1 2010-05-17 Marek Safar <marek.safar@gmail.com>
3 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
4 delegate.cs: Member instance is resolved after member overload
5 definitely resolves static/instance property of member expression.
6 Fixes #545047, #358848, #456605, #460016, #603299
8 2010-05-12 Marek Safar <marek.safar@gmail.com>
11 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
12 details for nested anonymous methods stories.
14 2010-05-11 Marek Safar <marek.safar@gmail.com>
17 * namespace.cs: Don't report namespace collision.
19 2010-05-11 Marek Safar <marek.safar@gmail.com>
22 * class.cs, typespec.cs: Search full imported attribute hierarchy
25 2010-05-11 Marek Safar <marek.safar@gmail.com>
27 * namespace.cs: Ignore missing dependencies failure at
30 2010-05-11 Marek Safar <marek.safar@gmail.com>
33 * namespace.cs: Don't resolve using constraints too early.
35 2010-05-11 Marek Safar <marek.safar@gmail.com>
38 * generic.cs: Copy partial type constraints to partial container.
40 2010-05-10 Marek Safar <marek.safar@gmail.com>
43 * import.cs: Relax underlying enum field rules.
45 2010-05-10 Marek Safar <marek.safar@gmail.com>
48 * property.cs: Implement IParametersMember for indexer accessors.
50 2010-05-07 Marek Safar <marek.safar@gmail.com>
53 * class.cs: Update all partial modifiers.
55 2010-05-06 Marek Safar <marek.safar@gmail.com>
58 * method.cs, membercache.cs: Destructors cannot be hidden.
60 2010-05-06 Marek Safar <marek.safar@gmail.com>
63 * class.cs: Resursive reference of type definition is allowed.
65 2010-05-06 Marek Safar <marek.safar@gmail.com>
67 * anonymous.cs: Mutate cached storey instance types too.
69 2010-05-06 Marek Safar <marek.safar@gmail.com>
72 * convert.cs: Explicit enum conversion cannot involve user operators
74 2010-05-05 Miguel de Icaza <miguel@novell.com>
76 * class.cs (TypeContainer.DefineBaseTypes)
77 (TypeContainer.CheckRecursiveDefinition): check for the iface not
78 being null, as we could have failed resolution and crashed;
81 * cs-parser.jay: Productions to catch common mistakes when other
82 punctuation operators are used instead of comma. Fixes 571702
84 2010-05-05 Marek Safar <marek.safar@gmail.com>
86 * anonymous.cs: Mutate correct set of constraints.
88 2010-05-05 Marek Safar <marek.safar@gmail.com>
91 * expression.cs: Resolve all array bound arguments.
93 2010-05-05 Marek Safar <marek.safar@gmail.com>
95 * import.cs: Don't import private fields.
97 2010-04-30 Marek Safar <marek.safar@gmail.com>
99 Partially based on patch by <sami.lamti@gmail.com>
101 * eval.cs, ecore.cs: Fixed eval show methods.
103 2010-04-30 Marek Safar <marek.safar@gmail.com>
105 * generic.cs, delegate.cs: Implement output type inference of
106 methodgroup now when the specification was cleared at least little
109 2010-04-29 Marek Safar <marek.safar@gmail.com>
111 A fix for bug #575611
112 * class.cs: Fix recursive unmanaged recursice sruct check.
114 2010-04-29 Marek Safar <marek.safar@gmail.com>
116 A fix for bug #479776
117 * expression.cs: Implement typeof unbounded nested generic types.
119 2010-04-29 Marek Safar <marek.safar@gmail.com>
121 A fix for bug #474953
122 * class.cs: Fix valid recursive base type definition.
124 2010-04-29 Marek Safar <marek.safar@gmail.com>
126 A fix for bug #421737
127 * convert.cs, expression.cs: A boxing conversion exists from a
128 nullable-type to a reference type, if a boxing conversion exists
129 from the underlying non-nullable-value-type to the reference type.
131 2010-04-29 Marek Safar <marek.safar@gmail.com>
133 A fix for bug #376875
134 * import.cs: Import volatile modifier.
136 2010-04-29 Marek Safar <marek.safar@gmail.com>
138 A fix for bug #372412
139 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
142 2010-04-29 Marek Safar <marek.safar@gmail.com>
144 A fix for bug #568955
145 * statements.cs: Handle recursive scope initializers.
147 2010-04-28 Marek Safar <marek.safar@gmail.com>
149 A fix for bug #566511
150 * anonymous.cs: Always get inflated version of hoisted variable
151 on generic type definition.
153 2010-04-28 Marek Safar <marek.safar@gmail.com>
155 * import.cs, membercache.cs: Relax rules for valid properties.
157 2010-04-28 Marek Safar <marek.safar@gmail.com>
159 * import.cs: Intern arrays used in generic arguments.
161 2010-04-28 Marek Safar <marek.safar@gmail.com>
163 A fix for bug #600398
164 * convert.cs: Actually use effective base type for the comparison.
166 2010-04-28 Marek Safar <marek.safar@gmail.com>
168 A fix for bug #600326
169 * ecore.cs: Pass arity to base member lookup.
171 2010-04-28 Marek Safar <marek.safar@gmail.com>
173 A fix for bug #573385
174 * expression.cs: MemberAccess is of generic type based on right
177 2010-05-28 Marek Safar <marek.safar@gmail.com>
179 * cs-tokenizer.cs: Made tab size configurable.
181 2010-05-27 Marek Safar <marek.safar@gmail.com>
183 * attribute.cs: Ensure Obsolete members are defined before doing
186 2010-05-27 Marek Safar <marek.safar@gmail.com>
188 * visit.cs: Add DOM visitor skeleton.
192 2010-05-27 Marek Safar <marek.safar@gmail.com>
194 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
196 2010-05-27 Marek Safar <marek.safar@gmail.com>
198 * *.cs: Major rewrite of compiler internals to better work with
199 unmodified System.Reflection.Emit. Some of the key changes are
200 - TypeSpec replaces reflection specific System.Type.
201 - All Type(TypeSpec) operations are now done in compiler therefore
202 no dependency on SRE to inflate generic members and types or to
203 query unclosed types.
204 - MemberCache is now the only and full hierarchical topology.
205 - Generic constraints are implemented properly.
206 - And as a bonus compilation is on average 30% faster.
208 2010-04-15 Jb Evain <jbevain@novell.com>
210 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
212 2010-04-12 Marek Safar <marek.safar@gmail.com>
214 * expression.cs, attribute.cs, parameter.cs: More attribute type
217 2010-04-12 Marek Safar <marek.safar@gmail.com>
219 A fix for bug #593342
221 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
222 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
223 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
224 codegen.cs: Add custom attribute encoder to deal with unfinished
225 types and easier corlib bootstrap from its own types.
227 2010-03-26 Marek Safar <marek.safar@gmail.com>
229 * cs-parser.jay: Report invalid constraint types.
231 2010-03-16 Jb Evain <jbevain@novell.com>
233 * Makefile: rename the net_2_1 profile to moonlight.
235 2010-03-11 Marek Safar <marek.safar@gmail.com>
237 * statement.cs, cs-parser.jay: Use correct location for empty
240 2010-03-11 Marek Safar <marek.safar@gmail.com>
242 * cs-parser.jay: Disable Location from expression.
244 * generic.cs: Check constraints for overrides in the parser.
246 2010-03-09 Marek Safar <marek.safar@gmail.com>
248 * cs-parser.jay (GetLocation): Use an expression when available.
250 2010-03-04 Marek Safar <marek.safar@gmail.com>
252 A fix for bug #582579
253 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
255 2010-03-04 Marek Safar <marek.safar@gmail.com>
257 A patch by kornelpal@gmail.com
259 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
260 compiler generated classes sealed by default. Emit and close top
261 level compiler generated classes as well.
263 * support.cs: Use RuntimeHelpers.GetHashCode.
265 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
267 * Makefile: We need to use the internal bootstrapping gmcs for
268 net_2_1_bootstrap too now.
270 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
272 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
274 2010-03-02 Marek Safar <marek.safar@gmail.com>
276 * cs-tokenizer.cs: Missed few locations in previous fix.
278 2010-03-02 Marek Safar <marek.safar@gmail.com>
280 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
281 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
282 Report correct location for operator errors.
284 2010-03-02 Marek Safar <marek.safar@gmail.com>
286 * typemanager.cs (IsDynamicType): Don't check external types when
287 the attribute is not external.
289 2010-02-24 Marek Safar <marek.safar@gmail.com>
291 A fix for bug #582579
292 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
295 2010-02-24 Marek Safar <marek.safar@gmail.com>
297 A fix for bug #581804
298 * ecore.cs: Fixed type comparison.
300 2010-02-08 Miguel de Icaza <miguel@novell.com>
302 * namespace.cs (CompletionGetTypesStartingWith): Do not include
303 private types in the completion results.
305 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
308 2010-02-17 Marek Safar <marek.safar@gmail.com>
310 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
313 2010-02-14 Miguel de Icaza <miguel@novell.com>
315 * eval.cs: Do not do the report printer dance unless the user has
316 set the DescribeTypes feature.
318 2010-02-10 Marek Safar <marek.safar@gmail.com>
320 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
322 2010-02-08 Marek Safar <marek.safar@gmail.com>
324 A fix for bug #577029
325 * anonymous.cs: Fixed TypeBuilder* check.
327 2010-02-06 Miguel de Icaza <miguel@novell.com>
329 * eval.cs (CompileBlock): Also undo if there are problems during
330 semantic analysis, fixes various cases where invalid C# code would
331 be reported, but the internal changes would not be undone.
333 2010-02-03 Miguel de Icaza <miguel@novell.com>
335 * driver.cs: Change the --fatal flag to allow a number to be
336 passed, this ignores the first N fatal errors. Useful to debug
337 errors that do not happen on the first hit.
339 * cs-parser.jay (invocation_expression): accept both the
340 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
341 inside an invocation.
343 * driver.cs: Expose FatalErrors.
345 * eval.cs: Initialize the printer's Fatal property from the
346 Driver's FatalError flag, this allows csharp --fatal to work
349 Add support for calling Describe (typeof (TYPE)) if the expression
352 2010-02-02 Marek Safar <marek.safar@gmail.com>
354 A fix for bug #574991
355 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
358 2010-02-02 Marek Safar <marek.safar@gmail.com>
360 A fix for bug #575986
361 * expression.cs: Don't mutate typeof type definitions.
363 2010-01-28 Marek Safar <marek.safar@gmail.com>
365 * decl.cs: Use only one set of modifiers.
367 2010-01-26 Marek Safar <marek.safar@gmail.com>
369 A fix for bug #573329
370 * eval.cs: Don't disable error reporting completely on silent mode.
372 2010-01-25 Marek Safar <marek.safar@gmail.com>
374 A fix for bug #573312
375 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
376 pointer index of unknown size types greater than 2.
378 2010-01-15 Marek Safar <marek.safar@gmail.com>
380 * *.cs: Use only 1 member kind enum.
382 2010-01-15 Marek Safar <marek.safar@gmail.com>
384 * *.cs: Add event specification.
386 2010-01-14 Marek Safar <marek.safar@gmail.com>
388 * membercache.cs: Extracted from decl.cs.
390 * *.cs: Put more infrastructure in place.
392 2010-01-13 Marek Safar <marek.safar@gmail.com>
394 * *.cs: Add property specification, unused yet.
396 2010-01-13 Marek Safar <marek.safar@gmail.com>
398 * property.cs: Move all property based declarations into a new file.
400 2010-01-13 Marek Safar <marek.safar at gmail.com>
402 * expression.cs (Conditional): Resolve reduced expression.
404 2010-01-13 Marek Safar <marek.safar at gmail.com>
406 * *.cs: Introduced non-generic method specification.
408 2010-01-07 Marek Safar <marek.safar@gmail.com>
410 * method.cs: Move all method based declarations into a new file.
412 2010-01-07 Marek Safar <marek.safar@gmail.com>
414 * *.cs: Extract field specification.
416 2009-12-17 Marek Safar <marek.safar@gmail.com>
418 * field.cs: Extracted from class.cs
420 2009-12-15 Marek Safar <marek.safar@gmail.com>
422 * attribute.cs (GetFixedBuffer): Work on field definition only.
424 2009-12-15 Marek Safar <marek.safar@gmail.com>
426 * *.cs: Clean up NET_4_0 conditional where possible.
428 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
430 support.cs (DynamicType): Assembly property returns the assembly builder.
431 This is required due to how compiler context works in corlib.
433 2009-12-14 Marek Safar <marek.safar@gmail.com>
435 A fix for bug #564376
436 * assign.cs (LocalTemporary): Removed no longer needed special
439 2009-12-11 Marek Safar <marek.safar@gmail.com>
441 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
442 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
443 enum for easier debugging.
445 2009-12-10 Marek Safar <marek.safar@gmail.com>
447 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
450 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
453 2009-12-10 Marek Safar <marek.safar@gmail.com>
455 * cs-parser.jay, statement.cs: Handle parser error in code
458 2009-12-10 Marek Safar <marek.safar@gmail.com>
460 * ecore.cs: Ignore base imported methods when they are already
463 * eval.cs: Handle non-existent keys.
465 * report.cs, driver.cs: Make fatal work with console printer only.
467 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
469 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
471 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
473 * typemanager.cs: Add MakeGenericMethod that checks if the method
474 is really the generic method definition.
476 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
477 to inflate generic methods.
479 2009-12-08 Marek Safar <marek.safar@gmail.com>
481 A fix for bug #561149
482 * anonymous.cs: Use actual type parameters when checking for generic
485 2009-12-08 Marek Safar <marek.safar@gmail.com>
487 A fix for bug #561369
488 * expression.cs (DoNumericPromotion): Fixed typo.
490 2009-12-08 Marek Safar <marek.safar@gmail.com>
492 *.cs: Moving to generics world.
494 cs-parser.jay: Removed current_array_type.
496 2009-12-07 Marek Safar <marek.safar@gmail.com>
498 *.cs: Moving to generics world.
500 2009-12-04 Marek Safar <marek.safar@gmail.com>
502 *.cs: Moving to generics world (day 2).
504 2009-12-03 Marek Safar <marek.safar@gmail.com>
506 *.cs: Moving to generics world.
508 2009-12-02 Marek Safar <marek.safar@gmail.com>
510 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
511 Encode dynamic type attribute for elements where attributes cannot
514 2009-12-01 Marek Safar <marek.safar@gmail.com>
516 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
519 2009-12-01 Marek Safar <marek.safar@gmail.com>
521 A fix for bug #360455
522 * class.cs: Never report a unused warning for generic events to
523 workaround wrong expression type.
525 2009-11-30 Marek Safar <marek.safar@gmail.com>
527 A fix for bug #558305
528 * decl.cs, class.cs: Check partial method definitions using correct
531 2009-11-30 Marek Safar <marek.safar@gmail.com>
533 * argument.cs: Don't cache rarely used dynamic flag.
535 2009-11-27 Marek Safar <marek.safar@gmail.com>
537 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
539 2009-11-27 Marek Safar <marek.safar@gmail.com>
541 * ecore.cs (SimpleName): Removed no longer needed in_transit as
542 Resolve is now non-reentrant (saves ~0.6MB for corlib).
544 2009-11-26 Marek Safar <marek.safar@gmail.com>
546 A fix for bug #545081
547 * decl.cs: Check private nested types of nested types recursively.
549 2009-11-26 Marek Safar <marek.safar@gmail.com>
551 A fix for bug #558305
552 * location.cs: Ignore self referencing #line directive
554 2009-11-26 Marek Safar <marek.safar@gmail.com>
556 A fix for bug #558292
557 * class.cs: Allow single unsafe fixed buffer fields.
559 2009-11-26 Marek Safar <marek.safar@gmail.com>
561 * expression: Optimize few more zero-based operations.
563 2009-11-26 Marek Safar <marek.safar@gmail.com>
565 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
566 avoids boxing of literal values.
568 2009-11-26 Marek Safar <marek.safar@gmail.com>
570 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
571 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
572 codegen.cs: LocatedToken redesing to avoid excessive allocation and
573 boxing (saves ~7MB for corlib). Also fixes presise token location.
575 2009-11-25 Marek Safar <marek.safar@gmail.com>
577 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
580 2009-11-24 Marek Safar <marek.safar@gmail.com>
582 * expression.cs: Lower static array initializer barrier.
584 * support.cs, driver.cs: Share reader buffer.
586 2009-11-23 Marek Safar <marek.safar@gmail.com>
588 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
590 2009-11-23 Marek Safar <marek.safar@gmail.com>
592 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
593 cleanup some obsolete code.
595 2009-11-20 Marek Safar <marek.safar@gmail.com>
597 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
600 2009-11-20 Marek Safar <marek.safar@gmail.com>
602 * *.cs: Resolved expressions are never resolved again, this helps to
603 uncover some not easy to find bugs and improve the performance.
605 2009-11-19 Marek Safar <marek.safar@gmail.com>
607 * *.cs: Made constant expressions fully compatible with any other
610 2009-11-19 Marek Safar <marek.safar@gmail.com>
612 * *.cs: DoResolve is a worker method and has to be protected.
614 2009-11-18 Marek Safar <marek.safar@gmail.com>
616 * *.cs: More context specific handling.
618 2009-11-17 Marek Safar <marek.safar@gmail.com>
620 * *.cs: More context specific handling.
622 2009-11-16 Marek Safar <marek.safar@gmail.com>
624 * dynamic.cs, class.cs: Removed few fixed user types conversions.
626 * symbolwriter.cs: Uses public ILOffset.
628 2009-11-13 Marek Safar <marek.safar@gmail.com>
630 A fix for bug #553650
631 * generic.cs: Another missing TypeToCoreType, still too many to fix.
633 2009-11-13 Marek Safar <marek.safar@gmail.com>
635 A fix for bug #555170
637 * class.cs, delegate.cs, enum.cs: Constants have to be available
638 for parameters resolve.
640 2009-11-12 Marek Safar <marek.safar@gmail.com>
642 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
645 2009-11-12 Marek Safar <marek.safar@gmail.com>
647 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
648 with a statically known candidate set.
650 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
652 * generic.cs: Made type inflation for generic constraint checks
653 recursive. This fixes BGO #553655.
655 2009-11-11 Marek Safar <marek.safar@gmail.com>
657 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
660 2009-11-10 Marek Safar <marek.safar@gmail.com>
662 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
663 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
664 attribute.cs: Add some dynamic error checking.
666 2009-11-07 Marek Safar <marek.safar@gmail.com>
668 A fix for bug #553465
670 * expression.cs: Fixed mixed version of expression tree anonymous
673 2009-11-06 Marek Safar <marek.safar@gmail.com>
675 A fix for bug #553031
677 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
678 expression tree version of anonymous type with members declaration.
680 2009-11-05 Marek Safar <marek.safar@gmail.com>
682 * parameter.cs: Handle nullable parameter default expression.
684 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
685 class.cs, attribute.cs: Check for wrong dynamic arguments.
687 2009-11-05 Marek Safar <marek.safar@gmail.com>
689 * statement.cs: Dynamic statements.
691 2009-11-04 Marek Safar <marek.safar@gmail.com>
693 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
694 Compound assignments over dynamic type.
696 2009-11-03 Marek Safar <marek.safar@gmail.com>
698 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
699 constructor arguments.
701 2009-10-30 Marek Safar <marek.safar@gmail.com>
703 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
704 codegen.cs: Unary mutator on dynamic member access expression.
706 2009-10-29 Marek Safar <marek.safar@gmail.com>
708 A fix for bug #550580
709 * convert.cs: Don't eliminate explicit precission casts.
711 2009-10-28 Marek Safar <marek.safar@gmail.com>
713 A fix for bug #550404
715 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
716 expression.cs, statement.cs, ecore.cs: Quote any nested expression
719 2009-10-27 Marek Safar <marek.safar@gmail.com>
721 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
724 * class.cs: Allow nullable binary user operators.
726 2009-10-26 Marek Safar <marek.safar@gmail.com>
728 * expression.cs: Move binary expression optimization at the end of
731 2009-10-23 Marek Safar <marek.safar@gmail.com>
733 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
734 Separate NullConstant from NullLiteral.
736 2009-10-23 Marek Safar <marek.safar@gmail.com>
738 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
739 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
740 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
741 ModuleContainer. Add common unclosed member check routine.
743 2009-10-22 Marek Safar <marek.safar@gmail.com>
745 * argument.cs: Use literal flag for real literals only.
747 * dynamic.cs: Use correct return type for custom delegates.
749 2009-10-22 Marek Safar <marek.safar@gmail.com>
751 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
754 2009-10-22 Marek Safar <marek.safar@gmail.com>
756 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
758 2009-10-21 Marek Safar <marek.safar@gmail.com>
760 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
763 2009-10-21 Marek Safar <marek.safar@gmail.com>
765 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
768 2009-10-20 Marek Safar <marek.safar@gmail.com>
770 * argument.cs, dynamic.cs, expression.cs: Latest API update.
772 2009-10-19 Marek Safar <marek.safar@gmail.com>
774 * typemanager.cs, expression.cs: Dynamic array initializer.
776 2009-10-16 Marek Safar <marek.safar@gmail.com>
778 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
781 2009-10-16 Marek Safar <marek.safar@gmail.com>
783 A fix for bug #493523, #507067
784 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
785 standard nullable conversion using underlying standard conversion
786 and not full conversion.
788 2009-10-15 Marek Safar <marek.safar@gmail.com>
790 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
791 type in VerifyArgumentsCompat.
793 2009-10-15 Marek Safar <marek.safar@gmail.com>
795 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
796 Reject variable used with type arguments.
798 2009-10-14 Marek Safar <marek.safar@gmail.com>
800 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
801 Implement dynamic expressions assignment.
803 2009-10-14 Marek Safar <marek.safar@gmail.com>
805 * expression.cs: Build underlying expression when resolving unary
808 2009-10-14 Marek Safar <marek.safar@gmail.com>
810 * expression.cs: Emit enum array initializer using binary blob.
812 2009-10-08 Marek Safar <marek.safar@gmail.com>
814 * typemanager.cs, constant.cs: Optimize decimal constants which fit
817 2009-10-07 Marek Safar <marek.safar@gmail.com>
819 * typemanager.cs: Reset object_type.
821 * assign: Made SimpleAssign public.
823 2009-10-06 Marek Safar <marek.safar@gmail.com>
825 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
826 invocation assembly to IsThisOrFriendAssembly.
828 2009-10-05 Marek Safar <marek.safar@gmail.com>
830 * expression.cs: Equality comparison of generic parameter with
833 2009-10-05 Marek Safar <marek.safar@gmail.com>
835 A fix for bug #543570
836 * generic.cs: Import predefined constraints correctly.
838 2009-10-02 Marek Safar <marek.safar@gmail.com>
840 * ecore.cs: Don't crash on overloads with optional paremeters where
841 arguments count overflows.
843 * parameter.cs: Import optional parameter constants using optional
846 2009-10-01 Marek Safar <marek.safar@gmail.com>
848 * Makefile: Default is gmcs compiler.
850 2009-10-01 Marek Safar <marek.safar@gmail.com>
852 * cs-parser.jay: Fixed few NRE.
854 2009-10-01 Marek Safar <marek.safar@gmail.com>
856 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
858 2009-09-30 Marek Safar <marek.safar@gmail.com>
860 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
861 ShimExpression, ImplicitCast.
863 2009-09-30 Marek Safar <marek.safar@gmail.com>
865 A fix for bug #542959
866 * delegate.cs: Emit correct delegate instance variable when there
867 are static and non-static overloads.
869 2009-09-29 Marek Safar <marek.safar@gmail.com>
871 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
872 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
874 2009-09-28 Marek Safar <marek.safar@gmail.com>
876 A fix for bug #542487
877 * ecore.cs: Resolve extension methods hidden by properties.
879 2009-09-25 Marek Safar <marek.safar@gmail.com>
881 * expression.cs, ecore.cs: More dynamic binary expressions.
883 2009-09-22 Marek Safar <marek.safar@gmail.com>
885 * nullable.cs, expression.cs: Fixed null lifted conversion for
886 bitwise enum operations.
888 2009-09-22 Marek Safar <marek.safar@gmail.com>
890 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
891 values in checked context.
893 2009-09-22 Marek Safar <marek.safar@gmail.com>
895 * expression.cs, ecore.cs: Fixed array index constant conversion.
897 2009-09-20 Miguel de Icaza <miguel@novell.com>
899 * expression.cs: Do not crash when MemberLookup returns something
900 that is not a MemberExpr here. Report error 582 instead.
904 2009-09-18 Marek Safar <marek.safar@gmail.com>
906 * decl.cs, class.cs: Check protected property accessors.
908 2009-09-18 Marek Safar <marek.safar@gmail.com>
910 * dynamic.cs, assign.cs: Dynamic compound assignment.
912 2009-09-17 Marek Safar <marek.safar@gmail.com>
914 * expression.cs: Fixed compound assignment explicit conversion.
916 2009-09-17 Marek Safar <marek.safar@gmail.com>
918 * expression.cs, ecore.cs: Cannot infer variables from method group.
920 2009-09-16 Marek Safar <marek.safar@gmail.com>
922 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
923 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
924 codegen.cs: Dynamic binary operations scaffolding.
926 2009-09-15 Marek Safar <marek.safar@gmail.com>
928 * expression.cs: Fixes nullable promotion for enum type variables.
930 2009-09-11 Marek Safar <marek.safar@gmail.com>
932 * driver.cs, dynamic.cs: Reset more static variables.
934 2009-09-11 Marek Safar <marek.safar@gmail.com>
936 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
937 driver.cs: Introduced Expression::MakeExpression.
939 2009-09-11 Marek Safar <marek.safar@gmail.com>
941 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
943 2009-09-09 Marek Safar <marek.safar@gmail.com>
945 * eval.cs, report.cs: Use Console.Out for all eval error or warning
948 2009-09-09 Marek Safar <marek.safar@gmail.com>
950 A fix for bug #518707
951 * expression.cs (Is): Optimize only generic parameter type
952 expression probing value type generic parameter.
954 2009-09-09 Marek Safar <marek.safar@gmail.com>
956 A fix for bug #532571
957 * ecore.cs: Check for simple name type arguments used with
960 2009-09-08 Marek Safar <marek.safar@gmail.com>
962 A fix for bug #497421
963 * generic.cs (CheckConstraint): Don't use buildin types to check for
964 parameterless constructor.
966 2009-09-08 Marek Safar <marek.safar@gmail.com>
968 A fix for bug #537402
969 * generic.cs (CheckConstraint): Correctly inflate generic type
970 arguments when checking generic method.
972 2009-09-08 Marek Safar <marek.safar@gmail.com>
974 A fix for bug #536463
975 * decl.cs (AddToContainer): Don't report collision between explicit
976 and parameterless non-explicit members.
978 2009-09-08 Marek Safar <marek.safar@gmail.com>
980 * eval.cs: Reset more static stuff.
982 2009-09-07 Marek Safar <marek.safar@gmail.com>
984 A fix for bug #324625
985 * expression.cs, ecore.cs: Create nested generic type expression
986 using declaring and not current type.
988 2009-09-07 Marek Safar <marek.safar@gmail.com>
990 * *.cs: Changed Report class to accept various output printers and
991 be an instance class. An expression resolver can now use different
992 message reporter for each call and Report.Error can safely throw
993 an exception. Part of ongoing work to turn mcs into proper library.
995 2009-09-04 Marek Safar <marek.safar@gmail.com>
997 * statement.cs, ecore.cs: Removed error reporting from emit code.
999 2009-09-04 Marek Safar <marek.safar@gmail.com>
1001 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1003 2009-09-03 Marek Safar <marek.safar@gmail.com>
1005 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1006 parser checks out of constructors.
1008 2009-09-02 Marek Safar <marek.safar@gmail.com>
1010 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1012 2009-09-02 Marek Safar <marek.safar@gmail.com>
1014 A fix for bug #535448
1015 * anonymous.cs, class.cs: Copy return label between all contexts.
1017 2009-09-02 Marek Safar <marek.safar@gmail.com>
1019 A fix for bug #535395
1020 * namespace.cs: Resolve context can be null.
1022 2009-08-25 Marek Safar <marek.safar@gmail.com>
1024 A fix for bug #533912
1025 * generic.cs: Use correct context for constraints resolving.
1027 2009-08-25 Marek Safar <marek.safar@gmail.com>
1029 A fix for bug #532630
1030 * driver.cs: Trim conditional symbols.
1032 2009-08-25 Marek Safar <marek.safar@gmail.com>
1034 * context.cs: New file.
1036 * *.exe.sources, *.csproj: Updated.
1038 2009-08-25 Marek Safar <marek.safar@gmail.com>
1040 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1041 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1042 IMembercontext, some small cleanups.
1044 2009-08-24 Marek Safar <marek.safar@gmail.com>
1046 * *.cs: Split ResolveContext and EmitContext.
1048 2009-08-24 Marek Safar <marek.safar@gmail.com>
1050 * *.cs: Only ResolveContext implements IMemberContext.
1052 2009-08-21 Marek Safar <marek.safar@gmail.com>
1054 * *.cs: Renamed IResolveContext to IMemberContext.
1056 2009-08-21 Marek Safar <marek.safar@gmail.com>
1058 * *.cs: Detached ResolveContext from EmitContext.
1060 2009-08-21 Marek Safar <marek.safar@gmail.com>
1062 * codegen.cs: Moved flow-analysis to BlockContext.
1064 2009-08-21 Marek Safar <marek.safar@gmail.com>
1066 * *.cs: Detached BlockContext from EmitContext.
1068 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1070 * statement.cs: avoid nullref when the return value of GetEnumerator()
1071 does not contain any MoveNext() method.
1073 2009-08-19 Marek Safar <marek.safar@gmail.com>
1075 * *.cs: Removed IResolveContext::GenericDeclContainer.
1077 2009-08-19 Marek Safar <marek.safar@gmail.com>
1079 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1081 2009-08-19 Marek Safar <marek.safar@gmail.com>
1083 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1084 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1086 2009-08-18 Marek Safar <marek.safar@gmail.com>
1088 * *.cs: Removed boolean fields from EmitContext.
1090 2009-08-18 Marek Safar <marek.safar@gmail.com>
1092 * *.cs: Add IResolveContext::IsStatic.
1094 2009-08-18 Marek Safar <marek.safar@gmail.com>
1096 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1098 2009-08-17 Marek Safar <marek.safar@gmail.com>
1100 * *.cs: Removed DeclContainer from EmitContext.
1102 2009-08-17 Marek Safar <marek.safar@gmail.com>
1104 * *.cs: Add IResolveContext::CurrentTypeParameters.
1106 2009-08-14 Marek Safar <marek.safar@gmail.com>
1108 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1110 2009-08-14 Marek Safar <marek.safar@gmail.com>
1112 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1113 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1115 2009-08-13 Marek Safar <marek.safar@gmail.com>
1117 * decl.cs: Look in PartialContainer for parent type parameters.
1119 2009-08-13 Marek Safar <marek.safar@gmail.com>
1121 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1122 codegen.cs: Add IResolveContext::LookupTypeParameter.
1124 2009-08-13 Marek Safar <marek.safar@gmail.com>
1126 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1127 Moved resolved logic from Emit to Resolve.
1129 2009-08-13 Marek Safar <marek.safar@gmail.com>
1131 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1132 codegen.cs: Reworked atttributes handling of ResolveContext.
1134 2009-08-12 Marek Safar <marek.safar@gmail.com>
1136 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1137 LookupNamespaceOrType to ResolveContext.
1139 2009-08-12 Marek Safar <marek.safar@gmail.com>
1141 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1142 class.cs: Removed unused parameters and methods.
1144 2009-08-11 Marek Safar <marek.safar@gmail.com>
1146 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1147 codegen.cs: Finding the best common type of a set of expressions for
1150 2009-08-07 Marek Safar <marek.safar@gmail.com>
1152 * dynamic.cs, expression.cs: More dynamic conversions.
1154 2009-08-06 Miguel de Icaza <miguel@novell.com>
1156 * generic.cs: This loop was incorrect, it was increment ii, but
1157 checking for `i'. This was a change introduced to fix #327497,
1160 * class.cs: Catch another case for cs0533 error, fixes #324782.
1162 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1164 * typemanager.cs (GetGenericArguments): SRE returns null for
1165 generic methods on type builder instances if they are not generic
1166 themselves. For example, for Foo<int>::Bar() it returns null, but
1167 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1169 2009-08-05 Marek Safar <marek.safar@gmail.com>
1171 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1172 delegate.cs: Work on dynamic binding.
1174 2009-08-04 Marek Safar <marek.safar@gmail.com>
1176 A second fix for bug #525342
1177 * class.cs: Attach partial method attributes to method
1180 2009-08-03 Marek Safar <marek.safar@gmail.com>
1182 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1185 * rootcontext.cs: Default to langversion v4.
1187 2009-08-03 Marek Safar <marek.safar@gmail.com>
1189 * pending.cs: Check return type before member info is set.
1191 2009-08-03 Marek Safar <marek.safar@gmail.com>
1193 * anonymous.cs: Fully initialize generic hoisted field expression.
1195 2009-08-02 Miguel de Icaza <miguel@novell.com>
1197 * cs-parser.jay: Flag variables declared on the interactive shell
1198 as used to prevent the 168 warning about local variable not being
1201 2009-07-31 Marek Safar <marek.safar@gmail.com>
1203 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1204 attribute.cs: Emit dynamic export attribute.
1206 2009-07-30 Marek Safar <marek.safar@gmail.com>
1208 * expression.cs: More verifier work.
1210 2009-07-29 Marek Safar <marek.safar@gmail.com>
1212 * nullable.cs: Fixed SRE crash during corlib compilation.
1214 2009-07-29 Marek Safar <marek.safar@gmail.com>
1216 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1217 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1218 More TypeManager.TypeToCoreType needed.
1220 2009-07-29 Marek Safar <marek.safar@gmail.com>
1222 * anonymous.cs: Update after recent SRE fixes.
1224 2009-07-28 Marek Safar <marek.safar@gmail.com>
1226 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1227 version of GetFieldHandle for fields of generic types.
1229 2009-07-27 Marek Safar <marek.safar@gmail.com>
1231 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1232 ecore.cs: Add TypeManager.IsDynamicType,
1233 PredefinedAttributes.Dynamic.
1235 2009-07-27 Marek Safar <marek.safar@gmail.com>
1237 A fix for bug #415375
1238 * expression.cs: Fixed object and reference type parameter
1241 2009-07-27 Marek Safar <marek.safar@gmail.com>
1243 A fix for bug #525342
1244 * class.cs: Attach partial method attributes to method
1247 2009-07-24 Marek Safar <marek.safar@gmail.com>
1249 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1252 2009-07-24 Marek Safar <marek.safar@gmail.com>
1254 * anonymous.cs (MutateField): Add imported types handling.
1256 2009-07-23 Marek Safar <marek.safar@gmail.com>
1258 * expression.cs, delegate.cs: Moved arguments resolve into their
1259 counterparts expressions. Removed argument resolve from
1260 CollectionElementInitializer.
1262 2009-07-23 Marek Safar <marek.safar@gmail.com>
1264 A fix for bug #523683
1265 * convert.cs, delegate.cs: Use common overload mechanism for method
1266 group conversion check.
1268 2009-07-22 Marek Safar <marek.safar@gmail.com>
1270 A fix for bug #523899
1271 * generics.cs: Exact type inference with other bound types.
1273 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1275 Don't complain when the same type is implemented by the output
1276 assembly as well as multiple referenced assemblies
1277 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1278 'must_be_unique' flag.
1279 (GlobalRootNamespace): Update to changes.
1280 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1281 already have a type in hand.
1283 2009-07-22 Marek Safar <marek.safar@gmail.com>
1285 * expression.cs: More verifier instrumentation.
1287 * statement.cs: Do proper throw expression conversion.
1289 2009-07-22 Marek Safar <marek.safar@gmail.com>
1291 A fix for bug #522789
1292 * expression.cs: Mutate invocation return type.
1294 2009-07-16 Marek Safar <marek.safar@gmail.com>
1296 * anonymous.cs: Split assignable and readonly generated variable
1299 2009-07-16 Marek Safar <marek.safar@gmail.com>
1301 A fix for bug #521671
1302 * statement.cs: Fixed crash when checking missing type.
1304 2009-07-16 Marek Safar <marek.safar@gmail.com>
1306 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1307 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1308 class.cs, driver.cs: Work on dynamic binding.
1310 * dynamic.cs: New file.
1312 * *.sources, *.proj: Updated.
1314 2009-07-15 Marek Safar <marek.safar@gmail.com>
1316 * expression.cs (Conditional): Avoid double Resolve.
1318 2009-07-13 Marcus Griep <marcus@griep.us>
1320 * ecore.cs: Fix obscure bug with resolving members of interfaces
1321 that hide parent interface members. Fixes bug #444388 and corrects
1324 2009-07-13 Marek Safar <marek.safar@gmail.com>
1326 * expression.cs (LocalVariableReference): Bounce resolve.
1328 2009-07-10 Marek Safar <marek.safar@gmail.com>
1330 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1331 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1334 * support.cs: New dynamic type wrapper.
1336 2009-07-08 Marek Safar <marek.safar@gmail.com>
1338 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1339 typed local variable.
1341 2009-07-06 Marek Safar <marek.safar@gmail.com>
1343 A fix for bug #519005
1344 * anonymous.cs: Use null_type as no return type placeholder.
1346 2009-07-02 Marek Safar <marek.safar@gmail.com>
1348 * generic.cs: Handle type inference of identical type parameters
1349 with different bounds.
1351 2009-07-01 Marek Safar <marek.safar@gmail.com>
1353 * expression.cs, class.cs: Events variance.
1355 * cs-parser.jay: Interface events error messages.
1357 2009-07-01 Marek Safar <marek.safar@gmail.com>
1359 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1361 2009-06-29 Marek Safar <marek.safar@gmail.com>
1363 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1364 parameter expression can be value-type New.
1366 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1368 2009-06-26 Marek Safar <marek.safar@gmail.com>
1370 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1371 Implemented C# 4.0 named arguments.
1373 2009-06-24 Marek Safar <marek.safar@gmail.com>
1375 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1376 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1377 parameter modifier. Also fixes bug #515497.
1379 2009-06-24 Marek Safar <marek.safar@gmail.com>
1381 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1382 arguments expression to be implemented.
1384 *.sources: Add argument.cs
1386 2009-06-23 Marek Safar <marek.safar@gmail.com>
1388 * parameter.cs: Moved GetParameterIndexByName to base class.
1390 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1391 unused AType. Use argument's version of GetExpressionTree.
1393 2009-06-22 Marek Safar <marek.safar@gmail.com>
1395 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1398 2009-06-17 Marek Safar <marek.safar@gmail.com>
1400 A fix for bug #514096
1401 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1403 2009-06-17 Marek Safar <marek.safar@gmail.com>
1405 * expression.cs: The first multi-dimensional array nested array
1406 initializers was not checked.
1408 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1410 2009-06-17 Marek Safar <marek.safar@gmail.com>
1412 A fix for bug #513400
1413 * nullable.cs (EmitEquality): Operands emit could be simplified for
1414 built-in types when we now emit user operators differently.
1416 2009-06-16 Marek Safar <marek.safar@gmail.com>
1418 * ecore.cs: Report inaccessible delegate methods correctly.
1420 2009-06-16 Marek Safar <marek.safar@gmail.com>
1422 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1423 cs-parser.jay: Implemented C# 4.0 optional parameters.
1425 2009-06-16 Marek Safar <marek.safar@gmail.com>
1427 * driver.cs: Removed broken DefineManifestResource.
1429 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1431 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1432 Use $(BOOTSTRAP_PROFILE) instead.
1434 2009-06-12 Jb Evain <jbevain@novell.com>
1436 * rootcontext.cs: add a Platform field.
1437 * driver.cs: handle /platform.
1438 * codegen.cs: pass the proper flags according to
1439 the platform when saving the assembly.
1441 2009-06-11 Marek Safar <marek.safar@gmail.com>
1443 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1444 Add optional parameters grammar.
1446 2009-06-10 Marek Safar <marek.safar@gmail.com>
1448 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1449 driver.cs: Split lang version and metadata version.
1451 2009-06-10 Marek Safar <marek.safar@gmail.com>
1453 * decl.cs: Better overload ctor collision error message.
1455 2009-06-05 Jb Evain <jbevain@novell.com>
1457 * driver.cs (EmbededResource): avoid using an internal method
1458 in gmcs to embed manifest resources.
1460 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1462 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1463 the compiler from older mono versions (like moon's bots)
1465 2009-06-04 Marek Safar <marek.safar@gmail.com>
1467 * namespace.cs (LookupTypeReflection): Ignore collisions between
1470 2009-06-04 Marek Safar <marek.safar@gmail.com>
1472 * codegen.cs: Enabled generic type forwarders.
1474 2009-06-04 Marek Safar <marek.safar@gmail.com>
1476 * dmcs.*: Add another version of SRE compiler.
1478 2009-06-03 Marek Safar <marek.safar@gmail.com>
1480 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1481 generic-mcs.cs: Fixed variant type conversions.
1483 2009-06-02 Marek Safar <marek.safar@gmail.com>
1485 A fix for bug #507863
1486 * codegen.cs: Fixes a crash on invalid string value attribute.
1488 2009-06-01 Marek Safar <marek.safar@gmail.com>
1490 A fix for bug #508334
1491 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1492 cs-parser.jay: Fully import __arglist modifier.
1494 2009-05-29 Marek Safar <marek.safar@gmail.com>
1496 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1497 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1498 actually work with closed generic types.
1500 2009-05-27 Alan McGovern <amcgovern@novell.com>
1502 * class.cs, decl.cs, delegate.cs, parameter.cs:
1503 Fix the build by replacing the use of 'var' with the actual type.
1505 2009-05-27 Marek Safar <marek.safar@gmail.com>
1507 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1508 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1511 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1514 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1515 Marek Safar <marek.safar@gmail.com>
1517 A fix for bug #377509
1518 * parameter.cs: Use predefined and not empty name for implicit
1521 2009-05-21 Marek Safar <marek.safar@gmail.com>
1523 * class.cs: Don't report wrong warnings for event fields.
1525 2009-05-21 Marek Safar <marek.safar@gmail.com>
1527 A fix for bug #504667
1528 * class.cs: Check for static class using parent container instead of
1531 2009-05-08 Marek Safar <marek.safar@gmail.com>
1533 A fix for bug #496922
1534 * expression.cs: Always use temporary variable when using object
1537 2009-04-28 Marek Safar <marek.safar@gmail.com>
1539 A fix for bug #495112
1540 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1543 2009-04-27 Miguel de Icaza <miguel@novell.com>
1545 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1547 2009-04-24 Miguel de Icaza <miguel@novell.com>
1549 * complete.cs: No idea how gonzalo got a null in the list, but
1552 2009-04-24 Miguel de Icaza <miguel@novell.com>
1554 * complete.cs (CompletionElementInitializer): New completion class
1555 to support completing inside a C# 3 element initializer, so this
1556 allows completion for Silverlight situations where it is very
1559 new TextBlock () { Fo<TAB>
1561 (CompletionSimpleName): Expose the prefix that was
1562 passed to the simple name.
1564 * cs-parser.jay (object_or_collection_initializer): Add support
1565 for element_initializers.
1567 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1568 special case completion expressions as this method aggressively
1569 collects data before it operates, and errors were being thrown
1570 earlier than we were able to complete.
1572 2009-04-23 Miguel de Icaza <miguel@novell.com>
1574 * eval.cs: Make getcompletions silent and enable debugging output
1575 if the -v option is passed.
1577 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1578 Consider looking up the namespace that matches the prefix being
1581 This is part of the support for allowing completions like:
1582 `System.Co<TAB>' to complete to System.Console.
1584 * complete.cs (CompletionSimpleName.AppendResults): Make this
1587 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1589 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1590 COMPLETE_COMPLETION as internal.
1592 2009-04-17 Miguel de Icaza <miguel@novell.com>
1594 * complete.cs: Include namespace resolution in simple names as
1595 well as global types and types in the using scope in the
1598 * namespace.cs: Supporting infrastrcture to provide completions
1599 based on the current using scope.
1601 * eval.cs: Introduce an entry point that allows for initialization
1602 to return a list of the files passed on the command line.
1604 2009-04-14 Marek Safar <marek.safar@gmail.com>
1606 A fix for bug #494243
1607 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1609 2009-04-13 Marek Safar <marek.safar@gmail.com>
1611 A fix for bug #493887
1612 * statement.cs: Don't skip string multi-section with default or
1613 null label when populating string hashtable.
1615 2009-04-06 Marek Safar <marek.safar@gmail.com>
1617 A fix for bug #492329
1618 * expression.cs (New): Load variable when assigning type parameter
1621 2009-04-06 Marek Safar <marek.safar@gmail.com>
1623 A fix for bug #488960
1624 * decl.cs: Compare MVAR types using non-null values.
1626 2009-03-27 Marek Safar <marek.safar@gmail.com>
1628 * typemanager.cs, expression.cs: Removed unused nullable checks.
1630 2009-03-27 Marek Safar <marek.safar@gmail.com>
1632 * *.cs: Removed some gmcs conditionals.
1634 2009-03-26 Marek Safar <marek.safar@gmail.com>
1636 * generic.cs, support.cs: Moved generics stuff out of support.cs
1638 2009-03-24 Marek Safar <marek.safar@gmail.com>
1640 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1643 2009-03-23 Marek Safar <marek.safar@gmail.com>
1645 * attribute.cs: Consider all members for error reporting when
1646 checking named arguments.
1648 2009-03-23 Marek Safar <marek.safar@gmail.com>
1650 A fix for bug #487625
1651 * namespace.cs: Use a warning for all predefined type conflicts.
1653 2009-03-23 Marek Safar <marek.safar@gmail.com>
1655 A fix for bug #485706
1656 * statement.cs: Explicitly type catch type argument to pass verifier
1659 2009-03-22 Miguel de Icaza <miguel@novell.com>
1661 Initial support to provide code completion facilities to consumers
1662 of the evaluator API.
1664 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1665 support the completion engine. When we reach the end of the
1666 input stream instead of returning EOF, when this flag is true the
1667 tokenizer instead produces:
1669 One GENERATE_COMPLETION token: this token then must be
1670 handled in the grammar at every point where the user
1671 would likely request a completion.
1673 As many COMPLETE_COMPLETION tokens as necessary. These
1674 tokens are generated to assist the parser in unwinding and
1675 producing a valid parse tree.
1677 The parser rules do not have to be perfect, the parser needs to be
1678 augmented with judicious use of GENERATE_COMPLETION tokens to
1679 improve the areas where we can provide completion and the parser
1680 needs to add support for COMPLETE_COMPLETION tokens in productions
1683 It is common to not have enough support for COMPLETE_COMPLETION
1684 under certain rules and that even if we generated the
1685 GENERATE_COMPLETION token that the resulting tree will be invalid
1686 due to the missing rules that support COMPLETE_COMPLETION.
1688 The final EOF token is produced by having the parser notify the
1689 tokenizer when it reaches the root production that the next token
1692 * support.cs (CompletionResult): New Exception. This exception
1693 is thrown to return the completion results when one of the special
1694 completion expressions is reached.
1696 This exception is thrown by the completing ExpressionStatements
1697 classes that live in complete.cs
1699 * complete.cs (CompletingExpression): a new base class for
1700 completing expressions. This derives from the
1701 ExpressionStatement class and not from Expression as it allows
1702 completion to happen not only where expressions are expected in
1703 the grammar, but also where statements are expected.
1705 (CompletionSimpleName): A new class used to provide completions
1706 for SimpleNames. This currently only resolves to local
1707 variables from the evaluator context (GetVars call).
1709 (CompletionMemberAccess): Implements support for completing member
1712 * cs-parser.jay: Add support for completion in a few places.
1714 * eval.cs (GetCompletions): New public API for the evaluator that
1715 returns a list of possible completions given the input. The
1716 return value is an array of completions
1718 * anonymous.cs (Compatible): If the exception thrown from the
1719 resolved expression is a CompletionResult exception let that one
1720 through instead of printing a diagnostic error in the try/catch.
1722 2009-03-22 Miguel de Icaza <miguel@novell.com>
1726 * driver.cs (Main): Use Environment.Exit to quit quickly and
1727 prevent the compiler from doing the usual wait for helper thread
1730 This is to prevent a slowdown that was reported by Gonzalo on
1733 2009-03-19 Marek Safar <marek.safar@gmail.com>
1735 * ecore.cs: Load build-in types directly instead of accessing
1738 2009-03-18 Marek Safar <marek.safar@gmail.com>
1740 * ecore.cs: Always use unbox.any when available.
1742 2009-03-18 Marek Safar <marek.safar@gmail.com>
1744 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1746 2009-03-17 Marek Safar <marek.safar@gmail.com>
1748 * generic.cs: Removed obsolete version of type inference.
1750 2009-03-16 Marek Safar <marek.safar@gmail.com>
1752 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1753 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1754 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1755 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1757 2009-03-11 Marek Safar <marek.safar@gmail.com>
1759 A fix for bug #482996
1760 * anonymous.cs: Make sure we are not infering return type when
1761 checking type compatibility.
1763 2009-03-11 Marek Safar <marek.safar@gmail.com>
1765 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1766 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1767 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1768 attributes in their own structure. Needed when accessing their
1769 properties before they are resolved.
1771 2009-03-09 Marek Safar <marek.safar@gmail.com>
1773 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1774 hashtable (~10x faster).
1776 * driver.cs: Removed wrong Reset.
1778 2009-03-08 Marek Safar <marek.safar@gmail.com>
1780 * class.cs: Use correct common base type for unmanaged delayed
1783 * rootcontext.cs: Wrap unhandled exception.
1785 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1787 Make SeekableStreamReader self-tuning and arbitrarily seekable
1788 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1790 (SeekableStreamReader.Position.set): Use it. Simplify logic
1791 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1792 buffer size when the stream needs to be re-read from the beginning.
1794 2009-03-05 Marek Safar <marek.safar@gmail.com>
1796 A fix for bug #480100
1797 * parameter.cs: A parameter is not hoisted when used directly as ET.
1799 2009-03-04 Marek Safar <marek.safar@gmail.com>
1801 * statement.cs: Fixed an issue when using variable is of interface
1804 2009-03-03 Marek Safar <marek.safar@gmail.com>
1806 A fix for bug #480319
1807 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1809 2009-03-03 Marek Safar <marek.safar@gmail.com>
1811 A fix for bug #480867
1812 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1813 expression to have no valid type.
1815 2009-03-03 Marek Safar <marek.safar@gmail.com>
1817 A fix for bug #481258
1818 * class.cs: Set extension method flag in partial container.
1820 2009-03-03 Marek Safar <marek.safar@gmail.com>
1822 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1824 * attribute.cs: Add sanity check.
1826 2009-02-27 Marek Safar <marek.safar@gmail.com>
1828 * class.cs: Add external constructor error.
1830 2009-02-26 Marek Safar <marek.safar@gmail.com>
1832 A fix for bug #475354
1833 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1834 correctly user defined nullable equality operators.
1836 2009-02-25 Marek Safar <marek.safar@gmail.com>
1838 A fix for bug #479532
1839 * expression.cs: Implement NewInitialize::AddressOf.
1841 2009-02-25 Marek Safar <marek.safar@gmail.com>
1843 A fix for bug #413633
1844 * expression.cs: Iterate all base class-constraint types.
1846 2009-02-24 Marek Safar <marek.safar@gmail.com>
1848 A fix for bug #479209
1849 * literal.cs: Mutate null underlying type.
1851 2009-02-24 Marek Safar <marek.safar@gmail.com>
1853 A fix for bug #476295
1854 * convert.cs: Avoid wrapping implicitly convertible reference type.
1856 2009-02-23 Marek Safar <marek.safar@gmail.com>
1858 * iterators.cs: Create MemberName correctly.
1860 2009-02-23 Marek Safar <marek.safar@gmail.com>
1862 A fix for bug #478655
1863 * literal.cs: Check also underlying null type conversion.
1865 2009-02-21 Marek Safar <marek.safar@gmail.com>
1867 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1869 2009-02-20 Marek Safar <marek.safar@gmail.com>
1871 A fix for bug #477447
1872 * statement.cs: Add reference to correct parent storey when this
1873 is accessible from deep children storey (more than 1 level).
1875 2009-02-19 Marek Safar <marek.safar@gmail.com>
1877 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1878 * class.cs: Define base type members before setting up member cache.
1880 2009-02-18 Marek Safar <marek.safar@gmail.com>
1882 A fix for bug #477378
1883 * nullable.cs, expression.cs, statement.cs: More precise null type
1886 2009-02-18 Marek Safar <marek.safar@gmail.com>
1888 A fix for bug #472805
1889 * typemanager.cs, namespace.cs: Import only visible extension method
1892 2009-02-18 Marek Safar <marek.safar@gmail.com>
1894 A fix for bug #476895
1895 * attribute.cs: Use correct resolve context for attribute type.
1897 2009-02-18 Marek Safar <marek.safar@gmail.com>
1899 A fix for bug #476266
1900 * anonymous.cs: Mutate multi-dimensional arrays.
1902 2009-02-18 Marek Safar <marek.safar@gmail.com>
1904 A fix for bug #476400
1905 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1907 2009-02-18 Marek Safar <marek.safar@gmail.com>
1909 A fix for bug #476811
1910 * generics.cs: Fixed null-literal check.
1912 2009-02-17 Marek Safar <marek.safar@gmail.com>
1914 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1915 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1916 messing with static variables.
1918 2009-02-16 Marek Safar <marek.safar@gmail.com>
1920 A fix for bug #475965
1921 * generics.cs: Check generic parameter type after extracting from
1924 2009-02-16 Marek Safar <marek.safar@gmail.com>
1926 A fix for bug #475823
1927 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1930 2009-02-14 Marek Safar <marek.safar@gmail.com>
1932 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1933 Simplified event field definition using backing field and not
1934 field builder directly.
1936 * expression.cs (EmitLdArg): Optimize fast paths.
1938 2009-02-13 Marek Safar <marek.safar@gmail.com>
1940 A fix for bug #475327
1941 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1943 2009-02-13 Marek Safar <marek.safar@gmail.com>
1945 A fix for bug #475342
1946 * cs-parser.jay: Using 'super' instead of 'base' to call base
1947 constructor crashes compiler.
1949 2009-02-13 Marek Safar <marek.safar@gmail.com>
1951 A fix for bug #475354
1952 * expression.cs (Constantify): Add nullable types.
1954 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1956 2009-02-12 Marek Safar <marek.safar@gmail.com>
1958 A fix for bug #475246
1959 * expression.cs: More broken flowanalysis hacking needed.
1961 2009-02-12 Marek Safar <marek.safar@gmail.com>
1963 * attribute.cs: Compare only ref/out array modifiers.
1965 2009-02-11 Marek Safar <marek.safar@gmail.com>
1967 * statement.cs: Use member cache when looking for foreach members.
1969 2009-02-11 Marek Safar <marek.safar@gmail.com>
1971 * expression.cs: Don't expose internal initializer types.
1973 * statement.cs: Check also explicit conversions for goto case.
1975 2009-02-11 Marek Safar <marek.safar@gmail.com>
1977 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1979 2009-02-10 Marek Safar <marek.safar@gmail.com>
1981 * *.cs: Replace null-type with NullLiteral where appropriate.
1983 2009-02-09 Marek Safar <marek.safar@gmail.com>
1985 * expression.cs: Initializer of reference argument use temporary
1986 variable to be verifiable.
1988 * parameter.cs: Share EmitLdArg.
1990 2009-02-09 Marek Safar <marek.safar@gmail.com>
1992 A fix for bug #473559
1993 * class.cs: Fixed: Not reporting error about nested class with the
1996 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1998 Contributed under the MIT/X11 license.
2000 * generic.cs: Added VerifyVariantTypeParameters which performs new
2001 variance verification logic. The old logic, based on the spec, was
2002 wrong because the spec is full of LIES!
2004 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2006 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2009 * ecore.cs: Added calls to the new variance verification logic.
2012 * delegate.cs: Removed calls to the old variance verification logic.
2014 2009-02-06 Marek Safar <marek.safar@gmail.com>
2016 * delegate.cs: Use cached Invoke method directly.
2018 2009-02-06 Marek Safar <marek.safar@gmail.com>
2020 * expression.cs: Emit expression tree for hoisted variable access.
2022 2009-02-04 Marek Safar <marek.safar@gmail.com>
2024 * namespace.cs: Add better extension class check.
2026 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2028 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2030 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2032 This patch adds initial generic variance support to the compiler.
2033 It is contributed under the MIT/X11 license.
2035 * typemanager.cs: Modified ImplementsInterface to check variance.
2036 Added VerifyVariantTypeParameters which checks the specified type to see
2037 if it uses a variant type parameter as a type argument (which is not
2038 allowed). Added IsVariantOf which determins if the first type is a
2039 variant of the second. NOTE: This only supports reference types at
2040 the moment to conform with the current level of VM support. When the
2041 VM supports value types, this will follow step.
2043 * generic.cs: Added the Variance enum. Added a Variance property to
2044 TypeParameter and added variance support to definition phase. Added a
2045 Variance property to TypeParameterName. Also check to make sure that
2046 no variant types appear in generic method parameters.
2048 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2049 keywords if the langversion supports it.
2051 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2052 that variant types are only used in legal positions. Also added
2053 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2056 * decl.cs: Construct TypeParameter with the variance information.
2058 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2059 and ImplicitConversionStandard.
2061 * rootcontext.cs: Added new "Future" language version.
2063 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2064 type parameters are not used as type arguments in interface inheritance.
2065 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2066 parameters are not used as method return types. In MemberBase.
2067 ResolveMemberType, ensure that variant type parameters are not used
2068 as type arguments. Also call VerifyNoVariantTypeParameters on every
2069 set of parameters which are resolved.
2071 * delegate.cs: Modified Delegate.Define to ensure that variant
2072 parameters are not used as type arguments and that a contravariant
2073 parameter is not used as the return type. Also call
2074 VerifyNoVariantTypeParameters on the delegate parameters.
2076 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2077 to specify generic variance.
2079 * driver.cs: Added support for LanguageVersion.Future in the form of
2080 "-langversion:future".
2082 * generic-mcs.cs: Stubbed out new members in generic.cs.
2084 2009-02-03 Marek Safar <marek.safar@gmail.com>
2086 * class.cs, generic.cs: Emit type parameter constraints for nested
2089 2009-02-02 Marek Safar <marek.safar@gmail.com>
2091 A fix for bug #471213
2092 * class.cs: Avoid emitting backing field for abstract event fields.
2094 2009-02-01 Marek Safar <marek.safar@gmail.com>
2096 A fix for bug #359731
2097 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2100 2009-01-30 Marek Safar <marek.safar@gmail.com>
2102 A fix for bug #470767
2103 * statement.cs: Introduced BlockScopeExpression, needed when
2104 expression tree conversion has to emit scope variables.
2106 2009-01-29 Marek Safar <marek.safar@gmail.com>
2108 * class.cs: Remove duplicate CallingConvention.
2110 2009-01-29 Marek Safar <marek.safar@gmail.com>
2112 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2113 when I finally found the right naming convention.
2115 2009-01-29 Marek Safar <marek.safar@gmail.com>
2117 * cs-tokenizer.cs: Put back different open parens optimization.
2119 2009-01-28 Marek Safar <marek.safar@gmail.com>
2121 A fix for bug #470227
2122 * cs-tokenizer.cs: Remove too agressive parser optimization.
2124 2009-01-28 Marek Safar <marek.safar@gmail.com>
2126 A fix for bug #324319
2127 * class.cs: Remove too early base type resolve.
2129 2009-01-27 Marek Safar <marek.safar@gmail.com>
2131 A fix for bug #324319
2132 * ecore.cs: Explicitly type null when assigning to type argument to
2133 make pass verifier check.
2135 2009-01-27 Marek Safar <marek.safar@gmail.com>
2137 * anonymous.cs: Fixed recent regression when initializing captured
2140 2009-01-26 Marek Safar <marek.safar@gmail.com>
2142 A fix for bug #469019
2143 * anonymous.cs: Use all parent type parameters when instantiating
2144 nested generic storey.
2146 2009-01-26 Marek Safar <marek.safar@gmail.com>
2148 * expression.cs: Check for null instance methodgroup expression.
2150 2009-01-26 Marek Safar <marek.safar@gmail.com>
2152 A fix for bug #469244
2153 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2154 instance inside a conditional expression.
2156 2009-01-23 Marek Safar <marek.safar@gmail.com>
2158 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2159 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2160 GetElementType and HasElementType. IsValueType clean up.
2162 2009-01-23 Marek Safar <marek.safar@gmail.com>
2164 * nullable.cs: Use common EmitCall.
2166 * expression.cs: Emit constraint. for virtual calls only.
2168 2009-01-23 Marek Safar <marek.safar@gmail.com>
2170 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2171 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2172 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2175 2009-01-22 Jb Evain <jbevain@novell.com>
2177 * anonymous.cs: make anonymous types' ToString implementation
2178 match what csc outputs.
2180 2009-01-21 Marek Safar <marek.safar@gmail.com>
2182 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2185 2009-01-17 Marek Safar <marek.safar@gmail.com>
2187 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2190 2009-01-16 Marek Safar <marek.safar@gmail.com>
2192 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2195 2009-01-15 Marek Safar <marek.safar@gmail.com>
2197 A fix for bug #466634
2198 * statement.cs: Add reference for nested storey when only this
2201 2009-01-15 Marek Safar <marek.safar@gmail.com>
2203 A fix for bug #466474
2204 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2207 2009-01-15 Marek Safar <marek.safar@gmail.com>
2209 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2210 Fixed nested stories parent referencing process. Also fixes #463985.
2212 2009-01-06 Marek Safar <marek.safar@gmail.com>
2214 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2215 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2216 implementation. Also fixes #463108.
2218 2009-01-05 Marek Safar <marek.safar@gmail.com>
2220 A fix for bug #416109
2221 * decl.cs: Issue correct CLSAttribute warning location.
2223 2009-01-05 Marek Safar <marek.safar@gmail.com>
2225 A fix for bug #456775
2226 * attribute.cs: Use attribute owner scope when resolving attribute
2229 2009-01-05 Marek Safar <marek.safar@gmail.com>
2231 A fix for bug #457257
2232 * decl.cs: Fixed incorrect member declaring type comparison.
2234 2009-01-05 Marek Safar <marek.safar@gmail.com>
2236 A fix for bug #460896
2237 * driver.cs: Handle /RES resources as embeddable.
2239 2009-01-05 Marek Safar <marek.safar@gmail.com>
2241 A fix for bug #462515
2242 * ecore.cs: Report inacessible members upwards.
2244 2009-01-05 Marek Safar <marek.safar@gmail.com>
2246 A fix for bug #463190, #463192
2247 * decl.cs, namespace.cs: Also import internal extension classes.
2249 2009-01-04 Marek Safar <marek.safar@gmail.com>
2251 A fix for bug #463415
2252 * generic.cs: Use right index for RemoveDependentTypes.
2254 2009-01-02 Marek Safar <marek.safar@gmail.com>
2256 A fix for bug #463196
2257 * expression.cs: Fixed enum to null comparison.
2259 2009-01-02 Marek Safar <marek.safar@gmail.com>
2261 A fix for bug #463121
2262 * nullable.cs: Fixed nullable user equality operator comparison.
2264 2009-01-02 Marek Safar <marek.safar@gmail.com>
2266 A fix for bug #462950
2267 * class.cs, decl.cs: Use full explicit name when defining automatic
2268 property backing field.
2270 2009-01-02 Marek Safar <marek.safar@gmail.com>
2272 A fix for bug #462592
2273 * pending.cs: Emit type arguments for generic proxy method.
2275 2008-12-30 Marek Safar <marek.safar@gmail.com>
2277 * expression.cs (As): Mutate all type arguments.
2279 2008-12-29 Marek Safar <marek.safar@gmail.com>
2281 A fix for bug #462622
2282 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2285 2008-12-29 Marek Safar <marek.safar@gmail.com>
2287 A fix for bug #450782
2288 * ecore.cs: Consider more variables of form V.I to be fixed.
2290 2008-12-29 Marek Safar <marek.safar@gmail.com>
2292 A fix for bug #460712
2293 * typemanager.cs: Core types could be imported.
2295 2008-12-28 Marek Safar <marek.safar@gmail.com>
2297 A fix for bugs #460847, #460772, #458049, #457339, #447807
2298 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2299 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2300 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2301 user lambdas used inside query clauses.
2303 2008-12-18 Marek Safar <marek.safar@gmail.com>
2305 A fix for bug #460229
2306 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2308 2008-12-18 Marek Safar <marek.safar@gmail.com>
2310 A fix for bug #459952
2311 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2313 2008-12-18 Marek Safar <marek.safar@gmail.com>
2315 A fix for bug #459630
2316 * convert.cs: Enum to valuetype conversion is not allowed.
2318 2008-12-18 Marek Safar <marek.safar@gmail.com>
2320 A fix for bug #457087
2321 * generic.cs: Don't crash when constraint comes from type
2324 2008-12-16 Marek Safar <marek.safar@gmail.com>
2326 A fix for bug #459221
2327 * anonymous.cs, statement.cs: Delay only captured this
2330 2008-12-12 Marek Safar <marek.safar@gmail.com>
2332 A fix for bug #457489
2333 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2334 and initialization to capture scope initializers correctly.
2336 2008-12-11 Marek Safar <marek.safar@gmail.com>
2338 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2339 ParameterReference refactoring.
2341 2008-12-03 Marek Safar <marek.safar@gmail.com>
2343 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2344 to be imported from any assembly.
2346 2008-12-03 Marek Safar <marek.safar@gmail.com>
2348 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2349 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2350 from anonymous method and lambda expression.
2352 2008-12-01 Marek Safar <marek.safar@gmail.com>
2354 A fix for bug #448560
2355 * expression.cs (As): Box any generic type arguments to be
2358 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2360 Add tripwire for implicit conversion bugs
2361 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2363 (MethodGroupExpr.OverloadResolve): Add sanity check between
2364 IsApplicable and VerifyArgumentsCompat.
2365 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2367 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2369 Fix build break in System.Data_test
2370 * convert.cs (ImplicitConversionExists): Move NullLiteral
2372 (ImplicitStandardConversionExists): ... here.
2374 2008-11-28 Marek Safar <marek.safar@gmail.com>
2376 * literal.cs: Emit correctly explicit null to nullable cast.
2378 2008-11-28 Marek Safar <marek.safar@gmail.com>
2380 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2383 2008-11-28 Marek Safar <marek.safar@gmail.com>
2385 A fix for bug #449005
2386 * convert.cs, nullable.cs: Use only one implicit nullable
2389 2008-11-27 Marek Safar <marek.safar@gmail.com>
2391 * convert.cs, literal.cs: More Convert cleanup is needed.
2393 2008-11-27 Marek Safar <marek.safar@gmail.com>
2395 * decl.cs, class.cs: Fixed misleading error message.
2397 2008-11-26 Marek Safar <marek.safar@gmail.com>
2399 A fix for bug #449005
2400 * nullable.cs (EmitEquality): Disable optimization for user operator
2403 2008-11-25 Marek Safar <marek.safar@gmail.com>
2405 A fix for bug #447027
2406 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2407 with context variables stored as expression instances.
2409 2008-11-25 Marek Safar <marek.safar@gmail.com>
2411 A fix for bug #447027
2412 * delegate.cs: Fixed delegate VerifyMethod logic.
2414 2008-11-24 Marek Safar <marek.safar@gmail.com>
2416 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2419 2008-11-21 Marek Safar <marek.safar@gmail.com>
2421 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2422 member type resolve to follow normal flow, instead of random
2425 2008-11-21 Marek Safar <marek.safar@gmail.com>
2427 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2430 2008-11-21 Marek Safar <marek.safar@gmail.com>
2432 * const.cs: Emit decimal array constant as literal.
2434 2008-11-20 Marek Safar <marek.safar@gmail.com>
2436 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2438 2008-11-19 Marek Safar <marek.safar@gmail.com>
2440 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2441 into real property (saves 8 MB for corlib compilation).
2443 2008-11-19 Marek Safar <marek.safar@gmail.com>
2445 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2446 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2447 generic-mcs.cs: Small cleanup of TypeArguments.
2449 2008-11-18 Marek Safar <marek.safar@gmail.com>
2451 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2452 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2453 of ConstructedType expression, renamed to GenericTypeExpr.
2455 2008-11-17 Marek Safar <marek.safar@gmail.com>
2457 A fix for bug #445303
2458 * location.cs (IsConditionalDefined): Handle undefined global
2461 2008-11-17 Marek Safar <marek.safar@gmail.com>
2463 A fix for bug #444678
2464 * expression.cs (TryReduceConstant): Always create new constant
2467 2008-11-17 Marek Safar <marek.safar@gmail.com>
2469 A fix for bug #444673
2470 * ecore.cs: Ignore open generic types when used as generic type
2473 2008-11-17 Marek Safar <marek.safar@gmail.com>
2475 A fix for bug #445458
2476 * expression.cs, cs-parser.jay: Don't crash when an expression
2479 2008-11-17 Marek Safar <marek.safar@gmail.com>
2481 A fix for bug #445464
2482 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2483 inside unbound type.
2485 2008-11-14 Jb Evain <jbevain@novell.com>
2487 * driver.cs: ignore empty -nowarn argument such as
2488 the one in -nowarn:12,13,,.
2490 2008-11-13 Marek Safar <marek.safar@gmail.com>
2492 A fix for bug #444271
2493 * anonymous.cs: Rescan parent storeys when best candidate was
2496 2008-11-13 Marek Safar <marek.safar@gmail.com>
2498 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2499 useless UnboundTypeExpression.
2501 * attribute.cs: Do check obsolete attribute on generic types.
2503 2008-11-12 Marek Safar <marek.safar@gmail.com>
2505 A fix for bugs #425680, #400139
2506 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2509 2008-11-11 Marek Safar <marek.safar@gmail.com>
2511 A fix for bug #435747
2512 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2513 compound value types assignment. Few micro optimizations added.
2515 2008-11-10 Marek Safar <marek.safar@gmail.com>
2517 A fix for bug #442610
2518 * anonymous.cs (MutateConstructor): More SRE hacking.
2520 2008-11-10 Marek Safar <marek.safar@gmail.com>
2522 A fix for bug #442579
2523 * ecore.cs: Also initialize expanded form of a method with 1 params
2526 2008-11-06 Marek Safar <marek.safar@gmail.com>
2528 * expression.cs (UnaryMutator): Do early l-side check.
2530 2008-11-05 Miguel de Icaza <miguel@novell.com>
2532 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2533 Init, otherwise we would crash later on when checking for friend
2536 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2537 Otherwise we never get any meaningful information as to what
2540 2008-11-05 Marek Safar <marek.safar@gmail.com>
2542 A fix for bug #436318
2543 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2545 2008-11-05 Miguel de Icaza <miguel@novell.com>
2547 * namespace.cs: Turns out that it was a really bad idea to hide
2548 the errors for namespaces not found here in eval mode.
2550 * eval.cs: When we process using clauses, only enter those into
2551 the list of valid using clauses after they have been validated.
2553 The above change gives the proper semantics: it does not
2554 senselessly report the same errors with broken using statements by
2555 never storing them in the first place when they are invalid.
2557 2008-11-05 Marek Safar <marek.safar@gmail.com>
2559 A fix for bug #421839
2560 * cs-parser.jay: Remove expression from coalesce rule to force lower
2561 priority than the assignment operator.
2563 2008-11-05 Marek Safar <marek.safar@gmail.com>
2565 A fix for bug #437875
2566 * nullable.cs: Compile correctly method group operand used with null
2567 coalescing operator.
2569 2008-11-04 Marek Safar <marek.safar@gmail.com>
2571 A fix for bug #434589
2572 * expression.cs (Binary): Ignore lifted conversions when at least
2573 one operand is of reference type.
2575 2008-11-04 Marek Safar <marek.safar@gmail.com>
2577 * cs-parser.jay: Better syntax error report.
2579 2008-11-03 Marek Safar <marek.safar@gmail.com>
2581 A fix for bug #436792
2582 * cs-parser.jay: Use GetLocation to access location.
2584 2008-11-03 Marek Safar <marek.safar@gmail.com>
2586 A fix for bug #440774
2587 * cs-parser.jay: Also set current_array_type when parsing local
2590 2008-11-03 Marek Safar <marek.safar@gmail.com>
2592 A fix for bug #440785
2593 * expression.cs (As): Don't resolve self modifing expression
2596 2008-11-03 Marek Safar <marek.safar@gmail.com>
2598 A fix for bug #439447
2599 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2601 2008-11-03 Marek Safar <marek.safar@gmail.com>
2603 A fix for bug #437571
2604 * cs-parser.jay: Fixes internal error for invalid expression
2607 2008-10-17 Marek Safar <marek.safar@gmail.com>
2609 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2611 2008-10-17 Marek Safar <marek.safar@gmail.com>
2613 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2615 2008-10-17 Marek Safar <marek.safar@gmail.com>
2617 * cs-tokenizer.cs: More precise cast parsing.
2619 2008-10-16 Martin Baulig <martin@ximian.com>
2621 * anonymous.cs (AnonymousMethodStorey): Put back the
2622 `hoisted_locals' hashtable and use it in EmitType().
2624 2008-10-15 Marek Safar <marek.safar@gmail.com>
2626 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2627 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2630 2008-10-14 Marek Safar <marek.safar@gmail.com>
2632 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2634 2008-10-14 Marek Safar <marek.safar@gmail.com>
2636 * statement.cs: Mutate scope initializers.
2638 2008-10-14 Marek Safar <marek.safar@gmail.com>
2640 * expression.cs: Use typeless value for This constant.
2642 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2644 2008-10-14 Marek Safar <marek.safar@gmail.com>
2646 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2649 2008-10-13 Marek Safar <marek.safar@gmail.com>
2651 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2654 2008-10-13 Marek Safar <marek.safar@gmail.com>
2656 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2657 parser and tokenizer. Fixes many ambiguities including #433258.
2659 2008-10-10 Marek Safar <marek.safar@gmail.com>
2661 * cs-parser.jay: Fixed missing accessor recovery.
2663 2008-10-10 Marek Safar <marek.safar@gmail.com>
2665 A fix for bug #433701
2666 * expression.cs: Better error message.
2668 2008-10-10 Marek Safar <marek.safar@gmail.com>
2670 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2672 * Makefile: Disabled unused debug symbols.
2674 Also fixes: #320556, #321097, #321656, #321876, #351316
2676 2008-10-09 Miguel de Icaza <miguel@novell.com>
2678 * eval.cs: rename "<interactive>" to "{interactive}", to work
2679 around a requirement in the compiler that this be a valid
2680 filename, and in Windows it is not (433886).
2682 2008-10-09 Marek Safar <marek.safar@gmail.com>
2684 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2686 2008-10-08 Marek Safar <marek.safar@gmail.com>
2688 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2689 cs-parser.jay: Generic type declaration and type arguments cleanup.
2691 2008-10-05 Marek Safar <marek.safar@gmail.com>
2693 * cs-parser.jay: Allow parsing weird array creation construct.
2695 2008-10-05 Marek Safar <marek.safar@gmail.com>
2697 * cs-parser.jay: Conflicts reduction.
2699 2008-10-04 Marek Safar <marek.safar@gmail.com>
2701 * cs-parser.jay: Conflicts reduction.
2703 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2706 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2707 property. Add a 'count' hint about the use of the shared vector.
2708 Ensure that we don't leak out dirty bits.
2709 (UsageVector.MergeChild): Throw away information about variables
2711 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2713 2008-10-03 Marek Safar <marek.safar@gmail.com>
2715 A fix for bug #431746
2716 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2717 parameters when iterator is created.
2719 2008-10-03 Marek Safar <marek.safar@gmail.com>
2721 A fix for bug #431827
2722 * expression.cs: Fixed right based pointer arithmetic operations
2725 2008-10-03 Marek Safar <marek.safar@gmail.com>
2727 A fix for bug #353779
2728 * assign.cs, expression.cs: Fixed compound assignment conversions.
2730 2008-10-02 Marek Safar <marek.safar@gmail.com>
2732 A fix for bug #375262
2733 * statement.cs: Refactor ArrayForeach to be usable with string
2734 indexer. Optimized single dimentional arrays foreach.
2736 2008-10-02 Marek Safar <marek.safar@gmail.com>
2738 A fix for bug #431255
2739 * anonymous.cs, expression.cs: Removed broken optimization.
2741 2008-10-01 Marek Safar <marek.safar@gmail.com>
2743 * anonymous.cs: Use full type parameters of parent generic
2744 containers. Removed unnecessary AddParentStoreyReference call.
2746 2008-10-01 Marek Safar <marek.safar@gmail.com>
2748 A fix for bug #324702
2749 * class.cs: Use better shorter names for explicit interface member
2752 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2754 2008-10-01 Marek Safar <marek.safar@gmail.com>
2756 * expression.cs: Use new interface to check fixed expression.
2758 2008-10-01 Marek Safar <marek.safar@gmail.com>
2760 A fix for bug #421101
2761 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2762 interface to check for fixed fixed-buffers.
2764 2008-10-01 Marek Safar <marek.safar@gmail.com>
2766 A fix for bug #429264
2767 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2769 * delegate.cs: Removed unnecessary casts.
2771 2008-09-30 Marek Safar <marek.safar@gmail.com>
2773 A fix for bug #352151
2774 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2775 class.cs: Fixed already defined explicit interface members check.
2777 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2779 cs-tokenizer.cs: Fix typo.
2781 2008-09-28 Miguel de Icaza <miguel@novell.com>
2783 * eval.cs (InteractiveBase): The quit command now just sets a
2784 flag, instead of calling Environment.Exit(), it is milder on
2787 CompiledMethod is now in Mono.CSharp, not nested inside
2788 the Evaluator, it was inconvenient to use.
2790 2008-09-27 Miguel de Icaza <miguel@novell.com>
2792 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2793 code to be invoked without having to reparse.
2795 2008-09-27 Miguel de Icaza <miguel@novell.com>
2797 * ecore.cs: The recent changes to FieldExpr broke this as well.
2798 Fixes LINQ queries in the interactive shell.
2800 * Multiple files: indentation fixing for the Mono coding
2801 guidelines for the switch statement.
2803 * eval.cs: Make the Evaluator API thread safe.
2805 2008-09-26 Marek Safar <marek.safar@gmail.com>
2807 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2808 constructor parsing.
2810 2008-09-26 Marek Safar <marek.safar@gmail.com>
2812 A fix for bug #325326
2813 * statement.cs: Check possible mistaken empty statement using
2814 explicit blocks only.
2816 2008-09-25 Miguel de Icaza <miguel@novell.com>
2818 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2819 RootNamespace.ComputeNamespaces to update the internal list of
2820 namespaces, this is no longer done for us.
2822 (InteractiveBase): Use the Evaluator APIs instead of calling into
2825 2008-09-25 Marek Safar <marek.safar@gmail.com>
2827 A fix for bug #429264
2828 * expression.cs: Missing mutator for access to multidimensional
2831 2008-09-25 Marek Safar <marek.safar@gmail.com>
2833 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2836 * driver.cs: Missing input argument check.
2838 2008-09-25 Marek Safar <marek.safar@gmail.com>
2840 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2841 expression.cs, statement.cs, rootcontext.cs, class.cs,
2842 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2845 2008-09-24 Miguel de Icaza <miguel@novell.com>
2847 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2848 fully constructed FieldExpr, fixes the regression introduced in
2851 * ecore.cs, expression.cs: Plug back the eclass initialization as
2852 otherwise it regresses `csharp'.
2854 2008-09-24 Marek Safar <marek.safar@gmail.com>
2856 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2857 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2858 phase to resolve phase. It resolves problems with expression trees
2859 and fixes bugs #323796, #325156.
2861 2008-09-23 Marek Safar <marek.safar@gmail.com>
2863 * codegen.cs: Report better error when symbol writer is missing.
2865 2008-09-23 Marek Safar <marek.safar@gmail.com>
2867 * codegen.cs: Set .NET symbol writer.
2869 * decl.cs: Guard against null generic arguments.
2871 * report.cs: Don't report exactly same additional details.
2873 2008-09-22 Marek Safar <marek.safar@gmail.com>
2875 A fix for bug #324917
2876 * cs-parser.jay: Add missing multidimensional non-expression type
2879 2008-09-22 Marek Safar <marek.safar@gmail.com>
2881 A fix for bug #428191
2882 * anonymous.cs: Create an outer generic fields also for non-storey
2885 2008-09-22 Marek Safar <marek.safar@gmail.com>
2887 A fix for bug #378294
2888 * class.cs: Make fixed size buffers gmcs feature only.
2890 2008-09-22 Marek Safar <marek.safar@gmail.com>
2892 A fix for bug #355622, #324993
2893 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2896 2008-09-19 Marek Safar <marek.safar@gmail.com>
2898 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2901 2008-09-19 Marek Safar <marek.safar@gmail.com>
2903 A fix for bug #416110
2904 * generic.cs: Struct constraint results in default ctor and
2905 ValueType base type constraint to be set.
2907 2008-09-19 Marek Safar <marek.safar@gmail.com>
2909 A fix for bug #423791
2910 * generic.cs: Fixed params output type type-inference.
2912 2008-09-19 Marek Safar <marek.safar@gmail.com>
2914 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2916 2008-09-19 Marek Safar <marek.safar@gmail.com>
2918 * cs-tokenizer.cs: Don't break on extra partial modifier.
2920 2008-09-19 Marek Safar <marek.safar@gmail.com>
2922 A fix for bug #427592
2923 * generic.cs: Use common parameter resolve method.
2925 2008-09-18 Marek Safar <marek.safar@gmail.com>
2927 A fix for bug #414758
2928 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2931 2008-09-18 Marek Safar <marek.safar@gmail.com>
2933 * driver.cs, namespace.cs: Read types and namespaces after all
2934 requested assemblies are loaded, fixes issues with System.Core
2935 auto-reference, and #419888.
2937 2008-09-18 Marek Safar <marek.safar@gmail.com>
2939 A fix for bug #417705
2940 * cs-parser.jay: Fixed as/is operator expression split.
2942 2008-09-18 Marek Safar <marek.safar@gmail.com>
2944 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2945 Fixed expression tree representation of empty new expression and
2946 new initializer expression.
2948 2008-09-18 Miguel de Icaza <miguel@novell.com>
2950 * eval.cs: Remove warning, keep reference to driver around.
2952 * Hide fields that do not need to be public.
2954 2008-09-17 Marek Safar <marek.safar@gmail.com>
2956 A fix for bug #426385
2957 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2958 conversion for array elements.
2960 2008-09-17 Marek Safar <marek.safar@gmail.com>
2962 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2963 void parsing conflicts.
2965 2008-09-15 Marek Safar <marek.safar@gmail.com>
2967 A fix for bug #425601
2968 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2969 System.Core only when there is no custom ExtensionAttribute
2972 2008-09-15 Miguel de Icaza <miguel@novell.com>
2974 * namespace.cs: Do not report CS0246 (name
2976 2008-09-12 Marek Safar <marek.safar@gmail.com>
2978 A fix for bug #425669
2979 * generic.cs: Don't cache generic static anonymous method
2982 2008-09-12 Marek Safar <marek.safar@gmail.com>
2984 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2985 conflicting constraints.
2987 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2989 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2992 2008-09-12 Marek Safar <marek.safar@gmail.com>
2994 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2995 to null pointer conversion fixes.
2997 2008-09-11 Marek Safar <marek.safar@gmail.com>
2999 * cs-parser.jay, expression.cs: An implicitly typed local variable
3000 declarator cannot use an array initializer.
3002 2008-09-11 Marek Safar <marek.safar@gmail.com>
3004 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3006 2008-09-11 Marek Safar <marek.safar@gmail.com>
3008 * generic.cs (InflatedConstraints): Don't crash when constraints
3011 * cs-parser.jay: const_declarator is a block.
3013 * constant.cs: Check for not allowed NaN conversions.
3015 2008-09-10 Miguel de Icaza <miguel@novell.com>
3017 * driver.cs: Drop --shell argument, the compiler is no longer a
3020 * eval.cs: Move most of the code that deals with evaluation into
3021 this file and document the public API from repl.cs
3023 * repl.cs: Remove from here.
3025 2008-09-10 Marek Safar <marek.safar@gmail.com>
3027 A fix for bug #424684
3028 * generic.cs: Generic class constraints must come first.
3030 2008-09-09 Miguel de Icaza <miguel@novell.com>
3032 * cs-parser.jay: Improve error reporting for syntax errors in
3033 statements and expressions, we now report the expected tokens
3034 instead of reporting the useless "; expected".
3036 Drop the strings from the token declaration, it turns out that
3037 they did not do what I thought they did. Instead they were adding
3038 two sets of tokens to the tables.
3040 2008-09-09 Marek Safar <marek.safar@gmail.com>
3042 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3043 delegate.cs: Share special type check.
3045 2008-09-09 Marek Safar <marek.safar@gmail.com>
3047 A fix for bug #423981
3048 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3050 2008-09-09 Marek Safar <marek.safar@gmail.com>
3052 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3055 2008-09-09 Marek Safar <marek.safar@gmail.com>
3057 A fix for bugs: #324750, #335946
3058 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3059 lookup rule to determine ?-based tokens.
3061 2008-09-08 Miguel de Icaza <miguel@novell.com>
3063 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3064 expressions (like event adding or removing) end up here, so we
3065 need to treat those as statements.
3067 Add LoadAssembly method.
3069 2008-09-04 Miguel de Icaza <miguel@novell.com>
3071 * repl.cs: Add Time method.
3073 2008-09-05 Marek Safar <marek.safar@gmail.com>
3075 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3077 2008-09-05 Miguel de Icaza <miguel@novell.com>
3079 * repl.cs: Add workaround for old compilers.
3081 2008-09-04 Jb Evain <jbevain@novell.com>
3083 * repl.cs (PrettyPrint): pretty print everything that
3084 implements IDictionary, as well as IEnumerables. Also,
3085 add a quit helper property.
3087 2008-09-04 Marek Safar <marek.safar@gmail.com>
3089 * constant.cs: Better error reporting for decimal literals.
3091 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3094 2008-09-04 Marek Safar <marek.safar@gmail.com>
3095 Miguel de Icaza <miguel@novell.com>
3097 A fix for bug #422951
3098 * assign.cs (Assign.DoResolve): Perform the type conversions
3099 checks before we attempt to initialize `New' initializers.
3101 2008-09-04 Marek Safar <marek.safar@gmail.com>
3103 A fix for bug #422853
3104 * delegate.cs (DelegateCreation): Add special handling for
3105 EmptyExpression.Null instance expression which is just another
3106 hack for undecided member instance exression.
3108 2008-09-04 Marek Safar <marek.safar@gmail.com>
3110 * expression.cs, ecore.cs: Emit full expression tree for reduced
3113 2008-09-04 Marek Safar <marek.safar@gmail.com>
3115 * expression.cs (This): Guard against multi-resolving.
3117 * ecore.cs, statement.cs (Throw): Simplified.
3119 * flowanalysis.cs: Also verify event fields.
3121 2008-09-04 Miguel de Icaza <miguel@novell.com>
3123 * assign.cs (Assign.DoResolve): Perform the type conversions
3124 checks before we attempt to initialize `New' initializers.
3126 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3128 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3131 * repl.cs: Update help.
3133 2008-09-03 Miguel de Icaza <miguel@novell.com>
3135 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3136 handling of the default config handling, including the special
3137 treatment of System.Core assembly.
3139 Fixes the REPL processing for LINQ.
3141 2008-09-03 Marek Safar <marek.safar@gmail.com>
3143 A fix for bug #422507
3144 * expression.cs (UnboxCast): Add missing child expression mutator.
3146 2008-09-03 Marek Safar <marek.safar@gmail.com>
3148 * driver.cs: Don't self reference System.Core assembly.
3150 2008-09-03 Marek Safar <marek.safar@gmail.com>
3152 A fix for bug #422507
3153 * expression.cs (StringConcat): Add missing type mutator.
3155 2008-09-03 Marek Safar <marek.safar@gmail.com>
3157 * generic.cs (TypeInferenceContext): Follow equality rule for
3158 constructed type lower bound type inference.
3160 2008-09-02 Miguel de Icaza <miguel@novell.com>
3162 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3163 <dblank@cs.brynmawr.edu> which updates the cursor position on
3166 2008-09-02 Marek Safar <marek.safar@gmail.com>
3168 A fix for bug #367145
3169 * driver.cs: Fixed import of extension methods when using -noconfig
3172 2008-09-02 Marek Safar <marek.safar@gmail.com>
3174 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3175 version from non-generic implementation instead.
3177 2008-09-01 Marek Safar <marek.safar@gmail.com>
3179 A fix for bug #418908
3180 * class.cs: Use AddScopeStatement for field initializers.
3182 2008-09-01 Marek Safar <marek.safar@gmail.com>
3184 A fix for bug #415385
3185 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3187 2008-09-01 Marek Safar <marek.safar@gmail.com>
3189 A fix for bug #421736
3190 * iterators.cs: Don't crash on unreachable iterators.
3192 2008-09-01 Marek Safar <marek.safar@gmail.com>
3194 A fix for bug #421628
3195 * parameter.cs, attribute.cs: Clone also parameter attributes.
3197 2008-08-30 Miguel de Icaza <miguel@novell.com>
3199 * namespace.cs (LookupType): In EvalMode, try to replace
3200 the TypeBuilder from our cache with a Type as Reflection.Emit does
3201 not like to mix code from older assemblies emitted and new
3204 This sounds like a serious Mono bug that prevents multiple
3205 assemblies to be generated and consumed at the same time.
3207 * cs-parser.jay (push_current_class): Do not make interactive
3208 classes internal or private, make them public as we currently
3209 generate each new class in a new assembly.
3211 2008-08-29 Miguel de Icaza <miguel@novell.com>
3213 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3214 remove types that are entered into the global namespace during
3215 parsing so that we can remove them on failure.
3217 * cs-parser.jay: Parsing: we now keep track of types that are
3218 entered into global variables and queue those in case the parsing
3221 This happens in a few situations: during partial-input, we invoke
3222 the parser repeatedly for example with the string "class X", this
3223 would cause X to be registed, and we need to remove this
3224 registration so that another parse attempt later with say "class X {"
3225 would actually work.
3227 Additionally, if there is an error in the resolution phase, for
3228 example: "class X : NonExistant {}" th
3230 * cs-parser.jay: Be more precise with the errors being raised,
3231 instead of flagging all exceptions during parsing to be attributed
3232 to the parsing process, distinguish those from errors happening in
3233 the actions and hint that using -v would produce the actual
3236 * repl.cs: Do not load all compiler references on each reset,
3237 doing the partial reset takes care of this.
3239 2008-08-28 Miguel de Icaza <miguel@novell.com>
3241 * repl.cs: Add support for loading all the files from
3242 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3245 Introduce a micro-parser that is able to deambiguate on its input
3246 whether we are dealing with a compilation unit (namespace, class,
3247 interface, struct, delegate) declaration or a statement. This
3248 allows both declarations and statements to be entered.
3250 Set history size by default to 300 lines.
3252 Instead of distinguishing based on the parser.InteractiveResult,
3253 have only two cases: statements were parsed, or a compilation unit
3254 was. Always pull the Using statement additions from the
3255 compilation unit parse.
3257 * cs-tokenizer.cs: Rename tokens to better describe their intent
3258 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3260 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3261 EvalMode is used to trigger the lookup of global variables while
3262 StatementMode is used turn variable declarations into static
3265 * getline.cs: Allow history size to be set.
3267 2008-08-29 Marek Safar <marek.safar@gmail.com>
3269 A fix for bug #360755
3270 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3272 2008-08-29 Marek Safar <marek.safar@gmail.com>
3274 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3276 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3277 member name, it is too confusing
3279 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3281 * rootcontext.cs: Finally default to warning level 4.
3283 2008-08-28 Marek Safar <marek.safar@gmail.com>
3285 * class.cs (CheckBase): Ignore overloaded operators.
3287 2008-08-28 Marek Safar <marek.safar@gmail.com>
3289 A fix for bug #420830
3290 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3292 2008-08-28 Marek Safar <marek.safar@gmail.com>
3294 A fix for bug #420832
3295 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3297 2008-08-28 Marek Safar <marek.safar@gmail.com>
3299 A fix for bug #420386
3300 * nullables.cs: Fixed logic of nullable user comparison operators involving
3303 2008-08-28 Marek Safar <marek.safar@gmail.com>
3305 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3307 2008-08-27 Miguel de Icaza <miguel@novell.com>
3309 * repl.cs: Add support for aborting the running code with C-c.
3311 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3313 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3315 2008-08-27 Miguel de Icaza <miguel@novell.com>
3317 * cs-parser.jay (interactive_statement_list): A new set of rules
3318 for hosting statements that uses the "interactive_" prefix.
3320 * repl.cs: Add support for parsing `using' as a statement or as a
3321 directive. Deambiguating before passing this to the parser.
3323 We need to distinguish statement_expressions that occur at the
3324 toplevel vs those that occur embedded into expressions.
3326 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3327 that fixes the cursor key handling, and a history bug.
3329 2008-08-26 Miguel de Icaza <miguel@novell.com>
3331 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3332 limitations in Console, instead the 2.0 bootstrap libraries now
3333 include the Console bits.
3335 Also, remove the use of Nullables from getline.cs
3339 Interactive support for the C# compiler. Use gmcs --shell to
3340 enter a read-eval-print loop shell.
3342 Docs: http://www.mono-project.com/CsharpRepl
3344 * sources: include repl.cs here and getline.cs for gmcs.exe,
3345 everything else is getline.cs impaired.
3347 * Makefile: when bootstrapping pass a special flag
3348 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3349 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3350 This distinguishes those two cases.
3352 * repl.cs: Support for a read-eval-print loop. Will be soon
3353 refactored into eval support and then REPL on top of it.
3355 * ecore.cs: If a simplename lookup fails, before erroring out,
3356 if we are in EvalMode to resolve the name to a declaration in the
3359 This means that variable declarations that happened in previous
3360 classes (as repl puts every statement in a separate class) are
3361 made visible in this way.
3363 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3364 triggered an error due to the end of file being reached. This is
3365 used to do multi-line input, and notify the caller that the user
3366 needs to provide more text before a successful parse.
3368 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3369 to drive the evaluation with a custom wrapper.
3371 * driver.cs: Add support for --shell, and refactor some code to be
3374 * namespace.cs: Add support for serializing the contents of the
3375 namespaces and reloading them.
3377 * getline.cs: A managed implementation of ReadLine under
3378 X11/Apache2 license terms. Easy to embed in other applications as
3381 * namespace.cs: Add some functions to save and restore the
3384 * rootcontext.cs: New public field.
3386 * cs-tokenizer.cs: Add support for one of the possible characters
3387 we introduce into the token stream.
3389 This patch does not affect the regular tokenization process, the
3390 only performance hit would happen if there is an invalid character
3391 on the input string.
3393 * support.cs: Move isatty helper routine here.
3395 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3396 code generator for in-memory assemblies.
3398 2008-08-26 Marek Safar <marek.safar@gmail.com>
3400 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3401 parameter cannot be always used as a type.
3403 2008-08-21 Marek Safar <marek.safar@gmail.com>
3405 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3407 2008-08-21 Marek Safar <marek.safar@gmail.com>
3409 * convert.cs: Implement explicit array to IList<T> conversion.
3411 2008-08-20 Marek Safar <marek.safar@gmail.com>
3413 A fix for bug #362740
3414 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3416 2008-08-20 Marek Safar <marek.safar@gmail.com>
3418 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3419 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3420 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3421 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3422 handling to use just one type of infrastructure and deal with generics
3425 2008-07-23 Martin Baulig <martin@ximian.com>
3427 *** Merged this from trunk revision 108527 ***
3430 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3431 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3434 2008-08-15 Marek Safar <marek.safar@gmail.com>
3436 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3439 2008-08-15 Marek Safar <marek.safar@gmail.com>
3441 * delegate.cs: Fixed compiler crash when creating delegate using partial
3444 * typemanager.cs: MulticastDelegate is not a delegate.
3446 2008-08-14 Marek Safar <marek.safar@gmail.com>
3448 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3451 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3453 * cs-parser.jay (type): Allow 'var' in mcs too.
3454 (local_variable_type): Likewise.
3456 2008-08-14 Marek Safar <marek.safar@gmail.com>
3458 * driver.cs: Removed broken -noconfig variants.
3460 2008-08-14 Marek Safar <marek.safar@gmail.com>
3462 A fix for bug #417078
3463 * expression.cs: Emit correctly left side pointer operators.
3465 2008-08-13 Marek Safar <marek.safar@gmail.com>
3467 * generic.cs, lambda.cs: Inflate method generic arguments only.
3469 2008-08-12 Marek Safar <marek.safar@gmail.com>
3471 * class.cs: Fixed struct layout check regression.
3473 2008-08-12 Marek Safar <marek.safar@gmail.com>
3475 * cs-parser.jay, enum.cs: Simplified enum parsing.
3477 * decl.cs: Check all type parameters conflicts.
3479 * expression.cs, statement.cs, attribute.cs: More expression checks.
3481 2008-08-11 Marek Safar <marek.safar@gmail.com>
3483 * generic.cs: Add type inference types restriction.
3485 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3486 anonymous.cs, expression.cs: Allocate less accessor parameters.
3488 2008-08-08 Marek Safar <marek.safar@gmail.com>
3490 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3493 2008-08-08 Marek Safar <marek.safar@gmail.com>
3495 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3497 2008-08-07 Marek Safar <marek.safar@gmail.com>
3499 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3500 Also fixes #362146 and #381592.
3502 2008-08-07 Marek Safar <marek.safar@gmail.com>
3504 * ecore.cs: Reduced constant cannot be used as an attribute value.
3506 * cs-parser.jay: Base expression has to be a type.
3508 * expression.cs (Conditional): Uses ReducedExpression.
3510 2008-08-06 Marek Safar <marek.safar@gmail.com>
3512 A fix for bug #376826
3513 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3514 address of hoisted local variable or parameter cannot be taken.
3516 2008-08-05 Marek Safar <marek.safar@gmail.com>
3518 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3519 anonymous method inside checked/unchecked expression.
3521 2008-08-05 Marek Safar <marek.safar@gmail.com>
3523 * typemanager.cs (IsEqual): Guard against null.
3525 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3526 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3527 routine. Fixed few misleading conversion errors.
3529 2008-08-04 Marek Safar <marek.safar@gmail.com>
3531 * class.cs: Consider generics when checking cycles in struct layout.
3533 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3535 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3537 2008-08-04 Marek Safar <marek.safar@gmail.com>
3539 A fix for bug #414165
3540 * anonymous.cs: Use same anonymous implementation method for all anonymous
3543 2008-08-04 Marek Safar <marek.safar@gmail.com>
3545 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3548 2008-08-04 Marek Safar <marek.safar@gmail.com>
3550 * cs-parser.jay: Typeof argument has to be a type expression.
3552 * namespace.cs: Check alias and namespace definitions collisions.
3554 * class.cs, pending.cs: Moved explicit interface accessor implementation
3557 * delegate.cs, expression.cs: Verify special name invocations.
3559 2008-08-01 Marek Safar <marek.safar@gmail.com>
3561 * cs-parser.jay: Don't choke on empty generic type arguments.
3563 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3565 * expression.cs, ecore.cs: Minor expressions bugs.
3567 2008-08-01 Marek Safar <marek.safar@gmail.com>
3569 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3570 and added more error handling.
3572 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3574 * modifiers.cs, enum.cs: Fixed.
3576 2008-07-31 Jb Evain <jbevain@novell.com>
3578 * driver.cs: remove -pkg ability of smcs.
3580 2008-07-30 Marek Safar <marek.safar@gmail.com>
3582 * statement.cs (Switch): Correctly set empty default target for single
3585 2008-07-30 Marek Safar <marek.safar@gmail.com>
3587 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3588 string switch statement implementation to use string dictionary which
3589 significantly (2-8x) improves performance of generated code.
3591 2008-07-29 Marek Safar <marek.safar@gmail.com>
3593 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3594 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3596 2008-07-29 Marek Safar <marek.safar@gmail.com>
3598 A fix for bug #412595
3599 * typemanager.cs, convert.cs, expression.cs: Some types are never
3600 convertible to each other.
3602 2008-07-29 Marek Safar <marek.safar@gmail.com>
3604 * nullable.cs (CreateNullConstant): An error messages update.
3606 2008-07-29 Marek Safar <marek.safar@gmail.com>
3608 A fix for bug #412595
3609 * cfold.cs: Don't cast undefined bool constant.
3611 2008-07-29 Martin Baulig <martin@ximian.com>
3614 (SymbolWriter.Reset): New public static method.
3617 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3619 2008-07-28 Marek Safar <marek.safar@gmail.com>
3621 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3623 * expression.cs (ElementAccess): Exact size allocation.
3625 2008-07-26 Marek Safar <marek.safar@gmail.com>
3627 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3629 2008-07-25 Marek Safar <marek.safar@gmail.com>
3631 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3633 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3636 2008-07-25 Marek Safar <marek.safar@gmail.com>
3638 A fix for bug #412217
3639 * assign.cs: Mutate also assignment type.
3641 2008-07-25 Marek Safar <marek.safar@gmail.com>
3643 A fix for bug #323644
3644 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3647 2008-07-25 Marek Safar <marek.safar@gmail.com>
3649 A fix for bug #412134
3650 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3651 non-enumerable operands when overloading equality or bitwise operators.
3653 2008-07-25 Marek Safar <marek.safar@gmail.com>
3655 * anonymous.cs: Cache closed generic anonymous method delegates.
3657 2008-07-24 Marek Safar <marek.safar@gmail.com>
3659 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3660 anonymous.cs, statement.cs: Always emit anonymous method as static method
3661 when is instance free. Use nesting for nested anynomous methods blocks.
3663 2008-07-23 Marek Safar <marek.safar@gmail.com>
3665 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3668 2008-07-23 Marek Safar <marek.safar@gmail.com>
3670 * expression.cs: Removed MakeSimpleCall.
3672 2008-07-23 Marek Safar <marek.safar@gmail.com>
3674 A fix for bug #323012
3675 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3676 Base method implementing interface has to be public.
3678 2008-07-23 Marek Safar <marek.safar@gmail.com>
3680 * cs-parser.jay: Don't break on missing argument.
3682 2008-07-22 Marek Safar <marek.safar@gmail.com>
3684 A fix for bug #320993
3685 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3686 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3688 2008-07-22 Marek Safar <marek.safar@gmail.com>
3690 A fix for bug #320748
3691 * convert.cs: Implicit user operators cannot convert to interfaces
3693 2008-07-22 Marek Safar <marek.safar@gmail.com>
3695 A fix for bug #312686
3696 * driver.cs: Ignore empty assembly references.
3698 2008-07-22 Marek Safar <marek.safar@gmail.com>
3700 A fix for bug #387040
3701 * ecore.cs: Skip constrains check for an explicit implementation.
3703 2008-07-21 Marek Safar <marek.safar@gmail.com>
3705 A fix for bug #409045
3706 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3707 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3708 identifiers are file specific unless passed as input arguments.
3710 2008-07-21 Marek Safar <marek.safar@gmail.com>
3712 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3713 to emit UnmanagedMarshal data under 2.0 profile.
3715 2008-07-21 Marek Safar <marek.safar@gmail.com>
3717 A fix for bug #410369
3718 * parameter.cs: Clone correctly ParamsParameter.
3720 2008-07-21 Marek Safar <marek.safar@gmail.com>
3722 * expression.cs (Argument): Always report type for type based expressions
3725 2008-07-18 Marek Safar <marek.safar@gmail.com>
3727 A fix for bug #410666
3728 * anonymous.cs: Correctly initialize generic storey reference.
3730 2008-07-18 Marek Safar <marek.safar@gmail.com>
3732 * convert.cs: Don't box same type arguments.
3734 2008-07-18 Marek Safar <marek.safar@gmail.com>
3736 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3737 Finished missing generic type mutators.
3739 2008-07-18 Marek Safar <marek.safar@gmail.com>
3741 * iterators.cs, statement.cs: Finished statements CloneTo.
3743 2008-07-18 Marek Safar <marek.safar@gmail.com>
3745 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3747 * expression.cs: Emit optimized default value expressions in expression tree
3750 2008-07-18 Marek Safar <marek.safar@gmail.com>
3752 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3754 2008-07-17 Marek Safar <marek.safar@gmail.com>
3756 A fix for bug #367536
3757 * cs-parser.jay: Check static constructor of generic types for an access
3760 2008-07-17 Marek Safar <marek.safar@gmail.com>
3762 A fix for bug #353800
3763 * lambda.cs: Emit ret for contextual statements.
3765 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3766 up emitting redundant ret for all anonymous methods with return.
3768 2008-07-17 Marek Safar <marek.safar@gmail.com>
3770 A fix for bug #365188
3771 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3772 create anonymous method storey in unreachable block.
3774 2008-07-17 Marek Safar <marek.safar@gmail.com>
3776 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3777 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3778 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3779 statement.cs: Fixed relevant defects found by Gendarme.
3781 2008-07-17 Marek Safar <marek.safar@gmail.com>
3783 A fix for bug #325291
3784 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3785 statement.cs: Replaced IAnonymousHost with top level block flag.
3787 2008-07-17 Marek Safar <marek.safar@gmail.com>
3789 * cs-parser.jay: Clean up unused open_parens.
3791 2008-07-17 Marek Safar <marek.safar@gmail.com>
3793 * ecore.cs: Custom error message for a range variable assignment.
3795 2008-07-16 Marek Safar <marek.safar@gmail.com>
3797 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3800 2008-07-16 Marek Safar <marek.safar@gmail.com>
3802 * literal.cs: Null literal is of object type.
3804 2008-07-16 Marek Safar <marek.safar@gmail.com>
3806 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3807 expression of nullable equality comparison.
3809 2008-07-15 Marek Safar <marek.safar@gmail.com>
3811 * expression.cs(PointerArithmetic): Removed redundant assignment.
3813 2008-07-15 Marek Safar <marek.safar@gmail.com>
3815 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3817 2008-07-14 Marek Safar <marek.safar@gmail.com>
3819 A fix for bug #408361
3820 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3821 they are replaced by GetMethod.
3823 2008-07-14 Marek Safar <marek.safar@gmail.com>
3825 A fix for bug #408721 by jeremie.laval@gmail.com
3826 * expression.cs (Indirection): Implemented CloneTo.
3828 2008-07-14 Marek Safar <marek.safar@gmail.com>
3830 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3833 2008-07-14 Marek Safar <marek.safar@gmail.com>
3835 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3837 2008-07-11 Marek Safar <marek.safar@gmail.com>
3839 * linq.cs: Reset tranparent parameter counter in probing mode.
3841 2008-07-11 Marek Safar <marek.safar@gmail.com>
3843 * anonymous.cs: Mutate anonymous method type.
3845 2008-07-11 Marek Safar <marek.safar@gmail.com>
3847 * ecore.cs, anonymous.cs: Mutate field expressions.
3849 2008-07-10 Marek Safar <marek.safar@gmail.com>
3851 A fix for bug #369670
3852 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3854 2008-07-10 Marek Safar <marek.safar@gmail.com>
3856 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3858 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3861 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3862 only one '>', and finds a '>>', abort the generic lookahead.
3864 2008-07-10 Marek Safar <marek.safar@gmail.com>
3866 A fix for bug #319902
3867 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3869 2008-07-10 Marek Safar <marek.safar@gmail.com>
3871 A fix for bug #406371
3872 * statement.cs: Moved EmitSymbolInfo to Block.
3874 2008-07-09 Marek Safar <marek.safar@gmail.com>
3876 * ecore.cs: Report better error for extension method overload failures.
3878 2008-07-09 Marek Safar <marek.safar@gmail.com>
3880 * expression.cs (Is): No need to box reference values.
3882 2008-07-09 Marek Safar <marek.safar@gmail.com>
3884 * class.cs: Use event resolve context when initializing CreateEmitContext.
3886 2008-07-09 Marek Safar <marek.safar@gmail.com>
3888 A fix for bug #394436
3889 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3890 method used inside expression trees. Added more LINQ to expression tree
3893 2008-07-08 Marek Safar <marek.safar@gmail.com>
3895 A fix for bug #378189, #370577
3896 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3899 2008-07-08 Marek Safar <marek.safar@gmail.com>
3901 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3904 2008-07-08 Marek Safar <marek.safar@gmail.com>
3906 A fix for bug #406702
3907 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3909 2008-07-07 Marek Safar <marek.safar@gmail.com>
3911 A fix for bug #406648
3912 * cs-parser.jay: Report nullable use in mcs for some cases.
3914 2008-07-07 Marek Safar <marek.safar@gmail.com>
3916 * ecore.cs: Improved argument mismatch error messages.
3918 2008-07-07 Marek Safar <marek.safar@gmail.com>
3920 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3922 2008-07-07 Marek Safar <marek.safar@gmail.com>
3924 * expression.cs (TypeOf): Mutate type argument.
3926 2008-07-04 Marek Safar <marek.safar@gmail.com>
3928 * class.cs: Report missing partial modifier for correct type.
3930 2008-07-04 Marek Safar <marek.safar@gmail.com>
3932 * ecore.cs, expression.cs (VariableReference): Variable property is
3935 2008-07-04 Marek Safar <marek.safar@gmail.com>
3937 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3939 2008-07-04 Marek Safar <marek.safar@gmail.com>
3941 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3944 2008-07-04 Marek Safar <marek.safar@gmail.com>
3946 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3947 anonymous method storey to an instance method when only "this" is hoisted.
3949 2008-07-03 Marek Safar <marek.safar@gmail.com>
3951 A fix for bug #321615
3952 * expression.cs: Pointer comparisons use unsigned operator.
3954 2008-07-03 Marek Safar <marek.safar@gmail.com>
3956 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3958 2008-07-02 Marek Safar <marek.safar@gmail.com>
3960 A fix for bug #404905
3961 * class.cs: Always initialize local unsafe variables.
3963 2008-06-30 Marek Safar <marek.safar@gmail.com>
3965 A fix for bug #396987
3966 * expression.cs (NewInitialize): Clear local temporary variable for next run
3968 2008-06-27 Marek Safar <marek.safar@gmail.com>
3970 A fix for bug #401020
3971 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3973 2008-06-27 Marek Safar <marek.safar@gmail.com>
3975 A fix for bug #398319
3976 * cs-parser.jay: Implemented undocumented base access expression inside
3979 2008-06-26 Marek Safar <marek.safar@gmail.com>
3981 A fix for bug #404227
3982 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3984 2008-06-26 Marek Safar <marek.safar@gmail.com>
3986 A fix for bug #404227
3987 * convert.cs: Fixed explicit array to interface cast.
3989 2008-06-26 Marek Safar <marek.safar@gmail.com>
3991 A fix for bug #403894
3992 * delegate.cs: Mutate DelegateInvocation type.
3994 2008-06-26 Marek Safar <marek.safar@gmail.com>
3996 A fix for bug #379348
3997 * delegate.cs: Box a load of generic parameters.
3999 2008-06-26 Marek Safar <marek.safar@gmail.com>
4001 * expression.cs: Add an array creation arguments mutate.
4003 2008-06-26 Marek Safar <marek.safar@gmail.com>
4005 A fix for bug #386068
4006 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4009 2008-06-25 Marek Safar <marek.safar@gmail.com>
4011 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4014 2008-06-25 Marek Safar <marek.safar@gmail.com>
4016 A fix for bug #403518
4017 * delegate.cs: Type correctly anonymous method new invocation.
4019 2008-06-24 Marek Safar <marek.safar@gmail.com>
4021 A fix for bug #394826
4022 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4025 2008-06-24 Marek Safar <marek.safar@gmail.com>
4027 A fix for bug #394826
4028 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4031 2008-06-24 Marek Safar <marek.safar@gmail.com>
4033 * class.cs: Clone indexer parameters for localized capturing.
4035 2008-06-24 Marek Safar <marek.safar@gmail.com>
4037 A fix for bug #402379
4038 * expression.cs: Don't crash when an object initializer resolve fails.
4040 2008-06-24 Marek Safar <marek.safar@gmail.com>
4042 A fix for bug #402888
4043 * expression.cs: Mutate conditional expression.
4045 2008-06-24 Marek Safar <marek.safar@gmail.com>
4047 A fix for bug #401012
4048 * class.cs: Keep StructLayout in shared container.
4050 2008-06-24 Marek Safar <marek.safar@gmail.com>
4052 A fix for bug #400438
4053 * decl.cs, class.cs: Only properties can be automatically implemented.
4055 2008-06-24 Marek Safar <marek.safar@gmail.com>
4057 * statement.cs (ChangeToIterator): Copy also labels.
4059 2008-06-23 Marek Safar <marek.safar@gmail.com>
4061 * ecore.cs: Pass type argument details to parent extension method.
4063 2008-06-23 Marek Safar <marek.safar@gmail.com>
4065 A fix for bug #375966
4066 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4068 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4070 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4072 2008-06-22 Marek Safar <marek.safar@gmail.com>
4074 A fix for bug #394347
4075 * anonymous.cs: Cache compatible delegates as compatibility check produces
4076 a new method every time.
4078 2008-06-20 Marek Safar <marek.safar@gmail.com>
4080 * anonymous.cs: Propagate storey reference for single references.
4082 2008-06-20 Marek Safar <marek.safar@gmail.com>
4084 A fix for bug #387615
4085 * assign.cs, expression.cs: Correctly clone compound assignment.
4087 2008-06-19 Marek Safar <marek.safar@gmail.com>
4089 A fix for bug #359611, #359604
4090 * anonymous.cs: Mutate all types of hoisted parameters.
4092 2008-06-19 Marek Safar <marek.safar@gmail.com>
4094 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4095 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4096 expression.cs, codegen.cs, statement.cs
4098 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4099 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4101 ** Anonymous methods, lambda expressions rewrite **
4103 Anonymous expressions are now resolved when an explicit block is resolved
4104 and they don't require any registration procedure anymore. Further,
4105 anonymous methods are defined when explicit block is emitted which allows
4106 better control of whole process and opens possibilities for more
4107 optimizations as well as alternative to reverse whole process.
4109 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4110 process consistent and to correctly emit hoisted generic methods when they
4111 have at least 1 hoisted variable.
4113 2008-06-17 Martin Baulig <martin@ximian.com>
4115 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4117 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4118 virtual property; check it in Emit().
4119 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4121 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4123 (Indexer.Define): Likewise.
4125 2008-06-17 Marek Safar <marek.safar@gmail.com>
4127 * convert.cs: Don't use IsInterface on type arguments.
4129 * delegate.cs: DelegateInvocation uses MethodInfo.
4131 * parameter.cs: Removed IsTypeParameter.
4133 * generic-mcs.cs: More missing stuff.
4135 2008-06-16 Martin Baulig <martin@ximian.com>
4138 (Modifiers.DEBUGGER_HIDDEN): New public const.
4141 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4144 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4145 (AbstractPropertyEventMethod): Likewise.
4146 (Constructor.Emit): Likewise.
4147 (SourceMethod.SetCompilerGenerated): Removed.
4149 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4153 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4154 if we're an `IteratorHost'.
4155 (AnonymousMethodMethod..ctor): Don't set
4156 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4159 2008-06-16 Marek Safar <marek.safar@gmail.com>
4161 * statement.cs: Clean-up foreach statements.
4163 2008-06-12 Marek Safar <marek.safar@gmail.com>
4165 * class.cs: Stop using public method which should not exist
4166 (MethodBuilder.SetGenericMethodSignature).
4168 2008-06-11 Martin Baulig <martin@ximian.com>
4171 (Location.LookupFile): Add `CompilationUnit' argument; when given
4172 a relative file name, make it relative to the directory the .cs
4173 file is located in instead of using the current directory.
4175 2008-06-11 Martin Baulig <martin@ximian.com>
4178 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4179 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4180 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4181 (SourceMethod.SetCompilerGenerated): Likewise.
4183 2008-06-11 Marek Safar <marek.safar@gmail.com>
4185 * codegen.cs, driver: Only write symbol file when it's asked for.
4187 2008-06-11 Marek Safar <marek.safar@gmail.com>
4189 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4191 2008-06-10 Martin Baulig <martin@ximian.com>
4193 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4195 2008-06-09 Marek Safar <marek.safar@gmail.com>
4197 A fix for bug #316290
4198 * expression.cs: Include decimal operators in predefined table.
4200 * parameters.cs: More readonlyness.
4202 2008-06-09 Marek Safar <marek.safar@gmail.com>
4204 A fix for bug #397213
4205 * cs-parser.jay: One more missing current_local_parameters reset.
4207 2008-06-09 Marek Safar <marek.safar@gmail.com>
4209 A fix for bug #396633
4210 * class.cs: Host backing field in partial container.
4212 2008-06-09 Marek Safar <marek.safar@gmail.com>
4214 A fix for bug #397068
4215 * expression.cs: Check both operand types when predefined operator is used.
4217 2008-06-05 Martin Baulig <martin@ximian.com>
4219 Merged the `debugger-kahalo' branch.
4222 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4223 we're an iterator method.
4224 (SourceMethod): Reflect latest symbol writer changes;
4225 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4226 now `start_row' and `end_row'.
4227 (Constructor.Emit): Fix the logic whether to emit symbol information.
4229 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4233 (CompilationUnit): New public class; derives from `SourceFile'.
4234 (SourceFileEntry.DefineSymbolInfo): New public method.
4235 (SourceFileEntry.SetChecksum): New public method.
4236 (Location): Encode hidden line numbers by using `column == 255';
4237 the .ctor now accepts `column == -1' to mark a hidden line number.
4238 (Location.Hidden): New public property.
4239 (Location.CheckPoint): Add `CompilationUnit'.
4240 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4241 (Location.Push): Add `CompilationUnit compile_unit' argument.
4242 (Location.CompilationUnit): New public property.
4245 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4247 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4249 * driver.cs: `SourceFile' -> `CompilationUnit'.
4251 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4253 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4255 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4259 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4260 new symbol writer API to also pass the file.
4262 2008-06-05 Marek Safar <marek.safar@gmail.com>
4264 * statement.cs: Emit catch variable assignment using variable expression.
4266 2008-06-05 Marek Safar <marek.safar@gmail.com>
4268 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4269 with other variable types.
4271 2008-06-04 Marek Safar <marek.safar@gmail.com>
4273 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4274 GetLength method emit, it breaks resolve rules.
4276 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4277 Marek Safar <marek.safar@gmail.com>
4279 A fix for bug #395542
4280 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4283 2008-06-02 Marek Safar <marek.safar@gmail.com>
4285 A fix for bug #395287
4286 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4288 2008-05-31 Marek Safar <marek.safar@gmail.com>
4290 A fix for bug #395845
4291 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4292 non-nullable parameter type.
4294 2008-05-31 Marek Safar <marek.safar@gmail.com>
4296 * class.cs: Handle contructor initializer as a statement in top-level block.
4298 2008-05-30 Marek Safar <marek.safar@gmail.com>
4300 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4301 security attributes.
4303 2008-05-24 Marek Safar <marek.safar@gmail.com>
4305 * ecore.cs, expression.cs: Small IVariable refactoring.
4307 2008-05-22 Marek Safar <marek.safar@gmail.com>
4309 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4311 2008-05-21 Marek Safar <marek.safar@gmail.com>
4313 * cs-parser.jay: Removed redundant catch type check.
4315 2008-05-21 Marek Safar <marek.safar@gmail.com>
4317 A fix for bug #390372
4318 * nullable.cs: Set correct return type.
4320 2008-05-21 Marek Safar <marek.safar@gmail.com>
4322 A fix for bug #391062
4323 * typemanager.cs: Fixed crash when comparing null types.
4325 2008-05-21 Marek Safar <marek.safar@gmail.com>
4327 A fix for bug #391871
4328 * cs-parser.jay: Better error handling for invalid catch type.
4330 2008-05-20 Marek Safar <marek.safar@gmail.com>
4332 A fix for bug #392155
4333 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4335 2008-05-15 Marek Safar <marek.safar@gmail.com>
4337 A fix for bug #390666
4338 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4341 2008-05-15 Marek Safar <marek.safar@gmail.com>
4343 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4346 2008-05-13 Marek Safar <marek.safar@gmail.com>
4348 A fix for bug #389625
4349 * delegate.cs, generic.cs: Some progress on method group return type
4352 2008-05-13 Marek Safar <marek.safar@gmail.com>
4354 A fix for bug #378419
4355 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4357 2008-05-12 Marek Safar <marek.safar@gmail.com>
4359 * class.cs (Constructor): Added IsCompilerGenerated.
4361 2008-05-12 Marek Safar <marek.safar@gmail.com>
4363 * expression.cs: Enum binary operators can accept non-enum operand only when
4364 is implicitly convertible to underlying type.
4366 2008-05-12 Marek Safar <marek.safar@gmail.com>
4368 A fix for bug #389272
4369 * support.cs: Workaround System.InvalidOperationException for enums.
4371 2008-05-12 Marek Safar <marek.safar@gmail.com>
4373 A fix for bug #389073
4374 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4376 2008-05-10 Marek Safar <marek.safar@gmail.com>
4378 * driver.cs: Split Parse.
4380 * location.cs (LookupFile): Uses string.Empty.
4382 2008-05-07 Marek Safar <marek.safar@gmail.com>
4384 * expression.cs, parameter.cs: Small ParameterReference clean up.
4386 2008-05-07 Marek Safar <marek.safar@gmail.com>
4388 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4389 hack. Fixes #387502.
4391 2008-05-06 Martin Baulig <martin@ximian.com>
4393 * class.cs (Constructor.Emit): Fix the logic whether to emit
4396 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4399 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4400 InvalidOperationException when the iterator is before the start or
4403 2008-05-06 Marek Safar <marek.safar@gmail.com>
4405 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4406 when left is nullable type.
4408 2008-05-06 Marek Safar <marek.safar@gmail.com>
4410 A fix for bug #386628
4411 * expression.cs (LocalVariableReference): Continue in resolving when
4412 variable is not assigned.
4414 2008-05-05 Marek Safar <marek.safar@gmail.com>
4416 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4417 nullable operations.
4419 2008-05-04 Marek Safar <marek.safar@gmail.com>
4421 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4422 it saves many redundant temporary variables for nullable operations.
4424 2008-05-03 Marek Safar <marek.safar@gmail.com>
4426 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4428 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4431 * nullable.cs: Constant coalescing operator optimizations.
4433 2008-05-03 Marek Safar <marek.safar@gmail.com>
4435 * constant.cs: Use unsigned conversion for values which are unsigned only.
4437 2008-05-03 Marek Safar <marek.safar@gmail.com>
4439 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4440 coalescing operator as it should be.
4442 2008-05-02 Marek Safar <marek.safar@gmail.com>
4444 A fix for bug #371016
4445 * expression.cs: All predefined delegate operators require implicit method
4448 2008-05-02 Marek Safar <marek.safar@gmail.com>
4450 * constant.cs: Emit long constant as uint when fits the range.
4452 * convert.cs, expression.cs: Fixed few unsafe conversions.
4454 2008-05-02 Marek Safar <marek.safar@gmail.com>
4456 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4458 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4461 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4463 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4465 2008-05-01 Marek Safar <marek.safar@gmail.com>
4467 * constant.cs, literal.cs: IsLiteral property for error reporting.
4469 * ecore.cs, expression.cs: Implemented Property expression.
4471 2008-05-01 Marek Safar <marek.safar@gmail.com>
4473 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4475 * nullable.cs: Implemented nullable coalescing null operator.
4477 * ecore.cs, expression.cs: Expression trees work.
4479 2008-05-01 Marek Safar <marek.safar@gmail.com>
4481 * ecore.cs: CreateExpressionTree is finally abstract.
4483 * expression.cs, linq.cs: Updated.
4485 2008-05-01 Marek Safar <marek.safar@gmail.com>
4487 * expression.cs, ecore.cs: Block base access expression inside expression
4490 2008-05-01 Marek Safar <marek.safar@gmail.com>
4492 A fix for bug #385058
4493 * expression.cs: User-defined operator implementations always take
4494 precedence over predefined operator implementations.
4496 2008-04-30 Marek Safar <marek.safar@gmail.com>
4498 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4499 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4500 expression tree conversions.
4502 2008-04-30 Marek Safar <marek.safar@gmail.com>
4504 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4505 operators method details to Operator class.
4507 2008-04-30 Marek Safar <marek.safar@gmail.com>
4509 * anonymous.cs: Pass unsafe flags to anonymous container.
4511 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4512 inside expression tree.
4514 2008-04-29 Martin Baulig <martin@ximian.com>
4516 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4517 (Tokenizer.PopPosition): Also restore the `line'.
4519 2008-04-29 Marek Safar <marek.safar@gmail.com>
4521 * delegate.cs: Implemented Invoke expression.
4523 2008-04-29 Marek Safar <marek.safar@gmail.com>
4525 * expression.cs: Fixed equality reference comparison regression.
4527 2008-04-29 Marek Safar <marek.safar@gmail.com>
4529 * ecore.cs: Clean up EmptyCast hack.
4531 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4532 using correct conversion rules. Also fixes #383993.
4534 2008-04-28 Martin Baulig <martin@ximian.com>
4536 * class.cs (Constructor.Emit): Don't emit debugging information
4537 for generated default .ctor's.
4539 2008-04-28 Marek Safar <marek.safar@gmail.com>
4541 * convert.cs: Empty-cast ushort to int conversion.
4543 2008-04-28 Marek Safar <marek.safar@gmail.com>
4545 A fix for bug #384191
4546 * ecore.cs, expression.cs: Fixed expression cloning.
4548 2008-04-28 Marek Safar <marek.safar@gmail.com>
4550 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4552 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4554 Fix #381559, test-638.cs, test-639.cs
4555 * assign.cs (CompoundAssign.Helper): New wrapper.
4556 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4558 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4559 Pass unconverted expressions to the params array creation expression.
4560 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4561 (PropertyExpr.EmitAssign): Likewise.
4562 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4563 element if it is of kind CompoundAssign.Helper.
4564 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4565 first before anything else.
4566 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4567 (ArrayAccess.LoadArrayAndArguments): Simplify.
4569 2008-04-27 Marek Safar <marek.safar@gmail.com>
4571 * expression.cs: Fixed cloning of typeof(void).
4573 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4575 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4576 (Assign.Emit): Likewise. Move it to ...
4577 (CompoundAssign.DoResolve): ... here and ...
4578 (CompoundAssign.Emit): ... here.
4579 (EventAddOrRemove): New helper to handle += and -= on events, and
4580 avoid the use of BinaryDelegates.
4581 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4582 (EventExpr.EmitAddOrRemove): Improve.
4583 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4585 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4586 create VarExprs for 'foo.bar.var'.
4587 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4588 is a highly inappropriate name for its functionality.
4590 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4592 Simplify handling of multiple assignments
4593 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4595 (SimpleAssign): New. Class to be used for normal assignments.
4596 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4597 * expression.cs, parameter.cs, statement.cs: Likewise.
4599 2008-04-25 Marek Safar <marek.safar@gmail.com>
4601 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4602 for incompatible underlying types, more to come, uff.
4604 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4607 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4608 Handle 'leave_copy'.
4610 2008-04-25 Marek Safar <marek.safar@gmail.com>
4612 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4614 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4616 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4617 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4618 * statement.cs (While, Do, For): Allow test to have side effects.
4619 (For.DoEmit): Always emit InitStatement.
4622 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4623 Always create SideEffectConstant.
4624 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4625 of type EnumConstant.
4627 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4628 Handle 'right' being SideEffectConstant of type 'bool'.
4630 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4631 Use left.EmitBranchable instead of open coding it, so as to
4632 improve optimization opportunities.
4634 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4636 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4638 (Expression.EmitSideEffect): Document.
4640 2008-04-23 Marek Safar <marek.safar@gmail.com>
4642 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4644 2008-04-23 Marek Safar <marek.safar@gmail.com>
4646 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4648 2008-04-23 Marek Safar <marek.safar@gmail.com>
4650 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4651 conversion to expression tree.
4653 2008-04-23 Marek Safar <marek.safar@gmail.com>
4655 * ecore.cs: Removed unused expression.
4657 2008-04-22 Marek Safar <marek.safar@gmail.com>
4659 * expression.cs: Implemented NegateChecked and New expressions.
4661 2008-04-22 Marek Safar <marek.safar@gmail.com>
4663 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4665 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4668 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4669 needing final 'ret' instruction.
4671 2008-04-22 Marek Safar <marek.safar@gmail.com>
4673 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4675 2008-04-21 Marek Safar <marek.safar@gmail.com>
4677 * expression.cs: Emit ldnull and not null expression as an instance argument
4678 of static method expression calls.
4680 2008-04-21 Marek Safar <marek.safar@gmail.com>
4682 A fix for bug #378200
4683 * expression.cs: Fixed crash when creating parameterless expression tree
4686 2008-04-21 Marek Safar <marek.safar@gmail.com>
4688 A fix for bug #375297
4689 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4692 2008-04-21 Marek Safar <marek.safar@gmail.com>
4694 A fix for bug #377596
4695 * decl.cs, class.cs: Emit delegate type argument attributes.
4697 2008-04-21 Marek Safar <marek.safar@gmail.com>
4699 A fix for bug #365314
4700 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4702 2008-04-21 Marek Safar <marek.safar@gmail.com>
4704 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4707 2008-04-21 Marek Safar <marek.safar@gmail.com>
4709 * generic.cs (TypeParameter): Removed redundant location.
4711 2008-04-19 Marek Safar <marek.safar@gmail.com>
4713 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4714 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4715 FullNamedExpression in all declaration type expression, statements will come
4718 2008-04-18 Marek Safar <marek.safar@gmail.com>
4720 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4721 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4723 2008-04-18 Marek Safar <marek.safar@gmail.com>
4725 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4728 2008-04-17 Marek Safar <marek.safar@gmail.com>
4730 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4733 2008-04-17 Marek Safar <marek.safar@gmail.com>
4735 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4739 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4741 Hook up 'EmitSideEffect'
4742 * constant.cs (Constant.EmitSideEffect): New.
4743 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4744 (SideEffectConstant.EmitSideEffect): New.
4745 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4746 unconditional branch in EmitBranchable.
4747 (FieldExpr.EmitBranchable): New.
4748 * expression.cs (Unary.EmitSideEffect): New.
4749 (Binary.EmitSideEffect): New.
4750 (VariableReference.EmitSideEffect): New. Do nothing.
4752 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4754 Introduce 'EmitSideEffect'
4755 * ecore.cs (Expression.EmitSideEffect): New.
4756 (TypeCast): Rename from EmptyCast.
4758 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4759 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4760 * convert.cs, nullable.cs: Update to changes.
4762 2008-04-16 Marek Safar <marek.safar@gmail.com>
4764 * class.cs, cs-parser.jay: Early check for base types expression.
4766 2008-04-16 Marek Safar <marek.safar@gmail.com>
4768 * decl.cs (MemberName): Declare PrettyName as obsolete.
4770 2008-04-16 Marek Safar <marek.safar@gmail.com>
4772 * namespace.cs: Use MemberName comparison.
4774 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4777 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4779 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4780 (MemberName.FullyQualifiedName): New. Provides the functionality
4781 that users assume FullName would have.
4782 * ecore.cs, namespace.cs: Update to changes.
4784 * statement.cs (Using.assign): Make into ExpressionStatement.
4785 (Using.EmitPreTryBody): Simplify.
4787 2008-04-16 Marek Safar <marek.safar@gmail.com>
4789 * report.cs: ColorFormat is protected.
4791 * rootcontext.cs: Unused fields clean-up.
4793 * namespace.cs: Made UsingEntry name private.
4795 2008-04-16 Marek Safar <marek.safar@gmail.com>
4797 * cs-tokenizer.cs, location.cs: Removed unused field.
4799 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4800 Raja R Harinath <harinath@hurrynot.org>
4803 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4804 (SideEffectConstant.side_effect): Rename from 'right'.
4805 (SideEffectConstant..ctor): Normalize 'side_effect'.
4806 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4807 value of this constant.
4808 * cfold.cs: Update to changes.
4810 2008-04-15 Marek Safar <marek.safar@gmail.com>
4812 * cs-paser.jay: Removed unused variable.
4814 * driver.cs: Made Compile instance method.
4816 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4818 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4820 2008-04-15 Marek Safar <marek.safar@gmail.com>
4822 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4824 2008-04-13 Jb Evain <jbevain@novell.com>
4826 * namespace.cs: update the System.Core fullname for 2.1
4827 * driver.cs: update the list of required assemblies for 2.1.
4828 Merged from the Moonlight 2 branch.
4830 2008-04-11 Marek Safar <marek.safar@gmail.com>
4832 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4833 types and user defined operators. User operators arguments has to be checked
4834 for null value before invocation, which also means no operator is called
4835 when any argument is not convertible to unwrapped nullable type.
4837 2008-04-09 Marek Safar <marek.safar@gmail.com>
4839 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4840 of Unary expressions to follow operator overloading rules precisely.
4841 Also fixes #321794, #323794
4843 2008-04-08 Marek Safar <marek.safar@gmail.com>
4845 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4848 2008-04-08 Marek Safar <marek.safar@gmail.com>
4850 * expression.cs, ecore.cs: Implemented MemberInit expression.
4852 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4854 Fix mono/tests/exception4.cs
4855 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4856 ec.NeedReturnLabel () rather emitting a 'nop'.
4858 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4860 (TryCatch.SomeCodeFollows): Likewise.
4861 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4862 for 'break', 'continue' and 'return' statements inside a try.
4863 We're fairly sure that the generated IL stream will have more
4864 instructions textually following the try.
4865 (FlowBranchingTryCatch): Likewise.
4867 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4868 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4871 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4872 wrapper -- forward everything to CollectionForeach.
4873 (CollectionForeach.NonDisposableWrapper): New.
4874 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4875 instead of a pop + branch to end.
4877 2008-04-07 Marek Safar <marek.safar@gmail.com>
4879 A fix for bug #377485
4880 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4881 Propagate location for extension method groups. Report conversion failure at
4884 2008-04-07 Marek Safar <marek.safar@gmail.com>
4886 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4887 ListInit and Field expressions.
4889 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4891 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4892 Since $PC is always -1 inside the body of MoveNext, the fault
4894 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4895 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4896 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4898 The denouement! Fix #324708
4899 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4900 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4901 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4902 'finally' inside the finally clause.
4904 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4905 inside an iterator. Don't emit the body of the 'finally' inside
4906 the finally clause yet.
4908 Use the ResumableStatement infrastructure for MoveNext ()
4909 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4910 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4911 'old_resume_points'. Move dispatcher upfront.
4912 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4913 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4914 in an enumerator. This encodes the main fix in this patch series
4915 -- we can only jump into the first instruction of a try from the
4916 outside, but we want to emit try/finally regions in iterators and
4917 resume in the middle of them.
4919 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4921 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4922 of NeedReturnLabel here.
4924 Introduce a common point for emitting try/finally to IL
4925 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4926 features of the various subclasses, which are now driven by ...
4927 (ExceptionStatement.EmitPreTryBody): ... this and ...
4928 (ExceptionStatement.EmitTryBody): ... this and the original
4930 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4931 Remove DoEmit and update to follow above protocol.
4933 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4934 of the dispatcher are the same, skip emitting the 'switch'.
4935 * iterator.cs (Iterator.EmitDispose): Update to changes.
4937 Clean up handling of 'using' statement
4938 * statement.cs (UsingTemporary): New. Carved out of ...
4939 (Using): ... this. Simplify drastically. Handle exactly
4941 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4942 or Using as appropriate. If there are multiple variable declared,
4943 create nested Using statements.
4944 (resource_acquisition): Kill.
4946 * statement.cs (ExceptionStatement.EmitForDispose): Use
4947 EmitFinallyBody, not EmitFinally.
4949 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4950 * iterator.cs: Update to changes.
4952 Start using the ResumableStatement infrastructure
4953 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4954 (ResumableStatement.EmitForDispose): New.
4955 (ExceptionStatement): Override them.
4956 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4957 EmitForDispose to create the body of the Dispose method. Don't
4960 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4961 * statement.cs (Toplevel.AddResumePoint): ... here.
4962 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4963 * flowanalysis.cs (FlowBranchingIterator): New.
4964 * codegen.cs (EmitContext): Update to changes.
4966 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4967 (Iterator.old_resume_points): Rename from 'resume_points'.
4968 (Iterator.MoveNextStatement): Remove unused class.
4970 New infrastructure for try/finally in iterators (still unused)
4971 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4972 (FlowBranchingToplevel.AddResumePoint): Hook into
4973 ToplevelBlock.AddResumePoint.
4974 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4975 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4976 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4977 resume points and assign program-counter values.
4978 (ExceptionBlock.AddResumePoint): Collect resume points for
4979 de-muxer at the top of try block.
4980 * iterators.cs (Yield.CheckContext): Simplify.
4981 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4983 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4985 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4986 argument to an ExitStatement.
4987 (FlowBranchingException): Refactor saved origins code.
4988 * statement.cs (ExitStatement): Update to cahges.
4989 * iterator.cs (YieldBreak): Likewise.
4991 * statement.cs (ResumableStatement): New. Common base class for
4992 YieldReturn and ExceptionStatement.
4993 (ExitStatement): New. Common base class for Return and YieldBreak.
4994 (Return): Update to changes.
4995 * iterator.cs (YieldBreak): Likewise.
4996 * lambda.cs (ContextualReturn): Likewise.
4999 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5000 emit a meaningful error message.
5002 Fix #324765, #319508
5003 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5004 (VariableInfo.SetAssigned): Set it.
5005 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5006 determine if CS0219 or CS0168 is appropriate. Don't use
5007 flow-analysis information.
5008 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5009 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5010 (EmitContext.EndFlowBranching): ... this.
5012 2008-04-03 Marek Safar <marek.safar@gmail.com>
5014 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5016 2008-04-03 Marek Safar <marek.safar@gmail.com>
5018 A fix for bug #376508
5019 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5020 ImplicitConversionExists.
5022 2008-04-03 Marek Safar <marek.safar@gmail.com>
5024 * expression.cs (Binary): Added remaining binary operators to expression
5027 * nullable.cs: Optimize shift with null argument.
5029 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5031 Fix minor IL regression
5032 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5033 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5034 * cs-parser.jay (try_statement): Update to changes.
5036 * statement.cs (TryFinally.need_exc_block): Delete.
5037 (TryFinally): Update to changes.
5039 Now all ExceptionStatements are unconditional
5040 * statement.cs (CollectionForeach.DisposableWrapper): New.
5041 Extract out the try/finally code into a new wrapper.
5042 (CollectionForeach.Resolve): Use it to simplify the code.
5044 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5046 Start at simplifying ExceptionStatement semantics a bit
5047 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5048 * cs-parser.jay (try_statement): Update to changes.
5049 (opt_catch_clauses): Remove.
5050 * flowanalysis.cs: Update to changes.
5051 (FlowBranching.BranchingType.TryCatch): New.
5052 (FlowBranchingTryCatch): New.
5054 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5055 (FlowBranching.CreateBranching): Update to changes.
5056 (FlowBranchingBlock.AddSibling): Add sanity check.
5057 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5060 * iterators.cs (Iterator.MarkFinally): Remove.
5061 * statement.cs (ExceptionStatement): Update to changes.
5063 Add support for skipping over finally blocks at runtime. First
5064 in a series to fix #324708
5065 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5066 (Iterator.EmitMoveNext): Initialize it.
5067 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5068 branch over the body of the 'finally' clause.
5070 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5072 Avoid lopsided use of Foo/DoFoo names
5073 * statement.cs (ExpressionStatement.EmitFinallyBody):
5074 Rename from EmitFinally.
5075 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5076 * iterator.cs: Update to changes.
5078 2008-04-02 Marek Safar <marek.safar@gmail.com>
5080 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5081 based on UserOperatorCall. More binary nullable operators clean up.
5083 2008-04-02 Martin Baulig <martin@ximian.com>
5085 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5087 2008-04-02 Marek Safar <marek.safar@gmail.com>
5089 * nullable.cs: Merge user and empty conversions when lifting expression
5092 * expression.cs (StringConcat): Implemented expression tree representation.
5094 2008-04-01 Marek Safar <marek.safar@gmail.com>
5096 * nullable.cs: When lifting null literal and a user operator exists, no call
5099 2008-04-01 Marek Safar <marek.safar@gmail.com>
5101 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5104 2008-04-01 Marek Safar <marek.safar@gmail.com>
5106 * nullable.cs, expression.cs: Use namespace instead heavily nested
5107 monster abstract class.
5109 2008-04-01 Marek Safar <marek.safar@gmail.com>
5111 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5112 lifting of null literal and user operators. Clean up of some temporary
5115 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5117 Fix #368224, test-629.cs
5118 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5119 if it crossed an unwind-protect boundary.
5120 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5121 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5122 inside an unwind-protected region.
5123 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5124 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5125 'leave' instead of a 'br' if unwind-protected.
5126 (Iterator.EmitYieldBreak): Likewise.
5128 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5130 * driver.cs: Only define versioninfo resources if no win32 resource
5133 2008-03-28 Marek Safar <marek.safar@gmail.com>
5135 A fix for bug #372375
5136 * convert.cs: Fixed boxing of nullable types.
5138 2008-03-28 Marek Safar <marek.safar@gmail.com>
5140 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5143 2008-03-28 Marek Safar <marek.safar@gmail.com>
5145 A fix for bug #374619
5146 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5148 2008-03-27 Marek Safar <marek.safar@gmail.com>
5150 * lambda.cs: Check return type only for invocation.
5152 2008-03-27 Marek Safar <marek.safar@gmail.com>
5154 A fix for bug #374214
5155 * ecore.cs: Correctly report argument type mismatch.
5157 2008-03-27 Marek Safar <marek.safar@gmail.com>
5159 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5160 and not rely on broken IsEnum.
5162 2008-03-27 Marek Safar <marek.safar@gmail.com>
5164 * nullable.cs: New file, extracted from generic.cs.
5166 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5168 2008-03-27 Marek Safar <marek.safar@gmail.com>
5170 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5171 predefined comparison operators and null literals.
5173 * report.cs: New warning ID.
5175 2008-03-25 Marek Safar <marek.safar@gmail.com>
5177 A fix for bug #370577
5178 * lambda.cs: Check return type too.
5180 2008-03-25 Marek Safar <marek.safar@gmail.com>
5182 A fix for bug #372846
5183 * class.cs: Automatic properties can be declared as unsafe.
5185 2008-03-20 Marek Safar <marek.safar@gmail.com>
5187 * location.cs: Use string based concatenation.
5189 * expression.cs: LiftedBinaryOperator is gmcs only.
5191 2008-03-20 Marek Safar <marek.safar@gmail.com>
5193 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5194 conversions rules and expression trees.
5196 2008-03-19 Marek Safar <marek.safar@gmail.com>
5198 * delegate.cs: Use extension method source as delegate target.
5200 2008-03-19 Marek Safar <marek.safar@gmail.com>
5202 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5203 binary operations to be purely based on binary operations and optimized
5204 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5205 and other ET refactoring.
5207 * typemanager.cs: Fixed warning.
5209 2008-03-17 Marek Safar <marek.safar@gmail.com>
5211 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5213 * symbolwriter.cs: Fixed.
5215 2008-03-17 Marek Safar <marek.safar@gmail.com>
5217 * anonymous.cs, driver.cs: Reset anonymous types counters.
5219 2008-03-17 Marek Safar <marek.safar@gmail.com>
5221 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5223 * class.cs: Use fullname for all type member definitions.
5225 2008-02-19 Martin Baulig <martin@ximian.com>
5228 (IMethodData.EmitExtraSymbolInfo): New interface method.
5229 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5230 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5231 interface method here as an empty public virtual method.
5234 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5235 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5236 CodeGen.SymbolWriter.SetRealMethodName().
5238 2008-02-18 Martin Baulig <martin@ximian.com>
5241 (ScopeInfo.EmitType): Override this and emit debugging
5242 information for captured variables.
5243 (RootScopeInfo.EmitType): Override this and emit symbol
5244 information for a captured `this'.
5246 2008-02-15 Martin Baulig <martin@ximian.com>
5248 * iterators.cs: Emit debugging info.
5251 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5252 (EmitContext.OmitDebuggingInfo): New public property.
5255 (While): Override Emit() and don't emit symbol info there; do it
5256 inside DoEmit() instead.
5257 (Block.Emit): Omit symbol information while emitting the scope
5258 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5260 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5261 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5262 .ctor to make `IsIterator' work.
5264 2008-03-14 Martin Baulig <martin@ximian.com>
5266 * symbolwriter.cs: Added the new symbol writer function from the
5267 debugger's `terrania' branch; temporarily enclose them inside
5268 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5271 2008-03-14 Martin Baulig <martin@ximian.com>
5274 (SymbolWriter): Make this a public static class.
5277 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5278 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5280 2008-03-14 Marek Safar <marek.safar@gmail.com>
5282 A fix for bug #370577
5283 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5286 2008-03-14 Marek Safar <marek.safar@gmail.com>
5288 * typemanager.cs (CSharpName): Made 250 times faster.
5290 2008-03-13 Marek Safar <marek.safar@gmail.com>
5292 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5294 2008-03-12 Marek Safar <marek.safar@gmail.com>
5296 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5297 crash when predefined field does not exist.
5299 2008-03-12 Marek Safar <marek.safar@gmail.com>
5301 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5303 2008-03-12 Marek Safar <marek.safar@gmail.com>
5305 * class.cs (FixedField): Don't crash when contructors are missing.
5307 2008-03-11 Marek Safar <marek.safar@gmail.com>
5309 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5310 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5311 check internal types accessibility for internal and external types.
5312 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5314 2008-03-11 Marek Safar <marek.safar@gmail.com>
5316 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5317 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5318 attribute.cs, statement: Use corect instance of predefined types (work
5319 related to #364674).
5321 2008-03-07 Marek Safar <marek.safar@gmail.com>
5323 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5325 2008-03-07 Marek Safar <marek.safar@gmail.com>
5327 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5328 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5329 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5330 predefined types clean up, delayed predefined types members initialization
5331 (work related to #364674).
5333 2008-03-05 Marek Safar <marek.safar@gmail.com>
5335 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5337 2008-03-05 Marek Safar <marek.safar@gmail.com>
5339 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5340 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5341 predefined types clean up (work related to #364674).
5343 2008-03-04 Marek Safar <marek.safar@gmail.com>
5345 * ecore.cs: Print an error message instead of throwing exception.
5347 2008-03-04 Marek Safar <marek.safar@gmail.com>
5349 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5350 expression.cs, statement.cs: Unififed null literal representation.
5352 2008-03-03 Marek Safar <marek.safar@gmail.com>
5354 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5355 expression.cs: Refactored binary operators resolve phase and improved speed.
5356 The nullable code is still missing and won't work correctly, more fixes
5359 It also fixes #323726, #324312, #324248, and many other unreported issues.
5361 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5363 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5366 2008-02-27 Marek Safar <marek.safar@gmail.com>
5368 * ecore.cs: Clean-up and split BetterConversion.
5370 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5373 * enum.cs (EnumMember.Value): Only access 'value' if
5374 ResolveValue says it's ok.
5375 (EnumMember.DoResolveValue): Don't set prev_member.value.
5376 (Enum.GetDefinition): Reverse arguments of Equals --
5377 EnumMember.Value can return 'null'.
5379 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5381 2008-02-22 Marek Safar <marek.safar@gmail.com>
5383 * generic.cs, expression.cs: More ongoing work on expression trees.
5385 2008-02-21 Marek Safar <marek.safar@gmail.com>
5387 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5388 handle missing matches when mutiple operators exist.
5390 2008-02-20 Marek Safar <marek.safar@gmail.com>
5392 A fix for bug #363218
5393 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5396 2008-02-20 Marek Safar <marek.safar@gmail.com>
5398 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5399 update. This time to deal correctly with SideEffectConstant expression used
5400 as an argument for another constant folding.
5402 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5404 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5407 2008-02-19 Marek Safar <marek.safar@gmail.com>
5409 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5411 2008-02-19 Marek Safar <marek.safar@gmail.com>
5413 A fix for bug #328136
5414 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5415 side is a false constant, because we still need to evaluate the right-hand
5418 * statement.cs (If): Emit two types of boolean constants (simple constant,
5419 side-effect constant).
5421 2008-02-19 Marek Safar <marek.safar@gmail.com>
5423 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5425 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5428 2008-02-18 Marek Safar <marek.safar@gmail.com>
5430 A fix for bug #361457
5431 * ecore.cs (IsApplicable): Params methods have lower priority.
5433 * support.cs: Return correct parameter modifier for params types.
5435 2008-02-18 Marek Safar <marek.safar@gmail.com>
5437 * generic.cs (TypeParameter): Cache attribute target name.
5439 * support.cs: Removed unused variable.
5441 * typemanager.cs: Removed debugging leftover.
5443 * ecore.cs: Use local type instead of a property;
5445 * class.cs (VerifyMembers): Consider also parent to test whether type member
5448 * expression.cs (FullMethodDesc): Removed.
5450 * attribute.cs (IsValidArgumentType): Made static.
5452 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5454 Cleanup to be more readable.
5455 * Makefile (GMCS_PROFILE): Remove.
5456 (COMPILER_NAME): New helper.
5458 2008-02-15 Miguel de Icaza <miguel@novell.com>
5460 * cs-tokenizer.cs: if a conditional expression happens inside a
5461 (...) this also means that we do not need to de-ambiguate between
5462 an parenthesized expression and a cast.
5466 * constant.cs (SideEffectConstant): a constant value that happens
5467 to have a side effect.
5469 Fixes the build regressions introduced by the fix for #359789
5471 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5473 * expression.cs (Conditional.Emit): when emitting the ternary
5474 operator, use local variables to generate code verifiable code.
5476 The verifier cannot infer that the type on stack before the
5477 stloc.0 is executed is of type ParentB. This happens because the
5478 stack merge algorithm uses only parent types when deciding which
5479 is the common type. This is described in Part III 1.8.1.3 of ECMA
5482 This code compiled with mcs is not verifiable under MS. The MS
5483 verifier picks the first common interface of Foo and Bar, which is
5484 wrong, but doesn't use a full join type of the 2 interfaces.
5486 CSC uses a clever hack to compile such code in a verifiable
5487 way. It stores the intermediate values in a local variable with
5492 2008-02-14 Miguel de Icaza <miguel@novell.com>
5494 * expression.cs: Do not fold BitwiseAnd operators when the left
5495 side is a false constant, because we still need to evaluate the
5500 * support.cs: Instead of throwing an InternalErrorException when
5501 the position of the stream is outside the boundary of our buffer,
5502 reset the state of the reader, and restart the reading from the
5503 beginning of the file.
5505 2008-02-14 Marek Safar <marek.safar@gmail.com>
5507 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5509 2008-02-14 Marek Safar <marek.safar@gmail.com>
5511 A fix for bug #361686
5512 * decl.cs: A protected types used inside a private class which parents
5513 derives from the protected class are accessible.
5515 2008-02-13 Marek Safar <marek.safar@gmail.com>
5517 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5518 the parameterless constructor.
5520 2008-02-13 Marek Safar <marek.safar@gmail.com>
5522 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5523 lookup methods to use standard member cache when doing member lookup.
5525 2008-02-12 Marek Safar <marek.safar@gmail.com>
5527 * driver.cs: Don't report full path for referenced module as assembly error.
5529 2008-02-12 Marek Safar <marek.safar@gmail.com>
5531 * Makefile: Fixed `qh' target to work on all machines.
5533 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5534 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5535 and HasElementType with TypeManager implementation.
5537 2008-02-08 Marek Safar <marek.safar@gmail.com>
5539 A fix for bugs #325134, #359749
5540 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5541 first binds point to non-method member expression.
5543 2008-02-08 Marek Safar <marek.safar@gmail.com>
5545 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5547 2008-02-08 Marek Safar <marek.safar@gmail.com>
5549 A fix for bugs #321394, #323028
5550 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5551 Reworked naive IsAccessibleAs implementation to handle nested types.
5553 2008-02-05 Jb Evain <jbevain@novell.com>
5555 * class.cs: use generic type comparison for parameters
5558 2008-02-05 Marek Safar <marek.safar@gmail.com>
5560 A fix for bug #325372
5561 * class.cs: Use generic type comparison when testing method signatures.
5563 2008-02-05 Marek Safar <marek.safar@gmail.com>
5565 A fix for bug #357047
5566 * ecore.cs: Applied C# 3.0 changes to better conversion.
5568 2008-02-05 Marek Safar <marek.safar@gmail.com>
5570 A fix for bug #358374
5571 * cs-parser.jay: Correctly set modifiers for all constructor types.
5573 2008-02-04 Marek Safar <marek.safar@gmail.com>
5575 A fix for bug #355251
5576 * generic.cs: Added base class constraint based type inference.
5578 2008-02-01 Marek Safar <marek.safar@gmail.com>
5580 A fix for bug #357255
5581 * decl.cs: One more missing visibility check.
5583 2008-02-01 Marek Safar <marek.safar@gmail.com>
5585 * support.cs: Fixed broken return.
5587 2008-01-25 Marek Safar <marek.safar@gmail.com>
5589 * report.cs: Correctly reset warnings count after probing.
5591 2008-01-25 Martin Baulig <martin@ximian.com>
5594 (NamespaceEntry.SymbolFileID): Make this work again after
5595 MemberName.ToString() is gone.
5597 2008-01-25 Marek Safar <marek.safar@gmail.com>
5599 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5602 2008-01-25 Marek Safar <marek.safar@gmail.com>
5604 * generic.cs: Use full implicit conversion for type inference fixing.
5606 2008-01-24 Marek Safar <marek.safar@gmail.com>
5608 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5609 Fixed user operator conversions.
5611 2008-01-24 Marek Safar <marek.safar@gmail.com>
5613 * generic.cs: Do nullable type to null comparison optimization during
5616 2008-01-24 Marek Safar <marek.safar@gmail.com>
5618 A fix for bug #355163
5619 * generic.cs: Enabled l-value resolve on nullable expressions.
5621 2008-01-24 Marek Safar <marek.safar@gmail.com>
5623 A fix for bug #353986
5624 * class.cs: Ingore static ctors with parameters for any further checks.
5626 2008-01-24 Marek Safar <marek.safar@gmail.com>
5628 A fix for bug #354310
5629 * namespace.cs: Removed redundant check.
5631 2008-01-24 Marek Safar <marek.safar@gmail.com>
5633 A fix for bug #354928
5634 * expression.cs: ElementInitializers can be resolved only once.
5636 2008-01-24 Marek Safar <marek.safar@gmail.com>
5638 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5639 Condition expressions.
5641 2008-01-23 Marek Safar <marek.safar@gmail.com>
5643 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5645 2008-01-22 Marek Safar <marek.safar@gmail.com>
5647 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5650 * generic.cs: Implemented coalesce expression.
5652 2008-01-22 Marek Safar <marek.safar@gmail.com>
5654 A fix for bug #355145
5655 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5656 expression tree type inference.
5658 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5661 * expression.cs (Binary.IsUnsignedType): Fix typo.
5663 2008-01-22 Marek Safar <marek.safar@gmail.com>
5665 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5667 2008-01-22 Marek Safar <marek.safar@gmail.com>
5669 A fix for bug #355161
5670 * ecore.cs, expression.cs: Wider range of extension method supported
5673 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5675 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5676 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5679 2008-01-22 Marek Safar <marek.safar@gmail.com>
5681 A fix for bug #355148
5682 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5684 2008-01-22 Miguel de Icaza <miguel@novell.com>
5686 * expression.cs (CreateExpressionTree): Add support for or and
5687 logical or, and indent following the coding conventions.
5689 * typemanager.cs (LinqExpression): renamed from
5690 ExpressionTreeManager, for a shorter name.
5692 Use TypeManager.CoreLookupType to lookup types from our core
5693 assemblies and turn those into "Type" variables.
5695 Consumers that previously used "Namespace" and "Type" from this
5696 class should instead use the TypeExpression which is a type that
5697 is fully resolved (without involving the regular C# resolution
5700 This typically looks like this:
5702 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5703 new MemberAccess (texpr, name, type_arguments, loc)
5705 This avoids the problem in: #355178
5707 2008-01-21 Marek Safar <marek.safar@gmail.com>
5709 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5710 feature in parser only as we do in other cases.
5712 2008-01-21 Marek Safar <marek.safar@gmail.com>
5714 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5715 typemanager.cs: A refactoring of params arguments to reuse existing
5716 expressions (params -> array initializer) to emit params argument instead
5717 of specialized handling.
5718 It was required by expression tree implementation and it has other benefits
5719 as well, we now apply same optimization for params arguments as we do for
5722 2008-01-18 Marek Safar <marek.safar@gmail.com>
5724 A fix for bug #353526
5725 * generic.cs: A type inference of params arguments may not required any
5726 temporary array creation.
5728 2008-01-18 Marek Safar <marek.safar@gmail.com>
5730 A fix for bug #353534
5731 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5732 supported for delegates only.
5734 2008-01-18 Marek Safar <marek.safar@gmail.com>
5736 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5737 type for more than 1 candidates.
5739 2008-01-18 Marek Safar <marek.safar@gmail.com>
5741 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5744 2008-01-16 Marek Safar <marek.safar@gmail.com>
5746 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5747 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5748 operator) expressions.
5750 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5752 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5753 not accessed from the generated IL.
5755 2008-01-14 Marek Safar <marek.safar@gmail.com>
5757 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5758 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5759 statement.cs: The first expression tree implementation drop, mostly
5760 infrastructure work.
5762 2008-01-14 Marek Safar <marek.safar@gmail.com>
5764 * ecore.cs (IsNestedChild): Refactored.
5766 2008-01-11 Marek Safar <marek.safar@gmail.com>
5768 * lambda.cs: Don't use a cast on unknown expression statement.
5770 2008-01-10 Geoff Norton <gnorton@novell.com>
5772 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5775 2008-01-09 Marek Safar <marek.safar@gmail.com>
5777 * doc.cs: Report better /doc crash details.
5779 2008-01-09 Marek Safar <marek.safar@gmail.com>
5781 A fix for bug #352536
5782 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5784 2008-01-08 Marek Safar <marek.safar@gmail.com>
5786 A fix for bug #352287
5787 * ecore.cs, expression.cs: Do `this' access checking in all member access
5790 2008-01-08 Marek Safar <marek.safar@gmail.com>
5792 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5794 * report.cs: Reset message stacks.
5796 2008-01-08 Marek Safar <marek.safar@gmail.com>
5798 * generic.cs (InferInPhases): Correctly calculate params position.
5800 2008-01-08 Marek Safar <marek.safar@gmail.com>
5802 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5805 2008-01-07 Marek Safar <marek.safar@gmail.com>
5807 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5809 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5811 * driver.cs: Updated --help option.
5813 2008-01-07 Marek Safar <marek.safar@gmail.com>
5815 * generic.cs (InferParamsTypeArguments): Removed.
5816 (InferInPhases): Add params type inference.
5817 (LowerBoundInference): Fixed scoring mechanism.
5819 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5821 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5823 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5824 byte array for unsigned "baked" assemblies.
5826 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5828 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5829 array for assemblies that are not strongnamed.
5831 2008-01-04 Marek Safar <marek.safar@gmail.com>
5833 A fix for bug #351481
5834 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5835 declaring type for nested generic types.
5837 2008-01-04 Marek Safar <marek.safar@gmail.com>
5839 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5840 instead of ToString.
5842 2008-01-03 Marek Safar <marek.safar@gmail.com>
5844 A fix for bug #351047
5845 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5846 null and structs only when equality and inequality operators are defined
5847 either as an user-operators or predefined operators.
5849 2008-01-03 Marek Safar <marek.safar@gmail.com>
5851 A fix for bug #351047
5852 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5854 2008-01-03 Marek Safar <marek.safar@gmail.com>
5856 A fix for bug #351257
5857 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5859 2008-01-03 Marek Safar <marek.safar@gmail.com>
5861 A fix for bug #351157
5862 * class.cs (Using): Fixed yet another broken cloning.
5864 (Block): Put back more sensible default value for statements.
5866 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5868 * codegen.cs: Allow AssemblyVersion with only major version component.
5871 2007-12-29 Marek Safar <marek.safar@gmail.com>
5873 A fix for bug #324654
5874 * class.cs: Use FullName property as member name.
5876 2007-12-28 Marek Safar <marek.safar@gmail.com>
5878 A fix for bug #342117
5879 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5880 constructor constraint.
5882 2007-12-28 Marek Safar <marek.safar@gmail.com>
5884 A fix for bug #338273
5885 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5888 2007-12-28 Marek Safar <marek.safar@gmail.com>
5890 A fix for bug #350839
5891 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5893 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5895 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5898 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5900 * statement.cs: Changed some Hashtables to use HybridDictionaries
5901 instead. It was observed that some HashTables only contained a few
5902 items in the vast majority of cases. Since HybridDictionary is
5903 more efficient on small sets (<10 elements), "known_variables"
5904 from class ExplicitBlock as well as "labels" and "constants " from
5905 class Block were changed to HybridDictionaries.
5907 Atsai results: (56216kb->54987kb)
5909 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5912 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5914 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5917 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5919 * expression.cs: foreach loop to for loop, saved on allocation of
5920 enumerator (59333kb->59141kb)
5922 * statement.cs. Changed foreach loops to for loops, saved on
5923 allocation of enumerator (59141kb->59006kb)
5925 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5926 when constructed with no specified capacity. This was causing a
5927 few ArrayLists to allocate more memory than they would potentially
5928 need in the Block class and MemberCache class. Setting the
5929 ArrayLists to construct with a capacity of 1 saves some
5930 memory. (56216kb->55585kb)
5932 2007-12-27 Marek Safar <marek.safar@gmail.com>
5934 A fix for bug #347189 (2nd issue)
5935 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5938 2007-12-27 Miguel de Icaza <miguel@novell.com>
5940 * report.cs: Do not use colors if stdout and stderr are not a
5943 2007-12-27 Marek Safar <marek.safar@gmail.com>
5945 A fix for bug #346998
5946 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5949 2007-12-27 Marek Safar <marek.safar@gmail.com>
5951 A fix for bug #343465
5952 * class.cs: Explicit method name for nested types uses dots only.
5954 2007-12-27 Marek Safar <marek.safar@gmail.com>
5956 A fix for bug #343707
5957 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5959 2007-12-27 Marek Safar <marek.safar@gmail.com>
5961 * ecore.cs: Report type inference errors only when arguments count matches
5964 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5966 * expression.cs, report.cs: New warning.
5968 * typemanager.cs: Catch anonymous method type too.
5970 2007-12-23 Marek Safar <marek.safar@gmail.com>
5972 A fix for bug #346379
5973 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5975 2007-12-23 Marek Safar <marek.safar@gmail.com>
5977 A fix for bug #347359
5978 * expression.cs (Invocation): Don't resolve already resolved expression.
5980 2007-12-23 Marek Safar <marek.safar@gmail.com>
5982 A fix for bug #347189
5983 * class.cs (FixedField): Use non-dependent code only in the define phase.
5985 2007-12-23 Marek Safar <marek.safar@gmail.com>
5987 A fix for bug #348076
5988 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5990 2007-12-22 Marek Safar <marek.safar@gmail.com>
5992 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5993 discovered extension methods.
5995 2007-12-22 Marek Safar <marek.safar@gmail.com>
5997 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6000 2007-12-21 Miguel de Icaza <miguel@novell.com>
6002 * report.cs (ErrorMessage): Add support for using colors on
6003 terminals that support it.
6005 2007-12-21 Marek Safar <marek.safar@gmail.com>
6007 * ecore.cs: Use information about expanded params for error reporting.
6009 2007-12-21 Marek Safar <marek.safar@gmail.com>
6011 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6012 and logic for params overloads.
6014 2007-12-15 Miguel de Icaza <miguel@novell.com>
6016 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6017 as this is also created from the parser. Fixes #349034
6019 2007-12-12 Miguel de Icaza <miguel@novell.com>
6021 * statement.cs (Throw.CloneTo): it is valid to have empty
6022 expressions for throw.
6024 2007-12-03 Marek Safar <marek.safar@gmail.com>
6026 * cs-parser.jay: Set delegate constraint parsing region correctly.
6028 2007-12-03 Marek Safar <marek.safar@gmail.com>
6030 A fix for bug #345467
6031 * typemanager.cs (IsEqual): Compare generic parameters position only.
6033 2007-11-28 Marek Safar <marek.safar@gmail.com>
6035 * expression.cs (BaseAccess): Type arguments can be null.
6037 2007-11-27 Raja R Harinath <harinath@gmail.com>
6039 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6040 consistent even when an error has occured.
6041 (Switch.Resolve): Likewise.
6043 2007-11-22 Marek Safar <marek.safar@gmail.com>
6045 A fix for bug #334505
6046 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6049 2007-11-22 Marek Safar <marek.safar@gmail.com>
6051 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6052 refactorings required to resolve extension methods correctly when mixing
6053 generics and non-generics members.
6055 2007-11-20 Marek Safar <marek.safar@gmail.com>
6057 A fix for bug #342584
6058 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6061 2007-11-19 Marek Safar <marek.safar@gmail.com>
6063 A fix for bug #342512
6064 * delegate.cs: Use delegate argument expression when is available. Don't
6065 emit virtual call when class is sealed.
6067 2007-11-16 Marek Safar <marek.safar@gmail.com>
6069 A fix for bug #325423
6070 * assign.cs (FieldInitializer): Use resolved expression for emit.
6072 * class.cs: Print less confusing error message.
6074 2007-11-16 Marek Safar <marek.safar@gmail.com>
6076 * cs-tokenizer.cs: Removed GMCS ifdefs.
6078 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6081 * cs-parser.jay: Disabled nullable check.
6083 * generic-mcs: Copied more generic stuff.
6085 2007-11-16 Marek Safar <marek.safar@gmail.com>
6087 * gcs-parser.jay: Merged to cs-parser.jay.
6089 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6090 * *.csproj, *.sources: Updated to use only jay parser file.
6092 2007-11-16 Marek Safar <marek.safar@gmail.com>
6094 * gcs-parser.jay: Added nullable and default expression feature checks.
6096 2007-11-16 Marek Safar <marek.safar@gmail.com>
6098 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6099 it fixes many TODOs and hidden bugs.
6101 * expression: Removed duplicate error check.
6103 2007-11-15 Marek Safar <marek.safar@gmail.com>
6105 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6106 implicitly type local variable only when it is used in a declaration.
6108 2007-11-15 Marek Safar <marek.safar@gmail.com>
6110 * attribute.cs: Use CS0612 for empty strings.
6112 2007-11-14 Marek Safar <marek.safar@gmail.com>
6114 * lambda.cs, statement.cs: Contextual return may act as a statement.
6116 2007-11-14 Marek Safar <marek.safar@gmail.com>
6118 A fix for a regression cause by #324222
6119 * class.cs: Don't report unused even when it implements an interface.
6121 2007-11-13 Marek Safar <marek.safar@gmail.com>
6123 A fix for bug #341205
6124 * ecore.cs, expression.cs: Method group expression cannot do static
6125 method access with an instance reference check before overloading takes
6128 2007-11-13 Marek Safar <marek.safar@gmail.com>
6130 A fix for bug #325359
6131 * class.cs: Use predictable name for automatically generated property.
6133 2007-11-12 Marek Safar <marek.safar@gmail.com>
6135 A fix for bug #324996
6136 * expression.cs (Is): Handle case where D is nullable and T is not
6139 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6141 2007-11-12 Marek Safar <marek.safar@gmail.com>
6143 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6144 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6145 Flush small error reporting changes.
6147 2007-11-09 Marek Safar <marek.safar@gmail.com>
6149 A fix for bug #324996
6150 * expression.cs: Rewrote Is expression implementation to work with
6151 generics, nullable types, anonymous method. A const result expression
6152 uses existing infrastructure instead of custom not fully-featured one.
6154 2007-11-08 Marek Safar <marek.safar@gmail.com>
6156 A fix for bug #340202
6157 * class.cs: Consider generics for volatile field.
6159 2007-11-08 Marek Safar <marek.safar@gmail.com>
6161 A fix for bug #335594
6162 * expression.cs: Use conversion rules when handling string addition.
6164 2007-11-07 Marek Safar <marek.safar@gmail.com>
6166 A fix for bug #336651
6167 * expression.cs: Fixed a crash when probing is on.
6169 2007-11-07 Marek Safar <marek.safar@gmail.com>
6171 A fix for bug #324242
6172 * covert.cs: Added a conversion from any nullable-type with an
6173 underlying enum-type to the type System.Enum.
6175 2007-11-07 Marek Safar <marek.safar@gmail.com>
6177 A fix for bug #324222
6178 * class.cs: Report all non-used event fields.
6180 2007-11-07 Marek Safar <marek.safar@gmail.com>
6182 A fix for bug #325161
6183 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6184 qualifier for generic types.
6186 2007-11-07 Marek Safar <marek.safar@gmail.com>
6188 A fix for bug #322971
6189 * expression.cs, ecore.cs: Added intermediate result value check for
6192 2007-11-07 Marek Safar <marek.safar@gmail.com>
6194 A fix for bug #324754
6195 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6196 when it was requested.
6198 2007-11-07 Marek Safar <marek.safar@gmail.com>
6200 A fix for bug #325101
6201 * expression.cs: Do type not value comparison for `is' expression.
6203 2007-11-07 Marek Safar <marek.safar@gmail.com>
6205 A fix for bug #320236
6206 * convert.cs: Don't apply user conversion on underlying target type.
6208 2007-11-06 Marek Safar <marek.safar@gmail.com>
6210 * expression.cs: Don't use unresolved expression for error reporting.
6212 2007-11-06 Marek Safar <marek.safar@gmail.com>
6214 A fix for bugs #337712, #324490
6215 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6216 overloading resolution too.
6218 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6219 the process consistent and more robust.
6221 * expression.cs, linq.cs, report.cs: Update.
6223 2007-11-02 Marek Safar <marek.safar@gmail.com>
6225 A fix for bug #332909
6226 * attribute.cs: Resolve attributes in correct context using error
6229 * rootcontext.cs: Define Obsolete attribute members as core members.
6231 2007-11-02 Marek Safar <marek.safar@gmail.com>
6233 * statement.cs: Removed unused methods.
6235 2007-10-31 Wade Berrier <wberrier@novell.com>
6237 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6238 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6241 2007-10-31 Marek Safar <marek.safar@gmail.com>
6243 A fix for bug #338102
6244 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6245 methods registered as non-generics.
6247 2007-10-31 Marek Safar <marek.safar@gmail.com>
6249 A fix for bugs #337712, #324490
6250 * delegate.cs: Delegate covariance and contravariance is not allowed for
6253 2007-10-31 Marek Safar <marek.safar@gmail.com>
6255 A fix for bug #337719
6256 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6259 2007-10-30 Marek Safar <marek.safar@gmail.com>
6261 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6263 2007-10-29 Marek Safar <marek.safar@gmail.com>
6265 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6268 2007-10-29 Raja R Harinath <rharinath@novell.com>
6270 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6272 2007-10-29 Marek Safar <marek.safar@gmail.com>
6274 A fix for bug #334652
6275 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6276 extension methods when we have not found the best candidate in normal
6279 2007-10-27 Marek Safar <marek.safar@gmail.com>
6281 * AssemblyInfo.cs: Keep up-to-date.
6283 2007-10-27 Marek Safar <marek.safar@gmail.com>
6285 * Makefile: Fixed generics compiler name.
6287 2007-10-27 Marek Safar <marek.safar@gmail.com>
6289 * lambda.test: removed, lambda parsing is done differently.
6291 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6293 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6295 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6297 2007-10-27 Marek Safar <marek.safar@gmail.com>
6299 * Makefile, *.sources : All C# compilers are in mcs folder.
6301 * *.cs: Use existing 2_1 define for smcs.
6303 2007-10-26 Marek Safar <marek.safar@gmail.com>
6305 A fix for bug #335847
6306 * assign.cs, expression.cs: Couple of changes to avoid creating a
6307 temporary variable for each object initializer assignment statement. It
6308 simplifies struct initialization too, otherwise two temporary variables
6310 Implemented optimization of redundant default element initializers.
6312 2007-10-25 Marek Safar <marek.safar@gmail.com>
6314 A fix for bug #336766
6315 * expression.cs (Class.CheckBase): Use generic name when method is
6318 2007-10-25 Marek Safar <marek.safar@gmail.com>
6320 A fix for bug #334737
6321 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6322 variable and not variable argument for prepared copies.
6324 2007-10-24 Marek Safar <marek.safar@gmail.com>
6326 A fix for bug #325110
6327 * class.cs, expression.cs, attribute.cs: Use open generic method when
6328 checking conditional attribute.
6330 2007-10-24 Marek Safar <marek.safar@gmail.com>
6332 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6333 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6334 FeatureIsNotAvailable.
6336 2007-10-24 Marek Safar <marek.safar@gmail.com>
6338 ** C# 3.0 Partial methods
6340 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6341 methods support. Because of member cache issue with generics only
6342 non-generics partial methods are fully supported.
6344 2007-10-23 Marek Safar <marek.safar@gmail.com>
6346 * class.cs, decl.cs: Rewrote member overloads check to cope with
6347 generics and to use member cache for member checking. It also improves
6348 performance and fixes remaining overloads issues.
6350 2007-10-20 Marek Safar <marek.safar@gmail.com>
6352 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6353 roottypes.cs, typemanager.cs:
6355 A member cache creation logic changed to add members immediately and
6356 not rely on fallback. The member cache is now only prefered way
6357 how to access and find type declaration members. It saves 5 MB of memory
6358 during MWF compilation and makes code ready for more optimizations and
6359 clean-ups, it's also a pre-requirement for partial methods.
6361 2007-10-18 Raja R Harinath <harinath@gmail.com>
6363 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6364 handling for generic parameters.
6366 2007-10-15 Marek Safar <marek.safar@gmail.com>
6368 * class.cs (FixedField): Removed redundant volatile check.
6370 2007-10-15 Marek Safar <marek.safar@gmail.com>
6372 * class.cs, decl.cs: Fixed overload members verification to do only one
6373 check per possible collision.
6375 2007-10-13 Marek Safar <marek.safar@gmail.com>
6377 A fix for bug #325478
6378 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6379 and create only one disposable flags container.
6381 2007-10-12 Marek Safar <marek.safar@gmail.com>
6383 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6384 * statement.cs (Fixed): Fixed variables cloning.
6386 2007-10-12 Marek Safar <marek.safar@gmail.com>
6388 A fix for bug #333342
6389 * class.cs (EventField): Don't mark value type event as synchronized.
6391 2007-10-12 Marek Safar <marek.safar@gmail.com>
6393 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6394 inference to identify best candidate method correctly.
6395 (ProperyExpr): A range variable is read only and cannot be modified.
6397 2007-10-11 Marek Safar <marek.safar@gmail.com>
6399 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6400 logic to identify best candidate method correctly.
6402 2007-10-11 Marek Safar <marek.safar@gmail.com>
6404 * location.cs (Equals, GetHashCode): Removed.
6406 2007-10-11 Marek Safar <marek.safar@gmail.com>
6408 * report.cs: Implemented message recorder. It is used mainly for lambda
6409 expressions to capture otherwise swallowed error messages.
6411 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6413 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6415 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6417 * expression.cs (MemberAccess): Always report lookup failure.
6419 * location.cs: Implemented Equals, GetHashCode.
6421 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6423 2007-10-10 Jb Evain <jbevain@novell.com>
6425 * codegen.cs: re-enable assembly version check.
6427 2007-10-09 Marek Safar <marek.safar@gmail.com>
6429 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6432 * namespace.cs (UsingAlias): Do correct version check.
6434 2007-10-08 Marek Safar <marek.safar@gmail.com>
6436 * expresison.cs, ecore.cs: Issue extension method error message when
6439 * rootcontext.cs: Added ISO_2 compiler mode option.
6441 2007-10-08 Marek Safar <marek.safar@gmail.com>
6443 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6446 2007-10-08 Marek Safar <marek.safar@gmail.com>
6448 * attribute.cs (GetString, GetBoolean): Work with both literal and
6451 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6452 Moved method overload specific methods to MethodGroupExpr.
6454 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6455 it should be less memory consuming.
6457 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6459 * codegen.cs: remove the assembly version check until the buildbot is
6462 2007-10-07 Jb Evain <jbevain@novell.com>
6464 * attribute.cs (Attribute.GetString): if the value
6465 expression is a StringConstant, return its string value.
6467 2007-10-07 Jb Evain <jbevain@novell.com>
6469 * typemanager.cs: add `assembly_version_attribute_type`.
6470 * codegen.cs: on attribute emission, check that the
6471 AssemblyVersionAttribute doesn't overflow.
6473 2007-10-05 Marek Safar <marek.safar@gmail.com>
6475 A fix for bug #324677
6476 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6477 parent container of a scope container with currently resolved one.
6479 2007-10-05 Marek Safar <marek.safar@gmail.com>
6481 A fix for bug #325534
6482 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6485 2007-10-05 Marek Safar <marek.safar@gmail.com>
6487 A fix for bug #327504
6488 * class.cs (Operator.Define): Refactored implicit and explicit user
6489 operator conversion rules.
6491 2007-10-05 Marek Safar <marek.safar@gmail.com>
6493 A fix for bug #327520
6494 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6496 2007-10-04 Marek Safar <marek.safar@gmail.com>
6498 A fix for bug #328022
6499 * class.cs (MethodData.Define): Use correct method to check whether
6500 a method implementents an accessor.
6502 2007-10-04 Marek Safar <marek.safar@gmail.com>
6504 A fix for bug #330069
6505 * statement.cs (Fixed.Resolve): Read the first array element only when
6506 an array is instantiated.
6508 2007-10-04 Marek Safar <marek.safar@gmail.com>
6510 * expression.cs, assign.cs, generics.cs: Print correct operator when
6511 compound assignment is used.
6513 2007-10-04 Marek Safar <marek.safar@gmail.com>
6515 A fix for bug #325841
6516 * expression.cs (ArrayAccess): Use full argument cloning only for
6517 string compound concatenation.
6519 2007-10-03 Marek Safar <marek.safar@gmail.com>
6521 A fix for bug #328774
6522 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6524 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6527 2007-10-03 Raja R Harinath <rharinath@novell.com>
6530 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6531 Event accessibility checks here. Remove some bogus code that
6532 accidently made GenericMethods work.
6533 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6535 2007-09-25 Marek Safar <marek.safar@gmail.com>
6537 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6539 * statement.cs (Block): Refactored AddVariable to allow error handling
6542 * generic.cs: New stub.
6544 2007-09-23 Marek Safar <marek.safar@gmail.com>
6546 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6549 2007-09-17 Marek Safar <marek.safar@gmail.com>
6551 * class.cs: Use partial container to record whether any partial part
6552 contains static field initializer and therefore default contructor has
6555 2007-09-14 Marek Safar <marek.safar@gmail.com>
6557 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6558 mono-list when only one of two partial parts has defined accessibility
6561 2007-09-14 Marek Safar <marek.safar@gmail.com>
6563 A fix for bug #82845
6565 * class.cs (TypeContainer): Set correct resolve context for all field
6568 2007-09-13 Marek Safar <marek.safar@gmail.com>
6570 * assign.cs: Fixed a crash when field is resolved twice with an error.
6572 * codegen.cs: Changed InFieldInitializer to be flag.
6574 * anonymous.cs, ecore.cs, expression.cs: Update after
6575 IsInFieldInitializer rename.
6577 * const.cs: Removed unused parameter.
6579 * class.cs: Changed the way how we resolve and emit field initializers.
6580 The field initilizers have to have access to contructor block to emit
6581 compiler generated code.
6583 2007-09-13 Marek Safar <marek.safar@gmail.com>
6585 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6586 generics use TypeContainer instead.
6588 2007-09-12 Marek Safar <marek.safar@gmail.com>
6590 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6592 * lambda.cs (ResolveParameters): Use more powerful
6593 InflateGenericArgument.
6595 * parameters.cs: Better exception message.
6597 2007-09-10 Marek Safar <marek.safar@gmail.com>
6599 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6600 correct expression block type.
6602 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6604 * expression.cs (Invocation): Extracted method group resolve to
6607 2007-09-07 Marek Safar <marek.safar@gmail.com>
6609 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6610 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6612 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6613 generic extension methods.
6615 2007-09-06 Marek Safar <marek.safar@gmail.com>
6617 A fix for bug #82676 (Do I get it right now?)
6618 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6619 object before a standard conversion is applied.
6621 2007-09-06 Marek Safar <marek.safar@gmail.com>
6623 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6626 2007-09-05 Marek Safar <marek.safar@gmail.com>
6628 A fix for bug #82676
6629 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6630 non-generic interface types.
6632 2007-09-05 Marek Safar <marek.safar@gmail.com>
6634 A fix for bug #82690
6635 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6637 2007-09-05 Marek Safar <marek.safar@gmail.com>
6639 A fix for bug #82571
6640 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6641 modifier for container based methods.
6643 2007-09-05 Marek Safar <marek.safar@gmail.com>
6645 A fix for bug #82676
6646 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6647 any interface-type T means to any of interface type T.
6649 2007-09-04 Marek Safar <marek.safar@gmail.com>
6651 * namespace.cs: We have 2 versions of System.Core assembly.
6653 2007-09-04 Marek Safar <marek.safar@gmail.com>
6655 A fix for bug #82652
6656 * class.cs (Class.GetClassBases): Compare types and not expressions.
6658 2007-09-04 Marek Safar <marek.safar@gmail.com>
6660 A fix for bug #82620
6661 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6662 actually never worked before.
6663 (IndexerAccess): Emit prepared arguments before they are modified.
6665 2007-09-04 Marek Safar <marek.safar@gmail.com>
6667 A fix for bug #82563
6668 * assign.cs: Revert wrong fix.
6670 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6672 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6673 Instead of ldelema/stdind we have to use temporary variables to handle
6674 cases like String.Concat (params string[]).
6676 2007-08-31 Marek Safar <marek.safar@gmail.com>
6678 * class.cs: EmitAttributes to Emit rename.
6680 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6682 (MemberCore.HasClsCompliantAttribute): Don't depend on
6683 GetClsCompliantAttributeValue execution.
6685 2007-08-31 Marek Safar <marek.safar@gmail.com>
6687 * anonymous.cs: Use shorter type prefix.
6689 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6692 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6693 variables when probing is on.
6695 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6696 unresolved variables.
6697 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6698 handle transparent identifiers.
6700 2007-08-26 Marek Safar <marek.safar@gmail.com>
6702 * attribute.cs (IsClsCompliant): Add nullable types test.
6704 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6706 * doc.cs : catch other types of exception than XmlException to
6707 report CS1570. Fixed bug #82565.
6709 2007-08-23 Marek Safar <marek.safar@gmail.com>
6711 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6712 The number of delegate parameters has to match.
6713 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6716 2007-08-21 Marek Safar <marek.safar@gmail.com>
6718 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6719 to fix problem with private arguments.
6721 2007-08-20 Marek Safar <marek.safar@gmail.com>
6723 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6725 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6727 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6728 empty. Add cloning suport.
6730 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6732 2007-08-20 Marek Safar <marek.safar@gmail.com>
6734 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6735 to create EmptyCast. It handles EmptyConstantCast specialization for
6738 2007-08-18 Marek Safar <marek.safar@gmail.com>
6740 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6741 (EmitArrayArgument): One routine for array arguments.
6742 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6744 2007-08-17 Marek Safar <marek.safar@gmail.com>
6746 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6748 2007-08-17 Marek Safar <marek.safar@gmail.com>
6750 * anonymous.cs: MemberLookupFinal update.
6752 * class.cs (ConstructorInitializer): Is expression based.
6754 * delegate.cs: MethodGroupExpr update.
6756 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6758 (Error_MemberLookupFailed): Customizable error override.
6759 (MethodGroupExpr): Keep queried type for later usage.
6760 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6763 * expression.cs: Error_MemberLookupFailed refactoring.
6764 (New.DoResolve): Resolve as much as possible.
6765 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6766 customization for invalid member types.
6768 * statement.cs: MethodGroupExpr update.
6770 2007-08-16 Marek Safar <marek.safar@gmail.com>
6772 * modifier.cs (Check): Check all modifiers and not only accessibility
6775 2007-08-16 Marek Safar <marek.safar@gmail.com>
6777 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6778 type and not an expression.
6780 2007-08-16 Marek Safar <marek.safar@gmail.com>
6782 * statement.cs (Catch.Clone): Type and variable can be null.
6784 2007-08-16 Marek Safar <marek.safar@gmail.com>
6786 A fix for bug #81979
6787 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6788 I am really not sure whether this is the best fix.
6790 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6793 2007-08-14 Marek Safar <marek.safar@gmail.com>
6795 ** C# 3.0 Object and collection initializers (major re-write)
6797 * assign.cs (DoResolve): Initializers are not assign related.
6799 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6800 used during collection or object initialization.
6802 * expression.cs (Error_InvalidArguments): Add initializers specific
6803 messages. More will come later because it requires some general
6805 (New.DoResolve): Better error handling for unsafe types.
6806 (EmptyExpressionStatement): New class.
6807 (ElementInitializer): An object initializer expression.
6808 (CollectionElementInitializer): A collection initializer expression.
6809 (CollectionOrObjectInitializers): A block of object or collection
6811 (NewInitialize): New expression with element/object initializers.
6813 * statement.cs: Reverted object/collection initializer hacks.
6815 * typemanager.cs (CSharpName): Filter __arglist type.
6817 2007-08-09 Marek Safar <marek.safar@gmail.com>
6819 ** C# 3.0 Anonymous Types (update to the latest standard)
6821 * expression.cs (Binary.ResolveOperator): Threat all null based types
6823 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6824 (AnonymousTypeParameter): Updated.
6826 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6827 (AnonymousTypeClass): New anonymous type container.
6829 * class.cs (AddField): Return operation result.
6831 * generic.cs: Another empty TypeArguments overload.
6833 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6834 are stored at top of normal hierarchy.
6836 * typemanager.cs (CSharpName): Filter anonymous types.
6838 2007-08-09 Marek Safar <marek.safar@gmail.com>
6840 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6841 as single Concat call. How could we miss that :-(
6843 2007-08-08 Marek Safar <marek.safar@gmail.com>
6845 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6847 2007-08-07 Miguel de Icaza <miguel@novell.com>
6849 * expression.cs: Fix the previous commit, the creation of the
6850 arguments array list needs also to be conditional on the arguments
6853 * class.cs: Add a little bit of help to help narrow down problems.
6855 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6856 not try to copy in that case.
6858 * driver.cs: When building SMCS, include a new different set of
6859 default assemblies here. Do this here so we can control whether
6860 to include the default assemblies with /noconfig.
6862 2007-08-03 Marek Safar <marek.safar@gmail.com>
6864 A fix for bug #81979
6865 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6868 2007-08-03 Marek Safar <marek.safar@gmail.com>
6870 A fix for bug #82300
6872 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6873 we are in probing scope.
6875 2007-08-03 Marek Safar <marek.safar@gmail.com>
6877 A fix for bug #82301
6879 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6880 (Statement.CloneTo): Clone and not map children blocks.
6882 2007-08-03 Marek Safar <marek.safar@gmail.com>
6884 A fix for bug #82299
6886 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6889 * statement.cs (Statement.CloneTo): Clone variables before statements
6890 to allow remaping of local variables.
6892 2007-08-03 Marek Safar <marek.safar@gmail.com>
6894 A fix for bug #82296
6897 * report.cs: Log crash details for future clone problems.
6899 * statement.cs (Return.Clone): Don't clone non-existent expression.
6901 2007-08-03 Raja R Harinath <harinath@gmail.com>
6903 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6904 (Class.AddBasesForPart): Move CS0537 check here from ...
6905 * cs-parser.jay (class_declaration): ... here. Move calling of
6906 'AddBasesForPart' to ...
6907 (class_bases): ... here.
6908 (struct_declaration, interface_declaration): Update to changes.
6910 2007-08-02 Marek Safar <marek.safar@gmail.com>
6912 A fix for bug #81923
6914 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6915 conversion is allowed.
6917 2007-08-02 Marek Safar <marek.safar@gmail.com>
6919 A fix for bug #81564
6921 * ecore.cs (EventExpr): Add IsBase handling.
6923 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6926 2007-08-02 Raja R Harinath <harinath@gmail.com>
6928 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6929 * cs-parser.jay: Some whitespace cleanups.
6930 (current_delegate): New.
6932 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6933 a dummy code block, and use 'type_name' instead of 'member_name'.
6934 (interface_declaration, class_declaration): Likewise.
6935 (delegate_declaration): Likewise. Rearrange slightly and use
6937 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6938 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6940 2007-08-02 Marek Safar <marek.safar@gmail.com>
6942 A fix for bug #82039
6944 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6947 * typemanager.cs (CSharpName): Split to string overload.
6949 2007-08-02 Marek Safar <marek.safar@gmail.com>
6952 * report.cs: Updated warning CS0472.
6954 2007-08-01 Marek Safar <marek.safar@gmail.com>
6956 A fix for bug #82181
6958 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6960 2007-08-01 Marek Safar <marek.safar@gmail.com>
6962 A fix for bug #82277
6963 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6965 2007-08-01 Marek Safar <marek.safar@gmail.com>
6967 ** C# 3.0 Type Inference (major bits are working)
6969 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6970 (.ImplicitStandardConversionExists): Uses compatible.
6971 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6972 (.InferReturnType): New method.
6973 (.Compatible): Refactored.
6974 (.ResolveParameters): Uses factory to create resolved parameters.
6975 (.CompatibleMethod): Add probing mode support.
6976 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6977 clearly distinguish between 2 different operations.
6978 (LambdaMethod): Moved to lambda.cs.
6979 (AnonymousMethod): Removed unused fields and methods.
6980 (AnonymousDelegate): Simplified.
6982 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6984 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6986 * delegate.cs (Delegate): New mehods to reduce code duplication.
6987 (.GetConstructor): New method.
6988 (.GetInvokeMethod): New method.
6989 (DelegateCreation): Updated.
6991 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6993 (OverloadResolve): Made probing little bit faster.
6995 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6998 * generic.cs (TypeInferenceContext): Dummy implementation.
7000 * iterators.cs: Updated after Resolve/Define rename.
7002 * lambda.cs (LambdaExpression)
7003 (.ResolveParameters): Handles both type of arguments and type inference too.
7005 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7006 (InflateTypes): Updated.
7008 * support.cs (InflateTypes): Changed signature and updated.
7010 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7011 (MemberLookup_FindMembers): More MS tricks.
7012 (GetParameterData): Ditto.
7013 (GetDelegateParameters): Uses quick path for dynamic types.
7015 2007-08-01 Marek Safar <marek.safar@gmail.com>
7017 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7020 2007-07-31 Marek Safar <marek.safar@gmail.com>
7022 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7025 2007-07-26 Jb Evain <jbevain@novell.com>
7027 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7028 which takes a boolean 'report_errors', similar to the GetMethod.
7029 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7030 in .net 2.1, do not report errors here.
7032 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7033 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7034 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7037 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7038 of the type InternalsVisibleToAttribute before the first call
7039 to CoreLookupType which is allowed to fail (third boolean parameter
7040 to true). Because, during the resolution for a type that is not
7041 immediately found, we try to check if the type is not defined in
7042 a friend assembly, and to do so, we need the
7043 InternalVisibleToAttribute.
7045 2007-07-23 Miguel de Icaza <miguel@novell.com>
7047 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7048 feature that allows structs to be compared against null and inline
7049 the result as true or false.
7051 Notice that the same code is not permitted inside a generic block
7052 of code that would do:
7054 class Foo<T> where T : struct {
7061 It is only allowed if the type of T is not bound (no where
7062 clause). In my opinion, this CSC 2 behavior is broken but people
7063 seem to be using it (IronRuby does, a few bug reports on bugzilla
7064 have it and some people have complained about it).
7066 All of the users that depend on this behavior have code that is
7069 * report.cs (Warning, Error): make these take object arguments,
7070 not strings, as that allows us to take advantage of Format.
7072 2007-07-20 William Holmes <billholmes54@gmail.com>
7074 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7075 Left member variable for the Count.
7076 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7077 MemberName.CountTypeArguments to avoid a NRE.
7079 This code is contributed under the MIT X11 license
7081 2007-07-18 Marek Safar <marek.safar@gmail.com>
7083 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7085 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7087 * doc.cs : generic method arguments are written as ``x while generic
7088 type arguments are `x. Combined with the previous change, fixed bug
7091 2007-07-18 Raja R Harinath <rharinath@novell.com>
7094 * expression.cs (Binary.ResolveOperator): When converting
7095 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7097 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7099 * doc.cs : when T: or whatever x: is specified, it does not really
7100 check the doc comment's syntax correctness. Fixed bug #82006.
7102 2007-07-18 Marek Safar <marek.safar@gmail.com>
7104 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7105 LambdaExpression better.
7107 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7109 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7111 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7112 as it can be generated.
7114 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7117 * lambda.cs (LambdaExpression): Refactored to share same code with
7118 AnonymousMethodExpression.
7120 2007-07-17 Marek Safar <marek.safar@gmail.com>
7122 * anonymous.cs (MakeName): Include host name for easier debugging.
7123 (LambdaMethod): New class for lambda spcecific stuff.
7125 * attribute.cs: Set EmitContext return type.
7127 * class.cs: Set EmitContext return type.
7129 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7130 with null/void meaning.
7132 * iterators.cs (ContainerType): Implemented.
7134 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7136 * statement.cs (Return): Updated to lambda expressions.
7137 (Block.CloneTo): Parent can be null.
7139 2007-07-13 Marek Safar <marek.safar@gmail.com>
7141 A fix for bug #81917
7142 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7144 * class.cs (FixedField): Check whether field is in unsafe scope.
7146 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7147 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7149 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7152 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7154 2007-07-13 Marek Safar <marek.safar@gmail.com>
7156 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7157 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7160 2007-07-13 Marek Safar <marek.safar@gmail.com>
7162 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7164 2007-07-13 Marek Safar <marek.safar@gmail.com>
7166 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7167 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7169 * codegen.cs(EmitContext): Add ProbingMode flag.
7171 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7173 * driver.cs: For now set both warning values.
7175 * ecore.cs (SimpleName): Name is readonly.
7176 (MethodGroup.OverloadResolve): One quick path for probing.
7178 * expression.cs (Unary): Set Oper r/o.
7179 (Binary): Set Oper r/o.
7180 (ParameterReference): Set few instance variables as r/o.
7181 (ParameterReference.DoResolveBase): Don't capture aruments when
7183 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7184 (Arglist): arguments are private.
7185 (SizeOf): type is private and r/o.
7186 (MemberAccess): arguments are private.
7188 * report.cs: Enhanced reporting on/off capabilities.
7190 * lambda.cs: Uses ec.IsInProbingMode.
7191 (ContextualReturn): Derives from return.
7193 * rootcontext.cs: For now set both warning values.
7195 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7197 (Return.Resolve): Don't die immediately.
7198 (Block.Resolve): Speed-up probing.
7199 (Block.CloneTo): Clone only child blocks.
7201 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7203 * iterators.cs: reverted Miguel's latest change (r81925) as it
7204 breaks the build in System.
7206 2007-07-13 Miguel de Icaza <miguel@novell.com>
7208 * iterators.cs (Yield.CheckContext): Check for the iterator type
7209 also here as we can call into Yield even in codepaths that are not
7211 (MethodOrOperator is the only path that was checked).
7213 In addition to the standard check, use a more specific check for
7214 constructors to report a more verbose error.
7216 2007-07-12 Miguel de Icaza <miguel@novell.com>
7218 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7219 report the warning and continue
7221 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7222 values on the stack on the call to Emit. Use EmitStatement if
7223 possible, or using Emit + Pop if not possible. Fixes #82064
7225 2007-07-12 Raja R Harinath <rharinath@novell.com>
7227 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7228 avoid try...finally in some cases.
7230 2007-07-10 Marek Safar <marek.safar@gmail.com>
7232 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7234 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7235 instead of method. Re-use standard error handling.
7236 (ConstructorInitializer.Emit): Simplified.
7238 * delegate.cs: Updated after Invocation.EmitCall change.
7240 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7241 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7242 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7243 method and don't permanently changing input arguments.
7244 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7245 is resolved it has one of the candidates is the best one which is later
7246 used to emit. Removed a few unused method.
7247 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7249 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7250 (Binary.ResolveOperator): Ditto.
7251 (ConditionalLogicalOperator.DoResolve): Ditto.
7252 (Invocation): Uses method group.
7253 (Invocation.DoResolve): Simplified.
7254 (Invocation.EmitCall): Removed useless is_static.
7255 (Invocation.Emit): Delegate to method group.
7256 (Invocation.EmitStatement): Simplified.
7257 (New): Uses method group.
7258 (MemberAccess.DoResolve): Don't destroy original expression.
7260 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7262 2007-07-04 Marek Safar <marek.safar@gmail.com>
7264 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7267 * lambda.cs: Add custom error message type.
7269 2007-07-03 Marek Safar <marek.safar@gmail.com>
7271 * lambda.cs: Simplified little bit.
7273 * parameter.cs: Introduced ImplicitLambdaParameter.
7274 (Parameters.CreateFullyResolved): New factory instead of ctor.
7278 * delegate.cs: Updated parameter creation.
7280 2007-07-03 Marek Safar <marek.safar@gmail.com>
7282 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7285 * generic.cs: Synchronized with gmcs.
7287 2007-07-03 Marek Safar <marek.safar@gmail.com>
7289 * class.cs (Indexer): Check return type as soon as possible.
7291 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7294 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7296 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7298 * parameter.cs (Parameter): Use expression type when it is available.
7300 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7301 method modifier for the first parameter only.
7303 2007-06-24 Marek Safar <marek.safar@gmail.com>
7305 A fix for bug #81938
7306 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7308 * constant.cs: Tide up an exception message.
7310 2007-06-22 Marek Safar <marek.safar@gmail.com>
7312 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7313 an uninitialized variable is used.
7315 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7317 2007-06-22 Marek Safar <marek.safar@gmail.com>
7319 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7320 not found error handling.
7322 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7324 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7325 (ArrayCreation.DoResolve): Simplified.
7326 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7327 its own resolve process.
7328 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7330 2007-06-20 Marek Safar <marek.safar@gmail.com>
7332 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7335 2007-06-20 Marek Safar <marek.safar@gmail.com>
7337 * cs-tokenizer.cs: Removed var related stuff.
7339 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7340 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7341 a type and a keyword at same time.
7343 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7346 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7347 implicitly typed arrays, more changes will follow.
7349 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7351 2007-06-19 Marek Safar <marek.safar@gmail.com>
7353 * ecore.cs (VarExpr): Removed Handled field.
7355 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7356 build-in assign functionality.
7357 (ForEach.Resolve): Removed all implicitly typed local variable code and
7359 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7360 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7362 2007-06-18 Marek Safar <marek.safar@gmail.com>
7364 * assign.cs: Removed implicitly typed local variable check.
7366 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7367 referencing implicitly typed local variable.
7368 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7371 * statement.cs (Fixed): Removed unsupported implicitly typed local
7374 2007-06-15 Marek Safar <marek.safar@gmail.com>
7376 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7378 2007-06-14 Marek Safar <marek.safar@gmail.com>
7380 A fix for bugs #81855 and #76274
7381 * attribute.cs (AttachTo): Always set owner for global attributes to
7384 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7387 * cs-parser.jay: Assembly and module attributes must precede all other
7388 elements except using clauses and extern alias declarations.
7390 2007-06-13 Marek Safar <marek.safar@gmail.com>
7392 A fix for bug #81748
7394 * expression.cs: More checks for non ISO-1 features.
7396 2007-06-12 Marek Safar <marek.safar@gmail.com>
7398 A fix for bug #81807
7399 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7400 present inside switch statement and it is required by nullable check.
7402 2007-06-12 Marek Safar <marek.safar@gmail.com>
7404 A fix for bug #81840
7405 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7406 when type matching fails.
7408 * namespace.cs: Tiny error message change.
7410 2007-06-12 Marek Safar <marek.safar@gmail.com>
7412 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7413 reporting. Added automatic property check.
7415 * class.cs: Updated after CheckAbstractAndExtern relocation.
7416 (AEventPropertyAccessor.GetSignatureForError): Customized.
7418 2007-06-11 Marek Safar <marek.safar@gmail.com>
7420 * class.cs (DefineBaseTypes): Base type can be undefined.
7422 * ecore.cs (TypeLookup): Minor refactoring.
7423 (DoResolveAsTypeStep): Removed redundant check.
7425 * namespace.cs (Lookup): Removed redundant check.
7427 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7428 ResolveAsTypeTerminal step.
7429 (BootstrapCorlib_*): Simplified.
7430 (PopulateCoreType): Core types can be now external.
7432 2007-06-07 Marek Safar <marek.safar@gmail.com>
7434 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7436 (InferTypeArguments): Infers anonymous expression type arguments.
7437 (Compatible): Split to Compatible and InferTypeArguments.
7439 * lambda.cs: Updated.
7441 2007-06-08 Marek Safar <marek.safar@gmail.com>
7443 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7445 2007-06-07 Raja R Harinath <harinath@gmail.com>
7447 Fix #80477, cs0135-2.cs, cs0135-3.cs
7448 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7449 names to the "known" variables list.
7450 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7451 parameter names are also "known".
7452 (Block.CheckError136): Remove.
7453 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7456 2007-06-07 Marek Safar <marek.safar@gmail.com>
7458 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7460 2007-06-06 Marek Safar <marek.safar@gmail.com>
7462 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7463 internal error not an user error.
7465 * expression.cs (IsApplicable): Refactored to make debugging easier.
7467 * support.cs: More tricks for non-mono runtimes.
7469 * typemanager.cs (CoreLookupType): Made public.
7470 (InitSystemCore): All linq specific stuff moved to linq.cs
7472 2007-06-05 Marek Safar <marek.safar@gmail.com>
7474 * typemanager.cs (CSharpSignature): One more missing build-in types
7476 More tricks for non-mono runtime.
7478 2007-06-05 Raja R Harinath <harinath@gmail.com>
7480 * statement.cs (Block.CheckError136_InParents): Remove.
7481 (Block.AddVariable): Use GetParameterInfo instead.
7482 (ToplevelBlock.ProcessArguments): Likewise.
7484 2007-06-04 Raja R Harinath <rharinath@novell.com>
7486 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7488 (ToplevelBlock.GetParameterInfo): Split out of ...
7489 (ToplevelBlock.GetParameterRefernce): ... this.
7490 (ToplevelBlock.ParameterMap): Remove.
7491 * expression.cs (ParameterReference): Update to use
7492 ToplevelParameterInfo.
7494 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7497 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7498 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7500 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7501 (ToplevelBlock.ProcessParameters) ... here.
7502 (ToplevelBlock..ctor): Invoke it.
7504 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7507 * statement.cs (IKnownVariable): New interface.
7508 (LocalInfo): Implement it.
7509 (ToplevelParameterInfo): New class.
7510 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7511 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7512 GetKnownVariableInfo.
7514 2007-06-03 Raja R Harinath <harinath@gmail.com>
7516 Partly speed up CS0136 error checks.
7517 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7518 'recurse' parameter.
7519 (Block.DoCheckError136): Only check errors in parameters. Move
7520 local variable checks ...
7521 (Block.AddVariable): ... here, and ...
7522 (ToplevelBlock.ResolveMeta): ... here.
7524 2007-06-02 Raja R Harinath <harinath@gmail.com>
7526 * statement.cs (Block.IsChildOf): Remove.
7528 * statement.cs (Statement.Clone): Move special case code ...
7529 (Block.CloneTo): ... here.
7531 2007-05-29 Raja R Harinath <rharinath@novell.com>
7533 * statement.cs (ToplevelBlock.container): Remove field. It's
7534 redundant with 'Parent'.
7535 (ToplevelBlock.ContainerBlock): Remove accessor.
7536 (ToplevelBlock..ctor): Update to changes. Register anonymous
7537 child with parent here, ...
7538 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7540 (start_anonymous): Don't save current_block.
7541 (top_current_block): Remove.
7543 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7544 (Block.Resolve): Update to changes.
7545 (Block..ctor): Move setting of "correct" 'Toplevel'
7546 and 'Explicit' fields to ...
7547 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7549 2007-05-27 Raja R Harinath <harinath@gmail.com>
7552 * statement.cs (Block.Implicit): Remove.
7553 (Block): Update to changes.
7554 * flowanalysis.cs: Likewise.
7556 Mildly speed up CheckInvariantMeaningInBlock
7557 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7558 Recursively call AddKnownVariable to all enclosing blocks.
7559 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7560 Remove recursive calls.
7561 (Block): Update to changes.
7563 New ExplicitBlock invariants
7564 * statement.cs (Block.Explicit): New field. It points to the
7565 immediately enclosing non-implicit block.
7566 (Block..ctor): Maintain the invariant.
7567 * cs-parser.jay: Take advantage of invariant.
7569 Introduce ExplicitBlock
7570 * statement.cs (ExplicitBlock): New.
7571 (ToplevelBlock): Derive from it.
7572 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7574 (Block.Implicit): Update to changes.
7575 * cs-parser.jay: Update to changes.
7578 * codegen.cs (EmitContext.IsLastStatement): Remove.
7579 * statement.cs (Block.DoEmit): Update to changes.
7581 2007-05-25 Raja R Harinath <rharinath@novell.com>
7583 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7584 modifying current_block directly.
7586 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7588 * class.cs: Implemented automatic properties (C# 3.0)
7589 Thanks to Marek for the help.
7591 2007-05-23 Raja R Harinath <rharinath@novell.com>
7593 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7594 variable as assigned, note also that all its components are
7596 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7598 2007-05-19 Marek Safar <marek.safar@gmail.com>
7600 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7601 member is marked as compiler generated.
7603 * decl.cs (MemberCore): Refactored ModFlags into property.
7605 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7606 (Check): Check only accessibility modifiers.
7608 2007-05-18 Raja R Harinath <rharinath@novell.com>
7610 Track all assignable slots in one bit array
7611 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7612 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7613 logic from VariableMap constructor here. Use the same 'offset'
7614 variable that's later used for computing offsets of local
7616 * flowanalysis.cs (UsageVector.parameters): Remove.
7617 (UsageVector): Update to changes.
7618 (VariableMap): Remove.
7620 Avoid creating ParameterMap in every block
7621 * statement.cs (Block.ParameterMap): Move ...
7622 (ToplevelBlock.ParameterMap): ... here.
7623 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7625 * flowanalysis.cs (FlowBranching.param_map): Remove.
7626 (FlowBranching.UsageVector): Update to changes.
7627 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7629 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7631 * expression.cs (ParameterReference): Distinguish between block
7632 where parameter was referenced and declared.
7634 2007-05-18 Marek Safar <marek.safar@gmail.com>
7636 * flowanalysis.cs, statement.cs: Put back improved error handling.
7638 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7642 Imporved object and collection initialization (C# 3.0).
7644 2007-05-15 Marek Safar <marek.safar@gmail.com>
7646 A fix for bug #81380
7647 * expression.cs (Is.DoResolve): Only value types have constant `is'
7650 2007-05-15 Raja R Harinath <rharinath@novell.com>
7652 * statement.cs (ToplevelBlock.child): Remove.
7654 2007-05-15 Raja R Harinath <harinath@gmail.com>
7656 Rationalize ResolveMeta: refactoring
7657 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7658 out constant handling code into ...
7659 (Block.DoResolveConstants): ... this.
7661 Rationalize ResolveMeta: kill local_map
7662 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7663 (Block.AssignableSlots): New.
7664 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7665 for locals -- move code from VariableMap here. Avoid unnecessary
7667 * flowanalysis.cs (FlowBranching.local_map): Remove.
7668 (FlowBranching..ctor): Use Block.AssignableSlots.
7669 (VariableMap): Remove unused constructors.
7671 2007-05-11 Raja R Harinath <rharinath@novell.com>
7673 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7675 2007-05-11 Marek Safar <marek.safar@gmail.com>
7677 * typemanager.cs (IsFriendAssembly): Should not be called for building
7680 2007-05-09 Marek Safar <marek.safar@gmail.com>
7682 * literal.cs (NullConstant): Print null in all cases.
7684 * expression.cs (Binary.ResolveOperator): Implemented delegate
7685 comparison based on C# 2.0 changes.
7687 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7689 This code is contributed under the MIT X11 license
7691 The following enables support for several C# 3.0 language features:
7693 * cs-tokenizer.cs: Added support for the "var" keyword.
7695 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7696 Added VarExpr class to facilitate type inferencing.
7698 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7699 to support anonymous types.
7701 * assign.cs: Added support for type inferencing and initialization.
7703 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7705 * expression.cs: Added implicit array support to ArrayCreation.
7706 Added 5 types and 1 interface:
7708 IInitializable Implementing classes can inject initializing
7709 statements after object instantiation.
7711 Initializer Stores data for object initialization.
7713 AnonymousType An expression for anonymous types.
7715 AnonymousTypeParameter Stores data about an anonymous type's field.
7717 NewInitialize An expression for object initialization.
7719 CollectionInitialize An expression for collection initialization.
7721 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7724 2007-05-06 Marek Safar <marek.safar@gmail.com>
7726 A fix for bug #81500
7727 * cs-tokenizer.cs: Add special handling for coalescing operator.
7729 2007-05-06 Marek Safar <marek.safar@gmail.com>
7731 A fix for bug #81529
7732 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7733 its value from base class until it is redefined.
7735 2007-05-02 Raja R Harinath <rharinath@novell.com>
7737 Fix regression in cs0631-3.cs
7738 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7739 fallback. Make error fallback catch more cases.
7741 2007-05-01 Miguel de Icaza <miguel@novell.com>
7743 * cs-parser.jay: Allow parameters in operator declarations to have
7746 2007-04-27 Miguel de Icaza <miguel@novell.com>
7748 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7751 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7752 inside the ContextualReturn, it does not have to be an
7753 ExpressionStatement.
7755 2007-04-24 Miguel de Icaza <miguel@novell.com>
7757 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7760 2007-04-23 Miguel de Icaza <miguel@novell.com>
7762 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7763 method in two methods: ResolveNoDefine and Resolve.
7765 ResolveNoDefine will stop just after ResolveTopBlock has been
7768 Resolve will then continue by creating a method and issuing the
7769 call to method.Define ().
7771 (AnonymousMethod): Split and implement the new Resolve and
7772 ResolveNoDefine as well.
7774 * lambda.cs (LambdaExpression): Split the anonymous method
7775 resolution code into a separate routine (CoreCompatibilityTest)
7776 from DoCompatibleTest.
7778 (LambdaExpression.TryBuild): New method, this method tries to
7779 build the LambdaExpression with the given set of types to be used
7780 as the types for the various parameters of the lambda expression.
7782 If the compilation succeed with the given types, the infered type
7783 of the Anonymous method is returned, otherwise null is returned.
7785 2007-04-23 Marek Safar <marek.safar@gmail.com>
7787 A fix for bug #81414
7788 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7790 2007-04-22 Miguel de Icaza <miguel@novell.com>
7792 * cs-tokenizer.cs: Change various identifiers here from the
7793 camelCasing to the recommended Linux-like style for instance
7794 variables from the Coding Guidelines.
7796 2007-04-19 Martin Baulig <martin@ximian.com>
7799 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7800 System.Enum to System.ValueType.
7802 2007-04-13 Martin Baulig <martin@ximian.com>
7804 Rewrote implicit reference conversions. We need to distinguish
7805 between implicit reference conversions (13.1.4) and implicit
7806 boxing conversions (13.1.5).
7808 According to the spec, there's an an implicit conversion
7809 "From a one-dimensional array-type S[] to IList<T> and base
7810 interfaces of this interface, provided there is an implicit
7811 reference conversion from S to T." Note that this does not
7812 include boxing conversions.
7815 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7816 (Convert.ImplicitReferenceConversion): Split into
7817 ImplicitReferenceConversionCore() and
7818 ImplicitBoxingConversionExist().
7819 (Convert.ImplicitReferenceConversionExists): Use the new
7820 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7822 2007-04-12 Martin Baulig <martin@ximian.com>
7824 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7825 `TypeManager.null_type' checks up to the top of the method.
7827 2007-04-11 Marek Safar <marek.safar@gmail.com>
7829 A fix for bug #81350
7830 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7833 2007-04-11 Martin Baulig <martin@ximian.com>
7835 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7836 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7837 to make this work for generic classes; fixes #79561.
7839 2007-04-11 Martin Baulig <martin@ximian.com>
7841 * expression.cs (As): Add support for nullable types; fixes #79371.
7843 2007-04-11 Martin Baulig <martin@ximian.com>
7845 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7846 `type.FullName' is null; fixes #80243.
7848 2007-04-11 Martin Baulig <martin@ximian.com>
7850 * expression.cs (Invocation.IsApplicable): Don't modify the method
7851 if type inference succeeded, but the method was not applicable.
7854 2007-04-10 Marek Safar <marek.safar@gmail.com>
7856 A fix for bug #81324
7857 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7858 internal and external namespaces containers.
7860 2007-04-10 Martin Baulig <martin@ximian.com>
7862 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7863 TypeManager.DropGenericMethodArguments() so we also call
7864 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7866 2007-04-10 Martin Baulig <martin@ximian.com>
7868 * iterators.cs (Iterator.CreateIterator): Don't crash if
7869 `method.ReturnType' is null. This happens if something went wrong
7870 while resolving that typ (we already reported an error in this case).
7872 2007-04-10 Martin Baulig <martin@ximian.com>
7874 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7875 generic interfaces; report the CS0144 directly.
7877 2007-04-10 Martin Baulig <martin@ximian.com>
7879 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7880 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7882 2007-04-10 Martin Baulig <martin@ximian.com>
7884 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7886 2007-04-09 Raja R Harinath <rharinath@novell.com>
7889 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7890 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7893 * statement.cs (For.Resolve): If resolution fails, use
7896 2007-04-08 Marek Safar <marek.safar@gmail.com>
7898 * anonymous.cs (MakeName): Make faster and zero-based.
7899 (VerifyExplicitParameterCompatibility): Back to mode where generic
7900 parameter is ignored.
7901 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7903 * class.cs (EmitType): Method can emit another new method.
7905 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7907 * driver.cs: Updated.
7909 * lambda.cs: Reuse predefined empty parameters.
7911 * parameter.cs: Updated
7913 * support.cs: Implemented InflateTypes.
7915 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7916 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7918 2007-04-03 Martin Baulig <martin@ximian.com>
7922 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7923 version of TypeManager.IsOverride() which also works with generic
7926 2007-04-03 Martin Baulig <martin@ximian.com>
7931 (Convert.ExplicitReferenceConversion): We need to cast when
7932 converting from IList<T> to S[].
7934 2007-04-01 Marek Safar <marek.safar@gmail.com>
7936 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7939 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7941 2007-03-31 Marek Safar <marek.safar@gmail.com>
7943 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7944 argument and return type inferring.
7946 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7947 (ReturnType): Turned to property.
7949 * statement.cs (Return): Implemented return type inferring.
7951 * support.cs (ReflectionParameters): Use local types if possible.
7953 2007-03-30 Raja R Harinath <rharinath@novell.com>
7955 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7956 (FlowBranching.UsageVector): Update to changes.
7958 Prepare to kill 'Reachability'
7959 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7960 argument of constructor.
7962 2007-03-29 Raja R Harinath <rharinath@novell.com>
7964 Prepare to kill 'Reachability'
7965 * flowanalysis.cs (UsageVector.is_unreachable): New.
7966 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7967 'reachability', and verify they're consistent.
7970 * expression.cs (New.EmitStatement): Handle type parameters here too.
7972 2007-03-29 Martin Baulig <martin@ximian.com>
7977 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7978 CompilerGeneratedClass.
7979 (ScopeInfo.EmitScopeInstance): Make this protected.
7980 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7981 `ec.CurrentAnonymousMethod.Scope == Scope'.
7983 * statement.cs (Block.ScopeInfo): Make this a property.
7985 2007-03-27 Raja R Harinath <harinath@gmail.com>
7987 Prepare to kill 'Reachability'
7988 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7989 (FlowBranching.UsageVector.Reachability): Remove property.
7990 (FlowBranching.UsageVector.IsUnreachable): New property.
7991 (FlowBranching.UsageVector.ResetBarrier): New.
7992 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7993 * codegen.cs, statement.cs: Update to changes.
7995 2007-03-27 Martin Baulig <martin@ximian.com>
8000 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8003 2007-03-26 Raja R Harinath <rharinath@novell.com>
8005 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8006 instead of TriState. Remove all mention of TriState.
8008 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8009 replaced by a boolean. Add boolean 'is_unreachable' field, check
8010 and maintain invariants.
8012 2007-03-25 Marek Safar <marek.safar@gmail.com>
8014 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8016 2007-03-25 Marek Safar <marek.safar@gmail.com>
8018 * expression.cs: Stop using obsolete 2.0 opcodes.
8020 2007-03-25 Marek Safar <marek.safar@gmail.com>
8022 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8023 one of the latests Martin's fixes.
8025 2007-03-23 Miguel de Icaza <miguel@novell.com>
8027 * expression.cs: On BigEndian systems, swap the bytes, temporary
8028 solution until we get a new bitconverter class.
8030 2007-03-23 Martin Baulig <martin@ximian.com>
8034 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8035 "Method" and "Method`1". Normally, a cache lookup is done on the
8036 "Method" form (ie. without the generic arity), but this one makes
8037 lookups on the full form work as well.
8039 2007-03-22 Raja R Harinath <rharinath@novell.com>
8041 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8044 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8046 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8047 ordered_member_list, to TypeBuilder to store members to be defined
8048 in the order they were parsed in.
8049 - ordered_explicit_member_list contains all properties indexers
8050 and methods that are defined as explicit implementation of an
8051 interface or base class.
8052 - ordered_member_list contains all properties indexers and methods
8053 that are not defined as explicit implementation of an interface
8056 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8057 functionality in these removed classes has been replaced with
8058 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8059 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8061 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8062 to CheckForDuplications inside GetMethod and SetMethod Define Method
8063 to handle method property and indexer name conflicts.
8067 All code is contributed under the MIT/X11 license.
8069 2007-03-20 Martin Baulig <martin@ximian.com>
8071 * class.cs (TypeContainer.Interfaces): Removed; they're now
8072 included in `TypeContainer.Types'.
8074 2007-03-20 Martin Baulig <martin@ximian.com>
8076 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8078 * class.cs (TypeContainer.CreateType): New public method. This is
8079 now called before DefineType() to create the TypeBuilders.
8080 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8081 has already been created by CreateType().
8082 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8083 don't resolve our base classes here; this has been moved into
8084 DefineBaseTypes(). We're now called from CreateType().
8085 (TypeContainer.DefineBaseTypes): New private method; resolve our
8086 base classes here. We're now called from DefineType().
8089 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8090 our types first to create all the TypeBuilders. After that, call
8091 TypeContainer.DefineType() on all the types which'll resolve their
8092 base classes and setup the resolve order.
8094 2007-03-20 Martin Baulig <martin@ximian.com>
8096 * class.cs (TypeContainer.Enums): Removed; they're now included in
8097 `TypeContainer.Types'.
8099 2007-03-20 Martin Baulig <martin@ximian.com>
8102 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8103 (TypeContainer.DoResolveMembers): Call DefineType() on our
8104 `compiler_generated' classes; moved here from DefineNestedTypes().
8107 (RootContext.ResolveTree): Call ResolveMembers() on all
8108 TypeContainer's in the `type_container_resolve_order'.
8110 2007-03-19 Marek Safar <marek.safar@gmail.com>
8112 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8114 2007-03-17 Marek Safar <marek.safar@gmail.com>
8116 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8117 implementation flags.
8119 2007-03-17 Marek Safar <marek.safar@gmail.com>
8121 * class.cs: More optimizations for type parameters.
8123 2007-03-15 Marek Safar <marek.safar@gmail.com>
8125 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8127 * ecore.cs, parameter.cs: More common code for both corlibs.
8129 * typemanager.cs (IsGenericMethod): Simplified.
8131 2007-03-15 Raja R Harinath <rharinath@novell.com>
8133 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8135 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8137 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8138 unconditionally. Simplify explanation.
8139 (Try.Resolve, Using.Resolve): Likewise.
8141 2007-03-15 Martin Baulig <martin@ximian.com>
8145 * decl.cs (DeclSpace): If we're a partial class, use our
8146 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8148 2007-03-15 Raja R Harinath <rharinath@novell.com>
8150 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8152 (FlowBranching.UsageVector): Update to changes.
8153 (FlowBranching.MergeSiblings): Likewise.
8154 * statement.cs: Likewise.
8156 2007-03-15 Martin Baulig <martin@ximian.com>
8161 (MemberCache): Added a special .ctor for type parameters.
8164 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8167 2007-03-09 Martin Baulig <martin@ximian.com>
8169 * enum.cs (Enum): Make this a TypeContainer.
8170 (EnumMember): Derive from `Const'.
8173 (Const.DoResolveValue): New protected virtual method; move most of
8174 the functionality of ResolveValue() here so we can override it in
8176 (Const.CreateConstantReference): Make this virtual.
8178 * class.cs (Kind): Add `Kind.Enum'.
8179 (TypeContainer.Emit): Don't emit the enums here; they're already
8180 in the `RootContext.typecontainer_resolve_order'.
8182 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8183 here; they're already in the `typecontainer_resolve_order'.
8185 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8186 TypeManager.DropGenericTypeArguments().
8189 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8190 (TypeManager.IsEnumType): Likewise.
8191 (TypeManager.EnumToUnderlying): Likewise.
8192 (TypeManager.IsEqual): Add support for enums.
8194 2007-03-12 Raja R Harinath <rharinath@novell.com>
8196 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8197 DefaultParameterValueAttribute to be undefined, say if System.dll
8200 2007-03-11 Marek Safar <marek.safar@gmail.com>
8202 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8205 2007-03-10 Marek Safar <marek.safar@gmail.com>
8207 * class.cs, parameter.cs: Unified parameters verification.
8209 2007-03-08 Martin Baulig <martin@ximian.com>
8211 * cs-parser.jay (constructor_header): Pass the location to the
8212 newly created TopLevelBlock.
8214 2007-03-07 Martin Baulig <martin@ximian.com>
8216 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8218 2007-03-06 Miguel de Icaza <miguel@novell.com>
8220 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8221 with the changes from David, fixes the build.
8223 2007-03-05 David Mitchell <dmitchell@logos.com>
8225 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8226 and its base interfaces to a one-dimensional array type S[],
8227 provided there is an implicit or explicit reference conversion
8230 2007-03-03 Marek Safar <marek.safar@gmail.com>
8232 * cs-tokenizer.cs: Implemented basic linq grammar.
8234 * driver.cs: Set linq lang version on demand.
8236 2007-02-26 Marek Safar <marek.safar@gmail.com>
8238 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8240 2007-02-25 Marek Safar <marek.safar@gmail.com>
8242 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8245 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8247 Check property and event extern attributes.
8249 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8252 2007-02-24 Marek Safar <marek.safar@gmail.com>
8254 A fix for bug #80407
8255 * ecore.cs: Don't report ambiguity error when methods have same parent.
8257 2007-02-23 Marek Safar <marek.safar@gmail.com>
8259 A fix for bug #80878
8260 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8262 2007-02-22 Marek Safar <marek.safar@gmail.com>
8264 * attribute.cs: Enable ExtensionAttribute presence test.
8266 2007-02-22 Marek Safar <marek.safar@gmail.com>
8268 * class.cs: Warn about missing GetHashCode only when Equals is override.
8270 * decl.cs: Check accessibility of type arguments.
8272 * typemanager.cs: Correctly report nullable array.
8274 2007-02-20 Marek Safar <marek.safar@gmail.com>
8276 * class.cs, report.cs: Capture more details when things go wrong.
8278 2007-02-20 Marek Safar <marek.safar@gmail.com>
8280 A fix for bug #80650
8281 * cs-parser.jay: Anonymous container starts at constructor declaration
8282 and not at block beginning because it has to be usable in constructor
8285 * statement.cs: Use context location and not block one for error reporting.
8287 2007-02-18 Marek Safar <marek.safar@gmail.com>
8289 A fix for bug #78712
8290 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8293 2007-02-18 Marek Safar <marek.safar@gmail.com>
8295 A fix for bug #80493 by Atsushi Enomoto
8296 * cs-parser.jay: Ignore invalid attribute target.
8298 2007-02-18 Marek Safar <marek.safar@gmail.com>
8300 * cs-tokenizer.cs: Ignore '\0' as white space character.
8302 2007-02-17 Miguel de Icaza <miguel@novell.com>
8304 * cs-parser.jay: Add support for lambda expressions to the mcs
8307 * lambda.cs: Only clone when we are probing, not on the final call
8308 (Compatible is the final call).
8310 * statement.cs (CloneContext): Introduce class to provide block
8311 remapping during clone.
8313 All statements Clone themselves now.
8315 (Clone): special handling for blocks, when we clone a block, we
8316 register the block inside this routine, as children of the block
8317 might trigger a lookup.
8319 * expression.cs: Add support for CloneContext in all expressions.
8321 2007-02-17 Marek Safar <marek.safar@gmail.com>
8323 A fix for bug #80493
8324 * statement.cs: Report ambiguous warning when interfaces are not related.
8326 2007-02-15 Marek Safar <marek.safar@gmail.com>
8328 C# 3.0 extension methods.
8330 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8331 cannot be used directly.
8333 * class.cs (Class.Emit): Emit extension attribute if any class method
8334 is extension method.
8335 (Method.Define): Add basic extension method validation conditions.
8336 (Method.Emit): Emit extension attribute for method.
8338 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8339 extension method exists. Currently we follow same approach as Microsoft
8340 does, emit even if a method or a class are private but this can change
8343 * cs-parser.jay: Add handling of `this' keyword in method parameters
8346 * decl.cs (DeclSpace.IsStaticClass): New property.
8347 (MemberCache.FindExtensionMethods): Looks for extension methods with
8348 defined name and extension type.
8350 * doc.cs: Updated after OverloadResolve changes.
8352 * driver.cs: Add new soft reference to System.Core.dll.
8354 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8355 (ExtensionMethodGroupExpr): Represents group of extension methods.
8357 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8358 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8359 to MethodGroupExpr and made non-static for easier customization.
8360 (Invocation.DoResolve): Add extension method lookup when no standard
8362 (MemberAccess.DoResolve): Try extension methods if no member exists.
8364 * modifiers.cs: Add METHOD_EXTENSION modifier.
8366 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8367 as well as candidate extension type.
8368 (ComputeNamespaces): When assembly constains extension methods registers
8370 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8371 extension method lookup.
8372 (Namespace.LookupExtensionMethod): Looks for extension method in this
8374 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8375 find a method which matches name and extensionType.
8377 * parameter.cs (Parameter): Add This modifer.
8378 (HasExtensionMethodModifier): New property.
8379 (Resolve): Add extension parameter check.
8380 (ModFlags): turned to property to exclude this modifier as it is not real
8382 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8384 * support.cs (ParameterData): Add ExtensionMethodType.
8385 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8387 * typemanager.cs: Add type and ctor extension attribute type.
8389 2007-02-15 Miguel de Icaza <miguel@novell.com>
8391 * report.cs (DisableErrors, EnableErrors): used to prevent error
8392 output when we are "trying" to compile various methods with
8395 * ecore.cs (Expression): Add Clone method that calls the virtual
8396 CloneTo method. The current CloneTo method in Expression throws
8397 an exception so we can track down all the places where this must
8398 be implemented (not using abstract, because that would be a lot of
8399 up-front-work before we can start testing the implementation
8402 Important: we only need Clone capabilities for expressions created
8403 by the parser, as the expressions we will be cloning are
8404 expressions in the pre-resolved state. This vastly simplifies
8407 (SimpleName): Add CloneTo that does nothing.
8408 (EmptyCast): Add CloneTo.
8410 * expression.cs (Binary): Implement CloneTo.
8411 (Invocation.IsApplicable): Store the current ec in
8412 EmitContext.TempEc and restore it on return. This is used so we
8413 do not have to sprinkle hundres of methods with an extra
8414 EmitContext, we know that the only user is the lambda expression
8415 ImplicitConversionExists code.
8417 (Argument): Add Cloning capabilities.
8418 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8419 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8420 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8421 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8422 IndexerAccess): Add Clone capability.
8424 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8426 (Argument): Add cloning capability.
8428 * assign.cs (Assign): Implement CloneTo.
8430 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8432 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8433 version by calling Convert with the EmitContext (that we are
8434 currently storing in ec, this is not great, but will do for now,
8435 to avoid passing EmitContext parameters to hundreds of functions
8436 that do not need them now).
8438 (SetExpression): Remove, it is not needed.
8440 (ContextualReturn): Implement CloneTo.
8442 * statement.cs (Statement): Implement cloning infrastructure,
8443 similar to expressions.
8445 (Block): Partial implementation of Clone for statements.
8447 (Return): Implement clone.
8449 * constant.cs (Constant.CloneTo): New method, does nothing.
8451 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8452 solution, until we decide how to exactly do this.
8454 2007-02-14 Marek Safar <marek.safar@gmail.com>
8456 A fix for bug #80493
8457 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8458 a property is override we need to use second accessor.
8460 2007-02-13 Marek Safar <marek.safar@gmail.com>
8462 A fix for bug #80418
8463 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8466 2007-02-13 Marek Safar <marek.safar@gmail.com>
8468 Another fix for bug #80749
8469 * pending.cs: Abstract class has priority over interfaces.
8471 2007-02-13 Marek Safar <marek.safar@gmail.com>
8473 Another fix for bug #80749
8474 * pending.cs: Abstract class has priority over interfaces.
8476 2007-02-13 Marek Safar <marek.safar@gmail.com>
8478 Another fix for bug #80749
8479 * pending.cs: Abstract class has priority over interfaces.
8481 2007-02-13 Marek Safar <marek.safar@gmail.com>
8483 Another fix for bug #80749
8484 * pending.cs: Abstract class has priority over interfaces.
8486 2007-02-13 Marek Safar <marek.safar@gmail.com>
8488 * class.cs Better error message.
8490 * driver.cs: Add shorter versions of -optimize option.
8492 2007-02-13 Martin Baulig <martin@ximian.com>
8494 * class.cs (Constructor.Emit): Check the return value of
8495 ec.ResolveTopBlock() and return on error.
8497 2007-02-13 Raja R Harinath <rharinath@novell.com>
8499 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8500 message to fix error message regression.
8502 2007-02-12 Marek Safar <marek.safar@gmail.com>
8504 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8506 2007-02-12 Marek Safar <marek.safar@gmail.com>
8508 A fix for bug #80749
8509 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8510 its parent container.
8512 * class.cs (DefineFieldInitializers): Each initializer can has different
8515 * const.cs: Updated.
8517 2007-02-11 Miguel de Icaza <miguel@novell.com>
8519 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8520 now all the heavy lifting to check that embedded statements or
8521 expressions have the right form is done in the ContextualReturn.
8523 (ContextualReturn): New class.
8525 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8526 method that can be invoked to report 201, so we do not replicate
8529 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8531 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8532 treating tabs as spaces.
8534 2007-02-09 Marek Safar <marek.safar@gmail.com>
8536 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8537 * assign.cs: Use full implicit conversion for right side check.
8539 2007-02-09 Marek Safar <marek.safar@gmail.com>
8541 * statement.cs (Switch): Switch over boolean type is not standardized.
8543 2007-02-08 Marek Safar <marek.safar@gmail.com>
8545 A fix for bug #80755
8546 * decl.cs (FindBaseEvent): Don't use method cache for events.
8548 2007-02-07 Marek Safar <marek.safar@gmail.com>
8550 * cs-parser.jay: Better syntax error handling.
8552 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8553 instead of underlying type value.
8555 2007-02-06 Marek Safar <marek.safar@gmail.com>
8557 * driver.cs: Check define identifier before is registered.
8559 * namespace.cs: Use existing error message.
8561 * report.cs: New warning.
8563 2007-02-06 Marek Safar <marek.safar@gmail.com>
8565 A fix for bug #80742
8566 * expression.cs: Delegate Invoke method can be called directly.
8568 2007-02-06 Marek Safar <marek.safar@gmail.com>
8570 A fix for bug #80676
8571 * class.cs (IsEntryPoint): The Main method can have params modifier.
8573 2007-02-04 Miguel de Icaza <miguel@novell.com>
8575 * parameter.cs (Parameter, Parameters): Add Clone method.
8577 * anonymous.cs (Compatible): Turn method into virtual method, so
8578 LambdaExpression can implement a different behavior.
8580 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8581 out the basic checking here, so it can be used by
8584 * lambda.cs: Introduce "Compatible" function that will do the
8587 2007-02-02 Marek Safar <marek.safar@gmail.com>
8589 * attribute.cs: Unified one error message.
8591 * class.cs (Class): Use type attributes and not properties to test static
8593 (IsEntryPoint): Don's pass local variable.
8595 * convert.cs: Removed duplicate check.
8597 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8599 * driver.cs: Don't crash when soft reference does not exist.
8601 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8602 (UsingEntry): Removed redundant allocation.
8604 * parameter.cs: Add fast path for type parameters.
8606 * support.cs: Don't allocate attribute when it's not used.
8608 2007-01-30 Miguel de Icaza <miguel@novell.com>
8611 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8612 this into a virtual method, so we can override it in LambdaExpression.
8614 * driver.cs: Improve diagnostics in case of failure.
8616 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8617 write a function that is slightly more complex and that parses:
8619 type identifier [, type identifier]* )
8621 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8624 (canEmpty ? i >= 0 : i > 0)
8626 2007-01-30 Raja R Harinath <rharinath@novell.com>
8628 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8629 exception on possibly valid code.
8631 2007-01-29 Raja R Harinath <rharinath@novell.com>
8633 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8635 (parse_opt_type_arguments): Remove. It's almost the same as
8637 (parse_namespace_or_typename): Use parse_less_than.
8639 2007-01-28 Miguel de Icaza <miguel@novell.com>
8641 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8642 this bug took a few hours to find, because the state saved and
8643 restored by PushPosition and PopPosition was ignoring the state of
8644 parse_generic_less_than.
8646 I can also now remove the handling of OP_LT and OP_GT, this solves
8649 * cs-tokenizer.cs: store the location for the ARROW token, we use
8652 (PushPosition, PopPosition): save/restore also `current_token',
8653 restore `parse_generic_less_than' (was missing).
8655 (parse_opt_type_arguments): use parse_type, not
8656 parse_namespace_or_typename to parse types.
8658 * lambda.cs: Empty new file, will eventually have the lambda
8659 expression implementation.
8661 * lambda.test: used to test the internal tokenizer.
8663 * report.cs (FeatureIsNotISO1): Rename from
8664 FeatureIsNotStandardized, because it was about the language level
8665 (1 vs 2) it was not about standarization.
8667 (FeatureRequiresLINQ): New.
8669 * support.cs (SeekableStreamReader): Only require that the reader
8670 is a TextReader, not a StreamReader, so we can plug StringReader.
8672 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8673 given position in the input stream the following tokens can be
8674 parsed as a type followed by an identifier.
8676 (is_punct): after a '(' if parse_type_and_parameter returns true,
8677 then return a special token OPEN_PARENS_LAMBDA which is used to
8678 avoid reduce/reduce errors in the grammar for the
8679 lambda_expression rules.
8681 (parse_type): implement a type parser inside the
8682 tokenizer, the parser only returns true or false depending on
8683 whether the input at a given position can be parsed as a type.
8685 (peek_token): new method used during type parsing.
8687 2007-01-28 Raja R Harinath <rharinath@novell.com>
8690 * anonymous.cs (ScopeInfo.InflateParameters): New.
8691 (AnonymousContainer.Resolve): Use it to redirect types of
8692 delegate parameters.
8694 2007-01-27 Raja R Harinath <rharinath@novell.com>
8697 * expression.cs (Error_InvalidArguments): Don't use two different
8698 messages for CS1503. Use ExtraInformation and
8699 SymbolRelatedToPreviousError instead.
8702 * decl.cs (DeclSpace.initialize_type_params): Don't access
8703 'type_params' of a partial class directly.
8705 2007-01-26 Miguel de Icaza <miguel@novell.com>
8707 * constant.cs: Removed a handful of out-of-range checks that were
8710 2007-01-25 Marek Safar <marek.safar@gmail.com>
8712 * expression.cs (CheckUselessComparison): Add additional check for char
8715 * namespace.cs: Fixed typo.
8717 2007-01-23 Miguel de Icaza <miguel@novell.com>
8719 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8720 gone, instead we inline the test, preventing the needless casts to
8721 longs, ulongs and doubles for the parameters, avoiding calls to
8722 methods that overchecked stuff, and instead inlined things
8725 2007-01-20 Marek Safar <marek.safar@gmail.com>
8727 * cs-parser.jay: Better parameter error handling.
8729 2007-01-17 Marek Safar <marek.safar@gmail.com>
8731 A fix for bug #80368, #80522
8732 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8733 whether array initializer contains constants only.
8734 (ArrayCreation.Emit): Use better formula to decide when
8735 are array initializers for static initialization.
8736 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8737 have to emit even constants otherwise they are pre-initialized.
8739 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8740 Raja R Harinath <rharinath@novell.com>
8742 Fix emit order of 'get' vs. 'set'.
8743 * support.cs (Accessors): New.
8744 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8745 Note the order in which accessors are declared in the source.
8746 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8747 Refactored from Property.Define and Indexer.Define.
8748 (PropertyBase.DefineAccessors): New helper that calls the above in
8749 appropriate order as noted by the parser.
8750 (Property.Define, Indexer.Define): Update to changes.
8751 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8753 2007-01-17 Raja R Harinath <rharinath@novell.com>
8755 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8756 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8757 there's an implicit conversion from the current type to the target
8758 type before converting the underlying constant.
8760 2007-01-16 Marek Safar <marek.safar@gmail.com>
8762 * const.cs (ResolveValue): Updated after constant conversion was made more
8765 * constant.cs (GetAttributableValue): constant to object conversion is
8766 used for attributes only.
8767 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8768 constant conversions.
8769 (LongConstant.ConvertImplicitly): Ditto.
8771 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8772 (ImplicitConversionStandard): Handle constant conversion as extra step.
8773 It solves the issue when constant conversion was called indirectly like
8774 inside array initializer and constant folding was skipped.
8776 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8779 * statement.cs(ImplicitConversionStandard): Updated after constant
8780 conversion was made more generic.
8782 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8784 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8785 Constraints, solves the problem where the compiler incorrectly
8786 reported that a type parameter was not constrained to a class (Bug
8789 2007-01-14 Marek Habersack <grendello@gmail.com>
8791 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8793 2007-01-14 Marek Safar <marek.safar@gmail.com>
8795 A fix for bug #80368
8796 * assign.cs (FieldInitializer): New class implements field
8797 initializer statement.
8799 * attribute.cs: Update after FieldMember rename.
8801 * class.cs (PropertyBasedMember): New common class for property based
8803 (InterfaceMemberBase): New base class for all members which can be used as
8804 an interface members.
8805 (MethodCore): Moved really common code to InterfaceMemberBase.
8806 (Method.Define): Equal and GetHasCode detection is relevant for methods
8808 (MethodData.Define): Don't assume that public event implements an
8809 interface automatically.
8810 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8812 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8813 (FieldMember): Merged with FieldBase.
8814 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8815 event extern modifier can be used.
8816 (EventField.EventFieldAccessor): Moved event field specific code here.
8817 (Event.AllowedModifiers): Even event can be extern.
8818 (Event.FindOutBaseMethod): New override specific to events.
8819 (Indexer.parameters): Reintroduce parameters because base class holds
8820 only properties common data.
8821 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8822 need do extra parameters check.
8824 * const.cs: Update after FieldMember rename.
8826 * decl.cs (MemberCache.FindBaseEvent): New method.
8828 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8829 to reflect that indexer is now derived from PropertyBased.
8831 * ecore.cs (GetMemberType): Made public.
8832 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8835 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8837 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8838 (RegisterEvent): Removed.
8839 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8840 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8842 2007-01-11 Raja R Harinath <rharinath@novell.com>
8845 * statement.cs (CollectionForeach.TryType): Prefer generic
8846 GetEnumerator over non-generic variant. Fix code to follow comments.
8848 2007-01-09 Raja R Harinath <rharinath@novell.com>
8851 * support.cs (ReflectionParameter): Don't use an invalid index on
8852 the generic parameter data.
8854 2007-01-08 Miguel de Icaza <miguel@novell.com>
8856 * driver.cs: Just add a tiny bit of infrastructure.
8858 2007-01-02 Marek Safar <marek.safar@gmail.com>
8860 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8861 where field type is struct from current assembly.
8863 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8866 2007-01-02 Marek Safar <marek.safar@gmail.com>
8868 A fix for bug #80381
8869 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8872 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8874 (Namespace.LookupType): Always use core types from corlib when speficied.
8876 * report.cs: A new warning.
8878 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8879 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8880 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8882 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8883 (InitCoreTypes): Set expression type of object_type and value_type
8884 immediately after lookup.
8886 2007-01-01 Miguel de Icaza <miguel@novell.com>
8888 * cs-tokenizer.cs: Accept Pc class characters (Connector
8889 Punctuation) as valid identifiers. Fixes #78259
8891 * expression.cs (Invocation.DoResolve): Moved the check for the
8892 use of `this' for doing method calls to the Invocation resolution
8893 step, after overload resolution has taken place instead of doing
8894 the check at the low-level `This.DoResolve' level.
8896 The `This.DoResolve'(appens before overload resolution, so it has
8897 no way of knowing if the method that will be called will be
8898 instace or static, triggering an erroneous report for cs0188 (Bug
8901 We now do the check for instance method invocations after we know
8902 what method will be called.
8904 (This.CheckThisUsage): Move the actual use of this structure
8905 checking into its own method and expose it.
8907 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8910 Exceptions: Null.ConvertImplicitly,
8911 Constant.ImplicitConversionRequired as there are too many call
8912 sites for passing the ec.
8914 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8915 EmitContext, if the value is null, then we do not try to provide
8916 the extra information from the error (If a userdefined conversion
8917 exists, as UserDefinedConversion requires a non null-EmitContext).
8921 2006-12-30 Raja R Harinath <rharinath@novell.com>
8923 * flowanalysis.cs (MyBitVector): Document some invariants.
8924 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8925 introduced below, and add a couple of others,
8927 2006-12-30 Marek Safar <marek.safar@gmail.com>
8929 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8930 GetPropertyFromAccessor and GetEventFromAccessor.
8932 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8933 overrides non-obsolete one.
8934 (Indexer.Define): Error message has been moved to the parser.
8936 * cs-parser.jay: Better syntax errors handling.
8938 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8939 when an invocation has no arguments.
8941 * ecore.cs: Removed not used caching.
8943 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8946 * report.cs: Add a new warning.
8948 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8950 * typemanager.cs (enumeration_type): Removed.
8951 (CSharpSignature): Reuses IsSpecialMethod.
8952 (IsEqual): Hack for MS BCL.
8953 (GetPropertyFromAccessor): New method.
8954 (GetEventFromAccessor): New method.
8955 (IsSpecialMethod): Fixed to handle more cases.
8957 2006-12-30 Marek Safar <marek.safar@gmail.com>
8959 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8960 Made white spaces array static.
8962 * ecore.cs (RemoveGenericArity): Optimized.
8964 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8966 (MyBitVector.initialize_vector): Simplified.
8968 2006-12-22 Miguel de Icaza <miguel@novell.com>
8970 * ecore.cs: Am not entirely happy with this hack, but it seems to
8971 address the issue in 80257 (a small test case for
8974 I set the MethodGroupExpr.Type to an internal compiler type
8975 (itself in this case) to force the resolution to take place. Why
8976 it does not take place with a null is beyond me.
8978 2006-12-20 Marek Safar <marek.safar@gmail.com>
8980 A fix for bug #80288
8981 * expression.cs (ResolveOperator): Consider user defined conversion for
8982 logical and operator too.
8983 (EmitBranchable): Optimization for logical and when full constant folding
8984 could not be applied but one operand is constant.
8986 2006-12-19 Marek Safar <marek.safar@gmail.com>
8988 * class.cs (GetClassBases): Write 5 times every day, will never use
8989 FullName for error reporting.
8991 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8993 2006-12-19 Martin Baulig <martin@ximian.com>
8995 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8996 the symbol file info here.
8998 2006-12-18 Marek Safar <marek.safar@gmail.com>
9000 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9001 of `elseif' is taking then following sections are not taking.
9002 Fixes an issue reported on mono mailing list.
9004 2006-12-18 Marek Safar <marek.safar@gmail.com>
9006 A fix for bug #80300
9007 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9008 a caller is not taking.
9010 2006-12-18 Raja R Harinath <rharinath@novell.com>
9012 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9013 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9014 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9015 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9016 * class.cs: Update to changes.
9018 2006-12-17 Marek Safar <marek.safar@gmail.com>
9020 A fix for bug #79934
9021 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9024 * class.cs (ResolveMembers): Register an iterator in current container and
9027 2006-12-16 Raja R Harinath <rharinath@novell.com>
9030 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9031 satisfy a params annotated parameter.
9033 2006-12-16 Marek Safar <marek.safar@gmail.com>
9035 A fix for bug #77014
9036 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9037 paramters correctly and not rely on hacks in Parameters class.
9038 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9040 (Invocation.VerifyArgumentsCompat): Ditto.
9041 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9044 * parameter.cs (HasParams): Don't assume that params is the last one.
9046 * support.cs (ReflectionParameters.ctor): Look for params attribute
9048 (ReflectionParameters.ParameterType): Removed hack when we returned last
9049 parameter for out of range parameters.
9050 (ParameterName, ParameterModifier): Ditto.
9052 2006-12-14 Marek Safar <marek.safar@gmail.com>
9054 A fix for bug #79987
9055 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9056 when assembly is not CLS compliant but type is. I have no idea why is this
9059 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9061 2006-12-13 Miguel de Icaza <miguel@novell.com>
9063 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9064 in struct constructors, they are basically no-ops.
9066 2006-12-12 Marek Safar <marek.safar@gmail.com>
9068 * cs-tokenizer.cs (Position): Save preprocessor status too.
9070 2006-12-12 Marek Safar <marek.safar@gmail.com>
9072 A fix for bug #77794
9073 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9075 2006-12-12 Marek Safar <marek.safar@gmail.com>
9077 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9079 (pp_expr): Report error for an invalid expression.
9080 (handle_preprocessing_directive): Simplified; add more error checking.
9082 2006-12-11 Marek Safar <marek.safar@gmail.com>
9084 A fix for bug #74939
9085 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9086 directives handling.
9088 2006-12-10 Marek Safar <marek.safar@gmail.com>
9090 A fix for bugs #80093, and #75984
9091 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9092 logic, it seems to me as it worked before "by coincidence".
9093 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9094 (cleanup): Enabled endif check.
9096 2006-12-09 Marek Safar <marek.safar@gmail.com>
9098 A fix for bug #80162
9099 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9100 enumerators are never ambiguous.
9102 2006-12-08 Raja R Harinath <rharinath@novell.com>
9105 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9107 2006-12-06 Marek Safar <marek.safar@gmail.com>
9109 A fix for bug #80144
9110 * class.cs (EventProperty.Define): Explicit implementation means
9111 that an even is used.
9113 2006-12-06 Marek Safar <marek.safar@gmail.com>
9115 Fixes the operators implementation (part II)
9117 * cfold.cs (DoConstantNumericPromotions): Renamed to
9118 DoBinaryNumericPromotions and simplified.
9119 (BinaryFold): Couple of conversion fixes; simplified.
9121 * constant.cs, ecore.cs, literal.cs
9122 (ToType): Renamed to ConvertImplicitly.
9123 (Reduce): Renamed to ConvertExplicitly.
9125 * class.cs, convert.cs: Updated.
9127 * expression.cs: TryReduce doesn't throw an exception.
9129 2006-12-01 Marek Safar <marek.safar@gmail.com>
9131 A fix for bug #80108
9132 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9135 2006-11-30 Marek Safar <marek.safar@gmail.com>
9137 Fixes unary operators implementation (part I)
9140 * cfold.cs (Error_CompileTimeOverflow): Made internal
9142 * const.cs (IConstant): Changed to use reference to constant and
9143 not constant itself.
9144 Updated IConstant implementations.
9146 * constant.cs (CreateConstant): New factory method.
9147 Updated IConstant implementation.
9149 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9151 * ecore.cs: Updated to use CreateConstantReference.
9153 * enum.cs: Reflects IConstant changes.
9155 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9157 * literal.cs (NullConstant): Change to be independently usable.
9159 2006-11-29 Martin Baulig <martin@ximian.com>
9161 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9162 we need to emit the scope initializer before calling the base .ctor.
9164 * anonymous.cs: Merged back from the new anonymous methods branch.
9165 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9167 * expression.cs (ParameterReference.DoResolveBase): Create a
9168 "normal" ScopeInfo when capturing parameters rather than using the
9169 root scope; this makes things work with anonymous methods having
9173 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9175 2006-11-22 Marek Safar <marek.safar@gmail.com>
9177 A fix for bug #79987
9178 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9179 check to a base class.
9180 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9181 only when assembly has missing attribute.
9182 * report.cs: Update.
9184 2006-11-21 Marek Safar <marek.safar@gmail.com>
9186 * cs-tokenizer.cs: Merged with gmcs version.
9188 2006-11-20 Marek Safar <marek.safar@gmail.com>
9191 * cs-parser.jay: Better error message when partial keyword is misplaced.
9193 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9195 A fix for bug #79810
9196 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9197 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9198 a RuntimeWrappedException by default.
9200 2006-11-18 Marek Safar <marek.safar@gmail.com>
9202 A fix for bug #79843
9203 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9205 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9207 2006-11-18 Marek Safar <marek.safar@gmail.com>
9209 * driver.cs, namespace.cs: Uses faster IndexOf version.
9211 2006-11-17 Marek Safar <marek.safar@gmail.com>
9213 A fix for bug #79941
9214 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9216 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9217 even if internal name is different.
9218 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9219 (UserDefinedConversion): Simplified as the operators cannot be internal.
9220 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9222 (MethodLookup): Replaced EmitContext with parentType.
9223 * expression.cs: Updated.
9225 2006-11-09 Raja R Harinath <rharinath@novell.com>
9227 * driver.cs (BadAssembly): Handle all the ugliness of
9228 DefineDynamicAssembly.
9230 2006-11-08 Raja R Harinath <rharinath@novell.com>
9232 Address parts of #58244 -- most of what's left is in the runtime
9233 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9234 CS1509 error checks, and handle them for all assembly loads, not
9235 just the first invocation.
9236 (LoadModule): Likewise. Move handling of 'adder_method' ...
9237 * codegen.cs (AssemblyClass.AddModule): ... here.
9239 2006-11-02 Marek Safar <marek.safar@gmail.com>
9241 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9242 IEnumerable<T> is ambiguous.
9244 2006-10-31 Marek Safar <marek.safar@gmail.com>
9246 A fix for bug #67689
9247 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9248 GetEnumerator is ambiguous.
9250 * report.cs: Add new warning.
9252 2006-10-29 Marek Safar <marek.safar@gmail.com>
9254 A fix for bug #78602
9255 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9256 to protected member can be nested type.
9258 2006-10-28 Marek Safar <marek.safar@gmail.com>
9260 A fix for bug #78965
9261 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9262 to protected member must derive from current type.
9264 2006-10-27 Marek Safar <marek.safar@gmail.com>
9266 assign.cs: Reuses error method.
9268 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9269 instead of type for constants.
9270 (Expression.Error_ValueAssignment): Common error method.
9272 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9275 2006-10-27 Marek Safar <marek.safar@gmail.com>
9277 A fix for bug #79081
9278 * expression.cs (MemberAccess.DoResolve): Check nested type
9281 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9283 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9285 2006-10-26 Marek Safar <marek.safar@gmail.com>
9287 A fix for bug #76591
9288 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9290 2006-10-26 Marek Safar <marek.safar@gmail.com>
9292 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9293 type forwarder of the same type multiple times.
9295 2006-10-26 Raja R Harinath <rharinath@novell.com>
9298 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9299 instance as an rvalue, even when we later resolve as an lvalue.
9301 2006-10-25 Martin Baulig <martin@ximian.com>
9303 * anonymous.cs: Fix #79673.
9305 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9307 A fix for bug #79666
9308 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9309 ignored when is optimized (= default value) as its value is already set.
9311 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9313 A fix for bug #79724
9314 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9315 TypeContainer for type lookup.
9317 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9319 A fix for bug #79231
9320 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9321 * expression.cs (OverloadResolve): Always convert type name for
9323 (ResolveNamespaceOrType): Don't confuse a nested type with any
9326 2006-10-18 Martin Baulig <martin@ximian.com>
9328 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9330 2006-10-17 Miguel de Icaza <miguel@novell.com>
9332 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9333 an int32, but requesting an int64 from the conversion
9335 2006-10-12 Martin Baulig <martin@ximian.com>
9338 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9340 2006-10-12 Martin Baulig <martin@ximian.com>
9343 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9345 2006-10-11 Miguel de Icaza <miguel@novell.com>
9347 * convert.cs: Remove broken code: I was doing the "Existance"
9348 tests for Implicit conversions.
9350 2006-10-10 Miguel de Icaza <miguel@novell.com>
9352 * convert.cs: Added one missing case in
9353 ImplicitStandardConversionExists uint64 to intptr.
9357 * typemanager.cs (uintptr_type): another core known type.
9359 * ecore.cs (OperatorCast): routine used to do cast operations that
9360 depend on op_Explicit. We could change some of the Decimal
9361 conversions to use this.
9363 This one has a probe mechanism that checks both types for an op_
9364 which it coudl be used to eliminate two classes: CastToDecimal
9365 and CastFromDecimal.
9367 * convert.cs: Implement the conversions documented in #59800
9369 2006-10-10 Martin Baulig <martin@ximian.com>
9371 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9372 before RootScope.ResolveMembers().
9374 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9375 `CurrentType' if appropriate.
9377 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9379 A fix for bug #78568
9380 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9381 when contains binary operators.
9382 * cs-parser.jay: Updated.
9384 2006-10-09 Martin Baulig <martin@ximian.com>
9387 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9388 moved that into Define() and also do the other type parameter
9389 checks there. Fixes #79094. Added gtest-292.cs.
9392 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9393 since that doesn't include type parameters; don't use `Ldelema'
9394 for type parameters. Fixes #78980. Added gtest-293.cs.
9396 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9399 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9400 conversion is allowed.
9402 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9404 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9405 error reporting when no error occurs.
9407 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9409 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9412 2006-10-06 Raja R Harinath <rharinath@novell.com>
9415 * class.cs (DefineTypeBuilder): Check circular dependencies before
9416 setting the parent of the TypeBuilder.
9417 (CheckRecursiveDefinition): Don't use 'BaseType', since
9418 it may not be valid until after DefineTypeBuilder. Use
9419 'base_type' instead.
9421 2006-10-04 Martin Baulig <martin@ximian.com>
9423 Merged the Anonymous Methods patch.
9425 * anonymous.cs, iterators.cs: The new anonymous methods code.
9427 * statement.cs (Variable): New public abstract class.
9428 (LocalInfo.Variable): New public property.
9429 (LocalInfo.ResolveVariable): New public method.
9430 (Block.Flags): Add `IsIterator'.
9431 (Block.AddVariable): Improved the CS0136 check.
9432 (Block.AnonymousChildren): New public property.
9433 (Block.AddAnonymousChild): New public method.
9434 (ToplevelBlock): Update to use the new anonymous method framework.
9435 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9436 `ToplevelBlock'; this is required to correctly implement the
9438 (Fixed, Using): Use `TemporaryVariable' instead of directly
9439 creating the `LocalBuilder'.
9441 * parameter.cs (Parameter.ResolveVariable): New public method.
9442 (Parameters.ResolveVariable): Likewise.
9444 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9446 * class.cs (TypeContainer): Replaced the `iterators' list and
9447 corresponding methods with a list of `CompilerGeneratedClass'es.
9448 (TypeContainer.ResolveMembers): New public method.
9449 (Method): `IIteratorContainer' has been replaced by
9452 * expression.cs (VariableReference): New public abstract base
9453 class for `LocalVariableReference', `ParameterReference' and
9456 * codegen.cs (EmitContext): Removed `capture_context',
9457 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9458 (EmitContext.EmitThis): Removed.
9460 * cs-parser.jay: Replace `iterator_container' with
9463 2006-10-04 Martin Baulig <martin@ximian.com>
9465 * generic.cs (GenericMethod): Don't make this abstract.
9466 (Constraints.Clone): Added dummy implementation.
9468 2006-10-04 Raja R Harinath <harinath@gmail.com>
9471 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9472 'declspaces'. Avoid allocating arrays willy-nilly.
9475 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9476 cases out of the switch.
9478 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9480 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9481 message when non-generic type is used with the type arguments.
9482 * expression.cs: Updated.
9484 2006-09-28 Raja R Harinath <rharinath@novell.com>
9487 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9488 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9489 Change semantics slightly. Don't insist on having only one
9490 temporary EmptyExpression -- just throttle the creation of new ones.
9493 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9494 non-interfaces too. If no methods are found, don't try to create
9497 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9499 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9502 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9503 us produce better error message.
9505 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9507 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9508 of the `|' operator.
9510 * report.cs: A new warning added.
9512 2006-09-27 Martin Baulig <martin@ximian.com>
9514 * generic.cs (GenericMethod): Don't make this abstract.
9516 2006-09-27 Martin Baulig <martin@ximian.com>
9519 (InternalErrorException): Added overloaded ctor taking a params array.
9521 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9523 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9524 Fixed the cases when same error was reported twice.
9526 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9527 now report symbol information.
9529 2006-09-25 Martin Baulig <martin@ximian.com>
9531 * class.cs: Completely unified with the gmcs version.
9533 2006-09-25 Martin Baulig <martin@ximian.com>
9535 * typemanager.cs (TypeManager.IsNullableType): New public function.
9536 (TypeManager.IsNullableTypeOf): Likewise.
9537 (TypeManager.IsNullableValueType): Likewise.
9539 * class.cs (MethodCore): Added the `GenericMethod' argument from
9540 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9542 2006-09-24 Raja R Harinath <harinath@gmail.com>
9544 * convert.cs: Unify with gmcs version.
9546 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9548 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9549 verify them as well.
9551 * report.cs: New warning.
9553 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9555 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9556 for anonymous block with out argument.
9558 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9560 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9561 not used private events only.
9563 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9565 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9567 * const.cs (Const.Define): Check for constant type.
9568 (Const.IsConstantTypeValid): Looks for valid constant types.
9570 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9572 * ecore.cs (EmptyConstantCast): New common class for all constant based
9575 * expression.cs (Is.DoResolve): Handle null constant especially.
9576 (New.DoResolve): Check for new void().
9577 (MemberAccess.DoResolve): Cope with all kind of nulls.
9579 * literal.cs (NullConstant): Uses EmptyConstantCast.
9580 (NullDefault): Based on EmptyConstantCast.
9581 (NullLiteral): Uses EmptyConstantCast.
9583 * statement.cs (Block.ResolveMeta): Check for constant type.
9585 2006-09-22 Martin Baulig <martin@ximian.com>
9587 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9589 2006-09-22 Raja R Harinath <rharinath@novell.com>
9591 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9595 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9596 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9599 2006-09-22 Martin Baulig <martin@ximian.com>
9601 * ecore.cs: Merged with the gmcs version.
9603 * generic.cs (ConstructedType): New dummy class.
9604 (TypeArguments): Don't make this abstract.
9607 (TypeManager.IsGenericTypeDefinition): New method.
9608 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9610 2006-09-22 Raja R Harinath <rharinath@novell.com>
9612 * expression.cs (ComposedCast): Check for arrays of TypedReference
9613 before creating the type, not after.
9615 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9617 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9618 after ToType change.
9620 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9621 when constant must be implicitly convertible.
9623 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9625 * ecore.cs (NullCast): Derives from NullConstant.
9627 * expression.cs (Is.DoResolve): Removed useless variables.
9628 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9629 (New.Constantify): Add enum support.
9630 (MemberAccess.DoResolve): Add warning when accessing null constant or
9633 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9636 * literal.cs (NullConstant): New abstract class with common
9637 functionality for all null specializations.
9638 (NullDefault): Represents default(X) when result can be
9640 (NullLiteral): Updated.
9642 * report.cs: Add new warning.
9644 2006-09-21 Martin Baulig <martin@ximian.com>
9646 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9648 2006-09-21 Martin Baulig <martin@ximian.com>
9650 * generic.cs (GenericConstraints): New dummy class.
9651 (Constraints): Likewise.
9652 (TypeParameter): Likewise.
9653 (TypeParameterName): Likewise.
9654 (GenericMethod): Likewise.
9656 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9658 * decl.cs: Merged with the gmcs version.
9660 2006-09-21 Raja R Harinath <rharinath@novell.com>
9662 * generic.cs (TypeParameter): Implement IMemberContainer.
9663 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9665 * rootcontext.cs: Unify with gmcs version.
9667 * report.cs: Unify with gmcs version.
9668 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9669 from gmcs/generics.cs.
9670 * generics.cs (TypeParameter): New dummy class.
9672 * support.cs: Unify with gmcs version.
9674 2006-09-20 Raja R Harinath <rharinath@novell.com>
9676 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9677 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9679 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9680 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9681 * mcs.exe.sources: Add generic.cs.
9683 * codegen.cs: Unify with gmcs version.
9685 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9686 (EmitContext): Add GenericDeclContainer implementation.
9687 * decl.cs (MemberCore, DeclSpace): Likewise.
9688 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9690 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9691 MCS TypeManager has a corresponding dummy method.
9693 2006-09-19 Martin Baulig <martin@ximian.com>
9695 * expression.cs: Completely merged with the gmcs version.
9697 2006-09-19 Martin Baulig <martin@ximian.com>
9699 * expression.cs (Invocation): Merged with the gmcs version.
9700 (ArrayAccess.GetStoreOpcode): Likewise.
9702 2006-09-19 Martin Baulig <martin@ximian.com>
9705 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9706 (TypeManager.IsGenericMethodDefinition): Likewise.
9708 2006-09-19 Martin Baulig <martin@ximian.com>
9711 (TypeManager.IsEqual): Moved the gmcs implementation here.
9712 (TypeManager.DropGenericTypeArguments): Likewise.
9713 (TypeManager.DropGenericMethodArguments): Likewise.
9714 (TypeManager.GetTypeArguments): Moved here from gmcs.
9715 (TypeManager.HasGenericArguments): Likewise.
9717 2006-09-19 Martin Baulig <martin@ximian.com>
9719 * expression.cs (Binary): Merged with the gmcs version.
9721 2006-09-19 Martin Baulig <martin@ximian.com>
9723 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9725 2006-09-19 Martin Baulig <martin@ximian.com>
9727 * typemanager.cs: Merged with the gmcs version.
9729 2006-09-16 Raja R Harinath <rharinath@novell.com>
9731 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9732 * driver.cs: Likewise.
9734 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9737 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9738 only if parent type is class.
9739 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9742 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9745 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9747 * typemanager.cs(CSharpName): Converts NullType to null.
9749 2006-09-15 Martin Baulig <martin@ximian.com>
9752 (TypeManager.GetMethodName): Added mcs implementation.
9753 (TypeManager.IsEqual): Likewise.
9756 (SimpleName.RemoveGenericArity): Added dummy implementation.
9758 * pending.cs: Merged with the gmcs version.
9760 2006-09-15 Martin Baulig <martin@ximian.com>
9762 * statement.cs: Merge with the gmcs version.
9764 2006-09-15 Martin Baulig <martin@ximian.com>
9766 * statement.cs (Switch): Merge with the gmcs implementation
9767 (without nullables), which is newer.
9769 2006-09-15 Martin Baulig <martin@ximian.com>
9771 * statement.cs (Block.Variables): Make this public.
9772 (ToplevelBlock.Parameters): Make this a property.
9773 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9775 2006-09-15 Martin Baulig <martin@ximian.com>
9777 * namespace.cs: Merge with the gmcs version.
9779 2006-09-15 Martin Baulig <martin@ximian.com>
9781 * decl.cs (MemberName): Minor code cleanups.
9783 2006-09-15 Martin Baulig <martin@ximian.com>
9785 * parameter.cs: Merge with the gmcs version.
9787 2006-09-15 Martin Baulig <martin@ximian.com>
9789 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9790 and an error in mcs.
9792 2006-09-15 Martin Baulig <martin@ximian.com>
9794 * flowanalysis.cs: Merged from GMCS; added the generics code into
9795 a `GMCS_SOURCE' conditional so we can share this file.
9797 2006-09-08 Martin Baulig <martin@ximian.com>
9799 * typemanager.cs (TypeManager.interlocked_type): New public field.
9800 (TypeManager.int_interlocked_compare-exchange): New public field.
9801 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9802 enumerator types here and call InitGenericCoreTypes().
9803 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9804 after calling InitEnumUnderlyingTypes().
9807 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9808 `classes_second_stage'.
9810 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9812 * assign.cs, ecore.cs, expression.cs: Share error message text.
9813 * class.cs (FieldMember.Define): Check for varible of static type.
9814 * driver.cs (LoadAssembly): Uses error output for errors.
9815 * statement.cs: Updated.
9817 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9819 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9822 2006-09-07 Martin Baulig <martin@ximian.com>
9825 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9827 2006-08-29 Miguel de Icaza <miguel@novell.com>
9829 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9831 2006-08-17 Miguel de Icaza <miguel@novell.com>
9833 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9834 #52019 and #79064, the use of the \uXXXX sequence in source code
9835 to represent unicode characters.
9837 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9839 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9841 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9843 2006-08-13 Miguel de Icaza <miguel@novell.com>
9845 * assign.cs: Catch attempts to assign to a method groups in += and
9848 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9851 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9853 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9855 * class.cs (Method.Define): Issue a warning when generic method looks like
9857 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9860 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9862 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9864 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9865 search all base interfaces as a member can be ambiguous.
9866 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9867 Constructor member type filter.
9868 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9869 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9870 reporting for returned memberinfos.
9871 * report.cs: Updated.
9872 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9873 version to work on all runtimes.
9874 (TypeManager.RealMemberLookup): Removed members filtering.
9876 2006-08-08 Raja R Harinath <rharinath@novell.com>
9878 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9879 (PropertyExpr.EmitAssign): Likewise.
9880 * expression.cs (Indirection.EmitAssign): Likewise.
9881 (LocalVariableReference.EmitAssign): Likewise.
9882 (ParameterReference.EmitAssign): Likewise.
9883 (Invocation.EmitArguments): Likewise.
9884 (ArrayAccess.EmitAssign): Likewise.
9885 (IndexerAccess.EmitAssign): Likewise.
9886 (This.EmitAssign): Likewise.
9887 (ConditionalLogicalOperator.Emit): Likewise.
9890 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9891 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9892 leave it in after returning it.
9893 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9895 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9897 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9900 2006-08-03 Raja R Harinath <rharinath@novell.com>
9902 Fix cs0146-3.cs and cs0146-4.cs.
9903 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9904 enclosing types don't depend on the current type.
9906 2006-08-02 Raja R Harinath <rharinath@novell.com>
9909 * class.cs (TypeContainer.DoDefineMembers): Use
9910 FindBaseMemberWithSameName on Parent, since we're interested in
9911 whether we hide inherited members or not.
9912 (FindBaseMemberWithSameName): Make slightly more robust.
9914 Fix the non-generic testcase from #77396
9915 * decl.cs (DeclSpace.DeclContainer): Remove override.
9917 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9918 declspaces for doppelgangers too.
9919 (UsingEntry): Implement IResolveContext.
9920 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9921 'this' as the resolve context.
9922 (LocalAliasEntry): Likewise.
9924 Implement parts of #77403
9925 * roottypes.cs (RootDeclSpace): New. Used to represent the
9926 toplevel declaration space. Each namespace declaration introduces
9927 a "partial" root declaretion space.
9928 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9929 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9930 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9931 from 'current_namespace.SlaveDeclSpace'.
9932 (namespace_declaration): Likewise.
9933 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9934 check. It can't happen now.
9935 * decl.cs (DeclSpace.LookupType): Likewise.
9936 * driver.cs (MainDriver): Sanity check.
9938 2006-08-01 Raja R Harinath <rharinath@novell.com>
9940 * decl.cs (DeclSpace.FindNestedType): Remove.
9941 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9942 LookupTypeContainer to get the container of the nested type.
9943 * class.cs (TypeContainer.FindNestedType): Make non-override.
9945 2006-07-31 Raja R Harinath <rharinath@novell.com>
9947 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9948 * class.cs (TypeContainer.PartialContainer): ... here.
9949 (TypeContainer.AddBasesForPart): New helper.
9950 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9952 * cs-parser.jay (current_class): Convert to DeclSpace.
9953 (struct_declaration, interface_declaration, class_declaration):
9954 Use AddBasesForPart instead of .Bases directly.
9955 * const.cs, iterators.cs: Update to changes.
9957 2006-07-28 Raja R Harinath <rharinath@novell.com>
9959 * class.cs (TypeContainer.AddMemberType): Rename from
9961 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9962 (AddTypeContainer): New. Combine AddClassOrStruct and
9964 (AddPartial): Update. Add 'is_partial' argument.
9965 * roottypes.cs: Update to changes.
9966 * cs-parser.jay (push_current_class): New helper for handling
9967 current_container and current_class.
9968 (struct_declaration, interface_declaration, class_declaration):
9971 2006-07-26 Raja R Harinath <rharinath@novell.com>
9973 * roottypes.cs: Rename from tree.cs.
9975 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9976 * tree.cs (Tree, ITreeDump): Remove types.
9977 * rootcontext.cs (tree, Tree): Remove fields.
9978 (root, ToplevelTypes): New.
9979 * *.cs: Update to rename.
9981 * tree.cs (Tree.RecordDecl): Remove.
9982 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9984 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9986 2006-07-23 Raja R Harinath <harinath@gmail.com>
9988 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9989 DoFlowAnalysis and OmitStructFlowAnalysis here.
9990 (ec.With): Rename from WithUnsafe and generalize.
9991 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9992 (ec.WithFlowAnalyis): New.
9993 * ecore.cs, expression.cs, statement.cs: Update.
9995 2006-07-22 Raja R Harinath <harinath@gmail.com>
9997 * statement.cs (Block.ResolveMeta): Simplify slightly.
9999 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10000 multiple boolean fields. Convert InUnsafe, constant_check_state,
10001 check_state to flags.
10002 (CheckState, ConstantCheckState): Update.
10003 (InUnsafe): New read-only property.
10004 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10006 (WithUnsafe): New helper similar to WithCheckState.
10007 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10008 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10010 2006-07-21 Raja R Harinath <rharinath@novell.com>
10012 Make comparisons use the same IL irrespective of whether they're
10013 in a 'checked' or 'unchecked' context: one of the issues in #78899
10014 * codegen.cs (EmitContext.CheckState): Make read-only property.
10015 (EmitContext.ConstantCheckState): Likewise.
10016 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10017 helper that implement a save/restore stack for CheckState
10018 values. This is the only way to change check-state.
10019 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10020 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10021 (CheckedExpr.EmitBranchable): New forwarding method.
10022 (UnCheckedExpr): Likewise.
10023 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10024 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10025 (Checked.Resolve, checked.DoEmit): Likewise.
10027 2006-07-20 Miguel de Icaza <miguel@novell.com>
10029 * anonymous.cs: Cache the resolved anonymous delegate, and return
10030 this so that the ResolveTopBlock is only triggered once, not
10033 Currently we trigger ResolvetopBlock twice due to a first pass of
10034 argument check compatibility, and a second pass that does the
10037 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10039 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10041 * rootcontext.cs (Reset): Add helper_classes.
10043 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10046 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10049 2006-07-13 Miguel de Icaza <miguel@novell.com>
10051 * statement.cs (Lock): Handle expressions of type
10052 TypeManager.null_type specially. Fixes #78770
10054 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10056 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10059 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10061 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10062 for accessors as well.
10063 * ecore.cs (EventExpr): Add AccessorTable.
10065 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10068 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10069 for CS0122 where appropriate.
10070 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10072 (Filter): Assembly can be null in the case of top level attributes.
10074 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10078 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10079 is done at global level.
10081 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10083 A fix for #77002, Implemented TypeForwarder support.
10085 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10086 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10087 * typemanager.cs (): Add type_forwarder_attr_type.
10089 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10091 * report.cs: Add CS0469 warning.
10093 2006-06-21 Martin Baulig <martin@ximian.com>
10095 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10096 the `try'-block, so we also report CS0016 etc. there.
10098 2006-06-21 Martin Baulig <martin@ximian.com>
10101 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10103 2006-06-21 Martin Baulig <martin@ximian.com>
10105 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10106 also report CS1686 for parameters.
10108 2006-06-21 Martin Baulig <martin@ximian.com>
10110 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10111 instead of an error if the value is not implicitly convertible to
10112 the switch types; fixes #77964.
10114 2006-06-21 Raja R Harinath <rharinath@novell.com>
10117 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10118 FieldBuilder is null.
10121 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10122 'left' and 'right' before error-checking.
10124 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10126 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10128 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10129 (FieldExpr.DoResolve): likewise.
10130 (PropertyExpr.InstanceResolve): likewise.
10131 (EventExpr.InstanceResolve): likewise.
10133 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10135 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10136 attribute applicable tests for attribute argument.
10138 2006-06-02 Raja R Harinath <rharinath@novell.com>
10141 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10142 (Binary.OverloadResolve_PredefinedIntegral): New.
10143 (Binary.OverloadResolve_PredefinedFloating): New.
10144 (Binary.OverloadResolve_PredefinedString): New.
10145 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10146 Follow the standard more closely, and treat numeric promotions in
10147 terms of overload resolution.
10148 (Binary.CheckShiftArguments): Simplify.
10150 2006-06-01 Raja R Harinath <rharinath@novell.com>
10152 * flowanalysis.cs (MyBitVector): Simplify representation.
10153 (MyBitVector.Clone): Avoid allocating BitArray.
10154 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10155 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10156 (*): Update. Change all references to MyBitVector.And and
10157 MyBitVector.Or to &= and |=.
10159 2006-05-29 Raja R Harinath <rharinath@novell.com>
10161 Fix cs0231-[34].cs.
10162 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10163 to param arguments too.
10165 2006-05-26 Miguel de Icaza <miguel@novell.com>
10167 * cs-parser.jay: Catch another parsing form for arglist being
10168 followed by other arguments. Fixes #78313.
10170 2006-05-24 Raja R Harinath <rharinath@novell.com>
10172 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10173 checking of out parameters to ...
10174 (FlowBranchingToplevel.Merge): ... here.
10175 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10176 set, propagate the origin upward, and only complain if there was
10178 (FlowBranchingException.AddContinueOrigin): Likewise.
10179 (FlowBranchingException.AddReturnOrigin): Likewise.
10180 (FlowBranchingException.AddGotoOrigin): Likewise.
10182 2006-05-23 Raja R Harinath <rharinath@novell.com>
10184 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10185 unreachable, skip it.
10186 (FlowBranchingException.Merge): Always propagate jumps, even if
10187 the finally block renders subsequent code unreachable.
10189 2006-05-18 Raja R Harinath <rharinath@novell.com>
10192 * statement.cs (Goto.Resolve): Move responsibility for resolving
10193 'goto' to FlowBranching.AddGotoOrigin.
10194 (Goto.SetResolvedTarget): New. Callback to set the
10195 LabeledStatement that's the target of the goto.
10196 (Goto.DoEmit): Use Leave instead of Br when crossing an
10197 unwind-protect boundary.
10198 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10199 LookupLabel and adjust to new semantics.
10200 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10201 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10202 Goto.SetResolvedTarget to update target.
10203 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10204 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10205 AddBreakOrigin & co. Delay propagation until ...
10206 (FlowBranchingException.Merge): ... this.
10208 * statement.cs (Block.Resolve): Always depend on flow-branching to
10209 determine unreachability. Kill workaround that originally emitted
10210 only one statement after an "unreachable" label (see infloop in
10213 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10214 This is still "wrong", but anything better would probably need a
10215 multi-pass algorithm.
10216 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10217 usage vector. Force current usage vector to be reachable, to
10218 optimistically signify backward jumps.
10219 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10221 (FlowBranchingLabeled.Merge): New. If no backward jump was
10222 detected, return the original salted-away usage vector instead,
10223 updated with appropriate changes. Print unreachable warning if
10225 * statement.cs (Block.Resolve): Don't print unreachable warning on
10226 a labeled statement.
10228 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10230 * driver.cs: Pass filename without path to AssemblyBuilder's
10231 AddResourceFile. Fixes bug #78407.
10233 2006-05-17 Raja R Harinath <rharinath@novell.com>
10235 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10236 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10237 (FlowBranching.MergeChild): Overwrite
10238 reachability information from Labeled branchings too.
10240 2006-05-16 Raja R Harinath <rharinath@novell.com>
10242 * statement.cs (Goto.Resolve): Merge jump origins here ...
10243 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10245 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10246 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10247 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10248 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10250 * statement.cs (Goto.Resolve): ... not here.
10251 (Goto.Emit): Remove CS1632 check.
10253 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10255 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10258 2006-05-11 Raja R Harinath <rharinath@novell.com>
10260 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10261 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10262 (FlowBranchingException.Label): Likewise.
10264 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10266 (MyBitVector.Or): Use it to avoid losing information (Count).
10267 (FlowBranching.MergeOrigins): Likewise.
10269 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10270 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10271 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10272 (UsageVector.ToString): Simplify.
10273 (UsageVector.MergeSiblings): Move here from ...
10274 (FlowBranching.Merge): ... here.
10275 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10278 2006-05-10 Raja R Harinath <rharinath@novell.com>
10280 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10281 null bitvector is treated as all-true.
10283 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10284 (MyBitVector): Rationalize invariants. 'vector != null' implies
10285 that we have our own copy of the bitvector. Otherwise,
10286 'InheritsFrom == null' implies all inherited bits are true.
10288 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10290 * statement.cs (LocalInfo): Add IsConstant.
10291 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10292 local variable for constants.
10294 2006-05-09 Raja R Harinath <rharinath@novell.com>
10296 * flowanalysis.cs (MyBitVector.Empty): New.
10297 (MyBitVector): Don't allow InheritedFrom to be null.
10298 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10299 (UsageVector, FlowBranching): Update to changes.
10301 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10302 recursion. The 'Parent == null' condition isn't sufficient for
10304 (FlowBranching.AddBreakOrigin): Likewise.
10305 (FlowBranching.AddContinueOrigin): Likewise.
10306 (FlowBranching.AddReturnOrigin): Likewise.
10307 (FlowBranching.StealFinallyClauses): Likewise.
10308 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10309 (FlowBranching.CheckOutParameters): Likewise.
10310 (FlowBranchingToplevel): Terminate all the above recursions here.
10311 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10312 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10314 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10316 (FlowBranchingToplevel): New. Empty for now.
10317 (FlowBranching.MergeTopBlock): Update.
10318 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10319 branching for the anonymous delegate.
10320 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10322 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10323 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10324 information at the start of the merge. Reorganize.
10326 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10328 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10330 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10332 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10333 to newly introduced ctor.
10335 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10336 message to one place.
10337 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10340 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10342 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10344 * ecore.cs (Expression.ResolveAsConstant): Updated.
10346 * statement.cs (ResolveMeta): Updated.
10348 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10350 * cs-parser.jay: __arglist cannot be used in initializer.
10352 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10355 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10358 2006-05-05 Raja R Harinath <rharinath@novell.com>
10360 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10361 (LabeledStatement): Add 'name' parameter.
10362 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10363 (Block.AddLabel): Update to changes.
10364 * cs-parser.jay (labeled_statement): Likewise.
10366 * flowanalysis.cs (BranchingType.Labeled): New.
10367 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10368 (FlowBranchingLabeled): New. Does nothing for now, but will
10369 eventually handle 'goto' flows.
10370 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10371 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10372 that's terminated ...
10373 (Block.Resolve): ... here.
10375 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10376 (UsageVector.MergeFinallyOrigins): Likewise.
10377 (FlowBranching.InTryOrCatch): Likewise.
10378 (FlowBranching.AddFinallyVector): Likewise.
10379 (FlowBranchingException): Update to changes.
10382 * statement.cs (Return.Resolve): Move error checking to ...
10383 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10384 (FlowBranchingException): Handle return origins like break and
10386 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10388 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10391 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10394 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10397 * class.cs (MethodData.Define): Do public accessor check only when method
10398 implements an interface.
10400 2006-05-04 Raja R Harinath <rharinath@novell.com>
10402 Remove special handling of 'break'
10403 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10404 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10405 (UsageVector.Break): Remove.
10406 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10408 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10410 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10411 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10413 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10416 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10417 be the interface member.
10419 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10422 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10423 for emitting small (int) values.
10425 2006-05-03 Raja R Harinath <rharinath@novell.com>
10428 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10429 control-flow passes through the 'finally' after merging-in all the
10430 control-flows from 'try' and the 'catch' clauses.
10432 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10433 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10434 always true at the only non-recursive entry point.
10435 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10436 FlowBranchingBreakable.
10437 (FlowBranchingLoop): Remove.
10438 * statement.cs (Return.DoResolve): Update to changes.
10441 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10442 (FlowBranching.CreateBranching): Handle it: create a
10443 FlowBranchingContinuable.
10444 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10445 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10446 except that it handles the 'continue' command.
10447 (FlowBranching.UsageVector.MergeOrigins): Rename from
10449 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10450 except that it overrides AddContinueOrigin.
10451 (FlowBranchingException): Override AddContinueOrigin, similar to
10453 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10454 Create a new branching around the embedded statement.
10455 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10456 control flow after the embedded statement.
10457 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10459 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10460 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10461 FlowBranchingBreakable.
10462 (FlowBranchingSwitch): Remove.
10465 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10466 error reporting to ...
10467 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10468 Rename from 'AddBreakVector'. Add new location argument. Return
10469 a bool indicating whether the 'break' crosses an unwind-protect.
10470 (FlowBranchingException.AddBreakOrigin): Add.
10471 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10472 flowbranching after updating with the effects of the 'finally'
10474 (FlowBranchingBreakable): New common base class for
10475 FlowBranchingLoop and FlowBranchingSwitch.
10477 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10478 embedded statement.
10479 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10481 2006-05-02 Raja R Harinath <rharinath@novell.com>
10483 * statement.cs (Do.Resolve): If the loop is infinite, set the
10485 (While.Resolve, For.Resolve): Set a barrier after the embedded
10486 statement. There's no direct control flow that goes from the end
10487 of the embedded statement to the end of the loop.
10488 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10489 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10490 above ensure that the reachability is correctly computed.
10492 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10493 (UsageVector.MergeBreakOrigins): If the current path is
10494 unreachable, treat it as if all parameters/locals are initialized.
10495 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10496 infinite loops before merging-in break origins.
10498 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10499 (Reachability.Reachable): Split part into ...
10500 (Reachability.Unreachable): ... this. Simplify.
10501 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10503 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10504 (Reachability.SetThrowsSometimes): Likewise.
10505 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10506 TriState.Always, use corresponding property.
10507 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10508 (Block.Resolve): Likewise. Remove some redundant checks.
10510 2006-05-02 Raja R Harinath <harinath@gmail.com>
10512 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10513 (Reachability.Meet): Don't bother checking AlwaysThrows --
10514 barrier is always set.
10515 (FlowBranchingBlock.Merge): Likewise.
10517 2006-05-01 Raja R Harinath <harinath@gmail.com>
10519 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10520 checks for unreachable.
10522 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10525 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10527 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10528 whether field is really assigned.
10530 2006-04-30 Raja R Harinath <harinath@gmail.com>
10532 * flowanalysis.cs (Reachability): Make 4-argument constructor
10534 (Reachability.Meet): Rename from 'And'. Remove static variant.
10535 (Reachability.Always): Rename from the highly misleading
10536 'Reachability.Never'.
10537 (FlowBranching.Merge): Update to changes. Mark an impossible
10538 situation with a 'throw'.
10539 (*): Update to changes.
10541 2006-04-29 Raja R Harinath <harinath@gmail.com>
10543 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10544 Remove 'Undefined'.
10545 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10546 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10547 (*): Update to changes.
10548 * statement.cs: Update to changes.
10550 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10553 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10555 2006-04-28 Raja R Harinath <harinath@gmail.com>
10557 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10560 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10561 argument to two arguments: an usage-vector and a bool. Move call
10562 to FlowBranching.Merge () ...
10563 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10565 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10566 handling of loop and switch reachability to ...
10567 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10569 2006-04-27 Raja R Harinath <harinath@gmail.com>
10571 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10572 handling to FlowBranchingLoop.InLoop.
10573 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10575 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10578 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10579 anonymous method is allowed from AnonymousContainer here.
10581 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10583 2006-04-24 Raja R Harinath <rharinath@novell.com>
10586 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10588 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10591 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10592 (DoubleConstant.Reduce): Ditto.
10594 2006-04-23 Raja R Harinath <rharinath@novell.com>
10596 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10597 Remove 'lvalue_right_side' argument. Move parts to ...
10598 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10599 (LocalVariable.DoResolveLValue): ... these.
10601 2006-04-21 Raja R Harinath <rharinath@novell.com>
10604 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10605 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10606 (LocalVariableReference.DoResolveBase): Use it to implement new
10608 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10609 (Argument.Resolve): Simplify. Move CS1510 check ...
10610 * ecore.cs (Expression.ResolveLValue): ... here.
10611 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10612 (PropertyExpr.DoResolveLValue): Likewise.
10613 (FieldExpr.Report_AssignToReadonly): Likewise.
10614 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10615 LValueMemberAccess or LValueMemberOutAccess on instance depending
10617 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10618 DoResolve as appropriate.
10620 2006-04-20 Raja R Harinath <rharinath@novell.com>
10623 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10624 implicit conversions on 'out' and 'ref' arguments.
10626 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10627 improve clarity. Remove dead code.
10630 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10631 (Catch.Resolve): Resolve VarBlock if it exists.
10633 2006-04-19 Miguel de Icaza <miguel@novell.com>
10635 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10636 twice, this was some residual code, the enumerator was emitted
10637 properly in the two branche of if later.
10639 2006-04-19 Raja R Harinath <rharinath@novell.com>
10641 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10642 cast is never an lvalue.
10643 (Cast.DoResolve, Cast.ResolveRest): Combine.
10644 (Argument.Emit): Simplify slightly. Move 'Expr is
10645 IMemoryLocation' check ...
10646 (Argument.Resolve): ... here.
10647 (Argument.Error_LValueRequired): Remove. Inline into only user.
10649 Simplifications. Fix cs0191-2.cs
10650 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10651 CS1649 and CS1651 to ...
10652 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10653 the actual selection of the error code and message to a lookup
10654 table. Add a dummy return value to simplify callsites.
10655 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10656 readonly fields of other instances of the same type. Move CS0197
10658 * expression.cs (Argument.Resolve): ... here. Simplify code.
10659 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10660 resolution of an out or ref argument. The code simplification
10661 above uses this invariant.
10663 2006-04-18 Raja R Harinath <rharinath@novell.com>
10665 Possibly fix #77752. Fix cs1690-[4-7].cs.
10666 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10667 CheckMarshallByRefAccess. Drop parameter.
10668 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10670 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10671 InstanceExpression.
10672 * report.cs (AllWarnings): Add CS1690.
10673 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10674 for ref access too.
10675 (LocalVariableReference.DoResolveBase): Update.
10677 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10679 * class.cs (MethodOrOperator): Moved common parts from method class.
10680 detect obsolete attributes.
10681 (Method.Define): Simplified as it reuses code from base.
10682 (Constructor.ValidAttributeTargets): Fixed issue found during
10684 (Destructor.ValidAttributeTargets): Fixed issue found during
10686 (Operator): Finished refactoring set off by #78020. Operator class is now
10687 ordinary method class.
10689 * anonymous.cs: Updated.
10691 * decl.cs (DeclSpace): Add IsGeneric
10693 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10695 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10697 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10699 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10700 detect obsolete attributes.
10701 (Method.CreateEmitContext): Moved to MethodOrOperator.
10703 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10706 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10707 customized exception to make crash detection easier.
10708 (MethodOrOperator): Started to work on new base class for methods and
10710 (Method): Derives from MethodOrOperator.
10711 (Constructor.Emit): Emits its own attributes.
10712 (AbstractPropertyEventMethod.Emit): Ditto.
10713 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10715 (Operator.Emit): It's temporary more tricky than should be.
10717 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10719 * report.cs (InternalErrorException): Add ctor with inner exception.
10721 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10724 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10727 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10730 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10733 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10735 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10736 attribute is present and Guid not.
10737 (Interface.ApplyAttributeBuilder): Ditto.
10739 * attribute.cs: Add error message.
10741 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10745 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10746 sources (it's composite) so hold them in extra array as they are used in
10747 Emit phase only. It worked in the previous versions by mistake.
10748 (Attribute.Emit): Emit attribute for more owners when exist.
10750 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10751 it has now different behaviour.
10753 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10755 * constant.cs (Constant.IsDefaultInitializer): New method.
10757 * class.cs: Updated.
10759 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10760 re-initialize default values. It saves KBs almost for every assembly.
10761 Thanks Zoltan for the idea.
10762 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10763 (ArrayCreation.DoResolve): Resolve only once.
10764 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10765 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10767 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10769 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10772 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10774 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10775 in an embedded statement too.
10777 2006-04-01 Raja R Harinath <rharinath@novell.com>
10780 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10782 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10786 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10789 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10791 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10793 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10796 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10797 LocalTemporary change.
10799 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10801 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10802 initializers optimization.
10803 (ClassOrStruct.TypeAttr): Moved from modifiers.
10804 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10805 (FieldBase.ResolveInitializer): Resolves initializer.
10806 (FieldBase.HasDefaultInitializer): New property.
10808 * cs-parser.jay: Removed message.
10810 * expression.cs (CompilerGeneratedThis): New specialization.
10812 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10814 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10816 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10818 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10820 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10821 be now EnumConstants only.
10823 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10825 * attribute.cs, driver.cs: Reset more caches.
10827 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10829 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10831 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10833 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10834 for easier reuse. Updated all overrides.
10835 (IntegralConstant): New base class for all integral constants.
10836 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10837 of the constant range, report custom error.
10838 (UIntConstant.Reduce): Fixed uint conversion.
10840 * ecore.cs, literal.cs: Reduce updates.
10842 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10846 * class.cs (Constructor.Define): Removed extra if for default ctors.
10847 A patch from Atsushi Enomoto.
10849 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10851 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10852 GetAttributableValue.
10854 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10857 * convert.cs (ImplicitConversionRequired): Error message moved to
10860 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10861 automatic implicit conversion of an output value.
10862 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10864 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10866 (TypeOf.GetAttributableValue): Add extra handling for object type.
10868 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10869 special error message.
10871 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10873 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10875 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10876 compatible with MS runtime.
10878 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10880 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10881 attribute arguments here.
10883 * class.cs (Indexer.Define): The check was moved to attribute class.
10885 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10887 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10888 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10891 2006-03-22 Raja R Harinath <rharinath@novell.com>
10893 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10894 mcs to keep code differences small.
10895 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10896 * typemanager.cs (parameter_default_value_attribute_type): New.
10897 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10900 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10902 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10904 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10906 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10908 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10911 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10913 * doc-bootstrap.cs : fix build.
10915 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10917 * expression.cs (StringConcat.Append): Issue a warning when empty string
10918 is going to append.
10920 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10922 * assign.cs (CompoundAssign.ResolveSource): Removed.
10924 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10927 * class.cs (TypeContainer.FindMethods): Removed.
10928 (TypeContainer.CheckMemberUsage): Made static.
10930 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10932 * constant.cs (CheckRange): Removed unused type argument.
10933 (CheckUnsigned): Removed unused type argument.
10935 * cs-parser.jay: Updated after MemberAccess clean up.
10936 Uses Length for empty string test.
10938 * cs-tokenizer.cs: Uses Length for empty string test.
10939 (IsCastToken): Made static.
10940 (is_hex): Made static.
10941 (real_type_suffix): Made static.
10943 * decl.cs (SetupCache): Made static.
10944 (OnGenerateDocComment): Removed unused ds argument.
10946 * delegate.cs (VerifyDelegate): Removed unused argument.
10948 * doc.cs: Uses Length for empty string test.
10950 * driver.cs: Uses Length for empty string test.
10952 * enum.cs (IsValidEnumType): Made static
10954 * expression.cs (EnumLiftUp): Removed unused argument.
10955 (ResolveMethodGroup): Ditto.
10956 (BetterConversion): Ditto.
10957 (GetVarargsTypes): Ditto.
10958 (UpdateIndices): Ditto.
10959 (ValidateInitializers): Ditto.
10960 (MemberAccess.ctor): Ditto.
10961 (GetIndexersForType): Ditto.
10963 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10965 * iterators.cs: Updated after MemberAccess clean up.
10967 * location.cs: Uses Length for empty string test.
10969 * namespace.cs: Uses Length for empty string test.
10971 * report.cs (CheckWarningCode): Made static.
10973 * statement.cs (LabeledStatement): Removed unused argument.
10975 * typemanager.cs (FilterNone): Removed.
10977 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10979 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10982 * class.cs: Updated.
10984 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10986 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10988 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10992 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10993 reporting, it's more tricky than I thought.
10995 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10999 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11001 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11002 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11003 Add more error reporting; Fixed issue with params.
11005 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11007 * cs-parser.jay: AnonymousMethod requires host container.
11009 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11011 2006-03-18 Raja R Harinath <harinath@gmail.com>
11013 * class.cs: Change 'TypeContainer ds' constructor argument to
11014 'DeclSpace parent'. Some classes were missed below due to
11015 different naming convention.
11017 * class.cs (MemberCore.Parent): Delete. This makes the
11018 ParentContainer changes below enforceable by the compiler.
11020 Treat pointers to enclosing declaration space as 'DeclSpace', not
11022 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11023 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11025 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11027 (Block.AddThisVariable): Likewise.
11028 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11029 (AbstractPropertyEventMethod.Emit): Likewise.
11030 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11031 (GetMethod.Define, SetMethod.Define): Likewise.
11032 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11033 (DelegateMethod.EmitMethod): Likewise.
11035 Fix regression test-partial-13.cs.
11036 Rationalize use of PartialContainer. Ensure that the partial
11037 class semantics can be tied to type-correctness, i.e., any
11038 violation will cause a compile error.
11039 * class.cs, const.cs: Access all fields that belong to class
11040 TypeContainer via ParentContainer. Arguments of EmitContexts and
11041 Resolve()-like functions still use 'Parent'.
11043 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11044 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11045 (PropertyMethod.CheckModifiers): Remove unused argument.
11046 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11049 2006-03-17 Raja R Harinath <harinath@gmail.com>
11051 Make semantics of PartialContainer simpler.
11052 * decl.cs (DeclSpace.IsPartial): Remove.
11053 * class.cs (TypeContainer.IsPartial): Likewise.
11054 (TypeContainer..ctor): Set PartialContainer to point to self.
11055 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11056 (TypeContainer.FindNestedType): Likewise.
11057 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11059 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11061 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11063 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11065 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11068 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11070 * class.cs (Operator.Define): An error for base conversion was not
11071 reported correctly.
11073 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11075 * iterator.cs : yield break is allowed in try statement which has
11076 catch clauses. Fixed bug #77767.
11078 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11080 A fix for #77593, #77574.
11082 * class.cs (MethodCore.CheckBase): Another if for operator.
11084 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11086 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11089 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11090 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11093 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11096 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11097 Updated after another emitcontext usage was clean up. It should help us to
11098 synchronize with gmcs easier.
11100 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11104 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11105 (Event.Define): ditto
11106 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11108 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11109 Removed redundant code and set NewSlot for Invoke method too.
11111 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11112 (Parameters.MergeGenerated): New method. Use this method when you merge
11113 compiler generated argument with user arguments.
11115 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11117 * attribute.cs (ResolveAsTypeTerminal): Removed.
11119 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11120 specialization for predefined types; 30% speed up.
11121 Finally placed obsolete check to right place.
11122 (Expression.ResolveType): Removed.
11124 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11125 Updated after ResolveType was removed.
11127 * expression.cs (Cast.ctor): Check void cast.
11128 (Binary.ResolveAsTypeTerminal): Is never type.
11129 (Conditional.ResolveAsTypeTerminal): Is never type.
11131 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11133 2006-03-01 Raja R Harinath <rharinath@novell.com>
11136 * expression.cs (ParameterReference.DoResolveBase): Change return
11138 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11142 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11145 * typemanager.cs (GetFullNameSignature): Don't nullref on
11146 protected accessors.
11148 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11150 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11151 these two separated members to simplify the code.
11152 (Attribute.Resolve): Refactored to use new fields and methods.
11153 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11154 implemented obsolete attribute checking.
11155 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11156 implemented obsolete checking again. It look line never ending quest ;-)
11157 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11159 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11161 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11163 *class.cs (Property.Define): Add RegisterProperty call.
11165 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11166 argument groups (only 2).
11168 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11169 encoding expression to arguments.
11170 (Expression.ExprClassToResolveFlags): Just turned to property.
11172 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11173 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11174 optimized as well as implemented support for zero-length attributes.
11176 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11177 Add caching of PropertyInfo's.
11179 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11181 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11182 error multiple times.
11184 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11186 New partial class implementation.
11187 A fix for #77027, #77029, #77403
11189 * attribute.cs (Attributable): Made attributes protected.
11191 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11192 the replacements of ClassPart and PartialContainer.
11193 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11194 (TypeContainer.AddInterface): Ditto.
11195 (TypeContainer.AddPartial): The main method for partial classes. It checks
11196 for errors and merges ModFlags and attributes. At the end class is added to
11197 partial_parts list.
11198 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11200 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11201 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11202 from the rest of partial classes.
11203 (TypeContainer.GetClassBases): Simplified.
11204 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11206 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11207 (TypeContainer.HasExplicitLayout): Uses Flags now.
11208 (PartialContainer): Removed.
11209 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11210 (StaticClass): Was merged with Class.
11211 (Class.GetClassBases): class and static class bases are verified here.
11212 (Class.TypeAttr): Added static attributes when class is static.
11213 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11214 (MemberBase): In some cases we need to call parent container for partial
11215 class. It should be eliminated but it's not easy now.
11217 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11219 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11220 partial classed to accumulate class comments.
11221 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11223 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11225 * driver.cs (MainDriver): Tree.GetDecl was removed.
11227 * modifiers.cs (Modifiers): Add partial modifier.
11229 * tree.cs (Tree.decl): Removed.
11230 (RootTypes): Started to use this class more often for root types
11233 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11237 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11238 external interface does not have an attribute.
11240 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11242 Another prerequisites for new partial classs implementation.
11244 * attribute.cs (Attribute.Equal): Implemented.
11245 (Attribute.Emit): Changed as attributes can be applied more than twice.
11246 (Attributes.Emit): Check for duplicate attributes here.
11248 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11249 as a parameter, clean-up.
11251 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11255 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11256 contains obsolete attribute check which can in some cases look for base
11257 type of current class which is not initialized yet.
11258 (TypeContainer.BaseType): Replacement of ptype.
11260 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11262 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11264 First of prerequisites for new partial classs implemention.
11266 * attribute.cs (Attributable): Extended by ResolveContext;
11267 Attributes finally have correct context for resolving in all cases.
11268 (AttachTo): Attribute owner is assigned here.
11270 * codegen.cs (IResolveContext): Introduce new interface to hold
11271 all information needed in resolving phase.
11272 (EmitContext): Implements IResolveContext; more clean-up needed here.
11274 * decl.cs (MemberCore): Implemented IResolveContext.
11276 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11277 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11278 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11279 Refactored to use new IResolveContext instead of EmitContext; cleanup
11281 2006-02-06 Miguel de Icaza <miguel@novell.com>
11283 * codegen.cs (EmitScopeInitFromBlock): check here the
11284 capture_context, there is no need to make two calls to the
11287 * anonymous.cs: Add some debugging messages that might help me
11288 track other instances of this problem in the future (the
11289 regression of test 467).
11291 * cs-parser.jay: track the variable block, as we need to initalize
11292 any captured variables declared in this block for the "catch"
11293 portion of the "Try" statement.
11295 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11296 scope initialization for captured variables.
11298 Also, move the emit for the variables after the block location has
11301 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11303 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11305 2006-02-02 Miguel de Icaza <miguel@novell.com>
11307 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11308 commit yesterday, the initialization for the roots is necessary.
11309 What is not necessary is the scope activation.
11311 2006-02-02 Raja R Harinath <rharinath@novell.com>
11313 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11314 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11316 (Argument.Resolve): Remove CS0206 checks.
11318 2006-02-01 Miguel de Icaza <miguel@novell.com>
11320 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11321 scopes for all the roots, the scopes will now be emitted when the
11322 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11324 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11325 code. This reduces a lot of existing cruft.
11327 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11328 that the ScopeInfo is generated as we enter the scope, not at the
11329 time of use, which is what we used to do before.
11331 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11332 every time a Block is about to be emitted if we have a
11335 2006-02-01 Raja R Harinath <rharinath@novell.com>
11337 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11339 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11341 * typemanager.cs (cons_param_array_attribute): Make private.
11342 (Reset): Set it to null.
11343 (InitCoreHelpers): Don't initialize it.
11344 (ConsParamArrayAttribute): New. Initialize it as needed.
11345 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11347 2006-01-31 Miguel de Icaza <miguel@novell.com>
11349 * expression.cs: There might be errors reported during the
11350 selection of applicable methods. If there are errors, do not
11351 continue execution as it will lead the compiler to crash.
11353 2006-01-30 Miguel de Icaza <miguel@novell.com>
11355 * expression.cs: Member access is not allowed on anonymous
11356 methods. Fixes #77402.
11358 2006-01-30 Raja R Harinath <rharinath@novell.com>
11361 * cs-parser.jay (VariableDeclaration): Don't set
11362 current_array_type to null.
11363 (field_declaration, event_declaration, declaration_statement):
11364 Set it to null here.
11366 2006-01-28 Raja R Harinath <harinath@gmail.com>
11368 * typemanager.cs (GenericParameterPosition): New.
11371 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11373 * doc.cs : To process "include" elements, first we should create
11374 another list than XmlNodeList, because it could result in node
11375 removal, which could result in that the XmlNodeList gives up
11376 yielding next node.
11378 (Also made code identical to gmcs again.)
11380 2006-01-25 Miguel de Icaza <miguel@novell.com>
11382 * ecore.cs: Introduce an error report that we were not catching
11383 before, if not silent, we must report the error. Gonzalo ran into
11386 2006-01-23 Miguel de Icaza <miguel@novell.com>
11388 A fix for bug: #76957
11390 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11391 ComputeMethodHost before creating the method, this is a new
11394 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11395 that this method references (RegisterScope). The actual scope
11396 where the method is hosted is computed with the ComputeMethodHost
11397 before we create the method.
11399 Moved the Deepest routine here.
11401 (AnonymousContainer.ComputeMethodHost): New routine used to
11402 compute the proper ScopeInfo that will host the anonymous method.
11404 (ScopeInfo): Deal with multiple roots. The problem was that we
11405 did not have a unique root where all ScopeInfos could be hanged
11406 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11409 Remove AdjustMethodScope which is now computed at the end. Remove
11410 LinkScope which did a partial link, instead link all ScopeInfos
11411 before code generation from the new "LinkScopes" routine.
11413 Simplify all the Add* routines as they no longer need to maintain
11414 the tree, they just need to record that they are using variables
11417 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11418 routines to produce the forest of ScopeInfo trees.
11420 * class.cs (TypeContainer.AppendMethod): This is just like
11421 AddMethod, but ensures that an interface implementation method
11422 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11423 methods, but at the end.
11425 We use this functionality to ensure that the generated MoveNext
11426 method in the iterator class is resolved/emitted before the
11427 enumerator methods created.
11429 This is required because the MoveNext method computes the right
11430 ScopeInfo for the method. And the other methods will eventually
11431 need to resolve and fetch information computed from the anonymous
11434 2006-01-21 Raja R Harinath <harinath@gmail.com>
11435 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11437 Fix rest of #76995.
11438 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11439 the 'aliases' hash.
11440 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11441 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11443 2006-01-18 Raja R Harinath <rharinath@novell.com>
11445 Fix #76656, cs0231-2.cs.
11446 * cs-parser.jay (formal_parameter_list): Make error case catch
11448 (parenthesized_expression_0): Add CS1026 check.
11449 (invocation_expression): Remove unused { $$ = lexer.Location }.
11451 2006-01-17 Raja R Harinath <rharinath@novell.com>
11454 * cs-parser.jay (statement_expression): Don't list out the
11455 individual statement-expressions. Convert syntax error into
11458 2006-01-16 Raja R Harinath <rharinath@novell.com>
11461 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11462 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11463 CheckIntermediateModification.
11464 (FieldExpr.DoResolve): Add new two-argument version that
11465 allows us to resolve the InstanceExpression as an lvalue.
11466 The one-argument variant is now just a wrapper.
11467 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11468 Resolve the lhs as an lvalue if the it has a value type.
11469 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11470 from Assign.DoResolve.
11471 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11472 resolved as an lvalue.
11473 (PropertyExpr.DoResolve): Update.
11474 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11475 has a value type. Move CS1612 check here from
11476 CheckIntermediateModification.
11477 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11478 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11479 'right_side' of a ResolveLValue on an 'out' argument.
11480 (EmptyExpression.LValueMemberAccess): New. Used as the
11481 'right_side' of a propagated ResolveLValue on a value type.
11482 (LocalVariableReference.DoResolveBase): Recognize
11483 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11485 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11486 EmptyExpression.Null.
11488 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11490 * typemanager.cs : added IsGenericParameter(). In mcs it always
11492 * doc.cs : for generic parameters, use GenericParameterPosition,
11495 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11497 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11499 2006-01-12 Miguel de Icaza <miguel@novell.com>
11501 This fixes the problem where we used ldfld instead of ldflda to
11502 load the "THIS" pointer on captured parameters, when THIS is a
11503 value type. See bug #77205.
11505 * iterators.cs (CapturedThisReference.Emit): Pass false to
11506 EmitThis (we do not need the address).
11508 * codegen.cs (EmitThis): it needs to know whether we need the
11509 address of `this' or not. This is used by value types.
11511 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11512 every other call passes false.
11514 2006-01-12 Raja R Harinath <rharinath@novell.com>
11517 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11519 * expression.cs (Invocation.OverloadResolve): Update.
11520 (Invocation.DoResolve): Avoid double resolution of invocation.
11522 2006-01-11 Raja R Harinath <rharinath@novell.com>
11525 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11526 unary negation of floating point types as 0-expr; negation cannot
11527 overflow in floating point types.
11530 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11531 on operands of 'void' type.
11534 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11535 and ExclusiveOr for boolean constants too.
11537 2006-01-09 Raja R Harinath <rharinath@novell.com>
11540 * expression.cs (Invocation.OverloadResolve): Replace reflected
11541 override methods with their base virtual methods, rather than
11542 skipping over them.
11543 * typemanager.cs (TypeManager.GetOverride): New.
11545 2006-01-05 Jb Evain <jbevain@gmail.com>
11547 * class.cs (Property.Define, Indexer.Define): do not tag the
11548 properties as SpecialName | RTSpecialName.
11550 2006-01-04 Miguel de Icaza <miguel@novell.com>
11552 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11553 doing a low-level comparission of parameter types. It was lacking
11554 a check for __argslist.
11556 2005-12-30 Miguel de Icaza <miguel@novell.com>
11558 * expression.cs (ParameterReference.DoResolveBase): Allow
11559 reference parameters if they are local to this block.
11561 This allows the ref and out parameters of a delegate to be used in
11562 an anonymous method, for example:
11564 delegate void set (out int x);
11566 set s = delegate (out int x){
11570 This is used by functionality introduced late in the C# language.
11572 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11573 method that take ref and out parameters.
11575 Fixes #77119 which was a late change in the spec.
11577 2005-12-23 Miguel de Icaza <miguel@novell.com>
11579 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11580 parent if its the same scope. Fixes #77060.
11582 2005-12-21 Miguel de Icaza <miguel@novell.com>
11584 * driver.cs: Report the case of no source files and no -out:
11587 2005-12-20 Raja R Harinath <rharinath@novell.com>
11590 * expression.cs (ComposedCast.GetSignatureForError): Define.
11592 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11596 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11597 ListDictionary, to contain the ExternAliasEntry entries (in
11598 addition to the NamespaceEntry.aliases hashtable). This field is
11599 shared between the original entry and its doppelganger (bodyless
11601 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11602 extern_aliases field.
11603 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11604 lookup in extern_aliases.
11606 2005-12-16 Raja R Harinath <rharinath@novell.com>
11609 * class.cs (TypeContainer.Mark_HasEquals): New.
11610 (TypeContainer.Mark_HasGetHashCode): New.
11611 (ClassPart): Override them.
11612 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11615 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11616 'parent' argument to the base constructor.
11618 Remove all mention of TypeContainer from decl.cs.
11619 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11620 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11621 (DeclSpace.DeclSpace): Likewise.
11622 (DeclSpace.DefineMembers): Remove unused argument.
11623 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11624 debugging check -- we don't care if the debug code throws an
11625 InvalidCastException instead of an InternalErrorException.
11626 * class.cs (TypeContainer.DefineMembers): Update to changes.
11627 (TypeContainer.DoDefineMembers): Likewise.
11628 (TypeContainer.GetMethods): Likewise.
11629 (PropertyMember.Define): Likewise.
11630 (MemberBase.Parent): New property that forwards to
11631 MemberCore.Parent, but ensures that we get a TypeContainer.
11632 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11633 (RootContext.PopulateTypes): Likewise. Remove special case code
11634 for !RootContext.StdLib: DefineMembers is idempotent.
11636 2005-12-14 Miguel de Icaza <miguel@novell.com>
11638 * convert.cs (ExplicitConversionCore): Check the return value from
11639 ExplicitConversionCore which can return null on failure. Fixes #76914
11641 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11643 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11645 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11647 * doc.cs : The search for referenced namespace was insufficient to
11648 get global one as it used to do. Fixed bug #76965.
11650 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11652 * doc.cs : check name in cref in the last phase that whether it is
11655 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11657 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11660 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11662 * doc.cs : so it turned out that we cannot skip override check for
11663 interface members. Fixed bug #76954.
11665 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11667 * cs-tokenizer.cs : fixed bug #75984:
11668 - #warning and #error should not be handled when the source line
11670 - #line is not checked strictly when the source line is disabled.
11671 - #define and #undef is on the other hand checked strictly at any
11674 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11676 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11679 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11681 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11683 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11684 event initializers.
11685 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11686 (FieldBase.Initializer): Initializer is now optional.
11687 (EventField.Define): Only event field can have initializer.
11689 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11691 * const.cs (Const): Reuse initializer.
11693 * cs-parser.jay: Updated after FieldBase changes.
11694 Added current_array_type to simplify array initializers.
11696 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11698 * expression.cs, iterators.cs: Updated.
11700 * namespace.cs (NamespaceEntry): Made UsingFound private.
11702 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11704 * parameterCollection.cs: Obsolete, removed.
11705 * parser.cs: Obsolete, removed.
11707 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11710 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11712 * enum.cs (Enum.Define): Set obsolete context here.
11714 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11717 - FindDocumentedMember() now expects 1) paramList as null
11718 when "we don't have to check the number of parameters" and
11719 2) Type.EmptyTypes when "there is no arguments".
11720 - Introduced FoundMember struct to hold the exact type which was
11721 used to find the documented member (the above change broke
11722 test-xml-044; it might be better just to use DeclaringType than
11723 what MS does, like this change does, but it depends on usage.)
11725 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11727 * doc.cs : documented member might be from DeclaringType for nested
11728 types. Fixed bug #76782.
11730 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11732 * anonymous.cs: Have the param code handle leaving copies on the
11733 stack etc. Allows anonymous params to take part in the assignment
11734 code (++, +=, etc). Fixes bug #76550
11736 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11737 it down to the anon code.
11739 * iterators.cs: Use dummy var here
11741 * codegen.cs: Handle new vars
11743 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11746 * class.cs (MethodData.Define): Set proper Obsolete context.
11748 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11750 (FieldExpr.DoResolve): Ditto.
11752 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11755 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11756 parent is not obsolete.
11758 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11760 * doc.cs : (FindDocumentedMember) find parameterless members first
11761 and get CS0419 in the early stage. Fixed first case of bug #76727.
11763 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11766 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11767 no error was reported.
11769 *expression.cs (Binary.DoResolve): left can be null.
11771 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11774 * class.cs (MethodData.Emit): Parameters should be labeled first.
11776 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11779 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11781 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11783 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11785 * class.cs (MethodCore): Parameter clean up.
11786 (IMethodData): Added ParameterInfo.
11787 (MethodData): Parameter clean up.
11788 (Indexer.Define): Parameter clean up.
11800 * typemanager.cs: Parameter clean up.
11802 * delegate.cs (Define): Get rid of duplicated code.
11804 * expression.cs (ParameterReference): Removed useless parameters
11806 (Invocation): Ditto.
11808 * parameter.cs (ParamsParameter): New class, params specialization.
11809 (ArglistParameter): Attemp to separate arglist.
11810 (Parameter): Refactored to be reusable and faster.
11811 (Parameter.Modifier): Made understandable.
11812 (Parameters): Changed to be used as a class for `this' assembly
11813 parameters. Refactored to use new specialized classes.
11815 * support.cs (ParameterData): Added Types property.
11816 (InternalParameters): Deleted.
11818 2005-08-20 Martin Baulig <martin@ximian.com>
11820 Merging this patch from GMCS to fix #75867.
11822 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11823 scope if we don't already have it.
11825 2005-11-17 Martin Baulig <martin@ximian.com>
11828 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11829 inherit the scope from our parent. Fixes #76653.
11831 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11833 * doc.cs : the previous patch does not actually fix the bug.
11834 PropertyInfo override check is now implemented and really fixed it.
11835 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11837 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11839 * doc.cs : apply "override filter" also to properties.
11842 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11844 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11845 no need to check overrides. For classes, omit those results from
11846 interfaces since they must exist in the class. Fixed bug #76726.
11848 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11850 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11851 with different parameters. Fixed the second problem in #76685.
11853 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11855 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11856 get expected 'protected' access in CheckValidFamilyAccess()).
11859 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11861 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11862 Fixed bug #76705. CS1569 was incorrectly commented out.
11864 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11866 * doc.cs : use Invocation.IsOverride() to do real override check.
11867 * expression.cs : made Invocation.IsOverride() internal.
11869 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11871 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11872 TypeBuilder.FindMembers() and filter overriden base members out.
11875 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11877 * doc.cs : ref/out parameters are represented as '@' (instead of
11878 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11880 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11882 * doc.cs : when there was no '.' in cref to methods in doc comment,
11883 then parameters were missing in the output. Fixed bug #76691.
11885 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11887 * driver.cs : don't output docs when there is an error.
11890 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11893 Now it should detect indexers. Fixed primary concern in bug #76685.
11894 Fixed CS0419 message to not show the identical member signature in
11897 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11899 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11900 instead of Type.FindMembers() since it does not handle events.
11903 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11905 * codegen.cs: Fixed typo (speficied -> specified).
11907 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11910 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11912 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11914 * attribute.cs: Changed error message.
11916 * cs-tokenizer.cs: One more check.
11918 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11920 * statement.cs (Block.Resolve): Ignore empty statement.
11922 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11924 * report.cs: Made error/warning methods more strict to avoid
11927 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11928 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11929 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11930 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11932 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11934 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11935 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11937 * class.cs (TypeContainer.IsComImport): New property.
11938 (Constructor.Define): Create proper ctor for ComImport types.
11940 * expression.cs (New.CheckComImport): Fixed.
11942 2005-11-07 Miguel de Icaza <miguel@novell.com>
11944 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11945 that a parameter has been captured does not mean that we do not
11946 have to do the rest of the processing. This fixes the second part
11947 of #76592. If there was another anonymous method capturing
11948 values in the past, the Scope would never be set for the second
11949 method that captured the same parameter.
11951 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11952 properly manipulate the stack. Second part of fix for #76592.
11954 * expression.cs (New): Add support for invoking "new" on
11955 interfaces that have been flagged with the ComImport attribute and
11956 the CoClass. Fixes #76637
11958 * statement.cs (Try.DoEmit): When a variable is captured, do not
11959 try to emit the vi.LocalBuilder variable as it has been captured.
11960 Create a temporary variable and store the results on the
11961 FieldBuilder. Fixes #76642
11963 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11965 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11967 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11969 * expression.cs (Binary.DoResolve): Added && optimalization.
11971 * typemanager.cs (AddUserType): Removed useless argument.
11973 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11975 * statement.cs (Block.variables): Uses ListDictionary.
11977 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11980 * class.cs (PartialContainer.EmitType): Customized to emit
11981 security attributes.
11982 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11983 for partial classes.
11985 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11988 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11989 access has to be fixed.
11991 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11993 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11996 * ecore.cs (NullCast.Reduce): Implemented.
11998 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12001 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12003 (Foreach.Resolve): Catch null properly.
12005 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12007 * cs-tokenizer.cs: Warning text fix.
12009 * driver.cs: AllWarningNumbers exposed on public interface.
12011 * report.cs (): Reviewed warning numbers.
12012 (IsValidWarning): Use binary search.
12014 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12016 * driver.cs: Implemeted resource visibility.
12017 (Resources): New class for code sharing between /res: and
12020 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12023 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12026 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12029 * ecore.cs (NullCast): Child is contant only.
12031 * literal.cs (NullLiteral.Reduce): null can be converted to any
12034 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12036 * driver.cs: Use Encoding.Default as default code page instead
12039 2005-10-27 Raja R Harinath <rharinath@novell.com>
12042 * expression.cs (Invocation.Error_InvalidArguments): Handle
12043 __arglist parameters.
12044 (Invocation.VerifyArgumentsCompat): Likewise.
12045 * support.cs (ReflectionParameters.GetSignatureForError): Print
12046 __arglist parameters.
12047 (InternalParamters.GetSignatureForError): Likewise.
12048 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12050 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12052 * attribute.cs (GetPropertyValue): Made public.
12054 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12056 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12058 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12061 * driver.cs: Reflect method name change.
12063 * statement.cs (Try.Resolve): Warn when try has both general
12064 exception handlers.
12066 * typemanager.cs: runtime_compatibility_attr_type new predefined
12069 2005-10-26 Raja R Harinath <harinath@gmail.com>
12072 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12073 treat it as an empty parameter list.
12075 2005-10-26 Raja R Harinath <rharinath@novell.com>
12078 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12079 ResolveAsTypeStep silent.
12080 * statement.cs (Block.AddConstant): Mark block as used.
12081 (Block.ResolveMeta): Avoid piling on error messages
12082 if a constant initializer resolution fails.
12084 2005-10-25 Raja R Harinath <rharinath@novell.com>
12086 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12088 (NamespaceEntry.VerifyAllUsing): New.
12089 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12090 behaviour. Delegates actual resolution of alias to ...
12091 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12092 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12094 * driver.cs (Driver.MainDriver): Update.
12096 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12097 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12099 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12101 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12102 RootNamespace.DefineNamespacesForAll.
12104 2005-10-24 Raja R Harinath <harinath@gmail.com>
12106 * typemanager.cs (assemblies, external_aliases, modules)
12107 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12108 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12109 overhead. Move resposibility ...
12110 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12111 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12113 2005-10-23 Raja R Harinath <harinath@gmail.com>
12115 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12116 cached_namespaces. Improve usage.
12117 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12118 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12119 Move from GlobalRootNamespace and simplify.
12120 (RootNamespace.Global): Make instance variable.
12121 (RootNamespace.RootNamespace): Add "alias name" parameter.
12122 (GlobalRootNamespace): Simplify drastically.
12123 (Namespace.Lookup): Don't use GetNamespace.
12124 * typemanager.cs (GetRootNamespace): Rename from
12125 ComputeNamespaceForAlias.
12126 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12128 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12130 * anonymous.cs (AnonymousContainer): Don't crash when container
12133 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12135 * expression.cs (Binary.DoResolve): Warn when comparing same
12138 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12141 * expression.cs (Binary.DoResolve): It looks like there are no
12142 convetsion rules in enum context.
12144 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12146 Add support for extern alias qualifiers.
12147 * typemanager.cs: Move some LookupTypeReflection code
12148 to namespace.cs, to have cleaner code. Added some methods
12149 to help us keep track of the extern aliased references.
12150 * driver.cs: Add suport for extern alias assemblies on command
12151 line and check for their warnings/errors. Also keep track of the
12152 extern aliased assemblies.
12153 * namespace.cs: Move the global functionality of Namespace
12154 to GlobalRootNamespace/RootNamespace. Now the global namespace
12155 is GlobalRootNamespace.Globa. Also the code moved from
12156 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12157 Finally added LocalAliasEntry (AliasEntry before) and
12158 ExternAliasEntry, to handle alias statements.
12159 * cs-parser.jay: Add support in the grammar for extern alias
12161 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12162 Update callings to Namespace (now in GlobalRootNamespace).
12164 2005-10-18 Raja R Harinath <rharinath@novell.com>
12167 * class.cs (TypeContainer.DefineType): Move updating of
12168 topological sort earlier in the code.
12169 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12171 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12174 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12176 * constant.cs (Constant.TryReduce): Moved from Cast class.
12177 (Reduce): Made little bit more OO and fixed missing conversions.
12179 * ecore.cs (Reduce): Implemented.
12180 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12182 * literal.cs (Reduce): Implemented.
12184 * class.cs: Reverted Miguel's wrong commit.
12186 2005-10-14 Miguel de Icaza <miguel@novell.com>
12188 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12190 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12192 * cs-parser.jay, expression.cs : CS0214 was missing error location
12193 for constants. Fixed bug #76404.
12195 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12198 * convert.cs (ExplicitConversionCore): Fixed object->enum
12201 2005-10-10 Raja R Harinath <rharinath@novell.com>
12203 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12204 InstanceExpression.
12205 (PropertyExpr.EmitCall): Likewise.
12206 * expression.cs (Invocation.EmitArguments): Handle case where
12208 (Invocation.EmitCall): Avoid allocating temporary variable if
12209 there are no arguments.
12211 2005-10-07 Raja R Harinath <rharinath@novell.com>
12214 * convert.cs (ImplicitConversionStandard): Move conversion of
12215 void* to arbitrary pointer types ...
12216 (ExplicitConversionStandard): .. here.
12217 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12218 error to always print typenames.
12220 2005-10-07 Raja R Harinath <rharinath@novell.com>
12222 * convert.cs (GetConversionOperator): Rename from
12223 GetConversionOperators. Move operator selection code from ...
12224 (UserDefinedConversion): ... here.
12226 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12228 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12231 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12233 * assign.cs (Assign.DoResolve): Error method changed.
12235 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12237 * const.cs (ResolveValue): Reset in_transit immediately.
12239 * constant.cs: Error method changed.
12241 * convert.cs: Removed useless location parameter.
12242 (ExplicitNumericConversion): Don't do double enum check.
12243 (ExplicitConversionCore): Renamed from ExplicitConversion.
12244 (ExplicitUnsafe): Extracted from ExplicitConversion.
12245 (ExplicitConversion): Uses for error reporting.
12247 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12249 (ResolveBoolean): Uses common error method.
12250 (CastToDecimal): Get rid of ec.
12251 (CastFromDecimal): Optimized.
12252 (ConvCast): Get rid of ec.
12254 * enum.cs (ResolveValue): Reset in_transit immediately.
12255 (Emit): Return after first error.
12257 * expression.cs: Convert changes.
12259 * literal.cs: Error method changed.
12261 * statement.cs: Error method changed.
12263 2005-10-03 Raja R Harinath <rharinath@novell.com>
12265 * support.cs (SeekableStreamReader.Position): Don't error out when
12266 the requested position is just beyond the end of the current
12269 2005-09-28 Raja R Harinath <rharinath@novell.com>
12271 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12272 try to keep in sync with the byte count of the underlying Stream.
12273 However, this limits us to a window size of 2048 characters: i.e.,
12274 the maximum lookahead of our lexer/parser can be 2048 characters.
12276 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12279 * driver.cs: Fix compilation files with full root path.
12281 2005-09-25 Miguel de Icaza <miguel@novell.com>
12283 * report.cs (SymbolRelatedToPreviousError): Format the output so
12284 it does not use an open parenthesis that is never closed.
12286 * driver.cs: Follow coding guidelines
12288 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12291 * const.cs (Const.ResolveValue): Check for assigning non-null
12292 value to reference type.
12294 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12296 * anonymous.cs: Implemented ExprClassName.
12298 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12301 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12304 * class.cs (StaticClass.DefineContainerMembers): Report protected
12307 * codegen.cs: if(ed) PRODUCTION.
12309 * convert.cs (Error_CannotImplicitConversion): Better error
12312 * cs-parser.jay: More error checks.
12314 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12316 * driver.cs (CSCParseOption): Enabled wrong option check.
12318 * ecore.cs (Expression.ExprClassName): Turned to property.
12319 (MemberExpr.CheckIntermediateModification): For checking boxed
12320 value types modification.
12322 * statement.cs (Fixed.Resolve): Expression type must be
12323 convertible to fixed type.
12324 (CollectionForeach.GetEnumeratorFilter,TryType):
12325 Small refactoring for easier error checking.
12327 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12329 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12332 * class.cs (GeneratedBaseInitializer): New class for customization
12333 compiler generated initializers.
12334 (MemberBase.DoDefine): Check Obsolete attribute here.
12335 (FieldMember.DoDefine): Ditto.
12337 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12340 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12341 (MemberCore.GetObsoleteAttribute): Removed argument.
12342 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12343 (MemberCore.CheckObsoleteType): New helper.
12347 * statement.cs: Updates after MemberCore changes.
12349 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12350 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12352 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12353 obsolete attribute for compiler construct.
12354 (As.DoResolve): Cache result.
12356 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12358 2005-09-26 Raja R Harinath <rharinath@novell.com>
12361 * expression.cs (This.VerifyFixed): In a value type T, the type of
12362 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12363 value type R, 'this' is treated as a value parameter.
12365 2005-09-22 Miguel de Icaza <miguel@novell.com>
12367 * statement.cs (Lock): Use the TemporaryVariable class instead of
12368 manually using local variables as those do not work when variables
12371 * ecore.cs: Moved the TemporaryVariable class from being a nested
12372 class inside Foreach to be a public class that can be employed in
12375 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12377 * cs-parser.jay: interface_accessors replaced by
12378 accessor_declarations.
12380 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12383 * statement.cs (GotoCase.Resolve): Convert null constant to
12385 (SwitchLabel.ResolveAndReduce): Ditto.
12386 (SwitchLabel.NullStringCase): Custom null stamp.
12387 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12389 typemanager.cs (CSharpSignature): Don't skip first argument
12392 2005-09-18 Miguel de Icaza <miguel@novell.com>
12394 * driver.cs: Set InEmacs based on the environment variable EMACS.
12396 * location.cs (InEmacs): in this mode, do not report column
12397 location as it confuses Emacs.
12399 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12401 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12402 expression.cs, iterators.cs, literal.cs: Store constants and
12405 * class.cs (MemberBase.ShortName): Pass location.
12407 * cs-parser.jay: Some location fixes.
12409 * ecore.cs (Expression.Location): Made virtual.
12411 2005-09-05 Miguel de Icaza <miguel@novell.com>
12413 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12414 if the underlying types are the same, otherwise we need to produce
12415 code that will do the proper cast.
12417 This was exposed by Marek's constant rewrite which produced
12418 invalid code for the call site:
12420 enum X : long { a }
12421 void Method (X v) {}
12425 This fixes test-49.cs
12427 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12429 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12430 Type/Object should be allowed as well. Fixed bug #75968.
12432 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12434 * expression.cs : (Binary.DoResolve): when one is enum constant and
12435 another is constant 0, then return enum one *as enum type*.
12438 2005-09-02 Raja R Harinath <rharinath@novell.com>
12440 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12444 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12445 flow-branching for LocalVariableReferences in case we were invoked
12446 from a MemberAccess.
12447 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12449 (LocalVariableReference.DoResolveBase): ... this.
12450 (MemberAccess.Resolve): Do the check that was disabled during
12453 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12456 (PartialContainer.Create): check abstract/sealed/static strictly
12457 but abstract/sealed can exist only at one side. Fixed bug #75883.
12459 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12462 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12463 specified, don't default to UnmanagedType.I4.
12465 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12467 * expression.cs : conditional operator should check possibly
12468 incorrect assign expression. Fixed bug #75946.
12470 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12472 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12473 Reverting the change. gmcs is much complex than mcs on this matter.
12475 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12477 * cs-tokenizer.cs : To read another token ahead of the actual
12478 consumption, use new SavedToken and cache token instead of moving
12479 back the stream with SeekableStreamReader (it seemed problematic).
12481 driver.cs : Thus use StreamReader directly.
12482 * support.cs : Thus removed SeekableStreamReader.
12484 2005-08-30 Raja R Harinath <rharinath@novell.com>
12487 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12488 (ScopeInfo.EmitScopeType): Use it to construct field names from
12489 names of captured locals.
12492 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12493 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12494 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12495 (ExplicitConversion): Remove enum cases already handled by
12496 implicit conversion. Move implicit conversion check to the beginning.
12497 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12498 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12499 Don't treat System.Enum as a struct.
12501 2005-08-30 Jb Evain <jbevain@gmail.com>
12503 * attribute.cs: handles as expression in parameters.
12505 2005-08-30 Raja R Harinath <rharinath@novell.com>
12508 * class.cs (TypeContainer.VerifyClsName): Don't use a
12509 PartialContainer when verifying CLS compliance.
12510 (AbstractPropertyEventMethod): Set Parent here, ...
12511 (PropertyMethod): ... not here.
12513 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12515 * attribute.cs : escaped attribute name should not be allowed to be
12516 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12518 2005-08-29 Raja R Harinath <rharinath@novell.com>
12521 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12522 when converting a long constant to unsigned long.
12523 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12524 detect where IsApplicable and VerifyArgumentsCompat disagree.
12526 2005-08-29 Raja R Harinath <rharinath@novell.com>
12527 and Carlos Alberto Cortez <carlos@unixmexico.org>
12530 * class.cs (TypeContainer.CanElideInitializer): New helper.
12531 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12532 can safely emitting the initializer of a field.
12534 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12536 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12537 allowed inside a switch (without loop). Fixed bug #75433.
12539 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12541 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12542 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12544 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12546 * driver.cs : kinda reverting the default encoding changes (not exact
12547 revert since I noticed that "codepage:reset" might not work fine).
12549 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12551 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12552 Location. Now getter and setter store location correctly.
12553 (errors/cs0111-12.cs now reports the expected location.)
12555 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12557 * driver.cs : Use default encoding on the environment.
12558 Removed (now that) extra parameter for SeekableStreamReader.
12559 * support.cs : (SeekableStreamReader) third .ctor() argument for
12560 StreamReader is not required (always true). preamble size could
12561 be acquired in simpler and safe way.
12563 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12565 * cs-parser.jay: report CS0642 at warning level 3
12566 and report CS0642 for an if else statement also
12567 fixes bug #74745. Patch by John Luke (and a bit
12569 Removed extra CS0642 warning check for "while",
12571 * statement.cs: In Block.Resolve(), CS0642 check
12572 is reimplemented to check a sequence of an empty
12573 statement and a block.
12575 Both fix bug #66777.
12577 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12579 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12580 detection until I fix it.
12582 * cs-tokenizer.cs: Changed error message.
12584 * cs-parser.jay: Fixed 2 error locations.
12586 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12587 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12590 * enum.cs (GetSignatureForError): Fixed.
12592 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12596 * typemanager.cs (RegisterProperty): Removed.
12598 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12600 2005-08-24 Raja R Harinath <rharinath@novell.com>
12603 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12604 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12606 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12608 * expression.cs : tiny fix is required for not warning positive ulong.
12611 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12613 * expression.cs : add CS0652 check for constant and integral
12614 expression. Fixed bug #53974.
12616 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12618 * expression.cs : in DoNumericPromotions(), check if there is implicit
12619 conversion overload for string (to check CS0034). Fixed bug #52492.
12621 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12623 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12625 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12627 * ecore.cs : report location when it is *not* Null.
12629 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12635 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12636 correctly. Fixed bug #75721.
12638 2005-08-23 Raja R Harinath <rharinath@novell.com>
12640 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12641 loop that performs 'min (pos, char_count)'.
12644 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12645 converted value in Operator.OnesComplement.
12647 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12649 * anonymous.cs: If the anon method is pulled into a helper class,
12650 it needs to be `internal' not `private'. Fixes runtime behavior on
12653 2005-08-20 Martin Baulig <martin@ximian.com>
12655 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12656 scope if we don't already have it.
12658 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12659 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12662 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12665 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12666 is a partial class.
12668 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12670 The big constants rewrite
12671 Fix #75746, #75685 and more
12672 As a side effect saved 1MB for MWF ;-)
12674 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12675 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12676 enum based for corlib compilation.
12678 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12681 * class.cs (FixedField.Define): Use ResolveAsConstant.
12683 * const.cs (IConstant): Interface constants and enums.
12684 (Const.ResolveValue): New method for constant resolvning.
12685 (ExternalConstant): Constants from imported assemblies.
12687 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12688 conversion; like enums.
12689 (Constant.ToType): Converts this constant to different type.
12690 (Constant.Increment): Adds 1.
12692 * convert.cs (ImplicitConversionRequired): Simplified.
12694 * cs-parser.jay: Create EnumMember directly.
12696 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12698 * doc.cs (GenerateEnumDocComment): Removed.
12700 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12701 (ConvertIntLiteral): Removed.
12702 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12704 * enum.cs (EnumMember): Implement IConstant.
12705 (Enum.IsValidEnumConstant): Removed.
12706 (Enum.GetNextDefaultValue): Removed.
12707 (Enum.FindMembers): Updated.
12708 (Enum.GenerateDocComment): Iterate enum members.
12710 * expression.cs (Cast.TryReduce): Handle enums correctly.
12711 (New.Constantify): Made public.
12712 (MemberAccess.DoResolve): Removed contant specific if(s).
12714 * literal.cs (NullLiteral): Implement new abstract methods.
12716 * statement.cs (GotoCase.Resolve): Use new constant methods.
12717 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12719 * typemanager.cs (LookupEnum): Removed.
12720 (IsEnumType): Fixed to work with corlib.
12721 (RegisterConstant): Removed.
12722 (LookupConstant): Removed.
12723 (GetConstant): Changed to work with IConstant.
12725 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12727 * location.cs : Fixed overflown (>255) column number.
12729 2005-08-03 Raja R Harinath <rharinath@novell.com>
12731 First cut of the qualified-alias-member feature.
12732 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12734 * cs-parser.jay (DOUBLE_COLON): New token.
12735 (namespace_or_type_name): Add rule for recognizing
12736 qualified-alias-members.
12737 (primary_expression): Likewise.
12738 (element_access): Allow QualifiedAliasMember as a possible
12739 type-bearing expression.
12740 (local_variable_type, local_variable_pointer_type): Likewise.
12741 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12742 aliases in the current and enclosing namespace declarations.
12743 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12744 * decl.cs (MemberName.is_double_colon): New.
12745 (MemberName.MemberName): Add new constructor for alias-member.
12746 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12747 * expression.cs (QualifiedAliasMember): New expression type.
12749 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12751 * location.cs : it borked when no argument was specified.
12753 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12755 * location.cs : tiny ToString() format fix.
12757 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12759 * statement.cs : oops, it was missing.
12761 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12763 A set of fixes for precise line/column location.
12766 "token" field now holds a file/line "delta", a line number offset
12767 from the segment, and a column number. See also:
12768 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12769 December/009508.html
12770 Removed static IsNull. Use instance IsNull property instead.
12771 * cs-tokenizer.cs :
12772 For some tokens it stores Location. For Identifier it stores
12773 LocatedToken which is a pair of string name and location.
12774 Column numbers are adjusted only at getChar().
12776 Use Location.ToString() for reporting (it now contains column).
12778 Largely modified to use LocatedToken instead of
12779 string (IDENTIFIER), and to acquire Location from some tokens.
12780 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12781 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12783 Now MemberName holds Location. DeclSpace.ctor() receives Location
12784 as a parameter. Removed extra parameters to all derived classes.
12785 Replaced Location.IsNull() with instance property.
12786 * assign.cs, expression.cs :
12787 Added .ctor() overload that omits Location.
12789 Added "nameEscaped" flag that indicates the identifier was escaped
12790 in the source file. This fixes bug #57047.
12792 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12794 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12795 New method, looking for lo-case imported cls type.
12797 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12800 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12802 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12804 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12805 all_imported_types.
12806 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12808 Optimized to save 3.5 MB for SWF compilation.
12810 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12812 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12813 (PartialContainer.Create): Moved logic AddToContainer.
12814 (PartialContainer.MarkForDuplicationCheck): Shares name.
12816 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12819 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12821 (Namespace.GetSignatureForError): New method.
12823 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12824 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12826 2005-08-01 Raja R Harinath <rharinath@novell.com>
12829 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12830 member lookup rather than qualifier_type, since qualifier_type can
12833 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12835 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12838 2005-07-31 Miguel de Icaza <miguel@novell.com>
12840 * statement.cs: Copy the local exception into the exception
12841 captured local. Fixes 75674
12843 2005-07-31 Raja R Harinath <harinath@gmail.com>
12846 * expression.cs (Invocation.OverloadResolve): Don't report error
12847 CS1501 if error CS1502 has been reported.
12848 (New.DoResolve): Delegate CS1501 reporting to
12849 Invocation.OverloadResolve.
12852 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12853 invariant-meaning-in-block property in an enclosing block if
12856 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12858 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12859 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12860 (Switch.CheckSwitch): Just save 50kb for SWF.
12862 2005-07-27 Martin Baulig <martin@ximian.com>
12864 * anonymous.cs (CaptureContext.AddField): Added
12865 `AnonymousContainer am' argument; compute its toplevel scope if
12866 it's not already computed. Fixes #75649.
12868 2005-07-26 Raja R Harinath <rharinath@novell.com>
12871 * class.cs (Constructor.Emit): Reset block to null if the block
12874 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12876 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12878 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12880 * class.cs (MethodData.Define): Check whether accessor implementing
12881 interface is public.
12883 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12885 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12888 * namespace.cs (LookupType): Moved same type check to...
12890 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12891 with the same name.
12893 2005-07-21 Raja R Harinath <rharinath@novell.com>
12895 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12896 already found a typebuilder.
12897 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12898 MemberNames, not strings.
12900 * const.cs (Error_ExpressionMustBeConst):
12901 Rename from Error_EpressionMustBeConst.
12902 * const.cs, class.cs, statement.cd: Update.
12904 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12908 * const.cs (Const.LookupConstantValue): Report missing contant expression
12910 (Error_EpressionMustBeConstant): Only one error method.
12912 * class.cs, statement.c: Updated.
12914 2005-07-20 Raja R Harinath <rharinath@novell.com>
12916 * statement.cs (Block.Flags): Add back HasVarargs.
12917 (Block.flags): Make protected.
12918 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12920 * typemanager.cs (types, typecontainers, user_types): Remove.
12921 (UserTypes, TypeContainers): Likewise.
12922 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12923 (CleanUp, Reset): Update.
12924 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12925 (GetNestedType): Use Type.GetNestedType.
12926 (CoreLookupType): Take two arguments, the namespace and the
12927 basename of the type. Update to use the Namespace.Lookup
12929 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12930 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12931 string concatenation and substring matches.
12932 * class.cs, enum.cs, delegate.cs: Update to changes.
12934 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12936 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12937 Expression and made virtual.
12939 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12940 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12942 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12944 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12947 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12950 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12953 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12954 AssemblyCultureAttribute is not used on executable.
12957 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12959 2005-07-16 Raja R Harinath <rharinath@novell.com>
12962 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12963 New. Reports CS0252/CS0253.
12964 Mostly taken from preliminary patch by Duncak Mak.
12965 (Binary.DoResolveOperator): Store results of operator lookup.
12966 Use them to detect if we need to warn about unintended reference
12969 2005-07-15 Raja R Harinath <rharinath@novell.com>
12972 * namespace.cs (Namespace.Lookup): Add back location parameter.
12973 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12974 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12976 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12977 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12978 (Namespace.LookupType): ... this.
12979 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12981 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12982 purported to handle pointers.
12983 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12986 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12988 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12991 2005-07-15 Raja R Harinath <rharinath@novell.com>
12993 * namespace.cs (Namespace.Lookup): Drop location parameter.
12994 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12995 (NamespaceEntry.Lookup): ... this.
12996 (NamespaceEntry.Error_AmbiguousTypeReference):
12997 Move here from DeclSpace.
12998 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13000 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13001 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13002 Move to NamespaceEntry.
13003 * delegate.cs, expression.cs: Update to changes.
13005 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13007 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13008 CheckAttributeType and refactored.
13009 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13010 ResolveAsTypeTerminal error handling.
13011 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13013 (GetSignatureForError): Print errors in same way.
13016 * codegen.cs: Reflect attribute GetSignatureForError change.
13019 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13021 * namespace.cs (UsingEntry): Refactored to make fields private.
13024 statement.cs: Error_UnexpectedKind has extra parameter.
13026 2005-07-14 Raja R Harinath <rharinath@novell.com>
13028 * ecore.cs (IAlias): Remove.
13029 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13030 that implement the interface.
13031 * namespace.cs (Namespace): Likewise.
13032 (Namespace.declspaces): Renamed from 'defined_names'.
13033 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13034 DeclSpace instead of an IAlias.
13035 * tree.cs (Tree.AddDecl): Update.
13037 2005-07-12 Raja R Harinath <rharinath@novell.com>
13039 * statement.cs (Block.Flags); Remove HasVarargs.
13040 (Block.HasVarargs): Move to ToplevelBlock.
13041 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13042 (Block.Variables): Make protected. Initialize variable hashtable
13044 (Block.AddVariable): Update.
13045 (Block.Resolve): Update to changes.
13046 (ToplevelBlock.HasVarargs): New boolean.
13047 (ToplevelBlock.ThisVariable): Move here from Block.
13048 (ToplevelBlock.AddThisVariable): Likewise.
13049 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13050 * expression.cs (This.ResolveBase): Update to changes.
13051 (ArglistAccess.DoResolve): Likewise.
13053 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13056 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13058 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13059 not used and not used & assigned.
13060 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13062 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13065 * expression.cs (Is.DoResolve): null is never provided type.
13067 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13070 * cs-parser.jay: Less strict event error rule to catch more errors.
13072 2005-07-08 Martin Baulig <martin@ximian.com>
13074 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13075 gettter (allowed) or setter (not allowed).
13077 * class.cs (Accessor): Implement IIteratorContainer.
13078 (Accessor.Yields): New public field.
13079 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13080 per-accessor basis.
13083 (get_accessor_declaration, set_accessor_declaration): Set the
13084 `yields' flag on the accessor, not the property.
13085 (property_declaration): Do the iterators check on a per-accessor
13086 basis and not for the whole property.
13088 2005-07-08 Martin Baulig <martin@ximian.com>
13090 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13091 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13093 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13096 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13097 (ExtractSecurityPermissionSet): Cope with self referencing security
13098 attributes properly.
13100 * driver.cs (SetOutputFile): Made public property OutputFile.
13102 2005-07-07 Raja R Harinath <rharinath@novell.com>
13105 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13106 has_nonstatic_fields. Make into a FieldBase pointer.
13107 (TypeContainer.AddField): Add CS0282 check.
13108 (TypeContainer.EmitType): Update.
13110 2005-07-06 Miguel de Icaza <miguel@novell.com>
13112 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13113 compare if they start with __.
13115 2005-07-06 Raja R Harinath <rharinath@novell.com>
13117 * statement.cs (Switch.SwitchGoverningType): Only look at
13118 UserCasts that don't need implicit standard conversions to one of
13119 the allowed switch types (Fixes test-322.cs).
13120 (LocalInfo.Resolve): Re-enable sanity-test.
13122 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13124 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13126 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13128 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13130 2005-07-06 Raja R Harinath <rharinath@novell.com>
13133 * ecore.cs (SimpleName.GetSignatureForError): Add.
13134 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13135 (MemberAccess.GetSignatureForError): Add.
13137 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13139 The big error and warning messages review.
13169 * typemanager.cs: Updated.
13171 * class.cs: (MethodCore.SetYields): Moved here to share.
13172 (PropertyMethod.Define): Moved iterator setup here.
13174 * iterators.cs: Add orig_method to have full access to parent
13177 2005-07-05 Raja R Harinath <rharinath@novell.com>
13179 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13180 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13181 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13182 variable of struct type.
13183 * expression.cs (Unary.ResolveOperator): Update to change.
13184 (Indirection.VerifyFixed): Likewise.
13185 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13186 (ParameterReference.VerifyFixed): Value parameters are fixed.
13187 (This.VerifyFixed): Treat 'this' as a value parameter.
13188 * statement.cs (LocalInfo.IsFixed): Remove.
13190 2005-07-01 Martin Baulig <martin@ximian.com>
13192 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13193 `ec.EmitThis ()' to get the correct scope.
13195 2005-07-01 Martin Baulig <martin@ximian.com>
13197 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13198 instance is a ParameterReference; fixes #75299.
13200 2005-07-01 Martin Baulig <martin@ximian.com>
13202 Reverted Marek's latest patch (r46725):
13203 - it contains structural changes which are neither mentioned in
13204 the ChangeLog nor explained anywhere; for example the additional
13205 argument of EmitContext's and Iterator's .ctor's and the
13206 TypeContainer.DefineMembers() change.
13207 - structural changes like this should go in in seperate patches
13208 and not be hidden in a huge patch which just seems to affect
13209 warnings and errors.
13210 a big and hard to understand patch.
13211 - it breaks iterators and causes regressions, for instance in
13214 2005-06-30 Raja R Harinath <rharinath@novell.com>
13217 * expression.cs (Indexers.map): Remove.
13218 (Indexers.Append): Filter out inaccessible setters and getters.
13219 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13222 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13223 Refactored from ...
13224 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13225 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13226 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13227 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13229 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13232 * class.cs (FieldBase.GetInitializerExpression): One more field
13235 2005-06-28 Miguel de Icaza <miguel@novell.com>
13237 * pending.cs: Do not define a proxy if the base method is virtual,
13238 it will be picked up by the runtime (bug 75270).
13240 2005-06-08 Martin Baulig <martin@ximian.com>
13242 The big Iterators rewrite :-)
13244 * iterators.cs: Rewrite this to use the anonymous methods framework.
13246 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13247 before the TypeContainers; see 2test-21.cs.
13250 (TypeContainer.DefineType): Don't create a new EmitContext if we
13251 already have one (this only happens if we're an Iterator).
13252 (TypeContainer.Define): Also call Define() on all our iterators.
13253 (Method.CreateEmitContext): Added support for iterators.
13256 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13257 (AnonymousContainer.CreateMethodHost): Moved here from
13258 AnonymousMethod and made abstract.
13259 (AnonymousContainer.CreateScopeType): New abstract method.
13260 (AnonymousContainer.IsIterator): New public property.
13261 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13262 get the ScopeTypeBuilder rather than manually defining it here.
13263 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13266 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13267 before RootContext.DefineTypes().
13269 * codegen.cs (EmitContext.RemapToProxy): Removed.
13270 (EmitContext.CurrentAnonymousMethod): Changed type from
13271 AnonymousMethod -> AnonymousContainer.
13272 (EmitContext.ResolveTopBlock): Protect from being called twice.
13273 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13274 (EmitContext.EmitThis): Removed the iterators hacks; use the
13275 anonymous methods framework for that.
13278 (ToplevelBlock.Container): Make this a property, not a field.
13279 (ToplevelBlock.ReParent): New public method; move the
13280 ToplevelBlock into a new container.
13281 (Foreach.TemporaryVariable): Simplify.
13283 2005-06-05 Martin Baulig <martin@ximian.com>
13285 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13286 (Block.AddTemporaryVariable): New public method; creates a new
13287 `LocalInfo' for a temporary variable.
13288 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13290 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13291 non-iterator variables.
13293 2005-06-05 Martin Baulig <martin@ximian.com>
13295 * statement.cs (Foreach.TemporaryVariable): Create the
13296 LocalBuilder in the Emit phase and not in Resolve since in some
13297 situations, we don't have an ILGenerator during Resolve; see
13298 2test-19.cs for an example.
13300 2005-06-04 Martin Baulig <martin@ximian.com>
13302 **** Merged r45395 from GCS ****
13304 The big Foreach rewrite - Part II.
13306 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13307 with `PropertyInfo ienumerator_getcurrent'.
13309 * codegen.cs (VariableStorage): Removed.
13312 (Foreach): Derive from Statement, not ExceptionStatement.
13313 (Foreach.CollectionForeach): New nested class. Moved all the code
13314 dealing with collection foreach here.
13315 (Foreach.ForeachHelperMethods): Removed.
13316 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13318 2005-05-23 Martin Baulig <martin@ximian.com>
13320 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13321 don't need to. Fix #75014.
13323 2005-05-20 Martin Baulig <martin@ximian.com>
13325 Merged r44808 from GMCS.
13327 * class.cs (TypeContainer.CircularDepException): Removed.
13328 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13329 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13330 (CS0146) and interface (CS0529) dependencies here.
13332 2005-06-21 Raja R Harinath <rharinath@novell.com>
13334 * expression.cs (Invocation.EmitCall): Fix initialization
13335 'this_call' to reflect current behaviour. Fix indentation.
13337 * convert.cs (FindMostEncompassedType): Add two trivial special
13338 cases (number_of_types == 0 || number_of_types == 1).
13339 (FindMostEncompasingType): Likewise.
13341 2005-06-17 Raja R Harinath <rharinath@novell.com>
13343 Some cleanups preparing for the fix of #75283.
13344 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13346 (EventExpr.InstanceResolve): Likewise.
13347 (EventExpr.DoResolve): Remove redundant checks.
13349 2005-06-10 Duncan Mak <duncan@novell.com>
13351 * cs-tokenizer.cs (process_directives): New flag for controlling
13352 the processing of preprocessor directives.
13353 (x_token): After seeing a '#', return Token.NONE instead of going
13354 to handle_preprocessing_directive() when not processing
13355 directives. This avoids unnecessary processing during the token peek in
13360 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13361 the existing error reporting methods instead of Report.Error.
13363 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13364 after Raja's rewrite.
13366 2005-06-08 Miguel de Icaza <miguel@novell.com>
13368 * class.cs: Small fix.
13370 2005-06-08 Raja R Harinath <rharinath@novell.com>
13373 * class.cs (GetPartialBases): Fix return value check of
13374 part.GetClassBases.
13376 2005-06-07 Raja R Harinath <rharinath@novell.com>
13378 Ensure that partial classes are registered in their enclosing
13379 namespace. Initial part of fix of #75160.
13380 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13381 Register declspace with namespace here, not in
13382 DeclSpace.RecordDecl.
13383 * cs-parser.jay: Pass namespace to RecordDecl.
13384 * class.cs (PartialContainer.Create): Likewise.
13385 (ClassPart.DefineType): New sanity-check. Throws an exception if
13387 * decl.cs (Declspace.RecordDecl): Remove.
13388 * namespace.cs (NamespaceEntry.DefineName): Remove.
13390 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13392 * rootcontext.cs: Reset TargetExt as well.
13394 2005-06-03 Raja R Harinath <rharinath@novell.com>
13396 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13397 -langversion:ISO-1.
13399 2005-06-02 Raja R Harinath <rharinath@novell.com>
13401 Fix #75080, cs0119.cs.
13402 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13404 (Expression.Resolve): ... this. Use it. Remove bogus code
13405 allowing ExprClass.Type and ExprClass.Namespace for
13406 ResolveFlags.VariableOrValue.
13407 (Expression.Resolve) [1-argument variant]: Change default resolve
13408 flags based on language version.
13409 (Expression.Error_UnexpectedKind): Use a simple string array
13410 rather than an ArrayList.
13411 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13412 not ExprClass.Type.
13413 (TypeOfVoid.DoResolve): Likewise.
13414 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13415 flags argument -- it always has the same value.
13417 2005-05-31 Raja R Harinath <rharinath@novell.com>
13420 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13421 Use it in the error message.
13422 * assign.cs, expression.cs, statement.cs: Update.
13424 2005-05-30 Raja R Harinath <rharinath@novell.com>
13427 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13428 the "almostMatchedMember" case too.
13429 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13430 that failed the accessibility checks to 'almost_match'.
13432 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13434 * attribute.cs: Use internal MethodBuilder methods to set
13435 ExactSpelling and SetLastError on PInvoke methods, instead
13436 of passing them via charset. Fixes #75060.
13438 2005-05-27 Raja R Harinath <rharinath@novell.com>
13440 * parameter.cs (Parameter): Remove TODO comment.
13441 (Parameter.DefineParameter): Remove Location parameter.
13442 (Parameters.LabelParameters): Likewise.
13443 * class.cs (Constructor.Emit): Update to change.
13444 (MethodData.Emit): Likewise.
13445 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13446 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13448 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13451 Removed Parameters.Location and added Parameter.Location instead.
13452 Removed Location parameter from Emit() and GetSignature().
13459 Modified all related calls.
13461 2005-05-26 Raja R Harinath <rharinath@novell.com>
13463 Improve user-defined conversion handling.
13464 * convert.cs (GetConversionOperators): Rewrite. Return only the
13465 applicable operators.
13466 (AddConversionOperators): New. Helper for GetConversionOperators.
13467 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13468 there is only one most encompassed/encompassing type.
13469 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13470 "applicable operator" handling.
13471 (UserConversion): Move cache here from GetConversionOperators.
13472 Directly cache the chosen operator, rather than the whole
13474 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13475 case. Allow conversion of decimal to sbyte and byte too.
13476 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13477 New static methods. Used to avoid allocating EmptyExpressions in
13480 2005-05-24 Duncan Mak <duncan@novell.com>
13482 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13483 another class, used in Convert.ExplicitNumericConversion.
13484 (CastToDecimal): New class, similar to above, but casts to
13485 System.Decimal, used in Convert.ImplicitNumericConversion and also
13486 in explicit convesion from double/float to decimal.
13488 * convert.cs (ImplicitNumericConversion): Handle implicit
13489 conversions to System.Decimal.
13490 (ExplicitNumericConversion): handle explicit conversions to
13495 2005-05-20 Miguel de Icaza <miguel@novell.com>
13497 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13498 know the type at this stage, just break through. Fixes #75008
13500 2005-05-19 Martin Baulig <martin@ximian.com>
13503 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13504 to disable error reporting.
13506 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13507 here since we don't want to report an error; see the new test-336.cs.
13509 2005-05-19 Raja R Harinath <rharinath@novell.com>
13511 * statement.cs (ToplevelBlock.GetParameterReference)
13512 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13513 Move here from class Block.
13514 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13515 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13517 2005-05-18 Martin Baulig <martin@ximian.com>
13522 (FlowBranching.Reachability): Add non-static public And() and Or()
13524 (FlowBranchingSwitch): New class; do the `break_origins' thing
13525 like in FlowBranchingLoop.
13526 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13527 reachability, not just locals and parameters.
13528 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13529 switch; MergeBreakOrigins() now takes care of that.
13531 2005-05-18 Martin Baulig <martin@ximian.com>
13533 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13534 a loop and may leave it, reset the barrier; fixes #74974.
13536 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13538 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13541 * cs-parser.jay: Catch more lexical errors.
13543 * report.cs: Add one more Error method.
13546 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13548 2005-05-17 Martin Baulig <martin@ximian.com>
13550 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13553 2005-05-16 Raja R Harinath <rharinath@novell.com>
13555 Fix test-382.cs. Emit values of decimal constants.
13556 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13558 (TypeContainer.AddField): ... this.
13559 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13560 with initializers to include 'Const's.
13561 (ClassPart.RegisterFieldForInitialization): Forward to
13563 * const.cs (Const.Const): Pass initializer to base class.
13564 (Const.Define): In case of decimal constants, register them for
13565 initialization in a static constructor.
13567 2005-05-14 Martin Baulig <martin@ximian.com>
13569 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13570 do not call ResolveUnreachable() on unreachable statements in
13571 here, see the comment in the source code.
13573 2005-05-13 Raja R Harinath <rharinath@novell.com>
13576 * expression.cs (BinaryResolveOperator): If one of the operands of
13577 an equality comparison is 'null' and the other is a pointer type,
13578 convert the null to a NullPointer.
13579 * convert.cs (ImplicitReferenceConversion): If the expression is a
13580 NullLiteral and the target type is a pointer type, return a
13581 NullPointer instead.
13582 (ImplicitConversionStandard): Likewise.
13584 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13586 * cs-parser.jay: Set readonly context based on special constructs.
13588 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13589 readonly variable error handling.
13591 * rootcontext.cs (EmitCode): Don't verify members when error
13594 * statement.cs (LocalInfo): Add reaodnly context information.
13595 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13597 2005-05-13 Raja R Harinath <rharinath@novell.com>
13599 * statement.cs (Block.Resolve): Revert change below. Modify fix
13600 for #74041 to initialize 'resolved' to false only for explicit
13601 blocks. Fixes #74873.
13603 2005-05-12 Raja R Harinath <harinath@gmail.com>
13606 * typemanager.cs (unmanaged_enclosing_types): New.
13607 (IsUnmanagedType): Avoid infloops by using
13608 'unmanaged_enclosing_types' to talk with recursive invocations.
13610 2005-05-13 Martin Baulig <martin@ximian.com>
13612 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13613 instance variable, not a local. Fix #74873.
13614 (Block.ResolveUnreachable): Set it to true here.
13616 2005-05-11 Duncan Mak <duncan@novell.com>
13618 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13619 continuing to process for 'arg'.
13620 (handle_preprocessing_directive): Check the argument of the #endif
13621 directive and report error CS1025 if there are any trailing
13624 According to the C# spec, having even whitespace after the #endif
13625 directive is illegal; however, because we call arg.TrimEnd ()
13626 beforehand, we have the same behavior as csc, allowing whitespace
13627 after the directive.
13631 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13635 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13636 (Constructor.GetObsoleteAttribute): Implemented correctly.
13638 2005-05-10 Martin Baulig <martin@ximian.com>
13640 * support.cs (ReflectionParameters.ParameterModifier): Use
13641 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13642 and `ParameterAttributes.In'. Fixes #74884.
13644 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13646 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13648 * expression.cs (Argument.GetParameterModifier): Turned to property.
13649 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13651 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13654 2005-05-09 Raja R Harinath <rharinath@novell.com>
13657 * decl.cs (MemberCache.AddMethods): Register override methods,
13658 rather than non-override methods.
13659 * typemanager.cs (RegisterOverride): New.
13660 (IsOverride): Update.
13662 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13666 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13667 recursive declaration.
13669 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13671 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13673 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13675 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13677 2005-05-05 Raja R Harinath <rharinath@novell.com>
13680 * decl.cs (DeclSpace.FamilyAccessible):
13681 Use TypeManager.IsNestedFamilyAccessible.
13683 Fix reopened #64812.
13684 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13687 2005-05-04 Raja R Harinath <rharinath@novell.com>
13688 Abin Thomas <projectmonokochi@rediffmail.com>
13689 Anoob V E <projectmonokochi@rediffmail.com>
13690 Harilal P R <projectmonokochi@rediffmail.com>
13693 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13694 allow access to all static members.
13696 2005-05-04 Martin Baulig <martin@ximian.com>
13698 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13700 2005-05-04 Martin Baulig <martin@ximian.com>
13704 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13705 section at the end; make things work if `default' is not the last
13708 2005-05-04 Martin Baulig <martin@ximian.com>
13712 * statement.cs (Switch): Replaced the `got_default' field with a
13713 `default_section' one.
13714 (Switch.CheckSwitch): Set `default_section' here.
13715 (Switch.Resolve): If we're a constant switch and the constant is
13716 not found, use the default section.
13718 2005-05-03 Martin Baulig <martin@ximian.com>
13720 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13722 * statement.cs (Foreach.ArrayForeach): New nested class.
13723 (Foreach.TemporaryVariable): New nested class.
13724 (Foreach.EmitArrayForeach): Removed; this is now in the new
13725 ArrayForeach class.
13727 2005-05-03 Raja R Harinath <rharinath@novell.com>
13729 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13731 (VerifyPendingMethods): Revert change below.
13733 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13734 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13735 that used to trigger warning -28. Remove warning -28.
13736 * expression.cs (Invocation.OverloadResolve): Use
13737 TypeManager.IsOverride to distinguish override methods.
13740 * pending.cs (VerifyPendingMethods): If a base type implements the
13741 requested interface, don't bother checking individual methods of
13742 the base type. As a side-effect, this prevents the creation of
13743 unnecessary proxies.
13745 2005-05-02 Martin Baulig <martin@ximian.com>
13749 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13750 Also `And' the locals if the old vector is null.
13751 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13752 null; in this case we basically reset all the variables.
13754 2005-05-02 Martin Baulig <martin@ximian.com>
13758 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13759 Added `FlowBranching branching' argument; always `and' the
13760 variables instead of `or'ing them unless we're an infinite loop.
13762 * statement.cs (While.Resolve): Create a new sibling unless we're
13765 2005-05-02 Martin Baulig <martin@ximian.com>
13769 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13770 arguments; use it instead of creating a new TopLevelBlock.
13771 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13772 our ConstructorInitializer.
13775 (TopLevelBlock.TopLevelBranching): New public property.
13776 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13777 and create our `TopLevelBranching'.
13779 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13780 anonymous method host, use `block.TopLevelBranching' rather than
13781 creating a new branching.
13783 2005-04-20 Miguel de Icaza <miguel@novell.com>
13785 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13786 a ScopeInfo, if any of the current children is a child of the new
13787 entry, move those children there.
13789 2005-04-30 Martin Baulig <martin@ximian.com>
13791 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13792 at the beginning of a SwitchSection. Fix #73335.
13794 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13797 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13799 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13800 (FieldExpr.DoResolve): Obsolete members are ignored for field
13803 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13805 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13806 of arrays detection.
13808 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13810 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13812 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13815 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13817 * cs-parser.jay: Use the prefered version of -unsafe in error
13820 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13822 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13825 2005-04-20 John Luke <john.luke@gmail.com>
13827 * driver.cs: fix typo in error message, --outout to --output
13829 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13831 * codegen.cs (InRefOutArgumentResolving): New field.
13833 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13834 fields outside contructor.
13836 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13838 2005-04-19 Miguel de Icaza <miguel@novell.com>
13840 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13841 parameter code was not completed ever, so it was not as up-to-date
13842 as local variables. Must finish it.
13844 The bug fix was to compare the Toplevel of the block, not the
13845 current block. Thanks for Ben for pointing this out.
13847 2005-04-19 Raja R Harinath <rharinath@novell.com>
13849 * decl.cs (AddMethods): Use the declaring type of the problem
13850 method to determine if we want to squash a warning.
13852 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13854 * attribute.cs: Removed debug output.
13856 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13858 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13861 2005-04-18 Raja R Harinath <rharinath@novell.com>
13864 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13865 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13866 all null comparisons against reference types.
13868 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13871 * class.cs (TypeContainer.CircularDepException) New nested
13873 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13874 (TypeContainer.DefineType): Removed error, reset InTransit before
13876 (Class.DefineType): Throw exception when is in Transit.
13877 Catch exception and report error.
13878 (Struct.DefineType): Throw exception when is in Transit.
13879 Catch exception and report error.
13880 (Interface.DefineType): Throw exception when is in Transit.
13881 Catch exception and report error.
13883 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13884 handle nested exception handlers.
13886 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13889 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13890 InFinally and InCatch storage.
13892 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13893 (Catch.Resolve): Set and Restore ec.InCatch.
13894 (Try.Resolve): Set and Restore ec.InFinally.
13895 (Try.HasCatch): True when try has catch.
13897 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13899 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13900 for the same event member, so exclude such cases from warning 419.
13903 2005-04-16 Miguel de Icaza <miguel@novell.com>
13905 * expression.cs (Binary.ResolveOperator): Apply patch from John
13906 Luke to fix bug 59864: operators &, | and ^ on enumerations
13907 require that the same enum type on both sides.
13909 * driver.cs: Add warnings to old flag usage, this is to assist
13910 people who produce Makefiles and hope that the Makefiles will be
13913 * class.cs (TypeContainer.EmitType): Moved the definition of the
13914 special $PRIVATE$ field from the resolve phase to the Emit phase.
13915 During resolve we do not know if we are a struct with
13916 HasExplicitLayout, we know this only after the attributes for the
13919 Set the FieldOffset to zero on the dummy field that we create for
13920 the class. Fixes 74590.
13922 2005-04-16 Raja R Harinath <rharinath@novell.com>
13925 * ecore.cs (PropertyExpr.resolved): New.
13926 (DoResolve): Use it to handle a case of double resolution here.
13927 Handle a case of identical-name-and-type-name.
13928 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13929 resolution by storing the results of expression resolution back
13930 into the "probes" array.
13932 2005-04-15 Raja R Harinath <rharinath@novell.com>
13934 Fix cs0208-7.cs and cs0208-8.cs.
13935 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13936 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13937 error reporting to point out the reason a struct is not unmanaged.
13939 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13941 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13942 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13944 2005-04-13 Raja R Harinath <rharinath@novell.com>
13947 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13948 IdenticalNameAndTypeName here.
13949 (EventExpr.InstanceResolve): Likewise.
13951 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13953 C# 2.0 DefaultCharSetAttribute implementation
13955 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13956 which allows us to set GlobalNamespace for every resolve.
13957 (Attribute.ResolveArguments): Cut from Resolve.
13958 (Attribute.GetCharSetValue): Returns CharSet named argument.
13959 (Attribute.DefinePInvokeMethod): Gets default charset from
13961 (GlobalAttribute.ResolveAsTypeStep): Override.
13962 (GlobalAttribute.ResolveArguments): Override.
13964 * class.cs (TypeAttr): Is protected.
13966 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13967 (ModuleClass.DefaultCharSetType): New memeber.
13968 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13970 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13971 charset from module.
13973 * delegate.cs (TypeAttr): Override.
13974 (Delegate.DefineType): Use this TypeAttr.
13976 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13977 at very early stage (before types are defined) to resolve model
13978 module attributes. It will probably not work with corlib but it
13981 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13982 charset from module.
13984 * typemanager.cs (default_charset_type): New type.
13986 2005-04-13 Raja R Harinath <rharinath@novell.com>
13988 * decl.cs (MemberCache.AddMethods): Don't warn if
13989 System.Object.Finalize has buggy MethodAttributes.
13991 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13994 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13996 * doc.cs : detect ambiguous reference to overloaded members.
13997 Fixed bug #71603. MS 1.1 csc does not detect it.
13999 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14001 * doc.cs : delegates must not be referenced with parameters.
14004 2005-04-12 Miguel de Icaza <miguel@novell.com>
14006 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14008 2005-04-10 Miguel de Icaza <miguel@novell.com>
14010 * driver.cs (MainDriver): Stop processing if the CLS stage found
14013 (CompilerCallableEntryPoint.InvokeCompiler): Always
14014 reset after execution; Take a TextWriter argument for the
14017 * report.cs: Use the error stream instead of hardcoding stderr.
14019 2005-04-09 Miguel de Icaza <miguel@novell.com>
14021 * class.cs: Reduce code paths to test, too small of an
14022 optimization to make it worth the extra testing. Always perform
14025 2005-04-08 Raja R Harinath <rharinath@novell.com>
14028 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14029 operators that had errors reported on them.
14031 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14033 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14035 (Attribute.Resolve): Add named argument type checking.
14037 * class.cs (FixedField.Define): Use IsPrimitiveType
14039 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14041 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14042 unsafe parameter types.
14044 * statement.cs (Using.ResolveExpression): Add better error description.
14046 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14048 2005-04-08 Raja R Harinath <rharinath@novell.com>
14051 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14052 AttributeUsageAttribute in the emitcontext of the attribute class,
14053 not in the emitcontext of the attributable entity it was attached to.
14054 * cs-parser.jay: Use 'current_class', not 'current_container',
14055 when creating a GlobalAttribute.
14057 2005-04-08 Alp Toker <alp@atoker.com>
14059 * pending.cs: The fix to #58413 failed to compile methods implementing
14060 interfaces with/without params modifiers and vice versa, even though
14061 params modifiers aren't part of the signature. Make the modifier check
14062 less strict as in csc.
14064 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14065 Anoob V E <projectmonokochi@rediffmail.com>
14066 Harilal P R <projectmonokochi@rediffmail.com>
14069 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14070 modifiers of pending methods.
14071 (PendingImplementation.PendingImplementation): Initialize it.
14072 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14073 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14074 with ParameterData. Add check for modifiers.
14075 * class.cs (MethodData.Define): Update to changes.
14077 2005-04-07 Raja R Harinath <rharinath@novell.com>
14079 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14081 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14083 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14086 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14089 * typemanager.cs: Registered RequiredAttributeAttribute.
14091 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14093 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14094 Warning CS0169 is back at level 3.
14095 (IMethodData.SetMemberIsUsed): New method.
14097 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14098 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14100 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14102 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14104 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14107 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14110 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14111 to avoid the problems with nested types.
14113 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14114 Anoob V.E <projectmonokochi@rediffmail.com>
14115 Harilal P.R <projectmonokochi@rediffmail.com>
14116 Raja R Harinath <rharinath@novell.com>
14119 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14121 * typemanager (GetConstructor): Make public.
14123 2005-04-05 John Luke <john.luke@gmail.com>
14124 Raja R Harinath <rharinath@novell.com>
14127 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14128 struct too. Return false quicker in a few cases.
14129 (VerifyUnManaged): Use it.
14131 2005-04-05 Raja R Harinath <rharinath@novell.com>
14134 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14135 not 'unreachable_seen'.
14137 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14139 * attribute.cs (Attribute.GetValue): Removed unused.
14141 * codegen.cs (CodeGen.TrimExt): Removed unused.
14143 * cs-parser.jay (output): Removed unused.
14145 * cs-tokenizer.cs (hex_digits): Removed unused.
14147 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14149 * expression.cs (Indirection.LoadExprValue): Removed unused.
14150 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14152 * iterators.cs (Iterator.param_types): Removed unused.
14154 * statement.cs (Goto.block): Removed unused.
14155 (ToplevelBlock.did): Removed unused.
14156 (Switch.ResolveConstantSwitch): Removed unused.
14158 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14160 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14163 2005-04-01 Raja R Harinath <rharinath@novell.com>
14165 Fix #74232 and cs0208-3.cs.
14166 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14167 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14168 unmanaged type. Don't use FieldBuilders when 't' is a
14169 TypeBuilder. Use ModFlags and MemberType fields.
14170 * class.cs (MemberBase.member_type): Rename from MemberType.
14171 (MemberBase.MemberType): New property. Determines member_type on
14173 (MemberBase.DoDefine): Don't initialize MemberType here.
14174 (FieldMember.Define): Likewise.
14176 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14179 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14180 Attributes are emitted there.
14182 2005-04-01 Raja R Harinath <rharinath@novell.com>
14184 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14185 keyword in 'partial enum' too.
14186 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14188 Report from Kamil Skalski <nazgul@omega.pl>.
14191 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14192 have partial containers too.
14194 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14195 in block' checks to Block.CheckInvariantMeaningInBlock.
14196 * statement.cs (Block.GetKnownVariableInfo): Make private.
14197 (Block.IsVariableUsedInChildBlock): Remove.
14198 (Block.IsVariableUsedInBlock): Likewise.
14199 (Block.CheckInvariantMeaningInBlock): New. Show location of
14200 conflicting declaration.
14201 (Block.AddVariable): Make error messages less long-winded and more
14202 specific. Show location of conflicting declaration.
14203 * parameter.cs (Parameters.Location): New readonly property.
14205 2005-03-31 Raja R Harinath <rharinath@novell.com>
14207 Clean up semantics of invoking ResolveMemberAccess.
14208 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14209 can have an instance, ensure that we pass in a non-TypeExpression
14210 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14211 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14212 argument. Update to changes and simplify.
14213 (FieldExpr.Emitinstance): Remove CS0120 check.
14214 (PropertyExpr.EmitInstance): Likewise.
14215 * expression.cs (Argument.Resolve): Likewise.
14216 (Invocation.DoResolve): Update to changes in semantics of
14217 InstanceExpression.
14219 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14222 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14225 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14227 2005-03-31 Raja R Harinath <rharinath@novell.com>
14229 Fix difference in behaviour with commandline invocation.
14230 * driver.cs (Driver.Reset): New.
14231 (CompilerCallableEntryPoint): Call it.
14233 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14234 variable" warnings if the boolean expression failed to resolve.
14236 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14238 * attribute.cs: Fix the union of several permissions when some of them
14239 are unrestricted (so the result isn't an unrestricted permission set).
14242 2005-03-30 Raja R Harinath <rharinath@novell.com>
14244 * ecore.cs (MemberExpr): New class. Convert from interface
14246 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14247 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14249 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14250 (MethodGroupExpr.IsExplicitImpl): Remove.
14251 (Expression.GetFieldFromEvent): Remove.
14252 (SimpleName.MemberStaticCheck): Remove.
14253 (SimpleName.DoSimpleNameResolve): Update to changes.
14254 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14255 (MemberAccess.IdenticalNameAndTypeName): Remove.
14256 (MemberAccess.error176): Move to MemberExpr.
14257 (MemberAccess.DoResolve): Update to changes.
14258 (BaseAccess.DoResolve): Likewise.
14260 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14262 C# 2.0 Conditional attribute class implementation
14264 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14265 Analyzes class whether it has attribute which has ConditionalAttribute
14266 and its condition is not defined.
14268 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14269 (Class.IsExcluded): New method. Search for at least one defined
14270 condition in ConditionalAttribute of attribute class.
14272 2005-03-30 Raja R Harinath <rharinath@novell.com>
14274 * ecore.cs (PropertyExpr): Derive from Expression, not
14275 ExpressionStatement.
14276 (PropertyExpr.EmitStatement): Remove.
14278 2005-03-29 Raja R Harinath <rharinath@novell.com>
14281 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14282 internal field "value__" of an enum be private. The examples for
14283 "value__" that I found on MSDN all used FieldAttributes.Private.
14285 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14286 Don't mention IL method attribute names.
14288 Fix #47991. Remove a TODO.
14289 * statement.cs (Block.Toplevel): Make into a field.
14290 (Block.Parameters): Move into ToplevelBlock.
14291 (Block.known_variables): Rename from child_variable_names.
14292 (Block.Block): Remove variants that take Parameters. Initialize
14293 'Toplevel' with the immediately surrounding toplevel block.
14294 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14295 LocalInfo parameter.
14296 (Block.GetKnownVariableInfo): New.
14297 (Block.IsVariableNameUsedInChildBlock): Update.
14298 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14299 the block, even though it may not be in scope.
14300 (Block.AddVariable): Remove Parameters parameter. Use
14301 Toplevel.Parameters instead.
14302 (Block.AddConstant): Remove Parameters parameter.
14303 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14304 (Block.IsParamaterReference): Likewise.
14305 (Block.IsLocalParameter): Likewise. Simplify a lot.
14306 (ToplevelBlock.Parameters): New. Moved from Block.
14307 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14308 initialize Parameters to a non-null value.
14309 * cs-parser.jay: Update to changes.
14310 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14311 simple names that mean different things in the same block. Use
14312 Block.IsVariableNameUsedInBlock.
14314 2005-03-28 Raja R Harinath <rharinath@novell.com>
14316 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14317 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14318 GetTypeHandle. It is possible for a reflected type to derive from
14319 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14320 System.Array during mscorlib compilation).
14321 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14322 contain a method_hash, don't create one either. Don't create a
14323 deep copy of the base cache's method_hash.
14324 (MemberCache.SetupCache): Rename back from DeepCopy.
14325 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14326 already initialized. If we see an override function, add its
14327 underlying base virtual function to the member_hash too.
14329 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14331 2005-03-26 Raja R Harinath <harinath@acm.org>
14334 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14335 fails to resolve, ensure that the LHS is still resolved as an
14338 2005-03-25 Raja R Harinath <harinath@acm.org>
14340 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14342 (Enum.current_ec): Remove.
14343 (Enum.LookupEnumValue): Remove EmitContext argument.
14344 Just uses the one created during DefineType.
14345 (Enum.FindMembers): Update.
14346 * expression.cs (MemberAccess.DoResolve): Update.
14348 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14350 * assign.cs (Assign.DoResolve): Check for CS1717 when
14351 source and target are same (uses Equals).
14353 * expression.cs (LocalVariableReference, ParameterReference,
14354 This): Implemented Equals, GetHashCode.
14356 * statement.cs (Block.GetParameterReference): Removed useless
14359 2005-03-22 Raja R Harinath <rharinath@novell.com>
14362 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14363 blocks before deciding whether the error is cs0136 or cs0128.
14365 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14366 (using_alias_directive, using_namespace_directive): Pass
14367 MemberName, not an expression to Namespace.UsingAlias and
14369 (MakeName): Use the MemberName of the namespace.
14370 * namespace.cs (Namespace.MemberName): New.
14371 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14372 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14374 * decl.cs (MemberName.Name): Make readonly.
14375 (MemberName.FromDotted): New "constructor".
14376 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14377 (MemberCore.Name): Compute from MemberName on demand.
14378 (MemberCore.SetMemberName): Provide a way to change the
14380 (MemberCore.AddToContainer): Don't take a fullname parameter.
14381 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14382 fully qualified name of the container to the member name.
14383 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14384 only if the type is a member of the root container.
14385 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14386 MemberName.Left rather than searching for an embedded ".".
14387 (PartialContainer.CreatePart): Update to changes in RootContext.
14388 (MemberBase.ShortName): Turn into a property. Use
14389 MemberCore.SetMemberName.
14390 (MemberBase.ExplicitInterfaceName): Remove.
14391 (MemberBase.UpdateMemberName): Remove.
14392 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14393 (PropertyBase.SetMemberName): New override.
14394 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14395 (Tree.GetDecl): New.
14396 (Tree.AllDecls): Rename from Decls.
14397 * attribute.cs, enum.cs, report.cs: Update to changes.
14398 * driver.cs (MainDriver): Use MemberName.FromDotted on
14399 RootContext.MainClass.
14401 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14403 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14406 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14408 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14410 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14411 property accessor modifiers.
14413 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14414 fixed buffer attribute (CS1716).
14415 (PropertyMethod.HasCustomAccessModifier): When property accessor
14416 has custom modifier.
14418 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14420 (PropertyExpr.DoResolveLValue): Add CS0272.
14422 2005-03-17 Miguel de Icaza <miguel@novell.com>
14424 * convert.cs: When converting to a pointer, use the proper Conv.U
14425 or Conv.I depending on the source data type.
14427 * cs-tokenizer.cs: Make the size for large decimal constants,
14430 2005-03-17 Martin Baulig <martin@ximian.com>
14432 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14433 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14435 2005-03-17 Martin Baulig <martin@ximian.com>
14437 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14438 to bool so we can return an error condition.
14439 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14442 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14444 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14447 2005-03-16 Raja R Harinath <rharinath@novell.com>
14449 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14450 Refactor to avoid traversing the list of assemblies, and to avoid
14451 string concatenation.
14452 * typemanager.cs (guid_attr_type): Remove.
14453 (negative_hits, pointers, references): Remove hashes.
14455 (GetConstructedType): New. Uses type_hash to handle constructed
14456 types (arrays, references, pointers).
14457 (GetReferenceType, GetPointerType): Use it.
14458 (GetNestedType): New. Uses type_hash to handle nested types of
14460 (LookupType, LookupTypeDirect): Remove.
14461 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14462 'types' hash and LookupTypeReflection directly.
14463 (params_string, params_object): Use GetConstructedType.
14464 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14466 (Namespace.Lookup): Use cached_types.
14467 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14468 provided by old TypeManager.LookupType.
14469 * rootcontext.cs (MakeFQN): Remove.
14470 * decl.cs (DeclSpace.MakeFQN): Likewise.
14471 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14472 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14473 TypeManager.GetConstructedType.
14474 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14476 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14478 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14481 * cs-parser.jay: Reports CS1527 for any namespace element.
14483 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14486 * expression.cs (ParameterReference.IsAssigned): Changed error to
14488 (Error_WrongNumArguments): Moved CS0245 detection here.
14490 * statement.cs (Return.Resolve): Add CS1622 report.
14492 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14494 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14496 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14498 * attribute.cs expression.cs: Get rid of some allocations.
14500 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14502 * doc.cs : just eliminate the latest change.
14504 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14506 * doc.cs : commented out the latest change. It breaks xml-030.cs
14508 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14510 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14511 fail. So invoke CreateType() in FindDocumentedType().
14513 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14515 * cs-tokenizer.cs : added IsKeyword().
14516 * doc.cs : Detect keyword incorrectly used as identifier.
14517 Allow identifiers prefixed by @.
14519 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14521 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14522 It caused exception in namespace resolving (again!).
14524 * class.cs (Class.ctor): Removed exit.
14525 (PropertyMethod.ctor): ditto.
14527 * codegen.cs (Codegen.Reset): Reset static data.
14528 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14530 * cs-tokenizer.cs (Cleanup): Removed.
14532 * driver.cs (GetSystemDir): Rewrote to one line command.
14533 It caused problem with unloaded dynamic modules.
14534 (UnixParseOption): Removed Exit.
14535 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14536 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14537 Now can be mcs used as library.
14539 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14542 * location.cs (Reset): Reset static data.
14544 * namespace.cs (Reset): Reset static data.
14546 * report.cs (Report.Reset): Reset static data.
14548 * rootcontext.cs (RootContext.Reset): Reset static data.
14550 * tree.cs (RootTypes.ctor): Use Location.Null
14552 * typemanager.cs (TypeManager.Reset): Reset static data.
14553 (CoreLookupType): Removed Exit.
14554 (TypeHandle.Reset): Reset static data.
14556 2005-03-10 Raja R Harinath <rharinath@novell.com>
14559 * typemanager.cs (ComputeNamespaces): Import namespaces from
14560 referenced modules too.
14562 2005-03-09 Raja R Harinath <rharinath@novell.com>
14564 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14567 2005-03-09 Raja R Harinath <rharinath@novell.com>
14569 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14570 enclosing DeclSpace. This ensures that a name-lookup populates
14571 more caches and there are fewer 'TypeExpression's. Carve out
14572 nested type lookup into ...
14573 (LookupNestedTypeInHierarchy): ... this.
14575 2005-03-09 Raja R Harinath <rharinath@novell.com>
14577 Clean up a few partial-class semantics.
14578 Fixes test-357.cs and cs1618-2.cs.
14579 * cs-parser.jay (struct_declaration): Use 'current_class' as
14580 parent of newly-created struct. Remove call to Register ().
14581 Use 'pop_current_class' to complete handing the current struct.
14582 (interface_declaration): Likewise.
14583 (class_declaration): Likewise.
14584 (enum_declaration): Use 'current_class' as parent of newly created
14586 (delegate_declaration): Likewise.
14587 (pop_current_class): New function. This is used to handle closing
14588 up the 'current_class' and 'current_container', and pointing them
14589 to the enclosing class/container.
14590 (CSharpParser): Initialize 'current_class' too.
14591 * decl.cs (MemberCore): Add check for invariant: a partial
14592 container is not a parsed entity, and thus does not enclose any
14594 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14595 (DeclSpace.BaseTypeExpr): Use it.
14596 (DeclSpace.LookupType): Add check for invariant.
14597 * class.cs (TypeContainer): Add check for invariant: a nested
14598 class should have the same NamespaceEntry as its enclosing class.
14599 (TypeContainer.EmitFieldInitializers): Make virtual.
14600 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14602 (TypeContainer.Register): Remove.
14603 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14604 null. Use TypeResolveEmitContext for resolving base types and
14605 interfaces. Move initialization of Parts.TypeBuilder here from
14607 (TypeContainer.DefineNestedTypes): ... here.
14608 (PartialContainer): Take a Namespace not a NamespaceEntry.
14609 (PartialContainer.Create): Don't use Register. Call the
14610 appropriate Add... function directly.
14611 (ClassPart): Take both the PartialContainer and the enclosing
14612 class as constructor arguments.
14613 (ClassPart.EmitFieldInitializers): Override.
14614 (ClassPart.PartFindNestedTypes): Remove.
14615 (FieldBase.GetInitializerExpression): Resolve the initializer
14616 expression in the emit context of the enclosing class.
14617 * tree.cs (RootTypes): Remove Register ().
14619 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14621 * cs-parser.jay: Removed CS0134.
14623 * driver.cs: Removed CS1901.
14625 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14626 for predefined types.
14628 2005-03-07 Duncan Mak <duncan@novell.com>
14630 * codegen.cs (Save): Catch UnauthorizedAccessException as
14631 well. Fixes bug #73454.
14633 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14635 * cs-tokenizer.cs (xtoken): Add CS1035.
14637 * class.cs (MethodData.Define): Add CS0683.
14638 (FieldMember.ctor): Add CS0681.
14640 2005-03-07 Raja R Harinath <rharinath@novell.com>
14642 * ecore.cs (SimpleName.DoResolve): Rename from
14643 SimpleName.DoResolveAllowStatic.
14644 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14645 Pass 'intermediate' flag to MemberStaticCheck.
14646 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14647 of "intermediate" lookups via MemberAccess.
14648 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14649 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14651 2005-03-07 Raja R Harinath <rharinath@novell.com>
14654 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14655 slipped in because of variable names that are identical to a
14656 builtin type's BCL equivalent ('string String;', 'int Int32;').
14657 (PropertyExpr.EmitInstance): Likewise.
14659 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14661 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14663 * report.cs (warning_ignore_table): Made public.
14665 2005-03-04 Raja R Harinath <rharinath@novell.com>
14668 * class.cs (MethodData.Emit): Pass 'container' to
14669 container.GetObsoleteAttribute instead of 'container.Parent'.
14671 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14673 * cs-parser.jay: Add 1534 error test.
14675 * iterators.cs (Yield.CheckContext): Add error 1629.
14676 (Iterator.ctor): Save unsafe modifier.
14677 (MoveNextMethod.DoEmit): Restore unsafe context.
14679 * namespace.cs (UsingAlias): Better error message.
14681 2005-03-03 Dan Winship <danw@novell.com>
14683 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14684 the warning message [#73219]
14686 2005-03-03 Raja R Harinath <rharinath@novell.com>
14688 Fix compile with MCS 1.0.0.0.
14689 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14690 w_restore to not depend on string constant folding.
14692 2005-03-03 Raja R Harinath <rharinath@novell.com>
14694 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14695 CS0246 check to users who passed 'silent = false'.
14696 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14698 (SimpleName.SimpleNameResolve): Update.
14699 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14700 (MemberAccess.IdenticalNameAndTypeName): Update.
14701 * doc.cs (FindDocumentedTypeNonArray): Update.
14703 2005-03-03 Raja R Harinath <rharinath@novell.com>
14705 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14706 * parameters.cs (ComputeAndDefineParameters): Remove.
14707 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14708 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14709 Use GetParameterInfo.
14711 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14713 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14715 2005-03-02 Raja R Harinath <rharinath@novell.com>
14717 Unify DeclSpace.LookupType and DeclSpace.FindType.
14718 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14719 is in charge of defining nested types on demand.
14720 (DeclSpace.LookupType): Use it when the current_type is a
14721 TypeBuilder. Use LookupTypeDirect for reflected types.
14722 (DeclSpace.FindType): Remove.
14723 (DeclSpace.LookupInterfaceOrClass): Likewise.
14724 (DeclSpace.DefineTypeAndParents): Likewise.
14725 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14726 DeclSpace.LookupType.
14727 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14728 * typemanager.cs (LookupType): Simplify.
14729 (AddUserType): Remove type from negative_hits.
14730 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14731 * class.cs (TypeContainer.FindMembers): Move handling of nested
14733 (TypeContainer.FindMembers_NestedTypes): ... here.
14734 (TypeContainer.FindNestedType): Implement override.
14735 (ClassPart.FindNestedType): Delegate to PartialContainer.
14736 (ClassPart.PartFindNestedType): Looks up the nested types of the
14739 2005-03-02 Martin Baulig <martin@ximian.com>
14741 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14742 static constructor in static classes.
14744 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14746 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14747 sizeParamIndex is not specified.
14749 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14752 * report.cs (WarningMessage.IsEnabled): Missing null check.
14754 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14756 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14757 in the fields and not in the properties.
14759 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14761 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14764 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14766 * attribute.cs: Small refactoring (improved robustness).
14767 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14768 (ValidateGuid): Removed.
14769 (Resolve): Removed referenced to above mentioned.
14770 (GetAttributeUsage): Made private and changed to work without
14772 (GetIndexerAttributeValue): Don't crash.
14773 (GetConditionalAttributeValue): Ditto.
14774 (GetClsCompliantAttributeValue): Ditto.
14775 (ExtractSecurityPermissionSet): All attributes exceptions are
14777 (GetPropertyValue): New helper.
14778 (GetMethodImplOptions): New method.
14779 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14780 some missing properties.
14782 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14783 (Method.ApplyAttributeBuilder): Updated.
14785 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14788 2005-02-28 Raja R Harinath <rharinath@novell.com>
14791 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14792 non-simple types (array, pointer, reference).
14794 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14796 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14798 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14800 (Method.CheckBase): Catch wrong destructor here.
14801 (MethodData.Define): Add errors 550, 668.
14803 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14805 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14807 * pending.cs (VerifyPendingMethods): Add error 551.
14809 * typemanager.cs (CSharpName): Next error report helper.
14811 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14813 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14814 attributes. Removed useless attribute double check.
14815 It saves almost 2MBs for corlib.
14817 2005-02-25 Raja R Harinath <rharinath@novell.com>
14820 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14821 called twice in case of error.
14823 2005-02-23 Chris Toshok <toshok@ximian.com>
14825 Fix compiler portions of #72827.
14826 * statement.cs (Block.Emit): call Begin/EndScope on the
14827 EmitContext instead of the ILGenerator.
14829 * codegen.cs (EmitContext.BeginScope): new method, call
14830 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14832 (EmitContext.BeginScope): same, but EndScope and CloseScope
14834 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14835 offset and call the superclass's OpenScope(int) with it.
14836 (SymbolWriter.CloseScope): get the current il
14837 offset and call superclass's CloseScope(int) with it.
14839 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14841 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14842 CS1677 for out and ref as well.
14844 * class.cs (Method.Define): Add error CS1599 detection.
14846 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14848 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14850 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14852 * support.cs.cs (ModifierDesc): New helper method.
14854 2005-02-23 Raja R Harinath <rharinath@novell.com>
14855 Abin Thomas <projectmonokochi@rediffmail.com>
14856 Anoob V E <projectmonokochi@rediffmail.com>
14857 Harilal P R <projectmonokochi@rediffmail.com>
14859 Fix #57851, #72718.
14860 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14861 MemberLookup (used for error reporting) actually returns a result.
14862 Fix error report number (122, not 112).
14864 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14865 Anoob V E <projectmonokochi@rediffmail.com>
14866 Harilal P R <projectmonokochi@rediffmail.com>
14869 * pending.cs (PendingImplementation.GetAbstractMethods):
14870 Find NonPublic members too.
14872 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14874 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14877 * class.cs (MethodCore.CheckMethodAgainstBase):
14878 Add error 239 report.
14880 2005-02-21 Raja R Harinath <rharinath@novell.com>
14883 * expression.cs (Invocation.IsApplicable): Make public.
14884 (Invocation.IsParamsMethodApplicable): Likewise.
14885 * delegate.cs (Delegate.VerifyApplicability): Don't use
14886 Invocation.VerifyArgumentCompat for parameter applicability
14887 testing. Use Invocation.IsApplicable and
14888 Invocation.IsParamsMethodApplicable.
14890 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14892 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14894 * class.cs (Operator.Define): Add error 217 report.
14896 2005-02-21 Raja R Harinath <rharinath@novell.com>
14898 * namespace.cs (UsingEntry.Resolve): Undo change below.
14900 2005-02-21 Raja R Harinath <rharinath@novell.com>
14903 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14904 disable the error message when the extended MemberLookup also
14906 (Expression.MemberLookupFinal): Update.
14907 (SimpleName.DoSimpleNameResolve): Update.
14908 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14909 Don't use MemberLookupFinal.
14910 (New.DoResolve): Update.
14911 (BaseAccess.CommonResolve): Update.
14913 2005-02-21 Raja R Harinath <rharinath@novell.com>
14916 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14917 occured previously, don't resolve again.
14919 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14922 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14923 argument. Call ResolveAttributeUsage for unresolved.
14924 when types doesn't match ctor arguments.
14926 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14927 for nested attribute classes.
14928 (Class.attribute_usage): Removed.
14929 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14930 for attribute class.
14932 * ecore.cs (IsAttribute): Removed.
14934 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14936 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14938 (attribute_types): Removed.
14939 (EmitCode): Global attributes are emited as the latest.
14941 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14943 * class.cs (EmitFieldInitializers): Don't emit field initializer
14944 for default values when optimilization is on.
14946 * constant.cs (Constant.IsDefaultValue): New property.
14948 * driver.cs: Add /optimize handling.
14952 * literal.cs: Implement new IsDefaultValue property.
14954 * rootcontext.cs (Optimize): New field, holds /optimize option.
14956 2005-02-18 Raja R Harinath <rharinath@novell.com>
14958 Fix crasher in re-opened #72347.
14959 * namespace.cs (Namespace.Lookup): Return null if
14960 DeclSpace.DefineType returns null.
14963 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14965 2005-02-18 Raja R Harinath <rharinath@novell.com>
14967 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14968 now returns null if it cannot resolve to an lvalue.
14969 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14970 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14971 returned null. Remove check for SimpleName.
14972 (EventExpr.DoResolveLValue): New.
14973 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14974 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14976 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14977 avoid CS0131 error.
14978 (Unary.ResolveOperator): Move CS0211 check ...
14979 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14981 (Unary.DoResolveLValue): Simplify.
14982 (AddressOf.DoResolveLValue): New.
14983 (ArrayAccess.DoResolveLValue): New.
14985 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14987 * attribute.cs (Attribute.Resolve): Add arguments casting for
14988 when types doesn't match ctor arguments.
14990 2005-02-16 Raja R Harinath <rharinath@novell.com>
14992 Fix parts of #63202.
14993 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14994 lookup of operator in base type. Ensure that all checks happen
14995 when the operator resolves to an "op_..." method.
14997 2005-02-15 Raja R Harinath <rharinath@novell.com>
15000 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15001 'ignore_cs0104' parameter. Pass it to ...
15002 (NamespaceEntry.Lookup): ... this.
15003 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15004 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15005 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15006 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15007 Update. Request that cs0104 errors be ignored.
15008 (ComposedCast.ResolveAsTypeStep): Update.
15010 2005-02-14 Raja R Harinath <rharinath@novell.com>
15013 * expression.cs (Invocation.BetterFunction): Remove support for
15014 comparing virtual functions and their overrides.
15015 (Invocation.IsOverride): New.
15016 (Invocation.OverloadResolve): Don't consider 'override' functions
15017 during candidate selection. Store them in a lookaside list.
15018 If the selected method is a 'virtual' function, use the list to
15019 find any overrides that are closer to the LHS type.
15021 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15023 * expression.cs (New.DoResolve): Add complex core type reduction.
15024 (New.Constantify): Converts complex core type syntax like 'new int ()'
15025 to simple constant.
15027 2005-02-14 Raja R Harinath <rharinath@novell.com>
15029 * decl.cs (EntryType.EntryType): New constructor to create an
15030 updated copy of a cache entry.
15031 (MemberCache.AddMethods): Use it.
15032 (MemberCache.ClearDeclaredOnly): Remove.
15033 (MemberCache.MemberCache): Update.
15035 2005-02-11 Miguel de Icaza <miguel@novell.com>
15037 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15038 variable. This one is represents the actual low-level declaration
15039 of the method, as opposed to the semantic level `IsStatic'.
15041 An anonymous method which is hosted into a static method might be
15042 actually an instance method. IsStatic would reflect the
15043 container, while MethodIsStatic represents the actual code
15046 * expression.cs (ParameterReference): Use the new MethodIsStatic
15047 instead of IsStatic.
15049 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15050 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15051 set on the current EmitContext.
15053 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15054 resolve our casted expression as an LValue. This triggers the
15055 proper LValue processing that is later required by Assign.
15059 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15061 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15063 C# 2.0 Fixed buffer implementation
15065 * anonymous.cs: Update after RegisterHelperClass renaming.
15067 * attribute.cs (AttributeTester.fixed_buffer_cache):
15068 Cache of external fixed buffers.
15069 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15070 implementation if field is fixed buffer else null.
15073 (TypeContainer.AddField): Accept FieldMember instead of Field.
15074 (FieldBase.IsFieldClsCompliant): Extracted code from
15075 VerifyClsCompliance descendant customization.
15076 (FixedField): New class handles fixed buffer fields.
15077 (FixedFieldExternal): Keeps information about imported fixed
15079 (IFixedField): Make access to internal or external fixed buffer
15082 * cs-parser.jay: Add fixed buffer parsing.
15084 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15087 * expression.cs (Indirection): Extended implementation to accept
15088 fixed buffer field.
15089 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15090 (ElementAccess.MakePointerAccess): Get type as parameter.
15091 (DoResolve): Add fixed buffer field expression conversion.
15092 (DoResolveLValue): Ditto.
15093 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15094 (ArrayPtr): Derives from FixedBufferPtr.
15095 (ArrayPtr.Emit): Add extra emit for array elements.
15097 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15099 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15100 for compiler generated types.
15101 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15103 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15104 and consume less memory.
15105 (Fixed.Resolve): Add fixed buffer case.
15107 * typemanager.cs (compiler_generated_attr_ctor,
15108 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15109 (HasElementType): Add our own implementation to work on every
15112 2005-02-11 Miguel de Icaza <miguel@novell.com>
15114 * anonymous.cs (CaptureContext): Track whether `this' has been
15117 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15118 only captured `this' if it was implicitly done (instance
15119 methods/variables were used).
15121 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15122 `this' must be captured.
15124 2005-01-30 Miguel de Icaza <miguel@novell.com>
15126 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15127 is null it means that there has been no need to capture anything,
15128 so we just create a sibling.
15130 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15132 Just a partial fix. The other half is fairly elusive.
15134 2005-02-10 Raja R Harinath <rharinath@novell.com>
15136 Fix #52586, cs0121-4.cs.
15137 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15138 and return a hashtable.
15139 (MemberCache.ClearDeclaredOnly): New.
15140 (MemberCache.MemberCache): Update to change. Make a deep copy of
15141 the method_hash of a base type too.
15142 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15143 type methods. Overwrite entries with the same MethodHandle so
15144 that the ReflectedType is correct. The process leaves in base
15145 virtual functions and their overrides as distinct entries.
15146 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15147 matters since it was boxed in a ArrayList before.
15148 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15150 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15151 case of a virtual function and its override (choose the overload
15153 (Invocation.OverloadResolve): Avoid 'override' members during
15154 'applicable_type' calculation.
15156 2005-02-09 Raja R Harinath <rharinath@novell.com>
15158 Combine two near-redundant caches.
15159 * typemanager.cs (method_params): Rename from method_internal_params.
15160 (TypeManager.GetParameterData): New. Replace
15161 Invocation.GetParameterData.
15162 (TypeManager.LookupParametersByBuilder): Remove.
15163 * expression.cs (Invocation.method_parameter_cache): Remove.
15164 (Invocation.GetParameterData): Remove.
15166 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15169 2005-02-08 Raja R Harinath <rharinath@novell.com>
15172 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15173 TypeManager.multicast_delegate_type is null, resolve it by looking
15174 up "System.MulticastDelegate".
15175 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15177 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15178 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15179 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15182 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15183 (LabeledStatement.AddReference): New. Set 'referenced'.
15184 (Goto.Resolve): Use it.
15186 2005-02-05 John Luke <john.luke@gmail.com>
15188 * driver.cs: remove duplicate -doc line in Usage ()
15190 2005-02-04 Raja R Harinath <rharinath@novell.com>
15192 * location.cs (Location.AddFile): Fix CS2002 error report.
15194 2005-02-02 Martin Baulig <martin@ximian.com>
15196 * delegate.cs (Delegate.DefineType): Report an internal error if
15197 TypeManager.multicast_delegate_type is null. See bug #72015 for
15200 2005-02-02 Raja R Harinath <rharinath@novell.com>
15202 Fix a crasher in a variant of #31984.
15203 * const.cs (Constant.CheckBase): New override that defers the
15204 new-or-override check in case the base type hasn't been populated
15206 (Constant.Define): Ensure the new-or-override check is performed.
15208 2005-02-01 Duncan Mak <duncan@ximian.com>
15210 * const.cs (LookupConstantValue): Check that `ce' is not null
15211 before calling GetValue ().
15213 2005-02-01 Raja R Harinath <rharinath@novell.com>
15215 Fix test-334.cs (#69519).
15216 * cs-parser.jay (using_alias_directive): Pass in an expression to
15217 NamespaceEntry.UsingAlias.
15218 (using_namespace_directive): Pass in an expression to
15219 NamespaceEntry.Using.
15220 (namespace_name): Don't flatten to a string.
15221 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15222 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15224 (NamespaceEntry.UsingEntry): Likewise.
15225 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15227 (NamespaceEntry.LookupForUsing): Remove.
15228 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15230 (NamespaceEntry.Lookup): Remove support for dotted names.
15232 2005-02-01 Raja R Harinath <rharinath@novell.com>
15234 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15236 (NamespaceEntry.ImplicitParent): Compute on demand.
15237 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15238 parallels the current.
15239 (NamespaceEntry.LookupForUsing): Use it.
15240 (NamespaceEntry.Lookup): If the current namespace-entry is
15241 implicit, don't search aliases and using tables.
15243 2005-02-01 Raja R Harinath <rharinath@novell.com>
15246 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15248 (TypeContainer.BaseCache): Compute on demand.
15249 (TypeContainer.FindMembers): Define constants and types if they're
15250 not already created.
15251 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15253 * const.cs (Constant.Define): Make idempotent.
15255 2005-01-29 Miguel de Icaza <miguel@novell.com>
15257 * pending.cs: Produce better code (no nops produced by using Ldarg
15260 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15261 i - 1' it should be arg + 1.
15265 2005-01-28 Raja R Harinath <rharinath@novell.com>
15267 * attribute.cs (Attribute.CheckAttributeType): Make private
15269 (Attribute.ResolveType): Make virtual.
15270 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15271 handling of RootContext.Tree.Types.
15273 2005-01-27 Raja R Harinath <rharinath@novell.com>
15275 Update attribute-handling to use the SimpleName/MemberAccess
15277 * cs-parser.jay (attribute): Pass in an expression to the
15278 constructors of Attribute and GlobalAttribute.
15279 * attribute.cs (Attribute): Take an expression for the name.
15280 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15281 passed in attribute name expression.
15282 (Attribute.CheckAttributeType): Use it.
15283 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15284 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15285 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15286 argument to prevent error messages if the lookup fails.
15288 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15290 * expression.cs (Indirection): Implemented IVariable interface
15291 to support indirection in AddressOf operator.
15292 (PointerArithmetic.Emit): Add optimalization for case where
15293 result can be precomputed.
15295 2005-01-26 Martin Baulig <martin@ximian.com>
15297 * class.cs (TypeContainer.AttributeTargets): Return the correct
15298 AttributeTargets depending on our `Kind' instead of throwing an
15299 exception; fixes #71632.
15301 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15304 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15307 2005-01-25 Raja R Harinath <rharinath@novell.com>
15310 * expression.cs (MemberAccess.DoResolve): Don't complain with
15311 cs0572 when the LHS of a member access has identical name and type
15314 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15317 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15319 Create custom PermissionSet only for PermissionSetAttribute.
15321 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15324 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15325 delegates in static class.
15327 2005-01-24 Martin Baulig <martin@ximian.com>
15329 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15330 merging an implicit block, just use its reachability.
15332 * statement.cs (Block.Resolve): Make the unreachable code check
15333 work wrt. implicit blocks; see test-337 from #63842.
15335 2005-01-21 Alp Toker <alp@atoker.com>
15337 * cs-parser.jay: destructor_declaration's container is PartialContainer
15338 not Class when partial types are used, so use Kind prop instead of
15341 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15343 * cs-parser.jay: Improve error reporting when an interface
15344 declares new types.
15346 2005-01-20 Dick Porter <dick@ximian.com>
15348 * support.cs: SeekableStreamReader fix from Sandor Dobos
15349 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15350 chars are read. Fixes bug 70369.
15352 2005-01-20 Raja R Harinath <rharinath@novell.com>
15354 * cs-parser.jay (catch_clause): Simplify current_block handling
15357 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15359 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15360 code with ImplicitStandardConversion to handle the implicit
15361 conversion of method groups into valid delegate invocations.
15363 The problem is that in parameter handling we were using this code
15364 path. Fixes bug #64698
15366 2005-01-19 Raja R Harinath <rharinath@novell.com>
15368 * cs-parser.jay: Fix several infelicities.
15369 - Avoid assigning to the parser value stack. Code like
15370 '$3 = null' is unclean. Synthesize a value for the code block
15372 - Avoid using oob_stack for storing location information. Use ...
15373 (_mark_): ... this. New (empty) rule. Saves the current location
15375 (foreach_statement): Avoid using oob_stack for current_block
15376 handling. Use technique used in for_statement and
15377 using_statement. Synthesize a value for the code block to store
15378 additional intermediate information.
15380 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15382 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15383 of a different type is only allowed to private fields of a
15384 containing type, not on fields of a base class.
15386 See test-174.cs and error cs0122-9.cs
15388 2005-01-13 Raja R Harinath <rharinath@novell.com>
15390 Fix test-335.cs (bug #58126).
15391 * cs-parser.jay (argument): Split out non-expression parts of the
15392 rule into 'non_simple_argument'.
15393 (invocation_expression): Support parenthesized invocations with
15394 multiple arguments, and with single non-simple arguments.
15396 2005-01-13 Raja R Harinath <rharinath@novell.com>
15398 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15401 2005-01-12 Raja R Harinath <rharinath@novell.com>
15403 Fix cs0038-1.cs, cs1640-6.cs.
15404 * ecore.cs (Expression.Resolve): Remove special-case for
15405 SimpleName in error-handling.
15406 (Expression.almostMatchedMembers): Relax access permission to
15408 (Expression.MemberLookupFailed): Handle duplicates in
15409 almostMatchedMembers list.
15410 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15411 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15412 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15413 overload if the passed in MemberInfo is a MethodBase.
15415 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15418 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15419 for non-CAS & merge permission sets properly.
15421 2005-01-11 Raja R Harinath <rharinath@novell.com>
15423 Improve standard-compliance of simple name and member access
15424 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15425 * ecore.cs (FullNamedExpression): New abstract base class
15426 for Namespaces and TypeExpressions.
15427 (ResolveFlags.SimpleName): Remove.
15428 (SimpleName): Remove support for dotted names.
15429 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15430 DeclSpace.FindType and DeclSpace.LookupType.
15431 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15432 (Expression.ExprClassName): Make member function.
15433 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15434 a namespace. Remove creation of dotted "SimpleName"s.
15435 (MemberAccess.DoResolve): Likewise.
15436 * decl.cs (DeclSpace.Cache): Make private.
15437 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15438 (DeclSpace.FindType): Update.
15439 (DeclSpace.LookupType): Move here from RootContext. Return a
15440 FullNamedExpression.
15441 * namespace.cs (Namespace): Derive from FullNamedExpression
15442 so that it can be part of expression resolution.
15443 (Namespace.Lookup): Return an FullNamedExpression.
15444 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15446 * rootcontext.cs (NamespaceLookup): Remove.
15447 (LookupType): Move to DeclSpace.
15448 * attribute.cs (CheckAttributeType): Update.
15449 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15450 (FindDocumentedTypeNonArray): Likewise.
15452 2005-01-11 Raja R Harinath <rharinath@novell.com>
15454 Fix cs0509.cs, cs1632.cs.
15455 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15456 is the same as IsInterface.
15457 (TypeContainer.GetClassBases): Likewise.
15458 * statement.cs (LabeledStatement.ig): New field.
15459 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15461 (LabeledStatement.DoEmit): Check that the label was created with
15462 the same ILGenerator.
15464 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15467 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15468 accessors to its properties.
15470 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15471 from accessors to property.
15473 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15476 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15477 only for overrides.
15479 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15481 * attribute.cs: Check for null and empty strings.
15483 I have lost another battle to Paolo.
15485 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15488 * class.cs (PropertyMethod): Set Parent field in ctors.
15489 (SetMethod.InternalParameters): Add unsafe switch hack.
15490 Override MarkForDuplicationCheck where it is appropriate.
15492 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15493 It says whether container allows members with the same name.
15494 Base default is no.
15495 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15496 Removed is_method parameter.
15498 2005-01-06 Duncan Mak <duncan@ximian.com>
15500 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15501 because the previous change led to incorrect reporting of CS1032
15502 ("Cannot define/undefine preprocessor symbols after first token in
15503 file"). Instead of using `tokens_seen' as the only flag that
15504 triggers CS1040, introduce `comments_seen'. This new flag is used
15505 to signify having seen comments on the current line, so it is
15506 unset after a newline.
15508 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15510 * doc.cs : When searching for a type, find nested type too.
15511 This fixes bug #71040.
15513 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15516 - Warn missing member comment on those classes which also does not
15517 have doc comments. Fixed bug #71041.
15518 - Don't warn missing doc comment on default constructor.
15521 2005-01-06 Duncan Mak <duncan@ximian.com>
15523 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15524 comments, set `tokens_seen' to true. This allows us to detect
15525 misplaced preprocessor directives (i.e. not at the beginning of
15526 the a line, nor after whitespaces). In that case, report error
15527 CS1040. This fixes bug #56460.
15529 * cs-parser.jay (interface_member_declaration): Add checks for
15530 IsExplicitImpl, and report CS0541 error if an interface member is
15531 defined as an explicit interface declaration.
15533 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15536 * class.cs (PropertyMethod): Set Parent field in ctors.
15537 (SetMethod.InternalParameters): Add unsafe switch hack.
15539 * decl.cs (MemberCore.Parent): Cannot be readonly.
15541 2005-01-06 Raja R Harinath <rharinath@novell.com>
15543 * decl.cs (DeclSpace.ResolveType): Remove.
15544 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15545 Merge in code from ...
15546 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15547 * class.cs, enum.cs: Update to changes.
15549 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15551 * anonymous.cs: Ensure that we init the scope of our parent if it
15552 has not been initialized yet.
15554 2004-12-30 Duncan Mak <duncan@ximian.com>
15556 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15557 if field.FieldBuilder is null. Fixes #70758.
15559 * convert.cs: Fixed some typos and updated some of the comments.
15560 (ImplicitStandardConversionExists):
15561 (TryImplicitIntConversion): If `target_type' is an interface and
15562 the type of `ic' implements this interface, return true or a new
15563 BoxedCast instead of null. This fixes #70468.
15565 2004-12-29 Duncan Mak <duncan@ximian.com>
15567 * expression.cs (Argument.Emit): Check that Expr is
15568 IMemoryLocation before casting to it, and report CS1510 otherwise.
15572 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15574 * statement.cs (Block.ThisVariable): remove the recursion here, to
15575 make the --profile more sane.
15577 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15579 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15580 assembly, by JB Evain.
15582 2004-12-17 Raja R Harinath <rharinath@novell.com>
15584 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15585 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15586 "parent" refers to enclosing type/class. "base" refers to superclass.
15588 2004-12-17 Raja R Harinath <rharinath@novell.com>
15590 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15591 Ensure that we only have GlobalAttributes.
15592 * attribute.cs (Attribute.Emit): Make non-virtual.
15593 (GlobalAttribute.Emit): Remove.
15594 (Attribute.Resolve): Make virtual.
15595 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15596 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15597 the argument. Don't create one.
15598 (Attribute.GetObsoleteAttribute): Likewise.
15599 (Attribute.GetClsCompliantAttributeValue): Likewise.
15600 * class.cs, decl.cs: Update to changes.
15602 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15604 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15606 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15608 * statement.cs (Foreach.Resolve): Add error 186 report.
15610 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15612 * expression.cs (Conditional.DoResolve): Add warning 429.
15614 * statement.cs (If.Resolve): Add warning 665.
15616 2004-12-16 Raja R Harinath <rharinath@novell.com>
15618 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15619 except when in the parser, and in GlobalAttribute.
15620 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15621 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15622 RootContext.Tree.Types.NamespaceEntry once work is done.
15623 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15624 and resets RootContext.Tree.Types.NamespaceEntry.
15626 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15628 * cs-parser.jay: Don't create a block for every variable.
15630 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15632 * location.cs: Provide extra information.
15634 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15635 variables from the captured environment, it is the ldarg_0.
15637 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15639 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15642 * class.cs: Changed warning level for 169 to avoid developer
15643 displeasure from warning flooding. It will be changed back when they
15644 fix most of current BCL warnings.
15646 * RootContext.cs: Pushed default WarningLevel to 3.
15648 * statement.cs: Removed unused variable.
15650 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15652 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15653 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15654 Add error 502 report.
15655 (StaticClass.DefineType): Add error 441 report.
15656 (Class.AllowedModifiersProp): New virtual property as temporary
15657 extension to AllowedModifiers.
15658 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15659 to share implementation with StaticClass and don't call virtual
15662 * driver.cs (MainDriver): Add error 1558 test.
15664 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15665 report. Moved error 36 test here.
15667 * statement.cs (Throw.Resolve): Add error 724 report.
15669 * typemanager.cs: Add out_attribute_type core type.
15671 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15673 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15675 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15677 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15680 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15682 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15683 Add error 3023 report.
15684 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15686 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15689 2004-12-12 John Luke <john.luke@gmail.com>
15691 * driver.cs (AddArgs): take -- into account when
15692 adding arguments, fixes bug 65710
15694 2004-12-12 Martin Baulig <martin@ximian.com>
15696 * expression.cs (Unary.TryReduceNegative): Added support for
15697 SByteConstant and ByteConstant.
15698 (Unary.Reduce): Check error values from TryReduceNegative().
15700 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15702 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15703 and report exception as error 182.
15705 2004-12-10 Raja R Harinath <rharinath@novell.com>
15707 * driver.cs (Main): Fix message when there are warnings.
15709 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15711 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15713 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15715 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15716 Reduced number of warnings.
15718 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15720 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15722 * driver.cs: Removed message.
15724 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15726 2004-12-08 <vargaz@freemail.hu>
15728 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15730 2004-12-08 Martin Baulig <martin@ximian.com>
15732 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15733 instead of a CS3002 for properties and indexer.
15735 2004-12-08 Martin Baulig <martin@ximian.com>
15737 * decl.cs (MemberName.ToString): Make this work again.
15739 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15741 * attribute.cs (Resolve): Add error 591 detection.
15743 * class.cs (FieldMember.Define): Add error 1547 detection.
15744 (Indexer.Define): Add error 620 detection.
15745 (Operator.Define): Add error 590 detection.
15747 * ecore.cs: Missing argument for error 79.
15749 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15752 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15755 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15758 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15760 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15761 Some operator comments were suppressed.
15762 * doc.cs : Implicit/explicit operator name in doc comments are like
15763 "op_Explicit(type)~returnType", so added suffix handling.
15765 2004-12-07 Martin Baulig <martin@ximian.com>
15768 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15769 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15770 (DeclSpace.ec): New protected field; store the EmitContext here.
15771 (DeclSpace.EmitContext): New public property; moved here from
15773 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15776 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15777 (Enum.Emit): Don't create a new EmitContext.
15779 * delegate.cs (Delegate.DefineType): Always create the
15782 * iterators.cs (Iterators.DefineIterator): Create a new
15783 EmitContext and store it in `ec'.
15785 2004-08-24 Martin Baulig <martin@ximian.com>
15788 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15789 this for accessibility checks.
15790 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15791 IsNestedFamilyAccessible.
15792 (TypeManager.IsSubclassOf): New method, do what the name actually
15795 2004-12-06 Raja R Harinath <rharinath@novell.com>
15797 Fix crash on cs0657-17.cs.
15798 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15799 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15800 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15801 the case where the NamespaceEntry gets overwritten.
15803 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15805 Fixed #69195, #56821
15806 * ecore.cs (ResolveBoolean): Tiny refactoring.
15808 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15809 of right expression resolving when left is false constant and
15810 operator is LogicalAnd OR true constant and operator is LogicalOr.
15812 * statement.cs (ResolveUnreachable): Always reports warning.
15814 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15816 * class.cs: Distinguish between 1721 and 1722 (just a little help
15817 for the programmer).
15819 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15821 * delegate.cs: Only allow this on new versions of the language.
15823 2004-12-02 Duncan Mak <duncan@ximian.com>
15825 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15827 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15828 here as a static method. Take an additional bool out parameter
15829 `must_do_cs1540_check' for signaling to InstanceResolve.
15830 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15831 member field from PropertyExpr class and made it an argument of
15832 the method instead.
15833 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15834 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15835 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15836 and `remove_accessor' as well as InstanceResolve: report CS0122
15841 2004-12-03 Raja R Harinath <rharinath@novell.com>
15843 Fix test-327.cs, test-328.cs, and put in early infrastructure
15844 for eventually fixing #52697.
15845 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15846 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15847 from other methods.
15848 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15849 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15850 (VerifyUsing, error246): Update.
15851 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15852 'NamespaceEntry.LookupNamespaceOrType'.
15854 2004-12-03 Martin Baulig <martin@ximian.com>
15856 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15857 method as our child, call AnonymousMethod.Compatible() on it.
15859 2004-12-03 Raja R Harinath <rharinath@novell.com>
15861 Disable XML documentation support in 'basic' profile.
15862 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15863 Redirect XmlElement to System.Object.
15864 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15865 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15866 * mcs.exe.sources: Add doc-bootstrap.cs.
15867 * doc-bootstrap.cs: New file. Contains empty stub implementation
15870 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15872 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15873 comments are allowed.
15875 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15877 * delegate.cs: Add checks for subtypes in paramaters and return values
15878 in VerifyMethod () to add support for Covariance/Contravariance
15881 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15883 * report.cs: Remove extra closing parenthesis.
15885 * convert.cs (Error_CannotImplicitConversion): If the name of the
15886 types are the same, provide some extra information.
15888 * class.cs (FieldBase): Use an unused bit field from the field to
15889 encode the `has_offset' property from the FieldMember. This saves
15890 a couple of Ks on bootstrap compilation.
15892 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15893 method as our child, return the AnonymousMethod resolved
15896 * expression.cs (New.DoResolve): Allow return values from
15897 NewDelegate to also include AnonymousMethods.
15901 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15904 * attribute.cs (Resolve): Improved implementation of params
15905 attribute arguments.
15907 * support.cs (ParameterData): Add HasParams to be faster.
15909 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15911 all things are for /doc support:
15913 * doc.cs: new file that supports XML documentation generation.
15914 * mcs.exe.sources: added doc.cs.
15916 Handle /doc command line option.
15917 Report error 2006 instead of 5 for missing file name for /doc.
15918 Generate XML documentation when required, after type resolution.
15920 Added support for picking up documentation (/// and /** ... */),
15921 including a new XmlCommentState enumeration.
15923 Added lines to fill Documentation element for field, constant,
15924 property, indexer, method, constructor, destructor, operator, event
15925 and class, struct, interface, delegate, enum.
15926 Added lines to warn incorrect comment.
15928 Added Documentation field (passed only when /doc was specified).
15930 Added DocComment, DocCommentHeader, GenerateDocComment() and
15931 OnGenerateDocComment() and some supporting private members for
15932 /doc feature to MemberCore.
15934 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15936 Added overriden DocCommentHeader.
15938 Added overriden DocCommentHeader and GenerateDocComment().
15940 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15942 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15943 unwrapping the enumeration values, chain to
15944 DoConstantNumericPromotions again, so we can promote things to the
15945 fundamental types (takes care of enums that are bytes, sbytes).
15949 2004-12-01 Raja R Harinath <rharinath@novell.com>
15951 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15952 Fix long-standing bug in type-lookup. Use FindType instead of
15953 LookupType when ec.ResolvingTypeTree.
15954 (Attribute.ResolveType, Attribute.Resolve)
15955 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15957 (Attributes.Search): Remove internal version. Update.
15958 (Attributes.SearchMulti): Update.
15959 (Attributes.GetClsCompliantAttribute): Remove.
15960 (Attributes.GetIndexerNameAttribute): Remove.
15961 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15962 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15963 * class.cs (Indexer.Define): Likewise.
15965 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15968 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15969 MarshallByReference members access.
15971 * expression.cs: Use CheckMarshallByRefAccess;
15972 Better error CS0197 message.
15974 * report.cs: Print whole related error message.
15976 2004-11-30 Raja R Harinath <rharinath@novell.com>
15978 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15979 the current directory to help debugging.
15981 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15983 * class (GetClassBases): Better error 60 report.
15984 (EventProperty): Disabled warning 67 detection.
15986 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15989 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15991 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15994 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15997 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15999 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16001 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16003 * attribute.cs (Attribute.Resolve): Refine error reporting and
16004 report a cs0117 if the identifier does not exist, to distinguish
16005 from 0617 which is a miss-use of the actual identifier.
16007 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16008 between cs0070 and cs0079.
16010 * class.cs (MemberBase.DoDefine): When reporting a wrong
16011 accessibility level, we use MethodCore to compare instead of
16012 Method (this was a regression in some refactoring effort).
16014 So now we correctly report cs0056 again.
16016 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16017 testing the target_type (which was known to be object_type) and
16018 not the source type (which is anonymous_method).
16020 Fixed reporting of error cs1660.
16022 * expression.cs (UserCast.Source): Expose the underlying cast.
16024 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16025 allowed types to find a match to int32 first (most common).
16027 In addition, it ignores any ImplicitUserConversions that did an
16028 internal implicit conversion (as the switch statement allows only
16029 one integral conversion to exist).
16031 * class.cs (PartialContainer.Create): rename `name' to
16032 `member_name' for clarity. Then replace the string calls with a
16033 call to MemberName.GetPartialName, as now using
16034 MemberName.ToString is an error (this is due to the side effects
16035 it had, that were fixed in the past).
16037 This will restore the error reporting on a number of partial class
16038 errors that were missusing this (and getting an exception as a
16039 results, which is now just a plain textual warning, because
16040 yyparse debug output would crash otherwise).
16042 2004-11-26 Raja R Harinath <rharinath@novell.com>
16044 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16046 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16048 * rootcontext.cs (LookupType): Make sure to cache lookups that
16049 don't give us a negative result. This saves about 5% of corlib
16052 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16054 * report.cs (AbstractMessage.Print): messages are sent to stderr
16056 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16057 non-interface in the list of interfaces (at this point, either
16058 parent was properly set, or a base class is being listed in the
16059 interfaces section).
16061 This flags error 1722, and resolves the crash from bug 69259.
16063 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16065 * statement.cs (Using.EmitExpressionFinally): make this work right
16066 for valuetypes. Fixes 69926.
16068 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16070 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16071 converted to an enum" here, before we try to change the underlying
16072 type. This code exists, but it is a different code path than the
16073 one used while encoding constants.
16075 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16076 old bug: when converting from the null literal to a pointer,
16077 return an EmptyCast, not the NullLiteral.
16079 This fixes #69921, the recent null_type changes probably made this
16080 bug more prominent.
16082 (ImplicitReferenceConversionExists): In addition, resynchronized
16083 the code here, so it matches the same code in
16084 ImplicitReferenceConversionExists for the `from any class-type S
16085 to any interface-type T'.
16088 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16090 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16092 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16094 * cs-parser.jay: Use verbosity accordingly.
16096 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16098 * expression.cs (Unary.ResolveOperator): Do not report warning;
16099 AddressOf reads from variable.
16101 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16103 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16107 * attribute.cs (Attributable): Removed CheckTargets.
16108 (Attributes.Emit): Explicit attribute targets are tested here.
16110 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16111 not enabled for interfaces.
16113 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16114 (GetAssemblyName): Ouch next bug there.
16116 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16118 * expression.cs: Error 275 added.
16120 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16122 Fix bug #69177 (Implemented decimal constant support)
16124 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16125 (BinaryFold): Add DecimalConstant.
16127 * const.cs (Define): Decimal constant
16129 (ChangeType): Add decimal type handling.
16130 (LookupConstantValue): Don't set value for decimal type but
16131 emit DecimalConstantAttribute. Needed for constant optimization.
16133 * constant.cs (ToDecimal): New method.
16134 (ConvertToDecimal): New method.
16135 (IntConstant): Implemented ConvertToDecimal.
16136 (DecimalConstant.Emit): Emit optimized version for decimals in
16139 * expression.cs (ResolveOperator): Changed order of constant
16140 reduction to work correctly with native types which have
16141 overloaded operators.
16142 (ResolveMemberAccess): Extract constant value from attribute
16145 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16147 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16148 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16149 (ChangeType): Decimal is special.
16150 (TypeToCoreType): Add decimal type.
16152 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16154 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16157 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16159 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16162 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16164 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16166 * pending.cs (PendingImplementation): Grab only interfaces.
16168 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16170 * statement.cs (ForeachHelperMethods): Add location member and
16171 error 202 detection.
16173 2004-11-19 Raja R Harinath <rharinath@novell.com>
16175 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16176 automatically handled by executable.make.
16177 (PROGRAM): Make profile-specific.
16179 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16181 * expression.cs (DoResolveBase): Fixed wrong warning for out
16184 2004-11-18 Martin Baulig <martin@ximian.com>
16186 Merged latest changes into gmcs. Please keep this comment in
16187 here, it makes it easier for me to see what changed in MCS since
16188 the last time I merged.
16190 2004-11-17 Raja R Harinath <rharinath@novell.com>
16192 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16193 (TypeHandle.GetMemberCache): New.
16194 (TypeHandle.TypeHandle): Update.
16195 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16196 (TypeManager.LookupParentInterfacesCache):
16197 Rename from LookupInterfaceCache. Optimize slightly.
16198 (TypeManager.MemberLookup_FindMembers): Update.
16199 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16200 multi-type variant.
16201 (AddCacheContents): Rename from AddHashtable.
16202 * class.cs (TypeContainer.parent_container): Remove.
16203 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16204 (TypeContainer.DoDefineMembers): Don't initialize it.
16205 Update to name changes.
16207 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16209 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16210 that factors the code to check access modifiers on override.
16212 (PropertyBase): Use the code here.
16214 Patch from Lluis S'anchez, fixes bug #69361.
16216 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16218 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16219 routine that is used to report the use of a captured variable
16220 whose address has been taken.
16222 There are two checks: one when variables are being captured and
16223 the other check is when the address of a variable is taken.
16225 (because an anonymous methods might be resolved before *or* after
16226 the address has been taken) and
16228 * expression.cs (Conditional.DoResolve): Remove the special
16229 casing that Martin added to trueExpr and falseExpr being both
16230 NullLiteral. We get the right behavior now just by introducing
16231 the null_type into the compiler.
16233 * convert.cs (ExplicitConversion): Change the code to use
16234 null_type instead of testing `expr is NullLiteral'.
16235 (ImplicitConversionStandard): use null_type too.
16236 (ImplicitReferenceConversionExists): use null_type too.
16237 (ImplicitReferenceConversion): use null_type too.
16239 * literal.cs: The type of `NullLiteral' is now null_type instead
16241 (Resolve): Set the type here.
16243 * typemanager.cs: Introduce null_type.
16245 2004-11-17 Martin Baulig <martin@ximian.com>
16247 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16248 direction, like FindMembers() does. Fixes #69546, testcase is in
16251 2004-11-16 Martin Baulig <martin@ximian.com>
16253 This is based on a patch from Marek Safar, see bug #69082.
16254 Fixes bugs #63705 and #67130.
16256 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16257 method; create a MemberCache for an interface type and cache the
16260 * decl.cs (IMemberContainer.ParentContainer): Removed.
16261 (IMemberContainer.ParentCache): New property.
16262 (MemberCache.SetupCacheForInterface): Removed.
16263 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16264 to create a cache for an interface's "parent".
16266 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16269 2004-11-16 Martin Baulig <martin@ximian.com>
16271 Merged back from gmcs; these changes already went into gmcs a
16272 couple of weeks ago.
16275 (TypeManager.AddUserType): Removed the `ifaces' argument.
16276 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16278 (TypeManager.AddUserInterface): Removed.
16279 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16281 (TypeManager.GetInterfaces): Likewise.
16282 (TypeManager.GetExplicitInterfaces): Likewise.
16284 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16286 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16287 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16289 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16291 * statement.cs: Avoid adding bools to a hashtable.
16293 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16295 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16296 calling an unsafe method from a safe location.
16298 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16301 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16303 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16305 * namespace.cs (VerifyUsing): use GetPartialName instead of
16308 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16310 * statement.cs (Return.Resolve): Fix regression in typo: if
16311 `in_exc', we have to request a NeedReturnLabel, this was a typo
16312 introduced in the anonymous method check-in. Fixes #69131.
16314 * Indexers were using the ShortName when defining themselves,
16315 causing a regression in the compiler bootstrap when applying the
16316 patch from 2004-11-02 (first part), now they use their full name
16317 and the bug is gone.
16319 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16321 * driver.cs: Strip the path from the names of embedded resources. Fixes
16324 2004-11-04 Raja R Harinath <rharinath@novell.com>
16326 Fix error message regression: cs0104-2.cs.
16327 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16328 (AliasEntry.Resolve): Update.
16329 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16331 (RootContext.LookupType): Update.
16333 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16335 * cs-parser.jay: Add support for handling accessor modifiers
16336 * class: Add support port accessor modifiers and error checking,
16337 define PropertyMethod.Define as virtual (not abstract anymore)
16338 * ecore.cs: Add checking for proeprties access with access modifiers
16339 * iterators.cs: Modify Accessor constructor call based in the modified
16341 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16343 * expression.cs (StringConcat): Handle being called twice,
16344 as when we have a concat in a field init with more than two
16347 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16349 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16350 special case explicit implementations, we should always produce
16351 the .property or .event declaration.
16353 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16354 since it will not return correct data if people use this
16355 unresolved in the presence of using statements (see test-313).
16357 * class.cs (MethodData.Define): If we are an explicit interface
16358 implementation, set the method name to the full name of the
16359 interface plus the name of the method.
16361 Notice that using the method.MethodName.GetFullName() does not
16362 work, as it will only contain the name as declared on the source
16363 file (it can be a shorthand in the presence of using statements)
16364 and not the fully qualifed type name, for example:
16368 class D : ICloneable {
16369 object ICloneable.Clone () {
16373 Would produce a method called `ICloneable.Clone' instead of
16374 `System.ICloneable.Clone'.
16376 * namespace.cs (Alias.Resolve): Use GetPartialName.
16378 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16380 * cs-parser.jay: Add error 1055 report.
16382 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16384 * assign.cs (Assign.DoResolve): Only do the transform of
16385 assignment into a New if the types are compatible, if not, fall
16386 through and let the implicit code deal with the errors and with
16387 the necessary conversions.
16389 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16391 * cs-parser.jay: Add error 1031 report.
16393 * cs-tokenizer.cs: Add location for error 1038.
16395 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16397 * cs-parser.jay: Add error 1016 report.
16399 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16401 * cs-parser.jay: Add errors 1575,1611 report.
16403 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16405 * cs-parser.jay: Add error 1001 report.
16407 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16410 * attribute.cs (GetMarshal): Add method argument for
16411 caller identification.
16413 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16414 agument for GetMarshal and RuntimeMissingSupport.
16416 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16418 * attribute.cs (ExtractSecurityPermissionSet): Removed
16419 TypeManager.code_access_permission_type.
16421 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16423 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16425 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16426 for obsolete use of a variable here. Fixes regression on errors
16427 cs0619-25 and cs0619-26.
16429 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16431 Fix #62358, implemented security attribute encoding.
16433 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16434 Tests permitted SecurityAction for assembly or other types.
16435 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16436 data from SecurityPermissionAttribute to PermisionSet class.
16438 * class.cs (ApplyAttributeBuilder): Added special handling
16439 for System.Security.Permissions.SecurityAttribute based types.
16441 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16442 special handling for System.Security.Permissions.SecurityAttribute
16445 * enum.cs (ApplyAttributeBuilder): Added special handling
16446 for System.Security.Permissions.SecurityAttribute based types.
16448 * parameter.cs (ApplyAttributeBuilder): Added special handling
16449 for System.Security.Permissions.SecurityAttribute based types.
16451 * rootcontext.cs: Next 2 core types.
16453 * typemanager.cs (TypeManager.security_permission_attr_type):
16454 Built in type for the SecurityPermission Attribute.
16455 (code_access_permission_type): Build in type.
16457 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16459 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16460 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16461 all of this information into
16462 EmitContext.EmitCapturedVariableInstance.
16464 * codegen.cs (EmitCapturedVariableInstance): move here the
16465 funcionality of emitting an ldarg.0 in the presence of a
16466 remapping. This centralizes the instance emit code.
16468 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16469 then emit a load of this: it means that we have reached the
16470 topmost ScopeInfo: the one that contains the pointer to the
16471 instance of the class hosting the anonymous method.
16473 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16474 captures to the topmost CaptureContext.
16476 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16478 * expression.cs (LocalVariableReference): Move the knowledge about
16479 the iterators into codegen's EmitCapturedVariableInstance.
16481 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16483 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16484 all code paths return a value from an anonymous method (it is the
16485 same as the 161 error, but for anonymous methods).
16487 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16489 The introduction of anonymous methods in the compiler changed
16490 various ways of doing things in the compiler. The most
16491 significant one is the hard split between the resolution phase
16492 and the emission phases of the compiler.
16494 For instance, routines that referenced local variables no
16495 longer can safely create temporary variables during the
16496 resolution phase: they must do so from the emission phase,
16497 since the variable might have been "captured", hence access to
16498 it can not be done with the local-variable operations from the runtime.
16502 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16503 is a toplevel block.
16505 (ToplevelBlock): A new kind of Block, these are the blocks that
16506 are created by the parser for all toplevel method bodies. These
16507 include methods, accessors and anonymous methods.
16509 These contain some extra information not found in regular blocks:
16510 A pointer to an optional CaptureContext (for tracking captured
16511 local variables and parameters). A pointer to the parent
16514 (Return.Resolve): Catch missmatches when returning a value from an
16515 anonymous method (error 1662).
16516 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16519 (Break.Resolve): ditto.
16521 (SwitchLabel): instead of defining the labels during the
16522 resolution phase, we now turned the public ILLabel and ILLabelCode
16523 labels into methods called GetILLabelCode() and GetILLabel() that
16524 only define the label during the Emit phase.
16526 (GotoCase): Track the SwitchLabel instead of the computed label
16527 (its contained therein). Emit the code by using
16528 SwitchLabel.GetILLabelCode ().
16530 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16531 whether the Local has been captured or not.
16533 (LocalInfo.IsCaptured): New property, used to tell whether the
16534 local has been captured.
16536 * anonymous.cs: Vastly updated to contain the anonymous method
16539 The main classes here are: CaptureContext which tracks any
16540 captured information for a toplevel block and ScopeInfo used to
16541 track the activation frames for various local variables.
16543 Each toplevel block has an optional capture context associated
16544 with it. When a method contains an anonymous method both the
16545 toplevel method and the anonymous method will create a capture
16546 context. When variables or parameters are captured, they are
16547 recorded on the CaptureContext that owns them, for example:
16551 MyDelegate d = delegate {
16556 Here `a' will be recorded as captured on the toplevel
16557 CapturedContext, the inner captured context will not have anything
16558 (it will only have data if local variables or parameters from it
16559 are captured in a nested anonymous method.
16561 The ScopeInfo is used to track the activation frames for local
16562 variables, for example:
16564 for (int i = 0; i < 10; i++)
16565 for (int j = 0; j < 10; j++){
16566 MyDelegate d = delegate {
16571 At runtime this captures a single captured variable `i', but it
16572 captures 10 different versions of the variable `j'. The variable
16573 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16574 recorded on a child.
16576 The toplevel ScopeInfo will also track information like the `this'
16577 pointer if instance variables were referenced (this is necessary
16578 as the anonymous method lives inside a nested class in the host
16579 type of the method).
16581 (AnonymousMethod): Expanded to track the Toplevel, implement
16582 `AnonymousMethod.Compatible' to tell whether an anonymous method
16583 can be converted to a target delegate type.
16585 The routine now also produces the anonymous method content
16587 (AnonymousDelegate): A helper class that derives from
16588 DelegateCreation, this is used to generate the code necessary to
16589 produce the delegate for the anonymous method that was created.
16591 * assign.cs: API adjustments for new changes in
16592 Convert.ImplicitStandardConversionExists.
16594 * class.cs: Adjustments to cope with the fact that now toplevel
16595 blocks are of type `ToplevelBlock'.
16597 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16598 insteda of standard blocks.
16600 Flag errors if params arguments are passed to anonymous methods.
16602 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16603 `CurrentAnonymousMethod' which points to the current Anonymous
16604 Method. The variable points to the AnonymousMethod class that
16605 holds the code being compiled. It is set in the new EmitContext
16606 created for the anonymous method.
16608 (EmitContext.Phase): Introduce a variable and an enumeration to
16609 assist in enforcing some rules about when and where we are allowed
16610 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16611 only one that enfonces this right now).
16613 (EmitContext.HaveCaptureInfo): new helper method that returns
16614 whether we have a CapturedContext initialized.
16616 (EmitContext.CaptureVariable): New method used to register that a
16617 LocalInfo must be flagged for capturing.
16619 (EmitContext.CapturedParameter): New method used to register that a
16620 parameters must be flagged for capturing.
16622 (EmitContext.CapturedField): New method used to register that a
16623 field must be flagged for capturing.
16625 (EmitContext.HaveCapturedVariables,
16626 EmitContext.HaveCapturedFields): Return whether there are captured
16627 variables or fields.
16629 (EmitContext.EmitMethodHostInstance): This is used to emit the
16630 instance for the anonymous method. The instance might be null
16631 (static methods), this (for anonymous methods that capture nothing
16632 and happen to live side-by-side with the current method body) or a
16633 more complicated expression if the method has a CaptureContext.
16635 (EmitContext.EmitTopBlock): Routine that drives the emission of
16636 code: it will first resolve the top block, then emit any metadata
16637 and then emit the code. The split is done so that we can extract
16638 any anonymous methods and flag any captured variables/parameters.
16640 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16641 during this phase, the ILGenerator should not be used as labels
16642 and local variables declared here might not be accessible to any
16643 code that is part of an anonymous method.
16645 Exceptions to this include the temporary variables that are
16646 created by some statements internally for holding temporary
16649 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16652 (EmitContext.TemporaryReturn): This method is typically called
16653 from the Emit phase, and its the only place where we allow the
16654 ReturnLabel to be defined other than the EmitMeta. The reason is
16655 that otherwise we would have to duplicate a lot of logic in the
16656 Resolve phases of various methods that today is on the Emit
16659 (EmitContext.NeedReturnLabel): This no longer creates the label,
16660 as the ILGenerator is not valid during the resolve phase.
16662 (EmitContext.EmitThis): Extended the knowledge in this class to
16663 work in anonymous methods in addition to iterators.
16665 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16666 code is necessary on the stack to access the instance to a local
16667 variable (the variable will be accessed as a field).
16669 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16670 EmitContext.EmitAddressOfParameter): Routines to support
16671 parameters (not completed at this point).
16673 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16674 will also remove the parameters.
16676 * convert.cs (Convert): Define a `ConstantEC' which points to a
16677 null. This is just to prefity some code that uses
16678 ImplicitStandardConversion code and do not have an EmitContext
16681 The idea is to flag explicitly that at that point in time, it is
16682 known that the conversion will not trigger the delegate checking
16683 code in implicit conversions (which requires a valid
16686 Everywhere: pass new EmitContext parameter since
16687 ImplicitStandardConversionExists now requires it to check for
16688 anonymous method conversions.
16690 (Convert.ImplicitStandardConversionExists): If the type of an
16691 expression is the anonymous_method_type, and the type is a
16692 delegate, we invoke the AnonymousMethod.Compatible method to check
16693 whether an implicit conversion is possible.
16695 (Convert.ImplicitConversionStandard): Only do implicit method
16696 group conversions if the language level is not ISO_1.
16698 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16699 MethodInfo for the Invoke method. used by Delegate and
16702 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16703 method conversions if the target type is a delegate.
16705 Removed extra debugging nops.
16707 (LocalVariableReference): Turn the `local_info' into a public
16710 Add `prepared' field, the same hack used for FieldExprs to cope
16711 with composed assignments, as Local variables do not necessarily
16712 operate purely on the stack as they used to: they can be captured
16715 Add `temp' for a temporary result, like fields.
16717 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16719 It now copes with Local variables that are captured and emits the
16720 proper instance variable to load it from a field in the captured
16723 (ParameterReference.DoResolveBase): During the resolve phase,
16724 capture parameters if we are in an anonymous method.
16726 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16727 anonymous method, use the EmitContext helper routines to emit the
16728 parameter reference.
16730 * iterators.cs: Set RemapToProxy to true/false during the
16733 * parameters.cs (GetParameterByName): New helper method.
16735 * typemanager.cs (anonymous_method_type) a new type that
16736 represents an anonyous method. This is always an internal type,
16737 used as a fencepost to test against the anonymous-methodness of an
16740 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16742 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16744 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16746 2004-10-18 Martin Baulig <martin@ximian.com>
16748 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16749 `Type' directly, but call ResolveType() on it.
16750 (Catch.Resolve): Likewise.
16751 (Foreach.Resolve): Likewise.
16753 2004-10-18 Martin Baulig <martin@ximian.com>
16755 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16756 `Type' directly, but call ResolveType() on it.
16757 (Probe.DoResolve): Likewise.
16758 (ArrayCreation.LookupType): Likewise.
16759 (TypeOf.DoResolve): Likewise.
16760 (SizeOf.DoResolve): Likewise.
16762 2004-10-18 Martin Baulig <martin@ximian.com>
16764 * expression.cs (Invocation.BetterFunction): Put back
16765 TypeManager.TypeToCoreType().
16767 2004-10-18 Raja R Harinath <rharinath@novell.com>
16769 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16772 2004-10-18 Martin Baulig <martin@ximian.com>
16774 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16775 `Type' directly, but call ResolveType() on it.
16777 2004-10-18 Martin Baulig <martin@ximian.com>
16779 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16780 `Type' directly, but call ResolveType() on it.
16781 (MemberBase.DoDefine): Likewise.
16783 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16784 `Type' directly, but call ResolveType() on it.
16785 (ComposedCast.DoResolveAsTypeStep): Likewise.
16787 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16788 `Type' directly, but call ResolveType() on it.
16790 2004-10-17 John Luke <john.luke@gmail.com>
16792 * class.cs (Operator.GetSignatureForError): use CSharpName
16794 * parameter.cs (Parameter.GetSignatureForError): Returns
16795 correct name even if was not defined.
16797 2004-10-13 Raja R Harinath <rharinath@novell.com>
16800 * class.cs (TypeContainer.EmitContext): New property.
16801 (DefineNestedTypes): Create an emitcontext for each part.
16802 (MethodCore.DoDefineParameters): Use container's emitcontext.
16803 Pass type array to InternalParameters.
16804 (MemberBase.DoDefine): Use container's emitcontext.
16805 (FieldMember.Define): Likewise.
16806 (Event.Define): Likewise.
16807 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16808 Pass type array to InternalParameters.
16809 (SetIndexerMethod.GetParameterInfo): Likewise.
16810 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16811 * delegate.cs (Define): Pass emitcontext to
16812 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16813 array to InternalParameters.
16814 * expression.cs (ParameterReference.DoResolveBase): Pass
16815 emitcontext to GetParameterInfo.
16816 (ComposedCast.DoResolveAsTypeStep): Remove check on
16817 ec.ResolvingTypeTree.
16818 * parameter.cs (Parameter.Resolve): Change argument to
16819 EmitContext. Use ResolveAsTypeTerminal.
16820 (Parameter.GetSignature): Change argument to EmitContext.
16821 (Parameters.ComputeSignature): Likewise.
16822 (Parameters.ComputeParameterTypes): Likewise.
16823 (Parameters.GetParameterInfo): Likewise.
16824 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16825 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16826 * support.cs (InternalParameters..ctor): Remove variant that takes
16828 * typemanager.cs (system_intptr_expr): New.
16829 (InitExpressionTypes): Initialize it.
16831 2004-10-12 Chris Toshok <toshok@ximian.com>
16833 * cs-parser.jay: fix location for try_statement and catch_clause.
16835 2004-10-11 Martin Baulig <martin@ximian.com>
16837 * report.cs: Don't make --fatal abort on warnings, we have
16838 -warnaserror for that.
16840 2004-10-07 Raja R Harinath <rharinath@novell.com>
16842 More DeclSpace.ResolveType avoidance.
16843 * decl.cs (MemberCore.InUnsafe): New property.
16844 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16845 with newly created EmitContext.
16846 (FieldMember.Define): Likewise.
16847 * delegate.cs (Delegate.Define): Likewise.
16848 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16849 only if normal name-lookup fails.
16850 (TypeExpr.DoResolve): Enable error-checking.
16851 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16852 (SizeOf.DoResolve): Likewise.
16853 (ComposedCast.DoResolveAsTypeStep): Likewise.
16854 (StackAlloc.DoResolve): Likewise.
16855 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16856 (Block.Unsafe): New property.
16857 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16858 (Unsafe): Set 'unsafe' flag of contained block.
16859 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16860 (Fixed.Resolve): Likewise.
16861 (Catch.Resolve): Likewise.
16862 (Using.ResolveLocalVariableDecls): Likewise.
16863 (Foreach.Resolve): Likewise.
16865 2004-10-05 John Luke <john.luke@gmail.com>
16867 * cs-parser.jay: add location to error CS0175
16869 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16871 * ecore.cs (Expression.Constantity): Add support for turning null
16874 * const.cs (Const.Define): Allow constants to be reference types
16875 as long as the value is Null.
16877 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16879 * namespace.cs (NamespaceEntry.Using): No matter which warning
16880 level is set, check if this namespace name has already been added.
16882 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16884 * expression.cs: reftype [!=]= null should always use br[true,false].
16887 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16890 * attribute.cs: Enum conversion moved to
16891 GetAttributeArgumentExpression to be applied to the all
16894 2004-10-01 Raja R Harinath <rharinath@novell.com>
16896 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16897 * class.c (TypeContainer.DefineType): Flag error if
16898 base types aren't accessible due to access permissions.
16899 * decl.cs (DeclSpace.ResolveType): Move logic to
16900 Expression.ResolveAsTypeTerminal.
16901 (DeclSpace.ResolveTypeExpr): Thin layer over
16902 Expression.ResolveAsTypeTerminal.
16903 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16904 Refactor code into NestedAccess. Use it.
16905 (DeclSpace.NestedAccess): New.
16906 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16907 argument to silence errors. Check access permissions.
16908 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16909 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16910 (Cast.DoResolve): Likewise.
16911 (New.DoResolve): Likewise.
16912 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16913 (TypeOf.DoResolve): Likewise.
16915 * expression.cs (Invocation.BetterConversion): Return the Type of
16916 the better conversion. Implement section 14.4.2.3 more faithfully.
16917 (Invocation.BetterFunction): Make boolean. Make correspondence to
16918 section 14.4.2.2 explicit.
16919 (Invocation.OverloadResolve): Update.
16920 (Invocation): Remove is_base field.
16921 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16922 (Invocation.Emit): Likewise.
16924 2004-09-27 Raja R Harinath <rharinath@novell.com>
16926 * README: Update to changes.
16928 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16930 * cs-parser.jay: Reverted 642 warning fix.
16932 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16935 * decl.cs (FindMemberWithSameName): Indexer can have more than
16938 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16940 * expression.cs (LocalVariableReference.DoResolveLValue):
16941 Do not report warning 219 for out values.
16942 (EmptyExpression.Null): New member to avoid extra allocations.
16944 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16946 * cs-parser.jay: Fix wrong warning 642 report.
16948 * cs-tokenizer.cs (CheckNextToken): New helper;
16949 Inspect next character if is same as expected.
16951 2004-09-23 Martin Baulig <martin@ximian.com>
16953 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16954 (Convert.ImplicitReferenceConversionExists): Likewise.
16956 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16958 * class.cs (Operator.Define): Add error 448 and 559 report.
16960 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16962 * class.cs (MemberBase.IsTypePermitted): New protected
16963 method for checking error CS0610.
16965 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16967 * class.cs (TypeContainer.HasExplicitLayout): New property
16968 Returns whether container has StructLayout attribute set Explicit.
16969 (FieldMember): New abstract class for consts and fields.
16970 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16971 (Field): Reuse FieldMember.
16973 * const.cs (Const): Reuse FieldMember.
16975 * rootcontext.cs: EmitConstants call moved to class.
16977 2004-09-22 Martin Baulig <martin@ximian.com>
16979 Thanks to Peter Sestoft for this bug report.
16981 * expression.cs (Conditional): If both the `trueExpr' and the
16982 `falseExpr' is a NullLiteral, return a NullLiteral.
16984 2004-09-22 Martin Baulig <martin@ximian.com>
16986 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16987 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16988 for the "get_Current" call.
16990 2004-09-22 Martin Baulig <martin@ximian.com>
16992 Marek and me just fixed one of our oldest bugs: #28562 :-)
16994 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16996 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16997 we're an EnumConstant, just return that.
16998 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16999 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17000 to get the value which'll actually be written into the attribute.
17001 However, we have to use GetValue() to access the attribute's value
17004 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17006 * constant.cs (Constant.IsNegative): New abstract property
17009 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17010 (StackAlloc.DoResolve): Reused IsNegative.
17012 2004-09-21 Martin Baulig <martin@ximian.com>
17014 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17015 if we're used in an iterator, we may be called from different
17018 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17019 we actually have an exception block.
17021 2004-09-20 John Luke <jluke@cfl.rr.com>
17023 * class.cs, cs-parser.jay: Improve the error report for 1520:
17024 report the actual line where the error happens, not where the
17025 class was declared.
17027 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17028 Pass location information that was available elsewhere.
17030 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17032 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17033 runtime to delay sign assemblies.
17035 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17037 * cs-parser.jay: Do not report the stack trace, this is barely
17040 2004-08-22 John Luke <john.luke@gmail.com>
17042 * driver.cs : check that a resource id is not already used
17043 before adding it, report CS1508 if it is, bug #63637
17045 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17047 * ecore.cs: Removed dead code.
17049 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17051 * class.cs: Do not report warning CS0067 on the interfaces.
17053 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17055 * cs-parser.jay: Add error 504 report.
17057 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17059 * rootcontext.cs: WarningLevel is 4 by default now.
17061 * statement.cs (Fixed.Resolve): Do not null
17064 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17067 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17068 deep search when property is not virtual.
17069 (PropertyExpr.ResolveAccessors): Make one call for both
17072 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17075 * statement.cs: Error 152 report constains also location.
17077 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17080 * const.cs: Explicitly set constant as static.
17082 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17085 * cs-parser.jay: Add error 1017 report.
17087 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17089 Fixed bug #59980, #64224
17090 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17092 * typemanager.cs (IsSpecialMethod): Simplified
17094 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17096 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17097 condition with better params.
17099 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17102 * attribute.cs (Resolve): Property has to have both
17105 2004-09-14 Martin Baulig <martin@ximian.com>
17107 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17109 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17112 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17113 called and is obsolete then this member suppress message
17114 when call is inside next [Obsolete] method or type.
17116 * expression.cs: Use TestObsoleteMethodUsage member.
17118 2004-09-14 Martin Baulig <martin@ximian.com>
17120 * cs-parser.jay: Sync a bit with the GMCS version.
17122 2004-09-14 Martin Baulig <martin@ximian.com>
17124 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17125 (CSharpParser.yacc_verbose_flag): New public field.
17127 * genericparser.cs: Removed.
17129 2004-09-14 Raja R Harinath <rharinath@novell.com>
17131 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17133 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17135 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17137 2004-09-10 Martin Baulig <martin@ximian.com>
17139 Backported my MemberName changes from GMCS into MCS.
17141 - we are now using a special `MemberName' class instead of using
17142 strings; in GMCS, the `MemberName' also contains the type
17145 - changed the grammar rules a bit:
17146 * the old `member_name' is now a `namespace_or_type_name':
17147 The rule is that we use `namespace_or_type_name' everywhere
17148 where we expect either a "member name" (GetEnumerator) or a
17149 "member name" with an explicit interface name
17150 (IEnumerable.GetEnumerator).
17151 In GMCS, the explicit interface name may include type arguments
17152 (IEnumerable<T>.GetEnumerator).
17153 * we use `member_name' instead of just `IDENTIFIER' for
17155 The rule is that we use `member_name' wherever a member may
17156 have type parameters in GMCS.
17158 * decl.cs (MemberName): New public class.
17159 (MemberCore.MemberName): New public readonly field.
17160 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17161 (DeclSpace): Likewise.
17163 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17164 * enum.cs (Enum.ctor): Likewise.
17166 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17168 (AliasEntry.ctor): Take a MemberName, not an Expression.
17169 (AliasEntry.UsingAlias): Likewise.
17171 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17172 (IMethodData.MemberName): Changed type from string to MemberName.
17173 (MemberBase.ExplicitInterfaceName): Likewise.
17174 (AbstractPropertyEventMethod.SetupName): Make this private.
17175 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17176 argument; compute the member name here.
17177 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17178 on the `member.MemberName' and the `prefix'.
17180 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17182 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17183 thus, we get a `MemberName' instead of a `string'. These
17184 declarations may have type parameters in GMCS.
17185 (interface_method_declaration, delegate_declaration): Likewise.
17186 (class_declaration, interface_declaration): Likewise.
17187 (method_header): Use `namespace_or_type_name' instead of
17188 `member_name'. We may be an explicit interface implementation.
17189 (property_declaration, event_declaration): Likewise.
17190 (member_name): This is now just an `IDENTIFIER', not a
17191 `namespace_or_type_name'.
17192 (type_name, interface_type): Removed.
17193 (namespace_or_type_name): Return a MemberName, not an Expression.
17194 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17195 call GetTypeExpression() on the MemberName to get an expression.
17196 (IndexerDeclaration.interface_type): Changed type from string to
17198 (MakeName): Operate on MemberName's instead of string's.
17200 2004-09-13 Raja R Harinath <rharinath@novell.com>
17203 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17204 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17205 lookup to avoid symbols introduced by 'using'.
17206 * rootcontext.cs (NamespaceLookup): Update.
17208 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17210 * class.cs (TypeContainer.DoDefineMembers): Do not call
17211 DefineDefaultConstructor for static classes.
17213 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17215 * attribute.cs (Attribute.Resolve): Add error 653 report.
17217 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17219 (Method.ApplyAttributeBuilder): Add error 685 report.
17220 (Operator.Define): Add error 564 report.
17222 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17224 * expression.cs (Invocation.DoResolve): Add error
17225 245 and 250 report.
17227 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17230 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17232 * class.cs (ConstructorInitializer.Resolve):
17233 Wrong error number (515->516).
17235 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17237 * class.cs (Indexer.Define): Add error 631 report.
17239 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17241 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17243 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17245 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17247 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17249 * cs-parser.jay: Added error CS0241 report.
17251 2004-09-10 Raja R Harinath <rharinath@novell.com>
17253 * cs-parser.jay (fixed_statement): Introduce a scope for the
17254 declaration in the 'fixed' statement.
17256 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17258 * cs-parser.jay: Added CS0230 error report.
17260 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17262 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17264 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17266 * expression.cs (Argument.Resolve): Added error CS0192 and
17269 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17271 C# 2.0 #pragma warning feature
17273 * cs-tokenizer.cs (PreProcessPragma): New method;
17274 Handles #pragma directive.
17276 * report.cs (WarningRegions): New class; Support
17277 class for #pragma warning directive. It tests whether
17278 warning is enabled for a given line.
17280 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17282 * const.cs: Add more descriptive error report, tahnks to
17285 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17287 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17289 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17291 * expression.cs: Apply patch from Ben: Remove dead code from
17292 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17293 as that code just threw an exception anwyays.
17295 * const.cs: Remove the call to the turnintoconstant, for details
17298 * literal.cs: The type of the null-literal is the null type; So
17299 we use a placeholder type (literal.cs:System.Null, defined here)
17302 * expression.cs (Conditional.DoResolve): Remove some old code that
17303 is no longer needed, conversions have been fixed.
17305 (ArrayCreationExpression.DoResolve): Return false if we fail to
17306 resolve the inner expression.
17308 2004-09-07 Raja R Harinath <rharinath@novell.com>
17311 * cs-parser.jay (delegate_declaration): Record a delegate
17312 declaration as a type declaration.
17313 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17315 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17317 * parameter.cs: Do not crash if the type can not be resolved.
17319 * expression.cs: Report errors with unsafe pointers, fixes #64896
17321 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17323 * expression.cs: Pointer arith always needs to do a conv.i
17324 if the operand is a long. fix 65320
17326 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17328 Fixed cs0619-37.cs, cs0619-38.cs
17330 * enum.cs (GetObsoleteAttribute): Removed.
17332 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17333 on Enum member is double staged. The first is tested member
17336 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17338 Fixed #56986, #63631, #65231
17340 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17341 adds member to name container.
17342 (TypeContainer.AddToTypeContainer): New method, adds type to
17344 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17345 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17346 AddOperator): Simplified by reusing AddToMemberContainer.
17347 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17349 (Method.CheckForDuplications): Fixed implementation to test all
17351 (MemberBase): Detection whether member is explicit interface
17352 implementation is now in constructor.
17353 (MemberBase.UpdateMemberName): Handles IndexerName.
17354 (Accessor): Changed to keep also location information.
17355 (AbstractPropertyEventMethod): Is derived from MemberCore.
17356 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17357 will be emited or not.
17358 (PropertyBase.AreAccessorsDuplicateImplementation):
17359 Tests whether accessors are not in collision with some method.
17360 (Operator): Is derived from MethodCore to simplify common
17363 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17365 (DeclSpace.AddToContainer): Adds the member to defined_names
17366 table. It tests for duplications and enclosing name conflicts.
17368 * enum.cs (EnumMember): Clean up to reuse the base structures
17370 2004-09-03 Martin Baulig <martin@ximian.com>
17372 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17373 into TypeContainer, to make partial classes work again.
17375 2004-09-03 Martin Baulig <martin@ximian.com>
17377 * rootcontext.cs (RootContext.V2): Removed.
17379 2004-03-23 Martin Baulig <martin@ximian.com>
17381 * expression.cs (Invocation.OverloadResolve): Added `bool
17382 may_fail' argument and use it instead of the Location.IsNull() hack.
17384 2004-09-03 Martin Baulig <martin@ximian.com>
17386 Merged latest changes into gmcs. Please keep this comment in
17387 here, it makes it easier for me to see what changed in MCS since
17388 the last time I merged.
17390 2004-09-03 Raja R Harinath <rharinath@novell.com>
17393 * expression.cs (BetterConversion): Don't allow either conversion
17394 to be null. Remove redundant implicit conversion test when 'q ==
17395 null' -- when this function is invoked, we already know that the
17396 implicit conversion exists.
17397 (BetterFunction): Assume that 'best' is non-null. Remove
17398 redundant reimplementation of IsApplicable when 'best' is null.
17399 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17400 number of arguments.
17401 (IsAncestralType): Extract from OverloadResolve.
17402 (OverloadResolve): Make robust to the MethodGroupExpr being
17403 unsorted. Implement all the logic of Section 14.5.5.1, and
17404 support overloading of methods from multiple applicable types.
17405 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17407 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17408 (RealError, Warning): Append type of report to related symbol.
17410 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17412 * enum.cs: Fixed CLS-Compliance checks for enum members.
17413 Error tests cs3008-8.cs, cs3014-8.cs
17415 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17417 Fixed bug #62342, #63102
17418 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17419 like ImplementMethod.
17421 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17423 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17426 2004-09-02 Martin Baulig <martin@ximian.com>
17428 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17429 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17432 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17434 C# 2.0 Static classes implemented
17436 * class.cs (TypeContainer): instance_constructors,
17437 initialized_fields, initialized_static_fields,
17438 default_constructor, base_inteface_types are protected to be
17439 accessible from StaticClass.
17440 (TypeContainer.DefineDefaultConstructor): New virtual method
17441 for custom default constructor generating
17442 (StaticClass): New class to handle "Static classes" feature.
17444 * cs-parser.jay: Handle static keyword on class like instance
17447 * driver.cs: Added "/langversion" command line switch with two
17448 options (iso-1, default).
17450 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17452 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17454 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17456 * delegate.cs: Style.
17458 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17460 * delegate.cs: Add seperate instance expr field for miguel.
17462 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17464 * PointerArithmetic (Resolve): make sure we are not doing
17465 pointer arith on void*. Also, make sure we are resolved
17466 by not setting eclass until resolve.
17468 All callers: Make sure that PointerArithmetic gets resolved.
17470 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17472 * ArrayCreation (LookupType): If the type does not resolve
17473 to an array, give an error.
17475 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17477 * statement.cs (Try.Resolve): Fixed bug #64222
17479 2004-08-27 Martin Baulig <martin@ximian.com>
17482 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17485 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17487 * ecore.cs (Constantify): Get underlying type via
17488 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17489 Windows in special cases.
17491 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17493 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17494 for obtaining also private methods.
17495 (GetRemoveMethod): Used GetRemoveMethod (true)
17496 for obtaining also private methods.
17498 2004-08-24 Martin Baulig <martin@ximian.com>
17500 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17501 MethodAttributes.HideBySig for operators.
17503 2004-08-23 Martin Baulig <martin@ximian.com>
17505 Back to the old error reporting system :-)
17507 * report.cs (Message): Removed.
17508 (Report.MessageData, ErrorData, WarningData): Removed.
17509 (Report.Error, Warning): Back to the old system.
17511 2004-08-23 Martin Baulig <martin@ximian.com>
17513 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17515 * class.cs (TypeContainer.ParentContainer): New public virtual
17516 method; replaces the explicit interface implementation.
17517 (ClassPart.ParentContainer): Override.
17519 2004-08-23 Martin Baulig <martin@ximian.com>
17521 * statement.cs (Switch): Added support for constant switches; see
17522 #59428 or test-285.cs.
17524 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17527 * statement.cs (GetEnumeratorFilter): Removed useless
17528 logic because C# specs is strict. GetEnumerator must be
17531 2004-08-22 Martin Baulig <martin@ximian.com>
17533 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17534 a switch and may break, reset the barrier. Fixes #59867.
17536 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17538 CLS-Compliance speed up (~5% for corlib)
17540 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17541 New method. Tests container for CLS-Compliant names
17543 * class.cs (TypeContainer.VerifyClsName): New method.
17544 Checks whether container name is CLS Compliant.
17545 (Constructor): Implements IMethodData.
17547 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17548 low-case table for CLS Compliance test.
17549 (MemberCache.VerifyClsParameterConflict): New method.
17550 Checks method parameters for CS3006 error.
17552 * enum.cs (EnumMember): Is derived from MemberCore.
17553 (Enum.VerifyClsName): Optimized for better performance.
17555 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17557 * report.cs: Renamed Error_T to Error and changed all
17560 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17562 * class.cs (TypeContainer.IndexerArrayList): New inner class
17563 container for indexers.
17564 (TypeContainer.DefaultIndexerName): New constant for default
17565 indexer name. Replaced all "Item" with this constant.
17566 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17568 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17569 DefaultMemberAttribute constructor.
17571 2004-08-05 Martin Baulig <martin@ximian.com>
17573 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17576 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17578 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17579 multi platforms problem.
17581 * compiler.csproj: Included shared files.
17583 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17585 Fix bug 60333, 55971 in the more general way
17586 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17587 Added arg_type argument for constant conversion.
17588 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17590 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17593 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17594 OperatorArrayList, MethodCoreArrayList for typecontainer
17595 containers. Changed class member types to these new types.
17596 (MethodArrayList.DefineMembers): Added test for CS0659.
17598 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17600 * cfold.cs: Synchronize the folding with the code in expression.cs
17601 Binary.DoNumericPromotions for uint operands.
17603 * attribute.cs: Revert patch from Raja, it introduced a regression
17604 while building Blam-1.2.1 (hard to isolate a test case).
17606 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17610 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17612 (MethodCore.parent_method): New member. The method we're overriding
17613 if this is an override method.
17614 (MethodCore.CheckBase): Moved from Method class and made common.
17615 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17617 (MethodCore.CheckForDuplications): New abstract method. For custom
17618 member duplication search in a container
17619 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17620 method and its return type.
17621 (Event.conflict_symbol): New member. Symbol with same name in the
17625 (MemberCache.FindMemberWithSameName): New method. The method
17626 is looking for conflict with inherited symbols.
17628 2004-08-04 Martin Baulig <martin@ximian.com>
17630 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17632 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17634 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17636 * report.cs (Message): New enum for better error, warning reference in
17638 (MessageData): New inner abstract class. It generally handles printing of
17639 error and warning messages.
17640 Removed unused Error, Warning, Message methods.
17642 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17644 Fix for cs0592-8.cs test
17646 (Attributable.ValidAttributeTargets): Made public.
17647 (Attribute.ExplicitTarget): New member for explicit target value.
17648 (Attribute.CheckTargets): Now we translate explicit attribute
17649 target to Target here.
17651 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17653 * ecore.cs (MethodGroupExpr): new IsBase property.
17655 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17657 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17658 rather than an instance expr.
17660 (DelegateCreation.Emit): Use the method group rather than
17661 the instance expression. Also, if you have base.Foo as the
17662 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17664 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17666 (NewDelegate.DoResolve): Only check for the existance of Invoke
17667 if the method is going to be needed. Use MethodGroupExpr.
17669 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17671 * expression.cs: For pointer arith., make sure to use
17672 the size of the type, not the size of the pointer to
17675 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17678 * class.cs (Class): Added error CS0502 test.
17680 2004-08-03 John Luke <jluke@cfl.rr.com>
17681 Raja R Harinath <rharinath@novell.com>
17684 * attribute.cs (Attribute.complained_before): New flag.
17685 (Attribute.ResolveType, Attribute.Resolve),
17686 (Attribute.DefinePInvokeMethod): Set it.
17687 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17689 2004-08-03 Martin Baulig <martin@ximian.com>
17691 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17692 use a user-defined operator; we still need to do numeric
17693 promotions in case one argument is a builtin type and the other
17694 one has an implicit conversion to that type. Fixes #62322.
17696 2004-08-02 Martin Baulig <martin@ximian.com>
17698 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17699 (LocalInfo.IsThis): New public property.
17700 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17702 2004-08-01 Martin Baulig <martin@ximian.com>
17704 * class.cs (TypeContainer.GetClassBases): Don't set the default
17705 here since we may get called from GetPartialBases().
17706 (TypeContainer.DefineType): If GetClassBases() didn't return a
17707 parent, use the default one.
17709 2004-07-30 Duncan Mak <duncan@ximian.com>
17711 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17713 2004-07-30 Martin Baulig <martin@ximian.com>
17715 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17717 * class.cs (SourceMethod): New public class, derive from the
17718 symbol writer's ISourceMethod.
17719 (Method): Use the new symbol writer API.
17721 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17722 as argument and use the new symbol writer.
17725 (SourceFile): Implement the symbol writer's ISourceFile.
17726 (Location.SymbolDocument): Removed.
17727 (Location.SourceFile): New public property.
17729 * symbolwriter.cs: Use the new symbol writer API.
17731 2004-07-30 Raja R Harinath <rharinath@novell.com>
17733 * Makefile (install-local): Remove. Functionality moved to
17736 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17738 * Makefile: Install mcs.exe.config file together with mcs.exe.
17739 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17740 correct runtime version.
17742 2004-07-25 Martin Baulig <martin@ximian.com>
17745 (TypeContainer.RegisterOrder): Removed, this was unused.
17746 (TypeContainer, interface_order): Removed.
17747 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17748 TypeContainer as argument since we can also be called with a
17749 `PartialContainer' for a partial class/struct/interface.
17750 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17751 of checking whether we're an `Interface' - we could be a
17752 `PartialContainer'.
17753 (PartialContainer.Register): Override; call
17754 AddClass()/AddStruct()/AddInterface() on our parent.
17756 * cs-parser.jay (interface_member_declaration): Add things to the
17757 `current_container', not the `current_class'.
17759 * rootcontext.cs (RegisterOrder): The overloaded version which
17760 takes an `Interface' was unused, removed.
17762 * typemanager.cs (TypeManager.LookupInterface): Return a
17763 `TypeContainer', not an `Interface'.
17764 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17765 contain a `PartialContainer' for an interface, so check it's
17766 `Kind' to figure out what it is.
17768 2004-07-25 Martin Baulig <martin@ximian.com>
17770 * class.cs (Class.DefaultTypeAttributes): New public constant.
17771 (Struct.DefaultTypeAttributes): Likewise.
17772 (Interface.DefaultTypeAttributes): Likewise.
17773 (PartialContainer.TypeAttr): Override this and add the
17774 DefaultTypeAttributes.
17776 2004-07-25 Martin Baulig <martin@ximian.com>
17778 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17779 we can just use the `Parent' field instead.
17781 2004-07-25 Martin Baulig <martin@ximian.com>
17783 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17785 2004-07-25 Martin Baulig <martin@ximian.com>
17787 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17788 our parts before defining any methods.
17789 (TypeContainer.VerifyImplements): Make this virtual.
17790 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17791 on our PartialContainer.
17793 2004-07-25 Martin Baulig <martin@ximian.com>
17795 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17797 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17798 argument, we can just use the `Parent' field instead.
17801 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17802 (MemberBase.DoDefine): Likewise.
17804 2004-07-24 Martin Baulig <martin@ximian.com>
17806 * decl.cs (MemberCore.Parent): New public field.
17807 (DeclSpace.Parent): Moved to MemberCore.
17809 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17810 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17812 (FieldBase, Field, Operator): Likewise.
17813 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17814 (EventField, Event): Likewise.
17816 2004-07-23 Martin Baulig <martin@ximian.com>
17818 * class.cs (PartialContainer): New public class.
17819 (ClassPart): New public class.
17820 (TypeContainer): Added support for partial classes.
17821 (TypeContainer.GetClassBases): Splitted some of the functionality
17822 out into GetNormalBases() and GetPartialBases().
17824 * cs-tokenizer.cs (Token.PARTIAL): New token.
17825 (Tokenizer.consume_identifier): Added some hacks to recognize
17826 `partial', but only if it's immediately followed by `class',
17827 `struct' or `interface'.
17829 * cs-parser.jay: Added support for partial clases.
17831 2004-07-23 Martin Baulig <martin@ximian.com>
17833 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17834 a `DeclSpace' and also made it readonly.
17835 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17836 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17837 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17839 * cs-parser.jay: Pass the `current_class', not the
17840 `current_container' (at the moment, this is still the same thing)
17841 to a new Method, Property, Event, Indexer or Constructor.
17843 2004-07-23 Martin Baulig <martin@ximian.com>
17845 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17846 and removed the `current_interface' one.
17847 (struct_declaration, class_declaration, interface_declaration):
17848 Set `current_class' to the newly created class/struct/interface;
17849 set their `Bases' and call Register() before parsing their body.
17851 2004-07-23 Martin Baulig <martin@ximian.com>
17853 * class.cs (Kind): New public enum.
17854 (TypeContainer): Made this class abstract.
17855 (TypeContainer.Kind): New public readonly field.
17856 (TypeContainer.CheckDef): New public method; moved here from
17858 (TypeContainer.Register): New public abstract method.
17859 (TypeContainer.GetPendingImplementations): New public abstract
17861 (TypeContainer.GetClassBases): Removed the `is_class' and
17862 `is_iface' parameters.
17863 (TypeContainer.DefineNestedTypes): Formerly known as
17865 (ClassOrStruct): Made this class abstract.
17867 * tree.cs (RootTypes): New public type.
17869 2004-07-20 Martin Baulig <martin@ximian.com>
17871 * tree.cs (Tree.RecordNamespace): Removed.
17872 (Tree.Namespaces): Removed.
17874 * rootcontext.cs (RootContext.IsNamespace): Removed.
17876 * cs-parser.jay (namespace_declaration): Just create a new
17877 NamespaceEntry here.
17879 2004-07-20 Martin Baulig <martin@ximian.com>
17881 * statement.cs (ExceptionStatement): New abstract class. This is
17882 now used as a base class for everyone who's using `finally'.
17883 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17884 our local variables before using them.
17886 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17887 virtual method. This is used by Yield.Resolve() to "steal" an
17888 outer block's `finally' clauses.
17889 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17892 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17893 version which takes an ExceptionStatement. This version must be
17894 used to create exception branchings.
17897 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17898 (Iterator.EmitMoveNext): Added exception support; protect the
17899 block with a `fault' clause, properly handle 'finally' clauses.
17900 (Iterator.EmitDispose): Run all the `finally' clauses here.
17902 2004-07-20 Martin Baulig <martin@ximian.com>
17904 * iterator.cs: This is the first of a set of changes in the
17905 iterator code. Match the spec more closely: if we're an
17906 IEnumerable, then GetEnumerator() must be called. The first time
17907 GetEnumerator() is called, it returns the current instance; all
17908 subsequent invocations (if any) must create a copy.
17910 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17912 * expression.cs: Resolve the constant expression before returning
17915 2004-07-19 Martin Baulig <martin@ximian.com>
17917 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17918 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17919 the return type of the new EmitContext.
17921 2004-07-18 Martin Baulig <martin@ximian.com>
17923 * class.cs (Property.Define): Fix iterators.
17925 * iterators.cs (Iterator.Define): Moved the
17926 `container.AddInterator (this)' call here from the .ctor; only do
17927 it if we resolved successfully.
17929 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17931 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17932 `true' for preprocessing directives that we parse. The return
17933 value indicates whether we should return to regular tokenizing or
17934 not, not whether it was parsed successfully.
17936 In the past if we were in: #if false ... #line #endif, we would
17937 resume parsing after `#line'. See bug 61604.
17939 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17940 building: IsEnumType should return true only for enums, not for
17941 enums or System.Enum itself. This fixes #61593.
17943 Likely what happened is that corlib was wrong: mcs depended on
17944 this bug in some places. The bug got fixed, we had to add the
17945 hack, which caused bug 61593.
17947 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17948 that was a workaround for the older conditions.
17950 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17952 * assign.cs: IAssignMethod has a new interface, as documented
17953 inline. All assignment code now uses this new api.
17955 * ecore.cs, expression.cs: All classes which implement
17956 IAssignMethod now use the new interface.
17958 * expression.cs (Invocation): add a hack to EmitCall so that
17959 IndexerAccess can be the target of a compound assignment without
17960 evaluating its arguments twice.
17962 * statement.cs: Handle changes in Invocation api.
17964 2004-07-16 Martin Baulig <martin@ximian.com>
17966 * iterators.cs: Rewrote this. We're now using one single Proxy
17967 class for both the IEnumerable and the IEnumerator interface and
17968 `Iterator' derives from Class so we can use the high-level API.
17970 * class.cs (TypeContainer.AddIterator): New method.
17971 (TypeContainer.DoDefineType): New protected virtual method, which
17972 is called from DefineType().
17973 (TypeContainer.DoDefineMembers): Call DefineType() and
17974 DefineMembers() on all our iterators.
17975 (TypeContainer.Emit): Call Emit() on all our iterators.
17976 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17978 * codegen.cs (EmitContext.CurrentIterator): New public field.
17980 2004-07-15 Martin Baulig <martin@ximian.com>
17983 (TypeManager.not_supported_exception_type): New type.
17985 2004-07-14 Martin Baulig <martin@ximian.com>
17987 * iterators.cs: Use real error numbers.
17989 2004-07-14 Martin Baulig <martin@ximian.com>
17991 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17992 requires this to be a System.Collection.IEnumerable and not a
17993 class implementing that interface.
17994 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17996 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17998 * class.cs: Fixed previous fix, it broke some error tests.
18000 2004-07-12 Martin Baulig <martin@ximian.com>
18002 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18005 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18007 * assign.cs (LocalTemporary): Add new argument: is_address,If
18008 `is_address' is true, then the value that we store is the address
18009 to the real value, and not the value itself.
18011 * ecore.cs (PropertyExpr): use the new local temporary
18012 stuff to allow us to handle X.Y += z (where X is a struct)
18014 2004-07-08 Martin Baulig <martin@ximian.com>
18016 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18017 not always return, just like we're doing in Using.Resolve().
18019 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18021 * cs-parser.jay (fixed_statement): flag this as Pinned.
18023 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18025 * typemanager.cs (TypeManager): Removed MakePinned method, this
18026 mechanism is replaced with the .NET 2.x compatible mechanism of
18027 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18029 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18030 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18031 `IsFixed' property which has a different meaning.
18033 2004-07-02 Raja R Harinath <rharinath@novell.com>
18035 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18036 visible from inside a nested class, not just the names of the
18037 immediately enclosing class.
18038 Fix for bug #60730.
18040 2004-06-24 Raja R Harinath <rharinath@novell.com>
18042 * expression.cs (BetterConversion): Remove buggy special-case
18043 handling of "implicit constant expression conversions". At this
18044 point, we already know that the conversion is possible -- we're
18045 only checking to see which is better.
18047 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18049 * cs-parser.jay: Added error CS0210 test.
18051 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18053 * cs-parser.jay: Added error CS0134 test.
18055 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18058 * cs-parser.jay: Added error CS0145 test.
18060 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18062 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18064 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18066 * expression.cs (StackAlloc.Resolve): The argument may not
18067 be a constant; deal with this case.
18069 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18071 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18072 GetIndexerAttributeValue.
18073 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18075 * class.cs (Indexer.Define): Added error tests for CS0415,
18078 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18080 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18083 2004-06-23 Martin Baulig <martin@ximian.com>
18085 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18086 neither return nor throw, reset the barrier as well. Fixes #60457.
18088 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18090 * class.cs : EventAttributes is now set to None by default.
18091 This fixes bug #60459.
18093 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18096 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18097 Don't throw exception but return null (it's sufficient now).
18099 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18101 * typemanager.cs (GetArgumentTypes): Faster implementation.
18103 2004-06-18 Martin Baulig <martin@ximian.com>
18105 * attribute.cs (Attribute.Resolve): Check whether we're an
18106 EmptyCast which a Constant child. Fixes #60333.
18108 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18110 * statement.cs (EmitCollectionForeach): Account for the fact that
18111 not all valuetypes are in areas which we can take the address of.
18112 For these variables, we store to a temporary variable. Also, make
18113 sure that we dont emit a `callvirt' on a valuetype method.
18115 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18117 * expression.cs (StackAlloc.DoReSolve): Added test for
18118 negative parameter (CS0247).
18120 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18123 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18125 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18128 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18131 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18133 Fix bug #58254 & cs1555.cs, cs1556.cs
18134 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18136 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18138 * cs-parser.jay: Added error CS1669 test for indexers.
18140 2004-06-11 Martin Baulig <martin@ximian.com>
18142 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18143 call this twice: for params and varargs methods.
18145 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18148 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18150 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18152 * attribute.cs (Attribute.GetValidTargets): Made public.
18155 (AbstractPropertyEventMethod): New class for better code sharing.
18156 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18158 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18160 2004-06-11 Raja R Harinath <rharinath@novell.com>
18163 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18164 that the call to Resolve is part of a MemberAccess.
18165 (Expression.Resolve): Use it for SimpleName resolution.
18166 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18167 Add 'intermediate' boolean argument.
18168 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18169 error message when the SimpleName can be resolved ambiguously
18170 between an expression and a type.
18171 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18173 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18174 call on the left-side.
18176 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18179 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18181 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18183 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18185 2004-06-11 Martin Baulig <martin@ximian.com>
18187 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18188 varargs methods if applicable.
18190 2004-06-11 Martin Baulig <martin@ximian.com>
18192 * expression.cs (Invocation.EmitCall): Don't use
18193 `method.CallingConvention == CallingConventions.VarArgs' since the
18194 method could also have `CallingConventions.HasThis'.
18196 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18198 * class.cs (Event.GetSignatureForError): Implemented.
18199 Fixed crash in error test cs3010.cs
18201 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18203 * cs-tokenizer.cs: Change the way we track __arglist to be
18204 consistent with the other keywords.
18206 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18208 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18211 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18213 * codegen.cs: Check that all referenced assemblies have a strongname
18214 before strongnaming the compiled assembly. If not report error CS1577.
18215 Fix bug #56563. Patch by Jackson Harper.
18216 * typemanager.cs: Added a method to return all referenced assemblies.
18217 Fix bug #56563. Patch by Jackson Harper.
18219 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18222 (Method.ApplyAttributeBuilder): Moved and added conditional
18223 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18226 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18228 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18231 * class.cs: (EventField.attribute_targets): Changed default target.
18233 2004-06-08 Martin Baulig <martin@ximian.com>
18235 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18237 2004-06-08 Martin Baulig <martin@ximian.com>
18239 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18241 2004-06-07 Martin Baulig <martin@ximian.com>
18243 Added support for varargs methods.
18245 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18248 * cs-parser.jay: Added support for `__arglist'.
18250 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18252 * expression.cs (Argument.AType): Added `ArgList'.
18253 (Invocation): Added support for varargs methods.
18254 (ArglistAccess): New public class.
18255 (Arglist): New public class.
18257 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18259 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18260 a method's top-level block if the method has varargs.
18262 * support.cs (ReflectionParameters, InternalParameters): Added
18263 support for varargs methods.
18265 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18267 * class.cs: Provide location in indexer error report.
18269 * driver.cs: Use standard names.
18271 * namespace.cs: Catch the use of using after a namespace has been
18272 declared also on using aliases.
18274 2004-06-03 Raja R Harinath <rharinath@novell.com>
18277 * typemanager.cs (closure_private_ok, closure_invocation_type)
18278 (closure_qualifier_type, closure_invocation_assembly)
18279 (FilterWithClosure): Move to ...
18280 (Closure): New internal nested class.
18281 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18282 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18283 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18284 (MemberLookup, MemberLookupFailed): Use it.
18285 * expression.cs (New.DoResolve): Treat the lookup for the
18286 constructor as being qualified by the 'new'ed type.
18287 (Indexers.GetIndexersForTypeOrInterface): Update.
18289 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18292 (GetConditionalAttributeValue): New method. Returns
18293 condition of ConditionalAttribute.
18294 (SearchMulti): New method. Returns all attributes of type 't'.
18295 Use it when attribute is AllowMultiple = true.
18296 (IsConditionalMethodExcluded): New method.
18299 (Method.IsExcluded): Implemented. Returns true if method has conditional
18300 attribute and the conditions is not defined (method is excluded).
18301 (IMethodData): Extended interface for ConditionalAttribute support.
18302 (PropertyMethod.IsExcluded): Implemented.
18305 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18308 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18311 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18313 * expression.cs (ArrayCreationExpression): Make this just an
18314 `expression'. It can't be a statement, so the code here was
18317 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18320 * typemanager.cs (GetFullNameSignature): New method for
18323 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18326 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18327 Use this method when MethodBuilder is null.
18328 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18329 Added test for error CS0626 (MONO reports error for this situation).
18330 (IMethodData.GetSignatureForError): Extended interface.
18332 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18335 (AttributeTester.GetObsoleteAttribute): Returns instance of
18336 ObsoleteAttribute when type is obsolete.
18339 (TypeContainer.VerifyObsoleteAttribute): Override.
18340 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18341 (MethodCode.VerifyObsoleteAttribute): Override.
18342 (MemberBase.VerifyObsoleteAttribute): Override.
18345 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18346 and report proper error.
18349 Delegate.VerifyObsoleteAttribute): Override.
18352 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18353 and report proper error.
18354 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18357 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18361 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18362 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18363 Added test for ObsoleteAttribute.
18366 (Catch): Derived from Statement.
18368 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18370 Fixed bug #59071 & cs0160.cs
18372 * statement.cs (Try.Resolve): Check here whether order of catch
18373 clauses matches their dependencies.
18375 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18377 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18378 caused a regression: #59343. Referencing nested classes from an
18379 assembly stopped working.
18381 2004-05-31 Martin Baulig <martin@ximian.com>
18383 MCS is now frozen for beta 2.
18385 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18387 * convert.cs: add a trivial cache for overload operator resolution.
18389 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18391 * decl.cs: If possible, use lookuptypedirect here. We can only do
18392 this if there is no `.' after the namespace. Avoids using
18393 LookupType, which does lots of slow processing.
18394 (FindNestedType) New method, does what it says :-).
18395 * namespace.cs: use LookupTypeDirect.
18396 * rootcontext.cs: use membercache, if possible.
18397 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18399 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18402 According to the spec,
18404 In a member access of the form E.I, if E is a single identifier,
18405 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18406 field, property, localvariable, or parameter with the same type as
18407 the meaning of E as a type-name (§3.8), then both possible
18408 meanings of E are permitted.
18410 We did not check that E as a simple-name had the same type as E as
18413 This trivial check gives us 5-7% on bootstrap time.
18415 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18417 * expression.cs (Invocation.OverloadResolve): Avoid the
18418 use of hashtables and boxing here by allocating on demand.
18420 2004-05-30 Martin Baulig <martin@ximian.com>
18422 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18423 we're doing a silent lookup. Don't try to lookup nested types in
18424 TypeManager.object_type (thanks to Ben Maurer).
18426 2004-05-30 Martin Baulig <martin@ximian.com>
18428 Committing a patch from Ben Maurer.
18430 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18432 2004-05-29 Martin Baulig <martin@ximian.com>
18434 * class.cs (IMethodData.ShouldIgnore): New method.
18436 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18437 `Location' argument, we don't need it anywhere. Use
18438 `IMethodData.ShouldIgnore ()' instead of
18439 `MethodData.GetMethodFlags ()'.
18440 (TypeManager.AddMethod): Removed.
18441 (TypeManager.AddMethod2): Renamed to AddMethod.
18443 2004-05-29 Martin Baulig <martin@ximian.com>
18445 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18447 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18448 converting from a class type S to an interface type and we already
18449 have an object on the stack, don't box it again. Fixes #52578.
18451 2004-05-29 Martin Baulig <martin@ximian.com>
18453 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18454 Added support for `params' parameters. Fixes #59267.
18456 2004-05-29 Martin Baulig <martin@ximian.com>
18458 * literal.cs (NullPointer): Provide a private .ctor which sets
18459 `type' to TypeManager.object_type. Fixes #59048.
18461 2004-05-29 Martin Baulig <martin@ximian.com>
18463 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18464 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18466 * ecore.cs (EventExpr.instance_expr): Make the field private.
18468 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18470 Fixed bug #50080 & cs0214-2.cs
18471 * expression.cs (Cast.DoResolve): Check unsafe context here.
18473 * statement.cs (Resolve.DoResolve): Likewise.
18475 2004-05-26 Martin Baulig <martin@ximian.com>
18477 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18479 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18480 (RootContext.LookupType): Pass down the `silent' flag.
18482 2004-05-25 Martin Baulig <martin@ximian.com>
18485 (MethodGroupExpr.IdenticalTypeName): New public property.
18486 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18487 expression actually refers to a type.
18489 2004-05-25 Martin Baulig <martin@ximian.com>
18491 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18492 for #56176 and made it actually work.
18494 2004-05-25 Martin Baulig <martin@ximian.com>
18496 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18497 (FieldExpr, PropertyExpr): Override and implement
18498 CacheTemporaries. Fixes #52279.
18500 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18502 * location.cs: In the new compiler listing a file twice is a
18503 warning, not an error.
18505 2004-05-24 Martin Baulig <martin@ximian.com>
18507 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18508 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18510 2004-05-24 Martin Baulig <martin@ximian.com>
18512 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18513 walking the `using' list. Fixes #53921.
18515 2004-05-24 Martin Baulig <martin@ximian.com>
18517 * const.cs (Const.LookupConstantValue): Added support for
18518 EmptyCast's; fixes #55251.
18520 2004-05-24 Martin Baulig <martin@ximian.com>
18522 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18523 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18524 which does the CS0135 check. The reason is that we first need to
18525 check whether the variable actually exists.
18527 2004-05-24 Martin Baulig <martin@ximian.com>
18529 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18530 than RootContext.LookupType() to find the explicit interface
18531 type. Fixes #58584.
18533 2004-05-24 Raja R Harinath <rharinath@novell.com>
18535 * Makefile: Simplify. Use executable.make.
18536 * mcs.exe.sources: New file. List of sources of mcs.exe.
18538 2004-05-24 Anders Carlsson <andersca@gnome.org>
18542 Use the invariant culture when doing String.Compare for CLS case
18545 2004-05-23 Martin Baulig <martin@ximian.com>
18547 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18548 don't have any dots. Fixes #52622, added cs0246-8.cs.
18550 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18552 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18554 * class.cs (MemberBase.Define): Reuse MemberType member for
18555 resolved type. Other methods can use it too.
18557 2004-05-23 Martin Baulig <martin@ximian.com>
18559 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18560 the variable also exists in the current block (otherwise, we need
18561 to report a CS0103). Fixes #58670.
18563 2004-05-23 Martin Baulig <martin@ximian.com>
18565 * flowanalysis.cs (Reachability.Reachable): Compute this
18566 on-the-fly rather than storing it as a field.
18568 2004-05-23 Martin Baulig <martin@ximian.com>
18570 * flowanalysis.cs (Reachability.And): Manually compute the
18571 resulting `barrier' from the reachability.
18573 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18576 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18577 instance of ObsoleteAttribute when symbol is obsolete.
18580 (IMethodData): Extended interface for ObsoleteAttribute support.
18582 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18584 * attribute.cs: Fix bug #55970
18586 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18590 (GetObsoleteAttribute): New method. Creates the instance of
18592 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18593 ObsoleteAttribute when member is obsolete.
18594 (AttributeTester.Report_ObsoleteMessage): Common method for
18595 Obsolete error/warning reporting.
18598 (TypeContainer.base_classs_type): New member for storing parent type.
18601 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18602 for this MemberCore.
18604 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18606 * attribute.cs, const.cs: Fix bug #58590
18608 2004-05-21 Martin Baulig <martin@ximian.com>
18610 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18611 out parameters if the end of the method is unreachable. Fixes
18614 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18616 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18617 Hari was right, why extra method.
18619 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18621 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18623 2004-05-20 Martin Baulig <martin@ximian.com>
18625 Merged this back from gmcs to keep the differences to a minumum.
18627 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18628 instead of a Declspace.
18629 (Attribute.ResolveType): Likewise.
18630 (Attributes.Search): Likewise.
18631 (Attributes.Contains): Likewise.
18632 (Attributes.GetClsCompliantAttribute): Likewise.
18634 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18636 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18639 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18641 Fix bug #58688 (MCS does not report error when the same attribute
18644 * attribute.cs (Attribute.Emit): Distinction between null and default.
18646 2004-05-19 Raja R Harinath <rharinath@novell.com>
18648 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18649 of a top-level attribute without an attribute target.
18650 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18652 (Attribute.Conditional_GetConditionName),
18653 (Attribute.Obsolete_GetObsoleteMessage): Update.
18654 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18655 part of ScanForIndexerName.
18656 (Attribute.CanIgnoreInvalidAttribute): New function.
18657 (Attribute.ScanForIndexerName): Move to ...
18658 (Attributes.ScanForIndexerName): ... here.
18659 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18660 (Attributes.Search): New internal variant that can choose not to
18661 complain if types aren't resolved. The original signature now
18663 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18664 complaints suppressed.
18665 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18666 only if it not useful.
18667 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18668 top-level for attributes that are shared between the assembly
18669 and a top-level class.
18670 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18671 * class.cs: Update to reflect changes.
18672 (DefineIndexers): Fuse loops.
18673 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18674 a couple more variants of attribute names.
18676 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18678 Fix bug #52585 (Implemented explicit attribute declaration)
18681 (Attributable.ValidAttributeTargets): New abstract method. It gets
18682 list of valid attribute targets for explicit target declaration.
18683 (Attribute.Target): It holds target itself.
18684 (AttributeSection): Removed.
18685 (Attribute.CheckTargets): New method. It checks whether attribute
18686 target is valid for the current element.
18689 (EventProperty): New class. For events that are declared like
18690 property (with add and remove accessors).
18691 (EventField): New class. For events that are declared like field.
18694 * cs-parser.jay: Implemented explicit attribute target declaration.
18696 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18697 Override ValidAttributeTargets.
18700 (ReturnParameter): Class for applying custom attributes on
18702 (ParameterAtribute): New class. Class for applying custom
18703 attributes on the parameter type.
18705 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18707 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18710 (Method): Allow UNSAFE here.
18712 * modifiers.cs: Support unsafe reporting.
18714 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18716 * decl.cs: Fix bug #58478.
18718 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18720 * statement.cs: When checking for unreachable code on an EmptyStatement,
18721 set the location. Fixes bug #58488.
18723 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18725 * driver.cs: Add -pkg handling.
18727 From Gonzalo: UseShelLExecute=false
18729 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18732 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18734 (Attribute.IsClsCompliaceRequired): Moved to base for better
18736 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18737 when attribute is AttributeUsageAttribute.
18738 (Attribute.GetValidTargets): Simplified.
18739 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18740 attribute for this type.
18741 (Attribute.ApplyAttributes): Method renamed to Emit and make
18743 (GlobalAttributeSection): New class for special handling of global
18744 attributes (assembly, module).
18745 (AttributeSection.Emit): New method.
18747 * class.cs: Implemented Attributable abstract methods.
18748 (MethodCore.LabelParameters): Moved to Parameter class.
18749 (Accessor): Is back simple class.
18750 (PropertyMethod): Implemented Attributable abstract class.
18751 (DelegateMethod): Implemented Attributable abstract class.
18752 (Event): New constructor for disctintion between normal Event
18753 and Event with accessors.
18755 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18757 * codegen.cs, const.cs, decl.cs, delegate.cs:
18758 (CommonAssemblyModulClass): Implemented Attributable abstract class
18761 * enum.cs: Implement IAttributeSupport interface.
18762 (EnumMember): New class for emum members. Implemented Attributable
18766 (ParameterBase): Is abstract.
18767 (ReturnParameter): New class for easier [return:] attribute handling.
18769 * typemanager.cs: Removed builder_to_attr.
18771 2004-05-11 Raja R Harinath <rharinath@novell.com>
18774 * attribute.cs (Attribute.GetPositionalValue): New function.
18775 * class.cs (TypeContainer.VerifyMembers): New function.
18776 (TypeContainer.Emit): Use it.
18777 (ClassOrStruct): New base class for Class and Struct.
18778 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18779 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18781 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18782 then each non-static field should have a FieldOffset attribute.
18783 Otherwise, none of the fields should have a FieldOffset attribute.
18784 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18785 and FieldOffset attributes.
18786 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18787 (TypeManager.field_offset_attribute_type): New core types.
18788 (TypeManager.InitCoreTypes): Initialize them.
18790 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18792 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18793 Return correct type.
18796 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18798 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18799 be implicitly converted to ulong.
18801 * expression.cs: The logic for allowing operator &, | and ^ worked
18802 was wrong, it worked before because we did not report an error in
18803 an else branch. Fixes 57895.
18805 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18806 allow volatile fields to be reference types.
18808 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18810 * driver.cs: Add support for /debug-
18812 2004-05-07 Raja R Harinath <rharinath@novell.com>
18814 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18815 Add a 'complain' parameter to silence errors.
18816 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18817 silently overlooked type-resolutions.
18818 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18819 to reflect changes.
18820 (Attributes.Search): New function.
18821 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18822 (Attributes.GetAttributeFullName): Remove hack.
18823 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18824 Update to reflect changes.
18825 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18826 Use Attributes.Search instead of nested loops.
18828 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18831 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18832 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18833 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18835 * report.cs: (Report.Warning): Renamed to Warning_T because of
18836 parameter collision.
18838 2004-05-05 Raja R Harinath <rharinath@novell.com>
18840 * expression.cs (MemberAccess.ResolveMemberAccess):
18841 Exit with non-zero status after Report.Error.
18842 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18844 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18846 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18848 * support.cs: Don't hang when the file is empty.
18850 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18852 * support.cs: In SeekableStreamReader, compute the preamble size of the
18853 underlying stream. Position changes should take into account that initial
18856 2004-05-03 Todd Berman <tberman@sevenl.net>
18858 * driver.cs: remove unused GetSysVersion function.
18860 2004-05-03 Todd Berman <tberman@sevenl.net>
18862 * driver.cs: Remove the hack from saturday, as well as the hack
18863 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18864 link_paths to get that bit proper.
18866 2004-05-01 Todd Berman <tberman@sevenl.net>
18868 * driver.cs: Try a LoadFrom before a Load, this checks the current
18869 path. This is currently a bug in mono that is be fixed, however, this
18870 provides a workaround for now. This will be removed when the bug
18873 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18875 * CryptoConvert.cs: Updated to latest version. Fix issue with
18876 incomplete key pairs (#57941).
18878 2004-05-01 Todd Berman <tberman@sevenl.net>
18880 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18883 2004-04-30 Jackson Harper <jackson@ximian.com>
18885 * codegen.cs: Open keys readonly.
18887 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18889 * typemanager.cs: don't report cyclic struct layout when a struct
18890 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18891 which has 2 Pango.Rectangle fields.
18893 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18895 * expression.cs: Handle IntPtr comparisons with IL code
18896 rather than a method call.
18898 2004-04-29 Martin Baulig <martin@ximian.com>
18900 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18901 the list of PropertyInfo's in class hierarchy and find the
18902 accessor. Fixes #56013.
18904 2004-04-29 Martin Baulig <martin@ximian.com>
18906 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18908 2004-04-29 Martin Baulig <martin@ximian.com>
18910 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18912 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18914 2004-04-29 Martin Baulig <martin@ximian.com>
18916 * class.cs (ConstructorInitializer.Resolve): Check whether the
18917 parent .ctor is accessible. Fixes #52146.
18919 2004-04-29 Martin Baulig <martin@ximian.com>
18921 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18923 * statement.cs (Using.EmitLocalVariableDecls): Use
18924 TypeManager.idisposable_type, not typeof (IDisposable).
18925 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18927 2004-04-29 Martin Baulig <martin@ximian.com>
18929 * class.cs (Event.Define): Don't emit the field and don't set
18930 RTSpecialName and SpecialName for events on interfaces. Fixes
18933 2004-04-29 Raja R Harinath <rharinath@novell.com>
18935 Refactor Attribute.ApplyAttributes.
18936 * attribute.cs (Attributable): New base class for objects that can
18937 have Attributes applied on them.
18938 (Attribute): Make AttributeUsage fields public.
18939 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18940 (Attribute.IsInternalCall): New property.
18941 (Attribute.UsageAttr): Convert to a public read-only property.
18942 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18943 (Attribute.ResolveType, Attribute.Resolve)
18944 (Attribute.ScanForIndexerName): Update to reflect changes.
18945 (Attribute.CheckAttributeTarget): Re-format.
18946 (Attribute.ApplyAttributes): Refactor, to various
18947 Attributable.ApplyAttributeBuilder methods.
18948 * decl.cs (MemberCore): Make Attributable.
18949 * class.cs (Accessor): Make Attributable.
18950 (MethodData.ApplyAttributes): Use proper attribute types, not
18952 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18953 (TypeContainer.ApplyAttributeBuilder)
18954 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18955 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18956 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18957 (Operator.ApplyAttributeBuilder): New factored-out methods.
18958 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18959 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18960 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18961 * parameter.cs (ParameterBase): New Attributable base class
18962 that can also represent Return types.
18963 (Parameter): Update to the changes.
18965 2004-04-29 Jackson Harper <jackson@ximian.com>
18967 * driver.cs: Prefer the corlib system version when looking for
18968 assemblies in the GAC. This is still a hack, but its a better hack
18971 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18973 * decl.cs, enum.cs: Improved error 3005 reporting.
18975 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18976 (related_symbols): New private member for list of symbols
18977 related to reported error/warning.
18979 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18981 2004-04-29 Martin Baulig <martin@ximian.com>
18983 * ecore.cs (Expression.Constantify): If we're an enum and
18984 TypeManager.TypeToCoreType() doesn't give us another type, use
18985 t.UnderlyingSystemType. Fixes #56178.
18987 2004-04-29 Martin Baulig <martin@ximian.com>
18989 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18990 interfaces and for each interface, only add members directly
18991 declared in that interface. Fixes #53255.
18993 2004-04-28 Martin Baulig <martin@ximian.com>
18995 * expression.cs (ConditionalLogicalOperator): Use a temporary
18996 variable for `left' to avoid that we evaluate it more than once;
18999 2004-04-28 Martin Baulig <martin@ximian.com>
19001 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19004 2004-04-28 Martin Baulig <martin@ximian.com>
19006 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19009 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19010 whether the type is not void (CS1547).
19012 2004-04-28 Martin Baulig <martin@ximian.com>
19014 * expression.cs (Unary.DoResolveLValue): Override this and report
19015 CS0131 for anything but Operator.Indirection.
19017 2004-04-28 Martin Baulig <martin@ximian.com>
19019 Committing a patch from Ben Maurer; see bug #50820.
19021 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19024 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19027 2004-04-28 Martin Baulig <martin@ximian.com>
19029 Committing a patch from Ben Maurer; see bug #50820.
19031 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19034 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19037 2004-04-28 Martin Baulig <martin@ximian.com>
19039 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19040 (Block.AddLabel): Call DoLookupLabel() to only search in the
19043 2004-04-28 Martin Baulig <martin@ximian.com>
19045 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19046 comparing StringConstants and NullLiterals in Equality and Inequality.
19048 2004-04-28 Jackson Harper <jackson@ximian.com>
19050 * driver.cs: Attempt to load referenced assemblies from the
19051 GAC. This is the quick and dirty version of this method that
19052 doesnt take into account versions and just takes the first
19053 canidate found. Will be good enough for now as we will not have more
19054 then one version installed into the GAC until I update this method.
19056 2004-04-28 Martin Baulig <martin@ximian.com>
19058 * typemanager.cs (TypeManager.CheckStructCycles): New public
19059 static method to check for cycles in the struct layout.
19061 * rootcontext.cs (RootContext.PopulateTypes): Call
19062 TypeManager.CheckStructCycles() for each TypeContainer.
19063 [Note: We only need to visit each type once.]
19065 2004-04-28 Martin Baulig <martin@ximian.com>
19067 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19069 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19070 success and added `out object value'. Use a `bool resolved' field
19071 to check whether we've already been called rather than
19072 `ConstantValue != null' since this breaks for NullLiterals.
19074 2004-04-28 Raja R Harinath <rharinath@novell.com>
19076 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19077 setting of this flag, since the 'set' method may be non-public.
19079 2004-04-28 Raja R Harinath <rharinath@novell.com>
19081 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19082 check on current_vector.Block.
19084 2004-04-27 Martin Baulig <martin@ximian.com>
19086 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19087 a field initializer. Fixes #56459.
19089 2004-04-27 Martin Baulig <martin@ximian.com>
19091 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19092 we're not attempting to use an indexer. Fixes #52154.
19094 2004-04-27 Martin Baulig <martin@ximian.com>
19096 * statement.cs (Return): Don't create a return label if we don't
19097 need it; reverts my change from January 20th. Thanks to Ben
19100 2004-04-27 Martin Baulig <martin@ximian.com>
19102 According to the spec, `goto' can only leave a nested scope, but
19105 * statement.cs (Block.LookupLabel): Only lookup in the current
19106 block, don't recurse into parent or child blocks.
19107 (Block.AddLabel): Check in parent and child blocks, report
19108 CS0140/CS0158 if we find a duplicate.
19109 (Block): Removed this indexer for label lookups.
19110 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19111 this already does the error reporting for us.
19114 (FlowBranching.UsageVector.Block): New public variable; may be null.
19115 (FlowBranching.CreateSibling): Added `Block' argument.
19116 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19117 label for the target of a `goto' and check whether we're not
19118 leaving a `finally'.
19120 2004-04-27 Martin Baulig <martin@ximian.com>
19122 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19123 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19126 2004-04-27 Martin Baulig <martin@ximian.com>
19128 * statement.cs (Block.AddLabel): Also check for implicit blocks
19129 and added a CS0158 check.
19131 2004-04-27 Martin Baulig <martin@ximian.com>
19133 * flowanalysis.cs (FlowBranchingLoop): New class.
19134 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19135 UsageVector's instead of an ArrayList.
19136 (FlowBranching.Label): Likewise.
19137 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19138 (FlowBranching.AddBreakVector): New method.
19140 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19142 * attribute.cs: Small regression fix: only convert the type if we
19143 the type is different, fixes System.Drawing build.
19145 2004-04-27 Martin Baulig <martin@ximian.com>
19147 * attribute.cs (Attribute.Resolve): If we have a constant value
19148 for a named field or property, implicity convert it to the correct
19151 2004-04-27 Raja R Harinath <rharinath@novell.com>
19153 * statement.cs (Block.Block): Implicit blocks share
19154 'child_variable_names' fields with parent blocks.
19155 (Block.AddChildVariableNames): Remove.
19156 (Block.AddVariable): Mark variable as "used by a child block" in
19157 every surrounding block.
19158 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19159 been used in a child block, complain about violation of "Invariant
19160 meaning in blocks" rule.
19161 * cs-parser.jay (declare_local_variables): Don't use
19162 AddChildVariableNames.
19163 (foreach_statement): Don't create an implicit block: 'foreach'
19164 introduces a scope.
19166 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19168 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19169 converting from 0L to ulong. Fixes 57522.
19171 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19173 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19174 derived class hides via 'new' keyword field from base class (test-242.cs).
19175 TODO: Handle this in the more general way.
19177 * class.cs (CheckBase): Ditto.
19179 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19181 * decl.cs (caching_flags): New member for storing cached values
19183 (MemberCore.Flags): New enum where bit flags for caching_flags
19185 (MemberCore.cls_compliance): Moved to caching_flags.
19186 (DeclSpace.Created): Moved to caching_flags.
19188 * class.cs: Use caching_flags instead of DeclSpace.Created
19190 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19192 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19193 if we are only a derived class, not a nested class.
19195 * typemanager.cs: Same as above, but do this at the MemberLookup
19196 level (used by field and methods, properties are handled in
19197 PropertyExpr). Allow for the qualified access if we are a nested
19200 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19202 * class.cs: Refactoring.
19203 (IMethodData): New inteface; Holds links to parent members
19204 to avoid member duplication (reduced memory allocation).
19205 (Method): Implemented IMethodData interface.
19206 (PropertyBase): New inner classes for get/set methods.
19207 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19208 (Event): New inner classes for add/remove methods.
19209 (Event.DelegateMethod): Implemented IMethodData interface.
19211 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19212 EmitContext (related to class.cs refactoring).
19214 2004-04-21 Raja R Harinath <rharinath@novell.com>
19216 * delegate.cs (Delegate.VerifyApplicability): If the number of
19217 arguments are the same as the number of parameters, first try to
19218 verify applicability ignoring any 'params' modifier on the last
19222 2004-04-16 Raja R Harinath <rharinath@novell.com>
19224 * class.cs (TypeContainer.AddIndexer): Use
19225 'ExplicitInterfaceName' to determine if interface name was
19226 explicitly specified. 'InterfaceType' is not initialized at this time.
19227 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19228 Indexers array is already in the required order. Initialize
19229 'IndexerName' only if there are normal indexers.
19230 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19231 (TypeContainer.Emit): Emit DefaultMember attribute only if
19232 IndexerName is initialized.
19235 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19237 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19240 2004-04-15 Raja R Harinath <rharinath@novell.com>
19242 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19246 * attribute.cs (Attribute.Resolve): Check for duplicate named
19250 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19252 * iterators.cs (MarkYield): track whether we are in an exception,
19253 and generate code accordingly. Use a temporary value to store the
19254 result for our state.
19256 I had ignored a bit the interaction of try/catch with iterators
19257 since their behavior was not entirely obvious, but now it is
19258 possible to verify that our behavior is the same as MS .NET 2.0
19262 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19264 * iterators.cs: Avoid creating temporaries if there is no work to
19267 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19268 Enumerations, use TypeManager.EnumToUnderlying and call
19271 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19274 (This.Emit): Use EmitContext.EmitThis to emit our
19277 (This.EmitAssign): Ditto.
19279 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19280 codepaths, we will move all the functionality into
19283 (FieldExpr.EmitAssign): Ditto.
19285 This fixes several hidden bugs that I uncovered while doing a code
19286 review of this today.
19288 * codegen.cs (EmitThis): reworked so the semantics are more clear
19289 and also support value types "this" instances.
19291 * iterators.cs: Changed so that for iterators in value types, we
19292 do not pass the value type as a parameter.
19294 Initialization of the enumerator helpers is now done in the caller
19295 instead of passing the parameters to the constructors and having
19296 the constructor set the fields.
19298 The fields have now `assembly' visibility instead of private.
19300 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19302 * expression.cs (Argument.Resolve): Check if fields passed as ref
19303 or out are contained in a MarshalByRefObject.
19305 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19306 another compiler type.
19308 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19310 * class.cs (Indexer.Define): use the new name checking method.
19311 Also, return false on an error.
19312 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19313 (is_identifier_[start/part]_character): make static.
19315 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19317 * expression.cs (Binary.ResolveOperator): Do no append strings
19318 twice: since we can be invoked more than once (array evaluation)
19319 on the same concatenation, take care of this here. Based on a fix
19320 from Ben (bug #56454)
19322 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19324 * codegen.cs: Fix another case where CS1548 must be reported (when
19325 delay-sign isn't specified and no private is available #56564). Fix
19326 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19327 error when MCS is used on the MS runtime and we need to delay-sign
19328 (which seems unsupported by AssemblyBuilder - see #56621).
19330 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19332 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19333 (TypeManager.ComputeNamespaces): Faster implementation for
19336 * compiler.csproj: Updated AssemblyName to mcs.
19338 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19340 * rootcontext.cs: Add new types to the boot resolution.
19342 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19343 MulticastDelegate is not allowed.
19345 * typemanager.cs: Add new types to lookup: System.TypedReference
19348 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19349 check for TypedReference or ArgIterator, they are not allowed.
19351 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19352 makes us properly catch 1510 in some conditions (see bug 56016 for
19355 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19357 * CryptoConvert.cs: update from corlib version
19360 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19362 * class.cs (Indexer.Define): Check indexername declaration
19364 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19366 * attribute.cs (IsClsCompliant): Fixed problem with handling
19367 all three states (compliant, not-compliant, undetected).
19369 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19371 * attribute.cs (Attribute): Location is now public.
19372 (Resolve): Store resolved arguments (pos_values) in attribute class.
19373 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19374 (GetClsCompliantAttributeValue): New method that gets
19375 CLSCompliantAttribute value.
19376 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19377 if exists else null.
19378 (AttributeTester): New class for CLS-Compliant verification routines.
19380 * class.cs (Emit): Add CLS-Compliant verification.
19381 (Method.GetSignatureForError): Implemented.
19382 (Constructor.GetSignatureForError): Implemented
19383 (Constructor.HasCompliantArgs): Returns if constructor has
19384 CLS-Compliant arguments.
19385 (Constructor.Emit): Override.
19386 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19387 is needed to test only parameters.
19388 (FieldBase.GetSignatureForError): Implemented.
19389 (TypeContainer): New member for storing base interfaces.
19390 (TypeContainer.FindMembers): Search in base interfaces too.
19392 * codegen.cs (GetClsComplianceAttribute): New method that gets
19393 assembly or module CLSCompliantAttribute value.
19394 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19396 (ModuleClass.Emit): Add error 3012 test.
19398 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19400 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19401 state for all decl types.
19402 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19403 if CLS-Compliant tests are required.
19404 (IsClsCompliaceRequired): New method. Analyze whether code
19405 must be CLS-Compliant.
19406 (IsExposedFromAssembly): New method. Returns true when MemberCore
19407 is exposed from assembly.
19408 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19409 value or gets cached value.
19410 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19411 is explicitly marked with CLSCompliantAttribute.
19412 (IsIdentifierClsCompliant): New abstract method. This method is
19413 used to testing error 3005.
19414 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19415 for identifier and parameters CLS-Compliant testing.
19416 (VerifyClsCompliance): New method. The main virtual method for
19417 CLS-Compliant verifications.
19418 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19419 null. I don't know why is null (too many public members !).
19420 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19421 and get value of first CLSCompliantAttribute that found.
19423 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19424 (VerifyClsCompliance): Override and add extra tests.
19426 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19427 clscheck- disable CLS-Compliant verification event if assembly is has
19428 CLSCompliantAttribute(true).
19430 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19431 ApllyAttribute is now called in emit section as in the other cases.
19432 Possible future Emit integration.
19433 (IsIdentifierClsCompliant): New override.
19434 (VerifyClsCompliance): New override.
19435 (GetEnumeratorName): Returns full enum name.
19437 * parameter.cs (GetSignatureForError): Implemented.
19439 * report.cs (WarningData): New struct for Warning message information.
19440 (LocationOfPreviousError): New method.
19441 (Warning): New method. Reports warning based on the warning table.
19442 (Error_T): New method. Reports error based on the error table.
19444 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19445 verifications are done here.
19447 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19449 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19450 CLSCompliantAttribute.
19451 (all_imported_types): New member holds all imported types from other
19453 (LoadAllImportedTypes): New method fills static table with exported types
19454 from all referenced assemblies.
19455 (Modules): New property returns all assembly modules.
19457 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19459 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19460 throwing a parser error.
19462 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19463 which removes the hardcoded get_/set_ prefixes for properties, as
19464 IL allows for the properties to be named something else.
19468 * expression.cs: Do not override operand before we know if it is
19469 non-null. Fix 56207
19471 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19473 * typemanager.cs: support for pinned variables.
19475 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19477 * decl.cs, typemanager.cs: Avoid using an arraylist
19478 as a buffer if there is only one result set.
19480 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19482 * expression.cs: Make sure you cant call a static method
19483 with an instance expression, bug #56174.
19485 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19487 * class.cs (IsDuplicateImplementation): Improve error reporting to
19488 flag 663 (method only differs in parameter modifier).
19490 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19491 in preprocessor directives.
19493 * location.cs (LookupFile): Allow for the empty path.
19495 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19496 better approach for some of that patch, but its failing with the
19497 CharSet enumeration. For now try/catch will do.
19499 * typemanager.cs: Do not crash if a struct does not have fields.
19502 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19504 * expression.cs: cs0213, cant fix a fixed expression.
19507 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19509 * cs-parser.jay: detect invalid embeded statements gracefully.
19512 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19514 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19517 the invocation type may not be a subclass of the tye of the item/
19518 The type of the item must be a subclass of the invocation item.
19523 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19525 * attribute.cs: Added methods to get a string and a bool from an
19526 attribute. Required to information from AssemblyKeyFileAttribute,
19527 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19528 * codegen.cs: Modified AssemblyName creation to include support for
19529 strongnames. Catch additional exceptions to report them as CS1548.
19530 * compiler.csproj: Updated include CryptoConvert.cs.
19531 * compiler.csproj.user: Removed file - user specific configuration.
19532 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19533 Mono.Security assembly. The original class is maintained and tested in
19534 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19535 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19536 like CSC 8.0 (C# v2) supports.
19537 * Makefile: Added CryptoConvert.cs to mcs sources.
19538 * rootcontext.cs: Added new options for strongnames.
19540 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19542 * driver.cs: For --expect-error, report error code `2'
19543 if the program compiled with no errors, error code `1' if
19544 it compiled with an error other than the one expected.
19546 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19548 * compiler.csproj: Updated for Visual Studio .NET 2003.
19549 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19550 * compiler.sln: Updated for Visual Studio .NET 2003.
19552 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19554 * expression.cs: Fix bug #47234. We basically need to apply the
19555 rule that we prefer the conversion of null to a reference type
19556 when faced with a conversion to 'object' (csc behaviour).
19558 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19560 * statement.cs: Shorter form for foreach, eliminates
19561 a local variable. r=Martin.
19563 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19565 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19566 checks if we can use brtrue/brfalse to test for 0.
19567 * expression.cs: use the above in the test for using brtrue/brfalse.
19568 cleanup code a bit.
19570 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19572 * expression.cs: Rewrite string concat stuff. Benefits:
19574 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19575 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19576 rather than a concat chain.
19578 * typemanager.cs: Add lookups for more concat overloads.
19580 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19582 * expression.cs: Emit shorter il code for array init.
19599 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19601 * statement.cs: Before, two switch blocks would be merged if the
19602 total size of the blocks (end_item - begin_item + 1) was less than
19603 two times the combined sizes of the blocks.
19605 Now, it will only merge if after the merge at least half of the
19610 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19612 * class.cs : csc build fix for GetMethods(). See bug #52503.
19614 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19616 * expression.cs: Make sure fp comparisons work with NaN.
19617 This fixes bug #54303. Mig approved this patch a long
19618 time ago, but we were not able to test b/c the runtime
19621 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19623 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19625 2004-03-19 Martin Baulig <martin@ximian.com>
19627 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19628 error here and not in our caller.
19630 2004-03-19 Martin Baulig <martin@ximian.com>
19632 * interface.cs: Completely killed this file.
19633 (Interface): We're now a TypeContainer and live in class.cs.
19635 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19636 argument; we're now also called for interfaces.
19637 (TypeContainer.DefineMembers): Allow this method being called
19639 (TypeContainer.GetMethods): New public method; formerly known as
19640 Interface.GetMethod(). This is used by PendingImplementation.
19641 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19642 it's now private and non-static.
19643 (Interface): Moved this here; it's now implemented similar to
19645 (Method, Property, Event, Indexer): Added `bool is_interface'
19646 argument to their .ctor's.
19647 (MemberBase.IsInterface): New public field.
19649 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19650 instances instead of InterfaceMethod, InterfaceProperty, etc.
19651 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19652 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19654 2004-03-19 Martin Baulig <martin@ximian.com>
19656 * class.cs (MethodCore.IsDuplicateImplementation): New private
19657 method which does the CS0111 checking.
19658 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19659 Use IsDuplicateImplementation().
19661 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19663 * decl.cs (FindMemberToOverride): New method to find the correct
19664 method or property to override in the base class.
19666 - Make Method/Property use the above method to find the
19667 version in the base class.
19668 - Remove the InheritableMemberSignatureCompare as it is now
19671 This patch makes large code bases much faster to compile, as it is
19672 O(n) rather than O(n^2) to do this validation.
19674 Also, it fixes bug 52458 which is that nested classes are not
19675 taken into account when finding the base class member.
19677 Reviewed/Approved by Martin.
19679 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19681 * interface.cs: In all interface classes removed redundant
19682 member initialization.
19684 2004-03-16 Martin Baulig <martin@ximian.com>
19686 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19688 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19690 * decl.cs (DefineTypeAndParents): New helper method to define a
19691 type's containers before the type itself is defined; This is a
19692 bug exposed by the recent changes to Windows.Forms when an
19693 implemented interface was defined inside a class that had not been
19696 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19698 (Check): Loop correctly to report errors modifiers
19699 (UNSAFE was not in the loop, since it was the same as TOP).
19701 * interface.cs: Every interface member now takes a ModFlags,
19702 instead of a "is_new" bool, which we set on the base MemberCore.
19704 Every place where we called "UnsafeOk" in the interface, now we
19705 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19706 the unsafe settings from the member declaration instead of the
19707 container interface.
19709 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19711 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19712 `set_indexer_name' to the pending bits (one per type).
19714 We fixed a bug today that was picking the wrong method to
19715 override, since for properties the existing InterfaceMethod code
19716 basically ignored the method name. Now we make sure that the
19717 method name is one of the valid indexer names.
19719 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19721 * support.cs (SeekableStreamReader): Keep track of stream byte
19722 positions and don't mix them with character offsets to the buffer.
19724 Patch from Gustavo Giráldez
19726 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19728 * interface.cs (InterfaceSetGetBase): Removed double member
19729 initialization, base class does it as well.
19731 2004-03-13 Martin Baulig <martin@ximian.com>
19733 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19734 when compiling corlib.
19736 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19738 * convert.cs (ExplicitConversion): We were reporting an error on
19739 certain conversions (object_type source to a value type, when the
19740 expression was `null') before we had a chance to pass it through
19741 the user defined conversions.
19743 * driver.cs: Replace / and \ in resource specifications to dots.
19746 * class.cs: Add check for duplicate operators. Fixes 52477
19748 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19750 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19751 that are in the middle of the statements, not only at the end.
19754 * class.cs (TypeContainer.AddField): No longer set the
19755 `HaveStaticConstructor' flag, now we call it
19756 `UserDefineStaticConstructor' to diferentiate the slightly
19757 semantic difference.
19759 The situation is that we were not adding BeforeFieldInit (from
19760 Modifiers.TypeAttr) to classes that could have it.
19761 BeforeFieldInit should be set to classes that have no static
19766 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19768 And most importantly Zoltan's comment:
19770 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19772 "I think beforefieldinit means 'it's ok to initialize the type sometime
19773 before its static fields are used', i.e. initialization does not need
19774 to be triggered by the first access to the type. Setting this flag
19775 helps the JIT to compile better code, since it can run the static
19776 constructor at JIT time, and does not need to generate code to call it
19777 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19778 this flag for lots of classes like String.
19780 csc sets this flag if the type does not have an explicit static
19781 constructor. The reasoning seems to be that if there are only static
19782 initalizers for a type, and no static constructor, then the programmer
19783 does not care when this initialization happens, so beforefieldinit
19786 This bug prevents the AOT compiler from being usable, since it
19787 generates so many calls to mono_runtime_class_init that the AOT code
19788 is much slower than the JITted code. The JITted code is faster,
19789 because it does not generate these calls if the vtable is type is
19790 already initialized, which is true in the majority of cases. But the
19791 AOT compiler can't do this."
19793 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19795 * class.cs (MethodData.Emit): Refactor the code so symbolic
19796 information is generated for destructors; For some reasons we
19797 were taking a code path that did not generate symbolic information
19800 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19802 * class.cs: Create a Constructor.CheckBase method that
19803 takes care of all validation type code. The method
19804 contains some code that was moved from Define.
19806 It also includes new code that checks for duplicate ctors.
19807 This fixes bug #55148.
19809 2004-03-09 Joshua Tauberer <tauberer@for.net>
19811 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19812 a { ... }-style array creation invokes EmitStaticInitializers
19813 which is not good for reference-type arrays. String, decimal
19814 and now null constants (NullCast) are not counted toward
19815 static initializers.
19817 2004-03-05 Martin Baulig <martin@ximian.com>
19819 * location.cs (SourceFile.HasLineDirective): New public field;
19820 specifies whether the file contains or is referenced by a "#line"
19822 (Location.DefineSymbolDocuments): Ignore source files which
19823 either contain or are referenced by a "#line" directive.
19825 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19827 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19828 direct access to our parent, so check the method inline there.
19830 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19832 * expression.cs (Invocation.EmitCall): Miguel's last commit
19833 caused a regression. If you had:
19838 In Foo the implict this would be null.
19840 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19842 * expression.cs (Invocation.EmitCall): If the method is not
19843 virtual, do not emit a CallVirt to it, use Call.
19845 * typemanager.cs (GetFullNameSignature): Improve the method to
19846 cope with ".ctor" and replace it with the type name.
19848 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19849 as an argument the ConstructorBuilder where it is being defined,
19850 to catch the recursive constructor invocations.
19852 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19854 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19855 routines to check if a type is an enumerable/enumerator allow
19856 classes that implement the IEnumerable or IEnumerator interfaces.
19858 * class.cs (Property, Operator): Implement IIteratorContainer, and
19859 implement SetYields.
19861 (Property.Define): Do the block swapping for get_methods in the
19862 context of iterators. We need to check if Properties also
19863 include indexers or not.
19865 (Operator): Assign the Block before invoking the
19866 OperatorMethod.Define, so we can trigger the Iterator code
19869 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19870 Property and Operator classes are not created when we parse the
19871 declarator but until we have the block completed, so we use a
19872 singleton SimpleIteratorContainer.Simple to flag whether the
19873 SetYields has been invoked.
19875 We propagate this setting then to the Property or the Operator to
19876 allow the `yield' to function.
19878 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19880 * codegen.cs: Implemented attribute support for modules.
19881 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19882 Assembly/Module functionality.
19884 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19885 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19886 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19888 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19890 * interface.cs (FindMembers): The operation is performed on all base
19891 interfaces and not only on the first. It is required for future CLS Compliance patch.
19893 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19895 * statement.cs, codegen.cs:
19896 This patch deals with patterns such as:
19898 public class List : IEnumerable {
19900 public MyEnumerator GetEnumerator () {
19901 return new MyEnumerator(this);
19904 IEnumerator IEnumerable.GetEnumerator () {
19908 public struct MyEnumerator : IEnumerator {
19913 Before, there were a few things we did wrong:
19914 1) we would emit callvirt on a struct, which is illegal
19915 2) we emited ldarg when we needed to emit ldarga
19916 3) we would mistakenly call the interface methods on an enumerator
19917 type that derived from IEnumerator and was in another assembly. For example:
19919 public class MyEnumerator : IEnumerator
19921 Would have the interface methods called, even if there were public impls of the
19922 method. In a struct, this lead to invalid IL code.
19924 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19926 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19929 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19931 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19933 * cs-parser.jay: Fix small regression: we were not testing V2
19934 compiler features correctly.
19936 * interface.cs: If the emit context is null, then create one
19938 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19940 * decl.cs (GetSignatureForError): New virtual method to get full name
19941 for error messages.
19943 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19944 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19946 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19947 Duplicated members and code in these classes has been removed.
19948 Better encapsulation in these classes.
19950 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19952 * assign.cs (Assign.DoResolve): When dealing with compound
19953 assignments, there is a new rule in ECMA C# 2.4 (might have been
19954 there before, but it is documented here) that states that in:
19958 If b is of type int, and the `op' is a shift-operator, then the
19959 above is evaluated as:
19963 * expression.cs (Binary.ResolveOperator): Instead of testing for
19964 int/uint/long/ulong, try to implicitly convert to any of those
19965 types and use that in pointer arithmetic.
19967 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19968 method to print information for from the type, not from the
19969 null-method we were given.
19971 2004-02-01 Duncan Mak <duncan@ximian.com>
19973 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19974 parsing for cmd, fixes bug #53694.
19976 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19978 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19979 in the member name duplication tests. Property and operator name duplication
19980 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19982 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19984 * interface.cs (PopulateMethod): Fixed crash when interface method
19985 returns not existing type (error test cs0246-3.cs).
19987 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19989 * cs-parser.jay (interface_accessors): Re-write actions to also
19990 store attributes attached to get and set methods. Fix spelling
19993 (inteface_property_declaration): Modify accordingly.
19995 (InterfaceAccessorInfo): New helper class to store information to pass
19996 around between rules that use interface_accessors.
19998 * interface.cs (Emit): Apply attributes on the get and set
19999 accessors of properties and indexers too.
20001 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20002 right MethodBuilder when applying attributes to the get and set accessors.
20004 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20006 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20008 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20010 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20012 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20014 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20015 changes that treat `yield' specially when present before `break'
20016 or `return' tokens.
20018 * cs-tokenizer.cs: yield is no longer a keyword.
20020 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20022 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20023 setting for default constructors.
20024 For default constructors are almost every time set wrong Modifier. The
20025 generated IL code has been alright. But inside mcs this values was
20026 wrong and this was reason why several of my CLS Compliance tests
20029 2004-01-22 Martin Baulig <martin@ximian.com>
20031 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20032 not a QualifiedIdentifier. This is what `type_name_expression'
20033 was previously doing.
20034 (type_name_expression): Removed; the code is now in
20035 `namespace_or_type_name'.
20036 (qualified_identifier): Removed, use `namespace_or_type_name'
20038 (QualifiedIdentifier): Removed this class.
20040 2004-01-22 Martin Baulig <martin@ximian.com>
20042 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20043 not a string as alias name.
20045 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20047 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20048 #52730 bug, and instead compute correctly the need to use a
20049 temporary variable when requesting an address based on the
20050 static/instace modified of the field and the constructor.
20052 2004-01-21 Martin Baulig <martin@ximian.com>
20054 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20055 class and namespace before looking up aliases. Fixes #52517.
20057 2004-01-21 Martin Baulig <martin@ximian.com>
20059 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20060 assinged in a 'try'; fixes exception4.cs.
20062 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20063 * class.cs : Implemented parameter-less constructor for TypeContainer
20065 * decl.cs: Attributes are now stored here. New property OptAttributes
20067 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20069 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20071 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20073 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20074 (CSharpSignature): New method for indexer and property signature.
20076 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20078 * pending.cs (IsVirtualFilter): Faster implementation.
20080 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20082 * typemanager.cs: Avoid inclusion of same assembly more than once.
20084 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20086 * cs-parser.jay: Fixed problem where the last assembly attribute
20087 has been applied also to following declaration (class, struct, etc.)
20089 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20091 * class.cs: Added error CS0538, CS0539 reporting.
20092 Fixed crash on Microsoft runtime when field type is void.
20094 * cs-parser.jay: Added error CS0537 reporting.
20096 * pending.cs: Added error CS0535 reporting.
20097 Improved error report for errors CS0536, CS0534.
20099 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20101 Merge a few bits from the Anonymous Method MCS tree.
20103 * statement.cs (ToplevelBlock): New class for toplevel methods,
20104 will hold anonymous methods, lifted variables.
20106 * cs-parser.jay: Create toplevel blocks for delegates and for
20107 regular blocks of code.
20109 2004-01-20 Martin Baulig <martin@ximian.com>
20111 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20112 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20113 and `NeedExplicitReturn'; added `IsLastStatement'.
20114 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20115 have a `ReturnLabel' or we're not unreachable.
20117 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20118 child's reachability; don't just override ours with it. Fixes
20119 #58058 (lluis's example).
20120 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20121 InFinally(), InLoop(), InSwitch() and
20122 BreakCrossesTryCatchBoundary() methods.
20124 * statement.cs (Return): Do all error checking in Resolve().
20125 Unless we are the last statement in a top-level block, always
20126 create a return label and jump to it.
20127 (Break, Continue): Do all error checking in Resolve(); also make
20128 sure we aren't leaving a `finally'.
20129 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20130 statement in a top-level block.
20131 (Block.Flags): Added `IsDestructor'.
20132 (Block.IsDestructor): New public property.
20134 2004-01-20 Martin Baulig <martin@ximian.com>
20136 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20138 2004-01-20 Martin Baulig <martin@ximian.com>
20140 * statement.cs (Statement.ResolveUnreachable): New public method.
20141 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20142 (Block.Resolve): Resolve unreachable statements.
20144 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20146 * expression.cs: We need to fix the case where we do
20147 not have a temp variable here.
20149 * assign.cs: Only expression compound assignments need
20150 temporary variables.
20152 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20154 * flowanalysis.cs: Reduce memory allocation in a few ways:
20155 - A block with no variables should not allocate a bit
20157 - A method with no out parameters does not need any tracking
20158 for assignment of the parameters, so we need not allocate
20161 public readonly Type[] VariableTypes;
20162 public readonly string[] VariableNames;
20163 Are redundant. The data is already stored in the variable
20164 map, so we need not allocate another array for it.
20165 - We need to add alot of checks for if (params | locals) == null
20166 due to the first two changes.
20168 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20170 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20171 implement IMemoryLocation, we store a copy on a local variable and
20172 take the address of it. Patch from Benjamin Jemlich
20174 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20175 to use a special "type_name_expression" rule which reduces the
20176 number of "QualifiedIdentifier" classes created, and instead
20177 directly creates MemberAccess expressions.
20179 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20181 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20182 that fixes #52853. Null literal assignment to ValueType
20184 * class.cs (MethodData.Emit): Instead of checking the name of the
20185 method to determine if its a destructor, create a new derived
20186 class from Method called Destructor, and test for that.
20188 * cs-parser.jay: Create a Destructor object instead of a Method.
20190 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20194 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20196 * expression.cs (Binary.ResolveOperator): Perform an implicit
20197 conversion from MethodGroups to their delegate types on the
20198 Addition operation.
20200 * delegate.cs: Introduce a new class DelegateCreation that is the
20201 base class for `NewDelegate' and `ImplicitDelegateCreation',
20202 factor some code in here.
20204 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20205 conversion from MethodGroups to compatible delegate types.
20207 * ecore.cs (Expression.Resolve): Do not flag error 654
20208 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20209 we allow conversions from MethodGroups to delegate types now.
20211 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20212 assignments in v2 either.
20214 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20216 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20217 static read-only fields in ctors.
20219 Applied patch from Benjamin Jemlich
20221 * expression.cs (UnaryMutator): Avoid leaking local variables.
20223 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20225 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20226 here to return true, as they can be used like this:
20228 (XXX) int.MEMBER ()
20230 Fixed 49836 and all the other dups
20232 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20234 * driver.cs: Implement /win32res and /win32icon.
20236 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20238 * cs-parser.jay: Add a rule to improve error handling for the
20239 common mistake of placing modifiers after the type.
20241 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20243 * cs-parser.jay (interface_event_declaration): Catch
20244 initialization of events on interfaces, and report cs0068
20246 * cs-parser.jay (interface_event_declaration): Catch
20247 initialization of events.
20249 * ecore.cs: Better report missing constructors.
20251 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20252 the error reporting done in the wrong place. Fix.
20254 * expression.cs (Binary.ResolveOperator): Catch the
20255 operator + (E x, E y) error earlier, and later allow for implicit
20256 conversions in operator +/- (E e, U x) from U to the underlying
20259 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20260 52596, if the container class is abstract, the default constructor
20261 is protected otherwise its public (before, we were always public).
20263 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20266 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20267 Jemlich that fixes bug #52597, MCS was generating invalid code for
20268 idisposable structs. Thanks to Ben for following up with this
20271 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20273 * driver.cs: Allow assemblies without code to be generated, fixes
20276 2004-01-07 Nick Drochak <ndrochak@gol.com>
20278 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20280 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20282 * cs-parser.jay: Add rules to improve error reporting if fields or
20283 methods are declared at the namespace level (error 116)
20285 * Add rules to catch event add/remove
20287 2004-01-04 David Sheldon <dave-mono@earth.li>
20289 * expression.cs: Added matching ")" to error message for
20292 2004-01-03 Todd Berman <tberman@gentoo.org>
20294 * ecore.cs, attribute.cs:
20295 Applying fix from #52429.
20297 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20299 * ecore.cs, expression.cs, statement.cs:
20300 Total rewrite of how we handle branching. We
20301 now handle complex boolean expressions with fewer
20302 jumps. As well if (x == 0) no longer emits a ceq.
20304 if (x is Foo) is much faster now, because we generate
20307 Overall, we get a pretty big improvement on our benchmark
20308 tests. The code we generate is smaller and more readable.
20310 I did a full two-stage bootstrap. The patch was reviewed
20311 by Martin and Miguel.
20313 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20315 * cs-parser.jay: Make primary_expression not take a QI.
20316 we dont need this because the member_access rule covers
20317 us here. So we replace the rule with just IDENTIFIER.
20319 This has two good effects. First, we remove a s/r conflict.
20320 Second, we allocate many fewer QualifiedIdentifier objects.
20322 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20324 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20325 set the correct information via SRE. This prevents
20326 hanging on the MS runtime. Fixes #29374.
20328 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20330 * convert.cs: correctly handle conversions to value types
20331 from Enum and ValueType as unboxing conversions.
20333 Fixes bug #52569. Patch by Benjamin Jemlich.
20335 2004-01-02 Ravi Pratap <ravi@ximian.com>
20337 * expression.cs (BetterConversion): Prefer int -> uint
20338 over int -> ulong (csc's behaviour). This fixed bug #52046.
20340 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20342 * decl.cs (MemberCache.FindMembers): now returns a
20345 * typemanager.cs: In general, go with with ^^.
20346 (CopyNewMethods): take an IList.
20347 (RealMemberLookup): Only allocate an arraylist
20348 if we copy from two sets of methods.
20350 This change basically does two things:
20351 1) Fewer array lists allocated due to CopyNewMethods.
20352 2) the explicit cast in MemberList costed ALOT.
20354 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20356 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20357 a hashtable to avoid needless string allocations when an identifier is
20358 used more than once (the common case).
20360 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20362 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20363 is broken, it will not return anything. So, we
20364 have to use the information we have in mcs to
20367 * typemanager.cs: Add a cache for GetInterfaces,
20368 since this will now be used more often (due to ^^)
20370 (GetExplicitInterfaces) New method that gets the
20371 declared, not effective, interfaces on a type
20372 builder (eg, if you have interface IFoo, interface
20373 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20376 This patch makes MCS able to bootstrap itself on
20379 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20381 * expression.cs: Remove the Nop's that Miguel put
20384 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20386 * report.cs, codegen.cs: Give the real stack trace to
20387 the error when an exception is thrown.
20389 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20391 * decl.cs: only allocate hashtables for ifaces if
20394 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20396 * expression.cs: fix the error from cs0121-2.cs
20397 (a parent interface has two child interfaces that
20398 have a function with the same name and 0 params
20399 and the function is called through the parent).
20401 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20403 * class.cs, rootcontext.cs, typmanager.cs: do not
20406 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20408 * codegen.cs: remove stack for the ec flow branching.
20409 It is already a linked list, so no need.
20411 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20413 * Makefile: Allow custom profiler here.
20415 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20417 * typemanager.cs (LookupType):
20418 - Use a static char [], because split takes
20419 a param array for args, so it was allocating
20421 - Do not store true in a hashtable, it boxes.
20423 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20425 * flowanalysis.cs: bytify common enums.
20427 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20429 * modifiers.cs: Add a new set of flags for the
20430 flags allowed on explicit interface impls.
20431 * cs-parser.jay: catch the use of modifiers in
20432 interfaces correctly.
20433 * class.cs: catch private void IFoo.Blah ().
20435 All related to bug #50572.
20437 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20439 * decl.cs: Rewrite the consistant accessability checking.
20440 Accessability is not linear, it must be implemented in
20441 a tableish way. Fixes #49704.
20443 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20445 * expression.cs: Handle negation in a checked context.
20446 We must use subtraction from zero. Fixes #38674.
20448 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20450 * class.cs: Ignore static void main in DLLs.
20451 * rootcontext.cs: Handle the target type here,
20452 since we are have to access it from class.cs
20453 * driver.cs: account for the above.
20455 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20457 * report.cs: Give line numbers and files if available.
20459 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20461 * driver.cs: Implement /addmodule.
20463 * typemanager.cs: Change 'modules' field so it now contains Modules not
20466 2003-12-20 Martin Baulig <martin@ximian.com>
20468 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20469 (FieldBase.IsAssigned): Removed this field.
20470 (FieldBase.SetAssigned): New public method.
20471 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20473 2003-12-20 Martin Baulig <martin@ximian.com>
20475 * expression.cs (LocalVariableReference.DoResolve): Don't set
20476 `vi.Used' if we're called from DoResolveLValue().
20478 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20479 returns the usage vector it just merged into the current one -
20480 pass this one to UsageWarning().
20481 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20482 of the `EmitContext', don't call this recursively on our children.
20484 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20486 * driver.cs: Implement /target:module.
20488 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20490 * support.cs (CharArrayHashtable): New helper class.
20492 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20493 char arrays, not strings, so we can avoid creating a string in
20494 consume_identifier if the identifier is a keyword.
20496 2003-12-16 Martin Baulig <martin@ximian.com>
20498 * statement.cs (LocalInfo.Assigned): Removed this property.
20499 (LocalInfo.Flags): Removed `Assigned'.
20500 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20501 and uses flow analysis.
20502 (Block.UsageWarning): Made this method private.
20503 (Block.Resolve): Call UsageWarning() if appropriate.
20505 * expression.cs (LocalVariableReference.DoResolve): Always set
20506 LocalInfo.Used here.
20508 2003-12-13 Martin Baulig <martin@ximian.com>
20510 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20511 any value here; we're now using flow analysis to figure out
20512 whether a statement/block returns a value.
20514 2003-12-13 Martin Baulig <martin@ximian.com>
20516 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20518 (FlowBranching.MergeFinally): Don't call
20519 `branching.CheckOutParameters()' here, this is called in
20521 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20522 when adding the `finally' vector.
20524 2003-12-13 Martin Baulig <martin@ximian.com>
20527 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20528 actually work and also fix #48962.
20530 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20532 * decl.cs: Do not check System.Object for nested types,
20533 since we know it does not have any. Big bang for buck:
20536 Run 1: 8.35 seconds
20537 Run 2: 8.32 seconds
20538 corlib: 17.99 seconds
20540 Run 1: 8.17 seconds
20541 Run 2: 8.17 seconds
20542 corlib: 17.39 seconds
20544 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20546 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20547 time we are returning 0 members, so we save alot here.
20549 2003-12-11 Martin Baulig <martin@ximian.com>
20551 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20552 `MergeChild()', also just take the `FlowBranching' as argument;
20553 call Merge() on it and return the result.
20554 (FlowBranching.Merge): We don't need to do anything if we just
20557 2003-12-11 Martin Baulig <martin@ximian.com>
20559 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20560 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20561 Maurer for this idea.
20563 2003-12-11 Martin Baulig <martin@ximian.com>
20565 * flowanalysis.cs (MergeResult): This class is now gone; we now
20566 use the `UsageVector' for this. The reason for this is that if a
20567 branching just has one sibling, we don't need to "merge" them at
20568 all - that's the next step to do.
20569 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20572 2003-12-11 Martin Baulig <martin@ximian.com>
20574 Reworked flow analyis and made it more precise and bug-free. The
20575 most important change is that we're now using a special `Reachability'
20576 class instead of having "magic" meanings of `FlowReturns'. I'll
20577 do some more cleanups and optimizations and also add some more
20578 documentation this week.
20580 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20581 largely reworked this class.
20582 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20583 the new `Reachability' class instead of having "magic" values here.
20584 (FlowBranching): We're now using an instance of `Reachability'
20585 instead of having separate `Returns', `Breaks' etc. fields.
20587 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20588 based on flow analysis; ignore the return value of block.Emit ().
20590 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20592 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20593 if they are private.
20595 2003-12-09 Martin Baulig <martin@ximian.com>
20597 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20598 call them directly on the UsageVector.
20600 2003-12-09 Martin Baulig <martin@ximian.com>
20602 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20603 Changed return type from `FlowReturns' to `Reachability'.
20605 2003-12-09 Martin Baulig <martin@ximian.com>
20607 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20608 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20609 `Reachable' fields with a single `Reachability' one.
20611 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20613 * class.cs (FindMembers): Remove foreach's.
20618 Run 1: 8.74 seconds
20619 Run 2: 8.71 seconds
20622 Run 1: 8.64 seconds
20623 Run 2: 8.58 seconds
20626 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20631 This patch does a few things:
20632 1. EmptyStatement is now a singleton, so it is never reallocated.
20633 2. All blah is EmptyStatement constructs have been changed to
20634 blah == EmptyStatement.Value, which is much faster and valid
20635 now that EmptyStatement is a singleton.
20636 3. When resolving a block, rather than allocating a new array for
20637 the non-empty statements, empty statements are replaced with
20638 EmptyStatement.Value
20639 4. Some recursive functions have been made non-recursive.
20640 Mainly the performance impact is from (3), however (1) and (2) are needed for
20641 this to work. (4) does not make a big difference in normal situations, however
20642 it makes the profile look saner.
20647 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20648 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20649 Total memory allocated: 56397 KB
20652 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20653 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20654 Total memory allocated: 55666 KB
20656 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20658 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20659 than the hashtable in a hashtable version
20661 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20662 we always end up concating a string. This results in a huge perf
20663 loss, because many strings have to be tracked by the GC. In this
20664 patch, we first use a hashtable that works with two keys, so that
20665 the strings do not need to be concat'ed.
20669 Run 1: 8.74 seconds
20670 Run 2: 8.71 seconds
20673 Run 1: 8.65 seconds
20674 Run 2: 8.56 seconds
20676 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20678 * Makefile: Add a new target `do-time' that does a quick and simple
20679 profile, leaving easy to parse output.
20681 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20683 * codegen.cs (Init): Create the dynamic assembly with
20684 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20686 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20688 * support.cs: Make the PtrHashtable use only one
20689 instance of its comparer.
20691 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20693 * typemanager.cs: Fix lookup of GetNamespaces.
20695 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20697 * expression.cs: Removed redundant line.
20699 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20700 ArrayLists, use for loops with bounds.
20702 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20705 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20706 arraylists, use for loop with bounds.
20708 The above three changes give us a 0.071 second performance
20709 improvement out of 3.294 seconds down to 3.223. On my machine
20710 the above changes reduced the memory usage by 1,387 KB during
20711 compiler bootstrap.
20713 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20714 QualifiedIdentifiers. Before we created a new string through
20715 concatenation, and mostly later on, the result would be
20716 manipulated by DecomposeQI through string manipulation.
20718 This reduced the compiler memory usage for bootstrapping from
20719 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20720 compile times in 0.05 seconds.
20722 2003-11-28 Dick Porter <dick@ximian.com>
20724 * support.cs: Do string compares with the Invariant culture.
20732 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20733 the comparison is done with the Invariant culture.
20735 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20737 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20738 GetEnumerator method.
20740 (ProbeCollectionType): Iterate starting at the most specific type
20741 upwards looking for a GetEnumerator
20743 * expression.cs: Shift count can be up to 31 for int/uint and 63
20746 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20748 * statement.cs (Block.LookupLabel): Also look for the label on the
20749 children blocks. Use a hash table to keep track of visited
20752 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20753 we actually did transform the other operand, otherwise fall back
20754 to the common codepath that casts to long.
20756 * cs-tokenizer.cs: Use the same code pattern as the int case.
20757 Maybe I should do the parsing myself, and avoid depending on the
20758 Parse routines to get this done.
20760 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20762 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20763 which fixes bug 51347. This time test it.
20765 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20766 attributes for example can not tell the difference between these.
20767 The difference was only a syntax feature of the language.
20769 * attribute.cs: Apply attributes to delegates.
20771 * delegate.cs: Call the apply attributes method.
20773 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20775 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20776 comparing 0 vs Byte.MinValue, not the value
20778 (ImplicitConversionRequired): When reporting a conversion error,
20779 use error 31 to print out the constant error instead of the
20782 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20783 which fixes bug 51347.
20785 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20787 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20788 which fixes the -warnaserror command line option.
20790 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20792 * cfold.cs (DoNumericPromotions): During constant folding of
20793 additions on UIntConstant, special case intconstants with
20794 IntConstants like we do on the expression binary operator.
20796 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20798 * convert.cs (ImplicitReferenceConversion): We were missing a case
20799 (System.Enum are not value types or class types, so we need to
20800 classify them separatedly).
20802 * driver.cs: We do not support error 2007.
20804 2003-11-12 Jackson Harper <jackson@ximian.com>
20806 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20807 system directory. Also use the full file name so users can
20808 libraries names mscorlib-o-tron.dll in a non system dir.
20810 2003-11-10 Martin Baulig <martin@ximian.com>
20812 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20813 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20814 calling `ResolveType()' on them, directly assign their `Type'.
20816 2003-11-08 Martin Baulig <martin@ximian.com>
20818 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20819 return value and the `out parent' parameter.
20820 (TypeContainer.DefineType): Moved the CS0644 check into
20821 GetClassBases(). Don't pass the interface types to the
20822 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20823 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20825 * ecore.cs (TypeExpr.IsAttribute): New property.
20826 (TypeExpr.GetInterfaces): New method.
20828 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20829 TypeExpr instead of a Type.
20830 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20831 (Interface.DefineType): Don't pass the interface types to the
20832 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20833 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20835 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20836 instead of a `Type[]'.
20837 (TypeManager.RegisterBuilder): Likewise.
20838 (TypeManager.AddUserInterface): Likewise.
20839 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20840 `Type[]' and also return a `TypeExpr[]'.
20841 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20843 2003-11-08 Martin Baulig <martin@ximian.com>
20845 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20848 2003-11-08 Martin Baulig <martin@ximian.com>
20850 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20851 TypeManager.ResolveExpressionTypes().
20853 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20854 instead of an Expression.
20855 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20856 (TypeExpression): New public class; formerly known as `TypeExpr'.
20858 * expression.cs (ComposedCast): Derive from TypeExpr.
20860 * typemanager.cs (TypeManager.system_*_expr): These are now
20861 TypExpr's instead of Expression's.
20862 (TypeManager.ResolveExpressionTypes): New public static function;
20863 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20866 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20868 * expression.cs (New.DoResolve): Do not dereference value that
20869 might be a null return.
20871 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20872 sure that the constant value has the right type. Fixes an
20873 unreported bug, similar to 50425.
20875 * const.cs (Const.LookupConstantValue): Call
20876 ImplicitStandardConversionExists before doing a conversion to
20877 avoid havng the TypeManager.ChangeType do conversions.
20879 Reduced the number of casts used
20881 (Const.ChangeType): New routine to enable reuse of the constant
20882 type changing code from statement.
20884 * typemanager.cs (ChangeType): Move common initialization to
20885 static global variables.
20889 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20890 every value type to go through, even if it was void. Fix that.
20892 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20893 character of the define, and the is_identifier_part_character for
20894 the rest of the string.
20896 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20898 * expression.cs (UnaryMutator.EmitCode): When I updated
20899 LocalVariableReference.DoResolve, I overdid it, and dropped an
20900 optimization done on local variable references.
20902 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20904 * ecore.cs: Convert the return from Ldlen into an int.
20906 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20908 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20909 the accessibility, this is a special case for toplevel non-public
20910 classes (internal for instance).
20912 2003-10-20 Nick Drochak <ndrochak@gol.com>
20914 * ecore.cs: Fix typo and build. Needed another right paren.
20916 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20918 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20919 `internal' case regular and protected, but not allowing protected
20920 to be evaluated later. Bug 49840
20922 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20924 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20925 to kb.Nlast, and not the kb.nFirst to isolate the switch
20928 Extract the underlying type, so enumerations of long/ulong are
20929 treated like long/ulong.
20931 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20933 * expression.cs (New): Overload the meaning of RequestedType to
20934 track the possible creation of the NewDelegate type, since
20935 DoResolve is invoked more than once for new constructors on field
20938 See bugs: #48800 and #37014
20940 * cs-parser.jay (declare_local_constants): Take an arraylist
20941 instead of a single constant.
20943 (local_constant_declaration): It should take a
20944 constant_declarators, not a constant_declarator. Fixes 49487
20946 * convert.cs: Fix error report.
20948 2003-10-13 Jackson Harper <jackson@ximian.com>
20950 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20953 2003-10-09 Martin Baulig <martin@ximian.com>
20955 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20957 (MethodCore.DoDefineParameters): Removed the TypeContainer
20958 argument; use the DeclSpace which was passed to the .ctor instead.
20959 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20960 TypeContainer; we only need a DeclSpace here.
20962 2003-10-09 Martin Baulig <martin@ximian.com>
20964 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20966 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20967 EmitContext's .ctor.
20969 2003-10-09 Martin Baulig <martin@ximian.com>
20971 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20972 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20973 AsAccessible(), moved them as well.
20975 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20977 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20979 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20981 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20983 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20984 generation for >=, as spotted by Paolo, bug 48679.
20985 Patch from David Waite.
20987 * cs-tokenizer.cs: Add handling for #pragma.
20989 * cs-parser.jay: Allow for both yield and yield return in the
20990 syntax. The anti-cobolization of C# fight will go on!
20992 * class.cs (TypeBuilder.DefineType): Catch error condition here
20993 (Parent.DefineType erroring out and returning null).
20995 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20996 coping with enumerations variables, we were mistakenly processing
20997 them as a regular value type instead of built-in types. Fixes the
21000 * typemanager.cs (IsBuiltinOrEnum): New method.
21002 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21004 * cs-parser.jay: Upgrade: yield now needs the return clause.
21006 2003-09-19 Martin Baulig <martin@ximian.com>
21008 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21009 `MemberCache parent' argument. Normally, an interface doesn't
21010 have a parent type except System.Object, but we use this in gmcs
21011 for generic type parameters.
21013 2003-09-18 Martin Baulig <martin@ximian.com>
21015 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21016 on `type.IsInterface'; don't check whether the type has a parent
21017 to determine whether it's an interface.
21019 2003-09-15 Martin Baulig <martin@ximian.com>
21021 * class.cs (TypeContainer.DefineType): Added an error flag to
21022 avoid reporting duplicate CS0146's ("class definition is
21025 * driver.cs (Driver.MainDriver): Abort if
21026 RootContext.ResolveTree() reported any errors.
21028 2003-09-07 Martin Baulig <martin@ximian.com>
21030 * report.cs (Error, Warning): Added overloaded versions which take
21031 a `params object[] args' and call String.Format().
21033 2003-09-07 Martin Baulig <martin@ximian.com>
21035 * decl.cs (DeclSpace..ctor): Don't call
21036 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21037 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21038 (DeclSpace.RecordDecl): New method.
21040 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21042 2003-09-02 Ravi Pratap <ravi@ximian.com>
21044 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21045 value attributes to be applied to ParameterBuilders.
21047 * class.cs (MethodCore.LabelParameters): Make static and more
21048 generic so that it can be used from other places - like interface
21049 methods, for instance.
21051 * interface.cs (Interface.Emit): Call LabelParameters before
21052 emitting attributes on the InterfaceMethod.
21054 2003-08-26 Martin Baulig <martin@ximian.com>
21056 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21057 resolving aliases; fixes #47927.
21059 2003-08-26 Martin Baulig <martin@ximian.com>
21061 * statement.cs (Using.DoResolve): This is internally emitting a
21062 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21063 do not always return. Fixes #47681.
21065 2003-08-26 Martin Baulig <martin@ximian.com>
21067 * decl.cs (MemberCore): Moved WarningNotHiding(),
21068 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21070 (AdditionResult): Make this nested in DeclSpace.
21071 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21072 argument; call NamespaceEntry.Define() unless we're nested in a
21075 * namespace.cs (Namespace.DefineName): New public function. This
21076 is called from DeclSpace's .ctor to add
21077 (Namespace.Lookup): Include DeclSpaces in the lookup.
21079 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21081 * const.cs (Const): Derive from MemberBase, not MemberCore.
21083 2003-08-25 Martin Baulig <martin@ximian.com>
21085 * convert.cs (Convert.ExplicitReferenceConversion): When
21086 converting from an interface type to a class, unbox if the target
21087 type is a struct type. Fixes #47822.
21089 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21091 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21094 2003-08-22 Martin Baulig <martin@ximian.com>
21096 * class.cs (TypeManager.DefineType): When defining a nested type,
21097 call DefineType() on our parent; fixes #47801.
21099 2003-08-22 Martin Baulig <martin@ximian.com>
21101 * class.cs (MethodData.Define): While checking if a method is an
21102 interface implementation, improve the test a bit more to fix #47654.
21104 2003-08-22 Martin Baulig <martin@ximian.com>
21106 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21107 correctly; fixes #47722.
21109 2003-08-22 Martin Baulig <martin@ximian.com>
21111 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21112 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21114 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21116 2003-08-22 Martin Baulig <martin@ximian.com>
21118 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21119 can only be assigned in static constructors. Fixes #47161.
21121 2003-08-22 Martin Baulig <martin@ximian.com>
21123 Rewrote and improved the flow analysis code.
21125 * flowbranching.cs (FlowBranching): Make this class abstract.
21126 (FlowBranching.CreateBranching): New static function to create a
21127 new flow branching.
21128 (FlowBranchingBlock, FlowBranchingException): New classes.
21129 (FlowBranching.UsageVector.Type): New public readonly field.
21130 (FlowBranching.UsageVector.Breaks): Removed the setter.
21131 (FlowBranching.UsageVector.Returns): Removed the setter.
21132 (FlowBranching.UsageVector): Added Break(), Return(),
21133 NeverReachable() and Throw() methods to modify the reachability.
21134 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21135 done by FlowBranching.Merge().
21136 (FlowBranching.UsageVector.MergeChild): New method; merges the
21137 merge result into the current vector.
21138 (FlowBranching.Merge): New abstract method to merge a branching.
21140 2003-08-12 Martin Baulig <martin@ximian.com>
21142 * expression.cs (Indirection.CacheTemporaries): Create the
21143 LocalTemporary with the pointer type, not its element type.
21145 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21147 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21148 token was a keyword or not.
21150 Add `error' options where an IDENTIFIER was expected; Provide
21151 CheckToken and CheckIdentifierToken convenience error reporting
21154 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21156 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21157 NameSpaceEntry NameSpaceEntry.
21159 (LookupInterfaceOrClass): Avoid creating a full qualified name
21160 from namespace and name: avoid doing lookups when we know the
21161 namespace is non-existant. Use new Tree.LookupByNamespace which
21162 looks up DeclSpaces based on their namespace, name pair.
21164 * driver.cs: Provide a new `parser verbose' to display the
21165 exception thrown during parsing. This is turned off by default
21166 now, so the output of a failure from mcs is more graceful.
21168 * namespace.cs: Track all the namespaces defined in a hashtable
21171 (IsNamespace): New method
21173 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21175 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21176 we know that we need to concatenate (full typename can never be
21181 * statement.cs: Use a bitfield; Do not initialize to null things
21182 which are done by the constructor by default.
21184 * cs-parser.jay: bug fix, parameter was 4, not 3.
21186 * expression.cs: Just use the property;
21188 * statement.cs: No need for GetVariableInfo method.
21190 2003-08-08 Martin Baulig <martin@ximian.com>
21192 * flowanalysis.cs (FlowReturns): This is now nested in the
21193 `FlowBranching' class.
21194 (MyBitVector): Moved this here from statement.cs.
21195 (FlowBranching.SiblingType): New enum type.
21196 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21198 2003-08-07 Martin Baulig <martin@ximian.com>
21200 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21201 `FlowBranching' class and called `BranchingType'.
21203 2003-08-07 Martin Baulig <martin@ximian.com>
21205 * flowanalysis.cs: Moved all the control flow analysis code into
21208 2003-08-07 Martin Baulig <martin@ximian.com>
21210 * assign.cs (Assign.DoResolve): `target' must either be an
21211 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21214 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21216 * expression.cs (BinaryMethod): This kind of expression is created by the
21217 Binary class if it determines that the operator has to be handled
21220 (BinaryDelegate): This kind of expression is created if we are
21221 dealing with a + or - operator on delegates.
21223 (Binary): remove method, argumetns, and DelegateOperator: when
21224 dealing with methods,
21226 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21228 * statement.cs (Block): use bitfields for the three extra booleans
21229 we had in use. Remove unused topblock parameter.
21231 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21233 * assign.cs: Drop extra unneeded tests.
21235 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21237 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21239 * statement.cs (Foreach): Use VariableStorage instead of
21242 * codegen.cs (VariableStorage): New class used by clients that
21243 require a variable stored: locals or fields for variables that
21244 need to live across yield.
21246 Maybe provide a convenience api for EmitThis+EmitLoad?
21248 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21251 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21253 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21254 RemapParameterLValue): New methods that are used to turn a
21255 precomputed FieldInfo into an expression like this:
21259 The idea is to use this instead of making LocalVariableReference
21260 have more than one meaning.
21262 * cs-parser.jay: Add error production to BASE.
21264 * ecore.cs: Deal with TypeManager.GetField returning null, which
21265 is now a valid return value.
21267 (FieldExprNoAddress): New expression for Fields whose address can
21270 * expression.cs (LocalVariableReference): During the resolve
21271 phases, create new expressions if we are in a remapping context.
21272 Remove code that dealt with remapping here.
21274 (ParameterReference): same.
21276 (ProxyInstance): New expression, like the `This' expression, but
21277 it is born fully resolved. We know what we are doing, so remove
21278 the errors that are targeted to user-provided uses of `this'.
21280 * statement.cs (Foreach): our variable is now stored as an
21281 Expression; During resolution, follow the protocol, dont just
21282 assume it will return this.
21284 2003-08-06 Martin Baulig <martin@ximian.com>
21286 * support.cs (SeekableStreamReader.cs): New public class.
21288 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21289 SeekableStreamReader instead of the normal StreamReader.
21291 2003-08-04 Martin Baulig <martin@ximian.com>
21293 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21294 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21295 deambiguate casts and delegate invocations.
21296 (parenthesized_expression): Use the new tokens to ensure this is
21297 not a cast of method invocation.
21299 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21300 when reading a `)' and Deambiguate_CloseParens () was previously
21303 * expression.cs (ParenthesizedExpression): New class. This is
21304 just used for the CS0075 test.
21305 (Binary.DoResolve): Check for CS0075.
21307 2003-07-29 Ravi Pratap <ravi@ximian.com>
21309 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21310 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21311 reference comparison.
21313 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21314 examine the ReturnType for equality - this is necessary in the
21315 cases of implicit and explicit operators whose signature also
21316 includes the return type.
21318 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21320 * namespace.cs: Cache the result of the namespace computation,
21321 instead of computing it every time.
21323 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21325 * decl.cs: Use a global arraylist that we reuse over invocations
21326 to avoid excesive memory consumption. Reduces memory usage on an
21327 mcs compile by one meg (45 average).
21329 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21330 private, work around that.
21332 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21334 * literal.cs (IntLiteral): Define Zero and One static literals.
21336 * cs-parser.jay (integer_literal): use static literals to reduce
21337 memory usage for the most used literals (0, 1 and -1). 211kb
21338 reduced in memory usage.
21340 Replace all calls to `new ArrayList' with `new
21341 ArrayList(4)' which is a good average number for most allocations,
21342 and also requires only 16 bytes of memory for its buffer by
21345 This reduced MCS memory usage in seven megabytes for the RSS after
21348 2003-07-28 Ravi Pratap <ravi@ximian.com>
21350 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21351 handle params methods the correct way by forming only one
21352 applicable set with params and normal methods in them. Earlier we
21353 were looking at params methods only if we found no normal methods
21354 which was not the correct thing to do.
21356 (Invocation.BetterFunction): Take separate arguments indicating
21357 when candidate and the best method are params methods in their
21360 This fixes bugs #43367 and #46199.
21362 * attribute.cs: Documentation updates.
21364 (CheckAttribute): Rename to CheckAttributeTarget.
21365 (GetValidPlaces): Rename to GetValidTargets.
21367 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21368 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21372 2003-07-28 Martin Baulig <martin@ximian.com>
21374 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21375 name when looking up the base class of a nested class. Fixes #46977.
21377 2003-07-26 Martin Baulig <martin@ximian.com>
21379 * expression.cs (Indexers.Indexer): New nested struct; contains
21380 getter, setter and the indexer's type.
21381 (Indexers.Properties): This is now an ArrayList of
21382 Indexers.Indexer's.
21383 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21384 indexer doesn't have any getters.
21386 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21387 for embedded property and indexer assignments.
21389 2003-07-26 Martin Baulig <martin@ximian.com>
21391 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21392 preprocessor directive is not the first non-whitespace character
21395 2003-07-26 Martin Baulig <martin@ximian.com>
21397 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21398 namespace parsing, follow the spec more closely.
21400 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21401 NamespaceEntry.Lookup().
21403 2003-07-25 Martin Baulig <martin@ximian.com>
21405 * MethodCore.cs (OverridesSomething): New public field; it's set
21406 from TypeContainer.DefineMembers if this method overrides
21407 something (which doesn't need to be a method). Fix #39462.
21409 2003-07-25 Ravi Pratap <ravi@ximian.com>
21411 * typemanager.cs (GetMembers): Ensure that the list of members is
21412 reversed. This keeps things in sync.
21414 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21415 find an AttributeUsage attribute.
21417 * expression.cs (Invocation.OverloadResolve): Perform the check
21418 which disallows Invoke to be directly called on a Delegate.
21420 (Error_InvokeOnDelegate): Report error cs1533.
21422 2003-07-25 Martin Baulig <martin@ximian.com>
21424 * expression.cs (Indexers.GetIndexersForType): Only look in the
21425 interface hierarchy if the requested type is already an
21426 interface. Fixes #46788 while keeping #46502 fixed.
21428 2003-07-25 Martin Baulig <martin@ximian.com>
21430 * class.cs (TypeContainer.DefineMembers): Check whether all
21431 readonly fields have been assigned and report warning CS0649 if
21434 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21437 2003-07-24 Ravi Pratap <ravi@ximian.com>
21439 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21440 returned from GetMethods to make things consistent with the
21441 assumptions MCS makes about ordering of methods.
21443 This should comprehensively fix bug #45127 and it does :-)
21445 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21446 ordering is actually reverse.
21448 * Clean up some debug messages I left lying around.
21450 * interface.cs (Populate*): Get rid of code which emits attributes
21451 since the stage in which we emit attributes is the 'Emit' stage,
21452 not the define stage.
21454 (Emit): Move attribute emission for interface members here.
21456 2003-07-22 Ravi Pratap <ravi@ximian.com>
21458 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21459 closely: we eliminate methods in base types when we have an
21460 applicable method in a top-level type.
21462 Please see section 14.5.5.1 for an exact description of what goes
21465 This fixes bug #45127 and a host of other related to corlib compilation.
21467 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21468 array is the method corresponding to the top-level type (this is
21469 because of the changes made to icall.c) so we change this
21472 (MethodGroupExpr.Name): This too.
21474 * typemanager.cs (GetElementType): New method which does the right
21475 thing when compiling corlib.
21477 * everywhere: Make use of the above in the relevant places.
21479 2003-07-22 Martin Baulig <martin@ximian.com>
21481 * cs-parser.jay (invocation_expression): Moved
21482 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21483 `cast_expression', but create a InvocationOrCast which later
21484 resolves to either an Invocation or a Cast.
21486 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21487 method; call this before EmitStatement() to make sure that this
21488 expression can be used as a statement.
21490 * expression.cs (InvocationOrCast): New class; resolves to either
21491 an Invocation or a Cast.
21493 * statement.cs (StatementExpression): Call ResolveStatement() on
21494 the ExpressionStatement before emitting it.
21496 2003-07-21 Martin Baulig <martin@ximian.com>
21498 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21499 `ref' and `out' attributes match; fixes #46220.
21500 (MemberAccess.ResolveMemberAccess): You can't reference a type
21501 through an expression; fixes #33180.
21502 (Indexers.GetIndexersForType): Don't return the indexers from
21503 interfaces the class implements; fixes #46502.
21505 2003-07-21 Martin Baulig <martin@ximian.com>
21507 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21508 CS0661 checks; fixes bug #30442.
21510 2003-07-21 Martin Baulig <martin@ximian.com>
21512 * decl.cs (AdditionResult): Added `Error'.
21514 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21516 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21517 makes cs0031.cs actually work.
21519 2003-07-20 Martin Baulig <martin@ximian.com>
21521 * namespace.cs: Fixed that bug which caused a crash when compiling
21522 the debugger's GUI.
21524 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21526 * typemanager.cs (LookupTypeReflection): Never expose types which
21527 are NotPublic, NestedPrivate, NestedAssembly, or
21528 NestedFamANDAssem. We used to return these, and later do a check
21529 that would report a meaningful error, but the problem is that we
21530 would not get the real match, if there was a name override.
21532 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21534 * namespace.cs (Namespace, Name): Do not compute the namespace
21535 name dynamically, compute it in the constructor. This reduced
21536 memory usage by 1697 KB.
21538 * driver.cs: Use --pause to pause at the end.
21540 2003-07-17 Peter Williams <peter@newton.cx>
21542 * Makefile: Change the name of the test target so that it doesn't
21543 conflict with the recursive test target.
21545 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21547 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21548 AddressOf): Do not use EmitThis, that was wrong, use the actual
21551 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21553 * class.cs (MethodData.Define): While checking if a method is an
21554 interface implementation, improve the test: If we are not public
21555 (use new test here: use the computed MethodAttributes directly,
21556 instead of the parsed modifier flags) check if the `implementing'
21557 method comes from an interface or not.
21559 * pending.cs (VerifyPendingMethods): Slightly better error
21562 * makefile: add test target that does the mcs bootstrap.
21564 2003-07-16 Ravi Pratap <ravi@ximian.com>
21566 * interface.cs (Define): Do nothing here since there are no
21567 members to populate etc. Move the attribute emission out of here
21568 since this was just totally the wrong place to put it. Attribute
21569 application happens during the 'Emit' phase, not in the 'Define'
21572 (Emit): Add this method and move the attribute emission here
21574 * rootcontext.cs (EmitCode): Call the Emit method on interface
21577 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21579 * expression.cs (OverloadResolve): Report error only if Location
21580 is not 'Null' which means that there was a probe going on.
21582 2003-07-14 Martin Baulig <martin@ximian.com>
21584 * expression.cs (ConditionalLogicalOperator): New public class to
21585 implement user defined conditional logical operators.
21586 This is section 14.11.2 in the spec and bug #40505.
21588 2003-07-14 Martin Baulig <martin@ximian.com>
21590 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21592 2003-07-14 Martin Baulig <martin@ximian.com>
21594 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21596 * ecore.cs (IVariable.VerifyFixed): New interface method.
21598 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21599 operator, check whether the variable is actually fixed. Fixes bug
21600 #36055. Set a variable definitely assigned when taking its
21601 address as required by the spec.
21603 * statement.cs (LocalInfo.IsFixed): New field.
21604 (LocalInfo.MakePinned): Set `IsFixed' to true.
21606 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21608 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21609 for .ctors, ensure that we only ask for members declared in the
21610 attribute type (BindingFlags.DeclaredOnly).
21614 * expression.cs (Error_WrongNumArguments): Report error 1501
21615 correctly the way CSC does.
21617 2003-07-13 Martin Baulig <martin@ximian.com>
21619 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21620 lookup on the fully qualified name, to make things like "X.X" work
21621 where "X.X" is a fully qualified type name, but we also have a
21622 namespace "X" in the using list. Fixes #41975.
21624 2003-07-13 Martin Baulig <martin@ximian.com>
21626 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21627 function. If we're a CompoundAssign, we need to create an embedded
21628 CompoundAssign, not an embedded Assign.
21629 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21632 2003-07-13 Martin Baulig <martin@ximian.com>
21634 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21635 work to fix bug #46088.
21637 2003-07-13 Ravi Pratap <ravi@ximian.com>
21639 * class.cs (Operator.Emit): Do not emit attributes here - it is
21640 taken care of by the Method class that we delegate too. This takes
21641 care of bug #45876.
21643 2003-07-10 Martin Baulig <martin@ximian.com>
21645 * expression.cs (TypeOfVoid): New class.
21646 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21648 2003-07-10 Martin Baulig <martin@ximian.com>
21650 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21653 2003-07-10 Martin Baulig <martin@ximian.com>
21655 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21656 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21658 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21660 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21662 2003-07-10 Martin Baulig <martin@ximian.com>
21664 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21665 of decimal. Fixes #42850.
21667 NOTE: I also fixed the created byte blob, but this doesn't work on
21668 the MS runtime and csc never produces any byte blobs for decimal
21671 2003-07-10 Martin Baulig <martin@ximian.com>
21673 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21674 structs; fixes #32068.
21675 (Block.AddChildVariableNames): Fixed #44302.
21677 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21679 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21681 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21683 * attribute.cs: And this test is onger needed.
21685 2003-07-08 Martin Baulig <martin@ximian.com>
21687 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21688 inaccessible types. Fixes #36313.
21690 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21692 * namespace.cs (NamespaceEntry): Create implicit entries for all
21693 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21694 implicit entries for N1.N2 and N1.
21696 2003-07-08 Martin Baulig <martin@ximian.com>
21698 Rewrote the handling of namespaces to fix a lot of the issues
21699 wrt. `using' aliases etc.
21701 * namespace.cs (Namespace): Splitted this class into a
21702 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21704 * typemanager.cs (TypeManager.IsNamespace): Removed.
21705 (TypeManager.ComputeNamespaces): Only compute namespaces from
21706 loaded assemblies here, not the namespaces from the assembly we're
21707 currently compiling.
21709 2003-07-08 Martin Baulig <martin@ximian.com>
21711 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21713 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21715 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21718 I thought about the memory savings here, but LookupTypeReflection
21719 is used under already very constrained scenarios. Compiling
21720 corlib or mcs only exposes one hit, so it would not really reduce
21721 any memory consumption.
21723 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21725 * typemanager.cs: fixes bug #45889 by only adding public types from
21726 other assemblies to the list of known types.
21728 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21730 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21731 on the type we resolved.
21733 2003-07-05 Martin Baulig <martin@ximian.com>
21735 * pending.cs (PendingImplementation.ParentImplements): Don't
21736 create the proxy if the parent is abstract.
21738 * class.cs (TypeContainer.DefineIndexers): Process explicit
21739 interface implementations first. Fixes #37714.
21741 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21743 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21744 defined recursively; but since we modify the input parameters
21745 (left is set to `this' temporarily), we reset this value if the
21746 left_is_explicit is false, which gives the original semantics to
21749 * literal.cs (NullPointer): new class used to represent a null
21750 literal in a pointer context.
21752 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21753 type is a pointer, use a NullPointer object instead of a
21754 NullLiteral. Closes 43687
21756 (ExplicitConversion): Convert pointer values using
21757 the conv opcode to the proper type.
21759 * ecore.cs (New): change ValueTypeVariable property into a method,
21760 that returns whether the valuetype is suitable for being used.
21762 * expression.cs (Binary.DoNumericPromotions): Only return if we
21763 the int constant was a valid uint, and we can return both left and
21764 right as uints. If not, we continue processing, to trigger the
21765 type conversion. This fixes 39018.
21767 * statement.cs (Block.EmitMeta): During constant resolution, set
21768 the CurrentBlock property on the emitcontext, so that we resolve
21769 constants propertly.
21771 2003-07-02 Martin Baulig <martin@ximian.com>
21773 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21774 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21776 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21777 than emitting it here.
21779 * statement.cs: Fixed some more flow analysis bugs.
21781 2003-07-02 Martin Baulig <martin@ximian.com>
21783 * class.cs (MethodData.Define): When implementing interface
21784 methods, set Final unless we're Virtual.
21786 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21787 check work for interface methods.
21789 2003-07-01 Martin Baulig <martin@ximian.com>
21791 * ecore.cs (EmitContext.This): Replaced this property with a
21792 GetThis() method which takes a Location argument. This ensures
21793 that we get the correct error location for a CS0188.
21795 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21797 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21798 ImplicitStandardConversion.
21800 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21802 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21804 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21807 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21809 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21812 (MethodData.Define): Turn off initlocals for unsafe methods.
21814 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21816 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21817 complete; Fixes #37521.
21819 * delegate.cs: Use Modifiers.TypeAttr to compute the
21820 TypeAttributes, instead of rolling our own. This makes the flags
21821 correct for the delegates.
21823 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21825 * class.cs (Constructor.Define): Set the private flag for static
21826 constructors as well.
21828 * cs-parser.jay (statement_expression): Set the return value to
21829 null, to avoid a crash when we catch an error.
21831 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21833 * cs-parser.jay: Applied patch from Jackson that adds support for
21834 extern and unsafe modifiers to destructor declarations.
21836 * expression.cs: Report error 21 if the user is trying to index a
21839 * driver.cs: Add an error message, suggested by the bug report.
21841 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21842 if we do not have a ": this ()" constructor initializer. Fixes 45149
21844 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21846 * namespace.cs: Add some information to reduce FAQs.
21848 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21850 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21851 underlying enumeration types. Fixes #43915.
21853 * expression.cs: Treat ushort/short as legal values to be used in
21854 bitwise operations.
21856 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21858 * delegate.cs: transfer custom attributes for paramenters from
21859 the delegate declaration to Invoke and BeginInvoke.
21861 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21863 * attribute.cs: handle custom marshalers and emit marshal info
21866 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21868 * makefile.gnu: Added anonymous.cs to the compiler sources.
21870 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21872 * iterators.cs: Change the name of the proxy class to include two
21875 * cs-parser.jay: Update grammar to include anonymous methods.
21877 * anonymous.cs: new file.
21879 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21881 * class.cs (Field.Define): Add missing test for pointers and
21884 2003-05-27 Ravi Pratap <ravi@ximian.com>
21886 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21887 we use the stobj opcode.
21889 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21890 since it wasn't the correct fix.
21892 It still is puzzling that we are required to use stobj for IntPtr
21893 which seems to be a ValueType.
21895 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21897 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21898 during regular simple name resolution. Now, the trick is that
21899 instead of returning for processing the simplename, we do a
21900 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21901 contextual lookup type). If a match is found, return that, if
21902 not, return for further composition.
21904 This fixes long-standing 30485.
21906 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21907 using the address to initialize an object, do an Stobj instead of
21908 using the regular Stelem.
21910 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21911 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21912 Because if we are a BaseIndexerAccess that value will be true.
21915 * statement.cs (GotoCase.Resolve): Return after reporting an
21916 error, do not attempt to continue.
21918 * expression.cs (PointerArithmetic.Emit): If our operand is a
21919 long, convert our constants to match the operand before
21920 multiplying. Convert to I type before adding. Fixes 43670.
21922 2003-05-14 Ravi Pratap <ravi@ximian.com>
21924 * enum.cs (ImplicitConversionExists) : Rename to
21925 ImplicitEnumConversionExists to remove ambiguity.
21927 * ecore.cs (NullCast): New type of cast expression class which
21928 basically is very similar to EmptyCast with the difference being
21929 it still is a constant since it is used only to cast a null to
21931 (eg. (string) null)
21933 * convert.cs (ImplicitReferenceConversion): When casting a null
21934 literal, we return a NullCast.
21936 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21937 should be around anymore.
21939 The renaming (reported was slightly wrong). Corrections:
21941 ConvertImplicitStandard -> ImplicitConversionStandard
21942 ConvertExplicitStandard -> ExplicitConversionStandard
21944 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21945 before passing them in !
21947 * convert.cs (ImplicitConversionStandard): When comparing for
21948 equal expr and target types, ensure that expr is not a
21951 In general, we must not be checking (expr_type ==
21952 target_type) in the top level conversion methods
21953 (ImplicitConversion, ExplicitConversion etc). This checking is
21954 done in the methods that they delegate to.
21956 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21958 * convert.cs: Move Error_CannotConvertType,
21959 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21960 ImplicitNumericConversion, ImplicitConversionExists,
21961 ImplicitUserConversionExists, StandardConversionExists,
21962 FindMostEncompassedType, FindMostSpecificSource,
21963 FindMostSpecificTarget, ImplicitUserConversion,
21964 ExplicitUserConversion, GetConversionOperators,
21965 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21966 TryImplicitIntConversion, Error_CannotConvertImplicit,
21967 ConvertImplicitRequired, ConvertNumericExplicit,
21968 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21969 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21972 Perform the following renames:
21974 StandardConversionExists -> ImplicitStandardConversionExists
21975 ConvertImplicit -> ImplicitConversion
21976 ConvertImplicitStandard -> ImplicitStandardConversion
21977 TryImplicitIntConversion -> ImplicitIntConversion
21978 ConvertImplicitRequired -> ImplicitConversionRequired
21979 ConvertNumericExplicit -> ExplicitNumericConversion
21980 ConvertReferenceExplicit -> ExplicitReferenceConversion
21981 ConvertExplicit -> ExplicitConversion
21982 ConvertExplicitStandard -> ExplicitStandardConversion
21984 2003-05-19 Martin Baulig <martin@ximian.com>
21986 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21987 (TypeInfo): Added support for structs having structs as fields.
21989 * ecore.cs (FieldExpr): Implement IVariable.
21990 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21991 VariableInfo for the field.
21993 2003-05-18 Martin Baulig <martin@ximian.com>
21995 * expression.cs (This.DoResolve): Report a CS0027 if we're
21996 emitting a field initializer.
21998 2003-05-18 Martin Baulig <martin@ximian.com>
22000 * expression.cs (This.ResolveBase): New public function.
22001 (This.DoResolve): Check for CS0188.
22003 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22006 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22007 `instance_expression' to null if we don't have any non-static
22010 2003-05-18 Martin Baulig <martin@ximian.com>
22012 Reworked the way how local variables and parameters are handled by
22013 the flow analysis code.
22015 * statement.cs (TypeInfo, VariableMap): New public classes.
22016 (VariableInfo): New public class. This is now responsible for
22017 checking whether a variable has been assigned. It is used for
22018 parameters and local variables.
22019 (Block.EmitMeta): Take the InternalParameters as argument; compute
22020 the layout of the flow vectors here.
22021 (Block.LocalMap, Block.ParameterMap): New public properties.
22022 (FlowBranching): The .ctor doesn't get the InternalParameters
22023 anymore since Block.EmitMeta() now computes the layout of the flow
22025 (MyStructInfo): This class is now known as `StructInfo' and nested
22026 in `TypeInfo'; we don't access this directly anymore.
22028 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22029 property and removed IsAssigned(), IsFieldAssigned(),
22030 SetAssigned() and SetFieldAssigned(); we now call them on the
22031 VariableInfo so we don't need to duplicate this code everywhere.
22033 * expression.cs (ParameterReference): Added `Block block' argument
22035 (LocalVariableReference, ParameterReference, This): The new
22036 VariableInfo class is now responsible for all the definite
22039 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22040 IsParameterAssigned, SetParameterAssigned): Removed.
22042 2003-05-18 Martin Baulig <martin@ximian.com>
22044 * typemanager.cs (InitCoreTypes): Try calling
22045 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22046 the 3-args-version. Corlib now also needs our `void_type'.
22047 (GetMethod): Added overloaded version which takes an optional
22048 `bool report_errors' to allow lookups of optional methods.
22050 2003-05-12 Martin Baulig <martin@ximian.com>
22052 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22053 only used for locals and not for parameters.
22055 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22057 * support.cs (InternalParameters.ParameterType): Return the
22058 ExternalType of the parameter.
22060 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22063 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22065 * class.cs (MethodData.Define): Do not set the `newslot' on
22066 interface members, if they are also flagged as "override".
22068 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22069 better code for ++i and i++. This only works for static fields
22070 and local variables.
22072 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22073 want to pull the DeclSpace out of the builder_to_declspace instead
22074 of the TypeBuilder (like in TypeContainer.FindMembers).
22076 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22077 instead of LookupTypeContainer. Fixes the crash on .NET for
22078 looking up interface members.
22080 * const.cs: Create our own emit context during the Definition
22081 stage, so that constants are evaluated in the proper context, when
22082 a recursive definition happens.
22084 2003-05-11 Martin Baulig <martin@ximian.com>
22086 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22087 new block for a switch section.
22088 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22089 the adding/lookup in the switch block. Fixes #39828.
22091 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22093 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22094 functionality: I needed to convert the data after I had performed
22095 the add/sub operation into the operands type size.
22097 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22098 pass the type for the box operation, otherwise the resulting
22099 object would have been of type object.
22101 (BoxedCast): Add constructor to specify the type to box as.
22103 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22105 * iterators.cs: I was reusing the `count' variable inadvertently,
22106 take steps to not allow this to happen.
22108 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22110 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22111 by creating an array at the point where the params starts and
22112 putting all those arguments there, then adjusting the size of the
22115 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22117 * expression.cs (New.AddressOf): Implement interface
22118 IMemoryLocation. This is used when the `new' operator is used in
22119 the context of an invocation to a method on a value type.
22121 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22124 * namespace.cs: Also check the using aliases here.
22126 * driver.cs: Move the test for using validity after the types have
22127 been entered, so we do a single pass that also includes the using
22130 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22131 in the regular case. CreateSiblingForFinally is doing extra
22134 * attribute.cs (GetAttributeArgumentExpression): Store the result
22135 on an out value, and use the return value to indicate failure
22136 instead of using null (which is a valid return for Constant.GetValue).
22138 * statement.cs: Perform the analysis flow for the increment
22139 portion after the statement, because this will be the real flow of
22140 execution. Fixes #42385
22142 * codegen.cs (EmitContext.EmitArgument,
22143 EmitContext.EmitStoreArgument): New helper functions when the
22144 RemapToProxy flag is set.
22146 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22149 Add support for remapping parameters.
22151 * iterators.cs: Propagate parameter values; Store parameter
22152 values in the proxy classes.
22154 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22156 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22157 need a proxy reference; I do not know what I was thinking
22159 * cs-parser.jay (constructor_initializer): catch another error,
22160 and display nice message.
22162 (field_declaration): catch void field declaration
22163 to flag a better error.
22165 * class.cs (MemberBase.CheckBase): Report an error instead of a
22166 warning if a new protected member is declared in a struct.
22167 (Field.Define): catch the error of readonly/volatile.
22169 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22171 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22172 volatile variable is taken
22174 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22176 * statement.cs (Fixed.Resolve): Report an error if we are not in
22179 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22181 * typemanager.cs: reuse the code that handles type clashes for
22182 delegates and enumerations.
22184 * class.cs (Report28): Always report.
22186 * expression.cs (EncodeAsAttribute): Allow nulls here.
22188 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22190 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22191 the functionality for testing whether an expression is valid for
22192 an attribute here. Also handle the case of arrays of elements
22195 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22196 encoding a linear array into an array of objects that are suitable
22197 to be passed to an CustomAttributeBuilder.
22199 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22201 * ecore.cs: (FieldExpr): Handle field remapping here.
22203 * iteratators.cs: Pass the instance variable (if the method is an
22204 instance method) to the constructors, so we can access the field
22205 variables on the class.
22207 TODO: Test this with structs. I think the THIS variable on
22208 structs might have to be a pointer, and not a refenrece
22210 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22212 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22213 local variables to fields in a proxy class.
22215 * iterators.cs (PopulateProxy): Rename our internal fields to
22217 Create a <THIS> field if we are an instance method, so we can
22218 reference our parent container variables.
22219 (MapVariable): Called back from the EmitContext code to enter a
22220 new variable to field mapping into the proxy class (we just create
22224 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22225 for using the remapped locals to fields.
22227 I placed the code here, because that gives the same semantics to
22228 local variables, and only changes the Emit code.
22230 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22231 statements inside iterators.
22232 (VariableInfo): Add a FieldBuilder for the cases when we are
22233 remapping local variables to fields in a proxy class
22235 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22236 current_block != null.
22238 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22239 not cope with strings, as it has been moved to the
22240 TableSwitchEmit. Fixed bug in switch generation.
22242 * expression.cs (New.DoResolve): Provide more context for the user
22243 when reporting an error.
22245 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22248 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22249 check the permissions for it. Note than in a type-resolution
22250 context the check was already present in DeclSpace.ResolveType,
22251 but was missing from the MemberAccess.
22253 (ArrayCreation.CheckIndices): warn if the user has
22254 more nested levels of expressions, but there are no more
22255 dimensions specified. Avoids crash on bug 41906.
22257 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22259 * statement.cs (Block): replace Implicit bool, for a generic
22261 New flag: `Unchecked'. This is used during the EmitMeta phase
22262 (which is out-of-line with the regular Resolve/Emit process for a
22263 statement, as this is done ahead of time, but still gets a chance
22264 to call constant resolve).
22266 (Block.Flags): new enum for adding a new flag.
22268 (Block.EmitMeta): track the state of unchecked.
22270 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22271 to enable constant resolution to work there as well.
22273 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22275 * typemanager.cs (ienumerable_type): Also look up
22276 System.Collections.IEnumerable.
22278 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22280 TODO: Test more than one conditional per method.
22282 * class.cs (Indexer.Define): Report the location where the user is
22283 referencing the unsupported feature.
22285 (MethodData): Overload the use of `conditionals' to
22286 minimize the creation of needless ArrayLists. This saves roughly
22287 212kb on my machine.
22289 (Method): Implement the new IIteratorContainer interface.
22290 (Method.SetYields): Implement the method by setting the ModFlags
22291 to contain METHOD_YIELDS.
22293 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22294 which just got set to null.
22296 * iterators.cs: New file.
22298 (Yield, YieldBreak): New statements.
22300 * statement.cs (Return.Resolve): Flag an error if we are used in
22301 an iterator method.
22303 * codegen.cs (InIterator): New flag set if the code is being
22304 compiled in an iterator method.
22306 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22307 internal modifier, and we just use it to avoid adding extra
22308 fields, as this is seldom used.
22310 * cs-parser.jay: Add yield_statement (yield and yield break).
22312 * driver.cs: New flag -v2 to turn on version 2 features.
22314 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22315 hashtable when v2 is enabled.
22317 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22319 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22320 there is already a namespace defined with this name.
22322 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22323 people upgraded their corlibs.
22325 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22326 always use fully qualified types, no need to use the compiler
22329 (TypeManager.IsNamespace): Use binarysearch.
22331 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22332 AddDelegate): I did not quite use the new IsValid API properly: I
22333 have to pass the short-name and the fullname. I was passing only
22334 the basename instead of the fullname sometimes.
22336 (TypeContainer.DefineType): call NamespaceClash.
22338 * interface.cs (Interface.DefineType): use NamespaceClash before
22341 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22344 * enum.cs: (Enum.DefineType): use NamespaceClash before
22347 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22348 speed increase. First, use the negative_hits cache when we get a
22349 negative. Second, add the type with its full original name
22350 instead of the new . and + encoded name (reflection uses + to
22351 separate type from a nested type). Use LookupTypeReflection
22352 directly which bypasses the type->name hashtable (that we already
22353 know does not contain the type.
22355 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22356 location/container type.
22358 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22360 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22362 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22364 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22365 method is being referenced in the method group from a static
22366 context, and report error 120 if so.
22368 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22371 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22372 is created, we create the A namespace).
22374 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22377 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22379 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22380 invocation to ModuleBuilder.GetType with the same values will
22381 return a new type instance, so we need to cache its return
22384 * expression.cs (Binary.ResolveOperator): Only allow the compare
22385 operators on enums if they are of the same type.
22387 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22388 types of ValueType on their own case. Before we were giving them
22389 the same treatment as objects.
22391 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22392 fullname. Short name is used to compare against container name.
22393 Fullname is used to check against defined namespace names.
22395 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22396 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22398 (Method.CheckBase): Call parent.
22399 (MemberBase.CheckBase): Check for protected members on sealed
22401 (PropertyBase.CheckBase): Call parent.
22402 (Field.Define): Call parent.
22404 * report.cs: Negative error codes are now mapped to 8000 - code,
22405 so that the display is render more nicely.
22407 * typemanager.cs: Do not use try/catch, instead report a regular
22410 (GetPointerType, GetReferenceType): These methods provide
22411 mechanisms to obtain the T* and T& from a T. We had the code
22412 previously scattered around the code base, and it also used
22413 TypeManager.LookupType that would go through plenty of caches.
22414 This one goes directly to the type source.
22416 In some places we did the Type.GetType followed by
22417 ModuleBuilder.GetType, but not in others, so this unifies the
22418 processing as well.
22420 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22421 statements now that we have namespace information.
22423 * typemanager.cs (IsNamespace): New method, returns whether the
22424 string presented is a namespace or not.
22426 (ComputeNamespaces): New public entry point, computes the list of
22427 available namespaces, using the GetNamespaces API call in Mono, or
22428 the slower version in MS.NET.
22430 Now before we start the semantic analysis phase, we have a
22431 complete list of namespaces including everything that the user has
22434 Deleted old code to cache namespaces in .nsc files.
22436 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22438 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22439 class/struct location definition Location for the implicit
22440 constructor location.
22442 (Operator.Define): Use the location of the operator for the
22443 implicit Method definition.
22445 (Constructor.Emit): use the constructor location for the implicit
22446 base initializer constructor.
22448 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22449 and the Expression class now contains two new methods:
22451 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22452 isolate type lookup from the rest of the resolution process.
22454 Since we use Expressions to hold type definitions due to the way
22455 we parse the input we have historically overloaded Resolve to
22456 perform the Type lookups if a special flag is passed. Now this is
22457 eliminated and two methods take their place.
22459 The differences in the two methods between xStep and xTerminal is
22460 that xStep is involved in our current lookup system that uses
22461 SimpleNames to compose a name, while xTerminal is used just to
22462 catch the case where the simplename lookup failed.
22464 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22466 * expression.cs (ResolveMemberAccess): Remove redundant code.
22467 TypeExpr expressions are always born fully resolved.
22469 * interface.cs (PopulateMethod): Do not lookup the types twice.
22470 We were doing it once during SemanticAnalysis and once during
22473 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22474 in local variable type definitions, were being returned as a
22475 SimpleName (we decomposed everything into a string), that is
22476 because primary_expression was being used instead of a type in the
22477 grammar (reduce/reduce conflicts).
22479 The part that was wrong is that we converted the expression into a
22480 string (an oversimplification in one hand, compounded with primary
22481 expressions doing string concatenation).
22487 Would return "A.B.C[]" as a SimpleName. This stopped things like
22488 using clauses from working on this particular context. And a type
22489 was being matched directly against "A.B.C[]".
22491 We now use the correct approach, and allow for ComposedCast to be
22492 part of the unary expression. So the "A.B.C []" become a composed
22493 cast of "A.B.C" (as a nested group of MemberAccess with a
22494 SimpleName at the end) plus the rank composition "[]".
22498 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22500 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22501 for the access level checking.
22503 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22504 `TypeContainer container', because I kept getting confused when I
22505 was debugging this code.
22507 * expression.cs (Indexers): Instead of tracking getters/setters,
22508 we now track them in parallel. We create one arraylist less, but
22509 most importantly it is possible now for the LValue code to find a
22510 matching get for a set.
22512 (IndexerAccess.DoResolveLValue): Update the code.
22513 GetIndexersForType has been modified already to extract all the
22514 indexers from a type. The code assumed it did not.
22516 Also make the code set the correct return type for the indexer.
22517 This was fixed a long time ago for properties, but was missing for
22518 indexers. It used to be void_type.
22520 (Binary.Emit): Test first for doubles instead of
22521 floats, as they are more common.
22523 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22524 when dealing with floats and the <=, >= operators. This fixes bug
22527 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22528 to load the array value by emitting a load on the foreach variable
22529 type. This was incorrect.
22531 We now emit the code to load an element using the the array
22532 variable type, and then we emit the conversion operator.
22536 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22538 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22540 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22542 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22543 test for protection before we test for signatures.
22545 (MethodSignature.ToString): implement.
22547 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22548 to the case where we reduced into a LongConstant.
22550 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22551 depend on whether the information is acurrate, because the
22552 Microsoft runtime will always claim that the array type is public,
22553 regardless of the real state.
22555 If the type is a pointer, another problem happens: the type is
22556 reported as non-public in Microsoft.
22558 In both cases we have to call CheckAccessLevel recursively with
22559 the underlying type as the argument to be tested.
22561 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22563 * assign.cs (Assign.Emit): If we are dealing with a compound
22564 assignment expression, we should use the code path that stores the
22565 intermediate result in a temporary value. This fixes #40903.
22567 *expression.cs (Indirection.ToString): Provide ToString method for
22570 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22572 * class.cs: Null out fields holding references to Block objects so
22573 they can be garbage collected.
22575 * expression.cs (OverloadResolve): Remove unused local.
22577 2003-04-07 Martin Baulig <martin@ximian.com>
22579 * codegen.cs (EmitContext.CurrentFile): New public field.
22580 (EmitContext.Mark): Use the CurrentFile to check whether the
22581 location is in the correct file.
22582 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22584 2003-04-07 Martin Baulig <martin@ximian.com>
22586 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22588 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22589 location. [FIXME: The location argument which gets passed to this
22590 method is sometimes wrong!]
22592 2003-04-07 Nick Drochak <ndrochak@gol.com>
22594 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22596 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22598 * expression.cs (Indirection.EmitAssign): We were using the
22599 temporary, but returning immediately instead of continuing the
22602 2003-04-06 Martin Baulig <martin@ximian.com>
22604 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22605 if it's a nested child, but also deriving from the outer class.
22608 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22609 nested child, but also deriving from the outer class. See
22611 (FilterWithClosure): We may access private members of the outer
22612 class if we're a nested child and deriving from the outer class.
22613 (RealMemberLookup): Only set `closure_private_ok' if the
22614 `original_bf' contained BindingFlags.NonPublic.
22616 2003-04-05 Martin Baulig <martin@ximian.com>
22618 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22620 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22622 * class.cs (Event.Define): Do not allow abstract events to have
22625 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22627 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22628 block in event declarations.
22630 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22631 value type, get its address.
22633 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22634 leaving a class on the stack instead of a boolean value (int
22635 0/1). Change the code so we compare against null, and then the
22636 result against zero.
22638 * class.cs (TypeContainer.GetClassBases): We were checking for the
22639 parent class being sealed too late.
22641 * expression.cs (Binary.Emit): For <= and >= when dealing with
22642 floating point values, use cgt.un and clt.un instead of cgt and
22645 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22647 * statement.cs: Apply the same optimization as MS: skip the
22648 GetEnumerator returning an IEnumerator, and use the one returning a
22649 CharEnumerator instead. This allows us to avoid the try-finally block
22652 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22654 * cs-parser.jay: Attributes cannot be applied to
22655 namespaces. Fixes #40473
22657 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22660 (Add*): check if the name is valid using the full name for constants,
22661 fields, properties and events.
22663 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22665 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22666 char constants to be part of the enumeration.
22668 * expression.cs (Conditional.DoResolve): Add support for operator
22669 true. Implements the missing functionality from 14.12
22671 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22672 operator true/false as required by the spec.
22674 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22675 implicit conversion to boolean.
22677 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22678 also one where the type implements `operator true'.
22680 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22681 get an expression that will invoke operator true based on an
22684 (GetConversionOperators): Removed the hack that called op_True
22687 (Expression.ResolveBoolean): Move this from Statement.
22689 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22691 * ecore.cs (FieldExpr): do not allow initialization of initonly
22692 fields on derived classes
22694 2003-03-13 Martin Baulig <martin@ximian.com>
22696 * statement.cs (Block.Emit): Call ig.BeginScope() and
22697 ig.EndScope() when compiling with debugging info; call
22698 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22700 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22702 * expression.cs (Indexers): Do not construct immediately, allow
22703 for new members to be appended as we go. Fixes 38143
22705 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22707 * expression.cs: save/restore context when resolving an unchecked
22710 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22712 * cfold.cs: Catch division by zero in modulus operator during
22715 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22717 * interface.cs (Interface.DefineMembers): Avoid defining members
22720 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22722 * driver.cs: handle the +/- options for -noconfig
22724 * statement.cs (Unckeched.Resolve): Also track the state of
22725 unchecked in the Resolve phase.
22727 2003-02-27 Martin Baulig <martin@ximian.com>
22729 * ecore.cs (Expression.MemberLookup): Don't create a
22730 MethodGroupExpr for something which is not a method. Fixes #38291.
22732 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22734 * class.cs (MemberBase.CheckParameters): Also check that the type
22735 is unmanaged if it is a pointer.
22737 * expression.cs (SizeOf.Resolve): Add location information.
22739 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22740 a managed type is declared.
22742 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22743 parameter modifiers as well. Fixes bug 38606
22745 * class.cs: Very sad. Am backing out the speed up changes
22746 introduced by the ArrayList -> Array in the TypeContainer, as they
22747 were not actually that much faster, and introduced a bug (no error
22748 reports on duplicated methods).
22750 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22751 source first, this will guarantee that we have a valid expression
22752 before calling in lower levels functions that will require a
22753 resolved object. Then use this original_source in the
22754 target.ResolveLValue instead of the original source that was
22757 Another change. Use target.Resolve instead of LValueResolve.
22758 Although we are resolving for LValues, we will let the Assign code
22759 take care of that (it will be called again from Resolve). This
22760 basically allows code like this:
22762 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22763 class Y { void A (X x) { x [0] += o; }
22765 The problem was that the indexer was trying to resolve for
22766 set_Item (idx, object o) and never finding one. The real set_Item
22767 was set_Item (idx, X). By delaying the process we get the right
22772 2003-02-23 Martin Baulig <martin@ximian.com>
22774 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22775 while calling DoEmit ().
22777 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22778 source files; if you use the #line directive inside a method, the
22779 compiler stops emitting line numbers for the debugger until it
22780 reaches the end of the method or another #line directive which
22781 restores the original file.
22783 2003-02-23 Martin Baulig <martin@ximian.com>
22785 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22787 2003-02-23 Martin Baulig <martin@ximian.com>
22789 * statement.cs (Block.AddChildVariableNames): We need to call this
22790 recursively, not just for our immediate children.
22792 2003-02-23 Martin Baulig <martin@ximian.com>
22794 * class.cs (Event.Define): Always make the field private, like csc does.
22796 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22797 actually work, fixes bug #37521.
22799 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22801 * delegate.cs: When creating the various temporary "Parameters"
22802 classes, make sure that we call the ComputeAndDefineParameterTypes
22803 on those new parameters (just like we do with the formal ones), to
22804 allow them to be resolved in the context of the DeclSpace.
22806 This fixes the bug that Dick observed in Bugzilla #38530.
22808 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22810 * expression.cs (ResolveMemberAccess): When resolving a constant,
22811 do not attempt to pull a constant if the value was not able to
22812 generate a valid constant.
22814 * const.cs (LookupConstantValue): Do not report more errors than required.
22816 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22818 * expression.cs: fixes bug #38328.
22820 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22822 * class.cs: Changed all the various members that can be part of a
22823 class from being an ArrayList to be an Array of the right type.
22824 During the DefineType type_list, interface_list, delegate_list and
22825 enum_list are turned into types, interfaces, delegates and enums
22828 And during the member population, indexer_list, event_list,
22829 constant_list, field_list, instance_constructor_list, method_list,
22830 operator_list and property_list are turned into their real arrays.
22832 Although we could probably perform this operation earlier, for
22833 good error reporting we need to keep the lists and remove the
22834 lists for longer than required.
22836 This optimization was triggered by Paolo profiling the compiler
22837 speed on the output of `gen-sample-program.pl' perl script.
22839 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22840 not crash in methods like MemberLookupFailed that use this field.
22842 This problem arises when the compiler fails to resolve a type
22843 during interface type definition for example.
22845 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22847 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22848 inherit from System.Object, so we have to stop at null, not only
22849 when reaching System.Object.
22851 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22853 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22854 DeclaredOnly because the parent indexer might have had a different
22855 name, but did not loop until the top of the hierarchy was reached.
22857 The problem this one fixes is 35492: when a class implemented an
22858 indexer from an interface, we were getting the interface method
22859 (which was abstract) and we were flagging an error (can not invoke
22862 This also keeps bug 33089 functioning, and test-148 functioning.
22864 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22865 out if a method is special is to see if it is declared in a
22866 property or event, or whether it is one of the predefined operator
22867 names. This should fix correctly #36804.
22869 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22871 The goal here is to remove the dependency on EmptyCast.Peel ().
22872 Killing it completely.
22874 The problem is that currently in a number of places where
22875 constants are expected, we have to "probe" for an EmptyCast, and
22876 Peel, which is not the correct thing to do, as this will be
22877 repetitive and will likely lead to errors.
22879 The idea is to remove any EmptyCasts that are used in casts that
22880 can be reduced to constants, so we only have to cope with
22883 This bug hunt was triggered by Bug 37363 and the desire to remove
22884 the duplicate pattern where we were "peeling" emptycasts to check
22885 whether they were constants. Now constants will always be
22888 * ecore.cs: Use an enumconstant here instead of wrapping with
22891 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22892 throwing me off. By handling this we can get rid of a few hacks.
22894 * statement.cs (Switch): Removed Peel() code.
22896 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22898 * class.cs: Location information for error 508
22900 * expression.cs (New.DoResolve): Add a guard against double
22901 resolution of an expression.
22903 The New DoResolve might be called twice when initializing field
22904 expressions (see EmitFieldInitializers, the call to
22905 GetInitializerExpression will perform a resolve on the expression,
22906 and later the assign will trigger another resolution
22908 This leads to bugs (#37014)
22910 * delegate.cs: The signature for EndInvoke should contain any ref
22911 or out parameters as well. We were not doing this in the past.
22913 * class.cs (Field.Define): Do not overwrite the type definition
22914 inside the `volatile' group. Turns out that volatile enumerations
22915 were changing the type here to perform a validity test, which
22918 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22920 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22921 and structs, we do not want to load the instance variable
22923 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22924 enum_type has to be handled like an object reference (implicit
22925 conversions exists from this to object), but the regular IsClass
22926 and IsValueType tests will never return true for this one.
22928 Also we use TypeManager.IsValueType instead of type.IsValueType,
22929 just for consistency with the rest of the code (this is only
22930 needed if we ever use the construct exposed by test-180.cs inside
22931 corlib, which we dont today).
22933 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22935 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22938 2003-02-09 Martin Baulig <martin@ximian.com>
22940 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22941 (Namespace.DefineNamespaces): New static public method; this is
22942 called when we're compiling with debugging to add all namespaces
22943 to the symbol file.
22945 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22946 pass it to the Namespace's .ctor.
22948 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22949 and MethodBase arguments; pass the namespace ID to the symwriter;
22950 pass the MethodBase instead of the token to the symwriter.
22951 (SymbolWriter.DefineNamespace): New method to add a namespace to
22954 2003-02-09 Martin Baulig <martin@ximian.com>
22956 * symbolwriter.cs: New file. This is a wrapper around
22957 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22958 methods here in near future.
22960 2003-02-09 Martin Baulig <martin@ximian.com>
22962 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22963 ILGenerator.MarkSequencePoint() which are actually used by the
22966 2003-02-09 Martin Baulig <martin@ximian.com>
22968 * location.cs (SourceFile): New public sealed class. This
22969 contains the name and an index which is used in the location's token.
22970 (Location): Reserve an appropriate number of bits in the token for
22971 the source file instead of walking over that list, this gives us a
22972 really huge performance improvement when compiling with debugging.
22974 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22975 `SourceFile' argument instead of a string.
22976 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22977 but don't parse/tokenize here, we need to generate the list of all
22978 source files before we do that.
22979 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22982 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22983 instead of a string.
22985 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22988 2003-02-09 Martin Baulig <martin@ximian.com>
22990 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22991 filename on `#line default'.
22993 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22995 * statement.cs: don't clear the pinned var when the fixed statement
22996 returns from the method (fixes bug#37752).
22998 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23000 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23003 2003-02-07 Martin Baulig <martin@ximian.com>
23005 * driver.cs: Removed the `--debug-args' command line argument.
23007 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23008 automatically by the AsssemblyBuilder.
23009 (CodeGen.InitializeSymbolWriter): We don't need to call any
23010 initialization function on the symbol writer anymore. This method
23011 doesn't take any arguments.
23013 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23015 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23016 from referenced assemblies as well.
23018 2003-02-02 Martin Baulig <martin@ximian.com>
23020 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23022 2003-02-02 Martin Baulig <martin@ximian.com>
23024 * class.cs (Constructor.Emit): Open the symbol writer before
23025 emitting the constructor initializer.
23026 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23027 single-stepping through constructor initializers.
23029 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23031 * class.cs: Handle error 549: do not allow virtual methods in
23034 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23036 * decl.cs: Check access levels when resolving types
23038 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23040 * statement.cs: Add parameters and locals set in catch blocks that might
23041 return to set vector
23043 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23045 * class.cs (Operator): Set the SpecialName flags for operators.
23047 * expression.cs (Invocation.DoResolve): Only block calls to
23048 accessors and operators on SpecialName methods.
23050 (Cast.TryReduce): Handle conversions from char constants.
23053 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23055 * statement.cs: small memory and time optimization in FlowBranching.
23057 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23059 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23060 problem that the last fix but in the other sid (Set).
23062 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23063 access when there is no indexer in the hierarchy.
23065 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23067 * class.cs: Combine some if statements.
23069 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23071 * driver.cs: fixed bug #37187.
23073 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23075 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23076 any indexer, it's needed to build a list with all the indexers in the
23077 hierarchy (AllGetters), else we have problems. Fixes #35653.
23079 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23081 * class.cs (MethodData.Define): It is wrong for an interface
23082 implementation to be static in both cases: explicit and implicit.
23083 We were only handling this in one case.
23085 Improve the if situation there to not have negations.
23087 * class.cs (Field.Define): Turns out that we do not need to check
23088 the unsafe bit on field definition, only on usage. Remove the test.
23090 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23092 * driver.cs: use assembly.Location instead of Codebase (the latest
23093 patch made mcs fail when using MS assemblies).
23095 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23097 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23098 get the path to *corlib.dll.
23100 2003-01-21 Nick Drochak <ndrochak@gol.com>
23104 * typemanager.cs: Remove compiler warnings
23106 2003-01-20 Duncan Mak <duncan@ximian.com>
23108 * AssemblyInfo.cs: Bump the version number to 0.19.
23110 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23112 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23114 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23116 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23118 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23120 * cs-parser.jay: Small fix: we were not comparing the constructor
23121 name correctly. Thanks to Zoltan for the initial pointer.
23123 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23125 * cs-tokenizer.cs: Set file name when specified with #line
23127 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23129 * cs-parser.jay: Only perform the constructor checks here if we
23130 are named like the class; This will help provider a better
23131 error. The constructor path is taken when a type definition is
23132 not found, but most likely the user forgot to add the type, so
23133 report that rather than the constructor error.
23135 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23137 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23140 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23142 * cs-parser.jay: Add cleanup call.
23144 2003-01-13 Duncan Mak <duncan@ximian.com>
23146 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23147 consistent with other methods.
23149 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23151 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23153 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23155 * attribute.cs: only set GuidAttr to true when we have a
23158 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23162 * typemanager.cs: fixes to allow mcs compile corlib with the new
23163 Type.IsSubclassOf fix.
23165 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23167 * expression.cs (LocalVariableReference.DoResolve): Classify a
23168 constant as a value, not as a variable. Also, set the type for
23171 * cs-parser.jay (fixed_statement): take a type instead of a
23172 pointer_type, so we can produce a better error message later.
23174 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23177 (For.DoEmit): Make inifinite loops have a
23178 non-conditional branch back.
23180 (Fixed.DoEmit): First populate the pinned variables, then emit the
23181 statement, then clear the variables. Before I was emitting the
23182 code once for each fixed piece.
23185 2003-01-08 Martin Baulig <martin@ximian.com>
23187 * statement.cs (FlowBranching.MergeChild): A break in a
23188 SWITCH_SECTION does not leave a loop. Fixes #36155.
23190 2003-01-08 Martin Baulig <martin@ximian.com>
23192 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23193 lives in the same number space than `param_map'. Fixes #36154.
23195 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23197 * cs-parser.jay (constructor_declaration): Set the
23198 Constructor.ModFlags before probing for it. This makes the
23199 compiler report 514, 515 and 132 (the code was there, but got
23202 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23203 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23204 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23206 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23208 * enum.cs: create the enum static fields using the enum type.
23210 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23212 * class.cs: don't try to create the ParamBuilder for the return
23213 type if it's not needed (and handle it breaking for the ms runtime
23216 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23218 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23220 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23222 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23223 the command. This showed up while compiling the JANET source
23224 code, which used \r as its only newline separator.
23226 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23228 * class.cs (Method.Define): If we are an operator (because it
23229 reuses our code), then set the SpecialName and HideBySig. #36128
23231 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23233 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23234 exception, report error 120 `object reference required'.
23236 * driver.cs: Add --pause option, used during to measure the size
23237 of the process as it goes with --timestamp.
23239 * expression.cs (Invocation.DoResolve): Do not allow methods with
23240 SpecialName to be invoked.
23242 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23244 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23245 number before adding it.
23247 2002-12-21 Ravi Pratap <ravi@ximian.com>
23249 * ecore.cs (StandardImplicitConversion): When in an unsafe
23250 context, we allow conversion between void * to any other pointer
23251 type. This fixes bug #35973.
23253 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23255 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23256 is not thrown when extensionless outputs are used
23258 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23260 * rootcontext.cs: fixed compilation of corlib.
23262 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23264 * attribute.cs (Attributes.Contains): Add new method.
23266 * class.cs (MethodCore.LabelParameters): if the parameter is an
23267 `out' parameter, check that no attribute `[In]' has been passed.
23269 * enum.cs: Handle the `value__' name in an enumeration.
23271 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23273 * decl.cs: Added special case to allow overrides on "protected
23276 2002-12-18 Ravi Pratap <ravi@ximian.com>
23278 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23279 since it makes much more sense.
23281 (Attributes.ctor): Don't require a Location parameter.
23283 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23285 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23286 since we already have that information per attribute.
23288 * everywhere : make appropriate changes.
23290 * class.cs (LabelParameters): Write the code which actually
23291 applies attributes to the return type. We can't do this on the MS
23292 .NET runtime so we flag a warning in the case an exception is
23295 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23297 * const.cs: Handle implicit null conversions here too.
23299 2002-12-17 Ravi Pratap <ravi@ximian.com>
23301 * class.cs (MethodCore.LabelParameters): Remove the extra
23302 Type [] parameter since it is completely unnecessary. Instead
23303 pass in the method's attributes so that we can extract
23304 the "return" attribute.
23306 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23308 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23309 of ignoring it and letting the compile continue.
23311 * typemanager.cs (ChangeType): use an extra argument to return an
23312 error condition instead of throwing an exception.
23314 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23316 * expression.cs (Unary.TryReduce): mimic the code for the regular
23317 code path. Perform an implicit cast in the cases where we can
23318 implicitly convert to one of the integral types, and then reduce
23319 based on that constant. This fixes bug #35483.
23321 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23323 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23325 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23327 * namespace.cs: fixed bug #35489.
23329 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23331 * class.cs: Remove some dead code.
23333 * cs-parser.jay: Estimate the number of methods needed
23334 (RootContext.MethodCount);
23336 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23337 numbers instead of StringBuilders.
23339 * support.cs (PtrHashtable): Add constructor with initial size;
23340 We can now reduce reallocations of the method table.
23342 2002-12-10 Ravi Pratap <ravi@ximian.com>
23344 * attribute.cs (ApplyAttributes): Keep track of the emitted
23345 attributes on a per-target basis. This fixes bug #35413.
23347 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23349 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23350 default to the Windows 1252 encoding.
23352 (UnixParseOption): Support version, thanks to Alp for the missing
23355 * AssemblyInfo.cs: Add nice assembly information.
23357 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23360 * cs-parser.jay: Allow a trailing comma before the close bracked
23361 in the attribute_section production.
23363 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23364 address of the instance was being taken, I will take this out,
23365 because we take the address of the object immediately here.
23367 2002-12-09 Ravi Pratap <ravi@ximian.com>
23369 * typemanager.cs (AreMultipleAllowed): Take care of the most
23370 obvious case where attribute type is not in the current assembly -
23373 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23375 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23376 definitions, instead of doing that afterwards.
23378 Also we use a nice little hack, depending on the constructor, we
23379 know if we are a "composed" name or a simple name. Hence, we
23380 avoid the IndexOf test, and we avoid
23382 * codegen.cs: Add code to assist in a bug reporter to track down
23383 the source of a compiler crash.
23385 2002-12-07 Ravi Pratap <ravi@ximian.com>
23387 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23388 types have been emitted for a given element and flag an error
23389 if something which does not have AllowMultiple set is used more
23392 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23393 attribute types and their corresponding AllowMultiple properties
23395 (AreMultipleAllowed): Check the property for a given type.
23397 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23398 property in the case we have a TypeContainer.
23400 (Attributes.AddAttribute): Detect duplicates and just skip on
23401 adding them. This trivial fix catches a pretty gross error in our
23402 attribute emission - global attributes were being emitted twice!
23404 Bugzilla bug #33187 is now fixed.
23406 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23408 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23409 instead of pp_and).
23411 * expression.cs (Binary.ResolveOperator): I can only use the
23412 Concat (string, string, string) and Concat (string, string,
23413 string, string) if the child is actually a concatenation of
23416 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23418 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23419 context where we need a 2-character lookahead.
23421 * pending.cs (PendingImplementation): Rework so we can keep track
23422 of interface types all the time, and flag those which were
23423 implemented by parents as optional.
23425 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23427 * expression.cs (Binary.ResolveOperator): Use
23428 String.Concat(string,string,string) or
23429 String.Concat(string,string,string,string) when possible.
23431 * typemanager: More helper methods.
23434 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23436 * pending.cs: remove the bogus return from GetMissingInterfaces()
23437 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23439 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23441 * namespace.cs: avoid duplicated 'using xxx' being added to
23442 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23443 when we get more than one 'using' statement for the same namespace.
23444 Report a CS0105 warning for it.
23446 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23448 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23449 of calling getChar/putback, uses internal knowledge of it.
23451 (xtoken): Reorder tokenizer so most common patterns are checked
23452 first. This reduces the compilation time in another 5% (from 8.11s
23453 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23455 The parsing time is 22% of the compilation in mcs, and from that
23456 64% is spent on the tokenization process.
23458 I tried using a binary search for keywords, but this is slower
23459 than the hashtable. Another option would be to do a couple of
23462 * Not use a StringBuilder, instead use an array of chars,
23463 with a set value. Notice that this way we could catch
23464 the 645 error without having to do it *afterwards*.
23466 * We could write a hand-parser to avoid the hashtable
23467 compares altogether.
23469 The identifier consumption process takes 37% of the tokenization
23470 time. Another 15% is spent on is_number. 56% of the time spent
23471 on is_number is spent on Int64.Parse:
23473 * We could probably choose based on the string length to
23474 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23477 Another 3% is spend on wrapping `xtoken' in the `token' function.
23479 Handle 0xa0 as whitespace (#34752)
23481 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23483 * typemanager.cs (IsCLRType): New routine to tell whether a type
23484 is one of the builtin types.
23486 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23487 typecode in more places instead of doing pointer comparissions.
23488 We could leverage some knowledge about the way the typecodes are
23491 New code to cache namespaces in assemblies, it is currently not
23492 invoked, to be used soon.
23494 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23496 * expression.cs (Binary.ResolveOperator): specially handle
23497 strings, and do not perform user-defined operator overloading for
23500 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23502 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23503 internalcall as it is a pretty simple operation; Avoid whenever
23504 possible to call Char.IsLetter.
23506 (consume_identifier): Cut by half the number of
23507 hashtable calls by merging the is_keyword and GetKeyword behavior.
23509 Do not short-circuit, because if we do, we
23510 report errors (ie, #if false && true would produce an invalid
23514 2002-11-24 Martin Baulig <martin@ximian.com>
23516 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23517 check constant ranges and report a CS0221. Fixes #33186.
23519 2002-11-24 Martin Baulig <martin@ximian.com>
23521 * cs-parser.jay: Make this work for uninitialized variable
23522 declarations in the `for' initializer. Fixes #32416.
23524 2002-11-24 Martin Baulig <martin@ximian.com>
23526 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23527 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23529 2002-11-24 Martin Baulig <martin@ximian.com>
23531 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23532 argument; if true, we also check for user-defined conversions.
23533 This is only needed if both arguments are of a user-defined type.
23534 Fixes #30443, added test-175.cs.
23535 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23537 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23539 2002-11-24 Martin Baulig <martin@ximian.com>
23541 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23542 function to get the store opcode.
23543 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23544 only emit the Ldelema if the store opcode is Stobj. You must run
23545 both test-34 and test-167 to test this. Fixes #34529.
23547 2002-11-23 Martin Baulig <martin@ximian.com>
23549 * ecore.cs (Expression.MemberLookup): Added additional
23550 `qualifier_type' argument which is used when we're being called
23551 from MemberAccess.DoResolve() and null if we're called from a
23553 (Expression.MemberLookupFailed): New method to report errors; this
23554 does the CS1540 check and reports the correct error message.
23556 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23557 argument for the CS1540 check and redone the way how we're dealing
23558 with private members. See the comment in the source code for details.
23559 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23560 `closure_start_type' to `closure_qualifier_type' and check whether
23561 it's not null. It was not this filter being broken, it was just
23562 being called with the wrong arguments.
23564 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23565 and pass it the correct `qualifier_type'; this also does the error
23568 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23570 * expression.cs (Invocation.EmitParams): If the we are dealing
23571 with a non-built-in value type, load its address as well.
23573 (ArrayCreation): Use a a pretty constant instead
23574 of the hardcoded value 2. Use 6 instead of 2 for the number of
23575 static initializers.
23577 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23578 because they are not really value types, just glorified integers.
23580 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23582 * ecore.cs: Remove redundant code for enumerations, make them use
23583 the same code path as everything else, fixes the casting issue
23584 with enumerations in Windows.Forms.
23586 * attribute.cs: Do only cast to string if it is a string, the
23587 validation happens later.
23589 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23590 people upgrade their corlibs.
23592 * ecore.cs: Oops, enumerations were not following the entire code path
23594 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23596 * typemanager.cs (FilterWithClosure): Commented out the test for
23597 1540 in typemanager.cs, as it has problems when accessing
23598 protected methods from a parent class (see test-174.cs).
23600 * attribute.cs (Attribute.ValidateGuid): new method.
23601 (Attribute.Resolve): Use above.
23603 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23605 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23607 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23608 handling for enumerations, as we only needed the TypeContainer
23609 functionality to begin with (this is required for the fix below to
23610 work for enums that reference constants in a container class for
23613 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23615 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23616 a valid TypeBuilder to perform lookups on.o
23618 * class.cs (InheritableMemberSignatureCompare): Use true in the
23619 call to GetGetMethod and GetSetMethod, because we are comparing
23620 the signature, and we need to get the methods *even* if they are
23623 (PropertyBase.CheckBase): ditto.
23625 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23626 GotoCase.Resolve): Use Peel on EmpytCasts.
23628 * ecore.cs (EmptyCast): drop child, add Peel method.
23630 2002-11-17 Martin Baulig <martin@ximian.com>
23632 * ecore.cs (EmptyCast.Child): New public property.
23634 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23635 label resolved to an EmptyCast. Fixes #34162.
23636 (GotoCase.Resolve): Likewise.
23637 (Block.EmitMeta): Likewise.
23639 2002-11-17 Martin Baulig <martin@ximian.com>
23641 * expression.cs (Invocation.BetterConversion): Prefer int over
23642 uint; short over ushort; long over ulong for integer literals.
23643 Use ImplicitConversionExists instead of StandardConversionExists
23644 since we also need to check for user-defined implicit conversions.
23645 Fixes #34165. Added test-173.cs.
23647 2002-11-16 Martin Baulig <martin@ximian.com>
23649 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23650 with the `true' and `false' literals. Fixes #33151.
23652 2002-11-16 Martin Baulig <martin@ximian.com>
23654 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23655 October 22nd; don't do the cs1540 check for static members.
23657 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23658 now using our own filter here and doing the cs1540 check again.
23660 2002-11-16 Martin Baulig <martin@ximian.com>
23662 * support.cs (InternalParameters): Don't crash if we don't have
23663 any fixed parameters. Fixes #33532.
23665 2002-11-16 Martin Baulig <martin@ximian.com>
23667 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23668 when looking up static methods to make this work on Windows.
23671 2002-11-16 Martin Baulig <martin@ximian.com>
23673 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23674 a setter rather than using PropertyInfo.CanWrite.
23676 2002-11-15 Nick Drochak <ndrochak@gol.com>
23678 * class.cs: Allow acces to block member by subclasses. Fixes build
23681 2002-11-14 Martin Baulig <martin@ximian.com>
23683 * class.cs (Constructor.Emit): Added the extern/block check.
23686 2002-11-14 Martin Baulig <martin@ximian.com>
23688 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23689 iteration while looking for indexers, this is needed because the
23690 indexer may have a different name in our base classes. Fixed the
23691 error reporting (no indexers at all, not get accessor, no
23692 overloaded match). Fixes bug #33089.
23693 (IndexerAccess.DoResolveLValue): Likewise.
23695 2002-11-14 Martin Baulig <martin@ximian.com>
23697 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23698 indexers. Fixes the first part of bug #33089.
23699 (MethodSignature.InheritableMemberSignatureCompare): Added support
23702 2002-11-13 Ravi Pratap <ravi@ximian.com>
23704 * attribute.cs (Attribute.Resolve): Catch the
23705 NullReferenceException and report it since it isn't supposed to
23708 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23710 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23711 LogicalOr and LogicalAnd that can benefit from recursively
23712 handling EmitBranchable. The code now should be nice for Paolo.
23714 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23716 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23717 the Type lookups, as we perform quite a number of lookups on
23718 non-Types. This can be removed once we can deterministically tell
23719 whether we have a type or a namespace in advance.
23721 But this might require special hacks from our corlib.
23725 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23726 and double which avoids a conversion from an integer to a double.
23728 * expression.cs: tiny optimization, avoid calling IsConstant,
23729 because it effectively performs the lookup twice.
23731 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23733 But a bogus return here to keep the semantics of the old code
23734 until the Mono runtime is fixed.
23736 * pending.cs (GetMissingInterfaces): New method used to remove all
23737 the interfaces that are already implemented by our parent
23738 classes from the list of pending methods.
23740 * interface.cs: Add checks for calls after ResolveTypeExpr.
23742 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23744 * class.cs (Class.Emit): Report warning 67: event not used if the
23745 warning level is beyond 3.
23747 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23748 being a NullLiteral.
23750 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23753 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23754 path that might fail if a type can not be resolved.
23756 * expression.cs (Binary.Emit): Emit unsigned versions of the
23759 * driver.cs: use error 5.
23761 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23763 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23765 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23767 * cs-parser.jay (switch_section): A beautiful patch from Martin
23768 Baulig that fixed 33094.
23770 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23772 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23773 Check whether the base is abstract and report an error if so.
23775 * expression.cs (IndexerAccess.DoResolveLValue,
23776 IndexerAccess.DoResolve): ditto.
23778 (Invocation.DoResolve): ditto.
23780 (Invocation.FullMethodDesc): Improve the report string.
23782 * statement.cs (Block): Eliminate IsVariableDefined as it is
23783 basically just a wrapper for GetVariableInfo.
23785 * ecore.cs (SimpleName): Use new
23787 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23788 type, as we return the actual parameter ref/unref state on a
23791 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23793 * support.cs: Return proper flags REF/OUT fixing the previous
23796 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23797 not used to mean `ref' but `ref or out' in ParameterReference
23799 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23800 full type signature instead of calling TypeManger.CSharpName
23803 * support.cs (InternalParameters.ParameterDesc): Do not compare
23804 directly to the modflags, because REF/OUT will actually be bitsets
23807 * delegate.cs (VerifyMethod): Check also the modifiers.
23809 * cs-tokenizer.cs: Fix bug where floating point values with an
23810 exponent where a sign was missing was ignored.
23812 * driver.cs: Allow multiple assemblies to be specified in a single
23815 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23817 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23818 because identifiers after a parenthesis would end up in this kind
23819 of production, and we needed to desamiguate it for having casts
23822 (UserDefinedType *) xxx
23824 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23826 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23827 we should set on the Bindingflags.NonPublic, but not turn on
23828 private_ok. private_ok controls whether a Private member is
23829 returned (this is chekced on the filter routine), while the
23830 BindingFlags.NonPublic just controls whether private/protected
23831 will be allowed. This fixes the problem part of the problem of
23832 private properties being allowed to be used in derived classes.
23834 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23835 so we can call the children DoResolveLValue method (this will
23836 properly signal errors on lvalue assignments to base properties)
23838 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23839 getter are null, and we have a property info, we know that this
23840 happened because the lookup failed, so we report an error 122 for
23841 protection level violation.
23843 We also silently return if setter and getter are null in the
23844 resolve functions, this condition only happens if we have flagged
23845 the error before. This is the other half of the problem.
23847 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23848 not have accessibility information, that is why we were returning
23849 true in the filter function in typemanager.cs.
23851 To properly report 122 (property is inaccessible because of its
23852 protection level) correctly, we report this error in ResolveAccess
23853 by failing if both the setter and the getter are lacking (ie, the
23856 DoResolve and DoLResolve have been modified to check for both
23857 setter/getter being null and returning silently, the reason being
23858 that I did not want to put the knowledge about this error in upper
23861 int old = Report.Errors;
23862 x = new PropertyExpr (...);
23863 if (old != Report.Errors)
23868 So the property expr is returned, but it is invalid, so the error
23869 will be flagged during the resolve process.
23871 * class.cs: Remove InheritablePropertySignatureCompare from the
23872 class, as we no longer depend on the property signature to compute
23873 whether it is possible to implement a method or not.
23875 The reason is that calling PropertyInfo.GetGetMethod will return
23876 null (in .NET, in Mono it works, and we should change this), in
23877 cases where the Get Method does not exist in that particular
23882 class X { public virtual int A { get { return 1; } } }
23884 class Z : Y { public override int A { get { return 2; } } }
23886 Would fail in Z because the parent (Y) would not have the property
23887 defined. So we avoid this completely now (because the alternative
23888 fix was ugly and slow), and we now depend exclusively on the
23891 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23892 reference method, instead of using the property.
23894 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23895 routines are gone now.
23897 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23898 names, they were incorrectly named.
23900 * cs-tokenizer.cs: Return are more gentle token on failure.
23902 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23903 had an out-of-sync index variable, which caused it to remove from
23904 the list of pending methods the wrong method sometimes.
23906 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23908 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23909 CanWrite, because those refer to this particular instance of the
23910 property, and do not take into account the fact that we can
23911 override single members of a property.
23913 Constructor requires an EmitContext. The resolution process does
23914 not happen here, but we need to compute the accessors before,
23915 because the resolution does not always happen for properties.
23917 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23918 subclass, before we did not update this flag, but we did update
23921 (GetAccessors): Drop this routine, as it did not work in the
23922 presence of partially overwritten set/get methods.
23924 Notice that this broke the cs1540 detection, but that will require
23927 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23931 * driver.cs: issue a warning instead of an error if we don't support
23932 debugging for the platform. Also ignore a couple of errors that may
23933 arise when trying to write the symbols. Undo my previous patch.
23935 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23937 * driver.cs: ignore /debug switch except for Unix platforms.
23939 2002-10-23 Nick Drochak <ndrochak@gol.com>
23941 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23943 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23945 * driver.cs: Do not make mcs-debug conditional, so we do not break
23946 builds that use it.
23948 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23949 review this patch. But basically after all the children variables
23950 have been merged, the value of "Breaks" was not being set to
23951 new_breaks for Switch blocks. I think that it should be set after
23952 it has executed. Currently I set this to the value of new_breaks,
23953 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23954 conservative, but I do not understand this code very well.
23956 I did not break anything in the build, so that is good ;-)
23958 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23960 2002-10-20 Mark Crichton <crichton@gimp.org>
23962 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23964 2002-10-20 Nick Drochak <ndrochak@gol.com>
23966 * cfold.cs: Fixed compile blocker.
23968 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23970 * driver.cs: I was chekcing the key, not the file.
23972 2002-10-19 Ravi Pratap <ravi@ximian.com>
23974 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23975 message that we were generating - we just need to silently return
23978 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23980 * class.cs (Event.Define): Change my previous commit, as this
23981 breaks the debugger. This is a temporary hack, as it seems like
23982 the compiler is generating events incorrectly to begin with.
23984 * expression.cs (Binary.ResolveOperator): Added support for
23985 "U operator - (E x, E y)"
23987 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23990 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23991 init-only variables, but this path did not take into account that
23992 there might be also instance readonly variables. Correct this
23995 This fixes bug 32253
23997 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24000 * driver.cs: Change the extension for modules to `netmodule'
24002 * cs-parser.jay: Improved slightly the location tracking for
24003 the debugger symbols.
24005 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24006 modifiers that were specified instead of the hardcoded value
24007 (FamAndAssem). This was basically ignoring the static modifier,
24008 and others. Fixes 32429.
24010 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24011 fixed a bug in the process (32476)
24013 * expression.cs (ArrayAccess.EmitAssign): Patch from
24014 hwang_rob@yahoo.ca that fixes bug 31834.3
24016 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24018 * driver.cs: Make the module extension .netmodule.
24020 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24022 * driver.cs: Report an error if the resource file is not found
24023 instead of crashing.
24025 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24026 false, like Emit does.
24028 2002-10-16 Nick Drochak <ndrochak@gol.com>
24030 * typemanager.cs: Remove unused private member. Also reported mcs
24031 bug to report this as a warning like csc.
24033 2002-10-15 Martin Baulig <martin@gnome.org>
24035 * statement.cs (Statement.Emit): Made this a virtual method; emits
24036 the line number info and calls DoEmit().
24037 (Statement.DoEmit): New protected abstract method, formerly knows
24038 as Statement.Emit().
24040 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24042 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24044 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24045 have fixed a remaining problem: not every AddXXXX was adding a
24046 fully qualified name.
24048 Now everyone registers a fully qualified name in the DeclSpace as
24049 being defined instead of the partial name.
24051 Downsides: we are slower than we need to be due to the excess
24052 copies and the names being registered this way.
24054 The reason for this is that we currently depend (on the corlib
24055 bootstrap for instance) that types are fully qualified, because
24056 we dump all the types in the namespace, and we should really have
24057 types inserted into the proper namespace, so we can only store the
24058 basenames in the defined_names array.
24060 2002-10-10 Martin Baulig <martin@gnome.org>
24062 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24063 from bug #31834, see the bug report for a testcase which is
24066 2002-10-10 Martin Baulig <martin@gnome.org>
24068 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24069 flow analysis code for this.
24071 * statement.cs (Do, While, For): Tell the flow analysis code about
24073 (FlowBranching.UsageVector): Added support for infinite loops.
24074 (Block.Resolve): Moved the dead code elimination here and use flow
24077 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24079 * class.cs (Field.Define): Catch cycles on struct type
24082 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24083 fields if the fields are static. We only need to check instance
24086 * expression.cs (As.DoResolve): Test for reference type.
24088 * statement.cs (Using.ResolveExpression): Use
24089 ConvertImplicitRequired, not ConvertImplicit which reports an
24091 (Using.ResolveLocalVariableDecls): ditto.
24093 * expression.cs (Binary.ResolveOperator): Report errors in a few
24094 places where we had to.
24096 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24098 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24100 * expression.cs: Use StoreFromPtr instead of extracting the type
24101 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24103 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24104 an enumeration value to a System.Enum, but System.Enum is not a
24105 value type, but an class type, so we need to box.
24107 (Expression.ConvertExplicit): One codepath could return
24108 errors but not flag them. Fix this. Fixes #31853
24110 * parameter.cs (Resolve): Do not allow void as a parameter type.
24112 2002-10-06 Martin Baulig <martin@gnome.org>
24114 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24115 if it's a class type and not a struct. Fixes #31815.
24117 2002-10-06 Martin Baulig <martin@gnome.org>
24119 * statement.cs: Reworked the flow analysis code a bit to make it
24120 usable for dead code elimination.
24122 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24124 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24126 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24128 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24129 to fix the test 165, will investigate deeper.
24131 2002-10-04 Martin Baulig <martin@gnome.org>
24133 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24134 finally blocks actually work.
24135 (Try.Resolve): We don't need to create a sibling for `finally' if
24136 there is no finally block.
24138 2002-10-04 Martin Baulig <martin@gnome.org>
24140 * class.cs (Constructor.Define): The default accessibility for a
24141 non-default constructor is private, not public.
24143 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24145 * class.cs (Constructor): Make AllowedModifiers public, add
24148 * cs-parser.jay: Perform the modifiers test here, as the
24149 constructor for the Constructor class usually receives a zero
24150 because of the way we create it (first we create, later we
24151 customize, and we were never checking the modifiers).
24153 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24154 is a version of LookupTypeReflection that includes the type-name
24155 cache. This can be used as a fast path for functions that know
24156 the fully qualified name and are only calling into *.GetType() to
24157 obtain a composed type.
24159 This is also used by TypeManager.LookupType during its type
24162 (LookupType): We now also track the real type name, as sometimes
24163 we can get a quey for the real type name from things like
24164 ComposedCast. This fixes bug 31422.
24166 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24167 complete type fullname, it does not have to go through the type
24168 resolution system to obtain the composed version of the type (for
24169 obtaining arrays or pointers).
24171 (Conditional.Emit): Use the EmitBoolExpression to
24172 generate nicer code, as requested by Paolo.
24174 (ArrayCreation.CheckIndices): Use the patch from
24175 hwang_rob@yahoo.ca to validate the array initializers.
24177 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24179 * class.cs (ConstructorInitializer.Emit): simplify code by using
24180 Invocation.EmitCall, and at the same time, fix the bugs in calling
24181 parent constructors that took variable arguments.
24183 * ecore.cs (Expression.ConvertNumericExplicit,
24184 Expression.ImplicitNumericConversion): Remove the code that
24185 manually wrapped decimal (InternalTypeConstructor call is now gone
24188 * expression.cs (Cast.TryReduce): Also handle decimal types when
24189 trying to perform a constant fold on the type.
24191 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24193 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24194 that only turned off an error report, and did nothing else.
24196 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24198 * driver.cs: Handle and ignore /fullpaths
24200 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24202 * expression.cs (Binary.ResolveOperator): Catch the case where
24203 DoNumericPromotions returns true,
24205 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24207 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24209 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24212 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24214 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24215 conversion exists, but it is also required that the conversion be
24216 performed. This manifested in "(Type64Enum) 2".
24218 * class.cs (TypeManager.AddMethod): The fix is not to change
24219 AddEnum, because that one was using a fully qualified name (every
24220 DeclSpace derivative does), but to change the AddMethod routine
24221 that was using an un-namespaced name. This now correctly reports
24222 the duplicated name.
24224 Revert patch until I can properly fix it. The issue
24225 is that we have a shared Type space across all namespaces
24226 currently, which is wrong.
24228 Options include making the Namespace a DeclSpace, and merge
24229 current_namespace/current_container in the parser.
24231 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24233 * cs-parser.jay: Improve error reporting when we get a different
24234 kind of expression in local_variable_type and
24235 local_variable_pointer_type.
24237 Propagate this to avoid missleading errors being reported.
24239 * ecore.cs (ImplicitReferenceConversion): treat
24240 TypeManager.value_type as a target just like object_type. As
24245 Is valid, and needs to result in the int 1 being boxed before it
24246 is assigned to the value type v.
24248 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24249 to validate the enumeration name.
24251 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24252 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24253 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24255 * ecore.cs (TryImplicitIntConversion): When doing an
24256 implicit-enumeration-conversion, check if the type is 64-bits and
24257 perform a conversion before passing to EnumConstant.
24259 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24261 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24262 report ambiguous type references. Unlike the MS version, we
24263 report what the ambiguity is. Innovation at work ;-)
24265 (DeclSpace.FindType): Require a location argument to
24266 display when we display an ambiguous error.
24268 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24270 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24272 * expression.cs (EmitDynamicInitializers): Apply patch from
24273 hwang_rob@yahoo.ca that fixes the order in which we emit our
24276 2002-09-21 Martin Baulig <martin@gnome.org>
24278 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24279 delegate takes no arguments.
24281 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24283 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24286 * expression.cs: Extract the underlying type.
24288 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24290 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24292 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24294 * class.cs (TypeContainer.DefineType): We can not use the nice
24295 PackingSize with the size set to 1 DefineType method, because it
24296 will not allow us to define the interfaces that the struct
24299 This completes the fixing of bug 27287
24301 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24302 means also structs. This fixes part of the problem.
24303 (Expresion.ImplicitReferenceConversionExists): ditto.
24305 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24306 error if there were no errors reported during the type lookup
24307 process, to avoid duplicates or redundant errors. Without this
24308 you would get an ambiguous errors plus a type not found. We have
24309 beaten the user enough with the first error.
24311 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24314 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24315 during the resolution process, stop the lookup, this avoids
24316 repeated error reports (same error twice).
24318 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24320 * typemanager.cs (LookupType): Redo the type lookup code to match
24321 the needs of System.Reflection.
24323 The issue is that System.Reflection requires references to nested
24324 types to begin with a "+" sign instead of a dot. So toplevel
24325 types look like: "NameSpace.TopLevelClass", and nested ones look
24326 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24329 2002-09-19 Martin Baulig <martin@gnome.org>
24331 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24332 says that a method always returns or always throws an exception,
24333 don't report the CS0161.
24335 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24336 set `Returns = new_returns'.
24338 2002-09-19 Martin Baulig <martin@gnome.org>
24340 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24341 to an enum constant, check for a CS0176.
24343 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24345 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24346 for operators that must be in pairs and report errors.
24348 * ecore.cs (SimpleName.DoResolveType): During the initial type
24349 resolution process, when we define types recursively, we must
24350 check first for types in our current scope before we perform
24351 lookups in the enclosing scopes.
24353 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24355 (Invocation.VerifyArgumentsCompat): Call
24356 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24357 I thought we were supposed to always call this, but there are a
24358 few places in the code where we dont do it.
24360 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24362 * driver.cs: Add support in -linkres and -resource to specify the
24363 name of the identifier.
24365 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24367 * ecore.cs (StandardConversionExists): Sync with the conversion
24368 code: allow anything-* to void* conversions.
24370 (FindMostSpecificSource): Use an Expression argument
24371 instead of a Type, because we might be handed over a Literal which
24372 gets a few more implicit conversions that plain types do not. So
24373 this information was being lost.
24375 Also, we drop the temporary type-holder expression when not
24378 2002-09-17 Martin Baulig <martin@gnome.org>
24380 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24381 this is an explicit interface implementation.
24383 2002-09-17 Martin Baulig <martin@gnome.org>
24385 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24386 different `IndexerName' attributes.
24388 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24389 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24390 virtual CommonResolve().
24392 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24394 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24395 and convert that to the UnderlyingType.
24397 * statement.cs (Foreach.Resolve): Indexers are just like variables
24398 or PropertyAccesses.
24400 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24401 inside quoted strings, we were not doing this before.
24403 2002-09-16 Martin Baulig <martin@gnome.org>
24405 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24406 resolve it. This is needed for the definite assignment check of the
24407 instance expression, fixes bug #29846.
24408 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24410 2002-09-16 Nick Drochak <ndrochak@gol.com>
24412 * parameter.cs: Fix compile error. Cannot reference static member
24413 from an instance object. Is this an mcs bug?
24415 2002-09-14 Martin Baulig <martin@gnome.org>
24417 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24418 multiple times. Fixes bug #30295, added test-166.cs.
24420 2002-09-14 Martin Baulig <martin@gnome.org>
24422 * statement.cs (Block.Emit): Don't emit unreachable code.
24423 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24424 `break' statements.
24425 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24427 2002-09-14 Martin Baulig <martin@gnome.org>
24429 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24432 2002-09-14 Martin Baulig <martin@gnome.org>
24434 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24435 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24436 be false on the ms runtime.
24438 2002-09-13 Martin Baulig <martin@gnome.org>
24440 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24441 the CS0038 error message.
24443 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24445 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24446 constant inside, return it.
24448 2002-09-12 Martin Baulig <martin@gnome.org>
24450 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24451 implicit conversion can be done between enum types.
24453 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24454 check whether an implicit conversion to the current enum's UnderlyingType
24455 exists and report an error if not.
24457 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24458 without debugging support.
24460 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24461 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24463 2002-09-12 Martin Baulig <martin@gnome.org>
24465 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24467 * ecore.cs (IMemberExpr.DeclaringType): New property.
24468 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24469 nonstatic member of an outer type (CS0038).
24471 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24473 * driver.cs: Activate the using-error detector at warning level
24474 4 (at least for MS-compatible APIs).
24476 * namespace.cs (VerifyUsing): Small buglett fix.
24478 * pending.cs (PendingImplementation): pass the container pointer.
24480 * interface.cs (GetMethods): Allow for recursive definition. Long
24481 term, I would like to move every type to support recursive
24482 definitions, not the current ordering mechanism that we have right
24485 The situation is this: Attributes are handled before interfaces,
24486 so we can apply attributes to interfaces. But some attributes
24487 implement interfaces, we will now handle the simple cases
24488 (recursive definitions will just get an error).
24490 * parameter.cs: Only invalidate types at the end if we fail to
24493 2002-09-09 Martin Baulig <martin@gnome.org>
24495 * ecore.cs (PropertyExpr.Emit): Also check for
24496 TypeManager.system_int_array_get_length so this'll also work when
24497 compiling corlib. Fixes #30003.
24499 2002-09-09 Martin Baulig <martin@gnome.org>
24501 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24502 and throw an exception if we can't get the type's size. Fixed #30040,
24505 2002-09-09 Martin Baulig <martin@gnome.org>
24507 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24509 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24510 context. Fixes bug #30027.
24512 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24513 virtual functions. Fixes bug #30043, added test-164.cs.
24515 2002-09-08 Ravi Pratap <ravi@ximian.com>
24517 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24519 2002-09-08 Nick Drochak <ndrochak@gol.com>
24521 * driver.cs: Use an object to get the windows codepage since it's not a
24524 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24526 * statement.cs (For.Emit): for infinite loops (test == null)
24527 return whether there is a break inside, not always "true".
24529 * namespace.cs (UsingEntry): New struct to hold the name of the
24530 using definition, the location where it is defined, and whether it
24531 has been used in a successful type lookup.
24533 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24538 2002-09-06 Ravi Pratap <ravi@ximian.com>
24540 * attribute.cs : Fix incorrect code which relied on catching
24541 a NullReferenceException to detect a null being passed in
24542 where an object was expected.
24544 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24546 * statement.cs (Try): flag the catch variable as assigned
24548 * expression.cs (Cast): Simplified by using ResolveType instead of
24549 manually resolving.
24551 * statement.cs (Catch): Fix bug by using ResolveType.
24553 2002-09-06 Ravi Pratap <ravi@ximian.com>
24555 * expression.cs (BetterConversion): Special case for when we have
24556 a NullLiteral as the argument and we have to choose between string
24557 and object types - we choose string the way csc does.
24559 * attribute.cs (Attribute.Resolve): Catch the
24560 NullReferenceException and report error #182 since the Mono
24561 runtime no more has the bug and having this exception raised means
24562 we tried to select a constructor which takes an object and is
24565 2002-09-05 Ravi Pratap <ravi@ximian.com>
24567 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24568 message (1502, 1503) when we can't locate a method after overload
24569 resolution. This is much more informative and closes the bug
24572 * interface.cs (PopulateMethod): Return if there are no argument
24573 types. Fixes a NullReferenceException bug.
24575 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24576 expressions too. Previously we were checking only in one place for
24577 positional arguments leaving out named arguments.
24579 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24580 type to the enum type is not allowed. Remove code corresponding to
24583 (ConvertNumericExplicit): Allow explicit conversions from
24584 the underlying type to enum type. This precisely follows the spec
24585 and closes a bug filed by Gonzalo.
24587 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24590 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24592 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24594 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24595 it was important that we stored the right value after the
24596 reduction in `converted'.
24598 2002-09-04 Martin Baulig <martin@gnome.org>
24600 * location.cs (Location.SymbolDocument): Use full pathnames for the
24603 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24605 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24606 of the expression resolve mechanism, because that will catch the
24607 SimpleName error failures.
24609 (Conditional): If we can not resolve the
24610 expression, return, do not crash.
24612 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24615 (location): display token name instead of its number.
24617 2002-08-28 Martin Baulig <martin@gnome.org>
24619 * expression.cs (Binary.ResolveOperator): Don't silently return
24620 but return an error if an operator cannot be applied between two
24623 2002-08-28 Martin Baulig <martin@gnome.org>
24625 * class.cs (Constructor.Define): Set the permission attributes
24626 correctly instead of making all constructors public.
24628 2002-08-28 Martin Baulig <martin@gnome.org>
24630 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24631 for private members before reporting a CS0103; if we find anything,
24634 2002-08-28 Martin Baulig <martin@gnome.org>
24636 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24637 to check whether `closure_start_type == closure_invocation_type',
24638 we also need to check whether `m.DeclaringType == closure_invocation_type'
24639 before bypassing the permission checks. We might be accessing
24640 protected/private members from the base class.
24641 (TypeManager.RealMemberLookup): Only set private_ok if private
24642 members were requested via BindingFlags.NonPublic.
24644 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24646 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24647 MethodGroupExpr.IsExplicitImpl if appropriate.
24648 (Invocation.DoResolve): Don't report the CS0120 for explicit
24649 interface implementations.
24651 2002-08-27 Martin Baulig <martin@gnome.org>
24653 * expression.cs (Invocation.DoResolve): If this is a static
24654 method and we don't have an InstanceExpression, we must report
24657 2002-08-25 Martin Baulig <martin@gnome.org>
24659 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24660 `==' between a valuetype and an object.
24662 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24664 * ecore.cs (TypeExpr): Provide a ToString method.
24666 2002-08-24 Martin Baulig <martin@gnome.org>
24668 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24669 now called proggie.dbg and it's a binary file.
24671 2002-08-23 Martin Baulig <martin@gnome.org>
24673 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24675 2002-08-23 Martin Baulig <martin@gnome.org>
24677 * struct.cs (MyStructInfo.ctor): Make this work with empty
24678 structs; it's not allowed to use foreach() on null.
24680 2002-08-23 Martin Baulig <martin@gnome.org>
24682 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24683 writer the full pathname of the generated assembly.
24685 2002-08-23 Martin Baulig <martin@gnome.org>
24687 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24688 A `finally' block never returns or breaks; improved handling of
24691 2002-08-23 Martin Baulig <martin@gnome.org>
24693 * statement.cs (Throw.Resolve): Allow `throw null'.
24695 2002-08-23 Martin Baulig <martin@gnome.org>
24697 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24698 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24699 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24700 MemberLookup would return a wrong event if this is an explicit
24701 interface implementation and the class has an event with the same
24704 2002-08-23 Martin Baulig <martin@gnome.org>
24706 * statement.cs (Block.AddChildVariableNames): New public method.
24707 (Block.AddChildVariableName): Likewise.
24708 (Block.IsVariableNameUsedInChildBlock): Likewise.
24709 (Block.AddVariable): Check whether a variable name has already
24710 been used in a child block.
24712 * cs-parser.jay (declare_local_variables): Mark all variable names
24713 from the current block as being used in a child block in the
24716 2002-08-23 Martin Baulig <martin@gnome.org>
24718 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24719 find the symbol writer.
24721 * driver.cs: csc also allows the arguments to /define being
24722 separated by commas, not only by semicolons.
24724 2002-08-23 Martin Baulig <martin@gnome.org>
24726 * interface.cs (Interface.GetMembers): Added static check for events.
24728 2002-08-15 Martin Baulig <martin@gnome.org>
24730 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24731 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24733 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24734 why the MethodData.EmitDestructor() change was necessary.
24736 2002-08-20 Martin Baulig <martin@gnome.org>
24738 * class.cs (TypeContainer.FindMembers): Added static check for events.
24740 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24742 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24743 use Type.GetEvents(), not Type.FindMembers().
24745 2002-08-20 Martin Baulig <martin@gnome.org>
24747 * decl.cs (MemberCache): Added a special method cache which will
24748 be used for method-only searched. This ensures that a method
24749 search will return a MethodInfo with the correct ReflectedType for
24752 2002-08-20 Martin Baulig <martin@gnome.org>
24754 * decl.cs (DeclSpace.FindMembers): Made this public.
24756 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24758 * delegate.cs: fixed build on windows.
24759 [FIXME: Filed as bug #29150: MCS must report these errors.]
24761 2002-08-19 Ravi Pratap <ravi@ximian.com>
24763 * ecore.cs (StandardConversionExists): Return a false
24764 if we are trying to convert the void type to anything else
24765 since that is not allowed.
24767 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24768 we flag error 70 in the event an event is trying to be accessed
24769 directly from outside the declaring type.
24771 2002-08-20 Martin Baulig <martin@gnome.org>
24773 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24774 MemberCache from typemanager.cs to decl.cs.
24776 2002-08-19 Martin Baulig <martin@gnome.org>
24778 * class.cs (TypeContainer): Implement IMemberContainer.
24779 (TypeContainer.DefineMembers): Create the MemberCache.
24780 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24781 return public members if BindingFlags.Public was given, check
24782 whether members are static.
24784 2002-08-16 Martin Baulig <martin@gnome.org>
24786 * decl.cs (DeclSpace.Define): Splitted this in Define and
24787 DefineMembers. DefineMembers is called first and initializes the
24790 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24791 DefineMembers() on all our DeclSpaces.
24793 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24794 but call DefineMembers() on all nested interfaces. We call their
24795 Define() in our new Define() function.
24797 * interface.cs (Interface): Implement IMemberContainer.
24798 (Interface.Define): Moved all code except the attribute stuf to
24800 (Interface.DefineMembers): Initialize the member cache.
24802 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24803 need this anymore since we can use MemberCache.FindMembers directly.
24805 2002-08-19 Martin Baulig <martin@gnome.org>
24807 * typemanager.cs (MemberCache): When creating the cache for an
24808 interface type, add all inherited members.
24809 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24810 to `out bool used_cache' and documented it.
24811 (TypeManager.MemberLookup): If we already used the cache in the first
24812 iteration, we don't need to do the interfaces check.
24814 2002-08-19 Martin Baulig <martin@gnome.org>
24816 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24817 here from IMemberFinder and don't implement this interface anymore.
24818 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24820 * typemanager.cs (IMemberFinder): This interface is now only used by
24821 classes which actually support the member cache.
24822 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24823 since we only put DeclSpaces into this Hashtable.
24824 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24825 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24827 2002-08-16 Martin Baulig <martin@gnome.org>
24829 * typemanager.cs (ICachingMemberFinder): Removed.
24830 (IMemberFinder.MemberCache): New property.
24831 (TypeManager.FindMembers): Merged this with RealFindMembers().
24832 This function will never be called from TypeManager.MemberLookup()
24833 so we can't use the cache here, just the IMemberFinder.
24834 (TypeManager.MemberLookup_FindMembers): Check whether the
24835 IMemberFinder has a MemberCache and call the cache's FindMembers
24837 (MemberCache): Rewrote larger parts of this yet another time and
24838 cleaned it up a bit.
24840 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24842 * driver.cs (LoadArgs): Support quoting.
24844 (Usage): Show the CSC-like command line arguments.
24846 Improved a few error messages.
24848 2002-08-15 Martin Baulig <martin@gnome.org>
24850 * typemanager.cs (IMemberContainer.Type): New property.
24851 (IMemberContainer.IsInterface): New property.
24853 The following changes are conditional to BROKEN_RUNTIME, which is
24854 defined at the top of the file.
24856 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24857 class'es members, but add all members from TypeHandle.ObjectType
24858 if we're an interface.
24859 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24860 is the current type.
24861 (MemberCache.CacheEntry.Container): Removed this field.
24862 (TypeHandle.GetMembers): Include inherited members.
24864 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24866 * typemanager.cs: fixed compilation and added a comment on a field that
24869 2002-08-15 Martin Baulig <martin@gnome.org>
24871 * class.cs (ConstructorInitializer.Resolve): In the
24872 Expression.MemberLookup call, use the queried_type as
24875 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24876 declared' attribute, it's always true.
24877 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24878 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24879 temporary wrapper for FindMembers which tells MemberLookup whether
24880 members from the base classes are included in the return value.
24881 This will go away soon.
24882 (TypeManager.MemberLookup): Use this temporary hack here; once the
24883 new MemberCache is completed, we don't need to do the DeclaredOnly
24884 looping here anymore since the MemberCache will take care of this.
24885 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24886 (MemberCache): When creating the MemberCache for a class, get
24887 members from the current class and all its base classes.
24888 (MemberCache.CacheEntry.Container): New field. This is a
24889 temporary hack until the Mono runtime is fixed to distinguish
24890 between ReflectedType and DeclaringType. It allows us to use MCS
24891 with both the MS runtime and the unfixed Mono runtime without
24892 problems and without accecting performance.
24893 (MemberCache.SearchMembers): The DeclaredOnly looping from
24894 TypeManager.MemberLookup is now done here.
24896 2002-08-14 Martin Baulig <martin@gnome.org>
24898 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24899 Type.GetFields on dynamic types but get the fields from the
24900 corresponding TypeContainer.
24901 (MyStructInfo.GetStructInfo): Added check for enum types.
24903 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24904 (MemberList.SyncRoot): Implemented.
24905 (TypeManager.FilterWithClosure): No need to check permissions if
24906 closure_start_type == closure_invocation_type, don't crash if
24907 closure_invocation_type is null.
24909 2002-08-13 Martin Baulig <martin@gnome.org>
24911 Rewrote TypeContainer.FindMembers to use a member cache. This
24912 gives us a speed increase of about 35% for the self-hosting MCS
24913 build and of about 15-20% for the class libs (both on GNU/Linux).
24915 * report.cs (Timer): New class to get enhanced profiling. This
24916 whole class is "TIMER" conditional since it remarkably slows down
24919 * class.cs (MemberList): New class. This is an IList wrapper
24920 which we're now using instead of passing MemberInfo[]'s around to
24921 avoid copying this array unnecessarily.
24922 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24923 (ICachingMemberFinder, IMemberContainer): New interface.
24924 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24925 has already been checked, otherwise use it for the name comparision.
24926 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24927 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24928 if possible. Returns a MemberList, not a MemberInfo [].
24929 (TypeHandle): New class, implements IMemberContainer. We create
24930 one instance of this class per type, it contains a MemberCache
24931 which is used to do the member lookups.
24932 (MemberCache): New class. Each instance of this class contains
24933 all members of a type and a name-based hash table.
24934 (MemberCache.FindMembers): This is our new member lookup
24935 function. First, it looks up all members of the requested name in
24936 the hash table. Then, it walks this list and sorts out all
24937 applicable members and returns them.
24939 2002-08-13 Martin Baulig <martin@gnome.org>
24941 In addition to a nice code cleanup, this gives us a performance
24942 increase of about 1.4% on GNU/Linux - not much, but it's already
24943 half a second for the self-hosting MCS compilation.
24945 * typemanager.cs (IMemberFinder): New interface. It is used by
24946 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24947 Enum, Delegate or Interface.
24948 (TypeManager.finder_to_member_finder): New PtrHashtable.
24949 (TypeManager.finder_to_container): Removed.
24950 (TypeManager.finder_to_delegate): Removed.
24951 (TypeManager.finder_to_interface): Removed.
24952 (TypeManager.finder_to_enum): Removed.
24954 * interface.cs (Interface): Implement IMemberFinder.
24956 * delegate.cs (Delegate): Implement IMemberFinder.
24958 * enum.cs (Enum): Implement IMemberFinder.
24960 * class.cs (TypeContainer): Implement IMemberFinder.
24962 2002-08-12 Martin Baulig <martin@gnome.org>
24964 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24966 2002-08-12 Martin Baulig <martin@gnome.org>
24968 * ecore.cs (ITypeExpression): New interface for expressions which
24970 (TypeExpression): Renamed to TypeLookupExpression.
24971 (Expression.DoResolve): If we're doing a types-only lookup, the
24972 expression must implement the ITypeExpression interface and we
24973 call DoResolveType() on it.
24974 (SimpleName): Implement the new ITypeExpression interface.
24975 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24976 hack, the situation that we're only looking up types can't happen
24977 anymore when this method is called. Moved the type lookup code to
24978 DoResolveType() and call it.
24979 (SimpleName.DoResolveType): This ITypeExpression interface method
24980 is now doing the types-only lookup.
24981 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24982 (ResolveFlags): Added MaskExprClass.
24984 * expression.cs (MemberAccess): Implement the ITypeExpression
24986 (MemberAccess.DoResolve): Added support for a types-only lookup
24987 when we're called via ITypeExpression.DoResolveType().
24988 (ComposedCast): Implement the ITypeExpression interface.
24990 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24991 Expression.Resolve() with ResolveFlags.Type instead.
24993 2002-08-12 Martin Baulig <martin@gnome.org>
24995 * interface.cs (Interface.Define): Apply attributes.
24997 * attribute.cs (Attribute.ApplyAttributes): Added support for
24998 interface attributes.
25000 2002-08-11 Martin Baulig <martin@gnome.org>
25002 * statement.cs (Block.Emit): Only check the "this" variable if we
25003 do not always throw an exception.
25005 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25006 whether the property has a set accessor.
25008 2002-08-11 Martin Baulig <martin@gnome.org>
25010 Added control flow analysis support for structs.
25012 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25013 with control flow analysis turned off.
25014 (IVariable): New interface.
25015 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25016 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25017 (FieldExpr.DoResolve): Resolve the instance expression with flow
25018 analysis turned off and do the definite assignment check after the
25019 resolving when we know what the expression will resolve to.
25021 * expression.cs (LocalVariableReference, ParameterReference):
25022 Implement the new IVariable interface, only call the flow analysis
25023 code if ec.DoFlowAnalysis is true.
25024 (This): Added constructor which takes a Block argument. Implement
25025 the new IVariable interface.
25026 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25027 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25028 This does the definite assignment checks for struct members.
25030 * class.cs (Constructor.Emit): If this is a non-static `struct'
25031 constructor which doesn't have any initializer, call
25032 Block.AddThisVariable() to tell the flow analysis code that all
25033 struct elements must be initialized before control returns from
25036 * statement.cs (MyStructInfo): New public class.
25037 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25038 argument to this indexer. If non-zero, check an individual struct
25039 member, not the whole struct.
25040 (FlowBranching.CheckOutParameters): Check struct members.
25041 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25042 overloaded versions of these methods which take an additional
25043 `int field_idx' argument to check struct members.
25044 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25045 overloaded versions of these methods which take an additional
25046 `string field_name' argument to check struct member.s
25047 (VariableInfo): Implement the IVariable interface.
25048 (VariableInfo.StructInfo): New public property. Returns the
25049 MyStructInfo instance of the variable if it's a struct or null.
25050 (Block.AddThisVariable): New public method. This is called from
25051 Constructor.Emit() for non-static `struct' constructor which do
25052 not have any initializer. It creates a special variable for the
25053 "this" instance variable which will be checked by the flow
25054 analysis code to ensure that all of the struct's fields are
25055 initialized before control returns from the constructor.
25056 (UsageVector): Added support for struct members. If a
25057 variable/parameter is a struct with N members, we reserve a slot
25058 in the usage vector for each member. A struct is considered fully
25059 initialized if either the struct itself (slot 0) or all its
25060 members are initialized.
25062 2002-08-08 Martin Baulig <martin@gnome.org>
25064 * driver.cs (Driver.MainDriver): Only report an error CS5001
25065 if there were no compilation errors.
25067 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25068 `UnsafeContext' property to determine whether the parent is in
25069 unsafe context rather than checking the parent's ModFlags:
25070 classes nested in an unsafe class are unsafe as well.
25072 2002-08-08 Martin Baulig <martin@gnome.org>
25074 * statement.cs (UsageVector.MergeChildren): Distinguish between
25075 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25076 we return. Added test17() and test18() to test-154.cs.
25078 2002-08-08 Martin Baulig <martin@gnome.org>
25080 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25081 Family access, make sure the invoking type isn't a subclass of the
25082 queried type (that'd be a CS1540).
25084 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25085 this method which takes an additional `Type invocation_type'.
25087 * expression.cs (BaseAccess.DoResolve): Use the base type as
25088 invocation and query type.
25089 (MemberAccess.DoResolve): If the lookup failed and we're about to
25090 report a CS0122, try a lookup with the ec.ContainerType - if this
25091 succeeds, we must report a CS1540.
25093 2002-08-08 Martin Baulig <martin@gnome.org>
25095 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25096 (MethodGroupExpr): Implement the IMemberExpr interface.
25098 * expression (MemberAccess.ResolveMemberAccess): No need to have
25099 any special code for MethodGroupExprs anymore, they're now
25102 2002-08-08 Martin Baulig <martin@gnome.org>
25104 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25105 Family, FamANDAssem and FamORAssem permissions.
25106 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25108 2002-08-08 Martin Baulig <martin@gnome.org>
25110 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25111 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25114 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25116 * driver.cs: implemented /resource option to embed managed resources.
25118 2002-08-07 Martin Baulig <martin@gnome.org>
25120 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25121 (FieldBase.HasFieldInitializer): New public property.
25122 (FieldBase.GetInitializerExpression): New public method. Resolves and
25123 returns the field initializer and makes sure it is only resolved once.
25124 (TypeContainer.EmitFieldInitializers): Call
25125 FieldBase.GetInitializerExpression to get the initializer, this ensures
25126 that it isn't resolved multiple times.
25128 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25129 the resolving process (SimpleName/MemberLookup) that we're currently
25130 emitting a field initializer (which must not access any instance members,
25131 this is an error CS0236).
25133 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25134 argument, if the `IsFieldInitializer' flag is set, we must report and
25135 error CS0236 and not an error CS0120.
25137 2002-08-07 Martin Baulig <martin@gnome.org>
25139 * ecore.cs (IMemberExpr): New public interface.
25140 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25141 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25142 if the expression is an IMemberExpr.
25144 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25145 to be null, implicitly default to `this' if we're non-static in
25146 this case. Simplified the code a lot by using the new IMemberExpr
25147 interface. Also fixed bug #28176 here.
25149 2002-08-06 Martin Baulig <martin@gnome.org>
25151 * cs-parser.jay (SimpleLookup): Removed. We need to create
25152 ParameterReferences during semantic analysis so that we can do a
25153 type-only search when resolving Cast, TypeOf and SizeOf.
25154 (block): Pass the `current_local_parameters' to the Block's
25157 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25158 argument to the constructor.
25159 (ConstructorInitializer.Resolve): Create a temporary implicit
25160 block with the parameters.
25162 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25163 references here if we aren't doing a type-only search.
25165 * statement.cs (Block): Added constructor which takes a
25166 `Parameters parameters' argument.
25167 (Block.Parameters): New public property.
25169 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25170 to `Parameters' and made it public readonly.
25172 2002-08-06 Martin Baulig <martin@gnome.org>
25174 * ecore.cs (Expression.Warning): Made this public as well.
25176 * report.cs (Report.Debug): Print the contents of collections.
25178 2002-08-06 Martin Baulig <martin@gnome.org>
25180 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25181 used to tell Resolve() which kinds of expressions it may return.
25182 (Expression.Resolve): Added overloaded version of this method which
25183 takes a `ResolveFlags flags' argument. This can be used to tell
25184 Resolve() which kinds of expressions it may return. Reports a
25186 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25187 ResolveFlags.SimpleName.
25188 (Expression.Error118): Added overloaded version of this method which
25189 takes a `ResolveFlags flags' argument. It uses the flags to determine
25190 which kinds of expressions are allowed.
25192 * expression.cs (Argument.ResolveMethodGroup): New public method.
25193 Resolves an argument, but allows a MethodGroup to be returned.
25194 This is used when invoking a delegate.
25196 * TODO: Updated a bit.
25198 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25200 Fixed compilation with csc.
25202 * ecore.cs: Expression.Error made public. Is this correct? Should
25203 Warning be made public too?
25205 * expression.cs: use ea.Location instead of ea.loc.
25206 [FIXME: Filed as bug #28607: MCS must report these errors.]
25208 2002-08-06 Martin Baulig <martin@gnome.org>
25210 * ecore.cs (Expression.loc): Moved the location here instead of
25211 duplicating it in all derived classes.
25212 (Expression.Location): New public property.
25213 (Expression.Error, Expression.Warning): Made them non-static and
25214 removed the location argument.
25215 (Expression.Warning): Added overloaded version which takes an
25216 `int level' argument.
25217 (Expression.Error118): Make this non-static and removed the
25218 expression and location arguments.
25219 (TypeExpr): Added location argument to the constructor.
25221 * expression.cs (StaticCallExpr): Added location argument to
25223 (Indirection, PointerArithmetic): Likewise.
25224 (CheckedExpr, UnCheckedExpr): Likewise.
25225 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25226 (StringPtr): Likewise.
25229 2002-08-05 Martin Baulig <martin@gnome.org>
25231 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25233 * assign.cs (Assign.DoResolve): Check whether the source
25234 expression is a value or variable.
25236 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25237 while resolving the corresponding blocks.
25239 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25240 an error, don't silently return null.
25242 * statement.cs (Block.AddVariable): Do the error reporting here
25243 and distinguish between CS0128 and CS0136.
25244 (Block.DoResolve): Report all unused labels (warning CS0164).
25245 (LabeledStatement): Pass the location to the constructor.
25246 (LabeledStatement.HasBeenReferenced): New property.
25247 (LabeledStatement.Resolve): Set it to true here.
25249 * statement.cs (Return.Emit): Return success even after reporting
25250 a type mismatch error (CS0126 or CS0127), this is what csc does and
25251 it avoids confusing the users with any consecutive errors.
25253 2002-08-05 Martin Baulig <martin@gnome.org>
25255 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25257 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25259 * expression.cs (MemberAccess.DoResolve): Silently return if an
25260 error has already been reported.
25262 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25263 error has already been reported.
25265 2002-08-05 Martin Baulig <martin@gnome.org>
25267 * statement.cs (UsageVector): Only initialize the `parameters'
25268 vector if we actually have any "out" parameters.
25270 2002-08-05 Martin Baulig <martin@gnome.org>
25272 * expression.cs (Binary.ResolveOperator): When combining delegates,
25273 they must have the same type.
25275 2002-08-05 Martin Baulig <martin@gnome.org>
25277 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25278 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25279 work with the ms runtime and we also don't need it: if we're a
25280 PropertyBuilder and not in the `indexer_arguments' hash, then we
25281 are a property and not an indexer.
25283 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25284 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25285 since the latter one doesn't work with the ms runtime.
25287 2002-08-03 Martin Baulig <martin@gnome.org>
25289 Fixed bugs #27998 and #22735.
25291 * class.cs (Method.IsOperator): New public field.
25292 (Method.CheckBase): Report CS0111 if there's already a method
25293 with the same parameters in the current class. Report CS0508 when
25294 attempting to change the return type of an inherited method.
25295 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25296 and it's not marked abstract or extern.
25297 (PropertyBase): New abstract base class for Property and Indexer.
25298 (PropertyBase.CheckBase): Moved here from Property and made it work
25300 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25301 the same so we can reuse it there.
25302 (Property, Indexer): Derive from PropertyBase.
25303 (MethodSignature.inheritable_property_signature_filter): New delegate
25304 to find properties and indexers.
25306 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25307 argument and improved error reporting.
25309 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25310 EmptyReadOnlyParameters and made it a property.
25312 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25313 version of this method which takes a `PropertyInfo indexer'.
25314 (TypeManager.RegisterIndexer): New method.
25316 * class.cs: Added myself as author of this file :-)
25318 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25320 * class.cs: fixed compilation on windoze.
25322 2002-08-03 Martin Baulig <martin@gnome.org>
25324 * interface.cs (Interface.GetInterfaceBases): Check whether all
25325 base interfaces are at least as accessible than the current one.
25327 * class.cs (TypeContainer.GetClassBases): Check whether base types
25328 are at least as accessible than the current type.
25329 (TypeContainer.AsAccessible): Implemented and made non-static.
25330 (MemberBase.CheckParameters): Report errors if the accessibility
25333 * delegate.cs (Delegate.Delegate): The default visibility is
25334 internal for top-level types and private for nested types.
25335 (Delegate.Define): Report errors if the accessibility checks fail.
25337 * enum.cs (Enum.Enum): The default visibility is internal for
25338 top-level types and private for nested types.
25339 (Enum.DefineType): Compute the correct visibility.
25341 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25342 function which takes a `bool is_toplevel' instead of a TypeContainer.
25344 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25347 2002-08-02 Martin Baulig <martin@gnome.org>
25349 * expression.cs (LocalVariableReferenc): Added constructor which
25350 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25351 (LocalVariableReference.IsReadOnly): New property.
25352 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25353 variable is readonly, use our own readonly flag to do this; you can
25354 use the new constructor to get a writable reference to a read-only
25357 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25358 reference to the local variable.
25360 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25362 * rootcontext.cs (ResolveCore): Also include System.Exception
25364 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25365 we reach an EmptyStatement.
25367 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25370 * expression.cs (Binary.ResolveOperator): Check error result in
25373 use brtrue/brfalse directly and avoid compares to null.
25375 2002-08-02 Martin Baulig <martin@gnome.org>
25377 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25378 Fixes bug #28407, added test-155.cs.
25380 2002-08-01 Martin Baulig <martin@gnome.org>
25382 * class.cs (Event.EmitDefaultMethod): Make this work with static
25383 events. Fixes #28311, added verify-3.cs.
25385 2002-08-01 Martin Baulig <martin@gnome.org>
25387 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25388 `is_disposable' fields.
25389 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25390 `hm.is_disposable' if we're using the collection pattern.
25391 (Foreach.EmitCollectionForeach): Use the correct type for the
25392 enumerator's local variable, only emit the try/finally block if
25393 necessary (fixes #27713).
25395 2002-08-01 Martin Baulig <martin@gnome.org>
25397 * ecore.cs (Expression.report118): Renamed to Error118 and made
25400 * statement.cs (Throw.Resolve): Check whether the expression is of
25401 the correct type (CS0118) and whether the type derives from
25402 System.Exception (CS0155).
25403 (Catch.Resolve): New method. Do the type lookup here and check
25404 whether it derives from System.Exception (CS0155).
25405 (Catch.CatchType, Catch.IsGeneral): New public properties.
25407 * typemanager.cs (TypeManager.exception_type): Added.
25409 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25411 * driver.cs: Updated About function.
25413 2002-07-31 Martin Baulig <martin@gnome.org>
25415 Implemented Control Flow Analysis.
25417 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25418 (EmitContext.CurrentBranching): Added.
25419 (EmitContext.StartFlowBranching): Added.
25420 (EmitContext.EndFlowBranching): Added.
25421 (EmitContext.KillFlowBranching): Added.
25422 (EmitContext.IsVariableAssigned): Added.
25423 (EmitContext.SetVariableAssigned): Added.
25424 (EmitContext.IsParameterAssigned): Added.
25425 (EmitContext.SetParameterAssigned): Added.
25426 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25427 Added control flow analysis stuff here.
25429 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25430 resolve the expression as lvalue.
25431 (LocalVariableReference.DoResolve): Check whether the variable has
25432 already been assigned.
25433 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25434 the parameter as assigned here.
25435 (ParameterReference.DoResolve): Check whether the parameter has already
25437 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25438 expression as lvalue.
25440 * statement.cs (FlowBranching): New class for the flow analysis code.
25441 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25442 (LabeledStatement.IsDefined): New public property.
25443 (LabeledStatement.AddUsageVector): New public method to tell flow
25444 analyis that the label may be reached via a forward jump.
25445 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25447 (VariableInfo.Number): New public field. This is used by flow analysis
25448 to number all locals of a block.
25449 (Block.CountVariables): New public property. This is the number of
25450 local variables in this block (including the locals from all parent
25452 (Block.EmitMeta): Number all the variables.
25454 * statement.cs: Added flow analysis support to all classes.
25456 2002-07-31 Martin Baulig <martin@gnome.org>
25458 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25459 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25460 then use this argument.
25462 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25464 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25465 use this to specify /define options.
25467 2002-07-29 Martin Baulig <martin@gnome.org>
25469 * statement.cs (Fixed): Moved all code that does variable lookups
25470 and resolvings from Emit to Resolve.
25472 * statement.cs (For): Moved all code that does variable lookups
25473 and resolvings from Emit to Resolve.
25475 * statement.cs (Using): Moved all code that does variable lookups
25476 and resolvings from Emit to Resolve.
25478 2002-07-29 Martin Baulig <martin@gnome.org>
25480 * attribute.cs (Attribute.Resolve): Explicitly catch a
25481 System.NullReferenceException when creating the
25482 CustromAttributeBuilder and report a different warning message.
25484 2002-07-29 Martin Baulig <martin@gnome.org>
25486 * support.cs (ParameterData.ParameterName): Added method to
25487 get the name of a parameter.
25489 * typemanager.cs (TypeManager.IsValueType): New public method.
25491 2002-07-29 Martin Baulig <martin@gnome.org>
25493 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25494 is a flag which specifies that it's either ref or out.
25495 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25496 the out parameter to `out Parameter.Modifier mod', also set the
25497 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25499 * support.cs (InternalParameters.ParameterModifier): Distinguish
25500 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25501 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25503 * expression.cs (Argument.GetParameterModifier): Distinguish
25504 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25505 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25507 2002-07-29 Martin Baulig <martin@gnome.org>
25509 * expression.cs (ParameterReference.ParameterReference): Added
25510 `Location loc' argument to the constructor.
25512 * cs-parser.jay: Pass location to ParameterReference.
25514 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25516 * statement.cs (Try): Initialize the location.
25518 * cs-parser.jay: pass location to Try.
25520 * expression.cs (Unary.Reduce): Change the prototype to return
25521 whether a constant fold could be performed or not. The result is
25522 returned in an out parameters. In the case of Indirection and
25523 AddressOf, we want to perform the full tests.
25525 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25527 * statement.cs (Statement.Emit): Flag dead code.
25529 2002-07-27 Andrew Birkett <andy@nobugs.org>
25531 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25533 2002-07-27 Martin Baulig <martin@gnome.org>
25535 * class.cs (MethodData.Define): Put back call to
25536 TypeManager.AddMethod(), accidentally commented this out.
25538 * report.cs (Debug): New public method to print debugging information,
25539 this is `[Conditional ("DEBUG")]'.
25541 2002-07-26 Martin Baulig <martin@gnome.org>
25543 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25544 (switch_statement): Push the current_block to the switch_stack and
25545 pop it again when we're done with the switch.
25546 (switch_section): The new block is a child of the current_block.
25547 Fixes bug #24007, added test-152.cs.
25549 2002-07-27 Martin Baulig <martin@gnome.org>
25551 * expression.cs (Invocation.EmitArguments): When calling a varargs
25552 function with only its fixed arguments, we need to pass an empty
25555 2002-07-27 Martin Baulig <martin@gnome.org>
25557 Mono 0.13 has been released.
25559 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25561 * driver.cs: Rename --resource to --linkres, because that is what
25562 we do currently, we dont support --resource yet.
25564 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25566 2002-07-25 Martin Baulig <martin@gnome.org>
25568 * class.cs (MethodData): New public class. This is a `method builder'
25569 class for a method or one accessor of a Property/Indexer/Event.
25570 (MethodData.GetMethodFlags): Moved here from MemberBase.
25571 (MethodData.ApplyAttributes): Likewise.
25572 (MethodData.ApplyObsoleteAttribute): Likewise.
25573 (MethodData.ApplyConditionalAttribute): Likewise.
25574 (MethodData.ApplyDllImportAttribute): Likewise.
25575 (MethodData.CheckAbstractAndExternal): Likewise.
25576 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25577 (MethodData.Emit): Formerly known as Method.Emit().
25578 (MemberBase): Moved everything which was specific to a single
25579 accessor/method to MethodData.
25580 (Method): Create a new MethodData and call Define() and Emit() on it.
25581 (Property, Indexer, Event): Create a new MethodData objects for each
25582 accessor and call Define() and Emit() on them.
25584 2002-07-25 Martin Baulig <martin@gnome.org>
25586 Made MethodCore derive from MemberBase to reuse the code from there.
25587 MemberBase now also checks for attributes.
25589 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25590 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25592 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25593 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25594 (MemberBase.ApplyAttributes): New virtual method; applies the
25595 attributes to a method or accessor.
25596 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25597 (MemberBase.ApplyConditionalAttribute): Likewise.
25598 (MemberBase.ApplyDllImportAttribute): Likewise.
25599 (MemberBase.CheckAbstractAndExternal): Likewise.
25600 (MethodCore.ParameterTypes): This is now a property instead of a
25601 method, it's initialized from DoDefineParameters().
25602 (MethodCore.ParameterInfo): Removed the set accessor.
25603 (MethodCore.DoDefineParameters): New protected virtual method to
25604 initialize ParameterTypes and ParameterInfo.
25605 (Method.GetReturnType): We can now simply return the MemberType.
25606 (Method.GetMethodFlags): Override the MemberBase version and add
25607 the conditional flags.
25608 (Method.CheckBase): Moved some code from Define() here, call
25609 DoDefineParameters() here.
25610 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25611 here to avoid some larger code duplication.
25612 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25613 ensure that abstract and external accessors don't declare a body.
25615 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25616 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25617 lookup in the attribute's parent classes, so we need to abort as soon
25618 as we found the first match.
25619 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25620 the attribute has no arguments.
25622 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25625 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25627 * cs-parser.jay: reverted previous patch.
25629 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25631 * cs-parser.jay: fixed bug #22119.
25633 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25635 * attribute.cs: fixed compilation. The error was:
25636 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25637 be assigned to before control leaves the current method."
25638 [FIXME: Filed as bug #28186: MCS must report this error.]
25640 2002-07-25 Martin Baulig <martin@gnome.org>
25642 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25643 method to pull the condition name ouf of a Conditional attribute.
25644 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25645 the obsolete message and error flag out of an Obsolete attribute.
25647 * class.cs (Method.GetMethodFlags): New public method to get the
25648 TypeManager.MethodFlags for this method.
25649 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25651 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25652 if we're overriding a virtual function, set the new private variable
25653 `parent_method'; call the new TypeManager.AddMethod().
25655 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25656 the MethodBuilder and the Method in a PtrHashtable.
25657 (TypeManager.builder_to_method): Added for this purpose.
25658 (TypeManager.MethodFlags): Added IsObsoleteError.
25659 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25660 Obsolete and Conditional arguments in MethodBuilders. If we discover
25661 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25662 the message from the attribute.
25664 2002-07-24 Martin Baulig <martin@gnome.org>
25666 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25667 preprocessor directives, ensure that the argument to #define/#undef is
25668 exactly one identifier and that it's actually an identifier.
25670 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25673 2002-07-24 Martin Baulig <martin@gnome.org>
25675 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25676 initialize it to TypeManager.object_type in the constructor.
25677 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25678 of the `hm.get_current' method if we're using the collection pattern.
25679 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25680 for the explicit conversion to make it work when we're using the collection
25681 pattern and the `Current' property has a different return type than `object'.
25684 2002-07-24 Martin Baulig <martin@gnome.org>
25686 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25687 does not match, but don't report any errors. This method is called in
25688 order for all methods in a MethodGroupExpr until a matching method is
25689 found, so we don't want to bail out if the first method doesn't match.
25690 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25691 matches, report the 123. Fixes #28070.
25693 2002-07-24 Martin Baulig <martin@gnome.org>
25695 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25696 TypeManager.TypeToCoreType() to the top of the method so the
25697 following equality checks will work. Fixes #28107.
25699 2002-07-24 Martin Baulig <martin@gnome.org>
25701 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25702 operand is of type uint, and the other operand is of type sbyte,
25703 short or int, the operands are converted to type long." -
25704 Actually do what this comment already told us. Fixes bug #28106,
25707 2002-07-24 Martin Baulig <martin@gnome.org>
25709 * class.cs (MethodBase): New abstract class. This is now a base
25710 class for Property, Indexer and Event to avoid some code duplication
25711 in their Define() and DefineMethods() methods.
25712 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25713 generic methods for Define() and DefineMethods().
25714 (FieldBase): Derive from MemberBase, not MemberCore.
25715 (Property): Derive from MemberBase, not MemberCore.
25716 (Property.DefineMethod): Moved all the code from this method to the
25717 new MethodBase.DefineAccessor(), just call it with appropriate
25719 (Property.Define): Call the new Property.DoDefine(), this does some
25720 sanity checks and we don't need to duplicate the code everywhere.
25721 (Event): Derive from MemberBase, not MemberCore.
25722 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25723 accessors, this will also make them work with interface events.
25724 (Indexer): Derive from MemberBase, not MemberCore.
25725 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25726 (Indexer.Define): Use the new MethodBase functions.
25728 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25729 argument to the constructor.
25730 (Interface.FindMembers): Added support for interface events.
25731 (Interface.PopluateEvent): Implemented.
25733 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25735 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25737 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25738 but this is required to check for a method name being the same as
25739 the containing class.
25743 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25745 * interface.cs: initialize variable.
25747 2002-07-23 Martin Baulig <martin@gnome.org>
25749 Implemented the IndexerName attribute in interfaces.
25751 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25752 name if this is an explicit interface implementation.
25753 (Indexer.InterfaceIndexerName): New public variable. If we're
25754 implementing an interface indexer, this is the IndexerName in that
25755 interface. Otherwise, it's the IndexerName.
25756 (Indexer.DefineMethod): If we're implementing interface indexer,
25757 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25758 and Pending.ImplementIndexer methods.
25759 (Indexer.Define): Also define the PropertyBuilder if we're
25760 implementing an interface indexer and this is neither an explicit
25761 interface implementation nor do the IndexerName match the one in
25764 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25765 If a method is defined here, then we always need to create a proxy
25766 for it. This is used when implementing interface indexers.
25767 (Pending.IsInterfaceIndexer): New public method.
25768 (Pending.ImplementIndexer): New public method.
25769 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25770 This is used when implementing interface indexers to define a proxy
25772 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25773 define a proxy if necessary.
25775 * interface.cs (Interface.IndexerName): New public variable.
25776 (Interface.PopulateIndexer): Set the IndexerName.
25777 (Interface.DefineIndexers): New private method. Populate all the
25778 indexers and make sure their IndexerNames match.
25780 * typemanager.cs (IndexerPropertyName): Added support for interface
25783 2002-07-22 Martin Baulig <martin@gnome.org>
25785 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25786 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25787 ret if HasReturnLabel.
25788 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25791 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25792 and set the ec.LoopBeginTryCatchLevel.
25793 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25794 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25795 the current ec.TryCatchLevel, the branch goes out of an exception
25796 block. In this case, we need to use Leave and not Br.
25798 2002-07-22 Martin Baulig <martin@gnome.org>
25800 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25801 block unless the block does not always return or it is contained in
25802 another try { ... } catch { ... } block. Fixes bug #26506.
25803 Added verify-1.cs to the test suite.
25805 2002-07-22 Martin Baulig <martin@gnome.org>
25807 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25808 then we do not always return. Fixes bug #24985.
25810 2002-07-22 Martin Baulig <martin@gnome.org>
25812 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25813 lookup on a per-class level; ie. walk up the class hierarchy until we
25814 found at least one applicable method, then choose the best among them.
25815 Fixes bug #24463 and test-29.cs.
25817 2002-07-22 Martin Baulig <martin@gnome.org>
25819 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25820 return types of the methods. The return type is not part of the
25821 signature and we must not check it to make the `new' modifier work.
25822 Fixes bug #27999, also added test-147.cs.
25823 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25825 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25826 on the method's return type.
25828 2002-07-21 Martin Baulig <martin@gnome.org>
25830 * assign.cs: Make this work if the rightmost source is a constant and
25831 we need to do an implicit type conversion. Also adding a few more tests
25832 to test-38.cs which should have caught this.
25834 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25835 target in the makefile for this. The makefile.gnu is primarily intended
25836 for end-users who don't want to debug the compiler.
25838 2002-07-21 Martin Baulig <martin@gnome.org>
25840 * assign.cs: Improved the Assign class so it can now handle embedded
25841 assignments (X = Y = Z = something). As a side-effect this'll now also
25842 consume less local variables. test-38.cs now passes with MCS, added
25843 a few new test cases to that test.
25845 2002-07-20 Martin Baulig <martin@gnome.org>
25847 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25848 instructions. Fixes bug #27977, also added test-146.cs.
25850 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25852 * cs-tokenizer.cs: fixed getHex ().
25854 2002-07-19 Martin Baulig <martin@gnome.org>
25856 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25857 not Type.GetType() to lookup the array type. This is needed when
25858 we're constructing an array of a user-defined type.
25859 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25860 single-dimensional arrays, but also for single-dimensial arrays of
25863 2002-07-19 Martin Baulig <martin@gnome.org>
25865 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25866 this function is called, it's not allowed to share LocalBuilders
25867 among ILGenerators.
25869 2002-07-19 Martin Baulig <martin@gnome.org>
25871 * expression.cs (Argument.Resolve): Report an error 118 when trying
25872 to pass a type as argument.
25874 2002-07-18 Martin Baulig <martin@gnome.org>
25876 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25877 Conv_R_Un for the signed `long' type.
25879 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25881 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25882 `expr' for the temporary result, as that will fail if we do
25883 multiple resolves on the same expression.
25885 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25887 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25888 ec.TypeContainer for looking up aliases.
25890 * class.cs (TypeContainer): Remove LookupAlias from here.
25892 * decl.cs (DeclSpace); Move here.
25894 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25896 * class.cs (FindMembers): Only call filter if the constructor
25897 bulider is not null.
25899 Also handle delegates in `NestedTypes' now. Now we will perform
25900 type lookups using the standard resolution process. This also
25903 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25904 This uses Expressions (the limited kind that can be parsed by the
25905 tree) instead of strings.
25907 * expression.cs (ComposedCast.ToString): Implement, used to flag
25908 errors since now we have to render expressions.
25910 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25913 * ecore.cs (SimpleName.ToString): ditto.
25915 * cs-parser.jay: Instead of using strings to assemble types, use
25916 Expressions to assemble the type (using SimpleName, ComposedCast,
25917 MemberAccess). This should fix the type lookups in declarations,
25918 because we were using a different code path for this.
25920 * statement.cs (Block.Resolve): Continue processing statements
25921 even when there is an error.
25923 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25925 * class.cs (Event.Define): Also remove the `remove' method from
25926 the list of pending items.
25928 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25929 generate more compact code.
25931 2002-07-17 Martin Baulig <martin@gnome.org>
25933 * const.cs (Const.LookupConstantValue): Add support for constant
25934 `unchecked' and `checked' expressions.
25935 Also adding test case test-140.cs for this.
25937 2002-07-17 Martin Baulig <martin@gnome.org>
25939 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25940 check whether mi.ReturnType implements the IEnumerator interface; the
25941 `==' and the IsAssignableFrom() will fail in this situation.
25943 2002-07-16 Ravi Pratap <ravi@ximian.com>
25945 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25948 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25950 * expression.cs: fixed bug #27811.
25952 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25954 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25955 Molaro: when we are a ref, the value already contains a pointer
25956 value, do not take the address of it.
25958 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25959 * removed mb-parser.jay and mb-tokenizer.cs
25961 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25963 * expression.cs: check against the building corlib void type.
25965 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25967 * ecore.cs: fix for valuetype static readonly fields: when
25968 initializing them, we need their address, not the address of a copy.
25970 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25972 * typemanager.cs: register also enum_type in corlib.
25974 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25976 * class.cs: allow calling this (but not base) initializers in structs.
25978 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25980 * ecore.cs: make sure we compare against the building base types
25983 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25985 * typemanager.cs: fix TypeToCoreType() to handle void and object
25986 (corlib gets no more typerefs after this change).
25988 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25990 * expression.cs (ArrayCreation.EmitArrayArguments): use
25991 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25993 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25994 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25995 array indexes, the runtime actually forbids them.
25997 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25998 for array arguments here.
26000 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26001 instead of the default for ValueTypes.
26003 (New.DoEmit): Use IsValueType instead of
26004 IsSubclassOf (value_type)
26005 (New.DoResolve): ditto.
26006 (Invocation.EmitCall): ditto.
26008 * assign.cs (Assign): ditto.
26010 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26011 Statements *are* currently doing part of their resolution during
26014 Expressions do always resolve during resolve, but statements are
26015 only required to propagate resolution to their children.
26017 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26019 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26021 (LoadAssembly): Do not add the dll if it is already specified
26023 (MainDriver): Add the System directory to the link path at the end,
26024 after all the other -L arguments.
26026 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26027 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26028 ldelem.u1) and using the opposite for sbytes.
26030 This fixes Digger, and we can finally run it.
26032 * driver.cs (UnixParseOption): Move the option parsing here.
26033 (CSCParseOption): Implement CSC-like parsing of options.
26035 We now support both modes of operation, the old Unix way, and the
26036 new CSC-like way. This should help those who wanted to make cross
26037 platform makefiles.
26039 The only thing broken is that /r:, /reference: and /lib: are not
26040 implemented, because I want to make those have the same semantics
26041 as the CSC compiler has, and kill once and for all the confussion
26042 around this. Will be doing this tomorrow.
26044 * statement.cs (Unsafe.Resolve): The state is checked during
26045 resolve, not emit, so we have to set the flags for IsUnsfe here.
26047 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26049 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26050 not catch the Error_ObjectRefRequired in SimpleName (as it is
26051 possible to have a class/instance variable name that later gets
26052 deambiguated), we have to check this here.
26054 2002-07-10 Ravi Pratap <ravi@ximian.com>
26056 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26057 make static and put into Expression.
26059 (Event.Define): Register the private field of the event with the
26060 TypeManager so that GetFieldFromEvent can get at it.
26062 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26063 keep track of the private field associated with an event which
26066 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26069 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26071 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26073 * expression.cs (Binary.EmitBranchable): this routine emits the
26074 Binary expression in a branchable context. This basically means:
26075 we need to branch somewhere, not just get the value on the stack.
26077 This works together with Statement.EmitBoolExpression.
26079 * statement.cs (Statement.EmitBoolExpression): Use
26082 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26084 * statement.cs (For): Reduce the number of jumps in loops.
26086 (For): Implement loop inversion for the For statement.
26088 (Break): We can be breaking out of a Try/Catch controlled section
26089 (foreach might have an implicit try/catch clause), so we need to
26090 use Leave instead of Br.
26092 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26093 now). If the instace expression supports IMemoryLocation, we use
26094 the AddressOf method from the IMemoryLocation to extract the
26095 address instead of emitting the instance.
26097 This showed up with `This', as we were emitting the instance
26098 always (Emit) instead of the Address of This. Particularly
26099 interesting when This is a value type, as we dont want the Emit
26100 effect (which was to load the object).
26102 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26104 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26106 * statement.cs (Checked): Set the CheckedState during the resolve
26107 process too, as the ConvCast operations track the checked state on
26108 the resolve process, and not emit.
26110 * cs-parser.jay (namespace_member_declaration): Flag that we have
26111 found a declaration when we do. This is used to flag error 1529
26113 * driver.cs: Report ok when we display the help only.
26115 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26117 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26119 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26121 * cs-tokenizer.cs (define): We also have to track locally the
26122 defines. AllDefines is just used for the Conditional Attribute,
26123 but we also need the local defines for the current source code.
26125 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26127 * statement.cs (While, For, Do): These loops can exit through a
26128 Break statement, use this information to tell whether the
26129 statement is the last piece of code.
26131 (Break): Flag that we break.
26133 * codegen.cs (EmitContexts): New `Breaks' state variable.
26135 2002-07-03 Martin Baulig <martin@gnome.org>
26137 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26138 modifiers in method declarations in structs. Otherwise, you won't
26139 be able to override things like Object.Equals().
26141 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26143 * class.cs (Method, Property, Indexer): Do not allow the public
26144 modifier to be used in explicit interface implementations.
26146 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26147 override modifiers in method declarations in structs
26149 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26151 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26152 integer or real overflow, report an error
26154 2002-07-02 Martin Baulig <martin@gnome.org>
26156 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26157 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26158 to tell the runtime about our newly created System.Object and
26159 System.ValueType types.
26161 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26163 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26164 struct instead of Ldarg/Starg.
26166 2002-07-02 Martin Baulig <martin@gnome.org>
26168 * expression.cs (Indirection.Indirection): Call
26169 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26171 2002-07-02 Martin Baulig <martin@gnome.org>
26173 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26174 ValueType, call TypeManager.TypeToCoreType() on it.
26175 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26176 the OpCodes.Newarr argument.
26178 2002-07-02 Martin Baulig <martin@gnome.org>
26180 * expression.cs (Invocation.EmitCall): When compiling corlib,
26181 replace all calls to the system's System.Array type to calls to
26182 the newly created one.
26184 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26185 System.Array methods.
26186 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26187 from the system's System.Array type which must be replaced.
26189 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26191 * typemanager.cs: load unverifiable_code_ctor so we can build
26192 corlib using the correct type. Avoid using GetTypeCode() with
26194 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26195 TypeManager.object_type to allow building corlib.
26197 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26199 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26201 2002-07-01 Martin Baulig <martin@gnome.org>
26203 * class.cs: Make the last change actually work, we need to check
26204 whether `ifaces != null' to avoid a crash.
26206 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26208 * class.cs: when we build structs without fields that implement
26209 interfaces, we need to add the interfaces separately, since there is
26210 no API to both set the size and add the interfaces at type creation
26213 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26215 * expression.cs: the dimension arguments to the array constructors
26216 need to be converted if they are a long.
26218 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26220 * class.cs: don't emit ldarg.0 if there is no parent constructor
26221 (fixes showstopper for corlib).
26223 2002-06-29 Martin Baulig <martin@gnome.org>
26225 MCS now compiles corlib on GNU/Linux :-)
26227 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26228 ie. check for MethodImplOptions.InternalCall.
26230 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26231 and TypeManager.attribute_type are null, so we must explicitly check
26232 whether parent is not null to find out whether it's an attribute type.
26233 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26234 and SetBuilder, not only if the property is neither abstract nor external.
26235 This is necessary to set the MethodImplOptions on the accessor methods.
26236 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26237 SetBuilder, see Property.Emit().
26239 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26240 populate "System.Object", "System.ValueType" and "System.Attribute" since
26241 they've already been populated from BootCorlib_PopulateCoreTypes().
26243 2002-06-29 Martin Baulig <martin@gnome.org>
26245 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26246 is the NullLiteral, we also need to make sure that target_type is not
26249 2002-06-29 Martin Baulig <martin@gnome.org>
26251 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26252 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26253 before calling BootstrapCorlib_ResolveDelegate ().
26255 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26257 * statement.cs: fixed build-breaker. All tests passed ok.
26259 2002-06-27 Martin Baulig <martin@gnome.org>
26261 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26262 for System.Decimal when compiling corlib.
26264 2002-06-27 Martin Baulig <martin@gnome.org>
26266 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26267 switch blocks which contain nothing but a default clause.
26269 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26271 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26273 2002-06-27 Martin Baulig <martin@gnome.org>
26275 * ecore.cs (PropertyExpr.PropertyExpr): Call
26276 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26278 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26279 is already a TypeBuilder.
26281 2002-06-27 Martin Baulig <martin@gnome.org>
26283 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26284 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26285 the "from an array-type to System.Array" case. This makes it work
26286 when compiling corlib.
26288 2002-06-27 Martin Baulig <martin@gnome.org>
26290 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26291 non-static PropertyExpr, set its InstanceExpression. This makes
26292 the `ICollection.Count' property work in System/Array.cs.
26294 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26296 * driver.cs: Made error handling more consistent. Errors now
26297 tracked by Report class, so many methods which used to return int
26298 now return void. Main() now prints success/failure and
26299 errors/warnings message.
26301 Renamed '--probe' compiler argument to '--expect-error'. Removed
26302 the magic number return values (123 and 124). Now, if the
26303 expected error occurs, the compiler exits with success (exit value
26304 0). If the compilation completes without seeing that particular
26305 error, the compiler exits with failure (exit value 1). The
26306 makefile in mcs/errors has been changed to handle the new behaviour.
26308 * report.cs: Made 'expected error' number a property and renamed
26309 it from 'Probe' to 'ExpectedError'.
26311 * genericparser.cs: Removed error handling support, since it is
26312 now all done by Report class.
26314 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26315 class, so parse() no longer returns an int.
26317 * namespace.cs: Use Report.Error instead of GenericParser.error
26319 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26321 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26322 TypeContainer.AddOperator): At the front of the list put the
26323 explicit implementations, so they get resolved/defined first.
26325 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26327 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26328 interface type is implemented by this TypeContainer. Used during
26329 explicit interface implementation.
26331 (Property.Define, Indexer.Define, Method.Define): Validate that
26332 the given interface in the explicit implementation is one of the
26333 base classes for the containing type.
26335 Also if we are explicitly implementing an interface, but there is
26336 no match in the pending implementation table, report an error.
26338 (Property.Define): Only define the property if we are
26339 not explicitly implementing a property from an interface. Use the
26340 correct name also for those properties (the same CSC uses,
26341 although that is really not needed).
26343 (Property.Emit): Do not emit attributes for explicitly implemented
26344 properties, as there is no TypeBuilder.
26346 (Indexer.Emit): ditto.
26348 Hiding then means that we do not really *implement* a pending
26349 implementation, which makes code fail.
26351 2002-06-22 Martin Baulig <martin@gnome.org>
26353 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26354 the return value of Object.GetType(). [FIXME: we need to do this whenever
26355 we get a type back from the reflection library].
26357 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26359 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26361 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26363 * attribute.cs: Return null if we can not look up the type.
26365 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26366 the interface types found.
26368 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26369 interface types found.
26371 * typemanager.cs (GetInterfaces): Make this routine returns alll
26372 the interfaces and work around the lame differences between
26373 System.Type and System.Reflection.Emit.TypeBuilder in the results
26374 result for GetInterfaces.
26376 (ExpandInterfaces): Given an array of interface types, expand and
26377 eliminate repeated ocurrences of an interface. This expands in
26378 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26381 2002-06-21 Martin Baulig <martin@gnome.org>
26383 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26386 2002-06-21 Martin Baulig <martin@gnome.org>
26388 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26389 and called with one of the core types, return the corresponding typebuilder for
26392 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26395 2002-06-21 Martin Baulig <martin@gnome.org>
26397 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26398 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26399 (Expression.ConvertReferenceExplicit): Likewise.
26401 * expression.cs (ElementAccess.DoResolve): Likewise.
26402 (ElementAccess.DoResolveLValue): Likewise.
26404 2002-06-10 Martin Baulig <martin@gnome.org>
26406 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26407 add the "value" parameter to the parameter list.
26409 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26412 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26414 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26415 the argument to an int, uint, long or ulong, per the spec. Also
26416 catch negative constants in array creation.
26418 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26420 * class.cs: do not allow the same interface to appear twice in
26421 the definition list.
26423 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26425 * ecore.cs: don't use ldlen with System.Array.
26427 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26429 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26431 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26433 * modifiers.cs: produce correct field attributes for protected
26434 internal. Easy fix so miguel can work on ther harder stuff:-)
26436 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26438 * pending.cs: New file. Move the code from class.cs here.
26439 Support clearning the pending flag for all methods (when not doing
26440 explicit interface implementation).
26442 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26444 * rootcontext.cs: added a couple more types needed to bootstrap.
26446 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26448 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26449 constructor in the type, instead of any constructor in the type
26450 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26451 a bug in the Mono runtime when applying the params attribute).
26453 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26454 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26456 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26458 * expression.cs (Unary.ResolveOperator): Use TypeManager
26459 to resolve the type.
26461 2002-06-13 Ravi Pratap <ravi@ximian.com>
26463 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26466 * enum.cs (AddEnumMember): Add support to store the attributes associated
26467 with each member too.
26469 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26470 field builders too - this takes care of the enum member case.
26472 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26474 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26475 address-of operator on both value types and pointers.
26477 2002-06-10 Martin Baulig <martin@gnome.org>
26479 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26480 PropertyBuilder to the `property_builders' list.
26482 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26483 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26484 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26485 find any indexers which are inherited from an interface.
26487 2002-06-09 Martin Baulig <martin@gnome.org>
26489 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26490 the same type as the constant if necessary. There's also a test-130.cs
26493 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26495 * typemanager.cs (TypeManager.ChangeType): Previously known as
26496 Enum.ChangeEnumType().
26498 2002-06-09 Martin Baulig <martin@gnome.org>
26500 * expression.cs (Cast.TryReduce): Added support for consts.
26502 2002-06-08 Ravi Pratap <ravi@ximian.com>
26504 * class.cs (Accessor): Hold attributes information so we can pass
26507 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26508 Modify to pass in attributes attached to the methods.
26510 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26512 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26513 to handle the Accessor kind :-)
26515 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26517 2002-06-08 Martin Baulig <martin@gnome.org>
26519 * expression.cs (Unary.TryReduceNegative): Added support for
26522 2002-06-08 Martin Baulig <martin@gnome.org>
26524 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26525 name can't be found in the `defined_names' - the caller will do a
26526 MemberLookup in this case and thus find methods in System.Enum
26527 such as Enum.IsDefined().
26529 2002-06-08 Martin Baulig <martin@gnome.org>
26531 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26532 Convert.ChangeType() which works with TypeBuilder created types.
26533 (Enum.LookupEnumValue, Enum.Define): Use it here.
26535 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26536 `TypeBuilder.BaseType != null' check.
26537 (TypeContainer.FindMembers): Only lookup parent members if we
26538 actually have a parent.
26539 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26540 (ConstructorInitializer.Resolve): Likewise.
26542 * interface.cs (Interface.FindMembers): Added
26543 `TypeBuilder.BaseType != null' check.
26545 * rootcontext.cs (RootContext.ResolveCore): Added
26546 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26547 classes_second_stage.
26549 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26550 debug_type and trace_type when compiling with --nostdlib.
26552 2002-06-07 Martin Baulig <martin@gnome.org>
26554 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26555 (AddField): Set it to true when adding a non-static field.
26556 (DefineType): Use `have_nonstatic_fields' to find out whether we
26557 have non-static fields, not `Fields != null'.
26559 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26561 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26562 dereferencing a null on the static-field code path)
26564 2002-05-30 Martin Baulig <martin@gnome.org>
26566 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26567 to take command line arguments. Use reflection to call the new
26568 custom `Initialize' function on the symbol writer and pass it the
26569 command line arguments.
26571 * driver.cs (--debug-args): New command line argument to pass command
26572 line arguments to the symbol writer.
26574 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26576 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26577 the target type for indexers and properties. Thanks to Joe for
26580 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26582 * typemanager.cs (MethodFlags): returns the method flags
26583 (Obsolete/ShouldIgnore) that control warning emission and whether
26584 the invocation should be made, or ignored.
26586 * expression.cs (Invocation.Emit): Remove previous hack, we should
26587 not do this on matching a base type, we should do this based on an attribute
26589 Only emit calls to System.Diagnostics.Debug and
26590 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26591 on the command line.
26593 * rootcontext.cs: Global settings for tracing and debugging.
26595 * cs-tokenizer.cs (define): New utility function to track
26596 defines. Set the global settings for TRACE and DEBUG if found.
26598 2002-05-25 Ravi Pratap <ravi@ximian.com>
26600 * interface.cs (Populate*): Pass in the TypeContainer as well as
26601 the DeclSpace as parameters so that we can create EmitContexts and
26602 then use that to apply attributes etc.
26604 (PopulateMethod, PopulateEvent, PopulateProperty)
26605 (PopulateIndexer): Apply attributes everywhere.
26607 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26610 (ApplyAttributes): Update accordingly.
26612 We now apply interface attributes for all members too.
26614 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26616 * class.cs (Indexer.Define); Correctly check if we are explicit
26617 implementation (instead of checking the Name for a ".", we
26618 directly look up if the InterfaceType was specified).
26620 Delay the creation of the PropertyBuilder.
26622 Only create the PropertyBuilder if we are not an explicit
26623 interface implementation. This means that explicit interface
26624 implementation members do not participate in regular function
26625 lookups, and hence fixes another major ambiguity problem in
26626 overload resolution (that was the visible effect).
26628 (DefineMethod): Return whether we are doing an interface
26631 * typemanager.cs: Temporary hack until we get attributes in
26632 interfaces (Ravi is working on that) and we get IndexerName
26633 support in interfaces.
26635 * interface.cs: Register the indexers as properties.
26637 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26638 warning, I have verified that this is a bug in the .NET runtime
26639 (JavaScript suffers of the same problem).
26641 * typemanager.cs (MemberLookup): When looking up members for
26642 interfaces, the parent of an interface is the implicit
26643 System.Object (so we succeed in searches of Object methods in an
26644 interface method invocation. Example: IEnumerable x; x.ToString
26647 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26649 * class.cs (Event): Events should also register if they do
26650 implement the methods that an interface requires.
26652 * typemanager.cs (MemberLookup); use the new GetInterfaces
26655 (GetInterfaces): The code used to lookup interfaces for a type is
26656 used in more than one place, factor it here.
26658 * driver.cs: Track the errors at the bottom of the file, we kept
26661 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26662 instance if the method we are calling is static!
26664 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26666 * attribute.cs (ApplyAttributes): Make this function filter out
26667 the IndexerName attribute (as that attribute in reality is never
26668 applied) and return the string constant for the IndexerName
26671 * class.cs (TypeContainer.Emit): Validate that all the indexers
26672 have the same IndexerName attribute, and if so, set the
26673 DefaultName attribute on the class.
26675 * typemanager.cs: The return value might contain other stuff (not
26676 only methods). For instance, consider a method with an "Item"
26677 property and an Item method.
26679 * class.cs: If there is a problem with the parameter types,
26682 2002-05-24 Ravi Pratap <ravi@ximian.com>
26684 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26685 looks at user defined conversion after making a call to
26686 StandardConversionExists - we need this for overload resolution.
26688 * expression.cs : Update accordingly the various method calls.
26690 This fixes 2 bugs filed against implicit user defined conversions
26692 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26694 * statement.cs: Track the result of the assignment.
26696 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26698 * expression.cs (MemberAccess): Improved error reporting for
26699 inaccessible members.
26701 2002-05-22 Martin Baulig <martin@gnome.org>
26703 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26704 itself with debugging support.
26706 2002-05-22 Martin Baulig <martin@gnome.org>
26708 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26709 Removed, this isn't needed anymore.
26711 2002-05-20 Martin Baulig <martin@gnome.org>
26713 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26714 be underlying type for an enum.
26716 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26718 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26719 that splits out the loading of just the core types.
26721 * rootcontext.cs (ResolveCore): Split the struct resolution in
26722 two, so we can load the enumeration underlying types before any
26725 * expression.cs (Is): Bandaid until we fix properly Switch (see
26726 bug #24985 for details).
26728 * typemanager.cs (ImplementsInterface): The hashtable will contain
26729 a null if there are no interfaces implemented.
26731 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26733 * cs-parser.jay (indexer_declarator): It is fine to have array
26736 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26738 * typemanager.cs: (RegisterBuilder): New function used to register
26739 TypeBuilders that implement interfaces. Since
26740 TypeBuilder.GetInterfaces (as usual) does not work with lame
26742 (AddUserType): register interfaces.
26744 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26745 dealing with TypeBuilder. Also, arrays are showing up as
26746 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26747 methods can not be invoked on them!
26749 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26750 (ImplicitReferenceConversionExists): Split out from
26751 StandardConversionExists.
26753 * expression.cs (As): We were only implementing one of the three
26754 cases for the as operator. We now implement them all.
26755 (Is): Implement the various other cases for Is as well.
26757 * typemanager.cs (CACHE): New define used to control if we want or
26758 not the FindMembers cache. Seems to have a negative impact on
26759 performance currently
26761 (MemberLookup): Nested types have full acess to
26762 enclosing type members
26764 Remove code that coped with instance/static returns for events, we
26765 now catch this in RealFindMembers.
26767 (RealFindMembers): only perform static lookup if the instance
26768 lookup did not return a type or an event.
26770 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26772 * assign.cs (CompoundAssign): We pass more semantic information
26773 now to Compound Assignments than we did before: now we have all
26774 the information at hand, and now we resolve the target *before* we
26775 do the expression expansion, which allows the "CacheValue" method
26776 to have the effect we intended (before, a [x] += 1 would generate
26777 two differen ArrayAccess expressions from the ElementAccess,
26778 during the resolution process).
26780 (CompoundAssign.DoResolve): Resolve target and original_source here.
26782 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26784 * expression.cs (ArrayAccess): dropped debugging information.
26786 * typemanager.cs: Small bug fix: I was always returning i_members,
26787 instead of one of i_members or s_members (depending on which had
26790 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26791 method is invoked before any code generation takes place, and it
26792 is a mechanism to inform that the expression will be invoked more
26793 than once, and that the method should use temporary values to
26794 avoid having side effects
26796 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26798 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26801 * expression.cs (Indirection, ArrayAccess): Add support for
26802 CacheTemporaries in these two bad boys.
26804 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26805 ldobj or ldind_ref.
26806 (StoreFromPtr): Handle stobj as well.
26808 * expression.cs (UnaryMutator): Share more code.
26810 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26811 down: I was not tracking the Filter function as well, which
26812 was affecting the results of the cache.
26814 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26816 * attribute.cs: Remove the hack to handle the CharSet property on
26819 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26821 * attribute.cs (DoResolve): More uglyness, we now only try to
26822 resolve the attribute partially, to extract the CharSet
26823 information (only if we are a StructLayout attribute). Otherwise
26825 (GetExtraTypeInfo): Add some code to conditionally kill in the
26826 future this. I am more and more convinced that the .NET
26827 framework has special code to handle the attribute setting on
26830 * expression.cs (IsParamsMethodApplicable): Revert my previous
26831 foreach change here, it was wrong.
26833 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26835 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26836 (pp_expr): do not abort on unknown input, just return.
26837 (eval): abort if there are pending chars.
26839 * attribute.cs (Attribute.Resolve): Positional parameters are
26840 optional. Deal with that case.
26842 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26843 the Ansi/Unicode/Auto information for the type.
26845 (TypeContainer.DefineType): instantiate the EmitContext here, as
26846 we will be using it during the type definition (to resolve
26847 attributes) and during the emit phase.
26849 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26850 to pull type information out of the attributes
26852 (Attribute.Resolve): track the constructor builder, and allow for
26853 multiple invocations (structs and classes will use this).
26855 * ecore.cs (MemberLookupFinal): new version with all the
26856 parameters customizable.
26858 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26859 constructors. Return if the result value is null (as the error
26860 would have been flagged already by MemberLookupFinal)
26862 Do not allow instances of abstract classes or interfaces to be
26865 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26866 We have to compare the assembly property here when dealing with
26867 FamANDAssem and Assembly access modifiers, because we might be
26868 creating an assembly from *modules* (that means that we are not
26869 getting TypeBuilders for types defined in other modules that are
26870 part of this assembly).
26872 (Method.Emit): If the method is marked abstract and has a body,
26875 (TypeContainer.DefineMembers): If both the defined member and the
26876 parent name match are methods, then do not emit any warnings: let
26877 the Method.Define routine take care of flagging warnings. But if
26878 there is a mismatch (method overrides something else, or method is
26879 overriwritten by something, then emit warning).
26881 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26882 set to null, this means `do not check for the return type on the
26885 (Method.Define): set the return type for the method signature to
26886 null, so that we get methods with the same name and parameters and
26887 different return types. This is used to flag warning 114 (you are
26888 hiding a method, and you probably want to use the new/override
26891 * typemanager.cs (MemberLookup): Implemented proper access
26892 control, closing a long standing set of bug reports. The problem
26893 was that the Framework only has two bits: Public and NonPublic,
26894 and NonPublic includes private and protected methods, but we need
26895 to enforce the FamANDAssem, FamOrAssem and Family.
26897 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26899 * statement.cs (GotoCase): Return true: Ammounts to giving up
26900 knowledge on whether we return or not, and letting the other case
26901 be responsible for it.
26903 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26905 * driver.cs: Do not load directories for each file processed, only
26906 do it if there is a pattern.
26908 * ecore.cs: Report readonly assigns here as well, as we might have
26909 been resolved only by MemberAccess.
26911 (SimpleName.SimpleNameResolve): Also be useful for LValue
26912 resolution. We need this to propagate assign to local readonly variables
26914 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26915 do not want to reuse potential criteria memory.
26917 * class.cs (MyEventBuilder): Set reflected_type;
26919 * ecore.cs (Constantify): Added support for constifying bools.
26921 (RootContext.LookupType): Added a cache for values looked up in
26922 the declaration space.
26924 * typemanager.cs (FindMembers): Now is a front-end to
26925 RealFindMembers, and provides a two-level hashtable-based cache to
26928 15% performance improvement: from 22.5 to 19.2 seconds.
26930 * expression.cs (IsParamsMethodApplicable): use foreach.
26931 (Invocation.DoResolve): ditto.
26932 (New.DoResolve): ditto.
26933 (ArrayCreation.DoResolve): ditto.
26935 * ecore.cs (FindMostEncompassingType): use foreach.
26937 * delegate.cs (NewDelegate.DoResolve): Use foreach
26939 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26940 (RemoveMethods): use foreach.
26942 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26943 nested foreach statements instead of for, and also break out of
26944 the inner loop once a match is found.
26946 (Invocation.OverloadResolve): Use foreach, simplify the code.
26948 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26950 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26951 we actually unwrap the expression to allow for extra information
26954 * expression.cs: Use Shr_Un on unsigned operations.
26956 2002-05-08 Ravi Pratap <ravi@ximian.com>
26958 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26959 applicable operators was not being considered correctly. This closes
26960 the bug Miguel reported.
26962 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26964 * attribute.cs: check that the type derives from System.Attribute
26965 and report the correct error in that case (moved the duplicate code to
26966 its own method, too).
26968 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26970 * attribute.cs: lookup attribute type name as the spec says: first the
26971 bare attribute name and then name + "Attribute" (nant compiles with
26972 mcs after this fix).
26974 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26976 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26977 Because of the way we parse things, we should try to see if a
26978 UIntConstant can fit in an integer.
26980 2002-05-07 Ravi Pratap <ravi@ximian.com>
26982 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26983 when we are in an explicit context.
26985 (ConvertReferenceExplicit): When converting from Iface type S to Class
26986 T make sure the rules are implemented as an OR.
26988 * parameter.cs (ParameterType): Make it a property for now although the
26989 purpose really isn't anything immediate.
26991 * expression.cs (Is*Applicable): Do better checking on the parameter type
26992 of a ref/out parameter. The ones from the system assemblies are already
26993 marked with the correct type so we don't need to do any correction.
26995 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26996 the object type is standard too so include that.
26998 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27000 * ecore.cs (StandardConversionExists): Augment with missing code:
27001 deal with IntConstant, LongConstants and Enumerations.
27003 * assign.cs: Report the error, instead of failing silently
27005 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27006 typecontainer that they are declared, because the
27007 typecontainer/namespace will have the list of using clauses that
27008 need to be applied.
27010 Assembly Attributes were escaping the normal registration
27013 (EmitCode): Apply attributes within an EmitContext that represents
27014 the container they were declared on.
27016 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27018 2002-05-06 Ravi Pratap <ravi@ximian.com>
27020 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27021 Revamp completely - make much cleaner as we now operate only
27024 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27025 to implement the logic detailed in the spec more correctly.
27027 (UserDefinedConversion): Update accordingly.
27029 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27031 * statement.cs: Return flow analysis information up.
27033 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27036 (token): Do not consume an extra character before calling
27039 2002-05-06 Piers Haken <piersh@friskit.com>
27041 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27043 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27045 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27046 EmitContext during the instance constructor initializer
27047 resolution, to stop access to instance variables.
27049 This is mandated by the spec, last paragraph of the `constructor
27050 initializers' section.
27052 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27054 * cs-parser.jay, class.cs (Accessor): new class used to represent
27055 an accessor (get or set). In the past we used `null' to represent
27056 a missing accessor. But this is ambiguous because there was no
27057 way to tell in abstract indexers/properties if one of them was
27060 Now there is a way of addressing that.
27062 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27063 instead of FindMembers.
27065 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27066 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27068 * attribute.cs: Treat indexers and properties as the same in terms
27069 of applying attributes
27071 * ecore.cs (FindMostEncompassedType): Use statically initialized
27072 EmptyExpressions()s like we do elsewhere to avoid creating useless
27073 objects (and we take this out of the tight loop).
27075 (GetConversionOperators): Move the code to extract the actual
27076 operators to a separate routine to clean things up.
27078 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27080 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27081 events are always registered FieldBuilders.
27083 * class.cs (FieldBase): New class shared by Fields
27085 * delegate.cs: If we are a toplevel delegate, use our full name.
27086 If we are a nested delegate, then only use our tail name.
27088 2002-05-02 Ravi Pratap <ravi@ximian.com>
27090 * expression.cs (IsApplicable): Ensure that we add the "&" to
27091 ref/out types before comparing it with the type of the argument.
27093 (IsParamsMethodApplicable): Ditto.
27095 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27098 * delegate.cs : Handle the case when we have more than one applicable
27099 method. Flag an error only when we finish checking all.
27101 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27103 * expression.cs: Add support for boolean static initializers.
27105 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27107 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27109 * parameter.cs (ComputeParameterTypes,
27110 ComputeAndDefineParameterTypes): Better error handling: now we
27111 clear the `types' cache if we fail during any of the type lookups.
27112 We also return the status code correctly to our caller
27114 * delegate.cs: If we fail to define a delegate, abort the extra
27117 * expression.cs (Binary.ResolveOperator): for
27118 operator==(object,object) and operator !=(object, object) we also
27119 have to verify that there is an implicit conversion from one to
27122 (ArrayAccess.DoResolve): Array Access can operate on
27125 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27127 * assign.cs (CompoundAssign): A new class used as a "flag" that
27128 the assignment actually is happening as part of a compound
27129 assignment operator.
27131 During compound assignment, a few new rules exist to enable things
27138 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27139 to the type of x) if y is implicitly convertible to the type of x,
27140 and the operator is a builtin operator and the return type of the
27141 operator is explicitly convertible to the type of x.
27143 * rootcontext.cs: Reset warning level to 2. 4 catches various
27144 "interesting" features in mcs, we must clean this up at some
27145 point, but currently am trying to kill other bugs ;-)
27147 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27148 in container classes as well.
27150 * expression.cs (Binary.ResolveOperator): Handle string case
27151 before anything else (as operator overloading does emit an error
27152 before doing anything else).
27154 This code could go away when we move to a table driven model, but
27155 i could not come up with a good plan last night.
27157 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27159 * typemanager.cs (CSharpName): reimplementation using regex.
27160 * class.cs: added null check for fields in Emit
27161 * rootcontext.cs: set warninglevel to 4
27163 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27165 * typemanager.cs (CSharpName): reimplemented with Lupus
27168 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27170 * statement.cs (If): correclty implement Resolve, because we were
27171 not catching sem errors in there. The same process is needed
27173 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27176 (Statement.Warning_DeadCodeFound): Factorize code.
27177 (While): Report dead code here too.
27179 (Statement): Added Resolve virtual method to allow
27180 for resolution split from the emit code.
27182 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27184 * statement.cs (EmitBoolExpression): No longer try to resolve the
27186 (MakeBoolean): New utility function that resolve, implicitly
27187 converts to boolean and tags the expression.
27190 (If, Do): Implement dead code elimination.
27191 (While): Implement loop inversion
27193 (Do, While, For, If): Resolve the expression prior to calling our
27196 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27199 - added method Report28 (warning: program has more than one entry point)
27200 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27201 - modified method Method.Define, the part at the end of the method
27203 * rootcontext.cs: added static public Location EntryPointLocation;
27205 * ../errors/cs0028.cs : Add test case for the above warning.
27208 - modified method CSharpName to allow arrays of primitive type to
27209 be printed nicely (e.g. instead of System.Int32[][] it now prints
27211 - added method CSharpSignature: returns the signature of a method
27212 in string format to be used in reporting errors, warnings, etc.
27214 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27217 2002-04-26 Ravi Pratap <ravi@ximian.com>
27219 * delegate.cs (Define): Fix extremely silly bug where I was
27220 setting the type of the 'object' parameter of the BeginInvoke
27221 method to System.IAsyncResult instead of System.Object ;-)
27223 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27225 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27228 (Constructor.Emit): return if we fail to initialize the
27229 constructor. Another door closed!
27231 * expression.cs (New.DoResolve): Improve error message (from -6 to
27232 1501). Use DeclaredOnly lookup to find the exact constructor.
27234 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27235 loop. This is useful.
27237 * cs-parser.jay: Adjust the default parameters so that destructors
27238 have the proper signature.
27240 2002-04-26 Martin Baulig <martin@gnome.org>
27242 * driver.cs (LoadAssembly): If `assembly' contains any characters
27243 which are only valid in path names and not in assembly names
27244 (currently slash, backslash and point), use Assembly.LoadFrom ()
27245 instead of Assembly.Load () on the `assembly' (before iteration
27246 over the link_paths).
27248 2002-04-26 Martin Baulig <martin@gnome.org>
27250 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27252 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27254 * class.cs (Property): use the new typemanager.MemberLookup
27256 (TypeContainer.MemberLookup): Implement using the
27257 TypeManager.MemberLookup now.
27259 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27260 and return MemberInfos, so that these can be used without an
27261 EmitContext (what we had before).
27263 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27265 * expression.cs: Fix the case where the argument to params if the
27266 type of the params. I omitted handling this before. Fixed
27268 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27270 * driver.cs: Call BootCorlib_PopulateCoreType
27272 * class.cs (Property.CheckBase): Check for properties only, not
27275 * interface.cs: Temporary hack: try/catch around the
27276 CustomAttributeBuilder, because I am getting an exception that I
27279 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27280 types whose definitions are required to be there (attributes are
27281 defined before standard types).
27283 Compute definitions as we boot the various types, as they are used
27284 immediately (value_type class will need object_type, but if we do
27285 not initialize object_type, we will pass a null, which will let
27286 the runtime pick the System.Object from the existing corlib, which
27287 is not what we want).
27289 2002-04-22 Patrik Torstensson <totte@labs2.com>
27291 * cs-tokenizer.cs: fixed a number of trim() issues.
27293 2002-04-22 Ravi Pratap <ravi@ximian.com>
27295 * expression.cs (Argument.Type): Ensure that we return the correct
27296 type when we have out or ref parameters [in which case we
27299 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27301 * class.cs (Property, Indexer): Allow extern modifier in there.
27303 * typemanager.cs (InitBaseTypes): Initializes object_type and
27304 value_type, since those will be used early on during the bootstrap
27305 process to compile corlib.
27307 (InitCoreTypes): Move code from here to InitBaseTypes.
27309 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27311 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27312 single-dimension arrays as using the ldlen opcode.
27314 Daniel Lewis discovered this optimization.
27316 * typemanager.cs: Add signature for System.Array::get_Length
27318 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27320 * statement.cs: report the error when the foreach does not apply to an
27321 array nor a collection.
27323 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27325 * expression.cs: Add implicit conversions to the operator ~.
27327 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27329 * typemanager.cs: Locate the decimal constructor.
27331 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27333 * attribute.cs: use the new property of TypeOf.
27334 * expression.cs: added 'get' property around typearg.
27336 These changes fix a build breaker reported by NickD. Is this the
27337 correct way to fix? If not, please, revert my changes and make it
27340 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27342 * attribute.cs: Add support for typeof in attribute invocations.
27343 I am not sure that this is right though.
27345 2002-04-14 Duncan Mak <duncan@ximian.com>
27347 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27348 Binary.Operator.Division case.
27350 2002-04-13 Ravi Pratap <ravi@ximian.com>
27352 * class.cs (DefineType): Ensure that we do a proper check on
27353 attribute types and also register it with the TypeManager.
27355 (TypeContainer.Targets): The default for attribute types is
27356 AttributeTargets.All.
27358 * attribute.cs (ApplyAttributes): Registering the attribute type
27359 is done elsewhere, not when we discover we have a Usage attribute.
27361 2002-04-12 Ravi Pratap <ravi@ximian.com>
27363 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27364 and get rid of is_delegate parameter.
27366 * everywhere : update.
27368 2002-04-12 Ravi Pratap <ravi@ximian.com>
27370 * cs-parser.jay (compilation_unit): Revamp completely to use
27371 some new ideas that I got from Rhys' grammar to solve the problems
27372 with assembly level attributes.
27374 (outer_declaration): New grammar production.
27376 (attribute_sections): Add.
27378 (opt_attributes): Base on attribute_sections
27380 (namespace_declaration): Allow opt_attributes to tackle the case
27381 when we have assembly level attributes - we are clever in this
27384 * attribute.cs (ApplyAttributes): Do not worry about assembly
27385 attributes in the non-global context.
27387 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27388 instead of SetGlobalAttributes.
27390 * class.cs, rootcontext.cs : Ensure we define and generate
27391 attribute types before anything else.
27393 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27394 and flag the new error -20 for the case when the attribute type
27395 does not have valid targets specified. csc does not catch this.
27397 * ../errors/errors.txt : update for error # -20
27399 2002-04-11 Ravi Pratap <ravi@ximian.com>
27401 * support.cs (InternalParameters.ParameterModifier): Do some null
27402 checking and return sane values.
27404 * class.cs (Method.Define): If we are a PInvoke method, ensure
27405 that we are static and extern. Report error # 601
27407 * ../errors/cs0601.cs : Add test case for the above error.
27409 2002-04-07 Ravi Pratap <ravi@ximian.com>
27411 * rootcontext.cs (attribute_types): We need to keep type of
27412 all attribute types separately and emit code for them first.
27414 (RegisterAttribute) : Implement.
27416 * class.cs (DefineType): Check if the current Type is a custom
27417 attribute type and register it accordingly.
27419 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27420 adding the first attribute twice and rename to
27422 (SetGlobalAttributes): this.
27424 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27427 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27428 if we are processing global arguments. Hmm, I am unsure of this.
27430 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27432 * expression.cs: added static array of strings to avoid calling
27433 Enum.ToString () for Operator in Binary. Significant recover of
27436 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27438 * class.cs (FindMembers): Allow the Builders of the various
27439 members to be null. If they are skip them. This only happens
27440 during the PInvoke declaration.
27442 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27444 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27445 failure, so we do not keep going afterwards.
27447 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27448 wanted to pass `false' as the `is_delegate' argument. If this is
27449 the case, why not use delegate_type == null to mean `is_delegate =
27450 false' and anything else as is_delegate = true.
27452 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27454 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27455 code for the section, not the beginning of the tests.
27457 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27459 * cfold.cs: Handle operator + (Enum x, Underlying x)
27461 * expression.cs (Binary): same. Warn about errors where we have
27462 Enum/Enum in operator + as well.
27464 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27467 - added support for switch(bool)
27468 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27469 - add TableSwitchEmit() to handle table-based switch statements
27471 2002-04-05 Ravi Pratap <ravi@ximian.com>
27473 * expression.cs (Invocation.OverloadResolve): Factor out code which
27474 does parameter compatibility checking with arguments so that we can
27475 re-use the code even from Delegate.VerifyApplicability
27477 (VerifyArgumentsCompat): Move above code here.
27479 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27480 and instead make a call to the above method.
27482 2002-03-31 Ravi Pratap <ravi@ximian.com>
27484 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27485 We use it to keep track of classes which are attribute types.
27487 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27489 * delegate.cs (Delegate.Define): Correctly define the types in the
27490 presence of fixed and array parameters.
27492 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27495 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27496 include NonPublic after the first iteration.
27498 * class.cs (Indexer.CheckBase): Only check if both parents are
27501 * cs-parser.jay (accessor_body): If empty, set to null.
27503 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27504 same code path here to resolve constants names that we did have in
27505 MemberAccess.DoResolve. There is too much code duplicated here.
27507 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27509 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27511 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27514 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27515 tokens, numbers and strings.
27517 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27520 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27521 asyncronous parameters and the regular parameters.
27523 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27524 specify the target directory.
27526 * expression.cs: (This.DoResolve): Simplify
27527 (As.Emit): Optimize, do not generate IsInst if the expression is
27528 always of the given type.
27530 (Is.DoResolve): Bug fix, we were reporting both always/never for
27533 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27534 creating too many unnecessary arrays.
27536 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27538 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27539 fields instead of rolling our own initializer. Takes care of all
27540 implicit conversions, and drops unnecessary static checks/argument.
27542 2002-03-31 Dick Porter <dick@ximian.com>
27544 * driver.cs: use the GetDirectories() return values properly, and
27545 use "/" as path separator.
27547 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27549 * expression.cs (Unary): Optimize - - expr into expr.
27550 (Binary): Optimize a + (-b) into a -b.
27552 * codegen.cs (CodeGen): Made all methods static.
27554 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27558 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27559 TypeBuilder property.
27561 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27564 * tree.cs: Removed the various RecordXXXX, and replaced with a
27565 single RecordDecl. Removed all the accessor methods, and just
27566 left a single access point Type
27568 * enum.cs: Rename DefineEnum to DefineType.
27570 * decl.cs: New abstract method `DefineType' used to unify the
27571 Defines for Enumerations, Interfaces, TypeContainers and
27574 (FindType): Moved LookupInterfaceOrClass here. Moved the
27575 LookupBaseClasses method that used to live in class.cs and
27576 interface.cs here, and renamed to FindType.
27578 * delegate.cs: Implement DefineType. Take advantage of the
27579 refactored pattern for locating the parent builder without taking
27580 the parent_builder argument (which we know does not work if we are
27581 nested, and triggering a toplevel definition).
27583 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27585 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27586 accessibility of a member has changed during override and report
27589 * class.cs (Method.Define, Property.Define): Only complain on
27590 overrides if the method is private, any other accessibility is
27591 fine (and since we just checked the permission is the same, we are
27594 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27595 and elif are processed always. The other pre-processing
27596 directives are only processed if we are "taking" the path
27598 2002-03-29 Martin Baulig <martin@gnome.org>
27600 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27601 current location is not Null.
27603 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27604 a separate method so we can profile it.
27606 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27607 `span.Seconds' are just seconds, but no minutes or hours.
27608 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27610 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27612 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27613 Remove the gratuitous set of Final:
27615 // If an interface implementation, then we can set Final.
27616 if (((flags & MethodAttributes.Abstract) == 0) &&
27617 implementing.DeclaringType.IsInterface)
27618 flags |= MethodAttributes.Final;
27620 I do not know what I was smoking when I used that.
27623 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27624 step into fixing the name resolution issues for delegates and
27625 unifying the toplevel name resolution.
27627 2002-03-28 Martin Baulig <martin@gnome.org>
27629 * class.cs (Method.Emit): If we have a symbol writer, call its
27630 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27631 tell it about the current method.
27633 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27634 writer that we're going to emit the first byte of IL code for a new
27635 statement (a new source line).
27636 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27637 EmitContext.Mark() before emitting any code.
27639 * location.cs (SymbolDocument): Return null when we're Null.
27641 * statement.cs (Statement): Moved the `Location loc' variable here.
27642 (Statement.EmitBoolExpression): If we have a symbol writer, call
27643 ec.Mark() before emitting any code to tell it that we're at the
27644 beginning of a new statement.
27645 (StatementExpression): Added `Location' argument to the constructor.
27646 (Block): Added public readonly variable `StartLocation' and public
27647 variable `EndLocation'. The latter is to be set using SetEndLocation().
27648 (Block): Added constructor which takes a start and end location.
27649 (Block.SetEndLocation): New method. This sets the end location.
27650 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27651 local variables we create.
27652 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27653 each statement and do also mark the begin and end of the block.
27655 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27656 tell it the current lexer.Location, use Location.Null for the end of the
27658 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27659 current block, set its end location using SetEndLocation().
27660 (statement_expression): StatementExpression constructor now takes the
27661 lexer.Location as additional argument.
27662 (for_statement, declare_local_variables): Likewise.
27663 (declare_local_variables): When creating a new implicit block, use the
27664 new Block constructor and pass it the lexer.Location.
27666 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27668 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27669 members also on the parent interfaces recursively.
27671 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27673 * report.cs: Use new formats, since Gonzalo finished the missing
27676 * expression.cs (Binary.ResolveOperator): added missing operator|
27677 operator& and operator^ for bool/bool.
27679 * cs-parser.jay: CheckDef now takes a Location argument that is
27680 used to report errors more precisly (instead of reporting the end
27681 of a definition, we try to track something which is a lot closer
27682 to the source of the problem).
27684 * cs-tokenizer.cs: Track global token use, so we can properly flag
27685 the use of #define/#undef after the first token has been seen.
27687 Also, rename the reportXXXX to Error_DescriptiveName
27689 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27690 TypeContainer, so that Enum and Interface can use this too.
27692 * class.cs (TypeContainer.LookupInterfaceOrClass,
27693 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27694 `builder' argument. Typically this was used to pass the parent
27695 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27698 The problem is that a nested class could trigger the definition of
27699 a toplevel class, and the builder would be obviously wrong in that
27702 So we drop this argument, and we compute dynamically the
27703 TypeBuilder/ModuleBuilder (the correct information was available
27704 to us anyways from DeclSpace.Parent)
27706 * interface.cs (Interface.DefineInterface): Drop builder
27707 parameter cleanup like class.cs
27709 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27712 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27715 (Try.Emit): Propagate the returns value from the statement.
27717 (Return.Emit): Even if we are leavning
27719 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27721 * modifiers.cs: Fix the computation of MethodAttributes flags.
27723 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27725 * driver.cs: allow compilation of files that start with '/'.
27726 Add a default case when checking the argument of --target.
27728 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27730 * interface.cs: Implement the same search algorithm for types in
27731 the interface code.
27733 * delegate.cs: Do not allow multiple definition.
27735 * Recovered ChangeLog that got accidentally amputated
27737 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27739 * rootcontext.cs: Load manually enum to allow core classes to
27740 contain enumerations.
27742 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27743 Update to new static methods in TypeManager.
27745 * typemanager.cs (GetMethod, GetConstructor): Use our
27746 implementation of FindMembers to find the members, since during
27747 corlib compilation, the types are TypeBuilders and GetMethod and
27748 GetConstructor do not work.
27750 Make all methods in TypeManager static.
27752 (InitCodeHelpers): Split the functionality from
27753 the InitCodeTypes function.
27755 * driver.cs: Call InitCodeHelpers after we have populated the
27758 * cs-parser.jay (delegate_declaration): we did not used to compute
27759 the delegate name correctly for void delegates.
27761 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27763 * rootcontext.cs (RootContext): Init the interface_resolve_order
27764 and type_container_resolve_order always.
27766 (ResolveCore, BootstrapCorlib_ResolveClass,
27767 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27768 compiler when compiling with --nostdlib
27770 * class.cs (TypeContainer.DefineType): Check that our parent is
27771 not null. This test is most important when we are bootstraping
27774 * codegen.cs: Split out the symbol writing code.
27776 2002-03-25 Martin Baulig <martin@gnome.org>
27778 * driver.cs (-g): Made -g an alias for --debug.
27780 2002-03-24 Martin Baulig <martin@gnome.org>
27782 * codegen.cs (SymbolWriter): New public variable. Returns the
27783 current symbol writer.
27784 (CodeGen): Added `bool want_debugging_support' argument to the
27785 constructor. If true, tell the ModuleBuild that we want debugging
27786 support and ask it for the ISymbolWriter.
27787 (Save): If we have a symbol writer, call it's Close() method after
27788 saving the assembly.
27790 * driver.c (--debug): New command line argument to create a
27791 debugger information file.
27793 * location.cs (SymbolDocument): New public property. Returns an
27794 ISymbolDocumentWriter object for the current source file or null
27795 if we don't have a symbol writer.
27797 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27799 * driver.cs (LoadAssembly): Correctly return when all the paths
27800 have been tried and not before.
27802 * statement.cs (Switch.Emit): return the actual coverage for this
27803 statement (returns/not-returns)
27805 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27806 switch of the statement if we are the last switch section. That
27807 kills two problems: try/catch problems (we used to emit an empty
27808 nop at the end) and switch statements where all branches would
27811 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27813 * driver.cs: Add default assemblies (the equivalent to the
27814 Microsoft CSC.RSP file)
27816 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27817 also update tokens_seen and set it to false.
27819 * driver.cs: Implement --recurse for Mike.
27821 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27822 correctly splitting out the paths.
27824 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27826 * interface.cs (Interface.PopulateProperty): Instead of using
27827 `parent' as the declaration space for the set parameters, use
27830 * support.cs (InternalParameters): InternalParameters constructor
27831 takes a DeclSpace instead of a TypeContainer.
27833 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27834 types are being initialized, load the address of it before calling
27837 (New): Provide a mechanism to disable the generation of local
27838 value type temporaries when the caller will be providing us with
27839 an address to store it.
27841 (ArrayCreation.EmitDynamicInitializers): Use it.
27843 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27845 * expression.cs (Invocation.EmitArguments): Only probe for array
27846 property if there is more than one argument. Sorry about that.
27848 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27849 empty param arrays.
27851 * class.cs (Method.LabelParameters): Fix incorrect code path that
27852 prevented the `ParamArrayAttribute' from being applied to the
27855 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27857 * support.cs (ReflectionParameters): Correctly compute whether the
27858 last argument is a params array. Fixes the problem with
27861 * typemanager.cs: Make the assemblies array always be non-null
27862 (empty, but non-null)
27864 * tree.cs (RecordDecl): New function that abstracts the recording
27865 of names. This reports error 101, and provides a pointer to the
27866 previous declaration. Fixes a crash in the compiler.
27868 * cs-parser.jay (constructor_declaration): Update to new grammar,
27869 and provide a constructor_body that can be empty.
27871 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27873 * driver.cs: Add support for --resources.
27875 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27876 Make all types for the various array helper methods be integer.
27878 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27879 CheckState to ConvCast.
27881 (ConvCast): Now it takes a `checked' state argument, to avoid
27882 depending on the emit context for the conversion, and just using
27883 the resolve time setting.
27885 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27886 instead of Invocation.EmitArguments. We do not emit the original
27887 arguments, instead we emit those which have been converted to
27888 unsigned int expressions.
27890 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27892 * codegen.cs: ditto.
27894 * expression.cs (LocalVariableReference): Drop the use of the
27895 Store function that depended on the variable index.
27897 * statement.cs (VariableInfo): Drop the `Idx' property from this
27898 class, as this is not taking into account the indexes for
27899 temporaries tat we generate during the execution, getting the
27902 * class.cs: First emit class initializers, then call the parent
27905 * expression.cs (Binary): Fix opcode emision.
27906 (UnaryMutator.EmitCode): Support checked code generation
27908 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27909 matches for events for both the Static and Instance scans,
27910 pointing to the same element. Fix that.
27912 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27914 * rootcontext.cs (ResolveTree): Always set the
27915 interface_resolve_order, because nested interfaces will be calling
27918 * class.cs (GetInterfaceOrClass): Track the same resolution
27919 process used by TypeManager.LookupType. This fixes the nested
27920 type lookups in class declarations (separate path from
27923 (TypeContainer.DefineType): Also define nested interfaces.
27924 (TypeContainer.RegisterOrder): New public function used to
27925 register the order in which child interfaces need to be closed.
27927 Nested interfaces need to be closed after their parents have been
27930 * interface.cs (InterfaceAttr): Put all the logic for computing
27931 the interface attribute here.
27933 (DefineInterface): Register our interface order with the
27934 RootContext or with the TypeContainer depending on the case.
27936 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27938 * cs-parser.jay: rework foreach statement to work with the new
27939 changes to the policy on SimpleNames.
27941 * report.cs: support Stacktrace on warnings as well.
27943 * makefile: drop --unsafe and /unsafe from the compile.
27945 2002-03-13 Ravi Pratap <ravi@ximian.com>
27947 * ecore.cs (StandardConversionExists): Modify to take an Expression
27948 as the first parameter. Ensure we do null -> reference type conversion
27951 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27952 temporary Expression objects.
27954 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27956 * interface.cs: workaround bug in method overloading resolution
27957 (there is already a bugzilla bug for it).
27959 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27961 We could also solve this problem by having a separate path for
27962 performing type lookups, instead of DoResolve, we could have a
27963 ResolveType entry point, and only participating pieces of the
27964 production (simplename, deref, array) would implement this.
27966 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27967 signal SimpleName to only resolve type names and not attempt to
27968 resolve anything else.
27970 * expression.cs (Cast): Set the flag.
27972 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27974 * class.cs: Only report 108 if there is no `new' modifier.
27976 * cs-parser.jay: rework foreach statement to work with the new
27977 changes to the policy on SimpleNames.
27979 * report.cs: support Stacktrace on warnings as well.
27981 * makefile: drop --unsafe and /unsafe from the compile.
27983 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27985 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27986 lookups here, instead of doing that at parse time. This means
27987 that our grammar will not introduce `LocalVariableReferences' as
27988 expressions at this point. That solves the problem of code like
27992 static void Main ()
27996 This is only half the fix. The full fix requires parameters to
27997 also be handled in this way.
27999 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28000 makes the use more obvious of the DeclSpace. The
28001 ec.TypeContainer.TypeBuilder is now only used to pull the
28002 TypeBuilder for it.
28004 My theory is that I can get rid of the TypeBuilder completely from
28005 the EmitContext, and have typecasts where it is used (from
28006 DeclSpace to where it matters).
28008 The only pending problem is that the code that implements Aliases
28009 is on TypeContainer, and probably should go in DeclSpace.
28011 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28012 lookups here, instead of doing that at parse time. This means
28013 that our grammar will not introduce `LocalVariableReferences' as
28014 expressions at this point. That solves the problem of code like
28018 static void Main ()
28022 This is only half the fix. The full fix requires parameters to
28023 also be handled in this way.
28025 * class.cs (Property.DefineMethod): When implementing an interface
28026 method, set newslot, when implementing an abstract method, do not
28027 set the flag (before we tried never setting it, or always setting
28028 it, which is the difference).
28029 (Indexer.DefineMethod): same.
28030 (Method.DefineMethod): same.
28032 * ecore.cs: Only set the status used flag if we get back a Field.
28034 * attribute.cs: Temporary hack, so Paolo can keep working.
28036 2002-03-08 Ravi Pratap <ravi@ximian.com>
28038 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28039 the unmanaged type in the case we have a MarshalAs attribute.
28041 (Resolve): Handle the case when we are parsing the special MarshalAs
28042 attribute [we need to store the unmanaged type to use later]
28044 * typemanager.cs (marshal_as_attr_type): Built in type for the
28045 MarshalAs Attribute.
28047 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28048 on parameters and accordingly set the marshalling info.
28050 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28052 * class.cs: Optimizing slightly by removing redundant code after
28053 we switched to the `NoTypes' return value.
28054 (Property.DefineMethod): use NoTypes here too.
28056 This fixes the bug I introduced in my last batch of changes.
28058 2002-03-05 Ravi Pratap <ravi@ximian.com>
28060 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28062 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28063 Enums since those are types too.
28065 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28067 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28068 thanks to a call during the lookup process.
28070 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28072 * statement.cs (Foreach): Lots of work to accomodate a particular
28073 kind of foreach statement that I had not kept in mind. It is
28074 possible to have foreachs on classes that provide a GetEnumerator
28075 method that return objects that implement the "pattern" for using
28076 a foreach, there is no need to support GetEnumerator
28079 This is needed to compile nant.
28081 * decl.cs: Only report 114 if the member is not `Finalize' and if
28082 the warning level is at least 2.
28084 * class.cs: Moved the compare function from Method to
28087 (MethodSignature.InheritableMemberSignatureCompare): Add new
28088 filter function that is used to extract inheritable methods from a
28091 (Method.Define): Use the new `inheritable_method_signature_filter'
28094 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28097 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28099 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28101 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28103 * expression.cs: Pass location information to
28104 ConvertImplicitStandard.
28106 * class.cs: Added debugging code to track return values from
28109 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28111 * expression.cs (Is.DoResolve): If either side of the `is' is an
28112 interface, do not flag the warning.
28114 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28117 * report.cs: Allow for --fatal to be used with --probe.
28119 * typemanager.cs (NoTypes): Move the definition for the empty Type
28122 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28124 (TypeContainer.DefineProxy): New function used to proxy to parent
28125 implementations when implementing interfaces.
28126 (TypeContainer.ParentImplements): used to lookup if our parent
28127 implements a public function that is required by an interface.
28128 (TypeContainer.VerifyPendingMethods): Hook this up.
28130 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28131 `modules' and `assemblies' arraylists into arrays. We only grow
28132 these are the very early start up of the program, so this improves
28133 the speedof LookupType (nicely measured).
28135 * expression.cs (MakeByteBlob): Replaced unsafe code with
28136 BitConverter, as suggested by Paolo.
28138 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28139 folding of string concatenation, but if either side is a string,
28140 and the other is not, then return null, and let the runtime use
28141 the concatenation on the string plus the object (using
28142 `Object.ToString').
28144 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28146 Constant Folding has been implemented now.
28148 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28149 the error instead on types that are not supported in one's
28152 * constant.cs (Constant and all children): New set of functions to
28153 perform implict and explicit conversions.
28155 * ecore.cs (EnumConstant): Implement the new functions to perform
28156 conversion by proxying to the child expression.
28158 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28159 own separate setting that can not be turned off from the command
28160 line using --unchecked or --checked and is only controlled using
28161 the checked/unchecked statements and expressions. This setting is
28162 used by the constant folder to flag errors.
28164 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28165 ConstantCheckState as well.
28167 During Resolve, they also have to flag the state, because the
28168 constant folder runs completely in the Resolve phase.
28170 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28173 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28175 * cfold.cs: New file, this file contains the constant folder.
28177 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28178 argument to track whether we are using the resulting address to
28179 load or store a value and provide better error messages.
28181 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28182 new AddressOf arguments.
28184 * statement.cs (Foreach.EmitCollectionForeach): Update
28186 * expression.cs (Argument.Emit): Call AddressOf with proper
28187 arguments to track usage.
28189 (New.DoEmit): Call AddressOf with new arguments.
28191 (Unary.Emit): Adjust AddressOf call.
28193 2002-03-01 Ravi Pratap <ravi@ximian.com>
28195 * cs-parser.jay (member_access): Change the case for pre-defined types
28196 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28199 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28202 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28203 essentially like methods and apply attributes like MethodImplOptions to them too.
28205 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28208 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28209 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28212 * Update code everywhere accordingly.
28214 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28216 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28218 2002-02-28 Ravi Pratap <ravi@ximian.com>
28220 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28221 try performing lookups against those instead of jumping straight into using
28222 the 'using' clauses.
28224 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28226 (LookupType): Perform lookups in implicit parents too.
28228 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28229 sequence as RootContext.LookupType.
28231 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28232 the various cases of namespace lookups into this method.
28234 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28236 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28237 in positional arguments)
28239 * class.cs (Operator): Update the AllowedModifiers to contain
28242 * cs-parser.jay: Update operator declaration to allow for the
28243 operator body to be empty.
28245 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28248 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28250 * class.cs (Method.Emit): Label parameters.
28252 * driver.cs: Return 1 or 0 as the program exit code.
28254 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28256 * expression.cs: Special case the `null' object when trying to
28257 auto-compute the type, as anything can be explicitly converted to
28260 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28261 spotting this Paolo.
28263 (Expression.ImplicitNumericConversion): Perform comparissions of
28264 the type using the underlying type in the case of an enumeration
28265 rather than using the enumeration type for the compare.
28267 Cope with the underlying == type case, which is not possible to
28270 (Expression.ConvertNumericExplicit): Perform comparissions of
28271 the type using the underlying type in the case of an enumeration
28272 rather than using the enumeration type for the compare.
28274 * driver.cs: If the user does not supply an extension, assume .exe
28276 * cs-parser.jay (if_statement): Rewrote so that we can track the
28277 location for the if statement.
28279 * expression.cs (Binary.ConstantFold): Only concat strings when
28280 the operation is "+", not everything ;-)
28282 * statement.cs (Statement.EmitBoolExpression): Take a location
28284 (If, While, Do): Track location.
28286 * expression.cs (Binary.ResolveOperator): In the object + string
28287 case, I was missing a call to ConvertImplicit
28289 2002-02-25 Ravi Pratap <ravi@ximian.com>
28291 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28292 Location arguments. Ensure we use RootContext.LookupType to do our work
28293 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28295 * interface.cs (PopulateMethod): Handle the type of the parameter being
28298 * expression.cs (Invocation.BetterFunction): Handle the case when we
28299 have a params method with no fixed arguments and a call is made with no
28302 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28304 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28305 the verbatim-string-literal
28307 * support.cs (InternalParameters.ParameterModifier): handle null
28309 (InternalParameters.ParameterType): ditto.
28311 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28312 duplicating the name of the variable parameter.
28313 (GetParameterByName): Fix bug where we were not looking up array
28314 paramters if they were the only present (thanks Paolo!).
28315 (GetParameterInfo): We only have an empty set of types if both
28316 fixed and array are set to null.
28317 (GetParameterInfo-idx): Handle FixedParameter == null
28319 * cs-parser.jay: Handle the case where there is no catch
28320 statements (missing null test).
28322 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28324 * driver.cs (MainDriver): Be conservative on our command line
28327 Catch DirectoryNotFoundException when calling GetFiles.
28329 (SplitPathAndPattern): Used to split the input specification into
28330 a path and a pattern that we can feed to Directory.GetFiles.
28332 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28334 * statement.cs (Fixed): Implement the last case of the Fixed
28335 statement (string handling).
28337 * expression.cs (StringPtr): New class used to return a char * to
28338 a string; Used by the Fixed statement.
28340 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28342 * expression.cs (Binary.ResolveOperator): Remove redundant
28343 MemberLookup pn parent type.
28344 Optimize union call, we do not need a union if the types are the same.
28345 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28348 Specialize the use of MemberLookup everywhere, instead of using
28349 the default settings.
28351 (StackAlloc): Implement stackalloc keyword.
28353 * cs-parser.jay: Add rule to parse stackalloc.
28355 * driver.cs: Handle /h, /help, /?
28357 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28358 before we supported unsafe code.
28360 * makefile: add --unsafe to the self compilation of mcs.
28362 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28364 * expression.cs (PointerArithmetic): New class that is used to
28365 perform pointer arithmetic.
28366 (Binary.Resolve): Handle pointer arithmetic
28367 Handle pointer comparission.
28368 (ArrayPtr): Utility expression class that is used to take the
28369 address of an array.
28371 (ElementAccess): Implement array access for pointers
28373 * statement.cs (Fixed): Implement fixed statement for arrays, we
28374 are missing one more case before we are done.
28376 * expression.cs (Indirection): Implement EmitAssign and set the
28377 ExprClass to Variable. This allows pointer dereferences to be
28378 treated as variables, and to have values assigned to them.
28380 * ecore.cs (Expression.StoreFromPtr): New utility function to
28381 store values dereferencing.
28383 2002-02-20 Ravi Pratap <ravi@ximian.com>
28385 * expression.cs (Binary.ResolveOperator): Ensure that we are
28386 not trying to operate on a void type - this fixes the reported
28389 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28390 the parent implementation is sealed.
28392 * ../errors/cs0239.cs : Add.
28394 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28396 * typemanager.cs (unverifiable_code_type): Corresponds to
28397 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28398 which have unsafe code in them.
28400 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28403 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28405 * cs-tokenizer.cs: Add support for @"litreal strings"
28407 Make tokenizer accept pre-processor directives
28408 on any column (remove the old C-like limitation).
28410 * rootcontext.cs (EmitCode): Emit any global attributes.
28411 (AddGlobalAttributes): Used to keep track of assembly attributes.
28413 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28415 * cs-parser.jay: Add support for global attributes.
28417 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28419 * expression.cs (Indirection): New helper class. Unary will
28420 create Indirection classes to be able to implement the
28421 IMemoryLocation interface on it.
28423 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28425 * cs-parser.jay (fixed_statement): reference the right statement.
28427 * statement.cs (Fixed.Emit): Finish implementing the fixed
28428 statement for the &x case.
28430 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28432 * class.cs (Property.Define, Method.Define): Remove newslot when
28435 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28436 wrong. NewSlot should only be used if the `new' keyword is present.
28438 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28439 locating our system dir. Sorry about this.
28441 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28443 * driver.cs (GetSystemDir): Compute correctly the location of our
28444 system assemblies. I was using the compiler directory instead of
28445 the library directory.
28447 2002-02-13 Ravi Pratap <ravi@ximian.com>
28449 * expression.cs (BetterFunction): Put back in what Miguel commented out
28450 since it is the correct fix. The problem is elsewhere ;-)
28452 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28453 parameters of the parms method are themselves compatible or not !
28455 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28456 to check that a class implements an interface before saying that an implicit
28457 conversion was allowed. Use ImplementsInterface to do the checking.
28459 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28461 * class.cs (Method.Define): Track whether we are an explicit
28462 implementation or not. And only call DefineMethodOverride if we
28463 are an explicit implementation.
28465 (Property.DefineMethod): Ditto.
28467 2002-02-11 Ravi Pratap <ravi@ximian.com>
28469 * expression.cs (BetterFunction): Catch hideous bug which was
28470 preventing us from detecting ambiguous calls due to implicit casts i.e
28473 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28475 * support.cs (Pair): Remove un-needed method. I figured why I was
28476 getting the error in cs-parser.jay, the variable in a foreach loop
28477 is readonly, and the compiler does not really treat this as a variable.
28479 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28480 instead of EQUALS in grammar.
28482 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28484 * expression.cs (Unary.DoResolve): Check whether the argument is
28487 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28489 * support.cs: Api for Pair to set a value. Despite the fact that
28490 the variables are public the MS C# compiler refuses to compile
28491 code that accesses the field if the variable is part of a foreach
28494 * statement.cs (Fixed): Begin implementation of the fixed
28497 (Block.AddVariable): Return the VariableInfo on success and null
28498 on failure instead of true/false.
28500 * cs-parser.jay (foreach): Catch errors on variables already
28501 defined (we were ignoring this value before) and properly unwind
28502 the block hierarchy
28504 (fixed_statement): grammar for the fixed statement.
28506 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28508 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28509 pointer types to be incretemented.
28511 (SizeOf): Implement.
28513 * cs-parser.jay (pointer_member_access): Implement
28514 expr->IDENTIFIER production.
28516 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28517 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28520 (Unary): Implement indirection.
28522 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28523 use in non-unsafe context).
28525 (SimpleName.DoResolve): Check for pointers in field access on safe
28528 (Expression.LoadFromPtr): Factor the load-indirect code in this
28529 function. This was duplicated in UnboxCast and ParameterReference
28531 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28533 * expression.cs (ComposedCast): report an error if a pointer cast
28534 is used in a safe region.
28536 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28537 pointer type casts in unsafe context.
28539 * codegen.cs (EmitContext): Set up IsUnsafe.
28541 * cs-parser.jay (non_expression_type): Add productions for pointer
28544 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28545 code. We should not use force into static mode if the method is
28546 not virtual. Fixes bug in MIS
28548 * statement.cs (Do.Emit, While.Emit, For.Emit,
28549 Statement.EmitBoolExpression): Add support to Do and While to
28550 propagate infinite loop as `I do return' semantics.
28552 Improve the For case to also test for boolean constants.
28554 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28555 to the list of attributes we can add.
28557 Remove `EmitContext' argument.
28559 * class.cs (Method.Define): Apply parameter attributes.
28560 (Constructor.Define): Apply parameter attributes.
28561 (MethodCore.LabelParameters): Move here the core of labeling
28564 * support.cs (ReflectionParameters.ParameterModifier,
28565 InternalParameters.ParameterModifier): Use IsByRef on the type and
28566 only return the OUT bit for these parameters instead of in/out/ref
28569 This is because I miss-understood things. The ParameterInfo.IsIn
28570 and IsOut represent whether the parameter has the [In] and [Out]
28573 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28575 * ecore.cs (FieldExpr.Emit): Release temporaries.
28577 * assign.cs (LocalTemporary.Release): new function.
28579 * codegen.cs (EmitContext.GetTemporaryStorage,
28580 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28581 temporary storage. Now we can "put back" localbuilders when we
28584 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28586 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28587 need to make a copy of the variable to generate verifiable code.
28589 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28591 * driver.cs: Compute dynamically the system directory.
28593 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28594 Slower, but more generally useful. Used by the abstract
28595 registering implementation.
28597 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28598 the rules for the special rule on Type/instances. First check if
28599 we have the same name, and if so, try that special static path
28600 rather than the instance path.
28602 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28604 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28607 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28608 Enum, ValueType, Delegate or Array for non-corlib compiles.
28610 * cs-tokenizer.cs: Catch long identifiers (645)
28612 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28615 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28616 fix, we were returning too early, so we were not registering
28617 pending methods from abstract classes.
28619 Do not register pending methods if the class is abstract.
28621 * expression.cs (Conditional.DoResolve): Report circular implicit
28622 conversions when we neecd to compute it for conditional
28625 (Is.DoResolve): If the expression is always of the provided type,
28626 flag warning 183. If the expression can not ever be of the
28627 provided type flag warning 184.
28629 * class.cs: Catch 169 as well.
28631 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28634 2002-01-18 Nick Drochak <ndrochak@gol.com>
28636 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28638 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28640 * interface.cs: (PopulateMethod): Check for pointers being defined
28641 only if the unsafe context is active.
28642 (PopulateProperty): ditto.
28643 (PopulateIndexer): ditto.
28645 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28646 specified. If pointers are present, make sure that they are
28647 present in an unsafe context.
28648 (Constructor, Constructor.Define): ditto.
28649 (Field, Field.Define): ditto.
28650 (Property, Property.Define): ditto.
28651 (Event, Event.Define): ditto.
28653 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28654 hashtable if there are classes or structs defined.
28656 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28657 code, as the constant resolution moved.
28659 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28660 the metadata, so we can flag error 133.
28662 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28663 pointer is being declared in an unsafe context.
28665 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28667 * modifiers.cs (Modifiers.Check): Require a Location argument.
28668 Report error 227 for Unsafe use.
28670 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28672 * statement.cs (For.Emit): If the test is null, then report that
28673 we do `return', as we wont reach anything afterwards.
28675 (Switch.SwitchGoverningType): Track the expression that matched
28678 * driver.cs: Allow negative numbers as an error code to flag.
28680 * cs-parser.jay: Handle 1551.
28682 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28684 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28686 * cs-parser.jay: Report 1518 (type declaration can only contain
28687 class, struct, interface, enum or delegate)
28689 (switch_label): Report 1523 (keywords `case' or `default' must
28692 (opt_switch_sections): Report 1522 (empty switch)
28694 * driver.cs: Report 1515 (response file specified multiple times)
28695 Report 1516 (Source file specified multiple times).
28697 * expression.cs (Argument.Resolve): Signal 1510
28699 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28700 access not allowed in static code)
28702 2002-01-11 Ravi Pratap <ravi@ximian.com>
28704 * typemanager.cs (IsPointerType): Utility method which we are going
28707 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28708 the object type, so we take care of that.
28710 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28712 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28713 added to non-params parameters :-)
28715 * typemanager.cs (CSharpName): Include 'void' type too.
28717 (void_ptr_type): Include in the set of core types.
28719 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28722 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28725 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28726 completely forgotten about it.
28728 2002-01-10 Ravi Pratap <ravi@ximian.com>
28730 * cs-parser.jay (pointer_type): Add. This begins our implementation
28731 of parsing rules for unsafe code.
28733 (unsafe_statement): Implement.
28735 (embedded_statement): Modify to include the above.
28737 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28739 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28740 if the current context is an unsafe one.
28742 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28743 are handled differently, we need separate rules for them.
28745 (local_variable_declaration): Update to use local_variable_pointer_type
28746 to allow variable declarations of unmanaged pointer types.
28748 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28749 in unsafe contexts.
28751 * ../errors/cs0214.cs : Add.
28753 2002-01-16 Nick Drochak <ndrochak@gol.com>
28755 * makefile: remove 'response' file when cleaning.
28757 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28759 * cs-parser.jay: Report 1524.
28761 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28763 * typemanager.cs (RegisterMethod): drop checking if we have
28764 registered this from here
28766 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28768 * class.cs (Method.EmitDestructor): Implement calling our base
28771 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28772 value of InFinally.
28774 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28775 this routine and will wrap the call in a try/catch block. Deal
28778 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28780 * ecore.cs (Expression.MemberLookup): instead of taking a
28781 parameter `same_type' that was used to tell whether we could
28782 access private members we compute our containing type from the
28785 (FieldExpr): Added partial support for volatile fields. This does
28786 not work for volatile fields exposed from assemblies, as I can not
28787 figure out how to extract the modreq from it.
28789 Updated all the source files to use this.
28791 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28792 because it is referenced by MemberLookup very often.
28794 2002-01-09 Ravi Pratap <ravi@ximian.com>
28796 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28797 TypeBuilder.GetCustomAttributes to retrieve what we need.
28799 Get rid of redundant default_member_attr_type as this is the same as
28800 default_member_type which already exists.
28802 * interface.cs, attribute.cs : Update accordingly.
28804 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28806 * typemanager.cs: Enable IndexerPropertyName again. It does not
28807 work for TYpeBuilders though. Ravi, can you please fix this?
28809 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28811 * expression.cs (Argument.Emit): Handle the case of ref objects
28812 being passed to ref functions;
28814 (ParameterReference.EmitLoad): Loads the content of the pointer
28815 without dereferencing.
28817 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28819 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28821 2002-01-08 Ravi Pratap <ravi@ximian.com>
28823 * class.cs (Indexer.DefineMethod): Incorporate the interface
28824 type in the name of the method if we are doing explicit interface
28827 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28829 (BetterConversion): Fix extremely trivial bug where we were referring to
28830 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28833 * ../errors/bug16.cs : Add although we have fixed it.
28835 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28837 * expression.cs (BaseIndexer): Begin implementation.
28839 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28841 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28842 production directly to remove a shift/reduce, and implement
28843 explicit interface implementation.
28845 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28846 after a floating point suffix.
28848 * expression.cs (DoNumericPromotions): Improved the conversion for
28849 uint/uint. If we have a constant, we avoid doing a typecast to a
28852 * class.cs (Indexer): Implement explicit interface implementation
28855 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28857 * class.cs: make the default instance constructor public and hidebysig.
28859 2001-01-03 Ravi Pratap <ravi@ximian.com>
28861 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28862 so we can call it from elsewhere.
28864 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28865 we emit it internally if the class has a defined indexer; otherwise the user
28866 emits it by decorating the class definition with the DefaultMemberAttribute.
28868 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28869 attribute is not used on a type which defines an indexer.
28871 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28872 character when we skip whitespace.
28874 * ../errors/cs0646.cs : Add.
28876 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28878 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28881 * makefile: Add practical target `mcs3.exe' which builds the third
28882 generation compiler.
28884 * expression.cs (New): Fix structures constructor calling.
28886 * class.cs (Property, Method, Indexer): Emit Final flag on the
28887 method if we are an interface implementation and we are not
28890 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28891 whether this property is referencing a `base' method.
28893 * expression.cs (Invocation.EmitCall): take an extra argument:
28894 is_base, this is used to determine whether the `call' or
28895 `callvirt' opcode should be used.
28898 * delegate.cs: update EmitCall.
28900 * class.cs (Method.Define): Set NewSlot for the cases where we are
28901 not implementing an interface method.
28903 (Property.Define): ditto.
28905 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28907 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28908 'r'. Allows mcs to parse itself fully.
28910 2002-01-02 Ravi Pratap <ravi@ximian.com>
28912 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28913 of the number of initializers that require the InitializeArray method.
28915 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28916 update the above field where necessary.
28918 (MakeByteBlob): Update accordingly.
28920 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28923 (EmitDynamicInitializers): Update in accordance with the new optimization.
28925 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28926 same OpCode applies.
28928 * cs-parser.jay : Fix some glaring errors I introduced.
28930 2002-01-01 Ravi Pratap <ravi@ximian.com>
28932 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28933 so that we can check for name clashes there too.
28935 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28936 for interface indexers.
28938 * interfaces.cs (Define): Emit the default member attribute.
28940 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28941 variable was being referred to while setting the value ;-)
28943 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28945 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28946 byte-by-byte information when we know the data is zero.
28948 Make the block always a multiple of 4, because
28949 DefineInitializedData has a bug.
28951 * assign.cs: Fix, we should assign from the temporary, not from
28954 * expression.cs (MakeByteBlob): Fix my incorrect code.
28956 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28958 * typemanager.cs (EnumToUnderlying): This function is used to get
28959 the underlying type from an enumeration, because it does not
28962 * constant.cs: Use the I4_S form for values between -128 and 127.
28964 * statement.cs (Block.LookupLabel): Looks up a label.
28965 (Block): Drop support for labeled blocks.
28967 (LabeledStatement): New kind of statement that represents a label
28970 (Goto): Finally implement this bad boy.
28972 * cs-parser.jay: Update to reflect new mechanism to implement
28975 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28977 * codegen.cs (EmitContext.This): a codegen property that keeps the
28978 a single instance of this instead of creating many different this
28981 * delegate.cs (Delegate.DoResolve): Update to use the property;
28983 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28985 * expression.cs (BaseAccess.DoResolve): Ditto.
28987 2001-12-29 Ravi Pratap <ravi@ximian.com>
28989 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28990 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28992 (InitCoreTypes): Update accordingly.
28994 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28995 so we can quickly store the state.
28997 (ApplyAttributes): Set the correct implementation flags
28998 for InternalCall methods.
29000 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29002 * expression.cs (EmitCall): if a method is not virtual, then do
29003 not use callvirt on it.
29005 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29006 user defined stuff) requires the use of stobj, which takes an
29007 address on the stack instead of an array and an index. So emit
29008 the Ldelema operation for it.
29010 (EmitStoreOpcode): Use stobj for valuetypes.
29012 (UnaryMutator.EmitCode): Use the right 1 value depending on
29013 whether we are dealing with int64/uint64, float or doubles.
29015 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29016 constructors that I implemented last night.
29018 (Constructor.IsDefault): Fix to work properly for static
29021 * cs-parser.jay (CheckDef): report method signature errors.
29022 Update error number 103 to be 132.
29024 * decl.cs: New AdditionResult enumeration value: MethodExists.
29025 Although we do this check for methods later on in the semantic
29026 analysis, catching repeated default constructors is so easy that
29027 we catch these here.
29029 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29032 (ParameterReference.EmitAssign, Emit): handle
29035 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29036 (ArrayAccess.EmitStoreOpcode): ditto.
29038 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29040 * expression.cs (MakeByteBlob): Complete all the missing types
29041 (uint, short, ushort, byte, sbyte)
29043 * class.cs: Only init instance field initializers on instance
29046 Rename `constructors' to instance_constructors.
29048 (TypeContainer.AddConstructor): Only add constructors to the list
29049 if it is not static.
29051 Make sure that we handle default_static_constructor independently
29052 everywhere where we handle instance_constructors
29054 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29056 * class.cs: Do not lookup or create a base initializer for a
29057 static constructor.
29059 (ConstructorInitializer.Resolve): use the proper type to lookup
29062 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29064 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29067 * decl.cs: CloseType is now an virtual method, the default
29068 implementation just closes this type.
29070 2001-12-28 Ravi Pratap <ravi@ximian.com>
29072 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29073 to PreserveSig by default. Also emit HideBySig on such methods.
29075 Basically, set the defaults to standard values.
29077 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29078 argument, if candidate is better, it can't be worse than the best !
29080 (Invocation): Re-write bits to differentiate between methods being
29081 applicable in their expanded form and their normal form - for params
29084 Get rid of use_standard everywhere as only standard conversions are allowed
29085 in overload resolution.
29087 More spec conformance.
29089 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29091 * driver.cs: Add --timestamp, to see where the compiler spends
29094 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29095 `this' in static code.
29097 (SimpleName.DoResolve): Implement in terms of a helper function
29098 that allows static-references to be passed upstream to
29101 (Expression.ResolveWithSimpleName): Resolve specially simple
29102 names when called by MemberAccess to implement the special
29105 (Expression.ImplicitReferenceConversion): Handle conversions from
29106 Null to reference types before others, as Null's type is
29109 * expression.cs (Invocation.EmitCall): Handle the special case of
29110 calling methods declared on a reference type from a ValueType
29111 (Base classes System.Object and System.Enum)
29113 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29114 the left hand side is a TypeExpr, not on every enumeration.
29116 (Binary.Resolve): If types are reference types, then do a cast to
29117 object on operators != and == of both arguments.
29119 * typemanager.cs (FindMembers): Extract instance and static
29120 members if requested.
29122 * interface.cs (PopulateProperty): Use void_type instead of null
29123 as the return type for the setter method.
29125 (PopulateIndexer): ditto.
29127 2001-12-27 Ravi Pratap <ravi@ximian.com>
29129 * support.cs (ReflectionParameters): Fix minor bug where we
29130 were examining the wrong parameter for the ParamArray attribute.
29132 Cope with requests for the type of the parameter at position
29133 greater than the params parameter's. We now return the element
29134 type of the params array as that makes more sense.
29136 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29137 accordingly as we no longer have to extract the element type
29140 (Invocation.OverloadResolve): Update.
29142 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29144 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29145 against IEnumerator, test whether the return value is a descendant
29146 of the IEnumerator interface.
29148 * class.cs (Indexer.Define): Use an auxiliary method to implement
29149 the other bits of the method definition. Begin support for
29150 explicit interface implementation.
29152 (Property.DefineMethod): Use TypeManager.void_type instead of null
29153 for an empty return value.
29155 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29157 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29158 dealing with a FieldExpr which is composed of a FieldBuilder, in
29159 the code path we did extract the constant, but we should have
29160 obtained the underlying value to be able to cast it (otherwise we
29161 end up in an infinite loop, this is what Ravi was running into).
29163 (ArrayCreation.UpdateIndices): Arrays might be empty.
29165 (MemberAccess.ResolveMemberAccess): Add support for section
29166 14.5.4.1 that deals with the special case of E.I when E is a type
29167 and something else, that I can be a reference to a static member.
29169 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29170 handle a particular array type to create byte blobs, it is just
29171 something we dont generate byteblobs for.
29173 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29176 * location.cs (Push): remove the key from the hashtable that we
29177 are about to add. This happens for empty files.
29179 * driver.cs: Dispose files after we have parsed them.
29181 (tokenize): new function that only runs the tokenizer on its
29182 input, for speed testing.
29184 2001-12-26 Ravi Pratap <ravi@ximian.com>
29186 * class.cs (Event.Define): Define the private field only if there
29187 are no accessors defined.
29189 * expression.cs (ResolveMemberAccess): If there is no associated
29190 field with the event, that means we have an event defined with its
29191 own accessors and we should flag error cs0070 since transforming
29192 ourselves into a field is not valid in that case.
29194 * ecore.cs (SimpleName.DoResolve): Same as above.
29196 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29197 and charset to sane values.
29199 2001-12-25 Ravi Pratap <ravi@ximian.com>
29201 * assign.cs (DoResolve): Perform check on events only if they
29202 are being accessed outside the declaring type.
29204 * cs-parser.jay (event_declarations): Update rules to correctly
29205 set the type of the implicit parameter etc.
29207 (add_accessor, remove_accessor): Set current local parameters.
29209 * expression.cs (Binary): For delegate addition and subtraction,
29210 cast the return value from the method into the appropriate delegate
29213 2001-12-24 Ravi Pratap <ravi@ximian.com>
29215 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29216 of these as the workaround is unnecessary.
29218 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29219 delegate data - none of that is needed at all.
29221 Re-write bits to extract the instance expression and the delegate method
29224 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29227 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29228 of attaching attributes instead of duplicating code everywhere.
29230 * everywhere : Update code to do attribute emission using the above method.
29232 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29234 * expression.cs (IsParamsMethodApplicable): if there are not
29235 parameters, return immediately.
29237 * ecore.cs: The 0 literal can be implicity converted to an enum
29240 (SimpleName.DoResolve): First lookup the type, then lookup the
29243 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29244 want to get its address. If the InstanceExpression is not
29245 addressable, store the result in a temporary variable, then get
29248 * codegen.cs: Only display 219 errors on warning level or above.
29250 * expression.cs (ArrayAccess): Make it implement the
29251 IMemoryLocation interface.
29253 (Binary.DoResolve): handle the operator == (object a, object b)
29254 and operator != (object a, object b) without incurring into a
29255 BoxedCast (because 5 != o should never be performed).
29257 Handle binary enumerator operators.
29259 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29260 value type, otherwise use Ldelem_ref.
29262 Use precomputed names;
29264 (AddressOf): Implement address of
29266 * cs-parser.jay (labeled_statement): Fix recursive block
29267 addition by reworking the production.
29269 * expression.cs (New.DoEmit): New has a special case:
29271 If we are dealing with a ValueType, we have a few
29272 situations to deal with:
29274 * The target of New is a ValueType variable, that is
29275 easy, we just pass this as the variable reference
29277 * The target of New is being passed as an argument,
29278 to a boxing operation or a function that takes a
29281 In this case, we need to create a temporary variable
29282 that is the argument of New.
29285 2001-12-23 Ravi Pratap <ravi@ximian.com>
29287 * rootcontext.cs (LookupType): Check that current_type is not null before
29288 going about looking at nested types.
29290 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29291 not implement the IAssignMethod interface any more.
29293 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29294 where we tranform them into FieldExprs if they are being resolved from within
29295 the declaring type.
29297 * ecore.cs (SimpleName.DoResolve): Do the same here.
29299 * assign.cs (DoResolve, Emit): Clean up code considerably.
29301 * ../errors/bug10.cs : Add.
29303 * ../errors/cs0070.cs : Add.
29305 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29307 * assign.cs : Get rid of EventIsLocal everywhere.
29309 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29311 * ecore.cs (ConvertIntLiteral): finished the implementation.
29313 * statement.cs (SwitchLabel): Convert the value we are using as a
29314 key before looking up the table.
29316 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29318 * codegen.cs (EmitTopBlock): Require a Location argument now.
29320 * cs-parser.jay (constructor_declarator): We need to setup
29321 current_local_parameters before we parse the
29322 opt_constructor_initializer, to allow the variables to be bound
29323 to the constructor arguments.
29325 * rootcontext.cs (LookupType): First lookup nested classes in our
29326 class and our parents before we go looking outside our class.
29328 * expression.cs (ConstantFold): Extract/debox the values at the
29331 * rootcontext.cs (EmitCode): Resolve the constants first before we
29332 resolve the types. This is not really needed, but it helps debugging.
29334 * statement.cs: report location.
29336 * cs-parser.jay: pass location to throw statement.
29338 * driver.cs: Small bug fix.
29340 * report.cs: Updated format to be 4-zero filled digits.
29342 2001-12-22 Ravi Pratap <ravi@ximian.com>
29344 * expression.cs (CheckIndices): Fix minor bug where the wrong
29345 variable was being referred to ;-)
29347 (DoEmit): Do not call EmitStaticInitializers when the
29348 underlying type is System.Object.
29350 2001-12-21 Ravi Pratap <ravi@ximian.com>
29352 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29353 and do the usual workaround for SRE.
29355 * class.cs (MyEventBuilder.EventType): New member to get at the type
29356 of the event, quickly.
29358 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29360 * assign.cs (Assign.DoResolve): Handle the case when the target
29361 is an EventExpr and perform the necessary checks.
29363 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29366 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29368 (EventExpr): Set the type in the constructor itself since we
29369 are meant to be born fully resolved.
29371 (EventExpr.Define): Revert code I wrote earlier.
29373 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29374 instance expression is null. The instance expression is a This in that case
29375 or a null, depending on whether it is a static method or not.
29377 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29378 refers to more than one method.
29380 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29381 and accordingly flag errors.
29383 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29385 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29387 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29389 * location.cs (ToString): Provide useful rutine.
29391 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29393 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29394 objects, return the actual integral boxed.
29396 * statement.cs (SwitchLabel): define an ILLabel for each
29399 (Switch.CheckSwitch): If the value is a Literal, extract
29400 the underlying literal.
29402 Also in the unused hashtable we had, add the SwitchLabel so we can
29403 quickly look this value up.
29405 * constant.cs: Implement a bunch of new constants. Rewrite
29406 Literal based on this. Made changes everywhere to adapt to this.
29408 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29409 dereferencing array only once, and also copes with enumrations.
29411 bytes are two bytes wide, not one.
29413 (Cast): Perform constant conversions.
29415 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29416 wrappers to the literals here.
29418 * expression.cs (DoNumericPromotions): long literals can converted
29419 to ulong implicity (this is taken care of elsewhere, but I was
29420 missing this spot).
29422 * ecore.cs (Expression.Literalize): Make the return type Literal,
29423 to improve type checking.
29425 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29427 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29429 * literal.cs: Revert code from ravi that checked the bounds. The
29430 bounds are sane by the definition of the type itself.
29432 * typemanager.cs: Fix implementation of ImplementsInterface. We
29433 need to actually look up in our parent hierarchy for interfaces
29436 * const.cs: Use the underlying type for enumerations
29438 * delegate.cs: Compute the basename for the delegate creation,
29439 that should fix the delegate test case, and restore the correct
29440 Type Lookup semantics in rootcontext
29442 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29443 referencing a nested type with the Reflection API is using the "+"
29446 * cs-parser.jay: Do not require EOF token at the end.
29448 2001-12-20 Ravi Pratap <ravi@ximian.com>
29450 * rootcontext.cs (LookupType): Concatenate type names with
29451 a '.' instead of a '+' The test suite passes again.
29453 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29454 field of the enumeration.
29456 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29457 the case when the member is an EventExpr.
29459 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29460 static has an associated instance expression.
29462 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29464 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29466 * class.cs (Event.Define): Register event and perform appropriate checks
29469 We define the Add and Remove methods even if the use provides none because
29470 in that case, we provide default implementations ourselves.
29472 Define a private field of the type of the event. This is done by the CSC compiler
29473 and we should be doing it too ;-)
29475 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29476 More methods we use in code we generate.
29478 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29481 (InitCoreTypes): Update accordingly for the above.
29483 * class.cs (Event.Emit): Generate code for default accessors that we provide
29485 (EmitDefaultMethod): Do the job in the above.
29487 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29490 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29492 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29493 builders even if we were missing one.
29495 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29496 pass the Basename as our class name instead of the Name. The
29497 basename will be correctly composed for us.
29499 * parameter.cs (Paramters): Now takes a Location argument.
29501 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29502 make all the code call directly LookupType in RootContext and take
29503 this chance to pass the Location information everywhere.
29505 * Everywhere: pass Location information.
29507 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29509 * class.cs (Constructor.Define): Updated way of detecting the
29510 length of the parameters.
29512 (TypeContainer.DefineType): Use basename as the type name for
29515 (TypeContainer.Define): Do not recursively define types here, as
29516 definition is taken care in order by the RootContext.
29518 * tree.cs: Keep track of namespaces in a per-file basis.
29520 * parameter.cs (Parameter.ComputeSignature): Update to use
29523 (Parameters.GetSignature): ditto.
29525 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29526 instead of a TypeContainer.
29528 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29529 resolve names. Because we need to be resolve in our context, not
29532 * driver.cs: Implement response files.
29534 * class.cs (TypeContainer.DefineType): If we are defined, do not
29535 redefine ourselves.
29537 (Event.Emit): Emit the code for add/remove handlers.
29538 (Event.Define): Save the MethodBuilders for add/remove.
29540 * typemanager.cs: Use pair here too.
29542 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29543 DictionaryEntry requires the first argument to be non-null.
29545 (enum_declaration): Compute full name for registering the
29548 (delegate_declaration): Instead of using
29549 formal_parameter_list, use opt_formal_parameter_list as the list
29552 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29553 (EventParsing): New property that controls whether `add' and
29554 `remove' are returned as tokens or identifiers (for events);
29556 2001-12-19 Ravi Pratap <ravi@ximian.com>
29558 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29559 use MyEventBuilder only and let it wrap the real builder for us.
29561 (MyEventBuilder): Revamp constructor etc.
29563 Implement all operations that we perform on EventBuilder in precisely the same
29566 (FindMembers): Update to use the EventBuilder member.
29568 (Event.Emit): Update accordingly.
29570 2001-12-18 Ravi Pratap <ravi@ximian.com>
29572 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29573 by calling the appropriate methods.
29575 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29578 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29580 2001-12-17 Ravi Pratap <ravi@ximian.com>
29582 * delegate.cs (Delegate.Populate): Check that the return type
29583 and various parameters types are indeed accessible.
29585 * class.cs (Constructor.Define): Same here.
29587 (Field.Define): Ditto.
29589 (Event.Define): Ditto.
29591 (Operator.Define): Check that the underlying Method defined itself
29592 correctly - so it's MethodBuilder should not be null.
29594 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29595 expression happens to be null.
29597 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29598 members but as of now we don't seem to be able to do anything really useful with it.
29600 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29601 not the EventBuilder.
29603 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29605 * cs-tokenizer.cs: Add support for defines.
29606 Add support for #if, #elif, #else, #endif
29608 (eval_var): evaluates a variable.
29609 (eval): stubbed for evaluating functions.
29611 * cs-parser.jay: Pass the defines information
29613 * driver.cs: Add --define command line option.
29615 * decl.cs: Move MemberCore here.
29617 Make it the base class for DeclSpace. This allows us to catch and
29618 report 108 and 109 for everything now.
29620 * class.cs (TypeContainer.Define): Extract all the members
29621 before populating and emit the warning 108 (new keyword required
29622 to override) instead of having each member implement this.
29624 (MemberCore.Define): New abstract method, we will be using this in
29625 the warning reporting engine in Populate.
29627 (Operator.Define): Adjust to new MemberCore protocol.
29629 * const.cs (Const): This does not derive from Expression, it is a
29630 temporary object we use to create fields, it is a MemberCore.
29632 * class.cs (Method.Define): Allow the entry point to be in a
29635 * driver.cs: Rewrite the argument handler to clean it up a bit.
29637 * rootcontext.cs: Made it just an auxiliary namespace feature by
29638 making everything static.
29640 * driver.cs: Adapt code to use RootContext type name instead of
29643 * delegate.cs: Remove RootContext argument.
29645 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29648 * class.cs (Event.Define): The lookup can fail.
29650 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29652 * expression.cs: Resolve the this instance before invoking the code.
29654 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29656 * cs-parser.jay: Add a production in element_access that allows
29657 the thing to become a "type" reference. This way we can parse
29658 things like "(string [])" as a type.
29660 Note that this still does not handle the more complex rules of
29664 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29666 * ecore.cs: (CopyNewMethods): new utility function used to
29667 assemble the list of methods from running FindMembers.
29669 (MemberLookup): Rework FindMembers so that
29671 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29673 * class.cs (TypeContainer): Remove Delegates who fail to be
29676 * delegate.cs (Populate): Verify that we dont get null return
29677 values. TODO: Check for AsAccessible.
29679 * cs-parser.jay: Use basename to emit error 574 (destructor should
29680 have the same name as container class), not the full name.
29682 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29683 possible representation.
29685 Also implements integer type suffixes U and L.
29687 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29689 * expression.cs (ArrayCreation.DoResolve): We need to do the
29690 argument resolution *always*.
29692 * decl.cs: Make this hold the namespace. Hold the root context as
29694 (LookupType): Move here.
29696 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29698 * location.cs (Row, Name): Fixed the code, it was always returning
29699 references to the first file.
29701 * interface.cs: Register properties defined through interfaces.
29703 * driver.cs: Add support for globbing on the command line
29705 * class.cs (Field): Make it derive from MemberCore as well.
29708 2001-12-15 Ravi Pratap <ravi@ximian.com>
29710 * class.cs (Event::Define): Check that the type of the event is a delegate
29711 type else flag error #66.
29713 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29716 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29717 values of EntryPoint, CharSet etc etc.
29719 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29721 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29722 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29723 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29724 which needs this to do its work.
29726 * ../errors/cs0066.cs : Add.
29728 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29730 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29733 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29734 clears out the parameters field.
29735 (MemberSignatureCompare): Cleanup
29737 (MemberCore): New base class used to share code between MethodCore
29740 (RegisterRequiredImplementations) BindingFlags.Public requires
29741 either BindingFlags.Instace or Static. Use instance here.
29743 (Property): Refactored code to cope better with the full spec.
29745 * parameter.cs (GetParameterInfo): Return an empty array instead
29748 * class.cs (Property): Abstract or extern properties have no bodies.
29750 * parameter.cs (GetParameterInfo): return a zero-sized array.
29752 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29753 method modifier validation to the typecontainer so we can reuse
29754 this on properties.
29756 (MethodCore.ParameterTypes): return an empty sized array of types.
29758 (Property.Define): Test property modifier validity.
29760 Add tests for sealed/override too.
29762 (Method.Emit): abstract or extern methods have no bodies.
29764 2001-12-14 Ravi Pratap <ravi@ximian.com>
29766 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29769 (Method::Define, ::Emit): Modify accordingly.
29771 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29773 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29775 * makefile: Pass in /unsafe.
29777 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29779 * class.cs (MakeKey): Kill routine.
29781 * class.cs (TypeContainer.Define): Correctly define explicit
29782 method implementations (they require the full interface name plus
29785 * typemanager.cs: Deply the PtrHashtable here and stop using the
29786 lame keys. Things work so much better.
29788 This of course broke everyone who depended on `RegisterMethod' to
29789 do the `test for existance' test. This has to be done elsewhere.
29791 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29792 the object stupid Equals method (because, that like fails all over
29793 the place). We still do not use it.
29795 * class.cs (TypeContainer.SetRequiredInterface,
29796 TypeContainer.RequireMethods): Killed these two routines and moved
29797 all the functionality to RegisterRequiredImplementations.
29799 (TypeContainer.RegisterRequiredImplementations): This routine now
29800 registers all the implementations required in an array for the
29801 interfaces and abstract methods. We use an array of structures
29802 which can be computed ahead of time to reduce memory usage and we
29803 also assume that lookups are cheap as most classes will not
29804 implement too many interfaces.
29806 We also avoid creating too many MethodSignatures.
29808 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29809 clear the "pending" bit if we find that there are problems with
29812 (TypeContainer.VerifyPendingMethods): Update to report errors of
29813 methods that look like implementations but are not.
29815 (TypeContainer.Define): Add support for explicit interface method
29818 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29820 * typemanager.cs: Keep track of the parameters here instead of
29821 being a feature of the TypeContainer.
29823 * class.cs: Drop the registration of parameters here, as
29824 InterfaceMethods are also interface declarations.
29826 * delegate.cs: Register methods with the TypeManager not only with
29827 the TypeContainer. This code was buggy.
29829 * interface.cs: Full registation here.
29831 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29833 * expression.cs: Remove reducer for binary expressions, it can not
29836 * const.cs: Put here the code that used to go into constant.cs
29838 * constant.cs: Put here the code for constants, this is a new base
29839 class for Literals.
29841 * literal.cs: Make Literal derive from Constant.
29843 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29845 * statement.cs (Return.Emit): Report error 157 if the user
29846 attempts to return from a finally block.
29848 (Return.Emit): Instead of emitting a return, jump to the end of
29851 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29852 LocalBuilder to store the result of the function. ReturnLabel is
29853 the target where we jump.
29856 2001-12-09 Radek Doulik <rodo@ximian.com>
29858 * cs-parser.jay: remember alias in current namespace
29860 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29863 * class.cs (LookupAlias): lookup alias in my_namespace
29865 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29867 (LookupAlias): lookup alias in this and if needed in parent
29870 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29874 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29875 making things static. I need this to avoid passing the
29876 TypeContainer when calling ParameterType.
29878 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29879 that did string manipulation to compute the type and then call
29880 GetType. Use Parameter.ParameterType instead.
29882 * cs-tokenizer.cs: Consume the suffix for floating values.
29884 * expression.cs (ParameterReference): figure out whether this is a
29885 reference parameter or not. Kill an extra variable by computing
29886 the arg_idx during emission.
29888 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29889 function that returns whether a parameter is an out/ref value or not.
29891 (Parameter.ParameterType): The type of the parameter (base,
29892 without ref/out applied).
29894 (Parameter.Resolve): Perform resolution here.
29895 (Parameter.ExternalType): The full type (with ref/out applied).
29897 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29898 support for expressions on the using statement.
29900 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29902 * statement.cs (Using.EmitLocalVariableDecls): Split the
29903 localvariable handling of the using statement.
29905 (Block.EmitMeta): Keep track of variable count across blocks. We
29906 were reusing slots on separate branches of blocks.
29908 (Try.Emit): Emit the general code block, we were not emitting it.
29910 Check the type of the declaration to be an IDisposable or
29911 something that can be implicity converted to it.
29913 Emit conversions if required.
29915 * ecore.cs (EmptyExpression): New utility class.
29916 (Expression.ImplicitConversionExists): New utility function.
29918 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29920 * statement.cs (Using): Implement.
29922 * expression.cs (LocalVariableReference): Support read only variables.
29924 * statement.cs: Remove the explicit emit for the Leave opcode.
29925 (VariableInfo): Add a readonly field.
29927 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29929 * ecore.cs (ConvCast): new class used to encapsulate the various
29930 explicit integer conversions that works in both checked and
29931 unchecked contexts.
29933 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29934 properly generate the overflow opcodes.
29936 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29938 * statement.cs: The correct type for the EmptyExpression is the
29939 element_type, not the variable type. Ravi pointed this out.
29941 2001-12-04 Ravi Pratap <ravi@ximian.com>
29943 * class.cs (Method::Define): Handle PInvoke methods specially
29944 by using DefinePInvokeMethod instead of the usual one.
29946 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29947 above to do the task of extracting information and defining the method.
29949 2001-12-04 Ravi Pratap <ravi@ximian.com>
29951 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29952 of the condition for string type.
29954 (Emit): Move that here.
29956 (ArrayCreation::CheckIndices): Keep string literals in their expression
29959 (EmitDynamicInitializers): Handle strings appropriately.
29961 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29963 * codegen.cs (EmitContext): Replace multiple variables with a
29964 single pointer to the current Switch statement.
29966 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29969 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29973 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29976 (Foreach.Emit): Foreach on arrays was not setting
29977 up the loop variables (for break/continue).
29979 (GotoCase): Semi-implented.
29981 2001-12-03 Ravi Pratap <ravi@ximian.com>
29983 * attribute.cs (CheckAttribute): Handle system attributes by using
29984 Attribute.GetAttributes to examine information we need.
29986 (GetValidPlaces): Same here.
29988 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29990 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29992 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29994 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29996 (Method::Emit): Handle the case when we are a PInvoke method.
29998 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30000 * expression.cs: Use ResolveWithSimpleName on compound names.
30002 2001-12-02 Ravi Pratap <ravi@ximian.com>
30004 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30005 before trying to reduce it.
30007 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30009 * constant.cs (LookupConstantValue): Implement.
30011 (EmitConstant): Use the above in emitting the constant.
30013 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30014 that are user-defined by doing a LookupConstantValue on them.
30016 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30019 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30021 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30023 (BaseAccess.DoResolve): Implement.
30025 (MemberAccess.DoResolve): Split this routine into a
30026 ResolveMemberAccess routine that can be used independently
30028 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30030 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30031 As that share bits of the implementation. Is returns a boolean,
30032 while As returns the Type that is being probed.
30034 2001-12-01 Ravi Pratap <ravi@ximian.com>
30036 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30037 instead of a Literal - much easier.
30039 (EnumInTransit): Remove - utterly useless :-)
30041 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30043 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30045 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30046 chain when we have no associated expression.
30048 2001-11-30 Ravi Pratap <ravi@ximian.com>
30050 * constant.cs (Define): Use Location while reporting the errror.
30052 Also emit a warning when 'new' is used and there is no inherited
30055 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30058 (LookupEnumValue): Implement to lookup an enum member's value and define it
30061 (Populate): Re-write accordingly to use the above routine.
30063 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30065 * expression.cs (This): Fix prototype for DoResolveLValue to
30066 override the base class DoResolveLValue.
30068 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30071 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30072 (we need to load the address of the field here). This fixes
30075 (FieldExpr.DoResolveLValue): Call the DoResolve
30076 function to initialize the Instance expression.
30078 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30079 correctly the GetEnumerator operation on a value type.
30081 * cs-parser.jay: Add more simple parsing error catches.
30083 * statement.cs (Switch): Add support for string switches.
30084 Handle null specially.
30086 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30088 2001-11-28 Ravi Pratap <ravi@ximian.com>
30090 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30092 (declare_local_constant): New helper function.
30094 * statement.cs (AddConstant): Keep a separate record of constants
30096 (IsConstant): Implement to determine if a variable is a constant.
30098 (GetConstantExpression): Implement.
30100 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30102 * statement.cs (IsVariableDefined): Re-write.
30104 2001-11-27 Ravi Pratap <ravi@ximian.com>
30106 * class.cs (TypeContainer::FindMembers): Look for constants
30107 in the case when we are looking for MemberTypes.Field
30109 * expression.cs (MemberAccess::DoResolve): Check that in the
30110 case we are a FieldExpr and a Literal, we are not being accessed
30111 by an instance reference.
30113 * cs-parser.jay (local_constant_declaration): Implement.
30115 (declaration_statement): Implement for constant declarations.
30117 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30119 * statement.cs (Switch): Catch double defaults.
30121 (Switch): More work on the switch() statement
30122 implementation. It works for integral values now, need to finish
30126 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30128 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30129 integer literals into other integer literals. To be used by
30132 2001-11-24 Ravi Pratap <ravi@ximian.com>
30134 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30137 (EmitDynamicInitializers): Cope with the above since we extract data
30138 directly from ArrayData now.
30140 (ExpectInitializers): Keep track of whether initializers are mandatory
30143 (Bounds): Make it a hashtable to prevent the same dimension being
30144 recorded for every element in that dimension.
30146 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30149 Also fix bug which was causing the indices to be emitted in the reverse
30152 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30154 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30155 unfinished. They do not work, because the underlying code is
30158 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30160 * cs-parser.jay: Remove bogus fixme.
30162 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30163 on Switch statement.
30165 2001-11-23 Ravi Pratap <ravi@ximian.com>
30167 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30170 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30171 parameter. Apparently, any expression is allowed.
30173 (ValidateInitializers): Update accordingly.
30175 (CheckIndices): Fix some tricky bugs thanks to recursion.
30177 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30178 I was being completely brain-dead.
30180 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30181 and re-write acordingly.
30183 (DelegateInvocation): Re-write accordingly.
30185 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30187 (MakeByteBlob): Handle types more correctly.
30189 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30190 initialization from expressions but it is incomplete because I am a complete
30193 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30195 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30196 on If. Basically, we have to return `true' (ie, we do return to
30197 our caller) only if both branches of the if return.
30199 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30200 short-circuit operators, handle them as short circuit operators.
30202 (Cast.DoResolve): Resolve type.
30203 (Cast.Cast): Take an expression as the target type.
30205 * cs-parser.jay (cast_expression): Remove old hack that only
30206 allowed a limited set of types to be handled. Now we take a
30207 unary_expression and we resolve to a type during semantic
30210 Use the grammar productions from Rhys to handle casts (this is
30211 not complete like Rhys syntax yet, we fail to handle that corner
30212 case that C# has regarding (-x), but we will get there.
30214 2001-11-22 Ravi Pratap <ravi@ximian.com>
30216 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30217 field which is an array type.
30219 * cs-parser.jay (declare_local_variables): Support array initialization too.
30221 * typemanager.cs (MakeKey): Implement.
30223 (everywhere): Use the above appropriately.
30225 * cs-parser.jay (for_statement): Update for array initialization while
30226 declaring variables.
30228 * ecore.cs : The error message was correct, it's the variable's names that
30229 were misleading ;-) Make the code more readable.
30231 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30232 the correct type etc.
30234 (ConvertExplicit): Handle Enum types by examining the underlying type.
30236 2001-11-21 Ravi Pratap <ravi@ximian.com>
30238 * parameter.cs (GetCallingConvention): Always return
30239 CallingConventions.Standard for now.
30241 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30243 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30244 and `r' after calling DoNumericPromotions.
30246 * ecore.cs: Fix error message (the types were in the wrong order).
30248 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30249 BindingFlags.Instance as well
30251 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30252 implicit int literal conversion in an empty cast so that we
30253 propagate the right type upstream.
30255 (UnboxCast): new class used to unbox value types.
30256 (Expression.ConvertExplicit): Add explicit type conversions done
30259 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30260 the target type before applying the implicit LongLiterals to ULong
30263 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30265 * cs-parser.jay (for_statement): Reworked the way For works: now
30266 we declare manually any variables that are introduced in
30267 for_initializer to solve the problem of having out-of-band code
30268 emition (that is what got for broken).
30270 (declaration_statement): Perform the actual variable declaration
30271 that used to be done in local_variable_declaration here.
30273 (local_variable_declaration): Do not declare anything, just pass
30274 the information on a DictionaryEntry
30276 2001-11-20 Ravi Pratap <ravi@ximian.com>
30278 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30279 re-write of the logic to now make it recursive.
30281 (UpdateIndices): Re-write accordingly.
30283 Store element data in a separate ArrayData list in the above methods.
30285 (MakeByteBlob): Implement to dump the array data into a byte array.
30287 2001-11-19 Ravi Pratap <ravi@ximian.com>
30289 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30292 * constant.cs (Define): Implement.
30294 (EmitConstant): Re-write fully.
30296 Pass in location info.
30298 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30301 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30302 DictionaryEntry since we need location info too.
30304 (constant_declaration): Update accordingly.
30306 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30307 code into another method : UpdateIndices.
30309 2001-11-18 Ravi Pratap <ravi@ximian.com>
30311 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30312 some type checking etc.
30314 2001-11-17 Ravi Pratap <ravi@ximian.com>
30316 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30317 bits to provide dimension info if the user skips doing that.
30319 Update second constructor to store the rank correctly.
30321 2001-11-16 Ravi Pratap <ravi@ximian.com>
30323 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30324 and try to implement.
30326 * ../errors/cs0150.cs : Add.
30328 * ../errors/cs0178.cs : Add.
30330 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30332 * statement.cs: Implement foreach on multi-dimensional arrays.
30334 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30335 name of the params argument.
30337 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30338 initializing the array.
30340 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30341 we can use this elsewhere.
30343 * statement.cs: Finish implementation of foreach for single
30346 * cs-parser.jay: Use an out-of-band stack to pass information
30347 around, I wonder why I need this.
30349 foreach_block: Make the new foreach_block the current_block.
30351 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30352 function used to return a static Parameters structure. Used for
30353 empty parameters, as those are created very frequently.
30355 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30357 2001-11-15 Ravi Pratap <ravi@ximian.com>
30359 * interface.cs : Default modifier is private, not public. The
30360 make verify test passes again.
30362 2001-11-15 Ravi Pratap <ravi@ximian.com>
30364 * support.cs (ReflectionParameters): Fix logic to determine
30365 whether the last parameter is a params one. Test 9 passes again.
30367 * delegate.cs (Populate): Register the builders we define with
30368 RegisterParameterForBuilder. Test 19 passes again.
30370 * cs-parser.jay (property_declaration): Reference $6 instead
30371 of $$ to get at the location.
30373 (indexer_declaration): Similar stuff.
30375 (attribute): Ditto.
30377 * class.cs (Property): Register parameters for the Get and Set methods
30378 if they exist. Test 23 passes again.
30380 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30381 call to EmitArguments as we are sure there aren't any params arguments.
30382 Test 32 passes again.
30384 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30385 IndexOutOfRangeException.
30387 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30388 Test 33 now passes again.
30390 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30392 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30393 broke a bunch of things. Will have to come up with a better way
30394 of tracking locations.
30396 * statement.cs: Implemented foreach for single dimension arrays.
30398 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30400 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30401 an error. This removes the lookup from the critical path.
30403 * cs-parser.jay: Removed use of temporary_loc, which is completely
30406 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30408 * support.cs (ReflectionParameters.ParameterModifier): Report
30409 whether the argument is a PARAMS argument or not.
30411 * class.cs: Set the attribute `ParamArrayAttribute' on the
30412 parameter argument.
30414 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30415 and cons_param_array_attribute (ConstructorInfo for
30416 ParamArrayAttribute).,
30418 * codegen.cs: Emit the return using the `Return' statement, that
30419 way we can report the error correctly for missing return values.
30421 * class.cs (Method.Emit): Clean up.
30423 * expression.cs (Argument.Resolve): Take another argument: the
30424 location where this argument is used. Notice that this is not
30425 part of the "Argument" class as to reduce the size of the
30426 structure (we know the approximate location anyways).
30428 Test if the argument is a variable-reference, if not, then
30429 complain with a 206.
30431 (Argument.Emit): Emit addresses of variables.
30433 (Argument.FullDesc): Simplify.
30435 (Invocation.DoResolve): Update for Argument.Resolve.
30437 (ElementAccess.DoResolve): ditto.
30439 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30440 method should be virtual, as this method is always virtual.
30442 (NewDelegate.DoResolve): Update for Argument.Resolve.
30444 * class.cs (ConstructorInitializer.DoResolve): ditto.
30446 * attribute.cs (Attribute.Resolve): ditto.
30448 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30450 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30452 * expression.cs (ParameterReference): Drop IStackStorage and implement
30453 IAssignMethod instead.
30455 (LocalVariableReference): ditto.
30457 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30458 IAssignMethod instead.
30460 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30462 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30463 enumerations that are used in heavily used structures derive from
30464 byte in a laughable and pathetic attempt to reduce memory usage.
30465 This is the kind of pre-optimzations that you should not do at
30466 home without adult supervision.
30468 * expression.cs (UnaryMutator): New class, used to handle ++ and
30469 -- separatedly from the other unary operators. Cleans up the
30470 code, and kills the ExpressionStatement dependency in Unary.
30472 (Unary): Removed `method' and `Arguments' from this class, making
30473 it smaller, and moving it all to SimpleCall, so I can reuse this
30474 code in other locations and avoid creating a lot of transient data
30475 strucutres when not required.
30477 * cs-parser.jay: Adjust for new changes.
30479 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30481 * enum.cs (Enum.Populate): If there is a failure during
30484 * cs-parser.jay (opt_enum_base): we used to catch type errors
30485 here, but this is really incorrect. The type error should be
30486 catched during semantic analysis.
30488 2001-12-11 Ravi Pratap <ravi@ximian.com>
30490 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30491 current_local_parameters as expected since I, in my stupidity, had forgotten
30494 * attribute.cs (GetValidPlaces): Fix stupid bug.
30496 * class.cs (Method::Emit): Perform check on applicability of attributes.
30498 (Constructor::Emit): Ditto.
30500 (Field::Emit): Ditto.
30502 (Field.Location): Store location information.
30504 (Property, Event, Indexer, Operator): Ditto.
30506 * cs-parser.jay (field_declaration): Pass in location for each field.
30508 * ../errors/cs0592.cs : Add.
30510 2001-11-12 Ravi Pratap <ravi@ximian.com>
30512 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30514 (InitCoreTypes): Update accordingly.
30516 (RegisterAttrType, LookupAttr): Implement.
30518 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30519 info about the same.
30521 (Resolve): Update to populate the above as necessary.
30523 (Error592): Helper.
30525 (GetValidPlaces): Helper to the above.
30527 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30529 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30531 2001-11-12 Ravi Pratap <ravi@ximian.com>
30533 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30535 * ../errors/cs0617.cs : Add.
30537 2001-11-11 Ravi Pratap <ravi@ximian.com>
30539 * enum.cs (Emit): Rename to Populate to be more consistent with what
30540 we expect it to do and when exactly it is called.
30542 * class.cs, rootcontext.cs : Update accordingly.
30544 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30545 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30547 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30549 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30550 of a fieldinfo using the above, when dealing with a FieldBuilder.
30552 2001-11-10 Ravi Pratap <ravi@ximian.com>
30554 * ../errors/cs0031.cs : Add.
30556 * ../errors/cs1008.cs : Add.
30558 * ../errrors/cs0543.cs : Add.
30560 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30563 (FindMembers): Implement.
30565 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30566 enums and delegates too.
30568 (enum_types): Rename to builder_to_enum.
30570 (delegate_types): Rename to builder_to_delegate.
30572 * delegate.cs (FindMembers): Implement.
30574 2001-11-09 Ravi Pratap <ravi@ximian.com>
30576 * typemanager.cs (IsEnumType): Implement.
30578 * enum.cs (Emit): Re-write parts to account for the underlying type
30579 better and perform checking etc.
30581 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30582 of the underlying type.
30584 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30587 * enum.cs (error31): Helper to report error #31.
30589 * cs-parser.jay (enum_declaration): Store location of each member too.
30591 * enum.cs (member_to_location): New hashtable.
30593 (AddEnumMember): Update location hashtable.
30595 (Emit): Use the location of each member while reporting errors.
30597 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30599 * cs-parser.jay: A for_initializer if is a
30600 local_variable_declaration really ammount to have an implicit
30601 block with the variable declaration and no initializer for for.
30603 * statement.cs (For.Emit): Cope with null initializers.
30605 This fixes the infinite loop on for initializers.
30607 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30609 * enum.cs: More cleanup.
30611 * ecore.cs: Remove dead code.
30613 * class.cs (Property.Emit): More simplification.
30614 (Event.Emit): ditto.
30616 Reworked to have less levels of indentation.
30618 2001-11-08 Ravi Pratap <ravi@ximian.com>
30620 * class.cs (Property): Emit attributes.
30630 * enum.cs (Emit): Ditto.
30632 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30635 * class.cs (Field, Event, etc.): Move attribute generation into the
30636 Emit method everywhere.
30638 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30639 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30640 as we had no way of defining nested enums !
30642 * rootcontext.cs : Adjust code accordingly.
30644 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30646 2001-11-07 Ravi Pratap <ravi@ximian.com>
30648 * expression.cs (EvalConstantExpression): Move into ecore.cs
30650 * enum.cs (Enum): Rename some members and make them public and readonly
30651 according to our convention.
30653 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30656 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30658 (Enum::Emit): Write a simple version for now which doesn't try to compute
30659 expressions. I shall modify this to be more robust in just a while.
30661 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30663 (TypeContainer::CloseType): Create the Enum types too.
30665 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30667 * expression.cs (EvalConstantExpression): Get rid of completely.
30669 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30670 user-defined values and other cases.
30672 (IsValidEnumLiteral): Helper function.
30674 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30675 out there in the case we had a literal FieldExpr.
30677 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30679 (Literalize): Revamp a bit to take two arguments.
30681 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30683 2001-11-06 Ravi Pratap <ravi@ximian.com>
30685 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30687 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30689 (Resolve): Use the above to ensure we have proper initializers.
30691 2001-11-05 Ravi Pratap <ravi@ximian.com>
30693 * expression.cs (Expression::EvalConstantExpression): New method to
30694 evaluate constant expressions.
30696 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30698 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30700 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30703 (Binary.ResolveOperator): Handle operator != (object a, object b)
30704 and operator == (object a, object b);
30706 (Binary.DoNumericPromotions): Indicate whether the numeric
30707 promotion was possible.
30709 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30712 Made the ArrayAccess implement interface IAssignMethod instead of
30713 IStackStore as the order in which arguments are passed reflects
30716 * assign.cs: Instead of using expr.ExprClass to select the way of
30717 assinging, probe for the IStackStore/IAssignMethod interfaces.
30719 * typemanager.cs: Load InitializeArray definition.
30721 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30722 static data that can be used to initialize arrays.
30724 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30726 * expression.cs: Handle operator== and operator!= for booleans.
30728 (Conditioal.Reduce): Implement reducer for the ?: operator.
30730 (Conditional.Resolve): Implement dead code elimination.
30732 (Binary.Resolve): Catch string literals and return a new
30733 concatenated string.
30735 (Unary.Reduce): Implement reduction of unary expressions.
30737 * ecore.cs: Split out the expression core handling here.
30739 (Expression.Reduce): New method used to perform constant folding
30740 and CSE. This is needed to support constant-expressions.
30742 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30743 targets, and optimize for !x.
30745 2001-11-04 Ravi Pratap <ravi@ximian.com>
30747 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30748 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30749 set custom atttributes.
30751 * literal.cs (Literal::GetValue): New abstract method to return the actual
30752 value of the literal, cast as an object.
30754 (*Literal): Implement GetValue method.
30756 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30757 expressions to the arraylist but objects of type Argument.
30759 * class.cs (TypeContainer::Emit): Emit our attributes too.
30761 (Method::Emit, Constructor::Emit): Ditto.
30763 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30764 to be ignoring earlier.
30766 2001-11-03 Ravi Pratap <ravi@ximian.com>
30768 * attribute.cs (AttributeSection::Define): Implement to do the business
30769 of constructing a CustomAttributeBuilder.
30771 (Attribute): New trivial class. Increases readability of code.
30773 * cs-parser.jay : Update accordingly.
30775 (positional_argument_list, named_argument_list, named_argument): New rules
30777 (attribute_arguments): Use the above so that we are more correct.
30779 2001-11-02 Ravi Pratap <ravi@ximian.com>
30781 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30782 to perform all checks for a method with a params parameter.
30784 (Invocation::OverloadResolve): Update to use the above method and therefore
30785 cope correctly with params method invocations.
30787 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30790 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30791 constructors in our parent too because we can't afford to miss out on
30794 * attribute.cs (AttributeSection): New name for the class Attribute
30796 Other trivial changes to improve readability.
30798 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30799 use the new class names.
30801 2001-11-01 Ravi Pratap <ravi@ximian.com>
30803 * class.cs (Method::Define): Complete definition for params types too
30805 (Indexer::Define): Ditto.
30807 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30808 Cope everywhere with a request for info about the array parameter.
30810 2001-11-01 Ravi Pratap <ravi@ximian.com>
30812 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30814 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30815 local_variable_type to extract the string corresponding to the type.
30817 (local_variable_type): Fixup the action to use the new helper method.
30819 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30822 * expression.cs : Clean out code which uses the above.
30824 2001-10-31 Ravi Pratap <ravi@ximian.com>
30826 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30827 and bale out if necessary by returning a false.
30829 (RegisterProperty): Ditto.
30831 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30832 and print out appropriate error messages.
30834 * interface.cs (everywhere): Ditto.
30836 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30837 location to constructor.
30839 * class.cs (Property, Event, Indexer): Update accordingly.
30841 * ../errors/cs111.cs : Added.
30843 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30844 of a method, as laid down by the spec.
30846 (Invocation::OverloadResolve): Use the above method.
30848 2001-10-31 Ravi Pratap <ravi@ximian.com>
30850 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30851 now take a TypeContainer and a Parameters object.
30853 (ParameterData): Modify return type of ParameterModifier method to be
30854 Parameter.Modifier and not a string.
30856 (ReflectionParameters, InternalParameters): Update accordingly.
30858 * expression.cs (Argument::GetParameterModifier): Same here.
30860 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30861 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30862 symbol in it at all so maybe this is only for now.
30864 2001-10-30 Ravi Pratap <ravi@ximian.com>
30866 * support.cs (InternalParameters): Constructor now takes an extra argument
30867 which is the actual Parameters class.
30869 (ParameterDesc): Update to provide info on ref/out modifiers.
30871 * class.cs (everywhere): Update call to InternalParameters to pass in
30872 the second argument too.
30874 * support.cs (ParameterData): Add ParameterModifier, which is a method
30875 to return the modifier info [ref/out etc]
30877 (InternalParameters, ReflectionParameters): Implement the above.
30879 * expression.cs (Argument::ParameterModifier): Similar function to return
30880 info about the argument's modifiers.
30882 (Invocation::OverloadResolve): Update to take into account matching modifiers
30885 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30886 a new SetFormalParameters object which we pass to InternalParameters.
30888 2001-10-30 Ravi Pratap <ravi@ximian.com>
30890 * expression.cs (NewArray): Merge into the ArrayCreation class.
30892 2001-10-29 Ravi Pratap <ravi@ximian.com>
30894 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30895 NewUserdefinedArray into one as there wasn't much of a use in having
30898 * expression.cs (Argument): Change field's name to ArgType from Type.
30900 (Type): New readonly property which returns the proper type, taking into
30901 account ref/out modifiers.
30903 (everywhere): Adjust code accordingly for the above.
30905 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30906 whether we are emitting for a ref or out parameter.
30908 * expression.cs (Argument::Emit): Use the above field to set the state.
30910 (LocalVariableReference::Emit): Update to honour the flag and emit the
30913 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30915 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30917 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30919 (ReflectionParameters, InternalParameters): Implement the above method.
30921 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30924 (Invocation::FullMethodDesc): Ditto.
30926 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30928 * cs-parser.jay: Add extra production for the second form of array
30931 * expression.cs (ArrayCreation): Update to reflect the above
30934 * Small changes to prepare for Array initialization.
30936 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30938 * typemanager.cs (ImplementsInterface): interface might be null;
30939 Deal with this problem;
30941 Also, we do store negative hits on the cache (null values), so use
30942 this instead of calling t.GetInterfaces on the type everytime.
30944 2001-10-28 Ravi Pratap <ravi@ximian.com>
30946 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30948 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30949 split functionality out into different classes.
30951 (New::FormArrayType): Move into NewBuiltinArray.
30953 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30956 (NewBuiltinArray): New class to handle creation of built-in arrays.
30958 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30959 account creation of one-dimensional arrays.
30961 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30963 (NewUserdefinedArray::DoResolve): Implement.
30965 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30967 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30968 we maintain inside the TypeManager. This is necessary to perform lookups on the
30971 (LookupType): Update to perform GetType on the module builders too.
30973 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30975 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30977 2001-10-23 Ravi Pratap <ravi@ximian.com>
30979 * expression.cs (New::DoResolve): Implement guts of array creation.
30981 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30983 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30985 * expression.cs: Fix bug I introduced lsat night that broke
30988 (Expression.Resolve): Report a 246 error (can not resolve name)
30989 if we find a SimpleName in the stream.
30991 (Expression.ResolveLValue): Ditto.
30993 (Expression.ResolveWithSimpleName): This function is a variant of
30994 ResolveName, this one allows SimpleNames to be returned without a
30995 warning. The only consumer of SimpleNames is MemberAccess
30997 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30999 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31000 might arrive here. I have my doubts that this is correct.
31002 * statement.cs (Lock): Implement lock statement.
31004 * cs-parser.jay: Small fixes to support `lock' and `using'
31006 * cs-tokenizer.cs: Remove extra space
31008 * driver.cs: New flag --checked, allows to turn on integer math
31011 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31012 Threading.Monitor.Exit
31014 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31016 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31017 Expression Class to be IndexerAccess.
31019 Notice that Indexer::DoResolve sets the eclass to Value.
31021 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31023 * class.cs (TypeContainer::Emit): Emit code for indexers.
31025 * assign.cs (IAssignMethod): New interface implemented by Indexers
31026 and Properties for handling assignment.
31028 (Assign::Emit): Simplify and reuse code.
31030 * expression.cs (IndexerAccess, PropertyExpr): Implement
31031 IAssignMethod, clean up old code.
31033 2001-10-22 Ravi Pratap <ravi@ximian.com>
31035 * typemanager.cs (ImplementsInterface): New method to determine if a type
31036 implements a given interface. Provides a nice cache too.
31038 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31041 (ConvertReferenceExplicit): Ditto.
31043 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31044 various methods, with correct names etc.
31046 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31047 Operator.UnaryNegation.
31049 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31050 we have a unary plus or minus operator.
31052 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31055 * everywhere : update accordingly.
31057 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31060 * class.cs (Method::Define): For the case where we are implementing a method
31061 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31062 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31064 2001-10-21 Ravi Pratap <ravi@ximian.com>
31066 * interface.cs (FindMembers): Implement to work around S.R.E
31069 * typemanager.cs (IsInterfaceType): Implement.
31071 (FindMembers): Update to handle interface types too.
31073 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31074 use IsAssignableFrom as that is not correct - it doesn't work.
31076 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31077 and accordingly override EmitStatement.
31079 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31080 using the correct logic :-)
31082 2001-10-19 Ravi Pratap <ravi@ximian.com>
31084 * ../errors/cs-11.cs : Add to demonstrate error -11
31086 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31088 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31089 then pass this as a hint to ResolveLValue.
31091 * expression.cs (FieldExpr): Add Location information
31093 (FieldExpr::LValueResolve): Report assignment to readonly
31096 (Expression::ExprClassFromMemberInfo): Pass location information.
31098 (Expression::ResolveLValue): Add new method that resolves an
31101 (Expression::DoResolveLValue): Default invocation calls
31104 (Indexers): New class used to keep track of indexers in a given
31107 (IStackStore): Renamed from LValue, as it did not really describe
31108 what this did. Also ResolveLValue is gone from this interface and
31109 now is part of Expression.
31111 (ElementAccess): Depending on the element access type
31113 * typemanager.cs: Add `indexer_name_type' as a Core type
31114 (System.Runtime.CompilerServices.IndexerNameAttribute)
31116 * statement.cs (Goto): Take a location.
31118 2001-10-18 Ravi Pratap <ravi@ximian.com>
31120 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31121 if two delegates are compatible.
31123 (NewDelegate::DoResolve): Update to take care of the case when
31124 we instantiate a delegate from another delegate.
31126 * typemanager.cs (FindMembers): Don't even try to look up members
31127 of Delegate types for now.
31129 2001-10-18 Ravi Pratap <ravi@ximian.com>
31131 * delegate.cs (NewDelegate): New class to take care of delegate
31134 * expression.cs (New): Split the delegate related code out into
31135 the NewDelegate class.
31137 * delegate.cs (DelegateInvocation): New class to handle delegate
31140 * expression.cs (Invocation): Split out delegate related code into
31141 the DelegateInvocation class.
31143 2001-10-17 Ravi Pratap <ravi@ximian.com>
31145 * expression.cs (New::DoResolve): Implement delegate creation fully
31146 and according to the spec.
31148 (New::DoEmit): Update to handle delegates differently.
31150 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31151 because of which we were printing out arguments in reverse order !
31153 * delegate.cs (VerifyMethod): Implement to check if the given method
31154 matches the delegate.
31156 (FullDelegateDesc): Implement.
31158 (VerifyApplicability): Implement.
31160 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31161 delegate invocations too.
31163 (Invocation::Emit): Ditto.
31165 * ../errors/cs1593.cs : Added.
31167 * ../errors/cs1594.cs : Added.
31169 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31171 2001-10-16 Ravi Pratap <ravi@ximian.com>
31173 * typemanager.cs (intptr_type): Core type for System.IntPtr
31175 (InitCoreTypes): Update for the same.
31177 (iasyncresult_type, asynccallback_type): Ditto.
31179 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31182 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31185 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31186 the builders for the 4 members of a delegate type :-)
31188 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31191 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31193 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31195 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31197 * statement.cs (Break::Emit): Implement.
31198 (Continue::Emit): Implement.
31200 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31201 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31202 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31203 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31206 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31207 properties that track the label for the current loop (begin of the
31208 loop and end of the loop).
31210 2001-10-15 Ravi Pratap <ravi@ximian.com>
31212 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31213 use of emitting anything at all.
31215 * class.cs, rootcontext.cs : Get rid of calls to the same.
31217 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31219 (Populate): Define the constructor correctly and set the implementation
31222 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31225 (AddDelegateType): Implement.
31227 (IsDelegateType): Implement helper method.
31229 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31231 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31232 and accordingly handle it.
31234 * delegate.cs (Populate): Take TypeContainer argument.
31235 Implement bits to define the Invoke method. However, I still haven't figured out
31236 how to take care of the native int bit :-(
31238 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31239 Qualify the name of the delegate, not its return type !
31241 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31244 (StandardConversionExists): Checking for array types turns out to be recursive.
31246 (ConvertReferenceExplicit): Implement array conversion.
31248 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31250 2001-10-12 Ravi Pratap <ravi@ximian.com>
31252 * cs-parser.jay (delegate_declaration): Store the fully qualified
31253 name as it is a type declaration.
31255 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31258 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31259 as TypeContainer::DefineType.
31261 (Populate): Method in which all the definition of the various methods (Invoke)
31264 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31267 (CloseDelegate): Finally creates the delegate.
31269 * class.cs (TypeContainer::DefineType): Update to define delegates.
31270 (Populate, Emit and CloseType): Do the same thing here too.
31272 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31273 delegates in all these operations.
31275 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31277 * expression.cs: LocalTemporary: a new expression used to
31278 reference a temporary that has been created.
31280 * assign.cs: Handle PropertyAccess back here, so that we can
31281 provide the proper semantic access to properties.
31283 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31284 a few more explicit conversions.
31286 * modifiers.cs: `NEW' modifier maps to HideBySig.
31288 * expression.cs (PropertyExpr): Make this into an
31289 ExpressionStatement, and support the EmitStatement code path.
31291 Perform get/set error checking, clean up the interface.
31293 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31294 them into toplevel access objects.
31296 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31298 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31301 * typemanager.cs: Keep track here of our PropertyBuilders again to
31302 work around lameness in SRE.
31304 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31306 * expression.cs (LValue::LValueResolve): New method in the
31307 interface, used to perform a second resolution pass for LValues.
31309 (This::DoResolve): Catch the use of this in static methods.
31311 (This::LValueResolve): Implement.
31313 (This::Store): Remove warning, assigning to `this' in structures
31316 (Invocation::Emit): Deal with invocation of
31317 methods on value types. We need to pass the address to structure
31318 methods rather than the object itself. (The equivalent code to
31319 emit "this" for structures leaves the entire structure on the
31320 stack instead of a pointer to it).
31322 (ParameterReference::DoResolve): Compute the real index for the
31323 argument based on whether the method takes or not a `this' pointer
31324 (ie, the method is static).
31326 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31327 value types returned from functions when we need to invoke a
31328 method on the sturcture.
31331 2001-10-11 Ravi Pratap <ravi@ximian.com>
31333 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31334 defining the type in the Modulebuilder or Typebuilder. This is to take
31335 care of nested types which need to be defined on the TypeBuilder using
31336 DefineNestedMethod.
31338 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31339 methods in RootContext, only ported to be part of TypeContainer.
31341 (TypeContainer::GetInterfaceOrClass): Ditto.
31343 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31345 * interface.cs (Interface::DefineInterface): New method. Does exactly
31346 what RootContext.CreateInterface did earlier, only it takes care of nested types
31349 (Interface::GetInterfaces): Move from RootContext here and port.
31351 (Interface::GetInterfaceByName): Same here.
31353 * rootcontext.cs (ResolveTree): Re-write.
31355 (PopulateTypes): Re-write.
31357 * class.cs (TypeContainer::Populate): Populate nested types too.
31358 (TypeContainer::Emit): Emit nested members too.
31360 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31361 instead just use the name argument passed in as it is already fully
31364 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31365 to TypeContainer mapping to see if a type is user-defined.
31367 * class.cs (TypeContainer::CloseType): Implement.
31369 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31370 the default constructor.
31372 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31375 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31377 * interface.cs (CloseType): Create the type here.
31379 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31382 Remove all the methods which are now in TypeContainer.
31384 2001-10-10 Ravi Pratap <ravi@ximian.com>
31386 * delegate.cs (Define): Re-write bits to define the delegate
31389 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31391 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31393 * expression.cs (ImplicitReferenceConversion): handle null as well
31394 as a source to convert to any reference type.
31396 * statement.cs (Return): Perform any implicit conversions to
31397 expected return type.
31399 Validate use of return statement.
31401 * codegen.cs (EmitContext): Pass the expected return type here.
31403 * class.cs (Method, Constructor, Property): Pass expected return
31404 type to EmitContext.
31406 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31408 * expression.cs: Make DoResolve take an EmitContext instead of a
31411 Replaced `l' and `location' for `loc', for consistency.
31413 (Error, Warning): Remove unneeded Tc argument.
31415 * assign.cs, literal.cs, constant.cs: Update to new calling
31418 * codegen.cs: EmitContext now contains a flag indicating whether
31419 code is being generated in a static method or not.
31421 * cs-parser.jay: DecomposeQI, new function that replaces the old
31422 QualifiedIdentifier. Now we always decompose the assembled
31423 strings from qualified_identifier productions into a group of
31426 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31428 * rootcontext.cs: Deal with field-less struct types correctly now
31429 by passing the size option to Define Type.
31431 * class.cs: Removed hack that created one static field.
31433 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31435 * statement.cs: Moved most of the code generation here.
31437 2001-10-09 Ravi Pratap <ravi@ximian.com>
31439 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31442 (ElementAccess): Remove useless bits for now - keep checks as the spec
31445 2001-10-08 Ravi Pratap <ravi@ximian.com>
31447 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31448 and start performing checks according to the spec.
31450 2001-10-07 Ravi Pratap <ravi@ximian.com>
31452 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31453 rank_specifiers instead.
31455 (rank_specifiers): Change the order in which the rank specifiers are stored
31457 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31459 * expression.cs (ElementAccess): Implement the LValue interface too.
31461 2001-10-06 Ravi Pratap <ravi@ximian.com>
31463 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31464 except that user defined conversions are not included.
31466 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31467 perform the conversion of the return type, if necessary.
31469 (New::DoResolve): Check whether we are creating an array or an object
31470 and accordingly do the needful.
31472 (New::Emit): Same here.
31474 (New::DoResolve): Implement guts of array creation.
31476 (New::FormLookupType): Helper function.
31478 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31480 * codegen.cs: Removed most of the code generation here, and move the
31481 corresponding code generation bits to the statement classes.
31483 Added support for try/catch/finalize and throw.
31485 * cs-parser.jay: Added support for try/catch/finalize.
31487 * class.cs: Catch static methods having the flags override,
31488 virtual or abstract.
31490 * expression.cs (UserCast): This user cast was not really doing
31491 what it was supposed to do. Which is to be born in fully resolved
31492 state. Parts of the resolution were being performed at Emit time!
31496 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31498 * expression.cs: Implicity convert the result from UserCast.
31500 2001-10-05 Ravi Pratap <ravi@ximian.com>
31502 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31503 prevented it from working correctly.
31505 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31506 merely ConvertImplicit.
31508 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31510 * typemanager.cs: Make the LookupTypeContainer function static,
31511 and not per-instance.
31513 * class.cs: Make static FindMembers (the one that takes a Type
31516 * codegen.cs: Add EmitForeach here.
31518 * cs-parser.jay: Make foreach a toplevel object instead of the
31519 inline expansion, as we need to perform semantic analysis on it.
31521 2001-10-05 Ravi Pratap <ravi@ximian.com>
31523 * expression.cs (Expression::ImplicitUserConversion): Rename to
31524 UserDefinedConversion.
31526 (Expression::UserDefinedConversion): Take an extra argument specifying
31527 whether we look for explicit user conversions too.
31529 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31531 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31533 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31534 with the appropriate arguments.
31536 * cs-parser.jay (cast_expression): Record location too.
31538 * expression.cs (Cast): Record location info.
31540 (Expression::ConvertExplicit): Take location argument.
31542 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31543 to determine if we are doing explicit conversions.
31545 (UserCast::Emit): Update accordingly.
31547 (Expression::ConvertExplicit): Report an error if everything fails.
31549 * ../errors/cs0030.cs : Add.
31551 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31553 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31554 virtual and newslot bits.
31556 * class.cs (TypeContainer::RegisterRequiredImplementations):
31557 Record methods we need.
31559 (TypeContainer::MakeKey): Helper function to make keys for
31560 MethodBases, since the Methodbase key is useless.
31562 (TypeContainer::Populate): Call RegisterRequiredImplementations
31563 before defining the methods.
31565 Create a mapping for method_builders_to_methods ahead of time
31566 instead of inside a tight loop.
31568 (::RequireMethods): Accept an object as the data to set into the
31569 hashtable so we can report interface vs abstract method mismatch.
31571 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31573 * report.cs: Make all of it static.
31575 * rootcontext.cs: Drop object_type and value_type computations, as
31576 we have those in the TypeManager anyways.
31578 Drop report instance variable too, now it is a global.
31580 * driver.cs: Use try/catch on command line handling.
31582 Add --probe option to debug the error reporting system with a test
31585 * report.cs: Add support for exiting program when a probe
31586 condition is reached.
31588 2001-10-03 Ravi Pratap <ravi@ximian.com>
31590 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31591 we do a forcible conversion regardless of type, to check if
31592 ForceConversion returns a null.
31594 (Binary::error19): Use location to report error.
31596 (Unary::error23): Use location here too.
31598 * ../errors/cs0019.cs : Check in.
31600 * ../errors/cs0023.cs : Check in.
31602 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31603 case of a non-null MethodInfo object with a length of 0 !
31605 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31606 an applicable member - according to the spec :-)
31607 Also fix logic to find members in base types.
31609 (Unary::ResolveOperator): Same here.
31611 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31612 as I was getting thoroughly confused between this and error19 :-)
31614 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31615 (::FindMostEncompassedType): Implement.
31616 (::FindMostEncompassingType): Implement.
31617 (::StandardConversionExists): Implement.
31619 (UserImplicitCast): Re-vamp. We now need info about most specific
31620 source and target types so that we can do the necessary conversions.
31622 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31623 mathematical union with no duplicates.
31625 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31627 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31628 in order from base classes to child classes, so that we can in
31629 child classes look up in our parent for method names and
31630 attributes (required for handling abstract, virtual, new, override
31631 constructs: we need to instrospect our base class, and if we dont
31632 populate the classes in order, the introspection might be
31633 incorrect. For example, a method could query its parent before
31634 the parent has any methods and would determine that the parent has
31635 no abstract methods (while it could have had them)).
31637 (RootContext::CreateType): Record the order in which we define the
31640 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31642 * class.cs (TypeContainer::Populate): Also method definitions can
31643 fail now, keep track of this.
31645 (TypeContainer::FindMembers): Implement support for
31646 DeclaredOnly/noDeclaredOnly flag.
31648 (Constructor::Emit) Return the ConstructorBuilder.
31650 (Method::Emit) Return the MethodBuilder.
31651 Check for abstract or virtual methods to be public.
31653 * rootcontext.cs (RootContext::CreateType): Register all the
31654 abstract methods required for the class to be complete and the
31655 interface methods that must be implemented.
31657 * cs-parser.jay: Report error 501 (method requires body if it is
31658 not marked abstract or extern).
31660 * expression.cs (TypeOf::Emit): Implement.
31662 * typemanager.cs: runtime_handle_type, new global type.
31664 * class.cs (Property::Emit): Generate code for properties.
31666 2001-10-02 Ravi Pratap <ravi@ximian.com>
31668 * expression.cs (Unary::ResolveOperator): Find operators on base type
31669 too - we now conform exactly to the spec.
31671 (Binary::ResolveOperator): Same here.
31673 * class.cs (Operator::Define): Fix minor quirk in the tests.
31675 * ../errors/cs0215.cs : Added.
31677 * ../errors/cs0556.cs : Added.
31679 * ../errors/cs0555.cs : Added.
31681 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31683 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31684 single integer which is really efficient
31686 2001-10-01 Ravi Pratap <ravi@ximian.com>
31688 * expression.cs (Expression::ImplicitUserConversion): Use location
31689 even in the case when we are examining True operators.
31691 * class.cs (Operator::Define): Perform extensive checks to conform
31692 with the rules for operator overloading in the spec.
31694 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31695 some of the other conversions mentioned in the spec.
31697 * typemanager.cs (array_type): New static member for the System.Array built-in
31700 (cloneable_interface): For System.ICloneable interface.
31702 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31703 we start resolving the tree and populating types.
31705 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31707 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31709 * expression.cs (Expression::ExprClassFromMemberInfo,
31710 Expression::Literalize): Create literal expressions from
31711 FieldInfos which are literals.
31713 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31714 type casts, because they were wrong. The test suite in tests
31717 (ImplicitNumericConversion): ushort to ulong requires a widening
31720 Int32 constant to long requires widening cast as well.
31722 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31723 for integers because the type on the stack is not i4.
31725 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31727 * expression.cs (report118): require location argument.
31729 * parameter.cs: Do not dereference potential null value.
31731 * class.cs: Catch methods that lack the `new' keyword when
31732 overriding a name. Report warnings when `new' is used without
31733 anything being there to override.
31735 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31737 * class.cs: Only add constructor to hashtable if it is non-null
31738 (as now constructors can fail on define).
31740 (TypeManager, Class, Struct): Take location arguments.
31742 Catch field instance initialization in structs as errors.
31744 accepting_filter: a new filter for FindMembers that is static so
31745 that we dont create an instance per invocation.
31747 (Constructor::Define): Catch errors where a struct constructor is
31750 * cs-parser.jay: Pass location information for various new
31753 * delegate.cs (Delegate): take a location argument.
31755 * driver.cs: Do not call EmitCode if there were problesm in the
31756 Definition of the types, as many Builders wont be there.
31758 * decl.cs (Decl::Decl): Require a location argument.
31760 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31761 into integers, and find the most appropiate integer for it.
31763 * literal.cs: Implement ULongLiteral.
31765 * rootcontext.cs: Provide better information about the location of
31766 failure when CreateType fails.
31768 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31770 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31773 * expression.cs (Binary::CheckShiftArguments): Add missing type
31775 (Binary::ResolveOperator): Add type to the logical and and logical
31776 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31779 (Binary::DoNumericPromotions): In the case where either argument
31780 is ulong (and most signed types combined with ulong cause an
31781 error) perform implicit integer constant conversions as well.
31783 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31785 * expression.cs (UserImplicitCast): Method should always be
31787 (Invocation::BetterConversion): Simplified test for IntLiteral.
31789 (Expression::ImplicitNumericConversion): Split this routine out.
31790 Put the code that performs implicit constant integer conversions
31793 (Expression::Resolve): Become a wrapper around DoResolve so we can
31794 check eclass and type being set after resolve.
31796 (Invocation::Badness): Remove this dead function
31798 (Binary::ResolveOperator): Do not compute the expensive argumnets
31799 unless we have a union for it.
31801 (Probe::Emit): Is needs to do an isinst and then
31802 compare against null.
31804 (::CanConvert): Added Location argument. If the Location argument
31805 is null (Location.Null), then we do not report errors. This is
31806 used by the `probe' mechanism of the Explicit conversion. We do
31807 not want to generate an error for something that the user
31808 explicitly requested to be casted. But the pipeline for an
31809 explicit cast first tests for potential implicit casts.
31811 So for now, if the Location is null, it means `Probe only' to
31812 avoid adding another argument. Might have to revise this
31815 (ClassCast): New class used to type cast objects into arbitrary
31816 classes (used in Explicit Reference Conversions).
31818 Implement `as' as well.
31820 Reverted all the patches from Ravi below: they were broken:
31822 * The use of `level' as a mechanism to stop recursive
31823 invocations is wrong. That was there just to catch the
31824 bug with a strack trace but not as a way of addressing
31827 To fix the problem we have to *understand* what is going
31828 on and the interactions and come up with a plan, not
31829 just get things going.
31831 * The use of the type conversion cache that I proposed
31832 last night had an open topic: How does this work across
31833 protection domains. A user defined conversion might not
31834 be public in the location where we are applying the
31835 conversion, a different conversion might be selected
31836 (ie, private A->B (better) but public B->A (worse),
31837 inside A, A->B applies, but outside it, B->A will
31840 * On top of that (ie, even if the above is solved),
31841 conversions in a cache need to be abstract. Ie, `To
31842 convert from an Int to a Short use an OpcodeCast', not
31843 `To convert from an Int to a Short use the OpcodeCast on
31844 the variable 5' (which is what this patch was doing).
31846 2001-09-28 Ravi Pratap <ravi@ximian.com>
31848 * expression.cs (Invocation::ConversionExists): Re-write to use
31849 the conversion cache
31851 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31852 cache all conversions done, not just user-defined ones.
31854 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31855 to determine if a conversion exists instead of acutually trying to
31856 perform the conversion. It's faster too.
31858 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31859 and only then attempt the implicit conversion.
31861 2001-09-28 Ravi Pratap <ravi@ximian.com>
31863 * expression.cs (ConvertImplicit): Use a cache for conversions
31864 already found. Check level of recursion and bail out if necessary.
31866 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31868 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31869 Export standard methods that we expect for string operations.
31871 * statement.cs (Block::UsageWarning): Track usage of variables and
31872 report the errors for not used variables.
31874 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31877 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31879 * codegen.cs: remove unnneded code
31881 * expression.cs: Removed BuiltinTypeAccess class
31883 Fix the order in which implicit conversions are
31886 The previous fixed dropped support for boxed conversions (adding a
31887 test to the test suite now)
31889 (UserImplicitCast::CanConvert): Remove test for source being null,
31890 that code is broken. We should not feed a null to begin with, if
31891 we do, then we should track the bug where the problem originates
31892 and not try to cover it up here.
31894 Return a resolved expression of type UserImplicitCast on success
31895 rather than true/false. Ravi: this is what I was talking about,
31896 the pattern is to use a static method as a "constructor" for
31899 Also, do not create arguments until the very last minute,
31900 otherwise we always create the arguments even for lookups that
31901 will never be performed.
31903 (UserImplicitCast::Resolve): Eliminate, objects of type
31904 UserImplicitCast are born in a fully resolved state.
31906 * typemanager.cs (InitCoreTypes): Init also value_type
31907 (System.ValueType).
31909 * expression.cs (Cast::Resolve): First resolve the child expression.
31911 (LValue): Add new method AddressOf to be used by
31914 Change the argument of Store to take an EmitContext instead of an
31915 ILGenerator, because things like FieldExpr need to be able to call
31916 their children expression to generate the instance code.
31918 (Expression::Error, Expression::Warning): Sugar functions for
31921 (Expression::MemberLookup): Accept a TypeContainer instead of a
31922 Report as the first argument.
31924 (Expression::ResolvePrimary): Killed. I still want to improve
31925 this as currently the code is just not right.
31927 (Expression::ResolveMemberAccess): Simplify, but it is still
31930 (Unary::Resolve): Catch errors in AddressOf operators.
31932 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31933 index to a byte for the short-version, or the compiler will choose
31934 the wrong Emit call, which generates the wrong data.
31936 (ParameterReference::Emit, ::Store): same.
31938 (FieldExpr::AddressOf): Implement.
31940 * typemanager.cs: TypeManager: made public variable instead of
31943 * driver.cs: document --fatal.
31945 * report.cs (ErrorMessage, WarningMessage): new names for the old
31946 Error and Warning classes.
31948 * cs-parser.jay (member_access): Turn built-in access to types
31949 into a normal simplename
31951 2001-09-27 Ravi Pratap <ravi@ximian.com>
31953 * expression.cs (Invocation::BetterConversion): Fix to cope
31954 with q being null, since this was introducing a bug.
31956 * expression.cs (ConvertImplicit): Do built-in conversions first.
31958 2001-09-27 Ravi Pratap <ravi@ximian.com>
31960 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31962 2001-09-27 Ravi Pratap <ravi@ximian.com>
31964 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31965 I had introduced long ago (what's new ?).
31967 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31968 the work of all the checking.
31969 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31970 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31972 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31973 that is the right way.
31975 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31976 overloading resolution. Use everywhere instead of cutting and pasting code.
31978 (Binary::ResolveOperator): Use MakeUnionSet.
31980 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31981 we have to convert to bool types. Not complete yet.
31983 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31985 * typemanager.cs (TypeManager::CSharpName): support ushort.
31987 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31988 to provide an expression that performsn an implicit constant int
31989 conversion (section 6.1.6).
31990 (Expression::ConvertImplicitRequired): Reworked to include
31991 implicit constant expression conversions.
31993 (Expression::ConvertNumericExplicit): Finished.
31995 (Invocation::Emit): If InstanceExpression is null, then it means
31996 that we perform a call on this.
31998 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32000 * expression.cs (Unary::Emit): Remove some dead code.
32001 (Probe): Implement Resolve and Emit for `is'.
32002 (Expression::ConvertImplicitRequired): Attempt to do constant
32003 expression conversions here. Maybe should be moved to
32004 ConvertImplicit, but I am not sure.
32005 (Expression::ImplicitLongConstantConversionPossible,
32006 Expression::ImplicitIntConstantConversionPossible): New functions
32007 that tell whether is it possible to apply an implicit constant
32008 expression conversion.
32010 (ConvertNumericExplicit): Started work on explicit numeric
32013 * cs-parser.jay: Update operator constants.
32015 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32016 (Parameters::GetSignature): Hook up VerifyArgs here.
32017 (Parameters::VerifyArgs): Verifies that no two arguments have the
32020 * class.cs (Operator): Update the operator names to reflect the
32021 ones that the spec expects (as we are just stringizing the
32024 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32025 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32026 previous usage did only work for our methods.
32027 (Expression::ConvertImplicit): Handle decimal implicit numeric
32028 conversions as well.
32029 (Expression::InternalTypeConstructor): Used to invoke constructors
32030 on internal types for default promotions.
32032 (Unary::Emit): Implement special handling for the pre/post
32033 increment/decrement for overloaded operators, as they need to have
32034 the same semantics as the other operators.
32036 (Binary::ResolveOperator): ditto.
32037 (Invocation::ConversionExists): ditto.
32038 (UserImplicitCast::Resolve): ditto.
32040 2001-09-26 Ravi Pratap <ravi@ximian.com>
32042 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32043 operator, return after emitting body. Regression tests pass again !
32045 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32046 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32047 (Invocation::OverloadResolve): Ditto.
32048 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32050 * everywhere : update calls to the above methods accordingly.
32052 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32054 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32056 * expression.cs (ExpressionStatement): New base class used for
32057 expressions that can appear in statements, so that we can provide
32058 an alternate path to generate expression that do not leave a value
32061 (Expression::Emit, and all the derivatives): We no longer return
32062 whether a value is left on the stack or not. Every expression
32063 after being emitted leaves a single value on the stack.
32065 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32066 facilties of ExpressionStatement if possible.
32068 * cs-parser.jay: Update statement_expression.
32070 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32072 * driver.cs: Change the wording of message
32074 2001-09-25 Ravi Pratap <ravi@ximian.com>
32076 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32077 the type of the expression to the return type of the method if
32078 we have an overloaded operator match ! The regression tests pass again !
32079 (Unary::ResolveOperator): Ditto.
32081 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32082 to find "op_Implicit", not "implicit" ;-)
32083 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32084 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32086 * everywhere : Correct calls to the above accordingly.
32088 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32089 (ConvertImplicit): Do user-defined conversion if it exists.
32091 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32093 * assign.cs: track location.
32094 (Resolve): Use implicit conversions on assignment.
32096 * literal.cs: Oops. Not good, Emit of short access values should
32097 pass (Bytes) or the wrong argument will be selected.
32099 * expression.cs (Unary::Emit): Emit code for -expr.
32101 (Unary::ResolveOperator): Handle `Substract' for non-constants
32102 (substract from zero from the non-constants).
32103 Deal with Doubles as well.
32105 (Expression::ConvertImplicitRequired): New routine that reports an
32106 error if no implicit conversion exists.
32108 (Invocation::OverloadResolve): Store the converted implicit
32109 expressions if we make them
32111 2001-09-24 Ravi Pratap <ravi@ximian.com>
32113 * class.cs (ConstructorInitializer): Take a Location argument.
32114 (ConstructorBaseInitializer): Same here.
32115 (ConstructorThisInitializer): Same here.
32117 * cs-parser.jay : Update all calls accordingly.
32119 * expression.cs (Unary, Binary, New): Take location argument.
32120 Update accordingly everywhere.
32122 * cs-parser.jay : Update all calls to the above to take a location
32125 * class.cs : Ditto.
32127 2001-09-24 Ravi Pratap <ravi@ximian.com>
32129 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32130 (Invocation::BetterConversion): Same here
32131 (Invocation::ConversionExists): Ditto.
32133 (Invocation::ConversionExists): Implement.
32135 2001-09-22 Ravi Pratap <ravi@ximian.com>
32137 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32138 Also take an additional TypeContainer argument.
32140 * All over : Pass in TypeContainer as argument to OverloadResolve.
32142 * typemanager.cs (CSharpName): Update to check for the string type and return
32145 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32148 2001-09-21 Ravi Pratap <ravi@ximian.com>
32150 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32151 (Invocation::BetterFunction): Implement.
32152 (Invocation::BetterConversion): Implement.
32153 (Invocation::ConversionExists): Skeleton, no implementation yet.
32155 Okay, things work fine !
32157 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32159 * typemanager.cs: declare and load enum_type, delegate_type and
32162 * expression.cs (Expression::Emit): Now emit returns a value that
32163 tells whether a value is left on the stack or not. This strategy
32164 might be reveted tomorrow with a mechanism that would address
32165 multiple assignments.
32166 (Expression::report118): Utility routine to report mismatches on
32169 (Unary::Report23): Report impossible type/operator combination
32172 (Unary::IsIncrementableNumber): Whether the type can be
32173 incremented or decremented with add.
32174 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32176 (Unary::ResolveOperator): Implement ++, !, ~,
32178 (Invocation::Emit): Deal with new Emit convetion.
32180 * All Expression derivatives: Updated their Emit method to return
32181 whether they leave values on the stack or not.
32183 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32184 stack for expressions that are statements.
32186 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32188 * expression.cs (LValue): New interface. Must be implemented by
32190 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32193 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32194 interface for generating code, simplifies the code.
32196 2001-09-20 Ravi Pratap <ravi@ximian.com>
32198 * expression.cs (everywhere): Comment out return statements in ::Resolve
32199 methods to avoid the warnings.
32201 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32203 * driver.cs (parse): Report error 2001 if we can not open the
32206 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32209 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32212 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32213 otherwise nested blocks end up with the same index.
32215 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32217 * expression.cs: Instead of having FIXMEs in the Resolve
32218 functions, throw exceptions so it is obvious that we are facing a
32221 * cs-parser.jay (invocation_expression): Pass Location information.
32223 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32224 Use a basename for those routines because .NET does not like paths
32227 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32230 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32232 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32233 are loading the correct data types (throws an exception if not).
32234 (TypeManager::InitCoreTypes): Use CoreLookupType
32236 * expression.cs (Unary::ResolveOperator): return the child
32237 expression for expressions which are just +expr.
32238 (Unary::ResolveOperator): Return negative literals for -LITERAL
32239 expressions (otherwise they are Unary {Literal}).
32240 (Invocation::Badness): Take into account `Implicit constant
32241 expression conversions'.
32243 * literal.cs (LongLiteral): Implement long literal class.
32244 (IntLiteral): export the `Value' of the intliteral.
32246 2001-09-19 Ravi Pratap <ravi@ximian.com>
32248 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32250 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32251 instead of 'Operator'
32253 * expression.cs (Binary::ResolveOperator): Update accordingly.
32254 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32257 * cs-parser.jay (unary_expression): Update to use the new names.
32259 * gen-treedump.cs (GetUnary): Same here.
32261 * expression.cs (Unary::Resolve): Implement.
32262 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32263 operators are found instead of making noise ;-)
32264 (Unary::ResolveOperator): New method to do precisely the same thing which
32265 Binary::ResolveOperator does for Binary expressions.
32266 (Unary.method, .Arguments): Add.
32267 (Unary::OperName): Implement.
32268 (Unary::ForceConversion): Copy and Paste !
32270 * class.cs (Operator::Define): Fix a small bug for the case when we have
32273 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32274 for the inbuilt operators. Only overloading works for now ;-)
32276 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32278 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32279 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32281 * expression.cs (This::Emit): Implement.
32282 (This::Resolve): Implement.
32283 (TypeOf:Resolve): Implement.
32284 (Expression::ResolveSimpleName): Add an implicit this to instance
32286 (MemberAccess::Resolve): Deal with Parameters and Fields.
32287 Bind instance variable to Field expressions.
32288 (FieldExpr::Instance): New field used to track the expression that
32289 represents the object instance.
32290 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32292 (FieldExpr::Emit): Implement.
32294 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32295 the last instruction contains a return opcode to avoid generating
32296 the last `ret' instruction (this generates correct code, and it is
32297 nice to pass the peverify output).
32299 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32300 initializer for static and instance variables.
32301 (Constructor::Emit): Allow initializer to be null in the case of
32302 static constructors. Only emit initializer for instance
32305 (TypeContainer::FindMembers): Return a null array if there are no
32308 Also fix the code for the MemberTypes.Method branch, as it was not
32309 scanning that for operators (or tried to access null variables before).
32311 * assign.cs (Assign::Emit): Handle instance and static fields.
32315 * driver.cs: Stop compilation if there are parse errors.
32317 * cs-parser.jay (constructor_declaration): Provide default base
32318 initializer for non-static constructors.
32319 (constructor_declarator): Do not provide a default base
32320 initializers if none was specified.
32321 Catch the fact that constructors should not have parameters.
32323 * class.cs: Do not emit parent class initializers for static
32324 constructors, that should be flagged as an error.
32326 2001-09-18 Ravi Pratap <ravi@ximian.com>
32328 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32329 Move back code into TypeContainer::Populate.
32331 2001-09-18 Ravi Pratap <ravi@ximian.com>
32333 * class.cs (TypeContainer::AddConstructor): Fix the check to
32334 compare against Name, not Basename.
32335 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32337 * cs-parser.jay : Update accordingly.
32339 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32340 for methods, don't forget to look into the operators too.
32341 (RegisterMethodBuilder): Helper method to take care of this for
32342 methods, constructors and operators.
32343 (Operator::Define): Completely revamp.
32344 (Operator.OperatorMethod, MethodName): New fields.
32345 (TypeContainer::Populate): Move the registering of builders into
32346 RegisterMethodBuilder.
32347 (Operator::Emit): Re-write.
32349 * expression.cs (Binary::Emit): Comment out code path to emit method
32350 invocation stuff for the case when we have a user defined operator. I am
32351 just not able to get it right !
32353 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32355 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32358 (Expression::MemberLookup): Provide a version that allows to
32359 specify the MemberTypes and BindingFlags.
32361 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32362 so it was not fetching variable information from outer blocks.
32364 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32365 Beforefieldinit as it was buggy.
32367 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32368 that Ravi put here.
32370 * class.cs (Constructor::Emit): Only emit if block is not null.
32371 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32372 deal with this by semantically definining it as if the user had
32375 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32376 constructors as we now "emit" them at a higher level.
32378 (TypeContainer::DefineDefaultConstructor): Used to define the
32379 default constructors if none was provided.
32381 (ConstructorInitializer): Add methods Resolve and Emit.
32383 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32385 2001-09-17 Ravi Pratap <ravi@ximian.com>
32387 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32388 the default constructor builder with our hashtable for methodbuilders
32391 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32392 and argument_count is 0 in which case we have a match.
32393 (Binary::ResolveOperator): More null checking and miscellaneous coding
32396 2001-09-17 Ravi Pratap <ravi@ximian.com>
32398 * rootcontext.cs (IsNameSpace): Compare against null.
32400 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32402 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32403 and Unary::Operator.
32405 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32408 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32409 we have overloaded operators.
32410 (Binary::ResolveOperator): Implement the part which does the operator overload
32413 * class.cs (Operator::Emit): Implement.
32414 (TypeContainer::Emit): Emit the operators we have too.
32416 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32417 the case when we have a user-defined operator.
32419 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32421 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32423 2001-09-16 Ravi Pratap <ravi@ximian.com>
32425 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32426 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32427 (Constructor::Emit): Implement.
32428 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32429 if we have no work to do.
32430 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32433 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32434 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32436 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32439 2001-09-15 Ravi Pratap <ravi@ximian.com>
32441 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32443 (Tree::RecordNamespace): Method to do what the name says ;-)
32444 (Tree::Namespaces): Property to get at the namespaces hashtable.
32446 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32449 * rootcontext.cs (IsNamespace): Fixed it :-)
32451 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32453 * class.cs (TypeContainer::FindMembers): Add support for
32455 (MethodCore): New class that encapsulates both the shared aspects
32456 of a Constructor and a Method.
32457 (Method, Constructor): Factored pieces into MethodCore.
32459 * driver.cs: Added --fatal which makes errors throw exceptions.
32460 Load System assembly as well as part of the standard library.
32462 * report.cs: Allow throwing exceptions on errors for debugging.
32464 * modifiers.cs: Do not use `parent', instead use the real type
32465 container to evaluate permission settings.
32467 * class.cs: Put Ravi's patch back in. He is right, and we will
32468 have to cope with the
32470 2001-09-14 Ravi Pratap <ravi@ximian.com>
32472 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32473 FamORAssem, not FamANDAssem.
32475 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32477 * driver.cs: Added --parse option that only parses its input files
32480 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32481 incorrect. IsTopLevel is not used to tell whether an object is
32482 root_types or not (that can be achieved by testing this ==
32483 root_types). But to see if this is a top-level *class* (not
32484 necessarly our "toplevel" container).
32486 2001-09-14 Ravi Pratap <ravi@ximian.com>
32488 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32489 parent instead of a direct call to GetType.
32491 2001-09-14 Ravi Pratap <ravi@ximian.com>
32493 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32494 Modifiers.TypeAttr. This should just be a call to that method.
32496 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32497 object so that we can determine if we are top-level or not.
32499 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32502 * enum.cs (Enum::Define): Ditto.
32504 * modifiers.cs (FieldAttr): Re-write.
32506 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32507 (TypeContainer::HaveStaticConstructor): New property to provide access
32508 to precisely that info.
32510 * modifiers.cs (MethodAttr): Re-write.
32511 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32513 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32514 of top-level types as claimed.
32516 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32518 * expression.cs (MemberLookup): Fruitless attempt to lookup
32519 constructors. Maybe I need to emit default constructors? That
32520 might be it (currently .NET emits this for me automatically).
32521 (Invocation::OverloadResolve): Cope with Arguments == null.
32522 (Invocation::EmitArguments): new function, shared by the new
32523 constructor and us.
32524 (Invocation::Emit): Handle static and instance methods. Emit
32525 proper call instruction for virtual or non-virtual invocations.
32526 (New::Emit): Implement.
32527 (New::Resolve): Implement.
32528 (MemberAccess:Resolve): Implement.
32529 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32530 to track instances.
32531 (FieldExpr::Resolve): Set type.
32533 * support.cs: Handle empty arguments.
32535 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32536 SimpleLookup): Auxiliary routines to help parse a qualifier
32539 Update qualifier_identifier rule.
32541 * codegen.cs: Removed debugging messages.
32543 * class.cs: Make this a global thing, this acts just as a "key" to
32544 objects that we might have around.
32546 (Populate): Only initialize method_builders_to_methods once.
32548 * expression.cs (PropertyExpr): Initialize type from the
32551 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32552 Resolve pattern. Attempt to implicitly convert value to boolean.
32555 * expression.cs: Set the type for the int32/int32 argument case.
32556 (Binary::ResolveOperator): Set the return type to boolean for
32557 comparission operators
32559 * typemanager.cs: Remove debugging print code.
32561 (Invocation::Resolve): resolve type.
32563 * class.cs: Allocate a MemberInfo of the correct size, as the code
32564 elsewhere depends on the test to reflect the correct contents.
32566 (Method::) Keep track of parameters, due to System.Reflection holes
32568 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32571 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32572 of the exact size and return that.
32574 (Class::LookupMethodByBuilder): New function that maps
32575 MethodBuilders to its methods. Required to locate the information
32576 on methods because System.Reflection bit us again.
32578 * support.cs: New file, contains an interface ParameterData and
32579 two implementations: ReflectionParameters and InternalParameters
32580 used to access Parameter information. We will need to grow this
32583 * expression.cs (Invocation::GetParameterData): implement a cache
32584 and a wrapper around the ParameterData creation for methods.
32585 (Invocation::OverloadResolve): Use new code.
32587 2001-09-13 Ravi Pratap <ravi@ximian.com>
32589 * class.cs (TypeContainer::EmitField): Remove and move into
32590 (Field::Define): here and modify accordingly.
32591 (Field.FieldBuilder): New member.
32592 (TypeContainer::Populate): Update accordingly.
32593 (TypeContainer::FindMembers): Implement.
32595 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32597 * statement.cs: (VariableInfo::VariableType): New field to be
32598 initialized with the full type once it is resolved.
32600 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32602 * parameter.cs (GetParameterInfo): Use a type cache to compute
32603 things only once, and to reuse this information
32605 * expression.cs (LocalVariableReference::Emit): Implement.
32606 (OpcodeCast::Emit): fix.
32608 (ParameterReference::Resolve): Implement.
32609 (ParameterReference::Emit): Implement.
32611 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32612 that are expressions need to stay as Expressions.
32614 * typemanager.cs (CSharpName): Returns the C# name of a type if
32617 * expression.cs (Expression::ConvertImplicit): New function that
32618 implements implicit type conversions.
32620 (Expression::ImplicitReferenceConversion): Implements implicit
32621 reference conversions.
32623 (EmptyCast): New type for transparent casts.
32625 (OpcodeCast): New type for casts of types that are performed with
32626 a sequence of bytecodes.
32628 (BoxedCast): New type used for casting value types into reference
32629 types. Emits a box opcode.
32631 (Binary::DoNumericPromotions): Implements numeric promotions of
32632 and computation of the Binary::Type.
32634 (Binary::EmitBranchable): Optimization.
32636 (Binary::Emit): Implement code emission for expressions.
32638 * typemanager.cs (TypeManager): Added two new core types: sbyte
32641 2001-09-12 Ravi Pratap <ravi@ximian.com>
32643 * class.cs (TypeContainer::FindMembers): Method which does exactly
32644 what Type.FindMembers does, only we don't have to use reflection. No
32645 implementation yet.
32647 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32648 typecontainer objects as we need to get at them.
32649 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32651 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32652 typecontainer object.
32654 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32655 of just a Report object.
32657 2001-09-11 Ravi Pratap <ravi@ximian.com>
32659 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32661 (TypeContainer::Populate): Now define the delegates of the type too.
32662 (TypeContainer.Delegates): Property to access the list of delegates defined
32665 * delegates.cs (Delegate::Define): Implement partially.
32667 * modifiers.cs (TypeAttr): Handle more flags.
32669 2001-09-11 Ravi Pratap <ravi@ximian.com>
32671 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32673 (Operator::Define): Re-write logic to get types by using the LookupType method
32674 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32675 (Indexer::Define): Ditto.
32676 (Event::Define): Ditto.
32677 (Property::Define): Ditto.
32679 2001-09-10 Ravi Pratap <ravi@ximian.com>
32681 * class.cs (TypeContainer::Populate): Now define operators too.
32682 (TypeContainer.Operators): New property to access the list of operators
32684 (Operator.OperatorMethodBuilder): New member to hold the method builder
32685 for the operator we are defining.
32686 (Operator::Define): Implement.
32688 2001-09-10 Ravi Pratap <ravi@ximian.com>
32690 * class.cs (Event::Define): Make the prefixes of the accessor methods
32691 addOn_ and removeOn_
32693 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32694 of the location being passed in too. Ideally, this should go later since all
32695 error reporting should be done through the Report object.
32697 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32698 (Populate): Iterate thru the indexers we have and define them too.
32699 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32700 for the get and set accessors.
32701 (Indexer::Define): Implement.
32703 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32705 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32706 my previous implementation, did not work.
32708 * typemanager.cs: Add a couple of missing types (the longs).
32710 * literal.cs: Use TypeManager.bool_type instead of getting it.
32712 * expression.cs (EventExpr): New kind of expressions.
32713 (Expressio::ExprClassFromMemberInfo): finish
32715 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32717 * assign.cs: Emit stores to static fields differently.
32719 2001-09-08 Ravi Pratap <ravi@ximian.com>
32721 * Merge in changes and adjust code to tackle conflicts. Backed out my
32722 code in Assign::Resolve ;-)
32724 2001-09-08 Ravi Pratap <ravi@ximian.com>
32726 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32727 instead Report.Error and also pass in the location.
32728 (CSharpParser::Lexer): New readonly property to return the reference
32729 to the Tokenizer object.
32730 (declare_local_variables): Use Report.Error with location instead of plain
32734 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32735 (Operator.CheckBinaryOperator): Ditto.
32737 * cs-parser.jay (operator_declarator): Update accordingly.
32739 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32740 (CheckBinaryOperator): Same here.
32742 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32743 on the name without any prefixes of namespace names etc. This is because we
32744 already might have something already fully qualified like
32745 'System.Console.WriteLine'
32747 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32749 2001-09-07 Ravi Pratap <ravi@ximian.com>
32751 * cs-tokenizer.cs (location): Return a string which also contains
32754 * expression.cs (ElementAccess): New class for expressions of the
32755 type 'element access.'
32756 (BaseAccess): New class for expressions of the type 'base access.'
32757 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32760 * cs-parser.jay (element_access): Implement action.
32761 (base_access): Implement actions.
32762 (checked_expression, unchecked_expression): Implement.
32764 * cs-parser.jay (local_variable_type): Correct and implement.
32765 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32767 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32769 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32770 name and the specifiers.
32772 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32774 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32775 making them all public ;-)
32777 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32780 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32782 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32784 (FieldExpr, PropertyExprs): New resolved expressions.
32785 (SimpleName::MemberStaticCheck): Perform static checks for access
32786 to non-static fields on static methods. Maybe this should be
32787 generalized for MemberAccesses.
32788 (SimpleName::ResolveSimpleName): More work on simple name
32791 * cs-parser.jay (primary_expression/qualified_identifier): track
32792 the parameter index.
32794 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32795 (EmitContext::EmitBoolExpression): Chain to expression generation
32796 instead of temporary hack.
32797 (::EmitStatementExpression): Put generic expression code generation.
32799 * assign.cs (Assign::Emit): Implement variable assignments to
32800 local variables, parameters and fields.
32802 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32804 * statement.cs (Block::GetVariableInfo): New method, returns the
32805 VariableInfo for a variable name in a block.
32806 (Block::GetVariableType): Implement in terms of GetVariableInfo
32808 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32809 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32811 2001-09-06 Ravi Pratap <ravi@ximian.com>
32813 * cs-parser.jay (operator_declaration): Continue on my quest : update
32814 to take attributes argument.
32815 (event_declaration): Ditto.
32816 (enum_declaration): Ditto.
32817 (indexer_declaration): Ditto.
32819 * class.cs (Operator::Operator): Update constructor accordingly.
32820 (Event::Event): Ditto.
32822 * delegate.cs (Delegate::Delegate): Same here.
32824 * enum.cs (Enum::Enum): Same here.
32826 2001-09-05 Ravi Pratap <ravi@ximian.com>
32828 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32830 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32832 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32833 being passed around as an arraylist.
32834 (Attributes::AddAttribute): Method to add attribute sections.
32836 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32837 (struct_declaration): Update accordingly.
32838 (constant_declaration): Update.
32839 (field_declaration): Update.
32840 (method_header): Update.
32841 (fixed_parameter): Update.
32842 (parameter_array): Ditto.
32843 (property_declaration): Ditto.
32844 (destructor_declaration): Ditto.
32846 * class.cs (Struct::Struct): Update constructors accordingly.
32847 (Class::Class): Ditto.
32848 (Field::Field): Ditto.
32849 (Method::Method): Ditto.
32850 (Property::Property): Ditto.
32851 (TypeContainer::OptAttribute): update property's return type.
32853 * interface.cs (Interface.opt_attributes): New member.
32854 (Interface::Interface): Update to take the extra Attributes argument.
32856 * parameter.cs (Parameter::Parameter): Ditto.
32858 * constant.cs (Constant::Constant): Ditto.
32860 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32861 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32862 the attributes as a parameter.
32863 (InterfaceProperty): Update constructor call.
32864 (InterfaceEvent): Ditto.
32865 (InterfaceMethod): Ditto.
32866 (InterfaceIndexer): Ditto.
32868 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32869 pass the attributes too.
32870 (interface_event_declaration): Ditto.
32871 (interface_property_declaration): Ditto.
32872 (interface_method_declaration): Ditto.
32873 (interface_declaration): Ditto.
32875 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32877 * class.cs (Method::Define): Track the "static Main" definition to
32878 create an entry point.
32880 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32881 EntryPoint if we find it.
32883 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32884 (EmitContext::ig): Make this variable public.
32886 * driver.cs: Make the default output file be the first file name
32887 with the .exe extension.
32889 Detect empty compilations
32891 Handle various kinds of output targets. Handle --target and
32892 rename -t to --dumper.
32894 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32895 methods inherited from Expression return now an Expression. This
32896 will is used during the tree rewriting as we resolve them during
32899 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32900 the spec. Missing entirely is the information about
32901 accessability of elements of it.
32903 (Expression::ExprClassFromMemberInfo): New constructor for
32904 Expressions that creates a fully initialized Expression based on
32905 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32908 (Invocation::Resolve): Begin implementing resolution of invocations.
32910 * literal.cs (StringLiteral): Implement Emit.
32912 2001-09-05 Ravi Pratap <ravi@ximian.com>
32914 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32917 2001-09-04 Ravi Pratap <ravi@ximian.com>
32919 * cs-parser.jay (attribute_arguments): Implement actions.
32920 (attribute): Fix bug in production. Implement action.
32921 (attribute_list): Implement.
32922 (attribute_target): Implement.
32923 (attribute_target_specifier, opt_target_specifier): Implement
32924 (CheckAttributeTarget): New method to check if the attribute target
32926 (attribute_section): Implement.
32927 (opt_attributes): Implement.
32929 * attribute.cs : New file to handle attributes.
32930 (Attribute): Class to hold attribute info.
32932 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32933 (attribute_section): Modify production to use 2 different rules to
32934 achieve the same thing. 1 s/r conflict down !
32935 Clean out commented, useless, non-reducing dimension_separator rules.
32937 * class.cs (TypeContainer.attributes): New member to hold list
32938 of attributes for a type.
32939 (Struct::Struct): Modify to take one more argument, the attribute list.
32940 (Class::Class): Ditto.
32941 (Field::Field): Ditto.
32942 (Method::Method): Ditto.
32943 (Property::Property): Ditto.
32945 * cs-parser.jay (struct_declaration): Update constructor call to
32946 pass in the attributes too.
32947 (class_declaration): Ditto.
32948 (constant_declaration): Ditto.
32949 (field_declaration): Ditto.
32950 (method_header): Ditto.
32951 (fixed_parameter): Ditto.
32952 (parameter_array): Ditto.
32953 (property_declaration): Ditto.
32955 * constant.cs (Constant::Constant): Update constructor similarly.
32956 Use System.Collections.
32958 * parameter.cs (Parameter::Parameter): Update as above.
32960 2001-09-02 Ravi Pratap <ravi@ximian.com>
32962 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32963 (TypeContainer.delegates): New member to hold list of delegates.
32965 * cs-parser.jay (delegate_declaration): Implement the action correctly
32966 this time as I seem to be on crack ;-)
32968 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32970 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32971 tell whether an identifier represents a namespace.
32973 * expression.cs (NamespaceExpr): A namespace expression, used only
32974 temporarly during expression resolution.
32975 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32976 utility functions to resolve names on expressions.
32978 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32980 * codegen.cs: Add hook for StatementExpressions.
32982 * class.cs: Fix inverted test for static flag in methods.
32984 2001-09-02 Ravi Pratap <ravi@ximian.com>
32986 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32987 to make it coincide with MS' number.
32988 (Operator::CheckBinaryOperator): Ditto.
32990 * ../errors/errors.txt : Remove error numbers added earlier.
32992 * ../errors/cs1019.cs : Test case for error # 1019
32994 * ../errros/cs1020.cs : Test case for error # 1020
32996 * cs-parser.jay : Clean out commented cruft.
32997 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32998 used anywhere - non-reducing rule.
32999 (namespace_declarations): Non-reducing rule - comment out.
33001 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33002 with TypeContainer::AddEnum.
33004 * delegate.cs : New file for delegate handling classes.
33005 (Delegate): Class for declaring delegates.
33007 * makefile : Update.
33009 * cs-parser.jay (delegate_declaration): Implement.
33011 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33013 * class.cs (Event::Define): Implement.
33014 (Event.EventBuilder): New member.
33016 * class.cs (TypeContainer::Populate): Update to define all enums and events
33018 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33019 readonly fields for all these cases ?
33021 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33023 * class.cs (Property): Revamp to use the convention of making fields readonly.
33024 Accordingly modify code elsewhere.
33026 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33027 the Define method of the Property class.
33029 * class.cs : Clean up applied patch and update references to variables etc. Fix
33031 (TypeContainer::Populate): Update to define all the properties we have. Also
33032 define all enumerations.
33034 * enum.cs (Define): Implement.
33036 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33038 * cs-parser.jay (overloadable_operator): The semantic value is an
33039 enum of the Operator class.
33040 (operator_declarator): Implement actions.
33041 (operator_declaration): Implement.
33043 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33044 validity of definitions.
33045 (Operator::CheckBinaryOperator): Static method to check for binary operators
33046 (TypeContainer::AddOperator): New method to add an operator to a type.
33048 * cs-parser.jay (indexer_declaration): Added line to actually call the
33049 AddIndexer method so it gets added ;-)
33051 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33052 already taken care of by the MS compiler ?
33054 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33056 * class.cs (Operator): New class for operator declarations.
33057 (Operator::OpType): Enum for the various operators.
33059 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33061 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33062 ostensibly handle this in semantic analysis.
33064 * cs-parser.jay (general_catch_clause): Comment out
33065 (specific_catch_clauses, specific_catch_clause): Ditto.
33066 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33067 (catch_args, opt_catch_args): New productions.
33068 (catch_clause): Rewrite to use the new productions above
33069 (catch_clauses): Modify accordingly.
33070 (opt_catch_clauses): New production to use in try_statement
33071 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33072 and re-write the code in the actions to extract the specific and
33073 general catch clauses by being a little smart ;-)
33075 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33076 Hooray, try and catch statements parse fine !
33078 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33080 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33081 string from the hashtable of variables.
33083 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33084 I end up making that mistake ;-)
33085 (catch_clauses): Fixed gross error which made Key and Value of the
33086 DictionaryEntry the same : $1 !!
33088 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33090 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33092 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33093 when the add and remove accessors are specified.
33095 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33097 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33098 information about indexer_declarator.
33099 (indexer_declarator): Implement actions.
33100 (parsing_indexer): New local boolean used to keep track of whether
33101 we are parsing indexers or properties. This is necessary because
33102 implicit_parameters come into picture even for the get accessor in the
33103 case of an indexer.
33104 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33106 * class.cs (Indexer): New class for indexer declarations.
33107 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33108 (TypeContainer::indexers): New member to hold list of indexers for the
33111 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33113 * cs-parser.jay (add_accessor_declaration): Implement action.
33114 (remove_accessor_declaration): Implement action.
33115 (event_accessors_declaration): Implement
33116 (variable_declarators): swap statements for first rule - trivial.
33118 * class.cs (Event): New class to hold information about event
33120 (TypeContainer::AddEvent): New method to add an event to a type
33121 (TypeContainer::events): New member to hold list of events.
33123 * cs-parser.jay (event_declaration): Implement actions.
33125 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33127 * cs-parser.jay (dim_separators): Implement. Make it a string
33128 concatenating all the commas together, just as they appear.
33129 (opt_dim_separators): Modify accordingly
33130 (rank_specifiers): Update accordingly. Basically do the same
33131 thing - instead, collect the brackets here.
33132 (opt_rank_sepcifiers): Modify accordingly.
33133 (array_type): Modify to actually return the complete type string
33134 instead of ignoring the rank_specifiers.
33135 (expression_list): Implement to collect the expressions
33136 (variable_initializer): Implement. We make it a list of expressions
33137 essentially so that we can handle the array_initializer case neatly too.
33138 (variable_initializer_list): Implement.
33139 (array_initializer): Make it a list of variable_initializers
33140 (opt_array_initializer): Modify accordingly.
33142 * expression.cs (New::NType): Add enumeration to help us
33143 keep track of whether we have an object/delegate creation
33144 or an array creation.
33145 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33146 members to hold data about array creation.
33147 (New:New): Modify to update NewType
33148 (New:New): New Overloaded contructor for the array creation
33151 * cs-parser.jay (array_creation_expression): Implement to call
33152 the overloaded New constructor.
33154 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33156 * class.cs (TypeContainer::Constructors): Return member
33157 constructors instead of returning null.
33159 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33161 * typemanager.cs (InitCoreTypes): Initialize the various core
33162 types after we have populated the type manager with the user
33163 defined types (this distinction will be important later while
33164 compiling corlib.dll)
33166 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33167 on Expression Classification. Now all expressions have a method
33168 `Resolve' and a method `Emit'.
33170 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33171 generation from working. Also add some temporary debugging
33174 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33176 * codegen.cs: Lots of code generation pieces. This is only the
33177 beginning, will continue tomorrow with more touches of polish. We
33178 handle the fundamentals of if, while, do, for, return. Others are
33179 trickier and I need to start working on invocations soon.
33181 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33184 * codegen.cs (EmitContext): New struct, used during code
33185 emission to keep a context. Most of the code generation will be
33188 * cs-parser.jay: Add embedded blocks to the list of statements of
33189 this block. So code generation proceeds in a top down fashion.
33191 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33193 * statement.cs: Add support for multiple child blocks.
33195 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33197 * codegen.cs (EmitCode): New function, will emit the code for a
33198 Block of code given a TypeContainer and its ILGenerator.
33200 * statement.cs (Block): Standard public readonly optimization.
33201 (Block::Block constructors): Link children.
33202 (Block::Child): Child Linker.
33203 (Block::EmitVariables): Emits IL variable declarations.
33205 * class.cs: Drop support for MethodGroups here, delay until
33207 (Method::): Applied the same simplification that I did before, and
33208 move from Properties to public readonly fields.
33209 (Method::ParameterTypes): Returns the parameter types for the
33210 function, and implements a cache that will be useful later when I
33211 do error checking and the semantic analysis on the methods is
33213 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33214 and made a method, optional argument tells whether this is a class
33215 or a structure to apply the `has-this' bit.
33216 (Method::GetCallingConvention): Implement, returns the calling
33218 (Method::Define): Defines the type, a second pass is performed
33219 later to populate the methods.
33221 (Constructor::ParameterTypes): implement a cache similar to the
33222 one on Method::ParameterTypes, useful later when we do semantic
33225 (TypeContainer::EmitMethod): New method. Emits methods.
33227 * expression.cs: Removed MethodGroup class from here.
33229 * parameter.cs (Parameters::GetCallingConvention): new method.
33231 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33233 * class.cs (TypeContainer::Populate): Drop RootContext from the
33236 (Constructor::CallingConvention): Returns the calling convention.
33237 (Constructor::ParameterTypes): Returns the constructor parameter
33240 (TypeContainer::AddConstructor): Keep track of default constructor
33241 and the default static constructor.
33243 (Constructor::) Another class that starts using `public readonly'
33244 instead of properties.
33246 (Constructor::IsDefault): Whether this is a default constructor.
33248 (Field::) use readonly public fields instead of properties also.
33250 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33251 track of static constructors; If none is used, turn on
33252 BeforeFieldInit in the TypeAttributes.
33254 * cs-parser.jay (opt_argument_list): now the return can be null
33255 for the cases where there are no arguments.
33257 (constructor_declarator): If there is no implicit `base' or
33258 `this', then invoke the default parent constructor.
33260 * modifiers.cs (MethodAttr): New static function maps a set of
33261 modifiers flags into a MethodAttributes enum
33262 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33263 MethodAttr, TypeAttr to represent the various mappings where the
33264 modifiers are used.
33265 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33267 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33269 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33272 * interface.cs (PopulateIndexer): Implemented the code generator
33273 for interface indexers.
33275 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33277 * interface.cs (InterfaceMemberBase): Now we track the new status
33280 (PopulateProperty): Implement property population. Woohoo! Got
33281 Methods and Properties going today.
33283 Removed all the properties for interfaces, and replaced them with
33284 `public readonly' fields.
33286 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33288 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33289 initialize their hashtables/arraylists only when they are needed
33290 instead of doing this always.
33292 * parameter.cs: Handle refs and out parameters.
33294 * cs-parser.jay: Use an ArrayList to construct the arguments
33295 instead of the ParameterCollection, and then cast that to a
33298 * parameter.cs: Drop the use of ParameterCollection and use
33299 instead arrays of Parameters.
33301 (GetParameterInfo): Use the Type, not the Name when resolving
33304 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33306 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33307 and instead use public readonly fields.
33309 * class.cs: Put back walking code for type containers.
33311 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33313 * class.cs (MakeConstant): Code to define constants.
33315 * rootcontext.cs (LookupType): New function. Used to locate types
33318 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33320 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33321 this System.Reflection code is. Kudos to Microsoft
33323 * typemanager.cs: Implement a type cache and avoid loading all
33324 types at boot time. Wrap in LookupType the internals. This made
33325 the compiler so much faster. Wow. I rule!
33327 * driver.cs: Make sure we always load mscorlib first (for
33328 debugging purposes, nothing really important).
33330 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33331 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33333 * rootcontext.cs: Lookup types on their namespace; Lookup types
33334 on namespaces that have been imported using the `using' keyword.
33336 * class.cs (TypeContainer::TypeAttr): Virtualize.
33337 (Class::TypeAttr): Return attributes suitable for this bad boy.
33338 (Struct::TypeAttr): ditto.
33339 Handle nested classes.
33340 (TypeContainer::) Remove all the type visiting code, it is now
33341 replaced with the rootcontext.cs code
33343 * rootcontext.cs (GetClassBases): Added support for structs.
33345 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33347 * interface.cs, statement.cs, class.cs, parameter.cs,
33348 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33349 Drop use of TypeRefs, and use strings instead.
33351 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33355 * class.cs (Struct::Struct): set the SEALED flags after
33356 checking the modifiers.
33357 (TypeContainer::TypeAttr): new property, returns the
33358 TypeAttributes for a class.
33360 * cs-parser.jay (type_list): Oops, list production was creating a
33361 new list of base types.
33363 * rootcontext.cs (StdLib): New property.
33364 (GetInterfaceTypeByName): returns an interface by type name, and
33365 encapsulates error handling here.
33366 (GetInterfaces): simplified.
33367 (ResolveTree): Encapsulated all the tree resolution here.
33368 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33371 * driver.cs: Add support for --nostdlib, to avoid loading the
33372 default assemblies.
33373 (Main): Do not put tree resolution here.
33375 * rootcontext.cs: Beginning of the class resolution.
33377 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33379 * rootcontext.cs: Provide better error reporting.
33381 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33383 * rootcontext.cs (CreateInterface): Handle the case where there
33384 are no parent interfaces.
33386 (CloseTypes): Routine to flush types at the end.
33387 (CreateInterface): Track types.
33388 (GetInterfaces): Returns an array of Types from the list of
33389 defined interfaces.
33391 * typemanager.c (AddUserType): Mechanism to track user types (puts
33392 the type on the global type hash, and allows us to close it at the
33395 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33397 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33398 RecordInterface instead.
33400 * cs-parser.jay: Updated to reflect changes above.
33402 * decl.cs (Definition): Keep track of the TypeBuilder type that
33403 represents this type here. Not sure we will use it in the long
33404 run, but wont hurt for now.
33406 * driver.cs: Smaller changes to accomodate the new code.
33408 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33411 * rootcontext.cs (CreateInterface): New method, used to create
33412 the System.TypeBuilder type for interfaces.
33413 (ResolveInterfaces): new entry point to resolve the interface
33415 (CodeGen): Property, used to keep track of the code generator.
33417 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33419 * cs-parser.jay: Add a second production for delegate_declaration
33422 (enum_body): Put an opt_comma here instead of putting it on
33423 enum_body or enum_member_declarations so we can handle trailing
33424 commas on enumeration members. Gets rid of a shift/reduce.
33426 (type_list): Need a COMMA in the middle.
33428 (indexer_declaration): Tell tokenizer to recognize get/set
33430 * Remove old targets.
33432 * Re-add the parser target.
33434 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33436 * cs-parser.jay: Add precendence rules for a number of operators
33437 ot reduce the number of shift/reduce conflicts in the grammar.
33439 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33441 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33444 Get rid of old crufty code.
33446 * rootcontext.cs: Use this to keep track of the parsed
33447 representation and the defined types available to the program.
33449 * gen-treedump.cs: adjust for new convention.
33451 * type.cs: Split out the type manager, and the assembly builder
33454 * typemanager.cs: the type manager will live here now.
33456 * cil-codegen.cs: And the code generator here.
33458 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33460 * makefile: Fixed up for easy making.
33462 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33464 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33467 (unary_expression): Expand pre_increment_expression and
33468 post_decrement_expression to reduce a shift/reduce.
33470 2001-07-11 Simon Cozens
33472 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33474 Improve allow_keyword_as_indent name.
33476 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33478 * Adjustments for Beta2.
33480 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33482 * decl.cs: Added `Define' abstract method.
33483 (InTransit): new property, used to catch recursive definitions.
33485 * interface.cs: Implement `Define'.
33487 * modifiers.cs: Map Modifiers.constants to
33488 System.Reflection.TypeAttribute flags.
33490 * class.cs: Keep track of types and user-defined types.
33491 (BuilderInit): New method for creating an assembly
33492 (ResolveType): New function to launch the resolution process, only
33493 used by interfaces for now.
33495 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33496 that are inserted into the name space.
33498 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33500 * ARGH. I have screwed up my tree so many times due to the use of
33501 rsync rather than using CVS. Going to fix this at once.
33503 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33506 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33508 * Experiment successful: Use System.Type rather that our own
33511 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33513 * cs-parser.jay: Removed nsAliases from here.
33515 Use new namespaces, handle `using XXX;'
33517 * namespace.cs: Reimplemented namespace handling, use a recursive
33518 definition of the class. Now we can keep track of using clauses
33519 and catch invalid using clauses.
33521 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33523 * gen-treedump.cs: Adapted for all the renaming.
33525 * expression.cs (Expression): this class now has a Type property
33526 which returns an expression Type.
33528 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33529 `Type', as this has a different meaning now in the base
33531 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33533 * interface.cs, class.cs: Removed from all the sources the
33534 references to signature computation, as we can not do method
33535 signature computation during the parsing time, as we are not
33536 trying to solve at that point distinguishing:
33540 void a (NS.Blah x) {}
33543 Which depending on the context might be valid or not, as we do not
33544 know if Blah is the same thing as NS.Blah at that point.
33546 * Redid everything so the code uses TypeRefs now instead of
33547 Types. TypeRefs are just temporary type placeholders, that need
33548 to be resolved. They initially have a pointer to a string and the
33549 current scope in which they are used. This is used later by the
33550 compiler to resolve the reference to an actual Type.
33552 * DeclSpace is no longer a CIR.Type, and neither are
33553 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33554 are all DeclSpaces, but no Types.
33556 * type.cs (TypeRefManager): This implements the TypeRef manager,
33557 which keeps track of all the types that need to be resolved after
33558 the parsing has finished.
33560 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33562 * ARGH. We are going to have to store `foreach' as a class rather
33563 than resolving it, as we need to verify error 1579 after name
33564 resolution. *OR* we could keep a flag that says `This request to
33565 IEnumerator comes from a foreach statement' which we can then use
33566 to generate the error.
33568 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33570 * class.cs (TypeContainer.AddMethod): we now add methods to the
33571 MethodGroup instead of the method hashtable.
33573 * expression.cs: Add MethodGroup abstraction, which gets us one
33574 step closer to the specification in the way we handle method
33577 * cs-parser.jay (primary_expression): qualified_identifier now
33578 tried to match up an identifier to a local variable reference or
33579 to a parameter reference.
33581 current_local_parameters is now a parser global variable that
33582 points to the current parameters for the block, used during name
33585 (property_declaration): Now creates an implicit `value' argument to
33588 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33590 * parameter.cs: Do not use `param' arguments as part of the
33591 signature, per the spec.
33593 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33595 * decl.cs: Base class for classes, structs and interfaces. This
33596 is the "Declaration Space"
33598 * cs-parser.jay: Use CheckDef for checking declaration errors
33599 instead of having one on each function.
33601 * class.cs: Factor out some code for handling error handling in
33602 accordance to the "Declarations" section in the "Basic Concepts"
33603 chapter in the ECMA C# spec.
33605 * interface.cs: Make all interface member classes derive from
33606 InterfaceMemberBase.
33608 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33610 * Many things: all interfaces are parsed and generated in
33611 gen-treedump. Support for member variables, constructors,
33612 destructors, properties, constants is there.
33614 Beginning of the IL backend, but very little done, just there for
33617 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33619 * cs-parser.jay: Fix labeled statement.
33621 * cs-tokenizer.cs (escape): Escape " and ' always.
33622 ref_line, ref_name: keep track of the line/filename as instructed
33623 by #line by the compiler.
33626 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33628 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33629 to match the values in System.CodeDOM.
33631 Divid renamed to Divide.
33633 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33635 (Statements.set): remove.
33637 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33640 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33641 falseStatements always have valid values.
33643 * cs-parser.jay: Use System.CodeDOM now.