1 2008-05-06 Martin Baulig <martin@ximian.com>
3 * class.cs (Constructor.Emit): Fix the logic whether to emit
6 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
9 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
10 InvalidOperationException when the iterator is before the start or
13 2008-05-06 Marek Safar <marek.safar@gmail.com>
15 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
16 when left is nullable type.
18 2008-05-06 Marek Safar <marek.safar@gmail.com>
21 * expression.cs (LocalVariableReference): Continue in resolving when
22 variable is not assigned.
24 2008-05-05 Marek Safar <marek.safar@gmail.com>
26 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
29 2008-05-04 Marek Safar <marek.safar@gmail.com>
31 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
32 it saves many redundant temporary variables for nullable operations.
34 2008-05-03 Marek Safar <marek.safar@gmail.com>
36 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
38 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
41 * nullable.cs: Constant coalescing operator optimizations.
43 2008-05-03 Marek Safar <marek.safar@gmail.com>
45 * constant.cs: Use unsigned conversion for values which are unsigned only.
47 2008-05-03 Marek Safar <marek.safar@gmail.com>
49 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
50 coalescing operator as it should be.
52 2008-05-02 Marek Safar <marek.safar@gmail.com>
55 * expression.cs: All predefined delegate operators require implicit method
58 2008-05-02 Marek Safar <marek.safar@gmail.com>
60 * constant.cs: Emit long constant as uint when fits the range.
62 * convert.cs, expression.cs: Fixed few unsafe conversions.
64 2008-05-02 Marek Safar <marek.safar@gmail.com>
66 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
68 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
71 * convert.cs (ImplicitNumericConversion): Don't modify the type of
73 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
75 2008-05-01 Marek Safar <marek.safar@gmail.com>
77 * constant.cs, literal.cs: IsLiteral property for error reporting.
79 * ecore.cs, expression.cs: Implemented Property expression.
81 2008-05-01 Marek Safar <marek.safar@gmail.com>
83 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
85 * nullable.cs: Implemented nullable coalescing null operator.
87 * ecore.cs, expression.cs: Expression trees work.
89 2008-05-01 Marek Safar <marek.safar@gmail.com>
91 * ecore.cs: CreateExpressionTree is finally abstract.
93 * expression.cs, linq.cs: Updated.
95 2008-05-01 Marek Safar <marek.safar@gmail.com>
97 * expression.cs, ecore.cs: Block base access expression inside expression
100 2008-05-01 Marek Safar <marek.safar@gmail.com>
102 A fix for bug #385058
103 * expression.cs: User-defined operator implementations always take
104 precedence over predefined operator implementations.
106 2008-04-30 Marek Safar <marek.safar@gmail.com>
108 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
109 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
110 expression tree conversions.
112 2008-04-30 Marek Safar <marek.safar@gmail.com>
114 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
115 operators method details to Operator class.
117 2008-04-30 Marek Safar <marek.safar@gmail.com>
119 * anonymous.cs: Pass unsafe flags to anonymous container.
121 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
122 inside expression tree.
124 2008-04-29 Martin Baulig <martin@ximian.com>
126 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
127 (Tokenizer.PopPosition): Also restore the `line'.
129 2008-04-29 Marek Safar <marek.safar@gmail.com>
131 * delegate.cs: Implemented Invoke expression.
133 2008-04-29 Marek Safar <marek.safar@gmail.com>
135 * expression.cs: Fixed equality reference comparison regression.
137 2008-04-29 Marek Safar <marek.safar@gmail.com>
139 * ecore.cs: Clean up EmptyCast hack.
141 * expression.cs, nullable.cs: Implemented enum binary and unary operations
142 using correct conversion rules. Also fixes #383993.
144 2008-04-28 Martin Baulig <martin@ximian.com>
146 * class.cs (Constructor.Emit): Don't emit debugging information
147 for generated default .ctor's.
149 2008-04-28 Marek Safar <marek.safar@gmail.com>
151 * convert.cs: Empty-cast ushort to int conversion.
153 2008-04-28 Marek Safar <marek.safar@gmail.com>
155 A fix for bug #384191
156 * ecore.cs, expression.cs: Fixed expression cloning.
158 2008-04-28 Marek Safar <marek.safar@gmail.com>
160 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
162 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
164 Fix #381559, test-638.cs, test-639.cs
165 * assign.cs (CompoundAssign.Helper): New wrapper.
166 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
168 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
169 Pass unconverted expressions to the params array creation expression.
170 (FieldExpr.EmitAssign): Don't special-case StringConcat.
171 (PropertyExpr.EmitAssign): Likewise.
172 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
173 element if it is of kind CompoundAssign.Helper.
174 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
175 first before anything else.
176 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
177 (ArrayAccess.LoadArrayAndArguments): Simplify.
179 2008-04-27 Marek Safar <marek.safar@gmail.com>
181 * expression.cs: Fixed cloning of typeof(void).
183 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
185 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
186 (Assign.Emit): Likewise. Move it to ...
187 (CompoundAssign.DoResolve): ... here and ...
188 (CompoundAssign.Emit): ... here.
189 (EventAddOrRemove): New helper to handle += and -= on events, and
190 avoid the use of BinaryDelegates.
191 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
192 (EventExpr.EmitAddOrRemove): Improve.
193 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
195 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
196 create VarExprs for 'foo.bar.var'.
197 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
198 is a highly inappropriate name for its functionality.
200 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
202 Simplify handling of multiple assignments
203 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
205 (SimpleAssign): New. Class to be used for normal assignments.
206 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
207 * expression.cs, parameter.cs, statement.cs: Likewise.
209 2008-04-25 Marek Safar <marek.safar@gmail.com>
211 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
212 for incompatible underlying types, more to come, uff.
214 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
217 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
220 2008-04-25 Marek Safar <marek.safar@gmail.com>
222 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
224 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
226 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
227 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
228 * statement.cs (While, Do, For): Allow test to have side effects.
229 (For.DoEmit): Always emit InitStatement.
232 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
233 Always create SideEffectConstant.
234 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
235 of type EnumConstant.
237 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
238 Handle 'right' being SideEffectConstant of type 'bool'.
240 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
241 Use left.EmitBranchable instead of open coding it, so as to
242 improve optimization opportunities.
244 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
246 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
248 (Expression.EmitSideEffect): Document.
250 2008-04-23 Marek Safar <marek.safar@gmail.com>
252 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
254 2008-04-23 Marek Safar <marek.safar@gmail.com>
256 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
258 2008-04-23 Marek Safar <marek.safar@gmail.com>
260 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
261 conversion to expression tree.
263 2008-04-23 Marek Safar <marek.safar@gmail.com>
265 * ecore.cs: Removed unused expression.
267 2008-04-22 Marek Safar <marek.safar@gmail.com>
269 * expression.cs: Implemented NegateChecked and New expressions.
271 2008-04-22 Marek Safar <marek.safar@gmail.com>
273 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
275 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
278 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
279 needing final 'ret' instruction.
281 2008-04-22 Marek Safar <marek.safar@gmail.com>
283 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
285 2008-04-21 Marek Safar <marek.safar@gmail.com>
287 * expression.cs: Emit ldnull and not null expression as an instance argument
288 of static method expression calls.
290 2008-04-21 Marek Safar <marek.safar@gmail.com>
292 A fix for bug #378200
293 * expression.cs: Fixed crash when creating parameterless expression tree
296 2008-04-21 Marek Safar <marek.safar@gmail.com>
298 A fix for bug #375297
299 * anonymous.cs: Fixed crash when inferring from null argument anonymous
302 2008-04-21 Marek Safar <marek.safar@gmail.com>
304 A fix for bug #377596
305 * decl.cs, class.cs: Emit delegate type argument attributes.
307 2008-04-21 Marek Safar <marek.safar@gmail.com>
309 A fix for bug #365314
310 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
312 2008-04-21 Marek Safar <marek.safar@gmail.com>
314 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
317 2008-04-21 Marek Safar <marek.safar@gmail.com>
319 * generic.cs (TypeParameter): Removed redundant location.
321 2008-04-19 Marek Safar <marek.safar@gmail.com>
323 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
324 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
325 FullNamedExpression in all declaration type expression, statements will come
328 2008-04-18 Marek Safar <marek.safar@gmail.com>
330 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
331 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
333 2008-04-18 Marek Safar <marek.safar@gmail.com>
335 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
338 2008-04-17 Marek Safar <marek.safar@gmail.com>
340 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
343 2008-04-17 Marek Safar <marek.safar@gmail.com>
345 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
349 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
351 Hook up 'EmitSideEffect'
352 * constant.cs (Constant.EmitSideEffect): New.
353 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
354 (SideEffectConstant.EmitSideEffect): New.
355 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
356 unconditional branch in EmitBranchable.
357 (FieldExpr.EmitBranchable): New.
358 * expression.cs (Unary.EmitSideEffect): New.
359 (Binary.EmitSideEffect): New.
360 (VariableReference.EmitSideEffect): New. Do nothing.
362 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
364 Introduce 'EmitSideEffect'
365 * ecore.cs (Expression.EmitSideEffect): New.
366 (TypeCast): Rename from EmptyCast.
368 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
369 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
370 * convert.cs, nullable.cs: Update to changes.
372 2008-04-16 Marek Safar <marek.safar@gmail.com>
374 * class.cs, cs-parser.jay: Early check for base types expression.
376 2008-04-16 Marek Safar <marek.safar@gmail.com>
378 * decl.cs (MemberName): Declare PrettyName as obsolete.
380 2008-04-16 Marek Safar <marek.safar@gmail.com>
382 * namespace.cs: Use MemberName comparison.
384 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
387 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
389 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
390 (MemberName.FullyQualifiedName): New. Provides the functionality
391 that users assume FullName would have.
392 * ecore.cs, namespace.cs: Update to changes.
394 * statement.cs (Using.assign): Make into ExpressionStatement.
395 (Using.EmitPreTryBody): Simplify.
397 2008-04-16 Marek Safar <marek.safar@gmail.com>
399 * report.cs: ColorFormat is protected.
401 * rootcontext.cs: Unused fields clean-up.
403 * namespace.cs: Made UsingEntry name private.
405 2008-04-16 Marek Safar <marek.safar@gmail.com>
407 * cs-tokenizer.cs, location.cs: Removed unused field.
409 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
410 Raja R Harinath <harinath@hurrynot.org>
413 * constant.cs (SideEffectConstant.value): Rename from 'left'.
414 (SideEffectConstant.side_effect): Rename from 'right'.
415 (SideEffectConstant..ctor): Normalize 'side_effect'.
416 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
417 value of this constant.
418 * cfold.cs: Update to changes.
420 2008-04-15 Marek Safar <marek.safar@gmail.com>
422 * cs-paser.jay: Removed unused variable.
424 * driver.cs: Made Compile instance method.
426 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
428 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
430 2008-04-15 Marek Safar <marek.safar@gmail.com>
432 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
434 2008-04-13 Jb Evain <jbevain@novell.com>
436 * namespace.cs: update the System.Core fullname for 2.1
437 * driver.cs: update the list of required assemblies for 2.1.
438 Merged from the Moonlight 2 branch.
440 2008-04-11 Marek Safar <marek.safar@gmail.com>
442 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
443 types and user defined operators. User operators arguments has to be checked
444 for null value before invocation, which also means no operator is called
445 when any argument is not convertible to unwrapped nullable type.
447 2008-04-09 Marek Safar <marek.safar@gmail.com>
449 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
450 of Unary expressions to follow operator overloading rules precisely.
451 Also fixes #321794, #323794
453 2008-04-08 Marek Safar <marek.safar@gmail.com>
455 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
458 2008-04-08 Marek Safar <marek.safar@gmail.com>
460 * expression.cs, ecore.cs: Implemented MemberInit expression.
462 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
464 Fix mono/tests/exception4.cs
465 * statement.cs (ExceptionStatement, TryCatch): Revert to using
466 ec.NeedReturnLabel () rather emitting a 'nop'.
468 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
470 (TryCatch.SomeCodeFollows): Likewise.
471 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
472 for 'break', 'continue' and 'return' statements inside a try.
473 We're fairly sure that the generated IL stream will have more
474 instructions textually following the try.
475 (FlowBranchingTryCatch): Likewise.
477 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
478 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
481 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
482 wrapper -- forward everything to CollectionForeach.
483 (CollectionForeach.NonDisposableWrapper): New.
484 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
485 instead of a pop + branch to end.
487 2008-04-07 Marek Safar <marek.safar@gmail.com>
489 A fix for bug #377485
490 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
491 Propagate location for extension method groups. Report conversion failure at
494 2008-04-07 Marek Safar <marek.safar@gmail.com>
496 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
497 ListInit and Field expressions.
499 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
501 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
502 Since $PC is always -1 inside the body of MoveNext, the fault
504 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
505 * statement.cs (ExceptionStatement.emit_finally): Likewise.
506 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
508 The denouement! Fix #324708
509 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
510 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
511 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
512 'finally' inside the finally clause.
514 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
515 inside an iterator. Don't emit the body of the 'finally' inside
516 the finally clause yet.
518 Use the ResumableStatement infrastructure for MoveNext ()
519 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
520 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
521 'old_resume_points'. Move dispatcher upfront.
522 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
523 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
524 in an enumerator. This encodes the main fix in this patch series
525 -- we can only jump into the first instruction of a try from the
526 outside, but we want to emit try/finally regions in iterators and
527 resume in the middle of them.
529 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
531 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
532 of NeedReturnLabel here.
534 Introduce a common point for emitting try/finally to IL
535 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
536 features of the various subclasses, which are now driven by ...
537 (ExceptionStatement.EmitPreTryBody): ... this and ...
538 (ExceptionStatement.EmitTryBody): ... this and the original
540 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
541 Remove DoEmit and update to follow above protocol.
543 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
544 of the dispatcher are the same, skip emitting the 'switch'.
545 * iterator.cs (Iterator.EmitDispose): Update to changes.
547 Clean up handling of 'using' statement
548 * statement.cs (UsingTemporary): New. Carved out of ...
549 (Using): ... this. Simplify drastically. Handle exactly
551 * cs-parser.jay (using_statement): Split. Create UsingTemporary
552 or Using as appropriate. If there are multiple variable declared,
553 create nested Using statements.
554 (resource_acquisition): Kill.
556 * statement.cs (ExceptionStatement.EmitForDispose): Use
557 EmitFinallyBody, not EmitFinally.
559 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
560 * iterator.cs: Update to changes.
562 Start using the ResumableStatement infrastructure
563 * statement.cs (ResumeableStatement.PrepareForDispose): New.
564 (ResumableStatement.EmitForDispose): New.
565 (ExceptionStatement): Override them.
566 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
567 EmitForDispose to create the body of the Dispose method. Don't
570 * iterator.cs (Iterator.AddResumePoint): Move here from ...
571 * statement.cs (Toplevel.AddResumePoint): ... here.
572 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
573 * flowanalysis.cs (FlowBranchingIterator): New.
574 * codegen.cs (EmitContext): Update to changes.
576 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
577 (Iterator.old_resume_points): Rename from 'resume_points'.
578 (Iterator.MoveNextStatement): Remove unused class.
580 New infrastructure for try/finally in iterators (still unused)
581 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
582 (FlowBranchingToplevel.AddResumePoint): Hook into
583 ToplevelBlock.AddResumePoint.
584 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
585 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
586 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
587 resume points and assign program-counter values.
588 (ExceptionBlock.AddResumePoint): Collect resume points for
589 de-muxer at the top of try block.
590 * iterators.cs (Yield.CheckContext): Simplify.
591 (Yield.Resolve): Use FlowBranching.AddResumePoint.
593 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
595 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
596 argument to an ExitStatement.
597 (FlowBranchingException): Refactor saved origins code.
598 * statement.cs (ExitStatement): Update to cahges.
599 * iterator.cs (YieldBreak): Likewise.
601 * statement.cs (ResumableStatement): New. Common base class for
602 YieldReturn and ExceptionStatement.
603 (ExitStatement): New. Common base class for Return and YieldBreak.
604 (Return): Update to changes.
605 * iterator.cs (YieldBreak): Likewise.
606 * lambda.cs (ContextualReturn): Likewise.
609 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
610 emit a meaningful error message.
613 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
614 (VariableInfo.SetAssigned): Set it.
615 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
616 determine if CS0219 or CS0168 is appropriate. Don't use
617 flow-analysis information.
618 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
619 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
620 (EmitContext.EndFlowBranching): ... this.
622 2008-04-03 Marek Safar <marek.safar@gmail.com>
624 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
626 2008-04-03 Marek Safar <marek.safar@gmail.com>
628 A fix for bug #376508
629 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
630 ImplicitConversionExists.
632 2008-04-03 Marek Safar <marek.safar@gmail.com>
634 * expression.cs (Binary): Added remaining binary operators to expression
637 * nullable.cs: Optimize shift with null argument.
639 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
641 Fix minor IL regression
642 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
643 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
644 * cs-parser.jay (try_statement): Update to changes.
646 * statement.cs (TryFinally.need_exc_block): Delete.
647 (TryFinally): Update to changes.
649 Now all ExceptionStatements are unconditional
650 * statement.cs (CollectionForeach.DisposableWrapper): New.
651 Extract out the try/finally code into a new wrapper.
652 (CollectionForeach.Resolve): Use it to simplify the code.
654 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
656 Start at simplifying ExceptionStatement semantics a bit
657 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
658 * cs-parser.jay (try_statement): Update to changes.
659 (opt_catch_clauses): Remove.
660 * flowanalysis.cs: Update to changes.
661 (FlowBranching.BranchingType.TryCatch): New.
662 (FlowBranchingTryCatch): New.
664 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
665 (FlowBranching.CreateBranching): Update to changes.
666 (FlowBranchingBlock.AddSibling): Add sanity check.
667 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
670 * iterators.cs (Iterator.MarkFinally): Remove.
671 * statement.cs (ExceptionStatement): Update to changes.
673 Add support for skipping over finally blocks at runtime. First
674 in a series to fix #324708
675 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
676 (Iterator.EmitMoveNext): Initialize it.
677 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
678 branch over the body of the 'finally' clause.
680 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
682 Avoid lopsided use of Foo/DoFoo names
683 * statement.cs (ExpressionStatement.EmitFinallyBody):
684 Rename from EmitFinally.
685 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
686 * iterator.cs: Update to changes.
688 2008-04-02 Marek Safar <marek.safar@gmail.com>
690 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
691 based on UserOperatorCall. More binary nullable operators clean up.
693 2008-04-02 Martin Baulig <martin@ximian.com>
695 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
697 2008-04-02 Marek Safar <marek.safar@gmail.com>
699 * nullable.cs: Merge user and empty conversions when lifting expression
702 * expression.cs (StringConcat): Implemented expression tree representation.
704 2008-04-01 Marek Safar <marek.safar@gmail.com>
706 * nullable.cs: When lifting null literal and a user operator exists, no call
709 2008-04-01 Marek Safar <marek.safar@gmail.com>
711 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
714 2008-04-01 Marek Safar <marek.safar@gmail.com>
716 * nullable.cs, expression.cs: Use namespace instead heavily nested
717 monster abstract class.
719 2008-04-01 Marek Safar <marek.safar@gmail.com>
721 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
722 lifting of null literal and user operators. Clean up of some temporary
725 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
727 Fix #368224, test-629.cs
728 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
729 if it crossed an unwind-protect boundary.
730 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
731 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
732 inside an unwind-protected region.
733 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
734 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
735 'leave' instead of a 'br' if unwind-protected.
736 (Iterator.EmitYieldBreak): Likewise.
738 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
740 * driver.cs: Only define versioninfo resources if no win32 resource
743 2008-03-28 Marek Safar <marek.safar@gmail.com>
745 A fix for bug #372375
746 * convert.cs: Fixed boxing of nullable types.
748 2008-03-28 Marek Safar <marek.safar@gmail.com>
750 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
753 2008-03-28 Marek Safar <marek.safar@gmail.com>
755 A fix for bug #374619
756 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
758 2008-03-27 Marek Safar <marek.safar@gmail.com>
760 * lambda.cs: Check return type only for invocation.
762 2008-03-27 Marek Safar <marek.safar@gmail.com>
764 A fix for bug #374214
765 * ecore.cs: Correctly report argument type mismatch.
767 2008-03-27 Marek Safar <marek.safar@gmail.com>
769 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
770 and not rely on broken IsEnum.
772 2008-03-27 Marek Safar <marek.safar@gmail.com>
774 * nullable.cs: New file, extracted from generic.cs.
776 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
778 2008-03-27 Marek Safar <marek.safar@gmail.com>
780 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
781 predefined comparison operators and null literals.
783 * report.cs: New warning ID.
785 2008-03-25 Marek Safar <marek.safar@gmail.com>
787 A fix for bug #370577
788 * lambda.cs: Check return type too.
790 2008-03-25 Marek Safar <marek.safar@gmail.com>
792 A fix for bug #372846
793 * class.cs: Automatic properties can be declared as unsafe.
795 2008-03-20 Marek Safar <marek.safar@gmail.com>
797 * location.cs: Use string based concatenation.
799 * expression.cs: LiftedBinaryOperator is gmcs only.
801 2008-03-20 Marek Safar <marek.safar@gmail.com>
803 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
804 conversions rules and expression trees.
806 2008-03-19 Marek Safar <marek.safar@gmail.com>
808 * delegate.cs: Use extension method source as delegate target.
810 2008-03-19 Marek Safar <marek.safar@gmail.com>
812 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
813 binary operations to be purely based on binary operations and optimized
814 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
815 and other ET refactoring.
817 * typemanager.cs: Fixed warning.
819 2008-03-17 Marek Safar <marek.safar@gmail.com>
821 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
823 * symbolwriter.cs: Fixed.
825 2008-03-17 Marek Safar <marek.safar@gmail.com>
827 * anonymous.cs, driver.cs: Reset anonymous types counters.
829 2008-03-17 Marek Safar <marek.safar@gmail.com>
831 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
833 * class.cs: Use fullname for all type member definitions.
835 2008-02-19 Martin Baulig <martin@ximian.com>
838 (IMethodData.EmitExtraSymbolInfo): New interface method.
839 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
840 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
841 interface method here as an empty public virtual method.
844 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
845 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
846 CodeGen.SymbolWriter.SetRealMethodName().
848 2008-02-18 Martin Baulig <martin@ximian.com>
851 (ScopeInfo.EmitType): Override this and emit debugging
852 information for captured variables.
853 (RootScopeInfo.EmitType): Override this and emit symbol
854 information for a captured `this'.
856 2008-02-15 Martin Baulig <martin@ximian.com>
858 * iterators.cs: Emit debugging info.
861 (EmitContext.Flags): Add `OmitDebuggingInfo'.
862 (EmitContext.OmitDebuggingInfo): New public property.
865 (While): Override Emit() and don't emit symbol info there; do it
866 inside DoEmit() instead.
867 (Block.Emit): Omit symbol information while emitting the scope
868 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
870 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
871 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
872 .ctor to make `IsIterator' work.
874 2008-03-14 Martin Baulig <martin@ximian.com>
876 * symbolwriter.cs: Added the new symbol writer function from the
877 debugger's `terrania' branch; temporarily enclose them inside
878 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
881 2008-03-14 Martin Baulig <martin@ximian.com>
884 (SymbolWriter): Make this a public static class.
887 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
888 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
890 2008-03-14 Marek Safar <marek.safar@gmail.com>
892 A fix for bug #370577
893 * statement.cs, lambda.cs: Added extra limitations when dealing with void
896 2008-03-14 Marek Safar <marek.safar@gmail.com>
898 * typemanager.cs (CSharpName): Made 250 times faster.
900 2008-03-13 Marek Safar <marek.safar@gmail.com>
902 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
904 2008-03-12 Marek Safar <marek.safar@gmail.com>
906 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
907 crash when predefined field does not exist.
909 2008-03-12 Marek Safar <marek.safar@gmail.com>
911 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
913 2008-03-12 Marek Safar <marek.safar@gmail.com>
915 * class.cs (FixedField): Don't crash when contructors are missing.
917 2008-03-11 Marek Safar <marek.safar@gmail.com>
919 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
920 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
921 check internal types accessibility for internal and external types.
922 Replaced EnumToUnderlying by GetEnumUnderlyingType.
924 2008-03-11 Marek Safar <marek.safar@gmail.com>
926 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
927 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
928 attribute.cs, statement: Use corect instance of predefined types (work
931 2008-03-07 Marek Safar <marek.safar@gmail.com>
933 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
935 2008-03-07 Marek Safar <marek.safar@gmail.com>
937 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
938 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
939 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
940 predefined types clean up, delayed predefined types members initialization
941 (work related to #364674).
943 2008-03-05 Marek Safar <marek.safar@gmail.com>
945 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
947 2008-03-05 Marek Safar <marek.safar@gmail.com>
949 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
950 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
951 predefined types clean up (work related to #364674).
953 2008-03-04 Marek Safar <marek.safar@gmail.com>
955 * ecore.cs: Print an error message instead of throwing exception.
957 2008-03-04 Marek Safar <marek.safar@gmail.com>
959 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
960 expression.cs, statement.cs: Unififed null literal representation.
962 2008-03-03 Marek Safar <marek.safar@gmail.com>
964 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
965 expression.cs: Refactored binary operators resolve phase and improved speed.
966 The nullable code is still missing and won't work correctly, more fixes
969 It also fixes #323726, #324312, #324248, and many other unreported issues.
971 2008-02-29 Zoltan Varga <vargaz@gmail.com>
973 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
976 2008-02-27 Marek Safar <marek.safar@gmail.com>
978 * ecore.cs: Clean-up and split BetterConversion.
980 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
983 * enum.cs (EnumMember.Value): Only access 'value' if
984 ResolveValue says it's ok.
985 (EnumMember.DoResolveValue): Don't set prev_member.value.
986 (Enum.GetDefinition): Reverse arguments of Equals --
987 EnumMember.Value can return 'null'.
989 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
991 2008-02-22 Marek Safar <marek.safar@gmail.com>
993 * generic.cs, expression.cs: More ongoing work on expression trees.
995 2008-02-21 Marek Safar <marek.safar@gmail.com>
997 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
998 handle missing matches when mutiple operators exist.
1000 2008-02-20 Marek Safar <marek.safar@gmail.com>
1002 A fix for bug #363218
1003 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
1006 2008-02-20 Marek Safar <marek.safar@gmail.com>
1008 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
1009 update. This time to deal correctly with SideEffectConstant expression used
1010 as an argument for another constant folding.
1012 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
1014 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
1017 2008-02-19 Marek Safar <marek.safar@gmail.com>
1019 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
1021 2008-02-19 Marek Safar <marek.safar@gmail.com>
1023 A fix for bug #328136
1024 * expression.cs: Do not fold immediately LogicalAnd operators when the left
1025 side is a false constant, because we still need to evaluate the right-hand
1028 * statement.cs (If): Emit two types of boolean constants (simple constant,
1029 side-effect constant).
1031 2008-02-19 Marek Safar <marek.safar@gmail.com>
1033 * constant.cs (SideEffectConstant): Don't emit boolean constant.
1035 * expression.cs: Fold immediately LogicalAnd operators when both sides are
1038 2008-02-18 Marek Safar <marek.safar@gmail.com>
1040 A fix for bug #361457
1041 * ecore.cs (IsApplicable): Params methods have lower priority.
1043 * support.cs: Return correct parameter modifier for params types.
1045 2008-02-18 Marek Safar <marek.safar@gmail.com>
1047 * generic.cs (TypeParameter): Cache attribute target name.
1049 * support.cs: Removed unused variable.
1051 * typemanager.cs: Removed debugging leftover.
1053 * ecore.cs: Use local type instead of a property;
1055 * class.cs (VerifyMembers): Consider also parent to test whether type member
1058 * expression.cs (FullMethodDesc): Removed.
1060 * attribute.cs (IsValidArgumentType): Made static.
1062 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
1064 Cleanup to be more readable.
1065 * Makefile (GMCS_PROFILE): Remove.
1066 (COMPILER_NAME): New helper.
1068 2008-02-15 Miguel de Icaza <miguel@novell.com>
1070 * cs-tokenizer.cs: if a conditional expression happens inside a
1071 (...) this also means that we do not need to de-ambiguate between
1072 an parenthesized expression and a cast.
1076 * constant.cs (SideEffectConstant): a constant value that happens
1077 to have a side effect.
1079 Fixes the build regressions introduced by the fix for #359789
1081 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
1083 * expression.cs (Conditional.Emit): when emitting the ternary
1084 operator, use local variables to generate code verifiable code.
1086 The verifier cannot infer that the type on stack before the
1087 stloc.0 is executed is of type ParentB. This happens because the
1088 stack merge algorithm uses only parent types when deciding which
1089 is the common type. This is described in Part III 1.8.1.3 of ECMA
1092 This code compiled with mcs is not verifiable under MS. The MS
1093 verifier picks the first common interface of Foo and Bar, which is
1094 wrong, but doesn't use a full join type of the 2 interfaces.
1096 CSC uses a clever hack to compile such code in a verifiable
1097 way. It stores the intermediate values in a local variable with
1102 2008-02-14 Miguel de Icaza <miguel@novell.com>
1104 * expression.cs: Do not fold BitwiseAnd operators when the left
1105 side is a false constant, because we still need to evaluate the
1110 * support.cs: Instead of throwing an InternalErrorException when
1111 the position of the stream is outside the boundary of our buffer,
1112 reset the state of the reader, and restart the reading from the
1113 beginning of the file.
1115 2008-02-14 Marek Safar <marek.safar@gmail.com>
1117 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
1119 2008-02-14 Marek Safar <marek.safar@gmail.com>
1121 A fix for bug #361686
1122 * decl.cs: A protected types used inside a private class which parents
1123 derives from the protected class are accessible.
1125 2008-02-13 Marek Safar <marek.safar@gmail.com>
1127 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
1128 the parameterless constructor.
1130 2008-02-13 Marek Safar <marek.safar@gmail.com>
1132 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
1133 lookup methods to use standard member cache when doing member lookup.
1135 2008-02-12 Marek Safar <marek.safar@gmail.com>
1137 * driver.cs: Don't report full path for referenced module as assembly error.
1139 2008-02-12 Marek Safar <marek.safar@gmail.com>
1141 * Makefile: Fixed `qh' target to work on all machines.
1143 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
1144 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
1145 and HasElementType with TypeManager implementation.
1147 2008-02-08 Marek Safar <marek.safar@gmail.com>
1149 A fix for bugs #325134, #359749
1150 * expression.cs, ecore.cs: Try to resolve an extension method even if the
1151 first binds point to non-method member expression.
1153 2008-02-08 Marek Safar <marek.safar@gmail.com>
1155 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
1157 2008-02-08 Marek Safar <marek.safar@gmail.com>
1159 A fix for bugs #321394, #323028
1160 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
1161 Reworked naive IsAccessibleAs implementation to handle nested types.
1163 2008-02-05 Jb Evain <jbevain@novell.com>
1165 * class.cs: use generic type comparison for parameters
1168 2008-02-05 Marek Safar <marek.safar@gmail.com>
1170 A fix for bug #325372
1171 * class.cs: Use generic type comparison when testing method signatures.
1173 2008-02-05 Marek Safar <marek.safar@gmail.com>
1175 A fix for bug #357047
1176 * ecore.cs: Applied C# 3.0 changes to better conversion.
1178 2008-02-05 Marek Safar <marek.safar@gmail.com>
1180 A fix for bug #358374
1181 * cs-parser.jay: Correctly set modifiers for all constructor types.
1183 2008-02-04 Marek Safar <marek.safar@gmail.com>
1185 A fix for bug #355251
1186 * generic.cs: Added base class constraint based type inference.
1188 2008-02-01 Marek Safar <marek.safar@gmail.com>
1190 A fix for bug #357255
1191 * decl.cs: One more missing visibility check.
1193 2008-02-01 Marek Safar <marek.safar@gmail.com>
1195 * support.cs: Fixed broken return.
1197 2008-01-25 Marek Safar <marek.safar@gmail.com>
1199 * report.cs: Correctly reset warnings count after probing.
1201 2008-01-25 Martin Baulig <martin@ximian.com>
1204 (NamespaceEntry.SymbolFileID): Make this work again after
1205 MemberName.ToString() is gone.
1207 2008-01-25 Marek Safar <marek.safar@gmail.com>
1209 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
1212 2008-01-25 Marek Safar <marek.safar@gmail.com>
1214 * generic.cs: Use full implicit conversion for type inference fixing.
1216 2008-01-24 Marek Safar <marek.safar@gmail.com>
1218 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
1219 Fixed user operator conversions.
1221 2008-01-24 Marek Safar <marek.safar@gmail.com>
1223 * generic.cs: Do nullable type to null comparison optimization during
1226 2008-01-24 Marek Safar <marek.safar@gmail.com>
1228 A fix for bug #355163
1229 * generic.cs: Enabled l-value resolve on nullable expressions.
1231 2008-01-24 Marek Safar <marek.safar@gmail.com>
1233 A fix for bug #353986
1234 * class.cs: Ingore static ctors with parameters for any further checks.
1236 2008-01-24 Marek Safar <marek.safar@gmail.com>
1238 A fix for bug #354310
1239 * namespace.cs: Removed redundant check.
1241 2008-01-24 Marek Safar <marek.safar@gmail.com>
1243 A fix for bug #354928
1244 * expression.cs: ElementInitializers can be resolved only once.
1246 2008-01-24 Marek Safar <marek.safar@gmail.com>
1248 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
1249 Condition expressions.
1251 2008-01-23 Marek Safar <marek.safar@gmail.com>
1253 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
1255 2008-01-22 Marek Safar <marek.safar@gmail.com>
1257 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
1260 * generic.cs: Implemented coalesce expression.
1262 2008-01-22 Marek Safar <marek.safar@gmail.com>
1264 A fix for bug #355145
1265 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
1266 expression tree type inference.
1268 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
1271 * expression.cs (Binary.IsUnsignedType): Fix typo.
1273 2008-01-22 Marek Safar <marek.safar@gmail.com>
1275 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
1277 2008-01-22 Marek Safar <marek.safar@gmail.com>
1279 A fix for bug #355161
1280 * ecore.cs, expression.cs: Wider range of extension method supported
1283 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
1285 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
1286 AssemblyBuilder to operate in compiler context. Fixes mcs part of
1289 2008-01-22 Marek Safar <marek.safar@gmail.com>
1291 A fix for bug #355148
1292 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
1294 2008-01-22 Miguel de Icaza <miguel@novell.com>
1296 * expression.cs (CreateExpressionTree): Add support for or and
1297 logical or, and indent following the coding conventions.
1299 * typemanager.cs (LinqExpression): renamed from
1300 ExpressionTreeManager, for a shorter name.
1302 Use TypeManager.CoreLookupType to lookup types from our core
1303 assemblies and turn those into "Type" variables.
1305 Consumers that previously used "Namespace" and "Type" from this
1306 class should instead use the TypeExpression which is a type that
1307 is fully resolved (without involving the regular C# resolution
1310 This typically looks like this:
1312 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
1313 new MemberAccess (texpr, name, type_arguments, loc)
1315 This avoids the problem in: #355178
1317 2008-01-21 Marek Safar <marek.safar@gmail.com>
1319 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
1320 feature in parser only as we do in other cases.
1322 2008-01-21 Marek Safar <marek.safar@gmail.com>
1324 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
1325 typemanager.cs: A refactoring of params arguments to reuse existing
1326 expressions (params -> array initializer) to emit params argument instead
1327 of specialized handling.
1328 It was required by expression tree implementation and it has other benefits
1329 as well, we now apply same optimization for params arguments as we do for
1332 2008-01-18 Marek Safar <marek.safar@gmail.com>
1334 A fix for bug #353526
1335 * generic.cs: A type inference of params arguments may not required any
1336 temporary array creation.
1338 2008-01-18 Marek Safar <marek.safar@gmail.com>
1340 A fix for bug #353534
1341 * generic.cs, ecore.cs, expression.cs: A method group type inference is
1342 supported for delegates only.
1344 2008-01-18 Marek Safar <marek.safar@gmail.com>
1346 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
1347 type for more than 1 candidates.
1349 2008-01-18 Marek Safar <marek.safar@gmail.com>
1351 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
1354 2008-01-16 Marek Safar <marek.safar@gmail.com>
1356 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
1357 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
1358 operator) expressions.
1360 2008-01-16 Zoltan Varga <vargaz@gmail.com>
1362 * statement.cs: Avoid declaring an IL variable for this_variable since it is
1363 not accessed from the generated IL.
1365 2008-01-14 Marek Safar <marek.safar@gmail.com>
1367 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
1368 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
1369 statement.cs: The first expression tree implementation drop, mostly
1370 infrastructure work.
1372 2008-01-14 Marek Safar <marek.safar@gmail.com>
1374 * ecore.cs (IsNestedChild): Refactored.
1376 2008-01-11 Marek Safar <marek.safar@gmail.com>
1378 * lambda.cs: Don't use a cast on unknown expression statement.
1380 2008-01-10 Geoff Norton <gnorton@novell.com>
1382 * cs-tokenizer.cs: One more token to distinguish between method and lambda
1385 2008-01-09 Marek Safar <marek.safar@gmail.com>
1387 * doc.cs: Report better /doc crash details.
1389 2008-01-09 Marek Safar <marek.safar@gmail.com>
1391 A fix for bug #352536
1392 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
1394 2008-01-08 Marek Safar <marek.safar@gmail.com>
1396 A fix for bug #352287
1397 * ecore.cs, expression.cs: Do `this' access checking in all member access
1400 2008-01-08 Marek Safar <marek.safar@gmail.com>
1402 * rootcontext.cs, driver.cs: Switch to linq mode by default.
1404 * report.cs: Reset message stacks.
1406 2008-01-08 Marek Safar <marek.safar@gmail.com>
1408 * generic.cs (InferInPhases): Correctly calculate params position.
1410 2008-01-08 Marek Safar <marek.safar@gmail.com>
1412 * cs-tokenizer.cs: No need to parse full string when parsing lambda
1415 2008-01-07 Marek Safar <marek.safar@gmail.com>
1417 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
1419 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
1421 * driver.cs: Updated --help option.
1423 2008-01-07 Marek Safar <marek.safar@gmail.com>
1425 * generic.cs (InferParamsTypeArguments): Removed.
1426 (InferInPhases): Add params type inference.
1427 (LowerBoundInference): Fixed scoring mechanism.
1429 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
1431 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
1433 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
1434 byte array for unsigned "baked" assemblies.
1436 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
1438 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
1439 array for assemblies that are not strongnamed.
1441 2008-01-04 Marek Safar <marek.safar@gmail.com>
1443 A fix for bug #351481
1444 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
1445 declaring type for nested generic types.
1447 2008-01-04 Marek Safar <marek.safar@gmail.com>
1449 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
1450 instead of ToString.
1452 2008-01-03 Marek Safar <marek.safar@gmail.com>
1454 A fix for bug #351047
1455 * expression.cs (Binary.ResolveOperator): Allow equality operators between
1456 null and structs only when equality and inequality operators are defined
1457 either as an user-operators or predefined operators.
1459 2008-01-03 Marek Safar <marek.safar@gmail.com>
1461 A fix for bug #351047
1462 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
1464 2008-01-03 Marek Safar <marek.safar@gmail.com>
1466 A fix for bug #351257
1467 * cs-tokenizer.cs: Advance line number for '\r' correctly.
1469 2008-01-03 Marek Safar <marek.safar@gmail.com>
1471 A fix for bug #351157
1472 * class.cs (Using): Fixed yet another broken cloning.
1474 (Block): Put back more sensible default value for statements.
1476 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
1478 * codegen.cs: Allow AssemblyVersion with only major version component.
1481 2007-12-29 Marek Safar <marek.safar@gmail.com>
1483 A fix for bug #324654
1484 * class.cs: Use FullName property as member name.
1486 2007-12-28 Marek Safar <marek.safar@gmail.com>
1488 A fix for bug #342117
1489 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
1490 constructor constraint.
1492 2007-12-28 Marek Safar <marek.safar@gmail.com>
1494 A fix for bug #338273
1495 * class.cs (ProbertyBase): Access modifier checks are required for overrides
1498 2007-12-28 Marek Safar <marek.safar@gmail.com>
1500 A fix for bug #350839
1501 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
1503 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1505 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1508 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1510 * statement.cs: Changed some Hashtables to use HybridDictionaries
1511 instead. It was observed that some HashTables only contained a few
1512 items in the vast majority of cases. Since HybridDictionary is
1513 more efficient on small sets (<10 elements), "known_variables"
1514 from class ExplicitBlock as well as "labels" and "constants " from
1515 class Block were changed to HybridDictionaries.
1517 Atsai results: (56216kb->54987kb)
1519 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
1522 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1524 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1527 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1529 * expression.cs: foreach loop to for loop, saved on allocation of
1530 enumerator (59333kb->59141kb)
1532 * statement.cs. Changed foreach loops to for loops, saved on
1533 allocation of enumerator (59141kb->59006kb)
1535 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
1536 when constructed with no specified capacity. This was causing a
1537 few ArrayLists to allocate more memory than they would potentially
1538 need in the Block class and MemberCache class. Setting the
1539 ArrayLists to construct with a capacity of 1 saves some
1540 memory. (56216kb->55585kb)
1542 2007-12-27 Marek Safar <marek.safar@gmail.com>
1544 A fix for bug #347189 (2nd issue)
1545 * expression.cs (MemberAccess): Nested type can be found in base non-generic
1548 2007-12-27 Miguel de Icaza <miguel@novell.com>
1550 * report.cs: Do not use colors if stdout and stderr are not a
1553 2007-12-27 Marek Safar <marek.safar@gmail.com>
1555 A fix for bug #346998
1556 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
1559 2007-12-27 Marek Safar <marek.safar@gmail.com>
1561 A fix for bug #343465
1562 * class.cs: Explicit method name for nested types uses dots only.
1564 2007-12-27 Marek Safar <marek.safar@gmail.com>
1566 A fix for bug #343707
1567 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
1569 2007-12-27 Marek Safar <marek.safar@gmail.com>
1571 * ecore.cs: Report type inference errors only when arguments count matches
1574 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
1576 * expression.cs, report.cs: New warning.
1578 * typemanager.cs: Catch anonymous method type too.
1580 2007-12-23 Marek Safar <marek.safar@gmail.com>
1582 A fix for bug #346379
1583 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
1585 2007-12-23 Marek Safar <marek.safar@gmail.com>
1587 A fix for bug #347359
1588 * expression.cs (Invocation): Don't resolve already resolved expression.
1590 2007-12-23 Marek Safar <marek.safar@gmail.com>
1592 A fix for bug #347189
1593 * class.cs (FixedField): Use non-dependent code only in the define phase.
1595 2007-12-23 Marek Safar <marek.safar@gmail.com>
1597 A fix for bug #348076
1598 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
1600 2007-12-22 Marek Safar <marek.safar@gmail.com>
1602 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
1603 discovered extension methods.
1605 2007-12-22 Marek Safar <marek.safar@gmail.com>
1607 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
1610 2007-12-21 Miguel de Icaza <miguel@novell.com>
1612 * report.cs (ErrorMessage): Add support for using colors on
1613 terminals that support it.
1615 2007-12-21 Marek Safar <marek.safar@gmail.com>
1617 * ecore.cs: Use information about expanded params for error reporting.
1619 2007-12-21 Marek Safar <marek.safar@gmail.com>
1621 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
1622 and logic for params overloads.
1624 2007-12-15 Miguel de Icaza <miguel@novell.com>
1626 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
1627 as this is also created from the parser. Fixes #349034
1629 2007-12-12 Miguel de Icaza <miguel@novell.com>
1631 * statement.cs (Throw.CloneTo): it is valid to have empty
1632 expressions for throw.
1634 2007-12-03 Marek Safar <marek.safar@gmail.com>
1636 * cs-parser.jay: Set delegate constraint parsing region correctly.
1638 2007-12-03 Marek Safar <marek.safar@gmail.com>
1640 A fix for bug #345467
1641 * typemanager.cs (IsEqual): Compare generic parameters position only.
1643 2007-11-28 Marek Safar <marek.safar@gmail.com>
1645 * expression.cs (BaseAccess): Type arguments can be null.
1647 2007-11-27 Raja R Harinath <harinath@gmail.com>
1649 * statement.cs (Block.Resolve): Ensure flow-branching tree is
1650 consistent even when an error has occured.
1651 (Switch.Resolve): Likewise.
1653 2007-11-22 Marek Safar <marek.safar@gmail.com>
1655 A fix for bug #334505
1656 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
1659 2007-11-22 Marek Safar <marek.safar@gmail.com>
1661 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
1662 refactorings required to resolve extension methods correctly when mixing
1663 generics and non-generics members.
1665 2007-11-20 Marek Safar <marek.safar@gmail.com>
1667 A fix for bug #342584
1668 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
1671 2007-11-19 Marek Safar <marek.safar@gmail.com>
1673 A fix for bug #342512
1674 * delegate.cs: Use delegate argument expression when is available. Don't
1675 emit virtual call when class is sealed.
1677 2007-11-16 Marek Safar <marek.safar@gmail.com>
1679 A fix for bug #325423
1680 * assign.cs (FieldInitializer): Use resolved expression for emit.
1682 * class.cs: Print less confusing error message.
1684 2007-11-16 Marek Safar <marek.safar@gmail.com>
1686 * cs-tokenizer.cs: Removed GMCS ifdefs.
1688 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
1691 * cs-parser.jay: Disabled nullable check.
1693 * generic-mcs: Copied more generic stuff.
1695 2007-11-16 Marek Safar <marek.safar@gmail.com>
1697 * gcs-parser.jay: Merged to cs-parser.jay.
1699 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
1700 * *.csproj, *.sources: Updated to use only jay parser file.
1702 2007-11-16 Marek Safar <marek.safar@gmail.com>
1704 * gcs-parser.jay: Added nullable and default expression feature checks.
1706 2007-11-16 Marek Safar <marek.safar@gmail.com>
1708 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
1709 it fixes many TODOs and hidden bugs.
1711 * expression: Removed duplicate error check.
1713 2007-11-15 Marek Safar <marek.safar@gmail.com>
1715 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
1716 implicitly type local variable only when it is used in a declaration.
1718 2007-11-15 Marek Safar <marek.safar@gmail.com>
1720 * attribute.cs: Use CS0612 for empty strings.
1722 2007-11-14 Marek Safar <marek.safar@gmail.com>
1724 * lambda.cs, statement.cs: Contextual return may act as a statement.
1726 2007-11-14 Marek Safar <marek.safar@gmail.com>
1728 A fix for a regression cause by #324222
1729 * class.cs: Don't report unused even when it implements an interface.
1731 2007-11-13 Marek Safar <marek.safar@gmail.com>
1733 A fix for bug #341205
1734 * ecore.cs, expression.cs: Method group expression cannot do static
1735 method access with an instance reference check before overloading takes
1738 2007-11-13 Marek Safar <marek.safar@gmail.com>
1740 A fix for bug #325359
1741 * class.cs: Use predictable name for automatically generated property.
1743 2007-11-12 Marek Safar <marek.safar@gmail.com>
1745 A fix for bug #324996
1746 * expression.cs (Is): Handle case where D is nullable and T is not
1749 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
1751 2007-11-12 Marek Safar <marek.safar@gmail.com>
1753 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
1754 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
1755 Flush small error reporting changes.
1757 2007-11-09 Marek Safar <marek.safar@gmail.com>
1759 A fix for bug #324996
1760 * expression.cs: Rewrote Is expression implementation to work with
1761 generics, nullable types, anonymous method. A const result expression
1762 uses existing infrastructure instead of custom not fully-featured one.
1764 2007-11-08 Marek Safar <marek.safar@gmail.com>
1766 A fix for bug #340202
1767 * class.cs: Consider generics for volatile field.
1769 2007-11-08 Marek Safar <marek.safar@gmail.com>
1771 A fix for bug #335594
1772 * expression.cs: Use conversion rules when handling string addition.
1774 2007-11-07 Marek Safar <marek.safar@gmail.com>
1776 A fix for bug #336651
1777 * expression.cs: Fixed a crash when probing is on.
1779 2007-11-07 Marek Safar <marek.safar@gmail.com>
1781 A fix for bug #324242
1782 * covert.cs: Added a conversion from any nullable-type with an
1783 underlying enum-type to the type System.Enum.
1785 2007-11-07 Marek Safar <marek.safar@gmail.com>
1787 A fix for bug #324222
1788 * class.cs: Report all non-used event fields.
1790 2007-11-07 Marek Safar <marek.safar@gmail.com>
1792 A fix for bug #325161
1793 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
1794 qualifier for generic types.
1796 2007-11-07 Marek Safar <marek.safar@gmail.com>
1798 A fix for bug #322971
1799 * expression.cs, ecore.cs: Added intermediate result value check for
1802 2007-11-07 Marek Safar <marek.safar@gmail.com>
1804 A fix for bug #324754
1805 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
1806 when it was requested.
1808 2007-11-07 Marek Safar <marek.safar@gmail.com>
1810 A fix for bug #325101
1811 * expression.cs: Do type not value comparison for `is' expression.
1813 2007-11-07 Marek Safar <marek.safar@gmail.com>
1815 A fix for bug #320236
1816 * convert.cs: Don't apply user conversion on underlying target type.
1818 2007-11-06 Marek Safar <marek.safar@gmail.com>
1820 * expression.cs: Don't use unresolved expression for error reporting.
1822 2007-11-06 Marek Safar <marek.safar@gmail.com>
1824 A fix for bugs #337712, #324490
1825 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
1826 overloading resolution too.
1828 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
1829 the process consistent and more robust.
1831 * expression.cs, linq.cs, report.cs: Update.
1833 2007-11-02 Marek Safar <marek.safar@gmail.com>
1835 A fix for bug #332909
1836 * attribute.cs: Resolve attributes in correct context using error
1839 * rootcontext.cs: Define Obsolete attribute members as core members.
1841 2007-11-02 Marek Safar <marek.safar@gmail.com>
1843 * statement.cs: Removed unused methods.
1845 2007-10-31 Wade Berrier <wberrier@novell.com>
1847 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
1848 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
1851 2007-10-31 Marek Safar <marek.safar@gmail.com>
1853 A fix for bug #338102
1854 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
1855 methods registered as non-generics.
1857 2007-10-31 Marek Safar <marek.safar@gmail.com>
1859 A fix for bugs #337712, #324490
1860 * delegate.cs: Delegate covariance and contravariance is not allowed for
1863 2007-10-31 Marek Safar <marek.safar@gmail.com>
1865 A fix for bug #337719
1866 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
1869 2007-10-30 Marek Safar <marek.safar@gmail.com>
1871 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
1873 2007-10-29 Marek Safar <marek.safar@gmail.com>
1875 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
1878 2007-10-29 Raja R Harinath <rharinath@novell.com>
1880 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
1882 2007-10-29 Marek Safar <marek.safar@gmail.com>
1884 A fix for bug #334652
1885 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
1886 extension methods when we have not found the best candidate in normal
1889 2007-10-27 Marek Safar <marek.safar@gmail.com>
1891 * AssemblyInfo.cs: Keep up-to-date.
1893 2007-10-27 Marek Safar <marek.safar@gmail.com>
1895 * Makefile: Fixed generics compiler name.
1897 2007-10-27 Marek Safar <marek.safar@gmail.com>
1899 * lambda.test: removed, lambda parsing is done differently.
1901 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
1903 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
1905 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
1907 2007-10-27 Marek Safar <marek.safar@gmail.com>
1909 * Makefile, *.sources : All C# compilers are in mcs folder.
1911 * *.cs: Use existing 2_1 define for smcs.
1913 2007-10-26 Marek Safar <marek.safar@gmail.com>
1915 A fix for bug #335847
1916 * assign.cs, expression.cs: Couple of changes to avoid creating a
1917 temporary variable for each object initializer assignment statement. It
1918 simplifies struct initialization too, otherwise two temporary variables
1920 Implemented optimization of redundant default element initializers.
1922 2007-10-25 Marek Safar <marek.safar@gmail.com>
1924 A fix for bug #336766
1925 * expression.cs (Class.CheckBase): Use generic name when method is
1928 2007-10-25 Marek Safar <marek.safar@gmail.com>
1930 A fix for bug #334737
1931 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
1932 variable and not variable argument for prepared copies.
1934 2007-10-24 Marek Safar <marek.safar@gmail.com>
1936 A fix for bug #325110
1937 * class.cs, expression.cs, attribute.cs: Use open generic method when
1938 checking conditional attribute.
1940 2007-10-24 Marek Safar <marek.safar@gmail.com>
1942 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
1943 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
1944 FeatureIsNotAvailable.
1946 2007-10-24 Marek Safar <marek.safar@gmail.com>
1948 ** C# 3.0 Partial methods
1950 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
1951 methods support. Because of member cache issue with generics only
1952 non-generics partial methods are fully supported.
1954 2007-10-23 Marek Safar <marek.safar@gmail.com>
1956 * class.cs, decl.cs: Rewrote member overloads check to cope with
1957 generics and to use member cache for member checking. It also improves
1958 performance and fixes remaining overloads issues.
1960 2007-10-20 Marek Safar <marek.safar@gmail.com>
1962 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
1963 roottypes.cs, typemanager.cs:
1965 A member cache creation logic changed to add members immediately and
1966 not rely on fallback. The member cache is now only prefered way
1967 how to access and find type declaration members. It saves 5 MB of memory
1968 during MWF compilation and makes code ready for more optimizations and
1969 clean-ups, it's also a pre-requirement for partial methods.
1971 2007-10-18 Raja R Harinath <harinath@gmail.com>
1973 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
1974 handling for generic parameters.
1976 2007-10-15 Marek Safar <marek.safar@gmail.com>
1978 * class.cs (FixedField): Removed redundant volatile check.
1980 2007-10-15 Marek Safar <marek.safar@gmail.com>
1982 * class.cs, decl.cs: Fixed overload members verification to do only one
1983 check per possible collision.
1985 2007-10-13 Marek Safar <marek.safar@gmail.com>
1987 A fix for bug #325478
1988 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
1989 and create only one disposable flags container.
1991 2007-10-12 Marek Safar <marek.safar@gmail.com>
1993 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
1994 * statement.cs (Fixed): Fixed variables cloning.
1996 2007-10-12 Marek Safar <marek.safar@gmail.com>
1998 A fix for bug #333342
1999 * class.cs (EventField): Don't mark value type event as synchronized.
2001 2007-10-12 Marek Safar <marek.safar@gmail.com>
2003 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
2004 inference to identify best candidate method correctly.
2005 (ProperyExpr): A range variable is read only and cannot be modified.
2007 2007-10-11 Marek Safar <marek.safar@gmail.com>
2009 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
2010 logic to identify best candidate method correctly.
2012 2007-10-11 Marek Safar <marek.safar@gmail.com>
2014 * location.cs (Equals, GetHashCode): Removed.
2016 2007-10-11 Marek Safar <marek.safar@gmail.com>
2018 * report.cs: Implemented message recorder. It is used mainly for lambda
2019 expressions to capture otherwise swallowed error messages.
2021 * anonymous.cs, lambda.cs.cs: Do full parameters check.
2023 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
2025 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
2027 * expression.cs (MemberAccess): Always report lookup failure.
2029 * location.cs: Implemented Equals, GetHashCode.
2031 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
2033 2007-10-10 Jb Evain <jbevain@novell.com>
2035 * codegen.cs: re-enable assembly version check.
2037 2007-10-09 Marek Safar <marek.safar@gmail.com>
2039 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
2042 * namespace.cs (UsingAlias): Do correct version check.
2044 2007-10-08 Marek Safar <marek.safar@gmail.com>
2046 * expresison.cs, ecore.cs: Issue extension method error message when
2049 * rootcontext.cs: Added ISO_2 compiler mode option.
2051 2007-10-08 Marek Safar <marek.safar@gmail.com>
2053 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
2056 2007-10-08 Marek Safar <marek.safar@gmail.com>
2058 * attribute.cs (GetString, GetBoolean): Work with both literal and
2061 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
2062 Moved method overload specific methods to MethodGroupExpr.
2064 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
2065 it should be less memory consuming.
2067 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
2069 * codegen.cs: remove the assembly version check until the buildbot is
2072 2007-10-07 Jb Evain <jbevain@novell.com>
2074 * attribute.cs (Attribute.GetString): if the value
2075 expression is a StringConstant, return its string value.
2077 2007-10-07 Jb Evain <jbevain@novell.com>
2079 * typemanager.cs: add `assembly_version_attribute_type`.
2080 * codegen.cs: on attribute emission, check that the
2081 AssemblyVersionAttribute doesn't overflow.
2083 2007-10-05 Marek Safar <marek.safar@gmail.com>
2085 A fix for bug #324677
2086 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
2087 parent container of a scope container with currently resolved one.
2089 2007-10-05 Marek Safar <marek.safar@gmail.com>
2091 A fix for bug #325534
2092 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
2095 2007-10-05 Marek Safar <marek.safar@gmail.com>
2097 A fix for bug #327504
2098 * class.cs (Operator.Define): Refactored implicit and explicit user
2099 operator conversion rules.
2101 2007-10-05 Marek Safar <marek.safar@gmail.com>
2103 A fix for bug #327520
2104 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
2106 2007-10-04 Marek Safar <marek.safar@gmail.com>
2108 A fix for bug #328022
2109 * class.cs (MethodData.Define): Use correct method to check whether
2110 a method implementents an accessor.
2112 2007-10-04 Marek Safar <marek.safar@gmail.com>
2114 A fix for bug #330069
2115 * statement.cs (Fixed.Resolve): Read the first array element only when
2116 an array is instantiated.
2118 2007-10-04 Marek Safar <marek.safar@gmail.com>
2120 * expression.cs, assign.cs, generics.cs: Print correct operator when
2121 compound assignment is used.
2123 2007-10-04 Marek Safar <marek.safar@gmail.com>
2125 A fix for bug #325841
2126 * expression.cs (ArrayAccess): Use full argument cloning only for
2127 string compound concatenation.
2129 2007-10-03 Marek Safar <marek.safar@gmail.com>
2131 A fix for bug #328774
2132 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
2134 (PropertyExpr.EmitAssign): Fixed string concatenation compound
2137 2007-10-03 Raja R Harinath <rharinath@novell.com>
2140 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
2141 Event accessibility checks here. Remove some bogus code that
2142 accidently made GenericMethods work.
2143 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
2145 2007-09-25 Marek Safar <marek.safar@gmail.com>
2147 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
2149 * statement.cs (Block): Refactored AddVariable to allow error handling
2152 * generic.cs: New stub.
2154 2007-09-23 Marek Safar <marek.safar@gmail.com>
2156 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
2159 2007-09-17 Marek Safar <marek.safar@gmail.com>
2161 * class.cs: Use partial container to record whether any partial part
2162 contains static field initializer and therefore default contructor has
2165 2007-09-14 Marek Safar <marek.safar@gmail.com>
2167 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
2168 mono-list when only one of two partial parts has defined accessibility
2171 2007-09-14 Marek Safar <marek.safar@gmail.com>
2173 A fix for bug #82845
2175 * class.cs (TypeContainer): Set correct resolve context for all field
2178 2007-09-13 Marek Safar <marek.safar@gmail.com>
2180 * assign.cs: Fixed a crash when field is resolved twice with an error.
2182 * codegen.cs: Changed InFieldInitializer to be flag.
2184 * anonymous.cs, ecore.cs, expression.cs: Update after
2185 IsInFieldInitializer rename.
2187 * const.cs: Removed unused parameter.
2189 * class.cs: Changed the way how we resolve and emit field initializers.
2190 The field initilizers have to have access to contructor block to emit
2191 compiler generated code.
2193 2007-09-13 Marek Safar <marek.safar@gmail.com>
2195 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
2196 generics use TypeContainer instead.
2198 2007-09-12 Marek Safar <marek.safar@gmail.com>
2200 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
2202 * lambda.cs (ResolveParameters): Use more powerful
2203 InflateGenericArgument.
2205 * parameters.cs: Better exception message.
2207 2007-09-10 Marek Safar <marek.safar@gmail.com>
2209 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
2210 correct expression block type.
2212 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
2214 * expression.cs (Invocation): Extracted method group resolve to
2217 2007-09-07 Marek Safar <marek.safar@gmail.com>
2219 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
2220 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
2222 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
2223 generic extension methods.
2225 2007-09-06 Marek Safar <marek.safar@gmail.com>
2227 A fix for bug #82676 (Do I get it right now?)
2228 * convert.cs (Binary.ResolveOperator): An interface is converted to the
2229 object before a standard conversion is applied.
2231 2007-09-06 Marek Safar <marek.safar@gmail.com>
2233 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
2236 2007-09-05 Marek Safar <marek.safar@gmail.com>
2238 A fix for bug #82676
2239 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
2240 non-generic interface types.
2242 2007-09-05 Marek Safar <marek.safar@gmail.com>
2244 A fix for bug #82690
2245 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
2247 2007-09-05 Marek Safar <marek.safar@gmail.com>
2249 A fix for bug #82571
2250 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
2251 modifier for container based methods.
2253 2007-09-05 Marek Safar <marek.safar@gmail.com>
2255 A fix for bug #82676
2256 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
2257 any interface-type T means to any of interface type T.
2259 2007-09-04 Marek Safar <marek.safar@gmail.com>
2261 * namespace.cs: We have 2 versions of System.Core assembly.
2263 2007-09-04 Marek Safar <marek.safar@gmail.com>
2265 A fix for bug #82652
2266 * class.cs (Class.GetClassBases): Compare types and not expressions.
2268 2007-09-04 Marek Safar <marek.safar@gmail.com>
2270 A fix for bug #82620
2271 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
2272 actually never worked before.
2273 (IndexerAccess): Emit prepared arguments before they are modified.
2275 2007-09-04 Marek Safar <marek.safar@gmail.com>
2277 A fix for bug #82563
2278 * assign.cs: Revert wrong fix.
2280 * expression.cs (VariableReference.EmitAssign): Handle ref reference
2282 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
2283 Instead of ldelema/stdind we have to use temporary variables to handle
2284 cases like String.Concat (params string[]).
2286 2007-08-31 Marek Safar <marek.safar@gmail.com>
2288 * class.cs: EmitAttributes to Emit rename.
2290 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
2292 (MemberCore.HasClsCompliantAttribute): Don't depend on
2293 GetClsCompliantAttributeValue execution.
2295 2007-08-31 Marek Safar <marek.safar@gmail.com>
2297 * anonymous.cs: Use shorter type prefix.
2299 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
2302 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
2303 variables when probing is on.
2305 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
2306 unresolved variables.
2307 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
2308 handle transparent identifiers.
2310 2007-08-26 Marek Safar <marek.safar@gmail.com>
2312 * attribute.cs (IsClsCompliant): Add nullable types test.
2314 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
2316 * doc.cs : catch other types of exception than XmlException to
2317 report CS1570. Fixed bug #82565.
2319 2007-08-23 Marek Safar <marek.safar@gmail.com>
2321 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
2322 The number of delegate parameters has to match.
2323 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
2326 2007-08-21 Marek Safar <marek.safar@gmail.com>
2328 * anonymous.cs (AnonymousMethod): Generate private anonymous method
2329 to fix problem with private arguments.
2331 2007-08-20 Marek Safar <marek.safar@gmail.com>
2333 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
2335 * decl.cs (MemberName): Ignore generic type with no generic arguments.
2337 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
2338 empty. Add cloning suport.
2340 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
2342 2007-08-20 Marek Safar <marek.safar@gmail.com>
2344 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
2345 to create EmptyCast. It handles EmptyConstantCast specialization for
2348 2007-08-18 Marek Safar <marek.safar@gmail.com>
2350 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
2351 (EmitArrayArgument): One routine for array arguments.
2352 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
2354 2007-08-17 Marek Safar <marek.safar@gmail.com>
2356 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
2358 2007-08-17 Marek Safar <marek.safar@gmail.com>
2360 * anonymous.cs: MemberLookupFinal update.
2362 * class.cs (ConstructorInitializer): Is expression based.
2364 * delegate.cs: MethodGroupExpr update.
2366 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
2368 (Error_MemberLookupFailed): Customizable error override.
2369 (MethodGroupExpr): Keep queried type for later usage.
2370 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
2373 * expression.cs: Error_MemberLookupFailed refactoring.
2374 (New.DoResolve): Resolve as much as possible.
2375 (ElementInitializer.Error_MemberLookupFailed): Object initializer
2376 customization for invalid member types.
2378 * statement.cs: MethodGroupExpr update.
2380 2007-08-16 Marek Safar <marek.safar@gmail.com>
2382 * modifier.cs (Check): Check all modifiers and not only accessibility
2385 2007-08-16 Marek Safar <marek.safar@gmail.com>
2387 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
2388 type and not an expression.
2390 2007-08-16 Marek Safar <marek.safar@gmail.com>
2392 * statement.cs (Catch.Clone): Type and variable can be null.
2394 2007-08-16 Marek Safar <marek.safar@gmail.com>
2396 A fix for bug #81979
2397 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
2398 I am really not sure whether this is the best fix.
2400 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
2403 2007-08-14 Marek Safar <marek.safar@gmail.com>
2405 ** C# 3.0 Object and collection initializers (major re-write)
2407 * assign.cs (DoResolve): Initializers are not assign related.
2409 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
2410 used during collection or object initialization.
2412 * expression.cs (Error_InvalidArguments): Add initializers specific
2413 messages. More will come later because it requires some general
2415 (New.DoResolve): Better error handling for unsafe types.
2416 (EmptyExpressionStatement): New class.
2417 (ElementInitializer): An object initializer expression.
2418 (CollectionElementInitializer): A collection initializer expression.
2419 (CollectionOrObjectInitializers): A block of object or collection
2421 (NewInitialize): New expression with element/object initializers.
2423 * statement.cs: Reverted object/collection initializer hacks.
2425 * typemanager.cs (CSharpName): Filter __arglist type.
2427 2007-08-09 Marek Safar <marek.safar@gmail.com>
2429 ** C# 3.0 Anonymous Types (update to the latest standard)
2431 * expression.cs (Binary.ResolveOperator): Threat all null based types
2433 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
2434 (AnonymousTypeParameter): Updated.
2436 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
2437 (AnonymousTypeClass): New anonymous type container.
2439 * class.cs (AddField): Return operation result.
2441 * generic.cs: Another empty TypeArguments overload.
2443 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
2444 are stored at top of normal hierarchy.
2446 * typemanager.cs (CSharpName): Filter anonymous types.
2448 2007-08-09 Marek Safar <marek.safar@gmail.com>
2450 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
2451 as single Concat call. How could we miss that :-(
2453 2007-08-08 Marek Safar <marek.safar@gmail.com>
2455 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
2457 2007-08-07 Miguel de Icaza <miguel@novell.com>
2459 * expression.cs: Fix the previous commit, the creation of the
2460 arguments array list needs also to be conditional on the arguments
2463 * class.cs: Add a little bit of help to help narrow down problems.
2465 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
2466 not try to copy in that case.
2468 * driver.cs: When building SMCS, include a new different set of
2469 default assemblies here. Do this here so we can control whether
2470 to include the default assemblies with /noconfig.
2472 2007-08-03 Marek Safar <marek.safar@gmail.com>
2474 A fix for bug #81979
2475 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
2478 2007-08-03 Marek Safar <marek.safar@gmail.com>
2480 A fix for bug #82300
2482 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
2483 we are in probing scope.
2485 2007-08-03 Marek Safar <marek.safar@gmail.com>
2487 A fix for bug #82301
2489 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
2490 (Statement.CloneTo): Clone and not map children blocks.
2492 2007-08-03 Marek Safar <marek.safar@gmail.com>
2494 A fix for bug #82299
2496 * expression.cs (LocalVariableReference.CloneTo): Remap local info
2499 * statement.cs (Statement.CloneTo): Clone variables before statements
2500 to allow remaping of local variables.
2502 2007-08-03 Marek Safar <marek.safar@gmail.com>
2504 A fix for bug #82296
2507 * report.cs: Log crash details for future clone problems.
2509 * statement.cs (Return.Clone): Don't clone non-existent expression.
2511 2007-08-03 Raja R Harinath <harinath@gmail.com>
2513 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
2514 (Class.AddBasesForPart): Move CS0537 check here from ...
2515 * cs-parser.jay (class_declaration): ... here. Move calling of
2516 'AddBasesForPart' to ...
2517 (class_bases): ... here.
2518 (struct_declaration, interface_declaration): Update to changes.
2520 2007-08-02 Marek Safar <marek.safar@gmail.com>
2522 A fix for bug #81923
2524 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
2525 conversion is allowed.
2527 2007-08-02 Marek Safar <marek.safar@gmail.com>
2529 A fix for bug #81564
2531 * ecore.cs (EventExpr): Add IsBase handling.
2533 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
2536 2007-08-02 Raja R Harinath <harinath@gmail.com>
2538 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
2539 * cs-parser.jay: Some whitespace cleanups.
2540 (current_delegate): New.
2542 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
2543 a dummy code block, and use 'type_name' instead of 'member_name'.
2544 (interface_declaration, class_declaration): Likewise.
2545 (delegate_declaration): Likewise. Rearrange slightly and use
2547 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
2548 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
2550 2007-08-02 Marek Safar <marek.safar@gmail.com>
2552 A fix for bug #82039
2554 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
2557 * typemanager.cs (CSharpName): Split to string overload.
2559 2007-08-02 Marek Safar <marek.safar@gmail.com>
2562 * report.cs: Updated warning CS0472.
2564 2007-08-01 Marek Safar <marek.safar@gmail.com>
2566 A fix for bug #82181
2568 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
2570 2007-08-01 Marek Safar <marek.safar@gmail.com>
2572 A fix for bug #82277
2573 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
2575 2007-08-01 Marek Safar <marek.safar@gmail.com>
2577 ** C# 3.0 Type Inference (major bits are working)
2579 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
2580 (.ImplicitStandardConversionExists): Uses compatible.
2581 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
2582 (.InferReturnType): New method.
2583 (.Compatible): Refactored.
2584 (.ResolveParameters): Uses factory to create resolved parameters.
2585 (.CompatibleMethod): Add probing mode support.
2586 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
2587 clearly distinguish between 2 different operations.
2588 (LambdaMethod): Moved to lambda.cs.
2589 (AnonymousMethod): Removed unused fields and methods.
2590 (AnonymousDelegate): Simplified.
2592 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
2594 * convert. cs (ImplicitConversionStandard): Compatible works differently.
2596 * delegate.cs (Delegate): New mehods to reduce code duplication.
2597 (.GetConstructor): New method.
2598 (.GetInvokeMethod): New method.
2599 (DelegateCreation): Updated.
2601 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
2603 (OverloadResolve): Made probing little bit faster.
2605 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
2608 * generic.cs (TypeInferenceContext): Dummy implementation.
2610 * iterators.cs: Updated after Resolve/Define rename.
2612 * lambda.cs (LambdaExpression)
2613 (.ResolveParameters): Handles both type of arguments and type inference too.
2615 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
2616 (InflateTypes): Updated.
2618 * support.cs (InflateTypes): Changed signature and updated.
2620 * typemanager.cs (LookupMemberCache): Better dynamic type check.
2621 (MemberLookup_FindMembers): More MS tricks.
2622 (GetParameterData): Ditto.
2623 (GetDelegateParameters): Uses quick path for dynamic types.
2625 2007-08-01 Marek Safar <marek.safar@gmail.com>
2627 * class.cs (MethodData.Define): EmitContext is required for generic stuff
2630 2007-07-31 Marek Safar <marek.safar@gmail.com>
2632 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
2635 2007-07-26 Jb Evain <jbevain@novell.com>
2637 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
2638 which takes a boolean 'report_errors', similar to the GetMethod.
2639 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
2640 in .net 2.1, do not report errors here.
2642 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
2643 System.Runtime.CompilerServices.RequiredAttributeAttribute and
2644 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
2647 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
2648 of the type InternalsVisibleToAttribute before the first call
2649 to CoreLookupType which is allowed to fail (third boolean parameter
2650 to true). Because, during the resolution for a type that is not
2651 immediately found, we try to check if the type is not defined in
2652 a friend assembly, and to do so, we need the
2653 InternalVisibleToAttribute.
2655 2007-07-23 Miguel de Icaza <miguel@novell.com>
2657 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
2658 feature that allows structs to be compared against null and inline
2659 the result as true or false.
2661 Notice that the same code is not permitted inside a generic block
2662 of code that would do:
2664 class Foo<T> where T : struct {
2671 It is only allowed if the type of T is not bound (no where
2672 clause). In my opinion, this CSC 2 behavior is broken but people
2673 seem to be using it (IronRuby does, a few bug reports on bugzilla
2674 have it and some people have complained about it).
2676 All of the users that depend on this behavior have code that is
2679 * report.cs (Warning, Error): make these take object arguments,
2680 not strings, as that allows us to take advantage of Format.
2682 2007-07-20 William Holmes <billholmes54@gmail.com>
2684 * decl.cs: Changed MemberName.CountTypeArguments to also check the
2685 Left member variable for the Count.
2686 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
2687 MemberName.CountTypeArguments to avoid a NRE.
2689 This code is contributed under the MIT X11 license
2691 2007-07-18 Marek Safar <marek.safar@gmail.com>
2693 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
2695 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2697 * doc.cs : generic method arguments are written as ``x while generic
2698 type arguments are `x. Combined with the previous change, fixed bug
2701 2007-07-18 Raja R Harinath <rharinath@novell.com>
2704 * expression.cs (Binary.ResolveOperator): When converting
2705 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
2707 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2709 * doc.cs : when T: or whatever x: is specified, it does not really
2710 check the doc comment's syntax correctness. Fixed bug #82006.
2712 2007-07-18 Marek Safar <marek.safar@gmail.com>
2714 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
2715 LambdaExpression better.
2717 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
2719 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
2721 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
2722 as it can be generated.
2724 * expression.cs (Invocation.Error_InvalidArguments): Show correct
2727 * lambda.cs (LambdaExpression): Refactored to share same code with
2728 AnonymousMethodExpression.
2730 2007-07-17 Marek Safar <marek.safar@gmail.com>
2732 * anonymous.cs (MakeName): Include host name for easier debugging.
2733 (LambdaMethod): New class for lambda spcecific stuff.
2735 * attribute.cs: Set EmitContext return type.
2737 * class.cs: Set EmitContext return type.
2739 * codegen.cs (EmitContext): Return type cannot be null to stop messing
2740 with null/void meaning.
2742 * iterators.cs (ContainerType): Implemented.
2744 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
2746 * statement.cs (Return): Updated to lambda expressions.
2747 (Block.CloneTo): Parent can be null.
2749 2007-07-13 Marek Safar <marek.safar@gmail.com>
2751 A fix for bug #81917
2752 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
2754 * class.cs (FixedField): Check whether field is in unsafe scope.
2756 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
2757 (FieldExpr.Emit): Fixed buffers cannot be volatile.
2759 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
2762 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
2764 2007-07-13 Marek Safar <marek.safar@gmail.com>
2766 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
2767 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
2770 2007-07-13 Marek Safar <marek.safar@gmail.com>
2772 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
2774 2007-07-13 Marek Safar <marek.safar@gmail.com>
2776 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
2777 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
2779 * codegen.cs(EmitContext): Add ProbingMode flag.
2781 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
2783 * driver.cs: For now set both warning values.
2785 * ecore.cs (SimpleName): Name is readonly.
2786 (MethodGroup.OverloadResolve): One quick path for probing.
2788 * expression.cs (Unary): Set Oper r/o.
2789 (Binary): Set Oper r/o.
2790 (ParameterReference): Set few instance variables as r/o.
2791 (ParameterReference.DoResolveBase): Don't capture aruments when
2793 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
2794 (Arglist): arguments are private.
2795 (SizeOf): type is private and r/o.
2796 (MemberAccess): arguments are private.
2798 * report.cs: Enhanced reporting on/off capabilities.
2800 * lambda.cs: Uses ec.IsInProbingMode.
2801 (ContextualReturn): Derives from return.
2803 * rootcontext.cs: For now set both warning values.
2805 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
2807 (Return.Resolve): Don't die immediately.
2808 (Block.Resolve): Speed-up probing.
2809 (Block.CloneTo): Clone only child blocks.
2811 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
2813 * iterators.cs: reverted Miguel's latest change (r81925) as it
2814 breaks the build in System.
2816 2007-07-13 Miguel de Icaza <miguel@novell.com>
2818 * iterators.cs (Yield.CheckContext): Check for the iterator type
2819 also here as we can call into Yield even in codepaths that are not
2821 (MethodOrOperator is the only path that was checked).
2823 In addition to the standard check, use a more specific check for
2824 constructors to report a more verbose error.
2826 2007-07-12 Miguel de Icaza <miguel@novell.com>
2828 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
2829 report the warning and continue
2831 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
2832 values on the stack on the call to Emit. Use EmitStatement if
2833 possible, or using Emit + Pop if not possible. Fixes #82064
2835 2007-07-12 Raja R Harinath <rharinath@novell.com>
2837 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
2838 avoid try...finally in some cases.
2840 2007-07-10 Marek Safar <marek.safar@gmail.com>
2842 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
2844 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
2845 instead of method. Re-use standard error handling.
2846 (ConstructorInitializer.Emit): Simplified.
2848 * delegate.cs: Updated after Invocation.EmitCall change.
2850 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
2851 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
2852 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
2853 method and don't permanently changing input arguments.
2854 (MethodGroupExpr): Introduced resolved best_candidate, when method group
2855 is resolved it has one of the candidates is the best one which is later
2856 used to emit. Removed a few unused method.
2857 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
2859 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
2860 (Binary.ResolveOperator): Ditto.
2861 (ConditionalLogicalOperator.DoResolve): Ditto.
2862 (Invocation): Uses method group.
2863 (Invocation.DoResolve): Simplified.
2864 (Invocation.EmitCall): Removed useless is_static.
2865 (Invocation.Emit): Delegate to method group.
2866 (Invocation.EmitStatement): Simplified.
2867 (New): Uses method group.
2868 (MemberAccess.DoResolve): Don't destroy original expression.
2870 * statement.cs (ForEach.Resolve): Use null for no method arguments.
2872 2007-07-04 Marek Safar <marek.safar@gmail.com>
2874 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
2877 * lambda.cs: Add custom error message type.
2879 2007-07-03 Marek Safar <marek.safar@gmail.com>
2881 * lambda.cs: Simplified little bit.
2883 * parameter.cs: Introduced ImplicitLambdaParameter.
2884 (Parameters.CreateFullyResolved): New factory instead of ctor.
2888 * delegate.cs: Updated parameter creation.
2890 2007-07-03 Marek Safar <marek.safar@gmail.com>
2892 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
2895 * generic.cs: Synchronized with gmcs.
2897 2007-07-03 Marek Safar <marek.safar@gmail.com>
2899 * class.cs (Indexer): Check return type as soon as possible.
2901 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
2904 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
2906 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
2908 * parameter.cs (Parameter): Use expression type when it is available.
2910 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
2911 method modifier for the first parameter only.
2913 2007-06-24 Marek Safar <marek.safar@gmail.com>
2915 A fix for bug #81938
2916 * typemanager.cs (ChangeType): Fixed couple of char conversions.
2918 * constant.cs: Tide up an exception message.
2920 2007-06-22 Marek Safar <marek.safar@gmail.com>
2922 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
2923 an uninitialized variable is used.
2925 * expression.cs (LocalVariableReference.DoResolve): Ditto.
2927 2007-06-22 Marek Safar <marek.safar@gmail.com>
2929 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
2930 not found error handling.
2932 * expression.cs (ArrayCreation): Removed redundant fields and little bit
2934 (ArrayCreation.ResolveArrayElement): To be ready to customization.
2935 (ArrayCreation.DoResolve): Simplified.
2936 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
2937 its own resolve process.
2938 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
2940 2007-06-20 Marek Safar <marek.safar@gmail.com>
2942 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
2945 2007-06-20 Marek Safar <marek.safar@gmail.com>
2947 * cs-tokenizer.cs: Removed var related stuff.
2949 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
2950 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
2951 a type and a keyword at same time.
2953 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
2956 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
2957 implicitly typed arrays, more changes will follow.
2959 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
2961 2007-06-19 Marek Safar <marek.safar@gmail.com>
2963 * ecore.cs (VarExpr): Removed Handled field.
2965 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
2966 build-in assign functionality.
2967 (ForEach.Resolve): Removed all implicitly typed local variable code and
2969 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
2970 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
2972 2007-06-18 Marek Safar <marek.safar@gmail.com>
2974 * assign.cs: Removed implicitly typed local variable check.
2976 * expression.cs (LocalVariableReference.DoResolve): Add check for self
2977 referencing implicitly typed local variable.
2978 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
2981 * statement.cs (Fixed): Removed unsupported implicitly typed local
2984 2007-06-15 Marek Safar <marek.safar@gmail.com>
2986 * decl.cs (MemberName): Moved all Unbound stuff to parser.
2988 2007-06-14 Marek Safar <marek.safar@gmail.com>
2990 A fix for bugs #81855 and #76274
2991 * attribute.cs (AttachTo): Always set owner for global attributes to
2994 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
2997 * cs-parser.jay: Assembly and module attributes must precede all other
2998 elements except using clauses and extern alias declarations.
3000 2007-06-13 Marek Safar <marek.safar@gmail.com>
3002 A fix for bug #81748
3004 * expression.cs: More checks for non ISO-1 features.
3006 2007-06-12 Marek Safar <marek.safar@gmail.com>
3008 A fix for bug #81807
3009 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
3010 present inside switch statement and it is required by nullable check.
3012 2007-06-12 Marek Safar <marek.safar@gmail.com>
3014 A fix for bug #81840
3015 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
3016 when type matching fails.
3018 * namespace.cs: Tiny error message change.
3020 2007-06-12 Marek Safar <marek.safar@gmail.com>
3022 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
3023 reporting. Added automatic property check.
3025 * class.cs: Updated after CheckAbstractAndExtern relocation.
3026 (AEventPropertyAccessor.GetSignatureForError): Customized.
3028 2007-06-11 Marek Safar <marek.safar@gmail.com>
3030 * class.cs (DefineBaseTypes): Base type can be undefined.
3032 * ecore.cs (TypeLookup): Minor refactoring.
3033 (DoResolveAsTypeStep): Removed redundant check.
3035 * namespace.cs (Lookup): Removed redundant check.
3037 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
3038 ResolveAsTypeTerminal step.
3039 (BootstrapCorlib_*): Simplified.
3040 (PopulateCoreType): Core types can be now external.
3042 2007-06-07 Marek Safar <marek.safar@gmail.com>
3044 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
3046 (InferTypeArguments): Infers anonymous expression type arguments.
3047 (Compatible): Split to Compatible and InferTypeArguments.
3049 * lambda.cs: Updated.
3051 2007-06-08 Marek Safar <marek.safar@gmail.com>
3053 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
3055 2007-06-07 Raja R Harinath <harinath@gmail.com>
3057 Fix #80477, cs0135-2.cs, cs0135-3.cs
3058 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
3059 names to the "known" variables list.
3060 (Block.CheckInvariantMeaningInBlock): Handle the fact the
3061 parameter names are also "known".
3062 (Block.CheckError136): Remove.
3063 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
3066 2007-06-07 Marek Safar <marek.safar@gmail.com>
3068 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
3070 2007-06-06 Marek Safar <marek.safar@gmail.com>
3072 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
3073 internal error not an user error.
3075 * expression.cs (IsApplicable): Refactored to make debugging easier.
3077 * support.cs: More tricks for non-mono runtimes.
3079 * typemanager.cs (CoreLookupType): Made public.
3080 (InitSystemCore): All linq specific stuff moved to linq.cs
3082 2007-06-05 Marek Safar <marek.safar@gmail.com>
3084 * typemanager.cs (CSharpSignature): One more missing build-in types
3086 More tricks for non-mono runtime.
3088 2007-06-05 Raja R Harinath <harinath@gmail.com>
3090 * statement.cs (Block.CheckError136_InParents): Remove.
3091 (Block.AddVariable): Use GetParameterInfo instead.
3092 (ToplevelBlock.ProcessArguments): Likewise.
3094 2007-06-04 Raja R Harinath <rharinath@novell.com>
3096 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
3098 (ToplevelBlock.GetParameterInfo): Split out of ...
3099 (ToplevelBlock.GetParameterRefernce): ... this.
3100 (ToplevelBlock.ParameterMap): Remove.
3101 * expression.cs (ParameterReference): Update to use
3102 ToplevelParameterInfo.
3104 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
3107 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
3108 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
3110 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
3111 (ToplevelBlock.ProcessParameters) ... here.
3112 (ToplevelBlock..ctor): Invoke it.
3114 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
3117 * statement.cs (IKnownVariable): New interface.
3118 (LocalInfo): Implement it.
3119 (ToplevelParameterInfo): New class.
3120 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
3121 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
3122 GetKnownVariableInfo.
3124 2007-06-03 Raja R Harinath <harinath@gmail.com>
3126 Partly speed up CS0136 error checks.
3127 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
3128 'recurse' parameter.
3129 (Block.DoCheckError136): Only check errors in parameters. Move
3130 local variable checks ...
3131 (Block.AddVariable): ... here, and ...
3132 (ToplevelBlock.ResolveMeta): ... here.
3134 2007-06-02 Raja R Harinath <harinath@gmail.com>
3136 * statement.cs (Block.IsChildOf): Remove.
3138 * statement.cs (Statement.Clone): Move special case code ...
3139 (Block.CloneTo): ... here.
3141 2007-05-29 Raja R Harinath <rharinath@novell.com>
3143 * statement.cs (ToplevelBlock.container): Remove field. It's
3144 redundant with 'Parent'.
3145 (ToplevelBlock.ContainerBlock): Remove accessor.
3146 (ToplevelBlock..ctor): Update to changes. Register anonymous
3147 child with parent here, ...
3148 * cs-parser.jay (end_anonymous): ... not here. Don't modify
3150 (start_anonymous): Don't save current_block.
3151 (top_current_block): Remove.
3153 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
3154 (Block.Resolve): Update to changes.
3155 (Block..ctor): Move setting of "correct" 'Toplevel'
3156 and 'Explicit' fields to ...
3157 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
3159 2007-05-27 Raja R Harinath <harinath@gmail.com>
3162 * statement.cs (Block.Implicit): Remove.
3163 (Block): Update to changes.
3164 * flowanalysis.cs: Likewise.
3166 Mildly speed up CheckInvariantMeaningInBlock
3167 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
3168 Recursively call AddKnownVariable to all enclosing blocks.
3169 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
3170 Remove recursive calls.
3171 (Block): Update to changes.
3173 New ExplicitBlock invariants
3174 * statement.cs (Block.Explicit): New field. It points to the
3175 immediately enclosing non-implicit block.
3176 (Block..ctor): Maintain the invariant.
3177 * cs-parser.jay: Take advantage of invariant.
3179 Introduce ExplicitBlock
3180 * statement.cs (ExplicitBlock): New.
3181 (ToplevelBlock): Derive from it.
3182 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
3184 (Block.Implicit): Update to changes.
3185 * cs-parser.jay: Update to changes.
3188 * codegen.cs (EmitContext.IsLastStatement): Remove.
3189 * statement.cs (Block.DoEmit): Update to changes.
3191 2007-05-25 Raja R Harinath <rharinath@novell.com>
3193 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
3194 modifying current_block directly.
3196 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
3198 * class.cs: Implemented automatic properties (C# 3.0)
3199 Thanks to Marek for the help.
3201 2007-05-23 Raja R Harinath <rharinath@novell.com>
3203 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
3204 variable as assigned, note also that all its components are
3206 (MyBitVector.SetRange): New. Function to set multiple bits to true.
3208 2007-05-19 Marek Safar <marek.safar@gmail.com>
3210 * anonymous.cs, class.cs: Emit Compiler generated attribute when
3211 member is marked as compiler generated.
3213 * decl.cs (MemberCore): Refactored ModFlags into property.
3215 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
3216 (Check): Check only accessibility modifiers.
3218 2007-05-18 Raja R Harinath <rharinath@novell.com>
3220 Track all assignable slots in one bit array
3221 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
3222 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
3223 logic from VariableMap constructor here. Use the same 'offset'
3224 variable that's later used for computing offsets of local
3226 * flowanalysis.cs (UsageVector.parameters): Remove.
3227 (UsageVector): Update to changes.
3228 (VariableMap): Remove.
3230 Avoid creating ParameterMap in every block
3231 * statement.cs (Block.ParameterMap): Move ...
3232 (ToplevelBlock.ParameterMap): ... here.
3233 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
3235 * flowanalysis.cs (FlowBranching.param_map): Remove.
3236 (FlowBranching.UsageVector): Update to changes.
3237 (FlowBranchingToplevel.CheckOutParameters): Likewise.
3239 * statement.cs (Block.CloneTo): Clone Toplevel field too.
3241 * expression.cs (ParameterReference): Distinguish between block
3242 where parameter was referenced and declared.
3244 2007-05-18 Marek Safar <marek.safar@gmail.com>
3246 * flowanalysis.cs, statement.cs: Put back improved error handling.
3248 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
3252 Imporved object and collection initialization (C# 3.0).
3254 2007-05-15 Marek Safar <marek.safar@gmail.com>
3256 A fix for bug #81380
3257 * expression.cs (Is.DoResolve): Only value types have constant `is'
3260 2007-05-15 Raja R Harinath <rharinath@novell.com>
3262 * statement.cs (ToplevelBlock.child): Remove.
3264 2007-05-15 Raja R Harinath <harinath@gmail.com>
3266 Rationalize ResolveMeta: refactoring
3267 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
3268 out constant handling code into ...
3269 (Block.DoResolveConstants): ... this.
3271 Rationalize ResolveMeta: kill local_map
3272 * statement.cs (Block.local_map, Block.LocalMap): Remove.
3273 (Block.AssignableSlots): New.
3274 (Block.ResolveMeta): Make protected. Don't create a VariableMap
3275 for locals -- move code from VariableMap here. Avoid unnecessary
3277 * flowanalysis.cs (FlowBranching.local_map): Remove.
3278 (FlowBranching..ctor): Use Block.AssignableSlots.
3279 (VariableMap): Remove unused constructors.
3281 2007-05-11 Raja R Harinath <rharinath@novell.com>
3283 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
3285 2007-05-11 Marek Safar <marek.safar@gmail.com>
3287 * typemanager.cs (IsFriendAssembly): Should not be called for building
3290 2007-05-09 Marek Safar <marek.safar@gmail.com>
3292 * literal.cs (NullConstant): Print null in all cases.
3294 * expression.cs (Binary.ResolveOperator): Implemented delegate
3295 comparison based on C# 2.0 changes.
3297 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
3299 This code is contributed under the MIT X11 license
3301 The following enables support for several C# 3.0 language features:
3303 * cs-tokenizer.cs: Added support for the "var" keyword.
3305 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
3306 Added VarExpr class to facilitate type inferencing.
3308 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
3309 to support anonymous types.
3311 * assign.cs: Added support for type inferencing and initialization.
3313 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
3315 * expression.cs: Added implicit array support to ArrayCreation.
3316 Added 5 types and 1 interface:
3318 IInitializable Implementing classes can inject initializing
3319 statements after object instantiation.
3321 Initializer Stores data for object initialization.
3323 AnonymousType An expression for anonymous types.
3325 AnonymousTypeParameter Stores data about an anonymous type's field.
3327 NewInitialize An expression for object initialization.
3329 CollectionInitialize An expression for collection initialization.
3331 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
3334 2007-05-06 Marek Safar <marek.safar@gmail.com>
3336 A fix for bug #81500
3337 * cs-tokenizer.cs: Add special handling for coalescing operator.
3339 2007-05-06 Marek Safar <marek.safar@gmail.com>
3341 A fix for bug #81529
3342 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
3343 its value from base class until it is redefined.
3345 2007-05-02 Raja R Harinath <rharinath@novell.com>
3347 Fix regression in cs0631-3.cs
3348 * cs-parser.jay (operator_declarator): Add opt_attributes to error
3349 fallback. Make error fallback catch more cases.
3351 2007-05-01 Miguel de Icaza <miguel@novell.com>
3353 * cs-parser.jay: Allow parameters in operator declarations to have
3356 2007-04-27 Miguel de Icaza <miguel@novell.com>
3358 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
3361 * lambda.cs (ContextualReturn.Resolve): An expression is valid
3362 inside the ContextualReturn, it does not have to be an
3363 ExpressionStatement.
3365 2007-04-24 Miguel de Icaza <miguel@novell.com>
3367 * lambda.cs (ContextualReturn.Resolve): if the return type is not
3370 2007-04-23 Miguel de Icaza <miguel@novell.com>
3372 * anonymous.cs (AnonymousContainer): split the virtual Resolve
3373 method in two methods: ResolveNoDefine and Resolve.
3375 ResolveNoDefine will stop just after ResolveTopBlock has been
3378 Resolve will then continue by creating a method and issuing the
3379 call to method.Define ().
3381 (AnonymousMethod): Split and implement the new Resolve and
3382 ResolveNoDefine as well.
3384 * lambda.cs (LambdaExpression): Split the anonymous method
3385 resolution code into a separate routine (CoreCompatibilityTest)
3386 from DoCompatibleTest.
3388 (LambdaExpression.TryBuild): New method, this method tries to
3389 build the LambdaExpression with the given set of types to be used
3390 as the types for the various parameters of the lambda expression.
3392 If the compilation succeed with the given types, the infered type
3393 of the Anonymous method is returned, otherwise null is returned.
3395 2007-04-23 Marek Safar <marek.safar@gmail.com>
3397 A fix for bug #81414
3398 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
3400 2007-04-22 Miguel de Icaza <miguel@novell.com>
3402 * cs-tokenizer.cs: Change various identifiers here from the
3403 camelCasing to the recommended Linux-like style for instance
3404 variables from the Coding Guidelines.
3406 2007-04-19 Martin Baulig <martin@ximian.com>
3409 (Convert.ImplicitReferenceConversionCore): Allow conversions from
3410 System.Enum to System.ValueType.
3412 2007-04-13 Martin Baulig <martin@ximian.com>
3414 Rewrote implicit reference conversions. We need to distinguish
3415 between implicit reference conversions (13.1.4) and implicit
3416 boxing conversions (13.1.5).
3418 According to the spec, there's an an implicit conversion
3419 "From a one-dimensional array-type S[] to IList<T> and base
3420 interfaces of this interface, provided there is an implicit
3421 reference conversion from S to T." Note that this does not
3422 include boxing conversions.
3425 (Convert.ImplicitTypeParameterBoxingConversion): New method.
3426 (Convert.ImplicitReferenceConversion): Split into
3427 ImplicitReferenceConversionCore() and
3428 ImplicitBoxingConversionExist().
3429 (Convert.ImplicitReferenceConversionExists): Use the new
3430 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
3432 2007-04-12 Martin Baulig <martin@ximian.com>
3434 * convert.cs (Convert.ImplicitReferenceConversion): Move the
3435 `TypeManager.null_type' checks up to the top of the method.
3437 2007-04-11 Marek Safar <marek.safar@gmail.com>
3439 A fix for bug #81350
3440 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
3443 2007-04-11 Martin Baulig <martin@ximian.com>
3445 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
3446 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
3447 to make this work for generic classes; fixes #79561.
3449 2007-04-11 Martin Baulig <martin@ximian.com>
3451 * expression.cs (As): Add support for nullable types; fixes #79371.
3453 2007-04-11 Martin Baulig <martin@ximian.com>
3455 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
3456 `type.FullName' is null; fixes #80243.
3458 2007-04-11 Martin Baulig <martin@ximian.com>
3460 * expression.cs (Invocation.IsApplicable): Don't modify the method
3461 if type inference succeeded, but the method was not applicable.
3464 2007-04-10 Marek Safar <marek.safar@gmail.com>
3466 A fix for bug #81324
3467 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
3468 internal and external namespaces containers.
3470 2007-04-10 Martin Baulig <martin@ximian.com>
3472 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
3473 TypeManager.DropGenericMethodArguments() so we also call
3474 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
3476 2007-04-10 Martin Baulig <martin@ximian.com>
3478 * iterators.cs (Iterator.CreateIterator): Don't crash if
3479 `method.ReturnType' is null. This happens if something went wrong
3480 while resolving that typ (we already reported an error in this case).
3482 2007-04-10 Martin Baulig <martin@ximian.com>
3484 * expression.cs (New.DoResolve): Don't call CheckComImport() on
3485 generic interfaces; report the CS0144 directly.
3487 2007-04-10 Martin Baulig <martin@ximian.com>
3489 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
3490 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
3492 2007-04-10 Martin Baulig <martin@ximian.com>
3494 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
3496 2007-04-09 Raja R Harinath <rharinath@novell.com>
3499 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
3500 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
3503 * statement.cs (For.Resolve): If resolution fails, use
3506 2007-04-08 Marek Safar <marek.safar@gmail.com>
3508 * anonymous.cs (MakeName): Make faster and zero-based.
3509 (VerifyExplicitParameterCompatibility): Back to mode where generic
3510 parameter is ignored.
3511 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
3513 * class.cs (EmitType): Method can emit another new method.
3515 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
3517 * driver.cs: Updated.
3519 * lambda.cs: Reuse predefined empty parameters.
3521 * parameter.cs: Updated
3523 * support.cs: Implemented InflateTypes.
3525 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
3526 (InitSystemCore): Introduced to isolate 3.0 dependencies.
3528 2007-04-03 Martin Baulig <martin@ximian.com>
3532 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
3533 version of TypeManager.IsOverride() which also works with generic
3536 2007-04-03 Martin Baulig <martin@ximian.com>
3541 (Convert.ExplicitReferenceConversion): We need to cast when
3542 converting from IList<T> to S[].
3544 2007-04-01 Marek Safar <marek.safar@gmail.com>
3546 * decl.cs (FindExtensionMethods): Consider all candidates with same name
3549 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
3551 2007-03-31 Marek Safar <marek.safar@gmail.com>
3553 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
3554 argument and return type inferring.
3556 * codegen.cs (InferReturnType): Flag whether return can be inferred.
3557 (ReturnType): Turned to property.
3559 * statement.cs (Return): Implemented return type inferring.
3561 * support.cs (ReflectionParameters): Use local types if possible.
3563 2007-03-30 Raja R Harinath <rharinath@novell.com>
3565 * flowanalysis.cs (FlowBranching.Reachability): Remove.
3566 (FlowBranching.UsageVector): Update to changes.
3568 Prepare to kill 'Reachability'
3569 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
3570 argument of constructor.
3572 2007-03-29 Raja R Harinath <rharinath@novell.com>
3574 Prepare to kill 'Reachability'
3575 * flowanalysis.cs (UsageVector.is_unreachable): New.
3576 (UsageVector): Update to maintain 'is_unreachable' in parallel to
3577 'reachability', and verify they're consistent.
3580 * expression.cs (New.EmitStatement): Handle type parameters here too.
3582 2007-03-29 Martin Baulig <martin@ximian.com>
3587 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
3588 CompilerGeneratedClass.
3589 (ScopeInfo.EmitScopeInstance): Make this protected.
3590 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
3591 `ec.CurrentAnonymousMethod.Scope == Scope'.
3593 * statement.cs (Block.ScopeInfo): Make this a property.
3595 2007-03-27 Raja R Harinath <harinath@gmail.com>
3597 Prepare to kill 'Reachability'
3598 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
3599 (FlowBranching.UsageVector.Reachability): Remove property.
3600 (FlowBranching.UsageVector.IsUnreachable): New property.
3601 (FlowBranching.UsageVector.ResetBarrier): New.
3602 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
3603 * codegen.cs, statement.cs: Update to changes.
3605 2007-03-27 Martin Baulig <martin@ximian.com>
3610 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
3613 2007-03-26 Raja R Harinath <rharinath@novell.com>
3615 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
3616 instead of TriState. Remove all mention of TriState.
3618 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
3619 replaced by a boolean. Add boolean 'is_unreachable' field, check
3620 and maintain invariants.
3622 2007-03-25 Marek Safar <marek.safar@gmail.com>
3624 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
3626 2007-03-25 Marek Safar <marek.safar@gmail.com>
3628 * expression.cs: Stop using obsolete 2.0 opcodes.
3630 2007-03-25 Marek Safar <marek.safar@gmail.com>
3632 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
3633 one of the latests Martin's fixes.
3635 2007-03-23 Miguel de Icaza <miguel@novell.com>
3637 * expression.cs: On BigEndian systems, swap the bytes, temporary
3638 solution until we get a new bitconverter class.
3640 2007-03-23 Martin Baulig <martin@ximian.com>
3644 * decl.cs (MemberCache.AddMembers): Add generic methods both as
3645 "Method" and "Method`1". Normally, a cache lookup is done on the
3646 "Method" form (ie. without the generic arity), but this one makes
3647 lookups on the full form work as well.
3649 2007-03-22 Raja R Harinath <rharinath@novell.com>
3651 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
3654 2007-03-20 Bill Holmes <billholmes54@gmail.com>
3656 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
3657 ordered_member_list, to TypeBuilder to store members to be defined
3658 in the order they were parsed in.
3659 - ordered_explicit_member_list contains all properties indexers
3660 and methods that are defined as explicit implementation of an
3661 interface or base class.
3662 - ordered_member_list contains all properties indexers and methods
3663 that are not defined as explicit implementation of an interface
3666 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
3667 functionality in these removed classes has been replaced with
3668 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
3669 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
3671 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
3672 to CheckForDuplications inside GetMethod and SetMethod Define Method
3673 to handle method property and indexer name conflicts.
3677 All code is contributed under the MIT/X11 license.
3679 2007-03-20 Martin Baulig <martin@ximian.com>
3681 * class.cs (TypeContainer.Interfaces): Removed; they're now
3682 included in `TypeContainer.Types'.
3684 2007-03-20 Martin Baulig <martin@ximian.com>
3686 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
3688 * class.cs (TypeContainer.CreateType): New public method. This is
3689 now called before DefineType() to create the TypeBuilders.
3690 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
3691 has already been created by CreateType().
3692 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
3693 don't resolve our base classes here; this has been moved into
3694 DefineBaseTypes(). We're now called from CreateType().
3695 (TypeContainer.DefineBaseTypes): New private method; resolve our
3696 base classes here. We're now called from DefineType().
3699 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
3700 our types first to create all the TypeBuilders. After that, call
3701 TypeContainer.DefineType() on all the types which'll resolve their
3702 base classes and setup the resolve order.
3704 2007-03-20 Martin Baulig <martin@ximian.com>
3706 * class.cs (TypeContainer.Enums): Removed; they're now included in
3707 `TypeContainer.Types'.
3709 2007-03-20 Martin Baulig <martin@ximian.com>
3712 (TypeContainer.DefineType): Don't call ResolveMembers() here.
3713 (TypeContainer.DoResolveMembers): Call DefineType() on our
3714 `compiler_generated' classes; moved here from DefineNestedTypes().
3717 (RootContext.ResolveTree): Call ResolveMembers() on all
3718 TypeContainer's in the `type_container_resolve_order'.
3720 2007-03-19 Marek Safar <marek.safar@gmail.com>
3722 * class.cs: Use corlib to handle InternalMethodImplAttribute.
3724 2007-03-17 Marek Safar <marek.safar@gmail.com>
3726 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
3727 implementation flags.
3729 2007-03-17 Marek Safar <marek.safar@gmail.com>
3731 * class.cs: More optimizations for type parameters.
3733 2007-03-15 Marek Safar <marek.safar@gmail.com>
3735 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
3737 * ecore.cs, parameter.cs: More common code for both corlibs.
3739 * typemanager.cs (IsGenericMethod): Simplified.
3741 2007-03-15 Raja R Harinath <rharinath@novell.com>
3743 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3745 * statement.cs, iterators.cs, lambda.cs: Update to changes.
3747 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
3748 unconditionally. Simplify explanation.
3749 (Try.Resolve, Using.Resolve): Likewise.
3751 2007-03-15 Martin Baulig <martin@ximian.com>
3755 * decl.cs (DeclSpace): If we're a partial class, use our
3756 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
3758 2007-03-15 Raja R Harinath <rharinath@novell.com>
3760 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3762 (FlowBranching.UsageVector): Update to changes.
3763 (FlowBranching.MergeSiblings): Likewise.
3764 * statement.cs: Likewise.
3766 2007-03-15 Martin Baulig <martin@ximian.com>
3771 (MemberCache): Added a special .ctor for type parameters.
3774 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
3777 2007-03-09 Martin Baulig <martin@ximian.com>
3779 * enum.cs (Enum): Make this a TypeContainer.
3780 (EnumMember): Derive from `Const'.
3783 (Const.DoResolveValue): New protected virtual method; move most of
3784 the functionality of ResolveValue() here so we can override it in
3786 (Const.CreateConstantReference): Make this virtual.
3788 * class.cs (Kind): Add `Kind.Enum'.
3789 (TypeContainer.Emit): Don't emit the enums here; they're already
3790 in the `RootContext.typecontainer_resolve_order'.
3792 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
3793 here; they're already in the `typecontainer_resolve_order'.
3795 * ecore.cs (EnumConstant.ConvertImplicitly): Add
3796 TypeManager.DropGenericTypeArguments().
3799 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
3800 (TypeManager.IsEnumType): Likewise.
3801 (TypeManager.EnumToUnderlying): Likewise.
3802 (TypeManager.IsEqual): Add support for enums.
3804 2007-03-12 Raja R Harinath <rharinath@novell.com>
3806 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
3807 DefaultParameterValueAttribute to be undefined, say if System.dll
3810 2007-03-11 Marek Safar <marek.safar@gmail.com>
3812 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
3815 2007-03-10 Marek Safar <marek.safar@gmail.com>
3817 * class.cs, parameter.cs: Unified parameters verification.
3819 2007-03-08 Martin Baulig <martin@ximian.com>
3821 * cs-parser.jay (constructor_header): Pass the location to the
3822 newly created TopLevelBlock.
3824 2007-03-07 Martin Baulig <martin@ximian.com>
3826 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
3828 2007-03-06 Miguel de Icaza <miguel@novell.com>
3830 * convert.cs (ExplicitReferenceConversionExists): Sync this method
3831 with the changes from David, fixes the build.
3833 2007-03-05 David Mitchell <dmitchell@logos.com>
3835 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
3836 and its base interfaces to a one-dimensional array type S[],
3837 provided there is an implicit or explicit reference conversion
3840 2007-03-03 Marek Safar <marek.safar@gmail.com>
3842 * cs-tokenizer.cs: Implemented basic linq grammar.
3844 * driver.cs: Set linq lang version on demand.
3846 2007-02-26 Marek Safar <marek.safar@gmail.com>
3848 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
3850 2007-02-25 Marek Safar <marek.safar@gmail.com>
3852 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
3855 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
3857 Check property and event extern attributes.
3859 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
3862 2007-02-24 Marek Safar <marek.safar@gmail.com>
3864 A fix for bug #80407
3865 * ecore.cs: Don't report ambiguity error when methods have same parent.
3867 2007-02-23 Marek Safar <marek.safar@gmail.com>
3869 A fix for bug #80878
3870 * class.cs, cs-parser.jay: Event property can host anonymous methods.
3872 2007-02-22 Marek Safar <marek.safar@gmail.com>
3874 * attribute.cs: Enable ExtensionAttribute presence test.
3876 2007-02-22 Marek Safar <marek.safar@gmail.com>
3878 * class.cs: Warn about missing GetHashCode only when Equals is override.
3880 * decl.cs: Check accessibility of type arguments.
3882 * typemanager.cs: Correctly report nullable array.
3884 2007-02-20 Marek Safar <marek.safar@gmail.com>
3886 * class.cs, report.cs: Capture more details when things go wrong.
3888 2007-02-20 Marek Safar <marek.safar@gmail.com>
3890 A fix for bug #80650
3891 * cs-parser.jay: Anonymous container starts at constructor declaration
3892 and not at block beginning because it has to be usable in constructor
3895 * statement.cs: Use context location and not block one for error reporting.
3897 2007-02-18 Marek Safar <marek.safar@gmail.com>
3899 A fix for bug #78712
3900 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
3903 2007-02-18 Marek Safar <marek.safar@gmail.com>
3905 A fix for bug #80493 by Atsushi Enomoto
3906 * cs-parser.jay: Ignore invalid attribute target.
3908 2007-02-18 Marek Safar <marek.safar@gmail.com>
3910 * cs-tokenizer.cs: Ignore '\0' as white space character.
3912 2007-02-17 Miguel de Icaza <miguel@novell.com>
3914 * cs-parser.jay: Add support for lambda expressions to the mcs
3917 * lambda.cs: Only clone when we are probing, not on the final call
3918 (Compatible is the final call).
3920 * statement.cs (CloneContext): Introduce class to provide block
3921 remapping during clone.
3923 All statements Clone themselves now.
3925 (Clone): special handling for blocks, when we clone a block, we
3926 register the block inside this routine, as children of the block
3927 might trigger a lookup.
3929 * expression.cs: Add support for CloneContext in all expressions.
3931 2007-02-17 Marek Safar <marek.safar@gmail.com>
3933 A fix for bug #80493
3934 * statement.cs: Report ambiguous warning when interfaces are not related.
3936 2007-02-15 Marek Safar <marek.safar@gmail.com>
3938 C# 3.0 extension methods.
3940 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
3941 cannot be used directly.
3943 * class.cs (Class.Emit): Emit extension attribute if any class method
3944 is extension method.
3945 (Method.Define): Add basic extension method validation conditions.
3946 (Method.Emit): Emit extension attribute for method.
3948 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
3949 extension method exists. Currently we follow same approach as Microsoft
3950 does, emit even if a method or a class are private but this can change
3953 * cs-parser.jay: Add handling of `this' keyword in method parameters
3956 * decl.cs (DeclSpace.IsStaticClass): New property.
3957 (MemberCache.FindExtensionMethods): Looks for extension methods with
3958 defined name and extension type.
3960 * doc.cs: Updated after OverloadResolve changes.
3962 * driver.cs: Add new soft reference to System.Core.dll.
3964 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
3965 (ExtensionMethodGroupExpr): Represents group of extension methods.
3967 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
3968 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
3969 to MethodGroupExpr and made non-static for easier customization.
3970 (Invocation.DoResolve): Add extension method lookup when no standard
3972 (MemberAccess.DoResolve): Try extension methods if no member exists.
3974 * modifiers.cs: Add METHOD_EXTENSION modifier.
3976 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
3977 as well as candidate extension type.
3978 (ComputeNamespaces): When assembly constains extension methods registers
3980 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
3981 extension method lookup.
3982 (Namespace.LookupExtensionMethod): Looks for extension method in this
3984 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
3985 find a method which matches name and extensionType.
3987 * parameter.cs (Parameter): Add This modifer.
3988 (HasExtensionMethodModifier): New property.
3989 (Resolve): Add extension parameter check.
3990 (ModFlags): turned to property to exclude this modifier as it is not real
3992 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
3994 * support.cs (ParameterData): Add ExtensionMethodType.
3995 (ReflectionParameters): Implemented ExtensionMethodType interface property.
3997 * typemanager.cs: Add type and ctor extension attribute type.
3999 2007-02-15 Miguel de Icaza <miguel@novell.com>
4001 * report.cs (DisableErrors, EnableErrors): used to prevent error
4002 output when we are "trying" to compile various methods with
4005 * ecore.cs (Expression): Add Clone method that calls the virtual
4006 CloneTo method. The current CloneTo method in Expression throws
4007 an exception so we can track down all the places where this must
4008 be implemented (not using abstract, because that would be a lot of
4009 up-front-work before we can start testing the implementation
4012 Important: we only need Clone capabilities for expressions created
4013 by the parser, as the expressions we will be cloning are
4014 expressions in the pre-resolved state. This vastly simplifies
4017 (SimpleName): Add CloneTo that does nothing.
4018 (EmptyCast): Add CloneTo.
4020 * expression.cs (Binary): Implement CloneTo.
4021 (Invocation.IsApplicable): Store the current ec in
4022 EmitContext.TempEc and restore it on return. This is used so we
4023 do not have to sprinkle hundres of methods with an extra
4024 EmitContext, we know that the only user is the lambda expression
4025 ImplicitConversionExists code.
4027 (Argument): Add Cloning capabilities.
4028 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
4029 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
4030 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
4031 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
4032 IndexerAccess): Add Clone capability.
4034 (LocalVariableReference, This): TODO: needs cloned Block mapping.
4036 (Argument): Add cloning capability.
4038 * assign.cs (Assign): Implement CloneTo.
4040 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
4042 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
4043 version by calling Convert with the EmitContext (that we are
4044 currently storing in ec, this is not great, but will do for now,
4045 to avoid passing EmitContext parameters to hundreds of functions
4046 that do not need them now).
4048 (SetExpression): Remove, it is not needed.
4050 (ContextualReturn): Implement CloneTo.
4052 * statement.cs (Statement): Implement cloning infrastructure,
4053 similar to expressions.
4055 (Block): Partial implementation of Clone for statements.
4057 (Return): Implement clone.
4059 * constant.cs (Constant.CloneTo): New method, does nothing.
4061 * codegen.cs (TempEc): Add a static EmitContext as a temporary
4062 solution, until we decide how to exactly do this.
4064 2007-02-14 Marek Safar <marek.safar@gmail.com>
4066 A fix for bug #80493
4067 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
4068 a property is override we need to use second accessor.
4070 2007-02-13 Marek Safar <marek.safar@gmail.com>
4072 A fix for bug #80418
4073 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
4076 2007-02-13 Marek Safar <marek.safar@gmail.com>
4078 Another fix for bug #80749
4079 * pending.cs: Abstract class has priority over interfaces.
4081 2007-02-13 Marek Safar <marek.safar@gmail.com>
4083 Another fix for bug #80749
4084 * pending.cs: Abstract class has priority over interfaces.
4086 2007-02-13 Marek Safar <marek.safar@gmail.com>
4088 Another fix for bug #80749
4089 * pending.cs: Abstract class has priority over interfaces.
4091 2007-02-13 Marek Safar <marek.safar@gmail.com>
4093 Another fix for bug #80749
4094 * pending.cs: Abstract class has priority over interfaces.
4096 2007-02-13 Marek Safar <marek.safar@gmail.com>
4098 * class.cs Better error message.
4100 * driver.cs: Add shorter versions of -optimize option.
4102 2007-02-13 Martin Baulig <martin@ximian.com>
4104 * class.cs (Constructor.Emit): Check the return value of
4105 ec.ResolveTopBlock() and return on error.
4107 2007-02-13 Raja R Harinath <rharinath@novell.com>
4109 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
4110 message to fix error message regression.
4112 2007-02-12 Marek Safar <marek.safar@gmail.com>
4114 * delegate.cs: Delegate creation expression cannot be of Nullable type.
4116 2007-02-12 Marek Safar <marek.safar@gmail.com>
4118 A fix for bug #80749
4119 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
4120 its parent container.
4122 * class.cs (DefineFieldInitializers): Each initializer can has different
4125 * const.cs: Updated.
4127 2007-02-11 Miguel de Icaza <miguel@novell.com>
4129 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
4130 now all the heavy lifting to check that embedded statements or
4131 expressions have the right form is done in the ContextualReturn.
4133 (ContextualReturn): New class.
4135 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
4136 method that can be invoked to report 201, so we do not replicate
4139 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
4141 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
4142 treating tabs as spaces.
4144 2007-02-09 Marek Safar <marek.safar@gmail.com>
4146 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
4147 * assign.cs: Use full implicit conversion for right side check.
4149 2007-02-09 Marek Safar <marek.safar@gmail.com>
4151 * statement.cs (Switch): Switch over boolean type is not standardized.
4153 2007-02-08 Marek Safar <marek.safar@gmail.com>
4155 A fix for bug #80755
4156 * decl.cs (FindBaseEvent): Don't use method cache for events.
4158 2007-02-07 Marek Safar <marek.safar@gmail.com>
4160 * cs-parser.jay: Better syntax error handling.
4162 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
4163 instead of underlying type value.
4165 2007-02-06 Marek Safar <marek.safar@gmail.com>
4167 * driver.cs: Check define identifier before is registered.
4169 * namespace.cs: Use existing error message.
4171 * report.cs: New warning.
4173 2007-02-06 Marek Safar <marek.safar@gmail.com>
4175 A fix for bug #80742
4176 * expression.cs: Delegate Invoke method can be called directly.
4178 2007-02-06 Marek Safar <marek.safar@gmail.com>
4180 A fix for bug #80676
4181 * class.cs (IsEntryPoint): The Main method can have params modifier.
4183 2007-02-04 Miguel de Icaza <miguel@novell.com>
4185 * parameter.cs (Parameter, Parameters): Add Clone method.
4187 * anonymous.cs (Compatible): Turn method into virtual method, so
4188 LambdaExpression can implement a different behavior.
4190 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
4191 out the basic checking here, so it can be used by
4194 * lambda.cs: Introduce "Compatible" function that will do the
4197 2007-02-02 Marek Safar <marek.safar@gmail.com>
4199 * attribute.cs: Unified one error message.
4201 * class.cs (Class): Use type attributes and not properties to test static
4203 (IsEntryPoint): Don's pass local variable.
4205 * convert.cs: Removed duplicate check.
4207 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
4209 * driver.cs: Don't crash when soft reference does not exist.
4211 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
4212 (UsingEntry): Removed redundant allocation.
4214 * parameter.cs: Add fast path for type parameters.
4216 * support.cs: Don't allocate attribute when it's not used.
4218 2007-01-30 Miguel de Icaza <miguel@novell.com>
4221 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
4222 this into a virtual method, so we can override it in LambdaExpression.
4224 * driver.cs: Improve diagnostics in case of failure.
4226 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
4227 write a function that is slightly more complex and that parses:
4229 type identifier [, type identifier]* )
4231 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
4234 (canEmpty ? i >= 0 : i > 0)
4236 2007-01-30 Raja R Harinath <rharinath@novell.com>
4238 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
4239 exception on possibly valid code.
4241 2007-01-29 Raja R Harinath <rharinath@novell.com>
4243 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
4245 (parse_opt_type_arguments): Remove. It's almost the same as
4247 (parse_namespace_or_typename): Use parse_less_than.
4249 2007-01-28 Miguel de Icaza <miguel@novell.com>
4251 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
4252 this bug took a few hours to find, because the state saved and
4253 restored by PushPosition and PopPosition was ignoring the state of
4254 parse_generic_less_than.
4256 I can also now remove the handling of OP_LT and OP_GT, this solves
4259 * cs-tokenizer.cs: store the location for the ARROW token, we use
4262 (PushPosition, PopPosition): save/restore also `current_token',
4263 restore `parse_generic_less_than' (was missing).
4265 (parse_opt_type_arguments): use parse_type, not
4266 parse_namespace_or_typename to parse types.
4268 * lambda.cs: Empty new file, will eventually have the lambda
4269 expression implementation.
4271 * lambda.test: used to test the internal tokenizer.
4273 * report.cs (FeatureIsNotISO1): Rename from
4274 FeatureIsNotStandardized, because it was about the language level
4275 (1 vs 2) it was not about standarization.
4277 (FeatureRequiresLINQ): New.
4279 * support.cs (SeekableStreamReader): Only require that the reader
4280 is a TextReader, not a StreamReader, so we can plug StringReader.
4282 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
4283 given position in the input stream the following tokens can be
4284 parsed as a type followed by an identifier.
4286 (is_punct): after a '(' if parse_type_and_parameter returns true,
4287 then return a special token OPEN_PARENS_LAMBDA which is used to
4288 avoid reduce/reduce errors in the grammar for the
4289 lambda_expression rules.
4291 (parse_type): implement a type parser inside the
4292 tokenizer, the parser only returns true or false depending on
4293 whether the input at a given position can be parsed as a type.
4295 (peek_token): new method used during type parsing.
4297 2007-01-28 Raja R Harinath <rharinath@novell.com>
4300 * anonymous.cs (ScopeInfo.InflateParameters): New.
4301 (AnonymousContainer.Resolve): Use it to redirect types of
4302 delegate parameters.
4304 2007-01-27 Raja R Harinath <rharinath@novell.com>
4307 * expression.cs (Error_InvalidArguments): Don't use two different
4308 messages for CS1503. Use ExtraInformation and
4309 SymbolRelatedToPreviousError instead.
4312 * decl.cs (DeclSpace.initialize_type_params): Don't access
4313 'type_params' of a partial class directly.
4315 2007-01-26 Miguel de Icaza <miguel@novell.com>
4317 * constant.cs: Removed a handful of out-of-range checks that were
4320 2007-01-25 Marek Safar <marek.safar@gmail.com>
4322 * expression.cs (CheckUselessComparison): Add additional check for char
4325 * namespace.cs: Fixed typo.
4327 2007-01-23 Miguel de Icaza <miguel@novell.com>
4329 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
4330 gone, instead we inline the test, preventing the needless casts to
4331 longs, ulongs and doubles for the parameters, avoiding calls to
4332 methods that overchecked stuff, and instead inlined things
4335 2007-01-20 Marek Safar <marek.safar@gmail.com>
4337 * cs-parser.jay: Better parameter error handling.
4339 2007-01-17 Marek Safar <marek.safar@gmail.com>
4341 A fix for bug #80368, #80522
4342 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
4343 whether array initializer contains constants only.
4344 (ArrayCreation.Emit): Use better formula to decide when
4345 are array initializers for static initialization.
4346 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
4347 have to emit even constants otherwise they are pre-initialized.
4349 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
4350 Raja R Harinath <rharinath@novell.com>
4352 Fix emit order of 'get' vs. 'set'.
4353 * support.cs (Accessors): New.
4354 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
4355 Note the order in which accessors are declared in the source.
4356 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
4357 Refactored from Property.Define and Indexer.Define.
4358 (PropertyBase.DefineAccessors): New helper that calls the above in
4359 appropriate order as noted by the parser.
4360 (Property.Define, Indexer.Define): Update to changes.
4361 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
4363 2007-01-17 Raja R Harinath <rharinath@novell.com>
4365 Fix cs0029-6.cs and gcs0029-2.cs (regression)
4366 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
4367 there's an implicit conversion from the current type to the target
4368 type before converting the underlying constant.
4370 2007-01-16 Marek Safar <marek.safar@gmail.com>
4372 * const.cs (ResolveValue): Updated after constant conversion was made more
4375 * constant.cs (GetAttributableValue): constant to object conversion is
4376 used for attributes only.
4377 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
4378 constant conversions.
4379 (LongConstant.ConvertImplicitly): Ditto.
4381 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
4382 (ImplicitConversionStandard): Handle constant conversion as extra step.
4383 It solves the issue when constant conversion was called indirectly like
4384 inside array initializer and constant folding was skipped.
4386 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
4389 * statement.cs(ImplicitConversionStandard): Updated after constant
4390 conversion was made more generic.
4392 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
4394 * expression.cs (As.DoResolve): Use GenericConstraints instead of
4395 Constraints, solves the problem where the compiler incorrectly
4396 reported that a type parameter was not constrained to a class (Bug
4399 2007-01-14 Marek Habersack <grendello@gmail.com>
4401 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
4403 2007-01-14 Marek Safar <marek.safar@gmail.com>
4405 A fix for bug #80368
4406 * assign.cs (FieldInitializer): New class implements field
4407 initializer statement.
4409 * attribute.cs: Update after FieldMember rename.
4411 * class.cs (PropertyBasedMember): New common class for property based
4413 (InterfaceMemberBase): New base class for all members which can be used as
4414 an interface members.
4415 (MethodCore): Moved really common code to InterfaceMemberBase.
4416 (Method.Define): Equal and GetHasCode detection is relevant for methods
4418 (MethodData.Define): Don't assume that public event implements an
4419 interface automatically.
4420 (MethodData.DefineMethodBuilder): Issue an error even if only extern
4422 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
4423 (FieldMember): Merged with FieldBase.
4424 (EventProperty.AEventPropertyAccessor): New specialization to check whether
4425 event extern modifier can be used.
4426 (EventField.EventFieldAccessor): Moved event field specific code here.
4427 (Event.AllowedModifiers): Even event can be extern.
4428 (Event.FindOutBaseMethod): New override specific to events.
4429 (Indexer.parameters): Reintroduce parameters because base class holds
4430 only properties common data.
4431 (Indexer.CheckForDuplications): Indexers are threated as methods so we
4432 need do extra parameters check.
4434 * const.cs: Update after FieldMember rename.
4436 * decl.cs (MemberCache.FindBaseEvent): New method.
4438 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
4439 to reflect that indexer is now derived from PropertyBased.
4441 * ecore.cs (GetMemberType): Made public.
4442 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
4445 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
4447 * typemanager.cs (CSharpSignature): Correctly print event accessors.
4448 (RegisterEvent): Removed.
4449 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
4450 (GetPrivateFieldOfEvent): Renamed to GetEventField.
4452 2007-01-11 Raja R Harinath <rharinath@novell.com>
4455 * statement.cs (CollectionForeach.TryType): Prefer generic
4456 GetEnumerator over non-generic variant. Fix code to follow comments.
4458 2007-01-09 Raja R Harinath <rharinath@novell.com>
4461 * support.cs (ReflectionParameter): Don't use an invalid index on
4462 the generic parameter data.
4464 2007-01-08 Miguel de Icaza <miguel@novell.com>
4466 * driver.cs: Just add a tiny bit of infrastructure.
4468 2007-01-02 Marek Safar <marek.safar@gmail.com>
4470 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
4471 where field type is struct from current assembly.
4473 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
4476 2007-01-02 Marek Safar <marek.safar@gmail.com>
4478 A fix for bug #80381
4479 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
4482 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
4484 (Namespace.LookupType): Always use core types from corlib when speficied.
4486 * report.cs: A new warning.
4488 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
4489 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
4490 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
4492 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
4493 (InitCoreTypes): Set expression type of object_type and value_type
4494 immediately after lookup.
4496 2007-01-01 Miguel de Icaza <miguel@novell.com>
4498 * cs-tokenizer.cs: Accept Pc class characters (Connector
4499 Punctuation) as valid identifiers. Fixes #78259
4501 * expression.cs (Invocation.DoResolve): Moved the check for the
4502 use of `this' for doing method calls to the Invocation resolution
4503 step, after overload resolution has taken place instead of doing
4504 the check at the low-level `This.DoResolve' level.
4506 The `This.DoResolve'(appens before overload resolution, so it has
4507 no way of knowing if the method that will be called will be
4508 instace or static, triggering an erroneous report for cs0188 (Bug
4511 We now do the check for instance method invocations after we know
4512 what method will be called.
4514 (This.CheckThisUsage): Move the actual use of this structure
4515 checking into its own method and expose it.
4517 * Everywhere that called Error_ValueCannotBeConverted: pass a new
4520 Exceptions: Null.ConvertImplicitly,
4521 Constant.ImplicitConversionRequired as there are too many call
4522 sites for passing the ec.
4524 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
4525 EmitContext, if the value is null, then we do not try to provide
4526 the extra information from the error (If a userdefined conversion
4527 exists, as UserDefinedConversion requires a non null-EmitContext).
4531 2006-12-30 Raja R Harinath <rharinath@novell.com>
4533 * flowanalysis.cs (MyBitVector): Document some invariants.
4534 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
4535 introduced below, and add a couple of others,
4537 2006-12-30 Marek Safar <marek.safar@gmail.com>
4539 * attribute.cs (GetMethodObsoleteAttribute): Uses new
4540 GetPropertyFromAccessor and GetEventFromAccessor.
4542 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
4543 overrides non-obsolete one.
4544 (Indexer.Define): Error message has been moved to the parser.
4546 * cs-parser.jay: Better syntax errors handling.
4548 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
4549 when an invocation has no arguments.
4551 * ecore.cs: Removed not used caching.
4553 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
4556 * report.cs: Add a new warning.
4558 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
4560 * typemanager.cs (enumeration_type): Removed.
4561 (CSharpSignature): Reuses IsSpecialMethod.
4562 (IsEqual): Hack for MS BCL.
4563 (GetPropertyFromAccessor): New method.
4564 (GetEventFromAccessor): New method.
4565 (IsSpecialMethod): Fixed to handle more cases.
4567 2006-12-30 Marek Safar <marek.safar@gmail.com>
4569 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
4570 Made white spaces array static.
4572 * ecore.cs (RemoveGenericArity): Optimized.
4574 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
4576 (MyBitVector.initialize_vector): Simplified.
4578 2006-12-22 Miguel de Icaza <miguel@novell.com>
4580 * ecore.cs: Am not entirely happy with this hack, but it seems to
4581 address the issue in 80257 (a small test case for
4584 I set the MethodGroupExpr.Type to an internal compiler type
4585 (itself in this case) to force the resolution to take place. Why
4586 it does not take place with a null is beyond me.
4588 2006-12-20 Marek Safar <marek.safar@gmail.com>
4590 A fix for bug #80288
4591 * expression.cs (ResolveOperator): Consider user defined conversion for
4592 logical and operator too.
4593 (EmitBranchable): Optimization for logical and when full constant folding
4594 could not be applied but one operand is constant.
4596 2006-12-19 Marek Safar <marek.safar@gmail.com>
4598 * class.cs (GetClassBases): Write 5 times every day, will never use
4599 FullName for error reporting.
4601 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
4603 2006-12-19 Martin Baulig <martin@ximian.com>
4605 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
4606 the symbol file info here.
4608 2006-12-18 Marek Safar <marek.safar@gmail.com>
4610 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
4611 of `elseif' is taking then following sections are not taking.
4612 Fixes an issue reported on mono mailing list.
4614 2006-12-18 Marek Safar <marek.safar@gmail.com>
4616 A fix for bug #80300
4617 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
4618 a caller is not taking.
4620 2006-12-18 Raja R Harinath <rharinath@novell.com>
4622 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
4623 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
4624 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
4625 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
4626 * class.cs: Update to changes.
4628 2006-12-17 Marek Safar <marek.safar@gmail.com>
4630 A fix for bug #79934
4631 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
4634 * class.cs (ResolveMembers): Register an iterator in current container and
4637 2006-12-16 Raja R Harinath <rharinath@novell.com>
4640 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
4641 satisfy a params annotated parameter.
4643 2006-12-16 Marek Safar <marek.safar@gmail.com>
4645 A fix for bug #77014
4646 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
4647 paramters correctly and not rely on hacks in Parameters class.
4648 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
4650 (Invocation.VerifyArgumentsCompat): Ditto.
4651 (Invocation.EmitArguments): Changed to correctly emit params arguments at
4654 * parameter.cs (HasParams): Don't assume that params is the last one.
4656 * support.cs (ReflectionParameters.ctor): Look for params attribute
4658 (ReflectionParameters.ParameterType): Removed hack when we returned last
4659 parameter for out of range parameters.
4660 (ParameterName, ParameterModifier): Ditto.
4662 2006-12-14 Marek Safar <marek.safar@gmail.com>
4664 A fix for bug #79987
4665 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
4666 when assembly is not CLS compliant but type is. I have no idea why is this
4669 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
4671 2006-12-13 Miguel de Icaza <miguel@novell.com>
4673 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
4674 in struct constructors, they are basically no-ops.
4676 2006-12-12 Marek Safar <marek.safar@gmail.com>
4678 * cs-tokenizer.cs (Position): Save preprocessor status too.
4680 2006-12-12 Marek Safar <marek.safar@gmail.com>
4682 A fix for bug #77794
4683 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
4685 2006-12-12 Marek Safar <marek.safar@gmail.com>
4687 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
4689 (pp_expr): Report error for an invalid expression.
4690 (handle_preprocessing_directive): Simplified; add more error checking.
4692 2006-12-11 Marek Safar <marek.safar@gmail.com>
4694 A fix for bug #74939
4695 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
4696 directives handling.
4698 2006-12-10 Marek Safar <marek.safar@gmail.com>
4700 A fix for bugs #80093, and #75984
4701 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
4702 logic, it seems to me as it worked before "by coincidence".
4703 (xtoken): Simplified to use reworked handle_preprocessing_directive.
4704 (cleanup): Enabled endif check.
4706 2006-12-09 Marek Safar <marek.safar@gmail.com>
4708 A fix for bug #80162
4709 * statement.cs (CollectionForeach.TryType): Generics and non-generics
4710 enumerators are never ambiguous.
4712 2006-12-08 Raja R Harinath <rharinath@novell.com>
4715 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
4717 2006-12-06 Marek Safar <marek.safar@gmail.com>
4719 A fix for bug #80144
4720 * class.cs (EventProperty.Define): Explicit implementation means
4721 that an even is used.
4723 2006-12-06 Marek Safar <marek.safar@gmail.com>
4725 Fixes the operators implementation (part II)
4727 * cfold.cs (DoConstantNumericPromotions): Renamed to
4728 DoBinaryNumericPromotions and simplified.
4729 (BinaryFold): Couple of conversion fixes; simplified.
4731 * constant.cs, ecore.cs, literal.cs
4732 (ToType): Renamed to ConvertImplicitly.
4733 (Reduce): Renamed to ConvertExplicitly.
4735 * class.cs, convert.cs: Updated.
4737 * expression.cs: TryReduce doesn't throw an exception.
4739 2006-12-01 Marek Safar <marek.safar@gmail.com>
4741 A fix for bug #80108
4742 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
4745 2006-11-30 Marek Safar <marek.safar@gmail.com>
4747 Fixes unary operators implementation (part I)
4750 * cfold.cs (Error_CompileTimeOverflow): Made internal
4752 * const.cs (IConstant): Changed to use reference to constant and
4753 not constant itself.
4754 Updated IConstant implementations.
4756 * constant.cs (CreateConstant): New factory method.
4757 Updated IConstant implementation.
4759 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
4761 * ecore.cs: Updated to use CreateConstantReference.
4763 * enum.cs: Reflects IConstant changes.
4765 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
4767 * literal.cs (NullConstant): Change to be independently usable.
4769 2006-11-29 Martin Baulig <martin@ximian.com>
4771 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
4772 we need to emit the scope initializer before calling the base .ctor.
4774 * anonymous.cs: Merged back from the new anonymous methods branch.
4775 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
4777 * expression.cs (ParameterReference.DoResolveBase): Create a
4778 "normal" ScopeInfo when capturing parameters rather than using the
4779 root scope; this makes things work with anonymous methods having
4783 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
4785 2006-11-22 Marek Safar <marek.safar@gmail.com>
4787 A fix for bug #79987
4788 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
4789 check to a base class.
4790 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
4791 only when assembly has missing attribute.
4792 * report.cs: Update.
4794 2006-11-21 Marek Safar <marek.safar@gmail.com>
4796 * cs-tokenizer.cs: Merged with gmcs version.
4798 2006-11-20 Marek Safar <marek.safar@gmail.com>
4801 * cs-parser.jay: Better error message when partial keyword is misplaced.
4803 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
4805 A fix for bug #79810
4806 report.cs: CS1058 only applies to 2.0 profile (gmcs).
4807 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
4808 a RuntimeWrappedException by default.
4810 2006-11-18 Marek Safar <marek.safar@gmail.com>
4812 A fix for bug #79843
4813 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
4815 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
4817 2006-11-18 Marek Safar <marek.safar@gmail.com>
4819 * driver.cs, namespace.cs: Uses faster IndexOf version.
4821 2006-11-17 Marek Safar <marek.safar@gmail.com>
4823 A fix for bug #79941
4824 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
4826 (Operator.Define): Implicit/Explicit operator of same type is duplicate
4827 even if internal name is different.
4828 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
4829 (UserDefinedConversion): Simplified as the operators cannot be internal.
4830 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
4832 (MethodLookup): Replaced EmitContext with parentType.
4833 * expression.cs: Updated.
4835 2006-11-09 Raja R Harinath <rharinath@novell.com>
4837 * driver.cs (BadAssembly): Handle all the ugliness of
4838 DefineDynamicAssembly.
4840 2006-11-08 Raja R Harinath <rharinath@novell.com>
4842 Address parts of #58244 -- most of what's left is in the runtime
4843 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
4844 CS1509 error checks, and handle them for all assembly loads, not
4845 just the first invocation.
4846 (LoadModule): Likewise. Move handling of 'adder_method' ...
4847 * codegen.cs (AssemblyClass.AddModule): ... here.
4849 2006-11-02 Marek Safar <marek.safar@gmail.com>
4851 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
4852 IEnumerable<T> is ambiguous.
4854 2006-10-31 Marek Safar <marek.safar@gmail.com>
4856 A fix for bug #67689
4857 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
4858 GetEnumerator is ambiguous.
4860 * report.cs: Add new warning.
4862 2006-10-29 Marek Safar <marek.safar@gmail.com>
4864 A fix for bug #78602
4865 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4866 to protected member can be nested type.
4868 2006-10-28 Marek Safar <marek.safar@gmail.com>
4870 A fix for bug #78965
4871 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4872 to protected member must derive from current type.
4874 2006-10-27 Marek Safar <marek.safar@gmail.com>
4876 assign.cs: Reuses error method.
4878 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
4879 instead of type for constants.
4880 (Expression.Error_ValueAssignment): Common error method.
4882 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
4885 2006-10-27 Marek Safar <marek.safar@gmail.com>
4887 A fix for bug #79081
4888 * expression.cs (MemberAccess.DoResolve): Check nested type
4891 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
4893 * doc.cs : nested delegates were not handled. Fixed bug #79754.
4895 2006-10-26 Marek Safar <marek.safar@gmail.com>
4897 A fix for bug #76591
4898 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
4900 2006-10-26 Marek Safar <marek.safar@gmail.com>
4902 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
4903 type forwarder of the same type multiple times.
4905 2006-10-26 Raja R Harinath <rharinath@novell.com>
4908 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
4909 instance as an rvalue, even when we later resolve as an lvalue.
4911 2006-10-25 Martin Baulig <martin@ximian.com>
4913 * anonymous.cs: Fix #79673.
4915 2006-10-24 Marek Safar <marek.safar@seznam.cz>
4917 A fix for bug #79666
4918 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
4919 ignored when is optimized (= default value) as its value is already set.
4921 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4923 A fix for bug #79724
4924 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
4925 TypeContainer for type lookup.
4927 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4929 A fix for bug #79231
4930 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
4931 * expression.cs (OverloadResolve): Always convert type name for
4933 (ResolveNamespaceOrType): Don't confuse a nested type with any
4936 2006-10-18 Martin Baulig <martin@ximian.com>
4938 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
4940 2006-10-17 Miguel de Icaza <miguel@novell.com>
4942 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
4943 an int32, but requesting an int64 from the conversion
4945 2006-10-12 Martin Baulig <martin@ximian.com>
4948 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
4950 2006-10-12 Martin Baulig <martin@ximian.com>
4953 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
4955 2006-10-11 Miguel de Icaza <miguel@novell.com>
4957 * convert.cs: Remove broken code: I was doing the "Existance"
4958 tests for Implicit conversions.
4960 2006-10-10 Miguel de Icaza <miguel@novell.com>
4962 * convert.cs: Added one missing case in
4963 ImplicitStandardConversionExists uint64 to intptr.
4967 * typemanager.cs (uintptr_type): another core known type.
4969 * ecore.cs (OperatorCast): routine used to do cast operations that
4970 depend on op_Explicit. We could change some of the Decimal
4971 conversions to use this.
4973 This one has a probe mechanism that checks both types for an op_
4974 which it coudl be used to eliminate two classes: CastToDecimal
4975 and CastFromDecimal.
4977 * convert.cs: Implement the conversions documented in #59800
4979 2006-10-10 Martin Baulig <martin@ximian.com>
4981 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
4982 before RootScope.ResolveMembers().
4984 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
4985 `CurrentType' if appropriate.
4987 2006-10-09 Marek Safar <marek.safar@seznam.cz>
4989 A fix for bug #78568
4990 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
4991 when contains binary operators.
4992 * cs-parser.jay: Updated.
4994 2006-10-09 Martin Baulig <martin@ximian.com>
4997 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
4998 moved that into Define() and also do the other type parameter
4999 checks there. Fixes #79094. Added gtest-292.cs.
5002 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
5003 since that doesn't include type parameters; don't use `Ldelema'
5004 for type parameters. Fixes #78980. Added gtest-293.cs.
5006 2006-10-08 Marek Safar <marek.safar@seznam.cz>
5009 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
5010 conversion is allowed.
5012 2006-10-06 Marek Safar <marek.safar@seznam.cz>
5014 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
5015 error reporting when no error occurs.
5017 2006-10-06 Marek Safar <marek.safar@seznam.cz>
5019 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
5022 2006-10-06 Raja R Harinath <rharinath@novell.com>
5025 * class.cs (DefineTypeBuilder): Check circular dependencies before
5026 setting the parent of the TypeBuilder.
5027 (CheckRecursiveDefinition): Don't use 'BaseType', since
5028 it may not be valid until after DefineTypeBuilder. Use
5029 'base_type' instead.
5031 2006-10-04 Martin Baulig <martin@ximian.com>
5033 Merged the Anonymous Methods patch.
5035 * anonymous.cs, iterators.cs: The new anonymous methods code.
5037 * statement.cs (Variable): New public abstract class.
5038 (LocalInfo.Variable): New public property.
5039 (LocalInfo.ResolveVariable): New public method.
5040 (Block.Flags): Add `IsIterator'.
5041 (Block.AddVariable): Improved the CS0136 check.
5042 (Block.AnonymousChildren): New public property.
5043 (Block.AddAnonymousChild): New public method.
5044 (ToplevelBlock): Update to use the new anonymous method framework.
5045 (ToplevelBlock.ctor): `container' is now a `Block' and not a
5046 `ToplevelBlock'; this is required to correctly implement the
5048 (Fixed, Using): Use `TemporaryVariable' instead of directly
5049 creating the `LocalBuilder'.
5051 * parameter.cs (Parameter.ResolveVariable): New public method.
5052 (Parameters.ResolveVariable): Likewise.
5054 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
5056 * class.cs (TypeContainer): Replaced the `iterators' list and
5057 corresponding methods with a list of `CompilerGeneratedClass'es.
5058 (TypeContainer.ResolveMembers): New public method.
5059 (Method): `IIteratorContainer' has been replaced by
5062 * expression.cs (VariableReference): New public abstract base
5063 class for `LocalVariableReference', `ParameterReference' and
5066 * codegen.cs (EmitContext): Removed `capture_context',
5067 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
5068 (EmitContext.EmitThis): Removed.
5070 * cs-parser.jay: Replace `iterator_container' with
5073 2006-10-04 Martin Baulig <martin@ximian.com>
5075 * generic.cs (GenericMethod): Don't make this abstract.
5076 (Constraints.Clone): Added dummy implementation.
5078 2006-10-04 Raja R Harinath <harinath@gmail.com>
5081 * namespace.cs (LookForAnyGenericType): Avoid nullref on
5082 'declspaces'. Avoid allocating arrays willy-nilly.
5085 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
5086 cases out of the switch.
5088 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5090 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
5091 message when non-generic type is used with the type arguments.
5092 * expression.cs: Updated.
5094 2006-09-28 Raja R Harinath <rharinath@novell.com>
5097 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
5098 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5099 Change semantics slightly. Don't insist on having only one
5100 temporary EmptyExpression -- just throttle the creation of new ones.
5103 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
5104 non-interfaces too. If no methods are found, don't try to create
5107 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5109 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
5112 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
5113 us produce better error message.
5115 2006-09-27 Marek Safar <marek.safar@seznam.cz>
5117 * expression.cs (Binary.ResolveOperator): Warn about a side effect
5118 of the `|' operator.
5120 * report.cs: A new warning added.
5122 2006-09-27 Martin Baulig <martin@ximian.com>
5124 * generic.cs (GenericMethod): Don't make this abstract.
5126 2006-09-27 Martin Baulig <martin@ximian.com>
5129 (InternalErrorException): Added overloaded ctor taking a params array.
5131 2006-09-26 Marek Safar <marek.safar@seznam.cz>
5133 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
5134 Fixed the cases when same error was reported twice.
5136 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
5137 now report symbol information.
5139 2006-09-25 Martin Baulig <martin@ximian.com>
5141 * class.cs: Completely unified with the gmcs version.
5143 2006-09-25 Martin Baulig <martin@ximian.com>
5145 * typemanager.cs (TypeManager.IsNullableType): New public function.
5146 (TypeManager.IsNullableTypeOf): Likewise.
5147 (TypeManager.IsNullableValueType): Likewise.
5149 * class.cs (MethodCore): Added the `GenericMethod' argument from
5150 gmcs and also unified all classes derived from `MethodCore' with gmcs.
5152 2006-09-24 Raja R Harinath <harinath@gmail.com>
5154 * convert.cs: Unify with gmcs version.
5156 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5158 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
5159 verify them as well.
5161 * report.cs: New warning.
5163 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5165 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
5166 for anonymous block with out argument.
5168 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5170 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
5171 not used private events only.
5173 2006-09-23 Marek Safar <marek.safar@seznam.cz>
5175 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
5177 * const.cs (Const.Define): Check for constant type.
5178 (Const.IsConstantTypeValid): Looks for valid constant types.
5180 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
5182 * ecore.cs (EmptyConstantCast): New common class for all constant based
5185 * expression.cs (Is.DoResolve): Handle null constant especially.
5186 (New.DoResolve): Check for new void().
5187 (MemberAccess.DoResolve): Cope with all kind of nulls.
5189 * literal.cs (NullConstant): Uses EmptyConstantCast.
5190 (NullDefault): Based on EmptyConstantCast.
5191 (NullLiteral): Uses EmptyConstantCast.
5193 * statement.cs (Block.ResolveMeta): Check for constant type.
5195 2006-09-22 Martin Baulig <martin@ximian.com>
5197 * delegate.cs, attribute.cs: Merged with the gmcs versions.
5199 2006-09-22 Raja R Harinath <rharinath@novell.com>
5201 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
5205 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
5206 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
5209 2006-09-22 Martin Baulig <martin@ximian.com>
5211 * ecore.cs: Merged with the gmcs version.
5213 * generic.cs (ConstructedType): New dummy class.
5214 (TypeArguments): Don't make this abstract.
5217 (TypeManager.IsGenericTypeDefinition): New method.
5218 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
5220 2006-09-22 Raja R Harinath <rharinath@novell.com>
5222 * expression.cs (ComposedCast): Check for arrays of TypedReference
5223 before creating the type, not after.
5225 2006-09-21 Marek Safar <marek.safar@seznam.cz>
5227 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
5228 after ToType change.
5230 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
5231 when constant must be implicitly convertible.
5233 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
5235 * ecore.cs (NullCast): Derives from NullConstant.
5237 * expression.cs (Is.DoResolve): Removed useless variables.
5238 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
5239 (New.Constantify): Add enum support.
5240 (MemberAccess.DoResolve): Add warning when accessing null constant or
5243 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
5246 * literal.cs (NullConstant): New abstract class with common
5247 functionality for all null specializations.
5248 (NullDefault): Represents default(X) when result can be
5250 (NullLiteral): Updated.
5252 * report.cs: Add new warning.
5254 2006-09-21 Martin Baulig <martin@ximian.com>
5256 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
5258 2006-09-21 Martin Baulig <martin@ximian.com>
5260 * generic.cs (GenericConstraints): New dummy class.
5261 (Constraints): Likewise.
5262 (TypeParameter): Likewise.
5263 (TypeParameterName): Likewise.
5264 (GenericMethod): Likewise.
5266 * typemanager.cs (TypeManager.GetGenericArguments): New method.
5268 * decl.cs: Merged with the gmcs version.
5270 2006-09-21 Raja R Harinath <rharinath@novell.com>
5272 * generic.cs (TypeParameter): Implement IMemberContainer.
5273 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
5275 * rootcontext.cs: Unify with gmcs version.
5277 * report.cs: Unify with gmcs version.
5278 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
5279 from gmcs/generics.cs.
5280 * generics.cs (TypeParameter): New dummy class.
5282 * support.cs: Unify with gmcs version.
5284 2006-09-20 Raja R Harinath <rharinath@novell.com>
5286 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
5287 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
5289 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
5290 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
5291 * mcs.exe.sources: Add generic.cs.
5293 * codegen.cs: Unify with gmcs version.
5295 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
5296 (EmitContext): Add GenericDeclContainer implementation.
5297 * decl.cs (MemberCore, DeclSpace): Likewise.
5298 * namespace.cs: Remove #ifdef GMCS_SOURCE.
5300 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
5301 MCS TypeManager has a corresponding dummy method.
5303 2006-09-19 Martin Baulig <martin@ximian.com>
5305 * expression.cs: Completely merged with the gmcs version.
5307 2006-09-19 Martin Baulig <martin@ximian.com>
5309 * expression.cs (Invocation): Merged with the gmcs version.
5310 (ArrayAccess.GetStoreOpcode): Likewise.
5312 2006-09-19 Martin Baulig <martin@ximian.com>
5315 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
5316 (TypeManager.IsGenericMethodDefinition): Likewise.
5318 2006-09-19 Martin Baulig <martin@ximian.com>
5321 (TypeManager.IsEqual): Moved the gmcs implementation here.
5322 (TypeManager.DropGenericTypeArguments): Likewise.
5323 (TypeManager.DropGenericMethodArguments): Likewise.
5324 (TypeManager.GetTypeArguments): Moved here from gmcs.
5325 (TypeManager.HasGenericArguments): Likewise.
5327 2006-09-19 Martin Baulig <martin@ximian.com>
5329 * expression.cs (Binary): Merged with the gmcs version.
5331 2006-09-19 Martin Baulig <martin@ximian.com>
5333 * expression.cs (Probe, As, Is): Merged with the gmcs version.
5335 2006-09-19 Martin Baulig <martin@ximian.com>
5337 * typemanager.cs: Merged with the gmcs version.
5339 2006-09-16 Raja R Harinath <rharinath@novell.com>
5341 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
5342 * driver.cs: Likewise.
5344 2006-09-16 Marek Safar <marek.safar@seznam.cz>
5347 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
5348 only if parent type is class.
5349 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
5352 2006-09-15 Marek Safar <marek.safar@seznam.cz>
5355 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
5357 * typemanager.cs(CSharpName): Converts NullType to null.
5359 2006-09-15 Martin Baulig <martin@ximian.com>
5362 (TypeManager.GetMethodName): Added mcs implementation.
5363 (TypeManager.IsEqual): Likewise.
5366 (SimpleName.RemoveGenericArity): Added dummy implementation.
5368 * pending.cs: Merged with the gmcs version.
5370 2006-09-15 Martin Baulig <martin@ximian.com>
5372 * statement.cs: Merge with the gmcs version.
5374 2006-09-15 Martin Baulig <martin@ximian.com>
5376 * statement.cs (Switch): Merge with the gmcs implementation
5377 (without nullables), which is newer.
5379 2006-09-15 Martin Baulig <martin@ximian.com>
5381 * statement.cs (Block.Variables): Make this public.
5382 (ToplevelBlock.Parameters): Make this a property.
5383 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
5385 2006-09-15 Martin Baulig <martin@ximian.com>
5387 * namespace.cs: Merge with the gmcs version.
5389 2006-09-15 Martin Baulig <martin@ximian.com>
5391 * decl.cs (MemberName): Minor code cleanups.
5393 2006-09-15 Martin Baulig <martin@ximian.com>
5395 * parameter.cs: Merge with the gmcs version.
5397 2006-09-15 Martin Baulig <martin@ximian.com>
5399 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
5400 and an error in mcs.
5402 2006-09-15 Martin Baulig <martin@ximian.com>
5404 * flowanalysis.cs: Merged from GMCS; added the generics code into
5405 a `GMCS_SOURCE' conditional so we can share this file.
5407 2006-09-08 Martin Baulig <martin@ximian.com>
5409 * typemanager.cs (TypeManager.interlocked_type): New public field.
5410 (TypeManager.int_interlocked_compare-exchange): New public field.
5411 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
5412 enumerator types here and call InitGenericCoreTypes().
5413 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
5414 after calling InitEnumUnderlyingTypes().
5417 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
5418 `classes_second_stage'.
5420 2006-09-14 Marek Safar <marek.safar@seznam.cz>
5422 * assign.cs, ecore.cs, expression.cs: Share error message text.
5423 * class.cs (FieldMember.Define): Check for varible of static type.
5424 * driver.cs (LoadAssembly): Uses error output for errors.
5425 * statement.cs: Updated.
5427 2006-09-08 Marek Safar <marek.safar@seznam.cz>
5429 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
5432 2006-09-07 Martin Baulig <martin@ximian.com>
5435 (MainDriver): Revert r62663 from Marek; see #70506 for details.
5437 2006-08-29 Miguel de Icaza <miguel@novell.com>
5439 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
5441 2006-08-17 Miguel de Icaza <miguel@novell.com>
5443 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
5444 #52019 and #79064, the use of the \uXXXX sequence in source code
5445 to represent unicode characters.
5447 2006-08-15 Marek Safar <marek.safar@seznam.cz>
5449 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
5451 * class.cs, ecore.cs, statement.cs: Merged to one error message.
5453 2006-08-13 Miguel de Icaza <miguel@novell.com>
5455 * assign.cs: Catch attempts to assign to a method groups in += and
5458 2006-08-13 Marek Safar <marek.safar@seznam.cz>
5461 * cs-parser.jay: Don't destroy current array type by typeof of array's.
5463 2006-08-12 Marek Safar <marek.safar@seznam.cz>
5465 * class.cs (Method.Define): Issue a warning when generic method looks like
5467 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
5470 2006-08-09 Marek Safar <marek.safar@seznam.cz>
5472 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
5474 * decl.cs (MemberCache.FindMembers): When container is interface we need to
5475 search all base interfaces as a member can be ambiguous.
5476 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
5477 Constructor member type filter.
5478 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
5479 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
5480 reporting for returned memberinfos.
5481 * report.cs: Updated.
5482 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
5483 version to work on all runtimes.
5484 (TypeManager.RealMemberLookup): Removed members filtering.
5486 2006-08-08 Raja R Harinath <rharinath@novell.com>
5488 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
5489 (PropertyExpr.EmitAssign): Likewise.
5490 * expression.cs (Indirection.EmitAssign): Likewise.
5491 (LocalVariableReference.EmitAssign): Likewise.
5492 (ParameterReference.EmitAssign): Likewise.
5493 (Invocation.EmitArguments): Likewise.
5494 (ArrayAccess.EmitAssign): Likewise.
5495 (IndexerAccess.EmitAssign): Likewise.
5496 (This.EmitAssign): Likewise.
5497 (ConditionalLogicalOperator.Emit): Likewise.
5500 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
5501 instead of ArrayList. If the hashtable has a LocalBuilder, don't
5502 leave it in after returning it.
5503 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
5505 2006-08-06 Marek Safar <marek.safar@seznam.cz>
5507 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
5510 2006-08-03 Raja R Harinath <rharinath@novell.com>
5512 Fix cs0146-3.cs and cs0146-4.cs.
5513 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
5514 enclosing types don't depend on the current type.
5516 2006-08-02 Raja R Harinath <rharinath@novell.com>
5519 * class.cs (TypeContainer.DoDefineMembers): Use
5520 FindBaseMemberWithSameName on Parent, since we're interested in
5521 whether we hide inherited members or not.
5522 (FindBaseMemberWithSameName): Make slightly more robust.
5524 Fix the non-generic testcase from #77396
5525 * decl.cs (DeclSpace.DeclContainer): Remove override.
5527 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
5528 declspaces for doppelgangers too.
5529 (UsingEntry): Implement IResolveContext.
5530 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
5531 'this' as the resolve context.
5532 (LocalAliasEntry): Likewise.
5534 Implement parts of #77403
5535 * roottypes.cs (RootDeclSpace): New. Used to represent the
5536 toplevel declaration space. Each namespace declaration introduces
5537 a "partial" root declaretion space.
5538 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
5539 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
5540 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
5541 from 'current_namespace.SlaveDeclSpace'.
5542 (namespace_declaration): Likewise.
5543 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
5544 check. It can't happen now.
5545 * decl.cs (DeclSpace.LookupType): Likewise.
5546 * driver.cs (MainDriver): Sanity check.
5548 2006-08-01 Raja R Harinath <rharinath@novell.com>
5550 * decl.cs (DeclSpace.FindNestedType): Remove.
5551 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
5552 LookupTypeContainer to get the container of the nested type.
5553 * class.cs (TypeContainer.FindNestedType): Make non-override.
5555 2006-07-31 Raja R Harinath <rharinath@novell.com>
5557 * decl.cs (DeclSpace.PartialContainer): Move field from ...
5558 * class.cs (TypeContainer.PartialContainer): ... here.
5559 (TypeContainer.AddBasesForPart): New helper.
5560 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
5562 * cs-parser.jay (current_class): Convert to DeclSpace.
5563 (struct_declaration, interface_declaration, class_declaration):
5564 Use AddBasesForPart instead of .Bases directly.
5565 * const.cs, iterators.cs: Update to changes.
5567 2006-07-28 Raja R Harinath <rharinath@novell.com>
5569 * class.cs (TypeContainer.AddMemberType): Rename from
5571 (TypeContainer.AddMember): Rename from AddToMemberContainer.
5572 (AddTypeContainer): New. Combine AddClassOrStruct and
5574 (AddPartial): Update. Add 'is_partial' argument.
5575 * roottypes.cs: Update to changes.
5576 * cs-parser.jay (push_current_class): New helper for handling
5577 current_container and current_class.
5578 (struct_declaration, interface_declaration, class_declaration):
5581 2006-07-26 Raja R Harinath <rharinath@novell.com>
5583 * roottypes.cs: Rename from tree.cs.
5585 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
5586 * tree.cs (Tree, ITreeDump): Remove types.
5587 * rootcontext.cs (tree, Tree): Remove fields.
5588 (root, ToplevelTypes): New.
5589 * *.cs: Update to rename.
5591 * tree.cs (Tree.RecordDecl): Remove.
5592 (RootTypes.AddToTypeContainer): Record the toplevel type in its
5594 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
5596 2006-07-23 Raja R Harinath <harinath@gmail.com>
5598 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
5599 DoFlowAnalysis and OmitStructFlowAnalysis here.
5600 (ec.With): Rename from WithUnsafe and generalize.
5601 (ec.WithCheckState): Remove. All users can be handled by 'With'.
5602 (ec.WithFlowAnalyis): New.
5603 * ecore.cs, expression.cs, statement.cs: Update.
5605 2006-07-22 Raja R Harinath <harinath@gmail.com>
5607 * statement.cs (Block.ResolveMeta): Simplify slightly.
5609 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
5610 multiple boolean fields. Convert InUnsafe, constant_check_state,
5611 check_state to flags.
5612 (CheckState, ConstantCheckState): Update.
5613 (InUnsafe): New read-only property.
5614 (FlagsHandle): Rename from CheckStateHandle and convert to handle
5616 (WithUnsafe): New helper similar to WithCheckState.
5617 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
5618 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
5620 2006-07-21 Raja R Harinath <rharinath@novell.com>
5622 Make comparisons use the same IL irrespective of whether they're
5623 in a 'checked' or 'unchecked' context: one of the issues in #78899
5624 * codegen.cs (EmitContext.CheckState): Make read-only property.
5625 (EmitContext.ConstantCheckState): Likewise.
5626 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
5627 helper that implement a save/restore stack for CheckState
5628 values. This is the only way to change check-state.
5629 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
5630 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
5631 (CheckedExpr.EmitBranchable): New forwarding method.
5632 (UnCheckedExpr): Likewise.
5633 * statement.cs (Block.ResolveMeta): Use WithCheckState.
5634 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
5635 (Checked.Resolve, checked.DoEmit): Likewise.
5637 2006-07-20 Miguel de Icaza <miguel@novell.com>
5639 * anonymous.cs: Cache the resolved anonymous delegate, and return
5640 this so that the ResolveTopBlock is only triggered once, not
5643 Currently we trigger ResolvetopBlock twice due to a first pass of
5644 argument check compatibility, and a second pass that does the
5647 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5649 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
5651 * rootcontext.cs (Reset): Add helper_classes.
5653 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5656 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
5659 2006-07-13 Miguel de Icaza <miguel@novell.com>
5661 * statement.cs (Lock): Handle expressions of type
5662 TypeManager.null_type specially. Fixes #78770
5664 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5666 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
5669 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5671 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
5672 for accessors as well.
5673 * ecore.cs (EventExpr): Add AccessorTable.
5675 2006-07-01 Marek Safar <marek.safar@seznam.cz>
5678 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
5679 for CS0122 where appropriate.
5680 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
5682 (Filter): Assembly can be null in the case of top level attributes.
5684 2006-06-25 Marek Safar <marek.safar@seznam.cz>
5688 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
5689 is done at global level.
5691 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5693 A fix for #77002, Implemented TypeForwarder support.
5695 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
5696 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
5697 * typemanager.cs (): Add type_forwarder_attr_type.
5699 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5701 * report.cs: Add CS0469 warning.
5703 2006-06-21 Martin Baulig <martin@ximian.com>
5705 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
5706 the `try'-block, so we also report CS0016 etc. there.
5708 2006-06-21 Martin Baulig <martin@ximian.com>
5711 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
5713 2006-06-21 Martin Baulig <martin@ximian.com>
5715 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
5716 also report CS1686 for parameters.
5718 2006-06-21 Martin Baulig <martin@ximian.com>
5720 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
5721 instead of an error if the value is not implicitly convertible to
5722 the switch types; fixes #77964.
5724 2006-06-21 Raja R Harinath <rharinath@novell.com>
5727 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
5728 FieldBuilder is null.
5731 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
5732 'left' and 'right' before error-checking.
5734 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
5736 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
5738 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
5739 (FieldExpr.DoResolve): likewise.
5740 (PropertyExpr.InstanceResolve): likewise.
5741 (EventExpr.InstanceResolve): likewise.
5743 2006-06-04 Marek Safar <marek.safar@seznam.cz>
5745 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
5746 attribute applicable tests for attribute argument.
5748 2006-06-02 Raja R Harinath <rharinath@novell.com>
5751 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
5752 (Binary.OverloadResolve_PredefinedIntegral): New.
5753 (Binary.OverloadResolve_PredefinedFloating): New.
5754 (Binary.OverloadResolve_PredefinedString): New.
5755 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
5756 Follow the standard more closely, and treat numeric promotions in
5757 terms of overload resolution.
5758 (Binary.CheckShiftArguments): Simplify.
5760 2006-06-01 Raja R Harinath <rharinath@novell.com>
5762 * flowanalysis.cs (MyBitVector): Simplify representation.
5763 (MyBitVector.Clone): Avoid allocating BitArray.
5764 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
5765 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
5766 (*): Update. Change all references to MyBitVector.And and
5767 MyBitVector.Or to &= and |=.
5769 2006-05-29 Raja R Harinath <rharinath@novell.com>
5772 * cs-parser.jay (formal_parameter_list): Extend the pattern below
5773 to param arguments too.
5775 2006-05-26 Miguel de Icaza <miguel@novell.com>
5777 * cs-parser.jay: Catch another parsing form for arglist being
5778 followed by other arguments. Fixes #78313.
5780 2006-05-24 Raja R Harinath <rharinath@novell.com>
5782 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
5783 checking of out parameters to ...
5784 (FlowBranchingToplevel.Merge): ... here.
5785 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
5786 set, propagate the origin upward, and only complain if there was
5788 (FlowBranchingException.AddContinueOrigin): Likewise.
5789 (FlowBranchingException.AddReturnOrigin): Likewise.
5790 (FlowBranchingException.AddGotoOrigin): Likewise.
5792 2006-05-23 Raja R Harinath <rharinath@novell.com>
5794 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
5795 unreachable, skip it.
5796 (FlowBranchingException.Merge): Always propagate jumps, even if
5797 the finally block renders subsequent code unreachable.
5799 2006-05-18 Raja R Harinath <rharinath@novell.com>
5802 * statement.cs (Goto.Resolve): Move responsibility for resolving
5803 'goto' to FlowBranching.AddGotoOrigin.
5804 (Goto.SetResolvedTarget): New. Callback to set the
5805 LabeledStatement that's the target of the goto.
5806 (Goto.DoEmit): Use Leave instead of Br when crossing an
5807 unwind-protect boundary.
5808 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
5809 LookupLabel and adjust to new semantics.
5810 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
5811 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
5812 Goto.SetResolvedTarget to update target.
5813 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
5814 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
5815 AddBreakOrigin & co. Delay propagation until ...
5816 (FlowBranchingException.Merge): ... this.
5818 * statement.cs (Block.Resolve): Always depend on flow-branching to
5819 determine unreachability. Kill workaround that originally emitted
5820 only one statement after an "unreachable" label (see infloop in
5823 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
5824 This is still "wrong", but anything better would probably need a
5825 multi-pass algorithm.
5826 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
5827 usage vector. Force current usage vector to be reachable, to
5828 optimistically signify backward jumps.
5829 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
5831 (FlowBranchingLabeled.Merge): New. If no backward jump was
5832 detected, return the original salted-away usage vector instead,
5833 updated with appropriate changes. Print unreachable warning if
5835 * statement.cs (Block.Resolve): Don't print unreachable warning on
5836 a labeled statement.
5838 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
5840 * driver.cs: Pass filename without path to AssemblyBuilder's
5841 AddResourceFile. Fixes bug #78407.
5843 2006-05-17 Raja R Harinath <rharinath@novell.com>
5845 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
5846 * flowanalysis.cs (FlowBranchingLabeled): ... here.
5847 (FlowBranching.MergeChild): Overwrite
5848 reachability information from Labeled branchings too.
5850 2006-05-16 Raja R Harinath <rharinath@novell.com>
5852 * statement.cs (Goto.Resolve): Merge jump origins here ...
5853 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
5855 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
5856 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
5857 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
5858 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
5860 * statement.cs (Goto.Resolve): ... not here.
5861 (Goto.Emit): Remove CS1632 check.
5863 2006-05-14 Marek Safar <marek.safar@seznam.cz>
5865 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
5868 2006-05-11 Raja R Harinath <rharinath@novell.com>
5870 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
5871 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
5872 (FlowBranchingException.Label): Likewise.
5874 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
5876 (MyBitVector.Or): Use it to avoid losing information (Count).
5877 (FlowBranching.MergeOrigins): Likewise.
5879 * flowanalysis.cs (UsageVector.IsDirty): Remove.
5880 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
5881 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
5882 (UsageVector.ToString): Simplify.
5883 (UsageVector.MergeSiblings): Move here from ...
5884 (FlowBranching.Merge): ... here.
5885 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
5888 2006-05-10 Raja R Harinath <rharinath@novell.com>
5890 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
5891 null bitvector is treated as all-true.
5893 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
5894 (MyBitVector): Rationalize invariants. 'vector != null' implies
5895 that we have our own copy of the bitvector. Otherwise,
5896 'InheritsFrom == null' implies all inherited bits are true.
5898 2006-05-09 Marek Safar <marek.safar@seznam.cz>
5900 * statement.cs (LocalInfo): Add IsConstant.
5901 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
5902 local variable for constants.
5904 2006-05-09 Raja R Harinath <rharinath@novell.com>
5906 * flowanalysis.cs (MyBitVector.Empty): New.
5907 (MyBitVector): Don't allow InheritedFrom to be null.
5908 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
5909 (UsageVector, FlowBranching): Update to changes.
5911 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
5912 recursion. The 'Parent == null' condition isn't sufficient for
5914 (FlowBranching.AddBreakOrigin): Likewise.
5915 (FlowBranching.AddContinueOrigin): Likewise.
5916 (FlowBranching.AddReturnOrigin): Likewise.
5917 (FlowBranching.StealFinallyClauses): Likewise.
5918 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
5919 (FlowBranching.CheckOutParameters): Likewise.
5920 (FlowBranchingToplevel): Terminate all the above recursions here.
5921 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
5922 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
5924 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
5926 (FlowBranchingToplevel): New. Empty for now.
5927 (FlowBranching.MergeTopBlock): Update.
5928 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
5929 branching for the anonymous delegate.
5930 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
5932 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
5933 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
5934 information at the start of the merge. Reorganize.
5936 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5938 * class.cs (MethodData.Define): Method cannot implement interface accessor.
5940 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5942 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
5943 to newly introduced ctor.
5945 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
5946 message to one place.
5947 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
5950 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5952 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
5954 * ecore.cs (Expression.ResolveAsConstant): Updated.
5956 * statement.cs (ResolveMeta): Updated.
5958 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5960 * cs-parser.jay: __arglist cannot be used in initializer.
5962 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5965 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
5968 2006-05-05 Raja R Harinath <rharinath@novell.com>
5970 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
5971 (LabeledStatement): Add 'name' parameter.
5972 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
5973 (Block.AddLabel): Update to changes.
5974 * cs-parser.jay (labeled_statement): Likewise.
5976 * flowanalysis.cs (BranchingType.Labeled): New.
5977 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
5978 (FlowBranchingLabeled): New. Does nothing for now, but will
5979 eventually handle 'goto' flows.
5980 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
5981 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
5982 that's terminated ...
5983 (Block.Resolve): ... here.
5985 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
5986 (UsageVector.MergeFinallyOrigins): Likewise.
5987 (FlowBranching.InTryOrCatch): Likewise.
5988 (FlowBranching.AddFinallyVector): Likewise.
5989 (FlowBranchingException): Update to changes.
5992 * statement.cs (Return.Resolve): Move error checking to ...
5993 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
5994 (FlowBranchingException): Handle return origins like break and
5996 (FlowBranching.UsageVector.CheckOutParameters): Remove.
5998 2006-05-04 Marek Safar <marek.safar@seznam.cz>
6001 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
6004 2006-05-04 Marek Safar <marek.safar@seznam.cz>
6007 * class.cs (MethodData.Define): Do public accessor check only when method
6008 implements an interface.
6010 2006-05-04 Raja R Harinath <rharinath@novell.com>
6012 Remove special handling of 'break'
6013 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
6014 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
6015 (UsageVector.Break): Remove.
6016 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
6018 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
6020 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
6021 UsageVector.Breaks (). Don't set NeedsReturnLabel.
6023 2006-05-03 Marek Safar <marek.safar@seznam.cz>
6026 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
6027 be the interface member.
6029 2006-05-03 Marek Safar <marek.safar@seznam.cz>
6032 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
6033 for emitting small (int) values.
6035 2006-05-03 Raja R Harinath <rharinath@novell.com>
6038 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
6039 control-flow passes through the 'finally' after merging-in all the
6040 control-flows from 'try' and the 'catch' clauses.
6042 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
6043 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
6044 always true at the only non-recursive entry point.
6045 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
6046 FlowBranchingBreakable.
6047 (FlowBranchingLoop): Remove.
6048 * statement.cs (Return.DoResolve): Update to changes.
6051 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
6052 (FlowBranching.CreateBranching): Handle it: create a
6053 FlowBranchingContinuable.
6054 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
6055 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
6056 except that it handles the 'continue' command.
6057 (FlowBranching.UsageVector.MergeOrigins): Rename from
6059 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
6060 except that it overrides AddContinueOrigin.
6061 (FlowBranchingException): Override AddContinueOrigin, similar to
6063 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
6064 Create a new branching around the embedded statement.
6065 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
6066 control flow after the embedded statement.
6067 (Continue.Resolve): Move all error checking to AddContinueOrigin.
6069 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
6070 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
6071 FlowBranchingBreakable.
6072 (FlowBranchingSwitch): Remove.
6075 * statement.cs (Break.Resolve): Simplify. Move responsibility for
6076 error reporting to ...
6077 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
6078 Rename from 'AddBreakVector'. Add new location argument. Return
6079 a bool indicating whether the 'break' crosses an unwind-protect.
6080 (FlowBranchingException.AddBreakOrigin): Add.
6081 (FlowBranchingException.Merge): Propagate 'break's to surrounding
6082 flowbranching after updating with the effects of the 'finally'
6084 (FlowBranchingBreakable): New common base class for
6085 FlowBranchingLoop and FlowBranchingSwitch.
6087 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
6089 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
6091 2006-05-02 Raja R Harinath <rharinath@novell.com>
6093 * statement.cs (Do.Resolve): If the loop is infinite, set the
6095 (While.Resolve, For.Resolve): Set a barrier after the embedded
6096 statement. There's no direct control flow that goes from the end
6097 of the embedded statement to the end of the loop.
6098 * flowanalysis.cs (FlowBranching.Infinite): Remove.
6099 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
6100 above ensure that the reachability is correctly computed.
6102 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
6103 (UsageVector.MergeBreakOrigins): If the current path is
6104 unreachable, treat it as if all parameters/locals are initialized.
6105 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
6106 infinite loops before merging-in break origins.
6108 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
6109 (Reachability.Reachable): Split part into ...
6110 (Reachability.Unreachable): ... this. Simplify.
6111 (Reachability.IsUnreachable): Use 'Unreachable' instead.
6113 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
6114 (Reachability.SetThrowsSometimes): Likewise.
6115 (FlowBranchingBlock.MergeTopBlock): Don't compare against
6116 TriState.Always, use corresponding property.
6117 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
6118 (Block.Resolve): Likewise. Remove some redundant checks.
6120 2006-05-02 Raja R Harinath <harinath@gmail.com>
6122 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
6123 (Reachability.Meet): Don't bother checking AlwaysThrows --
6124 barrier is always set.
6125 (FlowBranchingBlock.Merge): Likewise.
6127 2006-05-01 Raja R Harinath <harinath@gmail.com>
6129 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
6130 checks for unreachable.
6132 2006-05-01 Marek Safar <marek.safar@seznam.cz>
6135 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
6137 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
6138 whether field is really assigned.
6140 2006-04-30 Raja R Harinath <harinath@gmail.com>
6142 * flowanalysis.cs (Reachability): Make 4-argument constructor
6144 (Reachability.Meet): Rename from 'And'. Remove static variant.
6145 (Reachability.Always): Rename from the highly misleading
6146 'Reachability.Never'.
6147 (FlowBranching.Merge): Update to changes. Mark an impossible
6148 situation with a 'throw'.
6149 (*): Update to changes.
6151 2006-04-29 Raja R Harinath <harinath@gmail.com>
6153 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
6155 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
6156 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
6157 (*): Update to changes.
6158 * statement.cs: Update to changes.
6160 2006-04-28 Marek Safar <marek.safar@seznam.cz>
6163 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
6165 2006-04-28 Raja R Harinath <harinath@gmail.com>
6167 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
6170 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
6171 argument to two arguments: an usage-vector and a bool. Move call
6172 to FlowBranching.Merge () ...
6173 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
6175 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
6176 handling of loop and switch reachability to ...
6177 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
6179 2006-04-27 Raja R Harinath <harinath@gmail.com>
6181 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
6182 handling to FlowBranchingLoop.InLoop.
6183 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
6185 2006-04-26 Marek Safar <marek.safar@seznam.cz>
6188 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
6189 anonymous method is allowed from AnonymousContainer here.
6191 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
6193 2006-04-24 Raja R Harinath <rharinath@novell.com>
6196 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
6198 2006-04-23 Marek Safar <marek.safar@seznam.cz>
6201 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
6202 (DoubleConstant.Reduce): Ditto.
6204 2006-04-23 Raja R Harinath <rharinath@novell.com>
6206 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
6207 Remove 'lvalue_right_side' argument. Move parts to ...
6208 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
6209 (LocalVariable.DoResolveLValue): ... these.
6211 2006-04-21 Raja R Harinath <rharinath@novell.com>
6214 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
6215 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
6216 (LocalVariableReference.DoResolveBase): Use it to implement new
6218 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
6219 (Argument.Resolve): Simplify. Move CS1510 check ...
6220 * ecore.cs (Expression.ResolveLValue): ... here.
6221 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
6222 (PropertyExpr.DoResolveLValue): Likewise.
6223 (FieldExpr.Report_AssignToReadonly): Likewise.
6224 (FieldExpr.DoResolve): Add 'out_access' argument. Use
6225 LValueMemberAccess or LValueMemberOutAccess on instance depending
6227 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
6228 DoResolve as appropriate.
6230 2006-04-20 Raja R Harinath <rharinath@novell.com>
6233 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
6234 implicit conversions on 'out' and 'ref' arguments.
6236 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
6237 improve clarity. Remove dead code.
6240 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
6241 (Catch.Resolve): Resolve VarBlock if it exists.
6243 2006-04-19 Miguel de Icaza <miguel@novell.com>
6245 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
6246 twice, this was some residual code, the enumerator was emitted
6247 properly in the two branche of if later.
6249 2006-04-19 Raja R Harinath <rharinath@novell.com>
6251 * expression.cs (Cast.ResolveLValue): Remove. The result of a
6252 cast is never an lvalue.
6253 (Cast.DoResolve, Cast.ResolveRest): Combine.
6254 (Argument.Emit): Simplify slightly. Move 'Expr is
6255 IMemoryLocation' check ...
6256 (Argument.Resolve): ... here.
6257 (Argument.Error_LValueRequired): Remove. Inline into only user.
6259 Simplifications. Fix cs0191-2.cs
6260 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
6261 CS1649 and CS1651 to ...
6262 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
6263 the actual selection of the error code and message to a lookup
6264 table. Add a dummy return value to simplify callsites.
6265 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
6266 readonly fields of other instances of the same type. Move CS0197
6268 * expression.cs (Argument.Resolve): ... here. Simplify code.
6269 Ensure that ec.InRefOutArgumentResolving is only set during LValue
6270 resolution of an out or ref argument. The code simplification
6271 above uses this invariant.
6273 2006-04-18 Raja R Harinath <rharinath@novell.com>
6275 Possibly fix #77752. Fix cs1690-[4-7].cs.
6276 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
6277 CheckMarshallByRefAccess. Drop parameter.
6278 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
6280 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
6282 * report.cs (AllWarnings): Add CS1690.
6283 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
6285 (LocalVariableReference.DoResolveBase): Update.
6287 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6289 * class.cs (MethodOrOperator): Moved common parts from method class.
6290 detect obsolete attributes.
6291 (Method.Define): Simplified as it reuses code from base.
6292 (Constructor.ValidAttributeTargets): Fixed issue found during
6294 (Destructor.ValidAttributeTargets): Fixed issue found during
6296 (Operator): Finished refactoring set off by #78020. Operator class is now
6297 ordinary method class.
6299 * anonymous.cs: Updated.
6301 * decl.cs (DeclSpace): Add IsGeneric
6303 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6305 * class.cs (Constructor.Emit): Don't emit the attributes twice.
6307 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6309 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
6310 detect obsolete attributes.
6311 (Method.CreateEmitContext): Moved to MethodOrOperator.
6313 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6316 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
6317 customized exception to make crash detection easier.
6318 (MethodOrOperator): Started to work on new base class for methods and
6320 (Method): Derives from MethodOrOperator.
6321 (Constructor.Emit): Emits its own attributes.
6322 (AbstractPropertyEventMethod.Emit): Ditto.
6323 (Operator): Derives from MethodOrOperator, will refactor fully in extra
6325 (Operator.Emit): It's temporary more tricky than should be.
6327 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
6329 * report.cs (InternalErrorException): Add ctor with inner exception.
6331 2006-04-08 Marek Safar <marek.safar@seznam.cz>
6334 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
6337 2006-04-07 Marek Safar <marek.safar@seznam.cz>
6340 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
6343 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6345 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
6346 attribute is present and Guid not.
6347 (Interface.ApplyAttributeBuilder): Ditto.
6349 * attribute.cs: Add error message.
6351 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6355 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
6356 sources (it's composite) so hold them in extra array as they are used in
6357 Emit phase only. It worked in the previous versions by mistake.
6358 (Attribute.Emit): Emit attribute for more owners when exist.
6360 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
6361 it has now different behaviour.
6363 2006-04-04 Marek Safar <marek.safar@seznam.cz>
6365 * constant.cs (Constant.IsDefaultInitializer): New method.
6367 * class.cs: Updated.
6369 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
6370 re-initialize default values. It saves KBs almost for every assembly.
6371 Thanks Zoltan for the idea.
6372 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
6373 (ArrayCreation.DoResolve): Resolve only once.
6374 (ArrayCreation.Emit): Emit static initializer only when it is faster.
6375 (ArrayCreation.GetAttributableValue): Cope with optimized values.
6377 2006-04-03 Zoltan Varga <vargaz@gmail.com>
6379 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
6382 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6384 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
6385 in an embedded statement too.
6387 2006-04-01 Raja R Harinath <rharinath@novell.com>
6390 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
6392 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6396 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
6399 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
6401 2006-03-31 Marek Safar <marek.safar@seznam.cz>
6403 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
6406 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
6407 LocalTemporary change.
6409 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
6411 (ClassOrStruct.DefineFieldInitializers): Implemented static field
6412 initializers optimization.
6413 (ClassOrStruct.TypeAttr): Moved from modifiers.
6414 (Constructor.CheckBase): Don't crash when static ctor has parameters.
6415 (FieldBase.ResolveInitializer): Resolves initializer.
6416 (FieldBase.HasDefaultInitializer): New property.
6418 * cs-parser.jay: Removed message.
6420 * expression.cs (CompilerGeneratedThis): New specialization.
6422 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
6424 2006-03-28 Marek Safar <marek.safar@seznam.cz>
6426 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
6428 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6430 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
6431 be now EnumConstants only.
6433 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6435 * attribute.cs, driver.cs: Reset more caches.
6437 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6439 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
6441 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6443 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
6444 for easier reuse. Updated all overrides.
6445 (IntegralConstant): New base class for all integral constants.
6446 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
6447 of the constant range, report custom error.
6448 (UIntConstant.Reduce): Fixed uint conversion.
6450 * ecore.cs, literal.cs: Reduce updates.
6452 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6456 * class.cs (Constructor.Define): Removed extra if for default ctors.
6457 A patch from Atsushi Enomoto.
6459 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6461 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
6462 GetAttributableValue.
6464 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
6467 * convert.cs (ImplicitConversionRequired): Error message moved to
6470 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
6471 automatic implicit conversion of an output value.
6472 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
6474 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
6476 (TypeOf.GetAttributableValue): Add extra handling for object type.
6478 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
6479 special error message.
6481 2006-03-25 Marek Safar <marek.safar@seznam.cz>
6483 * class.cs (Constructor.Emit): Don't crash when struct ctor is
6485 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
6486 compatible with MS runtime.
6488 2006-03-23 Marek Safar <marek.safar@seznam.cz>
6490 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
6491 attribute arguments here.
6493 * class.cs (Indexer.Define): The check was moved to attribute class.
6495 2006-03-22 Marek Safar <marek.safar@seznam.cz>
6497 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
6498 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
6501 2006-03-22 Raja R Harinath <rharinath@novell.com>
6503 Support ParameterDefaultValueAttribute in gmcs. Also applied to
6504 mcs to keep code differences small.
6505 * attribute.cs (Attribute.GetParameterDefaultValue): New.
6506 * typemanager.cs (parameter_default_value_attribute_type): New.
6507 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
6510 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6512 * expression.cs (StringConcat.Append): Reverted back to no warning state.
6514 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6516 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
6518 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
6521 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
6523 * doc-bootstrap.cs : fix build.
6525 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6527 * expression.cs (StringConcat.Append): Issue a warning when empty string
6530 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6532 * assign.cs (CompoundAssign.ResolveSource): Removed.
6534 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
6537 * class.cs (TypeContainer.FindMethods): Removed.
6538 (TypeContainer.CheckMemberUsage): Made static.
6540 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
6542 * constant.cs (CheckRange): Removed unused type argument.
6543 (CheckUnsigned): Removed unused type argument.
6545 * cs-parser.jay: Updated after MemberAccess clean up.
6546 Uses Length for empty string test.
6548 * cs-tokenizer.cs: Uses Length for empty string test.
6549 (IsCastToken): Made static.
6550 (is_hex): Made static.
6551 (real_type_suffix): Made static.
6553 * decl.cs (SetupCache): Made static.
6554 (OnGenerateDocComment): Removed unused ds argument.
6556 * delegate.cs (VerifyDelegate): Removed unused argument.
6558 * doc.cs: Uses Length for empty string test.
6560 * driver.cs: Uses Length for empty string test.
6562 * enum.cs (IsValidEnumType): Made static
6564 * expression.cs (EnumLiftUp): Removed unused argument.
6565 (ResolveMethodGroup): Ditto.
6566 (BetterConversion): Ditto.
6567 (GetVarargsTypes): Ditto.
6568 (UpdateIndices): Ditto.
6569 (ValidateInitializers): Ditto.
6570 (MemberAccess.ctor): Ditto.
6571 (GetIndexersForType): Ditto.
6573 * flowanalysis.cs: (MergeFinally): Removed unused argument.
6575 * iterators.cs: Updated after MemberAccess clean up.
6577 * location.cs: Uses Length for empty string test.
6579 * namespace.cs: Uses Length for empty string test.
6581 * report.cs (CheckWarningCode): Made static.
6583 * statement.cs (LabeledStatement): Removed unused argument.
6585 * typemanager.cs (FilterNone): Removed.
6587 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6589 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
6592 * class.cs: Updated.
6594 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6596 * cs-parser.jay.cs: __arglist is not allowed for delegates.
6598 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6602 * expression.cs (VerifyArgumentsCompat): Reverted to double error
6603 reporting, it's more tricky than I thought.
6605 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6609 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
6611 (AnonymousMethod.ImplicitStandardConversionExists): New method.
6612 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
6613 Add more error reporting; Fixed issue with params.
6615 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
6617 * cs-parser.jay: AnonymousMethod requires host container.
6619 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
6621 2006-03-18 Raja R Harinath <harinath@gmail.com>
6623 * class.cs: Change 'TypeContainer ds' constructor argument to
6624 'DeclSpace parent'. Some classes were missed below due to
6625 different naming convention.
6627 * class.cs (MemberCore.Parent): Delete. This makes the
6628 ParentContainer changes below enforceable by the compiler.
6630 Treat pointers to enclosing declaration space as 'DeclSpace', not
6632 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
6633 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
6635 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
6637 (Block.AddThisVariable): Likewise.
6638 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
6639 (AbstractPropertyEventMethod.Emit): Likewise.
6640 (AbstractPropertyEventMethod.EmitMethod): Likewise.
6641 (GetMethod.Define, SetMethod.Define): Likewise.
6642 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
6643 (DelegateMethod.EmitMethod): Likewise.
6645 Fix regression test-partial-13.cs.
6646 Rationalize use of PartialContainer. Ensure that the partial
6647 class semantics can be tied to type-correctness, i.e., any
6648 violation will cause a compile error.
6649 * class.cs, const.cs: Access all fields that belong to class
6650 TypeContainer via ParentContainer. Arguments of EmitContexts and
6651 Resolve()-like functions still use 'Parent'.
6653 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
6654 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
6655 (PropertyMethod.CheckModifiers): Remove unused argument.
6656 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
6659 2006-03-17 Raja R Harinath <harinath@gmail.com>
6661 Make semantics of PartialContainer simpler.
6662 * decl.cs (DeclSpace.IsPartial): Remove.
6663 * class.cs (TypeContainer.IsPartial): Likewise.
6664 (TypeContainer..ctor): Set PartialContainer to point to self.
6665 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
6666 (TypeContainer.FindNestedType): Likewise.
6667 (MemberCore.ParentContainer): Simplify. Remove deprecation.
6669 2006-03-17 Marek Safar <marek.safar@seznam.cz>
6671 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
6673 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6675 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
6678 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6680 * class.cs (Operator.Define): An error for base conversion was not
6683 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
6685 * iterator.cs : yield break is allowed in try statement which has
6686 catch clauses. Fixed bug #77767.
6688 2006-03-13 Marek Safar <marek.safar@seznam.cz>
6690 A fix for #77593, #77574.
6692 * class.cs (MethodCore.CheckBase): Another if for operator.
6694 2006-03-09 Marek Safar <marek.safar@seznam.cz>
6696 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
6699 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
6700 (DelegateCreation.ImplicitStandardConversionExists): New method for just
6703 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
6706 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
6707 Updated after another emitcontext usage was clean up. It should help us to
6708 synchronize with gmcs easier.
6710 2006-03-04 Marek Safar <marek.safar@seznam.cz>
6714 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
6715 (Event.Define): ditto
6716 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
6718 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
6719 Removed redundant code and set NewSlot for Invoke method too.
6721 * parameter.cs (Parameters.ctor): Add custom, type ctor.
6722 (Parameters.MergeGenerated): New method. Use this method when you merge
6723 compiler generated argument with user arguments.
6725 2006-03-03 Marek Safar <marek.safar@seznam.cz>
6727 * attribute.cs (ResolveAsTypeTerminal): Removed.
6729 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
6730 specialization for predefined types; 30% speed up.
6731 Finally placed obsolete check to right place.
6732 (Expression.ResolveType): Removed.
6734 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
6735 Updated after ResolveType was removed.
6737 * expression.cs (Cast.ctor): Check void cast.
6738 (Binary.ResolveAsTypeTerminal): Is never type.
6739 (Conditional.ResolveAsTypeTerminal): Is never type.
6741 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
6743 2006-03-01 Raja R Harinath <rharinath@novell.com>
6746 * expression.cs (ParameterReference.DoResolveBase): Change return
6748 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
6752 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
6755 * typemanager.cs (GetFullNameSignature): Don't nullref on
6756 protected accessors.
6758 2006-02-27 Marek Safar <marek.safar@seznam.cz>
6760 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
6761 these two separated members to simplify the code.
6762 (Attribute.Resolve): Refactored to use new fields and methods.
6763 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
6764 implemented obsolete attribute checking.
6765 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
6766 implemented obsolete checking again. It look line never ending quest ;-)
6767 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
6769 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
6771 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
6773 *class.cs (Property.Define): Add RegisterProperty call.
6775 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
6776 argument groups (only 2).
6778 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
6779 encoding expression to arguments.
6780 (Expression.ExprClassToResolveFlags): Just turned to property.
6782 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
6783 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
6784 optimized as well as implemented support for zero-length attributes.
6786 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
6787 Add caching of PropertyInfo's.
6789 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6791 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
6792 error multiple times.
6794 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6796 New partial class implementation.
6797 A fix for #77027, #77029, #77403
6799 * attribute.cs (Attributable): Made attributes protected.
6801 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
6802 the replacements of ClassPart and PartialContainer.
6803 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
6804 (TypeContainer.AddInterface): Ditto.
6805 (TypeContainer.AddPartial): The main method for partial classes. It checks
6806 for errors and merges ModFlags and attributes. At the end class is added to
6808 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
6810 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
6811 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
6812 from the rest of partial classes.
6813 (TypeContainer.GetClassBases): Simplified.
6814 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
6816 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
6817 (TypeContainer.HasExplicitLayout): Uses Flags now.
6818 (PartialContainer): Removed.
6819 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
6820 (StaticClass): Was merged with Class.
6821 (Class.GetClassBases): class and static class bases are verified here.
6822 (Class.TypeAttr): Added static attributes when class is static.
6823 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
6824 (MemberBase): In some cases we need to call parent container for partial
6825 class. It should be eliminated but it's not easy now.
6827 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
6829 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
6830 partial classed to accumulate class comments.
6831 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
6833 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
6835 * driver.cs (MainDriver): Tree.GetDecl was removed.
6837 * modifiers.cs (Modifiers): Add partial modifier.
6839 * tree.cs (Tree.decl): Removed.
6840 (RootTypes): Started to use this class more often for root types
6843 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6847 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
6848 external interface does not have an attribute.
6850 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6852 Another prerequisites for new partial classs implementation.
6854 * attribute.cs (Attribute.Equal): Implemented.
6855 (Attribute.Emit): Changed as attributes can be applied more than twice.
6856 (Attributes.Emit): Check for duplicate attributes here.
6858 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
6859 as a parameter, clean-up.
6861 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6865 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
6866 contains obsolete attribute check which can in some cases look for base
6867 type of current class which is not initialized yet.
6868 (TypeContainer.BaseType): Replacement of ptype.
6870 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
6872 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6874 First of prerequisites for new partial classs implemention.
6876 * attribute.cs (Attributable): Extended by ResolveContext;
6877 Attributes finally have correct context for resolving in all cases.
6878 (AttachTo): Attribute owner is assigned here.
6880 * codegen.cs (IResolveContext): Introduce new interface to hold
6881 all information needed in resolving phase.
6882 (EmitContext): Implements IResolveContext; more clean-up needed here.
6884 * decl.cs (MemberCore): Implemented IResolveContext.
6886 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
6887 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
6888 parameter.cs, statement.cs, tree.cs, typemanager.cs:
6889 Refactored to use new IResolveContext instead of EmitContext; cleanup
6891 2006-02-06 Miguel de Icaza <miguel@novell.com>
6893 * codegen.cs (EmitScopeInitFromBlock): check here the
6894 capture_context, there is no need to make two calls to the
6897 * anonymous.cs: Add some debugging messages that might help me
6898 track other instances of this problem in the future (the
6899 regression of test 467).
6901 * cs-parser.jay: track the variable block, as we need to initalize
6902 any captured variables declared in this block for the "catch"
6903 portion of the "Try" statement.
6905 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
6906 scope initialization for captured variables.
6908 Also, move the emit for the variables after the block location has
6911 2006-02-06 Marek Safar <marek.safar@seznam.cz>
6913 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
6915 2006-02-02 Miguel de Icaza <miguel@novell.com>
6917 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
6918 commit yesterday, the initialization for the roots is necessary.
6919 What is not necessary is the scope activation.
6921 2006-02-02 Raja R Harinath <rharinath@novell.com>
6923 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
6924 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
6926 (Argument.Resolve): Remove CS0206 checks.
6928 2006-02-01 Miguel de Icaza <miguel@novell.com>
6930 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
6931 scopes for all the roots, the scopes will now be emitted when the
6932 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
6934 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
6935 code. This reduces a lot of existing cruft.
6937 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
6938 that the ScopeInfo is generated as we enter the scope, not at the
6939 time of use, which is what we used to do before.
6941 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
6942 every time a Block is about to be emitted if we have a
6945 2006-02-01 Raja R Harinath <rharinath@novell.com>
6947 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
6949 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
6951 * typemanager.cs (cons_param_array_attribute): Make private.
6952 (Reset): Set it to null.
6953 (InitCoreHelpers): Don't initialize it.
6954 (ConsParamArrayAttribute): New. Initialize it as needed.
6955 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
6957 2006-01-31 Miguel de Icaza <miguel@novell.com>
6959 * expression.cs: There might be errors reported during the
6960 selection of applicable methods. If there are errors, do not
6961 continue execution as it will lead the compiler to crash.
6963 2006-01-30 Miguel de Icaza <miguel@novell.com>
6965 * expression.cs: Member access is not allowed on anonymous
6966 methods. Fixes #77402.
6968 2006-01-30 Raja R Harinath <rharinath@novell.com>
6971 * cs-parser.jay (VariableDeclaration): Don't set
6972 current_array_type to null.
6973 (field_declaration, event_declaration, declaration_statement):
6974 Set it to null here.
6976 2006-01-28 Raja R Harinath <harinath@gmail.com>
6978 * typemanager.cs (GenericParameterPosition): New.
6981 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
6983 * doc.cs : To process "include" elements, first we should create
6984 another list than XmlNodeList, because it could result in node
6985 removal, which could result in that the XmlNodeList gives up
6988 (Also made code identical to gmcs again.)
6990 2006-01-25 Miguel de Icaza <miguel@novell.com>
6992 * ecore.cs: Introduce an error report that we were not catching
6993 before, if not silent, we must report the error. Gonzalo ran into
6996 2006-01-23 Miguel de Icaza <miguel@novell.com>
6998 A fix for bug: #76957
7000 * iterators.cs (MoveNextMethod.CreateMethodHost): call
7001 ComputeMethodHost before creating the method, this is a new
7004 * anonymous.cs (AnonymousContainer): Now we track all the scopes
7005 that this method references (RegisterScope). The actual scope
7006 where the method is hosted is computed with the ComputeMethodHost
7007 before we create the method.
7009 Moved the Deepest routine here.
7011 (AnonymousContainer.ComputeMethodHost): New routine used to
7012 compute the proper ScopeInfo that will host the anonymous method.
7014 (ScopeInfo): Deal with multiple roots. The problem was that we
7015 did not have a unique root where all ScopeInfos could be hanged
7016 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
7019 Remove AdjustMethodScope which is now computed at the end. Remove
7020 LinkScope which did a partial link, instead link all ScopeInfos
7021 before code generation from the new "LinkScopes" routine.
7023 Simplify all the Add* routines as they no longer need to maintain
7024 the tree, they just need to record that they are using variables
7027 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
7028 routines to produce the forest of ScopeInfo trees.
7030 * class.cs (TypeContainer.AppendMethod): This is just like
7031 AddMethod, but ensures that an interface implementation method
7032 (IEnumerable.XXX) is not inserted at the beginning of the queue of
7033 methods, but at the end.
7035 We use this functionality to ensure that the generated MoveNext
7036 method in the iterator class is resolved/emitted before the
7037 enumerator methods created.
7039 This is required because the MoveNext method computes the right
7040 ScopeInfo for the method. And the other methods will eventually
7041 need to resolve and fetch information computed from the anonymous
7044 2006-01-21 Raja R Harinath <harinath@gmail.com>
7045 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7048 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
7050 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
7051 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
7053 2006-01-18 Raja R Harinath <rharinath@novell.com>
7055 Fix #76656, cs0231-2.cs.
7056 * cs-parser.jay (formal_parameter_list): Make error case catch
7058 (parenthesized_expression_0): Add CS1026 check.
7059 (invocation_expression): Remove unused { $$ = lexer.Location }.
7061 2006-01-17 Raja R Harinath <rharinath@novell.com>
7064 * cs-parser.jay (statement_expression): Don't list out the
7065 individual statement-expressions. Convert syntax error into
7068 2006-01-16 Raja R Harinath <rharinath@novell.com>
7071 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
7072 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
7073 CheckIntermediateModification.
7074 (FieldExpr.DoResolve): Add new two-argument version that
7075 allows us to resolve the InstanceExpression as an lvalue.
7076 The one-argument variant is now just a wrapper.
7077 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
7078 Resolve the lhs as an lvalue if the it has a value type.
7079 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
7080 from Assign.DoResolve.
7081 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
7082 resolved as an lvalue.
7083 (PropertyExpr.DoResolve): Update.
7084 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
7085 has a value type. Move CS1612 check here from
7086 CheckIntermediateModification.
7087 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
7088 * expression.cs (EmptyExpression.OutAccess): New. Used as the
7089 'right_side' of a ResolveLValue on an 'out' argument.
7090 (EmptyExpression.LValueMemberAccess): New. Used as the
7091 'right_side' of a propagated ResolveLValue on a value type.
7092 (LocalVariableReference.DoResolveBase): Recognize
7093 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
7095 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
7096 EmptyExpression.Null.
7098 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
7100 * typemanager.cs : added IsGenericParameter(). In mcs it always
7102 * doc.cs : for generic parameters, use GenericParameterPosition,
7105 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
7107 * expression.cs: Fix Console.WriteLine ((this = x).foo);
7109 2006-01-12 Miguel de Icaza <miguel@novell.com>
7111 This fixes the problem where we used ldfld instead of ldflda to
7112 load the "THIS" pointer on captured parameters, when THIS is a
7113 value type. See bug #77205.
7115 * iterators.cs (CapturedThisReference.Emit): Pass false to
7116 EmitThis (we do not need the address).
7118 * codegen.cs (EmitThis): it needs to know whether we need the
7119 address of `this' or not. This is used by value types.
7121 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
7122 every other call passes false.
7124 2006-01-12 Raja R Harinath <rharinath@novell.com>
7127 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
7129 * expression.cs (Invocation.OverloadResolve): Update.
7130 (Invocation.DoResolve): Avoid double resolution of invocation.
7132 2006-01-11 Raja R Harinath <rharinath@novell.com>
7135 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
7136 unary negation of floating point types as 0-expr; negation cannot
7137 overflow in floating point types.
7140 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
7141 on operands of 'void' type.
7144 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
7145 and ExclusiveOr for boolean constants too.
7147 2006-01-09 Raja R Harinath <rharinath@novell.com>
7150 * expression.cs (Invocation.OverloadResolve): Replace reflected
7151 override methods with their base virtual methods, rather than
7153 * typemanager.cs (TypeManager.GetOverride): New.
7155 2006-01-05 Jb Evain <jbevain@gmail.com>
7157 * class.cs (Property.Define, Indexer.Define): do not tag the
7158 properties as SpecialName | RTSpecialName.
7160 2006-01-04 Miguel de Icaza <miguel@novell.com>
7162 * class.cs (MethodCore.IsDuplicateImplementation): This method was
7163 doing a low-level comparission of parameter types. It was lacking
7164 a check for __argslist.
7166 2005-12-30 Miguel de Icaza <miguel@novell.com>
7168 * expression.cs (ParameterReference.DoResolveBase): Allow
7169 reference parameters if they are local to this block.
7171 This allows the ref and out parameters of a delegate to be used in
7172 an anonymous method, for example:
7174 delegate void set (out int x);
7176 set s = delegate (out int x){
7180 This is used by functionality introduced late in the C# language.
7182 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
7183 method that take ref and out parameters.
7185 Fixes #77119 which was a late change in the spec.
7187 2005-12-23 Miguel de Icaza <miguel@novell.com>
7189 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
7190 parent if its the same scope. Fixes #77060.
7192 2005-12-21 Miguel de Icaza <miguel@novell.com>
7194 * driver.cs: Report the case of no source files and no -out:
7197 2005-12-20 Raja R Harinath <rharinath@novell.com>
7200 * expression.cs (ComposedCast.GetSignatureForError): Define.
7202 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7206 * namespace.cs (NamespaceEntry): Add extern_aliases as a
7207 ListDictionary, to contain the ExternAliasEntry entries (in
7208 addition to the NamespaceEntry.aliases hashtable). This field is
7209 shared between the original entry and its doppelganger (bodyless
7211 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
7212 extern_aliases field.
7213 (NamespaceEntry.Lookup): Move the IsImplicit check after the
7214 lookup in extern_aliases.
7216 2005-12-16 Raja R Harinath <rharinath@novell.com>
7219 * class.cs (TypeContainer.Mark_HasEquals): New.
7220 (TypeContainer.Mark_HasGetHashCode): New.
7221 (ClassPart): Override them.
7222 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
7225 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
7226 'parent' argument to the base constructor.
7228 Remove all mention of TypeContainer from decl.cs.
7229 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
7230 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
7231 (DeclSpace.DeclSpace): Likewise.
7232 (DeclSpace.DefineMembers): Remove unused argument.
7233 * cs-parser.jay (pop_current_class): Update to changes. Simplify
7234 debugging check -- we don't care if the debug code throws an
7235 InvalidCastException instead of an InternalErrorException.
7236 * class.cs (TypeContainer.DefineMembers): Update to changes.
7237 (TypeContainer.DoDefineMembers): Likewise.
7238 (TypeContainer.GetMethods): Likewise.
7239 (PropertyMember.Define): Likewise.
7240 (MemberBase.Parent): New property that forwards to
7241 MemberCore.Parent, but ensures that we get a TypeContainer.
7242 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
7243 (RootContext.PopulateTypes): Likewise. Remove special case code
7244 for !RootContext.StdLib: DefineMembers is idempotent.
7246 2005-12-14 Miguel de Icaza <miguel@novell.com>
7248 * convert.cs (ExplicitConversionCore): Check the return value from
7249 ExplicitConversionCore which can return null on failure. Fixes #76914
7251 2005-12-13 Marek Safar <marek.safar@seznam.cz>
7253 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
7255 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
7257 * doc.cs : The search for referenced namespace was insufficient to
7258 get global one as it used to do. Fixed bug #76965.
7260 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
7262 * doc.cs : check name in cref in the last phase that whether it is
7265 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7267 * cs-tokenizer.cs : reverted the latest change: it somehow broke
7270 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7272 * doc.cs : so it turned out that we cannot skip override check for
7273 interface members. Fixed bug #76954.
7275 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7277 * cs-tokenizer.cs : fixed bug #75984:
7278 - #warning and #error should not be handled when the source line
7280 - #line is not checked strictly when the source line is disabled.
7281 - #define and #undef is on the other hand checked strictly at any
7284 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
7286 * cs-tokenizer.cs : missing Location (actually, filename) in one of
7289 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7291 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
7293 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
7295 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
7296 (FieldBase.Initializer): Initializer is now optional.
7297 (EventField.Define): Only event field can have initializer.
7299 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
7301 * const.cs (Const): Reuse initializer.
7303 * cs-parser.jay: Updated after FieldBase changes.
7304 Added current_array_type to simplify array initializers.
7306 * ecore.cs (NullCast.IsDefaultValue): Implemented.
7308 * expression.cs, iterators.cs: Updated.
7310 * namespace.cs (NamespaceEntry): Made UsingFound private.
7312 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7314 * parameterCollection.cs: Obsolete, removed.
7315 * parser.cs: Obsolete, removed.
7317 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7320 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
7322 * enum.cs (Enum.Define): Set obsolete context here.
7324 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7327 - FindDocumentedMember() now expects 1) paramList as null
7328 when "we don't have to check the number of parameters" and
7329 2) Type.EmptyTypes when "there is no arguments".
7330 - Introduced FoundMember struct to hold the exact type which was
7331 used to find the documented member (the above change broke
7332 test-xml-044; it might be better just to use DeclaringType than
7333 what MS does, like this change does, but it depends on usage.)
7335 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7337 * doc.cs : documented member might be from DeclaringType for nested
7338 types. Fixed bug #76782.
7340 2005-12-03 Ben Maurer <bmaurer@ximian.com>
7342 * anonymous.cs: Have the param code handle leaving copies on the
7343 stack etc. Allows anonymous params to take part in the assignment
7344 code (++, +=, etc). Fixes bug #76550
7346 * expression.cs: Handle the prepare_for_load/leave_copy by passing
7347 it down to the anon code.
7349 * iterators.cs: Use dummy var here
7351 * codegen.cs: Handle new vars
7353 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7356 * class.cs (MethodData.Define): Set proper Obsolete context.
7358 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
7360 (FieldExpr.DoResolve): Ditto.
7362 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7365 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
7366 parent is not obsolete.
7368 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
7370 * doc.cs : (FindDocumentedMember) find parameterless members first
7371 and get CS0419 in the early stage. Fixed first case of bug #76727.
7373 2005-11-30 Marek Safar <marek.safar@seznam.cz>
7376 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
7377 no error was reported.
7379 *expression.cs (Binary.DoResolve): left can be null.
7381 2005-11-22 Marek Safar <marek.safar@seznam.cz>
7384 * class.cs (MethodData.Emit): Parameters should be labeled first.
7386 2005-11-21 Marek Safar <marek.safar@seznam.cz>
7389 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
7391 2005-11-18 Marek Safar <marek.safar@seznam.cz>
7393 * attribute.cs (AreParametersCompliant): Moved to Parameter.
7395 * class.cs (MethodCore): Parameter clean up.
7396 (IMethodData): Added ParameterInfo.
7397 (MethodData): Parameter clean up.
7398 (Indexer.Define): Parameter clean up.
7410 * typemanager.cs: Parameter clean up.
7412 * delegate.cs (Define): Get rid of duplicated code.
7414 * expression.cs (ParameterReference): Removed useless parameters
7416 (Invocation): Ditto.
7418 * parameter.cs (ParamsParameter): New class, params specialization.
7419 (ArglistParameter): Attemp to separate arglist.
7420 (Parameter): Refactored to be reusable and faster.
7421 (Parameter.Modifier): Made understandable.
7422 (Parameters): Changed to be used as a class for `this' assembly
7423 parameters. Refactored to use new specialized classes.
7425 * support.cs (ParameterData): Added Types property.
7426 (InternalParameters): Deleted.
7428 2005-08-20 Martin Baulig <martin@ximian.com>
7430 Merging this patch from GMCS to fix #75867.
7432 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7433 scope if we don't already have it.
7435 2005-11-17 Martin Baulig <martin@ximian.com>
7438 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
7439 inherit the scope from our parent. Fixes #76653.
7441 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7443 * doc.cs : the previous patch does not actually fix the bug.
7444 PropertyInfo override check is now implemented and really fixed it.
7445 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
7447 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7449 * doc.cs : apply "override filter" also to properties.
7452 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7454 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
7455 no need to check overrides. For classes, omit those results from
7456 interfaces since they must exist in the class. Fixed bug #76726.
7458 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7460 * typemanager.cs : (GetFullNameSignature) differentiate indexers
7461 with different parameters. Fixed the second problem in #76685.
7463 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7465 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
7466 get expected 'protected' access in CheckValidFamilyAccess()).
7469 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7471 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
7472 Fixed bug #76705. CS1569 was incorrectly commented out.
7474 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7476 * doc.cs : use Invocation.IsOverride() to do real override check.
7477 * expression.cs : made Invocation.IsOverride() internal.
7479 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7481 * doc.cs : use TypeManager.FindMembers() instead of (possible)
7482 TypeBuilder.FindMembers() and filter overriden base members out.
7485 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7487 * doc.cs : ref/out parameters are represented as '@' (instead of
7488 '&' in type FullName). Fixed bug #76630 (additionally crefs).
7490 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7492 * doc.cs : when there was no '.' in cref to methods in doc comment,
7493 then parameters were missing in the output. Fixed bug #76691.
7495 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7497 * driver.cs : don't output docs when there is an error.
7500 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7503 Now it should detect indexers. Fixed primary concern in bug #76685.
7504 Fixed CS0419 message to not show the identical member signature in
7507 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7509 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
7510 instead of Type.FindMembers() since it does not handle events.
7513 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
7515 * codegen.cs: Fixed typo (speficied -> specified).
7517 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7520 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
7522 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7524 * attribute.cs: Changed error message.
7526 * cs-tokenizer.cs: One more check.
7528 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7530 * statement.cs (Block.Resolve): Ignore empty statement.
7532 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7534 * report.cs: Made error/warning methods more strict to avoid
7537 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
7538 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
7539 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
7540 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
7542 2005-11-08 Marek Safar <marek.safar@seznam.cz>
7544 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
7545 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
7547 * class.cs (TypeContainer.IsComImport): New property.
7548 (Constructor.Define): Create proper ctor for ComImport types.
7550 * expression.cs (New.CheckComImport): Fixed.
7552 2005-11-07 Miguel de Icaza <miguel@novell.com>
7554 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
7555 that a parameter has been captured does not mean that we do not
7556 have to do the rest of the processing. This fixes the second part
7557 of #76592. If there was another anonymous method capturing
7558 values in the past, the Scope would never be set for the second
7559 method that captured the same parameter.
7561 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
7562 properly manipulate the stack. Second part of fix for #76592.
7564 * expression.cs (New): Add support for invoking "new" on
7565 interfaces that have been flagged with the ComImport attribute and
7566 the CoClass. Fixes #76637
7568 * statement.cs (Try.DoEmit): When a variable is captured, do not
7569 try to emit the vi.LocalBuilder variable as it has been captured.
7570 Create a temporary variable and store the results on the
7571 FieldBuilder. Fixes #76642
7573 2005-11-07 Marek Safar <marek.safar@seznam.cz>
7575 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
7577 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
7579 * expression.cs (Binary.DoResolve): Added && optimalization.
7581 * typemanager.cs (AddUserType): Removed useless argument.
7583 2005-11-04 Marek Safar <marek.safar@seznam.cz>
7585 * statement.cs (Block.variables): Uses ListDictionary.
7587 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7590 * class.cs (PartialContainer.EmitType): Customized to emit
7591 security attributes.
7592 (ClassPart.ApplyAttributeBuilder): Transform security attribute
7593 for partial classes.
7595 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7598 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
7599 access has to be fixed.
7601 * typemanager.cs (IsUnmanagedType): Wrong common field type.
7603 2005-11-01 Marek Safar <marek.safar@seznam.cz>
7606 * ecore.cs (NullCast.Reduce): Implemented.
7608 * expression.cs (ArrayCreation.CheckIndices): Correcly check
7611 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
7613 (Foreach.Resolve): Catch null properly.
7615 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7617 * cs-tokenizer.cs: Warning text fix.
7619 * driver.cs: AllWarningNumbers exposed on public interface.
7621 * report.cs (): Reviewed warning numbers.
7622 (IsValidWarning): Use binary search.
7624 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7626 * driver.cs: Implemeted resource visibility.
7627 (Resources): New class for code sharing between /res: and
7630 2005-10-28 Marek Safar <marek.safar@seznam.cz>
7633 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
7636 * convert (Convert.ImplicitReferenceConversion): NullCast holds
7639 * ecore.cs (NullCast): Child is contant only.
7641 * literal.cs (NullLiteral.Reduce): null can be converted to any
7644 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
7646 * driver.cs: Use Encoding.Default as default code page instead
7649 2005-10-27 Raja R Harinath <rharinath@novell.com>
7652 * expression.cs (Invocation.Error_InvalidArguments): Handle
7653 __arglist parameters.
7654 (Invocation.VerifyArgumentsCompat): Likewise.
7655 * support.cs (ReflectionParameters.GetSignatureForError): Print
7656 __arglist parameters.
7657 (InternalParamters.GetSignatureForError): Likewise.
7658 * parameter.cs (Parameters.GetSignatureForError): Likewise.
7660 2005-10-26 Marek Safar <marek.safar@seznam.cz>
7662 * attribute.cs (GetPropertyValue): Made public.
7664 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
7666 Add new property WrapNonExceptionThrows to handle 2.0 assembly
7668 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
7671 * driver.cs: Reflect method name change.
7673 * statement.cs (Try.Resolve): Warn when try has both general
7676 * typemanager.cs: runtime_compatibility_attr_type new predefined
7679 2005-10-26 Raja R Harinath <harinath@gmail.com>
7682 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
7683 treat it as an empty parameter list.
7685 2005-10-26 Raja R Harinath <rharinath@novell.com>
7688 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
7689 ResolveAsTypeStep silent.
7690 * statement.cs (Block.AddConstant): Mark block as used.
7691 (Block.ResolveMeta): Avoid piling on error messages
7692 if a constant initializer resolution fails.
7694 2005-10-25 Raja R Harinath <rharinath@novell.com>
7696 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
7698 (NamespaceEntry.VerifyAllUsing): New.
7699 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
7700 behaviour. Delegates actual resolution of alias to ...
7701 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
7702 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
7704 * driver.cs (Driver.MainDriver): Update.
7706 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
7707 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
7709 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
7711 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
7712 RootNamespace.DefineNamespacesForAll.
7714 2005-10-24 Raja R Harinath <harinath@gmail.com>
7716 * typemanager.cs (assemblies, external_aliases, modules)
7717 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
7718 (ComputeNamespaces, GetRootNamespace): Remove extra staging
7719 overhead. Move resposibility ...
7720 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
7721 * driver.cs, attribute.cs, codegen.cs: Update to changes.
7723 2005-10-23 Raja R Harinath <harinath@gmail.com>
7725 * namespace.cs (RootNamespace.all_namespaces): Renamed from
7726 cached_namespaces. Improve usage.
7727 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
7728 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
7729 Move from GlobalRootNamespace and simplify.
7730 (RootNamespace.Global): Make instance variable.
7731 (RootNamespace.RootNamespace): Add "alias name" parameter.
7732 (GlobalRootNamespace): Simplify drastically.
7733 (Namespace.Lookup): Don't use GetNamespace.
7734 * typemanager.cs (GetRootNamespace): Rename from
7735 ComputeNamespaceForAlias.
7736 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
7738 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7740 * anonymous.cs (AnonymousContainer): Don't crash when container
7743 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7745 * expression.cs (Binary.DoResolve): Warn when comparing same
7748 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7751 * expression.cs (Binary.DoResolve): It looks like there are no
7752 convetsion rules in enum context.
7754 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7756 Add support for extern alias qualifiers.
7757 * typemanager.cs: Move some LookupTypeReflection code
7758 to namespace.cs, to have cleaner code. Added some methods
7759 to help us keep track of the extern aliased references.
7760 * driver.cs: Add suport for extern alias assemblies on command
7761 line and check for their warnings/errors. Also keep track of the
7762 extern aliased assemblies.
7763 * namespace.cs: Move the global functionality of Namespace
7764 to GlobalRootNamespace/RootNamespace. Now the global namespace
7765 is GlobalRootNamespace.Globa. Also the code moved from
7766 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
7767 Finally added LocalAliasEntry (AliasEntry before) and
7768 ExternAliasEntry, to handle alias statements.
7769 * cs-parser.jay: Add support in the grammar for extern alias
7771 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
7772 Update callings to Namespace (now in GlobalRootNamespace).
7774 2005-10-18 Raja R Harinath <rharinath@novell.com>
7777 * class.cs (TypeContainer.DefineType): Move updating of
7778 topological sort earlier in the code.
7779 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
7781 2005-10-18 Marek Safar <marek.safar@seznam.cz>
7784 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
7786 * constant.cs (Constant.TryReduce): Moved from Cast class.
7787 (Reduce): Made little bit more OO and fixed missing conversions.
7789 * ecore.cs (Reduce): Implemented.
7790 (Binary.EnumLiftUp): New method to upgrade values to enum values.
7792 * literal.cs (Reduce): Implemented.
7794 * class.cs: Reverted Miguel's wrong commit.
7796 2005-10-14 Miguel de Icaza <miguel@novell.com>
7798 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
7800 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
7802 * cs-parser.jay, expression.cs : CS0214 was missing error location
7803 for constants. Fixed bug #76404.
7805 2005-10-11 Marek Safar <marek.safar@seznam.cz>
7808 * convert.cs (ExplicitConversionCore): Fixed object->enum
7811 2005-10-10 Raja R Harinath <rharinath@novell.com>
7813 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
7815 (PropertyExpr.EmitCall): Likewise.
7816 * expression.cs (Invocation.EmitArguments): Handle case where
7818 (Invocation.EmitCall): Avoid allocating temporary variable if
7819 there are no arguments.
7821 2005-10-07 Raja R Harinath <rharinath@novell.com>
7824 * convert.cs (ImplicitConversionStandard): Move conversion of
7825 void* to arbitrary pointer types ...
7826 (ExplicitConversionStandard): .. here.
7827 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
7828 error to always print typenames.
7830 2005-10-07 Raja R Harinath <rharinath@novell.com>
7832 * convert.cs (GetConversionOperator): Rename from
7833 GetConversionOperators. Move operator selection code from ...
7834 (UserDefinedConversion): ... here.
7836 2005-10-06 Marek Safar <marek.safar@seznam.cz>
7838 * convert.cs (ExplicitConversionCore): Removed duplicate enum
7841 2005-10-05 Marek Safar <marek.safar@seznam.cz>
7843 * assign.cs (Assign.DoResolve): Error method changed.
7845 * cfold.cs (DoConstantNumericPromotions): Error method changed.
7847 * const.cs (ResolveValue): Reset in_transit immediately.
7849 * constant.cs: Error method changed.
7851 * convert.cs: Removed useless location parameter.
7852 (ExplicitNumericConversion): Don't do double enum check.
7853 (ExplicitConversionCore): Renamed from ExplicitConversion.
7854 (ExplicitUnsafe): Extracted from ExplicitConversion.
7855 (ExplicitConversion): Uses for error reporting.
7857 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
7859 (ResolveBoolean): Uses common error method.
7860 (CastToDecimal): Get rid of ec.
7861 (CastFromDecimal): Optimized.
7862 (ConvCast): Get rid of ec.
7864 * enum.cs (ResolveValue): Reset in_transit immediately.
7865 (Emit): Return after first error.
7867 * expression.cs: Convert changes.
7869 * literal.cs: Error method changed.
7871 * statement.cs: Error method changed.
7873 2005-10-03 Raja R Harinath <rharinath@novell.com>
7875 * support.cs (SeekableStreamReader.Position): Don't error out when
7876 the requested position is just beyond the end of the current
7879 2005-09-28 Raja R Harinath <rharinath@novell.com>
7881 * support.cs (SeekableStreamReader): Simplify drastically. Don't
7882 try to keep in sync with the byte count of the underlying Stream.
7883 However, this limits us to a window size of 2048 characters: i.e.,
7884 the maximum lookahead of our lexer/parser can be 2048 characters.
7886 2005-09-28 Marek Safar <marek.safar@seznam.cz>
7889 * driver.cs: Fix compilation files with full root path.
7891 2005-09-25 Miguel de Icaza <miguel@novell.com>
7893 * report.cs (SymbolRelatedToPreviousError): Format the output so
7894 it does not use an open parenthesis that is never closed.
7896 * driver.cs: Follow coding guidelines
7898 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7901 * const.cs (Const.ResolveValue): Check for assigning non-null
7902 value to reference type.
7904 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7906 * anonymous.cs: Implemented ExprClassName.
7908 * assign.cs (Assign.DoResolve): Don't chrash when type is not
7911 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
7914 * class.cs (StaticClass.DefineContainerMembers): Report protected
7917 * codegen.cs: if(ed) PRODUCTION.
7919 * convert.cs (Error_CannotImplicitConversion): Better error
7922 * cs-parser.jay: More error checks.
7924 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
7926 * driver.cs (CSCParseOption): Enabled wrong option check.
7928 * ecore.cs (Expression.ExprClassName): Turned to property.
7929 (MemberExpr.CheckIntermediateModification): For checking boxed
7930 value types modification.
7932 * statement.cs (Fixed.Resolve): Expression type must be
7933 convertible to fixed type.
7934 (CollectionForeach.GetEnumeratorFilter,TryType):
7935 Small refactoring for easier error checking.
7937 2005-09-26 Marek Safar <marek.safar@seznam.cz>
7939 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
7942 * class.cs (GeneratedBaseInitializer): New class for customization
7943 compiler generated initializers.
7944 (MemberBase.DoDefine): Check Obsolete attribute here.
7945 (FieldMember.DoDefine): Ditto.
7947 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
7950 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
7951 (MemberCore.GetObsoleteAttribute): Removed argument.
7952 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
7953 (MemberCore.CheckObsoleteType): New helper.
7957 * statement.cs: Updates after MemberCore changes.
7959 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
7960 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
7962 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
7963 obsolete attribute for compiler construct.
7964 (As.DoResolve): Cache result.
7966 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
7968 2005-09-26 Raja R Harinath <rharinath@novell.com>
7971 * expression.cs (This.VerifyFixed): In a value type T, the type of
7972 'this' is T&, iow, 'this' is either an out or ref parameter. In a
7973 value type R, 'this' is treated as a value parameter.
7975 2005-09-22 Miguel de Icaza <miguel@novell.com>
7977 * statement.cs (Lock): Use the TemporaryVariable class instead of
7978 manually using local variables as those do not work when variables
7981 * ecore.cs: Moved the TemporaryVariable class from being a nested
7982 class inside Foreach to be a public class that can be employed in
7985 2005-09-19 Marek Safar <marek.safar@seznam.cz>
7987 * cs-parser.jay: interface_accessors replaced by
7988 accessor_declarations.
7990 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
7993 * statement.cs (GotoCase.Resolve): Convert null constant to
7995 (SwitchLabel.ResolveAndReduce): Ditto.
7996 (SwitchLabel.NullStringCase): Custom null stamp.
7997 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
7999 typemanager.cs (CSharpSignature): Don't skip first argument
8002 2005-09-18 Miguel de Icaza <miguel@novell.com>
8004 * driver.cs: Set InEmacs based on the environment variable EMACS.
8006 * location.cs (InEmacs): in this mode, do not report column
8007 location as it confuses Emacs.
8009 2005-09-16 Marek Safar <marek.safar@seznam.cz>
8011 * cfold.cs, constant.cs, convert.cs, ecore.cs,
8012 expression.cs, iterators.cs, literal.cs: Store constants and
8015 * class.cs (MemberBase.ShortName): Pass location.
8017 * cs-parser.jay: Some location fixes.
8019 * ecore.cs (Expression.Location): Made virtual.
8021 2005-09-05 Miguel de Icaza <miguel@novell.com>
8023 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
8024 if the underlying types are the same, otherwise we need to produce
8025 code that will do the proper cast.
8027 This was exposed by Marek's constant rewrite which produced
8028 invalid code for the call site:
8031 void Method (X v) {}
8035 This fixes test-49.cs
8037 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
8039 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
8040 Type/Object should be allowed as well. Fixed bug #75968.
8042 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
8044 * expression.cs : (Binary.DoResolve): when one is enum constant and
8045 another is constant 0, then return enum one *as enum type*.
8048 2005-09-02 Raja R Harinath <rharinath@novell.com>
8050 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
8054 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
8055 flow-branching for LocalVariableReferences in case we were invoked
8056 from a MemberAccess.
8057 * expression.cs (LocalVariableReference.VerifyAssigned): New.
8059 (LocalVariableReference.DoResolveBase): ... this.
8060 (MemberAccess.Resolve): Do the check that was disabled during
8063 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8066 (PartialContainer.Create): check abstract/sealed/static strictly
8067 but abstract/sealed can exist only at one side. Fixed bug #75883.
8069 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
8072 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
8073 specified, don't default to UnmanagedType.I4.
8075 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8077 * expression.cs : conditional operator should check possibly
8078 incorrect assign expression. Fixed bug #75946.
8080 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8082 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
8083 Reverting the change. gmcs is much complex than mcs on this matter.
8085 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8087 * cs-tokenizer.cs : To read another token ahead of the actual
8088 consumption, use new SavedToken and cache token instead of moving
8089 back the stream with SeekableStreamReader (it seemed problematic).
8091 driver.cs : Thus use StreamReader directly.
8092 * support.cs : Thus removed SeekableStreamReader.
8094 2005-08-30 Raja R Harinath <rharinath@novell.com>
8097 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
8098 (ScopeInfo.EmitScopeType): Use it to construct field names from
8099 names of captured locals.
8102 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
8103 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
8104 Pass 'target_type' to BoxedCast. Don't default to 'object'.
8105 (ExplicitConversion): Remove enum cases already handled by
8106 implicit conversion. Move implicit conversion check to the beginning.
8107 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
8108 * expression.cs (ArrayCreation.EmitDynamicInitializers):
8109 Don't treat System.Enum as a struct.
8111 2005-08-30 Jb Evain <jbevain@gmail.com>
8113 * attribute.cs: handles as expression in parameters.
8115 2005-08-30 Raja R Harinath <rharinath@novell.com>
8118 * class.cs (TypeContainer.VerifyClsName): Don't use a
8119 PartialContainer when verifying CLS compliance.
8120 (AbstractPropertyEventMethod): Set Parent here, ...
8121 (PropertyMethod): ... not here.
8123 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
8125 * attribute.cs : escaped attribute name should not be allowed to be
8126 resolved (e.g. @class as classAttribute). Fixed bug #75930.
8128 2005-08-29 Raja R Harinath <rharinath@novell.com>
8131 * convert.cs (ImplicitStandardConversionExists): Allow zero also
8132 when converting a long constant to unsigned long.
8133 * expression.cs (Invocation.OverloadResolve): Add sanity check to
8134 detect where IsApplicable and VerifyArgumentsCompat disagree.
8136 2005-08-29 Raja R Harinath <rharinath@novell.com>
8137 and Carlos Alberto Cortez <carlos@unixmexico.org>
8140 * class.cs (TypeContainer.CanElideInitializer): New helper.
8141 (TypeContainer.EmitFieldInitializers): Use it to determine if we
8142 can safely emitting the initializer of a field.
8144 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8146 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
8147 allowed inside a switch (without loop). Fixed bug #75433.
8149 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
8151 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
8152 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
8154 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8156 * driver.cs : kinda reverting the default encoding changes (not exact
8157 revert since I noticed that "codepage:reset" might not work fine).
8159 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8161 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
8162 Location. Now getter and setter store location correctly.
8163 (errors/cs0111-12.cs now reports the expected location.)
8165 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8167 * driver.cs : Use default encoding on the environment.
8168 Removed (now that) extra parameter for SeekableStreamReader.
8169 * support.cs : (SeekableStreamReader) third .ctor() argument for
8170 StreamReader is not required (always true). preamble size could
8171 be acquired in simpler and safe way.
8173 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
8175 * cs-parser.jay: report CS0642 at warning level 3
8176 and report CS0642 for an if else statement also
8177 fixes bug #74745. Patch by John Luke (and a bit
8179 Removed extra CS0642 warning check for "while",
8181 * statement.cs: In Block.Resolve(), CS0642 check
8182 is reimplemented to check a sequence of an empty
8183 statement and a block.
8185 Both fix bug #66777.
8187 2005-08-24 Marek Safar <marek.safar@seznam.cz>
8189 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
8190 detection until I fix it.
8192 * cs-tokenizer.cs: Changed error message.
8194 * cs-parser.jay: Fixed 2 error locations.
8196 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
8197 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
8200 * enum.cs (GetSignatureForError): Fixed.
8202 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
8206 * typemanager.cs (RegisterProperty): Removed.
8208 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
8210 2005-08-24 Raja R Harinath <rharinath@novell.com>
8213 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
8214 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
8216 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8218 * expression.cs : tiny fix is required for not warning positive ulong.
8221 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8223 * expression.cs : add CS0652 check for constant and integral
8224 expression. Fixed bug #53974.
8226 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8228 * expression.cs : in DoNumericPromotions(), check if there is implicit
8229 conversion overload for string (to check CS0034). Fixed bug #52492.
8231 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8233 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
8235 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8237 * ecore.cs : report location when it is *not* Null.
8239 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8245 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
8246 correctly. Fixed bug #75721.
8248 2005-08-23 Raja R Harinath <rharinath@novell.com>
8250 * support.cs (SeekableStreamReader.Position): Avoid an expensive
8251 loop that performs 'min (pos, char_count)'.
8254 * expression.cs (Unary.ResolveOperator): Don't discard implicit
8255 converted value in Operator.OnesComplement.
8257 2005-08-22 Ben Maurer <bmaurer@ximian.com>
8259 * anonymous.cs: If the anon method is pulled into a helper class,
8260 it needs to be `internal' not `private'. Fixes runtime behavior on
8263 2005-08-20 Martin Baulig <martin@ximian.com>
8265 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
8266 scope if we don't already have it.
8268 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
8269 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
8272 2005-08-17 Marek Safar <marek.safar@seznam.cz>
8275 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
8278 2005-08-16 Marek Safar <marek.safar@seznam.cz>
8280 The big constants rewrite
8281 Fix #75746, #75685 and more
8282 As a side effect saved 1MB for MWF ;-)
8284 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
8285 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
8286 enum based for corlib compilation.
8288 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
8291 * class.cs (FixedField.Define): Use ResolveAsConstant.
8293 * const.cs (IConstant): Interface constants and enums.
8294 (Const.ResolveValue): New method for constant resolvning.
8295 (ExternalConstant): Constants from imported assemblies.
8297 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
8298 conversion; like enums.
8299 (Constant.ToType): Converts this constant to different type.
8300 (Constant.Increment): Adds 1.
8302 * convert.cs (ImplicitConversionRequired): Simplified.
8304 * cs-parser.jay: Create EnumMember directly.
8306 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
8308 * doc.cs (GenerateEnumDocComment): Removed.
8310 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
8311 (ConvertIntLiteral): Removed.
8312 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
8314 * enum.cs (EnumMember): Implement IConstant.
8315 (Enum.IsValidEnumConstant): Removed.
8316 (Enum.GetNextDefaultValue): Removed.
8317 (Enum.FindMembers): Updated.
8318 (Enum.GenerateDocComment): Iterate enum members.
8320 * expression.cs (Cast.TryReduce): Handle enums correctly.
8321 (New.Constantify): Made public.
8322 (MemberAccess.DoResolve): Removed contant specific if(s).
8324 * literal.cs (NullLiteral): Implement new abstract methods.
8326 * statement.cs (GotoCase.Resolve): Use new constant methods.
8327 (SwitchLabel.ResolveAndReduce): Use new constant methods.
8329 * typemanager.cs (LookupEnum): Removed.
8330 (IsEnumType): Fixed to work with corlib.
8331 (RegisterConstant): Removed.
8332 (LookupConstant): Removed.
8333 (GetConstant): Changed to work with IConstant.
8335 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
8337 * location.cs : Fixed overflown (>255) column number.
8339 2005-08-03 Raja R Harinath <rharinath@novell.com>
8341 First cut of the qualified-alias-member feature.
8342 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
8344 * cs-parser.jay (DOUBLE_COLON): New token.
8345 (namespace_or_type_name): Add rule for recognizing
8346 qualified-alias-members.
8347 (primary_expression): Likewise.
8348 (element_access): Allow QualifiedAliasMember as a possible
8349 type-bearing expression.
8350 (local_variable_type, local_variable_pointer_type): Likewise.
8351 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
8352 aliases in the current and enclosing namespace declarations.
8353 (NamespaceEntry.UsingAlias): Add CS0440 warning.
8354 * decl.cs (MemberName.is_double_colon): New.
8355 (MemberName.MemberName): Add new constructor for alias-member.
8356 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
8357 * expression.cs (QualifiedAliasMember): New expression type.
8359 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8361 * location.cs : it borked when no argument was specified.
8363 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8365 * location.cs : tiny ToString() format fix.
8367 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8369 * statement.cs : oops, it was missing.
8371 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8373 A set of fixes for precise line/column location.
8376 "token" field now holds a file/line "delta", a line number offset
8377 from the segment, and a column number. See also:
8378 http://lists.ximian.com/pipermail/mono-devel-list/2004-
8379 December/009508.html
8380 Removed static IsNull. Use instance IsNull property instead.
8382 For some tokens it stores Location. For Identifier it stores
8383 LocatedToken which is a pair of string name and location.
8384 Column numbers are adjusted only at getChar().
8386 Use Location.ToString() for reporting (it now contains column).
8388 Largely modified to use LocatedToken instead of
8389 string (IDENTIFIER), and to acquire Location from some tokens.
8390 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
8391 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
8393 Now MemberName holds Location. DeclSpace.ctor() receives Location
8394 as a parameter. Removed extra parameters to all derived classes.
8395 Replaced Location.IsNull() with instance property.
8396 * assign.cs, expression.cs :
8397 Added .ctor() overload that omits Location.
8399 Added "nameEscaped" flag that indicates the identifier was escaped
8400 in the source file. This fixes bug #57047.
8402 2005-08-02 Marek Safar <marek.safar@seznam.cz>
8404 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
8405 New method, looking for lo-case imported cls type.
8407 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
8410 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
8412 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
8414 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
8416 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
8418 Optimized to save 3.5 MB for SWF compilation.
8420 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8422 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
8423 (PartialContainer.Create): Moved logic AddToContainer.
8424 (PartialContainer.MarkForDuplicationCheck): Shares name.
8426 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
8429 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
8431 (Namespace.GetSignatureForError): New method.
8433 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
8434 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
8436 2005-08-01 Raja R Harinath <rharinath@novell.com>
8439 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
8440 member lookup rather than qualifier_type, since qualifier_type can
8443 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8445 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
8448 2005-07-31 Miguel de Icaza <miguel@novell.com>
8450 * statement.cs: Copy the local exception into the exception
8451 captured local. Fixes 75674
8453 2005-07-31 Raja R Harinath <harinath@gmail.com>
8456 * expression.cs (Invocation.OverloadResolve): Don't report error
8457 CS1501 if error CS1502 has been reported.
8458 (New.DoResolve): Delegate CS1501 reporting to
8459 Invocation.OverloadResolve.
8462 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
8463 invariant-meaning-in-block property in an enclosing block if
8466 2005-07-29 Marek Safar <marek.safar@seznam.cz>
8468 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
8469 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
8470 (Switch.CheckSwitch): Just save 50kb for SWF.
8472 2005-07-27 Martin Baulig <martin@ximian.com>
8474 * anonymous.cs (CaptureContext.AddField): Added
8475 `AnonymousContainer am' argument; compute its toplevel scope if
8476 it's not already computed. Fixes #75649.
8478 2005-07-26 Raja R Harinath <rharinath@novell.com>
8481 * class.cs (Constructor.Emit): Reset block to null if the block
8484 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8486 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
8488 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8490 * class.cs (MethodData.Define): Check whether accessor implementing
8491 interface is public.
8493 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
8495 2005-07-22 Marek Safar <marek.safar@seznam.cz>
8498 * namespace.cs (LookupType): Moved same type check to...
8500 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
8503 2005-07-21 Raja R Harinath <rharinath@novell.com>
8505 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
8506 already found a typebuilder.
8507 * class.cs (MethodCore.IsDuplicateImplementation): Compare
8508 MemberNames, not strings.
8510 * const.cs (Error_ExpressionMustBeConst):
8511 Rename from Error_EpressionMustBeConst.
8512 * const.cs, class.cs, statement.cd: Update.
8514 2005-07-21 Marek Safar <marek.safar@seznam.cz>
8518 * const.cs (Const.LookupConstantValue): Report missing contant expression
8520 (Error_EpressionMustBeConstant): Only one error method.
8522 * class.cs, statement.c: Updated.
8524 2005-07-20 Raja R Harinath <rharinath@novell.com>
8526 * statement.cs (Block.Flags): Add back HasVarargs.
8527 (Block.flags): Make protected.
8528 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
8530 * typemanager.cs (types, typecontainers, user_types): Remove.
8531 (UserTypes, TypeContainers): Likewise.
8532 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
8533 (CleanUp, Reset): Update.
8534 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
8535 (GetNestedType): Use Type.GetNestedType.
8536 (CoreLookupType): Take two arguments, the namespace and the
8537 basename of the type. Update to use the Namespace.Lookup
8539 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
8540 (RealMemberLookup): Use IsNestedChildOf instead of playing with
8541 string concatenation and substring matches.
8542 * class.cs, enum.cs, delegate.cs: Update to changes.
8544 2005-07-20 Marek Safar <marek.safar@seznam.cz>
8546 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
8547 Expression and made virtual.
8549 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
8550 (ImplicitStandardConversionExists): Fixed `byte' typo ?
8552 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
8554 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
8557 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
8560 2005-07-18 Marek Safar <marek.safar@seznam.cz>
8563 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
8564 AssemblyCultureAttribute is not used on executable.
8567 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
8569 2005-07-16 Raja R Harinath <rharinath@novell.com>
8572 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
8573 New. Reports CS0252/CS0253.
8574 Mostly taken from preliminary patch by Duncak Mak.
8575 (Binary.DoResolveOperator): Store results of operator lookup.
8576 Use them to detect if we need to warn about unintended reference
8579 2005-07-15 Raja R Harinath <rharinath@novell.com>
8582 * namespace.cs (Namespace.Lookup): Add back location parameter.
8583 (Namespace.LookupType): Add CS0436 report. Add location parameter.
8584 * delegate.cs, ecore.cs, expression.cs: Update to changes.
8586 * codegen.cs (EmitContext.DeclSpace): Make readonly.
8587 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
8588 (Namespace.LookupType): ... this.
8589 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
8591 * typemanager.cs (LookupTypeReflection): Remove buggy code that
8592 purported to handle pointers.
8593 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
8596 2005-07-15 Marek Safar <marek.safar@seznam.cz>
8598 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
8601 2005-07-15 Raja R Harinath <rharinath@novell.com>
8603 * namespace.cs (Namespace.Lookup): Drop location parameter.
8604 (NamespaceEntry.LookupAlias): Remove. Merge into ...
8605 (NamespaceEntry.Lookup): ... this.
8606 (NamespaceEntry.Error_AmbiguousTypeReference):
8607 Move here from DeclSpace.
8608 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
8610 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
8611 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
8612 Move to NamespaceEntry.
8613 * delegate.cs, expression.cs: Update to changes.
8615 2005-07-14 Marek Safar <marek.safar@seznam.cz>
8617 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
8618 CheckAttributeType and refactored.
8619 (Attribute.ResolvePossibleAttributeType): Changed to reuse
8620 ResolveAsTypeTerminal error handling.
8621 (ResolveAsTypeTerminal): Introduced because of global attributes extra
8623 (GetSignatureForError): Print errors in same way.
8626 * codegen.cs: Reflect attribute GetSignatureForError change.
8629 * expression.cs: Add silent parameter to ResolveAsTypeStep.
8631 * namespace.cs (UsingEntry): Refactored to make fields private.
8634 statement.cs: Error_UnexpectedKind has extra parameter.
8636 2005-07-14 Raja R Harinath <rharinath@novell.com>
8638 * ecore.cs (IAlias): Remove.
8639 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
8640 that implement the interface.
8641 * namespace.cs (Namespace): Likewise.
8642 (Namespace.declspaces): Renamed from 'defined_names'.
8643 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
8644 DeclSpace instead of an IAlias.
8645 * tree.cs (Tree.AddDecl): Update.
8647 2005-07-12 Raja R Harinath <rharinath@novell.com>
8649 * statement.cs (Block.Flags); Remove HasVarargs.
8650 (Block.HasVarargs): Move to ToplevelBlock.
8651 (Block.ThisVariable, Block.AddThisVariable): Likewise.
8652 (Block.Variables): Make protected. Initialize variable hashtable
8654 (Block.AddVariable): Update.
8655 (Block.Resolve): Update to changes.
8656 (ToplevelBlock.HasVarargs): New boolean.
8657 (ToplevelBlock.ThisVariable): Move here from Block.
8658 (ToplevelBlock.AddThisVariable): Likewise.
8659 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
8660 * expression.cs (This.ResolveBase): Update to changes.
8661 (ArglistAccess.DoResolve): Likewise.
8663 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8666 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
8668 * class.cs (TypeContainer.VerifyMembers): Distinguish between
8669 not used and not used & assigned.
8670 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
8672 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8675 * expression.cs (Is.DoResolve): null is never provided type.
8677 2005-07-08 Marek Safar <marek.safar@seznam.cz>
8680 * cs-parser.jay: Less strict event error rule to catch more errors.
8682 2005-07-08 Martin Baulig <martin@ximian.com>
8684 Fix test-iter-10.cs - distinguish whether we `yield' in a property
8685 gettter (allowed) or setter (not allowed).
8687 * class.cs (Accessor): Implement IIteratorContainer.
8688 (Accessor.Yields): New public field.
8689 (PropertyBase.PropertyMethod.Define): Handle iterators on a
8693 (get_accessor_declaration, set_accessor_declaration): Set the
8694 `yields' flag on the accessor, not the property.
8695 (property_declaration): Do the iterators check on a per-accessor
8696 basis and not for the whole property.
8698 2005-07-08 Martin Baulig <martin@ximian.com>
8700 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
8701 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
8703 2005-07-07 Marek Safar <marek.safar@seznam.cz>
8706 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
8707 (ExtractSecurityPermissionSet): Cope with self referencing security
8708 attributes properly.
8710 * driver.cs (SetOutputFile): Made public property OutputFile.
8712 2005-07-07 Raja R Harinath <rharinath@novell.com>
8715 * class.cs (TypeContainer.first_nonstatic_field): Rename from
8716 has_nonstatic_fields. Make into a FieldBase pointer.
8717 (TypeContainer.AddField): Add CS0282 check.
8718 (TypeContainer.EmitType): Update.
8720 2005-07-06 Miguel de Icaza <miguel@novell.com>
8722 * cs-tokenizer.cs (consume_identifier): Do not create strings to
8723 compare if they start with __.
8725 2005-07-06 Raja R Harinath <rharinath@novell.com>
8727 * statement.cs (Switch.SwitchGoverningType): Only look at
8728 UserCasts that don't need implicit standard conversions to one of
8729 the allowed switch types (Fixes test-322.cs).
8730 (LocalInfo.Resolve): Re-enable sanity-test.
8732 2005-07-06 Marek Safar <marek.safar@seznam.cz>
8734 * cs-tokenizer.cs (consume_identifier): Detect double undescores
8736 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
8738 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
8740 2005-07-06 Raja R Harinath <rharinath@novell.com>
8743 * ecore.cs (SimpleName.GetSignatureForError): Add.
8744 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
8745 (MemberAccess.GetSignatureForError): Add.
8747 2005-07-05 Marek Safar <marek.safar@seznam.cz>
8749 The big error and warning messages review.
8779 * typemanager.cs: Updated.
8781 * class.cs: (MethodCore.SetYields): Moved here to share.
8782 (PropertyMethod.Define): Moved iterator setup here.
8784 * iterators.cs: Add orig_method to have full access to parent
8787 2005-07-05 Raja R Harinath <rharinath@novell.com>
8789 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
8790 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
8791 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
8792 variable of struct type.
8793 * expression.cs (Unary.ResolveOperator): Update to change.
8794 (Indirection.VerifyFixed): Likewise.
8795 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
8796 (ParameterReference.VerifyFixed): Value parameters are fixed.
8797 (This.VerifyFixed): Treat 'this' as a value parameter.
8798 * statement.cs (LocalInfo.IsFixed): Remove.
8800 2005-07-01 Martin Baulig <martin@ximian.com>
8802 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
8803 `ec.EmitThis ()' to get the correct scope.
8805 2005-07-01 Martin Baulig <martin@ximian.com>
8807 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
8808 instance is a ParameterReference; fixes #75299.
8810 2005-07-01 Martin Baulig <martin@ximian.com>
8812 Reverted Marek's latest patch (r46725):
8813 - it contains structural changes which are neither mentioned in
8814 the ChangeLog nor explained anywhere; for example the additional
8815 argument of EmitContext's and Iterator's .ctor's and the
8816 TypeContainer.DefineMembers() change.
8817 - structural changes like this should go in in seperate patches
8818 and not be hidden in a huge patch which just seems to affect
8819 warnings and errors.
8820 a big and hard to understand patch.
8821 - it breaks iterators and causes regressions, for instance in
8824 2005-06-30 Raja R Harinath <rharinath@novell.com>
8827 * expression.cs (Indexers.map): Remove.
8828 (Indexers.Append): Filter out inaccessible setters and getters.
8829 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
8832 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
8834 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
8835 (FieldExpr.Emit, PropertyExpr.Emit): Update.
8836 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
8837 * expression.cs (Invocation.EmitCall): Add CS0120 check.
8839 2005-06-30 Marek Safar <marek.safar@seznam.cz>
8842 * class.cs (FieldBase.GetInitializerExpression): One more field
8845 2005-06-28 Miguel de Icaza <miguel@novell.com>
8847 * pending.cs: Do not define a proxy if the base method is virtual,
8848 it will be picked up by the runtime (bug 75270).
8850 2005-06-08 Martin Baulig <martin@ximian.com>
8852 The big Iterators rewrite :-)
8854 * iterators.cs: Rewrite this to use the anonymous methods framework.
8856 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
8857 before the TypeContainers; see 2test-21.cs.
8860 (TypeContainer.DefineType): Don't create a new EmitContext if we
8861 already have one (this only happens if we're an Iterator).
8862 (TypeContainer.Define): Also call Define() on all our iterators.
8863 (Method.CreateEmitContext): Added support for iterators.
8866 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
8867 (AnonymousContainer.CreateMethodHost): Moved here from
8868 AnonymousMethod and made abstract.
8869 (AnonymousContainer.CreateScopeType): New abstract method.
8870 (AnonymousContainer.IsIterator): New public property.
8871 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
8872 get the ScopeTypeBuilder rather than manually defining it here.
8873 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
8876 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
8877 before RootContext.DefineTypes().
8879 * codegen.cs (EmitContext.RemapToProxy): Removed.
8880 (EmitContext.CurrentAnonymousMethod): Changed type from
8881 AnonymousMethod -> AnonymousContainer.
8882 (EmitContext.ResolveTopBlock): Protect from being called twice.
8883 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
8884 (EmitContext.EmitThis): Removed the iterators hacks; use the
8885 anonymous methods framework for that.
8888 (ToplevelBlock.Container): Make this a property, not a field.
8889 (ToplevelBlock.ReParent): New public method; move the
8890 ToplevelBlock into a new container.
8891 (Foreach.TemporaryVariable): Simplify.
8893 2005-06-05 Martin Baulig <martin@ximian.com>
8895 * statement.cs (LocalInfo.CompilerGenerated): New flag.
8896 (Block.AddTemporaryVariable): New public method; creates a new
8897 `LocalInfo' for a temporary variable.
8898 (Block.EmitMeta): Create the LocalBuilders for all the temporary
8900 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
8901 non-iterator variables.
8903 2005-06-05 Martin Baulig <martin@ximian.com>
8905 * statement.cs (Foreach.TemporaryVariable): Create the
8906 LocalBuilder in the Emit phase and not in Resolve since in some
8907 situations, we don't have an ILGenerator during Resolve; see
8908 2test-19.cs for an example.
8910 2005-06-04 Martin Baulig <martin@ximian.com>
8912 **** Merged r45395 from GCS ****
8914 The big Foreach rewrite - Part II.
8916 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
8917 with `PropertyInfo ienumerator_getcurrent'.
8919 * codegen.cs (VariableStorage): Removed.
8922 (Foreach): Derive from Statement, not ExceptionStatement.
8923 (Foreach.CollectionForeach): New nested class. Moved all the code
8924 dealing with collection foreach here.
8925 (Foreach.ForeachHelperMethods): Removed.
8926 (Foreach.TemporaryVariable): Implement IMemoryLocation.
8928 2005-05-23 Martin Baulig <martin@ximian.com>
8930 * statement.cs (Try.DoResolve): Don't create a `finally' if we
8931 don't need to. Fix #75014.
8933 2005-05-20 Martin Baulig <martin@ximian.com>
8935 Merged r44808 from GMCS.
8937 * class.cs (TypeContainer.CircularDepException): Removed.
8938 (TypeContainer.DefineType): Removed the `InTransit' stuff.
8939 (TypeContainer.CheckRecursiveDefinition): Check for circular class
8940 (CS0146) and interface (CS0529) dependencies here.
8942 2005-06-21 Raja R Harinath <rharinath@novell.com>
8944 * expression.cs (Invocation.EmitCall): Fix initialization
8945 'this_call' to reflect current behaviour. Fix indentation.
8947 * convert.cs (FindMostEncompassedType): Add two trivial special
8948 cases (number_of_types == 0 || number_of_types == 1).
8949 (FindMostEncompasingType): Likewise.
8951 2005-06-17 Raja R Harinath <rharinath@novell.com>
8953 Some cleanups preparing for the fix of #75283.
8954 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
8956 (EventExpr.InstanceResolve): Likewise.
8957 (EventExpr.DoResolve): Remove redundant checks.
8959 2005-06-10 Duncan Mak <duncan@novell.com>
8961 * cs-tokenizer.cs (process_directives): New flag for controlling
8962 the processing of preprocessor directives.
8963 (x_token): After seeing a '#', return Token.NONE instead of going
8964 to handle_preprocessing_directive() when not processing
8965 directives. This avoids unnecessary processing during the token peek in
8970 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
8971 the existing error reporting methods instead of Report.Error.
8973 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
8974 after Raja's rewrite.
8976 2005-06-08 Miguel de Icaza <miguel@novell.com>
8978 * class.cs: Small fix.
8980 2005-06-08 Raja R Harinath <rharinath@novell.com>
8983 * class.cs (GetPartialBases): Fix return value check of
8986 2005-06-07 Raja R Harinath <rharinath@novell.com>
8988 Ensure that partial classes are registered in their enclosing
8989 namespace. Initial part of fix of #75160.
8990 * tree.cs (Tree.RecordDecl): Add new namespace argument.
8991 Register declspace with namespace here, not in
8992 DeclSpace.RecordDecl.
8993 * cs-parser.jay: Pass namespace to RecordDecl.
8994 * class.cs (PartialContainer.Create): Likewise.
8995 (ClassPart.DefineType): New sanity-check. Throws an exception if
8997 * decl.cs (Declspace.RecordDecl): Remove.
8998 * namespace.cs (NamespaceEntry.DefineName): Remove.
9000 2005-06-06 Marek Safar <marek.safar@seznam.cz>
9002 * rootcontext.cs: Reset TargetExt as well.
9004 2005-06-03 Raja R Harinath <rharinath@novell.com>
9006 * ecore.cs (Expression.Resolve): Emit CS0654 error when
9009 2005-06-02 Raja R Harinath <rharinath@novell.com>
9011 Fix #75080, cs0119.cs.
9012 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
9014 (Expression.Resolve): ... this. Use it. Remove bogus code
9015 allowing ExprClass.Type and ExprClass.Namespace for
9016 ResolveFlags.VariableOrValue.
9017 (Expression.Resolve) [1-argument variant]: Change default resolve
9018 flags based on language version.
9019 (Expression.Error_UnexpectedKind): Use a simple string array
9020 rather than an ArrayList.
9021 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
9023 (TypeOfVoid.DoResolve): Likewise.
9024 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
9025 flags argument -- it always has the same value.
9027 2005-05-31 Raja R Harinath <rharinath@novell.com>
9030 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
9031 Use it in the error message.
9032 * assign.cs, expression.cs, statement.cs: Update.
9034 2005-05-30 Raja R Harinath <rharinath@novell.com>
9037 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
9038 the "almostMatchedMember" case too.
9039 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
9040 that failed the accessibility checks to 'almost_match'.
9042 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
9044 * attribute.cs: Use internal MethodBuilder methods to set
9045 ExactSpelling and SetLastError on PInvoke methods, instead
9046 of passing them via charset. Fixes #75060.
9048 2005-05-27 Raja R Harinath <rharinath@novell.com>
9050 * parameter.cs (Parameter): Remove TODO comment.
9051 (Parameter.DefineParameter): Remove Location parameter.
9052 (Parameters.LabelParameters): Likewise.
9053 * class.cs (Constructor.Emit): Update to change.
9054 (MethodData.Emit): Likewise.
9055 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
9056 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
9058 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
9061 Removed Parameters.Location and added Parameter.Location instead.
9062 Removed Location parameter from Emit() and GetSignature().
9069 Modified all related calls.
9071 2005-05-26 Raja R Harinath <rharinath@novell.com>
9073 Improve user-defined conversion handling.
9074 * convert.cs (GetConversionOperators): Rewrite. Return only the
9075 applicable operators.
9076 (AddConversionOperators): New. Helper for GetConversionOperators.
9077 (FindMostEncompassedType, FindMostEncompassingType): Verify that
9078 there is only one most encompassed/encompassing type.
9079 (FindMostSpecificSource, FindMostSpecificTarget): Remove
9080 "applicable operator" handling.
9081 (UserConversion): Move cache here from GetConversionOperators.
9082 Directly cache the chosen operator, rather than the whole
9084 (ExplicitNumericConversion): Fix buggy implementation of Decimal
9085 case. Allow conversion of decimal to sbyte and byte too.
9086 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9087 New static methods. Used to avoid allocating EmptyExpressions in
9090 2005-05-24 Duncan Mak <duncan@novell.com>
9092 * ecore.cs (CastFromDecimal): New class for casting a decimal to
9093 another class, used in Convert.ExplicitNumericConversion.
9094 (CastToDecimal): New class, similar to above, but casts to
9095 System.Decimal, used in Convert.ImplicitNumericConversion and also
9096 in explicit convesion from double/float to decimal.
9098 * convert.cs (ImplicitNumericConversion): Handle implicit
9099 conversions to System.Decimal.
9100 (ExplicitNumericConversion): handle explicit conversions to
9105 2005-05-20 Miguel de Icaza <miguel@novell.com>
9107 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
9108 know the type at this stage, just break through. Fixes #75008
9110 2005-05-19 Martin Baulig <martin@ximian.com>
9113 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
9114 to disable error reporting.
9116 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
9117 here since we don't want to report an error; see the new test-336.cs.
9119 2005-05-19 Raja R Harinath <rharinath@novell.com>
9121 * statement.cs (ToplevelBlock.GetParameterReference)
9122 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
9123 Move here from class Block.
9124 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
9125 * expression.cs (ParameterReference.DoResolveBase): Likewise.
9127 2005-05-18 Martin Baulig <martin@ximian.com>
9132 (FlowBranching.Reachability): Add non-static public And() and Or()
9134 (FlowBranchingSwitch): New class; do the `break_origins' thing
9135 like in FlowBranchingLoop.
9136 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
9137 reachability, not just locals and parameters.
9138 (FlowBranching.MergeChild): Remove some of the hacks for loop and
9139 switch; MergeBreakOrigins() now takes care of that.
9141 2005-05-18 Martin Baulig <martin@ximian.com>
9143 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9144 a loop and may leave it, reset the barrier; fixes #74974.
9146 2005-05-17 Marek Safar <marek.safar@seznam.cz>
9148 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
9151 * cs-parser.jay: Catch more lexical errors.
9153 * report.cs: Add one more Error method.
9156 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
9158 2005-05-17 Martin Baulig <martin@ximian.com>
9160 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
9163 2005-05-16 Raja R Harinath <rharinath@novell.com>
9165 Fix test-382.cs. Emit values of decimal constants.
9166 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
9168 (TypeContainer.AddField): ... this.
9169 (TypeContainer.EmitFieldInitializers): Allow the list of fields
9170 with initializers to include 'Const's.
9171 (ClassPart.RegisterFieldForInitialization): Forward to
9173 * const.cs (Const.Const): Pass initializer to base class.
9174 (Const.Define): In case of decimal constants, register them for
9175 initialization in a static constructor.
9177 2005-05-14 Martin Baulig <martin@ximian.com>
9179 * statement.cs (Block.Resolve): Correctly handle unreachable code;
9180 do not call ResolveUnreachable() on unreachable statements in
9181 here, see the comment in the source code.
9183 2005-05-13 Raja R Harinath <rharinath@novell.com>
9186 * expression.cs (BinaryResolveOperator): If one of the operands of
9187 an equality comparison is 'null' and the other is a pointer type,
9188 convert the null to a NullPointer.
9189 * convert.cs (ImplicitReferenceConversion): If the expression is a
9190 NullLiteral and the target type is a pointer type, return a
9191 NullPointer instead.
9192 (ImplicitConversionStandard): Likewise.
9194 2005-05-13 Marek Safar <marek.safar@seznam.cz>
9196 * cs-parser.jay: Set readonly context based on special constructs.
9198 * expression.cs (LocalVariableReference.DoResolveBase): Improved
9199 readonly variable error handling.
9201 * rootcontext.cs (EmitCode): Don't verify members when error
9204 * statement.cs (LocalInfo): Add reaodnly context information.
9205 (SetReadOnlyContext, GetReadOnlyContext): New methods.
9207 2005-05-13 Raja R Harinath <rharinath@novell.com>
9209 * statement.cs (Block.Resolve): Revert change below. Modify fix
9210 for #74041 to initialize 'resolved' to false only for explicit
9211 blocks. Fixes #74873.
9213 2005-05-12 Raja R Harinath <harinath@gmail.com>
9216 * typemanager.cs (unmanaged_enclosing_types): New.
9217 (IsUnmanagedType): Avoid infloops by using
9218 'unmanaged_enclosing_types' to talk with recursive invocations.
9220 2005-05-13 Martin Baulig <martin@ximian.com>
9222 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
9223 instance variable, not a local. Fix #74873.
9224 (Block.ResolveUnreachable): Set it to true here.
9226 2005-05-11 Duncan Mak <duncan@novell.com>
9228 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
9229 continuing to process for 'arg'.
9230 (handle_preprocessing_directive): Check the argument of the #endif
9231 directive and report error CS1025 if there are any trailing
9234 According to the C# spec, having even whitespace after the #endif
9235 directive is illegal; however, because we call arg.TrimEnd ()
9236 beforehand, we have the same behavior as csc, allowing whitespace
9237 after the directive.
9241 2005-05-11 Marek Safar <marek.safar@seznam.cz>
9245 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
9246 (Constructor.GetObsoleteAttribute): Implemented correctly.
9248 2005-05-10 Martin Baulig <martin@ximian.com>
9250 * support.cs (ReflectionParameters.ParameterModifier): Use
9251 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
9252 and `ParameterAttributes.In'. Fixes #74884.
9254 2005-05-10 Marek Safar <marek.safar@seznam.cz>
9256 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
9258 * expression.cs (Argument.GetParameterModifier): Turned to property.
9259 (Invocation.Error_InvalidArguments): Add more descriptive errors.
9261 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
9264 2005-05-09 Raja R Harinath <rharinath@novell.com>
9267 * decl.cs (MemberCache.AddMethods): Register override methods,
9268 rather than non-override methods.
9269 * typemanager.cs (RegisterOverride): New.
9270 (IsOverride): Update.
9272 2005-05-09 Marek Safar <marek.safar@seznam.cz>
9276 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
9277 recursive declaration.
9279 * statement.cs (Block.ResolveMeta): Report any error in resolving.
9281 2005-05-06 Marek Safar <marek.safar@seznam.cz>
9283 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
9285 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
9287 2005-05-05 Raja R Harinath <rharinath@novell.com>
9290 * decl.cs (DeclSpace.FamilyAccessible):
9291 Use TypeManager.IsNestedFamilyAccessible.
9293 Fix reopened #64812.
9294 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
9297 2005-05-04 Raja R Harinath <rharinath@novell.com>
9298 Abin Thomas <projectmonokochi@rediffmail.com>
9299 Anoob V E <projectmonokochi@rediffmail.com>
9300 Harilal P R <projectmonokochi@rediffmail.com>
9303 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
9304 allow access to all static members.
9306 2005-05-04 Martin Baulig <martin@ximian.com>
9308 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
9310 2005-05-04 Martin Baulig <martin@ximian.com>
9314 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
9315 section at the end; make things work if `default' is not the last
9318 2005-05-04 Martin Baulig <martin@ximian.com>
9322 * statement.cs (Switch): Replaced the `got_default' field with a
9323 `default_section' one.
9324 (Switch.CheckSwitch): Set `default_section' here.
9325 (Switch.Resolve): If we're a constant switch and the constant is
9326 not found, use the default section.
9328 2005-05-03 Martin Baulig <martin@ximian.com>
9330 * expression.cs (ArrayAccess.EmitGetLength): New public method.
9332 * statement.cs (Foreach.ArrayForeach): New nested class.
9333 (Foreach.TemporaryVariable): New nested class.
9334 (Foreach.EmitArrayForeach): Removed; this is now in the new
9337 2005-05-03 Raja R Harinath <rharinath@novell.com>
9339 * pending.cs (BaseImplements): Move the #74773 fix here. This is
9341 (VerifyPendingMethods): Revert change below.
9343 * typemanager.cs (IsOverride, RegisterNonOverride): New.
9344 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
9345 that used to trigger warning -28. Remove warning -28.
9346 * expression.cs (Invocation.OverloadResolve): Use
9347 TypeManager.IsOverride to distinguish override methods.
9350 * pending.cs (VerifyPendingMethods): If a base type implements the
9351 requested interface, don't bother checking individual methods of
9352 the base type. As a side-effect, this prevents the creation of
9353 unnecessary proxies.
9355 2005-05-02 Martin Baulig <martin@ximian.com>
9359 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9360 Also `And' the locals if the old vector is null.
9361 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
9362 null; in this case we basically reset all the variables.
9364 2005-05-02 Martin Baulig <martin@ximian.com>
9368 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
9369 Added `FlowBranching branching' argument; always `and' the
9370 variables instead of `or'ing them unless we're an infinite loop.
9372 * statement.cs (While.Resolve): Create a new sibling unless we're
9375 2005-05-02 Martin Baulig <martin@ximian.com>
9379 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
9380 arguments; use it instead of creating a new TopLevelBlock.
9381 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
9382 our ConstructorInitializer.
9385 (TopLevelBlock.TopLevelBranching): New public property.
9386 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
9387 and create our `TopLevelBranching'.
9389 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
9390 anonymous method host, use `block.TopLevelBranching' rather than
9391 creating a new branching.
9393 2005-04-20 Miguel de Icaza <miguel@novell.com>
9395 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
9396 a ScopeInfo, if any of the current children is a child of the new
9397 entry, move those children there.
9399 2005-04-30 Martin Baulig <martin@ximian.com>
9401 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
9402 at the beginning of a SwitchSection. Fix #73335.
9404 2005-04-27 Marek Safar <marek.safar@seznam.cz>
9407 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
9409 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
9410 (FieldExpr.DoResolve): Obsolete members are ignored for field
9413 2005-04-26 Marek Safar <marek.safar@seznam.cz>
9415 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
9416 of arrays detection.
9418 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
9420 (Field.VerifyClsCompliance): Volatile fields are not compliant.
9422 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
9425 2005-04-25 Ben Maurer <bmaurer@ximian.com>
9427 * cs-parser.jay: Use the prefered version of -unsafe in error
9430 2005-04-22 Marek Safar <marek.safar@seznam.cz>
9432 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
9435 2005-04-20 John Luke <john.luke@gmail.com>
9437 * driver.cs: fix typo in error message, --outout to --output
9439 2005-04-20 Marek Safar <marek.safar@seznam.cz>
9441 * codegen.cs (InRefOutArgumentResolving): New field.
9443 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
9444 fields outside contructor.
9446 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
9448 2005-04-19 Miguel de Icaza <miguel@novell.com>
9450 * anonymous.cs (CaptureContext.EmitParameterInstance): The
9451 parameter code was not completed ever, so it was not as up-to-date
9452 as local variables. Must finish it.
9454 The bug fix was to compare the Toplevel of the block, not the
9455 current block. Thanks for Ben for pointing this out.
9457 2005-04-19 Raja R Harinath <rharinath@novell.com>
9459 * decl.cs (AddMethods): Use the declaring type of the problem
9460 method to determine if we want to squash a warning.
9462 2005-04-19 Marek Safar <marek.safar@seznam.cz>
9464 * attribute.cs: Removed debug output.
9466 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
9468 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
9471 2005-04-18 Raja R Harinath <rharinath@novell.com>
9474 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
9475 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
9476 all null comparisons against reference types.
9478 2005-04-18 Marek Safar <marek.safar@seznam.cz>
9481 * class.cs (TypeContainer.CircularDepException) New nested
9483 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
9484 (TypeContainer.DefineType): Removed error, reset InTransit before
9486 (Class.DefineType): Throw exception when is in Transit.
9487 Catch exception and report error.
9488 (Struct.DefineType): Throw exception when is in Transit.
9489 Catch exception and report error.
9490 (Interface.DefineType): Throw exception when is in Transit.
9491 Catch exception and report error.
9493 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
9494 handle nested exception handlers.
9496 * flowanalysis.cs (InTryWithCatch): New method, search for try with
9499 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
9500 InFinally and InCatch storage.
9502 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
9503 (Catch.Resolve): Set and Restore ec.InCatch.
9504 (Try.Resolve): Set and Restore ec.InFinally.
9505 (Try.HasCatch): True when try has catch.
9507 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
9509 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
9510 for the same event member, so exclude such cases from warning 419.
9513 2005-04-16 Miguel de Icaza <miguel@novell.com>
9515 * expression.cs (Binary.ResolveOperator): Apply patch from John
9516 Luke to fix bug 59864: operators &, | and ^ on enumerations
9517 require that the same enum type on both sides.
9519 * driver.cs: Add warnings to old flag usage, this is to assist
9520 people who produce Makefiles and hope that the Makefiles will be
9523 * class.cs (TypeContainer.EmitType): Moved the definition of the
9524 special $PRIVATE$ field from the resolve phase to the Emit phase.
9525 During resolve we do not know if we are a struct with
9526 HasExplicitLayout, we know this only after the attributes for the
9529 Set the FieldOffset to zero on the dummy field that we create for
9530 the class. Fixes 74590.
9532 2005-04-16 Raja R Harinath <rharinath@novell.com>
9535 * ecore.cs (PropertyExpr.resolved): New.
9536 (DoResolve): Use it to handle a case of double resolution here.
9537 Handle a case of identical-name-and-type-name.
9538 * expression.cs (ArrayCreation.CheckIndices): Avoid double
9539 resolution by storing the results of expression resolution back
9540 into the "probes" array.
9542 2005-04-15 Raja R Harinath <rharinath@novell.com>
9544 Fix cs0208-7.cs and cs0208-8.cs.
9545 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
9546 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
9547 error reporting to point out the reason a struct is not unmanaged.
9549 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9551 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
9552 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
9554 2005-04-13 Raja R Harinath <rharinath@novell.com>
9557 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
9558 IdenticalNameAndTypeName here.
9559 (EventExpr.InstanceResolve): Likewise.
9561 2005-04-13 Marek Safar <marek.safar@seznam.cz>
9563 C# 2.0 DefaultCharSetAttribute implementation
9565 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
9566 which allows us to set GlobalNamespace for every resolve.
9567 (Attribute.ResolveArguments): Cut from Resolve.
9568 (Attribute.GetCharSetValue): Returns CharSet named argument.
9569 (Attribute.DefinePInvokeMethod): Gets default charset from
9571 (GlobalAttribute.ResolveAsTypeStep): Override.
9572 (GlobalAttribute.ResolveArguments): Override.
9574 * class.cs (TypeAttr): Is protected.
9576 * codegen.cs (ModuleClass.DefaultCharSet): New member.
9577 (ModuleClass.DefaultCharSetType): New memeber.
9578 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
9580 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
9581 charset from module.
9583 * delegate.cs (TypeAttr): Override.
9584 (Delegate.DefineType): Use this TypeAttr.
9586 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
9587 at very early stage (before types are defined) to resolve model
9588 module attributes. It will probably not work with corlib but it
9591 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
9592 charset from module.
9594 * typemanager.cs (default_charset_type): New type.
9596 2005-04-13 Raja R Harinath <rharinath@novell.com>
9598 * decl.cs (MemberCache.AddMethods): Don't warn if
9599 System.Object.Finalize has buggy MethodAttributes.
9601 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
9604 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9606 * doc.cs : detect ambiguous reference to overloaded members.
9607 Fixed bug #71603. MS 1.1 csc does not detect it.
9609 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9611 * doc.cs : delegates must not be referenced with parameters.
9614 2005-04-12 Miguel de Icaza <miguel@novell.com>
9616 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
9618 2005-04-10 Miguel de Icaza <miguel@novell.com>
9620 * driver.cs (MainDriver): Stop processing if the CLS stage found
9623 (CompilerCallableEntryPoint.InvokeCompiler): Always
9624 reset after execution; Take a TextWriter argument for the
9627 * report.cs: Use the error stream instead of hardcoding stderr.
9629 2005-04-09 Miguel de Icaza <miguel@novell.com>
9631 * class.cs: Reduce code paths to test, too small of an
9632 optimization to make it worth the extra testing. Always perform
9635 2005-04-08 Raja R Harinath <rharinath@novell.com>
9638 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
9639 operators that had errors reported on them.
9641 2005-04-08 Marek Safar <marek.safar@seznam.cz>
9643 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
9645 (Attribute.Resolve): Add named argument type checking.
9647 * class.cs (FixedField.Define): Use IsPrimitiveType
9649 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
9651 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
9652 unsafe parameter types.
9654 * statement.cs (Using.ResolveExpression): Add better error description.
9656 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
9658 2005-04-08 Raja R Harinath <rharinath@novell.com>
9661 * attribute.cs (Attribute.GetAttributeUsage): Resolve
9662 AttributeUsageAttribute in the emitcontext of the attribute class,
9663 not in the emitcontext of the attributable entity it was attached to.
9664 * cs-parser.jay: Use 'current_class', not 'current_container',
9665 when creating a GlobalAttribute.
9667 2005-04-08 Alp Toker <alp@atoker.com>
9669 * pending.cs: The fix to #58413 failed to compile methods implementing
9670 interfaces with/without params modifiers and vice versa, even though
9671 params modifiers aren't part of the signature. Make the modifier check
9672 less strict as in csc.
9674 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
9675 Anoob V E <projectmonokochi@rediffmail.com>
9676 Harilal P R <projectmonokochi@rediffmail.com>
9679 * pending.cs (TypeAndMethods.mods): New. Store the parameter
9680 modifiers of pending methods.
9681 (PendingImplementation.PendingImplementation): Initialize it.
9682 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
9683 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
9684 with ParameterData. Add check for modifiers.
9685 * class.cs (MethodData.Define): Update to changes.
9687 2005-04-07 Raja R Harinath <rharinath@novell.com>
9689 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
9691 2005-04-07 Marek Safar <marek.safar@seznam.cz>
9693 * class.cs (PropertyMethod.Define): Check private accessor in abstract
9696 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
9699 * typemanager.cs: Registered RequiredAttributeAttribute.
9701 2005-04-06 Marek Safar <marek.safar@seznam.cz>
9703 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
9704 Warning CS0169 is back at level 3.
9705 (IMethodData.SetMemberIsUsed): New method.
9707 * decl.cs (IsUsed): New value; moved from FieldBase.Status
9708 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
9710 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
9712 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
9714 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
9717 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
9720 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
9721 to avoid the problems with nested types.
9723 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
9724 Anoob V.E <projectmonokochi@rediffmail.com>
9725 Harilal P.R <projectmonokochi@rediffmail.com>
9726 Raja R Harinath <rharinath@novell.com>
9729 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
9731 * typemanager (GetConstructor): Make public.
9733 2005-04-05 John Luke <john.luke@gmail.com>
9734 Raja R Harinath <rharinath@novell.com>
9737 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
9738 struct too. Return false quicker in a few cases.
9739 (VerifyUnManaged): Use it.
9741 2005-04-05 Raja R Harinath <rharinath@novell.com>
9744 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
9745 not 'unreachable_seen'.
9747 2005-04-04 Marek Safar <marek.safar@seznam.cz>
9749 * attribute.cs (Attribute.GetValue): Removed unused.
9751 * codegen.cs (CodeGen.TrimExt): Removed unused.
9753 * cs-parser.jay (output): Removed unused.
9755 * cs-tokenizer.cs (hex_digits): Removed unused.
9757 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
9759 * expression.cs (Indirection.LoadExprValue): Removed unused.
9760 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
9762 * iterators.cs (Iterator.param_types): Removed unused.
9764 * statement.cs (Goto.block): Removed unused.
9765 (ToplevelBlock.did): Removed unused.
9766 (Switch.ResolveConstantSwitch): Removed unused.
9768 2005-04-01 Ben Maurer <bmaurer@ximian.com>
9770 * rootcontext.cs: Allow mcs to bootstrap with the compilation
9773 2005-04-01 Raja R Harinath <rharinath@novell.com>
9775 Fix #74232 and cs0208-3.cs.
9776 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
9777 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
9778 unmanaged type. Don't use FieldBuilders when 't' is a
9779 TypeBuilder. Use ModFlags and MemberType fields.
9780 * class.cs (MemberBase.member_type): Rename from MemberType.
9781 (MemberBase.MemberType): New property. Determines member_type on
9783 (MemberBase.DoDefine): Don't initialize MemberType here.
9784 (FieldMember.Define): Likewise.
9786 2005-04-01 Marek Safar <marek.safar@seznam.cz>
9789 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
9790 Attributes are emitted there.
9792 2005-04-01 Raja R Harinath <rharinath@novell.com>
9794 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
9795 keyword in 'partial enum' too.
9796 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
9798 Report from Kamil Skalski <nazgul@omega.pl>.
9801 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
9802 have partial containers too.
9804 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
9805 in block' checks to Block.CheckInvariantMeaningInBlock.
9806 * statement.cs (Block.GetKnownVariableInfo): Make private.
9807 (Block.IsVariableUsedInChildBlock): Remove.
9808 (Block.IsVariableUsedInBlock): Likewise.
9809 (Block.CheckInvariantMeaningInBlock): New. Show location of
9810 conflicting declaration.
9811 (Block.AddVariable): Make error messages less long-winded and more
9812 specific. Show location of conflicting declaration.
9813 * parameter.cs (Parameters.Location): New readonly property.
9815 2005-03-31 Raja R Harinath <rharinath@novell.com>
9817 Clean up semantics of invoking ResolveMemberAccess.
9818 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
9819 can have an instance, ensure that we pass in a non-TypeExpression
9820 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
9821 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
9822 argument. Update to changes and simplify.
9823 (FieldExpr.Emitinstance): Remove CS0120 check.
9824 (PropertyExpr.EmitInstance): Likewise.
9825 * expression.cs (Argument.Resolve): Likewise.
9826 (Invocation.DoResolve): Update to changes in semantics of
9829 2005-03-31 Marek Safar <marek.safar@seznam.cz>
9832 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
9835 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
9837 2005-03-31 Raja R Harinath <rharinath@novell.com>
9839 Fix difference in behaviour with commandline invocation.
9840 * driver.cs (Driver.Reset): New.
9841 (CompilerCallableEntryPoint): Call it.
9843 * statement.cs (If.Resolve): Avoid spurious "uninitialized
9844 variable" warnings if the boolean expression failed to resolve.
9846 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
9848 * attribute.cs: Fix the union of several permissions when some of them
9849 are unrestricted (so the result isn't an unrestricted permission set).
9852 2005-03-30 Raja R Harinath <rharinath@novell.com>
9854 * ecore.cs (MemberExpr): New class. Convert from interface
9856 (MemberExpr.ResolveMemberAccess): Refactor and move here from
9857 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
9859 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
9860 (MethodGroupExpr.IsExplicitImpl): Remove.
9861 (Expression.GetFieldFromEvent): Remove.
9862 (SimpleName.MemberStaticCheck): Remove.
9863 (SimpleName.DoSimpleNameResolve): Update to changes.
9864 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
9865 (MemberAccess.IdenticalNameAndTypeName): Remove.
9866 (MemberAccess.error176): Move to MemberExpr.
9867 (MemberAccess.DoResolve): Update to changes.
9868 (BaseAccess.DoResolve): Likewise.
9870 2005-03-30 Marek Safar <marek.safar@seznam.cz>
9872 C# 2.0 Conditional attribute class implementation
9874 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
9875 Analyzes class whether it has attribute which has ConditionalAttribute
9876 and its condition is not defined.
9878 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
9879 (Class.IsExcluded): New method. Search for at least one defined
9880 condition in ConditionalAttribute of attribute class.
9882 2005-03-30 Raja R Harinath <rharinath@novell.com>
9884 * ecore.cs (PropertyExpr): Derive from Expression, not
9885 ExpressionStatement.
9886 (PropertyExpr.EmitStatement): Remove.
9888 2005-03-29 Raja R Harinath <rharinath@novell.com>
9891 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
9892 internal field "value__" of an enum be private. The examples for
9893 "value__" that I found on MSDN all used FieldAttributes.Private.
9895 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
9896 Don't mention IL method attribute names.
9898 Fix #47991. Remove a TODO.
9899 * statement.cs (Block.Toplevel): Make into a field.
9900 (Block.Parameters): Move into ToplevelBlock.
9901 (Block.known_variables): Rename from child_variable_names.
9902 (Block.Block): Remove variants that take Parameters. Initialize
9903 'Toplevel' with the immediately surrounding toplevel block.
9904 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
9905 LocalInfo parameter.
9906 (Block.GetKnownVariableInfo): New.
9907 (Block.IsVariableNameUsedInChildBlock): Update.
9908 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
9909 the block, even though it may not be in scope.
9910 (Block.AddVariable): Remove Parameters parameter. Use
9911 Toplevel.Parameters instead.
9912 (Block.AddConstant): Remove Parameters parameter.
9913 (Block.GetParameterReference): Update to use Toplevel.Parameters.
9914 (Block.IsParamaterReference): Likewise.
9915 (Block.IsLocalParameter): Likewise. Simplify a lot.
9916 (ToplevelBlock.Parameters): New. Moved from Block.
9917 (ToplevelBlock.ToplevelBlock): Update to changes. Always
9918 initialize Parameters to a non-null value.
9919 * cs-parser.jay: Update to changes.
9920 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
9921 simple names that mean different things in the same block. Use
9922 Block.IsVariableNameUsedInBlock.
9924 2005-03-28 Raja R Harinath <rharinath@novell.com>
9926 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
9927 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
9928 GetTypeHandle. It is possible for a reflected type to derive from
9929 a TypeBuilder (e.g., int[] derives from the TypeBuilder
9930 System.Array during mscorlib compilation).
9931 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
9932 contain a method_hash, don't create one either. Don't create a
9933 deep copy of the base cache's method_hash.
9934 (MemberCache.SetupCache): Rename back from DeepCopy.
9935 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
9936 already initialized. If we see an override function, add its
9937 underlying base virtual function to the member_hash too.
9939 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
9941 2005-03-26 Raja R Harinath <harinath@acm.org>
9944 * assign.cs (Assign.DoResolve): When the RHS of an assignment
9945 fails to resolve, ensure that the LHS is still resolved as an
9948 2005-03-25 Raja R Harinath <harinath@acm.org>
9950 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
9952 (Enum.current_ec): Remove.
9953 (Enum.LookupEnumValue): Remove EmitContext argument.
9954 Just uses the one created during DefineType.
9955 (Enum.FindMembers): Update.
9956 * expression.cs (MemberAccess.DoResolve): Update.
9958 2005-03-22 Marek Safar <marek.safar@seznam.cz>
9960 * assign.cs (Assign.DoResolve): Check for CS1717 when
9961 source and target are same (uses Equals).
9963 * expression.cs (LocalVariableReference, ParameterReference,
9964 This): Implemented Equals, GetHashCode.
9966 * statement.cs (Block.GetParameterReference): Removed useless
9969 2005-03-22 Raja R Harinath <rharinath@novell.com>
9972 * statement.cs (Block.AddVariable): Ensure that we skip implicit
9973 blocks before deciding whether the error is cs0136 or cs0128.
9975 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
9976 (using_alias_directive, using_namespace_directive): Pass
9977 MemberName, not an expression to Namespace.UsingAlias and
9979 (MakeName): Use the MemberName of the namespace.
9980 * namespace.cs (Namespace.MemberName): New.
9981 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
9982 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
9984 * decl.cs (MemberName.Name): Make readonly.
9985 (MemberName.FromDotted): New "constructor".
9986 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
9987 (MemberCore.Name): Compute from MemberName on demand.
9988 (MemberCore.SetMemberName): Provide a way to change the
9990 (MemberCore.AddToContainer): Don't take a fullname parameter.
9991 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
9992 fully qualified name of the container to the member name.
9993 (TypeContainer.AddToTypeContainer): Use a fully qualified name
9994 only if the type is a member of the root container.
9995 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
9996 MemberName.Left rather than searching for an embedded ".".
9997 (PartialContainer.CreatePart): Update to changes in RootContext.
9998 (MemberBase.ShortName): Turn into a property. Use
9999 MemberCore.SetMemberName.
10000 (MemberBase.ExplicitInterfaceName): Remove.
10001 (MemberBase.UpdateMemberName): Remove.
10002 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
10003 (PropertyBase.SetMemberName): New override.
10004 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
10005 (Tree.GetDecl): New.
10006 (Tree.AllDecls): Rename from Decls.
10007 * attribute.cs, enum.cs, report.cs: Update to changes.
10008 * driver.cs (MainDriver): Use MemberName.FromDotted on
10009 RootContext.MainClass.
10011 2005-03-21 Marek Safar <marek.safar@seznam.cz>
10013 * class.cs (FixedField.Define): Check for CS1664 and more sanity
10016 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
10018 2005-03-18 Marek Safar <marek.safar@seznam.cz>
10020 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
10021 property accessor modifiers.
10023 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
10024 fixed buffer attribute (CS1716).
10025 (PropertyMethod.HasCustomAccessModifier): When property accessor
10026 has custom modifier.
10028 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
10030 (PropertyExpr.DoResolveLValue): Add CS0272.
10032 2005-03-17 Miguel de Icaza <miguel@novell.com>
10034 * convert.cs: When converting to a pointer, use the proper Conv.U
10035 or Conv.I depending on the source data type.
10037 * cs-tokenizer.cs: Make the size for large decimal constants,
10040 2005-03-17 Martin Baulig <martin@ximian.com>
10042 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
10043 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
10045 2005-03-17 Martin Baulig <martin@ximian.com>
10047 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
10048 to bool so we can return an error condition.
10049 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
10052 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
10054 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
10057 2005-03-16 Raja R Harinath <rharinath@novell.com>
10059 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
10060 Refactor to avoid traversing the list of assemblies, and to avoid
10061 string concatenation.
10062 * typemanager.cs (guid_attr_type): Remove.
10063 (negative_hits, pointers, references): Remove hashes.
10065 (GetConstructedType): New. Uses type_hash to handle constructed
10066 types (arrays, references, pointers).
10067 (GetReferenceType, GetPointerType): Use it.
10068 (GetNestedType): New. Uses type_hash to handle nested types of
10070 (LookupType, LookupTypeDirect): Remove.
10071 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
10072 'types' hash and LookupTypeReflection directly.
10073 (params_string, params_object): Use GetConstructedType.
10074 * namespace.cs (Namespace.cached_types): New. Cache of reflected
10076 (Namespace.Lookup): Use cached_types.
10077 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
10078 provided by old TypeManager.LookupType.
10079 * rootcontext.cs (MakeFQN): Remove.
10080 * decl.cs (DeclSpace.MakeFQN): Likewise.
10081 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
10082 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
10083 TypeManager.GetConstructedType.
10084 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
10086 2005-03-15 Marek Safar <marek.safar@seznam.cz>
10088 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
10091 * cs-parser.jay: Reports CS1527 for any namespace element.
10093 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
10096 * expression.cs (ParameterReference.IsAssigned): Changed error to
10098 (Error_WrongNumArguments): Moved CS0245 detection here.
10100 * statement.cs (Return.Resolve): Add CS1622 report.
10102 2005-03-11 Marek Safar <marek.safar@seznam.cz>
10104 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
10106 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
10108 * attribute.cs expression.cs: Get rid of some allocations.
10110 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
10112 * doc.cs : just eliminate the latest change.
10114 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10116 * doc.cs : commented out the latest change. It breaks xml-030.cs
10118 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10120 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
10121 fail. So invoke CreateType() in FindDocumentedType().
10123 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10125 * cs-tokenizer.cs : added IsKeyword().
10126 * doc.cs : Detect keyword incorrectly used as identifier.
10127 Allow identifiers prefixed by @.
10129 2005-03-10 Marek Safar <marek.safar@seznam.cz>
10131 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
10132 It caused exception in namespace resolving (again!).
10134 * class.cs (Class.ctor): Removed exit.
10135 (PropertyMethod.ctor): ditto.
10137 * codegen.cs (Codegen.Reset): Reset static data.
10138 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
10140 * cs-tokenizer.cs (Cleanup): Removed.
10142 * driver.cs (GetSystemDir): Rewrote to one line command.
10143 It caused problem with unloaded dynamic modules.
10144 (UnixParseOption): Removed Exit.
10145 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
10146 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
10147 Now can be mcs used as library.
10149 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
10152 * location.cs (Reset): Reset static data.
10154 * namespace.cs (Reset): Reset static data.
10156 * report.cs (Report.Reset): Reset static data.
10158 * rootcontext.cs (RootContext.Reset): Reset static data.
10160 * tree.cs (RootTypes.ctor): Use Location.Null
10162 * typemanager.cs (TypeManager.Reset): Reset static data.
10163 (CoreLookupType): Removed Exit.
10164 (TypeHandle.Reset): Reset static data.
10166 2005-03-10 Raja R Harinath <rharinath@novell.com>
10169 * typemanager.cs (ComputeNamespaces): Import namespaces from
10170 referenced modules too.
10172 2005-03-09 Raja R Harinath <rharinath@novell.com>
10174 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
10177 2005-03-09 Raja R Harinath <rharinath@novell.com>
10179 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
10180 enclosing DeclSpace. This ensures that a name-lookup populates
10181 more caches and there are fewer 'TypeExpression's. Carve out
10182 nested type lookup into ...
10183 (LookupNestedTypeInHierarchy): ... this.
10185 2005-03-09 Raja R Harinath <rharinath@novell.com>
10187 Clean up a few partial-class semantics.
10188 Fixes test-357.cs and cs1618-2.cs.
10189 * cs-parser.jay (struct_declaration): Use 'current_class' as
10190 parent of newly-created struct. Remove call to Register ().
10191 Use 'pop_current_class' to complete handing the current struct.
10192 (interface_declaration): Likewise.
10193 (class_declaration): Likewise.
10194 (enum_declaration): Use 'current_class' as parent of newly created
10196 (delegate_declaration): Likewise.
10197 (pop_current_class): New function. This is used to handle closing
10198 up the 'current_class' and 'current_container', and pointing them
10199 to the enclosing class/container.
10200 (CSharpParser): Initialize 'current_class' too.
10201 * decl.cs (MemberCore): Add check for invariant: a partial
10202 container is not a parsed entity, and thus does not enclose any
10204 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
10205 (DeclSpace.BaseTypeExpr): Use it.
10206 (DeclSpace.LookupType): Add check for invariant.
10207 * class.cs (TypeContainer): Add check for invariant: a nested
10208 class should have the same NamespaceEntry as its enclosing class.
10209 (TypeContainer.EmitFieldInitializers): Make virtual.
10210 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
10212 (TypeContainer.Register): Remove.
10213 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
10214 null. Use TypeResolveEmitContext for resolving base types and
10215 interfaces. Move initialization of Parts.TypeBuilder here from
10217 (TypeContainer.DefineNestedTypes): ... here.
10218 (PartialContainer): Take a Namespace not a NamespaceEntry.
10219 (PartialContainer.Create): Don't use Register. Call the
10220 appropriate Add... function directly.
10221 (ClassPart): Take both the PartialContainer and the enclosing
10222 class as constructor arguments.
10223 (ClassPart.EmitFieldInitializers): Override.
10224 (ClassPart.PartFindNestedTypes): Remove.
10225 (FieldBase.GetInitializerExpression): Resolve the initializer
10226 expression in the emit context of the enclosing class.
10227 * tree.cs (RootTypes): Remove Register ().
10229 2005-03-08 Marek Safar <marek.safar@seznam.cz>
10231 * cs-parser.jay: Removed CS0134.
10233 * driver.cs: Removed CS1901.
10235 * expression.cs (SizeOf.DoResolve): Don't report CS0233
10236 for predefined types.
10238 2005-03-07 Duncan Mak <duncan@novell.com>
10240 * codegen.cs (Save): Catch UnauthorizedAccessException as
10241 well. Fixes bug #73454.
10243 2005-03-07 Marek Safar <marek.safar@seznam.cz>
10245 * cs-tokenizer.cs (xtoken): Add CS1035.
10247 * class.cs (MethodData.Define): Add CS0683.
10248 (FieldMember.ctor): Add CS0681.
10250 2005-03-07 Raja R Harinath <rharinath@novell.com>
10252 * ecore.cs (SimpleName.DoResolve): Rename from
10253 SimpleName.DoResolveAllowStatic.
10254 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
10255 Pass 'intermediate' flag to MemberStaticCheck.
10256 (SimpleName.MemberStaticCheck): Skip "static check" only in case
10257 of "intermediate" lookups via MemberAccess.
10258 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
10259 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
10261 2005-03-07 Raja R Harinath <rharinath@novell.com>
10264 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
10265 slipped in because of variable names that are identical to a
10266 builtin type's BCL equivalent ('string String;', 'int Int32;').
10267 (PropertyExpr.EmitInstance): Likewise.
10269 2005-03-04 Marek Safar <marek.safar@seznam.cz>
10271 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
10273 * report.cs (warning_ignore_table): Made public.
10275 2005-03-04 Raja R Harinath <rharinath@novell.com>
10278 * class.cs (MethodData.Emit): Pass 'container' to
10279 container.GetObsoleteAttribute instead of 'container.Parent'.
10281 2005-03-03 Marek Safar <marek.safar@seznam.cz>
10283 * cs-parser.jay: Add 1534 error test.
10285 * iterators.cs (Yield.CheckContext): Add error 1629.
10286 (Iterator.ctor): Save unsafe modifier.
10287 (MoveNextMethod.DoEmit): Restore unsafe context.
10289 * namespace.cs (UsingAlias): Better error message.
10291 2005-03-03 Dan Winship <danw@novell.com>
10293 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
10294 the warning message [#73219]
10296 2005-03-03 Raja R Harinath <rharinath@novell.com>
10298 Fix compile with MCS 1.0.0.0.
10299 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
10300 w_restore to not depend on string constant folding.
10302 2005-03-03 Raja R Harinath <rharinath@novell.com>
10304 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
10305 CS0246 check to users who passed 'silent = false'.
10306 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
10308 (SimpleName.SimpleNameResolve): Update.
10309 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
10310 (MemberAccess.IdenticalNameAndTypeName): Update.
10311 * doc.cs (FindDocumentedTypeNonArray): Update.
10313 2005-03-03 Raja R Harinath <rharinath@novell.com>
10315 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
10316 * parameters.cs (ComputeAndDefineParameters): Remove.
10317 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
10318 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
10319 Use GetParameterInfo.
10321 2005-03-02 Marek Safar <marek.safar@seznam.cz>
10323 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
10325 2005-03-02 Raja R Harinath <rharinath@novell.com>
10327 Unify DeclSpace.LookupType and DeclSpace.FindType.
10328 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
10329 is in charge of defining nested types on demand.
10330 (DeclSpace.LookupType): Use it when the current_type is a
10331 TypeBuilder. Use LookupTypeDirect for reflected types.
10332 (DeclSpace.FindType): Remove.
10333 (DeclSpace.LookupInterfaceOrClass): Likewise.
10334 (DeclSpace.DefineTypeAndParents): Likewise.
10335 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
10336 DeclSpace.LookupType.
10337 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
10338 * typemanager.cs (LookupType): Simplify.
10339 (AddUserType): Remove type from negative_hits.
10340 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
10341 * class.cs (TypeContainer.FindMembers): Move handling of nested
10343 (TypeContainer.FindMembers_NestedTypes): ... here.
10344 (TypeContainer.FindNestedType): Implement override.
10345 (ClassPart.FindNestedType): Delegate to PartialContainer.
10346 (ClassPart.PartFindNestedType): Looks up the nested types of the
10349 2005-03-02 Martin Baulig <martin@ximian.com>
10351 * class.cs (TypeContainer.DoDefineMembers): We also need a default
10352 static constructor in static classes.
10354 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
10356 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
10357 sizeParamIndex is not specified.
10359 2005-03-01 Marek Safar <marek.safar@seznam.cz>
10362 * report.cs (WarningMessage.IsEnabled): Missing null check.
10364 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10366 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
10367 in the fields and not in the properties.
10369 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
10371 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
10374 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10376 * attribute.cs: Small refactoring (improved robustness).
10377 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
10378 (ValidateGuid): Removed.
10379 (Resolve): Removed referenced to above mentioned.
10380 (GetAttributeUsage): Made private and changed to work without
10382 (GetIndexerAttributeValue): Don't crash.
10383 (GetConditionalAttributeValue): Ditto.
10384 (GetClsCompliantAttributeValue): Ditto.
10385 (ExtractSecurityPermissionSet): All attributes exceptions are
10387 (GetPropertyValue): New helper.
10388 (GetMethodImplOptions): New method.
10389 (DefinePInvokeMethod): Reuse common code. Implemented handling of
10390 some missing properties.
10392 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
10393 (Method.ApplyAttributeBuilder): Updated.
10395 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
10398 2005-02-28 Raja R Harinath <rharinath@novell.com>
10401 * report.cs (Report.SymbolRelatedToPreviousError): Handle
10402 non-simple types (array, pointer, reference).
10404 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10406 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
10408 * class.cs (MethodCore.IsDuplicateImplementation): Special error
10410 (Method.CheckBase): Catch wrong destructor here.
10411 (MethodData.Define): Add errors 550, 668.
10413 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
10415 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
10417 * pending.cs (VerifyPendingMethods): Add error 551.
10419 * typemanager.cs (CSharpName): Next error report helper.
10421 2005-02-25 Marek Safar <marek.safar@seznam.cz>
10423 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
10424 attributes. Removed useless attribute double check.
10425 It saves almost 2MBs for corlib.
10427 2005-02-25 Raja R Harinath <rharinath@novell.com>
10430 * statement.cs (ExpressionStatement.Resolve): Make robust to being
10431 called twice in case of error.
10433 2005-02-23 Chris Toshok <toshok@ximian.com>
10435 Fix compiler portions of #72827.
10436 * statement.cs (Block.Emit): call Begin/EndScope on the
10437 EmitContext instead of the ILGenerator.
10439 * codegen.cs (EmitContext.BeginScope): new method, call
10440 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
10442 (EmitContext.BeginScope): same, but EndScope and CloseScope
10444 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
10445 offset and call the superclass's OpenScope(int) with it.
10446 (SymbolWriter.CloseScope): get the current il
10447 offset and call superclass's CloseScope(int) with it.
10449 2005-02-23 Marek Safar <marek.safar@seznam.cz>
10451 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
10452 CS1677 for out and ref as well.
10454 * class.cs (Method.Define): Add error CS1599 detection.
10456 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
10458 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
10460 * delegate.cs (Delegate.Define): Add error CS1599 detection.
10462 * support.cs.cs (ModifierDesc): New helper method.
10464 2005-02-23 Raja R Harinath <rharinath@novell.com>
10465 Abin Thomas <projectmonokochi@rediffmail.com>
10466 Anoob V E <projectmonokochi@rediffmail.com>
10467 Harilal P R <projectmonokochi@rediffmail.com>
10469 Fix #57851, #72718.
10470 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
10471 MemberLookup (used for error reporting) actually returns a result.
10472 Fix error report number (122, not 112).
10474 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
10475 Anoob V E <projectmonokochi@rediffmail.com>
10476 Harilal P R <projectmonokochi@rediffmail.com>
10479 * pending.cs (PendingImplementation.GetAbstractMethods):
10480 Find NonPublic members too.
10482 2005-02-22 Marek Safar <marek.safar@seznam.cz>
10484 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
10487 * class.cs (MethodCore.CheckMethodAgainstBase):
10488 Add error 239 report.
10490 2005-02-21 Raja R Harinath <rharinath@novell.com>
10493 * expression.cs (Invocation.IsApplicable): Make public.
10494 (Invocation.IsParamsMethodApplicable): Likewise.
10495 * delegate.cs (Delegate.VerifyApplicability): Don't use
10496 Invocation.VerifyArgumentCompat for parameter applicability
10497 testing. Use Invocation.IsApplicable and
10498 Invocation.IsParamsMethodApplicable.
10500 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10502 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
10504 * class.cs (Operator.Define): Add error 217 report.
10506 2005-02-21 Raja R Harinath <rharinath@novell.com>
10508 * namespace.cs (UsingEntry.Resolve): Undo change below.
10510 2005-02-21 Raja R Harinath <rharinath@novell.com>
10513 * ecore.cs (Expression.MemberLookupFailed): Add argument to
10514 disable the error message when the extended MemberLookup also
10516 (Expression.MemberLookupFinal): Update.
10517 (SimpleName.DoSimpleNameResolve): Update.
10518 * expression.cs (MemberAccess.ResolveNamespaceOrType):
10519 Don't use MemberLookupFinal.
10520 (New.DoResolve): Update.
10521 (BaseAccess.CommonResolve): Update.
10523 2005-02-21 Raja R Harinath <rharinath@novell.com>
10526 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
10527 occured previously, don't resolve again.
10529 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10532 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
10533 argument. Call ResolveAttributeUsage for unresolved.
10534 when types doesn't match ctor arguments.
10536 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
10537 for nested attribute classes.
10538 (Class.attribute_usage): Removed.
10539 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
10540 for attribute class.
10542 * ecore.cs (IsAttribute): Removed.
10544 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
10546 * rootcontext.cs (RegisterAttribute): Removed, attributes are
10548 (attribute_types): Removed.
10549 (EmitCode): Global attributes are emited as the latest.
10551 2005-02-18 Marek Safar <marek.safar@seznam.cz>
10553 * class.cs (EmitFieldInitializers): Don't emit field initializer
10554 for default values when optimilization is on.
10556 * constant.cs (Constant.IsDefaultValue): New property.
10558 * driver.cs: Add /optimize handling.
10562 * literal.cs: Implement new IsDefaultValue property.
10564 * rootcontext.cs (Optimize): New field, holds /optimize option.
10566 2005-02-18 Raja R Harinath <rharinath@novell.com>
10568 Fix crasher in re-opened #72347.
10569 * namespace.cs (Namespace.Lookup): Return null if
10570 DeclSpace.DefineType returns null.
10573 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
10575 2005-02-18 Raja R Harinath <rharinath@novell.com>
10577 Fix remainder of #63202. Change semantics of DoResolveLValue: it
10578 now returns null if it cannot resolve to an lvalue.
10579 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
10580 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
10581 returned null. Remove check for SimpleName.
10582 (EventExpr.DoResolveLValue): New.
10583 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
10584 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
10586 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
10587 avoid CS0131 error.
10588 (Unary.ResolveOperator): Move CS0211 check ...
10589 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
10591 (Unary.DoResolveLValue): Simplify.
10592 (AddressOf.DoResolveLValue): New.
10593 (ArrayAccess.DoResolveLValue): New.
10595 2005-02-16 Marek Safar <marek.safar@seznam.cz>
10597 * attribute.cs (Attribute.Resolve): Add arguments casting for
10598 when types doesn't match ctor arguments.
10600 2005-02-16 Raja R Harinath <rharinath@novell.com>
10602 Fix parts of #63202.
10603 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
10604 lookup of operator in base type. Ensure that all checks happen
10605 when the operator resolves to an "op_..." method.
10607 2005-02-15 Raja R Harinath <rharinath@novell.com>
10610 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
10611 'ignore_cs0104' parameter. Pass it to ...
10612 (NamespaceEntry.Lookup): ... this.
10613 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
10614 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
10615 (TypeLookupExpression.DoResolveAsTypeStep): Update.
10616 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
10617 Update. Request that cs0104 errors be ignored.
10618 (ComposedCast.ResolveAsTypeStep): Update.
10620 2005-02-14 Raja R Harinath <rharinath@novell.com>
10623 * expression.cs (Invocation.BetterFunction): Remove support for
10624 comparing virtual functions and their overrides.
10625 (Invocation.IsOverride): New.
10626 (Invocation.OverloadResolve): Don't consider 'override' functions
10627 during candidate selection. Store them in a lookaside list.
10628 If the selected method is a 'virtual' function, use the list to
10629 find any overrides that are closer to the LHS type.
10631 2005-02-14 Marek Safar <marek.safar@seznam.cz>
10633 * expression.cs (New.DoResolve): Add complex core type reduction.
10634 (New.Constantify): Converts complex core type syntax like 'new int ()'
10635 to simple constant.
10637 2005-02-14 Raja R Harinath <rharinath@novell.com>
10639 * decl.cs (EntryType.EntryType): New constructor to create an
10640 updated copy of a cache entry.
10641 (MemberCache.AddMethods): Use it.
10642 (MemberCache.ClearDeclaredOnly): Remove.
10643 (MemberCache.MemberCache): Update.
10645 2005-02-11 Miguel de Icaza <miguel@novell.com>
10647 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
10648 variable. This one is represents the actual low-level declaration
10649 of the method, as opposed to the semantic level `IsStatic'.
10651 An anonymous method which is hosted into a static method might be
10652 actually an instance method. IsStatic would reflect the
10653 container, while MethodIsStatic represents the actual code
10656 * expression.cs (ParameterReference): Use the new MethodIsStatic
10657 instead of IsStatic.
10659 * anonymous.cs (AnonymousMethod.Compatible): Pass the
10660 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
10661 set on the current EmitContext.
10663 * expression.cs (Cast): Overload DoResolveLValue so we can pass
10664 resolve our casted expression as an LValue. This triggers the
10665 proper LValue processing that is later required by Assign.
10669 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
10671 2005-02-11 Marek Safar <marek.safar@seznam.cz>
10673 C# 2.0 Fixed buffer implementation
10675 * anonymous.cs: Update after RegisterHelperClass renaming.
10677 * attribute.cs (AttributeTester.fixed_buffer_cache):
10678 Cache of external fixed buffers.
10679 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
10680 implementation if field is fixed buffer else null.
10683 (TypeContainer.AddField): Accept FieldMember instead of Field.
10684 (FieldBase.IsFieldClsCompliant): Extracted code from
10685 VerifyClsCompliance descendant customization.
10686 (FixedField): New class handles fixed buffer fields.
10687 (FixedFieldExternal): Keeps information about imported fixed
10689 (IFixedField): Make access to internal or external fixed buffer
10692 * cs-parser.jay: Add fixed buffer parsing.
10694 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
10697 * expression.cs (Indirection): Extended implementation to accept
10698 fixed buffer field.
10699 (PointerArithmetic.Emit): Get element from fixed buffer as well.
10700 (ElementAccess.MakePointerAccess): Get type as parameter.
10701 (DoResolve): Add fixed buffer field expression conversion.
10702 (DoResolveLValue): Ditto.
10703 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
10704 (ArrayPtr): Derives from FixedBufferPtr.
10705 (ArrayPtr.Emit): Add extra emit for array elements.
10707 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
10709 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
10710 for compiler generated types.
10711 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
10713 * statement.cs (Fixed): Refactored to be easier add fixed buffer
10714 and consume less memory.
10715 (Fixed.Resolve): Add fixed buffer case.
10717 * typemanager.cs (compiler_generated_attr_ctor,
10718 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
10719 (HasElementType): Add our own implementation to work on every
10722 2005-02-11 Miguel de Icaza <miguel@novell.com>
10724 * anonymous.cs (CaptureContext): Track whether `this' has been
10727 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
10728 only captured `this' if it was implicitly done (instance
10729 methods/variables were used).
10731 * codegen.cs (EmitContext.CaptureThis): New method to flag that
10732 `this' must be captured.
10734 2005-01-30 Miguel de Icaza <miguel@novell.com>
10736 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
10737 is null it means that there has been no need to capture anything,
10738 so we just create a sibling.
10740 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
10742 Just a partial fix. The other half is fairly elusive.
10744 2005-02-10 Raja R Harinath <rharinath@novell.com>
10746 Fix #52586, cs0121-4.cs.
10747 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
10748 and return a hashtable.
10749 (MemberCache.ClearDeclaredOnly): New.
10750 (MemberCache.MemberCache): Update to change. Make a deep copy of
10751 the method_hash of a base type too.
10752 (MemberCache.AddMethods): Adapt to having a deep copy of the base
10753 type methods. Overwrite entries with the same MethodHandle so
10754 that the ReflectedType is correct. The process leaves in base
10755 virtual functions and their overrides as distinct entries.
10756 (CacheEntry): Now a class instead of a struct. It shouldn't alter
10757 matters since it was boxed in a ArrayList before.
10758 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
10760 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
10761 case of a virtual function and its override (choose the overload
10763 (Invocation.OverloadResolve): Avoid 'override' members during
10764 'applicable_type' calculation.
10766 2005-02-09 Raja R Harinath <rharinath@novell.com>
10768 Combine two near-redundant caches.
10769 * typemanager.cs (method_params): Rename from method_internal_params.
10770 (TypeManager.GetParameterData): New. Replace
10771 Invocation.GetParameterData.
10772 (TypeManager.LookupParametersByBuilder): Remove.
10773 * expression.cs (Invocation.method_parameter_cache): Remove.
10774 (Invocation.GetParameterData): Remove.
10776 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
10779 2005-02-08 Raja R Harinath <rharinath@novell.com>
10782 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
10783 TypeManager.multicast_delegate_type is null, resolve it by looking
10784 up "System.MulticastDelegate".
10785 * rootcontext.cs (RootContext.ResolveCore): Simplify.
10787 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
10788 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
10789 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
10792 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
10793 (LabeledStatement.AddReference): New. Set 'referenced'.
10794 (Goto.Resolve): Use it.
10796 2005-02-05 John Luke <john.luke@gmail.com>
10798 * driver.cs: remove duplicate -doc line in Usage ()
10800 2005-02-04 Raja R Harinath <rharinath@novell.com>
10802 * location.cs (Location.AddFile): Fix CS2002 error report.
10804 2005-02-02 Martin Baulig <martin@ximian.com>
10806 * delegate.cs (Delegate.DefineType): Report an internal error if
10807 TypeManager.multicast_delegate_type is null. See bug #72015 for
10810 2005-02-02 Raja R Harinath <rharinath@novell.com>
10812 Fix a crasher in a variant of #31984.
10813 * const.cs (Constant.CheckBase): New override that defers the
10814 new-or-override check in case the base type hasn't been populated
10816 (Constant.Define): Ensure the new-or-override check is performed.
10818 2005-02-01 Duncan Mak <duncan@ximian.com>
10820 * const.cs (LookupConstantValue): Check that `ce' is not null
10821 before calling GetValue ().
10823 2005-02-01 Raja R Harinath <rharinath@novell.com>
10825 Fix test-334.cs (#69519).
10826 * cs-parser.jay (using_alias_directive): Pass in an expression to
10827 NamespaceEntry.UsingAlias.
10828 (using_namespace_directive): Pass in an expression to
10829 NamespaceEntry.Using.
10830 (namespace_name): Don't flatten to a string.
10831 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
10832 (NamespaceEntry.AliasEntry.Resolve): Lookup using
10834 (NamespaceEntry.UsingEntry): Likewise.
10835 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
10837 (NamespaceEntry.LookupForUsing): Remove.
10838 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
10840 (NamespaceEntry.Lookup): Remove support for dotted names.
10842 2005-02-01 Raja R Harinath <rharinath@novell.com>
10844 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
10846 (NamespaceEntry.ImplicitParent): Compute on demand.
10847 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
10848 parallels the current.
10849 (NamespaceEntry.LookupForUsing): Use it.
10850 (NamespaceEntry.Lookup): If the current namespace-entry is
10851 implicit, don't search aliases and using tables.
10853 2005-02-01 Raja R Harinath <rharinath@novell.com>
10856 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
10858 (TypeContainer.BaseCache): Compute on demand.
10859 (TypeContainer.FindMembers): Define constants and types if they're
10860 not already created.
10861 (FieldMember.Define): Move resetting of ec.InUnsafe before error
10863 * const.cs (Constant.Define): Make idempotent.
10865 2005-01-29 Miguel de Icaza <miguel@novell.com>
10867 * pending.cs: Produce better code (no nops produced by using Ldarg
10870 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
10871 i - 1' it should be arg + 1.
10875 2005-01-28 Raja R Harinath <rharinath@novell.com>
10877 * attribute.cs (Attribute.CheckAttributeType): Make private
10879 (Attribute.ResolveType): Make virtual.
10880 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
10881 handling of RootContext.Tree.Types.
10883 2005-01-27 Raja R Harinath <rharinath@novell.com>
10885 Update attribute-handling to use the SimpleName/MemberAccess
10887 * cs-parser.jay (attribute): Pass in an expression to the
10888 constructors of Attribute and GlobalAttribute.
10889 * attribute.cs (Attribute): Take an expression for the name.
10890 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
10891 passed in attribute name expression.
10892 (Attribute.CheckAttributeType): Use it.
10893 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
10894 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
10895 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
10896 argument to prevent error messages if the lookup fails.
10898 2005-01-27 Marek Safar <marek.safar@seznam.cz>
10900 * expression.cs (Indirection): Implemented IVariable interface
10901 to support indirection in AddressOf operator.
10902 (PointerArithmetic.Emit): Add optimalization for case where
10903 result can be precomputed.
10905 2005-01-26 Martin Baulig <martin@ximian.com>
10907 * class.cs (TypeContainer.AttributeTargets): Return the correct
10908 AttributeTargets depending on our `Kind' instead of throwing an
10909 exception; fixes #71632.
10911 2005-01-26 Marek Safar <marek.safar@seznam.cz>
10914 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
10917 2005-01-25 Raja R Harinath <rharinath@novell.com>
10920 * expression.cs (MemberAccess.DoResolve): Don't complain with
10921 cs0572 when the LHS of a member access has identical name and type
10924 2005-01-25 Marek Safar <marek.safar@seznam.cz>
10927 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
10929 Create custom PermissionSet only for PermissionSetAttribute.
10931 2005-01-24 Marek Safar <marek.safar@seznam.cz>
10934 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
10935 delegates in static class.
10937 2005-01-24 Martin Baulig <martin@ximian.com>
10939 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10940 merging an implicit block, just use its reachability.
10942 * statement.cs (Block.Resolve): Make the unreachable code check
10943 work wrt. implicit blocks; see test-337 from #63842.
10945 2005-01-21 Alp Toker <alp@atoker.com>
10947 * cs-parser.jay: destructor_declaration's container is PartialContainer
10948 not Class when partial types are used, so use Kind prop instead of
10951 2005-01-22 Miguel de Icaza <miguel@ximian.com>
10953 * cs-parser.jay: Improve error reporting when an interface
10954 declares new types.
10956 2005-01-20 Dick Porter <dick@ximian.com>
10958 * support.cs: SeekableStreamReader fix from Sandor Dobos
10959 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
10960 chars are read. Fixes bug 70369.
10962 2005-01-20 Raja R Harinath <rharinath@novell.com>
10964 * cs-parser.jay (catch_clause): Simplify current_block handling
10967 2005-01-17 Miguel de Icaza <miguel@ximian.com>
10969 * convert.cs (ImplicitStandardConversionExists): Synchronize the
10970 code with ImplicitStandardConversion to handle the implicit
10971 conversion of method groups into valid delegate invocations.
10973 The problem is that in parameter handling we were using this code
10974 path. Fixes bug #64698
10976 2005-01-19 Raja R Harinath <rharinath@novell.com>
10978 * cs-parser.jay: Fix several infelicities.
10979 - Avoid assigning to the parser value stack. Code like
10980 '$3 = null' is unclean. Synthesize a value for the code block
10982 - Avoid using oob_stack for storing location information. Use ...
10983 (_mark_): ... this. New (empty) rule. Saves the current location
10985 (foreach_statement): Avoid using oob_stack for current_block
10986 handling. Use technique used in for_statement and
10987 using_statement. Synthesize a value for the code block to store
10988 additional intermediate information.
10990 2005-01-13 Miguel de Icaza <miguel@ximian.com>
10992 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
10993 of a different type is only allowed to private fields of a
10994 containing type, not on fields of a base class.
10996 See test-174.cs and error cs0122-9.cs
10998 2005-01-13 Raja R Harinath <rharinath@novell.com>
11000 Fix test-335.cs (bug #58126).
11001 * cs-parser.jay (argument): Split out non-expression parts of the
11002 rule into 'non_simple_argument'.
11003 (invocation_expression): Support parenthesized invocations with
11004 multiple arguments, and with single non-simple arguments.
11006 2005-01-13 Raja R Harinath <rharinath@novell.com>
11008 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
11011 2005-01-12 Raja R Harinath <rharinath@novell.com>
11013 Fix cs0038-1.cs, cs1640-6.cs.
11014 * ecore.cs (Expression.Resolve): Remove special-case for
11015 SimpleName in error-handling.
11016 (Expression.almostMatchedMembers): Relax access permission to
11018 (Expression.MemberLookupFailed): Handle duplicates in
11019 almostMatchedMembers list.
11020 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
11021 * expression.cs (New.DoResolve): Report CS1540 for more cases.
11022 * typemanager.cs (GetFullNameSignature): Use the MethodBase
11023 overload if the passed in MemberInfo is a MethodBase.
11025 2005-01-12 Marek Safar <marek.safar@seznam.cz>
11028 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
11029 for non-CAS & merge permission sets properly.
11031 2005-01-11 Raja R Harinath <rharinath@novell.com>
11033 Improve standard-compliance of simple name and member access
11034 resolution. Fixes bugs #52697, #57200, #67520, #69519.
11035 * ecore.cs (FullNamedExpression): New abstract base class
11036 for Namespaces and TypeExpressions.
11037 (ResolveFlags.SimpleName): Remove.
11038 (SimpleName): Remove support for dotted names.
11039 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
11040 DeclSpace.FindType and DeclSpace.LookupType.
11041 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
11042 (Expression.ExprClassName): Make member function.
11043 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
11044 a namespace. Remove creation of dotted "SimpleName"s.
11045 (MemberAccess.DoResolve): Likewise.
11046 * decl.cs (DeclSpace.Cache): Make private.
11047 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
11048 (DeclSpace.FindType): Update.
11049 (DeclSpace.LookupType): Move here from RootContext. Return a
11050 FullNamedExpression.
11051 * namespace.cs (Namespace): Derive from FullNamedExpression
11052 so that it can be part of expression resolution.
11053 (Namespace.Lookup): Return an FullNamedExpression.
11054 (NamespaceEntry.LookupAlias): Lookup aliases only in current
11056 * rootcontext.cs (NamespaceLookup): Remove.
11057 (LookupType): Move to DeclSpace.
11058 * attribute.cs (CheckAttributeType): Update.
11059 * doc.cs (FindDocumentedType): Remove allowAlias argument.
11060 (FindDocumentedTypeNonArray): Likewise.
11062 2005-01-11 Raja R Harinath <rharinath@novell.com>
11064 Fix cs0509.cs, cs1632.cs.
11065 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
11066 is the same as IsInterface.
11067 (TypeContainer.GetClassBases): Likewise.
11068 * statement.cs (LabeledStatement.ig): New field.
11069 (LabeledStatement.LabelTarget): Save ILGenerator which created the
11071 (LabeledStatement.DoEmit): Check that the label was created with
11072 the same ILGenerator.
11074 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11077 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
11078 accessors to its properties.
11080 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
11081 from accessors to property.
11083 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11086 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
11087 only for overrides.
11089 2005-01-08 Miguel de Icaza <miguel@ximian.com>
11091 * attribute.cs: Check for null and empty strings.
11093 I have lost another battle to Paolo.
11095 2005-01-07 Marek Safar <marek.safar@seznam.cz>
11098 * class.cs (PropertyMethod): Set Parent field in ctors.
11099 (SetMethod.InternalParameters): Add unsafe switch hack.
11100 Override MarkForDuplicationCheck where it is appropriate.
11102 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
11103 It says whether container allows members with the same name.
11104 Base default is no.
11105 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
11106 Removed is_method parameter.
11108 2005-01-06 Duncan Mak <duncan@ximian.com>
11110 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
11111 because the previous change led to incorrect reporting of CS1032
11112 ("Cannot define/undefine preprocessor symbols after first token in
11113 file"). Instead of using `tokens_seen' as the only flag that
11114 triggers CS1040, introduce `comments_seen'. This new flag is used
11115 to signify having seen comments on the current line, so it is
11116 unset after a newline.
11118 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11120 * doc.cs : When searching for a type, find nested type too.
11121 This fixes bug #71040.
11123 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11126 - Warn missing member comment on those classes which also does not
11127 have doc comments. Fixed bug #71041.
11128 - Don't warn missing doc comment on default constructor.
11131 2005-01-06 Duncan Mak <duncan@ximian.com>
11133 * cs-tokenizer.cs (xtoken): After handling traditional C-style
11134 comments, set `tokens_seen' to true. This allows us to detect
11135 misplaced preprocessor directives (i.e. not at the beginning of
11136 the a line, nor after whitespaces). In that case, report error
11137 CS1040. This fixes bug #56460.
11139 * cs-parser.jay (interface_member_declaration): Add checks for
11140 IsExplicitImpl, and report CS0541 error if an interface member is
11141 defined as an explicit interface declaration.
11143 2005-01-06 Marek Safar <marek.safar@seznam.cz>
11146 * class.cs (PropertyMethod): Set Parent field in ctors.
11147 (SetMethod.InternalParameters): Add unsafe switch hack.
11149 * decl.cs (MemberCore.Parent): Cannot be readonly.
11151 2005-01-06 Raja R Harinath <rharinath@novell.com>
11153 * decl.cs (DeclSpace.ResolveType): Remove.
11154 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
11155 Merge in code from ...
11156 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
11157 * class.cs, enum.cs: Update to changes.
11159 2005-01-06 Miguel de Icaza <miguel@ximian.com>
11161 * anonymous.cs: Ensure that we init the scope of our parent if it
11162 has not been initialized yet.
11164 2004-12-30 Duncan Mak <duncan@ximian.com>
11166 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
11167 if field.FieldBuilder is null. Fixes #70758.
11169 * convert.cs: Fixed some typos and updated some of the comments.
11170 (ImplicitStandardConversionExists):
11171 (TryImplicitIntConversion): If `target_type' is an interface and
11172 the type of `ic' implements this interface, return true or a new
11173 BoxedCast instead of null. This fixes #70468.
11175 2004-12-29 Duncan Mak <duncan@ximian.com>
11177 * expression.cs (Argument.Emit): Check that Expr is
11178 IMemoryLocation before casting to it, and report CS1510 otherwise.
11182 2004-12-21 Ben Maurer <bmaurer@ximian.com>
11184 * statement.cs (Block.ThisVariable): remove the recursion here, to
11185 make the --profile more sane.
11187 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
11189 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
11190 assembly, by JB Evain.
11192 2004-12-17 Raja R Harinath <rharinath@novell.com>
11194 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
11195 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
11196 "parent" refers to enclosing type/class. "base" refers to superclass.
11198 2004-12-17 Raja R Harinath <rharinath@novell.com>
11200 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11201 Ensure that we only have GlobalAttributes.
11202 * attribute.cs (Attribute.Emit): Make non-virtual.
11203 (GlobalAttribute.Emit): Remove.
11204 (Attribute.Resolve): Make virtual.
11205 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
11206 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
11207 the argument. Don't create one.
11208 (Attribute.GetObsoleteAttribute): Likewise.
11209 (Attribute.GetClsCompliantAttributeValue): Likewise.
11210 * class.cs, decl.cs: Update to changes.
11212 2004-12-17 Marek Safar <marek.safar@seznam.cz>
11214 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
11216 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
11218 * statement.cs (Foreach.Resolve): Add error 186 report.
11220 2004-12-16 Marek Safar <marek.safar@seznam.cz>
11222 * expression.cs (Conditional.DoResolve): Add warning 429.
11224 * statement.cs (If.Resolve): Add warning 665.
11226 2004-12-16 Raja R Harinath <rharinath@novell.com>
11228 New invariant: RootContext.Tree.Types.NamespaceEntry == null
11229 except when in the parser, and in GlobalAttribute.
11230 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
11231 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
11232 RootContext.Tree.Types.NamespaceEntry once work is done.
11233 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
11234 and resets RootContext.Tree.Types.NamespaceEntry.
11236 2004-12-15 Marek Safar <marek.safar@seznam.cz>
11238 * cs-parser.jay: Don't create a block for every variable.
11240 2004-12-14 Miguel de Icaza <miguel@ximian.com>
11242 * location.cs: Provide extra information.
11244 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
11245 variables from the captured environment, it is the ldarg_0.
11247 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11249 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
11252 * class.cs: Changed warning level for 169 to avoid developer
11253 displeasure from warning flooding. It will be changed back when they
11254 fix most of current BCL warnings.
11256 * RootContext.cs: Pushed default WarningLevel to 3.
11258 * statement.cs: Removed unused variable.
11260 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11262 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
11263 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
11264 Add error 502 report.
11265 (StaticClass.DefineType): Add error 441 report.
11266 (Class.AllowedModifiersProp): New virtual property as temporary
11267 extension to AllowedModifiers.
11268 (Class.DefineType): Add error 418 report. Moved ModFlags check here
11269 to share implementation with StaticClass and don't call virtual
11272 * driver.cs (MainDriver): Add error 1558 test.
11274 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
11275 report. Moved error 36 test here.
11277 * statement.cs (Throw.Resolve): Add error 724 report.
11279 * typemanager.cs: Add out_attribute_type core type.
11281 2004-12-13 Marek Safar <marek.safar@seznam.cz>
11283 * class.cs (TypeContainer.VerifyClsCompliance): Add error
11285 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
11287 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
11290 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
11292 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
11293 Add error 3023 report.
11294 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
11296 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
11299 2004-12-12 John Luke <john.luke@gmail.com>
11301 * driver.cs (AddArgs): take -- into account when
11302 adding arguments, fixes bug 65710
11304 2004-12-12 Martin Baulig <martin@ximian.com>
11306 * expression.cs (Unary.TryReduceNegative): Added support for
11307 SByteConstant and ByteConstant.
11308 (Unary.Reduce): Check error values from TryReduceNegative().
11310 2004-12-10 Marek Safar <marek.safar@seznam.cz>
11312 * attributes.cs (Attribute.Resolve): Avoid multiple error report
11313 and report exception as error 182.
11315 2004-12-10 Raja R Harinath <rharinath@novell.com>
11317 * driver.cs (Main): Fix message when there are warnings.
11319 2004-12-09 Miguel de Icaza <miguel@ximian.com>
11321 * delegate.cs: Fixed my fix from yesterday, sorry about that.
11323 2004-12-09 Marek Safar <marek.safar@seznam.cz>
11325 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
11326 Reduced number of warnings.
11328 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
11330 2004-12-08 Miguel de Icaza <miguel@ximian.com>
11332 * driver.cs: Removed message.
11334 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
11336 2004-12-08 <vargaz@freemail.hu>
11338 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
11340 2004-12-08 Martin Baulig <martin@ximian.com>
11342 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
11343 instead of a CS3002 for properties and indexer.
11345 2004-12-08 Martin Baulig <martin@ximian.com>
11347 * decl.cs (MemberName.ToString): Make this work again.
11349 2004-12-08 Marek Safar <marek.safar@seznam.cz>
11351 * attribute.cs (Resolve): Add error 591 detection.
11353 * class.cs (FieldMember.Define): Add error 1547 detection.
11354 (Indexer.Define): Add error 620 detection.
11355 (Operator.Define): Add error 590 detection.
11357 * ecore.cs: Missing argument for error 79.
11359 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
11362 2004-12-07 Marek Safar <marek.safar@seznam.cz>
11365 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
11368 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
11370 * cs-parser.jay : handle doc comments on implicit/explicit operators.
11371 Some operator comments were suppressed.
11372 * doc.cs : Implicit/explicit operator name in doc comments are like
11373 "op_Explicit(type)~returnType", so added suffix handling.
11375 2004-12-07 Martin Baulig <martin@ximian.com>
11378 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
11379 (MemberCore.GetClsCompliantAttributeValue): Likewise.
11380 (DeclSpace.ec): New protected field; store the EmitContext here.
11381 (DeclSpace.EmitContext): New public property; moved here from
11383 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
11386 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
11387 (Enum.Emit): Don't create a new EmitContext.
11389 * delegate.cs (Delegate.DefineType): Always create the
11392 * iterators.cs (Iterators.DefineIterator): Create a new
11393 EmitContext and store it in `ec'.
11395 2004-08-24 Martin Baulig <martin@ximian.com>
11398 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
11399 this for accessibility checks.
11400 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
11401 IsNestedFamilyAccessible.
11402 (TypeManager.IsSubclassOf): New method, do what the name actually
11405 2004-12-06 Raja R Harinath <rharinath@novell.com>
11407 Fix crash on cs0657-17.cs.
11408 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11409 Use RootContext.Tree.Types, not 'new RootTypes ()'.
11410 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
11411 the case where the NamespaceEntry gets overwritten.
11413 2004-12-06 Marek Safar <marek.safar@seznam.cz>
11415 Fixed #69195, #56821
11416 * ecore.cs (ResolveBoolean): Tiny refactoring.
11418 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
11419 of right expression resolving when left is false constant and
11420 operator is LogicalAnd OR true constant and operator is LogicalOr.
11422 * statement.cs (ResolveUnreachable): Always reports warning.
11424 2004-12-05 Miguel de Icaza <miguel@ximian.com>
11426 * class.cs: Distinguish between 1721 and 1722 (just a little help
11427 for the programmer).
11429 2004-12-03 Miguel de Icaza <miguel@ximian.com>
11431 * delegate.cs: Only allow this on new versions of the language.
11433 2004-12-02 Duncan Mak <duncan@ximian.com>
11435 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
11437 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
11438 here as a static method. Take an additional bool out parameter
11439 `must_do_cs1540_check' for signaling to InstanceResolve.
11440 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
11441 member field from PropertyExpr class and made it an argument of
11442 the method instead.
11443 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
11444 check for MarshalByRefObject, and report CS0122 instead of CS1540.
11445 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
11446 and `remove_accessor' as well as InstanceResolve: report CS0122
11451 2004-12-03 Raja R Harinath <rharinath@novell.com>
11453 Fix test-327.cs, test-328.cs, and put in early infrastructure
11454 for eventually fixing #52697.
11455 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
11456 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
11457 from other methods.
11458 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
11459 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
11460 (VerifyUsing, error246): Update.
11461 * rootcontext.cs (RootContext.NamespaceLookup): Just use
11462 'NamespaceEntry.LookupNamespaceOrType'.
11464 2004-12-03 Martin Baulig <martin@ximian.com>
11466 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11467 method as our child, call AnonymousMethod.Compatible() on it.
11469 2004-12-03 Raja R Harinath <rharinath@novell.com>
11471 Disable XML documentation support in 'basic' profile.
11472 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
11473 Redirect XmlElement to System.Object.
11474 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
11475 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
11476 * mcs.exe.sources: Add doc-bootstrap.cs.
11477 * doc-bootstrap.cs: New file. Contains empty stub implementation
11480 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
11482 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
11483 comments are allowed.
11485 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11487 * delegate.cs: Add checks for subtypes in paramaters and return values
11488 in VerifyMethod () to add support for Covariance/Contravariance
11491 2004-12-02 Miguel de Icaza <miguel@ximian.com>
11493 * report.cs: Remove extra closing parenthesis.
11495 * convert.cs (Error_CannotImplicitConversion): If the name of the
11496 types are the same, provide some extra information.
11498 * class.cs (FieldBase): Use an unused bit field from the field to
11499 encode the `has_offset' property from the FieldMember. This saves
11500 a couple of Ks on bootstrap compilation.
11502 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11503 method as our child, return the AnonymousMethod resolved
11506 * expression.cs (New.DoResolve): Allow return values from
11507 NewDelegate to also include AnonymousMethods.
11511 2004-12-02 Marek Safar <marek.safar@seznam.cz>
11514 * attribute.cs (Resolve): Improved implementation of params
11515 attribute arguments.
11517 * support.cs (ParameterData): Add HasParams to be faster.
11519 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
11521 all things are for /doc support:
11523 * doc.cs: new file that supports XML documentation generation.
11524 * mcs.exe.sources: added doc.cs.
11526 Handle /doc command line option.
11527 Report error 2006 instead of 5 for missing file name for /doc.
11528 Generate XML documentation when required, after type resolution.
11530 Added support for picking up documentation (/// and /** ... */),
11531 including a new XmlCommentState enumeration.
11533 Added lines to fill Documentation element for field, constant,
11534 property, indexer, method, constructor, destructor, operator, event
11535 and class, struct, interface, delegate, enum.
11536 Added lines to warn incorrect comment.
11538 Added Documentation field (passed only when /doc was specified).
11540 Added DocComment, DocCommentHeader, GenerateDocComment() and
11541 OnGenerateDocComment() and some supporting private members for
11542 /doc feature to MemberCore.
11544 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
11546 Added overriden DocCommentHeader.
11548 Added overriden DocCommentHeader and GenerateDocComment().
11550 2004-12-01 Miguel de Icaza <miguel@ximian.com>
11552 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
11553 unwrapping the enumeration values, chain to
11554 DoConstantNumericPromotions again, so we can promote things to the
11555 fundamental types (takes care of enums that are bytes, sbytes).
11559 2004-12-01 Raja R Harinath <rharinath@novell.com>
11561 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
11562 Fix long-standing bug in type-lookup. Use FindType instead of
11563 LookupType when ec.ResolvingTypeTree.
11564 (Attribute.ResolveType, Attribute.Resolve)
11565 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
11567 (Attributes.Search): Remove internal version. Update.
11568 (Attributes.SearchMulti): Update.
11569 (Attributes.GetClsCompliantAttribute): Remove.
11570 (Attributes.GetIndexerNameAttribute): Remove.
11571 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
11572 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
11573 * class.cs (Indexer.Define): Likewise.
11575 2004-12-01 Marek Safar <marek.safar@seznam.cz>
11578 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
11579 MarshallByReference members access.
11581 * expression.cs: Use CheckMarshallByRefAccess;
11582 Better error CS0197 message.
11584 * report.cs: Print whole related error message.
11586 2004-11-30 Raja R Harinath <rharinath@novell.com>
11588 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
11589 the current directory to help debugging.
11591 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11593 * class (GetClassBases): Better error 60 report.
11594 (EventProperty): Disabled warning 67 detection.
11596 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11599 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
11601 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
11604 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11607 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
11609 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
11611 2004-11-26 Miguel de Icaza <miguel@ximian.com>
11613 * attribute.cs (Attribute.Resolve): Refine error reporting and
11614 report a cs0117 if the identifier does not exist, to distinguish
11615 from 0617 which is a miss-use of the actual identifier.
11617 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
11618 between cs0070 and cs0079.
11620 * class.cs (MemberBase.DoDefine): When reporting a wrong
11621 accessibility level, we use MethodCore to compare instead of
11622 Method (this was a regression in some refactoring effort).
11624 So now we correctly report cs0056 again.
11626 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
11627 testing the target_type (which was known to be object_type) and
11628 not the source type (which is anonymous_method).
11630 Fixed reporting of error cs1660.
11632 * expression.cs (UserCast.Source): Expose the underlying cast.
11634 * statement.cs (Switch.SwitchGoverningType): Sort the list of
11635 allowed types to find a match to int32 first (most common).
11637 In addition, it ignores any ImplicitUserConversions that did an
11638 internal implicit conversion (as the switch statement allows only
11639 one integral conversion to exist).
11641 * class.cs (PartialContainer.Create): rename `name' to
11642 `member_name' for clarity. Then replace the string calls with a
11643 call to MemberName.GetPartialName, as now using
11644 MemberName.ToString is an error (this is due to the side effects
11645 it had, that were fixed in the past).
11647 This will restore the error reporting on a number of partial class
11648 errors that were missusing this (and getting an exception as a
11649 results, which is now just a plain textual warning, because
11650 yyparse debug output would crash otherwise).
11652 2004-11-26 Raja R Harinath <rharinath@novell.com>
11654 * Makefile (PROGRAM_INSTALL_DIR): Remove.
11656 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11658 * rootcontext.cs (LookupType): Make sure to cache lookups that
11659 don't give us a negative result. This saves about 5% of corlib
11662 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11664 * report.cs (AbstractMessage.Print): messages are sent to stderr
11666 * class.cs (TypeContainer.GetClassBases): It is an error to have a
11667 non-interface in the list of interfaces (at this point, either
11668 parent was properly set, or a base class is being listed in the
11669 interfaces section).
11671 This flags error 1722, and resolves the crash from bug 69259.
11673 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11675 * statement.cs (Using.EmitExpressionFinally): make this work right
11676 for valuetypes. Fixes 69926.
11678 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11680 * const.cs (Const.ChangeType): Cope with the "0 literal can be
11681 converted to an enum" here, before we try to change the underlying
11682 type. This code exists, but it is a different code path than the
11683 one used while encoding constants.
11685 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
11686 old bug: when converting from the null literal to a pointer,
11687 return an EmptyCast, not the NullLiteral.
11689 This fixes #69921, the recent null_type changes probably made this
11690 bug more prominent.
11692 (ImplicitReferenceConversionExists): In addition, resynchronized
11693 the code here, so it matches the same code in
11694 ImplicitReferenceConversionExists for the `from any class-type S
11695 to any interface-type T'.
11698 2004-11-25 Marek Safar <marek.safar@seznam.cz>
11700 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
11702 2004-11-24 Miguel de Icaza <miguel@ximian.com>
11704 * cs-parser.jay: Use verbosity accordingly.
11706 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11708 * expression.cs (Unary.ResolveOperator): Do not report warning;
11709 AddressOf reads from variable.
11711 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
11713 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11717 * attribute.cs (Attributable): Removed CheckTargets.
11718 (Attributes.Emit): Explicit attribute targets are tested here.
11720 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
11721 not enabled for interfaces.
11723 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
11724 (GetAssemblyName): Ouch next bug there.
11726 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11728 * expression.cs: Error 275 added.
11730 2004-11-23 Marek Safar <marek.safar@seznam.cz>
11732 Fix bug #69177 (Implemented decimal constant support)
11734 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
11735 (BinaryFold): Add DecimalConstant.
11737 * const.cs (Define): Decimal constant
11739 (ChangeType): Add decimal type handling.
11740 (LookupConstantValue): Don't set value for decimal type but
11741 emit DecimalConstantAttribute. Needed for constant optimization.
11743 * constant.cs (ToDecimal): New method.
11744 (ConvertToDecimal): New method.
11745 (IntConstant): Implemented ConvertToDecimal.
11746 (DecimalConstant.Emit): Emit optimized version for decimals in
11749 * expression.cs (ResolveOperator): Changed order of constant
11750 reduction to work correctly with native types which have
11751 overloaded operators.
11752 (ResolveMemberAccess): Extract constant value from attribute
11755 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
11757 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
11758 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
11759 (ChangeType): Decimal is special.
11760 (TypeToCoreType): Add decimal type.
11762 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11764 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
11767 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11769 * class.cs (EventField.ApplyAttributeBuilder): Fix error
11772 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11774 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
11776 * pending.cs (PendingImplementation): Grab only interfaces.
11778 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11780 * statement.cs (ForeachHelperMethods): Add location member and
11781 error 202 detection.
11783 2004-11-19 Raja R Harinath <rharinath@novell.com>
11785 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
11786 automatically handled by executable.make.
11787 (PROGRAM): Make profile-specific.
11789 2004-11-18 Marek Safar <marek.safar@seznam.cz>
11791 * expression.cs (DoResolveBase): Fixed wrong warning for out
11794 2004-11-18 Martin Baulig <martin@ximian.com>
11796 Merged latest changes into gmcs. Please keep this comment in
11797 here, it makes it easier for me to see what changed in MCS since
11798 the last time I merged.
11800 2004-11-17 Raja R Harinath <rharinath@novell.com>
11802 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
11803 (TypeHandle.GetMemberCache): New.
11804 (TypeHandle.TypeHandle): Update.
11805 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
11806 (TypeManager.LookupParentInterfacesCache):
11807 Rename from LookupInterfaceCache. Optimize slightly.
11808 (TypeManager.MemberLookup_FindMembers): Update.
11809 * decl.cs (MemberCache.MemberCache): Set Container to null in the
11810 multi-type variant.
11811 (AddCacheContents): Rename from AddHashtable.
11812 * class.cs (TypeContainer.parent_container): Remove.
11813 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
11814 (TypeContainer.DoDefineMembers): Don't initialize it.
11815 Update to name changes.
11817 2004-11-17 Miguel de Icaza <miguel@ximian.com>
11819 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
11820 that factors the code to check access modifiers on override.
11822 (PropertyBase): Use the code here.
11824 Patch from Lluis S'anchez, fixes bug #69361.
11826 2004-11-15 Miguel de Icaza <miguel@ximian.com>
11828 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
11829 routine that is used to report the use of a captured variable
11830 whose address has been taken.
11832 There are two checks: one when variables are being captured and
11833 the other check is when the address of a variable is taken.
11835 (because an anonymous methods might be resolved before *or* after
11836 the address has been taken) and
11838 * expression.cs (Conditional.DoResolve): Remove the special
11839 casing that Martin added to trueExpr and falseExpr being both
11840 NullLiteral. We get the right behavior now just by introducing
11841 the null_type into the compiler.
11843 * convert.cs (ExplicitConversion): Change the code to use
11844 null_type instead of testing `expr is NullLiteral'.
11845 (ImplicitConversionStandard): use null_type too.
11846 (ImplicitReferenceConversionExists): use null_type too.
11847 (ImplicitReferenceConversion): use null_type too.
11849 * literal.cs: The type of `NullLiteral' is now null_type instead
11851 (Resolve): Set the type here.
11853 * typemanager.cs: Introduce null_type.
11855 2004-11-17 Martin Baulig <martin@ximian.com>
11857 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
11858 direction, like FindMembers() does. Fixes #69546, testcase is in
11861 2004-11-16 Martin Baulig <martin@ximian.com>
11863 This is based on a patch from Marek Safar, see bug #69082.
11864 Fixes bugs #63705 and #67130.
11866 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
11867 method; create a MemberCache for an interface type and cache the
11870 * decl.cs (IMemberContainer.ParentContainer): Removed.
11871 (IMemberContainer.ParentCache): New property.
11872 (MemberCache.SetupCacheForInterface): Removed.
11873 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
11874 to create a cache for an interface's "parent".
11876 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
11879 2004-11-16 Martin Baulig <martin@ximian.com>
11881 Merged back from gmcs; these changes already went into gmcs a
11882 couple of weeks ago.
11885 (TypeManager.AddUserType): Removed the `ifaces' argument.
11886 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
11888 (TypeManager.AddUserInterface): Removed.
11889 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
11891 (TypeManager.GetInterfaces): Likewise.
11892 (TypeManager.GetExplicitInterfaces): Likewise.
11894 * ecore.cs (TypeExpr.GetInterfaces): Removed.
11896 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
11897 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
11899 2004-11-14 Ben Maurer <bmaurer@ximian.com>
11901 * statement.cs: Avoid adding bools to a hashtable.
11903 2004-11-07 Miguel de Icaza <miguel@ximian.com>
11905 * expression.cs (Invocation.OverloadResolve): Flag error if we are
11906 calling an unsafe method from a safe location.
11908 2004-11-06 Marek Safar <marek.safar@seznam.cz>
11911 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
11913 2004-11-06 Miguel de Icaza <miguel@ximian.com>
11915 * namespace.cs (VerifyUsing): use GetPartialName instead of
11918 2004-11-05 Miguel de Icaza <miguel@ximian.com>
11920 * statement.cs (Return.Resolve): Fix regression in typo: if
11921 `in_exc', we have to request a NeedReturnLabel, this was a typo
11922 introduced in the anonymous method check-in. Fixes #69131.
11924 * Indexers were using the ShortName when defining themselves,
11925 causing a regression in the compiler bootstrap when applying the
11926 patch from 2004-11-02 (first part), now they use their full name
11927 and the bug is gone.
11929 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
11931 * driver.cs: Strip the path from the names of embedded resources. Fixes
11934 2004-11-04 Raja R Harinath <rharinath@novell.com>
11936 Fix error message regression: cs0104-2.cs.
11937 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
11938 (AliasEntry.Resolve): Update.
11939 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
11941 (RootContext.LookupType): Update.
11943 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
11945 * cs-parser.jay: Add support for handling accessor modifiers
11946 * class: Add support port accessor modifiers and error checking,
11947 define PropertyMethod.Define as virtual (not abstract anymore)
11948 * ecore.cs: Add checking for proeprties access with access modifiers
11949 * iterators.cs: Modify Accessor constructor call based in the modified
11951 2004-11-02 Ben Maurer <bmaurer@ximian.com>
11953 * expression.cs (StringConcat): Handle being called twice,
11954 as when we have a concat in a field init with more than two
11957 2004-11-02 Miguel de Icaza <miguel@ximian.com>
11959 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
11960 special case explicit implementations, we should always produce
11961 the .property or .event declaration.
11963 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
11964 since it will not return correct data if people use this
11965 unresolved in the presence of using statements (see test-313).
11967 * class.cs (MethodData.Define): If we are an explicit interface
11968 implementation, set the method name to the full name of the
11969 interface plus the name of the method.
11971 Notice that using the method.MethodName.GetFullName() does not
11972 work, as it will only contain the name as declared on the source
11973 file (it can be a shorthand in the presence of using statements)
11974 and not the fully qualifed type name, for example:
11978 class D : ICloneable {
11979 object ICloneable.Clone () {
11983 Would produce a method called `ICloneable.Clone' instead of
11984 `System.ICloneable.Clone'.
11986 * namespace.cs (Alias.Resolve): Use GetPartialName.
11988 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11990 * cs-parser.jay: Add error 1055 report.
11992 2004-11-01 Miguel de Icaza <miguel@ximian.com>
11994 * assign.cs (Assign.DoResolve): Only do the transform of
11995 assignment into a New if the types are compatible, if not, fall
11996 through and let the implicit code deal with the errors and with
11997 the necessary conversions.
11999 2004-11-01 Marek Safar <marek.safar@seznam.cz>
12001 * cs-parser.jay: Add error 1031 report.
12003 * cs-tokenizer.cs: Add location for error 1038.
12005 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12007 * cs-parser.jay: Add error 1016 report.
12009 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12011 * cs-parser.jay: Add errors 1575,1611 report.
12013 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12015 * cs-parser.jay: Add error 1001 report.
12017 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12020 * attribute.cs (GetMarshal): Add method argument for
12021 caller identification.
12023 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
12024 agument for GetMarshal and RuntimeMissingSupport.
12026 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12028 * attribute.cs (ExtractSecurityPermissionSet): Removed
12029 TypeManager.code_access_permission_type.
12031 * typemanager.cs: Removed TypeManager.code_access_permission_type.
12033 2004-10-27 Miguel de Icaza <miguel@ximian.com>
12035 * expression.cs (LocalVariableReference.DoResolveLValue): Check
12036 for obsolete use of a variable here. Fixes regression on errors
12037 cs0619-25 and cs0619-26.
12039 2004-10-27 Marek Safar <marek.safar@seznam.cz>
12041 Fix #62358, implemented security attribute encoding.
12043 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
12044 Tests permitted SecurityAction for assembly or other types.
12045 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
12046 data from SecurityPermissionAttribute to PermisionSet class.
12048 * class.cs (ApplyAttributeBuilder): Added special handling
12049 for System.Security.Permissions.SecurityAttribute based types.
12051 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
12052 special handling for System.Security.Permissions.SecurityAttribute
12055 * enum.cs (ApplyAttributeBuilder): Added special handling
12056 for System.Security.Permissions.SecurityAttribute based types.
12058 * parameter.cs (ApplyAttributeBuilder): Added special handling
12059 for System.Security.Permissions.SecurityAttribute based types.
12061 * rootcontext.cs: Next 2 core types.
12063 * typemanager.cs (TypeManager.security_permission_attr_type):
12064 Built in type for the SecurityPermission Attribute.
12065 (code_access_permission_type): Build in type.
12067 2004-10-17 Miguel de Icaza <miguel@ximian.com>
12069 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
12070 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
12071 all of this information into
12072 EmitContext.EmitCapturedVariableInstance.
12074 * codegen.cs (EmitCapturedVariableInstance): move here the
12075 funcionality of emitting an ldarg.0 in the presence of a
12076 remapping. This centralizes the instance emit code.
12078 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
12079 then emit a load of this: it means that we have reached the
12080 topmost ScopeInfo: the one that contains the pointer to the
12081 instance of the class hosting the anonymous method.
12083 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
12084 captures to the topmost CaptureContext.
12086 2004-10-12 Miguel de Icaza <miguel@ximian.com>
12088 * expression.cs (LocalVariableReference): Move the knowledge about
12089 the iterators into codegen's EmitCapturedVariableInstance.
12091 2004-10-11 Miguel de Icaza <miguel@ximian.com>
12093 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
12094 all code paths return a value from an anonymous method (it is the
12095 same as the 161 error, but for anonymous methods).
12097 2004-10-08 Miguel de Icaza <miguel@ximian.com>
12099 The introduction of anonymous methods in the compiler changed
12100 various ways of doing things in the compiler. The most
12101 significant one is the hard split between the resolution phase
12102 and the emission phases of the compiler.
12104 For instance, routines that referenced local variables no
12105 longer can safely create temporary variables during the
12106 resolution phase: they must do so from the emission phase,
12107 since the variable might have been "captured", hence access to
12108 it can not be done with the local-variable operations from the runtime.
12112 (Block.Flags): New flag `IsTopLevel' to indicate that this block
12113 is a toplevel block.
12115 (ToplevelBlock): A new kind of Block, these are the blocks that
12116 are created by the parser for all toplevel method bodies. These
12117 include methods, accessors and anonymous methods.
12119 These contain some extra information not found in regular blocks:
12120 A pointer to an optional CaptureContext (for tracking captured
12121 local variables and parameters). A pointer to the parent
12124 (Return.Resolve): Catch missmatches when returning a value from an
12125 anonymous method (error 1662).
12126 Invoke NeedReturnLabel from the Resolve phase instead of the emit
12129 (Break.Resolve): ditto.
12131 (SwitchLabel): instead of defining the labels during the
12132 resolution phase, we now turned the public ILLabel and ILLabelCode
12133 labels into methods called GetILLabelCode() and GetILLabel() that
12134 only define the label during the Emit phase.
12136 (GotoCase): Track the SwitchLabel instead of the computed label
12137 (its contained therein). Emit the code by using
12138 SwitchLabel.GetILLabelCode ().
12140 (LocalInfo.Flags.Captured): A new flag has been introduce to track
12141 whether the Local has been captured or not.
12143 (LocalInfo.IsCaptured): New property, used to tell whether the
12144 local has been captured.
12146 * anonymous.cs: Vastly updated to contain the anonymous method
12149 The main classes here are: CaptureContext which tracks any
12150 captured information for a toplevel block and ScopeInfo used to
12151 track the activation frames for various local variables.
12153 Each toplevel block has an optional capture context associated
12154 with it. When a method contains an anonymous method both the
12155 toplevel method and the anonymous method will create a capture
12156 context. When variables or parameters are captured, they are
12157 recorded on the CaptureContext that owns them, for example:
12161 MyDelegate d = delegate {
12166 Here `a' will be recorded as captured on the toplevel
12167 CapturedContext, the inner captured context will not have anything
12168 (it will only have data if local variables or parameters from it
12169 are captured in a nested anonymous method.
12171 The ScopeInfo is used to track the activation frames for local
12172 variables, for example:
12174 for (int i = 0; i < 10; i++)
12175 for (int j = 0; j < 10; j++){
12176 MyDelegate d = delegate {
12181 At runtime this captures a single captured variable `i', but it
12182 captures 10 different versions of the variable `j'. The variable
12183 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
12184 recorded on a child.
12186 The toplevel ScopeInfo will also track information like the `this'
12187 pointer if instance variables were referenced (this is necessary
12188 as the anonymous method lives inside a nested class in the host
12189 type of the method).
12191 (AnonymousMethod): Expanded to track the Toplevel, implement
12192 `AnonymousMethod.Compatible' to tell whether an anonymous method
12193 can be converted to a target delegate type.
12195 The routine now also produces the anonymous method content
12197 (AnonymousDelegate): A helper class that derives from
12198 DelegateCreation, this is used to generate the code necessary to
12199 produce the delegate for the anonymous method that was created.
12201 * assign.cs: API adjustments for new changes in
12202 Convert.ImplicitStandardConversionExists.
12204 * class.cs: Adjustments to cope with the fact that now toplevel
12205 blocks are of type `ToplevelBlock'.
12207 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
12208 insteda of standard blocks.
12210 Flag errors if params arguments are passed to anonymous methods.
12212 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
12213 `CurrentAnonymousMethod' which points to the current Anonymous
12214 Method. The variable points to the AnonymousMethod class that
12215 holds the code being compiled. It is set in the new EmitContext
12216 created for the anonymous method.
12218 (EmitContext.Phase): Introduce a variable and an enumeration to
12219 assist in enforcing some rules about when and where we are allowed
12220 to invoke certain methods (EmitContext.NeedsReturnLabel is the
12221 only one that enfonces this right now).
12223 (EmitContext.HaveCaptureInfo): new helper method that returns
12224 whether we have a CapturedContext initialized.
12226 (EmitContext.CaptureVariable): New method used to register that a
12227 LocalInfo must be flagged for capturing.
12229 (EmitContext.CapturedParameter): New method used to register that a
12230 parameters must be flagged for capturing.
12232 (EmitContext.CapturedField): New method used to register that a
12233 field must be flagged for capturing.
12235 (EmitContext.HaveCapturedVariables,
12236 EmitContext.HaveCapturedFields): Return whether there are captured
12237 variables or fields.
12239 (EmitContext.EmitMethodHostInstance): This is used to emit the
12240 instance for the anonymous method. The instance might be null
12241 (static methods), this (for anonymous methods that capture nothing
12242 and happen to live side-by-side with the current method body) or a
12243 more complicated expression if the method has a CaptureContext.
12245 (EmitContext.EmitTopBlock): Routine that drives the emission of
12246 code: it will first resolve the top block, then emit any metadata
12247 and then emit the code. The split is done so that we can extract
12248 any anonymous methods and flag any captured variables/parameters.
12250 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
12251 during this phase, the ILGenerator should not be used as labels
12252 and local variables declared here might not be accessible to any
12253 code that is part of an anonymous method.
12255 Exceptions to this include the temporary variables that are
12256 created by some statements internally for holding temporary
12259 (EmitContext.EmitMeta): New routine, in charge of emitting all the
12262 (EmitContext.TemporaryReturn): This method is typically called
12263 from the Emit phase, and its the only place where we allow the
12264 ReturnLabel to be defined other than the EmitMeta. The reason is
12265 that otherwise we would have to duplicate a lot of logic in the
12266 Resolve phases of various methods that today is on the Emit
12269 (EmitContext.NeedReturnLabel): This no longer creates the label,
12270 as the ILGenerator is not valid during the resolve phase.
12272 (EmitContext.EmitThis): Extended the knowledge in this class to
12273 work in anonymous methods in addition to iterators.
12275 (EmitContext.EmitCapturedVariableInstance): This emits whatever
12276 code is necessary on the stack to access the instance to a local
12277 variable (the variable will be accessed as a field).
12279 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
12280 EmitContext.EmitAddressOfParameter): Routines to support
12281 parameters (not completed at this point).
12283 Removals: Removed RemapLocal and RemapLocalLValue. We probably
12284 will also remove the parameters.
12286 * convert.cs (Convert): Define a `ConstantEC' which points to a
12287 null. This is just to prefity some code that uses
12288 ImplicitStandardConversion code and do not have an EmitContext
12291 The idea is to flag explicitly that at that point in time, it is
12292 known that the conversion will not trigger the delegate checking
12293 code in implicit conversions (which requires a valid
12296 Everywhere: pass new EmitContext parameter since
12297 ImplicitStandardConversionExists now requires it to check for
12298 anonymous method conversions.
12300 (Convert.ImplicitStandardConversionExists): If the type of an
12301 expression is the anonymous_method_type, and the type is a
12302 delegate, we invoke the AnonymousMethod.Compatible method to check
12303 whether an implicit conversion is possible.
12305 (Convert.ImplicitConversionStandard): Only do implicit method
12306 group conversions if the language level is not ISO_1.
12308 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
12309 MethodInfo for the Invoke method. used by Delegate and
12312 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
12313 method conversions if the target type is a delegate.
12315 Removed extra debugging nops.
12317 (LocalVariableReference): Turn the `local_info' into a public
12320 Add `prepared' field, the same hack used for FieldExprs to cope
12321 with composed assignments, as Local variables do not necessarily
12322 operate purely on the stack as they used to: they can be captured
12325 Add `temp' for a temporary result, like fields.
12327 Refactor DoResolve and DoResolveLValue into DoResolveBase.
12329 It now copes with Local variables that are captured and emits the
12330 proper instance variable to load it from a field in the captured
12333 (ParameterReference.DoResolveBase): During the resolve phase,
12334 capture parameters if we are in an anonymous method.
12336 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
12337 anonymous method, use the EmitContext helper routines to emit the
12338 parameter reference.
12340 * iterators.cs: Set RemapToProxy to true/false during the
12343 * parameters.cs (GetParameterByName): New helper method.
12345 * typemanager.cs (anonymous_method_type) a new type that
12346 represents an anonyous method. This is always an internal type,
12347 used as a fencepost to test against the anonymous-methodness of an
12350 2004-10-20 Marek Safar <marek.safar@seznam.cz>
12352 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
12354 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
12356 2004-10-18 Martin Baulig <martin@ximian.com>
12358 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
12359 `Type' directly, but call ResolveType() on it.
12360 (Catch.Resolve): Likewise.
12361 (Foreach.Resolve): Likewise.
12363 2004-10-18 Martin Baulig <martin@ximian.com>
12365 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
12366 `Type' directly, but call ResolveType() on it.
12367 (Probe.DoResolve): Likewise.
12368 (ArrayCreation.LookupType): Likewise.
12369 (TypeOf.DoResolve): Likewise.
12370 (SizeOf.DoResolve): Likewise.
12372 2004-10-18 Martin Baulig <martin@ximian.com>
12374 * expression.cs (Invocation.BetterFunction): Put back
12375 TypeManager.TypeToCoreType().
12377 2004-10-18 Raja R Harinath <rharinath@novell.com>
12379 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
12382 2004-10-18 Martin Baulig <martin@ximian.com>
12384 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
12385 `Type' directly, but call ResolveType() on it.
12387 2004-10-18 Martin Baulig <martin@ximian.com>
12389 * class.cs (FieldMember.Define): Don't access the TypeExpr's
12390 `Type' directly, but call ResolveType() on it.
12391 (MemberBase.DoDefine): Likewise.
12393 * expression.cs (New.DoResolve): Don't access the TypeExpr's
12394 `Type' directly, but call ResolveType() on it.
12395 (ComposedCast.DoResolveAsTypeStep): Likewise.
12397 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
12398 `Type' directly, but call ResolveType() on it.
12400 2004-10-17 John Luke <john.luke@gmail.com>
12402 * class.cs (Operator.GetSignatureForError): use CSharpName
12404 * parameter.cs (Parameter.GetSignatureForError): Returns
12405 correct name even if was not defined.
12407 2004-10-13 Raja R Harinath <rharinath@novell.com>
12410 * class.cs (TypeContainer.EmitContext): New property.
12411 (DefineNestedTypes): Create an emitcontext for each part.
12412 (MethodCore.DoDefineParameters): Use container's emitcontext.
12413 Pass type array to InternalParameters.
12414 (MemberBase.DoDefine): Use container's emitcontext.
12415 (FieldMember.Define): Likewise.
12416 (Event.Define): Likewise.
12417 (SetMethod.GetParameterInfo): Change argument to EmitContext.
12418 Pass type array to InternalParameters.
12419 (SetIndexerMethod.GetParameterInfo): Likewise.
12420 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
12421 * delegate.cs (Define): Pass emitcontext to
12422 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
12423 array to InternalParameters.
12424 * expression.cs (ParameterReference.DoResolveBase): Pass
12425 emitcontext to GetParameterInfo.
12426 (ComposedCast.DoResolveAsTypeStep): Remove check on
12427 ec.ResolvingTypeTree.
12428 * parameter.cs (Parameter.Resolve): Change argument to
12429 EmitContext. Use ResolveAsTypeTerminal.
12430 (Parameter.GetSignature): Change argument to EmitContext.
12431 (Parameters.ComputeSignature): Likewise.
12432 (Parameters.ComputeParameterTypes): Likewise.
12433 (Parameters.GetParameterInfo): Likewise.
12434 (Parameters.ComputeAndDefineParameterTypes): Likewise.
12435 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
12436 * support.cs (InternalParameters..ctor): Remove variant that takes
12438 * typemanager.cs (system_intptr_expr): New.
12439 (InitExpressionTypes): Initialize it.
12441 2004-10-12 Chris Toshok <toshok@ximian.com>
12443 * cs-parser.jay: fix location for try_statement and catch_clause.
12445 2004-10-11 Martin Baulig <martin@ximian.com>
12447 * report.cs: Don't make --fatal abort on warnings, we have
12448 -warnaserror for that.
12450 2004-10-07 Raja R Harinath <rharinath@novell.com>
12452 More DeclSpace.ResolveType avoidance.
12453 * decl.cs (MemberCore.InUnsafe): New property.
12454 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
12455 with newly created EmitContext.
12456 (FieldMember.Define): Likewise.
12457 * delegate.cs (Delegate.Define): Likewise.
12458 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
12459 only if normal name-lookup fails.
12460 (TypeExpr.DoResolve): Enable error-checking.
12461 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
12462 (SizeOf.DoResolve): Likewise.
12463 (ComposedCast.DoResolveAsTypeStep): Likewise.
12464 (StackAlloc.DoResolve): Likewise.
12465 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
12466 (Block.Unsafe): New property.
12467 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
12468 (Unsafe): Set 'unsafe' flag of contained block.
12469 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
12470 (Fixed.Resolve): Likewise.
12471 (Catch.Resolve): Likewise.
12472 (Using.ResolveLocalVariableDecls): Likewise.
12473 (Foreach.Resolve): Likewise.
12475 2004-10-05 John Luke <john.luke@gmail.com>
12477 * cs-parser.jay: add location to error CS0175
12479 2004-10-04 Miguel de Icaza <miguel@ximian.com>
12481 * ecore.cs (Expression.Constantity): Add support for turning null
12484 * const.cs (Const.Define): Allow constants to be reference types
12485 as long as the value is Null.
12487 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
12489 * namespace.cs (NamespaceEntry.Using): No matter which warning
12490 level is set, check if this namespace name has already been added.
12492 2004-10-03 Ben Maurer <bmaurer@ximian.com>
12494 * expression.cs: reftype [!=]= null should always use br[true,false].
12497 2004-10-03 Marek Safar <marek.safar@seznam.cz>
12500 * attribute.cs: Enum conversion moved to
12501 GetAttributeArgumentExpression to be applied to the all
12504 2004-10-01 Raja R Harinath <rharinath@novell.com>
12506 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
12507 * class.c (TypeContainer.DefineType): Flag error if
12508 base types aren't accessible due to access permissions.
12509 * decl.cs (DeclSpace.ResolveType): Move logic to
12510 Expression.ResolveAsTypeTerminal.
12511 (DeclSpace.ResolveTypeExpr): Thin layer over
12512 Expression.ResolveAsTypeTerminal.
12513 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
12514 Refactor code into NestedAccess. Use it.
12515 (DeclSpace.NestedAccess): New.
12516 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
12517 argument to silence errors. Check access permissions.
12518 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
12519 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
12520 (Cast.DoResolve): Likewise.
12521 (New.DoResolve): Likewise.
12522 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
12523 (TypeOf.DoResolve): Likewise.
12525 * expression.cs (Invocation.BetterConversion): Return the Type of
12526 the better conversion. Implement section 14.4.2.3 more faithfully.
12527 (Invocation.BetterFunction): Make boolean. Make correspondence to
12528 section 14.4.2.2 explicit.
12529 (Invocation.OverloadResolve): Update.
12530 (Invocation): Remove is_base field.
12531 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
12532 (Invocation.Emit): Likewise.
12534 2004-09-27 Raja R Harinath <rharinath@novell.com>
12536 * README: Update to changes.
12538 2004-09-24 Marek Safar <marek.safar@seznam.cz>
12540 * cs-parser.jay: Reverted 642 warning fix.
12542 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12545 * decl.cs (FindMemberWithSameName): Indexer can have more than
12548 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12550 * expression.cs (LocalVariableReference.DoResolveLValue):
12551 Do not report warning 219 for out values.
12552 (EmptyExpression.Null): New member to avoid extra allocations.
12554 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12556 * cs-parser.jay: Fix wrong warning 642 report.
12558 * cs-tokenizer.cs (CheckNextToken): New helper;
12559 Inspect next character if is same as expected.
12561 2004-09-23 Martin Baulig <martin@ximian.com>
12563 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
12564 (Convert.ImplicitReferenceConversionExists): Likewise.
12566 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12568 * class.cs (Operator.Define): Add error 448 and 559 report.
12570 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12572 * class.cs (MemberBase.IsTypePermitted): New protected
12573 method for checking error CS0610.
12575 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12577 * class.cs (TypeContainer.HasExplicitLayout): New property
12578 Returns whether container has StructLayout attribute set Explicit.
12579 (FieldMember): New abstract class for consts and fields.
12580 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
12581 (Field): Reuse FieldMember.
12583 * const.cs (Const): Reuse FieldMember.
12585 * rootcontext.cs: EmitConstants call moved to class.
12587 2004-09-22 Martin Baulig <martin@ximian.com>
12589 Thanks to Peter Sestoft for this bug report.
12591 * expression.cs (Conditional): If both the `trueExpr' and the
12592 `falseExpr' is a NullLiteral, return a NullLiteral.
12594 2004-09-22 Martin Baulig <martin@ximian.com>
12596 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
12597 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
12598 for the "get_Current" call.
12600 2004-09-22 Martin Baulig <martin@ximian.com>
12602 Marek and me just fixed one of our oldest bugs: #28562 :-)
12604 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
12606 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
12607 we're an EnumConstant, just return that.
12608 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
12609 an EnumConstant. In this case, we need to use GetValueAsEnumType()
12610 to get the value which'll actually be written into the attribute.
12611 However, we have to use GetValue() to access the attribute's value
12614 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12616 * constant.cs (Constant.IsNegative): New abstract property
12619 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
12620 (StackAlloc.DoResolve): Reused IsNegative.
12622 2004-09-21 Martin Baulig <martin@ximian.com>
12624 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
12625 if we're used in an iterator, we may be called from different
12628 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
12629 we actually have an exception block.
12631 2004-09-20 John Luke <jluke@cfl.rr.com>
12633 * class.cs, cs-parser.jay: Improve the error report for 1520:
12634 report the actual line where the error happens, not where the
12635 class was declared.
12637 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
12638 Pass location information that was available elsewhere.
12640 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
12642 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
12643 runtime to delay sign assemblies.
12645 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12647 * cs-parser.jay: Do not report the stack trace, this is barely
12650 2004-08-22 John Luke <john.luke@gmail.com>
12652 * driver.cs : check that a resource id is not already used
12653 before adding it, report CS1508 if it is, bug #63637
12655 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12657 * ecore.cs: Removed dead code.
12659 2004-09-18 Marek Safar <marek.safar@seznam.cz>
12661 * class.cs: Do not report warning CS0067 on the interfaces.
12663 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12665 * cs-parser.jay: Add error 504 report.
12667 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12669 * rootcontext.cs: WarningLevel is 4 by default now.
12671 * statement.cs (Fixed.Resolve): Do not null
12674 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12677 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
12678 deep search when property is not virtual.
12679 (PropertyExpr.ResolveAccessors): Make one call for both
12682 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12685 * statement.cs: Error 152 report constains also location.
12687 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12690 * const.cs: Explicitly set constant as static.
12692 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12695 * cs-parser.jay: Add error 1017 report.
12697 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12699 Fixed bug #59980, #64224
12700 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
12702 * typemanager.cs (IsSpecialMethod): Simplified
12704 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12706 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
12707 condition with better params.
12709 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12712 * attribute.cs (Resolve): Property has to have both
12715 2004-09-14 Martin Baulig <martin@ximian.com>
12717 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
12719 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12722 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
12723 called and is obsolete then this member suppress message
12724 when call is inside next [Obsolete] method or type.
12726 * expression.cs: Use TestObsoleteMethodUsage member.
12728 2004-09-14 Martin Baulig <martin@ximian.com>
12730 * cs-parser.jay: Sync a bit with the GMCS version.
12732 2004-09-14 Martin Baulig <martin@ximian.com>
12734 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
12735 (CSharpParser.yacc_verbose_flag): New public field.
12737 * genericparser.cs: Removed.
12739 2004-09-14 Raja R Harinath <rharinath@novell.com>
12741 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
12743 2004-09-13 Marek Safar <marek.safar@seznam.cz>
12745 * class.cs (MethodCore.CheckBase): Fix bug #65757.
12747 2004-09-10 Martin Baulig <martin@ximian.com>
12749 Backported my MemberName changes from GMCS into MCS.
12751 - we are now using a special `MemberName' class instead of using
12752 strings; in GMCS, the `MemberName' also contains the type
12755 - changed the grammar rules a bit:
12756 * the old `member_name' is now a `namespace_or_type_name':
12757 The rule is that we use `namespace_or_type_name' everywhere
12758 where we expect either a "member name" (GetEnumerator) or a
12759 "member name" with an explicit interface name
12760 (IEnumerable.GetEnumerator).
12761 In GMCS, the explicit interface name may include type arguments
12762 (IEnumerable<T>.GetEnumerator).
12763 * we use `member_name' instead of just `IDENTIFIER' for
12765 The rule is that we use `member_name' wherever a member may
12766 have type parameters in GMCS.
12768 * decl.cs (MemberName): New public class.
12769 (MemberCore.MemberName): New public readonly field.
12770 (MemberCore.ctor): Take a `MemberName' argument, not a string.
12771 (DeclSpace): Likewise.
12773 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
12774 * enum.cs (Enum.ctor): Likewise.
12776 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
12778 (AliasEntry.ctor): Take a MemberName, not an Expression.
12779 (AliasEntry.UsingAlias): Likewise.
12781 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
12782 (IMethodData.MemberName): Changed type from string to MemberName.
12783 (MemberBase.ExplicitInterfaceName): Likewise.
12784 (AbstractPropertyEventMethod.SetupName): Make this private.
12785 (AbstractPropertyEventMethod.ctor): Added `string prefix'
12786 argument; compute the member name here.
12787 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
12788 on the `member.MemberName' and the `prefix'.
12790 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
12792 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
12793 thus, we get a `MemberName' instead of a `string'. These
12794 declarations may have type parameters in GMCS.
12795 (interface_method_declaration, delegate_declaration): Likewise.
12796 (class_declaration, interface_declaration): Likewise.
12797 (method_header): Use `namespace_or_type_name' instead of
12798 `member_name'. We may be an explicit interface implementation.
12799 (property_declaration, event_declaration): Likewise.
12800 (member_name): This is now just an `IDENTIFIER', not a
12801 `namespace_or_type_name'.
12802 (type_name, interface_type): Removed.
12803 (namespace_or_type_name): Return a MemberName, not an Expression.
12804 (primary_expression): Use `member_name' instead of `IDENTIFIER';
12805 call GetTypeExpression() on the MemberName to get an expression.
12806 (IndexerDeclaration.interface_type): Changed type from string to
12808 (MakeName): Operate on MemberName's instead of string's.
12810 2004-09-13 Raja R Harinath <rharinath@novell.com>
12813 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
12814 (NamespaceEntry.Lookup): Add new argument to flag if we want the
12815 lookup to avoid symbols introduced by 'using'.
12816 * rootcontext.cs (NamespaceLookup): Update.
12818 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12820 * class.cs (TypeContainer.DoDefineMembers): Do not call
12821 DefineDefaultConstructor for static classes.
12823 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12825 * attribute.cs (Attribute.Resolve): Add error 653 report.
12827 * class.cs (Class.ApplyAttributeBuilder): Add error 641
12829 (Method.ApplyAttributeBuilder): Add error 685 report.
12830 (Operator.Define): Add error 564 report.
12832 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
12834 * expression.cs (Invocation.DoResolve): Add error
12835 245 and 250 report.
12837 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
12840 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12842 * class.cs (ConstructorInitializer.Resolve):
12843 Wrong error number (515->516).
12845 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12847 * class.cs (Indexer.Define): Add error 631 report.
12849 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12851 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
12853 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12855 * expression.cs (Probe.DoResolve): Add error CS0241 report.
12857 2004-09-10 Marek Safar <marek.safar@seznam.cz>
12859 * cs-parser.jay: Added error CS0241 report.
12861 2004-09-10 Raja R Harinath <rharinath@novell.com>
12863 * cs-parser.jay (fixed_statement): Introduce a scope for the
12864 declaration in the 'fixed' statement.
12866 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12868 * cs-parser.jay: Added CS0230 error report.
12870 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12872 * cs-parser.jay: Added errors CS0231 and CS0257 report.
12874 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12876 * expression.cs (Argument.Resolve): Added error CS0192 and
12879 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12881 C# 2.0 #pragma warning feature
12883 * cs-tokenizer.cs (PreProcessPragma): New method;
12884 Handles #pragma directive.
12886 * report.cs (WarningRegions): New class; Support
12887 class for #pragma warning directive. It tests whether
12888 warning is enabled for a given line.
12890 2004-09-08 Miguel de Icaza <miguel@ximian.com>
12892 * const.cs: Add more descriptive error report, tahnks to
12895 2004-09-08 Marek Safar <marek.safar@seznam.cz>
12897 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
12899 2004-09-07 Miguel de Icaza <miguel@ximian.com>
12901 * expression.cs: Apply patch from Ben: Remove dead code from
12902 ArrayCreation, and remove the TurnintoConstant call in const.cs,
12903 as that code just threw an exception anwyays.
12905 * const.cs: Remove the call to the turnintoconstant, for details
12908 * literal.cs: The type of the null-literal is the null type; So
12909 we use a placeholder type (literal.cs:System.Null, defined here)
12912 * expression.cs (Conditional.DoResolve): Remove some old code that
12913 is no longer needed, conversions have been fixed.
12915 (ArrayCreationExpression.DoResolve): Return false if we fail to
12916 resolve the inner expression.
12918 2004-09-07 Raja R Harinath <rharinath@novell.com>
12921 * cs-parser.jay (delegate_declaration): Record a delegate
12922 declaration as a type declaration.
12923 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
12925 2004-09-06 Miguel de Icaza <miguel@ximian.com>
12927 * parameter.cs: Do not crash if the type can not be resolved.
12929 * expression.cs: Report errors with unsafe pointers, fixes #64896
12931 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
12933 * expression.cs: Pointer arith always needs to do a conv.i
12934 if the operand is a long. fix 65320
12936 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12938 Fixed cs0619-37.cs, cs0619-38.cs
12940 * enum.cs (GetObsoleteAttribute): Removed.
12942 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
12943 on Enum member is double staged. The first is tested member
12946 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12948 Fixed #56986, #63631, #65231
12950 * class.cs: (TypeContainer.AddToMemberContainer): New method,
12951 adds member to name container.
12952 (TypeContainer.AddToTypeContainer): New method, adds type to
12954 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
12955 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
12956 AddOperator): Simplified by reusing AddToMemberContainer.
12957 (TypeContainer.UserDefinedStaticConstructor): Changed to property
12959 (Method.CheckForDuplications): Fixed implementation to test all
12961 (MemberBase): Detection whether member is explicit interface
12962 implementation is now in constructor.
12963 (MemberBase.UpdateMemberName): Handles IndexerName.
12964 (Accessor): Changed to keep also location information.
12965 (AbstractPropertyEventMethod): Is derived from MemberCore.
12966 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
12967 will be emited or not.
12968 (PropertyBase.AreAccessorsDuplicateImplementation):
12969 Tests whether accessors are not in collision with some method.
12970 (Operator): Is derived from MethodCore to simplify common
12973 * decl.cs (Flags.TestMethodDuplication): Test for duplication
12975 (DeclSpace.AddToContainer): Adds the member to defined_names
12976 table. It tests for duplications and enclosing name conflicts.
12978 * enum.cs (EnumMember): Clean up to reuse the base structures
12980 2004-09-03 Martin Baulig <martin@ximian.com>
12982 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
12983 into TypeContainer, to make partial classes work again.
12985 2004-09-03 Martin Baulig <martin@ximian.com>
12987 * rootcontext.cs (RootContext.V2): Removed.
12989 2004-03-23 Martin Baulig <martin@ximian.com>
12991 * expression.cs (Invocation.OverloadResolve): Added `bool
12992 may_fail' argument and use it instead of the Location.IsNull() hack.
12994 2004-09-03 Martin Baulig <martin@ximian.com>
12996 Merged latest changes into gmcs. Please keep this comment in
12997 here, it makes it easier for me to see what changed in MCS since
12998 the last time I merged.
13000 2004-09-03 Raja R Harinath <rharinath@novell.com>
13003 * expression.cs (BetterConversion): Don't allow either conversion
13004 to be null. Remove redundant implicit conversion test when 'q ==
13005 null' -- when this function is invoked, we already know that the
13006 implicit conversion exists.
13007 (BetterFunction): Assume that 'best' is non-null. Remove
13008 redundant reimplementation of IsApplicable when 'best' is null.
13009 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
13010 number of arguments.
13011 (IsAncestralType): Extract from OverloadResolve.
13012 (OverloadResolve): Make robust to the MethodGroupExpr being
13013 unsorted. Implement all the logic of Section 14.5.5.1, and
13014 support overloading of methods from multiple applicable types.
13015 Clean up logic somewhat. Don't pass null methods to BetterFunction.
13017 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
13018 (RealError, Warning): Append type of report to related symbol.
13020 2004-09-03 Marek Safar <marek.safar@seznam.cz>
13022 * enum.cs: Fixed CLS-Compliance checks for enum members.
13023 Error tests cs3008-8.cs, cs3014-8.cs
13025 2004-09-02 Marek Safar <marek.safar@seznam.cz>
13027 Fixed bug #62342, #63102
13028 * class.cs: ImplementIndexer uses member.IsExplicitImpl
13029 like ImplementMethod.
13031 2004-09-02 Marek Safar <marek.safar@seznam.cz>
13033 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13036 2004-09-02 Martin Baulig <martin@ximian.com>
13038 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
13039 TypeManager.GetArgumentTypes() rather than calling GetParameters()
13042 2004-09-01 Marek Safar <marek.safar@seznam.cz>
13044 C# 2.0 Static classes implemented
13046 * class.cs (TypeContainer): instance_constructors,
13047 initialized_fields, initialized_static_fields,
13048 default_constructor, base_inteface_types are protected to be
13049 accessible from StaticClass.
13050 (TypeContainer.DefineDefaultConstructor): New virtual method
13051 for custom default constructor generating
13052 (StaticClass): New class to handle "Static classes" feature.
13054 * cs-parser.jay: Handle static keyword on class like instance
13057 * driver.cs: Added "/langversion" command line switch with two
13058 options (iso-1, default).
13060 2004-08-31 Marek Safar <marek.safar@seznam.cz>
13062 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
13064 2004-08-31 Miguel de Icaza <miguel@ximian.com>
13066 * delegate.cs: Style.
13068 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
13070 * delegate.cs: Add seperate instance expr field for miguel.
13072 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13074 * PointerArithmetic (Resolve): make sure we are not doing
13075 pointer arith on void*. Also, make sure we are resolved
13076 by not setting eclass until resolve.
13078 All callers: Make sure that PointerArithmetic gets resolved.
13080 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13082 * ArrayCreation (LookupType): If the type does not resolve
13083 to an array, give an error.
13085 2004-08-27 Marek Safar <marek.safar@seznam.cz>
13087 * statement.cs (Try.Resolve): Fixed bug #64222
13089 2004-08-27 Martin Baulig <martin@ximian.com>
13092 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
13095 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13097 * ecore.cs (Constantify): Get underlying type via
13098 System.Enum.GetUnderlyingType to avoid StackOverflow on the
13099 Windows in special cases.
13101 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13103 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
13104 for obtaining also private methods.
13105 (GetRemoveMethod): Used GetRemoveMethod (true)
13106 for obtaining also private methods.
13108 2004-08-24 Martin Baulig <martin@ximian.com>
13110 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
13111 MethodAttributes.HideBySig for operators.
13113 2004-08-23 Martin Baulig <martin@ximian.com>
13115 Back to the old error reporting system :-)
13117 * report.cs (Message): Removed.
13118 (Report.MessageData, ErrorData, WarningData): Removed.
13119 (Report.Error, Warning): Back to the old system.
13121 2004-08-23 Martin Baulig <martin@ximian.com>
13123 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
13125 * class.cs (TypeContainer.ParentContainer): New public virtual
13126 method; replaces the explicit interface implementation.
13127 (ClassPart.ParentContainer): Override.
13129 2004-08-23 Martin Baulig <martin@ximian.com>
13131 * statement.cs (Switch): Added support for constant switches; see
13132 #59428 or test-285.cs.
13134 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13137 * statement.cs (GetEnumeratorFilter): Removed useless
13138 logic because C# specs is strict. GetEnumerator must be
13141 2004-08-22 Martin Baulig <martin@ximian.com>
13143 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13144 a switch and may break, reset the barrier. Fixes #59867.
13146 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13148 CLS-Compliance speed up (~5% for corlib)
13150 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
13151 New method. Tests container for CLS-Compliant names
13153 * class.cs (TypeContainer.VerifyClsName): New method.
13154 Checks whether container name is CLS Compliant.
13155 (Constructor): Implements IMethodData.
13157 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
13158 low-case table for CLS Compliance test.
13159 (MemberCache.VerifyClsParameterConflict): New method.
13160 Checks method parameters for CS3006 error.
13162 * enum.cs (EnumMember): Is derived from MemberCore.
13163 (Enum.VerifyClsName): Optimized for better performance.
13165 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13167 * report.cs: Renamed Error_T to Error and changed all
13170 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13172 * class.cs (TypeContainer.IndexerArrayList): New inner class
13173 container for indexers.
13174 (TypeContainer.DefaultIndexerName): New constant for default
13175 indexer name. Replaced all "Item" with this constant.
13176 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
13178 * typemanager.cs (TypeManager.default_member_ctor): Cache here
13179 DefaultMemberAttribute constructor.
13181 2004-08-05 Martin Baulig <martin@ximian.com>
13183 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13186 2004-08-05 Marek Safar <marek.safar@seznam.cz>
13188 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
13189 multi platforms problem.
13191 * compiler.csproj: Included shared files.
13193 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13195 Fix bug 60333, 55971 in the more general way
13196 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13197 Added arg_type argument for constant conversion.
13198 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
13200 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13203 * class.cs (TypeContainer ): New inner classes MethodArrayList,
13204 OperatorArrayList, MethodCoreArrayList for typecontainer
13205 containers. Changed class member types to these new types.
13206 (MethodArrayList.DefineMembers): Added test for CS0659.
13208 2004-08-04 Miguel de Icaza <miguel@ximian.com>
13210 * cfold.cs: Synchronize the folding with the code in expression.cs
13211 Binary.DoNumericPromotions for uint operands.
13213 * attribute.cs: Revert patch from Raja, it introduced a regression
13214 while building Blam-1.2.1 (hard to isolate a test case).
13216 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13220 (TypeContainer.Define): Renamed to DefineContainerMembers because of
13222 (MethodCore.parent_method): New member. The method we're overriding
13223 if this is an override method.
13224 (MethodCore.CheckBase): Moved from Method class and made common.
13225 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
13227 (MethodCore.CheckForDuplications): New abstract method. For custom
13228 member duplication search in a container
13229 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
13230 method and its return type.
13231 (Event.conflict_symbol): New member. Symbol with same name in the
13235 (MemberCache.FindMemberWithSameName): New method. The method
13236 is looking for conflict with inherited symbols.
13238 2004-08-04 Martin Baulig <martin@ximian.com>
13240 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
13242 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
13244 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13246 * report.cs (Message): New enum for better error, warning reference in
13248 (MessageData): New inner abstract class. It generally handles printing of
13249 error and warning messages.
13250 Removed unused Error, Warning, Message methods.
13252 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13254 Fix for cs0592-8.cs test
13256 (Attributable.ValidAttributeTargets): Made public.
13257 (Attribute.ExplicitTarget): New member for explicit target value.
13258 (Attribute.CheckTargets): Now we translate explicit attribute
13259 target to Target here.
13261 2004-08-03 Ben Maurer <bmaurer@ximian.com>
13263 * ecore.cs (MethodGroupExpr): new IsBase property.
13265 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
13267 * delegate.cs (DelegateCreation): store a MethodGroupExpr
13268 rather than an instance expr.
13270 (DelegateCreation.Emit): Use the method group rather than
13271 the instance expression. Also, if you have base.Foo as the
13272 method for a delegate, make sure to emit ldftn, not ldftnvirt.
13274 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
13276 (NewDelegate.DoResolve): Only check for the existance of Invoke
13277 if the method is going to be needed. Use MethodGroupExpr.
13279 (NewDelegate.Emit): Remove, DelegateCreation implements this.
13281 * expression.cs: For pointer arith., make sure to use
13282 the size of the type, not the size of the pointer to
13285 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13288 * class.cs (Class): Added error CS0502 test.
13290 2004-08-03 John Luke <jluke@cfl.rr.com>
13291 Raja R Harinath <rharinath@novell.com>
13294 * attribute.cs (Attribute.complained_before): New flag.
13295 (Attribute.ResolveType, Attribute.Resolve),
13296 (Attribute.DefinePInvokeMethod): Set it.
13297 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
13299 2004-08-03 Martin Baulig <martin@ximian.com>
13301 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
13302 use a user-defined operator; we still need to do numeric
13303 promotions in case one argument is a builtin type and the other
13304 one has an implicit conversion to that type. Fixes #62322.
13306 2004-08-02 Martin Baulig <martin@ximian.com>
13308 * statement.cs (LocalInfo.Flags): Added `IsThis'.
13309 (LocalInfo.IsThis): New public property.
13310 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
13312 2004-08-01 Martin Baulig <martin@ximian.com>
13314 * class.cs (TypeContainer.GetClassBases): Don't set the default
13315 here since we may get called from GetPartialBases().
13316 (TypeContainer.DefineType): If GetClassBases() didn't return a
13317 parent, use the default one.
13319 2004-07-30 Duncan Mak <duncan@ximian.com>
13321 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
13323 2004-07-30 Martin Baulig <martin@ximian.com>
13325 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
13327 * class.cs (SourceMethod): New public class, derive from the
13328 symbol writer's ISourceMethod.
13329 (Method): Use the new symbol writer API.
13331 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
13332 as argument and use the new symbol writer.
13335 (SourceFile): Implement the symbol writer's ISourceFile.
13336 (Location.SymbolDocument): Removed.
13337 (Location.SourceFile): New public property.
13339 * symbolwriter.cs: Use the new symbol writer API.
13341 2004-07-30 Raja R Harinath <rharinath@novell.com>
13343 * Makefile (install-local): Remove. Functionality moved to
13346 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
13348 * Makefile: Install mcs.exe.config file together with mcs.exe.
13349 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
13350 correct runtime version.
13352 2004-07-25 Martin Baulig <martin@ximian.com>
13355 (TypeContainer.RegisterOrder): Removed, this was unused.
13356 (TypeContainer, interface_order): Removed.
13357 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
13358 TypeContainer as argument since we can also be called with a
13359 `PartialContainer' for a partial class/struct/interface.
13360 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
13361 of checking whether we're an `Interface' - we could be a
13362 `PartialContainer'.
13363 (PartialContainer.Register): Override; call
13364 AddClass()/AddStruct()/AddInterface() on our parent.
13366 * cs-parser.jay (interface_member_declaration): Add things to the
13367 `current_container', not the `current_class'.
13369 * rootcontext.cs (RegisterOrder): The overloaded version which
13370 takes an `Interface' was unused, removed.
13372 * typemanager.cs (TypeManager.LookupInterface): Return a
13373 `TypeContainer', not an `Interface'.
13374 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
13375 contain a `PartialContainer' for an interface, so check it's
13376 `Kind' to figure out what it is.
13378 2004-07-25 Martin Baulig <martin@ximian.com>
13380 * class.cs (Class.DefaultTypeAttributes): New public constant.
13381 (Struct.DefaultTypeAttributes): Likewise.
13382 (Interface.DefaultTypeAttributes): Likewise.
13383 (PartialContainer.TypeAttr): Override this and add the
13384 DefaultTypeAttributes.
13386 2004-07-25 Martin Baulig <martin@ximian.com>
13388 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
13389 we can just use the `Parent' field instead.
13391 2004-07-25 Martin Baulig <martin@ximian.com>
13393 * class.cs (TypeContainer.Emit): Renamed to EmitType().
13395 2004-07-25 Martin Baulig <martin@ximian.com>
13397 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
13398 our parts before defining any methods.
13399 (TypeContainer.VerifyImplements): Make this virtual.
13400 (ClassPart.VerifyImplements): Override and call VerifyImplements()
13401 on our PartialContainer.
13403 2004-07-25 Martin Baulig <martin@ximian.com>
13405 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
13407 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
13408 argument, we can just use the `Parent' field instead.
13411 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
13412 (MemberBase.DoDefine): Likewise.
13414 2004-07-24 Martin Baulig <martin@ximian.com>
13416 * decl.cs (MemberCore.Parent): New public field.
13417 (DeclSpace.Parent): Moved to MemberCore.
13419 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
13420 (MemberBase.ctor): Added TypeContainer argument, pass it to our
13422 (FieldBase, Field, Operator): Likewise.
13423 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
13424 (EventField, Event): Likewise.
13426 2004-07-23 Martin Baulig <martin@ximian.com>
13428 * class.cs (PartialContainer): New public class.
13429 (ClassPart): New public class.
13430 (TypeContainer): Added support for partial classes.
13431 (TypeContainer.GetClassBases): Splitted some of the functionality
13432 out into GetNormalBases() and GetPartialBases().
13434 * cs-tokenizer.cs (Token.PARTIAL): New token.
13435 (Tokenizer.consume_identifier): Added some hacks to recognize
13436 `partial', but only if it's immediately followed by `class',
13437 `struct' or `interface'.
13439 * cs-parser.jay: Added support for partial clases.
13441 2004-07-23 Martin Baulig <martin@ximian.com>
13443 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
13444 a `DeclSpace' and also made it readonly.
13445 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
13446 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
13447 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
13449 * cs-parser.jay: Pass the `current_class', not the
13450 `current_container' (at the moment, this is still the same thing)
13451 to a new Method, Property, Event, Indexer or Constructor.
13453 2004-07-23 Martin Baulig <martin@ximian.com>
13455 * cs-parser.jay (CSharpParser): Added a new `current_class' field
13456 and removed the `current_interface' one.
13457 (struct_declaration, class_declaration, interface_declaration):
13458 Set `current_class' to the newly created class/struct/interface;
13459 set their `Bases' and call Register() before parsing their body.
13461 2004-07-23 Martin Baulig <martin@ximian.com>
13463 * class.cs (Kind): New public enum.
13464 (TypeContainer): Made this class abstract.
13465 (TypeContainer.Kind): New public readonly field.
13466 (TypeContainer.CheckDef): New public method; moved here from
13468 (TypeContainer.Register): New public abstract method.
13469 (TypeContainer.GetPendingImplementations): New public abstract
13471 (TypeContainer.GetClassBases): Removed the `is_class' and
13472 `is_iface' parameters.
13473 (TypeContainer.DefineNestedTypes): Formerly known as
13475 (ClassOrStruct): Made this class abstract.
13477 * tree.cs (RootTypes): New public type.
13479 2004-07-20 Martin Baulig <martin@ximian.com>
13481 * tree.cs (Tree.RecordNamespace): Removed.
13482 (Tree.Namespaces): Removed.
13484 * rootcontext.cs (RootContext.IsNamespace): Removed.
13486 * cs-parser.jay (namespace_declaration): Just create a new
13487 NamespaceEntry here.
13489 2004-07-20 Martin Baulig <martin@ximian.com>
13491 * statement.cs (ExceptionStatement): New abstract class. This is
13492 now used as a base class for everyone who's using `finally'.
13493 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
13494 our local variables before using them.
13496 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
13497 virtual method. This is used by Yield.Resolve() to "steal" an
13498 outer block's `finally' clauses.
13499 (FlowBranchingException): The .ctor now takes an ExceptionStatement
13502 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
13503 version which takes an ExceptionStatement. This version must be
13504 used to create exception branchings.
13507 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
13508 (Iterator.EmitMoveNext): Added exception support; protect the
13509 block with a `fault' clause, properly handle 'finally' clauses.
13510 (Iterator.EmitDispose): Run all the `finally' clauses here.
13512 2004-07-20 Martin Baulig <martin@ximian.com>
13514 * iterator.cs: This is the first of a set of changes in the
13515 iterator code. Match the spec more closely: if we're an
13516 IEnumerable, then GetEnumerator() must be called. The first time
13517 GetEnumerator() is called, it returns the current instance; all
13518 subsequent invocations (if any) must create a copy.
13520 2004-07-19 Miguel de Icaza <miguel@ximian.com>
13522 * expression.cs: Resolve the constant expression before returning
13525 2004-07-19 Martin Baulig <martin@ximian.com>
13527 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
13528 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
13529 the return type of the new EmitContext.
13531 2004-07-18 Martin Baulig <martin@ximian.com>
13533 * class.cs (Property.Define): Fix iterators.
13535 * iterators.cs (Iterator.Define): Moved the
13536 `container.AddInterator (this)' call here from the .ctor; only do
13537 it if we resolved successfully.
13539 2004-07-17 Miguel de Icaza <miguel@ximian.com>
13541 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
13542 `true' for preprocessing directives that we parse. The return
13543 value indicates whether we should return to regular tokenizing or
13544 not, not whether it was parsed successfully.
13546 In the past if we were in: #if false ... #line #endif, we would
13547 resume parsing after `#line'. See bug 61604.
13549 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
13550 building: IsEnumType should return true only for enums, not for
13551 enums or System.Enum itself. This fixes #61593.
13553 Likely what happened is that corlib was wrong: mcs depended on
13554 this bug in some places. The bug got fixed, we had to add the
13555 hack, which caused bug 61593.
13557 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
13558 that was a workaround for the older conditions.
13560 2004-07-16 Ben Maurer <bmaurer@ximian.com>
13562 * assign.cs: IAssignMethod has a new interface, as documented
13563 inline. All assignment code now uses this new api.
13565 * ecore.cs, expression.cs: All classes which implement
13566 IAssignMethod now use the new interface.
13568 * expression.cs (Invocation): add a hack to EmitCall so that
13569 IndexerAccess can be the target of a compound assignment without
13570 evaluating its arguments twice.
13572 * statement.cs: Handle changes in Invocation api.
13574 2004-07-16 Martin Baulig <martin@ximian.com>
13576 * iterators.cs: Rewrote this. We're now using one single Proxy
13577 class for both the IEnumerable and the IEnumerator interface and
13578 `Iterator' derives from Class so we can use the high-level API.
13580 * class.cs (TypeContainer.AddIterator): New method.
13581 (TypeContainer.DoDefineType): New protected virtual method, which
13582 is called from DefineType().
13583 (TypeContainer.DoDefineMembers): Call DefineType() and
13584 DefineMembers() on all our iterators.
13585 (TypeContainer.Emit): Call Emit() on all our iterators.
13586 (TypeContainer.CloseType): Call CloseType() on all our iterators.
13588 * codegen.cs (EmitContext.CurrentIterator): New public field.
13590 2004-07-15 Martin Baulig <martin@ximian.com>
13593 (TypeManager.not_supported_exception_type): New type.
13595 2004-07-14 Martin Baulig <martin@ximian.com>
13597 * iterators.cs: Use real error numbers.
13599 2004-07-14 Martin Baulig <martin@ximian.com>
13601 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
13602 requires this to be a System.Collection.IEnumerable and not a
13603 class implementing that interface.
13604 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
13606 2004-07-13 Marek Safar <marek.safar@seznam.cz>
13608 * class.cs: Fixed previous fix, it broke some error tests.
13610 2004-07-12 Martin Baulig <martin@ximian.com>
13612 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
13615 2004-07-09 Miguel de Icaza <miguel@ximian.com>
13617 * assign.cs (LocalTemporary): Add new argument: is_address,If
13618 `is_address' is true, then the value that we store is the address
13619 to the real value, and not the value itself.
13621 * ecore.cs (PropertyExpr): use the new local temporary
13622 stuff to allow us to handle X.Y += z (where X is a struct)
13624 2004-07-08 Martin Baulig <martin@ximian.com>
13626 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
13627 not always return, just like we're doing in Using.Resolve().
13629 2004-07-07 Miguel de Icaza <miguel@ximian.com>
13631 * cs-parser.jay (fixed_statement): flag this as Pinned.
13633 2004-07-06 Miguel de Icaza <miguel@ximian.com>
13635 * typemanager.cs (TypeManager): Removed MakePinned method, this
13636 mechanism is replaced with the .NET 2.x compatible mechanism of
13637 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
13639 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
13640 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
13641 `IsFixed' property which has a different meaning.
13643 2004-07-02 Raja R Harinath <rharinath@novell.com>
13645 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
13646 visible from inside a nested class, not just the names of the
13647 immediately enclosing class.
13648 Fix for bug #60730.
13650 2004-06-24 Raja R Harinath <rharinath@novell.com>
13652 * expression.cs (BetterConversion): Remove buggy special-case
13653 handling of "implicit constant expression conversions". At this
13654 point, we already know that the conversion is possible -- we're
13655 only checking to see which is better.
13657 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13659 * cs-parser.jay: Added error CS0210 test.
13661 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13663 * cs-parser.jay: Added error CS0134 test.
13665 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13668 * cs-parser.jay: Added error CS0145 test.
13670 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13672 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
13674 2004-06-23 Ben Maurer <bmaurer@ximian.com>
13676 * expression.cs (StackAlloc.Resolve): The argument may not
13677 be a constant; deal with this case.
13679 2004-06-23 Marek Safar <marek.safar@seznam.cz>
13681 * attribute.cs (IndexerName_GetIndexerName): Renamed to
13682 GetIndexerAttributeValue.
13683 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
13685 * class.cs (Indexer.Define): Added error tests for CS0415,
13688 2004-06-23 Miguel de Icaza <miguel@ximian.com>
13690 * attribute.cs (Attribute.Resolve): Keep field code in sync with
13693 2004-06-23 Martin Baulig <martin@ximian.com>
13695 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
13696 neither return nor throw, reset the barrier as well. Fixes #60457.
13698 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
13700 * class.cs : EventAttributes is now set to None by default.
13701 This fixes bug #60459.
13703 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13706 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13707 Don't throw exception but return null (it's sufficient now).
13709 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13711 * typemanager.cs (GetArgumentTypes): Faster implementation.
13713 2004-06-18 Martin Baulig <martin@ximian.com>
13715 * attribute.cs (Attribute.Resolve): Check whether we're an
13716 EmptyCast which a Constant child. Fixes #60333.
13718 2004-06-17 Ben Maurer <bmaurer@ximian.com>
13720 * statement.cs (EmitCollectionForeach): Account for the fact that
13721 not all valuetypes are in areas which we can take the address of.
13722 For these variables, we store to a temporary variable. Also, make
13723 sure that we dont emit a `callvirt' on a valuetype method.
13725 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13727 * expression.cs (StackAlloc.DoReSolve): Added test for
13728 negative parameter (CS0247).
13730 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13733 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
13735 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13738 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
13741 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13743 Fix bug #58254 & cs1555.cs, cs1556.cs
13744 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
13746 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13748 * cs-parser.jay: Added error CS1669 test for indexers.
13750 2004-06-11 Martin Baulig <martin@ximian.com>
13752 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
13753 call this twice: for params and varargs methods.
13755 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13758 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
13760 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13762 * attribute.cs (Attribute.GetValidTargets): Made public.
13765 (AbstractPropertyEventMethod): New class for better code sharing.
13766 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
13768 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
13770 2004-06-11 Raja R Harinath <rharinath@novell.com>
13773 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
13774 that the call to Resolve is part of a MemberAccess.
13775 (Expression.Resolve): Use it for SimpleName resolution.
13776 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
13777 Add 'intermediate' boolean argument.
13778 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
13779 error message when the SimpleName can be resolved ambiguously
13780 between an expression and a type.
13781 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
13783 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
13784 call on the left-side.
13786 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13789 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
13791 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13793 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
13795 2004-06-11 Martin Baulig <martin@ximian.com>
13797 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
13798 varargs methods if applicable.
13800 2004-06-11 Martin Baulig <martin@ximian.com>
13802 * expression.cs (Invocation.EmitCall): Don't use
13803 `method.CallingConvention == CallingConventions.VarArgs' since the
13804 method could also have `CallingConventions.HasThis'.
13806 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13808 * class.cs (Event.GetSignatureForError): Implemented.
13809 Fixed crash in error test cs3010.cs
13811 2004-06-10 Miguel de Icaza <miguel@ximian.com>
13813 * cs-tokenizer.cs: Change the way we track __arglist to be
13814 consistent with the other keywords.
13816 2004-06-09 Miguel de Icaza <miguel@ximian.com>
13818 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
13821 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
13823 * codegen.cs: Check that all referenced assemblies have a strongname
13824 before strongnaming the compiled assembly. If not report error CS1577.
13825 Fix bug #56563. Patch by Jackson Harper.
13826 * typemanager.cs: Added a method to return all referenced assemblies.
13827 Fix bug #56563. Patch by Jackson Harper.
13829 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13832 (Method.ApplyAttributeBuilder): Moved and added conditional
13833 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
13836 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
13838 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13841 * class.cs: (EventField.attribute_targets): Changed default target.
13843 2004-06-08 Martin Baulig <martin@ximian.com>
13845 * expression.cs (Invocation.EmitCall): Enable varargs methods.
13847 2004-06-08 Martin Baulig <martin@ximian.com>
13849 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
13851 2004-06-07 Martin Baulig <martin@ximian.com>
13853 Added support for varargs methods.
13855 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
13858 * cs-parser.jay: Added support for `__arglist'.
13860 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
13862 * expression.cs (Argument.AType): Added `ArgList'.
13863 (Invocation): Added support for varargs methods.
13864 (ArglistAccess): New public class.
13865 (Arglist): New public class.
13867 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
13869 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
13870 a method's top-level block if the method has varargs.
13872 * support.cs (ReflectionParameters, InternalParameters): Added
13873 support for varargs methods.
13875 2004-06-07 Miguel de Icaza <miguel@ximian.com>
13877 * class.cs: Provide location in indexer error report.
13879 * driver.cs: Use standard names.
13881 * namespace.cs: Catch the use of using after a namespace has been
13882 declared also on using aliases.
13884 2004-06-03 Raja R Harinath <rharinath@novell.com>
13887 * typemanager.cs (closure_private_ok, closure_invocation_type)
13888 (closure_qualifier_type, closure_invocation_assembly)
13889 (FilterWithClosure): Move to ...
13890 (Closure): New internal nested class.
13891 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
13892 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
13893 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
13894 (MemberLookup, MemberLookupFailed): Use it.
13895 * expression.cs (New.DoResolve): Treat the lookup for the
13896 constructor as being qualified by the 'new'ed type.
13897 (Indexers.GetIndexersForTypeOrInterface): Update.
13899 2004-06-03 Marek Safar <marek.safar@seznam.cz>
13902 (GetConditionalAttributeValue): New method. Returns
13903 condition of ConditionalAttribute.
13904 (SearchMulti): New method. Returns all attributes of type 't'.
13905 Use it when attribute is AllowMultiple = true.
13906 (IsConditionalMethodExcluded): New method.
13909 (Method.IsExcluded): Implemented. Returns true if method has conditional
13910 attribute and the conditions is not defined (method is excluded).
13911 (IMethodData): Extended interface for ConditionalAttribute support.
13912 (PropertyMethod.IsExcluded): Implemented.
13915 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
13918 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
13921 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
13923 * expression.cs (ArrayCreationExpression): Make this just an
13924 `expression'. It can't be a statement, so the code here was
13927 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13930 * typemanager.cs (GetFullNameSignature): New method for
13933 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13936 * class.cs (MemberBase.GetSignatureForError): New virtual method.
13937 Use this method when MethodBuilder is null.
13938 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
13939 Added test for error CS0626 (MONO reports error for this situation).
13940 (IMethodData.GetSignatureForError): Extended interface.
13942 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13945 (AttributeTester.GetObsoleteAttribute): Returns instance of
13946 ObsoleteAttribute when type is obsolete.
13949 (TypeContainer.VerifyObsoleteAttribute): Override.
13950 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
13951 (MethodCode.VerifyObsoleteAttribute): Override.
13952 (MemberBase.VerifyObsoleteAttribute): Override.
13955 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
13956 and report proper error.
13959 Delegate.VerifyObsoleteAttribute): Override.
13962 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
13963 and report proper error.
13964 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
13967 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
13971 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
13972 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
13973 Added test for ObsoleteAttribute.
13976 (Catch): Derived from Statement.
13978 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13980 Fixed bug #59071 & cs0160.cs
13982 * statement.cs (Try.Resolve): Check here whether order of catch
13983 clauses matches their dependencies.
13985 2004-05-31 Miguel de Icaza <miguel@ximian.com>
13987 * Reverted patch to namespace.cs (Use lookuptypedirect). This
13988 caused a regression: #59343. Referencing nested classes from an
13989 assembly stopped working.
13991 2004-05-31 Martin Baulig <martin@ximian.com>
13993 MCS is now frozen for beta 2.
13995 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13997 * convert.cs: add a trivial cache for overload operator resolution.
13999 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14001 * decl.cs: If possible, use lookuptypedirect here. We can only do
14002 this if there is no `.' after the namespace. Avoids using
14003 LookupType, which does lots of slow processing.
14004 (FindNestedType) New method, does what it says :-).
14005 * namespace.cs: use LookupTypeDirect.
14006 * rootcontext.cs: use membercache, if possible.
14007 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
14009 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14012 According to the spec,
14014 In a member access of the form E.I, if E is a single identifier,
14015 and if the meaning of E as a simple-name (§7.5.2) is a constant,
14016 field, property, localvariable, or parameter with the same type as
14017 the meaning of E as a type-name (§3.8), then both possible
14018 meanings of E are permitted.
14020 We did not check that E as a simple-name had the same type as E as
14023 This trivial check gives us 5-7% on bootstrap time.
14025 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14027 * expression.cs (Invocation.OverloadResolve): Avoid the
14028 use of hashtables and boxing here by allocating on demand.
14030 2004-05-30 Martin Baulig <martin@ximian.com>
14032 * rootcontext.cs (RootContext.LookupType): Don't cache things if
14033 we're doing a silent lookup. Don't try to lookup nested types in
14034 TypeManager.object_type (thanks to Ben Maurer).
14036 2004-05-30 Martin Baulig <martin@ximian.com>
14038 Committing a patch from Ben Maurer.
14040 * rootcontext.cs (RootContext.LookupType): Cache negative results.
14042 2004-05-29 Martin Baulig <martin@ximian.com>
14044 * class.cs (IMethodData.ShouldIgnore): New method.
14046 * typemanager.cs (TypeManager.MethodFlags): Don't take a
14047 `Location' argument, we don't need it anywhere. Use
14048 `IMethodData.ShouldIgnore ()' instead of
14049 `MethodData.GetMethodFlags ()'.
14050 (TypeManager.AddMethod): Removed.
14051 (TypeManager.AddMethod2): Renamed to AddMethod.
14053 2004-05-29 Martin Baulig <martin@ximian.com>
14055 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
14057 * convert.cs (Convert.ImplicitReferenceConversion): If we're
14058 converting from a class type S to an interface type and we already
14059 have an object on the stack, don't box it again. Fixes #52578.
14061 2004-05-29 Martin Baulig <martin@ximian.com>
14063 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
14064 Added support for `params' parameters. Fixes #59267.
14066 2004-05-29 Martin Baulig <martin@ximian.com>
14068 * literal.cs (NullPointer): Provide a private .ctor which sets
14069 `type' to TypeManager.object_type. Fixes #59048.
14071 2004-05-29 Martin Baulig <martin@ximian.com>
14073 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
14074 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
14076 * ecore.cs (EventExpr.instance_expr): Make the field private.
14078 2004-05-26 Marek Safar <marek.safar@seznam.cz>
14080 Fixed bug #50080 & cs0214-2.cs
14081 * expression.cs (Cast.DoResolve): Check unsafe context here.
14083 * statement.cs (Resolve.DoResolve): Likewise.
14085 2004-05-26 Martin Baulig <martin@ximian.com>
14087 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
14089 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
14090 (RootContext.LookupType): Pass down the `silent' flag.
14092 2004-05-25 Martin Baulig <martin@ximian.com>
14095 (MethodGroupExpr.IdenticalTypeName): New public property.
14096 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
14097 expression actually refers to a type.
14099 2004-05-25 Martin Baulig <martin@ximian.com>
14101 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
14102 for #56176 and made it actually work.
14104 2004-05-25 Martin Baulig <martin@ximian.com>
14106 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
14107 (FieldExpr, PropertyExpr): Override and implement
14108 CacheTemporaries. Fixes #52279.
14110 2004-05-25 Miguel de Icaza <miguel@ximian.com>
14112 * location.cs: In the new compiler listing a file twice is a
14113 warning, not an error.
14115 2004-05-24 Martin Baulig <martin@ximian.com>
14117 * enum.cs (Enum.DefineType): For the `BaseType' to be a
14118 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
14120 2004-05-24 Martin Baulig <martin@ximian.com>
14122 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
14123 walking the `using' list. Fixes #53921.
14125 2004-05-24 Martin Baulig <martin@ximian.com>
14127 * const.cs (Const.LookupConstantValue): Added support for
14128 EmptyCast's; fixes #55251.
14130 2004-05-24 Martin Baulig <martin@ximian.com>
14132 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
14133 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
14134 which does the CS0135 check. The reason is that we first need to
14135 check whether the variable actually exists.
14137 2004-05-24 Martin Baulig <martin@ximian.com>
14139 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
14140 than RootContext.LookupType() to find the explicit interface
14141 type. Fixes #58584.
14143 2004-05-24 Raja R Harinath <rharinath@novell.com>
14145 * Makefile: Simplify. Use executable.make.
14146 * mcs.exe.sources: New file. List of sources of mcs.exe.
14148 2004-05-24 Anders Carlsson <andersca@gnome.org>
14152 Use the invariant culture when doing String.Compare for CLS case
14155 2004-05-23 Martin Baulig <martin@ximian.com>
14157 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
14158 don't have any dots. Fixes #52622, added cs0246-8.cs.
14160 * namespace.cs (NamespaceEntry.Lookup): Likewise.
14162 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14164 * class.cs (MemberBase.Define): Reuse MemberType member for
14165 resolved type. Other methods can use it too.
14167 2004-05-23 Martin Baulig <martin@ximian.com>
14169 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
14170 the variable also exists in the current block (otherwise, we need
14171 to report a CS0103). Fixes #58670.
14173 2004-05-23 Martin Baulig <martin@ximian.com>
14175 * flowanalysis.cs (Reachability.Reachable): Compute this
14176 on-the-fly rather than storing it as a field.
14178 2004-05-23 Martin Baulig <martin@ximian.com>
14180 * flowanalysis.cs (Reachability.And): Manually compute the
14181 resulting `barrier' from the reachability.
14183 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14186 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
14187 instance of ObsoleteAttribute when symbol is obsolete.
14190 (IMethodData): Extended interface for ObsoleteAttribute support.
14192 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14194 * attribute.cs: Fix bug #55970
14196 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14200 (GetObsoleteAttribute): New method. Creates the instance of
14202 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
14203 ObsoleteAttribute when member is obsolete.
14204 (AttributeTester.Report_ObsoleteMessage): Common method for
14205 Obsolete error/warning reporting.
14208 (TypeContainer.base_classs_type): New member for storing parent type.
14211 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
14212 for this MemberCore.
14214 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14216 * attribute.cs, const.cs: Fix bug #58590
14218 2004-05-21 Martin Baulig <martin@ximian.com>
14220 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
14221 out parameters if the end of the method is unreachable. Fixes
14224 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14226 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
14227 Hari was right, why extra method.
14229 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14231 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
14233 2004-05-20 Martin Baulig <martin@ximian.com>
14235 Merged this back from gmcs to keep the differences to a minumum.
14237 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
14238 instead of a Declspace.
14239 (Attribute.ResolveType): Likewise.
14240 (Attributes.Search): Likewise.
14241 (Attributes.Contains): Likewise.
14242 (Attributes.GetClsCompliantAttribute): Likewise.
14244 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
14246 (MethodData.ApplyAttributes): Take an EmitContext instead of a
14249 2004-05-19 Marek Safar <marek.safar@seznam.cz>
14251 Fix bug #58688 (MCS does not report error when the same attribute
14254 * attribute.cs (Attribute.Emit): Distinction between null and default.
14256 2004-05-19 Raja R Harinath <rharinath@novell.com>
14258 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
14259 of a top-level attribute without an attribute target.
14260 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
14262 (Attribute.Conditional_GetConditionName),
14263 (Attribute.Obsolete_GetObsoleteMessage): Update.
14264 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
14265 part of ScanForIndexerName.
14266 (Attribute.CanIgnoreInvalidAttribute): New function.
14267 (Attribute.ScanForIndexerName): Move to ...
14268 (Attributes.ScanForIndexerName): ... here.
14269 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
14270 (Attributes.Search): New internal variant that can choose not to
14271 complain if types aren't resolved. The original signature now
14273 (Attributes.GetClsCompliantAttribute): Use internal variant, with
14274 complaints suppressed.
14275 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
14276 only if it not useful.
14277 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
14278 top-level for attributes that are shared between the assembly
14279 and a top-level class.
14280 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
14281 * class.cs: Update to reflect changes.
14282 (DefineIndexers): Fuse loops.
14283 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
14284 a couple more variants of attribute names.
14286 2004-05-18 Marek Safar <marek.safar@seznam.cz>
14288 Fix bug #52585 (Implemented explicit attribute declaration)
14291 (Attributable.ValidAttributeTargets): New abstract method. It gets
14292 list of valid attribute targets for explicit target declaration.
14293 (Attribute.Target): It holds target itself.
14294 (AttributeSection): Removed.
14295 (Attribute.CheckTargets): New method. It checks whether attribute
14296 target is valid for the current element.
14299 (EventProperty): New class. For events that are declared like
14300 property (with add and remove accessors).
14301 (EventField): New class. For events that are declared like field.
14304 * cs-parser.jay: Implemented explicit attribute target declaration.
14306 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
14307 Override ValidAttributeTargets.
14310 (ReturnParameter): Class for applying custom attributes on
14312 (ParameterAtribute): New class. Class for applying custom
14313 attributes on the parameter type.
14315 2004-05-17 Miguel de Icaza <miguel@ximian.com>
14317 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
14320 (Method): Allow UNSAFE here.
14322 * modifiers.cs: Support unsafe reporting.
14324 2004-05-17 Marek Safar <marek.safar@seznam.cz>
14326 * decl.cs: Fix bug #58478.
14328 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14330 * statement.cs: When checking for unreachable code on an EmptyStatement,
14331 set the location. Fixes bug #58488.
14333 2004-05-13 Miguel de Icaza <miguel@ximian.com>
14335 * driver.cs: Add -pkg handling.
14337 From Gonzalo: UseShelLExecute=false
14339 2004-05-12 Marek Safar <marek.safar@seznam.cz>
14342 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
14344 (Attribute.IsClsCompliaceRequired): Moved to base for better
14346 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
14347 when attribute is AttributeUsageAttribute.
14348 (Attribute.GetValidTargets): Simplified.
14349 (Attribute.GetAttributeUsage): New method returns AttributeUsage
14350 attribute for this type.
14351 (Attribute.ApplyAttributes): Method renamed to Emit and make
14353 (GlobalAttributeSection): New class for special handling of global
14354 attributes (assembly, module).
14355 (AttributeSection.Emit): New method.
14357 * class.cs: Implemented Attributable abstract methods.
14358 (MethodCore.LabelParameters): Moved to Parameter class.
14359 (Accessor): Is back simple class.
14360 (PropertyMethod): Implemented Attributable abstract class.
14361 (DelegateMethod): Implemented Attributable abstract class.
14362 (Event): New constructor for disctintion between normal Event
14363 and Event with accessors.
14365 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
14367 * codegen.cs, const.cs, decl.cs, delegate.cs:
14368 (CommonAssemblyModulClass): Implemented Attributable abstract class
14371 * enum.cs: Implement IAttributeSupport interface.
14372 (EnumMember): New class for emum members. Implemented Attributable
14376 (ParameterBase): Is abstract.
14377 (ReturnParameter): New class for easier [return:] attribute handling.
14379 * typemanager.cs: Removed builder_to_attr.
14381 2004-05-11 Raja R Harinath <rharinath@novell.com>
14384 * attribute.cs (Attribute.GetPositionalValue): New function.
14385 * class.cs (TypeContainer.VerifyMembers): New function.
14386 (TypeContainer.Emit): Use it.
14387 (ClassOrStruct): New base class for Class and Struct.
14388 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
14389 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
14391 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
14392 then each non-static field should have a FieldOffset attribute.
14393 Otherwise, none of the fields should have a FieldOffset attribute.
14394 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
14395 and FieldOffset attributes.
14396 * typemanager.cs (TypeManager.struct_layout_attribute_type)
14397 (TypeManager.field_offset_attribute_type): New core types.
14398 (TypeManager.InitCoreTypes): Initialize them.
14400 2004-05-11 Michal Moskal <malekith@pld-linux.org>
14402 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
14403 Return correct type.
14406 2004-05-09 Miguel de Icaza <miguel@ximian.com>
14408 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
14409 be implicitly converted to ulong.
14411 * expression.cs: The logic for allowing operator &, | and ^ worked
14412 was wrong, it worked before because we did not report an error in
14413 an else branch. Fixes 57895.
14415 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
14416 allow volatile fields to be reference types.
14418 2004-05-07 Miguel de Icaza <miguel@ximian.com>
14420 * driver.cs: Add support for /debug-
14422 2004-05-07 Raja R Harinath <rharinath@novell.com>
14424 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
14425 Add a 'complain' parameter to silence errors.
14426 (Attribute.Resolve): Update to changes. Put in sanity check to catch
14427 silently overlooked type-resolutions.
14428 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
14429 to reflect changes.
14430 (Attributes.Search): New function.
14431 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
14432 (Attributes.GetAttributeFullName): Remove hack.
14433 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
14434 Update to reflect changes.
14435 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14436 Use Attributes.Search instead of nested loops.
14438 2004-05-07 Marek Safar <marek.safar@seznam.cz>
14441 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
14442 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
14443 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
14445 * report.cs: (Report.Warning): Renamed to Warning_T because of
14446 parameter collision.
14448 2004-05-05 Raja R Harinath <rharinath@novell.com>
14450 * expression.cs (MemberAccess.ResolveMemberAccess):
14451 Exit with non-zero status after Report.Error.
14452 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
14454 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
14456 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14458 * support.cs: Don't hang when the file is empty.
14460 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14462 * support.cs: In SeekableStreamReader, compute the preamble size of the
14463 underlying stream. Position changes should take into account that initial
14466 2004-05-03 Todd Berman <tberman@sevenl.net>
14468 * driver.cs: remove unused GetSysVersion function.
14470 2004-05-03 Todd Berman <tberman@sevenl.net>
14472 * driver.cs: Remove the hack from saturday, as well as the hack
14473 from jackson (LoadAssemblyFromGac), also adds the CWD to the
14474 link_paths to get that bit proper.
14476 2004-05-01 Todd Berman <tberman@sevenl.net>
14478 * driver.cs: Try a LoadFrom before a Load, this checks the current
14479 path. This is currently a bug in mono that is be fixed, however, this
14480 provides a workaround for now. This will be removed when the bug
14483 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
14485 * CryptoConvert.cs: Updated to latest version. Fix issue with
14486 incomplete key pairs (#57941).
14488 2004-05-01 Todd Berman <tberman@sevenl.net>
14490 * driver.cs: Remove '.' from path_chars, now System.* loads properly
14493 2004-04-30 Jackson Harper <jackson@ximian.com>
14495 * codegen.cs: Open keys readonly.
14497 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14499 * typemanager.cs: don't report cyclic struct layout when a struct
14500 contains 2 or more fields of the same type. Failed for Pango.AttrShape
14501 which has 2 Pango.Rectangle fields.
14503 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
14505 * expression.cs: Handle IntPtr comparisons with IL code
14506 rather than a method call.
14508 2004-04-29 Martin Baulig <martin@ximian.com>
14510 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
14511 the list of PropertyInfo's in class hierarchy and find the
14512 accessor. Fixes #56013.
14514 2004-04-29 Martin Baulig <martin@ximian.com>
14516 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
14518 2004-04-29 Martin Baulig <martin@ximian.com>
14520 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14522 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
14524 2004-04-29 Martin Baulig <martin@ximian.com>
14526 * class.cs (ConstructorInitializer.Resolve): Check whether the
14527 parent .ctor is accessible. Fixes #52146.
14529 2004-04-29 Martin Baulig <martin@ximian.com>
14531 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14533 * statement.cs (Using.EmitLocalVariableDecls): Use
14534 TypeManager.idisposable_type, not typeof (IDisposable).
14535 (Foreach.EmitCollectionForeach): Added support for valuetypes.
14537 2004-04-29 Martin Baulig <martin@ximian.com>
14539 * class.cs (Event.Define): Don't emit the field and don't set
14540 RTSpecialName and SpecialName for events on interfaces. Fixes
14543 2004-04-29 Raja R Harinath <rharinath@novell.com>
14545 Refactor Attribute.ApplyAttributes.
14546 * attribute.cs (Attributable): New base class for objects that can
14547 have Attributes applied on them.
14548 (Attribute): Make AttributeUsage fields public.
14549 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
14550 (Attribute.IsInternalCall): New property.
14551 (Attribute.UsageAttr): Convert to a public read-only property.
14552 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
14553 (Attribute.ResolveType, Attribute.Resolve)
14554 (Attribute.ScanForIndexerName): Update to reflect changes.
14555 (Attribute.CheckAttributeTarget): Re-format.
14556 (Attribute.ApplyAttributes): Refactor, to various
14557 Attributable.ApplyAttributeBuilder methods.
14558 * decl.cs (MemberCore): Make Attributable.
14559 * class.cs (Accessor): Make Attributable.
14560 (MethodData.ApplyAttributes): Use proper attribute types, not
14562 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
14563 (TypeContainer.ApplyAttributeBuilder)
14564 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
14565 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
14566 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
14567 (Operator.ApplyAttributeBuilder): New factored-out methods.
14568 * const.cs (Const.ApplyAttributeBuilder): Likewise.
14569 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
14570 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
14571 * parameter.cs (ParameterBase): New Attributable base class
14572 that can also represent Return types.
14573 (Parameter): Update to the changes.
14575 2004-04-29 Jackson Harper <jackson@ximian.com>
14577 * driver.cs: Prefer the corlib system version when looking for
14578 assemblies in the GAC. This is still a hack, but its a better hack
14581 2004-04-29 Marek Safar <marek.safar@seznam.cz>
14583 * decl.cs, enum.cs: Improved error 3005 reporting.
14585 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
14586 (related_symbols): New private member for list of symbols
14587 related to reported error/warning.
14589 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
14591 2004-04-29 Martin Baulig <martin@ximian.com>
14593 * ecore.cs (Expression.Constantify): If we're an enum and
14594 TypeManager.TypeToCoreType() doesn't give us another type, use
14595 t.UnderlyingSystemType. Fixes #56178.
14597 2004-04-29 Martin Baulig <martin@ximian.com>
14599 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
14600 interfaces and for each interface, only add members directly
14601 declared in that interface. Fixes #53255.
14603 2004-04-28 Martin Baulig <martin@ximian.com>
14605 * expression.cs (ConditionalLogicalOperator): Use a temporary
14606 variable for `left' to avoid that we evaluate it more than once;
14609 2004-04-28 Martin Baulig <martin@ximian.com>
14611 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
14614 2004-04-28 Martin Baulig <martin@ximian.com>
14616 * statement.cs (LocalInfo.Resolve): Check whether the type is not
14619 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
14620 whether the type is not void (CS1547).
14622 2004-04-28 Martin Baulig <martin@ximian.com>
14624 * expression.cs (Unary.DoResolveLValue): Override this and report
14625 CS0131 for anything but Operator.Indirection.
14627 2004-04-28 Martin Baulig <martin@ximian.com>
14629 Committing a patch from Ben Maurer; see bug #50820.
14631 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14634 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14637 2004-04-28 Martin Baulig <martin@ximian.com>
14639 Committing a patch from Ben Maurer; see bug #50820.
14641 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14644 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14647 2004-04-28 Martin Baulig <martin@ximian.com>
14649 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
14650 (Block.AddLabel): Call DoLookupLabel() to only search in the
14653 2004-04-28 Martin Baulig <martin@ximian.com>
14655 * cfold.cs (ConstantFold.BinaryFold): Added special support for
14656 comparing StringConstants and NullLiterals in Equality and Inequality.
14658 2004-04-28 Jackson Harper <jackson@ximian.com>
14660 * driver.cs: Attempt to load referenced assemblies from the
14661 GAC. This is the quick and dirty version of this method that
14662 doesnt take into account versions and just takes the first
14663 canidate found. Will be good enough for now as we will not have more
14664 then one version installed into the GAC until I update this method.
14666 2004-04-28 Martin Baulig <martin@ximian.com>
14668 * typemanager.cs (TypeManager.CheckStructCycles): New public
14669 static method to check for cycles in the struct layout.
14671 * rootcontext.cs (RootContext.PopulateTypes): Call
14672 TypeManager.CheckStructCycles() for each TypeContainer.
14673 [Note: We only need to visit each type once.]
14675 2004-04-28 Martin Baulig <martin@ximian.com>
14677 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
14679 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
14680 success and added `out object value'. Use a `bool resolved' field
14681 to check whether we've already been called rather than
14682 `ConstantValue != null' since this breaks for NullLiterals.
14684 2004-04-28 Raja R Harinath <rharinath@novell.com>
14686 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
14687 setting of this flag, since the 'set' method may be non-public.
14689 2004-04-28 Raja R Harinath <rharinath@novell.com>
14691 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
14692 check on current_vector.Block.
14694 2004-04-27 Martin Baulig <martin@ximian.com>
14696 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
14697 a field initializer. Fixes #56459.
14699 2004-04-27 Martin Baulig <martin@ximian.com>
14701 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
14702 we're not attempting to use an indexer. Fixes #52154.
14704 2004-04-27 Martin Baulig <martin@ximian.com>
14706 * statement.cs (Return): Don't create a return label if we don't
14707 need it; reverts my change from January 20th. Thanks to Ben
14710 2004-04-27 Martin Baulig <martin@ximian.com>
14712 According to the spec, `goto' can only leave a nested scope, but
14715 * statement.cs (Block.LookupLabel): Only lookup in the current
14716 block, don't recurse into parent or child blocks.
14717 (Block.AddLabel): Check in parent and child blocks, report
14718 CS0140/CS0158 if we find a duplicate.
14719 (Block): Removed this indexer for label lookups.
14720 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
14721 this already does the error reporting for us.
14724 (FlowBranching.UsageVector.Block): New public variable; may be null.
14725 (FlowBranching.CreateSibling): Added `Block' argument.
14726 (FlowBranching.LookupLabel): New public virtual method. Lookup a
14727 label for the target of a `goto' and check whether we're not
14728 leaving a `finally'.
14730 2004-04-27 Martin Baulig <martin@ximian.com>
14732 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14733 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
14736 2004-04-27 Martin Baulig <martin@ximian.com>
14738 * statement.cs (Block.AddLabel): Also check for implicit blocks
14739 and added a CS0158 check.
14741 2004-04-27 Martin Baulig <martin@ximian.com>
14743 * flowanalysis.cs (FlowBranchingLoop): New class.
14744 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
14745 UsageVector's instead of an ArrayList.
14746 (FlowBranching.Label): Likewise.
14747 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
14748 (FlowBranching.AddBreakVector): New method.
14750 2004-04-27 Miguel de Icaza <miguel@ximian.com>
14752 * attribute.cs: Small regression fix: only convert the type if we
14753 the type is different, fixes System.Drawing build.
14755 2004-04-27 Martin Baulig <martin@ximian.com>
14757 * attribute.cs (Attribute.Resolve): If we have a constant value
14758 for a named field or property, implicity convert it to the correct
14761 2004-04-27 Raja R Harinath <rharinath@novell.com>
14763 * statement.cs (Block.Block): Implicit blocks share
14764 'child_variable_names' fields with parent blocks.
14765 (Block.AddChildVariableNames): Remove.
14766 (Block.AddVariable): Mark variable as "used by a child block" in
14767 every surrounding block.
14768 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
14769 been used in a child block, complain about violation of "Invariant
14770 meaning in blocks" rule.
14771 * cs-parser.jay (declare_local_variables): Don't use
14772 AddChildVariableNames.
14773 (foreach_statement): Don't create an implicit block: 'foreach'
14774 introduces a scope.
14776 2004-04-23 Miguel de Icaza <miguel@ximian.com>
14778 * convert.cs (ImplicitNumericConversion): 0 is also positive when
14779 converting from 0L to ulong. Fixes 57522.
14781 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14783 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
14784 derived class hides via 'new' keyword field from base class (test-242.cs).
14785 TODO: Handle this in the more general way.
14787 * class.cs (CheckBase): Ditto.
14789 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14791 * decl.cs (caching_flags): New member for storing cached values
14793 (MemberCore.Flags): New enum where bit flags for caching_flags
14795 (MemberCore.cls_compliance): Moved to caching_flags.
14796 (DeclSpace.Created): Moved to caching_flags.
14798 * class.cs: Use caching_flags instead of DeclSpace.Created
14800 2004-04-21 Miguel de Icaza <miguel@ximian.com>
14802 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
14803 if we are only a derived class, not a nested class.
14805 * typemanager.cs: Same as above, but do this at the MemberLookup
14806 level (used by field and methods, properties are handled in
14807 PropertyExpr). Allow for the qualified access if we are a nested
14810 2004-04-21 Marek Safar <marek.safar@seznam.cz>
14812 * class.cs: Refactoring.
14813 (IMethodData): New inteface; Holds links to parent members
14814 to avoid member duplication (reduced memory allocation).
14815 (Method): Implemented IMethodData interface.
14816 (PropertyBase): New inner classes for get/set methods.
14817 (PropertyBase.PropertyMethod): Implemented IMethodData interface
14818 (Event): New inner classes for add/remove methods.
14819 (Event.DelegateMethod): Implemented IMethodData interface.
14821 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
14822 EmitContext (related to class.cs refactoring).
14824 2004-04-21 Raja R Harinath <rharinath@novell.com>
14826 * delegate.cs (Delegate.VerifyApplicability): If the number of
14827 arguments are the same as the number of parameters, first try to
14828 verify applicability ignoring any 'params' modifier on the last
14832 2004-04-16 Raja R Harinath <rharinath@novell.com>
14834 * class.cs (TypeContainer.AddIndexer): Use
14835 'ExplicitInterfaceName' to determine if interface name was
14836 explicitly specified. 'InterfaceType' is not initialized at this time.
14837 (TypeContainer.DefineIndexers): Remove use of temporary list. The
14838 Indexers array is already in the required order. Initialize
14839 'IndexerName' only if there are normal indexers.
14840 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
14841 (TypeContainer.Emit): Emit DefaultMember attribute only if
14842 IndexerName is initialized.
14845 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
14847 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
14850 2004-04-15 Raja R Harinath <rharinath@novell.com>
14852 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
14856 * attribute.cs (Attribute.Resolve): Check for duplicate named
14860 2004-04-15 Miguel de Icaza <miguel@ximian.com>
14862 * iterators.cs (MarkYield): track whether we are in an exception,
14863 and generate code accordingly. Use a temporary value to store the
14864 result for our state.
14866 I had ignored a bit the interaction of try/catch with iterators
14867 since their behavior was not entirely obvious, but now it is
14868 possible to verify that our behavior is the same as MS .NET 2.0
14872 2004-04-14 Miguel de Icaza <miguel@ximian.com>
14874 * iterators.cs: Avoid creating temporaries if there is no work to
14877 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
14878 Enumerations, use TypeManager.EnumToUnderlying and call
14881 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
14884 (This.Emit): Use EmitContext.EmitThis to emit our
14887 (This.EmitAssign): Ditto.
14889 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
14890 codepaths, we will move all the functionality into
14893 (FieldExpr.EmitAssign): Ditto.
14895 This fixes several hidden bugs that I uncovered while doing a code
14896 review of this today.
14898 * codegen.cs (EmitThis): reworked so the semantics are more clear
14899 and also support value types "this" instances.
14901 * iterators.cs: Changed so that for iterators in value types, we
14902 do not pass the value type as a parameter.
14904 Initialization of the enumerator helpers is now done in the caller
14905 instead of passing the parameters to the constructors and having
14906 the constructor set the fields.
14908 The fields have now `assembly' visibility instead of private.
14910 2004-04-11 Miguel de Icaza <miguel@ximian.com>
14912 * expression.cs (Argument.Resolve): Check if fields passed as ref
14913 or out are contained in a MarshalByRefObject.
14915 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
14916 another compiler type.
14918 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
14920 * class.cs (Indexer.Define): use the new name checking method.
14921 Also, return false on an error.
14922 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
14923 (is_identifier_[start/part]_character): make static.
14925 2004-04-10 Miguel de Icaza <miguel@ximian.com>
14927 * expression.cs (Binary.ResolveOperator): Do no append strings
14928 twice: since we can be invoked more than once (array evaluation)
14929 on the same concatenation, take care of this here. Based on a fix
14930 from Ben (bug #56454)
14932 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
14934 * codegen.cs: Fix another case where CS1548 must be reported (when
14935 delay-sign isn't specified and no private is available #56564). Fix
14936 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
14937 error when MCS is used on the MS runtime and we need to delay-sign
14938 (which seems unsupported by AssemblyBuilder - see #56621).
14940 2004-04-08 Marek Safar <marek.safar@seznam.cz>
14942 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
14943 (TypeManager.ComputeNamespaces): Faster implementation for
14946 * compiler.csproj: Updated AssemblyName to mcs.
14948 2004-04-07 Miguel de Icaza <miguel@ximian.com>
14950 * rootcontext.cs: Add new types to the boot resolution.
14952 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
14953 MulticastDelegate is not allowed.
14955 * typemanager.cs: Add new types to lookup: System.TypedReference
14958 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
14959 check for TypedReference or ArgIterator, they are not allowed.
14961 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
14962 makes us properly catch 1510 in some conditions (see bug 56016 for
14965 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
14967 * CryptoConvert.cs: update from corlib version
14970 2004-04-05 Miguel de Icaza <miguel@ximian.com>
14972 * class.cs (Indexer.Define): Check indexername declaration
14974 2004-04-05 Marek Safar <marek.safar@seznam.cz>
14976 * attribute.cs (IsClsCompliant): Fixed problem with handling
14977 all three states (compliant, not-compliant, undetected).
14979 2004-03-30 Marek Safar <marek.safar@seznam.cz>
14981 * attribute.cs (Attribute): Location is now public.
14982 (Resolve): Store resolved arguments (pos_values) in attribute class.
14983 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
14984 (GetClsCompliantAttributeValue): New method that gets
14985 CLSCompliantAttribute value.
14986 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
14987 if exists else null.
14988 (AttributeTester): New class for CLS-Compliant verification routines.
14990 * class.cs (Emit): Add CLS-Compliant verification.
14991 (Method.GetSignatureForError): Implemented.
14992 (Constructor.GetSignatureForError): Implemented
14993 (Constructor.HasCompliantArgs): Returns if constructor has
14994 CLS-Compliant arguments.
14995 (Constructor.Emit): Override.
14996 (Construcor.IsIdentifierClsCompliant): New method; For constructors
14997 is needed to test only parameters.
14998 (FieldBase.GetSignatureForError): Implemented.
14999 (TypeContainer): New member for storing base interfaces.
15000 (TypeContainer.FindMembers): Search in base interfaces too.
15002 * codegen.cs (GetClsComplianceAttribute): New method that gets
15003 assembly or module CLSCompliantAttribute value.
15004 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
15006 (ModuleClass.Emit): Add error 3012 test.
15008 * const.cs (Emit): Override and call base for CLS-Compliant tests.
15010 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
15011 state for all decl types.
15012 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
15013 if CLS-Compliant tests are required.
15014 (IsClsCompliaceRequired): New method. Analyze whether code
15015 must be CLS-Compliant.
15016 (IsExposedFromAssembly): New method. Returns true when MemberCore
15017 is exposed from assembly.
15018 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
15019 value or gets cached value.
15020 (HasClsCompliantAttribute): New method. Returns true if MemberCore
15021 is explicitly marked with CLSCompliantAttribute.
15022 (IsIdentifierClsCompliant): New abstract method. This method is
15023 used to testing error 3005.
15024 (IsIdentifierAndParamClsCompliant): New method. Common helper method
15025 for identifier and parameters CLS-Compliant testing.
15026 (VerifyClsCompliance): New method. The main virtual method for
15027 CLS-Compliant verifications.
15028 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
15029 null. I don't know why is null (too many public members !).
15030 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
15031 and get value of first CLSCompliantAttribute that found.
15033 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
15034 (VerifyClsCompliance): Override and add extra tests.
15036 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
15037 clscheck- disable CLS-Compliant verification event if assembly is has
15038 CLSCompliantAttribute(true).
15040 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
15041 ApllyAttribute is now called in emit section as in the other cases.
15042 Possible future Emit integration.
15043 (IsIdentifierClsCompliant): New override.
15044 (VerifyClsCompliance): New override.
15045 (GetEnumeratorName): Returns full enum name.
15047 * parameter.cs (GetSignatureForError): Implemented.
15049 * report.cs (WarningData): New struct for Warning message information.
15050 (LocationOfPreviousError): New method.
15051 (Warning): New method. Reports warning based on the warning table.
15052 (Error_T): New method. Reports error based on the error table.
15054 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
15055 verifications are done here.
15057 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
15059 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
15060 CLSCompliantAttribute.
15061 (all_imported_types): New member holds all imported types from other
15063 (LoadAllImportedTypes): New method fills static table with exported types
15064 from all referenced assemblies.
15065 (Modules): New property returns all assembly modules.
15067 2004-03-30 Miguel de Icaza <miguel@ximian.com>
15069 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
15070 throwing a parser error.
15072 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
15073 which removes the hardcoded get_/set_ prefixes for properties, as
15074 IL allows for the properties to be named something else.
15078 * expression.cs: Do not override operand before we know if it is
15079 non-null. Fix 56207
15081 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15083 * typemanager.cs: support for pinned variables.
15085 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15087 * decl.cs, typemanager.cs: Avoid using an arraylist
15088 as a buffer if there is only one result set.
15090 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15092 * expression.cs: Make sure you cant call a static method
15093 with an instance expression, bug #56174.
15095 2004-03-29 Miguel de Icaza <miguel@ximian.com>
15097 * class.cs (IsDuplicateImplementation): Improve error reporting to
15098 flag 663 (method only differs in parameter modifier).
15100 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
15101 in preprocessor directives.
15103 * location.cs (LookupFile): Allow for the empty path.
15105 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
15106 better approach for some of that patch, but its failing with the
15107 CharSet enumeration. For now try/catch will do.
15109 * typemanager.cs: Do not crash if a struct does not have fields.
15112 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15114 * expression.cs: cs0213, cant fix a fixed expression.
15117 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15119 * cs-parser.jay: detect invalid embeded statements gracefully.
15122 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15124 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
15127 the invocation type may not be a subclass of the tye of the item/
15128 The type of the item must be a subclass of the invocation item.
15133 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
15135 * attribute.cs: Added methods to get a string and a bool from an
15136 attribute. Required to information from AssemblyKeyFileAttribute,
15137 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
15138 * codegen.cs: Modified AssemblyName creation to include support for
15139 strongnames. Catch additional exceptions to report them as CS1548.
15140 * compiler.csproj: Updated include CryptoConvert.cs.
15141 * compiler.csproj.user: Removed file - user specific configuration.
15142 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
15143 Mono.Security assembly. The original class is maintained and tested in
15144 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
15145 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
15146 like CSC 8.0 (C# v2) supports.
15147 * Makefile: Added CryptoConvert.cs to mcs sources.
15148 * rootcontext.cs: Added new options for strongnames.
15150 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
15152 * driver.cs: For --expect-error, report error code `2'
15153 if the program compiled with no errors, error code `1' if
15154 it compiled with an error other than the one expected.
15156 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
15158 * compiler.csproj: Updated for Visual Studio .NET 2003.
15159 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
15160 * compiler.sln: Updated for Visual Studio .NET 2003.
15162 2004-03-24 Ravi Pratap M <ravi@ximian.com>
15164 * expression.cs: Fix bug #47234. We basically need to apply the
15165 rule that we prefer the conversion of null to a reference type
15166 when faced with a conversion to 'object' (csc behaviour).
15168 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15170 * statement.cs: Shorter form for foreach, eliminates
15171 a local variable. r=Martin.
15173 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15175 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
15176 checks if we can use brtrue/brfalse to test for 0.
15177 * expression.cs: use the above in the test for using brtrue/brfalse.
15178 cleanup code a bit.
15180 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15182 * expression.cs: Rewrite string concat stuff. Benefits:
15184 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
15185 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
15186 rather than a concat chain.
15188 * typemanager.cs: Add lookups for more concat overloads.
15190 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15192 * expression.cs: Emit shorter il code for array init.
15209 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
15211 * statement.cs: Before, two switch blocks would be merged if the
15212 total size of the blocks (end_item - begin_item + 1) was less than
15213 two times the combined sizes of the blocks.
15215 Now, it will only merge if after the merge at least half of the
15220 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
15222 * class.cs : csc build fix for GetMethods(). See bug #52503.
15224 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
15226 * expression.cs: Make sure fp comparisons work with NaN.
15227 This fixes bug #54303. Mig approved this patch a long
15228 time ago, but we were not able to test b/c the runtime
15231 2004-03-19 Miguel de Icaza <miguel@ximian.com>
15233 * ecore.cs (TypExpr.GetHashCode): implement this overload.
15235 2004-03-19 Martin Baulig <martin@ximian.com>
15237 * class.cs (MemberCore.IsDuplicateImplementation): Report the
15238 error here and not in our caller.
15240 2004-03-19 Martin Baulig <martin@ximian.com>
15242 * interface.cs: Completely killed this file.
15243 (Interface): We're now a TypeContainer and live in class.cs.
15245 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
15246 argument; we're now also called for interfaces.
15247 (TypeContainer.DefineMembers): Allow this method being called
15249 (TypeContainer.GetMethods): New public method; formerly known as
15250 Interface.GetMethod(). This is used by PendingImplementation.
15251 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
15252 it's now private and non-static.
15253 (Interface): Moved this here; it's now implemented similar to
15255 (Method, Property, Event, Indexer): Added `bool is_interface'
15256 argument to their .ctor's.
15257 (MemberBase.IsInterface): New public field.
15259 * cs-parser.jay: Create normal Method, Property, Event, Indexer
15260 instances instead of InterfaceMethod, InterfaceProperty, etc.
15261 (opt_interface_base): Removed; we now use `opt_class_base' instead.
15262 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
15264 2004-03-19 Martin Baulig <martin@ximian.com>
15266 * class.cs (MethodCore.IsDuplicateImplementation): New private
15267 method which does the CS0111 checking.
15268 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
15269 Use IsDuplicateImplementation().
15271 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
15273 * decl.cs (FindMemberToOverride): New method to find the correct
15274 method or property to override in the base class.
15276 - Make Method/Property use the above method to find the
15277 version in the base class.
15278 - Remove the InheritableMemberSignatureCompare as it is now
15281 This patch makes large code bases much faster to compile, as it is
15282 O(n) rather than O(n^2) to do this validation.
15284 Also, it fixes bug 52458 which is that nested classes are not
15285 taken into account when finding the base class member.
15287 Reviewed/Approved by Martin.
15289 2004-03-17 Marek Safar <marek.safar@seznam.cz>
15291 * interface.cs: In all interface classes removed redundant
15292 member initialization.
15294 2004-03-16 Martin Baulig <martin@ximian.com>
15296 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
15298 2004-03-15 Miguel de Icaza <miguel@ximian.com>
15300 * decl.cs (DefineTypeAndParents): New helper method to define a
15301 type's containers before the type itself is defined; This is a
15302 bug exposed by the recent changes to Windows.Forms when an
15303 implemented interface was defined inside a class that had not been
15306 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
15308 (Check): Loop correctly to report errors modifiers
15309 (UNSAFE was not in the loop, since it was the same as TOP).
15311 * interface.cs: Every interface member now takes a ModFlags,
15312 instead of a "is_new" bool, which we set on the base MemberCore.
15314 Every place where we called "UnsafeOk" in the interface, now we
15315 call the proper member (InterfaceMethod.UnsafeOK) instead to get
15316 the unsafe settings from the member declaration instead of the
15317 container interface.
15319 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
15321 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
15322 `set_indexer_name' to the pending bits (one per type).
15324 We fixed a bug today that was picking the wrong method to
15325 override, since for properties the existing InterfaceMethod code
15326 basically ignored the method name. Now we make sure that the
15327 method name is one of the valid indexer names.
15329 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
15331 * support.cs (SeekableStreamReader): Keep track of stream byte
15332 positions and don't mix them with character offsets to the buffer.
15334 Patch from Gustavo Giráldez
15336 2004-03-15 Marek Safar <marek.safar@seznam.cz>
15338 * interface.cs (InterfaceSetGetBase): Removed double member
15339 initialization, base class does it as well.
15341 2004-03-13 Martin Baulig <martin@ximian.com>
15343 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
15344 when compiling corlib.
15346 2004-03-13 Miguel de Icaza <miguel@ximian.com>
15348 * convert.cs (ExplicitConversion): We were reporting an error on
15349 certain conversions (object_type source to a value type, when the
15350 expression was `null') before we had a chance to pass it through
15351 the user defined conversions.
15353 * driver.cs: Replace / and \ in resource specifications to dots.
15356 * class.cs: Add check for duplicate operators. Fixes 52477
15358 2004-03-11 Miguel de Icaza <miguel@ximian.com>
15360 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
15361 that are in the middle of the statements, not only at the end.
15364 * class.cs (TypeContainer.AddField): No longer set the
15365 `HaveStaticConstructor' flag, now we call it
15366 `UserDefineStaticConstructor' to diferentiate the slightly
15367 semantic difference.
15369 The situation is that we were not adding BeforeFieldInit (from
15370 Modifiers.TypeAttr) to classes that could have it.
15371 BeforeFieldInit should be set to classes that have no static
15376 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
15378 And most importantly Zoltan's comment:
15380 http://bugzilla.ximian.com/show_bug.cgi?id=44229
15382 "I think beforefieldinit means 'it's ok to initialize the type sometime
15383 before its static fields are used', i.e. initialization does not need
15384 to be triggered by the first access to the type. Setting this flag
15385 helps the JIT to compile better code, since it can run the static
15386 constructor at JIT time, and does not need to generate code to call it
15387 (possibly lots of times) at runtime. Unfortunately, mcs does not set
15388 this flag for lots of classes like String.
15390 csc sets this flag if the type does not have an explicit static
15391 constructor. The reasoning seems to be that if there are only static
15392 initalizers for a type, and no static constructor, then the programmer
15393 does not care when this initialization happens, so beforefieldinit
15396 This bug prevents the AOT compiler from being usable, since it
15397 generates so many calls to mono_runtime_class_init that the AOT code
15398 is much slower than the JITted code. The JITted code is faster,
15399 because it does not generate these calls if the vtable is type is
15400 already initialized, which is true in the majority of cases. But the
15401 AOT compiler can't do this."
15403 2004-03-10 Miguel de Icaza <miguel@ximian.com>
15405 * class.cs (MethodData.Emit): Refactor the code so symbolic
15406 information is generated for destructors; For some reasons we
15407 were taking a code path that did not generate symbolic information
15410 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
15412 * class.cs: Create a Constructor.CheckBase method that
15413 takes care of all validation type code. The method
15414 contains some code that was moved from Define.
15416 It also includes new code that checks for duplicate ctors.
15417 This fixes bug #55148.
15419 2004-03-09 Joshua Tauberer <tauberer@for.net>
15421 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
15422 a { ... }-style array creation invokes EmitStaticInitializers
15423 which is not good for reference-type arrays. String, decimal
15424 and now null constants (NullCast) are not counted toward
15425 static initializers.
15427 2004-03-05 Martin Baulig <martin@ximian.com>
15429 * location.cs (SourceFile.HasLineDirective): New public field;
15430 specifies whether the file contains or is referenced by a "#line"
15432 (Location.DefineSymbolDocuments): Ignore source files which
15433 either contain or are referenced by a "#line" directive.
15435 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
15437 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
15438 direct access to our parent, so check the method inline there.
15440 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
15442 * expression.cs (Invocation.EmitCall): Miguel's last commit
15443 caused a regression. If you had:
15448 In Foo the implict this would be null.
15450 2004-02-27 Miguel de Icaza <miguel@ximian.com>
15452 * expression.cs (Invocation.EmitCall): If the method is not
15453 virtual, do not emit a CallVirt to it, use Call.
15455 * typemanager.cs (GetFullNameSignature): Improve the method to
15456 cope with ".ctor" and replace it with the type name.
15458 * class.cs (ConstructorInitializer.Resolve): Now the method takes
15459 as an argument the ConstructorBuilder where it is being defined,
15460 to catch the recursive constructor invocations.
15462 2004-02-26 Miguel de Icaza <miguel@ximian.com>
15464 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
15465 routines to check if a type is an enumerable/enumerator allow
15466 classes that implement the IEnumerable or IEnumerator interfaces.
15468 * class.cs (Property, Operator): Implement IIteratorContainer, and
15469 implement SetYields.
15471 (Property.Define): Do the block swapping for get_methods in the
15472 context of iterators. We need to check if Properties also
15473 include indexers or not.
15475 (Operator): Assign the Block before invoking the
15476 OperatorMethod.Define, so we can trigger the Iterator code
15479 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
15480 Property and Operator classes are not created when we parse the
15481 declarator but until we have the block completed, so we use a
15482 singleton SimpleIteratorContainer.Simple to flag whether the
15483 SetYields has been invoked.
15485 We propagate this setting then to the Property or the Operator to
15486 allow the `yield' to function.
15488 2004-02-25 Marek Safar <marek.safar@seznam.cz>
15490 * codegen.cs: Implemented attribute support for modules.
15491 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
15492 Assembly/Module functionality.
15494 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
15495 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
15496 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
15498 2004-02-16 Marek Safar <marek.safar@seznam.cz>
15500 * interface.cs (FindMembers): The operation is performed on all base
15501 interfaces and not only on the first. It is required for future CLS Compliance patch.
15503 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
15505 * statement.cs, codegen.cs:
15506 This patch deals with patterns such as:
15508 public class List : IEnumerable {
15510 public MyEnumerator GetEnumerator () {
15511 return new MyEnumerator(this);
15514 IEnumerator IEnumerable.GetEnumerator () {
15518 public struct MyEnumerator : IEnumerator {
15523 Before, there were a few things we did wrong:
15524 1) we would emit callvirt on a struct, which is illegal
15525 2) we emited ldarg when we needed to emit ldarga
15526 3) we would mistakenly call the interface methods on an enumerator
15527 type that derived from IEnumerator and was in another assembly. For example:
15529 public class MyEnumerator : IEnumerator
15531 Would have the interface methods called, even if there were public impls of the
15532 method. In a struct, this lead to invalid IL code.
15534 2004-02-11 Marek Safar <marek.safar@seznam.cz>
15536 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
15539 * delegate.cs (Define): Fixed crash when delegate type is undefined.
15541 2004-02-11 Miguel de Icaza <miguel@ximian.com>
15543 * cs-parser.jay: Fix small regression: we were not testing V2
15544 compiler features correctly.
15546 * interface.cs: If the emit context is null, then create one
15548 2004-02-09 Marek Safar <marek.safar@seznam.cz>
15550 * decl.cs (GetSignatureForError): New virtual method to get full name
15551 for error messages.
15553 * attribute.cs (IAttributeSupport): New interface for attribute setting.
15554 Now it is possible to rewrite ApplyAttributes method to be less if/else.
15556 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
15557 Duplicated members and code in these classes has been removed.
15558 Better encapsulation in these classes.
15560 2004-02-07 Miguel de Icaza <miguel@ximian.com>
15562 * assign.cs (Assign.DoResolve): When dealing with compound
15563 assignments, there is a new rule in ECMA C# 2.4 (might have been
15564 there before, but it is documented here) that states that in:
15568 If b is of type int, and the `op' is a shift-operator, then the
15569 above is evaluated as:
15573 * expression.cs (Binary.ResolveOperator): Instead of testing for
15574 int/uint/long/ulong, try to implicitly convert to any of those
15575 types and use that in pointer arithmetic.
15577 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
15578 method to print information for from the type, not from the
15579 null-method we were given.
15581 2004-02-01 Duncan Mak <duncan@ximian.com>
15583 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
15584 parsing for cmd, fixes bug #53694.
15586 2004-02-04 Marek Safar <marek.safar@seznam.cz>
15588 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
15589 in the member name duplication tests. Property and operator name duplication
15590 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
15592 2004-02-03 Marek Safar <marek.safar@seznam.cz>
15594 * interface.cs (PopulateMethod): Fixed crash when interface method
15595 returns not existing type (error test cs0246-3.cs).
15597 2004-02-02 Ravi Pratap M <ravi@ximian.com>
15599 * cs-parser.jay (interface_accessors): Re-write actions to also
15600 store attributes attached to get and set methods. Fix spelling
15603 (inteface_property_declaration): Modify accordingly.
15605 (InterfaceAccessorInfo): New helper class to store information to pass
15606 around between rules that use interface_accessors.
15608 * interface.cs (Emit): Apply attributes on the get and set
15609 accessors of properties and indexers too.
15611 * attribute.cs (ApplyAttributes): Modify accordingly to use the
15612 right MethodBuilder when applying attributes to the get and set accessors.
15614 2004-01-31 Miguel de Icaza <miguel@ximian.com>
15616 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
15618 2004-01-26 Miguel de Icaza <miguel@ximian.com>
15620 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
15622 2004-01-25 Miguel de Icaza <miguel@ximian.com>
15624 * cs-parser.jay: Remove YIELD token, instead use the new grammar
15625 changes that treat `yield' specially when present before `break'
15626 or `return' tokens.
15628 * cs-tokenizer.cs: yield is no longer a keyword.
15630 2004-01-23 Marek Safar <marek.safar@seznam.cz>
15632 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
15633 setting for default constructors.
15634 For default constructors are almost every time set wrong Modifier. The
15635 generated IL code has been alright. But inside mcs this values was
15636 wrong and this was reason why several of my CLS Compliance tests
15639 2004-01-22 Martin Baulig <martin@ximian.com>
15641 * cs-parser.jay (namespace_or_type_name): Return an Expression,
15642 not a QualifiedIdentifier. This is what `type_name_expression'
15643 was previously doing.
15644 (type_name_expression): Removed; the code is now in
15645 `namespace_or_type_name'.
15646 (qualified_identifier): Removed, use `namespace_or_type_name'
15648 (QualifiedIdentifier): Removed this class.
15650 2004-01-22 Martin Baulig <martin@ximian.com>
15652 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
15653 not a string as alias name.
15655 2004-01-21 Miguel de Icaza <miguel@ximian.com>
15657 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
15658 #52730 bug, and instead compute correctly the need to use a
15659 temporary variable when requesting an address based on the
15660 static/instace modified of the field and the constructor.
15662 2004-01-21 Martin Baulig <martin@ximian.com>
15664 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
15665 class and namespace before looking up aliases. Fixes #52517.
15667 2004-01-21 Martin Baulig <martin@ximian.com>
15669 * flowanalysis.cs (UsageVector.Merge): Allow variables being
15670 assinged in a 'try'; fixes exception4.cs.
15672 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15673 * class.cs : Implemented parameter-less constructor for TypeContainer
15675 * decl.cs: Attributes are now stored here. New property OptAttributes
15677 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
15679 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
15681 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15683 * typemanager.cs (CSharpSignature): Now reports also inner class name.
15684 (CSharpSignature): New method for indexer and property signature.
15686 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15688 * pending.cs (IsVirtualFilter): Faster implementation.
15690 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15692 * typemanager.cs: Avoid inclusion of same assembly more than once.
15694 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15696 * cs-parser.jay: Fixed problem where the last assembly attribute
15697 has been applied also to following declaration (class, struct, etc.)
15699 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15701 * class.cs: Added error CS0538, CS0539 reporting.
15702 Fixed crash on Microsoft runtime when field type is void.
15704 * cs-parser.jay: Added error CS0537 reporting.
15706 * pending.cs: Added error CS0535 reporting.
15707 Improved error report for errors CS0536, CS0534.
15709 2004-01-20 Miguel de Icaza <miguel@ximian.com>
15711 Merge a few bits from the Anonymous Method MCS tree.
15713 * statement.cs (ToplevelBlock): New class for toplevel methods,
15714 will hold anonymous methods, lifted variables.
15716 * cs-parser.jay: Create toplevel blocks for delegates and for
15717 regular blocks of code.
15719 2004-01-20 Martin Baulig <martin@ximian.com>
15721 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
15722 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
15723 and `NeedExplicitReturn'; added `IsLastStatement'.
15724 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
15725 have a `ReturnLabel' or we're not unreachable.
15727 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
15728 child's reachability; don't just override ours with it. Fixes
15729 #58058 (lluis's example).
15730 (FlowBranching): Added public InTryOrCatch(), InCatch(),
15731 InFinally(), InLoop(), InSwitch() and
15732 BreakCrossesTryCatchBoundary() methods.
15734 * statement.cs (Return): Do all error checking in Resolve().
15735 Unless we are the last statement in a top-level block, always
15736 create a return label and jump to it.
15737 (Break, Continue): Do all error checking in Resolve(); also make
15738 sure we aren't leaving a `finally'.
15739 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
15740 statement in a top-level block.
15741 (Block.Flags): Added `IsDestructor'.
15742 (Block.IsDestructor): New public property.
15744 2004-01-20 Martin Baulig <martin@ximian.com>
15746 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
15748 2004-01-20 Martin Baulig <martin@ximian.com>
15750 * statement.cs (Statement.ResolveUnreachable): New public method.
15751 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
15752 (Block.Resolve): Resolve unreachable statements.
15754 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15756 * expression.cs: We need to fix the case where we do
15757 not have a temp variable here.
15759 * assign.cs: Only expression compound assignments need
15760 temporary variables.
15762 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15764 * flowanalysis.cs: Reduce memory allocation in a few ways:
15765 - A block with no variables should not allocate a bit
15767 - A method with no out parameters does not need any tracking
15768 for assignment of the parameters, so we need not allocate
15771 public readonly Type[] VariableTypes;
15772 public readonly string[] VariableNames;
15773 Are redundant. The data is already stored in the variable
15774 map, so we need not allocate another array for it.
15775 - We need to add alot of checks for if (params | locals) == null
15776 due to the first two changes.
15778 2004-01-18 Miguel de Icaza <miguel@ximian.com>
15780 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
15781 implement IMemoryLocation, we store a copy on a local variable and
15782 take the address of it. Patch from Benjamin Jemlich
15784 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
15785 to use a special "type_name_expression" rule which reduces the
15786 number of "QualifiedIdentifier" classes created, and instead
15787 directly creates MemberAccess expressions.
15789 2004-01-17 Miguel de Icaza <miguel@ximian.com>
15791 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
15792 that fixes #52853. Null literal assignment to ValueType
15794 * class.cs (MethodData.Emit): Instead of checking the name of the
15795 method to determine if its a destructor, create a new derived
15796 class from Method called Destructor, and test for that.
15798 * cs-parser.jay: Create a Destructor object instead of a Method.
15800 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
15804 2004-01-16 Miguel de Icaza <miguel@ximian.com>
15806 * expression.cs (Binary.ResolveOperator): Perform an implicit
15807 conversion from MethodGroups to their delegate types on the
15808 Addition operation.
15810 * delegate.cs: Introduce a new class DelegateCreation that is the
15811 base class for `NewDelegate' and `ImplicitDelegateCreation',
15812 factor some code in here.
15814 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
15815 conversion from MethodGroups to compatible delegate types.
15817 * ecore.cs (Expression.Resolve): Do not flag error 654
15818 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
15819 we allow conversions from MethodGroups to delegate types now.
15821 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
15822 assignments in v2 either.
15824 2004-01-10 Miguel de Icaza <miguel@ximian.com>
15826 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
15827 static read-only fields in ctors.
15829 Applied patch from Benjamin Jemlich
15831 * expression.cs (UnaryMutator): Avoid leaking local variables.
15833 2004-01-09 Miguel de Icaza <miguel@ximian.com>
15835 * cs-tokenizer.cs (IsCastToken): Allow the various native types
15836 here to return true, as they can be used like this:
15838 (XXX) int.MEMBER ()
15840 Fixed 49836 and all the other dups
15842 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
15844 * driver.cs: Implement /win32res and /win32icon.
15846 2004-01-08 Miguel de Icaza <miguel@ximian.com>
15848 * cs-parser.jay: Add a rule to improve error handling for the
15849 common mistake of placing modifiers after the type.
15851 2004-01-07 Miguel de Icaza <miguel@ximian.com>
15853 * cs-parser.jay (interface_event_declaration): Catch
15854 initialization of events on interfaces, and report cs0068
15856 * cs-parser.jay (interface_event_declaration): Catch
15857 initialization of events.
15859 * ecore.cs: Better report missing constructors.
15861 * expression.cs (Binary.ResolveOperator): My previous bug fix had
15862 the error reporting done in the wrong place. Fix.
15864 * expression.cs (Binary.ResolveOperator): Catch the
15865 operator + (E x, E y) error earlier, and later allow for implicit
15866 conversions in operator +/- (E e, U x) from U to the underlying
15869 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
15870 52596, if the container class is abstract, the default constructor
15871 is protected otherwise its public (before, we were always public).
15873 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
15876 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
15877 Jemlich that fixes bug #52597, MCS was generating invalid code for
15878 idisposable structs. Thanks to Ben for following up with this
15881 2004-01-06 Miguel de Icaza <miguel@ximian.com>
15883 * driver.cs: Allow assemblies without code to be generated, fixes
15886 2004-01-07 Nick Drochak <ndrochak@gol.com>
15888 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
15890 2004-01-05 Miguel de Icaza <miguel@ximian.com>
15892 * cs-parser.jay: Add rules to improve error reporting if fields or
15893 methods are declared at the namespace level (error 116)
15895 * Add rules to catch event add/remove
15897 2004-01-04 David Sheldon <dave-mono@earth.li>
15899 * expression.cs: Added matching ")" to error message for
15902 2004-01-03 Todd Berman <tberman@gentoo.org>
15904 * ecore.cs, attribute.cs:
15905 Applying fix from #52429.
15907 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15909 * ecore.cs, expression.cs, statement.cs:
15910 Total rewrite of how we handle branching. We
15911 now handle complex boolean expressions with fewer
15912 jumps. As well if (x == 0) no longer emits a ceq.
15914 if (x is Foo) is much faster now, because we generate
15917 Overall, we get a pretty big improvement on our benchmark
15918 tests. The code we generate is smaller and more readable.
15920 I did a full two-stage bootstrap. The patch was reviewed
15921 by Martin and Miguel.
15923 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15925 * cs-parser.jay: Make primary_expression not take a QI.
15926 we dont need this because the member_access rule covers
15927 us here. So we replace the rule with just IDENTIFIER.
15929 This has two good effects. First, we remove a s/r conflict.
15930 Second, we allocate many fewer QualifiedIdentifier objects.
15932 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15934 * attribute.cs: Handle MarshalAs attributes as pseudo, and
15935 set the correct information via SRE. This prevents
15936 hanging on the MS runtime. Fixes #29374.
15938 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15940 * convert.cs: correctly handle conversions to value types
15941 from Enum and ValueType as unboxing conversions.
15943 Fixes bug #52569. Patch by Benjamin Jemlich.
15945 2004-01-02 Ravi Pratap <ravi@ximian.com>
15947 * expression.cs (BetterConversion): Prefer int -> uint
15948 over int -> ulong (csc's behaviour). This fixed bug #52046.
15950 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
15952 * decl.cs (MemberCache.FindMembers): now returns a
15955 * typemanager.cs: In general, go with with ^^.
15956 (CopyNewMethods): take an IList.
15957 (RealMemberLookup): Only allocate an arraylist
15958 if we copy from two sets of methods.
15960 This change basically does two things:
15961 1) Fewer array lists allocated due to CopyNewMethods.
15962 2) the explicit cast in MemberList costed ALOT.
15964 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
15966 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
15967 a hashtable to avoid needless string allocations when an identifier is
15968 used more than once (the common case).
15970 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15972 * pending.cs: MS's TypeBuilder.GetInterfaces ()
15973 is broken, it will not return anything. So, we
15974 have to use the information we have in mcs to
15977 * typemanager.cs: Add a cache for GetInterfaces,
15978 since this will now be used more often (due to ^^)
15980 (GetExplicitInterfaces) New method that gets the
15981 declared, not effective, interfaces on a type
15982 builder (eg, if you have interface IFoo, interface
15983 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
15986 This patch makes MCS able to bootstrap itself on
15989 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15991 * expression.cs: Remove the Nop's that Miguel put
15994 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15996 * report.cs, codegen.cs: Give the real stack trace to
15997 the error when an exception is thrown.
15999 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16001 * decl.cs: only allocate hashtables for ifaces if
16004 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16006 * expression.cs: fix the error from cs0121-2.cs
16007 (a parent interface has two child interfaces that
16008 have a function with the same name and 0 params
16009 and the function is called through the parent).
16011 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
16013 * class.cs, rootcontext.cs, typmanager.cs: do not
16016 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
16018 * codegen.cs: remove stack for the ec flow branching.
16019 It is already a linked list, so no need.
16021 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
16023 * Makefile: Allow custom profiler here.
16025 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
16027 * typemanager.cs (LookupType):
16028 - Use a static char [], because split takes
16029 a param array for args, so it was allocating
16031 - Do not store true in a hashtable, it boxes.
16033 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
16035 * flowanalysis.cs: bytify common enums.
16037 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16039 * modifiers.cs: Add a new set of flags for the
16040 flags allowed on explicit interface impls.
16041 * cs-parser.jay: catch the use of modifiers in
16042 interfaces correctly.
16043 * class.cs: catch private void IFoo.Blah ().
16045 All related to bug #50572.
16047 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16049 * decl.cs: Rewrite the consistant accessability checking.
16050 Accessability is not linear, it must be implemented in
16051 a tableish way. Fixes #49704.
16053 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16055 * expression.cs: Handle negation in a checked context.
16056 We must use subtraction from zero. Fixes #38674.
16058 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
16060 * class.cs: Ignore static void main in DLLs.
16061 * rootcontext.cs: Handle the target type here,
16062 since we are have to access it from class.cs
16063 * driver.cs: account for the above.
16065 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
16067 * report.cs: Give line numbers and files if available.
16069 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
16071 * driver.cs: Implement /addmodule.
16073 * typemanager.cs: Change 'modules' field so it now contains Modules not
16076 2003-12-20 Martin Baulig <martin@ximian.com>
16078 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
16079 (FieldBase.IsAssigned): Removed this field.
16080 (FieldBase.SetAssigned): New public method.
16081 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
16083 2003-12-20 Martin Baulig <martin@ximian.com>
16085 * expression.cs (LocalVariableReference.DoResolve): Don't set
16086 `vi.Used' if we're called from DoResolveLValue().
16088 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
16089 returns the usage vector it just merged into the current one -
16090 pass this one to UsageWarning().
16091 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
16092 of the `EmitContext', don't call this recursively on our children.
16094 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
16096 * driver.cs: Implement /target:module.
16098 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
16100 * support.cs (CharArrayHashtable): New helper class.
16102 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
16103 char arrays, not strings, so we can avoid creating a string in
16104 consume_identifier if the identifier is a keyword.
16106 2003-12-16 Martin Baulig <martin@ximian.com>
16108 * statement.cs (LocalInfo.Assigned): Removed this property.
16109 (LocalInfo.Flags): Removed `Assigned'.
16110 (LocalInfo.IsAssigned): New public method; takes the EmitContext
16111 and uses flow analysis.
16112 (Block.UsageWarning): Made this method private.
16113 (Block.Resolve): Call UsageWarning() if appropriate.
16115 * expression.cs (LocalVariableReference.DoResolve): Always set
16116 LocalInfo.Used here.
16118 2003-12-13 Martin Baulig <martin@ximian.com>
16120 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
16121 any value here; we're now using flow analysis to figure out
16122 whether a statement/block returns a value.
16124 2003-12-13 Martin Baulig <martin@ximian.com>
16126 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
16128 (FlowBranching.MergeFinally): Don't call
16129 `branching.CheckOutParameters()' here, this is called in
16131 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
16132 when adding the `finally' vector.
16134 2003-12-13 Martin Baulig <martin@ximian.com>
16137 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
16138 actually work and also fix #48962.
16140 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
16142 * decl.cs: Do not check System.Object for nested types,
16143 since we know it does not have any. Big bang for buck:
16146 Run 1: 8.35 seconds
16147 Run 2: 8.32 seconds
16148 corlib: 17.99 seconds
16150 Run 1: 8.17 seconds
16151 Run 2: 8.17 seconds
16152 corlib: 17.39 seconds
16154 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
16156 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
16157 time we are returning 0 members, so we save alot here.
16159 2003-12-11 Martin Baulig <martin@ximian.com>
16161 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
16162 `MergeChild()', also just take the `FlowBranching' as argument;
16163 call Merge() on it and return the result.
16164 (FlowBranching.Merge): We don't need to do anything if we just
16167 2003-12-11 Martin Baulig <martin@ximian.com>
16169 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
16170 them in an `ArrayList' to reduce memory usage. Thanks to Ben
16171 Maurer for this idea.
16173 2003-12-11 Martin Baulig <martin@ximian.com>
16175 * flowanalysis.cs (MergeResult): This class is now gone; we now
16176 use the `UsageVector' for this. The reason for this is that if a
16177 branching just has one sibling, we don't need to "merge" them at
16178 all - that's the next step to do.
16179 (FlowBranching.Merge): We now return a `UsageVector' instead of a
16182 2003-12-11 Martin Baulig <martin@ximian.com>
16184 Reworked flow analyis and made it more precise and bug-free. The
16185 most important change is that we're now using a special `Reachability'
16186 class instead of having "magic" meanings of `FlowReturns'. I'll
16187 do some more cleanups and optimizations and also add some more
16188 documentation this week.
16190 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
16191 largely reworked this class.
16192 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
16193 the new `Reachability' class instead of having "magic" values here.
16194 (FlowBranching): We're now using an instance of `Reachability'
16195 instead of having separate `Returns', `Breaks' etc. fields.
16197 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
16198 based on flow analysis; ignore the return value of block.Emit ().
16200 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
16202 * driver.cs typemanager.cs: Find the mono extensions to corlib even
16203 if they are private.
16205 2003-12-09 Martin Baulig <martin@ximian.com>
16207 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
16208 call them directly on the UsageVector.
16210 2003-12-09 Martin Baulig <martin@ximian.com>
16212 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
16213 Changed return type from `FlowReturns' to `Reachability'.
16215 2003-12-09 Martin Baulig <martin@ximian.com>
16217 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
16218 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
16219 `Reachable' fields with a single `Reachability' one.
16221 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16223 * class.cs (FindMembers): Remove foreach's.
16228 Run 1: 8.74 seconds
16229 Run 2: 8.71 seconds
16232 Run 1: 8.64 seconds
16233 Run 2: 8.58 seconds
16236 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16241 This patch does a few things:
16242 1. EmptyStatement is now a singleton, so it is never reallocated.
16243 2. All blah is EmptyStatement constructs have been changed to
16244 blah == EmptyStatement.Value, which is much faster and valid
16245 now that EmptyStatement is a singleton.
16246 3. When resolving a block, rather than allocating a new array for
16247 the non-empty statements, empty statements are replaced with
16248 EmptyStatement.Value
16249 4. Some recursive functions have been made non-recursive.
16250 Mainly the performance impact is from (3), however (1) and (2) are needed for
16251 this to work. (4) does not make a big difference in normal situations, however
16252 it makes the profile look saner.
16257 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16258 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16259 Total memory allocated: 56397 KB
16262 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
16263 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
16264 Total memory allocated: 55666 KB
16266 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16268 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
16269 than the hashtable in a hashtable version
16271 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
16272 we always end up concating a string. This results in a huge perf
16273 loss, because many strings have to be tracked by the GC. In this
16274 patch, we first use a hashtable that works with two keys, so that
16275 the strings do not need to be concat'ed.
16279 Run 1: 8.74 seconds
16280 Run 2: 8.71 seconds
16283 Run 1: 8.65 seconds
16284 Run 2: 8.56 seconds
16286 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16288 * Makefile: Add a new target `do-time' that does a quick and simple
16289 profile, leaving easy to parse output.
16291 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
16293 * codegen.cs (Init): Create the dynamic assembly with
16294 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
16296 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
16298 * support.cs: Make the PtrHashtable use only one
16299 instance of its comparer.
16301 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
16303 * typemanager.cs: Fix lookup of GetNamespaces.
16305 2003-11-29 Miguel de Icaza <miguel@ximian.com>
16307 * expression.cs: Removed redundant line.
16309 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
16310 ArrayLists, use for loops with bounds.
16312 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
16315 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
16316 arraylists, use for loop with bounds.
16318 The above three changes give us a 0.071 second performance
16319 improvement out of 3.294 seconds down to 3.223. On my machine
16320 the above changes reduced the memory usage by 1,387 KB during
16321 compiler bootstrap.
16323 * cs-parser.jay (QualifiedIdentifier): New class used to represent
16324 QualifiedIdentifiers. Before we created a new string through
16325 concatenation, and mostly later on, the result would be
16326 manipulated by DecomposeQI through string manipulation.
16328 This reduced the compiler memory usage for bootstrapping from
16329 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
16330 compile times in 0.05 seconds.
16332 2003-11-28 Dick Porter <dick@ximian.com>
16334 * support.cs: Do string compares with the Invariant culture.
16342 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
16343 the comparison is done with the Invariant culture.
16345 2003-11-27 Miguel de Icaza <miguel@ximian.com>
16347 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
16348 GetEnumerator method.
16350 (ProbeCollectionType): Iterate starting at the most specific type
16351 upwards looking for a GetEnumerator
16353 * expression.cs: Shift count can be up to 31 for int/uint and 63
16356 2003-11-26 Miguel de Icaza <miguel@ximian.com>
16358 * statement.cs (Block.LookupLabel): Also look for the label on the
16359 children blocks. Use a hash table to keep track of visited
16362 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
16363 we actually did transform the other operand, otherwise fall back
16364 to the common codepath that casts to long.
16366 * cs-tokenizer.cs: Use the same code pattern as the int case.
16367 Maybe I should do the parsing myself, and avoid depending on the
16368 Parse routines to get this done.
16370 2003-11-25 Miguel de Icaza <miguel@ximian.com>
16372 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16373 which fixes bug 51347. This time test it.
16375 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
16376 attributes for example can not tell the difference between these.
16377 The difference was only a syntax feature of the language.
16379 * attribute.cs: Apply attributes to delegates.
16381 * delegate.cs: Call the apply attributes method.
16383 2003-11-24 Miguel de Icaza <miguel@ximian.com>
16385 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
16386 comparing 0 vs Byte.MinValue, not the value
16388 (ImplicitConversionRequired): When reporting a conversion error,
16389 use error 31 to print out the constant error instead of the
16392 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16393 which fixes bug 51347.
16395 2003-11-22 Miguel de Icaza <miguel@ximian.com>
16397 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
16398 which fixes the -warnaserror command line option.
16400 2003-11-21 Miguel de Icaza <miguel@ximian.com>
16402 * cfold.cs (DoNumericPromotions): During constant folding of
16403 additions on UIntConstant, special case intconstants with
16404 IntConstants like we do on the expression binary operator.
16406 2003-11-12 Miguel de Icaza <miguel@ximian.com>
16408 * convert.cs (ImplicitReferenceConversion): We were missing a case
16409 (System.Enum are not value types or class types, so we need to
16410 classify them separatedly).
16412 * driver.cs: We do not support error 2007.
16414 2003-11-12 Jackson Harper <jackson@ximian.com>
16416 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
16417 system directory. Also use the full file name so users can
16418 libraries names mscorlib-o-tron.dll in a non system dir.
16420 2003-11-10 Martin Baulig <martin@ximian.com>
16422 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
16423 (TypeManager.InitCoreTypes): Initialize them here, but instead of
16424 calling `ResolveType()' on them, directly assign their `Type'.
16426 2003-11-08 Martin Baulig <martin@ximian.com>
16428 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
16429 return value and the `out parent' parameter.
16430 (TypeContainer.DefineType): Moved the CS0644 check into
16431 GetClassBases(). Don't pass the interface types to the
16432 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
16433 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
16435 * ecore.cs (TypeExpr.IsAttribute): New property.
16436 (TypeExpr.GetInterfaces): New method.
16438 * interface.cs (Interface.GetInterfaceTypeByName): Return a
16439 TypeExpr instead of a Type.
16440 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
16441 (Interface.DefineType): Don't pass the interface types to the
16442 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
16443 them later and then call `TypeBulider.AddInterfaceImplementation()'.
16445 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
16446 instead of a `Type[]'.
16447 (TypeManager.RegisterBuilder): Likewise.
16448 (TypeManager.AddUserInterface): Likewise.
16449 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
16450 `Type[]' and also return a `TypeExpr[]'.
16451 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
16453 2003-11-08 Martin Baulig <martin@ximian.com>
16455 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
16458 2003-11-08 Martin Baulig <martin@ximian.com>
16460 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
16461 TypeManager.ResolveExpressionTypes().
16463 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
16464 instead of an Expression.
16465 (TypeExpr): This is now an abstract base class for `TypeExpression'.
16466 (TypeExpression): New public class; formerly known as `TypeExpr'.
16468 * expression.cs (ComposedCast): Derive from TypeExpr.
16470 * typemanager.cs (TypeManager.system_*_expr): These are now
16471 TypExpr's instead of Expression's.
16472 (TypeManager.ResolveExpressionTypes): New public static function;
16473 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
16476 2003-11-06 Miguel de Icaza <miguel@ximian.com>
16478 * expression.cs (New.DoResolve): Do not dereference value that
16479 might be a null return.
16481 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
16482 sure that the constant value has the right type. Fixes an
16483 unreported bug, similar to 50425.
16485 * const.cs (Const.LookupConstantValue): Call
16486 ImplicitStandardConversionExists before doing a conversion to
16487 avoid havng the TypeManager.ChangeType do conversions.
16489 Reduced the number of casts used
16491 (Const.ChangeType): New routine to enable reuse of the constant
16492 type changing code from statement.
16494 * typemanager.cs (ChangeType): Move common initialization to
16495 static global variables.
16499 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
16500 every value type to go through, even if it was void. Fix that.
16502 * cs-tokenizer.cs: Use is_identifier_start_character on the start
16503 character of the define, and the is_identifier_part_character for
16504 the rest of the string.
16506 2003-11-05 Miguel de Icaza <miguel@ximian.com>
16508 * expression.cs (UnaryMutator.EmitCode): When I updated
16509 LocalVariableReference.DoResolve, I overdid it, and dropped an
16510 optimization done on local variable references.
16512 2003-11-04 Miguel de Icaza <miguel@ximian.com>
16514 * ecore.cs: Convert the return from Ldlen into an int.
16516 2003-10-20 Miguel de Icaza <miguel@ximian.com>
16518 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
16519 the accessibility, this is a special case for toplevel non-public
16520 classes (internal for instance).
16522 2003-10-20 Nick Drochak <ndrochak@gol.com>
16524 * ecore.cs: Fix typo and build. Needed another right paren.
16526 2003-10-19 Miguel de Icaza <miguel@ximian.com>
16528 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
16529 `internal' case regular and protected, but not allowing protected
16530 to be evaluated later. Bug 49840
16532 2003-10-15 Miguel de Icaza <miguel@ximian.com>
16534 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
16535 to kb.Nlast, and not the kb.nFirst to isolate the switch
16538 Extract the underlying type, so enumerations of long/ulong are
16539 treated like long/ulong.
16541 2003-10-14 Miguel de Icaza <miguel@ximian.com>
16543 * expression.cs (New): Overload the meaning of RequestedType to
16544 track the possible creation of the NewDelegate type, since
16545 DoResolve is invoked more than once for new constructors on field
16548 See bugs: #48800 and #37014
16550 * cs-parser.jay (declare_local_constants): Take an arraylist
16551 instead of a single constant.
16553 (local_constant_declaration): It should take a
16554 constant_declarators, not a constant_declarator. Fixes 49487
16556 * convert.cs: Fix error report.
16558 2003-10-13 Jackson Harper <jackson@ximian.com>
16560 * typemanager.cs (TypeToCoreType): Add float and double this fixes
16563 2003-10-09 Martin Baulig <martin@ximian.com>
16565 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
16567 (MethodCore.DoDefineParameters): Removed the TypeContainer
16568 argument; use the DeclSpace which was passed to the .ctor instead.
16569 (MethodCore.CheckParameter): Take a DeclSpace instead of a
16570 TypeContainer; we only need a DeclSpace here.
16572 2003-10-09 Martin Baulig <martin@ximian.com>
16574 * class.cs (MethodData): Added additional `DeclSpace ds' argument
16576 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
16577 EmitContext's .ctor.
16579 2003-10-09 Martin Baulig <martin@ximian.com>
16581 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
16582 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
16583 AsAccessible(), moved them as well.
16585 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
16587 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
16589 * cs-parser.jay : Renamed yyName to yyNames related to jay.
16591 2003-10-07 Miguel de Icaza <miguel@ximian.com>
16593 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
16594 generation for >=, as spotted by Paolo, bug 48679.
16595 Patch from David Waite.
16597 * cs-tokenizer.cs: Add handling for #pragma.
16599 * cs-parser.jay: Allow for both yield and yield return in the
16600 syntax. The anti-cobolization of C# fight will go on!
16602 * class.cs (TypeBuilder.DefineType): Catch error condition here
16603 (Parent.DefineType erroring out and returning null).
16605 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16606 coping with enumerations variables, we were mistakenly processing
16607 them as a regular value type instead of built-in types. Fixes the
16610 * typemanager.cs (IsBuiltinOrEnum): New method.
16612 2003-09-30 Miguel de Icaza <miguel@ximian.com>
16614 * cs-parser.jay: Upgrade: yield now needs the return clause.
16616 2003-09-19 Martin Baulig <martin@ximian.com>
16618 * decl.cs (MemberCache.SetupCacheForInterface): Take a
16619 `MemberCache parent' argument. Normally, an interface doesn't
16620 have a parent type except System.Object, but we use this in gmcs
16621 for generic type parameters.
16623 2003-09-18 Martin Baulig <martin@ximian.com>
16625 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
16626 on `type.IsInterface'; don't check whether the type has a parent
16627 to determine whether it's an interface.
16629 2003-09-15 Martin Baulig <martin@ximian.com>
16631 * class.cs (TypeContainer.DefineType): Added an error flag to
16632 avoid reporting duplicate CS0146's ("class definition is
16635 * driver.cs (Driver.MainDriver): Abort if
16636 RootContext.ResolveTree() reported any errors.
16638 2003-09-07 Martin Baulig <martin@ximian.com>
16640 * report.cs (Error, Warning): Added overloaded versions which take
16641 a `params object[] args' and call String.Format().
16643 2003-09-07 Martin Baulig <martin@ximian.com>
16645 * decl.cs (DeclSpace..ctor): Don't call
16646 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
16647 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
16648 (DeclSpace.RecordDecl): New method.
16650 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
16652 2003-09-02 Ravi Pratap <ravi@ximian.com>
16654 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
16655 value attributes to be applied to ParameterBuilders.
16657 * class.cs (MethodCore.LabelParameters): Make static and more
16658 generic so that it can be used from other places - like interface
16659 methods, for instance.
16661 * interface.cs (Interface.Emit): Call LabelParameters before
16662 emitting attributes on the InterfaceMethod.
16664 2003-08-26 Martin Baulig <martin@ximian.com>
16666 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
16667 resolving aliases; fixes #47927.
16669 2003-08-26 Martin Baulig <martin@ximian.com>
16671 * statement.cs (Using.DoResolve): This is internally emitting a
16672 try/finally clause, so we need to set ec.NeedExplicitReturn if we
16673 do not always return. Fixes #47681.
16675 2003-08-26 Martin Baulig <martin@ximian.com>
16677 * decl.cs (MemberCore): Moved WarningNotHiding(),
16678 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
16680 (AdditionResult): Make this nested in DeclSpace.
16681 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
16682 argument; call NamespaceEntry.Define() unless we're nested in a
16685 * namespace.cs (Namespace.DefineName): New public function. This
16686 is called from DeclSpace's .ctor to add
16687 (Namespace.Lookup): Include DeclSpaces in the lookup.
16689 * class.cs (Operator): Derive from MemberBase, not MemberCore.
16691 * const.cs (Const): Derive from MemberBase, not MemberCore.
16693 2003-08-25 Martin Baulig <martin@ximian.com>
16695 * convert.cs (Convert.ExplicitReferenceConversion): When
16696 converting from an interface type to a class, unbox if the target
16697 type is a struct type. Fixes #47822.
16699 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16701 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
16704 2003-08-22 Martin Baulig <martin@ximian.com>
16706 * class.cs (TypeManager.DefineType): When defining a nested type,
16707 call DefineType() on our parent; fixes #47801.
16709 2003-08-22 Martin Baulig <martin@ximian.com>
16711 * class.cs (MethodData.Define): While checking if a method is an
16712 interface implementation, improve the test a bit more to fix #47654.
16714 2003-08-22 Martin Baulig <martin@ximian.com>
16716 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
16717 correctly; fixes #47722.
16719 2003-08-22 Martin Baulig <martin@ximian.com>
16721 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
16722 LocalVariableReference, ensure it's not read-only. Fixes #47536.
16724 * statement.cs (Fixed.DoResolve): Make all variables read-only.
16726 2003-08-22 Martin Baulig <martin@ximian.com>
16728 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
16729 can only be assigned in static constructors. Fixes #47161.
16731 2003-08-22 Martin Baulig <martin@ximian.com>
16733 Rewrote and improved the flow analysis code.
16735 * flowbranching.cs (FlowBranching): Make this class abstract.
16736 (FlowBranching.CreateBranching): New static function to create a
16737 new flow branching.
16738 (FlowBranchingBlock, FlowBranchingException): New classes.
16739 (FlowBranching.UsageVector.Type): New public readonly field.
16740 (FlowBranching.UsageVector.Breaks): Removed the setter.
16741 (FlowBranching.UsageVector.Returns): Removed the setter.
16742 (FlowBranching.UsageVector): Added Break(), Return(),
16743 NeverReachable() and Throw() methods to modify the reachability.
16744 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
16745 done by FlowBranching.Merge().
16746 (FlowBranching.UsageVector.MergeChild): New method; merges the
16747 merge result into the current vector.
16748 (FlowBranching.Merge): New abstract method to merge a branching.
16750 2003-08-12 Martin Baulig <martin@ximian.com>
16752 * expression.cs (Indirection.CacheTemporaries): Create the
16753 LocalTemporary with the pointer type, not its element type.
16755 2003-08-10 Miguel de Icaza <miguel@ximian.com>
16757 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
16758 token was a keyword or not.
16760 Add `error' options where an IDENTIFIER was expected; Provide
16761 CheckToken and CheckIdentifierToken convenience error reporting
16764 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
16766 * decl.cs: Rename `NamespaceEntry Namespace' public field into
16767 NameSpaceEntry NameSpaceEntry.
16769 (LookupInterfaceOrClass): Avoid creating a full qualified name
16770 from namespace and name: avoid doing lookups when we know the
16771 namespace is non-existant. Use new Tree.LookupByNamespace which
16772 looks up DeclSpaces based on their namespace, name pair.
16774 * driver.cs: Provide a new `parser verbose' to display the
16775 exception thrown during parsing. This is turned off by default
16776 now, so the output of a failure from mcs is more graceful.
16778 * namespace.cs: Track all the namespaces defined in a hashtable
16781 (IsNamespace): New method
16783 2003-08-09 Miguel de Icaza <miguel@ximian.com>
16785 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
16786 we know that we need to concatenate (full typename can never be
16791 * statement.cs: Use a bitfield; Do not initialize to null things
16792 which are done by the constructor by default.
16794 * cs-parser.jay: bug fix, parameter was 4, not 3.
16796 * expression.cs: Just use the property;
16798 * statement.cs: No need for GetVariableInfo method.
16800 2003-08-08 Martin Baulig <martin@ximian.com>
16802 * flowanalysis.cs (FlowReturns): This is now nested in the
16803 `FlowBranching' class.
16804 (MyBitVector): Moved this here from statement.cs.
16805 (FlowBranching.SiblingType): New enum type.
16806 (FlowBranching.CreateSibling): Added `SiblingType' argument.
16808 2003-08-07 Martin Baulig <martin@ximian.com>
16810 * flowanalysis.cs (FlowBranchingType): This is now nested in the
16811 `FlowBranching' class and called `BranchingType'.
16813 2003-08-07 Martin Baulig <martin@ximian.com>
16815 * flowanalysis.cs: Moved all the control flow analysis code into
16818 2003-08-07 Martin Baulig <martin@ximian.com>
16820 * assign.cs (Assign.DoResolve): `target' must either be an
16821 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
16824 2003-08-07 Miguel de Icaza <miguel@ximian.com>
16826 * expression.cs (BinaryMethod): This kind of expression is created by the
16827 Binary class if it determines that the operator has to be handled
16830 (BinaryDelegate): This kind of expression is created if we are
16831 dealing with a + or - operator on delegates.
16833 (Binary): remove method, argumetns, and DelegateOperator: when
16834 dealing with methods,
16836 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
16838 * statement.cs (Block): use bitfields for the three extra booleans
16839 we had in use. Remove unused topblock parameter.
16841 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
16843 * assign.cs: Drop extra unneeded tests.
16845 2003-08-06 Miguel de Icaza <miguel@ximian.com>
16847 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
16849 * statement.cs (Foreach): Use VariableStorage instead of
16852 * codegen.cs (VariableStorage): New class used by clients that
16853 require a variable stored: locals or fields for variables that
16854 need to live across yield.
16856 Maybe provide a convenience api for EmitThis+EmitLoad?
16858 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
16861 2003-08-05 Miguel de Icaza <miguel@ximian.com>
16863 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
16864 RemapParameterLValue): New methods that are used to turn a
16865 precomputed FieldInfo into an expression like this:
16869 The idea is to use this instead of making LocalVariableReference
16870 have more than one meaning.
16872 * cs-parser.jay: Add error production to BASE.
16874 * ecore.cs: Deal with TypeManager.GetField returning null, which
16875 is now a valid return value.
16877 (FieldExprNoAddress): New expression for Fields whose address can
16880 * expression.cs (LocalVariableReference): During the resolve
16881 phases, create new expressions if we are in a remapping context.
16882 Remove code that dealt with remapping here.
16884 (ParameterReference): same.
16886 (ProxyInstance): New expression, like the `This' expression, but
16887 it is born fully resolved. We know what we are doing, so remove
16888 the errors that are targeted to user-provided uses of `this'.
16890 * statement.cs (Foreach): our variable is now stored as an
16891 Expression; During resolution, follow the protocol, dont just
16892 assume it will return this.
16894 2003-08-06 Martin Baulig <martin@ximian.com>
16896 * support.cs (SeekableStreamReader.cs): New public class.
16898 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
16899 SeekableStreamReader instead of the normal StreamReader.
16901 2003-08-04 Martin Baulig <martin@ximian.com>
16903 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
16904 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
16905 deambiguate casts and delegate invocations.
16906 (parenthesized_expression): Use the new tokens to ensure this is
16907 not a cast of method invocation.
16909 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
16910 when reading a `)' and Deambiguate_CloseParens () was previously
16913 * expression.cs (ParenthesizedExpression): New class. This is
16914 just used for the CS0075 test.
16915 (Binary.DoResolve): Check for CS0075.
16917 2003-07-29 Ravi Pratap <ravi@ximian.com>
16919 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
16920 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
16921 reference comparison.
16923 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
16924 examine the ReturnType for equality - this is necessary in the
16925 cases of implicit and explicit operators whose signature also
16926 includes the return type.
16928 2003-07-26 Miguel de Icaza <miguel@ximian.com>
16930 * namespace.cs: Cache the result of the namespace computation,
16931 instead of computing it every time.
16933 2003-07-24 Miguel de Icaza <miguel@ximian.com>
16935 * decl.cs: Use a global arraylist that we reuse over invocations
16936 to avoid excesive memory consumption. Reduces memory usage on an
16937 mcs compile by one meg (45 average).
16939 * typemanager.cs (LookupTypeReflection): In .NET pointers are
16940 private, work around that.
16942 2003-07-23 Miguel de Icaza <miguel@ximian.com>
16944 * literal.cs (IntLiteral): Define Zero and One static literals.
16946 * cs-parser.jay (integer_literal): use static literals to reduce
16947 memory usage for the most used literals (0, 1 and -1). 211kb
16948 reduced in memory usage.
16950 Replace all calls to `new ArrayList' with `new
16951 ArrayList(4)' which is a good average number for most allocations,
16952 and also requires only 16 bytes of memory for its buffer by
16955 This reduced MCS memory usage in seven megabytes for the RSS after
16958 2003-07-28 Ravi Pratap <ravi@ximian.com>
16960 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
16961 handle params methods the correct way by forming only one
16962 applicable set with params and normal methods in them. Earlier we
16963 were looking at params methods only if we found no normal methods
16964 which was not the correct thing to do.
16966 (Invocation.BetterFunction): Take separate arguments indicating
16967 when candidate and the best method are params methods in their
16970 This fixes bugs #43367 and #46199.
16972 * attribute.cs: Documentation updates.
16974 (CheckAttribute): Rename to CheckAttributeTarget.
16975 (GetValidPlaces): Rename to GetValidTargets.
16977 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
16978 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
16982 2003-07-28 Martin Baulig <martin@ximian.com>
16984 * class.cs (TypeContainer.DefineMembers): Use the base type's full
16985 name when looking up the base class of a nested class. Fixes #46977.
16987 2003-07-26 Martin Baulig <martin@ximian.com>
16989 * expression.cs (Indexers.Indexer): New nested struct; contains
16990 getter, setter and the indexer's type.
16991 (Indexers.Properties): This is now an ArrayList of
16992 Indexers.Indexer's.
16993 (IndexerAccess.DoResolveLValue): Correctly set the type if the
16994 indexer doesn't have any getters.
16996 * assign.cs (Assign.DoResolve): Also do the implicit conversions
16997 for embedded property and indexer assignments.
16999 2003-07-26 Martin Baulig <martin@ximian.com>
17001 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
17002 preprocessor directive is not the first non-whitespace character
17005 2003-07-26 Martin Baulig <martin@ximian.com>
17007 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
17008 namespace parsing, follow the spec more closely.
17010 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
17011 NamespaceEntry.Lookup().
17013 2003-07-25 Martin Baulig <martin@ximian.com>
17015 * MethodCore.cs (OverridesSomething): New public field; it's set
17016 from TypeContainer.DefineMembers if this method overrides
17017 something (which doesn't need to be a method). Fix #39462.
17019 2003-07-25 Ravi Pratap <ravi@ximian.com>
17021 * typemanager.cs (GetMembers): Ensure that the list of members is
17022 reversed. This keeps things in sync.
17024 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
17025 find an AttributeUsage attribute.
17027 * expression.cs (Invocation.OverloadResolve): Perform the check
17028 which disallows Invoke to be directly called on a Delegate.
17030 (Error_InvokeOnDelegate): Report error cs1533.
17032 2003-07-25 Martin Baulig <martin@ximian.com>
17034 * expression.cs (Indexers.GetIndexersForType): Only look in the
17035 interface hierarchy if the requested type is already an
17036 interface. Fixes #46788 while keeping #46502 fixed.
17038 2003-07-25 Martin Baulig <martin@ximian.com>
17040 * class.cs (TypeContainer.DefineMembers): Check whether all
17041 readonly fields have been assigned and report warning CS0649 if
17044 * statement.cs (LocalInfo.IsFixed): Always return true if this is
17047 2003-07-24 Ravi Pratap <ravi@ximian.com>
17049 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
17050 returned from GetMethods to make things consistent with the
17051 assumptions MCS makes about ordering of methods.
17053 This should comprehensively fix bug #45127 and it does :-)
17055 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
17056 ordering is actually reverse.
17058 * Clean up some debug messages I left lying around.
17060 * interface.cs (Populate*): Get rid of code which emits attributes
17061 since the stage in which we emit attributes is the 'Emit' stage,
17062 not the define stage.
17064 (Emit): Move attribute emission for interface members here.
17066 2003-07-22 Ravi Pratap <ravi@ximian.com>
17068 * expression.cs (Invocation.OverloadResolve): Follow the spec more
17069 closely: we eliminate methods in base types when we have an
17070 applicable method in a top-level type.
17072 Please see section 14.5.5.1 for an exact description of what goes
17075 This fixes bug #45127 and a host of other related to corlib compilation.
17077 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
17078 array is the method corresponding to the top-level type (this is
17079 because of the changes made to icall.c) so we change this
17082 (MethodGroupExpr.Name): This too.
17084 * typemanager.cs (GetElementType): New method which does the right
17085 thing when compiling corlib.
17087 * everywhere: Make use of the above in the relevant places.
17089 2003-07-22 Martin Baulig <martin@ximian.com>
17091 * cs-parser.jay (invocation_expression): Moved
17092 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
17093 `cast_expression', but create a InvocationOrCast which later
17094 resolves to either an Invocation or a Cast.
17096 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
17097 method; call this before EmitStatement() to make sure that this
17098 expression can be used as a statement.
17100 * expression.cs (InvocationOrCast): New class; resolves to either
17101 an Invocation or a Cast.
17103 * statement.cs (StatementExpression): Call ResolveStatement() on
17104 the ExpressionStatement before emitting it.
17106 2003-07-21 Martin Baulig <martin@ximian.com>
17108 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
17109 `ref' and `out' attributes match; fixes #46220.
17110 (MemberAccess.ResolveMemberAccess): You can't reference a type
17111 through an expression; fixes #33180.
17112 (Indexers.GetIndexersForType): Don't return the indexers from
17113 interfaces the class implements; fixes #46502.
17115 2003-07-21 Martin Baulig <martin@ximian.com>
17117 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
17118 CS0661 checks; fixes bug #30442.
17120 2003-07-21 Martin Baulig <martin@ximian.com>
17122 * decl.cs (AdditionResult): Added `Error'.
17124 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
17126 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
17127 makes cs0031.cs actually work.
17129 2003-07-20 Martin Baulig <martin@ximian.com>
17131 * namespace.cs: Fixed that bug which caused a crash when compiling
17132 the debugger's GUI.
17134 2003-07-20 Miguel de Icaza <miguel@ximian.com>
17136 * typemanager.cs (LookupTypeReflection): Never expose types which
17137 are NotPublic, NestedPrivate, NestedAssembly, or
17138 NestedFamANDAssem. We used to return these, and later do a check
17139 that would report a meaningful error, but the problem is that we
17140 would not get the real match, if there was a name override.
17142 2003-07-18 Miguel de Icaza <miguel@ximian.com>
17144 * namespace.cs (Namespace, Name): Do not compute the namespace
17145 name dynamically, compute it in the constructor. This reduced
17146 memory usage by 1697 KB.
17148 * driver.cs: Use --pause to pause at the end.
17150 2003-07-17 Peter Williams <peter@newton.cx>
17152 * Makefile: Change the name of the test target so that it doesn't
17153 conflict with the recursive test target.
17155 2003-07-17 Miguel de Icaza <miguel@ximian.com>
17157 * expression.cs (LocalVariableReference.Emit, EmitAssign,
17158 AddressOf): Do not use EmitThis, that was wrong, use the actual
17161 2003-07-15 Miguel de Icaza <miguel@ximian.com>
17163 * class.cs (MethodData.Define): While checking if a method is an
17164 interface implementation, improve the test: If we are not public
17165 (use new test here: use the computed MethodAttributes directly,
17166 instead of the parsed modifier flags) check if the `implementing'
17167 method comes from an interface or not.
17169 * pending.cs (VerifyPendingMethods): Slightly better error
17172 * makefile: add test target that does the mcs bootstrap.
17174 2003-07-16 Ravi Pratap <ravi@ximian.com>
17176 * interface.cs (Define): Do nothing here since there are no
17177 members to populate etc. Move the attribute emission out of here
17178 since this was just totally the wrong place to put it. Attribute
17179 application happens during the 'Emit' phase, not in the 'Define'
17182 (Emit): Add this method and move the attribute emission here
17184 * rootcontext.cs (EmitCode): Call the Emit method on interface
17187 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17189 * expression.cs (OverloadResolve): Report error only if Location
17190 is not 'Null' which means that there was a probe going on.
17192 2003-07-14 Martin Baulig <martin@ximian.com>
17194 * expression.cs (ConditionalLogicalOperator): New public class to
17195 implement user defined conditional logical operators.
17196 This is section 14.11.2 in the spec and bug #40505.
17198 2003-07-14 Martin Baulig <martin@ximian.com>
17200 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
17202 2003-07-14 Martin Baulig <martin@ximian.com>
17204 * codegen.cs (EmitContext.InFixedInitializer): New public field.
17206 * ecore.cs (IVariable.VerifyFixed): New interface method.
17208 * expression.cs (Unary.ResolveOperator): When resolving the `&'
17209 operator, check whether the variable is actually fixed. Fixes bug
17210 #36055. Set a variable definitely assigned when taking its
17211 address as required by the spec.
17213 * statement.cs (LocalInfo.IsFixed): New field.
17214 (LocalInfo.MakePinned): Set `IsFixed' to true.
17216 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17218 * attribute.cs (Attribute.Resolve): While doing a Member lookup
17219 for .ctors, ensure that we only ask for members declared in the
17220 attribute type (BindingFlags.DeclaredOnly).
17224 * expression.cs (Error_WrongNumArguments): Report error 1501
17225 correctly the way CSC does.
17227 2003-07-13 Martin Baulig <martin@ximian.com>
17229 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
17230 lookup on the fully qualified name, to make things like "X.X" work
17231 where "X.X" is a fully qualified type name, but we also have a
17232 namespace "X" in the using list. Fixes #41975.
17234 2003-07-13 Martin Baulig <martin@ximian.com>
17236 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
17237 function. If we're a CompoundAssign, we need to create an embedded
17238 CompoundAssign, not an embedded Assign.
17239 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
17242 2003-07-13 Martin Baulig <martin@ximian.com>
17244 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
17245 work to fix bug #46088.
17247 2003-07-13 Ravi Pratap <ravi@ximian.com>
17249 * class.cs (Operator.Emit): Do not emit attributes here - it is
17250 taken care of by the Method class that we delegate too. This takes
17251 care of bug #45876.
17253 2003-07-10 Martin Baulig <martin@ximian.com>
17255 * expression.cs (TypeOfVoid): New class.
17256 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
17258 2003-07-10 Martin Baulig <martin@ximian.com>
17260 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
17263 2003-07-10 Martin Baulig <martin@ximian.com>
17265 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
17266 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
17268 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
17270 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
17272 2003-07-10 Martin Baulig <martin@ximian.com>
17274 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
17275 of decimal. Fixes #42850.
17277 NOTE: I also fixed the created byte blob, but this doesn't work on
17278 the MS runtime and csc never produces any byte blobs for decimal
17281 2003-07-10 Martin Baulig <martin@ximian.com>
17283 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
17284 structs; fixes #32068.
17285 (Block.AddChildVariableNames): Fixed #44302.
17287 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17289 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
17291 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17293 * attribute.cs: And this test is onger needed.
17295 2003-07-08 Martin Baulig <martin@ximian.com>
17297 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
17298 inaccessible types. Fixes #36313.
17300 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
17302 * namespace.cs (NamespaceEntry): Create implicit entries for all
17303 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
17304 implicit entries for N1.N2 and N1.
17306 2003-07-08 Martin Baulig <martin@ximian.com>
17308 Rewrote the handling of namespaces to fix a lot of the issues
17309 wrt. `using' aliases etc.
17311 * namespace.cs (Namespace): Splitted this class into a
17312 per-assembly `Namespace' and a per-file `NamespaceEntry'.
17314 * typemanager.cs (TypeManager.IsNamespace): Removed.
17315 (TypeManager.ComputeNamespaces): Only compute namespaces from
17316 loaded assemblies here, not the namespaces from the assembly we're
17317 currently compiling.
17319 2003-07-08 Martin Baulig <martin@ximian.com>
17321 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
17323 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17325 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
17328 I thought about the memory savings here, but LookupTypeReflection
17329 is used under already very constrained scenarios. Compiling
17330 corlib or mcs only exposes one hit, so it would not really reduce
17331 any memory consumption.
17333 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17335 * typemanager.cs: fixes bug #45889 by only adding public types from
17336 other assemblies to the list of known types.
17338 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17340 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
17341 on the type we resolved.
17343 2003-07-05 Martin Baulig <martin@ximian.com>
17345 * pending.cs (PendingImplementation.ParentImplements): Don't
17346 create the proxy if the parent is abstract.
17348 * class.cs (TypeContainer.DefineIndexers): Process explicit
17349 interface implementations first. Fixes #37714.
17351 2003-07-04 Miguel de Icaza <miguel@ximian.com>
17353 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
17354 defined recursively; but since we modify the input parameters
17355 (left is set to `this' temporarily), we reset this value if the
17356 left_is_explicit is false, which gives the original semantics to
17359 * literal.cs (NullPointer): new class used to represent a null
17360 literal in a pointer context.
17362 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
17363 type is a pointer, use a NullPointer object instead of a
17364 NullLiteral. Closes 43687
17366 (ExplicitConversion): Convert pointer values using
17367 the conv opcode to the proper type.
17369 * ecore.cs (New): change ValueTypeVariable property into a method,
17370 that returns whether the valuetype is suitable for being used.
17372 * expression.cs (Binary.DoNumericPromotions): Only return if we
17373 the int constant was a valid uint, and we can return both left and
17374 right as uints. If not, we continue processing, to trigger the
17375 type conversion. This fixes 39018.
17377 * statement.cs (Block.EmitMeta): During constant resolution, set
17378 the CurrentBlock property on the emitcontext, so that we resolve
17379 constants propertly.
17381 2003-07-02 Martin Baulig <martin@ximian.com>
17383 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
17384 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
17386 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
17387 than emitting it here.
17389 * statement.cs: Fixed some more flow analysis bugs.
17391 2003-07-02 Martin Baulig <martin@ximian.com>
17393 * class.cs (MethodData.Define): When implementing interface
17394 methods, set Final unless we're Virtual.
17396 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
17397 check work for interface methods.
17399 2003-07-01 Martin Baulig <martin@ximian.com>
17401 * ecore.cs (EmitContext.This): Replaced this property with a
17402 GetThis() method which takes a Location argument. This ensures
17403 that we get the correct error location for a CS0188.
17405 2003-07-01 Miguel de Icaza <miguel@ximian.com>
17407 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
17408 ImplicitStandardConversion.
17410 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
17412 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
17414 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
17417 2003-06-30 Miguel de Icaza <miguel@ximian.com>
17419 * class.cs (Constructor.Define): Turn off initlocals for unsafe
17422 (MethodData.Define): Turn off initlocals for unsafe methods.
17424 2003-06-29 Miguel de Icaza <miguel@ximian.com>
17426 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
17427 complete; Fixes #37521.
17429 * delegate.cs: Use Modifiers.TypeAttr to compute the
17430 TypeAttributes, instead of rolling our own. This makes the flags
17431 correct for the delegates.
17433 2003-06-28 Miguel de Icaza <miguel@ximian.com>
17435 * class.cs (Constructor.Define): Set the private flag for static
17436 constructors as well.
17438 * cs-parser.jay (statement_expression): Set the return value to
17439 null, to avoid a crash when we catch an error.
17441 2003-06-24 Miguel de Icaza <miguel@ximian.com>
17443 * cs-parser.jay: Applied patch from Jackson that adds support for
17444 extern and unsafe modifiers to destructor declarations.
17446 * expression.cs: Report error 21 if the user is trying to index a
17449 * driver.cs: Add an error message, suggested by the bug report.
17451 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
17452 if we do not have a ": this ()" constructor initializer. Fixes 45149
17454 2003-06-14 Miguel de Icaza <miguel@ximian.com>
17456 * namespace.cs: Add some information to reduce FAQs.
17458 2003-06-13 Miguel de Icaza <miguel@ximian.com>
17460 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
17461 underlying enumeration types. Fixes #43915.
17463 * expression.cs: Treat ushort/short as legal values to be used in
17464 bitwise operations.
17466 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
17468 * delegate.cs: transfer custom attributes for paramenters from
17469 the delegate declaration to Invoke and BeginInvoke.
17471 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
17473 * attribute.cs: handle custom marshalers and emit marshal info
17476 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
17478 * makefile.gnu: Added anonymous.cs to the compiler sources.
17480 2003-05-28 Miguel de Icaza <miguel@ximian.com>
17482 * iterators.cs: Change the name of the proxy class to include two
17485 * cs-parser.jay: Update grammar to include anonymous methods.
17487 * anonymous.cs: new file.
17489 2003-05-27 Miguel de Icaza <miguel@ximian.com>
17491 * class.cs (Field.Define): Add missing test for pointers and
17494 2003-05-27 Ravi Pratap <ravi@ximian.com>
17496 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
17497 we use the stobj opcode.
17499 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
17500 since it wasn't the correct fix.
17502 It still is puzzling that we are required to use stobj for IntPtr
17503 which seems to be a ValueType.
17505 2003-05-26 Miguel de Icaza <miguel@ximian.com>
17507 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
17508 during regular simple name resolution. Now, the trick is that
17509 instead of returning for processing the simplename, we do a
17510 TypeManager.LookupType (ie, a rooted lookup as opposed to a
17511 contextual lookup type). If a match is found, return that, if
17512 not, return for further composition.
17514 This fixes long-standing 30485.
17516 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
17517 using the address to initialize an object, do an Stobj instead of
17518 using the regular Stelem.
17520 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
17521 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
17522 Because if we are a BaseIndexerAccess that value will be true.
17525 * statement.cs (GotoCase.Resolve): Return after reporting an
17526 error, do not attempt to continue.
17528 * expression.cs (PointerArithmetic.Emit): If our operand is a
17529 long, convert our constants to match the operand before
17530 multiplying. Convert to I type before adding. Fixes 43670.
17532 2003-05-14 Ravi Pratap <ravi@ximian.com>
17534 * enum.cs (ImplicitConversionExists) : Rename to
17535 ImplicitEnumConversionExists to remove ambiguity.
17537 * ecore.cs (NullCast): New type of cast expression class which
17538 basically is very similar to EmptyCast with the difference being
17539 it still is a constant since it is used only to cast a null to
17541 (eg. (string) null)
17543 * convert.cs (ImplicitReferenceConversion): When casting a null
17544 literal, we return a NullCast.
17546 * literal.cs (NullLiteralTyped): Remove - I don't see why this
17547 should be around anymore.
17549 The renaming (reported was slightly wrong). Corrections:
17551 ConvertImplicitStandard -> ImplicitConversionStandard
17552 ConvertExplicitStandard -> ExplicitConversionStandard
17554 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
17555 before passing them in !
17557 * convert.cs (ImplicitConversionStandard): When comparing for
17558 equal expr and target types, ensure that expr is not a
17561 In general, we must not be checking (expr_type ==
17562 target_type) in the top level conversion methods
17563 (ImplicitConversion, ExplicitConversion etc). This checking is
17564 done in the methods that they delegate to.
17566 2003-05-20 Miguel de Icaza <miguel@ximian.com>
17568 * convert.cs: Move Error_CannotConvertType,
17569 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
17570 ImplicitNumericConversion, ImplicitConversionExists,
17571 ImplicitUserConversionExists, StandardConversionExists,
17572 FindMostEncompassedType, FindMostSpecificSource,
17573 FindMostSpecificTarget, ImplicitUserConversion,
17574 ExplicitUserConversion, GetConversionOperators,
17575 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
17576 TryImplicitIntConversion, Error_CannotConvertImplicit,
17577 ConvertImplicitRequired, ConvertNumericExplicit,
17578 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
17579 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
17582 Perform the following renames:
17584 StandardConversionExists -> ImplicitStandardConversionExists
17585 ConvertImplicit -> ImplicitConversion
17586 ConvertImplicitStandard -> ImplicitStandardConversion
17587 TryImplicitIntConversion -> ImplicitIntConversion
17588 ConvertImplicitRequired -> ImplicitConversionRequired
17589 ConvertNumericExplicit -> ExplicitNumericConversion
17590 ConvertReferenceExplicit -> ExplicitReferenceConversion
17591 ConvertExplicit -> ExplicitConversion
17592 ConvertExplicitStandard -> ExplicitStandardConversion
17594 2003-05-19 Martin Baulig <martin@ximian.com>
17596 * statement.cs (TypeInfo.StructInfo): Made this type protected.
17597 (TypeInfo): Added support for structs having structs as fields.
17599 * ecore.cs (FieldExpr): Implement IVariable.
17600 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
17601 VariableInfo for the field.
17603 2003-05-18 Martin Baulig <martin@ximian.com>
17605 * expression.cs (This.DoResolve): Report a CS0027 if we're
17606 emitting a field initializer.
17608 2003-05-18 Martin Baulig <martin@ximian.com>
17610 * expression.cs (This.ResolveBase): New public function.
17611 (This.DoResolve): Check for CS0188.
17613 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
17616 * ecore.cs (MethodGroupExpr.DoResolve): Set the
17617 `instance_expression' to null if we don't have any non-static
17620 2003-05-18 Martin Baulig <martin@ximian.com>
17622 Reworked the way how local variables and parameters are handled by
17623 the flow analysis code.
17625 * statement.cs (TypeInfo, VariableMap): New public classes.
17626 (VariableInfo): New public class. This is now responsible for
17627 checking whether a variable has been assigned. It is used for
17628 parameters and local variables.
17629 (Block.EmitMeta): Take the InternalParameters as argument; compute
17630 the layout of the flow vectors here.
17631 (Block.LocalMap, Block.ParameterMap): New public properties.
17632 (FlowBranching): The .ctor doesn't get the InternalParameters
17633 anymore since Block.EmitMeta() now computes the layout of the flow
17635 (MyStructInfo): This class is now known as `StructInfo' and nested
17636 in `TypeInfo'; we don't access this directly anymore.
17638 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
17639 property and removed IsAssigned(), IsFieldAssigned(),
17640 SetAssigned() and SetFieldAssigned(); we now call them on the
17641 VariableInfo so we don't need to duplicate this code everywhere.
17643 * expression.cs (ParameterReference): Added `Block block' argument
17645 (LocalVariableReference, ParameterReference, This): The new
17646 VariableInfo class is now responsible for all the definite
17649 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
17650 IsParameterAssigned, SetParameterAssigned): Removed.
17652 2003-05-18 Martin Baulig <martin@ximian.com>
17654 * typemanager.cs (InitCoreTypes): Try calling
17655 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
17656 the 3-args-version. Corlib now also needs our `void_type'.
17657 (GetMethod): Added overloaded version which takes an optional
17658 `bool report_errors' to allow lookups of optional methods.
17660 2003-05-12 Martin Baulig <martin@ximian.com>
17662 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
17663 only used for locals and not for parameters.
17665 2003-05-12 Miguel de Icaza <miguel@ximian.com>
17667 * support.cs (InternalParameters.ParameterType): Return the
17668 ExternalType of the parameter.
17670 * parameter.cs (Parameter.ExternalType): drop the two arguments,
17673 2003-05-11 Miguel de Icaza <miguel@ximian.com>
17675 * class.cs (MethodData.Define): Do not set the `newslot' on
17676 interface members, if they are also flagged as "override".
17678 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
17679 better code for ++i and i++. This only works for static fields
17680 and local variables.
17682 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
17683 want to pull the DeclSpace out of the builder_to_declspace instead
17684 of the TypeBuilder (like in TypeContainer.FindMembers).
17686 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
17687 instead of LookupTypeContainer. Fixes the crash on .NET for
17688 looking up interface members.
17690 * const.cs: Create our own emit context during the Definition
17691 stage, so that constants are evaluated in the proper context, when
17692 a recursive definition happens.
17694 2003-05-11 Martin Baulig <martin@ximian.com>
17696 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
17697 new block for a switch section.
17698 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
17699 the adding/lookup in the switch block. Fixes #39828.
17701 2003-05-09 Miguel de Icaza <miguel@ximian.com>
17703 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
17704 functionality: I needed to convert the data after I had performed
17705 the add/sub operation into the operands type size.
17707 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
17708 pass the type for the box operation, otherwise the resulting
17709 object would have been of type object.
17711 (BoxedCast): Add constructor to specify the type to box as.
17713 2003-05-07 Miguel de Icaza <miguel@ximian.com>
17715 * iterators.cs: I was reusing the `count' variable inadvertently,
17716 take steps to not allow this to happen.
17718 2003-05-06 Miguel de Icaza <miguel@ximian.com>
17720 * attribute.cs (Attribute.Resolve): Params attributes are encoded
17721 by creating an array at the point where the params starts and
17722 putting all those arguments there, then adjusting the size of the
17725 2003-05-05 Miguel de Icaza <miguel@ximian.com>
17727 * expression.cs (New.AddressOf): Implement interface
17728 IMemoryLocation. This is used when the `new' operator is used in
17729 the context of an invocation to a method on a value type.
17731 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
17734 * namespace.cs: Also check the using aliases here.
17736 * driver.cs: Move the test for using validity after the types have
17737 been entered, so we do a single pass that also includes the using
17740 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
17741 in the regular case. CreateSiblingForFinally is doing extra
17744 * attribute.cs (GetAttributeArgumentExpression): Store the result
17745 on an out value, and use the return value to indicate failure
17746 instead of using null (which is a valid return for Constant.GetValue).
17748 * statement.cs: Perform the analysis flow for the increment
17749 portion after the statement, because this will be the real flow of
17750 execution. Fixes #42385
17752 * codegen.cs (EmitContext.EmitArgument,
17753 EmitContext.EmitStoreArgument): New helper functions when the
17754 RemapToProxy flag is set.
17756 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
17759 Add support for remapping parameters.
17761 * iterators.cs: Propagate parameter values; Store parameter
17762 values in the proxy classes.
17764 2003-05-04 Miguel de Icaza <miguel@ximian.com>
17766 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
17767 need a proxy reference; I do not know what I was thinking
17769 * cs-parser.jay (constructor_initializer): catch another error,
17770 and display nice message.
17772 (field_declaration): catch void field declaration
17773 to flag a better error.
17775 * class.cs (MemberBase.CheckBase): Report an error instead of a
17776 warning if a new protected member is declared in a struct.
17777 (Field.Define): catch the error of readonly/volatile.
17779 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
17781 (FieldExpr.AddressOf): ditto. Catch error where the address of a
17782 volatile variable is taken
17784 2003-05-02 Miguel de Icaza <miguel@ximian.com>
17786 * statement.cs (Fixed.Resolve): Report an error if we are not in
17789 2003-05-01 Miguel de Icaza <miguel@ximian.com>
17791 * typemanager.cs: reuse the code that handles type clashes for
17792 delegates and enumerations.
17794 * class.cs (Report28): Always report.
17796 * expression.cs (EncodeAsAttribute): Allow nulls here.
17798 2003-04-28 Miguel de Icaza <miguel@ximian.com>
17800 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
17801 the functionality for testing whether an expression is valid for
17802 an attribute here. Also handle the case of arrays of elements
17805 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
17806 encoding a linear array into an array of objects that are suitable
17807 to be passed to an CustomAttributeBuilder.
17809 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
17811 * ecore.cs: (FieldExpr): Handle field remapping here.
17813 * iteratators.cs: Pass the instance variable (if the method is an
17814 instance method) to the constructors, so we can access the field
17815 variables on the class.
17817 TODO: Test this with structs. I think the THIS variable on
17818 structs might have to be a pointer, and not a refenrece
17820 2003-04-27 Miguel de Icaza <miguel@ximian.com>
17822 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
17823 local variables to fields in a proxy class.
17825 * iterators.cs (PopulateProxy): Rename our internal fields to
17827 Create a <THIS> field if we are an instance method, so we can
17828 reference our parent container variables.
17829 (MapVariable): Called back from the EmitContext code to enter a
17830 new variable to field mapping into the proxy class (we just create
17834 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
17835 for using the remapped locals to fields.
17837 I placed the code here, because that gives the same semantics to
17838 local variables, and only changes the Emit code.
17840 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
17841 statements inside iterators.
17842 (VariableInfo): Add a FieldBuilder for the cases when we are
17843 remapping local variables to fields in a proxy class
17845 * ecore.cs (SimpleNameResolve): Avoid testing two times for
17846 current_block != null.
17848 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
17849 not cope with strings, as it has been moved to the
17850 TableSwitchEmit. Fixed bug in switch generation.
17852 * expression.cs (New.DoResolve): Provide more context for the user
17853 when reporting an error.
17855 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
17858 * expression.cs (MemberAccess.DoResolve): When we get a type back,
17859 check the permissions for it. Note than in a type-resolution
17860 context the check was already present in DeclSpace.ResolveType,
17861 but was missing from the MemberAccess.
17863 (ArrayCreation.CheckIndices): warn if the user has
17864 more nested levels of expressions, but there are no more
17865 dimensions specified. Avoids crash on bug 41906.
17867 2003-04-26 Miguel de Icaza <miguel@ximian.com>
17869 * statement.cs (Block): replace Implicit bool, for a generic
17871 New flag: `Unchecked'. This is used during the EmitMeta phase
17872 (which is out-of-line with the regular Resolve/Emit process for a
17873 statement, as this is done ahead of time, but still gets a chance
17874 to call constant resolve).
17876 (Block.Flags): new enum for adding a new flag.
17878 (Block.EmitMeta): track the state of unchecked.
17880 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
17881 to enable constant resolution to work there as well.
17883 2003-04-22 Miguel de Icaza <miguel@ximian.com>
17885 * typemanager.cs (ienumerable_type): Also look up
17886 System.Collections.IEnumerable.
17888 2003-04-21 Miguel de Icaza <miguel@ximian.com>
17890 TODO: Test more than one conditional per method.
17892 * class.cs (Indexer.Define): Report the location where the user is
17893 referencing the unsupported feature.
17895 (MethodData): Overload the use of `conditionals' to
17896 minimize the creation of needless ArrayLists. This saves roughly
17897 212kb on my machine.
17899 (Method): Implement the new IIteratorContainer interface.
17900 (Method.SetYields): Implement the method by setting the ModFlags
17901 to contain METHOD_YIELDS.
17903 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
17904 which just got set to null.
17906 * iterators.cs: New file.
17908 (Yield, YieldBreak): New statements.
17910 * statement.cs (Return.Resolve): Flag an error if we are used in
17911 an iterator method.
17913 * codegen.cs (InIterator): New flag set if the code is being
17914 compiled in an iterator method.
17916 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
17917 internal modifier, and we just use it to avoid adding extra
17918 fields, as this is seldom used.
17920 * cs-parser.jay: Add yield_statement (yield and yield break).
17922 * driver.cs: New flag -v2 to turn on version 2 features.
17924 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
17925 hashtable when v2 is enabled.
17927 2003-04-20 Miguel de Icaza <miguel@ximian.com>
17929 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
17930 there is already a namespace defined with this name.
17932 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
17933 people upgraded their corlibs.
17935 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
17936 always use fully qualified types, no need to use the compiler
17939 (TypeManager.IsNamespace): Use binarysearch.
17941 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
17942 AddDelegate): I did not quite use the new IsValid API properly: I
17943 have to pass the short-name and the fullname. I was passing only
17944 the basename instead of the fullname sometimes.
17946 (TypeContainer.DefineType): call NamespaceClash.
17948 * interface.cs (Interface.DefineType): use NamespaceClash before
17951 * delegate.cs (Delegate.DefineType): use NamespaceClash before
17954 * enum.cs: (Enum.DefineType): use NamespaceClash before
17957 * typemanager.cs (: 3-line patch that gives us some tasty 11%
17958 speed increase. First, use the negative_hits cache when we get a
17959 negative. Second, add the type with its full original name
17960 instead of the new . and + encoded name (reflection uses + to
17961 separate type from a nested type). Use LookupTypeReflection
17962 directly which bypasses the type->name hashtable (that we already
17963 know does not contain the type.
17965 * decl.cs (DeclSpace.ResolveTypeExpr): track the
17966 location/container type.
17968 * driver.cs: When passing utf8, use directly the UTF8Encoding.
17970 2003-04-19 Miguel de Icaza <miguel@ximian.com>
17972 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
17974 * delegate.cs (NewDelegate.Resolve): Test whether an instance
17975 method is being referenced in the method group from a static
17976 context, and report error 120 if so.
17978 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
17981 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
17982 is created, we create the A namespace).
17984 * cs-parser.jay: A namespace also introduces a DeclarationFound.
17987 2003-04-18 Miguel de Icaza <miguel@ximian.com>
17989 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
17990 invocation to ModuleBuilder.GetType with the same values will
17991 return a new type instance, so we need to cache its return
17994 * expression.cs (Binary.ResolveOperator): Only allow the compare
17995 operators on enums if they are of the same type.
17997 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
17998 types of ValueType on their own case. Before we were giving them
17999 the same treatment as objects.
18001 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
18002 fullname. Short name is used to compare against container name.
18003 Fullname is used to check against defined namespace names.
18005 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
18006 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
18008 (Method.CheckBase): Call parent.
18009 (MemberBase.CheckBase): Check for protected members on sealed
18011 (PropertyBase.CheckBase): Call parent.
18012 (Field.Define): Call parent.
18014 * report.cs: Negative error codes are now mapped to 8000 - code,
18015 so that the display is render more nicely.
18017 * typemanager.cs: Do not use try/catch, instead report a regular
18020 (GetPointerType, GetReferenceType): These methods provide
18021 mechanisms to obtain the T* and T& from a T. We had the code
18022 previously scattered around the code base, and it also used
18023 TypeManager.LookupType that would go through plenty of caches.
18024 This one goes directly to the type source.
18026 In some places we did the Type.GetType followed by
18027 ModuleBuilder.GetType, but not in others, so this unifies the
18028 processing as well.
18030 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
18031 statements now that we have namespace information.
18033 * typemanager.cs (IsNamespace): New method, returns whether the
18034 string presented is a namespace or not.
18036 (ComputeNamespaces): New public entry point, computes the list of
18037 available namespaces, using the GetNamespaces API call in Mono, or
18038 the slower version in MS.NET.
18040 Now before we start the semantic analysis phase, we have a
18041 complete list of namespaces including everything that the user has
18044 Deleted old code to cache namespaces in .nsc files.
18046 2003-04-17 Miguel de Icaza <miguel@ximian.com>
18048 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
18049 class/struct location definition Location for the implicit
18050 constructor location.
18052 (Operator.Define): Use the location of the operator for the
18053 implicit Method definition.
18055 (Constructor.Emit): use the constructor location for the implicit
18056 base initializer constructor.
18058 * ecore.cs: Remove ITypeExpression. This interface is now gone,
18059 and the Expression class now contains two new methods:
18061 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
18062 isolate type lookup from the rest of the resolution process.
18064 Since we use Expressions to hold type definitions due to the way
18065 we parse the input we have historically overloaded Resolve to
18066 perform the Type lookups if a special flag is passed. Now this is
18067 eliminated and two methods take their place.
18069 The differences in the two methods between xStep and xTerminal is
18070 that xStep is involved in our current lookup system that uses
18071 SimpleNames to compose a name, while xTerminal is used just to
18072 catch the case where the simplename lookup failed.
18074 2003-04-16 Miguel de Icaza <miguel@ximian.com>
18076 * expression.cs (ResolveMemberAccess): Remove redundant code.
18077 TypeExpr expressions are always born fully resolved.
18079 * interface.cs (PopulateMethod): Do not lookup the types twice.
18080 We were doing it once during SemanticAnalysis and once during
18083 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
18084 in local variable type definitions, were being returned as a
18085 SimpleName (we decomposed everything into a string), that is
18086 because primary_expression was being used instead of a type in the
18087 grammar (reduce/reduce conflicts).
18089 The part that was wrong is that we converted the expression into a
18090 string (an oversimplification in one hand, compounded with primary
18091 expressions doing string concatenation).
18097 Would return "A.B.C[]" as a SimpleName. This stopped things like
18098 using clauses from working on this particular context. And a type
18099 was being matched directly against "A.B.C[]".
18101 We now use the correct approach, and allow for ComposedCast to be
18102 part of the unary expression. So the "A.B.C []" become a composed
18103 cast of "A.B.C" (as a nested group of MemberAccess with a
18104 SimpleName at the end) plus the rank composition "[]".
18108 2003-04-10 Miguel de Icaza <miguel@ximian.com>
18110 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
18111 for the access level checking.
18113 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
18114 `TypeContainer container', because I kept getting confused when I
18115 was debugging this code.
18117 * expression.cs (Indexers): Instead of tracking getters/setters,
18118 we now track them in parallel. We create one arraylist less, but
18119 most importantly it is possible now for the LValue code to find a
18120 matching get for a set.
18122 (IndexerAccess.DoResolveLValue): Update the code.
18123 GetIndexersForType has been modified already to extract all the
18124 indexers from a type. The code assumed it did not.
18126 Also make the code set the correct return type for the indexer.
18127 This was fixed a long time ago for properties, but was missing for
18128 indexers. It used to be void_type.
18130 (Binary.Emit): Test first for doubles instead of
18131 floats, as they are more common.
18133 (Binary.EmitBranchable): Use the .un version of the branch opcodes
18134 when dealing with floats and the <=, >= operators. This fixes bug
18137 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
18138 to load the array value by emitting a load on the foreach variable
18139 type. This was incorrect.
18141 We now emit the code to load an element using the the array
18142 variable type, and then we emit the conversion operator.
18146 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
18148 * attribute.cs: Avoid allocation of ArrayLists in the common case.
18150 2003-04-09 Miguel de Icaza <miguel@ximian.com>
18152 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
18153 test for protection before we test for signatures.
18155 (MethodSignature.ToString): implement.
18157 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
18158 to the case where we reduced into a LongConstant.
18160 * decl.cs (CheckAccessLevel): If the type is an array, we can not
18161 depend on whether the information is acurrate, because the
18162 Microsoft runtime will always claim that the array type is public,
18163 regardless of the real state.
18165 If the type is a pointer, another problem happens: the type is
18166 reported as non-public in Microsoft.
18168 In both cases we have to call CheckAccessLevel recursively with
18169 the underlying type as the argument to be tested.
18171 2003-04-08 Miguel de Icaza <miguel@ximian.com>
18173 * assign.cs (Assign.Emit): If we are dealing with a compound
18174 assignment expression, we should use the code path that stores the
18175 intermediate result in a temporary value. This fixes #40903.
18177 *expression.cs (Indirection.ToString): Provide ToString method for
18180 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
18182 * class.cs: Null out fields holding references to Block objects so
18183 they can be garbage collected.
18185 * expression.cs (OverloadResolve): Remove unused local.
18187 2003-04-07 Martin Baulig <martin@ximian.com>
18189 * codegen.cs (EmitContext.CurrentFile): New public field.
18190 (EmitContext.Mark): Use the CurrentFile to check whether the
18191 location is in the correct file.
18192 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
18194 2003-04-07 Martin Baulig <martin@ximian.com>
18196 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
18198 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
18199 location. [FIXME: The location argument which gets passed to this
18200 method is sometimes wrong!]
18202 2003-04-07 Nick Drochak <ndrochak@gol.com>
18204 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
18206 2003-04-07 Miguel de Icaza <miguel@ximian.com>
18208 * expression.cs (Indirection.EmitAssign): We were using the
18209 temporary, but returning immediately instead of continuing the
18212 2003-04-06 Martin Baulig <martin@ximian.com>
18214 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
18215 if it's a nested child, but also deriving from the outer class.
18218 * typemanager.cs (IsNestedChildOf): Make this work if it's a
18219 nested child, but also deriving from the outer class. See
18221 (FilterWithClosure): We may access private members of the outer
18222 class if we're a nested child and deriving from the outer class.
18223 (RealMemberLookup): Only set `closure_private_ok' if the
18224 `original_bf' contained BindingFlags.NonPublic.
18226 2003-04-05 Martin Baulig <martin@ximian.com>
18228 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
18230 2003-04-02 Miguel de Icaza <miguel@ximian.com>
18232 * class.cs (Event.Define): Do not allow abstract events to have
18235 2003-04-01 Miguel de Icaza <miguel@ximian.com>
18237 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
18238 block in event declarations.
18240 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
18241 value type, get its address.
18243 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
18244 leaving a class on the stack instead of a boolean value (int
18245 0/1). Change the code so we compare against null, and then the
18246 result against zero.
18248 * class.cs (TypeContainer.GetClassBases): We were checking for the
18249 parent class being sealed too late.
18251 * expression.cs (Binary.Emit): For <= and >= when dealing with
18252 floating point values, use cgt.un and clt.un instead of cgt and
18255 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
18257 * statement.cs: Apply the same optimization as MS: skip the
18258 GetEnumerator returning an IEnumerator, and use the one returning a
18259 CharEnumerator instead. This allows us to avoid the try-finally block
18262 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
18264 * cs-parser.jay: Attributes cannot be applied to
18265 namespaces. Fixes #40473
18267 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18270 (Add*): check if the name is valid using the full name for constants,
18271 fields, properties and events.
18273 2003-03-28 Miguel de Icaza <miguel@ximian.com>
18275 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
18276 char constants to be part of the enumeration.
18278 * expression.cs (Conditional.DoResolve): Add support for operator
18279 true. Implements the missing functionality from 14.12
18281 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
18282 operator true/false as required by the spec.
18284 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
18285 implicit conversion to boolean.
18287 * statement.cs (Statement.ResolveBoolean): A boolean expression is
18288 also one where the type implements `operator true'.
18290 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
18291 get an expression that will invoke operator true based on an
18294 (GetConversionOperators): Removed the hack that called op_True
18297 (Expression.ResolveBoolean): Move this from Statement.
18299 2003-03-17 Miguel de Icaza <miguel@ximian.com>
18301 * ecore.cs (FieldExpr): do not allow initialization of initonly
18302 fields on derived classes
18304 2003-03-13 Martin Baulig <martin@ximian.com>
18306 * statement.cs (Block.Emit): Call ig.BeginScope() and
18307 ig.EndScope() when compiling with debugging info; call
18308 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
18310 2003-03-08 Miguel de Icaza <miguel@ximian.com>
18312 * expression.cs (Indexers): Do not construct immediately, allow
18313 for new members to be appended as we go. Fixes 38143
18315 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18317 * expression.cs: save/restore context when resolving an unchecked
18320 2003-03-05 Miguel de Icaza <miguel@ximian.com>
18322 * cfold.cs: Catch division by zero in modulus operator during
18325 2003-03-03 Miguel de Icaza <miguel@ximian.com>
18327 * interface.cs (Interface.DefineMembers): Avoid defining members
18330 2003-02-27 Miguel de Icaza <miguel@ximian.com>
18332 * driver.cs: handle the +/- options for -noconfig
18334 * statement.cs (Unckeched.Resolve): Also track the state of
18335 unchecked in the Resolve phase.
18337 2003-02-27 Martin Baulig <martin@ximian.com>
18339 * ecore.cs (Expression.MemberLookup): Don't create a
18340 MethodGroupExpr for something which is not a method. Fixes #38291.
18342 2003-02-25 Miguel de Icaza <miguel@ximian.com>
18344 * class.cs (MemberBase.CheckParameters): Also check that the type
18345 is unmanaged if it is a pointer.
18347 * expression.cs (SizeOf.Resolve): Add location information.
18349 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
18350 a managed type is declared.
18352 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
18353 parameter modifiers as well. Fixes bug 38606
18355 * class.cs: Very sad. Am backing out the speed up changes
18356 introduced by the ArrayList -> Array in the TypeContainer, as they
18357 were not actually that much faster, and introduced a bug (no error
18358 reports on duplicated methods).
18360 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
18361 source first, this will guarantee that we have a valid expression
18362 before calling in lower levels functions that will require a
18363 resolved object. Then use this original_source in the
18364 target.ResolveLValue instead of the original source that was
18367 Another change. Use target.Resolve instead of LValueResolve.
18368 Although we are resolving for LValues, we will let the Assign code
18369 take care of that (it will be called again from Resolve). This
18370 basically allows code like this:
18372 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
18373 class Y { void A (X x) { x [0] += o; }
18375 The problem was that the indexer was trying to resolve for
18376 set_Item (idx, object o) and never finding one. The real set_Item
18377 was set_Item (idx, X). By delaying the process we get the right
18382 2003-02-23 Martin Baulig <martin@ximian.com>
18384 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
18385 while calling DoEmit ().
18387 * codegen.cs (EmitContext.Mark): Don't mark locations in other
18388 source files; if you use the #line directive inside a method, the
18389 compiler stops emitting line numbers for the debugger until it
18390 reaches the end of the method or another #line directive which
18391 restores the original file.
18393 2003-02-23 Martin Baulig <martin@ximian.com>
18395 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
18397 2003-02-23 Martin Baulig <martin@ximian.com>
18399 * statement.cs (Block.AddChildVariableNames): We need to call this
18400 recursively, not just for our immediate children.
18402 2003-02-23 Martin Baulig <martin@ximian.com>
18404 * class.cs (Event.Define): Always make the field private, like csc does.
18406 * typemanager.cs (TypeManager.RealMemberLookup): Make events
18407 actually work, fixes bug #37521.
18409 2003-02-23 Miguel de Icaza <miguel@ximian.com>
18411 * delegate.cs: When creating the various temporary "Parameters"
18412 classes, make sure that we call the ComputeAndDefineParameterTypes
18413 on those new parameters (just like we do with the formal ones), to
18414 allow them to be resolved in the context of the DeclSpace.
18416 This fixes the bug that Dick observed in Bugzilla #38530.
18418 2003-02-22 Miguel de Icaza <miguel@ximian.com>
18420 * expression.cs (ResolveMemberAccess): When resolving a constant,
18421 do not attempt to pull a constant if the value was not able to
18422 generate a valid constant.
18424 * const.cs (LookupConstantValue): Do not report more errors than required.
18426 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18428 * expression.cs: fixes bug #38328.
18430 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18432 * class.cs: Changed all the various members that can be part of a
18433 class from being an ArrayList to be an Array of the right type.
18434 During the DefineType type_list, interface_list, delegate_list and
18435 enum_list are turned into types, interfaces, delegates and enums
18438 And during the member population, indexer_list, event_list,
18439 constant_list, field_list, instance_constructor_list, method_list,
18440 operator_list and property_list are turned into their real arrays.
18442 Although we could probably perform this operation earlier, for
18443 good error reporting we need to keep the lists and remove the
18444 lists for longer than required.
18446 This optimization was triggered by Paolo profiling the compiler
18447 speed on the output of `gen-sample-program.pl' perl script.
18449 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
18450 not crash in methods like MemberLookupFailed that use this field.
18452 This problem arises when the compiler fails to resolve a type
18453 during interface type definition for example.
18455 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18457 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
18458 inherit from System.Object, so we have to stop at null, not only
18459 when reaching System.Object.
18461 2003-02-17 Miguel de Icaza <miguel@ximian.com>
18463 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
18464 DeclaredOnly because the parent indexer might have had a different
18465 name, but did not loop until the top of the hierarchy was reached.
18467 The problem this one fixes is 35492: when a class implemented an
18468 indexer from an interface, we were getting the interface method
18469 (which was abstract) and we were flagging an error (can not invoke
18472 This also keeps bug 33089 functioning, and test-148 functioning.
18474 * typemanager.cs (IsSpecialMethod): The correct way of figuring
18475 out if a method is special is to see if it is declared in a
18476 property or event, or whether it is one of the predefined operator
18477 names. This should fix correctly #36804.
18479 2003-02-15 Miguel de Icaza <miguel@ximian.com>
18481 The goal here is to remove the dependency on EmptyCast.Peel ().
18482 Killing it completely.
18484 The problem is that currently in a number of places where
18485 constants are expected, we have to "probe" for an EmptyCast, and
18486 Peel, which is not the correct thing to do, as this will be
18487 repetitive and will likely lead to errors.
18489 The idea is to remove any EmptyCasts that are used in casts that
18490 can be reduced to constants, so we only have to cope with
18493 This bug hunt was triggered by Bug 37363 and the desire to remove
18494 the duplicate pattern where we were "peeling" emptycasts to check
18495 whether they were constants. Now constants will always be
18498 * ecore.cs: Use an enumconstant here instead of wrapping with
18501 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
18502 throwing me off. By handling this we can get rid of a few hacks.
18504 * statement.cs (Switch): Removed Peel() code.
18506 2003-02-14 Miguel de Icaza <miguel@ximian.com>
18508 * class.cs: Location information for error 508
18510 * expression.cs (New.DoResolve): Add a guard against double
18511 resolution of an expression.
18513 The New DoResolve might be called twice when initializing field
18514 expressions (see EmitFieldInitializers, the call to
18515 GetInitializerExpression will perform a resolve on the expression,
18516 and later the assign will trigger another resolution
18518 This leads to bugs (#37014)
18520 * delegate.cs: The signature for EndInvoke should contain any ref
18521 or out parameters as well. We were not doing this in the past.
18523 * class.cs (Field.Define): Do not overwrite the type definition
18524 inside the `volatile' group. Turns out that volatile enumerations
18525 were changing the type here to perform a validity test, which
18528 2003-02-12 Miguel de Icaza <miguel@ximian.com>
18530 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
18531 and structs, we do not want to load the instance variable
18533 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
18534 enum_type has to be handled like an object reference (implicit
18535 conversions exists from this to object), but the regular IsClass
18536 and IsValueType tests will never return true for this one.
18538 Also we use TypeManager.IsValueType instead of type.IsValueType,
18539 just for consistency with the rest of the code (this is only
18540 needed if we ever use the construct exposed by test-180.cs inside
18541 corlib, which we dont today).
18543 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
18545 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
18548 2003-02-09 Martin Baulig <martin@ximian.com>
18550 * namespace.cs (Namespace..ctor): Added SourceFile argument.
18551 (Namespace.DefineNamespaces): New static public method; this is
18552 called when we're compiling with debugging to add all namespaces
18553 to the symbol file.
18555 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
18556 pass it to the Namespace's .ctor.
18558 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
18559 and MethodBase arguments; pass the namespace ID to the symwriter;
18560 pass the MethodBase instead of the token to the symwriter.
18561 (SymbolWriter.DefineNamespace): New method to add a namespace to
18564 2003-02-09 Martin Baulig <martin@ximian.com>
18566 * symbolwriter.cs: New file. This is a wrapper around
18567 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
18568 methods here in near future.
18570 2003-02-09 Martin Baulig <martin@ximian.com>
18572 * codegen.cs (EmitContext.Mark): Just pass the arguments to
18573 ILGenerator.MarkSequencePoint() which are actually used by the
18576 2003-02-09 Martin Baulig <martin@ximian.com>
18578 * location.cs (SourceFile): New public sealed class. This
18579 contains the name and an index which is used in the location's token.
18580 (Location): Reserve an appropriate number of bits in the token for
18581 the source file instead of walking over that list, this gives us a
18582 really huge performance improvement when compiling with debugging.
18584 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
18585 `SourceFile' argument instead of a string.
18586 (Driver.ProcessFile): Add all the files via Location.AddFile(),
18587 but don't parse/tokenize here, we need to generate the list of all
18588 source files before we do that.
18589 (Driver.ProcessFiles): New static function. Parses/tokenizes all
18592 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
18593 instead of a string.
18595 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
18598 2003-02-09 Martin Baulig <martin@ximian.com>
18600 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
18601 filename on `#line default'.
18603 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
18605 * statement.cs: don't clear the pinned var when the fixed statement
18606 returns from the method (fixes bug#37752).
18608 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
18610 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
18613 2003-02-07 Martin Baulig <martin@ximian.com>
18615 * driver.cs: Removed the `--debug-args' command line argument.
18617 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
18618 automatically by the AsssemblyBuilder.
18619 (CodeGen.InitializeSymbolWriter): We don't need to call any
18620 initialization function on the symbol writer anymore. This method
18621 doesn't take any arguments.
18623 2003-02-03 Miguel de Icaza <miguel@ximian.com>
18625 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
18626 from referenced assemblies as well.
18628 2003-02-02 Martin Baulig <martin@ximian.com>
18630 * class.cs (MethodData.Emit): Generate debugging info for external methods.
18632 2003-02-02 Martin Baulig <martin@ximian.com>
18634 * class.cs (Constructor.Emit): Open the symbol writer before
18635 emitting the constructor initializer.
18636 (ConstructorInitializer.Emit): Call ec.Mark() to allow
18637 single-stepping through constructor initializers.
18639 2003-01-30 Miguel de Icaza <miguel@ximian.com>
18641 * class.cs: Handle error 549: do not allow virtual methods in
18644 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
18646 * decl.cs: Check access levels when resolving types
18648 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
18650 * statement.cs: Add parameters and locals set in catch blocks that might
18651 return to set vector
18653 2003-01-29 Miguel de Icaza <miguel@ximian.com>
18655 * class.cs (Operator): Set the SpecialName flags for operators.
18657 * expression.cs (Invocation.DoResolve): Only block calls to
18658 accessors and operators on SpecialName methods.
18660 (Cast.TryReduce): Handle conversions from char constants.
18663 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
18665 * statement.cs: small memory and time optimization in FlowBranching.
18667 2003-01-28 Pedro Mart <yoros@wanadoo.es>
18669 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
18670 problem that the last fix but in the other sid (Set).
18672 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
18673 access when there is no indexer in the hierarchy.
18675 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
18677 * class.cs: Combine some if statements.
18679 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18681 * driver.cs: fixed bug #37187.
18683 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
18685 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
18686 any indexer, it's needed to build a list with all the indexers in the
18687 hierarchy (AllGetters), else we have problems. Fixes #35653.
18689 2003-01-23 Miguel de Icaza <miguel@ximian.com>
18691 * class.cs (MethodData.Define): It is wrong for an interface
18692 implementation to be static in both cases: explicit and implicit.
18693 We were only handling this in one case.
18695 Improve the if situation there to not have negations.
18697 * class.cs (Field.Define): Turns out that we do not need to check
18698 the unsafe bit on field definition, only on usage. Remove the test.
18700 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18702 * driver.cs: use assembly.Location instead of Codebase (the latest
18703 patch made mcs fail when using MS assemblies).
18705 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
18707 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
18708 get the path to *corlib.dll.
18710 2003-01-21 Nick Drochak <ndrochak@gol.com>
18714 * typemanager.cs: Remove compiler warnings
18716 2003-01-20 Duncan Mak <duncan@ximian.com>
18718 * AssemblyInfo.cs: Bump the version number to 0.19.
18720 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18722 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
18724 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
18726 * class.cs (Constructor::Emit): Emit debugging info for constructors.
18728 2003-01-17 Miguel de Icaza <miguel@ximian.com>
18730 * cs-parser.jay: Small fix: we were not comparing the constructor
18731 name correctly. Thanks to Zoltan for the initial pointer.
18733 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
18735 * cs-tokenizer.cs: Set file name when specified with #line
18737 2003-01-15 Miguel de Icaza <miguel@ximian.com>
18739 * cs-parser.jay: Only perform the constructor checks here if we
18740 are named like the class; This will help provider a better
18741 error. The constructor path is taken when a type definition is
18742 not found, but most likely the user forgot to add the type, so
18743 report that rather than the constructor error.
18745 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
18747 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
18750 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18752 * cs-parser.jay: Add cleanup call.
18754 2003-01-13 Duncan Mak <duncan@ximian.com>
18756 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
18757 consistent with other methods.
18759 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18761 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
18763 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
18765 * attribute.cs: only set GuidAttr to true when we have a
18768 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18772 * typemanager.cs: fixes to allow mcs compile corlib with the new
18773 Type.IsSubclassOf fix.
18775 2003-01-08 Miguel de Icaza <miguel@ximian.com>
18777 * expression.cs (LocalVariableReference.DoResolve): Classify a
18778 constant as a value, not as a variable. Also, set the type for
18781 * cs-parser.jay (fixed_statement): take a type instead of a
18782 pointer_type, so we can produce a better error message later.
18784 * statement.cs (Fixed.Resolve): Flag types that are not pointers
18787 (For.DoEmit): Make inifinite loops have a
18788 non-conditional branch back.
18790 (Fixed.DoEmit): First populate the pinned variables, then emit the
18791 statement, then clear the variables. Before I was emitting the
18792 code once for each fixed piece.
18795 2003-01-08 Martin Baulig <martin@ximian.com>
18797 * statement.cs (FlowBranching.MergeChild): A break in a
18798 SWITCH_SECTION does not leave a loop. Fixes #36155.
18800 2003-01-08 Martin Baulig <martin@ximian.com>
18802 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
18803 lives in the same number space than `param_map'. Fixes #36154.
18805 2003-01-07 Miguel de Icaza <miguel@ximian.com>
18807 * cs-parser.jay (constructor_declaration): Set the
18808 Constructor.ModFlags before probing for it. This makes the
18809 compiler report 514, 515 and 132 (the code was there, but got
18812 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
18813 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
18814 (GotoCase.Resolve): Set `Returns' to ALWAYS.
18816 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
18818 * enum.cs: create the enum static fields using the enum type.
18820 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
18822 * class.cs: don't try to create the ParamBuilder for the return
18823 type if it's not needed (and handle it breaking for the ms runtime
18826 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
18828 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
18830 2002-12-29 Miguel de Icaza <miguel@ximian.com>
18832 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
18833 the command. This showed up while compiling the JANET source
18834 code, which used \r as its only newline separator.
18836 2002-12-28 Miguel de Icaza <miguel@ximian.com>
18838 * class.cs (Method.Define): If we are an operator (because it
18839 reuses our code), then set the SpecialName and HideBySig. #36128
18841 2002-12-22 Miguel de Icaza <miguel@ximian.com>
18843 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
18844 exception, report error 120 `object reference required'.
18846 * driver.cs: Add --pause option, used during to measure the size
18847 of the process as it goes with --timestamp.
18849 * expression.cs (Invocation.DoResolve): Do not allow methods with
18850 SpecialName to be invoked.
18852 2002-12-21 Miguel de Icaza <miguel@ximian.com>
18854 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
18855 number before adding it.
18857 2002-12-21 Ravi Pratap <ravi@ximian.com>
18859 * ecore.cs (StandardImplicitConversion): When in an unsafe
18860 context, we allow conversion between void * to any other pointer
18861 type. This fixes bug #35973.
18863 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
18865 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
18866 is not thrown when extensionless outputs are used
18868 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18870 * rootcontext.cs: fixed compilation of corlib.
18872 2002-12-19 Miguel de Icaza <miguel@ximian.com>
18874 * attribute.cs (Attributes.Contains): Add new method.
18876 * class.cs (MethodCore.LabelParameters): if the parameter is an
18877 `out' parameter, check that no attribute `[In]' has been passed.
18879 * enum.cs: Handle the `value__' name in an enumeration.
18881 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
18883 * decl.cs: Added special case to allow overrides on "protected
18886 2002-12-18 Ravi Pratap <ravi@ximian.com>
18888 * attribute.cs (Attributes.AddAttributeSection): Rename to this
18889 since it makes much more sense.
18891 (Attributes.ctor): Don't require a Location parameter.
18893 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
18895 * attribute.cs (ApplyAttributes): Remove extra Location parameters
18896 since we already have that information per attribute.
18898 * everywhere : make appropriate changes.
18900 * class.cs (LabelParameters): Write the code which actually
18901 applies attributes to the return type. We can't do this on the MS
18902 .NET runtime so we flag a warning in the case an exception is
18905 2002-12-18 Miguel de Icaza <miguel@ximian.com>
18907 * const.cs: Handle implicit null conversions here too.
18909 2002-12-17 Ravi Pratap <ravi@ximian.com>
18911 * class.cs (MethodCore.LabelParameters): Remove the extra
18912 Type [] parameter since it is completely unnecessary. Instead
18913 pass in the method's attributes so that we can extract
18914 the "return" attribute.
18916 2002-12-17 Miguel de Icaza <miguel@ximian.com>
18918 * cs-parser.jay (parse): Use Report.Error to flag errors instead
18919 of ignoring it and letting the compile continue.
18921 * typemanager.cs (ChangeType): use an extra argument to return an
18922 error condition instead of throwing an exception.
18924 2002-12-15 Miguel de Icaza <miguel@ximian.com>
18926 * expression.cs (Unary.TryReduce): mimic the code for the regular
18927 code path. Perform an implicit cast in the cases where we can
18928 implicitly convert to one of the integral types, and then reduce
18929 based on that constant. This fixes bug #35483.
18931 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18933 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
18935 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18937 * namespace.cs: fixed bug #35489.
18939 2002-12-12 Miguel de Icaza <miguel@ximian.com>
18941 * class.cs: Remove some dead code.
18943 * cs-parser.jay: Estimate the number of methods needed
18944 (RootContext.MethodCount);
18946 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
18947 numbers instead of StringBuilders.
18949 * support.cs (PtrHashtable): Add constructor with initial size;
18950 We can now reduce reallocations of the method table.
18952 2002-12-10 Ravi Pratap <ravi@ximian.com>
18954 * attribute.cs (ApplyAttributes): Keep track of the emitted
18955 attributes on a per-target basis. This fixes bug #35413.
18957 2002-12-10 Miguel de Icaza <miguel@ximian.com>
18959 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
18960 default to the Windows 1252 encoding.
18962 (UnixParseOption): Support version, thanks to Alp for the missing
18965 * AssemblyInfo.cs: Add nice assembly information.
18967 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
18970 * cs-parser.jay: Allow a trailing comma before the close bracked
18971 in the attribute_section production.
18973 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
18974 address of the instance was being taken, I will take this out,
18975 because we take the address of the object immediately here.
18977 2002-12-09 Ravi Pratap <ravi@ximian.com>
18979 * typemanager.cs (AreMultipleAllowed): Take care of the most
18980 obvious case where attribute type is not in the current assembly -
18983 2002-12-08 Miguel de Icaza <miguel@ximian.com>
18985 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
18986 definitions, instead of doing that afterwards.
18988 Also we use a nice little hack, depending on the constructor, we
18989 know if we are a "composed" name or a simple name. Hence, we
18990 avoid the IndexOf test, and we avoid
18992 * codegen.cs: Add code to assist in a bug reporter to track down
18993 the source of a compiler crash.
18995 2002-12-07 Ravi Pratap <ravi@ximian.com>
18997 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
18998 types have been emitted for a given element and flag an error
18999 if something which does not have AllowMultiple set is used more
19002 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
19003 attribute types and their corresponding AllowMultiple properties
19005 (AreMultipleAllowed): Check the property for a given type.
19007 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
19008 property in the case we have a TypeContainer.
19010 (Attributes.AddAttribute): Detect duplicates and just skip on
19011 adding them. This trivial fix catches a pretty gross error in our
19012 attribute emission - global attributes were being emitted twice!
19014 Bugzilla bug #33187 is now fixed.
19016 2002-12-06 Miguel de Icaza <miguel@ximian.com>
19018 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
19019 instead of pp_and).
19021 * expression.cs (Binary.ResolveOperator): I can only use the
19022 Concat (string, string, string) and Concat (string, string,
19023 string, string) if the child is actually a concatenation of
19026 2002-12-04 Miguel de Icaza <miguel@ximian.com>
19028 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
19029 context where we need a 2-character lookahead.
19031 * pending.cs (PendingImplementation): Rework so we can keep track
19032 of interface types all the time, and flag those which were
19033 implemented by parents as optional.
19035 2002-12-03 Miguel de Icaza <miguel@ximian.com>
19037 * expression.cs (Binary.ResolveOperator): Use
19038 String.Concat(string,string,string) or
19039 String.Concat(string,string,string,string) when possible.
19041 * typemanager: More helper methods.
19044 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
19046 * pending.cs: remove the bogus return from GetMissingInterfaces()
19047 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
19049 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19051 * namespace.cs: avoid duplicated 'using xxx' being added to
19052 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
19053 when we get more than one 'using' statement for the same namespace.
19054 Report a CS0105 warning for it.
19056 2002-11-30 Miguel de Icaza <miguel@ximian.com>
19058 * cs-tokenizer.cs (consume_identifier): use read directly, instead
19059 of calling getChar/putback, uses internal knowledge of it.
19061 (xtoken): Reorder tokenizer so most common patterns are checked
19062 first. This reduces the compilation time in another 5% (from 8.11s
19063 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
19065 The parsing time is 22% of the compilation in mcs, and from that
19066 64% is spent on the tokenization process.
19068 I tried using a binary search for keywords, but this is slower
19069 than the hashtable. Another option would be to do a couple of
19072 * Not use a StringBuilder, instead use an array of chars,
19073 with a set value. Notice that this way we could catch
19074 the 645 error without having to do it *afterwards*.
19076 * We could write a hand-parser to avoid the hashtable
19077 compares altogether.
19079 The identifier consumption process takes 37% of the tokenization
19080 time. Another 15% is spent on is_number. 56% of the time spent
19081 on is_number is spent on Int64.Parse:
19083 * We could probably choose based on the string length to
19084 use Int32.Parse or Int64.Parse and avoid all the 64-bit
19087 Another 3% is spend on wrapping `xtoken' in the `token' function.
19089 Handle 0xa0 as whitespace (#34752)
19091 2002-11-26 Miguel de Icaza <miguel@ximian.com>
19093 * typemanager.cs (IsCLRType): New routine to tell whether a type
19094 is one of the builtin types.
19096 Maybe it needs to use TypeCodes to be faster. Maybe we could use
19097 typecode in more places instead of doing pointer comparissions.
19098 We could leverage some knowledge about the way the typecodes are
19101 New code to cache namespaces in assemblies, it is currently not
19102 invoked, to be used soon.
19104 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
19106 * expression.cs (Binary.ResolveOperator): specially handle
19107 strings, and do not perform user-defined operator overloading for
19110 2002-11-24 Miguel de Icaza <miguel@ximian.com>
19112 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
19113 internalcall as it is a pretty simple operation; Avoid whenever
19114 possible to call Char.IsLetter.
19116 (consume_identifier): Cut by half the number of
19117 hashtable calls by merging the is_keyword and GetKeyword behavior.
19119 Do not short-circuit, because if we do, we
19120 report errors (ie, #if false && true would produce an invalid
19124 2002-11-24 Martin Baulig <martin@ximian.com>
19126 * expression.cs (Cast.TryReduce): If we're in checked syntax,
19127 check constant ranges and report a CS0221. Fixes #33186.
19129 2002-11-24 Martin Baulig <martin@ximian.com>
19131 * cs-parser.jay: Make this work for uninitialized variable
19132 declarations in the `for' initializer. Fixes #32416.
19134 2002-11-24 Martin Baulig <martin@ximian.com>
19136 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
19137 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
19139 2002-11-24 Martin Baulig <martin@ximian.com>
19141 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
19142 argument; if true, we also check for user-defined conversions.
19143 This is only needed if both arguments are of a user-defined type.
19144 Fixes #30443, added test-175.cs.
19145 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
19147 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
19149 2002-11-24 Martin Baulig <martin@ximian.com>
19151 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
19152 function to get the store opcode.
19153 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
19154 only emit the Ldelema if the store opcode is Stobj. You must run
19155 both test-34 and test-167 to test this. Fixes #34529.
19157 2002-11-23 Martin Baulig <martin@ximian.com>
19159 * ecore.cs (Expression.MemberLookup): Added additional
19160 `qualifier_type' argument which is used when we're being called
19161 from MemberAccess.DoResolve() and null if we're called from a
19163 (Expression.MemberLookupFailed): New method to report errors; this
19164 does the CS1540 check and reports the correct error message.
19166 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
19167 argument for the CS1540 check and redone the way how we're dealing
19168 with private members. See the comment in the source code for details.
19169 (FilterWithClosure): Reverted this back to revision 1.197; renamed
19170 `closure_start_type' to `closure_qualifier_type' and check whether
19171 it's not null. It was not this filter being broken, it was just
19172 being called with the wrong arguments.
19174 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
19175 and pass it the correct `qualifier_type'; this also does the error
19178 2002-11-22 Miguel de Icaza <miguel@ximian.com>
19180 * expression.cs (Invocation.EmitParams): If the we are dealing
19181 with a non-built-in value type, load its address as well.
19183 (ArrayCreation): Use a a pretty constant instead
19184 of the hardcoded value 2. Use 6 instead of 2 for the number of
19185 static initializers.
19187 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
19188 because they are not really value types, just glorified integers.
19190 * driver.cs: Do not append .exe, the CSC compiler does not do it.
19192 * ecore.cs: Remove redundant code for enumerations, make them use
19193 the same code path as everything else, fixes the casting issue
19194 with enumerations in Windows.Forms.
19196 * attribute.cs: Do only cast to string if it is a string, the
19197 validation happens later.
19199 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
19200 people upgrade their corlibs.
19202 * ecore.cs: Oops, enumerations were not following the entire code path
19204 2002-11-21 Miguel de Icaza <miguel@ximian.com>
19206 * typemanager.cs (FilterWithClosure): Commented out the test for
19207 1540 in typemanager.cs, as it has problems when accessing
19208 protected methods from a parent class (see test-174.cs).
19210 * attribute.cs (Attribute.ValidateGuid): new method.
19211 (Attribute.Resolve): Use above.
19213 2002-11-19 Miguel de Icaza <miguel@ximian.com>
19215 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
19217 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
19218 handling for enumerations, as we only needed the TypeContainer
19219 functionality to begin with (this is required for the fix below to
19220 work for enums that reference constants in a container class for
19223 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
19225 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
19226 a valid TypeBuilder to perform lookups on.o
19228 * class.cs (InheritableMemberSignatureCompare): Use true in the
19229 call to GetGetMethod and GetSetMethod, because we are comparing
19230 the signature, and we need to get the methods *even* if they are
19233 (PropertyBase.CheckBase): ditto.
19235 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
19236 GotoCase.Resolve): Use Peel on EmpytCasts.
19238 * ecore.cs (EmptyCast): drop child, add Peel method.
19240 2002-11-17 Martin Baulig <martin@ximian.com>
19242 * ecore.cs (EmptyCast.Child): New public property.
19244 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
19245 label resolved to an EmptyCast. Fixes #34162.
19246 (GotoCase.Resolve): Likewise.
19247 (Block.EmitMeta): Likewise.
19249 2002-11-17 Martin Baulig <martin@ximian.com>
19251 * expression.cs (Invocation.BetterConversion): Prefer int over
19252 uint; short over ushort; long over ulong for integer literals.
19253 Use ImplicitConversionExists instead of StandardConversionExists
19254 since we also need to check for user-defined implicit conversions.
19255 Fixes #34165. Added test-173.cs.
19257 2002-11-16 Martin Baulig <martin@ximian.com>
19259 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
19260 with the `true' and `false' literals. Fixes #33151.
19262 2002-11-16 Martin Baulig <martin@ximian.com>
19264 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
19265 October 22nd; don't do the cs1540 check for static members.
19267 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
19268 now using our own filter here and doing the cs1540 check again.
19270 2002-11-16 Martin Baulig <martin@ximian.com>
19272 * support.cs (InternalParameters): Don't crash if we don't have
19273 any fixed parameters. Fixes #33532.
19275 2002-11-16 Martin Baulig <martin@ximian.com>
19277 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
19278 when looking up static methods to make this work on Windows.
19281 2002-11-16 Martin Baulig <martin@ximian.com>
19283 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
19284 a setter rather than using PropertyInfo.CanWrite.
19286 2002-11-15 Nick Drochak <ndrochak@gol.com>
19288 * class.cs: Allow acces to block member by subclasses. Fixes build
19291 2002-11-14 Martin Baulig <martin@ximian.com>
19293 * class.cs (Constructor.Emit): Added the extern/block check.
19296 2002-11-14 Martin Baulig <martin@ximian.com>
19298 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
19299 iteration while looking for indexers, this is needed because the
19300 indexer may have a different name in our base classes. Fixed the
19301 error reporting (no indexers at all, not get accessor, no
19302 overloaded match). Fixes bug #33089.
19303 (IndexerAccess.DoResolveLValue): Likewise.
19305 2002-11-14 Martin Baulig <martin@ximian.com>
19307 * class.cs (PropertyBase.CheckBase): Make this work for multiple
19308 indexers. Fixes the first part of bug #33089.
19309 (MethodSignature.InheritableMemberSignatureCompare): Added support
19312 2002-11-13 Ravi Pratap <ravi@ximian.com>
19314 * attribute.cs (Attribute.Resolve): Catch the
19315 NullReferenceException and report it since it isn't supposed to
19318 2002-11-12 Miguel de Icaza <miguel@ximian.com>
19320 * expression.cs (Binary.EmitBranchable): Also handle the cases for
19321 LogicalOr and LogicalAnd that can benefit from recursively
19322 handling EmitBranchable. The code now should be nice for Paolo.
19324 2002-11-08 Miguel de Icaza <miguel@ximian.com>
19326 * typemanager.cs (LookupType): Added a negative-hit hashtable for
19327 the Type lookups, as we perform quite a number of lookups on
19328 non-Types. This can be removed once we can deterministically tell
19329 whether we have a type or a namespace in advance.
19331 But this might require special hacks from our corlib.
19335 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
19336 and double which avoids a conversion from an integer to a double.
19338 * expression.cs: tiny optimization, avoid calling IsConstant,
19339 because it effectively performs the lookup twice.
19341 2002-11-06 Miguel de Icaza <miguel@ximian.com>
19343 But a bogus return here to keep the semantics of the old code
19344 until the Mono runtime is fixed.
19346 * pending.cs (GetMissingInterfaces): New method used to remove all
19347 the interfaces that are already implemented by our parent
19348 classes from the list of pending methods.
19350 * interface.cs: Add checks for calls after ResolveTypeExpr.
19352 2002-11-05 Miguel de Icaza <miguel@ximian.com>
19354 * class.cs (Class.Emit): Report warning 67: event not used if the
19355 warning level is beyond 3.
19357 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
19358 being a NullLiteral.
19360 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
19363 * class.cs (TypeContainer.GetClassBases): Cover a missing code
19364 path that might fail if a type can not be resolved.
19366 * expression.cs (Binary.Emit): Emit unsigned versions of the
19369 * driver.cs: use error 5.
19371 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
19373 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
19375 2002-11-01 Miguel de Icaza <miguel@ximian.com>
19377 * cs-parser.jay (switch_section): A beautiful patch from Martin
19378 Baulig that fixed 33094.
19380 2002-10-31 Miguel de Icaza <miguel@ximian.com>
19382 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
19383 Check whether the base is abstract and report an error if so.
19385 * expression.cs (IndexerAccess.DoResolveLValue,
19386 IndexerAccess.DoResolve): ditto.
19388 (Invocation.DoResolve): ditto.
19390 (Invocation.FullMethodDesc): Improve the report string.
19392 * statement.cs (Block): Eliminate IsVariableDefined as it is
19393 basically just a wrapper for GetVariableInfo.
19395 * ecore.cs (SimpleName): Use new
19397 * support.cs (ReflectionParamter.ParameterType): We unwrap the
19398 type, as we return the actual parameter ref/unref state on a
19401 2002-10-30 Miguel de Icaza <miguel@ximian.com>
19403 * support.cs: Return proper flags REF/OUT fixing the previous
19406 * expression.cs: Reverted last patch, that was wrong. Is_ref is
19407 not used to mean `ref' but `ref or out' in ParameterReference
19409 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
19410 full type signature instead of calling TypeManger.CSharpName
19413 * support.cs (InternalParameters.ParameterDesc): Do not compare
19414 directly to the modflags, because REF/OUT will actually be bitsets
19417 * delegate.cs (VerifyMethod): Check also the modifiers.
19419 * cs-tokenizer.cs: Fix bug where floating point values with an
19420 exponent where a sign was missing was ignored.
19422 * driver.cs: Allow multiple assemblies to be specified in a single
19425 2002-10-28 Miguel de Icaza <miguel@ximian.com>
19427 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
19428 because identifiers after a parenthesis would end up in this kind
19429 of production, and we needed to desamiguate it for having casts
19432 (UserDefinedType *) xxx
19434 2002-10-24 Miguel de Icaza <miguel@ximian.com>
19436 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
19437 we should set on the Bindingflags.NonPublic, but not turn on
19438 private_ok. private_ok controls whether a Private member is
19439 returned (this is chekced on the filter routine), while the
19440 BindingFlags.NonPublic just controls whether private/protected
19441 will be allowed. This fixes the problem part of the problem of
19442 private properties being allowed to be used in derived classes.
19444 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
19445 so we can call the children DoResolveLValue method (this will
19446 properly signal errors on lvalue assignments to base properties)
19448 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
19449 getter are null, and we have a property info, we know that this
19450 happened because the lookup failed, so we report an error 122 for
19451 protection level violation.
19453 We also silently return if setter and getter are null in the
19454 resolve functions, this condition only happens if we have flagged
19455 the error before. This is the other half of the problem.
19457 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
19458 not have accessibility information, that is why we were returning
19459 true in the filter function in typemanager.cs.
19461 To properly report 122 (property is inaccessible because of its
19462 protection level) correctly, we report this error in ResolveAccess
19463 by failing if both the setter and the getter are lacking (ie, the
19466 DoResolve and DoLResolve have been modified to check for both
19467 setter/getter being null and returning silently, the reason being
19468 that I did not want to put the knowledge about this error in upper
19471 int old = Report.Errors;
19472 x = new PropertyExpr (...);
19473 if (old != Report.Errors)
19478 So the property expr is returned, but it is invalid, so the error
19479 will be flagged during the resolve process.
19481 * class.cs: Remove InheritablePropertySignatureCompare from the
19482 class, as we no longer depend on the property signature to compute
19483 whether it is possible to implement a method or not.
19485 The reason is that calling PropertyInfo.GetGetMethod will return
19486 null (in .NET, in Mono it works, and we should change this), in
19487 cases where the Get Method does not exist in that particular
19492 class X { public virtual int A { get { return 1; } } }
19494 class Z : Y { public override int A { get { return 2; } } }
19496 Would fail in Z because the parent (Y) would not have the property
19497 defined. So we avoid this completely now (because the alternative
19498 fix was ugly and slow), and we now depend exclusively on the
19501 (PropertyBase.CheckBase): Use a method-base mechanism to find our
19502 reference method, instead of using the property.
19504 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
19505 routines are gone now.
19507 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
19508 names, they were incorrectly named.
19510 * cs-tokenizer.cs: Return are more gentle token on failure.
19512 * pending.cs (PendingImplementation.InterfaceMethod): This routine
19513 had an out-of-sync index variable, which caused it to remove from
19514 the list of pending methods the wrong method sometimes.
19516 2002-10-22 Miguel de Icaza <miguel@ximian.com>
19518 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
19519 CanWrite, because those refer to this particular instance of the
19520 property, and do not take into account the fact that we can
19521 override single members of a property.
19523 Constructor requires an EmitContext. The resolution process does
19524 not happen here, but we need to compute the accessors before,
19525 because the resolution does not always happen for properties.
19527 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
19528 subclass, before we did not update this flag, but we did update
19531 (GetAccessors): Drop this routine, as it did not work in the
19532 presence of partially overwritten set/get methods.
19534 Notice that this broke the cs1540 detection, but that will require
19537 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19541 * driver.cs: issue a warning instead of an error if we don't support
19542 debugging for the platform. Also ignore a couple of errors that may
19543 arise when trying to write the symbols. Undo my previous patch.
19545 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19547 * driver.cs: ignore /debug switch except for Unix platforms.
19549 2002-10-23 Nick Drochak <ndrochak@gol.com>
19551 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
19553 2002-10-21 Miguel de Icaza <miguel@ximian.com>
19555 * driver.cs: Do not make mcs-debug conditional, so we do not break
19556 builds that use it.
19558 * statement.cs (UsageVector.MergeChildren): I would like Martin to
19559 review this patch. But basically after all the children variables
19560 have been merged, the value of "Breaks" was not being set to
19561 new_breaks for Switch blocks. I think that it should be set after
19562 it has executed. Currently I set this to the value of new_breaks,
19563 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
19564 conservative, but I do not understand this code very well.
19566 I did not break anything in the build, so that is good ;-)
19568 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
19570 2002-10-20 Mark Crichton <crichton@gimp.org>
19572 * cfold.cs: Fixed compile blocker. Really fixed it this time.
19574 2002-10-20 Nick Drochak <ndrochak@gol.com>
19576 * cfold.cs: Fixed compile blocker.
19578 2002-10-20 Miguel de Icaza <miguel@ximian.com>
19580 * driver.cs: I was chekcing the key, not the file.
19582 2002-10-19 Ravi Pratap <ravi@ximian.com>
19584 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
19585 message that we were generating - we just need to silently return
19588 2002-10-19 Miguel de Icaza <miguel@ximian.com>
19590 * class.cs (Event.Define): Change my previous commit, as this
19591 breaks the debugger. This is a temporary hack, as it seems like
19592 the compiler is generating events incorrectly to begin with.
19594 * expression.cs (Binary.ResolveOperator): Added support for
19595 "U operator - (E x, E y)"
19597 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
19600 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
19601 init-only variables, but this path did not take into account that
19602 there might be also instance readonly variables. Correct this
19605 This fixes bug 32253
19607 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
19610 * driver.cs: Change the extension for modules to `netmodule'
19612 * cs-parser.jay: Improved slightly the location tracking for
19613 the debugger symbols.
19615 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
19616 modifiers that were specified instead of the hardcoded value
19617 (FamAndAssem). This was basically ignoring the static modifier,
19618 and others. Fixes 32429.
19620 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
19621 fixed a bug in the process (32476)
19623 * expression.cs (ArrayAccess.EmitAssign): Patch from
19624 hwang_rob@yahoo.ca that fixes bug 31834.3
19626 2002-10-18 Miguel de Icaza <miguel@ximian.com>
19628 * driver.cs: Make the module extension .netmodule.
19630 2002-10-16 Miguel de Icaza <miguel@ximian.com>
19632 * driver.cs: Report an error if the resource file is not found
19633 instead of crashing.
19635 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
19636 false, like Emit does.
19638 2002-10-16 Nick Drochak <ndrochak@gol.com>
19640 * typemanager.cs: Remove unused private member. Also reported mcs
19641 bug to report this as a warning like csc.
19643 2002-10-15 Martin Baulig <martin@gnome.org>
19645 * statement.cs (Statement.Emit): Made this a virtual method; emits
19646 the line number info and calls DoEmit().
19647 (Statement.DoEmit): New protected abstract method, formerly knows
19648 as Statement.Emit().
19650 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
19652 2002-10-11 Miguel de Icaza <miguel@ximian.com>
19654 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
19655 have fixed a remaining problem: not every AddXXXX was adding a
19656 fully qualified name.
19658 Now everyone registers a fully qualified name in the DeclSpace as
19659 being defined instead of the partial name.
19661 Downsides: we are slower than we need to be due to the excess
19662 copies and the names being registered this way.
19664 The reason for this is that we currently depend (on the corlib
19665 bootstrap for instance) that types are fully qualified, because
19666 we dump all the types in the namespace, and we should really have
19667 types inserted into the proper namespace, so we can only store the
19668 basenames in the defined_names array.
19670 2002-10-10 Martin Baulig <martin@gnome.org>
19672 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
19673 from bug #31834, see the bug report for a testcase which is
19676 2002-10-10 Martin Baulig <martin@gnome.org>
19678 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
19679 flow analysis code for this.
19681 * statement.cs (Do, While, For): Tell the flow analysis code about
19683 (FlowBranching.UsageVector): Added support for infinite loops.
19684 (Block.Resolve): Moved the dead code elimination here and use flow
19687 2002-10-09 Miguel de Icaza <miguel@ximian.com>
19689 * class.cs (Field.Define): Catch cycles on struct type
19692 * typemanager.cs (IsUnmanagedtype): Do not recursively check
19693 fields if the fields are static. We only need to check instance
19696 * expression.cs (As.DoResolve): Test for reference type.
19698 * statement.cs (Using.ResolveExpression): Use
19699 ConvertImplicitRequired, not ConvertImplicit which reports an
19701 (Using.ResolveLocalVariableDecls): ditto.
19703 * expression.cs (Binary.ResolveOperator): Report errors in a few
19704 places where we had to.
19706 * typemanager.cs (IsUnmanagedtype): Finish implementation.
19708 2002-10-08 Miguel de Icaza <miguel@ximian.com>
19710 * expression.cs: Use StoreFromPtr instead of extracting the type
19711 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
19713 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
19714 an enumeration value to a System.Enum, but System.Enum is not a
19715 value type, but an class type, so we need to box.
19717 (Expression.ConvertExplicit): One codepath could return
19718 errors but not flag them. Fix this. Fixes #31853
19720 * parameter.cs (Resolve): Do not allow void as a parameter type.
19722 2002-10-06 Martin Baulig <martin@gnome.org>
19724 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
19725 if it's a class type and not a struct. Fixes #31815.
19727 2002-10-06 Martin Baulig <martin@gnome.org>
19729 * statement.cs: Reworked the flow analysis code a bit to make it
19730 usable for dead code elimination.
19732 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19734 * cs-parser.jay: allow empty source files. Fixes bug #31781.
19736 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19738 * expression.cs (ComposedCast.DoResolveType): A quick workaround
19739 to fix the test 165, will investigate deeper.
19741 2002-10-04 Martin Baulig <martin@gnome.org>
19743 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
19744 finally blocks actually work.
19745 (Try.Resolve): We don't need to create a sibling for `finally' if
19746 there is no finally block.
19748 2002-10-04 Martin Baulig <martin@gnome.org>
19750 * class.cs (Constructor.Define): The default accessibility for a
19751 non-default constructor is private, not public.
19753 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19755 * class.cs (Constructor): Make AllowedModifiers public, add
19758 * cs-parser.jay: Perform the modifiers test here, as the
19759 constructor for the Constructor class usually receives a zero
19760 because of the way we create it (first we create, later we
19761 customize, and we were never checking the modifiers).
19763 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
19764 is a version of LookupTypeReflection that includes the type-name
19765 cache. This can be used as a fast path for functions that know
19766 the fully qualified name and are only calling into *.GetType() to
19767 obtain a composed type.
19769 This is also used by TypeManager.LookupType during its type
19772 (LookupType): We now also track the real type name, as sometimes
19773 we can get a quey for the real type name from things like
19774 ComposedCast. This fixes bug 31422.
19776 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
19777 complete type fullname, it does not have to go through the type
19778 resolution system to obtain the composed version of the type (for
19779 obtaining arrays or pointers).
19781 (Conditional.Emit): Use the EmitBoolExpression to
19782 generate nicer code, as requested by Paolo.
19784 (ArrayCreation.CheckIndices): Use the patch from
19785 hwang_rob@yahoo.ca to validate the array initializers.
19787 2002-10-03 Miguel de Icaza <miguel@ximian.com>
19789 * class.cs (ConstructorInitializer.Emit): simplify code by using
19790 Invocation.EmitCall, and at the same time, fix the bugs in calling
19791 parent constructors that took variable arguments.
19793 * ecore.cs (Expression.ConvertNumericExplicit,
19794 Expression.ImplicitNumericConversion): Remove the code that
19795 manually wrapped decimal (InternalTypeConstructor call is now gone
19798 * expression.cs (Cast.TryReduce): Also handle decimal types when
19799 trying to perform a constant fold on the type.
19801 * typemanager.cs (IsUnmanagedtype): Partially implemented.
19803 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
19804 that only turned off an error report, and did nothing else.
19806 2002-10-02 Miguel de Icaza <miguel@ximian.com>
19808 * driver.cs: Handle and ignore /fullpaths
19810 2002-10-01 Miguel de Icaza <miguel@ximian.com>
19812 * expression.cs (Binary.ResolveOperator): Catch the case where
19813 DoNumericPromotions returns true,
19815 (Binary.DoNumericPromotions): Simplify the code, and the tests.
19817 2002-09-27 Miguel de Icaza <miguel@ximian.com>
19819 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
19822 2002-09-26 Miguel de Icaza <miguel@ximian.com>
19824 * ecore.cs (ConvertNumericExplicit): It is not enough that the
19825 conversion exists, but it is also required that the conversion be
19826 performed. This manifested in "(Type64Enum) 2".
19828 * class.cs (TypeManager.AddMethod): The fix is not to change
19829 AddEnum, because that one was using a fully qualified name (every
19830 DeclSpace derivative does), but to change the AddMethod routine
19831 that was using an un-namespaced name. This now correctly reports
19832 the duplicated name.
19834 Revert patch until I can properly fix it. The issue
19835 is that we have a shared Type space across all namespaces
19836 currently, which is wrong.
19838 Options include making the Namespace a DeclSpace, and merge
19839 current_namespace/current_container in the parser.
19841 2002-09-25 Miguel de Icaza <miguel@ximian.com>
19843 * cs-parser.jay: Improve error reporting when we get a different
19844 kind of expression in local_variable_type and
19845 local_variable_pointer_type.
19847 Propagate this to avoid missleading errors being reported.
19849 * ecore.cs (ImplicitReferenceConversion): treat
19850 TypeManager.value_type as a target just like object_type. As
19855 Is valid, and needs to result in the int 1 being boxed before it
19856 is assigned to the value type v.
19858 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
19859 to validate the enumeration name.
19861 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
19862 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
19863 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
19865 * ecore.cs (TryImplicitIntConversion): When doing an
19866 implicit-enumeration-conversion, check if the type is 64-bits and
19867 perform a conversion before passing to EnumConstant.
19869 2002-09-23 Miguel de Icaza <miguel@ximian.com>
19871 * decl.cs (Error_AmbiguousTypeReference); New routine used to
19872 report ambiguous type references. Unlike the MS version, we
19873 report what the ambiguity is. Innovation at work ;-)
19875 (DeclSpace.FindType): Require a location argument to
19876 display when we display an ambiguous error.
19878 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
19880 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
19882 * expression.cs (EmitDynamicInitializers): Apply patch from
19883 hwang_rob@yahoo.ca that fixes the order in which we emit our
19886 2002-09-21 Martin Baulig <martin@gnome.org>
19888 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
19889 delegate takes no arguments.
19891 2002-09-20 Miguel de Icaza <miguel@ximian.com>
19893 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
19896 * expression.cs: Extract the underlying type.
19898 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
19900 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
19902 2002-09-19 Miguel de Icaza <miguel@ximian.com>
19904 * class.cs (TypeContainer.DefineType): We can not use the nice
19905 PackingSize with the size set to 1 DefineType method, because it
19906 will not allow us to define the interfaces that the struct
19909 This completes the fixing of bug 27287
19911 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
19912 means also structs. This fixes part of the problem.
19913 (Expresion.ImplicitReferenceConversionExists): ditto.
19915 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
19916 error if there were no errors reported during the type lookup
19917 process, to avoid duplicates or redundant errors. Without this
19918 you would get an ambiguous errors plus a type not found. We have
19919 beaten the user enough with the first error.
19921 (DeclSparce.FindType): Emit a warning if we have an ambiguous
19924 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
19925 during the resolution process, stop the lookup, this avoids
19926 repeated error reports (same error twice).
19928 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
19930 * typemanager.cs (LookupType): Redo the type lookup code to match
19931 the needs of System.Reflection.
19933 The issue is that System.Reflection requires references to nested
19934 types to begin with a "+" sign instead of a dot. So toplevel
19935 types look like: "NameSpace.TopLevelClass", and nested ones look
19936 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
19939 2002-09-19 Martin Baulig <martin@gnome.org>
19941 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
19942 says that a method always returns or always throws an exception,
19943 don't report the CS0161.
19945 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
19946 set `Returns = new_returns'.
19948 2002-09-19 Martin Baulig <martin@gnome.org>
19950 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
19951 to an enum constant, check for a CS0176.
19953 2002-09-18 Miguel de Icaza <miguel@ximian.com>
19955 * class.cs (TypeContainer.CheckPairedOperators): Now we check
19956 for operators that must be in pairs and report errors.
19958 * ecore.cs (SimpleName.DoResolveType): During the initial type
19959 resolution process, when we define types recursively, we must
19960 check first for types in our current scope before we perform
19961 lookups in the enclosing scopes.
19963 * expression.cs (MakeByteBlob): Handle Decimal blobs.
19965 (Invocation.VerifyArgumentsCompat): Call
19966 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
19967 I thought we were supposed to always call this, but there are a
19968 few places in the code where we dont do it.
19970 2002-09-17 Miguel de Icaza <miguel@ximian.com>
19972 * driver.cs: Add support in -linkres and -resource to specify the
19973 name of the identifier.
19975 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19977 * ecore.cs (StandardConversionExists): Sync with the conversion
19978 code: allow anything-* to void* conversions.
19980 (FindMostSpecificSource): Use an Expression argument
19981 instead of a Type, because we might be handed over a Literal which
19982 gets a few more implicit conversions that plain types do not. So
19983 this information was being lost.
19985 Also, we drop the temporary type-holder expression when not
19988 2002-09-17 Martin Baulig <martin@gnome.org>
19990 * class.cs (PropertyBase.CheckBase): Don't check the base class if
19991 this is an explicit interface implementation.
19993 2002-09-17 Martin Baulig <martin@gnome.org>
19995 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
19996 different `IndexerName' attributes.
19998 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
19999 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
20000 virtual CommonResolve().
20002 2002-09-16 Miguel de Icaza <miguel@ximian.com>
20004 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
20005 and convert that to the UnderlyingType.
20007 * statement.cs (Foreach.Resolve): Indexers are just like variables
20008 or PropertyAccesses.
20010 * cs-tokenizer.cs (consume_string): Track line numbers and columns
20011 inside quoted strings, we were not doing this before.
20013 2002-09-16 Martin Baulig <martin@gnome.org>
20015 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
20016 resolve it. This is needed for the definite assignment check of the
20017 instance expression, fixes bug #29846.
20018 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
20020 2002-09-16 Nick Drochak <ndrochak@gol.com>
20022 * parameter.cs: Fix compile error. Cannot reference static member
20023 from an instance object. Is this an mcs bug?
20025 2002-09-14 Martin Baulig <martin@gnome.org>
20027 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
20028 multiple times. Fixes bug #30295, added test-166.cs.
20030 2002-09-14 Martin Baulig <martin@gnome.org>
20032 * statement.cs (Block.Emit): Don't emit unreachable code.
20033 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
20034 `break' statements.
20035 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
20037 2002-09-14 Martin Baulig <martin@gnome.org>
20039 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
20042 2002-09-14 Martin Baulig <martin@gnome.org>
20044 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
20045 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
20046 be false on the ms runtime.
20048 2002-09-13 Martin Baulig <martin@gnome.org>
20050 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
20051 the CS0038 error message.
20053 2002-09-12 Miguel de Icaza <miguel@ximian.com>
20055 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
20056 constant inside, return it.
20058 2002-09-12 Martin Baulig <martin@gnome.org>
20060 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
20061 implicit conversion can be done between enum types.
20063 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
20064 check whether an implicit conversion to the current enum's UnderlyingType
20065 exists and report an error if not.
20067 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
20068 without debugging support.
20070 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
20071 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
20073 2002-09-12 Martin Baulig <martin@gnome.org>
20075 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
20077 * ecore.cs (IMemberExpr.DeclaringType): New property.
20078 (SimpleName.SimpleNameResolve): Check whether we're accessing a
20079 nonstatic member of an outer type (CS0038).
20081 2002-09-11 Miguel de Icaza <miguel@ximian.com>
20083 * driver.cs: Activate the using-error detector at warning level
20084 4 (at least for MS-compatible APIs).
20086 * namespace.cs (VerifyUsing): Small buglett fix.
20088 * pending.cs (PendingImplementation): pass the container pointer.
20090 * interface.cs (GetMethods): Allow for recursive definition. Long
20091 term, I would like to move every type to support recursive
20092 definitions, not the current ordering mechanism that we have right
20095 The situation is this: Attributes are handled before interfaces,
20096 so we can apply attributes to interfaces. But some attributes
20097 implement interfaces, we will now handle the simple cases
20098 (recursive definitions will just get an error).
20100 * parameter.cs: Only invalidate types at the end if we fail to
20103 2002-09-09 Martin Baulig <martin@gnome.org>
20105 * ecore.cs (PropertyExpr.Emit): Also check for
20106 TypeManager.system_int_array_get_length so this'll also work when
20107 compiling corlib. Fixes #30003.
20109 2002-09-09 Martin Baulig <martin@gnome.org>
20111 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
20112 and throw an exception if we can't get the type's size. Fixed #30040,
20115 2002-09-09 Martin Baulig <martin@gnome.org>
20117 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
20119 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
20120 context. Fixes bug #30027.
20122 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
20123 virtual functions. Fixes bug #30043, added test-164.cs.
20125 2002-09-08 Ravi Pratap <ravi@ximian.com>
20127 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
20129 2002-09-08 Nick Drochak <ndrochak@gol.com>
20131 * driver.cs: Use an object to get the windows codepage since it's not a
20134 2002-09-08 Miguel de Icaza <miguel@ximian.com>
20136 * statement.cs (For.Emit): for infinite loops (test == null)
20137 return whether there is a break inside, not always "true".
20139 * namespace.cs (UsingEntry): New struct to hold the name of the
20140 using definition, the location where it is defined, and whether it
20141 has been used in a successful type lookup.
20143 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
20148 2002-09-06 Ravi Pratap <ravi@ximian.com>
20150 * attribute.cs : Fix incorrect code which relied on catching
20151 a NullReferenceException to detect a null being passed in
20152 where an object was expected.
20154 2002-09-06 Miguel de Icaza <miguel@ximian.com>
20156 * statement.cs (Try): flag the catch variable as assigned
20158 * expression.cs (Cast): Simplified by using ResolveType instead of
20159 manually resolving.
20161 * statement.cs (Catch): Fix bug by using ResolveType.
20163 2002-09-06 Ravi Pratap <ravi@ximian.com>
20165 * expression.cs (BetterConversion): Special case for when we have
20166 a NullLiteral as the argument and we have to choose between string
20167 and object types - we choose string the way csc does.
20169 * attribute.cs (Attribute.Resolve): Catch the
20170 NullReferenceException and report error #182 since the Mono
20171 runtime no more has the bug and having this exception raised means
20172 we tried to select a constructor which takes an object and is
20175 2002-09-05 Ravi Pratap <ravi@ximian.com>
20177 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
20178 message (1502, 1503) when we can't locate a method after overload
20179 resolution. This is much more informative and closes the bug
20182 * interface.cs (PopulateMethod): Return if there are no argument
20183 types. Fixes a NullReferenceException bug.
20185 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
20186 expressions too. Previously we were checking only in one place for
20187 positional arguments leaving out named arguments.
20189 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
20190 type to the enum type is not allowed. Remove code corresponding to
20193 (ConvertNumericExplicit): Allow explicit conversions from
20194 the underlying type to enum type. This precisely follows the spec
20195 and closes a bug filed by Gonzalo.
20197 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20200 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
20202 2002-09-03 Miguel de Icaza <miguel@ximian.com>
20204 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
20205 it was important that we stored the right value after the
20206 reduction in `converted'.
20208 2002-09-04 Martin Baulig <martin@gnome.org>
20210 * location.cs (Location.SymbolDocument): Use full pathnames for the
20213 2002-08-30 Miguel de Icaza <miguel@ximian.com>
20215 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
20216 of the expression resolve mechanism, because that will catch the
20217 SimpleName error failures.
20219 (Conditional): If we can not resolve the
20220 expression, return, do not crash.
20222 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20225 (location): display token name instead of its number.
20227 2002-08-28 Martin Baulig <martin@gnome.org>
20229 * expression.cs (Binary.ResolveOperator): Don't silently return
20230 but return an error if an operator cannot be applied between two
20233 2002-08-28 Martin Baulig <martin@gnome.org>
20235 * class.cs (Constructor.Define): Set the permission attributes
20236 correctly instead of making all constructors public.
20238 2002-08-28 Martin Baulig <martin@gnome.org>
20240 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
20241 for private members before reporting a CS0103; if we find anything,
20244 2002-08-28 Martin Baulig <martin@gnome.org>
20246 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
20247 to check whether `closure_start_type == closure_invocation_type',
20248 we also need to check whether `m.DeclaringType == closure_invocation_type'
20249 before bypassing the permission checks. We might be accessing
20250 protected/private members from the base class.
20251 (TypeManager.RealMemberLookup): Only set private_ok if private
20252 members were requested via BindingFlags.NonPublic.
20254 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
20256 * expression.cs (MemberAccess.ResolveMemberAccess): Set
20257 MethodGroupExpr.IsExplicitImpl if appropriate.
20258 (Invocation.DoResolve): Don't report the CS0120 for explicit
20259 interface implementations.
20261 2002-08-27 Martin Baulig <martin@gnome.org>
20263 * expression.cs (Invocation.DoResolve): If this is a static
20264 method and we don't have an InstanceExpression, we must report
20267 2002-08-25 Martin Baulig <martin@gnome.org>
20269 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
20270 `==' between a valuetype and an object.
20272 2002-08-25 Miguel de Icaza <miguel@ximian.com>
20274 * ecore.cs (TypeExpr): Provide a ToString method.
20276 2002-08-24 Martin Baulig <martin@gnome.org>
20278 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
20279 now called proggie.dbg and it's a binary file.
20281 2002-08-23 Martin Baulig <martin@gnome.org>
20283 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
20285 2002-08-23 Martin Baulig <martin@gnome.org>
20287 * struct.cs (MyStructInfo.ctor): Make this work with empty
20288 structs; it's not allowed to use foreach() on null.
20290 2002-08-23 Martin Baulig <martin@gnome.org>
20292 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
20293 writer the full pathname of the generated assembly.
20295 2002-08-23 Martin Baulig <martin@gnome.org>
20297 * statements.cs (FlowBranching.UsageVector.MergeChildren):
20298 A `finally' block never returns or breaks; improved handling of
20301 2002-08-23 Martin Baulig <martin@gnome.org>
20303 * statement.cs (Throw.Resolve): Allow `throw null'.
20305 2002-08-23 Martin Baulig <martin@gnome.org>
20307 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
20308 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
20309 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
20310 MemberLookup would return a wrong event if this is an explicit
20311 interface implementation and the class has an event with the same
20314 2002-08-23 Martin Baulig <martin@gnome.org>
20316 * statement.cs (Block.AddChildVariableNames): New public method.
20317 (Block.AddChildVariableName): Likewise.
20318 (Block.IsVariableNameUsedInChildBlock): Likewise.
20319 (Block.AddVariable): Check whether a variable name has already
20320 been used in a child block.
20322 * cs-parser.jay (declare_local_variables): Mark all variable names
20323 from the current block as being used in a child block in the
20326 2002-08-23 Martin Baulig <martin@gnome.org>
20328 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
20329 find the symbol writer.
20331 * driver.cs: csc also allows the arguments to /define being
20332 separated by commas, not only by semicolons.
20334 2002-08-23 Martin Baulig <martin@gnome.org>
20336 * interface.cs (Interface.GetMembers): Added static check for events.
20338 2002-08-15 Martin Baulig <martin@gnome.org>
20340 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
20341 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
20343 * ecore.cs (Expression.MemberLookup): Added documentation and explained
20344 why the MethodData.EmitDestructor() change was necessary.
20346 2002-08-20 Martin Baulig <martin@gnome.org>
20348 * class.cs (TypeContainer.FindMembers): Added static check for events.
20350 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
20352 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
20353 use Type.GetEvents(), not Type.FindMembers().
20355 2002-08-20 Martin Baulig <martin@gnome.org>
20357 * decl.cs (MemberCache): Added a special method cache which will
20358 be used for method-only searched. This ensures that a method
20359 search will return a MethodInfo with the correct ReflectedType for
20362 2002-08-20 Martin Baulig <martin@gnome.org>
20364 * decl.cs (DeclSpace.FindMembers): Made this public.
20366 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20368 * delegate.cs: fixed build on windows.
20369 [FIXME: Filed as bug #29150: MCS must report these errors.]
20371 2002-08-19 Ravi Pratap <ravi@ximian.com>
20373 * ecore.cs (StandardConversionExists): Return a false
20374 if we are trying to convert the void type to anything else
20375 since that is not allowed.
20377 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
20378 we flag error 70 in the event an event is trying to be accessed
20379 directly from outside the declaring type.
20381 2002-08-20 Martin Baulig <martin@gnome.org>
20383 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
20384 MemberCache from typemanager.cs to decl.cs.
20386 2002-08-19 Martin Baulig <martin@gnome.org>
20388 * class.cs (TypeContainer): Implement IMemberContainer.
20389 (TypeContainer.DefineMembers): Create the MemberCache.
20390 (TypeContainer.FindMembers): Do better BindingFlags checking; only
20391 return public members if BindingFlags.Public was given, check
20392 whether members are static.
20394 2002-08-16 Martin Baulig <martin@gnome.org>
20396 * decl.cs (DeclSpace.Define): Splitted this in Define and
20397 DefineMembers. DefineMembers is called first and initializes the
20400 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
20401 DefineMembers() on all our DeclSpaces.
20403 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
20404 but call DefineMembers() on all nested interfaces. We call their
20405 Define() in our new Define() function.
20407 * interface.cs (Interface): Implement IMemberContainer.
20408 (Interface.Define): Moved all code except the attribute stuf to
20410 (Interface.DefineMembers): Initialize the member cache.
20412 * typemanager.cs (IMemberFinder): Removed this interface, we don't
20413 need this anymore since we can use MemberCache.FindMembers directly.
20415 2002-08-19 Martin Baulig <martin@gnome.org>
20417 * typemanager.cs (MemberCache): When creating the cache for an
20418 interface type, add all inherited members.
20419 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
20420 to `out bool used_cache' and documented it.
20421 (TypeManager.MemberLookup): If we already used the cache in the first
20422 iteration, we don't need to do the interfaces check.
20424 2002-08-19 Martin Baulig <martin@gnome.org>
20426 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
20427 here from IMemberFinder and don't implement this interface anymore.
20428 (DeclSpace.MemberCache): Moved here from IMemberFinder.
20430 * typemanager.cs (IMemberFinder): This interface is now only used by
20431 classes which actually support the member cache.
20432 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
20433 since we only put DeclSpaces into this Hashtable.
20434 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
20435 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
20437 2002-08-16 Martin Baulig <martin@gnome.org>
20439 * typemanager.cs (ICachingMemberFinder): Removed.
20440 (IMemberFinder.MemberCache): New property.
20441 (TypeManager.FindMembers): Merged this with RealFindMembers().
20442 This function will never be called from TypeManager.MemberLookup()
20443 so we can't use the cache here, just the IMemberFinder.
20444 (TypeManager.MemberLookup_FindMembers): Check whether the
20445 IMemberFinder has a MemberCache and call the cache's FindMembers
20447 (MemberCache): Rewrote larger parts of this yet another time and
20448 cleaned it up a bit.
20450 2002-08-15 Miguel de Icaza <miguel@ximian.com>
20452 * driver.cs (LoadArgs): Support quoting.
20454 (Usage): Show the CSC-like command line arguments.
20456 Improved a few error messages.
20458 2002-08-15 Martin Baulig <martin@gnome.org>
20460 * typemanager.cs (IMemberContainer.Type): New property.
20461 (IMemberContainer.IsInterface): New property.
20463 The following changes are conditional to BROKEN_RUNTIME, which is
20464 defined at the top of the file.
20466 * typemanager.cs (MemberCache.MemberCache): Don't add the base
20467 class'es members, but add all members from TypeHandle.ObjectType
20468 if we're an interface.
20469 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
20470 is the current type.
20471 (MemberCache.CacheEntry.Container): Removed this field.
20472 (TypeHandle.GetMembers): Include inherited members.
20474 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20476 * typemanager.cs: fixed compilation and added a comment on a field that
20479 2002-08-15 Martin Baulig <martin@gnome.org>
20481 * class.cs (ConstructorInitializer.Resolve): In the
20482 Expression.MemberLookup call, use the queried_type as
20485 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
20486 declared' attribute, it's always true.
20487 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
20488 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
20489 temporary wrapper for FindMembers which tells MemberLookup whether
20490 members from the base classes are included in the return value.
20491 This will go away soon.
20492 (TypeManager.MemberLookup): Use this temporary hack here; once the
20493 new MemberCache is completed, we don't need to do the DeclaredOnly
20494 looping here anymore since the MemberCache will take care of this.
20495 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
20496 (MemberCache): When creating the MemberCache for a class, get
20497 members from the current class and all its base classes.
20498 (MemberCache.CacheEntry.Container): New field. This is a
20499 temporary hack until the Mono runtime is fixed to distinguish
20500 between ReflectedType and DeclaringType. It allows us to use MCS
20501 with both the MS runtime and the unfixed Mono runtime without
20502 problems and without accecting performance.
20503 (MemberCache.SearchMembers): The DeclaredOnly looping from
20504 TypeManager.MemberLookup is now done here.
20506 2002-08-14 Martin Baulig <martin@gnome.org>
20508 * statement.cs (MyStructInfo.MyStructInfo): Don't call
20509 Type.GetFields on dynamic types but get the fields from the
20510 corresponding TypeContainer.
20511 (MyStructInfo.GetStructInfo): Added check for enum types.
20513 * typemanager.cs (MemberList.IsSynchronized): Implemented.
20514 (MemberList.SyncRoot): Implemented.
20515 (TypeManager.FilterWithClosure): No need to check permissions if
20516 closure_start_type == closure_invocation_type, don't crash if
20517 closure_invocation_type is null.
20519 2002-08-13 Martin Baulig <martin@gnome.org>
20521 Rewrote TypeContainer.FindMembers to use a member cache. This
20522 gives us a speed increase of about 35% for the self-hosting MCS
20523 build and of about 15-20% for the class libs (both on GNU/Linux).
20525 * report.cs (Timer): New class to get enhanced profiling. This
20526 whole class is "TIMER" conditional since it remarkably slows down
20529 * class.cs (MemberList): New class. This is an IList wrapper
20530 which we're now using instead of passing MemberInfo[]'s around to
20531 avoid copying this array unnecessarily.
20532 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
20533 (ICachingMemberFinder, IMemberContainer): New interface.
20534 (TypeManager.FilterWithClosure): If `criteria' is null, the name
20535 has already been checked, otherwise use it for the name comparision.
20536 (TypeManager.FindMembers): Renamed to RealMemberFinder and
20537 provided wrapper which tries to use ICachingMemberFinder.FindMembers
20538 if possible. Returns a MemberList, not a MemberInfo [].
20539 (TypeHandle): New class, implements IMemberContainer. We create
20540 one instance of this class per type, it contains a MemberCache
20541 which is used to do the member lookups.
20542 (MemberCache): New class. Each instance of this class contains
20543 all members of a type and a name-based hash table.
20544 (MemberCache.FindMembers): This is our new member lookup
20545 function. First, it looks up all members of the requested name in
20546 the hash table. Then, it walks this list and sorts out all
20547 applicable members and returns them.
20549 2002-08-13 Martin Baulig <martin@gnome.org>
20551 In addition to a nice code cleanup, this gives us a performance
20552 increase of about 1.4% on GNU/Linux - not much, but it's already
20553 half a second for the self-hosting MCS compilation.
20555 * typemanager.cs (IMemberFinder): New interface. It is used by
20556 TypeManager.FindMembers to call FindMembers on a TypeContainer,
20557 Enum, Delegate or Interface.
20558 (TypeManager.finder_to_member_finder): New PtrHashtable.
20559 (TypeManager.finder_to_container): Removed.
20560 (TypeManager.finder_to_delegate): Removed.
20561 (TypeManager.finder_to_interface): Removed.
20562 (TypeManager.finder_to_enum): Removed.
20564 * interface.cs (Interface): Implement IMemberFinder.
20566 * delegate.cs (Delegate): Implement IMemberFinder.
20568 * enum.cs (Enum): Implement IMemberFinder.
20570 * class.cs (TypeContainer): Implement IMemberFinder.
20572 2002-08-12 Martin Baulig <martin@gnome.org>
20574 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
20576 2002-08-12 Martin Baulig <martin@gnome.org>
20578 * ecore.cs (ITypeExpression): New interface for expressions which
20580 (TypeExpression): Renamed to TypeLookupExpression.
20581 (Expression.DoResolve): If we're doing a types-only lookup, the
20582 expression must implement the ITypeExpression interface and we
20583 call DoResolveType() on it.
20584 (SimpleName): Implement the new ITypeExpression interface.
20585 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
20586 hack, the situation that we're only looking up types can't happen
20587 anymore when this method is called. Moved the type lookup code to
20588 DoResolveType() and call it.
20589 (SimpleName.DoResolveType): This ITypeExpression interface method
20590 is now doing the types-only lookup.
20591 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
20592 (ResolveFlags): Added MaskExprClass.
20594 * expression.cs (MemberAccess): Implement the ITypeExpression
20596 (MemberAccess.DoResolve): Added support for a types-only lookup
20597 when we're called via ITypeExpression.DoResolveType().
20598 (ComposedCast): Implement the ITypeExpression interface.
20600 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
20601 Expression.Resolve() with ResolveFlags.Type instead.
20603 2002-08-12 Martin Baulig <martin@gnome.org>
20605 * interface.cs (Interface.Define): Apply attributes.
20607 * attribute.cs (Attribute.ApplyAttributes): Added support for
20608 interface attributes.
20610 2002-08-11 Martin Baulig <martin@gnome.org>
20612 * statement.cs (Block.Emit): Only check the "this" variable if we
20613 do not always throw an exception.
20615 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
20616 whether the property has a set accessor.
20618 2002-08-11 Martin Baulig <martin@gnome.org>
20620 Added control flow analysis support for structs.
20622 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
20623 with control flow analysis turned off.
20624 (IVariable): New interface.
20625 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
20626 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
20627 (FieldExpr.DoResolve): Resolve the instance expression with flow
20628 analysis turned off and do the definite assignment check after the
20629 resolving when we know what the expression will resolve to.
20631 * expression.cs (LocalVariableReference, ParameterReference):
20632 Implement the new IVariable interface, only call the flow analysis
20633 code if ec.DoFlowAnalysis is true.
20634 (This): Added constructor which takes a Block argument. Implement
20635 the new IVariable interface.
20636 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
20637 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
20638 This does the definite assignment checks for struct members.
20640 * class.cs (Constructor.Emit): If this is a non-static `struct'
20641 constructor which doesn't have any initializer, call
20642 Block.AddThisVariable() to tell the flow analysis code that all
20643 struct elements must be initialized before control returns from
20646 * statement.cs (MyStructInfo): New public class.
20647 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
20648 argument to this indexer. If non-zero, check an individual struct
20649 member, not the whole struct.
20650 (FlowBranching.CheckOutParameters): Check struct members.
20651 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
20652 overloaded versions of these methods which take an additional
20653 `int field_idx' argument to check struct members.
20654 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
20655 overloaded versions of these methods which take an additional
20656 `string field_name' argument to check struct member.s
20657 (VariableInfo): Implement the IVariable interface.
20658 (VariableInfo.StructInfo): New public property. Returns the
20659 MyStructInfo instance of the variable if it's a struct or null.
20660 (Block.AddThisVariable): New public method. This is called from
20661 Constructor.Emit() for non-static `struct' constructor which do
20662 not have any initializer. It creates a special variable for the
20663 "this" instance variable which will be checked by the flow
20664 analysis code to ensure that all of the struct's fields are
20665 initialized before control returns from the constructor.
20666 (UsageVector): Added support for struct members. If a
20667 variable/parameter is a struct with N members, we reserve a slot
20668 in the usage vector for each member. A struct is considered fully
20669 initialized if either the struct itself (slot 0) or all its
20670 members are initialized.
20672 2002-08-08 Martin Baulig <martin@gnome.org>
20674 * driver.cs (Driver.MainDriver): Only report an error CS5001
20675 if there were no compilation errors.
20677 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
20678 `UnsafeContext' property to determine whether the parent is in
20679 unsafe context rather than checking the parent's ModFlags:
20680 classes nested in an unsafe class are unsafe as well.
20682 2002-08-08 Martin Baulig <martin@gnome.org>
20684 * statement.cs (UsageVector.MergeChildren): Distinguish between
20685 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
20686 we return. Added test17() and test18() to test-154.cs.
20688 2002-08-08 Martin Baulig <martin@gnome.org>
20690 * typemanager.cs (TypeManager.FilterWithClosure): If we have
20691 Family access, make sure the invoking type isn't a subclass of the
20692 queried type (that'd be a CS1540).
20694 * ecore.cs (Expression.MemberLookup): Added overloaded version of
20695 this method which takes an additional `Type invocation_type'.
20697 * expression.cs (BaseAccess.DoResolve): Use the base type as
20698 invocation and query type.
20699 (MemberAccess.DoResolve): If the lookup failed and we're about to
20700 report a CS0122, try a lookup with the ec.ContainerType - if this
20701 succeeds, we must report a CS1540.
20703 2002-08-08 Martin Baulig <martin@gnome.org>
20705 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
20706 (MethodGroupExpr): Implement the IMemberExpr interface.
20708 * expression (MemberAccess.ResolveMemberAccess): No need to have
20709 any special code for MethodGroupExprs anymore, they're now
20712 2002-08-08 Martin Baulig <martin@gnome.org>
20714 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
20715 Family, FamANDAssem and FamORAssem permissions.
20716 (TypeManager.IsSubclassOrNestedChildOf): New public method.
20718 2002-08-08 Martin Baulig <martin@gnome.org>
20720 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
20721 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
20724 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
20726 * driver.cs: implemented /resource option to embed managed resources.
20728 2002-08-07 Martin Baulig <martin@gnome.org>
20730 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
20731 (FieldBase.HasFieldInitializer): New public property.
20732 (FieldBase.GetInitializerExpression): New public method. Resolves and
20733 returns the field initializer and makes sure it is only resolved once.
20734 (TypeContainer.EmitFieldInitializers): Call
20735 FieldBase.GetInitializerExpression to get the initializer, this ensures
20736 that it isn't resolved multiple times.
20738 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
20739 the resolving process (SimpleName/MemberLookup) that we're currently
20740 emitting a field initializer (which must not access any instance members,
20741 this is an error CS0236).
20743 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
20744 argument, if the `IsFieldInitializer' flag is set, we must report and
20745 error CS0236 and not an error CS0120.
20747 2002-08-07 Martin Baulig <martin@gnome.org>
20749 * ecore.cs (IMemberExpr): New public interface.
20750 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
20751 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
20752 if the expression is an IMemberExpr.
20754 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
20755 to be null, implicitly default to `this' if we're non-static in
20756 this case. Simplified the code a lot by using the new IMemberExpr
20757 interface. Also fixed bug #28176 here.
20759 2002-08-06 Martin Baulig <martin@gnome.org>
20761 * cs-parser.jay (SimpleLookup): Removed. We need to create
20762 ParameterReferences during semantic analysis so that we can do a
20763 type-only search when resolving Cast, TypeOf and SizeOf.
20764 (block): Pass the `current_local_parameters' to the Block's
20767 * class.cs (ConstructorInitializer): Added `Parameters parameters'
20768 argument to the constructor.
20769 (ConstructorInitializer.Resolve): Create a temporary implicit
20770 block with the parameters.
20772 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
20773 references here if we aren't doing a type-only search.
20775 * statement.cs (Block): Added constructor which takes a
20776 `Parameters parameters' argument.
20777 (Block.Parameters): New public property.
20779 * support.cs (InternalParameters.Parameters): Renamed `parameters'
20780 to `Parameters' and made it public readonly.
20782 2002-08-06 Martin Baulig <martin@gnome.org>
20784 * ecore.cs (Expression.Warning): Made this public as well.
20786 * report.cs (Report.Debug): Print the contents of collections.
20788 2002-08-06 Martin Baulig <martin@gnome.org>
20790 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
20791 used to tell Resolve() which kinds of expressions it may return.
20792 (Expression.Resolve): Added overloaded version of this method which
20793 takes a `ResolveFlags flags' argument. This can be used to tell
20794 Resolve() which kinds of expressions it may return. Reports a
20796 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
20797 ResolveFlags.SimpleName.
20798 (Expression.Error118): Added overloaded version of this method which
20799 takes a `ResolveFlags flags' argument. It uses the flags to determine
20800 which kinds of expressions are allowed.
20802 * expression.cs (Argument.ResolveMethodGroup): New public method.
20803 Resolves an argument, but allows a MethodGroup to be returned.
20804 This is used when invoking a delegate.
20806 * TODO: Updated a bit.
20808 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20810 Fixed compilation with csc.
20812 * ecore.cs: Expression.Error made public. Is this correct? Should
20813 Warning be made public too?
20815 * expression.cs: use ea.Location instead of ea.loc.
20816 [FIXME: Filed as bug #28607: MCS must report these errors.]
20818 2002-08-06 Martin Baulig <martin@gnome.org>
20820 * ecore.cs (Expression.loc): Moved the location here instead of
20821 duplicating it in all derived classes.
20822 (Expression.Location): New public property.
20823 (Expression.Error, Expression.Warning): Made them non-static and
20824 removed the location argument.
20825 (Expression.Warning): Added overloaded version which takes an
20826 `int level' argument.
20827 (Expression.Error118): Make this non-static and removed the
20828 expression and location arguments.
20829 (TypeExpr): Added location argument to the constructor.
20831 * expression.cs (StaticCallExpr): Added location argument to
20833 (Indirection, PointerArithmetic): Likewise.
20834 (CheckedExpr, UnCheckedExpr): Likewise.
20835 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
20836 (StringPtr): Likewise.
20839 2002-08-05 Martin Baulig <martin@gnome.org>
20841 * expression.cs (BaseAccess.DoResolve): Actually report errors.
20843 * assign.cs (Assign.DoResolve): Check whether the source
20844 expression is a value or variable.
20846 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
20847 while resolving the corresponding blocks.
20849 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
20850 an error, don't silently return null.
20852 * statement.cs (Block.AddVariable): Do the error reporting here
20853 and distinguish between CS0128 and CS0136.
20854 (Block.DoResolve): Report all unused labels (warning CS0164).
20855 (LabeledStatement): Pass the location to the constructor.
20856 (LabeledStatement.HasBeenReferenced): New property.
20857 (LabeledStatement.Resolve): Set it to true here.
20859 * statement.cs (Return.Emit): Return success even after reporting
20860 a type mismatch error (CS0126 or CS0127), this is what csc does and
20861 it avoids confusing the users with any consecutive errors.
20863 2002-08-05 Martin Baulig <martin@gnome.org>
20865 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
20867 * const.cs (Const.LookupConstantValue): Catch circular definitions.
20869 * expression.cs (MemberAccess.DoResolve): Silently return if an
20870 error has already been reported.
20872 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
20873 error has already been reported.
20875 2002-08-05 Martin Baulig <martin@gnome.org>
20877 * statement.cs (UsageVector): Only initialize the `parameters'
20878 vector if we actually have any "out" parameters.
20880 2002-08-05 Martin Baulig <martin@gnome.org>
20882 * expression.cs (Binary.ResolveOperator): When combining delegates,
20883 they must have the same type.
20885 2002-08-05 Martin Baulig <martin@gnome.org>
20887 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
20888 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
20889 work with the ms runtime and we also don't need it: if we're a
20890 PropertyBuilder and not in the `indexer_arguments' hash, then we
20891 are a property and not an indexer.
20893 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
20894 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
20895 since the latter one doesn't work with the ms runtime.
20897 2002-08-03 Martin Baulig <martin@gnome.org>
20899 Fixed bugs #27998 and #22735.
20901 * class.cs (Method.IsOperator): New public field.
20902 (Method.CheckBase): Report CS0111 if there's already a method
20903 with the same parameters in the current class. Report CS0508 when
20904 attempting to change the return type of an inherited method.
20905 (MethodData.Emit): Report CS0179 if a method doesn't have a body
20906 and it's not marked abstract or extern.
20907 (PropertyBase): New abstract base class for Property and Indexer.
20908 (PropertyBase.CheckBase): Moved here from Property and made it work
20910 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
20911 the same so we can reuse it there.
20912 (Property, Indexer): Derive from PropertyBase.
20913 (MethodSignature.inheritable_property_signature_filter): New delegate
20914 to find properties and indexers.
20916 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
20917 argument and improved error reporting.
20919 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
20920 EmptyReadOnlyParameters and made it a property.
20922 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
20923 version of this method which takes a `PropertyInfo indexer'.
20924 (TypeManager.RegisterIndexer): New method.
20926 * class.cs: Added myself as author of this file :-)
20928 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20930 * class.cs: fixed compilation on windoze.
20932 2002-08-03 Martin Baulig <martin@gnome.org>
20934 * interface.cs (Interface.GetInterfaceBases): Check whether all
20935 base interfaces are at least as accessible than the current one.
20937 * class.cs (TypeContainer.GetClassBases): Check whether base types
20938 are at least as accessible than the current type.
20939 (TypeContainer.AsAccessible): Implemented and made non-static.
20940 (MemberBase.CheckParameters): Report errors if the accessibility
20943 * delegate.cs (Delegate.Delegate): The default visibility is
20944 internal for top-level types and private for nested types.
20945 (Delegate.Define): Report errors if the accessibility checks fail.
20947 * enum.cs (Enum.Enum): The default visibility is internal for
20948 top-level types and private for nested types.
20949 (Enum.DefineType): Compute the correct visibility.
20951 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
20952 function which takes a `bool is_toplevel' instead of a TypeContainer.
20954 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
20957 2002-08-02 Martin Baulig <martin@gnome.org>
20959 * expression.cs (LocalVariableReferenc): Added constructor which
20960 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
20961 (LocalVariableReference.IsReadOnly): New property.
20962 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
20963 variable is readonly, use our own readonly flag to do this; you can
20964 use the new constructor to get a writable reference to a read-only
20967 * cs-parser.jay (foreach_statement, using_statement): Get a writable
20968 reference to the local variable.
20970 2002-08-01 Miguel de Icaza <miguel@ximian.com>
20972 * rootcontext.cs (ResolveCore): Also include System.Exception
20974 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
20975 we reach an EmptyStatement.
20977 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
20980 * expression.cs (Binary.ResolveOperator): Check error result in
20983 use brtrue/brfalse directly and avoid compares to null.
20985 2002-08-02 Martin Baulig <martin@gnome.org>
20987 * class.cs (TypeContainer.Define): Define all nested interfaces here.
20988 Fixes bug #28407, added test-155.cs.
20990 2002-08-01 Martin Baulig <martin@gnome.org>
20992 * class.cs (Event.EmitDefaultMethod): Make this work with static
20993 events. Fixes #28311, added verify-3.cs.
20995 2002-08-01 Martin Baulig <martin@gnome.org>
20997 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
20998 `is_disposable' fields.
20999 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
21000 `hm.is_disposable' if we're using the collection pattern.
21001 (Foreach.EmitCollectionForeach): Use the correct type for the
21002 enumerator's local variable, only emit the try/finally block if
21003 necessary (fixes #27713).
21005 2002-08-01 Martin Baulig <martin@gnome.org>
21007 * ecore.cs (Expression.report118): Renamed to Error118 and made
21010 * statement.cs (Throw.Resolve): Check whether the expression is of
21011 the correct type (CS0118) and whether the type derives from
21012 System.Exception (CS0155).
21013 (Catch.Resolve): New method. Do the type lookup here and check
21014 whether it derives from System.Exception (CS0155).
21015 (Catch.CatchType, Catch.IsGeneral): New public properties.
21017 * typemanager.cs (TypeManager.exception_type): Added.
21019 2002-07-31 Miguel de Icaza <miguel@ximian.com>
21021 * driver.cs: Updated About function.
21023 2002-07-31 Martin Baulig <martin@gnome.org>
21025 Implemented Control Flow Analysis.
21027 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
21028 (EmitContext.CurrentBranching): Added.
21029 (EmitContext.StartFlowBranching): Added.
21030 (EmitContext.EndFlowBranching): Added.
21031 (EmitContext.KillFlowBranching): Added.
21032 (EmitContext.IsVariableAssigned): Added.
21033 (EmitContext.SetVariableAssigned): Added.
21034 (EmitContext.IsParameterAssigned): Added.
21035 (EmitContext.SetParameterAssigned): Added.
21036 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
21037 Added control flow analysis stuff here.
21039 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
21040 resolve the expression as lvalue.
21041 (LocalVariableReference.DoResolve): Check whether the variable has
21042 already been assigned.
21043 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
21044 the parameter as assigned here.
21045 (ParameterReference.DoResolve): Check whether the parameter has already
21047 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
21048 expression as lvalue.
21050 * statement.cs (FlowBranching): New class for the flow analysis code.
21051 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
21052 (LabeledStatement.IsDefined): New public property.
21053 (LabeledStatement.AddUsageVector): New public method to tell flow
21054 analyis that the label may be reached via a forward jump.
21055 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
21057 (VariableInfo.Number): New public field. This is used by flow analysis
21058 to number all locals of a block.
21059 (Block.CountVariables): New public property. This is the number of
21060 local variables in this block (including the locals from all parent
21062 (Block.EmitMeta): Number all the variables.
21064 * statement.cs: Added flow analysis support to all classes.
21066 2002-07-31 Martin Baulig <martin@gnome.org>
21068 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
21069 To get debugging messages, compile mcs with /define:MCS_DEBUG and
21070 then use this argument.
21072 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
21074 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
21075 use this to specify /define options.
21077 2002-07-29 Martin Baulig <martin@gnome.org>
21079 * statement.cs (Fixed): Moved all code that does variable lookups
21080 and resolvings from Emit to Resolve.
21082 * statement.cs (For): Moved all code that does variable lookups
21083 and resolvings from Emit to Resolve.
21085 * statement.cs (Using): Moved all code that does variable lookups
21086 and resolvings from Emit to Resolve.
21088 2002-07-29 Martin Baulig <martin@gnome.org>
21090 * attribute.cs (Attribute.Resolve): Explicitly catch a
21091 System.NullReferenceException when creating the
21092 CustromAttributeBuilder and report a different warning message.
21094 2002-07-29 Martin Baulig <martin@gnome.org>
21096 * support.cs (ParameterData.ParameterName): Added method to
21097 get the name of a parameter.
21099 * typemanager.cs (TypeManager.IsValueType): New public method.
21101 2002-07-29 Martin Baulig <martin@gnome.org>
21103 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
21104 is a flag which specifies that it's either ref or out.
21105 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
21106 the out parameter to `out Parameter.Modifier mod', also set the
21107 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
21109 * support.cs (InternalParameters.ParameterModifier): Distinguish
21110 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21111 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21113 * expression.cs (Argument.GetParameterModifier): Distinguish
21114 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21115 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21117 2002-07-29 Martin Baulig <martin@gnome.org>
21119 * expression.cs (ParameterReference.ParameterReference): Added
21120 `Location loc' argument to the constructor.
21122 * cs-parser.jay: Pass location to ParameterReference.
21124 2002-07-28 Miguel de Icaza <miguel@ximian.com>
21126 * statement.cs (Try): Initialize the location.
21128 * cs-parser.jay: pass location to Try.
21130 * expression.cs (Unary.Reduce): Change the prototype to return
21131 whether a constant fold could be performed or not. The result is
21132 returned in an out parameters. In the case of Indirection and
21133 AddressOf, we want to perform the full tests.
21135 2002-07-26 Miguel de Icaza <miguel@ximian.com>
21137 * statement.cs (Statement.Emit): Flag dead code.
21139 2002-07-27 Andrew Birkett <andy@nobugs.org>
21141 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
21143 2002-07-27 Martin Baulig <martin@gnome.org>
21145 * class.cs (MethodData.Define): Put back call to
21146 TypeManager.AddMethod(), accidentally commented this out.
21148 * report.cs (Debug): New public method to print debugging information,
21149 this is `[Conditional ("DEBUG")]'.
21151 2002-07-26 Martin Baulig <martin@gnome.org>
21153 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
21154 (switch_statement): Push the current_block to the switch_stack and
21155 pop it again when we're done with the switch.
21156 (switch_section): The new block is a child of the current_block.
21157 Fixes bug #24007, added test-152.cs.
21159 2002-07-27 Martin Baulig <martin@gnome.org>
21161 * expression.cs (Invocation.EmitArguments): When calling a varargs
21162 function with only its fixed arguments, we need to pass an empty
21165 2002-07-27 Martin Baulig <martin@gnome.org>
21167 Mono 0.13 has been released.
21169 2002-07-25 Miguel de Icaza <miguel@ximian.com>
21171 * driver.cs: Rename --resource to --linkres, because that is what
21172 we do currently, we dont support --resource yet.
21174 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
21176 2002-07-25 Martin Baulig <martin@gnome.org>
21178 * class.cs (MethodData): New public class. This is a `method builder'
21179 class for a method or one accessor of a Property/Indexer/Event.
21180 (MethodData.GetMethodFlags): Moved here from MemberBase.
21181 (MethodData.ApplyAttributes): Likewise.
21182 (MethodData.ApplyObsoleteAttribute): Likewise.
21183 (MethodData.ApplyConditionalAttribute): Likewise.
21184 (MethodData.ApplyDllImportAttribute): Likewise.
21185 (MethodData.CheckAbstractAndExternal): Likewise.
21186 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
21187 (MethodData.Emit): Formerly known as Method.Emit().
21188 (MemberBase): Moved everything which was specific to a single
21189 accessor/method to MethodData.
21190 (Method): Create a new MethodData and call Define() and Emit() on it.
21191 (Property, Indexer, Event): Create a new MethodData objects for each
21192 accessor and call Define() and Emit() on them.
21194 2002-07-25 Martin Baulig <martin@gnome.org>
21196 Made MethodCore derive from MemberBase to reuse the code from there.
21197 MemberBase now also checks for attributes.
21199 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
21200 (MemberBase.GetMethodFlags): Moved here from class Method and marked
21202 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
21203 `CallingConventions cc' and `Attributes opt_attrs' arguments.
21204 (MemberBase.ApplyAttributes): New virtual method; applies the
21205 attributes to a method or accessor.
21206 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
21207 (MemberBase.ApplyConditionalAttribute): Likewise.
21208 (MemberBase.ApplyDllImportAttribute): Likewise.
21209 (MemberBase.CheckAbstractAndExternal): Likewise.
21210 (MethodCore.ParameterTypes): This is now a property instead of a
21211 method, it's initialized from DoDefineParameters().
21212 (MethodCore.ParameterInfo): Removed the set accessor.
21213 (MethodCore.DoDefineParameters): New protected virtual method to
21214 initialize ParameterTypes and ParameterInfo.
21215 (Method.GetReturnType): We can now simply return the MemberType.
21216 (Method.GetMethodFlags): Override the MemberBase version and add
21217 the conditional flags.
21218 (Method.CheckBase): Moved some code from Define() here, call
21219 DoDefineParameters() here.
21220 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
21221 here to avoid some larger code duplication.
21222 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
21223 ensure that abstract and external accessors don't declare a body.
21225 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
21226 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
21227 lookup in the attribute's parent classes, so we need to abort as soon
21228 as we found the first match.
21229 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
21230 the attribute has no arguments.
21232 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
21235 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21237 * cs-parser.jay: reverted previous patch.
21239 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21241 * cs-parser.jay: fixed bug #22119.
21243 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21245 * attribute.cs: fixed compilation. The error was:
21246 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
21247 be assigned to before control leaves the current method."
21248 [FIXME: Filed as bug #28186: MCS must report this error.]
21250 2002-07-25 Martin Baulig <martin@gnome.org>
21252 * attribute.cs (Attribute.Conditional_GetConditionName): New static
21253 method to pull the condition name ouf of a Conditional attribute.
21254 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
21255 the obsolete message and error flag out of an Obsolete attribute.
21257 * class.cs (Method.GetMethodFlags): New public method to get the
21258 TypeManager.MethodFlags for this method.
21259 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
21261 (Method.Define): Get and apply the Obsolete and Conditional attributes;
21262 if we're overriding a virtual function, set the new private variable
21263 `parent_method'; call the new TypeManager.AddMethod().
21265 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
21266 the MethodBuilder and the Method in a PtrHashtable.
21267 (TypeManager.builder_to_method): Added for this purpose.
21268 (TypeManager.MethodFlags): Added IsObsoleteError.
21269 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
21270 Obsolete and Conditional arguments in MethodBuilders. If we discover
21271 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
21272 the message from the attribute.
21274 2002-07-24 Martin Baulig <martin@gnome.org>
21276 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
21277 preprocessor directives, ensure that the argument to #define/#undef is
21278 exactly one identifier and that it's actually an identifier.
21280 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
21283 2002-07-24 Martin Baulig <martin@gnome.org>
21285 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
21286 initialize it to TypeManager.object_type in the constructor.
21287 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
21288 of the `hm.get_current' method if we're using the collection pattern.
21289 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
21290 for the explicit conversion to make it work when we're using the collection
21291 pattern and the `Current' property has a different return type than `object'.
21294 2002-07-24 Martin Baulig <martin@gnome.org>
21296 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
21297 does not match, but don't report any errors. This method is called in
21298 order for all methods in a MethodGroupExpr until a matching method is
21299 found, so we don't want to bail out if the first method doesn't match.
21300 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
21301 matches, report the 123. Fixes #28070.
21303 2002-07-24 Martin Baulig <martin@gnome.org>
21305 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
21306 TypeManager.TypeToCoreType() to the top of the method so the
21307 following equality checks will work. Fixes #28107.
21309 2002-07-24 Martin Baulig <martin@gnome.org>
21311 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
21312 operand is of type uint, and the other operand is of type sbyte,
21313 short or int, the operands are converted to type long." -
21314 Actually do what this comment already told us. Fixes bug #28106,
21317 2002-07-24 Martin Baulig <martin@gnome.org>
21319 * class.cs (MethodBase): New abstract class. This is now a base
21320 class for Property, Indexer and Event to avoid some code duplication
21321 in their Define() and DefineMethods() methods.
21322 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
21323 generic methods for Define() and DefineMethods().
21324 (FieldBase): Derive from MemberBase, not MemberCore.
21325 (Property): Derive from MemberBase, not MemberCore.
21326 (Property.DefineMethod): Moved all the code from this method to the
21327 new MethodBase.DefineAccessor(), just call it with appropriate
21329 (Property.Define): Call the new Property.DoDefine(), this does some
21330 sanity checks and we don't need to duplicate the code everywhere.
21331 (Event): Derive from MemberBase, not MemberCore.
21332 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
21333 accessors, this will also make them work with interface events.
21334 (Indexer): Derive from MemberBase, not MemberCore.
21335 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
21336 (Indexer.Define): Use the new MethodBase functions.
21338 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
21339 argument to the constructor.
21340 (Interface.FindMembers): Added support for interface events.
21341 (Interface.PopluateEvent): Implemented.
21343 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
21345 2002-07-22 Miguel de Icaza <miguel@ximian.com>
21347 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
21348 but this is required to check for a method name being the same as
21349 the containing class.
21353 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21355 * interface.cs: initialize variable.
21357 2002-07-23 Martin Baulig <martin@gnome.org>
21359 Implemented the IndexerName attribute in interfaces.
21361 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
21362 name if this is an explicit interface implementation.
21363 (Indexer.InterfaceIndexerName): New public variable. If we're
21364 implementing an interface indexer, this is the IndexerName in that
21365 interface. Otherwise, it's the IndexerName.
21366 (Indexer.DefineMethod): If we're implementing interface indexer,
21367 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
21368 and Pending.ImplementIndexer methods.
21369 (Indexer.Define): Also define the PropertyBuilder if we're
21370 implementing an interface indexer and this is neither an explicit
21371 interface implementation nor do the IndexerName match the one in
21374 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
21375 If a method is defined here, then we always need to create a proxy
21376 for it. This is used when implementing interface indexers.
21377 (Pending.IsInterfaceIndexer): New public method.
21378 (Pending.ImplementIndexer): New public method.
21379 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
21380 This is used when implementing interface indexers to define a proxy
21382 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
21383 define a proxy if necessary.
21385 * interface.cs (Interface.IndexerName): New public variable.
21386 (Interface.PopulateIndexer): Set the IndexerName.
21387 (Interface.DefineIndexers): New private method. Populate all the
21388 indexers and make sure their IndexerNames match.
21390 * typemanager.cs (IndexerPropertyName): Added support for interface
21393 2002-07-22 Martin Baulig <martin@gnome.org>
21395 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
21396 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
21397 ret if HasReturnLabel.
21398 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
21401 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
21402 and set the ec.LoopBeginTryCatchLevel.
21403 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
21404 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
21405 the current ec.TryCatchLevel, the branch goes out of an exception
21406 block. In this case, we need to use Leave and not Br.
21408 2002-07-22 Martin Baulig <martin@gnome.org>
21410 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
21411 block unless the block does not always return or it is contained in
21412 another try { ... } catch { ... } block. Fixes bug #26506.
21413 Added verify-1.cs to the test suite.
21415 2002-07-22 Martin Baulig <martin@gnome.org>
21417 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
21418 then we do not always return. Fixes bug #24985.
21420 2002-07-22 Martin Baulig <martin@gnome.org>
21422 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
21423 lookup on a per-class level; ie. walk up the class hierarchy until we
21424 found at least one applicable method, then choose the best among them.
21425 Fixes bug #24463 and test-29.cs.
21427 2002-07-22 Martin Baulig <martin@gnome.org>
21429 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
21430 return types of the methods. The return type is not part of the
21431 signature and we must not check it to make the `new' modifier work.
21432 Fixes bug #27999, also added test-147.cs.
21433 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
21435 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
21436 on the method's return type.
21438 2002-07-21 Martin Baulig <martin@gnome.org>
21440 * assign.cs: Make this work if the rightmost source is a constant and
21441 we need to do an implicit type conversion. Also adding a few more tests
21442 to test-38.cs which should have caught this.
21444 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
21445 target in the makefile for this. The makefile.gnu is primarily intended
21446 for end-users who don't want to debug the compiler.
21448 2002-07-21 Martin Baulig <martin@gnome.org>
21450 * assign.cs: Improved the Assign class so it can now handle embedded
21451 assignments (X = Y = Z = something). As a side-effect this'll now also
21452 consume less local variables. test-38.cs now passes with MCS, added
21453 a few new test cases to that test.
21455 2002-07-20 Martin Baulig <martin@gnome.org>
21457 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
21458 instructions. Fixes bug #27977, also added test-146.cs.
21460 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21462 * cs-tokenizer.cs: fixed getHex ().
21464 2002-07-19 Martin Baulig <martin@gnome.org>
21466 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
21467 not Type.GetType() to lookup the array type. This is needed when
21468 we're constructing an array of a user-defined type.
21469 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
21470 single-dimensional arrays, but also for single-dimensial arrays of
21473 2002-07-19 Martin Baulig <martin@gnome.org>
21475 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
21476 this function is called, it's not allowed to share LocalBuilders
21477 among ILGenerators.
21479 2002-07-19 Martin Baulig <martin@gnome.org>
21481 * expression.cs (Argument.Resolve): Report an error 118 when trying
21482 to pass a type as argument.
21484 2002-07-18 Martin Baulig <martin@gnome.org>
21486 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
21487 Conv_R_Un for the signed `long' type.
21489 2002-07-15 Miguel de Icaza <miguel@ximian.com>
21491 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
21492 `expr' for the temporary result, as that will fail if we do
21493 multiple resolves on the same expression.
21495 2002-07-05 Miguel de Icaza <miguel@ximian.com>
21497 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
21498 ec.TypeContainer for looking up aliases.
21500 * class.cs (TypeContainer): Remove LookupAlias from here.
21502 * decl.cs (DeclSpace); Move here.
21504 2002-07-01 Miguel de Icaza <miguel@ximian.com>
21506 * class.cs (FindMembers): Only call filter if the constructor
21507 bulider is not null.
21509 Also handle delegates in `NestedTypes' now. Now we will perform
21510 type lookups using the standard resolution process. This also
21513 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
21514 This uses Expressions (the limited kind that can be parsed by the
21515 tree) instead of strings.
21517 * expression.cs (ComposedCast.ToString): Implement, used to flag
21518 errors since now we have to render expressions.
21520 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
21523 * ecore.cs (SimpleName.ToString): ditto.
21525 * cs-parser.jay: Instead of using strings to assemble types, use
21526 Expressions to assemble the type (using SimpleName, ComposedCast,
21527 MemberAccess). This should fix the type lookups in declarations,
21528 because we were using a different code path for this.
21530 * statement.cs (Block.Resolve): Continue processing statements
21531 even when there is an error.
21533 2002-07-17 Miguel de Icaza <miguel@ximian.com>
21535 * class.cs (Event.Define): Also remove the `remove' method from
21536 the list of pending items.
21538 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
21539 generate more compact code.
21541 2002-07-17 Martin Baulig <martin@gnome.org>
21543 * const.cs (Const.LookupConstantValue): Add support for constant
21544 `unchecked' and `checked' expressions.
21545 Also adding test case test-140.cs for this.
21547 2002-07-17 Martin Baulig <martin@gnome.org>
21549 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
21550 check whether mi.ReturnType implements the IEnumerator interface; the
21551 `==' and the IsAssignableFrom() will fail in this situation.
21553 2002-07-16 Ravi Pratap <ravi@ximian.com>
21555 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
21558 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21560 * expression.cs: fixed bug #27811.
21562 2002-07-14 Miguel de Icaza <miguel@ximian.com>
21564 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
21565 Molaro: when we are a ref, the value already contains a pointer
21566 value, do not take the address of it.
21568 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21569 * removed mb-parser.jay and mb-tokenizer.cs
21571 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21573 * expression.cs: check against the building corlib void type.
21575 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
21577 * ecore.cs: fix for valuetype static readonly fields: when
21578 initializing them, we need their address, not the address of a copy.
21580 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
21582 * typemanager.cs: register also enum_type in corlib.
21584 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21586 * class.cs: allow calling this (but not base) initializers in structs.
21588 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
21590 * ecore.cs: make sure we compare against the building base types
21593 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
21595 * typemanager.cs: fix TypeToCoreType() to handle void and object
21596 (corlib gets no more typerefs after this change).
21598 2002-07-12 Miguel de Icaza <miguel@ximian.com>
21600 * expression.cs (ArrayCreation.EmitArrayArguments): use
21601 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
21603 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
21604 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
21605 array indexes, the runtime actually forbids them.
21607 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
21608 for array arguments here.
21610 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
21611 instead of the default for ValueTypes.
21613 (New.DoEmit): Use IsValueType instead of
21614 IsSubclassOf (value_type)
21615 (New.DoResolve): ditto.
21616 (Invocation.EmitCall): ditto.
21618 * assign.cs (Assign): ditto.
21620 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
21621 Statements *are* currently doing part of their resolution during
21624 Expressions do always resolve during resolve, but statements are
21625 only required to propagate resolution to their children.
21627 2002-07-11 Miguel de Icaza <miguel@ximian.com>
21629 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
21631 (LoadAssembly): Do not add the dll if it is already specified
21633 (MainDriver): Add the System directory to the link path at the end,
21634 after all the other -L arguments.
21636 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
21637 wrong opcode for loading bytes and bools (ldelem.i1 instead of
21638 ldelem.u1) and using the opposite for sbytes.
21640 This fixes Digger, and we can finally run it.
21642 * driver.cs (UnixParseOption): Move the option parsing here.
21643 (CSCParseOption): Implement CSC-like parsing of options.
21645 We now support both modes of operation, the old Unix way, and the
21646 new CSC-like way. This should help those who wanted to make cross
21647 platform makefiles.
21649 The only thing broken is that /r:, /reference: and /lib: are not
21650 implemented, because I want to make those have the same semantics
21651 as the CSC compiler has, and kill once and for all the confussion
21652 around this. Will be doing this tomorrow.
21654 * statement.cs (Unsafe.Resolve): The state is checked during
21655 resolve, not emit, so we have to set the flags for IsUnsfe here.
21657 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21659 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
21660 not catch the Error_ObjectRefRequired in SimpleName (as it is
21661 possible to have a class/instance variable name that later gets
21662 deambiguated), we have to check this here.
21664 2002-07-10 Ravi Pratap <ravi@ximian.com>
21666 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
21667 make static and put into Expression.
21669 (Event.Define): Register the private field of the event with the
21670 TypeManager so that GetFieldFromEvent can get at it.
21672 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
21673 keep track of the private field associated with an event which
21676 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
21679 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
21681 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21683 * expression.cs (Binary.EmitBranchable): this routine emits the
21684 Binary expression in a branchable context. This basically means:
21685 we need to branch somewhere, not just get the value on the stack.
21687 This works together with Statement.EmitBoolExpression.
21689 * statement.cs (Statement.EmitBoolExpression): Use
21692 2002-07-09 Miguel de Icaza <miguel@ximian.com>
21694 * statement.cs (For): Reduce the number of jumps in loops.
21696 (For): Implement loop inversion for the For statement.
21698 (Break): We can be breaking out of a Try/Catch controlled section
21699 (foreach might have an implicit try/catch clause), so we need to
21700 use Leave instead of Br.
21702 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
21703 now). If the instace expression supports IMemoryLocation, we use
21704 the AddressOf method from the IMemoryLocation to extract the
21705 address instead of emitting the instance.
21707 This showed up with `This', as we were emitting the instance
21708 always (Emit) instead of the Address of This. Particularly
21709 interesting when This is a value type, as we dont want the Emit
21710 effect (which was to load the object).
21712 2002-07-08 Miguel de Icaza <miguel@ximian.com>
21714 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
21716 * statement.cs (Checked): Set the CheckedState during the resolve
21717 process too, as the ConvCast operations track the checked state on
21718 the resolve process, and not emit.
21720 * cs-parser.jay (namespace_member_declaration): Flag that we have
21721 found a declaration when we do. This is used to flag error 1529
21723 * driver.cs: Report ok when we display the help only.
21725 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
21727 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
21729 2002-07-04 Miguel de Icaza <miguel@ximian.com>
21731 * cs-tokenizer.cs (define): We also have to track locally the
21732 defines. AllDefines is just used for the Conditional Attribute,
21733 but we also need the local defines for the current source code.
21735 2002-07-03 Miguel de Icaza <miguel@ximian.com>
21737 * statement.cs (While, For, Do): These loops can exit through a
21738 Break statement, use this information to tell whether the
21739 statement is the last piece of code.
21741 (Break): Flag that we break.
21743 * codegen.cs (EmitContexts): New `Breaks' state variable.
21745 2002-07-03 Martin Baulig <martin@gnome.org>
21747 * class.cs (TypeContainer.MethodModifiersValid): Allow override
21748 modifiers in method declarations in structs. Otherwise, you won't
21749 be able to override things like Object.Equals().
21751 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21753 * class.cs (Method, Property, Indexer): Do not allow the public
21754 modifier to be used in explicit interface implementations.
21756 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
21757 override modifiers in method declarations in structs
21759 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
21761 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
21762 integer or real overflow, report an error
21764 2002-07-02 Martin Baulig <martin@gnome.org>
21766 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
21767 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
21768 to tell the runtime about our newly created System.Object and
21769 System.ValueType types.
21771 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21773 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
21774 struct instead of Ldarg/Starg.
21776 2002-07-02 Martin Baulig <martin@gnome.org>
21778 * expression.cs (Indirection.Indirection): Call
21779 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
21781 2002-07-02 Martin Baulig <martin@gnome.org>
21783 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
21784 ValueType, call TypeManager.TypeToCoreType() on it.
21785 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
21786 the OpCodes.Newarr argument.
21788 2002-07-02 Martin Baulig <martin@gnome.org>
21790 * expression.cs (Invocation.EmitCall): When compiling corlib,
21791 replace all calls to the system's System.Array type to calls to
21792 the newly created one.
21794 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
21795 System.Array methods.
21796 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
21797 from the system's System.Array type which must be replaced.
21799 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
21801 * typemanager.cs: load unverifiable_code_ctor so we can build
21802 corlib using the correct type. Avoid using GetTypeCode() with
21804 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
21805 TypeManager.object_type to allow building corlib.
21807 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
21809 * ecore.cs: handle System.Enum separately in LoadFromPtr().
21811 2002-07-01 Martin Baulig <martin@gnome.org>
21813 * class.cs: Make the last change actually work, we need to check
21814 whether `ifaces != null' to avoid a crash.
21816 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21818 * class.cs: when we build structs without fields that implement
21819 interfaces, we need to add the interfaces separately, since there is
21820 no API to both set the size and add the interfaces at type creation
21823 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21825 * expression.cs: the dimension arguments to the array constructors
21826 need to be converted if they are a long.
21828 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
21830 * class.cs: don't emit ldarg.0 if there is no parent constructor
21831 (fixes showstopper for corlib).
21833 2002-06-29 Martin Baulig <martin@gnome.org>
21835 MCS now compiles corlib on GNU/Linux :-)
21837 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
21838 ie. check for MethodImplOptions.InternalCall.
21840 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
21841 and TypeManager.attribute_type are null, so we must explicitly check
21842 whether parent is not null to find out whether it's an attribute type.
21843 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
21844 and SetBuilder, not only if the property is neither abstract nor external.
21845 This is necessary to set the MethodImplOptions on the accessor methods.
21846 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
21847 SetBuilder, see Property.Emit().
21849 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
21850 populate "System.Object", "System.ValueType" and "System.Attribute" since
21851 they've already been populated from BootCorlib_PopulateCoreTypes().
21853 2002-06-29 Martin Baulig <martin@gnome.org>
21855 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
21856 is the NullLiteral, we also need to make sure that target_type is not
21859 2002-06-29 Martin Baulig <martin@gnome.org>
21861 * rootcontext.cs (RootContext.ResolveCore): We must initialize
21862 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
21863 before calling BootstrapCorlib_ResolveDelegate ().
21865 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21867 * statement.cs: fixed build-breaker. All tests passed ok.
21869 2002-06-27 Martin Baulig <martin@gnome.org>
21871 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
21872 for System.Decimal when compiling corlib.
21874 2002-06-27 Martin Baulig <martin@gnome.org>
21876 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
21877 switch blocks which contain nothing but a default clause.
21879 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
21881 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
21883 2002-06-27 Martin Baulig <martin@gnome.org>
21885 * ecore.cs (PropertyExpr.PropertyExpr): Call
21886 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
21888 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
21889 is already a TypeBuilder.
21891 2002-06-27 Martin Baulig <martin@gnome.org>
21893 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
21894 `target_type == TypeManager.array_type', not IsAssignableFrom() in
21895 the "from an array-type to System.Array" case. This makes it work
21896 when compiling corlib.
21898 2002-06-27 Martin Baulig <martin@gnome.org>
21900 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
21901 non-static PropertyExpr, set its InstanceExpression. This makes
21902 the `ICollection.Count' property work in System/Array.cs.
21904 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
21906 * driver.cs: Made error handling more consistent. Errors now
21907 tracked by Report class, so many methods which used to return int
21908 now return void. Main() now prints success/failure and
21909 errors/warnings message.
21911 Renamed '--probe' compiler argument to '--expect-error'. Removed
21912 the magic number return values (123 and 124). Now, if the
21913 expected error occurs, the compiler exits with success (exit value
21914 0). If the compilation completes without seeing that particular
21915 error, the compiler exits with failure (exit value 1). The
21916 makefile in mcs/errors has been changed to handle the new behaviour.
21918 * report.cs: Made 'expected error' number a property and renamed
21919 it from 'Probe' to 'ExpectedError'.
21921 * genericparser.cs: Removed error handling support, since it is
21922 now all done by Report class.
21924 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
21925 class, so parse() no longer returns an int.
21927 * namespace.cs: Use Report.Error instead of GenericParser.error
21929 2002-06-22 Miguel de Icaza <miguel@ximian.com>
21931 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
21932 TypeContainer.AddOperator): At the front of the list put the
21933 explicit implementations, so they get resolved/defined first.
21935 2002-06-21 Miguel de Icaza <miguel@ximian.com>
21937 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
21938 interface type is implemented by this TypeContainer. Used during
21939 explicit interface implementation.
21941 (Property.Define, Indexer.Define, Method.Define): Validate that
21942 the given interface in the explicit implementation is one of the
21943 base classes for the containing type.
21945 Also if we are explicitly implementing an interface, but there is
21946 no match in the pending implementation table, report an error.
21948 (Property.Define): Only define the property if we are
21949 not explicitly implementing a property from an interface. Use the
21950 correct name also for those properties (the same CSC uses,
21951 although that is really not needed).
21953 (Property.Emit): Do not emit attributes for explicitly implemented
21954 properties, as there is no TypeBuilder.
21956 (Indexer.Emit): ditto.
21958 Hiding then means that we do not really *implement* a pending
21959 implementation, which makes code fail.
21961 2002-06-22 Martin Baulig <martin@gnome.org>
21963 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
21964 the return value of Object.GetType(). [FIXME: we need to do this whenever
21965 we get a type back from the reflection library].
21967 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
21969 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
21971 2002-06-20 Miguel de Icaza <miguel@ximian.com>
21973 * attribute.cs: Return null if we can not look up the type.
21975 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
21976 the interface types found.
21978 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
21979 interface types found.
21981 * typemanager.cs (GetInterfaces): Make this routine returns alll
21982 the interfaces and work around the lame differences between
21983 System.Type and System.Reflection.Emit.TypeBuilder in the results
21984 result for GetInterfaces.
21986 (ExpandInterfaces): Given an array of interface types, expand and
21987 eliminate repeated ocurrences of an interface. This expands in
21988 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
21991 2002-06-21 Martin Baulig <martin@gnome.org>
21993 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
21996 2002-06-21 Martin Baulig <martin@gnome.org>
21998 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
21999 and called with one of the core types, return the corresponding typebuilder for
22002 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
22005 2002-06-21 Martin Baulig <martin@gnome.org>
22007 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
22008 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
22009 (Expression.ConvertReferenceExplicit): Likewise.
22011 * expression.cs (ElementAccess.DoResolve): Likewise.
22012 (ElementAccess.DoResolveLValue): Likewise.
22014 2002-06-10 Martin Baulig <martin@gnome.org>
22016 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
22017 add the "value" parameter to the parameter list.
22019 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
22022 2002-06-19 Miguel de Icaza <miguel@ximian.com>
22024 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
22025 the argument to an int, uint, long or ulong, per the spec. Also
22026 catch negative constants in array creation.
22028 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
22030 * class.cs: do not allow the same interface to appear twice in
22031 the definition list.
22033 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
22035 * ecore.cs: don't use ldlen with System.Array.
22037 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
22039 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
22041 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
22043 * modifiers.cs: produce correct field attributes for protected
22044 internal. Easy fix so miguel can work on ther harder stuff:-)
22046 2002-06-18 Miguel de Icaza <miguel@ximian.com>
22048 * pending.cs: New file. Move the code from class.cs here.
22049 Support clearning the pending flag for all methods (when not doing
22050 explicit interface implementation).
22052 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
22054 * rootcontext.cs: added a couple more types needed to bootstrap.
22056 2002-06-17 Miguel de Icaza <miguel@ximian.com>
22058 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
22059 constructor in the type, instead of any constructor in the type
22060 hierarchy. Thanks to Paolo for finding this bug (it showed up as
22061 a bug in the Mono runtime when applying the params attribute).
22063 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
22064 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
22066 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
22068 * expression.cs (Unary.ResolveOperator): Use TypeManager
22069 to resolve the type.
22071 2002-06-13 Ravi Pratap <ravi@ximian.com>
22073 * cs-parser.jay (enum_member_declaration): Pass in the attributes
22076 * enum.cs (AddEnumMember): Add support to store the attributes associated
22077 with each member too.
22079 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
22080 field builders too - this takes care of the enum member case.
22082 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
22084 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
22085 address-of operator on both value types and pointers.
22087 2002-06-10 Martin Baulig <martin@gnome.org>
22089 * interface.cs (Interface.PopulateIndexer): Add the indexer's
22090 PropertyBuilder to the `property_builders' list.
22092 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
22093 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
22094 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
22095 find any indexers which are inherited from an interface.
22097 2002-06-09 Martin Baulig <martin@gnome.org>
22099 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
22100 the same type as the constant if necessary. There's also a test-130.cs
22103 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
22105 * typemanager.cs (TypeManager.ChangeType): Previously known as
22106 Enum.ChangeEnumType().
22108 2002-06-09 Martin Baulig <martin@gnome.org>
22110 * expression.cs (Cast.TryReduce): Added support for consts.
22112 2002-06-08 Ravi Pratap <ravi@ximian.com>
22114 * class.cs (Accessor): Hold attributes information so we can pass
22117 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
22118 Modify to pass in attributes attached to the methods.
22120 (add_accessor_declaration, remove_accessor_declaration): Ditto.
22122 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
22123 to handle the Accessor kind :-)
22125 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
22127 2002-06-08 Martin Baulig <martin@gnome.org>
22129 * expression.cs (Unary.TryReduceNegative): Added support for
22132 2002-06-08 Martin Baulig <martin@gnome.org>
22134 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
22135 name can't be found in the `defined_names' - the caller will do a
22136 MemberLookup in this case and thus find methods in System.Enum
22137 such as Enum.IsDefined().
22139 2002-06-08 Martin Baulig <martin@gnome.org>
22141 * enum.cs (Enum.ChangeEnumType): This is a custom version of
22142 Convert.ChangeType() which works with TypeBuilder created types.
22143 (Enum.LookupEnumValue, Enum.Define): Use it here.
22145 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
22146 `TypeBuilder.BaseType != null' check.
22147 (TypeContainer.FindMembers): Only lookup parent members if we
22148 actually have a parent.
22149 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
22150 (ConstructorInitializer.Resolve): Likewise.
22152 * interface.cs (Interface.FindMembers): Added
22153 `TypeBuilder.BaseType != null' check.
22155 * rootcontext.cs (RootContext.ResolveCore): Added
22156 "System.Runtime.CompilerServices.IndexerNameAttribute" to
22157 classes_second_stage.
22159 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
22160 debug_type and trace_type when compiling with --nostdlib.
22162 2002-06-07 Martin Baulig <martin@gnome.org>
22164 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
22165 (AddField): Set it to true when adding a non-static field.
22166 (DefineType): Use `have_nonstatic_fields' to find out whether we
22167 have non-static fields, not `Fields != null'.
22169 2002-06-02 Miguel de Icaza <miguel@ximian.com>
22171 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
22172 dereferencing a null on the static-field code path)
22174 2002-05-30 Martin Baulig <martin@gnome.org>
22176 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
22177 to take command line arguments. Use reflection to call the new
22178 custom `Initialize' function on the symbol writer and pass it the
22179 command line arguments.
22181 * driver.cs (--debug-args): New command line argument to pass command
22182 line arguments to the symbol writer.
22184 2002-05-28 Miguel de Icaza <miguel@ximian.com>
22186 * assign.cs (DoResolve): Forgot to do the implicit conversion to
22187 the target type for indexers and properties. Thanks to Joe for
22190 2002-05-27 Miguel de Icaza <miguel@ximian.com>
22192 * typemanager.cs (MethodFlags): returns the method flags
22193 (Obsolete/ShouldIgnore) that control warning emission and whether
22194 the invocation should be made, or ignored.
22196 * expression.cs (Invocation.Emit): Remove previous hack, we should
22197 not do this on matching a base type, we should do this based on an attribute
22199 Only emit calls to System.Diagnostics.Debug and
22200 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
22201 on the command line.
22203 * rootcontext.cs: Global settings for tracing and debugging.
22205 * cs-tokenizer.cs (define): New utility function to track
22206 defines. Set the global settings for TRACE and DEBUG if found.
22208 2002-05-25 Ravi Pratap <ravi@ximian.com>
22210 * interface.cs (Populate*): Pass in the TypeContainer as well as
22211 the DeclSpace as parameters so that we can create EmitContexts and
22212 then use that to apply attributes etc.
22214 (PopulateMethod, PopulateEvent, PopulateProperty)
22215 (PopulateIndexer): Apply attributes everywhere.
22217 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
22220 (ApplyAttributes): Update accordingly.
22222 We now apply interface attributes for all members too.
22224 2002-05-26 Miguel de Icaza <miguel@ximian.com>
22226 * class.cs (Indexer.Define); Correctly check if we are explicit
22227 implementation (instead of checking the Name for a ".", we
22228 directly look up if the InterfaceType was specified).
22230 Delay the creation of the PropertyBuilder.
22232 Only create the PropertyBuilder if we are not an explicit
22233 interface implementation. This means that explicit interface
22234 implementation members do not participate in regular function
22235 lookups, and hence fixes another major ambiguity problem in
22236 overload resolution (that was the visible effect).
22238 (DefineMethod): Return whether we are doing an interface
22241 * typemanager.cs: Temporary hack until we get attributes in
22242 interfaces (Ravi is working on that) and we get IndexerName
22243 support in interfaces.
22245 * interface.cs: Register the indexers as properties.
22247 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
22248 warning, I have verified that this is a bug in the .NET runtime
22249 (JavaScript suffers of the same problem).
22251 * typemanager.cs (MemberLookup): When looking up members for
22252 interfaces, the parent of an interface is the implicit
22253 System.Object (so we succeed in searches of Object methods in an
22254 interface method invocation. Example: IEnumerable x; x.ToString
22257 2002-05-25 Miguel de Icaza <miguel@ximian.com>
22259 * class.cs (Event): Events should also register if they do
22260 implement the methods that an interface requires.
22262 * typemanager.cs (MemberLookup); use the new GetInterfaces
22265 (GetInterfaces): The code used to lookup interfaces for a type is
22266 used in more than one place, factor it here.
22268 * driver.cs: Track the errors at the bottom of the file, we kept
22271 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
22272 instance if the method we are calling is static!
22274 2002-05-24 Miguel de Icaza <miguel@ximian.com>
22276 * attribute.cs (ApplyAttributes): Make this function filter out
22277 the IndexerName attribute (as that attribute in reality is never
22278 applied) and return the string constant for the IndexerName
22281 * class.cs (TypeContainer.Emit): Validate that all the indexers
22282 have the same IndexerName attribute, and if so, set the
22283 DefaultName attribute on the class.
22285 * typemanager.cs: The return value might contain other stuff (not
22286 only methods). For instance, consider a method with an "Item"
22287 property and an Item method.
22289 * class.cs: If there is a problem with the parameter types,
22292 2002-05-24 Ravi Pratap <ravi@ximian.com>
22294 * ecore.cs (ImplicitConversionExists): Wrapper function which also
22295 looks at user defined conversion after making a call to
22296 StandardConversionExists - we need this for overload resolution.
22298 * expression.cs : Update accordingly the various method calls.
22300 This fixes 2 bugs filed against implicit user defined conversions
22302 2002-05-22 Miguel de Icaza <miguel@ximian.com>
22304 * statement.cs: Track the result of the assignment.
22306 2002-05-21 Miguel de Icaza <miguel@ximian.com>
22308 * expression.cs (MemberAccess): Improved error reporting for
22309 inaccessible members.
22311 2002-05-22 Martin Baulig <martin@gnome.org>
22313 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
22314 itself with debugging support.
22316 2002-05-22 Martin Baulig <martin@gnome.org>
22318 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
22319 Removed, this isn't needed anymore.
22321 2002-05-20 Martin Baulig <martin@gnome.org>
22323 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
22324 be underlying type for an enum.
22326 2002-05-20 Miguel de Icaza <miguel@ximian.com>
22328 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
22329 that splits out the loading of just the core types.
22331 * rootcontext.cs (ResolveCore): Split the struct resolution in
22332 two, so we can load the enumeration underlying types before any
22335 * expression.cs (Is): Bandaid until we fix properly Switch (see
22336 bug #24985 for details).
22338 * typemanager.cs (ImplementsInterface): The hashtable will contain
22339 a null if there are no interfaces implemented.
22341 2002-05-18 Miguel de Icaza <miguel@ximian.com>
22343 * cs-parser.jay (indexer_declarator): It is fine to have array
22346 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22348 * typemanager.cs: (RegisterBuilder): New function used to register
22349 TypeBuilders that implement interfaces. Since
22350 TypeBuilder.GetInterfaces (as usual) does not work with lame
22352 (AddUserType): register interfaces.
22354 (ImplementsInterface): Use the builder_to_ifaces hash if we are
22355 dealing with TypeBuilder. Also, arrays are showing up as
22356 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
22357 methods can not be invoked on them!
22359 * ecore.cs (ExplicitReferenceConversionExists): Made public.
22360 (ImplicitReferenceConversionExists): Split out from
22361 StandardConversionExists.
22363 * expression.cs (As): We were only implementing one of the three
22364 cases for the as operator. We now implement them all.
22365 (Is): Implement the various other cases for Is as well.
22367 * typemanager.cs (CACHE): New define used to control if we want or
22368 not the FindMembers cache. Seems to have a negative impact on
22369 performance currently
22371 (MemberLookup): Nested types have full acess to
22372 enclosing type members
22374 Remove code that coped with instance/static returns for events, we
22375 now catch this in RealFindMembers.
22377 (RealFindMembers): only perform static lookup if the instance
22378 lookup did not return a type or an event.
22380 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22382 * assign.cs (CompoundAssign): We pass more semantic information
22383 now to Compound Assignments than we did before: now we have all
22384 the information at hand, and now we resolve the target *before* we
22385 do the expression expansion, which allows the "CacheValue" method
22386 to have the effect we intended (before, a [x] += 1 would generate
22387 two differen ArrayAccess expressions from the ElementAccess,
22388 during the resolution process).
22390 (CompoundAssign.DoResolve): Resolve target and original_source here.
22392 2002-05-16 Miguel de Icaza <miguel@ximian.com>
22394 * expression.cs (ArrayAccess): dropped debugging information.
22396 * typemanager.cs: Small bug fix: I was always returning i_members,
22397 instead of one of i_members or s_members (depending on which had
22400 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
22401 method is invoked before any code generation takes place, and it
22402 is a mechanism to inform that the expression will be invoked more
22403 than once, and that the method should use temporary values to
22404 avoid having side effects
22406 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
22408 * ecore.cs (Expression.CacheTemporaries): Provide empty default
22411 * expression.cs (Indirection, ArrayAccess): Add support for
22412 CacheTemporaries in these two bad boys.
22414 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
22415 ldobj or ldind_ref.
22416 (StoreFromPtr): Handle stobj as well.
22418 * expression.cs (UnaryMutator): Share more code.
22420 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
22421 down: I was not tracking the Filter function as well, which
22422 was affecting the results of the cache.
22424 2002-05-15 Miguel de Icaza <miguel@ximian.com>
22426 * attribute.cs: Remove the hack to handle the CharSet property on
22429 2002-05-14 Miguel de Icaza <miguel@ximian.com>
22431 * attribute.cs (DoResolve): More uglyness, we now only try to
22432 resolve the attribute partially, to extract the CharSet
22433 information (only if we are a StructLayout attribute). Otherwise
22435 (GetExtraTypeInfo): Add some code to conditionally kill in the
22436 future this. I am more and more convinced that the .NET
22437 framework has special code to handle the attribute setting on
22440 * expression.cs (IsParamsMethodApplicable): Revert my previous
22441 foreach change here, it was wrong.
22443 2002-05-13 Miguel de Icaza <miguel@ximian.com>
22445 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
22446 (pp_expr): do not abort on unknown input, just return.
22447 (eval): abort if there are pending chars.
22449 * attribute.cs (Attribute.Resolve): Positional parameters are
22450 optional. Deal with that case.
22452 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
22453 the Ansi/Unicode/Auto information for the type.
22455 (TypeContainer.DefineType): instantiate the EmitContext here, as
22456 we will be using it during the type definition (to resolve
22457 attributes) and during the emit phase.
22459 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
22460 to pull type information out of the attributes
22462 (Attribute.Resolve): track the constructor builder, and allow for
22463 multiple invocations (structs and classes will use this).
22465 * ecore.cs (MemberLookupFinal): new version with all the
22466 parameters customizable.
22468 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
22469 constructors. Return if the result value is null (as the error
22470 would have been flagged already by MemberLookupFinal)
22472 Do not allow instances of abstract classes or interfaces to be
22475 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
22476 We have to compare the assembly property here when dealing with
22477 FamANDAssem and Assembly access modifiers, because we might be
22478 creating an assembly from *modules* (that means that we are not
22479 getting TypeBuilders for types defined in other modules that are
22480 part of this assembly).
22482 (Method.Emit): If the method is marked abstract and has a body,
22485 (TypeContainer.DefineMembers): If both the defined member and the
22486 parent name match are methods, then do not emit any warnings: let
22487 the Method.Define routine take care of flagging warnings. But if
22488 there is a mismatch (method overrides something else, or method is
22489 overriwritten by something, then emit warning).
22491 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
22492 set to null, this means `do not check for the return type on the
22495 (Method.Define): set the return type for the method signature to
22496 null, so that we get methods with the same name and parameters and
22497 different return types. This is used to flag warning 114 (you are
22498 hiding a method, and you probably want to use the new/override
22501 * typemanager.cs (MemberLookup): Implemented proper access
22502 control, closing a long standing set of bug reports. The problem
22503 was that the Framework only has two bits: Public and NonPublic,
22504 and NonPublic includes private and protected methods, but we need
22505 to enforce the FamANDAssem, FamOrAssem and Family.
22507 2002-05-11 Miguel de Icaza <miguel@ximian.com>
22509 * statement.cs (GotoCase): Return true: Ammounts to giving up
22510 knowledge on whether we return or not, and letting the other case
22511 be responsible for it.
22513 2002-05-10 Miguel de Icaza <miguel@ximian.com>
22515 * driver.cs: Do not load directories for each file processed, only
22516 do it if there is a pattern.
22518 * ecore.cs: Report readonly assigns here as well, as we might have
22519 been resolved only by MemberAccess.
22521 (SimpleName.SimpleNameResolve): Also be useful for LValue
22522 resolution. We need this to propagate assign to local readonly variables
22524 * typemanager.cs: Use a ptrhashtable for the criteria, because we
22525 do not want to reuse potential criteria memory.
22527 * class.cs (MyEventBuilder): Set reflected_type;
22529 * ecore.cs (Constantify): Added support for constifying bools.
22531 (RootContext.LookupType): Added a cache for values looked up in
22532 the declaration space.
22534 * typemanager.cs (FindMembers): Now is a front-end to
22535 RealFindMembers, and provides a two-level hashtable-based cache to
22538 15% performance improvement: from 22.5 to 19.2 seconds.
22540 * expression.cs (IsParamsMethodApplicable): use foreach.
22541 (Invocation.DoResolve): ditto.
22542 (New.DoResolve): ditto.
22543 (ArrayCreation.DoResolve): ditto.
22545 * ecore.cs (FindMostEncompassingType): use foreach.
22547 * delegate.cs (NewDelegate.DoResolve): Use foreach
22549 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
22550 (RemoveMethods): use foreach.
22552 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
22553 nested foreach statements instead of for, and also break out of
22554 the inner loop once a match is found.
22556 (Invocation.OverloadResolve): Use foreach, simplify the code.
22558 2002-05-08 Miguel de Icaza <miguel@ximian.com>
22560 * cfold.cs (BinaryFold): During an enumeration evaluation context,
22561 we actually unwrap the expression to allow for extra information
22564 * expression.cs: Use Shr_Un on unsigned operations.
22566 2002-05-08 Ravi Pratap <ravi@ximian.com>
22568 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
22569 applicable operators was not being considered correctly. This closes
22570 the bug Miguel reported.
22572 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
22574 * attribute.cs: check that the type derives from System.Attribute
22575 and report the correct error in that case (moved the duplicate code to
22576 its own method, too).
22578 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
22580 * attribute.cs: lookup attribute type name as the spec says: first the
22581 bare attribute name and then name + "Attribute" (nant compiles with
22582 mcs after this fix).
22584 2002-05-07 Miguel de Icaza <miguel@ximian.com>
22586 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
22587 Because of the way we parse things, we should try to see if a
22588 UIntConstant can fit in an integer.
22590 2002-05-07 Ravi Pratap <ravi@ximian.com>
22592 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
22593 when we are in an explicit context.
22595 (ConvertReferenceExplicit): When converting from Iface type S to Class
22596 T make sure the rules are implemented as an OR.
22598 * parameter.cs (ParameterType): Make it a property for now although the
22599 purpose really isn't anything immediate.
22601 * expression.cs (Is*Applicable): Do better checking on the parameter type
22602 of a ref/out parameter. The ones from the system assemblies are already
22603 marked with the correct type so we don't need to do any correction.
22605 * ecore.cs (StandardConversionExists): Conversion from Interface types to
22606 the object type is standard too so include that.
22608 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22610 * ecore.cs (StandardConversionExists): Augment with missing code:
22611 deal with IntConstant, LongConstants and Enumerations.
22613 * assign.cs: Report the error, instead of failing silently
22615 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
22616 typecontainer that they are declared, because the
22617 typecontainer/namespace will have the list of using clauses that
22618 need to be applied.
22620 Assembly Attributes were escaping the normal registration
22623 (EmitCode): Apply attributes within an EmitContext that represents
22624 the container they were declared on.
22626 * cs-parser.jay: Track bases for structs. How did I get this wrong?
22628 2002-05-06 Ravi Pratap <ravi@ximian.com>
22630 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
22631 Revamp completely - make much cleaner as we now operate only
22634 (FindMostSpecificSource, FindMostSpecificTarget): New methods
22635 to implement the logic detailed in the spec more correctly.
22637 (UserDefinedConversion): Update accordingly.
22639 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22641 * statement.cs: Return flow analysis information up.
22643 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
22646 (token): Do not consume an extra character before calling
22649 2002-05-06 Piers Haken <piersh@friskit.com>
22651 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
22653 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22655 * class.cs (Constructor.Emit): Set the IsStatic flag in the
22656 EmitContext during the instance constructor initializer
22657 resolution, to stop access to instance variables.
22659 This is mandated by the spec, last paragraph of the `constructor
22660 initializers' section.
22662 2002-05-05 Miguel de Icaza <miguel@ximian.com>
22664 * cs-parser.jay, class.cs (Accessor): new class used to represent
22665 an accessor (get or set). In the past we used `null' to represent
22666 a missing accessor. But this is ambiguous because there was no
22667 way to tell in abstract indexers/properties if one of them was
22670 Now there is a way of addressing that.
22672 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
22673 instead of FindMembers.
22675 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
22676 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
22678 * attribute.cs: Treat indexers and properties as the same in terms
22679 of applying attributes
22681 * ecore.cs (FindMostEncompassedType): Use statically initialized
22682 EmptyExpressions()s like we do elsewhere to avoid creating useless
22683 objects (and we take this out of the tight loop).
22685 (GetConversionOperators): Move the code to extract the actual
22686 operators to a separate routine to clean things up.
22688 2002-05-04 Miguel de Icaza <miguel@ximian.com>
22690 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
22691 events are always registered FieldBuilders.
22693 * class.cs (FieldBase): New class shared by Fields
22695 * delegate.cs: If we are a toplevel delegate, use our full name.
22696 If we are a nested delegate, then only use our tail name.
22698 2002-05-02 Ravi Pratap <ravi@ximian.com>
22700 * expression.cs (IsApplicable): Ensure that we add the "&" to
22701 ref/out types before comparing it with the type of the argument.
22703 (IsParamsMethodApplicable): Ditto.
22705 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
22708 * delegate.cs : Handle the case when we have more than one applicable
22709 method. Flag an error only when we finish checking all.
22711 2002-05-02 Miguel de Icaza <miguel@ximian.com>
22713 * expression.cs: Add support for boolean static initializers.
22715 2002-05-01 Miguel de Icaza <miguel@ximian.com>
22717 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
22719 * parameter.cs (ComputeParameterTypes,
22720 ComputeAndDefineParameterTypes): Better error handling: now we
22721 clear the `types' cache if we fail during any of the type lookups.
22722 We also return the status code correctly to our caller
22724 * delegate.cs: If we fail to define a delegate, abort the extra
22727 * expression.cs (Binary.ResolveOperator): for
22728 operator==(object,object) and operator !=(object, object) we also
22729 have to verify that there is an implicit conversion from one to
22732 (ArrayAccess.DoResolve): Array Access can operate on
22735 2002-04-30 Miguel de Icaza <miguel@ximian.com>
22737 * assign.cs (CompoundAssign): A new class used as a "flag" that
22738 the assignment actually is happening as part of a compound
22739 assignment operator.
22741 During compound assignment, a few new rules exist to enable things
22748 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
22749 to the type of x) if y is implicitly convertible to the type of x,
22750 and the operator is a builtin operator and the return type of the
22751 operator is explicitly convertible to the type of x.
22753 * rootcontext.cs: Reset warning level to 2. 4 catches various
22754 "interesting" features in mcs, we must clean this up at some
22755 point, but currently am trying to kill other bugs ;-)
22757 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
22758 in container classes as well.
22760 * expression.cs (Binary.ResolveOperator): Handle string case
22761 before anything else (as operator overloading does emit an error
22762 before doing anything else).
22764 This code could go away when we move to a table driven model, but
22765 i could not come up with a good plan last night.
22767 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
22769 * typemanager.cs (CSharpName): reimplementation using regex.
22770 * class.cs: added null check for fields in Emit
22771 * rootcontext.cs: set warninglevel to 4
22773 2002-04-29 Miguel de Icaza <miguel@ximian.com>
22775 * typemanager.cs (CSharpName): reimplemented with Lupus
22778 2002-04-28 Miguel de Icaza <miguel@ximian.com>
22780 * statement.cs (If): correclty implement Resolve, because we were
22781 not catching sem errors in there. The same process is needed
22783 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
22786 (Statement.Warning_DeadCodeFound): Factorize code.
22787 (While): Report dead code here too.
22789 (Statement): Added Resolve virtual method to allow
22790 for resolution split from the emit code.
22792 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22794 * statement.cs (EmitBoolExpression): No longer try to resolve the
22796 (MakeBoolean): New utility function that resolve, implicitly
22797 converts to boolean and tags the expression.
22800 (If, Do): Implement dead code elimination.
22801 (While): Implement loop inversion
22803 (Do, While, For, If): Resolve the expression prior to calling our
22806 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
22809 - added method Report28 (warning: program has more than one entry point)
22810 - added method IsEntryPoint, implements paragraph 10.1 of the spec
22811 - modified method Method.Define, the part at the end of the method
22813 * rootcontext.cs: added static public Location EntryPointLocation;
22815 * ../errors/cs0028.cs : Add test case for the above warning.
22818 - modified method CSharpName to allow arrays of primitive type to
22819 be printed nicely (e.g. instead of System.Int32[][] it now prints
22821 - added method CSharpSignature: returns the signature of a method
22822 in string format to be used in reporting errors, warnings, etc.
22824 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
22827 2002-04-26 Ravi Pratap <ravi@ximian.com>
22829 * delegate.cs (Define): Fix extremely silly bug where I was
22830 setting the type of the 'object' parameter of the BeginInvoke
22831 method to System.IAsyncResult instead of System.Object ;-)
22833 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22835 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
22838 (Constructor.Emit): return if we fail to initialize the
22839 constructor. Another door closed!
22841 * expression.cs (New.DoResolve): Improve error message (from -6 to
22842 1501). Use DeclaredOnly lookup to find the exact constructor.
22844 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
22845 loop. This is useful.
22847 * cs-parser.jay: Adjust the default parameters so that destructors
22848 have the proper signature.
22850 2002-04-26 Martin Baulig <martin@gnome.org>
22852 * driver.cs (LoadAssembly): If `assembly' contains any characters
22853 which are only valid in path names and not in assembly names
22854 (currently slash, backslash and point), use Assembly.LoadFrom ()
22855 instead of Assembly.Load () on the `assembly' (before iteration
22856 over the link_paths).
22858 2002-04-26 Martin Baulig <martin@gnome.org>
22860 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
22862 2002-04-25 Miguel de Icaza <miguel@ximian.com>
22864 * class.cs (Property): use the new typemanager.MemberLookup
22866 (TypeContainer.MemberLookup): Implement using the
22867 TypeManager.MemberLookup now.
22869 * typemanager.cs: Make MemberLookup a function of the TypeManager,
22870 and return MemberInfos, so that these can be used without an
22871 EmitContext (what we had before).
22873 2002-04-24 Miguel de Icaza <miguel@ximian.com>
22875 * expression.cs: Fix the case where the argument to params if the
22876 type of the params. I omitted handling this before. Fixed
22878 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22880 * driver.cs: Call BootCorlib_PopulateCoreType
22882 * class.cs (Property.CheckBase): Check for properties only, not
22885 * interface.cs: Temporary hack: try/catch around the
22886 CustomAttributeBuilder, because I am getting an exception that I
22889 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
22890 types whose definitions are required to be there (attributes are
22891 defined before standard types).
22893 Compute definitions as we boot the various types, as they are used
22894 immediately (value_type class will need object_type, but if we do
22895 not initialize object_type, we will pass a null, which will let
22896 the runtime pick the System.Object from the existing corlib, which
22897 is not what we want).
22899 2002-04-22 Patrik Torstensson <totte@labs2.com>
22901 * cs-tokenizer.cs: fixed a number of trim() issues.
22903 2002-04-22 Ravi Pratap <ravi@ximian.com>
22905 * expression.cs (Argument.Type): Ensure that we return the correct
22906 type when we have out or ref parameters [in which case we
22909 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22911 * class.cs (Property, Indexer): Allow extern modifier in there.
22913 * typemanager.cs (InitBaseTypes): Initializes object_type and
22914 value_type, since those will be used early on during the bootstrap
22915 process to compile corlib.
22917 (InitCoreTypes): Move code from here to InitBaseTypes.
22919 2002-04-21 Miguel de Icaza <miguel@ximian.com>
22921 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
22922 single-dimension arrays as using the ldlen opcode.
22924 Daniel Lewis discovered this optimization.
22926 * typemanager.cs: Add signature for System.Array::get_Length
22928 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22930 * statement.cs: report the error when the foreach does not apply to an
22931 array nor a collection.
22933 2002-04-19 Miguel de Icaza <miguel@ximian.com>
22935 * expression.cs: Add implicit conversions to the operator ~.
22937 * constant.cs (DecimalConstant.Emit): Emit decimal value.
22939 * typemanager.cs: Locate the decimal constructor.
22941 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22943 * attribute.cs: use the new property of TypeOf.
22944 * expression.cs: added 'get' property around typearg.
22946 These changes fix a build breaker reported by NickD. Is this the
22947 correct way to fix? If not, please, revert my changes and make it
22950 2002-04-17 Miguel de Icaza <miguel@ximian.com>
22952 * attribute.cs: Add support for typeof in attribute invocations.
22953 I am not sure that this is right though.
22955 2002-04-14 Duncan Mak <duncan@ximian.com>
22957 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
22958 Binary.Operator.Division case.
22960 2002-04-13 Ravi Pratap <ravi@ximian.com>
22962 * class.cs (DefineType): Ensure that we do a proper check on
22963 attribute types and also register it with the TypeManager.
22965 (TypeContainer.Targets): The default for attribute types is
22966 AttributeTargets.All.
22968 * attribute.cs (ApplyAttributes): Registering the attribute type
22969 is done elsewhere, not when we discover we have a Usage attribute.
22971 2002-04-12 Ravi Pratap <ravi@ximian.com>
22973 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
22974 and get rid of is_delegate parameter.
22976 * everywhere : update.
22978 2002-04-12 Ravi Pratap <ravi@ximian.com>
22980 * cs-parser.jay (compilation_unit): Revamp completely to use
22981 some new ideas that I got from Rhys' grammar to solve the problems
22982 with assembly level attributes.
22984 (outer_declaration): New grammar production.
22986 (attribute_sections): Add.
22988 (opt_attributes): Base on attribute_sections
22990 (namespace_declaration): Allow opt_attributes to tackle the case
22991 when we have assembly level attributes - we are clever in this
22994 * attribute.cs (ApplyAttributes): Do not worry about assembly
22995 attributes in the non-global context.
22997 * rootcontext.cs (AddGlobalAttributes): Go back to using this
22998 instead of SetGlobalAttributes.
23000 * class.cs, rootcontext.cs : Ensure we define and generate
23001 attribute types before anything else.
23003 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
23004 and flag the new error -20 for the case when the attribute type
23005 does not have valid targets specified. csc does not catch this.
23007 * ../errors/errors.txt : update for error # -20
23009 2002-04-11 Ravi Pratap <ravi@ximian.com>
23011 * support.cs (InternalParameters.ParameterModifier): Do some null
23012 checking and return sane values.
23014 * class.cs (Method.Define): If we are a PInvoke method, ensure
23015 that we are static and extern. Report error # 601
23017 * ../errors/cs0601.cs : Add test case for the above error.
23019 2002-04-07 Ravi Pratap <ravi@ximian.com>
23021 * rootcontext.cs (attribute_types): We need to keep type of
23022 all attribute types separately and emit code for them first.
23024 (RegisterAttribute) : Implement.
23026 * class.cs (DefineType): Check if the current Type is a custom
23027 attribute type and register it accordingly.
23029 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
23030 adding the first attribute twice and rename to
23032 (SetGlobalAttributes): this.
23034 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
23037 * attribute.cs (ApplyAttributes): Take an additional argument telling us
23038 if we are processing global arguments. Hmm, I am unsure of this.
23040 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23042 * expression.cs: added static array of strings to avoid calling
23043 Enum.ToString () for Operator in Binary. Significant recover of
23046 2002-04-10 Miguel de Icaza <miguel@ximian.com>
23048 * class.cs (FindMembers): Allow the Builders of the various
23049 members to be null. If they are skip them. This only happens
23050 during the PInvoke declaration.
23052 2002-04-09 Miguel de Icaza <miguel@ximian.com>
23054 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
23055 failure, so we do not keep going afterwards.
23057 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
23058 wanted to pass `false' as the `is_delegate' argument. If this is
23059 the case, why not use delegate_type == null to mean `is_delegate =
23060 false' and anything else as is_delegate = true.
23062 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
23064 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
23065 code for the section, not the beginning of the tests.
23067 2002-04-08 Miguel de Icaza <miguel@ximian.com>
23069 * cfold.cs: Handle operator + (Enum x, Underlying x)
23071 * expression.cs (Binary): same. Warn about errors where we have
23072 Enum/Enum in operator + as well.
23074 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
23077 - added support for switch(bool)
23078 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
23079 - add TableSwitchEmit() to handle table-based switch statements
23081 2002-04-05 Ravi Pratap <ravi@ximian.com>
23083 * expression.cs (Invocation.OverloadResolve): Factor out code which
23084 does parameter compatibility checking with arguments so that we can
23085 re-use the code even from Delegate.VerifyApplicability
23087 (VerifyArgumentsCompat): Move above code here.
23089 * delegate.cs (VerifyApplicability): Get rid of duplicate code
23090 and instead make a call to the above method.
23092 2002-03-31 Ravi Pratap <ravi@ximian.com>
23094 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
23095 We use it to keep track of classes which are attribute types.
23097 2002-04-02 Miguel de Icaza <miguel@ximian.com>
23099 * delegate.cs (Delegate.Define): Correctly define the types in the
23100 presence of fixed and array parameters.
23102 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
23105 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
23106 include NonPublic after the first iteration.
23108 * class.cs (Indexer.CheckBase): Only check if both parents are
23111 * cs-parser.jay (accessor_body): If empty, set to null.
23113 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
23114 same code path here to resolve constants names that we did have in
23115 MemberAccess.DoResolve. There is too much code duplicated here.
23117 2002-04-01 Miguel de Icaza <miguel@ximian.com>
23119 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
23121 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
23124 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
23125 tokens, numbers and strings.
23127 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
23130 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
23131 asyncronous parameters and the regular parameters.
23133 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
23134 specify the target directory.
23136 * expression.cs: (This.DoResolve): Simplify
23137 (As.Emit): Optimize, do not generate IsInst if the expression is
23138 always of the given type.
23140 (Is.DoResolve): Bug fix, we were reporting both always/never for
23143 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
23144 creating too many unnecessary arrays.
23146 2002-03-31 Miguel de Icaza <miguel@ximian.com>
23148 * class.cs (EmitFieldInitializer): Use Assign expression to assign
23149 fields instead of rolling our own initializer. Takes care of all
23150 implicit conversions, and drops unnecessary static checks/argument.
23152 2002-03-31 Dick Porter <dick@ximian.com>
23154 * driver.cs: use the GetDirectories() return values properly, and
23155 use "/" as path separator.
23157 2002-03-30 Miguel de Icaza <miguel@ximian.com>
23159 * expression.cs (Unary): Optimize - - expr into expr.
23160 (Binary): Optimize a + (-b) into a -b.
23162 * codegen.cs (CodeGen): Made all methods static.
23164 2002-03-29 Miguel de Icaza <miguel@ximian.com>
23168 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
23169 TypeBuilder property.
23171 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
23174 * tree.cs: Removed the various RecordXXXX, and replaced with a
23175 single RecordDecl. Removed all the accessor methods, and just
23176 left a single access point Type
23178 * enum.cs: Rename DefineEnum to DefineType.
23180 * decl.cs: New abstract method `DefineType' used to unify the
23181 Defines for Enumerations, Interfaces, TypeContainers and
23184 (FindType): Moved LookupInterfaceOrClass here. Moved the
23185 LookupBaseClasses method that used to live in class.cs and
23186 interface.cs here, and renamed to FindType.
23188 * delegate.cs: Implement DefineType. Take advantage of the
23189 refactored pattern for locating the parent builder without taking
23190 the parent_builder argument (which we know does not work if we are
23191 nested, and triggering a toplevel definition).
23193 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23195 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
23196 accessibility of a member has changed during override and report
23199 * class.cs (Method.Define, Property.Define): Only complain on
23200 overrides if the method is private, any other accessibility is
23201 fine (and since we just checked the permission is the same, we are
23204 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
23205 and elif are processed always. The other pre-processing
23206 directives are only processed if we are "taking" the path
23208 2002-03-29 Martin Baulig <martin@gnome.org>
23210 * class.cs (Method.Emit): Only emit symbolic debugging info if the
23211 current location is not Null.
23213 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
23214 a separate method so we can profile it.
23216 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
23217 `span.Seconds' are just seconds, but no minutes or hours.
23218 (MainDriver): Profile the CodeGen.SaveSymbols calls.
23220 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23222 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
23223 Remove the gratuitous set of Final:
23225 // If an interface implementation, then we can set Final.
23226 if (((flags & MethodAttributes.Abstract) == 0) &&
23227 implementing.DeclaringType.IsInterface)
23228 flags |= MethodAttributes.Final;
23230 I do not know what I was smoking when I used that.
23233 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
23234 step into fixing the name resolution issues for delegates and
23235 unifying the toplevel name resolution.
23237 2002-03-28 Martin Baulig <martin@gnome.org>
23239 * class.cs (Method.Emit): If we have a symbol writer, call its
23240 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
23241 tell it about the current method.
23243 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
23244 writer that we're going to emit the first byte of IL code for a new
23245 statement (a new source line).
23246 (EmitContext.EmitTopBlock): If we have a symbol writer, call
23247 EmitContext.Mark() before emitting any code.
23249 * location.cs (SymbolDocument): Return null when we're Null.
23251 * statement.cs (Statement): Moved the `Location loc' variable here.
23252 (Statement.EmitBoolExpression): If we have a symbol writer, call
23253 ec.Mark() before emitting any code to tell it that we're at the
23254 beginning of a new statement.
23255 (StatementExpression): Added `Location' argument to the constructor.
23256 (Block): Added public readonly variable `StartLocation' and public
23257 variable `EndLocation'. The latter is to be set using SetEndLocation().
23258 (Block): Added constructor which takes a start and end location.
23259 (Block.SetEndLocation): New method. This sets the end location.
23260 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
23261 local variables we create.
23262 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
23263 each statement and do also mark the begin and end of the block.
23265 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
23266 tell it the current lexer.Location, use Location.Null for the end of the
23268 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
23269 current block, set its end location using SetEndLocation().
23270 (statement_expression): StatementExpression constructor now takes the
23271 lexer.Location as additional argument.
23272 (for_statement, declare_local_variables): Likewise.
23273 (declare_local_variables): When creating a new implicit block, use the
23274 new Block constructor and pass it the lexer.Location.
23276 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23278 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
23279 members also on the parent interfaces recursively.
23281 2002-03-27 Miguel de Icaza <miguel@ximian.com>
23283 * report.cs: Use new formats, since Gonzalo finished the missing
23286 * expression.cs (Binary.ResolveOperator): added missing operator|
23287 operator& and operator^ for bool/bool.
23289 * cs-parser.jay: CheckDef now takes a Location argument that is
23290 used to report errors more precisly (instead of reporting the end
23291 of a definition, we try to track something which is a lot closer
23292 to the source of the problem).
23294 * cs-tokenizer.cs: Track global token use, so we can properly flag
23295 the use of #define/#undef after the first token has been seen.
23297 Also, rename the reportXXXX to Error_DescriptiveName
23299 * decl.cs (DeclSpace.IsTopLevel): Move property here from
23300 TypeContainer, so that Enum and Interface can use this too.
23302 * class.cs (TypeContainer.LookupInterfaceOrClass,
23303 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
23304 `builder' argument. Typically this was used to pass the parent
23305 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
23308 The problem is that a nested class could trigger the definition of
23309 a toplevel class, and the builder would be obviously wrong in that
23312 So we drop this argument, and we compute dynamically the
23313 TypeBuilder/ModuleBuilder (the correct information was available
23314 to us anyways from DeclSpace.Parent)
23316 * interface.cs (Interface.DefineInterface): Drop builder
23317 parameter cleanup like class.cs
23319 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
23322 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
23325 (Try.Emit): Propagate the returns value from the statement.
23327 (Return.Emit): Even if we are leavning
23329 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
23331 * modifiers.cs: Fix the computation of MethodAttributes flags.
23333 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
23335 * driver.cs: allow compilation of files that start with '/'.
23336 Add a default case when checking the argument of --target.
23338 2002-03-25 Miguel de Icaza <miguel@ximian.com>
23340 * interface.cs: Implement the same search algorithm for types in
23341 the interface code.
23343 * delegate.cs: Do not allow multiple definition.
23345 * Recovered ChangeLog that got accidentally amputated
23347 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
23349 * rootcontext.cs: Load manually enum to allow core classes to
23350 contain enumerations.
23352 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
23353 Update to new static methods in TypeManager.
23355 * typemanager.cs (GetMethod, GetConstructor): Use our
23356 implementation of FindMembers to find the members, since during
23357 corlib compilation, the types are TypeBuilders and GetMethod and
23358 GetConstructor do not work.
23360 Make all methods in TypeManager static.
23362 (InitCodeHelpers): Split the functionality from
23363 the InitCodeTypes function.
23365 * driver.cs: Call InitCodeHelpers after we have populated the
23368 * cs-parser.jay (delegate_declaration): we did not used to compute
23369 the delegate name correctly for void delegates.
23371 2002-03-24 Miguel de Icaza <miguel@ximian.com>
23373 * rootcontext.cs (RootContext): Init the interface_resolve_order
23374 and type_container_resolve_order always.
23376 (ResolveCore, BootstrapCorlib_ResolveClass,
23377 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
23378 compiler when compiling with --nostdlib
23380 * class.cs (TypeContainer.DefineType): Check that our parent is
23381 not null. This test is most important when we are bootstraping
23384 * codegen.cs: Split out the symbol writing code.
23386 2002-03-25 Martin Baulig <martin@gnome.org>
23388 * driver.cs (-g): Made -g an alias for --debug.
23390 2002-03-24 Martin Baulig <martin@gnome.org>
23392 * codegen.cs (SymbolWriter): New public variable. Returns the
23393 current symbol writer.
23394 (CodeGen): Added `bool want_debugging_support' argument to the
23395 constructor. If true, tell the ModuleBuild that we want debugging
23396 support and ask it for the ISymbolWriter.
23397 (Save): If we have a symbol writer, call it's Close() method after
23398 saving the assembly.
23400 * driver.c (--debug): New command line argument to create a
23401 debugger information file.
23403 * location.cs (SymbolDocument): New public property. Returns an
23404 ISymbolDocumentWriter object for the current source file or null
23405 if we don't have a symbol writer.
23407 2002-03-21 Miguel de Icaza <miguel@ximian.com>
23409 * driver.cs (LoadAssembly): Correctly return when all the paths
23410 have been tried and not before.
23412 * statement.cs (Switch.Emit): return the actual coverage for this
23413 statement (returns/not-returns)
23415 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
23416 switch of the statement if we are the last switch section. That
23417 kills two problems: try/catch problems (we used to emit an empty
23418 nop at the end) and switch statements where all branches would
23421 2002-03-19 Miguel de Icaza <miguel@ximian.com>
23423 * driver.cs: Add default assemblies (the equivalent to the
23424 Microsoft CSC.RSP file)
23426 * cs-tokenizer.cs: When updating `cols and setting it to zero,
23427 also update tokens_seen and set it to false.
23429 * driver.cs: Implement --recurse for Mike.
23431 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
23432 correctly splitting out the paths.
23434 2002-03-18 Miguel de Icaza <miguel@ximian.com>
23436 * interface.cs (Interface.PopulateProperty): Instead of using
23437 `parent' as the declaration space for the set parameters, use
23440 * support.cs (InternalParameters): InternalParameters constructor
23441 takes a DeclSpace instead of a TypeContainer.
23443 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
23444 types are being initialized, load the address of it before calling
23447 (New): Provide a mechanism to disable the generation of local
23448 value type temporaries when the caller will be providing us with
23449 an address to store it.
23451 (ArrayCreation.EmitDynamicInitializers): Use it.
23453 2002-03-17 Miguel de Icaza <miguel@ximian.com>
23455 * expression.cs (Invocation.EmitArguments): Only probe for array
23456 property if there is more than one argument. Sorry about that.
23458 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
23459 empty param arrays.
23461 * class.cs (Method.LabelParameters): Fix incorrect code path that
23462 prevented the `ParamArrayAttribute' from being applied to the
23465 2002-03-16 Miguel de Icaza <miguel@ximian.com>
23467 * support.cs (ReflectionParameters): Correctly compute whether the
23468 last argument is a params array. Fixes the problem with
23471 * typemanager.cs: Make the assemblies array always be non-null
23472 (empty, but non-null)
23474 * tree.cs (RecordDecl): New function that abstracts the recording
23475 of names. This reports error 101, and provides a pointer to the
23476 previous declaration. Fixes a crash in the compiler.
23478 * cs-parser.jay (constructor_declaration): Update to new grammar,
23479 and provide a constructor_body that can be empty.
23481 2002-03-15 Miguel de Icaza <miguel@ximian.com>
23483 * driver.cs: Add support for --resources.
23485 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
23486 Make all types for the various array helper methods be integer.
23488 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
23489 CheckState to ConvCast.
23491 (ConvCast): Now it takes a `checked' state argument, to avoid
23492 depending on the emit context for the conversion, and just using
23493 the resolve time setting.
23495 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
23496 instead of Invocation.EmitArguments. We do not emit the original
23497 arguments, instead we emit those which have been converted to
23498 unsigned int expressions.
23500 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
23502 * codegen.cs: ditto.
23504 * expression.cs (LocalVariableReference): Drop the use of the
23505 Store function that depended on the variable index.
23507 * statement.cs (VariableInfo): Drop the `Idx' property from this
23508 class, as this is not taking into account the indexes for
23509 temporaries tat we generate during the execution, getting the
23512 * class.cs: First emit class initializers, then call the parent
23515 * expression.cs (Binary): Fix opcode emision.
23516 (UnaryMutator.EmitCode): Support checked code generation
23518 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
23519 matches for events for both the Static and Instance scans,
23520 pointing to the same element. Fix that.
23522 2002-03-14 Miguel de Icaza <miguel@ximian.com>
23524 * rootcontext.cs (ResolveTree): Always set the
23525 interface_resolve_order, because nested interfaces will be calling
23528 * class.cs (GetInterfaceOrClass): Track the same resolution
23529 process used by TypeManager.LookupType. This fixes the nested
23530 type lookups in class declarations (separate path from
23533 (TypeContainer.DefineType): Also define nested interfaces.
23534 (TypeContainer.RegisterOrder): New public function used to
23535 register the order in which child interfaces need to be closed.
23537 Nested interfaces need to be closed after their parents have been
23540 * interface.cs (InterfaceAttr): Put all the logic for computing
23541 the interface attribute here.
23543 (DefineInterface): Register our interface order with the
23544 RootContext or with the TypeContainer depending on the case.
23546 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23548 * cs-parser.jay: rework foreach statement to work with the new
23549 changes to the policy on SimpleNames.
23551 * report.cs: support Stacktrace on warnings as well.
23553 * makefile: drop --unsafe and /unsafe from the compile.
23555 2002-03-13 Ravi Pratap <ravi@ximian.com>
23557 * ecore.cs (StandardConversionExists): Modify to take an Expression
23558 as the first parameter. Ensure we do null -> reference type conversion
23561 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
23562 temporary Expression objects.
23564 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
23566 * interface.cs: workaround bug in method overloading resolution
23567 (there is already a bugzilla bug for it).
23569 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23571 We could also solve this problem by having a separate path for
23572 performing type lookups, instead of DoResolve, we could have a
23573 ResolveType entry point, and only participating pieces of the
23574 production (simplename, deref, array) would implement this.
23576 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
23577 signal SimpleName to only resolve type names and not attempt to
23578 resolve anything else.
23580 * expression.cs (Cast): Set the flag.
23582 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
23584 * class.cs: Only report 108 if there is no `new' modifier.
23586 * cs-parser.jay: rework foreach statement to work with the new
23587 changes to the policy on SimpleNames.
23589 * report.cs: support Stacktrace on warnings as well.
23591 * makefile: drop --unsafe and /unsafe from the compile.
23593 2002-03-11 Miguel de Icaza <miguel@ximian.com>
23595 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23596 lookups here, instead of doing that at parse time. This means
23597 that our grammar will not introduce `LocalVariableReferences' as
23598 expressions at this point. That solves the problem of code like
23602 static void Main ()
23606 This is only half the fix. The full fix requires parameters to
23607 also be handled in this way.
23609 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
23610 makes the use more obvious of the DeclSpace. The
23611 ec.TypeContainer.TypeBuilder is now only used to pull the
23612 TypeBuilder for it.
23614 My theory is that I can get rid of the TypeBuilder completely from
23615 the EmitContext, and have typecasts where it is used (from
23616 DeclSpace to where it matters).
23618 The only pending problem is that the code that implements Aliases
23619 is on TypeContainer, and probably should go in DeclSpace.
23621 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23622 lookups here, instead of doing that at parse time. This means
23623 that our grammar will not introduce `LocalVariableReferences' as
23624 expressions at this point. That solves the problem of code like
23628 static void Main ()
23632 This is only half the fix. The full fix requires parameters to
23633 also be handled in this way.
23635 * class.cs (Property.DefineMethod): When implementing an interface
23636 method, set newslot, when implementing an abstract method, do not
23637 set the flag (before we tried never setting it, or always setting
23638 it, which is the difference).
23639 (Indexer.DefineMethod): same.
23640 (Method.DefineMethod): same.
23642 * ecore.cs: Only set the status used flag if we get back a Field.
23644 * attribute.cs: Temporary hack, so Paolo can keep working.
23646 2002-03-08 Ravi Pratap <ravi@ximian.com>
23648 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
23649 the unmanaged type in the case we have a MarshalAs attribute.
23651 (Resolve): Handle the case when we are parsing the special MarshalAs
23652 attribute [we need to store the unmanaged type to use later]
23654 * typemanager.cs (marshal_as_attr_type): Built in type for the
23655 MarshalAs Attribute.
23657 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
23658 on parameters and accordingly set the marshalling info.
23660 2002-03-09 Miguel de Icaza <miguel@ximian.com>
23662 * class.cs: Optimizing slightly by removing redundant code after
23663 we switched to the `NoTypes' return value.
23664 (Property.DefineMethod): use NoTypes here too.
23666 This fixes the bug I introduced in my last batch of changes.
23668 2002-03-05 Ravi Pratap <ravi@ximian.com>
23670 * tree.cs (RecordEnum): Add. We now keep track of enums too.
23672 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
23673 Enums since those are types too.
23675 * cs-parser.jay (enum_declaration): Record enums as we parse them.
23677 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
23678 thanks to a call during the lookup process.
23680 2002-03-07 Miguel de Icaza <miguel@ximian.com>
23682 * statement.cs (Foreach): Lots of work to accomodate a particular
23683 kind of foreach statement that I had not kept in mind. It is
23684 possible to have foreachs on classes that provide a GetEnumerator
23685 method that return objects that implement the "pattern" for using
23686 a foreach, there is no need to support GetEnumerator
23689 This is needed to compile nant.
23691 * decl.cs: Only report 114 if the member is not `Finalize' and if
23692 the warning level is at least 2.
23694 * class.cs: Moved the compare function from Method to
23697 (MethodSignature.InheritableMemberSignatureCompare): Add new
23698 filter function that is used to extract inheritable methods from a
23701 (Method.Define): Use the new `inheritable_method_signature_filter'
23704 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
23707 2002-03-06 Miguel de Icaza <miguel@ximian.com>
23709 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
23711 * cs-parser.jay: Add opt_semicolon to the interface declaration.
23713 * expression.cs: Pass location information to
23714 ConvertImplicitStandard.
23716 * class.cs: Added debugging code to track return values from
23719 2002-03-05 Miguel de Icaza <miguel@ximian.com>
23721 * expression.cs (Is.DoResolve): If either side of the `is' is an
23722 interface, do not flag the warning.
23724 * ecore.cs (ImplicitReferenceConversion): We need a separate test
23727 * report.cs: Allow for --fatal to be used with --probe.
23729 * typemanager.cs (NoTypes): Move the definition for the empty Type
23732 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
23734 (TypeContainer.DefineProxy): New function used to proxy to parent
23735 implementations when implementing interfaces.
23736 (TypeContainer.ParentImplements): used to lookup if our parent
23737 implements a public function that is required by an interface.
23738 (TypeContainer.VerifyPendingMethods): Hook this up.
23740 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
23741 `modules' and `assemblies' arraylists into arrays. We only grow
23742 these are the very early start up of the program, so this improves
23743 the speedof LookupType (nicely measured).
23745 * expression.cs (MakeByteBlob): Replaced unsafe code with
23746 BitConverter, as suggested by Paolo.
23748 * cfold.cs (ConstantFold.Binary): Special case: perform constant
23749 folding of string concatenation, but if either side is a string,
23750 and the other is not, then return null, and let the runtime use
23751 the concatenation on the string plus the object (using
23752 `Object.ToString').
23754 2002-03-04 Miguel de Icaza <miguel@ximian.com>
23756 Constant Folding has been implemented now.
23758 * expression.cs (Unary.Reduce): Do not throw an exception, catch
23759 the error instead on types that are not supported in one's
23762 * constant.cs (Constant and all children): New set of functions to
23763 perform implict and explicit conversions.
23765 * ecore.cs (EnumConstant): Implement the new functions to perform
23766 conversion by proxying to the child expression.
23768 * codegen.cs: (ConstantCheckState): Constant evaluation has its
23769 own separate setting that can not be turned off from the command
23770 line using --unchecked or --checked and is only controlled using
23771 the checked/unchecked statements and expressions. This setting is
23772 used by the constant folder to flag errors.
23774 * expression.cs (CheckedExpr, UncheckedExpr): Set the
23775 ConstantCheckState as well.
23777 During Resolve, they also have to flag the state, because the
23778 constant folder runs completely in the Resolve phase.
23780 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
23783 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23785 * cfold.cs: New file, this file contains the constant folder.
23787 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
23788 argument to track whether we are using the resulting address to
23789 load or store a value and provide better error messages.
23791 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
23792 new AddressOf arguments.
23794 * statement.cs (Foreach.EmitCollectionForeach): Update
23796 * expression.cs (Argument.Emit): Call AddressOf with proper
23797 arguments to track usage.
23799 (New.DoEmit): Call AddressOf with new arguments.
23801 (Unary.Emit): Adjust AddressOf call.
23803 2002-03-01 Ravi Pratap <ravi@ximian.com>
23805 * cs-parser.jay (member_access): Change the case for pre-defined types
23806 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
23809 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
23812 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
23813 essentially like methods and apply attributes like MethodImplOptions to them too.
23815 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
23818 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
23819 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
23822 * Update code everywhere accordingly.
23824 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
23826 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
23828 2002-02-28 Ravi Pratap <ravi@ximian.com>
23830 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
23831 try performing lookups against those instead of jumping straight into using
23832 the 'using' clauses.
23834 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
23836 (LookupType): Perform lookups in implicit parents too.
23838 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
23839 sequence as RootContext.LookupType.
23841 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
23842 the various cases of namespace lookups into this method.
23844 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23846 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
23847 in positional arguments)
23849 * class.cs (Operator): Update the AllowedModifiers to contain
23852 * cs-parser.jay: Update operator declaration to allow for the
23853 operator body to be empty.
23855 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
23858 2002-02-27 Miguel de Icaza <miguel@ximian.com>
23860 * class.cs (Method.Emit): Label parameters.
23862 * driver.cs: Return 1 or 0 as the program exit code.
23864 2002-02-26 Miguel de Icaza <miguel@ximian.com>
23866 * expression.cs: Special case the `null' object when trying to
23867 auto-compute the type, as anything can be explicitly converted to
23870 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
23871 spotting this Paolo.
23873 (Expression.ImplicitNumericConversion): Perform comparissions of
23874 the type using the underlying type in the case of an enumeration
23875 rather than using the enumeration type for the compare.
23877 Cope with the underlying == type case, which is not possible to
23880 (Expression.ConvertNumericExplicit): Perform comparissions of
23881 the type using the underlying type in the case of an enumeration
23882 rather than using the enumeration type for the compare.
23884 * driver.cs: If the user does not supply an extension, assume .exe
23886 * cs-parser.jay (if_statement): Rewrote so that we can track the
23887 location for the if statement.
23889 * expression.cs (Binary.ConstantFold): Only concat strings when
23890 the operation is "+", not everything ;-)
23892 * statement.cs (Statement.EmitBoolExpression): Take a location
23894 (If, While, Do): Track location.
23896 * expression.cs (Binary.ResolveOperator): In the object + string
23897 case, I was missing a call to ConvertImplicit
23899 2002-02-25 Ravi Pratap <ravi@ximian.com>
23901 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
23902 Location arguments. Ensure we use RootContext.LookupType to do our work
23903 and not try to do a direct Type.GetType and ModuleBuilder.GetType
23905 * interface.cs (PopulateMethod): Handle the type of the parameter being
23908 * expression.cs (Invocation.BetterFunction): Handle the case when we
23909 have a params method with no fixed arguments and a call is made with no
23912 2002-02-25 Miguel de Icaza <miguel@ximian.com>
23914 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
23915 the verbatim-string-literal
23917 * support.cs (InternalParameters.ParameterModifier): handle null
23919 (InternalParameters.ParameterType): ditto.
23921 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
23922 duplicating the name of the variable parameter.
23923 (GetParameterByName): Fix bug where we were not looking up array
23924 paramters if they were the only present (thanks Paolo!).
23925 (GetParameterInfo): We only have an empty set of types if both
23926 fixed and array are set to null.
23927 (GetParameterInfo-idx): Handle FixedParameter == null
23929 * cs-parser.jay: Handle the case where there is no catch
23930 statements (missing null test).
23932 2002-02-22 Miguel de Icaza <miguel@ximian.com>
23934 * driver.cs (MainDriver): Be conservative on our command line
23937 Catch DirectoryNotFoundException when calling GetFiles.
23939 (SplitPathAndPattern): Used to split the input specification into
23940 a path and a pattern that we can feed to Directory.GetFiles.
23942 2002-02-21 Miguel de Icaza <miguel@ximian.com>
23944 * statement.cs (Fixed): Implement the last case of the Fixed
23945 statement (string handling).
23947 * expression.cs (StringPtr): New class used to return a char * to
23948 a string; Used by the Fixed statement.
23950 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
23952 * expression.cs (Binary.ResolveOperator): Remove redundant
23953 MemberLookup pn parent type.
23954 Optimize union call, we do not need a union if the types are the same.
23955 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
23958 Specialize the use of MemberLookup everywhere, instead of using
23959 the default settings.
23961 (StackAlloc): Implement stackalloc keyword.
23963 * cs-parser.jay: Add rule to parse stackalloc.
23965 * driver.cs: Handle /h, /help, /?
23967 * expression.cs (MakeByteBlob): Removed the hacks we had in place
23968 before we supported unsafe code.
23970 * makefile: add --unsafe to the self compilation of mcs.
23972 2002-02-20 Miguel de Icaza <miguel@ximian.com>
23974 * expression.cs (PointerArithmetic): New class that is used to
23975 perform pointer arithmetic.
23976 (Binary.Resolve): Handle pointer arithmetic
23977 Handle pointer comparission.
23978 (ArrayPtr): Utility expression class that is used to take the
23979 address of an array.
23981 (ElementAccess): Implement array access for pointers
23983 * statement.cs (Fixed): Implement fixed statement for arrays, we
23984 are missing one more case before we are done.
23986 * expression.cs (Indirection): Implement EmitAssign and set the
23987 ExprClass to Variable. This allows pointer dereferences to be
23988 treated as variables, and to have values assigned to them.
23990 * ecore.cs (Expression.StoreFromPtr): New utility function to
23991 store values dereferencing.
23993 2002-02-20 Ravi Pratap <ravi@ximian.com>
23995 * expression.cs (Binary.ResolveOperator): Ensure that we are
23996 not trying to operate on a void type - this fixes the reported
23999 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
24000 the parent implementation is sealed.
24002 * ../errors/cs0239.cs : Add.
24004 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
24006 * typemanager.cs (unverifiable_code_type): Corresponds to
24007 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
24008 which have unsafe code in them.
24010 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
24013 2002-02-19 Miguel de Icaza <miguel@ximian.com>
24015 * cs-tokenizer.cs: Add support for @"litreal strings"
24017 Make tokenizer accept pre-processor directives
24018 on any column (remove the old C-like limitation).
24020 * rootcontext.cs (EmitCode): Emit any global attributes.
24021 (AddGlobalAttributes): Used to keep track of assembly attributes.
24023 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
24025 * cs-parser.jay: Add support for global attributes.
24027 2002-02-17 Miguel de Icaza <miguel@ximian.com>
24029 * expression.cs (Indirection): New helper class. Unary will
24030 create Indirection classes to be able to implement the
24031 IMemoryLocation interface on it.
24033 2002-02-16 Miguel de Icaza <miguel@ximian.com>
24035 * cs-parser.jay (fixed_statement): reference the right statement.
24037 * statement.cs (Fixed.Emit): Finish implementing the fixed
24038 statement for the &x case.
24040 2002-02-14 Miguel de Icaza <miguel@ximian.com>
24042 * class.cs (Property.Define, Method.Define): Remove newslot when
24045 * modifiers.cs: My use of NewSlot when `Abstract' was set was
24046 wrong. NewSlot should only be used if the `new' keyword is present.
24048 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
24049 locating our system dir. Sorry about this.
24051 2002-02-13 Miguel de Icaza <miguel@ximian.com>
24053 * driver.cs (GetSystemDir): Compute correctly the location of our
24054 system assemblies. I was using the compiler directory instead of
24055 the library directory.
24057 2002-02-13 Ravi Pratap <ravi@ximian.com>
24059 * expression.cs (BetterFunction): Put back in what Miguel commented out
24060 since it is the correct fix. The problem is elsewhere ;-)
24062 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
24063 parameters of the parms method are themselves compatible or not !
24065 (StandardConversionExists): Fix very dangerous bug where we were forgetting
24066 to check that a class implements an interface before saying that an implicit
24067 conversion was allowed. Use ImplementsInterface to do the checking.
24069 2002-02-13 Miguel de Icaza <miguel@ximian.com>
24071 * class.cs (Method.Define): Track whether we are an explicit
24072 implementation or not. And only call DefineMethodOverride if we
24073 are an explicit implementation.
24075 (Property.DefineMethod): Ditto.
24077 2002-02-11 Ravi Pratap <ravi@ximian.com>
24079 * expression.cs (BetterFunction): Catch hideous bug which was
24080 preventing us from detecting ambiguous calls due to implicit casts i.e
24083 2002-01-29 Miguel de Icaza <miguel@ximian.com>
24085 * support.cs (Pair): Remove un-needed method. I figured why I was
24086 getting the error in cs-parser.jay, the variable in a foreach loop
24087 is readonly, and the compiler does not really treat this as a variable.
24089 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
24090 instead of EQUALS in grammar.
24092 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
24094 * expression.cs (Unary.DoResolve): Check whether the argument is
24097 2002-01-28 Miguel de Icaza <miguel@ximian.com>
24099 * support.cs: Api for Pair to set a value. Despite the fact that
24100 the variables are public the MS C# compiler refuses to compile
24101 code that accesses the field if the variable is part of a foreach
24104 * statement.cs (Fixed): Begin implementation of the fixed
24107 (Block.AddVariable): Return the VariableInfo on success and null
24108 on failure instead of true/false.
24110 * cs-parser.jay (foreach): Catch errors on variables already
24111 defined (we were ignoring this value before) and properly unwind
24112 the block hierarchy
24114 (fixed_statement): grammar for the fixed statement.
24116 2002-01-25 Miguel de Icaza <miguel@ximian.com>
24118 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
24119 pointer types to be incretemented.
24121 (SizeOf): Implement.
24123 * cs-parser.jay (pointer_member_access): Implement
24124 expr->IDENTIFIER production.
24126 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
24127 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
24130 (Unary): Implement indirection.
24132 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
24133 use in non-unsafe context).
24135 (SimpleName.DoResolve): Check for pointers in field access on safe
24138 (Expression.LoadFromPtr): Factor the load-indirect code in this
24139 function. This was duplicated in UnboxCast and ParameterReference
24141 2002-01-24 Miguel de Icaza <miguel@ximian.com>
24143 * expression.cs (ComposedCast): report an error if a pointer cast
24144 is used in a safe region.
24146 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
24147 pointer type casts in unsafe context.
24149 * codegen.cs (EmitContext): Set up IsUnsafe.
24151 * cs-parser.jay (non_expression_type): Add productions for pointer
24154 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
24155 code. We should not use force into static mode if the method is
24156 not virtual. Fixes bug in MIS
24158 * statement.cs (Do.Emit, While.Emit, For.Emit,
24159 Statement.EmitBoolExpression): Add support to Do and While to
24160 propagate infinite loop as `I do return' semantics.
24162 Improve the For case to also test for boolean constants.
24164 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
24165 to the list of attributes we can add.
24167 Remove `EmitContext' argument.
24169 * class.cs (Method.Define): Apply parameter attributes.
24170 (Constructor.Define): Apply parameter attributes.
24171 (MethodCore.LabelParameters): Move here the core of labeling
24174 * support.cs (ReflectionParameters.ParameterModifier,
24175 InternalParameters.ParameterModifier): Use IsByRef on the type and
24176 only return the OUT bit for these parameters instead of in/out/ref
24179 This is because I miss-understood things. The ParameterInfo.IsIn
24180 and IsOut represent whether the parameter has the [In] and [Out]
24183 2002-01-22 Miguel de Icaza <miguel@ximian.com>
24185 * ecore.cs (FieldExpr.Emit): Release temporaries.
24187 * assign.cs (LocalTemporary.Release): new function.
24189 * codegen.cs (EmitContext.GetTemporaryStorage,
24190 EmitContext.FreeTemporaryStorage): Rework the way we deal with
24191 temporary storage. Now we can "put back" localbuilders when we
24194 2002-01-21 Miguel de Icaza <miguel@ximian.com>
24196 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
24197 need to make a copy of the variable to generate verifiable code.
24199 2002-01-19 Miguel de Icaza <miguel@ximian.com>
24201 * driver.cs: Compute dynamically the system directory.
24203 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
24204 Slower, but more generally useful. Used by the abstract
24205 registering implementation.
24207 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
24208 the rules for the special rule on Type/instances. First check if
24209 we have the same name, and if so, try that special static path
24210 rather than the instance path.
24212 2002-01-18 Miguel de Icaza <miguel@ximian.com>
24214 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
24217 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
24218 Enum, ValueType, Delegate or Array for non-corlib compiles.
24220 * cs-tokenizer.cs: Catch long identifiers (645)
24222 * typemanager.cs (IndexerPropetyName): Ravi never tested this
24225 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
24226 fix, we were returning too early, so we were not registering
24227 pending methods from abstract classes.
24229 Do not register pending methods if the class is abstract.
24231 * expression.cs (Conditional.DoResolve): Report circular implicit
24232 conversions when we neecd to compute it for conditional
24235 (Is.DoResolve): If the expression is always of the provided type,
24236 flag warning 183. If the expression can not ever be of the
24237 provided type flag warning 184.
24239 * class.cs: Catch 169 as well.
24241 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
24244 2002-01-18 Nick Drochak <ndrochak@gol.com>
24246 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
24248 2002-01-17 Miguel de Icaza <miguel@ximian.com>
24250 * interface.cs: (PopulateMethod): Check for pointers being defined
24251 only if the unsafe context is active.
24252 (PopulateProperty): ditto.
24253 (PopulateIndexer): ditto.
24255 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
24256 specified. If pointers are present, make sure that they are
24257 present in an unsafe context.
24258 (Constructor, Constructor.Define): ditto.
24259 (Field, Field.Define): ditto.
24260 (Property, Property.Define): ditto.
24261 (Event, Event.Define): ditto.
24263 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
24264 hashtable if there are classes or structs defined.
24266 * expression.cs (LocalVariableReference.DoResolve): Simplify this
24267 code, as the constant resolution moved.
24269 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
24270 the metadata, so we can flag error 133.
24272 * decl.cs (MemberCore.UnsafeOK): New function to test that a
24273 pointer is being declared in an unsafe context.
24275 2002-01-16 Miguel de Icaza <miguel@ximian.com>
24277 * modifiers.cs (Modifiers.Check): Require a Location argument.
24278 Report error 227 for Unsafe use.
24280 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
24282 * statement.cs (For.Emit): If the test is null, then report that
24283 we do `return', as we wont reach anything afterwards.
24285 (Switch.SwitchGoverningType): Track the expression that matched
24288 * driver.cs: Allow negative numbers as an error code to flag.
24290 * cs-parser.jay: Handle 1551.
24292 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
24294 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24296 * cs-parser.jay: Report 1518 (type declaration can only contain
24297 class, struct, interface, enum or delegate)
24299 (switch_label): Report 1523 (keywords `case' or `default' must
24302 (opt_switch_sections): Report 1522 (empty switch)
24304 * driver.cs: Report 1515 (response file specified multiple times)
24305 Report 1516 (Source file specified multiple times).
24307 * expression.cs (Argument.Resolve): Signal 1510
24309 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
24310 access not allowed in static code)
24312 2002-01-11 Ravi Pratap <ravi@ximian.com>
24314 * typemanager.cs (IsPointerType): Utility method which we are going
24317 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
24318 the object type, so we take care of that.
24320 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
24322 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
24323 added to non-params parameters :-)
24325 * typemanager.cs (CSharpName): Include 'void' type too.
24327 (void_ptr_type): Include in the set of core types.
24329 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
24332 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
24335 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
24336 completely forgotten about it.
24338 2002-01-10 Ravi Pratap <ravi@ximian.com>
24340 * cs-parser.jay (pointer_type): Add. This begins our implementation
24341 of parsing rules for unsafe code.
24343 (unsafe_statement): Implement.
24345 (embedded_statement): Modify to include the above.
24347 * statement.cs (Unsafe): Implement new class for unsafe blocks.
24349 * codegen.cs (EmitContext.InUnsafe): Add. This determines
24350 if the current context is an unsafe one.
24352 * cs-parser.jay (local_variable_pointer_type): Since local variable types
24353 are handled differently, we need separate rules for them.
24355 (local_variable_declaration): Update to use local_variable_pointer_type
24356 to allow variable declarations of unmanaged pointer types.
24358 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
24359 in unsafe contexts.
24361 * ../errors/cs0214.cs : Add.
24363 2002-01-16 Nick Drochak <ndrochak@gol.com>
24365 * makefile: remove 'response' file when cleaning.
24367 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24369 * cs-parser.jay: Report 1524.
24371 2002-01-14 Miguel de Icaza <miguel@ximian.com>
24373 * typemanager.cs (RegisterMethod): drop checking if we have
24374 registered this from here
24376 2002-01-12 Miguel de Icaza <miguel@ximian.com>
24378 * class.cs (Method.EmitDestructor): Implement calling our base
24381 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
24382 value of InFinally.
24384 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
24385 this routine and will wrap the call in a try/catch block. Deal
24388 2002-01-11 Miguel de Icaza <miguel@ximian.com>
24390 * ecore.cs (Expression.MemberLookup): instead of taking a
24391 parameter `same_type' that was used to tell whether we could
24392 access private members we compute our containing type from the
24395 (FieldExpr): Added partial support for volatile fields. This does
24396 not work for volatile fields exposed from assemblies, as I can not
24397 figure out how to extract the modreq from it.
24399 Updated all the source files to use this.
24401 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
24402 because it is referenced by MemberLookup very often.
24404 2002-01-09 Ravi Pratap <ravi@ximian.com>
24406 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
24407 TypeBuilder.GetCustomAttributes to retrieve what we need.
24409 Get rid of redundant default_member_attr_type as this is the same as
24410 default_member_type which already exists.
24412 * interface.cs, attribute.cs : Update accordingly.
24414 2002-01-08 Miguel de Icaza <miguel@ximian.com>
24416 * typemanager.cs: Enable IndexerPropertyName again. It does not
24417 work for TYpeBuilders though. Ravi, can you please fix this?
24419 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
24421 * expression.cs (Argument.Emit): Handle the case of ref objects
24422 being passed to ref functions;
24424 (ParameterReference.EmitLoad): Loads the content of the pointer
24425 without dereferencing.
24427 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24429 * cs-tokenizer.cs: Implemented the pre-processing expressions.
24431 2002-01-08 Ravi Pratap <ravi@ximian.com>
24433 * class.cs (Indexer.DefineMethod): Incorporate the interface
24434 type in the name of the method if we are doing explicit interface
24437 * expression.cs (ConversionExists): Remove as it is completely obsolete.
24439 (BetterConversion): Fix extremely trivial bug where we were referring to
24440 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
24443 * ../errors/bug16.cs : Add although we have fixed it.
24445 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24447 * expression.cs (BaseIndexer): Begin implementation.
24449 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
24451 * cs-parser.jay (indexer_declarator): Use qualified_identifier
24452 production directly to remove a shift/reduce, and implement
24453 explicit interface implementation.
24455 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
24456 after a floating point suffix.
24458 * expression.cs (DoNumericPromotions): Improved the conversion for
24459 uint/uint. If we have a constant, we avoid doing a typecast to a
24462 * class.cs (Indexer): Implement explicit interface implementation
24465 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
24467 * class.cs: make the default instance constructor public and hidebysig.
24469 2001-01-03 Ravi Pratap <ravi@ximian.com>
24471 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
24472 so we can call it from elsewhere.
24474 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
24475 we emit it internally if the class has a defined indexer; otherwise the user
24476 emits it by decorating the class definition with the DefaultMemberAttribute.
24478 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
24479 attribute is not used on a type which defines an indexer.
24481 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
24482 character when we skip whitespace.
24484 * ../errors/cs0646.cs : Add.
24486 2002-01-03 Miguel de Icaza <miguel@ximian.com>
24488 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
24491 * makefile: Add practical target `mcs3.exe' which builds the third
24492 generation compiler.
24494 * expression.cs (New): Fix structures constructor calling.
24496 * class.cs (Property, Method, Indexer): Emit Final flag on the
24497 method if we are an interface implementation and we are not
24500 * ecore.cs (PropertyExpr): New public field `IsBase', tells
24501 whether this property is referencing a `base' method.
24503 * expression.cs (Invocation.EmitCall): take an extra argument:
24504 is_base, this is used to determine whether the `call' or
24505 `callvirt' opcode should be used.
24508 * delegate.cs: update EmitCall.
24510 * class.cs (Method.Define): Set NewSlot for the cases where we are
24511 not implementing an interface method.
24513 (Property.Define): ditto.
24515 2002-01-02 Miguel de Icaza <miguel@ximian.com>
24517 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
24518 'r'. Allows mcs to parse itself fully.
24520 2002-01-02 Ravi Pratap <ravi@ximian.com>
24522 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
24523 of the number of initializers that require the InitializeArray method.
24525 (CheckIndices): Store the Expression in all cases - not the plain value. Also
24526 update the above field where necessary.
24528 (MakeByteBlob): Update accordingly.
24530 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
24533 (EmitDynamicInitializers): Update in accordance with the new optimization.
24535 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
24536 same OpCode applies.
24538 * cs-parser.jay : Fix some glaring errors I introduced.
24540 2002-01-01 Ravi Pratap <ravi@ximian.com>
24542 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
24543 so that we can check for name clashes there too.
24545 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
24546 for interface indexers.
24548 * interfaces.cs (Define): Emit the default member attribute.
24550 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
24551 variable was being referred to while setting the value ;-)
24553 2002-01-01 Miguel de Icaza <miguel@ximian.com>
24555 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
24556 byte-by-byte information when we know the data is zero.
24558 Make the block always a multiple of 4, because
24559 DefineInitializedData has a bug.
24561 * assign.cs: Fix, we should assign from the temporary, not from
24564 * expression.cs (MakeByteBlob): Fix my incorrect code.
24566 2001-12-31 Miguel de Icaza <miguel@ximian.com>
24568 * typemanager.cs (EnumToUnderlying): This function is used to get
24569 the underlying type from an enumeration, because it does not
24572 * constant.cs: Use the I4_S form for values between -128 and 127.
24574 * statement.cs (Block.LookupLabel): Looks up a label.
24575 (Block): Drop support for labeled blocks.
24577 (LabeledStatement): New kind of statement that represents a label
24580 (Goto): Finally implement this bad boy.
24582 * cs-parser.jay: Update to reflect new mechanism to implement
24585 2001-12-30 Miguel de Icaza <miguel@ximian.com>
24587 * codegen.cs (EmitContext.This): a codegen property that keeps the
24588 a single instance of this instead of creating many different this
24591 * delegate.cs (Delegate.DoResolve): Update to use the property;
24593 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
24595 * expression.cs (BaseAccess.DoResolve): Ditto.
24597 2001-12-29 Ravi Pratap <ravi@ximian.com>
24599 * typemanager.cs (methodimpl_attr_type): Add to hold the type
24600 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
24602 (InitCoreTypes): Update accordingly.
24604 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
24605 so we can quickly store the state.
24607 (ApplyAttributes): Set the correct implementation flags
24608 for InternalCall methods.
24610 2001-12-29 Miguel de Icaza <miguel@ximian.com>
24612 * expression.cs (EmitCall): if a method is not virtual, then do
24613 not use callvirt on it.
24615 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
24616 user defined stuff) requires the use of stobj, which takes an
24617 address on the stack instead of an array and an index. So emit
24618 the Ldelema operation for it.
24620 (EmitStoreOpcode): Use stobj for valuetypes.
24622 (UnaryMutator.EmitCode): Use the right 1 value depending on
24623 whether we are dealing with int64/uint64, float or doubles.
24625 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
24626 constructors that I implemented last night.
24628 (Constructor.IsDefault): Fix to work properly for static
24631 * cs-parser.jay (CheckDef): report method signature errors.
24632 Update error number 103 to be 132.
24634 * decl.cs: New AdditionResult enumeration value: MethodExists.
24635 Although we do this check for methods later on in the semantic
24636 analysis, catching repeated default constructors is so easy that
24637 we catch these here.
24639 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
24642 (ParameterReference.EmitAssign, Emit): handle
24645 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
24646 (ArrayAccess.EmitStoreOpcode): ditto.
24648 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
24650 * expression.cs (MakeByteBlob): Complete all the missing types
24651 (uint, short, ushort, byte, sbyte)
24653 * class.cs: Only init instance field initializers on instance
24656 Rename `constructors' to instance_constructors.
24658 (TypeContainer.AddConstructor): Only add constructors to the list
24659 if it is not static.
24661 Make sure that we handle default_static_constructor independently
24662 everywhere where we handle instance_constructors
24664 2001-12-28 Miguel de Icaza <miguel@ximian.com>
24666 * class.cs: Do not lookup or create a base initializer for a
24667 static constructor.
24669 (ConstructorInitializer.Resolve): use the proper type to lookup
24672 * cs-parser.jay: Report error 1585 (modifiers between type and name).
24674 * enum.cs, interface.cs: Remove CloseType, this is taken care by
24677 * decl.cs: CloseType is now an virtual method, the default
24678 implementation just closes this type.
24680 2001-12-28 Ravi Pratap <ravi@ximian.com>
24682 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
24683 to PreserveSig by default. Also emit HideBySig on such methods.
24685 Basically, set the defaults to standard values.
24687 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
24688 argument, if candidate is better, it can't be worse than the best !
24690 (Invocation): Re-write bits to differentiate between methods being
24691 applicable in their expanded form and their normal form - for params
24694 Get rid of use_standard everywhere as only standard conversions are allowed
24695 in overload resolution.
24697 More spec conformance.
24699 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24701 * driver.cs: Add --timestamp, to see where the compiler spends
24704 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
24705 `this' in static code.
24707 (SimpleName.DoResolve): Implement in terms of a helper function
24708 that allows static-references to be passed upstream to
24711 (Expression.ResolveWithSimpleName): Resolve specially simple
24712 names when called by MemberAccess to implement the special
24715 (Expression.ImplicitReferenceConversion): Handle conversions from
24716 Null to reference types before others, as Null's type is
24719 * expression.cs (Invocation.EmitCall): Handle the special case of
24720 calling methods declared on a reference type from a ValueType
24721 (Base classes System.Object and System.Enum)
24723 (MemberAccess.Resolve): Only perform lookups on Enumerations if
24724 the left hand side is a TypeExpr, not on every enumeration.
24726 (Binary.Resolve): If types are reference types, then do a cast to
24727 object on operators != and == of both arguments.
24729 * typemanager.cs (FindMembers): Extract instance and static
24730 members if requested.
24732 * interface.cs (PopulateProperty): Use void_type instead of null
24733 as the return type for the setter method.
24735 (PopulateIndexer): ditto.
24737 2001-12-27 Ravi Pratap <ravi@ximian.com>
24739 * support.cs (ReflectionParameters): Fix minor bug where we
24740 were examining the wrong parameter for the ParamArray attribute.
24742 Cope with requests for the type of the parameter at position
24743 greater than the params parameter's. We now return the element
24744 type of the params array as that makes more sense.
24746 * expression.cs (Invocation.IsParamsMethodApplicable): Update
24747 accordingly as we no longer have to extract the element type
24750 (Invocation.OverloadResolve): Update.
24752 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24754 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
24755 against IEnumerator, test whether the return value is a descendant
24756 of the IEnumerator interface.
24758 * class.cs (Indexer.Define): Use an auxiliary method to implement
24759 the other bits of the method definition. Begin support for
24760 explicit interface implementation.
24762 (Property.DefineMethod): Use TypeManager.void_type instead of null
24763 for an empty return value.
24765 2001-12-26 Miguel de Icaza <miguel@ximian.com>
24767 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
24768 dealing with a FieldExpr which is composed of a FieldBuilder, in
24769 the code path we did extract the constant, but we should have
24770 obtained the underlying value to be able to cast it (otherwise we
24771 end up in an infinite loop, this is what Ravi was running into).
24773 (ArrayCreation.UpdateIndices): Arrays might be empty.
24775 (MemberAccess.ResolveMemberAccess): Add support for section
24776 14.5.4.1 that deals with the special case of E.I when E is a type
24777 and something else, that I can be a reference to a static member.
24779 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
24780 handle a particular array type to create byte blobs, it is just
24781 something we dont generate byteblobs for.
24783 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
24786 * location.cs (Push): remove the key from the hashtable that we
24787 are about to add. This happens for empty files.
24789 * driver.cs: Dispose files after we have parsed them.
24791 (tokenize): new function that only runs the tokenizer on its
24792 input, for speed testing.
24794 2001-12-26 Ravi Pratap <ravi@ximian.com>
24796 * class.cs (Event.Define): Define the private field only if there
24797 are no accessors defined.
24799 * expression.cs (ResolveMemberAccess): If there is no associated
24800 field with the event, that means we have an event defined with its
24801 own accessors and we should flag error cs0070 since transforming
24802 ourselves into a field is not valid in that case.
24804 * ecore.cs (SimpleName.DoResolve): Same as above.
24806 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
24807 and charset to sane values.
24809 2001-12-25 Ravi Pratap <ravi@ximian.com>
24811 * assign.cs (DoResolve): Perform check on events only if they
24812 are being accessed outside the declaring type.
24814 * cs-parser.jay (event_declarations): Update rules to correctly
24815 set the type of the implicit parameter etc.
24817 (add_accessor, remove_accessor): Set current local parameters.
24819 * expression.cs (Binary): For delegate addition and subtraction,
24820 cast the return value from the method into the appropriate delegate
24823 2001-12-24 Ravi Pratap <ravi@ximian.com>
24825 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
24826 of these as the workaround is unnecessary.
24828 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
24829 delegate data - none of that is needed at all.
24831 Re-write bits to extract the instance expression and the delegate method
24834 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
24837 * attribute.cs (ApplyAttributes): New method to take care of common tasks
24838 of attaching attributes instead of duplicating code everywhere.
24840 * everywhere : Update code to do attribute emission using the above method.
24842 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24844 * expression.cs (IsParamsMethodApplicable): if there are not
24845 parameters, return immediately.
24847 * ecore.cs: The 0 literal can be implicity converted to an enum
24850 (SimpleName.DoResolve): First lookup the type, then lookup the
24853 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
24854 want to get its address. If the InstanceExpression is not
24855 addressable, store the result in a temporary variable, then get
24858 * codegen.cs: Only display 219 errors on warning level or above.
24860 * expression.cs (ArrayAccess): Make it implement the
24861 IMemoryLocation interface.
24863 (Binary.DoResolve): handle the operator == (object a, object b)
24864 and operator != (object a, object b) without incurring into a
24865 BoxedCast (because 5 != o should never be performed).
24867 Handle binary enumerator operators.
24869 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
24870 value type, otherwise use Ldelem_ref.
24872 Use precomputed names;
24874 (AddressOf): Implement address of
24876 * cs-parser.jay (labeled_statement): Fix recursive block
24877 addition by reworking the production.
24879 * expression.cs (New.DoEmit): New has a special case:
24881 If we are dealing with a ValueType, we have a few
24882 situations to deal with:
24884 * The target of New is a ValueType variable, that is
24885 easy, we just pass this as the variable reference
24887 * The target of New is being passed as an argument,
24888 to a boxing operation or a function that takes a
24891 In this case, we need to create a temporary variable
24892 that is the argument of New.
24895 2001-12-23 Ravi Pratap <ravi@ximian.com>
24897 * rootcontext.cs (LookupType): Check that current_type is not null before
24898 going about looking at nested types.
24900 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
24901 not implement the IAssignMethod interface any more.
24903 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
24904 where we tranform them into FieldExprs if they are being resolved from within
24905 the declaring type.
24907 * ecore.cs (SimpleName.DoResolve): Do the same here.
24909 * assign.cs (DoResolve, Emit): Clean up code considerably.
24911 * ../errors/bug10.cs : Add.
24913 * ../errors/cs0070.cs : Add.
24915 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
24917 * assign.cs : Get rid of EventIsLocal everywhere.
24919 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24921 * ecore.cs (ConvertIntLiteral): finished the implementation.
24923 * statement.cs (SwitchLabel): Convert the value we are using as a
24924 key before looking up the table.
24926 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24928 * codegen.cs (EmitTopBlock): Require a Location argument now.
24930 * cs-parser.jay (constructor_declarator): We need to setup
24931 current_local_parameters before we parse the
24932 opt_constructor_initializer, to allow the variables to be bound
24933 to the constructor arguments.
24935 * rootcontext.cs (LookupType): First lookup nested classes in our
24936 class and our parents before we go looking outside our class.
24938 * expression.cs (ConstantFold): Extract/debox the values at the
24941 * rootcontext.cs (EmitCode): Resolve the constants first before we
24942 resolve the types. This is not really needed, but it helps debugging.
24944 * statement.cs: report location.
24946 * cs-parser.jay: pass location to throw statement.
24948 * driver.cs: Small bug fix.
24950 * report.cs: Updated format to be 4-zero filled digits.
24952 2001-12-22 Ravi Pratap <ravi@ximian.com>
24954 * expression.cs (CheckIndices): Fix minor bug where the wrong
24955 variable was being referred to ;-)
24957 (DoEmit): Do not call EmitStaticInitializers when the
24958 underlying type is System.Object.
24960 2001-12-21 Ravi Pratap <ravi@ximian.com>
24962 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
24963 and do the usual workaround for SRE.
24965 * class.cs (MyEventBuilder.EventType): New member to get at the type
24966 of the event, quickly.
24968 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
24970 * assign.cs (Assign.DoResolve): Handle the case when the target
24971 is an EventExpr and perform the necessary checks.
24973 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
24976 (SimpleName.MemberStaticCheck): Include check for EventExpr.
24978 (EventExpr): Set the type in the constructor itself since we
24979 are meant to be born fully resolved.
24981 (EventExpr.Define): Revert code I wrote earlier.
24983 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
24984 instance expression is null. The instance expression is a This in that case
24985 or a null, depending on whether it is a static method or not.
24987 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
24988 refers to more than one method.
24990 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
24991 and accordingly flag errors.
24993 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24995 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
24997 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24999 * location.cs (ToString): Provide useful rutine.
25001 2001-12-21 Miguel de Icaza <miguel@ximian.com>
25003 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
25004 objects, return the actual integral boxed.
25006 * statement.cs (SwitchLabel): define an ILLabel for each
25009 (Switch.CheckSwitch): If the value is a Literal, extract
25010 the underlying literal.
25012 Also in the unused hashtable we had, add the SwitchLabel so we can
25013 quickly look this value up.
25015 * constant.cs: Implement a bunch of new constants. Rewrite
25016 Literal based on this. Made changes everywhere to adapt to this.
25018 * expression.cs (Expression.MakeByteBlob): Optimize routine by
25019 dereferencing array only once, and also copes with enumrations.
25021 bytes are two bytes wide, not one.
25023 (Cast): Perform constant conversions.
25025 * ecore.cs (TryImplicitIntConversion): Return literals instead of
25026 wrappers to the literals here.
25028 * expression.cs (DoNumericPromotions): long literals can converted
25029 to ulong implicity (this is taken care of elsewhere, but I was
25030 missing this spot).
25032 * ecore.cs (Expression.Literalize): Make the return type Literal,
25033 to improve type checking.
25035 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
25037 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25039 * literal.cs: Revert code from ravi that checked the bounds. The
25040 bounds are sane by the definition of the type itself.
25042 * typemanager.cs: Fix implementation of ImplementsInterface. We
25043 need to actually look up in our parent hierarchy for interfaces
25046 * const.cs: Use the underlying type for enumerations
25048 * delegate.cs: Compute the basename for the delegate creation,
25049 that should fix the delegate test case, and restore the correct
25050 Type Lookup semantics in rootcontext
25052 * rootcontext.cs: Revert Ravi's last patch. The correct way of
25053 referencing a nested type with the Reflection API is using the "+"
25056 * cs-parser.jay: Do not require EOF token at the end.
25058 2001-12-20 Ravi Pratap <ravi@ximian.com>
25060 * rootcontext.cs (LookupType): Concatenate type names with
25061 a '.' instead of a '+' The test suite passes again.
25063 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
25064 field of the enumeration.
25066 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
25067 the case when the member is an EventExpr.
25069 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
25070 static has an associated instance expression.
25072 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
25074 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
25076 * class.cs (Event.Define): Register event and perform appropriate checks
25079 We define the Add and Remove methods even if the use provides none because
25080 in that case, we provide default implementations ourselves.
25082 Define a private field of the type of the event. This is done by the CSC compiler
25083 and we should be doing it too ;-)
25085 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
25086 More methods we use in code we generate.
25088 (multicast_delegate_type, delegate_type): Two separate types since the distinction
25091 (InitCoreTypes): Update accordingly for the above.
25093 * class.cs (Event.Emit): Generate code for default accessors that we provide
25095 (EmitDefaultMethod): Do the job in the above.
25097 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
25100 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25102 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
25103 builders even if we were missing one.
25105 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
25106 pass the Basename as our class name instead of the Name. The
25107 basename will be correctly composed for us.
25109 * parameter.cs (Paramters): Now takes a Location argument.
25111 * decl.cs (DeclSpace.LookupType): Removed convenience function and
25112 make all the code call directly LookupType in RootContext and take
25113 this chance to pass the Location information everywhere.
25115 * Everywhere: pass Location information.
25117 2001-12-19 Miguel de Icaza <miguel@ximian.com>
25119 * class.cs (Constructor.Define): Updated way of detecting the
25120 length of the parameters.
25122 (TypeContainer.DefineType): Use basename as the type name for
25125 (TypeContainer.Define): Do not recursively define types here, as
25126 definition is taken care in order by the RootContext.
25128 * tree.cs: Keep track of namespaces in a per-file basis.
25130 * parameter.cs (Parameter.ComputeSignature): Update to use
25133 (Parameters.GetSignature): ditto.
25135 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
25136 instead of a TypeContainer.
25138 (Interface.SemanticAnalysis): Use `this' instead of our parent to
25139 resolve names. Because we need to be resolve in our context, not
25142 * driver.cs: Implement response files.
25144 * class.cs (TypeContainer.DefineType): If we are defined, do not
25145 redefine ourselves.
25147 (Event.Emit): Emit the code for add/remove handlers.
25148 (Event.Define): Save the MethodBuilders for add/remove.
25150 * typemanager.cs: Use pair here too.
25152 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
25153 DictionaryEntry requires the first argument to be non-null.
25155 (enum_declaration): Compute full name for registering the
25158 (delegate_declaration): Instead of using
25159 formal_parameter_list, use opt_formal_parameter_list as the list
25162 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
25163 (EventParsing): New property that controls whether `add' and
25164 `remove' are returned as tokens or identifiers (for events);
25166 2001-12-19 Ravi Pratap <ravi@ximian.com>
25168 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
25169 use MyEventBuilder only and let it wrap the real builder for us.
25171 (MyEventBuilder): Revamp constructor etc.
25173 Implement all operations that we perform on EventBuilder in precisely the same
25176 (FindMembers): Update to use the EventBuilder member.
25178 (Event.Emit): Update accordingly.
25180 2001-12-18 Ravi Pratap <ravi@ximian.com>
25182 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
25183 by calling the appropriate methods.
25185 (GetCustomAttributes): Make stubs as they cannot possibly do anything
25188 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
25190 2001-12-17 Ravi Pratap <ravi@ximian.com>
25192 * delegate.cs (Delegate.Populate): Check that the return type
25193 and various parameters types are indeed accessible.
25195 * class.cs (Constructor.Define): Same here.
25197 (Field.Define): Ditto.
25199 (Event.Define): Ditto.
25201 (Operator.Define): Check that the underlying Method defined itself
25202 correctly - so it's MethodBuilder should not be null.
25204 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
25205 expression happens to be null.
25207 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
25208 members but as of now we don't seem to be able to do anything really useful with it.
25210 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
25211 not the EventBuilder.
25213 2001-12-18 Miguel de Icaza <miguel@ximian.com>
25215 * cs-tokenizer.cs: Add support for defines.
25216 Add support for #if, #elif, #else, #endif
25218 (eval_var): evaluates a variable.
25219 (eval): stubbed for evaluating functions.
25221 * cs-parser.jay: Pass the defines information
25223 * driver.cs: Add --define command line option.
25225 * decl.cs: Move MemberCore here.
25227 Make it the base class for DeclSpace. This allows us to catch and
25228 report 108 and 109 for everything now.
25230 * class.cs (TypeContainer.Define): Extract all the members
25231 before populating and emit the warning 108 (new keyword required
25232 to override) instead of having each member implement this.
25234 (MemberCore.Define): New abstract method, we will be using this in
25235 the warning reporting engine in Populate.
25237 (Operator.Define): Adjust to new MemberCore protocol.
25239 * const.cs (Const): This does not derive from Expression, it is a
25240 temporary object we use to create fields, it is a MemberCore.
25242 * class.cs (Method.Define): Allow the entry point to be in a
25245 * driver.cs: Rewrite the argument handler to clean it up a bit.
25247 * rootcontext.cs: Made it just an auxiliary namespace feature by
25248 making everything static.
25250 * driver.cs: Adapt code to use RootContext type name instead of
25253 * delegate.cs: Remove RootContext argument.
25255 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
25258 * class.cs (Event.Define): The lookup can fail.
25260 * cs-tokenizer.cs: Begin implementation of pre-procesor.
25262 * expression.cs: Resolve the this instance before invoking the code.
25264 2001-12-17 Miguel de Icaza <miguel@ximian.com>
25266 * cs-parser.jay: Add a production in element_access that allows
25267 the thing to become a "type" reference. This way we can parse
25268 things like "(string [])" as a type.
25270 Note that this still does not handle the more complex rules of
25274 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
25276 * ecore.cs: (CopyNewMethods): new utility function used to
25277 assemble the list of methods from running FindMembers.
25279 (MemberLookup): Rework FindMembers so that
25281 2001-12-16 Miguel de Icaza <miguel@ximian.com>
25283 * class.cs (TypeContainer): Remove Delegates who fail to be
25286 * delegate.cs (Populate): Verify that we dont get null return
25287 values. TODO: Check for AsAccessible.
25289 * cs-parser.jay: Use basename to emit error 574 (destructor should
25290 have the same name as container class), not the full name.
25292 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
25293 possible representation.
25295 Also implements integer type suffixes U and L.
25297 2001-12-15 Miguel de Icaza <miguel@ximian.com>
25299 * expression.cs (ArrayCreation.DoResolve): We need to do the
25300 argument resolution *always*.
25302 * decl.cs: Make this hold the namespace. Hold the root context as
25304 (LookupType): Move here.
25306 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
25308 * location.cs (Row, Name): Fixed the code, it was always returning
25309 references to the first file.
25311 * interface.cs: Register properties defined through interfaces.
25313 * driver.cs: Add support for globbing on the command line
25315 * class.cs (Field): Make it derive from MemberCore as well.
25318 2001-12-15 Ravi Pratap <ravi@ximian.com>
25320 * class.cs (Event::Define): Check that the type of the event is a delegate
25321 type else flag error #66.
25323 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
25326 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
25327 values of EntryPoint, CharSet etc etc.
25329 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
25331 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
25332 be null and we should ignore this. I am not sure if this is really clean. Apparently,
25333 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
25334 which needs this to do its work.
25336 * ../errors/cs0066.cs : Add.
25338 2001-12-14 Miguel de Icaza <miguel@ximian.com>
25340 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
25343 * class.cs: (MethodSignature.MethodSignature): Removed hack that
25344 clears out the parameters field.
25345 (MemberSignatureCompare): Cleanup
25347 (MemberCore): New base class used to share code between MethodCore
25350 (RegisterRequiredImplementations) BindingFlags.Public requires
25351 either BindingFlags.Instace or Static. Use instance here.
25353 (Property): Refactored code to cope better with the full spec.
25355 * parameter.cs (GetParameterInfo): Return an empty array instead
25358 * class.cs (Property): Abstract or extern properties have no bodies.
25360 * parameter.cs (GetParameterInfo): return a zero-sized array.
25362 * class.cs (TypeContainer.MethodModifiersValid): Move all the
25363 method modifier validation to the typecontainer so we can reuse
25364 this on properties.
25366 (MethodCore.ParameterTypes): return an empty sized array of types.
25368 (Property.Define): Test property modifier validity.
25370 Add tests for sealed/override too.
25372 (Method.Emit): abstract or extern methods have no bodies.
25374 2001-12-14 Ravi Pratap <ravi@ximian.com>
25376 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
25379 (Method::Define, ::Emit): Modify accordingly.
25381 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
25383 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
25385 * makefile: Pass in /unsafe.
25387 2001-12-13 Miguel de Icaza <miguel@ximian.com>
25389 * class.cs (MakeKey): Kill routine.
25391 * class.cs (TypeContainer.Define): Correctly define explicit
25392 method implementations (they require the full interface name plus
25395 * typemanager.cs: Deply the PtrHashtable here and stop using the
25396 lame keys. Things work so much better.
25398 This of course broke everyone who depended on `RegisterMethod' to
25399 do the `test for existance' test. This has to be done elsewhere.
25401 * support.cs (PtrHashtable): A hashtable that avoid comparing with
25402 the object stupid Equals method (because, that like fails all over
25403 the place). We still do not use it.
25405 * class.cs (TypeContainer.SetRequiredInterface,
25406 TypeContainer.RequireMethods): Killed these two routines and moved
25407 all the functionality to RegisterRequiredImplementations.
25409 (TypeContainer.RegisterRequiredImplementations): This routine now
25410 registers all the implementations required in an array for the
25411 interfaces and abstract methods. We use an array of structures
25412 which can be computed ahead of time to reduce memory usage and we
25413 also assume that lookups are cheap as most classes will not
25414 implement too many interfaces.
25416 We also avoid creating too many MethodSignatures.
25418 (TypeContainer.IsInterfaceMethod): Update and optionally does not
25419 clear the "pending" bit if we find that there are problems with
25422 (TypeContainer.VerifyPendingMethods): Update to report errors of
25423 methods that look like implementations but are not.
25425 (TypeContainer.Define): Add support for explicit interface method
25428 2001-12-12 Miguel de Icaza <miguel@ximian.com>
25430 * typemanager.cs: Keep track of the parameters here instead of
25431 being a feature of the TypeContainer.
25433 * class.cs: Drop the registration of parameters here, as
25434 InterfaceMethods are also interface declarations.
25436 * delegate.cs: Register methods with the TypeManager not only with
25437 the TypeContainer. This code was buggy.
25439 * interface.cs: Full registation here.
25441 2001-12-11 Miguel de Icaza <miguel@ximian.com>
25443 * expression.cs: Remove reducer for binary expressions, it can not
25446 * const.cs: Put here the code that used to go into constant.cs
25448 * constant.cs: Put here the code for constants, this is a new base
25449 class for Literals.
25451 * literal.cs: Make Literal derive from Constant.
25453 2001-12-09 Miguel de Icaza <miguel@ximian.com>
25455 * statement.cs (Return.Emit): Report error 157 if the user
25456 attempts to return from a finally block.
25458 (Return.Emit): Instead of emitting a return, jump to the end of
25461 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
25462 LocalBuilder to store the result of the function. ReturnLabel is
25463 the target where we jump.
25466 2001-12-09 Radek Doulik <rodo@ximian.com>
25468 * cs-parser.jay: remember alias in current namespace
25470 * ecore.cs (SimpleName::DoResolve): use aliases for types or
25473 * class.cs (LookupAlias): lookup alias in my_namespace
25475 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
25477 (LookupAlias): lookup alias in this and if needed in parent
25480 2001-12-08 Miguel de Icaza <miguel@ximian.com>
25484 * rootcontext.cs: (ModuleBuilder) Made static, first step into
25485 making things static. I need this to avoid passing the
25486 TypeContainer when calling ParameterType.
25488 * support.cs (InternalParameters.ParameterType): Remove ugly hack
25489 that did string manipulation to compute the type and then call
25490 GetType. Use Parameter.ParameterType instead.
25492 * cs-tokenizer.cs: Consume the suffix for floating values.
25494 * expression.cs (ParameterReference): figure out whether this is a
25495 reference parameter or not. Kill an extra variable by computing
25496 the arg_idx during emission.
25498 * parameter.cs (Parameters.GetParameterInfo): New overloaded
25499 function that returns whether a parameter is an out/ref value or not.
25501 (Parameter.ParameterType): The type of the parameter (base,
25502 without ref/out applied).
25504 (Parameter.Resolve): Perform resolution here.
25505 (Parameter.ExternalType): The full type (with ref/out applied).
25507 * statement.cs (Using.Emit, Using.EmitExpression): Implement
25508 support for expressions on the using statement.
25510 2001-12-07 Miguel de Icaza <miguel@ximian.com>
25512 * statement.cs (Using.EmitLocalVariableDecls): Split the
25513 localvariable handling of the using statement.
25515 (Block.EmitMeta): Keep track of variable count across blocks. We
25516 were reusing slots on separate branches of blocks.
25518 (Try.Emit): Emit the general code block, we were not emitting it.
25520 Check the type of the declaration to be an IDisposable or
25521 something that can be implicity converted to it.
25523 Emit conversions if required.
25525 * ecore.cs (EmptyExpression): New utility class.
25526 (Expression.ImplicitConversionExists): New utility function.
25528 2001-12-06 Miguel de Icaza <miguel@ximian.com>
25530 * statement.cs (Using): Implement.
25532 * expression.cs (LocalVariableReference): Support read only variables.
25534 * statement.cs: Remove the explicit emit for the Leave opcode.
25535 (VariableInfo): Add a readonly field.
25537 2001-12-05 Miguel de Icaza <miguel@ximian.com>
25539 * ecore.cs (ConvCast): new class used to encapsulate the various
25540 explicit integer conversions that works in both checked and
25541 unchecked contexts.
25543 (Expression.ConvertNumericExplicit): Use new ConvCast class to
25544 properly generate the overflow opcodes.
25546 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25548 * statement.cs: The correct type for the EmptyExpression is the
25549 element_type, not the variable type. Ravi pointed this out.
25551 2001-12-04 Ravi Pratap <ravi@ximian.com>
25553 * class.cs (Method::Define): Handle PInvoke methods specially
25554 by using DefinePInvokeMethod instead of the usual one.
25556 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
25557 above to do the task of extracting information and defining the method.
25559 2001-12-04 Ravi Pratap <ravi@ximian.com>
25561 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
25562 of the condition for string type.
25564 (Emit): Move that here.
25566 (ArrayCreation::CheckIndices): Keep string literals in their expression
25569 (EmitDynamicInitializers): Handle strings appropriately.
25571 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25573 * codegen.cs (EmitContext): Replace multiple variables with a
25574 single pointer to the current Switch statement.
25576 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
25579 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25583 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
25586 (Foreach.Emit): Foreach on arrays was not setting
25587 up the loop variables (for break/continue).
25589 (GotoCase): Semi-implented.
25591 2001-12-03 Ravi Pratap <ravi@ximian.com>
25593 * attribute.cs (CheckAttribute): Handle system attributes by using
25594 Attribute.GetAttributes to examine information we need.
25596 (GetValidPlaces): Same here.
25598 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
25600 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
25602 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
25604 (Method::Define): Set appropriate flags if we have a DllImport attribute.
25606 (Method::Emit): Handle the case when we are a PInvoke method.
25608 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25610 * expression.cs: Use ResolveWithSimpleName on compound names.
25612 2001-12-02 Ravi Pratap <ravi@ximian.com>
25614 * constant.cs (EmitConstant): Make sure we resolve the associated expression
25615 before trying to reduce it.
25617 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
25619 * constant.cs (LookupConstantValue): Implement.
25621 (EmitConstant): Use the above in emitting the constant.
25623 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
25624 that are user-defined by doing a LookupConstantValue on them.
25626 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
25629 2001-11-29 Miguel de Icaza <miguel@ximian.com>
25631 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
25633 (BaseAccess.DoResolve): Implement.
25635 (MemberAccess.DoResolve): Split this routine into a
25636 ResolveMemberAccess routine that can be used independently
25638 2001-11-28 Miguel de Icaza <miguel@ximian.com>
25640 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
25641 As that share bits of the implementation. Is returns a boolean,
25642 while As returns the Type that is being probed.
25644 2001-12-01 Ravi Pratap <ravi@ximian.com>
25646 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
25647 instead of a Literal - much easier.
25649 (EnumInTransit): Remove - utterly useless :-)
25651 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
25653 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
25655 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
25656 chain when we have no associated expression.
25658 2001-11-30 Ravi Pratap <ravi@ximian.com>
25660 * constant.cs (Define): Use Location while reporting the errror.
25662 Also emit a warning when 'new' is used and there is no inherited
25665 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
25668 (LookupEnumValue): Implement to lookup an enum member's value and define it
25671 (Populate): Re-write accordingly to use the above routine.
25673 2001-11-27 Miguel de Icaza <miguel@ximian.com>
25675 * expression.cs (This): Fix prototype for DoResolveLValue to
25676 override the base class DoResolveLValue.
25678 * cs-parser.cs: Report errors cs574 and cs575 (destructor
25681 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
25682 (we need to load the address of the field here). This fixes
25685 (FieldExpr.DoResolveLValue): Call the DoResolve
25686 function to initialize the Instance expression.
25688 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
25689 correctly the GetEnumerator operation on a value type.
25691 * cs-parser.jay: Add more simple parsing error catches.
25693 * statement.cs (Switch): Add support for string switches.
25694 Handle null specially.
25696 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
25698 2001-11-28 Ravi Pratap <ravi@ximian.com>
25700 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
25702 (declare_local_constant): New helper function.
25704 * statement.cs (AddConstant): Keep a separate record of constants
25706 (IsConstant): Implement to determine if a variable is a constant.
25708 (GetConstantExpression): Implement.
25710 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
25712 * statement.cs (IsVariableDefined): Re-write.
25714 2001-11-27 Ravi Pratap <ravi@ximian.com>
25716 * class.cs (TypeContainer::FindMembers): Look for constants
25717 in the case when we are looking for MemberTypes.Field
25719 * expression.cs (MemberAccess::DoResolve): Check that in the
25720 case we are a FieldExpr and a Literal, we are not being accessed
25721 by an instance reference.
25723 * cs-parser.jay (local_constant_declaration): Implement.
25725 (declaration_statement): Implement for constant declarations.
25727 2001-11-26 Miguel de Icaza <miguel@ximian.com>
25729 * statement.cs (Switch): Catch double defaults.
25731 (Switch): More work on the switch() statement
25732 implementation. It works for integral values now, need to finish
25736 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25738 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
25739 integer literals into other integer literals. To be used by
25742 2001-11-24 Ravi Pratap <ravi@ximian.com>
25744 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
25747 (EmitDynamicInitializers): Cope with the above since we extract data
25748 directly from ArrayData now.
25750 (ExpectInitializers): Keep track of whether initializers are mandatory
25753 (Bounds): Make it a hashtable to prevent the same dimension being
25754 recorded for every element in that dimension.
25756 (EmitDynamicInitializers): Fix bug which prevented the Set array method
25759 Also fix bug which was causing the indices to be emitted in the reverse
25762 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25764 * expression.cs (ArrayCreation): Implement the bits that Ravi left
25765 unfinished. They do not work, because the underlying code is
25768 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25770 * cs-parser.jay: Remove bogus fixme.
25772 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
25773 on Switch statement.
25775 2001-11-23 Ravi Pratap <ravi@ximian.com>
25777 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
25780 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
25781 parameter. Apparently, any expression is allowed.
25783 (ValidateInitializers): Update accordingly.
25785 (CheckIndices): Fix some tricky bugs thanks to recursion.
25787 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
25788 I was being completely brain-dead.
25790 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
25791 and re-write acordingly.
25793 (DelegateInvocation): Re-write accordingly.
25795 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
25797 (MakeByteBlob): Handle types more correctly.
25799 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
25800 initialization from expressions but it is incomplete because I am a complete
25803 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25805 * statement.cs (If.Emit): Fix a bug that generated incorrect code
25806 on If. Basically, we have to return `true' (ie, we do return to
25807 our caller) only if both branches of the if return.
25809 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
25810 short-circuit operators, handle them as short circuit operators.
25812 (Cast.DoResolve): Resolve type.
25813 (Cast.Cast): Take an expression as the target type.
25815 * cs-parser.jay (cast_expression): Remove old hack that only
25816 allowed a limited set of types to be handled. Now we take a
25817 unary_expression and we resolve to a type during semantic
25820 Use the grammar productions from Rhys to handle casts (this is
25821 not complete like Rhys syntax yet, we fail to handle that corner
25822 case that C# has regarding (-x), but we will get there.
25824 2001-11-22 Ravi Pratap <ravi@ximian.com>
25826 * class.cs (EmitFieldInitializer): Take care of the case when we have a
25827 field which is an array type.
25829 * cs-parser.jay (declare_local_variables): Support array initialization too.
25831 * typemanager.cs (MakeKey): Implement.
25833 (everywhere): Use the above appropriately.
25835 * cs-parser.jay (for_statement): Update for array initialization while
25836 declaring variables.
25838 * ecore.cs : The error message was correct, it's the variable's names that
25839 were misleading ;-) Make the code more readable.
25841 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
25842 the correct type etc.
25844 (ConvertExplicit): Handle Enum types by examining the underlying type.
25846 2001-11-21 Ravi Pratap <ravi@ximian.com>
25848 * parameter.cs (GetCallingConvention): Always return
25849 CallingConventions.Standard for now.
25851 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25853 * expression.cs (Binary.ResolveOperator): Update the values of `l'
25854 and `r' after calling DoNumericPromotions.
25856 * ecore.cs: Fix error message (the types were in the wrong order).
25858 * statement.cs (Foreach.ProbeCollectionType): Need to pass
25859 BindingFlags.Instance as well
25861 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
25862 implicit int literal conversion in an empty cast so that we
25863 propagate the right type upstream.
25865 (UnboxCast): new class used to unbox value types.
25866 (Expression.ConvertExplicit): Add explicit type conversions done
25869 (Expression.ImplicitNumericConversion): Oops, forgot to test for
25870 the target type before applying the implicit LongLiterals to ULong
25873 2001-11-21 Miguel de Icaza <miguel@ximian.com>
25875 * cs-parser.jay (for_statement): Reworked the way For works: now
25876 we declare manually any variables that are introduced in
25877 for_initializer to solve the problem of having out-of-band code
25878 emition (that is what got for broken).
25880 (declaration_statement): Perform the actual variable declaration
25881 that used to be done in local_variable_declaration here.
25883 (local_variable_declaration): Do not declare anything, just pass
25884 the information on a DictionaryEntry
25886 2001-11-20 Ravi Pratap <ravi@ximian.com>
25888 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
25889 re-write of the logic to now make it recursive.
25891 (UpdateIndices): Re-write accordingly.
25893 Store element data in a separate ArrayData list in the above methods.
25895 (MakeByteBlob): Implement to dump the array data into a byte array.
25897 2001-11-19 Ravi Pratap <ravi@ximian.com>
25899 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
25902 * constant.cs (Define): Implement.
25904 (EmitConstant): Re-write fully.
25906 Pass in location info.
25908 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
25911 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
25912 DictionaryEntry since we need location info too.
25914 (constant_declaration): Update accordingly.
25916 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
25917 code into another method : UpdateIndices.
25919 2001-11-18 Ravi Pratap <ravi@ximian.com>
25921 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
25922 some type checking etc.
25924 2001-11-17 Ravi Pratap <ravi@ximian.com>
25926 * expression.cs (ArrayCreation::ValidateInitializers): Implement
25927 bits to provide dimension info if the user skips doing that.
25929 Update second constructor to store the rank correctly.
25931 2001-11-16 Ravi Pratap <ravi@ximian.com>
25933 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
25934 and try to implement.
25936 * ../errors/cs0150.cs : Add.
25938 * ../errors/cs0178.cs : Add.
25940 2001-11-16 Miguel de Icaza <miguel@ximian.com>
25942 * statement.cs: Implement foreach on multi-dimensional arrays.
25944 * parameter.cs (Parameters.GetParameterByName): Also lookup the
25945 name of the params argument.
25947 * expression.cs: Use EmitStoreOpcode to get the right opcode while
25948 initializing the array.
25950 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
25951 we can use this elsewhere.
25953 * statement.cs: Finish implementation of foreach for single
25956 * cs-parser.jay: Use an out-of-band stack to pass information
25957 around, I wonder why I need this.
25959 foreach_block: Make the new foreach_block the current_block.
25961 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
25962 function used to return a static Parameters structure. Used for
25963 empty parameters, as those are created very frequently.
25965 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
25967 2001-11-15 Ravi Pratap <ravi@ximian.com>
25969 * interface.cs : Default modifier is private, not public. The
25970 make verify test passes again.
25972 2001-11-15 Ravi Pratap <ravi@ximian.com>
25974 * support.cs (ReflectionParameters): Fix logic to determine
25975 whether the last parameter is a params one. Test 9 passes again.
25977 * delegate.cs (Populate): Register the builders we define with
25978 RegisterParameterForBuilder. Test 19 passes again.
25980 * cs-parser.jay (property_declaration): Reference $6 instead
25981 of $$ to get at the location.
25983 (indexer_declaration): Similar stuff.
25985 (attribute): Ditto.
25987 * class.cs (Property): Register parameters for the Get and Set methods
25988 if they exist. Test 23 passes again.
25990 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
25991 call to EmitArguments as we are sure there aren't any params arguments.
25992 Test 32 passes again.
25994 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
25995 IndexOutOfRangeException.
25997 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
25998 Test 33 now passes again.
26000 2001-11-15 Miguel de Icaza <miguel@ximian.com>
26002 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
26003 broke a bunch of things. Will have to come up with a better way
26004 of tracking locations.
26006 * statement.cs: Implemented foreach for single dimension arrays.
26008 2001-11-09 Miguel de Icaza <miguel@ximian.com>
26010 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
26011 an error. This removes the lookup from the critical path.
26013 * cs-parser.jay: Removed use of temporary_loc, which is completely
26016 2001-11-14 Miguel de Icaza <miguel@ximian.com>
26018 * support.cs (ReflectionParameters.ParameterModifier): Report
26019 whether the argument is a PARAMS argument or not.
26021 * class.cs: Set the attribute `ParamArrayAttribute' on the
26022 parameter argument.
26024 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
26025 and cons_param_array_attribute (ConstructorInfo for
26026 ParamArrayAttribute).,
26028 * codegen.cs: Emit the return using the `Return' statement, that
26029 way we can report the error correctly for missing return values.
26031 * class.cs (Method.Emit): Clean up.
26033 * expression.cs (Argument.Resolve): Take another argument: the
26034 location where this argument is used. Notice that this is not
26035 part of the "Argument" class as to reduce the size of the
26036 structure (we know the approximate location anyways).
26038 Test if the argument is a variable-reference, if not, then
26039 complain with a 206.
26041 (Argument.Emit): Emit addresses of variables.
26043 (Argument.FullDesc): Simplify.
26045 (Invocation.DoResolve): Update for Argument.Resolve.
26047 (ElementAccess.DoResolve): ditto.
26049 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
26050 method should be virtual, as this method is always virtual.
26052 (NewDelegate.DoResolve): Update for Argument.Resolve.
26054 * class.cs (ConstructorInitializer.DoResolve): ditto.
26056 * attribute.cs (Attribute.Resolve): ditto.
26058 2001-11-13 Miguel de Icaza <miguel@ximian.com>
26060 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
26062 * expression.cs (ParameterReference): Drop IStackStorage and implement
26063 IAssignMethod instead.
26065 (LocalVariableReference): ditto.
26067 * ecore.cs (FieldExpr): Drop IStackStorage and implement
26068 IAssignMethod instead.
26070 2001-11-13 Miguel de Icaza <miguel@ximian.com>
26072 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
26073 enumerations that are used in heavily used structures derive from
26074 byte in a laughable and pathetic attempt to reduce memory usage.
26075 This is the kind of pre-optimzations that you should not do at
26076 home without adult supervision.
26078 * expression.cs (UnaryMutator): New class, used to handle ++ and
26079 -- separatedly from the other unary operators. Cleans up the
26080 code, and kills the ExpressionStatement dependency in Unary.
26082 (Unary): Removed `method' and `Arguments' from this class, making
26083 it smaller, and moving it all to SimpleCall, so I can reuse this
26084 code in other locations and avoid creating a lot of transient data
26085 strucutres when not required.
26087 * cs-parser.jay: Adjust for new changes.
26089 2001-11-11 Miguel de Icaza <miguel@ximian.com>
26091 * enum.cs (Enum.Populate): If there is a failure during
26094 * cs-parser.jay (opt_enum_base): we used to catch type errors
26095 here, but this is really incorrect. The type error should be
26096 catched during semantic analysis.
26098 2001-12-11 Ravi Pratap <ravi@ximian.com>
26100 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
26101 current_local_parameters as expected since I, in my stupidity, had forgotten
26104 * attribute.cs (GetValidPlaces): Fix stupid bug.
26106 * class.cs (Method::Emit): Perform check on applicability of attributes.
26108 (Constructor::Emit): Ditto.
26110 (Field::Emit): Ditto.
26112 (Field.Location): Store location information.
26114 (Property, Event, Indexer, Operator): Ditto.
26116 * cs-parser.jay (field_declaration): Pass in location for each field.
26118 * ../errors/cs0592.cs : Add.
26120 2001-11-12 Ravi Pratap <ravi@ximian.com>
26122 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
26124 (InitCoreTypes): Update accordingly.
26126 (RegisterAttrType, LookupAttr): Implement.
26128 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
26129 info about the same.
26131 (Resolve): Update to populate the above as necessary.
26133 (Error592): Helper.
26135 (GetValidPlaces): Helper to the above.
26137 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
26139 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
26141 2001-11-12 Ravi Pratap <ravi@ximian.com>
26143 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
26145 * ../errors/cs0617.cs : Add.
26147 2001-11-11 Ravi Pratap <ravi@ximian.com>
26149 * enum.cs (Emit): Rename to Populate to be more consistent with what
26150 we expect it to do and when exactly it is called.
26152 * class.cs, rootcontext.cs : Update accordingly.
26154 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
26155 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
26157 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
26159 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
26160 of a fieldinfo using the above, when dealing with a FieldBuilder.
26162 2001-11-10 Ravi Pratap <ravi@ximian.com>
26164 * ../errors/cs0031.cs : Add.
26166 * ../errors/cs1008.cs : Add.
26168 * ../errrors/cs0543.cs : Add.
26170 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
26173 (FindMembers): Implement.
26175 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
26176 enums and delegates too.
26178 (enum_types): Rename to builder_to_enum.
26180 (delegate_types): Rename to builder_to_delegate.
26182 * delegate.cs (FindMembers): Implement.
26184 2001-11-09 Ravi Pratap <ravi@ximian.com>
26186 * typemanager.cs (IsEnumType): Implement.
26188 * enum.cs (Emit): Re-write parts to account for the underlying type
26189 better and perform checking etc.
26191 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
26192 of the underlying type.
26194 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
26197 * enum.cs (error31): Helper to report error #31.
26199 * cs-parser.jay (enum_declaration): Store location of each member too.
26201 * enum.cs (member_to_location): New hashtable.
26203 (AddEnumMember): Update location hashtable.
26205 (Emit): Use the location of each member while reporting errors.
26207 2001-11-09 Miguel de Icaza <miguel@ximian.com>
26209 * cs-parser.jay: A for_initializer if is a
26210 local_variable_declaration really ammount to have an implicit
26211 block with the variable declaration and no initializer for for.
26213 * statement.cs (For.Emit): Cope with null initializers.
26215 This fixes the infinite loop on for initializers.
26217 2001-11-08 Miguel de Icaza <miguel@ximian.com>
26219 * enum.cs: More cleanup.
26221 * ecore.cs: Remove dead code.
26223 * class.cs (Property.Emit): More simplification.
26224 (Event.Emit): ditto.
26226 Reworked to have less levels of indentation.
26228 2001-11-08 Ravi Pratap <ravi@ximian.com>
26230 * class.cs (Property): Emit attributes.
26240 * enum.cs (Emit): Ditto.
26242 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
26245 * class.cs (Field, Event, etc.): Move attribute generation into the
26246 Emit method everywhere.
26248 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
26249 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
26250 as we had no way of defining nested enums !
26252 * rootcontext.cs : Adjust code accordingly.
26254 * typemanager.cs (AddEnumType): To keep track of enum types separately.
26256 2001-11-07 Ravi Pratap <ravi@ximian.com>
26258 * expression.cs (EvalConstantExpression): Move into ecore.cs
26260 * enum.cs (Enum): Rename some members and make them public and readonly
26261 according to our convention.
26263 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
26266 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
26268 (Enum::Emit): Write a simple version for now which doesn't try to compute
26269 expressions. I shall modify this to be more robust in just a while.
26271 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
26273 (TypeContainer::CloseType): Create the Enum types too.
26275 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
26277 * expression.cs (EvalConstantExpression): Get rid of completely.
26279 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
26280 user-defined values and other cases.
26282 (IsValidEnumLiteral): Helper function.
26284 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
26285 out there in the case we had a literal FieldExpr.
26287 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
26289 (Literalize): Revamp a bit to take two arguments.
26291 (EnumLiteral): New class which derives from Literal to wrap enum literals.
26293 2001-11-06 Ravi Pratap <ravi@ximian.com>
26295 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
26297 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
26299 (Resolve): Use the above to ensure we have proper initializers.
26301 2001-11-05 Ravi Pratap <ravi@ximian.com>
26303 * expression.cs (Expression::EvalConstantExpression): New method to
26304 evaluate constant expressions.
26306 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
26308 2001-11-07 Miguel de Icaza <miguel@ximian.com>
26310 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
26313 (Binary.ResolveOperator): Handle operator != (object a, object b)
26314 and operator == (object a, object b);
26316 (Binary.DoNumericPromotions): Indicate whether the numeric
26317 promotion was possible.
26319 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
26322 Made the ArrayAccess implement interface IAssignMethod instead of
26323 IStackStore as the order in which arguments are passed reflects
26326 * assign.cs: Instead of using expr.ExprClass to select the way of
26327 assinging, probe for the IStackStore/IAssignMethod interfaces.
26329 * typemanager.cs: Load InitializeArray definition.
26331 * rootcontext.cs (RootContext.MakeStaticData): Used to define
26332 static data that can be used to initialize arrays.
26334 2001-11-05 Miguel de Icaza <miguel@ximian.com>
26336 * expression.cs: Handle operator== and operator!= for booleans.
26338 (Conditioal.Reduce): Implement reducer for the ?: operator.
26340 (Conditional.Resolve): Implement dead code elimination.
26342 (Binary.Resolve): Catch string literals and return a new
26343 concatenated string.
26345 (Unary.Reduce): Implement reduction of unary expressions.
26347 * ecore.cs: Split out the expression core handling here.
26349 (Expression.Reduce): New method used to perform constant folding
26350 and CSE. This is needed to support constant-expressions.
26352 * statement.cs (Statement.EmitBoolExpression): Pass true and false
26353 targets, and optimize for !x.
26355 2001-11-04 Ravi Pratap <ravi@ximian.com>
26357 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
26358 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
26359 set custom atttributes.
26361 * literal.cs (Literal::GetValue): New abstract method to return the actual
26362 value of the literal, cast as an object.
26364 (*Literal): Implement GetValue method.
26366 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
26367 expressions to the arraylist but objects of type Argument.
26369 * class.cs (TypeContainer::Emit): Emit our attributes too.
26371 (Method::Emit, Constructor::Emit): Ditto.
26373 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
26374 to be ignoring earlier.
26376 2001-11-03 Ravi Pratap <ravi@ximian.com>
26378 * attribute.cs (AttributeSection::Define): Implement to do the business
26379 of constructing a CustomAttributeBuilder.
26381 (Attribute): New trivial class. Increases readability of code.
26383 * cs-parser.jay : Update accordingly.
26385 (positional_argument_list, named_argument_list, named_argument): New rules
26387 (attribute_arguments): Use the above so that we are more correct.
26389 2001-11-02 Ravi Pratap <ravi@ximian.com>
26391 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
26392 to perform all checks for a method with a params parameter.
26394 (Invocation::OverloadResolve): Update to use the above method and therefore
26395 cope correctly with params method invocations.
26397 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
26400 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
26401 constructors in our parent too because we can't afford to miss out on
26404 * attribute.cs (AttributeSection): New name for the class Attribute
26406 Other trivial changes to improve readability.
26408 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
26409 use the new class names.
26411 2001-11-01 Ravi Pratap <ravi@ximian.com>
26413 * class.cs (Method::Define): Complete definition for params types too
26415 (Indexer::Define): Ditto.
26417 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
26418 Cope everywhere with a request for info about the array parameter.
26420 2001-11-01 Ravi Pratap <ravi@ximian.com>
26422 * tree.cs (RecordNamespace): Fix up to check for the correct key.
26424 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
26425 local_variable_type to extract the string corresponding to the type.
26427 (local_variable_type): Fixup the action to use the new helper method.
26429 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
26432 * expression.cs : Clean out code which uses the above.
26434 2001-10-31 Ravi Pratap <ravi@ximian.com>
26436 * typemanager.cs (RegisterMethod): Check if we already have an existing key
26437 and bale out if necessary by returning a false.
26439 (RegisterProperty): Ditto.
26441 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
26442 and print out appropriate error messages.
26444 * interface.cs (everywhere): Ditto.
26446 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
26447 location to constructor.
26449 * class.cs (Property, Event, Indexer): Update accordingly.
26451 * ../errors/cs111.cs : Added.
26453 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
26454 of a method, as laid down by the spec.
26456 (Invocation::OverloadResolve): Use the above method.
26458 2001-10-31 Ravi Pratap <ravi@ximian.com>
26460 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
26461 now take a TypeContainer and a Parameters object.
26463 (ParameterData): Modify return type of ParameterModifier method to be
26464 Parameter.Modifier and not a string.
26466 (ReflectionParameters, InternalParameters): Update accordingly.
26468 * expression.cs (Argument::GetParameterModifier): Same here.
26470 * support.cs (InternalParameters::ParameterType): Find a better way of determining
26471 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
26472 symbol in it at all so maybe this is only for now.
26474 2001-10-30 Ravi Pratap <ravi@ximian.com>
26476 * support.cs (InternalParameters): Constructor now takes an extra argument
26477 which is the actual Parameters class.
26479 (ParameterDesc): Update to provide info on ref/out modifiers.
26481 * class.cs (everywhere): Update call to InternalParameters to pass in
26482 the second argument too.
26484 * support.cs (ParameterData): Add ParameterModifier, which is a method
26485 to return the modifier info [ref/out etc]
26487 (InternalParameters, ReflectionParameters): Implement the above.
26489 * expression.cs (Argument::ParameterModifier): Similar function to return
26490 info about the argument's modifiers.
26492 (Invocation::OverloadResolve): Update to take into account matching modifiers
26495 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
26496 a new SetFormalParameters object which we pass to InternalParameters.
26498 2001-10-30 Ravi Pratap <ravi@ximian.com>
26500 * expression.cs (NewArray): Merge into the ArrayCreation class.
26502 2001-10-29 Ravi Pratap <ravi@ximian.com>
26504 * expression.cs (NewArray): Merge classes NewBuiltinArray and
26505 NewUserdefinedArray into one as there wasn't much of a use in having
26508 * expression.cs (Argument): Change field's name to ArgType from Type.
26510 (Type): New readonly property which returns the proper type, taking into
26511 account ref/out modifiers.
26513 (everywhere): Adjust code accordingly for the above.
26515 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
26516 whether we are emitting for a ref or out parameter.
26518 * expression.cs (Argument::Emit): Use the above field to set the state.
26520 (LocalVariableReference::Emit): Update to honour the flag and emit the
26523 * parameter.cs (Attributes): Set the correct flags for ref parameters.
26525 * expression.cs (Argument::FullDesc): New function to provide a full desc.
26527 * support.cs (ParameterData): Add method ParameterDesc to the interface.
26529 (ReflectionParameters, InternalParameters): Implement the above method.
26531 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
26534 (Invocation::FullMethodDesc): Ditto.
26536 2001-10-29 Miguel de Icaza <miguel@ximian.com>
26538 * cs-parser.jay: Add extra production for the second form of array
26541 * expression.cs (ArrayCreation): Update to reflect the above
26544 * Small changes to prepare for Array initialization.
26546 2001-10-28 Miguel de Icaza <miguel@ximian.com>
26548 * typemanager.cs (ImplementsInterface): interface might be null;
26549 Deal with this problem;
26551 Also, we do store negative hits on the cache (null values), so use
26552 this instead of calling t.GetInterfaces on the type everytime.
26554 2001-10-28 Ravi Pratap <ravi@ximian.com>
26556 * typemanager.cs (IsBuiltinType): New method to help determine the same.
26558 * expression.cs (New::DoResolve): Get rid of array creation code and instead
26559 split functionality out into different classes.
26561 (New::FormArrayType): Move into NewBuiltinArray.
26563 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
26566 (NewBuiltinArray): New class to handle creation of built-in arrays.
26568 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
26569 account creation of one-dimensional arrays.
26571 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
26573 (NewUserdefinedArray::DoResolve): Implement.
26575 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
26577 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
26578 we maintain inside the TypeManager. This is necessary to perform lookups on the
26581 (LookupType): Update to perform GetType on the module builders too.
26583 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
26585 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
26587 2001-10-23 Ravi Pratap <ravi@ximian.com>
26589 * expression.cs (New::DoResolve): Implement guts of array creation.
26591 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
26593 2001-10-27 Miguel de Icaza <miguel@ximian.com>
26595 * expression.cs: Fix bug I introduced lsat night that broke
26598 (Expression.Resolve): Report a 246 error (can not resolve name)
26599 if we find a SimpleName in the stream.
26601 (Expression.ResolveLValue): Ditto.
26603 (Expression.ResolveWithSimpleName): This function is a variant of
26604 ResolveName, this one allows SimpleNames to be returned without a
26605 warning. The only consumer of SimpleNames is MemberAccess
26607 2001-10-26 Miguel de Icaza <miguel@ximian.com>
26609 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
26610 might arrive here. I have my doubts that this is correct.
26612 * statement.cs (Lock): Implement lock statement.
26614 * cs-parser.jay: Small fixes to support `lock' and `using'
26616 * cs-tokenizer.cs: Remove extra space
26618 * driver.cs: New flag --checked, allows to turn on integer math
26621 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
26622 Threading.Monitor.Exit
26624 2001-10-23 Miguel de Icaza <miguel@ximian.com>
26626 * expression.cs (IndexerAccess::DoResolveLValue): Set the
26627 Expression Class to be IndexerAccess.
26629 Notice that Indexer::DoResolve sets the eclass to Value.
26631 2001-10-22 Miguel de Icaza <miguel@ximian.com>
26633 * class.cs (TypeContainer::Emit): Emit code for indexers.
26635 * assign.cs (IAssignMethod): New interface implemented by Indexers
26636 and Properties for handling assignment.
26638 (Assign::Emit): Simplify and reuse code.
26640 * expression.cs (IndexerAccess, PropertyExpr): Implement
26641 IAssignMethod, clean up old code.
26643 2001-10-22 Ravi Pratap <ravi@ximian.com>
26645 * typemanager.cs (ImplementsInterface): New method to determine if a type
26646 implements a given interface. Provides a nice cache too.
26648 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
26651 (ConvertReferenceExplicit): Ditto.
26653 * delegate.cs (Delegate::Populate): Update to define the parameters on the
26654 various methods, with correct names etc.
26656 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
26657 Operator.UnaryNegation.
26659 * cs-parser.jay (operator_declarator): Be a little clever in the case where
26660 we have a unary plus or minus operator.
26662 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
26665 * everywhere : update accordingly.
26667 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
26670 * class.cs (Method::Define): For the case where we are implementing a method
26671 inherited from an interface, we need to set the MethodAttributes.Final flag too.
26672 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
26674 2001-10-21 Ravi Pratap <ravi@ximian.com>
26676 * interface.cs (FindMembers): Implement to work around S.R.E
26679 * typemanager.cs (IsInterfaceType): Implement.
26681 (FindMembers): Update to handle interface types too.
26683 * expression.cs (ImplicitReferenceConversion): Re-write bits which
26684 use IsAssignableFrom as that is not correct - it doesn't work.
26686 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
26687 and accordingly override EmitStatement.
26689 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
26690 using the correct logic :-)
26692 2001-10-19 Ravi Pratap <ravi@ximian.com>
26694 * ../errors/cs-11.cs : Add to demonstrate error -11
26696 2001-10-17 Miguel de Icaza <miguel@ximian.com>
26698 * assign.cs (Assign::Resolve): Resolve right hand side first, and
26699 then pass this as a hint to ResolveLValue.
26701 * expression.cs (FieldExpr): Add Location information
26703 (FieldExpr::LValueResolve): Report assignment to readonly
26706 (Expression::ExprClassFromMemberInfo): Pass location information.
26708 (Expression::ResolveLValue): Add new method that resolves an
26711 (Expression::DoResolveLValue): Default invocation calls
26714 (Indexers): New class used to keep track of indexers in a given
26717 (IStackStore): Renamed from LValue, as it did not really describe
26718 what this did. Also ResolveLValue is gone from this interface and
26719 now is part of Expression.
26721 (ElementAccess): Depending on the element access type
26723 * typemanager.cs: Add `indexer_name_type' as a Core type
26724 (System.Runtime.CompilerServices.IndexerNameAttribute)
26726 * statement.cs (Goto): Take a location.
26728 2001-10-18 Ravi Pratap <ravi@ximian.com>
26730 * delegate.cs (Delegate::VerifyDelegate): New method to verify
26731 if two delegates are compatible.
26733 (NewDelegate::DoResolve): Update to take care of the case when
26734 we instantiate a delegate from another delegate.
26736 * typemanager.cs (FindMembers): Don't even try to look up members
26737 of Delegate types for now.
26739 2001-10-18 Ravi Pratap <ravi@ximian.com>
26741 * delegate.cs (NewDelegate): New class to take care of delegate
26744 * expression.cs (New): Split the delegate related code out into
26745 the NewDelegate class.
26747 * delegate.cs (DelegateInvocation): New class to handle delegate
26750 * expression.cs (Invocation): Split out delegate related code into
26751 the DelegateInvocation class.
26753 2001-10-17 Ravi Pratap <ravi@ximian.com>
26755 * expression.cs (New::DoResolve): Implement delegate creation fully
26756 and according to the spec.
26758 (New::DoEmit): Update to handle delegates differently.
26760 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
26761 because of which we were printing out arguments in reverse order !
26763 * delegate.cs (VerifyMethod): Implement to check if the given method
26764 matches the delegate.
26766 (FullDelegateDesc): Implement.
26768 (VerifyApplicability): Implement.
26770 * expression.cs (Invocation::DoResolve): Update to accordingly handle
26771 delegate invocations too.
26773 (Invocation::Emit): Ditto.
26775 * ../errors/cs1593.cs : Added.
26777 * ../errors/cs1594.cs : Added.
26779 * delegate.cs (InstanceExpression, TargetMethod): New properties.
26781 2001-10-16 Ravi Pratap <ravi@ximian.com>
26783 * typemanager.cs (intptr_type): Core type for System.IntPtr
26785 (InitCoreTypes): Update for the same.
26787 (iasyncresult_type, asynccallback_type): Ditto.
26789 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
26792 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
26795 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
26796 the builders for the 4 members of a delegate type :-)
26798 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
26801 * expression.cs (New::DoResolve): Implement guts for delegate creation.
26803 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
26805 2001-10-15 Miguel de Icaza <miguel@ximian.com>
26807 * statement.cs (Break::Emit): Implement.
26808 (Continue::Emit): Implement.
26810 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
26811 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
26812 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
26813 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
26816 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
26817 properties that track the label for the current loop (begin of the
26818 loop and end of the loop).
26820 2001-10-15 Ravi Pratap <ravi@ximian.com>
26822 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
26823 use of emitting anything at all.
26825 * class.cs, rootcontext.cs : Get rid of calls to the same.
26827 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
26829 (Populate): Define the constructor correctly and set the implementation
26832 * typemanager.cs (delegate_types): New hashtable to hold delegates that
26835 (AddDelegateType): Implement.
26837 (IsDelegateType): Implement helper method.
26839 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
26841 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
26842 and accordingly handle it.
26844 * delegate.cs (Populate): Take TypeContainer argument.
26845 Implement bits to define the Invoke method. However, I still haven't figured out
26846 how to take care of the native int bit :-(
26848 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
26849 Qualify the name of the delegate, not its return type !
26851 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
26854 (StandardConversionExists): Checking for array types turns out to be recursive.
26856 (ConvertReferenceExplicit): Implement array conversion.
26858 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
26860 2001-10-12 Ravi Pratap <ravi@ximian.com>
26862 * cs-parser.jay (delegate_declaration): Store the fully qualified
26863 name as it is a type declaration.
26865 * delegate.cs (ReturnType, Name): Rename members to these. Make them
26868 (DefineDelegate): Renamed from Define. Does the same thing essentially,
26869 as TypeContainer::DefineType.
26871 (Populate): Method in which all the definition of the various methods (Invoke)
26874 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
26877 (CloseDelegate): Finally creates the delegate.
26879 * class.cs (TypeContainer::DefineType): Update to define delegates.
26880 (Populate, Emit and CloseType): Do the same thing here too.
26882 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
26883 delegates in all these operations.
26885 2001-10-14 Miguel de Icaza <miguel@ximian.com>
26887 * expression.cs: LocalTemporary: a new expression used to
26888 reference a temporary that has been created.
26890 * assign.cs: Handle PropertyAccess back here, so that we can
26891 provide the proper semantic access to properties.
26893 * expression.cs (Expression::ConvertReferenceExplicit): Implement
26894 a few more explicit conversions.
26896 * modifiers.cs: `NEW' modifier maps to HideBySig.
26898 * expression.cs (PropertyExpr): Make this into an
26899 ExpressionStatement, and support the EmitStatement code path.
26901 Perform get/set error checking, clean up the interface.
26903 * assign.cs: recognize PropertyExprs as targets, and if so, turn
26904 them into toplevel access objects.
26906 2001-10-12 Miguel de Icaza <miguel@ximian.com>
26908 * expression.cs: PropertyExpr::PropertyExpr: use work around the
26911 * typemanager.cs: Keep track here of our PropertyBuilders again to
26912 work around lameness in SRE.
26914 2001-10-11 Miguel de Icaza <miguel@ximian.com>
26916 * expression.cs (LValue::LValueResolve): New method in the
26917 interface, used to perform a second resolution pass for LValues.
26919 (This::DoResolve): Catch the use of this in static methods.
26921 (This::LValueResolve): Implement.
26923 (This::Store): Remove warning, assigning to `this' in structures
26926 (Invocation::Emit): Deal with invocation of
26927 methods on value types. We need to pass the address to structure
26928 methods rather than the object itself. (The equivalent code to
26929 emit "this" for structures leaves the entire structure on the
26930 stack instead of a pointer to it).
26932 (ParameterReference::DoResolve): Compute the real index for the
26933 argument based on whether the method takes or not a `this' pointer
26934 (ie, the method is static).
26936 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
26937 value types returned from functions when we need to invoke a
26938 method on the sturcture.
26941 2001-10-11 Ravi Pratap <ravi@ximian.com>
26943 * class.cs (TypeContainer::DefineType): Method to actually do the business of
26944 defining the type in the Modulebuilder or Typebuilder. This is to take
26945 care of nested types which need to be defined on the TypeBuilder using
26946 DefineNestedMethod.
26948 (TypeContainer::GetClassBases): Implement. Essentially the code from the
26949 methods in RootContext, only ported to be part of TypeContainer.
26951 (TypeContainer::GetInterfaceOrClass): Ditto.
26953 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
26955 * interface.cs (Interface::DefineInterface): New method. Does exactly
26956 what RootContext.CreateInterface did earlier, only it takes care of nested types
26959 (Interface::GetInterfaces): Move from RootContext here and port.
26961 (Interface::GetInterfaceByName): Same here.
26963 * rootcontext.cs (ResolveTree): Re-write.
26965 (PopulateTypes): Re-write.
26967 * class.cs (TypeContainer::Populate): Populate nested types too.
26968 (TypeContainer::Emit): Emit nested members too.
26970 * typemanager.cs (AddUserType): Do not make use of the FullName property,
26971 instead just use the name argument passed in as it is already fully
26974 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
26975 to TypeContainer mapping to see if a type is user-defined.
26977 * class.cs (TypeContainer::CloseType): Implement.
26979 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
26980 the default constructor.
26982 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
26985 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
26987 * interface.cs (CloseType): Create the type here.
26989 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
26992 Remove all the methods which are now in TypeContainer.
26994 2001-10-10 Ravi Pratap <ravi@ximian.com>
26996 * delegate.cs (Define): Re-write bits to define the delegate
26999 2001-10-10 Miguel de Icaza <miguel@ximian.com>
27001 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
27003 * expression.cs (ImplicitReferenceConversion): handle null as well
27004 as a source to convert to any reference type.
27006 * statement.cs (Return): Perform any implicit conversions to
27007 expected return type.
27009 Validate use of return statement.
27011 * codegen.cs (EmitContext): Pass the expected return type here.
27013 * class.cs (Method, Constructor, Property): Pass expected return
27014 type to EmitContext.
27016 2001-10-09 Miguel de Icaza <miguel@ximian.com>
27018 * expression.cs: Make DoResolve take an EmitContext instead of a
27021 Replaced `l' and `location' for `loc', for consistency.
27023 (Error, Warning): Remove unneeded Tc argument.
27025 * assign.cs, literal.cs, constant.cs: Update to new calling
27028 * codegen.cs: EmitContext now contains a flag indicating whether
27029 code is being generated in a static method or not.
27031 * cs-parser.jay: DecomposeQI, new function that replaces the old
27032 QualifiedIdentifier. Now we always decompose the assembled
27033 strings from qualified_identifier productions into a group of
27036 2001-10-08 Miguel de Icaza <miguel@ximian.com>
27038 * rootcontext.cs: Deal with field-less struct types correctly now
27039 by passing the size option to Define Type.
27041 * class.cs: Removed hack that created one static field.
27043 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27045 * statement.cs: Moved most of the code generation here.
27047 2001-10-09 Ravi Pratap <ravi@ximian.com>
27049 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
27052 (ElementAccess): Remove useless bits for now - keep checks as the spec
27055 2001-10-08 Ravi Pratap <ravi@ximian.com>
27057 * expression.cs (ElementAccess::DoResolve): Remove my crap code
27058 and start performing checks according to the spec.
27060 2001-10-07 Ravi Pratap <ravi@ximian.com>
27062 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
27063 rank_specifiers instead.
27065 (rank_specifiers): Change the order in which the rank specifiers are stored
27067 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
27069 * expression.cs (ElementAccess): Implement the LValue interface too.
27071 2001-10-06 Ravi Pratap <ravi@ximian.com>
27073 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
27074 except that user defined conversions are not included.
27076 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
27077 perform the conversion of the return type, if necessary.
27079 (New::DoResolve): Check whether we are creating an array or an object
27080 and accordingly do the needful.
27082 (New::Emit): Same here.
27084 (New::DoResolve): Implement guts of array creation.
27086 (New::FormLookupType): Helper function.
27088 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27090 * codegen.cs: Removed most of the code generation here, and move the
27091 corresponding code generation bits to the statement classes.
27093 Added support for try/catch/finalize and throw.
27095 * cs-parser.jay: Added support for try/catch/finalize.
27097 * class.cs: Catch static methods having the flags override,
27098 virtual or abstract.
27100 * expression.cs (UserCast): This user cast was not really doing
27101 what it was supposed to do. Which is to be born in fully resolved
27102 state. Parts of the resolution were being performed at Emit time!
27106 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27108 * expression.cs: Implicity convert the result from UserCast.
27110 2001-10-05 Ravi Pratap <ravi@ximian.com>
27112 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
27113 prevented it from working correctly.
27115 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
27116 merely ConvertImplicit.
27118 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27120 * typemanager.cs: Make the LookupTypeContainer function static,
27121 and not per-instance.
27123 * class.cs: Make static FindMembers (the one that takes a Type
27126 * codegen.cs: Add EmitForeach here.
27128 * cs-parser.jay: Make foreach a toplevel object instead of the
27129 inline expansion, as we need to perform semantic analysis on it.
27131 2001-10-05 Ravi Pratap <ravi@ximian.com>
27133 * expression.cs (Expression::ImplicitUserConversion): Rename to
27134 UserDefinedConversion.
27136 (Expression::UserDefinedConversion): Take an extra argument specifying
27137 whether we look for explicit user conversions too.
27139 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
27141 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
27143 (ExplicitUserConversion): Make it a call to UserDefinedConversion
27144 with the appropriate arguments.
27146 * cs-parser.jay (cast_expression): Record location too.
27148 * expression.cs (Cast): Record location info.
27150 (Expression::ConvertExplicit): Take location argument.
27152 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
27153 to determine if we are doing explicit conversions.
27155 (UserCast::Emit): Update accordingly.
27157 (Expression::ConvertExplicit): Report an error if everything fails.
27159 * ../errors/cs0030.cs : Add.
27161 2001-10-04 Miguel de Icaza <miguel@ximian.com>
27163 * modifiers.cs: If the ABSTRACT keyword is present, also set the
27164 virtual and newslot bits.
27166 * class.cs (TypeContainer::RegisterRequiredImplementations):
27167 Record methods we need.
27169 (TypeContainer::MakeKey): Helper function to make keys for
27170 MethodBases, since the Methodbase key is useless.
27172 (TypeContainer::Populate): Call RegisterRequiredImplementations
27173 before defining the methods.
27175 Create a mapping for method_builders_to_methods ahead of time
27176 instead of inside a tight loop.
27178 (::RequireMethods): Accept an object as the data to set into the
27179 hashtable so we can report interface vs abstract method mismatch.
27181 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27183 * report.cs: Make all of it static.
27185 * rootcontext.cs: Drop object_type and value_type computations, as
27186 we have those in the TypeManager anyways.
27188 Drop report instance variable too, now it is a global.
27190 * driver.cs: Use try/catch on command line handling.
27192 Add --probe option to debug the error reporting system with a test
27195 * report.cs: Add support for exiting program when a probe
27196 condition is reached.
27198 2001-10-03 Ravi Pratap <ravi@ximian.com>
27200 * expression.cs (Binary::DoNumericPromotions): Fix the case when
27201 we do a forcible conversion regardless of type, to check if
27202 ForceConversion returns a null.
27204 (Binary::error19): Use location to report error.
27206 (Unary::error23): Use location here too.
27208 * ../errors/cs0019.cs : Check in.
27210 * ../errors/cs0023.cs : Check in.
27212 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
27213 case of a non-null MethodInfo object with a length of 0 !
27215 (Binary::ResolveOperator): Flag error if overload resolution fails to find
27216 an applicable member - according to the spec :-)
27217 Also fix logic to find members in base types.
27219 (Unary::ResolveOperator): Same here.
27221 (Unary::report23): Change name to error23 and make first argument a TypeContainer
27222 as I was getting thoroughly confused between this and error19 :-)
27224 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
27225 (::FindMostEncompassedType): Implement.
27226 (::FindMostEncompassingType): Implement.
27227 (::StandardConversionExists): Implement.
27229 (UserImplicitCast): Re-vamp. We now need info about most specific
27230 source and target types so that we can do the necessary conversions.
27232 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
27233 mathematical union with no duplicates.
27235 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27237 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
27238 in order from base classes to child classes, so that we can in
27239 child classes look up in our parent for method names and
27240 attributes (required for handling abstract, virtual, new, override
27241 constructs: we need to instrospect our base class, and if we dont
27242 populate the classes in order, the introspection might be
27243 incorrect. For example, a method could query its parent before
27244 the parent has any methods and would determine that the parent has
27245 no abstract methods (while it could have had them)).
27247 (RootContext::CreateType): Record the order in which we define the
27250 2001-10-02 Miguel de Icaza <miguel@ximian.com>
27252 * class.cs (TypeContainer::Populate): Also method definitions can
27253 fail now, keep track of this.
27255 (TypeContainer::FindMembers): Implement support for
27256 DeclaredOnly/noDeclaredOnly flag.
27258 (Constructor::Emit) Return the ConstructorBuilder.
27260 (Method::Emit) Return the MethodBuilder.
27261 Check for abstract or virtual methods to be public.
27263 * rootcontext.cs (RootContext::CreateType): Register all the
27264 abstract methods required for the class to be complete and the
27265 interface methods that must be implemented.
27267 * cs-parser.jay: Report error 501 (method requires body if it is
27268 not marked abstract or extern).
27270 * expression.cs (TypeOf::Emit): Implement.
27272 * typemanager.cs: runtime_handle_type, new global type.
27274 * class.cs (Property::Emit): Generate code for properties.
27276 2001-10-02 Ravi Pratap <ravi@ximian.com>
27278 * expression.cs (Unary::ResolveOperator): Find operators on base type
27279 too - we now conform exactly to the spec.
27281 (Binary::ResolveOperator): Same here.
27283 * class.cs (Operator::Define): Fix minor quirk in the tests.
27285 * ../errors/cs0215.cs : Added.
27287 * ../errors/cs0556.cs : Added.
27289 * ../errors/cs0555.cs : Added.
27291 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27293 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
27294 single integer which is really efficient
27296 2001-10-01 Ravi Pratap <ravi@ximian.com>
27298 * expression.cs (Expression::ImplicitUserConversion): Use location
27299 even in the case when we are examining True operators.
27301 * class.cs (Operator::Define): Perform extensive checks to conform
27302 with the rules for operator overloading in the spec.
27304 * expression.cs (Expression::ImplicitReferenceConversion): Implement
27305 some of the other conversions mentioned in the spec.
27307 * typemanager.cs (array_type): New static member for the System.Array built-in
27310 (cloneable_interface): For System.ICloneable interface.
27312 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
27313 we start resolving the tree and populating types.
27315 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
27317 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27319 * expression.cs (Expression::ExprClassFromMemberInfo,
27320 Expression::Literalize): Create literal expressions from
27321 FieldInfos which are literals.
27323 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
27324 type casts, because they were wrong. The test suite in tests
27327 (ImplicitNumericConversion): ushort to ulong requires a widening
27330 Int32 constant to long requires widening cast as well.
27332 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
27333 for integers because the type on the stack is not i4.
27335 2001-09-30 Miguel de Icaza <miguel@ximian.com>
27337 * expression.cs (report118): require location argument.
27339 * parameter.cs: Do not dereference potential null value.
27341 * class.cs: Catch methods that lack the `new' keyword when
27342 overriding a name. Report warnings when `new' is used without
27343 anything being there to override.
27345 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
27347 * class.cs: Only add constructor to hashtable if it is non-null
27348 (as now constructors can fail on define).
27350 (TypeManager, Class, Struct): Take location arguments.
27352 Catch field instance initialization in structs as errors.
27354 accepting_filter: a new filter for FindMembers that is static so
27355 that we dont create an instance per invocation.
27357 (Constructor::Define): Catch errors where a struct constructor is
27360 * cs-parser.jay: Pass location information for various new
27363 * delegate.cs (Delegate): take a location argument.
27365 * driver.cs: Do not call EmitCode if there were problesm in the
27366 Definition of the types, as many Builders wont be there.
27368 * decl.cs (Decl::Decl): Require a location argument.
27370 * cs-tokenizer.cs: Handle properly hex constants that can not fit
27371 into integers, and find the most appropiate integer for it.
27373 * literal.cs: Implement ULongLiteral.
27375 * rootcontext.cs: Provide better information about the location of
27376 failure when CreateType fails.
27378 2001-09-29 Miguel de Icaza <miguel@ximian.com>
27380 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
27383 * expression.cs (Binary::CheckShiftArguments): Add missing type
27385 (Binary::ResolveOperator): Add type to the logical and and logical
27386 or, Bitwise And/Or and Exclusive Or code paths, it was missing
27389 (Binary::DoNumericPromotions): In the case where either argument
27390 is ulong (and most signed types combined with ulong cause an
27391 error) perform implicit integer constant conversions as well.
27393 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27395 * expression.cs (UserImplicitCast): Method should always be
27397 (Invocation::BetterConversion): Simplified test for IntLiteral.
27399 (Expression::ImplicitNumericConversion): Split this routine out.
27400 Put the code that performs implicit constant integer conversions
27403 (Expression::Resolve): Become a wrapper around DoResolve so we can
27404 check eclass and type being set after resolve.
27406 (Invocation::Badness): Remove this dead function
27408 (Binary::ResolveOperator): Do not compute the expensive argumnets
27409 unless we have a union for it.
27411 (Probe::Emit): Is needs to do an isinst and then
27412 compare against null.
27414 (::CanConvert): Added Location argument. If the Location argument
27415 is null (Location.Null), then we do not report errors. This is
27416 used by the `probe' mechanism of the Explicit conversion. We do
27417 not want to generate an error for something that the user
27418 explicitly requested to be casted. But the pipeline for an
27419 explicit cast first tests for potential implicit casts.
27421 So for now, if the Location is null, it means `Probe only' to
27422 avoid adding another argument. Might have to revise this
27425 (ClassCast): New class used to type cast objects into arbitrary
27426 classes (used in Explicit Reference Conversions).
27428 Implement `as' as well.
27430 Reverted all the patches from Ravi below: they were broken:
27432 * The use of `level' as a mechanism to stop recursive
27433 invocations is wrong. That was there just to catch the
27434 bug with a strack trace but not as a way of addressing
27437 To fix the problem we have to *understand* what is going
27438 on and the interactions and come up with a plan, not
27439 just get things going.
27441 * The use of the type conversion cache that I proposed
27442 last night had an open topic: How does this work across
27443 protection domains. A user defined conversion might not
27444 be public in the location where we are applying the
27445 conversion, a different conversion might be selected
27446 (ie, private A->B (better) but public B->A (worse),
27447 inside A, A->B applies, but outside it, B->A will
27450 * On top of that (ie, even if the above is solved),
27451 conversions in a cache need to be abstract. Ie, `To
27452 convert from an Int to a Short use an OpcodeCast', not
27453 `To convert from an Int to a Short use the OpcodeCast on
27454 the variable 5' (which is what this patch was doing).
27456 2001-09-28 Ravi Pratap <ravi@ximian.com>
27458 * expression.cs (Invocation::ConversionExists): Re-write to use
27459 the conversion cache
27461 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
27462 cache all conversions done, not just user-defined ones.
27464 (Invocation::BetterConversion): The real culprit. Use ConversionExists
27465 to determine if a conversion exists instead of acutually trying to
27466 perform the conversion. It's faster too.
27468 (Expression::ConvertExplicit): Modify to use ConversionExists to check
27469 and only then attempt the implicit conversion.
27471 2001-09-28 Ravi Pratap <ravi@ximian.com>
27473 * expression.cs (ConvertImplicit): Use a cache for conversions
27474 already found. Check level of recursion and bail out if necessary.
27476 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27478 * typemanager.cs (string_concat_string_string, string_concat_object_object):
27479 Export standard methods that we expect for string operations.
27481 * statement.cs (Block::UsageWarning): Track usage of variables and
27482 report the errors for not used variables.
27484 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
27487 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27489 * codegen.cs: remove unnneded code
27491 * expression.cs: Removed BuiltinTypeAccess class
27493 Fix the order in which implicit conversions are
27496 The previous fixed dropped support for boxed conversions (adding a
27497 test to the test suite now)
27499 (UserImplicitCast::CanConvert): Remove test for source being null,
27500 that code is broken. We should not feed a null to begin with, if
27501 we do, then we should track the bug where the problem originates
27502 and not try to cover it up here.
27504 Return a resolved expression of type UserImplicitCast on success
27505 rather than true/false. Ravi: this is what I was talking about,
27506 the pattern is to use a static method as a "constructor" for
27509 Also, do not create arguments until the very last minute,
27510 otherwise we always create the arguments even for lookups that
27511 will never be performed.
27513 (UserImplicitCast::Resolve): Eliminate, objects of type
27514 UserImplicitCast are born in a fully resolved state.
27516 * typemanager.cs (InitCoreTypes): Init also value_type
27517 (System.ValueType).
27519 * expression.cs (Cast::Resolve): First resolve the child expression.
27521 (LValue): Add new method AddressOf to be used by
27524 Change the argument of Store to take an EmitContext instead of an
27525 ILGenerator, because things like FieldExpr need to be able to call
27526 their children expression to generate the instance code.
27528 (Expression::Error, Expression::Warning): Sugar functions for
27531 (Expression::MemberLookup): Accept a TypeContainer instead of a
27532 Report as the first argument.
27534 (Expression::ResolvePrimary): Killed. I still want to improve
27535 this as currently the code is just not right.
27537 (Expression::ResolveMemberAccess): Simplify, but it is still
27540 (Unary::Resolve): Catch errors in AddressOf operators.
27542 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
27543 index to a byte for the short-version, or the compiler will choose
27544 the wrong Emit call, which generates the wrong data.
27546 (ParameterReference::Emit, ::Store): same.
27548 (FieldExpr::AddressOf): Implement.
27550 * typemanager.cs: TypeManager: made public variable instead of
27553 * driver.cs: document --fatal.
27555 * report.cs (ErrorMessage, WarningMessage): new names for the old
27556 Error and Warning classes.
27558 * cs-parser.jay (member_access): Turn built-in access to types
27559 into a normal simplename
27561 2001-09-27 Ravi Pratap <ravi@ximian.com>
27563 * expression.cs (Invocation::BetterConversion): Fix to cope
27564 with q being null, since this was introducing a bug.
27566 * expression.cs (ConvertImplicit): Do built-in conversions first.
27568 2001-09-27 Ravi Pratap <ravi@ximian.com>
27570 * expression.cs (UserImplicitCast::Resolve): Fix bug.
27572 2001-09-27 Ravi Pratap <ravi@ximian.com>
27574 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
27575 I had introduced long ago (what's new ?).
27577 * expression.cs (UserImplicitCast::CanConvert): Static method to do
27578 the work of all the checking.
27579 (ConvertImplicit): Call CanConvert and only then create object if necessary.
27580 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
27582 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
27583 that is the right way.
27585 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
27586 overloading resolution. Use everywhere instead of cutting and pasting code.
27588 (Binary::ResolveOperator): Use MakeUnionSet.
27590 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
27591 we have to convert to bool types. Not complete yet.
27593 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27595 * typemanager.cs (TypeManager::CSharpName): support ushort.
27597 * expression.cs (Expression::TryImplicitIntConversion): Attempts
27598 to provide an expression that performsn an implicit constant int
27599 conversion (section 6.1.6).
27600 (Expression::ConvertImplicitRequired): Reworked to include
27601 implicit constant expression conversions.
27603 (Expression::ConvertNumericExplicit): Finished.
27605 (Invocation::Emit): If InstanceExpression is null, then it means
27606 that we perform a call on this.
27608 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27610 * expression.cs (Unary::Emit): Remove some dead code.
27611 (Probe): Implement Resolve and Emit for `is'.
27612 (Expression::ConvertImplicitRequired): Attempt to do constant
27613 expression conversions here. Maybe should be moved to
27614 ConvertImplicit, but I am not sure.
27615 (Expression::ImplicitLongConstantConversionPossible,
27616 Expression::ImplicitIntConstantConversionPossible): New functions
27617 that tell whether is it possible to apply an implicit constant
27618 expression conversion.
27620 (ConvertNumericExplicit): Started work on explicit numeric
27623 * cs-parser.jay: Update operator constants.
27625 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
27626 (Parameters::GetSignature): Hook up VerifyArgs here.
27627 (Parameters::VerifyArgs): Verifies that no two arguments have the
27630 * class.cs (Operator): Update the operator names to reflect the
27631 ones that the spec expects (as we are just stringizing the
27634 * expression.cs (Unary::ResolveOperator): Fix bug: Use
27635 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
27636 previous usage did only work for our methods.
27637 (Expression::ConvertImplicit): Handle decimal implicit numeric
27638 conversions as well.
27639 (Expression::InternalTypeConstructor): Used to invoke constructors
27640 on internal types for default promotions.
27642 (Unary::Emit): Implement special handling for the pre/post
27643 increment/decrement for overloaded operators, as they need to have
27644 the same semantics as the other operators.
27646 (Binary::ResolveOperator): ditto.
27647 (Invocation::ConversionExists): ditto.
27648 (UserImplicitCast::Resolve): ditto.
27650 2001-09-26 Ravi Pratap <ravi@ximian.com>
27652 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
27653 operator, return after emitting body. Regression tests pass again !
27655 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
27656 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
27657 (Invocation::OverloadResolve): Ditto.
27658 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
27660 * everywhere : update calls to the above methods accordingly.
27662 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27664 * assign.cs (Assign): Make it inherit from ExpressionStatement.
27666 * expression.cs (ExpressionStatement): New base class used for
27667 expressions that can appear in statements, so that we can provide
27668 an alternate path to generate expression that do not leave a value
27671 (Expression::Emit, and all the derivatives): We no longer return
27672 whether a value is left on the stack or not. Every expression
27673 after being emitted leaves a single value on the stack.
27675 * codegen.cs (EmitContext::EmitStatementExpression): Use the
27676 facilties of ExpressionStatement if possible.
27678 * cs-parser.jay: Update statement_expression.
27680 2001-09-25 Miguel de Icaza <miguel@ximian.com>
27682 * driver.cs: Change the wording of message
27684 2001-09-25 Ravi Pratap <ravi@ximian.com>
27686 * expression.cs (Binary::ResolveOperator): Had forgottten to set
27687 the type of the expression to the return type of the method if
27688 we have an overloaded operator match ! The regression tests pass again !
27689 (Unary::ResolveOperator): Ditto.
27691 * expression.cs (Invocation::ConversionExists): Correct the member lookup
27692 to find "op_Implicit", not "implicit" ;-)
27693 (UserImplicitCast): New class to take care of user-defined implicit conversions.
27694 (ConvertImplicit, ForceConversion): Take TypeContainer argument
27696 * everywhere : Correct calls to the above accordingly.
27698 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
27699 (ConvertImplicit): Do user-defined conversion if it exists.
27701 2001-09-24 Miguel de Icaza <miguel@ximian.com>
27703 * assign.cs: track location.
27704 (Resolve): Use implicit conversions on assignment.
27706 * literal.cs: Oops. Not good, Emit of short access values should
27707 pass (Bytes) or the wrong argument will be selected.
27709 * expression.cs (Unary::Emit): Emit code for -expr.
27711 (Unary::ResolveOperator): Handle `Substract' for non-constants
27712 (substract from zero from the non-constants).
27713 Deal with Doubles as well.
27715 (Expression::ConvertImplicitRequired): New routine that reports an
27716 error if no implicit conversion exists.
27718 (Invocation::OverloadResolve): Store the converted implicit
27719 expressions if we make them
27721 2001-09-24 Ravi Pratap <ravi@ximian.com>
27723 * class.cs (ConstructorInitializer): Take a Location argument.
27724 (ConstructorBaseInitializer): Same here.
27725 (ConstructorThisInitializer): Same here.
27727 * cs-parser.jay : Update all calls accordingly.
27729 * expression.cs (Unary, Binary, New): Take location argument.
27730 Update accordingly everywhere.
27732 * cs-parser.jay : Update all calls to the above to take a location
27735 * class.cs : Ditto.
27737 2001-09-24 Ravi Pratap <ravi@ximian.com>
27739 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
27740 (Invocation::BetterConversion): Same here
27741 (Invocation::ConversionExists): Ditto.
27743 (Invocation::ConversionExists): Implement.
27745 2001-09-22 Ravi Pratap <ravi@ximian.com>
27747 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
27748 Also take an additional TypeContainer argument.
27750 * All over : Pass in TypeContainer as argument to OverloadResolve.
27752 * typemanager.cs (CSharpName): Update to check for the string type and return
27755 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
27758 2001-09-21 Ravi Pratap <ravi@ximian.com>
27760 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
27761 (Invocation::BetterFunction): Implement.
27762 (Invocation::BetterConversion): Implement.
27763 (Invocation::ConversionExists): Skeleton, no implementation yet.
27765 Okay, things work fine !
27767 2001-09-21 Miguel de Icaza <miguel@ximian.com>
27769 * typemanager.cs: declare and load enum_type, delegate_type and
27772 * expression.cs (Expression::Emit): Now emit returns a value that
27773 tells whether a value is left on the stack or not. This strategy
27774 might be reveted tomorrow with a mechanism that would address
27775 multiple assignments.
27776 (Expression::report118): Utility routine to report mismatches on
27779 (Unary::Report23): Report impossible type/operator combination
27782 (Unary::IsIncrementableNumber): Whether the type can be
27783 incremented or decremented with add.
27784 (Unary::ResolveOperator): Also allow enumerations to be bitwise
27786 (Unary::ResolveOperator): Implement ++, !, ~,
27788 (Invocation::Emit): Deal with new Emit convetion.
27790 * All Expression derivatives: Updated their Emit method to return
27791 whether they leave values on the stack or not.
27793 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
27794 stack for expressions that are statements.
27796 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27798 * expression.cs (LValue): New interface. Must be implemented by
27800 (LocalVariableReference, ParameterReference, FieldExpr): Implement
27803 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
27804 interface for generating code, simplifies the code.
27806 2001-09-20 Ravi Pratap <ravi@ximian.com>
27808 * expression.cs (everywhere): Comment out return statements in ::Resolve
27809 methods to avoid the warnings.
27811 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27813 * driver.cs (parse): Report error 2001 if we can not open the
27816 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
27819 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
27822 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
27823 otherwise nested blocks end up with the same index.
27825 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
27827 * expression.cs: Instead of having FIXMEs in the Resolve
27828 functions, throw exceptions so it is obvious that we are facing a
27831 * cs-parser.jay (invocation_expression): Pass Location information.
27833 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
27834 Use a basename for those routines because .NET does not like paths
27837 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
27840 2001-09-19 Miguel de Icaza <miguel@ximian.com>
27842 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
27843 are loading the correct data types (throws an exception if not).
27844 (TypeManager::InitCoreTypes): Use CoreLookupType
27846 * expression.cs (Unary::ResolveOperator): return the child
27847 expression for expressions which are just +expr.
27848 (Unary::ResolveOperator): Return negative literals for -LITERAL
27849 expressions (otherwise they are Unary {Literal}).
27850 (Invocation::Badness): Take into account `Implicit constant
27851 expression conversions'.
27853 * literal.cs (LongLiteral): Implement long literal class.
27854 (IntLiteral): export the `Value' of the intliteral.
27856 2001-09-19 Ravi Pratap <ravi@ximian.com>
27858 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
27860 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
27861 instead of 'Operator'
27863 * expression.cs (Binary::ResolveOperator): Update accordingly.
27864 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
27867 * cs-parser.jay (unary_expression): Update to use the new names.
27869 * gen-treedump.cs (GetUnary): Same here.
27871 * expression.cs (Unary::Resolve): Implement.
27872 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
27873 operators are found instead of making noise ;-)
27874 (Unary::ResolveOperator): New method to do precisely the same thing which
27875 Binary::ResolveOperator does for Binary expressions.
27876 (Unary.method, .Arguments): Add.
27877 (Unary::OperName): Implement.
27878 (Unary::ForceConversion): Copy and Paste !
27880 * class.cs (Operator::Define): Fix a small bug for the case when we have
27883 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
27884 for the inbuilt operators. Only overloading works for now ;-)
27886 2001-09-18 Miguel de Icaza <miguel@ximian.com>
27888 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
27889 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
27891 * expression.cs (This::Emit): Implement.
27892 (This::Resolve): Implement.
27893 (TypeOf:Resolve): Implement.
27894 (Expression::ResolveSimpleName): Add an implicit this to instance
27896 (MemberAccess::Resolve): Deal with Parameters and Fields.
27897 Bind instance variable to Field expressions.
27898 (FieldExpr::Instance): New field used to track the expression that
27899 represents the object instance.
27900 (FieldExpr::Resolve): Track potential errors from MemberLookup not
27902 (FieldExpr::Emit): Implement.
27904 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
27905 the last instruction contains a return opcode to avoid generating
27906 the last `ret' instruction (this generates correct code, and it is
27907 nice to pass the peverify output).
27909 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
27910 initializer for static and instance variables.
27911 (Constructor::Emit): Allow initializer to be null in the case of
27912 static constructors. Only emit initializer for instance
27915 (TypeContainer::FindMembers): Return a null array if there are no
27918 Also fix the code for the MemberTypes.Method branch, as it was not
27919 scanning that for operators (or tried to access null variables before).
27921 * assign.cs (Assign::Emit): Handle instance and static fields.
27925 * driver.cs: Stop compilation if there are parse errors.
27927 * cs-parser.jay (constructor_declaration): Provide default base
27928 initializer for non-static constructors.
27929 (constructor_declarator): Do not provide a default base
27930 initializers if none was specified.
27931 Catch the fact that constructors should not have parameters.
27933 * class.cs: Do not emit parent class initializers for static
27934 constructors, that should be flagged as an error.
27936 2001-09-18 Ravi Pratap <ravi@ximian.com>
27938 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
27939 Move back code into TypeContainer::Populate.
27941 2001-09-18 Ravi Pratap <ravi@ximian.com>
27943 * class.cs (TypeContainer::AddConstructor): Fix the check to
27944 compare against Name, not Basename.
27945 (Operator::OpType): Change Plus and Minus to Add and Subtract.
27947 * cs-parser.jay : Update accordingly.
27949 * class.cs (TypeContainer::FindMembers): For the case where we are searching
27950 for methods, don't forget to look into the operators too.
27951 (RegisterMethodBuilder): Helper method to take care of this for
27952 methods, constructors and operators.
27953 (Operator::Define): Completely revamp.
27954 (Operator.OperatorMethod, MethodName): New fields.
27955 (TypeContainer::Populate): Move the registering of builders into
27956 RegisterMethodBuilder.
27957 (Operator::Emit): Re-write.
27959 * expression.cs (Binary::Emit): Comment out code path to emit method
27960 invocation stuff for the case when we have a user defined operator. I am
27961 just not able to get it right !
27963 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27965 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
27968 (Expression::MemberLookup): Provide a version that allows to
27969 specify the MemberTypes and BindingFlags.
27971 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
27972 so it was not fetching variable information from outer blocks.
27974 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
27975 Beforefieldinit as it was buggy.
27977 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
27978 that Ravi put here.
27980 * class.cs (Constructor::Emit): Only emit if block is not null.
27981 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
27982 deal with this by semantically definining it as if the user had
27985 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
27986 constructors as we now "emit" them at a higher level.
27988 (TypeContainer::DefineDefaultConstructor): Used to define the
27989 default constructors if none was provided.
27991 (ConstructorInitializer): Add methods Resolve and Emit.
27993 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
27995 2001-09-17 Ravi Pratap <ravi@ximian.com>
27997 * class.cs (TypeContainer::EmitDefaultConstructor): Register
27998 the default constructor builder with our hashtable for methodbuilders
28001 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
28002 and argument_count is 0 in which case we have a match.
28003 (Binary::ResolveOperator): More null checking and miscellaneous coding
28006 2001-09-17 Ravi Pratap <ravi@ximian.com>
28008 * rootcontext.cs (IsNameSpace): Compare against null.
28010 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
28012 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
28013 and Unary::Operator.
28015 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
28018 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
28019 we have overloaded operators.
28020 (Binary::ResolveOperator): Implement the part which does the operator overload
28023 * class.cs (Operator::Emit): Implement.
28024 (TypeContainer::Emit): Emit the operators we have too.
28026 * expression.cs (Binary::Emit): Update to emit the appropriate code for
28027 the case when we have a user-defined operator.
28029 2001-09-17 Miguel de Icaza <miguel@ximian.com>
28031 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
28033 2001-09-16 Ravi Pratap <ravi@ximian.com>
28035 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
28036 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
28037 (Constructor::Emit): Implement.
28038 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
28039 if we have no work to do.
28040 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
28043 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
28044 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
28046 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
28049 2001-09-15 Ravi Pratap <ravi@ximian.com>
28051 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
28053 (Tree::RecordNamespace): Method to do what the name says ;-)
28054 (Tree::Namespaces): Property to get at the namespaces hashtable.
28056 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
28059 * rootcontext.cs (IsNamespace): Fixed it :-)
28061 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28063 * class.cs (TypeContainer::FindMembers): Add support for
28065 (MethodCore): New class that encapsulates both the shared aspects
28066 of a Constructor and a Method.
28067 (Method, Constructor): Factored pieces into MethodCore.
28069 * driver.cs: Added --fatal which makes errors throw exceptions.
28070 Load System assembly as well as part of the standard library.
28072 * report.cs: Allow throwing exceptions on errors for debugging.
28074 * modifiers.cs: Do not use `parent', instead use the real type
28075 container to evaluate permission settings.
28077 * class.cs: Put Ravi's patch back in. He is right, and we will
28078 have to cope with the
28080 2001-09-14 Ravi Pratap <ravi@ximian.com>
28082 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
28083 FamORAssem, not FamANDAssem.
28085 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28087 * driver.cs: Added --parse option that only parses its input files
28090 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
28091 incorrect. IsTopLevel is not used to tell whether an object is
28092 root_types or not (that can be achieved by testing this ==
28093 root_types). But to see if this is a top-level *class* (not
28094 necessarly our "toplevel" container).
28096 2001-09-14 Ravi Pratap <ravi@ximian.com>
28098 * enum.cs (Enum::Define): Modify to call the Lookup method on the
28099 parent instead of a direct call to GetType.
28101 2001-09-14 Ravi Pratap <ravi@ximian.com>
28103 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
28104 Modifiers.TypeAttr. This should just be a call to that method.
28106 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
28107 object so that we can determine if we are top-level or not.
28109 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
28112 * enum.cs (Enum::Define): Ditto.
28114 * modifiers.cs (FieldAttr): Re-write.
28116 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
28117 (TypeContainer::HaveStaticConstructor): New property to provide access
28118 to precisely that info.
28120 * modifiers.cs (MethodAttr): Re-write.
28121 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
28123 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
28124 of top-level types as claimed.
28126 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28128 * expression.cs (MemberLookup): Fruitless attempt to lookup
28129 constructors. Maybe I need to emit default constructors? That
28130 might be it (currently .NET emits this for me automatically).
28131 (Invocation::OverloadResolve): Cope with Arguments == null.
28132 (Invocation::EmitArguments): new function, shared by the new
28133 constructor and us.
28134 (Invocation::Emit): Handle static and instance methods. Emit
28135 proper call instruction for virtual or non-virtual invocations.
28136 (New::Emit): Implement.
28137 (New::Resolve): Implement.
28138 (MemberAccess:Resolve): Implement.
28139 (MethodGroupExpr::InstanceExpression): used conforming to the spec
28140 to track instances.
28141 (FieldExpr::Resolve): Set type.
28143 * support.cs: Handle empty arguments.
28145 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
28146 SimpleLookup): Auxiliary routines to help parse a qualifier
28149 Update qualifier_identifier rule.
28151 * codegen.cs: Removed debugging messages.
28153 * class.cs: Make this a global thing, this acts just as a "key" to
28154 objects that we might have around.
28156 (Populate): Only initialize method_builders_to_methods once.
28158 * expression.cs (PropertyExpr): Initialize type from the
28161 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
28162 Resolve pattern. Attempt to implicitly convert value to boolean.
28165 * expression.cs: Set the type for the int32/int32 argument case.
28166 (Binary::ResolveOperator): Set the return type to boolean for
28167 comparission operators
28169 * typemanager.cs: Remove debugging print code.
28171 (Invocation::Resolve): resolve type.
28173 * class.cs: Allocate a MemberInfo of the correct size, as the code
28174 elsewhere depends on the test to reflect the correct contents.
28176 (Method::) Keep track of parameters, due to System.Reflection holes
28178 (TypeContainer::Populate): Keep track of MethodBuilders to Method
28181 (TypeContainer::FindMembers): Use ArrayList and then copy an array
28182 of the exact size and return that.
28184 (Class::LookupMethodByBuilder): New function that maps
28185 MethodBuilders to its methods. Required to locate the information
28186 on methods because System.Reflection bit us again.
28188 * support.cs: New file, contains an interface ParameterData and
28189 two implementations: ReflectionParameters and InternalParameters
28190 used to access Parameter information. We will need to grow this
28193 * expression.cs (Invocation::GetParameterData): implement a cache
28194 and a wrapper around the ParameterData creation for methods.
28195 (Invocation::OverloadResolve): Use new code.
28197 2001-09-13 Ravi Pratap <ravi@ximian.com>
28199 * class.cs (TypeContainer::EmitField): Remove and move into
28200 (Field::Define): here and modify accordingly.
28201 (Field.FieldBuilder): New member.
28202 (TypeContainer::Populate): Update accordingly.
28203 (TypeContainer::FindMembers): Implement.
28205 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28207 * statement.cs: (VariableInfo::VariableType): New field to be
28208 initialized with the full type once it is resolved.
28210 2001-09-12 Miguel de Icaza <miguel@ximian.com>
28212 * parameter.cs (GetParameterInfo): Use a type cache to compute
28213 things only once, and to reuse this information
28215 * expression.cs (LocalVariableReference::Emit): Implement.
28216 (OpcodeCast::Emit): fix.
28218 (ParameterReference::Resolve): Implement.
28219 (ParameterReference::Emit): Implement.
28221 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
28222 that are expressions need to stay as Expressions.
28224 * typemanager.cs (CSharpName): Returns the C# name of a type if
28227 * expression.cs (Expression::ConvertImplicit): New function that
28228 implements implicit type conversions.
28230 (Expression::ImplicitReferenceConversion): Implements implicit
28231 reference conversions.
28233 (EmptyCast): New type for transparent casts.
28235 (OpcodeCast): New type for casts of types that are performed with
28236 a sequence of bytecodes.
28238 (BoxedCast): New type used for casting value types into reference
28239 types. Emits a box opcode.
28241 (Binary::DoNumericPromotions): Implements numeric promotions of
28242 and computation of the Binary::Type.
28244 (Binary::EmitBranchable): Optimization.
28246 (Binary::Emit): Implement code emission for expressions.
28248 * typemanager.cs (TypeManager): Added two new core types: sbyte
28251 2001-09-12 Ravi Pratap <ravi@ximian.com>
28253 * class.cs (TypeContainer::FindMembers): Method which does exactly
28254 what Type.FindMembers does, only we don't have to use reflection. No
28255 implementation yet.
28257 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
28258 typecontainer objects as we need to get at them.
28259 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
28261 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
28262 typecontainer object.
28264 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
28265 of just a Report object.
28267 2001-09-11 Ravi Pratap <ravi@ximian.com>
28269 * class.cs (Event::Define): Go back to using the prefixes "add_" and
28271 (TypeContainer::Populate): Now define the delegates of the type too.
28272 (TypeContainer.Delegates): Property to access the list of delegates defined
28275 * delegates.cs (Delegate::Define): Implement partially.
28277 * modifiers.cs (TypeAttr): Handle more flags.
28279 2001-09-11 Ravi Pratap <ravi@ximian.com>
28281 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
28283 (Operator::Define): Re-write logic to get types by using the LookupType method
28284 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
28285 (Indexer::Define): Ditto.
28286 (Event::Define): Ditto.
28287 (Property::Define): Ditto.
28289 2001-09-10 Ravi Pratap <ravi@ximian.com>
28291 * class.cs (TypeContainer::Populate): Now define operators too.
28292 (TypeContainer.Operators): New property to access the list of operators
28294 (Operator.OperatorMethodBuilder): New member to hold the method builder
28295 for the operator we are defining.
28296 (Operator::Define): Implement.
28298 2001-09-10 Ravi Pratap <ravi@ximian.com>
28300 * class.cs (Event::Define): Make the prefixes of the accessor methods
28301 addOn_ and removeOn_
28303 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
28304 of the location being passed in too. Ideally, this should go later since all
28305 error reporting should be done through the Report object.
28307 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
28308 (Populate): Iterate thru the indexers we have and define them too.
28309 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
28310 for the get and set accessors.
28311 (Indexer::Define): Implement.
28313 2001-09-09 Miguel de Icaza <miguel@ximian.com>
28315 * expression.cs (Binary::Resolve): Beginning of it. I scratched
28316 my previous implementation, did not work.
28318 * typemanager.cs: Add a couple of missing types (the longs).
28320 * literal.cs: Use TypeManager.bool_type instead of getting it.
28322 * expression.cs (EventExpr): New kind of expressions.
28323 (Expressio::ExprClassFromMemberInfo): finish
28325 2001-09-08 Miguel de Icaza <miguel@ximian.com>
28327 * assign.cs: Emit stores to static fields differently.
28329 2001-09-08 Ravi Pratap <ravi@ximian.com>
28331 * Merge in changes and adjust code to tackle conflicts. Backed out my
28332 code in Assign::Resolve ;-)
28334 2001-09-08 Ravi Pratap <ravi@ximian.com>
28336 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
28337 instead Report.Error and also pass in the location.
28338 (CSharpParser::Lexer): New readonly property to return the reference
28339 to the Tokenizer object.
28340 (declare_local_variables): Use Report.Error with location instead of plain
28344 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
28345 (Operator.CheckBinaryOperator): Ditto.
28347 * cs-parser.jay (operator_declarator): Update accordingly.
28349 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
28350 (CheckBinaryOperator): Same here.
28352 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
28353 on the name without any prefixes of namespace names etc. This is because we
28354 already might have something already fully qualified like
28355 'System.Console.WriteLine'
28357 * assign.cs (Resolve): Begin implementation. Stuck ;-)
28359 2001-09-07 Ravi Pratap <ravi@ximian.com>
28361 * cs-tokenizer.cs (location): Return a string which also contains
28364 * expression.cs (ElementAccess): New class for expressions of the
28365 type 'element access.'
28366 (BaseAccess): New class for expressions of the type 'base access.'
28367 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
28370 * cs-parser.jay (element_access): Implement action.
28371 (base_access): Implement actions.
28372 (checked_expression, unchecked_expression): Implement.
28374 * cs-parser.jay (local_variable_type): Correct and implement.
28375 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
28377 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
28379 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
28380 name and the specifiers.
28382 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
28384 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
28385 making them all public ;-)
28387 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
28390 2001-09-07 Miguel de Icaza <miguel@ximian.com>
28392 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
28394 (FieldExpr, PropertyExprs): New resolved expressions.
28395 (SimpleName::MemberStaticCheck): Perform static checks for access
28396 to non-static fields on static methods. Maybe this should be
28397 generalized for MemberAccesses.
28398 (SimpleName::ResolveSimpleName): More work on simple name
28401 * cs-parser.jay (primary_expression/qualified_identifier): track
28402 the parameter index.
28404 * codegen.cs (CodeGen::Save): Catch save exception, report error.
28405 (EmitContext::EmitBoolExpression): Chain to expression generation
28406 instead of temporary hack.
28407 (::EmitStatementExpression): Put generic expression code generation.
28409 * assign.cs (Assign::Emit): Implement variable assignments to
28410 local variables, parameters and fields.
28412 2001-09-06 Miguel de Icaza <miguel@ximian.com>
28414 * statement.cs (Block::GetVariableInfo): New method, returns the
28415 VariableInfo for a variable name in a block.
28416 (Block::GetVariableType): Implement in terms of GetVariableInfo
28418 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
28419 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
28421 2001-09-06 Ravi Pratap <ravi@ximian.com>
28423 * cs-parser.jay (operator_declaration): Continue on my quest : update
28424 to take attributes argument.
28425 (event_declaration): Ditto.
28426 (enum_declaration): Ditto.
28427 (indexer_declaration): Ditto.
28429 * class.cs (Operator::Operator): Update constructor accordingly.
28430 (Event::Event): Ditto.
28432 * delegate.cs (Delegate::Delegate): Same here.
28434 * enum.cs (Enum::Enum): Same here.
28436 2001-09-05 Ravi Pratap <ravi@ximian.com>
28438 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
28440 * ../tests/cs0658.cs : New file to demonstrate error 0658.
28442 * attribute.cs (Attributes): New class to encapsulate all attributes which were
28443 being passed around as an arraylist.
28444 (Attributes::AddAttribute): Method to add attribute sections.
28446 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
28447 (struct_declaration): Update accordingly.
28448 (constant_declaration): Update.
28449 (field_declaration): Update.
28450 (method_header): Update.
28451 (fixed_parameter): Update.
28452 (parameter_array): Ditto.
28453 (property_declaration): Ditto.
28454 (destructor_declaration): Ditto.
28456 * class.cs (Struct::Struct): Update constructors accordingly.
28457 (Class::Class): Ditto.
28458 (Field::Field): Ditto.
28459 (Method::Method): Ditto.
28460 (Property::Property): Ditto.
28461 (TypeContainer::OptAttribute): update property's return type.
28463 * interface.cs (Interface.opt_attributes): New member.
28464 (Interface::Interface): Update to take the extra Attributes argument.
28466 * parameter.cs (Parameter::Parameter): Ditto.
28468 * constant.cs (Constant::Constant): Ditto.
28470 * interface.cs (InterfaceMemberBase): New OptAttributes field.
28471 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
28472 the attributes as a parameter.
28473 (InterfaceProperty): Update constructor call.
28474 (InterfaceEvent): Ditto.
28475 (InterfaceMethod): Ditto.
28476 (InterfaceIndexer): Ditto.
28478 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
28479 pass the attributes too.
28480 (interface_event_declaration): Ditto.
28481 (interface_property_declaration): Ditto.
28482 (interface_method_declaration): Ditto.
28483 (interface_declaration): Ditto.
28485 2001-09-05 Miguel de Icaza <miguel@ximian.com>
28487 * class.cs (Method::Define): Track the "static Main" definition to
28488 create an entry point.
28490 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
28491 EntryPoint if we find it.
28493 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
28494 (EmitContext::ig): Make this variable public.
28496 * driver.cs: Make the default output file be the first file name
28497 with the .exe extension.
28499 Detect empty compilations
28501 Handle various kinds of output targets. Handle --target and
28502 rename -t to --dumper.
28504 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
28505 methods inherited from Expression return now an Expression. This
28506 will is used during the tree rewriting as we resolve them during
28509 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
28510 the spec. Missing entirely is the information about
28511 accessability of elements of it.
28513 (Expression::ExprClassFromMemberInfo): New constructor for
28514 Expressions that creates a fully initialized Expression based on
28515 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
28518 (Invocation::Resolve): Begin implementing resolution of invocations.
28520 * literal.cs (StringLiteral): Implement Emit.
28522 2001-09-05 Ravi Pratap <ravi@ximian.com>
28524 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
28527 2001-09-04 Ravi Pratap <ravi@ximian.com>
28529 * cs-parser.jay (attribute_arguments): Implement actions.
28530 (attribute): Fix bug in production. Implement action.
28531 (attribute_list): Implement.
28532 (attribute_target): Implement.
28533 (attribute_target_specifier, opt_target_specifier): Implement
28534 (CheckAttributeTarget): New method to check if the attribute target
28536 (attribute_section): Implement.
28537 (opt_attributes): Implement.
28539 * attribute.cs : New file to handle attributes.
28540 (Attribute): Class to hold attribute info.
28542 * cs-parser.jay (opt_attribute_target_specifier): Remove production
28543 (attribute_section): Modify production to use 2 different rules to
28544 achieve the same thing. 1 s/r conflict down !
28545 Clean out commented, useless, non-reducing dimension_separator rules.
28547 * class.cs (TypeContainer.attributes): New member to hold list
28548 of attributes for a type.
28549 (Struct::Struct): Modify to take one more argument, the attribute list.
28550 (Class::Class): Ditto.
28551 (Field::Field): Ditto.
28552 (Method::Method): Ditto.
28553 (Property::Property): Ditto.
28555 * cs-parser.jay (struct_declaration): Update constructor call to
28556 pass in the attributes too.
28557 (class_declaration): Ditto.
28558 (constant_declaration): Ditto.
28559 (field_declaration): Ditto.
28560 (method_header): Ditto.
28561 (fixed_parameter): Ditto.
28562 (parameter_array): Ditto.
28563 (property_declaration): Ditto.
28565 * constant.cs (Constant::Constant): Update constructor similarly.
28566 Use System.Collections.
28568 * parameter.cs (Parameter::Parameter): Update as above.
28570 2001-09-02 Ravi Pratap <ravi@ximian.com>
28572 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
28573 (TypeContainer.delegates): New member to hold list of delegates.
28575 * cs-parser.jay (delegate_declaration): Implement the action correctly
28576 this time as I seem to be on crack ;-)
28578 2001-09-02 Miguel de Icaza <miguel@ximian.com>
28580 * rootcontext.cs (RootContext::IsNamespace): new function, used to
28581 tell whether an identifier represents a namespace.
28583 * expression.cs (NamespaceExpr): A namespace expression, used only
28584 temporarly during expression resolution.
28585 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
28586 utility functions to resolve names on expressions.
28588 2001-09-01 Miguel de Icaza <miguel@ximian.com>
28590 * codegen.cs: Add hook for StatementExpressions.
28592 * class.cs: Fix inverted test for static flag in methods.
28594 2001-09-02 Ravi Pratap <ravi@ximian.com>
28596 * class.cs (Operator::CheckUnaryOperator): Correct error number used
28597 to make it coincide with MS' number.
28598 (Operator::CheckBinaryOperator): Ditto.
28600 * ../errors/errors.txt : Remove error numbers added earlier.
28602 * ../errors/cs1019.cs : Test case for error # 1019
28604 * ../errros/cs1020.cs : Test case for error # 1020
28606 * cs-parser.jay : Clean out commented cruft.
28607 (dimension_separators, dimension_separator): Comment out. Ostensibly not
28608 used anywhere - non-reducing rule.
28609 (namespace_declarations): Non-reducing rule - comment out.
28611 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
28612 with TypeContainer::AddEnum.
28614 * delegate.cs : New file for delegate handling classes.
28615 (Delegate): Class for declaring delegates.
28617 * makefile : Update.
28619 * cs-parser.jay (delegate_declaration): Implement.
28621 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
28623 * class.cs (Event::Define): Implement.
28624 (Event.EventBuilder): New member.
28626 * class.cs (TypeContainer::Populate): Update to define all enums and events
28628 (Events): New property for the events arraylist we hold. Shouldn't we move to using
28629 readonly fields for all these cases ?
28631 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28633 * class.cs (Property): Revamp to use the convention of making fields readonly.
28634 Accordingly modify code elsewhere.
28636 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
28637 the Define method of the Property class.
28639 * class.cs : Clean up applied patch and update references to variables etc. Fix
28641 (TypeContainer::Populate): Update to define all the properties we have. Also
28642 define all enumerations.
28644 * enum.cs (Define): Implement.
28646 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28648 * cs-parser.jay (overloadable_operator): The semantic value is an
28649 enum of the Operator class.
28650 (operator_declarator): Implement actions.
28651 (operator_declaration): Implement.
28653 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
28654 validity of definitions.
28655 (Operator::CheckBinaryOperator): Static method to check for binary operators
28656 (TypeContainer::AddOperator): New method to add an operator to a type.
28658 * cs-parser.jay (indexer_declaration): Added line to actually call the
28659 AddIndexer method so it gets added ;-)
28661 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
28662 already taken care of by the MS compiler ?
28664 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28666 * class.cs (Operator): New class for operator declarations.
28667 (Operator::OpType): Enum for the various operators.
28669 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28671 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
28672 ostensibly handle this in semantic analysis.
28674 * cs-parser.jay (general_catch_clause): Comment out
28675 (specific_catch_clauses, specific_catch_clause): Ditto.
28676 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
28677 (catch_args, opt_catch_args): New productions.
28678 (catch_clause): Rewrite to use the new productions above
28679 (catch_clauses): Modify accordingly.
28680 (opt_catch_clauses): New production to use in try_statement
28681 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
28682 and re-write the code in the actions to extract the specific and
28683 general catch clauses by being a little smart ;-)
28685 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
28686 Hooray, try and catch statements parse fine !
28688 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28690 * statement.cs (Block::GetVariableType): Fix logic to extract the type
28691 string from the hashtable of variables.
28693 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
28694 I end up making that mistake ;-)
28695 (catch_clauses): Fixed gross error which made Key and Value of the
28696 DictionaryEntry the same : $1 !!
28698 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28700 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
28702 * cs-parser.jay (event_declaration): Correct to remove the semicolon
28703 when the add and remove accessors are specified.
28705 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28707 * cs-parser.jay (IndexerDeclaration): New helper class to hold
28708 information about indexer_declarator.
28709 (indexer_declarator): Implement actions.
28710 (parsing_indexer): New local boolean used to keep track of whether
28711 we are parsing indexers or properties. This is necessary because
28712 implicit_parameters come into picture even for the get accessor in the
28713 case of an indexer.
28714 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
28716 * class.cs (Indexer): New class for indexer declarations.
28717 (TypeContainer::AddIndexer): New method to add an indexer to a type.
28718 (TypeContainer::indexers): New member to hold list of indexers for the
28721 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28723 * cs-parser.jay (add_accessor_declaration): Implement action.
28724 (remove_accessor_declaration): Implement action.
28725 (event_accessors_declaration): Implement
28726 (variable_declarators): swap statements for first rule - trivial.
28728 * class.cs (Event): New class to hold information about event
28730 (TypeContainer::AddEvent): New method to add an event to a type
28731 (TypeContainer::events): New member to hold list of events.
28733 * cs-parser.jay (event_declaration): Implement actions.
28735 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28737 * cs-parser.jay (dim_separators): Implement. Make it a string
28738 concatenating all the commas together, just as they appear.
28739 (opt_dim_separators): Modify accordingly
28740 (rank_specifiers): Update accordingly. Basically do the same
28741 thing - instead, collect the brackets here.
28742 (opt_rank_sepcifiers): Modify accordingly.
28743 (array_type): Modify to actually return the complete type string
28744 instead of ignoring the rank_specifiers.
28745 (expression_list): Implement to collect the expressions
28746 (variable_initializer): Implement. We make it a list of expressions
28747 essentially so that we can handle the array_initializer case neatly too.
28748 (variable_initializer_list): Implement.
28749 (array_initializer): Make it a list of variable_initializers
28750 (opt_array_initializer): Modify accordingly.
28752 * expression.cs (New::NType): Add enumeration to help us
28753 keep track of whether we have an object/delegate creation
28754 or an array creation.
28755 (New:NewType, New::Rank, New::Indices, New::Initializers): New
28756 members to hold data about array creation.
28757 (New:New): Modify to update NewType
28758 (New:New): New Overloaded contructor for the array creation
28761 * cs-parser.jay (array_creation_expression): Implement to call
28762 the overloaded New constructor.
28764 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
28766 * class.cs (TypeContainer::Constructors): Return member
28767 constructors instead of returning null.
28769 2001-08-26 Miguel de Icaza <miguel@ximian.com>
28771 * typemanager.cs (InitCoreTypes): Initialize the various core
28772 types after we have populated the type manager with the user
28773 defined types (this distinction will be important later while
28774 compiling corlib.dll)
28776 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
28777 on Expression Classification. Now all expressions have a method
28778 `Resolve' and a method `Emit'.
28780 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
28781 generation from working. Also add some temporary debugging
28784 2001-08-24 Miguel de Icaza <miguel@ximian.com>
28786 * codegen.cs: Lots of code generation pieces. This is only the
28787 beginning, will continue tomorrow with more touches of polish. We
28788 handle the fundamentals of if, while, do, for, return. Others are
28789 trickier and I need to start working on invocations soon.
28791 * gen-treedump.cs: Bug fix, use s.Increment here instead of
28794 * codegen.cs (EmitContext): New struct, used during code
28795 emission to keep a context. Most of the code generation will be
28798 * cs-parser.jay: Add embedded blocks to the list of statements of
28799 this block. So code generation proceeds in a top down fashion.
28801 2001-08-23 Miguel de Icaza <miguel@ximian.com>
28803 * statement.cs: Add support for multiple child blocks.
28805 2001-08-22 Miguel de Icaza <miguel@ximian.com>
28807 * codegen.cs (EmitCode): New function, will emit the code for a
28808 Block of code given a TypeContainer and its ILGenerator.
28810 * statement.cs (Block): Standard public readonly optimization.
28811 (Block::Block constructors): Link children.
28812 (Block::Child): Child Linker.
28813 (Block::EmitVariables): Emits IL variable declarations.
28815 * class.cs: Drop support for MethodGroups here, delay until
28817 (Method::): Applied the same simplification that I did before, and
28818 move from Properties to public readonly fields.
28819 (Method::ParameterTypes): Returns the parameter types for the
28820 function, and implements a cache that will be useful later when I
28821 do error checking and the semantic analysis on the methods is
28823 (Constructor::GetCallingConvention): Renamed from CallingConvetion
28824 and made a method, optional argument tells whether this is a class
28825 or a structure to apply the `has-this' bit.
28826 (Method::GetCallingConvention): Implement, returns the calling
28828 (Method::Define): Defines the type, a second pass is performed
28829 later to populate the methods.
28831 (Constructor::ParameterTypes): implement a cache similar to the
28832 one on Method::ParameterTypes, useful later when we do semantic
28835 (TypeContainer::EmitMethod): New method. Emits methods.
28837 * expression.cs: Removed MethodGroup class from here.
28839 * parameter.cs (Parameters::GetCallingConvention): new method.
28841 2001-08-21 Miguel de Icaza <miguel@ximian.com>
28843 * class.cs (TypeContainer::Populate): Drop RootContext from the
28846 (Constructor::CallingConvention): Returns the calling convention.
28847 (Constructor::ParameterTypes): Returns the constructor parameter
28850 (TypeContainer::AddConstructor): Keep track of default constructor
28851 and the default static constructor.
28853 (Constructor::) Another class that starts using `public readonly'
28854 instead of properties.
28856 (Constructor::IsDefault): Whether this is a default constructor.
28858 (Field::) use readonly public fields instead of properties also.
28860 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
28861 track of static constructors; If none is used, turn on
28862 BeforeFieldInit in the TypeAttributes.
28864 * cs-parser.jay (opt_argument_list): now the return can be null
28865 for the cases where there are no arguments.
28867 (constructor_declarator): If there is no implicit `base' or
28868 `this', then invoke the default parent constructor.
28870 * modifiers.cs (MethodAttr): New static function maps a set of
28871 modifiers flags into a MethodAttributes enum
28872 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
28873 MethodAttr, TypeAttr to represent the various mappings where the
28874 modifiers are used.
28875 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
28877 2001-08-19 Miguel de Icaza <miguel@ximian.com>
28879 * parameter.cs (GetParameterInfo): Fix bug where there would be no
28882 * interface.cs (PopulateIndexer): Implemented the code generator
28883 for interface indexers.
28885 2001-08-17 Miguel de Icaza <miguel@ximian.com>
28887 * interface.cs (InterfaceMemberBase): Now we track the new status
28890 (PopulateProperty): Implement property population. Woohoo! Got
28891 Methods and Properties going today.
28893 Removed all the properties for interfaces, and replaced them with
28894 `public readonly' fields.
28896 2001-08-16 Miguel de Icaza <miguel@ximian.com>
28898 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
28899 initialize their hashtables/arraylists only when they are needed
28900 instead of doing this always.
28902 * parameter.cs: Handle refs and out parameters.
28904 * cs-parser.jay: Use an ArrayList to construct the arguments
28905 instead of the ParameterCollection, and then cast that to a
28908 * parameter.cs: Drop the use of ParameterCollection and use
28909 instead arrays of Parameters.
28911 (GetParameterInfo): Use the Type, not the Name when resolving
28914 2001-08-13 Miguel de Icaza <miguel@ximian.com>
28916 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
28917 and instead use public readonly fields.
28919 * class.cs: Put back walking code for type containers.
28921 2001-08-11 Miguel de Icaza <miguel@ximian.com>
28923 * class.cs (MakeConstant): Code to define constants.
28925 * rootcontext.cs (LookupType): New function. Used to locate types
28928 2001-08-08 Miguel de Icaza <miguel@ximian.com>
28930 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
28931 this System.Reflection code is. Kudos to Microsoft
28933 * typemanager.cs: Implement a type cache and avoid loading all
28934 types at boot time. Wrap in LookupType the internals. This made
28935 the compiler so much faster. Wow. I rule!
28937 * driver.cs: Make sure we always load mscorlib first (for
28938 debugging purposes, nothing really important).
28940 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
28941 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
28943 * rootcontext.cs: Lookup types on their namespace; Lookup types
28944 on namespaces that have been imported using the `using' keyword.
28946 * class.cs (TypeContainer::TypeAttr): Virtualize.
28947 (Class::TypeAttr): Return attributes suitable for this bad boy.
28948 (Struct::TypeAttr): ditto.
28949 Handle nested classes.
28950 (TypeContainer::) Remove all the type visiting code, it is now
28951 replaced with the rootcontext.cs code
28953 * rootcontext.cs (GetClassBases): Added support for structs.
28955 2001-08-06 Miguel de Icaza <miguel@ximian.com>
28957 * interface.cs, statement.cs, class.cs, parameter.cs,
28958 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
28959 Drop use of TypeRefs, and use strings instead.
28961 2001-08-04 Miguel de Icaza <miguel@ximian.com>
28965 * class.cs (Struct::Struct): set the SEALED flags after
28966 checking the modifiers.
28967 (TypeContainer::TypeAttr): new property, returns the
28968 TypeAttributes for a class.
28970 * cs-parser.jay (type_list): Oops, list production was creating a
28971 new list of base types.
28973 * rootcontext.cs (StdLib): New property.
28974 (GetInterfaceTypeByName): returns an interface by type name, and
28975 encapsulates error handling here.
28976 (GetInterfaces): simplified.
28977 (ResolveTree): Encapsulated all the tree resolution here.
28978 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
28981 * driver.cs: Add support for --nostdlib, to avoid loading the
28982 default assemblies.
28983 (Main): Do not put tree resolution here.
28985 * rootcontext.cs: Beginning of the class resolution.
28987 2001-08-03 Miguel de Icaza <miguel@ximian.com>
28989 * rootcontext.cs: Provide better error reporting.
28991 * cs-parser.jay (interface_base): set our $$ to be interfaces.
28993 * rootcontext.cs (CreateInterface): Handle the case where there
28994 are no parent interfaces.
28996 (CloseTypes): Routine to flush types at the end.
28997 (CreateInterface): Track types.
28998 (GetInterfaces): Returns an array of Types from the list of
28999 defined interfaces.
29001 * typemanager.c (AddUserType): Mechanism to track user types (puts
29002 the type on the global type hash, and allows us to close it at the
29005 2001-08-02 Miguel de Icaza <miguel@ximian.com>
29007 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
29008 RecordInterface instead.
29010 * cs-parser.jay: Updated to reflect changes above.
29012 * decl.cs (Definition): Keep track of the TypeBuilder type that
29013 represents this type here. Not sure we will use it in the long
29014 run, but wont hurt for now.
29016 * driver.cs: Smaller changes to accomodate the new code.
29018 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
29021 * rootcontext.cs (CreateInterface): New method, used to create
29022 the System.TypeBuilder type for interfaces.
29023 (ResolveInterfaces): new entry point to resolve the interface
29025 (CodeGen): Property, used to keep track of the code generator.
29027 2001-07-26 Miguel de Icaza <miguel@ximian.com>
29029 * cs-parser.jay: Add a second production for delegate_declaration
29032 (enum_body): Put an opt_comma here instead of putting it on
29033 enum_body or enum_member_declarations so we can handle trailing
29034 commas on enumeration members. Gets rid of a shift/reduce.
29036 (type_list): Need a COMMA in the middle.
29038 (indexer_declaration): Tell tokenizer to recognize get/set
29040 * Remove old targets.
29042 * Re-add the parser target.
29044 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29046 * cs-parser.jay: Add precendence rules for a number of operators
29047 ot reduce the number of shift/reduce conflicts in the grammar.
29049 2001-07-17 Miguel de Icaza <miguel@ximian.com>
29051 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
29054 Get rid of old crufty code.
29056 * rootcontext.cs: Use this to keep track of the parsed
29057 representation and the defined types available to the program.
29059 * gen-treedump.cs: adjust for new convention.
29061 * type.cs: Split out the type manager, and the assembly builder
29064 * typemanager.cs: the type manager will live here now.
29066 * cil-codegen.cs: And the code generator here.
29068 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
29070 * makefile: Fixed up for easy making.
29072 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29074 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
29077 (unary_expression): Expand pre_increment_expression and
29078 post_decrement_expression to reduce a shift/reduce.
29080 2001-07-11 Simon Cozens
29082 * cs-tokenizer.cs: Hex numbers should begin with a 0.
29084 Improve allow_keyword_as_indent name.
29086 2001-06-19 Miguel de Icaza <miguel@ximian.com>
29088 * Adjustments for Beta2.
29090 2001-06-13 Miguel de Icaza <miguel@ximian.com>
29092 * decl.cs: Added `Define' abstract method.
29093 (InTransit): new property, used to catch recursive definitions.
29095 * interface.cs: Implement `Define'.
29097 * modifiers.cs: Map Modifiers.constants to
29098 System.Reflection.TypeAttribute flags.
29100 * class.cs: Keep track of types and user-defined types.
29101 (BuilderInit): New method for creating an assembly
29102 (ResolveType): New function to launch the resolution process, only
29103 used by interfaces for now.
29105 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
29106 that are inserted into the name space.
29108 2001-06-08 Miguel de Icaza <miguel@ximian.com>
29110 * ARGH. I have screwed up my tree so many times due to the use of
29111 rsync rather than using CVS. Going to fix this at once.
29113 * driver.cs: Objetify driver. Load assemblies, use assemblies to
29116 2001-06-07 Miguel de Icaza <miguel@ximian.com>
29118 * Experiment successful: Use System.Type rather that our own
29121 2001-05-25 Miguel de Icaza <miguel@ximian.com>
29123 * cs-parser.jay: Removed nsAliases from here.
29125 Use new namespaces, handle `using XXX;'
29127 * namespace.cs: Reimplemented namespace handling, use a recursive
29128 definition of the class. Now we can keep track of using clauses
29129 and catch invalid using clauses.
29131 2001-05-24 Miguel de Icaza <miguel@ximian.com>
29133 * gen-treedump.cs: Adapted for all the renaming.
29135 * expression.cs (Expression): this class now has a Type property
29136 which returns an expression Type.
29138 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
29139 `Type', as this has a different meaning now in the base
29141 2001-05-22 Miguel de Icaza <miguel@ximian.com>
29143 * interface.cs, class.cs: Removed from all the sources the
29144 references to signature computation, as we can not do method
29145 signature computation during the parsing time, as we are not
29146 trying to solve at that point distinguishing:
29150 void a (NS.Blah x) {}
29153 Which depending on the context might be valid or not, as we do not
29154 know if Blah is the same thing as NS.Blah at that point.
29156 * Redid everything so the code uses TypeRefs now instead of
29157 Types. TypeRefs are just temporary type placeholders, that need
29158 to be resolved. They initially have a pointer to a string and the
29159 current scope in which they are used. This is used later by the
29160 compiler to resolve the reference to an actual Type.
29162 * DeclSpace is no longer a CIR.Type, and neither are
29163 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
29164 are all DeclSpaces, but no Types.
29166 * type.cs (TypeRefManager): This implements the TypeRef manager,
29167 which keeps track of all the types that need to be resolved after
29168 the parsing has finished.
29170 2001-05-13 Miguel de Icaza <miguel@ximian.com>
29172 * ARGH. We are going to have to store `foreach' as a class rather
29173 than resolving it, as we need to verify error 1579 after name
29174 resolution. *OR* we could keep a flag that says `This request to
29175 IEnumerator comes from a foreach statement' which we can then use
29176 to generate the error.
29178 2001-05-10 Miguel de Icaza <miguel@ximian.com>
29180 * class.cs (TypeContainer.AddMethod): we now add methods to the
29181 MethodGroup instead of the method hashtable.
29183 * expression.cs: Add MethodGroup abstraction, which gets us one
29184 step closer to the specification in the way we handle method
29187 * cs-parser.jay (primary_expression): qualified_identifier now
29188 tried to match up an identifier to a local variable reference or
29189 to a parameter reference.
29191 current_local_parameters is now a parser global variable that
29192 points to the current parameters for the block, used during name
29195 (property_declaration): Now creates an implicit `value' argument to
29198 2001-05-09 Miguel de Icaza <miguel@ximian.com>
29200 * parameter.cs: Do not use `param' arguments as part of the
29201 signature, per the spec.
29203 2001-05-08 Miguel de Icaza <miguel@ximian.com>
29205 * decl.cs: Base class for classes, structs and interfaces. This
29206 is the "Declaration Space"
29208 * cs-parser.jay: Use CheckDef for checking declaration errors
29209 instead of having one on each function.
29211 * class.cs: Factor out some code for handling error handling in
29212 accordance to the "Declarations" section in the "Basic Concepts"
29213 chapter in the ECMA C# spec.
29215 * interface.cs: Make all interface member classes derive from
29216 InterfaceMemberBase.
29218 2001-05-07 Miguel de Icaza <miguel@ximian.com>
29220 * Many things: all interfaces are parsed and generated in
29221 gen-treedump. Support for member variables, constructors,
29222 destructors, properties, constants is there.
29224 Beginning of the IL backend, but very little done, just there for
29227 2001-04-29 Miguel de Icaza <miguel@ximian.com>
29229 * cs-parser.jay: Fix labeled statement.
29231 * cs-tokenizer.cs (escape): Escape " and ' always.
29232 ref_line, ref_name: keep track of the line/filename as instructed
29233 by #line by the compiler.
29236 2001-04-27 Miguel de Icaza <miguel@ximian.com>
29238 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
29239 to match the values in System.CodeDOM.
29241 Divid renamed to Divide.
29243 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
29245 (Statements.set): remove.
29247 * System.CodeDOM/CodeCatchClause.cs: always have a valid
29250 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
29251 falseStatements always have valid values.
29253 * cs-parser.jay: Use System.CodeDOM now.