1 2010-06-29 Marek Safar <marek.safar@gmail.com>
3 * membercache.cs, expression.cs, statement.cs, doc.cs, ecore.cs:
4 Changed FindMembers to allocate a new list only when a filter is
5 used. Saves decent chunk of memory and should save even more in the
6 future when the filter is not used that often.
8 2010-06-28 Marek Safar <marek.safar@gmail.com>
10 * field.cs, property.cs, assign.cs, const.cs, expression.cs,
11 ecore.cs, class.cs, cs-parser.jay, enum.cs: Don't use intermediate
12 structure for simple type fields (saves memory and makes few things
13 simpler). Clean up some hacks mostly for events.
15 2010-06-25 Marek Safar <marek.safar@gmail.com>
17 * statement.cs, cs-parser.jay: Don't create expensive block for
20 2010-06-24 Marek Safar <marek.safar@gmail.com>
22 * statement.cs, report.cs: Rethrow internal error when reporting is
25 * ecore.cs: Check for identical name only when simple name is set.
28 2010-06-24 Marek Safar <marek.safar@gmail.com>
31 * generic.cs, expression.cs, ecore.cs: Added a new type expression
32 for open generic type to pass unbound type arguments to typeof
35 2010-06-24 Marek Safar <marek.safar@gmail.com>
37 * statement.cs: Foreach collection implementation refactoring to
38 search for GetEnumerator more preciselly. Fixes #431453 and more
41 * linq.cs, decl.cs, ecore.cs, delegate.cs: Update methodgroup api.
43 2010-06-23 Marek Safar <marek.safar@gmail.com>
45 * cs-parser.jay: Track more locations.
47 2010-06-22 Marek Safar <marek.safar@gmail.com>
49 * cs-tokenizer.cs, location.cs, cs-parser.jay: Track more locations.
51 2010-06-18 Marek Safar <marek.safar@gmail.com>
53 * cs-tokenizer.cs, anonymous.cs, expression.cs, statement.cs,
54 support.cs, location.cs, cs-parser.jay: Some work on full ast mode.
56 2010-06-18 Marek Safar <marek.safar@gmail.com>
58 * convert.cs, typespec.cs, method.cs: Fixed few more dynamic
61 2010-06-18 Marek Safar <marek.safar@gmail.com>
63 * typemanager.cs, namespace.cs: Report more predefined types and
64 imported types collision types as a warning.
65 Fixes #537414, #601157
67 2010-06-18 Marek Safar <marek.safar@gmail.com>
69 * generic.cs: Overrides base method constraint can use method type
72 * import.cs: Removed redundant cache.
74 2010-06-17 Marek Safar <marek.safar@gmail.com>
76 * generic.cs: Propagate type only inflate downwards.
78 2010-06-17 Marek Safar <marek.safar@gmail.com>
81 * method.cs: Do not reject binary dynamic operators.
83 2010-06-17 Marek Safar <marek.safar@gmail.com>
85 * typespec.cs: Internal types have no generic parameters.
88 2010-06-17 Marek Safar <marek.safar@gmail.com>
91 * cs-parser.jay: Correctly set expression mode for default parameter
94 2010-06-17 Marek Safar <marek.safar@gmail.com>
97 * ecore.cs: Resolve dynamic namespace and keyword collision in the
98 favour of the keyword.
100 2010-06-17 Marek Safar <marek.safar@gmail.com>
102 A fix for bug #614917
103 * convert.cs: Allow more undocumented 0 like values to enum type
106 2010-06-17 Marek Safar <marek.safar@gmail.com>
108 * generic.cs, method.cs: Inflate copied type parameters from base
109 class or explicit interfaces.
111 * convert.cs: Fixed conversion between two type parameters.
114 2010-06-16 Marek Safar <marek.safar@gmail.com>
116 * membercache.cs, convert.cs: Correctly resize an array used by
119 2010-06-15 Marek Safar <marek.safar@gmail.com>
121 A fix for bug #599601
122 * dynamic.cs, ecore.cs: A new flag for dynamic resolver to ignore
123 generated member access left expression.
125 2010-06-16 Marek Safar <marek.safar@gmail.com>
127 * expression.cs: Dispatch dynamic invocation solely on left
130 2010-06-16 Marek Safar <marek.safar@gmail.com>
132 * expression.cs, statement.cs: Always persist explicit cast
133 semantic at expression level.
135 2010-06-15 Marek Safar <marek.safar@gmail.com>
137 * expression.cs, attribute.cs: Enable generic type parameters
140 2010-06-15 Marek Safar <marek.safar@gmail.com>
142 A fix for bug #612146
143 * generic.cs: Don't use fixed array for inflated type parameter
144 interface constraints.
146 2010-06-15 Marek Safar <marek.safar@gmail.com>
148 * typespec.cs: ElementTypeSpec has to use its own ITypeDefinition.
150 * report.cs: Unwrap elements for related symbols reporting.
152 2010-06-15 Marek Safar <marek.safar@gmail.com>
154 A fix for bug #612796
155 * cs-tokenizer.cs: Offset correctly keywords the first character
158 2010-06-15 Marek Safar <marek.safar@gmail.com>
160 A fix for bug #613397
161 * expression.cs: Removed too aggressive object initializers
164 2010-06-15 Marek Safar <marek.safar@gmail.com>
166 * parameter.cs, property.cs, membercache.cs, decl.cs, iterators.cs,
167 anonymous.cs, expression.cs, support.cs, method.cs, pending.cs,
168 class.cs, cs-parser.jay: Simplify parsing of accessors by removing
169 any intermediate steps and fake nodes, also saves few MBs of memory.
171 2010-06-11 Marek Safar <marek.safar@gmail.com>
173 * modifiers.cs, rootcontext.cs, location.cs, cs-parser.jay: More
174 precise modifiers parsing.
176 2010-06-09 Marek Safar <marek.safar@gmail.com>
178 * cs-tokenizer.cs, anonymous.cs, expression.cs, cs-parser.jay:
179 Fixed few shift/reduce conflicts.
181 2010-06-09 Marek Safar <marek.safar@gmail.com>
183 * typemanager.cs, parameter.cs, dynamic.cs, typespec.cs,
184 expression.cs, ecore.cs, cs-parser.jay: Fully parse composed type
185 specifiers and stop using string in AST.
187 2010-06-07 Marek Safar <marek.safar@gmail.com>
189 * typemanager.cs, eval.cs, iterators.cs, anonymous.cs, expression.cs
190 method.cs, class.cs, delegate.cs, cs-parser.jay, driver.cs, visit.cs
191 enum.cs: Hold location of predefined types.
193 2010-06-07 Marek Safar <marek.safar@gmail.com>
195 A fix for bug #610878
196 * pending.cs: Clone cached list before modifying.
198 2010-06-04 Marek Safar <marek.safar@gmail.com>
200 * convert.cs, typespec.cs, expression.cs: Start using array member
201 kind for better conversion checks.
203 * import.cs, report.cs: Report better error message for runtime
206 2010-06-04 Marek Safar <marek.safar@gmail.com>
208 * membercache.cs, convert.cs, nullable.cs, expression.cs: Optimize
209 user defined conversion probing and simplify user conversion for
210 nullabe types. Fixes #610940.
212 2010-06-03 Marek Safar <marek.safar@gmail.com>
214 A fix for bug #610919
215 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
216 parameters for explicit event accessors. Anonymous method capturing
217 won't otherwise work for event implicit parameter.
219 2010-06-02 Marek Safar <marek.safar@gmail.com>
221 A fix for bug #610088
222 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
223 Ignore overrides for base overload resolution as for non-base
224 expressions and convert the best candidate to closest override
227 2010-06-01 Marek Safar <marek.safar@gmail.com>
229 A fix for bug #610139
230 * generic.cs, convert.cs: Recursively check effective base interface
232 2010-06-01 Marek Safar <marek.safar@gmail.com>
234 * statement.cs: Handle nullable types and type parameters in using
235 statement, avoid boxing value types. Also fixes #571010
237 2010-06-01 Marek Safar <marek.safar@gmail.com>
239 * convert.cs, expression.cs: Emit unbox for underlying nullable
242 2010-05-29 Marek Safar <marek.safar@gmail.com>
244 A fix for bug #610126
245 * expression.cs: Don't use branch optimization for types bigger than
248 2010-05-28 Marek Safar <marek.safar@gmail.com>
250 A fix for bug #609088
251 * import.cs: Check private modifier correctly.
253 2010-05-28 Marek Safar <marek.safar@gmail.com>
255 A fix for bug #609049
256 * ecore.cs: Don't ignore override methods when looking for base
259 2010-05-27 Marek Safar <marek.safar@gmail.com>
261 A fix for bugs #608007, #572540, #566130, #476358
263 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
264 More tricky refactoring of implicit linq blocks.
266 2010-05-25 Marek Safar <marek.safar@gmail.com>
268 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
270 2010-05-25 Marek Safar <marek.safar@gmail.com>
272 * context.cs, expression.cs, cs-parser.jay: Don't store current
273 block in This expression (it's too early for linq blocks).
275 2010-05-21 Marek Safar <marek.safar@gmail.com>
277 * expression.cs: Use constrained prefix more broadly to avoid boxing.
279 2010-05-20 Marek Safar <marek.safar@gmail.com>
281 A fix for bug #591149
282 * nullable.cs: Don't double wrap same expression.
284 2010-05-20 Marek Safar <marek.safar@gmail.com>
286 A fix for bug #569827
287 * anonymous.cs: Any issued error in probing mode means no match.
289 2010-05-20 Marek Safar <marek.safar@gmail.com>
291 * expression.cs: Search for base indexer using the closest match
294 2010-05-20 Marek Safar <marek.safar@gmail.com>
296 A fix for bug #572071
297 * method.cs: Set override constraints using unexpanded interface
300 2010-05-20 Marek Safar <marek.safar@gmail.com>
302 A fix for bug #572071
303 * ecore.cs: Include secondary extension method lookup in probing
306 2010-05-19 Marek Safar <marek.safar@gmail.com>
308 A fix for bug #515801
309 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
312 2010-05-19 Marek Safar <marek.safar@gmail.com>
314 A fix for bug #515801
315 * pending.cs: Advance counter correctly.
317 2010-05-19 Marek Safar <marek.safar@gmail.com>
319 A fix for bug #480139
320 * method.cs, pending.cs: Indexer override uses base name.
322 2010-05-19 Marek Safar <marek.safar@gmail.com>
324 A fix for bug #424064
325 * generic.cs: Replace original with inflated type parameter on
328 2010-05-19 Marek Safar <marek.safar@gmail.com>
330 A fix for bug #359733
331 * parameter.cs: Extension attribute can be defined in each assembly.
333 2010-05-18 Marek Safar <marek.safar@gmail.com>
335 A fix for bug #446507
336 * method.cs: Only one method can implement an interface.
338 2010-05-18 Marek Safar <marek.safar@gmail.com>
340 A fix for bug #594905
341 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
342 Typed null can be used as a source for expression methods.
344 2010-05-18 Marek Safar <marek.safar@gmail.com>
346 A fix for bug #606551
347 * namespace.cs: Using directive imports only types and not nested
350 2010-05-17 Marek Safar <marek.safar@gmail.com>
352 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
353 delegate.cs: Member instance is resolved after member overload
354 definitely resolves static/instance property of member expression.
355 Fixes #545047, #358848, #456605, #460016, #603299
357 2010-05-12 Marek Safar <marek.safar@gmail.com>
359 A fix for bug #604981
360 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
361 details for nested anonymous methods stories.
363 2010-05-11 Marek Safar <marek.safar@gmail.com>
365 A fix for bug #604735
366 * namespace.cs: Don't report namespace collision.
368 2010-05-11 Marek Safar <marek.safar@gmail.com>
370 A fix for bug #604748
371 * class.cs, typespec.cs: Search full imported attribute hierarchy
374 2010-05-11 Marek Safar <marek.safar@gmail.com>
376 * namespace.cs: Ignore missing dependencies failure at
379 2010-05-11 Marek Safar <marek.safar@gmail.com>
381 A fix for bug #604640
382 * namespace.cs: Don't resolve using constraints too early.
384 2010-05-11 Marek Safar <marek.safar@gmail.com>
386 A fix for bug #604239
387 * generic.cs: Copy partial type constraints to partial container.
389 2010-05-10 Marek Safar <marek.safar@gmail.com>
391 A fix for bug #557210
392 * import.cs: Relax underlying enum field rules.
394 2010-05-10 Marek Safar <marek.safar@gmail.com>
396 A fix for bug #603476
397 * property.cs: Implement IParametersMember for indexer accessors.
399 2010-05-07 Marek Safar <marek.safar@gmail.com>
401 A fix for bug #601141
402 * class.cs: Update all partial modifiers.
404 2010-05-06 Marek Safar <marek.safar@gmail.com>
406 A fix for bug #601708
407 * method.cs, membercache.cs: Destructors cannot be hidden.
409 2010-05-06 Marek Safar <marek.safar@gmail.com>
411 A fix for bug #602551
412 * class.cs: Resursive reference of type definition is allowed.
414 2010-05-06 Marek Safar <marek.safar@gmail.com>
416 * anonymous.cs: Mutate cached storey instance types too.
418 2010-05-06 Marek Safar <marek.safar@gmail.com>
420 A fix for bug #602443
421 * convert.cs: Explicit enum conversion cannot involve user operators
423 2010-05-05 Miguel de Icaza <miguel@novell.com>
425 * class.cs (TypeContainer.DefineBaseTypes)
426 (TypeContainer.CheckRecursiveDefinition): check for the iface not
427 being null, as we could have failed resolution and crashed;
430 * cs-parser.jay: Productions to catch common mistakes when other
431 punctuation operators are used instead of comma. Fixes 571702
433 2010-05-05 Marek Safar <marek.safar@gmail.com>
435 * anonymous.cs: Mutate correct set of constraints.
437 2010-05-05 Marek Safar <marek.safar@gmail.com>
439 A fix for bug #602842
440 * expression.cs: Resolve all array bound arguments.
442 2010-05-05 Marek Safar <marek.safar@gmail.com>
444 * import.cs: Don't import private fields.
446 2010-04-30 Marek Safar <marek.safar@gmail.com>
448 Partially based on patch by <sami.lamti@gmail.com>
450 * eval.cs, ecore.cs: Fixed eval show methods.
452 2010-04-30 Marek Safar <marek.safar@gmail.com>
454 * generic.cs, delegate.cs: Implement output type inference of
455 methodgroup now when the specification was cleared at least little
458 2010-04-29 Marek Safar <marek.safar@gmail.com>
460 A fix for bug #575611
461 * class.cs: Fix recursive unmanaged recursice sruct check.
463 2010-04-29 Marek Safar <marek.safar@gmail.com>
465 A fix for bug #479776
466 * expression.cs: Implement typeof unbounded nested generic types.
468 2010-04-29 Marek Safar <marek.safar@gmail.com>
470 A fix for bug #474953
471 * class.cs: Fix valid recursive base type definition.
473 2010-04-29 Marek Safar <marek.safar@gmail.com>
475 A fix for bug #421737
476 * convert.cs, expression.cs: A boxing conversion exists from a
477 nullable-type to a reference type, if a boxing conversion exists
478 from the underlying non-nullable-value-type to the reference type.
480 2010-04-29 Marek Safar <marek.safar@gmail.com>
482 A fix for bug #376875
483 * import.cs: Import volatile modifier.
485 2010-04-29 Marek Safar <marek.safar@gmail.com>
487 A fix for bug #372412
488 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
491 2010-04-29 Marek Safar <marek.safar@gmail.com>
493 A fix for bug #568955
494 * statements.cs: Handle recursive scope initializers.
496 2010-04-28 Marek Safar <marek.safar@gmail.com>
498 A fix for bug #566511
499 * anonymous.cs: Always get inflated version of hoisted variable
500 on generic type definition.
502 2010-04-28 Marek Safar <marek.safar@gmail.com>
504 * import.cs, membercache.cs: Relax rules for valid properties.
506 2010-04-28 Marek Safar <marek.safar@gmail.com>
508 * import.cs: Intern arrays used in generic arguments.
510 2010-04-28 Marek Safar <marek.safar@gmail.com>
512 A fix for bug #600398
513 * convert.cs: Actually use effective base type for the comparison.
515 2010-04-28 Marek Safar <marek.safar@gmail.com>
517 A fix for bug #600326
518 * ecore.cs: Pass arity to base member lookup.
520 2010-04-28 Marek Safar <marek.safar@gmail.com>
522 A fix for bug #573385
523 * expression.cs: MemberAccess is of generic type based on right
526 2010-05-28 Marek Safar <marek.safar@gmail.com>
528 * cs-tokenizer.cs: Made tab size configurable.
530 2010-05-27 Marek Safar <marek.safar@gmail.com>
532 * attribute.cs: Ensure Obsolete members are defined before doing
535 2010-05-27 Marek Safar <marek.safar@gmail.com>
537 * visit.cs: Add DOM visitor skeleton.
541 2010-05-27 Marek Safar <marek.safar@gmail.com>
543 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
545 2010-05-27 Marek Safar <marek.safar@gmail.com>
547 * *.cs: Major rewrite of compiler internals to better work with
548 unmodified System.Reflection.Emit. Some of the key changes are
549 - TypeSpec replaces reflection specific System.Type.
550 - All Type(TypeSpec) operations are now done in compiler therefore
551 no dependency on SRE to inflate generic members and types or to
552 query unclosed types.
553 - MemberCache is now the only and full hierarchical topology.
554 - Generic constraints are implemented properly.
555 - And as a bonus compilation is on average 30% faster.
557 2010-04-15 Jb Evain <jbevain@novell.com>
559 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
561 2010-04-12 Marek Safar <marek.safar@gmail.com>
563 * expression.cs, attribute.cs, parameter.cs: More attribute type
566 2010-04-12 Marek Safar <marek.safar@gmail.com>
568 A fix for bug #593342
570 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
571 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
572 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
573 codegen.cs: Add custom attribute encoder to deal with unfinished
574 types and easier corlib bootstrap from its own types.
576 2010-03-26 Marek Safar <marek.safar@gmail.com>
578 * cs-parser.jay: Report invalid constraint types.
580 2010-03-16 Jb Evain <jbevain@novell.com>
582 * Makefile: rename the net_2_1 profile to moonlight.
584 2010-03-11 Marek Safar <marek.safar@gmail.com>
586 * statement.cs, cs-parser.jay: Use correct location for empty
589 2010-03-11 Marek Safar <marek.safar@gmail.com>
591 * cs-parser.jay: Disable Location from expression.
593 * generic.cs: Check constraints for overrides in the parser.
595 2010-03-09 Marek Safar <marek.safar@gmail.com>
597 * cs-parser.jay (GetLocation): Use an expression when available.
599 2010-03-04 Marek Safar <marek.safar@gmail.com>
601 A fix for bug #582579
602 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
604 2010-03-04 Marek Safar <marek.safar@gmail.com>
606 A patch by kornelpal@gmail.com
608 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
609 compiler generated classes sealed by default. Emit and close top
610 level compiler generated classes as well.
612 * support.cs: Use RuntimeHelpers.GetHashCode.
614 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
616 * Makefile: We need to use the internal bootstrapping gmcs for
617 net_2_1_bootstrap too now.
619 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
621 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
623 2010-03-02 Marek Safar <marek.safar@gmail.com>
625 * cs-tokenizer.cs: Missed few locations in previous fix.
627 2010-03-02 Marek Safar <marek.safar@gmail.com>
629 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
630 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
631 Report correct location for operator errors.
633 2010-03-02 Marek Safar <marek.safar@gmail.com>
635 * typemanager.cs (IsDynamicType): Don't check external types when
636 the attribute is not external.
638 2010-02-24 Marek Safar <marek.safar@gmail.com>
640 A fix for bug #582579
641 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
644 2010-02-24 Marek Safar <marek.safar@gmail.com>
646 A fix for bug #581804
647 * ecore.cs: Fixed type comparison.
649 2010-02-08 Miguel de Icaza <miguel@novell.com>
651 * namespace.cs (CompletionGetTypesStartingWith): Do not include
652 private types in the completion results.
654 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
657 2010-02-17 Marek Safar <marek.safar@gmail.com>
659 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
662 2010-02-14 Miguel de Icaza <miguel@novell.com>
664 * eval.cs: Do not do the report printer dance unless the user has
665 set the DescribeTypes feature.
667 2010-02-10 Marek Safar <marek.safar@gmail.com>
669 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
671 2010-02-08 Marek Safar <marek.safar@gmail.com>
673 A fix for bug #577029
674 * anonymous.cs: Fixed TypeBuilder* check.
676 2010-02-06 Miguel de Icaza <miguel@novell.com>
678 * eval.cs (CompileBlock): Also undo if there are problems during
679 semantic analysis, fixes various cases where invalid C# code would
680 be reported, but the internal changes would not be undone.
682 2010-02-03 Miguel de Icaza <miguel@novell.com>
684 * driver.cs: Change the --fatal flag to allow a number to be
685 passed, this ignores the first N fatal errors. Useful to debug
686 errors that do not happen on the first hit.
688 * cs-parser.jay (invocation_expression): accept both the
689 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
690 inside an invocation.
692 * driver.cs: Expose FatalErrors.
694 * eval.cs: Initialize the printer's Fatal property from the
695 Driver's FatalError flag, this allows csharp --fatal to work
698 Add support for calling Describe (typeof (TYPE)) if the expression
701 2010-02-02 Marek Safar <marek.safar@gmail.com>
703 A fix for bug #574991
704 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
707 2010-02-02 Marek Safar <marek.safar@gmail.com>
709 A fix for bug #575986
710 * expression.cs: Don't mutate typeof type definitions.
712 2010-01-28 Marek Safar <marek.safar@gmail.com>
714 * decl.cs: Use only one set of modifiers.
716 2010-01-26 Marek Safar <marek.safar@gmail.com>
718 A fix for bug #573329
719 * eval.cs: Don't disable error reporting completely on silent mode.
721 2010-01-25 Marek Safar <marek.safar@gmail.com>
723 A fix for bug #573312
724 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
725 pointer index of unknown size types greater than 2.
727 2010-01-15 Marek Safar <marek.safar@gmail.com>
729 * *.cs: Use only 1 member kind enum.
731 2010-01-15 Marek Safar <marek.safar@gmail.com>
733 * *.cs: Add event specification.
735 2010-01-14 Marek Safar <marek.safar@gmail.com>
737 * membercache.cs: Extracted from decl.cs.
739 * *.cs: Put more infrastructure in place.
741 2010-01-13 Marek Safar <marek.safar@gmail.com>
743 * *.cs: Add property specification, unused yet.
745 2010-01-13 Marek Safar <marek.safar@gmail.com>
747 * property.cs: Move all property based declarations into a new file.
749 2010-01-13 Marek Safar <marek.safar at gmail.com>
751 * expression.cs (Conditional): Resolve reduced expression.
753 2010-01-13 Marek Safar <marek.safar at gmail.com>
755 * *.cs: Introduced non-generic method specification.
757 2010-01-07 Marek Safar <marek.safar@gmail.com>
759 * method.cs: Move all method based declarations into a new file.
761 2010-01-07 Marek Safar <marek.safar@gmail.com>
763 * *.cs: Extract field specification.
765 2009-12-17 Marek Safar <marek.safar@gmail.com>
767 * field.cs: Extracted from class.cs
769 2009-12-15 Marek Safar <marek.safar@gmail.com>
771 * attribute.cs (GetFixedBuffer): Work on field definition only.
773 2009-12-15 Marek Safar <marek.safar@gmail.com>
775 * *.cs: Clean up NET_4_0 conditional where possible.
777 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
779 support.cs (DynamicType): Assembly property returns the assembly builder.
780 This is required due to how compiler context works in corlib.
782 2009-12-14 Marek Safar <marek.safar@gmail.com>
784 A fix for bug #564376
785 * assign.cs (LocalTemporary): Removed no longer needed special
788 2009-12-11 Marek Safar <marek.safar@gmail.com>
790 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
791 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
792 enum for easier debugging.
794 2009-12-10 Marek Safar <marek.safar@gmail.com>
796 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
799 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
802 2009-12-10 Marek Safar <marek.safar@gmail.com>
804 * cs-parser.jay, statement.cs: Handle parser error in code
807 2009-12-10 Marek Safar <marek.safar@gmail.com>
809 * ecore.cs: Ignore base imported methods when they are already
812 * eval.cs: Handle non-existent keys.
814 * report.cs, driver.cs: Make fatal work with console printer only.
816 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
818 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
820 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
822 * typemanager.cs: Add MakeGenericMethod that checks if the method
823 is really the generic method definition.
825 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
826 to inflate generic methods.
828 2009-12-08 Marek Safar <marek.safar@gmail.com>
830 A fix for bug #561149
831 * anonymous.cs: Use actual type parameters when checking for generic
834 2009-12-08 Marek Safar <marek.safar@gmail.com>
836 A fix for bug #561369
837 * expression.cs (DoNumericPromotion): Fixed typo.
839 2009-12-08 Marek Safar <marek.safar@gmail.com>
841 *.cs: Moving to generics world.
843 cs-parser.jay: Removed current_array_type.
845 2009-12-07 Marek Safar <marek.safar@gmail.com>
847 *.cs: Moving to generics world.
849 2009-12-04 Marek Safar <marek.safar@gmail.com>
851 *.cs: Moving to generics world (day 2).
853 2009-12-03 Marek Safar <marek.safar@gmail.com>
855 *.cs: Moving to generics world.
857 2009-12-02 Marek Safar <marek.safar@gmail.com>
859 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
860 Encode dynamic type attribute for elements where attributes cannot
863 2009-12-01 Marek Safar <marek.safar@gmail.com>
865 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
868 2009-12-01 Marek Safar <marek.safar@gmail.com>
870 A fix for bug #360455
871 * class.cs: Never report a unused warning for generic events to
872 workaround wrong expression type.
874 2009-11-30 Marek Safar <marek.safar@gmail.com>
876 A fix for bug #558305
877 * decl.cs, class.cs: Check partial method definitions using correct
880 2009-11-30 Marek Safar <marek.safar@gmail.com>
882 * argument.cs: Don't cache rarely used dynamic flag.
884 2009-11-27 Marek Safar <marek.safar@gmail.com>
886 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
888 2009-11-27 Marek Safar <marek.safar@gmail.com>
890 * ecore.cs (SimpleName): Removed no longer needed in_transit as
891 Resolve is now non-reentrant (saves ~0.6MB for corlib).
893 2009-11-26 Marek Safar <marek.safar@gmail.com>
895 A fix for bug #545081
896 * decl.cs: Check private nested types of nested types recursively.
898 2009-11-26 Marek Safar <marek.safar@gmail.com>
900 A fix for bug #558305
901 * location.cs: Ignore self referencing #line directive
903 2009-11-26 Marek Safar <marek.safar@gmail.com>
905 A fix for bug #558292
906 * class.cs: Allow single unsafe fixed buffer fields.
908 2009-11-26 Marek Safar <marek.safar@gmail.com>
910 * expression: Optimize few more zero-based operations.
912 2009-11-26 Marek Safar <marek.safar@gmail.com>
914 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
915 avoids boxing of literal values.
917 2009-11-26 Marek Safar <marek.safar@gmail.com>
919 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
920 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
921 codegen.cs: LocatedToken redesing to avoid excessive allocation and
922 boxing (saves ~7MB for corlib). Also fixes presise token location.
924 2009-11-25 Marek Safar <marek.safar@gmail.com>
926 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
929 2009-11-24 Marek Safar <marek.safar@gmail.com>
931 * expression.cs: Lower static array initializer barrier.
933 * support.cs, driver.cs: Share reader buffer.
935 2009-11-23 Marek Safar <marek.safar@gmail.com>
937 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
939 2009-11-23 Marek Safar <marek.safar@gmail.com>
941 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
942 cleanup some obsolete code.
944 2009-11-20 Marek Safar <marek.safar@gmail.com>
946 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
949 2009-11-20 Marek Safar <marek.safar@gmail.com>
951 * *.cs: Resolved expressions are never resolved again, this helps to
952 uncover some not easy to find bugs and improve the performance.
954 2009-11-19 Marek Safar <marek.safar@gmail.com>
956 * *.cs: Made constant expressions fully compatible with any other
959 2009-11-19 Marek Safar <marek.safar@gmail.com>
961 * *.cs: DoResolve is a worker method and has to be protected.
963 2009-11-18 Marek Safar <marek.safar@gmail.com>
965 * *.cs: More context specific handling.
967 2009-11-17 Marek Safar <marek.safar@gmail.com>
969 * *.cs: More context specific handling.
971 2009-11-16 Marek Safar <marek.safar@gmail.com>
973 * dynamic.cs, class.cs: Removed few fixed user types conversions.
975 * symbolwriter.cs: Uses public ILOffset.
977 2009-11-13 Marek Safar <marek.safar@gmail.com>
979 A fix for bug #553650
980 * generic.cs: Another missing TypeToCoreType, still too many to fix.
982 2009-11-13 Marek Safar <marek.safar@gmail.com>
984 A fix for bug #555170
986 * class.cs, delegate.cs, enum.cs: Constants have to be available
987 for parameters resolve.
989 2009-11-12 Marek Safar <marek.safar@gmail.com>
991 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
994 2009-11-12 Marek Safar <marek.safar@gmail.com>
996 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
997 with a statically known candidate set.
999 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
1001 * generic.cs: Made type inflation for generic constraint checks
1002 recursive. This fixes BGO #553655.
1004 2009-11-11 Marek Safar <marek.safar@gmail.com>
1006 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
1009 2009-11-10 Marek Safar <marek.safar@gmail.com>
1011 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
1012 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
1013 attribute.cs: Add some dynamic error checking.
1015 2009-11-07 Marek Safar <marek.safar@gmail.com>
1017 A fix for bug #553465
1019 * expression.cs: Fixed mixed version of expression tree anonymous
1022 2009-11-06 Marek Safar <marek.safar@gmail.com>
1024 A fix for bug #553031
1026 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
1027 expression tree version of anonymous type with members declaration.
1029 2009-11-05 Marek Safar <marek.safar@gmail.com>
1031 * parameter.cs: Handle nullable parameter default expression.
1033 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
1034 class.cs, attribute.cs: Check for wrong dynamic arguments.
1036 2009-11-05 Marek Safar <marek.safar@gmail.com>
1038 * statement.cs: Dynamic statements.
1040 2009-11-04 Marek Safar <marek.safar@gmail.com>
1042 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
1043 Compound assignments over dynamic type.
1045 2009-11-03 Marek Safar <marek.safar@gmail.com>
1047 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
1048 constructor arguments.
1050 2009-10-30 Marek Safar <marek.safar@gmail.com>
1052 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
1053 codegen.cs: Unary mutator on dynamic member access expression.
1055 2009-10-29 Marek Safar <marek.safar@gmail.com>
1057 A fix for bug #550580
1058 * convert.cs: Don't eliminate explicit precission casts.
1060 2009-10-28 Marek Safar <marek.safar@gmail.com>
1062 A fix for bug #550404
1064 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
1065 expression.cs, statement.cs, ecore.cs: Quote any nested expression
1068 2009-10-27 Marek Safar <marek.safar@gmail.com>
1070 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
1073 * class.cs: Allow nullable binary user operators.
1075 2009-10-26 Marek Safar <marek.safar@gmail.com>
1077 * expression.cs: Move binary expression optimization at the end of
1080 2009-10-23 Marek Safar <marek.safar@gmail.com>
1082 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
1083 Separate NullConstant from NullLiteral.
1085 2009-10-23 Marek Safar <marek.safar@gmail.com>
1087 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
1088 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
1089 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
1090 ModuleContainer. Add common unclosed member check routine.
1092 2009-10-22 Marek Safar <marek.safar@gmail.com>
1094 * argument.cs: Use literal flag for real literals only.
1096 * dynamic.cs: Use correct return type for custom delegates.
1098 2009-10-22 Marek Safar <marek.safar@gmail.com>
1100 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
1103 2009-10-22 Marek Safar <marek.safar@gmail.com>
1105 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
1107 2009-10-21 Marek Safar <marek.safar@gmail.com>
1109 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
1112 2009-10-21 Marek Safar <marek.safar@gmail.com>
1114 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
1117 2009-10-20 Marek Safar <marek.safar@gmail.com>
1119 * argument.cs, dynamic.cs, expression.cs: Latest API update.
1121 2009-10-19 Marek Safar <marek.safar@gmail.com>
1123 * typemanager.cs, expression.cs: Dynamic array initializer.
1125 2009-10-16 Marek Safar <marek.safar@gmail.com>
1127 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
1130 2009-10-16 Marek Safar <marek.safar@gmail.com>
1132 A fix for bug #493523, #507067
1133 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
1134 standard nullable conversion using underlying standard conversion
1135 and not full conversion.
1137 2009-10-15 Marek Safar <marek.safar@gmail.com>
1139 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
1140 type in VerifyArgumentsCompat.
1142 2009-10-15 Marek Safar <marek.safar@gmail.com>
1144 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1145 Reject variable used with type arguments.
1147 2009-10-14 Marek Safar <marek.safar@gmail.com>
1149 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
1150 Implement dynamic expressions assignment.
1152 2009-10-14 Marek Safar <marek.safar@gmail.com>
1154 * expression.cs: Build underlying expression when resolving unary
1157 2009-10-14 Marek Safar <marek.safar@gmail.com>
1159 * expression.cs: Emit enum array initializer using binary blob.
1161 2009-10-08 Marek Safar <marek.safar@gmail.com>
1163 * typemanager.cs, constant.cs: Optimize decimal constants which fit
1166 2009-10-07 Marek Safar <marek.safar@gmail.com>
1168 * typemanager.cs: Reset object_type.
1170 * assign: Made SimpleAssign public.
1172 2009-10-06 Marek Safar <marek.safar@gmail.com>
1174 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
1175 invocation assembly to IsThisOrFriendAssembly.
1177 2009-10-05 Marek Safar <marek.safar@gmail.com>
1179 * expression.cs: Equality comparison of generic parameter with
1182 2009-10-05 Marek Safar <marek.safar@gmail.com>
1184 A fix for bug #543570
1185 * generic.cs: Import predefined constraints correctly.
1187 2009-10-02 Marek Safar <marek.safar@gmail.com>
1189 * ecore.cs: Don't crash on overloads with optional paremeters where
1190 arguments count overflows.
1192 * parameter.cs: Import optional parameter constants using optional
1195 2009-10-01 Marek Safar <marek.safar@gmail.com>
1197 * Makefile: Default is gmcs compiler.
1199 2009-10-01 Marek Safar <marek.safar@gmail.com>
1201 * cs-parser.jay: Fixed few NRE.
1203 2009-10-01 Marek Safar <marek.safar@gmail.com>
1205 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
1207 2009-09-30 Marek Safar <marek.safar@gmail.com>
1209 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
1210 ShimExpression, ImplicitCast.
1212 2009-09-30 Marek Safar <marek.safar@gmail.com>
1214 A fix for bug #542959
1215 * delegate.cs: Emit correct delegate instance variable when there
1216 are static and non-static overloads.
1218 2009-09-29 Marek Safar <marek.safar@gmail.com>
1220 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1221 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1223 2009-09-28 Marek Safar <marek.safar@gmail.com>
1225 A fix for bug #542487
1226 * ecore.cs: Resolve extension methods hidden by properties.
1228 2009-09-25 Marek Safar <marek.safar@gmail.com>
1230 * expression.cs, ecore.cs: More dynamic binary expressions.
1232 2009-09-22 Marek Safar <marek.safar@gmail.com>
1234 * nullable.cs, expression.cs: Fixed null lifted conversion for
1235 bitwise enum operations.
1237 2009-09-22 Marek Safar <marek.safar@gmail.com>
1239 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1240 values in checked context.
1242 2009-09-22 Marek Safar <marek.safar@gmail.com>
1244 * expression.cs, ecore.cs: Fixed array index constant conversion.
1246 2009-09-20 Miguel de Icaza <miguel@novell.com>
1248 * expression.cs: Do not crash when MemberLookup returns something
1249 that is not a MemberExpr here. Report error 582 instead.
1253 2009-09-18 Marek Safar <marek.safar@gmail.com>
1255 * decl.cs, class.cs: Check protected property accessors.
1257 2009-09-18 Marek Safar <marek.safar@gmail.com>
1259 * dynamic.cs, assign.cs: Dynamic compound assignment.
1261 2009-09-17 Marek Safar <marek.safar@gmail.com>
1263 * expression.cs: Fixed compound assignment explicit conversion.
1265 2009-09-17 Marek Safar <marek.safar@gmail.com>
1267 * expression.cs, ecore.cs: Cannot infer variables from method group.
1269 2009-09-16 Marek Safar <marek.safar@gmail.com>
1271 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1272 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1273 codegen.cs: Dynamic binary operations scaffolding.
1275 2009-09-15 Marek Safar <marek.safar@gmail.com>
1277 * expression.cs: Fixes nullable promotion for enum type variables.
1279 2009-09-11 Marek Safar <marek.safar@gmail.com>
1281 * driver.cs, dynamic.cs: Reset more static variables.
1283 2009-09-11 Marek Safar <marek.safar@gmail.com>
1285 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1286 driver.cs: Introduced Expression::MakeExpression.
1288 2009-09-11 Marek Safar <marek.safar@gmail.com>
1290 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1292 2009-09-09 Marek Safar <marek.safar@gmail.com>
1294 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1297 2009-09-09 Marek Safar <marek.safar@gmail.com>
1299 A fix for bug #518707
1300 * expression.cs (Is): Optimize only generic parameter type
1301 expression probing value type generic parameter.
1303 2009-09-09 Marek Safar <marek.safar@gmail.com>
1305 A fix for bug #532571
1306 * ecore.cs: Check for simple name type arguments used with
1309 2009-09-08 Marek Safar <marek.safar@gmail.com>
1311 A fix for bug #497421
1312 * generic.cs (CheckConstraint): Don't use buildin types to check for
1313 parameterless constructor.
1315 2009-09-08 Marek Safar <marek.safar@gmail.com>
1317 A fix for bug #537402
1318 * generic.cs (CheckConstraint): Correctly inflate generic type
1319 arguments when checking generic method.
1321 2009-09-08 Marek Safar <marek.safar@gmail.com>
1323 A fix for bug #536463
1324 * decl.cs (AddToContainer): Don't report collision between explicit
1325 and parameterless non-explicit members.
1327 2009-09-08 Marek Safar <marek.safar@gmail.com>
1329 * eval.cs: Reset more static stuff.
1331 2009-09-07 Marek Safar <marek.safar@gmail.com>
1333 A fix for bug #324625
1334 * expression.cs, ecore.cs: Create nested generic type expression
1335 using declaring and not current type.
1337 2009-09-07 Marek Safar <marek.safar@gmail.com>
1339 * *.cs: Changed Report class to accept various output printers and
1340 be an instance class. An expression resolver can now use different
1341 message reporter for each call and Report.Error can safely throw
1342 an exception. Part of ongoing work to turn mcs into proper library.
1344 2009-09-04 Marek Safar <marek.safar@gmail.com>
1346 * statement.cs, ecore.cs: Removed error reporting from emit code.
1348 2009-09-04 Marek Safar <marek.safar@gmail.com>
1350 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1352 2009-09-03 Marek Safar <marek.safar@gmail.com>
1354 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1355 parser checks out of constructors.
1357 2009-09-02 Marek Safar <marek.safar@gmail.com>
1359 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1361 2009-09-02 Marek Safar <marek.safar@gmail.com>
1363 A fix for bug #535448
1364 * anonymous.cs, class.cs: Copy return label between all contexts.
1366 2009-09-02 Marek Safar <marek.safar@gmail.com>
1368 A fix for bug #535395
1369 * namespace.cs: Resolve context can be null.
1371 2009-08-25 Marek Safar <marek.safar@gmail.com>
1373 A fix for bug #533912
1374 * generic.cs: Use correct context for constraints resolving.
1376 2009-08-25 Marek Safar <marek.safar@gmail.com>
1378 A fix for bug #532630
1379 * driver.cs: Trim conditional symbols.
1381 2009-08-25 Marek Safar <marek.safar@gmail.com>
1383 * context.cs: New file.
1385 * *.exe.sources, *.csproj: Updated.
1387 2009-08-25 Marek Safar <marek.safar@gmail.com>
1389 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1390 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1391 IMembercontext, some small cleanups.
1393 2009-08-24 Marek Safar <marek.safar@gmail.com>
1395 * *.cs: Split ResolveContext and EmitContext.
1397 2009-08-24 Marek Safar <marek.safar@gmail.com>
1399 * *.cs: Only ResolveContext implements IMemberContext.
1401 2009-08-21 Marek Safar <marek.safar@gmail.com>
1403 * *.cs: Renamed IResolveContext to IMemberContext.
1405 2009-08-21 Marek Safar <marek.safar@gmail.com>
1407 * *.cs: Detached ResolveContext from EmitContext.
1409 2009-08-21 Marek Safar <marek.safar@gmail.com>
1411 * codegen.cs: Moved flow-analysis to BlockContext.
1413 2009-08-21 Marek Safar <marek.safar@gmail.com>
1415 * *.cs: Detached BlockContext from EmitContext.
1417 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1419 * statement.cs: avoid nullref when the return value of GetEnumerator()
1420 does not contain any MoveNext() method.
1422 2009-08-19 Marek Safar <marek.safar@gmail.com>
1424 * *.cs: Removed IResolveContext::GenericDeclContainer.
1426 2009-08-19 Marek Safar <marek.safar@gmail.com>
1428 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1430 2009-08-19 Marek Safar <marek.safar@gmail.com>
1432 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1433 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1435 2009-08-18 Marek Safar <marek.safar@gmail.com>
1437 * *.cs: Removed boolean fields from EmitContext.
1439 2009-08-18 Marek Safar <marek.safar@gmail.com>
1441 * *.cs: Add IResolveContext::IsStatic.
1443 2009-08-18 Marek Safar <marek.safar@gmail.com>
1445 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1447 2009-08-17 Marek Safar <marek.safar@gmail.com>
1449 * *.cs: Removed DeclContainer from EmitContext.
1451 2009-08-17 Marek Safar <marek.safar@gmail.com>
1453 * *.cs: Add IResolveContext::CurrentTypeParameters.
1455 2009-08-14 Marek Safar <marek.safar@gmail.com>
1457 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1459 2009-08-14 Marek Safar <marek.safar@gmail.com>
1461 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1462 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1464 2009-08-13 Marek Safar <marek.safar@gmail.com>
1466 * decl.cs: Look in PartialContainer for parent type parameters.
1468 2009-08-13 Marek Safar <marek.safar@gmail.com>
1470 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1471 codegen.cs: Add IResolveContext::LookupTypeParameter.
1473 2009-08-13 Marek Safar <marek.safar@gmail.com>
1475 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1476 Moved resolved logic from Emit to Resolve.
1478 2009-08-13 Marek Safar <marek.safar@gmail.com>
1480 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1481 codegen.cs: Reworked atttributes handling of ResolveContext.
1483 2009-08-12 Marek Safar <marek.safar@gmail.com>
1485 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1486 LookupNamespaceOrType to ResolveContext.
1488 2009-08-12 Marek Safar <marek.safar@gmail.com>
1490 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1491 class.cs: Removed unused parameters and methods.
1493 2009-08-11 Marek Safar <marek.safar@gmail.com>
1495 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1496 codegen.cs: Finding the best common type of a set of expressions for
1499 2009-08-07 Marek Safar <marek.safar@gmail.com>
1501 * dynamic.cs, expression.cs: More dynamic conversions.
1503 2009-08-06 Miguel de Icaza <miguel@novell.com>
1505 * generic.cs: This loop was incorrect, it was increment ii, but
1506 checking for `i'. This was a change introduced to fix #327497,
1509 * class.cs: Catch another case for cs0533 error, fixes #324782.
1511 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1513 * typemanager.cs (GetGenericArguments): SRE returns null for
1514 generic methods on type builder instances if they are not generic
1515 themselves. For example, for Foo<int>::Bar() it returns null, but
1516 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1518 2009-08-05 Marek Safar <marek.safar@gmail.com>
1520 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1521 delegate.cs: Work on dynamic binding.
1523 2009-08-04 Marek Safar <marek.safar@gmail.com>
1525 A second fix for bug #525342
1526 * class.cs: Attach partial method attributes to method
1529 2009-08-03 Marek Safar <marek.safar@gmail.com>
1531 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1534 * rootcontext.cs: Default to langversion v4.
1536 2009-08-03 Marek Safar <marek.safar@gmail.com>
1538 * pending.cs: Check return type before member info is set.
1540 2009-08-03 Marek Safar <marek.safar@gmail.com>
1542 * anonymous.cs: Fully initialize generic hoisted field expression.
1544 2009-08-02 Miguel de Icaza <miguel@novell.com>
1546 * cs-parser.jay: Flag variables declared on the interactive shell
1547 as used to prevent the 168 warning about local variable not being
1550 2009-07-31 Marek Safar <marek.safar@gmail.com>
1552 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1553 attribute.cs: Emit dynamic export attribute.
1555 2009-07-30 Marek Safar <marek.safar@gmail.com>
1557 * expression.cs: More verifier work.
1559 2009-07-29 Marek Safar <marek.safar@gmail.com>
1561 * nullable.cs: Fixed SRE crash during corlib compilation.
1563 2009-07-29 Marek Safar <marek.safar@gmail.com>
1565 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1566 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1567 More TypeManager.TypeToCoreType needed.
1569 2009-07-29 Marek Safar <marek.safar@gmail.com>
1571 * anonymous.cs: Update after recent SRE fixes.
1573 2009-07-28 Marek Safar <marek.safar@gmail.com>
1575 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1576 version of GetFieldHandle for fields of generic types.
1578 2009-07-27 Marek Safar <marek.safar@gmail.com>
1580 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1581 ecore.cs: Add TypeManager.IsDynamicType,
1582 PredefinedAttributes.Dynamic.
1584 2009-07-27 Marek Safar <marek.safar@gmail.com>
1586 A fix for bug #415375
1587 * expression.cs: Fixed object and reference type parameter
1590 2009-07-27 Marek Safar <marek.safar@gmail.com>
1592 A fix for bug #525342
1593 * class.cs: Attach partial method attributes to method
1596 2009-07-24 Marek Safar <marek.safar@gmail.com>
1598 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1601 2009-07-24 Marek Safar <marek.safar@gmail.com>
1603 * anonymous.cs (MutateField): Add imported types handling.
1605 2009-07-23 Marek Safar <marek.safar@gmail.com>
1607 * expression.cs, delegate.cs: Moved arguments resolve into their
1608 counterparts expressions. Removed argument resolve from
1609 CollectionElementInitializer.
1611 2009-07-23 Marek Safar <marek.safar@gmail.com>
1613 A fix for bug #523683
1614 * convert.cs, delegate.cs: Use common overload mechanism for method
1615 group conversion check.
1617 2009-07-22 Marek Safar <marek.safar@gmail.com>
1619 A fix for bug #523899
1620 * generics.cs: Exact type inference with other bound types.
1622 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1624 Don't complain when the same type is implemented by the output
1625 assembly as well as multiple referenced assemblies
1626 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1627 'must_be_unique' flag.
1628 (GlobalRootNamespace): Update to changes.
1629 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1630 already have a type in hand.
1632 2009-07-22 Marek Safar <marek.safar@gmail.com>
1634 * expression.cs: More verifier instrumentation.
1636 * statement.cs: Do proper throw expression conversion.
1638 2009-07-22 Marek Safar <marek.safar@gmail.com>
1640 A fix for bug #522789
1641 * expression.cs: Mutate invocation return type.
1643 2009-07-16 Marek Safar <marek.safar@gmail.com>
1645 * anonymous.cs: Split assignable and readonly generated variable
1648 2009-07-16 Marek Safar <marek.safar@gmail.com>
1650 A fix for bug #521671
1651 * statement.cs: Fixed crash when checking missing type.
1653 2009-07-16 Marek Safar <marek.safar@gmail.com>
1655 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1656 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1657 class.cs, driver.cs: Work on dynamic binding.
1659 * dynamic.cs: New file.
1661 * *.sources, *.proj: Updated.
1663 2009-07-15 Marek Safar <marek.safar@gmail.com>
1665 * expression.cs (Conditional): Avoid double Resolve.
1667 2009-07-13 Marcus Griep <marcus@griep.us>
1669 * ecore.cs: Fix obscure bug with resolving members of interfaces
1670 that hide parent interface members. Fixes bug #444388 and corrects
1673 2009-07-13 Marek Safar <marek.safar@gmail.com>
1675 * expression.cs (LocalVariableReference): Bounce resolve.
1677 2009-07-10 Marek Safar <marek.safar@gmail.com>
1679 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1680 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1683 * support.cs: New dynamic type wrapper.
1685 2009-07-08 Marek Safar <marek.safar@gmail.com>
1687 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1688 typed local variable.
1690 2009-07-06 Marek Safar <marek.safar@gmail.com>
1692 A fix for bug #519005
1693 * anonymous.cs: Use null_type as no return type placeholder.
1695 2009-07-02 Marek Safar <marek.safar@gmail.com>
1697 * generic.cs: Handle type inference of identical type parameters
1698 with different bounds.
1700 2009-07-01 Marek Safar <marek.safar@gmail.com>
1702 * expression.cs, class.cs: Events variance.
1704 * cs-parser.jay: Interface events error messages.
1706 2009-07-01 Marek Safar <marek.safar@gmail.com>
1708 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1710 2009-06-29 Marek Safar <marek.safar@gmail.com>
1712 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1713 parameter expression can be value-type New.
1715 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1717 2009-06-26 Marek Safar <marek.safar@gmail.com>
1719 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1720 Implemented C# 4.0 named arguments.
1722 2009-06-24 Marek Safar <marek.safar@gmail.com>
1724 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1725 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1726 parameter modifier. Also fixes bug #515497.
1728 2009-06-24 Marek Safar <marek.safar@gmail.com>
1730 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1731 arguments expression to be implemented.
1733 *.sources: Add argument.cs
1735 2009-06-23 Marek Safar <marek.safar@gmail.com>
1737 * parameter.cs: Moved GetParameterIndexByName to base class.
1739 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1740 unused AType. Use argument's version of GetExpressionTree.
1742 2009-06-22 Marek Safar <marek.safar@gmail.com>
1744 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1747 2009-06-17 Marek Safar <marek.safar@gmail.com>
1749 A fix for bug #514096
1750 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1752 2009-06-17 Marek Safar <marek.safar@gmail.com>
1754 * expression.cs: The first multi-dimensional array nested array
1755 initializers was not checked.
1757 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1759 2009-06-17 Marek Safar <marek.safar@gmail.com>
1761 A fix for bug #513400
1762 * nullable.cs (EmitEquality): Operands emit could be simplified for
1763 built-in types when we now emit user operators differently.
1765 2009-06-16 Marek Safar <marek.safar@gmail.com>
1767 * ecore.cs: Report inaccessible delegate methods correctly.
1769 2009-06-16 Marek Safar <marek.safar@gmail.com>
1771 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1772 cs-parser.jay: Implemented C# 4.0 optional parameters.
1774 2009-06-16 Marek Safar <marek.safar@gmail.com>
1776 * driver.cs: Removed broken DefineManifestResource.
1778 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1780 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1781 Use $(BOOTSTRAP_PROFILE) instead.
1783 2009-06-12 Jb Evain <jbevain@novell.com>
1785 * rootcontext.cs: add a Platform field.
1786 * driver.cs: handle /platform.
1787 * codegen.cs: pass the proper flags according to
1788 the platform when saving the assembly.
1790 2009-06-11 Marek Safar <marek.safar@gmail.com>
1792 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1793 Add optional parameters grammar.
1795 2009-06-10 Marek Safar <marek.safar@gmail.com>
1797 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1798 driver.cs: Split lang version and metadata version.
1800 2009-06-10 Marek Safar <marek.safar@gmail.com>
1802 * decl.cs: Better overload ctor collision error message.
1804 2009-06-05 Jb Evain <jbevain@novell.com>
1806 * driver.cs (EmbededResource): avoid using an internal method
1807 in gmcs to embed manifest resources.
1809 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1811 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1812 the compiler from older mono versions (like moon's bots)
1814 2009-06-04 Marek Safar <marek.safar@gmail.com>
1816 * namespace.cs (LookupTypeReflection): Ignore collisions between
1819 2009-06-04 Marek Safar <marek.safar@gmail.com>
1821 * codegen.cs: Enabled generic type forwarders.
1823 2009-06-04 Marek Safar <marek.safar@gmail.com>
1825 * dmcs.*: Add another version of SRE compiler.
1827 2009-06-03 Marek Safar <marek.safar@gmail.com>
1829 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1830 generic-mcs.cs: Fixed variant type conversions.
1832 2009-06-02 Marek Safar <marek.safar@gmail.com>
1834 A fix for bug #507863
1835 * codegen.cs: Fixes a crash on invalid string value attribute.
1837 2009-06-01 Marek Safar <marek.safar@gmail.com>
1839 A fix for bug #508334
1840 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1841 cs-parser.jay: Fully import __arglist modifier.
1843 2009-05-29 Marek Safar <marek.safar@gmail.com>
1845 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1846 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1847 actually work with closed generic types.
1849 2009-05-27 Alan McGovern <amcgovern@novell.com>
1851 * class.cs, decl.cs, delegate.cs, parameter.cs:
1852 Fix the build by replacing the use of 'var' with the actual type.
1854 2009-05-27 Marek Safar <marek.safar@gmail.com>
1856 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1857 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1860 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1863 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1864 Marek Safar <marek.safar@gmail.com>
1866 A fix for bug #377509
1867 * parameter.cs: Use predefined and not empty name for implicit
1870 2009-05-21 Marek Safar <marek.safar@gmail.com>
1872 * class.cs: Don't report wrong warnings for event fields.
1874 2009-05-21 Marek Safar <marek.safar@gmail.com>
1876 A fix for bug #504667
1877 * class.cs: Check for static class using parent container instead of
1880 2009-05-08 Marek Safar <marek.safar@gmail.com>
1882 A fix for bug #496922
1883 * expression.cs: Always use temporary variable when using object
1886 2009-04-28 Marek Safar <marek.safar@gmail.com>
1888 A fix for bug #495112
1889 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1892 2009-04-27 Miguel de Icaza <miguel@novell.com>
1894 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1896 2009-04-24 Miguel de Icaza <miguel@novell.com>
1898 * complete.cs: No idea how gonzalo got a null in the list, but
1901 2009-04-24 Miguel de Icaza <miguel@novell.com>
1903 * complete.cs (CompletionElementInitializer): New completion class
1904 to support completing inside a C# 3 element initializer, so this
1905 allows completion for Silverlight situations where it is very
1908 new TextBlock () { Fo<TAB>
1910 (CompletionSimpleName): Expose the prefix that was
1911 passed to the simple name.
1913 * cs-parser.jay (object_or_collection_initializer): Add support
1914 for element_initializers.
1916 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1917 special case completion expressions as this method aggressively
1918 collects data before it operates, and errors were being thrown
1919 earlier than we were able to complete.
1921 2009-04-23 Miguel de Icaza <miguel@novell.com>
1923 * eval.cs: Make getcompletions silent and enable debugging output
1924 if the -v option is passed.
1926 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1927 Consider looking up the namespace that matches the prefix being
1930 This is part of the support for allowing completions like:
1931 `System.Co<TAB>' to complete to System.Console.
1933 * complete.cs (CompletionSimpleName.AppendResults): Make this
1936 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1938 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1939 COMPLETE_COMPLETION as internal.
1941 2009-04-17 Miguel de Icaza <miguel@novell.com>
1943 * complete.cs: Include namespace resolution in simple names as
1944 well as global types and types in the using scope in the
1947 * namespace.cs: Supporting infrastrcture to provide completions
1948 based on the current using scope.
1950 * eval.cs: Introduce an entry point that allows for initialization
1951 to return a list of the files passed on the command line.
1953 2009-04-14 Marek Safar <marek.safar@gmail.com>
1955 A fix for bug #494243
1956 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1958 2009-04-13 Marek Safar <marek.safar@gmail.com>
1960 A fix for bug #493887
1961 * statement.cs: Don't skip string multi-section with default or
1962 null label when populating string hashtable.
1964 2009-04-06 Marek Safar <marek.safar@gmail.com>
1966 A fix for bug #492329
1967 * expression.cs (New): Load variable when assigning type parameter
1970 2009-04-06 Marek Safar <marek.safar@gmail.com>
1972 A fix for bug #488960
1973 * decl.cs: Compare MVAR types using non-null values.
1975 2009-03-27 Marek Safar <marek.safar@gmail.com>
1977 * typemanager.cs, expression.cs: Removed unused nullable checks.
1979 2009-03-27 Marek Safar <marek.safar@gmail.com>
1981 * *.cs: Removed some gmcs conditionals.
1983 2009-03-26 Marek Safar <marek.safar@gmail.com>
1985 * generic.cs, support.cs: Moved generics stuff out of support.cs
1987 2009-03-24 Marek Safar <marek.safar@gmail.com>
1989 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1992 2009-03-23 Marek Safar <marek.safar@gmail.com>
1994 * attribute.cs: Consider all members for error reporting when
1995 checking named arguments.
1997 2009-03-23 Marek Safar <marek.safar@gmail.com>
1999 A fix for bug #487625
2000 * namespace.cs: Use a warning for all predefined type conflicts.
2002 2009-03-23 Marek Safar <marek.safar@gmail.com>
2004 A fix for bug #485706
2005 * statement.cs: Explicitly type catch type argument to pass verifier
2008 2009-03-22 Miguel de Icaza <miguel@novell.com>
2010 Initial support to provide code completion facilities to consumers
2011 of the evaluator API.
2013 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
2014 support the completion engine. When we reach the end of the
2015 input stream instead of returning EOF, when this flag is true the
2016 tokenizer instead produces:
2018 One GENERATE_COMPLETION token: this token then must be
2019 handled in the grammar at every point where the user
2020 would likely request a completion.
2022 As many COMPLETE_COMPLETION tokens as necessary. These
2023 tokens are generated to assist the parser in unwinding and
2024 producing a valid parse tree.
2026 The parser rules do not have to be perfect, the parser needs to be
2027 augmented with judicious use of GENERATE_COMPLETION tokens to
2028 improve the areas where we can provide completion and the parser
2029 needs to add support for COMPLETE_COMPLETION tokens in productions
2032 It is common to not have enough support for COMPLETE_COMPLETION
2033 under certain rules and that even if we generated the
2034 GENERATE_COMPLETION token that the resulting tree will be invalid
2035 due to the missing rules that support COMPLETE_COMPLETION.
2037 The final EOF token is produced by having the parser notify the
2038 tokenizer when it reaches the root production that the next token
2041 * support.cs (CompletionResult): New Exception. This exception
2042 is thrown to return the completion results when one of the special
2043 completion expressions is reached.
2045 This exception is thrown by the completing ExpressionStatements
2046 classes that live in complete.cs
2048 * complete.cs (CompletingExpression): a new base class for
2049 completing expressions. This derives from the
2050 ExpressionStatement class and not from Expression as it allows
2051 completion to happen not only where expressions are expected in
2052 the grammar, but also where statements are expected.
2054 (CompletionSimpleName): A new class used to provide completions
2055 for SimpleNames. This currently only resolves to local
2056 variables from the evaluator context (GetVars call).
2058 (CompletionMemberAccess): Implements support for completing member
2061 * cs-parser.jay: Add support for completion in a few places.
2063 * eval.cs (GetCompletions): New public API for the evaluator that
2064 returns a list of possible completions given the input. The
2065 return value is an array of completions
2067 * anonymous.cs (Compatible): If the exception thrown from the
2068 resolved expression is a CompletionResult exception let that one
2069 through instead of printing a diagnostic error in the try/catch.
2071 2009-03-22 Miguel de Icaza <miguel@novell.com>
2075 * driver.cs (Main): Use Environment.Exit to quit quickly and
2076 prevent the compiler from doing the usual wait for helper thread
2079 This is to prevent a slowdown that was reported by Gonzalo on
2082 2009-03-19 Marek Safar <marek.safar@gmail.com>
2084 * ecore.cs: Load build-in types directly instead of accessing
2087 2009-03-18 Marek Safar <marek.safar@gmail.com>
2089 * ecore.cs: Always use unbox.any when available.
2091 2009-03-18 Marek Safar <marek.safar@gmail.com>
2093 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
2095 2009-03-17 Marek Safar <marek.safar@gmail.com>
2097 * generic.cs: Removed obsolete version of type inference.
2099 2009-03-16 Marek Safar <marek.safar@gmail.com>
2101 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
2102 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
2103 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
2104 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
2106 2009-03-11 Marek Safar <marek.safar@gmail.com>
2108 A fix for bug #482996
2109 * anonymous.cs: Make sure we are not infering return type when
2110 checking type compatibility.
2112 2009-03-11 Marek Safar <marek.safar@gmail.com>
2114 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
2115 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
2116 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
2117 attributes in their own structure. Needed when accessing their
2118 properties before they are resolved.
2120 2009-03-09 Marek Safar <marek.safar@gmail.com>
2122 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
2123 hashtable (~10x faster).
2125 * driver.cs: Removed wrong Reset.
2127 2009-03-08 Marek Safar <marek.safar@gmail.com>
2129 * class.cs: Use correct common base type for unmanaged delayed
2132 * rootcontext.cs: Wrap unhandled exception.
2134 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
2136 Make SeekableStreamReader self-tuning and arbitrarily seekable
2137 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
2139 (SeekableStreamReader.Position.set): Use it. Simplify logic
2140 which, as a side-effect, makes it arbitrarily-seekable. Tune the
2141 buffer size when the stream needs to be re-read from the beginning.
2143 2009-03-05 Marek Safar <marek.safar@gmail.com>
2145 A fix for bug #480100
2146 * parameter.cs: A parameter is not hoisted when used directly as ET.
2148 2009-03-04 Marek Safar <marek.safar@gmail.com>
2150 * statement.cs: Fixed an issue when using variable is of interface
2153 2009-03-03 Marek Safar <marek.safar@gmail.com>
2155 A fix for bug #480319
2156 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
2158 2009-03-03 Marek Safar <marek.safar@gmail.com>
2160 A fix for bug #480867
2161 * typemanager.cs, expression.cs, ecore.cs: Changed method group
2162 expression to have no valid type.
2164 2009-03-03 Marek Safar <marek.safar@gmail.com>
2166 A fix for bug #481258
2167 * class.cs: Set extension method flag in partial container.
2169 2009-03-03 Marek Safar <marek.safar@gmail.com>
2171 * statement.cs, typemanager.cs: Use expression for StringEmitter.
2173 * attribute.cs: Add sanity check.
2175 2009-02-27 Marek Safar <marek.safar@gmail.com>
2177 * class.cs: Add external constructor error.
2179 2009-02-26 Marek Safar <marek.safar@gmail.com>
2181 A fix for bug #475354
2182 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
2183 correctly user defined nullable equality operators.
2185 2009-02-25 Marek Safar <marek.safar@gmail.com>
2187 A fix for bug #479532
2188 * expression.cs: Implement NewInitialize::AddressOf.
2190 2009-02-25 Marek Safar <marek.safar@gmail.com>
2192 A fix for bug #413633
2193 * expression.cs: Iterate all base class-constraint types.
2195 2009-02-24 Marek Safar <marek.safar@gmail.com>
2197 A fix for bug #479209
2198 * literal.cs: Mutate null underlying type.
2200 2009-02-24 Marek Safar <marek.safar@gmail.com>
2202 A fix for bug #476295
2203 * convert.cs: Avoid wrapping implicitly convertible reference type.
2205 2009-02-23 Marek Safar <marek.safar@gmail.com>
2207 * iterators.cs: Create MemberName correctly.
2209 2009-02-23 Marek Safar <marek.safar@gmail.com>
2211 A fix for bug #478655
2212 * literal.cs: Check also underlying null type conversion.
2214 2009-02-21 Marek Safar <marek.safar@gmail.com>
2216 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2218 2009-02-20 Marek Safar <marek.safar@gmail.com>
2220 A fix for bug #477447
2221 * statement.cs: Add reference to correct parent storey when this
2222 is accessible from deep children storey (more than 1 level).
2224 2009-02-19 Marek Safar <marek.safar@gmail.com>
2226 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2227 * class.cs: Define base type members before setting up member cache.
2229 2009-02-18 Marek Safar <marek.safar@gmail.com>
2231 A fix for bug #477378
2232 * nullable.cs, expression.cs, statement.cs: More precise null type
2235 2009-02-18 Marek Safar <marek.safar@gmail.com>
2237 A fix for bug #472805
2238 * typemanager.cs, namespace.cs: Import only visible extension method
2241 2009-02-18 Marek Safar <marek.safar@gmail.com>
2243 A fix for bug #476895
2244 * attribute.cs: Use correct resolve context for attribute type.
2246 2009-02-18 Marek Safar <marek.safar@gmail.com>
2248 A fix for bug #476266
2249 * anonymous.cs: Mutate multi-dimensional arrays.
2251 2009-02-18 Marek Safar <marek.safar@gmail.com>
2253 A fix for bug #476400
2254 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2256 2009-02-18 Marek Safar <marek.safar@gmail.com>
2258 A fix for bug #476811
2259 * generics.cs: Fixed null-literal check.
2261 2009-02-17 Marek Safar <marek.safar@gmail.com>
2263 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2264 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2265 messing with static variables.
2267 2009-02-16 Marek Safar <marek.safar@gmail.com>
2269 A fix for bug #475965
2270 * generics.cs: Check generic parameter type after extracting from
2273 2009-02-16 Marek Safar <marek.safar@gmail.com>
2275 A fix for bug #475823
2276 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2279 2009-02-14 Marek Safar <marek.safar@gmail.com>
2281 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2282 Simplified event field definition using backing field and not
2283 field builder directly.
2285 * expression.cs (EmitLdArg): Optimize fast paths.
2287 2009-02-13 Marek Safar <marek.safar@gmail.com>
2289 A fix for bug #475327
2290 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2292 2009-02-13 Marek Safar <marek.safar@gmail.com>
2294 A fix for bug #475342
2295 * cs-parser.jay: Using 'super' instead of 'base' to call base
2296 constructor crashes compiler.
2298 2009-02-13 Marek Safar <marek.safar@gmail.com>
2300 A fix for bug #475354
2301 * expression.cs (Constantify): Add nullable types.
2303 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2305 2009-02-12 Marek Safar <marek.safar@gmail.com>
2307 A fix for bug #475246
2308 * expression.cs: More broken flowanalysis hacking needed.
2310 2009-02-12 Marek Safar <marek.safar@gmail.com>
2312 * attribute.cs: Compare only ref/out array modifiers.
2314 2009-02-11 Marek Safar <marek.safar@gmail.com>
2316 * statement.cs: Use member cache when looking for foreach members.
2318 2009-02-11 Marek Safar <marek.safar@gmail.com>
2320 * expression.cs: Don't expose internal initializer types.
2322 * statement.cs: Check also explicit conversions for goto case.
2324 2009-02-11 Marek Safar <marek.safar@gmail.com>
2326 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2328 2009-02-10 Marek Safar <marek.safar@gmail.com>
2330 * *.cs: Replace null-type with NullLiteral where appropriate.
2332 2009-02-09 Marek Safar <marek.safar@gmail.com>
2334 * expression.cs: Initializer of reference argument use temporary
2335 variable to be verifiable.
2337 * parameter.cs: Share EmitLdArg.
2339 2009-02-09 Marek Safar <marek.safar@gmail.com>
2341 A fix for bug #473559
2342 * class.cs: Fixed: Not reporting error about nested class with the
2345 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2347 Contributed under the MIT/X11 license.
2349 * generic.cs: Added VerifyVariantTypeParameters which performs new
2350 variance verification logic. The old logic, based on the spec, was
2351 wrong because the spec is full of LIES!
2353 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2355 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2358 * ecore.cs: Added calls to the new variance verification logic.
2361 * delegate.cs: Removed calls to the old variance verification logic.
2363 2009-02-06 Marek Safar <marek.safar@gmail.com>
2365 * delegate.cs: Use cached Invoke method directly.
2367 2009-02-06 Marek Safar <marek.safar@gmail.com>
2369 * expression.cs: Emit expression tree for hoisted variable access.
2371 2009-02-04 Marek Safar <marek.safar@gmail.com>
2373 * namespace.cs: Add better extension class check.
2375 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2377 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2379 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2381 This patch adds initial generic variance support to the compiler.
2382 It is contributed under the MIT/X11 license.
2384 * typemanager.cs: Modified ImplementsInterface to check variance.
2385 Added VerifyVariantTypeParameters which checks the specified type to see
2386 if it uses a variant type parameter as a type argument (which is not
2387 allowed). Added IsVariantOf which determins if the first type is a
2388 variant of the second. NOTE: This only supports reference types at
2389 the moment to conform with the current level of VM support. When the
2390 VM supports value types, this will follow step.
2392 * generic.cs: Added the Variance enum. Added a Variance property to
2393 TypeParameter and added variance support to definition phase. Added a
2394 Variance property to TypeParameterName. Also check to make sure that
2395 no variant types appear in generic method parameters.
2397 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2398 keywords if the langversion supports it.
2400 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2401 that variant types are only used in legal positions. Also added
2402 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2405 * decl.cs: Construct TypeParameter with the variance information.
2407 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2408 and ImplicitConversionStandard.
2410 * rootcontext.cs: Added new "Future" language version.
2412 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2413 type parameters are not used as type arguments in interface inheritance.
2414 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2415 parameters are not used as method return types. In MemberBase.
2416 ResolveMemberType, ensure that variant type parameters are not used
2417 as type arguments. Also call VerifyNoVariantTypeParameters on every
2418 set of parameters which are resolved.
2420 * delegate.cs: Modified Delegate.Define to ensure that variant
2421 parameters are not used as type arguments and that a contravariant
2422 parameter is not used as the return type. Also call
2423 VerifyNoVariantTypeParameters on the delegate parameters.
2425 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2426 to specify generic variance.
2428 * driver.cs: Added support for LanguageVersion.Future in the form of
2429 "-langversion:future".
2431 * generic-mcs.cs: Stubbed out new members in generic.cs.
2433 2009-02-03 Marek Safar <marek.safar@gmail.com>
2435 * class.cs, generic.cs: Emit type parameter constraints for nested
2438 2009-02-02 Marek Safar <marek.safar@gmail.com>
2440 A fix for bug #471213
2441 * class.cs: Avoid emitting backing field for abstract event fields.
2443 2009-02-01 Marek Safar <marek.safar@gmail.com>
2445 A fix for bug #359731
2446 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2449 2009-01-30 Marek Safar <marek.safar@gmail.com>
2451 A fix for bug #470767
2452 * statement.cs: Introduced BlockScopeExpression, needed when
2453 expression tree conversion has to emit scope variables.
2455 2009-01-29 Marek Safar <marek.safar@gmail.com>
2457 * class.cs: Remove duplicate CallingConvention.
2459 2009-01-29 Marek Safar <marek.safar@gmail.com>
2461 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2462 when I finally found the right naming convention.
2464 2009-01-29 Marek Safar <marek.safar@gmail.com>
2466 * cs-tokenizer.cs: Put back different open parens optimization.
2468 2009-01-28 Marek Safar <marek.safar@gmail.com>
2470 A fix for bug #470227
2471 * cs-tokenizer.cs: Remove too agressive parser optimization.
2473 2009-01-28 Marek Safar <marek.safar@gmail.com>
2475 A fix for bug #324319
2476 * class.cs: Remove too early base type resolve.
2478 2009-01-27 Marek Safar <marek.safar@gmail.com>
2480 A fix for bug #324319
2481 * ecore.cs: Explicitly type null when assigning to type argument to
2482 make pass verifier check.
2484 2009-01-27 Marek Safar <marek.safar@gmail.com>
2486 * anonymous.cs: Fixed recent regression when initializing captured
2489 2009-01-26 Marek Safar <marek.safar@gmail.com>
2491 A fix for bug #469019
2492 * anonymous.cs: Use all parent type parameters when instantiating
2493 nested generic storey.
2495 2009-01-26 Marek Safar <marek.safar@gmail.com>
2497 * expression.cs: Check for null instance methodgroup expression.
2499 2009-01-26 Marek Safar <marek.safar@gmail.com>
2501 A fix for bug #469244
2502 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2503 instance inside a conditional expression.
2505 2009-01-23 Marek Safar <marek.safar@gmail.com>
2507 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2508 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2509 GetElementType and HasElementType. IsValueType clean up.
2511 2009-01-23 Marek Safar <marek.safar@gmail.com>
2513 * nullable.cs: Use common EmitCall.
2515 * expression.cs: Emit constraint. for virtual calls only.
2517 2009-01-23 Marek Safar <marek.safar@gmail.com>
2519 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2520 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2521 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2524 2009-01-22 Jb Evain <jbevain@novell.com>
2526 * anonymous.cs: make anonymous types' ToString implementation
2527 match what csc outputs.
2529 2009-01-21 Marek Safar <marek.safar@gmail.com>
2531 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2534 2009-01-17 Marek Safar <marek.safar@gmail.com>
2536 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2539 2009-01-16 Marek Safar <marek.safar@gmail.com>
2541 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2544 2009-01-15 Marek Safar <marek.safar@gmail.com>
2546 A fix for bug #466634
2547 * statement.cs: Add reference for nested storey when only this
2550 2009-01-15 Marek Safar <marek.safar@gmail.com>
2552 A fix for bug #466474
2553 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2556 2009-01-15 Marek Safar <marek.safar@gmail.com>
2558 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2559 Fixed nested stories parent referencing process. Also fixes #463985.
2561 2009-01-06 Marek Safar <marek.safar@gmail.com>
2563 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2564 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2565 implementation. Also fixes #463108.
2567 2009-01-05 Marek Safar <marek.safar@gmail.com>
2569 A fix for bug #416109
2570 * decl.cs: Issue correct CLSAttribute warning location.
2572 2009-01-05 Marek Safar <marek.safar@gmail.com>
2574 A fix for bug #456775
2575 * attribute.cs: Use attribute owner scope when resolving attribute
2578 2009-01-05 Marek Safar <marek.safar@gmail.com>
2580 A fix for bug #457257
2581 * decl.cs: Fixed incorrect member declaring type comparison.
2583 2009-01-05 Marek Safar <marek.safar@gmail.com>
2585 A fix for bug #460896
2586 * driver.cs: Handle /RES resources as embeddable.
2588 2009-01-05 Marek Safar <marek.safar@gmail.com>
2590 A fix for bug #462515
2591 * ecore.cs: Report inacessible members upwards.
2593 2009-01-05 Marek Safar <marek.safar@gmail.com>
2595 A fix for bug #463190, #463192
2596 * decl.cs, namespace.cs: Also import internal extension classes.
2598 2009-01-04 Marek Safar <marek.safar@gmail.com>
2600 A fix for bug #463415
2601 * generic.cs: Use right index for RemoveDependentTypes.
2603 2009-01-02 Marek Safar <marek.safar@gmail.com>
2605 A fix for bug #463196
2606 * expression.cs: Fixed enum to null comparison.
2608 2009-01-02 Marek Safar <marek.safar@gmail.com>
2610 A fix for bug #463121
2611 * nullable.cs: Fixed nullable user equality operator comparison.
2613 2009-01-02 Marek Safar <marek.safar@gmail.com>
2615 A fix for bug #462950
2616 * class.cs, decl.cs: Use full explicit name when defining automatic
2617 property backing field.
2619 2009-01-02 Marek Safar <marek.safar@gmail.com>
2621 A fix for bug #462592
2622 * pending.cs: Emit type arguments for generic proxy method.
2624 2008-12-30 Marek Safar <marek.safar@gmail.com>
2626 * expression.cs (As): Mutate all type arguments.
2628 2008-12-29 Marek Safar <marek.safar@gmail.com>
2630 A fix for bug #462622
2631 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2634 2008-12-29 Marek Safar <marek.safar@gmail.com>
2636 A fix for bug #450782
2637 * ecore.cs: Consider more variables of form V.I to be fixed.
2639 2008-12-29 Marek Safar <marek.safar@gmail.com>
2641 A fix for bug #460712
2642 * typemanager.cs: Core types could be imported.
2644 2008-12-28 Marek Safar <marek.safar@gmail.com>
2646 A fix for bugs #460847, #460772, #458049, #457339, #447807
2647 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2648 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2649 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2650 user lambdas used inside query clauses.
2652 2008-12-18 Marek Safar <marek.safar@gmail.com>
2654 A fix for bug #460229
2655 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2657 2008-12-18 Marek Safar <marek.safar@gmail.com>
2659 A fix for bug #459952
2660 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2662 2008-12-18 Marek Safar <marek.safar@gmail.com>
2664 A fix for bug #459630
2665 * convert.cs: Enum to valuetype conversion is not allowed.
2667 2008-12-18 Marek Safar <marek.safar@gmail.com>
2669 A fix for bug #457087
2670 * generic.cs: Don't crash when constraint comes from type
2673 2008-12-16 Marek Safar <marek.safar@gmail.com>
2675 A fix for bug #459221
2676 * anonymous.cs, statement.cs: Delay only captured this
2679 2008-12-12 Marek Safar <marek.safar@gmail.com>
2681 A fix for bug #457489
2682 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2683 and initialization to capture scope initializers correctly.
2685 2008-12-11 Marek Safar <marek.safar@gmail.com>
2687 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2688 ParameterReference refactoring.
2690 2008-12-03 Marek Safar <marek.safar@gmail.com>
2692 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2693 to be imported from any assembly.
2695 2008-12-03 Marek Safar <marek.safar@gmail.com>
2697 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2698 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2699 from anonymous method and lambda expression.
2701 2008-12-01 Marek Safar <marek.safar@gmail.com>
2703 A fix for bug #448560
2704 * expression.cs (As): Box any generic type arguments to be
2707 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2709 Add tripwire for implicit conversion bugs
2710 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2712 (MethodGroupExpr.OverloadResolve): Add sanity check between
2713 IsApplicable and VerifyArgumentsCompat.
2714 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2716 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2718 Fix build break in System.Data_test
2719 * convert.cs (ImplicitConversionExists): Move NullLiteral
2721 (ImplicitStandardConversionExists): ... here.
2723 2008-11-28 Marek Safar <marek.safar@gmail.com>
2725 * literal.cs: Emit correctly explicit null to nullable cast.
2727 2008-11-28 Marek Safar <marek.safar@gmail.com>
2729 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2732 2008-11-28 Marek Safar <marek.safar@gmail.com>
2734 A fix for bug #449005
2735 * convert.cs, nullable.cs: Use only one implicit nullable
2738 2008-11-27 Marek Safar <marek.safar@gmail.com>
2740 * convert.cs, literal.cs: More Convert cleanup is needed.
2742 2008-11-27 Marek Safar <marek.safar@gmail.com>
2744 * decl.cs, class.cs: Fixed misleading error message.
2746 2008-11-26 Marek Safar <marek.safar@gmail.com>
2748 A fix for bug #449005
2749 * nullable.cs (EmitEquality): Disable optimization for user operator
2752 2008-11-25 Marek Safar <marek.safar@gmail.com>
2754 A fix for bug #447027
2755 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2756 with context variables stored as expression instances.
2758 2008-11-25 Marek Safar <marek.safar@gmail.com>
2760 A fix for bug #447027
2761 * delegate.cs: Fixed delegate VerifyMethod logic.
2763 2008-11-24 Marek Safar <marek.safar@gmail.com>
2765 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2768 2008-11-21 Marek Safar <marek.safar@gmail.com>
2770 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2771 member type resolve to follow normal flow, instead of random
2774 2008-11-21 Marek Safar <marek.safar@gmail.com>
2776 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2779 2008-11-21 Marek Safar <marek.safar@gmail.com>
2781 * const.cs: Emit decimal array constant as literal.
2783 2008-11-20 Marek Safar <marek.safar@gmail.com>
2785 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2787 2008-11-19 Marek Safar <marek.safar@gmail.com>
2789 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2790 into real property (saves 8 MB for corlib compilation).
2792 2008-11-19 Marek Safar <marek.safar@gmail.com>
2794 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2795 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2796 generic-mcs.cs: Small cleanup of TypeArguments.
2798 2008-11-18 Marek Safar <marek.safar@gmail.com>
2800 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2801 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2802 of ConstructedType expression, renamed to GenericTypeExpr.
2804 2008-11-17 Marek Safar <marek.safar@gmail.com>
2806 A fix for bug #445303
2807 * location.cs (IsConditionalDefined): Handle undefined global
2810 2008-11-17 Marek Safar <marek.safar@gmail.com>
2812 A fix for bug #444678
2813 * expression.cs (TryReduceConstant): Always create new constant
2816 2008-11-17 Marek Safar <marek.safar@gmail.com>
2818 A fix for bug #444673
2819 * ecore.cs: Ignore open generic types when used as generic type
2822 2008-11-17 Marek Safar <marek.safar@gmail.com>
2824 A fix for bug #445458
2825 * expression.cs, cs-parser.jay: Don't crash when an expression
2828 2008-11-17 Marek Safar <marek.safar@gmail.com>
2830 A fix for bug #445464
2831 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2832 inside unbound type.
2834 2008-11-14 Jb Evain <jbevain@novell.com>
2836 * driver.cs: ignore empty -nowarn argument such as
2837 the one in -nowarn:12,13,,.
2839 2008-11-13 Marek Safar <marek.safar@gmail.com>
2841 A fix for bug #444271
2842 * anonymous.cs: Rescan parent storeys when best candidate was
2845 2008-11-13 Marek Safar <marek.safar@gmail.com>
2847 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2848 useless UnboundTypeExpression.
2850 * attribute.cs: Do check obsolete attribute on generic types.
2852 2008-11-12 Marek Safar <marek.safar@gmail.com>
2854 A fix for bugs #425680, #400139
2855 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2858 2008-11-11 Marek Safar <marek.safar@gmail.com>
2860 A fix for bug #435747
2861 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2862 compound value types assignment. Few micro optimizations added.
2864 2008-11-10 Marek Safar <marek.safar@gmail.com>
2866 A fix for bug #442610
2867 * anonymous.cs (MutateConstructor): More SRE hacking.
2869 2008-11-10 Marek Safar <marek.safar@gmail.com>
2871 A fix for bug #442579
2872 * ecore.cs: Also initialize expanded form of a method with 1 params
2875 2008-11-06 Marek Safar <marek.safar@gmail.com>
2877 * expression.cs (UnaryMutator): Do early l-side check.
2879 2008-11-05 Miguel de Icaza <miguel@novell.com>
2881 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2882 Init, otherwise we would crash later on when checking for friend
2885 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2886 Otherwise we never get any meaningful information as to what
2889 2008-11-05 Marek Safar <marek.safar@gmail.com>
2891 A fix for bug #436318
2892 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2894 2008-11-05 Miguel de Icaza <miguel@novell.com>
2896 * namespace.cs: Turns out that it was a really bad idea to hide
2897 the errors for namespaces not found here in eval mode.
2899 * eval.cs: When we process using clauses, only enter those into
2900 the list of valid using clauses after they have been validated.
2902 The above change gives the proper semantics: it does not
2903 senselessly report the same errors with broken using statements by
2904 never storing them in the first place when they are invalid.
2906 2008-11-05 Marek Safar <marek.safar@gmail.com>
2908 A fix for bug #421839
2909 * cs-parser.jay: Remove expression from coalesce rule to force lower
2910 priority than the assignment operator.
2912 2008-11-05 Marek Safar <marek.safar@gmail.com>
2914 A fix for bug #437875
2915 * nullable.cs: Compile correctly method group operand used with null
2916 coalescing operator.
2918 2008-11-04 Marek Safar <marek.safar@gmail.com>
2920 A fix for bug #434589
2921 * expression.cs (Binary): Ignore lifted conversions when at least
2922 one operand is of reference type.
2924 2008-11-04 Marek Safar <marek.safar@gmail.com>
2926 * cs-parser.jay: Better syntax error report.
2928 2008-11-03 Marek Safar <marek.safar@gmail.com>
2930 A fix for bug #436792
2931 * cs-parser.jay: Use GetLocation to access location.
2933 2008-11-03 Marek Safar <marek.safar@gmail.com>
2935 A fix for bug #440774
2936 * cs-parser.jay: Also set current_array_type when parsing local
2939 2008-11-03 Marek Safar <marek.safar@gmail.com>
2941 A fix for bug #440785
2942 * expression.cs (As): Don't resolve self modifing expression
2945 2008-11-03 Marek Safar <marek.safar@gmail.com>
2947 A fix for bug #439447
2948 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2950 2008-11-03 Marek Safar <marek.safar@gmail.com>
2952 A fix for bug #437571
2953 * cs-parser.jay: Fixes internal error for invalid expression
2956 2008-10-17 Marek Safar <marek.safar@gmail.com>
2958 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2960 2008-10-17 Marek Safar <marek.safar@gmail.com>
2962 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2964 2008-10-17 Marek Safar <marek.safar@gmail.com>
2966 * cs-tokenizer.cs: More precise cast parsing.
2968 2008-10-16 Martin Baulig <martin@ximian.com>
2970 * anonymous.cs (AnonymousMethodStorey): Put back the
2971 `hoisted_locals' hashtable and use it in EmitType().
2973 2008-10-15 Marek Safar <marek.safar@gmail.com>
2975 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2976 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2979 2008-10-14 Marek Safar <marek.safar@gmail.com>
2981 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2983 2008-10-14 Marek Safar <marek.safar@gmail.com>
2985 * statement.cs: Mutate scope initializers.
2987 2008-10-14 Marek Safar <marek.safar@gmail.com>
2989 * expression.cs: Use typeless value for This constant.
2991 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2993 2008-10-14 Marek Safar <marek.safar@gmail.com>
2995 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2998 2008-10-13 Marek Safar <marek.safar@gmail.com>
3000 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
3003 2008-10-13 Marek Safar <marek.safar@gmail.com>
3005 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
3006 parser and tokenizer. Fixes many ambiguities including #433258.
3008 2008-10-10 Marek Safar <marek.safar@gmail.com>
3010 * cs-parser.jay: Fixed missing accessor recovery.
3012 2008-10-10 Marek Safar <marek.safar@gmail.com>
3014 A fix for bug #433701
3015 * expression.cs: Better error message.
3017 2008-10-10 Marek Safar <marek.safar@gmail.com>
3019 * cs-parser.jay, expression.cs: Start reporting real parser errors.
3021 * Makefile: Disabled unused debug symbols.
3023 Also fixes: #320556, #321097, #321656, #321876, #351316
3025 2008-10-09 Miguel de Icaza <miguel@novell.com>
3027 * eval.cs: rename "<interactive>" to "{interactive}", to work
3028 around a requirement in the compiler that this be a valid
3029 filename, and in Windows it is not (433886).
3031 2008-10-09 Marek Safar <marek.safar@gmail.com>
3033 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
3035 2008-10-08 Marek Safar <marek.safar@gmail.com>
3037 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
3038 cs-parser.jay: Generic type declaration and type arguments cleanup.
3040 2008-10-05 Marek Safar <marek.safar@gmail.com>
3042 * cs-parser.jay: Allow parsing weird array creation construct.
3044 2008-10-05 Marek Safar <marek.safar@gmail.com>
3046 * cs-parser.jay: Conflicts reduction.
3048 2008-10-04 Marek Safar <marek.safar@gmail.com>
3050 * cs-parser.jay: Conflicts reduction.
3052 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
3055 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
3056 property. Add a 'count' hint about the use of the shared vector.
3057 Ensure that we don't leak out dirty bits.
3058 (UsageVector.MergeChild): Throw away information about variables
3060 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
3062 2008-10-03 Marek Safar <marek.safar@gmail.com>
3064 A fix for bug #431746
3065 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
3066 parameters when iterator is created.
3068 2008-10-03 Marek Safar <marek.safar@gmail.com>
3070 A fix for bug #431827
3071 * expression.cs: Fixed right based pointer arithmetic operations
3074 2008-10-03 Marek Safar <marek.safar@gmail.com>
3076 A fix for bug #353779
3077 * assign.cs, expression.cs: Fixed compound assignment conversions.
3079 2008-10-02 Marek Safar <marek.safar@gmail.com>
3081 A fix for bug #375262
3082 * statement.cs: Refactor ArrayForeach to be usable with string
3083 indexer. Optimized single dimentional arrays foreach.
3085 2008-10-02 Marek Safar <marek.safar@gmail.com>
3087 A fix for bug #431255
3088 * anonymous.cs, expression.cs: Removed broken optimization.
3090 2008-10-01 Marek Safar <marek.safar@gmail.com>
3092 * anonymous.cs: Use full type parameters of parent generic
3093 containers. Removed unnecessary AddParentStoreyReference call.
3095 2008-10-01 Marek Safar <marek.safar@gmail.com>
3097 A fix for bug #324702
3098 * class.cs: Use better shorter names for explicit interface member
3101 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
3103 2008-10-01 Marek Safar <marek.safar@gmail.com>
3105 * expression.cs: Use new interface to check fixed expression.
3107 2008-10-01 Marek Safar <marek.safar@gmail.com>
3109 A fix for bug #421101
3110 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
3111 interface to check for fixed fixed-buffers.
3113 2008-10-01 Marek Safar <marek.safar@gmail.com>
3115 A fix for bug #429264
3116 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
3118 * delegate.cs: Removed unnecessary casts.
3120 2008-09-30 Marek Safar <marek.safar@gmail.com>
3122 A fix for bug #352151
3123 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
3124 class.cs: Fixed already defined explicit interface members check.
3126 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
3128 cs-tokenizer.cs: Fix typo.
3130 2008-09-28 Miguel de Icaza <miguel@novell.com>
3132 * eval.cs (InteractiveBase): The quit command now just sets a
3133 flag, instead of calling Environment.Exit(), it is milder on
3136 CompiledMethod is now in Mono.CSharp, not nested inside
3137 the Evaluator, it was inconvenient to use.
3139 2008-09-27 Miguel de Icaza <miguel@novell.com>
3141 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
3142 code to be invoked without having to reparse.
3144 2008-09-27 Miguel de Icaza <miguel@novell.com>
3146 * ecore.cs: The recent changes to FieldExpr broke this as well.
3147 Fixes LINQ queries in the interactive shell.
3149 * Multiple files: indentation fixing for the Mono coding
3150 guidelines for the switch statement.
3152 * eval.cs: Make the Evaluator API thread safe.
3154 2008-09-26 Marek Safar <marek.safar@gmail.com>
3156 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
3157 constructor parsing.
3159 2008-09-26 Marek Safar <marek.safar@gmail.com>
3161 A fix for bug #325326
3162 * statement.cs: Check possible mistaken empty statement using
3163 explicit blocks only.
3165 2008-09-25 Miguel de Icaza <miguel@novell.com>
3167 * eval.cs (LoadAssembly, ReferenceAssembly): Call
3168 RootNamespace.ComputeNamespaces to update the internal list of
3169 namespaces, this is no longer done for us.
3171 (InteractiveBase): Use the Evaluator APIs instead of calling into
3174 2008-09-25 Marek Safar <marek.safar@gmail.com>
3176 A fix for bug #429264
3177 * expression.cs: Missing mutator for access to multidimensional
3180 2008-09-25 Marek Safar <marek.safar@gmail.com>
3182 * class.cs, statement: Emit DebuggerHidden attribute for iterator
3185 * driver.cs: Missing input argument check.
3187 2008-09-25 Marek Safar <marek.safar@gmail.com>
3189 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
3190 expression.cs, statement.cs, rootcontext.cs, class.cs,
3191 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
3194 2008-09-24 Miguel de Icaza <miguel@novell.com>
3196 * ecore.cs (FieldExpr): Only initialize eclass when we return a
3197 fully constructed FieldExpr, fixes the regression introduced in
3200 * ecore.cs, expression.cs: Plug back the eclass initialization as
3201 otherwise it regresses `csharp'.
3203 2008-09-24 Marek Safar <marek.safar@gmail.com>
3205 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
3206 ecore.cs, attribute.cs: Moved obsolete method checks from emit
3207 phase to resolve phase. It resolves problems with expression trees
3208 and fixes bugs #323796, #325156.
3210 2008-09-23 Marek Safar <marek.safar@gmail.com>
3212 * codegen.cs: Report better error when symbol writer is missing.
3214 2008-09-23 Marek Safar <marek.safar@gmail.com>
3216 * codegen.cs: Set .NET symbol writer.
3218 * decl.cs: Guard against null generic arguments.
3220 * report.cs: Don't report exactly same additional details.
3222 2008-09-22 Marek Safar <marek.safar@gmail.com>
3224 A fix for bug #324917
3225 * cs-parser.jay: Add missing multidimensional non-expression type
3228 2008-09-22 Marek Safar <marek.safar@gmail.com>
3230 A fix for bug #428191
3231 * anonymous.cs: Create an outer generic fields also for non-storey
3234 2008-09-22 Marek Safar <marek.safar@gmail.com>
3236 A fix for bug #378294
3237 * class.cs: Make fixed size buffers gmcs feature only.
3239 2008-09-22 Marek Safar <marek.safar@gmail.com>
3241 A fix for bug #355622, #324993
3242 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3245 2008-09-19 Marek Safar <marek.safar@gmail.com>
3247 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3250 2008-09-19 Marek Safar <marek.safar@gmail.com>
3252 A fix for bug #416110
3253 * generic.cs: Struct constraint results in default ctor and
3254 ValueType base type constraint to be set.
3256 2008-09-19 Marek Safar <marek.safar@gmail.com>
3258 A fix for bug #423791
3259 * generic.cs: Fixed params output type type-inference.
3261 2008-09-19 Marek Safar <marek.safar@gmail.com>
3263 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3265 2008-09-19 Marek Safar <marek.safar@gmail.com>
3267 * cs-tokenizer.cs: Don't break on extra partial modifier.
3269 2008-09-19 Marek Safar <marek.safar@gmail.com>
3271 A fix for bug #427592
3272 * generic.cs: Use common parameter resolve method.
3274 2008-09-18 Marek Safar <marek.safar@gmail.com>
3276 A fix for bug #414758
3277 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3280 2008-09-18 Marek Safar <marek.safar@gmail.com>
3282 * driver.cs, namespace.cs: Read types and namespaces after all
3283 requested assemblies are loaded, fixes issues with System.Core
3284 auto-reference, and #419888.
3286 2008-09-18 Marek Safar <marek.safar@gmail.com>
3288 A fix for bug #417705
3289 * cs-parser.jay: Fixed as/is operator expression split.
3291 2008-09-18 Marek Safar <marek.safar@gmail.com>
3293 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3294 Fixed expression tree representation of empty new expression and
3295 new initializer expression.
3297 2008-09-18 Miguel de Icaza <miguel@novell.com>
3299 * eval.cs: Remove warning, keep reference to driver around.
3301 * Hide fields that do not need to be public.
3303 2008-09-17 Marek Safar <marek.safar@gmail.com>
3305 A fix for bug #426385
3306 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3307 conversion for array elements.
3309 2008-09-17 Marek Safar <marek.safar@gmail.com>
3311 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3312 void parsing conflicts.
3314 2008-09-15 Marek Safar <marek.safar@gmail.com>
3316 A fix for bug #425601
3317 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3318 System.Core only when there is no custom ExtensionAttribute
3321 2008-09-15 Miguel de Icaza <miguel@novell.com>
3323 * namespace.cs: Do not report CS0246 (name
3325 2008-09-12 Marek Safar <marek.safar@gmail.com>
3327 A fix for bug #425669
3328 * generic.cs: Don't cache generic static anonymous method
3331 2008-09-12 Marek Safar <marek.safar@gmail.com>
3333 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3334 conflicting constraints.
3336 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3338 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3341 2008-09-12 Marek Safar <marek.safar@gmail.com>
3343 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3344 to null pointer conversion fixes.
3346 2008-09-11 Marek Safar <marek.safar@gmail.com>
3348 * cs-parser.jay, expression.cs: An implicitly typed local variable
3349 declarator cannot use an array initializer.
3351 2008-09-11 Marek Safar <marek.safar@gmail.com>
3353 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3355 2008-09-11 Marek Safar <marek.safar@gmail.com>
3357 * generic.cs (InflatedConstraints): Don't crash when constraints
3360 * cs-parser.jay: const_declarator is a block.
3362 * constant.cs: Check for not allowed NaN conversions.
3364 2008-09-10 Miguel de Icaza <miguel@novell.com>
3366 * driver.cs: Drop --shell argument, the compiler is no longer a
3369 * eval.cs: Move most of the code that deals with evaluation into
3370 this file and document the public API from repl.cs
3372 * repl.cs: Remove from here.
3374 2008-09-10 Marek Safar <marek.safar@gmail.com>
3376 A fix for bug #424684
3377 * generic.cs: Generic class constraints must come first.
3379 2008-09-09 Miguel de Icaza <miguel@novell.com>
3381 * cs-parser.jay: Improve error reporting for syntax errors in
3382 statements and expressions, we now report the expected tokens
3383 instead of reporting the useless "; expected".
3385 Drop the strings from the token declaration, it turns out that
3386 they did not do what I thought they did. Instead they were adding
3387 two sets of tokens to the tables.
3389 2008-09-09 Marek Safar <marek.safar@gmail.com>
3391 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3392 delegate.cs: Share special type check.
3394 2008-09-09 Marek Safar <marek.safar@gmail.com>
3396 A fix for bug #423981
3397 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3399 2008-09-09 Marek Safar <marek.safar@gmail.com>
3401 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3404 2008-09-09 Marek Safar <marek.safar@gmail.com>
3406 A fix for bugs: #324750, #335946
3407 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3408 lookup rule to determine ?-based tokens.
3410 2008-09-08 Miguel de Icaza <miguel@novell.com>
3412 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3413 expressions (like event adding or removing) end up here, so we
3414 need to treat those as statements.
3416 Add LoadAssembly method.
3418 2008-09-04 Miguel de Icaza <miguel@novell.com>
3420 * repl.cs: Add Time method.
3422 2008-09-05 Marek Safar <marek.safar@gmail.com>
3424 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3426 2008-09-05 Miguel de Icaza <miguel@novell.com>
3428 * repl.cs: Add workaround for old compilers.
3430 2008-09-04 Jb Evain <jbevain@novell.com>
3432 * repl.cs (PrettyPrint): pretty print everything that
3433 implements IDictionary, as well as IEnumerables. Also,
3434 add a quit helper property.
3436 2008-09-04 Marek Safar <marek.safar@gmail.com>
3438 * constant.cs: Better error reporting for decimal literals.
3440 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3443 2008-09-04 Marek Safar <marek.safar@gmail.com>
3444 Miguel de Icaza <miguel@novell.com>
3446 A fix for bug #422951
3447 * assign.cs (Assign.DoResolve): Perform the type conversions
3448 checks before we attempt to initialize `New' initializers.
3450 2008-09-04 Marek Safar <marek.safar@gmail.com>
3452 A fix for bug #422853
3453 * delegate.cs (DelegateCreation): Add special handling for
3454 EmptyExpression.Null instance expression which is just another
3455 hack for undecided member instance exression.
3457 2008-09-04 Marek Safar <marek.safar@gmail.com>
3459 * expression.cs, ecore.cs: Emit full expression tree for reduced
3462 2008-09-04 Marek Safar <marek.safar@gmail.com>
3464 * expression.cs (This): Guard against multi-resolving.
3466 * ecore.cs, statement.cs (Throw): Simplified.
3468 * flowanalysis.cs: Also verify event fields.
3470 2008-09-04 Miguel de Icaza <miguel@novell.com>
3472 * assign.cs (Assign.DoResolve): Perform the type conversions
3473 checks before we attempt to initialize `New' initializers.
3475 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3477 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3480 * repl.cs: Update help.
3482 2008-09-03 Miguel de Icaza <miguel@novell.com>
3484 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3485 handling of the default config handling, including the special
3486 treatment of System.Core assembly.
3488 Fixes the REPL processing for LINQ.
3490 2008-09-03 Marek Safar <marek.safar@gmail.com>
3492 A fix for bug #422507
3493 * expression.cs (UnboxCast): Add missing child expression mutator.
3495 2008-09-03 Marek Safar <marek.safar@gmail.com>
3497 * driver.cs: Don't self reference System.Core assembly.
3499 2008-09-03 Marek Safar <marek.safar@gmail.com>
3501 A fix for bug #422507
3502 * expression.cs (StringConcat): Add missing type mutator.
3504 2008-09-03 Marek Safar <marek.safar@gmail.com>
3506 * generic.cs (TypeInferenceContext): Follow equality rule for
3507 constructed type lower bound type inference.
3509 2008-09-02 Miguel de Icaza <miguel@novell.com>
3511 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3512 <dblank@cs.brynmawr.edu> which updates the cursor position on
3515 2008-09-02 Marek Safar <marek.safar@gmail.com>
3517 A fix for bug #367145
3518 * driver.cs: Fixed import of extension methods when using -noconfig
3521 2008-09-02 Marek Safar <marek.safar@gmail.com>
3523 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3524 version from non-generic implementation instead.
3526 2008-09-01 Marek Safar <marek.safar@gmail.com>
3528 A fix for bug #418908
3529 * class.cs: Use AddScopeStatement for field initializers.
3531 2008-09-01 Marek Safar <marek.safar@gmail.com>
3533 A fix for bug #415385
3534 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3536 2008-09-01 Marek Safar <marek.safar@gmail.com>
3538 A fix for bug #421736
3539 * iterators.cs: Don't crash on unreachable iterators.
3541 2008-09-01 Marek Safar <marek.safar@gmail.com>
3543 A fix for bug #421628
3544 * parameter.cs, attribute.cs: Clone also parameter attributes.
3546 2008-08-30 Miguel de Icaza <miguel@novell.com>
3548 * namespace.cs (LookupType): In EvalMode, try to replace
3549 the TypeBuilder from our cache with a Type as Reflection.Emit does
3550 not like to mix code from older assemblies emitted and new
3553 This sounds like a serious Mono bug that prevents multiple
3554 assemblies to be generated and consumed at the same time.
3556 * cs-parser.jay (push_current_class): Do not make interactive
3557 classes internal or private, make them public as we currently
3558 generate each new class in a new assembly.
3560 2008-08-29 Miguel de Icaza <miguel@novell.com>
3562 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3563 remove types that are entered into the global namespace during
3564 parsing so that we can remove them on failure.
3566 * cs-parser.jay: Parsing: we now keep track of types that are
3567 entered into global variables and queue those in case the parsing
3570 This happens in a few situations: during partial-input, we invoke
3571 the parser repeatedly for example with the string "class X", this
3572 would cause X to be registed, and we need to remove this
3573 registration so that another parse attempt later with say "class X {"
3574 would actually work.
3576 Additionally, if there is an error in the resolution phase, for
3577 example: "class X : NonExistant {}" th
3579 * cs-parser.jay: Be more precise with the errors being raised,
3580 instead of flagging all exceptions during parsing to be attributed
3581 to the parsing process, distinguish those from errors happening in
3582 the actions and hint that using -v would produce the actual
3585 * repl.cs: Do not load all compiler references on each reset,
3586 doing the partial reset takes care of this.
3588 2008-08-28 Miguel de Icaza <miguel@novell.com>
3590 * repl.cs: Add support for loading all the files from
3591 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3594 Introduce a micro-parser that is able to deambiguate on its input
3595 whether we are dealing with a compilation unit (namespace, class,
3596 interface, struct, delegate) declaration or a statement. This
3597 allows both declarations and statements to be entered.
3599 Set history size by default to 300 lines.
3601 Instead of distinguishing based on the parser.InteractiveResult,
3602 have only two cases: statements were parsed, or a compilation unit
3603 was. Always pull the Using statement additions from the
3604 compilation unit parse.
3606 * cs-tokenizer.cs: Rename tokens to better describe their intent
3607 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3609 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3610 EvalMode is used to trigger the lookup of global variables while
3611 StatementMode is used turn variable declarations into static
3614 * getline.cs: Allow history size to be set.
3616 2008-08-29 Marek Safar <marek.safar@gmail.com>
3618 A fix for bug #360755
3619 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3621 2008-08-29 Marek Safar <marek.safar@gmail.com>
3623 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3625 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3626 member name, it is too confusing
3628 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3630 * rootcontext.cs: Finally default to warning level 4.
3632 2008-08-28 Marek Safar <marek.safar@gmail.com>
3634 * class.cs (CheckBase): Ignore overloaded operators.
3636 2008-08-28 Marek Safar <marek.safar@gmail.com>
3638 A fix for bug #420830
3639 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3641 2008-08-28 Marek Safar <marek.safar@gmail.com>
3643 A fix for bug #420832
3644 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3646 2008-08-28 Marek Safar <marek.safar@gmail.com>
3648 A fix for bug #420386
3649 * nullables.cs: Fixed logic of nullable user comparison operators involving
3652 2008-08-28 Marek Safar <marek.safar@gmail.com>
3654 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3656 2008-08-27 Miguel de Icaza <miguel@novell.com>
3658 * repl.cs: Add support for aborting the running code with C-c.
3660 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3662 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3664 2008-08-27 Miguel de Icaza <miguel@novell.com>
3666 * cs-parser.jay (interactive_statement_list): A new set of rules
3667 for hosting statements that uses the "interactive_" prefix.
3669 * repl.cs: Add support for parsing `using' as a statement or as a
3670 directive. Deambiguating before passing this to the parser.
3672 We need to distinguish statement_expressions that occur at the
3673 toplevel vs those that occur embedded into expressions.
3675 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3676 that fixes the cursor key handling, and a history bug.
3678 2008-08-26 Miguel de Icaza <miguel@novell.com>
3680 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3681 limitations in Console, instead the 2.0 bootstrap libraries now
3682 include the Console bits.
3684 Also, remove the use of Nullables from getline.cs
3688 Interactive support for the C# compiler. Use gmcs --shell to
3689 enter a read-eval-print loop shell.
3691 Docs: http://www.mono-project.com/CsharpRepl
3693 * sources: include repl.cs here and getline.cs for gmcs.exe,
3694 everything else is getline.cs impaired.
3696 * Makefile: when bootstrapping pass a special flag
3697 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3698 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3699 This distinguishes those two cases.
3701 * repl.cs: Support for a read-eval-print loop. Will be soon
3702 refactored into eval support and then REPL on top of it.
3704 * ecore.cs: If a simplename lookup fails, before erroring out,
3705 if we are in EvalMode to resolve the name to a declaration in the
3708 This means that variable declarations that happened in previous
3709 classes (as repl puts every statement in a separate class) are
3710 made visible in this way.
3712 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3713 triggered an error due to the end of file being reached. This is
3714 used to do multi-line input, and notify the caller that the user
3715 needs to provide more text before a successful parse.
3717 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3718 to drive the evaluation with a custom wrapper.
3720 * driver.cs: Add support for --shell, and refactor some code to be
3723 * namespace.cs: Add support for serializing the contents of the
3724 namespaces and reloading them.
3726 * getline.cs: A managed implementation of ReadLine under
3727 X11/Apache2 license terms. Easy to embed in other applications as
3730 * namespace.cs: Add some functions to save and restore the
3733 * rootcontext.cs: New public field.
3735 * cs-tokenizer.cs: Add support for one of the possible characters
3736 we introduce into the token stream.
3738 This patch does not affect the regular tokenization process, the
3739 only performance hit would happen if there is an invalid character
3740 on the input string.
3742 * support.cs: Move isatty helper routine here.
3744 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3745 code generator for in-memory assemblies.
3747 2008-08-26 Marek Safar <marek.safar@gmail.com>
3749 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3750 parameter cannot be always used as a type.
3752 2008-08-21 Marek Safar <marek.safar@gmail.com>
3754 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3756 2008-08-21 Marek Safar <marek.safar@gmail.com>
3758 * convert.cs: Implement explicit array to IList<T> conversion.
3760 2008-08-20 Marek Safar <marek.safar@gmail.com>
3762 A fix for bug #362740
3763 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3765 2008-08-20 Marek Safar <marek.safar@gmail.com>
3767 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3768 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3769 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3770 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3771 handling to use just one type of infrastructure and deal with generics
3774 2008-07-23 Martin Baulig <martin@ximian.com>
3776 *** Merged this from trunk revision 108527 ***
3779 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3780 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3783 2008-08-15 Marek Safar <marek.safar@gmail.com>
3785 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3788 2008-08-15 Marek Safar <marek.safar@gmail.com>
3790 * delegate.cs: Fixed compiler crash when creating delegate using partial
3793 * typemanager.cs: MulticastDelegate is not a delegate.
3795 2008-08-14 Marek Safar <marek.safar@gmail.com>
3797 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3800 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3802 * cs-parser.jay (type): Allow 'var' in mcs too.
3803 (local_variable_type): Likewise.
3805 2008-08-14 Marek Safar <marek.safar@gmail.com>
3807 * driver.cs: Removed broken -noconfig variants.
3809 2008-08-14 Marek Safar <marek.safar@gmail.com>
3811 A fix for bug #417078
3812 * expression.cs: Emit correctly left side pointer operators.
3814 2008-08-13 Marek Safar <marek.safar@gmail.com>
3816 * generic.cs, lambda.cs: Inflate method generic arguments only.
3818 2008-08-12 Marek Safar <marek.safar@gmail.com>
3820 * class.cs: Fixed struct layout check regression.
3822 2008-08-12 Marek Safar <marek.safar@gmail.com>
3824 * cs-parser.jay, enum.cs: Simplified enum parsing.
3826 * decl.cs: Check all type parameters conflicts.
3828 * expression.cs, statement.cs, attribute.cs: More expression checks.
3830 2008-08-11 Marek Safar <marek.safar@gmail.com>
3832 * generic.cs: Add type inference types restriction.
3834 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3835 anonymous.cs, expression.cs: Allocate less accessor parameters.
3837 2008-08-08 Marek Safar <marek.safar@gmail.com>
3839 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3842 2008-08-08 Marek Safar <marek.safar@gmail.com>
3844 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3846 2008-08-07 Marek Safar <marek.safar@gmail.com>
3848 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3849 Also fixes #362146 and #381592.
3851 2008-08-07 Marek Safar <marek.safar@gmail.com>
3853 * ecore.cs: Reduced constant cannot be used as an attribute value.
3855 * cs-parser.jay: Base expression has to be a type.
3857 * expression.cs (Conditional): Uses ReducedExpression.
3859 2008-08-06 Marek Safar <marek.safar@gmail.com>
3861 A fix for bug #376826
3862 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3863 address of hoisted local variable or parameter cannot be taken.
3865 2008-08-05 Marek Safar <marek.safar@gmail.com>
3867 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3868 anonymous method inside checked/unchecked expression.
3870 2008-08-05 Marek Safar <marek.safar@gmail.com>
3872 * typemanager.cs (IsEqual): Guard against null.
3874 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3875 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3876 routine. Fixed few misleading conversion errors.
3878 2008-08-04 Marek Safar <marek.safar@gmail.com>
3880 * class.cs: Consider generics when checking cycles in struct layout.
3882 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3884 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3886 2008-08-04 Marek Safar <marek.safar@gmail.com>
3888 A fix for bug #414165
3889 * anonymous.cs: Use same anonymous implementation method for all anonymous
3892 2008-08-04 Marek Safar <marek.safar@gmail.com>
3894 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3897 2008-08-04 Marek Safar <marek.safar@gmail.com>
3899 * cs-parser.jay: Typeof argument has to be a type expression.
3901 * namespace.cs: Check alias and namespace definitions collisions.
3903 * class.cs, pending.cs: Moved explicit interface accessor implementation
3906 * delegate.cs, expression.cs: Verify special name invocations.
3908 2008-08-01 Marek Safar <marek.safar@gmail.com>
3910 * cs-parser.jay: Don't choke on empty generic type arguments.
3912 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3914 * expression.cs, ecore.cs: Minor expressions bugs.
3916 2008-08-01 Marek Safar <marek.safar@gmail.com>
3918 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3919 and added more error handling.
3921 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3923 * modifiers.cs, enum.cs: Fixed.
3925 2008-07-31 Jb Evain <jbevain@novell.com>
3927 * driver.cs: remove -pkg ability of smcs.
3929 2008-07-30 Marek Safar <marek.safar@gmail.com>
3931 * statement.cs (Switch): Correctly set empty default target for single
3934 2008-07-30 Marek Safar <marek.safar@gmail.com>
3936 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3937 string switch statement implementation to use string dictionary which
3938 significantly (2-8x) improves performance of generated code.
3940 2008-07-29 Marek Safar <marek.safar@gmail.com>
3942 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3943 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3945 2008-07-29 Marek Safar <marek.safar@gmail.com>
3947 A fix for bug #412595
3948 * typemanager.cs, convert.cs, expression.cs: Some types are never
3949 convertible to each other.
3951 2008-07-29 Marek Safar <marek.safar@gmail.com>
3953 * nullable.cs (CreateNullConstant): An error messages update.
3955 2008-07-29 Marek Safar <marek.safar@gmail.com>
3957 A fix for bug #412595
3958 * cfold.cs: Don't cast undefined bool constant.
3960 2008-07-29 Martin Baulig <martin@ximian.com>
3963 (SymbolWriter.Reset): New public static method.
3966 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3968 2008-07-28 Marek Safar <marek.safar@gmail.com>
3970 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3972 * expression.cs (ElementAccess): Exact size allocation.
3974 2008-07-26 Marek Safar <marek.safar@gmail.com>
3976 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3978 2008-07-25 Marek Safar <marek.safar@gmail.com>
3980 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3982 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3985 2008-07-25 Marek Safar <marek.safar@gmail.com>
3987 A fix for bug #412217
3988 * assign.cs: Mutate also assignment type.
3990 2008-07-25 Marek Safar <marek.safar@gmail.com>
3992 A fix for bug #323644
3993 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3996 2008-07-25 Marek Safar <marek.safar@gmail.com>
3998 A fix for bug #412134
3999 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
4000 non-enumerable operands when overloading equality or bitwise operators.
4002 2008-07-25 Marek Safar <marek.safar@gmail.com>
4004 * anonymous.cs: Cache closed generic anonymous method delegates.
4006 2008-07-24 Marek Safar <marek.safar@gmail.com>
4008 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
4009 anonymous.cs, statement.cs: Always emit anonymous method as static method
4010 when is instance free. Use nesting for nested anynomous methods blocks.
4012 2008-07-23 Marek Safar <marek.safar@gmail.com>
4014 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
4017 2008-07-23 Marek Safar <marek.safar@gmail.com>
4019 * expression.cs: Removed MakeSimpleCall.
4021 2008-07-23 Marek Safar <marek.safar@gmail.com>
4023 A fix for bug #323012
4024 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
4025 Base method implementing interface has to be public.
4027 2008-07-23 Marek Safar <marek.safar@gmail.com>
4029 * cs-parser.jay: Don't break on missing argument.
4031 2008-07-22 Marek Safar <marek.safar@gmail.com>
4033 A fix for bug #320993
4034 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
4035 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
4037 2008-07-22 Marek Safar <marek.safar@gmail.com>
4039 A fix for bug #320748
4040 * convert.cs: Implicit user operators cannot convert to interfaces
4042 2008-07-22 Marek Safar <marek.safar@gmail.com>
4044 A fix for bug #312686
4045 * driver.cs: Ignore empty assembly references.
4047 2008-07-22 Marek Safar <marek.safar@gmail.com>
4049 A fix for bug #387040
4050 * ecore.cs: Skip constrains check for an explicit implementation.
4052 2008-07-21 Marek Safar <marek.safar@gmail.com>
4054 A fix for bug #409045
4055 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
4056 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
4057 identifiers are file specific unless passed as input arguments.
4059 2008-07-21 Marek Safar <marek.safar@gmail.com>
4061 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
4062 to emit UnmanagedMarshal data under 2.0 profile.
4064 2008-07-21 Marek Safar <marek.safar@gmail.com>
4066 A fix for bug #410369
4067 * parameter.cs: Clone correctly ParamsParameter.
4069 2008-07-21 Marek Safar <marek.safar@gmail.com>
4071 * expression.cs (Argument): Always report type for type based expressions
4074 2008-07-18 Marek Safar <marek.safar@gmail.com>
4076 A fix for bug #410666
4077 * anonymous.cs: Correctly initialize generic storey reference.
4079 2008-07-18 Marek Safar <marek.safar@gmail.com>
4081 * convert.cs: Don't box same type arguments.
4083 2008-07-18 Marek Safar <marek.safar@gmail.com>
4085 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
4086 Finished missing generic type mutators.
4088 2008-07-18 Marek Safar <marek.safar@gmail.com>
4090 * iterators.cs, statement.cs: Finished statements CloneTo.
4092 2008-07-18 Marek Safar <marek.safar@gmail.com>
4094 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
4096 * expression.cs: Emit optimized default value expressions in expression tree
4099 2008-07-18 Marek Safar <marek.safar@gmail.com>
4101 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
4103 2008-07-17 Marek Safar <marek.safar@gmail.com>
4105 A fix for bug #367536
4106 * cs-parser.jay: Check static constructor of generic types for an access
4109 2008-07-17 Marek Safar <marek.safar@gmail.com>
4111 A fix for bug #353800
4112 * lambda.cs: Emit ret for contextual statements.
4114 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
4115 up emitting redundant ret for all anonymous methods with return.
4117 2008-07-17 Marek Safar <marek.safar@gmail.com>
4119 A fix for bug #365188
4120 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
4121 create anonymous method storey in unreachable block.
4123 2008-07-17 Marek Safar <marek.safar@gmail.com>
4125 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
4126 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
4127 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
4128 statement.cs: Fixed relevant defects found by Gendarme.
4130 2008-07-17 Marek Safar <marek.safar@gmail.com>
4132 A fix for bug #325291
4133 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
4134 statement.cs: Replaced IAnonymousHost with top level block flag.
4136 2008-07-17 Marek Safar <marek.safar@gmail.com>
4138 * cs-parser.jay: Clean up unused open_parens.
4140 2008-07-17 Marek Safar <marek.safar@gmail.com>
4142 * ecore.cs: Custom error message for a range variable assignment.
4144 2008-07-16 Marek Safar <marek.safar@gmail.com>
4146 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
4149 2008-07-16 Marek Safar <marek.safar@gmail.com>
4151 * literal.cs: Null literal is of object type.
4153 2008-07-16 Marek Safar <marek.safar@gmail.com>
4155 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
4156 expression of nullable equality comparison.
4158 2008-07-15 Marek Safar <marek.safar@gmail.com>
4160 * expression.cs(PointerArithmetic): Removed redundant assignment.
4162 2008-07-15 Marek Safar <marek.safar@gmail.com>
4164 * decl.cs (GetSignatureForError): Report full namespace name for containers.
4166 2008-07-14 Marek Safar <marek.safar@gmail.com>
4168 A fix for bug #408361
4169 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
4170 they are replaced by GetMethod.
4172 2008-07-14 Marek Safar <marek.safar@gmail.com>
4174 A fix for bug #408721 by jeremie.laval@gmail.com
4175 * expression.cs (Indirection): Implemented CloneTo.
4177 2008-07-14 Marek Safar <marek.safar@gmail.com>
4179 * statement.cs (AssignableSlots): Temporary disabled variable initialization
4182 2008-07-14 Marek Safar <marek.safar@gmail.com>
4184 * report.cs (EnableReporting): Don't reinitialize 0-based values.
4186 2008-07-11 Marek Safar <marek.safar@gmail.com>
4188 * linq.cs: Reset tranparent parameter counter in probing mode.
4190 2008-07-11 Marek Safar <marek.safar@gmail.com>
4192 * anonymous.cs: Mutate anonymous method type.
4194 2008-07-11 Marek Safar <marek.safar@gmail.com>
4196 * ecore.cs, anonymous.cs: Mutate field expressions.
4198 2008-07-10 Marek Safar <marek.safar@gmail.com>
4200 A fix for bug #369670
4201 * linq.cs, statement.cs: Use explicit block for query expressions variables.
4203 2008-07-10 Marek Safar <marek.safar@gmail.com>
4205 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
4207 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
4210 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4211 only one '>', and finds a '>>', abort the generic lookahead.
4213 2008-07-10 Marek Safar <marek.safar@gmail.com>
4215 A fix for bug #319902
4216 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4218 2008-07-10 Marek Safar <marek.safar@gmail.com>
4220 A fix for bug #406371
4221 * statement.cs: Moved EmitSymbolInfo to Block.
4223 2008-07-09 Marek Safar <marek.safar@gmail.com>
4225 * ecore.cs: Report better error for extension method overload failures.
4227 2008-07-09 Marek Safar <marek.safar@gmail.com>
4229 * expression.cs (Is): No need to box reference values.
4231 2008-07-09 Marek Safar <marek.safar@gmail.com>
4233 * class.cs: Use event resolve context when initializing CreateEmitContext.
4235 2008-07-09 Marek Safar <marek.safar@gmail.com>
4237 A fix for bug #394436
4238 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4239 method used inside expression trees. Added more LINQ to expression tree
4242 2008-07-08 Marek Safar <marek.safar@gmail.com>
4244 A fix for bug #378189, #370577
4245 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4248 2008-07-08 Marek Safar <marek.safar@gmail.com>
4250 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4253 2008-07-08 Marek Safar <marek.safar@gmail.com>
4255 A fix for bug #406702
4256 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4258 2008-07-07 Marek Safar <marek.safar@gmail.com>
4260 A fix for bug #406648
4261 * cs-parser.jay: Report nullable use in mcs for some cases.
4263 2008-07-07 Marek Safar <marek.safar@gmail.com>
4265 * ecore.cs: Improved argument mismatch error messages.
4267 2008-07-07 Marek Safar <marek.safar@gmail.com>
4269 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4271 2008-07-07 Marek Safar <marek.safar@gmail.com>
4273 * expression.cs (TypeOf): Mutate type argument.
4275 2008-07-04 Marek Safar <marek.safar@gmail.com>
4277 * class.cs: Report missing partial modifier for correct type.
4279 2008-07-04 Marek Safar <marek.safar@gmail.com>
4281 * ecore.cs, expression.cs (VariableReference): Variable property is
4284 2008-07-04 Marek Safar <marek.safar@gmail.com>
4286 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4288 2008-07-04 Marek Safar <marek.safar@gmail.com>
4290 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4293 2008-07-04 Marek Safar <marek.safar@gmail.com>
4295 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4296 anonymous method storey to an instance method when only "this" is hoisted.
4298 2008-07-03 Marek Safar <marek.safar@gmail.com>
4300 A fix for bug #321615
4301 * expression.cs: Pointer comparisons use unsigned operator.
4303 2008-07-03 Marek Safar <marek.safar@gmail.com>
4305 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4307 2008-07-02 Marek Safar <marek.safar@gmail.com>
4309 A fix for bug #404905
4310 * class.cs: Always initialize local unsafe variables.
4312 2008-06-30 Marek Safar <marek.safar@gmail.com>
4314 A fix for bug #396987
4315 * expression.cs (NewInitialize): Clear local temporary variable for next run
4317 2008-06-27 Marek Safar <marek.safar@gmail.com>
4319 A fix for bug #401020
4320 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4322 2008-06-27 Marek Safar <marek.safar@gmail.com>
4324 A fix for bug #398319
4325 * cs-parser.jay: Implemented undocumented base access expression inside
4328 2008-06-26 Marek Safar <marek.safar@gmail.com>
4330 A fix for bug #404227
4331 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4333 2008-06-26 Marek Safar <marek.safar@gmail.com>
4335 A fix for bug #404227
4336 * convert.cs: Fixed explicit array to interface cast.
4338 2008-06-26 Marek Safar <marek.safar@gmail.com>
4340 A fix for bug #403894
4341 * delegate.cs: Mutate DelegateInvocation type.
4343 2008-06-26 Marek Safar <marek.safar@gmail.com>
4345 A fix for bug #379348
4346 * delegate.cs: Box a load of generic parameters.
4348 2008-06-26 Marek Safar <marek.safar@gmail.com>
4350 * expression.cs: Add an array creation arguments mutate.
4352 2008-06-26 Marek Safar <marek.safar@gmail.com>
4354 A fix for bug #386068
4355 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4358 2008-06-25 Marek Safar <marek.safar@gmail.com>
4360 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4363 2008-06-25 Marek Safar <marek.safar@gmail.com>
4365 A fix for bug #403518
4366 * delegate.cs: Type correctly anonymous method new invocation.
4368 2008-06-24 Marek Safar <marek.safar@gmail.com>
4370 A fix for bug #394826
4371 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4374 2008-06-24 Marek Safar <marek.safar@gmail.com>
4376 A fix for bug #394826
4377 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4380 2008-06-24 Marek Safar <marek.safar@gmail.com>
4382 * class.cs: Clone indexer parameters for localized capturing.
4384 2008-06-24 Marek Safar <marek.safar@gmail.com>
4386 A fix for bug #402379
4387 * expression.cs: Don't crash when an object initializer resolve fails.
4389 2008-06-24 Marek Safar <marek.safar@gmail.com>
4391 A fix for bug #402888
4392 * expression.cs: Mutate conditional expression.
4394 2008-06-24 Marek Safar <marek.safar@gmail.com>
4396 A fix for bug #401012
4397 * class.cs: Keep StructLayout in shared container.
4399 2008-06-24 Marek Safar <marek.safar@gmail.com>
4401 A fix for bug #400438
4402 * decl.cs, class.cs: Only properties can be automatically implemented.
4404 2008-06-24 Marek Safar <marek.safar@gmail.com>
4406 * statement.cs (ChangeToIterator): Copy also labels.
4408 2008-06-23 Marek Safar <marek.safar@gmail.com>
4410 * ecore.cs: Pass type argument details to parent extension method.
4412 2008-06-23 Marek Safar <marek.safar@gmail.com>
4414 A fix for bug #375966
4415 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4417 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4419 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4421 2008-06-22 Marek Safar <marek.safar@gmail.com>
4423 A fix for bug #394347
4424 * anonymous.cs: Cache compatible delegates as compatibility check produces
4425 a new method every time.
4427 2008-06-20 Marek Safar <marek.safar@gmail.com>
4429 * anonymous.cs: Propagate storey reference for single references.
4431 2008-06-20 Marek Safar <marek.safar@gmail.com>
4433 A fix for bug #387615
4434 * assign.cs, expression.cs: Correctly clone compound assignment.
4436 2008-06-19 Marek Safar <marek.safar@gmail.com>
4438 A fix for bug #359611, #359604
4439 * anonymous.cs: Mutate all types of hoisted parameters.
4441 2008-06-19 Marek Safar <marek.safar@gmail.com>
4443 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4444 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4445 expression.cs, codegen.cs, statement.cs
4447 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4448 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4450 ** Anonymous methods, lambda expressions rewrite **
4452 Anonymous expressions are now resolved when an explicit block is resolved
4453 and they don't require any registration procedure anymore. Further,
4454 anonymous methods are defined when explicit block is emitted which allows
4455 better control of whole process and opens possibilities for more
4456 optimizations as well as alternative to reverse whole process.
4458 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4459 process consistent and to correctly emit hoisted generic methods when they
4460 have at least 1 hoisted variable.
4462 2008-06-17 Martin Baulig <martin@ximian.com>
4464 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4466 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4467 virtual property; check it in Emit().
4468 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4470 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4472 (Indexer.Define): Likewise.
4474 2008-06-17 Marek Safar <marek.safar@gmail.com>
4476 * convert.cs: Don't use IsInterface on type arguments.
4478 * delegate.cs: DelegateInvocation uses MethodInfo.
4480 * parameter.cs: Removed IsTypeParameter.
4482 * generic-mcs.cs: More missing stuff.
4484 2008-06-16 Martin Baulig <martin@ximian.com>
4487 (Modifiers.DEBUGGER_HIDDEN): New public const.
4490 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4493 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4494 (AbstractPropertyEventMethod): Likewise.
4495 (Constructor.Emit): Likewise.
4496 (SourceMethod.SetCompilerGenerated): Removed.
4498 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4502 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4503 if we're an `IteratorHost'.
4504 (AnonymousMethodMethod..ctor): Don't set
4505 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4508 2008-06-16 Marek Safar <marek.safar@gmail.com>
4510 * statement.cs: Clean-up foreach statements.
4512 2008-06-12 Marek Safar <marek.safar@gmail.com>
4514 * class.cs: Stop using public method which should not exist
4515 (MethodBuilder.SetGenericMethodSignature).
4517 2008-06-11 Martin Baulig <martin@ximian.com>
4520 (Location.LookupFile): Add `CompilationUnit' argument; when given
4521 a relative file name, make it relative to the directory the .cs
4522 file is located in instead of using the current directory.
4524 2008-06-11 Martin Baulig <martin@ximian.com>
4527 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4528 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4529 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4530 (SourceMethod.SetCompilerGenerated): Likewise.
4532 2008-06-11 Marek Safar <marek.safar@gmail.com>
4534 * codegen.cs, driver: Only write symbol file when it's asked for.
4536 2008-06-11 Marek Safar <marek.safar@gmail.com>
4538 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4540 2008-06-10 Martin Baulig <martin@ximian.com>
4542 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4544 2008-06-09 Marek Safar <marek.safar@gmail.com>
4546 A fix for bug #316290
4547 * expression.cs: Include decimal operators in predefined table.
4549 * parameters.cs: More readonlyness.
4551 2008-06-09 Marek Safar <marek.safar@gmail.com>
4553 A fix for bug #397213
4554 * cs-parser.jay: One more missing current_local_parameters reset.
4556 2008-06-09 Marek Safar <marek.safar@gmail.com>
4558 A fix for bug #396633
4559 * class.cs: Host backing field in partial container.
4561 2008-06-09 Marek Safar <marek.safar@gmail.com>
4563 A fix for bug #397068
4564 * expression.cs: Check both operand types when predefined operator is used.
4566 2008-06-05 Martin Baulig <martin@ximian.com>
4568 Merged the `debugger-kahalo' branch.
4571 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4572 we're an iterator method.
4573 (SourceMethod): Reflect latest symbol writer changes;
4574 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4575 now `start_row' and `end_row'.
4576 (Constructor.Emit): Fix the logic whether to emit symbol information.
4578 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4582 (CompilationUnit): New public class; derives from `SourceFile'.
4583 (SourceFileEntry.DefineSymbolInfo): New public method.
4584 (SourceFileEntry.SetChecksum): New public method.
4585 (Location): Encode hidden line numbers by using `column == 255';
4586 the .ctor now accepts `column == -1' to mark a hidden line number.
4587 (Location.Hidden): New public property.
4588 (Location.CheckPoint): Add `CompilationUnit'.
4589 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4590 (Location.Push): Add `CompilationUnit compile_unit' argument.
4591 (Location.CompilationUnit): New public property.
4594 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4596 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4598 * driver.cs: `SourceFile' -> `CompilationUnit'.
4600 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4602 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4604 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4608 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4609 new symbol writer API to also pass the file.
4611 2008-06-05 Marek Safar <marek.safar@gmail.com>
4613 * statement.cs: Emit catch variable assignment using variable expression.
4615 2008-06-05 Marek Safar <marek.safar@gmail.com>
4617 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4618 with other variable types.
4620 2008-06-04 Marek Safar <marek.safar@gmail.com>
4622 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4623 GetLength method emit, it breaks resolve rules.
4625 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4626 Marek Safar <marek.safar@gmail.com>
4628 A fix for bug #395542
4629 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4632 2008-06-02 Marek Safar <marek.safar@gmail.com>
4634 A fix for bug #395287
4635 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4637 2008-05-31 Marek Safar <marek.safar@gmail.com>
4639 A fix for bug #395845
4640 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4641 non-nullable parameter type.
4643 2008-05-31 Marek Safar <marek.safar@gmail.com>
4645 * class.cs: Handle contructor initializer as a statement in top-level block.
4647 2008-05-30 Marek Safar <marek.safar@gmail.com>
4649 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4650 security attributes.
4652 2008-05-24 Marek Safar <marek.safar@gmail.com>
4654 * ecore.cs, expression.cs: Small IVariable refactoring.
4656 2008-05-22 Marek Safar <marek.safar@gmail.com>
4658 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4660 2008-05-21 Marek Safar <marek.safar@gmail.com>
4662 * cs-parser.jay: Removed redundant catch type check.
4664 2008-05-21 Marek Safar <marek.safar@gmail.com>
4666 A fix for bug #390372
4667 * nullable.cs: Set correct return type.
4669 2008-05-21 Marek Safar <marek.safar@gmail.com>
4671 A fix for bug #391062
4672 * typemanager.cs: Fixed crash when comparing null types.
4674 2008-05-21 Marek Safar <marek.safar@gmail.com>
4676 A fix for bug #391871
4677 * cs-parser.jay: Better error handling for invalid catch type.
4679 2008-05-20 Marek Safar <marek.safar@gmail.com>
4681 A fix for bug #392155
4682 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4684 2008-05-15 Marek Safar <marek.safar@gmail.com>
4686 A fix for bug #390666
4687 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4690 2008-05-15 Marek Safar <marek.safar@gmail.com>
4692 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4695 2008-05-13 Marek Safar <marek.safar@gmail.com>
4697 A fix for bug #389625
4698 * delegate.cs, generic.cs: Some progress on method group return type
4701 2008-05-13 Marek Safar <marek.safar@gmail.com>
4703 A fix for bug #378419
4704 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4706 2008-05-12 Marek Safar <marek.safar@gmail.com>
4708 * class.cs (Constructor): Added IsCompilerGenerated.
4710 2008-05-12 Marek Safar <marek.safar@gmail.com>
4712 * expression.cs: Enum binary operators can accept non-enum operand only when
4713 is implicitly convertible to underlying type.
4715 2008-05-12 Marek Safar <marek.safar@gmail.com>
4717 A fix for bug #389272
4718 * support.cs: Workaround System.InvalidOperationException for enums.
4720 2008-05-12 Marek Safar <marek.safar@gmail.com>
4722 A fix for bug #389073
4723 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4725 2008-05-10 Marek Safar <marek.safar@gmail.com>
4727 * driver.cs: Split Parse.
4729 * location.cs (LookupFile): Uses string.Empty.
4731 2008-05-07 Marek Safar <marek.safar@gmail.com>
4733 * expression.cs, parameter.cs: Small ParameterReference clean up.
4735 2008-05-07 Marek Safar <marek.safar@gmail.com>
4737 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4738 hack. Fixes #387502.
4740 2008-05-06 Martin Baulig <martin@ximian.com>
4742 * class.cs (Constructor.Emit): Fix the logic whether to emit
4745 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4748 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4749 InvalidOperationException when the iterator is before the start or
4752 2008-05-06 Marek Safar <marek.safar@gmail.com>
4754 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4755 when left is nullable type.
4757 2008-05-06 Marek Safar <marek.safar@gmail.com>
4759 A fix for bug #386628
4760 * expression.cs (LocalVariableReference): Continue in resolving when
4761 variable is not assigned.
4763 2008-05-05 Marek Safar <marek.safar@gmail.com>
4765 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4766 nullable operations.
4768 2008-05-04 Marek Safar <marek.safar@gmail.com>
4770 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4771 it saves many redundant temporary variables for nullable operations.
4773 2008-05-03 Marek Safar <marek.safar@gmail.com>
4775 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4777 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4780 * nullable.cs: Constant coalescing operator optimizations.
4782 2008-05-03 Marek Safar <marek.safar@gmail.com>
4784 * constant.cs: Use unsigned conversion for values which are unsigned only.
4786 2008-05-03 Marek Safar <marek.safar@gmail.com>
4788 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4789 coalescing operator as it should be.
4791 2008-05-02 Marek Safar <marek.safar@gmail.com>
4793 A fix for bug #371016
4794 * expression.cs: All predefined delegate operators require implicit method
4797 2008-05-02 Marek Safar <marek.safar@gmail.com>
4799 * constant.cs: Emit long constant as uint when fits the range.
4801 * convert.cs, expression.cs: Fixed few unsafe conversions.
4803 2008-05-02 Marek Safar <marek.safar@gmail.com>
4805 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4807 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4810 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4812 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4814 2008-05-01 Marek Safar <marek.safar@gmail.com>
4816 * constant.cs, literal.cs: IsLiteral property for error reporting.
4818 * ecore.cs, expression.cs: Implemented Property expression.
4820 2008-05-01 Marek Safar <marek.safar@gmail.com>
4822 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4824 * nullable.cs: Implemented nullable coalescing null operator.
4826 * ecore.cs, expression.cs: Expression trees work.
4828 2008-05-01 Marek Safar <marek.safar@gmail.com>
4830 * ecore.cs: CreateExpressionTree is finally abstract.
4832 * expression.cs, linq.cs: Updated.
4834 2008-05-01 Marek Safar <marek.safar@gmail.com>
4836 * expression.cs, ecore.cs: Block base access expression inside expression
4839 2008-05-01 Marek Safar <marek.safar@gmail.com>
4841 A fix for bug #385058
4842 * expression.cs: User-defined operator implementations always take
4843 precedence over predefined operator implementations.
4845 2008-04-30 Marek Safar <marek.safar@gmail.com>
4847 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4848 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4849 expression tree conversions.
4851 2008-04-30 Marek Safar <marek.safar@gmail.com>
4853 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4854 operators method details to Operator class.
4856 2008-04-30 Marek Safar <marek.safar@gmail.com>
4858 * anonymous.cs: Pass unsafe flags to anonymous container.
4860 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4861 inside expression tree.
4863 2008-04-29 Martin Baulig <martin@ximian.com>
4865 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4866 (Tokenizer.PopPosition): Also restore the `line'.
4868 2008-04-29 Marek Safar <marek.safar@gmail.com>
4870 * delegate.cs: Implemented Invoke expression.
4872 2008-04-29 Marek Safar <marek.safar@gmail.com>
4874 * expression.cs: Fixed equality reference comparison regression.
4876 2008-04-29 Marek Safar <marek.safar@gmail.com>
4878 * ecore.cs: Clean up EmptyCast hack.
4880 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4881 using correct conversion rules. Also fixes #383993.
4883 2008-04-28 Martin Baulig <martin@ximian.com>
4885 * class.cs (Constructor.Emit): Don't emit debugging information
4886 for generated default .ctor's.
4888 2008-04-28 Marek Safar <marek.safar@gmail.com>
4890 * convert.cs: Empty-cast ushort to int conversion.
4892 2008-04-28 Marek Safar <marek.safar@gmail.com>
4894 A fix for bug #384191
4895 * ecore.cs, expression.cs: Fixed expression cloning.
4897 2008-04-28 Marek Safar <marek.safar@gmail.com>
4899 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4901 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4903 Fix #381559, test-638.cs, test-639.cs
4904 * assign.cs (CompoundAssign.Helper): New wrapper.
4905 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4907 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4908 Pass unconverted expressions to the params array creation expression.
4909 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4910 (PropertyExpr.EmitAssign): Likewise.
4911 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4912 element if it is of kind CompoundAssign.Helper.
4913 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4914 first before anything else.
4915 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4916 (ArrayAccess.LoadArrayAndArguments): Simplify.
4918 2008-04-27 Marek Safar <marek.safar@gmail.com>
4920 * expression.cs: Fixed cloning of typeof(void).
4922 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4924 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4925 (Assign.Emit): Likewise. Move it to ...
4926 (CompoundAssign.DoResolve): ... here and ...
4927 (CompoundAssign.Emit): ... here.
4928 (EventAddOrRemove): New helper to handle += and -= on events, and
4929 avoid the use of BinaryDelegates.
4930 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4931 (EventExpr.EmitAddOrRemove): Improve.
4932 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4934 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4935 create VarExprs for 'foo.bar.var'.
4936 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4937 is a highly inappropriate name for its functionality.
4939 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4941 Simplify handling of multiple assignments
4942 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4944 (SimpleAssign): New. Class to be used for normal assignments.
4945 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4946 * expression.cs, parameter.cs, statement.cs: Likewise.
4948 2008-04-25 Marek Safar <marek.safar@gmail.com>
4950 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4951 for incompatible underlying types, more to come, uff.
4953 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4956 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4957 Handle 'leave_copy'.
4959 2008-04-25 Marek Safar <marek.safar@gmail.com>
4961 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4963 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4965 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4966 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4967 * statement.cs (While, Do, For): Allow test to have side effects.
4968 (For.DoEmit): Always emit InitStatement.
4971 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4972 Always create SideEffectConstant.
4973 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4974 of type EnumConstant.
4976 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4977 Handle 'right' being SideEffectConstant of type 'bool'.
4979 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4980 Use left.EmitBranchable instead of open coding it, so as to
4981 improve optimization opportunities.
4983 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4985 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4987 (Expression.EmitSideEffect): Document.
4989 2008-04-23 Marek Safar <marek.safar@gmail.com>
4991 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4993 2008-04-23 Marek Safar <marek.safar@gmail.com>
4995 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4997 2008-04-23 Marek Safar <marek.safar@gmail.com>
4999 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
5000 conversion to expression tree.
5002 2008-04-23 Marek Safar <marek.safar@gmail.com>
5004 * ecore.cs: Removed unused expression.
5006 2008-04-22 Marek Safar <marek.safar@gmail.com>
5008 * expression.cs: Implemented NegateChecked and New expressions.
5010 2008-04-22 Marek Safar <marek.safar@gmail.com>
5012 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
5014 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
5017 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
5018 needing final 'ret' instruction.
5020 2008-04-22 Marek Safar <marek.safar@gmail.com>
5022 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
5024 2008-04-21 Marek Safar <marek.safar@gmail.com>
5026 * expression.cs: Emit ldnull and not null expression as an instance argument
5027 of static method expression calls.
5029 2008-04-21 Marek Safar <marek.safar@gmail.com>
5031 A fix for bug #378200
5032 * expression.cs: Fixed crash when creating parameterless expression tree
5035 2008-04-21 Marek Safar <marek.safar@gmail.com>
5037 A fix for bug #375297
5038 * anonymous.cs: Fixed crash when inferring from null argument anonymous
5041 2008-04-21 Marek Safar <marek.safar@gmail.com>
5043 A fix for bug #377596
5044 * decl.cs, class.cs: Emit delegate type argument attributes.
5046 2008-04-21 Marek Safar <marek.safar@gmail.com>
5048 A fix for bug #365314
5049 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
5051 2008-04-21 Marek Safar <marek.safar@gmail.com>
5053 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
5056 2008-04-21 Marek Safar <marek.safar@gmail.com>
5058 * generic.cs (TypeParameter): Removed redundant location.
5060 2008-04-19 Marek Safar <marek.safar@gmail.com>
5062 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
5063 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
5064 FullNamedExpression in all declaration type expression, statements will come
5067 2008-04-18 Marek Safar <marek.safar@gmail.com>
5069 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
5070 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
5072 2008-04-18 Marek Safar <marek.safar@gmail.com>
5074 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
5077 2008-04-17 Marek Safar <marek.safar@gmail.com>
5079 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
5082 2008-04-17 Marek Safar <marek.safar@gmail.com>
5084 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
5088 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
5090 Hook up 'EmitSideEffect'
5091 * constant.cs (Constant.EmitSideEffect): New.
5092 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
5093 (SideEffectConstant.EmitSideEffect): New.
5094 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
5095 unconditional branch in EmitBranchable.
5096 (FieldExpr.EmitBranchable): New.
5097 * expression.cs (Unary.EmitSideEffect): New.
5098 (Binary.EmitSideEffect): New.
5099 (VariableReference.EmitSideEffect): New. Do nothing.
5101 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5103 Introduce 'EmitSideEffect'
5104 * ecore.cs (Expression.EmitSideEffect): New.
5105 (TypeCast): Rename from EmptyCast.
5107 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
5108 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
5109 * convert.cs, nullable.cs: Update to changes.
5111 2008-04-16 Marek Safar <marek.safar@gmail.com>
5113 * class.cs, cs-parser.jay: Early check for base types expression.
5115 2008-04-16 Marek Safar <marek.safar@gmail.com>
5117 * decl.cs (MemberName): Declare PrettyName as obsolete.
5119 2008-04-16 Marek Safar <marek.safar@gmail.com>
5121 * namespace.cs: Use MemberName comparison.
5123 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
5126 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
5128 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
5129 (MemberName.FullyQualifiedName): New. Provides the functionality
5130 that users assume FullName would have.
5131 * ecore.cs, namespace.cs: Update to changes.
5133 * statement.cs (Using.assign): Make into ExpressionStatement.
5134 (Using.EmitPreTryBody): Simplify.
5136 2008-04-16 Marek Safar <marek.safar@gmail.com>
5138 * report.cs: ColorFormat is protected.
5140 * rootcontext.cs: Unused fields clean-up.
5142 * namespace.cs: Made UsingEntry name private.
5144 2008-04-16 Marek Safar <marek.safar@gmail.com>
5146 * cs-tokenizer.cs, location.cs: Removed unused field.
5148 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
5149 Raja R Harinath <harinath@hurrynot.org>
5152 * constant.cs (SideEffectConstant.value): Rename from 'left'.
5153 (SideEffectConstant.side_effect): Rename from 'right'.
5154 (SideEffectConstant..ctor): Normalize 'side_effect'.
5155 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
5156 value of this constant.
5157 * cfold.cs: Update to changes.
5159 2008-04-15 Marek Safar <marek.safar@gmail.com>
5161 * cs-paser.jay: Removed unused variable.
5163 * driver.cs: Made Compile instance method.
5165 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
5167 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
5169 2008-04-15 Marek Safar <marek.safar@gmail.com>
5171 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
5173 2008-04-13 Jb Evain <jbevain@novell.com>
5175 * namespace.cs: update the System.Core fullname for 2.1
5176 * driver.cs: update the list of required assemblies for 2.1.
5177 Merged from the Moonlight 2 branch.
5179 2008-04-11 Marek Safar <marek.safar@gmail.com>
5181 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
5182 types and user defined operators. User operators arguments has to be checked
5183 for null value before invocation, which also means no operator is called
5184 when any argument is not convertible to unwrapped nullable type.
5186 2008-04-09 Marek Safar <marek.safar@gmail.com>
5188 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
5189 of Unary expressions to follow operator overloading rules precisely.
5190 Also fixes #321794, #323794
5192 2008-04-08 Marek Safar <marek.safar@gmail.com>
5194 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
5197 2008-04-08 Marek Safar <marek.safar@gmail.com>
5199 * expression.cs, ecore.cs: Implemented MemberInit expression.
5201 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
5203 Fix mono/tests/exception4.cs
5204 * statement.cs (ExceptionStatement, TryCatch): Revert to using
5205 ec.NeedReturnLabel () rather emitting a 'nop'.
5207 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
5209 (TryCatch.SomeCodeFollows): Likewise.
5210 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5211 for 'break', 'continue' and 'return' statements inside a try.
5212 We're fairly sure that the generated IL stream will have more
5213 instructions textually following the try.
5214 (FlowBranchingTryCatch): Likewise.
5216 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5217 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5220 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5221 wrapper -- forward everything to CollectionForeach.
5222 (CollectionForeach.NonDisposableWrapper): New.
5223 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5224 instead of a pop + branch to end.
5226 2008-04-07 Marek Safar <marek.safar@gmail.com>
5228 A fix for bug #377485
5229 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5230 Propagate location for extension method groups. Report conversion failure at
5233 2008-04-07 Marek Safar <marek.safar@gmail.com>
5235 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5236 ListInit and Field expressions.
5238 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5240 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5241 Since $PC is always -1 inside the body of MoveNext, the fault
5243 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5244 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5245 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5247 The denouement! Fix #324708
5248 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5249 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5250 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5251 'finally' inside the finally clause.
5253 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5254 inside an iterator. Don't emit the body of the 'finally' inside
5255 the finally clause yet.
5257 Use the ResumableStatement infrastructure for MoveNext ()
5258 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5259 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5260 'old_resume_points'. Move dispatcher upfront.
5261 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5262 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5263 in an enumerator. This encodes the main fix in this patch series
5264 -- we can only jump into the first instruction of a try from the
5265 outside, but we want to emit try/finally regions in iterators and
5266 resume in the middle of them.
5268 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5270 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5271 of NeedReturnLabel here.
5273 Introduce a common point for emitting try/finally to IL
5274 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5275 features of the various subclasses, which are now driven by ...
5276 (ExceptionStatement.EmitPreTryBody): ... this and ...
5277 (ExceptionStatement.EmitTryBody): ... this and the original
5279 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5280 Remove DoEmit and update to follow above protocol.
5282 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5283 of the dispatcher are the same, skip emitting the 'switch'.
5284 * iterator.cs (Iterator.EmitDispose): Update to changes.
5286 Clean up handling of 'using' statement
5287 * statement.cs (UsingTemporary): New. Carved out of ...
5288 (Using): ... this. Simplify drastically. Handle exactly
5290 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5291 or Using as appropriate. If there are multiple variable declared,
5292 create nested Using statements.
5293 (resource_acquisition): Kill.
5295 * statement.cs (ExceptionStatement.EmitForDispose): Use
5296 EmitFinallyBody, not EmitFinally.
5298 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5299 * iterator.cs: Update to changes.
5301 Start using the ResumableStatement infrastructure
5302 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5303 (ResumableStatement.EmitForDispose): New.
5304 (ExceptionStatement): Override them.
5305 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5306 EmitForDispose to create the body of the Dispose method. Don't
5309 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5310 * statement.cs (Toplevel.AddResumePoint): ... here.
5311 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5312 * flowanalysis.cs (FlowBranchingIterator): New.
5313 * codegen.cs (EmitContext): Update to changes.
5315 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5316 (Iterator.old_resume_points): Rename from 'resume_points'.
5317 (Iterator.MoveNextStatement): Remove unused class.
5319 New infrastructure for try/finally in iterators (still unused)
5320 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5321 (FlowBranchingToplevel.AddResumePoint): Hook into
5322 ToplevelBlock.AddResumePoint.
5323 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5324 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5325 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5326 resume points and assign program-counter values.
5327 (ExceptionBlock.AddResumePoint): Collect resume points for
5328 de-muxer at the top of try block.
5329 * iterators.cs (Yield.CheckContext): Simplify.
5330 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5332 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5334 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5335 argument to an ExitStatement.
5336 (FlowBranchingException): Refactor saved origins code.
5337 * statement.cs (ExitStatement): Update to cahges.
5338 * iterator.cs (YieldBreak): Likewise.
5340 * statement.cs (ResumableStatement): New. Common base class for
5341 YieldReturn and ExceptionStatement.
5342 (ExitStatement): New. Common base class for Return and YieldBreak.
5343 (Return): Update to changes.
5344 * iterator.cs (YieldBreak): Likewise.
5345 * lambda.cs (ContextualReturn): Likewise.
5348 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5349 emit a meaningful error message.
5351 Fix #324765, #319508
5352 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5353 (VariableInfo.SetAssigned): Set it.
5354 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5355 determine if CS0219 or CS0168 is appropriate. Don't use
5356 flow-analysis information.
5357 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5358 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5359 (EmitContext.EndFlowBranching): ... this.
5361 2008-04-03 Marek Safar <marek.safar@gmail.com>
5363 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5365 2008-04-03 Marek Safar <marek.safar@gmail.com>
5367 A fix for bug #376508
5368 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5369 ImplicitConversionExists.
5371 2008-04-03 Marek Safar <marek.safar@gmail.com>
5373 * expression.cs (Binary): Added remaining binary operators to expression
5376 * nullable.cs: Optimize shift with null argument.
5378 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5380 Fix minor IL regression
5381 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5382 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5383 * cs-parser.jay (try_statement): Update to changes.
5385 * statement.cs (TryFinally.need_exc_block): Delete.
5386 (TryFinally): Update to changes.
5388 Now all ExceptionStatements are unconditional
5389 * statement.cs (CollectionForeach.DisposableWrapper): New.
5390 Extract out the try/finally code into a new wrapper.
5391 (CollectionForeach.Resolve): Use it to simplify the code.
5393 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5395 Start at simplifying ExceptionStatement semantics a bit
5396 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5397 * cs-parser.jay (try_statement): Update to changes.
5398 (opt_catch_clauses): Remove.
5399 * flowanalysis.cs: Update to changes.
5400 (FlowBranching.BranchingType.TryCatch): New.
5401 (FlowBranchingTryCatch): New.
5403 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5404 (FlowBranching.CreateBranching): Update to changes.
5405 (FlowBranchingBlock.AddSibling): Add sanity check.
5406 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5409 * iterators.cs (Iterator.MarkFinally): Remove.
5410 * statement.cs (ExceptionStatement): Update to changes.
5412 Add support for skipping over finally blocks at runtime. First
5413 in a series to fix #324708
5414 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5415 (Iterator.EmitMoveNext): Initialize it.
5416 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5417 branch over the body of the 'finally' clause.
5419 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5421 Avoid lopsided use of Foo/DoFoo names
5422 * statement.cs (ExpressionStatement.EmitFinallyBody):
5423 Rename from EmitFinally.
5424 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5425 * iterator.cs: Update to changes.
5427 2008-04-02 Marek Safar <marek.safar@gmail.com>
5429 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5430 based on UserOperatorCall. More binary nullable operators clean up.
5432 2008-04-02 Martin Baulig <martin@ximian.com>
5434 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5436 2008-04-02 Marek Safar <marek.safar@gmail.com>
5438 * nullable.cs: Merge user and empty conversions when lifting expression
5441 * expression.cs (StringConcat): Implemented expression tree representation.
5443 2008-04-01 Marek Safar <marek.safar@gmail.com>
5445 * nullable.cs: When lifting null literal and a user operator exists, no call
5448 2008-04-01 Marek Safar <marek.safar@gmail.com>
5450 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5453 2008-04-01 Marek Safar <marek.safar@gmail.com>
5455 * nullable.cs, expression.cs: Use namespace instead heavily nested
5456 monster abstract class.
5458 2008-04-01 Marek Safar <marek.safar@gmail.com>
5460 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5461 lifting of null literal and user operators. Clean up of some temporary
5464 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5466 Fix #368224, test-629.cs
5467 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5468 if it crossed an unwind-protect boundary.
5469 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5470 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5471 inside an unwind-protected region.
5472 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5473 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5474 'leave' instead of a 'br' if unwind-protected.
5475 (Iterator.EmitYieldBreak): Likewise.
5477 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5479 * driver.cs: Only define versioninfo resources if no win32 resource
5482 2008-03-28 Marek Safar <marek.safar@gmail.com>
5484 A fix for bug #372375
5485 * convert.cs: Fixed boxing of nullable types.
5487 2008-03-28 Marek Safar <marek.safar@gmail.com>
5489 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5492 2008-03-28 Marek Safar <marek.safar@gmail.com>
5494 A fix for bug #374619
5495 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5497 2008-03-27 Marek Safar <marek.safar@gmail.com>
5499 * lambda.cs: Check return type only for invocation.
5501 2008-03-27 Marek Safar <marek.safar@gmail.com>
5503 A fix for bug #374214
5504 * ecore.cs: Correctly report argument type mismatch.
5506 2008-03-27 Marek Safar <marek.safar@gmail.com>
5508 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5509 and not rely on broken IsEnum.
5511 2008-03-27 Marek Safar <marek.safar@gmail.com>
5513 * nullable.cs: New file, extracted from generic.cs.
5515 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5517 2008-03-27 Marek Safar <marek.safar@gmail.com>
5519 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5520 predefined comparison operators and null literals.
5522 * report.cs: New warning ID.
5524 2008-03-25 Marek Safar <marek.safar@gmail.com>
5526 A fix for bug #370577
5527 * lambda.cs: Check return type too.
5529 2008-03-25 Marek Safar <marek.safar@gmail.com>
5531 A fix for bug #372846
5532 * class.cs: Automatic properties can be declared as unsafe.
5534 2008-03-20 Marek Safar <marek.safar@gmail.com>
5536 * location.cs: Use string based concatenation.
5538 * expression.cs: LiftedBinaryOperator is gmcs only.
5540 2008-03-20 Marek Safar <marek.safar@gmail.com>
5542 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5543 conversions rules and expression trees.
5545 2008-03-19 Marek Safar <marek.safar@gmail.com>
5547 * delegate.cs: Use extension method source as delegate target.
5549 2008-03-19 Marek Safar <marek.safar@gmail.com>
5551 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5552 binary operations to be purely based on binary operations and optimized
5553 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5554 and other ET refactoring.
5556 * typemanager.cs: Fixed warning.
5558 2008-03-17 Marek Safar <marek.safar@gmail.com>
5560 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5562 * symbolwriter.cs: Fixed.
5564 2008-03-17 Marek Safar <marek.safar@gmail.com>
5566 * anonymous.cs, driver.cs: Reset anonymous types counters.
5568 2008-03-17 Marek Safar <marek.safar@gmail.com>
5570 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5572 * class.cs: Use fullname for all type member definitions.
5574 2008-02-19 Martin Baulig <martin@ximian.com>
5577 (IMethodData.EmitExtraSymbolInfo): New interface method.
5578 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5579 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5580 interface method here as an empty public virtual method.
5583 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5584 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5585 CodeGen.SymbolWriter.SetRealMethodName().
5587 2008-02-18 Martin Baulig <martin@ximian.com>
5590 (ScopeInfo.EmitType): Override this and emit debugging
5591 information for captured variables.
5592 (RootScopeInfo.EmitType): Override this and emit symbol
5593 information for a captured `this'.
5595 2008-02-15 Martin Baulig <martin@ximian.com>
5597 * iterators.cs: Emit debugging info.
5600 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5601 (EmitContext.OmitDebuggingInfo): New public property.
5604 (While): Override Emit() and don't emit symbol info there; do it
5605 inside DoEmit() instead.
5606 (Block.Emit): Omit symbol information while emitting the scope
5607 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5609 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5610 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5611 .ctor to make `IsIterator' work.
5613 2008-03-14 Martin Baulig <martin@ximian.com>
5615 * symbolwriter.cs: Added the new symbol writer function from the
5616 debugger's `terrania' branch; temporarily enclose them inside
5617 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5620 2008-03-14 Martin Baulig <martin@ximian.com>
5623 (SymbolWriter): Make this a public static class.
5626 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5627 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5629 2008-03-14 Marek Safar <marek.safar@gmail.com>
5631 A fix for bug #370577
5632 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5635 2008-03-14 Marek Safar <marek.safar@gmail.com>
5637 * typemanager.cs (CSharpName): Made 250 times faster.
5639 2008-03-13 Marek Safar <marek.safar@gmail.com>
5641 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5643 2008-03-12 Marek Safar <marek.safar@gmail.com>
5645 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5646 crash when predefined field does not exist.
5648 2008-03-12 Marek Safar <marek.safar@gmail.com>
5650 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5652 2008-03-12 Marek Safar <marek.safar@gmail.com>
5654 * class.cs (FixedField): Don't crash when contructors are missing.
5656 2008-03-11 Marek Safar <marek.safar@gmail.com>
5658 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5659 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5660 check internal types accessibility for internal and external types.
5661 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5663 2008-03-11 Marek Safar <marek.safar@gmail.com>
5665 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5666 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5667 attribute.cs, statement: Use corect instance of predefined types (work
5668 related to #364674).
5670 2008-03-07 Marek Safar <marek.safar@gmail.com>
5672 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5674 2008-03-07 Marek Safar <marek.safar@gmail.com>
5676 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5677 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5678 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5679 predefined types clean up, delayed predefined types members initialization
5680 (work related to #364674).
5682 2008-03-05 Marek Safar <marek.safar@gmail.com>
5684 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5686 2008-03-05 Marek Safar <marek.safar@gmail.com>
5688 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5689 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5690 predefined types clean up (work related to #364674).
5692 2008-03-04 Marek Safar <marek.safar@gmail.com>
5694 * ecore.cs: Print an error message instead of throwing exception.
5696 2008-03-04 Marek Safar <marek.safar@gmail.com>
5698 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5699 expression.cs, statement.cs: Unififed null literal representation.
5701 2008-03-03 Marek Safar <marek.safar@gmail.com>
5703 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5704 expression.cs: Refactored binary operators resolve phase and improved speed.
5705 The nullable code is still missing and won't work correctly, more fixes
5708 It also fixes #323726, #324312, #324248, and many other unreported issues.
5710 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5712 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5715 2008-02-27 Marek Safar <marek.safar@gmail.com>
5717 * ecore.cs: Clean-up and split BetterConversion.
5719 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5722 * enum.cs (EnumMember.Value): Only access 'value' if
5723 ResolveValue says it's ok.
5724 (EnumMember.DoResolveValue): Don't set prev_member.value.
5725 (Enum.GetDefinition): Reverse arguments of Equals --
5726 EnumMember.Value can return 'null'.
5728 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5730 2008-02-22 Marek Safar <marek.safar@gmail.com>
5732 * generic.cs, expression.cs: More ongoing work on expression trees.
5734 2008-02-21 Marek Safar <marek.safar@gmail.com>
5736 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5737 handle missing matches when mutiple operators exist.
5739 2008-02-20 Marek Safar <marek.safar@gmail.com>
5741 A fix for bug #363218
5742 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5745 2008-02-20 Marek Safar <marek.safar@gmail.com>
5747 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5748 update. This time to deal correctly with SideEffectConstant expression used
5749 as an argument for another constant folding.
5751 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5753 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5756 2008-02-19 Marek Safar <marek.safar@gmail.com>
5758 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5760 2008-02-19 Marek Safar <marek.safar@gmail.com>
5762 A fix for bug #328136
5763 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5764 side is a false constant, because we still need to evaluate the right-hand
5767 * statement.cs (If): Emit two types of boolean constants (simple constant,
5768 side-effect constant).
5770 2008-02-19 Marek Safar <marek.safar@gmail.com>
5772 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5774 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5777 2008-02-18 Marek Safar <marek.safar@gmail.com>
5779 A fix for bug #361457
5780 * ecore.cs (IsApplicable): Params methods have lower priority.
5782 * support.cs: Return correct parameter modifier for params types.
5784 2008-02-18 Marek Safar <marek.safar@gmail.com>
5786 * generic.cs (TypeParameter): Cache attribute target name.
5788 * support.cs: Removed unused variable.
5790 * typemanager.cs: Removed debugging leftover.
5792 * ecore.cs: Use local type instead of a property;
5794 * class.cs (VerifyMembers): Consider also parent to test whether type member
5797 * expression.cs (FullMethodDesc): Removed.
5799 * attribute.cs (IsValidArgumentType): Made static.
5801 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5803 Cleanup to be more readable.
5804 * Makefile (GMCS_PROFILE): Remove.
5805 (COMPILER_NAME): New helper.
5807 2008-02-15 Miguel de Icaza <miguel@novell.com>
5809 * cs-tokenizer.cs: if a conditional expression happens inside a
5810 (...) this also means that we do not need to de-ambiguate between
5811 an parenthesized expression and a cast.
5815 * constant.cs (SideEffectConstant): a constant value that happens
5816 to have a side effect.
5818 Fixes the build regressions introduced by the fix for #359789
5820 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5822 * expression.cs (Conditional.Emit): when emitting the ternary
5823 operator, use local variables to generate code verifiable code.
5825 The verifier cannot infer that the type on stack before the
5826 stloc.0 is executed is of type ParentB. This happens because the
5827 stack merge algorithm uses only parent types when deciding which
5828 is the common type. This is described in Part III 1.8.1.3 of ECMA
5831 This code compiled with mcs is not verifiable under MS. The MS
5832 verifier picks the first common interface of Foo and Bar, which is
5833 wrong, but doesn't use a full join type of the 2 interfaces.
5835 CSC uses a clever hack to compile such code in a verifiable
5836 way. It stores the intermediate values in a local variable with
5841 2008-02-14 Miguel de Icaza <miguel@novell.com>
5843 * expression.cs: Do not fold BitwiseAnd operators when the left
5844 side is a false constant, because we still need to evaluate the
5849 * support.cs: Instead of throwing an InternalErrorException when
5850 the position of the stream is outside the boundary of our buffer,
5851 reset the state of the reader, and restart the reading from the
5852 beginning of the file.
5854 2008-02-14 Marek Safar <marek.safar@gmail.com>
5856 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5858 2008-02-14 Marek Safar <marek.safar@gmail.com>
5860 A fix for bug #361686
5861 * decl.cs: A protected types used inside a private class which parents
5862 derives from the protected class are accessible.
5864 2008-02-13 Marek Safar <marek.safar@gmail.com>
5866 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5867 the parameterless constructor.
5869 2008-02-13 Marek Safar <marek.safar@gmail.com>
5871 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5872 lookup methods to use standard member cache when doing member lookup.
5874 2008-02-12 Marek Safar <marek.safar@gmail.com>
5876 * driver.cs: Don't report full path for referenced module as assembly error.
5878 2008-02-12 Marek Safar <marek.safar@gmail.com>
5880 * Makefile: Fixed `qh' target to work on all machines.
5882 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5883 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5884 and HasElementType with TypeManager implementation.
5886 2008-02-08 Marek Safar <marek.safar@gmail.com>
5888 A fix for bugs #325134, #359749
5889 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5890 first binds point to non-method member expression.
5892 2008-02-08 Marek Safar <marek.safar@gmail.com>
5894 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5896 2008-02-08 Marek Safar <marek.safar@gmail.com>
5898 A fix for bugs #321394, #323028
5899 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5900 Reworked naive IsAccessibleAs implementation to handle nested types.
5902 2008-02-05 Jb Evain <jbevain@novell.com>
5904 * class.cs: use generic type comparison for parameters
5907 2008-02-05 Marek Safar <marek.safar@gmail.com>
5909 A fix for bug #325372
5910 * class.cs: Use generic type comparison when testing method signatures.
5912 2008-02-05 Marek Safar <marek.safar@gmail.com>
5914 A fix for bug #357047
5915 * ecore.cs: Applied C# 3.0 changes to better conversion.
5917 2008-02-05 Marek Safar <marek.safar@gmail.com>
5919 A fix for bug #358374
5920 * cs-parser.jay: Correctly set modifiers for all constructor types.
5922 2008-02-04 Marek Safar <marek.safar@gmail.com>
5924 A fix for bug #355251
5925 * generic.cs: Added base class constraint based type inference.
5927 2008-02-01 Marek Safar <marek.safar@gmail.com>
5929 A fix for bug #357255
5930 * decl.cs: One more missing visibility check.
5932 2008-02-01 Marek Safar <marek.safar@gmail.com>
5934 * support.cs: Fixed broken return.
5936 2008-01-25 Marek Safar <marek.safar@gmail.com>
5938 * report.cs: Correctly reset warnings count after probing.
5940 2008-01-25 Martin Baulig <martin@ximian.com>
5943 (NamespaceEntry.SymbolFileID): Make this work again after
5944 MemberName.ToString() is gone.
5946 2008-01-25 Marek Safar <marek.safar@gmail.com>
5948 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5951 2008-01-25 Marek Safar <marek.safar@gmail.com>
5953 * generic.cs: Use full implicit conversion for type inference fixing.
5955 2008-01-24 Marek Safar <marek.safar@gmail.com>
5957 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5958 Fixed user operator conversions.
5960 2008-01-24 Marek Safar <marek.safar@gmail.com>
5962 * generic.cs: Do nullable type to null comparison optimization during
5965 2008-01-24 Marek Safar <marek.safar@gmail.com>
5967 A fix for bug #355163
5968 * generic.cs: Enabled l-value resolve on nullable expressions.
5970 2008-01-24 Marek Safar <marek.safar@gmail.com>
5972 A fix for bug #353986
5973 * class.cs: Ingore static ctors with parameters for any further checks.
5975 2008-01-24 Marek Safar <marek.safar@gmail.com>
5977 A fix for bug #354310
5978 * namespace.cs: Removed redundant check.
5980 2008-01-24 Marek Safar <marek.safar@gmail.com>
5982 A fix for bug #354928
5983 * expression.cs: ElementInitializers can be resolved only once.
5985 2008-01-24 Marek Safar <marek.safar@gmail.com>
5987 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5988 Condition expressions.
5990 2008-01-23 Marek Safar <marek.safar@gmail.com>
5992 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5994 2008-01-22 Marek Safar <marek.safar@gmail.com>
5996 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5999 * generic.cs: Implemented coalesce expression.
6001 2008-01-22 Marek Safar <marek.safar@gmail.com>
6003 A fix for bug #355145
6004 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
6005 expression tree type inference.
6007 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
6010 * expression.cs (Binary.IsUnsignedType): Fix typo.
6012 2008-01-22 Marek Safar <marek.safar@gmail.com>
6014 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
6016 2008-01-22 Marek Safar <marek.safar@gmail.com>
6018 A fix for bug #355161
6019 * ecore.cs, expression.cs: Wider range of extension method supported
6022 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
6024 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
6025 AssemblyBuilder to operate in compiler context. Fixes mcs part of
6028 2008-01-22 Marek Safar <marek.safar@gmail.com>
6030 A fix for bug #355148
6031 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
6033 2008-01-22 Miguel de Icaza <miguel@novell.com>
6035 * expression.cs (CreateExpressionTree): Add support for or and
6036 logical or, and indent following the coding conventions.
6038 * typemanager.cs (LinqExpression): renamed from
6039 ExpressionTreeManager, for a shorter name.
6041 Use TypeManager.CoreLookupType to lookup types from our core
6042 assemblies and turn those into "Type" variables.
6044 Consumers that previously used "Namespace" and "Type" from this
6045 class should instead use the TypeExpression which is a type that
6046 is fully resolved (without involving the regular C# resolution
6049 This typically looks like this:
6051 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
6052 new MemberAccess (texpr, name, type_arguments, loc)
6054 This avoids the problem in: #355178
6056 2008-01-21 Marek Safar <marek.safar@gmail.com>
6058 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
6059 feature in parser only as we do in other cases.
6061 2008-01-21 Marek Safar <marek.safar@gmail.com>
6063 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
6064 typemanager.cs: A refactoring of params arguments to reuse existing
6065 expressions (params -> array initializer) to emit params argument instead
6066 of specialized handling.
6067 It was required by expression tree implementation and it has other benefits
6068 as well, we now apply same optimization for params arguments as we do for
6071 2008-01-18 Marek Safar <marek.safar@gmail.com>
6073 A fix for bug #353526
6074 * generic.cs: A type inference of params arguments may not required any
6075 temporary array creation.
6077 2008-01-18 Marek Safar <marek.safar@gmail.com>
6079 A fix for bug #353534
6080 * generic.cs, ecore.cs, expression.cs: A method group type inference is
6081 supported for delegates only.
6083 2008-01-18 Marek Safar <marek.safar@gmail.com>
6085 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
6086 type for more than 1 candidates.
6088 2008-01-18 Marek Safar <marek.safar@gmail.com>
6090 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
6093 2008-01-16 Marek Safar <marek.safar@gmail.com>
6095 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
6096 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
6097 operator) expressions.
6099 2008-01-16 Zoltan Varga <vargaz@gmail.com>
6101 * statement.cs: Avoid declaring an IL variable for this_variable since it is
6102 not accessed from the generated IL.
6104 2008-01-14 Marek Safar <marek.safar@gmail.com>
6106 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
6107 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
6108 statement.cs: The first expression tree implementation drop, mostly
6109 infrastructure work.
6111 2008-01-14 Marek Safar <marek.safar@gmail.com>
6113 * ecore.cs (IsNestedChild): Refactored.
6115 2008-01-11 Marek Safar <marek.safar@gmail.com>
6117 * lambda.cs: Don't use a cast on unknown expression statement.
6119 2008-01-10 Geoff Norton <gnorton@novell.com>
6121 * cs-tokenizer.cs: One more token to distinguish between method and lambda
6124 2008-01-09 Marek Safar <marek.safar@gmail.com>
6126 * doc.cs: Report better /doc crash details.
6128 2008-01-09 Marek Safar <marek.safar@gmail.com>
6130 A fix for bug #352536
6131 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
6133 2008-01-08 Marek Safar <marek.safar@gmail.com>
6135 A fix for bug #352287
6136 * ecore.cs, expression.cs: Do `this' access checking in all member access
6139 2008-01-08 Marek Safar <marek.safar@gmail.com>
6141 * rootcontext.cs, driver.cs: Switch to linq mode by default.
6143 * report.cs: Reset message stacks.
6145 2008-01-08 Marek Safar <marek.safar@gmail.com>
6147 * generic.cs (InferInPhases): Correctly calculate params position.
6149 2008-01-08 Marek Safar <marek.safar@gmail.com>
6151 * cs-tokenizer.cs: No need to parse full string when parsing lambda
6154 2008-01-07 Marek Safar <marek.safar@gmail.com>
6156 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
6158 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
6160 * driver.cs: Updated --help option.
6162 2008-01-07 Marek Safar <marek.safar@gmail.com>
6164 * generic.cs (InferParamsTypeArguments): Removed.
6165 (InferInPhases): Add params type inference.
6166 (LowerBoundInference): Fixed scoring mechanism.
6168 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
6170 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
6172 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
6173 byte array for unsigned "baked" assemblies.
6175 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
6177 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
6178 array for assemblies that are not strongnamed.
6180 2008-01-04 Marek Safar <marek.safar@gmail.com>
6182 A fix for bug #351481
6183 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
6184 declaring type for nested generic types.
6186 2008-01-04 Marek Safar <marek.safar@gmail.com>
6188 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
6189 instead of ToString.
6191 2008-01-03 Marek Safar <marek.safar@gmail.com>
6193 A fix for bug #351047
6194 * expression.cs (Binary.ResolveOperator): Allow equality operators between
6195 null and structs only when equality and inequality operators are defined
6196 either as an user-operators or predefined operators.
6198 2008-01-03 Marek Safar <marek.safar@gmail.com>
6200 A fix for bug #351047
6201 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
6203 2008-01-03 Marek Safar <marek.safar@gmail.com>
6205 A fix for bug #351257
6206 * cs-tokenizer.cs: Advance line number for '\r' correctly.
6208 2008-01-03 Marek Safar <marek.safar@gmail.com>
6210 A fix for bug #351157
6211 * class.cs (Using): Fixed yet another broken cloning.
6213 (Block): Put back more sensible default value for statements.
6215 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6217 * codegen.cs: Allow AssemblyVersion with only major version component.
6220 2007-12-29 Marek Safar <marek.safar@gmail.com>
6222 A fix for bug #324654
6223 * class.cs: Use FullName property as member name.
6225 2007-12-28 Marek Safar <marek.safar@gmail.com>
6227 A fix for bug #342117
6228 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6229 constructor constraint.
6231 2007-12-28 Marek Safar <marek.safar@gmail.com>
6233 A fix for bug #338273
6234 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6237 2007-12-28 Marek Safar <marek.safar@gmail.com>
6239 A fix for bug #350839
6240 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6242 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6244 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6247 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6249 * statement.cs: Changed some Hashtables to use HybridDictionaries
6250 instead. It was observed that some HashTables only contained a few
6251 items in the vast majority of cases. Since HybridDictionary is
6252 more efficient on small sets (<10 elements), "known_variables"
6253 from class ExplicitBlock as well as "labels" and "constants " from
6254 class Block were changed to HybridDictionaries.
6256 Atsai results: (56216kb->54987kb)
6258 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6261 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6263 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6266 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6268 * expression.cs: foreach loop to for loop, saved on allocation of
6269 enumerator (59333kb->59141kb)
6271 * statement.cs. Changed foreach loops to for loops, saved on
6272 allocation of enumerator (59141kb->59006kb)
6274 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6275 when constructed with no specified capacity. This was causing a
6276 few ArrayLists to allocate more memory than they would potentially
6277 need in the Block class and MemberCache class. Setting the
6278 ArrayLists to construct with a capacity of 1 saves some
6279 memory. (56216kb->55585kb)
6281 2007-12-27 Marek Safar <marek.safar@gmail.com>
6283 A fix for bug #347189 (2nd issue)
6284 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6287 2007-12-27 Miguel de Icaza <miguel@novell.com>
6289 * report.cs: Do not use colors if stdout and stderr are not a
6292 2007-12-27 Marek Safar <marek.safar@gmail.com>
6294 A fix for bug #346998
6295 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6298 2007-12-27 Marek Safar <marek.safar@gmail.com>
6300 A fix for bug #343465
6301 * class.cs: Explicit method name for nested types uses dots only.
6303 2007-12-27 Marek Safar <marek.safar@gmail.com>
6305 A fix for bug #343707
6306 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6308 2007-12-27 Marek Safar <marek.safar@gmail.com>
6310 * ecore.cs: Report type inference errors only when arguments count matches
6313 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6315 * expression.cs, report.cs: New warning.
6317 * typemanager.cs: Catch anonymous method type too.
6319 2007-12-23 Marek Safar <marek.safar@gmail.com>
6321 A fix for bug #346379
6322 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6324 2007-12-23 Marek Safar <marek.safar@gmail.com>
6326 A fix for bug #347359
6327 * expression.cs (Invocation): Don't resolve already resolved expression.
6329 2007-12-23 Marek Safar <marek.safar@gmail.com>
6331 A fix for bug #347189
6332 * class.cs (FixedField): Use non-dependent code only in the define phase.
6334 2007-12-23 Marek Safar <marek.safar@gmail.com>
6336 A fix for bug #348076
6337 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6339 2007-12-22 Marek Safar <marek.safar@gmail.com>
6341 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6342 discovered extension methods.
6344 2007-12-22 Marek Safar <marek.safar@gmail.com>
6346 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6349 2007-12-21 Miguel de Icaza <miguel@novell.com>
6351 * report.cs (ErrorMessage): Add support for using colors on
6352 terminals that support it.
6354 2007-12-21 Marek Safar <marek.safar@gmail.com>
6356 * ecore.cs: Use information about expanded params for error reporting.
6358 2007-12-21 Marek Safar <marek.safar@gmail.com>
6360 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6361 and logic for params overloads.
6363 2007-12-15 Miguel de Icaza <miguel@novell.com>
6365 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6366 as this is also created from the parser. Fixes #349034
6368 2007-12-12 Miguel de Icaza <miguel@novell.com>
6370 * statement.cs (Throw.CloneTo): it is valid to have empty
6371 expressions for throw.
6373 2007-12-03 Marek Safar <marek.safar@gmail.com>
6375 * cs-parser.jay: Set delegate constraint parsing region correctly.
6377 2007-12-03 Marek Safar <marek.safar@gmail.com>
6379 A fix for bug #345467
6380 * typemanager.cs (IsEqual): Compare generic parameters position only.
6382 2007-11-28 Marek Safar <marek.safar@gmail.com>
6384 * expression.cs (BaseAccess): Type arguments can be null.
6386 2007-11-27 Raja R Harinath <harinath@gmail.com>
6388 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6389 consistent even when an error has occured.
6390 (Switch.Resolve): Likewise.
6392 2007-11-22 Marek Safar <marek.safar@gmail.com>
6394 A fix for bug #334505
6395 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6398 2007-11-22 Marek Safar <marek.safar@gmail.com>
6400 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6401 refactorings required to resolve extension methods correctly when mixing
6402 generics and non-generics members.
6404 2007-11-20 Marek Safar <marek.safar@gmail.com>
6406 A fix for bug #342584
6407 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6410 2007-11-19 Marek Safar <marek.safar@gmail.com>
6412 A fix for bug #342512
6413 * delegate.cs: Use delegate argument expression when is available. Don't
6414 emit virtual call when class is sealed.
6416 2007-11-16 Marek Safar <marek.safar@gmail.com>
6418 A fix for bug #325423
6419 * assign.cs (FieldInitializer): Use resolved expression for emit.
6421 * class.cs: Print less confusing error message.
6423 2007-11-16 Marek Safar <marek.safar@gmail.com>
6425 * cs-tokenizer.cs: Removed GMCS ifdefs.
6427 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6430 * cs-parser.jay: Disabled nullable check.
6432 * generic-mcs: Copied more generic stuff.
6434 2007-11-16 Marek Safar <marek.safar@gmail.com>
6436 * gcs-parser.jay: Merged to cs-parser.jay.
6438 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6439 * *.csproj, *.sources: Updated to use only jay parser file.
6441 2007-11-16 Marek Safar <marek.safar@gmail.com>
6443 * gcs-parser.jay: Added nullable and default expression feature checks.
6445 2007-11-16 Marek Safar <marek.safar@gmail.com>
6447 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6448 it fixes many TODOs and hidden bugs.
6450 * expression: Removed duplicate error check.
6452 2007-11-15 Marek Safar <marek.safar@gmail.com>
6454 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6455 implicitly type local variable only when it is used in a declaration.
6457 2007-11-15 Marek Safar <marek.safar@gmail.com>
6459 * attribute.cs: Use CS0612 for empty strings.
6461 2007-11-14 Marek Safar <marek.safar@gmail.com>
6463 * lambda.cs, statement.cs: Contextual return may act as a statement.
6465 2007-11-14 Marek Safar <marek.safar@gmail.com>
6467 A fix for a regression cause by #324222
6468 * class.cs: Don't report unused even when it implements an interface.
6470 2007-11-13 Marek Safar <marek.safar@gmail.com>
6472 A fix for bug #341205
6473 * ecore.cs, expression.cs: Method group expression cannot do static
6474 method access with an instance reference check before overloading takes
6477 2007-11-13 Marek Safar <marek.safar@gmail.com>
6479 A fix for bug #325359
6480 * class.cs: Use predictable name for automatically generated property.
6482 2007-11-12 Marek Safar <marek.safar@gmail.com>
6484 A fix for bug #324996
6485 * expression.cs (Is): Handle case where D is nullable and T is not
6488 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6490 2007-11-12 Marek Safar <marek.safar@gmail.com>
6492 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6493 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6494 Flush small error reporting changes.
6496 2007-11-09 Marek Safar <marek.safar@gmail.com>
6498 A fix for bug #324996
6499 * expression.cs: Rewrote Is expression implementation to work with
6500 generics, nullable types, anonymous method. A const result expression
6501 uses existing infrastructure instead of custom not fully-featured one.
6503 2007-11-08 Marek Safar <marek.safar@gmail.com>
6505 A fix for bug #340202
6506 * class.cs: Consider generics for volatile field.
6508 2007-11-08 Marek Safar <marek.safar@gmail.com>
6510 A fix for bug #335594
6511 * expression.cs: Use conversion rules when handling string addition.
6513 2007-11-07 Marek Safar <marek.safar@gmail.com>
6515 A fix for bug #336651
6516 * expression.cs: Fixed a crash when probing is on.
6518 2007-11-07 Marek Safar <marek.safar@gmail.com>
6520 A fix for bug #324242
6521 * covert.cs: Added a conversion from any nullable-type with an
6522 underlying enum-type to the type System.Enum.
6524 2007-11-07 Marek Safar <marek.safar@gmail.com>
6526 A fix for bug #324222
6527 * class.cs: Report all non-used event fields.
6529 2007-11-07 Marek Safar <marek.safar@gmail.com>
6531 A fix for bug #325161
6532 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6533 qualifier for generic types.
6535 2007-11-07 Marek Safar <marek.safar@gmail.com>
6537 A fix for bug #322971
6538 * expression.cs, ecore.cs: Added intermediate result value check for
6541 2007-11-07 Marek Safar <marek.safar@gmail.com>
6543 A fix for bug #324754
6544 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6545 when it was requested.
6547 2007-11-07 Marek Safar <marek.safar@gmail.com>
6549 A fix for bug #325101
6550 * expression.cs: Do type not value comparison for `is' expression.
6552 2007-11-07 Marek Safar <marek.safar@gmail.com>
6554 A fix for bug #320236
6555 * convert.cs: Don't apply user conversion on underlying target type.
6557 2007-11-06 Marek Safar <marek.safar@gmail.com>
6559 * expression.cs: Don't use unresolved expression for error reporting.
6561 2007-11-06 Marek Safar <marek.safar@gmail.com>
6563 A fix for bugs #337712, #324490
6564 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6565 overloading resolution too.
6567 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6568 the process consistent and more robust.
6570 * expression.cs, linq.cs, report.cs: Update.
6572 2007-11-02 Marek Safar <marek.safar@gmail.com>
6574 A fix for bug #332909
6575 * attribute.cs: Resolve attributes in correct context using error
6578 * rootcontext.cs: Define Obsolete attribute members as core members.
6580 2007-11-02 Marek Safar <marek.safar@gmail.com>
6582 * statement.cs: Removed unused methods.
6584 2007-10-31 Wade Berrier <wberrier@novell.com>
6586 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6587 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6590 2007-10-31 Marek Safar <marek.safar@gmail.com>
6592 A fix for bug #338102
6593 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6594 methods registered as non-generics.
6596 2007-10-31 Marek Safar <marek.safar@gmail.com>
6598 A fix for bugs #337712, #324490
6599 * delegate.cs: Delegate covariance and contravariance is not allowed for
6602 2007-10-31 Marek Safar <marek.safar@gmail.com>
6604 A fix for bug #337719
6605 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6608 2007-10-30 Marek Safar <marek.safar@gmail.com>
6610 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6612 2007-10-29 Marek Safar <marek.safar@gmail.com>
6614 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6617 2007-10-29 Raja R Harinath <rharinath@novell.com>
6619 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6621 2007-10-29 Marek Safar <marek.safar@gmail.com>
6623 A fix for bug #334652
6624 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6625 extension methods when we have not found the best candidate in normal
6628 2007-10-27 Marek Safar <marek.safar@gmail.com>
6630 * AssemblyInfo.cs: Keep up-to-date.
6632 2007-10-27 Marek Safar <marek.safar@gmail.com>
6634 * Makefile: Fixed generics compiler name.
6636 2007-10-27 Marek Safar <marek.safar@gmail.com>
6638 * lambda.test: removed, lambda parsing is done differently.
6640 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6642 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6644 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6646 2007-10-27 Marek Safar <marek.safar@gmail.com>
6648 * Makefile, *.sources : All C# compilers are in mcs folder.
6650 * *.cs: Use existing 2_1 define for smcs.
6652 2007-10-26 Marek Safar <marek.safar@gmail.com>
6654 A fix for bug #335847
6655 * assign.cs, expression.cs: Couple of changes to avoid creating a
6656 temporary variable for each object initializer assignment statement. It
6657 simplifies struct initialization too, otherwise two temporary variables
6659 Implemented optimization of redundant default element initializers.
6661 2007-10-25 Marek Safar <marek.safar@gmail.com>
6663 A fix for bug #336766
6664 * expression.cs (Class.CheckBase): Use generic name when method is
6667 2007-10-25 Marek Safar <marek.safar@gmail.com>
6669 A fix for bug #334737
6670 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6671 variable and not variable argument for prepared copies.
6673 2007-10-24 Marek Safar <marek.safar@gmail.com>
6675 A fix for bug #325110
6676 * class.cs, expression.cs, attribute.cs: Use open generic method when
6677 checking conditional attribute.
6679 2007-10-24 Marek Safar <marek.safar@gmail.com>
6681 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6682 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6683 FeatureIsNotAvailable.
6685 2007-10-24 Marek Safar <marek.safar@gmail.com>
6687 ** C# 3.0 Partial methods
6689 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6690 methods support. Because of member cache issue with generics only
6691 non-generics partial methods are fully supported.
6693 2007-10-23 Marek Safar <marek.safar@gmail.com>
6695 * class.cs, decl.cs: Rewrote member overloads check to cope with
6696 generics and to use member cache for member checking. It also improves
6697 performance and fixes remaining overloads issues.
6699 2007-10-20 Marek Safar <marek.safar@gmail.com>
6701 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6702 roottypes.cs, typemanager.cs:
6704 A member cache creation logic changed to add members immediately and
6705 not rely on fallback. The member cache is now only prefered way
6706 how to access and find type declaration members. It saves 5 MB of memory
6707 during MWF compilation and makes code ready for more optimizations and
6708 clean-ups, it's also a pre-requirement for partial methods.
6710 2007-10-18 Raja R Harinath <harinath@gmail.com>
6712 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6713 handling for generic parameters.
6715 2007-10-15 Marek Safar <marek.safar@gmail.com>
6717 * class.cs (FixedField): Removed redundant volatile check.
6719 2007-10-15 Marek Safar <marek.safar@gmail.com>
6721 * class.cs, decl.cs: Fixed overload members verification to do only one
6722 check per possible collision.
6724 2007-10-13 Marek Safar <marek.safar@gmail.com>
6726 A fix for bug #325478
6727 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6728 and create only one disposable flags container.
6730 2007-10-12 Marek Safar <marek.safar@gmail.com>
6732 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6733 * statement.cs (Fixed): Fixed variables cloning.
6735 2007-10-12 Marek Safar <marek.safar@gmail.com>
6737 A fix for bug #333342
6738 * class.cs (EventField): Don't mark value type event as synchronized.
6740 2007-10-12 Marek Safar <marek.safar@gmail.com>
6742 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6743 inference to identify best candidate method correctly.
6744 (ProperyExpr): A range variable is read only and cannot be modified.
6746 2007-10-11 Marek Safar <marek.safar@gmail.com>
6748 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6749 logic to identify best candidate method correctly.
6751 2007-10-11 Marek Safar <marek.safar@gmail.com>
6753 * location.cs (Equals, GetHashCode): Removed.
6755 2007-10-11 Marek Safar <marek.safar@gmail.com>
6757 * report.cs: Implemented message recorder. It is used mainly for lambda
6758 expressions to capture otherwise swallowed error messages.
6760 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6762 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6764 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6766 * expression.cs (MemberAccess): Always report lookup failure.
6768 * location.cs: Implemented Equals, GetHashCode.
6770 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6772 2007-10-10 Jb Evain <jbevain@novell.com>
6774 * codegen.cs: re-enable assembly version check.
6776 2007-10-09 Marek Safar <marek.safar@gmail.com>
6778 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6781 * namespace.cs (UsingAlias): Do correct version check.
6783 2007-10-08 Marek Safar <marek.safar@gmail.com>
6785 * expresison.cs, ecore.cs: Issue extension method error message when
6788 * rootcontext.cs: Added ISO_2 compiler mode option.
6790 2007-10-08 Marek Safar <marek.safar@gmail.com>
6792 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6795 2007-10-08 Marek Safar <marek.safar@gmail.com>
6797 * attribute.cs (GetString, GetBoolean): Work with both literal and
6800 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6801 Moved method overload specific methods to MethodGroupExpr.
6803 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6804 it should be less memory consuming.
6806 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6808 * codegen.cs: remove the assembly version check until the buildbot is
6811 2007-10-07 Jb Evain <jbevain@novell.com>
6813 * attribute.cs (Attribute.GetString): if the value
6814 expression is a StringConstant, return its string value.
6816 2007-10-07 Jb Evain <jbevain@novell.com>
6818 * typemanager.cs: add `assembly_version_attribute_type`.
6819 * codegen.cs: on attribute emission, check that the
6820 AssemblyVersionAttribute doesn't overflow.
6822 2007-10-05 Marek Safar <marek.safar@gmail.com>
6824 A fix for bug #324677
6825 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6826 parent container of a scope container with currently resolved one.
6828 2007-10-05 Marek Safar <marek.safar@gmail.com>
6830 A fix for bug #325534
6831 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6834 2007-10-05 Marek Safar <marek.safar@gmail.com>
6836 A fix for bug #327504
6837 * class.cs (Operator.Define): Refactored implicit and explicit user
6838 operator conversion rules.
6840 2007-10-05 Marek Safar <marek.safar@gmail.com>
6842 A fix for bug #327520
6843 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6845 2007-10-04 Marek Safar <marek.safar@gmail.com>
6847 A fix for bug #328022
6848 * class.cs (MethodData.Define): Use correct method to check whether
6849 a method implementents an accessor.
6851 2007-10-04 Marek Safar <marek.safar@gmail.com>
6853 A fix for bug #330069
6854 * statement.cs (Fixed.Resolve): Read the first array element only when
6855 an array is instantiated.
6857 2007-10-04 Marek Safar <marek.safar@gmail.com>
6859 * expression.cs, assign.cs, generics.cs: Print correct operator when
6860 compound assignment is used.
6862 2007-10-04 Marek Safar <marek.safar@gmail.com>
6864 A fix for bug #325841
6865 * expression.cs (ArrayAccess): Use full argument cloning only for
6866 string compound concatenation.
6868 2007-10-03 Marek Safar <marek.safar@gmail.com>
6870 A fix for bug #328774
6871 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6873 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6876 2007-10-03 Raja R Harinath <rharinath@novell.com>
6879 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6880 Event accessibility checks here. Remove some bogus code that
6881 accidently made GenericMethods work.
6882 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6884 2007-09-25 Marek Safar <marek.safar@gmail.com>
6886 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6888 * statement.cs (Block): Refactored AddVariable to allow error handling
6891 * generic.cs: New stub.
6893 2007-09-23 Marek Safar <marek.safar@gmail.com>
6895 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6898 2007-09-17 Marek Safar <marek.safar@gmail.com>
6900 * class.cs: Use partial container to record whether any partial part
6901 contains static field initializer and therefore default contructor has
6904 2007-09-14 Marek Safar <marek.safar@gmail.com>
6906 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6907 mono-list when only one of two partial parts has defined accessibility
6910 2007-09-14 Marek Safar <marek.safar@gmail.com>
6912 A fix for bug #82845
6914 * class.cs (TypeContainer): Set correct resolve context for all field
6917 2007-09-13 Marek Safar <marek.safar@gmail.com>
6919 * assign.cs: Fixed a crash when field is resolved twice with an error.
6921 * codegen.cs: Changed InFieldInitializer to be flag.
6923 * anonymous.cs, ecore.cs, expression.cs: Update after
6924 IsInFieldInitializer rename.
6926 * const.cs: Removed unused parameter.
6928 * class.cs: Changed the way how we resolve and emit field initializers.
6929 The field initilizers have to have access to contructor block to emit
6930 compiler generated code.
6932 2007-09-13 Marek Safar <marek.safar@gmail.com>
6934 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6935 generics use TypeContainer instead.
6937 2007-09-12 Marek Safar <marek.safar@gmail.com>
6939 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6941 * lambda.cs (ResolveParameters): Use more powerful
6942 InflateGenericArgument.
6944 * parameters.cs: Better exception message.
6946 2007-09-10 Marek Safar <marek.safar@gmail.com>
6948 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6949 correct expression block type.
6951 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6953 * expression.cs (Invocation): Extracted method group resolve to
6956 2007-09-07 Marek Safar <marek.safar@gmail.com>
6958 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6959 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6961 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6962 generic extension methods.
6964 2007-09-06 Marek Safar <marek.safar@gmail.com>
6966 A fix for bug #82676 (Do I get it right now?)
6967 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6968 object before a standard conversion is applied.
6970 2007-09-06 Marek Safar <marek.safar@gmail.com>
6972 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6975 2007-09-05 Marek Safar <marek.safar@gmail.com>
6977 A fix for bug #82676
6978 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6979 non-generic interface types.
6981 2007-09-05 Marek Safar <marek.safar@gmail.com>
6983 A fix for bug #82690
6984 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6986 2007-09-05 Marek Safar <marek.safar@gmail.com>
6988 A fix for bug #82571
6989 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6990 modifier for container based methods.
6992 2007-09-05 Marek Safar <marek.safar@gmail.com>
6994 A fix for bug #82676
6995 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6996 any interface-type T means to any of interface type T.
6998 2007-09-04 Marek Safar <marek.safar@gmail.com>
7000 * namespace.cs: We have 2 versions of System.Core assembly.
7002 2007-09-04 Marek Safar <marek.safar@gmail.com>
7004 A fix for bug #82652
7005 * class.cs (Class.GetClassBases): Compare types and not expressions.
7007 2007-09-04 Marek Safar <marek.safar@gmail.com>
7009 A fix for bug #82620
7010 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
7011 actually never worked before.
7012 (IndexerAccess): Emit prepared arguments before they are modified.
7014 2007-09-04 Marek Safar <marek.safar@gmail.com>
7016 A fix for bug #82563
7017 * assign.cs: Revert wrong fix.
7019 * expression.cs (VariableReference.EmitAssign): Handle ref reference
7021 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
7022 Instead of ldelema/stdind we have to use temporary variables to handle
7023 cases like String.Concat (params string[]).
7025 2007-08-31 Marek Safar <marek.safar@gmail.com>
7027 * class.cs: EmitAttributes to Emit rename.
7029 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
7031 (MemberCore.HasClsCompliantAttribute): Don't depend on
7032 GetClsCompliantAttributeValue execution.
7034 2007-08-31 Marek Safar <marek.safar@gmail.com>
7036 * anonymous.cs: Use shorter type prefix.
7038 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
7041 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
7042 variables when probing is on.
7044 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
7045 unresolved variables.
7046 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
7047 handle transparent identifiers.
7049 2007-08-26 Marek Safar <marek.safar@gmail.com>
7051 * attribute.cs (IsClsCompliant): Add nullable types test.
7053 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
7055 * doc.cs : catch other types of exception than XmlException to
7056 report CS1570. Fixed bug #82565.
7058 2007-08-23 Marek Safar <marek.safar@gmail.com>
7060 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
7061 The number of delegate parameters has to match.
7062 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
7065 2007-08-21 Marek Safar <marek.safar@gmail.com>
7067 * anonymous.cs (AnonymousMethod): Generate private anonymous method
7068 to fix problem with private arguments.
7070 2007-08-20 Marek Safar <marek.safar@gmail.com>
7072 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
7074 * decl.cs (MemberName): Ignore generic type with no generic arguments.
7076 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
7077 empty. Add cloning suport.
7079 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
7081 2007-08-20 Marek Safar <marek.safar@gmail.com>
7083 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
7084 to create EmptyCast. It handles EmptyConstantCast specialization for
7087 2007-08-18 Marek Safar <marek.safar@gmail.com>
7089 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
7090 (EmitArrayArgument): One routine for array arguments.
7091 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
7093 2007-08-17 Marek Safar <marek.safar@gmail.com>
7095 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
7097 2007-08-17 Marek Safar <marek.safar@gmail.com>
7099 * anonymous.cs: MemberLookupFinal update.
7101 * class.cs (ConstructorInitializer): Is expression based.
7103 * delegate.cs: MethodGroupExpr update.
7105 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
7107 (Error_MemberLookupFailed): Customizable error override.
7108 (MethodGroupExpr): Keep queried type for later usage.
7109 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
7112 * expression.cs: Error_MemberLookupFailed refactoring.
7113 (New.DoResolve): Resolve as much as possible.
7114 (ElementInitializer.Error_MemberLookupFailed): Object initializer
7115 customization for invalid member types.
7117 * statement.cs: MethodGroupExpr update.
7119 2007-08-16 Marek Safar <marek.safar@gmail.com>
7121 * modifier.cs (Check): Check all modifiers and not only accessibility
7124 2007-08-16 Marek Safar <marek.safar@gmail.com>
7126 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
7127 type and not an expression.
7129 2007-08-16 Marek Safar <marek.safar@gmail.com>
7131 * statement.cs (Catch.Clone): Type and variable can be null.
7133 2007-08-16 Marek Safar <marek.safar@gmail.com>
7135 A fix for bug #81979
7136 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
7137 I am really not sure whether this is the best fix.
7139 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
7142 2007-08-14 Marek Safar <marek.safar@gmail.com>
7144 ** C# 3.0 Object and collection initializers (major re-write)
7146 * assign.cs (DoResolve): Initializers are not assign related.
7148 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
7149 used during collection or object initialization.
7151 * expression.cs (Error_InvalidArguments): Add initializers specific
7152 messages. More will come later because it requires some general
7154 (New.DoResolve): Better error handling for unsafe types.
7155 (EmptyExpressionStatement): New class.
7156 (ElementInitializer): An object initializer expression.
7157 (CollectionElementInitializer): A collection initializer expression.
7158 (CollectionOrObjectInitializers): A block of object or collection
7160 (NewInitialize): New expression with element/object initializers.
7162 * statement.cs: Reverted object/collection initializer hacks.
7164 * typemanager.cs (CSharpName): Filter __arglist type.
7166 2007-08-09 Marek Safar <marek.safar@gmail.com>
7168 ** C# 3.0 Anonymous Types (update to the latest standard)
7170 * expression.cs (Binary.ResolveOperator): Threat all null based types
7172 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
7173 (AnonymousTypeParameter): Updated.
7175 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
7176 (AnonymousTypeClass): New anonymous type container.
7178 * class.cs (AddField): Return operation result.
7180 * generic.cs: Another empty TypeArguments overload.
7182 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
7183 are stored at top of normal hierarchy.
7185 * typemanager.cs (CSharpName): Filter anonymous types.
7187 2007-08-09 Marek Safar <marek.safar@gmail.com>
7189 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
7190 as single Concat call. How could we miss that :-(
7192 2007-08-08 Marek Safar <marek.safar@gmail.com>
7194 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
7196 2007-08-07 Miguel de Icaza <miguel@novell.com>
7198 * expression.cs: Fix the previous commit, the creation of the
7199 arguments array list needs also to be conditional on the arguments
7202 * class.cs: Add a little bit of help to help narrow down problems.
7204 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
7205 not try to copy in that case.
7207 * driver.cs: When building SMCS, include a new different set of
7208 default assemblies here. Do this here so we can control whether
7209 to include the default assemblies with /noconfig.
7211 2007-08-03 Marek Safar <marek.safar@gmail.com>
7213 A fix for bug #81979
7214 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7217 2007-08-03 Marek Safar <marek.safar@gmail.com>
7219 A fix for bug #82300
7221 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7222 we are in probing scope.
7224 2007-08-03 Marek Safar <marek.safar@gmail.com>
7226 A fix for bug #82301
7228 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7229 (Statement.CloneTo): Clone and not map children blocks.
7231 2007-08-03 Marek Safar <marek.safar@gmail.com>
7233 A fix for bug #82299
7235 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7238 * statement.cs (Statement.CloneTo): Clone variables before statements
7239 to allow remaping of local variables.
7241 2007-08-03 Marek Safar <marek.safar@gmail.com>
7243 A fix for bug #82296
7246 * report.cs: Log crash details for future clone problems.
7248 * statement.cs (Return.Clone): Don't clone non-existent expression.
7250 2007-08-03 Raja R Harinath <harinath@gmail.com>
7252 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7253 (Class.AddBasesForPart): Move CS0537 check here from ...
7254 * cs-parser.jay (class_declaration): ... here. Move calling of
7255 'AddBasesForPart' to ...
7256 (class_bases): ... here.
7257 (struct_declaration, interface_declaration): Update to changes.
7259 2007-08-02 Marek Safar <marek.safar@gmail.com>
7261 A fix for bug #81923
7263 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7264 conversion is allowed.
7266 2007-08-02 Marek Safar <marek.safar@gmail.com>
7268 A fix for bug #81564
7270 * ecore.cs (EventExpr): Add IsBase handling.
7272 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7275 2007-08-02 Raja R Harinath <harinath@gmail.com>
7277 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7278 * cs-parser.jay: Some whitespace cleanups.
7279 (current_delegate): New.
7281 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7282 a dummy code block, and use 'type_name' instead of 'member_name'.
7283 (interface_declaration, class_declaration): Likewise.
7284 (delegate_declaration): Likewise. Rearrange slightly and use
7286 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7287 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7289 2007-08-02 Marek Safar <marek.safar@gmail.com>
7291 A fix for bug #82039
7293 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7296 * typemanager.cs (CSharpName): Split to string overload.
7298 2007-08-02 Marek Safar <marek.safar@gmail.com>
7301 * report.cs: Updated warning CS0472.
7303 2007-08-01 Marek Safar <marek.safar@gmail.com>
7305 A fix for bug #82181
7307 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7309 2007-08-01 Marek Safar <marek.safar@gmail.com>
7311 A fix for bug #82277
7312 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7314 2007-08-01 Marek Safar <marek.safar@gmail.com>
7316 ** C# 3.0 Type Inference (major bits are working)
7318 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7319 (.ImplicitStandardConversionExists): Uses compatible.
7320 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7321 (.InferReturnType): New method.
7322 (.Compatible): Refactored.
7323 (.ResolveParameters): Uses factory to create resolved parameters.
7324 (.CompatibleMethod): Add probing mode support.
7325 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7326 clearly distinguish between 2 different operations.
7327 (LambdaMethod): Moved to lambda.cs.
7328 (AnonymousMethod): Removed unused fields and methods.
7329 (AnonymousDelegate): Simplified.
7331 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7333 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7335 * delegate.cs (Delegate): New mehods to reduce code duplication.
7336 (.GetConstructor): New method.
7337 (.GetInvokeMethod): New method.
7338 (DelegateCreation): Updated.
7340 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7342 (OverloadResolve): Made probing little bit faster.
7344 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7347 * generic.cs (TypeInferenceContext): Dummy implementation.
7349 * iterators.cs: Updated after Resolve/Define rename.
7351 * lambda.cs (LambdaExpression)
7352 (.ResolveParameters): Handles both type of arguments and type inference too.
7354 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7355 (InflateTypes): Updated.
7357 * support.cs (InflateTypes): Changed signature and updated.
7359 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7360 (MemberLookup_FindMembers): More MS tricks.
7361 (GetParameterData): Ditto.
7362 (GetDelegateParameters): Uses quick path for dynamic types.
7364 2007-08-01 Marek Safar <marek.safar@gmail.com>
7366 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7369 2007-07-31 Marek Safar <marek.safar@gmail.com>
7371 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7374 2007-07-26 Jb Evain <jbevain@novell.com>
7376 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7377 which takes a boolean 'report_errors', similar to the GetMethod.
7378 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7379 in .net 2.1, do not report errors here.
7381 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7382 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7383 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7386 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7387 of the type InternalsVisibleToAttribute before the first call
7388 to CoreLookupType which is allowed to fail (third boolean parameter
7389 to true). Because, during the resolution for a type that is not
7390 immediately found, we try to check if the type is not defined in
7391 a friend assembly, and to do so, we need the
7392 InternalVisibleToAttribute.
7394 2007-07-23 Miguel de Icaza <miguel@novell.com>
7396 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7397 feature that allows structs to be compared against null and inline
7398 the result as true or false.
7400 Notice that the same code is not permitted inside a generic block
7401 of code that would do:
7403 class Foo<T> where T : struct {
7410 It is only allowed if the type of T is not bound (no where
7411 clause). In my opinion, this CSC 2 behavior is broken but people
7412 seem to be using it (IronRuby does, a few bug reports on bugzilla
7413 have it and some people have complained about it).
7415 All of the users that depend on this behavior have code that is
7418 * report.cs (Warning, Error): make these take object arguments,
7419 not strings, as that allows us to take advantage of Format.
7421 2007-07-20 William Holmes <billholmes54@gmail.com>
7423 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7424 Left member variable for the Count.
7425 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7426 MemberName.CountTypeArguments to avoid a NRE.
7428 This code is contributed under the MIT X11 license
7430 2007-07-18 Marek Safar <marek.safar@gmail.com>
7432 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7434 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7436 * doc.cs : generic method arguments are written as ``x while generic
7437 type arguments are `x. Combined with the previous change, fixed bug
7440 2007-07-18 Raja R Harinath <rharinath@novell.com>
7443 * expression.cs (Binary.ResolveOperator): When converting
7444 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7446 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7448 * doc.cs : when T: or whatever x: is specified, it does not really
7449 check the doc comment's syntax correctness. Fixed bug #82006.
7451 2007-07-18 Marek Safar <marek.safar@gmail.com>
7453 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7454 LambdaExpression better.
7456 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7458 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7460 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7461 as it can be generated.
7463 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7466 * lambda.cs (LambdaExpression): Refactored to share same code with
7467 AnonymousMethodExpression.
7469 2007-07-17 Marek Safar <marek.safar@gmail.com>
7471 * anonymous.cs (MakeName): Include host name for easier debugging.
7472 (LambdaMethod): New class for lambda spcecific stuff.
7474 * attribute.cs: Set EmitContext return type.
7476 * class.cs: Set EmitContext return type.
7478 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7479 with null/void meaning.
7481 * iterators.cs (ContainerType): Implemented.
7483 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7485 * statement.cs (Return): Updated to lambda expressions.
7486 (Block.CloneTo): Parent can be null.
7488 2007-07-13 Marek Safar <marek.safar@gmail.com>
7490 A fix for bug #81917
7491 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7493 * class.cs (FixedField): Check whether field is in unsafe scope.
7495 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7496 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7498 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7501 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7503 2007-07-13 Marek Safar <marek.safar@gmail.com>
7505 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7506 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7509 2007-07-13 Marek Safar <marek.safar@gmail.com>
7511 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7513 2007-07-13 Marek Safar <marek.safar@gmail.com>
7515 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7516 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7518 * codegen.cs(EmitContext): Add ProbingMode flag.
7520 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7522 * driver.cs: For now set both warning values.
7524 * ecore.cs (SimpleName): Name is readonly.
7525 (MethodGroup.OverloadResolve): One quick path for probing.
7527 * expression.cs (Unary): Set Oper r/o.
7528 (Binary): Set Oper r/o.
7529 (ParameterReference): Set few instance variables as r/o.
7530 (ParameterReference.DoResolveBase): Don't capture aruments when
7532 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7533 (Arglist): arguments are private.
7534 (SizeOf): type is private and r/o.
7535 (MemberAccess): arguments are private.
7537 * report.cs: Enhanced reporting on/off capabilities.
7539 * lambda.cs: Uses ec.IsInProbingMode.
7540 (ContextualReturn): Derives from return.
7542 * rootcontext.cs: For now set both warning values.
7544 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7546 (Return.Resolve): Don't die immediately.
7547 (Block.Resolve): Speed-up probing.
7548 (Block.CloneTo): Clone only child blocks.
7550 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7552 * iterators.cs: reverted Miguel's latest change (r81925) as it
7553 breaks the build in System.
7555 2007-07-13 Miguel de Icaza <miguel@novell.com>
7557 * iterators.cs (Yield.CheckContext): Check for the iterator type
7558 also here as we can call into Yield even in codepaths that are not
7560 (MethodOrOperator is the only path that was checked).
7562 In addition to the standard check, use a more specific check for
7563 constructors to report a more verbose error.
7565 2007-07-12 Miguel de Icaza <miguel@novell.com>
7567 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7568 report the warning and continue
7570 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7571 values on the stack on the call to Emit. Use EmitStatement if
7572 possible, or using Emit + Pop if not possible. Fixes #82064
7574 2007-07-12 Raja R Harinath <rharinath@novell.com>
7576 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7577 avoid try...finally in some cases.
7579 2007-07-10 Marek Safar <marek.safar@gmail.com>
7581 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7583 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7584 instead of method. Re-use standard error handling.
7585 (ConstructorInitializer.Emit): Simplified.
7587 * delegate.cs: Updated after Invocation.EmitCall change.
7589 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7590 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7591 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7592 method and don't permanently changing input arguments.
7593 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7594 is resolved it has one of the candidates is the best one which is later
7595 used to emit. Removed a few unused method.
7596 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7598 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7599 (Binary.ResolveOperator): Ditto.
7600 (ConditionalLogicalOperator.DoResolve): Ditto.
7601 (Invocation): Uses method group.
7602 (Invocation.DoResolve): Simplified.
7603 (Invocation.EmitCall): Removed useless is_static.
7604 (Invocation.Emit): Delegate to method group.
7605 (Invocation.EmitStatement): Simplified.
7606 (New): Uses method group.
7607 (MemberAccess.DoResolve): Don't destroy original expression.
7609 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7611 2007-07-04 Marek Safar <marek.safar@gmail.com>
7613 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7616 * lambda.cs: Add custom error message type.
7618 2007-07-03 Marek Safar <marek.safar@gmail.com>
7620 * lambda.cs: Simplified little bit.
7622 * parameter.cs: Introduced ImplicitLambdaParameter.
7623 (Parameters.CreateFullyResolved): New factory instead of ctor.
7627 * delegate.cs: Updated parameter creation.
7629 2007-07-03 Marek Safar <marek.safar@gmail.com>
7631 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7634 * generic.cs: Synchronized with gmcs.
7636 2007-07-03 Marek Safar <marek.safar@gmail.com>
7638 * class.cs (Indexer): Check return type as soon as possible.
7640 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7643 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7645 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7647 * parameter.cs (Parameter): Use expression type when it is available.
7649 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7650 method modifier for the first parameter only.
7652 2007-06-24 Marek Safar <marek.safar@gmail.com>
7654 A fix for bug #81938
7655 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7657 * constant.cs: Tide up an exception message.
7659 2007-06-22 Marek Safar <marek.safar@gmail.com>
7661 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7662 an uninitialized variable is used.
7664 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7666 2007-06-22 Marek Safar <marek.safar@gmail.com>
7668 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7669 not found error handling.
7671 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7673 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7674 (ArrayCreation.DoResolve): Simplified.
7675 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7676 its own resolve process.
7677 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7679 2007-06-20 Marek Safar <marek.safar@gmail.com>
7681 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7684 2007-06-20 Marek Safar <marek.safar@gmail.com>
7686 * cs-tokenizer.cs: Removed var related stuff.
7688 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7689 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7690 a type and a keyword at same time.
7692 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7695 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7696 implicitly typed arrays, more changes will follow.
7698 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7700 2007-06-19 Marek Safar <marek.safar@gmail.com>
7702 * ecore.cs (VarExpr): Removed Handled field.
7704 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7705 build-in assign functionality.
7706 (ForEach.Resolve): Removed all implicitly typed local variable code and
7708 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7709 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7711 2007-06-18 Marek Safar <marek.safar@gmail.com>
7713 * assign.cs: Removed implicitly typed local variable check.
7715 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7716 referencing implicitly typed local variable.
7717 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7720 * statement.cs (Fixed): Removed unsupported implicitly typed local
7723 2007-06-15 Marek Safar <marek.safar@gmail.com>
7725 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7727 2007-06-14 Marek Safar <marek.safar@gmail.com>
7729 A fix for bugs #81855 and #76274
7730 * attribute.cs (AttachTo): Always set owner for global attributes to
7733 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7736 * cs-parser.jay: Assembly and module attributes must precede all other
7737 elements except using clauses and extern alias declarations.
7739 2007-06-13 Marek Safar <marek.safar@gmail.com>
7741 A fix for bug #81748
7743 * expression.cs: More checks for non ISO-1 features.
7745 2007-06-12 Marek Safar <marek.safar@gmail.com>
7747 A fix for bug #81807
7748 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7749 present inside switch statement and it is required by nullable check.
7751 2007-06-12 Marek Safar <marek.safar@gmail.com>
7753 A fix for bug #81840
7754 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7755 when type matching fails.
7757 * namespace.cs: Tiny error message change.
7759 2007-06-12 Marek Safar <marek.safar@gmail.com>
7761 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7762 reporting. Added automatic property check.
7764 * class.cs: Updated after CheckAbstractAndExtern relocation.
7765 (AEventPropertyAccessor.GetSignatureForError): Customized.
7767 2007-06-11 Marek Safar <marek.safar@gmail.com>
7769 * class.cs (DefineBaseTypes): Base type can be undefined.
7771 * ecore.cs (TypeLookup): Minor refactoring.
7772 (DoResolveAsTypeStep): Removed redundant check.
7774 * namespace.cs (Lookup): Removed redundant check.
7776 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7777 ResolveAsTypeTerminal step.
7778 (BootstrapCorlib_*): Simplified.
7779 (PopulateCoreType): Core types can be now external.
7781 2007-06-07 Marek Safar <marek.safar@gmail.com>
7783 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7785 (InferTypeArguments): Infers anonymous expression type arguments.
7786 (Compatible): Split to Compatible and InferTypeArguments.
7788 * lambda.cs: Updated.
7790 2007-06-08 Marek Safar <marek.safar@gmail.com>
7792 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7794 2007-06-07 Raja R Harinath <harinath@gmail.com>
7796 Fix #80477, cs0135-2.cs, cs0135-3.cs
7797 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7798 names to the "known" variables list.
7799 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7800 parameter names are also "known".
7801 (Block.CheckError136): Remove.
7802 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7805 2007-06-07 Marek Safar <marek.safar@gmail.com>
7807 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7809 2007-06-06 Marek Safar <marek.safar@gmail.com>
7811 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7812 internal error not an user error.
7814 * expression.cs (IsApplicable): Refactored to make debugging easier.
7816 * support.cs: More tricks for non-mono runtimes.
7818 * typemanager.cs (CoreLookupType): Made public.
7819 (InitSystemCore): All linq specific stuff moved to linq.cs
7821 2007-06-05 Marek Safar <marek.safar@gmail.com>
7823 * typemanager.cs (CSharpSignature): One more missing build-in types
7825 More tricks for non-mono runtime.
7827 2007-06-05 Raja R Harinath <harinath@gmail.com>
7829 * statement.cs (Block.CheckError136_InParents): Remove.
7830 (Block.AddVariable): Use GetParameterInfo instead.
7831 (ToplevelBlock.ProcessArguments): Likewise.
7833 2007-06-04 Raja R Harinath <rharinath@novell.com>
7835 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7837 (ToplevelBlock.GetParameterInfo): Split out of ...
7838 (ToplevelBlock.GetParameterRefernce): ... this.
7839 (ToplevelBlock.ParameterMap): Remove.
7840 * expression.cs (ParameterReference): Update to use
7841 ToplevelParameterInfo.
7843 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7846 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7847 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7849 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7850 (ToplevelBlock.ProcessParameters) ... here.
7851 (ToplevelBlock..ctor): Invoke it.
7853 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7856 * statement.cs (IKnownVariable): New interface.
7857 (LocalInfo): Implement it.
7858 (ToplevelParameterInfo): New class.
7859 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7860 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7861 GetKnownVariableInfo.
7863 2007-06-03 Raja R Harinath <harinath@gmail.com>
7865 Partly speed up CS0136 error checks.
7866 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7867 'recurse' parameter.
7868 (Block.DoCheckError136): Only check errors in parameters. Move
7869 local variable checks ...
7870 (Block.AddVariable): ... here, and ...
7871 (ToplevelBlock.ResolveMeta): ... here.
7873 2007-06-02 Raja R Harinath <harinath@gmail.com>
7875 * statement.cs (Block.IsChildOf): Remove.
7877 * statement.cs (Statement.Clone): Move special case code ...
7878 (Block.CloneTo): ... here.
7880 2007-05-29 Raja R Harinath <rharinath@novell.com>
7882 * statement.cs (ToplevelBlock.container): Remove field. It's
7883 redundant with 'Parent'.
7884 (ToplevelBlock.ContainerBlock): Remove accessor.
7885 (ToplevelBlock..ctor): Update to changes. Register anonymous
7886 child with parent here, ...
7887 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7889 (start_anonymous): Don't save current_block.
7890 (top_current_block): Remove.
7892 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7893 (Block.Resolve): Update to changes.
7894 (Block..ctor): Move setting of "correct" 'Toplevel'
7895 and 'Explicit' fields to ...
7896 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7898 2007-05-27 Raja R Harinath <harinath@gmail.com>
7901 * statement.cs (Block.Implicit): Remove.
7902 (Block): Update to changes.
7903 * flowanalysis.cs: Likewise.
7905 Mildly speed up CheckInvariantMeaningInBlock
7906 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7907 Recursively call AddKnownVariable to all enclosing blocks.
7908 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7909 Remove recursive calls.
7910 (Block): Update to changes.
7912 New ExplicitBlock invariants
7913 * statement.cs (Block.Explicit): New field. It points to the
7914 immediately enclosing non-implicit block.
7915 (Block..ctor): Maintain the invariant.
7916 * cs-parser.jay: Take advantage of invariant.
7918 Introduce ExplicitBlock
7919 * statement.cs (ExplicitBlock): New.
7920 (ToplevelBlock): Derive from it.
7921 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7923 (Block.Implicit): Update to changes.
7924 * cs-parser.jay: Update to changes.
7927 * codegen.cs (EmitContext.IsLastStatement): Remove.
7928 * statement.cs (Block.DoEmit): Update to changes.
7930 2007-05-25 Raja R Harinath <rharinath@novell.com>
7932 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7933 modifying current_block directly.
7935 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7937 * class.cs: Implemented automatic properties (C# 3.0)
7938 Thanks to Marek for the help.
7940 2007-05-23 Raja R Harinath <rharinath@novell.com>
7942 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7943 variable as assigned, note also that all its components are
7945 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7947 2007-05-19 Marek Safar <marek.safar@gmail.com>
7949 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7950 member is marked as compiler generated.
7952 * decl.cs (MemberCore): Refactored ModFlags into property.
7954 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7955 (Check): Check only accessibility modifiers.
7957 2007-05-18 Raja R Harinath <rharinath@novell.com>
7959 Track all assignable slots in one bit array
7960 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7961 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7962 logic from VariableMap constructor here. Use the same 'offset'
7963 variable that's later used for computing offsets of local
7965 * flowanalysis.cs (UsageVector.parameters): Remove.
7966 (UsageVector): Update to changes.
7967 (VariableMap): Remove.
7969 Avoid creating ParameterMap in every block
7970 * statement.cs (Block.ParameterMap): Move ...
7971 (ToplevelBlock.ParameterMap): ... here.
7972 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7974 * flowanalysis.cs (FlowBranching.param_map): Remove.
7975 (FlowBranching.UsageVector): Update to changes.
7976 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7978 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7980 * expression.cs (ParameterReference): Distinguish between block
7981 where parameter was referenced and declared.
7983 2007-05-18 Marek Safar <marek.safar@gmail.com>
7985 * flowanalysis.cs, statement.cs: Put back improved error handling.
7987 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7991 Imporved object and collection initialization (C# 3.0).
7993 2007-05-15 Marek Safar <marek.safar@gmail.com>
7995 A fix for bug #81380
7996 * expression.cs (Is.DoResolve): Only value types have constant `is'
7999 2007-05-15 Raja R Harinath <rharinath@novell.com>
8001 * statement.cs (ToplevelBlock.child): Remove.
8003 2007-05-15 Raja R Harinath <harinath@gmail.com>
8005 Rationalize ResolveMeta: refactoring
8006 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
8007 out constant handling code into ...
8008 (Block.DoResolveConstants): ... this.
8010 Rationalize ResolveMeta: kill local_map
8011 * statement.cs (Block.local_map, Block.LocalMap): Remove.
8012 (Block.AssignableSlots): New.
8013 (Block.ResolveMeta): Make protected. Don't create a VariableMap
8014 for locals -- move code from VariableMap here. Avoid unnecessary
8016 * flowanalysis.cs (FlowBranching.local_map): Remove.
8017 (FlowBranching..ctor): Use Block.AssignableSlots.
8018 (VariableMap): Remove unused constructors.
8020 2007-05-11 Raja R Harinath <rharinath@novell.com>
8022 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
8024 2007-05-11 Marek Safar <marek.safar@gmail.com>
8026 * typemanager.cs (IsFriendAssembly): Should not be called for building
8029 2007-05-09 Marek Safar <marek.safar@gmail.com>
8031 * literal.cs (NullConstant): Print null in all cases.
8033 * expression.cs (Binary.ResolveOperator): Implemented delegate
8034 comparison based on C# 2.0 changes.
8036 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
8038 This code is contributed under the MIT X11 license
8040 The following enables support for several C# 3.0 language features:
8042 * cs-tokenizer.cs: Added support for the "var" keyword.
8044 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
8045 Added VarExpr class to facilitate type inferencing.
8047 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
8048 to support anonymous types.
8050 * assign.cs: Added support for type inferencing and initialization.
8052 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
8054 * expression.cs: Added implicit array support to ArrayCreation.
8055 Added 5 types and 1 interface:
8057 IInitializable Implementing classes can inject initializing
8058 statements after object instantiation.
8060 Initializer Stores data for object initialization.
8062 AnonymousType An expression for anonymous types.
8064 AnonymousTypeParameter Stores data about an anonymous type's field.
8066 NewInitialize An expression for object initialization.
8068 CollectionInitialize An expression for collection initialization.
8070 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
8073 2007-05-06 Marek Safar <marek.safar@gmail.com>
8075 A fix for bug #81500
8076 * cs-tokenizer.cs: Add special handling for coalescing operator.
8078 2007-05-06 Marek Safar <marek.safar@gmail.com>
8080 A fix for bug #81529
8081 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
8082 its value from base class until it is redefined.
8084 2007-05-02 Raja R Harinath <rharinath@novell.com>
8086 Fix regression in cs0631-3.cs
8087 * cs-parser.jay (operator_declarator): Add opt_attributes to error
8088 fallback. Make error fallback catch more cases.
8090 2007-05-01 Miguel de Icaza <miguel@novell.com>
8092 * cs-parser.jay: Allow parameters in operator declarations to have
8095 2007-04-27 Miguel de Icaza <miguel@novell.com>
8097 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
8100 * lambda.cs (ContextualReturn.Resolve): An expression is valid
8101 inside the ContextualReturn, it does not have to be an
8102 ExpressionStatement.
8104 2007-04-24 Miguel de Icaza <miguel@novell.com>
8106 * lambda.cs (ContextualReturn.Resolve): if the return type is not
8109 2007-04-23 Miguel de Icaza <miguel@novell.com>
8111 * anonymous.cs (AnonymousContainer): split the virtual Resolve
8112 method in two methods: ResolveNoDefine and Resolve.
8114 ResolveNoDefine will stop just after ResolveTopBlock has been
8117 Resolve will then continue by creating a method and issuing the
8118 call to method.Define ().
8120 (AnonymousMethod): Split and implement the new Resolve and
8121 ResolveNoDefine as well.
8123 * lambda.cs (LambdaExpression): Split the anonymous method
8124 resolution code into a separate routine (CoreCompatibilityTest)
8125 from DoCompatibleTest.
8127 (LambdaExpression.TryBuild): New method, this method tries to
8128 build the LambdaExpression with the given set of types to be used
8129 as the types for the various parameters of the lambda expression.
8131 If the compilation succeed with the given types, the infered type
8132 of the Anonymous method is returned, otherwise null is returned.
8134 2007-04-23 Marek Safar <marek.safar@gmail.com>
8136 A fix for bug #81414
8137 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
8139 2007-04-22 Miguel de Icaza <miguel@novell.com>
8141 * cs-tokenizer.cs: Change various identifiers here from the
8142 camelCasing to the recommended Linux-like style for instance
8143 variables from the Coding Guidelines.
8145 2007-04-19 Martin Baulig <martin@ximian.com>
8148 (Convert.ImplicitReferenceConversionCore): Allow conversions from
8149 System.Enum to System.ValueType.
8151 2007-04-13 Martin Baulig <martin@ximian.com>
8153 Rewrote implicit reference conversions. We need to distinguish
8154 between implicit reference conversions (13.1.4) and implicit
8155 boxing conversions (13.1.5).
8157 According to the spec, there's an an implicit conversion
8158 "From a one-dimensional array-type S[] to IList<T> and base
8159 interfaces of this interface, provided there is an implicit
8160 reference conversion from S to T." Note that this does not
8161 include boxing conversions.
8164 (Convert.ImplicitTypeParameterBoxingConversion): New method.
8165 (Convert.ImplicitReferenceConversion): Split into
8166 ImplicitReferenceConversionCore() and
8167 ImplicitBoxingConversionExist().
8168 (Convert.ImplicitReferenceConversionExists): Use the new
8169 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
8171 2007-04-12 Martin Baulig <martin@ximian.com>
8173 * convert.cs (Convert.ImplicitReferenceConversion): Move the
8174 `TypeManager.null_type' checks up to the top of the method.
8176 2007-04-11 Marek Safar <marek.safar@gmail.com>
8178 A fix for bug #81350
8179 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
8182 2007-04-11 Martin Baulig <martin@ximian.com>
8184 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
8185 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
8186 to make this work for generic classes; fixes #79561.
8188 2007-04-11 Martin Baulig <martin@ximian.com>
8190 * expression.cs (As): Add support for nullable types; fixes #79371.
8192 2007-04-11 Martin Baulig <martin@ximian.com>
8194 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
8195 `type.FullName' is null; fixes #80243.
8197 2007-04-11 Martin Baulig <martin@ximian.com>
8199 * expression.cs (Invocation.IsApplicable): Don't modify the method
8200 if type inference succeeded, but the method was not applicable.
8203 2007-04-10 Marek Safar <marek.safar@gmail.com>
8205 A fix for bug #81324
8206 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
8207 internal and external namespaces containers.
8209 2007-04-10 Martin Baulig <martin@ximian.com>
8211 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8212 TypeManager.DropGenericMethodArguments() so we also call
8213 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8215 2007-04-10 Martin Baulig <martin@ximian.com>
8217 * iterators.cs (Iterator.CreateIterator): Don't crash if
8218 `method.ReturnType' is null. This happens if something went wrong
8219 while resolving that typ (we already reported an error in this case).
8221 2007-04-10 Martin Baulig <martin@ximian.com>
8223 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8224 generic interfaces; report the CS0144 directly.
8226 2007-04-10 Martin Baulig <martin@ximian.com>
8228 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8229 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8231 2007-04-10 Martin Baulig <martin@ximian.com>
8233 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8235 2007-04-09 Raja R Harinath <rharinath@novell.com>
8238 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8239 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8242 * statement.cs (For.Resolve): If resolution fails, use
8245 2007-04-08 Marek Safar <marek.safar@gmail.com>
8247 * anonymous.cs (MakeName): Make faster and zero-based.
8248 (VerifyExplicitParameterCompatibility): Back to mode where generic
8249 parameter is ignored.
8250 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8252 * class.cs (EmitType): Method can emit another new method.
8254 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8256 * driver.cs: Updated.
8258 * lambda.cs: Reuse predefined empty parameters.
8260 * parameter.cs: Updated
8262 * support.cs: Implemented InflateTypes.
8264 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8265 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8267 2007-04-03 Martin Baulig <martin@ximian.com>
8271 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8272 version of TypeManager.IsOverride() which also works with generic
8275 2007-04-03 Martin Baulig <martin@ximian.com>
8280 (Convert.ExplicitReferenceConversion): We need to cast when
8281 converting from IList<T> to S[].
8283 2007-04-01 Marek Safar <marek.safar@gmail.com>
8285 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8288 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8290 2007-03-31 Marek Safar <marek.safar@gmail.com>
8292 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8293 argument and return type inferring.
8295 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8296 (ReturnType): Turned to property.
8298 * statement.cs (Return): Implemented return type inferring.
8300 * support.cs (ReflectionParameters): Use local types if possible.
8302 2007-03-30 Raja R Harinath <rharinath@novell.com>
8304 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8305 (FlowBranching.UsageVector): Update to changes.
8307 Prepare to kill 'Reachability'
8308 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8309 argument of constructor.
8311 2007-03-29 Raja R Harinath <rharinath@novell.com>
8313 Prepare to kill 'Reachability'
8314 * flowanalysis.cs (UsageVector.is_unreachable): New.
8315 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8316 'reachability', and verify they're consistent.
8319 * expression.cs (New.EmitStatement): Handle type parameters here too.
8321 2007-03-29 Martin Baulig <martin@ximian.com>
8326 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8327 CompilerGeneratedClass.
8328 (ScopeInfo.EmitScopeInstance): Make this protected.
8329 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8330 `ec.CurrentAnonymousMethod.Scope == Scope'.
8332 * statement.cs (Block.ScopeInfo): Make this a property.
8334 2007-03-27 Raja R Harinath <harinath@gmail.com>
8336 Prepare to kill 'Reachability'
8337 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8338 (FlowBranching.UsageVector.Reachability): Remove property.
8339 (FlowBranching.UsageVector.IsUnreachable): New property.
8340 (FlowBranching.UsageVector.ResetBarrier): New.
8341 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8342 * codegen.cs, statement.cs: Update to changes.
8344 2007-03-27 Martin Baulig <martin@ximian.com>
8349 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8352 2007-03-26 Raja R Harinath <rharinath@novell.com>
8354 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8355 instead of TriState. Remove all mention of TriState.
8357 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8358 replaced by a boolean. Add boolean 'is_unreachable' field, check
8359 and maintain invariants.
8361 2007-03-25 Marek Safar <marek.safar@gmail.com>
8363 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8365 2007-03-25 Marek Safar <marek.safar@gmail.com>
8367 * expression.cs: Stop using obsolete 2.0 opcodes.
8369 2007-03-25 Marek Safar <marek.safar@gmail.com>
8371 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8372 one of the latests Martin's fixes.
8374 2007-03-23 Miguel de Icaza <miguel@novell.com>
8376 * expression.cs: On BigEndian systems, swap the bytes, temporary
8377 solution until we get a new bitconverter class.
8379 2007-03-23 Martin Baulig <martin@ximian.com>
8383 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8384 "Method" and "Method`1". Normally, a cache lookup is done on the
8385 "Method" form (ie. without the generic arity), but this one makes
8386 lookups on the full form work as well.
8388 2007-03-22 Raja R Harinath <rharinath@novell.com>
8390 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8393 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8395 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8396 ordered_member_list, to TypeBuilder to store members to be defined
8397 in the order they were parsed in.
8398 - ordered_explicit_member_list contains all properties indexers
8399 and methods that are defined as explicit implementation of an
8400 interface or base class.
8401 - ordered_member_list contains all properties indexers and methods
8402 that are not defined as explicit implementation of an interface
8405 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8406 functionality in these removed classes has been replaced with
8407 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8408 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8410 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8411 to CheckForDuplications inside GetMethod and SetMethod Define Method
8412 to handle method property and indexer name conflicts.
8416 All code is contributed under the MIT/X11 license.
8418 2007-03-20 Martin Baulig <martin@ximian.com>
8420 * class.cs (TypeContainer.Interfaces): Removed; they're now
8421 included in `TypeContainer.Types'.
8423 2007-03-20 Martin Baulig <martin@ximian.com>
8425 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8427 * class.cs (TypeContainer.CreateType): New public method. This is
8428 now called before DefineType() to create the TypeBuilders.
8429 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8430 has already been created by CreateType().
8431 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8432 don't resolve our base classes here; this has been moved into
8433 DefineBaseTypes(). We're now called from CreateType().
8434 (TypeContainer.DefineBaseTypes): New private method; resolve our
8435 base classes here. We're now called from DefineType().
8438 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8439 our types first to create all the TypeBuilders. After that, call
8440 TypeContainer.DefineType() on all the types which'll resolve their
8441 base classes and setup the resolve order.
8443 2007-03-20 Martin Baulig <martin@ximian.com>
8445 * class.cs (TypeContainer.Enums): Removed; they're now included in
8446 `TypeContainer.Types'.
8448 2007-03-20 Martin Baulig <martin@ximian.com>
8451 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8452 (TypeContainer.DoResolveMembers): Call DefineType() on our
8453 `compiler_generated' classes; moved here from DefineNestedTypes().
8456 (RootContext.ResolveTree): Call ResolveMembers() on all
8457 TypeContainer's in the `type_container_resolve_order'.
8459 2007-03-19 Marek Safar <marek.safar@gmail.com>
8461 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8463 2007-03-17 Marek Safar <marek.safar@gmail.com>
8465 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8466 implementation flags.
8468 2007-03-17 Marek Safar <marek.safar@gmail.com>
8470 * class.cs: More optimizations for type parameters.
8472 2007-03-15 Marek Safar <marek.safar@gmail.com>
8474 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8476 * ecore.cs, parameter.cs: More common code for both corlibs.
8478 * typemanager.cs (IsGenericMethod): Simplified.
8480 2007-03-15 Raja R Harinath <rharinath@novell.com>
8482 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8484 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8486 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8487 unconditionally. Simplify explanation.
8488 (Try.Resolve, Using.Resolve): Likewise.
8490 2007-03-15 Martin Baulig <martin@ximian.com>
8494 * decl.cs (DeclSpace): If we're a partial class, use our
8495 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8497 2007-03-15 Raja R Harinath <rharinath@novell.com>
8499 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8501 (FlowBranching.UsageVector): Update to changes.
8502 (FlowBranching.MergeSiblings): Likewise.
8503 * statement.cs: Likewise.
8505 2007-03-15 Martin Baulig <martin@ximian.com>
8510 (MemberCache): Added a special .ctor for type parameters.
8513 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8516 2007-03-09 Martin Baulig <martin@ximian.com>
8518 * enum.cs (Enum): Make this a TypeContainer.
8519 (EnumMember): Derive from `Const'.
8522 (Const.DoResolveValue): New protected virtual method; move most of
8523 the functionality of ResolveValue() here so we can override it in
8525 (Const.CreateConstantReference): Make this virtual.
8527 * class.cs (Kind): Add `Kind.Enum'.
8528 (TypeContainer.Emit): Don't emit the enums here; they're already
8529 in the `RootContext.typecontainer_resolve_order'.
8531 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8532 here; they're already in the `typecontainer_resolve_order'.
8534 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8535 TypeManager.DropGenericTypeArguments().
8538 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8539 (TypeManager.IsEnumType): Likewise.
8540 (TypeManager.EnumToUnderlying): Likewise.
8541 (TypeManager.IsEqual): Add support for enums.
8543 2007-03-12 Raja R Harinath <rharinath@novell.com>
8545 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8546 DefaultParameterValueAttribute to be undefined, say if System.dll
8549 2007-03-11 Marek Safar <marek.safar@gmail.com>
8551 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8554 2007-03-10 Marek Safar <marek.safar@gmail.com>
8556 * class.cs, parameter.cs: Unified parameters verification.
8558 2007-03-08 Martin Baulig <martin@ximian.com>
8560 * cs-parser.jay (constructor_header): Pass the location to the
8561 newly created TopLevelBlock.
8563 2007-03-07 Martin Baulig <martin@ximian.com>
8565 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8567 2007-03-06 Miguel de Icaza <miguel@novell.com>
8569 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8570 with the changes from David, fixes the build.
8572 2007-03-05 David Mitchell <dmitchell@logos.com>
8574 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8575 and its base interfaces to a one-dimensional array type S[],
8576 provided there is an implicit or explicit reference conversion
8579 2007-03-03 Marek Safar <marek.safar@gmail.com>
8581 * cs-tokenizer.cs: Implemented basic linq grammar.
8583 * driver.cs: Set linq lang version on demand.
8585 2007-02-26 Marek Safar <marek.safar@gmail.com>
8587 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8589 2007-02-25 Marek Safar <marek.safar@gmail.com>
8591 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8594 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8596 Check property and event extern attributes.
8598 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8601 2007-02-24 Marek Safar <marek.safar@gmail.com>
8603 A fix for bug #80407
8604 * ecore.cs: Don't report ambiguity error when methods have same parent.
8606 2007-02-23 Marek Safar <marek.safar@gmail.com>
8608 A fix for bug #80878
8609 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8611 2007-02-22 Marek Safar <marek.safar@gmail.com>
8613 * attribute.cs: Enable ExtensionAttribute presence test.
8615 2007-02-22 Marek Safar <marek.safar@gmail.com>
8617 * class.cs: Warn about missing GetHashCode only when Equals is override.
8619 * decl.cs: Check accessibility of type arguments.
8621 * typemanager.cs: Correctly report nullable array.
8623 2007-02-20 Marek Safar <marek.safar@gmail.com>
8625 * class.cs, report.cs: Capture more details when things go wrong.
8627 2007-02-20 Marek Safar <marek.safar@gmail.com>
8629 A fix for bug #80650
8630 * cs-parser.jay: Anonymous container starts at constructor declaration
8631 and not at block beginning because it has to be usable in constructor
8634 * statement.cs: Use context location and not block one for error reporting.
8636 2007-02-18 Marek Safar <marek.safar@gmail.com>
8638 A fix for bug #78712
8639 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8642 2007-02-18 Marek Safar <marek.safar@gmail.com>
8644 A fix for bug #80493 by Atsushi Enomoto
8645 * cs-parser.jay: Ignore invalid attribute target.
8647 2007-02-18 Marek Safar <marek.safar@gmail.com>
8649 * cs-tokenizer.cs: Ignore '\0' as white space character.
8651 2007-02-17 Miguel de Icaza <miguel@novell.com>
8653 * cs-parser.jay: Add support for lambda expressions to the mcs
8656 * lambda.cs: Only clone when we are probing, not on the final call
8657 (Compatible is the final call).
8659 * statement.cs (CloneContext): Introduce class to provide block
8660 remapping during clone.
8662 All statements Clone themselves now.
8664 (Clone): special handling for blocks, when we clone a block, we
8665 register the block inside this routine, as children of the block
8666 might trigger a lookup.
8668 * expression.cs: Add support for CloneContext in all expressions.
8670 2007-02-17 Marek Safar <marek.safar@gmail.com>
8672 A fix for bug #80493
8673 * statement.cs: Report ambiguous warning when interfaces are not related.
8675 2007-02-15 Marek Safar <marek.safar@gmail.com>
8677 C# 3.0 extension methods.
8679 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8680 cannot be used directly.
8682 * class.cs (Class.Emit): Emit extension attribute if any class method
8683 is extension method.
8684 (Method.Define): Add basic extension method validation conditions.
8685 (Method.Emit): Emit extension attribute for method.
8687 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8688 extension method exists. Currently we follow same approach as Microsoft
8689 does, emit even if a method or a class are private but this can change
8692 * cs-parser.jay: Add handling of `this' keyword in method parameters
8695 * decl.cs (DeclSpace.IsStaticClass): New property.
8696 (MemberCache.FindExtensionMethods): Looks for extension methods with
8697 defined name and extension type.
8699 * doc.cs: Updated after OverloadResolve changes.
8701 * driver.cs: Add new soft reference to System.Core.dll.
8703 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8704 (ExtensionMethodGroupExpr): Represents group of extension methods.
8706 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8707 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8708 to MethodGroupExpr and made non-static for easier customization.
8709 (Invocation.DoResolve): Add extension method lookup when no standard
8711 (MemberAccess.DoResolve): Try extension methods if no member exists.
8713 * modifiers.cs: Add METHOD_EXTENSION modifier.
8715 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8716 as well as candidate extension type.
8717 (ComputeNamespaces): When assembly constains extension methods registers
8719 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8720 extension method lookup.
8721 (Namespace.LookupExtensionMethod): Looks for extension method in this
8723 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8724 find a method which matches name and extensionType.
8726 * parameter.cs (Parameter): Add This modifer.
8727 (HasExtensionMethodModifier): New property.
8728 (Resolve): Add extension parameter check.
8729 (ModFlags): turned to property to exclude this modifier as it is not real
8731 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8733 * support.cs (ParameterData): Add ExtensionMethodType.
8734 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8736 * typemanager.cs: Add type and ctor extension attribute type.
8738 2007-02-15 Miguel de Icaza <miguel@novell.com>
8740 * report.cs (DisableErrors, EnableErrors): used to prevent error
8741 output when we are "trying" to compile various methods with
8744 * ecore.cs (Expression): Add Clone method that calls the virtual
8745 CloneTo method. The current CloneTo method in Expression throws
8746 an exception so we can track down all the places where this must
8747 be implemented (not using abstract, because that would be a lot of
8748 up-front-work before we can start testing the implementation
8751 Important: we only need Clone capabilities for expressions created
8752 by the parser, as the expressions we will be cloning are
8753 expressions in the pre-resolved state. This vastly simplifies
8756 (SimpleName): Add CloneTo that does nothing.
8757 (EmptyCast): Add CloneTo.
8759 * expression.cs (Binary): Implement CloneTo.
8760 (Invocation.IsApplicable): Store the current ec in
8761 EmitContext.TempEc and restore it on return. This is used so we
8762 do not have to sprinkle hundres of methods with an extra
8763 EmitContext, we know that the only user is the lambda expression
8764 ImplicitConversionExists code.
8766 (Argument): Add Cloning capabilities.
8767 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8768 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8769 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8770 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8771 IndexerAccess): Add Clone capability.
8773 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8775 (Argument): Add cloning capability.
8777 * assign.cs (Assign): Implement CloneTo.
8779 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8781 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8782 version by calling Convert with the EmitContext (that we are
8783 currently storing in ec, this is not great, but will do for now,
8784 to avoid passing EmitContext parameters to hundreds of functions
8785 that do not need them now).
8787 (SetExpression): Remove, it is not needed.
8789 (ContextualReturn): Implement CloneTo.
8791 * statement.cs (Statement): Implement cloning infrastructure,
8792 similar to expressions.
8794 (Block): Partial implementation of Clone for statements.
8796 (Return): Implement clone.
8798 * constant.cs (Constant.CloneTo): New method, does nothing.
8800 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8801 solution, until we decide how to exactly do this.
8803 2007-02-14 Marek Safar <marek.safar@gmail.com>
8805 A fix for bug #80493
8806 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8807 a property is override we need to use second accessor.
8809 2007-02-13 Marek Safar <marek.safar@gmail.com>
8811 A fix for bug #80418
8812 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8815 2007-02-13 Marek Safar <marek.safar@gmail.com>
8817 Another fix for bug #80749
8818 * pending.cs: Abstract class has priority over interfaces.
8820 2007-02-13 Marek Safar <marek.safar@gmail.com>
8822 Another fix for bug #80749
8823 * pending.cs: Abstract class has priority over interfaces.
8825 2007-02-13 Marek Safar <marek.safar@gmail.com>
8827 Another fix for bug #80749
8828 * pending.cs: Abstract class has priority over interfaces.
8830 2007-02-13 Marek Safar <marek.safar@gmail.com>
8832 Another fix for bug #80749
8833 * pending.cs: Abstract class has priority over interfaces.
8835 2007-02-13 Marek Safar <marek.safar@gmail.com>
8837 * class.cs Better error message.
8839 * driver.cs: Add shorter versions of -optimize option.
8841 2007-02-13 Martin Baulig <martin@ximian.com>
8843 * class.cs (Constructor.Emit): Check the return value of
8844 ec.ResolveTopBlock() and return on error.
8846 2007-02-13 Raja R Harinath <rharinath@novell.com>
8848 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8849 message to fix error message regression.
8851 2007-02-12 Marek Safar <marek.safar@gmail.com>
8853 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8855 2007-02-12 Marek Safar <marek.safar@gmail.com>
8857 A fix for bug #80749
8858 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8859 its parent container.
8861 * class.cs (DefineFieldInitializers): Each initializer can has different
8864 * const.cs: Updated.
8866 2007-02-11 Miguel de Icaza <miguel@novell.com>
8868 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8869 now all the heavy lifting to check that embedded statements or
8870 expressions have the right form is done in the ContextualReturn.
8872 (ContextualReturn): New class.
8874 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8875 method that can be invoked to report 201, so we do not replicate
8878 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8880 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8881 treating tabs as spaces.
8883 2007-02-09 Marek Safar <marek.safar@gmail.com>
8885 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8886 * assign.cs: Use full implicit conversion for right side check.
8888 2007-02-09 Marek Safar <marek.safar@gmail.com>
8890 * statement.cs (Switch): Switch over boolean type is not standardized.
8892 2007-02-08 Marek Safar <marek.safar@gmail.com>
8894 A fix for bug #80755
8895 * decl.cs (FindBaseEvent): Don't use method cache for events.
8897 2007-02-07 Marek Safar <marek.safar@gmail.com>
8899 * cs-parser.jay: Better syntax error handling.
8901 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8902 instead of underlying type value.
8904 2007-02-06 Marek Safar <marek.safar@gmail.com>
8906 * driver.cs: Check define identifier before is registered.
8908 * namespace.cs: Use existing error message.
8910 * report.cs: New warning.
8912 2007-02-06 Marek Safar <marek.safar@gmail.com>
8914 A fix for bug #80742
8915 * expression.cs: Delegate Invoke method can be called directly.
8917 2007-02-06 Marek Safar <marek.safar@gmail.com>
8919 A fix for bug #80676
8920 * class.cs (IsEntryPoint): The Main method can have params modifier.
8922 2007-02-04 Miguel de Icaza <miguel@novell.com>
8924 * parameter.cs (Parameter, Parameters): Add Clone method.
8926 * anonymous.cs (Compatible): Turn method into virtual method, so
8927 LambdaExpression can implement a different behavior.
8929 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8930 out the basic checking here, so it can be used by
8933 * lambda.cs: Introduce "Compatible" function that will do the
8936 2007-02-02 Marek Safar <marek.safar@gmail.com>
8938 * attribute.cs: Unified one error message.
8940 * class.cs (Class): Use type attributes and not properties to test static
8942 (IsEntryPoint): Don's pass local variable.
8944 * convert.cs: Removed duplicate check.
8946 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8948 * driver.cs: Don't crash when soft reference does not exist.
8950 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8951 (UsingEntry): Removed redundant allocation.
8953 * parameter.cs: Add fast path for type parameters.
8955 * support.cs: Don't allocate attribute when it's not used.
8957 2007-01-30 Miguel de Icaza <miguel@novell.com>
8960 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8961 this into a virtual method, so we can override it in LambdaExpression.
8963 * driver.cs: Improve diagnostics in case of failure.
8965 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8966 write a function that is slightly more complex and that parses:
8968 type identifier [, type identifier]* )
8970 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8973 (canEmpty ? i >= 0 : i > 0)
8975 2007-01-30 Raja R Harinath <rharinath@novell.com>
8977 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8978 exception on possibly valid code.
8980 2007-01-29 Raja R Harinath <rharinath@novell.com>
8982 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8984 (parse_opt_type_arguments): Remove. It's almost the same as
8986 (parse_namespace_or_typename): Use parse_less_than.
8988 2007-01-28 Miguel de Icaza <miguel@novell.com>
8990 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8991 this bug took a few hours to find, because the state saved and
8992 restored by PushPosition and PopPosition was ignoring the state of
8993 parse_generic_less_than.
8995 I can also now remove the handling of OP_LT and OP_GT, this solves
8998 * cs-tokenizer.cs: store the location for the ARROW token, we use
9001 (PushPosition, PopPosition): save/restore also `current_token',
9002 restore `parse_generic_less_than' (was missing).
9004 (parse_opt_type_arguments): use parse_type, not
9005 parse_namespace_or_typename to parse types.
9007 * lambda.cs: Empty new file, will eventually have the lambda
9008 expression implementation.
9010 * lambda.test: used to test the internal tokenizer.
9012 * report.cs (FeatureIsNotISO1): Rename from
9013 FeatureIsNotStandardized, because it was about the language level
9014 (1 vs 2) it was not about standarization.
9016 (FeatureRequiresLINQ): New.
9018 * support.cs (SeekableStreamReader): Only require that the reader
9019 is a TextReader, not a StreamReader, so we can plug StringReader.
9021 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
9022 given position in the input stream the following tokens can be
9023 parsed as a type followed by an identifier.
9025 (is_punct): after a '(' if parse_type_and_parameter returns true,
9026 then return a special token OPEN_PARENS_LAMBDA which is used to
9027 avoid reduce/reduce errors in the grammar for the
9028 lambda_expression rules.
9030 (parse_type): implement a type parser inside the
9031 tokenizer, the parser only returns true or false depending on
9032 whether the input at a given position can be parsed as a type.
9034 (peek_token): new method used during type parsing.
9036 2007-01-28 Raja R Harinath <rharinath@novell.com>
9039 * anonymous.cs (ScopeInfo.InflateParameters): New.
9040 (AnonymousContainer.Resolve): Use it to redirect types of
9041 delegate parameters.
9043 2007-01-27 Raja R Harinath <rharinath@novell.com>
9046 * expression.cs (Error_InvalidArguments): Don't use two different
9047 messages for CS1503. Use ExtraInformation and
9048 SymbolRelatedToPreviousError instead.
9051 * decl.cs (DeclSpace.initialize_type_params): Don't access
9052 'type_params' of a partial class directly.
9054 2007-01-26 Miguel de Icaza <miguel@novell.com>
9056 * constant.cs: Removed a handful of out-of-range checks that were
9059 2007-01-25 Marek Safar <marek.safar@gmail.com>
9061 * expression.cs (CheckUselessComparison): Add additional check for char
9064 * namespace.cs: Fixed typo.
9066 2007-01-23 Miguel de Icaza <miguel@novell.com>
9068 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
9069 gone, instead we inline the test, preventing the needless casts to
9070 longs, ulongs and doubles for the parameters, avoiding calls to
9071 methods that overchecked stuff, and instead inlined things
9074 2007-01-20 Marek Safar <marek.safar@gmail.com>
9076 * cs-parser.jay: Better parameter error handling.
9078 2007-01-17 Marek Safar <marek.safar@gmail.com>
9080 A fix for bug #80368, #80522
9081 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
9082 whether array initializer contains constants only.
9083 (ArrayCreation.Emit): Use better formula to decide when
9084 are array initializers for static initialization.
9085 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
9086 have to emit even constants otherwise they are pre-initialized.
9088 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
9089 Raja R Harinath <rharinath@novell.com>
9091 Fix emit order of 'get' vs. 'set'.
9092 * support.cs (Accessors): New.
9093 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
9094 Note the order in which accessors are declared in the source.
9095 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
9096 Refactored from Property.Define and Indexer.Define.
9097 (PropertyBase.DefineAccessors): New helper that calls the above in
9098 appropriate order as noted by the parser.
9099 (Property.Define, Indexer.Define): Update to changes.
9100 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
9102 2007-01-17 Raja R Harinath <rharinath@novell.com>
9104 Fix cs0029-6.cs and gcs0029-2.cs (regression)
9105 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
9106 there's an implicit conversion from the current type to the target
9107 type before converting the underlying constant.
9109 2007-01-16 Marek Safar <marek.safar@gmail.com>
9111 * const.cs (ResolveValue): Updated after constant conversion was made more
9114 * constant.cs (GetAttributableValue): constant to object conversion is
9115 used for attributes only.
9116 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
9117 constant conversions.
9118 (LongConstant.ConvertImplicitly): Ditto.
9120 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
9121 (ImplicitConversionStandard): Handle constant conversion as extra step.
9122 It solves the issue when constant conversion was called indirectly like
9123 inside array initializer and constant folding was skipped.
9125 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
9128 * statement.cs(ImplicitConversionStandard): Updated after constant
9129 conversion was made more generic.
9131 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
9133 * expression.cs (As.DoResolve): Use GenericConstraints instead of
9134 Constraints, solves the problem where the compiler incorrectly
9135 reported that a type parameter was not constrained to a class (Bug
9138 2007-01-14 Marek Habersack <grendello@gmail.com>
9140 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
9142 2007-01-14 Marek Safar <marek.safar@gmail.com>
9144 A fix for bug #80368
9145 * assign.cs (FieldInitializer): New class implements field
9146 initializer statement.
9148 * attribute.cs: Update after FieldMember rename.
9150 * class.cs (PropertyBasedMember): New common class for property based
9152 (InterfaceMemberBase): New base class for all members which can be used as
9153 an interface members.
9154 (MethodCore): Moved really common code to InterfaceMemberBase.
9155 (Method.Define): Equal and GetHasCode detection is relevant for methods
9157 (MethodData.Define): Don't assume that public event implements an
9158 interface automatically.
9159 (MethodData.DefineMethodBuilder): Issue an error even if only extern
9161 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
9162 (FieldMember): Merged with FieldBase.
9163 (EventProperty.AEventPropertyAccessor): New specialization to check whether
9164 event extern modifier can be used.
9165 (EventField.EventFieldAccessor): Moved event field specific code here.
9166 (Event.AllowedModifiers): Even event can be extern.
9167 (Event.FindOutBaseMethod): New override specific to events.
9168 (Indexer.parameters): Reintroduce parameters because base class holds
9169 only properties common data.
9170 (Indexer.CheckForDuplications): Indexers are threated as methods so we
9171 need do extra parameters check.
9173 * const.cs: Update after FieldMember rename.
9175 * decl.cs (MemberCache.FindBaseEvent): New method.
9177 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
9178 to reflect that indexer is now derived from PropertyBased.
9180 * ecore.cs (GetMemberType): Made public.
9181 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
9184 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
9186 * typemanager.cs (CSharpSignature): Correctly print event accessors.
9187 (RegisterEvent): Removed.
9188 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
9189 (GetPrivateFieldOfEvent): Renamed to GetEventField.
9191 2007-01-11 Raja R Harinath <rharinath@novell.com>
9194 * statement.cs (CollectionForeach.TryType): Prefer generic
9195 GetEnumerator over non-generic variant. Fix code to follow comments.
9197 2007-01-09 Raja R Harinath <rharinath@novell.com>
9200 * support.cs (ReflectionParameter): Don't use an invalid index on
9201 the generic parameter data.
9203 2007-01-08 Miguel de Icaza <miguel@novell.com>
9205 * driver.cs: Just add a tiny bit of infrastructure.
9207 2007-01-02 Marek Safar <marek.safar@gmail.com>
9209 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
9210 where field type is struct from current assembly.
9212 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9215 2007-01-02 Marek Safar <marek.safar@gmail.com>
9217 A fix for bug #80381
9218 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9221 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9223 (Namespace.LookupType): Always use core types from corlib when speficied.
9225 * report.cs: A new warning.
9227 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9228 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9229 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9231 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9232 (InitCoreTypes): Set expression type of object_type and value_type
9233 immediately after lookup.
9235 2007-01-01 Miguel de Icaza <miguel@novell.com>
9237 * cs-tokenizer.cs: Accept Pc class characters (Connector
9238 Punctuation) as valid identifiers. Fixes #78259
9240 * expression.cs (Invocation.DoResolve): Moved the check for the
9241 use of `this' for doing method calls to the Invocation resolution
9242 step, after overload resolution has taken place instead of doing
9243 the check at the low-level `This.DoResolve' level.
9245 The `This.DoResolve'(appens before overload resolution, so it has
9246 no way of knowing if the method that will be called will be
9247 instace or static, triggering an erroneous report for cs0188 (Bug
9250 We now do the check for instance method invocations after we know
9251 what method will be called.
9253 (This.CheckThisUsage): Move the actual use of this structure
9254 checking into its own method and expose it.
9256 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9259 Exceptions: Null.ConvertImplicitly,
9260 Constant.ImplicitConversionRequired as there are too many call
9261 sites for passing the ec.
9263 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9264 EmitContext, if the value is null, then we do not try to provide
9265 the extra information from the error (If a userdefined conversion
9266 exists, as UserDefinedConversion requires a non null-EmitContext).
9270 2006-12-30 Raja R Harinath <rharinath@novell.com>
9272 * flowanalysis.cs (MyBitVector): Document some invariants.
9273 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9274 introduced below, and add a couple of others,
9276 2006-12-30 Marek Safar <marek.safar@gmail.com>
9278 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9279 GetPropertyFromAccessor and GetEventFromAccessor.
9281 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9282 overrides non-obsolete one.
9283 (Indexer.Define): Error message has been moved to the parser.
9285 * cs-parser.jay: Better syntax errors handling.
9287 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9288 when an invocation has no arguments.
9290 * ecore.cs: Removed not used caching.
9292 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9295 * report.cs: Add a new warning.
9297 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9299 * typemanager.cs (enumeration_type): Removed.
9300 (CSharpSignature): Reuses IsSpecialMethod.
9301 (IsEqual): Hack for MS BCL.
9302 (GetPropertyFromAccessor): New method.
9303 (GetEventFromAccessor): New method.
9304 (IsSpecialMethod): Fixed to handle more cases.
9306 2006-12-30 Marek Safar <marek.safar@gmail.com>
9308 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9309 Made white spaces array static.
9311 * ecore.cs (RemoveGenericArity): Optimized.
9313 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9315 (MyBitVector.initialize_vector): Simplified.
9317 2006-12-22 Miguel de Icaza <miguel@novell.com>
9319 * ecore.cs: Am not entirely happy with this hack, but it seems to
9320 address the issue in 80257 (a small test case for
9323 I set the MethodGroupExpr.Type to an internal compiler type
9324 (itself in this case) to force the resolution to take place. Why
9325 it does not take place with a null is beyond me.
9327 2006-12-20 Marek Safar <marek.safar@gmail.com>
9329 A fix for bug #80288
9330 * expression.cs (ResolveOperator): Consider user defined conversion for
9331 logical and operator too.
9332 (EmitBranchable): Optimization for logical and when full constant folding
9333 could not be applied but one operand is constant.
9335 2006-12-19 Marek Safar <marek.safar@gmail.com>
9337 * class.cs (GetClassBases): Write 5 times every day, will never use
9338 FullName for error reporting.
9340 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9342 2006-12-19 Martin Baulig <martin@ximian.com>
9344 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9345 the symbol file info here.
9347 2006-12-18 Marek Safar <marek.safar@gmail.com>
9349 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9350 of `elseif' is taking then following sections are not taking.
9351 Fixes an issue reported on mono mailing list.
9353 2006-12-18 Marek Safar <marek.safar@gmail.com>
9355 A fix for bug #80300
9356 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9357 a caller is not taking.
9359 2006-12-18 Raja R Harinath <rharinath@novell.com>
9361 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9362 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9363 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9364 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9365 * class.cs: Update to changes.
9367 2006-12-17 Marek Safar <marek.safar@gmail.com>
9369 A fix for bug #79934
9370 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9373 * class.cs (ResolveMembers): Register an iterator in current container and
9376 2006-12-16 Raja R Harinath <rharinath@novell.com>
9379 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9380 satisfy a params annotated parameter.
9382 2006-12-16 Marek Safar <marek.safar@gmail.com>
9384 A fix for bug #77014
9385 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9386 paramters correctly and not rely on hacks in Parameters class.
9387 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9389 (Invocation.VerifyArgumentsCompat): Ditto.
9390 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9393 * parameter.cs (HasParams): Don't assume that params is the last one.
9395 * support.cs (ReflectionParameters.ctor): Look for params attribute
9397 (ReflectionParameters.ParameterType): Removed hack when we returned last
9398 parameter for out of range parameters.
9399 (ParameterName, ParameterModifier): Ditto.
9401 2006-12-14 Marek Safar <marek.safar@gmail.com>
9403 A fix for bug #79987
9404 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9405 when assembly is not CLS compliant but type is. I have no idea why is this
9408 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9410 2006-12-13 Miguel de Icaza <miguel@novell.com>
9412 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9413 in struct constructors, they are basically no-ops.
9415 2006-12-12 Marek Safar <marek.safar@gmail.com>
9417 * cs-tokenizer.cs (Position): Save preprocessor status too.
9419 2006-12-12 Marek Safar <marek.safar@gmail.com>
9421 A fix for bug #77794
9422 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9424 2006-12-12 Marek Safar <marek.safar@gmail.com>
9426 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9428 (pp_expr): Report error for an invalid expression.
9429 (handle_preprocessing_directive): Simplified; add more error checking.
9431 2006-12-11 Marek Safar <marek.safar@gmail.com>
9433 A fix for bug #74939
9434 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9435 directives handling.
9437 2006-12-10 Marek Safar <marek.safar@gmail.com>
9439 A fix for bugs #80093, and #75984
9440 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9441 logic, it seems to me as it worked before "by coincidence".
9442 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9443 (cleanup): Enabled endif check.
9445 2006-12-09 Marek Safar <marek.safar@gmail.com>
9447 A fix for bug #80162
9448 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9449 enumerators are never ambiguous.
9451 2006-12-08 Raja R Harinath <rharinath@novell.com>
9454 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9456 2006-12-06 Marek Safar <marek.safar@gmail.com>
9458 A fix for bug #80144
9459 * class.cs (EventProperty.Define): Explicit implementation means
9460 that an even is used.
9462 2006-12-06 Marek Safar <marek.safar@gmail.com>
9464 Fixes the operators implementation (part II)
9466 * cfold.cs (DoConstantNumericPromotions): Renamed to
9467 DoBinaryNumericPromotions and simplified.
9468 (BinaryFold): Couple of conversion fixes; simplified.
9470 * constant.cs, ecore.cs, literal.cs
9471 (ToType): Renamed to ConvertImplicitly.
9472 (Reduce): Renamed to ConvertExplicitly.
9474 * class.cs, convert.cs: Updated.
9476 * expression.cs: TryReduce doesn't throw an exception.
9478 2006-12-01 Marek Safar <marek.safar@gmail.com>
9480 A fix for bug #80108
9481 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9484 2006-11-30 Marek Safar <marek.safar@gmail.com>
9486 Fixes unary operators implementation (part I)
9489 * cfold.cs (Error_CompileTimeOverflow): Made internal
9491 * const.cs (IConstant): Changed to use reference to constant and
9492 not constant itself.
9493 Updated IConstant implementations.
9495 * constant.cs (CreateConstant): New factory method.
9496 Updated IConstant implementation.
9498 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9500 * ecore.cs: Updated to use CreateConstantReference.
9502 * enum.cs: Reflects IConstant changes.
9504 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9506 * literal.cs (NullConstant): Change to be independently usable.
9508 2006-11-29 Martin Baulig <martin@ximian.com>
9510 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9511 we need to emit the scope initializer before calling the base .ctor.
9513 * anonymous.cs: Merged back from the new anonymous methods branch.
9514 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9516 * expression.cs (ParameterReference.DoResolveBase): Create a
9517 "normal" ScopeInfo when capturing parameters rather than using the
9518 root scope; this makes things work with anonymous methods having
9522 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9524 2006-11-22 Marek Safar <marek.safar@gmail.com>
9526 A fix for bug #79987
9527 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9528 check to a base class.
9529 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9530 only when assembly has missing attribute.
9531 * report.cs: Update.
9533 2006-11-21 Marek Safar <marek.safar@gmail.com>
9535 * cs-tokenizer.cs: Merged with gmcs version.
9537 2006-11-20 Marek Safar <marek.safar@gmail.com>
9540 * cs-parser.jay: Better error message when partial keyword is misplaced.
9542 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9544 A fix for bug #79810
9545 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9546 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9547 a RuntimeWrappedException by default.
9549 2006-11-18 Marek Safar <marek.safar@gmail.com>
9551 A fix for bug #79843
9552 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9554 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9556 2006-11-18 Marek Safar <marek.safar@gmail.com>
9558 * driver.cs, namespace.cs: Uses faster IndexOf version.
9560 2006-11-17 Marek Safar <marek.safar@gmail.com>
9562 A fix for bug #79941
9563 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9565 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9566 even if internal name is different.
9567 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9568 (UserDefinedConversion): Simplified as the operators cannot be internal.
9569 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9571 (MethodLookup): Replaced EmitContext with parentType.
9572 * expression.cs: Updated.
9574 2006-11-09 Raja R Harinath <rharinath@novell.com>
9576 * driver.cs (BadAssembly): Handle all the ugliness of
9577 DefineDynamicAssembly.
9579 2006-11-08 Raja R Harinath <rharinath@novell.com>
9581 Address parts of #58244 -- most of what's left is in the runtime
9582 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9583 CS1509 error checks, and handle them for all assembly loads, not
9584 just the first invocation.
9585 (LoadModule): Likewise. Move handling of 'adder_method' ...
9586 * codegen.cs (AssemblyClass.AddModule): ... here.
9588 2006-11-02 Marek Safar <marek.safar@gmail.com>
9590 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9591 IEnumerable<T> is ambiguous.
9593 2006-10-31 Marek Safar <marek.safar@gmail.com>
9595 A fix for bug #67689
9596 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9597 GetEnumerator is ambiguous.
9599 * report.cs: Add new warning.
9601 2006-10-29 Marek Safar <marek.safar@gmail.com>
9603 A fix for bug #78602
9604 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9605 to protected member can be nested type.
9607 2006-10-28 Marek Safar <marek.safar@gmail.com>
9609 A fix for bug #78965
9610 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9611 to protected member must derive from current type.
9613 2006-10-27 Marek Safar <marek.safar@gmail.com>
9615 assign.cs: Reuses error method.
9617 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9618 instead of type for constants.
9619 (Expression.Error_ValueAssignment): Common error method.
9621 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9624 2006-10-27 Marek Safar <marek.safar@gmail.com>
9626 A fix for bug #79081
9627 * expression.cs (MemberAccess.DoResolve): Check nested type
9630 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9632 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9634 2006-10-26 Marek Safar <marek.safar@gmail.com>
9636 A fix for bug #76591
9637 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9639 2006-10-26 Marek Safar <marek.safar@gmail.com>
9641 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9642 type forwarder of the same type multiple times.
9644 2006-10-26 Raja R Harinath <rharinath@novell.com>
9647 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9648 instance as an rvalue, even when we later resolve as an lvalue.
9650 2006-10-25 Martin Baulig <martin@ximian.com>
9652 * anonymous.cs: Fix #79673.
9654 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9656 A fix for bug #79666
9657 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9658 ignored when is optimized (= default value) as its value is already set.
9660 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9662 A fix for bug #79724
9663 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9664 TypeContainer for type lookup.
9666 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9668 A fix for bug #79231
9669 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9670 * expression.cs (OverloadResolve): Always convert type name for
9672 (ResolveNamespaceOrType): Don't confuse a nested type with any
9675 2006-10-18 Martin Baulig <martin@ximian.com>
9677 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9679 2006-10-17 Miguel de Icaza <miguel@novell.com>
9681 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9682 an int32, but requesting an int64 from the conversion
9684 2006-10-12 Martin Baulig <martin@ximian.com>
9687 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9689 2006-10-12 Martin Baulig <martin@ximian.com>
9692 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9694 2006-10-11 Miguel de Icaza <miguel@novell.com>
9696 * convert.cs: Remove broken code: I was doing the "Existance"
9697 tests for Implicit conversions.
9699 2006-10-10 Miguel de Icaza <miguel@novell.com>
9701 * convert.cs: Added one missing case in
9702 ImplicitStandardConversionExists uint64 to intptr.
9706 * typemanager.cs (uintptr_type): another core known type.
9708 * ecore.cs (OperatorCast): routine used to do cast operations that
9709 depend on op_Explicit. We could change some of the Decimal
9710 conversions to use this.
9712 This one has a probe mechanism that checks both types for an op_
9713 which it coudl be used to eliminate two classes: CastToDecimal
9714 and CastFromDecimal.
9716 * convert.cs: Implement the conversions documented in #59800
9718 2006-10-10 Martin Baulig <martin@ximian.com>
9720 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9721 before RootScope.ResolveMembers().
9723 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9724 `CurrentType' if appropriate.
9726 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9728 A fix for bug #78568
9729 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9730 when contains binary operators.
9731 * cs-parser.jay: Updated.
9733 2006-10-09 Martin Baulig <martin@ximian.com>
9736 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9737 moved that into Define() and also do the other type parameter
9738 checks there. Fixes #79094. Added gtest-292.cs.
9741 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9742 since that doesn't include type parameters; don't use `Ldelema'
9743 for type parameters. Fixes #78980. Added gtest-293.cs.
9745 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9748 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9749 conversion is allowed.
9751 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9753 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9754 error reporting when no error occurs.
9756 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9758 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9761 2006-10-06 Raja R Harinath <rharinath@novell.com>
9764 * class.cs (DefineTypeBuilder): Check circular dependencies before
9765 setting the parent of the TypeBuilder.
9766 (CheckRecursiveDefinition): Don't use 'BaseType', since
9767 it may not be valid until after DefineTypeBuilder. Use
9768 'base_type' instead.
9770 2006-10-04 Martin Baulig <martin@ximian.com>
9772 Merged the Anonymous Methods patch.
9774 * anonymous.cs, iterators.cs: The new anonymous methods code.
9776 * statement.cs (Variable): New public abstract class.
9777 (LocalInfo.Variable): New public property.
9778 (LocalInfo.ResolveVariable): New public method.
9779 (Block.Flags): Add `IsIterator'.
9780 (Block.AddVariable): Improved the CS0136 check.
9781 (Block.AnonymousChildren): New public property.
9782 (Block.AddAnonymousChild): New public method.
9783 (ToplevelBlock): Update to use the new anonymous method framework.
9784 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9785 `ToplevelBlock'; this is required to correctly implement the
9787 (Fixed, Using): Use `TemporaryVariable' instead of directly
9788 creating the `LocalBuilder'.
9790 * parameter.cs (Parameter.ResolveVariable): New public method.
9791 (Parameters.ResolveVariable): Likewise.
9793 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9795 * class.cs (TypeContainer): Replaced the `iterators' list and
9796 corresponding methods with a list of `CompilerGeneratedClass'es.
9797 (TypeContainer.ResolveMembers): New public method.
9798 (Method): `IIteratorContainer' has been replaced by
9801 * expression.cs (VariableReference): New public abstract base
9802 class for `LocalVariableReference', `ParameterReference' and
9805 * codegen.cs (EmitContext): Removed `capture_context',
9806 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9807 (EmitContext.EmitThis): Removed.
9809 * cs-parser.jay: Replace `iterator_container' with
9812 2006-10-04 Martin Baulig <martin@ximian.com>
9814 * generic.cs (GenericMethod): Don't make this abstract.
9815 (Constraints.Clone): Added dummy implementation.
9817 2006-10-04 Raja R Harinath <harinath@gmail.com>
9820 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9821 'declspaces'. Avoid allocating arrays willy-nilly.
9824 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9825 cases out of the switch.
9827 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9829 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9830 message when non-generic type is used with the type arguments.
9831 * expression.cs: Updated.
9833 2006-09-28 Raja R Harinath <rharinath@novell.com>
9836 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9837 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9838 Change semantics slightly. Don't insist on having only one
9839 temporary EmptyExpression -- just throttle the creation of new ones.
9842 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9843 non-interfaces too. If no methods are found, don't try to create
9846 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9848 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9851 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9852 us produce better error message.
9854 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9856 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9857 of the `|' operator.
9859 * report.cs: A new warning added.
9861 2006-09-27 Martin Baulig <martin@ximian.com>
9863 * generic.cs (GenericMethod): Don't make this abstract.
9865 2006-09-27 Martin Baulig <martin@ximian.com>
9868 (InternalErrorException): Added overloaded ctor taking a params array.
9870 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9872 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9873 Fixed the cases when same error was reported twice.
9875 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9876 now report symbol information.
9878 2006-09-25 Martin Baulig <martin@ximian.com>
9880 * class.cs: Completely unified with the gmcs version.
9882 2006-09-25 Martin Baulig <martin@ximian.com>
9884 * typemanager.cs (TypeManager.IsNullableType): New public function.
9885 (TypeManager.IsNullableTypeOf): Likewise.
9886 (TypeManager.IsNullableValueType): Likewise.
9888 * class.cs (MethodCore): Added the `GenericMethod' argument from
9889 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9891 2006-09-24 Raja R Harinath <harinath@gmail.com>
9893 * convert.cs: Unify with gmcs version.
9895 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9897 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9898 verify them as well.
9900 * report.cs: New warning.
9902 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9904 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9905 for anonymous block with out argument.
9907 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9909 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9910 not used private events only.
9912 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9914 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9916 * const.cs (Const.Define): Check for constant type.
9917 (Const.IsConstantTypeValid): Looks for valid constant types.
9919 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9921 * ecore.cs (EmptyConstantCast): New common class for all constant based
9924 * expression.cs (Is.DoResolve): Handle null constant especially.
9925 (New.DoResolve): Check for new void().
9926 (MemberAccess.DoResolve): Cope with all kind of nulls.
9928 * literal.cs (NullConstant): Uses EmptyConstantCast.
9929 (NullDefault): Based on EmptyConstantCast.
9930 (NullLiteral): Uses EmptyConstantCast.
9932 * statement.cs (Block.ResolveMeta): Check for constant type.
9934 2006-09-22 Martin Baulig <martin@ximian.com>
9936 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9938 2006-09-22 Raja R Harinath <rharinath@novell.com>
9940 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9944 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9945 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9948 2006-09-22 Martin Baulig <martin@ximian.com>
9950 * ecore.cs: Merged with the gmcs version.
9952 * generic.cs (ConstructedType): New dummy class.
9953 (TypeArguments): Don't make this abstract.
9956 (TypeManager.IsGenericTypeDefinition): New method.
9957 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9959 2006-09-22 Raja R Harinath <rharinath@novell.com>
9961 * expression.cs (ComposedCast): Check for arrays of TypedReference
9962 before creating the type, not after.
9964 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9966 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9967 after ToType change.
9969 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9970 when constant must be implicitly convertible.
9972 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9974 * ecore.cs (NullCast): Derives from NullConstant.
9976 * expression.cs (Is.DoResolve): Removed useless variables.
9977 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9978 (New.Constantify): Add enum support.
9979 (MemberAccess.DoResolve): Add warning when accessing null constant or
9982 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9985 * literal.cs (NullConstant): New abstract class with common
9986 functionality for all null specializations.
9987 (NullDefault): Represents default(X) when result can be
9989 (NullLiteral): Updated.
9991 * report.cs: Add new warning.
9993 2006-09-21 Martin Baulig <martin@ximian.com>
9995 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9997 2006-09-21 Martin Baulig <martin@ximian.com>
9999 * generic.cs (GenericConstraints): New dummy class.
10000 (Constraints): Likewise.
10001 (TypeParameter): Likewise.
10002 (TypeParameterName): Likewise.
10003 (GenericMethod): Likewise.
10005 * typemanager.cs (TypeManager.GetGenericArguments): New method.
10007 * decl.cs: Merged with the gmcs version.
10009 2006-09-21 Raja R Harinath <rharinath@novell.com>
10011 * generic.cs (TypeParameter): Implement IMemberContainer.
10012 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
10014 * rootcontext.cs: Unify with gmcs version.
10016 * report.cs: Unify with gmcs version.
10017 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
10018 from gmcs/generics.cs.
10019 * generics.cs (TypeParameter): New dummy class.
10021 * support.cs: Unify with gmcs version.
10023 2006-09-20 Raja R Harinath <rharinath@novell.com>
10025 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
10026 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
10028 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
10029 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
10030 * mcs.exe.sources: Add generic.cs.
10032 * codegen.cs: Unify with gmcs version.
10034 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
10035 (EmitContext): Add GenericDeclContainer implementation.
10036 * decl.cs (MemberCore, DeclSpace): Likewise.
10037 * namespace.cs: Remove #ifdef GMCS_SOURCE.
10039 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
10040 MCS TypeManager has a corresponding dummy method.
10042 2006-09-19 Martin Baulig <martin@ximian.com>
10044 * expression.cs: Completely merged with the gmcs version.
10046 2006-09-19 Martin Baulig <martin@ximian.com>
10048 * expression.cs (Invocation): Merged with the gmcs version.
10049 (ArrayAccess.GetStoreOpcode): Likewise.
10051 2006-09-19 Martin Baulig <martin@ximian.com>
10054 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
10055 (TypeManager.IsGenericMethodDefinition): Likewise.
10057 2006-09-19 Martin Baulig <martin@ximian.com>
10060 (TypeManager.IsEqual): Moved the gmcs implementation here.
10061 (TypeManager.DropGenericTypeArguments): Likewise.
10062 (TypeManager.DropGenericMethodArguments): Likewise.
10063 (TypeManager.GetTypeArguments): Moved here from gmcs.
10064 (TypeManager.HasGenericArguments): Likewise.
10066 2006-09-19 Martin Baulig <martin@ximian.com>
10068 * expression.cs (Binary): Merged with the gmcs version.
10070 2006-09-19 Martin Baulig <martin@ximian.com>
10072 * expression.cs (Probe, As, Is): Merged with the gmcs version.
10074 2006-09-19 Martin Baulig <martin@ximian.com>
10076 * typemanager.cs: Merged with the gmcs version.
10078 2006-09-16 Raja R Harinath <rharinath@novell.com>
10080 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
10081 * driver.cs: Likewise.
10083 2006-09-16 Marek Safar <marek.safar@seznam.cz>
10086 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
10087 only if parent type is class.
10088 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
10091 2006-09-15 Marek Safar <marek.safar@seznam.cz>
10094 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
10096 * typemanager.cs(CSharpName): Converts NullType to null.
10098 2006-09-15 Martin Baulig <martin@ximian.com>
10101 (TypeManager.GetMethodName): Added mcs implementation.
10102 (TypeManager.IsEqual): Likewise.
10105 (SimpleName.RemoveGenericArity): Added dummy implementation.
10107 * pending.cs: Merged with the gmcs version.
10109 2006-09-15 Martin Baulig <martin@ximian.com>
10111 * statement.cs: Merge with the gmcs version.
10113 2006-09-15 Martin Baulig <martin@ximian.com>
10115 * statement.cs (Switch): Merge with the gmcs implementation
10116 (without nullables), which is newer.
10118 2006-09-15 Martin Baulig <martin@ximian.com>
10120 * statement.cs (Block.Variables): Make this public.
10121 (ToplevelBlock.Parameters): Make this a property.
10122 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
10124 2006-09-15 Martin Baulig <martin@ximian.com>
10126 * namespace.cs: Merge with the gmcs version.
10128 2006-09-15 Martin Baulig <martin@ximian.com>
10130 * decl.cs (MemberName): Minor code cleanups.
10132 2006-09-15 Martin Baulig <martin@ximian.com>
10134 * parameter.cs: Merge with the gmcs version.
10136 2006-09-15 Martin Baulig <martin@ximian.com>
10138 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
10139 and an error in mcs.
10141 2006-09-15 Martin Baulig <martin@ximian.com>
10143 * flowanalysis.cs: Merged from GMCS; added the generics code into
10144 a `GMCS_SOURCE' conditional so we can share this file.
10146 2006-09-08 Martin Baulig <martin@ximian.com>
10148 * typemanager.cs (TypeManager.interlocked_type): New public field.
10149 (TypeManager.int_interlocked_compare-exchange): New public field.
10150 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
10151 enumerator types here and call InitGenericCoreTypes().
10152 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
10153 after calling InitEnumUnderlyingTypes().
10156 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
10157 `classes_second_stage'.
10159 2006-09-14 Marek Safar <marek.safar@seznam.cz>
10161 * assign.cs, ecore.cs, expression.cs: Share error message text.
10162 * class.cs (FieldMember.Define): Check for varible of static type.
10163 * driver.cs (LoadAssembly): Uses error output for errors.
10164 * statement.cs: Updated.
10166 2006-09-08 Marek Safar <marek.safar@seznam.cz>
10168 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
10171 2006-09-07 Martin Baulig <martin@ximian.com>
10174 (MainDriver): Revert r62663 from Marek; see #70506 for details.
10176 2006-08-29 Miguel de Icaza <miguel@novell.com>
10178 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
10180 2006-08-17 Miguel de Icaza <miguel@novell.com>
10182 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
10183 #52019 and #79064, the use of the \uXXXX sequence in source code
10184 to represent unicode characters.
10186 2006-08-15 Marek Safar <marek.safar@seznam.cz>
10188 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
10190 * class.cs, ecore.cs, statement.cs: Merged to one error message.
10192 2006-08-13 Miguel de Icaza <miguel@novell.com>
10194 * assign.cs: Catch attempts to assign to a method groups in += and
10197 2006-08-13 Marek Safar <marek.safar@seznam.cz>
10200 * cs-parser.jay: Don't destroy current array type by typeof of array's.
10202 2006-08-12 Marek Safar <marek.safar@seznam.cz>
10204 * class.cs (Method.Define): Issue a warning when generic method looks like
10206 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
10209 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10211 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10213 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10214 search all base interfaces as a member can be ambiguous.
10215 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10216 Constructor member type filter.
10217 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10218 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10219 reporting for returned memberinfos.
10220 * report.cs: Updated.
10221 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10222 version to work on all runtimes.
10223 (TypeManager.RealMemberLookup): Removed members filtering.
10225 2006-08-08 Raja R Harinath <rharinath@novell.com>
10227 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10228 (PropertyExpr.EmitAssign): Likewise.
10229 * expression.cs (Indirection.EmitAssign): Likewise.
10230 (LocalVariableReference.EmitAssign): Likewise.
10231 (ParameterReference.EmitAssign): Likewise.
10232 (Invocation.EmitArguments): Likewise.
10233 (ArrayAccess.EmitAssign): Likewise.
10234 (IndexerAccess.EmitAssign): Likewise.
10235 (This.EmitAssign): Likewise.
10236 (ConditionalLogicalOperator.Emit): Likewise.
10239 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10240 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10241 leave it in after returning it.
10242 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10244 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10246 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10249 2006-08-03 Raja R Harinath <rharinath@novell.com>
10251 Fix cs0146-3.cs and cs0146-4.cs.
10252 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10253 enclosing types don't depend on the current type.
10255 2006-08-02 Raja R Harinath <rharinath@novell.com>
10258 * class.cs (TypeContainer.DoDefineMembers): Use
10259 FindBaseMemberWithSameName on Parent, since we're interested in
10260 whether we hide inherited members or not.
10261 (FindBaseMemberWithSameName): Make slightly more robust.
10263 Fix the non-generic testcase from #77396
10264 * decl.cs (DeclSpace.DeclContainer): Remove override.
10266 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10267 declspaces for doppelgangers too.
10268 (UsingEntry): Implement IResolveContext.
10269 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10270 'this' as the resolve context.
10271 (LocalAliasEntry): Likewise.
10273 Implement parts of #77403
10274 * roottypes.cs (RootDeclSpace): New. Used to represent the
10275 toplevel declaration space. Each namespace declaration introduces
10276 a "partial" root declaretion space.
10277 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10278 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10279 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10280 from 'current_namespace.SlaveDeclSpace'.
10281 (namespace_declaration): Likewise.
10282 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10283 check. It can't happen now.
10284 * decl.cs (DeclSpace.LookupType): Likewise.
10285 * driver.cs (MainDriver): Sanity check.
10287 2006-08-01 Raja R Harinath <rharinath@novell.com>
10289 * decl.cs (DeclSpace.FindNestedType): Remove.
10290 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10291 LookupTypeContainer to get the container of the nested type.
10292 * class.cs (TypeContainer.FindNestedType): Make non-override.
10294 2006-07-31 Raja R Harinath <rharinath@novell.com>
10296 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10297 * class.cs (TypeContainer.PartialContainer): ... here.
10298 (TypeContainer.AddBasesForPart): New helper.
10299 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10301 * cs-parser.jay (current_class): Convert to DeclSpace.
10302 (struct_declaration, interface_declaration, class_declaration):
10303 Use AddBasesForPart instead of .Bases directly.
10304 * const.cs, iterators.cs: Update to changes.
10306 2006-07-28 Raja R Harinath <rharinath@novell.com>
10308 * class.cs (TypeContainer.AddMemberType): Rename from
10309 AddToTypeContainer.
10310 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10311 (AddTypeContainer): New. Combine AddClassOrStruct and
10313 (AddPartial): Update. Add 'is_partial' argument.
10314 * roottypes.cs: Update to changes.
10315 * cs-parser.jay (push_current_class): New helper for handling
10316 current_container and current_class.
10317 (struct_declaration, interface_declaration, class_declaration):
10320 2006-07-26 Raja R Harinath <rharinath@novell.com>
10322 * roottypes.cs: Rename from tree.cs.
10324 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10325 * tree.cs (Tree, ITreeDump): Remove types.
10326 * rootcontext.cs (tree, Tree): Remove fields.
10327 (root, ToplevelTypes): New.
10328 * *.cs: Update to rename.
10330 * tree.cs (Tree.RecordDecl): Remove.
10331 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10333 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10335 2006-07-23 Raja R Harinath <harinath@gmail.com>
10337 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10338 DoFlowAnalysis and OmitStructFlowAnalysis here.
10339 (ec.With): Rename from WithUnsafe and generalize.
10340 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10341 (ec.WithFlowAnalyis): New.
10342 * ecore.cs, expression.cs, statement.cs: Update.
10344 2006-07-22 Raja R Harinath <harinath@gmail.com>
10346 * statement.cs (Block.ResolveMeta): Simplify slightly.
10348 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10349 multiple boolean fields. Convert InUnsafe, constant_check_state,
10350 check_state to flags.
10351 (CheckState, ConstantCheckState): Update.
10352 (InUnsafe): New read-only property.
10353 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10355 (WithUnsafe): New helper similar to WithCheckState.
10356 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10357 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10359 2006-07-21 Raja R Harinath <rharinath@novell.com>
10361 Make comparisons use the same IL irrespective of whether they're
10362 in a 'checked' or 'unchecked' context: one of the issues in #78899
10363 * codegen.cs (EmitContext.CheckState): Make read-only property.
10364 (EmitContext.ConstantCheckState): Likewise.
10365 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10366 helper that implement a save/restore stack for CheckState
10367 values. This is the only way to change check-state.
10368 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10369 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10370 (CheckedExpr.EmitBranchable): New forwarding method.
10371 (UnCheckedExpr): Likewise.
10372 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10373 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10374 (Checked.Resolve, checked.DoEmit): Likewise.
10376 2006-07-20 Miguel de Icaza <miguel@novell.com>
10378 * anonymous.cs: Cache the resolved anonymous delegate, and return
10379 this so that the ResolveTopBlock is only triggered once, not
10382 Currently we trigger ResolvetopBlock twice due to a first pass of
10383 argument check compatibility, and a second pass that does the
10386 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10388 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10390 * rootcontext.cs (Reset): Add helper_classes.
10392 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10395 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10398 2006-07-13 Miguel de Icaza <miguel@novell.com>
10400 * statement.cs (Lock): Handle expressions of type
10401 TypeManager.null_type specially. Fixes #78770
10403 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10405 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10408 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10410 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10411 for accessors as well.
10412 * ecore.cs (EventExpr): Add AccessorTable.
10414 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10417 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10418 for CS0122 where appropriate.
10419 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10421 (Filter): Assembly can be null in the case of top level attributes.
10423 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10427 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10428 is done at global level.
10430 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10432 A fix for #77002, Implemented TypeForwarder support.
10434 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10435 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10436 * typemanager.cs (): Add type_forwarder_attr_type.
10438 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10440 * report.cs: Add CS0469 warning.
10442 2006-06-21 Martin Baulig <martin@ximian.com>
10444 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10445 the `try'-block, so we also report CS0016 etc. there.
10447 2006-06-21 Martin Baulig <martin@ximian.com>
10450 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10452 2006-06-21 Martin Baulig <martin@ximian.com>
10454 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10455 also report CS1686 for parameters.
10457 2006-06-21 Martin Baulig <martin@ximian.com>
10459 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10460 instead of an error if the value is not implicitly convertible to
10461 the switch types; fixes #77964.
10463 2006-06-21 Raja R Harinath <rharinath@novell.com>
10466 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10467 FieldBuilder is null.
10470 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10471 'left' and 'right' before error-checking.
10473 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10475 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10477 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10478 (FieldExpr.DoResolve): likewise.
10479 (PropertyExpr.InstanceResolve): likewise.
10480 (EventExpr.InstanceResolve): likewise.
10482 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10484 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10485 attribute applicable tests for attribute argument.
10487 2006-06-02 Raja R Harinath <rharinath@novell.com>
10490 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10491 (Binary.OverloadResolve_PredefinedIntegral): New.
10492 (Binary.OverloadResolve_PredefinedFloating): New.
10493 (Binary.OverloadResolve_PredefinedString): New.
10494 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10495 Follow the standard more closely, and treat numeric promotions in
10496 terms of overload resolution.
10497 (Binary.CheckShiftArguments): Simplify.
10499 2006-06-01 Raja R Harinath <rharinath@novell.com>
10501 * flowanalysis.cs (MyBitVector): Simplify representation.
10502 (MyBitVector.Clone): Avoid allocating BitArray.
10503 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10504 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10505 (*): Update. Change all references to MyBitVector.And and
10506 MyBitVector.Or to &= and |=.
10508 2006-05-29 Raja R Harinath <rharinath@novell.com>
10510 Fix cs0231-[34].cs.
10511 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10512 to param arguments too.
10514 2006-05-26 Miguel de Icaza <miguel@novell.com>
10516 * cs-parser.jay: Catch another parsing form for arglist being
10517 followed by other arguments. Fixes #78313.
10519 2006-05-24 Raja R Harinath <rharinath@novell.com>
10521 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10522 checking of out parameters to ...
10523 (FlowBranchingToplevel.Merge): ... here.
10524 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10525 set, propagate the origin upward, and only complain if there was
10527 (FlowBranchingException.AddContinueOrigin): Likewise.
10528 (FlowBranchingException.AddReturnOrigin): Likewise.
10529 (FlowBranchingException.AddGotoOrigin): Likewise.
10531 2006-05-23 Raja R Harinath <rharinath@novell.com>
10533 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10534 unreachable, skip it.
10535 (FlowBranchingException.Merge): Always propagate jumps, even if
10536 the finally block renders subsequent code unreachable.
10538 2006-05-18 Raja R Harinath <rharinath@novell.com>
10541 * statement.cs (Goto.Resolve): Move responsibility for resolving
10542 'goto' to FlowBranching.AddGotoOrigin.
10543 (Goto.SetResolvedTarget): New. Callback to set the
10544 LabeledStatement that's the target of the goto.
10545 (Goto.DoEmit): Use Leave instead of Br when crossing an
10546 unwind-protect boundary.
10547 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10548 LookupLabel and adjust to new semantics.
10549 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10550 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10551 Goto.SetResolvedTarget to update target.
10552 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10553 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10554 AddBreakOrigin & co. Delay propagation until ...
10555 (FlowBranchingException.Merge): ... this.
10557 * statement.cs (Block.Resolve): Always depend on flow-branching to
10558 determine unreachability. Kill workaround that originally emitted
10559 only one statement after an "unreachable" label (see infloop in
10562 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10563 This is still "wrong", but anything better would probably need a
10564 multi-pass algorithm.
10565 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10566 usage vector. Force current usage vector to be reachable, to
10567 optimistically signify backward jumps.
10568 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10570 (FlowBranchingLabeled.Merge): New. If no backward jump was
10571 detected, return the original salted-away usage vector instead,
10572 updated with appropriate changes. Print unreachable warning if
10574 * statement.cs (Block.Resolve): Don't print unreachable warning on
10575 a labeled statement.
10577 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10579 * driver.cs: Pass filename without path to AssemblyBuilder's
10580 AddResourceFile. Fixes bug #78407.
10582 2006-05-17 Raja R Harinath <rharinath@novell.com>
10584 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10585 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10586 (FlowBranching.MergeChild): Overwrite
10587 reachability information from Labeled branchings too.
10589 2006-05-16 Raja R Harinath <rharinath@novell.com>
10591 * statement.cs (Goto.Resolve): Merge jump origins here ...
10592 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10594 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10595 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10596 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10597 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10599 * statement.cs (Goto.Resolve): ... not here.
10600 (Goto.Emit): Remove CS1632 check.
10602 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10604 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10607 2006-05-11 Raja R Harinath <rharinath@novell.com>
10609 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10610 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10611 (FlowBranchingException.Label): Likewise.
10613 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10615 (MyBitVector.Or): Use it to avoid losing information (Count).
10616 (FlowBranching.MergeOrigins): Likewise.
10618 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10619 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10620 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10621 (UsageVector.ToString): Simplify.
10622 (UsageVector.MergeSiblings): Move here from ...
10623 (FlowBranching.Merge): ... here.
10624 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10627 2006-05-10 Raja R Harinath <rharinath@novell.com>
10629 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10630 null bitvector is treated as all-true.
10632 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10633 (MyBitVector): Rationalize invariants. 'vector != null' implies
10634 that we have our own copy of the bitvector. Otherwise,
10635 'InheritsFrom == null' implies all inherited bits are true.
10637 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10639 * statement.cs (LocalInfo): Add IsConstant.
10640 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10641 local variable for constants.
10643 2006-05-09 Raja R Harinath <rharinath@novell.com>
10645 * flowanalysis.cs (MyBitVector.Empty): New.
10646 (MyBitVector): Don't allow InheritedFrom to be null.
10647 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10648 (UsageVector, FlowBranching): Update to changes.
10650 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10651 recursion. The 'Parent == null' condition isn't sufficient for
10653 (FlowBranching.AddBreakOrigin): Likewise.
10654 (FlowBranching.AddContinueOrigin): Likewise.
10655 (FlowBranching.AddReturnOrigin): Likewise.
10656 (FlowBranching.StealFinallyClauses): Likewise.
10657 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10658 (FlowBranching.CheckOutParameters): Likewise.
10659 (FlowBranchingToplevel): Terminate all the above recursions here.
10660 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10661 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10663 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10665 (FlowBranchingToplevel): New. Empty for now.
10666 (FlowBranching.MergeTopBlock): Update.
10667 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10668 branching for the anonymous delegate.
10669 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10671 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10672 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10673 information at the start of the merge. Reorganize.
10675 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10677 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10679 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10681 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10682 to newly introduced ctor.
10684 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10685 message to one place.
10686 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10689 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10691 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10693 * ecore.cs (Expression.ResolveAsConstant): Updated.
10695 * statement.cs (ResolveMeta): Updated.
10697 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10699 * cs-parser.jay: __arglist cannot be used in initializer.
10701 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10704 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10707 2006-05-05 Raja R Harinath <rharinath@novell.com>
10709 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10710 (LabeledStatement): Add 'name' parameter.
10711 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10712 (Block.AddLabel): Update to changes.
10713 * cs-parser.jay (labeled_statement): Likewise.
10715 * flowanalysis.cs (BranchingType.Labeled): New.
10716 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10717 (FlowBranchingLabeled): New. Does nothing for now, but will
10718 eventually handle 'goto' flows.
10719 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10720 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10721 that's terminated ...
10722 (Block.Resolve): ... here.
10724 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10725 (UsageVector.MergeFinallyOrigins): Likewise.
10726 (FlowBranching.InTryOrCatch): Likewise.
10727 (FlowBranching.AddFinallyVector): Likewise.
10728 (FlowBranchingException): Update to changes.
10731 * statement.cs (Return.Resolve): Move error checking to ...
10732 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10733 (FlowBranchingException): Handle return origins like break and
10735 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10737 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10740 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10743 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10746 * class.cs (MethodData.Define): Do public accessor check only when method
10747 implements an interface.
10749 2006-05-04 Raja R Harinath <rharinath@novell.com>
10751 Remove special handling of 'break'
10752 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10753 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10754 (UsageVector.Break): Remove.
10755 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10757 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10759 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10760 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10762 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10765 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10766 be the interface member.
10768 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10771 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10772 for emitting small (int) values.
10774 2006-05-03 Raja R Harinath <rharinath@novell.com>
10777 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10778 control-flow passes through the 'finally' after merging-in all the
10779 control-flows from 'try' and the 'catch' clauses.
10781 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10782 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10783 always true at the only non-recursive entry point.
10784 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10785 FlowBranchingBreakable.
10786 (FlowBranchingLoop): Remove.
10787 * statement.cs (Return.DoResolve): Update to changes.
10790 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10791 (FlowBranching.CreateBranching): Handle it: create a
10792 FlowBranchingContinuable.
10793 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10794 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10795 except that it handles the 'continue' command.
10796 (FlowBranching.UsageVector.MergeOrigins): Rename from
10798 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10799 except that it overrides AddContinueOrigin.
10800 (FlowBranchingException): Override AddContinueOrigin, similar to
10802 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10803 Create a new branching around the embedded statement.
10804 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10805 control flow after the embedded statement.
10806 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10808 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10809 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10810 FlowBranchingBreakable.
10811 (FlowBranchingSwitch): Remove.
10814 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10815 error reporting to ...
10816 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10817 Rename from 'AddBreakVector'. Add new location argument. Return
10818 a bool indicating whether the 'break' crosses an unwind-protect.
10819 (FlowBranchingException.AddBreakOrigin): Add.
10820 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10821 flowbranching after updating with the effects of the 'finally'
10823 (FlowBranchingBreakable): New common base class for
10824 FlowBranchingLoop and FlowBranchingSwitch.
10826 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10827 embedded statement.
10828 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10830 2006-05-02 Raja R Harinath <rharinath@novell.com>
10832 * statement.cs (Do.Resolve): If the loop is infinite, set the
10834 (While.Resolve, For.Resolve): Set a barrier after the embedded
10835 statement. There's no direct control flow that goes from the end
10836 of the embedded statement to the end of the loop.
10837 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10838 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10839 above ensure that the reachability is correctly computed.
10841 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10842 (UsageVector.MergeBreakOrigins): If the current path is
10843 unreachable, treat it as if all parameters/locals are initialized.
10844 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10845 infinite loops before merging-in break origins.
10847 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10848 (Reachability.Reachable): Split part into ...
10849 (Reachability.Unreachable): ... this. Simplify.
10850 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10852 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10853 (Reachability.SetThrowsSometimes): Likewise.
10854 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10855 TriState.Always, use corresponding property.
10856 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10857 (Block.Resolve): Likewise. Remove some redundant checks.
10859 2006-05-02 Raja R Harinath <harinath@gmail.com>
10861 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10862 (Reachability.Meet): Don't bother checking AlwaysThrows --
10863 barrier is always set.
10864 (FlowBranchingBlock.Merge): Likewise.
10866 2006-05-01 Raja R Harinath <harinath@gmail.com>
10868 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10869 checks for unreachable.
10871 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10874 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10876 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10877 whether field is really assigned.
10879 2006-04-30 Raja R Harinath <harinath@gmail.com>
10881 * flowanalysis.cs (Reachability): Make 4-argument constructor
10883 (Reachability.Meet): Rename from 'And'. Remove static variant.
10884 (Reachability.Always): Rename from the highly misleading
10885 'Reachability.Never'.
10886 (FlowBranching.Merge): Update to changes. Mark an impossible
10887 situation with a 'throw'.
10888 (*): Update to changes.
10890 2006-04-29 Raja R Harinath <harinath@gmail.com>
10892 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10893 Remove 'Undefined'.
10894 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10895 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10896 (*): Update to changes.
10897 * statement.cs: Update to changes.
10899 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10902 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10904 2006-04-28 Raja R Harinath <harinath@gmail.com>
10906 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10909 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10910 argument to two arguments: an usage-vector and a bool. Move call
10911 to FlowBranching.Merge () ...
10912 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10914 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10915 handling of loop and switch reachability to ...
10916 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10918 2006-04-27 Raja R Harinath <harinath@gmail.com>
10920 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10921 handling to FlowBranchingLoop.InLoop.
10922 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10924 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10927 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10928 anonymous method is allowed from AnonymousContainer here.
10930 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10932 2006-04-24 Raja R Harinath <rharinath@novell.com>
10935 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10937 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10940 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10941 (DoubleConstant.Reduce): Ditto.
10943 2006-04-23 Raja R Harinath <rharinath@novell.com>
10945 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10946 Remove 'lvalue_right_side' argument. Move parts to ...
10947 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10948 (LocalVariable.DoResolveLValue): ... these.
10950 2006-04-21 Raja R Harinath <rharinath@novell.com>
10953 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10954 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10955 (LocalVariableReference.DoResolveBase): Use it to implement new
10957 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10958 (Argument.Resolve): Simplify. Move CS1510 check ...
10959 * ecore.cs (Expression.ResolveLValue): ... here.
10960 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10961 (PropertyExpr.DoResolveLValue): Likewise.
10962 (FieldExpr.Report_AssignToReadonly): Likewise.
10963 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10964 LValueMemberAccess or LValueMemberOutAccess on instance depending
10966 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10967 DoResolve as appropriate.
10969 2006-04-20 Raja R Harinath <rharinath@novell.com>
10972 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10973 implicit conversions on 'out' and 'ref' arguments.
10975 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10976 improve clarity. Remove dead code.
10979 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10980 (Catch.Resolve): Resolve VarBlock if it exists.
10982 2006-04-19 Miguel de Icaza <miguel@novell.com>
10984 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10985 twice, this was some residual code, the enumerator was emitted
10986 properly in the two branche of if later.
10988 2006-04-19 Raja R Harinath <rharinath@novell.com>
10990 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10991 cast is never an lvalue.
10992 (Cast.DoResolve, Cast.ResolveRest): Combine.
10993 (Argument.Emit): Simplify slightly. Move 'Expr is
10994 IMemoryLocation' check ...
10995 (Argument.Resolve): ... here.
10996 (Argument.Error_LValueRequired): Remove. Inline into only user.
10998 Simplifications. Fix cs0191-2.cs
10999 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
11000 CS1649 and CS1651 to ...
11001 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
11002 the actual selection of the error code and message to a lookup
11003 table. Add a dummy return value to simplify callsites.
11004 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
11005 readonly fields of other instances of the same type. Move CS0197
11007 * expression.cs (Argument.Resolve): ... here. Simplify code.
11008 Ensure that ec.InRefOutArgumentResolving is only set during LValue
11009 resolution of an out or ref argument. The code simplification
11010 above uses this invariant.
11012 2006-04-18 Raja R Harinath <rharinath@novell.com>
11014 Possibly fix #77752. Fix cs1690-[4-7].cs.
11015 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
11016 CheckMarshallByRefAccess. Drop parameter.
11017 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
11019 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
11020 InstanceExpression.
11021 * report.cs (AllWarnings): Add CS1690.
11022 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
11023 for ref access too.
11024 (LocalVariableReference.DoResolveBase): Update.
11026 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11028 * class.cs (MethodOrOperator): Moved common parts from method class.
11029 detect obsolete attributes.
11030 (Method.Define): Simplified as it reuses code from base.
11031 (Constructor.ValidAttributeTargets): Fixed issue found during
11033 (Destructor.ValidAttributeTargets): Fixed issue found during
11035 (Operator): Finished refactoring set off by #78020. Operator class is now
11036 ordinary method class.
11038 * anonymous.cs: Updated.
11040 * decl.cs (DeclSpace): Add IsGeneric
11042 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11044 * class.cs (Constructor.Emit): Don't emit the attributes twice.
11046 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11048 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
11049 detect obsolete attributes.
11050 (Method.CreateEmitContext): Moved to MethodOrOperator.
11052 2006-04-09 Marek Safar <marek.safar@seznam.cz>
11055 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
11056 customized exception to make crash detection easier.
11057 (MethodOrOperator): Started to work on new base class for methods and
11059 (Method): Derives from MethodOrOperator.
11060 (Constructor.Emit): Emits its own attributes.
11061 (AbstractPropertyEventMethod.Emit): Ditto.
11062 (Operator): Derives from MethodOrOperator, will refactor fully in extra
11064 (Operator.Emit): It's temporary more tricky than should be.
11066 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
11068 * report.cs (InternalErrorException): Add ctor with inner exception.
11070 2006-04-08 Marek Safar <marek.safar@seznam.cz>
11073 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
11076 2006-04-07 Marek Safar <marek.safar@seznam.cz>
11079 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
11082 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11084 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
11085 attribute is present and Guid not.
11086 (Interface.ApplyAttributeBuilder): Ditto.
11088 * attribute.cs: Add error message.
11090 2006-04-06 Marek Safar <marek.safar@seznam.cz>
11094 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
11095 sources (it's composite) so hold them in extra array as they are used in
11096 Emit phase only. It worked in the previous versions by mistake.
11097 (Attribute.Emit): Emit attribute for more owners when exist.
11099 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
11100 it has now different behaviour.
11102 2006-04-04 Marek Safar <marek.safar@seznam.cz>
11104 * constant.cs (Constant.IsDefaultInitializer): New method.
11106 * class.cs: Updated.
11108 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
11109 re-initialize default values. It saves KBs almost for every assembly.
11110 Thanks Zoltan for the idea.
11111 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
11112 (ArrayCreation.DoResolve): Resolve only once.
11113 (ArrayCreation.Emit): Emit static initializer only when it is faster.
11114 (ArrayCreation.GetAttributableValue): Cope with optimized values.
11116 2006-04-03 Zoltan Varga <vargaz@gmail.com>
11118 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
11121 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11123 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
11124 in an embedded statement too.
11126 2006-04-01 Raja R Harinath <rharinath@novell.com>
11129 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
11131 2006-04-01 Marek Safar <marek.safar@seznam.cz>
11135 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
11138 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
11140 2006-03-31 Marek Safar <marek.safar@seznam.cz>
11142 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
11145 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
11146 LocalTemporary change.
11148 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
11150 (ClassOrStruct.DefineFieldInitializers): Implemented static field
11151 initializers optimization.
11152 (ClassOrStruct.TypeAttr): Moved from modifiers.
11153 (Constructor.CheckBase): Don't crash when static ctor has parameters.
11154 (FieldBase.ResolveInitializer): Resolves initializer.
11155 (FieldBase.HasDefaultInitializer): New property.
11157 * cs-parser.jay: Removed message.
11159 * expression.cs (CompilerGeneratedThis): New specialization.
11161 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
11163 2006-03-28 Marek Safar <marek.safar@seznam.cz>
11165 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
11167 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11169 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
11170 be now EnumConstants only.
11172 2006-03-27 Marek Safar <marek.safar@seznam.cz>
11174 * attribute.cs, driver.cs: Reset more caches.
11176 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11178 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
11180 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11182 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
11183 for easier reuse. Updated all overrides.
11184 (IntegralConstant): New base class for all integral constants.
11185 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
11186 of the constant range, report custom error.
11187 (UIntConstant.Reduce): Fixed uint conversion.
11189 * ecore.cs, literal.cs: Reduce updates.
11191 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11195 * class.cs (Constructor.Define): Removed extra if for default ctors.
11196 A patch from Atsushi Enomoto.
11198 2006-03-26 Marek Safar <marek.safar@seznam.cz>
11200 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
11201 GetAttributableValue.
11203 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
11206 * convert.cs (ImplicitConversionRequired): Error message moved to
11209 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
11210 automatic implicit conversion of an output value.
11211 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11213 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11215 (TypeOf.GetAttributableValue): Add extra handling for object type.
11217 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11218 special error message.
11220 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11222 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11224 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11225 compatible with MS runtime.
11227 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11229 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11230 attribute arguments here.
11232 * class.cs (Indexer.Define): The check was moved to attribute class.
11234 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11236 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11237 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11240 2006-03-22 Raja R Harinath <rharinath@novell.com>
11242 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11243 mcs to keep code differences small.
11244 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11245 * typemanager.cs (parameter_default_value_attribute_type): New.
11246 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11249 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11251 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11253 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11255 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11257 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11260 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11262 * doc-bootstrap.cs : fix build.
11264 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11266 * expression.cs (StringConcat.Append): Issue a warning when empty string
11267 is going to append.
11269 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11271 * assign.cs (CompoundAssign.ResolveSource): Removed.
11273 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11276 * class.cs (TypeContainer.FindMethods): Removed.
11277 (TypeContainer.CheckMemberUsage): Made static.
11279 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11281 * constant.cs (CheckRange): Removed unused type argument.
11282 (CheckUnsigned): Removed unused type argument.
11284 * cs-parser.jay: Updated after MemberAccess clean up.
11285 Uses Length for empty string test.
11287 * cs-tokenizer.cs: Uses Length for empty string test.
11288 (IsCastToken): Made static.
11289 (is_hex): Made static.
11290 (real_type_suffix): Made static.
11292 * decl.cs (SetupCache): Made static.
11293 (OnGenerateDocComment): Removed unused ds argument.
11295 * delegate.cs (VerifyDelegate): Removed unused argument.
11297 * doc.cs: Uses Length for empty string test.
11299 * driver.cs: Uses Length for empty string test.
11301 * enum.cs (IsValidEnumType): Made static
11303 * expression.cs (EnumLiftUp): Removed unused argument.
11304 (ResolveMethodGroup): Ditto.
11305 (BetterConversion): Ditto.
11306 (GetVarargsTypes): Ditto.
11307 (UpdateIndices): Ditto.
11308 (ValidateInitializers): Ditto.
11309 (MemberAccess.ctor): Ditto.
11310 (GetIndexersForType): Ditto.
11312 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11314 * iterators.cs: Updated after MemberAccess clean up.
11316 * location.cs: Uses Length for empty string test.
11318 * namespace.cs: Uses Length for empty string test.
11320 * report.cs (CheckWarningCode): Made static.
11322 * statement.cs (LabeledStatement): Removed unused argument.
11324 * typemanager.cs (FilterNone): Removed.
11326 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11328 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11331 * class.cs: Updated.
11333 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11335 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11337 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11341 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11342 reporting, it's more tricky than I thought.
11344 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11348 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11350 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11351 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11352 Add more error reporting; Fixed issue with params.
11354 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11356 * cs-parser.jay: AnonymousMethod requires host container.
11358 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11360 2006-03-18 Raja R Harinath <harinath@gmail.com>
11362 * class.cs: Change 'TypeContainer ds' constructor argument to
11363 'DeclSpace parent'. Some classes were missed below due to
11364 different naming convention.
11366 * class.cs (MemberCore.Parent): Delete. This makes the
11367 ParentContainer changes below enforceable by the compiler.
11369 Treat pointers to enclosing declaration space as 'DeclSpace', not
11371 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11372 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11374 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11376 (Block.AddThisVariable): Likewise.
11377 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11378 (AbstractPropertyEventMethod.Emit): Likewise.
11379 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11380 (GetMethod.Define, SetMethod.Define): Likewise.
11381 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11382 (DelegateMethod.EmitMethod): Likewise.
11384 Fix regression test-partial-13.cs.
11385 Rationalize use of PartialContainer. Ensure that the partial
11386 class semantics can be tied to type-correctness, i.e., any
11387 violation will cause a compile error.
11388 * class.cs, const.cs: Access all fields that belong to class
11389 TypeContainer via ParentContainer. Arguments of EmitContexts and
11390 Resolve()-like functions still use 'Parent'.
11392 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11393 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11394 (PropertyMethod.CheckModifiers): Remove unused argument.
11395 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11398 2006-03-17 Raja R Harinath <harinath@gmail.com>
11400 Make semantics of PartialContainer simpler.
11401 * decl.cs (DeclSpace.IsPartial): Remove.
11402 * class.cs (TypeContainer.IsPartial): Likewise.
11403 (TypeContainer..ctor): Set PartialContainer to point to self.
11404 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11405 (TypeContainer.FindNestedType): Likewise.
11406 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11408 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11410 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11412 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11414 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11417 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11419 * class.cs (Operator.Define): An error for base conversion was not
11420 reported correctly.
11422 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11424 * iterator.cs : yield break is allowed in try statement which has
11425 catch clauses. Fixed bug #77767.
11427 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11429 A fix for #77593, #77574.
11431 * class.cs (MethodCore.CheckBase): Another if for operator.
11433 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11435 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11438 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11439 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11442 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11445 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11446 Updated after another emitcontext usage was clean up. It should help us to
11447 synchronize with gmcs easier.
11449 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11453 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11454 (Event.Define): ditto
11455 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11457 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11458 Removed redundant code and set NewSlot for Invoke method too.
11460 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11461 (Parameters.MergeGenerated): New method. Use this method when you merge
11462 compiler generated argument with user arguments.
11464 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11466 * attribute.cs (ResolveAsTypeTerminal): Removed.
11468 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11469 specialization for predefined types; 30% speed up.
11470 Finally placed obsolete check to right place.
11471 (Expression.ResolveType): Removed.
11473 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11474 Updated after ResolveType was removed.
11476 * expression.cs (Cast.ctor): Check void cast.
11477 (Binary.ResolveAsTypeTerminal): Is never type.
11478 (Conditional.ResolveAsTypeTerminal): Is never type.
11480 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11482 2006-03-01 Raja R Harinath <rharinath@novell.com>
11485 * expression.cs (ParameterReference.DoResolveBase): Change return
11487 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11491 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11494 * typemanager.cs (GetFullNameSignature): Don't nullref on
11495 protected accessors.
11497 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11499 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11500 these two separated members to simplify the code.
11501 (Attribute.Resolve): Refactored to use new fields and methods.
11502 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11503 implemented obsolete attribute checking.
11504 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11505 implemented obsolete checking again. It look line never ending quest ;-)
11506 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11508 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11510 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11512 *class.cs (Property.Define): Add RegisterProperty call.
11514 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11515 argument groups (only 2).
11517 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11518 encoding expression to arguments.
11519 (Expression.ExprClassToResolveFlags): Just turned to property.
11521 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11522 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11523 optimized as well as implemented support for zero-length attributes.
11525 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11526 Add caching of PropertyInfo's.
11528 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11530 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11531 error multiple times.
11533 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11535 New partial class implementation.
11536 A fix for #77027, #77029, #77403
11538 * attribute.cs (Attributable): Made attributes protected.
11540 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11541 the replacements of ClassPart and PartialContainer.
11542 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11543 (TypeContainer.AddInterface): Ditto.
11544 (TypeContainer.AddPartial): The main method for partial classes. It checks
11545 for errors and merges ModFlags and attributes. At the end class is added to
11546 partial_parts list.
11547 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11549 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11550 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11551 from the rest of partial classes.
11552 (TypeContainer.GetClassBases): Simplified.
11553 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11555 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11556 (TypeContainer.HasExplicitLayout): Uses Flags now.
11557 (PartialContainer): Removed.
11558 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11559 (StaticClass): Was merged with Class.
11560 (Class.GetClassBases): class and static class bases are verified here.
11561 (Class.TypeAttr): Added static attributes when class is static.
11562 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11563 (MemberBase): In some cases we need to call parent container for partial
11564 class. It should be eliminated but it's not easy now.
11566 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11568 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11569 partial classed to accumulate class comments.
11570 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11572 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11574 * driver.cs (MainDriver): Tree.GetDecl was removed.
11576 * modifiers.cs (Modifiers): Add partial modifier.
11578 * tree.cs (Tree.decl): Removed.
11579 (RootTypes): Started to use this class more often for root types
11582 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11586 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11587 external interface does not have an attribute.
11589 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11591 Another prerequisites for new partial classs implementation.
11593 * attribute.cs (Attribute.Equal): Implemented.
11594 (Attribute.Emit): Changed as attributes can be applied more than twice.
11595 (Attributes.Emit): Check for duplicate attributes here.
11597 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11598 as a parameter, clean-up.
11600 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11604 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11605 contains obsolete attribute check which can in some cases look for base
11606 type of current class which is not initialized yet.
11607 (TypeContainer.BaseType): Replacement of ptype.
11609 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11611 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11613 First of prerequisites for new partial classs implemention.
11615 * attribute.cs (Attributable): Extended by ResolveContext;
11616 Attributes finally have correct context for resolving in all cases.
11617 (AttachTo): Attribute owner is assigned here.
11619 * codegen.cs (IResolveContext): Introduce new interface to hold
11620 all information needed in resolving phase.
11621 (EmitContext): Implements IResolveContext; more clean-up needed here.
11623 * decl.cs (MemberCore): Implemented IResolveContext.
11625 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11626 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11627 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11628 Refactored to use new IResolveContext instead of EmitContext; cleanup
11630 2006-02-06 Miguel de Icaza <miguel@novell.com>
11632 * codegen.cs (EmitScopeInitFromBlock): check here the
11633 capture_context, there is no need to make two calls to the
11636 * anonymous.cs: Add some debugging messages that might help me
11637 track other instances of this problem in the future (the
11638 regression of test 467).
11640 * cs-parser.jay: track the variable block, as we need to initalize
11641 any captured variables declared in this block for the "catch"
11642 portion of the "Try" statement.
11644 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11645 scope initialization for captured variables.
11647 Also, move the emit for the variables after the block location has
11650 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11652 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11654 2006-02-02 Miguel de Icaza <miguel@novell.com>
11656 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11657 commit yesterday, the initialization for the roots is necessary.
11658 What is not necessary is the scope activation.
11660 2006-02-02 Raja R Harinath <rharinath@novell.com>
11662 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11663 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11665 (Argument.Resolve): Remove CS0206 checks.
11667 2006-02-01 Miguel de Icaza <miguel@novell.com>
11669 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11670 scopes for all the roots, the scopes will now be emitted when the
11671 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11673 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11674 code. This reduces a lot of existing cruft.
11676 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11677 that the ScopeInfo is generated as we enter the scope, not at the
11678 time of use, which is what we used to do before.
11680 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11681 every time a Block is about to be emitted if we have a
11684 2006-02-01 Raja R Harinath <rharinath@novell.com>
11686 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11688 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11690 * typemanager.cs (cons_param_array_attribute): Make private.
11691 (Reset): Set it to null.
11692 (InitCoreHelpers): Don't initialize it.
11693 (ConsParamArrayAttribute): New. Initialize it as needed.
11694 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11696 2006-01-31 Miguel de Icaza <miguel@novell.com>
11698 * expression.cs: There might be errors reported during the
11699 selection of applicable methods. If there are errors, do not
11700 continue execution as it will lead the compiler to crash.
11702 2006-01-30 Miguel de Icaza <miguel@novell.com>
11704 * expression.cs: Member access is not allowed on anonymous
11705 methods. Fixes #77402.
11707 2006-01-30 Raja R Harinath <rharinath@novell.com>
11710 * cs-parser.jay (VariableDeclaration): Don't set
11711 current_array_type to null.
11712 (field_declaration, event_declaration, declaration_statement):
11713 Set it to null here.
11715 2006-01-28 Raja R Harinath <harinath@gmail.com>
11717 * typemanager.cs (GenericParameterPosition): New.
11720 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11722 * doc.cs : To process "include" elements, first we should create
11723 another list than XmlNodeList, because it could result in node
11724 removal, which could result in that the XmlNodeList gives up
11725 yielding next node.
11727 (Also made code identical to gmcs again.)
11729 2006-01-25 Miguel de Icaza <miguel@novell.com>
11731 * ecore.cs: Introduce an error report that we were not catching
11732 before, if not silent, we must report the error. Gonzalo ran into
11735 2006-01-23 Miguel de Icaza <miguel@novell.com>
11737 A fix for bug: #76957
11739 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11740 ComputeMethodHost before creating the method, this is a new
11743 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11744 that this method references (RegisterScope). The actual scope
11745 where the method is hosted is computed with the ComputeMethodHost
11746 before we create the method.
11748 Moved the Deepest routine here.
11750 (AnonymousContainer.ComputeMethodHost): New routine used to
11751 compute the proper ScopeInfo that will host the anonymous method.
11753 (ScopeInfo): Deal with multiple roots. The problem was that we
11754 did not have a unique root where all ScopeInfos could be hanged
11755 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11758 Remove AdjustMethodScope which is now computed at the end. Remove
11759 LinkScope which did a partial link, instead link all ScopeInfos
11760 before code generation from the new "LinkScopes" routine.
11762 Simplify all the Add* routines as they no longer need to maintain
11763 the tree, they just need to record that they are using variables
11766 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11767 routines to produce the forest of ScopeInfo trees.
11769 * class.cs (TypeContainer.AppendMethod): This is just like
11770 AddMethod, but ensures that an interface implementation method
11771 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11772 methods, but at the end.
11774 We use this functionality to ensure that the generated MoveNext
11775 method in the iterator class is resolved/emitted before the
11776 enumerator methods created.
11778 This is required because the MoveNext method computes the right
11779 ScopeInfo for the method. And the other methods will eventually
11780 need to resolve and fetch information computed from the anonymous
11783 2006-01-21 Raja R Harinath <harinath@gmail.com>
11784 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11786 Fix rest of #76995.
11787 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11788 the 'aliases' hash.
11789 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11790 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11792 2006-01-18 Raja R Harinath <rharinath@novell.com>
11794 Fix #76656, cs0231-2.cs.
11795 * cs-parser.jay (formal_parameter_list): Make error case catch
11797 (parenthesized_expression_0): Add CS1026 check.
11798 (invocation_expression): Remove unused { $$ = lexer.Location }.
11800 2006-01-17 Raja R Harinath <rharinath@novell.com>
11803 * cs-parser.jay (statement_expression): Don't list out the
11804 individual statement-expressions. Convert syntax error into
11807 2006-01-16 Raja R Harinath <rharinath@novell.com>
11810 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11811 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11812 CheckIntermediateModification.
11813 (FieldExpr.DoResolve): Add new two-argument version that
11814 allows us to resolve the InstanceExpression as an lvalue.
11815 The one-argument variant is now just a wrapper.
11816 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11817 Resolve the lhs as an lvalue if the it has a value type.
11818 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11819 from Assign.DoResolve.
11820 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11821 resolved as an lvalue.
11822 (PropertyExpr.DoResolve): Update.
11823 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11824 has a value type. Move CS1612 check here from
11825 CheckIntermediateModification.
11826 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11827 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11828 'right_side' of a ResolveLValue on an 'out' argument.
11829 (EmptyExpression.LValueMemberAccess): New. Used as the
11830 'right_side' of a propagated ResolveLValue on a value type.
11831 (LocalVariableReference.DoResolveBase): Recognize
11832 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11834 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11835 EmptyExpression.Null.
11837 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11839 * typemanager.cs : added IsGenericParameter(). In mcs it always
11841 * doc.cs : for generic parameters, use GenericParameterPosition,
11844 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11846 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11848 2006-01-12 Miguel de Icaza <miguel@novell.com>
11850 This fixes the problem where we used ldfld instead of ldflda to
11851 load the "THIS" pointer on captured parameters, when THIS is a
11852 value type. See bug #77205.
11854 * iterators.cs (CapturedThisReference.Emit): Pass false to
11855 EmitThis (we do not need the address).
11857 * codegen.cs (EmitThis): it needs to know whether we need the
11858 address of `this' or not. This is used by value types.
11860 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11861 every other call passes false.
11863 2006-01-12 Raja R Harinath <rharinath@novell.com>
11866 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11868 * expression.cs (Invocation.OverloadResolve): Update.
11869 (Invocation.DoResolve): Avoid double resolution of invocation.
11871 2006-01-11 Raja R Harinath <rharinath@novell.com>
11874 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11875 unary negation of floating point types as 0-expr; negation cannot
11876 overflow in floating point types.
11879 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11880 on operands of 'void' type.
11883 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11884 and ExclusiveOr for boolean constants too.
11886 2006-01-09 Raja R Harinath <rharinath@novell.com>
11889 * expression.cs (Invocation.OverloadResolve): Replace reflected
11890 override methods with their base virtual methods, rather than
11891 skipping over them.
11892 * typemanager.cs (TypeManager.GetOverride): New.
11894 2006-01-05 Jb Evain <jbevain@gmail.com>
11896 * class.cs (Property.Define, Indexer.Define): do not tag the
11897 properties as SpecialName | RTSpecialName.
11899 2006-01-04 Miguel de Icaza <miguel@novell.com>
11901 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11902 doing a low-level comparission of parameter types. It was lacking
11903 a check for __argslist.
11905 2005-12-30 Miguel de Icaza <miguel@novell.com>
11907 * expression.cs (ParameterReference.DoResolveBase): Allow
11908 reference parameters if they are local to this block.
11910 This allows the ref and out parameters of a delegate to be used in
11911 an anonymous method, for example:
11913 delegate void set (out int x);
11915 set s = delegate (out int x){
11919 This is used by functionality introduced late in the C# language.
11921 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11922 method that take ref and out parameters.
11924 Fixes #77119 which was a late change in the spec.
11926 2005-12-23 Miguel de Icaza <miguel@novell.com>
11928 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11929 parent if its the same scope. Fixes #77060.
11931 2005-12-21 Miguel de Icaza <miguel@novell.com>
11933 * driver.cs: Report the case of no source files and no -out:
11936 2005-12-20 Raja R Harinath <rharinath@novell.com>
11939 * expression.cs (ComposedCast.GetSignatureForError): Define.
11941 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11945 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11946 ListDictionary, to contain the ExternAliasEntry entries (in
11947 addition to the NamespaceEntry.aliases hashtable). This field is
11948 shared between the original entry and its doppelganger (bodyless
11950 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11951 extern_aliases field.
11952 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11953 lookup in extern_aliases.
11955 2005-12-16 Raja R Harinath <rharinath@novell.com>
11958 * class.cs (TypeContainer.Mark_HasEquals): New.
11959 (TypeContainer.Mark_HasGetHashCode): New.
11960 (ClassPart): Override them.
11961 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11964 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11965 'parent' argument to the base constructor.
11967 Remove all mention of TypeContainer from decl.cs.
11968 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11969 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11970 (DeclSpace.DeclSpace): Likewise.
11971 (DeclSpace.DefineMembers): Remove unused argument.
11972 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11973 debugging check -- we don't care if the debug code throws an
11974 InvalidCastException instead of an InternalErrorException.
11975 * class.cs (TypeContainer.DefineMembers): Update to changes.
11976 (TypeContainer.DoDefineMembers): Likewise.
11977 (TypeContainer.GetMethods): Likewise.
11978 (PropertyMember.Define): Likewise.
11979 (MemberBase.Parent): New property that forwards to
11980 MemberCore.Parent, but ensures that we get a TypeContainer.
11981 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11982 (RootContext.PopulateTypes): Likewise. Remove special case code
11983 for !RootContext.StdLib: DefineMembers is idempotent.
11985 2005-12-14 Miguel de Icaza <miguel@novell.com>
11987 * convert.cs (ExplicitConversionCore): Check the return value from
11988 ExplicitConversionCore which can return null on failure. Fixes #76914
11990 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11992 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11994 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11996 * doc.cs : The search for referenced namespace was insufficient to
11997 get global one as it used to do. Fixed bug #76965.
11999 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
12001 * doc.cs : check name in cref in the last phase that whether it is
12004 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12006 * cs-tokenizer.cs : reverted the latest change: it somehow broke
12009 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12011 * doc.cs : so it turned out that we cannot skip override check for
12012 interface members. Fixed bug #76954.
12014 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
12016 * cs-tokenizer.cs : fixed bug #75984:
12017 - #warning and #error should not be handled when the source line
12019 - #line is not checked strictly when the source line is disabled.
12020 - #define and #undef is on the other hand checked strictly at any
12023 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
12025 * cs-tokenizer.cs : missing Location (actually, filename) in one of
12028 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12030 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
12032 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
12033 event initializers.
12034 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
12035 (FieldBase.Initializer): Initializer is now optional.
12036 (EventField.Define): Only event field can have initializer.
12038 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
12040 * const.cs (Const): Reuse initializer.
12042 * cs-parser.jay: Updated after FieldBase changes.
12043 Added current_array_type to simplify array initializers.
12045 * ecore.cs (NullCast.IsDefaultValue): Implemented.
12047 * expression.cs, iterators.cs: Updated.
12049 * namespace.cs (NamespaceEntry): Made UsingFound private.
12051 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12053 * parameterCollection.cs: Obsolete, removed.
12054 * parser.cs: Obsolete, removed.
12056 2005-12-05 Marek Safar <marek.safar@seznam.cz>
12059 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
12061 * enum.cs (Enum.Define): Set obsolete context here.
12063 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12066 - FindDocumentedMember() now expects 1) paramList as null
12067 when "we don't have to check the number of parameters" and
12068 2) Type.EmptyTypes when "there is no arguments".
12069 - Introduced FoundMember struct to hold the exact type which was
12070 used to find the documented member (the above change broke
12071 test-xml-044; it might be better just to use DeclaringType than
12072 what MS does, like this change does, but it depends on usage.)
12074 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
12076 * doc.cs : documented member might be from DeclaringType for nested
12077 types. Fixed bug #76782.
12079 2005-12-03 Ben Maurer <bmaurer@ximian.com>
12081 * anonymous.cs: Have the param code handle leaving copies on the
12082 stack etc. Allows anonymous params to take part in the assignment
12083 code (++, +=, etc). Fixes bug #76550
12085 * expression.cs: Handle the prepare_for_load/leave_copy by passing
12086 it down to the anon code.
12088 * iterators.cs: Use dummy var here
12090 * codegen.cs: Handle new vars
12092 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12095 * class.cs (MethodData.Define): Set proper Obsolete context.
12097 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
12099 (FieldExpr.DoResolve): Ditto.
12101 2005-12-01 Marek Safar <marek.safar@seznam.cz>
12104 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
12105 parent is not obsolete.
12107 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
12109 * doc.cs : (FindDocumentedMember) find parameterless members first
12110 and get CS0419 in the early stage. Fixed first case of bug #76727.
12112 2005-11-30 Marek Safar <marek.safar@seznam.cz>
12115 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
12116 no error was reported.
12118 *expression.cs (Binary.DoResolve): left can be null.
12120 2005-11-22 Marek Safar <marek.safar@seznam.cz>
12123 * class.cs (MethodData.Emit): Parameters should be labeled first.
12125 2005-11-21 Marek Safar <marek.safar@seznam.cz>
12128 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
12130 2005-11-18 Marek Safar <marek.safar@seznam.cz>
12132 * attribute.cs (AreParametersCompliant): Moved to Parameter.
12134 * class.cs (MethodCore): Parameter clean up.
12135 (IMethodData): Added ParameterInfo.
12136 (MethodData): Parameter clean up.
12137 (Indexer.Define): Parameter clean up.
12149 * typemanager.cs: Parameter clean up.
12151 * delegate.cs (Define): Get rid of duplicated code.
12153 * expression.cs (ParameterReference): Removed useless parameters
12155 (Invocation): Ditto.
12157 * parameter.cs (ParamsParameter): New class, params specialization.
12158 (ArglistParameter): Attemp to separate arglist.
12159 (Parameter): Refactored to be reusable and faster.
12160 (Parameter.Modifier): Made understandable.
12161 (Parameters): Changed to be used as a class for `this' assembly
12162 parameters. Refactored to use new specialized classes.
12164 * support.cs (ParameterData): Added Types property.
12165 (InternalParameters): Deleted.
12167 2005-08-20 Martin Baulig <martin@ximian.com>
12169 Merging this patch from GMCS to fix #75867.
12171 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12172 scope if we don't already have it.
12174 2005-11-17 Martin Baulig <martin@ximian.com>
12177 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
12178 inherit the scope from our parent. Fixes #76653.
12180 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12182 * doc.cs : the previous patch does not actually fix the bug.
12183 PropertyInfo override check is now implemented and really fixed it.
12184 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
12186 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12188 * doc.cs : apply "override filter" also to properties.
12191 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
12193 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
12194 no need to check overrides. For classes, omit those results from
12195 interfaces since they must exist in the class. Fixed bug #76726.
12197 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12199 * typemanager.cs : (GetFullNameSignature) differentiate indexers
12200 with different parameters. Fixed the second problem in #76685.
12202 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12204 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
12205 get expected 'protected' access in CheckValidFamilyAccess()).
12208 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
12210 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12211 Fixed bug #76705. CS1569 was incorrectly commented out.
12213 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12215 * doc.cs : use Invocation.IsOverride() to do real override check.
12216 * expression.cs : made Invocation.IsOverride() internal.
12218 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12220 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12221 TypeBuilder.FindMembers() and filter overriden base members out.
12224 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12226 * doc.cs : ref/out parameters are represented as '@' (instead of
12227 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12229 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12231 * doc.cs : when there was no '.' in cref to methods in doc comment,
12232 then parameters were missing in the output. Fixed bug #76691.
12234 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12236 * driver.cs : don't output docs when there is an error.
12239 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12242 Now it should detect indexers. Fixed primary concern in bug #76685.
12243 Fixed CS0419 message to not show the identical member signature in
12246 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12248 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12249 instead of Type.FindMembers() since it does not handle events.
12252 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12254 * codegen.cs: Fixed typo (speficied -> specified).
12256 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12259 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12261 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12263 * attribute.cs: Changed error message.
12265 * cs-tokenizer.cs: One more check.
12267 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12269 * statement.cs (Block.Resolve): Ignore empty statement.
12271 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12273 * report.cs: Made error/warning methods more strict to avoid
12276 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12277 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12278 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12279 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12281 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12283 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12284 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12286 * class.cs (TypeContainer.IsComImport): New property.
12287 (Constructor.Define): Create proper ctor for ComImport types.
12289 * expression.cs (New.CheckComImport): Fixed.
12291 2005-11-07 Miguel de Icaza <miguel@novell.com>
12293 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12294 that a parameter has been captured does not mean that we do not
12295 have to do the rest of the processing. This fixes the second part
12296 of #76592. If there was another anonymous method capturing
12297 values in the past, the Scope would never be set for the second
12298 method that captured the same parameter.
12300 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12301 properly manipulate the stack. Second part of fix for #76592.
12303 * expression.cs (New): Add support for invoking "new" on
12304 interfaces that have been flagged with the ComImport attribute and
12305 the CoClass. Fixes #76637
12307 * statement.cs (Try.DoEmit): When a variable is captured, do not
12308 try to emit the vi.LocalBuilder variable as it has been captured.
12309 Create a temporary variable and store the results on the
12310 FieldBuilder. Fixes #76642
12312 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12314 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12316 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12318 * expression.cs (Binary.DoResolve): Added && optimalization.
12320 * typemanager.cs (AddUserType): Removed useless argument.
12322 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12324 * statement.cs (Block.variables): Uses ListDictionary.
12326 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12329 * class.cs (PartialContainer.EmitType): Customized to emit
12330 security attributes.
12331 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12332 for partial classes.
12334 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12337 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12338 access has to be fixed.
12340 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12342 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12345 * ecore.cs (NullCast.Reduce): Implemented.
12347 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12350 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12352 (Foreach.Resolve): Catch null properly.
12354 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12356 * cs-tokenizer.cs: Warning text fix.
12358 * driver.cs: AllWarningNumbers exposed on public interface.
12360 * report.cs (): Reviewed warning numbers.
12361 (IsValidWarning): Use binary search.
12363 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12365 * driver.cs: Implemeted resource visibility.
12366 (Resources): New class for code sharing between /res: and
12369 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12372 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12375 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12378 * ecore.cs (NullCast): Child is contant only.
12380 * literal.cs (NullLiteral.Reduce): null can be converted to any
12383 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12385 * driver.cs: Use Encoding.Default as default code page instead
12388 2005-10-27 Raja R Harinath <rharinath@novell.com>
12391 * expression.cs (Invocation.Error_InvalidArguments): Handle
12392 __arglist parameters.
12393 (Invocation.VerifyArgumentsCompat): Likewise.
12394 * support.cs (ReflectionParameters.GetSignatureForError): Print
12395 __arglist parameters.
12396 (InternalParamters.GetSignatureForError): Likewise.
12397 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12399 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12401 * attribute.cs (GetPropertyValue): Made public.
12403 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12405 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12407 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12410 * driver.cs: Reflect method name change.
12412 * statement.cs (Try.Resolve): Warn when try has both general
12413 exception handlers.
12415 * typemanager.cs: runtime_compatibility_attr_type new predefined
12418 2005-10-26 Raja R Harinath <harinath@gmail.com>
12421 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12422 treat it as an empty parameter list.
12424 2005-10-26 Raja R Harinath <rharinath@novell.com>
12427 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12428 ResolveAsTypeStep silent.
12429 * statement.cs (Block.AddConstant): Mark block as used.
12430 (Block.ResolveMeta): Avoid piling on error messages
12431 if a constant initializer resolution fails.
12433 2005-10-25 Raja R Harinath <rharinath@novell.com>
12435 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12437 (NamespaceEntry.VerifyAllUsing): New.
12438 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12439 behaviour. Delegates actual resolution of alias to ...
12440 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12441 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12443 * driver.cs (Driver.MainDriver): Update.
12445 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12446 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12448 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12450 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12451 RootNamespace.DefineNamespacesForAll.
12453 2005-10-24 Raja R Harinath <harinath@gmail.com>
12455 * typemanager.cs (assemblies, external_aliases, modules)
12456 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12457 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12458 overhead. Move resposibility ...
12459 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12460 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12462 2005-10-23 Raja R Harinath <harinath@gmail.com>
12464 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12465 cached_namespaces. Improve usage.
12466 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12467 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12468 Move from GlobalRootNamespace and simplify.
12469 (RootNamespace.Global): Make instance variable.
12470 (RootNamespace.RootNamespace): Add "alias name" parameter.
12471 (GlobalRootNamespace): Simplify drastically.
12472 (Namespace.Lookup): Don't use GetNamespace.
12473 * typemanager.cs (GetRootNamespace): Rename from
12474 ComputeNamespaceForAlias.
12475 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12477 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12479 * anonymous.cs (AnonymousContainer): Don't crash when container
12482 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12484 * expression.cs (Binary.DoResolve): Warn when comparing same
12487 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12490 * expression.cs (Binary.DoResolve): It looks like there are no
12491 convetsion rules in enum context.
12493 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12495 Add support for extern alias qualifiers.
12496 * typemanager.cs: Move some LookupTypeReflection code
12497 to namespace.cs, to have cleaner code. Added some methods
12498 to help us keep track of the extern aliased references.
12499 * driver.cs: Add suport for extern alias assemblies on command
12500 line and check for their warnings/errors. Also keep track of the
12501 extern aliased assemblies.
12502 * namespace.cs: Move the global functionality of Namespace
12503 to GlobalRootNamespace/RootNamespace. Now the global namespace
12504 is GlobalRootNamespace.Globa. Also the code moved from
12505 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12506 Finally added LocalAliasEntry (AliasEntry before) and
12507 ExternAliasEntry, to handle alias statements.
12508 * cs-parser.jay: Add support in the grammar for extern alias
12510 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12511 Update callings to Namespace (now in GlobalRootNamespace).
12513 2005-10-18 Raja R Harinath <rharinath@novell.com>
12516 * class.cs (TypeContainer.DefineType): Move updating of
12517 topological sort earlier in the code.
12518 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12520 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12523 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12525 * constant.cs (Constant.TryReduce): Moved from Cast class.
12526 (Reduce): Made little bit more OO and fixed missing conversions.
12528 * ecore.cs (Reduce): Implemented.
12529 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12531 * literal.cs (Reduce): Implemented.
12533 * class.cs: Reverted Miguel's wrong commit.
12535 2005-10-14 Miguel de Icaza <miguel@novell.com>
12537 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12539 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12541 * cs-parser.jay, expression.cs : CS0214 was missing error location
12542 for constants. Fixed bug #76404.
12544 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12547 * convert.cs (ExplicitConversionCore): Fixed object->enum
12550 2005-10-10 Raja R Harinath <rharinath@novell.com>
12552 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12553 InstanceExpression.
12554 (PropertyExpr.EmitCall): Likewise.
12555 * expression.cs (Invocation.EmitArguments): Handle case where
12557 (Invocation.EmitCall): Avoid allocating temporary variable if
12558 there are no arguments.
12560 2005-10-07 Raja R Harinath <rharinath@novell.com>
12563 * convert.cs (ImplicitConversionStandard): Move conversion of
12564 void* to arbitrary pointer types ...
12565 (ExplicitConversionStandard): .. here.
12566 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12567 error to always print typenames.
12569 2005-10-07 Raja R Harinath <rharinath@novell.com>
12571 * convert.cs (GetConversionOperator): Rename from
12572 GetConversionOperators. Move operator selection code from ...
12573 (UserDefinedConversion): ... here.
12575 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12577 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12580 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12582 * assign.cs (Assign.DoResolve): Error method changed.
12584 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12586 * const.cs (ResolveValue): Reset in_transit immediately.
12588 * constant.cs: Error method changed.
12590 * convert.cs: Removed useless location parameter.
12591 (ExplicitNumericConversion): Don't do double enum check.
12592 (ExplicitConversionCore): Renamed from ExplicitConversion.
12593 (ExplicitUnsafe): Extracted from ExplicitConversion.
12594 (ExplicitConversion): Uses for error reporting.
12596 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12598 (ResolveBoolean): Uses common error method.
12599 (CastToDecimal): Get rid of ec.
12600 (CastFromDecimal): Optimized.
12601 (ConvCast): Get rid of ec.
12603 * enum.cs (ResolveValue): Reset in_transit immediately.
12604 (Emit): Return after first error.
12606 * expression.cs: Convert changes.
12608 * literal.cs: Error method changed.
12610 * statement.cs: Error method changed.
12612 2005-10-03 Raja R Harinath <rharinath@novell.com>
12614 * support.cs (SeekableStreamReader.Position): Don't error out when
12615 the requested position is just beyond the end of the current
12618 2005-09-28 Raja R Harinath <rharinath@novell.com>
12620 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12621 try to keep in sync with the byte count of the underlying Stream.
12622 However, this limits us to a window size of 2048 characters: i.e.,
12623 the maximum lookahead of our lexer/parser can be 2048 characters.
12625 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12628 * driver.cs: Fix compilation files with full root path.
12630 2005-09-25 Miguel de Icaza <miguel@novell.com>
12632 * report.cs (SymbolRelatedToPreviousError): Format the output so
12633 it does not use an open parenthesis that is never closed.
12635 * driver.cs: Follow coding guidelines
12637 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12640 * const.cs (Const.ResolveValue): Check for assigning non-null
12641 value to reference type.
12643 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12645 * anonymous.cs: Implemented ExprClassName.
12647 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12650 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12653 * class.cs (StaticClass.DefineContainerMembers): Report protected
12656 * codegen.cs: if(ed) PRODUCTION.
12658 * convert.cs (Error_CannotImplicitConversion): Better error
12661 * cs-parser.jay: More error checks.
12663 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12665 * driver.cs (CSCParseOption): Enabled wrong option check.
12667 * ecore.cs (Expression.ExprClassName): Turned to property.
12668 (MemberExpr.CheckIntermediateModification): For checking boxed
12669 value types modification.
12671 * statement.cs (Fixed.Resolve): Expression type must be
12672 convertible to fixed type.
12673 (CollectionForeach.GetEnumeratorFilter,TryType):
12674 Small refactoring for easier error checking.
12676 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12678 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12681 * class.cs (GeneratedBaseInitializer): New class for customization
12682 compiler generated initializers.
12683 (MemberBase.DoDefine): Check Obsolete attribute here.
12684 (FieldMember.DoDefine): Ditto.
12686 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12689 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12690 (MemberCore.GetObsoleteAttribute): Removed argument.
12691 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12692 (MemberCore.CheckObsoleteType): New helper.
12696 * statement.cs: Updates after MemberCore changes.
12698 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12699 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12701 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12702 obsolete attribute for compiler construct.
12703 (As.DoResolve): Cache result.
12705 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12707 2005-09-26 Raja R Harinath <rharinath@novell.com>
12710 * expression.cs (This.VerifyFixed): In a value type T, the type of
12711 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12712 value type R, 'this' is treated as a value parameter.
12714 2005-09-22 Miguel de Icaza <miguel@novell.com>
12716 * statement.cs (Lock): Use the TemporaryVariable class instead of
12717 manually using local variables as those do not work when variables
12720 * ecore.cs: Moved the TemporaryVariable class from being a nested
12721 class inside Foreach to be a public class that can be employed in
12724 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12726 * cs-parser.jay: interface_accessors replaced by
12727 accessor_declarations.
12729 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12732 * statement.cs (GotoCase.Resolve): Convert null constant to
12734 (SwitchLabel.ResolveAndReduce): Ditto.
12735 (SwitchLabel.NullStringCase): Custom null stamp.
12736 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12738 typemanager.cs (CSharpSignature): Don't skip first argument
12741 2005-09-18 Miguel de Icaza <miguel@novell.com>
12743 * driver.cs: Set InEmacs based on the environment variable EMACS.
12745 * location.cs (InEmacs): in this mode, do not report column
12746 location as it confuses Emacs.
12748 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12750 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12751 expression.cs, iterators.cs, literal.cs: Store constants and
12754 * class.cs (MemberBase.ShortName): Pass location.
12756 * cs-parser.jay: Some location fixes.
12758 * ecore.cs (Expression.Location): Made virtual.
12760 2005-09-05 Miguel de Icaza <miguel@novell.com>
12762 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12763 if the underlying types are the same, otherwise we need to produce
12764 code that will do the proper cast.
12766 This was exposed by Marek's constant rewrite which produced
12767 invalid code for the call site:
12769 enum X : long { a }
12770 void Method (X v) {}
12774 This fixes test-49.cs
12776 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12778 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12779 Type/Object should be allowed as well. Fixed bug #75968.
12781 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12783 * expression.cs : (Binary.DoResolve): when one is enum constant and
12784 another is constant 0, then return enum one *as enum type*.
12787 2005-09-02 Raja R Harinath <rharinath@novell.com>
12789 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12793 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12794 flow-branching for LocalVariableReferences in case we were invoked
12795 from a MemberAccess.
12796 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12798 (LocalVariableReference.DoResolveBase): ... this.
12799 (MemberAccess.Resolve): Do the check that was disabled during
12802 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12805 (PartialContainer.Create): check abstract/sealed/static strictly
12806 but abstract/sealed can exist only at one side. Fixed bug #75883.
12808 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12811 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12812 specified, don't default to UnmanagedType.I4.
12814 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12816 * expression.cs : conditional operator should check possibly
12817 incorrect assign expression. Fixed bug #75946.
12819 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12821 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12822 Reverting the change. gmcs is much complex than mcs on this matter.
12824 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12826 * cs-tokenizer.cs : To read another token ahead of the actual
12827 consumption, use new SavedToken and cache token instead of moving
12828 back the stream with SeekableStreamReader (it seemed problematic).
12830 driver.cs : Thus use StreamReader directly.
12831 * support.cs : Thus removed SeekableStreamReader.
12833 2005-08-30 Raja R Harinath <rharinath@novell.com>
12836 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12837 (ScopeInfo.EmitScopeType): Use it to construct field names from
12838 names of captured locals.
12841 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12842 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12843 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12844 (ExplicitConversion): Remove enum cases already handled by
12845 implicit conversion. Move implicit conversion check to the beginning.
12846 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12847 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12848 Don't treat System.Enum as a struct.
12850 2005-08-30 Jb Evain <jbevain@gmail.com>
12852 * attribute.cs: handles as expression in parameters.
12854 2005-08-30 Raja R Harinath <rharinath@novell.com>
12857 * class.cs (TypeContainer.VerifyClsName): Don't use a
12858 PartialContainer when verifying CLS compliance.
12859 (AbstractPropertyEventMethod): Set Parent here, ...
12860 (PropertyMethod): ... not here.
12862 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12864 * attribute.cs : escaped attribute name should not be allowed to be
12865 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12867 2005-08-29 Raja R Harinath <rharinath@novell.com>
12870 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12871 when converting a long constant to unsigned long.
12872 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12873 detect where IsApplicable and VerifyArgumentsCompat disagree.
12875 2005-08-29 Raja R Harinath <rharinath@novell.com>
12876 and Carlos Alberto Cortez <carlos@unixmexico.org>
12879 * class.cs (TypeContainer.CanElideInitializer): New helper.
12880 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12881 can safely emitting the initializer of a field.
12883 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12885 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12886 allowed inside a switch (without loop). Fixed bug #75433.
12888 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12890 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12891 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12893 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12895 * driver.cs : kinda reverting the default encoding changes (not exact
12896 revert since I noticed that "codepage:reset" might not work fine).
12898 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12900 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12901 Location. Now getter and setter store location correctly.
12902 (errors/cs0111-12.cs now reports the expected location.)
12904 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12906 * driver.cs : Use default encoding on the environment.
12907 Removed (now that) extra parameter for SeekableStreamReader.
12908 * support.cs : (SeekableStreamReader) third .ctor() argument for
12909 StreamReader is not required (always true). preamble size could
12910 be acquired in simpler and safe way.
12912 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12914 * cs-parser.jay: report CS0642 at warning level 3
12915 and report CS0642 for an if else statement also
12916 fixes bug #74745. Patch by John Luke (and a bit
12918 Removed extra CS0642 warning check for "while",
12920 * statement.cs: In Block.Resolve(), CS0642 check
12921 is reimplemented to check a sequence of an empty
12922 statement and a block.
12924 Both fix bug #66777.
12926 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12928 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12929 detection until I fix it.
12931 * cs-tokenizer.cs: Changed error message.
12933 * cs-parser.jay: Fixed 2 error locations.
12935 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12936 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12939 * enum.cs (GetSignatureForError): Fixed.
12941 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12945 * typemanager.cs (RegisterProperty): Removed.
12947 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12949 2005-08-24 Raja R Harinath <rharinath@novell.com>
12952 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12953 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12955 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12957 * expression.cs : tiny fix is required for not warning positive ulong.
12960 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12962 * expression.cs : add CS0652 check for constant and integral
12963 expression. Fixed bug #53974.
12965 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12967 * expression.cs : in DoNumericPromotions(), check if there is implicit
12968 conversion overload for string (to check CS0034). Fixed bug #52492.
12970 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12972 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12974 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12976 * ecore.cs : report location when it is *not* Null.
12978 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12984 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12985 correctly. Fixed bug #75721.
12987 2005-08-23 Raja R Harinath <rharinath@novell.com>
12989 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12990 loop that performs 'min (pos, char_count)'.
12993 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12994 converted value in Operator.OnesComplement.
12996 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12998 * anonymous.cs: If the anon method is pulled into a helper class,
12999 it needs to be `internal' not `private'. Fixes runtime behavior on
13002 2005-08-20 Martin Baulig <martin@ximian.com>
13004 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
13005 scope if we don't already have it.
13007 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
13008 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
13011 2005-08-17 Marek Safar <marek.safar@seznam.cz>
13014 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
13015 is a partial class.
13017 2005-08-16 Marek Safar <marek.safar@seznam.cz>
13019 The big constants rewrite
13020 Fix #75746, #75685 and more
13021 As a side effect saved 1MB for MWF ;-)
13023 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
13024 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
13025 enum based for corlib compilation.
13027 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
13030 * class.cs (FixedField.Define): Use ResolveAsConstant.
13032 * const.cs (IConstant): Interface constants and enums.
13033 (Const.ResolveValue): New method for constant resolvning.
13034 (ExternalConstant): Constants from imported assemblies.
13036 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
13037 conversion; like enums.
13038 (Constant.ToType): Converts this constant to different type.
13039 (Constant.Increment): Adds 1.
13041 * convert.cs (ImplicitConversionRequired): Simplified.
13043 * cs-parser.jay: Create EnumMember directly.
13045 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
13047 * doc.cs (GenerateEnumDocComment): Removed.
13049 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
13050 (ConvertIntLiteral): Removed.
13051 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
13053 * enum.cs (EnumMember): Implement IConstant.
13054 (Enum.IsValidEnumConstant): Removed.
13055 (Enum.GetNextDefaultValue): Removed.
13056 (Enum.FindMembers): Updated.
13057 (Enum.GenerateDocComment): Iterate enum members.
13059 * expression.cs (Cast.TryReduce): Handle enums correctly.
13060 (New.Constantify): Made public.
13061 (MemberAccess.DoResolve): Removed contant specific if(s).
13063 * literal.cs (NullLiteral): Implement new abstract methods.
13065 * statement.cs (GotoCase.Resolve): Use new constant methods.
13066 (SwitchLabel.ResolveAndReduce): Use new constant methods.
13068 * typemanager.cs (LookupEnum): Removed.
13069 (IsEnumType): Fixed to work with corlib.
13070 (RegisterConstant): Removed.
13071 (LookupConstant): Removed.
13072 (GetConstant): Changed to work with IConstant.
13074 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
13076 * location.cs : Fixed overflown (>255) column number.
13078 2005-08-03 Raja R Harinath <rharinath@novell.com>
13080 First cut of the qualified-alias-member feature.
13081 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
13083 * cs-parser.jay (DOUBLE_COLON): New token.
13084 (namespace_or_type_name): Add rule for recognizing
13085 qualified-alias-members.
13086 (primary_expression): Likewise.
13087 (element_access): Allow QualifiedAliasMember as a possible
13088 type-bearing expression.
13089 (local_variable_type, local_variable_pointer_type): Likewise.
13090 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
13091 aliases in the current and enclosing namespace declarations.
13092 (NamespaceEntry.UsingAlias): Add CS0440 warning.
13093 * decl.cs (MemberName.is_double_colon): New.
13094 (MemberName.MemberName): Add new constructor for alias-member.
13095 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
13096 * expression.cs (QualifiedAliasMember): New expression type.
13098 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13100 * location.cs : it borked when no argument was specified.
13102 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13104 * location.cs : tiny ToString() format fix.
13106 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13108 * statement.cs : oops, it was missing.
13110 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
13112 A set of fixes for precise line/column location.
13115 "token" field now holds a file/line "delta", a line number offset
13116 from the segment, and a column number. See also:
13117 http://lists.ximian.com/pipermail/mono-devel-list/2004-
13118 December/009508.html
13119 Removed static IsNull. Use instance IsNull property instead.
13120 * cs-tokenizer.cs :
13121 For some tokens it stores Location. For Identifier it stores
13122 LocatedToken which is a pair of string name and location.
13123 Column numbers are adjusted only at getChar().
13125 Use Location.ToString() for reporting (it now contains column).
13127 Largely modified to use LocatedToken instead of
13128 string (IDENTIFIER), and to acquire Location from some tokens.
13129 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
13130 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
13132 Now MemberName holds Location. DeclSpace.ctor() receives Location
13133 as a parameter. Removed extra parameters to all derived classes.
13134 Replaced Location.IsNull() with instance property.
13135 * assign.cs, expression.cs :
13136 Added .ctor() overload that omits Location.
13138 Added "nameEscaped" flag that indicates the identifier was escaped
13139 in the source file. This fixes bug #57047.
13141 2005-08-02 Marek Safar <marek.safar@seznam.cz>
13143 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
13144 New method, looking for lo-case imported cls type.
13146 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
13149 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
13151 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
13153 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
13154 all_imported_types.
13155 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
13157 Optimized to save 3.5 MB for SWF compilation.
13159 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13161 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
13162 (PartialContainer.Create): Moved logic AddToContainer.
13163 (PartialContainer.MarkForDuplicationCheck): Shares name.
13165 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
13168 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
13170 (Namespace.GetSignatureForError): New method.
13172 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
13173 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
13175 2005-08-01 Raja R Harinath <rharinath@novell.com>
13178 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
13179 member lookup rather than qualifier_type, since qualifier_type can
13182 2005-08-01 Marek Safar <marek.safar@seznam.cz>
13184 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
13187 2005-07-31 Miguel de Icaza <miguel@novell.com>
13189 * statement.cs: Copy the local exception into the exception
13190 captured local. Fixes 75674
13192 2005-07-31 Raja R Harinath <harinath@gmail.com>
13195 * expression.cs (Invocation.OverloadResolve): Don't report error
13196 CS1501 if error CS1502 has been reported.
13197 (New.DoResolve): Delegate CS1501 reporting to
13198 Invocation.OverloadResolve.
13201 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
13202 invariant-meaning-in-block property in an enclosing block if
13205 2005-07-29 Marek Safar <marek.safar@seznam.cz>
13207 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
13208 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
13209 (Switch.CheckSwitch): Just save 50kb for SWF.
13211 2005-07-27 Martin Baulig <martin@ximian.com>
13213 * anonymous.cs (CaptureContext.AddField): Added
13214 `AnonymousContainer am' argument; compute its toplevel scope if
13215 it's not already computed. Fixes #75649.
13217 2005-07-26 Raja R Harinath <rharinath@novell.com>
13220 * class.cs (Constructor.Emit): Reset block to null if the block
13223 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13225 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13227 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13229 * class.cs (MethodData.Define): Check whether accessor implementing
13230 interface is public.
13232 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13234 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13237 * namespace.cs (LookupType): Moved same type check to...
13239 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13240 with the same name.
13242 2005-07-21 Raja R Harinath <rharinath@novell.com>
13244 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13245 already found a typebuilder.
13246 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13247 MemberNames, not strings.
13249 * const.cs (Error_ExpressionMustBeConst):
13250 Rename from Error_EpressionMustBeConst.
13251 * const.cs, class.cs, statement.cd: Update.
13253 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13257 * const.cs (Const.LookupConstantValue): Report missing contant expression
13259 (Error_EpressionMustBeConstant): Only one error method.
13261 * class.cs, statement.c: Updated.
13263 2005-07-20 Raja R Harinath <rharinath@novell.com>
13265 * statement.cs (Block.Flags): Add back HasVarargs.
13266 (Block.flags): Make protected.
13267 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13269 * typemanager.cs (types, typecontainers, user_types): Remove.
13270 (UserTypes, TypeContainers): Likewise.
13271 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13272 (CleanUp, Reset): Update.
13273 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13274 (GetNestedType): Use Type.GetNestedType.
13275 (CoreLookupType): Take two arguments, the namespace and the
13276 basename of the type. Update to use the Namespace.Lookup
13278 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13279 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13280 string concatenation and substring matches.
13281 * class.cs, enum.cs, delegate.cs: Update to changes.
13283 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13285 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13286 Expression and made virtual.
13288 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13289 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13291 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13293 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13296 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13299 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13302 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13303 AssemblyCultureAttribute is not used on executable.
13306 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13308 2005-07-16 Raja R Harinath <rharinath@novell.com>
13311 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13312 New. Reports CS0252/CS0253.
13313 Mostly taken from preliminary patch by Duncak Mak.
13314 (Binary.DoResolveOperator): Store results of operator lookup.
13315 Use them to detect if we need to warn about unintended reference
13318 2005-07-15 Raja R Harinath <rharinath@novell.com>
13321 * namespace.cs (Namespace.Lookup): Add back location parameter.
13322 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13323 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13325 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13326 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13327 (Namespace.LookupType): ... this.
13328 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13330 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13331 purported to handle pointers.
13332 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13335 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13337 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13340 2005-07-15 Raja R Harinath <rharinath@novell.com>
13342 * namespace.cs (Namespace.Lookup): Drop location parameter.
13343 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13344 (NamespaceEntry.Lookup): ... this.
13345 (NamespaceEntry.Error_AmbiguousTypeReference):
13346 Move here from DeclSpace.
13347 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13349 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13350 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13351 Move to NamespaceEntry.
13352 * delegate.cs, expression.cs: Update to changes.
13354 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13356 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13357 CheckAttributeType and refactored.
13358 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13359 ResolveAsTypeTerminal error handling.
13360 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13362 (GetSignatureForError): Print errors in same way.
13365 * codegen.cs: Reflect attribute GetSignatureForError change.
13368 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13370 * namespace.cs (UsingEntry): Refactored to make fields private.
13373 statement.cs: Error_UnexpectedKind has extra parameter.
13375 2005-07-14 Raja R Harinath <rharinath@novell.com>
13377 * ecore.cs (IAlias): Remove.
13378 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13379 that implement the interface.
13380 * namespace.cs (Namespace): Likewise.
13381 (Namespace.declspaces): Renamed from 'defined_names'.
13382 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13383 DeclSpace instead of an IAlias.
13384 * tree.cs (Tree.AddDecl): Update.
13386 2005-07-12 Raja R Harinath <rharinath@novell.com>
13388 * statement.cs (Block.Flags); Remove HasVarargs.
13389 (Block.HasVarargs): Move to ToplevelBlock.
13390 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13391 (Block.Variables): Make protected. Initialize variable hashtable
13393 (Block.AddVariable): Update.
13394 (Block.Resolve): Update to changes.
13395 (ToplevelBlock.HasVarargs): New boolean.
13396 (ToplevelBlock.ThisVariable): Move here from Block.
13397 (ToplevelBlock.AddThisVariable): Likewise.
13398 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13399 * expression.cs (This.ResolveBase): Update to changes.
13400 (ArglistAccess.DoResolve): Likewise.
13402 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13405 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13407 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13408 not used and not used & assigned.
13409 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13411 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13414 * expression.cs (Is.DoResolve): null is never provided type.
13416 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13419 * cs-parser.jay: Less strict event error rule to catch more errors.
13421 2005-07-08 Martin Baulig <martin@ximian.com>
13423 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13424 gettter (allowed) or setter (not allowed).
13426 * class.cs (Accessor): Implement IIteratorContainer.
13427 (Accessor.Yields): New public field.
13428 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13429 per-accessor basis.
13432 (get_accessor_declaration, set_accessor_declaration): Set the
13433 `yields' flag on the accessor, not the property.
13434 (property_declaration): Do the iterators check on a per-accessor
13435 basis and not for the whole property.
13437 2005-07-08 Martin Baulig <martin@ximian.com>
13439 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13440 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13442 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13445 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13446 (ExtractSecurityPermissionSet): Cope with self referencing security
13447 attributes properly.
13449 * driver.cs (SetOutputFile): Made public property OutputFile.
13451 2005-07-07 Raja R Harinath <rharinath@novell.com>
13454 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13455 has_nonstatic_fields. Make into a FieldBase pointer.
13456 (TypeContainer.AddField): Add CS0282 check.
13457 (TypeContainer.EmitType): Update.
13459 2005-07-06 Miguel de Icaza <miguel@novell.com>
13461 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13462 compare if they start with __.
13464 2005-07-06 Raja R Harinath <rharinath@novell.com>
13466 * statement.cs (Switch.SwitchGoverningType): Only look at
13467 UserCasts that don't need implicit standard conversions to one of
13468 the allowed switch types (Fixes test-322.cs).
13469 (LocalInfo.Resolve): Re-enable sanity-test.
13471 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13473 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13475 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13477 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13479 2005-07-06 Raja R Harinath <rharinath@novell.com>
13482 * ecore.cs (SimpleName.GetSignatureForError): Add.
13483 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13484 (MemberAccess.GetSignatureForError): Add.
13486 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13488 The big error and warning messages review.
13518 * typemanager.cs: Updated.
13520 * class.cs: (MethodCore.SetYields): Moved here to share.
13521 (PropertyMethod.Define): Moved iterator setup here.
13523 * iterators.cs: Add orig_method to have full access to parent
13526 2005-07-05 Raja R Harinath <rharinath@novell.com>
13528 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13529 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13530 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13531 variable of struct type.
13532 * expression.cs (Unary.ResolveOperator): Update to change.
13533 (Indirection.VerifyFixed): Likewise.
13534 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13535 (ParameterReference.VerifyFixed): Value parameters are fixed.
13536 (This.VerifyFixed): Treat 'this' as a value parameter.
13537 * statement.cs (LocalInfo.IsFixed): Remove.
13539 2005-07-01 Martin Baulig <martin@ximian.com>
13541 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13542 `ec.EmitThis ()' to get the correct scope.
13544 2005-07-01 Martin Baulig <martin@ximian.com>
13546 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13547 instance is a ParameterReference; fixes #75299.
13549 2005-07-01 Martin Baulig <martin@ximian.com>
13551 Reverted Marek's latest patch (r46725):
13552 - it contains structural changes which are neither mentioned in
13553 the ChangeLog nor explained anywhere; for example the additional
13554 argument of EmitContext's and Iterator's .ctor's and the
13555 TypeContainer.DefineMembers() change.
13556 - structural changes like this should go in in seperate patches
13557 and not be hidden in a huge patch which just seems to affect
13558 warnings and errors.
13559 a big and hard to understand patch.
13560 - it breaks iterators and causes regressions, for instance in
13563 2005-06-30 Raja R Harinath <rharinath@novell.com>
13566 * expression.cs (Indexers.map): Remove.
13567 (Indexers.Append): Filter out inaccessible setters and getters.
13568 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13571 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13572 Refactored from ...
13573 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13574 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13575 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13576 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13578 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13581 * class.cs (FieldBase.GetInitializerExpression): One more field
13584 2005-06-28 Miguel de Icaza <miguel@novell.com>
13586 * pending.cs: Do not define a proxy if the base method is virtual,
13587 it will be picked up by the runtime (bug 75270).
13589 2005-06-08 Martin Baulig <martin@ximian.com>
13591 The big Iterators rewrite :-)
13593 * iterators.cs: Rewrite this to use the anonymous methods framework.
13595 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13596 before the TypeContainers; see 2test-21.cs.
13599 (TypeContainer.DefineType): Don't create a new EmitContext if we
13600 already have one (this only happens if we're an Iterator).
13601 (TypeContainer.Define): Also call Define() on all our iterators.
13602 (Method.CreateEmitContext): Added support for iterators.
13605 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13606 (AnonymousContainer.CreateMethodHost): Moved here from
13607 AnonymousMethod and made abstract.
13608 (AnonymousContainer.CreateScopeType): New abstract method.
13609 (AnonymousContainer.IsIterator): New public property.
13610 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13611 get the ScopeTypeBuilder rather than manually defining it here.
13612 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13615 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13616 before RootContext.DefineTypes().
13618 * codegen.cs (EmitContext.RemapToProxy): Removed.
13619 (EmitContext.CurrentAnonymousMethod): Changed type from
13620 AnonymousMethod -> AnonymousContainer.
13621 (EmitContext.ResolveTopBlock): Protect from being called twice.
13622 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13623 (EmitContext.EmitThis): Removed the iterators hacks; use the
13624 anonymous methods framework for that.
13627 (ToplevelBlock.Container): Make this a property, not a field.
13628 (ToplevelBlock.ReParent): New public method; move the
13629 ToplevelBlock into a new container.
13630 (Foreach.TemporaryVariable): Simplify.
13632 2005-06-05 Martin Baulig <martin@ximian.com>
13634 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13635 (Block.AddTemporaryVariable): New public method; creates a new
13636 `LocalInfo' for a temporary variable.
13637 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13639 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13640 non-iterator variables.
13642 2005-06-05 Martin Baulig <martin@ximian.com>
13644 * statement.cs (Foreach.TemporaryVariable): Create the
13645 LocalBuilder in the Emit phase and not in Resolve since in some
13646 situations, we don't have an ILGenerator during Resolve; see
13647 2test-19.cs for an example.
13649 2005-06-04 Martin Baulig <martin@ximian.com>
13651 **** Merged r45395 from GCS ****
13653 The big Foreach rewrite - Part II.
13655 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13656 with `PropertyInfo ienumerator_getcurrent'.
13658 * codegen.cs (VariableStorage): Removed.
13661 (Foreach): Derive from Statement, not ExceptionStatement.
13662 (Foreach.CollectionForeach): New nested class. Moved all the code
13663 dealing with collection foreach here.
13664 (Foreach.ForeachHelperMethods): Removed.
13665 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13667 2005-05-23 Martin Baulig <martin@ximian.com>
13669 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13670 don't need to. Fix #75014.
13672 2005-05-20 Martin Baulig <martin@ximian.com>
13674 Merged r44808 from GMCS.
13676 * class.cs (TypeContainer.CircularDepException): Removed.
13677 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13678 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13679 (CS0146) and interface (CS0529) dependencies here.
13681 2005-06-21 Raja R Harinath <rharinath@novell.com>
13683 * expression.cs (Invocation.EmitCall): Fix initialization
13684 'this_call' to reflect current behaviour. Fix indentation.
13686 * convert.cs (FindMostEncompassedType): Add two trivial special
13687 cases (number_of_types == 0 || number_of_types == 1).
13688 (FindMostEncompasingType): Likewise.
13690 2005-06-17 Raja R Harinath <rharinath@novell.com>
13692 Some cleanups preparing for the fix of #75283.
13693 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13695 (EventExpr.InstanceResolve): Likewise.
13696 (EventExpr.DoResolve): Remove redundant checks.
13698 2005-06-10 Duncan Mak <duncan@novell.com>
13700 * cs-tokenizer.cs (process_directives): New flag for controlling
13701 the processing of preprocessor directives.
13702 (x_token): After seeing a '#', return Token.NONE instead of going
13703 to handle_preprocessing_directive() when not processing
13704 directives. This avoids unnecessary processing during the token peek in
13709 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13710 the existing error reporting methods instead of Report.Error.
13712 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13713 after Raja's rewrite.
13715 2005-06-08 Miguel de Icaza <miguel@novell.com>
13717 * class.cs: Small fix.
13719 2005-06-08 Raja R Harinath <rharinath@novell.com>
13722 * class.cs (GetPartialBases): Fix return value check of
13723 part.GetClassBases.
13725 2005-06-07 Raja R Harinath <rharinath@novell.com>
13727 Ensure that partial classes are registered in their enclosing
13728 namespace. Initial part of fix of #75160.
13729 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13730 Register declspace with namespace here, not in
13731 DeclSpace.RecordDecl.
13732 * cs-parser.jay: Pass namespace to RecordDecl.
13733 * class.cs (PartialContainer.Create): Likewise.
13734 (ClassPart.DefineType): New sanity-check. Throws an exception if
13736 * decl.cs (Declspace.RecordDecl): Remove.
13737 * namespace.cs (NamespaceEntry.DefineName): Remove.
13739 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13741 * rootcontext.cs: Reset TargetExt as well.
13743 2005-06-03 Raja R Harinath <rharinath@novell.com>
13745 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13746 -langversion:ISO-1.
13748 2005-06-02 Raja R Harinath <rharinath@novell.com>
13750 Fix #75080, cs0119.cs.
13751 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13753 (Expression.Resolve): ... this. Use it. Remove bogus code
13754 allowing ExprClass.Type and ExprClass.Namespace for
13755 ResolveFlags.VariableOrValue.
13756 (Expression.Resolve) [1-argument variant]: Change default resolve
13757 flags based on language version.
13758 (Expression.Error_UnexpectedKind): Use a simple string array
13759 rather than an ArrayList.
13760 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13761 not ExprClass.Type.
13762 (TypeOfVoid.DoResolve): Likewise.
13763 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13764 flags argument -- it always has the same value.
13766 2005-05-31 Raja R Harinath <rharinath@novell.com>
13769 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13770 Use it in the error message.
13771 * assign.cs, expression.cs, statement.cs: Update.
13773 2005-05-30 Raja R Harinath <rharinath@novell.com>
13776 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13777 the "almostMatchedMember" case too.
13778 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13779 that failed the accessibility checks to 'almost_match'.
13781 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13783 * attribute.cs: Use internal MethodBuilder methods to set
13784 ExactSpelling and SetLastError on PInvoke methods, instead
13785 of passing them via charset. Fixes #75060.
13787 2005-05-27 Raja R Harinath <rharinath@novell.com>
13789 * parameter.cs (Parameter): Remove TODO comment.
13790 (Parameter.DefineParameter): Remove Location parameter.
13791 (Parameters.LabelParameters): Likewise.
13792 * class.cs (Constructor.Emit): Update to change.
13793 (MethodData.Emit): Likewise.
13794 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13795 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13797 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13800 Removed Parameters.Location and added Parameter.Location instead.
13801 Removed Location parameter from Emit() and GetSignature().
13808 Modified all related calls.
13810 2005-05-26 Raja R Harinath <rharinath@novell.com>
13812 Improve user-defined conversion handling.
13813 * convert.cs (GetConversionOperators): Rewrite. Return only the
13814 applicable operators.
13815 (AddConversionOperators): New. Helper for GetConversionOperators.
13816 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13817 there is only one most encompassed/encompassing type.
13818 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13819 "applicable operator" handling.
13820 (UserConversion): Move cache here from GetConversionOperators.
13821 Directly cache the chosen operator, rather than the whole
13823 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13824 case. Allow conversion of decimal to sbyte and byte too.
13825 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13826 New static methods. Used to avoid allocating EmptyExpressions in
13829 2005-05-24 Duncan Mak <duncan@novell.com>
13831 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13832 another class, used in Convert.ExplicitNumericConversion.
13833 (CastToDecimal): New class, similar to above, but casts to
13834 System.Decimal, used in Convert.ImplicitNumericConversion and also
13835 in explicit convesion from double/float to decimal.
13837 * convert.cs (ImplicitNumericConversion): Handle implicit
13838 conversions to System.Decimal.
13839 (ExplicitNumericConversion): handle explicit conversions to
13844 2005-05-20 Miguel de Icaza <miguel@novell.com>
13846 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13847 know the type at this stage, just break through. Fixes #75008
13849 2005-05-19 Martin Baulig <martin@ximian.com>
13852 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13853 to disable error reporting.
13855 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13856 here since we don't want to report an error; see the new test-336.cs.
13858 2005-05-19 Raja R Harinath <rharinath@novell.com>
13860 * statement.cs (ToplevelBlock.GetParameterReference)
13861 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13862 Move here from class Block.
13863 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13864 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13866 2005-05-18 Martin Baulig <martin@ximian.com>
13871 (FlowBranching.Reachability): Add non-static public And() and Or()
13873 (FlowBranchingSwitch): New class; do the `break_origins' thing
13874 like in FlowBranchingLoop.
13875 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13876 reachability, not just locals and parameters.
13877 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13878 switch; MergeBreakOrigins() now takes care of that.
13880 2005-05-18 Martin Baulig <martin@ximian.com>
13882 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13883 a loop and may leave it, reset the barrier; fixes #74974.
13885 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13887 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13890 * cs-parser.jay: Catch more lexical errors.
13892 * report.cs: Add one more Error method.
13895 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13897 2005-05-17 Martin Baulig <martin@ximian.com>
13899 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13902 2005-05-16 Raja R Harinath <rharinath@novell.com>
13904 Fix test-382.cs. Emit values of decimal constants.
13905 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13907 (TypeContainer.AddField): ... this.
13908 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13909 with initializers to include 'Const's.
13910 (ClassPart.RegisterFieldForInitialization): Forward to
13912 * const.cs (Const.Const): Pass initializer to base class.
13913 (Const.Define): In case of decimal constants, register them for
13914 initialization in a static constructor.
13916 2005-05-14 Martin Baulig <martin@ximian.com>
13918 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13919 do not call ResolveUnreachable() on unreachable statements in
13920 here, see the comment in the source code.
13922 2005-05-13 Raja R Harinath <rharinath@novell.com>
13925 * expression.cs (BinaryResolveOperator): If one of the operands of
13926 an equality comparison is 'null' and the other is a pointer type,
13927 convert the null to a NullPointer.
13928 * convert.cs (ImplicitReferenceConversion): If the expression is a
13929 NullLiteral and the target type is a pointer type, return a
13930 NullPointer instead.
13931 (ImplicitConversionStandard): Likewise.
13933 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13935 * cs-parser.jay: Set readonly context based on special constructs.
13937 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13938 readonly variable error handling.
13940 * rootcontext.cs (EmitCode): Don't verify members when error
13943 * statement.cs (LocalInfo): Add reaodnly context information.
13944 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13946 2005-05-13 Raja R Harinath <rharinath@novell.com>
13948 * statement.cs (Block.Resolve): Revert change below. Modify fix
13949 for #74041 to initialize 'resolved' to false only for explicit
13950 blocks. Fixes #74873.
13952 2005-05-12 Raja R Harinath <harinath@gmail.com>
13955 * typemanager.cs (unmanaged_enclosing_types): New.
13956 (IsUnmanagedType): Avoid infloops by using
13957 'unmanaged_enclosing_types' to talk with recursive invocations.
13959 2005-05-13 Martin Baulig <martin@ximian.com>
13961 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13962 instance variable, not a local. Fix #74873.
13963 (Block.ResolveUnreachable): Set it to true here.
13965 2005-05-11 Duncan Mak <duncan@novell.com>
13967 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13968 continuing to process for 'arg'.
13969 (handle_preprocessing_directive): Check the argument of the #endif
13970 directive and report error CS1025 if there are any trailing
13973 According to the C# spec, having even whitespace after the #endif
13974 directive is illegal; however, because we call arg.TrimEnd ()
13975 beforehand, we have the same behavior as csc, allowing whitespace
13976 after the directive.
13980 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13984 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13985 (Constructor.GetObsoleteAttribute): Implemented correctly.
13987 2005-05-10 Martin Baulig <martin@ximian.com>
13989 * support.cs (ReflectionParameters.ParameterModifier): Use
13990 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13991 and `ParameterAttributes.In'. Fixes #74884.
13993 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13995 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13997 * expression.cs (Argument.GetParameterModifier): Turned to property.
13998 (Invocation.Error_InvalidArguments): Add more descriptive errors.
14000 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
14003 2005-05-09 Raja R Harinath <rharinath@novell.com>
14006 * decl.cs (MemberCache.AddMethods): Register override methods,
14007 rather than non-override methods.
14008 * typemanager.cs (RegisterOverride): New.
14009 (IsOverride): Update.
14011 2005-05-09 Marek Safar <marek.safar@seznam.cz>
14015 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
14016 recursive declaration.
14018 * statement.cs (Block.ResolveMeta): Report any error in resolving.
14020 2005-05-06 Marek Safar <marek.safar@seznam.cz>
14022 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
14024 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
14026 2005-05-05 Raja R Harinath <rharinath@novell.com>
14029 * decl.cs (DeclSpace.FamilyAccessible):
14030 Use TypeManager.IsNestedFamilyAccessible.
14032 Fix reopened #64812.
14033 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
14036 2005-05-04 Raja R Harinath <rharinath@novell.com>
14037 Abin Thomas <projectmonokochi@rediffmail.com>
14038 Anoob V E <projectmonokochi@rediffmail.com>
14039 Harilal P R <projectmonokochi@rediffmail.com>
14042 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
14043 allow access to all static members.
14045 2005-05-04 Martin Baulig <martin@ximian.com>
14047 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
14049 2005-05-04 Martin Baulig <martin@ximian.com>
14053 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
14054 section at the end; make things work if `default' is not the last
14057 2005-05-04 Martin Baulig <martin@ximian.com>
14061 * statement.cs (Switch): Replaced the `got_default' field with a
14062 `default_section' one.
14063 (Switch.CheckSwitch): Set `default_section' here.
14064 (Switch.Resolve): If we're a constant switch and the constant is
14065 not found, use the default section.
14067 2005-05-03 Martin Baulig <martin@ximian.com>
14069 * expression.cs (ArrayAccess.EmitGetLength): New public method.
14071 * statement.cs (Foreach.ArrayForeach): New nested class.
14072 (Foreach.TemporaryVariable): New nested class.
14073 (Foreach.EmitArrayForeach): Removed; this is now in the new
14074 ArrayForeach class.
14076 2005-05-03 Raja R Harinath <rharinath@novell.com>
14078 * pending.cs (BaseImplements): Move the #74773 fix here. This is
14080 (VerifyPendingMethods): Revert change below.
14082 * typemanager.cs (IsOverride, RegisterNonOverride): New.
14083 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
14084 that used to trigger warning -28. Remove warning -28.
14085 * expression.cs (Invocation.OverloadResolve): Use
14086 TypeManager.IsOverride to distinguish override methods.
14089 * pending.cs (VerifyPendingMethods): If a base type implements the
14090 requested interface, don't bother checking individual methods of
14091 the base type. As a side-effect, this prevents the creation of
14092 unnecessary proxies.
14094 2005-05-02 Martin Baulig <martin@ximian.com>
14098 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
14099 Also `And' the locals if the old vector is null.
14100 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
14101 null; in this case we basically reset all the variables.
14103 2005-05-02 Martin Baulig <martin@ximian.com>
14107 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
14108 Added `FlowBranching branching' argument; always `and' the
14109 variables instead of `or'ing them unless we're an infinite loop.
14111 * statement.cs (While.Resolve): Create a new sibling unless we're
14114 2005-05-02 Martin Baulig <martin@ximian.com>
14118 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
14119 arguments; use it instead of creating a new TopLevelBlock.
14120 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
14121 our ConstructorInitializer.
14124 (TopLevelBlock.TopLevelBranching): New public property.
14125 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
14126 and create our `TopLevelBranching'.
14128 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
14129 anonymous method host, use `block.TopLevelBranching' rather than
14130 creating a new branching.
14132 2005-04-20 Miguel de Icaza <miguel@novell.com>
14134 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
14135 a ScopeInfo, if any of the current children is a child of the new
14136 entry, move those children there.
14138 2005-04-30 Martin Baulig <martin@ximian.com>
14140 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
14141 at the beginning of a SwitchSection. Fix #73335.
14143 2005-04-27 Marek Safar <marek.safar@seznam.cz>
14146 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
14148 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
14149 (FieldExpr.DoResolve): Obsolete members are ignored for field
14152 2005-04-26 Marek Safar <marek.safar@seznam.cz>
14154 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
14155 of arrays detection.
14157 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
14159 (Field.VerifyClsCompliance): Volatile fields are not compliant.
14161 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
14164 2005-04-25 Ben Maurer <bmaurer@ximian.com>
14166 * cs-parser.jay: Use the prefered version of -unsafe in error
14169 2005-04-22 Marek Safar <marek.safar@seznam.cz>
14171 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
14174 2005-04-20 John Luke <john.luke@gmail.com>
14176 * driver.cs: fix typo in error message, --outout to --output
14178 2005-04-20 Marek Safar <marek.safar@seznam.cz>
14180 * codegen.cs (InRefOutArgumentResolving): New field.
14182 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
14183 fields outside contructor.
14185 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
14187 2005-04-19 Miguel de Icaza <miguel@novell.com>
14189 * anonymous.cs (CaptureContext.EmitParameterInstance): The
14190 parameter code was not completed ever, so it was not as up-to-date
14191 as local variables. Must finish it.
14193 The bug fix was to compare the Toplevel of the block, not the
14194 current block. Thanks for Ben for pointing this out.
14196 2005-04-19 Raja R Harinath <rharinath@novell.com>
14198 * decl.cs (AddMethods): Use the declaring type of the problem
14199 method to determine if we want to squash a warning.
14201 2005-04-19 Marek Safar <marek.safar@seznam.cz>
14203 * attribute.cs: Removed debug output.
14205 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
14207 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
14210 2005-04-18 Raja R Harinath <rharinath@novell.com>
14213 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14214 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14215 all null comparisons against reference types.
14217 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14220 * class.cs (TypeContainer.CircularDepException) New nested
14222 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14223 (TypeContainer.DefineType): Removed error, reset InTransit before
14225 (Class.DefineType): Throw exception when is in Transit.
14226 Catch exception and report error.
14227 (Struct.DefineType): Throw exception when is in Transit.
14228 Catch exception and report error.
14229 (Interface.DefineType): Throw exception when is in Transit.
14230 Catch exception and report error.
14232 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14233 handle nested exception handlers.
14235 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14238 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14239 InFinally and InCatch storage.
14241 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14242 (Catch.Resolve): Set and Restore ec.InCatch.
14243 (Try.Resolve): Set and Restore ec.InFinally.
14244 (Try.HasCatch): True when try has catch.
14246 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14248 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14249 for the same event member, so exclude such cases from warning 419.
14252 2005-04-16 Miguel de Icaza <miguel@novell.com>
14254 * expression.cs (Binary.ResolveOperator): Apply patch from John
14255 Luke to fix bug 59864: operators &, | and ^ on enumerations
14256 require that the same enum type on both sides.
14258 * driver.cs: Add warnings to old flag usage, this is to assist
14259 people who produce Makefiles and hope that the Makefiles will be
14262 * class.cs (TypeContainer.EmitType): Moved the definition of the
14263 special $PRIVATE$ field from the resolve phase to the Emit phase.
14264 During resolve we do not know if we are a struct with
14265 HasExplicitLayout, we know this only after the attributes for the
14268 Set the FieldOffset to zero on the dummy field that we create for
14269 the class. Fixes 74590.
14271 2005-04-16 Raja R Harinath <rharinath@novell.com>
14274 * ecore.cs (PropertyExpr.resolved): New.
14275 (DoResolve): Use it to handle a case of double resolution here.
14276 Handle a case of identical-name-and-type-name.
14277 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14278 resolution by storing the results of expression resolution back
14279 into the "probes" array.
14281 2005-04-15 Raja R Harinath <rharinath@novell.com>
14283 Fix cs0208-7.cs and cs0208-8.cs.
14284 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14285 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14286 error reporting to point out the reason a struct is not unmanaged.
14288 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14290 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14291 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14293 2005-04-13 Raja R Harinath <rharinath@novell.com>
14296 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14297 IdenticalNameAndTypeName here.
14298 (EventExpr.InstanceResolve): Likewise.
14300 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14302 C# 2.0 DefaultCharSetAttribute implementation
14304 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14305 which allows us to set GlobalNamespace for every resolve.
14306 (Attribute.ResolveArguments): Cut from Resolve.
14307 (Attribute.GetCharSetValue): Returns CharSet named argument.
14308 (Attribute.DefinePInvokeMethod): Gets default charset from
14310 (GlobalAttribute.ResolveAsTypeStep): Override.
14311 (GlobalAttribute.ResolveArguments): Override.
14313 * class.cs (TypeAttr): Is protected.
14315 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14316 (ModuleClass.DefaultCharSetType): New memeber.
14317 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14319 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14320 charset from module.
14322 * delegate.cs (TypeAttr): Override.
14323 (Delegate.DefineType): Use this TypeAttr.
14325 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14326 at very early stage (before types are defined) to resolve model
14327 module attributes. It will probably not work with corlib but it
14330 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14331 charset from module.
14333 * typemanager.cs (default_charset_type): New type.
14335 2005-04-13 Raja R Harinath <rharinath@novell.com>
14337 * decl.cs (MemberCache.AddMethods): Don't warn if
14338 System.Object.Finalize has buggy MethodAttributes.
14340 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14343 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14345 * doc.cs : detect ambiguous reference to overloaded members.
14346 Fixed bug #71603. MS 1.1 csc does not detect it.
14348 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14350 * doc.cs : delegates must not be referenced with parameters.
14353 2005-04-12 Miguel de Icaza <miguel@novell.com>
14355 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14357 2005-04-10 Miguel de Icaza <miguel@novell.com>
14359 * driver.cs (MainDriver): Stop processing if the CLS stage found
14362 (CompilerCallableEntryPoint.InvokeCompiler): Always
14363 reset after execution; Take a TextWriter argument for the
14366 * report.cs: Use the error stream instead of hardcoding stderr.
14368 2005-04-09 Miguel de Icaza <miguel@novell.com>
14370 * class.cs: Reduce code paths to test, too small of an
14371 optimization to make it worth the extra testing. Always perform
14374 2005-04-08 Raja R Harinath <rharinath@novell.com>
14377 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14378 operators that had errors reported on them.
14380 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14382 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14384 (Attribute.Resolve): Add named argument type checking.
14386 * class.cs (FixedField.Define): Use IsPrimitiveType
14388 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14390 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14391 unsafe parameter types.
14393 * statement.cs (Using.ResolveExpression): Add better error description.
14395 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14397 2005-04-08 Raja R Harinath <rharinath@novell.com>
14400 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14401 AttributeUsageAttribute in the emitcontext of the attribute class,
14402 not in the emitcontext of the attributable entity it was attached to.
14403 * cs-parser.jay: Use 'current_class', not 'current_container',
14404 when creating a GlobalAttribute.
14406 2005-04-08 Alp Toker <alp@atoker.com>
14408 * pending.cs: The fix to #58413 failed to compile methods implementing
14409 interfaces with/without params modifiers and vice versa, even though
14410 params modifiers aren't part of the signature. Make the modifier check
14411 less strict as in csc.
14413 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14414 Anoob V E <projectmonokochi@rediffmail.com>
14415 Harilal P R <projectmonokochi@rediffmail.com>
14418 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14419 modifiers of pending methods.
14420 (PendingImplementation.PendingImplementation): Initialize it.
14421 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14422 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14423 with ParameterData. Add check for modifiers.
14424 * class.cs (MethodData.Define): Update to changes.
14426 2005-04-07 Raja R Harinath <rharinath@novell.com>
14428 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14430 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14432 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14435 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14438 * typemanager.cs: Registered RequiredAttributeAttribute.
14440 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14442 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14443 Warning CS0169 is back at level 3.
14444 (IMethodData.SetMemberIsUsed): New method.
14446 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14447 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14449 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14451 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14453 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14456 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14459 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14460 to avoid the problems with nested types.
14462 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14463 Anoob V.E <projectmonokochi@rediffmail.com>
14464 Harilal P.R <projectmonokochi@rediffmail.com>
14465 Raja R Harinath <rharinath@novell.com>
14468 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14470 * typemanager (GetConstructor): Make public.
14472 2005-04-05 John Luke <john.luke@gmail.com>
14473 Raja R Harinath <rharinath@novell.com>
14476 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14477 struct too. Return false quicker in a few cases.
14478 (VerifyUnManaged): Use it.
14480 2005-04-05 Raja R Harinath <rharinath@novell.com>
14483 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14484 not 'unreachable_seen'.
14486 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14488 * attribute.cs (Attribute.GetValue): Removed unused.
14490 * codegen.cs (CodeGen.TrimExt): Removed unused.
14492 * cs-parser.jay (output): Removed unused.
14494 * cs-tokenizer.cs (hex_digits): Removed unused.
14496 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14498 * expression.cs (Indirection.LoadExprValue): Removed unused.
14499 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14501 * iterators.cs (Iterator.param_types): Removed unused.
14503 * statement.cs (Goto.block): Removed unused.
14504 (ToplevelBlock.did): Removed unused.
14505 (Switch.ResolveConstantSwitch): Removed unused.
14507 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14509 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14512 2005-04-01 Raja R Harinath <rharinath@novell.com>
14514 Fix #74232 and cs0208-3.cs.
14515 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14516 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14517 unmanaged type. Don't use FieldBuilders when 't' is a
14518 TypeBuilder. Use ModFlags and MemberType fields.
14519 * class.cs (MemberBase.member_type): Rename from MemberType.
14520 (MemberBase.MemberType): New property. Determines member_type on
14522 (MemberBase.DoDefine): Don't initialize MemberType here.
14523 (FieldMember.Define): Likewise.
14525 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14528 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14529 Attributes are emitted there.
14531 2005-04-01 Raja R Harinath <rharinath@novell.com>
14533 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14534 keyword in 'partial enum' too.
14535 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14537 Report from Kamil Skalski <nazgul@omega.pl>.
14540 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14541 have partial containers too.
14543 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14544 in block' checks to Block.CheckInvariantMeaningInBlock.
14545 * statement.cs (Block.GetKnownVariableInfo): Make private.
14546 (Block.IsVariableUsedInChildBlock): Remove.
14547 (Block.IsVariableUsedInBlock): Likewise.
14548 (Block.CheckInvariantMeaningInBlock): New. Show location of
14549 conflicting declaration.
14550 (Block.AddVariable): Make error messages less long-winded and more
14551 specific. Show location of conflicting declaration.
14552 * parameter.cs (Parameters.Location): New readonly property.
14554 2005-03-31 Raja R Harinath <rharinath@novell.com>
14556 Clean up semantics of invoking ResolveMemberAccess.
14557 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14558 can have an instance, ensure that we pass in a non-TypeExpression
14559 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14560 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14561 argument. Update to changes and simplify.
14562 (FieldExpr.Emitinstance): Remove CS0120 check.
14563 (PropertyExpr.EmitInstance): Likewise.
14564 * expression.cs (Argument.Resolve): Likewise.
14565 (Invocation.DoResolve): Update to changes in semantics of
14566 InstanceExpression.
14568 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14571 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14574 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14576 2005-03-31 Raja R Harinath <rharinath@novell.com>
14578 Fix difference in behaviour with commandline invocation.
14579 * driver.cs (Driver.Reset): New.
14580 (CompilerCallableEntryPoint): Call it.
14582 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14583 variable" warnings if the boolean expression failed to resolve.
14585 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14587 * attribute.cs: Fix the union of several permissions when some of them
14588 are unrestricted (so the result isn't an unrestricted permission set).
14591 2005-03-30 Raja R Harinath <rharinath@novell.com>
14593 * ecore.cs (MemberExpr): New class. Convert from interface
14595 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14596 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14598 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14599 (MethodGroupExpr.IsExplicitImpl): Remove.
14600 (Expression.GetFieldFromEvent): Remove.
14601 (SimpleName.MemberStaticCheck): Remove.
14602 (SimpleName.DoSimpleNameResolve): Update to changes.
14603 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14604 (MemberAccess.IdenticalNameAndTypeName): Remove.
14605 (MemberAccess.error176): Move to MemberExpr.
14606 (MemberAccess.DoResolve): Update to changes.
14607 (BaseAccess.DoResolve): Likewise.
14609 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14611 C# 2.0 Conditional attribute class implementation
14613 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14614 Analyzes class whether it has attribute which has ConditionalAttribute
14615 and its condition is not defined.
14617 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14618 (Class.IsExcluded): New method. Search for at least one defined
14619 condition in ConditionalAttribute of attribute class.
14621 2005-03-30 Raja R Harinath <rharinath@novell.com>
14623 * ecore.cs (PropertyExpr): Derive from Expression, not
14624 ExpressionStatement.
14625 (PropertyExpr.EmitStatement): Remove.
14627 2005-03-29 Raja R Harinath <rharinath@novell.com>
14630 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14631 internal field "value__" of an enum be private. The examples for
14632 "value__" that I found on MSDN all used FieldAttributes.Private.
14634 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14635 Don't mention IL method attribute names.
14637 Fix #47991. Remove a TODO.
14638 * statement.cs (Block.Toplevel): Make into a field.
14639 (Block.Parameters): Move into ToplevelBlock.
14640 (Block.known_variables): Rename from child_variable_names.
14641 (Block.Block): Remove variants that take Parameters. Initialize
14642 'Toplevel' with the immediately surrounding toplevel block.
14643 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14644 LocalInfo parameter.
14645 (Block.GetKnownVariableInfo): New.
14646 (Block.IsVariableNameUsedInChildBlock): Update.
14647 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14648 the block, even though it may not be in scope.
14649 (Block.AddVariable): Remove Parameters parameter. Use
14650 Toplevel.Parameters instead.
14651 (Block.AddConstant): Remove Parameters parameter.
14652 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14653 (Block.IsParamaterReference): Likewise.
14654 (Block.IsLocalParameter): Likewise. Simplify a lot.
14655 (ToplevelBlock.Parameters): New. Moved from Block.
14656 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14657 initialize Parameters to a non-null value.
14658 * cs-parser.jay: Update to changes.
14659 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14660 simple names that mean different things in the same block. Use
14661 Block.IsVariableNameUsedInBlock.
14663 2005-03-28 Raja R Harinath <rharinath@novell.com>
14665 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14666 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14667 GetTypeHandle. It is possible for a reflected type to derive from
14668 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14669 System.Array during mscorlib compilation).
14670 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14671 contain a method_hash, don't create one either. Don't create a
14672 deep copy of the base cache's method_hash.
14673 (MemberCache.SetupCache): Rename back from DeepCopy.
14674 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14675 already initialized. If we see an override function, add its
14676 underlying base virtual function to the member_hash too.
14678 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14680 2005-03-26 Raja R Harinath <harinath@acm.org>
14683 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14684 fails to resolve, ensure that the LHS is still resolved as an
14687 2005-03-25 Raja R Harinath <harinath@acm.org>
14689 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14691 (Enum.current_ec): Remove.
14692 (Enum.LookupEnumValue): Remove EmitContext argument.
14693 Just uses the one created during DefineType.
14694 (Enum.FindMembers): Update.
14695 * expression.cs (MemberAccess.DoResolve): Update.
14697 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14699 * assign.cs (Assign.DoResolve): Check for CS1717 when
14700 source and target are same (uses Equals).
14702 * expression.cs (LocalVariableReference, ParameterReference,
14703 This): Implemented Equals, GetHashCode.
14705 * statement.cs (Block.GetParameterReference): Removed useless
14708 2005-03-22 Raja R Harinath <rharinath@novell.com>
14711 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14712 blocks before deciding whether the error is cs0136 or cs0128.
14714 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14715 (using_alias_directive, using_namespace_directive): Pass
14716 MemberName, not an expression to Namespace.UsingAlias and
14718 (MakeName): Use the MemberName of the namespace.
14719 * namespace.cs (Namespace.MemberName): New.
14720 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14721 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14723 * decl.cs (MemberName.Name): Make readonly.
14724 (MemberName.FromDotted): New "constructor".
14725 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14726 (MemberCore.Name): Compute from MemberName on demand.
14727 (MemberCore.SetMemberName): Provide a way to change the
14729 (MemberCore.AddToContainer): Don't take a fullname parameter.
14730 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14731 fully qualified name of the container to the member name.
14732 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14733 only if the type is a member of the root container.
14734 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14735 MemberName.Left rather than searching for an embedded ".".
14736 (PartialContainer.CreatePart): Update to changes in RootContext.
14737 (MemberBase.ShortName): Turn into a property. Use
14738 MemberCore.SetMemberName.
14739 (MemberBase.ExplicitInterfaceName): Remove.
14740 (MemberBase.UpdateMemberName): Remove.
14741 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14742 (PropertyBase.SetMemberName): New override.
14743 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14744 (Tree.GetDecl): New.
14745 (Tree.AllDecls): Rename from Decls.
14746 * attribute.cs, enum.cs, report.cs: Update to changes.
14747 * driver.cs (MainDriver): Use MemberName.FromDotted on
14748 RootContext.MainClass.
14750 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14752 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14755 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14757 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14759 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14760 property accessor modifiers.
14762 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14763 fixed buffer attribute (CS1716).
14764 (PropertyMethod.HasCustomAccessModifier): When property accessor
14765 has custom modifier.
14767 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14769 (PropertyExpr.DoResolveLValue): Add CS0272.
14771 2005-03-17 Miguel de Icaza <miguel@novell.com>
14773 * convert.cs: When converting to a pointer, use the proper Conv.U
14774 or Conv.I depending on the source data type.
14776 * cs-tokenizer.cs: Make the size for large decimal constants,
14779 2005-03-17 Martin Baulig <martin@ximian.com>
14781 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14782 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14784 2005-03-17 Martin Baulig <martin@ximian.com>
14786 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14787 to bool so we can return an error condition.
14788 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14791 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14793 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14796 2005-03-16 Raja R Harinath <rharinath@novell.com>
14798 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14799 Refactor to avoid traversing the list of assemblies, and to avoid
14800 string concatenation.
14801 * typemanager.cs (guid_attr_type): Remove.
14802 (negative_hits, pointers, references): Remove hashes.
14804 (GetConstructedType): New. Uses type_hash to handle constructed
14805 types (arrays, references, pointers).
14806 (GetReferenceType, GetPointerType): Use it.
14807 (GetNestedType): New. Uses type_hash to handle nested types of
14809 (LookupType, LookupTypeDirect): Remove.
14810 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14811 'types' hash and LookupTypeReflection directly.
14812 (params_string, params_object): Use GetConstructedType.
14813 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14815 (Namespace.Lookup): Use cached_types.
14816 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14817 provided by old TypeManager.LookupType.
14818 * rootcontext.cs (MakeFQN): Remove.
14819 * decl.cs (DeclSpace.MakeFQN): Likewise.
14820 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14821 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14822 TypeManager.GetConstructedType.
14823 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14825 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14827 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14830 * cs-parser.jay: Reports CS1527 for any namespace element.
14832 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14835 * expression.cs (ParameterReference.IsAssigned): Changed error to
14837 (Error_WrongNumArguments): Moved CS0245 detection here.
14839 * statement.cs (Return.Resolve): Add CS1622 report.
14841 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14843 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14845 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14847 * attribute.cs expression.cs: Get rid of some allocations.
14849 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14851 * doc.cs : just eliminate the latest change.
14853 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14855 * doc.cs : commented out the latest change. It breaks xml-030.cs
14857 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14859 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14860 fail. So invoke CreateType() in FindDocumentedType().
14862 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14864 * cs-tokenizer.cs : added IsKeyword().
14865 * doc.cs : Detect keyword incorrectly used as identifier.
14866 Allow identifiers prefixed by @.
14868 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14870 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14871 It caused exception in namespace resolving (again!).
14873 * class.cs (Class.ctor): Removed exit.
14874 (PropertyMethod.ctor): ditto.
14876 * codegen.cs (Codegen.Reset): Reset static data.
14877 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14879 * cs-tokenizer.cs (Cleanup): Removed.
14881 * driver.cs (GetSystemDir): Rewrote to one line command.
14882 It caused problem with unloaded dynamic modules.
14883 (UnixParseOption): Removed Exit.
14884 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14885 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14886 Now can be mcs used as library.
14888 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14891 * location.cs (Reset): Reset static data.
14893 * namespace.cs (Reset): Reset static data.
14895 * report.cs (Report.Reset): Reset static data.
14897 * rootcontext.cs (RootContext.Reset): Reset static data.
14899 * tree.cs (RootTypes.ctor): Use Location.Null
14901 * typemanager.cs (TypeManager.Reset): Reset static data.
14902 (CoreLookupType): Removed Exit.
14903 (TypeHandle.Reset): Reset static data.
14905 2005-03-10 Raja R Harinath <rharinath@novell.com>
14908 * typemanager.cs (ComputeNamespaces): Import namespaces from
14909 referenced modules too.
14911 2005-03-09 Raja R Harinath <rharinath@novell.com>
14913 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14916 2005-03-09 Raja R Harinath <rharinath@novell.com>
14918 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14919 enclosing DeclSpace. This ensures that a name-lookup populates
14920 more caches and there are fewer 'TypeExpression's. Carve out
14921 nested type lookup into ...
14922 (LookupNestedTypeInHierarchy): ... this.
14924 2005-03-09 Raja R Harinath <rharinath@novell.com>
14926 Clean up a few partial-class semantics.
14927 Fixes test-357.cs and cs1618-2.cs.
14928 * cs-parser.jay (struct_declaration): Use 'current_class' as
14929 parent of newly-created struct. Remove call to Register ().
14930 Use 'pop_current_class' to complete handing the current struct.
14931 (interface_declaration): Likewise.
14932 (class_declaration): Likewise.
14933 (enum_declaration): Use 'current_class' as parent of newly created
14935 (delegate_declaration): Likewise.
14936 (pop_current_class): New function. This is used to handle closing
14937 up the 'current_class' and 'current_container', and pointing them
14938 to the enclosing class/container.
14939 (CSharpParser): Initialize 'current_class' too.
14940 * decl.cs (MemberCore): Add check for invariant: a partial
14941 container is not a parsed entity, and thus does not enclose any
14943 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14944 (DeclSpace.BaseTypeExpr): Use it.
14945 (DeclSpace.LookupType): Add check for invariant.
14946 * class.cs (TypeContainer): Add check for invariant: a nested
14947 class should have the same NamespaceEntry as its enclosing class.
14948 (TypeContainer.EmitFieldInitializers): Make virtual.
14949 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14951 (TypeContainer.Register): Remove.
14952 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14953 null. Use TypeResolveEmitContext for resolving base types and
14954 interfaces. Move initialization of Parts.TypeBuilder here from
14956 (TypeContainer.DefineNestedTypes): ... here.
14957 (PartialContainer): Take a Namespace not a NamespaceEntry.
14958 (PartialContainer.Create): Don't use Register. Call the
14959 appropriate Add... function directly.
14960 (ClassPart): Take both the PartialContainer and the enclosing
14961 class as constructor arguments.
14962 (ClassPart.EmitFieldInitializers): Override.
14963 (ClassPart.PartFindNestedTypes): Remove.
14964 (FieldBase.GetInitializerExpression): Resolve the initializer
14965 expression in the emit context of the enclosing class.
14966 * tree.cs (RootTypes): Remove Register ().
14968 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14970 * cs-parser.jay: Removed CS0134.
14972 * driver.cs: Removed CS1901.
14974 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14975 for predefined types.
14977 2005-03-07 Duncan Mak <duncan@novell.com>
14979 * codegen.cs (Save): Catch UnauthorizedAccessException as
14980 well. Fixes bug #73454.
14982 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14984 * cs-tokenizer.cs (xtoken): Add CS1035.
14986 * class.cs (MethodData.Define): Add CS0683.
14987 (FieldMember.ctor): Add CS0681.
14989 2005-03-07 Raja R Harinath <rharinath@novell.com>
14991 * ecore.cs (SimpleName.DoResolve): Rename from
14992 SimpleName.DoResolveAllowStatic.
14993 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14994 Pass 'intermediate' flag to MemberStaticCheck.
14995 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14996 of "intermediate" lookups via MemberAccess.
14997 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14998 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
15000 2005-03-07 Raja R Harinath <rharinath@novell.com>
15003 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
15004 slipped in because of variable names that are identical to a
15005 builtin type's BCL equivalent ('string String;', 'int Int32;').
15006 (PropertyExpr.EmitInstance): Likewise.
15008 2005-03-04 Marek Safar <marek.safar@seznam.cz>
15010 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
15012 * report.cs (warning_ignore_table): Made public.
15014 2005-03-04 Raja R Harinath <rharinath@novell.com>
15017 * class.cs (MethodData.Emit): Pass 'container' to
15018 container.GetObsoleteAttribute instead of 'container.Parent'.
15020 2005-03-03 Marek Safar <marek.safar@seznam.cz>
15022 * cs-parser.jay: Add 1534 error test.
15024 * iterators.cs (Yield.CheckContext): Add error 1629.
15025 (Iterator.ctor): Save unsafe modifier.
15026 (MoveNextMethod.DoEmit): Restore unsafe context.
15028 * namespace.cs (UsingAlias): Better error message.
15030 2005-03-03 Dan Winship <danw@novell.com>
15032 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
15033 the warning message [#73219]
15035 2005-03-03 Raja R Harinath <rharinath@novell.com>
15037 Fix compile with MCS 1.0.0.0.
15038 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
15039 w_restore to not depend on string constant folding.
15041 2005-03-03 Raja R Harinath <rharinath@novell.com>
15043 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
15044 CS0246 check to users who passed 'silent = false'.
15045 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
15047 (SimpleName.SimpleNameResolve): Update.
15048 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
15049 (MemberAccess.IdenticalNameAndTypeName): Update.
15050 * doc.cs (FindDocumentedTypeNonArray): Update.
15052 2005-03-03 Raja R Harinath <rharinath@novell.com>
15054 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
15055 * parameters.cs (ComputeAndDefineParameters): Remove.
15056 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
15057 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
15058 Use GetParameterInfo.
15060 2005-03-02 Marek Safar <marek.safar@seznam.cz>
15062 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
15064 2005-03-02 Raja R Harinath <rharinath@novell.com>
15066 Unify DeclSpace.LookupType and DeclSpace.FindType.
15067 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
15068 is in charge of defining nested types on demand.
15069 (DeclSpace.LookupType): Use it when the current_type is a
15070 TypeBuilder. Use LookupTypeDirect for reflected types.
15071 (DeclSpace.FindType): Remove.
15072 (DeclSpace.LookupInterfaceOrClass): Likewise.
15073 (DeclSpace.DefineTypeAndParents): Likewise.
15074 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
15075 DeclSpace.LookupType.
15076 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
15077 * typemanager.cs (LookupType): Simplify.
15078 (AddUserType): Remove type from negative_hits.
15079 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
15080 * class.cs (TypeContainer.FindMembers): Move handling of nested
15082 (TypeContainer.FindMembers_NestedTypes): ... here.
15083 (TypeContainer.FindNestedType): Implement override.
15084 (ClassPart.FindNestedType): Delegate to PartialContainer.
15085 (ClassPart.PartFindNestedType): Looks up the nested types of the
15088 2005-03-02 Martin Baulig <martin@ximian.com>
15090 * class.cs (TypeContainer.DoDefineMembers): We also need a default
15091 static constructor in static classes.
15093 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
15095 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
15096 sizeParamIndex is not specified.
15098 2005-03-01 Marek Safar <marek.safar@seznam.cz>
15101 * report.cs (WarningMessage.IsEnabled): Missing null check.
15103 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15105 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
15106 in the fields and not in the properties.
15108 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
15110 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
15113 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15115 * attribute.cs: Small refactoring (improved robustness).
15116 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
15117 (ValidateGuid): Removed.
15118 (Resolve): Removed referenced to above mentioned.
15119 (GetAttributeUsage): Made private and changed to work without
15121 (GetIndexerAttributeValue): Don't crash.
15122 (GetConditionalAttributeValue): Ditto.
15123 (GetClsCompliantAttributeValue): Ditto.
15124 (ExtractSecurityPermissionSet): All attributes exceptions are
15126 (GetPropertyValue): New helper.
15127 (GetMethodImplOptions): New method.
15128 (DefinePInvokeMethod): Reuse common code. Implemented handling of
15129 some missing properties.
15131 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
15132 (Method.ApplyAttributeBuilder): Updated.
15134 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
15137 2005-02-28 Raja R Harinath <rharinath@novell.com>
15140 * report.cs (Report.SymbolRelatedToPreviousError): Handle
15141 non-simple types (array, pointer, reference).
15143 2005-02-28 Marek Safar <marek.safar@seznam.cz>
15145 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
15147 * class.cs (MethodCore.IsDuplicateImplementation): Special error
15149 (Method.CheckBase): Catch wrong destructor here.
15150 (MethodData.Define): Add errors 550, 668.
15152 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
15154 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
15156 * pending.cs (VerifyPendingMethods): Add error 551.
15158 * typemanager.cs (CSharpName): Next error report helper.
15160 2005-02-25 Marek Safar <marek.safar@seznam.cz>
15162 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
15163 attributes. Removed useless attribute double check.
15164 It saves almost 2MBs for corlib.
15166 2005-02-25 Raja R Harinath <rharinath@novell.com>
15169 * statement.cs (ExpressionStatement.Resolve): Make robust to being
15170 called twice in case of error.
15172 2005-02-23 Chris Toshok <toshok@ximian.com>
15174 Fix compiler portions of #72827.
15175 * statement.cs (Block.Emit): call Begin/EndScope on the
15176 EmitContext instead of the ILGenerator.
15178 * codegen.cs (EmitContext.BeginScope): new method, call
15179 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
15181 (EmitContext.BeginScope): same, but EndScope and CloseScope
15183 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
15184 offset and call the superclass's OpenScope(int) with it.
15185 (SymbolWriter.CloseScope): get the current il
15186 offset and call superclass's CloseScope(int) with it.
15188 2005-02-23 Marek Safar <marek.safar@seznam.cz>
15190 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
15191 CS1677 for out and ref as well.
15193 * class.cs (Method.Define): Add error CS1599 detection.
15195 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
15197 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
15199 * delegate.cs (Delegate.Define): Add error CS1599 detection.
15201 * support.cs.cs (ModifierDesc): New helper method.
15203 2005-02-23 Raja R Harinath <rharinath@novell.com>
15204 Abin Thomas <projectmonokochi@rediffmail.com>
15205 Anoob V E <projectmonokochi@rediffmail.com>
15206 Harilal P R <projectmonokochi@rediffmail.com>
15208 Fix #57851, #72718.
15209 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
15210 MemberLookup (used for error reporting) actually returns a result.
15211 Fix error report number (122, not 112).
15213 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15214 Anoob V E <projectmonokochi@rediffmail.com>
15215 Harilal P R <projectmonokochi@rediffmail.com>
15218 * pending.cs (PendingImplementation.GetAbstractMethods):
15219 Find NonPublic members too.
15221 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15223 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15226 * class.cs (MethodCore.CheckMethodAgainstBase):
15227 Add error 239 report.
15229 2005-02-21 Raja R Harinath <rharinath@novell.com>
15232 * expression.cs (Invocation.IsApplicable): Make public.
15233 (Invocation.IsParamsMethodApplicable): Likewise.
15234 * delegate.cs (Delegate.VerifyApplicability): Don't use
15235 Invocation.VerifyArgumentCompat for parameter applicability
15236 testing. Use Invocation.IsApplicable and
15237 Invocation.IsParamsMethodApplicable.
15239 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15241 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15243 * class.cs (Operator.Define): Add error 217 report.
15245 2005-02-21 Raja R Harinath <rharinath@novell.com>
15247 * namespace.cs (UsingEntry.Resolve): Undo change below.
15249 2005-02-21 Raja R Harinath <rharinath@novell.com>
15252 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15253 disable the error message when the extended MemberLookup also
15255 (Expression.MemberLookupFinal): Update.
15256 (SimpleName.DoSimpleNameResolve): Update.
15257 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15258 Don't use MemberLookupFinal.
15259 (New.DoResolve): Update.
15260 (BaseAccess.CommonResolve): Update.
15262 2005-02-21 Raja R Harinath <rharinath@novell.com>
15265 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15266 occured previously, don't resolve again.
15268 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15271 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15272 argument. Call ResolveAttributeUsage for unresolved.
15273 when types doesn't match ctor arguments.
15275 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15276 for nested attribute classes.
15277 (Class.attribute_usage): Removed.
15278 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15279 for attribute class.
15281 * ecore.cs (IsAttribute): Removed.
15283 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15285 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15287 (attribute_types): Removed.
15288 (EmitCode): Global attributes are emited as the latest.
15290 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15292 * class.cs (EmitFieldInitializers): Don't emit field initializer
15293 for default values when optimilization is on.
15295 * constant.cs (Constant.IsDefaultValue): New property.
15297 * driver.cs: Add /optimize handling.
15301 * literal.cs: Implement new IsDefaultValue property.
15303 * rootcontext.cs (Optimize): New field, holds /optimize option.
15305 2005-02-18 Raja R Harinath <rharinath@novell.com>
15307 Fix crasher in re-opened #72347.
15308 * namespace.cs (Namespace.Lookup): Return null if
15309 DeclSpace.DefineType returns null.
15312 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15314 2005-02-18 Raja R Harinath <rharinath@novell.com>
15316 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15317 now returns null if it cannot resolve to an lvalue.
15318 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15319 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15320 returned null. Remove check for SimpleName.
15321 (EventExpr.DoResolveLValue): New.
15322 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15323 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15325 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15326 avoid CS0131 error.
15327 (Unary.ResolveOperator): Move CS0211 check ...
15328 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15330 (Unary.DoResolveLValue): Simplify.
15331 (AddressOf.DoResolveLValue): New.
15332 (ArrayAccess.DoResolveLValue): New.
15334 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15336 * attribute.cs (Attribute.Resolve): Add arguments casting for
15337 when types doesn't match ctor arguments.
15339 2005-02-16 Raja R Harinath <rharinath@novell.com>
15341 Fix parts of #63202.
15342 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15343 lookup of operator in base type. Ensure that all checks happen
15344 when the operator resolves to an "op_..." method.
15346 2005-02-15 Raja R Harinath <rharinath@novell.com>
15349 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15350 'ignore_cs0104' parameter. Pass it to ...
15351 (NamespaceEntry.Lookup): ... this.
15352 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15353 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15354 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15355 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15356 Update. Request that cs0104 errors be ignored.
15357 (ComposedCast.ResolveAsTypeStep): Update.
15359 2005-02-14 Raja R Harinath <rharinath@novell.com>
15362 * expression.cs (Invocation.BetterFunction): Remove support for
15363 comparing virtual functions and their overrides.
15364 (Invocation.IsOverride): New.
15365 (Invocation.OverloadResolve): Don't consider 'override' functions
15366 during candidate selection. Store them in a lookaside list.
15367 If the selected method is a 'virtual' function, use the list to
15368 find any overrides that are closer to the LHS type.
15370 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15372 * expression.cs (New.DoResolve): Add complex core type reduction.
15373 (New.Constantify): Converts complex core type syntax like 'new int ()'
15374 to simple constant.
15376 2005-02-14 Raja R Harinath <rharinath@novell.com>
15378 * decl.cs (EntryType.EntryType): New constructor to create an
15379 updated copy of a cache entry.
15380 (MemberCache.AddMethods): Use it.
15381 (MemberCache.ClearDeclaredOnly): Remove.
15382 (MemberCache.MemberCache): Update.
15384 2005-02-11 Miguel de Icaza <miguel@novell.com>
15386 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15387 variable. This one is represents the actual low-level declaration
15388 of the method, as opposed to the semantic level `IsStatic'.
15390 An anonymous method which is hosted into a static method might be
15391 actually an instance method. IsStatic would reflect the
15392 container, while MethodIsStatic represents the actual code
15395 * expression.cs (ParameterReference): Use the new MethodIsStatic
15396 instead of IsStatic.
15398 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15399 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15400 set on the current EmitContext.
15402 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15403 resolve our casted expression as an LValue. This triggers the
15404 proper LValue processing that is later required by Assign.
15408 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15410 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15412 C# 2.0 Fixed buffer implementation
15414 * anonymous.cs: Update after RegisterHelperClass renaming.
15416 * attribute.cs (AttributeTester.fixed_buffer_cache):
15417 Cache of external fixed buffers.
15418 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15419 implementation if field is fixed buffer else null.
15422 (TypeContainer.AddField): Accept FieldMember instead of Field.
15423 (FieldBase.IsFieldClsCompliant): Extracted code from
15424 VerifyClsCompliance descendant customization.
15425 (FixedField): New class handles fixed buffer fields.
15426 (FixedFieldExternal): Keeps information about imported fixed
15428 (IFixedField): Make access to internal or external fixed buffer
15431 * cs-parser.jay: Add fixed buffer parsing.
15433 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15436 * expression.cs (Indirection): Extended implementation to accept
15437 fixed buffer field.
15438 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15439 (ElementAccess.MakePointerAccess): Get type as parameter.
15440 (DoResolve): Add fixed buffer field expression conversion.
15441 (DoResolveLValue): Ditto.
15442 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15443 (ArrayPtr): Derives from FixedBufferPtr.
15444 (ArrayPtr.Emit): Add extra emit for array elements.
15446 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15448 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15449 for compiler generated types.
15450 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15452 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15453 and consume less memory.
15454 (Fixed.Resolve): Add fixed buffer case.
15456 * typemanager.cs (compiler_generated_attr_ctor,
15457 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15458 (HasElementType): Add our own implementation to work on every
15461 2005-02-11 Miguel de Icaza <miguel@novell.com>
15463 * anonymous.cs (CaptureContext): Track whether `this' has been
15466 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15467 only captured `this' if it was implicitly done (instance
15468 methods/variables were used).
15470 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15471 `this' must be captured.
15473 2005-01-30 Miguel de Icaza <miguel@novell.com>
15475 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15476 is null it means that there has been no need to capture anything,
15477 so we just create a sibling.
15479 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15481 Just a partial fix. The other half is fairly elusive.
15483 2005-02-10 Raja R Harinath <rharinath@novell.com>
15485 Fix #52586, cs0121-4.cs.
15486 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15487 and return a hashtable.
15488 (MemberCache.ClearDeclaredOnly): New.
15489 (MemberCache.MemberCache): Update to change. Make a deep copy of
15490 the method_hash of a base type too.
15491 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15492 type methods. Overwrite entries with the same MethodHandle so
15493 that the ReflectedType is correct. The process leaves in base
15494 virtual functions and their overrides as distinct entries.
15495 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15496 matters since it was boxed in a ArrayList before.
15497 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15499 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15500 case of a virtual function and its override (choose the overload
15502 (Invocation.OverloadResolve): Avoid 'override' members during
15503 'applicable_type' calculation.
15505 2005-02-09 Raja R Harinath <rharinath@novell.com>
15507 Combine two near-redundant caches.
15508 * typemanager.cs (method_params): Rename from method_internal_params.
15509 (TypeManager.GetParameterData): New. Replace
15510 Invocation.GetParameterData.
15511 (TypeManager.LookupParametersByBuilder): Remove.
15512 * expression.cs (Invocation.method_parameter_cache): Remove.
15513 (Invocation.GetParameterData): Remove.
15515 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15518 2005-02-08 Raja R Harinath <rharinath@novell.com>
15521 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15522 TypeManager.multicast_delegate_type is null, resolve it by looking
15523 up "System.MulticastDelegate".
15524 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15526 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15527 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15528 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15531 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15532 (LabeledStatement.AddReference): New. Set 'referenced'.
15533 (Goto.Resolve): Use it.
15535 2005-02-05 John Luke <john.luke@gmail.com>
15537 * driver.cs: remove duplicate -doc line in Usage ()
15539 2005-02-04 Raja R Harinath <rharinath@novell.com>
15541 * location.cs (Location.AddFile): Fix CS2002 error report.
15543 2005-02-02 Martin Baulig <martin@ximian.com>
15545 * delegate.cs (Delegate.DefineType): Report an internal error if
15546 TypeManager.multicast_delegate_type is null. See bug #72015 for
15549 2005-02-02 Raja R Harinath <rharinath@novell.com>
15551 Fix a crasher in a variant of #31984.
15552 * const.cs (Constant.CheckBase): New override that defers the
15553 new-or-override check in case the base type hasn't been populated
15555 (Constant.Define): Ensure the new-or-override check is performed.
15557 2005-02-01 Duncan Mak <duncan@ximian.com>
15559 * const.cs (LookupConstantValue): Check that `ce' is not null
15560 before calling GetValue ().
15562 2005-02-01 Raja R Harinath <rharinath@novell.com>
15564 Fix test-334.cs (#69519).
15565 * cs-parser.jay (using_alias_directive): Pass in an expression to
15566 NamespaceEntry.UsingAlias.
15567 (using_namespace_directive): Pass in an expression to
15568 NamespaceEntry.Using.
15569 (namespace_name): Don't flatten to a string.
15570 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15571 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15573 (NamespaceEntry.UsingEntry): Likewise.
15574 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15576 (NamespaceEntry.LookupForUsing): Remove.
15577 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15579 (NamespaceEntry.Lookup): Remove support for dotted names.
15581 2005-02-01 Raja R Harinath <rharinath@novell.com>
15583 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15585 (NamespaceEntry.ImplicitParent): Compute on demand.
15586 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15587 parallels the current.
15588 (NamespaceEntry.LookupForUsing): Use it.
15589 (NamespaceEntry.Lookup): If the current namespace-entry is
15590 implicit, don't search aliases and using tables.
15592 2005-02-01 Raja R Harinath <rharinath@novell.com>
15595 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15597 (TypeContainer.BaseCache): Compute on demand.
15598 (TypeContainer.FindMembers): Define constants and types if they're
15599 not already created.
15600 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15602 * const.cs (Constant.Define): Make idempotent.
15604 2005-01-29 Miguel de Icaza <miguel@novell.com>
15606 * pending.cs: Produce better code (no nops produced by using Ldarg
15609 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15610 i - 1' it should be arg + 1.
15614 2005-01-28 Raja R Harinath <rharinath@novell.com>
15616 * attribute.cs (Attribute.CheckAttributeType): Make private
15618 (Attribute.ResolveType): Make virtual.
15619 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15620 handling of RootContext.Tree.Types.
15622 2005-01-27 Raja R Harinath <rharinath@novell.com>
15624 Update attribute-handling to use the SimpleName/MemberAccess
15626 * cs-parser.jay (attribute): Pass in an expression to the
15627 constructors of Attribute and GlobalAttribute.
15628 * attribute.cs (Attribute): Take an expression for the name.
15629 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15630 passed in attribute name expression.
15631 (Attribute.CheckAttributeType): Use it.
15632 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15633 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15634 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15635 argument to prevent error messages if the lookup fails.
15637 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15639 * expression.cs (Indirection): Implemented IVariable interface
15640 to support indirection in AddressOf operator.
15641 (PointerArithmetic.Emit): Add optimalization for case where
15642 result can be precomputed.
15644 2005-01-26 Martin Baulig <martin@ximian.com>
15646 * class.cs (TypeContainer.AttributeTargets): Return the correct
15647 AttributeTargets depending on our `Kind' instead of throwing an
15648 exception; fixes #71632.
15650 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15653 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15656 2005-01-25 Raja R Harinath <rharinath@novell.com>
15659 * expression.cs (MemberAccess.DoResolve): Don't complain with
15660 cs0572 when the LHS of a member access has identical name and type
15663 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15666 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15668 Create custom PermissionSet only for PermissionSetAttribute.
15670 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15673 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15674 delegates in static class.
15676 2005-01-24 Martin Baulig <martin@ximian.com>
15678 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15679 merging an implicit block, just use its reachability.
15681 * statement.cs (Block.Resolve): Make the unreachable code check
15682 work wrt. implicit blocks; see test-337 from #63842.
15684 2005-01-21 Alp Toker <alp@atoker.com>
15686 * cs-parser.jay: destructor_declaration's container is PartialContainer
15687 not Class when partial types are used, so use Kind prop instead of
15690 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15692 * cs-parser.jay: Improve error reporting when an interface
15693 declares new types.
15695 2005-01-20 Dick Porter <dick@ximian.com>
15697 * support.cs: SeekableStreamReader fix from Sandor Dobos
15698 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15699 chars are read. Fixes bug 70369.
15701 2005-01-20 Raja R Harinath <rharinath@novell.com>
15703 * cs-parser.jay (catch_clause): Simplify current_block handling
15706 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15708 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15709 code with ImplicitStandardConversion to handle the implicit
15710 conversion of method groups into valid delegate invocations.
15712 The problem is that in parameter handling we were using this code
15713 path. Fixes bug #64698
15715 2005-01-19 Raja R Harinath <rharinath@novell.com>
15717 * cs-parser.jay: Fix several infelicities.
15718 - Avoid assigning to the parser value stack. Code like
15719 '$3 = null' is unclean. Synthesize a value for the code block
15721 - Avoid using oob_stack for storing location information. Use ...
15722 (_mark_): ... this. New (empty) rule. Saves the current location
15724 (foreach_statement): Avoid using oob_stack for current_block
15725 handling. Use technique used in for_statement and
15726 using_statement. Synthesize a value for the code block to store
15727 additional intermediate information.
15729 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15731 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15732 of a different type is only allowed to private fields of a
15733 containing type, not on fields of a base class.
15735 See test-174.cs and error cs0122-9.cs
15737 2005-01-13 Raja R Harinath <rharinath@novell.com>
15739 Fix test-335.cs (bug #58126).
15740 * cs-parser.jay (argument): Split out non-expression parts of the
15741 rule into 'non_simple_argument'.
15742 (invocation_expression): Support parenthesized invocations with
15743 multiple arguments, and with single non-simple arguments.
15745 2005-01-13 Raja R Harinath <rharinath@novell.com>
15747 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15750 2005-01-12 Raja R Harinath <rharinath@novell.com>
15752 Fix cs0038-1.cs, cs1640-6.cs.
15753 * ecore.cs (Expression.Resolve): Remove special-case for
15754 SimpleName in error-handling.
15755 (Expression.almostMatchedMembers): Relax access permission to
15757 (Expression.MemberLookupFailed): Handle duplicates in
15758 almostMatchedMembers list.
15759 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15760 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15761 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15762 overload if the passed in MemberInfo is a MethodBase.
15764 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15767 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15768 for non-CAS & merge permission sets properly.
15770 2005-01-11 Raja R Harinath <rharinath@novell.com>
15772 Improve standard-compliance of simple name and member access
15773 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15774 * ecore.cs (FullNamedExpression): New abstract base class
15775 for Namespaces and TypeExpressions.
15776 (ResolveFlags.SimpleName): Remove.
15777 (SimpleName): Remove support for dotted names.
15778 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15779 DeclSpace.FindType and DeclSpace.LookupType.
15780 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15781 (Expression.ExprClassName): Make member function.
15782 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15783 a namespace. Remove creation of dotted "SimpleName"s.
15784 (MemberAccess.DoResolve): Likewise.
15785 * decl.cs (DeclSpace.Cache): Make private.
15786 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15787 (DeclSpace.FindType): Update.
15788 (DeclSpace.LookupType): Move here from RootContext. Return a
15789 FullNamedExpression.
15790 * namespace.cs (Namespace): Derive from FullNamedExpression
15791 so that it can be part of expression resolution.
15792 (Namespace.Lookup): Return an FullNamedExpression.
15793 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15795 * rootcontext.cs (NamespaceLookup): Remove.
15796 (LookupType): Move to DeclSpace.
15797 * attribute.cs (CheckAttributeType): Update.
15798 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15799 (FindDocumentedTypeNonArray): Likewise.
15801 2005-01-11 Raja R Harinath <rharinath@novell.com>
15803 Fix cs0509.cs, cs1632.cs.
15804 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15805 is the same as IsInterface.
15806 (TypeContainer.GetClassBases): Likewise.
15807 * statement.cs (LabeledStatement.ig): New field.
15808 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15810 (LabeledStatement.DoEmit): Check that the label was created with
15811 the same ILGenerator.
15813 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15816 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15817 accessors to its properties.
15819 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15820 from accessors to property.
15822 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15825 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15826 only for overrides.
15828 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15830 * attribute.cs: Check for null and empty strings.
15832 I have lost another battle to Paolo.
15834 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15837 * class.cs (PropertyMethod): Set Parent field in ctors.
15838 (SetMethod.InternalParameters): Add unsafe switch hack.
15839 Override MarkForDuplicationCheck where it is appropriate.
15841 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15842 It says whether container allows members with the same name.
15843 Base default is no.
15844 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15845 Removed is_method parameter.
15847 2005-01-06 Duncan Mak <duncan@ximian.com>
15849 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15850 because the previous change led to incorrect reporting of CS1032
15851 ("Cannot define/undefine preprocessor symbols after first token in
15852 file"). Instead of using `tokens_seen' as the only flag that
15853 triggers CS1040, introduce `comments_seen'. This new flag is used
15854 to signify having seen comments on the current line, so it is
15855 unset after a newline.
15857 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15859 * doc.cs : When searching for a type, find nested type too.
15860 This fixes bug #71040.
15862 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15865 - Warn missing member comment on those classes which also does not
15866 have doc comments. Fixed bug #71041.
15867 - Don't warn missing doc comment on default constructor.
15870 2005-01-06 Duncan Mak <duncan@ximian.com>
15872 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15873 comments, set `tokens_seen' to true. This allows us to detect
15874 misplaced preprocessor directives (i.e. not at the beginning of
15875 the a line, nor after whitespaces). In that case, report error
15876 CS1040. This fixes bug #56460.
15878 * cs-parser.jay (interface_member_declaration): Add checks for
15879 IsExplicitImpl, and report CS0541 error if an interface member is
15880 defined as an explicit interface declaration.
15882 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15885 * class.cs (PropertyMethod): Set Parent field in ctors.
15886 (SetMethod.InternalParameters): Add unsafe switch hack.
15888 * decl.cs (MemberCore.Parent): Cannot be readonly.
15890 2005-01-06 Raja R Harinath <rharinath@novell.com>
15892 * decl.cs (DeclSpace.ResolveType): Remove.
15893 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15894 Merge in code from ...
15895 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15896 * class.cs, enum.cs: Update to changes.
15898 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15900 * anonymous.cs: Ensure that we init the scope of our parent if it
15901 has not been initialized yet.
15903 2004-12-30 Duncan Mak <duncan@ximian.com>
15905 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15906 if field.FieldBuilder is null. Fixes #70758.
15908 * convert.cs: Fixed some typos and updated some of the comments.
15909 (ImplicitStandardConversionExists):
15910 (TryImplicitIntConversion): If `target_type' is an interface and
15911 the type of `ic' implements this interface, return true or a new
15912 BoxedCast instead of null. This fixes #70468.
15914 2004-12-29 Duncan Mak <duncan@ximian.com>
15916 * expression.cs (Argument.Emit): Check that Expr is
15917 IMemoryLocation before casting to it, and report CS1510 otherwise.
15921 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15923 * statement.cs (Block.ThisVariable): remove the recursion here, to
15924 make the --profile more sane.
15926 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15928 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15929 assembly, by JB Evain.
15931 2004-12-17 Raja R Harinath <rharinath@novell.com>
15933 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15934 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15935 "parent" refers to enclosing type/class. "base" refers to superclass.
15937 2004-12-17 Raja R Harinath <rharinath@novell.com>
15939 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15940 Ensure that we only have GlobalAttributes.
15941 * attribute.cs (Attribute.Emit): Make non-virtual.
15942 (GlobalAttribute.Emit): Remove.
15943 (Attribute.Resolve): Make virtual.
15944 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15945 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15946 the argument. Don't create one.
15947 (Attribute.GetObsoleteAttribute): Likewise.
15948 (Attribute.GetClsCompliantAttributeValue): Likewise.
15949 * class.cs, decl.cs: Update to changes.
15951 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15953 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15955 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15957 * statement.cs (Foreach.Resolve): Add error 186 report.
15959 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15961 * expression.cs (Conditional.DoResolve): Add warning 429.
15963 * statement.cs (If.Resolve): Add warning 665.
15965 2004-12-16 Raja R Harinath <rharinath@novell.com>
15967 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15968 except when in the parser, and in GlobalAttribute.
15969 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15970 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15971 RootContext.Tree.Types.NamespaceEntry once work is done.
15972 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15973 and resets RootContext.Tree.Types.NamespaceEntry.
15975 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15977 * cs-parser.jay: Don't create a block for every variable.
15979 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15981 * location.cs: Provide extra information.
15983 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15984 variables from the captured environment, it is the ldarg_0.
15986 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15988 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15991 * class.cs: Changed warning level for 169 to avoid developer
15992 displeasure from warning flooding. It will be changed back when they
15993 fix most of current BCL warnings.
15995 * RootContext.cs: Pushed default WarningLevel to 3.
15997 * statement.cs: Removed unused variable.
15999 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16001 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
16002 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
16003 Add error 502 report.
16004 (StaticClass.DefineType): Add error 441 report.
16005 (Class.AllowedModifiersProp): New virtual property as temporary
16006 extension to AllowedModifiers.
16007 (Class.DefineType): Add error 418 report. Moved ModFlags check here
16008 to share implementation with StaticClass and don't call virtual
16011 * driver.cs (MainDriver): Add error 1558 test.
16013 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
16014 report. Moved error 36 test here.
16016 * statement.cs (Throw.Resolve): Add error 724 report.
16018 * typemanager.cs: Add out_attribute_type core type.
16020 2004-12-13 Marek Safar <marek.safar@seznam.cz>
16022 * class.cs (TypeContainer.VerifyClsCompliance): Add error
16024 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
16026 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
16029 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
16031 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
16032 Add error 3023 report.
16033 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
16035 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
16038 2004-12-12 John Luke <john.luke@gmail.com>
16040 * driver.cs (AddArgs): take -- into account when
16041 adding arguments, fixes bug 65710
16043 2004-12-12 Martin Baulig <martin@ximian.com>
16045 * expression.cs (Unary.TryReduceNegative): Added support for
16046 SByteConstant and ByteConstant.
16047 (Unary.Reduce): Check error values from TryReduceNegative().
16049 2004-12-10 Marek Safar <marek.safar@seznam.cz>
16051 * attributes.cs (Attribute.Resolve): Avoid multiple error report
16052 and report exception as error 182.
16054 2004-12-10 Raja R Harinath <rharinath@novell.com>
16056 * driver.cs (Main): Fix message when there are warnings.
16058 2004-12-09 Miguel de Icaza <miguel@ximian.com>
16060 * delegate.cs: Fixed my fix from yesterday, sorry about that.
16062 2004-12-09 Marek Safar <marek.safar@seznam.cz>
16064 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
16065 Reduced number of warnings.
16067 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
16069 2004-12-08 Miguel de Icaza <miguel@ximian.com>
16071 * driver.cs: Removed message.
16073 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
16075 2004-12-08 <vargaz@freemail.hu>
16077 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
16079 2004-12-08 Martin Baulig <martin@ximian.com>
16081 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
16082 instead of a CS3002 for properties and indexer.
16084 2004-12-08 Martin Baulig <martin@ximian.com>
16086 * decl.cs (MemberName.ToString): Make this work again.
16088 2004-12-08 Marek Safar <marek.safar@seznam.cz>
16090 * attribute.cs (Resolve): Add error 591 detection.
16092 * class.cs (FieldMember.Define): Add error 1547 detection.
16093 (Indexer.Define): Add error 620 detection.
16094 (Operator.Define): Add error 590 detection.
16096 * ecore.cs: Missing argument for error 79.
16098 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
16101 2004-12-07 Marek Safar <marek.safar@seznam.cz>
16104 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
16107 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
16109 * cs-parser.jay : handle doc comments on implicit/explicit operators.
16110 Some operator comments were suppressed.
16111 * doc.cs : Implicit/explicit operator name in doc comments are like
16112 "op_Explicit(type)~returnType", so added suffix handling.
16114 2004-12-07 Martin Baulig <martin@ximian.com>
16117 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
16118 (MemberCore.GetClsCompliantAttributeValue): Likewise.
16119 (DeclSpace.ec): New protected field; store the EmitContext here.
16120 (DeclSpace.EmitContext): New public property; moved here from
16122 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
16125 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
16126 (Enum.Emit): Don't create a new EmitContext.
16128 * delegate.cs (Delegate.DefineType): Always create the
16131 * iterators.cs (Iterators.DefineIterator): Create a new
16132 EmitContext and store it in `ec'.
16134 2004-08-24 Martin Baulig <martin@ximian.com>
16137 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
16138 this for accessibility checks.
16139 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
16140 IsNestedFamilyAccessible.
16141 (TypeManager.IsSubclassOf): New method, do what the name actually
16144 2004-12-06 Raja R Harinath <rharinath@novell.com>
16146 Fix crash on cs0657-17.cs.
16147 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
16148 Use RootContext.Tree.Types, not 'new RootTypes ()'.
16149 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
16150 the case where the NamespaceEntry gets overwritten.
16152 2004-12-06 Marek Safar <marek.safar@seznam.cz>
16154 Fixed #69195, #56821
16155 * ecore.cs (ResolveBoolean): Tiny refactoring.
16157 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
16158 of right expression resolving when left is false constant and
16159 operator is LogicalAnd OR true constant and operator is LogicalOr.
16161 * statement.cs (ResolveUnreachable): Always reports warning.
16163 2004-12-05 Miguel de Icaza <miguel@ximian.com>
16165 * class.cs: Distinguish between 1721 and 1722 (just a little help
16166 for the programmer).
16168 2004-12-03 Miguel de Icaza <miguel@ximian.com>
16170 * delegate.cs: Only allow this on new versions of the language.
16172 2004-12-02 Duncan Mak <duncan@ximian.com>
16174 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
16176 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
16177 here as a static method. Take an additional bool out parameter
16178 `must_do_cs1540_check' for signaling to InstanceResolve.
16179 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
16180 member field from PropertyExpr class and made it an argument of
16181 the method instead.
16182 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
16183 check for MarshalByRefObject, and report CS0122 instead of CS1540.
16184 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
16185 and `remove_accessor' as well as InstanceResolve: report CS0122
16190 2004-12-03 Raja R Harinath <rharinath@novell.com>
16192 Fix test-327.cs, test-328.cs, and put in early infrastructure
16193 for eventually fixing #52697.
16194 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
16195 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
16196 from other methods.
16197 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
16198 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
16199 (VerifyUsing, error246): Update.
16200 * rootcontext.cs (RootContext.NamespaceLookup): Just use
16201 'NamespaceEntry.LookupNamespaceOrType'.
16203 2004-12-03 Martin Baulig <martin@ximian.com>
16205 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16206 method as our child, call AnonymousMethod.Compatible() on it.
16208 2004-12-03 Raja R Harinath <rharinath@novell.com>
16210 Disable XML documentation support in 'basic' profile.
16211 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16212 Redirect XmlElement to System.Object.
16213 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16214 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16215 * mcs.exe.sources: Add doc-bootstrap.cs.
16216 * doc-bootstrap.cs: New file. Contains empty stub implementation
16219 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16221 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16222 comments are allowed.
16224 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16226 * delegate.cs: Add checks for subtypes in paramaters and return values
16227 in VerifyMethod () to add support for Covariance/Contravariance
16230 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16232 * report.cs: Remove extra closing parenthesis.
16234 * convert.cs (Error_CannotImplicitConversion): If the name of the
16235 types are the same, provide some extra information.
16237 * class.cs (FieldBase): Use an unused bit field from the field to
16238 encode the `has_offset' property from the FieldMember. This saves
16239 a couple of Ks on bootstrap compilation.
16241 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16242 method as our child, return the AnonymousMethod resolved
16245 * expression.cs (New.DoResolve): Allow return values from
16246 NewDelegate to also include AnonymousMethods.
16250 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16253 * attribute.cs (Resolve): Improved implementation of params
16254 attribute arguments.
16256 * support.cs (ParameterData): Add HasParams to be faster.
16258 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16260 all things are for /doc support:
16262 * doc.cs: new file that supports XML documentation generation.
16263 * mcs.exe.sources: added doc.cs.
16265 Handle /doc command line option.
16266 Report error 2006 instead of 5 for missing file name for /doc.
16267 Generate XML documentation when required, after type resolution.
16269 Added support for picking up documentation (/// and /** ... */),
16270 including a new XmlCommentState enumeration.
16272 Added lines to fill Documentation element for field, constant,
16273 property, indexer, method, constructor, destructor, operator, event
16274 and class, struct, interface, delegate, enum.
16275 Added lines to warn incorrect comment.
16277 Added Documentation field (passed only when /doc was specified).
16279 Added DocComment, DocCommentHeader, GenerateDocComment() and
16280 OnGenerateDocComment() and some supporting private members for
16281 /doc feature to MemberCore.
16283 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16285 Added overriden DocCommentHeader.
16287 Added overriden DocCommentHeader and GenerateDocComment().
16289 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16291 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16292 unwrapping the enumeration values, chain to
16293 DoConstantNumericPromotions again, so we can promote things to the
16294 fundamental types (takes care of enums that are bytes, sbytes).
16298 2004-12-01 Raja R Harinath <rharinath@novell.com>
16300 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16301 Fix long-standing bug in type-lookup. Use FindType instead of
16302 LookupType when ec.ResolvingTypeTree.
16303 (Attribute.ResolveType, Attribute.Resolve)
16304 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16306 (Attributes.Search): Remove internal version. Update.
16307 (Attributes.SearchMulti): Update.
16308 (Attributes.GetClsCompliantAttribute): Remove.
16309 (Attributes.GetIndexerNameAttribute): Remove.
16310 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16311 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16312 * class.cs (Indexer.Define): Likewise.
16314 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16317 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16318 MarshallByReference members access.
16320 * expression.cs: Use CheckMarshallByRefAccess;
16321 Better error CS0197 message.
16323 * report.cs: Print whole related error message.
16325 2004-11-30 Raja R Harinath <rharinath@novell.com>
16327 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16328 the current directory to help debugging.
16330 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16332 * class (GetClassBases): Better error 60 report.
16333 (EventProperty): Disabled warning 67 detection.
16335 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16338 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16340 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16343 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16346 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16348 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16350 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16352 * attribute.cs (Attribute.Resolve): Refine error reporting and
16353 report a cs0117 if the identifier does not exist, to distinguish
16354 from 0617 which is a miss-use of the actual identifier.
16356 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16357 between cs0070 and cs0079.
16359 * class.cs (MemberBase.DoDefine): When reporting a wrong
16360 accessibility level, we use MethodCore to compare instead of
16361 Method (this was a regression in some refactoring effort).
16363 So now we correctly report cs0056 again.
16365 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16366 testing the target_type (which was known to be object_type) and
16367 not the source type (which is anonymous_method).
16369 Fixed reporting of error cs1660.
16371 * expression.cs (UserCast.Source): Expose the underlying cast.
16373 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16374 allowed types to find a match to int32 first (most common).
16376 In addition, it ignores any ImplicitUserConversions that did an
16377 internal implicit conversion (as the switch statement allows only
16378 one integral conversion to exist).
16380 * class.cs (PartialContainer.Create): rename `name' to
16381 `member_name' for clarity. Then replace the string calls with a
16382 call to MemberName.GetPartialName, as now using
16383 MemberName.ToString is an error (this is due to the side effects
16384 it had, that were fixed in the past).
16386 This will restore the error reporting on a number of partial class
16387 errors that were missusing this (and getting an exception as a
16388 results, which is now just a plain textual warning, because
16389 yyparse debug output would crash otherwise).
16391 2004-11-26 Raja R Harinath <rharinath@novell.com>
16393 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16395 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16397 * rootcontext.cs (LookupType): Make sure to cache lookups that
16398 don't give us a negative result. This saves about 5% of corlib
16401 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16403 * report.cs (AbstractMessage.Print): messages are sent to stderr
16405 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16406 non-interface in the list of interfaces (at this point, either
16407 parent was properly set, or a base class is being listed in the
16408 interfaces section).
16410 This flags error 1722, and resolves the crash from bug 69259.
16412 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16414 * statement.cs (Using.EmitExpressionFinally): make this work right
16415 for valuetypes. Fixes 69926.
16417 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16419 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16420 converted to an enum" here, before we try to change the underlying
16421 type. This code exists, but it is a different code path than the
16422 one used while encoding constants.
16424 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16425 old bug: when converting from the null literal to a pointer,
16426 return an EmptyCast, not the NullLiteral.
16428 This fixes #69921, the recent null_type changes probably made this
16429 bug more prominent.
16431 (ImplicitReferenceConversionExists): In addition, resynchronized
16432 the code here, so it matches the same code in
16433 ImplicitReferenceConversionExists for the `from any class-type S
16434 to any interface-type T'.
16437 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16439 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16441 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16443 * cs-parser.jay: Use verbosity accordingly.
16445 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16447 * expression.cs (Unary.ResolveOperator): Do not report warning;
16448 AddressOf reads from variable.
16450 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16452 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16456 * attribute.cs (Attributable): Removed CheckTargets.
16457 (Attributes.Emit): Explicit attribute targets are tested here.
16459 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16460 not enabled for interfaces.
16462 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16463 (GetAssemblyName): Ouch next bug there.
16465 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16467 * expression.cs: Error 275 added.
16469 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16471 Fix bug #69177 (Implemented decimal constant support)
16473 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16474 (BinaryFold): Add DecimalConstant.
16476 * const.cs (Define): Decimal constant
16478 (ChangeType): Add decimal type handling.
16479 (LookupConstantValue): Don't set value for decimal type but
16480 emit DecimalConstantAttribute. Needed for constant optimization.
16482 * constant.cs (ToDecimal): New method.
16483 (ConvertToDecimal): New method.
16484 (IntConstant): Implemented ConvertToDecimal.
16485 (DecimalConstant.Emit): Emit optimized version for decimals in
16488 * expression.cs (ResolveOperator): Changed order of constant
16489 reduction to work correctly with native types which have
16490 overloaded operators.
16491 (ResolveMemberAccess): Extract constant value from attribute
16494 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16496 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16497 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16498 (ChangeType): Decimal is special.
16499 (TypeToCoreType): Add decimal type.
16501 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16503 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16506 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16508 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16511 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16513 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16515 * pending.cs (PendingImplementation): Grab only interfaces.
16517 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16519 * statement.cs (ForeachHelperMethods): Add location member and
16520 error 202 detection.
16522 2004-11-19 Raja R Harinath <rharinath@novell.com>
16524 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16525 automatically handled by executable.make.
16526 (PROGRAM): Make profile-specific.
16528 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16530 * expression.cs (DoResolveBase): Fixed wrong warning for out
16533 2004-11-18 Martin Baulig <martin@ximian.com>
16535 Merged latest changes into gmcs. Please keep this comment in
16536 here, it makes it easier for me to see what changed in MCS since
16537 the last time I merged.
16539 2004-11-17 Raja R Harinath <rharinath@novell.com>
16541 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16542 (TypeHandle.GetMemberCache): New.
16543 (TypeHandle.TypeHandle): Update.
16544 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16545 (TypeManager.LookupParentInterfacesCache):
16546 Rename from LookupInterfaceCache. Optimize slightly.
16547 (TypeManager.MemberLookup_FindMembers): Update.
16548 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16549 multi-type variant.
16550 (AddCacheContents): Rename from AddHashtable.
16551 * class.cs (TypeContainer.parent_container): Remove.
16552 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16553 (TypeContainer.DoDefineMembers): Don't initialize it.
16554 Update to name changes.
16556 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16558 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16559 that factors the code to check access modifiers on override.
16561 (PropertyBase): Use the code here.
16563 Patch from Lluis S'anchez, fixes bug #69361.
16565 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16567 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16568 routine that is used to report the use of a captured variable
16569 whose address has been taken.
16571 There are two checks: one when variables are being captured and
16572 the other check is when the address of a variable is taken.
16574 (because an anonymous methods might be resolved before *or* after
16575 the address has been taken) and
16577 * expression.cs (Conditional.DoResolve): Remove the special
16578 casing that Martin added to trueExpr and falseExpr being both
16579 NullLiteral. We get the right behavior now just by introducing
16580 the null_type into the compiler.
16582 * convert.cs (ExplicitConversion): Change the code to use
16583 null_type instead of testing `expr is NullLiteral'.
16584 (ImplicitConversionStandard): use null_type too.
16585 (ImplicitReferenceConversionExists): use null_type too.
16586 (ImplicitReferenceConversion): use null_type too.
16588 * literal.cs: The type of `NullLiteral' is now null_type instead
16590 (Resolve): Set the type here.
16592 * typemanager.cs: Introduce null_type.
16594 2004-11-17 Martin Baulig <martin@ximian.com>
16596 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16597 direction, like FindMembers() does. Fixes #69546, testcase is in
16600 2004-11-16 Martin Baulig <martin@ximian.com>
16602 This is based on a patch from Marek Safar, see bug #69082.
16603 Fixes bugs #63705 and #67130.
16605 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16606 method; create a MemberCache for an interface type and cache the
16609 * decl.cs (IMemberContainer.ParentContainer): Removed.
16610 (IMemberContainer.ParentCache): New property.
16611 (MemberCache.SetupCacheForInterface): Removed.
16612 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16613 to create a cache for an interface's "parent".
16615 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16618 2004-11-16 Martin Baulig <martin@ximian.com>
16620 Merged back from gmcs; these changes already went into gmcs a
16621 couple of weeks ago.
16624 (TypeManager.AddUserType): Removed the `ifaces' argument.
16625 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16627 (TypeManager.AddUserInterface): Removed.
16628 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16630 (TypeManager.GetInterfaces): Likewise.
16631 (TypeManager.GetExplicitInterfaces): Likewise.
16633 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16635 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16636 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16638 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16640 * statement.cs: Avoid adding bools to a hashtable.
16642 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16644 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16645 calling an unsafe method from a safe location.
16647 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16650 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16652 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16654 * namespace.cs (VerifyUsing): use GetPartialName instead of
16657 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16659 * statement.cs (Return.Resolve): Fix regression in typo: if
16660 `in_exc', we have to request a NeedReturnLabel, this was a typo
16661 introduced in the anonymous method check-in. Fixes #69131.
16663 * Indexers were using the ShortName when defining themselves,
16664 causing a regression in the compiler bootstrap when applying the
16665 patch from 2004-11-02 (first part), now they use their full name
16666 and the bug is gone.
16668 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16670 * driver.cs: Strip the path from the names of embedded resources. Fixes
16673 2004-11-04 Raja R Harinath <rharinath@novell.com>
16675 Fix error message regression: cs0104-2.cs.
16676 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16677 (AliasEntry.Resolve): Update.
16678 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16680 (RootContext.LookupType): Update.
16682 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16684 * cs-parser.jay: Add support for handling accessor modifiers
16685 * class: Add support port accessor modifiers and error checking,
16686 define PropertyMethod.Define as virtual (not abstract anymore)
16687 * ecore.cs: Add checking for proeprties access with access modifiers
16688 * iterators.cs: Modify Accessor constructor call based in the modified
16690 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16692 * expression.cs (StringConcat): Handle being called twice,
16693 as when we have a concat in a field init with more than two
16696 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16698 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16699 special case explicit implementations, we should always produce
16700 the .property or .event declaration.
16702 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16703 since it will not return correct data if people use this
16704 unresolved in the presence of using statements (see test-313).
16706 * class.cs (MethodData.Define): If we are an explicit interface
16707 implementation, set the method name to the full name of the
16708 interface plus the name of the method.
16710 Notice that using the method.MethodName.GetFullName() does not
16711 work, as it will only contain the name as declared on the source
16712 file (it can be a shorthand in the presence of using statements)
16713 and not the fully qualifed type name, for example:
16717 class D : ICloneable {
16718 object ICloneable.Clone () {
16722 Would produce a method called `ICloneable.Clone' instead of
16723 `System.ICloneable.Clone'.
16725 * namespace.cs (Alias.Resolve): Use GetPartialName.
16727 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16729 * cs-parser.jay: Add error 1055 report.
16731 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16733 * assign.cs (Assign.DoResolve): Only do the transform of
16734 assignment into a New if the types are compatible, if not, fall
16735 through and let the implicit code deal with the errors and with
16736 the necessary conversions.
16738 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16740 * cs-parser.jay: Add error 1031 report.
16742 * cs-tokenizer.cs: Add location for error 1038.
16744 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16746 * cs-parser.jay: Add error 1016 report.
16748 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16750 * cs-parser.jay: Add errors 1575,1611 report.
16752 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16754 * cs-parser.jay: Add error 1001 report.
16756 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16759 * attribute.cs (GetMarshal): Add method argument for
16760 caller identification.
16762 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16763 agument for GetMarshal and RuntimeMissingSupport.
16765 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16767 * attribute.cs (ExtractSecurityPermissionSet): Removed
16768 TypeManager.code_access_permission_type.
16770 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16772 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16774 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16775 for obsolete use of a variable here. Fixes regression on errors
16776 cs0619-25 and cs0619-26.
16778 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16780 Fix #62358, implemented security attribute encoding.
16782 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16783 Tests permitted SecurityAction for assembly or other types.
16784 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16785 data from SecurityPermissionAttribute to PermisionSet class.
16787 * class.cs (ApplyAttributeBuilder): Added special handling
16788 for System.Security.Permissions.SecurityAttribute based types.
16790 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16791 special handling for System.Security.Permissions.SecurityAttribute
16794 * enum.cs (ApplyAttributeBuilder): Added special handling
16795 for System.Security.Permissions.SecurityAttribute based types.
16797 * parameter.cs (ApplyAttributeBuilder): Added special handling
16798 for System.Security.Permissions.SecurityAttribute based types.
16800 * rootcontext.cs: Next 2 core types.
16802 * typemanager.cs (TypeManager.security_permission_attr_type):
16803 Built in type for the SecurityPermission Attribute.
16804 (code_access_permission_type): Build in type.
16806 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16808 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16809 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16810 all of this information into
16811 EmitContext.EmitCapturedVariableInstance.
16813 * codegen.cs (EmitCapturedVariableInstance): move here the
16814 funcionality of emitting an ldarg.0 in the presence of a
16815 remapping. This centralizes the instance emit code.
16817 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16818 then emit a load of this: it means that we have reached the
16819 topmost ScopeInfo: the one that contains the pointer to the
16820 instance of the class hosting the anonymous method.
16822 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16823 captures to the topmost CaptureContext.
16825 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16827 * expression.cs (LocalVariableReference): Move the knowledge about
16828 the iterators into codegen's EmitCapturedVariableInstance.
16830 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16832 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16833 all code paths return a value from an anonymous method (it is the
16834 same as the 161 error, but for anonymous methods).
16836 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16838 The introduction of anonymous methods in the compiler changed
16839 various ways of doing things in the compiler. The most
16840 significant one is the hard split between the resolution phase
16841 and the emission phases of the compiler.
16843 For instance, routines that referenced local variables no
16844 longer can safely create temporary variables during the
16845 resolution phase: they must do so from the emission phase,
16846 since the variable might have been "captured", hence access to
16847 it can not be done with the local-variable operations from the runtime.
16851 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16852 is a toplevel block.
16854 (ToplevelBlock): A new kind of Block, these are the blocks that
16855 are created by the parser for all toplevel method bodies. These
16856 include methods, accessors and anonymous methods.
16858 These contain some extra information not found in regular blocks:
16859 A pointer to an optional CaptureContext (for tracking captured
16860 local variables and parameters). A pointer to the parent
16863 (Return.Resolve): Catch missmatches when returning a value from an
16864 anonymous method (error 1662).
16865 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16868 (Break.Resolve): ditto.
16870 (SwitchLabel): instead of defining the labels during the
16871 resolution phase, we now turned the public ILLabel and ILLabelCode
16872 labels into methods called GetILLabelCode() and GetILLabel() that
16873 only define the label during the Emit phase.
16875 (GotoCase): Track the SwitchLabel instead of the computed label
16876 (its contained therein). Emit the code by using
16877 SwitchLabel.GetILLabelCode ().
16879 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16880 whether the Local has been captured or not.
16882 (LocalInfo.IsCaptured): New property, used to tell whether the
16883 local has been captured.
16885 * anonymous.cs: Vastly updated to contain the anonymous method
16888 The main classes here are: CaptureContext which tracks any
16889 captured information for a toplevel block and ScopeInfo used to
16890 track the activation frames for various local variables.
16892 Each toplevel block has an optional capture context associated
16893 with it. When a method contains an anonymous method both the
16894 toplevel method and the anonymous method will create a capture
16895 context. When variables or parameters are captured, they are
16896 recorded on the CaptureContext that owns them, for example:
16900 MyDelegate d = delegate {
16905 Here `a' will be recorded as captured on the toplevel
16906 CapturedContext, the inner captured context will not have anything
16907 (it will only have data if local variables or parameters from it
16908 are captured in a nested anonymous method.
16910 The ScopeInfo is used to track the activation frames for local
16911 variables, for example:
16913 for (int i = 0; i < 10; i++)
16914 for (int j = 0; j < 10; j++){
16915 MyDelegate d = delegate {
16920 At runtime this captures a single captured variable `i', but it
16921 captures 10 different versions of the variable `j'. The variable
16922 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16923 recorded on a child.
16925 The toplevel ScopeInfo will also track information like the `this'
16926 pointer if instance variables were referenced (this is necessary
16927 as the anonymous method lives inside a nested class in the host
16928 type of the method).
16930 (AnonymousMethod): Expanded to track the Toplevel, implement
16931 `AnonymousMethod.Compatible' to tell whether an anonymous method
16932 can be converted to a target delegate type.
16934 The routine now also produces the anonymous method content
16936 (AnonymousDelegate): A helper class that derives from
16937 DelegateCreation, this is used to generate the code necessary to
16938 produce the delegate for the anonymous method that was created.
16940 * assign.cs: API adjustments for new changes in
16941 Convert.ImplicitStandardConversionExists.
16943 * class.cs: Adjustments to cope with the fact that now toplevel
16944 blocks are of type `ToplevelBlock'.
16946 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16947 insteda of standard blocks.
16949 Flag errors if params arguments are passed to anonymous methods.
16951 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16952 `CurrentAnonymousMethod' which points to the current Anonymous
16953 Method. The variable points to the AnonymousMethod class that
16954 holds the code being compiled. It is set in the new EmitContext
16955 created for the anonymous method.
16957 (EmitContext.Phase): Introduce a variable and an enumeration to
16958 assist in enforcing some rules about when and where we are allowed
16959 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16960 only one that enfonces this right now).
16962 (EmitContext.HaveCaptureInfo): new helper method that returns
16963 whether we have a CapturedContext initialized.
16965 (EmitContext.CaptureVariable): New method used to register that a
16966 LocalInfo must be flagged for capturing.
16968 (EmitContext.CapturedParameter): New method used to register that a
16969 parameters must be flagged for capturing.
16971 (EmitContext.CapturedField): New method used to register that a
16972 field must be flagged for capturing.
16974 (EmitContext.HaveCapturedVariables,
16975 EmitContext.HaveCapturedFields): Return whether there are captured
16976 variables or fields.
16978 (EmitContext.EmitMethodHostInstance): This is used to emit the
16979 instance for the anonymous method. The instance might be null
16980 (static methods), this (for anonymous methods that capture nothing
16981 and happen to live side-by-side with the current method body) or a
16982 more complicated expression if the method has a CaptureContext.
16984 (EmitContext.EmitTopBlock): Routine that drives the emission of
16985 code: it will first resolve the top block, then emit any metadata
16986 and then emit the code. The split is done so that we can extract
16987 any anonymous methods and flag any captured variables/parameters.
16989 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16990 during this phase, the ILGenerator should not be used as labels
16991 and local variables declared here might not be accessible to any
16992 code that is part of an anonymous method.
16994 Exceptions to this include the temporary variables that are
16995 created by some statements internally for holding temporary
16998 (EmitContext.EmitMeta): New routine, in charge of emitting all the
17001 (EmitContext.TemporaryReturn): This method is typically called
17002 from the Emit phase, and its the only place where we allow the
17003 ReturnLabel to be defined other than the EmitMeta. The reason is
17004 that otherwise we would have to duplicate a lot of logic in the
17005 Resolve phases of various methods that today is on the Emit
17008 (EmitContext.NeedReturnLabel): This no longer creates the label,
17009 as the ILGenerator is not valid during the resolve phase.
17011 (EmitContext.EmitThis): Extended the knowledge in this class to
17012 work in anonymous methods in addition to iterators.
17014 (EmitContext.EmitCapturedVariableInstance): This emits whatever
17015 code is necessary on the stack to access the instance to a local
17016 variable (the variable will be accessed as a field).
17018 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
17019 EmitContext.EmitAddressOfParameter): Routines to support
17020 parameters (not completed at this point).
17022 Removals: Removed RemapLocal and RemapLocalLValue. We probably
17023 will also remove the parameters.
17025 * convert.cs (Convert): Define a `ConstantEC' which points to a
17026 null. This is just to prefity some code that uses
17027 ImplicitStandardConversion code and do not have an EmitContext
17030 The idea is to flag explicitly that at that point in time, it is
17031 known that the conversion will not trigger the delegate checking
17032 code in implicit conversions (which requires a valid
17035 Everywhere: pass new EmitContext parameter since
17036 ImplicitStandardConversionExists now requires it to check for
17037 anonymous method conversions.
17039 (Convert.ImplicitStandardConversionExists): If the type of an
17040 expression is the anonymous_method_type, and the type is a
17041 delegate, we invoke the AnonymousMethod.Compatible method to check
17042 whether an implicit conversion is possible.
17044 (Convert.ImplicitConversionStandard): Only do implicit method
17045 group conversions if the language level is not ISO_1.
17047 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
17048 MethodInfo for the Invoke method. used by Delegate and
17051 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
17052 method conversions if the target type is a delegate.
17054 Removed extra debugging nops.
17056 (LocalVariableReference): Turn the `local_info' into a public
17059 Add `prepared' field, the same hack used for FieldExprs to cope
17060 with composed assignments, as Local variables do not necessarily
17061 operate purely on the stack as they used to: they can be captured
17064 Add `temp' for a temporary result, like fields.
17066 Refactor DoResolve and DoResolveLValue into DoResolveBase.
17068 It now copes with Local variables that are captured and emits the
17069 proper instance variable to load it from a field in the captured
17072 (ParameterReference.DoResolveBase): During the resolve phase,
17073 capture parameters if we are in an anonymous method.
17075 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
17076 anonymous method, use the EmitContext helper routines to emit the
17077 parameter reference.
17079 * iterators.cs: Set RemapToProxy to true/false during the
17082 * parameters.cs (GetParameterByName): New helper method.
17084 * typemanager.cs (anonymous_method_type) a new type that
17085 represents an anonyous method. This is always an internal type,
17086 used as a fencepost to test against the anonymous-methodness of an
17089 2004-10-20 Marek Safar <marek.safar@seznam.cz>
17091 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
17093 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
17095 2004-10-18 Martin Baulig <martin@ximian.com>
17097 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
17098 `Type' directly, but call ResolveType() on it.
17099 (Catch.Resolve): Likewise.
17100 (Foreach.Resolve): Likewise.
17102 2004-10-18 Martin Baulig <martin@ximian.com>
17104 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
17105 `Type' directly, but call ResolveType() on it.
17106 (Probe.DoResolve): Likewise.
17107 (ArrayCreation.LookupType): Likewise.
17108 (TypeOf.DoResolve): Likewise.
17109 (SizeOf.DoResolve): Likewise.
17111 2004-10-18 Martin Baulig <martin@ximian.com>
17113 * expression.cs (Invocation.BetterFunction): Put back
17114 TypeManager.TypeToCoreType().
17116 2004-10-18 Raja R Harinath <rharinath@novell.com>
17118 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
17121 2004-10-18 Martin Baulig <martin@ximian.com>
17123 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
17124 `Type' directly, but call ResolveType() on it.
17126 2004-10-18 Martin Baulig <martin@ximian.com>
17128 * class.cs (FieldMember.Define): Don't access the TypeExpr's
17129 `Type' directly, but call ResolveType() on it.
17130 (MemberBase.DoDefine): Likewise.
17132 * expression.cs (New.DoResolve): Don't access the TypeExpr's
17133 `Type' directly, but call ResolveType() on it.
17134 (ComposedCast.DoResolveAsTypeStep): Likewise.
17136 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
17137 `Type' directly, but call ResolveType() on it.
17139 2004-10-17 John Luke <john.luke@gmail.com>
17141 * class.cs (Operator.GetSignatureForError): use CSharpName
17143 * parameter.cs (Parameter.GetSignatureForError): Returns
17144 correct name even if was not defined.
17146 2004-10-13 Raja R Harinath <rharinath@novell.com>
17149 * class.cs (TypeContainer.EmitContext): New property.
17150 (DefineNestedTypes): Create an emitcontext for each part.
17151 (MethodCore.DoDefineParameters): Use container's emitcontext.
17152 Pass type array to InternalParameters.
17153 (MemberBase.DoDefine): Use container's emitcontext.
17154 (FieldMember.Define): Likewise.
17155 (Event.Define): Likewise.
17156 (SetMethod.GetParameterInfo): Change argument to EmitContext.
17157 Pass type array to InternalParameters.
17158 (SetIndexerMethod.GetParameterInfo): Likewise.
17159 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
17160 * delegate.cs (Define): Pass emitcontext to
17161 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
17162 array to InternalParameters.
17163 * expression.cs (ParameterReference.DoResolveBase): Pass
17164 emitcontext to GetParameterInfo.
17165 (ComposedCast.DoResolveAsTypeStep): Remove check on
17166 ec.ResolvingTypeTree.
17167 * parameter.cs (Parameter.Resolve): Change argument to
17168 EmitContext. Use ResolveAsTypeTerminal.
17169 (Parameter.GetSignature): Change argument to EmitContext.
17170 (Parameters.ComputeSignature): Likewise.
17171 (Parameters.ComputeParameterTypes): Likewise.
17172 (Parameters.GetParameterInfo): Likewise.
17173 (Parameters.ComputeAndDefineParameterTypes): Likewise.
17174 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
17175 * support.cs (InternalParameters..ctor): Remove variant that takes
17177 * typemanager.cs (system_intptr_expr): New.
17178 (InitExpressionTypes): Initialize it.
17180 2004-10-12 Chris Toshok <toshok@ximian.com>
17182 * cs-parser.jay: fix location for try_statement and catch_clause.
17184 2004-10-11 Martin Baulig <martin@ximian.com>
17186 * report.cs: Don't make --fatal abort on warnings, we have
17187 -warnaserror for that.
17189 2004-10-07 Raja R Harinath <rharinath@novell.com>
17191 More DeclSpace.ResolveType avoidance.
17192 * decl.cs (MemberCore.InUnsafe): New property.
17193 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
17194 with newly created EmitContext.
17195 (FieldMember.Define): Likewise.
17196 * delegate.cs (Delegate.Define): Likewise.
17197 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
17198 only if normal name-lookup fails.
17199 (TypeExpr.DoResolve): Enable error-checking.
17200 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
17201 (SizeOf.DoResolve): Likewise.
17202 (ComposedCast.DoResolveAsTypeStep): Likewise.
17203 (StackAlloc.DoResolve): Likewise.
17204 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
17205 (Block.Unsafe): New property.
17206 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
17207 (Unsafe): Set 'unsafe' flag of contained block.
17208 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
17209 (Fixed.Resolve): Likewise.
17210 (Catch.Resolve): Likewise.
17211 (Using.ResolveLocalVariableDecls): Likewise.
17212 (Foreach.Resolve): Likewise.
17214 2004-10-05 John Luke <john.luke@gmail.com>
17216 * cs-parser.jay: add location to error CS0175
17218 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17220 * ecore.cs (Expression.Constantity): Add support for turning null
17223 * const.cs (Const.Define): Allow constants to be reference types
17224 as long as the value is Null.
17226 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17228 * namespace.cs (NamespaceEntry.Using): No matter which warning
17229 level is set, check if this namespace name has already been added.
17231 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17233 * expression.cs: reftype [!=]= null should always use br[true,false].
17236 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17239 * attribute.cs: Enum conversion moved to
17240 GetAttributeArgumentExpression to be applied to the all
17243 2004-10-01 Raja R Harinath <rharinath@novell.com>
17245 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17246 * class.c (TypeContainer.DefineType): Flag error if
17247 base types aren't accessible due to access permissions.
17248 * decl.cs (DeclSpace.ResolveType): Move logic to
17249 Expression.ResolveAsTypeTerminal.
17250 (DeclSpace.ResolveTypeExpr): Thin layer over
17251 Expression.ResolveAsTypeTerminal.
17252 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17253 Refactor code into NestedAccess. Use it.
17254 (DeclSpace.NestedAccess): New.
17255 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17256 argument to silence errors. Check access permissions.
17257 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17258 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17259 (Cast.DoResolve): Likewise.
17260 (New.DoResolve): Likewise.
17261 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17262 (TypeOf.DoResolve): Likewise.
17264 * expression.cs (Invocation.BetterConversion): Return the Type of
17265 the better conversion. Implement section 14.4.2.3 more faithfully.
17266 (Invocation.BetterFunction): Make boolean. Make correspondence to
17267 section 14.4.2.2 explicit.
17268 (Invocation.OverloadResolve): Update.
17269 (Invocation): Remove is_base field.
17270 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17271 (Invocation.Emit): Likewise.
17273 2004-09-27 Raja R Harinath <rharinath@novell.com>
17275 * README: Update to changes.
17277 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17279 * cs-parser.jay: Reverted 642 warning fix.
17281 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17284 * decl.cs (FindMemberWithSameName): Indexer can have more than
17287 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17289 * expression.cs (LocalVariableReference.DoResolveLValue):
17290 Do not report warning 219 for out values.
17291 (EmptyExpression.Null): New member to avoid extra allocations.
17293 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17295 * cs-parser.jay: Fix wrong warning 642 report.
17297 * cs-tokenizer.cs (CheckNextToken): New helper;
17298 Inspect next character if is same as expected.
17300 2004-09-23 Martin Baulig <martin@ximian.com>
17302 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17303 (Convert.ImplicitReferenceConversionExists): Likewise.
17305 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17307 * class.cs (Operator.Define): Add error 448 and 559 report.
17309 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17311 * class.cs (MemberBase.IsTypePermitted): New protected
17312 method for checking error CS0610.
17314 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17316 * class.cs (TypeContainer.HasExplicitLayout): New property
17317 Returns whether container has StructLayout attribute set Explicit.
17318 (FieldMember): New abstract class for consts and fields.
17319 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17320 (Field): Reuse FieldMember.
17322 * const.cs (Const): Reuse FieldMember.
17324 * rootcontext.cs: EmitConstants call moved to class.
17326 2004-09-22 Martin Baulig <martin@ximian.com>
17328 Thanks to Peter Sestoft for this bug report.
17330 * expression.cs (Conditional): If both the `trueExpr' and the
17331 `falseExpr' is a NullLiteral, return a NullLiteral.
17333 2004-09-22 Martin Baulig <martin@ximian.com>
17335 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17336 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17337 for the "get_Current" call.
17339 2004-09-22 Martin Baulig <martin@ximian.com>
17341 Marek and me just fixed one of our oldest bugs: #28562 :-)
17343 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17345 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17346 we're an EnumConstant, just return that.
17347 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17348 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17349 to get the value which'll actually be written into the attribute.
17350 However, we have to use GetValue() to access the attribute's value
17353 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17355 * constant.cs (Constant.IsNegative): New abstract property
17358 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17359 (StackAlloc.DoResolve): Reused IsNegative.
17361 2004-09-21 Martin Baulig <martin@ximian.com>
17363 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17364 if we're used in an iterator, we may be called from different
17367 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17368 we actually have an exception block.
17370 2004-09-20 John Luke <jluke@cfl.rr.com>
17372 * class.cs, cs-parser.jay: Improve the error report for 1520:
17373 report the actual line where the error happens, not where the
17374 class was declared.
17376 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17377 Pass location information that was available elsewhere.
17379 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17381 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17382 runtime to delay sign assemblies.
17384 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17386 * cs-parser.jay: Do not report the stack trace, this is barely
17389 2004-08-22 John Luke <john.luke@gmail.com>
17391 * driver.cs : check that a resource id is not already used
17392 before adding it, report CS1508 if it is, bug #63637
17394 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17396 * ecore.cs: Removed dead code.
17398 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17400 * class.cs: Do not report warning CS0067 on the interfaces.
17402 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17404 * cs-parser.jay: Add error 504 report.
17406 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17408 * rootcontext.cs: WarningLevel is 4 by default now.
17410 * statement.cs (Fixed.Resolve): Do not null
17413 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17416 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17417 deep search when property is not virtual.
17418 (PropertyExpr.ResolveAccessors): Make one call for both
17421 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17424 * statement.cs: Error 152 report constains also location.
17426 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17429 * const.cs: Explicitly set constant as static.
17431 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17434 * cs-parser.jay: Add error 1017 report.
17436 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17438 Fixed bug #59980, #64224
17439 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17441 * typemanager.cs (IsSpecialMethod): Simplified
17443 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17445 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17446 condition with better params.
17448 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17451 * attribute.cs (Resolve): Property has to have both
17454 2004-09-14 Martin Baulig <martin@ximian.com>
17456 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17458 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17461 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17462 called and is obsolete then this member suppress message
17463 when call is inside next [Obsolete] method or type.
17465 * expression.cs: Use TestObsoleteMethodUsage member.
17467 2004-09-14 Martin Baulig <martin@ximian.com>
17469 * cs-parser.jay: Sync a bit with the GMCS version.
17471 2004-09-14 Martin Baulig <martin@ximian.com>
17473 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17474 (CSharpParser.yacc_verbose_flag): New public field.
17476 * genericparser.cs: Removed.
17478 2004-09-14 Raja R Harinath <rharinath@novell.com>
17480 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17482 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17484 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17486 2004-09-10 Martin Baulig <martin@ximian.com>
17488 Backported my MemberName changes from GMCS into MCS.
17490 - we are now using a special `MemberName' class instead of using
17491 strings; in GMCS, the `MemberName' also contains the type
17494 - changed the grammar rules a bit:
17495 * the old `member_name' is now a `namespace_or_type_name':
17496 The rule is that we use `namespace_or_type_name' everywhere
17497 where we expect either a "member name" (GetEnumerator) or a
17498 "member name" with an explicit interface name
17499 (IEnumerable.GetEnumerator).
17500 In GMCS, the explicit interface name may include type arguments
17501 (IEnumerable<T>.GetEnumerator).
17502 * we use `member_name' instead of just `IDENTIFIER' for
17504 The rule is that we use `member_name' wherever a member may
17505 have type parameters in GMCS.
17507 * decl.cs (MemberName): New public class.
17508 (MemberCore.MemberName): New public readonly field.
17509 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17510 (DeclSpace): Likewise.
17512 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17513 * enum.cs (Enum.ctor): Likewise.
17515 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17517 (AliasEntry.ctor): Take a MemberName, not an Expression.
17518 (AliasEntry.UsingAlias): Likewise.
17520 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17521 (IMethodData.MemberName): Changed type from string to MemberName.
17522 (MemberBase.ExplicitInterfaceName): Likewise.
17523 (AbstractPropertyEventMethod.SetupName): Make this private.
17524 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17525 argument; compute the member name here.
17526 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17527 on the `member.MemberName' and the `prefix'.
17529 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17531 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17532 thus, we get a `MemberName' instead of a `string'. These
17533 declarations may have type parameters in GMCS.
17534 (interface_method_declaration, delegate_declaration): Likewise.
17535 (class_declaration, interface_declaration): Likewise.
17536 (method_header): Use `namespace_or_type_name' instead of
17537 `member_name'. We may be an explicit interface implementation.
17538 (property_declaration, event_declaration): Likewise.
17539 (member_name): This is now just an `IDENTIFIER', not a
17540 `namespace_or_type_name'.
17541 (type_name, interface_type): Removed.
17542 (namespace_or_type_name): Return a MemberName, not an Expression.
17543 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17544 call GetTypeExpression() on the MemberName to get an expression.
17545 (IndexerDeclaration.interface_type): Changed type from string to
17547 (MakeName): Operate on MemberName's instead of string's.
17549 2004-09-13 Raja R Harinath <rharinath@novell.com>
17552 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17553 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17554 lookup to avoid symbols introduced by 'using'.
17555 * rootcontext.cs (NamespaceLookup): Update.
17557 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17559 * class.cs (TypeContainer.DoDefineMembers): Do not call
17560 DefineDefaultConstructor for static classes.
17562 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17564 * attribute.cs (Attribute.Resolve): Add error 653 report.
17566 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17568 (Method.ApplyAttributeBuilder): Add error 685 report.
17569 (Operator.Define): Add error 564 report.
17571 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17573 * expression.cs (Invocation.DoResolve): Add error
17574 245 and 250 report.
17576 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17579 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17581 * class.cs (ConstructorInitializer.Resolve):
17582 Wrong error number (515->516).
17584 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17586 * class.cs (Indexer.Define): Add error 631 report.
17588 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17590 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17592 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17594 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17596 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17598 * cs-parser.jay: Added error CS0241 report.
17600 2004-09-10 Raja R Harinath <rharinath@novell.com>
17602 * cs-parser.jay (fixed_statement): Introduce a scope for the
17603 declaration in the 'fixed' statement.
17605 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17607 * cs-parser.jay: Added CS0230 error report.
17609 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17611 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17613 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17615 * expression.cs (Argument.Resolve): Added error CS0192 and
17618 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17620 C# 2.0 #pragma warning feature
17622 * cs-tokenizer.cs (PreProcessPragma): New method;
17623 Handles #pragma directive.
17625 * report.cs (WarningRegions): New class; Support
17626 class for #pragma warning directive. It tests whether
17627 warning is enabled for a given line.
17629 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17631 * const.cs: Add more descriptive error report, tahnks to
17634 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17636 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17638 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17640 * expression.cs: Apply patch from Ben: Remove dead code from
17641 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17642 as that code just threw an exception anwyays.
17644 * const.cs: Remove the call to the turnintoconstant, for details
17647 * literal.cs: The type of the null-literal is the null type; So
17648 we use a placeholder type (literal.cs:System.Null, defined here)
17651 * expression.cs (Conditional.DoResolve): Remove some old code that
17652 is no longer needed, conversions have been fixed.
17654 (ArrayCreationExpression.DoResolve): Return false if we fail to
17655 resolve the inner expression.
17657 2004-09-07 Raja R Harinath <rharinath@novell.com>
17660 * cs-parser.jay (delegate_declaration): Record a delegate
17661 declaration as a type declaration.
17662 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17664 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17666 * parameter.cs: Do not crash if the type can not be resolved.
17668 * expression.cs: Report errors with unsafe pointers, fixes #64896
17670 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17672 * expression.cs: Pointer arith always needs to do a conv.i
17673 if the operand is a long. fix 65320
17675 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17677 Fixed cs0619-37.cs, cs0619-38.cs
17679 * enum.cs (GetObsoleteAttribute): Removed.
17681 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17682 on Enum member is double staged. The first is tested member
17685 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17687 Fixed #56986, #63631, #65231
17689 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17690 adds member to name container.
17691 (TypeContainer.AddToTypeContainer): New method, adds type to
17693 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17694 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17695 AddOperator): Simplified by reusing AddToMemberContainer.
17696 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17698 (Method.CheckForDuplications): Fixed implementation to test all
17700 (MemberBase): Detection whether member is explicit interface
17701 implementation is now in constructor.
17702 (MemberBase.UpdateMemberName): Handles IndexerName.
17703 (Accessor): Changed to keep also location information.
17704 (AbstractPropertyEventMethod): Is derived from MemberCore.
17705 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17706 will be emited or not.
17707 (PropertyBase.AreAccessorsDuplicateImplementation):
17708 Tests whether accessors are not in collision with some method.
17709 (Operator): Is derived from MethodCore to simplify common
17712 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17714 (DeclSpace.AddToContainer): Adds the member to defined_names
17715 table. It tests for duplications and enclosing name conflicts.
17717 * enum.cs (EnumMember): Clean up to reuse the base structures
17719 2004-09-03 Martin Baulig <martin@ximian.com>
17721 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17722 into TypeContainer, to make partial classes work again.
17724 2004-09-03 Martin Baulig <martin@ximian.com>
17726 * rootcontext.cs (RootContext.V2): Removed.
17728 2004-03-23 Martin Baulig <martin@ximian.com>
17730 * expression.cs (Invocation.OverloadResolve): Added `bool
17731 may_fail' argument and use it instead of the Location.IsNull() hack.
17733 2004-09-03 Martin Baulig <martin@ximian.com>
17735 Merged latest changes into gmcs. Please keep this comment in
17736 here, it makes it easier for me to see what changed in MCS since
17737 the last time I merged.
17739 2004-09-03 Raja R Harinath <rharinath@novell.com>
17742 * expression.cs (BetterConversion): Don't allow either conversion
17743 to be null. Remove redundant implicit conversion test when 'q ==
17744 null' -- when this function is invoked, we already know that the
17745 implicit conversion exists.
17746 (BetterFunction): Assume that 'best' is non-null. Remove
17747 redundant reimplementation of IsApplicable when 'best' is null.
17748 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17749 number of arguments.
17750 (IsAncestralType): Extract from OverloadResolve.
17751 (OverloadResolve): Make robust to the MethodGroupExpr being
17752 unsorted. Implement all the logic of Section 14.5.5.1, and
17753 support overloading of methods from multiple applicable types.
17754 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17756 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17757 (RealError, Warning): Append type of report to related symbol.
17759 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17761 * enum.cs: Fixed CLS-Compliance checks for enum members.
17762 Error tests cs3008-8.cs, cs3014-8.cs
17764 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17766 Fixed bug #62342, #63102
17767 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17768 like ImplementMethod.
17770 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17772 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17775 2004-09-02 Martin Baulig <martin@ximian.com>
17777 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17778 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17781 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17783 C# 2.0 Static classes implemented
17785 * class.cs (TypeContainer): instance_constructors,
17786 initialized_fields, initialized_static_fields,
17787 default_constructor, base_inteface_types are protected to be
17788 accessible from StaticClass.
17789 (TypeContainer.DefineDefaultConstructor): New virtual method
17790 for custom default constructor generating
17791 (StaticClass): New class to handle "Static classes" feature.
17793 * cs-parser.jay: Handle static keyword on class like instance
17796 * driver.cs: Added "/langversion" command line switch with two
17797 options (iso-1, default).
17799 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17801 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17803 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17805 * delegate.cs: Style.
17807 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17809 * delegate.cs: Add seperate instance expr field for miguel.
17811 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17813 * PointerArithmetic (Resolve): make sure we are not doing
17814 pointer arith on void*. Also, make sure we are resolved
17815 by not setting eclass until resolve.
17817 All callers: Make sure that PointerArithmetic gets resolved.
17819 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17821 * ArrayCreation (LookupType): If the type does not resolve
17822 to an array, give an error.
17824 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17826 * statement.cs (Try.Resolve): Fixed bug #64222
17828 2004-08-27 Martin Baulig <martin@ximian.com>
17831 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17834 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17836 * ecore.cs (Constantify): Get underlying type via
17837 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17838 Windows in special cases.
17840 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17842 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17843 for obtaining also private methods.
17844 (GetRemoveMethod): Used GetRemoveMethod (true)
17845 for obtaining also private methods.
17847 2004-08-24 Martin Baulig <martin@ximian.com>
17849 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17850 MethodAttributes.HideBySig for operators.
17852 2004-08-23 Martin Baulig <martin@ximian.com>
17854 Back to the old error reporting system :-)
17856 * report.cs (Message): Removed.
17857 (Report.MessageData, ErrorData, WarningData): Removed.
17858 (Report.Error, Warning): Back to the old system.
17860 2004-08-23 Martin Baulig <martin@ximian.com>
17862 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17864 * class.cs (TypeContainer.ParentContainer): New public virtual
17865 method; replaces the explicit interface implementation.
17866 (ClassPart.ParentContainer): Override.
17868 2004-08-23 Martin Baulig <martin@ximian.com>
17870 * statement.cs (Switch): Added support for constant switches; see
17871 #59428 or test-285.cs.
17873 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17876 * statement.cs (GetEnumeratorFilter): Removed useless
17877 logic because C# specs is strict. GetEnumerator must be
17880 2004-08-22 Martin Baulig <martin@ximian.com>
17882 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17883 a switch and may break, reset the barrier. Fixes #59867.
17885 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17887 CLS-Compliance speed up (~5% for corlib)
17889 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17890 New method. Tests container for CLS-Compliant names
17892 * class.cs (TypeContainer.VerifyClsName): New method.
17893 Checks whether container name is CLS Compliant.
17894 (Constructor): Implements IMethodData.
17896 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17897 low-case table for CLS Compliance test.
17898 (MemberCache.VerifyClsParameterConflict): New method.
17899 Checks method parameters for CS3006 error.
17901 * enum.cs (EnumMember): Is derived from MemberCore.
17902 (Enum.VerifyClsName): Optimized for better performance.
17904 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17906 * report.cs: Renamed Error_T to Error and changed all
17909 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17911 * class.cs (TypeContainer.IndexerArrayList): New inner class
17912 container for indexers.
17913 (TypeContainer.DefaultIndexerName): New constant for default
17914 indexer name. Replaced all "Item" with this constant.
17915 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17917 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17918 DefaultMemberAttribute constructor.
17920 2004-08-05 Martin Baulig <martin@ximian.com>
17922 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17925 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17927 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17928 multi platforms problem.
17930 * compiler.csproj: Included shared files.
17932 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17934 Fix bug 60333, 55971 in the more general way
17935 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17936 Added arg_type argument for constant conversion.
17937 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17939 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17942 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17943 OperatorArrayList, MethodCoreArrayList for typecontainer
17944 containers. Changed class member types to these new types.
17945 (MethodArrayList.DefineMembers): Added test for CS0659.
17947 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17949 * cfold.cs: Synchronize the folding with the code in expression.cs
17950 Binary.DoNumericPromotions for uint operands.
17952 * attribute.cs: Revert patch from Raja, it introduced a regression
17953 while building Blam-1.2.1 (hard to isolate a test case).
17955 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17959 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17961 (MethodCore.parent_method): New member. The method we're overriding
17962 if this is an override method.
17963 (MethodCore.CheckBase): Moved from Method class and made common.
17964 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17966 (MethodCore.CheckForDuplications): New abstract method. For custom
17967 member duplication search in a container
17968 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17969 method and its return type.
17970 (Event.conflict_symbol): New member. Symbol with same name in the
17974 (MemberCache.FindMemberWithSameName): New method. The method
17975 is looking for conflict with inherited symbols.
17977 2004-08-04 Martin Baulig <martin@ximian.com>
17979 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17981 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17983 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17985 * report.cs (Message): New enum for better error, warning reference in
17987 (MessageData): New inner abstract class. It generally handles printing of
17988 error and warning messages.
17989 Removed unused Error, Warning, Message methods.
17991 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17993 Fix for cs0592-8.cs test
17995 (Attributable.ValidAttributeTargets): Made public.
17996 (Attribute.ExplicitTarget): New member for explicit target value.
17997 (Attribute.CheckTargets): Now we translate explicit attribute
17998 target to Target here.
18000 2004-08-03 Ben Maurer <bmaurer@ximian.com>
18002 * ecore.cs (MethodGroupExpr): new IsBase property.
18004 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
18006 * delegate.cs (DelegateCreation): store a MethodGroupExpr
18007 rather than an instance expr.
18009 (DelegateCreation.Emit): Use the method group rather than
18010 the instance expression. Also, if you have base.Foo as the
18011 method for a delegate, make sure to emit ldftn, not ldftnvirt.
18013 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
18015 (NewDelegate.DoResolve): Only check for the existance of Invoke
18016 if the method is going to be needed. Use MethodGroupExpr.
18018 (NewDelegate.Emit): Remove, DelegateCreation implements this.
18020 * expression.cs: For pointer arith., make sure to use
18021 the size of the type, not the size of the pointer to
18024 2004-08-03 Marek Safar <marek.safar@seznam.cz>
18027 * class.cs (Class): Added error CS0502 test.
18029 2004-08-03 John Luke <jluke@cfl.rr.com>
18030 Raja R Harinath <rharinath@novell.com>
18033 * attribute.cs (Attribute.complained_before): New flag.
18034 (Attribute.ResolveType, Attribute.Resolve),
18035 (Attribute.DefinePInvokeMethod): Set it.
18036 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
18038 2004-08-03 Martin Baulig <martin@ximian.com>
18040 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
18041 use a user-defined operator; we still need to do numeric
18042 promotions in case one argument is a builtin type and the other
18043 one has an implicit conversion to that type. Fixes #62322.
18045 2004-08-02 Martin Baulig <martin@ximian.com>
18047 * statement.cs (LocalInfo.Flags): Added `IsThis'.
18048 (LocalInfo.IsThis): New public property.
18049 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
18051 2004-08-01 Martin Baulig <martin@ximian.com>
18053 * class.cs (TypeContainer.GetClassBases): Don't set the default
18054 here since we may get called from GetPartialBases().
18055 (TypeContainer.DefineType): If GetClassBases() didn't return a
18056 parent, use the default one.
18058 2004-07-30 Duncan Mak <duncan@ximian.com>
18060 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
18062 2004-07-30 Martin Baulig <martin@ximian.com>
18064 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
18066 * class.cs (SourceMethod): New public class, derive from the
18067 symbol writer's ISourceMethod.
18068 (Method): Use the new symbol writer API.
18070 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
18071 as argument and use the new symbol writer.
18074 (SourceFile): Implement the symbol writer's ISourceFile.
18075 (Location.SymbolDocument): Removed.
18076 (Location.SourceFile): New public property.
18078 * symbolwriter.cs: Use the new symbol writer API.
18080 2004-07-30 Raja R Harinath <rharinath@novell.com>
18082 * Makefile (install-local): Remove. Functionality moved to
18085 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
18087 * Makefile: Install mcs.exe.config file together with mcs.exe.
18088 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
18089 correct runtime version.
18091 2004-07-25 Martin Baulig <martin@ximian.com>
18094 (TypeContainer.RegisterOrder): Removed, this was unused.
18095 (TypeContainer, interface_order): Removed.
18096 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
18097 TypeContainer as argument since we can also be called with a
18098 `PartialContainer' for a partial class/struct/interface.
18099 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
18100 of checking whether we're an `Interface' - we could be a
18101 `PartialContainer'.
18102 (PartialContainer.Register): Override; call
18103 AddClass()/AddStruct()/AddInterface() on our parent.
18105 * cs-parser.jay (interface_member_declaration): Add things to the
18106 `current_container', not the `current_class'.
18108 * rootcontext.cs (RegisterOrder): The overloaded version which
18109 takes an `Interface' was unused, removed.
18111 * typemanager.cs (TypeManager.LookupInterface): Return a
18112 `TypeContainer', not an `Interface'.
18113 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
18114 contain a `PartialContainer' for an interface, so check it's
18115 `Kind' to figure out what it is.
18117 2004-07-25 Martin Baulig <martin@ximian.com>
18119 * class.cs (Class.DefaultTypeAttributes): New public constant.
18120 (Struct.DefaultTypeAttributes): Likewise.
18121 (Interface.DefaultTypeAttributes): Likewise.
18122 (PartialContainer.TypeAttr): Override this and add the
18123 DefaultTypeAttributes.
18125 2004-07-25 Martin Baulig <martin@ximian.com>
18127 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
18128 we can just use the `Parent' field instead.
18130 2004-07-25 Martin Baulig <martin@ximian.com>
18132 * class.cs (TypeContainer.Emit): Renamed to EmitType().
18134 2004-07-25 Martin Baulig <martin@ximian.com>
18136 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
18137 our parts before defining any methods.
18138 (TypeContainer.VerifyImplements): Make this virtual.
18139 (ClassPart.VerifyImplements): Override and call VerifyImplements()
18140 on our PartialContainer.
18142 2004-07-25 Martin Baulig <martin@ximian.com>
18144 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
18146 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
18147 argument, we can just use the `Parent' field instead.
18150 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
18151 (MemberBase.DoDefine): Likewise.
18153 2004-07-24 Martin Baulig <martin@ximian.com>
18155 * decl.cs (MemberCore.Parent): New public field.
18156 (DeclSpace.Parent): Moved to MemberCore.
18158 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
18159 (MemberBase.ctor): Added TypeContainer argument, pass it to our
18161 (FieldBase, Field, Operator): Likewise.
18162 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
18163 (EventField, Event): Likewise.
18165 2004-07-23 Martin Baulig <martin@ximian.com>
18167 * class.cs (PartialContainer): New public class.
18168 (ClassPart): New public class.
18169 (TypeContainer): Added support for partial classes.
18170 (TypeContainer.GetClassBases): Splitted some of the functionality
18171 out into GetNormalBases() and GetPartialBases().
18173 * cs-tokenizer.cs (Token.PARTIAL): New token.
18174 (Tokenizer.consume_identifier): Added some hacks to recognize
18175 `partial', but only if it's immediately followed by `class',
18176 `struct' or `interface'.
18178 * cs-parser.jay: Added support for partial clases.
18180 2004-07-23 Martin Baulig <martin@ximian.com>
18182 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
18183 a `DeclSpace' and also made it readonly.
18184 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
18185 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
18186 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
18188 * cs-parser.jay: Pass the `current_class', not the
18189 `current_container' (at the moment, this is still the same thing)
18190 to a new Method, Property, Event, Indexer or Constructor.
18192 2004-07-23 Martin Baulig <martin@ximian.com>
18194 * cs-parser.jay (CSharpParser): Added a new `current_class' field
18195 and removed the `current_interface' one.
18196 (struct_declaration, class_declaration, interface_declaration):
18197 Set `current_class' to the newly created class/struct/interface;
18198 set their `Bases' and call Register() before parsing their body.
18200 2004-07-23 Martin Baulig <martin@ximian.com>
18202 * class.cs (Kind): New public enum.
18203 (TypeContainer): Made this class abstract.
18204 (TypeContainer.Kind): New public readonly field.
18205 (TypeContainer.CheckDef): New public method; moved here from
18207 (TypeContainer.Register): New public abstract method.
18208 (TypeContainer.GetPendingImplementations): New public abstract
18210 (TypeContainer.GetClassBases): Removed the `is_class' and
18211 `is_iface' parameters.
18212 (TypeContainer.DefineNestedTypes): Formerly known as
18214 (ClassOrStruct): Made this class abstract.
18216 * tree.cs (RootTypes): New public type.
18218 2004-07-20 Martin Baulig <martin@ximian.com>
18220 * tree.cs (Tree.RecordNamespace): Removed.
18221 (Tree.Namespaces): Removed.
18223 * rootcontext.cs (RootContext.IsNamespace): Removed.
18225 * cs-parser.jay (namespace_declaration): Just create a new
18226 NamespaceEntry here.
18228 2004-07-20 Martin Baulig <martin@ximian.com>
18230 * statement.cs (ExceptionStatement): New abstract class. This is
18231 now used as a base class for everyone who's using `finally'.
18232 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18233 our local variables before using them.
18235 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18236 virtual method. This is used by Yield.Resolve() to "steal" an
18237 outer block's `finally' clauses.
18238 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18241 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18242 version which takes an ExceptionStatement. This version must be
18243 used to create exception branchings.
18246 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18247 (Iterator.EmitMoveNext): Added exception support; protect the
18248 block with a `fault' clause, properly handle 'finally' clauses.
18249 (Iterator.EmitDispose): Run all the `finally' clauses here.
18251 2004-07-20 Martin Baulig <martin@ximian.com>
18253 * iterator.cs: This is the first of a set of changes in the
18254 iterator code. Match the spec more closely: if we're an
18255 IEnumerable, then GetEnumerator() must be called. The first time
18256 GetEnumerator() is called, it returns the current instance; all
18257 subsequent invocations (if any) must create a copy.
18259 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18261 * expression.cs: Resolve the constant expression before returning
18264 2004-07-19 Martin Baulig <martin@ximian.com>
18266 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18267 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18268 the return type of the new EmitContext.
18270 2004-07-18 Martin Baulig <martin@ximian.com>
18272 * class.cs (Property.Define): Fix iterators.
18274 * iterators.cs (Iterator.Define): Moved the
18275 `container.AddInterator (this)' call here from the .ctor; only do
18276 it if we resolved successfully.
18278 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18280 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18281 `true' for preprocessing directives that we parse. The return
18282 value indicates whether we should return to regular tokenizing or
18283 not, not whether it was parsed successfully.
18285 In the past if we were in: #if false ... #line #endif, we would
18286 resume parsing after `#line'. See bug 61604.
18288 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18289 building: IsEnumType should return true only for enums, not for
18290 enums or System.Enum itself. This fixes #61593.
18292 Likely what happened is that corlib was wrong: mcs depended on
18293 this bug in some places. The bug got fixed, we had to add the
18294 hack, which caused bug 61593.
18296 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18297 that was a workaround for the older conditions.
18299 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18301 * assign.cs: IAssignMethod has a new interface, as documented
18302 inline. All assignment code now uses this new api.
18304 * ecore.cs, expression.cs: All classes which implement
18305 IAssignMethod now use the new interface.
18307 * expression.cs (Invocation): add a hack to EmitCall so that
18308 IndexerAccess can be the target of a compound assignment without
18309 evaluating its arguments twice.
18311 * statement.cs: Handle changes in Invocation api.
18313 2004-07-16 Martin Baulig <martin@ximian.com>
18315 * iterators.cs: Rewrote this. We're now using one single Proxy
18316 class for both the IEnumerable and the IEnumerator interface and
18317 `Iterator' derives from Class so we can use the high-level API.
18319 * class.cs (TypeContainer.AddIterator): New method.
18320 (TypeContainer.DoDefineType): New protected virtual method, which
18321 is called from DefineType().
18322 (TypeContainer.DoDefineMembers): Call DefineType() and
18323 DefineMembers() on all our iterators.
18324 (TypeContainer.Emit): Call Emit() on all our iterators.
18325 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18327 * codegen.cs (EmitContext.CurrentIterator): New public field.
18329 2004-07-15 Martin Baulig <martin@ximian.com>
18332 (TypeManager.not_supported_exception_type): New type.
18334 2004-07-14 Martin Baulig <martin@ximian.com>
18336 * iterators.cs: Use real error numbers.
18338 2004-07-14 Martin Baulig <martin@ximian.com>
18340 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18341 requires this to be a System.Collection.IEnumerable and not a
18342 class implementing that interface.
18343 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18345 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18347 * class.cs: Fixed previous fix, it broke some error tests.
18349 2004-07-12 Martin Baulig <martin@ximian.com>
18351 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18354 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18356 * assign.cs (LocalTemporary): Add new argument: is_address,If
18357 `is_address' is true, then the value that we store is the address
18358 to the real value, and not the value itself.
18360 * ecore.cs (PropertyExpr): use the new local temporary
18361 stuff to allow us to handle X.Y += z (where X is a struct)
18363 2004-07-08 Martin Baulig <martin@ximian.com>
18365 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18366 not always return, just like we're doing in Using.Resolve().
18368 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18370 * cs-parser.jay (fixed_statement): flag this as Pinned.
18372 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18374 * typemanager.cs (TypeManager): Removed MakePinned method, this
18375 mechanism is replaced with the .NET 2.x compatible mechanism of
18376 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18378 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18379 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18380 `IsFixed' property which has a different meaning.
18382 2004-07-02 Raja R Harinath <rharinath@novell.com>
18384 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18385 visible from inside a nested class, not just the names of the
18386 immediately enclosing class.
18387 Fix for bug #60730.
18389 2004-06-24 Raja R Harinath <rharinath@novell.com>
18391 * expression.cs (BetterConversion): Remove buggy special-case
18392 handling of "implicit constant expression conversions". At this
18393 point, we already know that the conversion is possible -- we're
18394 only checking to see which is better.
18396 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18398 * cs-parser.jay: Added error CS0210 test.
18400 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18402 * cs-parser.jay: Added error CS0134 test.
18404 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18407 * cs-parser.jay: Added error CS0145 test.
18409 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18411 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18413 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18415 * expression.cs (StackAlloc.Resolve): The argument may not
18416 be a constant; deal with this case.
18418 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18420 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18421 GetIndexerAttributeValue.
18422 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18424 * class.cs (Indexer.Define): Added error tests for CS0415,
18427 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18429 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18432 2004-06-23 Martin Baulig <martin@ximian.com>
18434 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18435 neither return nor throw, reset the barrier as well. Fixes #60457.
18437 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18439 * class.cs : EventAttributes is now set to None by default.
18440 This fixes bug #60459.
18442 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18445 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18446 Don't throw exception but return null (it's sufficient now).
18448 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18450 * typemanager.cs (GetArgumentTypes): Faster implementation.
18452 2004-06-18 Martin Baulig <martin@ximian.com>
18454 * attribute.cs (Attribute.Resolve): Check whether we're an
18455 EmptyCast which a Constant child. Fixes #60333.
18457 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18459 * statement.cs (EmitCollectionForeach): Account for the fact that
18460 not all valuetypes are in areas which we can take the address of.
18461 For these variables, we store to a temporary variable. Also, make
18462 sure that we dont emit a `callvirt' on a valuetype method.
18464 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18466 * expression.cs (StackAlloc.DoReSolve): Added test for
18467 negative parameter (CS0247).
18469 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18472 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18474 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18477 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18480 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18482 Fix bug #58254 & cs1555.cs, cs1556.cs
18483 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18485 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18487 * cs-parser.jay: Added error CS1669 test for indexers.
18489 2004-06-11 Martin Baulig <martin@ximian.com>
18491 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18492 call this twice: for params and varargs methods.
18494 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18497 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18499 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18501 * attribute.cs (Attribute.GetValidTargets): Made public.
18504 (AbstractPropertyEventMethod): New class for better code sharing.
18505 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18507 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18509 2004-06-11 Raja R Harinath <rharinath@novell.com>
18512 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18513 that the call to Resolve is part of a MemberAccess.
18514 (Expression.Resolve): Use it for SimpleName resolution.
18515 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18516 Add 'intermediate' boolean argument.
18517 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18518 error message when the SimpleName can be resolved ambiguously
18519 between an expression and a type.
18520 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18522 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18523 call on the left-side.
18525 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18528 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18530 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18532 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18534 2004-06-11 Martin Baulig <martin@ximian.com>
18536 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18537 varargs methods if applicable.
18539 2004-06-11 Martin Baulig <martin@ximian.com>
18541 * expression.cs (Invocation.EmitCall): Don't use
18542 `method.CallingConvention == CallingConventions.VarArgs' since the
18543 method could also have `CallingConventions.HasThis'.
18545 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18547 * class.cs (Event.GetSignatureForError): Implemented.
18548 Fixed crash in error test cs3010.cs
18550 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18552 * cs-tokenizer.cs: Change the way we track __arglist to be
18553 consistent with the other keywords.
18555 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18557 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18560 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18562 * codegen.cs: Check that all referenced assemblies have a strongname
18563 before strongnaming the compiled assembly. If not report error CS1577.
18564 Fix bug #56563. Patch by Jackson Harper.
18565 * typemanager.cs: Added a method to return all referenced assemblies.
18566 Fix bug #56563. Patch by Jackson Harper.
18568 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18571 (Method.ApplyAttributeBuilder): Moved and added conditional
18572 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18575 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18577 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18580 * class.cs: (EventField.attribute_targets): Changed default target.
18582 2004-06-08 Martin Baulig <martin@ximian.com>
18584 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18586 2004-06-08 Martin Baulig <martin@ximian.com>
18588 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18590 2004-06-07 Martin Baulig <martin@ximian.com>
18592 Added support for varargs methods.
18594 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18597 * cs-parser.jay: Added support for `__arglist'.
18599 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18601 * expression.cs (Argument.AType): Added `ArgList'.
18602 (Invocation): Added support for varargs methods.
18603 (ArglistAccess): New public class.
18604 (Arglist): New public class.
18606 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18608 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18609 a method's top-level block if the method has varargs.
18611 * support.cs (ReflectionParameters, InternalParameters): Added
18612 support for varargs methods.
18614 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18616 * class.cs: Provide location in indexer error report.
18618 * driver.cs: Use standard names.
18620 * namespace.cs: Catch the use of using after a namespace has been
18621 declared also on using aliases.
18623 2004-06-03 Raja R Harinath <rharinath@novell.com>
18626 * typemanager.cs (closure_private_ok, closure_invocation_type)
18627 (closure_qualifier_type, closure_invocation_assembly)
18628 (FilterWithClosure): Move to ...
18629 (Closure): New internal nested class.
18630 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18631 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18632 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18633 (MemberLookup, MemberLookupFailed): Use it.
18634 * expression.cs (New.DoResolve): Treat the lookup for the
18635 constructor as being qualified by the 'new'ed type.
18636 (Indexers.GetIndexersForTypeOrInterface): Update.
18638 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18641 (GetConditionalAttributeValue): New method. Returns
18642 condition of ConditionalAttribute.
18643 (SearchMulti): New method. Returns all attributes of type 't'.
18644 Use it when attribute is AllowMultiple = true.
18645 (IsConditionalMethodExcluded): New method.
18648 (Method.IsExcluded): Implemented. Returns true if method has conditional
18649 attribute and the conditions is not defined (method is excluded).
18650 (IMethodData): Extended interface for ConditionalAttribute support.
18651 (PropertyMethod.IsExcluded): Implemented.
18654 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18657 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18660 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18662 * expression.cs (ArrayCreationExpression): Make this just an
18663 `expression'. It can't be a statement, so the code here was
18666 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18669 * typemanager.cs (GetFullNameSignature): New method for
18672 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18675 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18676 Use this method when MethodBuilder is null.
18677 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18678 Added test for error CS0626 (MONO reports error for this situation).
18679 (IMethodData.GetSignatureForError): Extended interface.
18681 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18684 (AttributeTester.GetObsoleteAttribute): Returns instance of
18685 ObsoleteAttribute when type is obsolete.
18688 (TypeContainer.VerifyObsoleteAttribute): Override.
18689 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18690 (MethodCode.VerifyObsoleteAttribute): Override.
18691 (MemberBase.VerifyObsoleteAttribute): Override.
18694 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18695 and report proper error.
18698 Delegate.VerifyObsoleteAttribute): Override.
18701 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18702 and report proper error.
18703 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18706 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18710 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18711 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18712 Added test for ObsoleteAttribute.
18715 (Catch): Derived from Statement.
18717 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18719 Fixed bug #59071 & cs0160.cs
18721 * statement.cs (Try.Resolve): Check here whether order of catch
18722 clauses matches their dependencies.
18724 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18726 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18727 caused a regression: #59343. Referencing nested classes from an
18728 assembly stopped working.
18730 2004-05-31 Martin Baulig <martin@ximian.com>
18732 MCS is now frozen for beta 2.
18734 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18736 * convert.cs: add a trivial cache for overload operator resolution.
18738 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18740 * decl.cs: If possible, use lookuptypedirect here. We can only do
18741 this if there is no `.' after the namespace. Avoids using
18742 LookupType, which does lots of slow processing.
18743 (FindNestedType) New method, does what it says :-).
18744 * namespace.cs: use LookupTypeDirect.
18745 * rootcontext.cs: use membercache, if possible.
18746 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18748 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18751 According to the spec,
18753 In a member access of the form E.I, if E is a single identifier,
18754 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18755 field, property, localvariable, or parameter with the same type as
18756 the meaning of E as a type-name (§3.8), then both possible
18757 meanings of E are permitted.
18759 We did not check that E as a simple-name had the same type as E as
18762 This trivial check gives us 5-7% on bootstrap time.
18764 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18766 * expression.cs (Invocation.OverloadResolve): Avoid the
18767 use of hashtables and boxing here by allocating on demand.
18769 2004-05-30 Martin Baulig <martin@ximian.com>
18771 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18772 we're doing a silent lookup. Don't try to lookup nested types in
18773 TypeManager.object_type (thanks to Ben Maurer).
18775 2004-05-30 Martin Baulig <martin@ximian.com>
18777 Committing a patch from Ben Maurer.
18779 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18781 2004-05-29 Martin Baulig <martin@ximian.com>
18783 * class.cs (IMethodData.ShouldIgnore): New method.
18785 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18786 `Location' argument, we don't need it anywhere. Use
18787 `IMethodData.ShouldIgnore ()' instead of
18788 `MethodData.GetMethodFlags ()'.
18789 (TypeManager.AddMethod): Removed.
18790 (TypeManager.AddMethod2): Renamed to AddMethod.
18792 2004-05-29 Martin Baulig <martin@ximian.com>
18794 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18796 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18797 converting from a class type S to an interface type and we already
18798 have an object on the stack, don't box it again. Fixes #52578.
18800 2004-05-29 Martin Baulig <martin@ximian.com>
18802 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18803 Added support for `params' parameters. Fixes #59267.
18805 2004-05-29 Martin Baulig <martin@ximian.com>
18807 * literal.cs (NullPointer): Provide a private .ctor which sets
18808 `type' to TypeManager.object_type. Fixes #59048.
18810 2004-05-29 Martin Baulig <martin@ximian.com>
18812 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18813 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18815 * ecore.cs (EventExpr.instance_expr): Make the field private.
18817 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18819 Fixed bug #50080 & cs0214-2.cs
18820 * expression.cs (Cast.DoResolve): Check unsafe context here.
18822 * statement.cs (Resolve.DoResolve): Likewise.
18824 2004-05-26 Martin Baulig <martin@ximian.com>
18826 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18828 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18829 (RootContext.LookupType): Pass down the `silent' flag.
18831 2004-05-25 Martin Baulig <martin@ximian.com>
18834 (MethodGroupExpr.IdenticalTypeName): New public property.
18835 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18836 expression actually refers to a type.
18838 2004-05-25 Martin Baulig <martin@ximian.com>
18840 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18841 for #56176 and made it actually work.
18843 2004-05-25 Martin Baulig <martin@ximian.com>
18845 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18846 (FieldExpr, PropertyExpr): Override and implement
18847 CacheTemporaries. Fixes #52279.
18849 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18851 * location.cs: In the new compiler listing a file twice is a
18852 warning, not an error.
18854 2004-05-24 Martin Baulig <martin@ximian.com>
18856 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18857 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18859 2004-05-24 Martin Baulig <martin@ximian.com>
18861 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18862 walking the `using' list. Fixes #53921.
18864 2004-05-24 Martin Baulig <martin@ximian.com>
18866 * const.cs (Const.LookupConstantValue): Added support for
18867 EmptyCast's; fixes #55251.
18869 2004-05-24 Martin Baulig <martin@ximian.com>
18871 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18872 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18873 which does the CS0135 check. The reason is that we first need to
18874 check whether the variable actually exists.
18876 2004-05-24 Martin Baulig <martin@ximian.com>
18878 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18879 than RootContext.LookupType() to find the explicit interface
18880 type. Fixes #58584.
18882 2004-05-24 Raja R Harinath <rharinath@novell.com>
18884 * Makefile: Simplify. Use executable.make.
18885 * mcs.exe.sources: New file. List of sources of mcs.exe.
18887 2004-05-24 Anders Carlsson <andersca@gnome.org>
18891 Use the invariant culture when doing String.Compare for CLS case
18894 2004-05-23 Martin Baulig <martin@ximian.com>
18896 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18897 don't have any dots. Fixes #52622, added cs0246-8.cs.
18899 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18901 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18903 * class.cs (MemberBase.Define): Reuse MemberType member for
18904 resolved type. Other methods can use it too.
18906 2004-05-23 Martin Baulig <martin@ximian.com>
18908 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18909 the variable also exists in the current block (otherwise, we need
18910 to report a CS0103). Fixes #58670.
18912 2004-05-23 Martin Baulig <martin@ximian.com>
18914 * flowanalysis.cs (Reachability.Reachable): Compute this
18915 on-the-fly rather than storing it as a field.
18917 2004-05-23 Martin Baulig <martin@ximian.com>
18919 * flowanalysis.cs (Reachability.And): Manually compute the
18920 resulting `barrier' from the reachability.
18922 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18925 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18926 instance of ObsoleteAttribute when symbol is obsolete.
18929 (IMethodData): Extended interface for ObsoleteAttribute support.
18931 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18933 * attribute.cs: Fix bug #55970
18935 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18939 (GetObsoleteAttribute): New method. Creates the instance of
18941 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18942 ObsoleteAttribute when member is obsolete.
18943 (AttributeTester.Report_ObsoleteMessage): Common method for
18944 Obsolete error/warning reporting.
18947 (TypeContainer.base_classs_type): New member for storing parent type.
18950 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18951 for this MemberCore.
18953 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18955 * attribute.cs, const.cs: Fix bug #58590
18957 2004-05-21 Martin Baulig <martin@ximian.com>
18959 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18960 out parameters if the end of the method is unreachable. Fixes
18963 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18965 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18966 Hari was right, why extra method.
18968 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18970 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18972 2004-05-20 Martin Baulig <martin@ximian.com>
18974 Merged this back from gmcs to keep the differences to a minumum.
18976 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18977 instead of a Declspace.
18978 (Attribute.ResolveType): Likewise.
18979 (Attributes.Search): Likewise.
18980 (Attributes.Contains): Likewise.
18981 (Attributes.GetClsCompliantAttribute): Likewise.
18983 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18985 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18988 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18990 Fix bug #58688 (MCS does not report error when the same attribute
18993 * attribute.cs (Attribute.Emit): Distinction between null and default.
18995 2004-05-19 Raja R Harinath <rharinath@novell.com>
18997 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18998 of a top-level attribute without an attribute target.
18999 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
19001 (Attribute.Conditional_GetConditionName),
19002 (Attribute.Obsolete_GetObsoleteMessage): Update.
19003 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
19004 part of ScanForIndexerName.
19005 (Attribute.CanIgnoreInvalidAttribute): New function.
19006 (Attribute.ScanForIndexerName): Move to ...
19007 (Attributes.ScanForIndexerName): ... here.
19008 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
19009 (Attributes.Search): New internal variant that can choose not to
19010 complain if types aren't resolved. The original signature now
19012 (Attributes.GetClsCompliantAttribute): Use internal variant, with
19013 complaints suppressed.
19014 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
19015 only if it not useful.
19016 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
19017 top-level for attributes that are shared between the assembly
19018 and a top-level class.
19019 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
19020 * class.cs: Update to reflect changes.
19021 (DefineIndexers): Fuse loops.
19022 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
19023 a couple more variants of attribute names.
19025 2004-05-18 Marek Safar <marek.safar@seznam.cz>
19027 Fix bug #52585 (Implemented explicit attribute declaration)
19030 (Attributable.ValidAttributeTargets): New abstract method. It gets
19031 list of valid attribute targets for explicit target declaration.
19032 (Attribute.Target): It holds target itself.
19033 (AttributeSection): Removed.
19034 (Attribute.CheckTargets): New method. It checks whether attribute
19035 target is valid for the current element.
19038 (EventProperty): New class. For events that are declared like
19039 property (with add and remove accessors).
19040 (EventField): New class. For events that are declared like field.
19043 * cs-parser.jay: Implemented explicit attribute target declaration.
19045 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
19046 Override ValidAttributeTargets.
19049 (ReturnParameter): Class for applying custom attributes on
19051 (ParameterAtribute): New class. Class for applying custom
19052 attributes on the parameter type.
19054 2004-05-17 Miguel de Icaza <miguel@ximian.com>
19056 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
19059 (Method): Allow UNSAFE here.
19061 * modifiers.cs: Support unsafe reporting.
19063 2004-05-17 Marek Safar <marek.safar@seznam.cz>
19065 * decl.cs: Fix bug #58478.
19067 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19069 * statement.cs: When checking for unreachable code on an EmptyStatement,
19070 set the location. Fixes bug #58488.
19072 2004-05-13 Miguel de Icaza <miguel@ximian.com>
19074 * driver.cs: Add -pkg handling.
19076 From Gonzalo: UseShelLExecute=false
19078 2004-05-12 Marek Safar <marek.safar@seznam.cz>
19081 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
19083 (Attribute.IsClsCompliaceRequired): Moved to base for better
19085 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
19086 when attribute is AttributeUsageAttribute.
19087 (Attribute.GetValidTargets): Simplified.
19088 (Attribute.GetAttributeUsage): New method returns AttributeUsage
19089 attribute for this type.
19090 (Attribute.ApplyAttributes): Method renamed to Emit and make
19092 (GlobalAttributeSection): New class for special handling of global
19093 attributes (assembly, module).
19094 (AttributeSection.Emit): New method.
19096 * class.cs: Implemented Attributable abstract methods.
19097 (MethodCore.LabelParameters): Moved to Parameter class.
19098 (Accessor): Is back simple class.
19099 (PropertyMethod): Implemented Attributable abstract class.
19100 (DelegateMethod): Implemented Attributable abstract class.
19101 (Event): New constructor for disctintion between normal Event
19102 and Event with accessors.
19104 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
19106 * codegen.cs, const.cs, decl.cs, delegate.cs:
19107 (CommonAssemblyModulClass): Implemented Attributable abstract class
19110 * enum.cs: Implement IAttributeSupport interface.
19111 (EnumMember): New class for emum members. Implemented Attributable
19115 (ParameterBase): Is abstract.
19116 (ReturnParameter): New class for easier [return:] attribute handling.
19118 * typemanager.cs: Removed builder_to_attr.
19120 2004-05-11 Raja R Harinath <rharinath@novell.com>
19123 * attribute.cs (Attribute.GetPositionalValue): New function.
19124 * class.cs (TypeContainer.VerifyMembers): New function.
19125 (TypeContainer.Emit): Use it.
19126 (ClassOrStruct): New base class for Class and Struct.
19127 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
19128 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
19130 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
19131 then each non-static field should have a FieldOffset attribute.
19132 Otherwise, none of the fields should have a FieldOffset attribute.
19133 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
19134 and FieldOffset attributes.
19135 * typemanager.cs (TypeManager.struct_layout_attribute_type)
19136 (TypeManager.field_offset_attribute_type): New core types.
19137 (TypeManager.InitCoreTypes): Initialize them.
19139 2004-05-11 Michal Moskal <malekith@pld-linux.org>
19141 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
19142 Return correct type.
19145 2004-05-09 Miguel de Icaza <miguel@ximian.com>
19147 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
19148 be implicitly converted to ulong.
19150 * expression.cs: The logic for allowing operator &, | and ^ worked
19151 was wrong, it worked before because we did not report an error in
19152 an else branch. Fixes 57895.
19154 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
19155 allow volatile fields to be reference types.
19157 2004-05-07 Miguel de Icaza <miguel@ximian.com>
19159 * driver.cs: Add support for /debug-
19161 2004-05-07 Raja R Harinath <rharinath@novell.com>
19163 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
19164 Add a 'complain' parameter to silence errors.
19165 (Attribute.Resolve): Update to changes. Put in sanity check to catch
19166 silently overlooked type-resolutions.
19167 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
19168 to reflect changes.
19169 (Attributes.Search): New function.
19170 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
19171 (Attributes.GetAttributeFullName): Remove hack.
19172 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
19173 Update to reflect changes.
19174 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
19175 Use Attributes.Search instead of nested loops.
19177 2004-05-07 Marek Safar <marek.safar@seznam.cz>
19180 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
19181 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
19182 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
19184 * report.cs: (Report.Warning): Renamed to Warning_T because of
19185 parameter collision.
19187 2004-05-05 Raja R Harinath <rharinath@novell.com>
19189 * expression.cs (MemberAccess.ResolveMemberAccess):
19190 Exit with non-zero status after Report.Error.
19191 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
19193 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
19195 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19197 * support.cs: Don't hang when the file is empty.
19199 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
19201 * support.cs: In SeekableStreamReader, compute the preamble size of the
19202 underlying stream. Position changes should take into account that initial
19205 2004-05-03 Todd Berman <tberman@sevenl.net>
19207 * driver.cs: remove unused GetSysVersion function.
19209 2004-05-03 Todd Berman <tberman@sevenl.net>
19211 * driver.cs: Remove the hack from saturday, as well as the hack
19212 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19213 link_paths to get that bit proper.
19215 2004-05-01 Todd Berman <tberman@sevenl.net>
19217 * driver.cs: Try a LoadFrom before a Load, this checks the current
19218 path. This is currently a bug in mono that is be fixed, however, this
19219 provides a workaround for now. This will be removed when the bug
19222 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19224 * CryptoConvert.cs: Updated to latest version. Fix issue with
19225 incomplete key pairs (#57941).
19227 2004-05-01 Todd Berman <tberman@sevenl.net>
19229 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19232 2004-04-30 Jackson Harper <jackson@ximian.com>
19234 * codegen.cs: Open keys readonly.
19236 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19238 * typemanager.cs: don't report cyclic struct layout when a struct
19239 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19240 which has 2 Pango.Rectangle fields.
19242 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19244 * expression.cs: Handle IntPtr comparisons with IL code
19245 rather than a method call.
19247 2004-04-29 Martin Baulig <martin@ximian.com>
19249 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19250 the list of PropertyInfo's in class hierarchy and find the
19251 accessor. Fixes #56013.
19253 2004-04-29 Martin Baulig <martin@ximian.com>
19255 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19257 2004-04-29 Martin Baulig <martin@ximian.com>
19259 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19261 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19263 2004-04-29 Martin Baulig <martin@ximian.com>
19265 * class.cs (ConstructorInitializer.Resolve): Check whether the
19266 parent .ctor is accessible. Fixes #52146.
19268 2004-04-29 Martin Baulig <martin@ximian.com>
19270 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19272 * statement.cs (Using.EmitLocalVariableDecls): Use
19273 TypeManager.idisposable_type, not typeof (IDisposable).
19274 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19276 2004-04-29 Martin Baulig <martin@ximian.com>
19278 * class.cs (Event.Define): Don't emit the field and don't set
19279 RTSpecialName and SpecialName for events on interfaces. Fixes
19282 2004-04-29 Raja R Harinath <rharinath@novell.com>
19284 Refactor Attribute.ApplyAttributes.
19285 * attribute.cs (Attributable): New base class for objects that can
19286 have Attributes applied on them.
19287 (Attribute): Make AttributeUsage fields public.
19288 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19289 (Attribute.IsInternalCall): New property.
19290 (Attribute.UsageAttr): Convert to a public read-only property.
19291 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19292 (Attribute.ResolveType, Attribute.Resolve)
19293 (Attribute.ScanForIndexerName): Update to reflect changes.
19294 (Attribute.CheckAttributeTarget): Re-format.
19295 (Attribute.ApplyAttributes): Refactor, to various
19296 Attributable.ApplyAttributeBuilder methods.
19297 * decl.cs (MemberCore): Make Attributable.
19298 * class.cs (Accessor): Make Attributable.
19299 (MethodData.ApplyAttributes): Use proper attribute types, not
19301 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19302 (TypeContainer.ApplyAttributeBuilder)
19303 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19304 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19305 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19306 (Operator.ApplyAttributeBuilder): New factored-out methods.
19307 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19308 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19309 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19310 * parameter.cs (ParameterBase): New Attributable base class
19311 that can also represent Return types.
19312 (Parameter): Update to the changes.
19314 2004-04-29 Jackson Harper <jackson@ximian.com>
19316 * driver.cs: Prefer the corlib system version when looking for
19317 assemblies in the GAC. This is still a hack, but its a better hack
19320 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19322 * decl.cs, enum.cs: Improved error 3005 reporting.
19324 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19325 (related_symbols): New private member for list of symbols
19326 related to reported error/warning.
19328 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19330 2004-04-29 Martin Baulig <martin@ximian.com>
19332 * ecore.cs (Expression.Constantify): If we're an enum and
19333 TypeManager.TypeToCoreType() doesn't give us another type, use
19334 t.UnderlyingSystemType. Fixes #56178.
19336 2004-04-29 Martin Baulig <martin@ximian.com>
19338 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19339 interfaces and for each interface, only add members directly
19340 declared in that interface. Fixes #53255.
19342 2004-04-28 Martin Baulig <martin@ximian.com>
19344 * expression.cs (ConditionalLogicalOperator): Use a temporary
19345 variable for `left' to avoid that we evaluate it more than once;
19348 2004-04-28 Martin Baulig <martin@ximian.com>
19350 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19353 2004-04-28 Martin Baulig <martin@ximian.com>
19355 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19358 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19359 whether the type is not void (CS1547).
19361 2004-04-28 Martin Baulig <martin@ximian.com>
19363 * expression.cs (Unary.DoResolveLValue): Override this and report
19364 CS0131 for anything but Operator.Indirection.
19366 2004-04-28 Martin Baulig <martin@ximian.com>
19368 Committing a patch from Ben Maurer; see bug #50820.
19370 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19373 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19376 2004-04-28 Martin Baulig <martin@ximian.com>
19378 Committing a patch from Ben Maurer; see bug #50820.
19380 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19383 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19386 2004-04-28 Martin Baulig <martin@ximian.com>
19388 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19389 (Block.AddLabel): Call DoLookupLabel() to only search in the
19392 2004-04-28 Martin Baulig <martin@ximian.com>
19394 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19395 comparing StringConstants and NullLiterals in Equality and Inequality.
19397 2004-04-28 Jackson Harper <jackson@ximian.com>
19399 * driver.cs: Attempt to load referenced assemblies from the
19400 GAC. This is the quick and dirty version of this method that
19401 doesnt take into account versions and just takes the first
19402 canidate found. Will be good enough for now as we will not have more
19403 then one version installed into the GAC until I update this method.
19405 2004-04-28 Martin Baulig <martin@ximian.com>
19407 * typemanager.cs (TypeManager.CheckStructCycles): New public
19408 static method to check for cycles in the struct layout.
19410 * rootcontext.cs (RootContext.PopulateTypes): Call
19411 TypeManager.CheckStructCycles() for each TypeContainer.
19412 [Note: We only need to visit each type once.]
19414 2004-04-28 Martin Baulig <martin@ximian.com>
19416 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19418 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19419 success and added `out object value'. Use a `bool resolved' field
19420 to check whether we've already been called rather than
19421 `ConstantValue != null' since this breaks for NullLiterals.
19423 2004-04-28 Raja R Harinath <rharinath@novell.com>
19425 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19426 setting of this flag, since the 'set' method may be non-public.
19428 2004-04-28 Raja R Harinath <rharinath@novell.com>
19430 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19431 check on current_vector.Block.
19433 2004-04-27 Martin Baulig <martin@ximian.com>
19435 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19436 a field initializer. Fixes #56459.
19438 2004-04-27 Martin Baulig <martin@ximian.com>
19440 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19441 we're not attempting to use an indexer. Fixes #52154.
19443 2004-04-27 Martin Baulig <martin@ximian.com>
19445 * statement.cs (Return): Don't create a return label if we don't
19446 need it; reverts my change from January 20th. Thanks to Ben
19449 2004-04-27 Martin Baulig <martin@ximian.com>
19451 According to the spec, `goto' can only leave a nested scope, but
19454 * statement.cs (Block.LookupLabel): Only lookup in the current
19455 block, don't recurse into parent or child blocks.
19456 (Block.AddLabel): Check in parent and child blocks, report
19457 CS0140/CS0158 if we find a duplicate.
19458 (Block): Removed this indexer for label lookups.
19459 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19460 this already does the error reporting for us.
19463 (FlowBranching.UsageVector.Block): New public variable; may be null.
19464 (FlowBranching.CreateSibling): Added `Block' argument.
19465 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19466 label for the target of a `goto' and check whether we're not
19467 leaving a `finally'.
19469 2004-04-27 Martin Baulig <martin@ximian.com>
19471 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19472 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19475 2004-04-27 Martin Baulig <martin@ximian.com>
19477 * statement.cs (Block.AddLabel): Also check for implicit blocks
19478 and added a CS0158 check.
19480 2004-04-27 Martin Baulig <martin@ximian.com>
19482 * flowanalysis.cs (FlowBranchingLoop): New class.
19483 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19484 UsageVector's instead of an ArrayList.
19485 (FlowBranching.Label): Likewise.
19486 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19487 (FlowBranching.AddBreakVector): New method.
19489 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19491 * attribute.cs: Small regression fix: only convert the type if we
19492 the type is different, fixes System.Drawing build.
19494 2004-04-27 Martin Baulig <martin@ximian.com>
19496 * attribute.cs (Attribute.Resolve): If we have a constant value
19497 for a named field or property, implicity convert it to the correct
19500 2004-04-27 Raja R Harinath <rharinath@novell.com>
19502 * statement.cs (Block.Block): Implicit blocks share
19503 'child_variable_names' fields with parent blocks.
19504 (Block.AddChildVariableNames): Remove.
19505 (Block.AddVariable): Mark variable as "used by a child block" in
19506 every surrounding block.
19507 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19508 been used in a child block, complain about violation of "Invariant
19509 meaning in blocks" rule.
19510 * cs-parser.jay (declare_local_variables): Don't use
19511 AddChildVariableNames.
19512 (foreach_statement): Don't create an implicit block: 'foreach'
19513 introduces a scope.
19515 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19517 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19518 converting from 0L to ulong. Fixes 57522.
19520 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19522 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19523 derived class hides via 'new' keyword field from base class (test-242.cs).
19524 TODO: Handle this in the more general way.
19526 * class.cs (CheckBase): Ditto.
19528 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19530 * decl.cs (caching_flags): New member for storing cached values
19532 (MemberCore.Flags): New enum where bit flags for caching_flags
19534 (MemberCore.cls_compliance): Moved to caching_flags.
19535 (DeclSpace.Created): Moved to caching_flags.
19537 * class.cs: Use caching_flags instead of DeclSpace.Created
19539 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19541 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19542 if we are only a derived class, not a nested class.
19544 * typemanager.cs: Same as above, but do this at the MemberLookup
19545 level (used by field and methods, properties are handled in
19546 PropertyExpr). Allow for the qualified access if we are a nested
19549 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19551 * class.cs: Refactoring.
19552 (IMethodData): New inteface; Holds links to parent members
19553 to avoid member duplication (reduced memory allocation).
19554 (Method): Implemented IMethodData interface.
19555 (PropertyBase): New inner classes for get/set methods.
19556 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19557 (Event): New inner classes for add/remove methods.
19558 (Event.DelegateMethod): Implemented IMethodData interface.
19560 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19561 EmitContext (related to class.cs refactoring).
19563 2004-04-21 Raja R Harinath <rharinath@novell.com>
19565 * delegate.cs (Delegate.VerifyApplicability): If the number of
19566 arguments are the same as the number of parameters, first try to
19567 verify applicability ignoring any 'params' modifier on the last
19571 2004-04-16 Raja R Harinath <rharinath@novell.com>
19573 * class.cs (TypeContainer.AddIndexer): Use
19574 'ExplicitInterfaceName' to determine if interface name was
19575 explicitly specified. 'InterfaceType' is not initialized at this time.
19576 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19577 Indexers array is already in the required order. Initialize
19578 'IndexerName' only if there are normal indexers.
19579 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19580 (TypeContainer.Emit): Emit DefaultMember attribute only if
19581 IndexerName is initialized.
19584 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19586 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19589 2004-04-15 Raja R Harinath <rharinath@novell.com>
19591 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19595 * attribute.cs (Attribute.Resolve): Check for duplicate named
19599 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19601 * iterators.cs (MarkYield): track whether we are in an exception,
19602 and generate code accordingly. Use a temporary value to store the
19603 result for our state.
19605 I had ignored a bit the interaction of try/catch with iterators
19606 since their behavior was not entirely obvious, but now it is
19607 possible to verify that our behavior is the same as MS .NET 2.0
19611 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19613 * iterators.cs: Avoid creating temporaries if there is no work to
19616 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19617 Enumerations, use TypeManager.EnumToUnderlying and call
19620 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19623 (This.Emit): Use EmitContext.EmitThis to emit our
19626 (This.EmitAssign): Ditto.
19628 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19629 codepaths, we will move all the functionality into
19632 (FieldExpr.EmitAssign): Ditto.
19634 This fixes several hidden bugs that I uncovered while doing a code
19635 review of this today.
19637 * codegen.cs (EmitThis): reworked so the semantics are more clear
19638 and also support value types "this" instances.
19640 * iterators.cs: Changed so that for iterators in value types, we
19641 do not pass the value type as a parameter.
19643 Initialization of the enumerator helpers is now done in the caller
19644 instead of passing the parameters to the constructors and having
19645 the constructor set the fields.
19647 The fields have now `assembly' visibility instead of private.
19649 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19651 * expression.cs (Argument.Resolve): Check if fields passed as ref
19652 or out are contained in a MarshalByRefObject.
19654 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19655 another compiler type.
19657 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19659 * class.cs (Indexer.Define): use the new name checking method.
19660 Also, return false on an error.
19661 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19662 (is_identifier_[start/part]_character): make static.
19664 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19666 * expression.cs (Binary.ResolveOperator): Do no append strings
19667 twice: since we can be invoked more than once (array evaluation)
19668 on the same concatenation, take care of this here. Based on a fix
19669 from Ben (bug #56454)
19671 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19673 * codegen.cs: Fix another case where CS1548 must be reported (when
19674 delay-sign isn't specified and no private is available #56564). Fix
19675 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19676 error when MCS is used on the MS runtime and we need to delay-sign
19677 (which seems unsupported by AssemblyBuilder - see #56621).
19679 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19681 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19682 (TypeManager.ComputeNamespaces): Faster implementation for
19685 * compiler.csproj: Updated AssemblyName to mcs.
19687 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19689 * rootcontext.cs: Add new types to the boot resolution.
19691 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19692 MulticastDelegate is not allowed.
19694 * typemanager.cs: Add new types to lookup: System.TypedReference
19697 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19698 check for TypedReference or ArgIterator, they are not allowed.
19700 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19701 makes us properly catch 1510 in some conditions (see bug 56016 for
19704 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19706 * CryptoConvert.cs: update from corlib version
19709 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19711 * class.cs (Indexer.Define): Check indexername declaration
19713 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19715 * attribute.cs (IsClsCompliant): Fixed problem with handling
19716 all three states (compliant, not-compliant, undetected).
19718 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19720 * attribute.cs (Attribute): Location is now public.
19721 (Resolve): Store resolved arguments (pos_values) in attribute class.
19722 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19723 (GetClsCompliantAttributeValue): New method that gets
19724 CLSCompliantAttribute value.
19725 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19726 if exists else null.
19727 (AttributeTester): New class for CLS-Compliant verification routines.
19729 * class.cs (Emit): Add CLS-Compliant verification.
19730 (Method.GetSignatureForError): Implemented.
19731 (Constructor.GetSignatureForError): Implemented
19732 (Constructor.HasCompliantArgs): Returns if constructor has
19733 CLS-Compliant arguments.
19734 (Constructor.Emit): Override.
19735 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19736 is needed to test only parameters.
19737 (FieldBase.GetSignatureForError): Implemented.
19738 (TypeContainer): New member for storing base interfaces.
19739 (TypeContainer.FindMembers): Search in base interfaces too.
19741 * codegen.cs (GetClsComplianceAttribute): New method that gets
19742 assembly or module CLSCompliantAttribute value.
19743 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19745 (ModuleClass.Emit): Add error 3012 test.
19747 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19749 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19750 state for all decl types.
19751 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19752 if CLS-Compliant tests are required.
19753 (IsClsCompliaceRequired): New method. Analyze whether code
19754 must be CLS-Compliant.
19755 (IsExposedFromAssembly): New method. Returns true when MemberCore
19756 is exposed from assembly.
19757 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19758 value or gets cached value.
19759 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19760 is explicitly marked with CLSCompliantAttribute.
19761 (IsIdentifierClsCompliant): New abstract method. This method is
19762 used to testing error 3005.
19763 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19764 for identifier and parameters CLS-Compliant testing.
19765 (VerifyClsCompliance): New method. The main virtual method for
19766 CLS-Compliant verifications.
19767 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19768 null. I don't know why is null (too many public members !).
19769 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19770 and get value of first CLSCompliantAttribute that found.
19772 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19773 (VerifyClsCompliance): Override and add extra tests.
19775 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19776 clscheck- disable CLS-Compliant verification event if assembly is has
19777 CLSCompliantAttribute(true).
19779 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19780 ApllyAttribute is now called in emit section as in the other cases.
19781 Possible future Emit integration.
19782 (IsIdentifierClsCompliant): New override.
19783 (VerifyClsCompliance): New override.
19784 (GetEnumeratorName): Returns full enum name.
19786 * parameter.cs (GetSignatureForError): Implemented.
19788 * report.cs (WarningData): New struct for Warning message information.
19789 (LocationOfPreviousError): New method.
19790 (Warning): New method. Reports warning based on the warning table.
19791 (Error_T): New method. Reports error based on the error table.
19793 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19794 verifications are done here.
19796 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19798 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19799 CLSCompliantAttribute.
19800 (all_imported_types): New member holds all imported types from other
19802 (LoadAllImportedTypes): New method fills static table with exported types
19803 from all referenced assemblies.
19804 (Modules): New property returns all assembly modules.
19806 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19808 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19809 throwing a parser error.
19811 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19812 which removes the hardcoded get_/set_ prefixes for properties, as
19813 IL allows for the properties to be named something else.
19817 * expression.cs: Do not override operand before we know if it is
19818 non-null. Fix 56207
19820 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19822 * typemanager.cs: support for pinned variables.
19824 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19826 * decl.cs, typemanager.cs: Avoid using an arraylist
19827 as a buffer if there is only one result set.
19829 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19831 * expression.cs: Make sure you cant call a static method
19832 with an instance expression, bug #56174.
19834 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19836 * class.cs (IsDuplicateImplementation): Improve error reporting to
19837 flag 663 (method only differs in parameter modifier).
19839 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19840 in preprocessor directives.
19842 * location.cs (LookupFile): Allow for the empty path.
19844 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19845 better approach for some of that patch, but its failing with the
19846 CharSet enumeration. For now try/catch will do.
19848 * typemanager.cs: Do not crash if a struct does not have fields.
19851 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19853 * expression.cs: cs0213, cant fix a fixed expression.
19856 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19858 * cs-parser.jay: detect invalid embeded statements gracefully.
19861 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19863 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19866 the invocation type may not be a subclass of the tye of the item/
19867 The type of the item must be a subclass of the invocation item.
19872 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19874 * attribute.cs: Added methods to get a string and a bool from an
19875 attribute. Required to information from AssemblyKeyFileAttribute,
19876 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19877 * codegen.cs: Modified AssemblyName creation to include support for
19878 strongnames. Catch additional exceptions to report them as CS1548.
19879 * compiler.csproj: Updated include CryptoConvert.cs.
19880 * compiler.csproj.user: Removed file - user specific configuration.
19881 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19882 Mono.Security assembly. The original class is maintained and tested in
19883 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19884 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19885 like CSC 8.0 (C# v2) supports.
19886 * Makefile: Added CryptoConvert.cs to mcs sources.
19887 * rootcontext.cs: Added new options for strongnames.
19889 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19891 * driver.cs: For --expect-error, report error code `2'
19892 if the program compiled with no errors, error code `1' if
19893 it compiled with an error other than the one expected.
19895 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19897 * compiler.csproj: Updated for Visual Studio .NET 2003.
19898 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19899 * compiler.sln: Updated for Visual Studio .NET 2003.
19901 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19903 * expression.cs: Fix bug #47234. We basically need to apply the
19904 rule that we prefer the conversion of null to a reference type
19905 when faced with a conversion to 'object' (csc behaviour).
19907 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19909 * statement.cs: Shorter form for foreach, eliminates
19910 a local variable. r=Martin.
19912 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19914 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19915 checks if we can use brtrue/brfalse to test for 0.
19916 * expression.cs: use the above in the test for using brtrue/brfalse.
19917 cleanup code a bit.
19919 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19921 * expression.cs: Rewrite string concat stuff. Benefits:
19923 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19924 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19925 rather than a concat chain.
19927 * typemanager.cs: Add lookups for more concat overloads.
19929 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19931 * expression.cs: Emit shorter il code for array init.
19948 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19950 * statement.cs: Before, two switch blocks would be merged if the
19951 total size of the blocks (end_item - begin_item + 1) was less than
19952 two times the combined sizes of the blocks.
19954 Now, it will only merge if after the merge at least half of the
19959 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19961 * class.cs : csc build fix for GetMethods(). See bug #52503.
19963 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19965 * expression.cs: Make sure fp comparisons work with NaN.
19966 This fixes bug #54303. Mig approved this patch a long
19967 time ago, but we were not able to test b/c the runtime
19970 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19972 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19974 2004-03-19 Martin Baulig <martin@ximian.com>
19976 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19977 error here and not in our caller.
19979 2004-03-19 Martin Baulig <martin@ximian.com>
19981 * interface.cs: Completely killed this file.
19982 (Interface): We're now a TypeContainer and live in class.cs.
19984 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19985 argument; we're now also called for interfaces.
19986 (TypeContainer.DefineMembers): Allow this method being called
19988 (TypeContainer.GetMethods): New public method; formerly known as
19989 Interface.GetMethod(). This is used by PendingImplementation.
19990 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19991 it's now private and non-static.
19992 (Interface): Moved this here; it's now implemented similar to
19994 (Method, Property, Event, Indexer): Added `bool is_interface'
19995 argument to their .ctor's.
19996 (MemberBase.IsInterface): New public field.
19998 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19999 instances instead of InterfaceMethod, InterfaceProperty, etc.
20000 (opt_interface_base): Removed; we now use `opt_class_base' instead.
20001 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
20003 2004-03-19 Martin Baulig <martin@ximian.com>
20005 * class.cs (MethodCore.IsDuplicateImplementation): New private
20006 method which does the CS0111 checking.
20007 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
20008 Use IsDuplicateImplementation().
20010 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
20012 * decl.cs (FindMemberToOverride): New method to find the correct
20013 method or property to override in the base class.
20015 - Make Method/Property use the above method to find the
20016 version in the base class.
20017 - Remove the InheritableMemberSignatureCompare as it is now
20020 This patch makes large code bases much faster to compile, as it is
20021 O(n) rather than O(n^2) to do this validation.
20023 Also, it fixes bug 52458 which is that nested classes are not
20024 taken into account when finding the base class member.
20026 Reviewed/Approved by Martin.
20028 2004-03-17 Marek Safar <marek.safar@seznam.cz>
20030 * interface.cs: In all interface classes removed redundant
20031 member initialization.
20033 2004-03-16 Martin Baulig <martin@ximian.com>
20035 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
20037 2004-03-15 Miguel de Icaza <miguel@ximian.com>
20039 * decl.cs (DefineTypeAndParents): New helper method to define a
20040 type's containers before the type itself is defined; This is a
20041 bug exposed by the recent changes to Windows.Forms when an
20042 implemented interface was defined inside a class that had not been
20045 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
20047 (Check): Loop correctly to report errors modifiers
20048 (UNSAFE was not in the loop, since it was the same as TOP).
20050 * interface.cs: Every interface member now takes a ModFlags,
20051 instead of a "is_new" bool, which we set on the base MemberCore.
20053 Every place where we called "UnsafeOk" in the interface, now we
20054 call the proper member (InterfaceMethod.UnsafeOK) instead to get
20055 the unsafe settings from the member declaration instead of the
20056 container interface.
20058 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
20060 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
20061 `set_indexer_name' to the pending bits (one per type).
20063 We fixed a bug today that was picking the wrong method to
20064 override, since for properties the existing InterfaceMethod code
20065 basically ignored the method name. Now we make sure that the
20066 method name is one of the valid indexer names.
20068 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
20070 * support.cs (SeekableStreamReader): Keep track of stream byte
20071 positions and don't mix them with character offsets to the buffer.
20073 Patch from Gustavo Giráldez
20075 2004-03-15 Marek Safar <marek.safar@seznam.cz>
20077 * interface.cs (InterfaceSetGetBase): Removed double member
20078 initialization, base class does it as well.
20080 2004-03-13 Martin Baulig <martin@ximian.com>
20082 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
20083 when compiling corlib.
20085 2004-03-13 Miguel de Icaza <miguel@ximian.com>
20087 * convert.cs (ExplicitConversion): We were reporting an error on
20088 certain conversions (object_type source to a value type, when the
20089 expression was `null') before we had a chance to pass it through
20090 the user defined conversions.
20092 * driver.cs: Replace / and \ in resource specifications to dots.
20095 * class.cs: Add check for duplicate operators. Fixes 52477
20097 2004-03-11 Miguel de Icaza <miguel@ximian.com>
20099 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
20100 that are in the middle of the statements, not only at the end.
20103 * class.cs (TypeContainer.AddField): No longer set the
20104 `HaveStaticConstructor' flag, now we call it
20105 `UserDefineStaticConstructor' to diferentiate the slightly
20106 semantic difference.
20108 The situation is that we were not adding BeforeFieldInit (from
20109 Modifiers.TypeAttr) to classes that could have it.
20110 BeforeFieldInit should be set to classes that have no static
20115 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
20117 And most importantly Zoltan's comment:
20119 http://bugzilla.ximian.com/show_bug.cgi?id=44229
20121 "I think beforefieldinit means 'it's ok to initialize the type sometime
20122 before its static fields are used', i.e. initialization does not need
20123 to be triggered by the first access to the type. Setting this flag
20124 helps the JIT to compile better code, since it can run the static
20125 constructor at JIT time, and does not need to generate code to call it
20126 (possibly lots of times) at runtime. Unfortunately, mcs does not set
20127 this flag for lots of classes like String.
20129 csc sets this flag if the type does not have an explicit static
20130 constructor. The reasoning seems to be that if there are only static
20131 initalizers for a type, and no static constructor, then the programmer
20132 does not care when this initialization happens, so beforefieldinit
20135 This bug prevents the AOT compiler from being usable, since it
20136 generates so many calls to mono_runtime_class_init that the AOT code
20137 is much slower than the JITted code. The JITted code is faster,
20138 because it does not generate these calls if the vtable is type is
20139 already initialized, which is true in the majority of cases. But the
20140 AOT compiler can't do this."
20142 2004-03-10 Miguel de Icaza <miguel@ximian.com>
20144 * class.cs (MethodData.Emit): Refactor the code so symbolic
20145 information is generated for destructors; For some reasons we
20146 were taking a code path that did not generate symbolic information
20149 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
20151 * class.cs: Create a Constructor.CheckBase method that
20152 takes care of all validation type code. The method
20153 contains some code that was moved from Define.
20155 It also includes new code that checks for duplicate ctors.
20156 This fixes bug #55148.
20158 2004-03-09 Joshua Tauberer <tauberer@for.net>
20160 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
20161 a { ... }-style array creation invokes EmitStaticInitializers
20162 which is not good for reference-type arrays. String, decimal
20163 and now null constants (NullCast) are not counted toward
20164 static initializers.
20166 2004-03-05 Martin Baulig <martin@ximian.com>
20168 * location.cs (SourceFile.HasLineDirective): New public field;
20169 specifies whether the file contains or is referenced by a "#line"
20171 (Location.DefineSymbolDocuments): Ignore source files which
20172 either contain or are referenced by a "#line" directive.
20174 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
20176 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
20177 direct access to our parent, so check the method inline there.
20179 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
20181 * expression.cs (Invocation.EmitCall): Miguel's last commit
20182 caused a regression. If you had:
20187 In Foo the implict this would be null.
20189 2004-02-27 Miguel de Icaza <miguel@ximian.com>
20191 * expression.cs (Invocation.EmitCall): If the method is not
20192 virtual, do not emit a CallVirt to it, use Call.
20194 * typemanager.cs (GetFullNameSignature): Improve the method to
20195 cope with ".ctor" and replace it with the type name.
20197 * class.cs (ConstructorInitializer.Resolve): Now the method takes
20198 as an argument the ConstructorBuilder where it is being defined,
20199 to catch the recursive constructor invocations.
20201 2004-02-26 Miguel de Icaza <miguel@ximian.com>
20203 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
20204 routines to check if a type is an enumerable/enumerator allow
20205 classes that implement the IEnumerable or IEnumerator interfaces.
20207 * class.cs (Property, Operator): Implement IIteratorContainer, and
20208 implement SetYields.
20210 (Property.Define): Do the block swapping for get_methods in the
20211 context of iterators. We need to check if Properties also
20212 include indexers or not.
20214 (Operator): Assign the Block before invoking the
20215 OperatorMethod.Define, so we can trigger the Iterator code
20218 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20219 Property and Operator classes are not created when we parse the
20220 declarator but until we have the block completed, so we use a
20221 singleton SimpleIteratorContainer.Simple to flag whether the
20222 SetYields has been invoked.
20224 We propagate this setting then to the Property or the Operator to
20225 allow the `yield' to function.
20227 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20229 * codegen.cs: Implemented attribute support for modules.
20230 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20231 Assembly/Module functionality.
20233 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20234 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20235 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20237 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20239 * interface.cs (FindMembers): The operation is performed on all base
20240 interfaces and not only on the first. It is required for future CLS Compliance patch.
20242 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20244 * statement.cs, codegen.cs:
20245 This patch deals with patterns such as:
20247 public class List : IEnumerable {
20249 public MyEnumerator GetEnumerator () {
20250 return new MyEnumerator(this);
20253 IEnumerator IEnumerable.GetEnumerator () {
20257 public struct MyEnumerator : IEnumerator {
20262 Before, there were a few things we did wrong:
20263 1) we would emit callvirt on a struct, which is illegal
20264 2) we emited ldarg when we needed to emit ldarga
20265 3) we would mistakenly call the interface methods on an enumerator
20266 type that derived from IEnumerator and was in another assembly. For example:
20268 public class MyEnumerator : IEnumerator
20270 Would have the interface methods called, even if there were public impls of the
20271 method. In a struct, this lead to invalid IL code.
20273 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20275 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20278 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20280 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20282 * cs-parser.jay: Fix small regression: we were not testing V2
20283 compiler features correctly.
20285 * interface.cs: If the emit context is null, then create one
20287 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20289 * decl.cs (GetSignatureForError): New virtual method to get full name
20290 for error messages.
20292 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20293 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20295 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20296 Duplicated members and code in these classes has been removed.
20297 Better encapsulation in these classes.
20299 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20301 * assign.cs (Assign.DoResolve): When dealing with compound
20302 assignments, there is a new rule in ECMA C# 2.4 (might have been
20303 there before, but it is documented here) that states that in:
20307 If b is of type int, and the `op' is a shift-operator, then the
20308 above is evaluated as:
20312 * expression.cs (Binary.ResolveOperator): Instead of testing for
20313 int/uint/long/ulong, try to implicitly convert to any of those
20314 types and use that in pointer arithmetic.
20316 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20317 method to print information for from the type, not from the
20318 null-method we were given.
20320 2004-02-01 Duncan Mak <duncan@ximian.com>
20322 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20323 parsing for cmd, fixes bug #53694.
20325 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20327 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20328 in the member name duplication tests. Property and operator name duplication
20329 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20331 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20333 * interface.cs (PopulateMethod): Fixed crash when interface method
20334 returns not existing type (error test cs0246-3.cs).
20336 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20338 * cs-parser.jay (interface_accessors): Re-write actions to also
20339 store attributes attached to get and set methods. Fix spelling
20342 (inteface_property_declaration): Modify accordingly.
20344 (InterfaceAccessorInfo): New helper class to store information to pass
20345 around between rules that use interface_accessors.
20347 * interface.cs (Emit): Apply attributes on the get and set
20348 accessors of properties and indexers too.
20350 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20351 right MethodBuilder when applying attributes to the get and set accessors.
20353 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20355 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20357 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20359 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20361 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20363 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20364 changes that treat `yield' specially when present before `break'
20365 or `return' tokens.
20367 * cs-tokenizer.cs: yield is no longer a keyword.
20369 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20371 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20372 setting for default constructors.
20373 For default constructors are almost every time set wrong Modifier. The
20374 generated IL code has been alright. But inside mcs this values was
20375 wrong and this was reason why several of my CLS Compliance tests
20378 2004-01-22 Martin Baulig <martin@ximian.com>
20380 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20381 not a QualifiedIdentifier. This is what `type_name_expression'
20382 was previously doing.
20383 (type_name_expression): Removed; the code is now in
20384 `namespace_or_type_name'.
20385 (qualified_identifier): Removed, use `namespace_or_type_name'
20387 (QualifiedIdentifier): Removed this class.
20389 2004-01-22 Martin Baulig <martin@ximian.com>
20391 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20392 not a string as alias name.
20394 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20396 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20397 #52730 bug, and instead compute correctly the need to use a
20398 temporary variable when requesting an address based on the
20399 static/instace modified of the field and the constructor.
20401 2004-01-21 Martin Baulig <martin@ximian.com>
20403 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20404 class and namespace before looking up aliases. Fixes #52517.
20406 2004-01-21 Martin Baulig <martin@ximian.com>
20408 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20409 assinged in a 'try'; fixes exception4.cs.
20411 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20412 * class.cs : Implemented parameter-less constructor for TypeContainer
20414 * decl.cs: Attributes are now stored here. New property OptAttributes
20416 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20418 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20420 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20422 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20423 (CSharpSignature): New method for indexer and property signature.
20425 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20427 * pending.cs (IsVirtualFilter): Faster implementation.
20429 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20431 * typemanager.cs: Avoid inclusion of same assembly more than once.
20433 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20435 * cs-parser.jay: Fixed problem where the last assembly attribute
20436 has been applied also to following declaration (class, struct, etc.)
20438 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20440 * class.cs: Added error CS0538, CS0539 reporting.
20441 Fixed crash on Microsoft runtime when field type is void.
20443 * cs-parser.jay: Added error CS0537 reporting.
20445 * pending.cs: Added error CS0535 reporting.
20446 Improved error report for errors CS0536, CS0534.
20448 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20450 Merge a few bits from the Anonymous Method MCS tree.
20452 * statement.cs (ToplevelBlock): New class for toplevel methods,
20453 will hold anonymous methods, lifted variables.
20455 * cs-parser.jay: Create toplevel blocks for delegates and for
20456 regular blocks of code.
20458 2004-01-20 Martin Baulig <martin@ximian.com>
20460 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20461 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20462 and `NeedExplicitReturn'; added `IsLastStatement'.
20463 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20464 have a `ReturnLabel' or we're not unreachable.
20466 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20467 child's reachability; don't just override ours with it. Fixes
20468 #58058 (lluis's example).
20469 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20470 InFinally(), InLoop(), InSwitch() and
20471 BreakCrossesTryCatchBoundary() methods.
20473 * statement.cs (Return): Do all error checking in Resolve().
20474 Unless we are the last statement in a top-level block, always
20475 create a return label and jump to it.
20476 (Break, Continue): Do all error checking in Resolve(); also make
20477 sure we aren't leaving a `finally'.
20478 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20479 statement in a top-level block.
20480 (Block.Flags): Added `IsDestructor'.
20481 (Block.IsDestructor): New public property.
20483 2004-01-20 Martin Baulig <martin@ximian.com>
20485 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20487 2004-01-20 Martin Baulig <martin@ximian.com>
20489 * statement.cs (Statement.ResolveUnreachable): New public method.
20490 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20491 (Block.Resolve): Resolve unreachable statements.
20493 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20495 * expression.cs: We need to fix the case where we do
20496 not have a temp variable here.
20498 * assign.cs: Only expression compound assignments need
20499 temporary variables.
20501 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20503 * flowanalysis.cs: Reduce memory allocation in a few ways:
20504 - A block with no variables should not allocate a bit
20506 - A method with no out parameters does not need any tracking
20507 for assignment of the parameters, so we need not allocate
20510 public readonly Type[] VariableTypes;
20511 public readonly string[] VariableNames;
20512 Are redundant. The data is already stored in the variable
20513 map, so we need not allocate another array for it.
20514 - We need to add alot of checks for if (params | locals) == null
20515 due to the first two changes.
20517 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20519 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20520 implement IMemoryLocation, we store a copy on a local variable and
20521 take the address of it. Patch from Benjamin Jemlich
20523 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20524 to use a special "type_name_expression" rule which reduces the
20525 number of "QualifiedIdentifier" classes created, and instead
20526 directly creates MemberAccess expressions.
20528 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20530 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20531 that fixes #52853. Null literal assignment to ValueType
20533 * class.cs (MethodData.Emit): Instead of checking the name of the
20534 method to determine if its a destructor, create a new derived
20535 class from Method called Destructor, and test for that.
20537 * cs-parser.jay: Create a Destructor object instead of a Method.
20539 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20543 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20545 * expression.cs (Binary.ResolveOperator): Perform an implicit
20546 conversion from MethodGroups to their delegate types on the
20547 Addition operation.
20549 * delegate.cs: Introduce a new class DelegateCreation that is the
20550 base class for `NewDelegate' and `ImplicitDelegateCreation',
20551 factor some code in here.
20553 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20554 conversion from MethodGroups to compatible delegate types.
20556 * ecore.cs (Expression.Resolve): Do not flag error 654
20557 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20558 we allow conversions from MethodGroups to delegate types now.
20560 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20561 assignments in v2 either.
20563 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20565 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20566 static read-only fields in ctors.
20568 Applied patch from Benjamin Jemlich
20570 * expression.cs (UnaryMutator): Avoid leaking local variables.
20572 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20574 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20575 here to return true, as they can be used like this:
20577 (XXX) int.MEMBER ()
20579 Fixed 49836 and all the other dups
20581 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20583 * driver.cs: Implement /win32res and /win32icon.
20585 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20587 * cs-parser.jay: Add a rule to improve error handling for the
20588 common mistake of placing modifiers after the type.
20590 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20592 * cs-parser.jay (interface_event_declaration): Catch
20593 initialization of events on interfaces, and report cs0068
20595 * cs-parser.jay (interface_event_declaration): Catch
20596 initialization of events.
20598 * ecore.cs: Better report missing constructors.
20600 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20601 the error reporting done in the wrong place. Fix.
20603 * expression.cs (Binary.ResolveOperator): Catch the
20604 operator + (E x, E y) error earlier, and later allow for implicit
20605 conversions in operator +/- (E e, U x) from U to the underlying
20608 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20609 52596, if the container class is abstract, the default constructor
20610 is protected otherwise its public (before, we were always public).
20612 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20615 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20616 Jemlich that fixes bug #52597, MCS was generating invalid code for
20617 idisposable structs. Thanks to Ben for following up with this
20620 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20622 * driver.cs: Allow assemblies without code to be generated, fixes
20625 2004-01-07 Nick Drochak <ndrochak@gol.com>
20627 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20629 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20631 * cs-parser.jay: Add rules to improve error reporting if fields or
20632 methods are declared at the namespace level (error 116)
20634 * Add rules to catch event add/remove
20636 2004-01-04 David Sheldon <dave-mono@earth.li>
20638 * expression.cs: Added matching ")" to error message for
20641 2004-01-03 Todd Berman <tberman@gentoo.org>
20643 * ecore.cs, attribute.cs:
20644 Applying fix from #52429.
20646 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20648 * ecore.cs, expression.cs, statement.cs:
20649 Total rewrite of how we handle branching. We
20650 now handle complex boolean expressions with fewer
20651 jumps. As well if (x == 0) no longer emits a ceq.
20653 if (x is Foo) is much faster now, because we generate
20656 Overall, we get a pretty big improvement on our benchmark
20657 tests. The code we generate is smaller and more readable.
20659 I did a full two-stage bootstrap. The patch was reviewed
20660 by Martin and Miguel.
20662 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20664 * cs-parser.jay: Make primary_expression not take a QI.
20665 we dont need this because the member_access rule covers
20666 us here. So we replace the rule with just IDENTIFIER.
20668 This has two good effects. First, we remove a s/r conflict.
20669 Second, we allocate many fewer QualifiedIdentifier objects.
20671 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20673 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20674 set the correct information via SRE. This prevents
20675 hanging on the MS runtime. Fixes #29374.
20677 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20679 * convert.cs: correctly handle conversions to value types
20680 from Enum and ValueType as unboxing conversions.
20682 Fixes bug #52569. Patch by Benjamin Jemlich.
20684 2004-01-02 Ravi Pratap <ravi@ximian.com>
20686 * expression.cs (BetterConversion): Prefer int -> uint
20687 over int -> ulong (csc's behaviour). This fixed bug #52046.
20689 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20691 * decl.cs (MemberCache.FindMembers): now returns a
20694 * typemanager.cs: In general, go with with ^^.
20695 (CopyNewMethods): take an IList.
20696 (RealMemberLookup): Only allocate an arraylist
20697 if we copy from two sets of methods.
20699 This change basically does two things:
20700 1) Fewer array lists allocated due to CopyNewMethods.
20701 2) the explicit cast in MemberList costed ALOT.
20703 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20705 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20706 a hashtable to avoid needless string allocations when an identifier is
20707 used more than once (the common case).
20709 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20711 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20712 is broken, it will not return anything. So, we
20713 have to use the information we have in mcs to
20716 * typemanager.cs: Add a cache for GetInterfaces,
20717 since this will now be used more often (due to ^^)
20719 (GetExplicitInterfaces) New method that gets the
20720 declared, not effective, interfaces on a type
20721 builder (eg, if you have interface IFoo, interface
20722 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20725 This patch makes MCS able to bootstrap itself on
20728 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20730 * expression.cs: Remove the Nop's that Miguel put
20733 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20735 * report.cs, codegen.cs: Give the real stack trace to
20736 the error when an exception is thrown.
20738 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20740 * decl.cs: only allocate hashtables for ifaces if
20743 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20745 * expression.cs: fix the error from cs0121-2.cs
20746 (a parent interface has two child interfaces that
20747 have a function with the same name and 0 params
20748 and the function is called through the parent).
20750 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20752 * class.cs, rootcontext.cs, typmanager.cs: do not
20755 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20757 * codegen.cs: remove stack for the ec flow branching.
20758 It is already a linked list, so no need.
20760 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20762 * Makefile: Allow custom profiler here.
20764 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20766 * typemanager.cs (LookupType):
20767 - Use a static char [], because split takes
20768 a param array for args, so it was allocating
20770 - Do not store true in a hashtable, it boxes.
20772 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20774 * flowanalysis.cs: bytify common enums.
20776 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20778 * modifiers.cs: Add a new set of flags for the
20779 flags allowed on explicit interface impls.
20780 * cs-parser.jay: catch the use of modifiers in
20781 interfaces correctly.
20782 * class.cs: catch private void IFoo.Blah ().
20784 All related to bug #50572.
20786 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20788 * decl.cs: Rewrite the consistant accessability checking.
20789 Accessability is not linear, it must be implemented in
20790 a tableish way. Fixes #49704.
20792 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20794 * expression.cs: Handle negation in a checked context.
20795 We must use subtraction from zero. Fixes #38674.
20797 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20799 * class.cs: Ignore static void main in DLLs.
20800 * rootcontext.cs: Handle the target type here,
20801 since we are have to access it from class.cs
20802 * driver.cs: account for the above.
20804 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20806 * report.cs: Give line numbers and files if available.
20808 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20810 * driver.cs: Implement /addmodule.
20812 * typemanager.cs: Change 'modules' field so it now contains Modules not
20815 2003-12-20 Martin Baulig <martin@ximian.com>
20817 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20818 (FieldBase.IsAssigned): Removed this field.
20819 (FieldBase.SetAssigned): New public method.
20820 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20822 2003-12-20 Martin Baulig <martin@ximian.com>
20824 * expression.cs (LocalVariableReference.DoResolve): Don't set
20825 `vi.Used' if we're called from DoResolveLValue().
20827 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20828 returns the usage vector it just merged into the current one -
20829 pass this one to UsageWarning().
20830 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20831 of the `EmitContext', don't call this recursively on our children.
20833 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20835 * driver.cs: Implement /target:module.
20837 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20839 * support.cs (CharArrayHashtable): New helper class.
20841 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20842 char arrays, not strings, so we can avoid creating a string in
20843 consume_identifier if the identifier is a keyword.
20845 2003-12-16 Martin Baulig <martin@ximian.com>
20847 * statement.cs (LocalInfo.Assigned): Removed this property.
20848 (LocalInfo.Flags): Removed `Assigned'.
20849 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20850 and uses flow analysis.
20851 (Block.UsageWarning): Made this method private.
20852 (Block.Resolve): Call UsageWarning() if appropriate.
20854 * expression.cs (LocalVariableReference.DoResolve): Always set
20855 LocalInfo.Used here.
20857 2003-12-13 Martin Baulig <martin@ximian.com>
20859 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20860 any value here; we're now using flow analysis to figure out
20861 whether a statement/block returns a value.
20863 2003-12-13 Martin Baulig <martin@ximian.com>
20865 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20867 (FlowBranching.MergeFinally): Don't call
20868 `branching.CheckOutParameters()' here, this is called in
20870 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20871 when adding the `finally' vector.
20873 2003-12-13 Martin Baulig <martin@ximian.com>
20876 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20877 actually work and also fix #48962.
20879 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20881 * decl.cs: Do not check System.Object for nested types,
20882 since we know it does not have any. Big bang for buck:
20885 Run 1: 8.35 seconds
20886 Run 2: 8.32 seconds
20887 corlib: 17.99 seconds
20889 Run 1: 8.17 seconds
20890 Run 2: 8.17 seconds
20891 corlib: 17.39 seconds
20893 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20895 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20896 time we are returning 0 members, so we save alot here.
20898 2003-12-11 Martin Baulig <martin@ximian.com>
20900 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20901 `MergeChild()', also just take the `FlowBranching' as argument;
20902 call Merge() on it and return the result.
20903 (FlowBranching.Merge): We don't need to do anything if we just
20906 2003-12-11 Martin Baulig <martin@ximian.com>
20908 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20909 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20910 Maurer for this idea.
20912 2003-12-11 Martin Baulig <martin@ximian.com>
20914 * flowanalysis.cs (MergeResult): This class is now gone; we now
20915 use the `UsageVector' for this. The reason for this is that if a
20916 branching just has one sibling, we don't need to "merge" them at
20917 all - that's the next step to do.
20918 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20921 2003-12-11 Martin Baulig <martin@ximian.com>
20923 Reworked flow analyis and made it more precise and bug-free. The
20924 most important change is that we're now using a special `Reachability'
20925 class instead of having "magic" meanings of `FlowReturns'. I'll
20926 do some more cleanups and optimizations and also add some more
20927 documentation this week.
20929 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20930 largely reworked this class.
20931 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20932 the new `Reachability' class instead of having "magic" values here.
20933 (FlowBranching): We're now using an instance of `Reachability'
20934 instead of having separate `Returns', `Breaks' etc. fields.
20936 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20937 based on flow analysis; ignore the return value of block.Emit ().
20939 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20941 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20942 if they are private.
20944 2003-12-09 Martin Baulig <martin@ximian.com>
20946 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20947 call them directly on the UsageVector.
20949 2003-12-09 Martin Baulig <martin@ximian.com>
20951 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20952 Changed return type from `FlowReturns' to `Reachability'.
20954 2003-12-09 Martin Baulig <martin@ximian.com>
20956 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20957 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20958 `Reachable' fields with a single `Reachability' one.
20960 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20962 * class.cs (FindMembers): Remove foreach's.
20967 Run 1: 8.74 seconds
20968 Run 2: 8.71 seconds
20971 Run 1: 8.64 seconds
20972 Run 2: 8.58 seconds
20975 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20980 This patch does a few things:
20981 1. EmptyStatement is now a singleton, so it is never reallocated.
20982 2. All blah is EmptyStatement constructs have been changed to
20983 blah == EmptyStatement.Value, which is much faster and valid
20984 now that EmptyStatement is a singleton.
20985 3. When resolving a block, rather than allocating a new array for
20986 the non-empty statements, empty statements are replaced with
20987 EmptyStatement.Value
20988 4. Some recursive functions have been made non-recursive.
20989 Mainly the performance impact is from (3), however (1) and (2) are needed for
20990 this to work. (4) does not make a big difference in normal situations, however
20991 it makes the profile look saner.
20996 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20997 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20998 Total memory allocated: 56397 KB
21001 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
21002 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
21003 Total memory allocated: 55666 KB
21005 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21007 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
21008 than the hashtable in a hashtable version
21010 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
21011 we always end up concating a string. This results in a huge perf
21012 loss, because many strings have to be tracked by the GC. In this
21013 patch, we first use a hashtable that works with two keys, so that
21014 the strings do not need to be concat'ed.
21018 Run 1: 8.74 seconds
21019 Run 2: 8.71 seconds
21022 Run 1: 8.65 seconds
21023 Run 2: 8.56 seconds
21025 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
21027 * Makefile: Add a new target `do-time' that does a quick and simple
21028 profile, leaving easy to parse output.
21030 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
21032 * codegen.cs (Init): Create the dynamic assembly with
21033 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
21035 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
21037 * support.cs: Make the PtrHashtable use only one
21038 instance of its comparer.
21040 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
21042 * typemanager.cs: Fix lookup of GetNamespaces.
21044 2003-11-29 Miguel de Icaza <miguel@ximian.com>
21046 * expression.cs: Removed redundant line.
21048 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
21049 ArrayLists, use for loops with bounds.
21051 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
21054 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
21055 arraylists, use for loop with bounds.
21057 The above three changes give us a 0.071 second performance
21058 improvement out of 3.294 seconds down to 3.223. On my machine
21059 the above changes reduced the memory usage by 1,387 KB during
21060 compiler bootstrap.
21062 * cs-parser.jay (QualifiedIdentifier): New class used to represent
21063 QualifiedIdentifiers. Before we created a new string through
21064 concatenation, and mostly later on, the result would be
21065 manipulated by DecomposeQI through string manipulation.
21067 This reduced the compiler memory usage for bootstrapping from
21068 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
21069 compile times in 0.05 seconds.
21071 2003-11-28 Dick Porter <dick@ximian.com>
21073 * support.cs: Do string compares with the Invariant culture.
21081 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
21082 the comparison is done with the Invariant culture.
21084 2003-11-27 Miguel de Icaza <miguel@ximian.com>
21086 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
21087 GetEnumerator method.
21089 (ProbeCollectionType): Iterate starting at the most specific type
21090 upwards looking for a GetEnumerator
21092 * expression.cs: Shift count can be up to 31 for int/uint and 63
21095 2003-11-26 Miguel de Icaza <miguel@ximian.com>
21097 * statement.cs (Block.LookupLabel): Also look for the label on the
21098 children blocks. Use a hash table to keep track of visited
21101 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
21102 we actually did transform the other operand, otherwise fall back
21103 to the common codepath that casts to long.
21105 * cs-tokenizer.cs: Use the same code pattern as the int case.
21106 Maybe I should do the parsing myself, and avoid depending on the
21107 Parse routines to get this done.
21109 2003-11-25 Miguel de Icaza <miguel@ximian.com>
21111 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21112 which fixes bug 51347. This time test it.
21114 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
21115 attributes for example can not tell the difference between these.
21116 The difference was only a syntax feature of the language.
21118 * attribute.cs: Apply attributes to delegates.
21120 * delegate.cs: Call the apply attributes method.
21122 2003-11-24 Miguel de Icaza <miguel@ximian.com>
21124 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
21125 comparing 0 vs Byte.MinValue, not the value
21127 (ImplicitConversionRequired): When reporting a conversion error,
21128 use error 31 to print out the constant error instead of the
21131 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
21132 which fixes bug 51347.
21134 2003-11-22 Miguel de Icaza <miguel@ximian.com>
21136 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
21137 which fixes the -warnaserror command line option.
21139 2003-11-21 Miguel de Icaza <miguel@ximian.com>
21141 * cfold.cs (DoNumericPromotions): During constant folding of
21142 additions on UIntConstant, special case intconstants with
21143 IntConstants like we do on the expression binary operator.
21145 2003-11-12 Miguel de Icaza <miguel@ximian.com>
21147 * convert.cs (ImplicitReferenceConversion): We were missing a case
21148 (System.Enum are not value types or class types, so we need to
21149 classify them separatedly).
21151 * driver.cs: We do not support error 2007.
21153 2003-11-12 Jackson Harper <jackson@ximian.com>
21155 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
21156 system directory. Also use the full file name so users can
21157 libraries names mscorlib-o-tron.dll in a non system dir.
21159 2003-11-10 Martin Baulig <martin@ximian.com>
21161 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
21162 (TypeManager.InitCoreTypes): Initialize them here, but instead of
21163 calling `ResolveType()' on them, directly assign their `Type'.
21165 2003-11-08 Martin Baulig <martin@ximian.com>
21167 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
21168 return value and the `out parent' parameter.
21169 (TypeContainer.DefineType): Moved the CS0644 check into
21170 GetClassBases(). Don't pass the interface types to the
21171 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
21172 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
21174 * ecore.cs (TypeExpr.IsAttribute): New property.
21175 (TypeExpr.GetInterfaces): New method.
21177 * interface.cs (Interface.GetInterfaceTypeByName): Return a
21178 TypeExpr instead of a Type.
21179 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
21180 (Interface.DefineType): Don't pass the interface types to the
21181 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
21182 them later and then call `TypeBulider.AddInterfaceImplementation()'.
21184 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
21185 instead of a `Type[]'.
21186 (TypeManager.RegisterBuilder): Likewise.
21187 (TypeManager.AddUserInterface): Likewise.
21188 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
21189 `Type[]' and also return a `TypeExpr[]'.
21190 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
21192 2003-11-08 Martin Baulig <martin@ximian.com>
21194 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
21197 2003-11-08 Martin Baulig <martin@ximian.com>
21199 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
21200 TypeManager.ResolveExpressionTypes().
21202 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
21203 instead of an Expression.
21204 (TypeExpr): This is now an abstract base class for `TypeExpression'.
21205 (TypeExpression): New public class; formerly known as `TypeExpr'.
21207 * expression.cs (ComposedCast): Derive from TypeExpr.
21209 * typemanager.cs (TypeManager.system_*_expr): These are now
21210 TypExpr's instead of Expression's.
21211 (TypeManager.ResolveExpressionTypes): New public static function;
21212 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21215 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21217 * expression.cs (New.DoResolve): Do not dereference value that
21218 might be a null return.
21220 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21221 sure that the constant value has the right type. Fixes an
21222 unreported bug, similar to 50425.
21224 * const.cs (Const.LookupConstantValue): Call
21225 ImplicitStandardConversionExists before doing a conversion to
21226 avoid havng the TypeManager.ChangeType do conversions.
21228 Reduced the number of casts used
21230 (Const.ChangeType): New routine to enable reuse of the constant
21231 type changing code from statement.
21233 * typemanager.cs (ChangeType): Move common initialization to
21234 static global variables.
21238 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21239 every value type to go through, even if it was void. Fix that.
21241 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21242 character of the define, and the is_identifier_part_character for
21243 the rest of the string.
21245 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21247 * expression.cs (UnaryMutator.EmitCode): When I updated
21248 LocalVariableReference.DoResolve, I overdid it, and dropped an
21249 optimization done on local variable references.
21251 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21253 * ecore.cs: Convert the return from Ldlen into an int.
21255 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21257 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21258 the accessibility, this is a special case for toplevel non-public
21259 classes (internal for instance).
21261 2003-10-20 Nick Drochak <ndrochak@gol.com>
21263 * ecore.cs: Fix typo and build. Needed another right paren.
21265 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21267 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21268 `internal' case regular and protected, but not allowing protected
21269 to be evaluated later. Bug 49840
21271 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21273 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21274 to kb.Nlast, and not the kb.nFirst to isolate the switch
21277 Extract the underlying type, so enumerations of long/ulong are
21278 treated like long/ulong.
21280 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21282 * expression.cs (New): Overload the meaning of RequestedType to
21283 track the possible creation of the NewDelegate type, since
21284 DoResolve is invoked more than once for new constructors on field
21287 See bugs: #48800 and #37014
21289 * cs-parser.jay (declare_local_constants): Take an arraylist
21290 instead of a single constant.
21292 (local_constant_declaration): It should take a
21293 constant_declarators, not a constant_declarator. Fixes 49487
21295 * convert.cs: Fix error report.
21297 2003-10-13 Jackson Harper <jackson@ximian.com>
21299 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21302 2003-10-09 Martin Baulig <martin@ximian.com>
21304 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21306 (MethodCore.DoDefineParameters): Removed the TypeContainer
21307 argument; use the DeclSpace which was passed to the .ctor instead.
21308 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21309 TypeContainer; we only need a DeclSpace here.
21311 2003-10-09 Martin Baulig <martin@ximian.com>
21313 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21315 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21316 EmitContext's .ctor.
21318 2003-10-09 Martin Baulig <martin@ximian.com>
21320 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21321 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21322 AsAccessible(), moved them as well.
21324 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21326 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21328 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21330 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21332 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21333 generation for >=, as spotted by Paolo, bug 48679.
21334 Patch from David Waite.
21336 * cs-tokenizer.cs: Add handling for #pragma.
21338 * cs-parser.jay: Allow for both yield and yield return in the
21339 syntax. The anti-cobolization of C# fight will go on!
21341 * class.cs (TypeBuilder.DefineType): Catch error condition here
21342 (Parent.DefineType erroring out and returning null).
21344 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21345 coping with enumerations variables, we were mistakenly processing
21346 them as a regular value type instead of built-in types. Fixes the
21349 * typemanager.cs (IsBuiltinOrEnum): New method.
21351 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21353 * cs-parser.jay: Upgrade: yield now needs the return clause.
21355 2003-09-19 Martin Baulig <martin@ximian.com>
21357 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21358 `MemberCache parent' argument. Normally, an interface doesn't
21359 have a parent type except System.Object, but we use this in gmcs
21360 for generic type parameters.
21362 2003-09-18 Martin Baulig <martin@ximian.com>
21364 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21365 on `type.IsInterface'; don't check whether the type has a parent
21366 to determine whether it's an interface.
21368 2003-09-15 Martin Baulig <martin@ximian.com>
21370 * class.cs (TypeContainer.DefineType): Added an error flag to
21371 avoid reporting duplicate CS0146's ("class definition is
21374 * driver.cs (Driver.MainDriver): Abort if
21375 RootContext.ResolveTree() reported any errors.
21377 2003-09-07 Martin Baulig <martin@ximian.com>
21379 * report.cs (Error, Warning): Added overloaded versions which take
21380 a `params object[] args' and call String.Format().
21382 2003-09-07 Martin Baulig <martin@ximian.com>
21384 * decl.cs (DeclSpace..ctor): Don't call
21385 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21386 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21387 (DeclSpace.RecordDecl): New method.
21389 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21391 2003-09-02 Ravi Pratap <ravi@ximian.com>
21393 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21394 value attributes to be applied to ParameterBuilders.
21396 * class.cs (MethodCore.LabelParameters): Make static and more
21397 generic so that it can be used from other places - like interface
21398 methods, for instance.
21400 * interface.cs (Interface.Emit): Call LabelParameters before
21401 emitting attributes on the InterfaceMethod.
21403 2003-08-26 Martin Baulig <martin@ximian.com>
21405 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21406 resolving aliases; fixes #47927.
21408 2003-08-26 Martin Baulig <martin@ximian.com>
21410 * statement.cs (Using.DoResolve): This is internally emitting a
21411 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21412 do not always return. Fixes #47681.
21414 2003-08-26 Martin Baulig <martin@ximian.com>
21416 * decl.cs (MemberCore): Moved WarningNotHiding(),
21417 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21419 (AdditionResult): Make this nested in DeclSpace.
21420 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21421 argument; call NamespaceEntry.Define() unless we're nested in a
21424 * namespace.cs (Namespace.DefineName): New public function. This
21425 is called from DeclSpace's .ctor to add
21426 (Namespace.Lookup): Include DeclSpaces in the lookup.
21428 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21430 * const.cs (Const): Derive from MemberBase, not MemberCore.
21432 2003-08-25 Martin Baulig <martin@ximian.com>
21434 * convert.cs (Convert.ExplicitReferenceConversion): When
21435 converting from an interface type to a class, unbox if the target
21436 type is a struct type. Fixes #47822.
21438 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21440 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21443 2003-08-22 Martin Baulig <martin@ximian.com>
21445 * class.cs (TypeManager.DefineType): When defining a nested type,
21446 call DefineType() on our parent; fixes #47801.
21448 2003-08-22 Martin Baulig <martin@ximian.com>
21450 * class.cs (MethodData.Define): While checking if a method is an
21451 interface implementation, improve the test a bit more to fix #47654.
21453 2003-08-22 Martin Baulig <martin@ximian.com>
21455 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21456 correctly; fixes #47722.
21458 2003-08-22 Martin Baulig <martin@ximian.com>
21460 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21461 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21463 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21465 2003-08-22 Martin Baulig <martin@ximian.com>
21467 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21468 can only be assigned in static constructors. Fixes #47161.
21470 2003-08-22 Martin Baulig <martin@ximian.com>
21472 Rewrote and improved the flow analysis code.
21474 * flowbranching.cs (FlowBranching): Make this class abstract.
21475 (FlowBranching.CreateBranching): New static function to create a
21476 new flow branching.
21477 (FlowBranchingBlock, FlowBranchingException): New classes.
21478 (FlowBranching.UsageVector.Type): New public readonly field.
21479 (FlowBranching.UsageVector.Breaks): Removed the setter.
21480 (FlowBranching.UsageVector.Returns): Removed the setter.
21481 (FlowBranching.UsageVector): Added Break(), Return(),
21482 NeverReachable() and Throw() methods to modify the reachability.
21483 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21484 done by FlowBranching.Merge().
21485 (FlowBranching.UsageVector.MergeChild): New method; merges the
21486 merge result into the current vector.
21487 (FlowBranching.Merge): New abstract method to merge a branching.
21489 2003-08-12 Martin Baulig <martin@ximian.com>
21491 * expression.cs (Indirection.CacheTemporaries): Create the
21492 LocalTemporary with the pointer type, not its element type.
21494 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21496 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21497 token was a keyword or not.
21499 Add `error' options where an IDENTIFIER was expected; Provide
21500 CheckToken and CheckIdentifierToken convenience error reporting
21503 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21505 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21506 NameSpaceEntry NameSpaceEntry.
21508 (LookupInterfaceOrClass): Avoid creating a full qualified name
21509 from namespace and name: avoid doing lookups when we know the
21510 namespace is non-existant. Use new Tree.LookupByNamespace which
21511 looks up DeclSpaces based on their namespace, name pair.
21513 * driver.cs: Provide a new `parser verbose' to display the
21514 exception thrown during parsing. This is turned off by default
21515 now, so the output of a failure from mcs is more graceful.
21517 * namespace.cs: Track all the namespaces defined in a hashtable
21520 (IsNamespace): New method
21522 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21524 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21525 we know that we need to concatenate (full typename can never be
21530 * statement.cs: Use a bitfield; Do not initialize to null things
21531 which are done by the constructor by default.
21533 * cs-parser.jay: bug fix, parameter was 4, not 3.
21535 * expression.cs: Just use the property;
21537 * statement.cs: No need for GetVariableInfo method.
21539 2003-08-08 Martin Baulig <martin@ximian.com>
21541 * flowanalysis.cs (FlowReturns): This is now nested in the
21542 `FlowBranching' class.
21543 (MyBitVector): Moved this here from statement.cs.
21544 (FlowBranching.SiblingType): New enum type.
21545 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21547 2003-08-07 Martin Baulig <martin@ximian.com>
21549 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21550 `FlowBranching' class and called `BranchingType'.
21552 2003-08-07 Martin Baulig <martin@ximian.com>
21554 * flowanalysis.cs: Moved all the control flow analysis code into
21557 2003-08-07 Martin Baulig <martin@ximian.com>
21559 * assign.cs (Assign.DoResolve): `target' must either be an
21560 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21563 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21565 * expression.cs (BinaryMethod): This kind of expression is created by the
21566 Binary class if it determines that the operator has to be handled
21569 (BinaryDelegate): This kind of expression is created if we are
21570 dealing with a + or - operator on delegates.
21572 (Binary): remove method, argumetns, and DelegateOperator: when
21573 dealing with methods,
21575 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21577 * statement.cs (Block): use bitfields for the three extra booleans
21578 we had in use. Remove unused topblock parameter.
21580 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21582 * assign.cs: Drop extra unneeded tests.
21584 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21586 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21588 * statement.cs (Foreach): Use VariableStorage instead of
21591 * codegen.cs (VariableStorage): New class used by clients that
21592 require a variable stored: locals or fields for variables that
21593 need to live across yield.
21595 Maybe provide a convenience api for EmitThis+EmitLoad?
21597 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21600 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21602 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21603 RemapParameterLValue): New methods that are used to turn a
21604 precomputed FieldInfo into an expression like this:
21608 The idea is to use this instead of making LocalVariableReference
21609 have more than one meaning.
21611 * cs-parser.jay: Add error production to BASE.
21613 * ecore.cs: Deal with TypeManager.GetField returning null, which
21614 is now a valid return value.
21616 (FieldExprNoAddress): New expression for Fields whose address can
21619 * expression.cs (LocalVariableReference): During the resolve
21620 phases, create new expressions if we are in a remapping context.
21621 Remove code that dealt with remapping here.
21623 (ParameterReference): same.
21625 (ProxyInstance): New expression, like the `This' expression, but
21626 it is born fully resolved. We know what we are doing, so remove
21627 the errors that are targeted to user-provided uses of `this'.
21629 * statement.cs (Foreach): our variable is now stored as an
21630 Expression; During resolution, follow the protocol, dont just
21631 assume it will return this.
21633 2003-08-06 Martin Baulig <martin@ximian.com>
21635 * support.cs (SeekableStreamReader.cs): New public class.
21637 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21638 SeekableStreamReader instead of the normal StreamReader.
21640 2003-08-04 Martin Baulig <martin@ximian.com>
21642 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21643 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21644 deambiguate casts and delegate invocations.
21645 (parenthesized_expression): Use the new tokens to ensure this is
21646 not a cast of method invocation.
21648 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21649 when reading a `)' and Deambiguate_CloseParens () was previously
21652 * expression.cs (ParenthesizedExpression): New class. This is
21653 just used for the CS0075 test.
21654 (Binary.DoResolve): Check for CS0075.
21656 2003-07-29 Ravi Pratap <ravi@ximian.com>
21658 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21659 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21660 reference comparison.
21662 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21663 examine the ReturnType for equality - this is necessary in the
21664 cases of implicit and explicit operators whose signature also
21665 includes the return type.
21667 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21669 * namespace.cs: Cache the result of the namespace computation,
21670 instead of computing it every time.
21672 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21674 * decl.cs: Use a global arraylist that we reuse over invocations
21675 to avoid excesive memory consumption. Reduces memory usage on an
21676 mcs compile by one meg (45 average).
21678 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21679 private, work around that.
21681 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21683 * literal.cs (IntLiteral): Define Zero and One static literals.
21685 * cs-parser.jay (integer_literal): use static literals to reduce
21686 memory usage for the most used literals (0, 1 and -1). 211kb
21687 reduced in memory usage.
21689 Replace all calls to `new ArrayList' with `new
21690 ArrayList(4)' which is a good average number for most allocations,
21691 and also requires only 16 bytes of memory for its buffer by
21694 This reduced MCS memory usage in seven megabytes for the RSS after
21697 2003-07-28 Ravi Pratap <ravi@ximian.com>
21699 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21700 handle params methods the correct way by forming only one
21701 applicable set with params and normal methods in them. Earlier we
21702 were looking at params methods only if we found no normal methods
21703 which was not the correct thing to do.
21705 (Invocation.BetterFunction): Take separate arguments indicating
21706 when candidate and the best method are params methods in their
21709 This fixes bugs #43367 and #46199.
21711 * attribute.cs: Documentation updates.
21713 (CheckAttribute): Rename to CheckAttributeTarget.
21714 (GetValidPlaces): Rename to GetValidTargets.
21716 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21717 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21721 2003-07-28 Martin Baulig <martin@ximian.com>
21723 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21724 name when looking up the base class of a nested class. Fixes #46977.
21726 2003-07-26 Martin Baulig <martin@ximian.com>
21728 * expression.cs (Indexers.Indexer): New nested struct; contains
21729 getter, setter and the indexer's type.
21730 (Indexers.Properties): This is now an ArrayList of
21731 Indexers.Indexer's.
21732 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21733 indexer doesn't have any getters.
21735 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21736 for embedded property and indexer assignments.
21738 2003-07-26 Martin Baulig <martin@ximian.com>
21740 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21741 preprocessor directive is not the first non-whitespace character
21744 2003-07-26 Martin Baulig <martin@ximian.com>
21746 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21747 namespace parsing, follow the spec more closely.
21749 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21750 NamespaceEntry.Lookup().
21752 2003-07-25 Martin Baulig <martin@ximian.com>
21754 * MethodCore.cs (OverridesSomething): New public field; it's set
21755 from TypeContainer.DefineMembers if this method overrides
21756 something (which doesn't need to be a method). Fix #39462.
21758 2003-07-25 Ravi Pratap <ravi@ximian.com>
21760 * typemanager.cs (GetMembers): Ensure that the list of members is
21761 reversed. This keeps things in sync.
21763 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21764 find an AttributeUsage attribute.
21766 * expression.cs (Invocation.OverloadResolve): Perform the check
21767 which disallows Invoke to be directly called on a Delegate.
21769 (Error_InvokeOnDelegate): Report error cs1533.
21771 2003-07-25 Martin Baulig <martin@ximian.com>
21773 * expression.cs (Indexers.GetIndexersForType): Only look in the
21774 interface hierarchy if the requested type is already an
21775 interface. Fixes #46788 while keeping #46502 fixed.
21777 2003-07-25 Martin Baulig <martin@ximian.com>
21779 * class.cs (TypeContainer.DefineMembers): Check whether all
21780 readonly fields have been assigned and report warning CS0649 if
21783 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21786 2003-07-24 Ravi Pratap <ravi@ximian.com>
21788 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21789 returned from GetMethods to make things consistent with the
21790 assumptions MCS makes about ordering of methods.
21792 This should comprehensively fix bug #45127 and it does :-)
21794 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21795 ordering is actually reverse.
21797 * Clean up some debug messages I left lying around.
21799 * interface.cs (Populate*): Get rid of code which emits attributes
21800 since the stage in which we emit attributes is the 'Emit' stage,
21801 not the define stage.
21803 (Emit): Move attribute emission for interface members here.
21805 2003-07-22 Ravi Pratap <ravi@ximian.com>
21807 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21808 closely: we eliminate methods in base types when we have an
21809 applicable method in a top-level type.
21811 Please see section 14.5.5.1 for an exact description of what goes
21814 This fixes bug #45127 and a host of other related to corlib compilation.
21816 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21817 array is the method corresponding to the top-level type (this is
21818 because of the changes made to icall.c) so we change this
21821 (MethodGroupExpr.Name): This too.
21823 * typemanager.cs (GetElementType): New method which does the right
21824 thing when compiling corlib.
21826 * everywhere: Make use of the above in the relevant places.
21828 2003-07-22 Martin Baulig <martin@ximian.com>
21830 * cs-parser.jay (invocation_expression): Moved
21831 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21832 `cast_expression', but create a InvocationOrCast which later
21833 resolves to either an Invocation or a Cast.
21835 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21836 method; call this before EmitStatement() to make sure that this
21837 expression can be used as a statement.
21839 * expression.cs (InvocationOrCast): New class; resolves to either
21840 an Invocation or a Cast.
21842 * statement.cs (StatementExpression): Call ResolveStatement() on
21843 the ExpressionStatement before emitting it.
21845 2003-07-21 Martin Baulig <martin@ximian.com>
21847 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21848 `ref' and `out' attributes match; fixes #46220.
21849 (MemberAccess.ResolveMemberAccess): You can't reference a type
21850 through an expression; fixes #33180.
21851 (Indexers.GetIndexersForType): Don't return the indexers from
21852 interfaces the class implements; fixes #46502.
21854 2003-07-21 Martin Baulig <martin@ximian.com>
21856 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21857 CS0661 checks; fixes bug #30442.
21859 2003-07-21 Martin Baulig <martin@ximian.com>
21861 * decl.cs (AdditionResult): Added `Error'.
21863 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21865 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21866 makes cs0031.cs actually work.
21868 2003-07-20 Martin Baulig <martin@ximian.com>
21870 * namespace.cs: Fixed that bug which caused a crash when compiling
21871 the debugger's GUI.
21873 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21875 * typemanager.cs (LookupTypeReflection): Never expose types which
21876 are NotPublic, NestedPrivate, NestedAssembly, or
21877 NestedFamANDAssem. We used to return these, and later do a check
21878 that would report a meaningful error, but the problem is that we
21879 would not get the real match, if there was a name override.
21881 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21883 * namespace.cs (Namespace, Name): Do not compute the namespace
21884 name dynamically, compute it in the constructor. This reduced
21885 memory usage by 1697 KB.
21887 * driver.cs: Use --pause to pause at the end.
21889 2003-07-17 Peter Williams <peter@newton.cx>
21891 * Makefile: Change the name of the test target so that it doesn't
21892 conflict with the recursive test target.
21894 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21896 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21897 AddressOf): Do not use EmitThis, that was wrong, use the actual
21900 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21902 * class.cs (MethodData.Define): While checking if a method is an
21903 interface implementation, improve the test: If we are not public
21904 (use new test here: use the computed MethodAttributes directly,
21905 instead of the parsed modifier flags) check if the `implementing'
21906 method comes from an interface or not.
21908 * pending.cs (VerifyPendingMethods): Slightly better error
21911 * makefile: add test target that does the mcs bootstrap.
21913 2003-07-16 Ravi Pratap <ravi@ximian.com>
21915 * interface.cs (Define): Do nothing here since there are no
21916 members to populate etc. Move the attribute emission out of here
21917 since this was just totally the wrong place to put it. Attribute
21918 application happens during the 'Emit' phase, not in the 'Define'
21921 (Emit): Add this method and move the attribute emission here
21923 * rootcontext.cs (EmitCode): Call the Emit method on interface
21926 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21928 * expression.cs (OverloadResolve): Report error only if Location
21929 is not 'Null' which means that there was a probe going on.
21931 2003-07-14 Martin Baulig <martin@ximian.com>
21933 * expression.cs (ConditionalLogicalOperator): New public class to
21934 implement user defined conditional logical operators.
21935 This is section 14.11.2 in the spec and bug #40505.
21937 2003-07-14 Martin Baulig <martin@ximian.com>
21939 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21941 2003-07-14 Martin Baulig <martin@ximian.com>
21943 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21945 * ecore.cs (IVariable.VerifyFixed): New interface method.
21947 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21948 operator, check whether the variable is actually fixed. Fixes bug
21949 #36055. Set a variable definitely assigned when taking its
21950 address as required by the spec.
21952 * statement.cs (LocalInfo.IsFixed): New field.
21953 (LocalInfo.MakePinned): Set `IsFixed' to true.
21955 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21957 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21958 for .ctors, ensure that we only ask for members declared in the
21959 attribute type (BindingFlags.DeclaredOnly).
21963 * expression.cs (Error_WrongNumArguments): Report error 1501
21964 correctly the way CSC does.
21966 2003-07-13 Martin Baulig <martin@ximian.com>
21968 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21969 lookup on the fully qualified name, to make things like "X.X" work
21970 where "X.X" is a fully qualified type name, but we also have a
21971 namespace "X" in the using list. Fixes #41975.
21973 2003-07-13 Martin Baulig <martin@ximian.com>
21975 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21976 function. If we're a CompoundAssign, we need to create an embedded
21977 CompoundAssign, not an embedded Assign.
21978 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21981 2003-07-13 Martin Baulig <martin@ximian.com>
21983 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21984 work to fix bug #46088.
21986 2003-07-13 Ravi Pratap <ravi@ximian.com>
21988 * class.cs (Operator.Emit): Do not emit attributes here - it is
21989 taken care of by the Method class that we delegate too. This takes
21990 care of bug #45876.
21992 2003-07-10 Martin Baulig <martin@ximian.com>
21994 * expression.cs (TypeOfVoid): New class.
21995 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21997 2003-07-10 Martin Baulig <martin@ximian.com>
21999 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
22002 2003-07-10 Martin Baulig <martin@ximian.com>
22004 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
22005 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
22007 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
22009 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
22011 2003-07-10 Martin Baulig <martin@ximian.com>
22013 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
22014 of decimal. Fixes #42850.
22016 NOTE: I also fixed the created byte blob, but this doesn't work on
22017 the MS runtime and csc never produces any byte blobs for decimal
22020 2003-07-10 Martin Baulig <martin@ximian.com>
22022 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
22023 structs; fixes #32068.
22024 (Block.AddChildVariableNames): Fixed #44302.
22026 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22028 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
22030 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22032 * attribute.cs: And this test is onger needed.
22034 2003-07-08 Martin Baulig <martin@ximian.com>
22036 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
22037 inaccessible types. Fixes #36313.
22039 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
22041 * namespace.cs (NamespaceEntry): Create implicit entries for all
22042 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
22043 implicit entries for N1.N2 and N1.
22045 2003-07-08 Martin Baulig <martin@ximian.com>
22047 Rewrote the handling of namespaces to fix a lot of the issues
22048 wrt. `using' aliases etc.
22050 * namespace.cs (Namespace): Splitted this class into a
22051 per-assembly `Namespace' and a per-file `NamespaceEntry'.
22053 * typemanager.cs (TypeManager.IsNamespace): Removed.
22054 (TypeManager.ComputeNamespaces): Only compute namespaces from
22055 loaded assemblies here, not the namespaces from the assembly we're
22056 currently compiling.
22058 2003-07-08 Martin Baulig <martin@ximian.com>
22060 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
22062 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22064 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
22067 I thought about the memory savings here, but LookupTypeReflection
22068 is used under already very constrained scenarios. Compiling
22069 corlib or mcs only exposes one hit, so it would not really reduce
22070 any memory consumption.
22072 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22074 * typemanager.cs: fixes bug #45889 by only adding public types from
22075 other assemblies to the list of known types.
22077 2003-07-07 Miguel de Icaza <miguel@ximian.com>
22079 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
22080 on the type we resolved.
22082 2003-07-05 Martin Baulig <martin@ximian.com>
22084 * pending.cs (PendingImplementation.ParentImplements): Don't
22085 create the proxy if the parent is abstract.
22087 * class.cs (TypeContainer.DefineIndexers): Process explicit
22088 interface implementations first. Fixes #37714.
22090 2003-07-04 Miguel de Icaza <miguel@ximian.com>
22092 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
22093 defined recursively; but since we modify the input parameters
22094 (left is set to `this' temporarily), we reset this value if the
22095 left_is_explicit is false, which gives the original semantics to
22098 * literal.cs (NullPointer): new class used to represent a null
22099 literal in a pointer context.
22101 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
22102 type is a pointer, use a NullPointer object instead of a
22103 NullLiteral. Closes 43687
22105 (ExplicitConversion): Convert pointer values using
22106 the conv opcode to the proper type.
22108 * ecore.cs (New): change ValueTypeVariable property into a method,
22109 that returns whether the valuetype is suitable for being used.
22111 * expression.cs (Binary.DoNumericPromotions): Only return if we
22112 the int constant was a valid uint, and we can return both left and
22113 right as uints. If not, we continue processing, to trigger the
22114 type conversion. This fixes 39018.
22116 * statement.cs (Block.EmitMeta): During constant resolution, set
22117 the CurrentBlock property on the emitcontext, so that we resolve
22118 constants propertly.
22120 2003-07-02 Martin Baulig <martin@ximian.com>
22122 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
22123 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
22125 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
22126 than emitting it here.
22128 * statement.cs: Fixed some more flow analysis bugs.
22130 2003-07-02 Martin Baulig <martin@ximian.com>
22132 * class.cs (MethodData.Define): When implementing interface
22133 methods, set Final unless we're Virtual.
22135 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
22136 check work for interface methods.
22138 2003-07-01 Martin Baulig <martin@ximian.com>
22140 * ecore.cs (EmitContext.This): Replaced this property with a
22141 GetThis() method which takes a Location argument. This ensures
22142 that we get the correct error location for a CS0188.
22144 2003-07-01 Miguel de Icaza <miguel@ximian.com>
22146 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
22147 ImplicitStandardConversion.
22149 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
22151 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
22153 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
22156 2003-06-30 Miguel de Icaza <miguel@ximian.com>
22158 * class.cs (Constructor.Define): Turn off initlocals for unsafe
22161 (MethodData.Define): Turn off initlocals for unsafe methods.
22163 2003-06-29 Miguel de Icaza <miguel@ximian.com>
22165 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
22166 complete; Fixes #37521.
22168 * delegate.cs: Use Modifiers.TypeAttr to compute the
22169 TypeAttributes, instead of rolling our own. This makes the flags
22170 correct for the delegates.
22172 2003-06-28 Miguel de Icaza <miguel@ximian.com>
22174 * class.cs (Constructor.Define): Set the private flag for static
22175 constructors as well.
22177 * cs-parser.jay (statement_expression): Set the return value to
22178 null, to avoid a crash when we catch an error.
22180 2003-06-24 Miguel de Icaza <miguel@ximian.com>
22182 * cs-parser.jay: Applied patch from Jackson that adds support for
22183 extern and unsafe modifiers to destructor declarations.
22185 * expression.cs: Report error 21 if the user is trying to index a
22188 * driver.cs: Add an error message, suggested by the bug report.
22190 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
22191 if we do not have a ": this ()" constructor initializer. Fixes 45149
22193 2003-06-14 Miguel de Icaza <miguel@ximian.com>
22195 * namespace.cs: Add some information to reduce FAQs.
22197 2003-06-13 Miguel de Icaza <miguel@ximian.com>
22199 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
22200 underlying enumeration types. Fixes #43915.
22202 * expression.cs: Treat ushort/short as legal values to be used in
22203 bitwise operations.
22205 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
22207 * delegate.cs: transfer custom attributes for paramenters from
22208 the delegate declaration to Invoke and BeginInvoke.
22210 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22212 * attribute.cs: handle custom marshalers and emit marshal info
22215 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22217 * makefile.gnu: Added anonymous.cs to the compiler sources.
22219 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22221 * iterators.cs: Change the name of the proxy class to include two
22224 * cs-parser.jay: Update grammar to include anonymous methods.
22226 * anonymous.cs: new file.
22228 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22230 * class.cs (Field.Define): Add missing test for pointers and
22233 2003-05-27 Ravi Pratap <ravi@ximian.com>
22235 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22236 we use the stobj opcode.
22238 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22239 since it wasn't the correct fix.
22241 It still is puzzling that we are required to use stobj for IntPtr
22242 which seems to be a ValueType.
22244 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22246 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22247 during regular simple name resolution. Now, the trick is that
22248 instead of returning for processing the simplename, we do a
22249 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22250 contextual lookup type). If a match is found, return that, if
22251 not, return for further composition.
22253 This fixes long-standing 30485.
22255 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22256 using the address to initialize an object, do an Stobj instead of
22257 using the regular Stelem.
22259 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22260 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22261 Because if we are a BaseIndexerAccess that value will be true.
22264 * statement.cs (GotoCase.Resolve): Return after reporting an
22265 error, do not attempt to continue.
22267 * expression.cs (PointerArithmetic.Emit): If our operand is a
22268 long, convert our constants to match the operand before
22269 multiplying. Convert to I type before adding. Fixes 43670.
22271 2003-05-14 Ravi Pratap <ravi@ximian.com>
22273 * enum.cs (ImplicitConversionExists) : Rename to
22274 ImplicitEnumConversionExists to remove ambiguity.
22276 * ecore.cs (NullCast): New type of cast expression class which
22277 basically is very similar to EmptyCast with the difference being
22278 it still is a constant since it is used only to cast a null to
22280 (eg. (string) null)
22282 * convert.cs (ImplicitReferenceConversion): When casting a null
22283 literal, we return a NullCast.
22285 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22286 should be around anymore.
22288 The renaming (reported was slightly wrong). Corrections:
22290 ConvertImplicitStandard -> ImplicitConversionStandard
22291 ConvertExplicitStandard -> ExplicitConversionStandard
22293 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22294 before passing them in !
22296 * convert.cs (ImplicitConversionStandard): When comparing for
22297 equal expr and target types, ensure that expr is not a
22300 In general, we must not be checking (expr_type ==
22301 target_type) in the top level conversion methods
22302 (ImplicitConversion, ExplicitConversion etc). This checking is
22303 done in the methods that they delegate to.
22305 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22307 * convert.cs: Move Error_CannotConvertType,
22308 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22309 ImplicitNumericConversion, ImplicitConversionExists,
22310 ImplicitUserConversionExists, StandardConversionExists,
22311 FindMostEncompassedType, FindMostSpecificSource,
22312 FindMostSpecificTarget, ImplicitUserConversion,
22313 ExplicitUserConversion, GetConversionOperators,
22314 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22315 TryImplicitIntConversion, Error_CannotConvertImplicit,
22316 ConvertImplicitRequired, ConvertNumericExplicit,
22317 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22318 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22321 Perform the following renames:
22323 StandardConversionExists -> ImplicitStandardConversionExists
22324 ConvertImplicit -> ImplicitConversion
22325 ConvertImplicitStandard -> ImplicitStandardConversion
22326 TryImplicitIntConversion -> ImplicitIntConversion
22327 ConvertImplicitRequired -> ImplicitConversionRequired
22328 ConvertNumericExplicit -> ExplicitNumericConversion
22329 ConvertReferenceExplicit -> ExplicitReferenceConversion
22330 ConvertExplicit -> ExplicitConversion
22331 ConvertExplicitStandard -> ExplicitStandardConversion
22333 2003-05-19 Martin Baulig <martin@ximian.com>
22335 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22336 (TypeInfo): Added support for structs having structs as fields.
22338 * ecore.cs (FieldExpr): Implement IVariable.
22339 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22340 VariableInfo for the field.
22342 2003-05-18 Martin Baulig <martin@ximian.com>
22344 * expression.cs (This.DoResolve): Report a CS0027 if we're
22345 emitting a field initializer.
22347 2003-05-18 Martin Baulig <martin@ximian.com>
22349 * expression.cs (This.ResolveBase): New public function.
22350 (This.DoResolve): Check for CS0188.
22352 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22355 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22356 `instance_expression' to null if we don't have any non-static
22359 2003-05-18 Martin Baulig <martin@ximian.com>
22361 Reworked the way how local variables and parameters are handled by
22362 the flow analysis code.
22364 * statement.cs (TypeInfo, VariableMap): New public classes.
22365 (VariableInfo): New public class. This is now responsible for
22366 checking whether a variable has been assigned. It is used for
22367 parameters and local variables.
22368 (Block.EmitMeta): Take the InternalParameters as argument; compute
22369 the layout of the flow vectors here.
22370 (Block.LocalMap, Block.ParameterMap): New public properties.
22371 (FlowBranching): The .ctor doesn't get the InternalParameters
22372 anymore since Block.EmitMeta() now computes the layout of the flow
22374 (MyStructInfo): This class is now known as `StructInfo' and nested
22375 in `TypeInfo'; we don't access this directly anymore.
22377 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22378 property and removed IsAssigned(), IsFieldAssigned(),
22379 SetAssigned() and SetFieldAssigned(); we now call them on the
22380 VariableInfo so we don't need to duplicate this code everywhere.
22382 * expression.cs (ParameterReference): Added `Block block' argument
22384 (LocalVariableReference, ParameterReference, This): The new
22385 VariableInfo class is now responsible for all the definite
22388 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22389 IsParameterAssigned, SetParameterAssigned): Removed.
22391 2003-05-18 Martin Baulig <martin@ximian.com>
22393 * typemanager.cs (InitCoreTypes): Try calling
22394 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22395 the 3-args-version. Corlib now also needs our `void_type'.
22396 (GetMethod): Added overloaded version which takes an optional
22397 `bool report_errors' to allow lookups of optional methods.
22399 2003-05-12 Martin Baulig <martin@ximian.com>
22401 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22402 only used for locals and not for parameters.
22404 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22406 * support.cs (InternalParameters.ParameterType): Return the
22407 ExternalType of the parameter.
22409 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22412 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22414 * class.cs (MethodData.Define): Do not set the `newslot' on
22415 interface members, if they are also flagged as "override".
22417 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22418 better code for ++i and i++. This only works for static fields
22419 and local variables.
22421 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22422 want to pull the DeclSpace out of the builder_to_declspace instead
22423 of the TypeBuilder (like in TypeContainer.FindMembers).
22425 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22426 instead of LookupTypeContainer. Fixes the crash on .NET for
22427 looking up interface members.
22429 * const.cs: Create our own emit context during the Definition
22430 stage, so that constants are evaluated in the proper context, when
22431 a recursive definition happens.
22433 2003-05-11 Martin Baulig <martin@ximian.com>
22435 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22436 new block for a switch section.
22437 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22438 the adding/lookup in the switch block. Fixes #39828.
22440 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22442 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22443 functionality: I needed to convert the data after I had performed
22444 the add/sub operation into the operands type size.
22446 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22447 pass the type for the box operation, otherwise the resulting
22448 object would have been of type object.
22450 (BoxedCast): Add constructor to specify the type to box as.
22452 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22454 * iterators.cs: I was reusing the `count' variable inadvertently,
22455 take steps to not allow this to happen.
22457 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22459 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22460 by creating an array at the point where the params starts and
22461 putting all those arguments there, then adjusting the size of the
22464 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22466 * expression.cs (New.AddressOf): Implement interface
22467 IMemoryLocation. This is used when the `new' operator is used in
22468 the context of an invocation to a method on a value type.
22470 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22473 * namespace.cs: Also check the using aliases here.
22475 * driver.cs: Move the test for using validity after the types have
22476 been entered, so we do a single pass that also includes the using
22479 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22480 in the regular case. CreateSiblingForFinally is doing extra
22483 * attribute.cs (GetAttributeArgumentExpression): Store the result
22484 on an out value, and use the return value to indicate failure
22485 instead of using null (which is a valid return for Constant.GetValue).
22487 * statement.cs: Perform the analysis flow for the increment
22488 portion after the statement, because this will be the real flow of
22489 execution. Fixes #42385
22491 * codegen.cs (EmitContext.EmitArgument,
22492 EmitContext.EmitStoreArgument): New helper functions when the
22493 RemapToProxy flag is set.
22495 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22498 Add support for remapping parameters.
22500 * iterators.cs: Propagate parameter values; Store parameter
22501 values in the proxy classes.
22503 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22505 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22506 need a proxy reference; I do not know what I was thinking
22508 * cs-parser.jay (constructor_initializer): catch another error,
22509 and display nice message.
22511 (field_declaration): catch void field declaration
22512 to flag a better error.
22514 * class.cs (MemberBase.CheckBase): Report an error instead of a
22515 warning if a new protected member is declared in a struct.
22516 (Field.Define): catch the error of readonly/volatile.
22518 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22520 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22521 volatile variable is taken
22523 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22525 * statement.cs (Fixed.Resolve): Report an error if we are not in
22528 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22530 * typemanager.cs: reuse the code that handles type clashes for
22531 delegates and enumerations.
22533 * class.cs (Report28): Always report.
22535 * expression.cs (EncodeAsAttribute): Allow nulls here.
22537 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22539 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22540 the functionality for testing whether an expression is valid for
22541 an attribute here. Also handle the case of arrays of elements
22544 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22545 encoding a linear array into an array of objects that are suitable
22546 to be passed to an CustomAttributeBuilder.
22548 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22550 * ecore.cs: (FieldExpr): Handle field remapping here.
22552 * iteratators.cs: Pass the instance variable (if the method is an
22553 instance method) to the constructors, so we can access the field
22554 variables on the class.
22556 TODO: Test this with structs. I think the THIS variable on
22557 structs might have to be a pointer, and not a refenrece
22559 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22561 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22562 local variables to fields in a proxy class.
22564 * iterators.cs (PopulateProxy): Rename our internal fields to
22566 Create a <THIS> field if we are an instance method, so we can
22567 reference our parent container variables.
22568 (MapVariable): Called back from the EmitContext code to enter a
22569 new variable to field mapping into the proxy class (we just create
22573 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22574 for using the remapped locals to fields.
22576 I placed the code here, because that gives the same semantics to
22577 local variables, and only changes the Emit code.
22579 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22580 statements inside iterators.
22581 (VariableInfo): Add a FieldBuilder for the cases when we are
22582 remapping local variables to fields in a proxy class
22584 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22585 current_block != null.
22587 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22588 not cope with strings, as it has been moved to the
22589 TableSwitchEmit. Fixed bug in switch generation.
22591 * expression.cs (New.DoResolve): Provide more context for the user
22592 when reporting an error.
22594 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22597 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22598 check the permissions for it. Note than in a type-resolution
22599 context the check was already present in DeclSpace.ResolveType,
22600 but was missing from the MemberAccess.
22602 (ArrayCreation.CheckIndices): warn if the user has
22603 more nested levels of expressions, but there are no more
22604 dimensions specified. Avoids crash on bug 41906.
22606 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22608 * statement.cs (Block): replace Implicit bool, for a generic
22610 New flag: `Unchecked'. This is used during the EmitMeta phase
22611 (which is out-of-line with the regular Resolve/Emit process for a
22612 statement, as this is done ahead of time, but still gets a chance
22613 to call constant resolve).
22615 (Block.Flags): new enum for adding a new flag.
22617 (Block.EmitMeta): track the state of unchecked.
22619 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22620 to enable constant resolution to work there as well.
22622 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22624 * typemanager.cs (ienumerable_type): Also look up
22625 System.Collections.IEnumerable.
22627 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22629 TODO: Test more than one conditional per method.
22631 * class.cs (Indexer.Define): Report the location where the user is
22632 referencing the unsupported feature.
22634 (MethodData): Overload the use of `conditionals' to
22635 minimize the creation of needless ArrayLists. This saves roughly
22636 212kb on my machine.
22638 (Method): Implement the new IIteratorContainer interface.
22639 (Method.SetYields): Implement the method by setting the ModFlags
22640 to contain METHOD_YIELDS.
22642 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22643 which just got set to null.
22645 * iterators.cs: New file.
22647 (Yield, YieldBreak): New statements.
22649 * statement.cs (Return.Resolve): Flag an error if we are used in
22650 an iterator method.
22652 * codegen.cs (InIterator): New flag set if the code is being
22653 compiled in an iterator method.
22655 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22656 internal modifier, and we just use it to avoid adding extra
22657 fields, as this is seldom used.
22659 * cs-parser.jay: Add yield_statement (yield and yield break).
22661 * driver.cs: New flag -v2 to turn on version 2 features.
22663 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22664 hashtable when v2 is enabled.
22666 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22668 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22669 there is already a namespace defined with this name.
22671 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22672 people upgraded their corlibs.
22674 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22675 always use fully qualified types, no need to use the compiler
22678 (TypeManager.IsNamespace): Use binarysearch.
22680 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22681 AddDelegate): I did not quite use the new IsValid API properly: I
22682 have to pass the short-name and the fullname. I was passing only
22683 the basename instead of the fullname sometimes.
22685 (TypeContainer.DefineType): call NamespaceClash.
22687 * interface.cs (Interface.DefineType): use NamespaceClash before
22690 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22693 * enum.cs: (Enum.DefineType): use NamespaceClash before
22696 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22697 speed increase. First, use the negative_hits cache when we get a
22698 negative. Second, add the type with its full original name
22699 instead of the new . and + encoded name (reflection uses + to
22700 separate type from a nested type). Use LookupTypeReflection
22701 directly which bypasses the type->name hashtable (that we already
22702 know does not contain the type.
22704 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22705 location/container type.
22707 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22709 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22711 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22713 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22714 method is being referenced in the method group from a static
22715 context, and report error 120 if so.
22717 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22720 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22721 is created, we create the A namespace).
22723 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22726 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22728 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22729 invocation to ModuleBuilder.GetType with the same values will
22730 return a new type instance, so we need to cache its return
22733 * expression.cs (Binary.ResolveOperator): Only allow the compare
22734 operators on enums if they are of the same type.
22736 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22737 types of ValueType on their own case. Before we were giving them
22738 the same treatment as objects.
22740 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22741 fullname. Short name is used to compare against container name.
22742 Fullname is used to check against defined namespace names.
22744 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22745 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22747 (Method.CheckBase): Call parent.
22748 (MemberBase.CheckBase): Check for protected members on sealed
22750 (PropertyBase.CheckBase): Call parent.
22751 (Field.Define): Call parent.
22753 * report.cs: Negative error codes are now mapped to 8000 - code,
22754 so that the display is render more nicely.
22756 * typemanager.cs: Do not use try/catch, instead report a regular
22759 (GetPointerType, GetReferenceType): These methods provide
22760 mechanisms to obtain the T* and T& from a T. We had the code
22761 previously scattered around the code base, and it also used
22762 TypeManager.LookupType that would go through plenty of caches.
22763 This one goes directly to the type source.
22765 In some places we did the Type.GetType followed by
22766 ModuleBuilder.GetType, but not in others, so this unifies the
22767 processing as well.
22769 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22770 statements now that we have namespace information.
22772 * typemanager.cs (IsNamespace): New method, returns whether the
22773 string presented is a namespace or not.
22775 (ComputeNamespaces): New public entry point, computes the list of
22776 available namespaces, using the GetNamespaces API call in Mono, or
22777 the slower version in MS.NET.
22779 Now before we start the semantic analysis phase, we have a
22780 complete list of namespaces including everything that the user has
22783 Deleted old code to cache namespaces in .nsc files.
22785 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22787 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22788 class/struct location definition Location for the implicit
22789 constructor location.
22791 (Operator.Define): Use the location of the operator for the
22792 implicit Method definition.
22794 (Constructor.Emit): use the constructor location for the implicit
22795 base initializer constructor.
22797 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22798 and the Expression class now contains two new methods:
22800 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22801 isolate type lookup from the rest of the resolution process.
22803 Since we use Expressions to hold type definitions due to the way
22804 we parse the input we have historically overloaded Resolve to
22805 perform the Type lookups if a special flag is passed. Now this is
22806 eliminated and two methods take their place.
22808 The differences in the two methods between xStep and xTerminal is
22809 that xStep is involved in our current lookup system that uses
22810 SimpleNames to compose a name, while xTerminal is used just to
22811 catch the case where the simplename lookup failed.
22813 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22815 * expression.cs (ResolveMemberAccess): Remove redundant code.
22816 TypeExpr expressions are always born fully resolved.
22818 * interface.cs (PopulateMethod): Do not lookup the types twice.
22819 We were doing it once during SemanticAnalysis and once during
22822 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22823 in local variable type definitions, were being returned as a
22824 SimpleName (we decomposed everything into a string), that is
22825 because primary_expression was being used instead of a type in the
22826 grammar (reduce/reduce conflicts).
22828 The part that was wrong is that we converted the expression into a
22829 string (an oversimplification in one hand, compounded with primary
22830 expressions doing string concatenation).
22836 Would return "A.B.C[]" as a SimpleName. This stopped things like
22837 using clauses from working on this particular context. And a type
22838 was being matched directly against "A.B.C[]".
22840 We now use the correct approach, and allow for ComposedCast to be
22841 part of the unary expression. So the "A.B.C []" become a composed
22842 cast of "A.B.C" (as a nested group of MemberAccess with a
22843 SimpleName at the end) plus the rank composition "[]".
22847 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22849 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22850 for the access level checking.
22852 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22853 `TypeContainer container', because I kept getting confused when I
22854 was debugging this code.
22856 * expression.cs (Indexers): Instead of tracking getters/setters,
22857 we now track them in parallel. We create one arraylist less, but
22858 most importantly it is possible now for the LValue code to find a
22859 matching get for a set.
22861 (IndexerAccess.DoResolveLValue): Update the code.
22862 GetIndexersForType has been modified already to extract all the
22863 indexers from a type. The code assumed it did not.
22865 Also make the code set the correct return type for the indexer.
22866 This was fixed a long time ago for properties, but was missing for
22867 indexers. It used to be void_type.
22869 (Binary.Emit): Test first for doubles instead of
22870 floats, as they are more common.
22872 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22873 when dealing with floats and the <=, >= operators. This fixes bug
22876 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22877 to load the array value by emitting a load on the foreach variable
22878 type. This was incorrect.
22880 We now emit the code to load an element using the the array
22881 variable type, and then we emit the conversion operator.
22885 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22887 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22889 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22891 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22892 test for protection before we test for signatures.
22894 (MethodSignature.ToString): implement.
22896 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22897 to the case where we reduced into a LongConstant.
22899 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22900 depend on whether the information is acurrate, because the
22901 Microsoft runtime will always claim that the array type is public,
22902 regardless of the real state.
22904 If the type is a pointer, another problem happens: the type is
22905 reported as non-public in Microsoft.
22907 In both cases we have to call CheckAccessLevel recursively with
22908 the underlying type as the argument to be tested.
22910 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22912 * assign.cs (Assign.Emit): If we are dealing with a compound
22913 assignment expression, we should use the code path that stores the
22914 intermediate result in a temporary value. This fixes #40903.
22916 *expression.cs (Indirection.ToString): Provide ToString method for
22919 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22921 * class.cs: Null out fields holding references to Block objects so
22922 they can be garbage collected.
22924 * expression.cs (OverloadResolve): Remove unused local.
22926 2003-04-07 Martin Baulig <martin@ximian.com>
22928 * codegen.cs (EmitContext.CurrentFile): New public field.
22929 (EmitContext.Mark): Use the CurrentFile to check whether the
22930 location is in the correct file.
22931 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22933 2003-04-07 Martin Baulig <martin@ximian.com>
22935 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22937 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22938 location. [FIXME: The location argument which gets passed to this
22939 method is sometimes wrong!]
22941 2003-04-07 Nick Drochak <ndrochak@gol.com>
22943 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22945 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22947 * expression.cs (Indirection.EmitAssign): We were using the
22948 temporary, but returning immediately instead of continuing the
22951 2003-04-06 Martin Baulig <martin@ximian.com>
22953 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22954 if it's a nested child, but also deriving from the outer class.
22957 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22958 nested child, but also deriving from the outer class. See
22960 (FilterWithClosure): We may access private members of the outer
22961 class if we're a nested child and deriving from the outer class.
22962 (RealMemberLookup): Only set `closure_private_ok' if the
22963 `original_bf' contained BindingFlags.NonPublic.
22965 2003-04-05 Martin Baulig <martin@ximian.com>
22967 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22969 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22971 * class.cs (Event.Define): Do not allow abstract events to have
22974 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22976 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22977 block in event declarations.
22979 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22980 value type, get its address.
22982 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22983 leaving a class on the stack instead of a boolean value (int
22984 0/1). Change the code so we compare against null, and then the
22985 result against zero.
22987 * class.cs (TypeContainer.GetClassBases): We were checking for the
22988 parent class being sealed too late.
22990 * expression.cs (Binary.Emit): For <= and >= when dealing with
22991 floating point values, use cgt.un and clt.un instead of cgt and
22994 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22996 * statement.cs: Apply the same optimization as MS: skip the
22997 GetEnumerator returning an IEnumerator, and use the one returning a
22998 CharEnumerator instead. This allows us to avoid the try-finally block
23001 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
23003 * cs-parser.jay: Attributes cannot be applied to
23004 namespaces. Fixes #40473
23006 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23009 (Add*): check if the name is valid using the full name for constants,
23010 fields, properties and events.
23012 2003-03-28 Miguel de Icaza <miguel@ximian.com>
23014 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
23015 char constants to be part of the enumeration.
23017 * expression.cs (Conditional.DoResolve): Add support for operator
23018 true. Implements the missing functionality from 14.12
23020 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
23021 operator true/false as required by the spec.
23023 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
23024 implicit conversion to boolean.
23026 * statement.cs (Statement.ResolveBoolean): A boolean expression is
23027 also one where the type implements `operator true'.
23029 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
23030 get an expression that will invoke operator true based on an
23033 (GetConversionOperators): Removed the hack that called op_True
23036 (Expression.ResolveBoolean): Move this from Statement.
23038 2003-03-17 Miguel de Icaza <miguel@ximian.com>
23040 * ecore.cs (FieldExpr): do not allow initialization of initonly
23041 fields on derived classes
23043 2003-03-13 Martin Baulig <martin@ximian.com>
23045 * statement.cs (Block.Emit): Call ig.BeginScope() and
23046 ig.EndScope() when compiling with debugging info; call
23047 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
23049 2003-03-08 Miguel de Icaza <miguel@ximian.com>
23051 * expression.cs (Indexers): Do not construct immediately, allow
23052 for new members to be appended as we go. Fixes 38143
23054 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23056 * expression.cs: save/restore context when resolving an unchecked
23059 2003-03-05 Miguel de Icaza <miguel@ximian.com>
23061 * cfold.cs: Catch division by zero in modulus operator during
23064 2003-03-03 Miguel de Icaza <miguel@ximian.com>
23066 * interface.cs (Interface.DefineMembers): Avoid defining members
23069 2003-02-27 Miguel de Icaza <miguel@ximian.com>
23071 * driver.cs: handle the +/- options for -noconfig
23073 * statement.cs (Unckeched.Resolve): Also track the state of
23074 unchecked in the Resolve phase.
23076 2003-02-27 Martin Baulig <martin@ximian.com>
23078 * ecore.cs (Expression.MemberLookup): Don't create a
23079 MethodGroupExpr for something which is not a method. Fixes #38291.
23081 2003-02-25 Miguel de Icaza <miguel@ximian.com>
23083 * class.cs (MemberBase.CheckParameters): Also check that the type
23084 is unmanaged if it is a pointer.
23086 * expression.cs (SizeOf.Resolve): Add location information.
23088 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
23089 a managed type is declared.
23091 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
23092 parameter modifiers as well. Fixes bug 38606
23094 * class.cs: Very sad. Am backing out the speed up changes
23095 introduced by the ArrayList -> Array in the TypeContainer, as they
23096 were not actually that much faster, and introduced a bug (no error
23097 reports on duplicated methods).
23099 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
23100 source first, this will guarantee that we have a valid expression
23101 before calling in lower levels functions that will require a
23102 resolved object. Then use this original_source in the
23103 target.ResolveLValue instead of the original source that was
23106 Another change. Use target.Resolve instead of LValueResolve.
23107 Although we are resolving for LValues, we will let the Assign code
23108 take care of that (it will be called again from Resolve). This
23109 basically allows code like this:
23111 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
23112 class Y { void A (X x) { x [0] += o; }
23114 The problem was that the indexer was trying to resolve for
23115 set_Item (idx, object o) and never finding one. The real set_Item
23116 was set_Item (idx, X). By delaying the process we get the right
23121 2003-02-23 Martin Baulig <martin@ximian.com>
23123 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
23124 while calling DoEmit ().
23126 * codegen.cs (EmitContext.Mark): Don't mark locations in other
23127 source files; if you use the #line directive inside a method, the
23128 compiler stops emitting line numbers for the debugger until it
23129 reaches the end of the method or another #line directive which
23130 restores the original file.
23132 2003-02-23 Martin Baulig <martin@ximian.com>
23134 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
23136 2003-02-23 Martin Baulig <martin@ximian.com>
23138 * statement.cs (Block.AddChildVariableNames): We need to call this
23139 recursively, not just for our immediate children.
23141 2003-02-23 Martin Baulig <martin@ximian.com>
23143 * class.cs (Event.Define): Always make the field private, like csc does.
23145 * typemanager.cs (TypeManager.RealMemberLookup): Make events
23146 actually work, fixes bug #37521.
23148 2003-02-23 Miguel de Icaza <miguel@ximian.com>
23150 * delegate.cs: When creating the various temporary "Parameters"
23151 classes, make sure that we call the ComputeAndDefineParameterTypes
23152 on those new parameters (just like we do with the formal ones), to
23153 allow them to be resolved in the context of the DeclSpace.
23155 This fixes the bug that Dick observed in Bugzilla #38530.
23157 2003-02-22 Miguel de Icaza <miguel@ximian.com>
23159 * expression.cs (ResolveMemberAccess): When resolving a constant,
23160 do not attempt to pull a constant if the value was not able to
23161 generate a valid constant.
23163 * const.cs (LookupConstantValue): Do not report more errors than required.
23165 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23167 * expression.cs: fixes bug #38328.
23169 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23171 * class.cs: Changed all the various members that can be part of a
23172 class from being an ArrayList to be an Array of the right type.
23173 During the DefineType type_list, interface_list, delegate_list and
23174 enum_list are turned into types, interfaces, delegates and enums
23177 And during the member population, indexer_list, event_list,
23178 constant_list, field_list, instance_constructor_list, method_list,
23179 operator_list and property_list are turned into their real arrays.
23181 Although we could probably perform this operation earlier, for
23182 good error reporting we need to keep the lists and remove the
23183 lists for longer than required.
23185 This optimization was triggered by Paolo profiling the compiler
23186 speed on the output of `gen-sample-program.pl' perl script.
23188 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
23189 not crash in methods like MemberLookupFailed that use this field.
23191 This problem arises when the compiler fails to resolve a type
23192 during interface type definition for example.
23194 2003-02-18 Miguel de Icaza <miguel@ximian.com>
23196 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
23197 inherit from System.Object, so we have to stop at null, not only
23198 when reaching System.Object.
23200 2003-02-17 Miguel de Icaza <miguel@ximian.com>
23202 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
23203 DeclaredOnly because the parent indexer might have had a different
23204 name, but did not loop until the top of the hierarchy was reached.
23206 The problem this one fixes is 35492: when a class implemented an
23207 indexer from an interface, we were getting the interface method
23208 (which was abstract) and we were flagging an error (can not invoke
23211 This also keeps bug 33089 functioning, and test-148 functioning.
23213 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23214 out if a method is special is to see if it is declared in a
23215 property or event, or whether it is one of the predefined operator
23216 names. This should fix correctly #36804.
23218 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23220 The goal here is to remove the dependency on EmptyCast.Peel ().
23221 Killing it completely.
23223 The problem is that currently in a number of places where
23224 constants are expected, we have to "probe" for an EmptyCast, and
23225 Peel, which is not the correct thing to do, as this will be
23226 repetitive and will likely lead to errors.
23228 The idea is to remove any EmptyCasts that are used in casts that
23229 can be reduced to constants, so we only have to cope with
23232 This bug hunt was triggered by Bug 37363 and the desire to remove
23233 the duplicate pattern where we were "peeling" emptycasts to check
23234 whether they were constants. Now constants will always be
23237 * ecore.cs: Use an enumconstant here instead of wrapping with
23240 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23241 throwing me off. By handling this we can get rid of a few hacks.
23243 * statement.cs (Switch): Removed Peel() code.
23245 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23247 * class.cs: Location information for error 508
23249 * expression.cs (New.DoResolve): Add a guard against double
23250 resolution of an expression.
23252 The New DoResolve might be called twice when initializing field
23253 expressions (see EmitFieldInitializers, the call to
23254 GetInitializerExpression will perform a resolve on the expression,
23255 and later the assign will trigger another resolution
23257 This leads to bugs (#37014)
23259 * delegate.cs: The signature for EndInvoke should contain any ref
23260 or out parameters as well. We were not doing this in the past.
23262 * class.cs (Field.Define): Do not overwrite the type definition
23263 inside the `volatile' group. Turns out that volatile enumerations
23264 were changing the type here to perform a validity test, which
23267 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23269 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23270 and structs, we do not want to load the instance variable
23272 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23273 enum_type has to be handled like an object reference (implicit
23274 conversions exists from this to object), but the regular IsClass
23275 and IsValueType tests will never return true for this one.
23277 Also we use TypeManager.IsValueType instead of type.IsValueType,
23278 just for consistency with the rest of the code (this is only
23279 needed if we ever use the construct exposed by test-180.cs inside
23280 corlib, which we dont today).
23282 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23284 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23287 2003-02-09 Martin Baulig <martin@ximian.com>
23289 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23290 (Namespace.DefineNamespaces): New static public method; this is
23291 called when we're compiling with debugging to add all namespaces
23292 to the symbol file.
23294 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23295 pass it to the Namespace's .ctor.
23297 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23298 and MethodBase arguments; pass the namespace ID to the symwriter;
23299 pass the MethodBase instead of the token to the symwriter.
23300 (SymbolWriter.DefineNamespace): New method to add a namespace to
23303 2003-02-09 Martin Baulig <martin@ximian.com>
23305 * symbolwriter.cs: New file. This is a wrapper around
23306 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23307 methods here in near future.
23309 2003-02-09 Martin Baulig <martin@ximian.com>
23311 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23312 ILGenerator.MarkSequencePoint() which are actually used by the
23315 2003-02-09 Martin Baulig <martin@ximian.com>
23317 * location.cs (SourceFile): New public sealed class. This
23318 contains the name and an index which is used in the location's token.
23319 (Location): Reserve an appropriate number of bits in the token for
23320 the source file instead of walking over that list, this gives us a
23321 really huge performance improvement when compiling with debugging.
23323 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23324 `SourceFile' argument instead of a string.
23325 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23326 but don't parse/tokenize here, we need to generate the list of all
23327 source files before we do that.
23328 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23331 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23332 instead of a string.
23334 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23337 2003-02-09 Martin Baulig <martin@ximian.com>
23339 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23340 filename on `#line default'.
23342 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23344 * statement.cs: don't clear the pinned var when the fixed statement
23345 returns from the method (fixes bug#37752).
23347 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23349 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23352 2003-02-07 Martin Baulig <martin@ximian.com>
23354 * driver.cs: Removed the `--debug-args' command line argument.
23356 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23357 automatically by the AsssemblyBuilder.
23358 (CodeGen.InitializeSymbolWriter): We don't need to call any
23359 initialization function on the symbol writer anymore. This method
23360 doesn't take any arguments.
23362 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23364 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23365 from referenced assemblies as well.
23367 2003-02-02 Martin Baulig <martin@ximian.com>
23369 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23371 2003-02-02 Martin Baulig <martin@ximian.com>
23373 * class.cs (Constructor.Emit): Open the symbol writer before
23374 emitting the constructor initializer.
23375 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23376 single-stepping through constructor initializers.
23378 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23380 * class.cs: Handle error 549: do not allow virtual methods in
23383 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23385 * decl.cs: Check access levels when resolving types
23387 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23389 * statement.cs: Add parameters and locals set in catch blocks that might
23390 return to set vector
23392 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23394 * class.cs (Operator): Set the SpecialName flags for operators.
23396 * expression.cs (Invocation.DoResolve): Only block calls to
23397 accessors and operators on SpecialName methods.
23399 (Cast.TryReduce): Handle conversions from char constants.
23402 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23404 * statement.cs: small memory and time optimization in FlowBranching.
23406 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23408 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23409 problem that the last fix but in the other sid (Set).
23411 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23412 access when there is no indexer in the hierarchy.
23414 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23416 * class.cs: Combine some if statements.
23418 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23420 * driver.cs: fixed bug #37187.
23422 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23424 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23425 any indexer, it's needed to build a list with all the indexers in the
23426 hierarchy (AllGetters), else we have problems. Fixes #35653.
23428 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23430 * class.cs (MethodData.Define): It is wrong for an interface
23431 implementation to be static in both cases: explicit and implicit.
23432 We were only handling this in one case.
23434 Improve the if situation there to not have negations.
23436 * class.cs (Field.Define): Turns out that we do not need to check
23437 the unsafe bit on field definition, only on usage. Remove the test.
23439 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23441 * driver.cs: use assembly.Location instead of Codebase (the latest
23442 patch made mcs fail when using MS assemblies).
23444 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23446 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23447 get the path to *corlib.dll.
23449 2003-01-21 Nick Drochak <ndrochak@gol.com>
23453 * typemanager.cs: Remove compiler warnings
23455 2003-01-20 Duncan Mak <duncan@ximian.com>
23457 * AssemblyInfo.cs: Bump the version number to 0.19.
23459 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23461 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23463 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23465 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23467 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23469 * cs-parser.jay: Small fix: we were not comparing the constructor
23470 name correctly. Thanks to Zoltan for the initial pointer.
23472 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23474 * cs-tokenizer.cs: Set file name when specified with #line
23476 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23478 * cs-parser.jay: Only perform the constructor checks here if we
23479 are named like the class; This will help provider a better
23480 error. The constructor path is taken when a type definition is
23481 not found, but most likely the user forgot to add the type, so
23482 report that rather than the constructor error.
23484 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23486 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23489 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23491 * cs-parser.jay: Add cleanup call.
23493 2003-01-13 Duncan Mak <duncan@ximian.com>
23495 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23496 consistent with other methods.
23498 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23500 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23502 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23504 * attribute.cs: only set GuidAttr to true when we have a
23507 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23511 * typemanager.cs: fixes to allow mcs compile corlib with the new
23512 Type.IsSubclassOf fix.
23514 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23516 * expression.cs (LocalVariableReference.DoResolve): Classify a
23517 constant as a value, not as a variable. Also, set the type for
23520 * cs-parser.jay (fixed_statement): take a type instead of a
23521 pointer_type, so we can produce a better error message later.
23523 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23526 (For.DoEmit): Make inifinite loops have a
23527 non-conditional branch back.
23529 (Fixed.DoEmit): First populate the pinned variables, then emit the
23530 statement, then clear the variables. Before I was emitting the
23531 code once for each fixed piece.
23534 2003-01-08 Martin Baulig <martin@ximian.com>
23536 * statement.cs (FlowBranching.MergeChild): A break in a
23537 SWITCH_SECTION does not leave a loop. Fixes #36155.
23539 2003-01-08 Martin Baulig <martin@ximian.com>
23541 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23542 lives in the same number space than `param_map'. Fixes #36154.
23544 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23546 * cs-parser.jay (constructor_declaration): Set the
23547 Constructor.ModFlags before probing for it. This makes the
23548 compiler report 514, 515 and 132 (the code was there, but got
23551 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23552 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23553 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23555 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23557 * enum.cs: create the enum static fields using the enum type.
23559 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23561 * class.cs: don't try to create the ParamBuilder for the return
23562 type if it's not needed (and handle it breaking for the ms runtime
23565 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23567 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23569 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23571 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23572 the command. This showed up while compiling the JANET source
23573 code, which used \r as its only newline separator.
23575 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23577 * class.cs (Method.Define): If we are an operator (because it
23578 reuses our code), then set the SpecialName and HideBySig. #36128
23580 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23582 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23583 exception, report error 120 `object reference required'.
23585 * driver.cs: Add --pause option, used during to measure the size
23586 of the process as it goes with --timestamp.
23588 * expression.cs (Invocation.DoResolve): Do not allow methods with
23589 SpecialName to be invoked.
23591 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23593 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23594 number before adding it.
23596 2002-12-21 Ravi Pratap <ravi@ximian.com>
23598 * ecore.cs (StandardImplicitConversion): When in an unsafe
23599 context, we allow conversion between void * to any other pointer
23600 type. This fixes bug #35973.
23602 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23604 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23605 is not thrown when extensionless outputs are used
23607 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23609 * rootcontext.cs: fixed compilation of corlib.
23611 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23613 * attribute.cs (Attributes.Contains): Add new method.
23615 * class.cs (MethodCore.LabelParameters): if the parameter is an
23616 `out' parameter, check that no attribute `[In]' has been passed.
23618 * enum.cs: Handle the `value__' name in an enumeration.
23620 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23622 * decl.cs: Added special case to allow overrides on "protected
23625 2002-12-18 Ravi Pratap <ravi@ximian.com>
23627 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23628 since it makes much more sense.
23630 (Attributes.ctor): Don't require a Location parameter.
23632 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23634 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23635 since we already have that information per attribute.
23637 * everywhere : make appropriate changes.
23639 * class.cs (LabelParameters): Write the code which actually
23640 applies attributes to the return type. We can't do this on the MS
23641 .NET runtime so we flag a warning in the case an exception is
23644 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23646 * const.cs: Handle implicit null conversions here too.
23648 2002-12-17 Ravi Pratap <ravi@ximian.com>
23650 * class.cs (MethodCore.LabelParameters): Remove the extra
23651 Type [] parameter since it is completely unnecessary. Instead
23652 pass in the method's attributes so that we can extract
23653 the "return" attribute.
23655 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23657 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23658 of ignoring it and letting the compile continue.
23660 * typemanager.cs (ChangeType): use an extra argument to return an
23661 error condition instead of throwing an exception.
23663 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23665 * expression.cs (Unary.TryReduce): mimic the code for the regular
23666 code path. Perform an implicit cast in the cases where we can
23667 implicitly convert to one of the integral types, and then reduce
23668 based on that constant. This fixes bug #35483.
23670 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23672 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23674 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23676 * namespace.cs: fixed bug #35489.
23678 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23680 * class.cs: Remove some dead code.
23682 * cs-parser.jay: Estimate the number of methods needed
23683 (RootContext.MethodCount);
23685 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23686 numbers instead of StringBuilders.
23688 * support.cs (PtrHashtable): Add constructor with initial size;
23689 We can now reduce reallocations of the method table.
23691 2002-12-10 Ravi Pratap <ravi@ximian.com>
23693 * attribute.cs (ApplyAttributes): Keep track of the emitted
23694 attributes on a per-target basis. This fixes bug #35413.
23696 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23698 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23699 default to the Windows 1252 encoding.
23701 (UnixParseOption): Support version, thanks to Alp for the missing
23704 * AssemblyInfo.cs: Add nice assembly information.
23706 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23709 * cs-parser.jay: Allow a trailing comma before the close bracked
23710 in the attribute_section production.
23712 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23713 address of the instance was being taken, I will take this out,
23714 because we take the address of the object immediately here.
23716 2002-12-09 Ravi Pratap <ravi@ximian.com>
23718 * typemanager.cs (AreMultipleAllowed): Take care of the most
23719 obvious case where attribute type is not in the current assembly -
23722 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23724 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23725 definitions, instead of doing that afterwards.
23727 Also we use a nice little hack, depending on the constructor, we
23728 know if we are a "composed" name or a simple name. Hence, we
23729 avoid the IndexOf test, and we avoid
23731 * codegen.cs: Add code to assist in a bug reporter to track down
23732 the source of a compiler crash.
23734 2002-12-07 Ravi Pratap <ravi@ximian.com>
23736 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23737 types have been emitted for a given element and flag an error
23738 if something which does not have AllowMultiple set is used more
23741 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23742 attribute types and their corresponding AllowMultiple properties
23744 (AreMultipleAllowed): Check the property for a given type.
23746 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23747 property in the case we have a TypeContainer.
23749 (Attributes.AddAttribute): Detect duplicates and just skip on
23750 adding them. This trivial fix catches a pretty gross error in our
23751 attribute emission - global attributes were being emitted twice!
23753 Bugzilla bug #33187 is now fixed.
23755 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23757 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23758 instead of pp_and).
23760 * expression.cs (Binary.ResolveOperator): I can only use the
23761 Concat (string, string, string) and Concat (string, string,
23762 string, string) if the child is actually a concatenation of
23765 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23767 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23768 context where we need a 2-character lookahead.
23770 * pending.cs (PendingImplementation): Rework so we can keep track
23771 of interface types all the time, and flag those which were
23772 implemented by parents as optional.
23774 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23776 * expression.cs (Binary.ResolveOperator): Use
23777 String.Concat(string,string,string) or
23778 String.Concat(string,string,string,string) when possible.
23780 * typemanager: More helper methods.
23783 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23785 * pending.cs: remove the bogus return from GetMissingInterfaces()
23786 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23788 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23790 * namespace.cs: avoid duplicated 'using xxx' being added to
23791 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23792 when we get more than one 'using' statement for the same namespace.
23793 Report a CS0105 warning for it.
23795 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23797 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23798 of calling getChar/putback, uses internal knowledge of it.
23800 (xtoken): Reorder tokenizer so most common patterns are checked
23801 first. This reduces the compilation time in another 5% (from 8.11s
23802 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23804 The parsing time is 22% of the compilation in mcs, and from that
23805 64% is spent on the tokenization process.
23807 I tried using a binary search for keywords, but this is slower
23808 than the hashtable. Another option would be to do a couple of
23811 * Not use a StringBuilder, instead use an array of chars,
23812 with a set value. Notice that this way we could catch
23813 the 645 error without having to do it *afterwards*.
23815 * We could write a hand-parser to avoid the hashtable
23816 compares altogether.
23818 The identifier consumption process takes 37% of the tokenization
23819 time. Another 15% is spent on is_number. 56% of the time spent
23820 on is_number is spent on Int64.Parse:
23822 * We could probably choose based on the string length to
23823 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23826 Another 3% is spend on wrapping `xtoken' in the `token' function.
23828 Handle 0xa0 as whitespace (#34752)
23830 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23832 * typemanager.cs (IsCLRType): New routine to tell whether a type
23833 is one of the builtin types.
23835 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23836 typecode in more places instead of doing pointer comparissions.
23837 We could leverage some knowledge about the way the typecodes are
23840 New code to cache namespaces in assemblies, it is currently not
23841 invoked, to be used soon.
23843 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23845 * expression.cs (Binary.ResolveOperator): specially handle
23846 strings, and do not perform user-defined operator overloading for
23849 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23851 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23852 internalcall as it is a pretty simple operation; Avoid whenever
23853 possible to call Char.IsLetter.
23855 (consume_identifier): Cut by half the number of
23856 hashtable calls by merging the is_keyword and GetKeyword behavior.
23858 Do not short-circuit, because if we do, we
23859 report errors (ie, #if false && true would produce an invalid
23863 2002-11-24 Martin Baulig <martin@ximian.com>
23865 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23866 check constant ranges and report a CS0221. Fixes #33186.
23868 2002-11-24 Martin Baulig <martin@ximian.com>
23870 * cs-parser.jay: Make this work for uninitialized variable
23871 declarations in the `for' initializer. Fixes #32416.
23873 2002-11-24 Martin Baulig <martin@ximian.com>
23875 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23876 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23878 2002-11-24 Martin Baulig <martin@ximian.com>
23880 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23881 argument; if true, we also check for user-defined conversions.
23882 This is only needed if both arguments are of a user-defined type.
23883 Fixes #30443, added test-175.cs.
23884 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23886 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23888 2002-11-24 Martin Baulig <martin@ximian.com>
23890 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23891 function to get the store opcode.
23892 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23893 only emit the Ldelema if the store opcode is Stobj. You must run
23894 both test-34 and test-167 to test this. Fixes #34529.
23896 2002-11-23 Martin Baulig <martin@ximian.com>
23898 * ecore.cs (Expression.MemberLookup): Added additional
23899 `qualifier_type' argument which is used when we're being called
23900 from MemberAccess.DoResolve() and null if we're called from a
23902 (Expression.MemberLookupFailed): New method to report errors; this
23903 does the CS1540 check and reports the correct error message.
23905 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23906 argument for the CS1540 check and redone the way how we're dealing
23907 with private members. See the comment in the source code for details.
23908 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23909 `closure_start_type' to `closure_qualifier_type' and check whether
23910 it's not null. It was not this filter being broken, it was just
23911 being called with the wrong arguments.
23913 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23914 and pass it the correct `qualifier_type'; this also does the error
23917 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23919 * expression.cs (Invocation.EmitParams): If the we are dealing
23920 with a non-built-in value type, load its address as well.
23922 (ArrayCreation): Use a a pretty constant instead
23923 of the hardcoded value 2. Use 6 instead of 2 for the number of
23924 static initializers.
23926 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23927 because they are not really value types, just glorified integers.
23929 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23931 * ecore.cs: Remove redundant code for enumerations, make them use
23932 the same code path as everything else, fixes the casting issue
23933 with enumerations in Windows.Forms.
23935 * attribute.cs: Do only cast to string if it is a string, the
23936 validation happens later.
23938 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23939 people upgrade their corlibs.
23941 * ecore.cs: Oops, enumerations were not following the entire code path
23943 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23945 * typemanager.cs (FilterWithClosure): Commented out the test for
23946 1540 in typemanager.cs, as it has problems when accessing
23947 protected methods from a parent class (see test-174.cs).
23949 * attribute.cs (Attribute.ValidateGuid): new method.
23950 (Attribute.Resolve): Use above.
23952 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23954 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23956 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23957 handling for enumerations, as we only needed the TypeContainer
23958 functionality to begin with (this is required for the fix below to
23959 work for enums that reference constants in a container class for
23962 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23964 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23965 a valid TypeBuilder to perform lookups on.o
23967 * class.cs (InheritableMemberSignatureCompare): Use true in the
23968 call to GetGetMethod and GetSetMethod, because we are comparing
23969 the signature, and we need to get the methods *even* if they are
23972 (PropertyBase.CheckBase): ditto.
23974 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23975 GotoCase.Resolve): Use Peel on EmpytCasts.
23977 * ecore.cs (EmptyCast): drop child, add Peel method.
23979 2002-11-17 Martin Baulig <martin@ximian.com>
23981 * ecore.cs (EmptyCast.Child): New public property.
23983 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23984 label resolved to an EmptyCast. Fixes #34162.
23985 (GotoCase.Resolve): Likewise.
23986 (Block.EmitMeta): Likewise.
23988 2002-11-17 Martin Baulig <martin@ximian.com>
23990 * expression.cs (Invocation.BetterConversion): Prefer int over
23991 uint; short over ushort; long over ulong for integer literals.
23992 Use ImplicitConversionExists instead of StandardConversionExists
23993 since we also need to check for user-defined implicit conversions.
23994 Fixes #34165. Added test-173.cs.
23996 2002-11-16 Martin Baulig <martin@ximian.com>
23998 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23999 with the `true' and `false' literals. Fixes #33151.
24001 2002-11-16 Martin Baulig <martin@ximian.com>
24003 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
24004 October 22nd; don't do the cs1540 check for static members.
24006 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
24007 now using our own filter here and doing the cs1540 check again.
24009 2002-11-16 Martin Baulig <martin@ximian.com>
24011 * support.cs (InternalParameters): Don't crash if we don't have
24012 any fixed parameters. Fixes #33532.
24014 2002-11-16 Martin Baulig <martin@ximian.com>
24016 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
24017 when looking up static methods to make this work on Windows.
24020 2002-11-16 Martin Baulig <martin@ximian.com>
24022 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
24023 a setter rather than using PropertyInfo.CanWrite.
24025 2002-11-15 Nick Drochak <ndrochak@gol.com>
24027 * class.cs: Allow acces to block member by subclasses. Fixes build
24030 2002-11-14 Martin Baulig <martin@ximian.com>
24032 * class.cs (Constructor.Emit): Added the extern/block check.
24035 2002-11-14 Martin Baulig <martin@ximian.com>
24037 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
24038 iteration while looking for indexers, this is needed because the
24039 indexer may have a different name in our base classes. Fixed the
24040 error reporting (no indexers at all, not get accessor, no
24041 overloaded match). Fixes bug #33089.
24042 (IndexerAccess.DoResolveLValue): Likewise.
24044 2002-11-14 Martin Baulig <martin@ximian.com>
24046 * class.cs (PropertyBase.CheckBase): Make this work for multiple
24047 indexers. Fixes the first part of bug #33089.
24048 (MethodSignature.InheritableMemberSignatureCompare): Added support
24051 2002-11-13 Ravi Pratap <ravi@ximian.com>
24053 * attribute.cs (Attribute.Resolve): Catch the
24054 NullReferenceException and report it since it isn't supposed to
24057 2002-11-12 Miguel de Icaza <miguel@ximian.com>
24059 * expression.cs (Binary.EmitBranchable): Also handle the cases for
24060 LogicalOr and LogicalAnd that can benefit from recursively
24061 handling EmitBranchable. The code now should be nice for Paolo.
24063 2002-11-08 Miguel de Icaza <miguel@ximian.com>
24065 * typemanager.cs (LookupType): Added a negative-hit hashtable for
24066 the Type lookups, as we perform quite a number of lookups on
24067 non-Types. This can be removed once we can deterministically tell
24068 whether we have a type or a namespace in advance.
24070 But this might require special hacks from our corlib.
24074 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
24075 and double which avoids a conversion from an integer to a double.
24077 * expression.cs: tiny optimization, avoid calling IsConstant,
24078 because it effectively performs the lookup twice.
24080 2002-11-06 Miguel de Icaza <miguel@ximian.com>
24082 But a bogus return here to keep the semantics of the old code
24083 until the Mono runtime is fixed.
24085 * pending.cs (GetMissingInterfaces): New method used to remove all
24086 the interfaces that are already implemented by our parent
24087 classes from the list of pending methods.
24089 * interface.cs: Add checks for calls after ResolveTypeExpr.
24091 2002-11-05 Miguel de Icaza <miguel@ximian.com>
24093 * class.cs (Class.Emit): Report warning 67: event not used if the
24094 warning level is beyond 3.
24096 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
24097 being a NullLiteral.
24099 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
24102 * class.cs (TypeContainer.GetClassBases): Cover a missing code
24103 path that might fail if a type can not be resolved.
24105 * expression.cs (Binary.Emit): Emit unsigned versions of the
24108 * driver.cs: use error 5.
24110 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
24112 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
24114 2002-11-01 Miguel de Icaza <miguel@ximian.com>
24116 * cs-parser.jay (switch_section): A beautiful patch from Martin
24117 Baulig that fixed 33094.
24119 2002-10-31 Miguel de Icaza <miguel@ximian.com>
24121 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
24122 Check whether the base is abstract and report an error if so.
24124 * expression.cs (IndexerAccess.DoResolveLValue,
24125 IndexerAccess.DoResolve): ditto.
24127 (Invocation.DoResolve): ditto.
24129 (Invocation.FullMethodDesc): Improve the report string.
24131 * statement.cs (Block): Eliminate IsVariableDefined as it is
24132 basically just a wrapper for GetVariableInfo.
24134 * ecore.cs (SimpleName): Use new
24136 * support.cs (ReflectionParamter.ParameterType): We unwrap the
24137 type, as we return the actual parameter ref/unref state on a
24140 2002-10-30 Miguel de Icaza <miguel@ximian.com>
24142 * support.cs: Return proper flags REF/OUT fixing the previous
24145 * expression.cs: Reverted last patch, that was wrong. Is_ref is
24146 not used to mean `ref' but `ref or out' in ParameterReference
24148 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
24149 full type signature instead of calling TypeManger.CSharpName
24152 * support.cs (InternalParameters.ParameterDesc): Do not compare
24153 directly to the modflags, because REF/OUT will actually be bitsets
24156 * delegate.cs (VerifyMethod): Check also the modifiers.
24158 * cs-tokenizer.cs: Fix bug where floating point values with an
24159 exponent where a sign was missing was ignored.
24161 * driver.cs: Allow multiple assemblies to be specified in a single
24164 2002-10-28 Miguel de Icaza <miguel@ximian.com>
24166 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
24167 because identifiers after a parenthesis would end up in this kind
24168 of production, and we needed to desamiguate it for having casts
24171 (UserDefinedType *) xxx
24173 2002-10-24 Miguel de Icaza <miguel@ximian.com>
24175 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
24176 we should set on the Bindingflags.NonPublic, but not turn on
24177 private_ok. private_ok controls whether a Private member is
24178 returned (this is chekced on the filter routine), while the
24179 BindingFlags.NonPublic just controls whether private/protected
24180 will be allowed. This fixes the problem part of the problem of
24181 private properties being allowed to be used in derived classes.
24183 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
24184 so we can call the children DoResolveLValue method (this will
24185 properly signal errors on lvalue assignments to base properties)
24187 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
24188 getter are null, and we have a property info, we know that this
24189 happened because the lookup failed, so we report an error 122 for
24190 protection level violation.
24192 We also silently return if setter and getter are null in the
24193 resolve functions, this condition only happens if we have flagged
24194 the error before. This is the other half of the problem.
24196 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
24197 not have accessibility information, that is why we were returning
24198 true in the filter function in typemanager.cs.
24200 To properly report 122 (property is inaccessible because of its
24201 protection level) correctly, we report this error in ResolveAccess
24202 by failing if both the setter and the getter are lacking (ie, the
24205 DoResolve and DoLResolve have been modified to check for both
24206 setter/getter being null and returning silently, the reason being
24207 that I did not want to put the knowledge about this error in upper
24210 int old = Report.Errors;
24211 x = new PropertyExpr (...);
24212 if (old != Report.Errors)
24217 So the property expr is returned, but it is invalid, so the error
24218 will be flagged during the resolve process.
24220 * class.cs: Remove InheritablePropertySignatureCompare from the
24221 class, as we no longer depend on the property signature to compute
24222 whether it is possible to implement a method or not.
24224 The reason is that calling PropertyInfo.GetGetMethod will return
24225 null (in .NET, in Mono it works, and we should change this), in
24226 cases where the Get Method does not exist in that particular
24231 class X { public virtual int A { get { return 1; } } }
24233 class Z : Y { public override int A { get { return 2; } } }
24235 Would fail in Z because the parent (Y) would not have the property
24236 defined. So we avoid this completely now (because the alternative
24237 fix was ugly and slow), and we now depend exclusively on the
24240 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24241 reference method, instead of using the property.
24243 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24244 routines are gone now.
24246 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24247 names, they were incorrectly named.
24249 * cs-tokenizer.cs: Return are more gentle token on failure.
24251 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24252 had an out-of-sync index variable, which caused it to remove from
24253 the list of pending methods the wrong method sometimes.
24255 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24257 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24258 CanWrite, because those refer to this particular instance of the
24259 property, and do not take into account the fact that we can
24260 override single members of a property.
24262 Constructor requires an EmitContext. The resolution process does
24263 not happen here, but we need to compute the accessors before,
24264 because the resolution does not always happen for properties.
24266 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24267 subclass, before we did not update this flag, but we did update
24270 (GetAccessors): Drop this routine, as it did not work in the
24271 presence of partially overwritten set/get methods.
24273 Notice that this broke the cs1540 detection, but that will require
24276 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24280 * driver.cs: issue a warning instead of an error if we don't support
24281 debugging for the platform. Also ignore a couple of errors that may
24282 arise when trying to write the symbols. Undo my previous patch.
24284 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24286 * driver.cs: ignore /debug switch except for Unix platforms.
24288 2002-10-23 Nick Drochak <ndrochak@gol.com>
24290 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24292 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24294 * driver.cs: Do not make mcs-debug conditional, so we do not break
24295 builds that use it.
24297 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24298 review this patch. But basically after all the children variables
24299 have been merged, the value of "Breaks" was not being set to
24300 new_breaks for Switch blocks. I think that it should be set after
24301 it has executed. Currently I set this to the value of new_breaks,
24302 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24303 conservative, but I do not understand this code very well.
24305 I did not break anything in the build, so that is good ;-)
24307 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24309 2002-10-20 Mark Crichton <crichton@gimp.org>
24311 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24313 2002-10-20 Nick Drochak <ndrochak@gol.com>
24315 * cfold.cs: Fixed compile blocker.
24317 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24319 * driver.cs: I was chekcing the key, not the file.
24321 2002-10-19 Ravi Pratap <ravi@ximian.com>
24323 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24324 message that we were generating - we just need to silently return
24327 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24329 * class.cs (Event.Define): Change my previous commit, as this
24330 breaks the debugger. This is a temporary hack, as it seems like
24331 the compiler is generating events incorrectly to begin with.
24333 * expression.cs (Binary.ResolveOperator): Added support for
24334 "U operator - (E x, E y)"
24336 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24339 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24340 init-only variables, but this path did not take into account that
24341 there might be also instance readonly variables. Correct this
24344 This fixes bug 32253
24346 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24349 * driver.cs: Change the extension for modules to `netmodule'
24351 * cs-parser.jay: Improved slightly the location tracking for
24352 the debugger symbols.
24354 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24355 modifiers that were specified instead of the hardcoded value
24356 (FamAndAssem). This was basically ignoring the static modifier,
24357 and others. Fixes 32429.
24359 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24360 fixed a bug in the process (32476)
24362 * expression.cs (ArrayAccess.EmitAssign): Patch from
24363 hwang_rob@yahoo.ca that fixes bug 31834.3
24365 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24367 * driver.cs: Make the module extension .netmodule.
24369 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24371 * driver.cs: Report an error if the resource file is not found
24372 instead of crashing.
24374 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24375 false, like Emit does.
24377 2002-10-16 Nick Drochak <ndrochak@gol.com>
24379 * typemanager.cs: Remove unused private member. Also reported mcs
24380 bug to report this as a warning like csc.
24382 2002-10-15 Martin Baulig <martin@gnome.org>
24384 * statement.cs (Statement.Emit): Made this a virtual method; emits
24385 the line number info and calls DoEmit().
24386 (Statement.DoEmit): New protected abstract method, formerly knows
24387 as Statement.Emit().
24389 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24391 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24393 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24394 have fixed a remaining problem: not every AddXXXX was adding a
24395 fully qualified name.
24397 Now everyone registers a fully qualified name in the DeclSpace as
24398 being defined instead of the partial name.
24400 Downsides: we are slower than we need to be due to the excess
24401 copies and the names being registered this way.
24403 The reason for this is that we currently depend (on the corlib
24404 bootstrap for instance) that types are fully qualified, because
24405 we dump all the types in the namespace, and we should really have
24406 types inserted into the proper namespace, so we can only store the
24407 basenames in the defined_names array.
24409 2002-10-10 Martin Baulig <martin@gnome.org>
24411 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24412 from bug #31834, see the bug report for a testcase which is
24415 2002-10-10 Martin Baulig <martin@gnome.org>
24417 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24418 flow analysis code for this.
24420 * statement.cs (Do, While, For): Tell the flow analysis code about
24422 (FlowBranching.UsageVector): Added support for infinite loops.
24423 (Block.Resolve): Moved the dead code elimination here and use flow
24426 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24428 * class.cs (Field.Define): Catch cycles on struct type
24431 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24432 fields if the fields are static. We only need to check instance
24435 * expression.cs (As.DoResolve): Test for reference type.
24437 * statement.cs (Using.ResolveExpression): Use
24438 ConvertImplicitRequired, not ConvertImplicit which reports an
24440 (Using.ResolveLocalVariableDecls): ditto.
24442 * expression.cs (Binary.ResolveOperator): Report errors in a few
24443 places where we had to.
24445 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24447 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24449 * expression.cs: Use StoreFromPtr instead of extracting the type
24450 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24452 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24453 an enumeration value to a System.Enum, but System.Enum is not a
24454 value type, but an class type, so we need to box.
24456 (Expression.ConvertExplicit): One codepath could return
24457 errors but not flag them. Fix this. Fixes #31853
24459 * parameter.cs (Resolve): Do not allow void as a parameter type.
24461 2002-10-06 Martin Baulig <martin@gnome.org>
24463 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24464 if it's a class type and not a struct. Fixes #31815.
24466 2002-10-06 Martin Baulig <martin@gnome.org>
24468 * statement.cs: Reworked the flow analysis code a bit to make it
24469 usable for dead code elimination.
24471 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24473 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24475 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24477 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24478 to fix the test 165, will investigate deeper.
24480 2002-10-04 Martin Baulig <martin@gnome.org>
24482 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24483 finally blocks actually work.
24484 (Try.Resolve): We don't need to create a sibling for `finally' if
24485 there is no finally block.
24487 2002-10-04 Martin Baulig <martin@gnome.org>
24489 * class.cs (Constructor.Define): The default accessibility for a
24490 non-default constructor is private, not public.
24492 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24494 * class.cs (Constructor): Make AllowedModifiers public, add
24497 * cs-parser.jay: Perform the modifiers test here, as the
24498 constructor for the Constructor class usually receives a zero
24499 because of the way we create it (first we create, later we
24500 customize, and we were never checking the modifiers).
24502 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24503 is a version of LookupTypeReflection that includes the type-name
24504 cache. This can be used as a fast path for functions that know
24505 the fully qualified name and are only calling into *.GetType() to
24506 obtain a composed type.
24508 This is also used by TypeManager.LookupType during its type
24511 (LookupType): We now also track the real type name, as sometimes
24512 we can get a quey for the real type name from things like
24513 ComposedCast. This fixes bug 31422.
24515 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24516 complete type fullname, it does not have to go through the type
24517 resolution system to obtain the composed version of the type (for
24518 obtaining arrays or pointers).
24520 (Conditional.Emit): Use the EmitBoolExpression to
24521 generate nicer code, as requested by Paolo.
24523 (ArrayCreation.CheckIndices): Use the patch from
24524 hwang_rob@yahoo.ca to validate the array initializers.
24526 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24528 * class.cs (ConstructorInitializer.Emit): simplify code by using
24529 Invocation.EmitCall, and at the same time, fix the bugs in calling
24530 parent constructors that took variable arguments.
24532 * ecore.cs (Expression.ConvertNumericExplicit,
24533 Expression.ImplicitNumericConversion): Remove the code that
24534 manually wrapped decimal (InternalTypeConstructor call is now gone
24537 * expression.cs (Cast.TryReduce): Also handle decimal types when
24538 trying to perform a constant fold on the type.
24540 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24542 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24543 that only turned off an error report, and did nothing else.
24545 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24547 * driver.cs: Handle and ignore /fullpaths
24549 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24551 * expression.cs (Binary.ResolveOperator): Catch the case where
24552 DoNumericPromotions returns true,
24554 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24556 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24558 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24561 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24563 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24564 conversion exists, but it is also required that the conversion be
24565 performed. This manifested in "(Type64Enum) 2".
24567 * class.cs (TypeManager.AddMethod): The fix is not to change
24568 AddEnum, because that one was using a fully qualified name (every
24569 DeclSpace derivative does), but to change the AddMethod routine
24570 that was using an un-namespaced name. This now correctly reports
24571 the duplicated name.
24573 Revert patch until I can properly fix it. The issue
24574 is that we have a shared Type space across all namespaces
24575 currently, which is wrong.
24577 Options include making the Namespace a DeclSpace, and merge
24578 current_namespace/current_container in the parser.
24580 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24582 * cs-parser.jay: Improve error reporting when we get a different
24583 kind of expression in local_variable_type and
24584 local_variable_pointer_type.
24586 Propagate this to avoid missleading errors being reported.
24588 * ecore.cs (ImplicitReferenceConversion): treat
24589 TypeManager.value_type as a target just like object_type. As
24594 Is valid, and needs to result in the int 1 being boxed before it
24595 is assigned to the value type v.
24597 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24598 to validate the enumeration name.
24600 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24601 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24602 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24604 * ecore.cs (TryImplicitIntConversion): When doing an
24605 implicit-enumeration-conversion, check if the type is 64-bits and
24606 perform a conversion before passing to EnumConstant.
24608 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24610 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24611 report ambiguous type references. Unlike the MS version, we
24612 report what the ambiguity is. Innovation at work ;-)
24614 (DeclSpace.FindType): Require a location argument to
24615 display when we display an ambiguous error.
24617 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24619 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24621 * expression.cs (EmitDynamicInitializers): Apply patch from
24622 hwang_rob@yahoo.ca that fixes the order in which we emit our
24625 2002-09-21 Martin Baulig <martin@gnome.org>
24627 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24628 delegate takes no arguments.
24630 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24632 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24635 * expression.cs: Extract the underlying type.
24637 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24639 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24641 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24643 * class.cs (TypeContainer.DefineType): We can not use the nice
24644 PackingSize with the size set to 1 DefineType method, because it
24645 will not allow us to define the interfaces that the struct
24648 This completes the fixing of bug 27287
24650 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24651 means also structs. This fixes part of the problem.
24652 (Expresion.ImplicitReferenceConversionExists): ditto.
24654 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24655 error if there were no errors reported during the type lookup
24656 process, to avoid duplicates or redundant errors. Without this
24657 you would get an ambiguous errors plus a type not found. We have
24658 beaten the user enough with the first error.
24660 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24663 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24664 during the resolution process, stop the lookup, this avoids
24665 repeated error reports (same error twice).
24667 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24669 * typemanager.cs (LookupType): Redo the type lookup code to match
24670 the needs of System.Reflection.
24672 The issue is that System.Reflection requires references to nested
24673 types to begin with a "+" sign instead of a dot. So toplevel
24674 types look like: "NameSpace.TopLevelClass", and nested ones look
24675 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24678 2002-09-19 Martin Baulig <martin@gnome.org>
24680 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24681 says that a method always returns or always throws an exception,
24682 don't report the CS0161.
24684 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24685 set `Returns = new_returns'.
24687 2002-09-19 Martin Baulig <martin@gnome.org>
24689 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24690 to an enum constant, check for a CS0176.
24692 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24694 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24695 for operators that must be in pairs and report errors.
24697 * ecore.cs (SimpleName.DoResolveType): During the initial type
24698 resolution process, when we define types recursively, we must
24699 check first for types in our current scope before we perform
24700 lookups in the enclosing scopes.
24702 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24704 (Invocation.VerifyArgumentsCompat): Call
24705 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24706 I thought we were supposed to always call this, but there are a
24707 few places in the code where we dont do it.
24709 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24711 * driver.cs: Add support in -linkres and -resource to specify the
24712 name of the identifier.
24714 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24716 * ecore.cs (StandardConversionExists): Sync with the conversion
24717 code: allow anything-* to void* conversions.
24719 (FindMostSpecificSource): Use an Expression argument
24720 instead of a Type, because we might be handed over a Literal which
24721 gets a few more implicit conversions that plain types do not. So
24722 this information was being lost.
24724 Also, we drop the temporary type-holder expression when not
24727 2002-09-17 Martin Baulig <martin@gnome.org>
24729 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24730 this is an explicit interface implementation.
24732 2002-09-17 Martin Baulig <martin@gnome.org>
24734 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24735 different `IndexerName' attributes.
24737 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24738 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24739 virtual CommonResolve().
24741 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24743 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24744 and convert that to the UnderlyingType.
24746 * statement.cs (Foreach.Resolve): Indexers are just like variables
24747 or PropertyAccesses.
24749 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24750 inside quoted strings, we were not doing this before.
24752 2002-09-16 Martin Baulig <martin@gnome.org>
24754 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24755 resolve it. This is needed for the definite assignment check of the
24756 instance expression, fixes bug #29846.
24757 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24759 2002-09-16 Nick Drochak <ndrochak@gol.com>
24761 * parameter.cs: Fix compile error. Cannot reference static member
24762 from an instance object. Is this an mcs bug?
24764 2002-09-14 Martin Baulig <martin@gnome.org>
24766 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24767 multiple times. Fixes bug #30295, added test-166.cs.
24769 2002-09-14 Martin Baulig <martin@gnome.org>
24771 * statement.cs (Block.Emit): Don't emit unreachable code.
24772 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24773 `break' statements.
24774 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24776 2002-09-14 Martin Baulig <martin@gnome.org>
24778 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24781 2002-09-14 Martin Baulig <martin@gnome.org>
24783 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24784 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24785 be false on the ms runtime.
24787 2002-09-13 Martin Baulig <martin@gnome.org>
24789 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24790 the CS0038 error message.
24792 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24794 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24795 constant inside, return it.
24797 2002-09-12 Martin Baulig <martin@gnome.org>
24799 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24800 implicit conversion can be done between enum types.
24802 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24803 check whether an implicit conversion to the current enum's UnderlyingType
24804 exists and report an error if not.
24806 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24807 without debugging support.
24809 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24810 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24812 2002-09-12 Martin Baulig <martin@gnome.org>
24814 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24816 * ecore.cs (IMemberExpr.DeclaringType): New property.
24817 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24818 nonstatic member of an outer type (CS0038).
24820 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24822 * driver.cs: Activate the using-error detector at warning level
24823 4 (at least for MS-compatible APIs).
24825 * namespace.cs (VerifyUsing): Small buglett fix.
24827 * pending.cs (PendingImplementation): pass the container pointer.
24829 * interface.cs (GetMethods): Allow for recursive definition. Long
24830 term, I would like to move every type to support recursive
24831 definitions, not the current ordering mechanism that we have right
24834 The situation is this: Attributes are handled before interfaces,
24835 so we can apply attributes to interfaces. But some attributes
24836 implement interfaces, we will now handle the simple cases
24837 (recursive definitions will just get an error).
24839 * parameter.cs: Only invalidate types at the end if we fail to
24842 2002-09-09 Martin Baulig <martin@gnome.org>
24844 * ecore.cs (PropertyExpr.Emit): Also check for
24845 TypeManager.system_int_array_get_length so this'll also work when
24846 compiling corlib. Fixes #30003.
24848 2002-09-09 Martin Baulig <martin@gnome.org>
24850 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24851 and throw an exception if we can't get the type's size. Fixed #30040,
24854 2002-09-09 Martin Baulig <martin@gnome.org>
24856 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24858 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24859 context. Fixes bug #30027.
24861 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24862 virtual functions. Fixes bug #30043, added test-164.cs.
24864 2002-09-08 Ravi Pratap <ravi@ximian.com>
24866 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24868 2002-09-08 Nick Drochak <ndrochak@gol.com>
24870 * driver.cs: Use an object to get the windows codepage since it's not a
24873 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24875 * statement.cs (For.Emit): for infinite loops (test == null)
24876 return whether there is a break inside, not always "true".
24878 * namespace.cs (UsingEntry): New struct to hold the name of the
24879 using definition, the location where it is defined, and whether it
24880 has been used in a successful type lookup.
24882 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24887 2002-09-06 Ravi Pratap <ravi@ximian.com>
24889 * attribute.cs : Fix incorrect code which relied on catching
24890 a NullReferenceException to detect a null being passed in
24891 where an object was expected.
24893 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24895 * statement.cs (Try): flag the catch variable as assigned
24897 * expression.cs (Cast): Simplified by using ResolveType instead of
24898 manually resolving.
24900 * statement.cs (Catch): Fix bug by using ResolveType.
24902 2002-09-06 Ravi Pratap <ravi@ximian.com>
24904 * expression.cs (BetterConversion): Special case for when we have
24905 a NullLiteral as the argument and we have to choose between string
24906 and object types - we choose string the way csc does.
24908 * attribute.cs (Attribute.Resolve): Catch the
24909 NullReferenceException and report error #182 since the Mono
24910 runtime no more has the bug and having this exception raised means
24911 we tried to select a constructor which takes an object and is
24914 2002-09-05 Ravi Pratap <ravi@ximian.com>
24916 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24917 message (1502, 1503) when we can't locate a method after overload
24918 resolution. This is much more informative and closes the bug
24921 * interface.cs (PopulateMethod): Return if there are no argument
24922 types. Fixes a NullReferenceException bug.
24924 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24925 expressions too. Previously we were checking only in one place for
24926 positional arguments leaving out named arguments.
24928 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24929 type to the enum type is not allowed. Remove code corresponding to
24932 (ConvertNumericExplicit): Allow explicit conversions from
24933 the underlying type to enum type. This precisely follows the spec
24934 and closes a bug filed by Gonzalo.
24936 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24939 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24941 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24943 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24944 it was important that we stored the right value after the
24945 reduction in `converted'.
24947 2002-09-04 Martin Baulig <martin@gnome.org>
24949 * location.cs (Location.SymbolDocument): Use full pathnames for the
24952 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24954 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24955 of the expression resolve mechanism, because that will catch the
24956 SimpleName error failures.
24958 (Conditional): If we can not resolve the
24959 expression, return, do not crash.
24961 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24964 (location): display token name instead of its number.
24966 2002-08-28 Martin Baulig <martin@gnome.org>
24968 * expression.cs (Binary.ResolveOperator): Don't silently return
24969 but return an error if an operator cannot be applied between two
24972 2002-08-28 Martin Baulig <martin@gnome.org>
24974 * class.cs (Constructor.Define): Set the permission attributes
24975 correctly instead of making all constructors public.
24977 2002-08-28 Martin Baulig <martin@gnome.org>
24979 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24980 for private members before reporting a CS0103; if we find anything,
24983 2002-08-28 Martin Baulig <martin@gnome.org>
24985 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24986 to check whether `closure_start_type == closure_invocation_type',
24987 we also need to check whether `m.DeclaringType == closure_invocation_type'
24988 before bypassing the permission checks. We might be accessing
24989 protected/private members from the base class.
24990 (TypeManager.RealMemberLookup): Only set private_ok if private
24991 members were requested via BindingFlags.NonPublic.
24993 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24995 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24996 MethodGroupExpr.IsExplicitImpl if appropriate.
24997 (Invocation.DoResolve): Don't report the CS0120 for explicit
24998 interface implementations.
25000 2002-08-27 Martin Baulig <martin@gnome.org>
25002 * expression.cs (Invocation.DoResolve): If this is a static
25003 method and we don't have an InstanceExpression, we must report
25006 2002-08-25 Martin Baulig <martin@gnome.org>
25008 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
25009 `==' between a valuetype and an object.
25011 2002-08-25 Miguel de Icaza <miguel@ximian.com>
25013 * ecore.cs (TypeExpr): Provide a ToString method.
25015 2002-08-24 Martin Baulig <martin@gnome.org>
25017 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
25018 now called proggie.dbg and it's a binary file.
25020 2002-08-23 Martin Baulig <martin@gnome.org>
25022 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
25024 2002-08-23 Martin Baulig <martin@gnome.org>
25026 * struct.cs (MyStructInfo.ctor): Make this work with empty
25027 structs; it's not allowed to use foreach() on null.
25029 2002-08-23 Martin Baulig <martin@gnome.org>
25031 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
25032 writer the full pathname of the generated assembly.
25034 2002-08-23 Martin Baulig <martin@gnome.org>
25036 * statements.cs (FlowBranching.UsageVector.MergeChildren):
25037 A `finally' block never returns or breaks; improved handling of
25040 2002-08-23 Martin Baulig <martin@gnome.org>
25042 * statement.cs (Throw.Resolve): Allow `throw null'.
25044 2002-08-23 Martin Baulig <martin@gnome.org>
25046 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
25047 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
25048 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
25049 MemberLookup would return a wrong event if this is an explicit
25050 interface implementation and the class has an event with the same
25053 2002-08-23 Martin Baulig <martin@gnome.org>
25055 * statement.cs (Block.AddChildVariableNames): New public method.
25056 (Block.AddChildVariableName): Likewise.
25057 (Block.IsVariableNameUsedInChildBlock): Likewise.
25058 (Block.AddVariable): Check whether a variable name has already
25059 been used in a child block.
25061 * cs-parser.jay (declare_local_variables): Mark all variable names
25062 from the current block as being used in a child block in the
25065 2002-08-23 Martin Baulig <martin@gnome.org>
25067 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
25068 find the symbol writer.
25070 * driver.cs: csc also allows the arguments to /define being
25071 separated by commas, not only by semicolons.
25073 2002-08-23 Martin Baulig <martin@gnome.org>
25075 * interface.cs (Interface.GetMembers): Added static check for events.
25077 2002-08-15 Martin Baulig <martin@gnome.org>
25079 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
25080 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
25082 * ecore.cs (Expression.MemberLookup): Added documentation and explained
25083 why the MethodData.EmitDestructor() change was necessary.
25085 2002-08-20 Martin Baulig <martin@gnome.org>
25087 * class.cs (TypeContainer.FindMembers): Added static check for events.
25089 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
25091 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
25092 use Type.GetEvents(), not Type.FindMembers().
25094 2002-08-20 Martin Baulig <martin@gnome.org>
25096 * decl.cs (MemberCache): Added a special method cache which will
25097 be used for method-only searched. This ensures that a method
25098 search will return a MethodInfo with the correct ReflectedType for
25101 2002-08-20 Martin Baulig <martin@gnome.org>
25103 * decl.cs (DeclSpace.FindMembers): Made this public.
25105 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25107 * delegate.cs: fixed build on windows.
25108 [FIXME: Filed as bug #29150: MCS must report these errors.]
25110 2002-08-19 Ravi Pratap <ravi@ximian.com>
25112 * ecore.cs (StandardConversionExists): Return a false
25113 if we are trying to convert the void type to anything else
25114 since that is not allowed.
25116 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
25117 we flag error 70 in the event an event is trying to be accessed
25118 directly from outside the declaring type.
25120 2002-08-20 Martin Baulig <martin@gnome.org>
25122 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
25123 MemberCache from typemanager.cs to decl.cs.
25125 2002-08-19 Martin Baulig <martin@gnome.org>
25127 * class.cs (TypeContainer): Implement IMemberContainer.
25128 (TypeContainer.DefineMembers): Create the MemberCache.
25129 (TypeContainer.FindMembers): Do better BindingFlags checking; only
25130 return public members if BindingFlags.Public was given, check
25131 whether members are static.
25133 2002-08-16 Martin Baulig <martin@gnome.org>
25135 * decl.cs (DeclSpace.Define): Splitted this in Define and
25136 DefineMembers. DefineMembers is called first and initializes the
25139 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
25140 DefineMembers() on all our DeclSpaces.
25142 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
25143 but call DefineMembers() on all nested interfaces. We call their
25144 Define() in our new Define() function.
25146 * interface.cs (Interface): Implement IMemberContainer.
25147 (Interface.Define): Moved all code except the attribute stuf to
25149 (Interface.DefineMembers): Initialize the member cache.
25151 * typemanager.cs (IMemberFinder): Removed this interface, we don't
25152 need this anymore since we can use MemberCache.FindMembers directly.
25154 2002-08-19 Martin Baulig <martin@gnome.org>
25156 * typemanager.cs (MemberCache): When creating the cache for an
25157 interface type, add all inherited members.
25158 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
25159 to `out bool used_cache' and documented it.
25160 (TypeManager.MemberLookup): If we already used the cache in the first
25161 iteration, we don't need to do the interfaces check.
25163 2002-08-19 Martin Baulig <martin@gnome.org>
25165 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
25166 here from IMemberFinder and don't implement this interface anymore.
25167 (DeclSpace.MemberCache): Moved here from IMemberFinder.
25169 * typemanager.cs (IMemberFinder): This interface is now only used by
25170 classes which actually support the member cache.
25171 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
25172 since we only put DeclSpaces into this Hashtable.
25173 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
25174 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
25176 2002-08-16 Martin Baulig <martin@gnome.org>
25178 * typemanager.cs (ICachingMemberFinder): Removed.
25179 (IMemberFinder.MemberCache): New property.
25180 (TypeManager.FindMembers): Merged this with RealFindMembers().
25181 This function will never be called from TypeManager.MemberLookup()
25182 so we can't use the cache here, just the IMemberFinder.
25183 (TypeManager.MemberLookup_FindMembers): Check whether the
25184 IMemberFinder has a MemberCache and call the cache's FindMembers
25186 (MemberCache): Rewrote larger parts of this yet another time and
25187 cleaned it up a bit.
25189 2002-08-15 Miguel de Icaza <miguel@ximian.com>
25191 * driver.cs (LoadArgs): Support quoting.
25193 (Usage): Show the CSC-like command line arguments.
25195 Improved a few error messages.
25197 2002-08-15 Martin Baulig <martin@gnome.org>
25199 * typemanager.cs (IMemberContainer.Type): New property.
25200 (IMemberContainer.IsInterface): New property.
25202 The following changes are conditional to BROKEN_RUNTIME, which is
25203 defined at the top of the file.
25205 * typemanager.cs (MemberCache.MemberCache): Don't add the base
25206 class'es members, but add all members from TypeHandle.ObjectType
25207 if we're an interface.
25208 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
25209 is the current type.
25210 (MemberCache.CacheEntry.Container): Removed this field.
25211 (TypeHandle.GetMembers): Include inherited members.
25213 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25215 * typemanager.cs: fixed compilation and added a comment on a field that
25218 2002-08-15 Martin Baulig <martin@gnome.org>
25220 * class.cs (ConstructorInitializer.Resolve): In the
25221 Expression.MemberLookup call, use the queried_type as
25224 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25225 declared' attribute, it's always true.
25226 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25227 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25228 temporary wrapper for FindMembers which tells MemberLookup whether
25229 members from the base classes are included in the return value.
25230 This will go away soon.
25231 (TypeManager.MemberLookup): Use this temporary hack here; once the
25232 new MemberCache is completed, we don't need to do the DeclaredOnly
25233 looping here anymore since the MemberCache will take care of this.
25234 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25235 (MemberCache): When creating the MemberCache for a class, get
25236 members from the current class and all its base classes.
25237 (MemberCache.CacheEntry.Container): New field. This is a
25238 temporary hack until the Mono runtime is fixed to distinguish
25239 between ReflectedType and DeclaringType. It allows us to use MCS
25240 with both the MS runtime and the unfixed Mono runtime without
25241 problems and without accecting performance.
25242 (MemberCache.SearchMembers): The DeclaredOnly looping from
25243 TypeManager.MemberLookup is now done here.
25245 2002-08-14 Martin Baulig <martin@gnome.org>
25247 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25248 Type.GetFields on dynamic types but get the fields from the
25249 corresponding TypeContainer.
25250 (MyStructInfo.GetStructInfo): Added check for enum types.
25252 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25253 (MemberList.SyncRoot): Implemented.
25254 (TypeManager.FilterWithClosure): No need to check permissions if
25255 closure_start_type == closure_invocation_type, don't crash if
25256 closure_invocation_type is null.
25258 2002-08-13 Martin Baulig <martin@gnome.org>
25260 Rewrote TypeContainer.FindMembers to use a member cache. This
25261 gives us a speed increase of about 35% for the self-hosting MCS
25262 build and of about 15-20% for the class libs (both on GNU/Linux).
25264 * report.cs (Timer): New class to get enhanced profiling. This
25265 whole class is "TIMER" conditional since it remarkably slows down
25268 * class.cs (MemberList): New class. This is an IList wrapper
25269 which we're now using instead of passing MemberInfo[]'s around to
25270 avoid copying this array unnecessarily.
25271 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25272 (ICachingMemberFinder, IMemberContainer): New interface.
25273 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25274 has already been checked, otherwise use it for the name comparision.
25275 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25276 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25277 if possible. Returns a MemberList, not a MemberInfo [].
25278 (TypeHandle): New class, implements IMemberContainer. We create
25279 one instance of this class per type, it contains a MemberCache
25280 which is used to do the member lookups.
25281 (MemberCache): New class. Each instance of this class contains
25282 all members of a type and a name-based hash table.
25283 (MemberCache.FindMembers): This is our new member lookup
25284 function. First, it looks up all members of the requested name in
25285 the hash table. Then, it walks this list and sorts out all
25286 applicable members and returns them.
25288 2002-08-13 Martin Baulig <martin@gnome.org>
25290 In addition to a nice code cleanup, this gives us a performance
25291 increase of about 1.4% on GNU/Linux - not much, but it's already
25292 half a second for the self-hosting MCS compilation.
25294 * typemanager.cs (IMemberFinder): New interface. It is used by
25295 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25296 Enum, Delegate or Interface.
25297 (TypeManager.finder_to_member_finder): New PtrHashtable.
25298 (TypeManager.finder_to_container): Removed.
25299 (TypeManager.finder_to_delegate): Removed.
25300 (TypeManager.finder_to_interface): Removed.
25301 (TypeManager.finder_to_enum): Removed.
25303 * interface.cs (Interface): Implement IMemberFinder.
25305 * delegate.cs (Delegate): Implement IMemberFinder.
25307 * enum.cs (Enum): Implement IMemberFinder.
25309 * class.cs (TypeContainer): Implement IMemberFinder.
25311 2002-08-12 Martin Baulig <martin@gnome.org>
25313 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25315 2002-08-12 Martin Baulig <martin@gnome.org>
25317 * ecore.cs (ITypeExpression): New interface for expressions which
25319 (TypeExpression): Renamed to TypeLookupExpression.
25320 (Expression.DoResolve): If we're doing a types-only lookup, the
25321 expression must implement the ITypeExpression interface and we
25322 call DoResolveType() on it.
25323 (SimpleName): Implement the new ITypeExpression interface.
25324 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25325 hack, the situation that we're only looking up types can't happen
25326 anymore when this method is called. Moved the type lookup code to
25327 DoResolveType() and call it.
25328 (SimpleName.DoResolveType): This ITypeExpression interface method
25329 is now doing the types-only lookup.
25330 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25331 (ResolveFlags): Added MaskExprClass.
25333 * expression.cs (MemberAccess): Implement the ITypeExpression
25335 (MemberAccess.DoResolve): Added support for a types-only lookup
25336 when we're called via ITypeExpression.DoResolveType().
25337 (ComposedCast): Implement the ITypeExpression interface.
25339 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25340 Expression.Resolve() with ResolveFlags.Type instead.
25342 2002-08-12 Martin Baulig <martin@gnome.org>
25344 * interface.cs (Interface.Define): Apply attributes.
25346 * attribute.cs (Attribute.ApplyAttributes): Added support for
25347 interface attributes.
25349 2002-08-11 Martin Baulig <martin@gnome.org>
25351 * statement.cs (Block.Emit): Only check the "this" variable if we
25352 do not always throw an exception.
25354 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25355 whether the property has a set accessor.
25357 2002-08-11 Martin Baulig <martin@gnome.org>
25359 Added control flow analysis support for structs.
25361 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25362 with control flow analysis turned off.
25363 (IVariable): New interface.
25364 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25365 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25366 (FieldExpr.DoResolve): Resolve the instance expression with flow
25367 analysis turned off and do the definite assignment check after the
25368 resolving when we know what the expression will resolve to.
25370 * expression.cs (LocalVariableReference, ParameterReference):
25371 Implement the new IVariable interface, only call the flow analysis
25372 code if ec.DoFlowAnalysis is true.
25373 (This): Added constructor which takes a Block argument. Implement
25374 the new IVariable interface.
25375 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25376 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25377 This does the definite assignment checks for struct members.
25379 * class.cs (Constructor.Emit): If this is a non-static `struct'
25380 constructor which doesn't have any initializer, call
25381 Block.AddThisVariable() to tell the flow analysis code that all
25382 struct elements must be initialized before control returns from
25385 * statement.cs (MyStructInfo): New public class.
25386 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25387 argument to this indexer. If non-zero, check an individual struct
25388 member, not the whole struct.
25389 (FlowBranching.CheckOutParameters): Check struct members.
25390 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25391 overloaded versions of these methods which take an additional
25392 `int field_idx' argument to check struct members.
25393 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25394 overloaded versions of these methods which take an additional
25395 `string field_name' argument to check struct member.s
25396 (VariableInfo): Implement the IVariable interface.
25397 (VariableInfo.StructInfo): New public property. Returns the
25398 MyStructInfo instance of the variable if it's a struct or null.
25399 (Block.AddThisVariable): New public method. This is called from
25400 Constructor.Emit() for non-static `struct' constructor which do
25401 not have any initializer. It creates a special variable for the
25402 "this" instance variable which will be checked by the flow
25403 analysis code to ensure that all of the struct's fields are
25404 initialized before control returns from the constructor.
25405 (UsageVector): Added support for struct members. If a
25406 variable/parameter is a struct with N members, we reserve a slot
25407 in the usage vector for each member. A struct is considered fully
25408 initialized if either the struct itself (slot 0) or all its
25409 members are initialized.
25411 2002-08-08 Martin Baulig <martin@gnome.org>
25413 * driver.cs (Driver.MainDriver): Only report an error CS5001
25414 if there were no compilation errors.
25416 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25417 `UnsafeContext' property to determine whether the parent is in
25418 unsafe context rather than checking the parent's ModFlags:
25419 classes nested in an unsafe class are unsafe as well.
25421 2002-08-08 Martin Baulig <martin@gnome.org>
25423 * statement.cs (UsageVector.MergeChildren): Distinguish between
25424 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25425 we return. Added test17() and test18() to test-154.cs.
25427 2002-08-08 Martin Baulig <martin@gnome.org>
25429 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25430 Family access, make sure the invoking type isn't a subclass of the
25431 queried type (that'd be a CS1540).
25433 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25434 this method which takes an additional `Type invocation_type'.
25436 * expression.cs (BaseAccess.DoResolve): Use the base type as
25437 invocation and query type.
25438 (MemberAccess.DoResolve): If the lookup failed and we're about to
25439 report a CS0122, try a lookup with the ec.ContainerType - if this
25440 succeeds, we must report a CS1540.
25442 2002-08-08 Martin Baulig <martin@gnome.org>
25444 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25445 (MethodGroupExpr): Implement the IMemberExpr interface.
25447 * expression (MemberAccess.ResolveMemberAccess): No need to have
25448 any special code for MethodGroupExprs anymore, they're now
25451 2002-08-08 Martin Baulig <martin@gnome.org>
25453 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25454 Family, FamANDAssem and FamORAssem permissions.
25455 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25457 2002-08-08 Martin Baulig <martin@gnome.org>
25459 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25460 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25463 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25465 * driver.cs: implemented /resource option to embed managed resources.
25467 2002-08-07 Martin Baulig <martin@gnome.org>
25469 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25470 (FieldBase.HasFieldInitializer): New public property.
25471 (FieldBase.GetInitializerExpression): New public method. Resolves and
25472 returns the field initializer and makes sure it is only resolved once.
25473 (TypeContainer.EmitFieldInitializers): Call
25474 FieldBase.GetInitializerExpression to get the initializer, this ensures
25475 that it isn't resolved multiple times.
25477 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25478 the resolving process (SimpleName/MemberLookup) that we're currently
25479 emitting a field initializer (which must not access any instance members,
25480 this is an error CS0236).
25482 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25483 argument, if the `IsFieldInitializer' flag is set, we must report and
25484 error CS0236 and not an error CS0120.
25486 2002-08-07 Martin Baulig <martin@gnome.org>
25488 * ecore.cs (IMemberExpr): New public interface.
25489 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25490 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25491 if the expression is an IMemberExpr.
25493 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25494 to be null, implicitly default to `this' if we're non-static in
25495 this case. Simplified the code a lot by using the new IMemberExpr
25496 interface. Also fixed bug #28176 here.
25498 2002-08-06 Martin Baulig <martin@gnome.org>
25500 * cs-parser.jay (SimpleLookup): Removed. We need to create
25501 ParameterReferences during semantic analysis so that we can do a
25502 type-only search when resolving Cast, TypeOf and SizeOf.
25503 (block): Pass the `current_local_parameters' to the Block's
25506 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25507 argument to the constructor.
25508 (ConstructorInitializer.Resolve): Create a temporary implicit
25509 block with the parameters.
25511 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25512 references here if we aren't doing a type-only search.
25514 * statement.cs (Block): Added constructor which takes a
25515 `Parameters parameters' argument.
25516 (Block.Parameters): New public property.
25518 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25519 to `Parameters' and made it public readonly.
25521 2002-08-06 Martin Baulig <martin@gnome.org>
25523 * ecore.cs (Expression.Warning): Made this public as well.
25525 * report.cs (Report.Debug): Print the contents of collections.
25527 2002-08-06 Martin Baulig <martin@gnome.org>
25529 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25530 used to tell Resolve() which kinds of expressions it may return.
25531 (Expression.Resolve): Added overloaded version of this method which
25532 takes a `ResolveFlags flags' argument. This can be used to tell
25533 Resolve() which kinds of expressions it may return. Reports a
25535 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25536 ResolveFlags.SimpleName.
25537 (Expression.Error118): Added overloaded version of this method which
25538 takes a `ResolveFlags flags' argument. It uses the flags to determine
25539 which kinds of expressions are allowed.
25541 * expression.cs (Argument.ResolveMethodGroup): New public method.
25542 Resolves an argument, but allows a MethodGroup to be returned.
25543 This is used when invoking a delegate.
25545 * TODO: Updated a bit.
25547 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25549 Fixed compilation with csc.
25551 * ecore.cs: Expression.Error made public. Is this correct? Should
25552 Warning be made public too?
25554 * expression.cs: use ea.Location instead of ea.loc.
25555 [FIXME: Filed as bug #28607: MCS must report these errors.]
25557 2002-08-06 Martin Baulig <martin@gnome.org>
25559 * ecore.cs (Expression.loc): Moved the location here instead of
25560 duplicating it in all derived classes.
25561 (Expression.Location): New public property.
25562 (Expression.Error, Expression.Warning): Made them non-static and
25563 removed the location argument.
25564 (Expression.Warning): Added overloaded version which takes an
25565 `int level' argument.
25566 (Expression.Error118): Make this non-static and removed the
25567 expression and location arguments.
25568 (TypeExpr): Added location argument to the constructor.
25570 * expression.cs (StaticCallExpr): Added location argument to
25572 (Indirection, PointerArithmetic): Likewise.
25573 (CheckedExpr, UnCheckedExpr): Likewise.
25574 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25575 (StringPtr): Likewise.
25578 2002-08-05 Martin Baulig <martin@gnome.org>
25580 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25582 * assign.cs (Assign.DoResolve): Check whether the source
25583 expression is a value or variable.
25585 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25586 while resolving the corresponding blocks.
25588 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25589 an error, don't silently return null.
25591 * statement.cs (Block.AddVariable): Do the error reporting here
25592 and distinguish between CS0128 and CS0136.
25593 (Block.DoResolve): Report all unused labels (warning CS0164).
25594 (LabeledStatement): Pass the location to the constructor.
25595 (LabeledStatement.HasBeenReferenced): New property.
25596 (LabeledStatement.Resolve): Set it to true here.
25598 * statement.cs (Return.Emit): Return success even after reporting
25599 a type mismatch error (CS0126 or CS0127), this is what csc does and
25600 it avoids confusing the users with any consecutive errors.
25602 2002-08-05 Martin Baulig <martin@gnome.org>
25604 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25606 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25608 * expression.cs (MemberAccess.DoResolve): Silently return if an
25609 error has already been reported.
25611 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25612 error has already been reported.
25614 2002-08-05 Martin Baulig <martin@gnome.org>
25616 * statement.cs (UsageVector): Only initialize the `parameters'
25617 vector if we actually have any "out" parameters.
25619 2002-08-05 Martin Baulig <martin@gnome.org>
25621 * expression.cs (Binary.ResolveOperator): When combining delegates,
25622 they must have the same type.
25624 2002-08-05 Martin Baulig <martin@gnome.org>
25626 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25627 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25628 work with the ms runtime and we also don't need it: if we're a
25629 PropertyBuilder and not in the `indexer_arguments' hash, then we
25630 are a property and not an indexer.
25632 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25633 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25634 since the latter one doesn't work with the ms runtime.
25636 2002-08-03 Martin Baulig <martin@gnome.org>
25638 Fixed bugs #27998 and #22735.
25640 * class.cs (Method.IsOperator): New public field.
25641 (Method.CheckBase): Report CS0111 if there's already a method
25642 with the same parameters in the current class. Report CS0508 when
25643 attempting to change the return type of an inherited method.
25644 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25645 and it's not marked abstract or extern.
25646 (PropertyBase): New abstract base class for Property and Indexer.
25647 (PropertyBase.CheckBase): Moved here from Property and made it work
25649 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25650 the same so we can reuse it there.
25651 (Property, Indexer): Derive from PropertyBase.
25652 (MethodSignature.inheritable_property_signature_filter): New delegate
25653 to find properties and indexers.
25655 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25656 argument and improved error reporting.
25658 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25659 EmptyReadOnlyParameters and made it a property.
25661 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25662 version of this method which takes a `PropertyInfo indexer'.
25663 (TypeManager.RegisterIndexer): New method.
25665 * class.cs: Added myself as author of this file :-)
25667 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25669 * class.cs: fixed compilation on windoze.
25671 2002-08-03 Martin Baulig <martin@gnome.org>
25673 * interface.cs (Interface.GetInterfaceBases): Check whether all
25674 base interfaces are at least as accessible than the current one.
25676 * class.cs (TypeContainer.GetClassBases): Check whether base types
25677 are at least as accessible than the current type.
25678 (TypeContainer.AsAccessible): Implemented and made non-static.
25679 (MemberBase.CheckParameters): Report errors if the accessibility
25682 * delegate.cs (Delegate.Delegate): The default visibility is
25683 internal for top-level types and private for nested types.
25684 (Delegate.Define): Report errors if the accessibility checks fail.
25686 * enum.cs (Enum.Enum): The default visibility is internal for
25687 top-level types and private for nested types.
25688 (Enum.DefineType): Compute the correct visibility.
25690 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25691 function which takes a `bool is_toplevel' instead of a TypeContainer.
25693 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25696 2002-08-02 Martin Baulig <martin@gnome.org>
25698 * expression.cs (LocalVariableReferenc): Added constructor which
25699 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25700 (LocalVariableReference.IsReadOnly): New property.
25701 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25702 variable is readonly, use our own readonly flag to do this; you can
25703 use the new constructor to get a writable reference to a read-only
25706 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25707 reference to the local variable.
25709 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25711 * rootcontext.cs (ResolveCore): Also include System.Exception
25713 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25714 we reach an EmptyStatement.
25716 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25719 * expression.cs (Binary.ResolveOperator): Check error result in
25722 use brtrue/brfalse directly and avoid compares to null.
25724 2002-08-02 Martin Baulig <martin@gnome.org>
25726 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25727 Fixes bug #28407, added test-155.cs.
25729 2002-08-01 Martin Baulig <martin@gnome.org>
25731 * class.cs (Event.EmitDefaultMethod): Make this work with static
25732 events. Fixes #28311, added verify-3.cs.
25734 2002-08-01 Martin Baulig <martin@gnome.org>
25736 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25737 `is_disposable' fields.
25738 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25739 `hm.is_disposable' if we're using the collection pattern.
25740 (Foreach.EmitCollectionForeach): Use the correct type for the
25741 enumerator's local variable, only emit the try/finally block if
25742 necessary (fixes #27713).
25744 2002-08-01 Martin Baulig <martin@gnome.org>
25746 * ecore.cs (Expression.report118): Renamed to Error118 and made
25749 * statement.cs (Throw.Resolve): Check whether the expression is of
25750 the correct type (CS0118) and whether the type derives from
25751 System.Exception (CS0155).
25752 (Catch.Resolve): New method. Do the type lookup here and check
25753 whether it derives from System.Exception (CS0155).
25754 (Catch.CatchType, Catch.IsGeneral): New public properties.
25756 * typemanager.cs (TypeManager.exception_type): Added.
25758 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25760 * driver.cs: Updated About function.
25762 2002-07-31 Martin Baulig <martin@gnome.org>
25764 Implemented Control Flow Analysis.
25766 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25767 (EmitContext.CurrentBranching): Added.
25768 (EmitContext.StartFlowBranching): Added.
25769 (EmitContext.EndFlowBranching): Added.
25770 (EmitContext.KillFlowBranching): Added.
25771 (EmitContext.IsVariableAssigned): Added.
25772 (EmitContext.SetVariableAssigned): Added.
25773 (EmitContext.IsParameterAssigned): Added.
25774 (EmitContext.SetParameterAssigned): Added.
25775 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25776 Added control flow analysis stuff here.
25778 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25779 resolve the expression as lvalue.
25780 (LocalVariableReference.DoResolve): Check whether the variable has
25781 already been assigned.
25782 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25783 the parameter as assigned here.
25784 (ParameterReference.DoResolve): Check whether the parameter has already
25786 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25787 expression as lvalue.
25789 * statement.cs (FlowBranching): New class for the flow analysis code.
25790 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25791 (LabeledStatement.IsDefined): New public property.
25792 (LabeledStatement.AddUsageVector): New public method to tell flow
25793 analyis that the label may be reached via a forward jump.
25794 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25796 (VariableInfo.Number): New public field. This is used by flow analysis
25797 to number all locals of a block.
25798 (Block.CountVariables): New public property. This is the number of
25799 local variables in this block (including the locals from all parent
25801 (Block.EmitMeta): Number all the variables.
25803 * statement.cs: Added flow analysis support to all classes.
25805 2002-07-31 Martin Baulig <martin@gnome.org>
25807 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25808 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25809 then use this argument.
25811 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25813 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25814 use this to specify /define options.
25816 2002-07-29 Martin Baulig <martin@gnome.org>
25818 * statement.cs (Fixed): Moved all code that does variable lookups
25819 and resolvings from Emit to Resolve.
25821 * statement.cs (For): Moved all code that does variable lookups
25822 and resolvings from Emit to Resolve.
25824 * statement.cs (Using): Moved all code that does variable lookups
25825 and resolvings from Emit to Resolve.
25827 2002-07-29 Martin Baulig <martin@gnome.org>
25829 * attribute.cs (Attribute.Resolve): Explicitly catch a
25830 System.NullReferenceException when creating the
25831 CustromAttributeBuilder and report a different warning message.
25833 2002-07-29 Martin Baulig <martin@gnome.org>
25835 * support.cs (ParameterData.ParameterName): Added method to
25836 get the name of a parameter.
25838 * typemanager.cs (TypeManager.IsValueType): New public method.
25840 2002-07-29 Martin Baulig <martin@gnome.org>
25842 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25843 is a flag which specifies that it's either ref or out.
25844 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25845 the out parameter to `out Parameter.Modifier mod', also set the
25846 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25848 * support.cs (InternalParameters.ParameterModifier): Distinguish
25849 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25850 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25852 * expression.cs (Argument.GetParameterModifier): Distinguish
25853 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25854 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25856 2002-07-29 Martin Baulig <martin@gnome.org>
25858 * expression.cs (ParameterReference.ParameterReference): Added
25859 `Location loc' argument to the constructor.
25861 * cs-parser.jay: Pass location to ParameterReference.
25863 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25865 * statement.cs (Try): Initialize the location.
25867 * cs-parser.jay: pass location to Try.
25869 * expression.cs (Unary.Reduce): Change the prototype to return
25870 whether a constant fold could be performed or not. The result is
25871 returned in an out parameters. In the case of Indirection and
25872 AddressOf, we want to perform the full tests.
25874 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25876 * statement.cs (Statement.Emit): Flag dead code.
25878 2002-07-27 Andrew Birkett <andy@nobugs.org>
25880 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25882 2002-07-27 Martin Baulig <martin@gnome.org>
25884 * class.cs (MethodData.Define): Put back call to
25885 TypeManager.AddMethod(), accidentally commented this out.
25887 * report.cs (Debug): New public method to print debugging information,
25888 this is `[Conditional ("DEBUG")]'.
25890 2002-07-26 Martin Baulig <martin@gnome.org>
25892 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25893 (switch_statement): Push the current_block to the switch_stack and
25894 pop it again when we're done with the switch.
25895 (switch_section): The new block is a child of the current_block.
25896 Fixes bug #24007, added test-152.cs.
25898 2002-07-27 Martin Baulig <martin@gnome.org>
25900 * expression.cs (Invocation.EmitArguments): When calling a varargs
25901 function with only its fixed arguments, we need to pass an empty
25904 2002-07-27 Martin Baulig <martin@gnome.org>
25906 Mono 0.13 has been released.
25908 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25910 * driver.cs: Rename --resource to --linkres, because that is what
25911 we do currently, we dont support --resource yet.
25913 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25915 2002-07-25 Martin Baulig <martin@gnome.org>
25917 * class.cs (MethodData): New public class. This is a `method builder'
25918 class for a method or one accessor of a Property/Indexer/Event.
25919 (MethodData.GetMethodFlags): Moved here from MemberBase.
25920 (MethodData.ApplyAttributes): Likewise.
25921 (MethodData.ApplyObsoleteAttribute): Likewise.
25922 (MethodData.ApplyConditionalAttribute): Likewise.
25923 (MethodData.ApplyDllImportAttribute): Likewise.
25924 (MethodData.CheckAbstractAndExternal): Likewise.
25925 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25926 (MethodData.Emit): Formerly known as Method.Emit().
25927 (MemberBase): Moved everything which was specific to a single
25928 accessor/method to MethodData.
25929 (Method): Create a new MethodData and call Define() and Emit() on it.
25930 (Property, Indexer, Event): Create a new MethodData objects for each
25931 accessor and call Define() and Emit() on them.
25933 2002-07-25 Martin Baulig <martin@gnome.org>
25935 Made MethodCore derive from MemberBase to reuse the code from there.
25936 MemberBase now also checks for attributes.
25938 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25939 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25941 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25942 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25943 (MemberBase.ApplyAttributes): New virtual method; applies the
25944 attributes to a method or accessor.
25945 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25946 (MemberBase.ApplyConditionalAttribute): Likewise.
25947 (MemberBase.ApplyDllImportAttribute): Likewise.
25948 (MemberBase.CheckAbstractAndExternal): Likewise.
25949 (MethodCore.ParameterTypes): This is now a property instead of a
25950 method, it's initialized from DoDefineParameters().
25951 (MethodCore.ParameterInfo): Removed the set accessor.
25952 (MethodCore.DoDefineParameters): New protected virtual method to
25953 initialize ParameterTypes and ParameterInfo.
25954 (Method.GetReturnType): We can now simply return the MemberType.
25955 (Method.GetMethodFlags): Override the MemberBase version and add
25956 the conditional flags.
25957 (Method.CheckBase): Moved some code from Define() here, call
25958 DoDefineParameters() here.
25959 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25960 here to avoid some larger code duplication.
25961 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25962 ensure that abstract and external accessors don't declare a body.
25964 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25965 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25966 lookup in the attribute's parent classes, so we need to abort as soon
25967 as we found the first match.
25968 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25969 the attribute has no arguments.
25971 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25974 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25976 * cs-parser.jay: reverted previous patch.
25978 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25980 * cs-parser.jay: fixed bug #22119.
25982 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25984 * attribute.cs: fixed compilation. The error was:
25985 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25986 be assigned to before control leaves the current method."
25987 [FIXME: Filed as bug #28186: MCS must report this error.]
25989 2002-07-25 Martin Baulig <martin@gnome.org>
25991 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25992 method to pull the condition name ouf of a Conditional attribute.
25993 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25994 the obsolete message and error flag out of an Obsolete attribute.
25996 * class.cs (Method.GetMethodFlags): New public method to get the
25997 TypeManager.MethodFlags for this method.
25998 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
26000 (Method.Define): Get and apply the Obsolete and Conditional attributes;
26001 if we're overriding a virtual function, set the new private variable
26002 `parent_method'; call the new TypeManager.AddMethod().
26004 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
26005 the MethodBuilder and the Method in a PtrHashtable.
26006 (TypeManager.builder_to_method): Added for this purpose.
26007 (TypeManager.MethodFlags): Added IsObsoleteError.
26008 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
26009 Obsolete and Conditional arguments in MethodBuilders. If we discover
26010 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
26011 the message from the attribute.
26013 2002-07-24 Martin Baulig <martin@gnome.org>
26015 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
26016 preprocessor directives, ensure that the argument to #define/#undef is
26017 exactly one identifier and that it's actually an identifier.
26019 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
26022 2002-07-24 Martin Baulig <martin@gnome.org>
26024 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
26025 initialize it to TypeManager.object_type in the constructor.
26026 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
26027 of the `hm.get_current' method if we're using the collection pattern.
26028 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
26029 for the explicit conversion to make it work when we're using the collection
26030 pattern and the `Current' property has a different return type than `object'.
26033 2002-07-24 Martin Baulig <martin@gnome.org>
26035 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
26036 does not match, but don't report any errors. This method is called in
26037 order for all methods in a MethodGroupExpr until a matching method is
26038 found, so we don't want to bail out if the first method doesn't match.
26039 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
26040 matches, report the 123. Fixes #28070.
26042 2002-07-24 Martin Baulig <martin@gnome.org>
26044 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
26045 TypeManager.TypeToCoreType() to the top of the method so the
26046 following equality checks will work. Fixes #28107.
26048 2002-07-24 Martin Baulig <martin@gnome.org>
26050 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
26051 operand is of type uint, and the other operand is of type sbyte,
26052 short or int, the operands are converted to type long." -
26053 Actually do what this comment already told us. Fixes bug #28106,
26056 2002-07-24 Martin Baulig <martin@gnome.org>
26058 * class.cs (MethodBase): New abstract class. This is now a base
26059 class for Property, Indexer and Event to avoid some code duplication
26060 in their Define() and DefineMethods() methods.
26061 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
26062 generic methods for Define() and DefineMethods().
26063 (FieldBase): Derive from MemberBase, not MemberCore.
26064 (Property): Derive from MemberBase, not MemberCore.
26065 (Property.DefineMethod): Moved all the code from this method to the
26066 new MethodBase.DefineAccessor(), just call it with appropriate
26068 (Property.Define): Call the new Property.DoDefine(), this does some
26069 sanity checks and we don't need to duplicate the code everywhere.
26070 (Event): Derive from MemberBase, not MemberCore.
26071 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
26072 accessors, this will also make them work with interface events.
26073 (Indexer): Derive from MemberBase, not MemberCore.
26074 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
26075 (Indexer.Define): Use the new MethodBase functions.
26077 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
26078 argument to the constructor.
26079 (Interface.FindMembers): Added support for interface events.
26080 (Interface.PopluateEvent): Implemented.
26082 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
26084 2002-07-22 Miguel de Icaza <miguel@ximian.com>
26086 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
26087 but this is required to check for a method name being the same as
26088 the containing class.
26092 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26094 * interface.cs: initialize variable.
26096 2002-07-23 Martin Baulig <martin@gnome.org>
26098 Implemented the IndexerName attribute in interfaces.
26100 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
26101 name if this is an explicit interface implementation.
26102 (Indexer.InterfaceIndexerName): New public variable. If we're
26103 implementing an interface indexer, this is the IndexerName in that
26104 interface. Otherwise, it's the IndexerName.
26105 (Indexer.DefineMethod): If we're implementing interface indexer,
26106 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
26107 and Pending.ImplementIndexer methods.
26108 (Indexer.Define): Also define the PropertyBuilder if we're
26109 implementing an interface indexer and this is neither an explicit
26110 interface implementation nor do the IndexerName match the one in
26113 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
26114 If a method is defined here, then we always need to create a proxy
26115 for it. This is used when implementing interface indexers.
26116 (Pending.IsInterfaceIndexer): New public method.
26117 (Pending.ImplementIndexer): New public method.
26118 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
26119 This is used when implementing interface indexers to define a proxy
26121 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
26122 define a proxy if necessary.
26124 * interface.cs (Interface.IndexerName): New public variable.
26125 (Interface.PopulateIndexer): Set the IndexerName.
26126 (Interface.DefineIndexers): New private method. Populate all the
26127 indexers and make sure their IndexerNames match.
26129 * typemanager.cs (IndexerPropertyName): Added support for interface
26132 2002-07-22 Martin Baulig <martin@gnome.org>
26134 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
26135 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
26136 ret if HasReturnLabel.
26137 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
26140 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
26141 and set the ec.LoopBeginTryCatchLevel.
26142 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
26143 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
26144 the current ec.TryCatchLevel, the branch goes out of an exception
26145 block. In this case, we need to use Leave and not Br.
26147 2002-07-22 Martin Baulig <martin@gnome.org>
26149 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
26150 block unless the block does not always return or it is contained in
26151 another try { ... } catch { ... } block. Fixes bug #26506.
26152 Added verify-1.cs to the test suite.
26154 2002-07-22 Martin Baulig <martin@gnome.org>
26156 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
26157 then we do not always return. Fixes bug #24985.
26159 2002-07-22 Martin Baulig <martin@gnome.org>
26161 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
26162 lookup on a per-class level; ie. walk up the class hierarchy until we
26163 found at least one applicable method, then choose the best among them.
26164 Fixes bug #24463 and test-29.cs.
26166 2002-07-22 Martin Baulig <martin@gnome.org>
26168 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
26169 return types of the methods. The return type is not part of the
26170 signature and we must not check it to make the `new' modifier work.
26171 Fixes bug #27999, also added test-147.cs.
26172 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
26174 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
26175 on the method's return type.
26177 2002-07-21 Martin Baulig <martin@gnome.org>
26179 * assign.cs: Make this work if the rightmost source is a constant and
26180 we need to do an implicit type conversion. Also adding a few more tests
26181 to test-38.cs which should have caught this.
26183 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
26184 target in the makefile for this. The makefile.gnu is primarily intended
26185 for end-users who don't want to debug the compiler.
26187 2002-07-21 Martin Baulig <martin@gnome.org>
26189 * assign.cs: Improved the Assign class so it can now handle embedded
26190 assignments (X = Y = Z = something). As a side-effect this'll now also
26191 consume less local variables. test-38.cs now passes with MCS, added
26192 a few new test cases to that test.
26194 2002-07-20 Martin Baulig <martin@gnome.org>
26196 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
26197 instructions. Fixes bug #27977, also added test-146.cs.
26199 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26201 * cs-tokenizer.cs: fixed getHex ().
26203 2002-07-19 Martin Baulig <martin@gnome.org>
26205 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
26206 not Type.GetType() to lookup the array type. This is needed when
26207 we're constructing an array of a user-defined type.
26208 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
26209 single-dimensional arrays, but also for single-dimensial arrays of
26212 2002-07-19 Martin Baulig <martin@gnome.org>
26214 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26215 this function is called, it's not allowed to share LocalBuilders
26216 among ILGenerators.
26218 2002-07-19 Martin Baulig <martin@gnome.org>
26220 * expression.cs (Argument.Resolve): Report an error 118 when trying
26221 to pass a type as argument.
26223 2002-07-18 Martin Baulig <martin@gnome.org>
26225 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26226 Conv_R_Un for the signed `long' type.
26228 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26230 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26231 `expr' for the temporary result, as that will fail if we do
26232 multiple resolves on the same expression.
26234 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26236 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26237 ec.TypeContainer for looking up aliases.
26239 * class.cs (TypeContainer): Remove LookupAlias from here.
26241 * decl.cs (DeclSpace); Move here.
26243 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26245 * class.cs (FindMembers): Only call filter if the constructor
26246 bulider is not null.
26248 Also handle delegates in `NestedTypes' now. Now we will perform
26249 type lookups using the standard resolution process. This also
26252 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26253 This uses Expressions (the limited kind that can be parsed by the
26254 tree) instead of strings.
26256 * expression.cs (ComposedCast.ToString): Implement, used to flag
26257 errors since now we have to render expressions.
26259 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26262 * ecore.cs (SimpleName.ToString): ditto.
26264 * cs-parser.jay: Instead of using strings to assemble types, use
26265 Expressions to assemble the type (using SimpleName, ComposedCast,
26266 MemberAccess). This should fix the type lookups in declarations,
26267 because we were using a different code path for this.
26269 * statement.cs (Block.Resolve): Continue processing statements
26270 even when there is an error.
26272 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26274 * class.cs (Event.Define): Also remove the `remove' method from
26275 the list of pending items.
26277 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26278 generate more compact code.
26280 2002-07-17 Martin Baulig <martin@gnome.org>
26282 * const.cs (Const.LookupConstantValue): Add support for constant
26283 `unchecked' and `checked' expressions.
26284 Also adding test case test-140.cs for this.
26286 2002-07-17 Martin Baulig <martin@gnome.org>
26288 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26289 check whether mi.ReturnType implements the IEnumerator interface; the
26290 `==' and the IsAssignableFrom() will fail in this situation.
26292 2002-07-16 Ravi Pratap <ravi@ximian.com>
26294 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26297 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26299 * expression.cs: fixed bug #27811.
26301 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26303 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26304 Molaro: when we are a ref, the value already contains a pointer
26305 value, do not take the address of it.
26307 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26308 * removed mb-parser.jay and mb-tokenizer.cs
26310 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26312 * expression.cs: check against the building corlib void type.
26314 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26316 * ecore.cs: fix for valuetype static readonly fields: when
26317 initializing them, we need their address, not the address of a copy.
26319 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26321 * typemanager.cs: register also enum_type in corlib.
26323 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26325 * class.cs: allow calling this (but not base) initializers in structs.
26327 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26329 * ecore.cs: make sure we compare against the building base types
26332 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26334 * typemanager.cs: fix TypeToCoreType() to handle void and object
26335 (corlib gets no more typerefs after this change).
26337 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26339 * expression.cs (ArrayCreation.EmitArrayArguments): use
26340 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26342 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26343 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26344 array indexes, the runtime actually forbids them.
26346 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26347 for array arguments here.
26349 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26350 instead of the default for ValueTypes.
26352 (New.DoEmit): Use IsValueType instead of
26353 IsSubclassOf (value_type)
26354 (New.DoResolve): ditto.
26355 (Invocation.EmitCall): ditto.
26357 * assign.cs (Assign): ditto.
26359 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26360 Statements *are* currently doing part of their resolution during
26363 Expressions do always resolve during resolve, but statements are
26364 only required to propagate resolution to their children.
26366 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26368 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26370 (LoadAssembly): Do not add the dll if it is already specified
26372 (MainDriver): Add the System directory to the link path at the end,
26373 after all the other -L arguments.
26375 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26376 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26377 ldelem.u1) and using the opposite for sbytes.
26379 This fixes Digger, and we can finally run it.
26381 * driver.cs (UnixParseOption): Move the option parsing here.
26382 (CSCParseOption): Implement CSC-like parsing of options.
26384 We now support both modes of operation, the old Unix way, and the
26385 new CSC-like way. This should help those who wanted to make cross
26386 platform makefiles.
26388 The only thing broken is that /r:, /reference: and /lib: are not
26389 implemented, because I want to make those have the same semantics
26390 as the CSC compiler has, and kill once and for all the confussion
26391 around this. Will be doing this tomorrow.
26393 * statement.cs (Unsafe.Resolve): The state is checked during
26394 resolve, not emit, so we have to set the flags for IsUnsfe here.
26396 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26398 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26399 not catch the Error_ObjectRefRequired in SimpleName (as it is
26400 possible to have a class/instance variable name that later gets
26401 deambiguated), we have to check this here.
26403 2002-07-10 Ravi Pratap <ravi@ximian.com>
26405 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26406 make static and put into Expression.
26408 (Event.Define): Register the private field of the event with the
26409 TypeManager so that GetFieldFromEvent can get at it.
26411 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26412 keep track of the private field associated with an event which
26415 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26418 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26420 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26422 * expression.cs (Binary.EmitBranchable): this routine emits the
26423 Binary expression in a branchable context. This basically means:
26424 we need to branch somewhere, not just get the value on the stack.
26426 This works together with Statement.EmitBoolExpression.
26428 * statement.cs (Statement.EmitBoolExpression): Use
26431 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26433 * statement.cs (For): Reduce the number of jumps in loops.
26435 (For): Implement loop inversion for the For statement.
26437 (Break): We can be breaking out of a Try/Catch controlled section
26438 (foreach might have an implicit try/catch clause), so we need to
26439 use Leave instead of Br.
26441 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26442 now). If the instace expression supports IMemoryLocation, we use
26443 the AddressOf method from the IMemoryLocation to extract the
26444 address instead of emitting the instance.
26446 This showed up with `This', as we were emitting the instance
26447 always (Emit) instead of the Address of This. Particularly
26448 interesting when This is a value type, as we dont want the Emit
26449 effect (which was to load the object).
26451 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26453 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26455 * statement.cs (Checked): Set the CheckedState during the resolve
26456 process too, as the ConvCast operations track the checked state on
26457 the resolve process, and not emit.
26459 * cs-parser.jay (namespace_member_declaration): Flag that we have
26460 found a declaration when we do. This is used to flag error 1529
26462 * driver.cs: Report ok when we display the help only.
26464 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26466 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26468 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26470 * cs-tokenizer.cs (define): We also have to track locally the
26471 defines. AllDefines is just used for the Conditional Attribute,
26472 but we also need the local defines for the current source code.
26474 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26476 * statement.cs (While, For, Do): These loops can exit through a
26477 Break statement, use this information to tell whether the
26478 statement is the last piece of code.
26480 (Break): Flag that we break.
26482 * codegen.cs (EmitContexts): New `Breaks' state variable.
26484 2002-07-03 Martin Baulig <martin@gnome.org>
26486 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26487 modifiers in method declarations in structs. Otherwise, you won't
26488 be able to override things like Object.Equals().
26490 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26492 * class.cs (Method, Property, Indexer): Do not allow the public
26493 modifier to be used in explicit interface implementations.
26495 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26496 override modifiers in method declarations in structs
26498 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26500 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26501 integer or real overflow, report an error
26503 2002-07-02 Martin Baulig <martin@gnome.org>
26505 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26506 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26507 to tell the runtime about our newly created System.Object and
26508 System.ValueType types.
26510 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26512 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26513 struct instead of Ldarg/Starg.
26515 2002-07-02 Martin Baulig <martin@gnome.org>
26517 * expression.cs (Indirection.Indirection): Call
26518 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26520 2002-07-02 Martin Baulig <martin@gnome.org>
26522 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26523 ValueType, call TypeManager.TypeToCoreType() on it.
26524 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26525 the OpCodes.Newarr argument.
26527 2002-07-02 Martin Baulig <martin@gnome.org>
26529 * expression.cs (Invocation.EmitCall): When compiling corlib,
26530 replace all calls to the system's System.Array type to calls to
26531 the newly created one.
26533 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26534 System.Array methods.
26535 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26536 from the system's System.Array type which must be replaced.
26538 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26540 * typemanager.cs: load unverifiable_code_ctor so we can build
26541 corlib using the correct type. Avoid using GetTypeCode() with
26543 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26544 TypeManager.object_type to allow building corlib.
26546 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26548 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26550 2002-07-01 Martin Baulig <martin@gnome.org>
26552 * class.cs: Make the last change actually work, we need to check
26553 whether `ifaces != null' to avoid a crash.
26555 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26557 * class.cs: when we build structs without fields that implement
26558 interfaces, we need to add the interfaces separately, since there is
26559 no API to both set the size and add the interfaces at type creation
26562 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26564 * expression.cs: the dimension arguments to the array constructors
26565 need to be converted if they are a long.
26567 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26569 * class.cs: don't emit ldarg.0 if there is no parent constructor
26570 (fixes showstopper for corlib).
26572 2002-06-29 Martin Baulig <martin@gnome.org>
26574 MCS now compiles corlib on GNU/Linux :-)
26576 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26577 ie. check for MethodImplOptions.InternalCall.
26579 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26580 and TypeManager.attribute_type are null, so we must explicitly check
26581 whether parent is not null to find out whether it's an attribute type.
26582 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26583 and SetBuilder, not only if the property is neither abstract nor external.
26584 This is necessary to set the MethodImplOptions on the accessor methods.
26585 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26586 SetBuilder, see Property.Emit().
26588 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26589 populate "System.Object", "System.ValueType" and "System.Attribute" since
26590 they've already been populated from BootCorlib_PopulateCoreTypes().
26592 2002-06-29 Martin Baulig <martin@gnome.org>
26594 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26595 is the NullLiteral, we also need to make sure that target_type is not
26598 2002-06-29 Martin Baulig <martin@gnome.org>
26600 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26601 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26602 before calling BootstrapCorlib_ResolveDelegate ().
26604 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26606 * statement.cs: fixed build-breaker. All tests passed ok.
26608 2002-06-27 Martin Baulig <martin@gnome.org>
26610 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26611 for System.Decimal when compiling corlib.
26613 2002-06-27 Martin Baulig <martin@gnome.org>
26615 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26616 switch blocks which contain nothing but a default clause.
26618 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26620 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26622 2002-06-27 Martin Baulig <martin@gnome.org>
26624 * ecore.cs (PropertyExpr.PropertyExpr): Call
26625 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26627 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26628 is already a TypeBuilder.
26630 2002-06-27 Martin Baulig <martin@gnome.org>
26632 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26633 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26634 the "from an array-type to System.Array" case. This makes it work
26635 when compiling corlib.
26637 2002-06-27 Martin Baulig <martin@gnome.org>
26639 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26640 non-static PropertyExpr, set its InstanceExpression. This makes
26641 the `ICollection.Count' property work in System/Array.cs.
26643 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26645 * driver.cs: Made error handling more consistent. Errors now
26646 tracked by Report class, so many methods which used to return int
26647 now return void. Main() now prints success/failure and
26648 errors/warnings message.
26650 Renamed '--probe' compiler argument to '--expect-error'. Removed
26651 the magic number return values (123 and 124). Now, if the
26652 expected error occurs, the compiler exits with success (exit value
26653 0). If the compilation completes without seeing that particular
26654 error, the compiler exits with failure (exit value 1). The
26655 makefile in mcs/errors has been changed to handle the new behaviour.
26657 * report.cs: Made 'expected error' number a property and renamed
26658 it from 'Probe' to 'ExpectedError'.
26660 * genericparser.cs: Removed error handling support, since it is
26661 now all done by Report class.
26663 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26664 class, so parse() no longer returns an int.
26666 * namespace.cs: Use Report.Error instead of GenericParser.error
26668 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26670 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26671 TypeContainer.AddOperator): At the front of the list put the
26672 explicit implementations, so they get resolved/defined first.
26674 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26676 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26677 interface type is implemented by this TypeContainer. Used during
26678 explicit interface implementation.
26680 (Property.Define, Indexer.Define, Method.Define): Validate that
26681 the given interface in the explicit implementation is one of the
26682 base classes for the containing type.
26684 Also if we are explicitly implementing an interface, but there is
26685 no match in the pending implementation table, report an error.
26687 (Property.Define): Only define the property if we are
26688 not explicitly implementing a property from an interface. Use the
26689 correct name also for those properties (the same CSC uses,
26690 although that is really not needed).
26692 (Property.Emit): Do not emit attributes for explicitly implemented
26693 properties, as there is no TypeBuilder.
26695 (Indexer.Emit): ditto.
26697 Hiding then means that we do not really *implement* a pending
26698 implementation, which makes code fail.
26700 2002-06-22 Martin Baulig <martin@gnome.org>
26702 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26703 the return value of Object.GetType(). [FIXME: we need to do this whenever
26704 we get a type back from the reflection library].
26706 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26708 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26710 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26712 * attribute.cs: Return null if we can not look up the type.
26714 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26715 the interface types found.
26717 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26718 interface types found.
26720 * typemanager.cs (GetInterfaces): Make this routine returns alll
26721 the interfaces and work around the lame differences between
26722 System.Type and System.Reflection.Emit.TypeBuilder in the results
26723 result for GetInterfaces.
26725 (ExpandInterfaces): Given an array of interface types, expand and
26726 eliminate repeated ocurrences of an interface. This expands in
26727 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26730 2002-06-21 Martin Baulig <martin@gnome.org>
26732 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26735 2002-06-21 Martin Baulig <martin@gnome.org>
26737 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26738 and called with one of the core types, return the corresponding typebuilder for
26741 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26744 2002-06-21 Martin Baulig <martin@gnome.org>
26746 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26747 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26748 (Expression.ConvertReferenceExplicit): Likewise.
26750 * expression.cs (ElementAccess.DoResolve): Likewise.
26751 (ElementAccess.DoResolveLValue): Likewise.
26753 2002-06-10 Martin Baulig <martin@gnome.org>
26755 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26756 add the "value" parameter to the parameter list.
26758 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26761 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26763 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26764 the argument to an int, uint, long or ulong, per the spec. Also
26765 catch negative constants in array creation.
26767 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26769 * class.cs: do not allow the same interface to appear twice in
26770 the definition list.
26772 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26774 * ecore.cs: don't use ldlen with System.Array.
26776 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26778 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26780 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26782 * modifiers.cs: produce correct field attributes for protected
26783 internal. Easy fix so miguel can work on ther harder stuff:-)
26785 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26787 * pending.cs: New file. Move the code from class.cs here.
26788 Support clearning the pending flag for all methods (when not doing
26789 explicit interface implementation).
26791 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26793 * rootcontext.cs: added a couple more types needed to bootstrap.
26795 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26797 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26798 constructor in the type, instead of any constructor in the type
26799 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26800 a bug in the Mono runtime when applying the params attribute).
26802 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26803 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26805 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26807 * expression.cs (Unary.ResolveOperator): Use TypeManager
26808 to resolve the type.
26810 2002-06-13 Ravi Pratap <ravi@ximian.com>
26812 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26815 * enum.cs (AddEnumMember): Add support to store the attributes associated
26816 with each member too.
26818 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26819 field builders too - this takes care of the enum member case.
26821 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26823 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26824 address-of operator on both value types and pointers.
26826 2002-06-10 Martin Baulig <martin@gnome.org>
26828 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26829 PropertyBuilder to the `property_builders' list.
26831 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26832 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26833 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26834 find any indexers which are inherited from an interface.
26836 2002-06-09 Martin Baulig <martin@gnome.org>
26838 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26839 the same type as the constant if necessary. There's also a test-130.cs
26842 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26844 * typemanager.cs (TypeManager.ChangeType): Previously known as
26845 Enum.ChangeEnumType().
26847 2002-06-09 Martin Baulig <martin@gnome.org>
26849 * expression.cs (Cast.TryReduce): Added support for consts.
26851 2002-06-08 Ravi Pratap <ravi@ximian.com>
26853 * class.cs (Accessor): Hold attributes information so we can pass
26856 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26857 Modify to pass in attributes attached to the methods.
26859 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26861 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26862 to handle the Accessor kind :-)
26864 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26866 2002-06-08 Martin Baulig <martin@gnome.org>
26868 * expression.cs (Unary.TryReduceNegative): Added support for
26871 2002-06-08 Martin Baulig <martin@gnome.org>
26873 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26874 name can't be found in the `defined_names' - the caller will do a
26875 MemberLookup in this case and thus find methods in System.Enum
26876 such as Enum.IsDefined().
26878 2002-06-08 Martin Baulig <martin@gnome.org>
26880 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26881 Convert.ChangeType() which works with TypeBuilder created types.
26882 (Enum.LookupEnumValue, Enum.Define): Use it here.
26884 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26885 `TypeBuilder.BaseType != null' check.
26886 (TypeContainer.FindMembers): Only lookup parent members if we
26887 actually have a parent.
26888 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26889 (ConstructorInitializer.Resolve): Likewise.
26891 * interface.cs (Interface.FindMembers): Added
26892 `TypeBuilder.BaseType != null' check.
26894 * rootcontext.cs (RootContext.ResolveCore): Added
26895 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26896 classes_second_stage.
26898 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26899 debug_type and trace_type when compiling with --nostdlib.
26901 2002-06-07 Martin Baulig <martin@gnome.org>
26903 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26904 (AddField): Set it to true when adding a non-static field.
26905 (DefineType): Use `have_nonstatic_fields' to find out whether we
26906 have non-static fields, not `Fields != null'.
26908 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26910 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26911 dereferencing a null on the static-field code path)
26913 2002-05-30 Martin Baulig <martin@gnome.org>
26915 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26916 to take command line arguments. Use reflection to call the new
26917 custom `Initialize' function on the symbol writer and pass it the
26918 command line arguments.
26920 * driver.cs (--debug-args): New command line argument to pass command
26921 line arguments to the symbol writer.
26923 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26925 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26926 the target type for indexers and properties. Thanks to Joe for
26929 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26931 * typemanager.cs (MethodFlags): returns the method flags
26932 (Obsolete/ShouldIgnore) that control warning emission and whether
26933 the invocation should be made, or ignored.
26935 * expression.cs (Invocation.Emit): Remove previous hack, we should
26936 not do this on matching a base type, we should do this based on an attribute
26938 Only emit calls to System.Diagnostics.Debug and
26939 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26940 on the command line.
26942 * rootcontext.cs: Global settings for tracing and debugging.
26944 * cs-tokenizer.cs (define): New utility function to track
26945 defines. Set the global settings for TRACE and DEBUG if found.
26947 2002-05-25 Ravi Pratap <ravi@ximian.com>
26949 * interface.cs (Populate*): Pass in the TypeContainer as well as
26950 the DeclSpace as parameters so that we can create EmitContexts and
26951 then use that to apply attributes etc.
26953 (PopulateMethod, PopulateEvent, PopulateProperty)
26954 (PopulateIndexer): Apply attributes everywhere.
26956 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26959 (ApplyAttributes): Update accordingly.
26961 We now apply interface attributes for all members too.
26963 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26965 * class.cs (Indexer.Define); Correctly check if we are explicit
26966 implementation (instead of checking the Name for a ".", we
26967 directly look up if the InterfaceType was specified).
26969 Delay the creation of the PropertyBuilder.
26971 Only create the PropertyBuilder if we are not an explicit
26972 interface implementation. This means that explicit interface
26973 implementation members do not participate in regular function
26974 lookups, and hence fixes another major ambiguity problem in
26975 overload resolution (that was the visible effect).
26977 (DefineMethod): Return whether we are doing an interface
26980 * typemanager.cs: Temporary hack until we get attributes in
26981 interfaces (Ravi is working on that) and we get IndexerName
26982 support in interfaces.
26984 * interface.cs: Register the indexers as properties.
26986 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26987 warning, I have verified that this is a bug in the .NET runtime
26988 (JavaScript suffers of the same problem).
26990 * typemanager.cs (MemberLookup): When looking up members for
26991 interfaces, the parent of an interface is the implicit
26992 System.Object (so we succeed in searches of Object methods in an
26993 interface method invocation. Example: IEnumerable x; x.ToString
26996 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26998 * class.cs (Event): Events should also register if they do
26999 implement the methods that an interface requires.
27001 * typemanager.cs (MemberLookup); use the new GetInterfaces
27004 (GetInterfaces): The code used to lookup interfaces for a type is
27005 used in more than one place, factor it here.
27007 * driver.cs: Track the errors at the bottom of the file, we kept
27010 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
27011 instance if the method we are calling is static!
27013 2002-05-24 Miguel de Icaza <miguel@ximian.com>
27015 * attribute.cs (ApplyAttributes): Make this function filter out
27016 the IndexerName attribute (as that attribute in reality is never
27017 applied) and return the string constant for the IndexerName
27020 * class.cs (TypeContainer.Emit): Validate that all the indexers
27021 have the same IndexerName attribute, and if so, set the
27022 DefaultName attribute on the class.
27024 * typemanager.cs: The return value might contain other stuff (not
27025 only methods). For instance, consider a method with an "Item"
27026 property and an Item method.
27028 * class.cs: If there is a problem with the parameter types,
27031 2002-05-24 Ravi Pratap <ravi@ximian.com>
27033 * ecore.cs (ImplicitConversionExists): Wrapper function which also
27034 looks at user defined conversion after making a call to
27035 StandardConversionExists - we need this for overload resolution.
27037 * expression.cs : Update accordingly the various method calls.
27039 This fixes 2 bugs filed against implicit user defined conversions
27041 2002-05-22 Miguel de Icaza <miguel@ximian.com>
27043 * statement.cs: Track the result of the assignment.
27045 2002-05-21 Miguel de Icaza <miguel@ximian.com>
27047 * expression.cs (MemberAccess): Improved error reporting for
27048 inaccessible members.
27050 2002-05-22 Martin Baulig <martin@gnome.org>
27052 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
27053 itself with debugging support.
27055 2002-05-22 Martin Baulig <martin@gnome.org>
27057 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
27058 Removed, this isn't needed anymore.
27060 2002-05-20 Martin Baulig <martin@gnome.org>
27062 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
27063 be underlying type for an enum.
27065 2002-05-20 Miguel de Icaza <miguel@ximian.com>
27067 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
27068 that splits out the loading of just the core types.
27070 * rootcontext.cs (ResolveCore): Split the struct resolution in
27071 two, so we can load the enumeration underlying types before any
27074 * expression.cs (Is): Bandaid until we fix properly Switch (see
27075 bug #24985 for details).
27077 * typemanager.cs (ImplementsInterface): The hashtable will contain
27078 a null if there are no interfaces implemented.
27080 2002-05-18 Miguel de Icaza <miguel@ximian.com>
27082 * cs-parser.jay (indexer_declarator): It is fine to have array
27085 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27087 * typemanager.cs: (RegisterBuilder): New function used to register
27088 TypeBuilders that implement interfaces. Since
27089 TypeBuilder.GetInterfaces (as usual) does not work with lame
27091 (AddUserType): register interfaces.
27093 (ImplementsInterface): Use the builder_to_ifaces hash if we are
27094 dealing with TypeBuilder. Also, arrays are showing up as
27095 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
27096 methods can not be invoked on them!
27098 * ecore.cs (ExplicitReferenceConversionExists): Made public.
27099 (ImplicitReferenceConversionExists): Split out from
27100 StandardConversionExists.
27102 * expression.cs (As): We were only implementing one of the three
27103 cases for the as operator. We now implement them all.
27104 (Is): Implement the various other cases for Is as well.
27106 * typemanager.cs (CACHE): New define used to control if we want or
27107 not the FindMembers cache. Seems to have a negative impact on
27108 performance currently
27110 (MemberLookup): Nested types have full acess to
27111 enclosing type members
27113 Remove code that coped with instance/static returns for events, we
27114 now catch this in RealFindMembers.
27116 (RealFindMembers): only perform static lookup if the instance
27117 lookup did not return a type or an event.
27119 2002-05-17 Miguel de Icaza <miguel@ximian.com>
27121 * assign.cs (CompoundAssign): We pass more semantic information
27122 now to Compound Assignments than we did before: now we have all
27123 the information at hand, and now we resolve the target *before* we
27124 do the expression expansion, which allows the "CacheValue" method
27125 to have the effect we intended (before, a [x] += 1 would generate
27126 two differen ArrayAccess expressions from the ElementAccess,
27127 during the resolution process).
27129 (CompoundAssign.DoResolve): Resolve target and original_source here.
27131 2002-05-16 Miguel de Icaza <miguel@ximian.com>
27133 * expression.cs (ArrayAccess): dropped debugging information.
27135 * typemanager.cs: Small bug fix: I was always returning i_members,
27136 instead of one of i_members or s_members (depending on which had
27139 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
27140 method is invoked before any code generation takes place, and it
27141 is a mechanism to inform that the expression will be invoked more
27142 than once, and that the method should use temporary values to
27143 avoid having side effects
27145 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
27147 * ecore.cs (Expression.CacheTemporaries): Provide empty default
27150 * expression.cs (Indirection, ArrayAccess): Add support for
27151 CacheTemporaries in these two bad boys.
27153 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
27154 ldobj or ldind_ref.
27155 (StoreFromPtr): Handle stobj as well.
27157 * expression.cs (UnaryMutator): Share more code.
27159 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
27160 down: I was not tracking the Filter function as well, which
27161 was affecting the results of the cache.
27163 2002-05-15 Miguel de Icaza <miguel@ximian.com>
27165 * attribute.cs: Remove the hack to handle the CharSet property on
27168 2002-05-14 Miguel de Icaza <miguel@ximian.com>
27170 * attribute.cs (DoResolve): More uglyness, we now only try to
27171 resolve the attribute partially, to extract the CharSet
27172 information (only if we are a StructLayout attribute). Otherwise
27174 (GetExtraTypeInfo): Add some code to conditionally kill in the
27175 future this. I am more and more convinced that the .NET
27176 framework has special code to handle the attribute setting on
27179 * expression.cs (IsParamsMethodApplicable): Revert my previous
27180 foreach change here, it was wrong.
27182 2002-05-13 Miguel de Icaza <miguel@ximian.com>
27184 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
27185 (pp_expr): do not abort on unknown input, just return.
27186 (eval): abort if there are pending chars.
27188 * attribute.cs (Attribute.Resolve): Positional parameters are
27189 optional. Deal with that case.
27191 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
27192 the Ansi/Unicode/Auto information for the type.
27194 (TypeContainer.DefineType): instantiate the EmitContext here, as
27195 we will be using it during the type definition (to resolve
27196 attributes) and during the emit phase.
27198 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
27199 to pull type information out of the attributes
27201 (Attribute.Resolve): track the constructor builder, and allow for
27202 multiple invocations (structs and classes will use this).
27204 * ecore.cs (MemberLookupFinal): new version with all the
27205 parameters customizable.
27207 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
27208 constructors. Return if the result value is null (as the error
27209 would have been flagged already by MemberLookupFinal)
27211 Do not allow instances of abstract classes or interfaces to be
27214 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27215 We have to compare the assembly property here when dealing with
27216 FamANDAssem and Assembly access modifiers, because we might be
27217 creating an assembly from *modules* (that means that we are not
27218 getting TypeBuilders for types defined in other modules that are
27219 part of this assembly).
27221 (Method.Emit): If the method is marked abstract and has a body,
27224 (TypeContainer.DefineMembers): If both the defined member and the
27225 parent name match are methods, then do not emit any warnings: let
27226 the Method.Define routine take care of flagging warnings. But if
27227 there is a mismatch (method overrides something else, or method is
27228 overriwritten by something, then emit warning).
27230 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27231 set to null, this means `do not check for the return type on the
27234 (Method.Define): set the return type for the method signature to
27235 null, so that we get methods with the same name and parameters and
27236 different return types. This is used to flag warning 114 (you are
27237 hiding a method, and you probably want to use the new/override
27240 * typemanager.cs (MemberLookup): Implemented proper access
27241 control, closing a long standing set of bug reports. The problem
27242 was that the Framework only has two bits: Public and NonPublic,
27243 and NonPublic includes private and protected methods, but we need
27244 to enforce the FamANDAssem, FamOrAssem and Family.
27246 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27248 * statement.cs (GotoCase): Return true: Ammounts to giving up
27249 knowledge on whether we return or not, and letting the other case
27250 be responsible for it.
27252 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27254 * driver.cs: Do not load directories for each file processed, only
27255 do it if there is a pattern.
27257 * ecore.cs: Report readonly assigns here as well, as we might have
27258 been resolved only by MemberAccess.
27260 (SimpleName.SimpleNameResolve): Also be useful for LValue
27261 resolution. We need this to propagate assign to local readonly variables
27263 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27264 do not want to reuse potential criteria memory.
27266 * class.cs (MyEventBuilder): Set reflected_type;
27268 * ecore.cs (Constantify): Added support for constifying bools.
27270 (RootContext.LookupType): Added a cache for values looked up in
27271 the declaration space.
27273 * typemanager.cs (FindMembers): Now is a front-end to
27274 RealFindMembers, and provides a two-level hashtable-based cache to
27277 15% performance improvement: from 22.5 to 19.2 seconds.
27279 * expression.cs (IsParamsMethodApplicable): use foreach.
27280 (Invocation.DoResolve): ditto.
27281 (New.DoResolve): ditto.
27282 (ArrayCreation.DoResolve): ditto.
27284 * ecore.cs (FindMostEncompassingType): use foreach.
27286 * delegate.cs (NewDelegate.DoResolve): Use foreach
27288 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27289 (RemoveMethods): use foreach.
27291 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27292 nested foreach statements instead of for, and also break out of
27293 the inner loop once a match is found.
27295 (Invocation.OverloadResolve): Use foreach, simplify the code.
27297 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27299 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27300 we actually unwrap the expression to allow for extra information
27303 * expression.cs: Use Shr_Un on unsigned operations.
27305 2002-05-08 Ravi Pratap <ravi@ximian.com>
27307 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27308 applicable operators was not being considered correctly. This closes
27309 the bug Miguel reported.
27311 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27313 * attribute.cs: check that the type derives from System.Attribute
27314 and report the correct error in that case (moved the duplicate code to
27315 its own method, too).
27317 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27319 * attribute.cs: lookup attribute type name as the spec says: first the
27320 bare attribute name and then name + "Attribute" (nant compiles with
27321 mcs after this fix).
27323 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27325 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27326 Because of the way we parse things, we should try to see if a
27327 UIntConstant can fit in an integer.
27329 2002-05-07 Ravi Pratap <ravi@ximian.com>
27331 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27332 when we are in an explicit context.
27334 (ConvertReferenceExplicit): When converting from Iface type S to Class
27335 T make sure the rules are implemented as an OR.
27337 * parameter.cs (ParameterType): Make it a property for now although the
27338 purpose really isn't anything immediate.
27340 * expression.cs (Is*Applicable): Do better checking on the parameter type
27341 of a ref/out parameter. The ones from the system assemblies are already
27342 marked with the correct type so we don't need to do any correction.
27344 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27345 the object type is standard too so include that.
27347 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27349 * ecore.cs (StandardConversionExists): Augment with missing code:
27350 deal with IntConstant, LongConstants and Enumerations.
27352 * assign.cs: Report the error, instead of failing silently
27354 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27355 typecontainer that they are declared, because the
27356 typecontainer/namespace will have the list of using clauses that
27357 need to be applied.
27359 Assembly Attributes were escaping the normal registration
27362 (EmitCode): Apply attributes within an EmitContext that represents
27363 the container they were declared on.
27365 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27367 2002-05-06 Ravi Pratap <ravi@ximian.com>
27369 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27370 Revamp completely - make much cleaner as we now operate only
27373 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27374 to implement the logic detailed in the spec more correctly.
27376 (UserDefinedConversion): Update accordingly.
27378 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27380 * statement.cs: Return flow analysis information up.
27382 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27385 (token): Do not consume an extra character before calling
27388 2002-05-06 Piers Haken <piersh@friskit.com>
27390 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27392 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27394 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27395 EmitContext during the instance constructor initializer
27396 resolution, to stop access to instance variables.
27398 This is mandated by the spec, last paragraph of the `constructor
27399 initializers' section.
27401 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27403 * cs-parser.jay, class.cs (Accessor): new class used to represent
27404 an accessor (get or set). In the past we used `null' to represent
27405 a missing accessor. But this is ambiguous because there was no
27406 way to tell in abstract indexers/properties if one of them was
27409 Now there is a way of addressing that.
27411 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27412 instead of FindMembers.
27414 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27415 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27417 * attribute.cs: Treat indexers and properties as the same in terms
27418 of applying attributes
27420 * ecore.cs (FindMostEncompassedType): Use statically initialized
27421 EmptyExpressions()s like we do elsewhere to avoid creating useless
27422 objects (and we take this out of the tight loop).
27424 (GetConversionOperators): Move the code to extract the actual
27425 operators to a separate routine to clean things up.
27427 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27429 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27430 events are always registered FieldBuilders.
27432 * class.cs (FieldBase): New class shared by Fields
27434 * delegate.cs: If we are a toplevel delegate, use our full name.
27435 If we are a nested delegate, then only use our tail name.
27437 2002-05-02 Ravi Pratap <ravi@ximian.com>
27439 * expression.cs (IsApplicable): Ensure that we add the "&" to
27440 ref/out types before comparing it with the type of the argument.
27442 (IsParamsMethodApplicable): Ditto.
27444 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27447 * delegate.cs : Handle the case when we have more than one applicable
27448 method. Flag an error only when we finish checking all.
27450 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27452 * expression.cs: Add support for boolean static initializers.
27454 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27456 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27458 * parameter.cs (ComputeParameterTypes,
27459 ComputeAndDefineParameterTypes): Better error handling: now we
27460 clear the `types' cache if we fail during any of the type lookups.
27461 We also return the status code correctly to our caller
27463 * delegate.cs: If we fail to define a delegate, abort the extra
27466 * expression.cs (Binary.ResolveOperator): for
27467 operator==(object,object) and operator !=(object, object) we also
27468 have to verify that there is an implicit conversion from one to
27471 (ArrayAccess.DoResolve): Array Access can operate on
27474 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27476 * assign.cs (CompoundAssign): A new class used as a "flag" that
27477 the assignment actually is happening as part of a compound
27478 assignment operator.
27480 During compound assignment, a few new rules exist to enable things
27487 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27488 to the type of x) if y is implicitly convertible to the type of x,
27489 and the operator is a builtin operator and the return type of the
27490 operator is explicitly convertible to the type of x.
27492 * rootcontext.cs: Reset warning level to 2. 4 catches various
27493 "interesting" features in mcs, we must clean this up at some
27494 point, but currently am trying to kill other bugs ;-)
27496 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27497 in container classes as well.
27499 * expression.cs (Binary.ResolveOperator): Handle string case
27500 before anything else (as operator overloading does emit an error
27501 before doing anything else).
27503 This code could go away when we move to a table driven model, but
27504 i could not come up with a good plan last night.
27506 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27508 * typemanager.cs (CSharpName): reimplementation using regex.
27509 * class.cs: added null check for fields in Emit
27510 * rootcontext.cs: set warninglevel to 4
27512 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27514 * typemanager.cs (CSharpName): reimplemented with Lupus
27517 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27519 * statement.cs (If): correclty implement Resolve, because we were
27520 not catching sem errors in there. The same process is needed
27522 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27525 (Statement.Warning_DeadCodeFound): Factorize code.
27526 (While): Report dead code here too.
27528 (Statement): Added Resolve virtual method to allow
27529 for resolution split from the emit code.
27531 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27533 * statement.cs (EmitBoolExpression): No longer try to resolve the
27535 (MakeBoolean): New utility function that resolve, implicitly
27536 converts to boolean and tags the expression.
27539 (If, Do): Implement dead code elimination.
27540 (While): Implement loop inversion
27542 (Do, While, For, If): Resolve the expression prior to calling our
27545 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27548 - added method Report28 (warning: program has more than one entry point)
27549 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27550 - modified method Method.Define, the part at the end of the method
27552 * rootcontext.cs: added static public Location EntryPointLocation;
27554 * ../errors/cs0028.cs : Add test case for the above warning.
27557 - modified method CSharpName to allow arrays of primitive type to
27558 be printed nicely (e.g. instead of System.Int32[][] it now prints
27560 - added method CSharpSignature: returns the signature of a method
27561 in string format to be used in reporting errors, warnings, etc.
27563 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27566 2002-04-26 Ravi Pratap <ravi@ximian.com>
27568 * delegate.cs (Define): Fix extremely silly bug where I was
27569 setting the type of the 'object' parameter of the BeginInvoke
27570 method to System.IAsyncResult instead of System.Object ;-)
27572 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27574 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27577 (Constructor.Emit): return if we fail to initialize the
27578 constructor. Another door closed!
27580 * expression.cs (New.DoResolve): Improve error message (from -6 to
27581 1501). Use DeclaredOnly lookup to find the exact constructor.
27583 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27584 loop. This is useful.
27586 * cs-parser.jay: Adjust the default parameters so that destructors
27587 have the proper signature.
27589 2002-04-26 Martin Baulig <martin@gnome.org>
27591 * driver.cs (LoadAssembly): If `assembly' contains any characters
27592 which are only valid in path names and not in assembly names
27593 (currently slash, backslash and point), use Assembly.LoadFrom ()
27594 instead of Assembly.Load () on the `assembly' (before iteration
27595 over the link_paths).
27597 2002-04-26 Martin Baulig <martin@gnome.org>
27599 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27601 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27603 * class.cs (Property): use the new typemanager.MemberLookup
27605 (TypeContainer.MemberLookup): Implement using the
27606 TypeManager.MemberLookup now.
27608 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27609 and return MemberInfos, so that these can be used without an
27610 EmitContext (what we had before).
27612 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27614 * expression.cs: Fix the case where the argument to params if the
27615 type of the params. I omitted handling this before. Fixed
27617 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27619 * driver.cs: Call BootCorlib_PopulateCoreType
27621 * class.cs (Property.CheckBase): Check for properties only, not
27624 * interface.cs: Temporary hack: try/catch around the
27625 CustomAttributeBuilder, because I am getting an exception that I
27628 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27629 types whose definitions are required to be there (attributes are
27630 defined before standard types).
27632 Compute definitions as we boot the various types, as they are used
27633 immediately (value_type class will need object_type, but if we do
27634 not initialize object_type, we will pass a null, which will let
27635 the runtime pick the System.Object from the existing corlib, which
27636 is not what we want).
27638 2002-04-22 Patrik Torstensson <totte@labs2.com>
27640 * cs-tokenizer.cs: fixed a number of trim() issues.
27642 2002-04-22 Ravi Pratap <ravi@ximian.com>
27644 * expression.cs (Argument.Type): Ensure that we return the correct
27645 type when we have out or ref parameters [in which case we
27648 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27650 * class.cs (Property, Indexer): Allow extern modifier in there.
27652 * typemanager.cs (InitBaseTypes): Initializes object_type and
27653 value_type, since those will be used early on during the bootstrap
27654 process to compile corlib.
27656 (InitCoreTypes): Move code from here to InitBaseTypes.
27658 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27660 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27661 single-dimension arrays as using the ldlen opcode.
27663 Daniel Lewis discovered this optimization.
27665 * typemanager.cs: Add signature for System.Array::get_Length
27667 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27669 * statement.cs: report the error when the foreach does not apply to an
27670 array nor a collection.
27672 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27674 * expression.cs: Add implicit conversions to the operator ~.
27676 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27678 * typemanager.cs: Locate the decimal constructor.
27680 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27682 * attribute.cs: use the new property of TypeOf.
27683 * expression.cs: added 'get' property around typearg.
27685 These changes fix a build breaker reported by NickD. Is this the
27686 correct way to fix? If not, please, revert my changes and make it
27689 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27691 * attribute.cs: Add support for typeof in attribute invocations.
27692 I am not sure that this is right though.
27694 2002-04-14 Duncan Mak <duncan@ximian.com>
27696 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27697 Binary.Operator.Division case.
27699 2002-04-13 Ravi Pratap <ravi@ximian.com>
27701 * class.cs (DefineType): Ensure that we do a proper check on
27702 attribute types and also register it with the TypeManager.
27704 (TypeContainer.Targets): The default for attribute types is
27705 AttributeTargets.All.
27707 * attribute.cs (ApplyAttributes): Registering the attribute type
27708 is done elsewhere, not when we discover we have a Usage attribute.
27710 2002-04-12 Ravi Pratap <ravi@ximian.com>
27712 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27713 and get rid of is_delegate parameter.
27715 * everywhere : update.
27717 2002-04-12 Ravi Pratap <ravi@ximian.com>
27719 * cs-parser.jay (compilation_unit): Revamp completely to use
27720 some new ideas that I got from Rhys' grammar to solve the problems
27721 with assembly level attributes.
27723 (outer_declaration): New grammar production.
27725 (attribute_sections): Add.
27727 (opt_attributes): Base on attribute_sections
27729 (namespace_declaration): Allow opt_attributes to tackle the case
27730 when we have assembly level attributes - we are clever in this
27733 * attribute.cs (ApplyAttributes): Do not worry about assembly
27734 attributes in the non-global context.
27736 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27737 instead of SetGlobalAttributes.
27739 * class.cs, rootcontext.cs : Ensure we define and generate
27740 attribute types before anything else.
27742 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27743 and flag the new error -20 for the case when the attribute type
27744 does not have valid targets specified. csc does not catch this.
27746 * ../errors/errors.txt : update for error # -20
27748 2002-04-11 Ravi Pratap <ravi@ximian.com>
27750 * support.cs (InternalParameters.ParameterModifier): Do some null
27751 checking and return sane values.
27753 * class.cs (Method.Define): If we are a PInvoke method, ensure
27754 that we are static and extern. Report error # 601
27756 * ../errors/cs0601.cs : Add test case for the above error.
27758 2002-04-07 Ravi Pratap <ravi@ximian.com>
27760 * rootcontext.cs (attribute_types): We need to keep type of
27761 all attribute types separately and emit code for them first.
27763 (RegisterAttribute) : Implement.
27765 * class.cs (DefineType): Check if the current Type is a custom
27766 attribute type and register it accordingly.
27768 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27769 adding the first attribute twice and rename to
27771 (SetGlobalAttributes): this.
27773 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27776 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27777 if we are processing global arguments. Hmm, I am unsure of this.
27779 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27781 * expression.cs: added static array of strings to avoid calling
27782 Enum.ToString () for Operator in Binary. Significant recover of
27785 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27787 * class.cs (FindMembers): Allow the Builders of the various
27788 members to be null. If they are skip them. This only happens
27789 during the PInvoke declaration.
27791 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27793 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27794 failure, so we do not keep going afterwards.
27796 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27797 wanted to pass `false' as the `is_delegate' argument. If this is
27798 the case, why not use delegate_type == null to mean `is_delegate =
27799 false' and anything else as is_delegate = true.
27801 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27803 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27804 code for the section, not the beginning of the tests.
27806 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27808 * cfold.cs: Handle operator + (Enum x, Underlying x)
27810 * expression.cs (Binary): same. Warn about errors where we have
27811 Enum/Enum in operator + as well.
27813 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27816 - added support for switch(bool)
27817 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27818 - add TableSwitchEmit() to handle table-based switch statements
27820 2002-04-05 Ravi Pratap <ravi@ximian.com>
27822 * expression.cs (Invocation.OverloadResolve): Factor out code which
27823 does parameter compatibility checking with arguments so that we can
27824 re-use the code even from Delegate.VerifyApplicability
27826 (VerifyArgumentsCompat): Move above code here.
27828 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27829 and instead make a call to the above method.
27831 2002-03-31 Ravi Pratap <ravi@ximian.com>
27833 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27834 We use it to keep track of classes which are attribute types.
27836 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27838 * delegate.cs (Delegate.Define): Correctly define the types in the
27839 presence of fixed and array parameters.
27841 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27844 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27845 include NonPublic after the first iteration.
27847 * class.cs (Indexer.CheckBase): Only check if both parents are
27850 * cs-parser.jay (accessor_body): If empty, set to null.
27852 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27853 same code path here to resolve constants names that we did have in
27854 MemberAccess.DoResolve. There is too much code duplicated here.
27856 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27858 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27860 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27863 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27864 tokens, numbers and strings.
27866 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27869 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27870 asyncronous parameters and the regular parameters.
27872 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27873 specify the target directory.
27875 * expression.cs: (This.DoResolve): Simplify
27876 (As.Emit): Optimize, do not generate IsInst if the expression is
27877 always of the given type.
27879 (Is.DoResolve): Bug fix, we were reporting both always/never for
27882 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27883 creating too many unnecessary arrays.
27885 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27887 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27888 fields instead of rolling our own initializer. Takes care of all
27889 implicit conversions, and drops unnecessary static checks/argument.
27891 2002-03-31 Dick Porter <dick@ximian.com>
27893 * driver.cs: use the GetDirectories() return values properly, and
27894 use "/" as path separator.
27896 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27898 * expression.cs (Unary): Optimize - - expr into expr.
27899 (Binary): Optimize a + (-b) into a -b.
27901 * codegen.cs (CodeGen): Made all methods static.
27903 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27907 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27908 TypeBuilder property.
27910 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27913 * tree.cs: Removed the various RecordXXXX, and replaced with a
27914 single RecordDecl. Removed all the accessor methods, and just
27915 left a single access point Type
27917 * enum.cs: Rename DefineEnum to DefineType.
27919 * decl.cs: New abstract method `DefineType' used to unify the
27920 Defines for Enumerations, Interfaces, TypeContainers and
27923 (FindType): Moved LookupInterfaceOrClass here. Moved the
27924 LookupBaseClasses method that used to live in class.cs and
27925 interface.cs here, and renamed to FindType.
27927 * delegate.cs: Implement DefineType. Take advantage of the
27928 refactored pattern for locating the parent builder without taking
27929 the parent_builder argument (which we know does not work if we are
27930 nested, and triggering a toplevel definition).
27932 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27934 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27935 accessibility of a member has changed during override and report
27938 * class.cs (Method.Define, Property.Define): Only complain on
27939 overrides if the method is private, any other accessibility is
27940 fine (and since we just checked the permission is the same, we are
27943 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27944 and elif are processed always. The other pre-processing
27945 directives are only processed if we are "taking" the path
27947 2002-03-29 Martin Baulig <martin@gnome.org>
27949 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27950 current location is not Null.
27952 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27953 a separate method so we can profile it.
27955 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27956 `span.Seconds' are just seconds, but no minutes or hours.
27957 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27959 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27961 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27962 Remove the gratuitous set of Final:
27964 // If an interface implementation, then we can set Final.
27965 if (((flags & MethodAttributes.Abstract) == 0) &&
27966 implementing.DeclaringType.IsInterface)
27967 flags |= MethodAttributes.Final;
27969 I do not know what I was smoking when I used that.
27972 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27973 step into fixing the name resolution issues for delegates and
27974 unifying the toplevel name resolution.
27976 2002-03-28 Martin Baulig <martin@gnome.org>
27978 * class.cs (Method.Emit): If we have a symbol writer, call its
27979 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27980 tell it about the current method.
27982 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27983 writer that we're going to emit the first byte of IL code for a new
27984 statement (a new source line).
27985 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27986 EmitContext.Mark() before emitting any code.
27988 * location.cs (SymbolDocument): Return null when we're Null.
27990 * statement.cs (Statement): Moved the `Location loc' variable here.
27991 (Statement.EmitBoolExpression): If we have a symbol writer, call
27992 ec.Mark() before emitting any code to tell it that we're at the
27993 beginning of a new statement.
27994 (StatementExpression): Added `Location' argument to the constructor.
27995 (Block): Added public readonly variable `StartLocation' and public
27996 variable `EndLocation'. The latter is to be set using SetEndLocation().
27997 (Block): Added constructor which takes a start and end location.
27998 (Block.SetEndLocation): New method. This sets the end location.
27999 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
28000 local variables we create.
28001 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
28002 each statement and do also mark the begin and end of the block.
28004 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
28005 tell it the current lexer.Location, use Location.Null for the end of the
28007 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
28008 current block, set its end location using SetEndLocation().
28009 (statement_expression): StatementExpression constructor now takes the
28010 lexer.Location as additional argument.
28011 (for_statement, declare_local_variables): Likewise.
28012 (declare_local_variables): When creating a new implicit block, use the
28013 new Block constructor and pass it the lexer.Location.
28015 2002-03-28 Miguel de Icaza <miguel@ximian.com>
28017 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
28018 members also on the parent interfaces recursively.
28020 2002-03-27 Miguel de Icaza <miguel@ximian.com>
28022 * report.cs: Use new formats, since Gonzalo finished the missing
28025 * expression.cs (Binary.ResolveOperator): added missing operator|
28026 operator& and operator^ for bool/bool.
28028 * cs-parser.jay: CheckDef now takes a Location argument that is
28029 used to report errors more precisly (instead of reporting the end
28030 of a definition, we try to track something which is a lot closer
28031 to the source of the problem).
28033 * cs-tokenizer.cs: Track global token use, so we can properly flag
28034 the use of #define/#undef after the first token has been seen.
28036 Also, rename the reportXXXX to Error_DescriptiveName
28038 * decl.cs (DeclSpace.IsTopLevel): Move property here from
28039 TypeContainer, so that Enum and Interface can use this too.
28041 * class.cs (TypeContainer.LookupInterfaceOrClass,
28042 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
28043 `builder' argument. Typically this was used to pass the parent
28044 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
28047 The problem is that a nested class could trigger the definition of
28048 a toplevel class, and the builder would be obviously wrong in that
28051 So we drop this argument, and we compute dynamically the
28052 TypeBuilder/ModuleBuilder (the correct information was available
28053 to us anyways from DeclSpace.Parent)
28055 * interface.cs (Interface.DefineInterface): Drop builder
28056 parameter cleanup like class.cs
28058 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
28061 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
28064 (Try.Emit): Propagate the returns value from the statement.
28066 (Return.Emit): Even if we are leavning
28068 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
28070 * modifiers.cs: Fix the computation of MethodAttributes flags.
28072 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
28074 * driver.cs: allow compilation of files that start with '/'.
28075 Add a default case when checking the argument of --target.
28077 2002-03-25 Miguel de Icaza <miguel@ximian.com>
28079 * interface.cs: Implement the same search algorithm for types in
28080 the interface code.
28082 * delegate.cs: Do not allow multiple definition.
28084 * Recovered ChangeLog that got accidentally amputated
28086 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
28088 * rootcontext.cs: Load manually enum to allow core classes to
28089 contain enumerations.
28091 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
28092 Update to new static methods in TypeManager.
28094 * typemanager.cs (GetMethod, GetConstructor): Use our
28095 implementation of FindMembers to find the members, since during
28096 corlib compilation, the types are TypeBuilders and GetMethod and
28097 GetConstructor do not work.
28099 Make all methods in TypeManager static.
28101 (InitCodeHelpers): Split the functionality from
28102 the InitCodeTypes function.
28104 * driver.cs: Call InitCodeHelpers after we have populated the
28107 * cs-parser.jay (delegate_declaration): we did not used to compute
28108 the delegate name correctly for void delegates.
28110 2002-03-24 Miguel de Icaza <miguel@ximian.com>
28112 * rootcontext.cs (RootContext): Init the interface_resolve_order
28113 and type_container_resolve_order always.
28115 (ResolveCore, BootstrapCorlib_ResolveClass,
28116 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
28117 compiler when compiling with --nostdlib
28119 * class.cs (TypeContainer.DefineType): Check that our parent is
28120 not null. This test is most important when we are bootstraping
28123 * codegen.cs: Split out the symbol writing code.
28125 2002-03-25 Martin Baulig <martin@gnome.org>
28127 * driver.cs (-g): Made -g an alias for --debug.
28129 2002-03-24 Martin Baulig <martin@gnome.org>
28131 * codegen.cs (SymbolWriter): New public variable. Returns the
28132 current symbol writer.
28133 (CodeGen): Added `bool want_debugging_support' argument to the
28134 constructor. If true, tell the ModuleBuild that we want debugging
28135 support and ask it for the ISymbolWriter.
28136 (Save): If we have a symbol writer, call it's Close() method after
28137 saving the assembly.
28139 * driver.c (--debug): New command line argument to create a
28140 debugger information file.
28142 * location.cs (SymbolDocument): New public property. Returns an
28143 ISymbolDocumentWriter object for the current source file or null
28144 if we don't have a symbol writer.
28146 2002-03-21 Miguel de Icaza <miguel@ximian.com>
28148 * driver.cs (LoadAssembly): Correctly return when all the paths
28149 have been tried and not before.
28151 * statement.cs (Switch.Emit): return the actual coverage for this
28152 statement (returns/not-returns)
28154 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
28155 switch of the statement if we are the last switch section. That
28156 kills two problems: try/catch problems (we used to emit an empty
28157 nop at the end) and switch statements where all branches would
28160 2002-03-19 Miguel de Icaza <miguel@ximian.com>
28162 * driver.cs: Add default assemblies (the equivalent to the
28163 Microsoft CSC.RSP file)
28165 * cs-tokenizer.cs: When updating `cols and setting it to zero,
28166 also update tokens_seen and set it to false.
28168 * driver.cs: Implement --recurse for Mike.
28170 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
28171 correctly splitting out the paths.
28173 2002-03-18 Miguel de Icaza <miguel@ximian.com>
28175 * interface.cs (Interface.PopulateProperty): Instead of using
28176 `parent' as the declaration space for the set parameters, use
28179 * support.cs (InternalParameters): InternalParameters constructor
28180 takes a DeclSpace instead of a TypeContainer.
28182 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
28183 types are being initialized, load the address of it before calling
28186 (New): Provide a mechanism to disable the generation of local
28187 value type temporaries when the caller will be providing us with
28188 an address to store it.
28190 (ArrayCreation.EmitDynamicInitializers): Use it.
28192 2002-03-17 Miguel de Icaza <miguel@ximian.com>
28194 * expression.cs (Invocation.EmitArguments): Only probe for array
28195 property if there is more than one argument. Sorry about that.
28197 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
28198 empty param arrays.
28200 * class.cs (Method.LabelParameters): Fix incorrect code path that
28201 prevented the `ParamArrayAttribute' from being applied to the
28204 2002-03-16 Miguel de Icaza <miguel@ximian.com>
28206 * support.cs (ReflectionParameters): Correctly compute whether the
28207 last argument is a params array. Fixes the problem with
28210 * typemanager.cs: Make the assemblies array always be non-null
28211 (empty, but non-null)
28213 * tree.cs (RecordDecl): New function that abstracts the recording
28214 of names. This reports error 101, and provides a pointer to the
28215 previous declaration. Fixes a crash in the compiler.
28217 * cs-parser.jay (constructor_declaration): Update to new grammar,
28218 and provide a constructor_body that can be empty.
28220 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28222 * driver.cs: Add support for --resources.
28224 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28225 Make all types for the various array helper methods be integer.
28227 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28228 CheckState to ConvCast.
28230 (ConvCast): Now it takes a `checked' state argument, to avoid
28231 depending on the emit context for the conversion, and just using
28232 the resolve time setting.
28234 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28235 instead of Invocation.EmitArguments. We do not emit the original
28236 arguments, instead we emit those which have been converted to
28237 unsigned int expressions.
28239 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28241 * codegen.cs: ditto.
28243 * expression.cs (LocalVariableReference): Drop the use of the
28244 Store function that depended on the variable index.
28246 * statement.cs (VariableInfo): Drop the `Idx' property from this
28247 class, as this is not taking into account the indexes for
28248 temporaries tat we generate during the execution, getting the
28251 * class.cs: First emit class initializers, then call the parent
28254 * expression.cs (Binary): Fix opcode emision.
28255 (UnaryMutator.EmitCode): Support checked code generation
28257 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28258 matches for events for both the Static and Instance scans,
28259 pointing to the same element. Fix that.
28261 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28263 * rootcontext.cs (ResolveTree): Always set the
28264 interface_resolve_order, because nested interfaces will be calling
28267 * class.cs (GetInterfaceOrClass): Track the same resolution
28268 process used by TypeManager.LookupType. This fixes the nested
28269 type lookups in class declarations (separate path from
28272 (TypeContainer.DefineType): Also define nested interfaces.
28273 (TypeContainer.RegisterOrder): New public function used to
28274 register the order in which child interfaces need to be closed.
28276 Nested interfaces need to be closed after their parents have been
28279 * interface.cs (InterfaceAttr): Put all the logic for computing
28280 the interface attribute here.
28282 (DefineInterface): Register our interface order with the
28283 RootContext or with the TypeContainer depending on the case.
28285 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28287 * cs-parser.jay: rework foreach statement to work with the new
28288 changes to the policy on SimpleNames.
28290 * report.cs: support Stacktrace on warnings as well.
28292 * makefile: drop --unsafe and /unsafe from the compile.
28294 2002-03-13 Ravi Pratap <ravi@ximian.com>
28296 * ecore.cs (StandardConversionExists): Modify to take an Expression
28297 as the first parameter. Ensure we do null -> reference type conversion
28300 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28301 temporary Expression objects.
28303 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28305 * interface.cs: workaround bug in method overloading resolution
28306 (there is already a bugzilla bug for it).
28308 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28310 We could also solve this problem by having a separate path for
28311 performing type lookups, instead of DoResolve, we could have a
28312 ResolveType entry point, and only participating pieces of the
28313 production (simplename, deref, array) would implement this.
28315 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28316 signal SimpleName to only resolve type names and not attempt to
28317 resolve anything else.
28319 * expression.cs (Cast): Set the flag.
28321 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28323 * class.cs: Only report 108 if there is no `new' modifier.
28325 * cs-parser.jay: rework foreach statement to work with the new
28326 changes to the policy on SimpleNames.
28328 * report.cs: support Stacktrace on warnings as well.
28330 * makefile: drop --unsafe and /unsafe from the compile.
28332 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28334 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28335 lookups here, instead of doing that at parse time. This means
28336 that our grammar will not introduce `LocalVariableReferences' as
28337 expressions at this point. That solves the problem of code like
28341 static void Main ()
28345 This is only half the fix. The full fix requires parameters to
28346 also be handled in this way.
28348 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28349 makes the use more obvious of the DeclSpace. The
28350 ec.TypeContainer.TypeBuilder is now only used to pull the
28351 TypeBuilder for it.
28353 My theory is that I can get rid of the TypeBuilder completely from
28354 the EmitContext, and have typecasts where it is used (from
28355 DeclSpace to where it matters).
28357 The only pending problem is that the code that implements Aliases
28358 is on TypeContainer, and probably should go in DeclSpace.
28360 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28361 lookups here, instead of doing that at parse time. This means
28362 that our grammar will not introduce `LocalVariableReferences' as
28363 expressions at this point. That solves the problem of code like
28367 static void Main ()
28371 This is only half the fix. The full fix requires parameters to
28372 also be handled in this way.
28374 * class.cs (Property.DefineMethod): When implementing an interface
28375 method, set newslot, when implementing an abstract method, do not
28376 set the flag (before we tried never setting it, or always setting
28377 it, which is the difference).
28378 (Indexer.DefineMethod): same.
28379 (Method.DefineMethod): same.
28381 * ecore.cs: Only set the status used flag if we get back a Field.
28383 * attribute.cs: Temporary hack, so Paolo can keep working.
28385 2002-03-08 Ravi Pratap <ravi@ximian.com>
28387 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28388 the unmanaged type in the case we have a MarshalAs attribute.
28390 (Resolve): Handle the case when we are parsing the special MarshalAs
28391 attribute [we need to store the unmanaged type to use later]
28393 * typemanager.cs (marshal_as_attr_type): Built in type for the
28394 MarshalAs Attribute.
28396 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28397 on parameters and accordingly set the marshalling info.
28399 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28401 * class.cs: Optimizing slightly by removing redundant code after
28402 we switched to the `NoTypes' return value.
28403 (Property.DefineMethod): use NoTypes here too.
28405 This fixes the bug I introduced in my last batch of changes.
28407 2002-03-05 Ravi Pratap <ravi@ximian.com>
28409 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28411 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28412 Enums since those are types too.
28414 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28416 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28417 thanks to a call during the lookup process.
28419 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28421 * statement.cs (Foreach): Lots of work to accomodate a particular
28422 kind of foreach statement that I had not kept in mind. It is
28423 possible to have foreachs on classes that provide a GetEnumerator
28424 method that return objects that implement the "pattern" for using
28425 a foreach, there is no need to support GetEnumerator
28428 This is needed to compile nant.
28430 * decl.cs: Only report 114 if the member is not `Finalize' and if
28431 the warning level is at least 2.
28433 * class.cs: Moved the compare function from Method to
28436 (MethodSignature.InheritableMemberSignatureCompare): Add new
28437 filter function that is used to extract inheritable methods from a
28440 (Method.Define): Use the new `inheritable_method_signature_filter'
28443 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28446 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28448 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28450 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28452 * expression.cs: Pass location information to
28453 ConvertImplicitStandard.
28455 * class.cs: Added debugging code to track return values from
28458 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28460 * expression.cs (Is.DoResolve): If either side of the `is' is an
28461 interface, do not flag the warning.
28463 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28466 * report.cs: Allow for --fatal to be used with --probe.
28468 * typemanager.cs (NoTypes): Move the definition for the empty Type
28471 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28473 (TypeContainer.DefineProxy): New function used to proxy to parent
28474 implementations when implementing interfaces.
28475 (TypeContainer.ParentImplements): used to lookup if our parent
28476 implements a public function that is required by an interface.
28477 (TypeContainer.VerifyPendingMethods): Hook this up.
28479 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28480 `modules' and `assemblies' arraylists into arrays. We only grow
28481 these are the very early start up of the program, so this improves
28482 the speedof LookupType (nicely measured).
28484 * expression.cs (MakeByteBlob): Replaced unsafe code with
28485 BitConverter, as suggested by Paolo.
28487 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28488 folding of string concatenation, but if either side is a string,
28489 and the other is not, then return null, and let the runtime use
28490 the concatenation on the string plus the object (using
28491 `Object.ToString').
28493 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28495 Constant Folding has been implemented now.
28497 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28498 the error instead on types that are not supported in one's
28501 * constant.cs (Constant and all children): New set of functions to
28502 perform implict and explicit conversions.
28504 * ecore.cs (EnumConstant): Implement the new functions to perform
28505 conversion by proxying to the child expression.
28507 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28508 own separate setting that can not be turned off from the command
28509 line using --unchecked or --checked and is only controlled using
28510 the checked/unchecked statements and expressions. This setting is
28511 used by the constant folder to flag errors.
28513 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28514 ConstantCheckState as well.
28516 During Resolve, they also have to flag the state, because the
28517 constant folder runs completely in the Resolve phase.
28519 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28522 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28524 * cfold.cs: New file, this file contains the constant folder.
28526 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28527 argument to track whether we are using the resulting address to
28528 load or store a value and provide better error messages.
28530 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28531 new AddressOf arguments.
28533 * statement.cs (Foreach.EmitCollectionForeach): Update
28535 * expression.cs (Argument.Emit): Call AddressOf with proper
28536 arguments to track usage.
28538 (New.DoEmit): Call AddressOf with new arguments.
28540 (Unary.Emit): Adjust AddressOf call.
28542 2002-03-01 Ravi Pratap <ravi@ximian.com>
28544 * cs-parser.jay (member_access): Change the case for pre-defined types
28545 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28548 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28551 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28552 essentially like methods and apply attributes like MethodImplOptions to them too.
28554 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28557 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28558 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28561 * Update code everywhere accordingly.
28563 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28565 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28567 2002-02-28 Ravi Pratap <ravi@ximian.com>
28569 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28570 try performing lookups against those instead of jumping straight into using
28571 the 'using' clauses.
28573 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28575 (LookupType): Perform lookups in implicit parents too.
28577 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28578 sequence as RootContext.LookupType.
28580 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28581 the various cases of namespace lookups into this method.
28583 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28585 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28586 in positional arguments)
28588 * class.cs (Operator): Update the AllowedModifiers to contain
28591 * cs-parser.jay: Update operator declaration to allow for the
28592 operator body to be empty.
28594 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28597 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28599 * class.cs (Method.Emit): Label parameters.
28601 * driver.cs: Return 1 or 0 as the program exit code.
28603 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28605 * expression.cs: Special case the `null' object when trying to
28606 auto-compute the type, as anything can be explicitly converted to
28609 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28610 spotting this Paolo.
28612 (Expression.ImplicitNumericConversion): Perform comparissions of
28613 the type using the underlying type in the case of an enumeration
28614 rather than using the enumeration type for the compare.
28616 Cope with the underlying == type case, which is not possible to
28619 (Expression.ConvertNumericExplicit): Perform comparissions of
28620 the type using the underlying type in the case of an enumeration
28621 rather than using the enumeration type for the compare.
28623 * driver.cs: If the user does not supply an extension, assume .exe
28625 * cs-parser.jay (if_statement): Rewrote so that we can track the
28626 location for the if statement.
28628 * expression.cs (Binary.ConstantFold): Only concat strings when
28629 the operation is "+", not everything ;-)
28631 * statement.cs (Statement.EmitBoolExpression): Take a location
28633 (If, While, Do): Track location.
28635 * expression.cs (Binary.ResolveOperator): In the object + string
28636 case, I was missing a call to ConvertImplicit
28638 2002-02-25 Ravi Pratap <ravi@ximian.com>
28640 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28641 Location arguments. Ensure we use RootContext.LookupType to do our work
28642 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28644 * interface.cs (PopulateMethod): Handle the type of the parameter being
28647 * expression.cs (Invocation.BetterFunction): Handle the case when we
28648 have a params method with no fixed arguments and a call is made with no
28651 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28653 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28654 the verbatim-string-literal
28656 * support.cs (InternalParameters.ParameterModifier): handle null
28658 (InternalParameters.ParameterType): ditto.
28660 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28661 duplicating the name of the variable parameter.
28662 (GetParameterByName): Fix bug where we were not looking up array
28663 paramters if they were the only present (thanks Paolo!).
28664 (GetParameterInfo): We only have an empty set of types if both
28665 fixed and array are set to null.
28666 (GetParameterInfo-idx): Handle FixedParameter == null
28668 * cs-parser.jay: Handle the case where there is no catch
28669 statements (missing null test).
28671 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28673 * driver.cs (MainDriver): Be conservative on our command line
28676 Catch DirectoryNotFoundException when calling GetFiles.
28678 (SplitPathAndPattern): Used to split the input specification into
28679 a path and a pattern that we can feed to Directory.GetFiles.
28681 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28683 * statement.cs (Fixed): Implement the last case of the Fixed
28684 statement (string handling).
28686 * expression.cs (StringPtr): New class used to return a char * to
28687 a string; Used by the Fixed statement.
28689 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28691 * expression.cs (Binary.ResolveOperator): Remove redundant
28692 MemberLookup pn parent type.
28693 Optimize union call, we do not need a union if the types are the same.
28694 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28697 Specialize the use of MemberLookup everywhere, instead of using
28698 the default settings.
28700 (StackAlloc): Implement stackalloc keyword.
28702 * cs-parser.jay: Add rule to parse stackalloc.
28704 * driver.cs: Handle /h, /help, /?
28706 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28707 before we supported unsafe code.
28709 * makefile: add --unsafe to the self compilation of mcs.
28711 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28713 * expression.cs (PointerArithmetic): New class that is used to
28714 perform pointer arithmetic.
28715 (Binary.Resolve): Handle pointer arithmetic
28716 Handle pointer comparission.
28717 (ArrayPtr): Utility expression class that is used to take the
28718 address of an array.
28720 (ElementAccess): Implement array access for pointers
28722 * statement.cs (Fixed): Implement fixed statement for arrays, we
28723 are missing one more case before we are done.
28725 * expression.cs (Indirection): Implement EmitAssign and set the
28726 ExprClass to Variable. This allows pointer dereferences to be
28727 treated as variables, and to have values assigned to them.
28729 * ecore.cs (Expression.StoreFromPtr): New utility function to
28730 store values dereferencing.
28732 2002-02-20 Ravi Pratap <ravi@ximian.com>
28734 * expression.cs (Binary.ResolveOperator): Ensure that we are
28735 not trying to operate on a void type - this fixes the reported
28738 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28739 the parent implementation is sealed.
28741 * ../errors/cs0239.cs : Add.
28743 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28745 * typemanager.cs (unverifiable_code_type): Corresponds to
28746 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28747 which have unsafe code in them.
28749 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28752 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28754 * cs-tokenizer.cs: Add support for @"litreal strings"
28756 Make tokenizer accept pre-processor directives
28757 on any column (remove the old C-like limitation).
28759 * rootcontext.cs (EmitCode): Emit any global attributes.
28760 (AddGlobalAttributes): Used to keep track of assembly attributes.
28762 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28764 * cs-parser.jay: Add support for global attributes.
28766 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28768 * expression.cs (Indirection): New helper class. Unary will
28769 create Indirection classes to be able to implement the
28770 IMemoryLocation interface on it.
28772 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28774 * cs-parser.jay (fixed_statement): reference the right statement.
28776 * statement.cs (Fixed.Emit): Finish implementing the fixed
28777 statement for the &x case.
28779 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28781 * class.cs (Property.Define, Method.Define): Remove newslot when
28784 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28785 wrong. NewSlot should only be used if the `new' keyword is present.
28787 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28788 locating our system dir. Sorry about this.
28790 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28792 * driver.cs (GetSystemDir): Compute correctly the location of our
28793 system assemblies. I was using the compiler directory instead of
28794 the library directory.
28796 2002-02-13 Ravi Pratap <ravi@ximian.com>
28798 * expression.cs (BetterFunction): Put back in what Miguel commented out
28799 since it is the correct fix. The problem is elsewhere ;-)
28801 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28802 parameters of the parms method are themselves compatible or not !
28804 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28805 to check that a class implements an interface before saying that an implicit
28806 conversion was allowed. Use ImplementsInterface to do the checking.
28808 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28810 * class.cs (Method.Define): Track whether we are an explicit
28811 implementation or not. And only call DefineMethodOverride if we
28812 are an explicit implementation.
28814 (Property.DefineMethod): Ditto.
28816 2002-02-11 Ravi Pratap <ravi@ximian.com>
28818 * expression.cs (BetterFunction): Catch hideous bug which was
28819 preventing us from detecting ambiguous calls due to implicit casts i.e
28822 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28824 * support.cs (Pair): Remove un-needed method. I figured why I was
28825 getting the error in cs-parser.jay, the variable in a foreach loop
28826 is readonly, and the compiler does not really treat this as a variable.
28828 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28829 instead of EQUALS in grammar.
28831 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28833 * expression.cs (Unary.DoResolve): Check whether the argument is
28836 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28838 * support.cs: Api for Pair to set a value. Despite the fact that
28839 the variables are public the MS C# compiler refuses to compile
28840 code that accesses the field if the variable is part of a foreach
28843 * statement.cs (Fixed): Begin implementation of the fixed
28846 (Block.AddVariable): Return the VariableInfo on success and null
28847 on failure instead of true/false.
28849 * cs-parser.jay (foreach): Catch errors on variables already
28850 defined (we were ignoring this value before) and properly unwind
28851 the block hierarchy
28853 (fixed_statement): grammar for the fixed statement.
28855 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28857 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28858 pointer types to be incretemented.
28860 (SizeOf): Implement.
28862 * cs-parser.jay (pointer_member_access): Implement
28863 expr->IDENTIFIER production.
28865 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28866 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28869 (Unary): Implement indirection.
28871 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28872 use in non-unsafe context).
28874 (SimpleName.DoResolve): Check for pointers in field access on safe
28877 (Expression.LoadFromPtr): Factor the load-indirect code in this
28878 function. This was duplicated in UnboxCast and ParameterReference
28880 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28882 * expression.cs (ComposedCast): report an error if a pointer cast
28883 is used in a safe region.
28885 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28886 pointer type casts in unsafe context.
28888 * codegen.cs (EmitContext): Set up IsUnsafe.
28890 * cs-parser.jay (non_expression_type): Add productions for pointer
28893 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28894 code. We should not use force into static mode if the method is
28895 not virtual. Fixes bug in MIS
28897 * statement.cs (Do.Emit, While.Emit, For.Emit,
28898 Statement.EmitBoolExpression): Add support to Do and While to
28899 propagate infinite loop as `I do return' semantics.
28901 Improve the For case to also test for boolean constants.
28903 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28904 to the list of attributes we can add.
28906 Remove `EmitContext' argument.
28908 * class.cs (Method.Define): Apply parameter attributes.
28909 (Constructor.Define): Apply parameter attributes.
28910 (MethodCore.LabelParameters): Move here the core of labeling
28913 * support.cs (ReflectionParameters.ParameterModifier,
28914 InternalParameters.ParameterModifier): Use IsByRef on the type and
28915 only return the OUT bit for these parameters instead of in/out/ref
28918 This is because I miss-understood things. The ParameterInfo.IsIn
28919 and IsOut represent whether the parameter has the [In] and [Out]
28922 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28924 * ecore.cs (FieldExpr.Emit): Release temporaries.
28926 * assign.cs (LocalTemporary.Release): new function.
28928 * codegen.cs (EmitContext.GetTemporaryStorage,
28929 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28930 temporary storage. Now we can "put back" localbuilders when we
28933 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28935 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28936 need to make a copy of the variable to generate verifiable code.
28938 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28940 * driver.cs: Compute dynamically the system directory.
28942 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28943 Slower, but more generally useful. Used by the abstract
28944 registering implementation.
28946 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28947 the rules for the special rule on Type/instances. First check if
28948 we have the same name, and if so, try that special static path
28949 rather than the instance path.
28951 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28953 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28956 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28957 Enum, ValueType, Delegate or Array for non-corlib compiles.
28959 * cs-tokenizer.cs: Catch long identifiers (645)
28961 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28964 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28965 fix, we were returning too early, so we were not registering
28966 pending methods from abstract classes.
28968 Do not register pending methods if the class is abstract.
28970 * expression.cs (Conditional.DoResolve): Report circular implicit
28971 conversions when we neecd to compute it for conditional
28974 (Is.DoResolve): If the expression is always of the provided type,
28975 flag warning 183. If the expression can not ever be of the
28976 provided type flag warning 184.
28978 * class.cs: Catch 169 as well.
28980 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28983 2002-01-18 Nick Drochak <ndrochak@gol.com>
28985 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28987 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28989 * interface.cs: (PopulateMethod): Check for pointers being defined
28990 only if the unsafe context is active.
28991 (PopulateProperty): ditto.
28992 (PopulateIndexer): ditto.
28994 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28995 specified. If pointers are present, make sure that they are
28996 present in an unsafe context.
28997 (Constructor, Constructor.Define): ditto.
28998 (Field, Field.Define): ditto.
28999 (Property, Property.Define): ditto.
29000 (Event, Event.Define): ditto.
29002 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
29003 hashtable if there are classes or structs defined.
29005 * expression.cs (LocalVariableReference.DoResolve): Simplify this
29006 code, as the constant resolution moved.
29008 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
29009 the metadata, so we can flag error 133.
29011 * decl.cs (MemberCore.UnsafeOK): New function to test that a
29012 pointer is being declared in an unsafe context.
29014 2002-01-16 Miguel de Icaza <miguel@ximian.com>
29016 * modifiers.cs (Modifiers.Check): Require a Location argument.
29017 Report error 227 for Unsafe use.
29019 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
29021 * statement.cs (For.Emit): If the test is null, then report that
29022 we do `return', as we wont reach anything afterwards.
29024 (Switch.SwitchGoverningType): Track the expression that matched
29027 * driver.cs: Allow negative numbers as an error code to flag.
29029 * cs-parser.jay: Handle 1551.
29031 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
29033 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29035 * cs-parser.jay: Report 1518 (type declaration can only contain
29036 class, struct, interface, enum or delegate)
29038 (switch_label): Report 1523 (keywords `case' or `default' must
29041 (opt_switch_sections): Report 1522 (empty switch)
29043 * driver.cs: Report 1515 (response file specified multiple times)
29044 Report 1516 (Source file specified multiple times).
29046 * expression.cs (Argument.Resolve): Signal 1510
29048 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
29049 access not allowed in static code)
29051 2002-01-11 Ravi Pratap <ravi@ximian.com>
29053 * typemanager.cs (IsPointerType): Utility method which we are going
29056 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
29057 the object type, so we take care of that.
29059 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
29061 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
29062 added to non-params parameters :-)
29064 * typemanager.cs (CSharpName): Include 'void' type too.
29066 (void_ptr_type): Include in the set of core types.
29068 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
29071 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
29074 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
29075 completely forgotten about it.
29077 2002-01-10 Ravi Pratap <ravi@ximian.com>
29079 * cs-parser.jay (pointer_type): Add. This begins our implementation
29080 of parsing rules for unsafe code.
29082 (unsafe_statement): Implement.
29084 (embedded_statement): Modify to include the above.
29086 * statement.cs (Unsafe): Implement new class for unsafe blocks.
29088 * codegen.cs (EmitContext.InUnsafe): Add. This determines
29089 if the current context is an unsafe one.
29091 * cs-parser.jay (local_variable_pointer_type): Since local variable types
29092 are handled differently, we need separate rules for them.
29094 (local_variable_declaration): Update to use local_variable_pointer_type
29095 to allow variable declarations of unmanaged pointer types.
29097 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
29098 in unsafe contexts.
29100 * ../errors/cs0214.cs : Add.
29102 2002-01-16 Nick Drochak <ndrochak@gol.com>
29104 * makefile: remove 'response' file when cleaning.
29106 2002-01-15 Miguel de Icaza <miguel@ximian.com>
29108 * cs-parser.jay: Report 1524.
29110 2002-01-14 Miguel de Icaza <miguel@ximian.com>
29112 * typemanager.cs (RegisterMethod): drop checking if we have
29113 registered this from here
29115 2002-01-12 Miguel de Icaza <miguel@ximian.com>
29117 * class.cs (Method.EmitDestructor): Implement calling our base
29120 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
29121 value of InFinally.
29123 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
29124 this routine and will wrap the call in a try/catch block. Deal
29127 2002-01-11 Miguel de Icaza <miguel@ximian.com>
29129 * ecore.cs (Expression.MemberLookup): instead of taking a
29130 parameter `same_type' that was used to tell whether we could
29131 access private members we compute our containing type from the
29134 (FieldExpr): Added partial support for volatile fields. This does
29135 not work for volatile fields exposed from assemblies, as I can not
29136 figure out how to extract the modreq from it.
29138 Updated all the source files to use this.
29140 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
29141 because it is referenced by MemberLookup very often.
29143 2002-01-09 Ravi Pratap <ravi@ximian.com>
29145 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
29146 TypeBuilder.GetCustomAttributes to retrieve what we need.
29148 Get rid of redundant default_member_attr_type as this is the same as
29149 default_member_type which already exists.
29151 * interface.cs, attribute.cs : Update accordingly.
29153 2002-01-08 Miguel de Icaza <miguel@ximian.com>
29155 * typemanager.cs: Enable IndexerPropertyName again. It does not
29156 work for TYpeBuilders though. Ravi, can you please fix this?
29158 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
29160 * expression.cs (Argument.Emit): Handle the case of ref objects
29161 being passed to ref functions;
29163 (ParameterReference.EmitLoad): Loads the content of the pointer
29164 without dereferencing.
29166 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29168 * cs-tokenizer.cs: Implemented the pre-processing expressions.
29170 2002-01-08 Ravi Pratap <ravi@ximian.com>
29172 * class.cs (Indexer.DefineMethod): Incorporate the interface
29173 type in the name of the method if we are doing explicit interface
29176 * expression.cs (ConversionExists): Remove as it is completely obsolete.
29178 (BetterConversion): Fix extremely trivial bug where we were referring to
29179 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
29182 * ../errors/bug16.cs : Add although we have fixed it.
29184 2002-01-07 Miguel de Icaza <miguel@ximian.com>
29186 * expression.cs (BaseIndexer): Begin implementation.
29188 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
29190 * cs-parser.jay (indexer_declarator): Use qualified_identifier
29191 production directly to remove a shift/reduce, and implement
29192 explicit interface implementation.
29194 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
29195 after a floating point suffix.
29197 * expression.cs (DoNumericPromotions): Improved the conversion for
29198 uint/uint. If we have a constant, we avoid doing a typecast to a
29201 * class.cs (Indexer): Implement explicit interface implementation
29204 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
29206 * class.cs: make the default instance constructor public and hidebysig.
29208 2001-01-03 Ravi Pratap <ravi@ximian.com>
29210 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29211 so we can call it from elsewhere.
29213 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29214 we emit it internally if the class has a defined indexer; otherwise the user
29215 emits it by decorating the class definition with the DefaultMemberAttribute.
29217 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29218 attribute is not used on a type which defines an indexer.
29220 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29221 character when we skip whitespace.
29223 * ../errors/cs0646.cs : Add.
29225 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29227 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29230 * makefile: Add practical target `mcs3.exe' which builds the third
29231 generation compiler.
29233 * expression.cs (New): Fix structures constructor calling.
29235 * class.cs (Property, Method, Indexer): Emit Final flag on the
29236 method if we are an interface implementation and we are not
29239 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29240 whether this property is referencing a `base' method.
29242 * expression.cs (Invocation.EmitCall): take an extra argument:
29243 is_base, this is used to determine whether the `call' or
29244 `callvirt' opcode should be used.
29247 * delegate.cs: update EmitCall.
29249 * class.cs (Method.Define): Set NewSlot for the cases where we are
29250 not implementing an interface method.
29252 (Property.Define): ditto.
29254 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29256 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29257 'r'. Allows mcs to parse itself fully.
29259 2002-01-02 Ravi Pratap <ravi@ximian.com>
29261 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29262 of the number of initializers that require the InitializeArray method.
29264 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29265 update the above field where necessary.
29267 (MakeByteBlob): Update accordingly.
29269 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29272 (EmitDynamicInitializers): Update in accordance with the new optimization.
29274 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29275 same OpCode applies.
29277 * cs-parser.jay : Fix some glaring errors I introduced.
29279 2002-01-01 Ravi Pratap <ravi@ximian.com>
29281 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29282 so that we can check for name clashes there too.
29284 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29285 for interface indexers.
29287 * interfaces.cs (Define): Emit the default member attribute.
29289 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29290 variable was being referred to while setting the value ;-)
29292 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29294 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29295 byte-by-byte information when we know the data is zero.
29297 Make the block always a multiple of 4, because
29298 DefineInitializedData has a bug.
29300 * assign.cs: Fix, we should assign from the temporary, not from
29303 * expression.cs (MakeByteBlob): Fix my incorrect code.
29305 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29307 * typemanager.cs (EnumToUnderlying): This function is used to get
29308 the underlying type from an enumeration, because it does not
29311 * constant.cs: Use the I4_S form for values between -128 and 127.
29313 * statement.cs (Block.LookupLabel): Looks up a label.
29314 (Block): Drop support for labeled blocks.
29316 (LabeledStatement): New kind of statement that represents a label
29319 (Goto): Finally implement this bad boy.
29321 * cs-parser.jay: Update to reflect new mechanism to implement
29324 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29326 * codegen.cs (EmitContext.This): a codegen property that keeps the
29327 a single instance of this instead of creating many different this
29330 * delegate.cs (Delegate.DoResolve): Update to use the property;
29332 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29334 * expression.cs (BaseAccess.DoResolve): Ditto.
29336 2001-12-29 Ravi Pratap <ravi@ximian.com>
29338 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29339 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29341 (InitCoreTypes): Update accordingly.
29343 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29344 so we can quickly store the state.
29346 (ApplyAttributes): Set the correct implementation flags
29347 for InternalCall methods.
29349 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29351 * expression.cs (EmitCall): if a method is not virtual, then do
29352 not use callvirt on it.
29354 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29355 user defined stuff) requires the use of stobj, which takes an
29356 address on the stack instead of an array and an index. So emit
29357 the Ldelema operation for it.
29359 (EmitStoreOpcode): Use stobj for valuetypes.
29361 (UnaryMutator.EmitCode): Use the right 1 value depending on
29362 whether we are dealing with int64/uint64, float or doubles.
29364 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29365 constructors that I implemented last night.
29367 (Constructor.IsDefault): Fix to work properly for static
29370 * cs-parser.jay (CheckDef): report method signature errors.
29371 Update error number 103 to be 132.
29373 * decl.cs: New AdditionResult enumeration value: MethodExists.
29374 Although we do this check for methods later on in the semantic
29375 analysis, catching repeated default constructors is so easy that
29376 we catch these here.
29378 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29381 (ParameterReference.EmitAssign, Emit): handle
29384 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29385 (ArrayAccess.EmitStoreOpcode): ditto.
29387 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29389 * expression.cs (MakeByteBlob): Complete all the missing types
29390 (uint, short, ushort, byte, sbyte)
29392 * class.cs: Only init instance field initializers on instance
29395 Rename `constructors' to instance_constructors.
29397 (TypeContainer.AddConstructor): Only add constructors to the list
29398 if it is not static.
29400 Make sure that we handle default_static_constructor independently
29401 everywhere where we handle instance_constructors
29403 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29405 * class.cs: Do not lookup or create a base initializer for a
29406 static constructor.
29408 (ConstructorInitializer.Resolve): use the proper type to lookup
29411 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29413 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29416 * decl.cs: CloseType is now an virtual method, the default
29417 implementation just closes this type.
29419 2001-12-28 Ravi Pratap <ravi@ximian.com>
29421 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29422 to PreserveSig by default. Also emit HideBySig on such methods.
29424 Basically, set the defaults to standard values.
29426 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29427 argument, if candidate is better, it can't be worse than the best !
29429 (Invocation): Re-write bits to differentiate between methods being
29430 applicable in their expanded form and their normal form - for params
29433 Get rid of use_standard everywhere as only standard conversions are allowed
29434 in overload resolution.
29436 More spec conformance.
29438 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29440 * driver.cs: Add --timestamp, to see where the compiler spends
29443 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29444 `this' in static code.
29446 (SimpleName.DoResolve): Implement in terms of a helper function
29447 that allows static-references to be passed upstream to
29450 (Expression.ResolveWithSimpleName): Resolve specially simple
29451 names when called by MemberAccess to implement the special
29454 (Expression.ImplicitReferenceConversion): Handle conversions from
29455 Null to reference types before others, as Null's type is
29458 * expression.cs (Invocation.EmitCall): Handle the special case of
29459 calling methods declared on a reference type from a ValueType
29460 (Base classes System.Object and System.Enum)
29462 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29463 the left hand side is a TypeExpr, not on every enumeration.
29465 (Binary.Resolve): If types are reference types, then do a cast to
29466 object on operators != and == of both arguments.
29468 * typemanager.cs (FindMembers): Extract instance and static
29469 members if requested.
29471 * interface.cs (PopulateProperty): Use void_type instead of null
29472 as the return type for the setter method.
29474 (PopulateIndexer): ditto.
29476 2001-12-27 Ravi Pratap <ravi@ximian.com>
29478 * support.cs (ReflectionParameters): Fix minor bug where we
29479 were examining the wrong parameter for the ParamArray attribute.
29481 Cope with requests for the type of the parameter at position
29482 greater than the params parameter's. We now return the element
29483 type of the params array as that makes more sense.
29485 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29486 accordingly as we no longer have to extract the element type
29489 (Invocation.OverloadResolve): Update.
29491 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29493 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29494 against IEnumerator, test whether the return value is a descendant
29495 of the IEnumerator interface.
29497 * class.cs (Indexer.Define): Use an auxiliary method to implement
29498 the other bits of the method definition. Begin support for
29499 explicit interface implementation.
29501 (Property.DefineMethod): Use TypeManager.void_type instead of null
29502 for an empty return value.
29504 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29506 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29507 dealing with a FieldExpr which is composed of a FieldBuilder, in
29508 the code path we did extract the constant, but we should have
29509 obtained the underlying value to be able to cast it (otherwise we
29510 end up in an infinite loop, this is what Ravi was running into).
29512 (ArrayCreation.UpdateIndices): Arrays might be empty.
29514 (MemberAccess.ResolveMemberAccess): Add support for section
29515 14.5.4.1 that deals with the special case of E.I when E is a type
29516 and something else, that I can be a reference to a static member.
29518 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29519 handle a particular array type to create byte blobs, it is just
29520 something we dont generate byteblobs for.
29522 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29525 * location.cs (Push): remove the key from the hashtable that we
29526 are about to add. This happens for empty files.
29528 * driver.cs: Dispose files after we have parsed them.
29530 (tokenize): new function that only runs the tokenizer on its
29531 input, for speed testing.
29533 2001-12-26 Ravi Pratap <ravi@ximian.com>
29535 * class.cs (Event.Define): Define the private field only if there
29536 are no accessors defined.
29538 * expression.cs (ResolveMemberAccess): If there is no associated
29539 field with the event, that means we have an event defined with its
29540 own accessors and we should flag error cs0070 since transforming
29541 ourselves into a field is not valid in that case.
29543 * ecore.cs (SimpleName.DoResolve): Same as above.
29545 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29546 and charset to sane values.
29548 2001-12-25 Ravi Pratap <ravi@ximian.com>
29550 * assign.cs (DoResolve): Perform check on events only if they
29551 are being accessed outside the declaring type.
29553 * cs-parser.jay (event_declarations): Update rules to correctly
29554 set the type of the implicit parameter etc.
29556 (add_accessor, remove_accessor): Set current local parameters.
29558 * expression.cs (Binary): For delegate addition and subtraction,
29559 cast the return value from the method into the appropriate delegate
29562 2001-12-24 Ravi Pratap <ravi@ximian.com>
29564 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29565 of these as the workaround is unnecessary.
29567 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29568 delegate data - none of that is needed at all.
29570 Re-write bits to extract the instance expression and the delegate method
29573 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29576 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29577 of attaching attributes instead of duplicating code everywhere.
29579 * everywhere : Update code to do attribute emission using the above method.
29581 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29583 * expression.cs (IsParamsMethodApplicable): if there are not
29584 parameters, return immediately.
29586 * ecore.cs: The 0 literal can be implicity converted to an enum
29589 (SimpleName.DoResolve): First lookup the type, then lookup the
29592 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29593 want to get its address. If the InstanceExpression is not
29594 addressable, store the result in a temporary variable, then get
29597 * codegen.cs: Only display 219 errors on warning level or above.
29599 * expression.cs (ArrayAccess): Make it implement the
29600 IMemoryLocation interface.
29602 (Binary.DoResolve): handle the operator == (object a, object b)
29603 and operator != (object a, object b) without incurring into a
29604 BoxedCast (because 5 != o should never be performed).
29606 Handle binary enumerator operators.
29608 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29609 value type, otherwise use Ldelem_ref.
29611 Use precomputed names;
29613 (AddressOf): Implement address of
29615 * cs-parser.jay (labeled_statement): Fix recursive block
29616 addition by reworking the production.
29618 * expression.cs (New.DoEmit): New has a special case:
29620 If we are dealing with a ValueType, we have a few
29621 situations to deal with:
29623 * The target of New is a ValueType variable, that is
29624 easy, we just pass this as the variable reference
29626 * The target of New is being passed as an argument,
29627 to a boxing operation or a function that takes a
29630 In this case, we need to create a temporary variable
29631 that is the argument of New.
29634 2001-12-23 Ravi Pratap <ravi@ximian.com>
29636 * rootcontext.cs (LookupType): Check that current_type is not null before
29637 going about looking at nested types.
29639 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29640 not implement the IAssignMethod interface any more.
29642 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29643 where we tranform them into FieldExprs if they are being resolved from within
29644 the declaring type.
29646 * ecore.cs (SimpleName.DoResolve): Do the same here.
29648 * assign.cs (DoResolve, Emit): Clean up code considerably.
29650 * ../errors/bug10.cs : Add.
29652 * ../errors/cs0070.cs : Add.
29654 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29656 * assign.cs : Get rid of EventIsLocal everywhere.
29658 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29660 * ecore.cs (ConvertIntLiteral): finished the implementation.
29662 * statement.cs (SwitchLabel): Convert the value we are using as a
29663 key before looking up the table.
29665 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29667 * codegen.cs (EmitTopBlock): Require a Location argument now.
29669 * cs-parser.jay (constructor_declarator): We need to setup
29670 current_local_parameters before we parse the
29671 opt_constructor_initializer, to allow the variables to be bound
29672 to the constructor arguments.
29674 * rootcontext.cs (LookupType): First lookup nested classes in our
29675 class and our parents before we go looking outside our class.
29677 * expression.cs (ConstantFold): Extract/debox the values at the
29680 * rootcontext.cs (EmitCode): Resolve the constants first before we
29681 resolve the types. This is not really needed, but it helps debugging.
29683 * statement.cs: report location.
29685 * cs-parser.jay: pass location to throw statement.
29687 * driver.cs: Small bug fix.
29689 * report.cs: Updated format to be 4-zero filled digits.
29691 2001-12-22 Ravi Pratap <ravi@ximian.com>
29693 * expression.cs (CheckIndices): Fix minor bug where the wrong
29694 variable was being referred to ;-)
29696 (DoEmit): Do not call EmitStaticInitializers when the
29697 underlying type is System.Object.
29699 2001-12-21 Ravi Pratap <ravi@ximian.com>
29701 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29702 and do the usual workaround for SRE.
29704 * class.cs (MyEventBuilder.EventType): New member to get at the type
29705 of the event, quickly.
29707 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29709 * assign.cs (Assign.DoResolve): Handle the case when the target
29710 is an EventExpr and perform the necessary checks.
29712 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29715 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29717 (EventExpr): Set the type in the constructor itself since we
29718 are meant to be born fully resolved.
29720 (EventExpr.Define): Revert code I wrote earlier.
29722 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29723 instance expression is null. The instance expression is a This in that case
29724 or a null, depending on whether it is a static method or not.
29726 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29727 refers to more than one method.
29729 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29730 and accordingly flag errors.
29732 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29734 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29736 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29738 * location.cs (ToString): Provide useful rutine.
29740 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29742 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29743 objects, return the actual integral boxed.
29745 * statement.cs (SwitchLabel): define an ILLabel for each
29748 (Switch.CheckSwitch): If the value is a Literal, extract
29749 the underlying literal.
29751 Also in the unused hashtable we had, add the SwitchLabel so we can
29752 quickly look this value up.
29754 * constant.cs: Implement a bunch of new constants. Rewrite
29755 Literal based on this. Made changes everywhere to adapt to this.
29757 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29758 dereferencing array only once, and also copes with enumrations.
29760 bytes are two bytes wide, not one.
29762 (Cast): Perform constant conversions.
29764 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29765 wrappers to the literals here.
29767 * expression.cs (DoNumericPromotions): long literals can converted
29768 to ulong implicity (this is taken care of elsewhere, but I was
29769 missing this spot).
29771 * ecore.cs (Expression.Literalize): Make the return type Literal,
29772 to improve type checking.
29774 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29776 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29778 * literal.cs: Revert code from ravi that checked the bounds. The
29779 bounds are sane by the definition of the type itself.
29781 * typemanager.cs: Fix implementation of ImplementsInterface. We
29782 need to actually look up in our parent hierarchy for interfaces
29785 * const.cs: Use the underlying type for enumerations
29787 * delegate.cs: Compute the basename for the delegate creation,
29788 that should fix the delegate test case, and restore the correct
29789 Type Lookup semantics in rootcontext
29791 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29792 referencing a nested type with the Reflection API is using the "+"
29795 * cs-parser.jay: Do not require EOF token at the end.
29797 2001-12-20 Ravi Pratap <ravi@ximian.com>
29799 * rootcontext.cs (LookupType): Concatenate type names with
29800 a '.' instead of a '+' The test suite passes again.
29802 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29803 field of the enumeration.
29805 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29806 the case when the member is an EventExpr.
29808 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29809 static has an associated instance expression.
29811 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29813 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29815 * class.cs (Event.Define): Register event and perform appropriate checks
29818 We define the Add and Remove methods even if the use provides none because
29819 in that case, we provide default implementations ourselves.
29821 Define a private field of the type of the event. This is done by the CSC compiler
29822 and we should be doing it too ;-)
29824 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29825 More methods we use in code we generate.
29827 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29830 (InitCoreTypes): Update accordingly for the above.
29832 * class.cs (Event.Emit): Generate code for default accessors that we provide
29834 (EmitDefaultMethod): Do the job in the above.
29836 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29839 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29841 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29842 builders even if we were missing one.
29844 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29845 pass the Basename as our class name instead of the Name. The
29846 basename will be correctly composed for us.
29848 * parameter.cs (Paramters): Now takes a Location argument.
29850 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29851 make all the code call directly LookupType in RootContext and take
29852 this chance to pass the Location information everywhere.
29854 * Everywhere: pass Location information.
29856 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29858 * class.cs (Constructor.Define): Updated way of detecting the
29859 length of the parameters.
29861 (TypeContainer.DefineType): Use basename as the type name for
29864 (TypeContainer.Define): Do not recursively define types here, as
29865 definition is taken care in order by the RootContext.
29867 * tree.cs: Keep track of namespaces in a per-file basis.
29869 * parameter.cs (Parameter.ComputeSignature): Update to use
29872 (Parameters.GetSignature): ditto.
29874 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29875 instead of a TypeContainer.
29877 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29878 resolve names. Because we need to be resolve in our context, not
29881 * driver.cs: Implement response files.
29883 * class.cs (TypeContainer.DefineType): If we are defined, do not
29884 redefine ourselves.
29886 (Event.Emit): Emit the code for add/remove handlers.
29887 (Event.Define): Save the MethodBuilders for add/remove.
29889 * typemanager.cs: Use pair here too.
29891 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29892 DictionaryEntry requires the first argument to be non-null.
29894 (enum_declaration): Compute full name for registering the
29897 (delegate_declaration): Instead of using
29898 formal_parameter_list, use opt_formal_parameter_list as the list
29901 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29902 (EventParsing): New property that controls whether `add' and
29903 `remove' are returned as tokens or identifiers (for events);
29905 2001-12-19 Ravi Pratap <ravi@ximian.com>
29907 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29908 use MyEventBuilder only and let it wrap the real builder for us.
29910 (MyEventBuilder): Revamp constructor etc.
29912 Implement all operations that we perform on EventBuilder in precisely the same
29915 (FindMembers): Update to use the EventBuilder member.
29917 (Event.Emit): Update accordingly.
29919 2001-12-18 Ravi Pratap <ravi@ximian.com>
29921 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29922 by calling the appropriate methods.
29924 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29927 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29929 2001-12-17 Ravi Pratap <ravi@ximian.com>
29931 * delegate.cs (Delegate.Populate): Check that the return type
29932 and various parameters types are indeed accessible.
29934 * class.cs (Constructor.Define): Same here.
29936 (Field.Define): Ditto.
29938 (Event.Define): Ditto.
29940 (Operator.Define): Check that the underlying Method defined itself
29941 correctly - so it's MethodBuilder should not be null.
29943 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29944 expression happens to be null.
29946 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29947 members but as of now we don't seem to be able to do anything really useful with it.
29949 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29950 not the EventBuilder.
29952 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29954 * cs-tokenizer.cs: Add support for defines.
29955 Add support for #if, #elif, #else, #endif
29957 (eval_var): evaluates a variable.
29958 (eval): stubbed for evaluating functions.
29960 * cs-parser.jay: Pass the defines information
29962 * driver.cs: Add --define command line option.
29964 * decl.cs: Move MemberCore here.
29966 Make it the base class for DeclSpace. This allows us to catch and
29967 report 108 and 109 for everything now.
29969 * class.cs (TypeContainer.Define): Extract all the members
29970 before populating and emit the warning 108 (new keyword required
29971 to override) instead of having each member implement this.
29973 (MemberCore.Define): New abstract method, we will be using this in
29974 the warning reporting engine in Populate.
29976 (Operator.Define): Adjust to new MemberCore protocol.
29978 * const.cs (Const): This does not derive from Expression, it is a
29979 temporary object we use to create fields, it is a MemberCore.
29981 * class.cs (Method.Define): Allow the entry point to be in a
29984 * driver.cs: Rewrite the argument handler to clean it up a bit.
29986 * rootcontext.cs: Made it just an auxiliary namespace feature by
29987 making everything static.
29989 * driver.cs: Adapt code to use RootContext type name instead of
29992 * delegate.cs: Remove RootContext argument.
29994 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29997 * class.cs (Event.Define): The lookup can fail.
29999 * cs-tokenizer.cs: Begin implementation of pre-procesor.
30001 * expression.cs: Resolve the this instance before invoking the code.
30003 2001-12-17 Miguel de Icaza <miguel@ximian.com>
30005 * cs-parser.jay: Add a production in element_access that allows
30006 the thing to become a "type" reference. This way we can parse
30007 things like "(string [])" as a type.
30009 Note that this still does not handle the more complex rules of
30013 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
30015 * ecore.cs: (CopyNewMethods): new utility function used to
30016 assemble the list of methods from running FindMembers.
30018 (MemberLookup): Rework FindMembers so that
30020 2001-12-16 Miguel de Icaza <miguel@ximian.com>
30022 * class.cs (TypeContainer): Remove Delegates who fail to be
30025 * delegate.cs (Populate): Verify that we dont get null return
30026 values. TODO: Check for AsAccessible.
30028 * cs-parser.jay: Use basename to emit error 574 (destructor should
30029 have the same name as container class), not the full name.
30031 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
30032 possible representation.
30034 Also implements integer type suffixes U and L.
30036 2001-12-15 Miguel de Icaza <miguel@ximian.com>
30038 * expression.cs (ArrayCreation.DoResolve): We need to do the
30039 argument resolution *always*.
30041 * decl.cs: Make this hold the namespace. Hold the root context as
30043 (LookupType): Move here.
30045 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
30047 * location.cs (Row, Name): Fixed the code, it was always returning
30048 references to the first file.
30050 * interface.cs: Register properties defined through interfaces.
30052 * driver.cs: Add support for globbing on the command line
30054 * class.cs (Field): Make it derive from MemberCore as well.
30057 2001-12-15 Ravi Pratap <ravi@ximian.com>
30059 * class.cs (Event::Define): Check that the type of the event is a delegate
30060 type else flag error #66.
30062 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
30065 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
30066 values of EntryPoint, CharSet etc etc.
30068 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
30070 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
30071 be null and we should ignore this. I am not sure if this is really clean. Apparently,
30072 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
30073 which needs this to do its work.
30075 * ../errors/cs0066.cs : Add.
30077 2001-12-14 Miguel de Icaza <miguel@ximian.com>
30079 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
30082 * class.cs: (MethodSignature.MethodSignature): Removed hack that
30083 clears out the parameters field.
30084 (MemberSignatureCompare): Cleanup
30086 (MemberCore): New base class used to share code between MethodCore
30089 (RegisterRequiredImplementations) BindingFlags.Public requires
30090 either BindingFlags.Instace or Static. Use instance here.
30092 (Property): Refactored code to cope better with the full spec.
30094 * parameter.cs (GetParameterInfo): Return an empty array instead
30097 * class.cs (Property): Abstract or extern properties have no bodies.
30099 * parameter.cs (GetParameterInfo): return a zero-sized array.
30101 * class.cs (TypeContainer.MethodModifiersValid): Move all the
30102 method modifier validation to the typecontainer so we can reuse
30103 this on properties.
30105 (MethodCore.ParameterTypes): return an empty sized array of types.
30107 (Property.Define): Test property modifier validity.
30109 Add tests for sealed/override too.
30111 (Method.Emit): abstract or extern methods have no bodies.
30113 2001-12-14 Ravi Pratap <ravi@ximian.com>
30115 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
30118 (Method::Define, ::Emit): Modify accordingly.
30120 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
30122 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
30124 * makefile: Pass in /unsafe.
30126 2001-12-13 Miguel de Icaza <miguel@ximian.com>
30128 * class.cs (MakeKey): Kill routine.
30130 * class.cs (TypeContainer.Define): Correctly define explicit
30131 method implementations (they require the full interface name plus
30134 * typemanager.cs: Deply the PtrHashtable here and stop using the
30135 lame keys. Things work so much better.
30137 This of course broke everyone who depended on `RegisterMethod' to
30138 do the `test for existance' test. This has to be done elsewhere.
30140 * support.cs (PtrHashtable): A hashtable that avoid comparing with
30141 the object stupid Equals method (because, that like fails all over
30142 the place). We still do not use it.
30144 * class.cs (TypeContainer.SetRequiredInterface,
30145 TypeContainer.RequireMethods): Killed these two routines and moved
30146 all the functionality to RegisterRequiredImplementations.
30148 (TypeContainer.RegisterRequiredImplementations): This routine now
30149 registers all the implementations required in an array for the
30150 interfaces and abstract methods. We use an array of structures
30151 which can be computed ahead of time to reduce memory usage and we
30152 also assume that lookups are cheap as most classes will not
30153 implement too many interfaces.
30155 We also avoid creating too many MethodSignatures.
30157 (TypeContainer.IsInterfaceMethod): Update and optionally does not
30158 clear the "pending" bit if we find that there are problems with
30161 (TypeContainer.VerifyPendingMethods): Update to report errors of
30162 methods that look like implementations but are not.
30164 (TypeContainer.Define): Add support for explicit interface method
30167 2001-12-12 Miguel de Icaza <miguel@ximian.com>
30169 * typemanager.cs: Keep track of the parameters here instead of
30170 being a feature of the TypeContainer.
30172 * class.cs: Drop the registration of parameters here, as
30173 InterfaceMethods are also interface declarations.
30175 * delegate.cs: Register methods with the TypeManager not only with
30176 the TypeContainer. This code was buggy.
30178 * interface.cs: Full registation here.
30180 2001-12-11 Miguel de Icaza <miguel@ximian.com>
30182 * expression.cs: Remove reducer for binary expressions, it can not
30185 * const.cs: Put here the code that used to go into constant.cs
30187 * constant.cs: Put here the code for constants, this is a new base
30188 class for Literals.
30190 * literal.cs: Make Literal derive from Constant.
30192 2001-12-09 Miguel de Icaza <miguel@ximian.com>
30194 * statement.cs (Return.Emit): Report error 157 if the user
30195 attempts to return from a finally block.
30197 (Return.Emit): Instead of emitting a return, jump to the end of
30200 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
30201 LocalBuilder to store the result of the function. ReturnLabel is
30202 the target where we jump.
30205 2001-12-09 Radek Doulik <rodo@ximian.com>
30207 * cs-parser.jay: remember alias in current namespace
30209 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30212 * class.cs (LookupAlias): lookup alias in my_namespace
30214 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30216 (LookupAlias): lookup alias in this and if needed in parent
30219 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30223 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30224 making things static. I need this to avoid passing the
30225 TypeContainer when calling ParameterType.
30227 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30228 that did string manipulation to compute the type and then call
30229 GetType. Use Parameter.ParameterType instead.
30231 * cs-tokenizer.cs: Consume the suffix for floating values.
30233 * expression.cs (ParameterReference): figure out whether this is a
30234 reference parameter or not. Kill an extra variable by computing
30235 the arg_idx during emission.
30237 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30238 function that returns whether a parameter is an out/ref value or not.
30240 (Parameter.ParameterType): The type of the parameter (base,
30241 without ref/out applied).
30243 (Parameter.Resolve): Perform resolution here.
30244 (Parameter.ExternalType): The full type (with ref/out applied).
30246 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30247 support for expressions on the using statement.
30249 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30251 * statement.cs (Using.EmitLocalVariableDecls): Split the
30252 localvariable handling of the using statement.
30254 (Block.EmitMeta): Keep track of variable count across blocks. We
30255 were reusing slots on separate branches of blocks.
30257 (Try.Emit): Emit the general code block, we were not emitting it.
30259 Check the type of the declaration to be an IDisposable or
30260 something that can be implicity converted to it.
30262 Emit conversions if required.
30264 * ecore.cs (EmptyExpression): New utility class.
30265 (Expression.ImplicitConversionExists): New utility function.
30267 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30269 * statement.cs (Using): Implement.
30271 * expression.cs (LocalVariableReference): Support read only variables.
30273 * statement.cs: Remove the explicit emit for the Leave opcode.
30274 (VariableInfo): Add a readonly field.
30276 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30278 * ecore.cs (ConvCast): new class used to encapsulate the various
30279 explicit integer conversions that works in both checked and
30280 unchecked contexts.
30282 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30283 properly generate the overflow opcodes.
30285 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30287 * statement.cs: The correct type for the EmptyExpression is the
30288 element_type, not the variable type. Ravi pointed this out.
30290 2001-12-04 Ravi Pratap <ravi@ximian.com>
30292 * class.cs (Method::Define): Handle PInvoke methods specially
30293 by using DefinePInvokeMethod instead of the usual one.
30295 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30296 above to do the task of extracting information and defining the method.
30298 2001-12-04 Ravi Pratap <ravi@ximian.com>
30300 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30301 of the condition for string type.
30303 (Emit): Move that here.
30305 (ArrayCreation::CheckIndices): Keep string literals in their expression
30308 (EmitDynamicInitializers): Handle strings appropriately.
30310 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30312 * codegen.cs (EmitContext): Replace multiple variables with a
30313 single pointer to the current Switch statement.
30315 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30318 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30322 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30325 (Foreach.Emit): Foreach on arrays was not setting
30326 up the loop variables (for break/continue).
30328 (GotoCase): Semi-implented.
30330 2001-12-03 Ravi Pratap <ravi@ximian.com>
30332 * attribute.cs (CheckAttribute): Handle system attributes by using
30333 Attribute.GetAttributes to examine information we need.
30335 (GetValidPlaces): Same here.
30337 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30339 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30341 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30343 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30345 (Method::Emit): Handle the case when we are a PInvoke method.
30347 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30349 * expression.cs: Use ResolveWithSimpleName on compound names.
30351 2001-12-02 Ravi Pratap <ravi@ximian.com>
30353 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30354 before trying to reduce it.
30356 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30358 * constant.cs (LookupConstantValue): Implement.
30360 (EmitConstant): Use the above in emitting the constant.
30362 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30363 that are user-defined by doing a LookupConstantValue on them.
30365 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30368 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30370 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30372 (BaseAccess.DoResolve): Implement.
30374 (MemberAccess.DoResolve): Split this routine into a
30375 ResolveMemberAccess routine that can be used independently
30377 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30379 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30380 As that share bits of the implementation. Is returns a boolean,
30381 while As returns the Type that is being probed.
30383 2001-12-01 Ravi Pratap <ravi@ximian.com>
30385 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30386 instead of a Literal - much easier.
30388 (EnumInTransit): Remove - utterly useless :-)
30390 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30392 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30394 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30395 chain when we have no associated expression.
30397 2001-11-30 Ravi Pratap <ravi@ximian.com>
30399 * constant.cs (Define): Use Location while reporting the errror.
30401 Also emit a warning when 'new' is used and there is no inherited
30404 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30407 (LookupEnumValue): Implement to lookup an enum member's value and define it
30410 (Populate): Re-write accordingly to use the above routine.
30412 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30414 * expression.cs (This): Fix prototype for DoResolveLValue to
30415 override the base class DoResolveLValue.
30417 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30420 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30421 (we need to load the address of the field here). This fixes
30424 (FieldExpr.DoResolveLValue): Call the DoResolve
30425 function to initialize the Instance expression.
30427 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30428 correctly the GetEnumerator operation on a value type.
30430 * cs-parser.jay: Add more simple parsing error catches.
30432 * statement.cs (Switch): Add support for string switches.
30433 Handle null specially.
30435 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30437 2001-11-28 Ravi Pratap <ravi@ximian.com>
30439 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30441 (declare_local_constant): New helper function.
30443 * statement.cs (AddConstant): Keep a separate record of constants
30445 (IsConstant): Implement to determine if a variable is a constant.
30447 (GetConstantExpression): Implement.
30449 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30451 * statement.cs (IsVariableDefined): Re-write.
30453 2001-11-27 Ravi Pratap <ravi@ximian.com>
30455 * class.cs (TypeContainer::FindMembers): Look for constants
30456 in the case when we are looking for MemberTypes.Field
30458 * expression.cs (MemberAccess::DoResolve): Check that in the
30459 case we are a FieldExpr and a Literal, we are not being accessed
30460 by an instance reference.
30462 * cs-parser.jay (local_constant_declaration): Implement.
30464 (declaration_statement): Implement for constant declarations.
30466 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30468 * statement.cs (Switch): Catch double defaults.
30470 (Switch): More work on the switch() statement
30471 implementation. It works for integral values now, need to finish
30475 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30477 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30478 integer literals into other integer literals. To be used by
30481 2001-11-24 Ravi Pratap <ravi@ximian.com>
30483 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30486 (EmitDynamicInitializers): Cope with the above since we extract data
30487 directly from ArrayData now.
30489 (ExpectInitializers): Keep track of whether initializers are mandatory
30492 (Bounds): Make it a hashtable to prevent the same dimension being
30493 recorded for every element in that dimension.
30495 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30498 Also fix bug which was causing the indices to be emitted in the reverse
30501 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30503 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30504 unfinished. They do not work, because the underlying code is
30507 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30509 * cs-parser.jay: Remove bogus fixme.
30511 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30512 on Switch statement.
30514 2001-11-23 Ravi Pratap <ravi@ximian.com>
30516 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30519 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30520 parameter. Apparently, any expression is allowed.
30522 (ValidateInitializers): Update accordingly.
30524 (CheckIndices): Fix some tricky bugs thanks to recursion.
30526 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30527 I was being completely brain-dead.
30529 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30530 and re-write acordingly.
30532 (DelegateInvocation): Re-write accordingly.
30534 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30536 (MakeByteBlob): Handle types more correctly.
30538 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30539 initialization from expressions but it is incomplete because I am a complete
30542 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30544 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30545 on If. Basically, we have to return `true' (ie, we do return to
30546 our caller) only if both branches of the if return.
30548 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30549 short-circuit operators, handle them as short circuit operators.
30551 (Cast.DoResolve): Resolve type.
30552 (Cast.Cast): Take an expression as the target type.
30554 * cs-parser.jay (cast_expression): Remove old hack that only
30555 allowed a limited set of types to be handled. Now we take a
30556 unary_expression and we resolve to a type during semantic
30559 Use the grammar productions from Rhys to handle casts (this is
30560 not complete like Rhys syntax yet, we fail to handle that corner
30561 case that C# has regarding (-x), but we will get there.
30563 2001-11-22 Ravi Pratap <ravi@ximian.com>
30565 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30566 field which is an array type.
30568 * cs-parser.jay (declare_local_variables): Support array initialization too.
30570 * typemanager.cs (MakeKey): Implement.
30572 (everywhere): Use the above appropriately.
30574 * cs-parser.jay (for_statement): Update for array initialization while
30575 declaring variables.
30577 * ecore.cs : The error message was correct, it's the variable's names that
30578 were misleading ;-) Make the code more readable.
30580 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30581 the correct type etc.
30583 (ConvertExplicit): Handle Enum types by examining the underlying type.
30585 2001-11-21 Ravi Pratap <ravi@ximian.com>
30587 * parameter.cs (GetCallingConvention): Always return
30588 CallingConventions.Standard for now.
30590 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30592 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30593 and `r' after calling DoNumericPromotions.
30595 * ecore.cs: Fix error message (the types were in the wrong order).
30597 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30598 BindingFlags.Instance as well
30600 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30601 implicit int literal conversion in an empty cast so that we
30602 propagate the right type upstream.
30604 (UnboxCast): new class used to unbox value types.
30605 (Expression.ConvertExplicit): Add explicit type conversions done
30608 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30609 the target type before applying the implicit LongLiterals to ULong
30612 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30614 * cs-parser.jay (for_statement): Reworked the way For works: now
30615 we declare manually any variables that are introduced in
30616 for_initializer to solve the problem of having out-of-band code
30617 emition (that is what got for broken).
30619 (declaration_statement): Perform the actual variable declaration
30620 that used to be done in local_variable_declaration here.
30622 (local_variable_declaration): Do not declare anything, just pass
30623 the information on a DictionaryEntry
30625 2001-11-20 Ravi Pratap <ravi@ximian.com>
30627 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30628 re-write of the logic to now make it recursive.
30630 (UpdateIndices): Re-write accordingly.
30632 Store element data in a separate ArrayData list in the above methods.
30634 (MakeByteBlob): Implement to dump the array data into a byte array.
30636 2001-11-19 Ravi Pratap <ravi@ximian.com>
30638 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30641 * constant.cs (Define): Implement.
30643 (EmitConstant): Re-write fully.
30645 Pass in location info.
30647 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30650 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30651 DictionaryEntry since we need location info too.
30653 (constant_declaration): Update accordingly.
30655 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30656 code into another method : UpdateIndices.
30658 2001-11-18 Ravi Pratap <ravi@ximian.com>
30660 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30661 some type checking etc.
30663 2001-11-17 Ravi Pratap <ravi@ximian.com>
30665 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30666 bits to provide dimension info if the user skips doing that.
30668 Update second constructor to store the rank correctly.
30670 2001-11-16 Ravi Pratap <ravi@ximian.com>
30672 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30673 and try to implement.
30675 * ../errors/cs0150.cs : Add.
30677 * ../errors/cs0178.cs : Add.
30679 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30681 * statement.cs: Implement foreach on multi-dimensional arrays.
30683 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30684 name of the params argument.
30686 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30687 initializing the array.
30689 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30690 we can use this elsewhere.
30692 * statement.cs: Finish implementation of foreach for single
30695 * cs-parser.jay: Use an out-of-band stack to pass information
30696 around, I wonder why I need this.
30698 foreach_block: Make the new foreach_block the current_block.
30700 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30701 function used to return a static Parameters structure. Used for
30702 empty parameters, as those are created very frequently.
30704 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30706 2001-11-15 Ravi Pratap <ravi@ximian.com>
30708 * interface.cs : Default modifier is private, not public. The
30709 make verify test passes again.
30711 2001-11-15 Ravi Pratap <ravi@ximian.com>
30713 * support.cs (ReflectionParameters): Fix logic to determine
30714 whether the last parameter is a params one. Test 9 passes again.
30716 * delegate.cs (Populate): Register the builders we define with
30717 RegisterParameterForBuilder. Test 19 passes again.
30719 * cs-parser.jay (property_declaration): Reference $6 instead
30720 of $$ to get at the location.
30722 (indexer_declaration): Similar stuff.
30724 (attribute): Ditto.
30726 * class.cs (Property): Register parameters for the Get and Set methods
30727 if they exist. Test 23 passes again.
30729 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30730 call to EmitArguments as we are sure there aren't any params arguments.
30731 Test 32 passes again.
30733 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30734 IndexOutOfRangeException.
30736 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30737 Test 33 now passes again.
30739 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30741 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30742 broke a bunch of things. Will have to come up with a better way
30743 of tracking locations.
30745 * statement.cs: Implemented foreach for single dimension arrays.
30747 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30749 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30750 an error. This removes the lookup from the critical path.
30752 * cs-parser.jay: Removed use of temporary_loc, which is completely
30755 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30757 * support.cs (ReflectionParameters.ParameterModifier): Report
30758 whether the argument is a PARAMS argument or not.
30760 * class.cs: Set the attribute `ParamArrayAttribute' on the
30761 parameter argument.
30763 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30764 and cons_param_array_attribute (ConstructorInfo for
30765 ParamArrayAttribute).,
30767 * codegen.cs: Emit the return using the `Return' statement, that
30768 way we can report the error correctly for missing return values.
30770 * class.cs (Method.Emit): Clean up.
30772 * expression.cs (Argument.Resolve): Take another argument: the
30773 location where this argument is used. Notice that this is not
30774 part of the "Argument" class as to reduce the size of the
30775 structure (we know the approximate location anyways).
30777 Test if the argument is a variable-reference, if not, then
30778 complain with a 206.
30780 (Argument.Emit): Emit addresses of variables.
30782 (Argument.FullDesc): Simplify.
30784 (Invocation.DoResolve): Update for Argument.Resolve.
30786 (ElementAccess.DoResolve): ditto.
30788 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30789 method should be virtual, as this method is always virtual.
30791 (NewDelegate.DoResolve): Update for Argument.Resolve.
30793 * class.cs (ConstructorInitializer.DoResolve): ditto.
30795 * attribute.cs (Attribute.Resolve): ditto.
30797 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30799 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30801 * expression.cs (ParameterReference): Drop IStackStorage and implement
30802 IAssignMethod instead.
30804 (LocalVariableReference): ditto.
30806 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30807 IAssignMethod instead.
30809 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30811 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30812 enumerations that are used in heavily used structures derive from
30813 byte in a laughable and pathetic attempt to reduce memory usage.
30814 This is the kind of pre-optimzations that you should not do at
30815 home without adult supervision.
30817 * expression.cs (UnaryMutator): New class, used to handle ++ and
30818 -- separatedly from the other unary operators. Cleans up the
30819 code, and kills the ExpressionStatement dependency in Unary.
30821 (Unary): Removed `method' and `Arguments' from this class, making
30822 it smaller, and moving it all to SimpleCall, so I can reuse this
30823 code in other locations and avoid creating a lot of transient data
30824 strucutres when not required.
30826 * cs-parser.jay: Adjust for new changes.
30828 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30830 * enum.cs (Enum.Populate): If there is a failure during
30833 * cs-parser.jay (opt_enum_base): we used to catch type errors
30834 here, but this is really incorrect. The type error should be
30835 catched during semantic analysis.
30837 2001-12-11 Ravi Pratap <ravi@ximian.com>
30839 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30840 current_local_parameters as expected since I, in my stupidity, had forgotten
30843 * attribute.cs (GetValidPlaces): Fix stupid bug.
30845 * class.cs (Method::Emit): Perform check on applicability of attributes.
30847 (Constructor::Emit): Ditto.
30849 (Field::Emit): Ditto.
30851 (Field.Location): Store location information.
30853 (Property, Event, Indexer, Operator): Ditto.
30855 * cs-parser.jay (field_declaration): Pass in location for each field.
30857 * ../errors/cs0592.cs : Add.
30859 2001-11-12 Ravi Pratap <ravi@ximian.com>
30861 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30863 (InitCoreTypes): Update accordingly.
30865 (RegisterAttrType, LookupAttr): Implement.
30867 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30868 info about the same.
30870 (Resolve): Update to populate the above as necessary.
30872 (Error592): Helper.
30874 (GetValidPlaces): Helper to the above.
30876 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30878 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30880 2001-11-12 Ravi Pratap <ravi@ximian.com>
30882 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30884 * ../errors/cs0617.cs : Add.
30886 2001-11-11 Ravi Pratap <ravi@ximian.com>
30888 * enum.cs (Emit): Rename to Populate to be more consistent with what
30889 we expect it to do and when exactly it is called.
30891 * class.cs, rootcontext.cs : Update accordingly.
30893 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30894 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30896 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30898 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30899 of a fieldinfo using the above, when dealing with a FieldBuilder.
30901 2001-11-10 Ravi Pratap <ravi@ximian.com>
30903 * ../errors/cs0031.cs : Add.
30905 * ../errors/cs1008.cs : Add.
30907 * ../errrors/cs0543.cs : Add.
30909 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30912 (FindMembers): Implement.
30914 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30915 enums and delegates too.
30917 (enum_types): Rename to builder_to_enum.
30919 (delegate_types): Rename to builder_to_delegate.
30921 * delegate.cs (FindMembers): Implement.
30923 2001-11-09 Ravi Pratap <ravi@ximian.com>
30925 * typemanager.cs (IsEnumType): Implement.
30927 * enum.cs (Emit): Re-write parts to account for the underlying type
30928 better and perform checking etc.
30930 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30931 of the underlying type.
30933 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30936 * enum.cs (error31): Helper to report error #31.
30938 * cs-parser.jay (enum_declaration): Store location of each member too.
30940 * enum.cs (member_to_location): New hashtable.
30942 (AddEnumMember): Update location hashtable.
30944 (Emit): Use the location of each member while reporting errors.
30946 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30948 * cs-parser.jay: A for_initializer if is a
30949 local_variable_declaration really ammount to have an implicit
30950 block with the variable declaration and no initializer for for.
30952 * statement.cs (For.Emit): Cope with null initializers.
30954 This fixes the infinite loop on for initializers.
30956 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30958 * enum.cs: More cleanup.
30960 * ecore.cs: Remove dead code.
30962 * class.cs (Property.Emit): More simplification.
30963 (Event.Emit): ditto.
30965 Reworked to have less levels of indentation.
30967 2001-11-08 Ravi Pratap <ravi@ximian.com>
30969 * class.cs (Property): Emit attributes.
30979 * enum.cs (Emit): Ditto.
30981 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30984 * class.cs (Field, Event, etc.): Move attribute generation into the
30985 Emit method everywhere.
30987 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30988 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30989 as we had no way of defining nested enums !
30991 * rootcontext.cs : Adjust code accordingly.
30993 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30995 2001-11-07 Ravi Pratap <ravi@ximian.com>
30997 * expression.cs (EvalConstantExpression): Move into ecore.cs
30999 * enum.cs (Enum): Rename some members and make them public and readonly
31000 according to our convention.
31002 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
31005 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
31007 (Enum::Emit): Write a simple version for now which doesn't try to compute
31008 expressions. I shall modify this to be more robust in just a while.
31010 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
31012 (TypeContainer::CloseType): Create the Enum types too.
31014 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
31016 * expression.cs (EvalConstantExpression): Get rid of completely.
31018 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
31019 user-defined values and other cases.
31021 (IsValidEnumLiteral): Helper function.
31023 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
31024 out there in the case we had a literal FieldExpr.
31026 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
31028 (Literalize): Revamp a bit to take two arguments.
31030 (EnumLiteral): New class which derives from Literal to wrap enum literals.
31032 2001-11-06 Ravi Pratap <ravi@ximian.com>
31034 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
31036 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
31038 (Resolve): Use the above to ensure we have proper initializers.
31040 2001-11-05 Ravi Pratap <ravi@ximian.com>
31042 * expression.cs (Expression::EvalConstantExpression): New method to
31043 evaluate constant expressions.
31045 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
31047 2001-11-07 Miguel de Icaza <miguel@ximian.com>
31049 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
31052 (Binary.ResolveOperator): Handle operator != (object a, object b)
31053 and operator == (object a, object b);
31055 (Binary.DoNumericPromotions): Indicate whether the numeric
31056 promotion was possible.
31058 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
31061 Made the ArrayAccess implement interface IAssignMethod instead of
31062 IStackStore as the order in which arguments are passed reflects
31065 * assign.cs: Instead of using expr.ExprClass to select the way of
31066 assinging, probe for the IStackStore/IAssignMethod interfaces.
31068 * typemanager.cs: Load InitializeArray definition.
31070 * rootcontext.cs (RootContext.MakeStaticData): Used to define
31071 static data that can be used to initialize arrays.
31073 2001-11-05 Miguel de Icaza <miguel@ximian.com>
31075 * expression.cs: Handle operator== and operator!= for booleans.
31077 (Conditioal.Reduce): Implement reducer for the ?: operator.
31079 (Conditional.Resolve): Implement dead code elimination.
31081 (Binary.Resolve): Catch string literals and return a new
31082 concatenated string.
31084 (Unary.Reduce): Implement reduction of unary expressions.
31086 * ecore.cs: Split out the expression core handling here.
31088 (Expression.Reduce): New method used to perform constant folding
31089 and CSE. This is needed to support constant-expressions.
31091 * statement.cs (Statement.EmitBoolExpression): Pass true and false
31092 targets, and optimize for !x.
31094 2001-11-04 Ravi Pratap <ravi@ximian.com>
31096 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
31097 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
31098 set custom atttributes.
31100 * literal.cs (Literal::GetValue): New abstract method to return the actual
31101 value of the literal, cast as an object.
31103 (*Literal): Implement GetValue method.
31105 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
31106 expressions to the arraylist but objects of type Argument.
31108 * class.cs (TypeContainer::Emit): Emit our attributes too.
31110 (Method::Emit, Constructor::Emit): Ditto.
31112 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
31113 to be ignoring earlier.
31115 2001-11-03 Ravi Pratap <ravi@ximian.com>
31117 * attribute.cs (AttributeSection::Define): Implement to do the business
31118 of constructing a CustomAttributeBuilder.
31120 (Attribute): New trivial class. Increases readability of code.
31122 * cs-parser.jay : Update accordingly.
31124 (positional_argument_list, named_argument_list, named_argument): New rules
31126 (attribute_arguments): Use the above so that we are more correct.
31128 2001-11-02 Ravi Pratap <ravi@ximian.com>
31130 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
31131 to perform all checks for a method with a params parameter.
31133 (Invocation::OverloadResolve): Update to use the above method and therefore
31134 cope correctly with params method invocations.
31136 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
31139 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
31140 constructors in our parent too because we can't afford to miss out on
31143 * attribute.cs (AttributeSection): New name for the class Attribute
31145 Other trivial changes to improve readability.
31147 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
31148 use the new class names.
31150 2001-11-01 Ravi Pratap <ravi@ximian.com>
31152 * class.cs (Method::Define): Complete definition for params types too
31154 (Indexer::Define): Ditto.
31156 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
31157 Cope everywhere with a request for info about the array parameter.
31159 2001-11-01 Ravi Pratap <ravi@ximian.com>
31161 * tree.cs (RecordNamespace): Fix up to check for the correct key.
31163 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
31164 local_variable_type to extract the string corresponding to the type.
31166 (local_variable_type): Fixup the action to use the new helper method.
31168 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
31171 * expression.cs : Clean out code which uses the above.
31173 2001-10-31 Ravi Pratap <ravi@ximian.com>
31175 * typemanager.cs (RegisterMethod): Check if we already have an existing key
31176 and bale out if necessary by returning a false.
31178 (RegisterProperty): Ditto.
31180 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
31181 and print out appropriate error messages.
31183 * interface.cs (everywhere): Ditto.
31185 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
31186 location to constructor.
31188 * class.cs (Property, Event, Indexer): Update accordingly.
31190 * ../errors/cs111.cs : Added.
31192 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
31193 of a method, as laid down by the spec.
31195 (Invocation::OverloadResolve): Use the above method.
31197 2001-10-31 Ravi Pratap <ravi@ximian.com>
31199 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
31200 now take a TypeContainer and a Parameters object.
31202 (ParameterData): Modify return type of ParameterModifier method to be
31203 Parameter.Modifier and not a string.
31205 (ReflectionParameters, InternalParameters): Update accordingly.
31207 * expression.cs (Argument::GetParameterModifier): Same here.
31209 * support.cs (InternalParameters::ParameterType): Find a better way of determining
31210 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31211 symbol in it at all so maybe this is only for now.
31213 2001-10-30 Ravi Pratap <ravi@ximian.com>
31215 * support.cs (InternalParameters): Constructor now takes an extra argument
31216 which is the actual Parameters class.
31218 (ParameterDesc): Update to provide info on ref/out modifiers.
31220 * class.cs (everywhere): Update call to InternalParameters to pass in
31221 the second argument too.
31223 * support.cs (ParameterData): Add ParameterModifier, which is a method
31224 to return the modifier info [ref/out etc]
31226 (InternalParameters, ReflectionParameters): Implement the above.
31228 * expression.cs (Argument::ParameterModifier): Similar function to return
31229 info about the argument's modifiers.
31231 (Invocation::OverloadResolve): Update to take into account matching modifiers
31234 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31235 a new SetFormalParameters object which we pass to InternalParameters.
31237 2001-10-30 Ravi Pratap <ravi@ximian.com>
31239 * expression.cs (NewArray): Merge into the ArrayCreation class.
31241 2001-10-29 Ravi Pratap <ravi@ximian.com>
31243 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31244 NewUserdefinedArray into one as there wasn't much of a use in having
31247 * expression.cs (Argument): Change field's name to ArgType from Type.
31249 (Type): New readonly property which returns the proper type, taking into
31250 account ref/out modifiers.
31252 (everywhere): Adjust code accordingly for the above.
31254 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31255 whether we are emitting for a ref or out parameter.
31257 * expression.cs (Argument::Emit): Use the above field to set the state.
31259 (LocalVariableReference::Emit): Update to honour the flag and emit the
31262 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31264 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31266 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31268 (ReflectionParameters, InternalParameters): Implement the above method.
31270 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31273 (Invocation::FullMethodDesc): Ditto.
31275 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31277 * cs-parser.jay: Add extra production for the second form of array
31280 * expression.cs (ArrayCreation): Update to reflect the above
31283 * Small changes to prepare for Array initialization.
31285 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31287 * typemanager.cs (ImplementsInterface): interface might be null;
31288 Deal with this problem;
31290 Also, we do store negative hits on the cache (null values), so use
31291 this instead of calling t.GetInterfaces on the type everytime.
31293 2001-10-28 Ravi Pratap <ravi@ximian.com>
31295 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31297 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31298 split functionality out into different classes.
31300 (New::FormArrayType): Move into NewBuiltinArray.
31302 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31305 (NewBuiltinArray): New class to handle creation of built-in arrays.
31307 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31308 account creation of one-dimensional arrays.
31310 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31312 (NewUserdefinedArray::DoResolve): Implement.
31314 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31316 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31317 we maintain inside the TypeManager. This is necessary to perform lookups on the
31320 (LookupType): Update to perform GetType on the module builders too.
31322 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31324 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31326 2001-10-23 Ravi Pratap <ravi@ximian.com>
31328 * expression.cs (New::DoResolve): Implement guts of array creation.
31330 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31332 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31334 * expression.cs: Fix bug I introduced lsat night that broke
31337 (Expression.Resolve): Report a 246 error (can not resolve name)
31338 if we find a SimpleName in the stream.
31340 (Expression.ResolveLValue): Ditto.
31342 (Expression.ResolveWithSimpleName): This function is a variant of
31343 ResolveName, this one allows SimpleNames to be returned without a
31344 warning. The only consumer of SimpleNames is MemberAccess
31346 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31348 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31349 might arrive here. I have my doubts that this is correct.
31351 * statement.cs (Lock): Implement lock statement.
31353 * cs-parser.jay: Small fixes to support `lock' and `using'
31355 * cs-tokenizer.cs: Remove extra space
31357 * driver.cs: New flag --checked, allows to turn on integer math
31360 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31361 Threading.Monitor.Exit
31363 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31365 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31366 Expression Class to be IndexerAccess.
31368 Notice that Indexer::DoResolve sets the eclass to Value.
31370 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31372 * class.cs (TypeContainer::Emit): Emit code for indexers.
31374 * assign.cs (IAssignMethod): New interface implemented by Indexers
31375 and Properties for handling assignment.
31377 (Assign::Emit): Simplify and reuse code.
31379 * expression.cs (IndexerAccess, PropertyExpr): Implement
31380 IAssignMethod, clean up old code.
31382 2001-10-22 Ravi Pratap <ravi@ximian.com>
31384 * typemanager.cs (ImplementsInterface): New method to determine if a type
31385 implements a given interface. Provides a nice cache too.
31387 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31390 (ConvertReferenceExplicit): Ditto.
31392 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31393 various methods, with correct names etc.
31395 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31396 Operator.UnaryNegation.
31398 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31399 we have a unary plus or minus operator.
31401 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31404 * everywhere : update accordingly.
31406 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31409 * class.cs (Method::Define): For the case where we are implementing a method
31410 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31411 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31413 2001-10-21 Ravi Pratap <ravi@ximian.com>
31415 * interface.cs (FindMembers): Implement to work around S.R.E
31418 * typemanager.cs (IsInterfaceType): Implement.
31420 (FindMembers): Update to handle interface types too.
31422 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31423 use IsAssignableFrom as that is not correct - it doesn't work.
31425 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31426 and accordingly override EmitStatement.
31428 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31429 using the correct logic :-)
31431 2001-10-19 Ravi Pratap <ravi@ximian.com>
31433 * ../errors/cs-11.cs : Add to demonstrate error -11
31435 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31437 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31438 then pass this as a hint to ResolveLValue.
31440 * expression.cs (FieldExpr): Add Location information
31442 (FieldExpr::LValueResolve): Report assignment to readonly
31445 (Expression::ExprClassFromMemberInfo): Pass location information.
31447 (Expression::ResolveLValue): Add new method that resolves an
31450 (Expression::DoResolveLValue): Default invocation calls
31453 (Indexers): New class used to keep track of indexers in a given
31456 (IStackStore): Renamed from LValue, as it did not really describe
31457 what this did. Also ResolveLValue is gone from this interface and
31458 now is part of Expression.
31460 (ElementAccess): Depending on the element access type
31462 * typemanager.cs: Add `indexer_name_type' as a Core type
31463 (System.Runtime.CompilerServices.IndexerNameAttribute)
31465 * statement.cs (Goto): Take a location.
31467 2001-10-18 Ravi Pratap <ravi@ximian.com>
31469 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31470 if two delegates are compatible.
31472 (NewDelegate::DoResolve): Update to take care of the case when
31473 we instantiate a delegate from another delegate.
31475 * typemanager.cs (FindMembers): Don't even try to look up members
31476 of Delegate types for now.
31478 2001-10-18 Ravi Pratap <ravi@ximian.com>
31480 * delegate.cs (NewDelegate): New class to take care of delegate
31483 * expression.cs (New): Split the delegate related code out into
31484 the NewDelegate class.
31486 * delegate.cs (DelegateInvocation): New class to handle delegate
31489 * expression.cs (Invocation): Split out delegate related code into
31490 the DelegateInvocation class.
31492 2001-10-17 Ravi Pratap <ravi@ximian.com>
31494 * expression.cs (New::DoResolve): Implement delegate creation fully
31495 and according to the spec.
31497 (New::DoEmit): Update to handle delegates differently.
31499 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31500 because of which we were printing out arguments in reverse order !
31502 * delegate.cs (VerifyMethod): Implement to check if the given method
31503 matches the delegate.
31505 (FullDelegateDesc): Implement.
31507 (VerifyApplicability): Implement.
31509 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31510 delegate invocations too.
31512 (Invocation::Emit): Ditto.
31514 * ../errors/cs1593.cs : Added.
31516 * ../errors/cs1594.cs : Added.
31518 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31520 2001-10-16 Ravi Pratap <ravi@ximian.com>
31522 * typemanager.cs (intptr_type): Core type for System.IntPtr
31524 (InitCoreTypes): Update for the same.
31526 (iasyncresult_type, asynccallback_type): Ditto.
31528 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31531 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31534 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31535 the builders for the 4 members of a delegate type :-)
31537 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31540 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31542 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31544 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31546 * statement.cs (Break::Emit): Implement.
31547 (Continue::Emit): Implement.
31549 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31550 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31551 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31552 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31555 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31556 properties that track the label for the current loop (begin of the
31557 loop and end of the loop).
31559 2001-10-15 Ravi Pratap <ravi@ximian.com>
31561 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31562 use of emitting anything at all.
31564 * class.cs, rootcontext.cs : Get rid of calls to the same.
31566 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31568 (Populate): Define the constructor correctly and set the implementation
31571 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31574 (AddDelegateType): Implement.
31576 (IsDelegateType): Implement helper method.
31578 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31580 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31581 and accordingly handle it.
31583 * delegate.cs (Populate): Take TypeContainer argument.
31584 Implement bits to define the Invoke method. However, I still haven't figured out
31585 how to take care of the native int bit :-(
31587 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31588 Qualify the name of the delegate, not its return type !
31590 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31593 (StandardConversionExists): Checking for array types turns out to be recursive.
31595 (ConvertReferenceExplicit): Implement array conversion.
31597 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31599 2001-10-12 Ravi Pratap <ravi@ximian.com>
31601 * cs-parser.jay (delegate_declaration): Store the fully qualified
31602 name as it is a type declaration.
31604 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31607 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31608 as TypeContainer::DefineType.
31610 (Populate): Method in which all the definition of the various methods (Invoke)
31613 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31616 (CloseDelegate): Finally creates the delegate.
31618 * class.cs (TypeContainer::DefineType): Update to define delegates.
31619 (Populate, Emit and CloseType): Do the same thing here too.
31621 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31622 delegates in all these operations.
31624 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31626 * expression.cs: LocalTemporary: a new expression used to
31627 reference a temporary that has been created.
31629 * assign.cs: Handle PropertyAccess back here, so that we can
31630 provide the proper semantic access to properties.
31632 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31633 a few more explicit conversions.
31635 * modifiers.cs: `NEW' modifier maps to HideBySig.
31637 * expression.cs (PropertyExpr): Make this into an
31638 ExpressionStatement, and support the EmitStatement code path.
31640 Perform get/set error checking, clean up the interface.
31642 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31643 them into toplevel access objects.
31645 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31647 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31650 * typemanager.cs: Keep track here of our PropertyBuilders again to
31651 work around lameness in SRE.
31653 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31655 * expression.cs (LValue::LValueResolve): New method in the
31656 interface, used to perform a second resolution pass for LValues.
31658 (This::DoResolve): Catch the use of this in static methods.
31660 (This::LValueResolve): Implement.
31662 (This::Store): Remove warning, assigning to `this' in structures
31665 (Invocation::Emit): Deal with invocation of
31666 methods on value types. We need to pass the address to structure
31667 methods rather than the object itself. (The equivalent code to
31668 emit "this" for structures leaves the entire structure on the
31669 stack instead of a pointer to it).
31671 (ParameterReference::DoResolve): Compute the real index for the
31672 argument based on whether the method takes or not a `this' pointer
31673 (ie, the method is static).
31675 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31676 value types returned from functions when we need to invoke a
31677 method on the sturcture.
31680 2001-10-11 Ravi Pratap <ravi@ximian.com>
31682 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31683 defining the type in the Modulebuilder or Typebuilder. This is to take
31684 care of nested types which need to be defined on the TypeBuilder using
31685 DefineNestedMethod.
31687 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31688 methods in RootContext, only ported to be part of TypeContainer.
31690 (TypeContainer::GetInterfaceOrClass): Ditto.
31692 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31694 * interface.cs (Interface::DefineInterface): New method. Does exactly
31695 what RootContext.CreateInterface did earlier, only it takes care of nested types
31698 (Interface::GetInterfaces): Move from RootContext here and port.
31700 (Interface::GetInterfaceByName): Same here.
31702 * rootcontext.cs (ResolveTree): Re-write.
31704 (PopulateTypes): Re-write.
31706 * class.cs (TypeContainer::Populate): Populate nested types too.
31707 (TypeContainer::Emit): Emit nested members too.
31709 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31710 instead just use the name argument passed in as it is already fully
31713 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31714 to TypeContainer mapping to see if a type is user-defined.
31716 * class.cs (TypeContainer::CloseType): Implement.
31718 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31719 the default constructor.
31721 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31724 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31726 * interface.cs (CloseType): Create the type here.
31728 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31731 Remove all the methods which are now in TypeContainer.
31733 2001-10-10 Ravi Pratap <ravi@ximian.com>
31735 * delegate.cs (Define): Re-write bits to define the delegate
31738 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31740 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31742 * expression.cs (ImplicitReferenceConversion): handle null as well
31743 as a source to convert to any reference type.
31745 * statement.cs (Return): Perform any implicit conversions to
31746 expected return type.
31748 Validate use of return statement.
31750 * codegen.cs (EmitContext): Pass the expected return type here.
31752 * class.cs (Method, Constructor, Property): Pass expected return
31753 type to EmitContext.
31755 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31757 * expression.cs: Make DoResolve take an EmitContext instead of a
31760 Replaced `l' and `location' for `loc', for consistency.
31762 (Error, Warning): Remove unneeded Tc argument.
31764 * assign.cs, literal.cs, constant.cs: Update to new calling
31767 * codegen.cs: EmitContext now contains a flag indicating whether
31768 code is being generated in a static method or not.
31770 * cs-parser.jay: DecomposeQI, new function that replaces the old
31771 QualifiedIdentifier. Now we always decompose the assembled
31772 strings from qualified_identifier productions into a group of
31775 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31777 * rootcontext.cs: Deal with field-less struct types correctly now
31778 by passing the size option to Define Type.
31780 * class.cs: Removed hack that created one static field.
31782 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31784 * statement.cs: Moved most of the code generation here.
31786 2001-10-09 Ravi Pratap <ravi@ximian.com>
31788 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31791 (ElementAccess): Remove useless bits for now - keep checks as the spec
31794 2001-10-08 Ravi Pratap <ravi@ximian.com>
31796 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31797 and start performing checks according to the spec.
31799 2001-10-07 Ravi Pratap <ravi@ximian.com>
31801 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31802 rank_specifiers instead.
31804 (rank_specifiers): Change the order in which the rank specifiers are stored
31806 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31808 * expression.cs (ElementAccess): Implement the LValue interface too.
31810 2001-10-06 Ravi Pratap <ravi@ximian.com>
31812 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31813 except that user defined conversions are not included.
31815 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31816 perform the conversion of the return type, if necessary.
31818 (New::DoResolve): Check whether we are creating an array or an object
31819 and accordingly do the needful.
31821 (New::Emit): Same here.
31823 (New::DoResolve): Implement guts of array creation.
31825 (New::FormLookupType): Helper function.
31827 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31829 * codegen.cs: Removed most of the code generation here, and move the
31830 corresponding code generation bits to the statement classes.
31832 Added support for try/catch/finalize and throw.
31834 * cs-parser.jay: Added support for try/catch/finalize.
31836 * class.cs: Catch static methods having the flags override,
31837 virtual or abstract.
31839 * expression.cs (UserCast): This user cast was not really doing
31840 what it was supposed to do. Which is to be born in fully resolved
31841 state. Parts of the resolution were being performed at Emit time!
31845 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31847 * expression.cs: Implicity convert the result from UserCast.
31849 2001-10-05 Ravi Pratap <ravi@ximian.com>
31851 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31852 prevented it from working correctly.
31854 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31855 merely ConvertImplicit.
31857 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31859 * typemanager.cs: Make the LookupTypeContainer function static,
31860 and not per-instance.
31862 * class.cs: Make static FindMembers (the one that takes a Type
31865 * codegen.cs: Add EmitForeach here.
31867 * cs-parser.jay: Make foreach a toplevel object instead of the
31868 inline expansion, as we need to perform semantic analysis on it.
31870 2001-10-05 Ravi Pratap <ravi@ximian.com>
31872 * expression.cs (Expression::ImplicitUserConversion): Rename to
31873 UserDefinedConversion.
31875 (Expression::UserDefinedConversion): Take an extra argument specifying
31876 whether we look for explicit user conversions too.
31878 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31880 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31882 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31883 with the appropriate arguments.
31885 * cs-parser.jay (cast_expression): Record location too.
31887 * expression.cs (Cast): Record location info.
31889 (Expression::ConvertExplicit): Take location argument.
31891 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31892 to determine if we are doing explicit conversions.
31894 (UserCast::Emit): Update accordingly.
31896 (Expression::ConvertExplicit): Report an error if everything fails.
31898 * ../errors/cs0030.cs : Add.
31900 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31902 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31903 virtual and newslot bits.
31905 * class.cs (TypeContainer::RegisterRequiredImplementations):
31906 Record methods we need.
31908 (TypeContainer::MakeKey): Helper function to make keys for
31909 MethodBases, since the Methodbase key is useless.
31911 (TypeContainer::Populate): Call RegisterRequiredImplementations
31912 before defining the methods.
31914 Create a mapping for method_builders_to_methods ahead of time
31915 instead of inside a tight loop.
31917 (::RequireMethods): Accept an object as the data to set into the
31918 hashtable so we can report interface vs abstract method mismatch.
31920 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31922 * report.cs: Make all of it static.
31924 * rootcontext.cs: Drop object_type and value_type computations, as
31925 we have those in the TypeManager anyways.
31927 Drop report instance variable too, now it is a global.
31929 * driver.cs: Use try/catch on command line handling.
31931 Add --probe option to debug the error reporting system with a test
31934 * report.cs: Add support for exiting program when a probe
31935 condition is reached.
31937 2001-10-03 Ravi Pratap <ravi@ximian.com>
31939 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31940 we do a forcible conversion regardless of type, to check if
31941 ForceConversion returns a null.
31943 (Binary::error19): Use location to report error.
31945 (Unary::error23): Use location here too.
31947 * ../errors/cs0019.cs : Check in.
31949 * ../errors/cs0023.cs : Check in.
31951 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31952 case of a non-null MethodInfo object with a length of 0 !
31954 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31955 an applicable member - according to the spec :-)
31956 Also fix logic to find members in base types.
31958 (Unary::ResolveOperator): Same here.
31960 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31961 as I was getting thoroughly confused between this and error19 :-)
31963 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31964 (::FindMostEncompassedType): Implement.
31965 (::FindMostEncompassingType): Implement.
31966 (::StandardConversionExists): Implement.
31968 (UserImplicitCast): Re-vamp. We now need info about most specific
31969 source and target types so that we can do the necessary conversions.
31971 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31972 mathematical union with no duplicates.
31974 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31976 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31977 in order from base classes to child classes, so that we can in
31978 child classes look up in our parent for method names and
31979 attributes (required for handling abstract, virtual, new, override
31980 constructs: we need to instrospect our base class, and if we dont
31981 populate the classes in order, the introspection might be
31982 incorrect. For example, a method could query its parent before
31983 the parent has any methods and would determine that the parent has
31984 no abstract methods (while it could have had them)).
31986 (RootContext::CreateType): Record the order in which we define the
31989 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31991 * class.cs (TypeContainer::Populate): Also method definitions can
31992 fail now, keep track of this.
31994 (TypeContainer::FindMembers): Implement support for
31995 DeclaredOnly/noDeclaredOnly flag.
31997 (Constructor::Emit) Return the ConstructorBuilder.
31999 (Method::Emit) Return the MethodBuilder.
32000 Check for abstract or virtual methods to be public.
32002 * rootcontext.cs (RootContext::CreateType): Register all the
32003 abstract methods required for the class to be complete and the
32004 interface methods that must be implemented.
32006 * cs-parser.jay: Report error 501 (method requires body if it is
32007 not marked abstract or extern).
32009 * expression.cs (TypeOf::Emit): Implement.
32011 * typemanager.cs: runtime_handle_type, new global type.
32013 * class.cs (Property::Emit): Generate code for properties.
32015 2001-10-02 Ravi Pratap <ravi@ximian.com>
32017 * expression.cs (Unary::ResolveOperator): Find operators on base type
32018 too - we now conform exactly to the spec.
32020 (Binary::ResolveOperator): Same here.
32022 * class.cs (Operator::Define): Fix minor quirk in the tests.
32024 * ../errors/cs0215.cs : Added.
32026 * ../errors/cs0556.cs : Added.
32028 * ../errors/cs0555.cs : Added.
32030 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32032 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
32033 single integer which is really efficient
32035 2001-10-01 Ravi Pratap <ravi@ximian.com>
32037 * expression.cs (Expression::ImplicitUserConversion): Use location
32038 even in the case when we are examining True operators.
32040 * class.cs (Operator::Define): Perform extensive checks to conform
32041 with the rules for operator overloading in the spec.
32043 * expression.cs (Expression::ImplicitReferenceConversion): Implement
32044 some of the other conversions mentioned in the spec.
32046 * typemanager.cs (array_type): New static member for the System.Array built-in
32049 (cloneable_interface): For System.ICloneable interface.
32051 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
32052 we start resolving the tree and populating types.
32054 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
32056 2001-10-01 Miguel de Icaza <miguel@ximian.com>
32058 * expression.cs (Expression::ExprClassFromMemberInfo,
32059 Expression::Literalize): Create literal expressions from
32060 FieldInfos which are literals.
32062 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
32063 type casts, because they were wrong. The test suite in tests
32066 (ImplicitNumericConversion): ushort to ulong requires a widening
32069 Int32 constant to long requires widening cast as well.
32071 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
32072 for integers because the type on the stack is not i4.
32074 2001-09-30 Miguel de Icaza <miguel@ximian.com>
32076 * expression.cs (report118): require location argument.
32078 * parameter.cs: Do not dereference potential null value.
32080 * class.cs: Catch methods that lack the `new' keyword when
32081 overriding a name. Report warnings when `new' is used without
32082 anything being there to override.
32084 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
32086 * class.cs: Only add constructor to hashtable if it is non-null
32087 (as now constructors can fail on define).
32089 (TypeManager, Class, Struct): Take location arguments.
32091 Catch field instance initialization in structs as errors.
32093 accepting_filter: a new filter for FindMembers that is static so
32094 that we dont create an instance per invocation.
32096 (Constructor::Define): Catch errors where a struct constructor is
32099 * cs-parser.jay: Pass location information for various new
32102 * delegate.cs (Delegate): take a location argument.
32104 * driver.cs: Do not call EmitCode if there were problesm in the
32105 Definition of the types, as many Builders wont be there.
32107 * decl.cs (Decl::Decl): Require a location argument.
32109 * cs-tokenizer.cs: Handle properly hex constants that can not fit
32110 into integers, and find the most appropiate integer for it.
32112 * literal.cs: Implement ULongLiteral.
32114 * rootcontext.cs: Provide better information about the location of
32115 failure when CreateType fails.
32117 2001-09-29 Miguel de Icaza <miguel@ximian.com>
32119 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
32122 * expression.cs (Binary::CheckShiftArguments): Add missing type
32124 (Binary::ResolveOperator): Add type to the logical and and logical
32125 or, Bitwise And/Or and Exclusive Or code paths, it was missing
32128 (Binary::DoNumericPromotions): In the case where either argument
32129 is ulong (and most signed types combined with ulong cause an
32130 error) perform implicit integer constant conversions as well.
32132 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32134 * expression.cs (UserImplicitCast): Method should always be
32136 (Invocation::BetterConversion): Simplified test for IntLiteral.
32138 (Expression::ImplicitNumericConversion): Split this routine out.
32139 Put the code that performs implicit constant integer conversions
32142 (Expression::Resolve): Become a wrapper around DoResolve so we can
32143 check eclass and type being set after resolve.
32145 (Invocation::Badness): Remove this dead function
32147 (Binary::ResolveOperator): Do not compute the expensive argumnets
32148 unless we have a union for it.
32150 (Probe::Emit): Is needs to do an isinst and then
32151 compare against null.
32153 (::CanConvert): Added Location argument. If the Location argument
32154 is null (Location.Null), then we do not report errors. This is
32155 used by the `probe' mechanism of the Explicit conversion. We do
32156 not want to generate an error for something that the user
32157 explicitly requested to be casted. But the pipeline for an
32158 explicit cast first tests for potential implicit casts.
32160 So for now, if the Location is null, it means `Probe only' to
32161 avoid adding another argument. Might have to revise this
32164 (ClassCast): New class used to type cast objects into arbitrary
32165 classes (used in Explicit Reference Conversions).
32167 Implement `as' as well.
32169 Reverted all the patches from Ravi below: they were broken:
32171 * The use of `level' as a mechanism to stop recursive
32172 invocations is wrong. That was there just to catch the
32173 bug with a strack trace but not as a way of addressing
32176 To fix the problem we have to *understand* what is going
32177 on and the interactions and come up with a plan, not
32178 just get things going.
32180 * The use of the type conversion cache that I proposed
32181 last night had an open topic: How does this work across
32182 protection domains. A user defined conversion might not
32183 be public in the location where we are applying the
32184 conversion, a different conversion might be selected
32185 (ie, private A->B (better) but public B->A (worse),
32186 inside A, A->B applies, but outside it, B->A will
32189 * On top of that (ie, even if the above is solved),
32190 conversions in a cache need to be abstract. Ie, `To
32191 convert from an Int to a Short use an OpcodeCast', not
32192 `To convert from an Int to a Short use the OpcodeCast on
32193 the variable 5' (which is what this patch was doing).
32195 2001-09-28 Ravi Pratap <ravi@ximian.com>
32197 * expression.cs (Invocation::ConversionExists): Re-write to use
32198 the conversion cache
32200 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
32201 cache all conversions done, not just user-defined ones.
32203 (Invocation::BetterConversion): The real culprit. Use ConversionExists
32204 to determine if a conversion exists instead of acutually trying to
32205 perform the conversion. It's faster too.
32207 (Expression::ConvertExplicit): Modify to use ConversionExists to check
32208 and only then attempt the implicit conversion.
32210 2001-09-28 Ravi Pratap <ravi@ximian.com>
32212 * expression.cs (ConvertImplicit): Use a cache for conversions
32213 already found. Check level of recursion and bail out if necessary.
32215 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32217 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32218 Export standard methods that we expect for string operations.
32220 * statement.cs (Block::UsageWarning): Track usage of variables and
32221 report the errors for not used variables.
32223 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32226 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32228 * codegen.cs: remove unnneded code
32230 * expression.cs: Removed BuiltinTypeAccess class
32232 Fix the order in which implicit conversions are
32235 The previous fixed dropped support for boxed conversions (adding a
32236 test to the test suite now)
32238 (UserImplicitCast::CanConvert): Remove test for source being null,
32239 that code is broken. We should not feed a null to begin with, if
32240 we do, then we should track the bug where the problem originates
32241 and not try to cover it up here.
32243 Return a resolved expression of type UserImplicitCast on success
32244 rather than true/false. Ravi: this is what I was talking about,
32245 the pattern is to use a static method as a "constructor" for
32248 Also, do not create arguments until the very last minute,
32249 otherwise we always create the arguments even for lookups that
32250 will never be performed.
32252 (UserImplicitCast::Resolve): Eliminate, objects of type
32253 UserImplicitCast are born in a fully resolved state.
32255 * typemanager.cs (InitCoreTypes): Init also value_type
32256 (System.ValueType).
32258 * expression.cs (Cast::Resolve): First resolve the child expression.
32260 (LValue): Add new method AddressOf to be used by
32263 Change the argument of Store to take an EmitContext instead of an
32264 ILGenerator, because things like FieldExpr need to be able to call
32265 their children expression to generate the instance code.
32267 (Expression::Error, Expression::Warning): Sugar functions for
32270 (Expression::MemberLookup): Accept a TypeContainer instead of a
32271 Report as the first argument.
32273 (Expression::ResolvePrimary): Killed. I still want to improve
32274 this as currently the code is just not right.
32276 (Expression::ResolveMemberAccess): Simplify, but it is still
32279 (Unary::Resolve): Catch errors in AddressOf operators.
32281 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32282 index to a byte for the short-version, or the compiler will choose
32283 the wrong Emit call, which generates the wrong data.
32285 (ParameterReference::Emit, ::Store): same.
32287 (FieldExpr::AddressOf): Implement.
32289 * typemanager.cs: TypeManager: made public variable instead of
32292 * driver.cs: document --fatal.
32294 * report.cs (ErrorMessage, WarningMessage): new names for the old
32295 Error and Warning classes.
32297 * cs-parser.jay (member_access): Turn built-in access to types
32298 into a normal simplename
32300 2001-09-27 Ravi Pratap <ravi@ximian.com>
32302 * expression.cs (Invocation::BetterConversion): Fix to cope
32303 with q being null, since this was introducing a bug.
32305 * expression.cs (ConvertImplicit): Do built-in conversions first.
32307 2001-09-27 Ravi Pratap <ravi@ximian.com>
32309 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32311 2001-09-27 Ravi Pratap <ravi@ximian.com>
32313 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32314 I had introduced long ago (what's new ?).
32316 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32317 the work of all the checking.
32318 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32319 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32321 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32322 that is the right way.
32324 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32325 overloading resolution. Use everywhere instead of cutting and pasting code.
32327 (Binary::ResolveOperator): Use MakeUnionSet.
32329 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32330 we have to convert to bool types. Not complete yet.
32332 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32334 * typemanager.cs (TypeManager::CSharpName): support ushort.
32336 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32337 to provide an expression that performsn an implicit constant int
32338 conversion (section 6.1.6).
32339 (Expression::ConvertImplicitRequired): Reworked to include
32340 implicit constant expression conversions.
32342 (Expression::ConvertNumericExplicit): Finished.
32344 (Invocation::Emit): If InstanceExpression is null, then it means
32345 that we perform a call on this.
32347 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32349 * expression.cs (Unary::Emit): Remove some dead code.
32350 (Probe): Implement Resolve and Emit for `is'.
32351 (Expression::ConvertImplicitRequired): Attempt to do constant
32352 expression conversions here. Maybe should be moved to
32353 ConvertImplicit, but I am not sure.
32354 (Expression::ImplicitLongConstantConversionPossible,
32355 Expression::ImplicitIntConstantConversionPossible): New functions
32356 that tell whether is it possible to apply an implicit constant
32357 expression conversion.
32359 (ConvertNumericExplicit): Started work on explicit numeric
32362 * cs-parser.jay: Update operator constants.
32364 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32365 (Parameters::GetSignature): Hook up VerifyArgs here.
32366 (Parameters::VerifyArgs): Verifies that no two arguments have the
32369 * class.cs (Operator): Update the operator names to reflect the
32370 ones that the spec expects (as we are just stringizing the
32373 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32374 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32375 previous usage did only work for our methods.
32376 (Expression::ConvertImplicit): Handle decimal implicit numeric
32377 conversions as well.
32378 (Expression::InternalTypeConstructor): Used to invoke constructors
32379 on internal types for default promotions.
32381 (Unary::Emit): Implement special handling for the pre/post
32382 increment/decrement for overloaded operators, as they need to have
32383 the same semantics as the other operators.
32385 (Binary::ResolveOperator): ditto.
32386 (Invocation::ConversionExists): ditto.
32387 (UserImplicitCast::Resolve): ditto.
32389 2001-09-26 Ravi Pratap <ravi@ximian.com>
32391 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32392 operator, return after emitting body. Regression tests pass again !
32394 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32395 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32396 (Invocation::OverloadResolve): Ditto.
32397 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32399 * everywhere : update calls to the above methods accordingly.
32401 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32403 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32405 * expression.cs (ExpressionStatement): New base class used for
32406 expressions that can appear in statements, so that we can provide
32407 an alternate path to generate expression that do not leave a value
32410 (Expression::Emit, and all the derivatives): We no longer return
32411 whether a value is left on the stack or not. Every expression
32412 after being emitted leaves a single value on the stack.
32414 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32415 facilties of ExpressionStatement if possible.
32417 * cs-parser.jay: Update statement_expression.
32419 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32421 * driver.cs: Change the wording of message
32423 2001-09-25 Ravi Pratap <ravi@ximian.com>
32425 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32426 the type of the expression to the return type of the method if
32427 we have an overloaded operator match ! The regression tests pass again !
32428 (Unary::ResolveOperator): Ditto.
32430 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32431 to find "op_Implicit", not "implicit" ;-)
32432 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32433 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32435 * everywhere : Correct calls to the above accordingly.
32437 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32438 (ConvertImplicit): Do user-defined conversion if it exists.
32440 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32442 * assign.cs: track location.
32443 (Resolve): Use implicit conversions on assignment.
32445 * literal.cs: Oops. Not good, Emit of short access values should
32446 pass (Bytes) or the wrong argument will be selected.
32448 * expression.cs (Unary::Emit): Emit code for -expr.
32450 (Unary::ResolveOperator): Handle `Substract' for non-constants
32451 (substract from zero from the non-constants).
32452 Deal with Doubles as well.
32454 (Expression::ConvertImplicitRequired): New routine that reports an
32455 error if no implicit conversion exists.
32457 (Invocation::OverloadResolve): Store the converted implicit
32458 expressions if we make them
32460 2001-09-24 Ravi Pratap <ravi@ximian.com>
32462 * class.cs (ConstructorInitializer): Take a Location argument.
32463 (ConstructorBaseInitializer): Same here.
32464 (ConstructorThisInitializer): Same here.
32466 * cs-parser.jay : Update all calls accordingly.
32468 * expression.cs (Unary, Binary, New): Take location argument.
32469 Update accordingly everywhere.
32471 * cs-parser.jay : Update all calls to the above to take a location
32474 * class.cs : Ditto.
32476 2001-09-24 Ravi Pratap <ravi@ximian.com>
32478 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32479 (Invocation::BetterConversion): Same here
32480 (Invocation::ConversionExists): Ditto.
32482 (Invocation::ConversionExists): Implement.
32484 2001-09-22 Ravi Pratap <ravi@ximian.com>
32486 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32487 Also take an additional TypeContainer argument.
32489 * All over : Pass in TypeContainer as argument to OverloadResolve.
32491 * typemanager.cs (CSharpName): Update to check for the string type and return
32494 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32497 2001-09-21 Ravi Pratap <ravi@ximian.com>
32499 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32500 (Invocation::BetterFunction): Implement.
32501 (Invocation::BetterConversion): Implement.
32502 (Invocation::ConversionExists): Skeleton, no implementation yet.
32504 Okay, things work fine !
32506 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32508 * typemanager.cs: declare and load enum_type, delegate_type and
32511 * expression.cs (Expression::Emit): Now emit returns a value that
32512 tells whether a value is left on the stack or not. This strategy
32513 might be reveted tomorrow with a mechanism that would address
32514 multiple assignments.
32515 (Expression::report118): Utility routine to report mismatches on
32518 (Unary::Report23): Report impossible type/operator combination
32521 (Unary::IsIncrementableNumber): Whether the type can be
32522 incremented or decremented with add.
32523 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32525 (Unary::ResolveOperator): Implement ++, !, ~,
32527 (Invocation::Emit): Deal with new Emit convetion.
32529 * All Expression derivatives: Updated their Emit method to return
32530 whether they leave values on the stack or not.
32532 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32533 stack for expressions that are statements.
32535 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32537 * expression.cs (LValue): New interface. Must be implemented by
32539 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32542 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32543 interface for generating code, simplifies the code.
32545 2001-09-20 Ravi Pratap <ravi@ximian.com>
32547 * expression.cs (everywhere): Comment out return statements in ::Resolve
32548 methods to avoid the warnings.
32550 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32552 * driver.cs (parse): Report error 2001 if we can not open the
32555 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32558 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32561 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32562 otherwise nested blocks end up with the same index.
32564 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32566 * expression.cs: Instead of having FIXMEs in the Resolve
32567 functions, throw exceptions so it is obvious that we are facing a
32570 * cs-parser.jay (invocation_expression): Pass Location information.
32572 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32573 Use a basename for those routines because .NET does not like paths
32576 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32579 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32581 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32582 are loading the correct data types (throws an exception if not).
32583 (TypeManager::InitCoreTypes): Use CoreLookupType
32585 * expression.cs (Unary::ResolveOperator): return the child
32586 expression for expressions which are just +expr.
32587 (Unary::ResolveOperator): Return negative literals for -LITERAL
32588 expressions (otherwise they are Unary {Literal}).
32589 (Invocation::Badness): Take into account `Implicit constant
32590 expression conversions'.
32592 * literal.cs (LongLiteral): Implement long literal class.
32593 (IntLiteral): export the `Value' of the intliteral.
32595 2001-09-19 Ravi Pratap <ravi@ximian.com>
32597 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32599 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32600 instead of 'Operator'
32602 * expression.cs (Binary::ResolveOperator): Update accordingly.
32603 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32606 * cs-parser.jay (unary_expression): Update to use the new names.
32608 * gen-treedump.cs (GetUnary): Same here.
32610 * expression.cs (Unary::Resolve): Implement.
32611 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32612 operators are found instead of making noise ;-)
32613 (Unary::ResolveOperator): New method to do precisely the same thing which
32614 Binary::ResolveOperator does for Binary expressions.
32615 (Unary.method, .Arguments): Add.
32616 (Unary::OperName): Implement.
32617 (Unary::ForceConversion): Copy and Paste !
32619 * class.cs (Operator::Define): Fix a small bug for the case when we have
32622 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32623 for the inbuilt operators. Only overloading works for now ;-)
32625 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32627 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32628 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32630 * expression.cs (This::Emit): Implement.
32631 (This::Resolve): Implement.
32632 (TypeOf:Resolve): Implement.
32633 (Expression::ResolveSimpleName): Add an implicit this to instance
32635 (MemberAccess::Resolve): Deal with Parameters and Fields.
32636 Bind instance variable to Field expressions.
32637 (FieldExpr::Instance): New field used to track the expression that
32638 represents the object instance.
32639 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32641 (FieldExpr::Emit): Implement.
32643 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32644 the last instruction contains a return opcode to avoid generating
32645 the last `ret' instruction (this generates correct code, and it is
32646 nice to pass the peverify output).
32648 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32649 initializer for static and instance variables.
32650 (Constructor::Emit): Allow initializer to be null in the case of
32651 static constructors. Only emit initializer for instance
32654 (TypeContainer::FindMembers): Return a null array if there are no
32657 Also fix the code for the MemberTypes.Method branch, as it was not
32658 scanning that for operators (or tried to access null variables before).
32660 * assign.cs (Assign::Emit): Handle instance and static fields.
32664 * driver.cs: Stop compilation if there are parse errors.
32666 * cs-parser.jay (constructor_declaration): Provide default base
32667 initializer for non-static constructors.
32668 (constructor_declarator): Do not provide a default base
32669 initializers if none was specified.
32670 Catch the fact that constructors should not have parameters.
32672 * class.cs: Do not emit parent class initializers for static
32673 constructors, that should be flagged as an error.
32675 2001-09-18 Ravi Pratap <ravi@ximian.com>
32677 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32678 Move back code into TypeContainer::Populate.
32680 2001-09-18 Ravi Pratap <ravi@ximian.com>
32682 * class.cs (TypeContainer::AddConstructor): Fix the check to
32683 compare against Name, not Basename.
32684 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32686 * cs-parser.jay : Update accordingly.
32688 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32689 for methods, don't forget to look into the operators too.
32690 (RegisterMethodBuilder): Helper method to take care of this for
32691 methods, constructors and operators.
32692 (Operator::Define): Completely revamp.
32693 (Operator.OperatorMethod, MethodName): New fields.
32694 (TypeContainer::Populate): Move the registering of builders into
32695 RegisterMethodBuilder.
32696 (Operator::Emit): Re-write.
32698 * expression.cs (Binary::Emit): Comment out code path to emit method
32699 invocation stuff for the case when we have a user defined operator. I am
32700 just not able to get it right !
32702 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32704 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32707 (Expression::MemberLookup): Provide a version that allows to
32708 specify the MemberTypes and BindingFlags.
32710 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32711 so it was not fetching variable information from outer blocks.
32713 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32714 Beforefieldinit as it was buggy.
32716 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32717 that Ravi put here.
32719 * class.cs (Constructor::Emit): Only emit if block is not null.
32720 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32721 deal with this by semantically definining it as if the user had
32724 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32725 constructors as we now "emit" them at a higher level.
32727 (TypeContainer::DefineDefaultConstructor): Used to define the
32728 default constructors if none was provided.
32730 (ConstructorInitializer): Add methods Resolve and Emit.
32732 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32734 2001-09-17 Ravi Pratap <ravi@ximian.com>
32736 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32737 the default constructor builder with our hashtable for methodbuilders
32740 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32741 and argument_count is 0 in which case we have a match.
32742 (Binary::ResolveOperator): More null checking and miscellaneous coding
32745 2001-09-17 Ravi Pratap <ravi@ximian.com>
32747 * rootcontext.cs (IsNameSpace): Compare against null.
32749 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32751 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32752 and Unary::Operator.
32754 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32757 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32758 we have overloaded operators.
32759 (Binary::ResolveOperator): Implement the part which does the operator overload
32762 * class.cs (Operator::Emit): Implement.
32763 (TypeContainer::Emit): Emit the operators we have too.
32765 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32766 the case when we have a user-defined operator.
32768 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32770 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32772 2001-09-16 Ravi Pratap <ravi@ximian.com>
32774 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32775 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32776 (Constructor::Emit): Implement.
32777 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32778 if we have no work to do.
32779 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32782 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32783 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32785 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32788 2001-09-15 Ravi Pratap <ravi@ximian.com>
32790 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32792 (Tree::RecordNamespace): Method to do what the name says ;-)
32793 (Tree::Namespaces): Property to get at the namespaces hashtable.
32795 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32798 * rootcontext.cs (IsNamespace): Fixed it :-)
32800 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32802 * class.cs (TypeContainer::FindMembers): Add support for
32804 (MethodCore): New class that encapsulates both the shared aspects
32805 of a Constructor and a Method.
32806 (Method, Constructor): Factored pieces into MethodCore.
32808 * driver.cs: Added --fatal which makes errors throw exceptions.
32809 Load System assembly as well as part of the standard library.
32811 * report.cs: Allow throwing exceptions on errors for debugging.
32813 * modifiers.cs: Do not use `parent', instead use the real type
32814 container to evaluate permission settings.
32816 * class.cs: Put Ravi's patch back in. He is right, and we will
32817 have to cope with the
32819 2001-09-14 Ravi Pratap <ravi@ximian.com>
32821 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32822 FamORAssem, not FamANDAssem.
32824 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32826 * driver.cs: Added --parse option that only parses its input files
32829 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32830 incorrect. IsTopLevel is not used to tell whether an object is
32831 root_types or not (that can be achieved by testing this ==
32832 root_types). But to see if this is a top-level *class* (not
32833 necessarly our "toplevel" container).
32835 2001-09-14 Ravi Pratap <ravi@ximian.com>
32837 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32838 parent instead of a direct call to GetType.
32840 2001-09-14 Ravi Pratap <ravi@ximian.com>
32842 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32843 Modifiers.TypeAttr. This should just be a call to that method.
32845 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32846 object so that we can determine if we are top-level or not.
32848 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32851 * enum.cs (Enum::Define): Ditto.
32853 * modifiers.cs (FieldAttr): Re-write.
32855 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32856 (TypeContainer::HaveStaticConstructor): New property to provide access
32857 to precisely that info.
32859 * modifiers.cs (MethodAttr): Re-write.
32860 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32862 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32863 of top-level types as claimed.
32865 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32867 * expression.cs (MemberLookup): Fruitless attempt to lookup
32868 constructors. Maybe I need to emit default constructors? That
32869 might be it (currently .NET emits this for me automatically).
32870 (Invocation::OverloadResolve): Cope with Arguments == null.
32871 (Invocation::EmitArguments): new function, shared by the new
32872 constructor and us.
32873 (Invocation::Emit): Handle static and instance methods. Emit
32874 proper call instruction for virtual or non-virtual invocations.
32875 (New::Emit): Implement.
32876 (New::Resolve): Implement.
32877 (MemberAccess:Resolve): Implement.
32878 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32879 to track instances.
32880 (FieldExpr::Resolve): Set type.
32882 * support.cs: Handle empty arguments.
32884 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32885 SimpleLookup): Auxiliary routines to help parse a qualifier
32888 Update qualifier_identifier rule.
32890 * codegen.cs: Removed debugging messages.
32892 * class.cs: Make this a global thing, this acts just as a "key" to
32893 objects that we might have around.
32895 (Populate): Only initialize method_builders_to_methods once.
32897 * expression.cs (PropertyExpr): Initialize type from the
32900 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32901 Resolve pattern. Attempt to implicitly convert value to boolean.
32904 * expression.cs: Set the type for the int32/int32 argument case.
32905 (Binary::ResolveOperator): Set the return type to boolean for
32906 comparission operators
32908 * typemanager.cs: Remove debugging print code.
32910 (Invocation::Resolve): resolve type.
32912 * class.cs: Allocate a MemberInfo of the correct size, as the code
32913 elsewhere depends on the test to reflect the correct contents.
32915 (Method::) Keep track of parameters, due to System.Reflection holes
32917 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32920 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32921 of the exact size and return that.
32923 (Class::LookupMethodByBuilder): New function that maps
32924 MethodBuilders to its methods. Required to locate the information
32925 on methods because System.Reflection bit us again.
32927 * support.cs: New file, contains an interface ParameterData and
32928 two implementations: ReflectionParameters and InternalParameters
32929 used to access Parameter information. We will need to grow this
32932 * expression.cs (Invocation::GetParameterData): implement a cache
32933 and a wrapper around the ParameterData creation for methods.
32934 (Invocation::OverloadResolve): Use new code.
32936 2001-09-13 Ravi Pratap <ravi@ximian.com>
32938 * class.cs (TypeContainer::EmitField): Remove and move into
32939 (Field::Define): here and modify accordingly.
32940 (Field.FieldBuilder): New member.
32941 (TypeContainer::Populate): Update accordingly.
32942 (TypeContainer::FindMembers): Implement.
32944 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32946 * statement.cs: (VariableInfo::VariableType): New field to be
32947 initialized with the full type once it is resolved.
32949 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32951 * parameter.cs (GetParameterInfo): Use a type cache to compute
32952 things only once, and to reuse this information
32954 * expression.cs (LocalVariableReference::Emit): Implement.
32955 (OpcodeCast::Emit): fix.
32957 (ParameterReference::Resolve): Implement.
32958 (ParameterReference::Emit): Implement.
32960 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32961 that are expressions need to stay as Expressions.
32963 * typemanager.cs (CSharpName): Returns the C# name of a type if
32966 * expression.cs (Expression::ConvertImplicit): New function that
32967 implements implicit type conversions.
32969 (Expression::ImplicitReferenceConversion): Implements implicit
32970 reference conversions.
32972 (EmptyCast): New type for transparent casts.
32974 (OpcodeCast): New type for casts of types that are performed with
32975 a sequence of bytecodes.
32977 (BoxedCast): New type used for casting value types into reference
32978 types. Emits a box opcode.
32980 (Binary::DoNumericPromotions): Implements numeric promotions of
32981 and computation of the Binary::Type.
32983 (Binary::EmitBranchable): Optimization.
32985 (Binary::Emit): Implement code emission for expressions.
32987 * typemanager.cs (TypeManager): Added two new core types: sbyte
32990 2001-09-12 Ravi Pratap <ravi@ximian.com>
32992 * class.cs (TypeContainer::FindMembers): Method which does exactly
32993 what Type.FindMembers does, only we don't have to use reflection. No
32994 implementation yet.
32996 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32997 typecontainer objects as we need to get at them.
32998 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
33000 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
33001 typecontainer object.
33003 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
33004 of just a Report object.
33006 2001-09-11 Ravi Pratap <ravi@ximian.com>
33008 * class.cs (Event::Define): Go back to using the prefixes "add_" and
33010 (TypeContainer::Populate): Now define the delegates of the type too.
33011 (TypeContainer.Delegates): Property to access the list of delegates defined
33014 * delegates.cs (Delegate::Define): Implement partially.
33016 * modifiers.cs (TypeAttr): Handle more flags.
33018 2001-09-11 Ravi Pratap <ravi@ximian.com>
33020 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
33022 (Operator::Define): Re-write logic to get types by using the LookupType method
33023 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
33024 (Indexer::Define): Ditto.
33025 (Event::Define): Ditto.
33026 (Property::Define): Ditto.
33028 2001-09-10 Ravi Pratap <ravi@ximian.com>
33030 * class.cs (TypeContainer::Populate): Now define operators too.
33031 (TypeContainer.Operators): New property to access the list of operators
33033 (Operator.OperatorMethodBuilder): New member to hold the method builder
33034 for the operator we are defining.
33035 (Operator::Define): Implement.
33037 2001-09-10 Ravi Pratap <ravi@ximian.com>
33039 * class.cs (Event::Define): Make the prefixes of the accessor methods
33040 addOn_ and removeOn_
33042 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
33043 of the location being passed in too. Ideally, this should go later since all
33044 error reporting should be done through the Report object.
33046 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
33047 (Populate): Iterate thru the indexers we have and define them too.
33048 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
33049 for the get and set accessors.
33050 (Indexer::Define): Implement.
33052 2001-09-09 Miguel de Icaza <miguel@ximian.com>
33054 * expression.cs (Binary::Resolve): Beginning of it. I scratched
33055 my previous implementation, did not work.
33057 * typemanager.cs: Add a couple of missing types (the longs).
33059 * literal.cs: Use TypeManager.bool_type instead of getting it.
33061 * expression.cs (EventExpr): New kind of expressions.
33062 (Expressio::ExprClassFromMemberInfo): finish
33064 2001-09-08 Miguel de Icaza <miguel@ximian.com>
33066 * assign.cs: Emit stores to static fields differently.
33068 2001-09-08 Ravi Pratap <ravi@ximian.com>
33070 * Merge in changes and adjust code to tackle conflicts. Backed out my
33071 code in Assign::Resolve ;-)
33073 2001-09-08 Ravi Pratap <ravi@ximian.com>
33075 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
33076 instead Report.Error and also pass in the location.
33077 (CSharpParser::Lexer): New readonly property to return the reference
33078 to the Tokenizer object.
33079 (declare_local_variables): Use Report.Error with location instead of plain
33083 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
33084 (Operator.CheckBinaryOperator): Ditto.
33086 * cs-parser.jay (operator_declarator): Update accordingly.
33088 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
33089 (CheckBinaryOperator): Same here.
33091 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
33092 on the name without any prefixes of namespace names etc. This is because we
33093 already might have something already fully qualified like
33094 'System.Console.WriteLine'
33096 * assign.cs (Resolve): Begin implementation. Stuck ;-)
33098 2001-09-07 Ravi Pratap <ravi@ximian.com>
33100 * cs-tokenizer.cs (location): Return a string which also contains
33103 * expression.cs (ElementAccess): New class for expressions of the
33104 type 'element access.'
33105 (BaseAccess): New class for expressions of the type 'base access.'
33106 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
33109 * cs-parser.jay (element_access): Implement action.
33110 (base_access): Implement actions.
33111 (checked_expression, unchecked_expression): Implement.
33113 * cs-parser.jay (local_variable_type): Correct and implement.
33114 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
33116 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
33118 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
33119 name and the specifiers.
33121 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
33123 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
33124 making them all public ;-)
33126 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
33129 2001-09-07 Miguel de Icaza <miguel@ximian.com>
33131 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
33133 (FieldExpr, PropertyExprs): New resolved expressions.
33134 (SimpleName::MemberStaticCheck): Perform static checks for access
33135 to non-static fields on static methods. Maybe this should be
33136 generalized for MemberAccesses.
33137 (SimpleName::ResolveSimpleName): More work on simple name
33140 * cs-parser.jay (primary_expression/qualified_identifier): track
33141 the parameter index.
33143 * codegen.cs (CodeGen::Save): Catch save exception, report error.
33144 (EmitContext::EmitBoolExpression): Chain to expression generation
33145 instead of temporary hack.
33146 (::EmitStatementExpression): Put generic expression code generation.
33148 * assign.cs (Assign::Emit): Implement variable assignments to
33149 local variables, parameters and fields.
33151 2001-09-06 Miguel de Icaza <miguel@ximian.com>
33153 * statement.cs (Block::GetVariableInfo): New method, returns the
33154 VariableInfo for a variable name in a block.
33155 (Block::GetVariableType): Implement in terms of GetVariableInfo
33157 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
33158 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
33160 2001-09-06 Ravi Pratap <ravi@ximian.com>
33162 * cs-parser.jay (operator_declaration): Continue on my quest : update
33163 to take attributes argument.
33164 (event_declaration): Ditto.
33165 (enum_declaration): Ditto.
33166 (indexer_declaration): Ditto.
33168 * class.cs (Operator::Operator): Update constructor accordingly.
33169 (Event::Event): Ditto.
33171 * delegate.cs (Delegate::Delegate): Same here.
33173 * enum.cs (Enum::Enum): Same here.
33175 2001-09-05 Ravi Pratap <ravi@ximian.com>
33177 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
33179 * ../tests/cs0658.cs : New file to demonstrate error 0658.
33181 * attribute.cs (Attributes): New class to encapsulate all attributes which were
33182 being passed around as an arraylist.
33183 (Attributes::AddAttribute): Method to add attribute sections.
33185 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
33186 (struct_declaration): Update accordingly.
33187 (constant_declaration): Update.
33188 (field_declaration): Update.
33189 (method_header): Update.
33190 (fixed_parameter): Update.
33191 (parameter_array): Ditto.
33192 (property_declaration): Ditto.
33193 (destructor_declaration): Ditto.
33195 * class.cs (Struct::Struct): Update constructors accordingly.
33196 (Class::Class): Ditto.
33197 (Field::Field): Ditto.
33198 (Method::Method): Ditto.
33199 (Property::Property): Ditto.
33200 (TypeContainer::OptAttribute): update property's return type.
33202 * interface.cs (Interface.opt_attributes): New member.
33203 (Interface::Interface): Update to take the extra Attributes argument.
33205 * parameter.cs (Parameter::Parameter): Ditto.
33207 * constant.cs (Constant::Constant): Ditto.
33209 * interface.cs (InterfaceMemberBase): New OptAttributes field.
33210 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33211 the attributes as a parameter.
33212 (InterfaceProperty): Update constructor call.
33213 (InterfaceEvent): Ditto.
33214 (InterfaceMethod): Ditto.
33215 (InterfaceIndexer): Ditto.
33217 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33218 pass the attributes too.
33219 (interface_event_declaration): Ditto.
33220 (interface_property_declaration): Ditto.
33221 (interface_method_declaration): Ditto.
33222 (interface_declaration): Ditto.
33224 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33226 * class.cs (Method::Define): Track the "static Main" definition to
33227 create an entry point.
33229 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33230 EntryPoint if we find it.
33232 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33233 (EmitContext::ig): Make this variable public.
33235 * driver.cs: Make the default output file be the first file name
33236 with the .exe extension.
33238 Detect empty compilations
33240 Handle various kinds of output targets. Handle --target and
33241 rename -t to --dumper.
33243 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33244 methods inherited from Expression return now an Expression. This
33245 will is used during the tree rewriting as we resolve them during
33248 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33249 the spec. Missing entirely is the information about
33250 accessability of elements of it.
33252 (Expression::ExprClassFromMemberInfo): New constructor for
33253 Expressions that creates a fully initialized Expression based on
33254 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33257 (Invocation::Resolve): Begin implementing resolution of invocations.
33259 * literal.cs (StringLiteral): Implement Emit.
33261 2001-09-05 Ravi Pratap <ravi@ximian.com>
33263 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33266 2001-09-04 Ravi Pratap <ravi@ximian.com>
33268 * cs-parser.jay (attribute_arguments): Implement actions.
33269 (attribute): Fix bug in production. Implement action.
33270 (attribute_list): Implement.
33271 (attribute_target): Implement.
33272 (attribute_target_specifier, opt_target_specifier): Implement
33273 (CheckAttributeTarget): New method to check if the attribute target
33275 (attribute_section): Implement.
33276 (opt_attributes): Implement.
33278 * attribute.cs : New file to handle attributes.
33279 (Attribute): Class to hold attribute info.
33281 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33282 (attribute_section): Modify production to use 2 different rules to
33283 achieve the same thing. 1 s/r conflict down !
33284 Clean out commented, useless, non-reducing dimension_separator rules.
33286 * class.cs (TypeContainer.attributes): New member to hold list
33287 of attributes for a type.
33288 (Struct::Struct): Modify to take one more argument, the attribute list.
33289 (Class::Class): Ditto.
33290 (Field::Field): Ditto.
33291 (Method::Method): Ditto.
33292 (Property::Property): Ditto.
33294 * cs-parser.jay (struct_declaration): Update constructor call to
33295 pass in the attributes too.
33296 (class_declaration): Ditto.
33297 (constant_declaration): Ditto.
33298 (field_declaration): Ditto.
33299 (method_header): Ditto.
33300 (fixed_parameter): Ditto.
33301 (parameter_array): Ditto.
33302 (property_declaration): Ditto.
33304 * constant.cs (Constant::Constant): Update constructor similarly.
33305 Use System.Collections.
33307 * parameter.cs (Parameter::Parameter): Update as above.
33309 2001-09-02 Ravi Pratap <ravi@ximian.com>
33311 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33312 (TypeContainer.delegates): New member to hold list of delegates.
33314 * cs-parser.jay (delegate_declaration): Implement the action correctly
33315 this time as I seem to be on crack ;-)
33317 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33319 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33320 tell whether an identifier represents a namespace.
33322 * expression.cs (NamespaceExpr): A namespace expression, used only
33323 temporarly during expression resolution.
33324 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33325 utility functions to resolve names on expressions.
33327 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33329 * codegen.cs: Add hook for StatementExpressions.
33331 * class.cs: Fix inverted test for static flag in methods.
33333 2001-09-02 Ravi Pratap <ravi@ximian.com>
33335 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33336 to make it coincide with MS' number.
33337 (Operator::CheckBinaryOperator): Ditto.
33339 * ../errors/errors.txt : Remove error numbers added earlier.
33341 * ../errors/cs1019.cs : Test case for error # 1019
33343 * ../errros/cs1020.cs : Test case for error # 1020
33345 * cs-parser.jay : Clean out commented cruft.
33346 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33347 used anywhere - non-reducing rule.
33348 (namespace_declarations): Non-reducing rule - comment out.
33350 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33351 with TypeContainer::AddEnum.
33353 * delegate.cs : New file for delegate handling classes.
33354 (Delegate): Class for declaring delegates.
33356 * makefile : Update.
33358 * cs-parser.jay (delegate_declaration): Implement.
33360 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33362 * class.cs (Event::Define): Implement.
33363 (Event.EventBuilder): New member.
33365 * class.cs (TypeContainer::Populate): Update to define all enums and events
33367 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33368 readonly fields for all these cases ?
33370 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33372 * class.cs (Property): Revamp to use the convention of making fields readonly.
33373 Accordingly modify code elsewhere.
33375 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33376 the Define method of the Property class.
33378 * class.cs : Clean up applied patch and update references to variables etc. Fix
33380 (TypeContainer::Populate): Update to define all the properties we have. Also
33381 define all enumerations.
33383 * enum.cs (Define): Implement.
33385 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33387 * cs-parser.jay (overloadable_operator): The semantic value is an
33388 enum of the Operator class.
33389 (operator_declarator): Implement actions.
33390 (operator_declaration): Implement.
33392 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33393 validity of definitions.
33394 (Operator::CheckBinaryOperator): Static method to check for binary operators
33395 (TypeContainer::AddOperator): New method to add an operator to a type.
33397 * cs-parser.jay (indexer_declaration): Added line to actually call the
33398 AddIndexer method so it gets added ;-)
33400 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33401 already taken care of by the MS compiler ?
33403 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33405 * class.cs (Operator): New class for operator declarations.
33406 (Operator::OpType): Enum for the various operators.
33408 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33410 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33411 ostensibly handle this in semantic analysis.
33413 * cs-parser.jay (general_catch_clause): Comment out
33414 (specific_catch_clauses, specific_catch_clause): Ditto.
33415 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33416 (catch_args, opt_catch_args): New productions.
33417 (catch_clause): Rewrite to use the new productions above
33418 (catch_clauses): Modify accordingly.
33419 (opt_catch_clauses): New production to use in try_statement
33420 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33421 and re-write the code in the actions to extract the specific and
33422 general catch clauses by being a little smart ;-)
33424 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33425 Hooray, try and catch statements parse fine !
33427 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33429 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33430 string from the hashtable of variables.
33432 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33433 I end up making that mistake ;-)
33434 (catch_clauses): Fixed gross error which made Key and Value of the
33435 DictionaryEntry the same : $1 !!
33437 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33439 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33441 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33442 when the add and remove accessors are specified.
33444 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33446 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33447 information about indexer_declarator.
33448 (indexer_declarator): Implement actions.
33449 (parsing_indexer): New local boolean used to keep track of whether
33450 we are parsing indexers or properties. This is necessary because
33451 implicit_parameters come into picture even for the get accessor in the
33452 case of an indexer.
33453 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33455 * class.cs (Indexer): New class for indexer declarations.
33456 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33457 (TypeContainer::indexers): New member to hold list of indexers for the
33460 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33462 * cs-parser.jay (add_accessor_declaration): Implement action.
33463 (remove_accessor_declaration): Implement action.
33464 (event_accessors_declaration): Implement
33465 (variable_declarators): swap statements for first rule - trivial.
33467 * class.cs (Event): New class to hold information about event
33469 (TypeContainer::AddEvent): New method to add an event to a type
33470 (TypeContainer::events): New member to hold list of events.
33472 * cs-parser.jay (event_declaration): Implement actions.
33474 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33476 * cs-parser.jay (dim_separators): Implement. Make it a string
33477 concatenating all the commas together, just as they appear.
33478 (opt_dim_separators): Modify accordingly
33479 (rank_specifiers): Update accordingly. Basically do the same
33480 thing - instead, collect the brackets here.
33481 (opt_rank_sepcifiers): Modify accordingly.
33482 (array_type): Modify to actually return the complete type string
33483 instead of ignoring the rank_specifiers.
33484 (expression_list): Implement to collect the expressions
33485 (variable_initializer): Implement. We make it a list of expressions
33486 essentially so that we can handle the array_initializer case neatly too.
33487 (variable_initializer_list): Implement.
33488 (array_initializer): Make it a list of variable_initializers
33489 (opt_array_initializer): Modify accordingly.
33491 * expression.cs (New::NType): Add enumeration to help us
33492 keep track of whether we have an object/delegate creation
33493 or an array creation.
33494 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33495 members to hold data about array creation.
33496 (New:New): Modify to update NewType
33497 (New:New): New Overloaded contructor for the array creation
33500 * cs-parser.jay (array_creation_expression): Implement to call
33501 the overloaded New constructor.
33503 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33505 * class.cs (TypeContainer::Constructors): Return member
33506 constructors instead of returning null.
33508 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33510 * typemanager.cs (InitCoreTypes): Initialize the various core
33511 types after we have populated the type manager with the user
33512 defined types (this distinction will be important later while
33513 compiling corlib.dll)
33515 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33516 on Expression Classification. Now all expressions have a method
33517 `Resolve' and a method `Emit'.
33519 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33520 generation from working. Also add some temporary debugging
33523 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33525 * codegen.cs: Lots of code generation pieces. This is only the
33526 beginning, will continue tomorrow with more touches of polish. We
33527 handle the fundamentals of if, while, do, for, return. Others are
33528 trickier and I need to start working on invocations soon.
33530 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33533 * codegen.cs (EmitContext): New struct, used during code
33534 emission to keep a context. Most of the code generation will be
33537 * cs-parser.jay: Add embedded blocks to the list of statements of
33538 this block. So code generation proceeds in a top down fashion.
33540 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33542 * statement.cs: Add support for multiple child blocks.
33544 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33546 * codegen.cs (EmitCode): New function, will emit the code for a
33547 Block of code given a TypeContainer and its ILGenerator.
33549 * statement.cs (Block): Standard public readonly optimization.
33550 (Block::Block constructors): Link children.
33551 (Block::Child): Child Linker.
33552 (Block::EmitVariables): Emits IL variable declarations.
33554 * class.cs: Drop support for MethodGroups here, delay until
33556 (Method::): Applied the same simplification that I did before, and
33557 move from Properties to public readonly fields.
33558 (Method::ParameterTypes): Returns the parameter types for the
33559 function, and implements a cache that will be useful later when I
33560 do error checking and the semantic analysis on the methods is
33562 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33563 and made a method, optional argument tells whether this is a class
33564 or a structure to apply the `has-this' bit.
33565 (Method::GetCallingConvention): Implement, returns the calling
33567 (Method::Define): Defines the type, a second pass is performed
33568 later to populate the methods.
33570 (Constructor::ParameterTypes): implement a cache similar to the
33571 one on Method::ParameterTypes, useful later when we do semantic
33574 (TypeContainer::EmitMethod): New method. Emits methods.
33576 * expression.cs: Removed MethodGroup class from here.
33578 * parameter.cs (Parameters::GetCallingConvention): new method.
33580 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33582 * class.cs (TypeContainer::Populate): Drop RootContext from the
33585 (Constructor::CallingConvention): Returns the calling convention.
33586 (Constructor::ParameterTypes): Returns the constructor parameter
33589 (TypeContainer::AddConstructor): Keep track of default constructor
33590 and the default static constructor.
33592 (Constructor::) Another class that starts using `public readonly'
33593 instead of properties.
33595 (Constructor::IsDefault): Whether this is a default constructor.
33597 (Field::) use readonly public fields instead of properties also.
33599 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33600 track of static constructors; If none is used, turn on
33601 BeforeFieldInit in the TypeAttributes.
33603 * cs-parser.jay (opt_argument_list): now the return can be null
33604 for the cases where there are no arguments.
33606 (constructor_declarator): If there is no implicit `base' or
33607 `this', then invoke the default parent constructor.
33609 * modifiers.cs (MethodAttr): New static function maps a set of
33610 modifiers flags into a MethodAttributes enum
33611 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33612 MethodAttr, TypeAttr to represent the various mappings where the
33613 modifiers are used.
33614 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33616 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33618 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33621 * interface.cs (PopulateIndexer): Implemented the code generator
33622 for interface indexers.
33624 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33626 * interface.cs (InterfaceMemberBase): Now we track the new status
33629 (PopulateProperty): Implement property population. Woohoo! Got
33630 Methods and Properties going today.
33632 Removed all the properties for interfaces, and replaced them with
33633 `public readonly' fields.
33635 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33637 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33638 initialize their hashtables/arraylists only when they are needed
33639 instead of doing this always.
33641 * parameter.cs: Handle refs and out parameters.
33643 * cs-parser.jay: Use an ArrayList to construct the arguments
33644 instead of the ParameterCollection, and then cast that to a
33647 * parameter.cs: Drop the use of ParameterCollection and use
33648 instead arrays of Parameters.
33650 (GetParameterInfo): Use the Type, not the Name when resolving
33653 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33655 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33656 and instead use public readonly fields.
33658 * class.cs: Put back walking code for type containers.
33660 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33662 * class.cs (MakeConstant): Code to define constants.
33664 * rootcontext.cs (LookupType): New function. Used to locate types
33667 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33669 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33670 this System.Reflection code is. Kudos to Microsoft
33672 * typemanager.cs: Implement a type cache and avoid loading all
33673 types at boot time. Wrap in LookupType the internals. This made
33674 the compiler so much faster. Wow. I rule!
33676 * driver.cs: Make sure we always load mscorlib first (for
33677 debugging purposes, nothing really important).
33679 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33680 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33682 * rootcontext.cs: Lookup types on their namespace; Lookup types
33683 on namespaces that have been imported using the `using' keyword.
33685 * class.cs (TypeContainer::TypeAttr): Virtualize.
33686 (Class::TypeAttr): Return attributes suitable for this bad boy.
33687 (Struct::TypeAttr): ditto.
33688 Handle nested classes.
33689 (TypeContainer::) Remove all the type visiting code, it is now
33690 replaced with the rootcontext.cs code
33692 * rootcontext.cs (GetClassBases): Added support for structs.
33694 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33696 * interface.cs, statement.cs, class.cs, parameter.cs,
33697 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33698 Drop use of TypeRefs, and use strings instead.
33700 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33704 * class.cs (Struct::Struct): set the SEALED flags after
33705 checking the modifiers.
33706 (TypeContainer::TypeAttr): new property, returns the
33707 TypeAttributes for a class.
33709 * cs-parser.jay (type_list): Oops, list production was creating a
33710 new list of base types.
33712 * rootcontext.cs (StdLib): New property.
33713 (GetInterfaceTypeByName): returns an interface by type name, and
33714 encapsulates error handling here.
33715 (GetInterfaces): simplified.
33716 (ResolveTree): Encapsulated all the tree resolution here.
33717 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33720 * driver.cs: Add support for --nostdlib, to avoid loading the
33721 default assemblies.
33722 (Main): Do not put tree resolution here.
33724 * rootcontext.cs: Beginning of the class resolution.
33726 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33728 * rootcontext.cs: Provide better error reporting.
33730 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33732 * rootcontext.cs (CreateInterface): Handle the case where there
33733 are no parent interfaces.
33735 (CloseTypes): Routine to flush types at the end.
33736 (CreateInterface): Track types.
33737 (GetInterfaces): Returns an array of Types from the list of
33738 defined interfaces.
33740 * typemanager.c (AddUserType): Mechanism to track user types (puts
33741 the type on the global type hash, and allows us to close it at the
33744 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33746 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33747 RecordInterface instead.
33749 * cs-parser.jay: Updated to reflect changes above.
33751 * decl.cs (Definition): Keep track of the TypeBuilder type that
33752 represents this type here. Not sure we will use it in the long
33753 run, but wont hurt for now.
33755 * driver.cs: Smaller changes to accomodate the new code.
33757 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33760 * rootcontext.cs (CreateInterface): New method, used to create
33761 the System.TypeBuilder type for interfaces.
33762 (ResolveInterfaces): new entry point to resolve the interface
33764 (CodeGen): Property, used to keep track of the code generator.
33766 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33768 * cs-parser.jay: Add a second production for delegate_declaration
33771 (enum_body): Put an opt_comma here instead of putting it on
33772 enum_body or enum_member_declarations so we can handle trailing
33773 commas on enumeration members. Gets rid of a shift/reduce.
33775 (type_list): Need a COMMA in the middle.
33777 (indexer_declaration): Tell tokenizer to recognize get/set
33779 * Remove old targets.
33781 * Re-add the parser target.
33783 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33785 * cs-parser.jay: Add precendence rules for a number of operators
33786 ot reduce the number of shift/reduce conflicts in the grammar.
33788 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33790 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33793 Get rid of old crufty code.
33795 * rootcontext.cs: Use this to keep track of the parsed
33796 representation and the defined types available to the program.
33798 * gen-treedump.cs: adjust for new convention.
33800 * type.cs: Split out the type manager, and the assembly builder
33803 * typemanager.cs: the type manager will live here now.
33805 * cil-codegen.cs: And the code generator here.
33807 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33809 * makefile: Fixed up for easy making.
33811 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33813 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33816 (unary_expression): Expand pre_increment_expression and
33817 post_decrement_expression to reduce a shift/reduce.
33819 2001-07-11 Simon Cozens
33821 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33823 Improve allow_keyword_as_indent name.
33825 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33827 * Adjustments for Beta2.
33829 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33831 * decl.cs: Added `Define' abstract method.
33832 (InTransit): new property, used to catch recursive definitions.
33834 * interface.cs: Implement `Define'.
33836 * modifiers.cs: Map Modifiers.constants to
33837 System.Reflection.TypeAttribute flags.
33839 * class.cs: Keep track of types and user-defined types.
33840 (BuilderInit): New method for creating an assembly
33841 (ResolveType): New function to launch the resolution process, only
33842 used by interfaces for now.
33844 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33845 that are inserted into the name space.
33847 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33849 * ARGH. I have screwed up my tree so many times due to the use of
33850 rsync rather than using CVS. Going to fix this at once.
33852 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33855 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33857 * Experiment successful: Use System.Type rather that our own
33860 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33862 * cs-parser.jay: Removed nsAliases from here.
33864 Use new namespaces, handle `using XXX;'
33866 * namespace.cs: Reimplemented namespace handling, use a recursive
33867 definition of the class. Now we can keep track of using clauses
33868 and catch invalid using clauses.
33870 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33872 * gen-treedump.cs: Adapted for all the renaming.
33874 * expression.cs (Expression): this class now has a Type property
33875 which returns an expression Type.
33877 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33878 `Type', as this has a different meaning now in the base
33880 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33882 * interface.cs, class.cs: Removed from all the sources the
33883 references to signature computation, as we can not do method
33884 signature computation during the parsing time, as we are not
33885 trying to solve at that point distinguishing:
33889 void a (NS.Blah x) {}
33892 Which depending on the context might be valid or not, as we do not
33893 know if Blah is the same thing as NS.Blah at that point.
33895 * Redid everything so the code uses TypeRefs now instead of
33896 Types. TypeRefs are just temporary type placeholders, that need
33897 to be resolved. They initially have a pointer to a string and the
33898 current scope in which they are used. This is used later by the
33899 compiler to resolve the reference to an actual Type.
33901 * DeclSpace is no longer a CIR.Type, and neither are
33902 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33903 are all DeclSpaces, but no Types.
33905 * type.cs (TypeRefManager): This implements the TypeRef manager,
33906 which keeps track of all the types that need to be resolved after
33907 the parsing has finished.
33909 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33911 * ARGH. We are going to have to store `foreach' as a class rather
33912 than resolving it, as we need to verify error 1579 after name
33913 resolution. *OR* we could keep a flag that says `This request to
33914 IEnumerator comes from a foreach statement' which we can then use
33915 to generate the error.
33917 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33919 * class.cs (TypeContainer.AddMethod): we now add methods to the
33920 MethodGroup instead of the method hashtable.
33922 * expression.cs: Add MethodGroup abstraction, which gets us one
33923 step closer to the specification in the way we handle method
33926 * cs-parser.jay (primary_expression): qualified_identifier now
33927 tried to match up an identifier to a local variable reference or
33928 to a parameter reference.
33930 current_local_parameters is now a parser global variable that
33931 points to the current parameters for the block, used during name
33934 (property_declaration): Now creates an implicit `value' argument to
33937 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33939 * parameter.cs: Do not use `param' arguments as part of the
33940 signature, per the spec.
33942 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33944 * decl.cs: Base class for classes, structs and interfaces. This
33945 is the "Declaration Space"
33947 * cs-parser.jay: Use CheckDef for checking declaration errors
33948 instead of having one on each function.
33950 * class.cs: Factor out some code for handling error handling in
33951 accordance to the "Declarations" section in the "Basic Concepts"
33952 chapter in the ECMA C# spec.
33954 * interface.cs: Make all interface member classes derive from
33955 InterfaceMemberBase.
33957 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33959 * Many things: all interfaces are parsed and generated in
33960 gen-treedump. Support for member variables, constructors,
33961 destructors, properties, constants is there.
33963 Beginning of the IL backend, but very little done, just there for
33966 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33968 * cs-parser.jay: Fix labeled statement.
33970 * cs-tokenizer.cs (escape): Escape " and ' always.
33971 ref_line, ref_name: keep track of the line/filename as instructed
33972 by #line by the compiler.
33975 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33977 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33978 to match the values in System.CodeDOM.
33980 Divid renamed to Divide.
33982 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33984 (Statements.set): remove.
33986 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33989 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33990 falseStatements always have valid values.
33992 * cs-parser.jay: Use System.CodeDOM now.