1 2005-01-11 Raja R Harinath <rharinath@novell.com>
3 Improve standard-compliance of simple name and member access
4 resolution. Fixes bugs #52697, #57200, #67520, #69519.
5 * ecore.cs (FullNamedExpression): New abstract base class
6 for Namespaces and TypeExpressions.
7 (ResolveFlags.SimpleName): Remove.
8 (SimpleName): Remove support for dotted names.
9 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
10 DeclSpace.FindType and DeclSpace.LookupType.
11 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
12 (Expression.ExprClassName): Make member function.
13 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
14 a namespace. Remove creation of dotted "SimpleName"s.
15 (MemberAccess.DoResolve): Likewise.
16 * decl.cs (DeclSpace.Cache): Make private.
17 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
18 (DeclSpace.FindType): Update.
19 (DeclSpace.LookupType): Move here from RootContext. Return a
21 * namespace.cs (Namespace): Derive from FullNamedExpression
22 so that it can be part of expression resolution.
23 (Namespace.Lookup): Return an FullNamedExpression.
24 (NamespaceEntry.LookupAlias): Lookup aliases only in current
26 * rootcontext.cs (NamespaceLookup): Remove.
27 (LookupType): Move to DeclSpace.
28 * attribute.cs (CheckAttributeType): Update.
29 * doc.cs (FindDocumentedType): Remove allowAlias argument.
30 (FindDocumentedTypeNonArray): Likewise.
32 2005-01-11 Raja R Harinath <rharinath@novell.com>
34 Fix cs0509.cs, cs1632.cs.
35 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
36 is the same as IsInterface.
37 (TypeContainer.GetClassBases): Likewise.
38 * statement.cs (LabeledStatement.ig): New field.
39 (LabeledStatement.LabelTarget): Save ILGenerator which created the
41 (LabeledStatement.DoEmit): Check that the label was created with
44 2005-01-10 Marek Safar <marek.safar@seznam.cz>
47 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
48 accessors to its properties.
50 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
51 from accessors to property.
53 2005-01-10 Marek Safar <marek.safar@seznam.cz>
56 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
59 2005-01-08 Miguel de Icaza <miguel@ximian.com>
61 * attribute.cs: Check for null and empty strings.
63 I have lost another battle to Paolo.
65 2005-01-07 Marek Safar <marek.safar@seznam.cz>
68 * class.cs (PropertyMethod): Set Parent field in ctors.
69 (SetMethod.InternalParameters): Add unsafe switch hack.
70 Override MarkForDuplicationCheck where it is appropriate.
72 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
73 It says whether container allows members with the same name.
75 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
76 Removed is_method parameter.
78 2005-01-06 Duncan Mak <duncan@ximian.com>
80 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
81 because the previous change led to incorrect reporting of CS1032
82 ("Cannot define/undefine preprocessor symbols after first token in
83 file"). Instead of using `tokens_seen' as the only flag that
84 triggers CS1040, introduce `comments_seen'. This new flag is used
85 to signify having seen comments on the current line, so it is
86 unset after a newline.
88 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
90 * doc.cs : When searching for a type, find nested type too.
91 This fixes bug #71040.
93 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
96 - Warn missing member comment on those classes which also does not
97 have doc comments. Fixed bug #71041.
98 - Don't warn missing doc comment on default constructor.
101 2005-01-06 Duncan Mak <duncan@ximian.com>
103 * cs-tokenizer.cs (xtoken): After handling traditional C-style
104 comments, set `tokens_seen' to true. This allows us to detect
105 misplaced preprocessor directives (i.e. not at the beginning of
106 the a line, nor after whitespaces). In that case, report error
107 CS1040. This fixes bug #56460.
109 * cs-parser.jay (interface_member_declaration): Add checks for
110 IsExplicitImpl, and report CS0541 error if an interface member is
111 defined as an explicit interface declaration.
113 2005-01-06 Marek Safar <marek.safar@seznam.cz>
116 * class.cs (PropertyMethod): Set Parent field in ctors.
117 (SetMethod.InternalParameters): Add unsafe switch hack.
119 * decl.cs (MemberCore.Parent): Cannot be readonly.
121 2005-01-06 Raja R Harinath <rharinath@novell.com>
123 * decl.cs (DeclSpace.ResolveType): Remove.
124 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
125 Merge in code from ...
126 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
127 * class.cs, enum.cs: Update to changes.
129 2005-01-06 Miguel de Icaza <miguel@ximian.com>
131 * anonymous.cs: Ensure that we init the scope of our parent if it
132 has not been initialized yet.
134 2004-12-30 Duncan Mak <duncan@ximian.com>
136 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
137 if field.FieldBuilder is null. Fixes #70758.
139 * convert.cs: Fixed some typos and updated some of the comments.
140 (ImplicitStandardConversionExists):
141 (TryImplicitIntConversion): If `target_type' is an interface and
142 the type of `ic' implements this interface, return true or a new
143 BoxedCast instead of null. This fixes #70468.
145 2004-12-29 Duncan Mak <duncan@ximian.com>
147 * expression.cs (Argument.Emit): Check that Expr is
148 IMemoryLocation before casting to it, and report CS1510 otherwise.
152 2004-12-21 Ben Maurer <bmaurer@ximian.com>
154 * statement.cs (Block.ThisVariable): remove the recursion here, to
155 make the --profile more sane.
157 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
159 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
160 assembly, by JB Evain.
162 2004-12-17 Raja R Harinath <rharinath@novell.com>
164 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
165 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
166 "parent" refers to enclosing type/class. "base" refers to superclass.
168 2004-12-17 Raja R Harinath <rharinath@novell.com>
170 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
171 Ensure that we only have GlobalAttributes.
172 * attribute.cs (Attribute.Emit): Make non-virtual.
173 (GlobalAttribute.Emit): Remove.
174 (Attribute.Resolve): Make virtual.
175 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
176 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
177 the argument. Don't create one.
178 (Attribute.GetObsoleteAttribute): Likewise.
179 (Attribute.GetClsCompliantAttributeValue): Likewise.
180 * class.cs, decl.cs: Update to changes.
182 2004-12-17 Marek Safar <marek.safar@seznam.cz>
184 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
186 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
188 * statement.cs (Foreach.Resolve): Add error 186 report.
190 2004-12-16 Marek Safar <marek.safar@seznam.cz>
192 * expression.cs (Conditional.DoResolve): Add warning 429.
194 * statement.cs (If.Resolve): Add warning 665.
196 2004-12-16 Raja R Harinath <rharinath@novell.com>
198 New invariant: RootContext.Tree.Types.NamespaceEntry == null
199 except when in the parser, and in GlobalAttribute.
200 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
201 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
202 RootContext.Tree.Types.NamespaceEntry once work is done.
203 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
204 and resets RootContext.Tree.Types.NamespaceEntry.
206 2004-12-15 Marek Safar <marek.safar@seznam.cz>
208 * cs-parser.jay: Don't create a block for every variable.
210 2004-12-14 Miguel de Icaza <miguel@ximian.com>
212 * location.cs: Provide extra information.
214 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
215 variables from the captured environment, it is the ldarg_0.
217 2004-12-14 Marek Safar <marek.safar@seznam.cz>
219 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
222 * class.cs: Changed warning level for 169 to avoid developer
223 displeasure from warning flooding. It will be changed back when they
224 fix most of current BCL warnings.
226 * RootContext.cs: Pushed default WarningLevel to 3.
228 * statement.cs: Removed unused variable.
230 2004-12-14 Marek Safar <marek.safar@seznam.cz>
232 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
233 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
234 Add error 502 report.
235 (StaticClass.DefineType): Add error 441 report.
236 (Class.AllowedModifiersProp): New virtual property as temporary
237 extension to AllowedModifiers.
238 (Class.DefineType): Add error 418 report. Moved ModFlags check here
239 to share implementation with StaticClass and don't call virtual
242 * driver.cs (MainDriver): Add error 1558 test.
244 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
245 report. Moved error 36 test here.
247 * statement.cs (Throw.Resolve): Add error 724 report.
249 * typemanager.cs: Add out_attribute_type core type.
251 2004-12-13 Marek Safar <marek.safar@seznam.cz>
253 * class.cs (TypeContainer.VerifyClsCompliance): Add error
255 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
257 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
260 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
262 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
263 Add error 3023 report.
264 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
266 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
269 2004-12-12 John Luke <john.luke@gmail.com>
271 * driver.cs (AddArgs): take -- into account when
272 adding arguments, fixes bug 65710
274 2004-12-12 Martin Baulig <martin@ximian.com>
276 * expression.cs (Unary.TryReduceNegative): Added support for
277 SByteConstant and ByteConstant.
278 (Unary.Reduce): Check error values from TryReduceNegative().
280 2004-12-10 Marek Safar <marek.safar@seznam.cz>
282 * attributes.cs (Attribute.Resolve): Avoid multiple error report
283 and report exception as error 182.
285 2004-12-10 Raja R Harinath <rharinath@novell.com>
287 * driver.cs (Main): Fix message when there are warnings.
289 2004-12-09 Miguel de Icaza <miguel@ximian.com>
291 * delegate.cs: Fixed my fix from yesterday, sorry about that.
293 2004-12-09 Marek Safar <marek.safar@seznam.cz>
295 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
296 Reduced number of warnings.
298 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
300 2004-12-08 Miguel de Icaza <miguel@ximian.com>
302 * driver.cs: Removed message.
304 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
306 2004-12-08 <vargaz@freemail.hu>
308 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
310 2004-12-08 Martin Baulig <martin@ximian.com>
312 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
313 instead of a CS3002 for properties and indexer.
315 2004-12-08 Martin Baulig <martin@ximian.com>
317 * decl.cs (MemberName.ToString): Make this work again.
319 2004-12-08 Marek Safar <marek.safar@seznam.cz>
321 * attribute.cs (Resolve): Add error 591 detection.
323 * class.cs (FieldMember.Define): Add error 1547 detection.
324 (Indexer.Define): Add error 620 detection.
325 (Operator.Define): Add error 590 detection.
327 * ecore.cs: Missing argument for error 79.
329 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
332 2004-12-07 Marek Safar <marek.safar@seznam.cz>
335 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
338 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
340 * cs-parser.jay : handle doc comments on implicit/explicit operators.
341 Some operator comments were suppressed.
342 * doc.cs : Implicit/explicit operator name in doc comments are like
343 "op_Explicit(type)~returnType", so added suffix handling.
345 2004-12-07 Martin Baulig <martin@ximian.com>
348 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
349 (MemberCore.GetClsCompliantAttributeValue): Likewise.
350 (DeclSpace.ec): New protected field; store the EmitContext here.
351 (DeclSpace.EmitContext): New public property; moved here from
353 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
356 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
357 (Enum.Emit): Don't create a new EmitContext.
359 * delegate.cs (Delegate.DefineType): Always create the
362 * iterators.cs (Iterators.DefineIterator): Create a new
363 EmitContext and store it in `ec'.
365 2004-08-24 Martin Baulig <martin@ximian.com>
368 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
369 this for accessibility checks.
370 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
371 IsNestedFamilyAccessible.
372 (TypeManager.IsSubclassOf): New method, do what the name actually
375 2004-12-06 Raja R Harinath <rharinath@novell.com>
377 Fix crash on cs0657-17.cs.
378 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
379 Use RootContext.Tree.Types, not 'new RootTypes ()'.
380 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
381 the case where the NamespaceEntry gets overwritten.
383 2004-12-06 Marek Safar <marek.safar@seznam.cz>
386 * ecore.cs (ResolveBoolean): Tiny refactoring.
388 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
389 of right expression resolving when left is false constant and
390 operator is LogicalAnd OR true constant and operator is LogicalOr.
392 * statement.cs (ResolveUnreachable): Always reports warning.
394 2004-12-05 Miguel de Icaza <miguel@ximian.com>
396 * class.cs: Distinguish between 1721 and 1722 (just a little help
399 2004-12-03 Miguel de Icaza <miguel@ximian.com>
401 * delegate.cs: Only allow this on new versions of the language.
403 2004-12-02 Duncan Mak <duncan@ximian.com>
405 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
407 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
408 here as a static method. Take an additional bool out parameter
409 `must_do_cs1540_check' for signaling to InstanceResolve.
410 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
411 member field from PropertyExpr class and made it an argument of
413 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
414 check for MarshalByRefObject, and report CS0122 instead of CS1540.
415 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
416 and `remove_accessor' as well as InstanceResolve: report CS0122
421 2004-12-03 Raja R Harinath <rharinath@novell.com>
423 Fix test-327.cs, test-328.cs, and put in early infrastructure
424 for eventually fixing #52697.
425 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
426 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
428 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
429 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
430 (VerifyUsing, error246): Update.
431 * rootcontext.cs (RootContext.NamespaceLookup): Just use
432 'NamespaceEntry.LookupNamespaceOrType'.
434 2004-12-03 Martin Baulig <martin@ximian.com>
436 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
437 method as our child, call AnonymousMethod.Compatible() on it.
439 2004-12-03 Raja R Harinath <rharinath@novell.com>
441 Disable XML documentation support in 'basic' profile.
442 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
443 Redirect XmlElement to System.Object.
444 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
445 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
446 * mcs.exe.sources: Add doc-bootstrap.cs.
447 * doc-bootstrap.cs: New file. Contains empty stub implementation
450 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
452 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
453 comments are allowed.
455 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
457 * delegate.cs: Add checks for subtypes in paramaters and return values
458 in VerifyMethod () to add support for Covariance/Contravariance
461 2004-12-02 Miguel de Icaza <miguel@ximian.com>
463 * report.cs: Remove extra closing parenthesis.
465 * convert.cs (Error_CannotImplicitConversion): If the name of the
466 types are the same, provide some extra information.
468 * class.cs (FieldBase): Use an unused bit field from the field to
469 encode the `has_offset' property from the FieldMember. This saves
470 a couple of Ks on bootstrap compilation.
472 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
473 method as our child, return the AnonymousMethod resolved
476 * expression.cs (New.DoResolve): Allow return values from
477 NewDelegate to also include AnonymousMethods.
481 2004-12-02 Marek Safar <marek.safar@seznam.cz>
484 * attribute.cs (Resolve): Improved implementation of params
487 * support.cs (ParameterData): Add HasParams to be faster.
489 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
491 all things are for /doc support:
493 * doc.cs: new file that supports XML documentation generation.
494 * mcs.exe.sources: added doc.cs.
496 Handle /doc command line option.
497 Report error 2006 instead of 5 for missing file name for /doc.
498 Generate XML documentation when required, after type resolution.
500 Added support for picking up documentation (/// and /** ... */),
501 including a new XmlCommentState enumeration.
503 Added lines to fill Documentation element for field, constant,
504 property, indexer, method, constructor, destructor, operator, event
505 and class, struct, interface, delegate, enum.
506 Added lines to warn incorrect comment.
508 Added Documentation field (passed only when /doc was specified).
510 Added DocComment, DocCommentHeader, GenerateDocComment() and
511 OnGenerateDocComment() and some supporting private members for
512 /doc feature to MemberCore.
514 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
516 Added overriden DocCommentHeader.
518 Added overriden DocCommentHeader and GenerateDocComment().
520 2004-12-01 Miguel de Icaza <miguel@ximian.com>
522 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
523 unwrapping the enumeration values, chain to
524 DoConstantNumericPromotions again, so we can promote things to the
525 fundamental types (takes care of enums that are bytes, sbytes).
529 2004-12-01 Raja R Harinath <rharinath@novell.com>
531 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
532 Fix long-standing bug in type-lookup. Use FindType instead of
533 LookupType when ec.ResolvingTypeTree.
534 (Attribute.ResolveType, Attribute.Resolve)
535 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
537 (Attributes.Search): Remove internal version. Update.
538 (Attributes.SearchMulti): Update.
539 (Attributes.GetClsCompliantAttribute): Remove.
540 (Attributes.GetIndexerNameAttribute): Remove.
541 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
542 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
543 * class.cs (Indexer.Define): Likewise.
545 2004-12-01 Marek Safar <marek.safar@seznam.cz>
548 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
549 MarshallByReference members access.
551 * expression.cs: Use CheckMarshallByRefAccess;
552 Better error CS0197 message.
554 * report.cs: Print whole related error message.
556 2004-11-30 Raja R Harinath <rharinath@novell.com>
558 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
559 the current directory to help debugging.
561 2004-11-29 Marek Safar <marek.safar@seznam.cz>
563 * class (GetClassBases): Better error 60 report.
564 (EventProperty): Disabled warning 67 detection.
566 2004-11-29 Marek Safar <marek.safar@seznam.cz>
569 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
571 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
574 2004-11-29 Marek Safar <marek.safar@seznam.cz>
577 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
579 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
581 2004-11-26 Miguel de Icaza <miguel@ximian.com>
583 * attribute.cs (Attribute.Resolve): Refine error reporting and
584 report a cs0117 if the identifier does not exist, to distinguish
585 from 0617 which is a miss-use of the actual identifier.
587 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
588 between cs0070 and cs0079.
590 * class.cs (MemberBase.DoDefine): When reporting a wrong
591 accessibility level, we use MethodCore to compare instead of
592 Method (this was a regression in some refactoring effort).
594 So now we correctly report cs0056 again.
596 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
597 testing the target_type (which was known to be object_type) and
598 not the source type (which is anonymous_method).
600 Fixed reporting of error cs1660.
602 * expression.cs (UserCast.Source): Expose the underlying cast.
604 * statement.cs (Switch.SwitchGoverningType): Sort the list of
605 allowed types to find a match to int32 first (most common).
607 In addition, it ignores any ImplicitUserConversions that did an
608 internal implicit conversion (as the switch statement allows only
609 one integral conversion to exist).
611 * class.cs (PartialContainer.Create): rename `name' to
612 `member_name' for clarity. Then replace the string calls with a
613 call to MemberName.GetPartialName, as now using
614 MemberName.ToString is an error (this is due to the side effects
615 it had, that were fixed in the past).
617 This will restore the error reporting on a number of partial class
618 errors that were missusing this (and getting an exception as a
619 results, which is now just a plain textual warning, because
620 yyparse debug output would crash otherwise).
622 2004-11-26 Raja R Harinath <rharinath@novell.com>
624 * Makefile (PROGRAM_INSTALL_DIR): Remove.
626 2004-11-25 Ben Maurer <bmaurer@ximian.com>
628 * rootcontext.cs (LookupType): Make sure to cache lookups that
629 don't give us a negative result. This saves about 5% of corlib
632 2004-11-25 Miguel de Icaza <miguel@ximian.com>
634 * report.cs (AbstractMessage.Print): messages are sent to stderr
636 * class.cs (TypeContainer.GetClassBases): It is an error to have a
637 non-interface in the list of interfaces (at this point, either
638 parent was properly set, or a base class is being listed in the
641 This flags error 1722, and resolves the crash from bug 69259.
643 2004-11-25 Ben Maurer <bmaurer@ximian.com>
645 * statement.cs (Using.EmitExpressionFinally): make this work right
646 for valuetypes. Fixes 69926.
648 2004-11-25 Miguel de Icaza <miguel@ximian.com>
650 * const.cs (Const.ChangeType): Cope with the "0 literal can be
651 converted to an enum" here, before we try to change the underlying
652 type. This code exists, but it is a different code path than the
653 one used while encoding constants.
655 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
656 old bug: when converting from the null literal to a pointer,
657 return an EmptyCast, not the NullLiteral.
659 This fixes #69921, the recent null_type changes probably made this
662 (ImplicitReferenceConversionExists): In addition, resynchronized
663 the code here, so it matches the same code in
664 ImplicitReferenceConversionExists for the `from any class-type S
665 to any interface-type T'.
668 2004-11-25 Marek Safar <marek.safar@seznam.cz>
670 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
672 2004-11-24 Miguel de Icaza <miguel@ximian.com>
674 * cs-parser.jay: Use verbosity accordingly.
676 2004-11-24 Marek Safar <marek.safar@seznam.cz>
678 * expression.cs (Unary.ResolveOperator): Do not report warning;
679 AddressOf reads from variable.
681 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
683 2004-11-24 Marek Safar <marek.safar@seznam.cz>
687 * attribute.cs (Attributable): Removed CheckTargets.
688 (Attributes.Emit): Explicit attribute targets are tested here.
690 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
691 not enabled for interfaces.
693 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
694 (GetAssemblyName): Ouch next bug there.
696 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
698 * expression.cs: Error 275 added.
700 2004-11-23 Marek Safar <marek.safar@seznam.cz>
702 Fix bug #69177 (Implemented decimal constant support)
704 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
705 (BinaryFold): Add DecimalConstant.
707 * const.cs (Define): Decimal constant
709 (ChangeType): Add decimal type handling.
710 (LookupConstantValue): Don't set value for decimal type but
711 emit DecimalConstantAttribute. Needed for constant optimization.
713 * constant.cs (ToDecimal): New method.
714 (ConvertToDecimal): New method.
715 (IntConstant): Implemented ConvertToDecimal.
716 (DecimalConstant.Emit): Emit optimized version for decimals in
719 * expression.cs (ResolveOperator): Changed order of constant
720 reduction to work correctly with native types which have
721 overloaded operators.
722 (ResolveMemberAccess): Extract constant value from attribute
725 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
727 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
728 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
729 (ChangeType): Decimal is special.
730 (TypeToCoreType): Add decimal type.
732 2004-11-22 Marek Safar <marek.safar@seznam.cz>
734 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
737 2004-11-22 Marek Safar <marek.safar@seznam.cz>
739 * class.cs (EventField.ApplyAttributeBuilder): Fix error
742 2004-11-19 Marek Safar <marek.safar@seznam.cz>
744 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
746 * pending.cs (PendingImplementation): Grab only interfaces.
748 2004-11-19 Marek Safar <marek.safar@seznam.cz>
750 * statement.cs (ForeachHelperMethods): Add location member and
753 2004-11-19 Raja R Harinath <rharinath@novell.com>
755 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
756 automatically handled by executable.make.
757 (PROGRAM): Make profile-specific.
759 2004-11-18 Marek Safar <marek.safar@seznam.cz>
761 * expression.cs (DoResolveBase): Fixed wrong warning for out
764 2004-11-18 Martin Baulig <martin@ximian.com>
766 Merged latest changes into gmcs. Please keep this comment in
767 here, it makes it easier for me to see what changed in MCS since
768 the last time I merged.
770 2004-11-17 Raja R Harinath <rharinath@novell.com>
772 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
773 (TypeHandle.GetMemberCache): New.
774 (TypeHandle.TypeHandle): Update.
775 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
776 (TypeManager.LookupParentInterfacesCache):
777 Rename from LookupInterfaceCache. Optimize slightly.
778 (TypeManager.MemberLookup_FindMembers): Update.
779 * decl.cs (MemberCache.MemberCache): Set Container to null in the
781 (AddCacheContents): Rename from AddHashtable.
782 * class.cs (TypeContainer.parent_container): Remove.
783 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
784 (TypeContainer.DoDefineMembers): Don't initialize it.
785 Update to name changes.
787 2004-11-17 Miguel de Icaza <miguel@ximian.com>
789 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
790 that factors the code to check access modifiers on override.
792 (PropertyBase): Use the code here.
794 Patch from Lluis S'anchez, fixes bug #69361.
796 2004-11-15 Miguel de Icaza <miguel@ximian.com>
798 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
799 routine that is used to report the use of a captured variable
800 whose address has been taken.
802 There are two checks: one when variables are being captured and
803 the other check is when the address of a variable is taken.
805 (because an anonymous methods might be resolved before *or* after
806 the address has been taken) and
808 * expression.cs (Conditional.DoResolve): Remove the special
809 casing that Martin added to trueExpr and falseExpr being both
810 NullLiteral. We get the right behavior now just by introducing
811 the null_type into the compiler.
813 * convert.cs (ExplicitConversion): Change the code to use
814 null_type instead of testing `expr is NullLiteral'.
815 (ImplicitConversionStandard): use null_type too.
816 (ImplicitReferenceConversionExists): use null_type too.
817 (ImplicitReferenceConversion): use null_type too.
819 * literal.cs: The type of `NullLiteral' is now null_type instead
821 (Resolve): Set the type here.
823 * typemanager.cs: Introduce null_type.
825 2004-11-17 Martin Baulig <martin@ximian.com>
827 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
828 direction, like FindMembers() does. Fixes #69546, testcase is in
831 2004-11-16 Martin Baulig <martin@ximian.com>
833 This is based on a patch from Marek Safar, see bug #69082.
834 Fixes bugs #63705 and #67130.
836 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
837 method; create a MemberCache for an interface type and cache the
840 * decl.cs (IMemberContainer.ParentContainer): Removed.
841 (IMemberContainer.ParentCache): New property.
842 (MemberCache.SetupCacheForInterface): Removed.
843 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
844 to create a cache for an interface's "parent".
846 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
849 2004-11-16 Martin Baulig <martin@ximian.com>
851 Merged back from gmcs; these changes already went into gmcs a
855 (TypeManager.AddUserType): Removed the `ifaces' argument.
856 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
858 (TypeManager.AddUserInterface): Removed.
859 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
861 (TypeManager.GetInterfaces): Likewise.
862 (TypeManager.GetExplicitInterfaces): Likewise.
864 * ecore.cs (TypeExpr.GetInterfaces): Removed.
866 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
867 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
869 2004-11-14 Ben Maurer <bmaurer@ximian.com>
871 * statement.cs: Avoid adding bools to a hashtable.
873 2004-11-07 Miguel de Icaza <miguel@ximian.com>
875 * expression.cs (Invocation.OverloadResolve): Flag error if we are
876 calling an unsafe method from a safe location.
878 2004-11-06 Marek Safar <marek.safar@seznam.cz>
881 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
883 2004-11-06 Miguel de Icaza <miguel@ximian.com>
885 * namespace.cs (VerifyUsing): use GetPartialName instead of
888 2004-11-05 Miguel de Icaza <miguel@ximian.com>
890 * statement.cs (Return.Resolve): Fix regression in typo: if
891 `in_exc', we have to request a NeedReturnLabel, this was a typo
892 introduced in the anonymous method check-in. Fixes #69131.
894 * Indexers were using the ShortName when defining themselves,
895 causing a regression in the compiler bootstrap when applying the
896 patch from 2004-11-02 (first part), now they use their full name
899 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
901 * driver.cs: Strip the path from the names of embedded resources. Fixes
904 2004-11-04 Raja R Harinath <rharinath@novell.com>
906 Fix error message regression: cs0104-2.cs.
907 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
908 (AliasEntry.Resolve): Update.
909 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
911 (RootContext.LookupType): Update.
913 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
915 * cs-parser.jay: Add support for handling accessor modifiers
916 * class: Add support port accessor modifiers and error checking,
917 define PropertyMethod.Define as virtual (not abstract anymore)
918 * ecore.cs: Add checking for proeprties access with access modifiers
919 * iterators.cs: Modify Accessor constructor call based in the modified
921 2004-11-02 Ben Maurer <bmaurer@ximian.com>
923 * expression.cs (StringConcat): Handle being called twice,
924 as when we have a concat in a field init with more than two
927 2004-11-02 Miguel de Icaza <miguel@ximian.com>
929 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
930 special case explicit implementations, we should always produce
931 the .property or .event declaration.
933 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
934 since it will not return correct data if people use this
935 unresolved in the presence of using statements (see test-313).
937 * class.cs (MethodData.Define): If we are an explicit interface
938 implementation, set the method name to the full name of the
939 interface plus the name of the method.
941 Notice that using the method.MethodName.GetFullName() does not
942 work, as it will only contain the name as declared on the source
943 file (it can be a shorthand in the presence of using statements)
944 and not the fully qualifed type name, for example:
948 class D : ICloneable {
949 object ICloneable.Clone () {
953 Would produce a method called `ICloneable.Clone' instead of
954 `System.ICloneable.Clone'.
956 * namespace.cs (Alias.Resolve): Use GetPartialName.
958 2004-11-01 Marek Safar <marek.safar@seznam.cz>
960 * cs-parser.jay: Add error 1055 report.
962 2004-11-01 Miguel de Icaza <miguel@ximian.com>
964 * assign.cs (Assign.DoResolve): Only do the transform of
965 assignment into a New if the types are compatible, if not, fall
966 through and let the implicit code deal with the errors and with
967 the necessary conversions.
969 2004-11-01 Marek Safar <marek.safar@seznam.cz>
971 * cs-parser.jay: Add error 1031 report.
973 * cs-tokenizer.cs: Add location for error 1038.
975 2004-10-31 Marek Safar <marek.safar@seznam.cz>
977 * cs-parser.jay: Add error 1016 report.
979 2004-10-31 Marek Safar <marek.safar@seznam.cz>
981 * cs-parser.jay: Add errors 1575,1611 report.
983 2004-10-31 Marek Safar <marek.safar@seznam.cz>
985 * cs-parser.jay: Add error 1001 report.
987 2004-10-31 Marek Safar <marek.safar@seznam.cz>
990 * attribute.cs (GetMarshal): Add method argument for
991 caller identification.
993 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
994 agument for GetMarshal and RuntimeMissingSupport.
996 2004-10-31 Marek Safar <marek.safar@seznam.cz>
998 * attribute.cs (ExtractSecurityPermissionSet): Removed
999 TypeManager.code_access_permission_type.
1001 * typemanager.cs: Removed TypeManager.code_access_permission_type.
1003 2004-10-27 Miguel de Icaza <miguel@ximian.com>
1005 * expression.cs (LocalVariableReference.DoResolveLValue): Check
1006 for obsolete use of a variable here. Fixes regression on errors
1007 cs0619-25 and cs0619-26.
1009 2004-10-27 Marek Safar <marek.safar@seznam.cz>
1011 Fix #62358, implemented security attribute encoding.
1013 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
1014 Tests permitted SecurityAction for assembly or other types.
1015 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
1016 data from SecurityPermissionAttribute to PermisionSet class.
1018 * class.cs (ApplyAttributeBuilder): Added special handling
1019 for System.Security.Permissions.SecurityAttribute based types.
1021 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
1022 special handling for System.Security.Permissions.SecurityAttribute
1025 * enum.cs (ApplyAttributeBuilder): Added special handling
1026 for System.Security.Permissions.SecurityAttribute based types.
1028 * parameter.cs (ApplyAttributeBuilder): Added special handling
1029 for System.Security.Permissions.SecurityAttribute based types.
1031 * rootcontext.cs: Next 2 core types.
1033 * typemanager.cs (TypeManager.security_permission_attr_type):
1034 Built in type for the SecurityPermission Attribute.
1035 (code_access_permission_type): Build in type.
1037 2004-10-17 Miguel de Icaza <miguel@ximian.com>
1039 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
1040 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
1041 all of this information into
1042 EmitContext.EmitCapturedVariableInstance.
1044 * codegen.cs (EmitCapturedVariableInstance): move here the
1045 funcionality of emitting an ldarg.0 in the presence of a
1046 remapping. This centralizes the instance emit code.
1048 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
1049 then emit a load of this: it means that we have reached the
1050 topmost ScopeInfo: the one that contains the pointer to the
1051 instance of the class hosting the anonymous method.
1053 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
1054 captures to the topmost CaptureContext.
1056 2004-10-12 Miguel de Icaza <miguel@ximian.com>
1058 * expression.cs (LocalVariableReference): Move the knowledge about
1059 the iterators into codegen's EmitCapturedVariableInstance.
1061 2004-10-11 Miguel de Icaza <miguel@ximian.com>
1063 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
1064 all code paths return a value from an anonymous method (it is the
1065 same as the 161 error, but for anonymous methods).
1067 2004-10-08 Miguel de Icaza <miguel@ximian.com>
1069 The introduction of anonymous methods in the compiler changed
1070 various ways of doing things in the compiler. The most
1071 significant one is the hard split between the resolution phase
1072 and the emission phases of the compiler.
1074 For instance, routines that referenced local variables no
1075 longer can safely create temporary variables during the
1076 resolution phase: they must do so from the emission phase,
1077 since the variable might have been "captured", hence access to
1078 it can not be done with the local-variable operations from the runtime.
1082 (Block.Flags): New flag `IsTopLevel' to indicate that this block
1083 is a toplevel block.
1085 (ToplevelBlock): A new kind of Block, these are the blocks that
1086 are created by the parser for all toplevel method bodies. These
1087 include methods, accessors and anonymous methods.
1089 These contain some extra information not found in regular blocks:
1090 A pointer to an optional CaptureContext (for tracking captured
1091 local variables and parameters). A pointer to the parent
1094 (Return.Resolve): Catch missmatches when returning a value from an
1095 anonymous method (error 1662).
1096 Invoke NeedReturnLabel from the Resolve phase instead of the emit
1099 (Break.Resolve): ditto.
1101 (SwitchLabel): instead of defining the labels during the
1102 resolution phase, we now turned the public ILLabel and ILLabelCode
1103 labels into methods called GetILLabelCode() and GetILLabel() that
1104 only define the label during the Emit phase.
1106 (GotoCase): Track the SwitchLabel instead of the computed label
1107 (its contained therein). Emit the code by using
1108 SwitchLabel.GetILLabelCode ().
1110 (LocalInfo.Flags.Captured): A new flag has been introduce to track
1111 whether the Local has been captured or not.
1113 (LocalInfo.IsCaptured): New property, used to tell whether the
1114 local has been captured.
1116 * anonymous.cs: Vastly updated to contain the anonymous method
1119 The main classes here are: CaptureContext which tracks any
1120 captured information for a toplevel block and ScopeInfo used to
1121 track the activation frames for various local variables.
1123 Each toplevel block has an optional capture context associated
1124 with it. When a method contains an anonymous method both the
1125 toplevel method and the anonymous method will create a capture
1126 context. When variables or parameters are captured, they are
1127 recorded on the CaptureContext that owns them, for example:
1131 MyDelegate d = delegate {
1136 Here `a' will be recorded as captured on the toplevel
1137 CapturedContext, the inner captured context will not have anything
1138 (it will only have data if local variables or parameters from it
1139 are captured in a nested anonymous method.
1141 The ScopeInfo is used to track the activation frames for local
1142 variables, for example:
1144 for (int i = 0; i < 10; i++)
1145 for (int j = 0; j < 10; j++){
1146 MyDelegate d = delegate {
1151 At runtime this captures a single captured variable `i', but it
1152 captures 10 different versions of the variable `j'. The variable
1153 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1154 recorded on a child.
1156 The toplevel ScopeInfo will also track information like the `this'
1157 pointer if instance variables were referenced (this is necessary
1158 as the anonymous method lives inside a nested class in the host
1159 type of the method).
1161 (AnonymousMethod): Expanded to track the Toplevel, implement
1162 `AnonymousMethod.Compatible' to tell whether an anonymous method
1163 can be converted to a target delegate type.
1165 The routine now also produces the anonymous method content
1167 (AnonymousDelegate): A helper class that derives from
1168 DelegateCreation, this is used to generate the code necessary to
1169 produce the delegate for the anonymous method that was created.
1171 * assign.cs: API adjustments for new changes in
1172 Convert.ImplicitStandardConversionExists.
1174 * class.cs: Adjustments to cope with the fact that now toplevel
1175 blocks are of type `ToplevelBlock'.
1177 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1178 insteda of standard blocks.
1180 Flag errors if params arguments are passed to anonymous methods.
1182 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1183 `CurrentAnonymousMethod' which points to the current Anonymous
1184 Method. The variable points to the AnonymousMethod class that
1185 holds the code being compiled. It is set in the new EmitContext
1186 created for the anonymous method.
1188 (EmitContext.Phase): Introduce a variable and an enumeration to
1189 assist in enforcing some rules about when and where we are allowed
1190 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1191 only one that enfonces this right now).
1193 (EmitContext.HaveCaptureInfo): new helper method that returns
1194 whether we have a CapturedContext initialized.
1196 (EmitContext.CaptureVariable): New method used to register that a
1197 LocalInfo must be flagged for capturing.
1199 (EmitContext.CapturedParameter): New method used to register that a
1200 parameters must be flagged for capturing.
1202 (EmitContext.CapturedField): New method used to register that a
1203 field must be flagged for capturing.
1205 (EmitContext.HaveCapturedVariables,
1206 EmitContext.HaveCapturedFields): Return whether there are captured
1207 variables or fields.
1209 (EmitContext.EmitMethodHostInstance): This is used to emit the
1210 instance for the anonymous method. The instance might be null
1211 (static methods), this (for anonymous methods that capture nothing
1212 and happen to live side-by-side with the current method body) or a
1213 more complicated expression if the method has a CaptureContext.
1215 (EmitContext.EmitTopBlock): Routine that drives the emission of
1216 code: it will first resolve the top block, then emit any metadata
1217 and then emit the code. The split is done so that we can extract
1218 any anonymous methods and flag any captured variables/parameters.
1220 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1221 during this phase, the ILGenerator should not be used as labels
1222 and local variables declared here might not be accessible to any
1223 code that is part of an anonymous method.
1225 Exceptions to this include the temporary variables that are
1226 created by some statements internally for holding temporary
1229 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1232 (EmitContext.TemporaryReturn): This method is typically called
1233 from the Emit phase, and its the only place where we allow the
1234 ReturnLabel to be defined other than the EmitMeta. The reason is
1235 that otherwise we would have to duplicate a lot of logic in the
1236 Resolve phases of various methods that today is on the Emit
1239 (EmitContext.NeedReturnLabel): This no longer creates the label,
1240 as the ILGenerator is not valid during the resolve phase.
1242 (EmitContext.EmitThis): Extended the knowledge in this class to
1243 work in anonymous methods in addition to iterators.
1245 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1246 code is necessary on the stack to access the instance to a local
1247 variable (the variable will be accessed as a field).
1249 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1250 EmitContext.EmitAddressOfParameter): Routines to support
1251 parameters (not completed at this point).
1253 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1254 will also remove the parameters.
1256 * convert.cs (Convert): Define a `ConstantEC' which points to a
1257 null. This is just to prefity some code that uses
1258 ImplicitStandardConversion code and do not have an EmitContext
1261 The idea is to flag explicitly that at that point in time, it is
1262 known that the conversion will not trigger the delegate checking
1263 code in implicit conversions (which requires a valid
1266 Everywhere: pass new EmitContext parameter since
1267 ImplicitStandardConversionExists now requires it to check for
1268 anonymous method conversions.
1270 (Convert.ImplicitStandardConversionExists): If the type of an
1271 expression is the anonymous_method_type, and the type is a
1272 delegate, we invoke the AnonymousMethod.Compatible method to check
1273 whether an implicit conversion is possible.
1275 (Convert.ImplicitConversionStandard): Only do implicit method
1276 group conversions if the language level is not ISO_1.
1278 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1279 MethodInfo for the Invoke method. used by Delegate and
1282 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1283 method conversions if the target type is a delegate.
1285 Removed extra debugging nops.
1287 (LocalVariableReference): Turn the `local_info' into a public
1290 Add `prepared' field, the same hack used for FieldExprs to cope
1291 with composed assignments, as Local variables do not necessarily
1292 operate purely on the stack as they used to: they can be captured
1295 Add `temp' for a temporary result, like fields.
1297 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1299 It now copes with Local variables that are captured and emits the
1300 proper instance variable to load it from a field in the captured
1303 (ParameterReference.DoResolveBase): During the resolve phase,
1304 capture parameters if we are in an anonymous method.
1306 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1307 anonymous method, use the EmitContext helper routines to emit the
1308 parameter reference.
1310 * iterators.cs: Set RemapToProxy to true/false during the
1313 * parameters.cs (GetParameterByName): New helper method.
1315 * typemanager.cs (anonymous_method_type) a new type that
1316 represents an anonyous method. This is always an internal type,
1317 used as a fencepost to test against the anonymous-methodness of an
1320 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1322 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1324 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1326 2004-10-18 Martin Baulig <martin@ximian.com>
1328 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1329 `Type' directly, but call ResolveType() on it.
1330 (Catch.Resolve): Likewise.
1331 (Foreach.Resolve): Likewise.
1333 2004-10-18 Martin Baulig <martin@ximian.com>
1335 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1336 `Type' directly, but call ResolveType() on it.
1337 (Probe.DoResolve): Likewise.
1338 (ArrayCreation.LookupType): Likewise.
1339 (TypeOf.DoResolve): Likewise.
1340 (SizeOf.DoResolve): Likewise.
1342 2004-10-18 Martin Baulig <martin@ximian.com>
1344 * expression.cs (Invocation.BetterFunction): Put back
1345 TypeManager.TypeToCoreType().
1347 2004-10-18 Raja R Harinath <rharinath@novell.com>
1349 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1352 2004-10-18 Martin Baulig <martin@ximian.com>
1354 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1355 `Type' directly, but call ResolveType() on it.
1357 2004-10-18 Martin Baulig <martin@ximian.com>
1359 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1360 `Type' directly, but call ResolveType() on it.
1361 (MemberBase.DoDefine): Likewise.
1363 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1364 `Type' directly, but call ResolveType() on it.
1365 (ComposedCast.DoResolveAsTypeStep): Likewise.
1367 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1368 `Type' directly, but call ResolveType() on it.
1370 2004-10-17 John Luke <john.luke@gmail.com>
1372 * class.cs (Operator.GetSignatureForError): use CSharpName
1374 * parameter.cs (Parameter.GetSignatureForError): Returns
1375 correct name even if was not defined.
1377 2004-10-13 Raja R Harinath <rharinath@novell.com>
1380 * class.cs (TypeContainer.EmitContext): New property.
1381 (DefineNestedTypes): Create an emitcontext for each part.
1382 (MethodCore.DoDefineParameters): Use container's emitcontext.
1383 Pass type array to InternalParameters.
1384 (MemberBase.DoDefine): Use container's emitcontext.
1385 (FieldMember.Define): Likewise.
1386 (Event.Define): Likewise.
1387 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1388 Pass type array to InternalParameters.
1389 (SetIndexerMethod.GetParameterInfo): Likewise.
1390 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1391 * delegate.cs (Define): Pass emitcontext to
1392 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1393 array to InternalParameters.
1394 * expression.cs (ParameterReference.DoResolveBase): Pass
1395 emitcontext to GetParameterInfo.
1396 (ComposedCast.DoResolveAsTypeStep): Remove check on
1397 ec.ResolvingTypeTree.
1398 * parameter.cs (Parameter.Resolve): Change argument to
1399 EmitContext. Use ResolveAsTypeTerminal.
1400 (Parameter.GetSignature): Change argument to EmitContext.
1401 (Parameters.ComputeSignature): Likewise.
1402 (Parameters.ComputeParameterTypes): Likewise.
1403 (Parameters.GetParameterInfo): Likewise.
1404 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1405 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1406 * support.cs (InternalParameters..ctor): Remove variant that takes
1408 * typemanager.cs (system_intptr_expr): New.
1409 (InitExpressionTypes): Initialize it.
1411 2004-10-12 Chris Toshok <toshok@ximian.com>
1413 * cs-parser.jay: fix location for try_statement and catch_clause.
1415 2004-10-11 Martin Baulig <martin@ximian.com>
1417 * report.cs: Don't make --fatal abort on warnings, we have
1418 -warnaserror for that.
1420 2004-10-07 Raja R Harinath <rharinath@novell.com>
1422 More DeclSpace.ResolveType avoidance.
1423 * decl.cs (MemberCore.InUnsafe): New property.
1424 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1425 with newly created EmitContext.
1426 (FieldMember.Define): Likewise.
1427 * delegate.cs (Delegate.Define): Likewise.
1428 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1429 only if normal name-lookup fails.
1430 (TypeExpr.DoResolve): Enable error-checking.
1431 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1432 (SizeOf.DoResolve): Likewise.
1433 (ComposedCast.DoResolveAsTypeStep): Likewise.
1434 (StackAlloc.DoResolve): Likewise.
1435 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1436 (Block.Unsafe): New property.
1437 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1438 (Unsafe): Set 'unsafe' flag of contained block.
1439 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1440 (Fixed.Resolve): Likewise.
1441 (Catch.Resolve): Likewise.
1442 (Using.ResolveLocalVariableDecls): Likewise.
1443 (Foreach.Resolve): Likewise.
1445 2004-10-05 John Luke <john.luke@gmail.com>
1447 * cs-parser.jay: add location to error CS0175
1449 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1451 * ecore.cs (Expression.Constantity): Add support for turning null
1454 * const.cs (Const.Define): Allow constants to be reference types
1455 as long as the value is Null.
1457 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1459 * namespace.cs (NamespaceEntry.Using): No matter which warning
1460 level is set, check if this namespace name has already been added.
1462 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1464 * expression.cs: reftype [!=]= null should always use br[true,false].
1467 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1470 * attribute.cs: Enum conversion moved to
1471 GetAttributeArgumentExpression to be applied to the all
1474 2004-10-01 Raja R Harinath <rharinath@novell.com>
1476 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1477 * class.c (TypeContainer.DefineType): Flag error if
1478 base types aren't accessible due to access permissions.
1479 * decl.cs (DeclSpace.ResolveType): Move logic to
1480 Expression.ResolveAsTypeTerminal.
1481 (DeclSpace.ResolveTypeExpr): Thin layer over
1482 Expression.ResolveAsTypeTerminal.
1483 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1484 Refactor code into NestedAccess. Use it.
1485 (DeclSpace.NestedAccess): New.
1486 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1487 argument to silence errors. Check access permissions.
1488 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1489 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1490 (Cast.DoResolve): Likewise.
1491 (New.DoResolve): Likewise.
1492 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1493 (TypeOf.DoResolve): Likewise.
1495 * expression.cs (Invocation.BetterConversion): Return the Type of
1496 the better conversion. Implement section 14.4.2.3 more faithfully.
1497 (Invocation.BetterFunction): Make boolean. Make correspondence to
1498 section 14.4.2.2 explicit.
1499 (Invocation.OverloadResolve): Update.
1500 (Invocation): Remove is_base field.
1501 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1502 (Invocation.Emit): Likewise.
1504 2004-09-27 Raja R Harinath <rharinath@novell.com>
1506 * README: Update to changes.
1508 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1510 * cs-parser.jay: Reverted 642 warning fix.
1512 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1515 * decl.cs (FindMemberWithSameName): Indexer can have more than
1518 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1520 * expression.cs (LocalVariableReference.DoResolveLValue):
1521 Do not report warning 219 for out values.
1522 (EmptyExpression.Null): New member to avoid extra allocations.
1524 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1526 * cs-parser.jay: Fix wrong warning 642 report.
1528 * cs-tokenizer.cs (CheckNextToken): New helper;
1529 Inspect next character if is same as expected.
1531 2004-09-23 Martin Baulig <martin@ximian.com>
1533 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1534 (Convert.ImplicitReferenceConversionExists): Likewise.
1536 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1538 * class.cs (Operator.Define): Add error 448 and 559 report.
1540 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1542 * class.cs (MemberBase.IsTypePermitted): New protected
1543 method for checking error CS0610.
1545 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1547 * class.cs (TypeContainer.HasExplicitLayout): New property
1548 Returns whether container has StructLayout attribute set Explicit.
1549 (FieldMember): New abstract class for consts and fields.
1550 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1551 (Field): Reuse FieldMember.
1553 * const.cs (Const): Reuse FieldMember.
1555 * rootcontext.cs: EmitConstants call moved to class.
1557 2004-09-22 Martin Baulig <martin@ximian.com>
1559 Thanks to Peter Sestoft for this bug report.
1561 * expression.cs (Conditional): If both the `trueExpr' and the
1562 `falseExpr' is a NullLiteral, return a NullLiteral.
1564 2004-09-22 Martin Baulig <martin@ximian.com>
1566 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1567 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1568 for the "get_Current" call.
1570 2004-09-22 Martin Baulig <martin@ximian.com>
1572 Marek and me just fixed one of our oldest bugs: #28562 :-)
1574 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1576 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1577 we're an EnumConstant, just return that.
1578 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1579 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1580 to get the value which'll actually be written into the attribute.
1581 However, we have to use GetValue() to access the attribute's value
1584 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1586 * constant.cs (Constant.IsNegative): New abstract property
1589 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1590 (StackAlloc.DoResolve): Reused IsNegative.
1592 2004-09-21 Martin Baulig <martin@ximian.com>
1594 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1595 if we're used in an iterator, we may be called from different
1598 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1599 we actually have an exception block.
1601 2004-09-20 John Luke <jluke@cfl.rr.com>
1603 * class.cs, cs-parser.jay: Improve the error report for 1520:
1604 report the actual line where the error happens, not where the
1607 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1608 Pass location information that was available elsewhere.
1610 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1612 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1613 runtime to delay sign assemblies.
1615 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1617 * cs-parser.jay: Do not report the stack trace, this is barely
1620 2004-08-22 John Luke <john.luke@gmail.com>
1622 * driver.cs : check that a resource id is not already used
1623 before adding it, report CS1508 if it is, bug #63637
1625 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1627 * ecore.cs: Removed dead code.
1629 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1631 * class.cs: Do not report warning CS0067 on the interfaces.
1633 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1635 * cs-parser.jay: Add error 504 report.
1637 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1639 * rootcontext.cs: WarningLevel is 4 by default now.
1641 * statement.cs (Fixed.Resolve): Do not null
1644 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1647 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1648 deep search when property is not virtual.
1649 (PropertyExpr.ResolveAccessors): Make one call for both
1652 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1655 * statement.cs: Error 152 report constains also location.
1657 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1660 * const.cs: Explicitly set constant as static.
1662 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1665 * cs-parser.jay: Add error 1017 report.
1667 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1669 Fixed bug #59980, #64224
1670 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1672 * typemanager.cs (IsSpecialMethod): Simplified
1674 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1676 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1677 condition with better params.
1679 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1682 * attribute.cs (Resolve): Property has to have both
1685 2004-09-14 Martin Baulig <martin@ximian.com>
1687 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1689 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1692 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1693 called and is obsolete then this member suppress message
1694 when call is inside next [Obsolete] method or type.
1696 * expression.cs: Use TestObsoleteMethodUsage member.
1698 2004-09-14 Martin Baulig <martin@ximian.com>
1700 * cs-parser.jay: Sync a bit with the GMCS version.
1702 2004-09-14 Martin Baulig <martin@ximian.com>
1704 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1705 (CSharpParser.yacc_verbose_flag): New public field.
1707 * genericparser.cs: Removed.
1709 2004-09-14 Raja R Harinath <rharinath@novell.com>
1711 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
1713 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1715 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1717 2004-09-10 Martin Baulig <martin@ximian.com>
1719 Backported my MemberName changes from GMCS into MCS.
1721 - we are now using a special `MemberName' class instead of using
1722 strings; in GMCS, the `MemberName' also contains the type
1725 - changed the grammar rules a bit:
1726 * the old `member_name' is now a `namespace_or_type_name':
1727 The rule is that we use `namespace_or_type_name' everywhere
1728 where we expect either a "member name" (GetEnumerator) or a
1729 "member name" with an explicit interface name
1730 (IEnumerable.GetEnumerator).
1731 In GMCS, the explicit interface name may include type arguments
1732 (IEnumerable<T>.GetEnumerator).
1733 * we use `member_name' instead of just `IDENTIFIER' for
1735 The rule is that we use `member_name' wherever a member may
1736 have type parameters in GMCS.
1738 * decl.cs (MemberName): New public class.
1739 (MemberCore.MemberName): New public readonly field.
1740 (MemberCore.ctor): Take a `MemberName' argument, not a string.
1741 (DeclSpace): Likewise.
1743 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
1744 * enum.cs (Enum.ctor): Likewise.
1746 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
1748 (AliasEntry.ctor): Take a MemberName, not an Expression.
1749 (AliasEntry.UsingAlias): Likewise.
1751 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
1752 (IMethodData.MemberName): Changed type from string to MemberName.
1753 (MemberBase.ExplicitInterfaceName): Likewise.
1754 (AbstractPropertyEventMethod.SetupName): Make this private.
1755 (AbstractPropertyEventMethod.ctor): Added `string prefix'
1756 argument; compute the member name here.
1757 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
1758 on the `member.MemberName' and the `prefix'.
1760 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
1762 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
1763 thus, we get a `MemberName' instead of a `string'. These
1764 declarations may have type parameters in GMCS.
1765 (interface_method_declaration, delegate_declaration): Likewise.
1766 (class_declaration, interface_declaration): Likewise.
1767 (method_header): Use `namespace_or_type_name' instead of
1768 `member_name'. We may be an explicit interface implementation.
1769 (property_declaration, event_declaration): Likewise.
1770 (member_name): This is now just an `IDENTIFIER', not a
1771 `namespace_or_type_name'.
1772 (type_name, interface_type): Removed.
1773 (namespace_or_type_name): Return a MemberName, not an Expression.
1774 (primary_expression): Use `member_name' instead of `IDENTIFIER';
1775 call GetTypeExpression() on the MemberName to get an expression.
1776 (IndexerDeclaration.interface_type): Changed type from string to
1778 (MakeName): Operate on MemberName's instead of string's.
1780 2004-09-13 Raja R Harinath <rharinath@novell.com>
1783 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
1784 (NamespaceEntry.Lookup): Add new argument to flag if we want the
1785 lookup to avoid symbols introduced by 'using'.
1786 * rootcontext.cs (NamespaceLookup): Update.
1788 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1790 * class.cs (TypeContainer.DoDefineMembers): Do not call
1791 DefineDefaultConstructor for static classes.
1793 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1795 * attribute.cs (Attribute.Resolve): Add error 653 report.
1797 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1799 (Method.ApplyAttributeBuilder): Add error 685 report.
1800 (Operator.Define): Add error 564 report.
1802 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1804 * expression.cs (Invocation.DoResolve): Add error
1807 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1810 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1812 * class.cs (ConstructorInitializer.Resolve):
1813 Wrong error number (515->516).
1815 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1817 * class.cs (Indexer.Define): Add error 631 report.
1819 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1821 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1823 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1825 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1827 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1829 * cs-parser.jay: Added error CS0241 report.
1831 2004-09-10 Raja R Harinath <rharinath@novell.com>
1833 * cs-parser.jay (fixed_statement): Introduce a scope for the
1834 declaration in the 'fixed' statement.
1836 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1838 * cs-parser.jay: Added CS0230 error report.
1840 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1842 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1844 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1846 * expression.cs (Argument.Resolve): Added error CS0192 and
1849 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1851 C# 2.0 #pragma warning feature
1853 * cs-tokenizer.cs (PreProcessPragma): New method;
1854 Handles #pragma directive.
1856 * report.cs (WarningRegions): New class; Support
1857 class for #pragma warning directive. It tests whether
1858 warning is enabled for a given line.
1860 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1862 * const.cs: Add more descriptive error report, tahnks to
1865 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1867 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1869 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1871 * expression.cs: Apply patch from Ben: Remove dead code from
1872 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1873 as that code just threw an exception anwyays.
1875 * const.cs: Remove the call to the turnintoconstant, for details
1878 * literal.cs: The type of the null-literal is the null type; So
1879 we use a placeholder type (literal.cs:System.Null, defined here)
1882 * expression.cs (Conditional.DoResolve): Remove some old code that
1883 is no longer needed, conversions have been fixed.
1885 (ArrayCreationExpression.DoResolve): Return false if we fail to
1886 resolve the inner expression.
1888 2004-09-07 Raja R Harinath <rharinath@novell.com>
1891 * cs-parser.jay (delegate_declaration): Record a delegate
1892 declaration as a type declaration.
1893 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1895 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1897 * parameter.cs: Do not crash if the type can not be resolved.
1899 * expression.cs: Report errors with unsafe pointers, fixes #64896
1901 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1903 * expression.cs: Pointer arith always needs to do a conv.i
1904 if the operand is a long. fix 65320
1906 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1908 Fixed cs0619-37.cs, cs0619-38.cs
1910 * enum.cs (GetObsoleteAttribute): Removed.
1912 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1913 on Enum member is double staged. The first is tested member
1916 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1918 Fixed #56986, #63631, #65231
1920 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1921 adds member to name container.
1922 (TypeContainer.AddToTypeContainer): New method, adds type to
1924 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1925 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1926 AddOperator): Simplified by reusing AddToMemberContainer.
1927 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1929 (Method.CheckForDuplications): Fixed implementation to test all
1931 (MemberBase): Detection whether member is explicit interface
1932 implementation is now in constructor.
1933 (MemberBase.UpdateMemberName): Handles IndexerName.
1934 (Accessor): Changed to keep also location information.
1935 (AbstractPropertyEventMethod): Is derived from MemberCore.
1936 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1937 will be emited or not.
1938 (PropertyBase.AreAccessorsDuplicateImplementation):
1939 Tests whether accessors are not in collision with some method.
1940 (Operator): Is derived from MethodCore to simplify common
1943 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1945 (DeclSpace.AddToContainer): Adds the member to defined_names
1946 table. It tests for duplications and enclosing name conflicts.
1948 * enum.cs (EnumMember): Clean up to reuse the base structures
1950 2004-09-03 Martin Baulig <martin@ximian.com>
1952 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1953 into TypeContainer, to make partial classes work again.
1955 2004-09-03 Martin Baulig <martin@ximian.com>
1957 * rootcontext.cs (RootContext.V2): Removed.
1959 2004-03-23 Martin Baulig <martin@ximian.com>
1961 * expression.cs (Invocation.OverloadResolve): Added `bool
1962 may_fail' argument and use it instead of the Location.IsNull() hack.
1964 2004-09-03 Martin Baulig <martin@ximian.com>
1966 Merged latest changes into gmcs. Please keep this comment in
1967 here, it makes it easier for me to see what changed in MCS since
1968 the last time I merged.
1970 2004-09-03 Raja R Harinath <rharinath@novell.com>
1973 * expression.cs (BetterConversion): Don't allow either conversion
1974 to be null. Remove redundant implicit conversion test when 'q ==
1975 null' -- when this function is invoked, we already know that the
1976 implicit conversion exists.
1977 (BetterFunction): Assume that 'best' is non-null. Remove
1978 redundant reimplementation of IsApplicable when 'best' is null.
1979 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1980 number of arguments.
1981 (IsAncestralType): Extract from OverloadResolve.
1982 (OverloadResolve): Make robust to the MethodGroupExpr being
1983 unsorted. Implement all the logic of Section 14.5.5.1, and
1984 support overloading of methods from multiple applicable types.
1985 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1987 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1988 (RealError, Warning): Append type of report to related symbol.
1990 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1992 * enum.cs: Fixed CLS-Compliance checks for enum members.
1993 Error tests cs3008-8.cs, cs3014-8.cs
1995 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1997 Fixed bug #62342, #63102
1998 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1999 like ImplementMethod.
2001 2004-09-02 Marek Safar <marek.safar@seznam.cz>
2003 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2006 2004-09-02 Martin Baulig <martin@ximian.com>
2008 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
2009 TypeManager.GetArgumentTypes() rather than calling GetParameters()
2012 2004-09-01 Marek Safar <marek.safar@seznam.cz>
2014 C# 2.0 Static classes implemented
2016 * class.cs (TypeContainer): instance_constructors,
2017 initialized_fields, initialized_static_fields,
2018 default_constructor, base_inteface_types are protected to be
2019 accessible from StaticClass.
2020 (TypeContainer.DefineDefaultConstructor): New virtual method
2021 for custom default constructor generating
2022 (StaticClass): New class to handle "Static classes" feature.
2024 * cs-parser.jay: Handle static keyword on class like instance
2027 * driver.cs: Added "/langversion" command line switch with two
2028 options (iso-1, default).
2030 2004-08-31 Marek Safar <marek.safar@seznam.cz>
2032 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
2034 2004-08-31 Miguel de Icaza <miguel@ximian.com>
2036 * delegate.cs: Style.
2038 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
2040 * delegate.cs: Add seperate instance expr field for miguel.
2042 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2044 * PointerArithmetic (Resolve): make sure we are not doing
2045 pointer arith on void*. Also, make sure we are resolved
2046 by not setting eclass until resolve.
2048 All callers: Make sure that PointerArithmetic gets resolved.
2050 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
2052 * ArrayCreation (LookupType): If the type does not resolve
2053 to an array, give an error.
2055 2004-08-27 Marek Safar <marek.safar@seznam.cz>
2057 * statement.cs (Try.Resolve): Fixed bug #64222
2059 2004-08-27 Martin Baulig <martin@ximian.com>
2062 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
2065 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2067 * ecore.cs (Constantify): Get underlying type via
2068 System.Enum.GetUnderlyingType to avoid StackOverflow on the
2069 Windows in special cases.
2071 2004-08-26 Marek Safar <marek.safar@seznam.cz>
2073 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
2074 for obtaining also private methods.
2075 (GetRemoveMethod): Used GetRemoveMethod (true)
2076 for obtaining also private methods.
2078 2004-08-24 Martin Baulig <martin@ximian.com>
2080 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
2081 MethodAttributes.HideBySig for operators.
2083 2004-08-23 Martin Baulig <martin@ximian.com>
2085 Back to the old error reporting system :-)
2087 * report.cs (Message): Removed.
2088 (Report.MessageData, ErrorData, WarningData): Removed.
2089 (Report.Error, Warning): Back to the old system.
2091 2004-08-23 Martin Baulig <martin@ximian.com>
2093 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
2095 * class.cs (TypeContainer.ParentContainer): New public virtual
2096 method; replaces the explicit interface implementation.
2097 (ClassPart.ParentContainer): Override.
2099 2004-08-23 Martin Baulig <martin@ximian.com>
2101 * statement.cs (Switch): Added support for constant switches; see
2102 #59428 or test-285.cs.
2104 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2107 * statement.cs (GetEnumeratorFilter): Removed useless
2108 logic because C# specs is strict. GetEnumerator must be
2111 2004-08-22 Martin Baulig <martin@ximian.com>
2113 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
2114 a switch and may break, reset the barrier. Fixes #59867.
2116 2004-08-22 Marek Safar <marek.safar@seznam.cz>
2118 CLS-Compliance speed up (~5% for corlib)
2120 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
2121 New method. Tests container for CLS-Compliant names
2123 * class.cs (TypeContainer.VerifyClsName): New method.
2124 Checks whether container name is CLS Compliant.
2125 (Constructor): Implements IMethodData.
2127 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
2128 low-case table for CLS Compliance test.
2129 (MemberCache.VerifyClsParameterConflict): New method.
2130 Checks method parameters for CS3006 error.
2132 * enum.cs (EnumMember): Is derived from MemberCore.
2133 (Enum.VerifyClsName): Optimized for better performance.
2135 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2137 * report.cs: Renamed Error_T to Error and changed all
2140 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2142 * class.cs (TypeContainer.IndexerArrayList): New inner class
2143 container for indexers.
2144 (TypeContainer.DefaultIndexerName): New constant for default
2145 indexer name. Replaced all "Item" with this constant.
2146 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
2148 * typemanager.cs (TypeManager.default_member_ctor): Cache here
2149 DefaultMemberAttribute constructor.
2151 2004-08-05 Martin Baulig <martin@ximian.com>
2153 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
2156 2004-08-05 Marek Safar <marek.safar@seznam.cz>
2158 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
2159 multi platforms problem.
2161 * compiler.csproj: Included shared files.
2163 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2165 Fix bug 60333, 55971 in the more general way
2166 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2167 Added arg_type argument for constant conversion.
2168 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
2170 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2173 * class.cs (TypeContainer ): New inner classes MethodArrayList,
2174 OperatorArrayList, MethodCoreArrayList for typecontainer
2175 containers. Changed class member types to these new types.
2176 (MethodArrayList.DefineMembers): Added test for CS0659.
2178 2004-08-04 Miguel de Icaza <miguel@ximian.com>
2180 * cfold.cs: Synchronize the folding with the code in expression.cs
2181 Binary.DoNumericPromotions for uint operands.
2183 * attribute.cs: Revert patch from Raja, it introduced a regression
2184 while building Blam-1.2.1 (hard to isolate a test case).
2186 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2190 (TypeContainer.Define): Renamed to DefineContainerMembers because of
2192 (MethodCore.parent_method): New member. The method we're overriding
2193 if this is an override method.
2194 (MethodCore.CheckBase): Moved from Method class and made common.
2195 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
2197 (MethodCore.CheckForDuplications): New abstract method. For custom
2198 member duplication search in a container
2199 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
2200 method and its return type.
2201 (Event.conflict_symbol): New member. Symbol with same name in the
2205 (MemberCache.FindMemberWithSameName): New method. The method
2206 is looking for conflict with inherited symbols.
2208 2004-08-04 Martin Baulig <martin@ximian.com>
2210 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2212 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2214 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2216 * report.cs (Message): New enum for better error, warning reference in
2218 (MessageData): New inner abstract class. It generally handles printing of
2219 error and warning messages.
2220 Removed unused Error, Warning, Message methods.
2222 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2224 Fix for cs0592-8.cs test
2226 (Attributable.ValidAttributeTargets): Made public.
2227 (Attribute.ExplicitTarget): New member for explicit target value.
2228 (Attribute.CheckTargets): Now we translate explicit attribute
2229 target to Target here.
2231 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2233 * ecore.cs (MethodGroupExpr): new IsBase property.
2235 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2237 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2238 rather than an instance expr.
2240 (DelegateCreation.Emit): Use the method group rather than
2241 the instance expression. Also, if you have base.Foo as the
2242 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2244 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2246 (NewDelegate.DoResolve): Only check for the existance of Invoke
2247 if the method is going to be needed. Use MethodGroupExpr.
2249 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2251 * expression.cs: For pointer arith., make sure to use
2252 the size of the type, not the size of the pointer to
2255 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2258 * class.cs (Class): Added error CS0502 test.
2260 2004-08-03 John Luke <jluke@cfl.rr.com>
2261 Raja R Harinath <rharinath@novell.com>
2264 * attribute.cs (Attribute.complained_before): New flag.
2265 (Attribute.ResolveType, Attribute.Resolve),
2266 (Attribute.DefinePInvokeMethod): Set it.
2267 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2269 2004-08-03 Martin Baulig <martin@ximian.com>
2271 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2272 use a user-defined operator; we still need to do numeric
2273 promotions in case one argument is a builtin type and the other
2274 one has an implicit conversion to that type. Fixes #62322.
2276 2004-08-02 Martin Baulig <martin@ximian.com>
2278 * statement.cs (LocalInfo.Flags): Added `IsThis'.
2279 (LocalInfo.IsThis): New public property.
2280 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
2282 2004-08-01 Martin Baulig <martin@ximian.com>
2284 * class.cs (TypeContainer.GetClassBases): Don't set the default
2285 here since we may get called from GetPartialBases().
2286 (TypeContainer.DefineType): If GetClassBases() didn't return a
2287 parent, use the default one.
2289 2004-07-30 Duncan Mak <duncan@ximian.com>
2291 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
2293 2004-07-30 Martin Baulig <martin@ximian.com>
2295 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2297 * class.cs (SourceMethod): New public class, derive from the
2298 symbol writer's ISourceMethod.
2299 (Method): Use the new symbol writer API.
2301 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2302 as argument and use the new symbol writer.
2305 (SourceFile): Implement the symbol writer's ISourceFile.
2306 (Location.SymbolDocument): Removed.
2307 (Location.SourceFile): New public property.
2309 * symbolwriter.cs: Use the new symbol writer API.
2311 2004-07-30 Raja R Harinath <rharinath@novell.com>
2313 * Makefile (install-local): Remove. Functionality moved to
2316 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2318 * Makefile: Install mcs.exe.config file together with mcs.exe.
2319 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2320 correct runtime version.
2322 2004-07-25 Martin Baulig <martin@ximian.com>
2325 (TypeContainer.RegisterOrder): Removed, this was unused.
2326 (TypeContainer, interface_order): Removed.
2327 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2328 TypeContainer as argument since we can also be called with a
2329 `PartialContainer' for a partial class/struct/interface.
2330 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2331 of checking whether we're an `Interface' - we could be a
2333 (PartialContainer.Register): Override; call
2334 AddClass()/AddStruct()/AddInterface() on our parent.
2336 * cs-parser.jay (interface_member_declaration): Add things to the
2337 `current_container', not the `current_class'.
2339 * rootcontext.cs (RegisterOrder): The overloaded version which
2340 takes an `Interface' was unused, removed.
2342 * typemanager.cs (TypeManager.LookupInterface): Return a
2343 `TypeContainer', not an `Interface'.
2344 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2345 contain a `PartialContainer' for an interface, so check it's
2346 `Kind' to figure out what it is.
2348 2004-07-25 Martin Baulig <martin@ximian.com>
2350 * class.cs (Class.DefaultTypeAttributes): New public constant.
2351 (Struct.DefaultTypeAttributes): Likewise.
2352 (Interface.DefaultTypeAttributes): Likewise.
2353 (PartialContainer.TypeAttr): Override this and add the
2354 DefaultTypeAttributes.
2356 2004-07-25 Martin Baulig <martin@ximian.com>
2358 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2359 we can just use the `Parent' field instead.
2361 2004-07-25 Martin Baulig <martin@ximian.com>
2363 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2365 2004-07-25 Martin Baulig <martin@ximian.com>
2367 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2368 our parts before defining any methods.
2369 (TypeContainer.VerifyImplements): Make this virtual.
2370 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2371 on our PartialContainer.
2373 2004-07-25 Martin Baulig <martin@ximian.com>
2375 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2377 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2378 argument, we can just use the `Parent' field instead.
2381 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2382 (MemberBase.DoDefine): Likewise.
2384 2004-07-24 Martin Baulig <martin@ximian.com>
2386 * decl.cs (MemberCore.Parent): New public field.
2387 (DeclSpace.Parent): Moved to MemberCore.
2389 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2390 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2392 (FieldBase, Field, Operator): Likewise.
2393 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2394 (EventField, Event): Likewise.
2396 2004-07-23 Martin Baulig <martin@ximian.com>
2398 * class.cs (PartialContainer): New public class.
2399 (ClassPart): New public class.
2400 (TypeContainer): Added support for partial classes.
2401 (TypeContainer.GetClassBases): Splitted some of the functionality
2402 out into GetNormalBases() and GetPartialBases().
2404 * cs-tokenizer.cs (Token.PARTIAL): New token.
2405 (Tokenizer.consume_identifier): Added some hacks to recognize
2406 `partial', but only if it's immediately followed by `class',
2407 `struct' or `interface'.
2409 * cs-parser.jay: Added support for partial clases.
2411 2004-07-23 Martin Baulig <martin@ximian.com>
2413 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2414 a `DeclSpace' and also made it readonly.
2415 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2416 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2417 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2419 * cs-parser.jay: Pass the `current_class', not the
2420 `current_container' (at the moment, this is still the same thing)
2421 to a new Method, Property, Event, Indexer or Constructor.
2423 2004-07-23 Martin Baulig <martin@ximian.com>
2425 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2426 and removed the `current_interface' one.
2427 (struct_declaration, class_declaration, interface_declaration):
2428 Set `current_class' to the newly created class/struct/interface;
2429 set their `Bases' and call Register() before parsing their body.
2431 2004-07-23 Martin Baulig <martin@ximian.com>
2433 * class.cs (Kind): New public enum.
2434 (TypeContainer): Made this class abstract.
2435 (TypeContainer.Kind): New public readonly field.
2436 (TypeContainer.CheckDef): New public method; moved here from
2438 (TypeContainer.Register): New public abstract method.
2439 (TypeContainer.GetPendingImplementations): New public abstract
2441 (TypeContainer.GetClassBases): Removed the `is_class' and
2442 `is_iface' parameters.
2443 (TypeContainer.DefineNestedTypes): Formerly known as
2445 (ClassOrStruct): Made this class abstract.
2447 * tree.cs (RootTypes): New public type.
2449 2004-07-20 Martin Baulig <martin@ximian.com>
2451 * tree.cs (Tree.RecordNamespace): Removed.
2452 (Tree.Namespaces): Removed.
2454 * rootcontext.cs (RootContext.IsNamespace): Removed.
2456 * cs-parser.jay (namespace_declaration): Just create a new
2457 NamespaceEntry here.
2459 2004-07-20 Martin Baulig <martin@ximian.com>
2461 * statement.cs (ExceptionStatement): New abstract class. This is
2462 now used as a base class for everyone who's using `finally'.
2463 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2464 our local variables before using them.
2466 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2467 virtual method. This is used by Yield.Resolve() to "steal" an
2468 outer block's `finally' clauses.
2469 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2472 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2473 version which takes an ExceptionStatement. This version must be
2474 used to create exception branchings.
2477 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2478 (Iterator.EmitMoveNext): Added exception support; protect the
2479 block with a `fault' clause, properly handle 'finally' clauses.
2480 (Iterator.EmitDispose): Run all the `finally' clauses here.
2482 2004-07-20 Martin Baulig <martin@ximian.com>
2484 * iterator.cs: This is the first of a set of changes in the
2485 iterator code. Match the spec more closely: if we're an
2486 IEnumerable, then GetEnumerator() must be called. The first time
2487 GetEnumerator() is called, it returns the current instance; all
2488 subsequent invocations (if any) must create a copy.
2490 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2492 * expression.cs: Resolve the constant expression before returning
2495 2004-07-19 Martin Baulig <martin@ximian.com>
2497 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2498 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2499 the return type of the new EmitContext.
2501 2004-07-18 Martin Baulig <martin@ximian.com>
2503 * class.cs (Property.Define): Fix iterators.
2505 * iterators.cs (Iterator.Define): Moved the
2506 `container.AddInterator (this)' call here from the .ctor; only do
2507 it if we resolved successfully.
2509 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2511 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2512 `true' for preprocessing directives that we parse. The return
2513 value indicates whether we should return to regular tokenizing or
2514 not, not whether it was parsed successfully.
2516 In the past if we were in: #if false ... #line #endif, we would
2517 resume parsing after `#line'. See bug 61604.
2519 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2520 building: IsEnumType should return true only for enums, not for
2521 enums or System.Enum itself. This fixes #61593.
2523 Likely what happened is that corlib was wrong: mcs depended on
2524 this bug in some places. The bug got fixed, we had to add the
2525 hack, which caused bug 61593.
2527 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2528 that was a workaround for the older conditions.
2530 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2532 * assign.cs: IAssignMethod has a new interface, as documented
2533 inline. All assignment code now uses this new api.
2535 * ecore.cs, expression.cs: All classes which implement
2536 IAssignMethod now use the new interface.
2538 * expression.cs (Invocation): add a hack to EmitCall so that
2539 IndexerAccess can be the target of a compound assignment without
2540 evaluating its arguments twice.
2542 * statement.cs: Handle changes in Invocation api.
2544 2004-07-16 Martin Baulig <martin@ximian.com>
2546 * iterators.cs: Rewrote this. We're now using one single Proxy
2547 class for both the IEnumerable and the IEnumerator interface and
2548 `Iterator' derives from Class so we can use the high-level API.
2550 * class.cs (TypeContainer.AddIterator): New method.
2551 (TypeContainer.DoDefineType): New protected virtual method, which
2552 is called from DefineType().
2553 (TypeContainer.DoDefineMembers): Call DefineType() and
2554 DefineMembers() on all our iterators.
2555 (TypeContainer.Emit): Call Emit() on all our iterators.
2556 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2558 * codegen.cs (EmitContext.CurrentIterator): New public field.
2560 2004-07-15 Martin Baulig <martin@ximian.com>
2563 (TypeManager.not_supported_exception_type): New type.
2565 2004-07-14 Martin Baulig <martin@ximian.com>
2567 * iterators.cs: Use real error numbers.
2569 2004-07-14 Martin Baulig <martin@ximian.com>
2571 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2572 requires this to be a System.Collection.IEnumerable and not a
2573 class implementing that interface.
2574 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2576 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2578 * class.cs: Fixed previous fix, it broke some error tests.
2580 2004-07-12 Martin Baulig <martin@ximian.com>
2582 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2585 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2587 * assign.cs (LocalTemporary): Add new argument: is_address,If
2588 `is_address' is true, then the value that we store is the address
2589 to the real value, and not the value itself.
2591 * ecore.cs (PropertyExpr): use the new local temporary
2592 stuff to allow us to handle X.Y += z (where X is a struct)
2594 2004-07-08 Martin Baulig <martin@ximian.com>
2596 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2597 not always return, just like we're doing in Using.Resolve().
2599 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2601 * cs-parser.jay (fixed_statement): flag this as Pinned.
2603 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2605 * typemanager.cs (TypeManager): Removed MakePinned method, this
2606 mechanism is replaced with the .NET 2.x compatible mechanism of
2607 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2609 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2610 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2611 `IsFixed' property which has a different meaning.
2613 2004-07-02 Raja R Harinath <rharinath@novell.com>
2615 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2616 visible from inside a nested class, not just the names of the
2617 immediately enclosing class.
2620 2004-06-24 Raja R Harinath <rharinath@novell.com>
2622 * expression.cs (BetterConversion): Remove buggy special-case
2623 handling of "implicit constant expression conversions". At this
2624 point, we already know that the conversion is possible -- we're
2625 only checking to see which is better.
2627 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2629 * cs-parser.jay: Added error CS0210 test.
2631 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2633 * cs-parser.jay: Added error CS0134 test.
2635 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2638 * cs-parser.jay: Added error CS0145 test.
2640 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2642 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2644 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2646 * expression.cs (StackAlloc.Resolve): The argument may not
2647 be a constant; deal with this case.
2649 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2651 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2652 GetIndexerAttributeValue.
2653 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2655 * class.cs (Indexer.Define): Added error tests for CS0415,
2658 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2660 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2663 2004-06-23 Martin Baulig <martin@ximian.com>
2665 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2666 neither return nor throw, reset the barrier as well. Fixes #60457.
2668 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2670 * class.cs : EventAttributes is now set to None by default.
2671 This fixes bug #60459.
2673 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2676 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2677 Don't throw exception but return null (it's sufficient now).
2679 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2681 * typemanager.cs (GetArgumentTypes): Faster implementation.
2683 2004-06-18 Martin Baulig <martin@ximian.com>
2685 * attribute.cs (Attribute.Resolve): Check whether we're an
2686 EmptyCast which a Constant child. Fixes #60333.
2688 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2690 * statement.cs (EmitCollectionForeach): Account for the fact that
2691 not all valuetypes are in areas which we can take the address of.
2692 For these variables, we store to a temporary variable. Also, make
2693 sure that we dont emit a `callvirt' on a valuetype method.
2695 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2697 * expression.cs (StackAlloc.DoReSolve): Added test for
2698 negative parameter (CS0247).
2700 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2703 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2705 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2708 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2711 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2713 Fix bug #58254 & cs1555.cs, cs1556.cs
2714 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2716 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2718 * cs-parser.jay: Added error CS1669 test for indexers.
2720 2004-06-11 Martin Baulig <martin@ximian.com>
2722 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2723 call this twice: for params and varargs methods.
2725 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2728 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2730 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2732 * attribute.cs (Attribute.GetValidTargets): Made public.
2735 (AbstractPropertyEventMethod): New class for better code sharing.
2736 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2738 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2740 2004-06-11 Raja R Harinath <rharinath@novell.com>
2743 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
2744 that the call to Resolve is part of a MemberAccess.
2745 (Expression.Resolve): Use it for SimpleName resolution.
2746 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
2747 Add 'intermediate' boolean argument.
2748 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
2749 error message when the SimpleName can be resolved ambiguously
2750 between an expression and a type.
2751 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
2753 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
2754 call on the left-side.
2756 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2759 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
2761 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2763 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
2765 2004-06-11 Martin Baulig <martin@ximian.com>
2767 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
2768 varargs methods if applicable.
2770 2004-06-11 Martin Baulig <martin@ximian.com>
2772 * expression.cs (Invocation.EmitCall): Don't use
2773 `method.CallingConvention == CallingConventions.VarArgs' since the
2774 method could also have `CallingConventions.HasThis'.
2776 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2778 * class.cs (Event.GetSignatureForError): Implemented.
2779 Fixed crash in error test cs3010.cs
2781 2004-06-10 Miguel de Icaza <miguel@ximian.com>
2783 * cs-tokenizer.cs: Change the way we track __arglist to be
2784 consistent with the other keywords.
2786 2004-06-09 Miguel de Icaza <miguel@ximian.com>
2788 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
2791 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
2793 * codegen.cs: Check that all referenced assemblies have a strongname
2794 before strongnaming the compiled assembly. If not report error CS1577.
2795 Fix bug #56563. Patch by Jackson Harper.
2796 * typemanager.cs: Added a method to return all referenced assemblies.
2797 Fix bug #56563. Patch by Jackson Harper.
2799 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2802 (Method.ApplyAttributeBuilder): Moved and added conditional
2803 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
2806 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
2808 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2811 * class.cs: (EventField.attribute_targets): Changed default target.
2813 2004-06-08 Martin Baulig <martin@ximian.com>
2815 * expression.cs (Invocation.EmitCall): Enable varargs methods.
2817 2004-06-08 Martin Baulig <martin@ximian.com>
2819 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
2821 2004-06-07 Martin Baulig <martin@ximian.com>
2823 Added support for varargs methods.
2825 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
2828 * cs-parser.jay: Added support for `__arglist'.
2830 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
2832 * expression.cs (Argument.AType): Added `ArgList'.
2833 (Invocation): Added support for varargs methods.
2834 (ArglistAccess): New public class.
2835 (Arglist): New public class.
2837 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
2839 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
2840 a method's top-level block if the method has varargs.
2842 * support.cs (ReflectionParameters, InternalParameters): Added
2843 support for varargs methods.
2845 2004-06-07 Miguel de Icaza <miguel@ximian.com>
2847 * class.cs: Provide location in indexer error report.
2849 * driver.cs: Use standard names.
2851 * namespace.cs: Catch the use of using after a namespace has been
2852 declared also on using aliases.
2854 2004-06-03 Raja R Harinath <rharinath@novell.com>
2857 * typemanager.cs (closure_private_ok, closure_invocation_type)
2858 (closure_qualifier_type, closure_invocation_assembly)
2859 (FilterWithClosure): Move to ...
2860 (Closure): New internal nested class.
2861 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
2862 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
2863 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
2864 (MemberLookup, MemberLookupFailed): Use it.
2865 * expression.cs (New.DoResolve): Treat the lookup for the
2866 constructor as being qualified by the 'new'ed type.
2867 (Indexers.GetIndexersForTypeOrInterface): Update.
2869 2004-06-03 Marek Safar <marek.safar@seznam.cz>
2872 (GetConditionalAttributeValue): New method. Returns
2873 condition of ConditionalAttribute.
2874 (SearchMulti): New method. Returns all attributes of type 't'.
2875 Use it when attribute is AllowMultiple = true.
2876 (IsConditionalMethodExcluded): New method.
2879 (Method.IsExcluded): Implemented. Returns true if method has conditional
2880 attribute and the conditions is not defined (method is excluded).
2881 (IMethodData): Extended interface for ConditionalAttribute support.
2882 (PropertyMethod.IsExcluded): Implemented.
2885 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
2888 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
2891 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
2893 * expression.cs (ArrayCreationExpression): Make this just an
2894 `expression'. It can't be a statement, so the code here was
2897 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2900 * typemanager.cs (GetFullNameSignature): New method for
2903 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2906 * class.cs (MemberBase.GetSignatureForError): New virtual method.
2907 Use this method when MethodBuilder is null.
2908 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
2909 Added test for error CS0626 (MONO reports error for this situation).
2910 (IMethodData.GetSignatureForError): Extended interface.
2912 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2915 (AttributeTester.GetObsoleteAttribute): Returns instance of
2916 ObsoleteAttribute when type is obsolete.
2919 (TypeContainer.VerifyObsoleteAttribute): Override.
2920 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2921 (MethodCode.VerifyObsoleteAttribute): Override.
2922 (MemberBase.VerifyObsoleteAttribute): Override.
2925 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2926 and report proper error.
2929 Delegate.VerifyObsoleteAttribute): Override.
2932 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2933 and report proper error.
2934 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2937 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2941 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2942 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2943 Added test for ObsoleteAttribute.
2946 (Catch): Derived from Statement.
2948 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2950 Fixed bug #59071 & cs0160.cs
2952 * statement.cs (Try.Resolve): Check here whether order of catch
2953 clauses matches their dependencies.
2955 2004-05-31 Miguel de Icaza <miguel@ximian.com>
2957 * Reverted patch to namespace.cs (Use lookuptypedirect). This
2958 caused a regression: #59343. Referencing nested classes from an
2959 assembly stopped working.
2961 2004-05-31 Martin Baulig <martin@ximian.com>
2963 MCS is now frozen for beta 2.
2965 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2967 * convert.cs: add a trivial cache for overload operator resolution.
2969 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2971 * decl.cs: If possible, use lookuptypedirect here. We can only do
2972 this if there is no `.' after the namespace. Avoids using
2973 LookupType, which does lots of slow processing.
2974 (FindNestedType) New method, does what it says :-).
2975 * namespace.cs: use LookupTypeDirect.
2976 * rootcontext.cs: use membercache, if possible.
2977 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2979 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2982 According to the spec,
2984 In a member access of the form E.I, if E is a single identifier,
2985 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2986 field, property, localvariable, or parameter with the same type as
2987 the meaning of E as a type-name (§3.8), then both possible
2988 meanings of E are permitted.
2990 We did not check that E as a simple-name had the same type as E as
2993 This trivial check gives us 5-7% on bootstrap time.
2995 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2997 * expression.cs (Invocation.OverloadResolve): Avoid the
2998 use of hashtables and boxing here by allocating on demand.
3000 2004-05-30 Martin Baulig <martin@ximian.com>
3002 * rootcontext.cs (RootContext.LookupType): Don't cache things if
3003 we're doing a silent lookup. Don't try to lookup nested types in
3004 TypeManager.object_type (thanks to Ben Maurer).
3006 2004-05-30 Martin Baulig <martin@ximian.com>
3008 Committing a patch from Ben Maurer.
3010 * rootcontext.cs (RootContext.LookupType): Cache negative results.
3012 2004-05-29 Martin Baulig <martin@ximian.com>
3014 * class.cs (IMethodData.ShouldIgnore): New method.
3016 * typemanager.cs (TypeManager.MethodFlags): Don't take a
3017 `Location' argument, we don't need it anywhere. Use
3018 `IMethodData.ShouldIgnore ()' instead of
3019 `MethodData.GetMethodFlags ()'.
3020 (TypeManager.AddMethod): Removed.
3021 (TypeManager.AddMethod2): Renamed to AddMethod.
3023 2004-05-29 Martin Baulig <martin@ximian.com>
3025 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
3027 * convert.cs (Convert.ImplicitReferenceConversion): If we're
3028 converting from a class type S to an interface type and we already
3029 have an object on the stack, don't box it again. Fixes #52578.
3031 2004-05-29 Martin Baulig <martin@ximian.com>
3033 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
3034 Added support for `params' parameters. Fixes #59267.
3036 2004-05-29 Martin Baulig <martin@ximian.com>
3038 * literal.cs (NullPointer): Provide a private .ctor which sets
3039 `type' to TypeManager.object_type. Fixes #59048.
3041 2004-05-29 Martin Baulig <martin@ximian.com>
3043 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
3044 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
3046 * ecore.cs (EventExpr.instance_expr): Make the field private.
3048 2004-05-26 Marek Safar <marek.safar@seznam.cz>
3050 Fixed bug #50080 & cs0214-2.cs
3051 * expression.cs (Cast.DoResolve): Check unsafe context here.
3053 * statement.cs (Resolve.DoResolve): Likewise.
3055 2004-05-26 Martin Baulig <martin@ximian.com>
3057 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
3059 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
3060 (RootContext.LookupType): Pass down the `silent' flag.
3062 2004-05-25 Martin Baulig <martin@ximian.com>
3065 (MethodGroupExpr.IdenticalTypeName): New public property.
3066 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
3067 expression actually refers to a type.
3069 2004-05-25 Martin Baulig <martin@ximian.com>
3071 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
3072 for #56176 and made it actually work.
3074 2004-05-25 Martin Baulig <martin@ximian.com>
3076 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
3077 (FieldExpr, PropertyExpr): Override and implement
3078 CacheTemporaries. Fixes #52279.
3080 2004-05-25 Miguel de Icaza <miguel@ximian.com>
3082 * location.cs: In the new compiler listing a file twice is a
3083 warning, not an error.
3085 2004-05-24 Martin Baulig <martin@ximian.com>
3087 * enum.cs (Enum.DefineType): For the `BaseType' to be a
3088 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
3090 2004-05-24 Martin Baulig <martin@ximian.com>
3092 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
3093 walking the `using' list. Fixes #53921.
3095 2004-05-24 Martin Baulig <martin@ximian.com>
3097 * const.cs (Const.LookupConstantValue): Added support for
3098 EmptyCast's; fixes #55251.
3100 2004-05-24 Martin Baulig <martin@ximian.com>
3102 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
3103 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
3104 which does the CS0135 check. The reason is that we first need to
3105 check whether the variable actually exists.
3107 2004-05-24 Martin Baulig <martin@ximian.com>
3109 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
3110 than RootContext.LookupType() to find the explicit interface
3113 2004-05-24 Raja R Harinath <rharinath@novell.com>
3115 * Makefile: Simplify. Use executable.make.
3116 * mcs.exe.sources: New file. List of sources of mcs.exe.
3118 2004-05-24 Anders Carlsson <andersca@gnome.org>
3122 Use the invariant culture when doing String.Compare for CLS case
3125 2004-05-23 Martin Baulig <martin@ximian.com>
3127 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
3128 don't have any dots. Fixes #52622, added cs0246-8.cs.
3130 * namespace.cs (NamespaceEntry.Lookup): Likewise.
3132 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3134 * class.cs (MemberBase.Define): Reuse MemberType member for
3135 resolved type. Other methods can use it too.
3137 2004-05-23 Martin Baulig <martin@ximian.com>
3139 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
3140 the variable also exists in the current block (otherwise, we need
3141 to report a CS0103). Fixes #58670.
3143 2004-05-23 Martin Baulig <martin@ximian.com>
3145 * flowanalysis.cs (Reachability.Reachable): Compute this
3146 on-the-fly rather than storing it as a field.
3148 2004-05-23 Martin Baulig <martin@ximian.com>
3150 * flowanalysis.cs (Reachability.And): Manually compute the
3151 resulting `barrier' from the reachability.
3153 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3156 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
3157 instance of ObsoleteAttribute when symbol is obsolete.
3160 (IMethodData): Extended interface for ObsoleteAttribute support.
3162 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3164 * attribute.cs: Fix bug #55970
3166 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3170 (GetObsoleteAttribute): New method. Creates the instance of
3172 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
3173 ObsoleteAttribute when member is obsolete.
3174 (AttributeTester.Report_ObsoleteMessage): Common method for
3175 Obsolete error/warning reporting.
3178 (TypeContainer.base_classs_type): New member for storing parent type.
3181 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
3182 for this MemberCore.
3184 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3186 * attribute.cs, const.cs: Fix bug #58590
3188 2004-05-21 Martin Baulig <martin@ximian.com>
3190 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
3191 out parameters if the end of the method is unreachable. Fixes
3194 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3196 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
3197 Hari was right, why extra method.
3199 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3201 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
3203 2004-05-20 Martin Baulig <martin@ximian.com>
3205 Merged this back from gmcs to keep the differences to a minumum.
3207 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
3208 instead of a Declspace.
3209 (Attribute.ResolveType): Likewise.
3210 (Attributes.Search): Likewise.
3211 (Attributes.Contains): Likewise.
3212 (Attributes.GetClsCompliantAttribute): Likewise.
3214 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
3216 (MethodData.ApplyAttributes): Take an EmitContext instead of a
3219 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3221 Fix bug #58688 (MCS does not report error when the same attribute
3224 * attribute.cs (Attribute.Emit): Distinction between null and default.
3226 2004-05-19 Raja R Harinath <rharinath@novell.com>
3228 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3229 of a top-level attribute without an attribute target.
3230 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3232 (Attribute.Conditional_GetConditionName),
3233 (Attribute.Obsolete_GetObsoleteMessage): Update.
3234 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3235 part of ScanForIndexerName.
3236 (Attribute.CanIgnoreInvalidAttribute): New function.
3237 (Attribute.ScanForIndexerName): Move to ...
3238 (Attributes.ScanForIndexerName): ... here.
3239 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3240 (Attributes.Search): New internal variant that can choose not to
3241 complain if types aren't resolved. The original signature now
3243 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3244 complaints suppressed.
3245 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3246 only if it not useful.
3247 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3248 top-level for attributes that are shared between the assembly
3249 and a top-level class.
3250 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3251 * class.cs: Update to reflect changes.
3252 (DefineIndexers): Fuse loops.
3253 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3254 a couple more variants of attribute names.
3256 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3258 Fix bug #52585 (Implemented explicit attribute declaration)
3261 (Attributable.ValidAttributeTargets): New abstract method. It gets
3262 list of valid attribute targets for explicit target declaration.
3263 (Attribute.Target): It holds target itself.
3264 (AttributeSection): Removed.
3265 (Attribute.CheckTargets): New method. It checks whether attribute
3266 target is valid for the current element.
3269 (EventProperty): New class. For events that are declared like
3270 property (with add and remove accessors).
3271 (EventField): New class. For events that are declared like field.
3274 * cs-parser.jay: Implemented explicit attribute target declaration.
3276 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3277 Override ValidAttributeTargets.
3280 (ReturnParameter): Class for applying custom attributes on
3282 (ParameterAtribute): New class. Class for applying custom
3283 attributes on the parameter type.
3285 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3287 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3290 (Method): Allow UNSAFE here.
3292 * modifiers.cs: Support unsafe reporting.
3294 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3296 * decl.cs: Fix bug #58478.
3298 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3300 * statement.cs: When checking for unreachable code on an EmptyStatement,
3301 set the location. Fixes bug #58488.
3303 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3305 * driver.cs: Add -pkg handling.
3307 From Gonzalo: UseShelLExecute=false
3309 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3312 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3314 (Attribute.IsClsCompliaceRequired): Moved to base for better
3316 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3317 when attribute is AttributeUsageAttribute.
3318 (Attribute.GetValidTargets): Simplified.
3319 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3320 attribute for this type.
3321 (Attribute.ApplyAttributes): Method renamed to Emit and make
3323 (GlobalAttributeSection): New class for special handling of global
3324 attributes (assembly, module).
3325 (AttributeSection.Emit): New method.
3327 * class.cs: Implemented Attributable abstract methods.
3328 (MethodCore.LabelParameters): Moved to Parameter class.
3329 (Accessor): Is back simple class.
3330 (PropertyMethod): Implemented Attributable abstract class.
3331 (DelegateMethod): Implemented Attributable abstract class.
3332 (Event): New constructor for disctintion between normal Event
3333 and Event with accessors.
3335 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3337 * codegen.cs, const.cs, decl.cs, delegate.cs:
3338 (CommonAssemblyModulClass): Implemented Attributable abstract class
3341 * enum.cs: Implement IAttributeSupport interface.
3342 (EnumMember): New class for emum members. Implemented Attributable
3346 (ParameterBase): Is abstract.
3347 (ReturnParameter): New class for easier [return:] attribute handling.
3349 * typemanager.cs: Removed builder_to_attr.
3351 2004-05-11 Raja R Harinath <rharinath@novell.com>
3354 * attribute.cs (Attribute.GetPositionalValue): New function.
3355 * class.cs (TypeContainer.VerifyMembers): New function.
3356 (TypeContainer.Emit): Use it.
3357 (ClassOrStruct): New base class for Class and Struct.
3358 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3359 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3361 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3362 then each non-static field should have a FieldOffset attribute.
3363 Otherwise, none of the fields should have a FieldOffset attribute.
3364 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3365 and FieldOffset attributes.
3366 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3367 (TypeManager.field_offset_attribute_type): New core types.
3368 (TypeManager.InitCoreTypes): Initialize them.
3370 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3372 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3373 Return correct type.
3376 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3378 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3379 be implicitly converted to ulong.
3381 * expression.cs: The logic for allowing operator &, | and ^ worked
3382 was wrong, it worked before because we did not report an error in
3383 an else branch. Fixes 57895.
3385 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3386 allow volatile fields to be reference types.
3388 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3390 * driver.cs: Add support for /debug-
3392 2004-05-07 Raja R Harinath <rharinath@novell.com>
3394 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3395 Add a 'complain' parameter to silence errors.
3396 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3397 silently overlooked type-resolutions.
3398 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3400 (Attributes.Search): New function.
3401 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3402 (Attributes.GetAttributeFullName): Remove hack.
3403 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3404 Update to reflect changes.
3405 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3406 Use Attributes.Search instead of nested loops.
3408 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3411 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3412 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3413 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3415 * report.cs: (Report.Warning): Renamed to Warning_T because of
3416 parameter collision.
3418 2004-05-05 Raja R Harinath <rharinath@novell.com>
3420 * expression.cs (MemberAccess.ResolveMemberAccess):
3421 Exit with non-zero status after Report.Error.
3422 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3424 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3426 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3428 * support.cs: Don't hang when the file is empty.
3430 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3432 * support.cs: In SeekableStreamReader, compute the preamble size of the
3433 underlying stream. Position changes should take into account that initial
3436 2004-05-03 Todd Berman <tberman@sevenl.net>
3438 * driver.cs: remove unused GetSysVersion function.
3440 2004-05-03 Todd Berman <tberman@sevenl.net>
3442 * driver.cs: Remove the hack from saturday, as well as the hack
3443 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3444 link_paths to get that bit proper.
3446 2004-05-01 Todd Berman <tberman@sevenl.net>
3448 * driver.cs: Try a LoadFrom before a Load, this checks the current
3449 path. This is currently a bug in mono that is be fixed, however, this
3450 provides a workaround for now. This will be removed when the bug
3453 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3455 * CryptoConvert.cs: Updated to latest version. Fix issue with
3456 incomplete key pairs (#57941).
3458 2004-05-01 Todd Berman <tberman@sevenl.net>
3460 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3463 2004-04-30 Jackson Harper <jackson@ximian.com>
3465 * codegen.cs: Open keys readonly.
3467 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3469 * typemanager.cs: don't report cyclic struct layout when a struct
3470 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3471 which has 2 Pango.Rectangle fields.
3473 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3475 * expression.cs: Handle IntPtr comparisons with IL code
3476 rather than a method call.
3478 2004-04-29 Martin Baulig <martin@ximian.com>
3480 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3481 the list of PropertyInfo's in class hierarchy and find the
3482 accessor. Fixes #56013.
3484 2004-04-29 Martin Baulig <martin@ximian.com>
3486 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3488 2004-04-29 Martin Baulig <martin@ximian.com>
3490 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3492 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3494 2004-04-29 Martin Baulig <martin@ximian.com>
3496 * class.cs (ConstructorInitializer.Resolve): Check whether the
3497 parent .ctor is accessible. Fixes #52146.
3499 2004-04-29 Martin Baulig <martin@ximian.com>
3501 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3503 * statement.cs (Using.EmitLocalVariableDecls): Use
3504 TypeManager.idisposable_type, not typeof (IDisposable).
3505 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3507 2004-04-29 Martin Baulig <martin@ximian.com>
3509 * class.cs (Event.Define): Don't emit the field and don't set
3510 RTSpecialName and SpecialName for events on interfaces. Fixes
3513 2004-04-29 Raja R Harinath <rharinath@novell.com>
3515 Refactor Attribute.ApplyAttributes.
3516 * attribute.cs (Attributable): New base class for objects that can
3517 have Attributes applied on them.
3518 (Attribute): Make AttributeUsage fields public.
3519 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3520 (Attribute.IsInternalCall): New property.
3521 (Attribute.UsageAttr): Convert to a public read-only property.
3522 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3523 (Attribute.ResolveType, Attribute.Resolve)
3524 (Attribute.ScanForIndexerName): Update to reflect changes.
3525 (Attribute.CheckAttributeTarget): Re-format.
3526 (Attribute.ApplyAttributes): Refactor, to various
3527 Attributable.ApplyAttributeBuilder methods.
3528 * decl.cs (MemberCore): Make Attributable.
3529 * class.cs (Accessor): Make Attributable.
3530 (MethodData.ApplyAttributes): Use proper attribute types, not
3532 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3533 (TypeContainer.ApplyAttributeBuilder)
3534 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3535 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3536 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3537 (Operator.ApplyAttributeBuilder): New factored-out methods.
3538 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3539 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3540 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3541 * parameter.cs (ParameterBase): New Attributable base class
3542 that can also represent Return types.
3543 (Parameter): Update to the changes.
3545 2004-04-29 Jackson Harper <jackson@ximian.com>
3547 * driver.cs: Prefer the corlib system version when looking for
3548 assemblies in the GAC. This is still a hack, but its a better hack
3551 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3553 * decl.cs, enum.cs: Improved error 3005 reporting.
3555 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3556 (related_symbols): New private member for list of symbols
3557 related to reported error/warning.
3559 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3561 2004-04-29 Martin Baulig <martin@ximian.com>
3563 * ecore.cs (Expression.Constantify): If we're an enum and
3564 TypeManager.TypeToCoreType() doesn't give us another type, use
3565 t.UnderlyingSystemType. Fixes #56178.
3567 2004-04-29 Martin Baulig <martin@ximian.com>
3569 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3570 interfaces and for each interface, only add members directly
3571 declared in that interface. Fixes #53255.
3573 2004-04-28 Martin Baulig <martin@ximian.com>
3575 * expression.cs (ConditionalLogicalOperator): Use a temporary
3576 variable for `left' to avoid that we evaluate it more than once;
3579 2004-04-28 Martin Baulig <martin@ximian.com>
3581 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3584 2004-04-28 Martin Baulig <martin@ximian.com>
3586 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3589 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3590 whether the type is not void (CS1547).
3592 2004-04-28 Martin Baulig <martin@ximian.com>
3594 * expression.cs (Unary.DoResolveLValue): Override this and report
3595 CS0131 for anything but Operator.Indirection.
3597 2004-04-28 Martin Baulig <martin@ximian.com>
3599 Committing a patch from Ben Maurer; see bug #50820.
3601 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3604 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3607 2004-04-28 Martin Baulig <martin@ximian.com>
3609 Committing a patch from Ben Maurer; see bug #50820.
3611 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3614 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3617 2004-04-28 Martin Baulig <martin@ximian.com>
3619 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3620 (Block.AddLabel): Call DoLookupLabel() to only search in the
3623 2004-04-28 Martin Baulig <martin@ximian.com>
3625 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3626 comparing StringConstants and NullLiterals in Equality and Inequality.
3628 2004-04-28 Jackson Harper <jackson@ximian.com>
3630 * driver.cs: Attempt to load referenced assemblies from the
3631 GAC. This is the quick and dirty version of this method that
3632 doesnt take into account versions and just takes the first
3633 canidate found. Will be good enough for now as we will not have more
3634 then one version installed into the GAC until I update this method.
3636 2004-04-28 Martin Baulig <martin@ximian.com>
3638 * typemanager.cs (TypeManager.CheckStructCycles): New public
3639 static method to check for cycles in the struct layout.
3641 * rootcontext.cs (RootContext.PopulateTypes): Call
3642 TypeManager.CheckStructCycles() for each TypeContainer.
3643 [Note: We only need to visit each type once.]
3645 2004-04-28 Martin Baulig <martin@ximian.com>
3647 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3649 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3650 success and added `out object value'. Use a `bool resolved' field
3651 to check whether we've already been called rather than
3652 `ConstantValue != null' since this breaks for NullLiterals.
3654 2004-04-28 Raja R Harinath <rharinath@novell.com>
3656 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3657 setting of this flag, since the 'set' method may be non-public.
3659 2004-04-28 Raja R Harinath <rharinath@novell.com>
3661 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3662 check on current_vector.Block.
3664 2004-04-27 Martin Baulig <martin@ximian.com>
3666 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3667 a field initializer. Fixes #56459.
3669 2004-04-27 Martin Baulig <martin@ximian.com>
3671 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3672 we're not attempting to use an indexer. Fixes #52154.
3674 2004-04-27 Martin Baulig <martin@ximian.com>
3676 * statement.cs (Return): Don't create a return label if we don't
3677 need it; reverts my change from January 20th. Thanks to Ben
3680 2004-04-27 Martin Baulig <martin@ximian.com>
3682 According to the spec, `goto' can only leave a nested scope, but
3685 * statement.cs (Block.LookupLabel): Only lookup in the current
3686 block, don't recurse into parent or child blocks.
3687 (Block.AddLabel): Check in parent and child blocks, report
3688 CS0140/CS0158 if we find a duplicate.
3689 (Block): Removed this indexer for label lookups.
3690 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3691 this already does the error reporting for us.
3694 (FlowBranching.UsageVector.Block): New public variable; may be null.
3695 (FlowBranching.CreateSibling): Added `Block' argument.
3696 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3697 label for the target of a `goto' and check whether we're not
3698 leaving a `finally'.
3700 2004-04-27 Martin Baulig <martin@ximian.com>
3702 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3703 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3706 2004-04-27 Martin Baulig <martin@ximian.com>
3708 * statement.cs (Block.AddLabel): Also check for implicit blocks
3709 and added a CS0158 check.
3711 2004-04-27 Martin Baulig <martin@ximian.com>
3713 * flowanalysis.cs (FlowBranchingLoop): New class.
3714 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3715 UsageVector's instead of an ArrayList.
3716 (FlowBranching.Label): Likewise.
3717 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3718 (FlowBranching.AddBreakVector): New method.
3720 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3722 * attribute.cs: Small regression fix: only convert the type if we
3723 the type is different, fixes System.Drawing build.
3725 2004-04-27 Martin Baulig <martin@ximian.com>
3727 * attribute.cs (Attribute.Resolve): If we have a constant value
3728 for a named field or property, implicity convert it to the correct
3731 2004-04-27 Raja R Harinath <rharinath@novell.com>
3733 * statement.cs (Block.Block): Implicit blocks share
3734 'child_variable_names' fields with parent blocks.
3735 (Block.AddChildVariableNames): Remove.
3736 (Block.AddVariable): Mark variable as "used by a child block" in
3737 every surrounding block.
3738 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3739 been used in a child block, complain about violation of "Invariant
3740 meaning in blocks" rule.
3741 * cs-parser.jay (declare_local_variables): Don't use
3742 AddChildVariableNames.
3743 (foreach_statement): Don't create an implicit block: 'foreach'
3746 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3748 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3749 converting from 0L to ulong. Fixes 57522.
3751 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3753 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3754 derived class hides via 'new' keyword field from base class (test-242.cs).
3755 TODO: Handle this in the more general way.
3757 * class.cs (CheckBase): Ditto.
3759 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3761 * decl.cs (caching_flags): New member for storing cached values
3763 (MemberCore.Flags): New enum where bit flags for caching_flags
3765 (MemberCore.cls_compliance): Moved to caching_flags.
3766 (DeclSpace.Created): Moved to caching_flags.
3768 * class.cs: Use caching_flags instead of DeclSpace.Created
3770 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3772 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3773 if we are only a derived class, not a nested class.
3775 * typemanager.cs: Same as above, but do this at the MemberLookup
3776 level (used by field and methods, properties are handled in
3777 PropertyExpr). Allow for the qualified access if we are a nested
3780 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3782 * class.cs: Refactoring.
3783 (IMethodData): New inteface; Holds links to parent members
3784 to avoid member duplication (reduced memory allocation).
3785 (Method): Implemented IMethodData interface.
3786 (PropertyBase): New inner classes for get/set methods.
3787 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3788 (Event): New inner classes for add/remove methods.
3789 (Event.DelegateMethod): Implemented IMethodData interface.
3791 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3792 EmitContext (related to class.cs refactoring).
3794 2004-04-21 Raja R Harinath <rharinath@novell.com>
3796 * delegate.cs (Delegate.VerifyApplicability): If the number of
3797 arguments are the same as the number of parameters, first try to
3798 verify applicability ignoring any 'params' modifier on the last
3802 2004-04-16 Raja R Harinath <rharinath@novell.com>
3804 * class.cs (TypeContainer.AddIndexer): Use
3805 'ExplicitInterfaceName' to determine if interface name was
3806 explicitly specified. 'InterfaceType' is not initialized at this time.
3807 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3808 Indexers array is already in the required order. Initialize
3809 'IndexerName' only if there are normal indexers.
3810 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3811 (TypeContainer.Emit): Emit DefaultMember attribute only if
3812 IndexerName is initialized.
3815 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3817 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3820 2004-04-15 Raja R Harinath <rharinath@novell.com>
3822 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3826 * attribute.cs (Attribute.Resolve): Check for duplicate named
3830 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3832 * iterators.cs (MarkYield): track whether we are in an exception,
3833 and generate code accordingly. Use a temporary value to store the
3834 result for our state.
3836 I had ignored a bit the interaction of try/catch with iterators
3837 since their behavior was not entirely obvious, but now it is
3838 possible to verify that our behavior is the same as MS .NET 2.0
3842 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3844 * iterators.cs: Avoid creating temporaries if there is no work to
3847 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3848 Enumerations, use TypeManager.EnumToUnderlying and call
3851 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3854 (This.Emit): Use EmitContext.EmitThis to emit our
3857 (This.EmitAssign): Ditto.
3859 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3860 codepaths, we will move all the functionality into
3863 (FieldExpr.EmitAssign): Ditto.
3865 This fixes several hidden bugs that I uncovered while doing a code
3866 review of this today.
3868 * codegen.cs (EmitThis): reworked so the semantics are more clear
3869 and also support value types "this" instances.
3871 * iterators.cs: Changed so that for iterators in value types, we
3872 do not pass the value type as a parameter.
3874 Initialization of the enumerator helpers is now done in the caller
3875 instead of passing the parameters to the constructors and having
3876 the constructor set the fields.
3878 The fields have now `assembly' visibility instead of private.
3880 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3882 * expression.cs (Argument.Resolve): Check if fields passed as ref
3883 or out are contained in a MarshalByRefObject.
3885 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3886 another compiler type.
3888 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3890 * class.cs (Indexer.Define): use the new name checking method.
3891 Also, return false on an error.
3892 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3893 (is_identifier_[start/part]_character): make static.
3895 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3897 * expression.cs (Binary.ResolveOperator): Do no append strings
3898 twice: since we can be invoked more than once (array evaluation)
3899 on the same concatenation, take care of this here. Based on a fix
3900 from Ben (bug #56454)
3902 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3904 * codegen.cs: Fix another case where CS1548 must be reported (when
3905 delay-sign isn't specified and no private is available #56564). Fix
3906 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3907 error when MCS is used on the MS runtime and we need to delay-sign
3908 (which seems unsupported by AssemblyBuilder - see #56621).
3910 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3912 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3913 (TypeManager.ComputeNamespaces): Faster implementation for
3916 * compiler.csproj: Updated AssemblyName to mcs.
3918 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3920 * rootcontext.cs: Add new types to the boot resolution.
3922 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3923 MulticastDelegate is not allowed.
3925 * typemanager.cs: Add new types to lookup: System.TypedReference
3928 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3929 check for TypedReference or ArgIterator, they are not allowed.
3931 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3932 makes us properly catch 1510 in some conditions (see bug 56016 for
3935 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3937 * CryptoConvert.cs: update from corlib version
3940 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3942 * class.cs (Indexer.Define): Check indexername declaration
3944 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3946 * attribute.cs (IsClsCompliant): Fixed problem with handling
3947 all three states (compliant, not-compliant, undetected).
3949 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3951 * attribute.cs (Attribute): Location is now public.
3952 (Resolve): Store resolved arguments (pos_values) in attribute class.
3953 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3954 (GetClsCompliantAttributeValue): New method that gets
3955 CLSCompliantAttribute value.
3956 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3957 if exists else null.
3958 (AttributeTester): New class for CLS-Compliant verification routines.
3960 * class.cs (Emit): Add CLS-Compliant verification.
3961 (Method.GetSignatureForError): Implemented.
3962 (Constructor.GetSignatureForError): Implemented
3963 (Constructor.HasCompliantArgs): Returns if constructor has
3964 CLS-Compliant arguments.
3965 (Constructor.Emit): Override.
3966 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3967 is needed to test only parameters.
3968 (FieldBase.GetSignatureForError): Implemented.
3969 (TypeContainer): New member for storing base interfaces.
3970 (TypeContainer.FindMembers): Search in base interfaces too.
3972 * codegen.cs (GetClsComplianceAttribute): New method that gets
3973 assembly or module CLSCompliantAttribute value.
3974 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3976 (ModuleClass.Emit): Add error 3012 test.
3978 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3980 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3981 state for all decl types.
3982 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3983 if CLS-Compliant tests are required.
3984 (IsClsCompliaceRequired): New method. Analyze whether code
3985 must be CLS-Compliant.
3986 (IsExposedFromAssembly): New method. Returns true when MemberCore
3987 is exposed from assembly.
3988 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3989 value or gets cached value.
3990 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3991 is explicitly marked with CLSCompliantAttribute.
3992 (IsIdentifierClsCompliant): New abstract method. This method is
3993 used to testing error 3005.
3994 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3995 for identifier and parameters CLS-Compliant testing.
3996 (VerifyClsCompliance): New method. The main virtual method for
3997 CLS-Compliant verifications.
3998 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3999 null. I don't know why is null (too many public members !).
4000 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
4001 and get value of first CLSCompliantAttribute that found.
4003 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
4004 (VerifyClsCompliance): Override and add extra tests.
4006 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
4007 clscheck- disable CLS-Compliant verification event if assembly is has
4008 CLSCompliantAttribute(true).
4010 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
4011 ApllyAttribute is now called in emit section as in the other cases.
4012 Possible future Emit integration.
4013 (IsIdentifierClsCompliant): New override.
4014 (VerifyClsCompliance): New override.
4015 (GetEnumeratorName): Returns full enum name.
4017 * parameter.cs (GetSignatureForError): Implemented.
4019 * report.cs (WarningData): New struct for Warning message information.
4020 (LocationOfPreviousError): New method.
4021 (Warning): New method. Reports warning based on the warning table.
4022 (Error_T): New method. Reports error based on the error table.
4024 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
4025 verifications are done here.
4027 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
4029 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
4030 CLSCompliantAttribute.
4031 (all_imported_types): New member holds all imported types from other
4033 (LoadAllImportedTypes): New method fills static table with exported types
4034 from all referenced assemblies.
4035 (Modules): New property returns all assembly modules.
4037 2004-03-30 Miguel de Icaza <miguel@ximian.com>
4039 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
4040 throwing a parser error.
4042 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
4043 which removes the hardcoded get_/set_ prefixes for properties, as
4044 IL allows for the properties to be named something else.
4048 * expression.cs: Do not override operand before we know if it is
4051 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4053 * typemanager.cs: support for pinned variables.
4055 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4057 * decl.cs, typemanager.cs: Avoid using an arraylist
4058 as a buffer if there is only one result set.
4060 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
4062 * expression.cs: Make sure you cant call a static method
4063 with an instance expression, bug #56174.
4065 2004-03-29 Miguel de Icaza <miguel@ximian.com>
4067 * class.cs (IsDuplicateImplementation): Improve error reporting to
4068 flag 663 (method only differs in parameter modifier).
4070 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
4071 in preprocessor directives.
4073 * location.cs (LookupFile): Allow for the empty path.
4075 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
4076 better approach for some of that patch, but its failing with the
4077 CharSet enumeration. For now try/catch will do.
4079 * typemanager.cs: Do not crash if a struct does not have fields.
4082 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4084 * expression.cs: cs0213, cant fix a fixed expression.
4087 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4089 * cs-parser.jay: detect invalid embeded statements gracefully.
4092 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
4094 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
4097 the invocation type may not be a subclass of the tye of the item/
4098 The type of the item must be a subclass of the invocation item.
4103 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
4105 * attribute.cs: Added methods to get a string and a bool from an
4106 attribute. Required to information from AssemblyKeyFileAttribute,
4107 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
4108 * codegen.cs: Modified AssemblyName creation to include support for
4109 strongnames. Catch additional exceptions to report them as CS1548.
4110 * compiler.csproj: Updated include CryptoConvert.cs.
4111 * compiler.csproj.user: Removed file - user specific configuration.
4112 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
4113 Mono.Security assembly. The original class is maintained and tested in
4114 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
4115 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
4116 like CSC 8.0 (C# v2) supports.
4117 * Makefile: Added CryptoConvert.cs to mcs sources.
4118 * rootcontext.cs: Added new options for strongnames.
4120 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4122 * driver.cs: For --expect-error, report error code `2'
4123 if the program compiled with no errors, error code `1' if
4124 it compiled with an error other than the one expected.
4126 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4128 * compiler.csproj: Updated for Visual Studio .NET 2003.
4129 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4130 * compiler.sln: Updated for Visual Studio .NET 2003.
4132 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4134 * expression.cs: Fix bug #47234. We basically need to apply the
4135 rule that we prefer the conversion of null to a reference type
4136 when faced with a conversion to 'object' (csc behaviour).
4138 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4140 * statement.cs: Shorter form for foreach, eliminates
4141 a local variable. r=Martin.
4143 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4145 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4146 checks if we can use brtrue/brfalse to test for 0.
4147 * expression.cs: use the above in the test for using brtrue/brfalse.
4150 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4152 * expression.cs: Rewrite string concat stuff. Benefits:
4154 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4155 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4156 rather than a concat chain.
4158 * typemanager.cs: Add lookups for more concat overloads.
4160 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4162 * expression.cs: Emit shorter il code for array init.
4179 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4181 * statement.cs: Before, two switch blocks would be merged if the
4182 total size of the blocks (end_item - begin_item + 1) was less than
4183 two times the combined sizes of the blocks.
4185 Now, it will only merge if after the merge at least half of the
4190 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4192 * class.cs : csc build fix for GetMethods(). See bug #52503.
4194 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4196 * expression.cs: Make sure fp comparisons work with NaN.
4197 This fixes bug #54303. Mig approved this patch a long
4198 time ago, but we were not able to test b/c the runtime
4201 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4203 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4205 2004-03-19 Martin Baulig <martin@ximian.com>
4207 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4208 error here and not in our caller.
4210 2004-03-19 Martin Baulig <martin@ximian.com>
4212 * interface.cs: Completely killed this file.
4213 (Interface): We're now a TypeContainer and live in class.cs.
4215 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4216 argument; we're now also called for interfaces.
4217 (TypeContainer.DefineMembers): Allow this method being called
4219 (TypeContainer.GetMethods): New public method; formerly known as
4220 Interface.GetMethod(). This is used by PendingImplementation.
4221 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4222 it's now private and non-static.
4223 (Interface): Moved this here; it's now implemented similar to
4225 (Method, Property, Event, Indexer): Added `bool is_interface'
4226 argument to their .ctor's.
4227 (MemberBase.IsInterface): New public field.
4229 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4230 instances instead of InterfaceMethod, InterfaceProperty, etc.
4231 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4232 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4234 2004-03-19 Martin Baulig <martin@ximian.com>
4236 * class.cs (MethodCore.IsDuplicateImplementation): New private
4237 method which does the CS0111 checking.
4238 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4239 Use IsDuplicateImplementation().
4241 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4243 * decl.cs (FindMemberToOverride): New method to find the correct
4244 method or property to override in the base class.
4246 - Make Method/Property use the above method to find the
4247 version in the base class.
4248 - Remove the InheritableMemberSignatureCompare as it is now
4251 This patch makes large code bases much faster to compile, as it is
4252 O(n) rather than O(n^2) to do this validation.
4254 Also, it fixes bug 52458 which is that nested classes are not
4255 taken into account when finding the base class member.
4257 Reviewed/Approved by Martin.
4259 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4261 * interface.cs: In all interface classes removed redundant
4262 member initialization.
4264 2004-03-16 Martin Baulig <martin@ximian.com>
4266 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4268 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4270 * decl.cs (DefineTypeAndParents): New helper method to define a
4271 type's containers before the type itself is defined; This is a
4272 bug exposed by the recent changes to Windows.Forms when an
4273 implemented interface was defined inside a class that had not been
4276 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4278 (Check): Loop correctly to report errors modifiers
4279 (UNSAFE was not in the loop, since it was the same as TOP).
4281 * interface.cs: Every interface member now takes a ModFlags,
4282 instead of a "is_new" bool, which we set on the base MemberCore.
4284 Every place where we called "UnsafeOk" in the interface, now we
4285 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4286 the unsafe settings from the member declaration instead of the
4287 container interface.
4289 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4291 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4292 `set_indexer_name' to the pending bits (one per type).
4294 We fixed a bug today that was picking the wrong method to
4295 override, since for properties the existing InterfaceMethod code
4296 basically ignored the method name. Now we make sure that the
4297 method name is one of the valid indexer names.
4299 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4301 * support.cs (SeekableStreamReader): Keep track of stream byte
4302 positions and don't mix them with character offsets to the buffer.
4304 Patch from Gustavo Giráldez
4306 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4308 * interface.cs (InterfaceSetGetBase): Removed double member
4309 initialization, base class does it as well.
4311 2004-03-13 Martin Baulig <martin@ximian.com>
4313 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4314 when compiling corlib.
4316 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4318 * convert.cs (ExplicitConversion): We were reporting an error on
4319 certain conversions (object_type source to a value type, when the
4320 expression was `null') before we had a chance to pass it through
4321 the user defined conversions.
4323 * driver.cs: Replace / and \ in resource specifications to dots.
4326 * class.cs: Add check for duplicate operators. Fixes 52477
4328 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4330 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4331 that are in the middle of the statements, not only at the end.
4334 * class.cs (TypeContainer.AddField): No longer set the
4335 `HaveStaticConstructor' flag, now we call it
4336 `UserDefineStaticConstructor' to diferentiate the slightly
4337 semantic difference.
4339 The situation is that we were not adding BeforeFieldInit (from
4340 Modifiers.TypeAttr) to classes that could have it.
4341 BeforeFieldInit should be set to classes that have no static
4346 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4348 And most importantly Zoltan's comment:
4350 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4352 "I think beforefieldinit means 'it's ok to initialize the type sometime
4353 before its static fields are used', i.e. initialization does not need
4354 to be triggered by the first access to the type. Setting this flag
4355 helps the JIT to compile better code, since it can run the static
4356 constructor at JIT time, and does not need to generate code to call it
4357 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4358 this flag for lots of classes like String.
4360 csc sets this flag if the type does not have an explicit static
4361 constructor. The reasoning seems to be that if there are only static
4362 initalizers for a type, and no static constructor, then the programmer
4363 does not care when this initialization happens, so beforefieldinit
4366 This bug prevents the AOT compiler from being usable, since it
4367 generates so many calls to mono_runtime_class_init that the AOT code
4368 is much slower than the JITted code. The JITted code is faster,
4369 because it does not generate these calls if the vtable is type is
4370 already initialized, which is true in the majority of cases. But the
4371 AOT compiler can't do this."
4373 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4375 * class.cs (MethodData.Emit): Refactor the code so symbolic
4376 information is generated for destructors; For some reasons we
4377 were taking a code path that did not generate symbolic information
4380 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4382 * class.cs: Create a Constructor.CheckBase method that
4383 takes care of all validation type code. The method
4384 contains some code that was moved from Define.
4386 It also includes new code that checks for duplicate ctors.
4387 This fixes bug #55148.
4389 2004-03-09 Joshua Tauberer <tauberer@for.net>
4391 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4392 a { ... }-style array creation invokes EmitStaticInitializers
4393 which is not good for reference-type arrays. String, decimal
4394 and now null constants (NullCast) are not counted toward
4395 static initializers.
4397 2004-03-05 Martin Baulig <martin@ximian.com>
4399 * location.cs (SourceFile.HasLineDirective): New public field;
4400 specifies whether the file contains or is referenced by a "#line"
4402 (Location.DefineSymbolDocuments): Ignore source files which
4403 either contain or are referenced by a "#line" directive.
4405 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4407 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4408 direct access to our parent, so check the method inline there.
4410 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4412 * expression.cs (Invocation.EmitCall): Miguel's last commit
4413 caused a regression. If you had:
4418 In Foo the implict this would be null.
4420 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4422 * expression.cs (Invocation.EmitCall): If the method is not
4423 virtual, do not emit a CallVirt to it, use Call.
4425 * typemanager.cs (GetFullNameSignature): Improve the method to
4426 cope with ".ctor" and replace it with the type name.
4428 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4429 as an argument the ConstructorBuilder where it is being defined,
4430 to catch the recursive constructor invocations.
4432 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4434 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4435 routines to check if a type is an enumerable/enumerator allow
4436 classes that implement the IEnumerable or IEnumerator interfaces.
4438 * class.cs (Property, Operator): Implement IIteratorContainer, and
4439 implement SetYields.
4441 (Property.Define): Do the block swapping for get_methods in the
4442 context of iterators. We need to check if Properties also
4443 include indexers or not.
4445 (Operator): Assign the Block before invoking the
4446 OperatorMethod.Define, so we can trigger the Iterator code
4449 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4450 Property and Operator classes are not created when we parse the
4451 declarator but until we have the block completed, so we use a
4452 singleton SimpleIteratorContainer.Simple to flag whether the
4453 SetYields has been invoked.
4455 We propagate this setting then to the Property or the Operator to
4456 allow the `yield' to function.
4458 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4460 * codegen.cs: Implemented attribute support for modules.
4461 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4462 Assembly/Module functionality.
4464 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4465 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4466 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4468 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4470 * interface.cs (FindMembers): The operation is performed on all base
4471 interfaces and not only on the first. It is required for future CLS Compliance patch.
4473 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4475 * statement.cs, codegen.cs:
4476 This patch deals with patterns such as:
4478 public class List : IEnumerable {
4480 public MyEnumerator GetEnumerator () {
4481 return new MyEnumerator(this);
4484 IEnumerator IEnumerable.GetEnumerator () {
4488 public struct MyEnumerator : IEnumerator {
4493 Before, there were a few things we did wrong:
4494 1) we would emit callvirt on a struct, which is illegal
4495 2) we emited ldarg when we needed to emit ldarga
4496 3) we would mistakenly call the interface methods on an enumerator
4497 type that derived from IEnumerator and was in another assembly. For example:
4499 public class MyEnumerator : IEnumerator
4501 Would have the interface methods called, even if there were public impls of the
4502 method. In a struct, this lead to invalid IL code.
4504 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4506 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4509 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4511 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4513 * cs-parser.jay: Fix small regression: we were not testing V2
4514 compiler features correctly.
4516 * interface.cs: If the emit context is null, then create one
4518 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4520 * decl.cs (GetSignatureForError): New virtual method to get full name
4523 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4524 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4526 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4527 Duplicated members and code in these classes has been removed.
4528 Better encapsulation in these classes.
4530 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4532 * assign.cs (Assign.DoResolve): When dealing with compound
4533 assignments, there is a new rule in ECMA C# 2.4 (might have been
4534 there before, but it is documented here) that states that in:
4538 If b is of type int, and the `op' is a shift-operator, then the
4539 above is evaluated as:
4543 * expression.cs (Binary.ResolveOperator): Instead of testing for
4544 int/uint/long/ulong, try to implicitly convert to any of those
4545 types and use that in pointer arithmetic.
4547 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4548 method to print information for from the type, not from the
4549 null-method we were given.
4551 2004-02-01 Duncan Mak <duncan@ximian.com>
4553 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4554 parsing for cmd, fixes bug #53694.
4556 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4558 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4559 in the member name duplication tests. Property and operator name duplication
4560 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4562 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4564 * interface.cs (PopulateMethod): Fixed crash when interface method
4565 returns not existing type (error test cs0246-3.cs).
4567 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4569 * cs-parser.jay (interface_accessors): Re-write actions to also
4570 store attributes attached to get and set methods. Fix spelling
4573 (inteface_property_declaration): Modify accordingly.
4575 (InterfaceAccessorInfo): New helper class to store information to pass
4576 around between rules that use interface_accessors.
4578 * interface.cs (Emit): Apply attributes on the get and set
4579 accessors of properties and indexers too.
4581 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4582 right MethodBuilder when applying attributes to the get and set accessors.
4584 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4586 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4588 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4590 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4592 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4594 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4595 changes that treat `yield' specially when present before `break'
4598 * cs-tokenizer.cs: yield is no longer a keyword.
4600 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4602 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4603 setting for default constructors.
4604 For default constructors are almost every time set wrong Modifier. The
4605 generated IL code has been alright. But inside mcs this values was
4606 wrong and this was reason why several of my CLS Compliance tests
4609 2004-01-22 Martin Baulig <martin@ximian.com>
4611 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4612 not a QualifiedIdentifier. This is what `type_name_expression'
4613 was previously doing.
4614 (type_name_expression): Removed; the code is now in
4615 `namespace_or_type_name'.
4616 (qualified_identifier): Removed, use `namespace_or_type_name'
4618 (QualifiedIdentifier): Removed this class.
4620 2004-01-22 Martin Baulig <martin@ximian.com>
4622 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4623 not a string as alias name.
4625 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4627 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4628 #52730 bug, and instead compute correctly the need to use a
4629 temporary variable when requesting an address based on the
4630 static/instace modified of the field and the constructor.
4632 2004-01-21 Martin Baulig <martin@ximian.com>
4634 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4635 class and namespace before looking up aliases. Fixes #52517.
4637 2004-01-21 Martin Baulig <martin@ximian.com>
4639 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4640 assinged in a 'try'; fixes exception4.cs.
4642 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4643 * class.cs : Implemented parameter-less constructor for TypeContainer
4645 * decl.cs: Attributes are now stored here. New property OptAttributes
4647 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4649 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4651 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4653 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4654 (CSharpSignature): New method for indexer and property signature.
4656 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4658 * pending.cs (IsVirtualFilter): Faster implementation.
4660 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4662 * typemanager.cs: Avoid inclusion of same assembly more than once.
4664 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4666 * cs-parser.jay: Fixed problem where the last assembly attribute
4667 has been applied also to following declaration (class, struct, etc.)
4669 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4671 * class.cs: Added error CS0538, CS0539 reporting.
4672 Fixed crash on Microsoft runtime when field type is void.
4674 * cs-parser.jay: Added error CS0537 reporting.
4676 * pending.cs: Added error CS0535 reporting.
4677 Improved error report for errors CS0536, CS0534.
4679 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4681 Merge a few bits from the Anonymous Method MCS tree.
4683 * statement.cs (ToplevelBlock): New class for toplevel methods,
4684 will hold anonymous methods, lifted variables.
4686 * cs-parser.jay: Create toplevel blocks for delegates and for
4687 regular blocks of code.
4689 2004-01-20 Martin Baulig <martin@ximian.com>
4691 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4692 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4693 and `NeedExplicitReturn'; added `IsLastStatement'.
4694 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4695 have a `ReturnLabel' or we're not unreachable.
4697 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4698 child's reachability; don't just override ours with it. Fixes
4699 #58058 (lluis's example).
4700 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4701 InFinally(), InLoop(), InSwitch() and
4702 BreakCrossesTryCatchBoundary() methods.
4704 * statement.cs (Return): Do all error checking in Resolve().
4705 Unless we are the last statement in a top-level block, always
4706 create a return label and jump to it.
4707 (Break, Continue): Do all error checking in Resolve(); also make
4708 sure we aren't leaving a `finally'.
4709 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4710 statement in a top-level block.
4711 (Block.Flags): Added `IsDestructor'.
4712 (Block.IsDestructor): New public property.
4714 2004-01-20 Martin Baulig <martin@ximian.com>
4716 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4718 2004-01-20 Martin Baulig <martin@ximian.com>
4720 * statement.cs (Statement.ResolveUnreachable): New public method.
4721 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4722 (Block.Resolve): Resolve unreachable statements.
4724 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4726 * expression.cs: We need to fix the case where we do
4727 not have a temp variable here.
4729 * assign.cs: Only expression compound assignments need
4730 temporary variables.
4732 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4734 * flowanalysis.cs: Reduce memory allocation in a few ways:
4735 - A block with no variables should not allocate a bit
4737 - A method with no out parameters does not need any tracking
4738 for assignment of the parameters, so we need not allocate
4741 public readonly Type[] VariableTypes;
4742 public readonly string[] VariableNames;
4743 Are redundant. The data is already stored in the variable
4744 map, so we need not allocate another array for it.
4745 - We need to add alot of checks for if (params | locals) == null
4746 due to the first two changes.
4748 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4750 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4751 implement IMemoryLocation, we store a copy on a local variable and
4752 take the address of it. Patch from Benjamin Jemlich
4754 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4755 to use a special "type_name_expression" rule which reduces the
4756 number of "QualifiedIdentifier" classes created, and instead
4757 directly creates MemberAccess expressions.
4759 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4761 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4762 that fixes #52853. Null literal assignment to ValueType
4764 * class.cs (MethodData.Emit): Instead of checking the name of the
4765 method to determine if its a destructor, create a new derived
4766 class from Method called Destructor, and test for that.
4768 * cs-parser.jay: Create a Destructor object instead of a Method.
4770 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4774 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4776 * expression.cs (Binary.ResolveOperator): Perform an implicit
4777 conversion from MethodGroups to their delegate types on the
4780 * delegate.cs: Introduce a new class DelegateCreation that is the
4781 base class for `NewDelegate' and `ImplicitDelegateCreation',
4782 factor some code in here.
4784 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4785 conversion from MethodGroups to compatible delegate types.
4787 * ecore.cs (Expression.Resolve): Do not flag error 654
4788 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4789 we allow conversions from MethodGroups to delegate types now.
4791 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4792 assignments in v2 either.
4794 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4796 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4797 static read-only fields in ctors.
4799 Applied patch from Benjamin Jemlich
4801 * expression.cs (UnaryMutator): Avoid leaking local variables.
4803 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4805 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4806 here to return true, as they can be used like this:
4810 Fixed 49836 and all the other dups
4812 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4814 * driver.cs: Implement /win32res and /win32icon.
4816 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4818 * cs-parser.jay: Add a rule to improve error handling for the
4819 common mistake of placing modifiers after the type.
4821 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4823 * cs-parser.jay (interface_event_declaration): Catch
4824 initialization of events on interfaces, and report cs0068
4826 * cs-parser.jay (interface_event_declaration): Catch
4827 initialization of events.
4829 * ecore.cs: Better report missing constructors.
4831 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4832 the error reporting done in the wrong place. Fix.
4834 * expression.cs (Binary.ResolveOperator): Catch the
4835 operator + (E x, E y) error earlier, and later allow for implicit
4836 conversions in operator +/- (E e, U x) from U to the underlying
4839 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4840 52596, if the container class is abstract, the default constructor
4841 is protected otherwise its public (before, we were always public).
4843 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4846 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4847 Jemlich that fixes bug #52597, MCS was generating invalid code for
4848 idisposable structs. Thanks to Ben for following up with this
4851 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4853 * driver.cs: Allow assemblies without code to be generated, fixes
4856 2004-01-07 Nick Drochak <ndrochak@gol.com>
4858 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4860 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4862 * cs-parser.jay: Add rules to improve error reporting if fields or
4863 methods are declared at the namespace level (error 116)
4865 * Add rules to catch event add/remove
4867 2004-01-04 David Sheldon <dave-mono@earth.li>
4869 * expression.cs: Added matching ")" to error message for
4872 2004-01-03 Todd Berman <tberman@gentoo.org>
4874 * ecore.cs, attribute.cs:
4875 Applying fix from #52429.
4877 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4879 * ecore.cs, expression.cs, statement.cs:
4880 Total rewrite of how we handle branching. We
4881 now handle complex boolean expressions with fewer
4882 jumps. As well if (x == 0) no longer emits a ceq.
4884 if (x is Foo) is much faster now, because we generate
4887 Overall, we get a pretty big improvement on our benchmark
4888 tests. The code we generate is smaller and more readable.
4890 I did a full two-stage bootstrap. The patch was reviewed
4891 by Martin and Miguel.
4893 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4895 * cs-parser.jay: Make primary_expression not take a QI.
4896 we dont need this because the member_access rule covers
4897 us here. So we replace the rule with just IDENTIFIER.
4899 This has two good effects. First, we remove a s/r conflict.
4900 Second, we allocate many fewer QualifiedIdentifier objects.
4902 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4904 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4905 set the correct information via SRE. This prevents
4906 hanging on the MS runtime. Fixes #29374.
4908 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4910 * convert.cs: correctly handle conversions to value types
4911 from Enum and ValueType as unboxing conversions.
4913 Fixes bug #52569. Patch by Benjamin Jemlich.
4915 2004-01-02 Ravi Pratap <ravi@ximian.com>
4917 * expression.cs (BetterConversion): Prefer int -> uint
4918 over int -> ulong (csc's behaviour). This fixed bug #52046.
4920 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4922 * decl.cs (MemberCache.FindMembers): now returns a
4925 * typemanager.cs: In general, go with with ^^.
4926 (CopyNewMethods): take an IList.
4927 (RealMemberLookup): Only allocate an arraylist
4928 if we copy from two sets of methods.
4930 This change basically does two things:
4931 1) Fewer array lists allocated due to CopyNewMethods.
4932 2) the explicit cast in MemberList costed ALOT.
4934 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4936 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4937 a hashtable to avoid needless string allocations when an identifier is
4938 used more than once (the common case).
4940 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4942 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4943 is broken, it will not return anything. So, we
4944 have to use the information we have in mcs to
4947 * typemanager.cs: Add a cache for GetInterfaces,
4948 since this will now be used more often (due to ^^)
4950 (GetExplicitInterfaces) New method that gets the
4951 declared, not effective, interfaces on a type
4952 builder (eg, if you have interface IFoo, interface
4953 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4956 This patch makes MCS able to bootstrap itself on
4959 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4961 * expression.cs: Remove the Nop's that Miguel put
4964 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4966 * report.cs, codegen.cs: Give the real stack trace to
4967 the error when an exception is thrown.
4969 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4971 * decl.cs: only allocate hashtables for ifaces if
4974 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4976 * expression.cs: fix the error from cs0121-2.cs
4977 (a parent interface has two child interfaces that
4978 have a function with the same name and 0 params
4979 and the function is called through the parent).
4981 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4983 * class.cs, rootcontext.cs, typmanager.cs: do not
4986 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4988 * codegen.cs: remove stack for the ec flow branching.
4989 It is already a linked list, so no need.
4991 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4993 * Makefile: Allow custom profiler here.
4995 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4997 * typemanager.cs (LookupType):
4998 - Use a static char [], because split takes
4999 a param array for args, so it was allocating
5001 - Do not store true in a hashtable, it boxes.
5003 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
5005 * flowanalysis.cs: bytify common enums.
5007 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5009 * modifiers.cs: Add a new set of flags for the
5010 flags allowed on explicit interface impls.
5011 * cs-parser.jay: catch the use of modifiers in
5012 interfaces correctly.
5013 * class.cs: catch private void IFoo.Blah ().
5015 All related to bug #50572.
5017 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5019 * decl.cs: Rewrite the consistant accessability checking.
5020 Accessability is not linear, it must be implemented in
5021 a tableish way. Fixes #49704.
5023 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
5025 * expression.cs: Handle negation in a checked context.
5026 We must use subtraction from zero. Fixes #38674.
5028 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5030 * class.cs: Ignore static void main in DLLs.
5031 * rootcontext.cs: Handle the target type here,
5032 since we are have to access it from class.cs
5033 * driver.cs: account for the above.
5035 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
5037 * report.cs: Give line numbers and files if available.
5039 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
5041 * driver.cs: Implement /addmodule.
5043 * typemanager.cs: Change 'modules' field so it now contains Modules not
5046 2003-12-20 Martin Baulig <martin@ximian.com>
5048 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
5049 (FieldBase.IsAssigned): Removed this field.
5050 (FieldBase.SetAssigned): New public method.
5051 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
5053 2003-12-20 Martin Baulig <martin@ximian.com>
5055 * expression.cs (LocalVariableReference.DoResolve): Don't set
5056 `vi.Used' if we're called from DoResolveLValue().
5058 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
5059 returns the usage vector it just merged into the current one -
5060 pass this one to UsageWarning().
5061 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
5062 of the `EmitContext', don't call this recursively on our children.
5064 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
5066 * driver.cs: Implement /target:module.
5068 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
5070 * support.cs (CharArrayHashtable): New helper class.
5072 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
5073 char arrays, not strings, so we can avoid creating a string in
5074 consume_identifier if the identifier is a keyword.
5076 2003-12-16 Martin Baulig <martin@ximian.com>
5078 * statement.cs (LocalInfo.Assigned): Removed this property.
5079 (LocalInfo.Flags): Removed `Assigned'.
5080 (LocalInfo.IsAssigned): New public method; takes the EmitContext
5081 and uses flow analysis.
5082 (Block.UsageWarning): Made this method private.
5083 (Block.Resolve): Call UsageWarning() if appropriate.
5085 * expression.cs (LocalVariableReference.DoResolve): Always set
5086 LocalInfo.Used here.
5088 2003-12-13 Martin Baulig <martin@ximian.com>
5090 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
5091 any value here; we're now using flow analysis to figure out
5092 whether a statement/block returns a value.
5094 2003-12-13 Martin Baulig <martin@ximian.com>
5096 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
5098 (FlowBranching.MergeFinally): Don't call
5099 `branching.CheckOutParameters()' here, this is called in
5101 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
5102 when adding the `finally' vector.
5104 2003-12-13 Martin Baulig <martin@ximian.com>
5107 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
5108 actually work and also fix #48962.
5110 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
5112 * decl.cs: Do not check System.Object for nested types,
5113 since we know it does not have any. Big bang for buck:
5118 corlib: 17.99 seconds
5122 corlib: 17.39 seconds
5124 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5126 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5127 time we are returning 0 members, so we save alot here.
5129 2003-12-11 Martin Baulig <martin@ximian.com>
5131 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5132 `MergeChild()', also just take the `FlowBranching' as argument;
5133 call Merge() on it and return the result.
5134 (FlowBranching.Merge): We don't need to do anything if we just
5137 2003-12-11 Martin Baulig <martin@ximian.com>
5139 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5140 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5141 Maurer for this idea.
5143 2003-12-11 Martin Baulig <martin@ximian.com>
5145 * flowanalysis.cs (MergeResult): This class is now gone; we now
5146 use the `UsageVector' for this. The reason for this is that if a
5147 branching just has one sibling, we don't need to "merge" them at
5148 all - that's the next step to do.
5149 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5152 2003-12-11 Martin Baulig <martin@ximian.com>
5154 Reworked flow analyis and made it more precise and bug-free. The
5155 most important change is that we're now using a special `Reachability'
5156 class instead of having "magic" meanings of `FlowReturns'. I'll
5157 do some more cleanups and optimizations and also add some more
5158 documentation this week.
5160 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5161 largely reworked this class.
5162 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5163 the new `Reachability' class instead of having "magic" values here.
5164 (FlowBranching): We're now using an instance of `Reachability'
5165 instead of having separate `Returns', `Breaks' etc. fields.
5167 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5168 based on flow analysis; ignore the return value of block.Emit ().
5170 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5172 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5173 if they are private.
5175 2003-12-09 Martin Baulig <martin@ximian.com>
5177 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5178 call them directly on the UsageVector.
5180 2003-12-09 Martin Baulig <martin@ximian.com>
5182 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5183 Changed return type from `FlowReturns' to `Reachability'.
5185 2003-12-09 Martin Baulig <martin@ximian.com>
5187 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5188 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5189 `Reachable' fields with a single `Reachability' one.
5191 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5193 * class.cs (FindMembers): Remove foreach's.
5206 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5211 This patch does a few things:
5212 1. EmptyStatement is now a singleton, so it is never reallocated.
5213 2. All blah is EmptyStatement constructs have been changed to
5214 blah == EmptyStatement.Value, which is much faster and valid
5215 now that EmptyStatement is a singleton.
5216 3. When resolving a block, rather than allocating a new array for
5217 the non-empty statements, empty statements are replaced with
5218 EmptyStatement.Value
5219 4. Some recursive functions have been made non-recursive.
5220 Mainly the performance impact is from (3), however (1) and (2) are needed for
5221 this to work. (4) does not make a big difference in normal situations, however
5222 it makes the profile look saner.
5227 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5228 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5229 Total memory allocated: 56397 KB
5232 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5233 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5234 Total memory allocated: 55666 KB
5236 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5238 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5239 than the hashtable in a hashtable version
5241 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5242 we always end up concating a string. This results in a huge perf
5243 loss, because many strings have to be tracked by the GC. In this
5244 patch, we first use a hashtable that works with two keys, so that
5245 the strings do not need to be concat'ed.
5256 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5258 * Makefile: Add a new target `do-time' that does a quick and simple
5259 profile, leaving easy to parse output.
5261 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5263 * codegen.cs (Init): Create the dynamic assembly with
5264 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5266 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5268 * support.cs: Make the PtrHashtable use only one
5269 instance of its comparer.
5271 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5273 * typemanager.cs: Fix lookup of GetNamespaces.
5275 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5277 * expression.cs: Removed redundant line.
5279 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5280 ArrayLists, use for loops with bounds.
5282 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5285 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5286 arraylists, use for loop with bounds.
5288 The above three changes give us a 0.071 second performance
5289 improvement out of 3.294 seconds down to 3.223. On my machine
5290 the above changes reduced the memory usage by 1,387 KB during
5293 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5294 QualifiedIdentifiers. Before we created a new string through
5295 concatenation, and mostly later on, the result would be
5296 manipulated by DecomposeQI through string manipulation.
5298 This reduced the compiler memory usage for bootstrapping from
5299 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5300 compile times in 0.05 seconds.
5302 2003-11-28 Dick Porter <dick@ximian.com>
5304 * support.cs: Do string compares with the Invariant culture.
5312 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5313 the comparison is done with the Invariant culture.
5315 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5317 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5318 GetEnumerator method.
5320 (ProbeCollectionType): Iterate starting at the most specific type
5321 upwards looking for a GetEnumerator
5323 * expression.cs: Shift count can be up to 31 for int/uint and 63
5326 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5328 * statement.cs (Block.LookupLabel): Also look for the label on the
5329 children blocks. Use a hash table to keep track of visited
5332 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5333 we actually did transform the other operand, otherwise fall back
5334 to the common codepath that casts to long.
5336 * cs-tokenizer.cs: Use the same code pattern as the int case.
5337 Maybe I should do the parsing myself, and avoid depending on the
5338 Parse routines to get this done.
5340 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5342 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5343 which fixes bug 51347. This time test it.
5345 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5346 attributes for example can not tell the difference between these.
5347 The difference was only a syntax feature of the language.
5349 * attribute.cs: Apply attributes to delegates.
5351 * delegate.cs: Call the apply attributes method.
5353 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5355 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5356 comparing 0 vs Byte.MinValue, not the value
5358 (ImplicitConversionRequired): When reporting a conversion error,
5359 use error 31 to print out the constant error instead of the
5362 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5363 which fixes bug 51347.
5365 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5367 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5368 which fixes the -warnaserror command line option.
5370 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5372 * cfold.cs (DoNumericPromotions): During constant folding of
5373 additions on UIntConstant, special case intconstants with
5374 IntConstants like we do on the expression binary operator.
5376 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5378 * convert.cs (ImplicitReferenceConversion): We were missing a case
5379 (System.Enum are not value types or class types, so we need to
5380 classify them separatedly).
5382 * driver.cs: We do not support error 2007.
5384 2003-11-12 Jackson Harper <jackson@ximian.com>
5386 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5387 system directory. Also use the full file name so users can
5388 libraries names mscorlib-o-tron.dll in a non system dir.
5390 2003-11-10 Martin Baulig <martin@ximian.com>
5392 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5393 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5394 calling `ResolveType()' on them, directly assign their `Type'.
5396 2003-11-08 Martin Baulig <martin@ximian.com>
5398 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5399 return value and the `out parent' parameter.
5400 (TypeContainer.DefineType): Moved the CS0644 check into
5401 GetClassBases(). Don't pass the interface types to the
5402 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5403 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5405 * ecore.cs (TypeExpr.IsAttribute): New property.
5406 (TypeExpr.GetInterfaces): New method.
5408 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5409 TypeExpr instead of a Type.
5410 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5411 (Interface.DefineType): Don't pass the interface types to the
5412 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5413 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5415 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5416 instead of a `Type[]'.
5417 (TypeManager.RegisterBuilder): Likewise.
5418 (TypeManager.AddUserInterface): Likewise.
5419 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5420 `Type[]' and also return a `TypeExpr[]'.
5421 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5423 2003-11-08 Martin Baulig <martin@ximian.com>
5425 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5428 2003-11-08 Martin Baulig <martin@ximian.com>
5430 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5431 TypeManager.ResolveExpressionTypes().
5433 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5434 instead of an Expression.
5435 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5436 (TypeExpression): New public class; formerly known as `TypeExpr'.
5438 * expression.cs (ComposedCast): Derive from TypeExpr.
5440 * typemanager.cs (TypeManager.system_*_expr): These are now
5441 TypExpr's instead of Expression's.
5442 (TypeManager.ResolveExpressionTypes): New public static function;
5443 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5446 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5448 * expression.cs (New.DoResolve): Do not dereference value that
5449 might be a null return.
5451 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5452 sure that the constant value has the right type. Fixes an
5453 unreported bug, similar to 50425.
5455 * const.cs (Const.LookupConstantValue): Call
5456 ImplicitStandardConversionExists before doing a conversion to
5457 avoid havng the TypeManager.ChangeType do conversions.
5459 Reduced the number of casts used
5461 (Const.ChangeType): New routine to enable reuse of the constant
5462 type changing code from statement.
5464 * typemanager.cs (ChangeType): Move common initialization to
5465 static global variables.
5469 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5470 every value type to go through, even if it was void. Fix that.
5472 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5473 character of the define, and the is_identifier_part_character for
5474 the rest of the string.
5476 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5478 * expression.cs (UnaryMutator.EmitCode): When I updated
5479 LocalVariableReference.DoResolve, I overdid it, and dropped an
5480 optimization done on local variable references.
5482 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5484 * ecore.cs: Convert the return from Ldlen into an int.
5486 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5488 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5489 the accessibility, this is a special case for toplevel non-public
5490 classes (internal for instance).
5492 2003-10-20 Nick Drochak <ndrochak@gol.com>
5494 * ecore.cs: Fix typo and build. Needed another right paren.
5496 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5498 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5499 `internal' case regular and protected, but not allowing protected
5500 to be evaluated later. Bug 49840
5502 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5504 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5505 to kb.Nlast, and not the kb.nFirst to isolate the switch
5508 Extract the underlying type, so enumerations of long/ulong are
5509 treated like long/ulong.
5511 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5513 * expression.cs (New): Overload the meaning of RequestedType to
5514 track the possible creation of the NewDelegate type, since
5515 DoResolve is invoked more than once for new constructors on field
5518 See bugs: #48800 and #37014
5520 * cs-parser.jay (declare_local_constants): Take an arraylist
5521 instead of a single constant.
5523 (local_constant_declaration): It should take a
5524 constant_declarators, not a constant_declarator. Fixes 49487
5526 * convert.cs: Fix error report.
5528 2003-10-13 Jackson Harper <jackson@ximian.com>
5530 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5533 2003-10-09 Martin Baulig <martin@ximian.com>
5535 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5537 (MethodCore.DoDefineParameters): Removed the TypeContainer
5538 argument; use the DeclSpace which was passed to the .ctor instead.
5539 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5540 TypeContainer; we only need a DeclSpace here.
5542 2003-10-09 Martin Baulig <martin@ximian.com>
5544 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5546 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5547 EmitContext's .ctor.
5549 2003-10-09 Martin Baulig <martin@ximian.com>
5551 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5552 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5553 AsAccessible(), moved them as well.
5555 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5557 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5559 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5561 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5563 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5564 generation for >=, as spotted by Paolo, bug 48679.
5565 Patch from David Waite.
5567 * cs-tokenizer.cs: Add handling for #pragma.
5569 * cs-parser.jay: Allow for both yield and yield return in the
5570 syntax. The anti-cobolization of C# fight will go on!
5572 * class.cs (TypeBuilder.DefineType): Catch error condition here
5573 (Parent.DefineType erroring out and returning null).
5575 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5576 coping with enumerations variables, we were mistakenly processing
5577 them as a regular value type instead of built-in types. Fixes the
5580 * typemanager.cs (IsBuiltinOrEnum): New method.
5582 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5584 * cs-parser.jay: Upgrade: yield now needs the return clause.
5586 2003-09-19 Martin Baulig <martin@ximian.com>
5588 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5589 `MemberCache parent' argument. Normally, an interface doesn't
5590 have a parent type except System.Object, but we use this in gmcs
5591 for generic type parameters.
5593 2003-09-18 Martin Baulig <martin@ximian.com>
5595 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5596 on `type.IsInterface'; don't check whether the type has a parent
5597 to determine whether it's an interface.
5599 2003-09-15 Martin Baulig <martin@ximian.com>
5601 * class.cs (TypeContainer.DefineType): Added an error flag to
5602 avoid reporting duplicate CS0146's ("class definition is
5605 * driver.cs (Driver.MainDriver): Abort if
5606 RootContext.ResolveTree() reported any errors.
5608 2003-09-07 Martin Baulig <martin@ximian.com>
5610 * report.cs (Error, Warning): Added overloaded versions which take
5611 a `params object[] args' and call String.Format().
5613 2003-09-07 Martin Baulig <martin@ximian.com>
5615 * decl.cs (DeclSpace..ctor): Don't call
5616 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5617 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5618 (DeclSpace.RecordDecl): New method.
5620 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5622 2003-09-02 Ravi Pratap <ravi@ximian.com>
5624 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5625 value attributes to be applied to ParameterBuilders.
5627 * class.cs (MethodCore.LabelParameters): Make static and more
5628 generic so that it can be used from other places - like interface
5629 methods, for instance.
5631 * interface.cs (Interface.Emit): Call LabelParameters before
5632 emitting attributes on the InterfaceMethod.
5634 2003-08-26 Martin Baulig <martin@ximian.com>
5636 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5637 resolving aliases; fixes #47927.
5639 2003-08-26 Martin Baulig <martin@ximian.com>
5641 * statement.cs (Using.DoResolve): This is internally emitting a
5642 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5643 do not always return. Fixes #47681.
5645 2003-08-26 Martin Baulig <martin@ximian.com>
5647 * decl.cs (MemberCore): Moved WarningNotHiding(),
5648 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5650 (AdditionResult): Make this nested in DeclSpace.
5651 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5652 argument; call NamespaceEntry.Define() unless we're nested in a
5655 * namespace.cs (Namespace.DefineName): New public function. This
5656 is called from DeclSpace's .ctor to add
5657 (Namespace.Lookup): Include DeclSpaces in the lookup.
5659 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5661 * const.cs (Const): Derive from MemberBase, not MemberCore.
5663 2003-08-25 Martin Baulig <martin@ximian.com>
5665 * convert.cs (Convert.ExplicitReferenceConversion): When
5666 converting from an interface type to a class, unbox if the target
5667 type is a struct type. Fixes #47822.
5669 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5671 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5674 2003-08-22 Martin Baulig <martin@ximian.com>
5676 * class.cs (TypeManager.DefineType): When defining a nested type,
5677 call DefineType() on our parent; fixes #47801.
5679 2003-08-22 Martin Baulig <martin@ximian.com>
5681 * class.cs (MethodData.Define): While checking if a method is an
5682 interface implementation, improve the test a bit more to fix #47654.
5684 2003-08-22 Martin Baulig <martin@ximian.com>
5686 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5687 correctly; fixes #47722.
5689 2003-08-22 Martin Baulig <martin@ximian.com>
5691 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5692 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5694 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5696 2003-08-22 Martin Baulig <martin@ximian.com>
5698 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5699 can only be assigned in static constructors. Fixes #47161.
5701 2003-08-22 Martin Baulig <martin@ximian.com>
5703 Rewrote and improved the flow analysis code.
5705 * flowbranching.cs (FlowBranching): Make this class abstract.
5706 (FlowBranching.CreateBranching): New static function to create a
5708 (FlowBranchingBlock, FlowBranchingException): New classes.
5709 (FlowBranching.UsageVector.Type): New public readonly field.
5710 (FlowBranching.UsageVector.Breaks): Removed the setter.
5711 (FlowBranching.UsageVector.Returns): Removed the setter.
5712 (FlowBranching.UsageVector): Added Break(), Return(),
5713 NeverReachable() and Throw() methods to modify the reachability.
5714 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5715 done by FlowBranching.Merge().
5716 (FlowBranching.UsageVector.MergeChild): New method; merges the
5717 merge result into the current vector.
5718 (FlowBranching.Merge): New abstract method to merge a branching.
5720 2003-08-12 Martin Baulig <martin@ximian.com>
5722 * expression.cs (Indirection.CacheTemporaries): Create the
5723 LocalTemporary with the pointer type, not its element type.
5725 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5727 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5728 token was a keyword or not.
5730 Add `error' options where an IDENTIFIER was expected; Provide
5731 CheckToken and CheckIdentifierToken convenience error reporting
5734 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5736 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5737 NameSpaceEntry NameSpaceEntry.
5739 (LookupInterfaceOrClass): Avoid creating a full qualified name
5740 from namespace and name: avoid doing lookups when we know the
5741 namespace is non-existant. Use new Tree.LookupByNamespace which
5742 looks up DeclSpaces based on their namespace, name pair.
5744 * driver.cs: Provide a new `parser verbose' to display the
5745 exception thrown during parsing. This is turned off by default
5746 now, so the output of a failure from mcs is more graceful.
5748 * namespace.cs: Track all the namespaces defined in a hashtable
5751 (IsNamespace): New method
5753 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5755 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5756 we know that we need to concatenate (full typename can never be
5761 * statement.cs: Use a bitfield; Do not initialize to null things
5762 which are done by the constructor by default.
5764 * cs-parser.jay: bug fix, parameter was 4, not 3.
5766 * expression.cs: Just use the property;
5768 * statement.cs: No need for GetVariableInfo method.
5770 2003-08-08 Martin Baulig <martin@ximian.com>
5772 * flowanalysis.cs (FlowReturns): This is now nested in the
5773 `FlowBranching' class.
5774 (MyBitVector): Moved this here from statement.cs.
5775 (FlowBranching.SiblingType): New enum type.
5776 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5778 2003-08-07 Martin Baulig <martin@ximian.com>
5780 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5781 `FlowBranching' class and called `BranchingType'.
5783 2003-08-07 Martin Baulig <martin@ximian.com>
5785 * flowanalysis.cs: Moved all the control flow analysis code into
5788 2003-08-07 Martin Baulig <martin@ximian.com>
5790 * assign.cs (Assign.DoResolve): `target' must either be an
5791 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5794 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5796 * expression.cs (BinaryMethod): This kind of expression is created by the
5797 Binary class if it determines that the operator has to be handled
5800 (BinaryDelegate): This kind of expression is created if we are
5801 dealing with a + or - operator on delegates.
5803 (Binary): remove method, argumetns, and DelegateOperator: when
5804 dealing with methods,
5806 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5808 * statement.cs (Block): use bitfields for the three extra booleans
5809 we had in use. Remove unused topblock parameter.
5811 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5813 * assign.cs: Drop extra unneeded tests.
5815 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5817 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5819 * statement.cs (Foreach): Use VariableStorage instead of
5822 * codegen.cs (VariableStorage): New class used by clients that
5823 require a variable stored: locals or fields for variables that
5824 need to live across yield.
5826 Maybe provide a convenience api for EmitThis+EmitLoad?
5828 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5831 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5833 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5834 RemapParameterLValue): New methods that are used to turn a
5835 precomputed FieldInfo into an expression like this:
5839 The idea is to use this instead of making LocalVariableReference
5840 have more than one meaning.
5842 * cs-parser.jay: Add error production to BASE.
5844 * ecore.cs: Deal with TypeManager.GetField returning null, which
5845 is now a valid return value.
5847 (FieldExprNoAddress): New expression for Fields whose address can
5850 * expression.cs (LocalVariableReference): During the resolve
5851 phases, create new expressions if we are in a remapping context.
5852 Remove code that dealt with remapping here.
5854 (ParameterReference): same.
5856 (ProxyInstance): New expression, like the `This' expression, but
5857 it is born fully resolved. We know what we are doing, so remove
5858 the errors that are targeted to user-provided uses of `this'.
5860 * statement.cs (Foreach): our variable is now stored as an
5861 Expression; During resolution, follow the protocol, dont just
5862 assume it will return this.
5864 2003-08-06 Martin Baulig <martin@ximian.com>
5866 * support.cs (SeekableStreamReader.cs): New public class.
5868 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
5869 SeekableStreamReader instead of the normal StreamReader.
5871 2003-08-04 Martin Baulig <martin@ximian.com>
5873 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
5874 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
5875 deambiguate casts and delegate invocations.
5876 (parenthesized_expression): Use the new tokens to ensure this is
5877 not a cast of method invocation.
5879 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
5880 when reading a `)' and Deambiguate_CloseParens () was previously
5883 * expression.cs (ParenthesizedExpression): New class. This is
5884 just used for the CS0075 test.
5885 (Binary.DoResolve): Check for CS0075.
5887 2003-07-29 Ravi Pratap <ravi@ximian.com>
5889 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5890 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5891 reference comparison.
5893 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5894 examine the ReturnType for equality - this is necessary in the
5895 cases of implicit and explicit operators whose signature also
5896 includes the return type.
5898 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5900 * namespace.cs: Cache the result of the namespace computation,
5901 instead of computing it every time.
5903 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5905 * decl.cs: Use a global arraylist that we reuse over invocations
5906 to avoid excesive memory consumption. Reduces memory usage on an
5907 mcs compile by one meg (45 average).
5909 * typemanager.cs (LookupTypeReflection): In .NET pointers are
5910 private, work around that.
5912 2003-07-23 Miguel de Icaza <miguel@ximian.com>
5914 * literal.cs (IntLiteral): Define Zero and One static literals.
5916 * cs-parser.jay (integer_literal): use static literals to reduce
5917 memory usage for the most used literals (0, 1 and -1). 211kb
5918 reduced in memory usage.
5920 Replace all calls to `new ArrayList' with `new
5921 ArrayList(4)' which is a good average number for most allocations,
5922 and also requires only 16 bytes of memory for its buffer by
5925 This reduced MCS memory usage in seven megabytes for the RSS after
5928 2003-07-28 Ravi Pratap <ravi@ximian.com>
5930 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
5931 handle params methods the correct way by forming only one
5932 applicable set with params and normal methods in them. Earlier we
5933 were looking at params methods only if we found no normal methods
5934 which was not the correct thing to do.
5936 (Invocation.BetterFunction): Take separate arguments indicating
5937 when candidate and the best method are params methods in their
5940 This fixes bugs #43367 and #46199.
5942 * attribute.cs: Documentation updates.
5944 (CheckAttribute): Rename to CheckAttributeTarget.
5945 (GetValidPlaces): Rename to GetValidTargets.
5947 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
5948 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
5952 2003-07-28 Martin Baulig <martin@ximian.com>
5954 * class.cs (TypeContainer.DefineMembers): Use the base type's full
5955 name when looking up the base class of a nested class. Fixes #46977.
5957 2003-07-26 Martin Baulig <martin@ximian.com>
5959 * expression.cs (Indexers.Indexer): New nested struct; contains
5960 getter, setter and the indexer's type.
5961 (Indexers.Properties): This is now an ArrayList of
5963 (IndexerAccess.DoResolveLValue): Correctly set the type if the
5964 indexer doesn't have any getters.
5966 * assign.cs (Assign.DoResolve): Also do the implicit conversions
5967 for embedded property and indexer assignments.
5969 2003-07-26 Martin Baulig <martin@ximian.com>
5971 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
5972 preprocessor directive is not the first non-whitespace character
5975 2003-07-26 Martin Baulig <martin@ximian.com>
5977 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
5978 namespace parsing, follow the spec more closely.
5980 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
5981 NamespaceEntry.Lookup().
5983 2003-07-25 Martin Baulig <martin@ximian.com>
5985 * MethodCore.cs (OverridesSomething): New public field; it's set
5986 from TypeContainer.DefineMembers if this method overrides
5987 something (which doesn't need to be a method). Fix #39462.
5989 2003-07-25 Ravi Pratap <ravi@ximian.com>
5991 * typemanager.cs (GetMembers): Ensure that the list of members is
5992 reversed. This keeps things in sync.
5994 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
5995 find an AttributeUsage attribute.
5997 * expression.cs (Invocation.OverloadResolve): Perform the check
5998 which disallows Invoke to be directly called on a Delegate.
6000 (Error_InvokeOnDelegate): Report error cs1533.
6002 2003-07-25 Martin Baulig <martin@ximian.com>
6004 * expression.cs (Indexers.GetIndexersForType): Only look in the
6005 interface hierarchy if the requested type is already an
6006 interface. Fixes #46788 while keeping #46502 fixed.
6008 2003-07-25 Martin Baulig <martin@ximian.com>
6010 * class.cs (TypeContainer.DefineMembers): Check whether all
6011 readonly fields have been assigned and report warning CS0649 if
6014 * statement.cs (LocalInfo.IsFixed): Always return true if this is
6017 2003-07-24 Ravi Pratap <ravi@ximian.com>
6019 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
6020 returned from GetMethods to make things consistent with the
6021 assumptions MCS makes about ordering of methods.
6023 This should comprehensively fix bug #45127 and it does :-)
6025 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
6026 ordering is actually reverse.
6028 * Clean up some debug messages I left lying around.
6030 * interface.cs (Populate*): Get rid of code which emits attributes
6031 since the stage in which we emit attributes is the 'Emit' stage,
6032 not the define stage.
6034 (Emit): Move attribute emission for interface members here.
6036 2003-07-22 Ravi Pratap <ravi@ximian.com>
6038 * expression.cs (Invocation.OverloadResolve): Follow the spec more
6039 closely: we eliminate methods in base types when we have an
6040 applicable method in a top-level type.
6042 Please see section 14.5.5.1 for an exact description of what goes
6045 This fixes bug #45127 and a host of other related to corlib compilation.
6047 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
6048 array is the method corresponding to the top-level type (this is
6049 because of the changes made to icall.c) so we change this
6052 (MethodGroupExpr.Name): This too.
6054 * typemanager.cs (GetElementType): New method which does the right
6055 thing when compiling corlib.
6057 * everywhere: Make use of the above in the relevant places.
6059 2003-07-22 Martin Baulig <martin@ximian.com>
6061 * cs-parser.jay (invocation_expression): Moved
6062 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
6063 `cast_expression', but create a InvocationOrCast which later
6064 resolves to either an Invocation or a Cast.
6066 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
6067 method; call this before EmitStatement() to make sure that this
6068 expression can be used as a statement.
6070 * expression.cs (InvocationOrCast): New class; resolves to either
6071 an Invocation or a Cast.
6073 * statement.cs (StatementExpression): Call ResolveStatement() on
6074 the ExpressionStatement before emitting it.
6076 2003-07-21 Martin Baulig <martin@ximian.com>
6078 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
6079 `ref' and `out' attributes match; fixes #46220.
6080 (MemberAccess.ResolveMemberAccess): You can't reference a type
6081 through an expression; fixes #33180.
6082 (Indexers.GetIndexersForType): Don't return the indexers from
6083 interfaces the class implements; fixes #46502.
6085 2003-07-21 Martin Baulig <martin@ximian.com>
6087 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
6088 CS0661 checks; fixes bug #30442.
6090 2003-07-21 Martin Baulig <martin@ximian.com>
6092 * decl.cs (AdditionResult): Added `Error'.
6094 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
6096 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
6097 makes cs0031.cs actually work.
6099 2003-07-20 Martin Baulig <martin@ximian.com>
6101 * namespace.cs: Fixed that bug which caused a crash when compiling
6104 2003-07-20 Miguel de Icaza <miguel@ximian.com>
6106 * typemanager.cs (LookupTypeReflection): Never expose types which
6107 are NotPublic, NestedPrivate, NestedAssembly, or
6108 NestedFamANDAssem. We used to return these, and later do a check
6109 that would report a meaningful error, but the problem is that we
6110 would not get the real match, if there was a name override.
6112 2003-07-18 Miguel de Icaza <miguel@ximian.com>
6114 * namespace.cs (Namespace, Name): Do not compute the namespace
6115 name dynamically, compute it in the constructor. This reduced
6116 memory usage by 1697 KB.
6118 * driver.cs: Use --pause to pause at the end.
6120 2003-07-17 Peter Williams <peter@newton.cx>
6122 * Makefile: Change the name of the test target so that it doesn't
6123 conflict with the recursive test target.
6125 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6127 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6128 AddressOf): Do not use EmitThis, that was wrong, use the actual
6131 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6133 * class.cs (MethodData.Define): While checking if a method is an
6134 interface implementation, improve the test: If we are not public
6135 (use new test here: use the computed MethodAttributes directly,
6136 instead of the parsed modifier flags) check if the `implementing'
6137 method comes from an interface or not.
6139 * pending.cs (VerifyPendingMethods): Slightly better error
6142 * makefile: add test target that does the mcs bootstrap.
6144 2003-07-16 Ravi Pratap <ravi@ximian.com>
6146 * interface.cs (Define): Do nothing here since there are no
6147 members to populate etc. Move the attribute emission out of here
6148 since this was just totally the wrong place to put it. Attribute
6149 application happens during the 'Emit' phase, not in the 'Define'
6152 (Emit): Add this method and move the attribute emission here
6154 * rootcontext.cs (EmitCode): Call the Emit method on interface
6157 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6159 * expression.cs (OverloadResolve): Report error only if Location
6160 is not 'Null' which means that there was a probe going on.
6162 2003-07-14 Martin Baulig <martin@ximian.com>
6164 * expression.cs (ConditionalLogicalOperator): New public class to
6165 implement user defined conditional logical operators.
6166 This is section 14.11.2 in the spec and bug #40505.
6168 2003-07-14 Martin Baulig <martin@ximian.com>
6170 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6172 2003-07-14 Martin Baulig <martin@ximian.com>
6174 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6176 * ecore.cs (IVariable.VerifyFixed): New interface method.
6178 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6179 operator, check whether the variable is actually fixed. Fixes bug
6180 #36055. Set a variable definitely assigned when taking its
6181 address as required by the spec.
6183 * statement.cs (LocalInfo.IsFixed): New field.
6184 (LocalInfo.MakePinned): Set `IsFixed' to true.
6186 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6188 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6189 for .ctors, ensure that we only ask for members declared in the
6190 attribute type (BindingFlags.DeclaredOnly).
6194 * expression.cs (Error_WrongNumArguments): Report error 1501
6195 correctly the way CSC does.
6197 2003-07-13 Martin Baulig <martin@ximian.com>
6199 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6200 lookup on the fully qualified name, to make things like "X.X" work
6201 where "X.X" is a fully qualified type name, but we also have a
6202 namespace "X" in the using list. Fixes #41975.
6204 2003-07-13 Martin Baulig <martin@ximian.com>
6206 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6207 function. If we're a CompoundAssign, we need to create an embedded
6208 CompoundAssign, not an embedded Assign.
6209 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6212 2003-07-13 Martin Baulig <martin@ximian.com>
6214 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6215 work to fix bug #46088.
6217 2003-07-13 Ravi Pratap <ravi@ximian.com>
6219 * class.cs (Operator.Emit): Do not emit attributes here - it is
6220 taken care of by the Method class that we delegate too. This takes
6223 2003-07-10 Martin Baulig <martin@ximian.com>
6225 * expression.cs (TypeOfVoid): New class.
6226 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6228 2003-07-10 Martin Baulig <martin@ximian.com>
6230 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6233 2003-07-10 Martin Baulig <martin@ximian.com>
6235 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6236 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6238 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6240 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6242 2003-07-10 Martin Baulig <martin@ximian.com>
6244 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6245 of decimal. Fixes #42850.
6247 NOTE: I also fixed the created byte blob, but this doesn't work on
6248 the MS runtime and csc never produces any byte blobs for decimal
6251 2003-07-10 Martin Baulig <martin@ximian.com>
6253 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6254 structs; fixes #32068.
6255 (Block.AddChildVariableNames): Fixed #44302.
6257 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6259 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6261 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6263 * attribute.cs: And this test is onger needed.
6265 2003-07-08 Martin Baulig <martin@ximian.com>
6267 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6268 inaccessible types. Fixes #36313.
6270 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6272 * namespace.cs (NamespaceEntry): Create implicit entries for all
6273 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6274 implicit entries for N1.N2 and N1.
6276 2003-07-08 Martin Baulig <martin@ximian.com>
6278 Rewrote the handling of namespaces to fix a lot of the issues
6279 wrt. `using' aliases etc.
6281 * namespace.cs (Namespace): Splitted this class into a
6282 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6284 * typemanager.cs (TypeManager.IsNamespace): Removed.
6285 (TypeManager.ComputeNamespaces): Only compute namespaces from
6286 loaded assemblies here, not the namespaces from the assembly we're
6287 currently compiling.
6289 2003-07-08 Martin Baulig <martin@ximian.com>
6291 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6293 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6295 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6298 I thought about the memory savings here, but LookupTypeReflection
6299 is used under already very constrained scenarios. Compiling
6300 corlib or mcs only exposes one hit, so it would not really reduce
6301 any memory consumption.
6303 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6305 * typemanager.cs: fixes bug #45889 by only adding public types from
6306 other assemblies to the list of known types.
6308 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6310 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6311 on the type we resolved.
6313 2003-07-05 Martin Baulig <martin@ximian.com>
6315 * pending.cs (PendingImplementation.ParentImplements): Don't
6316 create the proxy if the parent is abstract.
6318 * class.cs (TypeContainer.DefineIndexers): Process explicit
6319 interface implementations first. Fixes #37714.
6321 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6323 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6324 defined recursively; but since we modify the input parameters
6325 (left is set to `this' temporarily), we reset this value if the
6326 left_is_explicit is false, which gives the original semantics to
6329 * literal.cs (NullPointer): new class used to represent a null
6330 literal in a pointer context.
6332 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6333 type is a pointer, use a NullPointer object instead of a
6334 NullLiteral. Closes 43687
6336 (ExplicitConversion): Convert pointer values using
6337 the conv opcode to the proper type.
6339 * ecore.cs (New): change ValueTypeVariable property into a method,
6340 that returns whether the valuetype is suitable for being used.
6342 * expression.cs (Binary.DoNumericPromotions): Only return if we
6343 the int constant was a valid uint, and we can return both left and
6344 right as uints. If not, we continue processing, to trigger the
6345 type conversion. This fixes 39018.
6347 * statement.cs (Block.EmitMeta): During constant resolution, set
6348 the CurrentBlock property on the emitcontext, so that we resolve
6349 constants propertly.
6351 2003-07-02 Martin Baulig <martin@ximian.com>
6353 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6354 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6356 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6357 than emitting it here.
6359 * statement.cs: Fixed some more flow analysis bugs.
6361 2003-07-02 Martin Baulig <martin@ximian.com>
6363 * class.cs (MethodData.Define): When implementing interface
6364 methods, set Final unless we're Virtual.
6366 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6367 check work for interface methods.
6369 2003-07-01 Martin Baulig <martin@ximian.com>
6371 * ecore.cs (EmitContext.This): Replaced this property with a
6372 GetThis() method which takes a Location argument. This ensures
6373 that we get the correct error location for a CS0188.
6375 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6377 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6378 ImplicitStandardConversion.
6380 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6382 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6384 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6387 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6389 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6392 (MethodData.Define): Turn off initlocals for unsafe methods.
6394 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6396 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6397 complete; Fixes #37521.
6399 * delegate.cs: Use Modifiers.TypeAttr to compute the
6400 TypeAttributes, instead of rolling our own. This makes the flags
6401 correct for the delegates.
6403 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6405 * class.cs (Constructor.Define): Set the private flag for static
6406 constructors as well.
6408 * cs-parser.jay (statement_expression): Set the return value to
6409 null, to avoid a crash when we catch an error.
6411 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6413 * cs-parser.jay: Applied patch from Jackson that adds support for
6414 extern and unsafe modifiers to destructor declarations.
6416 * expression.cs: Report error 21 if the user is trying to index a
6419 * driver.cs: Add an error message, suggested by the bug report.
6421 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6422 if we do not have a ": this ()" constructor initializer. Fixes 45149
6424 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6426 * namespace.cs: Add some information to reduce FAQs.
6428 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6430 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6431 underlying enumeration types. Fixes #43915.
6433 * expression.cs: Treat ushort/short as legal values to be used in
6436 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6438 * delegate.cs: transfer custom attributes for paramenters from
6439 the delegate declaration to Invoke and BeginInvoke.
6441 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6443 * attribute.cs: handle custom marshalers and emit marshal info
6446 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6448 * makefile.gnu: Added anonymous.cs to the compiler sources.
6450 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6452 * iterators.cs: Change the name of the proxy class to include two
6455 * cs-parser.jay: Update grammar to include anonymous methods.
6457 * anonymous.cs: new file.
6459 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6461 * class.cs (Field.Define): Add missing test for pointers and
6464 2003-05-27 Ravi Pratap <ravi@ximian.com>
6466 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6467 we use the stobj opcode.
6469 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6470 since it wasn't the correct fix.
6472 It still is puzzling that we are required to use stobj for IntPtr
6473 which seems to be a ValueType.
6475 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6477 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6478 during regular simple name resolution. Now, the trick is that
6479 instead of returning for processing the simplename, we do a
6480 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6481 contextual lookup type). If a match is found, return that, if
6482 not, return for further composition.
6484 This fixes long-standing 30485.
6486 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6487 using the address to initialize an object, do an Stobj instead of
6488 using the regular Stelem.
6490 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6491 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6492 Because if we are a BaseIndexerAccess that value will be true.
6495 * statement.cs (GotoCase.Resolve): Return after reporting an
6496 error, do not attempt to continue.
6498 * expression.cs (PointerArithmetic.Emit): If our operand is a
6499 long, convert our constants to match the operand before
6500 multiplying. Convert to I type before adding. Fixes 43670.
6502 2003-05-14 Ravi Pratap <ravi@ximian.com>
6504 * enum.cs (ImplicitConversionExists) : Rename to
6505 ImplicitEnumConversionExists to remove ambiguity.
6507 * ecore.cs (NullCast): New type of cast expression class which
6508 basically is very similar to EmptyCast with the difference being
6509 it still is a constant since it is used only to cast a null to
6513 * convert.cs (ImplicitReferenceConversion): When casting a null
6514 literal, we return a NullCast.
6516 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6517 should be around anymore.
6519 The renaming (reported was slightly wrong). Corrections:
6521 ConvertImplicitStandard -> ImplicitConversionStandard
6522 ConvertExplicitStandard -> ExplicitConversionStandard
6524 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6525 before passing them in !
6527 * convert.cs (ImplicitConversionStandard): When comparing for
6528 equal expr and target types, ensure that expr is not a
6531 In general, we must not be checking (expr_type ==
6532 target_type) in the top level conversion methods
6533 (ImplicitConversion, ExplicitConversion etc). This checking is
6534 done in the methods that they delegate to.
6536 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6538 * convert.cs: Move Error_CannotConvertType,
6539 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6540 ImplicitNumericConversion, ImplicitConversionExists,
6541 ImplicitUserConversionExists, StandardConversionExists,
6542 FindMostEncompassedType, FindMostSpecificSource,
6543 FindMostSpecificTarget, ImplicitUserConversion,
6544 ExplicitUserConversion, GetConversionOperators,
6545 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6546 TryImplicitIntConversion, Error_CannotConvertImplicit,
6547 ConvertImplicitRequired, ConvertNumericExplicit,
6548 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6549 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6552 Perform the following renames:
6554 StandardConversionExists -> ImplicitStandardConversionExists
6555 ConvertImplicit -> ImplicitConversion
6556 ConvertImplicitStandard -> ImplicitStandardConversion
6557 TryImplicitIntConversion -> ImplicitIntConversion
6558 ConvertImplicitRequired -> ImplicitConversionRequired
6559 ConvertNumericExplicit -> ExplicitNumericConversion
6560 ConvertReferenceExplicit -> ExplicitReferenceConversion
6561 ConvertExplicit -> ExplicitConversion
6562 ConvertExplicitStandard -> ExplicitStandardConversion
6564 2003-05-19 Martin Baulig <martin@ximian.com>
6566 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6567 (TypeInfo): Added support for structs having structs as fields.
6569 * ecore.cs (FieldExpr): Implement IVariable.
6570 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6571 VariableInfo for the field.
6573 2003-05-18 Martin Baulig <martin@ximian.com>
6575 * expression.cs (This.DoResolve): Report a CS0027 if we're
6576 emitting a field initializer.
6578 2003-05-18 Martin Baulig <martin@ximian.com>
6580 * expression.cs (This.ResolveBase): New public function.
6581 (This.DoResolve): Check for CS0188.
6583 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6586 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6587 `instance_expression' to null if we don't have any non-static
6590 2003-05-18 Martin Baulig <martin@ximian.com>
6592 Reworked the way how local variables and parameters are handled by
6593 the flow analysis code.
6595 * statement.cs (TypeInfo, VariableMap): New public classes.
6596 (VariableInfo): New public class. This is now responsible for
6597 checking whether a variable has been assigned. It is used for
6598 parameters and local variables.
6599 (Block.EmitMeta): Take the InternalParameters as argument; compute
6600 the layout of the flow vectors here.
6601 (Block.LocalMap, Block.ParameterMap): New public properties.
6602 (FlowBranching): The .ctor doesn't get the InternalParameters
6603 anymore since Block.EmitMeta() now computes the layout of the flow
6605 (MyStructInfo): This class is now known as `StructInfo' and nested
6606 in `TypeInfo'; we don't access this directly anymore.
6608 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6609 property and removed IsAssigned(), IsFieldAssigned(),
6610 SetAssigned() and SetFieldAssigned(); we now call them on the
6611 VariableInfo so we don't need to duplicate this code everywhere.
6613 * expression.cs (ParameterReference): Added `Block block' argument
6615 (LocalVariableReference, ParameterReference, This): The new
6616 VariableInfo class is now responsible for all the definite
6619 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6620 IsParameterAssigned, SetParameterAssigned): Removed.
6622 2003-05-18 Martin Baulig <martin@ximian.com>
6624 * typemanager.cs (InitCoreTypes): Try calling
6625 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6626 the 3-args-version. Corlib now also needs our `void_type'.
6627 (GetMethod): Added overloaded version which takes an optional
6628 `bool report_errors' to allow lookups of optional methods.
6630 2003-05-12 Martin Baulig <martin@ximian.com>
6632 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6633 only used for locals and not for parameters.
6635 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6637 * support.cs (InternalParameters.ParameterType): Return the
6638 ExternalType of the parameter.
6640 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6643 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6645 * class.cs (MethodData.Define): Do not set the `newslot' on
6646 interface members, if they are also flagged as "override".
6648 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6649 better code for ++i and i++. This only works for static fields
6650 and local variables.
6652 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6653 want to pull the DeclSpace out of the builder_to_declspace instead
6654 of the TypeBuilder (like in TypeContainer.FindMembers).
6656 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6657 instead of LookupTypeContainer. Fixes the crash on .NET for
6658 looking up interface members.
6660 * const.cs: Create our own emit context during the Definition
6661 stage, so that constants are evaluated in the proper context, when
6662 a recursive definition happens.
6664 2003-05-11 Martin Baulig <martin@ximian.com>
6666 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6667 new block for a switch section.
6668 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6669 the adding/lookup in the switch block. Fixes #39828.
6671 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6673 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6674 functionality: I needed to convert the data after I had performed
6675 the add/sub operation into the operands type size.
6677 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6678 pass the type for the box operation, otherwise the resulting
6679 object would have been of type object.
6681 (BoxedCast): Add constructor to specify the type to box as.
6683 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6685 * iterators.cs: I was reusing the `count' variable inadvertently,
6686 take steps to not allow this to happen.
6688 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6690 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6691 by creating an array at the point where the params starts and
6692 putting all those arguments there, then adjusting the size of the
6695 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6697 * expression.cs (New.AddressOf): Implement interface
6698 IMemoryLocation. This is used when the `new' operator is used in
6699 the context of an invocation to a method on a value type.
6701 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6704 * namespace.cs: Also check the using aliases here.
6706 * driver.cs: Move the test for using validity after the types have
6707 been entered, so we do a single pass that also includes the using
6710 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6711 in the regular case. CreateSiblingForFinally is doing extra
6714 * attribute.cs (GetAttributeArgumentExpression): Store the result
6715 on an out value, and use the return value to indicate failure
6716 instead of using null (which is a valid return for Constant.GetValue).
6718 * statement.cs: Perform the analysis flow for the increment
6719 portion after the statement, because this will be the real flow of
6720 execution. Fixes #42385
6722 * codegen.cs (EmitContext.EmitArgument,
6723 EmitContext.EmitStoreArgument): New helper functions when the
6724 RemapToProxy flag is set.
6726 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6729 Add support for remapping parameters.
6731 * iterators.cs: Propagate parameter values; Store parameter
6732 values in the proxy classes.
6734 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6736 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6737 need a proxy reference; I do not know what I was thinking
6739 * cs-parser.jay (constructor_initializer): catch another error,
6740 and display nice message.
6742 (field_declaration): catch void field declaration
6743 to flag a better error.
6745 * class.cs (MemberBase.CheckBase): Report an error instead of a
6746 warning if a new protected member is declared in a struct.
6747 (Field.Define): catch the error of readonly/volatile.
6749 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6751 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6752 volatile variable is taken
6754 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6756 * statement.cs (Fixed.Resolve): Report an error if we are not in
6759 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6761 * typemanager.cs: reuse the code that handles type clashes for
6762 delegates and enumerations.
6764 * class.cs (Report28): Always report.
6766 * expression.cs (EncodeAsAttribute): Allow nulls here.
6768 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6770 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6771 the functionality for testing whether an expression is valid for
6772 an attribute here. Also handle the case of arrays of elements
6775 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6776 encoding a linear array into an array of objects that are suitable
6777 to be passed to an CustomAttributeBuilder.
6779 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6781 * ecore.cs: (FieldExpr): Handle field remapping here.
6783 * iteratators.cs: Pass the instance variable (if the method is an
6784 instance method) to the constructors, so we can access the field
6785 variables on the class.
6787 TODO: Test this with structs. I think the THIS variable on
6788 structs might have to be a pointer, and not a refenrece
6790 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6792 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6793 local variables to fields in a proxy class.
6795 * iterators.cs (PopulateProxy): Rename our internal fields to
6797 Create a <THIS> field if we are an instance method, so we can
6798 reference our parent container variables.
6799 (MapVariable): Called back from the EmitContext code to enter a
6800 new variable to field mapping into the proxy class (we just create
6804 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6805 for using the remapped locals to fields.
6807 I placed the code here, because that gives the same semantics to
6808 local variables, and only changes the Emit code.
6810 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6811 statements inside iterators.
6812 (VariableInfo): Add a FieldBuilder for the cases when we are
6813 remapping local variables to fields in a proxy class
6815 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6816 current_block != null.
6818 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6819 not cope with strings, as it has been moved to the
6820 TableSwitchEmit. Fixed bug in switch generation.
6822 * expression.cs (New.DoResolve): Provide more context for the user
6823 when reporting an error.
6825 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6828 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6829 check the permissions for it. Note than in a type-resolution
6830 context the check was already present in DeclSpace.ResolveType,
6831 but was missing from the MemberAccess.
6833 (ArrayCreation.CheckIndices): warn if the user has
6834 more nested levels of expressions, but there are no more
6835 dimensions specified. Avoids crash on bug 41906.
6837 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6839 * statement.cs (Block): replace Implicit bool, for a generic
6841 New flag: `Unchecked'. This is used during the EmitMeta phase
6842 (which is out-of-line with the regular Resolve/Emit process for a
6843 statement, as this is done ahead of time, but still gets a chance
6844 to call constant resolve).
6846 (Block.Flags): new enum for adding a new flag.
6848 (Block.EmitMeta): track the state of unchecked.
6850 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6851 to enable constant resolution to work there as well.
6853 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6855 * typemanager.cs (ienumerable_type): Also look up
6856 System.Collections.IEnumerable.
6858 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6860 TODO: Test more than one conditional per method.
6862 * class.cs (Indexer.Define): Report the location where the user is
6863 referencing the unsupported feature.
6865 (MethodData): Overload the use of `conditionals' to
6866 minimize the creation of needless ArrayLists. This saves roughly
6867 212kb on my machine.
6869 (Method): Implement the new IIteratorContainer interface.
6870 (Method.SetYields): Implement the method by setting the ModFlags
6871 to contain METHOD_YIELDS.
6873 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
6874 which just got set to null.
6876 * iterators.cs: New file.
6878 (Yield, YieldBreak): New statements.
6880 * statement.cs (Return.Resolve): Flag an error if we are used in
6883 * codegen.cs (InIterator): New flag set if the code is being
6884 compiled in an iterator method.
6886 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6887 internal modifier, and we just use it to avoid adding extra
6888 fields, as this is seldom used.
6890 * cs-parser.jay: Add yield_statement (yield and yield break).
6892 * driver.cs: New flag -v2 to turn on version 2 features.
6894 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6895 hashtable when v2 is enabled.
6897 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6899 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6900 there is already a namespace defined with this name.
6902 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6903 people upgraded their corlibs.
6905 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
6906 always use fully qualified types, no need to use the compiler
6909 (TypeManager.IsNamespace): Use binarysearch.
6911 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
6912 AddDelegate): I did not quite use the new IsValid API properly: I
6913 have to pass the short-name and the fullname. I was passing only
6914 the basename instead of the fullname sometimes.
6916 (TypeContainer.DefineType): call NamespaceClash.
6918 * interface.cs (Interface.DefineType): use NamespaceClash before
6921 * delegate.cs (Delegate.DefineType): use NamespaceClash before
6924 * enum.cs: (Enum.DefineType): use NamespaceClash before
6927 * typemanager.cs (: 3-line patch that gives us some tasty 11%
6928 speed increase. First, use the negative_hits cache when we get a
6929 negative. Second, add the type with its full original name
6930 instead of the new . and + encoded name (reflection uses + to
6931 separate type from a nested type). Use LookupTypeReflection
6932 directly which bypasses the type->name hashtable (that we already
6933 know does not contain the type.
6935 * decl.cs (DeclSpace.ResolveTypeExpr): track the
6936 location/container type.
6938 * driver.cs: When passing utf8, use directly the UTF8Encoding.
6940 2003-04-19 Miguel de Icaza <miguel@ximian.com>
6942 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
6944 * delegate.cs (NewDelegate.Resolve): Test whether an instance
6945 method is being referenced in the method group from a static
6946 context, and report error 120 if so.
6948 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
6951 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
6952 is created, we create the A namespace).
6954 * cs-parser.jay: A namespace also introduces a DeclarationFound.
6957 2003-04-18 Miguel de Icaza <miguel@ximian.com>
6959 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
6960 invocation to ModuleBuilder.GetType with the same values will
6961 return a new type instance, so we need to cache its return
6964 * expression.cs (Binary.ResolveOperator): Only allow the compare
6965 operators on enums if they are of the same type.
6967 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
6968 types of ValueType on their own case. Before we were giving them
6969 the same treatment as objects.
6971 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
6972 fullname. Short name is used to compare against container name.
6973 Fullname is used to check against defined namespace names.
6975 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
6976 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
6978 (Method.CheckBase): Call parent.
6979 (MemberBase.CheckBase): Check for protected members on sealed
6981 (PropertyBase.CheckBase): Call parent.
6982 (Field.Define): Call parent.
6984 * report.cs: Negative error codes are now mapped to 8000 - code,
6985 so that the display is render more nicely.
6987 * typemanager.cs: Do not use try/catch, instead report a regular
6990 (GetPointerType, GetReferenceType): These methods provide
6991 mechanisms to obtain the T* and T& from a T. We had the code
6992 previously scattered around the code base, and it also used
6993 TypeManager.LookupType that would go through plenty of caches.
6994 This one goes directly to the type source.
6996 In some places we did the Type.GetType followed by
6997 ModuleBuilder.GetType, but not in others, so this unifies the
7000 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
7001 statements now that we have namespace information.
7003 * typemanager.cs (IsNamespace): New method, returns whether the
7004 string presented is a namespace or not.
7006 (ComputeNamespaces): New public entry point, computes the list of
7007 available namespaces, using the GetNamespaces API call in Mono, or
7008 the slower version in MS.NET.
7010 Now before we start the semantic analysis phase, we have a
7011 complete list of namespaces including everything that the user has
7014 Deleted old code to cache namespaces in .nsc files.
7016 2003-04-17 Miguel de Icaza <miguel@ximian.com>
7018 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
7019 class/struct location definition Location for the implicit
7020 constructor location.
7022 (Operator.Define): Use the location of the operator for the
7023 implicit Method definition.
7025 (Constructor.Emit): use the constructor location for the implicit
7026 base initializer constructor.
7028 * ecore.cs: Remove ITypeExpression. This interface is now gone,
7029 and the Expression class now contains two new methods:
7031 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
7032 isolate type lookup from the rest of the resolution process.
7034 Since we use Expressions to hold type definitions due to the way
7035 we parse the input we have historically overloaded Resolve to
7036 perform the Type lookups if a special flag is passed. Now this is
7037 eliminated and two methods take their place.
7039 The differences in the two methods between xStep and xTerminal is
7040 that xStep is involved in our current lookup system that uses
7041 SimpleNames to compose a name, while xTerminal is used just to
7042 catch the case where the simplename lookup failed.
7044 2003-04-16 Miguel de Icaza <miguel@ximian.com>
7046 * expression.cs (ResolveMemberAccess): Remove redundant code.
7047 TypeExpr expressions are always born fully resolved.
7049 * interface.cs (PopulateMethod): Do not lookup the types twice.
7050 We were doing it once during SemanticAnalysis and once during
7053 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
7054 in local variable type definitions, were being returned as a
7055 SimpleName (we decomposed everything into a string), that is
7056 because primary_expression was being used instead of a type in the
7057 grammar (reduce/reduce conflicts).
7059 The part that was wrong is that we converted the expression into a
7060 string (an oversimplification in one hand, compounded with primary
7061 expressions doing string concatenation).
7067 Would return "A.B.C[]" as a SimpleName. This stopped things like
7068 using clauses from working on this particular context. And a type
7069 was being matched directly against "A.B.C[]".
7071 We now use the correct approach, and allow for ComposedCast to be
7072 part of the unary expression. So the "A.B.C []" become a composed
7073 cast of "A.B.C" (as a nested group of MemberAccess with a
7074 SimpleName at the end) plus the rank composition "[]".
7078 2003-04-10 Miguel de Icaza <miguel@ximian.com>
7080 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
7081 for the access level checking.
7083 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
7084 `TypeContainer container', because I kept getting confused when I
7085 was debugging this code.
7087 * expression.cs (Indexers): Instead of tracking getters/setters,
7088 we now track them in parallel. We create one arraylist less, but
7089 most importantly it is possible now for the LValue code to find a
7090 matching get for a set.
7092 (IndexerAccess.DoResolveLValue): Update the code.
7093 GetIndexersForType has been modified already to extract all the
7094 indexers from a type. The code assumed it did not.
7096 Also make the code set the correct return type for the indexer.
7097 This was fixed a long time ago for properties, but was missing for
7098 indexers. It used to be void_type.
7100 (Binary.Emit): Test first for doubles instead of
7101 floats, as they are more common.
7103 (Binary.EmitBranchable): Use the .un version of the branch opcodes
7104 when dealing with floats and the <=, >= operators. This fixes bug
7107 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
7108 to load the array value by emitting a load on the foreach variable
7109 type. This was incorrect.
7111 We now emit the code to load an element using the the array
7112 variable type, and then we emit the conversion operator.
7116 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
7118 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7120 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7122 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7123 test for protection before we test for signatures.
7125 (MethodSignature.ToString): implement.
7127 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7128 to the case where we reduced into a LongConstant.
7130 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7131 depend on whether the information is acurrate, because the
7132 Microsoft runtime will always claim that the array type is public,
7133 regardless of the real state.
7135 If the type is a pointer, another problem happens: the type is
7136 reported as non-public in Microsoft.
7138 In both cases we have to call CheckAccessLevel recursively with
7139 the underlying type as the argument to be tested.
7141 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7143 * assign.cs (Assign.Emit): If we are dealing with a compound
7144 assignment expression, we should use the code path that stores the
7145 intermediate result in a temporary value. This fixes #40903.
7147 *expression.cs (Indirection.ToString): Provide ToString method for
7150 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7152 * class.cs: Null out fields holding references to Block objects so
7153 they can be garbage collected.
7155 * expression.cs (OverloadResolve): Remove unused local.
7157 2003-04-07 Martin Baulig <martin@ximian.com>
7159 * codegen.cs (EmitContext.CurrentFile): New public field.
7160 (EmitContext.Mark): Use the CurrentFile to check whether the
7161 location is in the correct file.
7162 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7164 2003-04-07 Martin Baulig <martin@ximian.com>
7166 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7168 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7169 location. [FIXME: The location argument which gets passed to this
7170 method is sometimes wrong!]
7172 2003-04-07 Nick Drochak <ndrochak@gol.com>
7174 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7176 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7178 * expression.cs (Indirection.EmitAssign): We were using the
7179 temporary, but returning immediately instead of continuing the
7182 2003-04-06 Martin Baulig <martin@ximian.com>
7184 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7185 if it's a nested child, but also deriving from the outer class.
7188 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7189 nested child, but also deriving from the outer class. See
7191 (FilterWithClosure): We may access private members of the outer
7192 class if we're a nested child and deriving from the outer class.
7193 (RealMemberLookup): Only set `closure_private_ok' if the
7194 `original_bf' contained BindingFlags.NonPublic.
7196 2003-04-05 Martin Baulig <martin@ximian.com>
7198 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
7200 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7202 * class.cs (Event.Define): Do not allow abstract events to have
7205 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7207 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7208 block in event declarations.
7210 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7211 value type, get its address.
7213 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7214 leaving a class on the stack instead of a boolean value (int
7215 0/1). Change the code so we compare against null, and then the
7216 result against zero.
7218 * class.cs (TypeContainer.GetClassBases): We were checking for the
7219 parent class being sealed too late.
7221 * expression.cs (Binary.Emit): For <= and >= when dealing with
7222 floating point values, use cgt.un and clt.un instead of cgt and
7225 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7227 * statement.cs: Apply the same optimization as MS: skip the
7228 GetEnumerator returning an IEnumerator, and use the one returning a
7229 CharEnumerator instead. This allows us to avoid the try-finally block
7232 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7234 * cs-parser.jay: Attributes cannot be applied to
7235 namespaces. Fixes #40473
7237 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7240 (Add*): check if the name is valid using the full name for constants,
7241 fields, properties and events.
7243 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7245 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7246 char constants to be part of the enumeration.
7248 * expression.cs (Conditional.DoResolve): Add support for operator
7249 true. Implements the missing functionality from 14.12
7251 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7252 operator true/false as required by the spec.
7254 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7255 implicit conversion to boolean.
7257 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7258 also one where the type implements `operator true'.
7260 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7261 get an expression that will invoke operator true based on an
7264 (GetConversionOperators): Removed the hack that called op_True
7267 (Expression.ResolveBoolean): Move this from Statement.
7269 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7271 * ecore.cs (FieldExpr): do not allow initialization of initonly
7272 fields on derived classes
7274 2003-03-13 Martin Baulig <martin@ximian.com>
7276 * statement.cs (Block.Emit): Call ig.BeginScope() and
7277 ig.EndScope() when compiling with debugging info; call
7278 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7280 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7282 * expression.cs (Indexers): Do not construct immediately, allow
7283 for new members to be appended as we go. Fixes 38143
7285 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7287 * expression.cs: save/restore context when resolving an unchecked
7290 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7292 * cfold.cs: Catch division by zero in modulus operator during
7295 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7297 * interface.cs (Interface.DefineMembers): Avoid defining members
7300 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7302 * driver.cs: handle the +/- options for -noconfig
7304 * statement.cs (Unckeched.Resolve): Also track the state of
7305 unchecked in the Resolve phase.
7307 2003-02-27 Martin Baulig <martin@ximian.com>
7309 * ecore.cs (Expression.MemberLookup): Don't create a
7310 MethodGroupExpr for something which is not a method. Fixes #38291.
7312 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7314 * class.cs (MemberBase.CheckParameters): Also check that the type
7315 is unmanaged if it is a pointer.
7317 * expression.cs (SizeOf.Resolve): Add location information.
7319 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7320 a managed type is declared.
7322 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7323 parameter modifiers as well. Fixes bug 38606
7325 * class.cs: Very sad. Am backing out the speed up changes
7326 introduced by the ArrayList -> Array in the TypeContainer, as they
7327 were not actually that much faster, and introduced a bug (no error
7328 reports on duplicated methods).
7330 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7331 source first, this will guarantee that we have a valid expression
7332 before calling in lower levels functions that will require a
7333 resolved object. Then use this original_source in the
7334 target.ResolveLValue instead of the original source that was
7337 Another change. Use target.Resolve instead of LValueResolve.
7338 Although we are resolving for LValues, we will let the Assign code
7339 take care of that (it will be called again from Resolve). This
7340 basically allows code like this:
7342 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7343 class Y { void A (X x) { x [0] += o; }
7345 The problem was that the indexer was trying to resolve for
7346 set_Item (idx, object o) and never finding one. The real set_Item
7347 was set_Item (idx, X). By delaying the process we get the right
7352 2003-02-23 Martin Baulig <martin@ximian.com>
7354 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7355 while calling DoEmit ().
7357 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7358 source files; if you use the #line directive inside a method, the
7359 compiler stops emitting line numbers for the debugger until it
7360 reaches the end of the method or another #line directive which
7361 restores the original file.
7363 2003-02-23 Martin Baulig <martin@ximian.com>
7365 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7367 2003-02-23 Martin Baulig <martin@ximian.com>
7369 * statement.cs (Block.AddChildVariableNames): We need to call this
7370 recursively, not just for our immediate children.
7372 2003-02-23 Martin Baulig <martin@ximian.com>
7374 * class.cs (Event.Define): Always make the field private, like csc does.
7376 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7377 actually work, fixes bug #37521.
7379 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7381 * delegate.cs: When creating the various temporary "Parameters"
7382 classes, make sure that we call the ComputeAndDefineParameterTypes
7383 on those new parameters (just like we do with the formal ones), to
7384 allow them to be resolved in the context of the DeclSpace.
7386 This fixes the bug that Dick observed in Bugzilla #38530.
7388 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7390 * expression.cs (ResolveMemberAccess): When resolving a constant,
7391 do not attempt to pull a constant if the value was not able to
7392 generate a valid constant.
7394 * const.cs (LookupConstantValue): Do not report more errors than required.
7396 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7398 * expression.cs: fixes bug #38328.
7400 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7402 * class.cs: Changed all the various members that can be part of a
7403 class from being an ArrayList to be an Array of the right type.
7404 During the DefineType type_list, interface_list, delegate_list and
7405 enum_list are turned into types, interfaces, delegates and enums
7408 And during the member population, indexer_list, event_list,
7409 constant_list, field_list, instance_constructor_list, method_list,
7410 operator_list and property_list are turned into their real arrays.
7412 Although we could probably perform this operation earlier, for
7413 good error reporting we need to keep the lists and remove the
7414 lists for longer than required.
7416 This optimization was triggered by Paolo profiling the compiler
7417 speed on the output of `gen-sample-program.pl' perl script.
7419 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7420 not crash in methods like MemberLookupFailed that use this field.
7422 This problem arises when the compiler fails to resolve a type
7423 during interface type definition for example.
7425 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7427 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7428 inherit from System.Object, so we have to stop at null, not only
7429 when reaching System.Object.
7431 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7433 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7434 DeclaredOnly because the parent indexer might have had a different
7435 name, but did not loop until the top of the hierarchy was reached.
7437 The problem this one fixes is 35492: when a class implemented an
7438 indexer from an interface, we were getting the interface method
7439 (which was abstract) and we were flagging an error (can not invoke
7442 This also keeps bug 33089 functioning, and test-148 functioning.
7444 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7445 out if a method is special is to see if it is declared in a
7446 property or event, or whether it is one of the predefined operator
7447 names. This should fix correctly #36804.
7449 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7451 The goal here is to remove the dependency on EmptyCast.Peel ().
7452 Killing it completely.
7454 The problem is that currently in a number of places where
7455 constants are expected, we have to "probe" for an EmptyCast, and
7456 Peel, which is not the correct thing to do, as this will be
7457 repetitive and will likely lead to errors.
7459 The idea is to remove any EmptyCasts that are used in casts that
7460 can be reduced to constants, so we only have to cope with
7463 This bug hunt was triggered by Bug 37363 and the desire to remove
7464 the duplicate pattern where we were "peeling" emptycasts to check
7465 whether they were constants. Now constants will always be
7468 * ecore.cs: Use an enumconstant here instead of wrapping with
7471 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7472 throwing me off. By handling this we can get rid of a few hacks.
7474 * statement.cs (Switch): Removed Peel() code.
7476 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7478 * class.cs: Location information for error 508
7480 * expression.cs (New.DoResolve): Add a guard against double
7481 resolution of an expression.
7483 The New DoResolve might be called twice when initializing field
7484 expressions (see EmitFieldInitializers, the call to
7485 GetInitializerExpression will perform a resolve on the expression,
7486 and later the assign will trigger another resolution
7488 This leads to bugs (#37014)
7490 * delegate.cs: The signature for EndInvoke should contain any ref
7491 or out parameters as well. We were not doing this in the past.
7493 * class.cs (Field.Define): Do not overwrite the type definition
7494 inside the `volatile' group. Turns out that volatile enumerations
7495 were changing the type here to perform a validity test, which
7498 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7500 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7501 and structs, we do not want to load the instance variable
7503 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7504 enum_type has to be handled like an object reference (implicit
7505 conversions exists from this to object), but the regular IsClass
7506 and IsValueType tests will never return true for this one.
7508 Also we use TypeManager.IsValueType instead of type.IsValueType,
7509 just for consistency with the rest of the code (this is only
7510 needed if we ever use the construct exposed by test-180.cs inside
7511 corlib, which we dont today).
7513 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7515 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7518 2003-02-09 Martin Baulig <martin@ximian.com>
7520 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7521 (Namespace.DefineNamespaces): New static public method; this is
7522 called when we're compiling with debugging to add all namespaces
7525 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7526 pass it to the Namespace's .ctor.
7528 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7529 and MethodBase arguments; pass the namespace ID to the symwriter;
7530 pass the MethodBase instead of the token to the symwriter.
7531 (SymbolWriter.DefineNamespace): New method to add a namespace to
7534 2003-02-09 Martin Baulig <martin@ximian.com>
7536 * symbolwriter.cs: New file. This is a wrapper around
7537 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7538 methods here in near future.
7540 2003-02-09 Martin Baulig <martin@ximian.com>
7542 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7543 ILGenerator.MarkSequencePoint() which are actually used by the
7546 2003-02-09 Martin Baulig <martin@ximian.com>
7548 * location.cs (SourceFile): New public sealed class. This
7549 contains the name and an index which is used in the location's token.
7550 (Location): Reserve an appropriate number of bits in the token for
7551 the source file instead of walking over that list, this gives us a
7552 really huge performance improvement when compiling with debugging.
7554 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7555 `SourceFile' argument instead of a string.
7556 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7557 but don't parse/tokenize here, we need to generate the list of all
7558 source files before we do that.
7559 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7562 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7563 instead of a string.
7565 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7568 2003-02-09 Martin Baulig <martin@ximian.com>
7570 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7571 filename on `#line default'.
7573 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7575 * statement.cs: don't clear the pinned var when the fixed statement
7576 returns from the method (fixes bug#37752).
7578 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7580 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7583 2003-02-07 Martin Baulig <martin@ximian.com>
7585 * driver.cs: Removed the `--debug-args' command line argument.
7587 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7588 automatically by the AsssemblyBuilder.
7589 (CodeGen.InitializeSymbolWriter): We don't need to call any
7590 initialization function on the symbol writer anymore. This method
7591 doesn't take any arguments.
7593 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7595 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7596 from referenced assemblies as well.
7598 2003-02-02 Martin Baulig <martin@ximian.com>
7600 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7602 2003-02-02 Martin Baulig <martin@ximian.com>
7604 * class.cs (Constructor.Emit): Open the symbol writer before
7605 emitting the constructor initializer.
7606 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7607 single-stepping through constructor initializers.
7609 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7611 * class.cs: Handle error 549: do not allow virtual methods in
7614 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7616 * decl.cs: Check access levels when resolving types
7618 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7620 * statement.cs: Add parameters and locals set in catch blocks that might
7621 return to set vector
7623 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7625 * class.cs (Operator): Set the SpecialName flags for operators.
7627 * expression.cs (Invocation.DoResolve): Only block calls to
7628 accessors and operators on SpecialName methods.
7630 (Cast.TryReduce): Handle conversions from char constants.
7633 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7635 * statement.cs: small memory and time optimization in FlowBranching.
7637 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7639 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7640 problem that the last fix but in the other sid (Set).
7642 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7643 access when there is no indexer in the hierarchy.
7645 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7647 * class.cs: Combine some if statements.
7649 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7651 * driver.cs: fixed bug #37187.
7653 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7655 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7656 any indexer, it's needed to build a list with all the indexers in the
7657 hierarchy (AllGetters), else we have problems. Fixes #35653.
7659 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7661 * class.cs (MethodData.Define): It is wrong for an interface
7662 implementation to be static in both cases: explicit and implicit.
7663 We were only handling this in one case.
7665 Improve the if situation there to not have negations.
7667 * class.cs (Field.Define): Turns out that we do not need to check
7668 the unsafe bit on field definition, only on usage. Remove the test.
7670 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7672 * driver.cs: use assembly.Location instead of Codebase (the latest
7673 patch made mcs fail when using MS assemblies).
7675 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7677 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7678 get the path to *corlib.dll.
7680 2003-01-21 Nick Drochak <ndrochak@gol.com>
7684 * typemanager.cs: Remove compiler warnings
7686 2003-01-20 Duncan Mak <duncan@ximian.com>
7688 * AssemblyInfo.cs: Bump the version number to 0.19.
7690 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7692 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7694 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7696 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7698 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7700 * cs-parser.jay: Small fix: we were not comparing the constructor
7701 name correctly. Thanks to Zoltan for the initial pointer.
7703 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7705 * cs-tokenizer.cs: Set file name when specified with #line
7707 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7709 * cs-parser.jay: Only perform the constructor checks here if we
7710 are named like the class; This will help provider a better
7711 error. The constructor path is taken when a type definition is
7712 not found, but most likely the user forgot to add the type, so
7713 report that rather than the constructor error.
7715 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7717 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7720 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7722 * cs-parser.jay: Add cleanup call.
7724 2003-01-13 Duncan Mak <duncan@ximian.com>
7726 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7727 consistent with other methods.
7729 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7731 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7733 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7735 * attribute.cs: only set GuidAttr to true when we have a
7738 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7742 * typemanager.cs: fixes to allow mcs compile corlib with the new
7743 Type.IsSubclassOf fix.
7745 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7747 * expression.cs (LocalVariableReference.DoResolve): Classify a
7748 constant as a value, not as a variable. Also, set the type for
7751 * cs-parser.jay (fixed_statement): take a type instead of a
7752 pointer_type, so we can produce a better error message later.
7754 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7757 (For.DoEmit): Make inifinite loops have a
7758 non-conditional branch back.
7760 (Fixed.DoEmit): First populate the pinned variables, then emit the
7761 statement, then clear the variables. Before I was emitting the
7762 code once for each fixed piece.
7765 2003-01-08 Martin Baulig <martin@ximian.com>
7767 * statement.cs (FlowBranching.MergeChild): A break in a
7768 SWITCH_SECTION does not leave a loop. Fixes #36155.
7770 2003-01-08 Martin Baulig <martin@ximian.com>
7772 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7773 lives in the same number space than `param_map'. Fixes #36154.
7775 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7777 * cs-parser.jay (constructor_declaration): Set the
7778 Constructor.ModFlags before probing for it. This makes the
7779 compiler report 514, 515 and 132 (the code was there, but got
7782 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7783 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7784 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7786 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7788 * enum.cs: create the enum static fields using the enum type.
7790 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7792 * class.cs: don't try to create the ParamBuilder for the return
7793 type if it's not needed (and handle it breaking for the ms runtime
7796 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7798 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7800 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7802 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7803 the command. This showed up while compiling the JANET source
7804 code, which used \r as its only newline separator.
7806 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7808 * class.cs (Method.Define): If we are an operator (because it
7809 reuses our code), then set the SpecialName and HideBySig. #36128
7811 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7813 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7814 exception, report error 120 `object reference required'.
7816 * driver.cs: Add --pause option, used during to measure the size
7817 of the process as it goes with --timestamp.
7819 * expression.cs (Invocation.DoResolve): Do not allow methods with
7820 SpecialName to be invoked.
7822 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7824 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7825 number before adding it.
7827 2002-12-21 Ravi Pratap <ravi@ximian.com>
7829 * ecore.cs (StandardImplicitConversion): When in an unsafe
7830 context, we allow conversion between void * to any other pointer
7831 type. This fixes bug #35973.
7833 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7835 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7836 is not thrown when extensionless outputs are used
7838 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7840 * rootcontext.cs: fixed compilation of corlib.
7842 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7844 * attribute.cs (Attributes.Contains): Add new method.
7846 * class.cs (MethodCore.LabelParameters): if the parameter is an
7847 `out' parameter, check that no attribute `[In]' has been passed.
7849 * enum.cs: Handle the `value__' name in an enumeration.
7851 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7853 * decl.cs: Added special case to allow overrides on "protected
7856 2002-12-18 Ravi Pratap <ravi@ximian.com>
7858 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7859 since it makes much more sense.
7861 (Attributes.ctor): Don't require a Location parameter.
7863 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7865 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7866 since we already have that information per attribute.
7868 * everywhere : make appropriate changes.
7870 * class.cs (LabelParameters): Write the code which actually
7871 applies attributes to the return type. We can't do this on the MS
7872 .NET runtime so we flag a warning in the case an exception is
7875 2002-12-18 Miguel de Icaza <miguel@ximian.com>
7877 * const.cs: Handle implicit null conversions here too.
7879 2002-12-17 Ravi Pratap <ravi@ximian.com>
7881 * class.cs (MethodCore.LabelParameters): Remove the extra
7882 Type [] parameter since it is completely unnecessary. Instead
7883 pass in the method's attributes so that we can extract
7884 the "return" attribute.
7886 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7888 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7889 of ignoring it and letting the compile continue.
7891 * typemanager.cs (ChangeType): use an extra argument to return an
7892 error condition instead of throwing an exception.
7894 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7896 * expression.cs (Unary.TryReduce): mimic the code for the regular
7897 code path. Perform an implicit cast in the cases where we can
7898 implicitly convert to one of the integral types, and then reduce
7899 based on that constant. This fixes bug #35483.
7901 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7903 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7905 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7907 * namespace.cs: fixed bug #35489.
7909 2002-12-12 Miguel de Icaza <miguel@ximian.com>
7911 * class.cs: Remove some dead code.
7913 * cs-parser.jay: Estimate the number of methods needed
7914 (RootContext.MethodCount);
7916 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
7917 numbers instead of StringBuilders.
7919 * support.cs (PtrHashtable): Add constructor with initial size;
7920 We can now reduce reallocations of the method table.
7922 2002-12-10 Ravi Pratap <ravi@ximian.com>
7924 * attribute.cs (ApplyAttributes): Keep track of the emitted
7925 attributes on a per-target basis. This fixes bug #35413.
7927 2002-12-10 Miguel de Icaza <miguel@ximian.com>
7929 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
7930 default to the Windows 1252 encoding.
7932 (UnixParseOption): Support version, thanks to Alp for the missing
7935 * AssemblyInfo.cs: Add nice assembly information.
7937 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
7940 * cs-parser.jay: Allow a trailing comma before the close bracked
7941 in the attribute_section production.
7943 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
7944 address of the instance was being taken, I will take this out,
7945 because we take the address of the object immediately here.
7947 2002-12-09 Ravi Pratap <ravi@ximian.com>
7949 * typemanager.cs (AreMultipleAllowed): Take care of the most
7950 obvious case where attribute type is not in the current assembly -
7953 2002-12-08 Miguel de Icaza <miguel@ximian.com>
7955 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
7956 definitions, instead of doing that afterwards.
7958 Also we use a nice little hack, depending on the constructor, we
7959 know if we are a "composed" name or a simple name. Hence, we
7960 avoid the IndexOf test, and we avoid
7962 * codegen.cs: Add code to assist in a bug reporter to track down
7963 the source of a compiler crash.
7965 2002-12-07 Ravi Pratap <ravi@ximian.com>
7967 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
7968 types have been emitted for a given element and flag an error
7969 if something which does not have AllowMultiple set is used more
7972 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
7973 attribute types and their corresponding AllowMultiple properties
7975 (AreMultipleAllowed): Check the property for a given type.
7977 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
7978 property in the case we have a TypeContainer.
7980 (Attributes.AddAttribute): Detect duplicates and just skip on
7981 adding them. This trivial fix catches a pretty gross error in our
7982 attribute emission - global attributes were being emitted twice!
7984 Bugzilla bug #33187 is now fixed.
7986 2002-12-06 Miguel de Icaza <miguel@ximian.com>
7988 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
7991 * expression.cs (Binary.ResolveOperator): I can only use the
7992 Concat (string, string, string) and Concat (string, string,
7993 string, string) if the child is actually a concatenation of
7996 2002-12-04 Miguel de Icaza <miguel@ximian.com>
7998 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
7999 context where we need a 2-character lookahead.
8001 * pending.cs (PendingImplementation): Rework so we can keep track
8002 of interface types all the time, and flag those which were
8003 implemented by parents as optional.
8005 2002-12-03 Miguel de Icaza <miguel@ximian.com>
8007 * expression.cs (Binary.ResolveOperator): Use
8008 String.Concat(string,string,string) or
8009 String.Concat(string,string,string,string) when possible.
8011 * typemanager: More helper methods.
8014 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
8016 * pending.cs: remove the bogus return from GetMissingInterfaces()
8017 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
8019 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8021 * namespace.cs: avoid duplicated 'using xxx' being added to
8022 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
8023 when we get more than one 'using' statement for the same namespace.
8024 Report a CS0105 warning for it.
8026 2002-11-30 Miguel de Icaza <miguel@ximian.com>
8028 * cs-tokenizer.cs (consume_identifier): use read directly, instead
8029 of calling getChar/putback, uses internal knowledge of it.
8031 (xtoken): Reorder tokenizer so most common patterns are checked
8032 first. This reduces the compilation time in another 5% (from 8.11s
8033 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
8035 The parsing time is 22% of the compilation in mcs, and from that
8036 64% is spent on the tokenization process.
8038 I tried using a binary search for keywords, but this is slower
8039 than the hashtable. Another option would be to do a couple of
8042 * Not use a StringBuilder, instead use an array of chars,
8043 with a set value. Notice that this way we could catch
8044 the 645 error without having to do it *afterwards*.
8046 * We could write a hand-parser to avoid the hashtable
8047 compares altogether.
8049 The identifier consumption process takes 37% of the tokenization
8050 time. Another 15% is spent on is_number. 56% of the time spent
8051 on is_number is spent on Int64.Parse:
8053 * We could probably choose based on the string length to
8054 use Int32.Parse or Int64.Parse and avoid all the 64-bit
8057 Another 3% is spend on wrapping `xtoken' in the `token' function.
8059 Handle 0xa0 as whitespace (#34752)
8061 2002-11-26 Miguel de Icaza <miguel@ximian.com>
8063 * typemanager.cs (IsCLRType): New routine to tell whether a type
8064 is one of the builtin types.
8066 Maybe it needs to use TypeCodes to be faster. Maybe we could use
8067 typecode in more places instead of doing pointer comparissions.
8068 We could leverage some knowledge about the way the typecodes are
8071 New code to cache namespaces in assemblies, it is currently not
8072 invoked, to be used soon.
8074 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
8076 * expression.cs (Binary.ResolveOperator): specially handle
8077 strings, and do not perform user-defined operator overloading for
8080 2002-11-24 Miguel de Icaza <miguel@ximian.com>
8082 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
8083 internalcall as it is a pretty simple operation; Avoid whenever
8084 possible to call Char.IsLetter.
8086 (consume_identifier): Cut by half the number of
8087 hashtable calls by merging the is_keyword and GetKeyword behavior.
8089 Do not short-circuit, because if we do, we
8090 report errors (ie, #if false && true would produce an invalid
8094 2002-11-24 Martin Baulig <martin@ximian.com>
8096 * expression.cs (Cast.TryReduce): If we're in checked syntax,
8097 check constant ranges and report a CS0221. Fixes #33186.
8099 2002-11-24 Martin Baulig <martin@ximian.com>
8101 * cs-parser.jay: Make this work for uninitialized variable
8102 declarations in the `for' initializer. Fixes #32416.
8104 2002-11-24 Martin Baulig <martin@ximian.com>
8106 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
8107 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
8109 2002-11-24 Martin Baulig <martin@ximian.com>
8111 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
8112 argument; if true, we also check for user-defined conversions.
8113 This is only needed if both arguments are of a user-defined type.
8114 Fixes #30443, added test-175.cs.
8115 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
8117 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
8119 2002-11-24 Martin Baulig <martin@ximian.com>
8121 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8122 function to get the store opcode.
8123 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8124 only emit the Ldelema if the store opcode is Stobj. You must run
8125 both test-34 and test-167 to test this. Fixes #34529.
8127 2002-11-23 Martin Baulig <martin@ximian.com>
8129 * ecore.cs (Expression.MemberLookup): Added additional
8130 `qualifier_type' argument which is used when we're being called
8131 from MemberAccess.DoResolve() and null if we're called from a
8133 (Expression.MemberLookupFailed): New method to report errors; this
8134 does the CS1540 check and reports the correct error message.
8136 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8137 argument for the CS1540 check and redone the way how we're dealing
8138 with private members. See the comment in the source code for details.
8139 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8140 `closure_start_type' to `closure_qualifier_type' and check whether
8141 it's not null. It was not this filter being broken, it was just
8142 being called with the wrong arguments.
8144 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8145 and pass it the correct `qualifier_type'; this also does the error
8148 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8150 * expression.cs (Invocation.EmitParams): If the we are dealing
8151 with a non-built-in value type, load its address as well.
8153 (ArrayCreation): Use a a pretty constant instead
8154 of the hardcoded value 2. Use 6 instead of 2 for the number of
8155 static initializers.
8157 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8158 because they are not really value types, just glorified integers.
8160 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8162 * ecore.cs: Remove redundant code for enumerations, make them use
8163 the same code path as everything else, fixes the casting issue
8164 with enumerations in Windows.Forms.
8166 * attribute.cs: Do only cast to string if it is a string, the
8167 validation happens later.
8169 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8170 people upgrade their corlibs.
8172 * ecore.cs: Oops, enumerations were not following the entire code path
8174 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8176 * typemanager.cs (FilterWithClosure): Commented out the test for
8177 1540 in typemanager.cs, as it has problems when accessing
8178 protected methods from a parent class (see test-174.cs).
8180 * attribute.cs (Attribute.ValidateGuid): new method.
8181 (Attribute.Resolve): Use above.
8183 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8185 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8187 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8188 handling for enumerations, as we only needed the TypeContainer
8189 functionality to begin with (this is required for the fix below to
8190 work for enums that reference constants in a container class for
8193 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8195 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8196 a valid TypeBuilder to perform lookups on.o
8198 * class.cs (InheritableMemberSignatureCompare): Use true in the
8199 call to GetGetMethod and GetSetMethod, because we are comparing
8200 the signature, and we need to get the methods *even* if they are
8203 (PropertyBase.CheckBase): ditto.
8205 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8206 GotoCase.Resolve): Use Peel on EmpytCasts.
8208 * ecore.cs (EmptyCast): drop child, add Peel method.
8210 2002-11-17 Martin Baulig <martin@ximian.com>
8212 * ecore.cs (EmptyCast.Child): New public property.
8214 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8215 label resolved to an EmptyCast. Fixes #34162.
8216 (GotoCase.Resolve): Likewise.
8217 (Block.EmitMeta): Likewise.
8219 2002-11-17 Martin Baulig <martin@ximian.com>
8221 * expression.cs (Invocation.BetterConversion): Prefer int over
8222 uint; short over ushort; long over ulong for integer literals.
8223 Use ImplicitConversionExists instead of StandardConversionExists
8224 since we also need to check for user-defined implicit conversions.
8225 Fixes #34165. Added test-173.cs.
8227 2002-11-16 Martin Baulig <martin@ximian.com>
8229 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8230 with the `true' and `false' literals. Fixes #33151.
8232 2002-11-16 Martin Baulig <martin@ximian.com>
8234 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8235 October 22nd; don't do the cs1540 check for static members.
8237 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8238 now using our own filter here and doing the cs1540 check again.
8240 2002-11-16 Martin Baulig <martin@ximian.com>
8242 * support.cs (InternalParameters): Don't crash if we don't have
8243 any fixed parameters. Fixes #33532.
8245 2002-11-16 Martin Baulig <martin@ximian.com>
8247 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8248 when looking up static methods to make this work on Windows.
8251 2002-11-16 Martin Baulig <martin@ximian.com>
8253 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8254 a setter rather than using PropertyInfo.CanWrite.
8256 2002-11-15 Nick Drochak <ndrochak@gol.com>
8258 * class.cs: Allow acces to block member by subclasses. Fixes build
8261 2002-11-14 Martin Baulig <martin@ximian.com>
8263 * class.cs (Constructor.Emit): Added the extern/block check.
8266 2002-11-14 Martin Baulig <martin@ximian.com>
8268 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8269 iteration while looking for indexers, this is needed because the
8270 indexer may have a different name in our base classes. Fixed the
8271 error reporting (no indexers at all, not get accessor, no
8272 overloaded match). Fixes bug #33089.
8273 (IndexerAccess.DoResolveLValue): Likewise.
8275 2002-11-14 Martin Baulig <martin@ximian.com>
8277 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8278 indexers. Fixes the first part of bug #33089.
8279 (MethodSignature.InheritableMemberSignatureCompare): Added support
8282 2002-11-13 Ravi Pratap <ravi@ximian.com>
8284 * attribute.cs (Attribute.Resolve): Catch the
8285 NullReferenceException and report it since it isn't supposed to
8288 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8290 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8291 LogicalOr and LogicalAnd that can benefit from recursively
8292 handling EmitBranchable. The code now should be nice for Paolo.
8294 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8296 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8297 the Type lookups, as we perform quite a number of lookups on
8298 non-Types. This can be removed once we can deterministically tell
8299 whether we have a type or a namespace in advance.
8301 But this might require special hacks from our corlib.
8305 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8306 and double which avoids a conversion from an integer to a double.
8308 * expression.cs: tiny optimization, avoid calling IsConstant,
8309 because it effectively performs the lookup twice.
8311 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8313 But a bogus return here to keep the semantics of the old code
8314 until the Mono runtime is fixed.
8316 * pending.cs (GetMissingInterfaces): New method used to remove all
8317 the interfaces that are already implemented by our parent
8318 classes from the list of pending methods.
8320 * interface.cs: Add checks for calls after ResolveTypeExpr.
8322 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8324 * class.cs (Class.Emit): Report warning 67: event not used if the
8325 warning level is beyond 3.
8327 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8328 being a NullLiteral.
8330 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8333 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8334 path that might fail if a type can not be resolved.
8336 * expression.cs (Binary.Emit): Emit unsigned versions of the
8339 * driver.cs: use error 5.
8341 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8343 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8345 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8347 * cs-parser.jay (switch_section): A beautiful patch from Martin
8348 Baulig that fixed 33094.
8350 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8352 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8353 Check whether the base is abstract and report an error if so.
8355 * expression.cs (IndexerAccess.DoResolveLValue,
8356 IndexerAccess.DoResolve): ditto.
8358 (Invocation.DoResolve): ditto.
8360 (Invocation.FullMethodDesc): Improve the report string.
8362 * statement.cs (Block): Eliminate IsVariableDefined as it is
8363 basically just a wrapper for GetVariableInfo.
8365 * ecore.cs (SimpleName): Use new
8367 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8368 type, as we return the actual parameter ref/unref state on a
8371 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8373 * support.cs: Return proper flags REF/OUT fixing the previous
8376 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8377 not used to mean `ref' but `ref or out' in ParameterReference
8379 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8380 full type signature instead of calling TypeManger.CSharpName
8383 * support.cs (InternalParameters.ParameterDesc): Do not compare
8384 directly to the modflags, because REF/OUT will actually be bitsets
8387 * delegate.cs (VerifyMethod): Check also the modifiers.
8389 * cs-tokenizer.cs: Fix bug where floating point values with an
8390 exponent where a sign was missing was ignored.
8392 * driver.cs: Allow multiple assemblies to be specified in a single
8395 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8397 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8398 because identifiers after a parenthesis would end up in this kind
8399 of production, and we needed to desamiguate it for having casts
8402 (UserDefinedType *) xxx
8404 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8406 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8407 we should set on the Bindingflags.NonPublic, but not turn on
8408 private_ok. private_ok controls whether a Private member is
8409 returned (this is chekced on the filter routine), while the
8410 BindingFlags.NonPublic just controls whether private/protected
8411 will be allowed. This fixes the problem part of the problem of
8412 private properties being allowed to be used in derived classes.
8414 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8415 so we can call the children DoResolveLValue method (this will
8416 properly signal errors on lvalue assignments to base properties)
8418 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8419 getter are null, and we have a property info, we know that this
8420 happened because the lookup failed, so we report an error 122 for
8421 protection level violation.
8423 We also silently return if setter and getter are null in the
8424 resolve functions, this condition only happens if we have flagged
8425 the error before. This is the other half of the problem.
8427 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8428 not have accessibility information, that is why we were returning
8429 true in the filter function in typemanager.cs.
8431 To properly report 122 (property is inaccessible because of its
8432 protection level) correctly, we report this error in ResolveAccess
8433 by failing if both the setter and the getter are lacking (ie, the
8436 DoResolve and DoLResolve have been modified to check for both
8437 setter/getter being null and returning silently, the reason being
8438 that I did not want to put the knowledge about this error in upper
8441 int old = Report.Errors;
8442 x = new PropertyExpr (...);
8443 if (old != Report.Errors)
8448 So the property expr is returned, but it is invalid, so the error
8449 will be flagged during the resolve process.
8451 * class.cs: Remove InheritablePropertySignatureCompare from the
8452 class, as we no longer depend on the property signature to compute
8453 whether it is possible to implement a method or not.
8455 The reason is that calling PropertyInfo.GetGetMethod will return
8456 null (in .NET, in Mono it works, and we should change this), in
8457 cases where the Get Method does not exist in that particular
8462 class X { public virtual int A { get { return 1; } } }
8464 class Z : Y { public override int A { get { return 2; } } }
8466 Would fail in Z because the parent (Y) would not have the property
8467 defined. So we avoid this completely now (because the alternative
8468 fix was ugly and slow), and we now depend exclusively on the
8471 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8472 reference method, instead of using the property.
8474 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8475 routines are gone now.
8477 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8478 names, they were incorrectly named.
8480 * cs-tokenizer.cs: Return are more gentle token on failure.
8482 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8483 had an out-of-sync index variable, which caused it to remove from
8484 the list of pending methods the wrong method sometimes.
8486 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8488 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8489 CanWrite, because those refer to this particular instance of the
8490 property, and do not take into account the fact that we can
8491 override single members of a property.
8493 Constructor requires an EmitContext. The resolution process does
8494 not happen here, but we need to compute the accessors before,
8495 because the resolution does not always happen for properties.
8497 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8498 subclass, before we did not update this flag, but we did update
8501 (GetAccessors): Drop this routine, as it did not work in the
8502 presence of partially overwritten set/get methods.
8504 Notice that this broke the cs1540 detection, but that will require
8507 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8511 * driver.cs: issue a warning instead of an error if we don't support
8512 debugging for the platform. Also ignore a couple of errors that may
8513 arise when trying to write the symbols. Undo my previous patch.
8515 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8517 * driver.cs: ignore /debug switch except for Unix platforms.
8519 2002-10-23 Nick Drochak <ndrochak@gol.com>
8521 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8523 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8525 * driver.cs: Do not make mcs-debug conditional, so we do not break
8528 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8529 review this patch. But basically after all the children variables
8530 have been merged, the value of "Breaks" was not being set to
8531 new_breaks for Switch blocks. I think that it should be set after
8532 it has executed. Currently I set this to the value of new_breaks,
8533 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8534 conservative, but I do not understand this code very well.
8536 I did not break anything in the build, so that is good ;-)
8538 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8540 2002-10-20 Mark Crichton <crichton@gimp.org>
8542 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8544 2002-10-20 Nick Drochak <ndrochak@gol.com>
8546 * cfold.cs: Fixed compile blocker.
8548 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8550 * driver.cs: I was chekcing the key, not the file.
8552 2002-10-19 Ravi Pratap <ravi@ximian.com>
8554 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8555 message that we were generating - we just need to silently return
8558 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8560 * class.cs (Event.Define): Change my previous commit, as this
8561 breaks the debugger. This is a temporary hack, as it seems like
8562 the compiler is generating events incorrectly to begin with.
8564 * expression.cs (Binary.ResolveOperator): Added support for
8565 "U operator - (E x, E y)"
8567 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8570 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8571 init-only variables, but this path did not take into account that
8572 there might be also instance readonly variables. Correct this
8575 This fixes bug 32253
8577 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8580 * driver.cs: Change the extension for modules to `netmodule'
8582 * cs-parser.jay: Improved slightly the location tracking for
8583 the debugger symbols.
8585 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8586 modifiers that were specified instead of the hardcoded value
8587 (FamAndAssem). This was basically ignoring the static modifier,
8588 and others. Fixes 32429.
8590 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8591 fixed a bug in the process (32476)
8593 * expression.cs (ArrayAccess.EmitAssign): Patch from
8594 hwang_rob@yahoo.ca that fixes bug 31834.3
8596 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8598 * driver.cs: Make the module extension .netmodule.
8600 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8602 * driver.cs: Report an error if the resource file is not found
8603 instead of crashing.
8605 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8606 false, like Emit does.
8608 2002-10-16 Nick Drochak <ndrochak@gol.com>
8610 * typemanager.cs: Remove unused private member. Also reported mcs
8611 bug to report this as a warning like csc.
8613 2002-10-15 Martin Baulig <martin@gnome.org>
8615 * statement.cs (Statement.Emit): Made this a virtual method; emits
8616 the line number info and calls DoEmit().
8617 (Statement.DoEmit): New protected abstract method, formerly knows
8618 as Statement.Emit().
8620 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8622 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8624 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8625 have fixed a remaining problem: not every AddXXXX was adding a
8626 fully qualified name.
8628 Now everyone registers a fully qualified name in the DeclSpace as
8629 being defined instead of the partial name.
8631 Downsides: we are slower than we need to be due to the excess
8632 copies and the names being registered this way.
8634 The reason for this is that we currently depend (on the corlib
8635 bootstrap for instance) that types are fully qualified, because
8636 we dump all the types in the namespace, and we should really have
8637 types inserted into the proper namespace, so we can only store the
8638 basenames in the defined_names array.
8640 2002-10-10 Martin Baulig <martin@gnome.org>
8642 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8643 from bug #31834, see the bug report for a testcase which is
8646 2002-10-10 Martin Baulig <martin@gnome.org>
8648 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8649 flow analysis code for this.
8651 * statement.cs (Do, While, For): Tell the flow analysis code about
8653 (FlowBranching.UsageVector): Added support for infinite loops.
8654 (Block.Resolve): Moved the dead code elimination here and use flow
8657 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8659 * class.cs (Field.Define): Catch cycles on struct type
8662 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8663 fields if the fields are static. We only need to check instance
8666 * expression.cs (As.DoResolve): Test for reference type.
8668 * statement.cs (Using.ResolveExpression): Use
8669 ConvertImplicitRequired, not ConvertImplicit which reports an
8671 (Using.ResolveLocalVariableDecls): ditto.
8673 * expression.cs (Binary.ResolveOperator): Report errors in a few
8674 places where we had to.
8676 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8678 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8680 * expression.cs: Use StoreFromPtr instead of extracting the type
8681 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8683 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8684 an enumeration value to a System.Enum, but System.Enum is not a
8685 value type, but an class type, so we need to box.
8687 (Expression.ConvertExplicit): One codepath could return
8688 errors but not flag them. Fix this. Fixes #31853
8690 * parameter.cs (Resolve): Do not allow void as a parameter type.
8692 2002-10-06 Martin Baulig <martin@gnome.org>
8694 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8695 if it's a class type and not a struct. Fixes #31815.
8697 2002-10-06 Martin Baulig <martin@gnome.org>
8699 * statement.cs: Reworked the flow analysis code a bit to make it
8700 usable for dead code elimination.
8702 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8704 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8706 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8708 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8709 to fix the test 165, will investigate deeper.
8711 2002-10-04 Martin Baulig <martin@gnome.org>
8713 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8714 finally blocks actually work.
8715 (Try.Resolve): We don't need to create a sibling for `finally' if
8716 there is no finally block.
8718 2002-10-04 Martin Baulig <martin@gnome.org>
8720 * class.cs (Constructor.Define): The default accessibility for a
8721 non-default constructor is private, not public.
8723 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8725 * class.cs (Constructor): Make AllowedModifiers public, add
8728 * cs-parser.jay: Perform the modifiers test here, as the
8729 constructor for the Constructor class usually receives a zero
8730 because of the way we create it (first we create, later we
8731 customize, and we were never checking the modifiers).
8733 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8734 is a version of LookupTypeReflection that includes the type-name
8735 cache. This can be used as a fast path for functions that know
8736 the fully qualified name and are only calling into *.GetType() to
8737 obtain a composed type.
8739 This is also used by TypeManager.LookupType during its type
8742 (LookupType): We now also track the real type name, as sometimes
8743 we can get a quey for the real type name from things like
8744 ComposedCast. This fixes bug 31422.
8746 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8747 complete type fullname, it does not have to go through the type
8748 resolution system to obtain the composed version of the type (for
8749 obtaining arrays or pointers).
8751 (Conditional.Emit): Use the EmitBoolExpression to
8752 generate nicer code, as requested by Paolo.
8754 (ArrayCreation.CheckIndices): Use the patch from
8755 hwang_rob@yahoo.ca to validate the array initializers.
8757 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8759 * class.cs (ConstructorInitializer.Emit): simplify code by using
8760 Invocation.EmitCall, and at the same time, fix the bugs in calling
8761 parent constructors that took variable arguments.
8763 * ecore.cs (Expression.ConvertNumericExplicit,
8764 Expression.ImplicitNumericConversion): Remove the code that
8765 manually wrapped decimal (InternalTypeConstructor call is now gone
8768 * expression.cs (Cast.TryReduce): Also handle decimal types when
8769 trying to perform a constant fold on the type.
8771 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8773 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8774 that only turned off an error report, and did nothing else.
8776 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8778 * driver.cs: Handle and ignore /fullpaths
8780 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8782 * expression.cs (Binary.ResolveOperator): Catch the case where
8783 DoNumericPromotions returns true,
8785 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8787 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8789 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8792 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8794 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8795 conversion exists, but it is also required that the conversion be
8796 performed. This manifested in "(Type64Enum) 2".
8798 * class.cs (TypeManager.AddMethod): The fix is not to change
8799 AddEnum, because that one was using a fully qualified name (every
8800 DeclSpace derivative does), but to change the AddMethod routine
8801 that was using an un-namespaced name. This now correctly reports
8802 the duplicated name.
8804 Revert patch until I can properly fix it. The issue
8805 is that we have a shared Type space across all namespaces
8806 currently, which is wrong.
8808 Options include making the Namespace a DeclSpace, and merge
8809 current_namespace/current_container in the parser.
8811 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8813 * cs-parser.jay: Improve error reporting when we get a different
8814 kind of expression in local_variable_type and
8815 local_variable_pointer_type.
8817 Propagate this to avoid missleading errors being reported.
8819 * ecore.cs (ImplicitReferenceConversion): treat
8820 TypeManager.value_type as a target just like object_type. As
8825 Is valid, and needs to result in the int 1 being boxed before it
8826 is assigned to the value type v.
8828 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8829 to validate the enumeration name.
8831 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8832 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8833 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8835 * ecore.cs (TryImplicitIntConversion): When doing an
8836 implicit-enumeration-conversion, check if the type is 64-bits and
8837 perform a conversion before passing to EnumConstant.
8839 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8841 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8842 report ambiguous type references. Unlike the MS version, we
8843 report what the ambiguity is. Innovation at work ;-)
8845 (DeclSpace.FindType): Require a location argument to
8846 display when we display an ambiguous error.
8848 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8850 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8852 * expression.cs (EmitDynamicInitializers): Apply patch from
8853 hwang_rob@yahoo.ca that fixes the order in which we emit our
8856 2002-09-21 Martin Baulig <martin@gnome.org>
8858 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8859 delegate takes no arguments.
8861 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8863 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8866 * expression.cs: Extract the underlying type.
8868 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
8870 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
8872 2002-09-19 Miguel de Icaza <miguel@ximian.com>
8874 * class.cs (TypeContainer.DefineType): We can not use the nice
8875 PackingSize with the size set to 1 DefineType method, because it
8876 will not allow us to define the interfaces that the struct
8879 This completes the fixing of bug 27287
8881 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
8882 means also structs. This fixes part of the problem.
8883 (Expresion.ImplicitReferenceConversionExists): ditto.
8885 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8886 error if there were no errors reported during the type lookup
8887 process, to avoid duplicates or redundant errors. Without this
8888 you would get an ambiguous errors plus a type not found. We have
8889 beaten the user enough with the first error.
8891 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8894 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8895 during the resolution process, stop the lookup, this avoids
8896 repeated error reports (same error twice).
8898 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8900 * typemanager.cs (LookupType): Redo the type lookup code to match
8901 the needs of System.Reflection.
8903 The issue is that System.Reflection requires references to nested
8904 types to begin with a "+" sign instead of a dot. So toplevel
8905 types look like: "NameSpace.TopLevelClass", and nested ones look
8906 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
8909 2002-09-19 Martin Baulig <martin@gnome.org>
8911 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
8912 says that a method always returns or always throws an exception,
8913 don't report the CS0161.
8915 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
8916 set `Returns = new_returns'.
8918 2002-09-19 Martin Baulig <martin@gnome.org>
8920 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
8921 to an enum constant, check for a CS0176.
8923 2002-09-18 Miguel de Icaza <miguel@ximian.com>
8925 * class.cs (TypeContainer.CheckPairedOperators): Now we check
8926 for operators that must be in pairs and report errors.
8928 * ecore.cs (SimpleName.DoResolveType): During the initial type
8929 resolution process, when we define types recursively, we must
8930 check first for types in our current scope before we perform
8931 lookups in the enclosing scopes.
8933 * expression.cs (MakeByteBlob): Handle Decimal blobs.
8935 (Invocation.VerifyArgumentsCompat): Call
8936 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
8937 I thought we were supposed to always call this, but there are a
8938 few places in the code where we dont do it.
8940 2002-09-17 Miguel de Icaza <miguel@ximian.com>
8942 * driver.cs: Add support in -linkres and -resource to specify the
8943 name of the identifier.
8945 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8947 * ecore.cs (StandardConversionExists): Sync with the conversion
8948 code: allow anything-* to void* conversions.
8950 (FindMostSpecificSource): Use an Expression argument
8951 instead of a Type, because we might be handed over a Literal which
8952 gets a few more implicit conversions that plain types do not. So
8953 this information was being lost.
8955 Also, we drop the temporary type-holder expression when not
8958 2002-09-17 Martin Baulig <martin@gnome.org>
8960 * class.cs (PropertyBase.CheckBase): Don't check the base class if
8961 this is an explicit interface implementation.
8963 2002-09-17 Martin Baulig <martin@gnome.org>
8965 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
8966 different `IndexerName' attributes.
8968 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
8969 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
8970 virtual CommonResolve().
8972 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8974 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
8975 and convert that to the UnderlyingType.
8977 * statement.cs (Foreach.Resolve): Indexers are just like variables
8978 or PropertyAccesses.
8980 * cs-tokenizer.cs (consume_string): Track line numbers and columns
8981 inside quoted strings, we were not doing this before.
8983 2002-09-16 Martin Baulig <martin@gnome.org>
8985 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
8986 resolve it. This is needed for the definite assignment check of the
8987 instance expression, fixes bug #29846.
8988 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
8990 2002-09-16 Nick Drochak <ndrochak@gol.com>
8992 * parameter.cs: Fix compile error. Cannot reference static member
8993 from an instance object. Is this an mcs bug?
8995 2002-09-14 Martin Baulig <martin@gnome.org>
8997 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
8998 multiple times. Fixes bug #30295, added test-166.cs.
9000 2002-09-14 Martin Baulig <martin@gnome.org>
9002 * statement.cs (Block.Emit): Don't emit unreachable code.
9003 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
9005 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
9007 2002-09-14 Martin Baulig <martin@gnome.org>
9009 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
9012 2002-09-14 Martin Baulig <martin@gnome.org>
9014 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
9015 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
9016 be false on the ms runtime.
9018 2002-09-13 Martin Baulig <martin@gnome.org>
9020 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
9021 the CS0038 error message.
9023 2002-09-12 Miguel de Icaza <miguel@ximian.com>
9025 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
9026 constant inside, return it.
9028 2002-09-12 Martin Baulig <martin@gnome.org>
9030 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
9031 implicit conversion can be done between enum types.
9033 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
9034 check whether an implicit conversion to the current enum's UnderlyingType
9035 exists and report an error if not.
9037 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
9038 without debugging support.
9040 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
9041 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
9043 2002-09-12 Martin Baulig <martin@gnome.org>
9045 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
9047 * ecore.cs (IMemberExpr.DeclaringType): New property.
9048 (SimpleName.SimpleNameResolve): Check whether we're accessing a
9049 nonstatic member of an outer type (CS0038).
9051 2002-09-11 Miguel de Icaza <miguel@ximian.com>
9053 * driver.cs: Activate the using-error detector at warning level
9054 4 (at least for MS-compatible APIs).
9056 * namespace.cs (VerifyUsing): Small buglett fix.
9058 * pending.cs (PendingImplementation): pass the container pointer.
9060 * interface.cs (GetMethods): Allow for recursive definition. Long
9061 term, I would like to move every type to support recursive
9062 definitions, not the current ordering mechanism that we have right
9065 The situation is this: Attributes are handled before interfaces,
9066 so we can apply attributes to interfaces. But some attributes
9067 implement interfaces, we will now handle the simple cases
9068 (recursive definitions will just get an error).
9070 * parameter.cs: Only invalidate types at the end if we fail to
9073 2002-09-09 Martin Baulig <martin@gnome.org>
9075 * ecore.cs (PropertyExpr.Emit): Also check for
9076 TypeManager.system_int_array_get_length so this'll also work when
9077 compiling corlib. Fixes #30003.
9079 2002-09-09 Martin Baulig <martin@gnome.org>
9081 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
9082 and throw an exception if we can't get the type's size. Fixed #30040,
9085 2002-09-09 Martin Baulig <martin@gnome.org>
9087 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
9089 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
9090 context. Fixes bug #30027.
9092 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
9093 virtual functions. Fixes bug #30043, added test-164.cs.
9095 2002-09-08 Ravi Pratap <ravi@ximian.com>
9097 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
9099 2002-09-08 Nick Drochak <ndrochak@gol.com>
9101 * driver.cs: Use an object to get the windows codepage since it's not a
9104 2002-09-08 Miguel de Icaza <miguel@ximian.com>
9106 * statement.cs (For.Emit): for infinite loops (test == null)
9107 return whether there is a break inside, not always "true".
9109 * namespace.cs (UsingEntry): New struct to hold the name of the
9110 using definition, the location where it is defined, and whether it
9111 has been used in a successful type lookup.
9113 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
9118 2002-09-06 Ravi Pratap <ravi@ximian.com>
9120 * attribute.cs : Fix incorrect code which relied on catching
9121 a NullReferenceException to detect a null being passed in
9122 where an object was expected.
9124 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9126 * statement.cs (Try): flag the catch variable as assigned
9128 * expression.cs (Cast): Simplified by using ResolveType instead of
9131 * statement.cs (Catch): Fix bug by using ResolveType.
9133 2002-09-06 Ravi Pratap <ravi@ximian.com>
9135 * expression.cs (BetterConversion): Special case for when we have
9136 a NullLiteral as the argument and we have to choose between string
9137 and object types - we choose string the way csc does.
9139 * attribute.cs (Attribute.Resolve): Catch the
9140 NullReferenceException and report error #182 since the Mono
9141 runtime no more has the bug and having this exception raised means
9142 we tried to select a constructor which takes an object and is
9145 2002-09-05 Ravi Pratap <ravi@ximian.com>
9147 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9148 message (1502, 1503) when we can't locate a method after overload
9149 resolution. This is much more informative and closes the bug
9152 * interface.cs (PopulateMethod): Return if there are no argument
9153 types. Fixes a NullReferenceException bug.
9155 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9156 expressions too. Previously we were checking only in one place for
9157 positional arguments leaving out named arguments.
9159 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9160 type to the enum type is not allowed. Remove code corresponding to
9163 (ConvertNumericExplicit): Allow explicit conversions from
9164 the underlying type to enum type. This precisely follows the spec
9165 and closes a bug filed by Gonzalo.
9167 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9170 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9172 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9174 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9175 it was important that we stored the right value after the
9176 reduction in `converted'.
9178 2002-09-04 Martin Baulig <martin@gnome.org>
9180 * location.cs (Location.SymbolDocument): Use full pathnames for the
9183 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9185 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9186 of the expression resolve mechanism, because that will catch the
9187 SimpleName error failures.
9189 (Conditional): If we can not resolve the
9190 expression, return, do not crash.
9192 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9195 (location): display token name instead of its number.
9197 2002-08-28 Martin Baulig <martin@gnome.org>
9199 * expression.cs (Binary.ResolveOperator): Don't silently return
9200 but return an error if an operator cannot be applied between two
9203 2002-08-28 Martin Baulig <martin@gnome.org>
9205 * class.cs (Constructor.Define): Set the permission attributes
9206 correctly instead of making all constructors public.
9208 2002-08-28 Martin Baulig <martin@gnome.org>
9210 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9211 for private members before reporting a CS0103; if we find anything,
9214 2002-08-28 Martin Baulig <martin@gnome.org>
9216 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9217 to check whether `closure_start_type == closure_invocation_type',
9218 we also need to check whether `m.DeclaringType == closure_invocation_type'
9219 before bypassing the permission checks. We might be accessing
9220 protected/private members from the base class.
9221 (TypeManager.RealMemberLookup): Only set private_ok if private
9222 members were requested via BindingFlags.NonPublic.
9224 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9226 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9227 MethodGroupExpr.IsExplicitImpl if appropriate.
9228 (Invocation.DoResolve): Don't report the CS0120 for explicit
9229 interface implementations.
9231 2002-08-27 Martin Baulig <martin@gnome.org>
9233 * expression.cs (Invocation.DoResolve): If this is a static
9234 method and we don't have an InstanceExpression, we must report
9237 2002-08-25 Martin Baulig <martin@gnome.org>
9239 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9240 `==' between a valuetype and an object.
9242 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9244 * ecore.cs (TypeExpr): Provide a ToString method.
9246 2002-08-24 Martin Baulig <martin@gnome.org>
9248 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9249 now called proggie.dbg and it's a binary file.
9251 2002-08-23 Martin Baulig <martin@gnome.org>
9253 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9255 2002-08-23 Martin Baulig <martin@gnome.org>
9257 * struct.cs (MyStructInfo.ctor): Make this work with empty
9258 structs; it's not allowed to use foreach() on null.
9260 2002-08-23 Martin Baulig <martin@gnome.org>
9262 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9263 writer the full pathname of the generated assembly.
9265 2002-08-23 Martin Baulig <martin@gnome.org>
9267 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9268 A `finally' block never returns or breaks; improved handling of
9271 2002-08-23 Martin Baulig <martin@gnome.org>
9273 * statement.cs (Throw.Resolve): Allow `throw null'.
9275 2002-08-23 Martin Baulig <martin@gnome.org>
9277 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9278 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9279 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9280 MemberLookup would return a wrong event if this is an explicit
9281 interface implementation and the class has an event with the same
9284 2002-08-23 Martin Baulig <martin@gnome.org>
9286 * statement.cs (Block.AddChildVariableNames): New public method.
9287 (Block.AddChildVariableName): Likewise.
9288 (Block.IsVariableNameUsedInChildBlock): Likewise.
9289 (Block.AddVariable): Check whether a variable name has already
9290 been used in a child block.
9292 * cs-parser.jay (declare_local_variables): Mark all variable names
9293 from the current block as being used in a child block in the
9296 2002-08-23 Martin Baulig <martin@gnome.org>
9298 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9299 find the symbol writer.
9301 * driver.cs: csc also allows the arguments to /define being
9302 separated by commas, not only by semicolons.
9304 2002-08-23 Martin Baulig <martin@gnome.org>
9306 * interface.cs (Interface.GetMembers): Added static check for events.
9308 2002-08-15 Martin Baulig <martin@gnome.org>
9310 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9311 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9313 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9314 why the MethodData.EmitDestructor() change was necessary.
9316 2002-08-20 Martin Baulig <martin@gnome.org>
9318 * class.cs (TypeContainer.FindMembers): Added static check for events.
9320 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9322 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9323 use Type.GetEvents(), not Type.FindMembers().
9325 2002-08-20 Martin Baulig <martin@gnome.org>
9327 * decl.cs (MemberCache): Added a special method cache which will
9328 be used for method-only searched. This ensures that a method
9329 search will return a MethodInfo with the correct ReflectedType for
9332 2002-08-20 Martin Baulig <martin@gnome.org>
9334 * decl.cs (DeclSpace.FindMembers): Made this public.
9336 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9338 * delegate.cs: fixed build on windows.
9339 [FIXME: Filed as bug #29150: MCS must report these errors.]
9341 2002-08-19 Ravi Pratap <ravi@ximian.com>
9343 * ecore.cs (StandardConversionExists): Return a false
9344 if we are trying to convert the void type to anything else
9345 since that is not allowed.
9347 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9348 we flag error 70 in the event an event is trying to be accessed
9349 directly from outside the declaring type.
9351 2002-08-20 Martin Baulig <martin@gnome.org>
9353 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9354 MemberCache from typemanager.cs to decl.cs.
9356 2002-08-19 Martin Baulig <martin@gnome.org>
9358 * class.cs (TypeContainer): Implement IMemberContainer.
9359 (TypeContainer.DefineMembers): Create the MemberCache.
9360 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9361 return public members if BindingFlags.Public was given, check
9362 whether members are static.
9364 2002-08-16 Martin Baulig <martin@gnome.org>
9366 * decl.cs (DeclSpace.Define): Splitted this in Define and
9367 DefineMembers. DefineMembers is called first and initializes the
9370 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9371 DefineMembers() on all our DeclSpaces.
9373 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9374 but call DefineMembers() on all nested interfaces. We call their
9375 Define() in our new Define() function.
9377 * interface.cs (Interface): Implement IMemberContainer.
9378 (Interface.Define): Moved all code except the attribute stuf to
9380 (Interface.DefineMembers): Initialize the member cache.
9382 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9383 need this anymore since we can use MemberCache.FindMembers directly.
9385 2002-08-19 Martin Baulig <martin@gnome.org>
9387 * typemanager.cs (MemberCache): When creating the cache for an
9388 interface type, add all inherited members.
9389 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9390 to `out bool used_cache' and documented it.
9391 (TypeManager.MemberLookup): If we already used the cache in the first
9392 iteration, we don't need to do the interfaces check.
9394 2002-08-19 Martin Baulig <martin@gnome.org>
9396 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9397 here from IMemberFinder and don't implement this interface anymore.
9398 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9400 * typemanager.cs (IMemberFinder): This interface is now only used by
9401 classes which actually support the member cache.
9402 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9403 since we only put DeclSpaces into this Hashtable.
9404 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9405 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9407 2002-08-16 Martin Baulig <martin@gnome.org>
9409 * typemanager.cs (ICachingMemberFinder): Removed.
9410 (IMemberFinder.MemberCache): New property.
9411 (TypeManager.FindMembers): Merged this with RealFindMembers().
9412 This function will never be called from TypeManager.MemberLookup()
9413 so we can't use the cache here, just the IMemberFinder.
9414 (TypeManager.MemberLookup_FindMembers): Check whether the
9415 IMemberFinder has a MemberCache and call the cache's FindMembers
9417 (MemberCache): Rewrote larger parts of this yet another time and
9418 cleaned it up a bit.
9420 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9422 * driver.cs (LoadArgs): Support quoting.
9424 (Usage): Show the CSC-like command line arguments.
9426 Improved a few error messages.
9428 2002-08-15 Martin Baulig <martin@gnome.org>
9430 * typemanager.cs (IMemberContainer.Type): New property.
9431 (IMemberContainer.IsInterface): New property.
9433 The following changes are conditional to BROKEN_RUNTIME, which is
9434 defined at the top of the file.
9436 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9437 class'es members, but add all members from TypeHandle.ObjectType
9438 if we're an interface.
9439 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9440 is the current type.
9441 (MemberCache.CacheEntry.Container): Removed this field.
9442 (TypeHandle.GetMembers): Include inherited members.
9444 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9446 * typemanager.cs: fixed compilation and added a comment on a field that
9449 2002-08-15 Martin Baulig <martin@gnome.org>
9451 * class.cs (ConstructorInitializer.Resolve): In the
9452 Expression.MemberLookup call, use the queried_type as
9455 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9456 declared' attribute, it's always true.
9457 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9458 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9459 temporary wrapper for FindMembers which tells MemberLookup whether
9460 members from the base classes are included in the return value.
9461 This will go away soon.
9462 (TypeManager.MemberLookup): Use this temporary hack here; once the
9463 new MemberCache is completed, we don't need to do the DeclaredOnly
9464 looping here anymore since the MemberCache will take care of this.
9465 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9466 (MemberCache): When creating the MemberCache for a class, get
9467 members from the current class and all its base classes.
9468 (MemberCache.CacheEntry.Container): New field. This is a
9469 temporary hack until the Mono runtime is fixed to distinguish
9470 between ReflectedType and DeclaringType. It allows us to use MCS
9471 with both the MS runtime and the unfixed Mono runtime without
9472 problems and without accecting performance.
9473 (MemberCache.SearchMembers): The DeclaredOnly looping from
9474 TypeManager.MemberLookup is now done here.
9476 2002-08-14 Martin Baulig <martin@gnome.org>
9478 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9479 Type.GetFields on dynamic types but get the fields from the
9480 corresponding TypeContainer.
9481 (MyStructInfo.GetStructInfo): Added check for enum types.
9483 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9484 (MemberList.SyncRoot): Implemented.
9485 (TypeManager.FilterWithClosure): No need to check permissions if
9486 closure_start_type == closure_invocation_type, don't crash if
9487 closure_invocation_type is null.
9489 2002-08-13 Martin Baulig <martin@gnome.org>
9491 Rewrote TypeContainer.FindMembers to use a member cache. This
9492 gives us a speed increase of about 35% for the self-hosting MCS
9493 build and of about 15-20% for the class libs (both on GNU/Linux).
9495 * report.cs (Timer): New class to get enhanced profiling. This
9496 whole class is "TIMER" conditional since it remarkably slows down
9499 * class.cs (MemberList): New class. This is an IList wrapper
9500 which we're now using instead of passing MemberInfo[]'s around to
9501 avoid copying this array unnecessarily.
9502 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9503 (ICachingMemberFinder, IMemberContainer): New interface.
9504 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9505 has already been checked, otherwise use it for the name comparision.
9506 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9507 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9508 if possible. Returns a MemberList, not a MemberInfo [].
9509 (TypeHandle): New class, implements IMemberContainer. We create
9510 one instance of this class per type, it contains a MemberCache
9511 which is used to do the member lookups.
9512 (MemberCache): New class. Each instance of this class contains
9513 all members of a type and a name-based hash table.
9514 (MemberCache.FindMembers): This is our new member lookup
9515 function. First, it looks up all members of the requested name in
9516 the hash table. Then, it walks this list and sorts out all
9517 applicable members and returns them.
9519 2002-08-13 Martin Baulig <martin@gnome.org>
9521 In addition to a nice code cleanup, this gives us a performance
9522 increase of about 1.4% on GNU/Linux - not much, but it's already
9523 half a second for the self-hosting MCS compilation.
9525 * typemanager.cs (IMemberFinder): New interface. It is used by
9526 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9527 Enum, Delegate or Interface.
9528 (TypeManager.finder_to_member_finder): New PtrHashtable.
9529 (TypeManager.finder_to_container): Removed.
9530 (TypeManager.finder_to_delegate): Removed.
9531 (TypeManager.finder_to_interface): Removed.
9532 (TypeManager.finder_to_enum): Removed.
9534 * interface.cs (Interface): Implement IMemberFinder.
9536 * delegate.cs (Delegate): Implement IMemberFinder.
9538 * enum.cs (Enum): Implement IMemberFinder.
9540 * class.cs (TypeContainer): Implement IMemberFinder.
9542 2002-08-12 Martin Baulig <martin@gnome.org>
9544 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9546 2002-08-12 Martin Baulig <martin@gnome.org>
9548 * ecore.cs (ITypeExpression): New interface for expressions which
9550 (TypeExpression): Renamed to TypeLookupExpression.
9551 (Expression.DoResolve): If we're doing a types-only lookup, the
9552 expression must implement the ITypeExpression interface and we
9553 call DoResolveType() on it.
9554 (SimpleName): Implement the new ITypeExpression interface.
9555 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9556 hack, the situation that we're only looking up types can't happen
9557 anymore when this method is called. Moved the type lookup code to
9558 DoResolveType() and call it.
9559 (SimpleName.DoResolveType): This ITypeExpression interface method
9560 is now doing the types-only lookup.
9561 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9562 (ResolveFlags): Added MaskExprClass.
9564 * expression.cs (MemberAccess): Implement the ITypeExpression
9566 (MemberAccess.DoResolve): Added support for a types-only lookup
9567 when we're called via ITypeExpression.DoResolveType().
9568 (ComposedCast): Implement the ITypeExpression interface.
9570 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9571 Expression.Resolve() with ResolveFlags.Type instead.
9573 2002-08-12 Martin Baulig <martin@gnome.org>
9575 * interface.cs (Interface.Define): Apply attributes.
9577 * attribute.cs (Attribute.ApplyAttributes): Added support for
9578 interface attributes.
9580 2002-08-11 Martin Baulig <martin@gnome.org>
9582 * statement.cs (Block.Emit): Only check the "this" variable if we
9583 do not always throw an exception.
9585 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9586 whether the property has a set accessor.
9588 2002-08-11 Martin Baulig <martin@gnome.org>
9590 Added control flow analysis support for structs.
9592 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9593 with control flow analysis turned off.
9594 (IVariable): New interface.
9595 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9596 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9597 (FieldExpr.DoResolve): Resolve the instance expression with flow
9598 analysis turned off and do the definite assignment check after the
9599 resolving when we know what the expression will resolve to.
9601 * expression.cs (LocalVariableReference, ParameterReference):
9602 Implement the new IVariable interface, only call the flow analysis
9603 code if ec.DoFlowAnalysis is true.
9604 (This): Added constructor which takes a Block argument. Implement
9605 the new IVariable interface.
9606 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9607 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9608 This does the definite assignment checks for struct members.
9610 * class.cs (Constructor.Emit): If this is a non-static `struct'
9611 constructor which doesn't have any initializer, call
9612 Block.AddThisVariable() to tell the flow analysis code that all
9613 struct elements must be initialized before control returns from
9616 * statement.cs (MyStructInfo): New public class.
9617 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9618 argument to this indexer. If non-zero, check an individual struct
9619 member, not the whole struct.
9620 (FlowBranching.CheckOutParameters): Check struct members.
9621 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9622 overloaded versions of these methods which take an additional
9623 `int field_idx' argument to check struct members.
9624 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9625 overloaded versions of these methods which take an additional
9626 `string field_name' argument to check struct member.s
9627 (VariableInfo): Implement the IVariable interface.
9628 (VariableInfo.StructInfo): New public property. Returns the
9629 MyStructInfo instance of the variable if it's a struct or null.
9630 (Block.AddThisVariable): New public method. This is called from
9631 Constructor.Emit() for non-static `struct' constructor which do
9632 not have any initializer. It creates a special variable for the
9633 "this" instance variable which will be checked by the flow
9634 analysis code to ensure that all of the struct's fields are
9635 initialized before control returns from the constructor.
9636 (UsageVector): Added support for struct members. If a
9637 variable/parameter is a struct with N members, we reserve a slot
9638 in the usage vector for each member. A struct is considered fully
9639 initialized if either the struct itself (slot 0) or all its
9640 members are initialized.
9642 2002-08-08 Martin Baulig <martin@gnome.org>
9644 * driver.cs (Driver.MainDriver): Only report an error CS5001
9645 if there were no compilation errors.
9647 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9648 `UnsafeContext' property to determine whether the parent is in
9649 unsafe context rather than checking the parent's ModFlags:
9650 classes nested in an unsafe class are unsafe as well.
9652 2002-08-08 Martin Baulig <martin@gnome.org>
9654 * statement.cs (UsageVector.MergeChildren): Distinguish between
9655 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9656 we return. Added test17() and test18() to test-154.cs.
9658 2002-08-08 Martin Baulig <martin@gnome.org>
9660 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9661 Family access, make sure the invoking type isn't a subclass of the
9662 queried type (that'd be a CS1540).
9664 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9665 this method which takes an additional `Type invocation_type'.
9667 * expression.cs (BaseAccess.DoResolve): Use the base type as
9668 invocation and query type.
9669 (MemberAccess.DoResolve): If the lookup failed and we're about to
9670 report a CS0122, try a lookup with the ec.ContainerType - if this
9671 succeeds, we must report a CS1540.
9673 2002-08-08 Martin Baulig <martin@gnome.org>
9675 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9676 (MethodGroupExpr): Implement the IMemberExpr interface.
9678 * expression (MemberAccess.ResolveMemberAccess): No need to have
9679 any special code for MethodGroupExprs anymore, they're now
9682 2002-08-08 Martin Baulig <martin@gnome.org>
9684 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9685 Family, FamANDAssem and FamORAssem permissions.
9686 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9688 2002-08-08 Martin Baulig <martin@gnome.org>
9690 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9691 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9694 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9696 * driver.cs: implemented /resource option to embed managed resources.
9698 2002-08-07 Martin Baulig <martin@gnome.org>
9700 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9701 (FieldBase.HasFieldInitializer): New public property.
9702 (FieldBase.GetInitializerExpression): New public method. Resolves and
9703 returns the field initializer and makes sure it is only resolved once.
9704 (TypeContainer.EmitFieldInitializers): Call
9705 FieldBase.GetInitializerExpression to get the initializer, this ensures
9706 that it isn't resolved multiple times.
9708 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9709 the resolving process (SimpleName/MemberLookup) that we're currently
9710 emitting a field initializer (which must not access any instance members,
9711 this is an error CS0236).
9713 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9714 argument, if the `IsFieldInitializer' flag is set, we must report and
9715 error CS0236 and not an error CS0120.
9717 2002-08-07 Martin Baulig <martin@gnome.org>
9719 * ecore.cs (IMemberExpr): New public interface.
9720 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9721 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9722 if the expression is an IMemberExpr.
9724 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9725 to be null, implicitly default to `this' if we're non-static in
9726 this case. Simplified the code a lot by using the new IMemberExpr
9727 interface. Also fixed bug #28176 here.
9729 2002-08-06 Martin Baulig <martin@gnome.org>
9731 * cs-parser.jay (SimpleLookup): Removed. We need to create
9732 ParameterReferences during semantic analysis so that we can do a
9733 type-only search when resolving Cast, TypeOf and SizeOf.
9734 (block): Pass the `current_local_parameters' to the Block's
9737 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9738 argument to the constructor.
9739 (ConstructorInitializer.Resolve): Create a temporary implicit
9740 block with the parameters.
9742 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9743 references here if we aren't doing a type-only search.
9745 * statement.cs (Block): Added constructor which takes a
9746 `Parameters parameters' argument.
9747 (Block.Parameters): New public property.
9749 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9750 to `Parameters' and made it public readonly.
9752 2002-08-06 Martin Baulig <martin@gnome.org>
9754 * ecore.cs (Expression.Warning): Made this public as well.
9756 * report.cs (Report.Debug): Print the contents of collections.
9758 2002-08-06 Martin Baulig <martin@gnome.org>
9760 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9761 used to tell Resolve() which kinds of expressions it may return.
9762 (Expression.Resolve): Added overloaded version of this method which
9763 takes a `ResolveFlags flags' argument. This can be used to tell
9764 Resolve() which kinds of expressions it may return. Reports a
9766 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9767 ResolveFlags.SimpleName.
9768 (Expression.Error118): Added overloaded version of this method which
9769 takes a `ResolveFlags flags' argument. It uses the flags to determine
9770 which kinds of expressions are allowed.
9772 * expression.cs (Argument.ResolveMethodGroup): New public method.
9773 Resolves an argument, but allows a MethodGroup to be returned.
9774 This is used when invoking a delegate.
9776 * TODO: Updated a bit.
9778 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9780 Fixed compilation with csc.
9782 * ecore.cs: Expression.Error made public. Is this correct? Should
9783 Warning be made public too?
9785 * expression.cs: use ea.Location instead of ea.loc.
9786 [FIXME: Filed as bug #28607: MCS must report these errors.]
9788 2002-08-06 Martin Baulig <martin@gnome.org>
9790 * ecore.cs (Expression.loc): Moved the location here instead of
9791 duplicating it in all derived classes.
9792 (Expression.Location): New public property.
9793 (Expression.Error, Expression.Warning): Made them non-static and
9794 removed the location argument.
9795 (Expression.Warning): Added overloaded version which takes an
9796 `int level' argument.
9797 (Expression.Error118): Make this non-static and removed the
9798 expression and location arguments.
9799 (TypeExpr): Added location argument to the constructor.
9801 * expression.cs (StaticCallExpr): Added location argument to
9803 (Indirection, PointerArithmetic): Likewise.
9804 (CheckedExpr, UnCheckedExpr): Likewise.
9805 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9806 (StringPtr): Likewise.
9809 2002-08-05 Martin Baulig <martin@gnome.org>
9811 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9813 * assign.cs (Assign.DoResolve): Check whether the source
9814 expression is a value or variable.
9816 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9817 while resolving the corresponding blocks.
9819 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9820 an error, don't silently return null.
9822 * statement.cs (Block.AddVariable): Do the error reporting here
9823 and distinguish between CS0128 and CS0136.
9824 (Block.DoResolve): Report all unused labels (warning CS0164).
9825 (LabeledStatement): Pass the location to the constructor.
9826 (LabeledStatement.HasBeenReferenced): New property.
9827 (LabeledStatement.Resolve): Set it to true here.
9829 * statement.cs (Return.Emit): Return success even after reporting
9830 a type mismatch error (CS0126 or CS0127), this is what csc does and
9831 it avoids confusing the users with any consecutive errors.
9833 2002-08-05 Martin Baulig <martin@gnome.org>
9835 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9837 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9839 * expression.cs (MemberAccess.DoResolve): Silently return if an
9840 error has already been reported.
9842 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9843 error has already been reported.
9845 2002-08-05 Martin Baulig <martin@gnome.org>
9847 * statement.cs (UsageVector): Only initialize the `parameters'
9848 vector if we actually have any "out" parameters.
9850 2002-08-05 Martin Baulig <martin@gnome.org>
9852 * expression.cs (Binary.ResolveOperator): When combining delegates,
9853 they must have the same type.
9855 2002-08-05 Martin Baulig <martin@gnome.org>
9857 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9858 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9859 work with the ms runtime and we also don't need it: if we're a
9860 PropertyBuilder and not in the `indexer_arguments' hash, then we
9861 are a property and not an indexer.
9863 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9864 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9865 since the latter one doesn't work with the ms runtime.
9867 2002-08-03 Martin Baulig <martin@gnome.org>
9869 Fixed bugs #27998 and #22735.
9871 * class.cs (Method.IsOperator): New public field.
9872 (Method.CheckBase): Report CS0111 if there's already a method
9873 with the same parameters in the current class. Report CS0508 when
9874 attempting to change the return type of an inherited method.
9875 (MethodData.Emit): Report CS0179 if a method doesn't have a body
9876 and it's not marked abstract or extern.
9877 (PropertyBase): New abstract base class for Property and Indexer.
9878 (PropertyBase.CheckBase): Moved here from Property and made it work
9880 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
9881 the same so we can reuse it there.
9882 (Property, Indexer): Derive from PropertyBase.
9883 (MethodSignature.inheritable_property_signature_filter): New delegate
9884 to find properties and indexers.
9886 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9887 argument and improved error reporting.
9889 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9890 EmptyReadOnlyParameters and made it a property.
9892 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9893 version of this method which takes a `PropertyInfo indexer'.
9894 (TypeManager.RegisterIndexer): New method.
9896 * class.cs: Added myself as author of this file :-)
9898 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9900 * class.cs: fixed compilation on windoze.
9902 2002-08-03 Martin Baulig <martin@gnome.org>
9904 * interface.cs (Interface.GetInterfaceBases): Check whether all
9905 base interfaces are at least as accessible than the current one.
9907 * class.cs (TypeContainer.GetClassBases): Check whether base types
9908 are at least as accessible than the current type.
9909 (TypeContainer.AsAccessible): Implemented and made non-static.
9910 (MemberBase.CheckParameters): Report errors if the accessibility
9913 * delegate.cs (Delegate.Delegate): The default visibility is
9914 internal for top-level types and private for nested types.
9915 (Delegate.Define): Report errors if the accessibility checks fail.
9917 * enum.cs (Enum.Enum): The default visibility is internal for
9918 top-level types and private for nested types.
9919 (Enum.DefineType): Compute the correct visibility.
9921 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
9922 function which takes a `bool is_toplevel' instead of a TypeContainer.
9924 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
9927 2002-08-02 Martin Baulig <martin@gnome.org>
9929 * expression.cs (LocalVariableReferenc): Added constructor which
9930 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
9931 (LocalVariableReference.IsReadOnly): New property.
9932 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
9933 variable is readonly, use our own readonly flag to do this; you can
9934 use the new constructor to get a writable reference to a read-only
9937 * cs-parser.jay (foreach_statement, using_statement): Get a writable
9938 reference to the local variable.
9940 2002-08-01 Miguel de Icaza <miguel@ximian.com>
9942 * rootcontext.cs (ResolveCore): Also include System.Exception
9944 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
9945 we reach an EmptyStatement.
9947 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
9950 * expression.cs (Binary.ResolveOperator): Check error result in
9953 use brtrue/brfalse directly and avoid compares to null.
9955 2002-08-02 Martin Baulig <martin@gnome.org>
9957 * class.cs (TypeContainer.Define): Define all nested interfaces here.
9958 Fixes bug #28407, added test-155.cs.
9960 2002-08-01 Martin Baulig <martin@gnome.org>
9962 * class.cs (Event.EmitDefaultMethod): Make this work with static
9963 events. Fixes #28311, added verify-3.cs.
9965 2002-08-01 Martin Baulig <martin@gnome.org>
9967 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
9968 `is_disposable' fields.
9969 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
9970 `hm.is_disposable' if we're using the collection pattern.
9971 (Foreach.EmitCollectionForeach): Use the correct type for the
9972 enumerator's local variable, only emit the try/finally block if
9973 necessary (fixes #27713).
9975 2002-08-01 Martin Baulig <martin@gnome.org>
9977 * ecore.cs (Expression.report118): Renamed to Error118 and made
9980 * statement.cs (Throw.Resolve): Check whether the expression is of
9981 the correct type (CS0118) and whether the type derives from
9982 System.Exception (CS0155).
9983 (Catch.Resolve): New method. Do the type lookup here and check
9984 whether it derives from System.Exception (CS0155).
9985 (Catch.CatchType, Catch.IsGeneral): New public properties.
9987 * typemanager.cs (TypeManager.exception_type): Added.
9989 2002-07-31 Miguel de Icaza <miguel@ximian.com>
9991 * driver.cs: Updated About function.
9993 2002-07-31 Martin Baulig <martin@gnome.org>
9995 Implemented Control Flow Analysis.
9997 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
9998 (EmitContext.CurrentBranching): Added.
9999 (EmitContext.StartFlowBranching): Added.
10000 (EmitContext.EndFlowBranching): Added.
10001 (EmitContext.KillFlowBranching): Added.
10002 (EmitContext.IsVariableAssigned): Added.
10003 (EmitContext.SetVariableAssigned): Added.
10004 (EmitContext.IsParameterAssigned): Added.
10005 (EmitContext.SetParameterAssigned): Added.
10006 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
10007 Added control flow analysis stuff here.
10009 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
10010 resolve the expression as lvalue.
10011 (LocalVariableReference.DoResolve): Check whether the variable has
10012 already been assigned.
10013 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
10014 the parameter as assigned here.
10015 (ParameterReference.DoResolve): Check whether the parameter has already
10017 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
10018 expression as lvalue.
10020 * statement.cs (FlowBranching): New class for the flow analysis code.
10021 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
10022 (LabeledStatement.IsDefined): New public property.
10023 (LabeledStatement.AddUsageVector): New public method to tell flow
10024 analyis that the label may be reached via a forward jump.
10025 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
10027 (VariableInfo.Number): New public field. This is used by flow analysis
10028 to number all locals of a block.
10029 (Block.CountVariables): New public property. This is the number of
10030 local variables in this block (including the locals from all parent
10032 (Block.EmitMeta): Number all the variables.
10034 * statement.cs: Added flow analysis support to all classes.
10036 2002-07-31 Martin Baulig <martin@gnome.org>
10038 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
10039 To get debugging messages, compile mcs with /define:MCS_DEBUG and
10040 then use this argument.
10042 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
10044 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
10045 use this to specify /define options.
10047 2002-07-29 Martin Baulig <martin@gnome.org>
10049 * statement.cs (Fixed): Moved all code that does variable lookups
10050 and resolvings from Emit to Resolve.
10052 * statement.cs (For): Moved all code that does variable lookups
10053 and resolvings from Emit to Resolve.
10055 * statement.cs (Using): Moved all code that does variable lookups
10056 and resolvings from Emit to Resolve.
10058 2002-07-29 Martin Baulig <martin@gnome.org>
10060 * attribute.cs (Attribute.Resolve): Explicitly catch a
10061 System.NullReferenceException when creating the
10062 CustromAttributeBuilder and report a different warning message.
10064 2002-07-29 Martin Baulig <martin@gnome.org>
10066 * support.cs (ParameterData.ParameterName): Added method to
10067 get the name of a parameter.
10069 * typemanager.cs (TypeManager.IsValueType): New public method.
10071 2002-07-29 Martin Baulig <martin@gnome.org>
10073 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
10074 is a flag which specifies that it's either ref or out.
10075 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
10076 the out parameter to `out Parameter.Modifier mod', also set the
10077 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
10079 * support.cs (InternalParameters.ParameterModifier): Distinguish
10080 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10081 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10083 * expression.cs (Argument.GetParameterModifier): Distinguish
10084 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
10085 Parameter.Modifier.ISBYREF flag if it's either ref or out.
10087 2002-07-29 Martin Baulig <martin@gnome.org>
10089 * expression.cs (ParameterReference.ParameterReference): Added
10090 `Location loc' argument to the constructor.
10092 * cs-parser.jay: Pass location to ParameterReference.
10094 2002-07-28 Miguel de Icaza <miguel@ximian.com>
10096 * statement.cs (Try): Initialize the location.
10098 * cs-parser.jay: pass location to Try.
10100 * expression.cs (Unary.Reduce): Change the prototype to return
10101 whether a constant fold could be performed or not. The result is
10102 returned in an out parameters. In the case of Indirection and
10103 AddressOf, we want to perform the full tests.
10105 2002-07-26 Miguel de Icaza <miguel@ximian.com>
10107 * statement.cs (Statement.Emit): Flag dead code.
10109 2002-07-27 Andrew Birkett <andy@nobugs.org>
10111 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
10113 2002-07-27 Martin Baulig <martin@gnome.org>
10115 * class.cs (MethodData.Define): Put back call to
10116 TypeManager.AddMethod(), accidentally commented this out.
10118 * report.cs (Debug): New public method to print debugging information,
10119 this is `[Conditional ("DEBUG")]'.
10121 2002-07-26 Martin Baulig <martin@gnome.org>
10123 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10124 (switch_statement): Push the current_block to the switch_stack and
10125 pop it again when we're done with the switch.
10126 (switch_section): The new block is a child of the current_block.
10127 Fixes bug #24007, added test-152.cs.
10129 2002-07-27 Martin Baulig <martin@gnome.org>
10131 * expression.cs (Invocation.EmitArguments): When calling a varargs
10132 function with only its fixed arguments, we need to pass an empty
10135 2002-07-27 Martin Baulig <martin@gnome.org>
10137 Mono 0.13 has been released.
10139 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10141 * driver.cs: Rename --resource to --linkres, because that is what
10142 we do currently, we dont support --resource yet.
10144 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10146 2002-07-25 Martin Baulig <martin@gnome.org>
10148 * class.cs (MethodData): New public class. This is a `method builder'
10149 class for a method or one accessor of a Property/Indexer/Event.
10150 (MethodData.GetMethodFlags): Moved here from MemberBase.
10151 (MethodData.ApplyAttributes): Likewise.
10152 (MethodData.ApplyObsoleteAttribute): Likewise.
10153 (MethodData.ApplyConditionalAttribute): Likewise.
10154 (MethodData.ApplyDllImportAttribute): Likewise.
10155 (MethodData.CheckAbstractAndExternal): Likewise.
10156 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10157 (MethodData.Emit): Formerly known as Method.Emit().
10158 (MemberBase): Moved everything which was specific to a single
10159 accessor/method to MethodData.
10160 (Method): Create a new MethodData and call Define() and Emit() on it.
10161 (Property, Indexer, Event): Create a new MethodData objects for each
10162 accessor and call Define() and Emit() on them.
10164 2002-07-25 Martin Baulig <martin@gnome.org>
10166 Made MethodCore derive from MemberBase to reuse the code from there.
10167 MemberBase now also checks for attributes.
10169 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10170 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10172 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10173 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10174 (MemberBase.ApplyAttributes): New virtual method; applies the
10175 attributes to a method or accessor.
10176 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10177 (MemberBase.ApplyConditionalAttribute): Likewise.
10178 (MemberBase.ApplyDllImportAttribute): Likewise.
10179 (MemberBase.CheckAbstractAndExternal): Likewise.
10180 (MethodCore.ParameterTypes): This is now a property instead of a
10181 method, it's initialized from DoDefineParameters().
10182 (MethodCore.ParameterInfo): Removed the set accessor.
10183 (MethodCore.DoDefineParameters): New protected virtual method to
10184 initialize ParameterTypes and ParameterInfo.
10185 (Method.GetReturnType): We can now simply return the MemberType.
10186 (Method.GetMethodFlags): Override the MemberBase version and add
10187 the conditional flags.
10188 (Method.CheckBase): Moved some code from Define() here, call
10189 DoDefineParameters() here.
10190 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10191 here to avoid some larger code duplication.
10192 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10193 ensure that abstract and external accessors don't declare a body.
10195 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10196 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10197 lookup in the attribute's parent classes, so we need to abort as soon
10198 as we found the first match.
10199 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10200 the attribute has no arguments.
10202 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10205 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10207 * cs-parser.jay: reverted previous patch.
10209 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10211 * cs-parser.jay: fixed bug #22119.
10213 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10215 * attribute.cs: fixed compilation. The error was:
10216 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10217 be assigned to before control leaves the current method."
10218 [FIXME: Filed as bug #28186: MCS must report this error.]
10220 2002-07-25 Martin Baulig <martin@gnome.org>
10222 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10223 method to pull the condition name ouf of a Conditional attribute.
10224 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10225 the obsolete message and error flag out of an Obsolete attribute.
10227 * class.cs (Method.GetMethodFlags): New public method to get the
10228 TypeManager.MethodFlags for this method.
10229 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10231 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10232 if we're overriding a virtual function, set the new private variable
10233 `parent_method'; call the new TypeManager.AddMethod().
10235 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10236 the MethodBuilder and the Method in a PtrHashtable.
10237 (TypeManager.builder_to_method): Added for this purpose.
10238 (TypeManager.MethodFlags): Added IsObsoleteError.
10239 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10240 Obsolete and Conditional arguments in MethodBuilders. If we discover
10241 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10242 the message from the attribute.
10244 2002-07-24 Martin Baulig <martin@gnome.org>
10246 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10247 preprocessor directives, ensure that the argument to #define/#undef is
10248 exactly one identifier and that it's actually an identifier.
10250 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10253 2002-07-24 Martin Baulig <martin@gnome.org>
10255 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10256 initialize it to TypeManager.object_type in the constructor.
10257 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10258 of the `hm.get_current' method if we're using the collection pattern.
10259 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10260 for the explicit conversion to make it work when we're using the collection
10261 pattern and the `Current' property has a different return type than `object'.
10264 2002-07-24 Martin Baulig <martin@gnome.org>
10266 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10267 does not match, but don't report any errors. This method is called in
10268 order for all methods in a MethodGroupExpr until a matching method is
10269 found, so we don't want to bail out if the first method doesn't match.
10270 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10271 matches, report the 123. Fixes #28070.
10273 2002-07-24 Martin Baulig <martin@gnome.org>
10275 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10276 TypeManager.TypeToCoreType() to the top of the method so the
10277 following equality checks will work. Fixes #28107.
10279 2002-07-24 Martin Baulig <martin@gnome.org>
10281 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10282 operand is of type uint, and the other operand is of type sbyte,
10283 short or int, the operands are converted to type long." -
10284 Actually do what this comment already told us. Fixes bug #28106,
10287 2002-07-24 Martin Baulig <martin@gnome.org>
10289 * class.cs (MethodBase): New abstract class. This is now a base
10290 class for Property, Indexer and Event to avoid some code duplication
10291 in their Define() and DefineMethods() methods.
10292 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10293 generic methods for Define() and DefineMethods().
10294 (FieldBase): Derive from MemberBase, not MemberCore.
10295 (Property): Derive from MemberBase, not MemberCore.
10296 (Property.DefineMethod): Moved all the code from this method to the
10297 new MethodBase.DefineAccessor(), just call it with appropriate
10299 (Property.Define): Call the new Property.DoDefine(), this does some
10300 sanity checks and we don't need to duplicate the code everywhere.
10301 (Event): Derive from MemberBase, not MemberCore.
10302 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10303 accessors, this will also make them work with interface events.
10304 (Indexer): Derive from MemberBase, not MemberCore.
10305 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10306 (Indexer.Define): Use the new MethodBase functions.
10308 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10309 argument to the constructor.
10310 (Interface.FindMembers): Added support for interface events.
10311 (Interface.PopluateEvent): Implemented.
10313 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10315 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10317 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10318 but this is required to check for a method name being the same as
10319 the containing class.
10323 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10325 * interface.cs: initialize variable.
10327 2002-07-23 Martin Baulig <martin@gnome.org>
10329 Implemented the IndexerName attribute in interfaces.
10331 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10332 name if this is an explicit interface implementation.
10333 (Indexer.InterfaceIndexerName): New public variable. If we're
10334 implementing an interface indexer, this is the IndexerName in that
10335 interface. Otherwise, it's the IndexerName.
10336 (Indexer.DefineMethod): If we're implementing interface indexer,
10337 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10338 and Pending.ImplementIndexer methods.
10339 (Indexer.Define): Also define the PropertyBuilder if we're
10340 implementing an interface indexer and this is neither an explicit
10341 interface implementation nor do the IndexerName match the one in
10344 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10345 If a method is defined here, then we always need to create a proxy
10346 for it. This is used when implementing interface indexers.
10347 (Pending.IsInterfaceIndexer): New public method.
10348 (Pending.ImplementIndexer): New public method.
10349 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10350 This is used when implementing interface indexers to define a proxy
10352 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10353 define a proxy if necessary.
10355 * interface.cs (Interface.IndexerName): New public variable.
10356 (Interface.PopulateIndexer): Set the IndexerName.
10357 (Interface.DefineIndexers): New private method. Populate all the
10358 indexers and make sure their IndexerNames match.
10360 * typemanager.cs (IndexerPropertyName): Added support for interface
10363 2002-07-22 Martin Baulig <martin@gnome.org>
10365 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10366 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10367 ret if HasReturnLabel.
10368 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10371 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10372 and set the ec.LoopBeginTryCatchLevel.
10373 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10374 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10375 the current ec.TryCatchLevel, the branch goes out of an exception
10376 block. In this case, we need to use Leave and not Br.
10378 2002-07-22 Martin Baulig <martin@gnome.org>
10380 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10381 block unless the block does not always return or it is contained in
10382 another try { ... } catch { ... } block. Fixes bug #26506.
10383 Added verify-1.cs to the test suite.
10385 2002-07-22 Martin Baulig <martin@gnome.org>
10387 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10388 then we do not always return. Fixes bug #24985.
10390 2002-07-22 Martin Baulig <martin@gnome.org>
10392 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10393 lookup on a per-class level; ie. walk up the class hierarchy until we
10394 found at least one applicable method, then choose the best among them.
10395 Fixes bug #24463 and test-29.cs.
10397 2002-07-22 Martin Baulig <martin@gnome.org>
10399 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10400 return types of the methods. The return type is not part of the
10401 signature and we must not check it to make the `new' modifier work.
10402 Fixes bug #27999, also added test-147.cs.
10403 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10405 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10406 on the method's return type.
10408 2002-07-21 Martin Baulig <martin@gnome.org>
10410 * assign.cs: Make this work if the rightmost source is a constant and
10411 we need to do an implicit type conversion. Also adding a few more tests
10412 to test-38.cs which should have caught this.
10414 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10415 target in the makefile for this. The makefile.gnu is primarily intended
10416 for end-users who don't want to debug the compiler.
10418 2002-07-21 Martin Baulig <martin@gnome.org>
10420 * assign.cs: Improved the Assign class so it can now handle embedded
10421 assignments (X = Y = Z = something). As a side-effect this'll now also
10422 consume less local variables. test-38.cs now passes with MCS, added
10423 a few new test cases to that test.
10425 2002-07-20 Martin Baulig <martin@gnome.org>
10427 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10428 instructions. Fixes bug #27977, also added test-146.cs.
10430 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10432 * cs-tokenizer.cs: fixed getHex ().
10434 2002-07-19 Martin Baulig <martin@gnome.org>
10436 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10437 not Type.GetType() to lookup the array type. This is needed when
10438 we're constructing an array of a user-defined type.
10439 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10440 single-dimensional arrays, but also for single-dimensial arrays of
10443 2002-07-19 Martin Baulig <martin@gnome.org>
10445 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10446 this function is called, it's not allowed to share LocalBuilders
10447 among ILGenerators.
10449 2002-07-19 Martin Baulig <martin@gnome.org>
10451 * expression.cs (Argument.Resolve): Report an error 118 when trying
10452 to pass a type as argument.
10454 2002-07-18 Martin Baulig <martin@gnome.org>
10456 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10457 Conv_R_Un for the signed `long' type.
10459 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10461 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10462 `expr' for the temporary result, as that will fail if we do
10463 multiple resolves on the same expression.
10465 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10467 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10468 ec.TypeContainer for looking up aliases.
10470 * class.cs (TypeContainer): Remove LookupAlias from here.
10472 * decl.cs (DeclSpace); Move here.
10474 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10476 * class.cs (FindMembers): Only call filter if the constructor
10477 bulider is not null.
10479 Also handle delegates in `NestedTypes' now. Now we will perform
10480 type lookups using the standard resolution process. This also
10483 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10484 This uses Expressions (the limited kind that can be parsed by the
10485 tree) instead of strings.
10487 * expression.cs (ComposedCast.ToString): Implement, used to flag
10488 errors since now we have to render expressions.
10490 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10493 * ecore.cs (SimpleName.ToString): ditto.
10495 * cs-parser.jay: Instead of using strings to assemble types, use
10496 Expressions to assemble the type (using SimpleName, ComposedCast,
10497 MemberAccess). This should fix the type lookups in declarations,
10498 because we were using a different code path for this.
10500 * statement.cs (Block.Resolve): Continue processing statements
10501 even when there is an error.
10503 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10505 * class.cs (Event.Define): Also remove the `remove' method from
10506 the list of pending items.
10508 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10509 generate more compact code.
10511 2002-07-17 Martin Baulig <martin@gnome.org>
10513 * const.cs (Const.LookupConstantValue): Add support for constant
10514 `unchecked' and `checked' expressions.
10515 Also adding test case test-140.cs for this.
10517 2002-07-17 Martin Baulig <martin@gnome.org>
10519 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10520 check whether mi.ReturnType implements the IEnumerator interface; the
10521 `==' and the IsAssignableFrom() will fail in this situation.
10523 2002-07-16 Ravi Pratap <ravi@ximian.com>
10525 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10528 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10530 * expression.cs: fixed bug #27811.
10532 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10534 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10535 Molaro: when we are a ref, the value already contains a pointer
10536 value, do not take the address of it.
10538 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10539 * removed mb-parser.jay and mb-tokenizer.cs
10541 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10543 * expression.cs: check against the building corlib void type.
10545 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10547 * ecore.cs: fix for valuetype static readonly fields: when
10548 initializing them, we need their address, not the address of a copy.
10550 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10552 * typemanager.cs: register also enum_type in corlib.
10554 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10556 * class.cs: allow calling this (but not base) initializers in structs.
10558 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10560 * ecore.cs: make sure we compare against the building base types
10563 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10565 * typemanager.cs: fix TypeToCoreType() to handle void and object
10566 (corlib gets no more typerefs after this change).
10568 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10570 * expression.cs (ArrayCreation.EmitArrayArguments): use
10571 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10573 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10574 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10575 array indexes, the runtime actually forbids them.
10577 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10578 for array arguments here.
10580 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10581 instead of the default for ValueTypes.
10583 (New.DoEmit): Use IsValueType instead of
10584 IsSubclassOf (value_type)
10585 (New.DoResolve): ditto.
10586 (Invocation.EmitCall): ditto.
10588 * assign.cs (Assign): ditto.
10590 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10591 Statements *are* currently doing part of their resolution during
10594 Expressions do always resolve during resolve, but statements are
10595 only required to propagate resolution to their children.
10597 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10599 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10601 (LoadAssembly): Do not add the dll if it is already specified
10603 (MainDriver): Add the System directory to the link path at the end,
10604 after all the other -L arguments.
10606 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10607 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10608 ldelem.u1) and using the opposite for sbytes.
10610 This fixes Digger, and we can finally run it.
10612 * driver.cs (UnixParseOption): Move the option parsing here.
10613 (CSCParseOption): Implement CSC-like parsing of options.
10615 We now support both modes of operation, the old Unix way, and the
10616 new CSC-like way. This should help those who wanted to make cross
10617 platform makefiles.
10619 The only thing broken is that /r:, /reference: and /lib: are not
10620 implemented, because I want to make those have the same semantics
10621 as the CSC compiler has, and kill once and for all the confussion
10622 around this. Will be doing this tomorrow.
10624 * statement.cs (Unsafe.Resolve): The state is checked during
10625 resolve, not emit, so we have to set the flags for IsUnsfe here.
10627 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10629 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10630 not catch the Error_ObjectRefRequired in SimpleName (as it is
10631 possible to have a class/instance variable name that later gets
10632 deambiguated), we have to check this here.
10634 2002-07-10 Ravi Pratap <ravi@ximian.com>
10636 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10637 make static and put into Expression.
10639 (Event.Define): Register the private field of the event with the
10640 TypeManager so that GetFieldFromEvent can get at it.
10642 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10643 keep track of the private field associated with an event which
10646 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10649 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10651 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10653 * expression.cs (Binary.EmitBranchable): this routine emits the
10654 Binary expression in a branchable context. This basically means:
10655 we need to branch somewhere, not just get the value on the stack.
10657 This works together with Statement.EmitBoolExpression.
10659 * statement.cs (Statement.EmitBoolExpression): Use
10662 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10664 * statement.cs (For): Reduce the number of jumps in loops.
10666 (For): Implement loop inversion for the For statement.
10668 (Break): We can be breaking out of a Try/Catch controlled section
10669 (foreach might have an implicit try/catch clause), so we need to
10670 use Leave instead of Br.
10672 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10673 now). If the instace expression supports IMemoryLocation, we use
10674 the AddressOf method from the IMemoryLocation to extract the
10675 address instead of emitting the instance.
10677 This showed up with `This', as we were emitting the instance
10678 always (Emit) instead of the Address of This. Particularly
10679 interesting when This is a value type, as we dont want the Emit
10680 effect (which was to load the object).
10682 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10684 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10686 * statement.cs (Checked): Set the CheckedState during the resolve
10687 process too, as the ConvCast operations track the checked state on
10688 the resolve process, and not emit.
10690 * cs-parser.jay (namespace_member_declaration): Flag that we have
10691 found a declaration when we do. This is used to flag error 1529
10693 * driver.cs: Report ok when we display the help only.
10695 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10697 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10699 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10701 * cs-tokenizer.cs (define): We also have to track locally the
10702 defines. AllDefines is just used for the Conditional Attribute,
10703 but we also need the local defines for the current source code.
10705 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10707 * statement.cs (While, For, Do): These loops can exit through a
10708 Break statement, use this information to tell whether the
10709 statement is the last piece of code.
10711 (Break): Flag that we break.
10713 * codegen.cs (EmitContexts): New `Breaks' state variable.
10715 2002-07-03 Martin Baulig <martin@gnome.org>
10717 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10718 modifiers in method declarations in structs. Otherwise, you won't
10719 be able to override things like Object.Equals().
10721 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10723 * class.cs (Method, Property, Indexer): Do not allow the public
10724 modifier to be used in explicit interface implementations.
10726 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10727 override modifiers in method declarations in structs
10729 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10731 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10732 integer or real overflow, report an error
10734 2002-07-02 Martin Baulig <martin@gnome.org>
10736 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10737 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10738 to tell the runtime about our newly created System.Object and
10739 System.ValueType types.
10741 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10743 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10744 struct instead of Ldarg/Starg.
10746 2002-07-02 Martin Baulig <martin@gnome.org>
10748 * expression.cs (Indirection.Indirection): Call
10749 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10751 2002-07-02 Martin Baulig <martin@gnome.org>
10753 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10754 ValueType, call TypeManager.TypeToCoreType() on it.
10755 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10756 the OpCodes.Newarr argument.
10758 2002-07-02 Martin Baulig <martin@gnome.org>
10760 * expression.cs (Invocation.EmitCall): When compiling corlib,
10761 replace all calls to the system's System.Array type to calls to
10762 the newly created one.
10764 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10765 System.Array methods.
10766 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10767 from the system's System.Array type which must be replaced.
10769 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10771 * typemanager.cs: load unverifiable_code_ctor so we can build
10772 corlib using the correct type. Avoid using GetTypeCode() with
10774 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10775 TypeManager.object_type to allow building corlib.
10777 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10779 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10781 2002-07-01 Martin Baulig <martin@gnome.org>
10783 * class.cs: Make the last change actually work, we need to check
10784 whether `ifaces != null' to avoid a crash.
10786 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10788 * class.cs: when we build structs without fields that implement
10789 interfaces, we need to add the interfaces separately, since there is
10790 no API to both set the size and add the interfaces at type creation
10793 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10795 * expression.cs: the dimension arguments to the array constructors
10796 need to be converted if they are a long.
10798 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10800 * class.cs: don't emit ldarg.0 if there is no parent constructor
10801 (fixes showstopper for corlib).
10803 2002-06-29 Martin Baulig <martin@gnome.org>
10805 MCS now compiles corlib on GNU/Linux :-)
10807 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10808 ie. check for MethodImplOptions.InternalCall.
10810 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10811 and TypeManager.attribute_type are null, so we must explicitly check
10812 whether parent is not null to find out whether it's an attribute type.
10813 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10814 and SetBuilder, not only if the property is neither abstract nor external.
10815 This is necessary to set the MethodImplOptions on the accessor methods.
10816 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10817 SetBuilder, see Property.Emit().
10819 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10820 populate "System.Object", "System.ValueType" and "System.Attribute" since
10821 they've already been populated from BootCorlib_PopulateCoreTypes().
10823 2002-06-29 Martin Baulig <martin@gnome.org>
10825 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10826 is the NullLiteral, we also need to make sure that target_type is not
10829 2002-06-29 Martin Baulig <martin@gnome.org>
10831 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10832 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10833 before calling BootstrapCorlib_ResolveDelegate ().
10835 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10837 * statement.cs: fixed build-breaker. All tests passed ok.
10839 2002-06-27 Martin Baulig <martin@gnome.org>
10841 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10842 for System.Decimal when compiling corlib.
10844 2002-06-27 Martin Baulig <martin@gnome.org>
10846 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10847 switch blocks which contain nothing but a default clause.
10849 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10851 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10853 2002-06-27 Martin Baulig <martin@gnome.org>
10855 * ecore.cs (PropertyExpr.PropertyExpr): Call
10856 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10858 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10859 is already a TypeBuilder.
10861 2002-06-27 Martin Baulig <martin@gnome.org>
10863 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10864 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10865 the "from an array-type to System.Array" case. This makes it work
10866 when compiling corlib.
10868 2002-06-27 Martin Baulig <martin@gnome.org>
10870 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
10871 non-static PropertyExpr, set its InstanceExpression. This makes
10872 the `ICollection.Count' property work in System/Array.cs.
10874 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
10876 * driver.cs: Made error handling more consistent. Errors now
10877 tracked by Report class, so many methods which used to return int
10878 now return void. Main() now prints success/failure and
10879 errors/warnings message.
10881 Renamed '--probe' compiler argument to '--expect-error'. Removed
10882 the magic number return values (123 and 124). Now, if the
10883 expected error occurs, the compiler exits with success (exit value
10884 0). If the compilation completes without seeing that particular
10885 error, the compiler exits with failure (exit value 1). The
10886 makefile in mcs/errors has been changed to handle the new behaviour.
10888 * report.cs: Made 'expected error' number a property and renamed
10889 it from 'Probe' to 'ExpectedError'.
10891 * genericparser.cs: Removed error handling support, since it is
10892 now all done by Report class.
10894 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10895 class, so parse() no longer returns an int.
10897 * namespace.cs: Use Report.Error instead of GenericParser.error
10899 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10901 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10902 TypeContainer.AddOperator): At the front of the list put the
10903 explicit implementations, so they get resolved/defined first.
10905 2002-06-21 Miguel de Icaza <miguel@ximian.com>
10907 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
10908 interface type is implemented by this TypeContainer. Used during
10909 explicit interface implementation.
10911 (Property.Define, Indexer.Define, Method.Define): Validate that
10912 the given interface in the explicit implementation is one of the
10913 base classes for the containing type.
10915 Also if we are explicitly implementing an interface, but there is
10916 no match in the pending implementation table, report an error.
10918 (Property.Define): Only define the property if we are
10919 not explicitly implementing a property from an interface. Use the
10920 correct name also for those properties (the same CSC uses,
10921 although that is really not needed).
10923 (Property.Emit): Do not emit attributes for explicitly implemented
10924 properties, as there is no TypeBuilder.
10926 (Indexer.Emit): ditto.
10928 Hiding then means that we do not really *implement* a pending
10929 implementation, which makes code fail.
10931 2002-06-22 Martin Baulig <martin@gnome.org>
10933 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
10934 the return value of Object.GetType(). [FIXME: we need to do this whenever
10935 we get a type back from the reflection library].
10937 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
10939 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
10941 2002-06-20 Miguel de Icaza <miguel@ximian.com>
10943 * attribute.cs: Return null if we can not look up the type.
10945 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
10946 the interface types found.
10948 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
10949 interface types found.
10951 * typemanager.cs (GetInterfaces): Make this routine returns alll
10952 the interfaces and work around the lame differences between
10953 System.Type and System.Reflection.Emit.TypeBuilder in the results
10954 result for GetInterfaces.
10956 (ExpandInterfaces): Given an array of interface types, expand and
10957 eliminate repeated ocurrences of an interface. This expands in
10958 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
10961 2002-06-21 Martin Baulig <martin@gnome.org>
10963 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
10966 2002-06-21 Martin Baulig <martin@gnome.org>
10968 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
10969 and called with one of the core types, return the corresponding typebuilder for
10972 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
10975 2002-06-21 Martin Baulig <martin@gnome.org>
10977 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
10978 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
10979 (Expression.ConvertReferenceExplicit): Likewise.
10981 * expression.cs (ElementAccess.DoResolve): Likewise.
10982 (ElementAccess.DoResolveLValue): Likewise.
10984 2002-06-10 Martin Baulig <martin@gnome.org>
10986 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
10987 add the "value" parameter to the parameter list.
10989 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
10992 2002-06-19 Miguel de Icaza <miguel@ximian.com>
10994 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
10995 the argument to an int, uint, long or ulong, per the spec. Also
10996 catch negative constants in array creation.
10998 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
11000 * class.cs: do not allow the same interface to appear twice in
11001 the definition list.
11003 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
11005 * ecore.cs: don't use ldlen with System.Array.
11007 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
11009 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
11011 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
11013 * modifiers.cs: produce correct field attributes for protected
11014 internal. Easy fix so miguel can work on ther harder stuff:-)
11016 2002-06-18 Miguel de Icaza <miguel@ximian.com>
11018 * pending.cs: New file. Move the code from class.cs here.
11019 Support clearning the pending flag for all methods (when not doing
11020 explicit interface implementation).
11022 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
11024 * rootcontext.cs: added a couple more types needed to bootstrap.
11026 2002-06-17 Miguel de Icaza <miguel@ximian.com>
11028 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
11029 constructor in the type, instead of any constructor in the type
11030 hierarchy. Thanks to Paolo for finding this bug (it showed up as
11031 a bug in the Mono runtime when applying the params attribute).
11033 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
11034 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
11036 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
11038 * expression.cs (Unary.ResolveOperator): Use TypeManager
11039 to resolve the type.
11041 2002-06-13 Ravi Pratap <ravi@ximian.com>
11043 * cs-parser.jay (enum_member_declaration): Pass in the attributes
11046 * enum.cs (AddEnumMember): Add support to store the attributes associated
11047 with each member too.
11049 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
11050 field builders too - this takes care of the enum member case.
11052 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
11054 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
11055 address-of operator on both value types and pointers.
11057 2002-06-10 Martin Baulig <martin@gnome.org>
11059 * interface.cs (Interface.PopulateIndexer): Add the indexer's
11060 PropertyBuilder to the `property_builders' list.
11062 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
11063 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
11064 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
11065 find any indexers which are inherited from an interface.
11067 2002-06-09 Martin Baulig <martin@gnome.org>
11069 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
11070 the same type as the constant if necessary. There's also a test-130.cs
11073 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
11075 * typemanager.cs (TypeManager.ChangeType): Previously known as
11076 Enum.ChangeEnumType().
11078 2002-06-09 Martin Baulig <martin@gnome.org>
11080 * expression.cs (Cast.TryReduce): Added support for consts.
11082 2002-06-08 Ravi Pratap <ravi@ximian.com>
11084 * class.cs (Accessor): Hold attributes information so we can pass
11087 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
11088 Modify to pass in attributes attached to the methods.
11090 (add_accessor_declaration, remove_accessor_declaration): Ditto.
11092 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
11093 to handle the Accessor kind :-)
11095 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
11097 2002-06-08 Martin Baulig <martin@gnome.org>
11099 * expression.cs (Unary.TryReduceNegative): Added support for
11102 2002-06-08 Martin Baulig <martin@gnome.org>
11104 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
11105 name can't be found in the `defined_names' - the caller will do a
11106 MemberLookup in this case and thus find methods in System.Enum
11107 such as Enum.IsDefined().
11109 2002-06-08 Martin Baulig <martin@gnome.org>
11111 * enum.cs (Enum.ChangeEnumType): This is a custom version of
11112 Convert.ChangeType() which works with TypeBuilder created types.
11113 (Enum.LookupEnumValue, Enum.Define): Use it here.
11115 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
11116 `TypeBuilder.BaseType != null' check.
11117 (TypeContainer.FindMembers): Only lookup parent members if we
11118 actually have a parent.
11119 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11120 (ConstructorInitializer.Resolve): Likewise.
11122 * interface.cs (Interface.FindMembers): Added
11123 `TypeBuilder.BaseType != null' check.
11125 * rootcontext.cs (RootContext.ResolveCore): Added
11126 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11127 classes_second_stage.
11129 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11130 debug_type and trace_type when compiling with --nostdlib.
11132 2002-06-07 Martin Baulig <martin@gnome.org>
11134 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11135 (AddField): Set it to true when adding a non-static field.
11136 (DefineType): Use `have_nonstatic_fields' to find out whether we
11137 have non-static fields, not `Fields != null'.
11139 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11141 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11142 dereferencing a null on the static-field code path)
11144 2002-05-30 Martin Baulig <martin@gnome.org>
11146 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11147 to take command line arguments. Use reflection to call the new
11148 custom `Initialize' function on the symbol writer and pass it the
11149 command line arguments.
11151 * driver.cs (--debug-args): New command line argument to pass command
11152 line arguments to the symbol writer.
11154 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11156 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11157 the target type for indexers and properties. Thanks to Joe for
11160 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11162 * typemanager.cs (MethodFlags): returns the method flags
11163 (Obsolete/ShouldIgnore) that control warning emission and whether
11164 the invocation should be made, or ignored.
11166 * expression.cs (Invocation.Emit): Remove previous hack, we should
11167 not do this on matching a base type, we should do this based on an attribute
11169 Only emit calls to System.Diagnostics.Debug and
11170 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11171 on the command line.
11173 * rootcontext.cs: Global settings for tracing and debugging.
11175 * cs-tokenizer.cs (define): New utility function to track
11176 defines. Set the global settings for TRACE and DEBUG if found.
11178 2002-05-25 Ravi Pratap <ravi@ximian.com>
11180 * interface.cs (Populate*): Pass in the TypeContainer as well as
11181 the DeclSpace as parameters so that we can create EmitContexts and
11182 then use that to apply attributes etc.
11184 (PopulateMethod, PopulateEvent, PopulateProperty)
11185 (PopulateIndexer): Apply attributes everywhere.
11187 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11190 (ApplyAttributes): Update accordingly.
11192 We now apply interface attributes for all members too.
11194 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11196 * class.cs (Indexer.Define); Correctly check if we are explicit
11197 implementation (instead of checking the Name for a ".", we
11198 directly look up if the InterfaceType was specified).
11200 Delay the creation of the PropertyBuilder.
11202 Only create the PropertyBuilder if we are not an explicit
11203 interface implementation. This means that explicit interface
11204 implementation members do not participate in regular function
11205 lookups, and hence fixes another major ambiguity problem in
11206 overload resolution (that was the visible effect).
11208 (DefineMethod): Return whether we are doing an interface
11211 * typemanager.cs: Temporary hack until we get attributes in
11212 interfaces (Ravi is working on that) and we get IndexerName
11213 support in interfaces.
11215 * interface.cs: Register the indexers as properties.
11217 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11218 warning, I have verified that this is a bug in the .NET runtime
11219 (JavaScript suffers of the same problem).
11221 * typemanager.cs (MemberLookup): When looking up members for
11222 interfaces, the parent of an interface is the implicit
11223 System.Object (so we succeed in searches of Object methods in an
11224 interface method invocation. Example: IEnumerable x; x.ToString
11227 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11229 * class.cs (Event): Events should also register if they do
11230 implement the methods that an interface requires.
11232 * typemanager.cs (MemberLookup); use the new GetInterfaces
11235 (GetInterfaces): The code used to lookup interfaces for a type is
11236 used in more than one place, factor it here.
11238 * driver.cs: Track the errors at the bottom of the file, we kept
11241 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11242 instance if the method we are calling is static!
11244 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11246 * attribute.cs (ApplyAttributes): Make this function filter out
11247 the IndexerName attribute (as that attribute in reality is never
11248 applied) and return the string constant for the IndexerName
11251 * class.cs (TypeContainer.Emit): Validate that all the indexers
11252 have the same IndexerName attribute, and if so, set the
11253 DefaultName attribute on the class.
11255 * typemanager.cs: The return value might contain other stuff (not
11256 only methods). For instance, consider a method with an "Item"
11257 property and an Item method.
11259 * class.cs: If there is a problem with the parameter types,
11262 2002-05-24 Ravi Pratap <ravi@ximian.com>
11264 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11265 looks at user defined conversion after making a call to
11266 StandardConversionExists - we need this for overload resolution.
11268 * expression.cs : Update accordingly the various method calls.
11270 This fixes 2 bugs filed against implicit user defined conversions
11272 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11274 * statement.cs: Track the result of the assignment.
11276 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11278 * expression.cs (MemberAccess): Improved error reporting for
11279 inaccessible members.
11281 2002-05-22 Martin Baulig <martin@gnome.org>
11283 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11284 itself with debugging support.
11286 2002-05-22 Martin Baulig <martin@gnome.org>
11288 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11289 Removed, this isn't needed anymore.
11291 2002-05-20 Martin Baulig <martin@gnome.org>
11293 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11294 be underlying type for an enum.
11296 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11298 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11299 that splits out the loading of just the core types.
11301 * rootcontext.cs (ResolveCore): Split the struct resolution in
11302 two, so we can load the enumeration underlying types before any
11305 * expression.cs (Is): Bandaid until we fix properly Switch (see
11306 bug #24985 for details).
11308 * typemanager.cs (ImplementsInterface): The hashtable will contain
11309 a null if there are no interfaces implemented.
11311 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11313 * cs-parser.jay (indexer_declarator): It is fine to have array
11316 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11318 * typemanager.cs: (RegisterBuilder): New function used to register
11319 TypeBuilders that implement interfaces. Since
11320 TypeBuilder.GetInterfaces (as usual) does not work with lame
11322 (AddUserType): register interfaces.
11324 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11325 dealing with TypeBuilder. Also, arrays are showing up as
11326 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11327 methods can not be invoked on them!
11329 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11330 (ImplicitReferenceConversionExists): Split out from
11331 StandardConversionExists.
11333 * expression.cs (As): We were only implementing one of the three
11334 cases for the as operator. We now implement them all.
11335 (Is): Implement the various other cases for Is as well.
11337 * typemanager.cs (CACHE): New define used to control if we want or
11338 not the FindMembers cache. Seems to have a negative impact on
11339 performance currently
11341 (MemberLookup): Nested types have full acess to
11342 enclosing type members
11344 Remove code that coped with instance/static returns for events, we
11345 now catch this in RealFindMembers.
11347 (RealFindMembers): only perform static lookup if the instance
11348 lookup did not return a type or an event.
11350 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11352 * assign.cs (CompoundAssign): We pass more semantic information
11353 now to Compound Assignments than we did before: now we have all
11354 the information at hand, and now we resolve the target *before* we
11355 do the expression expansion, which allows the "CacheValue" method
11356 to have the effect we intended (before, a [x] += 1 would generate
11357 two differen ArrayAccess expressions from the ElementAccess,
11358 during the resolution process).
11360 (CompoundAssign.DoResolve): Resolve target and original_source here.
11362 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11364 * expression.cs (ArrayAccess): dropped debugging information.
11366 * typemanager.cs: Small bug fix: I was always returning i_members,
11367 instead of one of i_members or s_members (depending on which had
11370 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11371 method is invoked before any code generation takes place, and it
11372 is a mechanism to inform that the expression will be invoked more
11373 than once, and that the method should use temporary values to
11374 avoid having side effects
11376 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11378 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11381 * expression.cs (Indirection, ArrayAccess): Add support for
11382 CacheTemporaries in these two bad boys.
11384 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11385 ldobj or ldind_ref.
11386 (StoreFromPtr): Handle stobj as well.
11388 * expression.cs (UnaryMutator): Share more code.
11390 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11391 down: I was not tracking the Filter function as well, which
11392 was affecting the results of the cache.
11394 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11396 * attribute.cs: Remove the hack to handle the CharSet property on
11399 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11401 * attribute.cs (DoResolve): More uglyness, we now only try to
11402 resolve the attribute partially, to extract the CharSet
11403 information (only if we are a StructLayout attribute). Otherwise
11405 (GetExtraTypeInfo): Add some code to conditionally kill in the
11406 future this. I am more and more convinced that the .NET
11407 framework has special code to handle the attribute setting on
11410 * expression.cs (IsParamsMethodApplicable): Revert my previous
11411 foreach change here, it was wrong.
11413 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11415 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11416 (pp_expr): do not abort on unknown input, just return.
11417 (eval): abort if there are pending chars.
11419 * attribute.cs (Attribute.Resolve): Positional parameters are
11420 optional. Deal with that case.
11422 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11423 the Ansi/Unicode/Auto information for the type.
11425 (TypeContainer.DefineType): instantiate the EmitContext here, as
11426 we will be using it during the type definition (to resolve
11427 attributes) and during the emit phase.
11429 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11430 to pull type information out of the attributes
11432 (Attribute.Resolve): track the constructor builder, and allow for
11433 multiple invocations (structs and classes will use this).
11435 * ecore.cs (MemberLookupFinal): new version with all the
11436 parameters customizable.
11438 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11439 constructors. Return if the result value is null (as the error
11440 would have been flagged already by MemberLookupFinal)
11442 Do not allow instances of abstract classes or interfaces to be
11445 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11446 We have to compare the assembly property here when dealing with
11447 FamANDAssem and Assembly access modifiers, because we might be
11448 creating an assembly from *modules* (that means that we are not
11449 getting TypeBuilders for types defined in other modules that are
11450 part of this assembly).
11452 (Method.Emit): If the method is marked abstract and has a body,
11455 (TypeContainer.DefineMembers): If both the defined member and the
11456 parent name match are methods, then do not emit any warnings: let
11457 the Method.Define routine take care of flagging warnings. But if
11458 there is a mismatch (method overrides something else, or method is
11459 overriwritten by something, then emit warning).
11461 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11462 set to null, this means `do not check for the return type on the
11465 (Method.Define): set the return type for the method signature to
11466 null, so that we get methods with the same name and parameters and
11467 different return types. This is used to flag warning 114 (you are
11468 hiding a method, and you probably want to use the new/override
11471 * typemanager.cs (MemberLookup): Implemented proper access
11472 control, closing a long standing set of bug reports. The problem
11473 was that the Framework only has two bits: Public and NonPublic,
11474 and NonPublic includes private and protected methods, but we need
11475 to enforce the FamANDAssem, FamOrAssem and Family.
11477 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11479 * statement.cs (GotoCase): Return true: Ammounts to giving up
11480 knowledge on whether we return or not, and letting the other case
11481 be responsible for it.
11483 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11485 * driver.cs: Do not load directories for each file processed, only
11486 do it if there is a pattern.
11488 * ecore.cs: Report readonly assigns here as well, as we might have
11489 been resolved only by MemberAccess.
11491 (SimpleName.SimpleNameResolve): Also be useful for LValue
11492 resolution. We need this to propagate assign to local readonly variables
11494 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11495 do not want to reuse potential criteria memory.
11497 * class.cs (MyEventBuilder): Set reflected_type;
11499 * ecore.cs (Constantify): Added support for constifying bools.
11501 (RootContext.LookupType): Added a cache for values looked up in
11502 the declaration space.
11504 * typemanager.cs (FindMembers): Now is a front-end to
11505 RealFindMembers, and provides a two-level hashtable-based cache to
11508 15% performance improvement: from 22.5 to 19.2 seconds.
11510 * expression.cs (IsParamsMethodApplicable): use foreach.
11511 (Invocation.DoResolve): ditto.
11512 (New.DoResolve): ditto.
11513 (ArrayCreation.DoResolve): ditto.
11515 * ecore.cs (FindMostEncompassingType): use foreach.
11517 * delegate.cs (NewDelegate.DoResolve): Use foreach
11519 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11520 (RemoveMethods): use foreach.
11522 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11523 nested foreach statements instead of for, and also break out of
11524 the inner loop once a match is found.
11526 (Invocation.OverloadResolve): Use foreach, simplify the code.
11528 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11530 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11531 we actually unwrap the expression to allow for extra information
11534 * expression.cs: Use Shr_Un on unsigned operations.
11536 2002-05-08 Ravi Pratap <ravi@ximian.com>
11538 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11539 applicable operators was not being considered correctly. This closes
11540 the bug Miguel reported.
11542 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11544 * attribute.cs: check that the type derives from System.Attribute
11545 and report the correct error in that case (moved the duplicate code to
11546 its own method, too).
11548 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11550 * attribute.cs: lookup attribute type name as the spec says: first the
11551 bare attribute name and then name + "Attribute" (nant compiles with
11552 mcs after this fix).
11554 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11556 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11557 Because of the way we parse things, we should try to see if a
11558 UIntConstant can fit in an integer.
11560 2002-05-07 Ravi Pratap <ravi@ximian.com>
11562 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11563 when we are in an explicit context.
11565 (ConvertReferenceExplicit): When converting from Iface type S to Class
11566 T make sure the rules are implemented as an OR.
11568 * parameter.cs (ParameterType): Make it a property for now although the
11569 purpose really isn't anything immediate.
11571 * expression.cs (Is*Applicable): Do better checking on the parameter type
11572 of a ref/out parameter. The ones from the system assemblies are already
11573 marked with the correct type so we don't need to do any correction.
11575 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11576 the object type is standard too so include that.
11578 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11580 * ecore.cs (StandardConversionExists): Augment with missing code:
11581 deal with IntConstant, LongConstants and Enumerations.
11583 * assign.cs: Report the error, instead of failing silently
11585 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11586 typecontainer that they are declared, because the
11587 typecontainer/namespace will have the list of using clauses that
11588 need to be applied.
11590 Assembly Attributes were escaping the normal registration
11593 (EmitCode): Apply attributes within an EmitContext that represents
11594 the container they were declared on.
11596 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11598 2002-05-06 Ravi Pratap <ravi@ximian.com>
11600 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11601 Revamp completely - make much cleaner as we now operate only
11604 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11605 to implement the logic detailed in the spec more correctly.
11607 (UserDefinedConversion): Update accordingly.
11609 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11611 * statement.cs: Return flow analysis information up.
11613 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11616 (token): Do not consume an extra character before calling
11619 2002-05-06 Piers Haken <piersh@friskit.com>
11621 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11623 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11625 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11626 EmitContext during the instance constructor initializer
11627 resolution, to stop access to instance variables.
11629 This is mandated by the spec, last paragraph of the `constructor
11630 initializers' section.
11632 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11634 * cs-parser.jay, class.cs (Accessor): new class used to represent
11635 an accessor (get or set). In the past we used `null' to represent
11636 a missing accessor. But this is ambiguous because there was no
11637 way to tell in abstract indexers/properties if one of them was
11640 Now there is a way of addressing that.
11642 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11643 instead of FindMembers.
11645 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11646 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11648 * attribute.cs: Treat indexers and properties as the same in terms
11649 of applying attributes
11651 * ecore.cs (FindMostEncompassedType): Use statically initialized
11652 EmptyExpressions()s like we do elsewhere to avoid creating useless
11653 objects (and we take this out of the tight loop).
11655 (GetConversionOperators): Move the code to extract the actual
11656 operators to a separate routine to clean things up.
11658 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11660 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11661 events are always registered FieldBuilders.
11663 * class.cs (FieldBase): New class shared by Fields
11665 * delegate.cs: If we are a toplevel delegate, use our full name.
11666 If we are a nested delegate, then only use our tail name.
11668 2002-05-02 Ravi Pratap <ravi@ximian.com>
11670 * expression.cs (IsApplicable): Ensure that we add the "&" to
11671 ref/out types before comparing it with the type of the argument.
11673 (IsParamsMethodApplicable): Ditto.
11675 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11678 * delegate.cs : Handle the case when we have more than one applicable
11679 method. Flag an error only when we finish checking all.
11681 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11683 * expression.cs: Add support for boolean static initializers.
11685 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11687 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11689 * parameter.cs (ComputeParameterTypes,
11690 ComputeAndDefineParameterTypes): Better error handling: now we
11691 clear the `types' cache if we fail during any of the type lookups.
11692 We also return the status code correctly to our caller
11694 * delegate.cs: If we fail to define a delegate, abort the extra
11697 * expression.cs (Binary.ResolveOperator): for
11698 operator==(object,object) and operator !=(object, object) we also
11699 have to verify that there is an implicit conversion from one to
11702 (ArrayAccess.DoResolve): Array Access can operate on
11705 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11707 * assign.cs (CompoundAssign): A new class used as a "flag" that
11708 the assignment actually is happening as part of a compound
11709 assignment operator.
11711 During compound assignment, a few new rules exist to enable things
11718 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11719 to the type of x) if y is implicitly convertible to the type of x,
11720 and the operator is a builtin operator and the return type of the
11721 operator is explicitly convertible to the type of x.
11723 * rootcontext.cs: Reset warning level to 2. 4 catches various
11724 "interesting" features in mcs, we must clean this up at some
11725 point, but currently am trying to kill other bugs ;-)
11727 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11728 in container classes as well.
11730 * expression.cs (Binary.ResolveOperator): Handle string case
11731 before anything else (as operator overloading does emit an error
11732 before doing anything else).
11734 This code could go away when we move to a table driven model, but
11735 i could not come up with a good plan last night.
11737 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11739 * typemanager.cs (CSharpName): reimplementation using regex.
11740 * class.cs: added null check for fields in Emit
11741 * rootcontext.cs: set warninglevel to 4
11743 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11745 * typemanager.cs (CSharpName): reimplemented with Lupus
11748 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11750 * statement.cs (If): correclty implement Resolve, because we were
11751 not catching sem errors in there. The same process is needed
11753 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11756 (Statement.Warning_DeadCodeFound): Factorize code.
11757 (While): Report dead code here too.
11759 (Statement): Added Resolve virtual method to allow
11760 for resolution split from the emit code.
11762 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11764 * statement.cs (EmitBoolExpression): No longer try to resolve the
11766 (MakeBoolean): New utility function that resolve, implicitly
11767 converts to boolean and tags the expression.
11770 (If, Do): Implement dead code elimination.
11771 (While): Implement loop inversion
11773 (Do, While, For, If): Resolve the expression prior to calling our
11776 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11779 - added method Report28 (warning: program has more than one entry point)
11780 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11781 - modified method Method.Define, the part at the end of the method
11783 * rootcontext.cs: added static public Location EntryPointLocation;
11785 * ../errors/cs0028.cs : Add test case for the above warning.
11788 - modified method CSharpName to allow arrays of primitive type to
11789 be printed nicely (e.g. instead of System.Int32[][] it now prints
11791 - added method CSharpSignature: returns the signature of a method
11792 in string format to be used in reporting errors, warnings, etc.
11794 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11797 2002-04-26 Ravi Pratap <ravi@ximian.com>
11799 * delegate.cs (Define): Fix extremely silly bug where I was
11800 setting the type of the 'object' parameter of the BeginInvoke
11801 method to System.IAsyncResult instead of System.Object ;-)
11803 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11805 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11808 (Constructor.Emit): return if we fail to initialize the
11809 constructor. Another door closed!
11811 * expression.cs (New.DoResolve): Improve error message (from -6 to
11812 1501). Use DeclaredOnly lookup to find the exact constructor.
11814 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11815 loop. This is useful.
11817 * cs-parser.jay: Adjust the default parameters so that destructors
11818 have the proper signature.
11820 2002-04-26 Martin Baulig <martin@gnome.org>
11822 * driver.cs (LoadAssembly): If `assembly' contains any characters
11823 which are only valid in path names and not in assembly names
11824 (currently slash, backslash and point), use Assembly.LoadFrom ()
11825 instead of Assembly.Load () on the `assembly' (before iteration
11826 over the link_paths).
11828 2002-04-26 Martin Baulig <martin@gnome.org>
11830 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11832 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11834 * class.cs (Property): use the new typemanager.MemberLookup
11836 (TypeContainer.MemberLookup): Implement using the
11837 TypeManager.MemberLookup now.
11839 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11840 and return MemberInfos, so that these can be used without an
11841 EmitContext (what we had before).
11843 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11845 * expression.cs: Fix the case where the argument to params if the
11846 type of the params. I omitted handling this before. Fixed
11848 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11850 * driver.cs: Call BootCorlib_PopulateCoreType
11852 * class.cs (Property.CheckBase): Check for properties only, not
11855 * interface.cs: Temporary hack: try/catch around the
11856 CustomAttributeBuilder, because I am getting an exception that I
11859 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11860 types whose definitions are required to be there (attributes are
11861 defined before standard types).
11863 Compute definitions as we boot the various types, as they are used
11864 immediately (value_type class will need object_type, but if we do
11865 not initialize object_type, we will pass a null, which will let
11866 the runtime pick the System.Object from the existing corlib, which
11867 is not what we want).
11869 2002-04-22 Patrik Torstensson <totte@labs2.com>
11871 * cs-tokenizer.cs: fixed a number of trim() issues.
11873 2002-04-22 Ravi Pratap <ravi@ximian.com>
11875 * expression.cs (Argument.Type): Ensure that we return the correct
11876 type when we have out or ref parameters [in which case we
11879 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11881 * class.cs (Property, Indexer): Allow extern modifier in there.
11883 * typemanager.cs (InitBaseTypes): Initializes object_type and
11884 value_type, since those will be used early on during the bootstrap
11885 process to compile corlib.
11887 (InitCoreTypes): Move code from here to InitBaseTypes.
11889 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11891 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11892 single-dimension arrays as using the ldlen opcode.
11894 Daniel Lewis discovered this optimization.
11896 * typemanager.cs: Add signature for System.Array::get_Length
11898 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11900 * statement.cs: report the error when the foreach does not apply to an
11901 array nor a collection.
11903 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11905 * expression.cs: Add implicit conversions to the operator ~.
11907 * constant.cs (DecimalConstant.Emit): Emit decimal value.
11909 * typemanager.cs: Locate the decimal constructor.
11911 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11913 * attribute.cs: use the new property of TypeOf.
11914 * expression.cs: added 'get' property around typearg.
11916 These changes fix a build breaker reported by NickD. Is this the
11917 correct way to fix? If not, please, revert my changes and make it
11920 2002-04-17 Miguel de Icaza <miguel@ximian.com>
11922 * attribute.cs: Add support for typeof in attribute invocations.
11923 I am not sure that this is right though.
11925 2002-04-14 Duncan Mak <duncan@ximian.com>
11927 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
11928 Binary.Operator.Division case.
11930 2002-04-13 Ravi Pratap <ravi@ximian.com>
11932 * class.cs (DefineType): Ensure that we do a proper check on
11933 attribute types and also register it with the TypeManager.
11935 (TypeContainer.Targets): The default for attribute types is
11936 AttributeTargets.All.
11938 * attribute.cs (ApplyAttributes): Registering the attribute type
11939 is done elsewhere, not when we discover we have a Usage attribute.
11941 2002-04-12 Ravi Pratap <ravi@ximian.com>
11943 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
11944 and get rid of is_delegate parameter.
11946 * everywhere : update.
11948 2002-04-12 Ravi Pratap <ravi@ximian.com>
11950 * cs-parser.jay (compilation_unit): Revamp completely to use
11951 some new ideas that I got from Rhys' grammar to solve the problems
11952 with assembly level attributes.
11954 (outer_declaration): New grammar production.
11956 (attribute_sections): Add.
11958 (opt_attributes): Base on attribute_sections
11960 (namespace_declaration): Allow opt_attributes to tackle the case
11961 when we have assembly level attributes - we are clever in this
11964 * attribute.cs (ApplyAttributes): Do not worry about assembly
11965 attributes in the non-global context.
11967 * rootcontext.cs (AddGlobalAttributes): Go back to using this
11968 instead of SetGlobalAttributes.
11970 * class.cs, rootcontext.cs : Ensure we define and generate
11971 attribute types before anything else.
11973 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
11974 and flag the new error -20 for the case when the attribute type
11975 does not have valid targets specified. csc does not catch this.
11977 * ../errors/errors.txt : update for error # -20
11979 2002-04-11 Ravi Pratap <ravi@ximian.com>
11981 * support.cs (InternalParameters.ParameterModifier): Do some null
11982 checking and return sane values.
11984 * class.cs (Method.Define): If we are a PInvoke method, ensure
11985 that we are static and extern. Report error # 601
11987 * ../errors/cs0601.cs : Add test case for the above error.
11989 2002-04-07 Ravi Pratap <ravi@ximian.com>
11991 * rootcontext.cs (attribute_types): We need to keep type of
11992 all attribute types separately and emit code for them first.
11994 (RegisterAttribute) : Implement.
11996 * class.cs (DefineType): Check if the current Type is a custom
11997 attribute type and register it accordingly.
11999 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
12000 adding the first attribute twice and rename to
12002 (SetGlobalAttributes): this.
12004 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
12007 * attribute.cs (ApplyAttributes): Take an additional argument telling us
12008 if we are processing global arguments. Hmm, I am unsure of this.
12010 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
12012 * expression.cs: added static array of strings to avoid calling
12013 Enum.ToString () for Operator in Binary. Significant recover of
12016 2002-04-10 Miguel de Icaza <miguel@ximian.com>
12018 * class.cs (FindMembers): Allow the Builders of the various
12019 members to be null. If they are skip them. This only happens
12020 during the PInvoke declaration.
12022 2002-04-09 Miguel de Icaza <miguel@ximian.com>
12024 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
12025 failure, so we do not keep going afterwards.
12027 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
12028 wanted to pass `false' as the `is_delegate' argument. If this is
12029 the case, why not use delegate_type == null to mean `is_delegate =
12030 false' and anything else as is_delegate = true.
12032 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
12034 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
12035 code for the section, not the beginning of the tests.
12037 2002-04-08 Miguel de Icaza <miguel@ximian.com>
12039 * cfold.cs: Handle operator + (Enum x, Underlying x)
12041 * expression.cs (Binary): same. Warn about errors where we have
12042 Enum/Enum in operator + as well.
12044 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
12047 - added support for switch(bool)
12048 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
12049 - add TableSwitchEmit() to handle table-based switch statements
12051 2002-04-05 Ravi Pratap <ravi@ximian.com>
12053 * expression.cs (Invocation.OverloadResolve): Factor out code which
12054 does parameter compatibility checking with arguments so that we can
12055 re-use the code even from Delegate.VerifyApplicability
12057 (VerifyArgumentsCompat): Move above code here.
12059 * delegate.cs (VerifyApplicability): Get rid of duplicate code
12060 and instead make a call to the above method.
12062 2002-03-31 Ravi Pratap <ravi@ximian.com>
12064 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
12065 We use it to keep track of classes which are attribute types.
12067 2002-04-02 Miguel de Icaza <miguel@ximian.com>
12069 * delegate.cs (Delegate.Define): Correctly define the types in the
12070 presence of fixed and array parameters.
12072 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
12075 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
12076 include NonPublic after the first iteration.
12078 * class.cs (Indexer.CheckBase): Only check if both parents are
12081 * cs-parser.jay (accessor_body): If empty, set to null.
12083 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
12084 same code path here to resolve constants names that we did have in
12085 MemberAccess.DoResolve. There is too much code duplicated here.
12087 2002-04-01 Miguel de Icaza <miguel@ximian.com>
12089 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
12091 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
12094 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
12095 tokens, numbers and strings.
12097 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
12100 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
12101 asyncronous parameters and the regular parameters.
12103 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
12104 specify the target directory.
12106 * expression.cs: (This.DoResolve): Simplify
12107 (As.Emit): Optimize, do not generate IsInst if the expression is
12108 always of the given type.
12110 (Is.DoResolve): Bug fix, we were reporting both always/never for
12113 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
12114 creating too many unnecessary arrays.
12116 2002-03-31 Miguel de Icaza <miguel@ximian.com>
12118 * class.cs (EmitFieldInitializer): Use Assign expression to assign
12119 fields instead of rolling our own initializer. Takes care of all
12120 implicit conversions, and drops unnecessary static checks/argument.
12122 2002-03-31 Dick Porter <dick@ximian.com>
12124 * driver.cs: use the GetDirectories() return values properly, and
12125 use "/" as path separator.
12127 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12129 * expression.cs (Unary): Optimize - - expr into expr.
12130 (Binary): Optimize a + (-b) into a -b.
12132 * codegen.cs (CodeGen): Made all methods static.
12134 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12138 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12139 TypeBuilder property.
12141 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12144 * tree.cs: Removed the various RecordXXXX, and replaced with a
12145 single RecordDecl. Removed all the accessor methods, and just
12146 left a single access point Type
12148 * enum.cs: Rename DefineEnum to DefineType.
12150 * decl.cs: New abstract method `DefineType' used to unify the
12151 Defines for Enumerations, Interfaces, TypeContainers and
12154 (FindType): Moved LookupInterfaceOrClass here. Moved the
12155 LookupBaseClasses method that used to live in class.cs and
12156 interface.cs here, and renamed to FindType.
12158 * delegate.cs: Implement DefineType. Take advantage of the
12159 refactored pattern for locating the parent builder without taking
12160 the parent_builder argument (which we know does not work if we are
12161 nested, and triggering a toplevel definition).
12163 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12165 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12166 accessibility of a member has changed during override and report
12169 * class.cs (Method.Define, Property.Define): Only complain on
12170 overrides if the method is private, any other accessibility is
12171 fine (and since we just checked the permission is the same, we are
12174 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12175 and elif are processed always. The other pre-processing
12176 directives are only processed if we are "taking" the path
12178 2002-03-29 Martin Baulig <martin@gnome.org>
12180 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12181 current location is not Null.
12183 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12184 a separate method so we can profile it.
12186 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12187 `span.Seconds' are just seconds, but no minutes or hours.
12188 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12190 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12192 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12193 Remove the gratuitous set of Final:
12195 // If an interface implementation, then we can set Final.
12196 if (((flags & MethodAttributes.Abstract) == 0) &&
12197 implementing.DeclaringType.IsInterface)
12198 flags |= MethodAttributes.Final;
12200 I do not know what I was smoking when I used that.
12203 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12204 step into fixing the name resolution issues for delegates and
12205 unifying the toplevel name resolution.
12207 2002-03-28 Martin Baulig <martin@gnome.org>
12209 * class.cs (Method.Emit): If we have a symbol writer, call its
12210 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12211 tell it about the current method.
12213 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12214 writer that we're going to emit the first byte of IL code for a new
12215 statement (a new source line).
12216 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12217 EmitContext.Mark() before emitting any code.
12219 * location.cs (SymbolDocument): Return null when we're Null.
12221 * statement.cs (Statement): Moved the `Location loc' variable here.
12222 (Statement.EmitBoolExpression): If we have a symbol writer, call
12223 ec.Mark() before emitting any code to tell it that we're at the
12224 beginning of a new statement.
12225 (StatementExpression): Added `Location' argument to the constructor.
12226 (Block): Added public readonly variable `StartLocation' and public
12227 variable `EndLocation'. The latter is to be set using SetEndLocation().
12228 (Block): Added constructor which takes a start and end location.
12229 (Block.SetEndLocation): New method. This sets the end location.
12230 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12231 local variables we create.
12232 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12233 each statement and do also mark the begin and end of the block.
12235 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12236 tell it the current lexer.Location, use Location.Null for the end of the
12238 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12239 current block, set its end location using SetEndLocation().
12240 (statement_expression): StatementExpression constructor now takes the
12241 lexer.Location as additional argument.
12242 (for_statement, declare_local_variables): Likewise.
12243 (declare_local_variables): When creating a new implicit block, use the
12244 new Block constructor and pass it the lexer.Location.
12246 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12248 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12249 members also on the parent interfaces recursively.
12251 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12253 * report.cs: Use new formats, since Gonzalo finished the missing
12256 * expression.cs (Binary.ResolveOperator): added missing operator|
12257 operator& and operator^ for bool/bool.
12259 * cs-parser.jay: CheckDef now takes a Location argument that is
12260 used to report errors more precisly (instead of reporting the end
12261 of a definition, we try to track something which is a lot closer
12262 to the source of the problem).
12264 * cs-tokenizer.cs: Track global token use, so we can properly flag
12265 the use of #define/#undef after the first token has been seen.
12267 Also, rename the reportXXXX to Error_DescriptiveName
12269 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12270 TypeContainer, so that Enum and Interface can use this too.
12272 * class.cs (TypeContainer.LookupInterfaceOrClass,
12273 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12274 `builder' argument. Typically this was used to pass the parent
12275 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12278 The problem is that a nested class could trigger the definition of
12279 a toplevel class, and the builder would be obviously wrong in that
12282 So we drop this argument, and we compute dynamically the
12283 TypeBuilder/ModuleBuilder (the correct information was available
12284 to us anyways from DeclSpace.Parent)
12286 * interface.cs (Interface.DefineInterface): Drop builder
12287 parameter cleanup like class.cs
12289 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12292 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12295 (Try.Emit): Propagate the returns value from the statement.
12297 (Return.Emit): Even if we are leavning
12299 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12301 * modifiers.cs: Fix the computation of MethodAttributes flags.
12303 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12305 * driver.cs: allow compilation of files that start with '/'.
12306 Add a default case when checking the argument of --target.
12308 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12310 * interface.cs: Implement the same search algorithm for types in
12311 the interface code.
12313 * delegate.cs: Do not allow multiple definition.
12315 * Recovered ChangeLog that got accidentally amputated
12317 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12319 * rootcontext.cs: Load manually enum to allow core classes to
12320 contain enumerations.
12322 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12323 Update to new static methods in TypeManager.
12325 * typemanager.cs (GetMethod, GetConstructor): Use our
12326 implementation of FindMembers to find the members, since during
12327 corlib compilation, the types are TypeBuilders and GetMethod and
12328 GetConstructor do not work.
12330 Make all methods in TypeManager static.
12332 (InitCodeHelpers): Split the functionality from
12333 the InitCodeTypes function.
12335 * driver.cs: Call InitCodeHelpers after we have populated the
12338 * cs-parser.jay (delegate_declaration): we did not used to compute
12339 the delegate name correctly for void delegates.
12341 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12343 * rootcontext.cs (RootContext): Init the interface_resolve_order
12344 and type_container_resolve_order always.
12346 (ResolveCore, BootstrapCorlib_ResolveClass,
12347 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12348 compiler when compiling with --nostdlib
12350 * class.cs (TypeContainer.DefineType): Check that our parent is
12351 not null. This test is most important when we are bootstraping
12354 * codegen.cs: Split out the symbol writing code.
12356 2002-03-25 Martin Baulig <martin@gnome.org>
12358 * driver.cs (-g): Made -g an alias for --debug.
12360 2002-03-24 Martin Baulig <martin@gnome.org>
12362 * codegen.cs (SymbolWriter): New public variable. Returns the
12363 current symbol writer.
12364 (CodeGen): Added `bool want_debugging_support' argument to the
12365 constructor. If true, tell the ModuleBuild that we want debugging
12366 support and ask it for the ISymbolWriter.
12367 (Save): If we have a symbol writer, call it's Close() method after
12368 saving the assembly.
12370 * driver.c (--debug): New command line argument to create a
12371 debugger information file.
12373 * location.cs (SymbolDocument): New public property. Returns an
12374 ISymbolDocumentWriter object for the current source file or null
12375 if we don't have a symbol writer.
12377 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12379 * driver.cs (LoadAssembly): Correctly return when all the paths
12380 have been tried and not before.
12382 * statement.cs (Switch.Emit): return the actual coverage for this
12383 statement (returns/not-returns)
12385 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12386 switch of the statement if we are the last switch section. That
12387 kills two problems: try/catch problems (we used to emit an empty
12388 nop at the end) and switch statements where all branches would
12391 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12393 * driver.cs: Add default assemblies (the equivalent to the
12394 Microsoft CSC.RSP file)
12396 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12397 also update tokens_seen and set it to false.
12399 * driver.cs: Implement --recurse for Mike.
12401 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12402 correctly splitting out the paths.
12404 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12406 * interface.cs (Interface.PopulateProperty): Instead of using
12407 `parent' as the declaration space for the set parameters, use
12410 * support.cs (InternalParameters): InternalParameters constructor
12411 takes a DeclSpace instead of a TypeContainer.
12413 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12414 types are being initialized, load the address of it before calling
12417 (New): Provide a mechanism to disable the generation of local
12418 value type temporaries when the caller will be providing us with
12419 an address to store it.
12421 (ArrayCreation.EmitDynamicInitializers): Use it.
12423 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12425 * expression.cs (Invocation.EmitArguments): Only probe for array
12426 property if there is more than one argument. Sorry about that.
12428 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12429 empty param arrays.
12431 * class.cs (Method.LabelParameters): Fix incorrect code path that
12432 prevented the `ParamArrayAttribute' from being applied to the
12435 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12437 * support.cs (ReflectionParameters): Correctly compute whether the
12438 last argument is a params array. Fixes the problem with
12441 * typemanager.cs: Make the assemblies array always be non-null
12442 (empty, but non-null)
12444 * tree.cs (RecordDecl): New function that abstracts the recording
12445 of names. This reports error 101, and provides a pointer to the
12446 previous declaration. Fixes a crash in the compiler.
12448 * cs-parser.jay (constructor_declaration): Update to new grammar,
12449 and provide a constructor_body that can be empty.
12451 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12453 * driver.cs: Add support for --resources.
12455 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12456 Make all types for the various array helper methods be integer.
12458 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12459 CheckState to ConvCast.
12461 (ConvCast): Now it takes a `checked' state argument, to avoid
12462 depending on the emit context for the conversion, and just using
12463 the resolve time setting.
12465 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12466 instead of Invocation.EmitArguments. We do not emit the original
12467 arguments, instead we emit those which have been converted to
12468 unsigned int expressions.
12470 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12472 * codegen.cs: ditto.
12474 * expression.cs (LocalVariableReference): Drop the use of the
12475 Store function that depended on the variable index.
12477 * statement.cs (VariableInfo): Drop the `Idx' property from this
12478 class, as this is not taking into account the indexes for
12479 temporaries tat we generate during the execution, getting the
12482 * class.cs: First emit class initializers, then call the parent
12485 * expression.cs (Binary): Fix opcode emision.
12486 (UnaryMutator.EmitCode): Support checked code generation
12488 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12489 matches for events for both the Static and Instance scans,
12490 pointing to the same element. Fix that.
12492 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12494 * rootcontext.cs (ResolveTree): Always set the
12495 interface_resolve_order, because nested interfaces will be calling
12498 * class.cs (GetInterfaceOrClass): Track the same resolution
12499 process used by TypeManager.LookupType. This fixes the nested
12500 type lookups in class declarations (separate path from
12503 (TypeContainer.DefineType): Also define nested interfaces.
12504 (TypeContainer.RegisterOrder): New public function used to
12505 register the order in which child interfaces need to be closed.
12507 Nested interfaces need to be closed after their parents have been
12510 * interface.cs (InterfaceAttr): Put all the logic for computing
12511 the interface attribute here.
12513 (DefineInterface): Register our interface order with the
12514 RootContext or with the TypeContainer depending on the case.
12516 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12518 * cs-parser.jay: rework foreach statement to work with the new
12519 changes to the policy on SimpleNames.
12521 * report.cs: support Stacktrace on warnings as well.
12523 * makefile: drop --unsafe and /unsafe from the compile.
12525 2002-03-13 Ravi Pratap <ravi@ximian.com>
12527 * ecore.cs (StandardConversionExists): Modify to take an Expression
12528 as the first parameter. Ensure we do null -> reference type conversion
12531 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12532 temporary Expression objects.
12534 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12536 * interface.cs: workaround bug in method overloading resolution
12537 (there is already a bugzilla bug for it).
12539 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12541 We could also solve this problem by having a separate path for
12542 performing type lookups, instead of DoResolve, we could have a
12543 ResolveType entry point, and only participating pieces of the
12544 production (simplename, deref, array) would implement this.
12546 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12547 signal SimpleName to only resolve type names and not attempt to
12548 resolve anything else.
12550 * expression.cs (Cast): Set the flag.
12552 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12554 * class.cs: Only report 108 if there is no `new' modifier.
12556 * cs-parser.jay: rework foreach statement to work with the new
12557 changes to the policy on SimpleNames.
12559 * report.cs: support Stacktrace on warnings as well.
12561 * makefile: drop --unsafe and /unsafe from the compile.
12563 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12565 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12566 lookups here, instead of doing that at parse time. This means
12567 that our grammar will not introduce `LocalVariableReferences' as
12568 expressions at this point. That solves the problem of code like
12572 static void Main ()
12576 This is only half the fix. The full fix requires parameters to
12577 also be handled in this way.
12579 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12580 makes the use more obvious of the DeclSpace. The
12581 ec.TypeContainer.TypeBuilder is now only used to pull the
12582 TypeBuilder for it.
12584 My theory is that I can get rid of the TypeBuilder completely from
12585 the EmitContext, and have typecasts where it is used (from
12586 DeclSpace to where it matters).
12588 The only pending problem is that the code that implements Aliases
12589 is on TypeContainer, and probably should go in DeclSpace.
12591 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12592 lookups here, instead of doing that at parse time. This means
12593 that our grammar will not introduce `LocalVariableReferences' as
12594 expressions at this point. That solves the problem of code like
12598 static void Main ()
12602 This is only half the fix. The full fix requires parameters to
12603 also be handled in this way.
12605 * class.cs (Property.DefineMethod): When implementing an interface
12606 method, set newslot, when implementing an abstract method, do not
12607 set the flag (before we tried never setting it, or always setting
12608 it, which is the difference).
12609 (Indexer.DefineMethod): same.
12610 (Method.DefineMethod): same.
12612 * ecore.cs: Only set the status used flag if we get back a Field.
12614 * attribute.cs: Temporary hack, so Paolo can keep working.
12616 2002-03-08 Ravi Pratap <ravi@ximian.com>
12618 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12619 the unmanaged type in the case we have a MarshalAs attribute.
12621 (Resolve): Handle the case when we are parsing the special MarshalAs
12622 attribute [we need to store the unmanaged type to use later]
12624 * typemanager.cs (marshal_as_attr_type): Built in type for the
12625 MarshalAs Attribute.
12627 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12628 on parameters and accordingly set the marshalling info.
12630 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12632 * class.cs: Optimizing slightly by removing redundant code after
12633 we switched to the `NoTypes' return value.
12634 (Property.DefineMethod): use NoTypes here too.
12636 This fixes the bug I introduced in my last batch of changes.
12638 2002-03-05 Ravi Pratap <ravi@ximian.com>
12640 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12642 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12643 Enums since those are types too.
12645 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12647 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12648 thanks to a call during the lookup process.
12650 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12652 * statement.cs (Foreach): Lots of work to accomodate a particular
12653 kind of foreach statement that I had not kept in mind. It is
12654 possible to have foreachs on classes that provide a GetEnumerator
12655 method that return objects that implement the "pattern" for using
12656 a foreach, there is no need to support GetEnumerator
12659 This is needed to compile nant.
12661 * decl.cs: Only report 114 if the member is not `Finalize' and if
12662 the warning level is at least 2.
12664 * class.cs: Moved the compare function from Method to
12667 (MethodSignature.InheritableMemberSignatureCompare): Add new
12668 filter function that is used to extract inheritable methods from a
12671 (Method.Define): Use the new `inheritable_method_signature_filter'
12674 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12677 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12679 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12681 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12683 * expression.cs: Pass location information to
12684 ConvertImplicitStandard.
12686 * class.cs: Added debugging code to track return values from
12689 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12691 * expression.cs (Is.DoResolve): If either side of the `is' is an
12692 interface, do not flag the warning.
12694 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12697 * report.cs: Allow for --fatal to be used with --probe.
12699 * typemanager.cs (NoTypes): Move the definition for the empty Type
12702 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12704 (TypeContainer.DefineProxy): New function used to proxy to parent
12705 implementations when implementing interfaces.
12706 (TypeContainer.ParentImplements): used to lookup if our parent
12707 implements a public function that is required by an interface.
12708 (TypeContainer.VerifyPendingMethods): Hook this up.
12710 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12711 `modules' and `assemblies' arraylists into arrays. We only grow
12712 these are the very early start up of the program, so this improves
12713 the speedof LookupType (nicely measured).
12715 * expression.cs (MakeByteBlob): Replaced unsafe code with
12716 BitConverter, as suggested by Paolo.
12718 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12719 folding of string concatenation, but if either side is a string,
12720 and the other is not, then return null, and let the runtime use
12721 the concatenation on the string plus the object (using
12722 `Object.ToString').
12724 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12726 Constant Folding has been implemented now.
12728 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12729 the error instead on types that are not supported in one's
12732 * constant.cs (Constant and all children): New set of functions to
12733 perform implict and explicit conversions.
12735 * ecore.cs (EnumConstant): Implement the new functions to perform
12736 conversion by proxying to the child expression.
12738 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12739 own separate setting that can not be turned off from the command
12740 line using --unchecked or --checked and is only controlled using
12741 the checked/unchecked statements and expressions. This setting is
12742 used by the constant folder to flag errors.
12744 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12745 ConstantCheckState as well.
12747 During Resolve, they also have to flag the state, because the
12748 constant folder runs completely in the Resolve phase.
12750 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12753 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12755 * cfold.cs: New file, this file contains the constant folder.
12757 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12758 argument to track whether we are using the resulting address to
12759 load or store a value and provide better error messages.
12761 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12762 new AddressOf arguments.
12764 * statement.cs (Foreach.EmitCollectionForeach): Update
12766 * expression.cs (Argument.Emit): Call AddressOf with proper
12767 arguments to track usage.
12769 (New.DoEmit): Call AddressOf with new arguments.
12771 (Unary.Emit): Adjust AddressOf call.
12773 2002-03-01 Ravi Pratap <ravi@ximian.com>
12775 * cs-parser.jay (member_access): Change the case for pre-defined types
12776 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12779 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12782 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12783 essentially like methods and apply attributes like MethodImplOptions to them too.
12785 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12788 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12789 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12792 * Update code everywhere accordingly.
12794 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12796 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12798 2002-02-28 Ravi Pratap <ravi@ximian.com>
12800 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12801 try performing lookups against those instead of jumping straight into using
12802 the 'using' clauses.
12804 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12806 (LookupType): Perform lookups in implicit parents too.
12808 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12809 sequence as RootContext.LookupType.
12811 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12812 the various cases of namespace lookups into this method.
12814 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12816 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12817 in positional arguments)
12819 * class.cs (Operator): Update the AllowedModifiers to contain
12822 * cs-parser.jay: Update operator declaration to allow for the
12823 operator body to be empty.
12825 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12828 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12830 * class.cs (Method.Emit): Label parameters.
12832 * driver.cs: Return 1 or 0 as the program exit code.
12834 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12836 * expression.cs: Special case the `null' object when trying to
12837 auto-compute the type, as anything can be explicitly converted to
12840 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12841 spotting this Paolo.
12843 (Expression.ImplicitNumericConversion): Perform comparissions of
12844 the type using the underlying type in the case of an enumeration
12845 rather than using the enumeration type for the compare.
12847 Cope with the underlying == type case, which is not possible to
12850 (Expression.ConvertNumericExplicit): Perform comparissions of
12851 the type using the underlying type in the case of an enumeration
12852 rather than using the enumeration type for the compare.
12854 * driver.cs: If the user does not supply an extension, assume .exe
12856 * cs-parser.jay (if_statement): Rewrote so that we can track the
12857 location for the if statement.
12859 * expression.cs (Binary.ConstantFold): Only concat strings when
12860 the operation is "+", not everything ;-)
12862 * statement.cs (Statement.EmitBoolExpression): Take a location
12864 (If, While, Do): Track location.
12866 * expression.cs (Binary.ResolveOperator): In the object + string
12867 case, I was missing a call to ConvertImplicit
12869 2002-02-25 Ravi Pratap <ravi@ximian.com>
12871 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
12872 Location arguments. Ensure we use RootContext.LookupType to do our work
12873 and not try to do a direct Type.GetType and ModuleBuilder.GetType
12875 * interface.cs (PopulateMethod): Handle the type of the parameter being
12878 * expression.cs (Invocation.BetterFunction): Handle the case when we
12879 have a params method with no fixed arguments and a call is made with no
12882 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12884 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12885 the verbatim-string-literal
12887 * support.cs (InternalParameters.ParameterModifier): handle null
12889 (InternalParameters.ParameterType): ditto.
12891 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12892 duplicating the name of the variable parameter.
12893 (GetParameterByName): Fix bug where we were not looking up array
12894 paramters if they were the only present (thanks Paolo!).
12895 (GetParameterInfo): We only have an empty set of types if both
12896 fixed and array are set to null.
12897 (GetParameterInfo-idx): Handle FixedParameter == null
12899 * cs-parser.jay: Handle the case where there is no catch
12900 statements (missing null test).
12902 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12904 * driver.cs (MainDriver): Be conservative on our command line
12907 Catch DirectoryNotFoundException when calling GetFiles.
12909 (SplitPathAndPattern): Used to split the input specification into
12910 a path and a pattern that we can feed to Directory.GetFiles.
12912 2002-02-21 Miguel de Icaza <miguel@ximian.com>
12914 * statement.cs (Fixed): Implement the last case of the Fixed
12915 statement (string handling).
12917 * expression.cs (StringPtr): New class used to return a char * to
12918 a string; Used by the Fixed statement.
12920 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
12922 * expression.cs (Binary.ResolveOperator): Remove redundant
12923 MemberLookup pn parent type.
12924 Optimize union call, we do not need a union if the types are the same.
12925 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
12928 Specialize the use of MemberLookup everywhere, instead of using
12929 the default settings.
12931 (StackAlloc): Implement stackalloc keyword.
12933 * cs-parser.jay: Add rule to parse stackalloc.
12935 * driver.cs: Handle /h, /help, /?
12937 * expression.cs (MakeByteBlob): Removed the hacks we had in place
12938 before we supported unsafe code.
12940 * makefile: add --unsafe to the self compilation of mcs.
12942 2002-02-20 Miguel de Icaza <miguel@ximian.com>
12944 * expression.cs (PointerArithmetic): New class that is used to
12945 perform pointer arithmetic.
12946 (Binary.Resolve): Handle pointer arithmetic
12947 Handle pointer comparission.
12948 (ArrayPtr): Utility expression class that is used to take the
12949 address of an array.
12951 (ElementAccess): Implement array access for pointers
12953 * statement.cs (Fixed): Implement fixed statement for arrays, we
12954 are missing one more case before we are done.
12956 * expression.cs (Indirection): Implement EmitAssign and set the
12957 ExprClass to Variable. This allows pointer dereferences to be
12958 treated as variables, and to have values assigned to them.
12960 * ecore.cs (Expression.StoreFromPtr): New utility function to
12961 store values dereferencing.
12963 2002-02-20 Ravi Pratap <ravi@ximian.com>
12965 * expression.cs (Binary.ResolveOperator): Ensure that we are
12966 not trying to operate on a void type - this fixes the reported
12969 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
12970 the parent implementation is sealed.
12972 * ../errors/cs0239.cs : Add.
12974 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
12976 * typemanager.cs (unverifiable_code_type): Corresponds to
12977 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
12978 which have unsafe code in them.
12980 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
12983 2002-02-19 Miguel de Icaza <miguel@ximian.com>
12985 * cs-tokenizer.cs: Add support for @"litreal strings"
12987 Make tokenizer accept pre-processor directives
12988 on any column (remove the old C-like limitation).
12990 * rootcontext.cs (EmitCode): Emit any global attributes.
12991 (AddGlobalAttributes): Used to keep track of assembly attributes.
12993 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
12995 * cs-parser.jay: Add support for global attributes.
12997 2002-02-17 Miguel de Icaza <miguel@ximian.com>
12999 * expression.cs (Indirection): New helper class. Unary will
13000 create Indirection classes to be able to implement the
13001 IMemoryLocation interface on it.
13003 2002-02-16 Miguel de Icaza <miguel@ximian.com>
13005 * cs-parser.jay (fixed_statement): reference the right statement.
13007 * statement.cs (Fixed.Emit): Finish implementing the fixed
13008 statement for the &x case.
13010 2002-02-14 Miguel de Icaza <miguel@ximian.com>
13012 * class.cs (Property.Define, Method.Define): Remove newslot when
13015 * modifiers.cs: My use of NewSlot when `Abstract' was set was
13016 wrong. NewSlot should only be used if the `new' keyword is present.
13018 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
13019 locating our system dir. Sorry about this.
13021 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13023 * driver.cs (GetSystemDir): Compute correctly the location of our
13024 system assemblies. I was using the compiler directory instead of
13025 the library directory.
13027 2002-02-13 Ravi Pratap <ravi@ximian.com>
13029 * expression.cs (BetterFunction): Put back in what Miguel commented out
13030 since it is the correct fix. The problem is elsewhere ;-)
13032 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
13033 parameters of the parms method are themselves compatible or not !
13035 (StandardConversionExists): Fix very dangerous bug where we were forgetting
13036 to check that a class implements an interface before saying that an implicit
13037 conversion was allowed. Use ImplementsInterface to do the checking.
13039 2002-02-13 Miguel de Icaza <miguel@ximian.com>
13041 * class.cs (Method.Define): Track whether we are an explicit
13042 implementation or not. And only call DefineMethodOverride if we
13043 are an explicit implementation.
13045 (Property.DefineMethod): Ditto.
13047 2002-02-11 Ravi Pratap <ravi@ximian.com>
13049 * expression.cs (BetterFunction): Catch hideous bug which was
13050 preventing us from detecting ambiguous calls due to implicit casts i.e
13053 2002-01-29 Miguel de Icaza <miguel@ximian.com>
13055 * support.cs (Pair): Remove un-needed method. I figured why I was
13056 getting the error in cs-parser.jay, the variable in a foreach loop
13057 is readonly, and the compiler does not really treat this as a variable.
13059 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
13060 instead of EQUALS in grammar.
13062 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
13064 * expression.cs (Unary.DoResolve): Check whether the argument is
13067 2002-01-28 Miguel de Icaza <miguel@ximian.com>
13069 * support.cs: Api for Pair to set a value. Despite the fact that
13070 the variables are public the MS C# compiler refuses to compile
13071 code that accesses the field if the variable is part of a foreach
13074 * statement.cs (Fixed): Begin implementation of the fixed
13077 (Block.AddVariable): Return the VariableInfo on success and null
13078 on failure instead of true/false.
13080 * cs-parser.jay (foreach): Catch errors on variables already
13081 defined (we were ignoring this value before) and properly unwind
13082 the block hierarchy
13084 (fixed_statement): grammar for the fixed statement.
13086 2002-01-25 Miguel de Icaza <miguel@ximian.com>
13088 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
13089 pointer types to be incretemented.
13091 (SizeOf): Implement.
13093 * cs-parser.jay (pointer_member_access): Implement
13094 expr->IDENTIFIER production.
13096 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
13097 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
13100 (Unary): Implement indirection.
13102 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
13103 use in non-unsafe context).
13105 (SimpleName.DoResolve): Check for pointers in field access on safe
13108 (Expression.LoadFromPtr): Factor the load-indirect code in this
13109 function. This was duplicated in UnboxCast and ParameterReference
13111 2002-01-24 Miguel de Icaza <miguel@ximian.com>
13113 * expression.cs (ComposedCast): report an error if a pointer cast
13114 is used in a safe region.
13116 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
13117 pointer type casts in unsafe context.
13119 * codegen.cs (EmitContext): Set up IsUnsafe.
13121 * cs-parser.jay (non_expression_type): Add productions for pointer
13124 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13125 code. We should not use force into static mode if the method is
13126 not virtual. Fixes bug in MIS
13128 * statement.cs (Do.Emit, While.Emit, For.Emit,
13129 Statement.EmitBoolExpression): Add support to Do and While to
13130 propagate infinite loop as `I do return' semantics.
13132 Improve the For case to also test for boolean constants.
13134 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13135 to the list of attributes we can add.
13137 Remove `EmitContext' argument.
13139 * class.cs (Method.Define): Apply parameter attributes.
13140 (Constructor.Define): Apply parameter attributes.
13141 (MethodCore.LabelParameters): Move here the core of labeling
13144 * support.cs (ReflectionParameters.ParameterModifier,
13145 InternalParameters.ParameterModifier): Use IsByRef on the type and
13146 only return the OUT bit for these parameters instead of in/out/ref
13149 This is because I miss-understood things. The ParameterInfo.IsIn
13150 and IsOut represent whether the parameter has the [In] and [Out]
13153 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13155 * ecore.cs (FieldExpr.Emit): Release temporaries.
13157 * assign.cs (LocalTemporary.Release): new function.
13159 * codegen.cs (EmitContext.GetTemporaryStorage,
13160 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13161 temporary storage. Now we can "put back" localbuilders when we
13164 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13166 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13167 need to make a copy of the variable to generate verifiable code.
13169 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13171 * driver.cs: Compute dynamically the system directory.
13173 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13174 Slower, but more generally useful. Used by the abstract
13175 registering implementation.
13177 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13178 the rules for the special rule on Type/instances. First check if
13179 we have the same name, and if so, try that special static path
13180 rather than the instance path.
13182 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13184 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13187 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13188 Enum, ValueType, Delegate or Array for non-corlib compiles.
13190 * cs-tokenizer.cs: Catch long identifiers (645)
13192 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13195 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13196 fix, we were returning too early, so we were not registering
13197 pending methods from abstract classes.
13199 Do not register pending methods if the class is abstract.
13201 * expression.cs (Conditional.DoResolve): Report circular implicit
13202 conversions when we neecd to compute it for conditional
13205 (Is.DoResolve): If the expression is always of the provided type,
13206 flag warning 183. If the expression can not ever be of the
13207 provided type flag warning 184.
13209 * class.cs: Catch 169 as well.
13211 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13214 2002-01-18 Nick Drochak <ndrochak@gol.com>
13216 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13218 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13220 * interface.cs: (PopulateMethod): Check for pointers being defined
13221 only if the unsafe context is active.
13222 (PopulateProperty): ditto.
13223 (PopulateIndexer): ditto.
13225 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13226 specified. If pointers are present, make sure that they are
13227 present in an unsafe context.
13228 (Constructor, Constructor.Define): ditto.
13229 (Field, Field.Define): ditto.
13230 (Property, Property.Define): ditto.
13231 (Event, Event.Define): ditto.
13233 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13234 hashtable if there are classes or structs defined.
13236 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13237 code, as the constant resolution moved.
13239 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13240 the metadata, so we can flag error 133.
13242 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13243 pointer is being declared in an unsafe context.
13245 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13247 * modifiers.cs (Modifiers.Check): Require a Location argument.
13248 Report error 227 for Unsafe use.
13250 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13252 * statement.cs (For.Emit): If the test is null, then report that
13253 we do `return', as we wont reach anything afterwards.
13255 (Switch.SwitchGoverningType): Track the expression that matched
13258 * driver.cs: Allow negative numbers as an error code to flag.
13260 * cs-parser.jay: Handle 1551.
13262 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13264 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13266 * cs-parser.jay: Report 1518 (type declaration can only contain
13267 class, struct, interface, enum or delegate)
13269 (switch_label): Report 1523 (keywords `case' or `default' must
13272 (opt_switch_sections): Report 1522 (empty switch)
13274 * driver.cs: Report 1515 (response file specified multiple times)
13275 Report 1516 (Source file specified multiple times).
13277 * expression.cs (Argument.Resolve): Signal 1510
13279 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13280 access not allowed in static code)
13282 2002-01-11 Ravi Pratap <ravi@ximian.com>
13284 * typemanager.cs (IsPointerType): Utility method which we are going
13287 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13288 the object type, so we take care of that.
13290 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13292 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13293 added to non-params parameters :-)
13295 * typemanager.cs (CSharpName): Include 'void' type too.
13297 (void_ptr_type): Include in the set of core types.
13299 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13302 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13305 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13306 completely forgotten about it.
13308 2002-01-10 Ravi Pratap <ravi@ximian.com>
13310 * cs-parser.jay (pointer_type): Add. This begins our implementation
13311 of parsing rules for unsafe code.
13313 (unsafe_statement): Implement.
13315 (embedded_statement): Modify to include the above.
13317 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13319 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13320 if the current context is an unsafe one.
13322 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13323 are handled differently, we need separate rules for them.
13325 (local_variable_declaration): Update to use local_variable_pointer_type
13326 to allow variable declarations of unmanaged pointer types.
13328 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13329 in unsafe contexts.
13331 * ../errors/cs0214.cs : Add.
13333 2002-01-16 Nick Drochak <ndrochak@gol.com>
13335 * makefile: remove 'response' file when cleaning.
13337 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13339 * cs-parser.jay: Report 1524.
13341 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13343 * typemanager.cs (RegisterMethod): drop checking if we have
13344 registered this from here
13346 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13348 * class.cs (Method.EmitDestructor): Implement calling our base
13351 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13352 value of InFinally.
13354 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13355 this routine and will wrap the call in a try/catch block. Deal
13358 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13360 * ecore.cs (Expression.MemberLookup): instead of taking a
13361 parameter `same_type' that was used to tell whether we could
13362 access private members we compute our containing type from the
13365 (FieldExpr): Added partial support for volatile fields. This does
13366 not work for volatile fields exposed from assemblies, as I can not
13367 figure out how to extract the modreq from it.
13369 Updated all the source files to use this.
13371 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13372 because it is referenced by MemberLookup very often.
13374 2002-01-09 Ravi Pratap <ravi@ximian.com>
13376 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13377 TypeBuilder.GetCustomAttributes to retrieve what we need.
13379 Get rid of redundant default_member_attr_type as this is the same as
13380 default_member_type which already exists.
13382 * interface.cs, attribute.cs : Update accordingly.
13384 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13386 * typemanager.cs: Enable IndexerPropertyName again. It does not
13387 work for TYpeBuilders though. Ravi, can you please fix this?
13389 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13391 * expression.cs (Argument.Emit): Handle the case of ref objects
13392 being passed to ref functions;
13394 (ParameterReference.EmitLoad): Loads the content of the pointer
13395 without dereferencing.
13397 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13399 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13401 2002-01-08 Ravi Pratap <ravi@ximian.com>
13403 * class.cs (Indexer.DefineMethod): Incorporate the interface
13404 type in the name of the method if we are doing explicit interface
13407 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13409 (BetterConversion): Fix extremely trivial bug where we were referring to
13410 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13413 * ../errors/bug16.cs : Add although we have fixed it.
13415 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13417 * expression.cs (BaseIndexer): Begin implementation.
13419 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13421 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13422 production directly to remove a shift/reduce, and implement
13423 explicit interface implementation.
13425 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13426 after a floating point suffix.
13428 * expression.cs (DoNumericPromotions): Improved the conversion for
13429 uint/uint. If we have a constant, we avoid doing a typecast to a
13432 * class.cs (Indexer): Implement explicit interface implementation
13435 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13437 * class.cs: make the default instance constructor public and hidebysig.
13439 2001-01-03 Ravi Pratap <ravi@ximian.com>
13441 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13442 so we can call it from elsewhere.
13444 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13445 we emit it internally if the class has a defined indexer; otherwise the user
13446 emits it by decorating the class definition with the DefaultMemberAttribute.
13448 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13449 attribute is not used on a type which defines an indexer.
13451 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13452 character when we skip whitespace.
13454 * ../errors/cs0646.cs : Add.
13456 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13458 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13461 * makefile: Add practical target `mcs3.exe' which builds the third
13462 generation compiler.
13464 * expression.cs (New): Fix structures constructor calling.
13466 * class.cs (Property, Method, Indexer): Emit Final flag on the
13467 method if we are an interface implementation and we are not
13470 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13471 whether this property is referencing a `base' method.
13473 * expression.cs (Invocation.EmitCall): take an extra argument:
13474 is_base, this is used to determine whether the `call' or
13475 `callvirt' opcode should be used.
13478 * delegate.cs: update EmitCall.
13480 * class.cs (Method.Define): Set NewSlot for the cases where we are
13481 not implementing an interface method.
13483 (Property.Define): ditto.
13485 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13487 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13488 'r'. Allows mcs to parse itself fully.
13490 2002-01-02 Ravi Pratap <ravi@ximian.com>
13492 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13493 of the number of initializers that require the InitializeArray method.
13495 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13496 update the above field where necessary.
13498 (MakeByteBlob): Update accordingly.
13500 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13503 (EmitDynamicInitializers): Update in accordance with the new optimization.
13505 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13506 same OpCode applies.
13508 * cs-parser.jay : Fix some glaring errors I introduced.
13510 2002-01-01 Ravi Pratap <ravi@ximian.com>
13512 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13513 so that we can check for name clashes there too.
13515 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13516 for interface indexers.
13518 * interfaces.cs (Define): Emit the default member attribute.
13520 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13521 variable was being referred to while setting the value ;-)
13523 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13525 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13526 byte-by-byte information when we know the data is zero.
13528 Make the block always a multiple of 4, because
13529 DefineInitializedData has a bug.
13531 * assign.cs: Fix, we should assign from the temporary, not from
13534 * expression.cs (MakeByteBlob): Fix my incorrect code.
13536 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13538 * typemanager.cs (EnumToUnderlying): This function is used to get
13539 the underlying type from an enumeration, because it does not
13542 * constant.cs: Use the I4_S form for values between -128 and 127.
13544 * statement.cs (Block.LookupLabel): Looks up a label.
13545 (Block): Drop support for labeled blocks.
13547 (LabeledStatement): New kind of statement that represents a label
13550 (Goto): Finally implement this bad boy.
13552 * cs-parser.jay: Update to reflect new mechanism to implement
13555 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13557 * codegen.cs (EmitContext.This): a codegen property that keeps the
13558 a single instance of this instead of creating many different this
13561 * delegate.cs (Delegate.DoResolve): Update to use the property;
13563 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13565 * expression.cs (BaseAccess.DoResolve): Ditto.
13567 2001-12-29 Ravi Pratap <ravi@ximian.com>
13569 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13570 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13572 (InitCoreTypes): Update accordingly.
13574 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13575 so we can quickly store the state.
13577 (ApplyAttributes): Set the correct implementation flags
13578 for InternalCall methods.
13580 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13582 * expression.cs (EmitCall): if a method is not virtual, then do
13583 not use callvirt on it.
13585 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13586 user defined stuff) requires the use of stobj, which takes an
13587 address on the stack instead of an array and an index. So emit
13588 the Ldelema operation for it.
13590 (EmitStoreOpcode): Use stobj for valuetypes.
13592 (UnaryMutator.EmitCode): Use the right 1 value depending on
13593 whether we are dealing with int64/uint64, float or doubles.
13595 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13596 constructors that I implemented last night.
13598 (Constructor.IsDefault): Fix to work properly for static
13601 * cs-parser.jay (CheckDef): report method signature errors.
13602 Update error number 103 to be 132.
13604 * decl.cs: New AdditionResult enumeration value: MethodExists.
13605 Although we do this check for methods later on in the semantic
13606 analysis, catching repeated default constructors is so easy that
13607 we catch these here.
13609 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13612 (ParameterReference.EmitAssign, Emit): handle
13615 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13616 (ArrayAccess.EmitStoreOpcode): ditto.
13618 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13620 * expression.cs (MakeByteBlob): Complete all the missing types
13621 (uint, short, ushort, byte, sbyte)
13623 * class.cs: Only init instance field initializers on instance
13626 Rename `constructors' to instance_constructors.
13628 (TypeContainer.AddConstructor): Only add constructors to the list
13629 if it is not static.
13631 Make sure that we handle default_static_constructor independently
13632 everywhere where we handle instance_constructors
13634 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13636 * class.cs: Do not lookup or create a base initializer for a
13637 static constructor.
13639 (ConstructorInitializer.Resolve): use the proper type to lookup
13642 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13644 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13647 * decl.cs: CloseType is now an virtual method, the default
13648 implementation just closes this type.
13650 2001-12-28 Ravi Pratap <ravi@ximian.com>
13652 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13653 to PreserveSig by default. Also emit HideBySig on such methods.
13655 Basically, set the defaults to standard values.
13657 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13658 argument, if candidate is better, it can't be worse than the best !
13660 (Invocation): Re-write bits to differentiate between methods being
13661 applicable in their expanded form and their normal form - for params
13664 Get rid of use_standard everywhere as only standard conversions are allowed
13665 in overload resolution.
13667 More spec conformance.
13669 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13671 * driver.cs: Add --timestamp, to see where the compiler spends
13674 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13675 `this' in static code.
13677 (SimpleName.DoResolve): Implement in terms of a helper function
13678 that allows static-references to be passed upstream to
13681 (Expression.ResolveWithSimpleName): Resolve specially simple
13682 names when called by MemberAccess to implement the special
13685 (Expression.ImplicitReferenceConversion): Handle conversions from
13686 Null to reference types before others, as Null's type is
13689 * expression.cs (Invocation.EmitCall): Handle the special case of
13690 calling methods declared on a reference type from a ValueType
13691 (Base classes System.Object and System.Enum)
13693 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13694 the left hand side is a TypeExpr, not on every enumeration.
13696 (Binary.Resolve): If types are reference types, then do a cast to
13697 object on operators != and == of both arguments.
13699 * typemanager.cs (FindMembers): Extract instance and static
13700 members if requested.
13702 * interface.cs (PopulateProperty): Use void_type instead of null
13703 as the return type for the setter method.
13705 (PopulateIndexer): ditto.
13707 2001-12-27 Ravi Pratap <ravi@ximian.com>
13709 * support.cs (ReflectionParameters): Fix minor bug where we
13710 were examining the wrong parameter for the ParamArray attribute.
13712 Cope with requests for the type of the parameter at position
13713 greater than the params parameter's. We now return the element
13714 type of the params array as that makes more sense.
13716 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13717 accordingly as we no longer have to extract the element type
13720 (Invocation.OverloadResolve): Update.
13722 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13724 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13725 against IEnumerator, test whether the return value is a descendant
13726 of the IEnumerator interface.
13728 * class.cs (Indexer.Define): Use an auxiliary method to implement
13729 the other bits of the method definition. Begin support for
13730 explicit interface implementation.
13732 (Property.DefineMethod): Use TypeManager.void_type instead of null
13733 for an empty return value.
13735 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13737 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13738 dealing with a FieldExpr which is composed of a FieldBuilder, in
13739 the code path we did extract the constant, but we should have
13740 obtained the underlying value to be able to cast it (otherwise we
13741 end up in an infinite loop, this is what Ravi was running into).
13743 (ArrayCreation.UpdateIndices): Arrays might be empty.
13745 (MemberAccess.ResolveMemberAccess): Add support for section
13746 14.5.4.1 that deals with the special case of E.I when E is a type
13747 and something else, that I can be a reference to a static member.
13749 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13750 handle a particular array type to create byte blobs, it is just
13751 something we dont generate byteblobs for.
13753 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13756 * location.cs (Push): remove the key from the hashtable that we
13757 are about to add. This happens for empty files.
13759 * driver.cs: Dispose files after we have parsed them.
13761 (tokenize): new function that only runs the tokenizer on its
13762 input, for speed testing.
13764 2001-12-26 Ravi Pratap <ravi@ximian.com>
13766 * class.cs (Event.Define): Define the private field only if there
13767 are no accessors defined.
13769 * expression.cs (ResolveMemberAccess): If there is no associated
13770 field with the event, that means we have an event defined with its
13771 own accessors and we should flag error cs0070 since transforming
13772 ourselves into a field is not valid in that case.
13774 * ecore.cs (SimpleName.DoResolve): Same as above.
13776 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13777 and charset to sane values.
13779 2001-12-25 Ravi Pratap <ravi@ximian.com>
13781 * assign.cs (DoResolve): Perform check on events only if they
13782 are being accessed outside the declaring type.
13784 * cs-parser.jay (event_declarations): Update rules to correctly
13785 set the type of the implicit parameter etc.
13787 (add_accessor, remove_accessor): Set current local parameters.
13789 * expression.cs (Binary): For delegate addition and subtraction,
13790 cast the return value from the method into the appropriate delegate
13793 2001-12-24 Ravi Pratap <ravi@ximian.com>
13795 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13796 of these as the workaround is unnecessary.
13798 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13799 delegate data - none of that is needed at all.
13801 Re-write bits to extract the instance expression and the delegate method
13804 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13807 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13808 of attaching attributes instead of duplicating code everywhere.
13810 * everywhere : Update code to do attribute emission using the above method.
13812 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13814 * expression.cs (IsParamsMethodApplicable): if there are not
13815 parameters, return immediately.
13817 * ecore.cs: The 0 literal can be implicity converted to an enum
13820 (SimpleName.DoResolve): First lookup the type, then lookup the
13823 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13824 want to get its address. If the InstanceExpression is not
13825 addressable, store the result in a temporary variable, then get
13828 * codegen.cs: Only display 219 errors on warning level or above.
13830 * expression.cs (ArrayAccess): Make it implement the
13831 IMemoryLocation interface.
13833 (Binary.DoResolve): handle the operator == (object a, object b)
13834 and operator != (object a, object b) without incurring into a
13835 BoxedCast (because 5 != o should never be performed).
13837 Handle binary enumerator operators.
13839 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13840 value type, otherwise use Ldelem_ref.
13842 Use precomputed names;
13844 (AddressOf): Implement address of
13846 * cs-parser.jay (labeled_statement): Fix recursive block
13847 addition by reworking the production.
13849 * expression.cs (New.DoEmit): New has a special case:
13851 If we are dealing with a ValueType, we have a few
13852 situations to deal with:
13854 * The target of New is a ValueType variable, that is
13855 easy, we just pass this as the variable reference
13857 * The target of New is being passed as an argument,
13858 to a boxing operation or a function that takes a
13861 In this case, we need to create a temporary variable
13862 that is the argument of New.
13865 2001-12-23 Ravi Pratap <ravi@ximian.com>
13867 * rootcontext.cs (LookupType): Check that current_type is not null before
13868 going about looking at nested types.
13870 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
13871 not implement the IAssignMethod interface any more.
13873 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
13874 where we tranform them into FieldExprs if they are being resolved from within
13875 the declaring type.
13877 * ecore.cs (SimpleName.DoResolve): Do the same here.
13879 * assign.cs (DoResolve, Emit): Clean up code considerably.
13881 * ../errors/bug10.cs : Add.
13883 * ../errors/cs0070.cs : Add.
13885 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13887 * assign.cs : Get rid of EventIsLocal everywhere.
13889 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13891 * ecore.cs (ConvertIntLiteral): finished the implementation.
13893 * statement.cs (SwitchLabel): Convert the value we are using as a
13894 key before looking up the table.
13896 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13898 * codegen.cs (EmitTopBlock): Require a Location argument now.
13900 * cs-parser.jay (constructor_declarator): We need to setup
13901 current_local_parameters before we parse the
13902 opt_constructor_initializer, to allow the variables to be bound
13903 to the constructor arguments.
13905 * rootcontext.cs (LookupType): First lookup nested classes in our
13906 class and our parents before we go looking outside our class.
13908 * expression.cs (ConstantFold): Extract/debox the values at the
13911 * rootcontext.cs (EmitCode): Resolve the constants first before we
13912 resolve the types. This is not really needed, but it helps debugging.
13914 * statement.cs: report location.
13916 * cs-parser.jay: pass location to throw statement.
13918 * driver.cs: Small bug fix.
13920 * report.cs: Updated format to be 4-zero filled digits.
13922 2001-12-22 Ravi Pratap <ravi@ximian.com>
13924 * expression.cs (CheckIndices): Fix minor bug where the wrong
13925 variable was being referred to ;-)
13927 (DoEmit): Do not call EmitStaticInitializers when the
13928 underlying type is System.Object.
13930 2001-12-21 Ravi Pratap <ravi@ximian.com>
13932 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
13933 and do the usual workaround for SRE.
13935 * class.cs (MyEventBuilder.EventType): New member to get at the type
13936 of the event, quickly.
13938 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
13940 * assign.cs (Assign.DoResolve): Handle the case when the target
13941 is an EventExpr and perform the necessary checks.
13943 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
13946 (SimpleName.MemberStaticCheck): Include check for EventExpr.
13948 (EventExpr): Set the type in the constructor itself since we
13949 are meant to be born fully resolved.
13951 (EventExpr.Define): Revert code I wrote earlier.
13953 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
13954 instance expression is null. The instance expression is a This in that case
13955 or a null, depending on whether it is a static method or not.
13957 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
13958 refers to more than one method.
13960 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
13961 and accordingly flag errors.
13963 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13965 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
13967 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13969 * location.cs (ToString): Provide useful rutine.
13971 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13973 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
13974 objects, return the actual integral boxed.
13976 * statement.cs (SwitchLabel): define an ILLabel for each
13979 (Switch.CheckSwitch): If the value is a Literal, extract
13980 the underlying literal.
13982 Also in the unused hashtable we had, add the SwitchLabel so we can
13983 quickly look this value up.
13985 * constant.cs: Implement a bunch of new constants. Rewrite
13986 Literal based on this. Made changes everywhere to adapt to this.
13988 * expression.cs (Expression.MakeByteBlob): Optimize routine by
13989 dereferencing array only once, and also copes with enumrations.
13991 bytes are two bytes wide, not one.
13993 (Cast): Perform constant conversions.
13995 * ecore.cs (TryImplicitIntConversion): Return literals instead of
13996 wrappers to the literals here.
13998 * expression.cs (DoNumericPromotions): long literals can converted
13999 to ulong implicity (this is taken care of elsewhere, but I was
14000 missing this spot).
14002 * ecore.cs (Expression.Literalize): Make the return type Literal,
14003 to improve type checking.
14005 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
14007 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14009 * literal.cs: Revert code from ravi that checked the bounds. The
14010 bounds are sane by the definition of the type itself.
14012 * typemanager.cs: Fix implementation of ImplementsInterface. We
14013 need to actually look up in our parent hierarchy for interfaces
14016 * const.cs: Use the underlying type for enumerations
14018 * delegate.cs: Compute the basename for the delegate creation,
14019 that should fix the delegate test case, and restore the correct
14020 Type Lookup semantics in rootcontext
14022 * rootcontext.cs: Revert Ravi's last patch. The correct way of
14023 referencing a nested type with the Reflection API is using the "+"
14026 * cs-parser.jay: Do not require EOF token at the end.
14028 2001-12-20 Ravi Pratap <ravi@ximian.com>
14030 * rootcontext.cs (LookupType): Concatenate type names with
14031 a '.' instead of a '+' The test suite passes again.
14033 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
14034 field of the enumeration.
14036 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
14037 the case when the member is an EventExpr.
14039 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
14040 static has an associated instance expression.
14042 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
14044 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
14046 * class.cs (Event.Define): Register event and perform appropriate checks
14049 We define the Add and Remove methods even if the use provides none because
14050 in that case, we provide default implementations ourselves.
14052 Define a private field of the type of the event. This is done by the CSC compiler
14053 and we should be doing it too ;-)
14055 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
14056 More methods we use in code we generate.
14058 (multicast_delegate_type, delegate_type): Two separate types since the distinction
14061 (InitCoreTypes): Update accordingly for the above.
14063 * class.cs (Event.Emit): Generate code for default accessors that we provide
14065 (EmitDefaultMethod): Do the job in the above.
14067 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
14070 2001-12-20 Miguel de Icaza <miguel@ximian.com>
14072 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
14073 builders even if we were missing one.
14075 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
14076 pass the Basename as our class name instead of the Name. The
14077 basename will be correctly composed for us.
14079 * parameter.cs (Paramters): Now takes a Location argument.
14081 * decl.cs (DeclSpace.LookupType): Removed convenience function and
14082 make all the code call directly LookupType in RootContext and take
14083 this chance to pass the Location information everywhere.
14085 * Everywhere: pass Location information.
14087 2001-12-19 Miguel de Icaza <miguel@ximian.com>
14089 * class.cs (Constructor.Define): Updated way of detecting the
14090 length of the parameters.
14092 (TypeContainer.DefineType): Use basename as the type name for
14095 (TypeContainer.Define): Do not recursively define types here, as
14096 definition is taken care in order by the RootContext.
14098 * tree.cs: Keep track of namespaces in a per-file basis.
14100 * parameter.cs (Parameter.ComputeSignature): Update to use
14103 (Parameters.GetSignature): ditto.
14105 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
14106 instead of a TypeContainer.
14108 (Interface.SemanticAnalysis): Use `this' instead of our parent to
14109 resolve names. Because we need to be resolve in our context, not
14112 * driver.cs: Implement response files.
14114 * class.cs (TypeContainer.DefineType): If we are defined, do not
14115 redefine ourselves.
14117 (Event.Emit): Emit the code for add/remove handlers.
14118 (Event.Define): Save the MethodBuilders for add/remove.
14120 * typemanager.cs: Use pair here too.
14122 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14123 DictionaryEntry requires the first argument to be non-null.
14125 (enum_declaration): Compute full name for registering the
14128 (delegate_declaration): Instead of using
14129 formal_parameter_list, use opt_formal_parameter_list as the list
14132 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14133 (EventParsing): New property that controls whether `add' and
14134 `remove' are returned as tokens or identifiers (for events);
14136 2001-12-19 Ravi Pratap <ravi@ximian.com>
14138 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14139 use MyEventBuilder only and let it wrap the real builder for us.
14141 (MyEventBuilder): Revamp constructor etc.
14143 Implement all operations that we perform on EventBuilder in precisely the same
14146 (FindMembers): Update to use the EventBuilder member.
14148 (Event.Emit): Update accordingly.
14150 2001-12-18 Ravi Pratap <ravi@ximian.com>
14152 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14153 by calling the appropriate methods.
14155 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14158 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14160 2001-12-17 Ravi Pratap <ravi@ximian.com>
14162 * delegate.cs (Delegate.Populate): Check that the return type
14163 and various parameters types are indeed accessible.
14165 * class.cs (Constructor.Define): Same here.
14167 (Field.Define): Ditto.
14169 (Event.Define): Ditto.
14171 (Operator.Define): Check that the underlying Method defined itself
14172 correctly - so it's MethodBuilder should not be null.
14174 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14175 expression happens to be null.
14177 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14178 members but as of now we don't seem to be able to do anything really useful with it.
14180 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14181 not the EventBuilder.
14183 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14185 * cs-tokenizer.cs: Add support for defines.
14186 Add support for #if, #elif, #else, #endif
14188 (eval_var): evaluates a variable.
14189 (eval): stubbed for evaluating functions.
14191 * cs-parser.jay: Pass the defines information
14193 * driver.cs: Add --define command line option.
14195 * decl.cs: Move MemberCore here.
14197 Make it the base class for DeclSpace. This allows us to catch and
14198 report 108 and 109 for everything now.
14200 * class.cs (TypeContainer.Define): Extract all the members
14201 before populating and emit the warning 108 (new keyword required
14202 to override) instead of having each member implement this.
14204 (MemberCore.Define): New abstract method, we will be using this in
14205 the warning reporting engine in Populate.
14207 (Operator.Define): Adjust to new MemberCore protocol.
14209 * const.cs (Const): This does not derive from Expression, it is a
14210 temporary object we use to create fields, it is a MemberCore.
14212 * class.cs (Method.Define): Allow the entry point to be in a
14215 * driver.cs: Rewrite the argument handler to clean it up a bit.
14217 * rootcontext.cs: Made it just an auxiliary namespace feature by
14218 making everything static.
14220 * driver.cs: Adapt code to use RootContext type name instead of
14223 * delegate.cs: Remove RootContext argument.
14225 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14228 * class.cs (Event.Define): The lookup can fail.
14230 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14232 * expression.cs: Resolve the this instance before invoking the code.
14234 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14236 * cs-parser.jay: Add a production in element_access that allows
14237 the thing to become a "type" reference. This way we can parse
14238 things like "(string [])" as a type.
14240 Note that this still does not handle the more complex rules of
14244 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14246 * ecore.cs: (CopyNewMethods): new utility function used to
14247 assemble the list of methods from running FindMembers.
14249 (MemberLookup): Rework FindMembers so that
14251 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14253 * class.cs (TypeContainer): Remove Delegates who fail to be
14256 * delegate.cs (Populate): Verify that we dont get null return
14257 values. TODO: Check for AsAccessible.
14259 * cs-parser.jay: Use basename to emit error 574 (destructor should
14260 have the same name as container class), not the full name.
14262 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14263 possible representation.
14265 Also implements integer type suffixes U and L.
14267 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14269 * expression.cs (ArrayCreation.DoResolve): We need to do the
14270 argument resolution *always*.
14272 * decl.cs: Make this hold the namespace. Hold the root context as
14274 (LookupType): Move here.
14276 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14278 * location.cs (Row, Name): Fixed the code, it was always returning
14279 references to the first file.
14281 * interface.cs: Register properties defined through interfaces.
14283 * driver.cs: Add support for globbing on the command line
14285 * class.cs (Field): Make it derive from MemberCore as well.
14288 2001-12-15 Ravi Pratap <ravi@ximian.com>
14290 * class.cs (Event::Define): Check that the type of the event is a delegate
14291 type else flag error #66.
14293 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14296 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14297 values of EntryPoint, CharSet etc etc.
14299 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14301 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14302 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14303 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14304 which needs this to do its work.
14306 * ../errors/cs0066.cs : Add.
14308 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14310 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14313 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14314 clears out the parameters field.
14315 (MemberSignatureCompare): Cleanup
14317 (MemberCore): New base class used to share code between MethodCore
14320 (RegisterRequiredImplementations) BindingFlags.Public requires
14321 either BindingFlags.Instace or Static. Use instance here.
14323 (Property): Refactored code to cope better with the full spec.
14325 * parameter.cs (GetParameterInfo): Return an empty array instead
14328 * class.cs (Property): Abstract or extern properties have no bodies.
14330 * parameter.cs (GetParameterInfo): return a zero-sized array.
14332 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14333 method modifier validation to the typecontainer so we can reuse
14334 this on properties.
14336 (MethodCore.ParameterTypes): return an empty sized array of types.
14338 (Property.Define): Test property modifier validity.
14340 Add tests for sealed/override too.
14342 (Method.Emit): abstract or extern methods have no bodies.
14344 2001-12-14 Ravi Pratap <ravi@ximian.com>
14346 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14349 (Method::Define, ::Emit): Modify accordingly.
14351 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14353 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14355 * makefile: Pass in /unsafe.
14357 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14359 * class.cs (MakeKey): Kill routine.
14361 * class.cs (TypeContainer.Define): Correctly define explicit
14362 method implementations (they require the full interface name plus
14365 * typemanager.cs: Deply the PtrHashtable here and stop using the
14366 lame keys. Things work so much better.
14368 This of course broke everyone who depended on `RegisterMethod' to
14369 do the `test for existance' test. This has to be done elsewhere.
14371 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14372 the object stupid Equals method (because, that like fails all over
14373 the place). We still do not use it.
14375 * class.cs (TypeContainer.SetRequiredInterface,
14376 TypeContainer.RequireMethods): Killed these two routines and moved
14377 all the functionality to RegisterRequiredImplementations.
14379 (TypeContainer.RegisterRequiredImplementations): This routine now
14380 registers all the implementations required in an array for the
14381 interfaces and abstract methods. We use an array of structures
14382 which can be computed ahead of time to reduce memory usage and we
14383 also assume that lookups are cheap as most classes will not
14384 implement too many interfaces.
14386 We also avoid creating too many MethodSignatures.
14388 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14389 clear the "pending" bit if we find that there are problems with
14392 (TypeContainer.VerifyPendingMethods): Update to report errors of
14393 methods that look like implementations but are not.
14395 (TypeContainer.Define): Add support for explicit interface method
14398 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14400 * typemanager.cs: Keep track of the parameters here instead of
14401 being a feature of the TypeContainer.
14403 * class.cs: Drop the registration of parameters here, as
14404 InterfaceMethods are also interface declarations.
14406 * delegate.cs: Register methods with the TypeManager not only with
14407 the TypeContainer. This code was buggy.
14409 * interface.cs: Full registation here.
14411 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14413 * expression.cs: Remove reducer for binary expressions, it can not
14416 * const.cs: Put here the code that used to go into constant.cs
14418 * constant.cs: Put here the code for constants, this is a new base
14419 class for Literals.
14421 * literal.cs: Make Literal derive from Constant.
14423 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14425 * statement.cs (Return.Emit): Report error 157 if the user
14426 attempts to return from a finally block.
14428 (Return.Emit): Instead of emitting a return, jump to the end of
14431 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14432 LocalBuilder to store the result of the function. ReturnLabel is
14433 the target where we jump.
14436 2001-12-09 Radek Doulik <rodo@ximian.com>
14438 * cs-parser.jay: remember alias in current namespace
14440 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14443 * class.cs (LookupAlias): lookup alias in my_namespace
14445 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14447 (LookupAlias): lookup alias in this and if needed in parent
14450 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14454 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14455 making things static. I need this to avoid passing the
14456 TypeContainer when calling ParameterType.
14458 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14459 that did string manipulation to compute the type and then call
14460 GetType. Use Parameter.ParameterType instead.
14462 * cs-tokenizer.cs: Consume the suffix for floating values.
14464 * expression.cs (ParameterReference): figure out whether this is a
14465 reference parameter or not. Kill an extra variable by computing
14466 the arg_idx during emission.
14468 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14469 function that returns whether a parameter is an out/ref value or not.
14471 (Parameter.ParameterType): The type of the parameter (base,
14472 without ref/out applied).
14474 (Parameter.Resolve): Perform resolution here.
14475 (Parameter.ExternalType): The full type (with ref/out applied).
14477 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14478 support for expressions on the using statement.
14480 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14482 * statement.cs (Using.EmitLocalVariableDecls): Split the
14483 localvariable handling of the using statement.
14485 (Block.EmitMeta): Keep track of variable count across blocks. We
14486 were reusing slots on separate branches of blocks.
14488 (Try.Emit): Emit the general code block, we were not emitting it.
14490 Check the type of the declaration to be an IDisposable or
14491 something that can be implicity converted to it.
14493 Emit conversions if required.
14495 * ecore.cs (EmptyExpression): New utility class.
14496 (Expression.ImplicitConversionExists): New utility function.
14498 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14500 * statement.cs (Using): Implement.
14502 * expression.cs (LocalVariableReference): Support read only variables.
14504 * statement.cs: Remove the explicit emit for the Leave opcode.
14505 (VariableInfo): Add a readonly field.
14507 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14509 * ecore.cs (ConvCast): new class used to encapsulate the various
14510 explicit integer conversions that works in both checked and
14511 unchecked contexts.
14513 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14514 properly generate the overflow opcodes.
14516 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14518 * statement.cs: The correct type for the EmptyExpression is the
14519 element_type, not the variable type. Ravi pointed this out.
14521 2001-12-04 Ravi Pratap <ravi@ximian.com>
14523 * class.cs (Method::Define): Handle PInvoke methods specially
14524 by using DefinePInvokeMethod instead of the usual one.
14526 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14527 above to do the task of extracting information and defining the method.
14529 2001-12-04 Ravi Pratap <ravi@ximian.com>
14531 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14532 of the condition for string type.
14534 (Emit): Move that here.
14536 (ArrayCreation::CheckIndices): Keep string literals in their expression
14539 (EmitDynamicInitializers): Handle strings appropriately.
14541 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14543 * codegen.cs (EmitContext): Replace multiple variables with a
14544 single pointer to the current Switch statement.
14546 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14549 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14553 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14556 (Foreach.Emit): Foreach on arrays was not setting
14557 up the loop variables (for break/continue).
14559 (GotoCase): Semi-implented.
14561 2001-12-03 Ravi Pratap <ravi@ximian.com>
14563 * attribute.cs (CheckAttribute): Handle system attributes by using
14564 Attribute.GetAttributes to examine information we need.
14566 (GetValidPlaces): Same here.
14568 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14570 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14572 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14574 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14576 (Method::Emit): Handle the case when we are a PInvoke method.
14578 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14580 * expression.cs: Use ResolveWithSimpleName on compound names.
14582 2001-12-02 Ravi Pratap <ravi@ximian.com>
14584 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14585 before trying to reduce it.
14587 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14589 * constant.cs (LookupConstantValue): Implement.
14591 (EmitConstant): Use the above in emitting the constant.
14593 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14594 that are user-defined by doing a LookupConstantValue on them.
14596 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14599 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14601 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14603 (BaseAccess.DoResolve): Implement.
14605 (MemberAccess.DoResolve): Split this routine into a
14606 ResolveMemberAccess routine that can be used independently
14608 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14610 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14611 As that share bits of the implementation. Is returns a boolean,
14612 while As returns the Type that is being probed.
14614 2001-12-01 Ravi Pratap <ravi@ximian.com>
14616 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14617 instead of a Literal - much easier.
14619 (EnumInTransit): Remove - utterly useless :-)
14621 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14623 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14625 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14626 chain when we have no associated expression.
14628 2001-11-30 Ravi Pratap <ravi@ximian.com>
14630 * constant.cs (Define): Use Location while reporting the errror.
14632 Also emit a warning when 'new' is used and there is no inherited
14635 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14638 (LookupEnumValue): Implement to lookup an enum member's value and define it
14641 (Populate): Re-write accordingly to use the above routine.
14643 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14645 * expression.cs (This): Fix prototype for DoResolveLValue to
14646 override the base class DoResolveLValue.
14648 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14651 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14652 (we need to load the address of the field here). This fixes
14655 (FieldExpr.DoResolveLValue): Call the DoResolve
14656 function to initialize the Instance expression.
14658 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14659 correctly the GetEnumerator operation on a value type.
14661 * cs-parser.jay: Add more simple parsing error catches.
14663 * statement.cs (Switch): Add support for string switches.
14664 Handle null specially.
14666 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14668 2001-11-28 Ravi Pratap <ravi@ximian.com>
14670 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14672 (declare_local_constant): New helper function.
14674 * statement.cs (AddConstant): Keep a separate record of constants
14676 (IsConstant): Implement to determine if a variable is a constant.
14678 (GetConstantExpression): Implement.
14680 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14682 * statement.cs (IsVariableDefined): Re-write.
14684 2001-11-27 Ravi Pratap <ravi@ximian.com>
14686 * class.cs (TypeContainer::FindMembers): Look for constants
14687 in the case when we are looking for MemberTypes.Field
14689 * expression.cs (MemberAccess::DoResolve): Check that in the
14690 case we are a FieldExpr and a Literal, we are not being accessed
14691 by an instance reference.
14693 * cs-parser.jay (local_constant_declaration): Implement.
14695 (declaration_statement): Implement for constant declarations.
14697 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14699 * statement.cs (Switch): Catch double defaults.
14701 (Switch): More work on the switch() statement
14702 implementation. It works for integral values now, need to finish
14706 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14708 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14709 integer literals into other integer literals. To be used by
14712 2001-11-24 Ravi Pratap <ravi@ximian.com>
14714 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14717 (EmitDynamicInitializers): Cope with the above since we extract data
14718 directly from ArrayData now.
14720 (ExpectInitializers): Keep track of whether initializers are mandatory
14723 (Bounds): Make it a hashtable to prevent the same dimension being
14724 recorded for every element in that dimension.
14726 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14729 Also fix bug which was causing the indices to be emitted in the reverse
14732 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14734 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14735 unfinished. They do not work, because the underlying code is
14738 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14740 * cs-parser.jay: Remove bogus fixme.
14742 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14743 on Switch statement.
14745 2001-11-23 Ravi Pratap <ravi@ximian.com>
14747 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14750 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14751 parameter. Apparently, any expression is allowed.
14753 (ValidateInitializers): Update accordingly.
14755 (CheckIndices): Fix some tricky bugs thanks to recursion.
14757 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14758 I was being completely brain-dead.
14760 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14761 and re-write acordingly.
14763 (DelegateInvocation): Re-write accordingly.
14765 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14767 (MakeByteBlob): Handle types more correctly.
14769 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14770 initialization from expressions but it is incomplete because I am a complete
14773 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14775 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14776 on If. Basically, we have to return `true' (ie, we do return to
14777 our caller) only if both branches of the if return.
14779 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14780 short-circuit operators, handle them as short circuit operators.
14782 (Cast.DoResolve): Resolve type.
14783 (Cast.Cast): Take an expression as the target type.
14785 * cs-parser.jay (cast_expression): Remove old hack that only
14786 allowed a limited set of types to be handled. Now we take a
14787 unary_expression and we resolve to a type during semantic
14790 Use the grammar productions from Rhys to handle casts (this is
14791 not complete like Rhys syntax yet, we fail to handle that corner
14792 case that C# has regarding (-x), but we will get there.
14794 2001-11-22 Ravi Pratap <ravi@ximian.com>
14796 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14797 field which is an array type.
14799 * cs-parser.jay (declare_local_variables): Support array initialization too.
14801 * typemanager.cs (MakeKey): Implement.
14803 (everywhere): Use the above appropriately.
14805 * cs-parser.jay (for_statement): Update for array initialization while
14806 declaring variables.
14808 * ecore.cs : The error message was correct, it's the variable's names that
14809 were misleading ;-) Make the code more readable.
14811 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14812 the correct type etc.
14814 (ConvertExplicit): Handle Enum types by examining the underlying type.
14816 2001-11-21 Ravi Pratap <ravi@ximian.com>
14818 * parameter.cs (GetCallingConvention): Always return
14819 CallingConventions.Standard for now.
14821 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14823 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14824 and `r' after calling DoNumericPromotions.
14826 * ecore.cs: Fix error message (the types were in the wrong order).
14828 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14829 BindingFlags.Instance as well
14831 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14832 implicit int literal conversion in an empty cast so that we
14833 propagate the right type upstream.
14835 (UnboxCast): new class used to unbox value types.
14836 (Expression.ConvertExplicit): Add explicit type conversions done
14839 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14840 the target type before applying the implicit LongLiterals to ULong
14843 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14845 * cs-parser.jay (for_statement): Reworked the way For works: now
14846 we declare manually any variables that are introduced in
14847 for_initializer to solve the problem of having out-of-band code
14848 emition (that is what got for broken).
14850 (declaration_statement): Perform the actual variable declaration
14851 that used to be done in local_variable_declaration here.
14853 (local_variable_declaration): Do not declare anything, just pass
14854 the information on a DictionaryEntry
14856 2001-11-20 Ravi Pratap <ravi@ximian.com>
14858 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14859 re-write of the logic to now make it recursive.
14861 (UpdateIndices): Re-write accordingly.
14863 Store element data in a separate ArrayData list in the above methods.
14865 (MakeByteBlob): Implement to dump the array data into a byte array.
14867 2001-11-19 Ravi Pratap <ravi@ximian.com>
14869 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
14872 * constant.cs (Define): Implement.
14874 (EmitConstant): Re-write fully.
14876 Pass in location info.
14878 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
14881 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
14882 DictionaryEntry since we need location info too.
14884 (constant_declaration): Update accordingly.
14886 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14887 code into another method : UpdateIndices.
14889 2001-11-18 Ravi Pratap <ravi@ximian.com>
14891 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14892 some type checking etc.
14894 2001-11-17 Ravi Pratap <ravi@ximian.com>
14896 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14897 bits to provide dimension info if the user skips doing that.
14899 Update second constructor to store the rank correctly.
14901 2001-11-16 Ravi Pratap <ravi@ximian.com>
14903 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14904 and try to implement.
14906 * ../errors/cs0150.cs : Add.
14908 * ../errors/cs0178.cs : Add.
14910 2001-11-16 Miguel de Icaza <miguel@ximian.com>
14912 * statement.cs: Implement foreach on multi-dimensional arrays.
14914 * parameter.cs (Parameters.GetParameterByName): Also lookup the
14915 name of the params argument.
14917 * expression.cs: Use EmitStoreOpcode to get the right opcode while
14918 initializing the array.
14920 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
14921 we can use this elsewhere.
14923 * statement.cs: Finish implementation of foreach for single
14926 * cs-parser.jay: Use an out-of-band stack to pass information
14927 around, I wonder why I need this.
14929 foreach_block: Make the new foreach_block the current_block.
14931 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
14932 function used to return a static Parameters structure. Used for
14933 empty parameters, as those are created very frequently.
14935 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
14937 2001-11-15 Ravi Pratap <ravi@ximian.com>
14939 * interface.cs : Default modifier is private, not public. The
14940 make verify test passes again.
14942 2001-11-15 Ravi Pratap <ravi@ximian.com>
14944 * support.cs (ReflectionParameters): Fix logic to determine
14945 whether the last parameter is a params one. Test 9 passes again.
14947 * delegate.cs (Populate): Register the builders we define with
14948 RegisterParameterForBuilder. Test 19 passes again.
14950 * cs-parser.jay (property_declaration): Reference $6 instead
14951 of $$ to get at the location.
14953 (indexer_declaration): Similar stuff.
14955 (attribute): Ditto.
14957 * class.cs (Property): Register parameters for the Get and Set methods
14958 if they exist. Test 23 passes again.
14960 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
14961 call to EmitArguments as we are sure there aren't any params arguments.
14962 Test 32 passes again.
14964 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
14965 IndexOutOfRangeException.
14967 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
14968 Test 33 now passes again.
14970 2001-11-15 Miguel de Icaza <miguel@ximian.com>
14972 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
14973 broke a bunch of things. Will have to come up with a better way
14974 of tracking locations.
14976 * statement.cs: Implemented foreach for single dimension arrays.
14978 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14980 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
14981 an error. This removes the lookup from the critical path.
14983 * cs-parser.jay: Removed use of temporary_loc, which is completely
14986 2001-11-14 Miguel de Icaza <miguel@ximian.com>
14988 * support.cs (ReflectionParameters.ParameterModifier): Report
14989 whether the argument is a PARAMS argument or not.
14991 * class.cs: Set the attribute `ParamArrayAttribute' on the
14992 parameter argument.
14994 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
14995 and cons_param_array_attribute (ConstructorInfo for
14996 ParamArrayAttribute).,
14998 * codegen.cs: Emit the return using the `Return' statement, that
14999 way we can report the error correctly for missing return values.
15001 * class.cs (Method.Emit): Clean up.
15003 * expression.cs (Argument.Resolve): Take another argument: the
15004 location where this argument is used. Notice that this is not
15005 part of the "Argument" class as to reduce the size of the
15006 structure (we know the approximate location anyways).
15008 Test if the argument is a variable-reference, if not, then
15009 complain with a 206.
15011 (Argument.Emit): Emit addresses of variables.
15013 (Argument.FullDesc): Simplify.
15015 (Invocation.DoResolve): Update for Argument.Resolve.
15017 (ElementAccess.DoResolve): ditto.
15019 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
15020 method should be virtual, as this method is always virtual.
15022 (NewDelegate.DoResolve): Update for Argument.Resolve.
15024 * class.cs (ConstructorInitializer.DoResolve): ditto.
15026 * attribute.cs (Attribute.Resolve): ditto.
15028 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15030 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
15032 * expression.cs (ParameterReference): Drop IStackStorage and implement
15033 IAssignMethod instead.
15035 (LocalVariableReference): ditto.
15037 * ecore.cs (FieldExpr): Drop IStackStorage and implement
15038 IAssignMethod instead.
15040 2001-11-13 Miguel de Icaza <miguel@ximian.com>
15042 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
15043 enumerations that are used in heavily used structures derive from
15044 byte in a laughable and pathetic attempt to reduce memory usage.
15045 This is the kind of pre-optimzations that you should not do at
15046 home without adult supervision.
15048 * expression.cs (UnaryMutator): New class, used to handle ++ and
15049 -- separatedly from the other unary operators. Cleans up the
15050 code, and kills the ExpressionStatement dependency in Unary.
15052 (Unary): Removed `method' and `Arguments' from this class, making
15053 it smaller, and moving it all to SimpleCall, so I can reuse this
15054 code in other locations and avoid creating a lot of transient data
15055 strucutres when not required.
15057 * cs-parser.jay: Adjust for new changes.
15059 2001-11-11 Miguel de Icaza <miguel@ximian.com>
15061 * enum.cs (Enum.Populate): If there is a failure during
15064 * cs-parser.jay (opt_enum_base): we used to catch type errors
15065 here, but this is really incorrect. The type error should be
15066 catched during semantic analysis.
15068 2001-12-11 Ravi Pratap <ravi@ximian.com>
15070 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
15071 current_local_parameters as expected since I, in my stupidity, had forgotten
15074 * attribute.cs (GetValidPlaces): Fix stupid bug.
15076 * class.cs (Method::Emit): Perform check on applicability of attributes.
15078 (Constructor::Emit): Ditto.
15080 (Field::Emit): Ditto.
15082 (Field.Location): Store location information.
15084 (Property, Event, Indexer, Operator): Ditto.
15086 * cs-parser.jay (field_declaration): Pass in location for each field.
15088 * ../errors/cs0592.cs : Add.
15090 2001-11-12 Ravi Pratap <ravi@ximian.com>
15092 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
15094 (InitCoreTypes): Update accordingly.
15096 (RegisterAttrType, LookupAttr): Implement.
15098 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
15099 info about the same.
15101 (Resolve): Update to populate the above as necessary.
15103 (Error592): Helper.
15105 (GetValidPlaces): Helper to the above.
15107 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
15109 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
15111 2001-11-12 Ravi Pratap <ravi@ximian.com>
15113 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
15115 * ../errors/cs0617.cs : Add.
15117 2001-11-11 Ravi Pratap <ravi@ximian.com>
15119 * enum.cs (Emit): Rename to Populate to be more consistent with what
15120 we expect it to do and when exactly it is called.
15122 * class.cs, rootcontext.cs : Update accordingly.
15124 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15125 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15127 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15129 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15130 of a fieldinfo using the above, when dealing with a FieldBuilder.
15132 2001-11-10 Ravi Pratap <ravi@ximian.com>
15134 * ../errors/cs0031.cs : Add.
15136 * ../errors/cs1008.cs : Add.
15138 * ../errrors/cs0543.cs : Add.
15140 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15143 (FindMembers): Implement.
15145 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15146 enums and delegates too.
15148 (enum_types): Rename to builder_to_enum.
15150 (delegate_types): Rename to builder_to_delegate.
15152 * delegate.cs (FindMembers): Implement.
15154 2001-11-09 Ravi Pratap <ravi@ximian.com>
15156 * typemanager.cs (IsEnumType): Implement.
15158 * enum.cs (Emit): Re-write parts to account for the underlying type
15159 better and perform checking etc.
15161 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15162 of the underlying type.
15164 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15167 * enum.cs (error31): Helper to report error #31.
15169 * cs-parser.jay (enum_declaration): Store location of each member too.
15171 * enum.cs (member_to_location): New hashtable.
15173 (AddEnumMember): Update location hashtable.
15175 (Emit): Use the location of each member while reporting errors.
15177 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15179 * cs-parser.jay: A for_initializer if is a
15180 local_variable_declaration really ammount to have an implicit
15181 block with the variable declaration and no initializer for for.
15183 * statement.cs (For.Emit): Cope with null initializers.
15185 This fixes the infinite loop on for initializers.
15187 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15189 * enum.cs: More cleanup.
15191 * ecore.cs: Remove dead code.
15193 * class.cs (Property.Emit): More simplification.
15194 (Event.Emit): ditto.
15196 Reworked to have less levels of indentation.
15198 2001-11-08 Ravi Pratap <ravi@ximian.com>
15200 * class.cs (Property): Emit attributes.
15210 * enum.cs (Emit): Ditto.
15212 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15215 * class.cs (Field, Event, etc.): Move attribute generation into the
15216 Emit method everywhere.
15218 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15219 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15220 as we had no way of defining nested enums !
15222 * rootcontext.cs : Adjust code accordingly.
15224 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15226 2001-11-07 Ravi Pratap <ravi@ximian.com>
15228 * expression.cs (EvalConstantExpression): Move into ecore.cs
15230 * enum.cs (Enum): Rename some members and make them public and readonly
15231 according to our convention.
15233 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15236 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15238 (Enum::Emit): Write a simple version for now which doesn't try to compute
15239 expressions. I shall modify this to be more robust in just a while.
15241 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15243 (TypeContainer::CloseType): Create the Enum types too.
15245 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15247 * expression.cs (EvalConstantExpression): Get rid of completely.
15249 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15250 user-defined values and other cases.
15252 (IsValidEnumLiteral): Helper function.
15254 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15255 out there in the case we had a literal FieldExpr.
15257 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15259 (Literalize): Revamp a bit to take two arguments.
15261 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15263 2001-11-06 Ravi Pratap <ravi@ximian.com>
15265 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15267 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15269 (Resolve): Use the above to ensure we have proper initializers.
15271 2001-11-05 Ravi Pratap <ravi@ximian.com>
15273 * expression.cs (Expression::EvalConstantExpression): New method to
15274 evaluate constant expressions.
15276 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15278 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15280 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15283 (Binary.ResolveOperator): Handle operator != (object a, object b)
15284 and operator == (object a, object b);
15286 (Binary.DoNumericPromotions): Indicate whether the numeric
15287 promotion was possible.
15289 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15292 Made the ArrayAccess implement interface IAssignMethod instead of
15293 IStackStore as the order in which arguments are passed reflects
15296 * assign.cs: Instead of using expr.ExprClass to select the way of
15297 assinging, probe for the IStackStore/IAssignMethod interfaces.
15299 * typemanager.cs: Load InitializeArray definition.
15301 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15302 static data that can be used to initialize arrays.
15304 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15306 * expression.cs: Handle operator== and operator!= for booleans.
15308 (Conditioal.Reduce): Implement reducer for the ?: operator.
15310 (Conditional.Resolve): Implement dead code elimination.
15312 (Binary.Resolve): Catch string literals and return a new
15313 concatenated string.
15315 (Unary.Reduce): Implement reduction of unary expressions.
15317 * ecore.cs: Split out the expression core handling here.
15319 (Expression.Reduce): New method used to perform constant folding
15320 and CSE. This is needed to support constant-expressions.
15322 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15323 targets, and optimize for !x.
15325 2001-11-04 Ravi Pratap <ravi@ximian.com>
15327 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15328 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15329 set custom atttributes.
15331 * literal.cs (Literal::GetValue): New abstract method to return the actual
15332 value of the literal, cast as an object.
15334 (*Literal): Implement GetValue method.
15336 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15337 expressions to the arraylist but objects of type Argument.
15339 * class.cs (TypeContainer::Emit): Emit our attributes too.
15341 (Method::Emit, Constructor::Emit): Ditto.
15343 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15344 to be ignoring earlier.
15346 2001-11-03 Ravi Pratap <ravi@ximian.com>
15348 * attribute.cs (AttributeSection::Define): Implement to do the business
15349 of constructing a CustomAttributeBuilder.
15351 (Attribute): New trivial class. Increases readability of code.
15353 * cs-parser.jay : Update accordingly.
15355 (positional_argument_list, named_argument_list, named_argument): New rules
15357 (attribute_arguments): Use the above so that we are more correct.
15359 2001-11-02 Ravi Pratap <ravi@ximian.com>
15361 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15362 to perform all checks for a method with a params parameter.
15364 (Invocation::OverloadResolve): Update to use the above method and therefore
15365 cope correctly with params method invocations.
15367 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15370 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15371 constructors in our parent too because we can't afford to miss out on
15374 * attribute.cs (AttributeSection): New name for the class Attribute
15376 Other trivial changes to improve readability.
15378 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15379 use the new class names.
15381 2001-11-01 Ravi Pratap <ravi@ximian.com>
15383 * class.cs (Method::Define): Complete definition for params types too
15385 (Indexer::Define): Ditto.
15387 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15388 Cope everywhere with a request for info about the array parameter.
15390 2001-11-01 Ravi Pratap <ravi@ximian.com>
15392 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15394 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15395 local_variable_type to extract the string corresponding to the type.
15397 (local_variable_type): Fixup the action to use the new helper method.
15399 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15402 * expression.cs : Clean out code which uses the above.
15404 2001-10-31 Ravi Pratap <ravi@ximian.com>
15406 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15407 and bale out if necessary by returning a false.
15409 (RegisterProperty): Ditto.
15411 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15412 and print out appropriate error messages.
15414 * interface.cs (everywhere): Ditto.
15416 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15417 location to constructor.
15419 * class.cs (Property, Event, Indexer): Update accordingly.
15421 * ../errors/cs111.cs : Added.
15423 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15424 of a method, as laid down by the spec.
15426 (Invocation::OverloadResolve): Use the above method.
15428 2001-10-31 Ravi Pratap <ravi@ximian.com>
15430 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15431 now take a TypeContainer and a Parameters object.
15433 (ParameterData): Modify return type of ParameterModifier method to be
15434 Parameter.Modifier and not a string.
15436 (ReflectionParameters, InternalParameters): Update accordingly.
15438 * expression.cs (Argument::GetParameterModifier): Same here.
15440 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15441 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15442 symbol in it at all so maybe this is only for now.
15444 2001-10-30 Ravi Pratap <ravi@ximian.com>
15446 * support.cs (InternalParameters): Constructor now takes an extra argument
15447 which is the actual Parameters class.
15449 (ParameterDesc): Update to provide info on ref/out modifiers.
15451 * class.cs (everywhere): Update call to InternalParameters to pass in
15452 the second argument too.
15454 * support.cs (ParameterData): Add ParameterModifier, which is a method
15455 to return the modifier info [ref/out etc]
15457 (InternalParameters, ReflectionParameters): Implement the above.
15459 * expression.cs (Argument::ParameterModifier): Similar function to return
15460 info about the argument's modifiers.
15462 (Invocation::OverloadResolve): Update to take into account matching modifiers
15465 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15466 a new SetFormalParameters object which we pass to InternalParameters.
15468 2001-10-30 Ravi Pratap <ravi@ximian.com>
15470 * expression.cs (NewArray): Merge into the ArrayCreation class.
15472 2001-10-29 Ravi Pratap <ravi@ximian.com>
15474 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15475 NewUserdefinedArray into one as there wasn't much of a use in having
15478 * expression.cs (Argument): Change field's name to ArgType from Type.
15480 (Type): New readonly property which returns the proper type, taking into
15481 account ref/out modifiers.
15483 (everywhere): Adjust code accordingly for the above.
15485 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15486 whether we are emitting for a ref or out parameter.
15488 * expression.cs (Argument::Emit): Use the above field to set the state.
15490 (LocalVariableReference::Emit): Update to honour the flag and emit the
15493 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15495 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15497 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15499 (ReflectionParameters, InternalParameters): Implement the above method.
15501 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15504 (Invocation::FullMethodDesc): Ditto.
15506 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15508 * cs-parser.jay: Add extra production for the second form of array
15511 * expression.cs (ArrayCreation): Update to reflect the above
15514 * Small changes to prepare for Array initialization.
15516 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15518 * typemanager.cs (ImplementsInterface): interface might be null;
15519 Deal with this problem;
15521 Also, we do store negative hits on the cache (null values), so use
15522 this instead of calling t.GetInterfaces on the type everytime.
15524 2001-10-28 Ravi Pratap <ravi@ximian.com>
15526 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15528 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15529 split functionality out into different classes.
15531 (New::FormArrayType): Move into NewBuiltinArray.
15533 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15536 (NewBuiltinArray): New class to handle creation of built-in arrays.
15538 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15539 account creation of one-dimensional arrays.
15541 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15543 (NewUserdefinedArray::DoResolve): Implement.
15545 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15547 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15548 we maintain inside the TypeManager. This is necessary to perform lookups on the
15551 (LookupType): Update to perform GetType on the module builders too.
15553 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15555 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15557 2001-10-23 Ravi Pratap <ravi@ximian.com>
15559 * expression.cs (New::DoResolve): Implement guts of array creation.
15561 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15563 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15565 * expression.cs: Fix bug I introduced lsat night that broke
15568 (Expression.Resolve): Report a 246 error (can not resolve name)
15569 if we find a SimpleName in the stream.
15571 (Expression.ResolveLValue): Ditto.
15573 (Expression.ResolveWithSimpleName): This function is a variant of
15574 ResolveName, this one allows SimpleNames to be returned without a
15575 warning. The only consumer of SimpleNames is MemberAccess
15577 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15579 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15580 might arrive here. I have my doubts that this is correct.
15582 * statement.cs (Lock): Implement lock statement.
15584 * cs-parser.jay: Small fixes to support `lock' and `using'
15586 * cs-tokenizer.cs: Remove extra space
15588 * driver.cs: New flag --checked, allows to turn on integer math
15591 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15592 Threading.Monitor.Exit
15594 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15596 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15597 Expression Class to be IndexerAccess.
15599 Notice that Indexer::DoResolve sets the eclass to Value.
15601 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15603 * class.cs (TypeContainer::Emit): Emit code for indexers.
15605 * assign.cs (IAssignMethod): New interface implemented by Indexers
15606 and Properties for handling assignment.
15608 (Assign::Emit): Simplify and reuse code.
15610 * expression.cs (IndexerAccess, PropertyExpr): Implement
15611 IAssignMethod, clean up old code.
15613 2001-10-22 Ravi Pratap <ravi@ximian.com>
15615 * typemanager.cs (ImplementsInterface): New method to determine if a type
15616 implements a given interface. Provides a nice cache too.
15618 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15621 (ConvertReferenceExplicit): Ditto.
15623 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15624 various methods, with correct names etc.
15626 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15627 Operator.UnaryNegation.
15629 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15630 we have a unary plus or minus operator.
15632 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15635 * everywhere : update accordingly.
15637 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15640 * class.cs (Method::Define): For the case where we are implementing a method
15641 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15642 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15644 2001-10-21 Ravi Pratap <ravi@ximian.com>
15646 * interface.cs (FindMembers): Implement to work around S.R.E
15649 * typemanager.cs (IsInterfaceType): Implement.
15651 (FindMembers): Update to handle interface types too.
15653 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15654 use IsAssignableFrom as that is not correct - it doesn't work.
15656 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15657 and accordingly override EmitStatement.
15659 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15660 using the correct logic :-)
15662 2001-10-19 Ravi Pratap <ravi@ximian.com>
15664 * ../errors/cs-11.cs : Add to demonstrate error -11
15666 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15668 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15669 then pass this as a hint to ResolveLValue.
15671 * expression.cs (FieldExpr): Add Location information
15673 (FieldExpr::LValueResolve): Report assignment to readonly
15676 (Expression::ExprClassFromMemberInfo): Pass location information.
15678 (Expression::ResolveLValue): Add new method that resolves an
15681 (Expression::DoResolveLValue): Default invocation calls
15684 (Indexers): New class used to keep track of indexers in a given
15687 (IStackStore): Renamed from LValue, as it did not really describe
15688 what this did. Also ResolveLValue is gone from this interface and
15689 now is part of Expression.
15691 (ElementAccess): Depending on the element access type
15693 * typemanager.cs: Add `indexer_name_type' as a Core type
15694 (System.Runtime.CompilerServices.IndexerNameAttribute)
15696 * statement.cs (Goto): Take a location.
15698 2001-10-18 Ravi Pratap <ravi@ximian.com>
15700 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15701 if two delegates are compatible.
15703 (NewDelegate::DoResolve): Update to take care of the case when
15704 we instantiate a delegate from another delegate.
15706 * typemanager.cs (FindMembers): Don't even try to look up members
15707 of Delegate types for now.
15709 2001-10-18 Ravi Pratap <ravi@ximian.com>
15711 * delegate.cs (NewDelegate): New class to take care of delegate
15714 * expression.cs (New): Split the delegate related code out into
15715 the NewDelegate class.
15717 * delegate.cs (DelegateInvocation): New class to handle delegate
15720 * expression.cs (Invocation): Split out delegate related code into
15721 the DelegateInvocation class.
15723 2001-10-17 Ravi Pratap <ravi@ximian.com>
15725 * expression.cs (New::DoResolve): Implement delegate creation fully
15726 and according to the spec.
15728 (New::DoEmit): Update to handle delegates differently.
15730 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15731 because of which we were printing out arguments in reverse order !
15733 * delegate.cs (VerifyMethod): Implement to check if the given method
15734 matches the delegate.
15736 (FullDelegateDesc): Implement.
15738 (VerifyApplicability): Implement.
15740 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15741 delegate invocations too.
15743 (Invocation::Emit): Ditto.
15745 * ../errors/cs1593.cs : Added.
15747 * ../errors/cs1594.cs : Added.
15749 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15751 2001-10-16 Ravi Pratap <ravi@ximian.com>
15753 * typemanager.cs (intptr_type): Core type for System.IntPtr
15755 (InitCoreTypes): Update for the same.
15757 (iasyncresult_type, asynccallback_type): Ditto.
15759 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15762 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15765 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15766 the builders for the 4 members of a delegate type :-)
15768 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15771 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15773 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15775 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15777 * statement.cs (Break::Emit): Implement.
15778 (Continue::Emit): Implement.
15780 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15781 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15782 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15783 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15786 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15787 properties that track the label for the current loop (begin of the
15788 loop and end of the loop).
15790 2001-10-15 Ravi Pratap <ravi@ximian.com>
15792 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15793 use of emitting anything at all.
15795 * class.cs, rootcontext.cs : Get rid of calls to the same.
15797 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15799 (Populate): Define the constructor correctly and set the implementation
15802 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15805 (AddDelegateType): Implement.
15807 (IsDelegateType): Implement helper method.
15809 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15811 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15812 and accordingly handle it.
15814 * delegate.cs (Populate): Take TypeContainer argument.
15815 Implement bits to define the Invoke method. However, I still haven't figured out
15816 how to take care of the native int bit :-(
15818 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15819 Qualify the name of the delegate, not its return type !
15821 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15824 (StandardConversionExists): Checking for array types turns out to be recursive.
15826 (ConvertReferenceExplicit): Implement array conversion.
15828 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15830 2001-10-12 Ravi Pratap <ravi@ximian.com>
15832 * cs-parser.jay (delegate_declaration): Store the fully qualified
15833 name as it is a type declaration.
15835 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15838 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15839 as TypeContainer::DefineType.
15841 (Populate): Method in which all the definition of the various methods (Invoke)
15844 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15847 (CloseDelegate): Finally creates the delegate.
15849 * class.cs (TypeContainer::DefineType): Update to define delegates.
15850 (Populate, Emit and CloseType): Do the same thing here too.
15852 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15853 delegates in all these operations.
15855 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15857 * expression.cs: LocalTemporary: a new expression used to
15858 reference a temporary that has been created.
15860 * assign.cs: Handle PropertyAccess back here, so that we can
15861 provide the proper semantic access to properties.
15863 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15864 a few more explicit conversions.
15866 * modifiers.cs: `NEW' modifier maps to HideBySig.
15868 * expression.cs (PropertyExpr): Make this into an
15869 ExpressionStatement, and support the EmitStatement code path.
15871 Perform get/set error checking, clean up the interface.
15873 * assign.cs: recognize PropertyExprs as targets, and if so, turn
15874 them into toplevel access objects.
15876 2001-10-12 Miguel de Icaza <miguel@ximian.com>
15878 * expression.cs: PropertyExpr::PropertyExpr: use work around the
15881 * typemanager.cs: Keep track here of our PropertyBuilders again to
15882 work around lameness in SRE.
15884 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15886 * expression.cs (LValue::LValueResolve): New method in the
15887 interface, used to perform a second resolution pass for LValues.
15889 (This::DoResolve): Catch the use of this in static methods.
15891 (This::LValueResolve): Implement.
15893 (This::Store): Remove warning, assigning to `this' in structures
15896 (Invocation::Emit): Deal with invocation of
15897 methods on value types. We need to pass the address to structure
15898 methods rather than the object itself. (The equivalent code to
15899 emit "this" for structures leaves the entire structure on the
15900 stack instead of a pointer to it).
15902 (ParameterReference::DoResolve): Compute the real index for the
15903 argument based on whether the method takes or not a `this' pointer
15904 (ie, the method is static).
15906 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
15907 value types returned from functions when we need to invoke a
15908 method on the sturcture.
15911 2001-10-11 Ravi Pratap <ravi@ximian.com>
15913 * class.cs (TypeContainer::DefineType): Method to actually do the business of
15914 defining the type in the Modulebuilder or Typebuilder. This is to take
15915 care of nested types which need to be defined on the TypeBuilder using
15916 DefineNestedMethod.
15918 (TypeContainer::GetClassBases): Implement. Essentially the code from the
15919 methods in RootContext, only ported to be part of TypeContainer.
15921 (TypeContainer::GetInterfaceOrClass): Ditto.
15923 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
15925 * interface.cs (Interface::DefineInterface): New method. Does exactly
15926 what RootContext.CreateInterface did earlier, only it takes care of nested types
15929 (Interface::GetInterfaces): Move from RootContext here and port.
15931 (Interface::GetInterfaceByName): Same here.
15933 * rootcontext.cs (ResolveTree): Re-write.
15935 (PopulateTypes): Re-write.
15937 * class.cs (TypeContainer::Populate): Populate nested types too.
15938 (TypeContainer::Emit): Emit nested members too.
15940 * typemanager.cs (AddUserType): Do not make use of the FullName property,
15941 instead just use the name argument passed in as it is already fully
15944 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
15945 to TypeContainer mapping to see if a type is user-defined.
15947 * class.cs (TypeContainer::CloseType): Implement.
15949 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
15950 the default constructor.
15952 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
15955 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
15957 * interface.cs (CloseType): Create the type here.
15959 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
15962 Remove all the methods which are now in TypeContainer.
15964 2001-10-10 Ravi Pratap <ravi@ximian.com>
15966 * delegate.cs (Define): Re-write bits to define the delegate
15969 2001-10-10 Miguel de Icaza <miguel@ximian.com>
15971 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
15973 * expression.cs (ImplicitReferenceConversion): handle null as well
15974 as a source to convert to any reference type.
15976 * statement.cs (Return): Perform any implicit conversions to
15977 expected return type.
15979 Validate use of return statement.
15981 * codegen.cs (EmitContext): Pass the expected return type here.
15983 * class.cs (Method, Constructor, Property): Pass expected return
15984 type to EmitContext.
15986 2001-10-09 Miguel de Icaza <miguel@ximian.com>
15988 * expression.cs: Make DoResolve take an EmitContext instead of a
15991 Replaced `l' and `location' for `loc', for consistency.
15993 (Error, Warning): Remove unneeded Tc argument.
15995 * assign.cs, literal.cs, constant.cs: Update to new calling
15998 * codegen.cs: EmitContext now contains a flag indicating whether
15999 code is being generated in a static method or not.
16001 * cs-parser.jay: DecomposeQI, new function that replaces the old
16002 QualifiedIdentifier. Now we always decompose the assembled
16003 strings from qualified_identifier productions into a group of
16006 2001-10-08 Miguel de Icaza <miguel@ximian.com>
16008 * rootcontext.cs: Deal with field-less struct types correctly now
16009 by passing the size option to Define Type.
16011 * class.cs: Removed hack that created one static field.
16013 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16015 * statement.cs: Moved most of the code generation here.
16017 2001-10-09 Ravi Pratap <ravi@ximian.com>
16019 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
16022 (ElementAccess): Remove useless bits for now - keep checks as the spec
16025 2001-10-08 Ravi Pratap <ravi@ximian.com>
16027 * expression.cs (ElementAccess::DoResolve): Remove my crap code
16028 and start performing checks according to the spec.
16030 2001-10-07 Ravi Pratap <ravi@ximian.com>
16032 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
16033 rank_specifiers instead.
16035 (rank_specifiers): Change the order in which the rank specifiers are stored
16037 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
16039 * expression.cs (ElementAccess): Implement the LValue interface too.
16041 2001-10-06 Ravi Pratap <ravi@ximian.com>
16043 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
16044 except that user defined conversions are not included.
16046 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
16047 perform the conversion of the return type, if necessary.
16049 (New::DoResolve): Check whether we are creating an array or an object
16050 and accordingly do the needful.
16052 (New::Emit): Same here.
16054 (New::DoResolve): Implement guts of array creation.
16056 (New::FormLookupType): Helper function.
16058 2001-10-07 Miguel de Icaza <miguel@ximian.com>
16060 * codegen.cs: Removed most of the code generation here, and move the
16061 corresponding code generation bits to the statement classes.
16063 Added support for try/catch/finalize and throw.
16065 * cs-parser.jay: Added support for try/catch/finalize.
16067 * class.cs: Catch static methods having the flags override,
16068 virtual or abstract.
16070 * expression.cs (UserCast): This user cast was not really doing
16071 what it was supposed to do. Which is to be born in fully resolved
16072 state. Parts of the resolution were being performed at Emit time!
16076 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16078 * expression.cs: Implicity convert the result from UserCast.
16080 2001-10-05 Ravi Pratap <ravi@ximian.com>
16082 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
16083 prevented it from working correctly.
16085 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
16086 merely ConvertImplicit.
16088 2001-10-05 Miguel de Icaza <miguel@ximian.com>
16090 * typemanager.cs: Make the LookupTypeContainer function static,
16091 and not per-instance.
16093 * class.cs: Make static FindMembers (the one that takes a Type
16096 * codegen.cs: Add EmitForeach here.
16098 * cs-parser.jay: Make foreach a toplevel object instead of the
16099 inline expansion, as we need to perform semantic analysis on it.
16101 2001-10-05 Ravi Pratap <ravi@ximian.com>
16103 * expression.cs (Expression::ImplicitUserConversion): Rename to
16104 UserDefinedConversion.
16106 (Expression::UserDefinedConversion): Take an extra argument specifying
16107 whether we look for explicit user conversions too.
16109 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
16111 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
16113 (ExplicitUserConversion): Make it a call to UserDefinedConversion
16114 with the appropriate arguments.
16116 * cs-parser.jay (cast_expression): Record location too.
16118 * expression.cs (Cast): Record location info.
16120 (Expression::ConvertExplicit): Take location argument.
16122 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16123 to determine if we are doing explicit conversions.
16125 (UserCast::Emit): Update accordingly.
16127 (Expression::ConvertExplicit): Report an error if everything fails.
16129 * ../errors/cs0030.cs : Add.
16131 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16133 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16134 virtual and newslot bits.
16136 * class.cs (TypeContainer::RegisterRequiredImplementations):
16137 Record methods we need.
16139 (TypeContainer::MakeKey): Helper function to make keys for
16140 MethodBases, since the Methodbase key is useless.
16142 (TypeContainer::Populate): Call RegisterRequiredImplementations
16143 before defining the methods.
16145 Create a mapping for method_builders_to_methods ahead of time
16146 instead of inside a tight loop.
16148 (::RequireMethods): Accept an object as the data to set into the
16149 hashtable so we can report interface vs abstract method mismatch.
16151 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16153 * report.cs: Make all of it static.
16155 * rootcontext.cs: Drop object_type and value_type computations, as
16156 we have those in the TypeManager anyways.
16158 Drop report instance variable too, now it is a global.
16160 * driver.cs: Use try/catch on command line handling.
16162 Add --probe option to debug the error reporting system with a test
16165 * report.cs: Add support for exiting program when a probe
16166 condition is reached.
16168 2001-10-03 Ravi Pratap <ravi@ximian.com>
16170 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16171 we do a forcible conversion regardless of type, to check if
16172 ForceConversion returns a null.
16174 (Binary::error19): Use location to report error.
16176 (Unary::error23): Use location here too.
16178 * ../errors/cs0019.cs : Check in.
16180 * ../errors/cs0023.cs : Check in.
16182 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16183 case of a non-null MethodInfo object with a length of 0 !
16185 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16186 an applicable member - according to the spec :-)
16187 Also fix logic to find members in base types.
16189 (Unary::ResolveOperator): Same here.
16191 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16192 as I was getting thoroughly confused between this and error19 :-)
16194 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16195 (::FindMostEncompassedType): Implement.
16196 (::FindMostEncompassingType): Implement.
16197 (::StandardConversionExists): Implement.
16199 (UserImplicitCast): Re-vamp. We now need info about most specific
16200 source and target types so that we can do the necessary conversions.
16202 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16203 mathematical union with no duplicates.
16205 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16207 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16208 in order from base classes to child classes, so that we can in
16209 child classes look up in our parent for method names and
16210 attributes (required for handling abstract, virtual, new, override
16211 constructs: we need to instrospect our base class, and if we dont
16212 populate the classes in order, the introspection might be
16213 incorrect. For example, a method could query its parent before
16214 the parent has any methods and would determine that the parent has
16215 no abstract methods (while it could have had them)).
16217 (RootContext::CreateType): Record the order in which we define the
16220 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16222 * class.cs (TypeContainer::Populate): Also method definitions can
16223 fail now, keep track of this.
16225 (TypeContainer::FindMembers): Implement support for
16226 DeclaredOnly/noDeclaredOnly flag.
16228 (Constructor::Emit) Return the ConstructorBuilder.
16230 (Method::Emit) Return the MethodBuilder.
16231 Check for abstract or virtual methods to be public.
16233 * rootcontext.cs (RootContext::CreateType): Register all the
16234 abstract methods required for the class to be complete and the
16235 interface methods that must be implemented.
16237 * cs-parser.jay: Report error 501 (method requires body if it is
16238 not marked abstract or extern).
16240 * expression.cs (TypeOf::Emit): Implement.
16242 * typemanager.cs: runtime_handle_type, new global type.
16244 * class.cs (Property::Emit): Generate code for properties.
16246 2001-10-02 Ravi Pratap <ravi@ximian.com>
16248 * expression.cs (Unary::ResolveOperator): Find operators on base type
16249 too - we now conform exactly to the spec.
16251 (Binary::ResolveOperator): Same here.
16253 * class.cs (Operator::Define): Fix minor quirk in the tests.
16255 * ../errors/cs0215.cs : Added.
16257 * ../errors/cs0556.cs : Added.
16259 * ../errors/cs0555.cs : Added.
16261 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16263 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16264 single integer which is really efficient
16266 2001-10-01 Ravi Pratap <ravi@ximian.com>
16268 * expression.cs (Expression::ImplicitUserConversion): Use location
16269 even in the case when we are examining True operators.
16271 * class.cs (Operator::Define): Perform extensive checks to conform
16272 with the rules for operator overloading in the spec.
16274 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16275 some of the other conversions mentioned in the spec.
16277 * typemanager.cs (array_type): New static member for the System.Array built-in
16280 (cloneable_interface): For System.ICloneable interface.
16282 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16283 we start resolving the tree and populating types.
16285 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16287 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16289 * expression.cs (Expression::ExprClassFromMemberInfo,
16290 Expression::Literalize): Create literal expressions from
16291 FieldInfos which are literals.
16293 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16294 type casts, because they were wrong. The test suite in tests
16297 (ImplicitNumericConversion): ushort to ulong requires a widening
16300 Int32 constant to long requires widening cast as well.
16302 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16303 for integers because the type on the stack is not i4.
16305 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16307 * expression.cs (report118): require location argument.
16309 * parameter.cs: Do not dereference potential null value.
16311 * class.cs: Catch methods that lack the `new' keyword when
16312 overriding a name. Report warnings when `new' is used without
16313 anything being there to override.
16315 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16317 * class.cs: Only add constructor to hashtable if it is non-null
16318 (as now constructors can fail on define).
16320 (TypeManager, Class, Struct): Take location arguments.
16322 Catch field instance initialization in structs as errors.
16324 accepting_filter: a new filter for FindMembers that is static so
16325 that we dont create an instance per invocation.
16327 (Constructor::Define): Catch errors where a struct constructor is
16330 * cs-parser.jay: Pass location information for various new
16333 * delegate.cs (Delegate): take a location argument.
16335 * driver.cs: Do not call EmitCode if there were problesm in the
16336 Definition of the types, as many Builders wont be there.
16338 * decl.cs (Decl::Decl): Require a location argument.
16340 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16341 into integers, and find the most appropiate integer for it.
16343 * literal.cs: Implement ULongLiteral.
16345 * rootcontext.cs: Provide better information about the location of
16346 failure when CreateType fails.
16348 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16350 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16353 * expression.cs (Binary::CheckShiftArguments): Add missing type
16355 (Binary::ResolveOperator): Add type to the logical and and logical
16356 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16359 (Binary::DoNumericPromotions): In the case where either argument
16360 is ulong (and most signed types combined with ulong cause an
16361 error) perform implicit integer constant conversions as well.
16363 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16365 * expression.cs (UserImplicitCast): Method should always be
16367 (Invocation::BetterConversion): Simplified test for IntLiteral.
16369 (Expression::ImplicitNumericConversion): Split this routine out.
16370 Put the code that performs implicit constant integer conversions
16373 (Expression::Resolve): Become a wrapper around DoResolve so we can
16374 check eclass and type being set after resolve.
16376 (Invocation::Badness): Remove this dead function
16378 (Binary::ResolveOperator): Do not compute the expensive argumnets
16379 unless we have a union for it.
16381 (Probe::Emit): Is needs to do an isinst and then
16382 compare against null.
16384 (::CanConvert): Added Location argument. If the Location argument
16385 is null (Location.Null), then we do not report errors. This is
16386 used by the `probe' mechanism of the Explicit conversion. We do
16387 not want to generate an error for something that the user
16388 explicitly requested to be casted. But the pipeline for an
16389 explicit cast first tests for potential implicit casts.
16391 So for now, if the Location is null, it means `Probe only' to
16392 avoid adding another argument. Might have to revise this
16395 (ClassCast): New class used to type cast objects into arbitrary
16396 classes (used in Explicit Reference Conversions).
16398 Implement `as' as well.
16400 Reverted all the patches from Ravi below: they were broken:
16402 * The use of `level' as a mechanism to stop recursive
16403 invocations is wrong. That was there just to catch the
16404 bug with a strack trace but not as a way of addressing
16407 To fix the problem we have to *understand* what is going
16408 on and the interactions and come up with a plan, not
16409 just get things going.
16411 * The use of the type conversion cache that I proposed
16412 last night had an open topic: How does this work across
16413 protection domains. A user defined conversion might not
16414 be public in the location where we are applying the
16415 conversion, a different conversion might be selected
16416 (ie, private A->B (better) but public B->A (worse),
16417 inside A, A->B applies, but outside it, B->A will
16420 * On top of that (ie, even if the above is solved),
16421 conversions in a cache need to be abstract. Ie, `To
16422 convert from an Int to a Short use an OpcodeCast', not
16423 `To convert from an Int to a Short use the OpcodeCast on
16424 the variable 5' (which is what this patch was doing).
16426 2001-09-28 Ravi Pratap <ravi@ximian.com>
16428 * expression.cs (Invocation::ConversionExists): Re-write to use
16429 the conversion cache
16431 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16432 cache all conversions done, not just user-defined ones.
16434 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16435 to determine if a conversion exists instead of acutually trying to
16436 perform the conversion. It's faster too.
16438 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16439 and only then attempt the implicit conversion.
16441 2001-09-28 Ravi Pratap <ravi@ximian.com>
16443 * expression.cs (ConvertImplicit): Use a cache for conversions
16444 already found. Check level of recursion and bail out if necessary.
16446 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16448 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16449 Export standard methods that we expect for string operations.
16451 * statement.cs (Block::UsageWarning): Track usage of variables and
16452 report the errors for not used variables.
16454 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16457 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16459 * codegen.cs: remove unnneded code
16461 * expression.cs: Removed BuiltinTypeAccess class
16463 Fix the order in which implicit conversions are
16466 The previous fixed dropped support for boxed conversions (adding a
16467 test to the test suite now)
16469 (UserImplicitCast::CanConvert): Remove test for source being null,
16470 that code is broken. We should not feed a null to begin with, if
16471 we do, then we should track the bug where the problem originates
16472 and not try to cover it up here.
16474 Return a resolved expression of type UserImplicitCast on success
16475 rather than true/false. Ravi: this is what I was talking about,
16476 the pattern is to use a static method as a "constructor" for
16479 Also, do not create arguments until the very last minute,
16480 otherwise we always create the arguments even for lookups that
16481 will never be performed.
16483 (UserImplicitCast::Resolve): Eliminate, objects of type
16484 UserImplicitCast are born in a fully resolved state.
16486 * typemanager.cs (InitCoreTypes): Init also value_type
16487 (System.ValueType).
16489 * expression.cs (Cast::Resolve): First resolve the child expression.
16491 (LValue): Add new method AddressOf to be used by
16494 Change the argument of Store to take an EmitContext instead of an
16495 ILGenerator, because things like FieldExpr need to be able to call
16496 their children expression to generate the instance code.
16498 (Expression::Error, Expression::Warning): Sugar functions for
16501 (Expression::MemberLookup): Accept a TypeContainer instead of a
16502 Report as the first argument.
16504 (Expression::ResolvePrimary): Killed. I still want to improve
16505 this as currently the code is just not right.
16507 (Expression::ResolveMemberAccess): Simplify, but it is still
16510 (Unary::Resolve): Catch errors in AddressOf operators.
16512 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16513 index to a byte for the short-version, or the compiler will choose
16514 the wrong Emit call, which generates the wrong data.
16516 (ParameterReference::Emit, ::Store): same.
16518 (FieldExpr::AddressOf): Implement.
16520 * typemanager.cs: TypeManager: made public variable instead of
16523 * driver.cs: document --fatal.
16525 * report.cs (ErrorMessage, WarningMessage): new names for the old
16526 Error and Warning classes.
16528 * cs-parser.jay (member_access): Turn built-in access to types
16529 into a normal simplename
16531 2001-09-27 Ravi Pratap <ravi@ximian.com>
16533 * expression.cs (Invocation::BetterConversion): Fix to cope
16534 with q being null, since this was introducing a bug.
16536 * expression.cs (ConvertImplicit): Do built-in conversions first.
16538 2001-09-27 Ravi Pratap <ravi@ximian.com>
16540 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16542 2001-09-27 Ravi Pratap <ravi@ximian.com>
16544 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16545 I had introduced long ago (what's new ?).
16547 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16548 the work of all the checking.
16549 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16550 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16552 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16553 that is the right way.
16555 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16556 overloading resolution. Use everywhere instead of cutting and pasting code.
16558 (Binary::ResolveOperator): Use MakeUnionSet.
16560 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16561 we have to convert to bool types. Not complete yet.
16563 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16565 * typemanager.cs (TypeManager::CSharpName): support ushort.
16567 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16568 to provide an expression that performsn an implicit constant int
16569 conversion (section 6.1.6).
16570 (Expression::ConvertImplicitRequired): Reworked to include
16571 implicit constant expression conversions.
16573 (Expression::ConvertNumericExplicit): Finished.
16575 (Invocation::Emit): If InstanceExpression is null, then it means
16576 that we perform a call on this.
16578 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16580 * expression.cs (Unary::Emit): Remove some dead code.
16581 (Probe): Implement Resolve and Emit for `is'.
16582 (Expression::ConvertImplicitRequired): Attempt to do constant
16583 expression conversions here. Maybe should be moved to
16584 ConvertImplicit, but I am not sure.
16585 (Expression::ImplicitLongConstantConversionPossible,
16586 Expression::ImplicitIntConstantConversionPossible): New functions
16587 that tell whether is it possible to apply an implicit constant
16588 expression conversion.
16590 (ConvertNumericExplicit): Started work on explicit numeric
16593 * cs-parser.jay: Update operator constants.
16595 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16596 (Parameters::GetSignature): Hook up VerifyArgs here.
16597 (Parameters::VerifyArgs): Verifies that no two arguments have the
16600 * class.cs (Operator): Update the operator names to reflect the
16601 ones that the spec expects (as we are just stringizing the
16604 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16605 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16606 previous usage did only work for our methods.
16607 (Expression::ConvertImplicit): Handle decimal implicit numeric
16608 conversions as well.
16609 (Expression::InternalTypeConstructor): Used to invoke constructors
16610 on internal types for default promotions.
16612 (Unary::Emit): Implement special handling for the pre/post
16613 increment/decrement for overloaded operators, as they need to have
16614 the same semantics as the other operators.
16616 (Binary::ResolveOperator): ditto.
16617 (Invocation::ConversionExists): ditto.
16618 (UserImplicitCast::Resolve): ditto.
16620 2001-09-26 Ravi Pratap <ravi@ximian.com>
16622 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16623 operator, return after emitting body. Regression tests pass again !
16625 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16626 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16627 (Invocation::OverloadResolve): Ditto.
16628 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16630 * everywhere : update calls to the above methods accordingly.
16632 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16634 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16636 * expression.cs (ExpressionStatement): New base class used for
16637 expressions that can appear in statements, so that we can provide
16638 an alternate path to generate expression that do not leave a value
16641 (Expression::Emit, and all the derivatives): We no longer return
16642 whether a value is left on the stack or not. Every expression
16643 after being emitted leaves a single value on the stack.
16645 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16646 facilties of ExpressionStatement if possible.
16648 * cs-parser.jay: Update statement_expression.
16650 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16652 * driver.cs: Change the wording of message
16654 2001-09-25 Ravi Pratap <ravi@ximian.com>
16656 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16657 the type of the expression to the return type of the method if
16658 we have an overloaded operator match ! The regression tests pass again !
16659 (Unary::ResolveOperator): Ditto.
16661 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16662 to find "op_Implicit", not "implicit" ;-)
16663 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16664 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16666 * everywhere : Correct calls to the above accordingly.
16668 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16669 (ConvertImplicit): Do user-defined conversion if it exists.
16671 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16673 * assign.cs: track location.
16674 (Resolve): Use implicit conversions on assignment.
16676 * literal.cs: Oops. Not good, Emit of short access values should
16677 pass (Bytes) or the wrong argument will be selected.
16679 * expression.cs (Unary::Emit): Emit code for -expr.
16681 (Unary::ResolveOperator): Handle `Substract' for non-constants
16682 (substract from zero from the non-constants).
16683 Deal with Doubles as well.
16685 (Expression::ConvertImplicitRequired): New routine that reports an
16686 error if no implicit conversion exists.
16688 (Invocation::OverloadResolve): Store the converted implicit
16689 expressions if we make them
16691 2001-09-24 Ravi Pratap <ravi@ximian.com>
16693 * class.cs (ConstructorInitializer): Take a Location argument.
16694 (ConstructorBaseInitializer): Same here.
16695 (ConstructorThisInitializer): Same here.
16697 * cs-parser.jay : Update all calls accordingly.
16699 * expression.cs (Unary, Binary, New): Take location argument.
16700 Update accordingly everywhere.
16702 * cs-parser.jay : Update all calls to the above to take a location
16705 * class.cs : Ditto.
16707 2001-09-24 Ravi Pratap <ravi@ximian.com>
16709 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16710 (Invocation::BetterConversion): Same here
16711 (Invocation::ConversionExists): Ditto.
16713 (Invocation::ConversionExists): Implement.
16715 2001-09-22 Ravi Pratap <ravi@ximian.com>
16717 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16718 Also take an additional TypeContainer argument.
16720 * All over : Pass in TypeContainer as argument to OverloadResolve.
16722 * typemanager.cs (CSharpName): Update to check for the string type and return
16725 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16728 2001-09-21 Ravi Pratap <ravi@ximian.com>
16730 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16731 (Invocation::BetterFunction): Implement.
16732 (Invocation::BetterConversion): Implement.
16733 (Invocation::ConversionExists): Skeleton, no implementation yet.
16735 Okay, things work fine !
16737 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16739 * typemanager.cs: declare and load enum_type, delegate_type and
16742 * expression.cs (Expression::Emit): Now emit returns a value that
16743 tells whether a value is left on the stack or not. This strategy
16744 might be reveted tomorrow with a mechanism that would address
16745 multiple assignments.
16746 (Expression::report118): Utility routine to report mismatches on
16749 (Unary::Report23): Report impossible type/operator combination
16752 (Unary::IsIncrementableNumber): Whether the type can be
16753 incremented or decremented with add.
16754 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16756 (Unary::ResolveOperator): Implement ++, !, ~,
16758 (Invocation::Emit): Deal with new Emit convetion.
16760 * All Expression derivatives: Updated their Emit method to return
16761 whether they leave values on the stack or not.
16763 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16764 stack for expressions that are statements.
16766 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16768 * expression.cs (LValue): New interface. Must be implemented by
16770 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16773 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16774 interface for generating code, simplifies the code.
16776 2001-09-20 Ravi Pratap <ravi@ximian.com>
16778 * expression.cs (everywhere): Comment out return statements in ::Resolve
16779 methods to avoid the warnings.
16781 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16783 * driver.cs (parse): Report error 2001 if we can not open the
16786 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16789 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16792 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16793 otherwise nested blocks end up with the same index.
16795 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16797 * expression.cs: Instead of having FIXMEs in the Resolve
16798 functions, throw exceptions so it is obvious that we are facing a
16801 * cs-parser.jay (invocation_expression): Pass Location information.
16803 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16804 Use a basename for those routines because .NET does not like paths
16807 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16810 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16812 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16813 are loading the correct data types (throws an exception if not).
16814 (TypeManager::InitCoreTypes): Use CoreLookupType
16816 * expression.cs (Unary::ResolveOperator): return the child
16817 expression for expressions which are just +expr.
16818 (Unary::ResolveOperator): Return negative literals for -LITERAL
16819 expressions (otherwise they are Unary {Literal}).
16820 (Invocation::Badness): Take into account `Implicit constant
16821 expression conversions'.
16823 * literal.cs (LongLiteral): Implement long literal class.
16824 (IntLiteral): export the `Value' of the intliteral.
16826 2001-09-19 Ravi Pratap <ravi@ximian.com>
16828 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16830 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16831 instead of 'Operator'
16833 * expression.cs (Binary::ResolveOperator): Update accordingly.
16834 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16837 * cs-parser.jay (unary_expression): Update to use the new names.
16839 * gen-treedump.cs (GetUnary): Same here.
16841 * expression.cs (Unary::Resolve): Implement.
16842 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16843 operators are found instead of making noise ;-)
16844 (Unary::ResolveOperator): New method to do precisely the same thing which
16845 Binary::ResolveOperator does for Binary expressions.
16846 (Unary.method, .Arguments): Add.
16847 (Unary::OperName): Implement.
16848 (Unary::ForceConversion): Copy and Paste !
16850 * class.cs (Operator::Define): Fix a small bug for the case when we have
16853 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16854 for the inbuilt operators. Only overloading works for now ;-)
16856 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16858 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16859 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16861 * expression.cs (This::Emit): Implement.
16862 (This::Resolve): Implement.
16863 (TypeOf:Resolve): Implement.
16864 (Expression::ResolveSimpleName): Add an implicit this to instance
16866 (MemberAccess::Resolve): Deal with Parameters and Fields.
16867 Bind instance variable to Field expressions.
16868 (FieldExpr::Instance): New field used to track the expression that
16869 represents the object instance.
16870 (FieldExpr::Resolve): Track potential errors from MemberLookup not
16872 (FieldExpr::Emit): Implement.
16874 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
16875 the last instruction contains a return opcode to avoid generating
16876 the last `ret' instruction (this generates correct code, and it is
16877 nice to pass the peverify output).
16879 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
16880 initializer for static and instance variables.
16881 (Constructor::Emit): Allow initializer to be null in the case of
16882 static constructors. Only emit initializer for instance
16885 (TypeContainer::FindMembers): Return a null array if there are no
16888 Also fix the code for the MemberTypes.Method branch, as it was not
16889 scanning that for operators (or tried to access null variables before).
16891 * assign.cs (Assign::Emit): Handle instance and static fields.
16895 * driver.cs: Stop compilation if there are parse errors.
16897 * cs-parser.jay (constructor_declaration): Provide default base
16898 initializer for non-static constructors.
16899 (constructor_declarator): Do not provide a default base
16900 initializers if none was specified.
16901 Catch the fact that constructors should not have parameters.
16903 * class.cs: Do not emit parent class initializers for static
16904 constructors, that should be flagged as an error.
16906 2001-09-18 Ravi Pratap <ravi@ximian.com>
16908 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
16909 Move back code into TypeContainer::Populate.
16911 2001-09-18 Ravi Pratap <ravi@ximian.com>
16913 * class.cs (TypeContainer::AddConstructor): Fix the check to
16914 compare against Name, not Basename.
16915 (Operator::OpType): Change Plus and Minus to Add and Subtract.
16917 * cs-parser.jay : Update accordingly.
16919 * class.cs (TypeContainer::FindMembers): For the case where we are searching
16920 for methods, don't forget to look into the operators too.
16921 (RegisterMethodBuilder): Helper method to take care of this for
16922 methods, constructors and operators.
16923 (Operator::Define): Completely revamp.
16924 (Operator.OperatorMethod, MethodName): New fields.
16925 (TypeContainer::Populate): Move the registering of builders into
16926 RegisterMethodBuilder.
16927 (Operator::Emit): Re-write.
16929 * expression.cs (Binary::Emit): Comment out code path to emit method
16930 invocation stuff for the case when we have a user defined operator. I am
16931 just not able to get it right !
16933 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16935 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
16938 (Expression::MemberLookup): Provide a version that allows to
16939 specify the MemberTypes and BindingFlags.
16941 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
16942 so it was not fetching variable information from outer blocks.
16944 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
16945 Beforefieldinit as it was buggy.
16947 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
16948 that Ravi put here.
16950 * class.cs (Constructor::Emit): Only emit if block is not null.
16951 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
16952 deal with this by semantically definining it as if the user had
16955 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
16956 constructors as we now "emit" them at a higher level.
16958 (TypeContainer::DefineDefaultConstructor): Used to define the
16959 default constructors if none was provided.
16961 (ConstructorInitializer): Add methods Resolve and Emit.
16963 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
16965 2001-09-17 Ravi Pratap <ravi@ximian.com>
16967 * class.cs (TypeContainer::EmitDefaultConstructor): Register
16968 the default constructor builder with our hashtable for methodbuilders
16971 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
16972 and argument_count is 0 in which case we have a match.
16973 (Binary::ResolveOperator): More null checking and miscellaneous coding
16976 2001-09-17 Ravi Pratap <ravi@ximian.com>
16978 * rootcontext.cs (IsNameSpace): Compare against null.
16980 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
16982 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
16983 and Unary::Operator.
16985 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
16988 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
16989 we have overloaded operators.
16990 (Binary::ResolveOperator): Implement the part which does the operator overload
16993 * class.cs (Operator::Emit): Implement.
16994 (TypeContainer::Emit): Emit the operators we have too.
16996 * expression.cs (Binary::Emit): Update to emit the appropriate code for
16997 the case when we have a user-defined operator.
16999 2001-09-17 Miguel de Icaza <miguel@ximian.com>
17001 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
17003 2001-09-16 Ravi Pratap <ravi@ximian.com>
17005 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
17006 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
17007 (Constructor::Emit): Implement.
17008 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
17009 if we have no work to do.
17010 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
17013 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
17014 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
17016 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
17019 2001-09-15 Ravi Pratap <ravi@ximian.com>
17021 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
17023 (Tree::RecordNamespace): Method to do what the name says ;-)
17024 (Tree::Namespaces): Property to get at the namespaces hashtable.
17026 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
17029 * rootcontext.cs (IsNamespace): Fixed it :-)
17031 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17033 * class.cs (TypeContainer::FindMembers): Add support for
17035 (MethodCore): New class that encapsulates both the shared aspects
17036 of a Constructor and a Method.
17037 (Method, Constructor): Factored pieces into MethodCore.
17039 * driver.cs: Added --fatal which makes errors throw exceptions.
17040 Load System assembly as well as part of the standard library.
17042 * report.cs: Allow throwing exceptions on errors for debugging.
17044 * modifiers.cs: Do not use `parent', instead use the real type
17045 container to evaluate permission settings.
17047 * class.cs: Put Ravi's patch back in. He is right, and we will
17048 have to cope with the
17050 2001-09-14 Ravi Pratap <ravi@ximian.com>
17052 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
17053 FamORAssem, not FamANDAssem.
17055 2001-09-14 Miguel de Icaza <miguel@ximian.com>
17057 * driver.cs: Added --parse option that only parses its input files
17060 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
17061 incorrect. IsTopLevel is not used to tell whether an object is
17062 root_types or not (that can be achieved by testing this ==
17063 root_types). But to see if this is a top-level *class* (not
17064 necessarly our "toplevel" container).
17066 2001-09-14 Ravi Pratap <ravi@ximian.com>
17068 * enum.cs (Enum::Define): Modify to call the Lookup method on the
17069 parent instead of a direct call to GetType.
17071 2001-09-14 Ravi Pratap <ravi@ximian.com>
17073 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
17074 Modifiers.TypeAttr. This should just be a call to that method.
17076 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
17077 object so that we can determine if we are top-level or not.
17079 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
17082 * enum.cs (Enum::Define): Ditto.
17084 * modifiers.cs (FieldAttr): Re-write.
17086 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
17087 (TypeContainer::HaveStaticConstructor): New property to provide access
17088 to precisely that info.
17090 * modifiers.cs (MethodAttr): Re-write.
17091 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
17093 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
17094 of top-level types as claimed.
17096 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17098 * expression.cs (MemberLookup): Fruitless attempt to lookup
17099 constructors. Maybe I need to emit default constructors? That
17100 might be it (currently .NET emits this for me automatically).
17101 (Invocation::OverloadResolve): Cope with Arguments == null.
17102 (Invocation::EmitArguments): new function, shared by the new
17103 constructor and us.
17104 (Invocation::Emit): Handle static and instance methods. Emit
17105 proper call instruction for virtual or non-virtual invocations.
17106 (New::Emit): Implement.
17107 (New::Resolve): Implement.
17108 (MemberAccess:Resolve): Implement.
17109 (MethodGroupExpr::InstanceExpression): used conforming to the spec
17110 to track instances.
17111 (FieldExpr::Resolve): Set type.
17113 * support.cs: Handle empty arguments.
17115 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
17116 SimpleLookup): Auxiliary routines to help parse a qualifier
17119 Update qualifier_identifier rule.
17121 * codegen.cs: Removed debugging messages.
17123 * class.cs: Make this a global thing, this acts just as a "key" to
17124 objects that we might have around.
17126 (Populate): Only initialize method_builders_to_methods once.
17128 * expression.cs (PropertyExpr): Initialize type from the
17131 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17132 Resolve pattern. Attempt to implicitly convert value to boolean.
17135 * expression.cs: Set the type for the int32/int32 argument case.
17136 (Binary::ResolveOperator): Set the return type to boolean for
17137 comparission operators
17139 * typemanager.cs: Remove debugging print code.
17141 (Invocation::Resolve): resolve type.
17143 * class.cs: Allocate a MemberInfo of the correct size, as the code
17144 elsewhere depends on the test to reflect the correct contents.
17146 (Method::) Keep track of parameters, due to System.Reflection holes
17148 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17151 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17152 of the exact size and return that.
17154 (Class::LookupMethodByBuilder): New function that maps
17155 MethodBuilders to its methods. Required to locate the information
17156 on methods because System.Reflection bit us again.
17158 * support.cs: New file, contains an interface ParameterData and
17159 two implementations: ReflectionParameters and InternalParameters
17160 used to access Parameter information. We will need to grow this
17163 * expression.cs (Invocation::GetParameterData): implement a cache
17164 and a wrapper around the ParameterData creation for methods.
17165 (Invocation::OverloadResolve): Use new code.
17167 2001-09-13 Ravi Pratap <ravi@ximian.com>
17169 * class.cs (TypeContainer::EmitField): Remove and move into
17170 (Field::Define): here and modify accordingly.
17171 (Field.FieldBuilder): New member.
17172 (TypeContainer::Populate): Update accordingly.
17173 (TypeContainer::FindMembers): Implement.
17175 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17177 * statement.cs: (VariableInfo::VariableType): New field to be
17178 initialized with the full type once it is resolved.
17180 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17182 * parameter.cs (GetParameterInfo): Use a type cache to compute
17183 things only once, and to reuse this information
17185 * expression.cs (LocalVariableReference::Emit): Implement.
17186 (OpcodeCast::Emit): fix.
17188 (ParameterReference::Resolve): Implement.
17189 (ParameterReference::Emit): Implement.
17191 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17192 that are expressions need to stay as Expressions.
17194 * typemanager.cs (CSharpName): Returns the C# name of a type if
17197 * expression.cs (Expression::ConvertImplicit): New function that
17198 implements implicit type conversions.
17200 (Expression::ImplicitReferenceConversion): Implements implicit
17201 reference conversions.
17203 (EmptyCast): New type for transparent casts.
17205 (OpcodeCast): New type for casts of types that are performed with
17206 a sequence of bytecodes.
17208 (BoxedCast): New type used for casting value types into reference
17209 types. Emits a box opcode.
17211 (Binary::DoNumericPromotions): Implements numeric promotions of
17212 and computation of the Binary::Type.
17214 (Binary::EmitBranchable): Optimization.
17216 (Binary::Emit): Implement code emission for expressions.
17218 * typemanager.cs (TypeManager): Added two new core types: sbyte
17221 2001-09-12 Ravi Pratap <ravi@ximian.com>
17223 * class.cs (TypeContainer::FindMembers): Method which does exactly
17224 what Type.FindMembers does, only we don't have to use reflection. No
17225 implementation yet.
17227 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17228 typecontainer objects as we need to get at them.
17229 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17231 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17232 typecontainer object.
17234 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17235 of just a Report object.
17237 2001-09-11 Ravi Pratap <ravi@ximian.com>
17239 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17241 (TypeContainer::Populate): Now define the delegates of the type too.
17242 (TypeContainer.Delegates): Property to access the list of delegates defined
17245 * delegates.cs (Delegate::Define): Implement partially.
17247 * modifiers.cs (TypeAttr): Handle more flags.
17249 2001-09-11 Ravi Pratap <ravi@ximian.com>
17251 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17253 (Operator::Define): Re-write logic to get types by using the LookupType method
17254 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17255 (Indexer::Define): Ditto.
17256 (Event::Define): Ditto.
17257 (Property::Define): Ditto.
17259 2001-09-10 Ravi Pratap <ravi@ximian.com>
17261 * class.cs (TypeContainer::Populate): Now define operators too.
17262 (TypeContainer.Operators): New property to access the list of operators
17264 (Operator.OperatorMethodBuilder): New member to hold the method builder
17265 for the operator we are defining.
17266 (Operator::Define): Implement.
17268 2001-09-10 Ravi Pratap <ravi@ximian.com>
17270 * class.cs (Event::Define): Make the prefixes of the accessor methods
17271 addOn_ and removeOn_
17273 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17274 of the location being passed in too. Ideally, this should go later since all
17275 error reporting should be done through the Report object.
17277 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17278 (Populate): Iterate thru the indexers we have and define them too.
17279 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17280 for the get and set accessors.
17281 (Indexer::Define): Implement.
17283 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17285 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17286 my previous implementation, did not work.
17288 * typemanager.cs: Add a couple of missing types (the longs).
17290 * literal.cs: Use TypeManager.bool_type instead of getting it.
17292 * expression.cs (EventExpr): New kind of expressions.
17293 (Expressio::ExprClassFromMemberInfo): finish
17295 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17297 * assign.cs: Emit stores to static fields differently.
17299 2001-09-08 Ravi Pratap <ravi@ximian.com>
17301 * Merge in changes and adjust code to tackle conflicts. Backed out my
17302 code in Assign::Resolve ;-)
17304 2001-09-08 Ravi Pratap <ravi@ximian.com>
17306 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17307 instead Report.Error and also pass in the location.
17308 (CSharpParser::Lexer): New readonly property to return the reference
17309 to the Tokenizer object.
17310 (declare_local_variables): Use Report.Error with location instead of plain
17314 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17315 (Operator.CheckBinaryOperator): Ditto.
17317 * cs-parser.jay (operator_declarator): Update accordingly.
17319 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17320 (CheckBinaryOperator): Same here.
17322 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17323 on the name without any prefixes of namespace names etc. This is because we
17324 already might have something already fully qualified like
17325 'System.Console.WriteLine'
17327 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17329 2001-09-07 Ravi Pratap <ravi@ximian.com>
17331 * cs-tokenizer.cs (location): Return a string which also contains
17334 * expression.cs (ElementAccess): New class for expressions of the
17335 type 'element access.'
17336 (BaseAccess): New class for expressions of the type 'base access.'
17337 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17340 * cs-parser.jay (element_access): Implement action.
17341 (base_access): Implement actions.
17342 (checked_expression, unchecked_expression): Implement.
17344 * cs-parser.jay (local_variable_type): Correct and implement.
17345 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17347 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17349 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17350 name and the specifiers.
17352 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17354 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17355 making them all public ;-)
17357 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17360 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17362 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17364 (FieldExpr, PropertyExprs): New resolved expressions.
17365 (SimpleName::MemberStaticCheck): Perform static checks for access
17366 to non-static fields on static methods. Maybe this should be
17367 generalized for MemberAccesses.
17368 (SimpleName::ResolveSimpleName): More work on simple name
17371 * cs-parser.jay (primary_expression/qualified_identifier): track
17372 the parameter index.
17374 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17375 (EmitContext::EmitBoolExpression): Chain to expression generation
17376 instead of temporary hack.
17377 (::EmitStatementExpression): Put generic expression code generation.
17379 * assign.cs (Assign::Emit): Implement variable assignments to
17380 local variables, parameters and fields.
17382 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17384 * statement.cs (Block::GetVariableInfo): New method, returns the
17385 VariableInfo for a variable name in a block.
17386 (Block::GetVariableType): Implement in terms of GetVariableInfo
17388 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17389 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17391 2001-09-06 Ravi Pratap <ravi@ximian.com>
17393 * cs-parser.jay (operator_declaration): Continue on my quest : update
17394 to take attributes argument.
17395 (event_declaration): Ditto.
17396 (enum_declaration): Ditto.
17397 (indexer_declaration): Ditto.
17399 * class.cs (Operator::Operator): Update constructor accordingly.
17400 (Event::Event): Ditto.
17402 * delegate.cs (Delegate::Delegate): Same here.
17404 * enum.cs (Enum::Enum): Same here.
17406 2001-09-05 Ravi Pratap <ravi@ximian.com>
17408 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17410 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17412 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17413 being passed around as an arraylist.
17414 (Attributes::AddAttribute): Method to add attribute sections.
17416 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17417 (struct_declaration): Update accordingly.
17418 (constant_declaration): Update.
17419 (field_declaration): Update.
17420 (method_header): Update.
17421 (fixed_parameter): Update.
17422 (parameter_array): Ditto.
17423 (property_declaration): Ditto.
17424 (destructor_declaration): Ditto.
17426 * class.cs (Struct::Struct): Update constructors accordingly.
17427 (Class::Class): Ditto.
17428 (Field::Field): Ditto.
17429 (Method::Method): Ditto.
17430 (Property::Property): Ditto.
17431 (TypeContainer::OptAttribute): update property's return type.
17433 * interface.cs (Interface.opt_attributes): New member.
17434 (Interface::Interface): Update to take the extra Attributes argument.
17436 * parameter.cs (Parameter::Parameter): Ditto.
17438 * constant.cs (Constant::Constant): Ditto.
17440 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17441 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17442 the attributes as a parameter.
17443 (InterfaceProperty): Update constructor call.
17444 (InterfaceEvent): Ditto.
17445 (InterfaceMethod): Ditto.
17446 (InterfaceIndexer): Ditto.
17448 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17449 pass the attributes too.
17450 (interface_event_declaration): Ditto.
17451 (interface_property_declaration): Ditto.
17452 (interface_method_declaration): Ditto.
17453 (interface_declaration): Ditto.
17455 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17457 * class.cs (Method::Define): Track the "static Main" definition to
17458 create an entry point.
17460 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17461 EntryPoint if we find it.
17463 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17464 (EmitContext::ig): Make this variable public.
17466 * driver.cs: Make the default output file be the first file name
17467 with the .exe extension.
17469 Detect empty compilations
17471 Handle various kinds of output targets. Handle --target and
17472 rename -t to --dumper.
17474 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17475 methods inherited from Expression return now an Expression. This
17476 will is used during the tree rewriting as we resolve them during
17479 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17480 the spec. Missing entirely is the information about
17481 accessability of elements of it.
17483 (Expression::ExprClassFromMemberInfo): New constructor for
17484 Expressions that creates a fully initialized Expression based on
17485 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17488 (Invocation::Resolve): Begin implementing resolution of invocations.
17490 * literal.cs (StringLiteral): Implement Emit.
17492 2001-09-05 Ravi Pratap <ravi@ximian.com>
17494 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17497 2001-09-04 Ravi Pratap <ravi@ximian.com>
17499 * cs-parser.jay (attribute_arguments): Implement actions.
17500 (attribute): Fix bug in production. Implement action.
17501 (attribute_list): Implement.
17502 (attribute_target): Implement.
17503 (attribute_target_specifier, opt_target_specifier): Implement
17504 (CheckAttributeTarget): New method to check if the attribute target
17506 (attribute_section): Implement.
17507 (opt_attributes): Implement.
17509 * attribute.cs : New file to handle attributes.
17510 (Attribute): Class to hold attribute info.
17512 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17513 (attribute_section): Modify production to use 2 different rules to
17514 achieve the same thing. 1 s/r conflict down !
17515 Clean out commented, useless, non-reducing dimension_separator rules.
17517 * class.cs (TypeContainer.attributes): New member to hold list
17518 of attributes for a type.
17519 (Struct::Struct): Modify to take one more argument, the attribute list.
17520 (Class::Class): Ditto.
17521 (Field::Field): Ditto.
17522 (Method::Method): Ditto.
17523 (Property::Property): Ditto.
17525 * cs-parser.jay (struct_declaration): Update constructor call to
17526 pass in the attributes too.
17527 (class_declaration): Ditto.
17528 (constant_declaration): Ditto.
17529 (field_declaration): Ditto.
17530 (method_header): Ditto.
17531 (fixed_parameter): Ditto.
17532 (parameter_array): Ditto.
17533 (property_declaration): Ditto.
17535 * constant.cs (Constant::Constant): Update constructor similarly.
17536 Use System.Collections.
17538 * parameter.cs (Parameter::Parameter): Update as above.
17540 2001-09-02 Ravi Pratap <ravi@ximian.com>
17542 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17543 (TypeContainer.delegates): New member to hold list of delegates.
17545 * cs-parser.jay (delegate_declaration): Implement the action correctly
17546 this time as I seem to be on crack ;-)
17548 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17550 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17551 tell whether an identifier represents a namespace.
17553 * expression.cs (NamespaceExpr): A namespace expression, used only
17554 temporarly during expression resolution.
17555 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17556 utility functions to resolve names on expressions.
17558 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17560 * codegen.cs: Add hook for StatementExpressions.
17562 * class.cs: Fix inverted test for static flag in methods.
17564 2001-09-02 Ravi Pratap <ravi@ximian.com>
17566 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17567 to make it coincide with MS' number.
17568 (Operator::CheckBinaryOperator): Ditto.
17570 * ../errors/errors.txt : Remove error numbers added earlier.
17572 * ../errors/cs1019.cs : Test case for error # 1019
17574 * ../errros/cs1020.cs : Test case for error # 1020
17576 * cs-parser.jay : Clean out commented cruft.
17577 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17578 used anywhere - non-reducing rule.
17579 (namespace_declarations): Non-reducing rule - comment out.
17581 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17582 with TypeContainer::AddEnum.
17584 * delegate.cs : New file for delegate handling classes.
17585 (Delegate): Class for declaring delegates.
17587 * makefile : Update.
17589 * cs-parser.jay (delegate_declaration): Implement.
17591 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17593 * class.cs (Event::Define): Implement.
17594 (Event.EventBuilder): New member.
17596 * class.cs (TypeContainer::Populate): Update to define all enums and events
17598 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17599 readonly fields for all these cases ?
17601 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17603 * class.cs (Property): Revamp to use the convention of making fields readonly.
17604 Accordingly modify code elsewhere.
17606 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17607 the Define method of the Property class.
17609 * class.cs : Clean up applied patch and update references to variables etc. Fix
17611 (TypeContainer::Populate): Update to define all the properties we have. Also
17612 define all enumerations.
17614 * enum.cs (Define): Implement.
17616 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17618 * cs-parser.jay (overloadable_operator): The semantic value is an
17619 enum of the Operator class.
17620 (operator_declarator): Implement actions.
17621 (operator_declaration): Implement.
17623 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17624 validity of definitions.
17625 (Operator::CheckBinaryOperator): Static method to check for binary operators
17626 (TypeContainer::AddOperator): New method to add an operator to a type.
17628 * cs-parser.jay (indexer_declaration): Added line to actually call the
17629 AddIndexer method so it gets added ;-)
17631 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17632 already taken care of by the MS compiler ?
17634 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17636 * class.cs (Operator): New class for operator declarations.
17637 (Operator::OpType): Enum for the various operators.
17639 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17641 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17642 ostensibly handle this in semantic analysis.
17644 * cs-parser.jay (general_catch_clause): Comment out
17645 (specific_catch_clauses, specific_catch_clause): Ditto.
17646 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17647 (catch_args, opt_catch_args): New productions.
17648 (catch_clause): Rewrite to use the new productions above
17649 (catch_clauses): Modify accordingly.
17650 (opt_catch_clauses): New production to use in try_statement
17651 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17652 and re-write the code in the actions to extract the specific and
17653 general catch clauses by being a little smart ;-)
17655 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17656 Hooray, try and catch statements parse fine !
17658 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17660 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17661 string from the hashtable of variables.
17663 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17664 I end up making that mistake ;-)
17665 (catch_clauses): Fixed gross error which made Key and Value of the
17666 DictionaryEntry the same : $1 !!
17668 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17670 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17672 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17673 when the add and remove accessors are specified.
17675 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17677 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17678 information about indexer_declarator.
17679 (indexer_declarator): Implement actions.
17680 (parsing_indexer): New local boolean used to keep track of whether
17681 we are parsing indexers or properties. This is necessary because
17682 implicit_parameters come into picture even for the get accessor in the
17683 case of an indexer.
17684 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17686 * class.cs (Indexer): New class for indexer declarations.
17687 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17688 (TypeContainer::indexers): New member to hold list of indexers for the
17691 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17693 * cs-parser.jay (add_accessor_declaration): Implement action.
17694 (remove_accessor_declaration): Implement action.
17695 (event_accessors_declaration): Implement
17696 (variable_declarators): swap statements for first rule - trivial.
17698 * class.cs (Event): New class to hold information about event
17700 (TypeContainer::AddEvent): New method to add an event to a type
17701 (TypeContainer::events): New member to hold list of events.
17703 * cs-parser.jay (event_declaration): Implement actions.
17705 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17707 * cs-parser.jay (dim_separators): Implement. Make it a string
17708 concatenating all the commas together, just as they appear.
17709 (opt_dim_separators): Modify accordingly
17710 (rank_specifiers): Update accordingly. Basically do the same
17711 thing - instead, collect the brackets here.
17712 (opt_rank_sepcifiers): Modify accordingly.
17713 (array_type): Modify to actually return the complete type string
17714 instead of ignoring the rank_specifiers.
17715 (expression_list): Implement to collect the expressions
17716 (variable_initializer): Implement. We make it a list of expressions
17717 essentially so that we can handle the array_initializer case neatly too.
17718 (variable_initializer_list): Implement.
17719 (array_initializer): Make it a list of variable_initializers
17720 (opt_array_initializer): Modify accordingly.
17722 * expression.cs (New::NType): Add enumeration to help us
17723 keep track of whether we have an object/delegate creation
17724 or an array creation.
17725 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17726 members to hold data about array creation.
17727 (New:New): Modify to update NewType
17728 (New:New): New Overloaded contructor for the array creation
17731 * cs-parser.jay (array_creation_expression): Implement to call
17732 the overloaded New constructor.
17734 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17736 * class.cs (TypeContainer::Constructors): Return member
17737 constructors instead of returning null.
17739 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17741 * typemanager.cs (InitCoreTypes): Initialize the various core
17742 types after we have populated the type manager with the user
17743 defined types (this distinction will be important later while
17744 compiling corlib.dll)
17746 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17747 on Expression Classification. Now all expressions have a method
17748 `Resolve' and a method `Emit'.
17750 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17751 generation from working. Also add some temporary debugging
17754 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17756 * codegen.cs: Lots of code generation pieces. This is only the
17757 beginning, will continue tomorrow with more touches of polish. We
17758 handle the fundamentals of if, while, do, for, return. Others are
17759 trickier and I need to start working on invocations soon.
17761 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17764 * codegen.cs (EmitContext): New struct, used during code
17765 emission to keep a context. Most of the code generation will be
17768 * cs-parser.jay: Add embedded blocks to the list of statements of
17769 this block. So code generation proceeds in a top down fashion.
17771 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17773 * statement.cs: Add support for multiple child blocks.
17775 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17777 * codegen.cs (EmitCode): New function, will emit the code for a
17778 Block of code given a TypeContainer and its ILGenerator.
17780 * statement.cs (Block): Standard public readonly optimization.
17781 (Block::Block constructors): Link children.
17782 (Block::Child): Child Linker.
17783 (Block::EmitVariables): Emits IL variable declarations.
17785 * class.cs: Drop support for MethodGroups here, delay until
17787 (Method::): Applied the same simplification that I did before, and
17788 move from Properties to public readonly fields.
17789 (Method::ParameterTypes): Returns the parameter types for the
17790 function, and implements a cache that will be useful later when I
17791 do error checking and the semantic analysis on the methods is
17793 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17794 and made a method, optional argument tells whether this is a class
17795 or a structure to apply the `has-this' bit.
17796 (Method::GetCallingConvention): Implement, returns the calling
17798 (Method::Define): Defines the type, a second pass is performed
17799 later to populate the methods.
17801 (Constructor::ParameterTypes): implement a cache similar to the
17802 one on Method::ParameterTypes, useful later when we do semantic
17805 (TypeContainer::EmitMethod): New method. Emits methods.
17807 * expression.cs: Removed MethodGroup class from here.
17809 * parameter.cs (Parameters::GetCallingConvention): new method.
17811 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17813 * class.cs (TypeContainer::Populate): Drop RootContext from the
17816 (Constructor::CallingConvention): Returns the calling convention.
17817 (Constructor::ParameterTypes): Returns the constructor parameter
17820 (TypeContainer::AddConstructor): Keep track of default constructor
17821 and the default static constructor.
17823 (Constructor::) Another class that starts using `public readonly'
17824 instead of properties.
17826 (Constructor::IsDefault): Whether this is a default constructor.
17828 (Field::) use readonly public fields instead of properties also.
17830 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17831 track of static constructors; If none is used, turn on
17832 BeforeFieldInit in the TypeAttributes.
17834 * cs-parser.jay (opt_argument_list): now the return can be null
17835 for the cases where there are no arguments.
17837 (constructor_declarator): If there is no implicit `base' or
17838 `this', then invoke the default parent constructor.
17840 * modifiers.cs (MethodAttr): New static function maps a set of
17841 modifiers flags into a MethodAttributes enum
17842 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17843 MethodAttr, TypeAttr to represent the various mappings where the
17844 modifiers are used.
17845 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17847 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17849 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17852 * interface.cs (PopulateIndexer): Implemented the code generator
17853 for interface indexers.
17855 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17857 * interface.cs (InterfaceMemberBase): Now we track the new status
17860 (PopulateProperty): Implement property population. Woohoo! Got
17861 Methods and Properties going today.
17863 Removed all the properties for interfaces, and replaced them with
17864 `public readonly' fields.
17866 2001-08-16 Miguel de Icaza <miguel@ximian.com>
17868 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
17869 initialize their hashtables/arraylists only when they are needed
17870 instead of doing this always.
17872 * parameter.cs: Handle refs and out parameters.
17874 * cs-parser.jay: Use an ArrayList to construct the arguments
17875 instead of the ParameterCollection, and then cast that to a
17878 * parameter.cs: Drop the use of ParameterCollection and use
17879 instead arrays of Parameters.
17881 (GetParameterInfo): Use the Type, not the Name when resolving
17884 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17886 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17887 and instead use public readonly fields.
17889 * class.cs: Put back walking code for type containers.
17891 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17893 * class.cs (MakeConstant): Code to define constants.
17895 * rootcontext.cs (LookupType): New function. Used to locate types
17898 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17900 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17901 this System.Reflection code is. Kudos to Microsoft
17903 * typemanager.cs: Implement a type cache and avoid loading all
17904 types at boot time. Wrap in LookupType the internals. This made
17905 the compiler so much faster. Wow. I rule!
17907 * driver.cs: Make sure we always load mscorlib first (for
17908 debugging purposes, nothing really important).
17910 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
17911 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
17913 * rootcontext.cs: Lookup types on their namespace; Lookup types
17914 on namespaces that have been imported using the `using' keyword.
17916 * class.cs (TypeContainer::TypeAttr): Virtualize.
17917 (Class::TypeAttr): Return attributes suitable for this bad boy.
17918 (Struct::TypeAttr): ditto.
17919 Handle nested classes.
17920 (TypeContainer::) Remove all the type visiting code, it is now
17921 replaced with the rootcontext.cs code
17923 * rootcontext.cs (GetClassBases): Added support for structs.
17925 2001-08-06 Miguel de Icaza <miguel@ximian.com>
17927 * interface.cs, statement.cs, class.cs, parameter.cs,
17928 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
17929 Drop use of TypeRefs, and use strings instead.
17931 2001-08-04 Miguel de Icaza <miguel@ximian.com>
17935 * class.cs (Struct::Struct): set the SEALED flags after
17936 checking the modifiers.
17937 (TypeContainer::TypeAttr): new property, returns the
17938 TypeAttributes for a class.
17940 * cs-parser.jay (type_list): Oops, list production was creating a
17941 new list of base types.
17943 * rootcontext.cs (StdLib): New property.
17944 (GetInterfaceTypeByName): returns an interface by type name, and
17945 encapsulates error handling here.
17946 (GetInterfaces): simplified.
17947 (ResolveTree): Encapsulated all the tree resolution here.
17948 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
17951 * driver.cs: Add support for --nostdlib, to avoid loading the
17952 default assemblies.
17953 (Main): Do not put tree resolution here.
17955 * rootcontext.cs: Beginning of the class resolution.
17957 2001-08-03 Miguel de Icaza <miguel@ximian.com>
17959 * rootcontext.cs: Provide better error reporting.
17961 * cs-parser.jay (interface_base): set our $$ to be interfaces.
17963 * rootcontext.cs (CreateInterface): Handle the case where there
17964 are no parent interfaces.
17966 (CloseTypes): Routine to flush types at the end.
17967 (CreateInterface): Track types.
17968 (GetInterfaces): Returns an array of Types from the list of
17969 defined interfaces.
17971 * typemanager.c (AddUserType): Mechanism to track user types (puts
17972 the type on the global type hash, and allows us to close it at the
17975 2001-08-02 Miguel de Icaza <miguel@ximian.com>
17977 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
17978 RecordInterface instead.
17980 * cs-parser.jay: Updated to reflect changes above.
17982 * decl.cs (Definition): Keep track of the TypeBuilder type that
17983 represents this type here. Not sure we will use it in the long
17984 run, but wont hurt for now.
17986 * driver.cs: Smaller changes to accomodate the new code.
17988 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
17991 * rootcontext.cs (CreateInterface): New method, used to create
17992 the System.TypeBuilder type for interfaces.
17993 (ResolveInterfaces): new entry point to resolve the interface
17995 (CodeGen): Property, used to keep track of the code generator.
17997 2001-07-26 Miguel de Icaza <miguel@ximian.com>
17999 * cs-parser.jay: Add a second production for delegate_declaration
18002 (enum_body): Put an opt_comma here instead of putting it on
18003 enum_body or enum_member_declarations so we can handle trailing
18004 commas on enumeration members. Gets rid of a shift/reduce.
18006 (type_list): Need a COMMA in the middle.
18008 (indexer_declaration): Tell tokenizer to recognize get/set
18010 * Remove old targets.
18012 * Re-add the parser target.
18014 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18016 * cs-parser.jay: Add precendence rules for a number of operators
18017 ot reduce the number of shift/reduce conflicts in the grammar.
18019 2001-07-17 Miguel de Icaza <miguel@ximian.com>
18021 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
18024 Get rid of old crufty code.
18026 * rootcontext.cs: Use this to keep track of the parsed
18027 representation and the defined types available to the program.
18029 * gen-treedump.cs: adjust for new convention.
18031 * type.cs: Split out the type manager, and the assembly builder
18034 * typemanager.cs: the type manager will live here now.
18036 * cil-codegen.cs: And the code generator here.
18038 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
18040 * makefile: Fixed up for easy making.
18042 2001-07-13 Simon Cozens <simon@simon-cozens.org>
18044 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
18047 (unary_expression): Expand pre_increment_expression and
18048 post_decrement_expression to reduce a shift/reduce.
18050 2001-07-11 Simon Cozens
18052 * cs-tokenizer.cs: Hex numbers should begin with a 0.
18054 Improve allow_keyword_as_indent name.
18056 2001-06-19 Miguel de Icaza <miguel@ximian.com>
18058 * Adjustments for Beta2.
18060 2001-06-13 Miguel de Icaza <miguel@ximian.com>
18062 * decl.cs: Added `Define' abstract method.
18063 (InTransit): new property, used to catch recursive definitions.
18065 * interface.cs: Implement `Define'.
18067 * modifiers.cs: Map Modifiers.constants to
18068 System.Reflection.TypeAttribute flags.
18070 * class.cs: Keep track of types and user-defined types.
18071 (BuilderInit): New method for creating an assembly
18072 (ResolveType): New function to launch the resolution process, only
18073 used by interfaces for now.
18075 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
18076 that are inserted into the name space.
18078 2001-06-08 Miguel de Icaza <miguel@ximian.com>
18080 * ARGH. I have screwed up my tree so many times due to the use of
18081 rsync rather than using CVS. Going to fix this at once.
18083 * driver.cs: Objetify driver. Load assemblies, use assemblies to
18086 2001-06-07 Miguel de Icaza <miguel@ximian.com>
18088 * Experiment successful: Use System.Type rather that our own
18091 2001-05-25 Miguel de Icaza <miguel@ximian.com>
18093 * cs-parser.jay: Removed nsAliases from here.
18095 Use new namespaces, handle `using XXX;'
18097 * namespace.cs: Reimplemented namespace handling, use a recursive
18098 definition of the class. Now we can keep track of using clauses
18099 and catch invalid using clauses.
18101 2001-05-24 Miguel de Icaza <miguel@ximian.com>
18103 * gen-treedump.cs: Adapted for all the renaming.
18105 * expression.cs (Expression): this class now has a Type property
18106 which returns an expression Type.
18108 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
18109 `Type', as this has a different meaning now in the base
18111 2001-05-22 Miguel de Icaza <miguel@ximian.com>
18113 * interface.cs, class.cs: Removed from all the sources the
18114 references to signature computation, as we can not do method
18115 signature computation during the parsing time, as we are not
18116 trying to solve at that point distinguishing:
18120 void a (NS.Blah x) {}
18123 Which depending on the context might be valid or not, as we do not
18124 know if Blah is the same thing as NS.Blah at that point.
18126 * Redid everything so the code uses TypeRefs now instead of
18127 Types. TypeRefs are just temporary type placeholders, that need
18128 to be resolved. They initially have a pointer to a string and the
18129 current scope in which they are used. This is used later by the
18130 compiler to resolve the reference to an actual Type.
18132 * DeclSpace is no longer a CIR.Type, and neither are
18133 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18134 are all DeclSpaces, but no Types.
18136 * type.cs (TypeRefManager): This implements the TypeRef manager,
18137 which keeps track of all the types that need to be resolved after
18138 the parsing has finished.
18140 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18142 * ARGH. We are going to have to store `foreach' as a class rather
18143 than resolving it, as we need to verify error 1579 after name
18144 resolution. *OR* we could keep a flag that says `This request to
18145 IEnumerator comes from a foreach statement' which we can then use
18146 to generate the error.
18148 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18150 * class.cs (TypeContainer.AddMethod): we now add methods to the
18151 MethodGroup instead of the method hashtable.
18153 * expression.cs: Add MethodGroup abstraction, which gets us one
18154 step closer to the specification in the way we handle method
18157 * cs-parser.jay (primary_expression): qualified_identifier now
18158 tried to match up an identifier to a local variable reference or
18159 to a parameter reference.
18161 current_local_parameters is now a parser global variable that
18162 points to the current parameters for the block, used during name
18165 (property_declaration): Now creates an implicit `value' argument to
18168 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18170 * parameter.cs: Do not use `param' arguments as part of the
18171 signature, per the spec.
18173 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18175 * decl.cs: Base class for classes, structs and interfaces. This
18176 is the "Declaration Space"
18178 * cs-parser.jay: Use CheckDef for checking declaration errors
18179 instead of having one on each function.
18181 * class.cs: Factor out some code for handling error handling in
18182 accordance to the "Declarations" section in the "Basic Concepts"
18183 chapter in the ECMA C# spec.
18185 * interface.cs: Make all interface member classes derive from
18186 InterfaceMemberBase.
18188 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18190 * Many things: all interfaces are parsed and generated in
18191 gen-treedump. Support for member variables, constructors,
18192 destructors, properties, constants is there.
18194 Beginning of the IL backend, but very little done, just there for
18197 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18199 * cs-parser.jay: Fix labeled statement.
18201 * cs-tokenizer.cs (escape): Escape " and ' always.
18202 ref_line, ref_name: keep track of the line/filename as instructed
18203 by #line by the compiler.
18206 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18208 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18209 to match the values in System.CodeDOM.
18211 Divid renamed to Divide.
18213 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18215 (Statements.set): remove.
18217 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18220 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18221 falseStatements always have valid values.
18223 * cs-parser.jay: Use System.CodeDOM now.