1 2004-12-07 Marek Safar <marek.safar@seznam.cz>
4 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
7 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
9 * cs-parser.jay : handle doc comments on implicit/explicit operators.
10 Some operator comments were suppressed.
11 * doc.cs : Implicit/explicit operator name in doc comments are like
12 "op_Explicit(type)~returnType", so added suffix handling.
14 2004-12-07 Martin Baulig <martin@ximian.com>
17 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
18 (MemberCore.GetClsCompliantAttributeValue): Likewise.
19 (DeclSpace.ec): New protected field; store the EmitContext here.
20 (DeclSpace.EmitContext): New public property; moved here from
22 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
25 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
26 (Enum.Emit): Don't create a new EmitContext.
28 * delegate.cs (Delegate.DefineType): Always create the
31 * iterators.cs (Iterators.DefineIterator): Create a new
32 EmitContext and store it in `ec'.
34 2004-08-24 Martin Baulig <martin@ximian.com>
37 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
38 this for accessibility checks.
39 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
40 IsNestedFamilyAccessible.
41 (TypeManager.IsSubclassOf): New method, do what the name actually
44 2004-12-06 Raja R Harinath <rharinath@novell.com>
46 Fix crash on cs0657-17.cs.
47 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
48 Use RootContext.Tree.Types, not 'new RootTypes ()'.
49 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
50 the case where the NamespaceEntry gets overwritten.
52 2004-12-06 Marek Safar <marek.safar@seznam.cz>
55 * ecore.cs (ResolveBoolean): Tiny refactoring.
57 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
58 of right expression resolving when left is false constant and
59 operator is LogicalAnd OR true constant and operator is LogicalOr.
61 * statement.cs (ResolveUnreachable): Always reports warning.
63 2004-12-05 Miguel de Icaza <miguel@ximian.com>
65 * class.cs: Distinguish between 1721 and 1722 (just a little help
68 2004-12-03 Miguel de Icaza <miguel@ximian.com>
70 * delegate.cs: Only allow this on new versions of the language.
72 2004-12-02 Duncan Mak <duncan@ximian.com>
74 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
76 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
77 here as a static method. Take an additional bool out parameter
78 `must_do_cs1540_check' for signaling to InstanceResolve.
79 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
80 member field from PropertyExpr class and made it an argument of
82 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
83 check for MarshalByRefObject, and report CS0122 instead of CS1540.
84 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
85 and `remove_accessor' as well as InstanceResolve: report CS0122
90 2004-12-03 Raja R Harinath <rharinath@novell.com>
92 Fix test-327.cs, test-328.cs, and put in early infrastructure
93 for eventually fixing #52697.
94 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
95 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
97 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
98 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
99 (VerifyUsing, error246): Update.
100 * rootcontext.cs (RootContext.NamespaceLookup): Just use
101 'NamespaceEntry.LookupNamespaceOrType'.
103 2004-12-03 Martin Baulig <martin@ximian.com>
105 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
106 method as our child, call AnonymousMethod.Compatible() on it.
108 2004-12-03 Raja R Harinath <rharinath@novell.com>
110 Disable XML documentation support in 'basic' profile.
111 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
112 Redirect XmlElement to System.Object.
113 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
114 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
115 * mcs.exe.sources: Add doc-bootstrap.cs.
116 * doc-bootstrap.cs: New file. Contains empty stub implementation
119 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
121 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
122 comments are allowed.
124 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
126 * delegate.cs: Add checks for subtypes in paramaters and return values
127 in VerifyMethod () to add support for Covariance/Contravariance
130 2004-12-02 Miguel de Icaza <miguel@ximian.com>
132 * report.cs: Remove extra closing parenthesis.
134 * convert.cs (Error_CannotImplicitConversion): If the name of the
135 types are the same, provide some extra information.
137 * class.cs (FieldBase): Use an unused bit field from the field to
138 encode the `has_offset' property from the FieldMember. This saves
139 a couple of Ks on bootstrap compilation.
141 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
142 method as our child, return the AnonymousMethod resolved
145 * expression.cs (New.DoResolve): Allow return values from
146 NewDelegate to also include AnonymousMethods.
150 2004-12-02 Marek Safar <marek.safar@seznam.cz>
153 * attribute.cs (Resolve): Improved implementation of params
156 * support.cs (ParameterData): Add HasParams to be faster.
158 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
160 all things are for /doc support:
162 * doc.cs: new file that supports XML documentation generation.
163 * mcs.exe.sources: added doc.cs.
165 Handle /doc command line option.
166 Report error 2006 instead of 5 for missing file name for /doc.
167 Generate XML documentation when required, after type resolution.
169 Added support for picking up documentation (/// and /** ... */),
170 including a new XmlCommentState enumeration.
172 Added lines to fill Documentation element for field, constant,
173 property, indexer, method, constructor, destructor, operator, event
174 and class, struct, interface, delegate, enum.
175 Added lines to warn incorrect comment.
177 Added Documentation field (passed only when /doc was specified).
179 Added DocComment, DocCommentHeader, GenerateDocComment() and
180 OnGenerateDocComment() and some supporting private members for
181 /doc feature to MemberCore.
183 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
185 Added overriden DocCommentHeader.
187 Added overriden DocCommentHeader and GenerateDocComment().
189 2004-12-01 Miguel de Icaza <miguel@ximian.com>
191 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
192 unwrapping the enumeration values, chain to
193 DoConstantNumericPromotions again, so we can promote things to the
194 fundamental types (takes care of enums that are bytes, sbytes).
198 2004-12-01 Raja R Harinath <rharinath@novell.com>
200 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
201 Fix long-standing bug in type-lookup. Use FindType instead of
202 LookupType when ec.ResolvingTypeTree.
203 (Attribute.ResolveType, Attribute.Resolve)
204 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
206 (Attributes.Search): Remove internal version. Update.
207 (Attributes.SearchMulti): Update.
208 (Attributes.GetClsCompliantAttribute): Remove.
209 (Attributes.GetIndexerNameAttribute): Remove.
210 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
211 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
212 * class.cs (Indexer.Define): Likewise.
214 2004-12-01 Marek Safar <marek.safar@seznam.cz>
217 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
218 MarshallByReference members access.
220 * expression.cs: Use CheckMarshallByRefAccess;
221 Better error CS0197 message.
223 * report.cs: Print whole related error message.
225 2004-11-30 Raja R Harinath <rharinath@novell.com>
227 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
228 the current directory to help debugging.
230 2004-11-29 Marek Safar <marek.safar@seznam.cz>
232 * class (GetClassBases): Better error 60 report.
233 (EventProperty): Disabled warning 67 detection.
235 2004-11-29 Marek Safar <marek.safar@seznam.cz>
238 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
240 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
243 2004-11-29 Marek Safar <marek.safar@seznam.cz>
246 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
248 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
250 2004-11-26 Miguel de Icaza <miguel@ximian.com>
252 * attribute.cs (Attribute.Resolve): Refine error reporting and
253 report a cs0117 if the identifier does not exist, to distinguish
254 from 0617 which is a miss-use of the actual identifier.
256 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
257 between cs0070 and cs0079.
259 * class.cs (MemberBase.DoDefine): When reporting a wrong
260 accessibility level, we use MethodCore to compare instead of
261 Method (this was a regression in some refactoring effort).
263 So now we correctly report cs0056 again.
265 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
266 testing the target_type (which was known to be object_type) and
267 not the source type (which is anonymous_method).
269 Fixed reporting of error cs1660.
271 * expression.cs (UserCast.Source): Expose the underlying cast.
273 * statement.cs (Switch.SwitchGoverningType): Sort the list of
274 allowed types to find a match to int32 first (most common).
276 In addition, it ignores any ImplicitUserConversions that did an
277 internal implicit conversion (as the switch statement allows only
278 one integral conversion to exist).
280 * class.cs (PartialContainer.Create): rename `name' to
281 `member_name' for clarity. Then replace the string calls with a
282 call to MemberName.GetPartialName, as now using
283 MemberName.ToString is an error (this is due to the side effects
284 it had, that were fixed in the past).
286 This will restore the error reporting on a number of partial class
287 errors that were missusing this (and getting an exception as a
288 results, which is now just a plain textual warning, because
289 yyparse debug output would crash otherwise).
291 2004-11-26 Raja R Harinath <rharinath@novell.com>
293 * Makefile (PROGRAM_INSTALL_DIR): Remove.
295 2004-11-25 Ben Maurer <bmaurer@ximian.com>
297 * rootcontext.cs (LookupType): Make sure to cache lookups that
298 don't give us a negative result. This saves about 5% of corlib
301 2004-11-25 Miguel de Icaza <miguel@ximian.com>
303 * report.cs (AbstractMessage.Print): messages are sent to stderr
305 * class.cs (TypeContainer.GetClassBases): It is an error to have a
306 non-interface in the list of interfaces (at this point, either
307 parent was properly set, or a base class is being listed in the
310 This flags error 1722, and resolves the crash from bug 69259.
312 2004-11-25 Ben Maurer <bmaurer@ximian.com>
314 * statement.cs (Using.EmitExpressionFinally): make this work right
315 for valuetypes. Fixes 69926.
317 2004-11-25 Miguel de Icaza <miguel@ximian.com>
319 * const.cs (Const.ChangeType): Cope with the "0 literal can be
320 converted to an enum" here, before we try to change the underlying
321 type. This code exists, but it is a different code path than the
322 one used while encoding constants.
324 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
325 old bug: when converting from the null literal to a pointer,
326 return an EmptyCast, not the NullLiteral.
328 This fixes #69921, the recent null_type changes probably made this
331 (ImplicitReferenceConversionExists): In addition, resynchronized
332 the code here, so it matches the same code in
333 ImplicitReferenceConversionExists for the `from any class-type S
334 to any interface-type T'.
337 2004-11-25 Marek Safar <marek.safar@seznam.cz>
339 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
341 2004-11-24 Miguel de Icaza <miguel@ximian.com>
343 * cs-parser.jay: Use verbosity accordingly.
345 2004-11-24 Marek Safar <marek.safar@seznam.cz>
347 * expression.cs (Unary.ResolveOperator): Do not report warning;
348 AddressOf reads from variable.
350 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
352 2004-11-24 Marek Safar <marek.safar@seznam.cz>
356 * attribute.cs (Attributable): Removed CheckTargets.
357 (Attributes.Emit): Explicit attribute targets are tested here.
359 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
360 not enabled for interfaces.
362 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
363 (GetAssemblyName): Ouch next bug there.
365 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
367 * expression.cs: Error 275 added.
369 2004-11-23 Marek Safar <marek.safar@seznam.cz>
371 Fix bug #69177 (Implemented decimal constant support)
373 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
374 (BinaryFold): Add DecimalConstant.
376 * const.cs (Define): Decimal constant
378 (ChangeType): Add decimal type handling.
379 (LookupConstantValue): Don't set value for decimal type but
380 emit DecimalConstantAttribute. Needed for constant optimization.
382 * constant.cs (ToDecimal): New method.
383 (ConvertToDecimal): New method.
384 (IntConstant): Implemented ConvertToDecimal.
385 (DecimalConstant.Emit): Emit optimized version for decimals in
388 * expression.cs (ResolveOperator): Changed order of constant
389 reduction to work correctly with native types which have
390 overloaded operators.
391 (ResolveMemberAccess): Extract constant value from attribute
394 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
396 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
397 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
398 (ChangeType): Decimal is special.
399 (TypeToCoreType): Add decimal type.
401 2004-11-22 Marek Safar <marek.safar@seznam.cz>
403 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
406 2004-11-22 Marek Safar <marek.safar@seznam.cz>
408 * class.cs (EventField.ApplyAttributeBuilder): Fix error
411 2004-11-19 Marek Safar <marek.safar@seznam.cz>
413 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
415 * pending.cs (PendingImplementation): Grab only interfaces.
417 2004-11-19 Marek Safar <marek.safar@seznam.cz>
419 * statement.cs (ForeachHelperMethods): Add location member and
422 2004-11-19 Raja R Harinath <rharinath@novell.com>
424 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
425 automatically handled by executable.make.
426 (PROGRAM): Make profile-specific.
428 2004-11-18 Marek Safar <marek.safar@seznam.cz>
430 * expression.cs (DoResolveBase): Fixed wrong warning for out
433 2004-11-18 Martin Baulig <martin@ximian.com>
435 Merged latest changes into gmcs. Please keep this comment in
436 here, it makes it easier for me to see what changed in MCS since
437 the last time I merged.
439 2004-11-17 Raja R Harinath <rharinath@novell.com>
441 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
442 (TypeHandle.GetMemberCache): New.
443 (TypeHandle.TypeHandle): Update.
444 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
445 (TypeManager.LookupParentInterfacesCache):
446 Rename from LookupInterfaceCache. Optimize slightly.
447 (TypeManager.MemberLookup_FindMembers): Update.
448 * decl.cs (MemberCache.MemberCache): Set Container to null in the
450 (AddCacheContents): Rename from AddHashtable.
451 * class.cs (TypeContainer.parent_container): Remove.
452 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
453 (TypeContainer.DoDefineMembers): Don't initialize it.
454 Update to name changes.
456 2004-11-17 Miguel de Icaza <miguel@ximian.com>
458 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
459 that factors the code to check access modifiers on override.
461 (PropertyBase): Use the code here.
463 Patch from Lluis S'anchez, fixes bug #69361.
465 2004-11-15 Miguel de Icaza <miguel@ximian.com>
467 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
468 routine that is used to report the use of a captured variable
469 whose address has been taken.
471 There are two checks: one when variables are being captured and
472 the other check is when the address of a variable is taken.
474 (because an anonymous methods might be resolved before *or* after
475 the address has been taken) and
477 * expression.cs (Conditional.DoResolve): Remove the special
478 casing that Martin added to trueExpr and falseExpr being both
479 NullLiteral. We get the right behavior now just by introducing
480 the null_type into the compiler.
482 * convert.cs (ExplicitConversion): Change the code to use
483 null_type instead of testing `expr is NullLiteral'.
484 (ImplicitConversionStandard): use null_type too.
485 (ImplicitReferenceConversionExists): use null_type too.
486 (ImplicitReferenceConversion): use null_type too.
488 * literal.cs: The type of `NullLiteral' is now null_type instead
490 (Resolve): Set the type here.
492 * typemanager.cs: Introduce null_type.
494 2004-11-17 Martin Baulig <martin@ximian.com>
496 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
497 direction, like FindMembers() does. Fixes #69546, testcase is in
500 2004-11-16 Martin Baulig <martin@ximian.com>
502 This is based on a patch from Marek Safar, see bug #69082.
503 Fixes bugs #63705 and #67130.
505 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
506 method; create a MemberCache for an interface type and cache the
509 * decl.cs (IMemberContainer.ParentContainer): Removed.
510 (IMemberContainer.ParentCache): New property.
511 (MemberCache.SetupCacheForInterface): Removed.
512 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
513 to create a cache for an interface's "parent".
515 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
518 2004-11-16 Martin Baulig <martin@ximian.com>
520 Merged back from gmcs; these changes already went into gmcs a
524 (TypeManager.AddUserType): Removed the `ifaces' argument.
525 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
527 (TypeManager.AddUserInterface): Removed.
528 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
530 (TypeManager.GetInterfaces): Likewise.
531 (TypeManager.GetExplicitInterfaces): Likewise.
533 * ecore.cs (TypeExpr.GetInterfaces): Removed.
535 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
536 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
538 2004-11-14 Ben Maurer <bmaurer@ximian.com>
540 * statement.cs: Avoid adding bools to a hashtable.
542 2004-11-07 Miguel de Icaza <miguel@ximian.com>
544 * expression.cs (Invocation.OverloadResolve): Flag error if we are
545 calling an unsafe method from a safe location.
547 2004-11-06 Marek Safar <marek.safar@seznam.cz>
550 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
552 2004-11-06 Miguel de Icaza <miguel@ximian.com>
554 * namespace.cs (VerifyUsing): use GetPartialName instead of
557 2004-11-05 Miguel de Icaza <miguel@ximian.com>
559 * statement.cs (Return.Resolve): Fix regression in typo: if
560 `in_exc', we have to request a NeedReturnLabel, this was a typo
561 introduced in the anonymous method check-in. Fixes #69131.
563 * Indexers were using the ShortName when defining themselves,
564 causing a regression in the compiler bootstrap when applying the
565 patch from 2004-11-02 (first part), now they use their full name
568 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
570 * driver.cs: Strip the path from the names of embedded resources. Fixes
573 2004-11-04 Raja R Harinath <rharinath@novell.com>
575 Fix error message regression: cs0104-2.cs.
576 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
577 (AliasEntry.Resolve): Update.
578 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
580 (RootContext.LookupType): Update.
582 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
584 * cs-parser.jay: Add support for handling accessor modifiers
585 * class: Add support port accessor modifiers and error checking,
586 define PropertyMethod.Define as virtual (not abstract anymore)
587 * ecore.cs: Add checking for proeprties access with access modifiers
588 * iterators.cs: Modify Accessor constructor call based in the modified
590 2004-11-02 Ben Maurer <bmaurer@ximian.com>
592 * expression.cs (StringConcat): Handle being called twice,
593 as when we have a concat in a field init with more than two
596 2004-11-02 Miguel de Icaza <miguel@ximian.com>
598 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
599 special case explicit implementations, we should always produce
600 the .property or .event declaration.
602 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
603 since it will not return correct data if people use this
604 unresolved in the presence of using statements (see test-313).
606 * class.cs (MethodData.Define): If we are an explicit interface
607 implementation, set the method name to the full name of the
608 interface plus the name of the method.
610 Notice that using the method.MethodName.GetFullName() does not
611 work, as it will only contain the name as declared on the source
612 file (it can be a shorthand in the presence of using statements)
613 and not the fully qualifed type name, for example:
617 class D : ICloneable {
618 object ICloneable.Clone () {
622 Would produce a method called `ICloneable.Clone' instead of
623 `System.ICloneable.Clone'.
625 * namespace.cs (Alias.Resolve): Use GetPartialName.
627 2004-11-01 Marek Safar <marek.safar@seznam.cz>
629 * cs-parser.jay: Add error 1055 report.
631 2004-11-01 Miguel de Icaza <miguel@ximian.com>
633 * assign.cs (Assign.DoResolve): Only do the transform of
634 assignment into a New if the types are compatible, if not, fall
635 through and let the implicit code deal with the errors and with
636 the necessary conversions.
638 2004-11-01 Marek Safar <marek.safar@seznam.cz>
640 * cs-parser.jay: Add error 1031 report.
642 * cs-tokenizer.cs: Add location for error 1038.
644 2004-10-31 Marek Safar <marek.safar@seznam.cz>
646 * cs-parser.jay: Add error 1016 report.
648 2004-10-31 Marek Safar <marek.safar@seznam.cz>
650 * cs-parser.jay: Add errors 1575,1611 report.
652 2004-10-31 Marek Safar <marek.safar@seznam.cz>
654 * cs-parser.jay: Add error 1001 report.
656 2004-10-31 Marek Safar <marek.safar@seznam.cz>
659 * attribute.cs (GetMarshal): Add method argument for
660 caller identification.
662 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
663 agument for GetMarshal and RuntimeMissingSupport.
665 2004-10-31 Marek Safar <marek.safar@seznam.cz>
667 * attribute.cs (ExtractSecurityPermissionSet): Removed
668 TypeManager.code_access_permission_type.
670 * typemanager.cs: Removed TypeManager.code_access_permission_type.
672 2004-10-27 Miguel de Icaza <miguel@ximian.com>
674 * expression.cs (LocalVariableReference.DoResolveLValue): Check
675 for obsolete use of a variable here. Fixes regression on errors
676 cs0619-25 and cs0619-26.
678 2004-10-27 Marek Safar <marek.safar@seznam.cz>
680 Fix #62358, implemented security attribute encoding.
682 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
683 Tests permitted SecurityAction for assembly or other types.
684 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
685 data from SecurityPermissionAttribute to PermisionSet class.
687 * class.cs (ApplyAttributeBuilder): Added special handling
688 for System.Security.Permissions.SecurityAttribute based types.
690 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
691 special handling for System.Security.Permissions.SecurityAttribute
694 * enum.cs (ApplyAttributeBuilder): Added special handling
695 for System.Security.Permissions.SecurityAttribute based types.
697 * parameter.cs (ApplyAttributeBuilder): Added special handling
698 for System.Security.Permissions.SecurityAttribute based types.
700 * rootcontext.cs: Next 2 core types.
702 * typemanager.cs (TypeManager.security_permission_attr_type):
703 Built in type for the SecurityPermission Attribute.
704 (code_access_permission_type): Build in type.
706 2004-10-17 Miguel de Icaza <miguel@ximian.com>
708 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
709 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
710 all of this information into
711 EmitContext.EmitCapturedVariableInstance.
713 * codegen.cs (EmitCapturedVariableInstance): move here the
714 funcionality of emitting an ldarg.0 in the presence of a
715 remapping. This centralizes the instance emit code.
717 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
718 then emit a load of this: it means that we have reached the
719 topmost ScopeInfo: the one that contains the pointer to the
720 instance of the class hosting the anonymous method.
722 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
723 captures to the topmost CaptureContext.
725 2004-10-12 Miguel de Icaza <miguel@ximian.com>
727 * expression.cs (LocalVariableReference): Move the knowledge about
728 the iterators into codegen's EmitCapturedVariableInstance.
730 2004-10-11 Miguel de Icaza <miguel@ximian.com>
732 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
733 all code paths return a value from an anonymous method (it is the
734 same as the 161 error, but for anonymous methods).
736 2004-10-08 Miguel de Icaza <miguel@ximian.com>
738 The introduction of anonymous methods in the compiler changed
739 various ways of doing things in the compiler. The most
740 significant one is the hard split between the resolution phase
741 and the emission phases of the compiler.
743 For instance, routines that referenced local variables no
744 longer can safely create temporary variables during the
745 resolution phase: they must do so from the emission phase,
746 since the variable might have been "captured", hence access to
747 it can not be done with the local-variable operations from the runtime.
751 (Block.Flags): New flag `IsTopLevel' to indicate that this block
754 (ToplevelBlock): A new kind of Block, these are the blocks that
755 are created by the parser for all toplevel method bodies. These
756 include methods, accessors and anonymous methods.
758 These contain some extra information not found in regular blocks:
759 A pointer to an optional CaptureContext (for tracking captured
760 local variables and parameters). A pointer to the parent
763 (Return.Resolve): Catch missmatches when returning a value from an
764 anonymous method (error 1662).
765 Invoke NeedReturnLabel from the Resolve phase instead of the emit
768 (Break.Resolve): ditto.
770 (SwitchLabel): instead of defining the labels during the
771 resolution phase, we now turned the public ILLabel and ILLabelCode
772 labels into methods called GetILLabelCode() and GetILLabel() that
773 only define the label during the Emit phase.
775 (GotoCase): Track the SwitchLabel instead of the computed label
776 (its contained therein). Emit the code by using
777 SwitchLabel.GetILLabelCode ().
779 (LocalInfo.Flags.Captured): A new flag has been introduce to track
780 whether the Local has been captured or not.
782 (LocalInfo.IsCaptured): New property, used to tell whether the
783 local has been captured.
785 * anonymous.cs: Vastly updated to contain the anonymous method
788 The main classes here are: CaptureContext which tracks any
789 captured information for a toplevel block and ScopeInfo used to
790 track the activation frames for various local variables.
792 Each toplevel block has an optional capture context associated
793 with it. When a method contains an anonymous method both the
794 toplevel method and the anonymous method will create a capture
795 context. When variables or parameters are captured, they are
796 recorded on the CaptureContext that owns them, for example:
800 MyDelegate d = delegate {
805 Here `a' will be recorded as captured on the toplevel
806 CapturedContext, the inner captured context will not have anything
807 (it will only have data if local variables or parameters from it
808 are captured in a nested anonymous method.
810 The ScopeInfo is used to track the activation frames for local
811 variables, for example:
813 for (int i = 0; i < 10; i++)
814 for (int j = 0; j < 10; j++){
815 MyDelegate d = delegate {
820 At runtime this captures a single captured variable `i', but it
821 captures 10 different versions of the variable `j'. The variable
822 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
825 The toplevel ScopeInfo will also track information like the `this'
826 pointer if instance variables were referenced (this is necessary
827 as the anonymous method lives inside a nested class in the host
830 (AnonymousMethod): Expanded to track the Toplevel, implement
831 `AnonymousMethod.Compatible' to tell whether an anonymous method
832 can be converted to a target delegate type.
834 The routine now also produces the anonymous method content
836 (AnonymousDelegate): A helper class that derives from
837 DelegateCreation, this is used to generate the code necessary to
838 produce the delegate for the anonymous method that was created.
840 * assign.cs: API adjustments for new changes in
841 Convert.ImplicitStandardConversionExists.
843 * class.cs: Adjustments to cope with the fact that now toplevel
844 blocks are of type `ToplevelBlock'.
846 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
847 insteda of standard blocks.
849 Flag errors if params arguments are passed to anonymous methods.
851 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
852 `CurrentAnonymousMethod' which points to the current Anonymous
853 Method. The variable points to the AnonymousMethod class that
854 holds the code being compiled. It is set in the new EmitContext
855 created for the anonymous method.
857 (EmitContext.Phase): Introduce a variable and an enumeration to
858 assist in enforcing some rules about when and where we are allowed
859 to invoke certain methods (EmitContext.NeedsReturnLabel is the
860 only one that enfonces this right now).
862 (EmitContext.HaveCaptureInfo): new helper method that returns
863 whether we have a CapturedContext initialized.
865 (EmitContext.CaptureVariable): New method used to register that a
866 LocalInfo must be flagged for capturing.
868 (EmitContext.CapturedParameter): New method used to register that a
869 parameters must be flagged for capturing.
871 (EmitContext.CapturedField): New method used to register that a
872 field must be flagged for capturing.
874 (EmitContext.HaveCapturedVariables,
875 EmitContext.HaveCapturedFields): Return whether there are captured
878 (EmitContext.EmitMethodHostInstance): This is used to emit the
879 instance for the anonymous method. The instance might be null
880 (static methods), this (for anonymous methods that capture nothing
881 and happen to live side-by-side with the current method body) or a
882 more complicated expression if the method has a CaptureContext.
884 (EmitContext.EmitTopBlock): Routine that drives the emission of
885 code: it will first resolve the top block, then emit any metadata
886 and then emit the code. The split is done so that we can extract
887 any anonymous methods and flag any captured variables/parameters.
889 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
890 during this phase, the ILGenerator should not be used as labels
891 and local variables declared here might not be accessible to any
892 code that is part of an anonymous method.
894 Exceptions to this include the temporary variables that are
895 created by some statements internally for holding temporary
898 (EmitContext.EmitMeta): New routine, in charge of emitting all the
901 (EmitContext.TemporaryReturn): This method is typically called
902 from the Emit phase, and its the only place where we allow the
903 ReturnLabel to be defined other than the EmitMeta. The reason is
904 that otherwise we would have to duplicate a lot of logic in the
905 Resolve phases of various methods that today is on the Emit
908 (EmitContext.NeedReturnLabel): This no longer creates the label,
909 as the ILGenerator is not valid during the resolve phase.
911 (EmitContext.EmitThis): Extended the knowledge in this class to
912 work in anonymous methods in addition to iterators.
914 (EmitContext.EmitCapturedVariableInstance): This emits whatever
915 code is necessary on the stack to access the instance to a local
916 variable (the variable will be accessed as a field).
918 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
919 EmitContext.EmitAddressOfParameter): Routines to support
920 parameters (not completed at this point).
922 Removals: Removed RemapLocal and RemapLocalLValue. We probably
923 will also remove the parameters.
925 * convert.cs (Convert): Define a `ConstantEC' which points to a
926 null. This is just to prefity some code that uses
927 ImplicitStandardConversion code and do not have an EmitContext
930 The idea is to flag explicitly that at that point in time, it is
931 known that the conversion will not trigger the delegate checking
932 code in implicit conversions (which requires a valid
935 Everywhere: pass new EmitContext parameter since
936 ImplicitStandardConversionExists now requires it to check for
937 anonymous method conversions.
939 (Convert.ImplicitStandardConversionExists): If the type of an
940 expression is the anonymous_method_type, and the type is a
941 delegate, we invoke the AnonymousMethod.Compatible method to check
942 whether an implicit conversion is possible.
944 (Convert.ImplicitConversionStandard): Only do implicit method
945 group conversions if the language level is not ISO_1.
947 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
948 MethodInfo for the Invoke method. used by Delegate and
951 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
952 method conversions if the target type is a delegate.
954 Removed extra debugging nops.
956 (LocalVariableReference): Turn the `local_info' into a public
959 Add `prepared' field, the same hack used for FieldExprs to cope
960 with composed assignments, as Local variables do not necessarily
961 operate purely on the stack as they used to: they can be captured
964 Add `temp' for a temporary result, like fields.
966 Refactor DoResolve and DoResolveLValue into DoResolveBase.
968 It now copes with Local variables that are captured and emits the
969 proper instance variable to load it from a field in the captured
972 (ParameterReference.DoResolveBase): During the resolve phase,
973 capture parameters if we are in an anonymous method.
975 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
976 anonymous method, use the EmitContext helper routines to emit the
979 * iterators.cs: Set RemapToProxy to true/false during the
982 * parameters.cs (GetParameterByName): New helper method.
984 * typemanager.cs (anonymous_method_type) a new type that
985 represents an anonyous method. This is always an internal type,
986 used as a fencepost to test against the anonymous-methodness of an
989 2004-10-20 Marek Safar <marek.safar@seznam.cz>
991 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
993 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
995 2004-10-18 Martin Baulig <martin@ximian.com>
997 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
998 `Type' directly, but call ResolveType() on it.
999 (Catch.Resolve): Likewise.
1000 (Foreach.Resolve): Likewise.
1002 2004-10-18 Martin Baulig <martin@ximian.com>
1004 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1005 `Type' directly, but call ResolveType() on it.
1006 (Probe.DoResolve): Likewise.
1007 (ArrayCreation.LookupType): Likewise.
1008 (TypeOf.DoResolve): Likewise.
1009 (SizeOf.DoResolve): Likewise.
1011 2004-10-18 Martin Baulig <martin@ximian.com>
1013 * expression.cs (Invocation.BetterFunction): Put back
1014 TypeManager.TypeToCoreType().
1016 2004-10-18 Raja R Harinath <rharinath@novell.com>
1018 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1021 2004-10-18 Martin Baulig <martin@ximian.com>
1023 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1024 `Type' directly, but call ResolveType() on it.
1026 2004-10-18 Martin Baulig <martin@ximian.com>
1028 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1029 `Type' directly, but call ResolveType() on it.
1030 (MemberBase.DoDefine): Likewise.
1032 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1033 `Type' directly, but call ResolveType() on it.
1034 (ComposedCast.DoResolveAsTypeStep): Likewise.
1036 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1037 `Type' directly, but call ResolveType() on it.
1039 2004-10-17 John Luke <john.luke@gmail.com>
1041 * class.cs (Operator.GetSignatureForError): use CSharpName
1043 * parameter.cs (Parameter.GetSignatureForError): Returns
1044 correct name even if was not defined.
1046 2004-10-13 Raja R Harinath <rharinath@novell.com>
1049 * class.cs (TypeContainer.EmitContext): New property.
1050 (DefineNestedTypes): Create an emitcontext for each part.
1051 (MethodCore.DoDefineParameters): Use container's emitcontext.
1052 Pass type array to InternalParameters.
1053 (MemberBase.DoDefine): Use container's emitcontext.
1054 (FieldMember.Define): Likewise.
1055 (Event.Define): Likewise.
1056 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1057 Pass type array to InternalParameters.
1058 (SetIndexerMethod.GetParameterInfo): Likewise.
1059 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1060 * delegate.cs (Define): Pass emitcontext to
1061 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1062 array to InternalParameters.
1063 * expression.cs (ParameterReference.DoResolveBase): Pass
1064 emitcontext to GetParameterInfo.
1065 (ComposedCast.DoResolveAsTypeStep): Remove check on
1066 ec.ResolvingTypeTree.
1067 * parameter.cs (Parameter.Resolve): Change argument to
1068 EmitContext. Use ResolveAsTypeTerminal.
1069 (Parameter.GetSignature): Change argument to EmitContext.
1070 (Parameters.ComputeSignature): Likewise.
1071 (Parameters.ComputeParameterTypes): Likewise.
1072 (Parameters.GetParameterInfo): Likewise.
1073 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1074 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1075 * support.cs (InternalParameters..ctor): Remove variant that takes
1077 * typemanager.cs (system_intptr_expr): New.
1078 (InitExpressionTypes): Initialize it.
1080 2004-10-12 Chris Toshok <toshok@ximian.com>
1082 * cs-parser.jay: fix location for try_statement and catch_clause.
1084 2004-10-11 Martin Baulig <martin@ximian.com>
1086 * report.cs: Don't make --fatal abort on warnings, we have
1087 -warnaserror for that.
1089 2004-10-07 Raja R Harinath <rharinath@novell.com>
1091 More DeclSpace.ResolveType avoidance.
1092 * decl.cs (MemberCore.InUnsafe): New property.
1093 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1094 with newly created EmitContext.
1095 (FieldMember.Define): Likewise.
1096 * delegate.cs (Delegate.Define): Likewise.
1097 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1098 only if normal name-lookup fails.
1099 (TypeExpr.DoResolve): Enable error-checking.
1100 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1101 (SizeOf.DoResolve): Likewise.
1102 (ComposedCast.DoResolveAsTypeStep): Likewise.
1103 (StackAlloc.DoResolve): Likewise.
1104 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1105 (Block.Unsafe): New property.
1106 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1107 (Unsafe): Set 'unsafe' flag of contained block.
1108 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1109 (Fixed.Resolve): Likewise.
1110 (Catch.Resolve): Likewise.
1111 (Using.ResolveLocalVariableDecls): Likewise.
1112 (Foreach.Resolve): Likewise.
1114 2004-10-05 John Luke <john.luke@gmail.com>
1116 * cs-parser.jay: add location to error CS0175
1118 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1120 * ecore.cs (Expression.Constantity): Add support for turning null
1123 * const.cs (Const.Define): Allow constants to be reference types
1124 as long as the value is Null.
1126 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1128 * namespace.cs (NamespaceEntry.Using): No matter which warning
1129 level is set, check if this namespace name has already been added.
1131 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1133 * expression.cs: reftype [!=]= null should always use br[true,false].
1136 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1139 * attribute.cs: Enum conversion moved to
1140 GetAttributeArgumentExpression to be applied to the all
1143 2004-10-01 Raja R Harinath <rharinath@novell.com>
1145 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1146 * class.c (TypeContainer.DefineType): Flag error if
1147 base types aren't accessible due to access permissions.
1148 * decl.cs (DeclSpace.ResolveType): Move logic to
1149 Expression.ResolveAsTypeTerminal.
1150 (DeclSpace.ResolveTypeExpr): Thin layer over
1151 Expression.ResolveAsTypeTerminal.
1152 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1153 Refactor code into NestedAccess. Use it.
1154 (DeclSpace.NestedAccess): New.
1155 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1156 argument to silence errors. Check access permissions.
1157 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1158 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1159 (Cast.DoResolve): Likewise.
1160 (New.DoResolve): Likewise.
1161 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1162 (TypeOf.DoResolve): Likewise.
1164 * expression.cs (Invocation.BetterConversion): Return the Type of
1165 the better conversion. Implement section 14.4.2.3 more faithfully.
1166 (Invocation.BetterFunction): Make boolean. Make correspondence to
1167 section 14.4.2.2 explicit.
1168 (Invocation.OverloadResolve): Update.
1169 (Invocation): Remove is_base field.
1170 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1171 (Invocation.Emit): Likewise.
1173 2004-09-27 Raja R Harinath <rharinath@novell.com>
1175 * README: Update to changes.
1177 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1179 * cs-parser.jay: Reverted 642 warning fix.
1181 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1184 * decl.cs (FindMemberWithSameName): Indexer can have more than
1187 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1189 * expression.cs (LocalVariableReference.DoResolveLValue):
1190 Do not report warning 219 for out values.
1191 (EmptyExpression.Null): New member to avoid extra allocations.
1193 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1195 * cs-parser.jay: Fix wrong warning 642 report.
1197 * cs-tokenizer.cs (CheckNextToken): New helper;
1198 Inspect next character if is same as expected.
1200 2004-09-23 Martin Baulig <martin@ximian.com>
1202 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1203 (Convert.ImplicitReferenceConversionExists): Likewise.
1205 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1207 * class.cs (Operator.Define): Add error 448 and 559 report.
1209 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1211 * class.cs (MemberBase.IsTypePermitted): New protected
1212 method for checking error CS0610.
1214 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1216 * class.cs (TypeContainer.HasExplicitLayout): New property
1217 Returns whether container has StructLayout attribute set Explicit.
1218 (FieldMember): New abstract class for consts and fields.
1219 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1220 (Field): Reuse FieldMember.
1222 * const.cs (Const): Reuse FieldMember.
1224 * rootcontext.cs: EmitConstants call moved to class.
1226 2004-09-22 Martin Baulig <martin@ximian.com>
1228 Thanks to Peter Sestoft for this bug report.
1230 * expression.cs (Conditional): If both the `trueExpr' and the
1231 `falseExpr' is a NullLiteral, return a NullLiteral.
1233 2004-09-22 Martin Baulig <martin@ximian.com>
1235 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1236 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1237 for the "get_Current" call.
1239 2004-09-22 Martin Baulig <martin@ximian.com>
1241 Marek and me just fixed one of our oldest bugs: #28562 :-)
1243 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1245 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1246 we're an EnumConstant, just return that.
1247 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1248 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1249 to get the value which'll actually be written into the attribute.
1250 However, we have to use GetValue() to access the attribute's value
1253 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1255 * constant.cs (Constant.IsNegative): New abstract property
1258 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1259 (StackAlloc.DoResolve): Reused IsNegative.
1261 2004-09-21 Martin Baulig <martin@ximian.com>
1263 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1264 if we're used in an iterator, we may be called from different
1267 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1268 we actually have an exception block.
1270 2004-09-20 John Luke <jluke@cfl.rr.com>
1272 * class.cs, cs-parser.jay: Improve the error report for 1520:
1273 report the actual line where the error happens, not where the
1276 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1277 Pass location information that was available elsewhere.
1279 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1281 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1282 runtime to delay sign assemblies.
1284 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1286 * cs-parser.jay: Do not report the stack trace, this is barely
1289 2004-08-22 John Luke <john.luke@gmail.com>
1291 * driver.cs : check that a resource id is not already used
1292 before adding it, report CS1508 if it is, bug #63637
1294 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1296 * ecore.cs: Removed dead code.
1298 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1300 * class.cs: Do not report warning CS0067 on the interfaces.
1302 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1304 * cs-parser.jay: Add error 504 report.
1306 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1308 * rootcontext.cs: WarningLevel is 4 by default now.
1310 * statement.cs (Fixed.Resolve): Do not null
1313 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1316 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1317 deep search when property is not virtual.
1318 (PropertyExpr.ResolveAccessors): Make one call for both
1321 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1324 * statement.cs: Error 152 report constains also location.
1326 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1329 * const.cs: Explicitly set constant as static.
1331 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1334 * cs-parser.jay: Add error 1017 report.
1336 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1338 Fixed bug #59980, #64224
1339 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1341 * typemanager.cs (IsSpecialMethod): Simplified
1343 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1345 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1346 condition with better params.
1348 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1351 * attribute.cs (Resolve): Property has to have both
1354 2004-09-14 Martin Baulig <martin@ximian.com>
1356 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1358 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1361 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1362 called and is obsolete then this member suppress message
1363 when call is inside next [Obsolete] method or type.
1365 * expression.cs: Use TestObsoleteMethodUsage member.
1367 2004-09-14 Martin Baulig <martin@ximian.com>
1369 * cs-parser.jay: Sync a bit with the GMCS version.
1371 2004-09-14 Martin Baulig <martin@ximian.com>
1373 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1374 (CSharpParser.yacc_verbose_flag): New public field.
1376 * genericparser.cs: Removed.
1378 2004-09-14 Raja R Harinath <rharinath@novell.com>
1380 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
1382 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1384 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1386 2004-09-10 Martin Baulig <martin@ximian.com>
1388 Backported my MemberName changes from GMCS into MCS.
1390 - we are now using a special `MemberName' class instead of using
1391 strings; in GMCS, the `MemberName' also contains the type
1394 - changed the grammar rules a bit:
1395 * the old `member_name' is now a `namespace_or_type_name':
1396 The rule is that we use `namespace_or_type_name' everywhere
1397 where we expect either a "member name" (GetEnumerator) or a
1398 "member name" with an explicit interface name
1399 (IEnumerable.GetEnumerator).
1400 In GMCS, the explicit interface name may include type arguments
1401 (IEnumerable<T>.GetEnumerator).
1402 * we use `member_name' instead of just `IDENTIFIER' for
1404 The rule is that we use `member_name' wherever a member may
1405 have type parameters in GMCS.
1407 * decl.cs (MemberName): New public class.
1408 (MemberCore.MemberName): New public readonly field.
1409 (MemberCore.ctor): Take a `MemberName' argument, not a string.
1410 (DeclSpace): Likewise.
1412 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
1413 * enum.cs (Enum.ctor): Likewise.
1415 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
1417 (AliasEntry.ctor): Take a MemberName, not an Expression.
1418 (AliasEntry.UsingAlias): Likewise.
1420 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
1421 (IMethodData.MemberName): Changed type from string to MemberName.
1422 (MemberBase.ExplicitInterfaceName): Likewise.
1423 (AbstractPropertyEventMethod.SetupName): Make this private.
1424 (AbstractPropertyEventMethod.ctor): Added `string prefix'
1425 argument; compute the member name here.
1426 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
1427 on the `member.MemberName' and the `prefix'.
1429 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
1431 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
1432 thus, we get a `MemberName' instead of a `string'. These
1433 declarations may have type parameters in GMCS.
1434 (interface_method_declaration, delegate_declaration): Likewise.
1435 (class_declaration, interface_declaration): Likewise.
1436 (method_header): Use `namespace_or_type_name' instead of
1437 `member_name'. We may be an explicit interface implementation.
1438 (property_declaration, event_declaration): Likewise.
1439 (member_name): This is now just an `IDENTIFIER', not a
1440 `namespace_or_type_name'.
1441 (type_name, interface_type): Removed.
1442 (namespace_or_type_name): Return a MemberName, not an Expression.
1443 (primary_expression): Use `member_name' instead of `IDENTIFIER';
1444 call GetTypeExpression() on the MemberName to get an expression.
1445 (IndexerDeclaration.interface_type): Changed type from string to
1447 (MakeName): Operate on MemberName's instead of string's.
1449 2004-09-13 Raja R Harinath <rharinath@novell.com>
1452 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
1453 (NamespaceEntry.Lookup): Add new argument to flag if we want the
1454 lookup to avoid symbols introduced by 'using'.
1455 * rootcontext.cs (NamespaceLookup): Update.
1457 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1459 * class.cs (TypeContainer.DoDefineMembers): Do not call
1460 DefineDefaultConstructor for static classes.
1462 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1464 * attribute.cs (Attribute.Resolve): Add error 653 report.
1466 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1468 (Method.ApplyAttributeBuilder): Add error 685 report.
1469 (Operator.Define): Add error 564 report.
1471 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1473 * expression.cs (Invocation.DoResolve): Add error
1476 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1479 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1481 * class.cs (ConstructorInitializer.Resolve):
1482 Wrong error number (515->516).
1484 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1486 * class.cs (Indexer.Define): Add error 631 report.
1488 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1490 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1492 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1494 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1496 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1498 * cs-parser.jay: Added error CS0241 report.
1500 2004-09-10 Raja R Harinath <rharinath@novell.com>
1502 * cs-parser.jay (fixed_statement): Introduce a scope for the
1503 declaration in the 'fixed' statement.
1505 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1507 * cs-parser.jay: Added CS0230 error report.
1509 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1511 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1513 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1515 * expression.cs (Argument.Resolve): Added error CS0192 and
1518 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1520 C# 2.0 #pragma warning feature
1522 * cs-tokenizer.cs (PreProcessPragma): New method;
1523 Handles #pragma directive.
1525 * report.cs (WarningRegions): New class; Support
1526 class for #pragma warning directive. It tests whether
1527 warning is enabled for a given line.
1529 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1531 * const.cs: Add more descriptive error report, tahnks to
1534 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1536 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1538 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1540 * expression.cs: Apply patch from Ben: Remove dead code from
1541 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1542 as that code just threw an exception anwyays.
1544 * const.cs: Remove the call to the turnintoconstant, for details
1547 * literal.cs: The type of the null-literal is the null type; So
1548 we use a placeholder type (literal.cs:System.Null, defined here)
1551 * expression.cs (Conditional.DoResolve): Remove some old code that
1552 is no longer needed, conversions have been fixed.
1554 (ArrayCreationExpression.DoResolve): Return false if we fail to
1555 resolve the inner expression.
1557 2004-09-07 Raja R Harinath <rharinath@novell.com>
1560 * cs-parser.jay (delegate_declaration): Record a delegate
1561 declaration as a type declaration.
1562 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1564 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1566 * parameter.cs: Do not crash if the type can not be resolved.
1568 * expression.cs: Report errors with unsafe pointers, fixes #64896
1570 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1572 * expression.cs: Pointer arith always needs to do a conv.i
1573 if the operand is a long. fix 65320
1575 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1577 Fixed cs0619-37.cs, cs0619-38.cs
1579 * enum.cs (GetObsoleteAttribute): Removed.
1581 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1582 on Enum member is double staged. The first is tested member
1585 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1587 Fixed #56986, #63631, #65231
1589 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1590 adds member to name container.
1591 (TypeContainer.AddToTypeContainer): New method, adds type to
1593 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1594 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1595 AddOperator): Simplified by reusing AddToMemberContainer.
1596 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1598 (Method.CheckForDuplications): Fixed implementation to test all
1600 (MemberBase): Detection whether member is explicit interface
1601 implementation is now in constructor.
1602 (MemberBase.UpdateMemberName): Handles IndexerName.
1603 (Accessor): Changed to keep also location information.
1604 (AbstractPropertyEventMethod): Is derived from MemberCore.
1605 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1606 will be emited or not.
1607 (PropertyBase.AreAccessorsDuplicateImplementation):
1608 Tests whether accessors are not in collision with some method.
1609 (Operator): Is derived from MethodCore to simplify common
1612 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1614 (DeclSpace.AddToContainer): Adds the member to defined_names
1615 table. It tests for duplications and enclosing name conflicts.
1617 * enum.cs (EnumMember): Clean up to reuse the base structures
1619 2004-09-03 Martin Baulig <martin@ximian.com>
1621 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1622 into TypeContainer, to make partial classes work again.
1624 2004-09-03 Martin Baulig <martin@ximian.com>
1626 * rootcontext.cs (RootContext.V2): Removed.
1628 2004-03-23 Martin Baulig <martin@ximian.com>
1630 * expression.cs (Invocation.OverloadResolve): Added `bool
1631 may_fail' argument and use it instead of the Location.IsNull() hack.
1633 2004-09-03 Martin Baulig <martin@ximian.com>
1635 Merged latest changes into gmcs. Please keep this comment in
1636 here, it makes it easier for me to see what changed in MCS since
1637 the last time I merged.
1639 2004-09-03 Raja R Harinath <rharinath@novell.com>
1642 * expression.cs (BetterConversion): Don't allow either conversion
1643 to be null. Remove redundant implicit conversion test when 'q ==
1644 null' -- when this function is invoked, we already know that the
1645 implicit conversion exists.
1646 (BetterFunction): Assume that 'best' is non-null. Remove
1647 redundant reimplementation of IsApplicable when 'best' is null.
1648 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1649 number of arguments.
1650 (IsAncestralType): Extract from OverloadResolve.
1651 (OverloadResolve): Make robust to the MethodGroupExpr being
1652 unsorted. Implement all the logic of Section 14.5.5.1, and
1653 support overloading of methods from multiple applicable types.
1654 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1656 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1657 (RealError, Warning): Append type of report to related symbol.
1659 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1661 * enum.cs: Fixed CLS-Compliance checks for enum members.
1662 Error tests cs3008-8.cs, cs3014-8.cs
1664 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1666 Fixed bug #62342, #63102
1667 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1668 like ImplementMethod.
1670 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1672 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1675 2004-09-02 Martin Baulig <martin@ximian.com>
1677 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1678 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1681 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1683 C# 2.0 Static classes implemented
1685 * class.cs (TypeContainer): instance_constructors,
1686 initialized_fields, initialized_static_fields,
1687 default_constructor, base_inteface_types are protected to be
1688 accessible from StaticClass.
1689 (TypeContainer.DefineDefaultConstructor): New virtual method
1690 for custom default constructor generating
1691 (StaticClass): New class to handle "Static classes" feature.
1693 * cs-parser.jay: Handle static keyword on class like instance
1696 * driver.cs: Added "/langversion" command line switch with two
1697 options (iso-1, default).
1699 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1701 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1703 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1705 * delegate.cs: Style.
1707 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1709 * delegate.cs: Add seperate instance expr field for miguel.
1711 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1713 * PointerArithmetic (Resolve): make sure we are not doing
1714 pointer arith on void*. Also, make sure we are resolved
1715 by not setting eclass until resolve.
1717 All callers: Make sure that PointerArithmetic gets resolved.
1719 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1721 * ArrayCreation (LookupType): If the type does not resolve
1722 to an array, give an error.
1724 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1726 * statement.cs (Try.Resolve): Fixed bug #64222
1728 2004-08-27 Martin Baulig <martin@ximian.com>
1731 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1734 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1736 * ecore.cs (Constantify): Get underlying type via
1737 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1738 Windows in special cases.
1740 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1742 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1743 for obtaining also private methods.
1744 (GetRemoveMethod): Used GetRemoveMethod (true)
1745 for obtaining also private methods.
1747 2004-08-24 Martin Baulig <martin@ximian.com>
1749 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1750 MethodAttributes.HideBySig for operators.
1752 2004-08-23 Martin Baulig <martin@ximian.com>
1754 Back to the old error reporting system :-)
1756 * report.cs (Message): Removed.
1757 (Report.MessageData, ErrorData, WarningData): Removed.
1758 (Report.Error, Warning): Back to the old system.
1760 2004-08-23 Martin Baulig <martin@ximian.com>
1762 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1764 * class.cs (TypeContainer.ParentContainer): New public virtual
1765 method; replaces the explicit interface implementation.
1766 (ClassPart.ParentContainer): Override.
1768 2004-08-23 Martin Baulig <martin@ximian.com>
1770 * statement.cs (Switch): Added support for constant switches; see
1771 #59428 or test-285.cs.
1773 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1776 * statement.cs (GetEnumeratorFilter): Removed useless
1777 logic because C# specs is strict. GetEnumerator must be
1780 2004-08-22 Martin Baulig <martin@ximian.com>
1782 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1783 a switch and may break, reset the barrier. Fixes #59867.
1785 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1787 CLS-Compliance speed up (~5% for corlib)
1789 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1790 New method. Tests container for CLS-Compliant names
1792 * class.cs (TypeContainer.VerifyClsName): New method.
1793 Checks whether container name is CLS Compliant.
1794 (Constructor): Implements IMethodData.
1796 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1797 low-case table for CLS Compliance test.
1798 (MemberCache.VerifyClsParameterConflict): New method.
1799 Checks method parameters for CS3006 error.
1801 * enum.cs (EnumMember): Is derived from MemberCore.
1802 (Enum.VerifyClsName): Optimized for better performance.
1804 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1806 * report.cs: Renamed Error_T to Error and changed all
1809 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1811 * class.cs (TypeContainer.IndexerArrayList): New inner class
1812 container for indexers.
1813 (TypeContainer.DefaultIndexerName): New constant for default
1814 indexer name. Replaced all "Item" with this constant.
1815 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1817 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1818 DefaultMemberAttribute constructor.
1820 2004-08-05 Martin Baulig <martin@ximian.com>
1822 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1825 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1827 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1828 multi platforms problem.
1830 * compiler.csproj: Included shared files.
1832 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1834 Fix bug 60333, 55971 in the more general way
1835 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1836 Added arg_type argument for constant conversion.
1837 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1839 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1842 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1843 OperatorArrayList, MethodCoreArrayList for typecontainer
1844 containers. Changed class member types to these new types.
1845 (MethodArrayList.DefineMembers): Added test for CS0659.
1847 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1849 * cfold.cs: Synchronize the folding with the code in expression.cs
1850 Binary.DoNumericPromotions for uint operands.
1852 * attribute.cs: Revert patch from Raja, it introduced a regression
1853 while building Blam-1.2.1 (hard to isolate a test case).
1855 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1859 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1861 (MethodCore.parent_method): New member. The method we're overriding
1862 if this is an override method.
1863 (MethodCore.CheckBase): Moved from Method class and made common.
1864 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1866 (MethodCore.CheckForDuplications): New abstract method. For custom
1867 member duplication search in a container
1868 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1869 method and its return type.
1870 (Event.conflict_symbol): New member. Symbol with same name in the
1874 (MemberCache.FindMemberWithSameName): New method. The method
1875 is looking for conflict with inherited symbols.
1877 2004-08-04 Martin Baulig <martin@ximian.com>
1879 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1881 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1883 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1885 * report.cs (Message): New enum for better error, warning reference in
1887 (MessageData): New inner abstract class. It generally handles printing of
1888 error and warning messages.
1889 Removed unused Error, Warning, Message methods.
1891 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1893 Fix for cs0592-8.cs test
1895 (Attributable.ValidAttributeTargets): Made public.
1896 (Attribute.ExplicitTarget): New member for explicit target value.
1897 (Attribute.CheckTargets): Now we translate explicit attribute
1898 target to Target here.
1900 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1902 * ecore.cs (MethodGroupExpr): new IsBase property.
1904 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1906 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1907 rather than an instance expr.
1909 (DelegateCreation.Emit): Use the method group rather than
1910 the instance expression. Also, if you have base.Foo as the
1911 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1913 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1915 (NewDelegate.DoResolve): Only check for the existance of Invoke
1916 if the method is going to be needed. Use MethodGroupExpr.
1918 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1920 * expression.cs: For pointer arith., make sure to use
1921 the size of the type, not the size of the pointer to
1924 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1927 * class.cs (Class): Added error CS0502 test.
1929 2004-08-03 John Luke <jluke@cfl.rr.com>
1930 Raja R Harinath <rharinath@novell.com>
1933 * attribute.cs (Attribute.complained_before): New flag.
1934 (Attribute.ResolveType, Attribute.Resolve),
1935 (Attribute.DefinePInvokeMethod): Set it.
1936 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1938 2004-08-03 Martin Baulig <martin@ximian.com>
1940 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1941 use a user-defined operator; we still need to do numeric
1942 promotions in case one argument is a builtin type and the other
1943 one has an implicit conversion to that type. Fixes #62322.
1945 2004-08-02 Martin Baulig <martin@ximian.com>
1947 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1948 (LocalInfo.IsThis): New public property.
1949 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1951 2004-08-01 Martin Baulig <martin@ximian.com>
1953 * class.cs (TypeContainer.GetClassBases): Don't set the default
1954 here since we may get called from GetPartialBases().
1955 (TypeContainer.DefineType): If GetClassBases() didn't return a
1956 parent, use the default one.
1958 2004-07-30 Duncan Mak <duncan@ximian.com>
1960 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
1962 2004-07-30 Martin Baulig <martin@ximian.com>
1964 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
1966 * class.cs (SourceMethod): New public class, derive from the
1967 symbol writer's ISourceMethod.
1968 (Method): Use the new symbol writer API.
1970 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
1971 as argument and use the new symbol writer.
1974 (SourceFile): Implement the symbol writer's ISourceFile.
1975 (Location.SymbolDocument): Removed.
1976 (Location.SourceFile): New public property.
1978 * symbolwriter.cs: Use the new symbol writer API.
1980 2004-07-30 Raja R Harinath <rharinath@novell.com>
1982 * Makefile (install-local): Remove. Functionality moved to
1985 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
1987 * Makefile: Install mcs.exe.config file together with mcs.exe.
1988 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
1989 correct runtime version.
1991 2004-07-25 Martin Baulig <martin@ximian.com>
1994 (TypeContainer.RegisterOrder): Removed, this was unused.
1995 (TypeContainer, interface_order): Removed.
1996 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
1997 TypeContainer as argument since we can also be called with a
1998 `PartialContainer' for a partial class/struct/interface.
1999 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2000 of checking whether we're an `Interface' - we could be a
2002 (PartialContainer.Register): Override; call
2003 AddClass()/AddStruct()/AddInterface() on our parent.
2005 * cs-parser.jay (interface_member_declaration): Add things to the
2006 `current_container', not the `current_class'.
2008 * rootcontext.cs (RegisterOrder): The overloaded version which
2009 takes an `Interface' was unused, removed.
2011 * typemanager.cs (TypeManager.LookupInterface): Return a
2012 `TypeContainer', not an `Interface'.
2013 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2014 contain a `PartialContainer' for an interface, so check it's
2015 `Kind' to figure out what it is.
2017 2004-07-25 Martin Baulig <martin@ximian.com>
2019 * class.cs (Class.DefaultTypeAttributes): New public constant.
2020 (Struct.DefaultTypeAttributes): Likewise.
2021 (Interface.DefaultTypeAttributes): Likewise.
2022 (PartialContainer.TypeAttr): Override this and add the
2023 DefaultTypeAttributes.
2025 2004-07-25 Martin Baulig <martin@ximian.com>
2027 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2028 we can just use the `Parent' field instead.
2030 2004-07-25 Martin Baulig <martin@ximian.com>
2032 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2034 2004-07-25 Martin Baulig <martin@ximian.com>
2036 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2037 our parts before defining any methods.
2038 (TypeContainer.VerifyImplements): Make this virtual.
2039 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2040 on our PartialContainer.
2042 2004-07-25 Martin Baulig <martin@ximian.com>
2044 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2046 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2047 argument, we can just use the `Parent' field instead.
2050 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2051 (MemberBase.DoDefine): Likewise.
2053 2004-07-24 Martin Baulig <martin@ximian.com>
2055 * decl.cs (MemberCore.Parent): New public field.
2056 (DeclSpace.Parent): Moved to MemberCore.
2058 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2059 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2061 (FieldBase, Field, Operator): Likewise.
2062 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2063 (EventField, Event): Likewise.
2065 2004-07-23 Martin Baulig <martin@ximian.com>
2067 * class.cs (PartialContainer): New public class.
2068 (ClassPart): New public class.
2069 (TypeContainer): Added support for partial classes.
2070 (TypeContainer.GetClassBases): Splitted some of the functionality
2071 out into GetNormalBases() and GetPartialBases().
2073 * cs-tokenizer.cs (Token.PARTIAL): New token.
2074 (Tokenizer.consume_identifier): Added some hacks to recognize
2075 `partial', but only if it's immediately followed by `class',
2076 `struct' or `interface'.
2078 * cs-parser.jay: Added support for partial clases.
2080 2004-07-23 Martin Baulig <martin@ximian.com>
2082 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2083 a `DeclSpace' and also made it readonly.
2084 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2085 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2086 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2088 * cs-parser.jay: Pass the `current_class', not the
2089 `current_container' (at the moment, this is still the same thing)
2090 to a new Method, Property, Event, Indexer or Constructor.
2092 2004-07-23 Martin Baulig <martin@ximian.com>
2094 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2095 and removed the `current_interface' one.
2096 (struct_declaration, class_declaration, interface_declaration):
2097 Set `current_class' to the newly created class/struct/interface;
2098 set their `Bases' and call Register() before parsing their body.
2100 2004-07-23 Martin Baulig <martin@ximian.com>
2102 * class.cs (Kind): New public enum.
2103 (TypeContainer): Made this class abstract.
2104 (TypeContainer.Kind): New public readonly field.
2105 (TypeContainer.CheckDef): New public method; moved here from
2107 (TypeContainer.Register): New public abstract method.
2108 (TypeContainer.GetPendingImplementations): New public abstract
2110 (TypeContainer.GetClassBases): Removed the `is_class' and
2111 `is_iface' parameters.
2112 (TypeContainer.DefineNestedTypes): Formerly known as
2114 (ClassOrStruct): Made this class abstract.
2116 * tree.cs (RootTypes): New public type.
2118 2004-07-20 Martin Baulig <martin@ximian.com>
2120 * tree.cs (Tree.RecordNamespace): Removed.
2121 (Tree.Namespaces): Removed.
2123 * rootcontext.cs (RootContext.IsNamespace): Removed.
2125 * cs-parser.jay (namespace_declaration): Just create a new
2126 NamespaceEntry here.
2128 2004-07-20 Martin Baulig <martin@ximian.com>
2130 * statement.cs (ExceptionStatement): New abstract class. This is
2131 now used as a base class for everyone who's using `finally'.
2132 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2133 our local variables before using them.
2135 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2136 virtual method. This is used by Yield.Resolve() to "steal" an
2137 outer block's `finally' clauses.
2138 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2141 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2142 version which takes an ExceptionStatement. This version must be
2143 used to create exception branchings.
2146 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2147 (Iterator.EmitMoveNext): Added exception support; protect the
2148 block with a `fault' clause, properly handle 'finally' clauses.
2149 (Iterator.EmitDispose): Run all the `finally' clauses here.
2151 2004-07-20 Martin Baulig <martin@ximian.com>
2153 * iterator.cs: This is the first of a set of changes in the
2154 iterator code. Match the spec more closely: if we're an
2155 IEnumerable, then GetEnumerator() must be called. The first time
2156 GetEnumerator() is called, it returns the current instance; all
2157 subsequent invocations (if any) must create a copy.
2159 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2161 * expression.cs: Resolve the constant expression before returning
2164 2004-07-19 Martin Baulig <martin@ximian.com>
2166 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2167 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2168 the return type of the new EmitContext.
2170 2004-07-18 Martin Baulig <martin@ximian.com>
2172 * class.cs (Property.Define): Fix iterators.
2174 * iterators.cs (Iterator.Define): Moved the
2175 `container.AddInterator (this)' call here from the .ctor; only do
2176 it if we resolved successfully.
2178 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2180 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2181 `true' for preprocessing directives that we parse. The return
2182 value indicates whether we should return to regular tokenizing or
2183 not, not whether it was parsed successfully.
2185 In the past if we were in: #if false ... #line #endif, we would
2186 resume parsing after `#line'. See bug 61604.
2188 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2189 building: IsEnumType should return true only for enums, not for
2190 enums or System.Enum itself. This fixes #61593.
2192 Likely what happened is that corlib was wrong: mcs depended on
2193 this bug in some places. The bug got fixed, we had to add the
2194 hack, which caused bug 61593.
2196 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2197 that was a workaround for the older conditions.
2199 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2201 * assign.cs: IAssignMethod has a new interface, as documented
2202 inline. All assignment code now uses this new api.
2204 * ecore.cs, expression.cs: All classes which implement
2205 IAssignMethod now use the new interface.
2207 * expression.cs (Invocation): add a hack to EmitCall so that
2208 IndexerAccess can be the target of a compound assignment without
2209 evaluating its arguments twice.
2211 * statement.cs: Handle changes in Invocation api.
2213 2004-07-16 Martin Baulig <martin@ximian.com>
2215 * iterators.cs: Rewrote this. We're now using one single Proxy
2216 class for both the IEnumerable and the IEnumerator interface and
2217 `Iterator' derives from Class so we can use the high-level API.
2219 * class.cs (TypeContainer.AddIterator): New method.
2220 (TypeContainer.DoDefineType): New protected virtual method, which
2221 is called from DefineType().
2222 (TypeContainer.DoDefineMembers): Call DefineType() and
2223 DefineMembers() on all our iterators.
2224 (TypeContainer.Emit): Call Emit() on all our iterators.
2225 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2227 * codegen.cs (EmitContext.CurrentIterator): New public field.
2229 2004-07-15 Martin Baulig <martin@ximian.com>
2232 (TypeManager.not_supported_exception_type): New type.
2234 2004-07-14 Martin Baulig <martin@ximian.com>
2236 * iterators.cs: Use real error numbers.
2238 2004-07-14 Martin Baulig <martin@ximian.com>
2240 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2241 requires this to be a System.Collection.IEnumerable and not a
2242 class implementing that interface.
2243 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2245 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2247 * class.cs: Fixed previous fix, it broke some error tests.
2249 2004-07-12 Martin Baulig <martin@ximian.com>
2251 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2254 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2256 * assign.cs (LocalTemporary): Add new argument: is_address,If
2257 `is_address' is true, then the value that we store is the address
2258 to the real value, and not the value itself.
2260 * ecore.cs (PropertyExpr): use the new local temporary
2261 stuff to allow us to handle X.Y += z (where X is a struct)
2263 2004-07-08 Martin Baulig <martin@ximian.com>
2265 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2266 not always return, just like we're doing in Using.Resolve().
2268 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2270 * cs-parser.jay (fixed_statement): flag this as Pinned.
2272 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2274 * typemanager.cs (TypeManager): Removed MakePinned method, this
2275 mechanism is replaced with the .NET 2.x compatible mechanism of
2276 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2278 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2279 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2280 `IsFixed' property which has a different meaning.
2282 2004-07-02 Raja R Harinath <rharinath@novell.com>
2284 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2285 visible from inside a nested class, not just the names of the
2286 immediately enclosing class.
2289 2004-06-24 Raja R Harinath <rharinath@novell.com>
2291 * expression.cs (BetterConversion): Remove buggy special-case
2292 handling of "implicit constant expression conversions". At this
2293 point, we already know that the conversion is possible -- we're
2294 only checking to see which is better.
2296 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2298 * cs-parser.jay: Added error CS0210 test.
2300 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2302 * cs-parser.jay: Added error CS0134 test.
2304 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2307 * cs-parser.jay: Added error CS0145 test.
2309 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2311 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2313 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2315 * expression.cs (StackAlloc.Resolve): The argument may not
2316 be a constant; deal with this case.
2318 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2320 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2321 GetIndexerAttributeValue.
2322 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2324 * class.cs (Indexer.Define): Added error tests for CS0415,
2327 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2329 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2332 2004-06-23 Martin Baulig <martin@ximian.com>
2334 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2335 neither return nor throw, reset the barrier as well. Fixes #60457.
2337 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2339 * class.cs : EventAttributes is now set to None by default.
2340 This fixes bug #60459.
2342 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2345 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2346 Don't throw exception but return null (it's sufficient now).
2348 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2350 * typemanager.cs (GetArgumentTypes): Faster implementation.
2352 2004-06-18 Martin Baulig <martin@ximian.com>
2354 * attribute.cs (Attribute.Resolve): Check whether we're an
2355 EmptyCast which a Constant child. Fixes #60333.
2357 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2359 * statement.cs (EmitCollectionForeach): Account for the fact that
2360 not all valuetypes are in areas which we can take the address of.
2361 For these variables, we store to a temporary variable. Also, make
2362 sure that we dont emit a `callvirt' on a valuetype method.
2364 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2366 * expression.cs (StackAlloc.DoReSolve): Added test for
2367 negative parameter (CS0247).
2369 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2372 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2374 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2377 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2380 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2382 Fix bug #58254 & cs1555.cs, cs1556.cs
2383 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2385 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2387 * cs-parser.jay: Added error CS1669 test for indexers.
2389 2004-06-11 Martin Baulig <martin@ximian.com>
2391 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2392 call this twice: for params and varargs methods.
2394 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2397 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2399 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2401 * attribute.cs (Attribute.GetValidTargets): Made public.
2404 (AbstractPropertyEventMethod): New class for better code sharing.
2405 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2407 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2409 2004-06-11 Raja R Harinath <rharinath@novell.com>
2412 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
2413 that the call to Resolve is part of a MemberAccess.
2414 (Expression.Resolve): Use it for SimpleName resolution.
2415 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
2416 Add 'intermediate' boolean argument.
2417 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
2418 error message when the SimpleName can be resolved ambiguously
2419 between an expression and a type.
2420 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
2422 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
2423 call on the left-side.
2425 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2428 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
2430 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2432 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
2434 2004-06-11 Martin Baulig <martin@ximian.com>
2436 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
2437 varargs methods if applicable.
2439 2004-06-11 Martin Baulig <martin@ximian.com>
2441 * expression.cs (Invocation.EmitCall): Don't use
2442 `method.CallingConvention == CallingConventions.VarArgs' since the
2443 method could also have `CallingConventions.HasThis'.
2445 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2447 * class.cs (Event.GetSignatureForError): Implemented.
2448 Fixed crash in error test cs3010.cs
2450 2004-06-10 Miguel de Icaza <miguel@ximian.com>
2452 * cs-tokenizer.cs: Change the way we track __arglist to be
2453 consistent with the other keywords.
2455 2004-06-09 Miguel de Icaza <miguel@ximian.com>
2457 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
2460 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
2462 * codegen.cs: Check that all referenced assemblies have a strongname
2463 before strongnaming the compiled assembly. If not report error CS1577.
2464 Fix bug #56563. Patch by Jackson Harper.
2465 * typemanager.cs: Added a method to return all referenced assemblies.
2466 Fix bug #56563. Patch by Jackson Harper.
2468 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2471 (Method.ApplyAttributeBuilder): Moved and added conditional
2472 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
2475 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
2477 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2480 * class.cs: (EventField.attribute_targets): Changed default target.
2482 2004-06-08 Martin Baulig <martin@ximian.com>
2484 * expression.cs (Invocation.EmitCall): Enable varargs methods.
2486 2004-06-08 Martin Baulig <martin@ximian.com>
2488 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
2490 2004-06-07 Martin Baulig <martin@ximian.com>
2492 Added support for varargs methods.
2494 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
2497 * cs-parser.jay: Added support for `__arglist'.
2499 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
2501 * expression.cs (Argument.AType): Added `ArgList'.
2502 (Invocation): Added support for varargs methods.
2503 (ArglistAccess): New public class.
2504 (Arglist): New public class.
2506 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
2508 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
2509 a method's top-level block if the method has varargs.
2511 * support.cs (ReflectionParameters, InternalParameters): Added
2512 support for varargs methods.
2514 2004-06-07 Miguel de Icaza <miguel@ximian.com>
2516 * class.cs: Provide location in indexer error report.
2518 * driver.cs: Use standard names.
2520 * namespace.cs: Catch the use of using after a namespace has been
2521 declared also on using aliases.
2523 2004-06-03 Raja R Harinath <rharinath@novell.com>
2526 * typemanager.cs (closure_private_ok, closure_invocation_type)
2527 (closure_qualifier_type, closure_invocation_assembly)
2528 (FilterWithClosure): Move to ...
2529 (Closure): New internal nested class.
2530 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
2531 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
2532 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
2533 (MemberLookup, MemberLookupFailed): Use it.
2534 * expression.cs (New.DoResolve): Treat the lookup for the
2535 constructor as being qualified by the 'new'ed type.
2536 (Indexers.GetIndexersForTypeOrInterface): Update.
2538 2004-06-03 Marek Safar <marek.safar@seznam.cz>
2541 (GetConditionalAttributeValue): New method. Returns
2542 condition of ConditionalAttribute.
2543 (SearchMulti): New method. Returns all attributes of type 't'.
2544 Use it when attribute is AllowMultiple = true.
2545 (IsConditionalMethodExcluded): New method.
2548 (Method.IsExcluded): Implemented. Returns true if method has conditional
2549 attribute and the conditions is not defined (method is excluded).
2550 (IMethodData): Extended interface for ConditionalAttribute support.
2551 (PropertyMethod.IsExcluded): Implemented.
2554 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
2557 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
2560 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
2562 * expression.cs (ArrayCreationExpression): Make this just an
2563 `expression'. It can't be a statement, so the code here was
2566 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2569 * typemanager.cs (GetFullNameSignature): New method for
2572 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2575 * class.cs (MemberBase.GetSignatureForError): New virtual method.
2576 Use this method when MethodBuilder is null.
2577 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
2578 Added test for error CS0626 (MONO reports error for this situation).
2579 (IMethodData.GetSignatureForError): Extended interface.
2581 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2584 (AttributeTester.GetObsoleteAttribute): Returns instance of
2585 ObsoleteAttribute when type is obsolete.
2588 (TypeContainer.VerifyObsoleteAttribute): Override.
2589 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2590 (MethodCode.VerifyObsoleteAttribute): Override.
2591 (MemberBase.VerifyObsoleteAttribute): Override.
2594 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2595 and report proper error.
2598 Delegate.VerifyObsoleteAttribute): Override.
2601 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2602 and report proper error.
2603 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2606 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2610 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2611 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2612 Added test for ObsoleteAttribute.
2615 (Catch): Derived from Statement.
2617 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2619 Fixed bug #59071 & cs0160.cs
2621 * statement.cs (Try.Resolve): Check here whether order of catch
2622 clauses matches their dependencies.
2624 2004-05-31 Miguel de Icaza <miguel@ximian.com>
2626 * Reverted patch to namespace.cs (Use lookuptypedirect). This
2627 caused a regression: #59343. Referencing nested classes from an
2628 assembly stopped working.
2630 2004-05-31 Martin Baulig <martin@ximian.com>
2632 MCS is now frozen for beta 2.
2634 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2636 * convert.cs: add a trivial cache for overload operator resolution.
2638 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2640 * decl.cs: If possible, use lookuptypedirect here. We can only do
2641 this if there is no `.' after the namespace. Avoids using
2642 LookupType, which does lots of slow processing.
2643 (FindNestedType) New method, does what it says :-).
2644 * namespace.cs: use LookupTypeDirect.
2645 * rootcontext.cs: use membercache, if possible.
2646 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2648 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2651 According to the spec,
2653 In a member access of the form E.I, if E is a single identifier,
2654 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2655 field, property, localvariable, or parameter with the same type as
2656 the meaning of E as a type-name (§3.8), then both possible
2657 meanings of E are permitted.
2659 We did not check that E as a simple-name had the same type as E as
2662 This trivial check gives us 5-7% on bootstrap time.
2664 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2666 * expression.cs (Invocation.OverloadResolve): Avoid the
2667 use of hashtables and boxing here by allocating on demand.
2669 2004-05-30 Martin Baulig <martin@ximian.com>
2671 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2672 we're doing a silent lookup. Don't try to lookup nested types in
2673 TypeManager.object_type (thanks to Ben Maurer).
2675 2004-05-30 Martin Baulig <martin@ximian.com>
2677 Committing a patch from Ben Maurer.
2679 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2681 2004-05-29 Martin Baulig <martin@ximian.com>
2683 * class.cs (IMethodData.ShouldIgnore): New method.
2685 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2686 `Location' argument, we don't need it anywhere. Use
2687 `IMethodData.ShouldIgnore ()' instead of
2688 `MethodData.GetMethodFlags ()'.
2689 (TypeManager.AddMethod): Removed.
2690 (TypeManager.AddMethod2): Renamed to AddMethod.
2692 2004-05-29 Martin Baulig <martin@ximian.com>
2694 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2696 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2697 converting from a class type S to an interface type and we already
2698 have an object on the stack, don't box it again. Fixes #52578.
2700 2004-05-29 Martin Baulig <martin@ximian.com>
2702 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2703 Added support for `params' parameters. Fixes #59267.
2705 2004-05-29 Martin Baulig <martin@ximian.com>
2707 * literal.cs (NullPointer): Provide a private .ctor which sets
2708 `type' to TypeManager.object_type. Fixes #59048.
2710 2004-05-29 Martin Baulig <martin@ximian.com>
2712 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2713 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2715 * ecore.cs (EventExpr.instance_expr): Make the field private.
2717 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2719 Fixed bug #50080 & cs0214-2.cs
2720 * expression.cs (Cast.DoResolve): Check unsafe context here.
2722 * statement.cs (Resolve.DoResolve): Likewise.
2724 2004-05-26 Martin Baulig <martin@ximian.com>
2726 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2728 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2729 (RootContext.LookupType): Pass down the `silent' flag.
2731 2004-05-25 Martin Baulig <martin@ximian.com>
2734 (MethodGroupExpr.IdenticalTypeName): New public property.
2735 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2736 expression actually refers to a type.
2738 2004-05-25 Martin Baulig <martin@ximian.com>
2740 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2741 for #56176 and made it actually work.
2743 2004-05-25 Martin Baulig <martin@ximian.com>
2745 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2746 (FieldExpr, PropertyExpr): Override and implement
2747 CacheTemporaries. Fixes #52279.
2749 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2751 * location.cs: In the new compiler listing a file twice is a
2752 warning, not an error.
2754 2004-05-24 Martin Baulig <martin@ximian.com>
2756 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2757 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2759 2004-05-24 Martin Baulig <martin@ximian.com>
2761 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2762 walking the `using' list. Fixes #53921.
2764 2004-05-24 Martin Baulig <martin@ximian.com>
2766 * const.cs (Const.LookupConstantValue): Added support for
2767 EmptyCast's; fixes #55251.
2769 2004-05-24 Martin Baulig <martin@ximian.com>
2771 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2772 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2773 which does the CS0135 check. The reason is that we first need to
2774 check whether the variable actually exists.
2776 2004-05-24 Martin Baulig <martin@ximian.com>
2778 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2779 than RootContext.LookupType() to find the explicit interface
2782 2004-05-24 Raja R Harinath <rharinath@novell.com>
2784 * Makefile: Simplify. Use executable.make.
2785 * mcs.exe.sources: New file. List of sources of mcs.exe.
2787 2004-05-24 Anders Carlsson <andersca@gnome.org>
2791 Use the invariant culture when doing String.Compare for CLS case
2794 2004-05-23 Martin Baulig <martin@ximian.com>
2796 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2797 don't have any dots. Fixes #52622, added cs0246-8.cs.
2799 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2801 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2803 * class.cs (MemberBase.Define): Reuse MemberType member for
2804 resolved type. Other methods can use it too.
2806 2004-05-23 Martin Baulig <martin@ximian.com>
2808 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2809 the variable also exists in the current block (otherwise, we need
2810 to report a CS0103). Fixes #58670.
2812 2004-05-23 Martin Baulig <martin@ximian.com>
2814 * flowanalysis.cs (Reachability.Reachable): Compute this
2815 on-the-fly rather than storing it as a field.
2817 2004-05-23 Martin Baulig <martin@ximian.com>
2819 * flowanalysis.cs (Reachability.And): Manually compute the
2820 resulting `barrier' from the reachability.
2822 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2825 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2826 instance of ObsoleteAttribute when symbol is obsolete.
2829 (IMethodData): Extended interface for ObsoleteAttribute support.
2831 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2833 * attribute.cs: Fix bug #55970
2835 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2839 (GetObsoleteAttribute): New method. Creates the instance of
2841 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2842 ObsoleteAttribute when member is obsolete.
2843 (AttributeTester.Report_ObsoleteMessage): Common method for
2844 Obsolete error/warning reporting.
2847 (TypeContainer.base_classs_type): New member for storing parent type.
2850 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2851 for this MemberCore.
2853 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2855 * attribute.cs, const.cs: Fix bug #58590
2857 2004-05-21 Martin Baulig <martin@ximian.com>
2859 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2860 out parameters if the end of the method is unreachable. Fixes
2863 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2865 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2866 Hari was right, why extra method.
2868 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2870 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2872 2004-05-20 Martin Baulig <martin@ximian.com>
2874 Merged this back from gmcs to keep the differences to a minumum.
2876 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
2877 instead of a Declspace.
2878 (Attribute.ResolveType): Likewise.
2879 (Attributes.Search): Likewise.
2880 (Attributes.Contains): Likewise.
2881 (Attributes.GetClsCompliantAttribute): Likewise.
2883 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
2885 (MethodData.ApplyAttributes): Take an EmitContext instead of a
2888 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2890 Fix bug #58688 (MCS does not report error when the same attribute
2893 * attribute.cs (Attribute.Emit): Distinction between null and default.
2895 2004-05-19 Raja R Harinath <rharinath@novell.com>
2897 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2898 of a top-level attribute without an attribute target.
2899 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2901 (Attribute.Conditional_GetConditionName),
2902 (Attribute.Obsolete_GetObsoleteMessage): Update.
2903 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2904 part of ScanForIndexerName.
2905 (Attribute.CanIgnoreInvalidAttribute): New function.
2906 (Attribute.ScanForIndexerName): Move to ...
2907 (Attributes.ScanForIndexerName): ... here.
2908 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2909 (Attributes.Search): New internal variant that can choose not to
2910 complain if types aren't resolved. The original signature now
2912 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2913 complaints suppressed.
2914 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2915 only if it not useful.
2916 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2917 top-level for attributes that are shared between the assembly
2918 and a top-level class.
2919 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2920 * class.cs: Update to reflect changes.
2921 (DefineIndexers): Fuse loops.
2922 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2923 a couple more variants of attribute names.
2925 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2927 Fix bug #52585 (Implemented explicit attribute declaration)
2930 (Attributable.ValidAttributeTargets): New abstract method. It gets
2931 list of valid attribute targets for explicit target declaration.
2932 (Attribute.Target): It holds target itself.
2933 (AttributeSection): Removed.
2934 (Attribute.CheckTargets): New method. It checks whether attribute
2935 target is valid for the current element.
2938 (EventProperty): New class. For events that are declared like
2939 property (with add and remove accessors).
2940 (EventField): New class. For events that are declared like field.
2943 * cs-parser.jay: Implemented explicit attribute target declaration.
2945 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2946 Override ValidAttributeTargets.
2949 (ReturnParameter): Class for applying custom attributes on
2951 (ParameterAtribute): New class. Class for applying custom
2952 attributes on the parameter type.
2954 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2956 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
2959 (Method): Allow UNSAFE here.
2961 * modifiers.cs: Support unsafe reporting.
2963 2004-05-17 Marek Safar <marek.safar@seznam.cz>
2965 * decl.cs: Fix bug #58478.
2967 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
2969 * statement.cs: When checking for unreachable code on an EmptyStatement,
2970 set the location. Fixes bug #58488.
2972 2004-05-13 Miguel de Icaza <miguel@ximian.com>
2974 * driver.cs: Add -pkg handling.
2976 From Gonzalo: UseShelLExecute=false
2978 2004-05-12 Marek Safar <marek.safar@seznam.cz>
2981 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
2983 (Attribute.IsClsCompliaceRequired): Moved to base for better
2985 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
2986 when attribute is AttributeUsageAttribute.
2987 (Attribute.GetValidTargets): Simplified.
2988 (Attribute.GetAttributeUsage): New method returns AttributeUsage
2989 attribute for this type.
2990 (Attribute.ApplyAttributes): Method renamed to Emit and make
2992 (GlobalAttributeSection): New class for special handling of global
2993 attributes (assembly, module).
2994 (AttributeSection.Emit): New method.
2996 * class.cs: Implemented Attributable abstract methods.
2997 (MethodCore.LabelParameters): Moved to Parameter class.
2998 (Accessor): Is back simple class.
2999 (PropertyMethod): Implemented Attributable abstract class.
3000 (DelegateMethod): Implemented Attributable abstract class.
3001 (Event): New constructor for disctintion between normal Event
3002 and Event with accessors.
3004 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3006 * codegen.cs, const.cs, decl.cs, delegate.cs:
3007 (CommonAssemblyModulClass): Implemented Attributable abstract class
3010 * enum.cs: Implement IAttributeSupport interface.
3011 (EnumMember): New class for emum members. Implemented Attributable
3015 (ParameterBase): Is abstract.
3016 (ReturnParameter): New class for easier [return:] attribute handling.
3018 * typemanager.cs: Removed builder_to_attr.
3020 2004-05-11 Raja R Harinath <rharinath@novell.com>
3023 * attribute.cs (Attribute.GetPositionalValue): New function.
3024 * class.cs (TypeContainer.VerifyMembers): New function.
3025 (TypeContainer.Emit): Use it.
3026 (ClassOrStruct): New base class for Class and Struct.
3027 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3028 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3030 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3031 then each non-static field should have a FieldOffset attribute.
3032 Otherwise, none of the fields should have a FieldOffset attribute.
3033 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3034 and FieldOffset attributes.
3035 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3036 (TypeManager.field_offset_attribute_type): New core types.
3037 (TypeManager.InitCoreTypes): Initialize them.
3039 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3041 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3042 Return correct type.
3045 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3047 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3048 be implicitly converted to ulong.
3050 * expression.cs: The logic for allowing operator &, | and ^ worked
3051 was wrong, it worked before because we did not report an error in
3052 an else branch. Fixes 57895.
3054 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3055 allow volatile fields to be reference types.
3057 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3059 * driver.cs: Add support for /debug-
3061 2004-05-07 Raja R Harinath <rharinath@novell.com>
3063 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3064 Add a 'complain' parameter to silence errors.
3065 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3066 silently overlooked type-resolutions.
3067 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3069 (Attributes.Search): New function.
3070 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3071 (Attributes.GetAttributeFullName): Remove hack.
3072 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3073 Update to reflect changes.
3074 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3075 Use Attributes.Search instead of nested loops.
3077 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3080 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3081 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3082 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3084 * report.cs: (Report.Warning): Renamed to Warning_T because of
3085 parameter collision.
3087 2004-05-05 Raja R Harinath <rharinath@novell.com>
3089 * expression.cs (MemberAccess.ResolveMemberAccess):
3090 Exit with non-zero status after Report.Error.
3091 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3093 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3095 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3097 * support.cs: Don't hang when the file is empty.
3099 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3101 * support.cs: In SeekableStreamReader, compute the preamble size of the
3102 underlying stream. Position changes should take into account that initial
3105 2004-05-03 Todd Berman <tberman@sevenl.net>
3107 * driver.cs: remove unused GetSysVersion function.
3109 2004-05-03 Todd Berman <tberman@sevenl.net>
3111 * driver.cs: Remove the hack from saturday, as well as the hack
3112 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3113 link_paths to get that bit proper.
3115 2004-05-01 Todd Berman <tberman@sevenl.net>
3117 * driver.cs: Try a LoadFrom before a Load, this checks the current
3118 path. This is currently a bug in mono that is be fixed, however, this
3119 provides a workaround for now. This will be removed when the bug
3122 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3124 * CryptoConvert.cs: Updated to latest version. Fix issue with
3125 incomplete key pairs (#57941).
3127 2004-05-01 Todd Berman <tberman@sevenl.net>
3129 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3132 2004-04-30 Jackson Harper <jackson@ximian.com>
3134 * codegen.cs: Open keys readonly.
3136 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3138 * typemanager.cs: don't report cyclic struct layout when a struct
3139 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3140 which has 2 Pango.Rectangle fields.
3142 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3144 * expression.cs: Handle IntPtr comparisons with IL code
3145 rather than a method call.
3147 2004-04-29 Martin Baulig <martin@ximian.com>
3149 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3150 the list of PropertyInfo's in class hierarchy and find the
3151 accessor. Fixes #56013.
3153 2004-04-29 Martin Baulig <martin@ximian.com>
3155 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3157 2004-04-29 Martin Baulig <martin@ximian.com>
3159 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3161 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3163 2004-04-29 Martin Baulig <martin@ximian.com>
3165 * class.cs (ConstructorInitializer.Resolve): Check whether the
3166 parent .ctor is accessible. Fixes #52146.
3168 2004-04-29 Martin Baulig <martin@ximian.com>
3170 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3172 * statement.cs (Using.EmitLocalVariableDecls): Use
3173 TypeManager.idisposable_type, not typeof (IDisposable).
3174 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3176 2004-04-29 Martin Baulig <martin@ximian.com>
3178 * class.cs (Event.Define): Don't emit the field and don't set
3179 RTSpecialName and SpecialName for events on interfaces. Fixes
3182 2004-04-29 Raja R Harinath <rharinath@novell.com>
3184 Refactor Attribute.ApplyAttributes.
3185 * attribute.cs (Attributable): New base class for objects that can
3186 have Attributes applied on them.
3187 (Attribute): Make AttributeUsage fields public.
3188 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3189 (Attribute.IsInternalCall): New property.
3190 (Attribute.UsageAttr): Convert to a public read-only property.
3191 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3192 (Attribute.ResolveType, Attribute.Resolve)
3193 (Attribute.ScanForIndexerName): Update to reflect changes.
3194 (Attribute.CheckAttributeTarget): Re-format.
3195 (Attribute.ApplyAttributes): Refactor, to various
3196 Attributable.ApplyAttributeBuilder methods.
3197 * decl.cs (MemberCore): Make Attributable.
3198 * class.cs (Accessor): Make Attributable.
3199 (MethodData.ApplyAttributes): Use proper attribute types, not
3201 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3202 (TypeContainer.ApplyAttributeBuilder)
3203 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3204 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3205 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3206 (Operator.ApplyAttributeBuilder): New factored-out methods.
3207 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3208 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3209 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3210 * parameter.cs (ParameterBase): New Attributable base class
3211 that can also represent Return types.
3212 (Parameter): Update to the changes.
3214 2004-04-29 Jackson Harper <jackson@ximian.com>
3216 * driver.cs: Prefer the corlib system version when looking for
3217 assemblies in the GAC. This is still a hack, but its a better hack
3220 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3222 * decl.cs, enum.cs: Improved error 3005 reporting.
3224 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3225 (related_symbols): New private member for list of symbols
3226 related to reported error/warning.
3228 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3230 2004-04-29 Martin Baulig <martin@ximian.com>
3232 * ecore.cs (Expression.Constantify): If we're an enum and
3233 TypeManager.TypeToCoreType() doesn't give us another type, use
3234 t.UnderlyingSystemType. Fixes #56178.
3236 2004-04-29 Martin Baulig <martin@ximian.com>
3238 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3239 interfaces and for each interface, only add members directly
3240 declared in that interface. Fixes #53255.
3242 2004-04-28 Martin Baulig <martin@ximian.com>
3244 * expression.cs (ConditionalLogicalOperator): Use a temporary
3245 variable for `left' to avoid that we evaluate it more than once;
3248 2004-04-28 Martin Baulig <martin@ximian.com>
3250 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3253 2004-04-28 Martin Baulig <martin@ximian.com>
3255 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3258 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3259 whether the type is not void (CS1547).
3261 2004-04-28 Martin Baulig <martin@ximian.com>
3263 * expression.cs (Unary.DoResolveLValue): Override this and report
3264 CS0131 for anything but Operator.Indirection.
3266 2004-04-28 Martin Baulig <martin@ximian.com>
3268 Committing a patch from Ben Maurer; see bug #50820.
3270 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3273 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3276 2004-04-28 Martin Baulig <martin@ximian.com>
3278 Committing a patch from Ben Maurer; see bug #50820.
3280 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3283 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3286 2004-04-28 Martin Baulig <martin@ximian.com>
3288 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3289 (Block.AddLabel): Call DoLookupLabel() to only search in the
3292 2004-04-28 Martin Baulig <martin@ximian.com>
3294 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3295 comparing StringConstants and NullLiterals in Equality and Inequality.
3297 2004-04-28 Jackson Harper <jackson@ximian.com>
3299 * driver.cs: Attempt to load referenced assemblies from the
3300 GAC. This is the quick and dirty version of this method that
3301 doesnt take into account versions and just takes the first
3302 canidate found. Will be good enough for now as we will not have more
3303 then one version installed into the GAC until I update this method.
3305 2004-04-28 Martin Baulig <martin@ximian.com>
3307 * typemanager.cs (TypeManager.CheckStructCycles): New public
3308 static method to check for cycles in the struct layout.
3310 * rootcontext.cs (RootContext.PopulateTypes): Call
3311 TypeManager.CheckStructCycles() for each TypeContainer.
3312 [Note: We only need to visit each type once.]
3314 2004-04-28 Martin Baulig <martin@ximian.com>
3316 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3318 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3319 success and added `out object value'. Use a `bool resolved' field
3320 to check whether we've already been called rather than
3321 `ConstantValue != null' since this breaks for NullLiterals.
3323 2004-04-28 Raja R Harinath <rharinath@novell.com>
3325 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3326 setting of this flag, since the 'set' method may be non-public.
3328 2004-04-28 Raja R Harinath <rharinath@novell.com>
3330 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3331 check on current_vector.Block.
3333 2004-04-27 Martin Baulig <martin@ximian.com>
3335 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3336 a field initializer. Fixes #56459.
3338 2004-04-27 Martin Baulig <martin@ximian.com>
3340 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3341 we're not attempting to use an indexer. Fixes #52154.
3343 2004-04-27 Martin Baulig <martin@ximian.com>
3345 * statement.cs (Return): Don't create a return label if we don't
3346 need it; reverts my change from January 20th. Thanks to Ben
3349 2004-04-27 Martin Baulig <martin@ximian.com>
3351 According to the spec, `goto' can only leave a nested scope, but
3354 * statement.cs (Block.LookupLabel): Only lookup in the current
3355 block, don't recurse into parent or child blocks.
3356 (Block.AddLabel): Check in parent and child blocks, report
3357 CS0140/CS0158 if we find a duplicate.
3358 (Block): Removed this indexer for label lookups.
3359 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3360 this already does the error reporting for us.
3363 (FlowBranching.UsageVector.Block): New public variable; may be null.
3364 (FlowBranching.CreateSibling): Added `Block' argument.
3365 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3366 label for the target of a `goto' and check whether we're not
3367 leaving a `finally'.
3369 2004-04-27 Martin Baulig <martin@ximian.com>
3371 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3372 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3375 2004-04-27 Martin Baulig <martin@ximian.com>
3377 * statement.cs (Block.AddLabel): Also check for implicit blocks
3378 and added a CS0158 check.
3380 2004-04-27 Martin Baulig <martin@ximian.com>
3382 * flowanalysis.cs (FlowBranchingLoop): New class.
3383 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3384 UsageVector's instead of an ArrayList.
3385 (FlowBranching.Label): Likewise.
3386 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3387 (FlowBranching.AddBreakVector): New method.
3389 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3391 * attribute.cs: Small regression fix: only convert the type if we
3392 the type is different, fixes System.Drawing build.
3394 2004-04-27 Martin Baulig <martin@ximian.com>
3396 * attribute.cs (Attribute.Resolve): If we have a constant value
3397 for a named field or property, implicity convert it to the correct
3400 2004-04-27 Raja R Harinath <rharinath@novell.com>
3402 * statement.cs (Block.Block): Implicit blocks share
3403 'child_variable_names' fields with parent blocks.
3404 (Block.AddChildVariableNames): Remove.
3405 (Block.AddVariable): Mark variable as "used by a child block" in
3406 every surrounding block.
3407 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3408 been used in a child block, complain about violation of "Invariant
3409 meaning in blocks" rule.
3410 * cs-parser.jay (declare_local_variables): Don't use
3411 AddChildVariableNames.
3412 (foreach_statement): Don't create an implicit block: 'foreach'
3415 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3417 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3418 converting from 0L to ulong. Fixes 57522.
3420 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3422 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3423 derived class hides via 'new' keyword field from base class (test-242.cs).
3424 TODO: Handle this in the more general way.
3426 * class.cs (CheckBase): Ditto.
3428 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3430 * decl.cs (caching_flags): New member for storing cached values
3432 (MemberCore.Flags): New enum where bit flags for caching_flags
3434 (MemberCore.cls_compliance): Moved to caching_flags.
3435 (DeclSpace.Created): Moved to caching_flags.
3437 * class.cs: Use caching_flags instead of DeclSpace.Created
3439 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3441 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3442 if we are only a derived class, not a nested class.
3444 * typemanager.cs: Same as above, but do this at the MemberLookup
3445 level (used by field and methods, properties are handled in
3446 PropertyExpr). Allow for the qualified access if we are a nested
3449 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3451 * class.cs: Refactoring.
3452 (IMethodData): New inteface; Holds links to parent members
3453 to avoid member duplication (reduced memory allocation).
3454 (Method): Implemented IMethodData interface.
3455 (PropertyBase): New inner classes for get/set methods.
3456 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3457 (Event): New inner classes for add/remove methods.
3458 (Event.DelegateMethod): Implemented IMethodData interface.
3460 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3461 EmitContext (related to class.cs refactoring).
3463 2004-04-21 Raja R Harinath <rharinath@novell.com>
3465 * delegate.cs (Delegate.VerifyApplicability): If the number of
3466 arguments are the same as the number of parameters, first try to
3467 verify applicability ignoring any 'params' modifier on the last
3471 2004-04-16 Raja R Harinath <rharinath@novell.com>
3473 * class.cs (TypeContainer.AddIndexer): Use
3474 'ExplicitInterfaceName' to determine if interface name was
3475 explicitly specified. 'InterfaceType' is not initialized at this time.
3476 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3477 Indexers array is already in the required order. Initialize
3478 'IndexerName' only if there are normal indexers.
3479 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3480 (TypeContainer.Emit): Emit DefaultMember attribute only if
3481 IndexerName is initialized.
3484 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3486 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3489 2004-04-15 Raja R Harinath <rharinath@novell.com>
3491 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3495 * attribute.cs (Attribute.Resolve): Check for duplicate named
3499 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3501 * iterators.cs (MarkYield): track whether we are in an exception,
3502 and generate code accordingly. Use a temporary value to store the
3503 result for our state.
3505 I had ignored a bit the interaction of try/catch with iterators
3506 since their behavior was not entirely obvious, but now it is
3507 possible to verify that our behavior is the same as MS .NET 2.0
3511 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3513 * iterators.cs: Avoid creating temporaries if there is no work to
3516 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3517 Enumerations, use TypeManager.EnumToUnderlying and call
3520 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3523 (This.Emit): Use EmitContext.EmitThis to emit our
3526 (This.EmitAssign): Ditto.
3528 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3529 codepaths, we will move all the functionality into
3532 (FieldExpr.EmitAssign): Ditto.
3534 This fixes several hidden bugs that I uncovered while doing a code
3535 review of this today.
3537 * codegen.cs (EmitThis): reworked so the semantics are more clear
3538 and also support value types "this" instances.
3540 * iterators.cs: Changed so that for iterators in value types, we
3541 do not pass the value type as a parameter.
3543 Initialization of the enumerator helpers is now done in the caller
3544 instead of passing the parameters to the constructors and having
3545 the constructor set the fields.
3547 The fields have now `assembly' visibility instead of private.
3549 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3551 * expression.cs (Argument.Resolve): Check if fields passed as ref
3552 or out are contained in a MarshalByRefObject.
3554 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3555 another compiler type.
3557 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3559 * class.cs (Indexer.Define): use the new name checking method.
3560 Also, return false on an error.
3561 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3562 (is_identifier_[start/part]_character): make static.
3564 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3566 * expression.cs (Binary.ResolveOperator): Do no append strings
3567 twice: since we can be invoked more than once (array evaluation)
3568 on the same concatenation, take care of this here. Based on a fix
3569 from Ben (bug #56454)
3571 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3573 * codegen.cs: Fix another case where CS1548 must be reported (when
3574 delay-sign isn't specified and no private is available #56564). Fix
3575 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3576 error when MCS is used on the MS runtime and we need to delay-sign
3577 (which seems unsupported by AssemblyBuilder - see #56621).
3579 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3581 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3582 (TypeManager.ComputeNamespaces): Faster implementation for
3585 * compiler.csproj: Updated AssemblyName to mcs.
3587 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3589 * rootcontext.cs: Add new types to the boot resolution.
3591 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3592 MulticastDelegate is not allowed.
3594 * typemanager.cs: Add new types to lookup: System.TypedReference
3597 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3598 check for TypedReference or ArgIterator, they are not allowed.
3600 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3601 makes us properly catch 1510 in some conditions (see bug 56016 for
3604 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3606 * CryptoConvert.cs: update from corlib version
3609 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3611 * class.cs (Indexer.Define): Check indexername declaration
3613 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3615 * attribute.cs (IsClsCompliant): Fixed problem with handling
3616 all three states (compliant, not-compliant, undetected).
3618 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3620 * attribute.cs (Attribute): Location is now public.
3621 (Resolve): Store resolved arguments (pos_values) in attribute class.
3622 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3623 (GetClsCompliantAttributeValue): New method that gets
3624 CLSCompliantAttribute value.
3625 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3626 if exists else null.
3627 (AttributeTester): New class for CLS-Compliant verification routines.
3629 * class.cs (Emit): Add CLS-Compliant verification.
3630 (Method.GetSignatureForError): Implemented.
3631 (Constructor.GetSignatureForError): Implemented
3632 (Constructor.HasCompliantArgs): Returns if constructor has
3633 CLS-Compliant arguments.
3634 (Constructor.Emit): Override.
3635 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3636 is needed to test only parameters.
3637 (FieldBase.GetSignatureForError): Implemented.
3638 (TypeContainer): New member for storing base interfaces.
3639 (TypeContainer.FindMembers): Search in base interfaces too.
3641 * codegen.cs (GetClsComplianceAttribute): New method that gets
3642 assembly or module CLSCompliantAttribute value.
3643 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3645 (ModuleClass.Emit): Add error 3012 test.
3647 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3649 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3650 state for all decl types.
3651 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3652 if CLS-Compliant tests are required.
3653 (IsClsCompliaceRequired): New method. Analyze whether code
3654 must be CLS-Compliant.
3655 (IsExposedFromAssembly): New method. Returns true when MemberCore
3656 is exposed from assembly.
3657 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3658 value or gets cached value.
3659 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3660 is explicitly marked with CLSCompliantAttribute.
3661 (IsIdentifierClsCompliant): New abstract method. This method is
3662 used to testing error 3005.
3663 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3664 for identifier and parameters CLS-Compliant testing.
3665 (VerifyClsCompliance): New method. The main virtual method for
3666 CLS-Compliant verifications.
3667 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3668 null. I don't know why is null (too many public members !).
3669 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3670 and get value of first CLSCompliantAttribute that found.
3672 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3673 (VerifyClsCompliance): Override and add extra tests.
3675 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3676 clscheck- disable CLS-Compliant verification event if assembly is has
3677 CLSCompliantAttribute(true).
3679 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3680 ApllyAttribute is now called in emit section as in the other cases.
3681 Possible future Emit integration.
3682 (IsIdentifierClsCompliant): New override.
3683 (VerifyClsCompliance): New override.
3684 (GetEnumeratorName): Returns full enum name.
3686 * parameter.cs (GetSignatureForError): Implemented.
3688 * report.cs (WarningData): New struct for Warning message information.
3689 (LocationOfPreviousError): New method.
3690 (Warning): New method. Reports warning based on the warning table.
3691 (Error_T): New method. Reports error based on the error table.
3693 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3694 verifications are done here.
3696 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3698 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3699 CLSCompliantAttribute.
3700 (all_imported_types): New member holds all imported types from other
3702 (LoadAllImportedTypes): New method fills static table with exported types
3703 from all referenced assemblies.
3704 (Modules): New property returns all assembly modules.
3706 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3708 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3709 throwing a parser error.
3711 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3712 which removes the hardcoded get_/set_ prefixes for properties, as
3713 IL allows for the properties to be named something else.
3717 * expression.cs: Do not override operand before we know if it is
3720 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3722 * typemanager.cs: support for pinned variables.
3724 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3726 * decl.cs, typemanager.cs: Avoid using an arraylist
3727 as a buffer if there is only one result set.
3729 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3731 * expression.cs: Make sure you cant call a static method
3732 with an instance expression, bug #56174.
3734 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3736 * class.cs (IsDuplicateImplementation): Improve error reporting to
3737 flag 663 (method only differs in parameter modifier).
3739 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3740 in preprocessor directives.
3742 * location.cs (LookupFile): Allow for the empty path.
3744 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3745 better approach for some of that patch, but its failing with the
3746 CharSet enumeration. For now try/catch will do.
3748 * typemanager.cs: Do not crash if a struct does not have fields.
3751 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3753 * expression.cs: cs0213, cant fix a fixed expression.
3756 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3758 * cs-parser.jay: detect invalid embeded statements gracefully.
3761 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3763 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3766 the invocation type may not be a subclass of the tye of the item/
3767 The type of the item must be a subclass of the invocation item.
3772 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3774 * attribute.cs: Added methods to get a string and a bool from an
3775 attribute. Required to information from AssemblyKeyFileAttribute,
3776 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3777 * codegen.cs: Modified AssemblyName creation to include support for
3778 strongnames. Catch additional exceptions to report them as CS1548.
3779 * compiler.csproj: Updated include CryptoConvert.cs.
3780 * compiler.csproj.user: Removed file - user specific configuration.
3781 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3782 Mono.Security assembly. The original class is maintained and tested in
3783 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3784 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3785 like CSC 8.0 (C# v2) supports.
3786 * Makefile: Added CryptoConvert.cs to mcs sources.
3787 * rootcontext.cs: Added new options for strongnames.
3789 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
3791 * driver.cs: For --expect-error, report error code `2'
3792 if the program compiled with no errors, error code `1' if
3793 it compiled with an error other than the one expected.
3795 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
3797 * compiler.csproj: Updated for Visual Studio .NET 2003.
3798 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
3799 * compiler.sln: Updated for Visual Studio .NET 2003.
3801 2004-03-24 Ravi Pratap M <ravi@ximian.com>
3803 * expression.cs: Fix bug #47234. We basically need to apply the
3804 rule that we prefer the conversion of null to a reference type
3805 when faced with a conversion to 'object' (csc behaviour).
3807 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3809 * statement.cs: Shorter form for foreach, eliminates
3810 a local variable. r=Martin.
3812 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3814 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
3815 checks if we can use brtrue/brfalse to test for 0.
3816 * expression.cs: use the above in the test for using brtrue/brfalse.
3819 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3821 * expression.cs: Rewrite string concat stuff. Benefits:
3823 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
3824 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
3825 rather than a concat chain.
3827 * typemanager.cs: Add lookups for more concat overloads.
3829 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3831 * expression.cs: Emit shorter il code for array init.
3848 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
3850 * statement.cs: Before, two switch blocks would be merged if the
3851 total size of the blocks (end_item - begin_item + 1) was less than
3852 two times the combined sizes of the blocks.
3854 Now, it will only merge if after the merge at least half of the
3859 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
3861 * class.cs : csc build fix for GetMethods(). See bug #52503.
3863 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
3865 * expression.cs: Make sure fp comparisons work with NaN.
3866 This fixes bug #54303. Mig approved this patch a long
3867 time ago, but we were not able to test b/c the runtime
3870 2004-03-19 Miguel de Icaza <miguel@ximian.com>
3872 * ecore.cs (TypExpr.GetHashCode): implement this overload.
3874 2004-03-19 Martin Baulig <martin@ximian.com>
3876 * class.cs (MemberCore.IsDuplicateImplementation): Report the
3877 error here and not in our caller.
3879 2004-03-19 Martin Baulig <martin@ximian.com>
3881 * interface.cs: Completely killed this file.
3882 (Interface): We're now a TypeContainer and live in class.cs.
3884 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
3885 argument; we're now also called for interfaces.
3886 (TypeContainer.DefineMembers): Allow this method being called
3888 (TypeContainer.GetMethods): New public method; formerly known as
3889 Interface.GetMethod(). This is used by PendingImplementation.
3890 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
3891 it's now private and non-static.
3892 (Interface): Moved this here; it's now implemented similar to
3894 (Method, Property, Event, Indexer): Added `bool is_interface'
3895 argument to their .ctor's.
3896 (MemberBase.IsInterface): New public field.
3898 * cs-parser.jay: Create normal Method, Property, Event, Indexer
3899 instances instead of InterfaceMethod, InterfaceProperty, etc.
3900 (opt_interface_base): Removed; we now use `opt_class_base' instead.
3901 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
3903 2004-03-19 Martin Baulig <martin@ximian.com>
3905 * class.cs (MethodCore.IsDuplicateImplementation): New private
3906 method which does the CS0111 checking.
3907 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
3908 Use IsDuplicateImplementation().
3910 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
3912 * decl.cs (FindMemberToOverride): New method to find the correct
3913 method or property to override in the base class.
3915 - Make Method/Property use the above method to find the
3916 version in the base class.
3917 - Remove the InheritableMemberSignatureCompare as it is now
3920 This patch makes large code bases much faster to compile, as it is
3921 O(n) rather than O(n^2) to do this validation.
3923 Also, it fixes bug 52458 which is that nested classes are not
3924 taken into account when finding the base class member.
3926 Reviewed/Approved by Martin.
3928 2004-03-17 Marek Safar <marek.safar@seznam.cz>
3930 * interface.cs: In all interface classes removed redundant
3931 member initialization.
3933 2004-03-16 Martin Baulig <martin@ximian.com>
3935 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
3937 2004-03-15 Miguel de Icaza <miguel@ximian.com>
3939 * decl.cs (DefineTypeAndParents): New helper method to define a
3940 type's containers before the type itself is defined; This is a
3941 bug exposed by the recent changes to Windows.Forms when an
3942 implemented interface was defined inside a class that had not been
3945 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
3947 (Check): Loop correctly to report errors modifiers
3948 (UNSAFE was not in the loop, since it was the same as TOP).
3950 * interface.cs: Every interface member now takes a ModFlags,
3951 instead of a "is_new" bool, which we set on the base MemberCore.
3953 Every place where we called "UnsafeOk" in the interface, now we
3954 call the proper member (InterfaceMethod.UnsafeOK) instead to get
3955 the unsafe settings from the member declaration instead of the
3956 container interface.
3958 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
3960 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
3961 `set_indexer_name' to the pending bits (one per type).
3963 We fixed a bug today that was picking the wrong method to
3964 override, since for properties the existing InterfaceMethod code
3965 basically ignored the method name. Now we make sure that the
3966 method name is one of the valid indexer names.
3968 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
3970 * support.cs (SeekableStreamReader): Keep track of stream byte
3971 positions and don't mix them with character offsets to the buffer.
3973 Patch from Gustavo Giráldez
3975 2004-03-15 Marek Safar <marek.safar@seznam.cz>
3977 * interface.cs (InterfaceSetGetBase): Removed double member
3978 initialization, base class does it as well.
3980 2004-03-13 Martin Baulig <martin@ximian.com>
3982 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
3983 when compiling corlib.
3985 2004-03-13 Miguel de Icaza <miguel@ximian.com>
3987 * convert.cs (ExplicitConversion): We were reporting an error on
3988 certain conversions (object_type source to a value type, when the
3989 expression was `null') before we had a chance to pass it through
3990 the user defined conversions.
3992 * driver.cs: Replace / and \ in resource specifications to dots.
3995 * class.cs: Add check for duplicate operators. Fixes 52477
3997 2004-03-11 Miguel de Icaza <miguel@ximian.com>
3999 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4000 that are in the middle of the statements, not only at the end.
4003 * class.cs (TypeContainer.AddField): No longer set the
4004 `HaveStaticConstructor' flag, now we call it
4005 `UserDefineStaticConstructor' to diferentiate the slightly
4006 semantic difference.
4008 The situation is that we were not adding BeforeFieldInit (from
4009 Modifiers.TypeAttr) to classes that could have it.
4010 BeforeFieldInit should be set to classes that have no static
4015 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4017 And most importantly Zoltan's comment:
4019 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4021 "I think beforefieldinit means 'it's ok to initialize the type sometime
4022 before its static fields are used', i.e. initialization does not need
4023 to be triggered by the first access to the type. Setting this flag
4024 helps the JIT to compile better code, since it can run the static
4025 constructor at JIT time, and does not need to generate code to call it
4026 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4027 this flag for lots of classes like String.
4029 csc sets this flag if the type does not have an explicit static
4030 constructor. The reasoning seems to be that if there are only static
4031 initalizers for a type, and no static constructor, then the programmer
4032 does not care when this initialization happens, so beforefieldinit
4035 This bug prevents the AOT compiler from being usable, since it
4036 generates so many calls to mono_runtime_class_init that the AOT code
4037 is much slower than the JITted code. The JITted code is faster,
4038 because it does not generate these calls if the vtable is type is
4039 already initialized, which is true in the majority of cases. But the
4040 AOT compiler can't do this."
4042 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4044 * class.cs (MethodData.Emit): Refactor the code so symbolic
4045 information is generated for destructors; For some reasons we
4046 were taking a code path that did not generate symbolic information
4049 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4051 * class.cs: Create a Constructor.CheckBase method that
4052 takes care of all validation type code. The method
4053 contains some code that was moved from Define.
4055 It also includes new code that checks for duplicate ctors.
4056 This fixes bug #55148.
4058 2004-03-09 Joshua Tauberer <tauberer@for.net>
4060 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4061 a { ... }-style array creation invokes EmitStaticInitializers
4062 which is not good for reference-type arrays. String, decimal
4063 and now null constants (NullCast) are not counted toward
4064 static initializers.
4066 2004-03-05 Martin Baulig <martin@ximian.com>
4068 * location.cs (SourceFile.HasLineDirective): New public field;
4069 specifies whether the file contains or is referenced by a "#line"
4071 (Location.DefineSymbolDocuments): Ignore source files which
4072 either contain or are referenced by a "#line" directive.
4074 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4076 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4077 direct access to our parent, so check the method inline there.
4079 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4081 * expression.cs (Invocation.EmitCall): Miguel's last commit
4082 caused a regression. If you had:
4087 In Foo the implict this would be null.
4089 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4091 * expression.cs (Invocation.EmitCall): If the method is not
4092 virtual, do not emit a CallVirt to it, use Call.
4094 * typemanager.cs (GetFullNameSignature): Improve the method to
4095 cope with ".ctor" and replace it with the type name.
4097 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4098 as an argument the ConstructorBuilder where it is being defined,
4099 to catch the recursive constructor invocations.
4101 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4103 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4104 routines to check if a type is an enumerable/enumerator allow
4105 classes that implement the IEnumerable or IEnumerator interfaces.
4107 * class.cs (Property, Operator): Implement IIteratorContainer, and
4108 implement SetYields.
4110 (Property.Define): Do the block swapping for get_methods in the
4111 context of iterators. We need to check if Properties also
4112 include indexers or not.
4114 (Operator): Assign the Block before invoking the
4115 OperatorMethod.Define, so we can trigger the Iterator code
4118 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4119 Property and Operator classes are not created when we parse the
4120 declarator but until we have the block completed, so we use a
4121 singleton SimpleIteratorContainer.Simple to flag whether the
4122 SetYields has been invoked.
4124 We propagate this setting then to the Property or the Operator to
4125 allow the `yield' to function.
4127 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4129 * codegen.cs: Implemented attribute support for modules.
4130 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4131 Assembly/Module functionality.
4133 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4134 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4135 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4137 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4139 * interface.cs (FindMembers): The operation is performed on all base
4140 interfaces and not only on the first. It is required for future CLS Compliance patch.
4142 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4144 * statement.cs, codegen.cs:
4145 This patch deals with patterns such as:
4147 public class List : IEnumerable {
4149 public MyEnumerator GetEnumerator () {
4150 return new MyEnumerator(this);
4153 IEnumerator IEnumerable.GetEnumerator () {
4157 public struct MyEnumerator : IEnumerator {
4162 Before, there were a few things we did wrong:
4163 1) we would emit callvirt on a struct, which is illegal
4164 2) we emited ldarg when we needed to emit ldarga
4165 3) we would mistakenly call the interface methods on an enumerator
4166 type that derived from IEnumerator and was in another assembly. For example:
4168 public class MyEnumerator : IEnumerator
4170 Would have the interface methods called, even if there were public impls of the
4171 method. In a struct, this lead to invalid IL code.
4173 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4175 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4178 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4180 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4182 * cs-parser.jay: Fix small regression: we were not testing V2
4183 compiler features correctly.
4185 * interface.cs: If the emit context is null, then create one
4187 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4189 * decl.cs (GetSignatureForError): New virtual method to get full name
4192 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4193 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4195 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4196 Duplicated members and code in these classes has been removed.
4197 Better encapsulation in these classes.
4199 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4201 * assign.cs (Assign.DoResolve): When dealing with compound
4202 assignments, there is a new rule in ECMA C# 2.4 (might have been
4203 there before, but it is documented here) that states that in:
4207 If b is of type int, and the `op' is a shift-operator, then the
4208 above is evaluated as:
4212 * expression.cs (Binary.ResolveOperator): Instead of testing for
4213 int/uint/long/ulong, try to implicitly convert to any of those
4214 types and use that in pointer arithmetic.
4216 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4217 method to print information for from the type, not from the
4218 null-method we were given.
4220 2004-02-01 Duncan Mak <duncan@ximian.com>
4222 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4223 parsing for cmd, fixes bug #53694.
4225 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4227 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4228 in the member name duplication tests. Property and operator name duplication
4229 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4231 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4233 * interface.cs (PopulateMethod): Fixed crash when interface method
4234 returns not existing type (error test cs0246-3.cs).
4236 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4238 * cs-parser.jay (interface_accessors): Re-write actions to also
4239 store attributes attached to get and set methods. Fix spelling
4242 (inteface_property_declaration): Modify accordingly.
4244 (InterfaceAccessorInfo): New helper class to store information to pass
4245 around between rules that use interface_accessors.
4247 * interface.cs (Emit): Apply attributes on the get and set
4248 accessors of properties and indexers too.
4250 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4251 right MethodBuilder when applying attributes to the get and set accessors.
4253 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4255 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4257 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4259 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4261 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4263 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4264 changes that treat `yield' specially when present before `break'
4267 * cs-tokenizer.cs: yield is no longer a keyword.
4269 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4271 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4272 setting for default constructors.
4273 For default constructors are almost every time set wrong Modifier. The
4274 generated IL code has been alright. But inside mcs this values was
4275 wrong and this was reason why several of my CLS Compliance tests
4278 2004-01-22 Martin Baulig <martin@ximian.com>
4280 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4281 not a QualifiedIdentifier. This is what `type_name_expression'
4282 was previously doing.
4283 (type_name_expression): Removed; the code is now in
4284 `namespace_or_type_name'.
4285 (qualified_identifier): Removed, use `namespace_or_type_name'
4287 (QualifiedIdentifier): Removed this class.
4289 2004-01-22 Martin Baulig <martin@ximian.com>
4291 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4292 not a string as alias name.
4294 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4296 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4297 #52730 bug, and instead compute correctly the need to use a
4298 temporary variable when requesting an address based on the
4299 static/instace modified of the field and the constructor.
4301 2004-01-21 Martin Baulig <martin@ximian.com>
4303 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4304 class and namespace before looking up aliases. Fixes #52517.
4306 2004-01-21 Martin Baulig <martin@ximian.com>
4308 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4309 assinged in a 'try'; fixes exception4.cs.
4311 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4312 * class.cs : Implemented parameter-less constructor for TypeContainer
4314 * decl.cs: Attributes are now stored here. New property OptAttributes
4316 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4318 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4320 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4322 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4323 (CSharpSignature): New method for indexer and property signature.
4325 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4327 * pending.cs (IsVirtualFilter): Faster implementation.
4329 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4331 * typemanager.cs: Avoid inclusion of same assembly more than once.
4333 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4335 * cs-parser.jay: Fixed problem where the last assembly attribute
4336 has been applied also to following declaration (class, struct, etc.)
4338 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4340 * class.cs: Added error CS0538, CS0539 reporting.
4341 Fixed crash on Microsoft runtime when field type is void.
4343 * cs-parser.jay: Added error CS0537 reporting.
4345 * pending.cs: Added error CS0535 reporting.
4346 Improved error report for errors CS0536, CS0534.
4348 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4350 Merge a few bits from the Anonymous Method MCS tree.
4352 * statement.cs (ToplevelBlock): New class for toplevel methods,
4353 will hold anonymous methods, lifted variables.
4355 * cs-parser.jay: Create toplevel blocks for delegates and for
4356 regular blocks of code.
4358 2004-01-20 Martin Baulig <martin@ximian.com>
4360 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4361 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4362 and `NeedExplicitReturn'; added `IsLastStatement'.
4363 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4364 have a `ReturnLabel' or we're not unreachable.
4366 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4367 child's reachability; don't just override ours with it. Fixes
4368 #58058 (lluis's example).
4369 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4370 InFinally(), InLoop(), InSwitch() and
4371 BreakCrossesTryCatchBoundary() methods.
4373 * statement.cs (Return): Do all error checking in Resolve().
4374 Unless we are the last statement in a top-level block, always
4375 create a return label and jump to it.
4376 (Break, Continue): Do all error checking in Resolve(); also make
4377 sure we aren't leaving a `finally'.
4378 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4379 statement in a top-level block.
4380 (Block.Flags): Added `IsDestructor'.
4381 (Block.IsDestructor): New public property.
4383 2004-01-20 Martin Baulig <martin@ximian.com>
4385 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4387 2004-01-20 Martin Baulig <martin@ximian.com>
4389 * statement.cs (Statement.ResolveUnreachable): New public method.
4390 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4391 (Block.Resolve): Resolve unreachable statements.
4393 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4395 * expression.cs: We need to fix the case where we do
4396 not have a temp variable here.
4398 * assign.cs: Only expression compound assignments need
4399 temporary variables.
4401 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4403 * flowanalysis.cs: Reduce memory allocation in a few ways:
4404 - A block with no variables should not allocate a bit
4406 - A method with no out parameters does not need any tracking
4407 for assignment of the parameters, so we need not allocate
4410 public readonly Type[] VariableTypes;
4411 public readonly string[] VariableNames;
4412 Are redundant. The data is already stored in the variable
4413 map, so we need not allocate another array for it.
4414 - We need to add alot of checks for if (params | locals) == null
4415 due to the first two changes.
4417 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4419 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4420 implement IMemoryLocation, we store a copy on a local variable and
4421 take the address of it. Patch from Benjamin Jemlich
4423 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4424 to use a special "type_name_expression" rule which reduces the
4425 number of "QualifiedIdentifier" classes created, and instead
4426 directly creates MemberAccess expressions.
4428 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4430 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4431 that fixes #52853. Null literal assignment to ValueType
4433 * class.cs (MethodData.Emit): Instead of checking the name of the
4434 method to determine if its a destructor, create a new derived
4435 class from Method called Destructor, and test for that.
4437 * cs-parser.jay: Create a Destructor object instead of a Method.
4439 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4443 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4445 * expression.cs (Binary.ResolveOperator): Perform an implicit
4446 conversion from MethodGroups to their delegate types on the
4449 * delegate.cs: Introduce a new class DelegateCreation that is the
4450 base class for `NewDelegate' and `ImplicitDelegateCreation',
4451 factor some code in here.
4453 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4454 conversion from MethodGroups to compatible delegate types.
4456 * ecore.cs (Expression.Resolve): Do not flag error 654
4457 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4458 we allow conversions from MethodGroups to delegate types now.
4460 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4461 assignments in v2 either.
4463 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4465 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4466 static read-only fields in ctors.
4468 Applied patch from Benjamin Jemlich
4470 * expression.cs (UnaryMutator): Avoid leaking local variables.
4472 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4474 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4475 here to return true, as they can be used like this:
4479 Fixed 49836 and all the other dups
4481 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4483 * driver.cs: Implement /win32res and /win32icon.
4485 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4487 * cs-parser.jay: Add a rule to improve error handling for the
4488 common mistake of placing modifiers after the type.
4490 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4492 * cs-parser.jay (interface_event_declaration): Catch
4493 initialization of events on interfaces, and report cs0068
4495 * cs-parser.jay (interface_event_declaration): Catch
4496 initialization of events.
4498 * ecore.cs: Better report missing constructors.
4500 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4501 the error reporting done in the wrong place. Fix.
4503 * expression.cs (Binary.ResolveOperator): Catch the
4504 operator + (E x, E y) error earlier, and later allow for implicit
4505 conversions in operator +/- (E e, U x) from U to the underlying
4508 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4509 52596, if the container class is abstract, the default constructor
4510 is protected otherwise its public (before, we were always public).
4512 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4515 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4516 Jemlich that fixes bug #52597, MCS was generating invalid code for
4517 idisposable structs. Thanks to Ben for following up with this
4520 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4522 * driver.cs: Allow assemblies without code to be generated, fixes
4525 2004-01-07 Nick Drochak <ndrochak@gol.com>
4527 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4529 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4531 * cs-parser.jay: Add rules to improve error reporting if fields or
4532 methods are declared at the namespace level (error 116)
4534 * Add rules to catch event add/remove
4536 2004-01-04 David Sheldon <dave-mono@earth.li>
4538 * expression.cs: Added matching ")" to error message for
4541 2004-01-03 Todd Berman <tberman@gentoo.org>
4543 * ecore.cs, attribute.cs:
4544 Applying fix from #52429.
4546 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4548 * ecore.cs, expression.cs, statement.cs:
4549 Total rewrite of how we handle branching. We
4550 now handle complex boolean expressions with fewer
4551 jumps. As well if (x == 0) no longer emits a ceq.
4553 if (x is Foo) is much faster now, because we generate
4556 Overall, we get a pretty big improvement on our benchmark
4557 tests. The code we generate is smaller and more readable.
4559 I did a full two-stage bootstrap. The patch was reviewed
4560 by Martin and Miguel.
4562 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4564 * cs-parser.jay: Make primary_expression not take a QI.
4565 we dont need this because the member_access rule covers
4566 us here. So we replace the rule with just IDENTIFIER.
4568 This has two good effects. First, we remove a s/r conflict.
4569 Second, we allocate many fewer QualifiedIdentifier objects.
4571 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4573 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4574 set the correct information via SRE. This prevents
4575 hanging on the MS runtime. Fixes #29374.
4577 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4579 * convert.cs: correctly handle conversions to value types
4580 from Enum and ValueType as unboxing conversions.
4582 Fixes bug #52569. Patch by Benjamin Jemlich.
4584 2004-01-02 Ravi Pratap <ravi@ximian.com>
4586 * expression.cs (BetterConversion): Prefer int -> uint
4587 over int -> ulong (csc's behaviour). This fixed bug #52046.
4589 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4591 * decl.cs (MemberCache.FindMembers): now returns a
4594 * typemanager.cs: In general, go with with ^^.
4595 (CopyNewMethods): take an IList.
4596 (RealMemberLookup): Only allocate an arraylist
4597 if we copy from two sets of methods.
4599 This change basically does two things:
4600 1) Fewer array lists allocated due to CopyNewMethods.
4601 2) the explicit cast in MemberList costed ALOT.
4603 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4605 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4606 a hashtable to avoid needless string allocations when an identifier is
4607 used more than once (the common case).
4609 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4611 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4612 is broken, it will not return anything. So, we
4613 have to use the information we have in mcs to
4616 * typemanager.cs: Add a cache for GetInterfaces,
4617 since this will now be used more often (due to ^^)
4619 (GetExplicitInterfaces) New method that gets the
4620 declared, not effective, interfaces on a type
4621 builder (eg, if you have interface IFoo, interface
4622 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4625 This patch makes MCS able to bootstrap itself on
4628 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4630 * expression.cs: Remove the Nop's that Miguel put
4633 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4635 * report.cs, codegen.cs: Give the real stack trace to
4636 the error when an exception is thrown.
4638 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4640 * decl.cs: only allocate hashtables for ifaces if
4643 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4645 * expression.cs: fix the error from cs0121-2.cs
4646 (a parent interface has two child interfaces that
4647 have a function with the same name and 0 params
4648 and the function is called through the parent).
4650 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4652 * class.cs, rootcontext.cs, typmanager.cs: do not
4655 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4657 * codegen.cs: remove stack for the ec flow branching.
4658 It is already a linked list, so no need.
4660 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4662 * Makefile: Allow custom profiler here.
4664 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4666 * typemanager.cs (LookupType):
4667 - Use a static char [], because split takes
4668 a param array for args, so it was allocating
4670 - Do not store true in a hashtable, it boxes.
4672 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4674 * flowanalysis.cs: bytify common enums.
4676 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4678 * modifiers.cs: Add a new set of flags for the
4679 flags allowed on explicit interface impls.
4680 * cs-parser.jay: catch the use of modifiers in
4681 interfaces correctly.
4682 * class.cs: catch private void IFoo.Blah ().
4684 All related to bug #50572.
4686 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4688 * decl.cs: Rewrite the consistant accessability checking.
4689 Accessability is not linear, it must be implemented in
4690 a tableish way. Fixes #49704.
4692 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4694 * expression.cs: Handle negation in a checked context.
4695 We must use subtraction from zero. Fixes #38674.
4697 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4699 * class.cs: Ignore static void main in DLLs.
4700 * rootcontext.cs: Handle the target type here,
4701 since we are have to access it from class.cs
4702 * driver.cs: account for the above.
4704 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4706 * report.cs: Give line numbers and files if available.
4708 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
4710 * driver.cs: Implement /addmodule.
4712 * typemanager.cs: Change 'modules' field so it now contains Modules not
4715 2003-12-20 Martin Baulig <martin@ximian.com>
4717 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
4718 (FieldBase.IsAssigned): Removed this field.
4719 (FieldBase.SetAssigned): New public method.
4720 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
4722 2003-12-20 Martin Baulig <martin@ximian.com>
4724 * expression.cs (LocalVariableReference.DoResolve): Don't set
4725 `vi.Used' if we're called from DoResolveLValue().
4727 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
4728 returns the usage vector it just merged into the current one -
4729 pass this one to UsageWarning().
4730 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
4731 of the `EmitContext', don't call this recursively on our children.
4733 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
4735 * driver.cs: Implement /target:module.
4737 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
4739 * support.cs (CharArrayHashtable): New helper class.
4741 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
4742 char arrays, not strings, so we can avoid creating a string in
4743 consume_identifier if the identifier is a keyword.
4745 2003-12-16 Martin Baulig <martin@ximian.com>
4747 * statement.cs (LocalInfo.Assigned): Removed this property.
4748 (LocalInfo.Flags): Removed `Assigned'.
4749 (LocalInfo.IsAssigned): New public method; takes the EmitContext
4750 and uses flow analysis.
4751 (Block.UsageWarning): Made this method private.
4752 (Block.Resolve): Call UsageWarning() if appropriate.
4754 * expression.cs (LocalVariableReference.DoResolve): Always set
4755 LocalInfo.Used here.
4757 2003-12-13 Martin Baulig <martin@ximian.com>
4759 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
4760 any value here; we're now using flow analysis to figure out
4761 whether a statement/block returns a value.
4763 2003-12-13 Martin Baulig <martin@ximian.com>
4765 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
4767 (FlowBranching.MergeFinally): Don't call
4768 `branching.CheckOutParameters()' here, this is called in
4770 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
4771 when adding the `finally' vector.
4773 2003-12-13 Martin Baulig <martin@ximian.com>
4776 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
4777 actually work and also fix #48962.
4779 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
4781 * decl.cs: Do not check System.Object for nested types,
4782 since we know it does not have any. Big bang for buck:
4787 corlib: 17.99 seconds
4791 corlib: 17.39 seconds
4793 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
4795 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
4796 time we are returning 0 members, so we save alot here.
4798 2003-12-11 Martin Baulig <martin@ximian.com>
4800 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
4801 `MergeChild()', also just take the `FlowBranching' as argument;
4802 call Merge() on it and return the result.
4803 (FlowBranching.Merge): We don't need to do anything if we just
4806 2003-12-11 Martin Baulig <martin@ximian.com>
4808 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
4809 them in an `ArrayList' to reduce memory usage. Thanks to Ben
4810 Maurer for this idea.
4812 2003-12-11 Martin Baulig <martin@ximian.com>
4814 * flowanalysis.cs (MergeResult): This class is now gone; we now
4815 use the `UsageVector' for this. The reason for this is that if a
4816 branching just has one sibling, we don't need to "merge" them at
4817 all - that's the next step to do.
4818 (FlowBranching.Merge): We now return a `UsageVector' instead of a
4821 2003-12-11 Martin Baulig <martin@ximian.com>
4823 Reworked flow analyis and made it more precise and bug-free. The
4824 most important change is that we're now using a special `Reachability'
4825 class instead of having "magic" meanings of `FlowReturns'. I'll
4826 do some more cleanups and optimizations and also add some more
4827 documentation this week.
4829 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
4830 largely reworked this class.
4831 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
4832 the new `Reachability' class instead of having "magic" values here.
4833 (FlowBranching): We're now using an instance of `Reachability'
4834 instead of having separate `Returns', `Breaks' etc. fields.
4836 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
4837 based on flow analysis; ignore the return value of block.Emit ().
4839 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
4841 * driver.cs typemanager.cs: Find the mono extensions to corlib even
4842 if they are private.
4844 2003-12-09 Martin Baulig <martin@ximian.com>
4846 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
4847 call them directly on the UsageVector.
4849 2003-12-09 Martin Baulig <martin@ximian.com>
4851 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
4852 Changed return type from `FlowReturns' to `Reachability'.
4854 2003-12-09 Martin Baulig <martin@ximian.com>
4856 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
4857 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
4858 `Reachable' fields with a single `Reachability' one.
4860 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4862 * class.cs (FindMembers): Remove foreach's.
4875 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4880 This patch does a few things:
4881 1. EmptyStatement is now a singleton, so it is never reallocated.
4882 2. All blah is EmptyStatement constructs have been changed to
4883 blah == EmptyStatement.Value, which is much faster and valid
4884 now that EmptyStatement is a singleton.
4885 3. When resolving a block, rather than allocating a new array for
4886 the non-empty statements, empty statements are replaced with
4887 EmptyStatement.Value
4888 4. Some recursive functions have been made non-recursive.
4889 Mainly the performance impact is from (3), however (1) and (2) are needed for
4890 this to work. (4) does not make a big difference in normal situations, however
4891 it makes the profile look saner.
4896 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4897 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4898 Total memory allocated: 56397 KB
4901 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
4902 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
4903 Total memory allocated: 55666 KB
4905 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4907 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
4908 than the hashtable in a hashtable version
4910 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
4911 we always end up concating a string. This results in a huge perf
4912 loss, because many strings have to be tracked by the GC. In this
4913 patch, we first use a hashtable that works with two keys, so that
4914 the strings do not need to be concat'ed.
4925 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4927 * Makefile: Add a new target `do-time' that does a quick and simple
4928 profile, leaving easy to parse output.
4930 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
4932 * codegen.cs (Init): Create the dynamic assembly with
4933 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
4935 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
4937 * support.cs: Make the PtrHashtable use only one
4938 instance of its comparer.
4940 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
4942 * typemanager.cs: Fix lookup of GetNamespaces.
4944 2003-11-29 Miguel de Icaza <miguel@ximian.com>
4946 * expression.cs: Removed redundant line.
4948 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
4949 ArrayLists, use for loops with bounds.
4951 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
4954 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
4955 arraylists, use for loop with bounds.
4957 The above three changes give us a 0.071 second performance
4958 improvement out of 3.294 seconds down to 3.223. On my machine
4959 the above changes reduced the memory usage by 1,387 KB during
4962 * cs-parser.jay (QualifiedIdentifier): New class used to represent
4963 QualifiedIdentifiers. Before we created a new string through
4964 concatenation, and mostly later on, the result would be
4965 manipulated by DecomposeQI through string manipulation.
4967 This reduced the compiler memory usage for bootstrapping from
4968 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
4969 compile times in 0.05 seconds.
4971 2003-11-28 Dick Porter <dick@ximian.com>
4973 * support.cs: Do string compares with the Invariant culture.
4981 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
4982 the comparison is done with the Invariant culture.
4984 2003-11-27 Miguel de Icaza <miguel@ximian.com>
4986 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
4987 GetEnumerator method.
4989 (ProbeCollectionType): Iterate starting at the most specific type
4990 upwards looking for a GetEnumerator
4992 * expression.cs: Shift count can be up to 31 for int/uint and 63
4995 2003-11-26 Miguel de Icaza <miguel@ximian.com>
4997 * statement.cs (Block.LookupLabel): Also look for the label on the
4998 children blocks. Use a hash table to keep track of visited
5001 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5002 we actually did transform the other operand, otherwise fall back
5003 to the common codepath that casts to long.
5005 * cs-tokenizer.cs: Use the same code pattern as the int case.
5006 Maybe I should do the parsing myself, and avoid depending on the
5007 Parse routines to get this done.
5009 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5011 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5012 which fixes bug 51347. This time test it.
5014 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5015 attributes for example can not tell the difference between these.
5016 The difference was only a syntax feature of the language.
5018 * attribute.cs: Apply attributes to delegates.
5020 * delegate.cs: Call the apply attributes method.
5022 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5024 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5025 comparing 0 vs Byte.MinValue, not the value
5027 (ImplicitConversionRequired): When reporting a conversion error,
5028 use error 31 to print out the constant error instead of the
5031 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5032 which fixes bug 51347.
5034 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5036 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5037 which fixes the -warnaserror command line option.
5039 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5041 * cfold.cs (DoNumericPromotions): During constant folding of
5042 additions on UIntConstant, special case intconstants with
5043 IntConstants like we do on the expression binary operator.
5045 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5047 * convert.cs (ImplicitReferenceConversion): We were missing a case
5048 (System.Enum are not value types or class types, so we need to
5049 classify them separatedly).
5051 * driver.cs: We do not support error 2007.
5053 2003-11-12 Jackson Harper <jackson@ximian.com>
5055 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5056 system directory. Also use the full file name so users can
5057 libraries names mscorlib-o-tron.dll in a non system dir.
5059 2003-11-10 Martin Baulig <martin@ximian.com>
5061 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5062 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5063 calling `ResolveType()' on them, directly assign their `Type'.
5065 2003-11-08 Martin Baulig <martin@ximian.com>
5067 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5068 return value and the `out parent' parameter.
5069 (TypeContainer.DefineType): Moved the CS0644 check into
5070 GetClassBases(). Don't pass the interface types to the
5071 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5072 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5074 * ecore.cs (TypeExpr.IsAttribute): New property.
5075 (TypeExpr.GetInterfaces): New method.
5077 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5078 TypeExpr instead of a Type.
5079 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5080 (Interface.DefineType): Don't pass the interface types to the
5081 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5082 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5084 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5085 instead of a `Type[]'.
5086 (TypeManager.RegisterBuilder): Likewise.
5087 (TypeManager.AddUserInterface): Likewise.
5088 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5089 `Type[]' and also return a `TypeExpr[]'.
5090 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5092 2003-11-08 Martin Baulig <martin@ximian.com>
5094 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5097 2003-11-08 Martin Baulig <martin@ximian.com>
5099 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5100 TypeManager.ResolveExpressionTypes().
5102 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5103 instead of an Expression.
5104 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5105 (TypeExpression): New public class; formerly known as `TypeExpr'.
5107 * expression.cs (ComposedCast): Derive from TypeExpr.
5109 * typemanager.cs (TypeManager.system_*_expr): These are now
5110 TypExpr's instead of Expression's.
5111 (TypeManager.ResolveExpressionTypes): New public static function;
5112 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5115 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5117 * expression.cs (New.DoResolve): Do not dereference value that
5118 might be a null return.
5120 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5121 sure that the constant value has the right type. Fixes an
5122 unreported bug, similar to 50425.
5124 * const.cs (Const.LookupConstantValue): Call
5125 ImplicitStandardConversionExists before doing a conversion to
5126 avoid havng the TypeManager.ChangeType do conversions.
5128 Reduced the number of casts used
5130 (Const.ChangeType): New routine to enable reuse of the constant
5131 type changing code from statement.
5133 * typemanager.cs (ChangeType): Move common initialization to
5134 static global variables.
5138 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5139 every value type to go through, even if it was void. Fix that.
5141 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5142 character of the define, and the is_identifier_part_character for
5143 the rest of the string.
5145 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5147 * expression.cs (UnaryMutator.EmitCode): When I updated
5148 LocalVariableReference.DoResolve, I overdid it, and dropped an
5149 optimization done on local variable references.
5151 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5153 * ecore.cs: Convert the return from Ldlen into an int.
5155 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5157 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5158 the accessibility, this is a special case for toplevel non-public
5159 classes (internal for instance).
5161 2003-10-20 Nick Drochak <ndrochak@gol.com>
5163 * ecore.cs: Fix typo and build. Needed another right paren.
5165 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5167 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5168 `internal' case regular and protected, but not allowing protected
5169 to be evaluated later. Bug 49840
5171 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5173 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5174 to kb.Nlast, and not the kb.nFirst to isolate the switch
5177 Extract the underlying type, so enumerations of long/ulong are
5178 treated like long/ulong.
5180 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5182 * expression.cs (New): Overload the meaning of RequestedType to
5183 track the possible creation of the NewDelegate type, since
5184 DoResolve is invoked more than once for new constructors on field
5187 See bugs: #48800 and #37014
5189 * cs-parser.jay (declare_local_constants): Take an arraylist
5190 instead of a single constant.
5192 (local_constant_declaration): It should take a
5193 constant_declarators, not a constant_declarator. Fixes 49487
5195 * convert.cs: Fix error report.
5197 2003-10-13 Jackson Harper <jackson@ximian.com>
5199 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5202 2003-10-09 Martin Baulig <martin@ximian.com>
5204 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5206 (MethodCore.DoDefineParameters): Removed the TypeContainer
5207 argument; use the DeclSpace which was passed to the .ctor instead.
5208 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5209 TypeContainer; we only need a DeclSpace here.
5211 2003-10-09 Martin Baulig <martin@ximian.com>
5213 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5215 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5216 EmitContext's .ctor.
5218 2003-10-09 Martin Baulig <martin@ximian.com>
5220 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5221 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5222 AsAccessible(), moved them as well.
5224 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5226 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5228 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5230 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5232 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5233 generation for >=, as spotted by Paolo, bug 48679.
5234 Patch from David Waite.
5236 * cs-tokenizer.cs: Add handling for #pragma.
5238 * cs-parser.jay: Allow for both yield and yield return in the
5239 syntax. The anti-cobolization of C# fight will go on!
5241 * class.cs (TypeBuilder.DefineType): Catch error condition here
5242 (Parent.DefineType erroring out and returning null).
5244 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5245 coping with enumerations variables, we were mistakenly processing
5246 them as a regular value type instead of built-in types. Fixes the
5249 * typemanager.cs (IsBuiltinOrEnum): New method.
5251 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5253 * cs-parser.jay: Upgrade: yield now needs the return clause.
5255 2003-09-19 Martin Baulig <martin@ximian.com>
5257 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5258 `MemberCache parent' argument. Normally, an interface doesn't
5259 have a parent type except System.Object, but we use this in gmcs
5260 for generic type parameters.
5262 2003-09-18 Martin Baulig <martin@ximian.com>
5264 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5265 on `type.IsInterface'; don't check whether the type has a parent
5266 to determine whether it's an interface.
5268 2003-09-15 Martin Baulig <martin@ximian.com>
5270 * class.cs (TypeContainer.DefineType): Added an error flag to
5271 avoid reporting duplicate CS0146's ("class definition is
5274 * driver.cs (Driver.MainDriver): Abort if
5275 RootContext.ResolveTree() reported any errors.
5277 2003-09-07 Martin Baulig <martin@ximian.com>
5279 * report.cs (Error, Warning): Added overloaded versions which take
5280 a `params object[] args' and call String.Format().
5282 2003-09-07 Martin Baulig <martin@ximian.com>
5284 * decl.cs (DeclSpace..ctor): Don't call
5285 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5286 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5287 (DeclSpace.RecordDecl): New method.
5289 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5291 2003-09-02 Ravi Pratap <ravi@ximian.com>
5293 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5294 value attributes to be applied to ParameterBuilders.
5296 * class.cs (MethodCore.LabelParameters): Make static and more
5297 generic so that it can be used from other places - like interface
5298 methods, for instance.
5300 * interface.cs (Interface.Emit): Call LabelParameters before
5301 emitting attributes on the InterfaceMethod.
5303 2003-08-26 Martin Baulig <martin@ximian.com>
5305 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5306 resolving aliases; fixes #47927.
5308 2003-08-26 Martin Baulig <martin@ximian.com>
5310 * statement.cs (Using.DoResolve): This is internally emitting a
5311 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5312 do not always return. Fixes #47681.
5314 2003-08-26 Martin Baulig <martin@ximian.com>
5316 * decl.cs (MemberCore): Moved WarningNotHiding(),
5317 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5319 (AdditionResult): Make this nested in DeclSpace.
5320 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5321 argument; call NamespaceEntry.Define() unless we're nested in a
5324 * namespace.cs (Namespace.DefineName): New public function. This
5325 is called from DeclSpace's .ctor to add
5326 (Namespace.Lookup): Include DeclSpaces in the lookup.
5328 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5330 * const.cs (Const): Derive from MemberBase, not MemberCore.
5332 2003-08-25 Martin Baulig <martin@ximian.com>
5334 * convert.cs (Convert.ExplicitReferenceConversion): When
5335 converting from an interface type to a class, unbox if the target
5336 type is a struct type. Fixes #47822.
5338 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5340 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5343 2003-08-22 Martin Baulig <martin@ximian.com>
5345 * class.cs (TypeManager.DefineType): When defining a nested type,
5346 call DefineType() on our parent; fixes #47801.
5348 2003-08-22 Martin Baulig <martin@ximian.com>
5350 * class.cs (MethodData.Define): While checking if a method is an
5351 interface implementation, improve the test a bit more to fix #47654.
5353 2003-08-22 Martin Baulig <martin@ximian.com>
5355 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5356 correctly; fixes #47722.
5358 2003-08-22 Martin Baulig <martin@ximian.com>
5360 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5361 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5363 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5365 2003-08-22 Martin Baulig <martin@ximian.com>
5367 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5368 can only be assigned in static constructors. Fixes #47161.
5370 2003-08-22 Martin Baulig <martin@ximian.com>
5372 Rewrote and improved the flow analysis code.
5374 * flowbranching.cs (FlowBranching): Make this class abstract.
5375 (FlowBranching.CreateBranching): New static function to create a
5377 (FlowBranchingBlock, FlowBranchingException): New classes.
5378 (FlowBranching.UsageVector.Type): New public readonly field.
5379 (FlowBranching.UsageVector.Breaks): Removed the setter.
5380 (FlowBranching.UsageVector.Returns): Removed the setter.
5381 (FlowBranching.UsageVector): Added Break(), Return(),
5382 NeverReachable() and Throw() methods to modify the reachability.
5383 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5384 done by FlowBranching.Merge().
5385 (FlowBranching.UsageVector.MergeChild): New method; merges the
5386 merge result into the current vector.
5387 (FlowBranching.Merge): New abstract method to merge a branching.
5389 2003-08-12 Martin Baulig <martin@ximian.com>
5391 * expression.cs (Indirection.CacheTemporaries): Create the
5392 LocalTemporary with the pointer type, not its element type.
5394 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5396 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5397 token was a keyword or not.
5399 Add `error' options where an IDENTIFIER was expected; Provide
5400 CheckToken and CheckIdentifierToken convenience error reporting
5403 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5405 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5406 NameSpaceEntry NameSpaceEntry.
5408 (LookupInterfaceOrClass): Avoid creating a full qualified name
5409 from namespace and name: avoid doing lookups when we know the
5410 namespace is non-existant. Use new Tree.LookupByNamespace which
5411 looks up DeclSpaces based on their namespace, name pair.
5413 * driver.cs: Provide a new `parser verbose' to display the
5414 exception thrown during parsing. This is turned off by default
5415 now, so the output of a failure from mcs is more graceful.
5417 * namespace.cs: Track all the namespaces defined in a hashtable
5420 (IsNamespace): New method
5422 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5424 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5425 we know that we need to concatenate (full typename can never be
5430 * statement.cs: Use a bitfield; Do not initialize to null things
5431 which are done by the constructor by default.
5433 * cs-parser.jay: bug fix, parameter was 4, not 3.
5435 * expression.cs: Just use the property;
5437 * statement.cs: No need for GetVariableInfo method.
5439 2003-08-08 Martin Baulig <martin@ximian.com>
5441 * flowanalysis.cs (FlowReturns): This is now nested in the
5442 `FlowBranching' class.
5443 (MyBitVector): Moved this here from statement.cs.
5444 (FlowBranching.SiblingType): New enum type.
5445 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5447 2003-08-07 Martin Baulig <martin@ximian.com>
5449 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5450 `FlowBranching' class and called `BranchingType'.
5452 2003-08-07 Martin Baulig <martin@ximian.com>
5454 * flowanalysis.cs: Moved all the control flow analysis code into
5457 2003-08-07 Martin Baulig <martin@ximian.com>
5459 * assign.cs (Assign.DoResolve): `target' must either be an
5460 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5463 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5465 * expression.cs (BinaryMethod): This kind of expression is created by the
5466 Binary class if it determines that the operator has to be handled
5469 (BinaryDelegate): This kind of expression is created if we are
5470 dealing with a + or - operator on delegates.
5472 (Binary): remove method, argumetns, and DelegateOperator: when
5473 dealing with methods,
5475 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5477 * statement.cs (Block): use bitfields for the three extra booleans
5478 we had in use. Remove unused topblock parameter.
5480 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5482 * assign.cs: Drop extra unneeded tests.
5484 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5486 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5488 * statement.cs (Foreach): Use VariableStorage instead of
5491 * codegen.cs (VariableStorage): New class used by clients that
5492 require a variable stored: locals or fields for variables that
5493 need to live across yield.
5495 Maybe provide a convenience api for EmitThis+EmitLoad?
5497 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5500 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5502 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5503 RemapParameterLValue): New methods that are used to turn a
5504 precomputed FieldInfo into an expression like this:
5508 The idea is to use this instead of making LocalVariableReference
5509 have more than one meaning.
5511 * cs-parser.jay: Add error production to BASE.
5513 * ecore.cs: Deal with TypeManager.GetField returning null, which
5514 is now a valid return value.
5516 (FieldExprNoAddress): New expression for Fields whose address can
5519 * expression.cs (LocalVariableReference): During the resolve
5520 phases, create new expressions if we are in a remapping context.
5521 Remove code that dealt with remapping here.
5523 (ParameterReference): same.
5525 (ProxyInstance): New expression, like the `This' expression, but
5526 it is born fully resolved. We know what we are doing, so remove
5527 the errors that are targeted to user-provided uses of `this'.
5529 * statement.cs (Foreach): our variable is now stored as an
5530 Expression; During resolution, follow the protocol, dont just
5531 assume it will return this.
5533 2003-08-06 Martin Baulig <martin@ximian.com>
5535 * support.cs (SeekableStreamReader.cs): New public class.
5537 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
5538 SeekableStreamReader instead of the normal StreamReader.
5540 2003-08-04 Martin Baulig <martin@ximian.com>
5542 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
5543 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
5544 deambiguate casts and delegate invocations.
5545 (parenthesized_expression): Use the new tokens to ensure this is
5546 not a cast of method invocation.
5548 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
5549 when reading a `)' and Deambiguate_CloseParens () was previously
5552 * expression.cs (ParenthesizedExpression): New class. This is
5553 just used for the CS0075 test.
5554 (Binary.DoResolve): Check for CS0075.
5556 2003-07-29 Ravi Pratap <ravi@ximian.com>
5558 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5559 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5560 reference comparison.
5562 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5563 examine the ReturnType for equality - this is necessary in the
5564 cases of implicit and explicit operators whose signature also
5565 includes the return type.
5567 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5569 * namespace.cs: Cache the result of the namespace computation,
5570 instead of computing it every time.
5572 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5574 * decl.cs: Use a global arraylist that we reuse over invocations
5575 to avoid excesive memory consumption. Reduces memory usage on an
5576 mcs compile by one meg (45 average).
5578 * typemanager.cs (LookupTypeReflection): In .NET pointers are
5579 private, work around that.
5581 2003-07-23 Miguel de Icaza <miguel@ximian.com>
5583 * literal.cs (IntLiteral): Define Zero and One static literals.
5585 * cs-parser.jay (integer_literal): use static literals to reduce
5586 memory usage for the most used literals (0, 1 and -1). 211kb
5587 reduced in memory usage.
5589 Replace all calls to `new ArrayList' with `new
5590 ArrayList(4)' which is a good average number for most allocations,
5591 and also requires only 16 bytes of memory for its buffer by
5594 This reduced MCS memory usage in seven megabytes for the RSS after
5597 2003-07-28 Ravi Pratap <ravi@ximian.com>
5599 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
5600 handle params methods the correct way by forming only one
5601 applicable set with params and normal methods in them. Earlier we
5602 were looking at params methods only if we found no normal methods
5603 which was not the correct thing to do.
5605 (Invocation.BetterFunction): Take separate arguments indicating
5606 when candidate and the best method are params methods in their
5609 This fixes bugs #43367 and #46199.
5611 * attribute.cs: Documentation updates.
5613 (CheckAttribute): Rename to CheckAttributeTarget.
5614 (GetValidPlaces): Rename to GetValidTargets.
5616 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
5617 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
5621 2003-07-28 Martin Baulig <martin@ximian.com>
5623 * class.cs (TypeContainer.DefineMembers): Use the base type's full
5624 name when looking up the base class of a nested class. Fixes #46977.
5626 2003-07-26 Martin Baulig <martin@ximian.com>
5628 * expression.cs (Indexers.Indexer): New nested struct; contains
5629 getter, setter and the indexer's type.
5630 (Indexers.Properties): This is now an ArrayList of
5632 (IndexerAccess.DoResolveLValue): Correctly set the type if the
5633 indexer doesn't have any getters.
5635 * assign.cs (Assign.DoResolve): Also do the implicit conversions
5636 for embedded property and indexer assignments.
5638 2003-07-26 Martin Baulig <martin@ximian.com>
5640 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
5641 preprocessor directive is not the first non-whitespace character
5644 2003-07-26 Martin Baulig <martin@ximian.com>
5646 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
5647 namespace parsing, follow the spec more closely.
5649 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
5650 NamespaceEntry.Lookup().
5652 2003-07-25 Martin Baulig <martin@ximian.com>
5654 * MethodCore.cs (OverridesSomething): New public field; it's set
5655 from TypeContainer.DefineMembers if this method overrides
5656 something (which doesn't need to be a method). Fix #39462.
5658 2003-07-25 Ravi Pratap <ravi@ximian.com>
5660 * typemanager.cs (GetMembers): Ensure that the list of members is
5661 reversed. This keeps things in sync.
5663 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
5664 find an AttributeUsage attribute.
5666 * expression.cs (Invocation.OverloadResolve): Perform the check
5667 which disallows Invoke to be directly called on a Delegate.
5669 (Error_InvokeOnDelegate): Report error cs1533.
5671 2003-07-25 Martin Baulig <martin@ximian.com>
5673 * expression.cs (Indexers.GetIndexersForType): Only look in the
5674 interface hierarchy if the requested type is already an
5675 interface. Fixes #46788 while keeping #46502 fixed.
5677 2003-07-25 Martin Baulig <martin@ximian.com>
5679 * class.cs (TypeContainer.DefineMembers): Check whether all
5680 readonly fields have been assigned and report warning CS0649 if
5683 * statement.cs (LocalInfo.IsFixed): Always return true if this is
5686 2003-07-24 Ravi Pratap <ravi@ximian.com>
5688 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
5689 returned from GetMethods to make things consistent with the
5690 assumptions MCS makes about ordering of methods.
5692 This should comprehensively fix bug #45127 and it does :-)
5694 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
5695 ordering is actually reverse.
5697 * Clean up some debug messages I left lying around.
5699 * interface.cs (Populate*): Get rid of code which emits attributes
5700 since the stage in which we emit attributes is the 'Emit' stage,
5701 not the define stage.
5703 (Emit): Move attribute emission for interface members here.
5705 2003-07-22 Ravi Pratap <ravi@ximian.com>
5707 * expression.cs (Invocation.OverloadResolve): Follow the spec more
5708 closely: we eliminate methods in base types when we have an
5709 applicable method in a top-level type.
5711 Please see section 14.5.5.1 for an exact description of what goes
5714 This fixes bug #45127 and a host of other related to corlib compilation.
5716 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
5717 array is the method corresponding to the top-level type (this is
5718 because of the changes made to icall.c) so we change this
5721 (MethodGroupExpr.Name): This too.
5723 * typemanager.cs (GetElementType): New method which does the right
5724 thing when compiling corlib.
5726 * everywhere: Make use of the above in the relevant places.
5728 2003-07-22 Martin Baulig <martin@ximian.com>
5730 * cs-parser.jay (invocation_expression): Moved
5731 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
5732 `cast_expression', but create a InvocationOrCast which later
5733 resolves to either an Invocation or a Cast.
5735 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
5736 method; call this before EmitStatement() to make sure that this
5737 expression can be used as a statement.
5739 * expression.cs (InvocationOrCast): New class; resolves to either
5740 an Invocation or a Cast.
5742 * statement.cs (StatementExpression): Call ResolveStatement() on
5743 the ExpressionStatement before emitting it.
5745 2003-07-21 Martin Baulig <martin@ximian.com>
5747 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
5748 `ref' and `out' attributes match; fixes #46220.
5749 (MemberAccess.ResolveMemberAccess): You can't reference a type
5750 through an expression; fixes #33180.
5751 (Indexers.GetIndexersForType): Don't return the indexers from
5752 interfaces the class implements; fixes #46502.
5754 2003-07-21 Martin Baulig <martin@ximian.com>
5756 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
5757 CS0661 checks; fixes bug #30442.
5759 2003-07-21 Martin Baulig <martin@ximian.com>
5761 * decl.cs (AdditionResult): Added `Error'.
5763 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
5765 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
5766 makes cs0031.cs actually work.
5768 2003-07-20 Martin Baulig <martin@ximian.com>
5770 * namespace.cs: Fixed that bug which caused a crash when compiling
5773 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5775 * typemanager.cs (LookupTypeReflection): Never expose types which
5776 are NotPublic, NestedPrivate, NestedAssembly, or
5777 NestedFamANDAssem. We used to return these, and later do a check
5778 that would report a meaningful error, but the problem is that we
5779 would not get the real match, if there was a name override.
5781 2003-07-18 Miguel de Icaza <miguel@ximian.com>
5783 * namespace.cs (Namespace, Name): Do not compute the namespace
5784 name dynamically, compute it in the constructor. This reduced
5785 memory usage by 1697 KB.
5787 * driver.cs: Use --pause to pause at the end.
5789 2003-07-17 Peter Williams <peter@newton.cx>
5791 * Makefile: Change the name of the test target so that it doesn't
5792 conflict with the recursive test target.
5794 2003-07-17 Miguel de Icaza <miguel@ximian.com>
5796 * expression.cs (LocalVariableReference.Emit, EmitAssign,
5797 AddressOf): Do not use EmitThis, that was wrong, use the actual
5800 2003-07-15 Miguel de Icaza <miguel@ximian.com>
5802 * class.cs (MethodData.Define): While checking if a method is an
5803 interface implementation, improve the test: If we are not public
5804 (use new test here: use the computed MethodAttributes directly,
5805 instead of the parsed modifier flags) check if the `implementing'
5806 method comes from an interface or not.
5808 * pending.cs (VerifyPendingMethods): Slightly better error
5811 * makefile: add test target that does the mcs bootstrap.
5813 2003-07-16 Ravi Pratap <ravi@ximian.com>
5815 * interface.cs (Define): Do nothing here since there are no
5816 members to populate etc. Move the attribute emission out of here
5817 since this was just totally the wrong place to put it. Attribute
5818 application happens during the 'Emit' phase, not in the 'Define'
5821 (Emit): Add this method and move the attribute emission here
5823 * rootcontext.cs (EmitCode): Call the Emit method on interface
5826 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5828 * expression.cs (OverloadResolve): Report error only if Location
5829 is not 'Null' which means that there was a probe going on.
5831 2003-07-14 Martin Baulig <martin@ximian.com>
5833 * expression.cs (ConditionalLogicalOperator): New public class to
5834 implement user defined conditional logical operators.
5835 This is section 14.11.2 in the spec and bug #40505.
5837 2003-07-14 Martin Baulig <martin@ximian.com>
5839 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
5841 2003-07-14 Martin Baulig <martin@ximian.com>
5843 * codegen.cs (EmitContext.InFixedInitializer): New public field.
5845 * ecore.cs (IVariable.VerifyFixed): New interface method.
5847 * expression.cs (Unary.ResolveOperator): When resolving the `&'
5848 operator, check whether the variable is actually fixed. Fixes bug
5849 #36055. Set a variable definitely assigned when taking its
5850 address as required by the spec.
5852 * statement.cs (LocalInfo.IsFixed): New field.
5853 (LocalInfo.MakePinned): Set `IsFixed' to true.
5855 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5857 * attribute.cs (Attribute.Resolve): While doing a Member lookup
5858 for .ctors, ensure that we only ask for members declared in the
5859 attribute type (BindingFlags.DeclaredOnly).
5863 * expression.cs (Error_WrongNumArguments): Report error 1501
5864 correctly the way CSC does.
5866 2003-07-13 Martin Baulig <martin@ximian.com>
5868 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
5869 lookup on the fully qualified name, to make things like "X.X" work
5870 where "X.X" is a fully qualified type name, but we also have a
5871 namespace "X" in the using list. Fixes #41975.
5873 2003-07-13 Martin Baulig <martin@ximian.com>
5875 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
5876 function. If we're a CompoundAssign, we need to create an embedded
5877 CompoundAssign, not an embedded Assign.
5878 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
5881 2003-07-13 Martin Baulig <martin@ximian.com>
5883 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
5884 work to fix bug #46088.
5886 2003-07-13 Ravi Pratap <ravi@ximian.com>
5888 * class.cs (Operator.Emit): Do not emit attributes here - it is
5889 taken care of by the Method class that we delegate too. This takes
5892 2003-07-10 Martin Baulig <martin@ximian.com>
5894 * expression.cs (TypeOfVoid): New class.
5895 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
5897 2003-07-10 Martin Baulig <martin@ximian.com>
5899 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
5902 2003-07-10 Martin Baulig <martin@ximian.com>
5904 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
5905 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
5907 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
5909 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
5911 2003-07-10 Martin Baulig <martin@ximian.com>
5913 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
5914 of decimal. Fixes #42850.
5916 NOTE: I also fixed the created byte blob, but this doesn't work on
5917 the MS runtime and csc never produces any byte blobs for decimal
5920 2003-07-10 Martin Baulig <martin@ximian.com>
5922 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
5923 structs; fixes #32068.
5924 (Block.AddChildVariableNames): Fixed #44302.
5926 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5928 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
5930 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5932 * attribute.cs: And this test is onger needed.
5934 2003-07-08 Martin Baulig <martin@ximian.com>
5936 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
5937 inaccessible types. Fixes #36313.
5939 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
5941 * namespace.cs (NamespaceEntry): Create implicit entries for all
5942 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
5943 implicit entries for N1.N2 and N1.
5945 2003-07-08 Martin Baulig <martin@ximian.com>
5947 Rewrote the handling of namespaces to fix a lot of the issues
5948 wrt. `using' aliases etc.
5950 * namespace.cs (Namespace): Splitted this class into a
5951 per-assembly `Namespace' and a per-file `NamespaceEntry'.
5953 * typemanager.cs (TypeManager.IsNamespace): Removed.
5954 (TypeManager.ComputeNamespaces): Only compute namespaces from
5955 loaded assemblies here, not the namespaces from the assembly we're
5956 currently compiling.
5958 2003-07-08 Martin Baulig <martin@ximian.com>
5960 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
5962 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5964 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
5967 I thought about the memory savings here, but LookupTypeReflection
5968 is used under already very constrained scenarios. Compiling
5969 corlib or mcs only exposes one hit, so it would not really reduce
5970 any memory consumption.
5972 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5974 * typemanager.cs: fixes bug #45889 by only adding public types from
5975 other assemblies to the list of known types.
5977 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5979 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
5980 on the type we resolved.
5982 2003-07-05 Martin Baulig <martin@ximian.com>
5984 * pending.cs (PendingImplementation.ParentImplements): Don't
5985 create the proxy if the parent is abstract.
5987 * class.cs (TypeContainer.DefineIndexers): Process explicit
5988 interface implementations first. Fixes #37714.
5990 2003-07-04 Miguel de Icaza <miguel@ximian.com>
5992 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
5993 defined recursively; but since we modify the input parameters
5994 (left is set to `this' temporarily), we reset this value if the
5995 left_is_explicit is false, which gives the original semantics to
5998 * literal.cs (NullPointer): new class used to represent a null
5999 literal in a pointer context.
6001 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6002 type is a pointer, use a NullPointer object instead of a
6003 NullLiteral. Closes 43687
6005 (ExplicitConversion): Convert pointer values using
6006 the conv opcode to the proper type.
6008 * ecore.cs (New): change ValueTypeVariable property into a method,
6009 that returns whether the valuetype is suitable for being used.
6011 * expression.cs (Binary.DoNumericPromotions): Only return if we
6012 the int constant was a valid uint, and we can return both left and
6013 right as uints. If not, we continue processing, to trigger the
6014 type conversion. This fixes 39018.
6016 * statement.cs (Block.EmitMeta): During constant resolution, set
6017 the CurrentBlock property on the emitcontext, so that we resolve
6018 constants propertly.
6020 2003-07-02 Martin Baulig <martin@ximian.com>
6022 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6023 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6025 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6026 than emitting it here.
6028 * statement.cs: Fixed some more flow analysis bugs.
6030 2003-07-02 Martin Baulig <martin@ximian.com>
6032 * class.cs (MethodData.Define): When implementing interface
6033 methods, set Final unless we're Virtual.
6035 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6036 check work for interface methods.
6038 2003-07-01 Martin Baulig <martin@ximian.com>
6040 * ecore.cs (EmitContext.This): Replaced this property with a
6041 GetThis() method which takes a Location argument. This ensures
6042 that we get the correct error location for a CS0188.
6044 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6046 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6047 ImplicitStandardConversion.
6049 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6051 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6053 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6056 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6058 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6061 (MethodData.Define): Turn off initlocals for unsafe methods.
6063 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6065 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6066 complete; Fixes #37521.
6068 * delegate.cs: Use Modifiers.TypeAttr to compute the
6069 TypeAttributes, instead of rolling our own. This makes the flags
6070 correct for the delegates.
6072 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6074 * class.cs (Constructor.Define): Set the private flag for static
6075 constructors as well.
6077 * cs-parser.jay (statement_expression): Set the return value to
6078 null, to avoid a crash when we catch an error.
6080 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6082 * cs-parser.jay: Applied patch from Jackson that adds support for
6083 extern and unsafe modifiers to destructor declarations.
6085 * expression.cs: Report error 21 if the user is trying to index a
6088 * driver.cs: Add an error message, suggested by the bug report.
6090 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6091 if we do not have a ": this ()" constructor initializer. Fixes 45149
6093 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6095 * namespace.cs: Add some information to reduce FAQs.
6097 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6099 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6100 underlying enumeration types. Fixes #43915.
6102 * expression.cs: Treat ushort/short as legal values to be used in
6105 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6107 * delegate.cs: transfer custom attributes for paramenters from
6108 the delegate declaration to Invoke and BeginInvoke.
6110 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6112 * attribute.cs: handle custom marshalers and emit marshal info
6115 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6117 * makefile.gnu: Added anonymous.cs to the compiler sources.
6119 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6121 * iterators.cs: Change the name of the proxy class to include two
6124 * cs-parser.jay: Update grammar to include anonymous methods.
6126 * anonymous.cs: new file.
6128 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6130 * class.cs (Field.Define): Add missing test for pointers and
6133 2003-05-27 Ravi Pratap <ravi@ximian.com>
6135 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6136 we use the stobj opcode.
6138 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6139 since it wasn't the correct fix.
6141 It still is puzzling that we are required to use stobj for IntPtr
6142 which seems to be a ValueType.
6144 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6146 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6147 during regular simple name resolution. Now, the trick is that
6148 instead of returning for processing the simplename, we do a
6149 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6150 contextual lookup type). If a match is found, return that, if
6151 not, return for further composition.
6153 This fixes long-standing 30485.
6155 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6156 using the address to initialize an object, do an Stobj instead of
6157 using the regular Stelem.
6159 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6160 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6161 Because if we are a BaseIndexerAccess that value will be true.
6164 * statement.cs (GotoCase.Resolve): Return after reporting an
6165 error, do not attempt to continue.
6167 * expression.cs (PointerArithmetic.Emit): If our operand is a
6168 long, convert our constants to match the operand before
6169 multiplying. Convert to I type before adding. Fixes 43670.
6171 2003-05-14 Ravi Pratap <ravi@ximian.com>
6173 * enum.cs (ImplicitConversionExists) : Rename to
6174 ImplicitEnumConversionExists to remove ambiguity.
6176 * ecore.cs (NullCast): New type of cast expression class which
6177 basically is very similar to EmptyCast with the difference being
6178 it still is a constant since it is used only to cast a null to
6182 * convert.cs (ImplicitReferenceConversion): When casting a null
6183 literal, we return a NullCast.
6185 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6186 should be around anymore.
6188 The renaming (reported was slightly wrong). Corrections:
6190 ConvertImplicitStandard -> ImplicitConversionStandard
6191 ConvertExplicitStandard -> ExplicitConversionStandard
6193 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6194 before passing them in !
6196 * convert.cs (ImplicitConversionStandard): When comparing for
6197 equal expr and target types, ensure that expr is not a
6200 In general, we must not be checking (expr_type ==
6201 target_type) in the top level conversion methods
6202 (ImplicitConversion, ExplicitConversion etc). This checking is
6203 done in the methods that they delegate to.
6205 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6207 * convert.cs: Move Error_CannotConvertType,
6208 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6209 ImplicitNumericConversion, ImplicitConversionExists,
6210 ImplicitUserConversionExists, StandardConversionExists,
6211 FindMostEncompassedType, FindMostSpecificSource,
6212 FindMostSpecificTarget, ImplicitUserConversion,
6213 ExplicitUserConversion, GetConversionOperators,
6214 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6215 TryImplicitIntConversion, Error_CannotConvertImplicit,
6216 ConvertImplicitRequired, ConvertNumericExplicit,
6217 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6218 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6221 Perform the following renames:
6223 StandardConversionExists -> ImplicitStandardConversionExists
6224 ConvertImplicit -> ImplicitConversion
6225 ConvertImplicitStandard -> ImplicitStandardConversion
6226 TryImplicitIntConversion -> ImplicitIntConversion
6227 ConvertImplicitRequired -> ImplicitConversionRequired
6228 ConvertNumericExplicit -> ExplicitNumericConversion
6229 ConvertReferenceExplicit -> ExplicitReferenceConversion
6230 ConvertExplicit -> ExplicitConversion
6231 ConvertExplicitStandard -> ExplicitStandardConversion
6233 2003-05-19 Martin Baulig <martin@ximian.com>
6235 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6236 (TypeInfo): Added support for structs having structs as fields.
6238 * ecore.cs (FieldExpr): Implement IVariable.
6239 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6240 VariableInfo for the field.
6242 2003-05-18 Martin Baulig <martin@ximian.com>
6244 * expression.cs (This.DoResolve): Report a CS0027 if we're
6245 emitting a field initializer.
6247 2003-05-18 Martin Baulig <martin@ximian.com>
6249 * expression.cs (This.ResolveBase): New public function.
6250 (This.DoResolve): Check for CS0188.
6252 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6255 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6256 `instance_expression' to null if we don't have any non-static
6259 2003-05-18 Martin Baulig <martin@ximian.com>
6261 Reworked the way how local variables and parameters are handled by
6262 the flow analysis code.
6264 * statement.cs (TypeInfo, VariableMap): New public classes.
6265 (VariableInfo): New public class. This is now responsible for
6266 checking whether a variable has been assigned. It is used for
6267 parameters and local variables.
6268 (Block.EmitMeta): Take the InternalParameters as argument; compute
6269 the layout of the flow vectors here.
6270 (Block.LocalMap, Block.ParameterMap): New public properties.
6271 (FlowBranching): The .ctor doesn't get the InternalParameters
6272 anymore since Block.EmitMeta() now computes the layout of the flow
6274 (MyStructInfo): This class is now known as `StructInfo' and nested
6275 in `TypeInfo'; we don't access this directly anymore.
6277 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6278 property and removed IsAssigned(), IsFieldAssigned(),
6279 SetAssigned() and SetFieldAssigned(); we now call them on the
6280 VariableInfo so we don't need to duplicate this code everywhere.
6282 * expression.cs (ParameterReference): Added `Block block' argument
6284 (LocalVariableReference, ParameterReference, This): The new
6285 VariableInfo class is now responsible for all the definite
6288 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6289 IsParameterAssigned, SetParameterAssigned): Removed.
6291 2003-05-18 Martin Baulig <martin@ximian.com>
6293 * typemanager.cs (InitCoreTypes): Try calling
6294 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6295 the 3-args-version. Corlib now also needs our `void_type'.
6296 (GetMethod): Added overloaded version which takes an optional
6297 `bool report_errors' to allow lookups of optional methods.
6299 2003-05-12 Martin Baulig <martin@ximian.com>
6301 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6302 only used for locals and not for parameters.
6304 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6306 * support.cs (InternalParameters.ParameterType): Return the
6307 ExternalType of the parameter.
6309 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6312 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6314 * class.cs (MethodData.Define): Do not set the `newslot' on
6315 interface members, if they are also flagged as "override".
6317 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6318 better code for ++i and i++. This only works for static fields
6319 and local variables.
6321 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6322 want to pull the DeclSpace out of the builder_to_declspace instead
6323 of the TypeBuilder (like in TypeContainer.FindMembers).
6325 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6326 instead of LookupTypeContainer. Fixes the crash on .NET for
6327 looking up interface members.
6329 * const.cs: Create our own emit context during the Definition
6330 stage, so that constants are evaluated in the proper context, when
6331 a recursive definition happens.
6333 2003-05-11 Martin Baulig <martin@ximian.com>
6335 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6336 new block for a switch section.
6337 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6338 the adding/lookup in the switch block. Fixes #39828.
6340 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6342 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6343 functionality: I needed to convert the data after I had performed
6344 the add/sub operation into the operands type size.
6346 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6347 pass the type for the box operation, otherwise the resulting
6348 object would have been of type object.
6350 (BoxedCast): Add constructor to specify the type to box as.
6352 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6354 * iterators.cs: I was reusing the `count' variable inadvertently,
6355 take steps to not allow this to happen.
6357 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6359 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6360 by creating an array at the point where the params starts and
6361 putting all those arguments there, then adjusting the size of the
6364 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6366 * expression.cs (New.AddressOf): Implement interface
6367 IMemoryLocation. This is used when the `new' operator is used in
6368 the context of an invocation to a method on a value type.
6370 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6373 * namespace.cs: Also check the using aliases here.
6375 * driver.cs: Move the test for using validity after the types have
6376 been entered, so we do a single pass that also includes the using
6379 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6380 in the regular case. CreateSiblingForFinally is doing extra
6383 * attribute.cs (GetAttributeArgumentExpression): Store the result
6384 on an out value, and use the return value to indicate failure
6385 instead of using null (which is a valid return for Constant.GetValue).
6387 * statement.cs: Perform the analysis flow for the increment
6388 portion after the statement, because this will be the real flow of
6389 execution. Fixes #42385
6391 * codegen.cs (EmitContext.EmitArgument,
6392 EmitContext.EmitStoreArgument): New helper functions when the
6393 RemapToProxy flag is set.
6395 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6398 Add support for remapping parameters.
6400 * iterators.cs: Propagate parameter values; Store parameter
6401 values in the proxy classes.
6403 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6405 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6406 need a proxy reference; I do not know what I was thinking
6408 * cs-parser.jay (constructor_initializer): catch another error,
6409 and display nice message.
6411 (field_declaration): catch void field declaration
6412 to flag a better error.
6414 * class.cs (MemberBase.CheckBase): Report an error instead of a
6415 warning if a new protected member is declared in a struct.
6416 (Field.Define): catch the error of readonly/volatile.
6418 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6420 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6421 volatile variable is taken
6423 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6425 * statement.cs (Fixed.Resolve): Report an error if we are not in
6428 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6430 * typemanager.cs: reuse the code that handles type clashes for
6431 delegates and enumerations.
6433 * class.cs (Report28): Always report.
6435 * expression.cs (EncodeAsAttribute): Allow nulls here.
6437 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6439 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6440 the functionality for testing whether an expression is valid for
6441 an attribute here. Also handle the case of arrays of elements
6444 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6445 encoding a linear array into an array of objects that are suitable
6446 to be passed to an CustomAttributeBuilder.
6448 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6450 * ecore.cs: (FieldExpr): Handle field remapping here.
6452 * iteratators.cs: Pass the instance variable (if the method is an
6453 instance method) to the constructors, so we can access the field
6454 variables on the class.
6456 TODO: Test this with structs. I think the THIS variable on
6457 structs might have to be a pointer, and not a refenrece
6459 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6461 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6462 local variables to fields in a proxy class.
6464 * iterators.cs (PopulateProxy): Rename our internal fields to
6466 Create a <THIS> field if we are an instance method, so we can
6467 reference our parent container variables.
6468 (MapVariable): Called back from the EmitContext code to enter a
6469 new variable to field mapping into the proxy class (we just create
6473 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6474 for using the remapped locals to fields.
6476 I placed the code here, because that gives the same semantics to
6477 local variables, and only changes the Emit code.
6479 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6480 statements inside iterators.
6481 (VariableInfo): Add a FieldBuilder for the cases when we are
6482 remapping local variables to fields in a proxy class
6484 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6485 current_block != null.
6487 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6488 not cope with strings, as it has been moved to the
6489 TableSwitchEmit. Fixed bug in switch generation.
6491 * expression.cs (New.DoResolve): Provide more context for the user
6492 when reporting an error.
6494 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6497 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6498 check the permissions for it. Note than in a type-resolution
6499 context the check was already present in DeclSpace.ResolveType,
6500 but was missing from the MemberAccess.
6502 (ArrayCreation.CheckIndices): warn if the user has
6503 more nested levels of expressions, but there are no more
6504 dimensions specified. Avoids crash on bug 41906.
6506 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6508 * statement.cs (Block): replace Implicit bool, for a generic
6510 New flag: `Unchecked'. This is used during the EmitMeta phase
6511 (which is out-of-line with the regular Resolve/Emit process for a
6512 statement, as this is done ahead of time, but still gets a chance
6513 to call constant resolve).
6515 (Block.Flags): new enum for adding a new flag.
6517 (Block.EmitMeta): track the state of unchecked.
6519 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6520 to enable constant resolution to work there as well.
6522 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6524 * typemanager.cs (ienumerable_type): Also look up
6525 System.Collections.IEnumerable.
6527 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6529 TODO: Test more than one conditional per method.
6531 * class.cs (Indexer.Define): Report the location where the user is
6532 referencing the unsupported feature.
6534 (MethodData): Overload the use of `conditionals' to
6535 minimize the creation of needless ArrayLists. This saves roughly
6536 212kb on my machine.
6538 (Method): Implement the new IIteratorContainer interface.
6539 (Method.SetYields): Implement the method by setting the ModFlags
6540 to contain METHOD_YIELDS.
6542 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
6543 which just got set to null.
6545 * iterators.cs: New file.
6547 (Yield, YieldBreak): New statements.
6549 * statement.cs (Return.Resolve): Flag an error if we are used in
6552 * codegen.cs (InIterator): New flag set if the code is being
6553 compiled in an iterator method.
6555 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6556 internal modifier, and we just use it to avoid adding extra
6557 fields, as this is seldom used.
6559 * cs-parser.jay: Add yield_statement (yield and yield break).
6561 * driver.cs: New flag -v2 to turn on version 2 features.
6563 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6564 hashtable when v2 is enabled.
6566 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6568 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6569 there is already a namespace defined with this name.
6571 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6572 people upgraded their corlibs.
6574 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
6575 always use fully qualified types, no need to use the compiler
6578 (TypeManager.IsNamespace): Use binarysearch.
6580 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
6581 AddDelegate): I did not quite use the new IsValid API properly: I
6582 have to pass the short-name and the fullname. I was passing only
6583 the basename instead of the fullname sometimes.
6585 (TypeContainer.DefineType): call NamespaceClash.
6587 * interface.cs (Interface.DefineType): use NamespaceClash before
6590 * delegate.cs (Delegate.DefineType): use NamespaceClash before
6593 * enum.cs: (Enum.DefineType): use NamespaceClash before
6596 * typemanager.cs (: 3-line patch that gives us some tasty 11%
6597 speed increase. First, use the negative_hits cache when we get a
6598 negative. Second, add the type with its full original name
6599 instead of the new . and + encoded name (reflection uses + to
6600 separate type from a nested type). Use LookupTypeReflection
6601 directly which bypasses the type->name hashtable (that we already
6602 know does not contain the type.
6604 * decl.cs (DeclSpace.ResolveTypeExpr): track the
6605 location/container type.
6607 * driver.cs: When passing utf8, use directly the UTF8Encoding.
6609 2003-04-19 Miguel de Icaza <miguel@ximian.com>
6611 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
6613 * delegate.cs (NewDelegate.Resolve): Test whether an instance
6614 method is being referenced in the method group from a static
6615 context, and report error 120 if so.
6617 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
6620 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
6621 is created, we create the A namespace).
6623 * cs-parser.jay: A namespace also introduces a DeclarationFound.
6626 2003-04-18 Miguel de Icaza <miguel@ximian.com>
6628 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
6629 invocation to ModuleBuilder.GetType with the same values will
6630 return a new type instance, so we need to cache its return
6633 * expression.cs (Binary.ResolveOperator): Only allow the compare
6634 operators on enums if they are of the same type.
6636 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
6637 types of ValueType on their own case. Before we were giving them
6638 the same treatment as objects.
6640 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
6641 fullname. Short name is used to compare against container name.
6642 Fullname is used to check against defined namespace names.
6644 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
6645 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
6647 (Method.CheckBase): Call parent.
6648 (MemberBase.CheckBase): Check for protected members on sealed
6650 (PropertyBase.CheckBase): Call parent.
6651 (Field.Define): Call parent.
6653 * report.cs: Negative error codes are now mapped to 8000 - code,
6654 so that the display is render more nicely.
6656 * typemanager.cs: Do not use try/catch, instead report a regular
6659 (GetPointerType, GetReferenceType): These methods provide
6660 mechanisms to obtain the T* and T& from a T. We had the code
6661 previously scattered around the code base, and it also used
6662 TypeManager.LookupType that would go through plenty of caches.
6663 This one goes directly to the type source.
6665 In some places we did the Type.GetType followed by
6666 ModuleBuilder.GetType, but not in others, so this unifies the
6669 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
6670 statements now that we have namespace information.
6672 * typemanager.cs (IsNamespace): New method, returns whether the
6673 string presented is a namespace or not.
6675 (ComputeNamespaces): New public entry point, computes the list of
6676 available namespaces, using the GetNamespaces API call in Mono, or
6677 the slower version in MS.NET.
6679 Now before we start the semantic analysis phase, we have a
6680 complete list of namespaces including everything that the user has
6683 Deleted old code to cache namespaces in .nsc files.
6685 2003-04-17 Miguel de Icaza <miguel@ximian.com>
6687 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
6688 class/struct location definition Location for the implicit
6689 constructor location.
6691 (Operator.Define): Use the location of the operator for the
6692 implicit Method definition.
6694 (Constructor.Emit): use the constructor location for the implicit
6695 base initializer constructor.
6697 * ecore.cs: Remove ITypeExpression. This interface is now gone,
6698 and the Expression class now contains two new methods:
6700 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
6701 isolate type lookup from the rest of the resolution process.
6703 Since we use Expressions to hold type definitions due to the way
6704 we parse the input we have historically overloaded Resolve to
6705 perform the Type lookups if a special flag is passed. Now this is
6706 eliminated and two methods take their place.
6708 The differences in the two methods between xStep and xTerminal is
6709 that xStep is involved in our current lookup system that uses
6710 SimpleNames to compose a name, while xTerminal is used just to
6711 catch the case where the simplename lookup failed.
6713 2003-04-16 Miguel de Icaza <miguel@ximian.com>
6715 * expression.cs (ResolveMemberAccess): Remove redundant code.
6716 TypeExpr expressions are always born fully resolved.
6718 * interface.cs (PopulateMethod): Do not lookup the types twice.
6719 We were doing it once during SemanticAnalysis and once during
6722 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
6723 in local variable type definitions, were being returned as a
6724 SimpleName (we decomposed everything into a string), that is
6725 because primary_expression was being used instead of a type in the
6726 grammar (reduce/reduce conflicts).
6728 The part that was wrong is that we converted the expression into a
6729 string (an oversimplification in one hand, compounded with primary
6730 expressions doing string concatenation).
6736 Would return "A.B.C[]" as a SimpleName. This stopped things like
6737 using clauses from working on this particular context. And a type
6738 was being matched directly against "A.B.C[]".
6740 We now use the correct approach, and allow for ComposedCast to be
6741 part of the unary expression. So the "A.B.C []" become a composed
6742 cast of "A.B.C" (as a nested group of MemberAccess with a
6743 SimpleName at the end) plus the rank composition "[]".
6747 2003-04-10 Miguel de Icaza <miguel@ximian.com>
6749 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
6750 for the access level checking.
6752 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
6753 `TypeContainer container', because I kept getting confused when I
6754 was debugging this code.
6756 * expression.cs (Indexers): Instead of tracking getters/setters,
6757 we now track them in parallel. We create one arraylist less, but
6758 most importantly it is possible now for the LValue code to find a
6759 matching get for a set.
6761 (IndexerAccess.DoResolveLValue): Update the code.
6762 GetIndexersForType has been modified already to extract all the
6763 indexers from a type. The code assumed it did not.
6765 Also make the code set the correct return type for the indexer.
6766 This was fixed a long time ago for properties, but was missing for
6767 indexers. It used to be void_type.
6769 (Binary.Emit): Test first for doubles instead of
6770 floats, as they are more common.
6772 (Binary.EmitBranchable): Use the .un version of the branch opcodes
6773 when dealing with floats and the <=, >= operators. This fixes bug
6776 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
6777 to load the array value by emitting a load on the foreach variable
6778 type. This was incorrect.
6780 We now emit the code to load an element using the the array
6781 variable type, and then we emit the conversion operator.
6785 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
6787 * attribute.cs: Avoid allocation of ArrayLists in the common case.
6789 2003-04-09 Miguel de Icaza <miguel@ximian.com>
6791 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
6792 test for protection before we test for signatures.
6794 (MethodSignature.ToString): implement.
6796 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
6797 to the case where we reduced into a LongConstant.
6799 * decl.cs (CheckAccessLevel): If the type is an array, we can not
6800 depend on whether the information is acurrate, because the
6801 Microsoft runtime will always claim that the array type is public,
6802 regardless of the real state.
6804 If the type is a pointer, another problem happens: the type is
6805 reported as non-public in Microsoft.
6807 In both cases we have to call CheckAccessLevel recursively with
6808 the underlying type as the argument to be tested.
6810 2003-04-08 Miguel de Icaza <miguel@ximian.com>
6812 * assign.cs (Assign.Emit): If we are dealing with a compound
6813 assignment expression, we should use the code path that stores the
6814 intermediate result in a temporary value. This fixes #40903.
6816 *expression.cs (Indirection.ToString): Provide ToString method for
6819 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
6821 * class.cs: Null out fields holding references to Block objects so
6822 they can be garbage collected.
6824 * expression.cs (OverloadResolve): Remove unused local.
6826 2003-04-07 Martin Baulig <martin@ximian.com>
6828 * codegen.cs (EmitContext.CurrentFile): New public field.
6829 (EmitContext.Mark): Use the CurrentFile to check whether the
6830 location is in the correct file.
6831 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
6833 2003-04-07 Martin Baulig <martin@ximian.com>
6835 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
6837 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
6838 location. [FIXME: The location argument which gets passed to this
6839 method is sometimes wrong!]
6841 2003-04-07 Nick Drochak <ndrochak@gol.com>
6843 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
6845 2003-04-07 Miguel de Icaza <miguel@ximian.com>
6847 * expression.cs (Indirection.EmitAssign): We were using the
6848 temporary, but returning immediately instead of continuing the
6851 2003-04-06 Martin Baulig <martin@ximian.com>
6853 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
6854 if it's a nested child, but also deriving from the outer class.
6857 * typemanager.cs (IsNestedChildOf): Make this work if it's a
6858 nested child, but also deriving from the outer class. See
6860 (FilterWithClosure): We may access private members of the outer
6861 class if we're a nested child and deriving from the outer class.
6862 (RealMemberLookup): Only set `closure_private_ok' if the
6863 `original_bf' contained BindingFlags.NonPublic.
6865 2003-04-05 Martin Baulig <martin@ximian.com>
6867 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
6869 2003-04-02 Miguel de Icaza <miguel@ximian.com>
6871 * class.cs (Event.Define): Do not allow abstract events to have
6874 2003-04-01 Miguel de Icaza <miguel@ximian.com>
6876 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
6877 block in event declarations.
6879 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
6880 value type, get its address.
6882 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
6883 leaving a class on the stack instead of a boolean value (int
6884 0/1). Change the code so we compare against null, and then the
6885 result against zero.
6887 * class.cs (TypeContainer.GetClassBases): We were checking for the
6888 parent class being sealed too late.
6890 * expression.cs (Binary.Emit): For <= and >= when dealing with
6891 floating point values, use cgt.un and clt.un instead of cgt and
6894 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
6896 * statement.cs: Apply the same optimization as MS: skip the
6897 GetEnumerator returning an IEnumerator, and use the one returning a
6898 CharEnumerator instead. This allows us to avoid the try-finally block
6901 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
6903 * cs-parser.jay: Attributes cannot be applied to
6904 namespaces. Fixes #40473
6906 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6909 (Add*): check if the name is valid using the full name for constants,
6910 fields, properties and events.
6912 2003-03-28 Miguel de Icaza <miguel@ximian.com>
6914 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
6915 char constants to be part of the enumeration.
6917 * expression.cs (Conditional.DoResolve): Add support for operator
6918 true. Implements the missing functionality from 14.12
6920 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
6921 operator true/false as required by the spec.
6923 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
6924 implicit conversion to boolean.
6926 * statement.cs (Statement.ResolveBoolean): A boolean expression is
6927 also one where the type implements `operator true'.
6929 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
6930 get an expression that will invoke operator true based on an
6933 (GetConversionOperators): Removed the hack that called op_True
6936 (Expression.ResolveBoolean): Move this from Statement.
6938 2003-03-17 Miguel de Icaza <miguel@ximian.com>
6940 * ecore.cs (FieldExpr): do not allow initialization of initonly
6941 fields on derived classes
6943 2003-03-13 Martin Baulig <martin@ximian.com>
6945 * statement.cs (Block.Emit): Call ig.BeginScope() and
6946 ig.EndScope() when compiling with debugging info; call
6947 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
6949 2003-03-08 Miguel de Icaza <miguel@ximian.com>
6951 * expression.cs (Indexers): Do not construct immediately, allow
6952 for new members to be appended as we go. Fixes 38143
6954 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6956 * expression.cs: save/restore context when resolving an unchecked
6959 2003-03-05 Miguel de Icaza <miguel@ximian.com>
6961 * cfold.cs: Catch division by zero in modulus operator during
6964 2003-03-03 Miguel de Icaza <miguel@ximian.com>
6966 * interface.cs (Interface.DefineMembers): Avoid defining members
6969 2003-02-27 Miguel de Icaza <miguel@ximian.com>
6971 * driver.cs: handle the +/- options for -noconfig
6973 * statement.cs (Unckeched.Resolve): Also track the state of
6974 unchecked in the Resolve phase.
6976 2003-02-27 Martin Baulig <martin@ximian.com>
6978 * ecore.cs (Expression.MemberLookup): Don't create a
6979 MethodGroupExpr for something which is not a method. Fixes #38291.
6981 2003-02-25 Miguel de Icaza <miguel@ximian.com>
6983 * class.cs (MemberBase.CheckParameters): Also check that the type
6984 is unmanaged if it is a pointer.
6986 * expression.cs (SizeOf.Resolve): Add location information.
6988 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
6989 a managed type is declared.
6991 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
6992 parameter modifiers as well. Fixes bug 38606
6994 * class.cs: Very sad. Am backing out the speed up changes
6995 introduced by the ArrayList -> Array in the TypeContainer, as they
6996 were not actually that much faster, and introduced a bug (no error
6997 reports on duplicated methods).
6999 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7000 source first, this will guarantee that we have a valid expression
7001 before calling in lower levels functions that will require a
7002 resolved object. Then use this original_source in the
7003 target.ResolveLValue instead of the original source that was
7006 Another change. Use target.Resolve instead of LValueResolve.
7007 Although we are resolving for LValues, we will let the Assign code
7008 take care of that (it will be called again from Resolve). This
7009 basically allows code like this:
7011 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7012 class Y { void A (X x) { x [0] += o; }
7014 The problem was that the indexer was trying to resolve for
7015 set_Item (idx, object o) and never finding one. The real set_Item
7016 was set_Item (idx, X). By delaying the process we get the right
7021 2003-02-23 Martin Baulig <martin@ximian.com>
7023 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7024 while calling DoEmit ().
7026 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7027 source files; if you use the #line directive inside a method, the
7028 compiler stops emitting line numbers for the debugger until it
7029 reaches the end of the method or another #line directive which
7030 restores the original file.
7032 2003-02-23 Martin Baulig <martin@ximian.com>
7034 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7036 2003-02-23 Martin Baulig <martin@ximian.com>
7038 * statement.cs (Block.AddChildVariableNames): We need to call this
7039 recursively, not just for our immediate children.
7041 2003-02-23 Martin Baulig <martin@ximian.com>
7043 * class.cs (Event.Define): Always make the field private, like csc does.
7045 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7046 actually work, fixes bug #37521.
7048 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7050 * delegate.cs: When creating the various temporary "Parameters"
7051 classes, make sure that we call the ComputeAndDefineParameterTypes
7052 on those new parameters (just like we do with the formal ones), to
7053 allow them to be resolved in the context of the DeclSpace.
7055 This fixes the bug that Dick observed in Bugzilla #38530.
7057 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7059 * expression.cs (ResolveMemberAccess): When resolving a constant,
7060 do not attempt to pull a constant if the value was not able to
7061 generate a valid constant.
7063 * const.cs (LookupConstantValue): Do not report more errors than required.
7065 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7067 * expression.cs: fixes bug #38328.
7069 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7071 * class.cs: Changed all the various members that can be part of a
7072 class from being an ArrayList to be an Array of the right type.
7073 During the DefineType type_list, interface_list, delegate_list and
7074 enum_list are turned into types, interfaces, delegates and enums
7077 And during the member population, indexer_list, event_list,
7078 constant_list, field_list, instance_constructor_list, method_list,
7079 operator_list and property_list are turned into their real arrays.
7081 Although we could probably perform this operation earlier, for
7082 good error reporting we need to keep the lists and remove the
7083 lists for longer than required.
7085 This optimization was triggered by Paolo profiling the compiler
7086 speed on the output of `gen-sample-program.pl' perl script.
7088 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7089 not crash in methods like MemberLookupFailed that use this field.
7091 This problem arises when the compiler fails to resolve a type
7092 during interface type definition for example.
7094 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7096 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7097 inherit from System.Object, so we have to stop at null, not only
7098 when reaching System.Object.
7100 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7102 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7103 DeclaredOnly because the parent indexer might have had a different
7104 name, but did not loop until the top of the hierarchy was reached.
7106 The problem this one fixes is 35492: when a class implemented an
7107 indexer from an interface, we were getting the interface method
7108 (which was abstract) and we were flagging an error (can not invoke
7111 This also keeps bug 33089 functioning, and test-148 functioning.
7113 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7114 out if a method is special is to see if it is declared in a
7115 property or event, or whether it is one of the predefined operator
7116 names. This should fix correctly #36804.
7118 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7120 The goal here is to remove the dependency on EmptyCast.Peel ().
7121 Killing it completely.
7123 The problem is that currently in a number of places where
7124 constants are expected, we have to "probe" for an EmptyCast, and
7125 Peel, which is not the correct thing to do, as this will be
7126 repetitive and will likely lead to errors.
7128 The idea is to remove any EmptyCasts that are used in casts that
7129 can be reduced to constants, so we only have to cope with
7132 This bug hunt was triggered by Bug 37363 and the desire to remove
7133 the duplicate pattern where we were "peeling" emptycasts to check
7134 whether they were constants. Now constants will always be
7137 * ecore.cs: Use an enumconstant here instead of wrapping with
7140 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7141 throwing me off. By handling this we can get rid of a few hacks.
7143 * statement.cs (Switch): Removed Peel() code.
7145 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7147 * class.cs: Location information for error 508
7149 * expression.cs (New.DoResolve): Add a guard against double
7150 resolution of an expression.
7152 The New DoResolve might be called twice when initializing field
7153 expressions (see EmitFieldInitializers, the call to
7154 GetInitializerExpression will perform a resolve on the expression,
7155 and later the assign will trigger another resolution
7157 This leads to bugs (#37014)
7159 * delegate.cs: The signature for EndInvoke should contain any ref
7160 or out parameters as well. We were not doing this in the past.
7162 * class.cs (Field.Define): Do not overwrite the type definition
7163 inside the `volatile' group. Turns out that volatile enumerations
7164 were changing the type here to perform a validity test, which
7167 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7169 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7170 and structs, we do not want to load the instance variable
7172 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7173 enum_type has to be handled like an object reference (implicit
7174 conversions exists from this to object), but the regular IsClass
7175 and IsValueType tests will never return true for this one.
7177 Also we use TypeManager.IsValueType instead of type.IsValueType,
7178 just for consistency with the rest of the code (this is only
7179 needed if we ever use the construct exposed by test-180.cs inside
7180 corlib, which we dont today).
7182 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7184 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7187 2003-02-09 Martin Baulig <martin@ximian.com>
7189 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7190 (Namespace.DefineNamespaces): New static public method; this is
7191 called when we're compiling with debugging to add all namespaces
7194 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7195 pass it to the Namespace's .ctor.
7197 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7198 and MethodBase arguments; pass the namespace ID to the symwriter;
7199 pass the MethodBase instead of the token to the symwriter.
7200 (SymbolWriter.DefineNamespace): New method to add a namespace to
7203 2003-02-09 Martin Baulig <martin@ximian.com>
7205 * symbolwriter.cs: New file. This is a wrapper around
7206 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7207 methods here in near future.
7209 2003-02-09 Martin Baulig <martin@ximian.com>
7211 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7212 ILGenerator.MarkSequencePoint() which are actually used by the
7215 2003-02-09 Martin Baulig <martin@ximian.com>
7217 * location.cs (SourceFile): New public sealed class. This
7218 contains the name and an index which is used in the location's token.
7219 (Location): Reserve an appropriate number of bits in the token for
7220 the source file instead of walking over that list, this gives us a
7221 really huge performance improvement when compiling with debugging.
7223 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7224 `SourceFile' argument instead of a string.
7225 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7226 but don't parse/tokenize here, we need to generate the list of all
7227 source files before we do that.
7228 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7231 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7232 instead of a string.
7234 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7237 2003-02-09 Martin Baulig <martin@ximian.com>
7239 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7240 filename on `#line default'.
7242 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7244 * statement.cs: don't clear the pinned var when the fixed statement
7245 returns from the method (fixes bug#37752).
7247 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7249 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7252 2003-02-07 Martin Baulig <martin@ximian.com>
7254 * driver.cs: Removed the `--debug-args' command line argument.
7256 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7257 automatically by the AsssemblyBuilder.
7258 (CodeGen.InitializeSymbolWriter): We don't need to call any
7259 initialization function on the symbol writer anymore. This method
7260 doesn't take any arguments.
7262 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7264 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7265 from referenced assemblies as well.
7267 2003-02-02 Martin Baulig <martin@ximian.com>
7269 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7271 2003-02-02 Martin Baulig <martin@ximian.com>
7273 * class.cs (Constructor.Emit): Open the symbol writer before
7274 emitting the constructor initializer.
7275 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7276 single-stepping through constructor initializers.
7278 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7280 * class.cs: Handle error 549: do not allow virtual methods in
7283 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7285 * decl.cs: Check access levels when resolving types
7287 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7289 * statement.cs: Add parameters and locals set in catch blocks that might
7290 return to set vector
7292 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7294 * class.cs (Operator): Set the SpecialName flags for operators.
7296 * expression.cs (Invocation.DoResolve): Only block calls to
7297 accessors and operators on SpecialName methods.
7299 (Cast.TryReduce): Handle conversions from char constants.
7302 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7304 * statement.cs: small memory and time optimization in FlowBranching.
7306 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7308 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7309 problem that the last fix but in the other sid (Set).
7311 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7312 access when there is no indexer in the hierarchy.
7314 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7316 * class.cs: Combine some if statements.
7318 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7320 * driver.cs: fixed bug #37187.
7322 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7324 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7325 any indexer, it's needed to build a list with all the indexers in the
7326 hierarchy (AllGetters), else we have problems. Fixes #35653.
7328 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7330 * class.cs (MethodData.Define): It is wrong for an interface
7331 implementation to be static in both cases: explicit and implicit.
7332 We were only handling this in one case.
7334 Improve the if situation there to not have negations.
7336 * class.cs (Field.Define): Turns out that we do not need to check
7337 the unsafe bit on field definition, only on usage. Remove the test.
7339 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7341 * driver.cs: use assembly.Location instead of Codebase (the latest
7342 patch made mcs fail when using MS assemblies).
7344 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7346 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7347 get the path to *corlib.dll.
7349 2003-01-21 Nick Drochak <ndrochak@gol.com>
7353 * typemanager.cs: Remove compiler warnings
7355 2003-01-20 Duncan Mak <duncan@ximian.com>
7357 * AssemblyInfo.cs: Bump the version number to 0.19.
7359 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7361 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7363 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7365 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7367 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7369 * cs-parser.jay: Small fix: we were not comparing the constructor
7370 name correctly. Thanks to Zoltan for the initial pointer.
7372 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7374 * cs-tokenizer.cs: Set file name when specified with #line
7376 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7378 * cs-parser.jay: Only perform the constructor checks here if we
7379 are named like the class; This will help provider a better
7380 error. The constructor path is taken when a type definition is
7381 not found, but most likely the user forgot to add the type, so
7382 report that rather than the constructor error.
7384 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7386 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7389 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7391 * cs-parser.jay: Add cleanup call.
7393 2003-01-13 Duncan Mak <duncan@ximian.com>
7395 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7396 consistent with other methods.
7398 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7400 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7402 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7404 * attribute.cs: only set GuidAttr to true when we have a
7407 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7411 * typemanager.cs: fixes to allow mcs compile corlib with the new
7412 Type.IsSubclassOf fix.
7414 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7416 * expression.cs (LocalVariableReference.DoResolve): Classify a
7417 constant as a value, not as a variable. Also, set the type for
7420 * cs-parser.jay (fixed_statement): take a type instead of a
7421 pointer_type, so we can produce a better error message later.
7423 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7426 (For.DoEmit): Make inifinite loops have a
7427 non-conditional branch back.
7429 (Fixed.DoEmit): First populate the pinned variables, then emit the
7430 statement, then clear the variables. Before I was emitting the
7431 code once for each fixed piece.
7434 2003-01-08 Martin Baulig <martin@ximian.com>
7436 * statement.cs (FlowBranching.MergeChild): A break in a
7437 SWITCH_SECTION does not leave a loop. Fixes #36155.
7439 2003-01-08 Martin Baulig <martin@ximian.com>
7441 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7442 lives in the same number space than `param_map'. Fixes #36154.
7444 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7446 * cs-parser.jay (constructor_declaration): Set the
7447 Constructor.ModFlags before probing for it. This makes the
7448 compiler report 514, 515 and 132 (the code was there, but got
7451 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7452 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7453 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7455 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7457 * enum.cs: create the enum static fields using the enum type.
7459 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7461 * class.cs: don't try to create the ParamBuilder for the return
7462 type if it's not needed (and handle it breaking for the ms runtime
7465 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7467 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7469 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7471 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7472 the command. This showed up while compiling the JANET source
7473 code, which used \r as its only newline separator.
7475 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7477 * class.cs (Method.Define): If we are an operator (because it
7478 reuses our code), then set the SpecialName and HideBySig. #36128
7480 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7482 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7483 exception, report error 120 `object reference required'.
7485 * driver.cs: Add --pause option, used during to measure the size
7486 of the process as it goes with --timestamp.
7488 * expression.cs (Invocation.DoResolve): Do not allow methods with
7489 SpecialName to be invoked.
7491 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7493 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7494 number before adding it.
7496 2002-12-21 Ravi Pratap <ravi@ximian.com>
7498 * ecore.cs (StandardImplicitConversion): When in an unsafe
7499 context, we allow conversion between void * to any other pointer
7500 type. This fixes bug #35973.
7502 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7504 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7505 is not thrown when extensionless outputs are used
7507 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7509 * rootcontext.cs: fixed compilation of corlib.
7511 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7513 * attribute.cs (Attributes.Contains): Add new method.
7515 * class.cs (MethodCore.LabelParameters): if the parameter is an
7516 `out' parameter, check that no attribute `[In]' has been passed.
7518 * enum.cs: Handle the `value__' name in an enumeration.
7520 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7522 * decl.cs: Added special case to allow overrides on "protected
7525 2002-12-18 Ravi Pratap <ravi@ximian.com>
7527 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7528 since it makes much more sense.
7530 (Attributes.ctor): Don't require a Location parameter.
7532 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7534 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7535 since we already have that information per attribute.
7537 * everywhere : make appropriate changes.
7539 * class.cs (LabelParameters): Write the code which actually
7540 applies attributes to the return type. We can't do this on the MS
7541 .NET runtime so we flag a warning in the case an exception is
7544 2002-12-18 Miguel de Icaza <miguel@ximian.com>
7546 * const.cs: Handle implicit null conversions here too.
7548 2002-12-17 Ravi Pratap <ravi@ximian.com>
7550 * class.cs (MethodCore.LabelParameters): Remove the extra
7551 Type [] parameter since it is completely unnecessary. Instead
7552 pass in the method's attributes so that we can extract
7553 the "return" attribute.
7555 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7557 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7558 of ignoring it and letting the compile continue.
7560 * typemanager.cs (ChangeType): use an extra argument to return an
7561 error condition instead of throwing an exception.
7563 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7565 * expression.cs (Unary.TryReduce): mimic the code for the regular
7566 code path. Perform an implicit cast in the cases where we can
7567 implicitly convert to one of the integral types, and then reduce
7568 based on that constant. This fixes bug #35483.
7570 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7572 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7574 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7576 * namespace.cs: fixed bug #35489.
7578 2002-12-12 Miguel de Icaza <miguel@ximian.com>
7580 * class.cs: Remove some dead code.
7582 * cs-parser.jay: Estimate the number of methods needed
7583 (RootContext.MethodCount);
7585 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
7586 numbers instead of StringBuilders.
7588 * support.cs (PtrHashtable): Add constructor with initial size;
7589 We can now reduce reallocations of the method table.
7591 2002-12-10 Ravi Pratap <ravi@ximian.com>
7593 * attribute.cs (ApplyAttributes): Keep track of the emitted
7594 attributes on a per-target basis. This fixes bug #35413.
7596 2002-12-10 Miguel de Icaza <miguel@ximian.com>
7598 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
7599 default to the Windows 1252 encoding.
7601 (UnixParseOption): Support version, thanks to Alp for the missing
7604 * AssemblyInfo.cs: Add nice assembly information.
7606 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
7609 * cs-parser.jay: Allow a trailing comma before the close bracked
7610 in the attribute_section production.
7612 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
7613 address of the instance was being taken, I will take this out,
7614 because we take the address of the object immediately here.
7616 2002-12-09 Ravi Pratap <ravi@ximian.com>
7618 * typemanager.cs (AreMultipleAllowed): Take care of the most
7619 obvious case where attribute type is not in the current assembly -
7622 2002-12-08 Miguel de Icaza <miguel@ximian.com>
7624 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
7625 definitions, instead of doing that afterwards.
7627 Also we use a nice little hack, depending on the constructor, we
7628 know if we are a "composed" name or a simple name. Hence, we
7629 avoid the IndexOf test, and we avoid
7631 * codegen.cs: Add code to assist in a bug reporter to track down
7632 the source of a compiler crash.
7634 2002-12-07 Ravi Pratap <ravi@ximian.com>
7636 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
7637 types have been emitted for a given element and flag an error
7638 if something which does not have AllowMultiple set is used more
7641 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
7642 attribute types and their corresponding AllowMultiple properties
7644 (AreMultipleAllowed): Check the property for a given type.
7646 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
7647 property in the case we have a TypeContainer.
7649 (Attributes.AddAttribute): Detect duplicates and just skip on
7650 adding them. This trivial fix catches a pretty gross error in our
7651 attribute emission - global attributes were being emitted twice!
7653 Bugzilla bug #33187 is now fixed.
7655 2002-12-06 Miguel de Icaza <miguel@ximian.com>
7657 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
7660 * expression.cs (Binary.ResolveOperator): I can only use the
7661 Concat (string, string, string) and Concat (string, string,
7662 string, string) if the child is actually a concatenation of
7665 2002-12-04 Miguel de Icaza <miguel@ximian.com>
7667 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
7668 context where we need a 2-character lookahead.
7670 * pending.cs (PendingImplementation): Rework so we can keep track
7671 of interface types all the time, and flag those which were
7672 implemented by parents as optional.
7674 2002-12-03 Miguel de Icaza <miguel@ximian.com>
7676 * expression.cs (Binary.ResolveOperator): Use
7677 String.Concat(string,string,string) or
7678 String.Concat(string,string,string,string) when possible.
7680 * typemanager: More helper methods.
7683 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
7685 * pending.cs: remove the bogus return from GetMissingInterfaces()
7686 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
7688 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7690 * namespace.cs: avoid duplicated 'using xxx' being added to
7691 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
7692 when we get more than one 'using' statement for the same namespace.
7693 Report a CS0105 warning for it.
7695 2002-11-30 Miguel de Icaza <miguel@ximian.com>
7697 * cs-tokenizer.cs (consume_identifier): use read directly, instead
7698 of calling getChar/putback, uses internal knowledge of it.
7700 (xtoken): Reorder tokenizer so most common patterns are checked
7701 first. This reduces the compilation time in another 5% (from 8.11s
7702 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
7704 The parsing time is 22% of the compilation in mcs, and from that
7705 64% is spent on the tokenization process.
7707 I tried using a binary search for keywords, but this is slower
7708 than the hashtable. Another option would be to do a couple of
7711 * Not use a StringBuilder, instead use an array of chars,
7712 with a set value. Notice that this way we could catch
7713 the 645 error without having to do it *afterwards*.
7715 * We could write a hand-parser to avoid the hashtable
7716 compares altogether.
7718 The identifier consumption process takes 37% of the tokenization
7719 time. Another 15% is spent on is_number. 56% of the time spent
7720 on is_number is spent on Int64.Parse:
7722 * We could probably choose based on the string length to
7723 use Int32.Parse or Int64.Parse and avoid all the 64-bit
7726 Another 3% is spend on wrapping `xtoken' in the `token' function.
7728 Handle 0xa0 as whitespace (#34752)
7730 2002-11-26 Miguel de Icaza <miguel@ximian.com>
7732 * typemanager.cs (IsCLRType): New routine to tell whether a type
7733 is one of the builtin types.
7735 Maybe it needs to use TypeCodes to be faster. Maybe we could use
7736 typecode in more places instead of doing pointer comparissions.
7737 We could leverage some knowledge about the way the typecodes are
7740 New code to cache namespaces in assemblies, it is currently not
7741 invoked, to be used soon.
7743 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
7745 * expression.cs (Binary.ResolveOperator): specially handle
7746 strings, and do not perform user-defined operator overloading for
7749 2002-11-24 Miguel de Icaza <miguel@ximian.com>
7751 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
7752 internalcall as it is a pretty simple operation; Avoid whenever
7753 possible to call Char.IsLetter.
7755 (consume_identifier): Cut by half the number of
7756 hashtable calls by merging the is_keyword and GetKeyword behavior.
7758 Do not short-circuit, because if we do, we
7759 report errors (ie, #if false && true would produce an invalid
7763 2002-11-24 Martin Baulig <martin@ximian.com>
7765 * expression.cs (Cast.TryReduce): If we're in checked syntax,
7766 check constant ranges and report a CS0221. Fixes #33186.
7768 2002-11-24 Martin Baulig <martin@ximian.com>
7770 * cs-parser.jay: Make this work for uninitialized variable
7771 declarations in the `for' initializer. Fixes #32416.
7773 2002-11-24 Martin Baulig <martin@ximian.com>
7775 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
7776 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
7778 2002-11-24 Martin Baulig <martin@ximian.com>
7780 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
7781 argument; if true, we also check for user-defined conversions.
7782 This is only needed if both arguments are of a user-defined type.
7783 Fixes #30443, added test-175.cs.
7784 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
7786 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
7788 2002-11-24 Martin Baulig <martin@ximian.com>
7790 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
7791 function to get the store opcode.
7792 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
7793 only emit the Ldelema if the store opcode is Stobj. You must run
7794 both test-34 and test-167 to test this. Fixes #34529.
7796 2002-11-23 Martin Baulig <martin@ximian.com>
7798 * ecore.cs (Expression.MemberLookup): Added additional
7799 `qualifier_type' argument which is used when we're being called
7800 from MemberAccess.DoResolve() and null if we're called from a
7802 (Expression.MemberLookupFailed): New method to report errors; this
7803 does the CS1540 check and reports the correct error message.
7805 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
7806 argument for the CS1540 check and redone the way how we're dealing
7807 with private members. See the comment in the source code for details.
7808 (FilterWithClosure): Reverted this back to revision 1.197; renamed
7809 `closure_start_type' to `closure_qualifier_type' and check whether
7810 it's not null. It was not this filter being broken, it was just
7811 being called with the wrong arguments.
7813 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
7814 and pass it the correct `qualifier_type'; this also does the error
7817 2002-11-22 Miguel de Icaza <miguel@ximian.com>
7819 * expression.cs (Invocation.EmitParams): If the we are dealing
7820 with a non-built-in value type, load its address as well.
7822 (ArrayCreation): Use a a pretty constant instead
7823 of the hardcoded value 2. Use 6 instead of 2 for the number of
7824 static initializers.
7826 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
7827 because they are not really value types, just glorified integers.
7829 * driver.cs: Do not append .exe, the CSC compiler does not do it.
7831 * ecore.cs: Remove redundant code for enumerations, make them use
7832 the same code path as everything else, fixes the casting issue
7833 with enumerations in Windows.Forms.
7835 * attribute.cs: Do only cast to string if it is a string, the
7836 validation happens later.
7838 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
7839 people upgrade their corlibs.
7841 * ecore.cs: Oops, enumerations were not following the entire code path
7843 2002-11-21 Miguel de Icaza <miguel@ximian.com>
7845 * typemanager.cs (FilterWithClosure): Commented out the test for
7846 1540 in typemanager.cs, as it has problems when accessing
7847 protected methods from a parent class (see test-174.cs).
7849 * attribute.cs (Attribute.ValidateGuid): new method.
7850 (Attribute.Resolve): Use above.
7852 2002-11-19 Miguel de Icaza <miguel@ximian.com>
7854 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
7856 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
7857 handling for enumerations, as we only needed the TypeContainer
7858 functionality to begin with (this is required for the fix below to
7859 work for enums that reference constants in a container class for
7862 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
7864 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
7865 a valid TypeBuilder to perform lookups on.o
7867 * class.cs (InheritableMemberSignatureCompare): Use true in the
7868 call to GetGetMethod and GetSetMethod, because we are comparing
7869 the signature, and we need to get the methods *even* if they are
7872 (PropertyBase.CheckBase): ditto.
7874 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
7875 GotoCase.Resolve): Use Peel on EmpytCasts.
7877 * ecore.cs (EmptyCast): drop child, add Peel method.
7879 2002-11-17 Martin Baulig <martin@ximian.com>
7881 * ecore.cs (EmptyCast.Child): New public property.
7883 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
7884 label resolved to an EmptyCast. Fixes #34162.
7885 (GotoCase.Resolve): Likewise.
7886 (Block.EmitMeta): Likewise.
7888 2002-11-17 Martin Baulig <martin@ximian.com>
7890 * expression.cs (Invocation.BetterConversion): Prefer int over
7891 uint; short over ushort; long over ulong for integer literals.
7892 Use ImplicitConversionExists instead of StandardConversionExists
7893 since we also need to check for user-defined implicit conversions.
7894 Fixes #34165. Added test-173.cs.
7896 2002-11-16 Martin Baulig <martin@ximian.com>
7898 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
7899 with the `true' and `false' literals. Fixes #33151.
7901 2002-11-16 Martin Baulig <martin@ximian.com>
7903 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
7904 October 22nd; don't do the cs1540 check for static members.
7906 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
7907 now using our own filter here and doing the cs1540 check again.
7909 2002-11-16 Martin Baulig <martin@ximian.com>
7911 * support.cs (InternalParameters): Don't crash if we don't have
7912 any fixed parameters. Fixes #33532.
7914 2002-11-16 Martin Baulig <martin@ximian.com>
7916 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
7917 when looking up static methods to make this work on Windows.
7920 2002-11-16 Martin Baulig <martin@ximian.com>
7922 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
7923 a setter rather than using PropertyInfo.CanWrite.
7925 2002-11-15 Nick Drochak <ndrochak@gol.com>
7927 * class.cs: Allow acces to block member by subclasses. Fixes build
7930 2002-11-14 Martin Baulig <martin@ximian.com>
7932 * class.cs (Constructor.Emit): Added the extern/block check.
7935 2002-11-14 Martin Baulig <martin@ximian.com>
7937 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
7938 iteration while looking for indexers, this is needed because the
7939 indexer may have a different name in our base classes. Fixed the
7940 error reporting (no indexers at all, not get accessor, no
7941 overloaded match). Fixes bug #33089.
7942 (IndexerAccess.DoResolveLValue): Likewise.
7944 2002-11-14 Martin Baulig <martin@ximian.com>
7946 * class.cs (PropertyBase.CheckBase): Make this work for multiple
7947 indexers. Fixes the first part of bug #33089.
7948 (MethodSignature.InheritableMemberSignatureCompare): Added support
7951 2002-11-13 Ravi Pratap <ravi@ximian.com>
7953 * attribute.cs (Attribute.Resolve): Catch the
7954 NullReferenceException and report it since it isn't supposed to
7957 2002-11-12 Miguel de Icaza <miguel@ximian.com>
7959 * expression.cs (Binary.EmitBranchable): Also handle the cases for
7960 LogicalOr and LogicalAnd that can benefit from recursively
7961 handling EmitBranchable. The code now should be nice for Paolo.
7963 2002-11-08 Miguel de Icaza <miguel@ximian.com>
7965 * typemanager.cs (LookupType): Added a negative-hit hashtable for
7966 the Type lookups, as we perform quite a number of lookups on
7967 non-Types. This can be removed once we can deterministically tell
7968 whether we have a type or a namespace in advance.
7970 But this might require special hacks from our corlib.
7974 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
7975 and double which avoids a conversion from an integer to a double.
7977 * expression.cs: tiny optimization, avoid calling IsConstant,
7978 because it effectively performs the lookup twice.
7980 2002-11-06 Miguel de Icaza <miguel@ximian.com>
7982 But a bogus return here to keep the semantics of the old code
7983 until the Mono runtime is fixed.
7985 * pending.cs (GetMissingInterfaces): New method used to remove all
7986 the interfaces that are already implemented by our parent
7987 classes from the list of pending methods.
7989 * interface.cs: Add checks for calls after ResolveTypeExpr.
7991 2002-11-05 Miguel de Icaza <miguel@ximian.com>
7993 * class.cs (Class.Emit): Report warning 67: event not used if the
7994 warning level is beyond 3.
7996 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
7997 being a NullLiteral.
7999 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8002 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8003 path that might fail if a type can not be resolved.
8005 * expression.cs (Binary.Emit): Emit unsigned versions of the
8008 * driver.cs: use error 5.
8010 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8012 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8014 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8016 * cs-parser.jay (switch_section): A beautiful patch from Martin
8017 Baulig that fixed 33094.
8019 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8021 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8022 Check whether the base is abstract and report an error if so.
8024 * expression.cs (IndexerAccess.DoResolveLValue,
8025 IndexerAccess.DoResolve): ditto.
8027 (Invocation.DoResolve): ditto.
8029 (Invocation.FullMethodDesc): Improve the report string.
8031 * statement.cs (Block): Eliminate IsVariableDefined as it is
8032 basically just a wrapper for GetVariableInfo.
8034 * ecore.cs (SimpleName): Use new
8036 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8037 type, as we return the actual parameter ref/unref state on a
8040 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8042 * support.cs: Return proper flags REF/OUT fixing the previous
8045 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8046 not used to mean `ref' but `ref or out' in ParameterReference
8048 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8049 full type signature instead of calling TypeManger.CSharpName
8052 * support.cs (InternalParameters.ParameterDesc): Do not compare
8053 directly to the modflags, because REF/OUT will actually be bitsets
8056 * delegate.cs (VerifyMethod): Check also the modifiers.
8058 * cs-tokenizer.cs: Fix bug where floating point values with an
8059 exponent where a sign was missing was ignored.
8061 * driver.cs: Allow multiple assemblies to be specified in a single
8064 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8066 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8067 because identifiers after a parenthesis would end up in this kind
8068 of production, and we needed to desamiguate it for having casts
8071 (UserDefinedType *) xxx
8073 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8075 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8076 we should set on the Bindingflags.NonPublic, but not turn on
8077 private_ok. private_ok controls whether a Private member is
8078 returned (this is chekced on the filter routine), while the
8079 BindingFlags.NonPublic just controls whether private/protected
8080 will be allowed. This fixes the problem part of the problem of
8081 private properties being allowed to be used in derived classes.
8083 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8084 so we can call the children DoResolveLValue method (this will
8085 properly signal errors on lvalue assignments to base properties)
8087 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8088 getter are null, and we have a property info, we know that this
8089 happened because the lookup failed, so we report an error 122 for
8090 protection level violation.
8092 We also silently return if setter and getter are null in the
8093 resolve functions, this condition only happens if we have flagged
8094 the error before. This is the other half of the problem.
8096 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8097 not have accessibility information, that is why we were returning
8098 true in the filter function in typemanager.cs.
8100 To properly report 122 (property is inaccessible because of its
8101 protection level) correctly, we report this error in ResolveAccess
8102 by failing if both the setter and the getter are lacking (ie, the
8105 DoResolve and DoLResolve have been modified to check for both
8106 setter/getter being null and returning silently, the reason being
8107 that I did not want to put the knowledge about this error in upper
8110 int old = Report.Errors;
8111 x = new PropertyExpr (...);
8112 if (old != Report.Errors)
8117 So the property expr is returned, but it is invalid, so the error
8118 will be flagged during the resolve process.
8120 * class.cs: Remove InheritablePropertySignatureCompare from the
8121 class, as we no longer depend on the property signature to compute
8122 whether it is possible to implement a method or not.
8124 The reason is that calling PropertyInfo.GetGetMethod will return
8125 null (in .NET, in Mono it works, and we should change this), in
8126 cases where the Get Method does not exist in that particular
8131 class X { public virtual int A { get { return 1; } } }
8133 class Z : Y { public override int A { get { return 2; } } }
8135 Would fail in Z because the parent (Y) would not have the property
8136 defined. So we avoid this completely now (because the alternative
8137 fix was ugly and slow), and we now depend exclusively on the
8140 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8141 reference method, instead of using the property.
8143 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8144 routines are gone now.
8146 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8147 names, they were incorrectly named.
8149 * cs-tokenizer.cs: Return are more gentle token on failure.
8151 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8152 had an out-of-sync index variable, which caused it to remove from
8153 the list of pending methods the wrong method sometimes.
8155 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8157 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8158 CanWrite, because those refer to this particular instance of the
8159 property, and do not take into account the fact that we can
8160 override single members of a property.
8162 Constructor requires an EmitContext. The resolution process does
8163 not happen here, but we need to compute the accessors before,
8164 because the resolution does not always happen for properties.
8166 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8167 subclass, before we did not update this flag, but we did update
8170 (GetAccessors): Drop this routine, as it did not work in the
8171 presence of partially overwritten set/get methods.
8173 Notice that this broke the cs1540 detection, but that will require
8176 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8180 * driver.cs: issue a warning instead of an error if we don't support
8181 debugging for the platform. Also ignore a couple of errors that may
8182 arise when trying to write the symbols. Undo my previous patch.
8184 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8186 * driver.cs: ignore /debug switch except for Unix platforms.
8188 2002-10-23 Nick Drochak <ndrochak@gol.com>
8190 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8192 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8194 * driver.cs: Do not make mcs-debug conditional, so we do not break
8197 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8198 review this patch. But basically after all the children variables
8199 have been merged, the value of "Breaks" was not being set to
8200 new_breaks for Switch blocks. I think that it should be set after
8201 it has executed. Currently I set this to the value of new_breaks,
8202 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8203 conservative, but I do not understand this code very well.
8205 I did not break anything in the build, so that is good ;-)
8207 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8209 2002-10-20 Mark Crichton <crichton@gimp.org>
8211 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8213 2002-10-20 Nick Drochak <ndrochak@gol.com>
8215 * cfold.cs: Fixed compile blocker.
8217 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8219 * driver.cs: I was chekcing the key, not the file.
8221 2002-10-19 Ravi Pratap <ravi@ximian.com>
8223 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8224 message that we were generating - we just need to silently return
8227 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8229 * class.cs (Event.Define): Change my previous commit, as this
8230 breaks the debugger. This is a temporary hack, as it seems like
8231 the compiler is generating events incorrectly to begin with.
8233 * expression.cs (Binary.ResolveOperator): Added support for
8234 "U operator - (E x, E y)"
8236 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8239 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8240 init-only variables, but this path did not take into account that
8241 there might be also instance readonly variables. Correct this
8244 This fixes bug 32253
8246 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8249 * driver.cs: Change the extension for modules to `netmodule'
8251 * cs-parser.jay: Improved slightly the location tracking for
8252 the debugger symbols.
8254 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8255 modifiers that were specified instead of the hardcoded value
8256 (FamAndAssem). This was basically ignoring the static modifier,
8257 and others. Fixes 32429.
8259 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8260 fixed a bug in the process (32476)
8262 * expression.cs (ArrayAccess.EmitAssign): Patch from
8263 hwang_rob@yahoo.ca that fixes bug 31834.3
8265 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8267 * driver.cs: Make the module extension .netmodule.
8269 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8271 * driver.cs: Report an error if the resource file is not found
8272 instead of crashing.
8274 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8275 false, like Emit does.
8277 2002-10-16 Nick Drochak <ndrochak@gol.com>
8279 * typemanager.cs: Remove unused private member. Also reported mcs
8280 bug to report this as a warning like csc.
8282 2002-10-15 Martin Baulig <martin@gnome.org>
8284 * statement.cs (Statement.Emit): Made this a virtual method; emits
8285 the line number info and calls DoEmit().
8286 (Statement.DoEmit): New protected abstract method, formerly knows
8287 as Statement.Emit().
8289 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8291 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8293 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8294 have fixed a remaining problem: not every AddXXXX was adding a
8295 fully qualified name.
8297 Now everyone registers a fully qualified name in the DeclSpace as
8298 being defined instead of the partial name.
8300 Downsides: we are slower than we need to be due to the excess
8301 copies and the names being registered this way.
8303 The reason for this is that we currently depend (on the corlib
8304 bootstrap for instance) that types are fully qualified, because
8305 we dump all the types in the namespace, and we should really have
8306 types inserted into the proper namespace, so we can only store the
8307 basenames in the defined_names array.
8309 2002-10-10 Martin Baulig <martin@gnome.org>
8311 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8312 from bug #31834, see the bug report for a testcase which is
8315 2002-10-10 Martin Baulig <martin@gnome.org>
8317 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8318 flow analysis code for this.
8320 * statement.cs (Do, While, For): Tell the flow analysis code about
8322 (FlowBranching.UsageVector): Added support for infinite loops.
8323 (Block.Resolve): Moved the dead code elimination here and use flow
8326 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8328 * class.cs (Field.Define): Catch cycles on struct type
8331 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8332 fields if the fields are static. We only need to check instance
8335 * expression.cs (As.DoResolve): Test for reference type.
8337 * statement.cs (Using.ResolveExpression): Use
8338 ConvertImplicitRequired, not ConvertImplicit which reports an
8340 (Using.ResolveLocalVariableDecls): ditto.
8342 * expression.cs (Binary.ResolveOperator): Report errors in a few
8343 places where we had to.
8345 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8347 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8349 * expression.cs: Use StoreFromPtr instead of extracting the type
8350 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8352 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8353 an enumeration value to a System.Enum, but System.Enum is not a
8354 value type, but an class type, so we need to box.
8356 (Expression.ConvertExplicit): One codepath could return
8357 errors but not flag them. Fix this. Fixes #31853
8359 * parameter.cs (Resolve): Do not allow void as a parameter type.
8361 2002-10-06 Martin Baulig <martin@gnome.org>
8363 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8364 if it's a class type and not a struct. Fixes #31815.
8366 2002-10-06 Martin Baulig <martin@gnome.org>
8368 * statement.cs: Reworked the flow analysis code a bit to make it
8369 usable for dead code elimination.
8371 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8373 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8375 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8377 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8378 to fix the test 165, will investigate deeper.
8380 2002-10-04 Martin Baulig <martin@gnome.org>
8382 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8383 finally blocks actually work.
8384 (Try.Resolve): We don't need to create a sibling for `finally' if
8385 there is no finally block.
8387 2002-10-04 Martin Baulig <martin@gnome.org>
8389 * class.cs (Constructor.Define): The default accessibility for a
8390 non-default constructor is private, not public.
8392 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8394 * class.cs (Constructor): Make AllowedModifiers public, add
8397 * cs-parser.jay: Perform the modifiers test here, as the
8398 constructor for the Constructor class usually receives a zero
8399 because of the way we create it (first we create, later we
8400 customize, and we were never checking the modifiers).
8402 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8403 is a version of LookupTypeReflection that includes the type-name
8404 cache. This can be used as a fast path for functions that know
8405 the fully qualified name and are only calling into *.GetType() to
8406 obtain a composed type.
8408 This is also used by TypeManager.LookupType during its type
8411 (LookupType): We now also track the real type name, as sometimes
8412 we can get a quey for the real type name from things like
8413 ComposedCast. This fixes bug 31422.
8415 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8416 complete type fullname, it does not have to go through the type
8417 resolution system to obtain the composed version of the type (for
8418 obtaining arrays or pointers).
8420 (Conditional.Emit): Use the EmitBoolExpression to
8421 generate nicer code, as requested by Paolo.
8423 (ArrayCreation.CheckIndices): Use the patch from
8424 hwang_rob@yahoo.ca to validate the array initializers.
8426 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8428 * class.cs (ConstructorInitializer.Emit): simplify code by using
8429 Invocation.EmitCall, and at the same time, fix the bugs in calling
8430 parent constructors that took variable arguments.
8432 * ecore.cs (Expression.ConvertNumericExplicit,
8433 Expression.ImplicitNumericConversion): Remove the code that
8434 manually wrapped decimal (InternalTypeConstructor call is now gone
8437 * expression.cs (Cast.TryReduce): Also handle decimal types when
8438 trying to perform a constant fold on the type.
8440 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8442 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8443 that only turned off an error report, and did nothing else.
8445 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8447 * driver.cs: Handle and ignore /fullpaths
8449 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8451 * expression.cs (Binary.ResolveOperator): Catch the case where
8452 DoNumericPromotions returns true,
8454 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8456 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8458 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8461 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8463 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8464 conversion exists, but it is also required that the conversion be
8465 performed. This manifested in "(Type64Enum) 2".
8467 * class.cs (TypeManager.AddMethod): The fix is not to change
8468 AddEnum, because that one was using a fully qualified name (every
8469 DeclSpace derivative does), but to change the AddMethod routine
8470 that was using an un-namespaced name. This now correctly reports
8471 the duplicated name.
8473 Revert patch until I can properly fix it. The issue
8474 is that we have a shared Type space across all namespaces
8475 currently, which is wrong.
8477 Options include making the Namespace a DeclSpace, and merge
8478 current_namespace/current_container in the parser.
8480 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8482 * cs-parser.jay: Improve error reporting when we get a different
8483 kind of expression in local_variable_type and
8484 local_variable_pointer_type.
8486 Propagate this to avoid missleading errors being reported.
8488 * ecore.cs (ImplicitReferenceConversion): treat
8489 TypeManager.value_type as a target just like object_type. As
8494 Is valid, and needs to result in the int 1 being boxed before it
8495 is assigned to the value type v.
8497 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8498 to validate the enumeration name.
8500 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8501 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8502 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8504 * ecore.cs (TryImplicitIntConversion): When doing an
8505 implicit-enumeration-conversion, check if the type is 64-bits and
8506 perform a conversion before passing to EnumConstant.
8508 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8510 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8511 report ambiguous type references. Unlike the MS version, we
8512 report what the ambiguity is. Innovation at work ;-)
8514 (DeclSpace.FindType): Require a location argument to
8515 display when we display an ambiguous error.
8517 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8519 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8521 * expression.cs (EmitDynamicInitializers): Apply patch from
8522 hwang_rob@yahoo.ca that fixes the order in which we emit our
8525 2002-09-21 Martin Baulig <martin@gnome.org>
8527 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8528 delegate takes no arguments.
8530 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8532 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8535 * expression.cs: Extract the underlying type.
8537 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
8539 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
8541 2002-09-19 Miguel de Icaza <miguel@ximian.com>
8543 * class.cs (TypeContainer.DefineType): We can not use the nice
8544 PackingSize with the size set to 1 DefineType method, because it
8545 will not allow us to define the interfaces that the struct
8548 This completes the fixing of bug 27287
8550 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
8551 means also structs. This fixes part of the problem.
8552 (Expresion.ImplicitReferenceConversionExists): ditto.
8554 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8555 error if there were no errors reported during the type lookup
8556 process, to avoid duplicates or redundant errors. Without this
8557 you would get an ambiguous errors plus a type not found. We have
8558 beaten the user enough with the first error.
8560 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8563 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8564 during the resolution process, stop the lookup, this avoids
8565 repeated error reports (same error twice).
8567 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8569 * typemanager.cs (LookupType): Redo the type lookup code to match
8570 the needs of System.Reflection.
8572 The issue is that System.Reflection requires references to nested
8573 types to begin with a "+" sign instead of a dot. So toplevel
8574 types look like: "NameSpace.TopLevelClass", and nested ones look
8575 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
8578 2002-09-19 Martin Baulig <martin@gnome.org>
8580 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
8581 says that a method always returns or always throws an exception,
8582 don't report the CS0161.
8584 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
8585 set `Returns = new_returns'.
8587 2002-09-19 Martin Baulig <martin@gnome.org>
8589 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
8590 to an enum constant, check for a CS0176.
8592 2002-09-18 Miguel de Icaza <miguel@ximian.com>
8594 * class.cs (TypeContainer.CheckPairedOperators): Now we check
8595 for operators that must be in pairs and report errors.
8597 * ecore.cs (SimpleName.DoResolveType): During the initial type
8598 resolution process, when we define types recursively, we must
8599 check first for types in our current scope before we perform
8600 lookups in the enclosing scopes.
8602 * expression.cs (MakeByteBlob): Handle Decimal blobs.
8604 (Invocation.VerifyArgumentsCompat): Call
8605 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
8606 I thought we were supposed to always call this, but there are a
8607 few places in the code where we dont do it.
8609 2002-09-17 Miguel de Icaza <miguel@ximian.com>
8611 * driver.cs: Add support in -linkres and -resource to specify the
8612 name of the identifier.
8614 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8616 * ecore.cs (StandardConversionExists): Sync with the conversion
8617 code: allow anything-* to void* conversions.
8619 (FindMostSpecificSource): Use an Expression argument
8620 instead of a Type, because we might be handed over a Literal which
8621 gets a few more implicit conversions that plain types do not. So
8622 this information was being lost.
8624 Also, we drop the temporary type-holder expression when not
8627 2002-09-17 Martin Baulig <martin@gnome.org>
8629 * class.cs (PropertyBase.CheckBase): Don't check the base class if
8630 this is an explicit interface implementation.
8632 2002-09-17 Martin Baulig <martin@gnome.org>
8634 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
8635 different `IndexerName' attributes.
8637 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
8638 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
8639 virtual CommonResolve().
8641 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8643 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
8644 and convert that to the UnderlyingType.
8646 * statement.cs (Foreach.Resolve): Indexers are just like variables
8647 or PropertyAccesses.
8649 * cs-tokenizer.cs (consume_string): Track line numbers and columns
8650 inside quoted strings, we were not doing this before.
8652 2002-09-16 Martin Baulig <martin@gnome.org>
8654 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
8655 resolve it. This is needed for the definite assignment check of the
8656 instance expression, fixes bug #29846.
8657 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
8659 2002-09-16 Nick Drochak <ndrochak@gol.com>
8661 * parameter.cs: Fix compile error. Cannot reference static member
8662 from an instance object. Is this an mcs bug?
8664 2002-09-14 Martin Baulig <martin@gnome.org>
8666 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
8667 multiple times. Fixes bug #30295, added test-166.cs.
8669 2002-09-14 Martin Baulig <martin@gnome.org>
8671 * statement.cs (Block.Emit): Don't emit unreachable code.
8672 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
8674 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
8676 2002-09-14 Martin Baulig <martin@gnome.org>
8678 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
8681 2002-09-14 Martin Baulig <martin@gnome.org>
8683 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
8684 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
8685 be false on the ms runtime.
8687 2002-09-13 Martin Baulig <martin@gnome.org>
8689 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
8690 the CS0038 error message.
8692 2002-09-12 Miguel de Icaza <miguel@ximian.com>
8694 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
8695 constant inside, return it.
8697 2002-09-12 Martin Baulig <martin@gnome.org>
8699 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
8700 implicit conversion can be done between enum types.
8702 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
8703 check whether an implicit conversion to the current enum's UnderlyingType
8704 exists and report an error if not.
8706 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
8707 without debugging support.
8709 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
8710 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
8712 2002-09-12 Martin Baulig <martin@gnome.org>
8714 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
8716 * ecore.cs (IMemberExpr.DeclaringType): New property.
8717 (SimpleName.SimpleNameResolve): Check whether we're accessing a
8718 nonstatic member of an outer type (CS0038).
8720 2002-09-11 Miguel de Icaza <miguel@ximian.com>
8722 * driver.cs: Activate the using-error detector at warning level
8723 4 (at least for MS-compatible APIs).
8725 * namespace.cs (VerifyUsing): Small buglett fix.
8727 * pending.cs (PendingImplementation): pass the container pointer.
8729 * interface.cs (GetMethods): Allow for recursive definition. Long
8730 term, I would like to move every type to support recursive
8731 definitions, not the current ordering mechanism that we have right
8734 The situation is this: Attributes are handled before interfaces,
8735 so we can apply attributes to interfaces. But some attributes
8736 implement interfaces, we will now handle the simple cases
8737 (recursive definitions will just get an error).
8739 * parameter.cs: Only invalidate types at the end if we fail to
8742 2002-09-09 Martin Baulig <martin@gnome.org>
8744 * ecore.cs (PropertyExpr.Emit): Also check for
8745 TypeManager.system_int_array_get_length so this'll also work when
8746 compiling corlib. Fixes #30003.
8748 2002-09-09 Martin Baulig <martin@gnome.org>
8750 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
8751 and throw an exception if we can't get the type's size. Fixed #30040,
8754 2002-09-09 Martin Baulig <martin@gnome.org>
8756 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
8758 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
8759 context. Fixes bug #30027.
8761 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
8762 virtual functions. Fixes bug #30043, added test-164.cs.
8764 2002-09-08 Ravi Pratap <ravi@ximian.com>
8766 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
8768 2002-09-08 Nick Drochak <ndrochak@gol.com>
8770 * driver.cs: Use an object to get the windows codepage since it's not a
8773 2002-09-08 Miguel de Icaza <miguel@ximian.com>
8775 * statement.cs (For.Emit): for infinite loops (test == null)
8776 return whether there is a break inside, not always "true".
8778 * namespace.cs (UsingEntry): New struct to hold the name of the
8779 using definition, the location where it is defined, and whether it
8780 has been used in a successful type lookup.
8782 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
8787 2002-09-06 Ravi Pratap <ravi@ximian.com>
8789 * attribute.cs : Fix incorrect code which relied on catching
8790 a NullReferenceException to detect a null being passed in
8791 where an object was expected.
8793 2002-09-06 Miguel de Icaza <miguel@ximian.com>
8795 * statement.cs (Try): flag the catch variable as assigned
8797 * expression.cs (Cast): Simplified by using ResolveType instead of
8800 * statement.cs (Catch): Fix bug by using ResolveType.
8802 2002-09-06 Ravi Pratap <ravi@ximian.com>
8804 * expression.cs (BetterConversion): Special case for when we have
8805 a NullLiteral as the argument and we have to choose between string
8806 and object types - we choose string the way csc does.
8808 * attribute.cs (Attribute.Resolve): Catch the
8809 NullReferenceException and report error #182 since the Mono
8810 runtime no more has the bug and having this exception raised means
8811 we tried to select a constructor which takes an object and is
8814 2002-09-05 Ravi Pratap <ravi@ximian.com>
8816 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
8817 message (1502, 1503) when we can't locate a method after overload
8818 resolution. This is much more informative and closes the bug
8821 * interface.cs (PopulateMethod): Return if there are no argument
8822 types. Fixes a NullReferenceException bug.
8824 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
8825 expressions too. Previously we were checking only in one place for
8826 positional arguments leaving out named arguments.
8828 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
8829 type to the enum type is not allowed. Remove code corresponding to
8832 (ConvertNumericExplicit): Allow explicit conversions from
8833 the underlying type to enum type. This precisely follows the spec
8834 and closes a bug filed by Gonzalo.
8836 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8839 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
8841 2002-09-03 Miguel de Icaza <miguel@ximian.com>
8843 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
8844 it was important that we stored the right value after the
8845 reduction in `converted'.
8847 2002-09-04 Martin Baulig <martin@gnome.org>
8849 * location.cs (Location.SymbolDocument): Use full pathnames for the
8852 2002-08-30 Miguel de Icaza <miguel@ximian.com>
8854 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
8855 of the expression resolve mechanism, because that will catch the
8856 SimpleName error failures.
8858 (Conditional): If we can not resolve the
8859 expression, return, do not crash.
8861 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8864 (location): display token name instead of its number.
8866 2002-08-28 Martin Baulig <martin@gnome.org>
8868 * expression.cs (Binary.ResolveOperator): Don't silently return
8869 but return an error if an operator cannot be applied between two
8872 2002-08-28 Martin Baulig <martin@gnome.org>
8874 * class.cs (Constructor.Define): Set the permission attributes
8875 correctly instead of making all constructors public.
8877 2002-08-28 Martin Baulig <martin@gnome.org>
8879 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
8880 for private members before reporting a CS0103; if we find anything,
8883 2002-08-28 Martin Baulig <martin@gnome.org>
8885 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
8886 to check whether `closure_start_type == closure_invocation_type',
8887 we also need to check whether `m.DeclaringType == closure_invocation_type'
8888 before bypassing the permission checks. We might be accessing
8889 protected/private members from the base class.
8890 (TypeManager.RealMemberLookup): Only set private_ok if private
8891 members were requested via BindingFlags.NonPublic.
8893 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
8895 * expression.cs (MemberAccess.ResolveMemberAccess): Set
8896 MethodGroupExpr.IsExplicitImpl if appropriate.
8897 (Invocation.DoResolve): Don't report the CS0120 for explicit
8898 interface implementations.
8900 2002-08-27 Martin Baulig <martin@gnome.org>
8902 * expression.cs (Invocation.DoResolve): If this is a static
8903 method and we don't have an InstanceExpression, we must report
8906 2002-08-25 Martin Baulig <martin@gnome.org>
8908 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
8909 `==' between a valuetype and an object.
8911 2002-08-25 Miguel de Icaza <miguel@ximian.com>
8913 * ecore.cs (TypeExpr): Provide a ToString method.
8915 2002-08-24 Martin Baulig <martin@gnome.org>
8917 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
8918 now called proggie.dbg and it's a binary file.
8920 2002-08-23 Martin Baulig <martin@gnome.org>
8922 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
8924 2002-08-23 Martin Baulig <martin@gnome.org>
8926 * struct.cs (MyStructInfo.ctor): Make this work with empty
8927 structs; it's not allowed to use foreach() on null.
8929 2002-08-23 Martin Baulig <martin@gnome.org>
8931 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
8932 writer the full pathname of the generated assembly.
8934 2002-08-23 Martin Baulig <martin@gnome.org>
8936 * statements.cs (FlowBranching.UsageVector.MergeChildren):
8937 A `finally' block never returns or breaks; improved handling of
8940 2002-08-23 Martin Baulig <martin@gnome.org>
8942 * statement.cs (Throw.Resolve): Allow `throw null'.
8944 2002-08-23 Martin Baulig <martin@gnome.org>
8946 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
8947 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
8948 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
8949 MemberLookup would return a wrong event if this is an explicit
8950 interface implementation and the class has an event with the same
8953 2002-08-23 Martin Baulig <martin@gnome.org>
8955 * statement.cs (Block.AddChildVariableNames): New public method.
8956 (Block.AddChildVariableName): Likewise.
8957 (Block.IsVariableNameUsedInChildBlock): Likewise.
8958 (Block.AddVariable): Check whether a variable name has already
8959 been used in a child block.
8961 * cs-parser.jay (declare_local_variables): Mark all variable names
8962 from the current block as being used in a child block in the
8965 2002-08-23 Martin Baulig <martin@gnome.org>
8967 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
8968 find the symbol writer.
8970 * driver.cs: csc also allows the arguments to /define being
8971 separated by commas, not only by semicolons.
8973 2002-08-23 Martin Baulig <martin@gnome.org>
8975 * interface.cs (Interface.GetMembers): Added static check for events.
8977 2002-08-15 Martin Baulig <martin@gnome.org>
8979 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
8980 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
8982 * ecore.cs (Expression.MemberLookup): Added documentation and explained
8983 why the MethodData.EmitDestructor() change was necessary.
8985 2002-08-20 Martin Baulig <martin@gnome.org>
8987 * class.cs (TypeContainer.FindMembers): Added static check for events.
8989 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
8991 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
8992 use Type.GetEvents(), not Type.FindMembers().
8994 2002-08-20 Martin Baulig <martin@gnome.org>
8996 * decl.cs (MemberCache): Added a special method cache which will
8997 be used for method-only searched. This ensures that a method
8998 search will return a MethodInfo with the correct ReflectedType for
9001 2002-08-20 Martin Baulig <martin@gnome.org>
9003 * decl.cs (DeclSpace.FindMembers): Made this public.
9005 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9007 * delegate.cs: fixed build on windows.
9008 [FIXME: Filed as bug #29150: MCS must report these errors.]
9010 2002-08-19 Ravi Pratap <ravi@ximian.com>
9012 * ecore.cs (StandardConversionExists): Return a false
9013 if we are trying to convert the void type to anything else
9014 since that is not allowed.
9016 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9017 we flag error 70 in the event an event is trying to be accessed
9018 directly from outside the declaring type.
9020 2002-08-20 Martin Baulig <martin@gnome.org>
9022 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9023 MemberCache from typemanager.cs to decl.cs.
9025 2002-08-19 Martin Baulig <martin@gnome.org>
9027 * class.cs (TypeContainer): Implement IMemberContainer.
9028 (TypeContainer.DefineMembers): Create the MemberCache.
9029 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9030 return public members if BindingFlags.Public was given, check
9031 whether members are static.
9033 2002-08-16 Martin Baulig <martin@gnome.org>
9035 * decl.cs (DeclSpace.Define): Splitted this in Define and
9036 DefineMembers. DefineMembers is called first and initializes the
9039 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9040 DefineMembers() on all our DeclSpaces.
9042 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9043 but call DefineMembers() on all nested interfaces. We call their
9044 Define() in our new Define() function.
9046 * interface.cs (Interface): Implement IMemberContainer.
9047 (Interface.Define): Moved all code except the attribute stuf to
9049 (Interface.DefineMembers): Initialize the member cache.
9051 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9052 need this anymore since we can use MemberCache.FindMembers directly.
9054 2002-08-19 Martin Baulig <martin@gnome.org>
9056 * typemanager.cs (MemberCache): When creating the cache for an
9057 interface type, add all inherited members.
9058 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9059 to `out bool used_cache' and documented it.
9060 (TypeManager.MemberLookup): If we already used the cache in the first
9061 iteration, we don't need to do the interfaces check.
9063 2002-08-19 Martin Baulig <martin@gnome.org>
9065 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9066 here from IMemberFinder and don't implement this interface anymore.
9067 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9069 * typemanager.cs (IMemberFinder): This interface is now only used by
9070 classes which actually support the member cache.
9071 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9072 since we only put DeclSpaces into this Hashtable.
9073 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9074 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9076 2002-08-16 Martin Baulig <martin@gnome.org>
9078 * typemanager.cs (ICachingMemberFinder): Removed.
9079 (IMemberFinder.MemberCache): New property.
9080 (TypeManager.FindMembers): Merged this with RealFindMembers().
9081 This function will never be called from TypeManager.MemberLookup()
9082 so we can't use the cache here, just the IMemberFinder.
9083 (TypeManager.MemberLookup_FindMembers): Check whether the
9084 IMemberFinder has a MemberCache and call the cache's FindMembers
9086 (MemberCache): Rewrote larger parts of this yet another time and
9087 cleaned it up a bit.
9089 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9091 * driver.cs (LoadArgs): Support quoting.
9093 (Usage): Show the CSC-like command line arguments.
9095 Improved a few error messages.
9097 2002-08-15 Martin Baulig <martin@gnome.org>
9099 * typemanager.cs (IMemberContainer.Type): New property.
9100 (IMemberContainer.IsInterface): New property.
9102 The following changes are conditional to BROKEN_RUNTIME, which is
9103 defined at the top of the file.
9105 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9106 class'es members, but add all members from TypeHandle.ObjectType
9107 if we're an interface.
9108 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9109 is the current type.
9110 (MemberCache.CacheEntry.Container): Removed this field.
9111 (TypeHandle.GetMembers): Include inherited members.
9113 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9115 * typemanager.cs: fixed compilation and added a comment on a field that
9118 2002-08-15 Martin Baulig <martin@gnome.org>
9120 * class.cs (ConstructorInitializer.Resolve): In the
9121 Expression.MemberLookup call, use the queried_type as
9124 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9125 declared' attribute, it's always true.
9126 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9127 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9128 temporary wrapper for FindMembers which tells MemberLookup whether
9129 members from the base classes are included in the return value.
9130 This will go away soon.
9131 (TypeManager.MemberLookup): Use this temporary hack here; once the
9132 new MemberCache is completed, we don't need to do the DeclaredOnly
9133 looping here anymore since the MemberCache will take care of this.
9134 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9135 (MemberCache): When creating the MemberCache for a class, get
9136 members from the current class and all its base classes.
9137 (MemberCache.CacheEntry.Container): New field. This is a
9138 temporary hack until the Mono runtime is fixed to distinguish
9139 between ReflectedType and DeclaringType. It allows us to use MCS
9140 with both the MS runtime and the unfixed Mono runtime without
9141 problems and without accecting performance.
9142 (MemberCache.SearchMembers): The DeclaredOnly looping from
9143 TypeManager.MemberLookup is now done here.
9145 2002-08-14 Martin Baulig <martin@gnome.org>
9147 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9148 Type.GetFields on dynamic types but get the fields from the
9149 corresponding TypeContainer.
9150 (MyStructInfo.GetStructInfo): Added check for enum types.
9152 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9153 (MemberList.SyncRoot): Implemented.
9154 (TypeManager.FilterWithClosure): No need to check permissions if
9155 closure_start_type == closure_invocation_type, don't crash if
9156 closure_invocation_type is null.
9158 2002-08-13 Martin Baulig <martin@gnome.org>
9160 Rewrote TypeContainer.FindMembers to use a member cache. This
9161 gives us a speed increase of about 35% for the self-hosting MCS
9162 build and of about 15-20% for the class libs (both on GNU/Linux).
9164 * report.cs (Timer): New class to get enhanced profiling. This
9165 whole class is "TIMER" conditional since it remarkably slows down
9168 * class.cs (MemberList): New class. This is an IList wrapper
9169 which we're now using instead of passing MemberInfo[]'s around to
9170 avoid copying this array unnecessarily.
9171 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9172 (ICachingMemberFinder, IMemberContainer): New interface.
9173 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9174 has already been checked, otherwise use it for the name comparision.
9175 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9176 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9177 if possible. Returns a MemberList, not a MemberInfo [].
9178 (TypeHandle): New class, implements IMemberContainer. We create
9179 one instance of this class per type, it contains a MemberCache
9180 which is used to do the member lookups.
9181 (MemberCache): New class. Each instance of this class contains
9182 all members of a type and a name-based hash table.
9183 (MemberCache.FindMembers): This is our new member lookup
9184 function. First, it looks up all members of the requested name in
9185 the hash table. Then, it walks this list and sorts out all
9186 applicable members and returns them.
9188 2002-08-13 Martin Baulig <martin@gnome.org>
9190 In addition to a nice code cleanup, this gives us a performance
9191 increase of about 1.4% on GNU/Linux - not much, but it's already
9192 half a second for the self-hosting MCS compilation.
9194 * typemanager.cs (IMemberFinder): New interface. It is used by
9195 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9196 Enum, Delegate or Interface.
9197 (TypeManager.finder_to_member_finder): New PtrHashtable.
9198 (TypeManager.finder_to_container): Removed.
9199 (TypeManager.finder_to_delegate): Removed.
9200 (TypeManager.finder_to_interface): Removed.
9201 (TypeManager.finder_to_enum): Removed.
9203 * interface.cs (Interface): Implement IMemberFinder.
9205 * delegate.cs (Delegate): Implement IMemberFinder.
9207 * enum.cs (Enum): Implement IMemberFinder.
9209 * class.cs (TypeContainer): Implement IMemberFinder.
9211 2002-08-12 Martin Baulig <martin@gnome.org>
9213 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9215 2002-08-12 Martin Baulig <martin@gnome.org>
9217 * ecore.cs (ITypeExpression): New interface for expressions which
9219 (TypeExpression): Renamed to TypeLookupExpression.
9220 (Expression.DoResolve): If we're doing a types-only lookup, the
9221 expression must implement the ITypeExpression interface and we
9222 call DoResolveType() on it.
9223 (SimpleName): Implement the new ITypeExpression interface.
9224 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9225 hack, the situation that we're only looking up types can't happen
9226 anymore when this method is called. Moved the type lookup code to
9227 DoResolveType() and call it.
9228 (SimpleName.DoResolveType): This ITypeExpression interface method
9229 is now doing the types-only lookup.
9230 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9231 (ResolveFlags): Added MaskExprClass.
9233 * expression.cs (MemberAccess): Implement the ITypeExpression
9235 (MemberAccess.DoResolve): Added support for a types-only lookup
9236 when we're called via ITypeExpression.DoResolveType().
9237 (ComposedCast): Implement the ITypeExpression interface.
9239 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9240 Expression.Resolve() with ResolveFlags.Type instead.
9242 2002-08-12 Martin Baulig <martin@gnome.org>
9244 * interface.cs (Interface.Define): Apply attributes.
9246 * attribute.cs (Attribute.ApplyAttributes): Added support for
9247 interface attributes.
9249 2002-08-11 Martin Baulig <martin@gnome.org>
9251 * statement.cs (Block.Emit): Only check the "this" variable if we
9252 do not always throw an exception.
9254 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9255 whether the property has a set accessor.
9257 2002-08-11 Martin Baulig <martin@gnome.org>
9259 Added control flow analysis support for structs.
9261 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9262 with control flow analysis turned off.
9263 (IVariable): New interface.
9264 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9265 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9266 (FieldExpr.DoResolve): Resolve the instance expression with flow
9267 analysis turned off and do the definite assignment check after the
9268 resolving when we know what the expression will resolve to.
9270 * expression.cs (LocalVariableReference, ParameterReference):
9271 Implement the new IVariable interface, only call the flow analysis
9272 code if ec.DoFlowAnalysis is true.
9273 (This): Added constructor which takes a Block argument. Implement
9274 the new IVariable interface.
9275 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9276 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9277 This does the definite assignment checks for struct members.
9279 * class.cs (Constructor.Emit): If this is a non-static `struct'
9280 constructor which doesn't have any initializer, call
9281 Block.AddThisVariable() to tell the flow analysis code that all
9282 struct elements must be initialized before control returns from
9285 * statement.cs (MyStructInfo): New public class.
9286 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9287 argument to this indexer. If non-zero, check an individual struct
9288 member, not the whole struct.
9289 (FlowBranching.CheckOutParameters): Check struct members.
9290 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9291 overloaded versions of these methods which take an additional
9292 `int field_idx' argument to check struct members.
9293 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9294 overloaded versions of these methods which take an additional
9295 `string field_name' argument to check struct member.s
9296 (VariableInfo): Implement the IVariable interface.
9297 (VariableInfo.StructInfo): New public property. Returns the
9298 MyStructInfo instance of the variable if it's a struct or null.
9299 (Block.AddThisVariable): New public method. This is called from
9300 Constructor.Emit() for non-static `struct' constructor which do
9301 not have any initializer. It creates a special variable for the
9302 "this" instance variable which will be checked by the flow
9303 analysis code to ensure that all of the struct's fields are
9304 initialized before control returns from the constructor.
9305 (UsageVector): Added support for struct members. If a
9306 variable/parameter is a struct with N members, we reserve a slot
9307 in the usage vector for each member. A struct is considered fully
9308 initialized if either the struct itself (slot 0) or all its
9309 members are initialized.
9311 2002-08-08 Martin Baulig <martin@gnome.org>
9313 * driver.cs (Driver.MainDriver): Only report an error CS5001
9314 if there were no compilation errors.
9316 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9317 `UnsafeContext' property to determine whether the parent is in
9318 unsafe context rather than checking the parent's ModFlags:
9319 classes nested in an unsafe class are unsafe as well.
9321 2002-08-08 Martin Baulig <martin@gnome.org>
9323 * statement.cs (UsageVector.MergeChildren): Distinguish between
9324 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9325 we return. Added test17() and test18() to test-154.cs.
9327 2002-08-08 Martin Baulig <martin@gnome.org>
9329 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9330 Family access, make sure the invoking type isn't a subclass of the
9331 queried type (that'd be a CS1540).
9333 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9334 this method which takes an additional `Type invocation_type'.
9336 * expression.cs (BaseAccess.DoResolve): Use the base type as
9337 invocation and query type.
9338 (MemberAccess.DoResolve): If the lookup failed and we're about to
9339 report a CS0122, try a lookup with the ec.ContainerType - if this
9340 succeeds, we must report a CS1540.
9342 2002-08-08 Martin Baulig <martin@gnome.org>
9344 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9345 (MethodGroupExpr): Implement the IMemberExpr interface.
9347 * expression (MemberAccess.ResolveMemberAccess): No need to have
9348 any special code for MethodGroupExprs anymore, they're now
9351 2002-08-08 Martin Baulig <martin@gnome.org>
9353 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9354 Family, FamANDAssem and FamORAssem permissions.
9355 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9357 2002-08-08 Martin Baulig <martin@gnome.org>
9359 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9360 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9363 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9365 * driver.cs: implemented /resource option to embed managed resources.
9367 2002-08-07 Martin Baulig <martin@gnome.org>
9369 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9370 (FieldBase.HasFieldInitializer): New public property.
9371 (FieldBase.GetInitializerExpression): New public method. Resolves and
9372 returns the field initializer and makes sure it is only resolved once.
9373 (TypeContainer.EmitFieldInitializers): Call
9374 FieldBase.GetInitializerExpression to get the initializer, this ensures
9375 that it isn't resolved multiple times.
9377 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9378 the resolving process (SimpleName/MemberLookup) that we're currently
9379 emitting a field initializer (which must not access any instance members,
9380 this is an error CS0236).
9382 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9383 argument, if the `IsFieldInitializer' flag is set, we must report and
9384 error CS0236 and not an error CS0120.
9386 2002-08-07 Martin Baulig <martin@gnome.org>
9388 * ecore.cs (IMemberExpr): New public interface.
9389 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9390 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9391 if the expression is an IMemberExpr.
9393 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9394 to be null, implicitly default to `this' if we're non-static in
9395 this case. Simplified the code a lot by using the new IMemberExpr
9396 interface. Also fixed bug #28176 here.
9398 2002-08-06 Martin Baulig <martin@gnome.org>
9400 * cs-parser.jay (SimpleLookup): Removed. We need to create
9401 ParameterReferences during semantic analysis so that we can do a
9402 type-only search when resolving Cast, TypeOf and SizeOf.
9403 (block): Pass the `current_local_parameters' to the Block's
9406 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9407 argument to the constructor.
9408 (ConstructorInitializer.Resolve): Create a temporary implicit
9409 block with the parameters.
9411 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9412 references here if we aren't doing a type-only search.
9414 * statement.cs (Block): Added constructor which takes a
9415 `Parameters parameters' argument.
9416 (Block.Parameters): New public property.
9418 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9419 to `Parameters' and made it public readonly.
9421 2002-08-06 Martin Baulig <martin@gnome.org>
9423 * ecore.cs (Expression.Warning): Made this public as well.
9425 * report.cs (Report.Debug): Print the contents of collections.
9427 2002-08-06 Martin Baulig <martin@gnome.org>
9429 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9430 used to tell Resolve() which kinds of expressions it may return.
9431 (Expression.Resolve): Added overloaded version of this method which
9432 takes a `ResolveFlags flags' argument. This can be used to tell
9433 Resolve() which kinds of expressions it may return. Reports a
9435 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9436 ResolveFlags.SimpleName.
9437 (Expression.Error118): Added overloaded version of this method which
9438 takes a `ResolveFlags flags' argument. It uses the flags to determine
9439 which kinds of expressions are allowed.
9441 * expression.cs (Argument.ResolveMethodGroup): New public method.
9442 Resolves an argument, but allows a MethodGroup to be returned.
9443 This is used when invoking a delegate.
9445 * TODO: Updated a bit.
9447 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9449 Fixed compilation with csc.
9451 * ecore.cs: Expression.Error made public. Is this correct? Should
9452 Warning be made public too?
9454 * expression.cs: use ea.Location instead of ea.loc.
9455 [FIXME: Filed as bug #28607: MCS must report these errors.]
9457 2002-08-06 Martin Baulig <martin@gnome.org>
9459 * ecore.cs (Expression.loc): Moved the location here instead of
9460 duplicating it in all derived classes.
9461 (Expression.Location): New public property.
9462 (Expression.Error, Expression.Warning): Made them non-static and
9463 removed the location argument.
9464 (Expression.Warning): Added overloaded version which takes an
9465 `int level' argument.
9466 (Expression.Error118): Make this non-static and removed the
9467 expression and location arguments.
9468 (TypeExpr): Added location argument to the constructor.
9470 * expression.cs (StaticCallExpr): Added location argument to
9472 (Indirection, PointerArithmetic): Likewise.
9473 (CheckedExpr, UnCheckedExpr): Likewise.
9474 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9475 (StringPtr): Likewise.
9478 2002-08-05 Martin Baulig <martin@gnome.org>
9480 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9482 * assign.cs (Assign.DoResolve): Check whether the source
9483 expression is a value or variable.
9485 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9486 while resolving the corresponding blocks.
9488 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9489 an error, don't silently return null.
9491 * statement.cs (Block.AddVariable): Do the error reporting here
9492 and distinguish between CS0128 and CS0136.
9493 (Block.DoResolve): Report all unused labels (warning CS0164).
9494 (LabeledStatement): Pass the location to the constructor.
9495 (LabeledStatement.HasBeenReferenced): New property.
9496 (LabeledStatement.Resolve): Set it to true here.
9498 * statement.cs (Return.Emit): Return success even after reporting
9499 a type mismatch error (CS0126 or CS0127), this is what csc does and
9500 it avoids confusing the users with any consecutive errors.
9502 2002-08-05 Martin Baulig <martin@gnome.org>
9504 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9506 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9508 * expression.cs (MemberAccess.DoResolve): Silently return if an
9509 error has already been reported.
9511 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9512 error has already been reported.
9514 2002-08-05 Martin Baulig <martin@gnome.org>
9516 * statement.cs (UsageVector): Only initialize the `parameters'
9517 vector if we actually have any "out" parameters.
9519 2002-08-05 Martin Baulig <martin@gnome.org>
9521 * expression.cs (Binary.ResolveOperator): When combining delegates,
9522 they must have the same type.
9524 2002-08-05 Martin Baulig <martin@gnome.org>
9526 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9527 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9528 work with the ms runtime and we also don't need it: if we're a
9529 PropertyBuilder and not in the `indexer_arguments' hash, then we
9530 are a property and not an indexer.
9532 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9533 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9534 since the latter one doesn't work with the ms runtime.
9536 2002-08-03 Martin Baulig <martin@gnome.org>
9538 Fixed bugs #27998 and #22735.
9540 * class.cs (Method.IsOperator): New public field.
9541 (Method.CheckBase): Report CS0111 if there's already a method
9542 with the same parameters in the current class. Report CS0508 when
9543 attempting to change the return type of an inherited method.
9544 (MethodData.Emit): Report CS0179 if a method doesn't have a body
9545 and it's not marked abstract or extern.
9546 (PropertyBase): New abstract base class for Property and Indexer.
9547 (PropertyBase.CheckBase): Moved here from Property and made it work
9549 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
9550 the same so we can reuse it there.
9551 (Property, Indexer): Derive from PropertyBase.
9552 (MethodSignature.inheritable_property_signature_filter): New delegate
9553 to find properties and indexers.
9555 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9556 argument and improved error reporting.
9558 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9559 EmptyReadOnlyParameters and made it a property.
9561 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9562 version of this method which takes a `PropertyInfo indexer'.
9563 (TypeManager.RegisterIndexer): New method.
9565 * class.cs: Added myself as author of this file :-)
9567 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9569 * class.cs: fixed compilation on windoze.
9571 2002-08-03 Martin Baulig <martin@gnome.org>
9573 * interface.cs (Interface.GetInterfaceBases): Check whether all
9574 base interfaces are at least as accessible than the current one.
9576 * class.cs (TypeContainer.GetClassBases): Check whether base types
9577 are at least as accessible than the current type.
9578 (TypeContainer.AsAccessible): Implemented and made non-static.
9579 (MemberBase.CheckParameters): Report errors if the accessibility
9582 * delegate.cs (Delegate.Delegate): The default visibility is
9583 internal for top-level types and private for nested types.
9584 (Delegate.Define): Report errors if the accessibility checks fail.
9586 * enum.cs (Enum.Enum): The default visibility is internal for
9587 top-level types and private for nested types.
9588 (Enum.DefineType): Compute the correct visibility.
9590 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
9591 function which takes a `bool is_toplevel' instead of a TypeContainer.
9593 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
9596 2002-08-02 Martin Baulig <martin@gnome.org>
9598 * expression.cs (LocalVariableReferenc): Added constructor which
9599 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
9600 (LocalVariableReference.IsReadOnly): New property.
9601 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
9602 variable is readonly, use our own readonly flag to do this; you can
9603 use the new constructor to get a writable reference to a read-only
9606 * cs-parser.jay (foreach_statement, using_statement): Get a writable
9607 reference to the local variable.
9609 2002-08-01 Miguel de Icaza <miguel@ximian.com>
9611 * rootcontext.cs (ResolveCore): Also include System.Exception
9613 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
9614 we reach an EmptyStatement.
9616 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
9619 * expression.cs (Binary.ResolveOperator): Check error result in
9622 use brtrue/brfalse directly and avoid compares to null.
9624 2002-08-02 Martin Baulig <martin@gnome.org>
9626 * class.cs (TypeContainer.Define): Define all nested interfaces here.
9627 Fixes bug #28407, added test-155.cs.
9629 2002-08-01 Martin Baulig <martin@gnome.org>
9631 * class.cs (Event.EmitDefaultMethod): Make this work with static
9632 events. Fixes #28311, added verify-3.cs.
9634 2002-08-01 Martin Baulig <martin@gnome.org>
9636 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
9637 `is_disposable' fields.
9638 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
9639 `hm.is_disposable' if we're using the collection pattern.
9640 (Foreach.EmitCollectionForeach): Use the correct type for the
9641 enumerator's local variable, only emit the try/finally block if
9642 necessary (fixes #27713).
9644 2002-08-01 Martin Baulig <martin@gnome.org>
9646 * ecore.cs (Expression.report118): Renamed to Error118 and made
9649 * statement.cs (Throw.Resolve): Check whether the expression is of
9650 the correct type (CS0118) and whether the type derives from
9651 System.Exception (CS0155).
9652 (Catch.Resolve): New method. Do the type lookup here and check
9653 whether it derives from System.Exception (CS0155).
9654 (Catch.CatchType, Catch.IsGeneral): New public properties.
9656 * typemanager.cs (TypeManager.exception_type): Added.
9658 2002-07-31 Miguel de Icaza <miguel@ximian.com>
9660 * driver.cs: Updated About function.
9662 2002-07-31 Martin Baulig <martin@gnome.org>
9664 Implemented Control Flow Analysis.
9666 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
9667 (EmitContext.CurrentBranching): Added.
9668 (EmitContext.StartFlowBranching): Added.
9669 (EmitContext.EndFlowBranching): Added.
9670 (EmitContext.KillFlowBranching): Added.
9671 (EmitContext.IsVariableAssigned): Added.
9672 (EmitContext.SetVariableAssigned): Added.
9673 (EmitContext.IsParameterAssigned): Added.
9674 (EmitContext.SetParameterAssigned): Added.
9675 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
9676 Added control flow analysis stuff here.
9678 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
9679 resolve the expression as lvalue.
9680 (LocalVariableReference.DoResolve): Check whether the variable has
9681 already been assigned.
9682 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
9683 the parameter as assigned here.
9684 (ParameterReference.DoResolve): Check whether the parameter has already
9686 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
9687 expression as lvalue.
9689 * statement.cs (FlowBranching): New class for the flow analysis code.
9690 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
9691 (LabeledStatement.IsDefined): New public property.
9692 (LabeledStatement.AddUsageVector): New public method to tell flow
9693 analyis that the label may be reached via a forward jump.
9694 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
9696 (VariableInfo.Number): New public field. This is used by flow analysis
9697 to number all locals of a block.
9698 (Block.CountVariables): New public property. This is the number of
9699 local variables in this block (including the locals from all parent
9701 (Block.EmitMeta): Number all the variables.
9703 * statement.cs: Added flow analysis support to all classes.
9705 2002-07-31 Martin Baulig <martin@gnome.org>
9707 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
9708 To get debugging messages, compile mcs with /define:MCS_DEBUG and
9709 then use this argument.
9711 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
9713 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
9714 use this to specify /define options.
9716 2002-07-29 Martin Baulig <martin@gnome.org>
9718 * statement.cs (Fixed): Moved all code that does variable lookups
9719 and resolvings from Emit to Resolve.
9721 * statement.cs (For): Moved all code that does variable lookups
9722 and resolvings from Emit to Resolve.
9724 * statement.cs (Using): Moved all code that does variable lookups
9725 and resolvings from Emit to Resolve.
9727 2002-07-29 Martin Baulig <martin@gnome.org>
9729 * attribute.cs (Attribute.Resolve): Explicitly catch a
9730 System.NullReferenceException when creating the
9731 CustromAttributeBuilder and report a different warning message.
9733 2002-07-29 Martin Baulig <martin@gnome.org>
9735 * support.cs (ParameterData.ParameterName): Added method to
9736 get the name of a parameter.
9738 * typemanager.cs (TypeManager.IsValueType): New public method.
9740 2002-07-29 Martin Baulig <martin@gnome.org>
9742 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
9743 is a flag which specifies that it's either ref or out.
9744 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
9745 the out parameter to `out Parameter.Modifier mod', also set the
9746 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
9748 * support.cs (InternalParameters.ParameterModifier): Distinguish
9749 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9750 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9752 * expression.cs (Argument.GetParameterModifier): Distinguish
9753 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9754 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9756 2002-07-29 Martin Baulig <martin@gnome.org>
9758 * expression.cs (ParameterReference.ParameterReference): Added
9759 `Location loc' argument to the constructor.
9761 * cs-parser.jay: Pass location to ParameterReference.
9763 2002-07-28 Miguel de Icaza <miguel@ximian.com>
9765 * statement.cs (Try): Initialize the location.
9767 * cs-parser.jay: pass location to Try.
9769 * expression.cs (Unary.Reduce): Change the prototype to return
9770 whether a constant fold could be performed or not. The result is
9771 returned in an out parameters. In the case of Indirection and
9772 AddressOf, we want to perform the full tests.
9774 2002-07-26 Miguel de Icaza <miguel@ximian.com>
9776 * statement.cs (Statement.Emit): Flag dead code.
9778 2002-07-27 Andrew Birkett <andy@nobugs.org>
9780 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
9782 2002-07-27 Martin Baulig <martin@gnome.org>
9784 * class.cs (MethodData.Define): Put back call to
9785 TypeManager.AddMethod(), accidentally commented this out.
9787 * report.cs (Debug): New public method to print debugging information,
9788 this is `[Conditional ("DEBUG")]'.
9790 2002-07-26 Martin Baulig <martin@gnome.org>
9792 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
9793 (switch_statement): Push the current_block to the switch_stack and
9794 pop it again when we're done with the switch.
9795 (switch_section): The new block is a child of the current_block.
9796 Fixes bug #24007, added test-152.cs.
9798 2002-07-27 Martin Baulig <martin@gnome.org>
9800 * expression.cs (Invocation.EmitArguments): When calling a varargs
9801 function with only its fixed arguments, we need to pass an empty
9804 2002-07-27 Martin Baulig <martin@gnome.org>
9806 Mono 0.13 has been released.
9808 2002-07-25 Miguel de Icaza <miguel@ximian.com>
9810 * driver.cs: Rename --resource to --linkres, because that is what
9811 we do currently, we dont support --resource yet.
9813 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
9815 2002-07-25 Martin Baulig <martin@gnome.org>
9817 * class.cs (MethodData): New public class. This is a `method builder'
9818 class for a method or one accessor of a Property/Indexer/Event.
9819 (MethodData.GetMethodFlags): Moved here from MemberBase.
9820 (MethodData.ApplyAttributes): Likewise.
9821 (MethodData.ApplyObsoleteAttribute): Likewise.
9822 (MethodData.ApplyConditionalAttribute): Likewise.
9823 (MethodData.ApplyDllImportAttribute): Likewise.
9824 (MethodData.CheckAbstractAndExternal): Likewise.
9825 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
9826 (MethodData.Emit): Formerly known as Method.Emit().
9827 (MemberBase): Moved everything which was specific to a single
9828 accessor/method to MethodData.
9829 (Method): Create a new MethodData and call Define() and Emit() on it.
9830 (Property, Indexer, Event): Create a new MethodData objects for each
9831 accessor and call Define() and Emit() on them.
9833 2002-07-25 Martin Baulig <martin@gnome.org>
9835 Made MethodCore derive from MemberBase to reuse the code from there.
9836 MemberBase now also checks for attributes.
9838 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
9839 (MemberBase.GetMethodFlags): Moved here from class Method and marked
9841 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
9842 `CallingConventions cc' and `Attributes opt_attrs' arguments.
9843 (MemberBase.ApplyAttributes): New virtual method; applies the
9844 attributes to a method or accessor.
9845 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
9846 (MemberBase.ApplyConditionalAttribute): Likewise.
9847 (MemberBase.ApplyDllImportAttribute): Likewise.
9848 (MemberBase.CheckAbstractAndExternal): Likewise.
9849 (MethodCore.ParameterTypes): This is now a property instead of a
9850 method, it's initialized from DoDefineParameters().
9851 (MethodCore.ParameterInfo): Removed the set accessor.
9852 (MethodCore.DoDefineParameters): New protected virtual method to
9853 initialize ParameterTypes and ParameterInfo.
9854 (Method.GetReturnType): We can now simply return the MemberType.
9855 (Method.GetMethodFlags): Override the MemberBase version and add
9856 the conditional flags.
9857 (Method.CheckBase): Moved some code from Define() here, call
9858 DoDefineParameters() here.
9859 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
9860 here to avoid some larger code duplication.
9861 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
9862 ensure that abstract and external accessors don't declare a body.
9864 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
9865 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
9866 lookup in the attribute's parent classes, so we need to abort as soon
9867 as we found the first match.
9868 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
9869 the attribute has no arguments.
9871 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
9874 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9876 * cs-parser.jay: reverted previous patch.
9878 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9880 * cs-parser.jay: fixed bug #22119.
9882 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9884 * attribute.cs: fixed compilation. The error was:
9885 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
9886 be assigned to before control leaves the current method."
9887 [FIXME: Filed as bug #28186: MCS must report this error.]
9889 2002-07-25 Martin Baulig <martin@gnome.org>
9891 * attribute.cs (Attribute.Conditional_GetConditionName): New static
9892 method to pull the condition name ouf of a Conditional attribute.
9893 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
9894 the obsolete message and error flag out of an Obsolete attribute.
9896 * class.cs (Method.GetMethodFlags): New public method to get the
9897 TypeManager.MethodFlags for this method.
9898 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
9900 (Method.Define): Get and apply the Obsolete and Conditional attributes;
9901 if we're overriding a virtual function, set the new private variable
9902 `parent_method'; call the new TypeManager.AddMethod().
9904 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
9905 the MethodBuilder and the Method in a PtrHashtable.
9906 (TypeManager.builder_to_method): Added for this purpose.
9907 (TypeManager.MethodFlags): Added IsObsoleteError.
9908 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
9909 Obsolete and Conditional arguments in MethodBuilders. If we discover
9910 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
9911 the message from the attribute.
9913 2002-07-24 Martin Baulig <martin@gnome.org>
9915 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
9916 preprocessor directives, ensure that the argument to #define/#undef is
9917 exactly one identifier and that it's actually an identifier.
9919 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
9922 2002-07-24 Martin Baulig <martin@gnome.org>
9924 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
9925 initialize it to TypeManager.object_type in the constructor.
9926 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
9927 of the `hm.get_current' method if we're using the collection pattern.
9928 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
9929 for the explicit conversion to make it work when we're using the collection
9930 pattern and the `Current' property has a different return type than `object'.
9933 2002-07-24 Martin Baulig <martin@gnome.org>
9935 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
9936 does not match, but don't report any errors. This method is called in
9937 order for all methods in a MethodGroupExpr until a matching method is
9938 found, so we don't want to bail out if the first method doesn't match.
9939 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
9940 matches, report the 123. Fixes #28070.
9942 2002-07-24 Martin Baulig <martin@gnome.org>
9944 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
9945 TypeManager.TypeToCoreType() to the top of the method so the
9946 following equality checks will work. Fixes #28107.
9948 2002-07-24 Martin Baulig <martin@gnome.org>
9950 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
9951 operand is of type uint, and the other operand is of type sbyte,
9952 short or int, the operands are converted to type long." -
9953 Actually do what this comment already told us. Fixes bug #28106,
9956 2002-07-24 Martin Baulig <martin@gnome.org>
9958 * class.cs (MethodBase): New abstract class. This is now a base
9959 class for Property, Indexer and Event to avoid some code duplication
9960 in their Define() and DefineMethods() methods.
9961 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
9962 generic methods for Define() and DefineMethods().
9963 (FieldBase): Derive from MemberBase, not MemberCore.
9964 (Property): Derive from MemberBase, not MemberCore.
9965 (Property.DefineMethod): Moved all the code from this method to the
9966 new MethodBase.DefineAccessor(), just call it with appropriate
9968 (Property.Define): Call the new Property.DoDefine(), this does some
9969 sanity checks and we don't need to duplicate the code everywhere.
9970 (Event): Derive from MemberBase, not MemberCore.
9971 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
9972 accessors, this will also make them work with interface events.
9973 (Indexer): Derive from MemberBase, not MemberCore.
9974 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
9975 (Indexer.Define): Use the new MethodBase functions.
9977 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
9978 argument to the constructor.
9979 (Interface.FindMembers): Added support for interface events.
9980 (Interface.PopluateEvent): Implemented.
9982 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
9984 2002-07-22 Miguel de Icaza <miguel@ximian.com>
9986 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
9987 but this is required to check for a method name being the same as
9988 the containing class.
9992 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9994 * interface.cs: initialize variable.
9996 2002-07-23 Martin Baulig <martin@gnome.org>
9998 Implemented the IndexerName attribute in interfaces.
10000 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10001 name if this is an explicit interface implementation.
10002 (Indexer.InterfaceIndexerName): New public variable. If we're
10003 implementing an interface indexer, this is the IndexerName in that
10004 interface. Otherwise, it's the IndexerName.
10005 (Indexer.DefineMethod): If we're implementing interface indexer,
10006 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10007 and Pending.ImplementIndexer methods.
10008 (Indexer.Define): Also define the PropertyBuilder if we're
10009 implementing an interface indexer and this is neither an explicit
10010 interface implementation nor do the IndexerName match the one in
10013 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10014 If a method is defined here, then we always need to create a proxy
10015 for it. This is used when implementing interface indexers.
10016 (Pending.IsInterfaceIndexer): New public method.
10017 (Pending.ImplementIndexer): New public method.
10018 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10019 This is used when implementing interface indexers to define a proxy
10021 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10022 define a proxy if necessary.
10024 * interface.cs (Interface.IndexerName): New public variable.
10025 (Interface.PopulateIndexer): Set the IndexerName.
10026 (Interface.DefineIndexers): New private method. Populate all the
10027 indexers and make sure their IndexerNames match.
10029 * typemanager.cs (IndexerPropertyName): Added support for interface
10032 2002-07-22 Martin Baulig <martin@gnome.org>
10034 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10035 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10036 ret if HasReturnLabel.
10037 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10040 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10041 and set the ec.LoopBeginTryCatchLevel.
10042 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10043 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10044 the current ec.TryCatchLevel, the branch goes out of an exception
10045 block. In this case, we need to use Leave and not Br.
10047 2002-07-22 Martin Baulig <martin@gnome.org>
10049 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10050 block unless the block does not always return or it is contained in
10051 another try { ... } catch { ... } block. Fixes bug #26506.
10052 Added verify-1.cs to the test suite.
10054 2002-07-22 Martin Baulig <martin@gnome.org>
10056 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10057 then we do not always return. Fixes bug #24985.
10059 2002-07-22 Martin Baulig <martin@gnome.org>
10061 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10062 lookup on a per-class level; ie. walk up the class hierarchy until we
10063 found at least one applicable method, then choose the best among them.
10064 Fixes bug #24463 and test-29.cs.
10066 2002-07-22 Martin Baulig <martin@gnome.org>
10068 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10069 return types of the methods. The return type is not part of the
10070 signature and we must not check it to make the `new' modifier work.
10071 Fixes bug #27999, also added test-147.cs.
10072 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10074 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10075 on the method's return type.
10077 2002-07-21 Martin Baulig <martin@gnome.org>
10079 * assign.cs: Make this work if the rightmost source is a constant and
10080 we need to do an implicit type conversion. Also adding a few more tests
10081 to test-38.cs which should have caught this.
10083 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10084 target in the makefile for this. The makefile.gnu is primarily intended
10085 for end-users who don't want to debug the compiler.
10087 2002-07-21 Martin Baulig <martin@gnome.org>
10089 * assign.cs: Improved the Assign class so it can now handle embedded
10090 assignments (X = Y = Z = something). As a side-effect this'll now also
10091 consume less local variables. test-38.cs now passes with MCS, added
10092 a few new test cases to that test.
10094 2002-07-20 Martin Baulig <martin@gnome.org>
10096 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10097 instructions. Fixes bug #27977, also added test-146.cs.
10099 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10101 * cs-tokenizer.cs: fixed getHex ().
10103 2002-07-19 Martin Baulig <martin@gnome.org>
10105 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10106 not Type.GetType() to lookup the array type. This is needed when
10107 we're constructing an array of a user-defined type.
10108 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10109 single-dimensional arrays, but also for single-dimensial arrays of
10112 2002-07-19 Martin Baulig <martin@gnome.org>
10114 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10115 this function is called, it's not allowed to share LocalBuilders
10116 among ILGenerators.
10118 2002-07-19 Martin Baulig <martin@gnome.org>
10120 * expression.cs (Argument.Resolve): Report an error 118 when trying
10121 to pass a type as argument.
10123 2002-07-18 Martin Baulig <martin@gnome.org>
10125 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10126 Conv_R_Un for the signed `long' type.
10128 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10130 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10131 `expr' for the temporary result, as that will fail if we do
10132 multiple resolves on the same expression.
10134 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10136 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10137 ec.TypeContainer for looking up aliases.
10139 * class.cs (TypeContainer): Remove LookupAlias from here.
10141 * decl.cs (DeclSpace); Move here.
10143 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10145 * class.cs (FindMembers): Only call filter if the constructor
10146 bulider is not null.
10148 Also handle delegates in `NestedTypes' now. Now we will perform
10149 type lookups using the standard resolution process. This also
10152 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10153 This uses Expressions (the limited kind that can be parsed by the
10154 tree) instead of strings.
10156 * expression.cs (ComposedCast.ToString): Implement, used to flag
10157 errors since now we have to render expressions.
10159 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10162 * ecore.cs (SimpleName.ToString): ditto.
10164 * cs-parser.jay: Instead of using strings to assemble types, use
10165 Expressions to assemble the type (using SimpleName, ComposedCast,
10166 MemberAccess). This should fix the type lookups in declarations,
10167 because we were using a different code path for this.
10169 * statement.cs (Block.Resolve): Continue processing statements
10170 even when there is an error.
10172 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10174 * class.cs (Event.Define): Also remove the `remove' method from
10175 the list of pending items.
10177 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10178 generate more compact code.
10180 2002-07-17 Martin Baulig <martin@gnome.org>
10182 * const.cs (Const.LookupConstantValue): Add support for constant
10183 `unchecked' and `checked' expressions.
10184 Also adding test case test-140.cs for this.
10186 2002-07-17 Martin Baulig <martin@gnome.org>
10188 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10189 check whether mi.ReturnType implements the IEnumerator interface; the
10190 `==' and the IsAssignableFrom() will fail in this situation.
10192 2002-07-16 Ravi Pratap <ravi@ximian.com>
10194 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10197 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10199 * expression.cs: fixed bug #27811.
10201 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10203 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10204 Molaro: when we are a ref, the value already contains a pointer
10205 value, do not take the address of it.
10207 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10208 * removed mb-parser.jay and mb-tokenizer.cs
10210 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10212 * expression.cs: check against the building corlib void type.
10214 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10216 * ecore.cs: fix for valuetype static readonly fields: when
10217 initializing them, we need their address, not the address of a copy.
10219 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10221 * typemanager.cs: register also enum_type in corlib.
10223 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10225 * class.cs: allow calling this (but not base) initializers in structs.
10227 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10229 * ecore.cs: make sure we compare against the building base types
10232 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10234 * typemanager.cs: fix TypeToCoreType() to handle void and object
10235 (corlib gets no more typerefs after this change).
10237 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10239 * expression.cs (ArrayCreation.EmitArrayArguments): use
10240 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10242 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10243 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10244 array indexes, the runtime actually forbids them.
10246 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10247 for array arguments here.
10249 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10250 instead of the default for ValueTypes.
10252 (New.DoEmit): Use IsValueType instead of
10253 IsSubclassOf (value_type)
10254 (New.DoResolve): ditto.
10255 (Invocation.EmitCall): ditto.
10257 * assign.cs (Assign): ditto.
10259 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10260 Statements *are* currently doing part of their resolution during
10263 Expressions do always resolve during resolve, but statements are
10264 only required to propagate resolution to their children.
10266 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10268 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10270 (LoadAssembly): Do not add the dll if it is already specified
10272 (MainDriver): Add the System directory to the link path at the end,
10273 after all the other -L arguments.
10275 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10276 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10277 ldelem.u1) and using the opposite for sbytes.
10279 This fixes Digger, and we can finally run it.
10281 * driver.cs (UnixParseOption): Move the option parsing here.
10282 (CSCParseOption): Implement CSC-like parsing of options.
10284 We now support both modes of operation, the old Unix way, and the
10285 new CSC-like way. This should help those who wanted to make cross
10286 platform makefiles.
10288 The only thing broken is that /r:, /reference: and /lib: are not
10289 implemented, because I want to make those have the same semantics
10290 as the CSC compiler has, and kill once and for all the confussion
10291 around this. Will be doing this tomorrow.
10293 * statement.cs (Unsafe.Resolve): The state is checked during
10294 resolve, not emit, so we have to set the flags for IsUnsfe here.
10296 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10298 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10299 not catch the Error_ObjectRefRequired in SimpleName (as it is
10300 possible to have a class/instance variable name that later gets
10301 deambiguated), we have to check this here.
10303 2002-07-10 Ravi Pratap <ravi@ximian.com>
10305 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10306 make static and put into Expression.
10308 (Event.Define): Register the private field of the event with the
10309 TypeManager so that GetFieldFromEvent can get at it.
10311 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10312 keep track of the private field associated with an event which
10315 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10318 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10320 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10322 * expression.cs (Binary.EmitBranchable): this routine emits the
10323 Binary expression in a branchable context. This basically means:
10324 we need to branch somewhere, not just get the value on the stack.
10326 This works together with Statement.EmitBoolExpression.
10328 * statement.cs (Statement.EmitBoolExpression): Use
10331 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10333 * statement.cs (For): Reduce the number of jumps in loops.
10335 (For): Implement loop inversion for the For statement.
10337 (Break): We can be breaking out of a Try/Catch controlled section
10338 (foreach might have an implicit try/catch clause), so we need to
10339 use Leave instead of Br.
10341 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10342 now). If the instace expression supports IMemoryLocation, we use
10343 the AddressOf method from the IMemoryLocation to extract the
10344 address instead of emitting the instance.
10346 This showed up with `This', as we were emitting the instance
10347 always (Emit) instead of the Address of This. Particularly
10348 interesting when This is a value type, as we dont want the Emit
10349 effect (which was to load the object).
10351 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10353 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10355 * statement.cs (Checked): Set the CheckedState during the resolve
10356 process too, as the ConvCast operations track the checked state on
10357 the resolve process, and not emit.
10359 * cs-parser.jay (namespace_member_declaration): Flag that we have
10360 found a declaration when we do. This is used to flag error 1529
10362 * driver.cs: Report ok when we display the help only.
10364 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10366 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10368 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10370 * cs-tokenizer.cs (define): We also have to track locally the
10371 defines. AllDefines is just used for the Conditional Attribute,
10372 but we also need the local defines for the current source code.
10374 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10376 * statement.cs (While, For, Do): These loops can exit through a
10377 Break statement, use this information to tell whether the
10378 statement is the last piece of code.
10380 (Break): Flag that we break.
10382 * codegen.cs (EmitContexts): New `Breaks' state variable.
10384 2002-07-03 Martin Baulig <martin@gnome.org>
10386 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10387 modifiers in method declarations in structs. Otherwise, you won't
10388 be able to override things like Object.Equals().
10390 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10392 * class.cs (Method, Property, Indexer): Do not allow the public
10393 modifier to be used in explicit interface implementations.
10395 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10396 override modifiers in method declarations in structs
10398 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10400 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10401 integer or real overflow, report an error
10403 2002-07-02 Martin Baulig <martin@gnome.org>
10405 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10406 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10407 to tell the runtime about our newly created System.Object and
10408 System.ValueType types.
10410 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10412 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10413 struct instead of Ldarg/Starg.
10415 2002-07-02 Martin Baulig <martin@gnome.org>
10417 * expression.cs (Indirection.Indirection): Call
10418 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10420 2002-07-02 Martin Baulig <martin@gnome.org>
10422 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10423 ValueType, call TypeManager.TypeToCoreType() on it.
10424 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10425 the OpCodes.Newarr argument.
10427 2002-07-02 Martin Baulig <martin@gnome.org>
10429 * expression.cs (Invocation.EmitCall): When compiling corlib,
10430 replace all calls to the system's System.Array type to calls to
10431 the newly created one.
10433 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10434 System.Array methods.
10435 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10436 from the system's System.Array type which must be replaced.
10438 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10440 * typemanager.cs: load unverifiable_code_ctor so we can build
10441 corlib using the correct type. Avoid using GetTypeCode() with
10443 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10444 TypeManager.object_type to allow building corlib.
10446 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10448 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10450 2002-07-01 Martin Baulig <martin@gnome.org>
10452 * class.cs: Make the last change actually work, we need to check
10453 whether `ifaces != null' to avoid a crash.
10455 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10457 * class.cs: when we build structs without fields that implement
10458 interfaces, we need to add the interfaces separately, since there is
10459 no API to both set the size and add the interfaces at type creation
10462 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10464 * expression.cs: the dimension arguments to the array constructors
10465 need to be converted if they are a long.
10467 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10469 * class.cs: don't emit ldarg.0 if there is no parent constructor
10470 (fixes showstopper for corlib).
10472 2002-06-29 Martin Baulig <martin@gnome.org>
10474 MCS now compiles corlib on GNU/Linux :-)
10476 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10477 ie. check for MethodImplOptions.InternalCall.
10479 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10480 and TypeManager.attribute_type are null, so we must explicitly check
10481 whether parent is not null to find out whether it's an attribute type.
10482 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10483 and SetBuilder, not only if the property is neither abstract nor external.
10484 This is necessary to set the MethodImplOptions on the accessor methods.
10485 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10486 SetBuilder, see Property.Emit().
10488 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10489 populate "System.Object", "System.ValueType" and "System.Attribute" since
10490 they've already been populated from BootCorlib_PopulateCoreTypes().
10492 2002-06-29 Martin Baulig <martin@gnome.org>
10494 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10495 is the NullLiteral, we also need to make sure that target_type is not
10498 2002-06-29 Martin Baulig <martin@gnome.org>
10500 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10501 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10502 before calling BootstrapCorlib_ResolveDelegate ().
10504 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10506 * statement.cs: fixed build-breaker. All tests passed ok.
10508 2002-06-27 Martin Baulig <martin@gnome.org>
10510 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10511 for System.Decimal when compiling corlib.
10513 2002-06-27 Martin Baulig <martin@gnome.org>
10515 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10516 switch blocks which contain nothing but a default clause.
10518 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10520 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10522 2002-06-27 Martin Baulig <martin@gnome.org>
10524 * ecore.cs (PropertyExpr.PropertyExpr): Call
10525 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10527 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10528 is already a TypeBuilder.
10530 2002-06-27 Martin Baulig <martin@gnome.org>
10532 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10533 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10534 the "from an array-type to System.Array" case. This makes it work
10535 when compiling corlib.
10537 2002-06-27 Martin Baulig <martin@gnome.org>
10539 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
10540 non-static PropertyExpr, set its InstanceExpression. This makes
10541 the `ICollection.Count' property work in System/Array.cs.
10543 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
10545 * driver.cs: Made error handling more consistent. Errors now
10546 tracked by Report class, so many methods which used to return int
10547 now return void. Main() now prints success/failure and
10548 errors/warnings message.
10550 Renamed '--probe' compiler argument to '--expect-error'. Removed
10551 the magic number return values (123 and 124). Now, if the
10552 expected error occurs, the compiler exits with success (exit value
10553 0). If the compilation completes without seeing that particular
10554 error, the compiler exits with failure (exit value 1). The
10555 makefile in mcs/errors has been changed to handle the new behaviour.
10557 * report.cs: Made 'expected error' number a property and renamed
10558 it from 'Probe' to 'ExpectedError'.
10560 * genericparser.cs: Removed error handling support, since it is
10561 now all done by Report class.
10563 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10564 class, so parse() no longer returns an int.
10566 * namespace.cs: Use Report.Error instead of GenericParser.error
10568 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10570 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10571 TypeContainer.AddOperator): At the front of the list put the
10572 explicit implementations, so they get resolved/defined first.
10574 2002-06-21 Miguel de Icaza <miguel@ximian.com>
10576 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
10577 interface type is implemented by this TypeContainer. Used during
10578 explicit interface implementation.
10580 (Property.Define, Indexer.Define, Method.Define): Validate that
10581 the given interface in the explicit implementation is one of the
10582 base classes for the containing type.
10584 Also if we are explicitly implementing an interface, but there is
10585 no match in the pending implementation table, report an error.
10587 (Property.Define): Only define the property if we are
10588 not explicitly implementing a property from an interface. Use the
10589 correct name also for those properties (the same CSC uses,
10590 although that is really not needed).
10592 (Property.Emit): Do not emit attributes for explicitly implemented
10593 properties, as there is no TypeBuilder.
10595 (Indexer.Emit): ditto.
10597 Hiding then means that we do not really *implement* a pending
10598 implementation, which makes code fail.
10600 2002-06-22 Martin Baulig <martin@gnome.org>
10602 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
10603 the return value of Object.GetType(). [FIXME: we need to do this whenever
10604 we get a type back from the reflection library].
10606 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
10608 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
10610 2002-06-20 Miguel de Icaza <miguel@ximian.com>
10612 * attribute.cs: Return null if we can not look up the type.
10614 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
10615 the interface types found.
10617 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
10618 interface types found.
10620 * typemanager.cs (GetInterfaces): Make this routine returns alll
10621 the interfaces and work around the lame differences between
10622 System.Type and System.Reflection.Emit.TypeBuilder in the results
10623 result for GetInterfaces.
10625 (ExpandInterfaces): Given an array of interface types, expand and
10626 eliminate repeated ocurrences of an interface. This expands in
10627 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
10630 2002-06-21 Martin Baulig <martin@gnome.org>
10632 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
10635 2002-06-21 Martin Baulig <martin@gnome.org>
10637 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
10638 and called with one of the core types, return the corresponding typebuilder for
10641 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
10644 2002-06-21 Martin Baulig <martin@gnome.org>
10646 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
10647 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
10648 (Expression.ConvertReferenceExplicit): Likewise.
10650 * expression.cs (ElementAccess.DoResolve): Likewise.
10651 (ElementAccess.DoResolveLValue): Likewise.
10653 2002-06-10 Martin Baulig <martin@gnome.org>
10655 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
10656 add the "value" parameter to the parameter list.
10658 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
10661 2002-06-19 Miguel de Icaza <miguel@ximian.com>
10663 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
10664 the argument to an int, uint, long or ulong, per the spec. Also
10665 catch negative constants in array creation.
10667 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
10669 * class.cs: do not allow the same interface to appear twice in
10670 the definition list.
10672 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
10674 * ecore.cs: don't use ldlen with System.Array.
10676 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
10678 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
10680 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
10682 * modifiers.cs: produce correct field attributes for protected
10683 internal. Easy fix so miguel can work on ther harder stuff:-)
10685 2002-06-18 Miguel de Icaza <miguel@ximian.com>
10687 * pending.cs: New file. Move the code from class.cs here.
10688 Support clearning the pending flag for all methods (when not doing
10689 explicit interface implementation).
10691 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
10693 * rootcontext.cs: added a couple more types needed to bootstrap.
10695 2002-06-17 Miguel de Icaza <miguel@ximian.com>
10697 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
10698 constructor in the type, instead of any constructor in the type
10699 hierarchy. Thanks to Paolo for finding this bug (it showed up as
10700 a bug in the Mono runtime when applying the params attribute).
10702 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10703 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
10705 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
10707 * expression.cs (Unary.ResolveOperator): Use TypeManager
10708 to resolve the type.
10710 2002-06-13 Ravi Pratap <ravi@ximian.com>
10712 * cs-parser.jay (enum_member_declaration): Pass in the attributes
10715 * enum.cs (AddEnumMember): Add support to store the attributes associated
10716 with each member too.
10718 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
10719 field builders too - this takes care of the enum member case.
10721 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
10723 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
10724 address-of operator on both value types and pointers.
10726 2002-06-10 Martin Baulig <martin@gnome.org>
10728 * interface.cs (Interface.PopulateIndexer): Add the indexer's
10729 PropertyBuilder to the `property_builders' list.
10731 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
10732 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
10733 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
10734 find any indexers which are inherited from an interface.
10736 2002-06-09 Martin Baulig <martin@gnome.org>
10738 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
10739 the same type as the constant if necessary. There's also a test-130.cs
10742 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
10744 * typemanager.cs (TypeManager.ChangeType): Previously known as
10745 Enum.ChangeEnumType().
10747 2002-06-09 Martin Baulig <martin@gnome.org>
10749 * expression.cs (Cast.TryReduce): Added support for consts.
10751 2002-06-08 Ravi Pratap <ravi@ximian.com>
10753 * class.cs (Accessor): Hold attributes information so we can pass
10756 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
10757 Modify to pass in attributes attached to the methods.
10759 (add_accessor_declaration, remove_accessor_declaration): Ditto.
10761 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
10762 to handle the Accessor kind :-)
10764 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
10766 2002-06-08 Martin Baulig <martin@gnome.org>
10768 * expression.cs (Unary.TryReduceNegative): Added support for
10771 2002-06-08 Martin Baulig <martin@gnome.org>
10773 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
10774 name can't be found in the `defined_names' - the caller will do a
10775 MemberLookup in this case and thus find methods in System.Enum
10776 such as Enum.IsDefined().
10778 2002-06-08 Martin Baulig <martin@gnome.org>
10780 * enum.cs (Enum.ChangeEnumType): This is a custom version of
10781 Convert.ChangeType() which works with TypeBuilder created types.
10782 (Enum.LookupEnumValue, Enum.Define): Use it here.
10784 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
10785 `TypeBuilder.BaseType != null' check.
10786 (TypeContainer.FindMembers): Only lookup parent members if we
10787 actually have a parent.
10788 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
10789 (ConstructorInitializer.Resolve): Likewise.
10791 * interface.cs (Interface.FindMembers): Added
10792 `TypeBuilder.BaseType != null' check.
10794 * rootcontext.cs (RootContext.ResolveCore): Added
10795 "System.Runtime.CompilerServices.IndexerNameAttribute" to
10796 classes_second_stage.
10798 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
10799 debug_type and trace_type when compiling with --nostdlib.
10801 2002-06-07 Martin Baulig <martin@gnome.org>
10803 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
10804 (AddField): Set it to true when adding a non-static field.
10805 (DefineType): Use `have_nonstatic_fields' to find out whether we
10806 have non-static fields, not `Fields != null'.
10808 2002-06-02 Miguel de Icaza <miguel@ximian.com>
10810 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
10811 dereferencing a null on the static-field code path)
10813 2002-05-30 Martin Baulig <martin@gnome.org>
10815 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
10816 to take command line arguments. Use reflection to call the new
10817 custom `Initialize' function on the symbol writer and pass it the
10818 command line arguments.
10820 * driver.cs (--debug-args): New command line argument to pass command
10821 line arguments to the symbol writer.
10823 2002-05-28 Miguel de Icaza <miguel@ximian.com>
10825 * assign.cs (DoResolve): Forgot to do the implicit conversion to
10826 the target type for indexers and properties. Thanks to Joe for
10829 2002-05-27 Miguel de Icaza <miguel@ximian.com>
10831 * typemanager.cs (MethodFlags): returns the method flags
10832 (Obsolete/ShouldIgnore) that control warning emission and whether
10833 the invocation should be made, or ignored.
10835 * expression.cs (Invocation.Emit): Remove previous hack, we should
10836 not do this on matching a base type, we should do this based on an attribute
10838 Only emit calls to System.Diagnostics.Debug and
10839 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
10840 on the command line.
10842 * rootcontext.cs: Global settings for tracing and debugging.
10844 * cs-tokenizer.cs (define): New utility function to track
10845 defines. Set the global settings for TRACE and DEBUG if found.
10847 2002-05-25 Ravi Pratap <ravi@ximian.com>
10849 * interface.cs (Populate*): Pass in the TypeContainer as well as
10850 the DeclSpace as parameters so that we can create EmitContexts and
10851 then use that to apply attributes etc.
10853 (PopulateMethod, PopulateEvent, PopulateProperty)
10854 (PopulateIndexer): Apply attributes everywhere.
10856 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
10859 (ApplyAttributes): Update accordingly.
10861 We now apply interface attributes for all members too.
10863 2002-05-26 Miguel de Icaza <miguel@ximian.com>
10865 * class.cs (Indexer.Define); Correctly check if we are explicit
10866 implementation (instead of checking the Name for a ".", we
10867 directly look up if the InterfaceType was specified).
10869 Delay the creation of the PropertyBuilder.
10871 Only create the PropertyBuilder if we are not an explicit
10872 interface implementation. This means that explicit interface
10873 implementation members do not participate in regular function
10874 lookups, and hence fixes another major ambiguity problem in
10875 overload resolution (that was the visible effect).
10877 (DefineMethod): Return whether we are doing an interface
10880 * typemanager.cs: Temporary hack until we get attributes in
10881 interfaces (Ravi is working on that) and we get IndexerName
10882 support in interfaces.
10884 * interface.cs: Register the indexers as properties.
10886 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
10887 warning, I have verified that this is a bug in the .NET runtime
10888 (JavaScript suffers of the same problem).
10890 * typemanager.cs (MemberLookup): When looking up members for
10891 interfaces, the parent of an interface is the implicit
10892 System.Object (so we succeed in searches of Object methods in an
10893 interface method invocation. Example: IEnumerable x; x.ToString
10896 2002-05-25 Miguel de Icaza <miguel@ximian.com>
10898 * class.cs (Event): Events should also register if they do
10899 implement the methods that an interface requires.
10901 * typemanager.cs (MemberLookup); use the new GetInterfaces
10904 (GetInterfaces): The code used to lookup interfaces for a type is
10905 used in more than one place, factor it here.
10907 * driver.cs: Track the errors at the bottom of the file, we kept
10910 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
10911 instance if the method we are calling is static!
10913 2002-05-24 Miguel de Icaza <miguel@ximian.com>
10915 * attribute.cs (ApplyAttributes): Make this function filter out
10916 the IndexerName attribute (as that attribute in reality is never
10917 applied) and return the string constant for the IndexerName
10920 * class.cs (TypeContainer.Emit): Validate that all the indexers
10921 have the same IndexerName attribute, and if so, set the
10922 DefaultName attribute on the class.
10924 * typemanager.cs: The return value might contain other stuff (not
10925 only methods). For instance, consider a method with an "Item"
10926 property and an Item method.
10928 * class.cs: If there is a problem with the parameter types,
10931 2002-05-24 Ravi Pratap <ravi@ximian.com>
10933 * ecore.cs (ImplicitConversionExists): Wrapper function which also
10934 looks at user defined conversion after making a call to
10935 StandardConversionExists - we need this for overload resolution.
10937 * expression.cs : Update accordingly the various method calls.
10939 This fixes 2 bugs filed against implicit user defined conversions
10941 2002-05-22 Miguel de Icaza <miguel@ximian.com>
10943 * statement.cs: Track the result of the assignment.
10945 2002-05-21 Miguel de Icaza <miguel@ximian.com>
10947 * expression.cs (MemberAccess): Improved error reporting for
10948 inaccessible members.
10950 2002-05-22 Martin Baulig <martin@gnome.org>
10952 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
10953 itself with debugging support.
10955 2002-05-22 Martin Baulig <martin@gnome.org>
10957 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
10958 Removed, this isn't needed anymore.
10960 2002-05-20 Martin Baulig <martin@gnome.org>
10962 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
10963 be underlying type for an enum.
10965 2002-05-20 Miguel de Icaza <miguel@ximian.com>
10967 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
10968 that splits out the loading of just the core types.
10970 * rootcontext.cs (ResolveCore): Split the struct resolution in
10971 two, so we can load the enumeration underlying types before any
10974 * expression.cs (Is): Bandaid until we fix properly Switch (see
10975 bug #24985 for details).
10977 * typemanager.cs (ImplementsInterface): The hashtable will contain
10978 a null if there are no interfaces implemented.
10980 2002-05-18 Miguel de Icaza <miguel@ximian.com>
10982 * cs-parser.jay (indexer_declarator): It is fine to have array
10985 2002-05-17 Miguel de Icaza <miguel@ximian.com>
10987 * typemanager.cs: (RegisterBuilder): New function used to register
10988 TypeBuilders that implement interfaces. Since
10989 TypeBuilder.GetInterfaces (as usual) does not work with lame
10991 (AddUserType): register interfaces.
10993 (ImplementsInterface): Use the builder_to_ifaces hash if we are
10994 dealing with TypeBuilder. Also, arrays are showing up as
10995 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
10996 methods can not be invoked on them!
10998 * ecore.cs (ExplicitReferenceConversionExists): Made public.
10999 (ImplicitReferenceConversionExists): Split out from
11000 StandardConversionExists.
11002 * expression.cs (As): We were only implementing one of the three
11003 cases for the as operator. We now implement them all.
11004 (Is): Implement the various other cases for Is as well.
11006 * typemanager.cs (CACHE): New define used to control if we want or
11007 not the FindMembers cache. Seems to have a negative impact on
11008 performance currently
11010 (MemberLookup): Nested types have full acess to
11011 enclosing type members
11013 Remove code that coped with instance/static returns for events, we
11014 now catch this in RealFindMembers.
11016 (RealFindMembers): only perform static lookup if the instance
11017 lookup did not return a type or an event.
11019 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11021 * assign.cs (CompoundAssign): We pass more semantic information
11022 now to Compound Assignments than we did before: now we have all
11023 the information at hand, and now we resolve the target *before* we
11024 do the expression expansion, which allows the "CacheValue" method
11025 to have the effect we intended (before, a [x] += 1 would generate
11026 two differen ArrayAccess expressions from the ElementAccess,
11027 during the resolution process).
11029 (CompoundAssign.DoResolve): Resolve target and original_source here.
11031 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11033 * expression.cs (ArrayAccess): dropped debugging information.
11035 * typemanager.cs: Small bug fix: I was always returning i_members,
11036 instead of one of i_members or s_members (depending on which had
11039 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11040 method is invoked before any code generation takes place, and it
11041 is a mechanism to inform that the expression will be invoked more
11042 than once, and that the method should use temporary values to
11043 avoid having side effects
11045 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11047 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11050 * expression.cs (Indirection, ArrayAccess): Add support for
11051 CacheTemporaries in these two bad boys.
11053 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11054 ldobj or ldind_ref.
11055 (StoreFromPtr): Handle stobj as well.
11057 * expression.cs (UnaryMutator): Share more code.
11059 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11060 down: I was not tracking the Filter function as well, which
11061 was affecting the results of the cache.
11063 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11065 * attribute.cs: Remove the hack to handle the CharSet property on
11068 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11070 * attribute.cs (DoResolve): More uglyness, we now only try to
11071 resolve the attribute partially, to extract the CharSet
11072 information (only if we are a StructLayout attribute). Otherwise
11074 (GetExtraTypeInfo): Add some code to conditionally kill in the
11075 future this. I am more and more convinced that the .NET
11076 framework has special code to handle the attribute setting on
11079 * expression.cs (IsParamsMethodApplicable): Revert my previous
11080 foreach change here, it was wrong.
11082 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11084 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11085 (pp_expr): do not abort on unknown input, just return.
11086 (eval): abort if there are pending chars.
11088 * attribute.cs (Attribute.Resolve): Positional parameters are
11089 optional. Deal with that case.
11091 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11092 the Ansi/Unicode/Auto information for the type.
11094 (TypeContainer.DefineType): instantiate the EmitContext here, as
11095 we will be using it during the type definition (to resolve
11096 attributes) and during the emit phase.
11098 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11099 to pull type information out of the attributes
11101 (Attribute.Resolve): track the constructor builder, and allow for
11102 multiple invocations (structs and classes will use this).
11104 * ecore.cs (MemberLookupFinal): new version with all the
11105 parameters customizable.
11107 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11108 constructors. Return if the result value is null (as the error
11109 would have been flagged already by MemberLookupFinal)
11111 Do not allow instances of abstract classes or interfaces to be
11114 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11115 We have to compare the assembly property here when dealing with
11116 FamANDAssem and Assembly access modifiers, because we might be
11117 creating an assembly from *modules* (that means that we are not
11118 getting TypeBuilders for types defined in other modules that are
11119 part of this assembly).
11121 (Method.Emit): If the method is marked abstract and has a body,
11124 (TypeContainer.DefineMembers): If both the defined member and the
11125 parent name match are methods, then do not emit any warnings: let
11126 the Method.Define routine take care of flagging warnings. But if
11127 there is a mismatch (method overrides something else, or method is
11128 overriwritten by something, then emit warning).
11130 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11131 set to null, this means `do not check for the return type on the
11134 (Method.Define): set the return type for the method signature to
11135 null, so that we get methods with the same name and parameters and
11136 different return types. This is used to flag warning 114 (you are
11137 hiding a method, and you probably want to use the new/override
11140 * typemanager.cs (MemberLookup): Implemented proper access
11141 control, closing a long standing set of bug reports. The problem
11142 was that the Framework only has two bits: Public and NonPublic,
11143 and NonPublic includes private and protected methods, but we need
11144 to enforce the FamANDAssem, FamOrAssem and Family.
11146 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11148 * statement.cs (GotoCase): Return true: Ammounts to giving up
11149 knowledge on whether we return or not, and letting the other case
11150 be responsible for it.
11152 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11154 * driver.cs: Do not load directories for each file processed, only
11155 do it if there is a pattern.
11157 * ecore.cs: Report readonly assigns here as well, as we might have
11158 been resolved only by MemberAccess.
11160 (SimpleName.SimpleNameResolve): Also be useful for LValue
11161 resolution. We need this to propagate assign to local readonly variables
11163 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11164 do not want to reuse potential criteria memory.
11166 * class.cs (MyEventBuilder): Set reflected_type;
11168 * ecore.cs (Constantify): Added support for constifying bools.
11170 (RootContext.LookupType): Added a cache for values looked up in
11171 the declaration space.
11173 * typemanager.cs (FindMembers): Now is a front-end to
11174 RealFindMembers, and provides a two-level hashtable-based cache to
11177 15% performance improvement: from 22.5 to 19.2 seconds.
11179 * expression.cs (IsParamsMethodApplicable): use foreach.
11180 (Invocation.DoResolve): ditto.
11181 (New.DoResolve): ditto.
11182 (ArrayCreation.DoResolve): ditto.
11184 * ecore.cs (FindMostEncompassingType): use foreach.
11186 * delegate.cs (NewDelegate.DoResolve): Use foreach
11188 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11189 (RemoveMethods): use foreach.
11191 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11192 nested foreach statements instead of for, and also break out of
11193 the inner loop once a match is found.
11195 (Invocation.OverloadResolve): Use foreach, simplify the code.
11197 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11199 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11200 we actually unwrap the expression to allow for extra information
11203 * expression.cs: Use Shr_Un on unsigned operations.
11205 2002-05-08 Ravi Pratap <ravi@ximian.com>
11207 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11208 applicable operators was not being considered correctly. This closes
11209 the bug Miguel reported.
11211 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11213 * attribute.cs: check that the type derives from System.Attribute
11214 and report the correct error in that case (moved the duplicate code to
11215 its own method, too).
11217 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11219 * attribute.cs: lookup attribute type name as the spec says: first the
11220 bare attribute name and then name + "Attribute" (nant compiles with
11221 mcs after this fix).
11223 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11225 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11226 Because of the way we parse things, we should try to see if a
11227 UIntConstant can fit in an integer.
11229 2002-05-07 Ravi Pratap <ravi@ximian.com>
11231 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11232 when we are in an explicit context.
11234 (ConvertReferenceExplicit): When converting from Iface type S to Class
11235 T make sure the rules are implemented as an OR.
11237 * parameter.cs (ParameterType): Make it a property for now although the
11238 purpose really isn't anything immediate.
11240 * expression.cs (Is*Applicable): Do better checking on the parameter type
11241 of a ref/out parameter. The ones from the system assemblies are already
11242 marked with the correct type so we don't need to do any correction.
11244 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11245 the object type is standard too so include that.
11247 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11249 * ecore.cs (StandardConversionExists): Augment with missing code:
11250 deal with IntConstant, LongConstants and Enumerations.
11252 * assign.cs: Report the error, instead of failing silently
11254 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11255 typecontainer that they are declared, because the
11256 typecontainer/namespace will have the list of using clauses that
11257 need to be applied.
11259 Assembly Attributes were escaping the normal registration
11262 (EmitCode): Apply attributes within an EmitContext that represents
11263 the container they were declared on.
11265 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11267 2002-05-06 Ravi Pratap <ravi@ximian.com>
11269 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11270 Revamp completely - make much cleaner as we now operate only
11273 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11274 to implement the logic detailed in the spec more correctly.
11276 (UserDefinedConversion): Update accordingly.
11278 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11280 * statement.cs: Return flow analysis information up.
11282 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11285 (token): Do not consume an extra character before calling
11288 2002-05-06 Piers Haken <piersh@friskit.com>
11290 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11292 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11294 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11295 EmitContext during the instance constructor initializer
11296 resolution, to stop access to instance variables.
11298 This is mandated by the spec, last paragraph of the `constructor
11299 initializers' section.
11301 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11303 * cs-parser.jay, class.cs (Accessor): new class used to represent
11304 an accessor (get or set). In the past we used `null' to represent
11305 a missing accessor. But this is ambiguous because there was no
11306 way to tell in abstract indexers/properties if one of them was
11309 Now there is a way of addressing that.
11311 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11312 instead of FindMembers.
11314 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11315 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11317 * attribute.cs: Treat indexers and properties as the same in terms
11318 of applying attributes
11320 * ecore.cs (FindMostEncompassedType): Use statically initialized
11321 EmptyExpressions()s like we do elsewhere to avoid creating useless
11322 objects (and we take this out of the tight loop).
11324 (GetConversionOperators): Move the code to extract the actual
11325 operators to a separate routine to clean things up.
11327 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11329 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11330 events are always registered FieldBuilders.
11332 * class.cs (FieldBase): New class shared by Fields
11334 * delegate.cs: If we are a toplevel delegate, use our full name.
11335 If we are a nested delegate, then only use our tail name.
11337 2002-05-02 Ravi Pratap <ravi@ximian.com>
11339 * expression.cs (IsApplicable): Ensure that we add the "&" to
11340 ref/out types before comparing it with the type of the argument.
11342 (IsParamsMethodApplicable): Ditto.
11344 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11347 * delegate.cs : Handle the case when we have more than one applicable
11348 method. Flag an error only when we finish checking all.
11350 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11352 * expression.cs: Add support for boolean static initializers.
11354 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11356 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11358 * parameter.cs (ComputeParameterTypes,
11359 ComputeAndDefineParameterTypes): Better error handling: now we
11360 clear the `types' cache if we fail during any of the type lookups.
11361 We also return the status code correctly to our caller
11363 * delegate.cs: If we fail to define a delegate, abort the extra
11366 * expression.cs (Binary.ResolveOperator): for
11367 operator==(object,object) and operator !=(object, object) we also
11368 have to verify that there is an implicit conversion from one to
11371 (ArrayAccess.DoResolve): Array Access can operate on
11374 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11376 * assign.cs (CompoundAssign): A new class used as a "flag" that
11377 the assignment actually is happening as part of a compound
11378 assignment operator.
11380 During compound assignment, a few new rules exist to enable things
11387 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11388 to the type of x) if y is implicitly convertible to the type of x,
11389 and the operator is a builtin operator and the return type of the
11390 operator is explicitly convertible to the type of x.
11392 * rootcontext.cs: Reset warning level to 2. 4 catches various
11393 "interesting" features in mcs, we must clean this up at some
11394 point, but currently am trying to kill other bugs ;-)
11396 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11397 in container classes as well.
11399 * expression.cs (Binary.ResolveOperator): Handle string case
11400 before anything else (as operator overloading does emit an error
11401 before doing anything else).
11403 This code could go away when we move to a table driven model, but
11404 i could not come up with a good plan last night.
11406 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11408 * typemanager.cs (CSharpName): reimplementation using regex.
11409 * class.cs: added null check for fields in Emit
11410 * rootcontext.cs: set warninglevel to 4
11412 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11414 * typemanager.cs (CSharpName): reimplemented with Lupus
11417 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11419 * statement.cs (If): correclty implement Resolve, because we were
11420 not catching sem errors in there. The same process is needed
11422 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11425 (Statement.Warning_DeadCodeFound): Factorize code.
11426 (While): Report dead code here too.
11428 (Statement): Added Resolve virtual method to allow
11429 for resolution split from the emit code.
11431 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11433 * statement.cs (EmitBoolExpression): No longer try to resolve the
11435 (MakeBoolean): New utility function that resolve, implicitly
11436 converts to boolean and tags the expression.
11439 (If, Do): Implement dead code elimination.
11440 (While): Implement loop inversion
11442 (Do, While, For, If): Resolve the expression prior to calling our
11445 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11448 - added method Report28 (warning: program has more than one entry point)
11449 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11450 - modified method Method.Define, the part at the end of the method
11452 * rootcontext.cs: added static public Location EntryPointLocation;
11454 * ../errors/cs0028.cs : Add test case for the above warning.
11457 - modified method CSharpName to allow arrays of primitive type to
11458 be printed nicely (e.g. instead of System.Int32[][] it now prints
11460 - added method CSharpSignature: returns the signature of a method
11461 in string format to be used in reporting errors, warnings, etc.
11463 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11466 2002-04-26 Ravi Pratap <ravi@ximian.com>
11468 * delegate.cs (Define): Fix extremely silly bug where I was
11469 setting the type of the 'object' parameter of the BeginInvoke
11470 method to System.IAsyncResult instead of System.Object ;-)
11472 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11474 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11477 (Constructor.Emit): return if we fail to initialize the
11478 constructor. Another door closed!
11480 * expression.cs (New.DoResolve): Improve error message (from -6 to
11481 1501). Use DeclaredOnly lookup to find the exact constructor.
11483 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11484 loop. This is useful.
11486 * cs-parser.jay: Adjust the default parameters so that destructors
11487 have the proper signature.
11489 2002-04-26 Martin Baulig <martin@gnome.org>
11491 * driver.cs (LoadAssembly): If `assembly' contains any characters
11492 which are only valid in path names and not in assembly names
11493 (currently slash, backslash and point), use Assembly.LoadFrom ()
11494 instead of Assembly.Load () on the `assembly' (before iteration
11495 over the link_paths).
11497 2002-04-26 Martin Baulig <martin@gnome.org>
11499 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11501 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11503 * class.cs (Property): use the new typemanager.MemberLookup
11505 (TypeContainer.MemberLookup): Implement using the
11506 TypeManager.MemberLookup now.
11508 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11509 and return MemberInfos, so that these can be used without an
11510 EmitContext (what we had before).
11512 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11514 * expression.cs: Fix the case where the argument to params if the
11515 type of the params. I omitted handling this before. Fixed
11517 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11519 * driver.cs: Call BootCorlib_PopulateCoreType
11521 * class.cs (Property.CheckBase): Check for properties only, not
11524 * interface.cs: Temporary hack: try/catch around the
11525 CustomAttributeBuilder, because I am getting an exception that I
11528 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11529 types whose definitions are required to be there (attributes are
11530 defined before standard types).
11532 Compute definitions as we boot the various types, as they are used
11533 immediately (value_type class will need object_type, but if we do
11534 not initialize object_type, we will pass a null, which will let
11535 the runtime pick the System.Object from the existing corlib, which
11536 is not what we want).
11538 2002-04-22 Patrik Torstensson <totte@labs2.com>
11540 * cs-tokenizer.cs: fixed a number of trim() issues.
11542 2002-04-22 Ravi Pratap <ravi@ximian.com>
11544 * expression.cs (Argument.Type): Ensure that we return the correct
11545 type when we have out or ref parameters [in which case we
11548 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11550 * class.cs (Property, Indexer): Allow extern modifier in there.
11552 * typemanager.cs (InitBaseTypes): Initializes object_type and
11553 value_type, since those will be used early on during the bootstrap
11554 process to compile corlib.
11556 (InitCoreTypes): Move code from here to InitBaseTypes.
11558 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11560 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11561 single-dimension arrays as using the ldlen opcode.
11563 Daniel Lewis discovered this optimization.
11565 * typemanager.cs: Add signature for System.Array::get_Length
11567 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11569 * statement.cs: report the error when the foreach does not apply to an
11570 array nor a collection.
11572 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11574 * expression.cs: Add implicit conversions to the operator ~.
11576 * constant.cs (DecimalConstant.Emit): Emit decimal value.
11578 * typemanager.cs: Locate the decimal constructor.
11580 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11582 * attribute.cs: use the new property of TypeOf.
11583 * expression.cs: added 'get' property around typearg.
11585 These changes fix a build breaker reported by NickD. Is this the
11586 correct way to fix? If not, please, revert my changes and make it
11589 2002-04-17 Miguel de Icaza <miguel@ximian.com>
11591 * attribute.cs: Add support for typeof in attribute invocations.
11592 I am not sure that this is right though.
11594 2002-04-14 Duncan Mak <duncan@ximian.com>
11596 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
11597 Binary.Operator.Division case.
11599 2002-04-13 Ravi Pratap <ravi@ximian.com>
11601 * class.cs (DefineType): Ensure that we do a proper check on
11602 attribute types and also register it with the TypeManager.
11604 (TypeContainer.Targets): The default for attribute types is
11605 AttributeTargets.All.
11607 * attribute.cs (ApplyAttributes): Registering the attribute type
11608 is done elsewhere, not when we discover we have a Usage attribute.
11610 2002-04-12 Ravi Pratap <ravi@ximian.com>
11612 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
11613 and get rid of is_delegate parameter.
11615 * everywhere : update.
11617 2002-04-12 Ravi Pratap <ravi@ximian.com>
11619 * cs-parser.jay (compilation_unit): Revamp completely to use
11620 some new ideas that I got from Rhys' grammar to solve the problems
11621 with assembly level attributes.
11623 (outer_declaration): New grammar production.
11625 (attribute_sections): Add.
11627 (opt_attributes): Base on attribute_sections
11629 (namespace_declaration): Allow opt_attributes to tackle the case
11630 when we have assembly level attributes - we are clever in this
11633 * attribute.cs (ApplyAttributes): Do not worry about assembly
11634 attributes in the non-global context.
11636 * rootcontext.cs (AddGlobalAttributes): Go back to using this
11637 instead of SetGlobalAttributes.
11639 * class.cs, rootcontext.cs : Ensure we define and generate
11640 attribute types before anything else.
11642 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
11643 and flag the new error -20 for the case when the attribute type
11644 does not have valid targets specified. csc does not catch this.
11646 * ../errors/errors.txt : update for error # -20
11648 2002-04-11 Ravi Pratap <ravi@ximian.com>
11650 * support.cs (InternalParameters.ParameterModifier): Do some null
11651 checking and return sane values.
11653 * class.cs (Method.Define): If we are a PInvoke method, ensure
11654 that we are static and extern. Report error # 601
11656 * ../errors/cs0601.cs : Add test case for the above error.
11658 2002-04-07 Ravi Pratap <ravi@ximian.com>
11660 * rootcontext.cs (attribute_types): We need to keep type of
11661 all attribute types separately and emit code for them first.
11663 (RegisterAttribute) : Implement.
11665 * class.cs (DefineType): Check if the current Type is a custom
11666 attribute type and register it accordingly.
11668 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
11669 adding the first attribute twice and rename to
11671 (SetGlobalAttributes): this.
11673 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
11676 * attribute.cs (ApplyAttributes): Take an additional argument telling us
11677 if we are processing global arguments. Hmm, I am unsure of this.
11679 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11681 * expression.cs: added static array of strings to avoid calling
11682 Enum.ToString () for Operator in Binary. Significant recover of
11685 2002-04-10 Miguel de Icaza <miguel@ximian.com>
11687 * class.cs (FindMembers): Allow the Builders of the various
11688 members to be null. If they are skip them. This only happens
11689 during the PInvoke declaration.
11691 2002-04-09 Miguel de Icaza <miguel@ximian.com>
11693 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
11694 failure, so we do not keep going afterwards.
11696 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
11697 wanted to pass `false' as the `is_delegate' argument. If this is
11698 the case, why not use delegate_type == null to mean `is_delegate =
11699 false' and anything else as is_delegate = true.
11701 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
11703 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
11704 code for the section, not the beginning of the tests.
11706 2002-04-08 Miguel de Icaza <miguel@ximian.com>
11708 * cfold.cs: Handle operator + (Enum x, Underlying x)
11710 * expression.cs (Binary): same. Warn about errors where we have
11711 Enum/Enum in operator + as well.
11713 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
11716 - added support for switch(bool)
11717 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
11718 - add TableSwitchEmit() to handle table-based switch statements
11720 2002-04-05 Ravi Pratap <ravi@ximian.com>
11722 * expression.cs (Invocation.OverloadResolve): Factor out code which
11723 does parameter compatibility checking with arguments so that we can
11724 re-use the code even from Delegate.VerifyApplicability
11726 (VerifyArgumentsCompat): Move above code here.
11728 * delegate.cs (VerifyApplicability): Get rid of duplicate code
11729 and instead make a call to the above method.
11731 2002-03-31 Ravi Pratap <ravi@ximian.com>
11733 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
11734 We use it to keep track of classes which are attribute types.
11736 2002-04-02 Miguel de Icaza <miguel@ximian.com>
11738 * delegate.cs (Delegate.Define): Correctly define the types in the
11739 presence of fixed and array parameters.
11741 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
11744 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
11745 include NonPublic after the first iteration.
11747 * class.cs (Indexer.CheckBase): Only check if both parents are
11750 * cs-parser.jay (accessor_body): If empty, set to null.
11752 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
11753 same code path here to resolve constants names that we did have in
11754 MemberAccess.DoResolve. There is too much code duplicated here.
11756 2002-04-01 Miguel de Icaza <miguel@ximian.com>
11758 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
11760 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
11763 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
11764 tokens, numbers and strings.
11766 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
11769 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
11770 asyncronous parameters and the regular parameters.
11772 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
11773 specify the target directory.
11775 * expression.cs: (This.DoResolve): Simplify
11776 (As.Emit): Optimize, do not generate IsInst if the expression is
11777 always of the given type.
11779 (Is.DoResolve): Bug fix, we were reporting both always/never for
11782 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
11783 creating too many unnecessary arrays.
11785 2002-03-31 Miguel de Icaza <miguel@ximian.com>
11787 * class.cs (EmitFieldInitializer): Use Assign expression to assign
11788 fields instead of rolling our own initializer. Takes care of all
11789 implicit conversions, and drops unnecessary static checks/argument.
11791 2002-03-31 Dick Porter <dick@ximian.com>
11793 * driver.cs: use the GetDirectories() return values properly, and
11794 use "/" as path separator.
11796 2002-03-30 Miguel de Icaza <miguel@ximian.com>
11798 * expression.cs (Unary): Optimize - - expr into expr.
11799 (Binary): Optimize a + (-b) into a -b.
11801 * codegen.cs (CodeGen): Made all methods static.
11803 2002-03-29 Miguel de Icaza <miguel@ximian.com>
11807 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
11808 TypeBuilder property.
11810 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
11813 * tree.cs: Removed the various RecordXXXX, and replaced with a
11814 single RecordDecl. Removed all the accessor methods, and just
11815 left a single access point Type
11817 * enum.cs: Rename DefineEnum to DefineType.
11819 * decl.cs: New abstract method `DefineType' used to unify the
11820 Defines for Enumerations, Interfaces, TypeContainers and
11823 (FindType): Moved LookupInterfaceOrClass here. Moved the
11824 LookupBaseClasses method that used to live in class.cs and
11825 interface.cs here, and renamed to FindType.
11827 * delegate.cs: Implement DefineType. Take advantage of the
11828 refactored pattern for locating the parent builder without taking
11829 the parent_builder argument (which we know does not work if we are
11830 nested, and triggering a toplevel definition).
11832 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11834 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
11835 accessibility of a member has changed during override and report
11838 * class.cs (Method.Define, Property.Define): Only complain on
11839 overrides if the method is private, any other accessibility is
11840 fine (and since we just checked the permission is the same, we are
11843 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
11844 and elif are processed always. The other pre-processing
11845 directives are only processed if we are "taking" the path
11847 2002-03-29 Martin Baulig <martin@gnome.org>
11849 * class.cs (Method.Emit): Only emit symbolic debugging info if the
11850 current location is not Null.
11852 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
11853 a separate method so we can profile it.
11855 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
11856 `span.Seconds' are just seconds, but no minutes or hours.
11857 (MainDriver): Profile the CodeGen.SaveSymbols calls.
11859 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11861 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
11862 Remove the gratuitous set of Final:
11864 // If an interface implementation, then we can set Final.
11865 if (((flags & MethodAttributes.Abstract) == 0) &&
11866 implementing.DeclaringType.IsInterface)
11867 flags |= MethodAttributes.Final;
11869 I do not know what I was smoking when I used that.
11872 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
11873 step into fixing the name resolution issues for delegates and
11874 unifying the toplevel name resolution.
11876 2002-03-28 Martin Baulig <martin@gnome.org>
11878 * class.cs (Method.Emit): If we have a symbol writer, call its
11879 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
11880 tell it about the current method.
11882 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
11883 writer that we're going to emit the first byte of IL code for a new
11884 statement (a new source line).
11885 (EmitContext.EmitTopBlock): If we have a symbol writer, call
11886 EmitContext.Mark() before emitting any code.
11888 * location.cs (SymbolDocument): Return null when we're Null.
11890 * statement.cs (Statement): Moved the `Location loc' variable here.
11891 (Statement.EmitBoolExpression): If we have a symbol writer, call
11892 ec.Mark() before emitting any code to tell it that we're at the
11893 beginning of a new statement.
11894 (StatementExpression): Added `Location' argument to the constructor.
11895 (Block): Added public readonly variable `StartLocation' and public
11896 variable `EndLocation'. The latter is to be set using SetEndLocation().
11897 (Block): Added constructor which takes a start and end location.
11898 (Block.SetEndLocation): New method. This sets the end location.
11899 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
11900 local variables we create.
11901 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
11902 each statement and do also mark the begin and end of the block.
11904 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
11905 tell it the current lexer.Location, use Location.Null for the end of the
11907 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
11908 current block, set its end location using SetEndLocation().
11909 (statement_expression): StatementExpression constructor now takes the
11910 lexer.Location as additional argument.
11911 (for_statement, declare_local_variables): Likewise.
11912 (declare_local_variables): When creating a new implicit block, use the
11913 new Block constructor and pass it the lexer.Location.
11915 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11917 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
11918 members also on the parent interfaces recursively.
11920 2002-03-27 Miguel de Icaza <miguel@ximian.com>
11922 * report.cs: Use new formats, since Gonzalo finished the missing
11925 * expression.cs (Binary.ResolveOperator): added missing operator|
11926 operator& and operator^ for bool/bool.
11928 * cs-parser.jay: CheckDef now takes a Location argument that is
11929 used to report errors more precisly (instead of reporting the end
11930 of a definition, we try to track something which is a lot closer
11931 to the source of the problem).
11933 * cs-tokenizer.cs: Track global token use, so we can properly flag
11934 the use of #define/#undef after the first token has been seen.
11936 Also, rename the reportXXXX to Error_DescriptiveName
11938 * decl.cs (DeclSpace.IsTopLevel): Move property here from
11939 TypeContainer, so that Enum and Interface can use this too.
11941 * class.cs (TypeContainer.LookupInterfaceOrClass,
11942 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
11943 `builder' argument. Typically this was used to pass the parent
11944 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
11947 The problem is that a nested class could trigger the definition of
11948 a toplevel class, and the builder would be obviously wrong in that
11951 So we drop this argument, and we compute dynamically the
11952 TypeBuilder/ModuleBuilder (the correct information was available
11953 to us anyways from DeclSpace.Parent)
11955 * interface.cs (Interface.DefineInterface): Drop builder
11956 parameter cleanup like class.cs
11958 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
11961 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
11964 (Try.Emit): Propagate the returns value from the statement.
11966 (Return.Emit): Even if we are leavning
11968 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
11970 * modifiers.cs: Fix the computation of MethodAttributes flags.
11972 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
11974 * driver.cs: allow compilation of files that start with '/'.
11975 Add a default case when checking the argument of --target.
11977 2002-03-25 Miguel de Icaza <miguel@ximian.com>
11979 * interface.cs: Implement the same search algorithm for types in
11980 the interface code.
11982 * delegate.cs: Do not allow multiple definition.
11984 * Recovered ChangeLog that got accidentally amputated
11986 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
11988 * rootcontext.cs: Load manually enum to allow core classes to
11989 contain enumerations.
11991 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
11992 Update to new static methods in TypeManager.
11994 * typemanager.cs (GetMethod, GetConstructor): Use our
11995 implementation of FindMembers to find the members, since during
11996 corlib compilation, the types are TypeBuilders and GetMethod and
11997 GetConstructor do not work.
11999 Make all methods in TypeManager static.
12001 (InitCodeHelpers): Split the functionality from
12002 the InitCodeTypes function.
12004 * driver.cs: Call InitCodeHelpers after we have populated the
12007 * cs-parser.jay (delegate_declaration): we did not used to compute
12008 the delegate name correctly for void delegates.
12010 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12012 * rootcontext.cs (RootContext): Init the interface_resolve_order
12013 and type_container_resolve_order always.
12015 (ResolveCore, BootstrapCorlib_ResolveClass,
12016 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12017 compiler when compiling with --nostdlib
12019 * class.cs (TypeContainer.DefineType): Check that our parent is
12020 not null. This test is most important when we are bootstraping
12023 * codegen.cs: Split out the symbol writing code.
12025 2002-03-25 Martin Baulig <martin@gnome.org>
12027 * driver.cs (-g): Made -g an alias for --debug.
12029 2002-03-24 Martin Baulig <martin@gnome.org>
12031 * codegen.cs (SymbolWriter): New public variable. Returns the
12032 current symbol writer.
12033 (CodeGen): Added `bool want_debugging_support' argument to the
12034 constructor. If true, tell the ModuleBuild that we want debugging
12035 support and ask it for the ISymbolWriter.
12036 (Save): If we have a symbol writer, call it's Close() method after
12037 saving the assembly.
12039 * driver.c (--debug): New command line argument to create a
12040 debugger information file.
12042 * location.cs (SymbolDocument): New public property. Returns an
12043 ISymbolDocumentWriter object for the current source file or null
12044 if we don't have a symbol writer.
12046 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12048 * driver.cs (LoadAssembly): Correctly return when all the paths
12049 have been tried and not before.
12051 * statement.cs (Switch.Emit): return the actual coverage for this
12052 statement (returns/not-returns)
12054 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12055 switch of the statement if we are the last switch section. That
12056 kills two problems: try/catch problems (we used to emit an empty
12057 nop at the end) and switch statements where all branches would
12060 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12062 * driver.cs: Add default assemblies (the equivalent to the
12063 Microsoft CSC.RSP file)
12065 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12066 also update tokens_seen and set it to false.
12068 * driver.cs: Implement --recurse for Mike.
12070 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12071 correctly splitting out the paths.
12073 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12075 * interface.cs (Interface.PopulateProperty): Instead of using
12076 `parent' as the declaration space for the set parameters, use
12079 * support.cs (InternalParameters): InternalParameters constructor
12080 takes a DeclSpace instead of a TypeContainer.
12082 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12083 types are being initialized, load the address of it before calling
12086 (New): Provide a mechanism to disable the generation of local
12087 value type temporaries when the caller will be providing us with
12088 an address to store it.
12090 (ArrayCreation.EmitDynamicInitializers): Use it.
12092 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12094 * expression.cs (Invocation.EmitArguments): Only probe for array
12095 property if there is more than one argument. Sorry about that.
12097 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12098 empty param arrays.
12100 * class.cs (Method.LabelParameters): Fix incorrect code path that
12101 prevented the `ParamArrayAttribute' from being applied to the
12104 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12106 * support.cs (ReflectionParameters): Correctly compute whether the
12107 last argument is a params array. Fixes the problem with
12110 * typemanager.cs: Make the assemblies array always be non-null
12111 (empty, but non-null)
12113 * tree.cs (RecordDecl): New function that abstracts the recording
12114 of names. This reports error 101, and provides a pointer to the
12115 previous declaration. Fixes a crash in the compiler.
12117 * cs-parser.jay (constructor_declaration): Update to new grammar,
12118 and provide a constructor_body that can be empty.
12120 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12122 * driver.cs: Add support for --resources.
12124 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12125 Make all types for the various array helper methods be integer.
12127 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12128 CheckState to ConvCast.
12130 (ConvCast): Now it takes a `checked' state argument, to avoid
12131 depending on the emit context for the conversion, and just using
12132 the resolve time setting.
12134 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12135 instead of Invocation.EmitArguments. We do not emit the original
12136 arguments, instead we emit those which have been converted to
12137 unsigned int expressions.
12139 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12141 * codegen.cs: ditto.
12143 * expression.cs (LocalVariableReference): Drop the use of the
12144 Store function that depended on the variable index.
12146 * statement.cs (VariableInfo): Drop the `Idx' property from this
12147 class, as this is not taking into account the indexes for
12148 temporaries tat we generate during the execution, getting the
12151 * class.cs: First emit class initializers, then call the parent
12154 * expression.cs (Binary): Fix opcode emision.
12155 (UnaryMutator.EmitCode): Support checked code generation
12157 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12158 matches for events for both the Static and Instance scans,
12159 pointing to the same element. Fix that.
12161 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12163 * rootcontext.cs (ResolveTree): Always set the
12164 interface_resolve_order, because nested interfaces will be calling
12167 * class.cs (GetInterfaceOrClass): Track the same resolution
12168 process used by TypeManager.LookupType. This fixes the nested
12169 type lookups in class declarations (separate path from
12172 (TypeContainer.DefineType): Also define nested interfaces.
12173 (TypeContainer.RegisterOrder): New public function used to
12174 register the order in which child interfaces need to be closed.
12176 Nested interfaces need to be closed after their parents have been
12179 * interface.cs (InterfaceAttr): Put all the logic for computing
12180 the interface attribute here.
12182 (DefineInterface): Register our interface order with the
12183 RootContext or with the TypeContainer depending on the case.
12185 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12187 * cs-parser.jay: rework foreach statement to work with the new
12188 changes to the policy on SimpleNames.
12190 * report.cs: support Stacktrace on warnings as well.
12192 * makefile: drop --unsafe and /unsafe from the compile.
12194 2002-03-13 Ravi Pratap <ravi@ximian.com>
12196 * ecore.cs (StandardConversionExists): Modify to take an Expression
12197 as the first parameter. Ensure we do null -> reference type conversion
12200 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12201 temporary Expression objects.
12203 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12205 * interface.cs: workaround bug in method overloading resolution
12206 (there is already a bugzilla bug for it).
12208 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12210 We could also solve this problem by having a separate path for
12211 performing type lookups, instead of DoResolve, we could have a
12212 ResolveType entry point, and only participating pieces of the
12213 production (simplename, deref, array) would implement this.
12215 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12216 signal SimpleName to only resolve type names and not attempt to
12217 resolve anything else.
12219 * expression.cs (Cast): Set the flag.
12221 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12223 * class.cs: Only report 108 if there is no `new' modifier.
12225 * cs-parser.jay: rework foreach statement to work with the new
12226 changes to the policy on SimpleNames.
12228 * report.cs: support Stacktrace on warnings as well.
12230 * makefile: drop --unsafe and /unsafe from the compile.
12232 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12234 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12235 lookups here, instead of doing that at parse time. This means
12236 that our grammar will not introduce `LocalVariableReferences' as
12237 expressions at this point. That solves the problem of code like
12241 static void Main ()
12245 This is only half the fix. The full fix requires parameters to
12246 also be handled in this way.
12248 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12249 makes the use more obvious of the DeclSpace. The
12250 ec.TypeContainer.TypeBuilder is now only used to pull the
12251 TypeBuilder for it.
12253 My theory is that I can get rid of the TypeBuilder completely from
12254 the EmitContext, and have typecasts where it is used (from
12255 DeclSpace to where it matters).
12257 The only pending problem is that the code that implements Aliases
12258 is on TypeContainer, and probably should go in DeclSpace.
12260 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12261 lookups here, instead of doing that at parse time. This means
12262 that our grammar will not introduce `LocalVariableReferences' as
12263 expressions at this point. That solves the problem of code like
12267 static void Main ()
12271 This is only half the fix. The full fix requires parameters to
12272 also be handled in this way.
12274 * class.cs (Property.DefineMethod): When implementing an interface
12275 method, set newslot, when implementing an abstract method, do not
12276 set the flag (before we tried never setting it, or always setting
12277 it, which is the difference).
12278 (Indexer.DefineMethod): same.
12279 (Method.DefineMethod): same.
12281 * ecore.cs: Only set the status used flag if we get back a Field.
12283 * attribute.cs: Temporary hack, so Paolo can keep working.
12285 2002-03-08 Ravi Pratap <ravi@ximian.com>
12287 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12288 the unmanaged type in the case we have a MarshalAs attribute.
12290 (Resolve): Handle the case when we are parsing the special MarshalAs
12291 attribute [we need to store the unmanaged type to use later]
12293 * typemanager.cs (marshal_as_attr_type): Built in type for the
12294 MarshalAs Attribute.
12296 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12297 on parameters and accordingly set the marshalling info.
12299 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12301 * class.cs: Optimizing slightly by removing redundant code after
12302 we switched to the `NoTypes' return value.
12303 (Property.DefineMethod): use NoTypes here too.
12305 This fixes the bug I introduced in my last batch of changes.
12307 2002-03-05 Ravi Pratap <ravi@ximian.com>
12309 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12311 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12312 Enums since those are types too.
12314 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12316 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12317 thanks to a call during the lookup process.
12319 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12321 * statement.cs (Foreach): Lots of work to accomodate a particular
12322 kind of foreach statement that I had not kept in mind. It is
12323 possible to have foreachs on classes that provide a GetEnumerator
12324 method that return objects that implement the "pattern" for using
12325 a foreach, there is no need to support GetEnumerator
12328 This is needed to compile nant.
12330 * decl.cs: Only report 114 if the member is not `Finalize' and if
12331 the warning level is at least 2.
12333 * class.cs: Moved the compare function from Method to
12336 (MethodSignature.InheritableMemberSignatureCompare): Add new
12337 filter function that is used to extract inheritable methods from a
12340 (Method.Define): Use the new `inheritable_method_signature_filter'
12343 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12346 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12348 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12350 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12352 * expression.cs: Pass location information to
12353 ConvertImplicitStandard.
12355 * class.cs: Added debugging code to track return values from
12358 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12360 * expression.cs (Is.DoResolve): If either side of the `is' is an
12361 interface, do not flag the warning.
12363 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12366 * report.cs: Allow for --fatal to be used with --probe.
12368 * typemanager.cs (NoTypes): Move the definition for the empty Type
12371 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12373 (TypeContainer.DefineProxy): New function used to proxy to parent
12374 implementations when implementing interfaces.
12375 (TypeContainer.ParentImplements): used to lookup if our parent
12376 implements a public function that is required by an interface.
12377 (TypeContainer.VerifyPendingMethods): Hook this up.
12379 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12380 `modules' and `assemblies' arraylists into arrays. We only grow
12381 these are the very early start up of the program, so this improves
12382 the speedof LookupType (nicely measured).
12384 * expression.cs (MakeByteBlob): Replaced unsafe code with
12385 BitConverter, as suggested by Paolo.
12387 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12388 folding of string concatenation, but if either side is a string,
12389 and the other is not, then return null, and let the runtime use
12390 the concatenation on the string plus the object (using
12391 `Object.ToString').
12393 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12395 Constant Folding has been implemented now.
12397 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12398 the error instead on types that are not supported in one's
12401 * constant.cs (Constant and all children): New set of functions to
12402 perform implict and explicit conversions.
12404 * ecore.cs (EnumConstant): Implement the new functions to perform
12405 conversion by proxying to the child expression.
12407 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12408 own separate setting that can not be turned off from the command
12409 line using --unchecked or --checked and is only controlled using
12410 the checked/unchecked statements and expressions. This setting is
12411 used by the constant folder to flag errors.
12413 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12414 ConstantCheckState as well.
12416 During Resolve, they also have to flag the state, because the
12417 constant folder runs completely in the Resolve phase.
12419 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12422 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12424 * cfold.cs: New file, this file contains the constant folder.
12426 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12427 argument to track whether we are using the resulting address to
12428 load or store a value and provide better error messages.
12430 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12431 new AddressOf arguments.
12433 * statement.cs (Foreach.EmitCollectionForeach): Update
12435 * expression.cs (Argument.Emit): Call AddressOf with proper
12436 arguments to track usage.
12438 (New.DoEmit): Call AddressOf with new arguments.
12440 (Unary.Emit): Adjust AddressOf call.
12442 2002-03-01 Ravi Pratap <ravi@ximian.com>
12444 * cs-parser.jay (member_access): Change the case for pre-defined types
12445 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12448 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12451 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12452 essentially like methods and apply attributes like MethodImplOptions to them too.
12454 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12457 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12458 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12461 * Update code everywhere accordingly.
12463 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12465 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12467 2002-02-28 Ravi Pratap <ravi@ximian.com>
12469 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12470 try performing lookups against those instead of jumping straight into using
12471 the 'using' clauses.
12473 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12475 (LookupType): Perform lookups in implicit parents too.
12477 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12478 sequence as RootContext.LookupType.
12480 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12481 the various cases of namespace lookups into this method.
12483 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12485 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12486 in positional arguments)
12488 * class.cs (Operator): Update the AllowedModifiers to contain
12491 * cs-parser.jay: Update operator declaration to allow for the
12492 operator body to be empty.
12494 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12497 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12499 * class.cs (Method.Emit): Label parameters.
12501 * driver.cs: Return 1 or 0 as the program exit code.
12503 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12505 * expression.cs: Special case the `null' object when trying to
12506 auto-compute the type, as anything can be explicitly converted to
12509 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12510 spotting this Paolo.
12512 (Expression.ImplicitNumericConversion): Perform comparissions of
12513 the type using the underlying type in the case of an enumeration
12514 rather than using the enumeration type for the compare.
12516 Cope with the underlying == type case, which is not possible to
12519 (Expression.ConvertNumericExplicit): Perform comparissions of
12520 the type using the underlying type in the case of an enumeration
12521 rather than using the enumeration type for the compare.
12523 * driver.cs: If the user does not supply an extension, assume .exe
12525 * cs-parser.jay (if_statement): Rewrote so that we can track the
12526 location for the if statement.
12528 * expression.cs (Binary.ConstantFold): Only concat strings when
12529 the operation is "+", not everything ;-)
12531 * statement.cs (Statement.EmitBoolExpression): Take a location
12533 (If, While, Do): Track location.
12535 * expression.cs (Binary.ResolveOperator): In the object + string
12536 case, I was missing a call to ConvertImplicit
12538 2002-02-25 Ravi Pratap <ravi@ximian.com>
12540 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
12541 Location arguments. Ensure we use RootContext.LookupType to do our work
12542 and not try to do a direct Type.GetType and ModuleBuilder.GetType
12544 * interface.cs (PopulateMethod): Handle the type of the parameter being
12547 * expression.cs (Invocation.BetterFunction): Handle the case when we
12548 have a params method with no fixed arguments and a call is made with no
12551 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12553 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12554 the verbatim-string-literal
12556 * support.cs (InternalParameters.ParameterModifier): handle null
12558 (InternalParameters.ParameterType): ditto.
12560 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12561 duplicating the name of the variable parameter.
12562 (GetParameterByName): Fix bug where we were not looking up array
12563 paramters if they were the only present (thanks Paolo!).
12564 (GetParameterInfo): We only have an empty set of types if both
12565 fixed and array are set to null.
12566 (GetParameterInfo-idx): Handle FixedParameter == null
12568 * cs-parser.jay: Handle the case where there is no catch
12569 statements (missing null test).
12571 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12573 * driver.cs (MainDriver): Be conservative on our command line
12576 Catch DirectoryNotFoundException when calling GetFiles.
12578 (SplitPathAndPattern): Used to split the input specification into
12579 a path and a pattern that we can feed to Directory.GetFiles.
12581 2002-02-21 Miguel de Icaza <miguel@ximian.com>
12583 * statement.cs (Fixed): Implement the last case of the Fixed
12584 statement (string handling).
12586 * expression.cs (StringPtr): New class used to return a char * to
12587 a string; Used by the Fixed statement.
12589 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
12591 * expression.cs (Binary.ResolveOperator): Remove redundant
12592 MemberLookup pn parent type.
12593 Optimize union call, we do not need a union if the types are the same.
12594 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
12597 Specialize the use of MemberLookup everywhere, instead of using
12598 the default settings.
12600 (StackAlloc): Implement stackalloc keyword.
12602 * cs-parser.jay: Add rule to parse stackalloc.
12604 * driver.cs: Handle /h, /help, /?
12606 * expression.cs (MakeByteBlob): Removed the hacks we had in place
12607 before we supported unsafe code.
12609 * makefile: add --unsafe to the self compilation of mcs.
12611 2002-02-20 Miguel de Icaza <miguel@ximian.com>
12613 * expression.cs (PointerArithmetic): New class that is used to
12614 perform pointer arithmetic.
12615 (Binary.Resolve): Handle pointer arithmetic
12616 Handle pointer comparission.
12617 (ArrayPtr): Utility expression class that is used to take the
12618 address of an array.
12620 (ElementAccess): Implement array access for pointers
12622 * statement.cs (Fixed): Implement fixed statement for arrays, we
12623 are missing one more case before we are done.
12625 * expression.cs (Indirection): Implement EmitAssign and set the
12626 ExprClass to Variable. This allows pointer dereferences to be
12627 treated as variables, and to have values assigned to them.
12629 * ecore.cs (Expression.StoreFromPtr): New utility function to
12630 store values dereferencing.
12632 2002-02-20 Ravi Pratap <ravi@ximian.com>
12634 * expression.cs (Binary.ResolveOperator): Ensure that we are
12635 not trying to operate on a void type - this fixes the reported
12638 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
12639 the parent implementation is sealed.
12641 * ../errors/cs0239.cs : Add.
12643 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
12645 * typemanager.cs (unverifiable_code_type): Corresponds to
12646 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
12647 which have unsafe code in them.
12649 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
12652 2002-02-19 Miguel de Icaza <miguel@ximian.com>
12654 * cs-tokenizer.cs: Add support for @"litreal strings"
12656 Make tokenizer accept pre-processor directives
12657 on any column (remove the old C-like limitation).
12659 * rootcontext.cs (EmitCode): Emit any global attributes.
12660 (AddGlobalAttributes): Used to keep track of assembly attributes.
12662 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
12664 * cs-parser.jay: Add support for global attributes.
12666 2002-02-17 Miguel de Icaza <miguel@ximian.com>
12668 * expression.cs (Indirection): New helper class. Unary will
12669 create Indirection classes to be able to implement the
12670 IMemoryLocation interface on it.
12672 2002-02-16 Miguel de Icaza <miguel@ximian.com>
12674 * cs-parser.jay (fixed_statement): reference the right statement.
12676 * statement.cs (Fixed.Emit): Finish implementing the fixed
12677 statement for the &x case.
12679 2002-02-14 Miguel de Icaza <miguel@ximian.com>
12681 * class.cs (Property.Define, Method.Define): Remove newslot when
12684 * modifiers.cs: My use of NewSlot when `Abstract' was set was
12685 wrong. NewSlot should only be used if the `new' keyword is present.
12687 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
12688 locating our system dir. Sorry about this.
12690 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12692 * driver.cs (GetSystemDir): Compute correctly the location of our
12693 system assemblies. I was using the compiler directory instead of
12694 the library directory.
12696 2002-02-13 Ravi Pratap <ravi@ximian.com>
12698 * expression.cs (BetterFunction): Put back in what Miguel commented out
12699 since it is the correct fix. The problem is elsewhere ;-)
12701 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
12702 parameters of the parms method are themselves compatible or not !
12704 (StandardConversionExists): Fix very dangerous bug where we were forgetting
12705 to check that a class implements an interface before saying that an implicit
12706 conversion was allowed. Use ImplementsInterface to do the checking.
12708 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12710 * class.cs (Method.Define): Track whether we are an explicit
12711 implementation or not. And only call DefineMethodOverride if we
12712 are an explicit implementation.
12714 (Property.DefineMethod): Ditto.
12716 2002-02-11 Ravi Pratap <ravi@ximian.com>
12718 * expression.cs (BetterFunction): Catch hideous bug which was
12719 preventing us from detecting ambiguous calls due to implicit casts i.e
12722 2002-01-29 Miguel de Icaza <miguel@ximian.com>
12724 * support.cs (Pair): Remove un-needed method. I figured why I was
12725 getting the error in cs-parser.jay, the variable in a foreach loop
12726 is readonly, and the compiler does not really treat this as a variable.
12728 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
12729 instead of EQUALS in grammar.
12731 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
12733 * expression.cs (Unary.DoResolve): Check whether the argument is
12736 2002-01-28 Miguel de Icaza <miguel@ximian.com>
12738 * support.cs: Api for Pair to set a value. Despite the fact that
12739 the variables are public the MS C# compiler refuses to compile
12740 code that accesses the field if the variable is part of a foreach
12743 * statement.cs (Fixed): Begin implementation of the fixed
12746 (Block.AddVariable): Return the VariableInfo on success and null
12747 on failure instead of true/false.
12749 * cs-parser.jay (foreach): Catch errors on variables already
12750 defined (we were ignoring this value before) and properly unwind
12751 the block hierarchy
12753 (fixed_statement): grammar for the fixed statement.
12755 2002-01-25 Miguel de Icaza <miguel@ximian.com>
12757 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
12758 pointer types to be incretemented.
12760 (SizeOf): Implement.
12762 * cs-parser.jay (pointer_member_access): Implement
12763 expr->IDENTIFIER production.
12765 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
12766 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
12769 (Unary): Implement indirection.
12771 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
12772 use in non-unsafe context).
12774 (SimpleName.DoResolve): Check for pointers in field access on safe
12777 (Expression.LoadFromPtr): Factor the load-indirect code in this
12778 function. This was duplicated in UnboxCast and ParameterReference
12780 2002-01-24 Miguel de Icaza <miguel@ximian.com>
12782 * expression.cs (ComposedCast): report an error if a pointer cast
12783 is used in a safe region.
12785 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
12786 pointer type casts in unsafe context.
12788 * codegen.cs (EmitContext): Set up IsUnsafe.
12790 * cs-parser.jay (non_expression_type): Add productions for pointer
12793 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
12794 code. We should not use force into static mode if the method is
12795 not virtual. Fixes bug in MIS
12797 * statement.cs (Do.Emit, While.Emit, For.Emit,
12798 Statement.EmitBoolExpression): Add support to Do and While to
12799 propagate infinite loop as `I do return' semantics.
12801 Improve the For case to also test for boolean constants.
12803 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
12804 to the list of attributes we can add.
12806 Remove `EmitContext' argument.
12808 * class.cs (Method.Define): Apply parameter attributes.
12809 (Constructor.Define): Apply parameter attributes.
12810 (MethodCore.LabelParameters): Move here the core of labeling
12813 * support.cs (ReflectionParameters.ParameterModifier,
12814 InternalParameters.ParameterModifier): Use IsByRef on the type and
12815 only return the OUT bit for these parameters instead of in/out/ref
12818 This is because I miss-understood things. The ParameterInfo.IsIn
12819 and IsOut represent whether the parameter has the [In] and [Out]
12822 2002-01-22 Miguel de Icaza <miguel@ximian.com>
12824 * ecore.cs (FieldExpr.Emit): Release temporaries.
12826 * assign.cs (LocalTemporary.Release): new function.
12828 * codegen.cs (EmitContext.GetTemporaryStorage,
12829 EmitContext.FreeTemporaryStorage): Rework the way we deal with
12830 temporary storage. Now we can "put back" localbuilders when we
12833 2002-01-21 Miguel de Icaza <miguel@ximian.com>
12835 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
12836 need to make a copy of the variable to generate verifiable code.
12838 2002-01-19 Miguel de Icaza <miguel@ximian.com>
12840 * driver.cs: Compute dynamically the system directory.
12842 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
12843 Slower, but more generally useful. Used by the abstract
12844 registering implementation.
12846 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
12847 the rules for the special rule on Type/instances. First check if
12848 we have the same name, and if so, try that special static path
12849 rather than the instance path.
12851 2002-01-18 Miguel de Icaza <miguel@ximian.com>
12853 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
12856 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
12857 Enum, ValueType, Delegate or Array for non-corlib compiles.
12859 * cs-tokenizer.cs: Catch long identifiers (645)
12861 * typemanager.cs (IndexerPropetyName): Ravi never tested this
12864 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
12865 fix, we were returning too early, so we were not registering
12866 pending methods from abstract classes.
12868 Do not register pending methods if the class is abstract.
12870 * expression.cs (Conditional.DoResolve): Report circular implicit
12871 conversions when we neecd to compute it for conditional
12874 (Is.DoResolve): If the expression is always of the provided type,
12875 flag warning 183. If the expression can not ever be of the
12876 provided type flag warning 184.
12878 * class.cs: Catch 169 as well.
12880 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
12883 2002-01-18 Nick Drochak <ndrochak@gol.com>
12885 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
12887 2002-01-17 Miguel de Icaza <miguel@ximian.com>
12889 * interface.cs: (PopulateMethod): Check for pointers being defined
12890 only if the unsafe context is active.
12891 (PopulateProperty): ditto.
12892 (PopulateIndexer): ditto.
12894 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
12895 specified. If pointers are present, make sure that they are
12896 present in an unsafe context.
12897 (Constructor, Constructor.Define): ditto.
12898 (Field, Field.Define): ditto.
12899 (Property, Property.Define): ditto.
12900 (Event, Event.Define): ditto.
12902 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
12903 hashtable if there are classes or structs defined.
12905 * expression.cs (LocalVariableReference.DoResolve): Simplify this
12906 code, as the constant resolution moved.
12908 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
12909 the metadata, so we can flag error 133.
12911 * decl.cs (MemberCore.UnsafeOK): New function to test that a
12912 pointer is being declared in an unsafe context.
12914 2002-01-16 Miguel de Icaza <miguel@ximian.com>
12916 * modifiers.cs (Modifiers.Check): Require a Location argument.
12917 Report error 227 for Unsafe use.
12919 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
12921 * statement.cs (For.Emit): If the test is null, then report that
12922 we do `return', as we wont reach anything afterwards.
12924 (Switch.SwitchGoverningType): Track the expression that matched
12927 * driver.cs: Allow negative numbers as an error code to flag.
12929 * cs-parser.jay: Handle 1551.
12931 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
12933 2002-01-15 Miguel de Icaza <miguel@ximian.com>
12935 * cs-parser.jay: Report 1518 (type declaration can only contain
12936 class, struct, interface, enum or delegate)
12938 (switch_label): Report 1523 (keywords `case' or `default' must
12941 (opt_switch_sections): Report 1522 (empty switch)
12943 * driver.cs: Report 1515 (response file specified multiple times)
12944 Report 1516 (Source file specified multiple times).
12946 * expression.cs (Argument.Resolve): Signal 1510
12948 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
12949 access not allowed in static code)
12951 2002-01-11 Ravi Pratap <ravi@ximian.com>
12953 * typemanager.cs (IsPointerType): Utility method which we are going
12956 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
12957 the object type, so we take care of that.
12959 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
12961 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
12962 added to non-params parameters :-)
12964 * typemanager.cs (CSharpName): Include 'void' type too.
12966 (void_ptr_type): Include in the set of core types.
12968 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
12971 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
12974 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
12975 completely forgotten about it.
12977 2002-01-10 Ravi Pratap <ravi@ximian.com>
12979 * cs-parser.jay (pointer_type): Add. This begins our implementation
12980 of parsing rules for unsafe code.
12982 (unsafe_statement): Implement.
12984 (embedded_statement): Modify to include the above.
12986 * statement.cs (Unsafe): Implement new class for unsafe blocks.
12988 * codegen.cs (EmitContext.InUnsafe): Add. This determines
12989 if the current context is an unsafe one.
12991 * cs-parser.jay (local_variable_pointer_type): Since local variable types
12992 are handled differently, we need separate rules for them.
12994 (local_variable_declaration): Update to use local_variable_pointer_type
12995 to allow variable declarations of unmanaged pointer types.
12997 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
12998 in unsafe contexts.
13000 * ../errors/cs0214.cs : Add.
13002 2002-01-16 Nick Drochak <ndrochak@gol.com>
13004 * makefile: remove 'response' file when cleaning.
13006 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13008 * cs-parser.jay: Report 1524.
13010 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13012 * typemanager.cs (RegisterMethod): drop checking if we have
13013 registered this from here
13015 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13017 * class.cs (Method.EmitDestructor): Implement calling our base
13020 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13021 value of InFinally.
13023 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13024 this routine and will wrap the call in a try/catch block. Deal
13027 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13029 * ecore.cs (Expression.MemberLookup): instead of taking a
13030 parameter `same_type' that was used to tell whether we could
13031 access private members we compute our containing type from the
13034 (FieldExpr): Added partial support for volatile fields. This does
13035 not work for volatile fields exposed from assemblies, as I can not
13036 figure out how to extract the modreq from it.
13038 Updated all the source files to use this.
13040 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13041 because it is referenced by MemberLookup very often.
13043 2002-01-09 Ravi Pratap <ravi@ximian.com>
13045 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13046 TypeBuilder.GetCustomAttributes to retrieve what we need.
13048 Get rid of redundant default_member_attr_type as this is the same as
13049 default_member_type which already exists.
13051 * interface.cs, attribute.cs : Update accordingly.
13053 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13055 * typemanager.cs: Enable IndexerPropertyName again. It does not
13056 work for TYpeBuilders though. Ravi, can you please fix this?
13058 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13060 * expression.cs (Argument.Emit): Handle the case of ref objects
13061 being passed to ref functions;
13063 (ParameterReference.EmitLoad): Loads the content of the pointer
13064 without dereferencing.
13066 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13068 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13070 2002-01-08 Ravi Pratap <ravi@ximian.com>
13072 * class.cs (Indexer.DefineMethod): Incorporate the interface
13073 type in the name of the method if we are doing explicit interface
13076 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13078 (BetterConversion): Fix extremely trivial bug where we were referring to
13079 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13082 * ../errors/bug16.cs : Add although we have fixed it.
13084 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13086 * expression.cs (BaseIndexer): Begin implementation.
13088 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13090 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13091 production directly to remove a shift/reduce, and implement
13092 explicit interface implementation.
13094 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13095 after a floating point suffix.
13097 * expression.cs (DoNumericPromotions): Improved the conversion for
13098 uint/uint. If we have a constant, we avoid doing a typecast to a
13101 * class.cs (Indexer): Implement explicit interface implementation
13104 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13106 * class.cs: make the default instance constructor public and hidebysig.
13108 2001-01-03 Ravi Pratap <ravi@ximian.com>
13110 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13111 so we can call it from elsewhere.
13113 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13114 we emit it internally if the class has a defined indexer; otherwise the user
13115 emits it by decorating the class definition with the DefaultMemberAttribute.
13117 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13118 attribute is not used on a type which defines an indexer.
13120 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13121 character when we skip whitespace.
13123 * ../errors/cs0646.cs : Add.
13125 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13127 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13130 * makefile: Add practical target `mcs3.exe' which builds the third
13131 generation compiler.
13133 * expression.cs (New): Fix structures constructor calling.
13135 * class.cs (Property, Method, Indexer): Emit Final flag on the
13136 method if we are an interface implementation and we are not
13139 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13140 whether this property is referencing a `base' method.
13142 * expression.cs (Invocation.EmitCall): take an extra argument:
13143 is_base, this is used to determine whether the `call' or
13144 `callvirt' opcode should be used.
13147 * delegate.cs: update EmitCall.
13149 * class.cs (Method.Define): Set NewSlot for the cases where we are
13150 not implementing an interface method.
13152 (Property.Define): ditto.
13154 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13156 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13157 'r'. Allows mcs to parse itself fully.
13159 2002-01-02 Ravi Pratap <ravi@ximian.com>
13161 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13162 of the number of initializers that require the InitializeArray method.
13164 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13165 update the above field where necessary.
13167 (MakeByteBlob): Update accordingly.
13169 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13172 (EmitDynamicInitializers): Update in accordance with the new optimization.
13174 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13175 same OpCode applies.
13177 * cs-parser.jay : Fix some glaring errors I introduced.
13179 2002-01-01 Ravi Pratap <ravi@ximian.com>
13181 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13182 so that we can check for name clashes there too.
13184 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13185 for interface indexers.
13187 * interfaces.cs (Define): Emit the default member attribute.
13189 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13190 variable was being referred to while setting the value ;-)
13192 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13194 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13195 byte-by-byte information when we know the data is zero.
13197 Make the block always a multiple of 4, because
13198 DefineInitializedData has a bug.
13200 * assign.cs: Fix, we should assign from the temporary, not from
13203 * expression.cs (MakeByteBlob): Fix my incorrect code.
13205 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13207 * typemanager.cs (EnumToUnderlying): This function is used to get
13208 the underlying type from an enumeration, because it does not
13211 * constant.cs: Use the I4_S form for values between -128 and 127.
13213 * statement.cs (Block.LookupLabel): Looks up a label.
13214 (Block): Drop support for labeled blocks.
13216 (LabeledStatement): New kind of statement that represents a label
13219 (Goto): Finally implement this bad boy.
13221 * cs-parser.jay: Update to reflect new mechanism to implement
13224 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13226 * codegen.cs (EmitContext.This): a codegen property that keeps the
13227 a single instance of this instead of creating many different this
13230 * delegate.cs (Delegate.DoResolve): Update to use the property;
13232 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13234 * expression.cs (BaseAccess.DoResolve): Ditto.
13236 2001-12-29 Ravi Pratap <ravi@ximian.com>
13238 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13239 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13241 (InitCoreTypes): Update accordingly.
13243 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13244 so we can quickly store the state.
13246 (ApplyAttributes): Set the correct implementation flags
13247 for InternalCall methods.
13249 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13251 * expression.cs (EmitCall): if a method is not virtual, then do
13252 not use callvirt on it.
13254 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13255 user defined stuff) requires the use of stobj, which takes an
13256 address on the stack instead of an array and an index. So emit
13257 the Ldelema operation for it.
13259 (EmitStoreOpcode): Use stobj for valuetypes.
13261 (UnaryMutator.EmitCode): Use the right 1 value depending on
13262 whether we are dealing with int64/uint64, float or doubles.
13264 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13265 constructors that I implemented last night.
13267 (Constructor.IsDefault): Fix to work properly for static
13270 * cs-parser.jay (CheckDef): report method signature errors.
13271 Update error number 103 to be 132.
13273 * decl.cs: New AdditionResult enumeration value: MethodExists.
13274 Although we do this check for methods later on in the semantic
13275 analysis, catching repeated default constructors is so easy that
13276 we catch these here.
13278 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13281 (ParameterReference.EmitAssign, Emit): handle
13284 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13285 (ArrayAccess.EmitStoreOpcode): ditto.
13287 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13289 * expression.cs (MakeByteBlob): Complete all the missing types
13290 (uint, short, ushort, byte, sbyte)
13292 * class.cs: Only init instance field initializers on instance
13295 Rename `constructors' to instance_constructors.
13297 (TypeContainer.AddConstructor): Only add constructors to the list
13298 if it is not static.
13300 Make sure that we handle default_static_constructor independently
13301 everywhere where we handle instance_constructors
13303 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13305 * class.cs: Do not lookup or create a base initializer for a
13306 static constructor.
13308 (ConstructorInitializer.Resolve): use the proper type to lookup
13311 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13313 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13316 * decl.cs: CloseType is now an virtual method, the default
13317 implementation just closes this type.
13319 2001-12-28 Ravi Pratap <ravi@ximian.com>
13321 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13322 to PreserveSig by default. Also emit HideBySig on such methods.
13324 Basically, set the defaults to standard values.
13326 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13327 argument, if candidate is better, it can't be worse than the best !
13329 (Invocation): Re-write bits to differentiate between methods being
13330 applicable in their expanded form and their normal form - for params
13333 Get rid of use_standard everywhere as only standard conversions are allowed
13334 in overload resolution.
13336 More spec conformance.
13338 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13340 * driver.cs: Add --timestamp, to see where the compiler spends
13343 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13344 `this' in static code.
13346 (SimpleName.DoResolve): Implement in terms of a helper function
13347 that allows static-references to be passed upstream to
13350 (Expression.ResolveWithSimpleName): Resolve specially simple
13351 names when called by MemberAccess to implement the special
13354 (Expression.ImplicitReferenceConversion): Handle conversions from
13355 Null to reference types before others, as Null's type is
13358 * expression.cs (Invocation.EmitCall): Handle the special case of
13359 calling methods declared on a reference type from a ValueType
13360 (Base classes System.Object and System.Enum)
13362 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13363 the left hand side is a TypeExpr, not on every enumeration.
13365 (Binary.Resolve): If types are reference types, then do a cast to
13366 object on operators != and == of both arguments.
13368 * typemanager.cs (FindMembers): Extract instance and static
13369 members if requested.
13371 * interface.cs (PopulateProperty): Use void_type instead of null
13372 as the return type for the setter method.
13374 (PopulateIndexer): ditto.
13376 2001-12-27 Ravi Pratap <ravi@ximian.com>
13378 * support.cs (ReflectionParameters): Fix minor bug where we
13379 were examining the wrong parameter for the ParamArray attribute.
13381 Cope with requests for the type of the parameter at position
13382 greater than the params parameter's. We now return the element
13383 type of the params array as that makes more sense.
13385 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13386 accordingly as we no longer have to extract the element type
13389 (Invocation.OverloadResolve): Update.
13391 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13393 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13394 against IEnumerator, test whether the return value is a descendant
13395 of the IEnumerator interface.
13397 * class.cs (Indexer.Define): Use an auxiliary method to implement
13398 the other bits of the method definition. Begin support for
13399 explicit interface implementation.
13401 (Property.DefineMethod): Use TypeManager.void_type instead of null
13402 for an empty return value.
13404 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13406 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13407 dealing with a FieldExpr which is composed of a FieldBuilder, in
13408 the code path we did extract the constant, but we should have
13409 obtained the underlying value to be able to cast it (otherwise we
13410 end up in an infinite loop, this is what Ravi was running into).
13412 (ArrayCreation.UpdateIndices): Arrays might be empty.
13414 (MemberAccess.ResolveMemberAccess): Add support for section
13415 14.5.4.1 that deals with the special case of E.I when E is a type
13416 and something else, that I can be a reference to a static member.
13418 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13419 handle a particular array type to create byte blobs, it is just
13420 something we dont generate byteblobs for.
13422 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13425 * location.cs (Push): remove the key from the hashtable that we
13426 are about to add. This happens for empty files.
13428 * driver.cs: Dispose files after we have parsed them.
13430 (tokenize): new function that only runs the tokenizer on its
13431 input, for speed testing.
13433 2001-12-26 Ravi Pratap <ravi@ximian.com>
13435 * class.cs (Event.Define): Define the private field only if there
13436 are no accessors defined.
13438 * expression.cs (ResolveMemberAccess): If there is no associated
13439 field with the event, that means we have an event defined with its
13440 own accessors and we should flag error cs0070 since transforming
13441 ourselves into a field is not valid in that case.
13443 * ecore.cs (SimpleName.DoResolve): Same as above.
13445 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13446 and charset to sane values.
13448 2001-12-25 Ravi Pratap <ravi@ximian.com>
13450 * assign.cs (DoResolve): Perform check on events only if they
13451 are being accessed outside the declaring type.
13453 * cs-parser.jay (event_declarations): Update rules to correctly
13454 set the type of the implicit parameter etc.
13456 (add_accessor, remove_accessor): Set current local parameters.
13458 * expression.cs (Binary): For delegate addition and subtraction,
13459 cast the return value from the method into the appropriate delegate
13462 2001-12-24 Ravi Pratap <ravi@ximian.com>
13464 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13465 of these as the workaround is unnecessary.
13467 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13468 delegate data - none of that is needed at all.
13470 Re-write bits to extract the instance expression and the delegate method
13473 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13476 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13477 of attaching attributes instead of duplicating code everywhere.
13479 * everywhere : Update code to do attribute emission using the above method.
13481 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13483 * expression.cs (IsParamsMethodApplicable): if there are not
13484 parameters, return immediately.
13486 * ecore.cs: The 0 literal can be implicity converted to an enum
13489 (SimpleName.DoResolve): First lookup the type, then lookup the
13492 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13493 want to get its address. If the InstanceExpression is not
13494 addressable, store the result in a temporary variable, then get
13497 * codegen.cs: Only display 219 errors on warning level or above.
13499 * expression.cs (ArrayAccess): Make it implement the
13500 IMemoryLocation interface.
13502 (Binary.DoResolve): handle the operator == (object a, object b)
13503 and operator != (object a, object b) without incurring into a
13504 BoxedCast (because 5 != o should never be performed).
13506 Handle binary enumerator operators.
13508 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13509 value type, otherwise use Ldelem_ref.
13511 Use precomputed names;
13513 (AddressOf): Implement address of
13515 * cs-parser.jay (labeled_statement): Fix recursive block
13516 addition by reworking the production.
13518 * expression.cs (New.DoEmit): New has a special case:
13520 If we are dealing with a ValueType, we have a few
13521 situations to deal with:
13523 * The target of New is a ValueType variable, that is
13524 easy, we just pass this as the variable reference
13526 * The target of New is being passed as an argument,
13527 to a boxing operation or a function that takes a
13530 In this case, we need to create a temporary variable
13531 that is the argument of New.
13534 2001-12-23 Ravi Pratap <ravi@ximian.com>
13536 * rootcontext.cs (LookupType): Check that current_type is not null before
13537 going about looking at nested types.
13539 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
13540 not implement the IAssignMethod interface any more.
13542 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
13543 where we tranform them into FieldExprs if they are being resolved from within
13544 the declaring type.
13546 * ecore.cs (SimpleName.DoResolve): Do the same here.
13548 * assign.cs (DoResolve, Emit): Clean up code considerably.
13550 * ../errors/bug10.cs : Add.
13552 * ../errors/cs0070.cs : Add.
13554 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13556 * assign.cs : Get rid of EventIsLocal everywhere.
13558 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13560 * ecore.cs (ConvertIntLiteral): finished the implementation.
13562 * statement.cs (SwitchLabel): Convert the value we are using as a
13563 key before looking up the table.
13565 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13567 * codegen.cs (EmitTopBlock): Require a Location argument now.
13569 * cs-parser.jay (constructor_declarator): We need to setup
13570 current_local_parameters before we parse the
13571 opt_constructor_initializer, to allow the variables to be bound
13572 to the constructor arguments.
13574 * rootcontext.cs (LookupType): First lookup nested classes in our
13575 class and our parents before we go looking outside our class.
13577 * expression.cs (ConstantFold): Extract/debox the values at the
13580 * rootcontext.cs (EmitCode): Resolve the constants first before we
13581 resolve the types. This is not really needed, but it helps debugging.
13583 * statement.cs: report location.
13585 * cs-parser.jay: pass location to throw statement.
13587 * driver.cs: Small bug fix.
13589 * report.cs: Updated format to be 4-zero filled digits.
13591 2001-12-22 Ravi Pratap <ravi@ximian.com>
13593 * expression.cs (CheckIndices): Fix minor bug where the wrong
13594 variable was being referred to ;-)
13596 (DoEmit): Do not call EmitStaticInitializers when the
13597 underlying type is System.Object.
13599 2001-12-21 Ravi Pratap <ravi@ximian.com>
13601 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
13602 and do the usual workaround for SRE.
13604 * class.cs (MyEventBuilder.EventType): New member to get at the type
13605 of the event, quickly.
13607 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
13609 * assign.cs (Assign.DoResolve): Handle the case when the target
13610 is an EventExpr and perform the necessary checks.
13612 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
13615 (SimpleName.MemberStaticCheck): Include check for EventExpr.
13617 (EventExpr): Set the type in the constructor itself since we
13618 are meant to be born fully resolved.
13620 (EventExpr.Define): Revert code I wrote earlier.
13622 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
13623 instance expression is null. The instance expression is a This in that case
13624 or a null, depending on whether it is a static method or not.
13626 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
13627 refers to more than one method.
13629 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
13630 and accordingly flag errors.
13632 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13634 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
13636 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13638 * location.cs (ToString): Provide useful rutine.
13640 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13642 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
13643 objects, return the actual integral boxed.
13645 * statement.cs (SwitchLabel): define an ILLabel for each
13648 (Switch.CheckSwitch): If the value is a Literal, extract
13649 the underlying literal.
13651 Also in the unused hashtable we had, add the SwitchLabel so we can
13652 quickly look this value up.
13654 * constant.cs: Implement a bunch of new constants. Rewrite
13655 Literal based on this. Made changes everywhere to adapt to this.
13657 * expression.cs (Expression.MakeByteBlob): Optimize routine by
13658 dereferencing array only once, and also copes with enumrations.
13660 bytes are two bytes wide, not one.
13662 (Cast): Perform constant conversions.
13664 * ecore.cs (TryImplicitIntConversion): Return literals instead of
13665 wrappers to the literals here.
13667 * expression.cs (DoNumericPromotions): long literals can converted
13668 to ulong implicity (this is taken care of elsewhere, but I was
13669 missing this spot).
13671 * ecore.cs (Expression.Literalize): Make the return type Literal,
13672 to improve type checking.
13674 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
13676 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13678 * literal.cs: Revert code from ravi that checked the bounds. The
13679 bounds are sane by the definition of the type itself.
13681 * typemanager.cs: Fix implementation of ImplementsInterface. We
13682 need to actually look up in our parent hierarchy for interfaces
13685 * const.cs: Use the underlying type for enumerations
13687 * delegate.cs: Compute the basename for the delegate creation,
13688 that should fix the delegate test case, and restore the correct
13689 Type Lookup semantics in rootcontext
13691 * rootcontext.cs: Revert Ravi's last patch. The correct way of
13692 referencing a nested type with the Reflection API is using the "+"
13695 * cs-parser.jay: Do not require EOF token at the end.
13697 2001-12-20 Ravi Pratap <ravi@ximian.com>
13699 * rootcontext.cs (LookupType): Concatenate type names with
13700 a '.' instead of a '+' The test suite passes again.
13702 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
13703 field of the enumeration.
13705 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
13706 the case when the member is an EventExpr.
13708 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
13709 static has an associated instance expression.
13711 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
13713 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
13715 * class.cs (Event.Define): Register event and perform appropriate checks
13718 We define the Add and Remove methods even if the use provides none because
13719 in that case, we provide default implementations ourselves.
13721 Define a private field of the type of the event. This is done by the CSC compiler
13722 and we should be doing it too ;-)
13724 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
13725 More methods we use in code we generate.
13727 (multicast_delegate_type, delegate_type): Two separate types since the distinction
13730 (InitCoreTypes): Update accordingly for the above.
13732 * class.cs (Event.Emit): Generate code for default accessors that we provide
13734 (EmitDefaultMethod): Do the job in the above.
13736 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
13739 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13741 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
13742 builders even if we were missing one.
13744 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
13745 pass the Basename as our class name instead of the Name. The
13746 basename will be correctly composed for us.
13748 * parameter.cs (Paramters): Now takes a Location argument.
13750 * decl.cs (DeclSpace.LookupType): Removed convenience function and
13751 make all the code call directly LookupType in RootContext and take
13752 this chance to pass the Location information everywhere.
13754 * Everywhere: pass Location information.
13756 2001-12-19 Miguel de Icaza <miguel@ximian.com>
13758 * class.cs (Constructor.Define): Updated way of detecting the
13759 length of the parameters.
13761 (TypeContainer.DefineType): Use basename as the type name for
13764 (TypeContainer.Define): Do not recursively define types here, as
13765 definition is taken care in order by the RootContext.
13767 * tree.cs: Keep track of namespaces in a per-file basis.
13769 * parameter.cs (Parameter.ComputeSignature): Update to use
13772 (Parameters.GetSignature): ditto.
13774 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
13775 instead of a TypeContainer.
13777 (Interface.SemanticAnalysis): Use `this' instead of our parent to
13778 resolve names. Because we need to be resolve in our context, not
13781 * driver.cs: Implement response files.
13783 * class.cs (TypeContainer.DefineType): If we are defined, do not
13784 redefine ourselves.
13786 (Event.Emit): Emit the code for add/remove handlers.
13787 (Event.Define): Save the MethodBuilders for add/remove.
13789 * typemanager.cs: Use pair here too.
13791 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
13792 DictionaryEntry requires the first argument to be non-null.
13794 (enum_declaration): Compute full name for registering the
13797 (delegate_declaration): Instead of using
13798 formal_parameter_list, use opt_formal_parameter_list as the list
13801 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
13802 (EventParsing): New property that controls whether `add' and
13803 `remove' are returned as tokens or identifiers (for events);
13805 2001-12-19 Ravi Pratap <ravi@ximian.com>
13807 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
13808 use MyEventBuilder only and let it wrap the real builder for us.
13810 (MyEventBuilder): Revamp constructor etc.
13812 Implement all operations that we perform on EventBuilder in precisely the same
13815 (FindMembers): Update to use the EventBuilder member.
13817 (Event.Emit): Update accordingly.
13819 2001-12-18 Ravi Pratap <ravi@ximian.com>
13821 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
13822 by calling the appropriate methods.
13824 (GetCustomAttributes): Make stubs as they cannot possibly do anything
13827 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
13829 2001-12-17 Ravi Pratap <ravi@ximian.com>
13831 * delegate.cs (Delegate.Populate): Check that the return type
13832 and various parameters types are indeed accessible.
13834 * class.cs (Constructor.Define): Same here.
13836 (Field.Define): Ditto.
13838 (Event.Define): Ditto.
13840 (Operator.Define): Check that the underlying Method defined itself
13841 correctly - so it's MethodBuilder should not be null.
13843 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
13844 expression happens to be null.
13846 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
13847 members but as of now we don't seem to be able to do anything really useful with it.
13849 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
13850 not the EventBuilder.
13852 2001-12-18 Miguel de Icaza <miguel@ximian.com>
13854 * cs-tokenizer.cs: Add support for defines.
13855 Add support for #if, #elif, #else, #endif
13857 (eval_var): evaluates a variable.
13858 (eval): stubbed for evaluating functions.
13860 * cs-parser.jay: Pass the defines information
13862 * driver.cs: Add --define command line option.
13864 * decl.cs: Move MemberCore here.
13866 Make it the base class for DeclSpace. This allows us to catch and
13867 report 108 and 109 for everything now.
13869 * class.cs (TypeContainer.Define): Extract all the members
13870 before populating and emit the warning 108 (new keyword required
13871 to override) instead of having each member implement this.
13873 (MemberCore.Define): New abstract method, we will be using this in
13874 the warning reporting engine in Populate.
13876 (Operator.Define): Adjust to new MemberCore protocol.
13878 * const.cs (Const): This does not derive from Expression, it is a
13879 temporary object we use to create fields, it is a MemberCore.
13881 * class.cs (Method.Define): Allow the entry point to be in a
13884 * driver.cs: Rewrite the argument handler to clean it up a bit.
13886 * rootcontext.cs: Made it just an auxiliary namespace feature by
13887 making everything static.
13889 * driver.cs: Adapt code to use RootContext type name instead of
13892 * delegate.cs: Remove RootContext argument.
13894 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
13897 * class.cs (Event.Define): The lookup can fail.
13899 * cs-tokenizer.cs: Begin implementation of pre-procesor.
13901 * expression.cs: Resolve the this instance before invoking the code.
13903 2001-12-17 Miguel de Icaza <miguel@ximian.com>
13905 * cs-parser.jay: Add a production in element_access that allows
13906 the thing to become a "type" reference. This way we can parse
13907 things like "(string [])" as a type.
13909 Note that this still does not handle the more complex rules of
13913 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
13915 * ecore.cs: (CopyNewMethods): new utility function used to
13916 assemble the list of methods from running FindMembers.
13918 (MemberLookup): Rework FindMembers so that
13920 2001-12-16 Miguel de Icaza <miguel@ximian.com>
13922 * class.cs (TypeContainer): Remove Delegates who fail to be
13925 * delegate.cs (Populate): Verify that we dont get null return
13926 values. TODO: Check for AsAccessible.
13928 * cs-parser.jay: Use basename to emit error 574 (destructor should
13929 have the same name as container class), not the full name.
13931 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
13932 possible representation.
13934 Also implements integer type suffixes U and L.
13936 2001-12-15 Miguel de Icaza <miguel@ximian.com>
13938 * expression.cs (ArrayCreation.DoResolve): We need to do the
13939 argument resolution *always*.
13941 * decl.cs: Make this hold the namespace. Hold the root context as
13943 (LookupType): Move here.
13945 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
13947 * location.cs (Row, Name): Fixed the code, it was always returning
13948 references to the first file.
13950 * interface.cs: Register properties defined through interfaces.
13952 * driver.cs: Add support for globbing on the command line
13954 * class.cs (Field): Make it derive from MemberCore as well.
13957 2001-12-15 Ravi Pratap <ravi@ximian.com>
13959 * class.cs (Event::Define): Check that the type of the event is a delegate
13960 type else flag error #66.
13962 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
13965 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
13966 values of EntryPoint, CharSet etc etc.
13968 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
13970 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
13971 be null and we should ignore this. I am not sure if this is really clean. Apparently,
13972 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
13973 which needs this to do its work.
13975 * ../errors/cs0066.cs : Add.
13977 2001-12-14 Miguel de Icaza <miguel@ximian.com>
13979 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
13982 * class.cs: (MethodSignature.MethodSignature): Removed hack that
13983 clears out the parameters field.
13984 (MemberSignatureCompare): Cleanup
13986 (MemberCore): New base class used to share code between MethodCore
13989 (RegisterRequiredImplementations) BindingFlags.Public requires
13990 either BindingFlags.Instace or Static. Use instance here.
13992 (Property): Refactored code to cope better with the full spec.
13994 * parameter.cs (GetParameterInfo): Return an empty array instead
13997 * class.cs (Property): Abstract or extern properties have no bodies.
13999 * parameter.cs (GetParameterInfo): return a zero-sized array.
14001 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14002 method modifier validation to the typecontainer so we can reuse
14003 this on properties.
14005 (MethodCore.ParameterTypes): return an empty sized array of types.
14007 (Property.Define): Test property modifier validity.
14009 Add tests for sealed/override too.
14011 (Method.Emit): abstract or extern methods have no bodies.
14013 2001-12-14 Ravi Pratap <ravi@ximian.com>
14015 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14018 (Method::Define, ::Emit): Modify accordingly.
14020 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14022 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14024 * makefile: Pass in /unsafe.
14026 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14028 * class.cs (MakeKey): Kill routine.
14030 * class.cs (TypeContainer.Define): Correctly define explicit
14031 method implementations (they require the full interface name plus
14034 * typemanager.cs: Deply the PtrHashtable here and stop using the
14035 lame keys. Things work so much better.
14037 This of course broke everyone who depended on `RegisterMethod' to
14038 do the `test for existance' test. This has to be done elsewhere.
14040 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14041 the object stupid Equals method (because, that like fails all over
14042 the place). We still do not use it.
14044 * class.cs (TypeContainer.SetRequiredInterface,
14045 TypeContainer.RequireMethods): Killed these two routines and moved
14046 all the functionality to RegisterRequiredImplementations.
14048 (TypeContainer.RegisterRequiredImplementations): This routine now
14049 registers all the implementations required in an array for the
14050 interfaces and abstract methods. We use an array of structures
14051 which can be computed ahead of time to reduce memory usage and we
14052 also assume that lookups are cheap as most classes will not
14053 implement too many interfaces.
14055 We also avoid creating too many MethodSignatures.
14057 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14058 clear the "pending" bit if we find that there are problems with
14061 (TypeContainer.VerifyPendingMethods): Update to report errors of
14062 methods that look like implementations but are not.
14064 (TypeContainer.Define): Add support for explicit interface method
14067 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14069 * typemanager.cs: Keep track of the parameters here instead of
14070 being a feature of the TypeContainer.
14072 * class.cs: Drop the registration of parameters here, as
14073 InterfaceMethods are also interface declarations.
14075 * delegate.cs: Register methods with the TypeManager not only with
14076 the TypeContainer. This code was buggy.
14078 * interface.cs: Full registation here.
14080 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14082 * expression.cs: Remove reducer for binary expressions, it can not
14085 * const.cs: Put here the code that used to go into constant.cs
14087 * constant.cs: Put here the code for constants, this is a new base
14088 class for Literals.
14090 * literal.cs: Make Literal derive from Constant.
14092 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14094 * statement.cs (Return.Emit): Report error 157 if the user
14095 attempts to return from a finally block.
14097 (Return.Emit): Instead of emitting a return, jump to the end of
14100 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14101 LocalBuilder to store the result of the function. ReturnLabel is
14102 the target where we jump.
14105 2001-12-09 Radek Doulik <rodo@ximian.com>
14107 * cs-parser.jay: remember alias in current namespace
14109 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14112 * class.cs (LookupAlias): lookup alias in my_namespace
14114 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14116 (LookupAlias): lookup alias in this and if needed in parent
14119 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14123 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14124 making things static. I need this to avoid passing the
14125 TypeContainer when calling ParameterType.
14127 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14128 that did string manipulation to compute the type and then call
14129 GetType. Use Parameter.ParameterType instead.
14131 * cs-tokenizer.cs: Consume the suffix for floating values.
14133 * expression.cs (ParameterReference): figure out whether this is a
14134 reference parameter or not. Kill an extra variable by computing
14135 the arg_idx during emission.
14137 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14138 function that returns whether a parameter is an out/ref value or not.
14140 (Parameter.ParameterType): The type of the parameter (base,
14141 without ref/out applied).
14143 (Parameter.Resolve): Perform resolution here.
14144 (Parameter.ExternalType): The full type (with ref/out applied).
14146 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14147 support for expressions on the using statement.
14149 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14151 * statement.cs (Using.EmitLocalVariableDecls): Split the
14152 localvariable handling of the using statement.
14154 (Block.EmitMeta): Keep track of variable count across blocks. We
14155 were reusing slots on separate branches of blocks.
14157 (Try.Emit): Emit the general code block, we were not emitting it.
14159 Check the type of the declaration to be an IDisposable or
14160 something that can be implicity converted to it.
14162 Emit conversions if required.
14164 * ecore.cs (EmptyExpression): New utility class.
14165 (Expression.ImplicitConversionExists): New utility function.
14167 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14169 * statement.cs (Using): Implement.
14171 * expression.cs (LocalVariableReference): Support read only variables.
14173 * statement.cs: Remove the explicit emit for the Leave opcode.
14174 (VariableInfo): Add a readonly field.
14176 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14178 * ecore.cs (ConvCast): new class used to encapsulate the various
14179 explicit integer conversions that works in both checked and
14180 unchecked contexts.
14182 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14183 properly generate the overflow opcodes.
14185 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14187 * statement.cs: The correct type for the EmptyExpression is the
14188 element_type, not the variable type. Ravi pointed this out.
14190 2001-12-04 Ravi Pratap <ravi@ximian.com>
14192 * class.cs (Method::Define): Handle PInvoke methods specially
14193 by using DefinePInvokeMethod instead of the usual one.
14195 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14196 above to do the task of extracting information and defining the method.
14198 2001-12-04 Ravi Pratap <ravi@ximian.com>
14200 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14201 of the condition for string type.
14203 (Emit): Move that here.
14205 (ArrayCreation::CheckIndices): Keep string literals in their expression
14208 (EmitDynamicInitializers): Handle strings appropriately.
14210 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14212 * codegen.cs (EmitContext): Replace multiple variables with a
14213 single pointer to the current Switch statement.
14215 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14218 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14222 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14225 (Foreach.Emit): Foreach on arrays was not setting
14226 up the loop variables (for break/continue).
14228 (GotoCase): Semi-implented.
14230 2001-12-03 Ravi Pratap <ravi@ximian.com>
14232 * attribute.cs (CheckAttribute): Handle system attributes by using
14233 Attribute.GetAttributes to examine information we need.
14235 (GetValidPlaces): Same here.
14237 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14239 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14241 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14243 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14245 (Method::Emit): Handle the case when we are a PInvoke method.
14247 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14249 * expression.cs: Use ResolveWithSimpleName on compound names.
14251 2001-12-02 Ravi Pratap <ravi@ximian.com>
14253 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14254 before trying to reduce it.
14256 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14258 * constant.cs (LookupConstantValue): Implement.
14260 (EmitConstant): Use the above in emitting the constant.
14262 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14263 that are user-defined by doing a LookupConstantValue on them.
14265 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14268 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14270 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14272 (BaseAccess.DoResolve): Implement.
14274 (MemberAccess.DoResolve): Split this routine into a
14275 ResolveMemberAccess routine that can be used independently
14277 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14279 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14280 As that share bits of the implementation. Is returns a boolean,
14281 while As returns the Type that is being probed.
14283 2001-12-01 Ravi Pratap <ravi@ximian.com>
14285 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14286 instead of a Literal - much easier.
14288 (EnumInTransit): Remove - utterly useless :-)
14290 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14292 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14294 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14295 chain when we have no associated expression.
14297 2001-11-30 Ravi Pratap <ravi@ximian.com>
14299 * constant.cs (Define): Use Location while reporting the errror.
14301 Also emit a warning when 'new' is used and there is no inherited
14304 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14307 (LookupEnumValue): Implement to lookup an enum member's value and define it
14310 (Populate): Re-write accordingly to use the above routine.
14312 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14314 * expression.cs (This): Fix prototype for DoResolveLValue to
14315 override the base class DoResolveLValue.
14317 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14320 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14321 (we need to load the address of the field here). This fixes
14324 (FieldExpr.DoResolveLValue): Call the DoResolve
14325 function to initialize the Instance expression.
14327 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14328 correctly the GetEnumerator operation on a value type.
14330 * cs-parser.jay: Add more simple parsing error catches.
14332 * statement.cs (Switch): Add support for string switches.
14333 Handle null specially.
14335 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14337 2001-11-28 Ravi Pratap <ravi@ximian.com>
14339 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14341 (declare_local_constant): New helper function.
14343 * statement.cs (AddConstant): Keep a separate record of constants
14345 (IsConstant): Implement to determine if a variable is a constant.
14347 (GetConstantExpression): Implement.
14349 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14351 * statement.cs (IsVariableDefined): Re-write.
14353 2001-11-27 Ravi Pratap <ravi@ximian.com>
14355 * class.cs (TypeContainer::FindMembers): Look for constants
14356 in the case when we are looking for MemberTypes.Field
14358 * expression.cs (MemberAccess::DoResolve): Check that in the
14359 case we are a FieldExpr and a Literal, we are not being accessed
14360 by an instance reference.
14362 * cs-parser.jay (local_constant_declaration): Implement.
14364 (declaration_statement): Implement for constant declarations.
14366 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14368 * statement.cs (Switch): Catch double defaults.
14370 (Switch): More work on the switch() statement
14371 implementation. It works for integral values now, need to finish
14375 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14377 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14378 integer literals into other integer literals. To be used by
14381 2001-11-24 Ravi Pratap <ravi@ximian.com>
14383 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14386 (EmitDynamicInitializers): Cope with the above since we extract data
14387 directly from ArrayData now.
14389 (ExpectInitializers): Keep track of whether initializers are mandatory
14392 (Bounds): Make it a hashtable to prevent the same dimension being
14393 recorded for every element in that dimension.
14395 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14398 Also fix bug which was causing the indices to be emitted in the reverse
14401 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14403 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14404 unfinished. They do not work, because the underlying code is
14407 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14409 * cs-parser.jay: Remove bogus fixme.
14411 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14412 on Switch statement.
14414 2001-11-23 Ravi Pratap <ravi@ximian.com>
14416 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14419 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14420 parameter. Apparently, any expression is allowed.
14422 (ValidateInitializers): Update accordingly.
14424 (CheckIndices): Fix some tricky bugs thanks to recursion.
14426 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14427 I was being completely brain-dead.
14429 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14430 and re-write acordingly.
14432 (DelegateInvocation): Re-write accordingly.
14434 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14436 (MakeByteBlob): Handle types more correctly.
14438 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14439 initialization from expressions but it is incomplete because I am a complete
14442 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14444 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14445 on If. Basically, we have to return `true' (ie, we do return to
14446 our caller) only if both branches of the if return.
14448 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14449 short-circuit operators, handle them as short circuit operators.
14451 (Cast.DoResolve): Resolve type.
14452 (Cast.Cast): Take an expression as the target type.
14454 * cs-parser.jay (cast_expression): Remove old hack that only
14455 allowed a limited set of types to be handled. Now we take a
14456 unary_expression and we resolve to a type during semantic
14459 Use the grammar productions from Rhys to handle casts (this is
14460 not complete like Rhys syntax yet, we fail to handle that corner
14461 case that C# has regarding (-x), but we will get there.
14463 2001-11-22 Ravi Pratap <ravi@ximian.com>
14465 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14466 field which is an array type.
14468 * cs-parser.jay (declare_local_variables): Support array initialization too.
14470 * typemanager.cs (MakeKey): Implement.
14472 (everywhere): Use the above appropriately.
14474 * cs-parser.jay (for_statement): Update for array initialization while
14475 declaring variables.
14477 * ecore.cs : The error message was correct, it's the variable's names that
14478 were misleading ;-) Make the code more readable.
14480 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14481 the correct type etc.
14483 (ConvertExplicit): Handle Enum types by examining the underlying type.
14485 2001-11-21 Ravi Pratap <ravi@ximian.com>
14487 * parameter.cs (GetCallingConvention): Always return
14488 CallingConventions.Standard for now.
14490 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14492 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14493 and `r' after calling DoNumericPromotions.
14495 * ecore.cs: Fix error message (the types were in the wrong order).
14497 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14498 BindingFlags.Instance as well
14500 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14501 implicit int literal conversion in an empty cast so that we
14502 propagate the right type upstream.
14504 (UnboxCast): new class used to unbox value types.
14505 (Expression.ConvertExplicit): Add explicit type conversions done
14508 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14509 the target type before applying the implicit LongLiterals to ULong
14512 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14514 * cs-parser.jay (for_statement): Reworked the way For works: now
14515 we declare manually any variables that are introduced in
14516 for_initializer to solve the problem of having out-of-band code
14517 emition (that is what got for broken).
14519 (declaration_statement): Perform the actual variable declaration
14520 that used to be done in local_variable_declaration here.
14522 (local_variable_declaration): Do not declare anything, just pass
14523 the information on a DictionaryEntry
14525 2001-11-20 Ravi Pratap <ravi@ximian.com>
14527 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14528 re-write of the logic to now make it recursive.
14530 (UpdateIndices): Re-write accordingly.
14532 Store element data in a separate ArrayData list in the above methods.
14534 (MakeByteBlob): Implement to dump the array data into a byte array.
14536 2001-11-19 Ravi Pratap <ravi@ximian.com>
14538 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
14541 * constant.cs (Define): Implement.
14543 (EmitConstant): Re-write fully.
14545 Pass in location info.
14547 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
14550 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
14551 DictionaryEntry since we need location info too.
14553 (constant_declaration): Update accordingly.
14555 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14556 code into another method : UpdateIndices.
14558 2001-11-18 Ravi Pratap <ravi@ximian.com>
14560 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14561 some type checking etc.
14563 2001-11-17 Ravi Pratap <ravi@ximian.com>
14565 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14566 bits to provide dimension info if the user skips doing that.
14568 Update second constructor to store the rank correctly.
14570 2001-11-16 Ravi Pratap <ravi@ximian.com>
14572 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14573 and try to implement.
14575 * ../errors/cs0150.cs : Add.
14577 * ../errors/cs0178.cs : Add.
14579 2001-11-16 Miguel de Icaza <miguel@ximian.com>
14581 * statement.cs: Implement foreach on multi-dimensional arrays.
14583 * parameter.cs (Parameters.GetParameterByName): Also lookup the
14584 name of the params argument.
14586 * expression.cs: Use EmitStoreOpcode to get the right opcode while
14587 initializing the array.
14589 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
14590 we can use this elsewhere.
14592 * statement.cs: Finish implementation of foreach for single
14595 * cs-parser.jay: Use an out-of-band stack to pass information
14596 around, I wonder why I need this.
14598 foreach_block: Make the new foreach_block the current_block.
14600 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
14601 function used to return a static Parameters structure. Used for
14602 empty parameters, as those are created very frequently.
14604 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
14606 2001-11-15 Ravi Pratap <ravi@ximian.com>
14608 * interface.cs : Default modifier is private, not public. The
14609 make verify test passes again.
14611 2001-11-15 Ravi Pratap <ravi@ximian.com>
14613 * support.cs (ReflectionParameters): Fix logic to determine
14614 whether the last parameter is a params one. Test 9 passes again.
14616 * delegate.cs (Populate): Register the builders we define with
14617 RegisterParameterForBuilder. Test 19 passes again.
14619 * cs-parser.jay (property_declaration): Reference $6 instead
14620 of $$ to get at the location.
14622 (indexer_declaration): Similar stuff.
14624 (attribute): Ditto.
14626 * class.cs (Property): Register parameters for the Get and Set methods
14627 if they exist. Test 23 passes again.
14629 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
14630 call to EmitArguments as we are sure there aren't any params arguments.
14631 Test 32 passes again.
14633 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
14634 IndexOutOfRangeException.
14636 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
14637 Test 33 now passes again.
14639 2001-11-15 Miguel de Icaza <miguel@ximian.com>
14641 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
14642 broke a bunch of things. Will have to come up with a better way
14643 of tracking locations.
14645 * statement.cs: Implemented foreach for single dimension arrays.
14647 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14649 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
14650 an error. This removes the lookup from the critical path.
14652 * cs-parser.jay: Removed use of temporary_loc, which is completely
14655 2001-11-14 Miguel de Icaza <miguel@ximian.com>
14657 * support.cs (ReflectionParameters.ParameterModifier): Report
14658 whether the argument is a PARAMS argument or not.
14660 * class.cs: Set the attribute `ParamArrayAttribute' on the
14661 parameter argument.
14663 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
14664 and cons_param_array_attribute (ConstructorInfo for
14665 ParamArrayAttribute).,
14667 * codegen.cs: Emit the return using the `Return' statement, that
14668 way we can report the error correctly for missing return values.
14670 * class.cs (Method.Emit): Clean up.
14672 * expression.cs (Argument.Resolve): Take another argument: the
14673 location where this argument is used. Notice that this is not
14674 part of the "Argument" class as to reduce the size of the
14675 structure (we know the approximate location anyways).
14677 Test if the argument is a variable-reference, if not, then
14678 complain with a 206.
14680 (Argument.Emit): Emit addresses of variables.
14682 (Argument.FullDesc): Simplify.
14684 (Invocation.DoResolve): Update for Argument.Resolve.
14686 (ElementAccess.DoResolve): ditto.
14688 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
14689 method should be virtual, as this method is always virtual.
14691 (NewDelegate.DoResolve): Update for Argument.Resolve.
14693 * class.cs (ConstructorInitializer.DoResolve): ditto.
14695 * attribute.cs (Attribute.Resolve): ditto.
14697 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14699 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
14701 * expression.cs (ParameterReference): Drop IStackStorage and implement
14702 IAssignMethod instead.
14704 (LocalVariableReference): ditto.
14706 * ecore.cs (FieldExpr): Drop IStackStorage and implement
14707 IAssignMethod instead.
14709 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14711 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
14712 enumerations that are used in heavily used structures derive from
14713 byte in a laughable and pathetic attempt to reduce memory usage.
14714 This is the kind of pre-optimzations that you should not do at
14715 home without adult supervision.
14717 * expression.cs (UnaryMutator): New class, used to handle ++ and
14718 -- separatedly from the other unary operators. Cleans up the
14719 code, and kills the ExpressionStatement dependency in Unary.
14721 (Unary): Removed `method' and `Arguments' from this class, making
14722 it smaller, and moving it all to SimpleCall, so I can reuse this
14723 code in other locations and avoid creating a lot of transient data
14724 strucutres when not required.
14726 * cs-parser.jay: Adjust for new changes.
14728 2001-11-11 Miguel de Icaza <miguel@ximian.com>
14730 * enum.cs (Enum.Populate): If there is a failure during
14733 * cs-parser.jay (opt_enum_base): we used to catch type errors
14734 here, but this is really incorrect. The type error should be
14735 catched during semantic analysis.
14737 2001-12-11 Ravi Pratap <ravi@ximian.com>
14739 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
14740 current_local_parameters as expected since I, in my stupidity, had forgotten
14743 * attribute.cs (GetValidPlaces): Fix stupid bug.
14745 * class.cs (Method::Emit): Perform check on applicability of attributes.
14747 (Constructor::Emit): Ditto.
14749 (Field::Emit): Ditto.
14751 (Field.Location): Store location information.
14753 (Property, Event, Indexer, Operator): Ditto.
14755 * cs-parser.jay (field_declaration): Pass in location for each field.
14757 * ../errors/cs0592.cs : Add.
14759 2001-11-12 Ravi Pratap <ravi@ximian.com>
14761 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
14763 (InitCoreTypes): Update accordingly.
14765 (RegisterAttrType, LookupAttr): Implement.
14767 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
14768 info about the same.
14770 (Resolve): Update to populate the above as necessary.
14772 (Error592): Helper.
14774 (GetValidPlaces): Helper to the above.
14776 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
14778 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
14780 2001-11-12 Ravi Pratap <ravi@ximian.com>
14782 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
14784 * ../errors/cs0617.cs : Add.
14786 2001-11-11 Ravi Pratap <ravi@ximian.com>
14788 * enum.cs (Emit): Rename to Populate to be more consistent with what
14789 we expect it to do and when exactly it is called.
14791 * class.cs, rootcontext.cs : Update accordingly.
14793 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
14794 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
14796 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
14798 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
14799 of a fieldinfo using the above, when dealing with a FieldBuilder.
14801 2001-11-10 Ravi Pratap <ravi@ximian.com>
14803 * ../errors/cs0031.cs : Add.
14805 * ../errors/cs1008.cs : Add.
14807 * ../errrors/cs0543.cs : Add.
14809 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
14812 (FindMembers): Implement.
14814 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
14815 enums and delegates too.
14817 (enum_types): Rename to builder_to_enum.
14819 (delegate_types): Rename to builder_to_delegate.
14821 * delegate.cs (FindMembers): Implement.
14823 2001-11-09 Ravi Pratap <ravi@ximian.com>
14825 * typemanager.cs (IsEnumType): Implement.
14827 * enum.cs (Emit): Re-write parts to account for the underlying type
14828 better and perform checking etc.
14830 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
14831 of the underlying type.
14833 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
14836 * enum.cs (error31): Helper to report error #31.
14838 * cs-parser.jay (enum_declaration): Store location of each member too.
14840 * enum.cs (member_to_location): New hashtable.
14842 (AddEnumMember): Update location hashtable.
14844 (Emit): Use the location of each member while reporting errors.
14846 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14848 * cs-parser.jay: A for_initializer if is a
14849 local_variable_declaration really ammount to have an implicit
14850 block with the variable declaration and no initializer for for.
14852 * statement.cs (For.Emit): Cope with null initializers.
14854 This fixes the infinite loop on for initializers.
14856 2001-11-08 Miguel de Icaza <miguel@ximian.com>
14858 * enum.cs: More cleanup.
14860 * ecore.cs: Remove dead code.
14862 * class.cs (Property.Emit): More simplification.
14863 (Event.Emit): ditto.
14865 Reworked to have less levels of indentation.
14867 2001-11-08 Ravi Pratap <ravi@ximian.com>
14869 * class.cs (Property): Emit attributes.
14879 * enum.cs (Emit): Ditto.
14881 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
14884 * class.cs (Field, Event, etc.): Move attribute generation into the
14885 Emit method everywhere.
14887 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
14888 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
14889 as we had no way of defining nested enums !
14891 * rootcontext.cs : Adjust code accordingly.
14893 * typemanager.cs (AddEnumType): To keep track of enum types separately.
14895 2001-11-07 Ravi Pratap <ravi@ximian.com>
14897 * expression.cs (EvalConstantExpression): Move into ecore.cs
14899 * enum.cs (Enum): Rename some members and make them public and readonly
14900 according to our convention.
14902 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
14905 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
14907 (Enum::Emit): Write a simple version for now which doesn't try to compute
14908 expressions. I shall modify this to be more robust in just a while.
14910 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
14912 (TypeContainer::CloseType): Create the Enum types too.
14914 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
14916 * expression.cs (EvalConstantExpression): Get rid of completely.
14918 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
14919 user-defined values and other cases.
14921 (IsValidEnumLiteral): Helper function.
14923 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
14924 out there in the case we had a literal FieldExpr.
14926 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
14928 (Literalize): Revamp a bit to take two arguments.
14930 (EnumLiteral): New class which derives from Literal to wrap enum literals.
14932 2001-11-06 Ravi Pratap <ravi@ximian.com>
14934 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
14936 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
14938 (Resolve): Use the above to ensure we have proper initializers.
14940 2001-11-05 Ravi Pratap <ravi@ximian.com>
14942 * expression.cs (Expression::EvalConstantExpression): New method to
14943 evaluate constant expressions.
14945 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
14947 2001-11-07 Miguel de Icaza <miguel@ximian.com>
14949 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
14952 (Binary.ResolveOperator): Handle operator != (object a, object b)
14953 and operator == (object a, object b);
14955 (Binary.DoNumericPromotions): Indicate whether the numeric
14956 promotion was possible.
14958 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
14961 Made the ArrayAccess implement interface IAssignMethod instead of
14962 IStackStore as the order in which arguments are passed reflects
14965 * assign.cs: Instead of using expr.ExprClass to select the way of
14966 assinging, probe for the IStackStore/IAssignMethod interfaces.
14968 * typemanager.cs: Load InitializeArray definition.
14970 * rootcontext.cs (RootContext.MakeStaticData): Used to define
14971 static data that can be used to initialize arrays.
14973 2001-11-05 Miguel de Icaza <miguel@ximian.com>
14975 * expression.cs: Handle operator== and operator!= for booleans.
14977 (Conditioal.Reduce): Implement reducer for the ?: operator.
14979 (Conditional.Resolve): Implement dead code elimination.
14981 (Binary.Resolve): Catch string literals and return a new
14982 concatenated string.
14984 (Unary.Reduce): Implement reduction of unary expressions.
14986 * ecore.cs: Split out the expression core handling here.
14988 (Expression.Reduce): New method used to perform constant folding
14989 and CSE. This is needed to support constant-expressions.
14991 * statement.cs (Statement.EmitBoolExpression): Pass true and false
14992 targets, and optimize for !x.
14994 2001-11-04 Ravi Pratap <ravi@ximian.com>
14996 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
14997 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
14998 set custom atttributes.
15000 * literal.cs (Literal::GetValue): New abstract method to return the actual
15001 value of the literal, cast as an object.
15003 (*Literal): Implement GetValue method.
15005 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15006 expressions to the arraylist but objects of type Argument.
15008 * class.cs (TypeContainer::Emit): Emit our attributes too.
15010 (Method::Emit, Constructor::Emit): Ditto.
15012 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15013 to be ignoring earlier.
15015 2001-11-03 Ravi Pratap <ravi@ximian.com>
15017 * attribute.cs (AttributeSection::Define): Implement to do the business
15018 of constructing a CustomAttributeBuilder.
15020 (Attribute): New trivial class. Increases readability of code.
15022 * cs-parser.jay : Update accordingly.
15024 (positional_argument_list, named_argument_list, named_argument): New rules
15026 (attribute_arguments): Use the above so that we are more correct.
15028 2001-11-02 Ravi Pratap <ravi@ximian.com>
15030 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15031 to perform all checks for a method with a params parameter.
15033 (Invocation::OverloadResolve): Update to use the above method and therefore
15034 cope correctly with params method invocations.
15036 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15039 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15040 constructors in our parent too because we can't afford to miss out on
15043 * attribute.cs (AttributeSection): New name for the class Attribute
15045 Other trivial changes to improve readability.
15047 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15048 use the new class names.
15050 2001-11-01 Ravi Pratap <ravi@ximian.com>
15052 * class.cs (Method::Define): Complete definition for params types too
15054 (Indexer::Define): Ditto.
15056 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15057 Cope everywhere with a request for info about the array parameter.
15059 2001-11-01 Ravi Pratap <ravi@ximian.com>
15061 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15063 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15064 local_variable_type to extract the string corresponding to the type.
15066 (local_variable_type): Fixup the action to use the new helper method.
15068 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15071 * expression.cs : Clean out code which uses the above.
15073 2001-10-31 Ravi Pratap <ravi@ximian.com>
15075 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15076 and bale out if necessary by returning a false.
15078 (RegisterProperty): Ditto.
15080 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15081 and print out appropriate error messages.
15083 * interface.cs (everywhere): Ditto.
15085 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15086 location to constructor.
15088 * class.cs (Property, Event, Indexer): Update accordingly.
15090 * ../errors/cs111.cs : Added.
15092 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15093 of a method, as laid down by the spec.
15095 (Invocation::OverloadResolve): Use the above method.
15097 2001-10-31 Ravi Pratap <ravi@ximian.com>
15099 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15100 now take a TypeContainer and a Parameters object.
15102 (ParameterData): Modify return type of ParameterModifier method to be
15103 Parameter.Modifier and not a string.
15105 (ReflectionParameters, InternalParameters): Update accordingly.
15107 * expression.cs (Argument::GetParameterModifier): Same here.
15109 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15110 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15111 symbol in it at all so maybe this is only for now.
15113 2001-10-30 Ravi Pratap <ravi@ximian.com>
15115 * support.cs (InternalParameters): Constructor now takes an extra argument
15116 which is the actual Parameters class.
15118 (ParameterDesc): Update to provide info on ref/out modifiers.
15120 * class.cs (everywhere): Update call to InternalParameters to pass in
15121 the second argument too.
15123 * support.cs (ParameterData): Add ParameterModifier, which is a method
15124 to return the modifier info [ref/out etc]
15126 (InternalParameters, ReflectionParameters): Implement the above.
15128 * expression.cs (Argument::ParameterModifier): Similar function to return
15129 info about the argument's modifiers.
15131 (Invocation::OverloadResolve): Update to take into account matching modifiers
15134 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15135 a new SetFormalParameters object which we pass to InternalParameters.
15137 2001-10-30 Ravi Pratap <ravi@ximian.com>
15139 * expression.cs (NewArray): Merge into the ArrayCreation class.
15141 2001-10-29 Ravi Pratap <ravi@ximian.com>
15143 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15144 NewUserdefinedArray into one as there wasn't much of a use in having
15147 * expression.cs (Argument): Change field's name to ArgType from Type.
15149 (Type): New readonly property which returns the proper type, taking into
15150 account ref/out modifiers.
15152 (everywhere): Adjust code accordingly for the above.
15154 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15155 whether we are emitting for a ref or out parameter.
15157 * expression.cs (Argument::Emit): Use the above field to set the state.
15159 (LocalVariableReference::Emit): Update to honour the flag and emit the
15162 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15164 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15166 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15168 (ReflectionParameters, InternalParameters): Implement the above method.
15170 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15173 (Invocation::FullMethodDesc): Ditto.
15175 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15177 * cs-parser.jay: Add extra production for the second form of array
15180 * expression.cs (ArrayCreation): Update to reflect the above
15183 * Small changes to prepare for Array initialization.
15185 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15187 * typemanager.cs (ImplementsInterface): interface might be null;
15188 Deal with this problem;
15190 Also, we do store negative hits on the cache (null values), so use
15191 this instead of calling t.GetInterfaces on the type everytime.
15193 2001-10-28 Ravi Pratap <ravi@ximian.com>
15195 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15197 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15198 split functionality out into different classes.
15200 (New::FormArrayType): Move into NewBuiltinArray.
15202 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15205 (NewBuiltinArray): New class to handle creation of built-in arrays.
15207 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15208 account creation of one-dimensional arrays.
15210 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15212 (NewUserdefinedArray::DoResolve): Implement.
15214 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15216 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15217 we maintain inside the TypeManager. This is necessary to perform lookups on the
15220 (LookupType): Update to perform GetType on the module builders too.
15222 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15224 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15226 2001-10-23 Ravi Pratap <ravi@ximian.com>
15228 * expression.cs (New::DoResolve): Implement guts of array creation.
15230 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15232 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15234 * expression.cs: Fix bug I introduced lsat night that broke
15237 (Expression.Resolve): Report a 246 error (can not resolve name)
15238 if we find a SimpleName in the stream.
15240 (Expression.ResolveLValue): Ditto.
15242 (Expression.ResolveWithSimpleName): This function is a variant of
15243 ResolveName, this one allows SimpleNames to be returned without a
15244 warning. The only consumer of SimpleNames is MemberAccess
15246 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15248 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15249 might arrive here. I have my doubts that this is correct.
15251 * statement.cs (Lock): Implement lock statement.
15253 * cs-parser.jay: Small fixes to support `lock' and `using'
15255 * cs-tokenizer.cs: Remove extra space
15257 * driver.cs: New flag --checked, allows to turn on integer math
15260 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15261 Threading.Monitor.Exit
15263 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15265 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15266 Expression Class to be IndexerAccess.
15268 Notice that Indexer::DoResolve sets the eclass to Value.
15270 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15272 * class.cs (TypeContainer::Emit): Emit code for indexers.
15274 * assign.cs (IAssignMethod): New interface implemented by Indexers
15275 and Properties for handling assignment.
15277 (Assign::Emit): Simplify and reuse code.
15279 * expression.cs (IndexerAccess, PropertyExpr): Implement
15280 IAssignMethod, clean up old code.
15282 2001-10-22 Ravi Pratap <ravi@ximian.com>
15284 * typemanager.cs (ImplementsInterface): New method to determine if a type
15285 implements a given interface. Provides a nice cache too.
15287 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15290 (ConvertReferenceExplicit): Ditto.
15292 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15293 various methods, with correct names etc.
15295 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15296 Operator.UnaryNegation.
15298 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15299 we have a unary plus or minus operator.
15301 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15304 * everywhere : update accordingly.
15306 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15309 * class.cs (Method::Define): For the case where we are implementing a method
15310 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15311 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15313 2001-10-21 Ravi Pratap <ravi@ximian.com>
15315 * interface.cs (FindMembers): Implement to work around S.R.E
15318 * typemanager.cs (IsInterfaceType): Implement.
15320 (FindMembers): Update to handle interface types too.
15322 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15323 use IsAssignableFrom as that is not correct - it doesn't work.
15325 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15326 and accordingly override EmitStatement.
15328 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15329 using the correct logic :-)
15331 2001-10-19 Ravi Pratap <ravi@ximian.com>
15333 * ../errors/cs-11.cs : Add to demonstrate error -11
15335 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15337 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15338 then pass this as a hint to ResolveLValue.
15340 * expression.cs (FieldExpr): Add Location information
15342 (FieldExpr::LValueResolve): Report assignment to readonly
15345 (Expression::ExprClassFromMemberInfo): Pass location information.
15347 (Expression::ResolveLValue): Add new method that resolves an
15350 (Expression::DoResolveLValue): Default invocation calls
15353 (Indexers): New class used to keep track of indexers in a given
15356 (IStackStore): Renamed from LValue, as it did not really describe
15357 what this did. Also ResolveLValue is gone from this interface and
15358 now is part of Expression.
15360 (ElementAccess): Depending on the element access type
15362 * typemanager.cs: Add `indexer_name_type' as a Core type
15363 (System.Runtime.CompilerServices.IndexerNameAttribute)
15365 * statement.cs (Goto): Take a location.
15367 2001-10-18 Ravi Pratap <ravi@ximian.com>
15369 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15370 if two delegates are compatible.
15372 (NewDelegate::DoResolve): Update to take care of the case when
15373 we instantiate a delegate from another delegate.
15375 * typemanager.cs (FindMembers): Don't even try to look up members
15376 of Delegate types for now.
15378 2001-10-18 Ravi Pratap <ravi@ximian.com>
15380 * delegate.cs (NewDelegate): New class to take care of delegate
15383 * expression.cs (New): Split the delegate related code out into
15384 the NewDelegate class.
15386 * delegate.cs (DelegateInvocation): New class to handle delegate
15389 * expression.cs (Invocation): Split out delegate related code into
15390 the DelegateInvocation class.
15392 2001-10-17 Ravi Pratap <ravi@ximian.com>
15394 * expression.cs (New::DoResolve): Implement delegate creation fully
15395 and according to the spec.
15397 (New::DoEmit): Update to handle delegates differently.
15399 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15400 because of which we were printing out arguments in reverse order !
15402 * delegate.cs (VerifyMethod): Implement to check if the given method
15403 matches the delegate.
15405 (FullDelegateDesc): Implement.
15407 (VerifyApplicability): Implement.
15409 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15410 delegate invocations too.
15412 (Invocation::Emit): Ditto.
15414 * ../errors/cs1593.cs : Added.
15416 * ../errors/cs1594.cs : Added.
15418 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15420 2001-10-16 Ravi Pratap <ravi@ximian.com>
15422 * typemanager.cs (intptr_type): Core type for System.IntPtr
15424 (InitCoreTypes): Update for the same.
15426 (iasyncresult_type, asynccallback_type): Ditto.
15428 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15431 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15434 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15435 the builders for the 4 members of a delegate type :-)
15437 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15440 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15442 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15444 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15446 * statement.cs (Break::Emit): Implement.
15447 (Continue::Emit): Implement.
15449 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15450 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15451 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15452 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15455 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15456 properties that track the label for the current loop (begin of the
15457 loop and end of the loop).
15459 2001-10-15 Ravi Pratap <ravi@ximian.com>
15461 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15462 use of emitting anything at all.
15464 * class.cs, rootcontext.cs : Get rid of calls to the same.
15466 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15468 (Populate): Define the constructor correctly and set the implementation
15471 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15474 (AddDelegateType): Implement.
15476 (IsDelegateType): Implement helper method.
15478 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15480 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15481 and accordingly handle it.
15483 * delegate.cs (Populate): Take TypeContainer argument.
15484 Implement bits to define the Invoke method. However, I still haven't figured out
15485 how to take care of the native int bit :-(
15487 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15488 Qualify the name of the delegate, not its return type !
15490 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15493 (StandardConversionExists): Checking for array types turns out to be recursive.
15495 (ConvertReferenceExplicit): Implement array conversion.
15497 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15499 2001-10-12 Ravi Pratap <ravi@ximian.com>
15501 * cs-parser.jay (delegate_declaration): Store the fully qualified
15502 name as it is a type declaration.
15504 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15507 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15508 as TypeContainer::DefineType.
15510 (Populate): Method in which all the definition of the various methods (Invoke)
15513 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15516 (CloseDelegate): Finally creates the delegate.
15518 * class.cs (TypeContainer::DefineType): Update to define delegates.
15519 (Populate, Emit and CloseType): Do the same thing here too.
15521 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15522 delegates in all these operations.
15524 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15526 * expression.cs: LocalTemporary: a new expression used to
15527 reference a temporary that has been created.
15529 * assign.cs: Handle PropertyAccess back here, so that we can
15530 provide the proper semantic access to properties.
15532 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15533 a few more explicit conversions.
15535 * modifiers.cs: `NEW' modifier maps to HideBySig.
15537 * expression.cs (PropertyExpr): Make this into an
15538 ExpressionStatement, and support the EmitStatement code path.
15540 Perform get/set error checking, clean up the interface.
15542 * assign.cs: recognize PropertyExprs as targets, and if so, turn
15543 them into toplevel access objects.
15545 2001-10-12 Miguel de Icaza <miguel@ximian.com>
15547 * expression.cs: PropertyExpr::PropertyExpr: use work around the
15550 * typemanager.cs: Keep track here of our PropertyBuilders again to
15551 work around lameness in SRE.
15553 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15555 * expression.cs (LValue::LValueResolve): New method in the
15556 interface, used to perform a second resolution pass for LValues.
15558 (This::DoResolve): Catch the use of this in static methods.
15560 (This::LValueResolve): Implement.
15562 (This::Store): Remove warning, assigning to `this' in structures
15565 (Invocation::Emit): Deal with invocation of
15566 methods on value types. We need to pass the address to structure
15567 methods rather than the object itself. (The equivalent code to
15568 emit "this" for structures leaves the entire structure on the
15569 stack instead of a pointer to it).
15571 (ParameterReference::DoResolve): Compute the real index for the
15572 argument based on whether the method takes or not a `this' pointer
15573 (ie, the method is static).
15575 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
15576 value types returned from functions when we need to invoke a
15577 method on the sturcture.
15580 2001-10-11 Ravi Pratap <ravi@ximian.com>
15582 * class.cs (TypeContainer::DefineType): Method to actually do the business of
15583 defining the type in the Modulebuilder or Typebuilder. This is to take
15584 care of nested types which need to be defined on the TypeBuilder using
15585 DefineNestedMethod.
15587 (TypeContainer::GetClassBases): Implement. Essentially the code from the
15588 methods in RootContext, only ported to be part of TypeContainer.
15590 (TypeContainer::GetInterfaceOrClass): Ditto.
15592 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
15594 * interface.cs (Interface::DefineInterface): New method. Does exactly
15595 what RootContext.CreateInterface did earlier, only it takes care of nested types
15598 (Interface::GetInterfaces): Move from RootContext here and port.
15600 (Interface::GetInterfaceByName): Same here.
15602 * rootcontext.cs (ResolveTree): Re-write.
15604 (PopulateTypes): Re-write.
15606 * class.cs (TypeContainer::Populate): Populate nested types too.
15607 (TypeContainer::Emit): Emit nested members too.
15609 * typemanager.cs (AddUserType): Do not make use of the FullName property,
15610 instead just use the name argument passed in as it is already fully
15613 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
15614 to TypeContainer mapping to see if a type is user-defined.
15616 * class.cs (TypeContainer::CloseType): Implement.
15618 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
15619 the default constructor.
15621 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
15624 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
15626 * interface.cs (CloseType): Create the type here.
15628 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
15631 Remove all the methods which are now in TypeContainer.
15633 2001-10-10 Ravi Pratap <ravi@ximian.com>
15635 * delegate.cs (Define): Re-write bits to define the delegate
15638 2001-10-10 Miguel de Icaza <miguel@ximian.com>
15640 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
15642 * expression.cs (ImplicitReferenceConversion): handle null as well
15643 as a source to convert to any reference type.
15645 * statement.cs (Return): Perform any implicit conversions to
15646 expected return type.
15648 Validate use of return statement.
15650 * codegen.cs (EmitContext): Pass the expected return type here.
15652 * class.cs (Method, Constructor, Property): Pass expected return
15653 type to EmitContext.
15655 2001-10-09 Miguel de Icaza <miguel@ximian.com>
15657 * expression.cs: Make DoResolve take an EmitContext instead of a
15660 Replaced `l' and `location' for `loc', for consistency.
15662 (Error, Warning): Remove unneeded Tc argument.
15664 * assign.cs, literal.cs, constant.cs: Update to new calling
15667 * codegen.cs: EmitContext now contains a flag indicating whether
15668 code is being generated in a static method or not.
15670 * cs-parser.jay: DecomposeQI, new function that replaces the old
15671 QualifiedIdentifier. Now we always decompose the assembled
15672 strings from qualified_identifier productions into a group of
15675 2001-10-08 Miguel de Icaza <miguel@ximian.com>
15677 * rootcontext.cs: Deal with field-less struct types correctly now
15678 by passing the size option to Define Type.
15680 * class.cs: Removed hack that created one static field.
15682 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15684 * statement.cs: Moved most of the code generation here.
15686 2001-10-09 Ravi Pratap <ravi@ximian.com>
15688 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
15691 (ElementAccess): Remove useless bits for now - keep checks as the spec
15694 2001-10-08 Ravi Pratap <ravi@ximian.com>
15696 * expression.cs (ElementAccess::DoResolve): Remove my crap code
15697 and start performing checks according to the spec.
15699 2001-10-07 Ravi Pratap <ravi@ximian.com>
15701 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
15702 rank_specifiers instead.
15704 (rank_specifiers): Change the order in which the rank specifiers are stored
15706 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
15708 * expression.cs (ElementAccess): Implement the LValue interface too.
15710 2001-10-06 Ravi Pratap <ravi@ximian.com>
15712 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
15713 except that user defined conversions are not included.
15715 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
15716 perform the conversion of the return type, if necessary.
15718 (New::DoResolve): Check whether we are creating an array or an object
15719 and accordingly do the needful.
15721 (New::Emit): Same here.
15723 (New::DoResolve): Implement guts of array creation.
15725 (New::FormLookupType): Helper function.
15727 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15729 * codegen.cs: Removed most of the code generation here, and move the
15730 corresponding code generation bits to the statement classes.
15732 Added support for try/catch/finalize and throw.
15734 * cs-parser.jay: Added support for try/catch/finalize.
15736 * class.cs: Catch static methods having the flags override,
15737 virtual or abstract.
15739 * expression.cs (UserCast): This user cast was not really doing
15740 what it was supposed to do. Which is to be born in fully resolved
15741 state. Parts of the resolution were being performed at Emit time!
15745 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15747 * expression.cs: Implicity convert the result from UserCast.
15749 2001-10-05 Ravi Pratap <ravi@ximian.com>
15751 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
15752 prevented it from working correctly.
15754 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
15755 merely ConvertImplicit.
15757 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15759 * typemanager.cs: Make the LookupTypeContainer function static,
15760 and not per-instance.
15762 * class.cs: Make static FindMembers (the one that takes a Type
15765 * codegen.cs: Add EmitForeach here.
15767 * cs-parser.jay: Make foreach a toplevel object instead of the
15768 inline expansion, as we need to perform semantic analysis on it.
15770 2001-10-05 Ravi Pratap <ravi@ximian.com>
15772 * expression.cs (Expression::ImplicitUserConversion): Rename to
15773 UserDefinedConversion.
15775 (Expression::UserDefinedConversion): Take an extra argument specifying
15776 whether we look for explicit user conversions too.
15778 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
15780 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
15782 (ExplicitUserConversion): Make it a call to UserDefinedConversion
15783 with the appropriate arguments.
15785 * cs-parser.jay (cast_expression): Record location too.
15787 * expression.cs (Cast): Record location info.
15789 (Expression::ConvertExplicit): Take location argument.
15791 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
15792 to determine if we are doing explicit conversions.
15794 (UserCast::Emit): Update accordingly.
15796 (Expression::ConvertExplicit): Report an error if everything fails.
15798 * ../errors/cs0030.cs : Add.
15800 2001-10-04 Miguel de Icaza <miguel@ximian.com>
15802 * modifiers.cs: If the ABSTRACT keyword is present, also set the
15803 virtual and newslot bits.
15805 * class.cs (TypeContainer::RegisterRequiredImplementations):
15806 Record methods we need.
15808 (TypeContainer::MakeKey): Helper function to make keys for
15809 MethodBases, since the Methodbase key is useless.
15811 (TypeContainer::Populate): Call RegisterRequiredImplementations
15812 before defining the methods.
15814 Create a mapping for method_builders_to_methods ahead of time
15815 instead of inside a tight loop.
15817 (::RequireMethods): Accept an object as the data to set into the
15818 hashtable so we can report interface vs abstract method mismatch.
15820 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15822 * report.cs: Make all of it static.
15824 * rootcontext.cs: Drop object_type and value_type computations, as
15825 we have those in the TypeManager anyways.
15827 Drop report instance variable too, now it is a global.
15829 * driver.cs: Use try/catch on command line handling.
15831 Add --probe option to debug the error reporting system with a test
15834 * report.cs: Add support for exiting program when a probe
15835 condition is reached.
15837 2001-10-03 Ravi Pratap <ravi@ximian.com>
15839 * expression.cs (Binary::DoNumericPromotions): Fix the case when
15840 we do a forcible conversion regardless of type, to check if
15841 ForceConversion returns a null.
15843 (Binary::error19): Use location to report error.
15845 (Unary::error23): Use location here too.
15847 * ../errors/cs0019.cs : Check in.
15849 * ../errors/cs0023.cs : Check in.
15851 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
15852 case of a non-null MethodInfo object with a length of 0 !
15854 (Binary::ResolveOperator): Flag error if overload resolution fails to find
15855 an applicable member - according to the spec :-)
15856 Also fix logic to find members in base types.
15858 (Unary::ResolveOperator): Same here.
15860 (Unary::report23): Change name to error23 and make first argument a TypeContainer
15861 as I was getting thoroughly confused between this and error19 :-)
15863 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
15864 (::FindMostEncompassedType): Implement.
15865 (::FindMostEncompassingType): Implement.
15866 (::StandardConversionExists): Implement.
15868 (UserImplicitCast): Re-vamp. We now need info about most specific
15869 source and target types so that we can do the necessary conversions.
15871 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
15872 mathematical union with no duplicates.
15874 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15876 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
15877 in order from base classes to child classes, so that we can in
15878 child classes look up in our parent for method names and
15879 attributes (required for handling abstract, virtual, new, override
15880 constructs: we need to instrospect our base class, and if we dont
15881 populate the classes in order, the introspection might be
15882 incorrect. For example, a method could query its parent before
15883 the parent has any methods and would determine that the parent has
15884 no abstract methods (while it could have had them)).
15886 (RootContext::CreateType): Record the order in which we define the
15889 2001-10-02 Miguel de Icaza <miguel@ximian.com>
15891 * class.cs (TypeContainer::Populate): Also method definitions can
15892 fail now, keep track of this.
15894 (TypeContainer::FindMembers): Implement support for
15895 DeclaredOnly/noDeclaredOnly flag.
15897 (Constructor::Emit) Return the ConstructorBuilder.
15899 (Method::Emit) Return the MethodBuilder.
15900 Check for abstract or virtual methods to be public.
15902 * rootcontext.cs (RootContext::CreateType): Register all the
15903 abstract methods required for the class to be complete and the
15904 interface methods that must be implemented.
15906 * cs-parser.jay: Report error 501 (method requires body if it is
15907 not marked abstract or extern).
15909 * expression.cs (TypeOf::Emit): Implement.
15911 * typemanager.cs: runtime_handle_type, new global type.
15913 * class.cs (Property::Emit): Generate code for properties.
15915 2001-10-02 Ravi Pratap <ravi@ximian.com>
15917 * expression.cs (Unary::ResolveOperator): Find operators on base type
15918 too - we now conform exactly to the spec.
15920 (Binary::ResolveOperator): Same here.
15922 * class.cs (Operator::Define): Fix minor quirk in the tests.
15924 * ../errors/cs0215.cs : Added.
15926 * ../errors/cs0556.cs : Added.
15928 * ../errors/cs0555.cs : Added.
15930 2001-10-01 Miguel de Icaza <miguel@ximian.com>
15932 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
15933 single integer which is really efficient
15935 2001-10-01 Ravi Pratap <ravi@ximian.com>
15937 * expression.cs (Expression::ImplicitUserConversion): Use location
15938 even in the case when we are examining True operators.
15940 * class.cs (Operator::Define): Perform extensive checks to conform
15941 with the rules for operator overloading in the spec.
15943 * expression.cs (Expression::ImplicitReferenceConversion): Implement
15944 some of the other conversions mentioned in the spec.
15946 * typemanager.cs (array_type): New static member for the System.Array built-in
15949 (cloneable_interface): For System.ICloneable interface.
15951 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
15952 we start resolving the tree and populating types.
15954 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
15956 2001-10-01 Miguel de Icaza <miguel@ximian.com>
15958 * expression.cs (Expression::ExprClassFromMemberInfo,
15959 Expression::Literalize): Create literal expressions from
15960 FieldInfos which are literals.
15962 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
15963 type casts, because they were wrong. The test suite in tests
15966 (ImplicitNumericConversion): ushort to ulong requires a widening
15969 Int32 constant to long requires widening cast as well.
15971 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
15972 for integers because the type on the stack is not i4.
15974 2001-09-30 Miguel de Icaza <miguel@ximian.com>
15976 * expression.cs (report118): require location argument.
15978 * parameter.cs: Do not dereference potential null value.
15980 * class.cs: Catch methods that lack the `new' keyword when
15981 overriding a name. Report warnings when `new' is used without
15982 anything being there to override.
15984 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
15986 * class.cs: Only add constructor to hashtable if it is non-null
15987 (as now constructors can fail on define).
15989 (TypeManager, Class, Struct): Take location arguments.
15991 Catch field instance initialization in structs as errors.
15993 accepting_filter: a new filter for FindMembers that is static so
15994 that we dont create an instance per invocation.
15996 (Constructor::Define): Catch errors where a struct constructor is
15999 * cs-parser.jay: Pass location information for various new
16002 * delegate.cs (Delegate): take a location argument.
16004 * driver.cs: Do not call EmitCode if there were problesm in the
16005 Definition of the types, as many Builders wont be there.
16007 * decl.cs (Decl::Decl): Require a location argument.
16009 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16010 into integers, and find the most appropiate integer for it.
16012 * literal.cs: Implement ULongLiteral.
16014 * rootcontext.cs: Provide better information about the location of
16015 failure when CreateType fails.
16017 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16019 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16022 * expression.cs (Binary::CheckShiftArguments): Add missing type
16024 (Binary::ResolveOperator): Add type to the logical and and logical
16025 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16028 (Binary::DoNumericPromotions): In the case where either argument
16029 is ulong (and most signed types combined with ulong cause an
16030 error) perform implicit integer constant conversions as well.
16032 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16034 * expression.cs (UserImplicitCast): Method should always be
16036 (Invocation::BetterConversion): Simplified test for IntLiteral.
16038 (Expression::ImplicitNumericConversion): Split this routine out.
16039 Put the code that performs implicit constant integer conversions
16042 (Expression::Resolve): Become a wrapper around DoResolve so we can
16043 check eclass and type being set after resolve.
16045 (Invocation::Badness): Remove this dead function
16047 (Binary::ResolveOperator): Do not compute the expensive argumnets
16048 unless we have a union for it.
16050 (Probe::Emit): Is needs to do an isinst and then
16051 compare against null.
16053 (::CanConvert): Added Location argument. If the Location argument
16054 is null (Location.Null), then we do not report errors. This is
16055 used by the `probe' mechanism of the Explicit conversion. We do
16056 not want to generate an error for something that the user
16057 explicitly requested to be casted. But the pipeline for an
16058 explicit cast first tests for potential implicit casts.
16060 So for now, if the Location is null, it means `Probe only' to
16061 avoid adding another argument. Might have to revise this
16064 (ClassCast): New class used to type cast objects into arbitrary
16065 classes (used in Explicit Reference Conversions).
16067 Implement `as' as well.
16069 Reverted all the patches from Ravi below: they were broken:
16071 * The use of `level' as a mechanism to stop recursive
16072 invocations is wrong. That was there just to catch the
16073 bug with a strack trace but not as a way of addressing
16076 To fix the problem we have to *understand* what is going
16077 on and the interactions and come up with a plan, not
16078 just get things going.
16080 * The use of the type conversion cache that I proposed
16081 last night had an open topic: How does this work across
16082 protection domains. A user defined conversion might not
16083 be public in the location where we are applying the
16084 conversion, a different conversion might be selected
16085 (ie, private A->B (better) but public B->A (worse),
16086 inside A, A->B applies, but outside it, B->A will
16089 * On top of that (ie, even if the above is solved),
16090 conversions in a cache need to be abstract. Ie, `To
16091 convert from an Int to a Short use an OpcodeCast', not
16092 `To convert from an Int to a Short use the OpcodeCast on
16093 the variable 5' (which is what this patch was doing).
16095 2001-09-28 Ravi Pratap <ravi@ximian.com>
16097 * expression.cs (Invocation::ConversionExists): Re-write to use
16098 the conversion cache
16100 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16101 cache all conversions done, not just user-defined ones.
16103 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16104 to determine if a conversion exists instead of acutually trying to
16105 perform the conversion. It's faster too.
16107 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16108 and only then attempt the implicit conversion.
16110 2001-09-28 Ravi Pratap <ravi@ximian.com>
16112 * expression.cs (ConvertImplicit): Use a cache for conversions
16113 already found. Check level of recursion and bail out if necessary.
16115 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16117 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16118 Export standard methods that we expect for string operations.
16120 * statement.cs (Block::UsageWarning): Track usage of variables and
16121 report the errors for not used variables.
16123 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16126 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16128 * codegen.cs: remove unnneded code
16130 * expression.cs: Removed BuiltinTypeAccess class
16132 Fix the order in which implicit conversions are
16135 The previous fixed dropped support for boxed conversions (adding a
16136 test to the test suite now)
16138 (UserImplicitCast::CanConvert): Remove test for source being null,
16139 that code is broken. We should not feed a null to begin with, if
16140 we do, then we should track the bug where the problem originates
16141 and not try to cover it up here.
16143 Return a resolved expression of type UserImplicitCast on success
16144 rather than true/false. Ravi: this is what I was talking about,
16145 the pattern is to use a static method as a "constructor" for
16148 Also, do not create arguments until the very last minute,
16149 otherwise we always create the arguments even for lookups that
16150 will never be performed.
16152 (UserImplicitCast::Resolve): Eliminate, objects of type
16153 UserImplicitCast are born in a fully resolved state.
16155 * typemanager.cs (InitCoreTypes): Init also value_type
16156 (System.ValueType).
16158 * expression.cs (Cast::Resolve): First resolve the child expression.
16160 (LValue): Add new method AddressOf to be used by
16163 Change the argument of Store to take an EmitContext instead of an
16164 ILGenerator, because things like FieldExpr need to be able to call
16165 their children expression to generate the instance code.
16167 (Expression::Error, Expression::Warning): Sugar functions for
16170 (Expression::MemberLookup): Accept a TypeContainer instead of a
16171 Report as the first argument.
16173 (Expression::ResolvePrimary): Killed. I still want to improve
16174 this as currently the code is just not right.
16176 (Expression::ResolveMemberAccess): Simplify, but it is still
16179 (Unary::Resolve): Catch errors in AddressOf operators.
16181 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16182 index to a byte for the short-version, or the compiler will choose
16183 the wrong Emit call, which generates the wrong data.
16185 (ParameterReference::Emit, ::Store): same.
16187 (FieldExpr::AddressOf): Implement.
16189 * typemanager.cs: TypeManager: made public variable instead of
16192 * driver.cs: document --fatal.
16194 * report.cs (ErrorMessage, WarningMessage): new names for the old
16195 Error and Warning classes.
16197 * cs-parser.jay (member_access): Turn built-in access to types
16198 into a normal simplename
16200 2001-09-27 Ravi Pratap <ravi@ximian.com>
16202 * expression.cs (Invocation::BetterConversion): Fix to cope
16203 with q being null, since this was introducing a bug.
16205 * expression.cs (ConvertImplicit): Do built-in conversions first.
16207 2001-09-27 Ravi Pratap <ravi@ximian.com>
16209 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16211 2001-09-27 Ravi Pratap <ravi@ximian.com>
16213 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16214 I had introduced long ago (what's new ?).
16216 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16217 the work of all the checking.
16218 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16219 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16221 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16222 that is the right way.
16224 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16225 overloading resolution. Use everywhere instead of cutting and pasting code.
16227 (Binary::ResolveOperator): Use MakeUnionSet.
16229 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16230 we have to convert to bool types. Not complete yet.
16232 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16234 * typemanager.cs (TypeManager::CSharpName): support ushort.
16236 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16237 to provide an expression that performsn an implicit constant int
16238 conversion (section 6.1.6).
16239 (Expression::ConvertImplicitRequired): Reworked to include
16240 implicit constant expression conversions.
16242 (Expression::ConvertNumericExplicit): Finished.
16244 (Invocation::Emit): If InstanceExpression is null, then it means
16245 that we perform a call on this.
16247 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16249 * expression.cs (Unary::Emit): Remove some dead code.
16250 (Probe): Implement Resolve and Emit for `is'.
16251 (Expression::ConvertImplicitRequired): Attempt to do constant
16252 expression conversions here. Maybe should be moved to
16253 ConvertImplicit, but I am not sure.
16254 (Expression::ImplicitLongConstantConversionPossible,
16255 Expression::ImplicitIntConstantConversionPossible): New functions
16256 that tell whether is it possible to apply an implicit constant
16257 expression conversion.
16259 (ConvertNumericExplicit): Started work on explicit numeric
16262 * cs-parser.jay: Update operator constants.
16264 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16265 (Parameters::GetSignature): Hook up VerifyArgs here.
16266 (Parameters::VerifyArgs): Verifies that no two arguments have the
16269 * class.cs (Operator): Update the operator names to reflect the
16270 ones that the spec expects (as we are just stringizing the
16273 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16274 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16275 previous usage did only work for our methods.
16276 (Expression::ConvertImplicit): Handle decimal implicit numeric
16277 conversions as well.
16278 (Expression::InternalTypeConstructor): Used to invoke constructors
16279 on internal types for default promotions.
16281 (Unary::Emit): Implement special handling for the pre/post
16282 increment/decrement for overloaded operators, as they need to have
16283 the same semantics as the other operators.
16285 (Binary::ResolveOperator): ditto.
16286 (Invocation::ConversionExists): ditto.
16287 (UserImplicitCast::Resolve): ditto.
16289 2001-09-26 Ravi Pratap <ravi@ximian.com>
16291 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16292 operator, return after emitting body. Regression tests pass again !
16294 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16295 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16296 (Invocation::OverloadResolve): Ditto.
16297 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16299 * everywhere : update calls to the above methods accordingly.
16301 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16303 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16305 * expression.cs (ExpressionStatement): New base class used for
16306 expressions that can appear in statements, so that we can provide
16307 an alternate path to generate expression that do not leave a value
16310 (Expression::Emit, and all the derivatives): We no longer return
16311 whether a value is left on the stack or not. Every expression
16312 after being emitted leaves a single value on the stack.
16314 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16315 facilties of ExpressionStatement if possible.
16317 * cs-parser.jay: Update statement_expression.
16319 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16321 * driver.cs: Change the wording of message
16323 2001-09-25 Ravi Pratap <ravi@ximian.com>
16325 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16326 the type of the expression to the return type of the method if
16327 we have an overloaded operator match ! The regression tests pass again !
16328 (Unary::ResolveOperator): Ditto.
16330 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16331 to find "op_Implicit", not "implicit" ;-)
16332 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16333 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16335 * everywhere : Correct calls to the above accordingly.
16337 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16338 (ConvertImplicit): Do user-defined conversion if it exists.
16340 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16342 * assign.cs: track location.
16343 (Resolve): Use implicit conversions on assignment.
16345 * literal.cs: Oops. Not good, Emit of short access values should
16346 pass (Bytes) or the wrong argument will be selected.
16348 * expression.cs (Unary::Emit): Emit code for -expr.
16350 (Unary::ResolveOperator): Handle `Substract' for non-constants
16351 (substract from zero from the non-constants).
16352 Deal with Doubles as well.
16354 (Expression::ConvertImplicitRequired): New routine that reports an
16355 error if no implicit conversion exists.
16357 (Invocation::OverloadResolve): Store the converted implicit
16358 expressions if we make them
16360 2001-09-24 Ravi Pratap <ravi@ximian.com>
16362 * class.cs (ConstructorInitializer): Take a Location argument.
16363 (ConstructorBaseInitializer): Same here.
16364 (ConstructorThisInitializer): Same here.
16366 * cs-parser.jay : Update all calls accordingly.
16368 * expression.cs (Unary, Binary, New): Take location argument.
16369 Update accordingly everywhere.
16371 * cs-parser.jay : Update all calls to the above to take a location
16374 * class.cs : Ditto.
16376 2001-09-24 Ravi Pratap <ravi@ximian.com>
16378 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16379 (Invocation::BetterConversion): Same here
16380 (Invocation::ConversionExists): Ditto.
16382 (Invocation::ConversionExists): Implement.
16384 2001-09-22 Ravi Pratap <ravi@ximian.com>
16386 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16387 Also take an additional TypeContainer argument.
16389 * All over : Pass in TypeContainer as argument to OverloadResolve.
16391 * typemanager.cs (CSharpName): Update to check for the string type and return
16394 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16397 2001-09-21 Ravi Pratap <ravi@ximian.com>
16399 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16400 (Invocation::BetterFunction): Implement.
16401 (Invocation::BetterConversion): Implement.
16402 (Invocation::ConversionExists): Skeleton, no implementation yet.
16404 Okay, things work fine !
16406 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16408 * typemanager.cs: declare and load enum_type, delegate_type and
16411 * expression.cs (Expression::Emit): Now emit returns a value that
16412 tells whether a value is left on the stack or not. This strategy
16413 might be reveted tomorrow with a mechanism that would address
16414 multiple assignments.
16415 (Expression::report118): Utility routine to report mismatches on
16418 (Unary::Report23): Report impossible type/operator combination
16421 (Unary::IsIncrementableNumber): Whether the type can be
16422 incremented or decremented with add.
16423 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16425 (Unary::ResolveOperator): Implement ++, !, ~,
16427 (Invocation::Emit): Deal with new Emit convetion.
16429 * All Expression derivatives: Updated their Emit method to return
16430 whether they leave values on the stack or not.
16432 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16433 stack for expressions that are statements.
16435 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16437 * expression.cs (LValue): New interface. Must be implemented by
16439 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16442 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16443 interface for generating code, simplifies the code.
16445 2001-09-20 Ravi Pratap <ravi@ximian.com>
16447 * expression.cs (everywhere): Comment out return statements in ::Resolve
16448 methods to avoid the warnings.
16450 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16452 * driver.cs (parse): Report error 2001 if we can not open the
16455 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16458 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16461 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16462 otherwise nested blocks end up with the same index.
16464 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16466 * expression.cs: Instead of having FIXMEs in the Resolve
16467 functions, throw exceptions so it is obvious that we are facing a
16470 * cs-parser.jay (invocation_expression): Pass Location information.
16472 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16473 Use a basename for those routines because .NET does not like paths
16476 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16479 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16481 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16482 are loading the correct data types (throws an exception if not).
16483 (TypeManager::InitCoreTypes): Use CoreLookupType
16485 * expression.cs (Unary::ResolveOperator): return the child
16486 expression for expressions which are just +expr.
16487 (Unary::ResolveOperator): Return negative literals for -LITERAL
16488 expressions (otherwise they are Unary {Literal}).
16489 (Invocation::Badness): Take into account `Implicit constant
16490 expression conversions'.
16492 * literal.cs (LongLiteral): Implement long literal class.
16493 (IntLiteral): export the `Value' of the intliteral.
16495 2001-09-19 Ravi Pratap <ravi@ximian.com>
16497 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16499 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16500 instead of 'Operator'
16502 * expression.cs (Binary::ResolveOperator): Update accordingly.
16503 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16506 * cs-parser.jay (unary_expression): Update to use the new names.
16508 * gen-treedump.cs (GetUnary): Same here.
16510 * expression.cs (Unary::Resolve): Implement.
16511 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16512 operators are found instead of making noise ;-)
16513 (Unary::ResolveOperator): New method to do precisely the same thing which
16514 Binary::ResolveOperator does for Binary expressions.
16515 (Unary.method, .Arguments): Add.
16516 (Unary::OperName): Implement.
16517 (Unary::ForceConversion): Copy and Paste !
16519 * class.cs (Operator::Define): Fix a small bug for the case when we have
16522 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16523 for the inbuilt operators. Only overloading works for now ;-)
16525 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16527 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16528 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16530 * expression.cs (This::Emit): Implement.
16531 (This::Resolve): Implement.
16532 (TypeOf:Resolve): Implement.
16533 (Expression::ResolveSimpleName): Add an implicit this to instance
16535 (MemberAccess::Resolve): Deal with Parameters and Fields.
16536 Bind instance variable to Field expressions.
16537 (FieldExpr::Instance): New field used to track the expression that
16538 represents the object instance.
16539 (FieldExpr::Resolve): Track potential errors from MemberLookup not
16541 (FieldExpr::Emit): Implement.
16543 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
16544 the last instruction contains a return opcode to avoid generating
16545 the last `ret' instruction (this generates correct code, and it is
16546 nice to pass the peverify output).
16548 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
16549 initializer for static and instance variables.
16550 (Constructor::Emit): Allow initializer to be null in the case of
16551 static constructors. Only emit initializer for instance
16554 (TypeContainer::FindMembers): Return a null array if there are no
16557 Also fix the code for the MemberTypes.Method branch, as it was not
16558 scanning that for operators (or tried to access null variables before).
16560 * assign.cs (Assign::Emit): Handle instance and static fields.
16564 * driver.cs: Stop compilation if there are parse errors.
16566 * cs-parser.jay (constructor_declaration): Provide default base
16567 initializer for non-static constructors.
16568 (constructor_declarator): Do not provide a default base
16569 initializers if none was specified.
16570 Catch the fact that constructors should not have parameters.
16572 * class.cs: Do not emit parent class initializers for static
16573 constructors, that should be flagged as an error.
16575 2001-09-18 Ravi Pratap <ravi@ximian.com>
16577 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
16578 Move back code into TypeContainer::Populate.
16580 2001-09-18 Ravi Pratap <ravi@ximian.com>
16582 * class.cs (TypeContainer::AddConstructor): Fix the check to
16583 compare against Name, not Basename.
16584 (Operator::OpType): Change Plus and Minus to Add and Subtract.
16586 * cs-parser.jay : Update accordingly.
16588 * class.cs (TypeContainer::FindMembers): For the case where we are searching
16589 for methods, don't forget to look into the operators too.
16590 (RegisterMethodBuilder): Helper method to take care of this for
16591 methods, constructors and operators.
16592 (Operator::Define): Completely revamp.
16593 (Operator.OperatorMethod, MethodName): New fields.
16594 (TypeContainer::Populate): Move the registering of builders into
16595 RegisterMethodBuilder.
16596 (Operator::Emit): Re-write.
16598 * expression.cs (Binary::Emit): Comment out code path to emit method
16599 invocation stuff for the case when we have a user defined operator. I am
16600 just not able to get it right !
16602 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16604 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
16607 (Expression::MemberLookup): Provide a version that allows to
16608 specify the MemberTypes and BindingFlags.
16610 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
16611 so it was not fetching variable information from outer blocks.
16613 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
16614 Beforefieldinit as it was buggy.
16616 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
16617 that Ravi put here.
16619 * class.cs (Constructor::Emit): Only emit if block is not null.
16620 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
16621 deal with this by semantically definining it as if the user had
16624 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
16625 constructors as we now "emit" them at a higher level.
16627 (TypeContainer::DefineDefaultConstructor): Used to define the
16628 default constructors if none was provided.
16630 (ConstructorInitializer): Add methods Resolve and Emit.
16632 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
16634 2001-09-17 Ravi Pratap <ravi@ximian.com>
16636 * class.cs (TypeContainer::EmitDefaultConstructor): Register
16637 the default constructor builder with our hashtable for methodbuilders
16640 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
16641 and argument_count is 0 in which case we have a match.
16642 (Binary::ResolveOperator): More null checking and miscellaneous coding
16645 2001-09-17 Ravi Pratap <ravi@ximian.com>
16647 * rootcontext.cs (IsNameSpace): Compare against null.
16649 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
16651 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
16652 and Unary::Operator.
16654 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
16657 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
16658 we have overloaded operators.
16659 (Binary::ResolveOperator): Implement the part which does the operator overload
16662 * class.cs (Operator::Emit): Implement.
16663 (TypeContainer::Emit): Emit the operators we have too.
16665 * expression.cs (Binary::Emit): Update to emit the appropriate code for
16666 the case when we have a user-defined operator.
16668 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16670 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
16672 2001-09-16 Ravi Pratap <ravi@ximian.com>
16674 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
16675 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
16676 (Constructor::Emit): Implement.
16677 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
16678 if we have no work to do.
16679 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
16682 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
16683 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
16685 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
16688 2001-09-15 Ravi Pratap <ravi@ximian.com>
16690 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
16692 (Tree::RecordNamespace): Method to do what the name says ;-)
16693 (Tree::Namespaces): Property to get at the namespaces hashtable.
16695 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
16698 * rootcontext.cs (IsNamespace): Fixed it :-)
16700 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16702 * class.cs (TypeContainer::FindMembers): Add support for
16704 (MethodCore): New class that encapsulates both the shared aspects
16705 of a Constructor and a Method.
16706 (Method, Constructor): Factored pieces into MethodCore.
16708 * driver.cs: Added --fatal which makes errors throw exceptions.
16709 Load System assembly as well as part of the standard library.
16711 * report.cs: Allow throwing exceptions on errors for debugging.
16713 * modifiers.cs: Do not use `parent', instead use the real type
16714 container to evaluate permission settings.
16716 * class.cs: Put Ravi's patch back in. He is right, and we will
16717 have to cope with the
16719 2001-09-14 Ravi Pratap <ravi@ximian.com>
16721 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
16722 FamORAssem, not FamANDAssem.
16724 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16726 * driver.cs: Added --parse option that only parses its input files
16729 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
16730 incorrect. IsTopLevel is not used to tell whether an object is
16731 root_types or not (that can be achieved by testing this ==
16732 root_types). But to see if this is a top-level *class* (not
16733 necessarly our "toplevel" container).
16735 2001-09-14 Ravi Pratap <ravi@ximian.com>
16737 * enum.cs (Enum::Define): Modify to call the Lookup method on the
16738 parent instead of a direct call to GetType.
16740 2001-09-14 Ravi Pratap <ravi@ximian.com>
16742 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
16743 Modifiers.TypeAttr. This should just be a call to that method.
16745 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
16746 object so that we can determine if we are top-level or not.
16748 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
16751 * enum.cs (Enum::Define): Ditto.
16753 * modifiers.cs (FieldAttr): Re-write.
16755 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
16756 (TypeContainer::HaveStaticConstructor): New property to provide access
16757 to precisely that info.
16759 * modifiers.cs (MethodAttr): Re-write.
16760 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
16762 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
16763 of top-level types as claimed.
16765 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16767 * expression.cs (MemberLookup): Fruitless attempt to lookup
16768 constructors. Maybe I need to emit default constructors? That
16769 might be it (currently .NET emits this for me automatically).
16770 (Invocation::OverloadResolve): Cope with Arguments == null.
16771 (Invocation::EmitArguments): new function, shared by the new
16772 constructor and us.
16773 (Invocation::Emit): Handle static and instance methods. Emit
16774 proper call instruction for virtual or non-virtual invocations.
16775 (New::Emit): Implement.
16776 (New::Resolve): Implement.
16777 (MemberAccess:Resolve): Implement.
16778 (MethodGroupExpr::InstanceExpression): used conforming to the spec
16779 to track instances.
16780 (FieldExpr::Resolve): Set type.
16782 * support.cs: Handle empty arguments.
16784 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
16785 SimpleLookup): Auxiliary routines to help parse a qualifier
16788 Update qualifier_identifier rule.
16790 * codegen.cs: Removed debugging messages.
16792 * class.cs: Make this a global thing, this acts just as a "key" to
16793 objects that we might have around.
16795 (Populate): Only initialize method_builders_to_methods once.
16797 * expression.cs (PropertyExpr): Initialize type from the
16800 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
16801 Resolve pattern. Attempt to implicitly convert value to boolean.
16804 * expression.cs: Set the type for the int32/int32 argument case.
16805 (Binary::ResolveOperator): Set the return type to boolean for
16806 comparission operators
16808 * typemanager.cs: Remove debugging print code.
16810 (Invocation::Resolve): resolve type.
16812 * class.cs: Allocate a MemberInfo of the correct size, as the code
16813 elsewhere depends on the test to reflect the correct contents.
16815 (Method::) Keep track of parameters, due to System.Reflection holes
16817 (TypeContainer::Populate): Keep track of MethodBuilders to Method
16820 (TypeContainer::FindMembers): Use ArrayList and then copy an array
16821 of the exact size and return that.
16823 (Class::LookupMethodByBuilder): New function that maps
16824 MethodBuilders to its methods. Required to locate the information
16825 on methods because System.Reflection bit us again.
16827 * support.cs: New file, contains an interface ParameterData and
16828 two implementations: ReflectionParameters and InternalParameters
16829 used to access Parameter information. We will need to grow this
16832 * expression.cs (Invocation::GetParameterData): implement a cache
16833 and a wrapper around the ParameterData creation for methods.
16834 (Invocation::OverloadResolve): Use new code.
16836 2001-09-13 Ravi Pratap <ravi@ximian.com>
16838 * class.cs (TypeContainer::EmitField): Remove and move into
16839 (Field::Define): here and modify accordingly.
16840 (Field.FieldBuilder): New member.
16841 (TypeContainer::Populate): Update accordingly.
16842 (TypeContainer::FindMembers): Implement.
16844 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16846 * statement.cs: (VariableInfo::VariableType): New field to be
16847 initialized with the full type once it is resolved.
16849 2001-09-12 Miguel de Icaza <miguel@ximian.com>
16851 * parameter.cs (GetParameterInfo): Use a type cache to compute
16852 things only once, and to reuse this information
16854 * expression.cs (LocalVariableReference::Emit): Implement.
16855 (OpcodeCast::Emit): fix.
16857 (ParameterReference::Resolve): Implement.
16858 (ParameterReference::Emit): Implement.
16860 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
16861 that are expressions need to stay as Expressions.
16863 * typemanager.cs (CSharpName): Returns the C# name of a type if
16866 * expression.cs (Expression::ConvertImplicit): New function that
16867 implements implicit type conversions.
16869 (Expression::ImplicitReferenceConversion): Implements implicit
16870 reference conversions.
16872 (EmptyCast): New type for transparent casts.
16874 (OpcodeCast): New type for casts of types that are performed with
16875 a sequence of bytecodes.
16877 (BoxedCast): New type used for casting value types into reference
16878 types. Emits a box opcode.
16880 (Binary::DoNumericPromotions): Implements numeric promotions of
16881 and computation of the Binary::Type.
16883 (Binary::EmitBranchable): Optimization.
16885 (Binary::Emit): Implement code emission for expressions.
16887 * typemanager.cs (TypeManager): Added two new core types: sbyte
16890 2001-09-12 Ravi Pratap <ravi@ximian.com>
16892 * class.cs (TypeContainer::FindMembers): Method which does exactly
16893 what Type.FindMembers does, only we don't have to use reflection. No
16894 implementation yet.
16896 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
16897 typecontainer objects as we need to get at them.
16898 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
16900 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
16901 typecontainer object.
16903 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
16904 of just a Report object.
16906 2001-09-11 Ravi Pratap <ravi@ximian.com>
16908 * class.cs (Event::Define): Go back to using the prefixes "add_" and
16910 (TypeContainer::Populate): Now define the delegates of the type too.
16911 (TypeContainer.Delegates): Property to access the list of delegates defined
16914 * delegates.cs (Delegate::Define): Implement partially.
16916 * modifiers.cs (TypeAttr): Handle more flags.
16918 2001-09-11 Ravi Pratap <ravi@ximian.com>
16920 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
16922 (Operator::Define): Re-write logic to get types by using the LookupType method
16923 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
16924 (Indexer::Define): Ditto.
16925 (Event::Define): Ditto.
16926 (Property::Define): Ditto.
16928 2001-09-10 Ravi Pratap <ravi@ximian.com>
16930 * class.cs (TypeContainer::Populate): Now define operators too.
16931 (TypeContainer.Operators): New property to access the list of operators
16933 (Operator.OperatorMethodBuilder): New member to hold the method builder
16934 for the operator we are defining.
16935 (Operator::Define): Implement.
16937 2001-09-10 Ravi Pratap <ravi@ximian.com>
16939 * class.cs (Event::Define): Make the prefixes of the accessor methods
16940 addOn_ and removeOn_
16942 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
16943 of the location being passed in too. Ideally, this should go later since all
16944 error reporting should be done through the Report object.
16946 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
16947 (Populate): Iterate thru the indexers we have and define them too.
16948 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
16949 for the get and set accessors.
16950 (Indexer::Define): Implement.
16952 2001-09-09 Miguel de Icaza <miguel@ximian.com>
16954 * expression.cs (Binary::Resolve): Beginning of it. I scratched
16955 my previous implementation, did not work.
16957 * typemanager.cs: Add a couple of missing types (the longs).
16959 * literal.cs: Use TypeManager.bool_type instead of getting it.
16961 * expression.cs (EventExpr): New kind of expressions.
16962 (Expressio::ExprClassFromMemberInfo): finish
16964 2001-09-08 Miguel de Icaza <miguel@ximian.com>
16966 * assign.cs: Emit stores to static fields differently.
16968 2001-09-08 Ravi Pratap <ravi@ximian.com>
16970 * Merge in changes and adjust code to tackle conflicts. Backed out my
16971 code in Assign::Resolve ;-)
16973 2001-09-08 Ravi Pratap <ravi@ximian.com>
16975 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
16976 instead Report.Error and also pass in the location.
16977 (CSharpParser::Lexer): New readonly property to return the reference
16978 to the Tokenizer object.
16979 (declare_local_variables): Use Report.Error with location instead of plain
16983 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
16984 (Operator.CheckBinaryOperator): Ditto.
16986 * cs-parser.jay (operator_declarator): Update accordingly.
16988 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
16989 (CheckBinaryOperator): Same here.
16991 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
16992 on the name without any prefixes of namespace names etc. This is because we
16993 already might have something already fully qualified like
16994 'System.Console.WriteLine'
16996 * assign.cs (Resolve): Begin implementation. Stuck ;-)
16998 2001-09-07 Ravi Pratap <ravi@ximian.com>
17000 * cs-tokenizer.cs (location): Return a string which also contains
17003 * expression.cs (ElementAccess): New class for expressions of the
17004 type 'element access.'
17005 (BaseAccess): New class for expressions of the type 'base access.'
17006 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17009 * cs-parser.jay (element_access): Implement action.
17010 (base_access): Implement actions.
17011 (checked_expression, unchecked_expression): Implement.
17013 * cs-parser.jay (local_variable_type): Correct and implement.
17014 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17016 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17018 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17019 name and the specifiers.
17021 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17023 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17024 making them all public ;-)
17026 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17029 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17031 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17033 (FieldExpr, PropertyExprs): New resolved expressions.
17034 (SimpleName::MemberStaticCheck): Perform static checks for access
17035 to non-static fields on static methods. Maybe this should be
17036 generalized for MemberAccesses.
17037 (SimpleName::ResolveSimpleName): More work on simple name
17040 * cs-parser.jay (primary_expression/qualified_identifier): track
17041 the parameter index.
17043 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17044 (EmitContext::EmitBoolExpression): Chain to expression generation
17045 instead of temporary hack.
17046 (::EmitStatementExpression): Put generic expression code generation.
17048 * assign.cs (Assign::Emit): Implement variable assignments to
17049 local variables, parameters and fields.
17051 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17053 * statement.cs (Block::GetVariableInfo): New method, returns the
17054 VariableInfo for a variable name in a block.
17055 (Block::GetVariableType): Implement in terms of GetVariableInfo
17057 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17058 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17060 2001-09-06 Ravi Pratap <ravi@ximian.com>
17062 * cs-parser.jay (operator_declaration): Continue on my quest : update
17063 to take attributes argument.
17064 (event_declaration): Ditto.
17065 (enum_declaration): Ditto.
17066 (indexer_declaration): Ditto.
17068 * class.cs (Operator::Operator): Update constructor accordingly.
17069 (Event::Event): Ditto.
17071 * delegate.cs (Delegate::Delegate): Same here.
17073 * enum.cs (Enum::Enum): Same here.
17075 2001-09-05 Ravi Pratap <ravi@ximian.com>
17077 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17079 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17081 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17082 being passed around as an arraylist.
17083 (Attributes::AddAttribute): Method to add attribute sections.
17085 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17086 (struct_declaration): Update accordingly.
17087 (constant_declaration): Update.
17088 (field_declaration): Update.
17089 (method_header): Update.
17090 (fixed_parameter): Update.
17091 (parameter_array): Ditto.
17092 (property_declaration): Ditto.
17093 (destructor_declaration): Ditto.
17095 * class.cs (Struct::Struct): Update constructors accordingly.
17096 (Class::Class): Ditto.
17097 (Field::Field): Ditto.
17098 (Method::Method): Ditto.
17099 (Property::Property): Ditto.
17100 (TypeContainer::OptAttribute): update property's return type.
17102 * interface.cs (Interface.opt_attributes): New member.
17103 (Interface::Interface): Update to take the extra Attributes argument.
17105 * parameter.cs (Parameter::Parameter): Ditto.
17107 * constant.cs (Constant::Constant): Ditto.
17109 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17110 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17111 the attributes as a parameter.
17112 (InterfaceProperty): Update constructor call.
17113 (InterfaceEvent): Ditto.
17114 (InterfaceMethod): Ditto.
17115 (InterfaceIndexer): Ditto.
17117 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17118 pass the attributes too.
17119 (interface_event_declaration): Ditto.
17120 (interface_property_declaration): Ditto.
17121 (interface_method_declaration): Ditto.
17122 (interface_declaration): Ditto.
17124 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17126 * class.cs (Method::Define): Track the "static Main" definition to
17127 create an entry point.
17129 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17130 EntryPoint if we find it.
17132 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17133 (EmitContext::ig): Make this variable public.
17135 * driver.cs: Make the default output file be the first file name
17136 with the .exe extension.
17138 Detect empty compilations
17140 Handle various kinds of output targets. Handle --target and
17141 rename -t to --dumper.
17143 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17144 methods inherited from Expression return now an Expression. This
17145 will is used during the tree rewriting as we resolve them during
17148 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17149 the spec. Missing entirely is the information about
17150 accessability of elements of it.
17152 (Expression::ExprClassFromMemberInfo): New constructor for
17153 Expressions that creates a fully initialized Expression based on
17154 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17157 (Invocation::Resolve): Begin implementing resolution of invocations.
17159 * literal.cs (StringLiteral): Implement Emit.
17161 2001-09-05 Ravi Pratap <ravi@ximian.com>
17163 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17166 2001-09-04 Ravi Pratap <ravi@ximian.com>
17168 * cs-parser.jay (attribute_arguments): Implement actions.
17169 (attribute): Fix bug in production. Implement action.
17170 (attribute_list): Implement.
17171 (attribute_target): Implement.
17172 (attribute_target_specifier, opt_target_specifier): Implement
17173 (CheckAttributeTarget): New method to check if the attribute target
17175 (attribute_section): Implement.
17176 (opt_attributes): Implement.
17178 * attribute.cs : New file to handle attributes.
17179 (Attribute): Class to hold attribute info.
17181 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17182 (attribute_section): Modify production to use 2 different rules to
17183 achieve the same thing. 1 s/r conflict down !
17184 Clean out commented, useless, non-reducing dimension_separator rules.
17186 * class.cs (TypeContainer.attributes): New member to hold list
17187 of attributes for a type.
17188 (Struct::Struct): Modify to take one more argument, the attribute list.
17189 (Class::Class): Ditto.
17190 (Field::Field): Ditto.
17191 (Method::Method): Ditto.
17192 (Property::Property): Ditto.
17194 * cs-parser.jay (struct_declaration): Update constructor call to
17195 pass in the attributes too.
17196 (class_declaration): Ditto.
17197 (constant_declaration): Ditto.
17198 (field_declaration): Ditto.
17199 (method_header): Ditto.
17200 (fixed_parameter): Ditto.
17201 (parameter_array): Ditto.
17202 (property_declaration): Ditto.
17204 * constant.cs (Constant::Constant): Update constructor similarly.
17205 Use System.Collections.
17207 * parameter.cs (Parameter::Parameter): Update as above.
17209 2001-09-02 Ravi Pratap <ravi@ximian.com>
17211 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17212 (TypeContainer.delegates): New member to hold list of delegates.
17214 * cs-parser.jay (delegate_declaration): Implement the action correctly
17215 this time as I seem to be on crack ;-)
17217 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17219 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17220 tell whether an identifier represents a namespace.
17222 * expression.cs (NamespaceExpr): A namespace expression, used only
17223 temporarly during expression resolution.
17224 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17225 utility functions to resolve names on expressions.
17227 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17229 * codegen.cs: Add hook for StatementExpressions.
17231 * class.cs: Fix inverted test for static flag in methods.
17233 2001-09-02 Ravi Pratap <ravi@ximian.com>
17235 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17236 to make it coincide with MS' number.
17237 (Operator::CheckBinaryOperator): Ditto.
17239 * ../errors/errors.txt : Remove error numbers added earlier.
17241 * ../errors/cs1019.cs : Test case for error # 1019
17243 * ../errros/cs1020.cs : Test case for error # 1020
17245 * cs-parser.jay : Clean out commented cruft.
17246 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17247 used anywhere - non-reducing rule.
17248 (namespace_declarations): Non-reducing rule - comment out.
17250 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17251 with TypeContainer::AddEnum.
17253 * delegate.cs : New file for delegate handling classes.
17254 (Delegate): Class for declaring delegates.
17256 * makefile : Update.
17258 * cs-parser.jay (delegate_declaration): Implement.
17260 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17262 * class.cs (Event::Define): Implement.
17263 (Event.EventBuilder): New member.
17265 * class.cs (TypeContainer::Populate): Update to define all enums and events
17267 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17268 readonly fields for all these cases ?
17270 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17272 * class.cs (Property): Revamp to use the convention of making fields readonly.
17273 Accordingly modify code elsewhere.
17275 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17276 the Define method of the Property class.
17278 * class.cs : Clean up applied patch and update references to variables etc. Fix
17280 (TypeContainer::Populate): Update to define all the properties we have. Also
17281 define all enumerations.
17283 * enum.cs (Define): Implement.
17285 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17287 * cs-parser.jay (overloadable_operator): The semantic value is an
17288 enum of the Operator class.
17289 (operator_declarator): Implement actions.
17290 (operator_declaration): Implement.
17292 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17293 validity of definitions.
17294 (Operator::CheckBinaryOperator): Static method to check for binary operators
17295 (TypeContainer::AddOperator): New method to add an operator to a type.
17297 * cs-parser.jay (indexer_declaration): Added line to actually call the
17298 AddIndexer method so it gets added ;-)
17300 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17301 already taken care of by the MS compiler ?
17303 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17305 * class.cs (Operator): New class for operator declarations.
17306 (Operator::OpType): Enum for the various operators.
17308 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17310 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17311 ostensibly handle this in semantic analysis.
17313 * cs-parser.jay (general_catch_clause): Comment out
17314 (specific_catch_clauses, specific_catch_clause): Ditto.
17315 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17316 (catch_args, opt_catch_args): New productions.
17317 (catch_clause): Rewrite to use the new productions above
17318 (catch_clauses): Modify accordingly.
17319 (opt_catch_clauses): New production to use in try_statement
17320 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17321 and re-write the code in the actions to extract the specific and
17322 general catch clauses by being a little smart ;-)
17324 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17325 Hooray, try and catch statements parse fine !
17327 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17329 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17330 string from the hashtable of variables.
17332 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17333 I end up making that mistake ;-)
17334 (catch_clauses): Fixed gross error which made Key and Value of the
17335 DictionaryEntry the same : $1 !!
17337 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17339 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17341 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17342 when the add and remove accessors are specified.
17344 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17346 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17347 information about indexer_declarator.
17348 (indexer_declarator): Implement actions.
17349 (parsing_indexer): New local boolean used to keep track of whether
17350 we are parsing indexers or properties. This is necessary because
17351 implicit_parameters come into picture even for the get accessor in the
17352 case of an indexer.
17353 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17355 * class.cs (Indexer): New class for indexer declarations.
17356 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17357 (TypeContainer::indexers): New member to hold list of indexers for the
17360 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17362 * cs-parser.jay (add_accessor_declaration): Implement action.
17363 (remove_accessor_declaration): Implement action.
17364 (event_accessors_declaration): Implement
17365 (variable_declarators): swap statements for first rule - trivial.
17367 * class.cs (Event): New class to hold information about event
17369 (TypeContainer::AddEvent): New method to add an event to a type
17370 (TypeContainer::events): New member to hold list of events.
17372 * cs-parser.jay (event_declaration): Implement actions.
17374 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17376 * cs-parser.jay (dim_separators): Implement. Make it a string
17377 concatenating all the commas together, just as they appear.
17378 (opt_dim_separators): Modify accordingly
17379 (rank_specifiers): Update accordingly. Basically do the same
17380 thing - instead, collect the brackets here.
17381 (opt_rank_sepcifiers): Modify accordingly.
17382 (array_type): Modify to actually return the complete type string
17383 instead of ignoring the rank_specifiers.
17384 (expression_list): Implement to collect the expressions
17385 (variable_initializer): Implement. We make it a list of expressions
17386 essentially so that we can handle the array_initializer case neatly too.
17387 (variable_initializer_list): Implement.
17388 (array_initializer): Make it a list of variable_initializers
17389 (opt_array_initializer): Modify accordingly.
17391 * expression.cs (New::NType): Add enumeration to help us
17392 keep track of whether we have an object/delegate creation
17393 or an array creation.
17394 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17395 members to hold data about array creation.
17396 (New:New): Modify to update NewType
17397 (New:New): New Overloaded contructor for the array creation
17400 * cs-parser.jay (array_creation_expression): Implement to call
17401 the overloaded New constructor.
17403 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17405 * class.cs (TypeContainer::Constructors): Return member
17406 constructors instead of returning null.
17408 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17410 * typemanager.cs (InitCoreTypes): Initialize the various core
17411 types after we have populated the type manager with the user
17412 defined types (this distinction will be important later while
17413 compiling corlib.dll)
17415 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17416 on Expression Classification. Now all expressions have a method
17417 `Resolve' and a method `Emit'.
17419 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17420 generation from working. Also add some temporary debugging
17423 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17425 * codegen.cs: Lots of code generation pieces. This is only the
17426 beginning, will continue tomorrow with more touches of polish. We
17427 handle the fundamentals of if, while, do, for, return. Others are
17428 trickier and I need to start working on invocations soon.
17430 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17433 * codegen.cs (EmitContext): New struct, used during code
17434 emission to keep a context. Most of the code generation will be
17437 * cs-parser.jay: Add embedded blocks to the list of statements of
17438 this block. So code generation proceeds in a top down fashion.
17440 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17442 * statement.cs: Add support for multiple child blocks.
17444 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17446 * codegen.cs (EmitCode): New function, will emit the code for a
17447 Block of code given a TypeContainer and its ILGenerator.
17449 * statement.cs (Block): Standard public readonly optimization.
17450 (Block::Block constructors): Link children.
17451 (Block::Child): Child Linker.
17452 (Block::EmitVariables): Emits IL variable declarations.
17454 * class.cs: Drop support for MethodGroups here, delay until
17456 (Method::): Applied the same simplification that I did before, and
17457 move from Properties to public readonly fields.
17458 (Method::ParameterTypes): Returns the parameter types for the
17459 function, and implements a cache that will be useful later when I
17460 do error checking and the semantic analysis on the methods is
17462 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17463 and made a method, optional argument tells whether this is a class
17464 or a structure to apply the `has-this' bit.
17465 (Method::GetCallingConvention): Implement, returns the calling
17467 (Method::Define): Defines the type, a second pass is performed
17468 later to populate the methods.
17470 (Constructor::ParameterTypes): implement a cache similar to the
17471 one on Method::ParameterTypes, useful later when we do semantic
17474 (TypeContainer::EmitMethod): New method. Emits methods.
17476 * expression.cs: Removed MethodGroup class from here.
17478 * parameter.cs (Parameters::GetCallingConvention): new method.
17480 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17482 * class.cs (TypeContainer::Populate): Drop RootContext from the
17485 (Constructor::CallingConvention): Returns the calling convention.
17486 (Constructor::ParameterTypes): Returns the constructor parameter
17489 (TypeContainer::AddConstructor): Keep track of default constructor
17490 and the default static constructor.
17492 (Constructor::) Another class that starts using `public readonly'
17493 instead of properties.
17495 (Constructor::IsDefault): Whether this is a default constructor.
17497 (Field::) use readonly public fields instead of properties also.
17499 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17500 track of static constructors; If none is used, turn on
17501 BeforeFieldInit in the TypeAttributes.
17503 * cs-parser.jay (opt_argument_list): now the return can be null
17504 for the cases where there are no arguments.
17506 (constructor_declarator): If there is no implicit `base' or
17507 `this', then invoke the default parent constructor.
17509 * modifiers.cs (MethodAttr): New static function maps a set of
17510 modifiers flags into a MethodAttributes enum
17511 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17512 MethodAttr, TypeAttr to represent the various mappings where the
17513 modifiers are used.
17514 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17516 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17518 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17521 * interface.cs (PopulateIndexer): Implemented the code generator
17522 for interface indexers.
17524 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17526 * interface.cs (InterfaceMemberBase): Now we track the new status
17529 (PopulateProperty): Implement property population. Woohoo! Got
17530 Methods and Properties going today.
17532 Removed all the properties for interfaces, and replaced them with
17533 `public readonly' fields.
17535 2001-08-16 Miguel de Icaza <miguel@ximian.com>
17537 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
17538 initialize their hashtables/arraylists only when they are needed
17539 instead of doing this always.
17541 * parameter.cs: Handle refs and out parameters.
17543 * cs-parser.jay: Use an ArrayList to construct the arguments
17544 instead of the ParameterCollection, and then cast that to a
17547 * parameter.cs: Drop the use of ParameterCollection and use
17548 instead arrays of Parameters.
17550 (GetParameterInfo): Use the Type, not the Name when resolving
17553 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17555 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17556 and instead use public readonly fields.
17558 * class.cs: Put back walking code for type containers.
17560 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17562 * class.cs (MakeConstant): Code to define constants.
17564 * rootcontext.cs (LookupType): New function. Used to locate types
17567 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17569 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17570 this System.Reflection code is. Kudos to Microsoft
17572 * typemanager.cs: Implement a type cache and avoid loading all
17573 types at boot time. Wrap in LookupType the internals. This made
17574 the compiler so much faster. Wow. I rule!
17576 * driver.cs: Make sure we always load mscorlib first (for
17577 debugging purposes, nothing really important).
17579 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
17580 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
17582 * rootcontext.cs: Lookup types on their namespace; Lookup types
17583 on namespaces that have been imported using the `using' keyword.
17585 * class.cs (TypeContainer::TypeAttr): Virtualize.
17586 (Class::TypeAttr): Return attributes suitable for this bad boy.
17587 (Struct::TypeAttr): ditto.
17588 Handle nested classes.
17589 (TypeContainer::) Remove all the type visiting code, it is now
17590 replaced with the rootcontext.cs code
17592 * rootcontext.cs (GetClassBases): Added support for structs.
17594 2001-08-06 Miguel de Icaza <miguel@ximian.com>
17596 * interface.cs, statement.cs, class.cs, parameter.cs,
17597 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
17598 Drop use of TypeRefs, and use strings instead.
17600 2001-08-04 Miguel de Icaza <miguel@ximian.com>
17604 * class.cs (Struct::Struct): set the SEALED flags after
17605 checking the modifiers.
17606 (TypeContainer::TypeAttr): new property, returns the
17607 TypeAttributes for a class.
17609 * cs-parser.jay (type_list): Oops, list production was creating a
17610 new list of base types.
17612 * rootcontext.cs (StdLib): New property.
17613 (GetInterfaceTypeByName): returns an interface by type name, and
17614 encapsulates error handling here.
17615 (GetInterfaces): simplified.
17616 (ResolveTree): Encapsulated all the tree resolution here.
17617 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
17620 * driver.cs: Add support for --nostdlib, to avoid loading the
17621 default assemblies.
17622 (Main): Do not put tree resolution here.
17624 * rootcontext.cs: Beginning of the class resolution.
17626 2001-08-03 Miguel de Icaza <miguel@ximian.com>
17628 * rootcontext.cs: Provide better error reporting.
17630 * cs-parser.jay (interface_base): set our $$ to be interfaces.
17632 * rootcontext.cs (CreateInterface): Handle the case where there
17633 are no parent interfaces.
17635 (CloseTypes): Routine to flush types at the end.
17636 (CreateInterface): Track types.
17637 (GetInterfaces): Returns an array of Types from the list of
17638 defined interfaces.
17640 * typemanager.c (AddUserType): Mechanism to track user types (puts
17641 the type on the global type hash, and allows us to close it at the
17644 2001-08-02 Miguel de Icaza <miguel@ximian.com>
17646 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
17647 RecordInterface instead.
17649 * cs-parser.jay: Updated to reflect changes above.
17651 * decl.cs (Definition): Keep track of the TypeBuilder type that
17652 represents this type here. Not sure we will use it in the long
17653 run, but wont hurt for now.
17655 * driver.cs: Smaller changes to accomodate the new code.
17657 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
17660 * rootcontext.cs (CreateInterface): New method, used to create
17661 the System.TypeBuilder type for interfaces.
17662 (ResolveInterfaces): new entry point to resolve the interface
17664 (CodeGen): Property, used to keep track of the code generator.
17666 2001-07-26 Miguel de Icaza <miguel@ximian.com>
17668 * cs-parser.jay: Add a second production for delegate_declaration
17671 (enum_body): Put an opt_comma here instead of putting it on
17672 enum_body or enum_member_declarations so we can handle trailing
17673 commas on enumeration members. Gets rid of a shift/reduce.
17675 (type_list): Need a COMMA in the middle.
17677 (indexer_declaration): Tell tokenizer to recognize get/set
17679 * Remove old targets.
17681 * Re-add the parser target.
17683 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17685 * cs-parser.jay: Add precendence rules for a number of operators
17686 ot reduce the number of shift/reduce conflicts in the grammar.
17688 2001-07-17 Miguel de Icaza <miguel@ximian.com>
17690 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
17693 Get rid of old crufty code.
17695 * rootcontext.cs: Use this to keep track of the parsed
17696 representation and the defined types available to the program.
17698 * gen-treedump.cs: adjust for new convention.
17700 * type.cs: Split out the type manager, and the assembly builder
17703 * typemanager.cs: the type manager will live here now.
17705 * cil-codegen.cs: And the code generator here.
17707 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
17709 * makefile: Fixed up for easy making.
17711 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17713 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
17716 (unary_expression): Expand pre_increment_expression and
17717 post_decrement_expression to reduce a shift/reduce.
17719 2001-07-11 Simon Cozens
17721 * cs-tokenizer.cs: Hex numbers should begin with a 0.
17723 Improve allow_keyword_as_indent name.
17725 2001-06-19 Miguel de Icaza <miguel@ximian.com>
17727 * Adjustments for Beta2.
17729 2001-06-13 Miguel de Icaza <miguel@ximian.com>
17731 * decl.cs: Added `Define' abstract method.
17732 (InTransit): new property, used to catch recursive definitions.
17734 * interface.cs: Implement `Define'.
17736 * modifiers.cs: Map Modifiers.constants to
17737 System.Reflection.TypeAttribute flags.
17739 * class.cs: Keep track of types and user-defined types.
17740 (BuilderInit): New method for creating an assembly
17741 (ResolveType): New function to launch the resolution process, only
17742 used by interfaces for now.
17744 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
17745 that are inserted into the name space.
17747 2001-06-08 Miguel de Icaza <miguel@ximian.com>
17749 * ARGH. I have screwed up my tree so many times due to the use of
17750 rsync rather than using CVS. Going to fix this at once.
17752 * driver.cs: Objetify driver. Load assemblies, use assemblies to
17755 2001-06-07 Miguel de Icaza <miguel@ximian.com>
17757 * Experiment successful: Use System.Type rather that our own
17760 2001-05-25 Miguel de Icaza <miguel@ximian.com>
17762 * cs-parser.jay: Removed nsAliases from here.
17764 Use new namespaces, handle `using XXX;'
17766 * namespace.cs: Reimplemented namespace handling, use a recursive
17767 definition of the class. Now we can keep track of using clauses
17768 and catch invalid using clauses.
17770 2001-05-24 Miguel de Icaza <miguel@ximian.com>
17772 * gen-treedump.cs: Adapted for all the renaming.
17774 * expression.cs (Expression): this class now has a Type property
17775 which returns an expression Type.
17777 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
17778 `Type', as this has a different meaning now in the base
17780 2001-05-22 Miguel de Icaza <miguel@ximian.com>
17782 * interface.cs, class.cs: Removed from all the sources the
17783 references to signature computation, as we can not do method
17784 signature computation during the parsing time, as we are not
17785 trying to solve at that point distinguishing:
17789 void a (NS.Blah x) {}
17792 Which depending on the context might be valid or not, as we do not
17793 know if Blah is the same thing as NS.Blah at that point.
17795 * Redid everything so the code uses TypeRefs now instead of
17796 Types. TypeRefs are just temporary type placeholders, that need
17797 to be resolved. They initially have a pointer to a string and the
17798 current scope in which they are used. This is used later by the
17799 compiler to resolve the reference to an actual Type.
17801 * DeclSpace is no longer a CIR.Type, and neither are
17802 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
17803 are all DeclSpaces, but no Types.
17805 * type.cs (TypeRefManager): This implements the TypeRef manager,
17806 which keeps track of all the types that need to be resolved after
17807 the parsing has finished.
17809 2001-05-13 Miguel de Icaza <miguel@ximian.com>
17811 * ARGH. We are going to have to store `foreach' as a class rather
17812 than resolving it, as we need to verify error 1579 after name
17813 resolution. *OR* we could keep a flag that says `This request to
17814 IEnumerator comes from a foreach statement' which we can then use
17815 to generate the error.
17817 2001-05-10 Miguel de Icaza <miguel@ximian.com>
17819 * class.cs (TypeContainer.AddMethod): we now add methods to the
17820 MethodGroup instead of the method hashtable.
17822 * expression.cs: Add MethodGroup abstraction, which gets us one
17823 step closer to the specification in the way we handle method
17826 * cs-parser.jay (primary_expression): qualified_identifier now
17827 tried to match up an identifier to a local variable reference or
17828 to a parameter reference.
17830 current_local_parameters is now a parser global variable that
17831 points to the current parameters for the block, used during name
17834 (property_declaration): Now creates an implicit `value' argument to
17837 2001-05-09 Miguel de Icaza <miguel@ximian.com>
17839 * parameter.cs: Do not use `param' arguments as part of the
17840 signature, per the spec.
17842 2001-05-08 Miguel de Icaza <miguel@ximian.com>
17844 * decl.cs: Base class for classes, structs and interfaces. This
17845 is the "Declaration Space"
17847 * cs-parser.jay: Use CheckDef for checking declaration errors
17848 instead of having one on each function.
17850 * class.cs: Factor out some code for handling error handling in
17851 accordance to the "Declarations" section in the "Basic Concepts"
17852 chapter in the ECMA C# spec.
17854 * interface.cs: Make all interface member classes derive from
17855 InterfaceMemberBase.
17857 2001-05-07 Miguel de Icaza <miguel@ximian.com>
17859 * Many things: all interfaces are parsed and generated in
17860 gen-treedump. Support for member variables, constructors,
17861 destructors, properties, constants is there.
17863 Beginning of the IL backend, but very little done, just there for
17866 2001-04-29 Miguel de Icaza <miguel@ximian.com>
17868 * cs-parser.jay: Fix labeled statement.
17870 * cs-tokenizer.cs (escape): Escape " and ' always.
17871 ref_line, ref_name: keep track of the line/filename as instructed
17872 by #line by the compiler.
17875 2001-04-27 Miguel de Icaza <miguel@ximian.com>
17877 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
17878 to match the values in System.CodeDOM.
17880 Divid renamed to Divide.
17882 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
17884 (Statements.set): remove.
17886 * System.CodeDOM/CodeCatchClause.cs: always have a valid
17889 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
17890 falseStatements always have valid values.
17892 * cs-parser.jay: Use System.CodeDOM now.