1 2008-05-07 Marek Safar <marek.safar@gmail.com>
3 * expression.cs, parameter.cs: Small ParameterReference clean up.
5 2008-05-07 Marek Safar <marek.safar@gmail.com>
7 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
10 2008-05-06 Martin Baulig <martin@ximian.com>
12 * class.cs (Constructor.Emit): Fix the logic whether to emit
15 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
18 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
19 InvalidOperationException when the iterator is before the start or
22 2008-05-06 Marek Safar <marek.safar@gmail.com>
24 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
25 when left is nullable type.
27 2008-05-06 Marek Safar <marek.safar@gmail.com>
30 * expression.cs (LocalVariableReference): Continue in resolving when
31 variable is not assigned.
33 2008-05-05 Marek Safar <marek.safar@gmail.com>
35 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
38 2008-05-04 Marek Safar <marek.safar@gmail.com>
40 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
41 it saves many redundant temporary variables for nullable operations.
43 2008-05-03 Marek Safar <marek.safar@gmail.com>
45 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
47 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
50 * nullable.cs: Constant coalescing operator optimizations.
52 2008-05-03 Marek Safar <marek.safar@gmail.com>
54 * constant.cs: Use unsigned conversion for values which are unsigned only.
56 2008-05-03 Marek Safar <marek.safar@gmail.com>
58 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
59 coalescing operator as it should be.
61 2008-05-02 Marek Safar <marek.safar@gmail.com>
64 * expression.cs: All predefined delegate operators require implicit method
67 2008-05-02 Marek Safar <marek.safar@gmail.com>
69 * constant.cs: Emit long constant as uint when fits the range.
71 * convert.cs, expression.cs: Fixed few unsafe conversions.
73 2008-05-02 Marek Safar <marek.safar@gmail.com>
75 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
77 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
80 * convert.cs (ImplicitNumericConversion): Don't modify the type of
82 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
84 2008-05-01 Marek Safar <marek.safar@gmail.com>
86 * constant.cs, literal.cs: IsLiteral property for error reporting.
88 * ecore.cs, expression.cs: Implemented Property expression.
90 2008-05-01 Marek Safar <marek.safar@gmail.com>
92 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
94 * nullable.cs: Implemented nullable coalescing null operator.
96 * ecore.cs, expression.cs: Expression trees work.
98 2008-05-01 Marek Safar <marek.safar@gmail.com>
100 * ecore.cs: CreateExpressionTree is finally abstract.
102 * expression.cs, linq.cs: Updated.
104 2008-05-01 Marek Safar <marek.safar@gmail.com>
106 * expression.cs, ecore.cs: Block base access expression inside expression
109 2008-05-01 Marek Safar <marek.safar@gmail.com>
111 A fix for bug #385058
112 * expression.cs: User-defined operator implementations always take
113 precedence over predefined operator implementations.
115 2008-04-30 Marek Safar <marek.safar@gmail.com>
117 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
118 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
119 expression tree conversions.
121 2008-04-30 Marek Safar <marek.safar@gmail.com>
123 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
124 operators method details to Operator class.
126 2008-04-30 Marek Safar <marek.safar@gmail.com>
128 * anonymous.cs: Pass unsafe flags to anonymous container.
130 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
131 inside expression tree.
133 2008-04-29 Martin Baulig <martin@ximian.com>
135 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
136 (Tokenizer.PopPosition): Also restore the `line'.
138 2008-04-29 Marek Safar <marek.safar@gmail.com>
140 * delegate.cs: Implemented Invoke expression.
142 2008-04-29 Marek Safar <marek.safar@gmail.com>
144 * expression.cs: Fixed equality reference comparison regression.
146 2008-04-29 Marek Safar <marek.safar@gmail.com>
148 * ecore.cs: Clean up EmptyCast hack.
150 * expression.cs, nullable.cs: Implemented enum binary and unary operations
151 using correct conversion rules. Also fixes #383993.
153 2008-04-28 Martin Baulig <martin@ximian.com>
155 * class.cs (Constructor.Emit): Don't emit debugging information
156 for generated default .ctor's.
158 2008-04-28 Marek Safar <marek.safar@gmail.com>
160 * convert.cs: Empty-cast ushort to int conversion.
162 2008-04-28 Marek Safar <marek.safar@gmail.com>
164 A fix for bug #384191
165 * ecore.cs, expression.cs: Fixed expression cloning.
167 2008-04-28 Marek Safar <marek.safar@gmail.com>
169 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
171 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
173 Fix #381559, test-638.cs, test-639.cs
174 * assign.cs (CompoundAssign.Helper): New wrapper.
175 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
177 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
178 Pass unconverted expressions to the params array creation expression.
179 (FieldExpr.EmitAssign): Don't special-case StringConcat.
180 (PropertyExpr.EmitAssign): Likewise.
181 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
182 element if it is of kind CompoundAssign.Helper.
183 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
184 first before anything else.
185 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
186 (ArrayAccess.LoadArrayAndArguments): Simplify.
188 2008-04-27 Marek Safar <marek.safar@gmail.com>
190 * expression.cs: Fixed cloning of typeof(void).
192 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
194 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
195 (Assign.Emit): Likewise. Move it to ...
196 (CompoundAssign.DoResolve): ... here and ...
197 (CompoundAssign.Emit): ... here.
198 (EventAddOrRemove): New helper to handle += and -= on events, and
199 avoid the use of BinaryDelegates.
200 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
201 (EventExpr.EmitAddOrRemove): Improve.
202 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
204 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
205 create VarExprs for 'foo.bar.var'.
206 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
207 is a highly inappropriate name for its functionality.
209 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
211 Simplify handling of multiple assignments
212 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
214 (SimpleAssign): New. Class to be used for normal assignments.
215 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
216 * expression.cs, parameter.cs, statement.cs: Likewise.
218 2008-04-25 Marek Safar <marek.safar@gmail.com>
220 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
221 for incompatible underlying types, more to come, uff.
223 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
226 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
229 2008-04-25 Marek Safar <marek.safar@gmail.com>
231 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
233 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
235 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
236 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
237 * statement.cs (While, Do, For): Allow test to have side effects.
238 (For.DoEmit): Always emit InitStatement.
241 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
242 Always create SideEffectConstant.
243 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
244 of type EnumConstant.
246 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
247 Handle 'right' being SideEffectConstant of type 'bool'.
249 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
250 Use left.EmitBranchable instead of open coding it, so as to
251 improve optimization opportunities.
253 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
255 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
257 (Expression.EmitSideEffect): Document.
259 2008-04-23 Marek Safar <marek.safar@gmail.com>
261 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
263 2008-04-23 Marek Safar <marek.safar@gmail.com>
265 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
267 2008-04-23 Marek Safar <marek.safar@gmail.com>
269 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
270 conversion to expression tree.
272 2008-04-23 Marek Safar <marek.safar@gmail.com>
274 * ecore.cs: Removed unused expression.
276 2008-04-22 Marek Safar <marek.safar@gmail.com>
278 * expression.cs: Implemented NegateChecked and New expressions.
280 2008-04-22 Marek Safar <marek.safar@gmail.com>
282 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
284 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
287 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
288 needing final 'ret' instruction.
290 2008-04-22 Marek Safar <marek.safar@gmail.com>
292 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
294 2008-04-21 Marek Safar <marek.safar@gmail.com>
296 * expression.cs: Emit ldnull and not null expression as an instance argument
297 of static method expression calls.
299 2008-04-21 Marek Safar <marek.safar@gmail.com>
301 A fix for bug #378200
302 * expression.cs: Fixed crash when creating parameterless expression tree
305 2008-04-21 Marek Safar <marek.safar@gmail.com>
307 A fix for bug #375297
308 * anonymous.cs: Fixed crash when inferring from null argument anonymous
311 2008-04-21 Marek Safar <marek.safar@gmail.com>
313 A fix for bug #377596
314 * decl.cs, class.cs: Emit delegate type argument attributes.
316 2008-04-21 Marek Safar <marek.safar@gmail.com>
318 A fix for bug #365314
319 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
321 2008-04-21 Marek Safar <marek.safar@gmail.com>
323 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
326 2008-04-21 Marek Safar <marek.safar@gmail.com>
328 * generic.cs (TypeParameter): Removed redundant location.
330 2008-04-19 Marek Safar <marek.safar@gmail.com>
332 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
333 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
334 FullNamedExpression in all declaration type expression, statements will come
337 2008-04-18 Marek Safar <marek.safar@gmail.com>
339 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
340 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
342 2008-04-18 Marek Safar <marek.safar@gmail.com>
344 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
347 2008-04-17 Marek Safar <marek.safar@gmail.com>
349 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
352 2008-04-17 Marek Safar <marek.safar@gmail.com>
354 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
358 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
360 Hook up 'EmitSideEffect'
361 * constant.cs (Constant.EmitSideEffect): New.
362 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
363 (SideEffectConstant.EmitSideEffect): New.
364 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
365 unconditional branch in EmitBranchable.
366 (FieldExpr.EmitBranchable): New.
367 * expression.cs (Unary.EmitSideEffect): New.
368 (Binary.EmitSideEffect): New.
369 (VariableReference.EmitSideEffect): New. Do nothing.
371 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
373 Introduce 'EmitSideEffect'
374 * ecore.cs (Expression.EmitSideEffect): New.
375 (TypeCast): Rename from EmptyCast.
377 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
378 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
379 * convert.cs, nullable.cs: Update to changes.
381 2008-04-16 Marek Safar <marek.safar@gmail.com>
383 * class.cs, cs-parser.jay: Early check for base types expression.
385 2008-04-16 Marek Safar <marek.safar@gmail.com>
387 * decl.cs (MemberName): Declare PrettyName as obsolete.
389 2008-04-16 Marek Safar <marek.safar@gmail.com>
391 * namespace.cs: Use MemberName comparison.
393 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
396 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
398 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
399 (MemberName.FullyQualifiedName): New. Provides the functionality
400 that users assume FullName would have.
401 * ecore.cs, namespace.cs: Update to changes.
403 * statement.cs (Using.assign): Make into ExpressionStatement.
404 (Using.EmitPreTryBody): Simplify.
406 2008-04-16 Marek Safar <marek.safar@gmail.com>
408 * report.cs: ColorFormat is protected.
410 * rootcontext.cs: Unused fields clean-up.
412 * namespace.cs: Made UsingEntry name private.
414 2008-04-16 Marek Safar <marek.safar@gmail.com>
416 * cs-tokenizer.cs, location.cs: Removed unused field.
418 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
419 Raja R Harinath <harinath@hurrynot.org>
422 * constant.cs (SideEffectConstant.value): Rename from 'left'.
423 (SideEffectConstant.side_effect): Rename from 'right'.
424 (SideEffectConstant..ctor): Normalize 'side_effect'.
425 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
426 value of this constant.
427 * cfold.cs: Update to changes.
429 2008-04-15 Marek Safar <marek.safar@gmail.com>
431 * cs-paser.jay: Removed unused variable.
433 * driver.cs: Made Compile instance method.
435 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
437 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
439 2008-04-15 Marek Safar <marek.safar@gmail.com>
441 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
443 2008-04-13 Jb Evain <jbevain@novell.com>
445 * namespace.cs: update the System.Core fullname for 2.1
446 * driver.cs: update the list of required assemblies for 2.1.
447 Merged from the Moonlight 2 branch.
449 2008-04-11 Marek Safar <marek.safar@gmail.com>
451 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
452 types and user defined operators. User operators arguments has to be checked
453 for null value before invocation, which also means no operator is called
454 when any argument is not convertible to unwrapped nullable type.
456 2008-04-09 Marek Safar <marek.safar@gmail.com>
458 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
459 of Unary expressions to follow operator overloading rules precisely.
460 Also fixes #321794, #323794
462 2008-04-08 Marek Safar <marek.safar@gmail.com>
464 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
467 2008-04-08 Marek Safar <marek.safar@gmail.com>
469 * expression.cs, ecore.cs: Implemented MemberInit expression.
471 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
473 Fix mono/tests/exception4.cs
474 * statement.cs (ExceptionStatement, TryCatch): Revert to using
475 ec.NeedReturnLabel () rather emitting a 'nop'.
477 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
479 (TryCatch.SomeCodeFollows): Likewise.
480 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
481 for 'break', 'continue' and 'return' statements inside a try.
482 We're fairly sure that the generated IL stream will have more
483 instructions textually following the try.
484 (FlowBranchingTryCatch): Likewise.
486 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
487 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
490 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
491 wrapper -- forward everything to CollectionForeach.
492 (CollectionForeach.NonDisposableWrapper): New.
493 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
494 instead of a pop + branch to end.
496 2008-04-07 Marek Safar <marek.safar@gmail.com>
498 A fix for bug #377485
499 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
500 Propagate location for extension method groups. Report conversion failure at
503 2008-04-07 Marek Safar <marek.safar@gmail.com>
505 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
506 ListInit and Field expressions.
508 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
510 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
511 Since $PC is always -1 inside the body of MoveNext, the fault
513 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
514 * statement.cs (ExceptionStatement.emit_finally): Likewise.
515 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
517 The denouement! Fix #324708
518 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
519 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
520 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
521 'finally' inside the finally clause.
523 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
524 inside an iterator. Don't emit the body of the 'finally' inside
525 the finally clause yet.
527 Use the ResumableStatement infrastructure for MoveNext ()
528 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
529 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
530 'old_resume_points'. Move dispatcher upfront.
531 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
532 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
533 in an enumerator. This encodes the main fix in this patch series
534 -- we can only jump into the first instruction of a try from the
535 outside, but we want to emit try/finally regions in iterators and
536 resume in the middle of them.
538 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
540 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
541 of NeedReturnLabel here.
543 Introduce a common point for emitting try/finally to IL
544 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
545 features of the various subclasses, which are now driven by ...
546 (ExceptionStatement.EmitPreTryBody): ... this and ...
547 (ExceptionStatement.EmitTryBody): ... this and the original
549 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
550 Remove DoEmit and update to follow above protocol.
552 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
553 of the dispatcher are the same, skip emitting the 'switch'.
554 * iterator.cs (Iterator.EmitDispose): Update to changes.
556 Clean up handling of 'using' statement
557 * statement.cs (UsingTemporary): New. Carved out of ...
558 (Using): ... this. Simplify drastically. Handle exactly
560 * cs-parser.jay (using_statement): Split. Create UsingTemporary
561 or Using as appropriate. If there are multiple variable declared,
562 create nested Using statements.
563 (resource_acquisition): Kill.
565 * statement.cs (ExceptionStatement.EmitForDispose): Use
566 EmitFinallyBody, not EmitFinally.
568 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
569 * iterator.cs: Update to changes.
571 Start using the ResumableStatement infrastructure
572 * statement.cs (ResumeableStatement.PrepareForDispose): New.
573 (ResumableStatement.EmitForDispose): New.
574 (ExceptionStatement): Override them.
575 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
576 EmitForDispose to create the body of the Dispose method. Don't
579 * iterator.cs (Iterator.AddResumePoint): Move here from ...
580 * statement.cs (Toplevel.AddResumePoint): ... here.
581 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
582 * flowanalysis.cs (FlowBranchingIterator): New.
583 * codegen.cs (EmitContext): Update to changes.
585 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
586 (Iterator.old_resume_points): Rename from 'resume_points'.
587 (Iterator.MoveNextStatement): Remove unused class.
589 New infrastructure for try/finally in iterators (still unused)
590 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
591 (FlowBranchingToplevel.AddResumePoint): Hook into
592 ToplevelBlock.AddResumePoint.
593 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
594 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
595 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
596 resume points and assign program-counter values.
597 (ExceptionBlock.AddResumePoint): Collect resume points for
598 de-muxer at the top of try block.
599 * iterators.cs (Yield.CheckContext): Simplify.
600 (Yield.Resolve): Use FlowBranching.AddResumePoint.
602 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
604 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
605 argument to an ExitStatement.
606 (FlowBranchingException): Refactor saved origins code.
607 * statement.cs (ExitStatement): Update to cahges.
608 * iterator.cs (YieldBreak): Likewise.
610 * statement.cs (ResumableStatement): New. Common base class for
611 YieldReturn and ExceptionStatement.
612 (ExitStatement): New. Common base class for Return and YieldBreak.
613 (Return): Update to changes.
614 * iterator.cs (YieldBreak): Likewise.
615 * lambda.cs (ContextualReturn): Likewise.
618 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
619 emit a meaningful error message.
622 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
623 (VariableInfo.SetAssigned): Set it.
624 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
625 determine if CS0219 or CS0168 is appropriate. Don't use
626 flow-analysis information.
627 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
628 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
629 (EmitContext.EndFlowBranching): ... this.
631 2008-04-03 Marek Safar <marek.safar@gmail.com>
633 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
635 2008-04-03 Marek Safar <marek.safar@gmail.com>
637 A fix for bug #376508
638 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
639 ImplicitConversionExists.
641 2008-04-03 Marek Safar <marek.safar@gmail.com>
643 * expression.cs (Binary): Added remaining binary operators to expression
646 * nullable.cs: Optimize shift with null argument.
648 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
650 Fix minor IL regression
651 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
652 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
653 * cs-parser.jay (try_statement): Update to changes.
655 * statement.cs (TryFinally.need_exc_block): Delete.
656 (TryFinally): Update to changes.
658 Now all ExceptionStatements are unconditional
659 * statement.cs (CollectionForeach.DisposableWrapper): New.
660 Extract out the try/finally code into a new wrapper.
661 (CollectionForeach.Resolve): Use it to simplify the code.
663 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
665 Start at simplifying ExceptionStatement semantics a bit
666 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
667 * cs-parser.jay (try_statement): Update to changes.
668 (opt_catch_clauses): Remove.
669 * flowanalysis.cs: Update to changes.
670 (FlowBranching.BranchingType.TryCatch): New.
671 (FlowBranchingTryCatch): New.
673 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
674 (FlowBranching.CreateBranching): Update to changes.
675 (FlowBranchingBlock.AddSibling): Add sanity check.
676 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
679 * iterators.cs (Iterator.MarkFinally): Remove.
680 * statement.cs (ExceptionStatement): Update to changes.
682 Add support for skipping over finally blocks at runtime. First
683 in a series to fix #324708
684 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
685 (Iterator.EmitMoveNext): Initialize it.
686 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
687 branch over the body of the 'finally' clause.
689 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
691 Avoid lopsided use of Foo/DoFoo names
692 * statement.cs (ExpressionStatement.EmitFinallyBody):
693 Rename from EmitFinally.
694 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
695 * iterator.cs: Update to changes.
697 2008-04-02 Marek Safar <marek.safar@gmail.com>
699 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
700 based on UserOperatorCall. More binary nullable operators clean up.
702 2008-04-02 Martin Baulig <martin@ximian.com>
704 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
706 2008-04-02 Marek Safar <marek.safar@gmail.com>
708 * nullable.cs: Merge user and empty conversions when lifting expression
711 * expression.cs (StringConcat): Implemented expression tree representation.
713 2008-04-01 Marek Safar <marek.safar@gmail.com>
715 * nullable.cs: When lifting null literal and a user operator exists, no call
718 2008-04-01 Marek Safar <marek.safar@gmail.com>
720 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
723 2008-04-01 Marek Safar <marek.safar@gmail.com>
725 * nullable.cs, expression.cs: Use namespace instead heavily nested
726 monster abstract class.
728 2008-04-01 Marek Safar <marek.safar@gmail.com>
730 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
731 lifting of null literal and user operators. Clean up of some temporary
734 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
736 Fix #368224, test-629.cs
737 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
738 if it crossed an unwind-protect boundary.
739 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
740 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
741 inside an unwind-protected region.
742 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
743 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
744 'leave' instead of a 'br' if unwind-protected.
745 (Iterator.EmitYieldBreak): Likewise.
747 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
749 * driver.cs: Only define versioninfo resources if no win32 resource
752 2008-03-28 Marek Safar <marek.safar@gmail.com>
754 A fix for bug #372375
755 * convert.cs: Fixed boxing of nullable types.
757 2008-03-28 Marek Safar <marek.safar@gmail.com>
759 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
762 2008-03-28 Marek Safar <marek.safar@gmail.com>
764 A fix for bug #374619
765 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
767 2008-03-27 Marek Safar <marek.safar@gmail.com>
769 * lambda.cs: Check return type only for invocation.
771 2008-03-27 Marek Safar <marek.safar@gmail.com>
773 A fix for bug #374214
774 * ecore.cs: Correctly report argument type mismatch.
776 2008-03-27 Marek Safar <marek.safar@gmail.com>
778 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
779 and not rely on broken IsEnum.
781 2008-03-27 Marek Safar <marek.safar@gmail.com>
783 * nullable.cs: New file, extracted from generic.cs.
785 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
787 2008-03-27 Marek Safar <marek.safar@gmail.com>
789 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
790 predefined comparison operators and null literals.
792 * report.cs: New warning ID.
794 2008-03-25 Marek Safar <marek.safar@gmail.com>
796 A fix for bug #370577
797 * lambda.cs: Check return type too.
799 2008-03-25 Marek Safar <marek.safar@gmail.com>
801 A fix for bug #372846
802 * class.cs: Automatic properties can be declared as unsafe.
804 2008-03-20 Marek Safar <marek.safar@gmail.com>
806 * location.cs: Use string based concatenation.
808 * expression.cs: LiftedBinaryOperator is gmcs only.
810 2008-03-20 Marek Safar <marek.safar@gmail.com>
812 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
813 conversions rules and expression trees.
815 2008-03-19 Marek Safar <marek.safar@gmail.com>
817 * delegate.cs: Use extension method source as delegate target.
819 2008-03-19 Marek Safar <marek.safar@gmail.com>
821 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
822 binary operations to be purely based on binary operations and optimized
823 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
824 and other ET refactoring.
826 * typemanager.cs: Fixed warning.
828 2008-03-17 Marek Safar <marek.safar@gmail.com>
830 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
832 * symbolwriter.cs: Fixed.
834 2008-03-17 Marek Safar <marek.safar@gmail.com>
836 * anonymous.cs, driver.cs: Reset anonymous types counters.
838 2008-03-17 Marek Safar <marek.safar@gmail.com>
840 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
842 * class.cs: Use fullname for all type member definitions.
844 2008-02-19 Martin Baulig <martin@ximian.com>
847 (IMethodData.EmitExtraSymbolInfo): New interface method.
848 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
849 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
850 interface method here as an empty public virtual method.
853 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
854 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
855 CodeGen.SymbolWriter.SetRealMethodName().
857 2008-02-18 Martin Baulig <martin@ximian.com>
860 (ScopeInfo.EmitType): Override this and emit debugging
861 information for captured variables.
862 (RootScopeInfo.EmitType): Override this and emit symbol
863 information for a captured `this'.
865 2008-02-15 Martin Baulig <martin@ximian.com>
867 * iterators.cs: Emit debugging info.
870 (EmitContext.Flags): Add `OmitDebuggingInfo'.
871 (EmitContext.OmitDebuggingInfo): New public property.
874 (While): Override Emit() and don't emit symbol info there; do it
875 inside DoEmit() instead.
876 (Block.Emit): Omit symbol information while emitting the scope
877 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
879 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
880 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
881 .ctor to make `IsIterator' work.
883 2008-03-14 Martin Baulig <martin@ximian.com>
885 * symbolwriter.cs: Added the new symbol writer function from the
886 debugger's `terrania' branch; temporarily enclose them inside
887 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
890 2008-03-14 Martin Baulig <martin@ximian.com>
893 (SymbolWriter): Make this a public static class.
896 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
897 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
899 2008-03-14 Marek Safar <marek.safar@gmail.com>
901 A fix for bug #370577
902 * statement.cs, lambda.cs: Added extra limitations when dealing with void
905 2008-03-14 Marek Safar <marek.safar@gmail.com>
907 * typemanager.cs (CSharpName): Made 250 times faster.
909 2008-03-13 Marek Safar <marek.safar@gmail.com>
911 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
913 2008-03-12 Marek Safar <marek.safar@gmail.com>
915 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
916 crash when predefined field does not exist.
918 2008-03-12 Marek Safar <marek.safar@gmail.com>
920 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
922 2008-03-12 Marek Safar <marek.safar@gmail.com>
924 * class.cs (FixedField): Don't crash when contructors are missing.
926 2008-03-11 Marek Safar <marek.safar@gmail.com>
928 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
929 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
930 check internal types accessibility for internal and external types.
931 Replaced EnumToUnderlying by GetEnumUnderlyingType.
933 2008-03-11 Marek Safar <marek.safar@gmail.com>
935 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
936 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
937 attribute.cs, statement: Use corect instance of predefined types (work
940 2008-03-07 Marek Safar <marek.safar@gmail.com>
942 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
944 2008-03-07 Marek Safar <marek.safar@gmail.com>
946 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
947 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
948 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
949 predefined types clean up, delayed predefined types members initialization
950 (work related to #364674).
952 2008-03-05 Marek Safar <marek.safar@gmail.com>
954 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
956 2008-03-05 Marek Safar <marek.safar@gmail.com>
958 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
959 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
960 predefined types clean up (work related to #364674).
962 2008-03-04 Marek Safar <marek.safar@gmail.com>
964 * ecore.cs: Print an error message instead of throwing exception.
966 2008-03-04 Marek Safar <marek.safar@gmail.com>
968 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
969 expression.cs, statement.cs: Unififed null literal representation.
971 2008-03-03 Marek Safar <marek.safar@gmail.com>
973 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
974 expression.cs: Refactored binary operators resolve phase and improved speed.
975 The nullable code is still missing and won't work correctly, more fixes
978 It also fixes #323726, #324312, #324248, and many other unreported issues.
980 2008-02-29 Zoltan Varga <vargaz@gmail.com>
982 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
985 2008-02-27 Marek Safar <marek.safar@gmail.com>
987 * ecore.cs: Clean-up and split BetterConversion.
989 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
992 * enum.cs (EnumMember.Value): Only access 'value' if
993 ResolveValue says it's ok.
994 (EnumMember.DoResolveValue): Don't set prev_member.value.
995 (Enum.GetDefinition): Reverse arguments of Equals --
996 EnumMember.Value can return 'null'.
998 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
1000 2008-02-22 Marek Safar <marek.safar@gmail.com>
1002 * generic.cs, expression.cs: More ongoing work on expression trees.
1004 2008-02-21 Marek Safar <marek.safar@gmail.com>
1006 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
1007 handle missing matches when mutiple operators exist.
1009 2008-02-20 Marek Safar <marek.safar@gmail.com>
1011 A fix for bug #363218
1012 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
1015 2008-02-20 Marek Safar <marek.safar@gmail.com>
1017 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
1018 update. This time to deal correctly with SideEffectConstant expression used
1019 as an argument for another constant folding.
1021 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
1023 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
1026 2008-02-19 Marek Safar <marek.safar@gmail.com>
1028 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
1030 2008-02-19 Marek Safar <marek.safar@gmail.com>
1032 A fix for bug #328136
1033 * expression.cs: Do not fold immediately LogicalAnd operators when the left
1034 side is a false constant, because we still need to evaluate the right-hand
1037 * statement.cs (If): Emit two types of boolean constants (simple constant,
1038 side-effect constant).
1040 2008-02-19 Marek Safar <marek.safar@gmail.com>
1042 * constant.cs (SideEffectConstant): Don't emit boolean constant.
1044 * expression.cs: Fold immediately LogicalAnd operators when both sides are
1047 2008-02-18 Marek Safar <marek.safar@gmail.com>
1049 A fix for bug #361457
1050 * ecore.cs (IsApplicable): Params methods have lower priority.
1052 * support.cs: Return correct parameter modifier for params types.
1054 2008-02-18 Marek Safar <marek.safar@gmail.com>
1056 * generic.cs (TypeParameter): Cache attribute target name.
1058 * support.cs: Removed unused variable.
1060 * typemanager.cs: Removed debugging leftover.
1062 * ecore.cs: Use local type instead of a property;
1064 * class.cs (VerifyMembers): Consider also parent to test whether type member
1067 * expression.cs (FullMethodDesc): Removed.
1069 * attribute.cs (IsValidArgumentType): Made static.
1071 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
1073 Cleanup to be more readable.
1074 * Makefile (GMCS_PROFILE): Remove.
1075 (COMPILER_NAME): New helper.
1077 2008-02-15 Miguel de Icaza <miguel@novell.com>
1079 * cs-tokenizer.cs: if a conditional expression happens inside a
1080 (...) this also means that we do not need to de-ambiguate between
1081 an parenthesized expression and a cast.
1085 * constant.cs (SideEffectConstant): a constant value that happens
1086 to have a side effect.
1088 Fixes the build regressions introduced by the fix for #359789
1090 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
1092 * expression.cs (Conditional.Emit): when emitting the ternary
1093 operator, use local variables to generate code verifiable code.
1095 The verifier cannot infer that the type on stack before the
1096 stloc.0 is executed is of type ParentB. This happens because the
1097 stack merge algorithm uses only parent types when deciding which
1098 is the common type. This is described in Part III 1.8.1.3 of ECMA
1101 This code compiled with mcs is not verifiable under MS. The MS
1102 verifier picks the first common interface of Foo and Bar, which is
1103 wrong, but doesn't use a full join type of the 2 interfaces.
1105 CSC uses a clever hack to compile such code in a verifiable
1106 way. It stores the intermediate values in a local variable with
1111 2008-02-14 Miguel de Icaza <miguel@novell.com>
1113 * expression.cs: Do not fold BitwiseAnd operators when the left
1114 side is a false constant, because we still need to evaluate the
1119 * support.cs: Instead of throwing an InternalErrorException when
1120 the position of the stream is outside the boundary of our buffer,
1121 reset the state of the reader, and restart the reading from the
1122 beginning of the file.
1124 2008-02-14 Marek Safar <marek.safar@gmail.com>
1126 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
1128 2008-02-14 Marek Safar <marek.safar@gmail.com>
1130 A fix for bug #361686
1131 * decl.cs: A protected types used inside a private class which parents
1132 derives from the protected class are accessible.
1134 2008-02-13 Marek Safar <marek.safar@gmail.com>
1136 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
1137 the parameterless constructor.
1139 2008-02-13 Marek Safar <marek.safar@gmail.com>
1141 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
1142 lookup methods to use standard member cache when doing member lookup.
1144 2008-02-12 Marek Safar <marek.safar@gmail.com>
1146 * driver.cs: Don't report full path for referenced module as assembly error.
1148 2008-02-12 Marek Safar <marek.safar@gmail.com>
1150 * Makefile: Fixed `qh' target to work on all machines.
1152 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
1153 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
1154 and HasElementType with TypeManager implementation.
1156 2008-02-08 Marek Safar <marek.safar@gmail.com>
1158 A fix for bugs #325134, #359749
1159 * expression.cs, ecore.cs: Try to resolve an extension method even if the
1160 first binds point to non-method member expression.
1162 2008-02-08 Marek Safar <marek.safar@gmail.com>
1164 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
1166 2008-02-08 Marek Safar <marek.safar@gmail.com>
1168 A fix for bugs #321394, #323028
1169 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
1170 Reworked naive IsAccessibleAs implementation to handle nested types.
1172 2008-02-05 Jb Evain <jbevain@novell.com>
1174 * class.cs: use generic type comparison for parameters
1177 2008-02-05 Marek Safar <marek.safar@gmail.com>
1179 A fix for bug #325372
1180 * class.cs: Use generic type comparison when testing method signatures.
1182 2008-02-05 Marek Safar <marek.safar@gmail.com>
1184 A fix for bug #357047
1185 * ecore.cs: Applied C# 3.0 changes to better conversion.
1187 2008-02-05 Marek Safar <marek.safar@gmail.com>
1189 A fix for bug #358374
1190 * cs-parser.jay: Correctly set modifiers for all constructor types.
1192 2008-02-04 Marek Safar <marek.safar@gmail.com>
1194 A fix for bug #355251
1195 * generic.cs: Added base class constraint based type inference.
1197 2008-02-01 Marek Safar <marek.safar@gmail.com>
1199 A fix for bug #357255
1200 * decl.cs: One more missing visibility check.
1202 2008-02-01 Marek Safar <marek.safar@gmail.com>
1204 * support.cs: Fixed broken return.
1206 2008-01-25 Marek Safar <marek.safar@gmail.com>
1208 * report.cs: Correctly reset warnings count after probing.
1210 2008-01-25 Martin Baulig <martin@ximian.com>
1213 (NamespaceEntry.SymbolFileID): Make this work again after
1214 MemberName.ToString() is gone.
1216 2008-01-25 Marek Safar <marek.safar@gmail.com>
1218 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
1221 2008-01-25 Marek Safar <marek.safar@gmail.com>
1223 * generic.cs: Use full implicit conversion for type inference fixing.
1225 2008-01-24 Marek Safar <marek.safar@gmail.com>
1227 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
1228 Fixed user operator conversions.
1230 2008-01-24 Marek Safar <marek.safar@gmail.com>
1232 * generic.cs: Do nullable type to null comparison optimization during
1235 2008-01-24 Marek Safar <marek.safar@gmail.com>
1237 A fix for bug #355163
1238 * generic.cs: Enabled l-value resolve on nullable expressions.
1240 2008-01-24 Marek Safar <marek.safar@gmail.com>
1242 A fix for bug #353986
1243 * class.cs: Ingore static ctors with parameters for any further checks.
1245 2008-01-24 Marek Safar <marek.safar@gmail.com>
1247 A fix for bug #354310
1248 * namespace.cs: Removed redundant check.
1250 2008-01-24 Marek Safar <marek.safar@gmail.com>
1252 A fix for bug #354928
1253 * expression.cs: ElementInitializers can be resolved only once.
1255 2008-01-24 Marek Safar <marek.safar@gmail.com>
1257 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
1258 Condition expressions.
1260 2008-01-23 Marek Safar <marek.safar@gmail.com>
1262 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
1264 2008-01-22 Marek Safar <marek.safar@gmail.com>
1266 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
1269 * generic.cs: Implemented coalesce expression.
1271 2008-01-22 Marek Safar <marek.safar@gmail.com>
1273 A fix for bug #355145
1274 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
1275 expression tree type inference.
1277 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
1280 * expression.cs (Binary.IsUnsignedType): Fix typo.
1282 2008-01-22 Marek Safar <marek.safar@gmail.com>
1284 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
1286 2008-01-22 Marek Safar <marek.safar@gmail.com>
1288 A fix for bug #355161
1289 * ecore.cs, expression.cs: Wider range of extension method supported
1292 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
1294 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
1295 AssemblyBuilder to operate in compiler context. Fixes mcs part of
1298 2008-01-22 Marek Safar <marek.safar@gmail.com>
1300 A fix for bug #355148
1301 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
1303 2008-01-22 Miguel de Icaza <miguel@novell.com>
1305 * expression.cs (CreateExpressionTree): Add support for or and
1306 logical or, and indent following the coding conventions.
1308 * typemanager.cs (LinqExpression): renamed from
1309 ExpressionTreeManager, for a shorter name.
1311 Use TypeManager.CoreLookupType to lookup types from our core
1312 assemblies and turn those into "Type" variables.
1314 Consumers that previously used "Namespace" and "Type" from this
1315 class should instead use the TypeExpression which is a type that
1316 is fully resolved (without involving the regular C# resolution
1319 This typically looks like this:
1321 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
1322 new MemberAccess (texpr, name, type_arguments, loc)
1324 This avoids the problem in: #355178
1326 2008-01-21 Marek Safar <marek.safar@gmail.com>
1328 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
1329 feature in parser only as we do in other cases.
1331 2008-01-21 Marek Safar <marek.safar@gmail.com>
1333 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
1334 typemanager.cs: A refactoring of params arguments to reuse existing
1335 expressions (params -> array initializer) to emit params argument instead
1336 of specialized handling.
1337 It was required by expression tree implementation and it has other benefits
1338 as well, we now apply same optimization for params arguments as we do for
1341 2008-01-18 Marek Safar <marek.safar@gmail.com>
1343 A fix for bug #353526
1344 * generic.cs: A type inference of params arguments may not required any
1345 temporary array creation.
1347 2008-01-18 Marek Safar <marek.safar@gmail.com>
1349 A fix for bug #353534
1350 * generic.cs, ecore.cs, expression.cs: A method group type inference is
1351 supported for delegates only.
1353 2008-01-18 Marek Safar <marek.safar@gmail.com>
1355 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
1356 type for more than 1 candidates.
1358 2008-01-18 Marek Safar <marek.safar@gmail.com>
1360 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
1363 2008-01-16 Marek Safar <marek.safar@gmail.com>
1365 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
1366 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
1367 operator) expressions.
1369 2008-01-16 Zoltan Varga <vargaz@gmail.com>
1371 * statement.cs: Avoid declaring an IL variable for this_variable since it is
1372 not accessed from the generated IL.
1374 2008-01-14 Marek Safar <marek.safar@gmail.com>
1376 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
1377 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
1378 statement.cs: The first expression tree implementation drop, mostly
1379 infrastructure work.
1381 2008-01-14 Marek Safar <marek.safar@gmail.com>
1383 * ecore.cs (IsNestedChild): Refactored.
1385 2008-01-11 Marek Safar <marek.safar@gmail.com>
1387 * lambda.cs: Don't use a cast on unknown expression statement.
1389 2008-01-10 Geoff Norton <gnorton@novell.com>
1391 * cs-tokenizer.cs: One more token to distinguish between method and lambda
1394 2008-01-09 Marek Safar <marek.safar@gmail.com>
1396 * doc.cs: Report better /doc crash details.
1398 2008-01-09 Marek Safar <marek.safar@gmail.com>
1400 A fix for bug #352536
1401 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
1403 2008-01-08 Marek Safar <marek.safar@gmail.com>
1405 A fix for bug #352287
1406 * ecore.cs, expression.cs: Do `this' access checking in all member access
1409 2008-01-08 Marek Safar <marek.safar@gmail.com>
1411 * rootcontext.cs, driver.cs: Switch to linq mode by default.
1413 * report.cs: Reset message stacks.
1415 2008-01-08 Marek Safar <marek.safar@gmail.com>
1417 * generic.cs (InferInPhases): Correctly calculate params position.
1419 2008-01-08 Marek Safar <marek.safar@gmail.com>
1421 * cs-tokenizer.cs: No need to parse full string when parsing lambda
1424 2008-01-07 Marek Safar <marek.safar@gmail.com>
1426 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
1428 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
1430 * driver.cs: Updated --help option.
1432 2008-01-07 Marek Safar <marek.safar@gmail.com>
1434 * generic.cs (InferParamsTypeArguments): Removed.
1435 (InferInPhases): Add params type inference.
1436 (LowerBoundInference): Fixed scoring mechanism.
1438 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
1440 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
1442 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
1443 byte array for unsigned "baked" assemblies.
1445 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
1447 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
1448 array for assemblies that are not strongnamed.
1450 2008-01-04 Marek Safar <marek.safar@gmail.com>
1452 A fix for bug #351481
1453 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
1454 declaring type for nested generic types.
1456 2008-01-04 Marek Safar <marek.safar@gmail.com>
1458 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
1459 instead of ToString.
1461 2008-01-03 Marek Safar <marek.safar@gmail.com>
1463 A fix for bug #351047
1464 * expression.cs (Binary.ResolveOperator): Allow equality operators between
1465 null and structs only when equality and inequality operators are defined
1466 either as an user-operators or predefined operators.
1468 2008-01-03 Marek Safar <marek.safar@gmail.com>
1470 A fix for bug #351047
1471 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
1473 2008-01-03 Marek Safar <marek.safar@gmail.com>
1475 A fix for bug #351257
1476 * cs-tokenizer.cs: Advance line number for '\r' correctly.
1478 2008-01-03 Marek Safar <marek.safar@gmail.com>
1480 A fix for bug #351157
1481 * class.cs (Using): Fixed yet another broken cloning.
1483 (Block): Put back more sensible default value for statements.
1485 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
1487 * codegen.cs: Allow AssemblyVersion with only major version component.
1490 2007-12-29 Marek Safar <marek.safar@gmail.com>
1492 A fix for bug #324654
1493 * class.cs: Use FullName property as member name.
1495 2007-12-28 Marek Safar <marek.safar@gmail.com>
1497 A fix for bug #342117
1498 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
1499 constructor constraint.
1501 2007-12-28 Marek Safar <marek.safar@gmail.com>
1503 A fix for bug #338273
1504 * class.cs (ProbertyBase): Access modifier checks are required for overrides
1507 2007-12-28 Marek Safar <marek.safar@gmail.com>
1509 A fix for bug #350839
1510 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
1512 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1514 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1517 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1519 * statement.cs: Changed some Hashtables to use HybridDictionaries
1520 instead. It was observed that some HashTables only contained a few
1521 items in the vast majority of cases. Since HybridDictionary is
1522 more efficient on small sets (<10 elements), "known_variables"
1523 from class ExplicitBlock as well as "labels" and "constants " from
1524 class Block were changed to HybridDictionaries.
1526 Atsai results: (56216kb->54987kb)
1528 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
1531 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1533 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1536 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1538 * expression.cs: foreach loop to for loop, saved on allocation of
1539 enumerator (59333kb->59141kb)
1541 * statement.cs. Changed foreach loops to for loops, saved on
1542 allocation of enumerator (59141kb->59006kb)
1544 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
1545 when constructed with no specified capacity. This was causing a
1546 few ArrayLists to allocate more memory than they would potentially
1547 need in the Block class and MemberCache class. Setting the
1548 ArrayLists to construct with a capacity of 1 saves some
1549 memory. (56216kb->55585kb)
1551 2007-12-27 Marek Safar <marek.safar@gmail.com>
1553 A fix for bug #347189 (2nd issue)
1554 * expression.cs (MemberAccess): Nested type can be found in base non-generic
1557 2007-12-27 Miguel de Icaza <miguel@novell.com>
1559 * report.cs: Do not use colors if stdout and stderr are not a
1562 2007-12-27 Marek Safar <marek.safar@gmail.com>
1564 A fix for bug #346998
1565 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
1568 2007-12-27 Marek Safar <marek.safar@gmail.com>
1570 A fix for bug #343465
1571 * class.cs: Explicit method name for nested types uses dots only.
1573 2007-12-27 Marek Safar <marek.safar@gmail.com>
1575 A fix for bug #343707
1576 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
1578 2007-12-27 Marek Safar <marek.safar@gmail.com>
1580 * ecore.cs: Report type inference errors only when arguments count matches
1583 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
1585 * expression.cs, report.cs: New warning.
1587 * typemanager.cs: Catch anonymous method type too.
1589 2007-12-23 Marek Safar <marek.safar@gmail.com>
1591 A fix for bug #346379
1592 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
1594 2007-12-23 Marek Safar <marek.safar@gmail.com>
1596 A fix for bug #347359
1597 * expression.cs (Invocation): Don't resolve already resolved expression.
1599 2007-12-23 Marek Safar <marek.safar@gmail.com>
1601 A fix for bug #347189
1602 * class.cs (FixedField): Use non-dependent code only in the define phase.
1604 2007-12-23 Marek Safar <marek.safar@gmail.com>
1606 A fix for bug #348076
1607 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
1609 2007-12-22 Marek Safar <marek.safar@gmail.com>
1611 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
1612 discovered extension methods.
1614 2007-12-22 Marek Safar <marek.safar@gmail.com>
1616 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
1619 2007-12-21 Miguel de Icaza <miguel@novell.com>
1621 * report.cs (ErrorMessage): Add support for using colors on
1622 terminals that support it.
1624 2007-12-21 Marek Safar <marek.safar@gmail.com>
1626 * ecore.cs: Use information about expanded params for error reporting.
1628 2007-12-21 Marek Safar <marek.safar@gmail.com>
1630 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
1631 and logic for params overloads.
1633 2007-12-15 Miguel de Icaza <miguel@novell.com>
1635 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
1636 as this is also created from the parser. Fixes #349034
1638 2007-12-12 Miguel de Icaza <miguel@novell.com>
1640 * statement.cs (Throw.CloneTo): it is valid to have empty
1641 expressions for throw.
1643 2007-12-03 Marek Safar <marek.safar@gmail.com>
1645 * cs-parser.jay: Set delegate constraint parsing region correctly.
1647 2007-12-03 Marek Safar <marek.safar@gmail.com>
1649 A fix for bug #345467
1650 * typemanager.cs (IsEqual): Compare generic parameters position only.
1652 2007-11-28 Marek Safar <marek.safar@gmail.com>
1654 * expression.cs (BaseAccess): Type arguments can be null.
1656 2007-11-27 Raja R Harinath <harinath@gmail.com>
1658 * statement.cs (Block.Resolve): Ensure flow-branching tree is
1659 consistent even when an error has occured.
1660 (Switch.Resolve): Likewise.
1662 2007-11-22 Marek Safar <marek.safar@gmail.com>
1664 A fix for bug #334505
1665 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
1668 2007-11-22 Marek Safar <marek.safar@gmail.com>
1670 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
1671 refactorings required to resolve extension methods correctly when mixing
1672 generics and non-generics members.
1674 2007-11-20 Marek Safar <marek.safar@gmail.com>
1676 A fix for bug #342584
1677 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
1680 2007-11-19 Marek Safar <marek.safar@gmail.com>
1682 A fix for bug #342512
1683 * delegate.cs: Use delegate argument expression when is available. Don't
1684 emit virtual call when class is sealed.
1686 2007-11-16 Marek Safar <marek.safar@gmail.com>
1688 A fix for bug #325423
1689 * assign.cs (FieldInitializer): Use resolved expression for emit.
1691 * class.cs: Print less confusing error message.
1693 2007-11-16 Marek Safar <marek.safar@gmail.com>
1695 * cs-tokenizer.cs: Removed GMCS ifdefs.
1697 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
1700 * cs-parser.jay: Disabled nullable check.
1702 * generic-mcs: Copied more generic stuff.
1704 2007-11-16 Marek Safar <marek.safar@gmail.com>
1706 * gcs-parser.jay: Merged to cs-parser.jay.
1708 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
1709 * *.csproj, *.sources: Updated to use only jay parser file.
1711 2007-11-16 Marek Safar <marek.safar@gmail.com>
1713 * gcs-parser.jay: Added nullable and default expression feature checks.
1715 2007-11-16 Marek Safar <marek.safar@gmail.com>
1717 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
1718 it fixes many TODOs and hidden bugs.
1720 * expression: Removed duplicate error check.
1722 2007-11-15 Marek Safar <marek.safar@gmail.com>
1724 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
1725 implicitly type local variable only when it is used in a declaration.
1727 2007-11-15 Marek Safar <marek.safar@gmail.com>
1729 * attribute.cs: Use CS0612 for empty strings.
1731 2007-11-14 Marek Safar <marek.safar@gmail.com>
1733 * lambda.cs, statement.cs: Contextual return may act as a statement.
1735 2007-11-14 Marek Safar <marek.safar@gmail.com>
1737 A fix for a regression cause by #324222
1738 * class.cs: Don't report unused even when it implements an interface.
1740 2007-11-13 Marek Safar <marek.safar@gmail.com>
1742 A fix for bug #341205
1743 * ecore.cs, expression.cs: Method group expression cannot do static
1744 method access with an instance reference check before overloading takes
1747 2007-11-13 Marek Safar <marek.safar@gmail.com>
1749 A fix for bug #325359
1750 * class.cs: Use predictable name for automatically generated property.
1752 2007-11-12 Marek Safar <marek.safar@gmail.com>
1754 A fix for bug #324996
1755 * expression.cs (Is): Handle case where D is nullable and T is not
1758 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
1760 2007-11-12 Marek Safar <marek.safar@gmail.com>
1762 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
1763 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
1764 Flush small error reporting changes.
1766 2007-11-09 Marek Safar <marek.safar@gmail.com>
1768 A fix for bug #324996
1769 * expression.cs: Rewrote Is expression implementation to work with
1770 generics, nullable types, anonymous method. A const result expression
1771 uses existing infrastructure instead of custom not fully-featured one.
1773 2007-11-08 Marek Safar <marek.safar@gmail.com>
1775 A fix for bug #340202
1776 * class.cs: Consider generics for volatile field.
1778 2007-11-08 Marek Safar <marek.safar@gmail.com>
1780 A fix for bug #335594
1781 * expression.cs: Use conversion rules when handling string addition.
1783 2007-11-07 Marek Safar <marek.safar@gmail.com>
1785 A fix for bug #336651
1786 * expression.cs: Fixed a crash when probing is on.
1788 2007-11-07 Marek Safar <marek.safar@gmail.com>
1790 A fix for bug #324242
1791 * covert.cs: Added a conversion from any nullable-type with an
1792 underlying enum-type to the type System.Enum.
1794 2007-11-07 Marek Safar <marek.safar@gmail.com>
1796 A fix for bug #324222
1797 * class.cs: Report all non-used event fields.
1799 2007-11-07 Marek Safar <marek.safar@gmail.com>
1801 A fix for bug #325161
1802 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
1803 qualifier for generic types.
1805 2007-11-07 Marek Safar <marek.safar@gmail.com>
1807 A fix for bug #322971
1808 * expression.cs, ecore.cs: Added intermediate result value check for
1811 2007-11-07 Marek Safar <marek.safar@gmail.com>
1813 A fix for bug #324754
1814 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
1815 when it was requested.
1817 2007-11-07 Marek Safar <marek.safar@gmail.com>
1819 A fix for bug #325101
1820 * expression.cs: Do type not value comparison for `is' expression.
1822 2007-11-07 Marek Safar <marek.safar@gmail.com>
1824 A fix for bug #320236
1825 * convert.cs: Don't apply user conversion on underlying target type.
1827 2007-11-06 Marek Safar <marek.safar@gmail.com>
1829 * expression.cs: Don't use unresolved expression for error reporting.
1831 2007-11-06 Marek Safar <marek.safar@gmail.com>
1833 A fix for bugs #337712, #324490
1834 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
1835 overloading resolution too.
1837 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
1838 the process consistent and more robust.
1840 * expression.cs, linq.cs, report.cs: Update.
1842 2007-11-02 Marek Safar <marek.safar@gmail.com>
1844 A fix for bug #332909
1845 * attribute.cs: Resolve attributes in correct context using error
1848 * rootcontext.cs: Define Obsolete attribute members as core members.
1850 2007-11-02 Marek Safar <marek.safar@gmail.com>
1852 * statement.cs: Removed unused methods.
1854 2007-10-31 Wade Berrier <wberrier@novell.com>
1856 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
1857 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
1860 2007-10-31 Marek Safar <marek.safar@gmail.com>
1862 A fix for bug #338102
1863 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
1864 methods registered as non-generics.
1866 2007-10-31 Marek Safar <marek.safar@gmail.com>
1868 A fix for bugs #337712, #324490
1869 * delegate.cs: Delegate covariance and contravariance is not allowed for
1872 2007-10-31 Marek Safar <marek.safar@gmail.com>
1874 A fix for bug #337719
1875 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
1878 2007-10-30 Marek Safar <marek.safar@gmail.com>
1880 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
1882 2007-10-29 Marek Safar <marek.safar@gmail.com>
1884 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
1887 2007-10-29 Raja R Harinath <rharinath@novell.com>
1889 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
1891 2007-10-29 Marek Safar <marek.safar@gmail.com>
1893 A fix for bug #334652
1894 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
1895 extension methods when we have not found the best candidate in normal
1898 2007-10-27 Marek Safar <marek.safar@gmail.com>
1900 * AssemblyInfo.cs: Keep up-to-date.
1902 2007-10-27 Marek Safar <marek.safar@gmail.com>
1904 * Makefile: Fixed generics compiler name.
1906 2007-10-27 Marek Safar <marek.safar@gmail.com>
1908 * lambda.test: removed, lambda parsing is done differently.
1910 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
1912 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
1914 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
1916 2007-10-27 Marek Safar <marek.safar@gmail.com>
1918 * Makefile, *.sources : All C# compilers are in mcs folder.
1920 * *.cs: Use existing 2_1 define for smcs.
1922 2007-10-26 Marek Safar <marek.safar@gmail.com>
1924 A fix for bug #335847
1925 * assign.cs, expression.cs: Couple of changes to avoid creating a
1926 temporary variable for each object initializer assignment statement. It
1927 simplifies struct initialization too, otherwise two temporary variables
1929 Implemented optimization of redundant default element initializers.
1931 2007-10-25 Marek Safar <marek.safar@gmail.com>
1933 A fix for bug #336766
1934 * expression.cs (Class.CheckBase): Use generic name when method is
1937 2007-10-25 Marek Safar <marek.safar@gmail.com>
1939 A fix for bug #334737
1940 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
1941 variable and not variable argument for prepared copies.
1943 2007-10-24 Marek Safar <marek.safar@gmail.com>
1945 A fix for bug #325110
1946 * class.cs, expression.cs, attribute.cs: Use open generic method when
1947 checking conditional attribute.
1949 2007-10-24 Marek Safar <marek.safar@gmail.com>
1951 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
1952 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
1953 FeatureIsNotAvailable.
1955 2007-10-24 Marek Safar <marek.safar@gmail.com>
1957 ** C# 3.0 Partial methods
1959 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
1960 methods support. Because of member cache issue with generics only
1961 non-generics partial methods are fully supported.
1963 2007-10-23 Marek Safar <marek.safar@gmail.com>
1965 * class.cs, decl.cs: Rewrote member overloads check to cope with
1966 generics and to use member cache for member checking. It also improves
1967 performance and fixes remaining overloads issues.
1969 2007-10-20 Marek Safar <marek.safar@gmail.com>
1971 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
1972 roottypes.cs, typemanager.cs:
1974 A member cache creation logic changed to add members immediately and
1975 not rely on fallback. The member cache is now only prefered way
1976 how to access and find type declaration members. It saves 5 MB of memory
1977 during MWF compilation and makes code ready for more optimizations and
1978 clean-ups, it's also a pre-requirement for partial methods.
1980 2007-10-18 Raja R Harinath <harinath@gmail.com>
1982 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
1983 handling for generic parameters.
1985 2007-10-15 Marek Safar <marek.safar@gmail.com>
1987 * class.cs (FixedField): Removed redundant volatile check.
1989 2007-10-15 Marek Safar <marek.safar@gmail.com>
1991 * class.cs, decl.cs: Fixed overload members verification to do only one
1992 check per possible collision.
1994 2007-10-13 Marek Safar <marek.safar@gmail.com>
1996 A fix for bug #325478
1997 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
1998 and create only one disposable flags container.
2000 2007-10-12 Marek Safar <marek.safar@gmail.com>
2002 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
2003 * statement.cs (Fixed): Fixed variables cloning.
2005 2007-10-12 Marek Safar <marek.safar@gmail.com>
2007 A fix for bug #333342
2008 * class.cs (EventField): Don't mark value type event as synchronized.
2010 2007-10-12 Marek Safar <marek.safar@gmail.com>
2012 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
2013 inference to identify best candidate method correctly.
2014 (ProperyExpr): A range variable is read only and cannot be modified.
2016 2007-10-11 Marek Safar <marek.safar@gmail.com>
2018 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
2019 logic to identify best candidate method correctly.
2021 2007-10-11 Marek Safar <marek.safar@gmail.com>
2023 * location.cs (Equals, GetHashCode): Removed.
2025 2007-10-11 Marek Safar <marek.safar@gmail.com>
2027 * report.cs: Implemented message recorder. It is used mainly for lambda
2028 expressions to capture otherwise swallowed error messages.
2030 * anonymous.cs, lambda.cs.cs: Do full parameters check.
2032 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
2034 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
2036 * expression.cs (MemberAccess): Always report lookup failure.
2038 * location.cs: Implemented Equals, GetHashCode.
2040 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
2042 2007-10-10 Jb Evain <jbevain@novell.com>
2044 * codegen.cs: re-enable assembly version check.
2046 2007-10-09 Marek Safar <marek.safar@gmail.com>
2048 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
2051 * namespace.cs (UsingAlias): Do correct version check.
2053 2007-10-08 Marek Safar <marek.safar@gmail.com>
2055 * expresison.cs, ecore.cs: Issue extension method error message when
2058 * rootcontext.cs: Added ISO_2 compiler mode option.
2060 2007-10-08 Marek Safar <marek.safar@gmail.com>
2062 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
2065 2007-10-08 Marek Safar <marek.safar@gmail.com>
2067 * attribute.cs (GetString, GetBoolean): Work with both literal and
2070 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
2071 Moved method overload specific methods to MethodGroupExpr.
2073 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
2074 it should be less memory consuming.
2076 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
2078 * codegen.cs: remove the assembly version check until the buildbot is
2081 2007-10-07 Jb Evain <jbevain@novell.com>
2083 * attribute.cs (Attribute.GetString): if the value
2084 expression is a StringConstant, return its string value.
2086 2007-10-07 Jb Evain <jbevain@novell.com>
2088 * typemanager.cs: add `assembly_version_attribute_type`.
2089 * codegen.cs: on attribute emission, check that the
2090 AssemblyVersionAttribute doesn't overflow.
2092 2007-10-05 Marek Safar <marek.safar@gmail.com>
2094 A fix for bug #324677
2095 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
2096 parent container of a scope container with currently resolved one.
2098 2007-10-05 Marek Safar <marek.safar@gmail.com>
2100 A fix for bug #325534
2101 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
2104 2007-10-05 Marek Safar <marek.safar@gmail.com>
2106 A fix for bug #327504
2107 * class.cs (Operator.Define): Refactored implicit and explicit user
2108 operator conversion rules.
2110 2007-10-05 Marek Safar <marek.safar@gmail.com>
2112 A fix for bug #327520
2113 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
2115 2007-10-04 Marek Safar <marek.safar@gmail.com>
2117 A fix for bug #328022
2118 * class.cs (MethodData.Define): Use correct method to check whether
2119 a method implementents an accessor.
2121 2007-10-04 Marek Safar <marek.safar@gmail.com>
2123 A fix for bug #330069
2124 * statement.cs (Fixed.Resolve): Read the first array element only when
2125 an array is instantiated.
2127 2007-10-04 Marek Safar <marek.safar@gmail.com>
2129 * expression.cs, assign.cs, generics.cs: Print correct operator when
2130 compound assignment is used.
2132 2007-10-04 Marek Safar <marek.safar@gmail.com>
2134 A fix for bug #325841
2135 * expression.cs (ArrayAccess): Use full argument cloning only for
2136 string compound concatenation.
2138 2007-10-03 Marek Safar <marek.safar@gmail.com>
2140 A fix for bug #328774
2141 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
2143 (PropertyExpr.EmitAssign): Fixed string concatenation compound
2146 2007-10-03 Raja R Harinath <rharinath@novell.com>
2149 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
2150 Event accessibility checks here. Remove some bogus code that
2151 accidently made GenericMethods work.
2152 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
2154 2007-09-25 Marek Safar <marek.safar@gmail.com>
2156 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
2158 * statement.cs (Block): Refactored AddVariable to allow error handling
2161 * generic.cs: New stub.
2163 2007-09-23 Marek Safar <marek.safar@gmail.com>
2165 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
2168 2007-09-17 Marek Safar <marek.safar@gmail.com>
2170 * class.cs: Use partial container to record whether any partial part
2171 contains static field initializer and therefore default contructor has
2174 2007-09-14 Marek Safar <marek.safar@gmail.com>
2176 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
2177 mono-list when only one of two partial parts has defined accessibility
2180 2007-09-14 Marek Safar <marek.safar@gmail.com>
2182 A fix for bug #82845
2184 * class.cs (TypeContainer): Set correct resolve context for all field
2187 2007-09-13 Marek Safar <marek.safar@gmail.com>
2189 * assign.cs: Fixed a crash when field is resolved twice with an error.
2191 * codegen.cs: Changed InFieldInitializer to be flag.
2193 * anonymous.cs, ecore.cs, expression.cs: Update after
2194 IsInFieldInitializer rename.
2196 * const.cs: Removed unused parameter.
2198 * class.cs: Changed the way how we resolve and emit field initializers.
2199 The field initilizers have to have access to contructor block to emit
2200 compiler generated code.
2202 2007-09-13 Marek Safar <marek.safar@gmail.com>
2204 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
2205 generics use TypeContainer instead.
2207 2007-09-12 Marek Safar <marek.safar@gmail.com>
2209 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
2211 * lambda.cs (ResolveParameters): Use more powerful
2212 InflateGenericArgument.
2214 * parameters.cs: Better exception message.
2216 2007-09-10 Marek Safar <marek.safar@gmail.com>
2218 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
2219 correct expression block type.
2221 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
2223 * expression.cs (Invocation): Extracted method group resolve to
2226 2007-09-07 Marek Safar <marek.safar@gmail.com>
2228 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
2229 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
2231 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
2232 generic extension methods.
2234 2007-09-06 Marek Safar <marek.safar@gmail.com>
2236 A fix for bug #82676 (Do I get it right now?)
2237 * convert.cs (Binary.ResolveOperator): An interface is converted to the
2238 object before a standard conversion is applied.
2240 2007-09-06 Marek Safar <marek.safar@gmail.com>
2242 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
2245 2007-09-05 Marek Safar <marek.safar@gmail.com>
2247 A fix for bug #82676
2248 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
2249 non-generic interface types.
2251 2007-09-05 Marek Safar <marek.safar@gmail.com>
2253 A fix for bug #82690
2254 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
2256 2007-09-05 Marek Safar <marek.safar@gmail.com>
2258 A fix for bug #82571
2259 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
2260 modifier for container based methods.
2262 2007-09-05 Marek Safar <marek.safar@gmail.com>
2264 A fix for bug #82676
2265 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
2266 any interface-type T means to any of interface type T.
2268 2007-09-04 Marek Safar <marek.safar@gmail.com>
2270 * namespace.cs: We have 2 versions of System.Core assembly.
2272 2007-09-04 Marek Safar <marek.safar@gmail.com>
2274 A fix for bug #82652
2275 * class.cs (Class.GetClassBases): Compare types and not expressions.
2277 2007-09-04 Marek Safar <marek.safar@gmail.com>
2279 A fix for bug #82620
2280 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
2281 actually never worked before.
2282 (IndexerAccess): Emit prepared arguments before they are modified.
2284 2007-09-04 Marek Safar <marek.safar@gmail.com>
2286 A fix for bug #82563
2287 * assign.cs: Revert wrong fix.
2289 * expression.cs (VariableReference.EmitAssign): Handle ref reference
2291 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
2292 Instead of ldelema/stdind we have to use temporary variables to handle
2293 cases like String.Concat (params string[]).
2295 2007-08-31 Marek Safar <marek.safar@gmail.com>
2297 * class.cs: EmitAttributes to Emit rename.
2299 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
2301 (MemberCore.HasClsCompliantAttribute): Don't depend on
2302 GetClsCompliantAttributeValue execution.
2304 2007-08-31 Marek Safar <marek.safar@gmail.com>
2306 * anonymous.cs: Use shorter type prefix.
2308 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
2311 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
2312 variables when probing is on.
2314 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
2315 unresolved variables.
2316 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
2317 handle transparent identifiers.
2319 2007-08-26 Marek Safar <marek.safar@gmail.com>
2321 * attribute.cs (IsClsCompliant): Add nullable types test.
2323 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
2325 * doc.cs : catch other types of exception than XmlException to
2326 report CS1570. Fixed bug #82565.
2328 2007-08-23 Marek Safar <marek.safar@gmail.com>
2330 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
2331 The number of delegate parameters has to match.
2332 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
2335 2007-08-21 Marek Safar <marek.safar@gmail.com>
2337 * anonymous.cs (AnonymousMethod): Generate private anonymous method
2338 to fix problem with private arguments.
2340 2007-08-20 Marek Safar <marek.safar@gmail.com>
2342 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
2344 * decl.cs (MemberName): Ignore generic type with no generic arguments.
2346 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
2347 empty. Add cloning suport.
2349 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
2351 2007-08-20 Marek Safar <marek.safar@gmail.com>
2353 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
2354 to create EmptyCast. It handles EmptyConstantCast specialization for
2357 2007-08-18 Marek Safar <marek.safar@gmail.com>
2359 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
2360 (EmitArrayArgument): One routine for array arguments.
2361 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
2363 2007-08-17 Marek Safar <marek.safar@gmail.com>
2365 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
2367 2007-08-17 Marek Safar <marek.safar@gmail.com>
2369 * anonymous.cs: MemberLookupFinal update.
2371 * class.cs (ConstructorInitializer): Is expression based.
2373 * delegate.cs: MethodGroupExpr update.
2375 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
2377 (Error_MemberLookupFailed): Customizable error override.
2378 (MethodGroupExpr): Keep queried type for later usage.
2379 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
2382 * expression.cs: Error_MemberLookupFailed refactoring.
2383 (New.DoResolve): Resolve as much as possible.
2384 (ElementInitializer.Error_MemberLookupFailed): Object initializer
2385 customization for invalid member types.
2387 * statement.cs: MethodGroupExpr update.
2389 2007-08-16 Marek Safar <marek.safar@gmail.com>
2391 * modifier.cs (Check): Check all modifiers and not only accessibility
2394 2007-08-16 Marek Safar <marek.safar@gmail.com>
2396 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
2397 type and not an expression.
2399 2007-08-16 Marek Safar <marek.safar@gmail.com>
2401 * statement.cs (Catch.Clone): Type and variable can be null.
2403 2007-08-16 Marek Safar <marek.safar@gmail.com>
2405 A fix for bug #81979
2406 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
2407 I am really not sure whether this is the best fix.
2409 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
2412 2007-08-14 Marek Safar <marek.safar@gmail.com>
2414 ** C# 3.0 Object and collection initializers (major re-write)
2416 * assign.cs (DoResolve): Initializers are not assign related.
2418 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
2419 used during collection or object initialization.
2421 * expression.cs (Error_InvalidArguments): Add initializers specific
2422 messages. More will come later because it requires some general
2424 (New.DoResolve): Better error handling for unsafe types.
2425 (EmptyExpressionStatement): New class.
2426 (ElementInitializer): An object initializer expression.
2427 (CollectionElementInitializer): A collection initializer expression.
2428 (CollectionOrObjectInitializers): A block of object or collection
2430 (NewInitialize): New expression with element/object initializers.
2432 * statement.cs: Reverted object/collection initializer hacks.
2434 * typemanager.cs (CSharpName): Filter __arglist type.
2436 2007-08-09 Marek Safar <marek.safar@gmail.com>
2438 ** C# 3.0 Anonymous Types (update to the latest standard)
2440 * expression.cs (Binary.ResolveOperator): Threat all null based types
2442 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
2443 (AnonymousTypeParameter): Updated.
2445 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
2446 (AnonymousTypeClass): New anonymous type container.
2448 * class.cs (AddField): Return operation result.
2450 * generic.cs: Another empty TypeArguments overload.
2452 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
2453 are stored at top of normal hierarchy.
2455 * typemanager.cs (CSharpName): Filter anonymous types.
2457 2007-08-09 Marek Safar <marek.safar@gmail.com>
2459 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
2460 as single Concat call. How could we miss that :-(
2462 2007-08-08 Marek Safar <marek.safar@gmail.com>
2464 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
2466 2007-08-07 Miguel de Icaza <miguel@novell.com>
2468 * expression.cs: Fix the previous commit, the creation of the
2469 arguments array list needs also to be conditional on the arguments
2472 * class.cs: Add a little bit of help to help narrow down problems.
2474 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
2475 not try to copy in that case.
2477 * driver.cs: When building SMCS, include a new different set of
2478 default assemblies here. Do this here so we can control whether
2479 to include the default assemblies with /noconfig.
2481 2007-08-03 Marek Safar <marek.safar@gmail.com>
2483 A fix for bug #81979
2484 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
2487 2007-08-03 Marek Safar <marek.safar@gmail.com>
2489 A fix for bug #82300
2491 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
2492 we are in probing scope.
2494 2007-08-03 Marek Safar <marek.safar@gmail.com>
2496 A fix for bug #82301
2498 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
2499 (Statement.CloneTo): Clone and not map children blocks.
2501 2007-08-03 Marek Safar <marek.safar@gmail.com>
2503 A fix for bug #82299
2505 * expression.cs (LocalVariableReference.CloneTo): Remap local info
2508 * statement.cs (Statement.CloneTo): Clone variables before statements
2509 to allow remaping of local variables.
2511 2007-08-03 Marek Safar <marek.safar@gmail.com>
2513 A fix for bug #82296
2516 * report.cs: Log crash details for future clone problems.
2518 * statement.cs (Return.Clone): Don't clone non-existent expression.
2520 2007-08-03 Raja R Harinath <harinath@gmail.com>
2522 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
2523 (Class.AddBasesForPart): Move CS0537 check here from ...
2524 * cs-parser.jay (class_declaration): ... here. Move calling of
2525 'AddBasesForPart' to ...
2526 (class_bases): ... here.
2527 (struct_declaration, interface_declaration): Update to changes.
2529 2007-08-02 Marek Safar <marek.safar@gmail.com>
2531 A fix for bug #81923
2533 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
2534 conversion is allowed.
2536 2007-08-02 Marek Safar <marek.safar@gmail.com>
2538 A fix for bug #81564
2540 * ecore.cs (EventExpr): Add IsBase handling.
2542 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
2545 2007-08-02 Raja R Harinath <harinath@gmail.com>
2547 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
2548 * cs-parser.jay: Some whitespace cleanups.
2549 (current_delegate): New.
2551 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
2552 a dummy code block, and use 'type_name' instead of 'member_name'.
2553 (interface_declaration, class_declaration): Likewise.
2554 (delegate_declaration): Likewise. Rearrange slightly and use
2556 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
2557 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
2559 2007-08-02 Marek Safar <marek.safar@gmail.com>
2561 A fix for bug #82039
2563 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
2566 * typemanager.cs (CSharpName): Split to string overload.
2568 2007-08-02 Marek Safar <marek.safar@gmail.com>
2571 * report.cs: Updated warning CS0472.
2573 2007-08-01 Marek Safar <marek.safar@gmail.com>
2575 A fix for bug #82181
2577 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
2579 2007-08-01 Marek Safar <marek.safar@gmail.com>
2581 A fix for bug #82277
2582 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
2584 2007-08-01 Marek Safar <marek.safar@gmail.com>
2586 ** C# 3.0 Type Inference (major bits are working)
2588 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
2589 (.ImplicitStandardConversionExists): Uses compatible.
2590 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
2591 (.InferReturnType): New method.
2592 (.Compatible): Refactored.
2593 (.ResolveParameters): Uses factory to create resolved parameters.
2594 (.CompatibleMethod): Add probing mode support.
2595 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
2596 clearly distinguish between 2 different operations.
2597 (LambdaMethod): Moved to lambda.cs.
2598 (AnonymousMethod): Removed unused fields and methods.
2599 (AnonymousDelegate): Simplified.
2601 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
2603 * convert. cs (ImplicitConversionStandard): Compatible works differently.
2605 * delegate.cs (Delegate): New mehods to reduce code duplication.
2606 (.GetConstructor): New method.
2607 (.GetInvokeMethod): New method.
2608 (DelegateCreation): Updated.
2610 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
2612 (OverloadResolve): Made probing little bit faster.
2614 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
2617 * generic.cs (TypeInferenceContext): Dummy implementation.
2619 * iterators.cs: Updated after Resolve/Define rename.
2621 * lambda.cs (LambdaExpression)
2622 (.ResolveParameters): Handles both type of arguments and type inference too.
2624 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
2625 (InflateTypes): Updated.
2627 * support.cs (InflateTypes): Changed signature and updated.
2629 * typemanager.cs (LookupMemberCache): Better dynamic type check.
2630 (MemberLookup_FindMembers): More MS tricks.
2631 (GetParameterData): Ditto.
2632 (GetDelegateParameters): Uses quick path for dynamic types.
2634 2007-08-01 Marek Safar <marek.safar@gmail.com>
2636 * class.cs (MethodData.Define): EmitContext is required for generic stuff
2639 2007-07-31 Marek Safar <marek.safar@gmail.com>
2641 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
2644 2007-07-26 Jb Evain <jbevain@novell.com>
2646 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
2647 which takes a boolean 'report_errors', similar to the GetMethod.
2648 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
2649 in .net 2.1, do not report errors here.
2651 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
2652 System.Runtime.CompilerServices.RequiredAttributeAttribute and
2653 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
2656 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
2657 of the type InternalsVisibleToAttribute before the first call
2658 to CoreLookupType which is allowed to fail (third boolean parameter
2659 to true). Because, during the resolution for a type that is not
2660 immediately found, we try to check if the type is not defined in
2661 a friend assembly, and to do so, we need the
2662 InternalVisibleToAttribute.
2664 2007-07-23 Miguel de Icaza <miguel@novell.com>
2666 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
2667 feature that allows structs to be compared against null and inline
2668 the result as true or false.
2670 Notice that the same code is not permitted inside a generic block
2671 of code that would do:
2673 class Foo<T> where T : struct {
2680 It is only allowed if the type of T is not bound (no where
2681 clause). In my opinion, this CSC 2 behavior is broken but people
2682 seem to be using it (IronRuby does, a few bug reports on bugzilla
2683 have it and some people have complained about it).
2685 All of the users that depend on this behavior have code that is
2688 * report.cs (Warning, Error): make these take object arguments,
2689 not strings, as that allows us to take advantage of Format.
2691 2007-07-20 William Holmes <billholmes54@gmail.com>
2693 * decl.cs: Changed MemberName.CountTypeArguments to also check the
2694 Left member variable for the Count.
2695 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
2696 MemberName.CountTypeArguments to avoid a NRE.
2698 This code is contributed under the MIT X11 license
2700 2007-07-18 Marek Safar <marek.safar@gmail.com>
2702 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
2704 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2706 * doc.cs : generic method arguments are written as ``x while generic
2707 type arguments are `x. Combined with the previous change, fixed bug
2710 2007-07-18 Raja R Harinath <rharinath@novell.com>
2713 * expression.cs (Binary.ResolveOperator): When converting
2714 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
2716 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2718 * doc.cs : when T: or whatever x: is specified, it does not really
2719 check the doc comment's syntax correctness. Fixed bug #82006.
2721 2007-07-18 Marek Safar <marek.safar@gmail.com>
2723 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
2724 LambdaExpression better.
2726 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
2728 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
2730 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
2731 as it can be generated.
2733 * expression.cs (Invocation.Error_InvalidArguments): Show correct
2736 * lambda.cs (LambdaExpression): Refactored to share same code with
2737 AnonymousMethodExpression.
2739 2007-07-17 Marek Safar <marek.safar@gmail.com>
2741 * anonymous.cs (MakeName): Include host name for easier debugging.
2742 (LambdaMethod): New class for lambda spcecific stuff.
2744 * attribute.cs: Set EmitContext return type.
2746 * class.cs: Set EmitContext return type.
2748 * codegen.cs (EmitContext): Return type cannot be null to stop messing
2749 with null/void meaning.
2751 * iterators.cs (ContainerType): Implemented.
2753 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
2755 * statement.cs (Return): Updated to lambda expressions.
2756 (Block.CloneTo): Parent can be null.
2758 2007-07-13 Marek Safar <marek.safar@gmail.com>
2760 A fix for bug #81917
2761 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
2763 * class.cs (FixedField): Check whether field is in unsafe scope.
2765 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
2766 (FieldExpr.Emit): Fixed buffers cannot be volatile.
2768 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
2771 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
2773 2007-07-13 Marek Safar <marek.safar@gmail.com>
2775 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
2776 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
2779 2007-07-13 Marek Safar <marek.safar@gmail.com>
2781 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
2783 2007-07-13 Marek Safar <marek.safar@gmail.com>
2785 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
2786 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
2788 * codegen.cs(EmitContext): Add ProbingMode flag.
2790 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
2792 * driver.cs: For now set both warning values.
2794 * ecore.cs (SimpleName): Name is readonly.
2795 (MethodGroup.OverloadResolve): One quick path for probing.
2797 * expression.cs (Unary): Set Oper r/o.
2798 (Binary): Set Oper r/o.
2799 (ParameterReference): Set few instance variables as r/o.
2800 (ParameterReference.DoResolveBase): Don't capture aruments when
2802 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
2803 (Arglist): arguments are private.
2804 (SizeOf): type is private and r/o.
2805 (MemberAccess): arguments are private.
2807 * report.cs: Enhanced reporting on/off capabilities.
2809 * lambda.cs: Uses ec.IsInProbingMode.
2810 (ContextualReturn): Derives from return.
2812 * rootcontext.cs: For now set both warning values.
2814 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
2816 (Return.Resolve): Don't die immediately.
2817 (Block.Resolve): Speed-up probing.
2818 (Block.CloneTo): Clone only child blocks.
2820 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
2822 * iterators.cs: reverted Miguel's latest change (r81925) as it
2823 breaks the build in System.
2825 2007-07-13 Miguel de Icaza <miguel@novell.com>
2827 * iterators.cs (Yield.CheckContext): Check for the iterator type
2828 also here as we can call into Yield even in codepaths that are not
2830 (MethodOrOperator is the only path that was checked).
2832 In addition to the standard check, use a more specific check for
2833 constructors to report a more verbose error.
2835 2007-07-12 Miguel de Icaza <miguel@novell.com>
2837 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
2838 report the warning and continue
2840 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
2841 values on the stack on the call to Emit. Use EmitStatement if
2842 possible, or using Emit + Pop if not possible. Fixes #82064
2844 2007-07-12 Raja R Harinath <rharinath@novell.com>
2846 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
2847 avoid try...finally in some cases.
2849 2007-07-10 Marek Safar <marek.safar@gmail.com>
2851 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
2853 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
2854 instead of method. Re-use standard error handling.
2855 (ConstructorInitializer.Emit): Simplified.
2857 * delegate.cs: Updated after Invocation.EmitCall change.
2859 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
2860 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
2861 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
2862 method and don't permanently changing input arguments.
2863 (MethodGroupExpr): Introduced resolved best_candidate, when method group
2864 is resolved it has one of the candidates is the best one which is later
2865 used to emit. Removed a few unused method.
2866 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
2868 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
2869 (Binary.ResolveOperator): Ditto.
2870 (ConditionalLogicalOperator.DoResolve): Ditto.
2871 (Invocation): Uses method group.
2872 (Invocation.DoResolve): Simplified.
2873 (Invocation.EmitCall): Removed useless is_static.
2874 (Invocation.Emit): Delegate to method group.
2875 (Invocation.EmitStatement): Simplified.
2876 (New): Uses method group.
2877 (MemberAccess.DoResolve): Don't destroy original expression.
2879 * statement.cs (ForEach.Resolve): Use null for no method arguments.
2881 2007-07-04 Marek Safar <marek.safar@gmail.com>
2883 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
2886 * lambda.cs: Add custom error message type.
2888 2007-07-03 Marek Safar <marek.safar@gmail.com>
2890 * lambda.cs: Simplified little bit.
2892 * parameter.cs: Introduced ImplicitLambdaParameter.
2893 (Parameters.CreateFullyResolved): New factory instead of ctor.
2897 * delegate.cs: Updated parameter creation.
2899 2007-07-03 Marek Safar <marek.safar@gmail.com>
2901 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
2904 * generic.cs: Synchronized with gmcs.
2906 2007-07-03 Marek Safar <marek.safar@gmail.com>
2908 * class.cs (Indexer): Check return type as soon as possible.
2910 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
2913 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
2915 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
2917 * parameter.cs (Parameter): Use expression type when it is available.
2919 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
2920 method modifier for the first parameter only.
2922 2007-06-24 Marek Safar <marek.safar@gmail.com>
2924 A fix for bug #81938
2925 * typemanager.cs (ChangeType): Fixed couple of char conversions.
2927 * constant.cs: Tide up an exception message.
2929 2007-06-22 Marek Safar <marek.safar@gmail.com>
2931 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
2932 an uninitialized variable is used.
2934 * expression.cs (LocalVariableReference.DoResolve): Ditto.
2936 2007-06-22 Marek Safar <marek.safar@gmail.com>
2938 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
2939 not found error handling.
2941 * expression.cs (ArrayCreation): Removed redundant fields and little bit
2943 (ArrayCreation.ResolveArrayElement): To be ready to customization.
2944 (ArrayCreation.DoResolve): Simplified.
2945 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
2946 its own resolve process.
2947 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
2949 2007-06-20 Marek Safar <marek.safar@gmail.com>
2951 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
2954 2007-06-20 Marek Safar <marek.safar@gmail.com>
2956 * cs-tokenizer.cs: Removed var related stuff.
2958 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
2959 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
2960 a type and a keyword at same time.
2962 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
2965 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
2966 implicitly typed arrays, more changes will follow.
2968 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
2970 2007-06-19 Marek Safar <marek.safar@gmail.com>
2972 * ecore.cs (VarExpr): Removed Handled field.
2974 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
2975 build-in assign functionality.
2976 (ForEach.Resolve): Removed all implicitly typed local variable code and
2978 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
2979 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
2981 2007-06-18 Marek Safar <marek.safar@gmail.com>
2983 * assign.cs: Removed implicitly typed local variable check.
2985 * expression.cs (LocalVariableReference.DoResolve): Add check for self
2986 referencing implicitly typed local variable.
2987 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
2990 * statement.cs (Fixed): Removed unsupported implicitly typed local
2993 2007-06-15 Marek Safar <marek.safar@gmail.com>
2995 * decl.cs (MemberName): Moved all Unbound stuff to parser.
2997 2007-06-14 Marek Safar <marek.safar@gmail.com>
2999 A fix for bugs #81855 and #76274
3000 * attribute.cs (AttachTo): Always set owner for global attributes to
3003 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
3006 * cs-parser.jay: Assembly and module attributes must precede all other
3007 elements except using clauses and extern alias declarations.
3009 2007-06-13 Marek Safar <marek.safar@gmail.com>
3011 A fix for bug #81748
3013 * expression.cs: More checks for non ISO-1 features.
3015 2007-06-12 Marek Safar <marek.safar@gmail.com>
3017 A fix for bug #81807
3018 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
3019 present inside switch statement and it is required by nullable check.
3021 2007-06-12 Marek Safar <marek.safar@gmail.com>
3023 A fix for bug #81840
3024 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
3025 when type matching fails.
3027 * namespace.cs: Tiny error message change.
3029 2007-06-12 Marek Safar <marek.safar@gmail.com>
3031 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
3032 reporting. Added automatic property check.
3034 * class.cs: Updated after CheckAbstractAndExtern relocation.
3035 (AEventPropertyAccessor.GetSignatureForError): Customized.
3037 2007-06-11 Marek Safar <marek.safar@gmail.com>
3039 * class.cs (DefineBaseTypes): Base type can be undefined.
3041 * ecore.cs (TypeLookup): Minor refactoring.
3042 (DoResolveAsTypeStep): Removed redundant check.
3044 * namespace.cs (Lookup): Removed redundant check.
3046 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
3047 ResolveAsTypeTerminal step.
3048 (BootstrapCorlib_*): Simplified.
3049 (PopulateCoreType): Core types can be now external.
3051 2007-06-07 Marek Safar <marek.safar@gmail.com>
3053 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
3055 (InferTypeArguments): Infers anonymous expression type arguments.
3056 (Compatible): Split to Compatible and InferTypeArguments.
3058 * lambda.cs: Updated.
3060 2007-06-08 Marek Safar <marek.safar@gmail.com>
3062 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
3064 2007-06-07 Raja R Harinath <harinath@gmail.com>
3066 Fix #80477, cs0135-2.cs, cs0135-3.cs
3067 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
3068 names to the "known" variables list.
3069 (Block.CheckInvariantMeaningInBlock): Handle the fact the
3070 parameter names are also "known".
3071 (Block.CheckError136): Remove.
3072 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
3075 2007-06-07 Marek Safar <marek.safar@gmail.com>
3077 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
3079 2007-06-06 Marek Safar <marek.safar@gmail.com>
3081 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
3082 internal error not an user error.
3084 * expression.cs (IsApplicable): Refactored to make debugging easier.
3086 * support.cs: More tricks for non-mono runtimes.
3088 * typemanager.cs (CoreLookupType): Made public.
3089 (InitSystemCore): All linq specific stuff moved to linq.cs
3091 2007-06-05 Marek Safar <marek.safar@gmail.com>
3093 * typemanager.cs (CSharpSignature): One more missing build-in types
3095 More tricks for non-mono runtime.
3097 2007-06-05 Raja R Harinath <harinath@gmail.com>
3099 * statement.cs (Block.CheckError136_InParents): Remove.
3100 (Block.AddVariable): Use GetParameterInfo instead.
3101 (ToplevelBlock.ProcessArguments): Likewise.
3103 2007-06-04 Raja R Harinath <rharinath@novell.com>
3105 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
3107 (ToplevelBlock.GetParameterInfo): Split out of ...
3108 (ToplevelBlock.GetParameterRefernce): ... this.
3109 (ToplevelBlock.ParameterMap): Remove.
3110 * expression.cs (ParameterReference): Update to use
3111 ToplevelParameterInfo.
3113 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
3116 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
3117 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
3119 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
3120 (ToplevelBlock.ProcessParameters) ... here.
3121 (ToplevelBlock..ctor): Invoke it.
3123 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
3126 * statement.cs (IKnownVariable): New interface.
3127 (LocalInfo): Implement it.
3128 (ToplevelParameterInfo): New class.
3129 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
3130 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
3131 GetKnownVariableInfo.
3133 2007-06-03 Raja R Harinath <harinath@gmail.com>
3135 Partly speed up CS0136 error checks.
3136 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
3137 'recurse' parameter.
3138 (Block.DoCheckError136): Only check errors in parameters. Move
3139 local variable checks ...
3140 (Block.AddVariable): ... here, and ...
3141 (ToplevelBlock.ResolveMeta): ... here.
3143 2007-06-02 Raja R Harinath <harinath@gmail.com>
3145 * statement.cs (Block.IsChildOf): Remove.
3147 * statement.cs (Statement.Clone): Move special case code ...
3148 (Block.CloneTo): ... here.
3150 2007-05-29 Raja R Harinath <rharinath@novell.com>
3152 * statement.cs (ToplevelBlock.container): Remove field. It's
3153 redundant with 'Parent'.
3154 (ToplevelBlock.ContainerBlock): Remove accessor.
3155 (ToplevelBlock..ctor): Update to changes. Register anonymous
3156 child with parent here, ...
3157 * cs-parser.jay (end_anonymous): ... not here. Don't modify
3159 (start_anonymous): Don't save current_block.
3160 (top_current_block): Remove.
3162 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
3163 (Block.Resolve): Update to changes.
3164 (Block..ctor): Move setting of "correct" 'Toplevel'
3165 and 'Explicit' fields to ...
3166 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
3168 2007-05-27 Raja R Harinath <harinath@gmail.com>
3171 * statement.cs (Block.Implicit): Remove.
3172 (Block): Update to changes.
3173 * flowanalysis.cs: Likewise.
3175 Mildly speed up CheckInvariantMeaningInBlock
3176 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
3177 Recursively call AddKnownVariable to all enclosing blocks.
3178 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
3179 Remove recursive calls.
3180 (Block): Update to changes.
3182 New ExplicitBlock invariants
3183 * statement.cs (Block.Explicit): New field. It points to the
3184 immediately enclosing non-implicit block.
3185 (Block..ctor): Maintain the invariant.
3186 * cs-parser.jay: Take advantage of invariant.
3188 Introduce ExplicitBlock
3189 * statement.cs (ExplicitBlock): New.
3190 (ToplevelBlock): Derive from it.
3191 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
3193 (Block.Implicit): Update to changes.
3194 * cs-parser.jay: Update to changes.
3197 * codegen.cs (EmitContext.IsLastStatement): Remove.
3198 * statement.cs (Block.DoEmit): Update to changes.
3200 2007-05-25 Raja R Harinath <rharinath@novell.com>
3202 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
3203 modifying current_block directly.
3205 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
3207 * class.cs: Implemented automatic properties (C# 3.0)
3208 Thanks to Marek for the help.
3210 2007-05-23 Raja R Harinath <rharinath@novell.com>
3212 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
3213 variable as assigned, note also that all its components are
3215 (MyBitVector.SetRange): New. Function to set multiple bits to true.
3217 2007-05-19 Marek Safar <marek.safar@gmail.com>
3219 * anonymous.cs, class.cs: Emit Compiler generated attribute when
3220 member is marked as compiler generated.
3222 * decl.cs (MemberCore): Refactored ModFlags into property.
3224 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
3225 (Check): Check only accessibility modifiers.
3227 2007-05-18 Raja R Harinath <rharinath@novell.com>
3229 Track all assignable slots in one bit array
3230 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
3231 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
3232 logic from VariableMap constructor here. Use the same 'offset'
3233 variable that's later used for computing offsets of local
3235 * flowanalysis.cs (UsageVector.parameters): Remove.
3236 (UsageVector): Update to changes.
3237 (VariableMap): Remove.
3239 Avoid creating ParameterMap in every block
3240 * statement.cs (Block.ParameterMap): Move ...
3241 (ToplevelBlock.ParameterMap): ... here.
3242 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
3244 * flowanalysis.cs (FlowBranching.param_map): Remove.
3245 (FlowBranching.UsageVector): Update to changes.
3246 (FlowBranchingToplevel.CheckOutParameters): Likewise.
3248 * statement.cs (Block.CloneTo): Clone Toplevel field too.
3250 * expression.cs (ParameterReference): Distinguish between block
3251 where parameter was referenced and declared.
3253 2007-05-18 Marek Safar <marek.safar@gmail.com>
3255 * flowanalysis.cs, statement.cs: Put back improved error handling.
3257 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
3261 Imporved object and collection initialization (C# 3.0).
3263 2007-05-15 Marek Safar <marek.safar@gmail.com>
3265 A fix for bug #81380
3266 * expression.cs (Is.DoResolve): Only value types have constant `is'
3269 2007-05-15 Raja R Harinath <rharinath@novell.com>
3271 * statement.cs (ToplevelBlock.child): Remove.
3273 2007-05-15 Raja R Harinath <harinath@gmail.com>
3275 Rationalize ResolveMeta: refactoring
3276 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
3277 out constant handling code into ...
3278 (Block.DoResolveConstants): ... this.
3280 Rationalize ResolveMeta: kill local_map
3281 * statement.cs (Block.local_map, Block.LocalMap): Remove.
3282 (Block.AssignableSlots): New.
3283 (Block.ResolveMeta): Make protected. Don't create a VariableMap
3284 for locals -- move code from VariableMap here. Avoid unnecessary
3286 * flowanalysis.cs (FlowBranching.local_map): Remove.
3287 (FlowBranching..ctor): Use Block.AssignableSlots.
3288 (VariableMap): Remove unused constructors.
3290 2007-05-11 Raja R Harinath <rharinath@novell.com>
3292 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
3294 2007-05-11 Marek Safar <marek.safar@gmail.com>
3296 * typemanager.cs (IsFriendAssembly): Should not be called for building
3299 2007-05-09 Marek Safar <marek.safar@gmail.com>
3301 * literal.cs (NullConstant): Print null in all cases.
3303 * expression.cs (Binary.ResolveOperator): Implemented delegate
3304 comparison based on C# 2.0 changes.
3306 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
3308 This code is contributed under the MIT X11 license
3310 The following enables support for several C# 3.0 language features:
3312 * cs-tokenizer.cs: Added support for the "var" keyword.
3314 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
3315 Added VarExpr class to facilitate type inferencing.
3317 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
3318 to support anonymous types.
3320 * assign.cs: Added support for type inferencing and initialization.
3322 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
3324 * expression.cs: Added implicit array support to ArrayCreation.
3325 Added 5 types and 1 interface:
3327 IInitializable Implementing classes can inject initializing
3328 statements after object instantiation.
3330 Initializer Stores data for object initialization.
3332 AnonymousType An expression for anonymous types.
3334 AnonymousTypeParameter Stores data about an anonymous type's field.
3336 NewInitialize An expression for object initialization.
3338 CollectionInitialize An expression for collection initialization.
3340 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
3343 2007-05-06 Marek Safar <marek.safar@gmail.com>
3345 A fix for bug #81500
3346 * cs-tokenizer.cs: Add special handling for coalescing operator.
3348 2007-05-06 Marek Safar <marek.safar@gmail.com>
3350 A fix for bug #81529
3351 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
3352 its value from base class until it is redefined.
3354 2007-05-02 Raja R Harinath <rharinath@novell.com>
3356 Fix regression in cs0631-3.cs
3357 * cs-parser.jay (operator_declarator): Add opt_attributes to error
3358 fallback. Make error fallback catch more cases.
3360 2007-05-01 Miguel de Icaza <miguel@novell.com>
3362 * cs-parser.jay: Allow parameters in operator declarations to have
3365 2007-04-27 Miguel de Icaza <miguel@novell.com>
3367 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
3370 * lambda.cs (ContextualReturn.Resolve): An expression is valid
3371 inside the ContextualReturn, it does not have to be an
3372 ExpressionStatement.
3374 2007-04-24 Miguel de Icaza <miguel@novell.com>
3376 * lambda.cs (ContextualReturn.Resolve): if the return type is not
3379 2007-04-23 Miguel de Icaza <miguel@novell.com>
3381 * anonymous.cs (AnonymousContainer): split the virtual Resolve
3382 method in two methods: ResolveNoDefine and Resolve.
3384 ResolveNoDefine will stop just after ResolveTopBlock has been
3387 Resolve will then continue by creating a method and issuing the
3388 call to method.Define ().
3390 (AnonymousMethod): Split and implement the new Resolve and
3391 ResolveNoDefine as well.
3393 * lambda.cs (LambdaExpression): Split the anonymous method
3394 resolution code into a separate routine (CoreCompatibilityTest)
3395 from DoCompatibleTest.
3397 (LambdaExpression.TryBuild): New method, this method tries to
3398 build the LambdaExpression with the given set of types to be used
3399 as the types for the various parameters of the lambda expression.
3401 If the compilation succeed with the given types, the infered type
3402 of the Anonymous method is returned, otherwise null is returned.
3404 2007-04-23 Marek Safar <marek.safar@gmail.com>
3406 A fix for bug #81414
3407 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
3409 2007-04-22 Miguel de Icaza <miguel@novell.com>
3411 * cs-tokenizer.cs: Change various identifiers here from the
3412 camelCasing to the recommended Linux-like style for instance
3413 variables from the Coding Guidelines.
3415 2007-04-19 Martin Baulig <martin@ximian.com>
3418 (Convert.ImplicitReferenceConversionCore): Allow conversions from
3419 System.Enum to System.ValueType.
3421 2007-04-13 Martin Baulig <martin@ximian.com>
3423 Rewrote implicit reference conversions. We need to distinguish
3424 between implicit reference conversions (13.1.4) and implicit
3425 boxing conversions (13.1.5).
3427 According to the spec, there's an an implicit conversion
3428 "From a one-dimensional array-type S[] to IList<T> and base
3429 interfaces of this interface, provided there is an implicit
3430 reference conversion from S to T." Note that this does not
3431 include boxing conversions.
3434 (Convert.ImplicitTypeParameterBoxingConversion): New method.
3435 (Convert.ImplicitReferenceConversion): Split into
3436 ImplicitReferenceConversionCore() and
3437 ImplicitBoxingConversionExist().
3438 (Convert.ImplicitReferenceConversionExists): Use the new
3439 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
3441 2007-04-12 Martin Baulig <martin@ximian.com>
3443 * convert.cs (Convert.ImplicitReferenceConversion): Move the
3444 `TypeManager.null_type' checks up to the top of the method.
3446 2007-04-11 Marek Safar <marek.safar@gmail.com>
3448 A fix for bug #81350
3449 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
3452 2007-04-11 Martin Baulig <martin@ximian.com>
3454 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
3455 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
3456 to make this work for generic classes; fixes #79561.
3458 2007-04-11 Martin Baulig <martin@ximian.com>
3460 * expression.cs (As): Add support for nullable types; fixes #79371.
3462 2007-04-11 Martin Baulig <martin@ximian.com>
3464 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
3465 `type.FullName' is null; fixes #80243.
3467 2007-04-11 Martin Baulig <martin@ximian.com>
3469 * expression.cs (Invocation.IsApplicable): Don't modify the method
3470 if type inference succeeded, but the method was not applicable.
3473 2007-04-10 Marek Safar <marek.safar@gmail.com>
3475 A fix for bug #81324
3476 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
3477 internal and external namespaces containers.
3479 2007-04-10 Martin Baulig <martin@ximian.com>
3481 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
3482 TypeManager.DropGenericMethodArguments() so we also call
3483 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
3485 2007-04-10 Martin Baulig <martin@ximian.com>
3487 * iterators.cs (Iterator.CreateIterator): Don't crash if
3488 `method.ReturnType' is null. This happens if something went wrong
3489 while resolving that typ (we already reported an error in this case).
3491 2007-04-10 Martin Baulig <martin@ximian.com>
3493 * expression.cs (New.DoResolve): Don't call CheckComImport() on
3494 generic interfaces; report the CS0144 directly.
3496 2007-04-10 Martin Baulig <martin@ximian.com>
3498 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
3499 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
3501 2007-04-10 Martin Baulig <martin@ximian.com>
3503 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
3505 2007-04-09 Raja R Harinath <rharinath@novell.com>
3508 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
3509 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
3512 * statement.cs (For.Resolve): If resolution fails, use
3515 2007-04-08 Marek Safar <marek.safar@gmail.com>
3517 * anonymous.cs (MakeName): Make faster and zero-based.
3518 (VerifyExplicitParameterCompatibility): Back to mode where generic
3519 parameter is ignored.
3520 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
3522 * class.cs (EmitType): Method can emit another new method.
3524 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
3526 * driver.cs: Updated.
3528 * lambda.cs: Reuse predefined empty parameters.
3530 * parameter.cs: Updated
3532 * support.cs: Implemented InflateTypes.
3534 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
3535 (InitSystemCore): Introduced to isolate 3.0 dependencies.
3537 2007-04-03 Martin Baulig <martin@ximian.com>
3541 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
3542 version of TypeManager.IsOverride() which also works with generic
3545 2007-04-03 Martin Baulig <martin@ximian.com>
3550 (Convert.ExplicitReferenceConversion): We need to cast when
3551 converting from IList<T> to S[].
3553 2007-04-01 Marek Safar <marek.safar@gmail.com>
3555 * decl.cs (FindExtensionMethods): Consider all candidates with same name
3558 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
3560 2007-03-31 Marek Safar <marek.safar@gmail.com>
3562 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
3563 argument and return type inferring.
3565 * codegen.cs (InferReturnType): Flag whether return can be inferred.
3566 (ReturnType): Turned to property.
3568 * statement.cs (Return): Implemented return type inferring.
3570 * support.cs (ReflectionParameters): Use local types if possible.
3572 2007-03-30 Raja R Harinath <rharinath@novell.com>
3574 * flowanalysis.cs (FlowBranching.Reachability): Remove.
3575 (FlowBranching.UsageVector): Update to changes.
3577 Prepare to kill 'Reachability'
3578 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
3579 argument of constructor.
3581 2007-03-29 Raja R Harinath <rharinath@novell.com>
3583 Prepare to kill 'Reachability'
3584 * flowanalysis.cs (UsageVector.is_unreachable): New.
3585 (UsageVector): Update to maintain 'is_unreachable' in parallel to
3586 'reachability', and verify they're consistent.
3589 * expression.cs (New.EmitStatement): Handle type parameters here too.
3591 2007-03-29 Martin Baulig <martin@ximian.com>
3596 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
3597 CompilerGeneratedClass.
3598 (ScopeInfo.EmitScopeInstance): Make this protected.
3599 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
3600 `ec.CurrentAnonymousMethod.Scope == Scope'.
3602 * statement.cs (Block.ScopeInfo): Make this a property.
3604 2007-03-27 Raja R Harinath <harinath@gmail.com>
3606 Prepare to kill 'Reachability'
3607 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
3608 (FlowBranching.UsageVector.Reachability): Remove property.
3609 (FlowBranching.UsageVector.IsUnreachable): New property.
3610 (FlowBranching.UsageVector.ResetBarrier): New.
3611 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
3612 * codegen.cs, statement.cs: Update to changes.
3614 2007-03-27 Martin Baulig <martin@ximian.com>
3619 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
3622 2007-03-26 Raja R Harinath <rharinath@novell.com>
3624 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
3625 instead of TriState. Remove all mention of TriState.
3627 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
3628 replaced by a boolean. Add boolean 'is_unreachable' field, check
3629 and maintain invariants.
3631 2007-03-25 Marek Safar <marek.safar@gmail.com>
3633 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
3635 2007-03-25 Marek Safar <marek.safar@gmail.com>
3637 * expression.cs: Stop using obsolete 2.0 opcodes.
3639 2007-03-25 Marek Safar <marek.safar@gmail.com>
3641 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
3642 one of the latests Martin's fixes.
3644 2007-03-23 Miguel de Icaza <miguel@novell.com>
3646 * expression.cs: On BigEndian systems, swap the bytes, temporary
3647 solution until we get a new bitconverter class.
3649 2007-03-23 Martin Baulig <martin@ximian.com>
3653 * decl.cs (MemberCache.AddMembers): Add generic methods both as
3654 "Method" and "Method`1". Normally, a cache lookup is done on the
3655 "Method" form (ie. without the generic arity), but this one makes
3656 lookups on the full form work as well.
3658 2007-03-22 Raja R Harinath <rharinath@novell.com>
3660 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
3663 2007-03-20 Bill Holmes <billholmes54@gmail.com>
3665 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
3666 ordered_member_list, to TypeBuilder to store members to be defined
3667 in the order they were parsed in.
3668 - ordered_explicit_member_list contains all properties indexers
3669 and methods that are defined as explicit implementation of an
3670 interface or base class.
3671 - ordered_member_list contains all properties indexers and methods
3672 that are not defined as explicit implementation of an interface
3675 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
3676 functionality in these removed classes has been replaced with
3677 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
3678 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
3680 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
3681 to CheckForDuplications inside GetMethod and SetMethod Define Method
3682 to handle method property and indexer name conflicts.
3686 All code is contributed under the MIT/X11 license.
3688 2007-03-20 Martin Baulig <martin@ximian.com>
3690 * class.cs (TypeContainer.Interfaces): Removed; they're now
3691 included in `TypeContainer.Types'.
3693 2007-03-20 Martin Baulig <martin@ximian.com>
3695 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
3697 * class.cs (TypeContainer.CreateType): New public method. This is
3698 now called before DefineType() to create the TypeBuilders.
3699 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
3700 has already been created by CreateType().
3701 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
3702 don't resolve our base classes here; this has been moved into
3703 DefineBaseTypes(). We're now called from CreateType().
3704 (TypeContainer.DefineBaseTypes): New private method; resolve our
3705 base classes here. We're now called from DefineType().
3708 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
3709 our types first to create all the TypeBuilders. After that, call
3710 TypeContainer.DefineType() on all the types which'll resolve their
3711 base classes and setup the resolve order.
3713 2007-03-20 Martin Baulig <martin@ximian.com>
3715 * class.cs (TypeContainer.Enums): Removed; they're now included in
3716 `TypeContainer.Types'.
3718 2007-03-20 Martin Baulig <martin@ximian.com>
3721 (TypeContainer.DefineType): Don't call ResolveMembers() here.
3722 (TypeContainer.DoResolveMembers): Call DefineType() on our
3723 `compiler_generated' classes; moved here from DefineNestedTypes().
3726 (RootContext.ResolveTree): Call ResolveMembers() on all
3727 TypeContainer's in the `type_container_resolve_order'.
3729 2007-03-19 Marek Safar <marek.safar@gmail.com>
3731 * class.cs: Use corlib to handle InternalMethodImplAttribute.
3733 2007-03-17 Marek Safar <marek.safar@gmail.com>
3735 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
3736 implementation flags.
3738 2007-03-17 Marek Safar <marek.safar@gmail.com>
3740 * class.cs: More optimizations for type parameters.
3742 2007-03-15 Marek Safar <marek.safar@gmail.com>
3744 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
3746 * ecore.cs, parameter.cs: More common code for both corlibs.
3748 * typemanager.cs (IsGenericMethod): Simplified.
3750 2007-03-15 Raja R Harinath <rharinath@novell.com>
3752 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3754 * statement.cs, iterators.cs, lambda.cs: Update to changes.
3756 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
3757 unconditionally. Simplify explanation.
3758 (Try.Resolve, Using.Resolve): Likewise.
3760 2007-03-15 Martin Baulig <martin@ximian.com>
3764 * decl.cs (DeclSpace): If we're a partial class, use our
3765 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
3767 2007-03-15 Raja R Harinath <rharinath@novell.com>
3769 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3771 (FlowBranching.UsageVector): Update to changes.
3772 (FlowBranching.MergeSiblings): Likewise.
3773 * statement.cs: Likewise.
3775 2007-03-15 Martin Baulig <martin@ximian.com>
3780 (MemberCache): Added a special .ctor for type parameters.
3783 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
3786 2007-03-09 Martin Baulig <martin@ximian.com>
3788 * enum.cs (Enum): Make this a TypeContainer.
3789 (EnumMember): Derive from `Const'.
3792 (Const.DoResolveValue): New protected virtual method; move most of
3793 the functionality of ResolveValue() here so we can override it in
3795 (Const.CreateConstantReference): Make this virtual.
3797 * class.cs (Kind): Add `Kind.Enum'.
3798 (TypeContainer.Emit): Don't emit the enums here; they're already
3799 in the `RootContext.typecontainer_resolve_order'.
3801 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
3802 here; they're already in the `typecontainer_resolve_order'.
3804 * ecore.cs (EnumConstant.ConvertImplicitly): Add
3805 TypeManager.DropGenericTypeArguments().
3808 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
3809 (TypeManager.IsEnumType): Likewise.
3810 (TypeManager.EnumToUnderlying): Likewise.
3811 (TypeManager.IsEqual): Add support for enums.
3813 2007-03-12 Raja R Harinath <rharinath@novell.com>
3815 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
3816 DefaultParameterValueAttribute to be undefined, say if System.dll
3819 2007-03-11 Marek Safar <marek.safar@gmail.com>
3821 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
3824 2007-03-10 Marek Safar <marek.safar@gmail.com>
3826 * class.cs, parameter.cs: Unified parameters verification.
3828 2007-03-08 Martin Baulig <martin@ximian.com>
3830 * cs-parser.jay (constructor_header): Pass the location to the
3831 newly created TopLevelBlock.
3833 2007-03-07 Martin Baulig <martin@ximian.com>
3835 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
3837 2007-03-06 Miguel de Icaza <miguel@novell.com>
3839 * convert.cs (ExplicitReferenceConversionExists): Sync this method
3840 with the changes from David, fixes the build.
3842 2007-03-05 David Mitchell <dmitchell@logos.com>
3844 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
3845 and its base interfaces to a one-dimensional array type S[],
3846 provided there is an implicit or explicit reference conversion
3849 2007-03-03 Marek Safar <marek.safar@gmail.com>
3851 * cs-tokenizer.cs: Implemented basic linq grammar.
3853 * driver.cs: Set linq lang version on demand.
3855 2007-02-26 Marek Safar <marek.safar@gmail.com>
3857 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
3859 2007-02-25 Marek Safar <marek.safar@gmail.com>
3861 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
3864 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
3866 Check property and event extern attributes.
3868 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
3871 2007-02-24 Marek Safar <marek.safar@gmail.com>
3873 A fix for bug #80407
3874 * ecore.cs: Don't report ambiguity error when methods have same parent.
3876 2007-02-23 Marek Safar <marek.safar@gmail.com>
3878 A fix for bug #80878
3879 * class.cs, cs-parser.jay: Event property can host anonymous methods.
3881 2007-02-22 Marek Safar <marek.safar@gmail.com>
3883 * attribute.cs: Enable ExtensionAttribute presence test.
3885 2007-02-22 Marek Safar <marek.safar@gmail.com>
3887 * class.cs: Warn about missing GetHashCode only when Equals is override.
3889 * decl.cs: Check accessibility of type arguments.
3891 * typemanager.cs: Correctly report nullable array.
3893 2007-02-20 Marek Safar <marek.safar@gmail.com>
3895 * class.cs, report.cs: Capture more details when things go wrong.
3897 2007-02-20 Marek Safar <marek.safar@gmail.com>
3899 A fix for bug #80650
3900 * cs-parser.jay: Anonymous container starts at constructor declaration
3901 and not at block beginning because it has to be usable in constructor
3904 * statement.cs: Use context location and not block one for error reporting.
3906 2007-02-18 Marek Safar <marek.safar@gmail.com>
3908 A fix for bug #78712
3909 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
3912 2007-02-18 Marek Safar <marek.safar@gmail.com>
3914 A fix for bug #80493 by Atsushi Enomoto
3915 * cs-parser.jay: Ignore invalid attribute target.
3917 2007-02-18 Marek Safar <marek.safar@gmail.com>
3919 * cs-tokenizer.cs: Ignore '\0' as white space character.
3921 2007-02-17 Miguel de Icaza <miguel@novell.com>
3923 * cs-parser.jay: Add support for lambda expressions to the mcs
3926 * lambda.cs: Only clone when we are probing, not on the final call
3927 (Compatible is the final call).
3929 * statement.cs (CloneContext): Introduce class to provide block
3930 remapping during clone.
3932 All statements Clone themselves now.
3934 (Clone): special handling for blocks, when we clone a block, we
3935 register the block inside this routine, as children of the block
3936 might trigger a lookup.
3938 * expression.cs: Add support for CloneContext in all expressions.
3940 2007-02-17 Marek Safar <marek.safar@gmail.com>
3942 A fix for bug #80493
3943 * statement.cs: Report ambiguous warning when interfaces are not related.
3945 2007-02-15 Marek Safar <marek.safar@gmail.com>
3947 C# 3.0 extension methods.
3949 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
3950 cannot be used directly.
3952 * class.cs (Class.Emit): Emit extension attribute if any class method
3953 is extension method.
3954 (Method.Define): Add basic extension method validation conditions.
3955 (Method.Emit): Emit extension attribute for method.
3957 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
3958 extension method exists. Currently we follow same approach as Microsoft
3959 does, emit even if a method or a class are private but this can change
3962 * cs-parser.jay: Add handling of `this' keyword in method parameters
3965 * decl.cs (DeclSpace.IsStaticClass): New property.
3966 (MemberCache.FindExtensionMethods): Looks for extension methods with
3967 defined name and extension type.
3969 * doc.cs: Updated after OverloadResolve changes.
3971 * driver.cs: Add new soft reference to System.Core.dll.
3973 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
3974 (ExtensionMethodGroupExpr): Represents group of extension methods.
3976 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
3977 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
3978 to MethodGroupExpr and made non-static for easier customization.
3979 (Invocation.DoResolve): Add extension method lookup when no standard
3981 (MemberAccess.DoResolve): Try extension methods if no member exists.
3983 * modifiers.cs: Add METHOD_EXTENSION modifier.
3985 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
3986 as well as candidate extension type.
3987 (ComputeNamespaces): When assembly constains extension methods registers
3989 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
3990 extension method lookup.
3991 (Namespace.LookupExtensionMethod): Looks for extension method in this
3993 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
3994 find a method which matches name and extensionType.
3996 * parameter.cs (Parameter): Add This modifer.
3997 (HasExtensionMethodModifier): New property.
3998 (Resolve): Add extension parameter check.
3999 (ModFlags): turned to property to exclude this modifier as it is not real
4001 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
4003 * support.cs (ParameterData): Add ExtensionMethodType.
4004 (ReflectionParameters): Implemented ExtensionMethodType interface property.
4006 * typemanager.cs: Add type and ctor extension attribute type.
4008 2007-02-15 Miguel de Icaza <miguel@novell.com>
4010 * report.cs (DisableErrors, EnableErrors): used to prevent error
4011 output when we are "trying" to compile various methods with
4014 * ecore.cs (Expression): Add Clone method that calls the virtual
4015 CloneTo method. The current CloneTo method in Expression throws
4016 an exception so we can track down all the places where this must
4017 be implemented (not using abstract, because that would be a lot of
4018 up-front-work before we can start testing the implementation
4021 Important: we only need Clone capabilities for expressions created
4022 by the parser, as the expressions we will be cloning are
4023 expressions in the pre-resolved state. This vastly simplifies
4026 (SimpleName): Add CloneTo that does nothing.
4027 (EmptyCast): Add CloneTo.
4029 * expression.cs (Binary): Implement CloneTo.
4030 (Invocation.IsApplicable): Store the current ec in
4031 EmitContext.TempEc and restore it on return. This is used so we
4032 do not have to sprinkle hundres of methods with an extra
4033 EmitContext, we know that the only user is the lambda expression
4034 ImplicitConversionExists code.
4036 (Argument): Add Cloning capabilities.
4037 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
4038 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
4039 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
4040 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
4041 IndexerAccess): Add Clone capability.
4043 (LocalVariableReference, This): TODO: needs cloned Block mapping.
4045 (Argument): Add cloning capability.
4047 * assign.cs (Assign): Implement CloneTo.
4049 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
4051 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
4052 version by calling Convert with the EmitContext (that we are
4053 currently storing in ec, this is not great, but will do for now,
4054 to avoid passing EmitContext parameters to hundreds of functions
4055 that do not need them now).
4057 (SetExpression): Remove, it is not needed.
4059 (ContextualReturn): Implement CloneTo.
4061 * statement.cs (Statement): Implement cloning infrastructure,
4062 similar to expressions.
4064 (Block): Partial implementation of Clone for statements.
4066 (Return): Implement clone.
4068 * constant.cs (Constant.CloneTo): New method, does nothing.
4070 * codegen.cs (TempEc): Add a static EmitContext as a temporary
4071 solution, until we decide how to exactly do this.
4073 2007-02-14 Marek Safar <marek.safar@gmail.com>
4075 A fix for bug #80493
4076 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
4077 a property is override we need to use second accessor.
4079 2007-02-13 Marek Safar <marek.safar@gmail.com>
4081 A fix for bug #80418
4082 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
4085 2007-02-13 Marek Safar <marek.safar@gmail.com>
4087 Another fix for bug #80749
4088 * pending.cs: Abstract class has priority over interfaces.
4090 2007-02-13 Marek Safar <marek.safar@gmail.com>
4092 Another fix for bug #80749
4093 * pending.cs: Abstract class has priority over interfaces.
4095 2007-02-13 Marek Safar <marek.safar@gmail.com>
4097 Another fix for bug #80749
4098 * pending.cs: Abstract class has priority over interfaces.
4100 2007-02-13 Marek Safar <marek.safar@gmail.com>
4102 Another fix for bug #80749
4103 * pending.cs: Abstract class has priority over interfaces.
4105 2007-02-13 Marek Safar <marek.safar@gmail.com>
4107 * class.cs Better error message.
4109 * driver.cs: Add shorter versions of -optimize option.
4111 2007-02-13 Martin Baulig <martin@ximian.com>
4113 * class.cs (Constructor.Emit): Check the return value of
4114 ec.ResolveTopBlock() and return on error.
4116 2007-02-13 Raja R Harinath <rharinath@novell.com>
4118 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
4119 message to fix error message regression.
4121 2007-02-12 Marek Safar <marek.safar@gmail.com>
4123 * delegate.cs: Delegate creation expression cannot be of Nullable type.
4125 2007-02-12 Marek Safar <marek.safar@gmail.com>
4127 A fix for bug #80749
4128 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
4129 its parent container.
4131 * class.cs (DefineFieldInitializers): Each initializer can has different
4134 * const.cs: Updated.
4136 2007-02-11 Miguel de Icaza <miguel@novell.com>
4138 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
4139 now all the heavy lifting to check that embedded statements or
4140 expressions have the right form is done in the ContextualReturn.
4142 (ContextualReturn): New class.
4144 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
4145 method that can be invoked to report 201, so we do not replicate
4148 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
4150 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
4151 treating tabs as spaces.
4153 2007-02-09 Marek Safar <marek.safar@gmail.com>
4155 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
4156 * assign.cs: Use full implicit conversion for right side check.
4158 2007-02-09 Marek Safar <marek.safar@gmail.com>
4160 * statement.cs (Switch): Switch over boolean type is not standardized.
4162 2007-02-08 Marek Safar <marek.safar@gmail.com>
4164 A fix for bug #80755
4165 * decl.cs (FindBaseEvent): Don't use method cache for events.
4167 2007-02-07 Marek Safar <marek.safar@gmail.com>
4169 * cs-parser.jay: Better syntax error handling.
4171 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
4172 instead of underlying type value.
4174 2007-02-06 Marek Safar <marek.safar@gmail.com>
4176 * driver.cs: Check define identifier before is registered.
4178 * namespace.cs: Use existing error message.
4180 * report.cs: New warning.
4182 2007-02-06 Marek Safar <marek.safar@gmail.com>
4184 A fix for bug #80742
4185 * expression.cs: Delegate Invoke method can be called directly.
4187 2007-02-06 Marek Safar <marek.safar@gmail.com>
4189 A fix for bug #80676
4190 * class.cs (IsEntryPoint): The Main method can have params modifier.
4192 2007-02-04 Miguel de Icaza <miguel@novell.com>
4194 * parameter.cs (Parameter, Parameters): Add Clone method.
4196 * anonymous.cs (Compatible): Turn method into virtual method, so
4197 LambdaExpression can implement a different behavior.
4199 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
4200 out the basic checking here, so it can be used by
4203 * lambda.cs: Introduce "Compatible" function that will do the
4206 2007-02-02 Marek Safar <marek.safar@gmail.com>
4208 * attribute.cs: Unified one error message.
4210 * class.cs (Class): Use type attributes and not properties to test static
4212 (IsEntryPoint): Don's pass local variable.
4214 * convert.cs: Removed duplicate check.
4216 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
4218 * driver.cs: Don't crash when soft reference does not exist.
4220 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
4221 (UsingEntry): Removed redundant allocation.
4223 * parameter.cs: Add fast path for type parameters.
4225 * support.cs: Don't allocate attribute when it's not used.
4227 2007-01-30 Miguel de Icaza <miguel@novell.com>
4230 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
4231 this into a virtual method, so we can override it in LambdaExpression.
4233 * driver.cs: Improve diagnostics in case of failure.
4235 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
4236 write a function that is slightly more complex and that parses:
4238 type identifier [, type identifier]* )
4240 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
4243 (canEmpty ? i >= 0 : i > 0)
4245 2007-01-30 Raja R Harinath <rharinath@novell.com>
4247 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
4248 exception on possibly valid code.
4250 2007-01-29 Raja R Harinath <rharinath@novell.com>
4252 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
4254 (parse_opt_type_arguments): Remove. It's almost the same as
4256 (parse_namespace_or_typename): Use parse_less_than.
4258 2007-01-28 Miguel de Icaza <miguel@novell.com>
4260 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
4261 this bug took a few hours to find, because the state saved and
4262 restored by PushPosition and PopPosition was ignoring the state of
4263 parse_generic_less_than.
4265 I can also now remove the handling of OP_LT and OP_GT, this solves
4268 * cs-tokenizer.cs: store the location for the ARROW token, we use
4271 (PushPosition, PopPosition): save/restore also `current_token',
4272 restore `parse_generic_less_than' (was missing).
4274 (parse_opt_type_arguments): use parse_type, not
4275 parse_namespace_or_typename to parse types.
4277 * lambda.cs: Empty new file, will eventually have the lambda
4278 expression implementation.
4280 * lambda.test: used to test the internal tokenizer.
4282 * report.cs (FeatureIsNotISO1): Rename from
4283 FeatureIsNotStandardized, because it was about the language level
4284 (1 vs 2) it was not about standarization.
4286 (FeatureRequiresLINQ): New.
4288 * support.cs (SeekableStreamReader): Only require that the reader
4289 is a TextReader, not a StreamReader, so we can plug StringReader.
4291 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
4292 given position in the input stream the following tokens can be
4293 parsed as a type followed by an identifier.
4295 (is_punct): after a '(' if parse_type_and_parameter returns true,
4296 then return a special token OPEN_PARENS_LAMBDA which is used to
4297 avoid reduce/reduce errors in the grammar for the
4298 lambda_expression rules.
4300 (parse_type): implement a type parser inside the
4301 tokenizer, the parser only returns true or false depending on
4302 whether the input at a given position can be parsed as a type.
4304 (peek_token): new method used during type parsing.
4306 2007-01-28 Raja R Harinath <rharinath@novell.com>
4309 * anonymous.cs (ScopeInfo.InflateParameters): New.
4310 (AnonymousContainer.Resolve): Use it to redirect types of
4311 delegate parameters.
4313 2007-01-27 Raja R Harinath <rharinath@novell.com>
4316 * expression.cs (Error_InvalidArguments): Don't use two different
4317 messages for CS1503. Use ExtraInformation and
4318 SymbolRelatedToPreviousError instead.
4321 * decl.cs (DeclSpace.initialize_type_params): Don't access
4322 'type_params' of a partial class directly.
4324 2007-01-26 Miguel de Icaza <miguel@novell.com>
4326 * constant.cs: Removed a handful of out-of-range checks that were
4329 2007-01-25 Marek Safar <marek.safar@gmail.com>
4331 * expression.cs (CheckUselessComparison): Add additional check for char
4334 * namespace.cs: Fixed typo.
4336 2007-01-23 Miguel de Icaza <miguel@novell.com>
4338 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
4339 gone, instead we inline the test, preventing the needless casts to
4340 longs, ulongs and doubles for the parameters, avoiding calls to
4341 methods that overchecked stuff, and instead inlined things
4344 2007-01-20 Marek Safar <marek.safar@gmail.com>
4346 * cs-parser.jay: Better parameter error handling.
4348 2007-01-17 Marek Safar <marek.safar@gmail.com>
4350 A fix for bug #80368, #80522
4351 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
4352 whether array initializer contains constants only.
4353 (ArrayCreation.Emit): Use better formula to decide when
4354 are array initializers for static initialization.
4355 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
4356 have to emit even constants otherwise they are pre-initialized.
4358 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
4359 Raja R Harinath <rharinath@novell.com>
4361 Fix emit order of 'get' vs. 'set'.
4362 * support.cs (Accessors): New.
4363 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
4364 Note the order in which accessors are declared in the source.
4365 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
4366 Refactored from Property.Define and Indexer.Define.
4367 (PropertyBase.DefineAccessors): New helper that calls the above in
4368 appropriate order as noted by the parser.
4369 (Property.Define, Indexer.Define): Update to changes.
4370 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
4372 2007-01-17 Raja R Harinath <rharinath@novell.com>
4374 Fix cs0029-6.cs and gcs0029-2.cs (regression)
4375 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
4376 there's an implicit conversion from the current type to the target
4377 type before converting the underlying constant.
4379 2007-01-16 Marek Safar <marek.safar@gmail.com>
4381 * const.cs (ResolveValue): Updated after constant conversion was made more
4384 * constant.cs (GetAttributableValue): constant to object conversion is
4385 used for attributes only.
4386 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
4387 constant conversions.
4388 (LongConstant.ConvertImplicitly): Ditto.
4390 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
4391 (ImplicitConversionStandard): Handle constant conversion as extra step.
4392 It solves the issue when constant conversion was called indirectly like
4393 inside array initializer and constant folding was skipped.
4395 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
4398 * statement.cs(ImplicitConversionStandard): Updated after constant
4399 conversion was made more generic.
4401 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
4403 * expression.cs (As.DoResolve): Use GenericConstraints instead of
4404 Constraints, solves the problem where the compiler incorrectly
4405 reported that a type parameter was not constrained to a class (Bug
4408 2007-01-14 Marek Habersack <grendello@gmail.com>
4410 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
4412 2007-01-14 Marek Safar <marek.safar@gmail.com>
4414 A fix for bug #80368
4415 * assign.cs (FieldInitializer): New class implements field
4416 initializer statement.
4418 * attribute.cs: Update after FieldMember rename.
4420 * class.cs (PropertyBasedMember): New common class for property based
4422 (InterfaceMemberBase): New base class for all members which can be used as
4423 an interface members.
4424 (MethodCore): Moved really common code to InterfaceMemberBase.
4425 (Method.Define): Equal and GetHasCode detection is relevant for methods
4427 (MethodData.Define): Don't assume that public event implements an
4428 interface automatically.
4429 (MethodData.DefineMethodBuilder): Issue an error even if only extern
4431 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
4432 (FieldMember): Merged with FieldBase.
4433 (EventProperty.AEventPropertyAccessor): New specialization to check whether
4434 event extern modifier can be used.
4435 (EventField.EventFieldAccessor): Moved event field specific code here.
4436 (Event.AllowedModifiers): Even event can be extern.
4437 (Event.FindOutBaseMethod): New override specific to events.
4438 (Indexer.parameters): Reintroduce parameters because base class holds
4439 only properties common data.
4440 (Indexer.CheckForDuplications): Indexers are threated as methods so we
4441 need do extra parameters check.
4443 * const.cs: Update after FieldMember rename.
4445 * decl.cs (MemberCache.FindBaseEvent): New method.
4447 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
4448 to reflect that indexer is now derived from PropertyBased.
4450 * ecore.cs (GetMemberType): Made public.
4451 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
4454 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
4456 * typemanager.cs (CSharpSignature): Correctly print event accessors.
4457 (RegisterEvent): Removed.
4458 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
4459 (GetPrivateFieldOfEvent): Renamed to GetEventField.
4461 2007-01-11 Raja R Harinath <rharinath@novell.com>
4464 * statement.cs (CollectionForeach.TryType): Prefer generic
4465 GetEnumerator over non-generic variant. Fix code to follow comments.
4467 2007-01-09 Raja R Harinath <rharinath@novell.com>
4470 * support.cs (ReflectionParameter): Don't use an invalid index on
4471 the generic parameter data.
4473 2007-01-08 Miguel de Icaza <miguel@novell.com>
4475 * driver.cs: Just add a tiny bit of infrastructure.
4477 2007-01-02 Marek Safar <marek.safar@gmail.com>
4479 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
4480 where field type is struct from current assembly.
4482 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
4485 2007-01-02 Marek Safar <marek.safar@gmail.com>
4487 A fix for bug #80381
4488 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
4491 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
4493 (Namespace.LookupType): Always use core types from corlib when speficied.
4495 * report.cs: A new warning.
4497 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
4498 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
4499 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
4501 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
4502 (InitCoreTypes): Set expression type of object_type and value_type
4503 immediately after lookup.
4505 2007-01-01 Miguel de Icaza <miguel@novell.com>
4507 * cs-tokenizer.cs: Accept Pc class characters (Connector
4508 Punctuation) as valid identifiers. Fixes #78259
4510 * expression.cs (Invocation.DoResolve): Moved the check for the
4511 use of `this' for doing method calls to the Invocation resolution
4512 step, after overload resolution has taken place instead of doing
4513 the check at the low-level `This.DoResolve' level.
4515 The `This.DoResolve'(appens before overload resolution, so it has
4516 no way of knowing if the method that will be called will be
4517 instace or static, triggering an erroneous report for cs0188 (Bug
4520 We now do the check for instance method invocations after we know
4521 what method will be called.
4523 (This.CheckThisUsage): Move the actual use of this structure
4524 checking into its own method and expose it.
4526 * Everywhere that called Error_ValueCannotBeConverted: pass a new
4529 Exceptions: Null.ConvertImplicitly,
4530 Constant.ImplicitConversionRequired as there are too many call
4531 sites for passing the ec.
4533 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
4534 EmitContext, if the value is null, then we do not try to provide
4535 the extra information from the error (If a userdefined conversion
4536 exists, as UserDefinedConversion requires a non null-EmitContext).
4540 2006-12-30 Raja R Harinath <rharinath@novell.com>
4542 * flowanalysis.cs (MyBitVector): Document some invariants.
4543 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
4544 introduced below, and add a couple of others,
4546 2006-12-30 Marek Safar <marek.safar@gmail.com>
4548 * attribute.cs (GetMethodObsoleteAttribute): Uses new
4549 GetPropertyFromAccessor and GetEventFromAccessor.
4551 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
4552 overrides non-obsolete one.
4553 (Indexer.Define): Error message has been moved to the parser.
4555 * cs-parser.jay: Better syntax errors handling.
4557 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
4558 when an invocation has no arguments.
4560 * ecore.cs: Removed not used caching.
4562 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
4565 * report.cs: Add a new warning.
4567 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
4569 * typemanager.cs (enumeration_type): Removed.
4570 (CSharpSignature): Reuses IsSpecialMethod.
4571 (IsEqual): Hack for MS BCL.
4572 (GetPropertyFromAccessor): New method.
4573 (GetEventFromAccessor): New method.
4574 (IsSpecialMethod): Fixed to handle more cases.
4576 2006-12-30 Marek Safar <marek.safar@gmail.com>
4578 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
4579 Made white spaces array static.
4581 * ecore.cs (RemoveGenericArity): Optimized.
4583 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
4585 (MyBitVector.initialize_vector): Simplified.
4587 2006-12-22 Miguel de Icaza <miguel@novell.com>
4589 * ecore.cs: Am not entirely happy with this hack, but it seems to
4590 address the issue in 80257 (a small test case for
4593 I set the MethodGroupExpr.Type to an internal compiler type
4594 (itself in this case) to force the resolution to take place. Why
4595 it does not take place with a null is beyond me.
4597 2006-12-20 Marek Safar <marek.safar@gmail.com>
4599 A fix for bug #80288
4600 * expression.cs (ResolveOperator): Consider user defined conversion for
4601 logical and operator too.
4602 (EmitBranchable): Optimization for logical and when full constant folding
4603 could not be applied but one operand is constant.
4605 2006-12-19 Marek Safar <marek.safar@gmail.com>
4607 * class.cs (GetClassBases): Write 5 times every day, will never use
4608 FullName for error reporting.
4610 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
4612 2006-12-19 Martin Baulig <martin@ximian.com>
4614 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
4615 the symbol file info here.
4617 2006-12-18 Marek Safar <marek.safar@gmail.com>
4619 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
4620 of `elseif' is taking then following sections are not taking.
4621 Fixes an issue reported on mono mailing list.
4623 2006-12-18 Marek Safar <marek.safar@gmail.com>
4625 A fix for bug #80300
4626 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
4627 a caller is not taking.
4629 2006-12-18 Raja R Harinath <rharinath@novell.com>
4631 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
4632 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
4633 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
4634 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
4635 * class.cs: Update to changes.
4637 2006-12-17 Marek Safar <marek.safar@gmail.com>
4639 A fix for bug #79934
4640 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
4643 * class.cs (ResolveMembers): Register an iterator in current container and
4646 2006-12-16 Raja R Harinath <rharinath@novell.com>
4649 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
4650 satisfy a params annotated parameter.
4652 2006-12-16 Marek Safar <marek.safar@gmail.com>
4654 A fix for bug #77014
4655 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
4656 paramters correctly and not rely on hacks in Parameters class.
4657 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
4659 (Invocation.VerifyArgumentsCompat): Ditto.
4660 (Invocation.EmitArguments): Changed to correctly emit params arguments at
4663 * parameter.cs (HasParams): Don't assume that params is the last one.
4665 * support.cs (ReflectionParameters.ctor): Look for params attribute
4667 (ReflectionParameters.ParameterType): Removed hack when we returned last
4668 parameter for out of range parameters.
4669 (ParameterName, ParameterModifier): Ditto.
4671 2006-12-14 Marek Safar <marek.safar@gmail.com>
4673 A fix for bug #79987
4674 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
4675 when assembly is not CLS compliant but type is. I have no idea why is this
4678 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
4680 2006-12-13 Miguel de Icaza <miguel@novell.com>
4682 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
4683 in struct constructors, they are basically no-ops.
4685 2006-12-12 Marek Safar <marek.safar@gmail.com>
4687 * cs-tokenizer.cs (Position): Save preprocessor status too.
4689 2006-12-12 Marek Safar <marek.safar@gmail.com>
4691 A fix for bug #77794
4692 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
4694 2006-12-12 Marek Safar <marek.safar@gmail.com>
4696 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
4698 (pp_expr): Report error for an invalid expression.
4699 (handle_preprocessing_directive): Simplified; add more error checking.
4701 2006-12-11 Marek Safar <marek.safar@gmail.com>
4703 A fix for bug #74939
4704 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
4705 directives handling.
4707 2006-12-10 Marek Safar <marek.safar@gmail.com>
4709 A fix for bugs #80093, and #75984
4710 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
4711 logic, it seems to me as it worked before "by coincidence".
4712 (xtoken): Simplified to use reworked handle_preprocessing_directive.
4713 (cleanup): Enabled endif check.
4715 2006-12-09 Marek Safar <marek.safar@gmail.com>
4717 A fix for bug #80162
4718 * statement.cs (CollectionForeach.TryType): Generics and non-generics
4719 enumerators are never ambiguous.
4721 2006-12-08 Raja R Harinath <rharinath@novell.com>
4724 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
4726 2006-12-06 Marek Safar <marek.safar@gmail.com>
4728 A fix for bug #80144
4729 * class.cs (EventProperty.Define): Explicit implementation means
4730 that an even is used.
4732 2006-12-06 Marek Safar <marek.safar@gmail.com>
4734 Fixes the operators implementation (part II)
4736 * cfold.cs (DoConstantNumericPromotions): Renamed to
4737 DoBinaryNumericPromotions and simplified.
4738 (BinaryFold): Couple of conversion fixes; simplified.
4740 * constant.cs, ecore.cs, literal.cs
4741 (ToType): Renamed to ConvertImplicitly.
4742 (Reduce): Renamed to ConvertExplicitly.
4744 * class.cs, convert.cs: Updated.
4746 * expression.cs: TryReduce doesn't throw an exception.
4748 2006-12-01 Marek Safar <marek.safar@gmail.com>
4750 A fix for bug #80108
4751 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
4754 2006-11-30 Marek Safar <marek.safar@gmail.com>
4756 Fixes unary operators implementation (part I)
4759 * cfold.cs (Error_CompileTimeOverflow): Made internal
4761 * const.cs (IConstant): Changed to use reference to constant and
4762 not constant itself.
4763 Updated IConstant implementations.
4765 * constant.cs (CreateConstant): New factory method.
4766 Updated IConstant implementation.
4768 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
4770 * ecore.cs: Updated to use CreateConstantReference.
4772 * enum.cs: Reflects IConstant changes.
4774 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
4776 * literal.cs (NullConstant): Change to be independently usable.
4778 2006-11-29 Martin Baulig <martin@ximian.com>
4780 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
4781 we need to emit the scope initializer before calling the base .ctor.
4783 * anonymous.cs: Merged back from the new anonymous methods branch.
4784 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
4786 * expression.cs (ParameterReference.DoResolveBase): Create a
4787 "normal" ScopeInfo when capturing parameters rather than using the
4788 root scope; this makes things work with anonymous methods having
4792 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
4794 2006-11-22 Marek Safar <marek.safar@gmail.com>
4796 A fix for bug #79987
4797 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
4798 check to a base class.
4799 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
4800 only when assembly has missing attribute.
4801 * report.cs: Update.
4803 2006-11-21 Marek Safar <marek.safar@gmail.com>
4805 * cs-tokenizer.cs: Merged with gmcs version.
4807 2006-11-20 Marek Safar <marek.safar@gmail.com>
4810 * cs-parser.jay: Better error message when partial keyword is misplaced.
4812 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
4814 A fix for bug #79810
4815 report.cs: CS1058 only applies to 2.0 profile (gmcs).
4816 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
4817 a RuntimeWrappedException by default.
4819 2006-11-18 Marek Safar <marek.safar@gmail.com>
4821 A fix for bug #79843
4822 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
4824 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
4826 2006-11-18 Marek Safar <marek.safar@gmail.com>
4828 * driver.cs, namespace.cs: Uses faster IndexOf version.
4830 2006-11-17 Marek Safar <marek.safar@gmail.com>
4832 A fix for bug #79941
4833 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
4835 (Operator.Define): Implicit/Explicit operator of same type is duplicate
4836 even if internal name is different.
4837 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
4838 (UserDefinedConversion): Simplified as the operators cannot be internal.
4839 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
4841 (MethodLookup): Replaced EmitContext with parentType.
4842 * expression.cs: Updated.
4844 2006-11-09 Raja R Harinath <rharinath@novell.com>
4846 * driver.cs (BadAssembly): Handle all the ugliness of
4847 DefineDynamicAssembly.
4849 2006-11-08 Raja R Harinath <rharinath@novell.com>
4851 Address parts of #58244 -- most of what's left is in the runtime
4852 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
4853 CS1509 error checks, and handle them for all assembly loads, not
4854 just the first invocation.
4855 (LoadModule): Likewise. Move handling of 'adder_method' ...
4856 * codegen.cs (AssemblyClass.AddModule): ... here.
4858 2006-11-02 Marek Safar <marek.safar@gmail.com>
4860 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
4861 IEnumerable<T> is ambiguous.
4863 2006-10-31 Marek Safar <marek.safar@gmail.com>
4865 A fix for bug #67689
4866 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
4867 GetEnumerator is ambiguous.
4869 * report.cs: Add new warning.
4871 2006-10-29 Marek Safar <marek.safar@gmail.com>
4873 A fix for bug #78602
4874 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4875 to protected member can be nested type.
4877 2006-10-28 Marek Safar <marek.safar@gmail.com>
4879 A fix for bug #78965
4880 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4881 to protected member must derive from current type.
4883 2006-10-27 Marek Safar <marek.safar@gmail.com>
4885 assign.cs: Reuses error method.
4887 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
4888 instead of type for constants.
4889 (Expression.Error_ValueAssignment): Common error method.
4891 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
4894 2006-10-27 Marek Safar <marek.safar@gmail.com>
4896 A fix for bug #79081
4897 * expression.cs (MemberAccess.DoResolve): Check nested type
4900 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
4902 * doc.cs : nested delegates were not handled. Fixed bug #79754.
4904 2006-10-26 Marek Safar <marek.safar@gmail.com>
4906 A fix for bug #76591
4907 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
4909 2006-10-26 Marek Safar <marek.safar@gmail.com>
4911 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
4912 type forwarder of the same type multiple times.
4914 2006-10-26 Raja R Harinath <rharinath@novell.com>
4917 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
4918 instance as an rvalue, even when we later resolve as an lvalue.
4920 2006-10-25 Martin Baulig <martin@ximian.com>
4922 * anonymous.cs: Fix #79673.
4924 2006-10-24 Marek Safar <marek.safar@seznam.cz>
4926 A fix for bug #79666
4927 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
4928 ignored when is optimized (= default value) as its value is already set.
4930 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4932 A fix for bug #79724
4933 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
4934 TypeContainer for type lookup.
4936 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4938 A fix for bug #79231
4939 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
4940 * expression.cs (OverloadResolve): Always convert type name for
4942 (ResolveNamespaceOrType): Don't confuse a nested type with any
4945 2006-10-18 Martin Baulig <martin@ximian.com>
4947 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
4949 2006-10-17 Miguel de Icaza <miguel@novell.com>
4951 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
4952 an int32, but requesting an int64 from the conversion
4954 2006-10-12 Martin Baulig <martin@ximian.com>
4957 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
4959 2006-10-12 Martin Baulig <martin@ximian.com>
4962 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
4964 2006-10-11 Miguel de Icaza <miguel@novell.com>
4966 * convert.cs: Remove broken code: I was doing the "Existance"
4967 tests for Implicit conversions.
4969 2006-10-10 Miguel de Icaza <miguel@novell.com>
4971 * convert.cs: Added one missing case in
4972 ImplicitStandardConversionExists uint64 to intptr.
4976 * typemanager.cs (uintptr_type): another core known type.
4978 * ecore.cs (OperatorCast): routine used to do cast operations that
4979 depend on op_Explicit. We could change some of the Decimal
4980 conversions to use this.
4982 This one has a probe mechanism that checks both types for an op_
4983 which it coudl be used to eliminate two classes: CastToDecimal
4984 and CastFromDecimal.
4986 * convert.cs: Implement the conversions documented in #59800
4988 2006-10-10 Martin Baulig <martin@ximian.com>
4990 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
4991 before RootScope.ResolveMembers().
4993 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
4994 `CurrentType' if appropriate.
4996 2006-10-09 Marek Safar <marek.safar@seznam.cz>
4998 A fix for bug #78568
4999 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
5000 when contains binary operators.
5001 * cs-parser.jay: Updated.
5003 2006-10-09 Martin Baulig <martin@ximian.com>
5006 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
5007 moved that into Define() and also do the other type parameter
5008 checks there. Fixes #79094. Added gtest-292.cs.
5011 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
5012 since that doesn't include type parameters; don't use `Ldelema'
5013 for type parameters. Fixes #78980. Added gtest-293.cs.
5015 2006-10-08 Marek Safar <marek.safar@seznam.cz>
5018 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
5019 conversion is allowed.
5021 2006-10-06 Marek Safar <marek.safar@seznam.cz>
5023 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
5024 error reporting when no error occurs.
5026 2006-10-06 Marek Safar <marek.safar@seznam.cz>
5028 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
5031 2006-10-06 Raja R Harinath <rharinath@novell.com>
5034 * class.cs (DefineTypeBuilder): Check circular dependencies before
5035 setting the parent of the TypeBuilder.
5036 (CheckRecursiveDefinition): Don't use 'BaseType', since
5037 it may not be valid until after DefineTypeBuilder. Use
5038 'base_type' instead.
5040 2006-10-04 Martin Baulig <martin@ximian.com>
5042 Merged the Anonymous Methods patch.
5044 * anonymous.cs, iterators.cs: The new anonymous methods code.
5046 * statement.cs (Variable): New public abstract class.
5047 (LocalInfo.Variable): New public property.
5048 (LocalInfo.ResolveVariable): New public method.
5049 (Block.Flags): Add `IsIterator'.
5050 (Block.AddVariable): Improved the CS0136 check.
5051 (Block.AnonymousChildren): New public property.
5052 (Block.AddAnonymousChild): New public method.
5053 (ToplevelBlock): Update to use the new anonymous method framework.
5054 (ToplevelBlock.ctor): `container' is now a `Block' and not a
5055 `ToplevelBlock'; this is required to correctly implement the
5057 (Fixed, Using): Use `TemporaryVariable' instead of directly
5058 creating the `LocalBuilder'.
5060 * parameter.cs (Parameter.ResolveVariable): New public method.
5061 (Parameters.ResolveVariable): Likewise.
5063 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
5065 * class.cs (TypeContainer): Replaced the `iterators' list and
5066 corresponding methods with a list of `CompilerGeneratedClass'es.
5067 (TypeContainer.ResolveMembers): New public method.
5068 (Method): `IIteratorContainer' has been replaced by
5071 * expression.cs (VariableReference): New public abstract base
5072 class for `LocalVariableReference', `ParameterReference' and
5075 * codegen.cs (EmitContext): Removed `capture_context',
5076 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
5077 (EmitContext.EmitThis): Removed.
5079 * cs-parser.jay: Replace `iterator_container' with
5082 2006-10-04 Martin Baulig <martin@ximian.com>
5084 * generic.cs (GenericMethod): Don't make this abstract.
5085 (Constraints.Clone): Added dummy implementation.
5087 2006-10-04 Raja R Harinath <harinath@gmail.com>
5090 * namespace.cs (LookForAnyGenericType): Avoid nullref on
5091 'declspaces'. Avoid allocating arrays willy-nilly.
5094 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
5095 cases out of the switch.
5097 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5099 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
5100 message when non-generic type is used with the type arguments.
5101 * expression.cs: Updated.
5103 2006-09-28 Raja R Harinath <rharinath@novell.com>
5106 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
5107 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5108 Change semantics slightly. Don't insist on having only one
5109 temporary EmptyExpression -- just throttle the creation of new ones.
5112 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
5113 non-interfaces too. If no methods are found, don't try to create
5116 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5118 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
5121 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
5122 us produce better error message.
5124 2006-09-27 Marek Safar <marek.safar@seznam.cz>
5126 * expression.cs (Binary.ResolveOperator): Warn about a side effect
5127 of the `|' operator.
5129 * report.cs: A new warning added.
5131 2006-09-27 Martin Baulig <martin@ximian.com>
5133 * generic.cs (GenericMethod): Don't make this abstract.
5135 2006-09-27 Martin Baulig <martin@ximian.com>
5138 (InternalErrorException): Added overloaded ctor taking a params array.
5140 2006-09-26 Marek Safar <marek.safar@seznam.cz>
5142 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
5143 Fixed the cases when same error was reported twice.
5145 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
5146 now report symbol information.
5148 2006-09-25 Martin Baulig <martin@ximian.com>
5150 * class.cs: Completely unified with the gmcs version.
5152 2006-09-25 Martin Baulig <martin@ximian.com>
5154 * typemanager.cs (TypeManager.IsNullableType): New public function.
5155 (TypeManager.IsNullableTypeOf): Likewise.
5156 (TypeManager.IsNullableValueType): Likewise.
5158 * class.cs (MethodCore): Added the `GenericMethod' argument from
5159 gmcs and also unified all classes derived from `MethodCore' with gmcs.
5161 2006-09-24 Raja R Harinath <harinath@gmail.com>
5163 * convert.cs: Unify with gmcs version.
5165 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5167 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
5168 verify them as well.
5170 * report.cs: New warning.
5172 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5174 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
5175 for anonymous block with out argument.
5177 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5179 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
5180 not used private events only.
5182 2006-09-23 Marek Safar <marek.safar@seznam.cz>
5184 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
5186 * const.cs (Const.Define): Check for constant type.
5187 (Const.IsConstantTypeValid): Looks for valid constant types.
5189 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
5191 * ecore.cs (EmptyConstantCast): New common class for all constant based
5194 * expression.cs (Is.DoResolve): Handle null constant especially.
5195 (New.DoResolve): Check for new void().
5196 (MemberAccess.DoResolve): Cope with all kind of nulls.
5198 * literal.cs (NullConstant): Uses EmptyConstantCast.
5199 (NullDefault): Based on EmptyConstantCast.
5200 (NullLiteral): Uses EmptyConstantCast.
5202 * statement.cs (Block.ResolveMeta): Check for constant type.
5204 2006-09-22 Martin Baulig <martin@ximian.com>
5206 * delegate.cs, attribute.cs: Merged with the gmcs versions.
5208 2006-09-22 Raja R Harinath <rharinath@novell.com>
5210 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
5214 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
5215 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
5218 2006-09-22 Martin Baulig <martin@ximian.com>
5220 * ecore.cs: Merged with the gmcs version.
5222 * generic.cs (ConstructedType): New dummy class.
5223 (TypeArguments): Don't make this abstract.
5226 (TypeManager.IsGenericTypeDefinition): New method.
5227 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
5229 2006-09-22 Raja R Harinath <rharinath@novell.com>
5231 * expression.cs (ComposedCast): Check for arrays of TypedReference
5232 before creating the type, not after.
5234 2006-09-21 Marek Safar <marek.safar@seznam.cz>
5236 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
5237 after ToType change.
5239 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
5240 when constant must be implicitly convertible.
5242 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
5244 * ecore.cs (NullCast): Derives from NullConstant.
5246 * expression.cs (Is.DoResolve): Removed useless variables.
5247 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
5248 (New.Constantify): Add enum support.
5249 (MemberAccess.DoResolve): Add warning when accessing null constant or
5252 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
5255 * literal.cs (NullConstant): New abstract class with common
5256 functionality for all null specializations.
5257 (NullDefault): Represents default(X) when result can be
5259 (NullLiteral): Updated.
5261 * report.cs: Add new warning.
5263 2006-09-21 Martin Baulig <martin@ximian.com>
5265 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
5267 2006-09-21 Martin Baulig <martin@ximian.com>
5269 * generic.cs (GenericConstraints): New dummy class.
5270 (Constraints): Likewise.
5271 (TypeParameter): Likewise.
5272 (TypeParameterName): Likewise.
5273 (GenericMethod): Likewise.
5275 * typemanager.cs (TypeManager.GetGenericArguments): New method.
5277 * decl.cs: Merged with the gmcs version.
5279 2006-09-21 Raja R Harinath <rharinath@novell.com>
5281 * generic.cs (TypeParameter): Implement IMemberContainer.
5282 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
5284 * rootcontext.cs: Unify with gmcs version.
5286 * report.cs: Unify with gmcs version.
5287 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
5288 from gmcs/generics.cs.
5289 * generics.cs (TypeParameter): New dummy class.
5291 * support.cs: Unify with gmcs version.
5293 2006-09-20 Raja R Harinath <rharinath@novell.com>
5295 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
5296 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
5298 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
5299 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
5300 * mcs.exe.sources: Add generic.cs.
5302 * codegen.cs: Unify with gmcs version.
5304 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
5305 (EmitContext): Add GenericDeclContainer implementation.
5306 * decl.cs (MemberCore, DeclSpace): Likewise.
5307 * namespace.cs: Remove #ifdef GMCS_SOURCE.
5309 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
5310 MCS TypeManager has a corresponding dummy method.
5312 2006-09-19 Martin Baulig <martin@ximian.com>
5314 * expression.cs: Completely merged with the gmcs version.
5316 2006-09-19 Martin Baulig <martin@ximian.com>
5318 * expression.cs (Invocation): Merged with the gmcs version.
5319 (ArrayAccess.GetStoreOpcode): Likewise.
5321 2006-09-19 Martin Baulig <martin@ximian.com>
5324 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
5325 (TypeManager.IsGenericMethodDefinition): Likewise.
5327 2006-09-19 Martin Baulig <martin@ximian.com>
5330 (TypeManager.IsEqual): Moved the gmcs implementation here.
5331 (TypeManager.DropGenericTypeArguments): Likewise.
5332 (TypeManager.DropGenericMethodArguments): Likewise.
5333 (TypeManager.GetTypeArguments): Moved here from gmcs.
5334 (TypeManager.HasGenericArguments): Likewise.
5336 2006-09-19 Martin Baulig <martin@ximian.com>
5338 * expression.cs (Binary): Merged with the gmcs version.
5340 2006-09-19 Martin Baulig <martin@ximian.com>
5342 * expression.cs (Probe, As, Is): Merged with the gmcs version.
5344 2006-09-19 Martin Baulig <martin@ximian.com>
5346 * typemanager.cs: Merged with the gmcs version.
5348 2006-09-16 Raja R Harinath <rharinath@novell.com>
5350 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
5351 * driver.cs: Likewise.
5353 2006-09-16 Marek Safar <marek.safar@seznam.cz>
5356 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
5357 only if parent type is class.
5358 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
5361 2006-09-15 Marek Safar <marek.safar@seznam.cz>
5364 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
5366 * typemanager.cs(CSharpName): Converts NullType to null.
5368 2006-09-15 Martin Baulig <martin@ximian.com>
5371 (TypeManager.GetMethodName): Added mcs implementation.
5372 (TypeManager.IsEqual): Likewise.
5375 (SimpleName.RemoveGenericArity): Added dummy implementation.
5377 * pending.cs: Merged with the gmcs version.
5379 2006-09-15 Martin Baulig <martin@ximian.com>
5381 * statement.cs: Merge with the gmcs version.
5383 2006-09-15 Martin Baulig <martin@ximian.com>
5385 * statement.cs (Switch): Merge with the gmcs implementation
5386 (without nullables), which is newer.
5388 2006-09-15 Martin Baulig <martin@ximian.com>
5390 * statement.cs (Block.Variables): Make this public.
5391 (ToplevelBlock.Parameters): Make this a property.
5392 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
5394 2006-09-15 Martin Baulig <martin@ximian.com>
5396 * namespace.cs: Merge with the gmcs version.
5398 2006-09-15 Martin Baulig <martin@ximian.com>
5400 * decl.cs (MemberName): Minor code cleanups.
5402 2006-09-15 Martin Baulig <martin@ximian.com>
5404 * parameter.cs: Merge with the gmcs version.
5406 2006-09-15 Martin Baulig <martin@ximian.com>
5408 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
5409 and an error in mcs.
5411 2006-09-15 Martin Baulig <martin@ximian.com>
5413 * flowanalysis.cs: Merged from GMCS; added the generics code into
5414 a `GMCS_SOURCE' conditional so we can share this file.
5416 2006-09-08 Martin Baulig <martin@ximian.com>
5418 * typemanager.cs (TypeManager.interlocked_type): New public field.
5419 (TypeManager.int_interlocked_compare-exchange): New public field.
5420 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
5421 enumerator types here and call InitGenericCoreTypes().
5422 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
5423 after calling InitEnumUnderlyingTypes().
5426 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
5427 `classes_second_stage'.
5429 2006-09-14 Marek Safar <marek.safar@seznam.cz>
5431 * assign.cs, ecore.cs, expression.cs: Share error message text.
5432 * class.cs (FieldMember.Define): Check for varible of static type.
5433 * driver.cs (LoadAssembly): Uses error output for errors.
5434 * statement.cs: Updated.
5436 2006-09-08 Marek Safar <marek.safar@seznam.cz>
5438 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
5441 2006-09-07 Martin Baulig <martin@ximian.com>
5444 (MainDriver): Revert r62663 from Marek; see #70506 for details.
5446 2006-08-29 Miguel de Icaza <miguel@novell.com>
5448 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
5450 2006-08-17 Miguel de Icaza <miguel@novell.com>
5452 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
5453 #52019 and #79064, the use of the \uXXXX sequence in source code
5454 to represent unicode characters.
5456 2006-08-15 Marek Safar <marek.safar@seznam.cz>
5458 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
5460 * class.cs, ecore.cs, statement.cs: Merged to one error message.
5462 2006-08-13 Miguel de Icaza <miguel@novell.com>
5464 * assign.cs: Catch attempts to assign to a method groups in += and
5467 2006-08-13 Marek Safar <marek.safar@seznam.cz>
5470 * cs-parser.jay: Don't destroy current array type by typeof of array's.
5472 2006-08-12 Marek Safar <marek.safar@seznam.cz>
5474 * class.cs (Method.Define): Issue a warning when generic method looks like
5476 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
5479 2006-08-09 Marek Safar <marek.safar@seznam.cz>
5481 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
5483 * decl.cs (MemberCache.FindMembers): When container is interface we need to
5484 search all base interfaces as a member can be ambiguous.
5485 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
5486 Constructor member type filter.
5487 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
5488 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
5489 reporting for returned memberinfos.
5490 * report.cs: Updated.
5491 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
5492 version to work on all runtimes.
5493 (TypeManager.RealMemberLookup): Removed members filtering.
5495 2006-08-08 Raja R Harinath <rharinath@novell.com>
5497 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
5498 (PropertyExpr.EmitAssign): Likewise.
5499 * expression.cs (Indirection.EmitAssign): Likewise.
5500 (LocalVariableReference.EmitAssign): Likewise.
5501 (ParameterReference.EmitAssign): Likewise.
5502 (Invocation.EmitArguments): Likewise.
5503 (ArrayAccess.EmitAssign): Likewise.
5504 (IndexerAccess.EmitAssign): Likewise.
5505 (This.EmitAssign): Likewise.
5506 (ConditionalLogicalOperator.Emit): Likewise.
5509 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
5510 instead of ArrayList. If the hashtable has a LocalBuilder, don't
5511 leave it in after returning it.
5512 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
5514 2006-08-06 Marek Safar <marek.safar@seznam.cz>
5516 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
5519 2006-08-03 Raja R Harinath <rharinath@novell.com>
5521 Fix cs0146-3.cs and cs0146-4.cs.
5522 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
5523 enclosing types don't depend on the current type.
5525 2006-08-02 Raja R Harinath <rharinath@novell.com>
5528 * class.cs (TypeContainer.DoDefineMembers): Use
5529 FindBaseMemberWithSameName on Parent, since we're interested in
5530 whether we hide inherited members or not.
5531 (FindBaseMemberWithSameName): Make slightly more robust.
5533 Fix the non-generic testcase from #77396
5534 * decl.cs (DeclSpace.DeclContainer): Remove override.
5536 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
5537 declspaces for doppelgangers too.
5538 (UsingEntry): Implement IResolveContext.
5539 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
5540 'this' as the resolve context.
5541 (LocalAliasEntry): Likewise.
5543 Implement parts of #77403
5544 * roottypes.cs (RootDeclSpace): New. Used to represent the
5545 toplevel declaration space. Each namespace declaration introduces
5546 a "partial" root declaretion space.
5547 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
5548 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
5549 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
5550 from 'current_namespace.SlaveDeclSpace'.
5551 (namespace_declaration): Likewise.
5552 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
5553 check. It can't happen now.
5554 * decl.cs (DeclSpace.LookupType): Likewise.
5555 * driver.cs (MainDriver): Sanity check.
5557 2006-08-01 Raja R Harinath <rharinath@novell.com>
5559 * decl.cs (DeclSpace.FindNestedType): Remove.
5560 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
5561 LookupTypeContainer to get the container of the nested type.
5562 * class.cs (TypeContainer.FindNestedType): Make non-override.
5564 2006-07-31 Raja R Harinath <rharinath@novell.com>
5566 * decl.cs (DeclSpace.PartialContainer): Move field from ...
5567 * class.cs (TypeContainer.PartialContainer): ... here.
5568 (TypeContainer.AddBasesForPart): New helper.
5569 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
5571 * cs-parser.jay (current_class): Convert to DeclSpace.
5572 (struct_declaration, interface_declaration, class_declaration):
5573 Use AddBasesForPart instead of .Bases directly.
5574 * const.cs, iterators.cs: Update to changes.
5576 2006-07-28 Raja R Harinath <rharinath@novell.com>
5578 * class.cs (TypeContainer.AddMemberType): Rename from
5580 (TypeContainer.AddMember): Rename from AddToMemberContainer.
5581 (AddTypeContainer): New. Combine AddClassOrStruct and
5583 (AddPartial): Update. Add 'is_partial' argument.
5584 * roottypes.cs: Update to changes.
5585 * cs-parser.jay (push_current_class): New helper for handling
5586 current_container and current_class.
5587 (struct_declaration, interface_declaration, class_declaration):
5590 2006-07-26 Raja R Harinath <rharinath@novell.com>
5592 * roottypes.cs: Rename from tree.cs.
5594 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
5595 * tree.cs (Tree, ITreeDump): Remove types.
5596 * rootcontext.cs (tree, Tree): Remove fields.
5597 (root, ToplevelTypes): New.
5598 * *.cs: Update to rename.
5600 * tree.cs (Tree.RecordDecl): Remove.
5601 (RootTypes.AddToTypeContainer): Record the toplevel type in its
5603 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
5605 2006-07-23 Raja R Harinath <harinath@gmail.com>
5607 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
5608 DoFlowAnalysis and OmitStructFlowAnalysis here.
5609 (ec.With): Rename from WithUnsafe and generalize.
5610 (ec.WithCheckState): Remove. All users can be handled by 'With'.
5611 (ec.WithFlowAnalyis): New.
5612 * ecore.cs, expression.cs, statement.cs: Update.
5614 2006-07-22 Raja R Harinath <harinath@gmail.com>
5616 * statement.cs (Block.ResolveMeta): Simplify slightly.
5618 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
5619 multiple boolean fields. Convert InUnsafe, constant_check_state,
5620 check_state to flags.
5621 (CheckState, ConstantCheckState): Update.
5622 (InUnsafe): New read-only property.
5623 (FlagsHandle): Rename from CheckStateHandle and convert to handle
5625 (WithUnsafe): New helper similar to WithCheckState.
5626 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
5627 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
5629 2006-07-21 Raja R Harinath <rharinath@novell.com>
5631 Make comparisons use the same IL irrespective of whether they're
5632 in a 'checked' or 'unchecked' context: one of the issues in #78899
5633 * codegen.cs (EmitContext.CheckState): Make read-only property.
5634 (EmitContext.ConstantCheckState): Likewise.
5635 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
5636 helper that implement a save/restore stack for CheckState
5637 values. This is the only way to change check-state.
5638 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
5639 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
5640 (CheckedExpr.EmitBranchable): New forwarding method.
5641 (UnCheckedExpr): Likewise.
5642 * statement.cs (Block.ResolveMeta): Use WithCheckState.
5643 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
5644 (Checked.Resolve, checked.DoEmit): Likewise.
5646 2006-07-20 Miguel de Icaza <miguel@novell.com>
5648 * anonymous.cs: Cache the resolved anonymous delegate, and return
5649 this so that the ResolveTopBlock is only triggered once, not
5652 Currently we trigger ResolvetopBlock twice due to a first pass of
5653 argument check compatibility, and a second pass that does the
5656 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5658 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
5660 * rootcontext.cs (Reset): Add helper_classes.
5662 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5665 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
5668 2006-07-13 Miguel de Icaza <miguel@novell.com>
5670 * statement.cs (Lock): Handle expressions of type
5671 TypeManager.null_type specially. Fixes #78770
5673 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5675 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
5678 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5680 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
5681 for accessors as well.
5682 * ecore.cs (EventExpr): Add AccessorTable.
5684 2006-07-01 Marek Safar <marek.safar@seznam.cz>
5687 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
5688 for CS0122 where appropriate.
5689 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
5691 (Filter): Assembly can be null in the case of top level attributes.
5693 2006-06-25 Marek Safar <marek.safar@seznam.cz>
5697 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
5698 is done at global level.
5700 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5702 A fix for #77002, Implemented TypeForwarder support.
5704 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
5705 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
5706 * typemanager.cs (): Add type_forwarder_attr_type.
5708 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5710 * report.cs: Add CS0469 warning.
5712 2006-06-21 Martin Baulig <martin@ximian.com>
5714 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
5715 the `try'-block, so we also report CS0016 etc. there.
5717 2006-06-21 Martin Baulig <martin@ximian.com>
5720 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
5722 2006-06-21 Martin Baulig <martin@ximian.com>
5724 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
5725 also report CS1686 for parameters.
5727 2006-06-21 Martin Baulig <martin@ximian.com>
5729 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
5730 instead of an error if the value is not implicitly convertible to
5731 the switch types; fixes #77964.
5733 2006-06-21 Raja R Harinath <rharinath@novell.com>
5736 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
5737 FieldBuilder is null.
5740 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
5741 'left' and 'right' before error-checking.
5743 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
5745 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
5747 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
5748 (FieldExpr.DoResolve): likewise.
5749 (PropertyExpr.InstanceResolve): likewise.
5750 (EventExpr.InstanceResolve): likewise.
5752 2006-06-04 Marek Safar <marek.safar@seznam.cz>
5754 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
5755 attribute applicable tests for attribute argument.
5757 2006-06-02 Raja R Harinath <rharinath@novell.com>
5760 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
5761 (Binary.OverloadResolve_PredefinedIntegral): New.
5762 (Binary.OverloadResolve_PredefinedFloating): New.
5763 (Binary.OverloadResolve_PredefinedString): New.
5764 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
5765 Follow the standard more closely, and treat numeric promotions in
5766 terms of overload resolution.
5767 (Binary.CheckShiftArguments): Simplify.
5769 2006-06-01 Raja R Harinath <rharinath@novell.com>
5771 * flowanalysis.cs (MyBitVector): Simplify representation.
5772 (MyBitVector.Clone): Avoid allocating BitArray.
5773 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
5774 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
5775 (*): Update. Change all references to MyBitVector.And and
5776 MyBitVector.Or to &= and |=.
5778 2006-05-29 Raja R Harinath <rharinath@novell.com>
5781 * cs-parser.jay (formal_parameter_list): Extend the pattern below
5782 to param arguments too.
5784 2006-05-26 Miguel de Icaza <miguel@novell.com>
5786 * cs-parser.jay: Catch another parsing form for arglist being
5787 followed by other arguments. Fixes #78313.
5789 2006-05-24 Raja R Harinath <rharinath@novell.com>
5791 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
5792 checking of out parameters to ...
5793 (FlowBranchingToplevel.Merge): ... here.
5794 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
5795 set, propagate the origin upward, and only complain if there was
5797 (FlowBranchingException.AddContinueOrigin): Likewise.
5798 (FlowBranchingException.AddReturnOrigin): Likewise.
5799 (FlowBranchingException.AddGotoOrigin): Likewise.
5801 2006-05-23 Raja R Harinath <rharinath@novell.com>
5803 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
5804 unreachable, skip it.
5805 (FlowBranchingException.Merge): Always propagate jumps, even if
5806 the finally block renders subsequent code unreachable.
5808 2006-05-18 Raja R Harinath <rharinath@novell.com>
5811 * statement.cs (Goto.Resolve): Move responsibility for resolving
5812 'goto' to FlowBranching.AddGotoOrigin.
5813 (Goto.SetResolvedTarget): New. Callback to set the
5814 LabeledStatement that's the target of the goto.
5815 (Goto.DoEmit): Use Leave instead of Br when crossing an
5816 unwind-protect boundary.
5817 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
5818 LookupLabel and adjust to new semantics.
5819 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
5820 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
5821 Goto.SetResolvedTarget to update target.
5822 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
5823 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
5824 AddBreakOrigin & co. Delay propagation until ...
5825 (FlowBranchingException.Merge): ... this.
5827 * statement.cs (Block.Resolve): Always depend on flow-branching to
5828 determine unreachability. Kill workaround that originally emitted
5829 only one statement after an "unreachable" label (see infloop in
5832 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
5833 This is still "wrong", but anything better would probably need a
5834 multi-pass algorithm.
5835 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
5836 usage vector. Force current usage vector to be reachable, to
5837 optimistically signify backward jumps.
5838 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
5840 (FlowBranchingLabeled.Merge): New. If no backward jump was
5841 detected, return the original salted-away usage vector instead,
5842 updated with appropriate changes. Print unreachable warning if
5844 * statement.cs (Block.Resolve): Don't print unreachable warning on
5845 a labeled statement.
5847 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
5849 * driver.cs: Pass filename without path to AssemblyBuilder's
5850 AddResourceFile. Fixes bug #78407.
5852 2006-05-17 Raja R Harinath <rharinath@novell.com>
5854 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
5855 * flowanalysis.cs (FlowBranchingLabeled): ... here.
5856 (FlowBranching.MergeChild): Overwrite
5857 reachability information from Labeled branchings too.
5859 2006-05-16 Raja R Harinath <rharinath@novell.com>
5861 * statement.cs (Goto.Resolve): Merge jump origins here ...
5862 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
5864 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
5865 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
5866 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
5867 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
5869 * statement.cs (Goto.Resolve): ... not here.
5870 (Goto.Emit): Remove CS1632 check.
5872 2006-05-14 Marek Safar <marek.safar@seznam.cz>
5874 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
5877 2006-05-11 Raja R Harinath <rharinath@novell.com>
5879 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
5880 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
5881 (FlowBranchingException.Label): Likewise.
5883 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
5885 (MyBitVector.Or): Use it to avoid losing information (Count).
5886 (FlowBranching.MergeOrigins): Likewise.
5888 * flowanalysis.cs (UsageVector.IsDirty): Remove.
5889 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
5890 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
5891 (UsageVector.ToString): Simplify.
5892 (UsageVector.MergeSiblings): Move here from ...
5893 (FlowBranching.Merge): ... here.
5894 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
5897 2006-05-10 Raja R Harinath <rharinath@novell.com>
5899 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
5900 null bitvector is treated as all-true.
5902 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
5903 (MyBitVector): Rationalize invariants. 'vector != null' implies
5904 that we have our own copy of the bitvector. Otherwise,
5905 'InheritsFrom == null' implies all inherited bits are true.
5907 2006-05-09 Marek Safar <marek.safar@seznam.cz>
5909 * statement.cs (LocalInfo): Add IsConstant.
5910 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
5911 local variable for constants.
5913 2006-05-09 Raja R Harinath <rharinath@novell.com>
5915 * flowanalysis.cs (MyBitVector.Empty): New.
5916 (MyBitVector): Don't allow InheritedFrom to be null.
5917 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
5918 (UsageVector, FlowBranching): Update to changes.
5920 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
5921 recursion. The 'Parent == null' condition isn't sufficient for
5923 (FlowBranching.AddBreakOrigin): Likewise.
5924 (FlowBranching.AddContinueOrigin): Likewise.
5925 (FlowBranching.AddReturnOrigin): Likewise.
5926 (FlowBranching.StealFinallyClauses): Likewise.
5927 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
5928 (FlowBranching.CheckOutParameters): Likewise.
5929 (FlowBranchingToplevel): Terminate all the above recursions here.
5930 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
5931 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
5933 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
5935 (FlowBranchingToplevel): New. Empty for now.
5936 (FlowBranching.MergeTopBlock): Update.
5937 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
5938 branching for the anonymous delegate.
5939 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
5941 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
5942 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
5943 information at the start of the merge. Reorganize.
5945 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5947 * class.cs (MethodData.Define): Method cannot implement interface accessor.
5949 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5951 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
5952 to newly introduced ctor.
5954 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
5955 message to one place.
5956 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
5959 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5961 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
5963 * ecore.cs (Expression.ResolveAsConstant): Updated.
5965 * statement.cs (ResolveMeta): Updated.
5967 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5969 * cs-parser.jay: __arglist cannot be used in initializer.
5971 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5974 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
5977 2006-05-05 Raja R Harinath <rharinath@novell.com>
5979 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
5980 (LabeledStatement): Add 'name' parameter.
5981 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
5982 (Block.AddLabel): Update to changes.
5983 * cs-parser.jay (labeled_statement): Likewise.
5985 * flowanalysis.cs (BranchingType.Labeled): New.
5986 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
5987 (FlowBranchingLabeled): New. Does nothing for now, but will
5988 eventually handle 'goto' flows.
5989 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
5990 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
5991 that's terminated ...
5992 (Block.Resolve): ... here.
5994 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
5995 (UsageVector.MergeFinallyOrigins): Likewise.
5996 (FlowBranching.InTryOrCatch): Likewise.
5997 (FlowBranching.AddFinallyVector): Likewise.
5998 (FlowBranchingException): Update to changes.
6001 * statement.cs (Return.Resolve): Move error checking to ...
6002 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
6003 (FlowBranchingException): Handle return origins like break and
6005 (FlowBranching.UsageVector.CheckOutParameters): Remove.
6007 2006-05-04 Marek Safar <marek.safar@seznam.cz>
6010 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
6013 2006-05-04 Marek Safar <marek.safar@seznam.cz>
6016 * class.cs (MethodData.Define): Do public accessor check only when method
6017 implements an interface.
6019 2006-05-04 Raja R Harinath <rharinath@novell.com>
6021 Remove special handling of 'break'
6022 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
6023 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
6024 (UsageVector.Break): Remove.
6025 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
6027 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
6029 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
6030 UsageVector.Breaks (). Don't set NeedsReturnLabel.
6032 2006-05-03 Marek Safar <marek.safar@seznam.cz>
6035 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
6036 be the interface member.
6038 2006-05-03 Marek Safar <marek.safar@seznam.cz>
6041 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
6042 for emitting small (int) values.
6044 2006-05-03 Raja R Harinath <rharinath@novell.com>
6047 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
6048 control-flow passes through the 'finally' after merging-in all the
6049 control-flows from 'try' and the 'catch' clauses.
6051 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
6052 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
6053 always true at the only non-recursive entry point.
6054 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
6055 FlowBranchingBreakable.
6056 (FlowBranchingLoop): Remove.
6057 * statement.cs (Return.DoResolve): Update to changes.
6060 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
6061 (FlowBranching.CreateBranching): Handle it: create a
6062 FlowBranchingContinuable.
6063 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
6064 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
6065 except that it handles the 'continue' command.
6066 (FlowBranching.UsageVector.MergeOrigins): Rename from
6068 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
6069 except that it overrides AddContinueOrigin.
6070 (FlowBranchingException): Override AddContinueOrigin, similar to
6072 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
6073 Create a new branching around the embedded statement.
6074 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
6075 control flow after the embedded statement.
6076 (Continue.Resolve): Move all error checking to AddContinueOrigin.
6078 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
6079 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
6080 FlowBranchingBreakable.
6081 (FlowBranchingSwitch): Remove.
6084 * statement.cs (Break.Resolve): Simplify. Move responsibility for
6085 error reporting to ...
6086 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
6087 Rename from 'AddBreakVector'. Add new location argument. Return
6088 a bool indicating whether the 'break' crosses an unwind-protect.
6089 (FlowBranchingException.AddBreakOrigin): Add.
6090 (FlowBranchingException.Merge): Propagate 'break's to surrounding
6091 flowbranching after updating with the effects of the 'finally'
6093 (FlowBranchingBreakable): New common base class for
6094 FlowBranchingLoop and FlowBranchingSwitch.
6096 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
6098 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
6100 2006-05-02 Raja R Harinath <rharinath@novell.com>
6102 * statement.cs (Do.Resolve): If the loop is infinite, set the
6104 (While.Resolve, For.Resolve): Set a barrier after the embedded
6105 statement. There's no direct control flow that goes from the end
6106 of the embedded statement to the end of the loop.
6107 * flowanalysis.cs (FlowBranching.Infinite): Remove.
6108 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
6109 above ensure that the reachability is correctly computed.
6111 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
6112 (UsageVector.MergeBreakOrigins): If the current path is
6113 unreachable, treat it as if all parameters/locals are initialized.
6114 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
6115 infinite loops before merging-in break origins.
6117 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
6118 (Reachability.Reachable): Split part into ...
6119 (Reachability.Unreachable): ... this. Simplify.
6120 (Reachability.IsUnreachable): Use 'Unreachable' instead.
6122 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
6123 (Reachability.SetThrowsSometimes): Likewise.
6124 (FlowBranchingBlock.MergeTopBlock): Don't compare against
6125 TriState.Always, use corresponding property.
6126 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
6127 (Block.Resolve): Likewise. Remove some redundant checks.
6129 2006-05-02 Raja R Harinath <harinath@gmail.com>
6131 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
6132 (Reachability.Meet): Don't bother checking AlwaysThrows --
6133 barrier is always set.
6134 (FlowBranchingBlock.Merge): Likewise.
6136 2006-05-01 Raja R Harinath <harinath@gmail.com>
6138 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
6139 checks for unreachable.
6141 2006-05-01 Marek Safar <marek.safar@seznam.cz>
6144 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
6146 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
6147 whether field is really assigned.
6149 2006-04-30 Raja R Harinath <harinath@gmail.com>
6151 * flowanalysis.cs (Reachability): Make 4-argument constructor
6153 (Reachability.Meet): Rename from 'And'. Remove static variant.
6154 (Reachability.Always): Rename from the highly misleading
6155 'Reachability.Never'.
6156 (FlowBranching.Merge): Update to changes. Mark an impossible
6157 situation with a 'throw'.
6158 (*): Update to changes.
6160 2006-04-29 Raja R Harinath <harinath@gmail.com>
6162 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
6164 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
6165 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
6166 (*): Update to changes.
6167 * statement.cs: Update to changes.
6169 2006-04-28 Marek Safar <marek.safar@seznam.cz>
6172 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
6174 2006-04-28 Raja R Harinath <harinath@gmail.com>
6176 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
6179 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
6180 argument to two arguments: an usage-vector and a bool. Move call
6181 to FlowBranching.Merge () ...
6182 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
6184 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
6185 handling of loop and switch reachability to ...
6186 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
6188 2006-04-27 Raja R Harinath <harinath@gmail.com>
6190 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
6191 handling to FlowBranchingLoop.InLoop.
6192 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
6194 2006-04-26 Marek Safar <marek.safar@seznam.cz>
6197 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
6198 anonymous method is allowed from AnonymousContainer here.
6200 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
6202 2006-04-24 Raja R Harinath <rharinath@novell.com>
6205 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
6207 2006-04-23 Marek Safar <marek.safar@seznam.cz>
6210 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
6211 (DoubleConstant.Reduce): Ditto.
6213 2006-04-23 Raja R Harinath <rharinath@novell.com>
6215 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
6216 Remove 'lvalue_right_side' argument. Move parts to ...
6217 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
6218 (LocalVariable.DoResolveLValue): ... these.
6220 2006-04-21 Raja R Harinath <rharinath@novell.com>
6223 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
6224 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
6225 (LocalVariableReference.DoResolveBase): Use it to implement new
6227 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
6228 (Argument.Resolve): Simplify. Move CS1510 check ...
6229 * ecore.cs (Expression.ResolveLValue): ... here.
6230 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
6231 (PropertyExpr.DoResolveLValue): Likewise.
6232 (FieldExpr.Report_AssignToReadonly): Likewise.
6233 (FieldExpr.DoResolve): Add 'out_access' argument. Use
6234 LValueMemberAccess or LValueMemberOutAccess on instance depending
6236 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
6237 DoResolve as appropriate.
6239 2006-04-20 Raja R Harinath <rharinath@novell.com>
6242 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
6243 implicit conversions on 'out' and 'ref' arguments.
6245 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
6246 improve clarity. Remove dead code.
6249 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
6250 (Catch.Resolve): Resolve VarBlock if it exists.
6252 2006-04-19 Miguel de Icaza <miguel@novell.com>
6254 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
6255 twice, this was some residual code, the enumerator was emitted
6256 properly in the two branche of if later.
6258 2006-04-19 Raja R Harinath <rharinath@novell.com>
6260 * expression.cs (Cast.ResolveLValue): Remove. The result of a
6261 cast is never an lvalue.
6262 (Cast.DoResolve, Cast.ResolveRest): Combine.
6263 (Argument.Emit): Simplify slightly. Move 'Expr is
6264 IMemoryLocation' check ...
6265 (Argument.Resolve): ... here.
6266 (Argument.Error_LValueRequired): Remove. Inline into only user.
6268 Simplifications. Fix cs0191-2.cs
6269 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
6270 CS1649 and CS1651 to ...
6271 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
6272 the actual selection of the error code and message to a lookup
6273 table. Add a dummy return value to simplify callsites.
6274 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
6275 readonly fields of other instances of the same type. Move CS0197
6277 * expression.cs (Argument.Resolve): ... here. Simplify code.
6278 Ensure that ec.InRefOutArgumentResolving is only set during LValue
6279 resolution of an out or ref argument. The code simplification
6280 above uses this invariant.
6282 2006-04-18 Raja R Harinath <rharinath@novell.com>
6284 Possibly fix #77752. Fix cs1690-[4-7].cs.
6285 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
6286 CheckMarshallByRefAccess. Drop parameter.
6287 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
6289 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
6291 * report.cs (AllWarnings): Add CS1690.
6292 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
6294 (LocalVariableReference.DoResolveBase): Update.
6296 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6298 * class.cs (MethodOrOperator): Moved common parts from method class.
6299 detect obsolete attributes.
6300 (Method.Define): Simplified as it reuses code from base.
6301 (Constructor.ValidAttributeTargets): Fixed issue found during
6303 (Destructor.ValidAttributeTargets): Fixed issue found during
6305 (Operator): Finished refactoring set off by #78020. Operator class is now
6306 ordinary method class.
6308 * anonymous.cs: Updated.
6310 * decl.cs (DeclSpace): Add IsGeneric
6312 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6314 * class.cs (Constructor.Emit): Don't emit the attributes twice.
6316 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6318 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
6319 detect obsolete attributes.
6320 (Method.CreateEmitContext): Moved to MethodOrOperator.
6322 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6325 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
6326 customized exception to make crash detection easier.
6327 (MethodOrOperator): Started to work on new base class for methods and
6329 (Method): Derives from MethodOrOperator.
6330 (Constructor.Emit): Emits its own attributes.
6331 (AbstractPropertyEventMethod.Emit): Ditto.
6332 (Operator): Derives from MethodOrOperator, will refactor fully in extra
6334 (Operator.Emit): It's temporary more tricky than should be.
6336 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
6338 * report.cs (InternalErrorException): Add ctor with inner exception.
6340 2006-04-08 Marek Safar <marek.safar@seznam.cz>
6343 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
6346 2006-04-07 Marek Safar <marek.safar@seznam.cz>
6349 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
6352 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6354 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
6355 attribute is present and Guid not.
6356 (Interface.ApplyAttributeBuilder): Ditto.
6358 * attribute.cs: Add error message.
6360 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6364 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
6365 sources (it's composite) so hold them in extra array as they are used in
6366 Emit phase only. It worked in the previous versions by mistake.
6367 (Attribute.Emit): Emit attribute for more owners when exist.
6369 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
6370 it has now different behaviour.
6372 2006-04-04 Marek Safar <marek.safar@seznam.cz>
6374 * constant.cs (Constant.IsDefaultInitializer): New method.
6376 * class.cs: Updated.
6378 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
6379 re-initialize default values. It saves KBs almost for every assembly.
6380 Thanks Zoltan for the idea.
6381 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
6382 (ArrayCreation.DoResolve): Resolve only once.
6383 (ArrayCreation.Emit): Emit static initializer only when it is faster.
6384 (ArrayCreation.GetAttributableValue): Cope with optimized values.
6386 2006-04-03 Zoltan Varga <vargaz@gmail.com>
6388 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
6391 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6393 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
6394 in an embedded statement too.
6396 2006-04-01 Raja R Harinath <rharinath@novell.com>
6399 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
6401 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6405 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
6408 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
6410 2006-03-31 Marek Safar <marek.safar@seznam.cz>
6412 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
6415 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
6416 LocalTemporary change.
6418 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
6420 (ClassOrStruct.DefineFieldInitializers): Implemented static field
6421 initializers optimization.
6422 (ClassOrStruct.TypeAttr): Moved from modifiers.
6423 (Constructor.CheckBase): Don't crash when static ctor has parameters.
6424 (FieldBase.ResolveInitializer): Resolves initializer.
6425 (FieldBase.HasDefaultInitializer): New property.
6427 * cs-parser.jay: Removed message.
6429 * expression.cs (CompilerGeneratedThis): New specialization.
6431 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
6433 2006-03-28 Marek Safar <marek.safar@seznam.cz>
6435 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
6437 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6439 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
6440 be now EnumConstants only.
6442 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6444 * attribute.cs, driver.cs: Reset more caches.
6446 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6448 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
6450 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6452 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
6453 for easier reuse. Updated all overrides.
6454 (IntegralConstant): New base class for all integral constants.
6455 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
6456 of the constant range, report custom error.
6457 (UIntConstant.Reduce): Fixed uint conversion.
6459 * ecore.cs, literal.cs: Reduce updates.
6461 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6465 * class.cs (Constructor.Define): Removed extra if for default ctors.
6466 A patch from Atsushi Enomoto.
6468 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6470 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
6471 GetAttributableValue.
6473 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
6476 * convert.cs (ImplicitConversionRequired): Error message moved to
6479 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
6480 automatic implicit conversion of an output value.
6481 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
6483 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
6485 (TypeOf.GetAttributableValue): Add extra handling for object type.
6487 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
6488 special error message.
6490 2006-03-25 Marek Safar <marek.safar@seznam.cz>
6492 * class.cs (Constructor.Emit): Don't crash when struct ctor is
6494 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
6495 compatible with MS runtime.
6497 2006-03-23 Marek Safar <marek.safar@seznam.cz>
6499 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
6500 attribute arguments here.
6502 * class.cs (Indexer.Define): The check was moved to attribute class.
6504 2006-03-22 Marek Safar <marek.safar@seznam.cz>
6506 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
6507 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
6510 2006-03-22 Raja R Harinath <rharinath@novell.com>
6512 Support ParameterDefaultValueAttribute in gmcs. Also applied to
6513 mcs to keep code differences small.
6514 * attribute.cs (Attribute.GetParameterDefaultValue): New.
6515 * typemanager.cs (parameter_default_value_attribute_type): New.
6516 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
6519 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6521 * expression.cs (StringConcat.Append): Reverted back to no warning state.
6523 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6525 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
6527 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
6530 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
6532 * doc-bootstrap.cs : fix build.
6534 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6536 * expression.cs (StringConcat.Append): Issue a warning when empty string
6539 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6541 * assign.cs (CompoundAssign.ResolveSource): Removed.
6543 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
6546 * class.cs (TypeContainer.FindMethods): Removed.
6547 (TypeContainer.CheckMemberUsage): Made static.
6549 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
6551 * constant.cs (CheckRange): Removed unused type argument.
6552 (CheckUnsigned): Removed unused type argument.
6554 * cs-parser.jay: Updated after MemberAccess clean up.
6555 Uses Length for empty string test.
6557 * cs-tokenizer.cs: Uses Length for empty string test.
6558 (IsCastToken): Made static.
6559 (is_hex): Made static.
6560 (real_type_suffix): Made static.
6562 * decl.cs (SetupCache): Made static.
6563 (OnGenerateDocComment): Removed unused ds argument.
6565 * delegate.cs (VerifyDelegate): Removed unused argument.
6567 * doc.cs: Uses Length for empty string test.
6569 * driver.cs: Uses Length for empty string test.
6571 * enum.cs (IsValidEnumType): Made static
6573 * expression.cs (EnumLiftUp): Removed unused argument.
6574 (ResolveMethodGroup): Ditto.
6575 (BetterConversion): Ditto.
6576 (GetVarargsTypes): Ditto.
6577 (UpdateIndices): Ditto.
6578 (ValidateInitializers): Ditto.
6579 (MemberAccess.ctor): Ditto.
6580 (GetIndexersForType): Ditto.
6582 * flowanalysis.cs: (MergeFinally): Removed unused argument.
6584 * iterators.cs: Updated after MemberAccess clean up.
6586 * location.cs: Uses Length for empty string test.
6588 * namespace.cs: Uses Length for empty string test.
6590 * report.cs (CheckWarningCode): Made static.
6592 * statement.cs (LabeledStatement): Removed unused argument.
6594 * typemanager.cs (FilterNone): Removed.
6596 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6598 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
6601 * class.cs: Updated.
6603 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6605 * cs-parser.jay.cs: __arglist is not allowed for delegates.
6607 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6611 * expression.cs (VerifyArgumentsCompat): Reverted to double error
6612 reporting, it's more tricky than I thought.
6614 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6618 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
6620 (AnonymousMethod.ImplicitStandardConversionExists): New method.
6621 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
6622 Add more error reporting; Fixed issue with params.
6624 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
6626 * cs-parser.jay: AnonymousMethod requires host container.
6628 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
6630 2006-03-18 Raja R Harinath <harinath@gmail.com>
6632 * class.cs: Change 'TypeContainer ds' constructor argument to
6633 'DeclSpace parent'. Some classes were missed below due to
6634 different naming convention.
6636 * class.cs (MemberCore.Parent): Delete. This makes the
6637 ParentContainer changes below enforceable by the compiler.
6639 Treat pointers to enclosing declaration space as 'DeclSpace', not
6641 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
6642 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
6644 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
6646 (Block.AddThisVariable): Likewise.
6647 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
6648 (AbstractPropertyEventMethod.Emit): Likewise.
6649 (AbstractPropertyEventMethod.EmitMethod): Likewise.
6650 (GetMethod.Define, SetMethod.Define): Likewise.
6651 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
6652 (DelegateMethod.EmitMethod): Likewise.
6654 Fix regression test-partial-13.cs.
6655 Rationalize use of PartialContainer. Ensure that the partial
6656 class semantics can be tied to type-correctness, i.e., any
6657 violation will cause a compile error.
6658 * class.cs, const.cs: Access all fields that belong to class
6659 TypeContainer via ParentContainer. Arguments of EmitContexts and
6660 Resolve()-like functions still use 'Parent'.
6662 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
6663 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
6664 (PropertyMethod.CheckModifiers): Remove unused argument.
6665 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
6668 2006-03-17 Raja R Harinath <harinath@gmail.com>
6670 Make semantics of PartialContainer simpler.
6671 * decl.cs (DeclSpace.IsPartial): Remove.
6672 * class.cs (TypeContainer.IsPartial): Likewise.
6673 (TypeContainer..ctor): Set PartialContainer to point to self.
6674 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
6675 (TypeContainer.FindNestedType): Likewise.
6676 (MemberCore.ParentContainer): Simplify. Remove deprecation.
6678 2006-03-17 Marek Safar <marek.safar@seznam.cz>
6680 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
6682 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6684 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
6687 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6689 * class.cs (Operator.Define): An error for base conversion was not
6692 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
6694 * iterator.cs : yield break is allowed in try statement which has
6695 catch clauses. Fixed bug #77767.
6697 2006-03-13 Marek Safar <marek.safar@seznam.cz>
6699 A fix for #77593, #77574.
6701 * class.cs (MethodCore.CheckBase): Another if for operator.
6703 2006-03-09 Marek Safar <marek.safar@seznam.cz>
6705 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
6708 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
6709 (DelegateCreation.ImplicitStandardConversionExists): New method for just
6712 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
6715 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
6716 Updated after another emitcontext usage was clean up. It should help us to
6717 synchronize with gmcs easier.
6719 2006-03-04 Marek Safar <marek.safar@seznam.cz>
6723 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
6724 (Event.Define): ditto
6725 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
6727 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
6728 Removed redundant code and set NewSlot for Invoke method too.
6730 * parameter.cs (Parameters.ctor): Add custom, type ctor.
6731 (Parameters.MergeGenerated): New method. Use this method when you merge
6732 compiler generated argument with user arguments.
6734 2006-03-03 Marek Safar <marek.safar@seznam.cz>
6736 * attribute.cs (ResolveAsTypeTerminal): Removed.
6738 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
6739 specialization for predefined types; 30% speed up.
6740 Finally placed obsolete check to right place.
6741 (Expression.ResolveType): Removed.
6743 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
6744 Updated after ResolveType was removed.
6746 * expression.cs (Cast.ctor): Check void cast.
6747 (Binary.ResolveAsTypeTerminal): Is never type.
6748 (Conditional.ResolveAsTypeTerminal): Is never type.
6750 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
6752 2006-03-01 Raja R Harinath <rharinath@novell.com>
6755 * expression.cs (ParameterReference.DoResolveBase): Change return
6757 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
6761 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
6764 * typemanager.cs (GetFullNameSignature): Don't nullref on
6765 protected accessors.
6767 2006-02-27 Marek Safar <marek.safar@seznam.cz>
6769 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
6770 these two separated members to simplify the code.
6771 (Attribute.Resolve): Refactored to use new fields and methods.
6772 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
6773 implemented obsolete attribute checking.
6774 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
6775 implemented obsolete checking again. It look line never ending quest ;-)
6776 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
6778 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
6780 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
6782 *class.cs (Property.Define): Add RegisterProperty call.
6784 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
6785 argument groups (only 2).
6787 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
6788 encoding expression to arguments.
6789 (Expression.ExprClassToResolveFlags): Just turned to property.
6791 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
6792 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
6793 optimized as well as implemented support for zero-length attributes.
6795 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
6796 Add caching of PropertyInfo's.
6798 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6800 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
6801 error multiple times.
6803 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6805 New partial class implementation.
6806 A fix for #77027, #77029, #77403
6808 * attribute.cs (Attributable): Made attributes protected.
6810 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
6811 the replacements of ClassPart and PartialContainer.
6812 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
6813 (TypeContainer.AddInterface): Ditto.
6814 (TypeContainer.AddPartial): The main method for partial classes. It checks
6815 for errors and merges ModFlags and attributes. At the end class is added to
6817 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
6819 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
6820 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
6821 from the rest of partial classes.
6822 (TypeContainer.GetClassBases): Simplified.
6823 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
6825 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
6826 (TypeContainer.HasExplicitLayout): Uses Flags now.
6827 (PartialContainer): Removed.
6828 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
6829 (StaticClass): Was merged with Class.
6830 (Class.GetClassBases): class and static class bases are verified here.
6831 (Class.TypeAttr): Added static attributes when class is static.
6832 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
6833 (MemberBase): In some cases we need to call parent container for partial
6834 class. It should be eliminated but it's not easy now.
6836 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
6838 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
6839 partial classed to accumulate class comments.
6840 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
6842 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
6844 * driver.cs (MainDriver): Tree.GetDecl was removed.
6846 * modifiers.cs (Modifiers): Add partial modifier.
6848 * tree.cs (Tree.decl): Removed.
6849 (RootTypes): Started to use this class more often for root types
6852 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6856 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
6857 external interface does not have an attribute.
6859 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6861 Another prerequisites for new partial classs implementation.
6863 * attribute.cs (Attribute.Equal): Implemented.
6864 (Attribute.Emit): Changed as attributes can be applied more than twice.
6865 (Attributes.Emit): Check for duplicate attributes here.
6867 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
6868 as a parameter, clean-up.
6870 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6874 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
6875 contains obsolete attribute check which can in some cases look for base
6876 type of current class which is not initialized yet.
6877 (TypeContainer.BaseType): Replacement of ptype.
6879 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
6881 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6883 First of prerequisites for new partial classs implemention.
6885 * attribute.cs (Attributable): Extended by ResolveContext;
6886 Attributes finally have correct context for resolving in all cases.
6887 (AttachTo): Attribute owner is assigned here.
6889 * codegen.cs (IResolveContext): Introduce new interface to hold
6890 all information needed in resolving phase.
6891 (EmitContext): Implements IResolveContext; more clean-up needed here.
6893 * decl.cs (MemberCore): Implemented IResolveContext.
6895 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
6896 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
6897 parameter.cs, statement.cs, tree.cs, typemanager.cs:
6898 Refactored to use new IResolveContext instead of EmitContext; cleanup
6900 2006-02-06 Miguel de Icaza <miguel@novell.com>
6902 * codegen.cs (EmitScopeInitFromBlock): check here the
6903 capture_context, there is no need to make two calls to the
6906 * anonymous.cs: Add some debugging messages that might help me
6907 track other instances of this problem in the future (the
6908 regression of test 467).
6910 * cs-parser.jay: track the variable block, as we need to initalize
6911 any captured variables declared in this block for the "catch"
6912 portion of the "Try" statement.
6914 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
6915 scope initialization for captured variables.
6917 Also, move the emit for the variables after the block location has
6920 2006-02-06 Marek Safar <marek.safar@seznam.cz>
6922 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
6924 2006-02-02 Miguel de Icaza <miguel@novell.com>
6926 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
6927 commit yesterday, the initialization for the roots is necessary.
6928 What is not necessary is the scope activation.
6930 2006-02-02 Raja R Harinath <rharinath@novell.com>
6932 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
6933 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
6935 (Argument.Resolve): Remove CS0206 checks.
6937 2006-02-01 Miguel de Icaza <miguel@novell.com>
6939 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
6940 scopes for all the roots, the scopes will now be emitted when the
6941 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
6943 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
6944 code. This reduces a lot of existing cruft.
6946 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
6947 that the ScopeInfo is generated as we enter the scope, not at the
6948 time of use, which is what we used to do before.
6950 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
6951 every time a Block is about to be emitted if we have a
6954 2006-02-01 Raja R Harinath <rharinath@novell.com>
6956 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
6958 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
6960 * typemanager.cs (cons_param_array_attribute): Make private.
6961 (Reset): Set it to null.
6962 (InitCoreHelpers): Don't initialize it.
6963 (ConsParamArrayAttribute): New. Initialize it as needed.
6964 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
6966 2006-01-31 Miguel de Icaza <miguel@novell.com>
6968 * expression.cs: There might be errors reported during the
6969 selection of applicable methods. If there are errors, do not
6970 continue execution as it will lead the compiler to crash.
6972 2006-01-30 Miguel de Icaza <miguel@novell.com>
6974 * expression.cs: Member access is not allowed on anonymous
6975 methods. Fixes #77402.
6977 2006-01-30 Raja R Harinath <rharinath@novell.com>
6980 * cs-parser.jay (VariableDeclaration): Don't set
6981 current_array_type to null.
6982 (field_declaration, event_declaration, declaration_statement):
6983 Set it to null here.
6985 2006-01-28 Raja R Harinath <harinath@gmail.com>
6987 * typemanager.cs (GenericParameterPosition): New.
6990 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
6992 * doc.cs : To process "include" elements, first we should create
6993 another list than XmlNodeList, because it could result in node
6994 removal, which could result in that the XmlNodeList gives up
6997 (Also made code identical to gmcs again.)
6999 2006-01-25 Miguel de Icaza <miguel@novell.com>
7001 * ecore.cs: Introduce an error report that we were not catching
7002 before, if not silent, we must report the error. Gonzalo ran into
7005 2006-01-23 Miguel de Icaza <miguel@novell.com>
7007 A fix for bug: #76957
7009 * iterators.cs (MoveNextMethod.CreateMethodHost): call
7010 ComputeMethodHost before creating the method, this is a new
7013 * anonymous.cs (AnonymousContainer): Now we track all the scopes
7014 that this method references (RegisterScope). The actual scope
7015 where the method is hosted is computed with the ComputeMethodHost
7016 before we create the method.
7018 Moved the Deepest routine here.
7020 (AnonymousContainer.ComputeMethodHost): New routine used to
7021 compute the proper ScopeInfo that will host the anonymous method.
7023 (ScopeInfo): Deal with multiple roots. The problem was that we
7024 did not have a unique root where all ScopeInfos could be hanged
7025 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
7028 Remove AdjustMethodScope which is now computed at the end. Remove
7029 LinkScope which did a partial link, instead link all ScopeInfos
7030 before code generation from the new "LinkScopes" routine.
7032 Simplify all the Add* routines as they no longer need to maintain
7033 the tree, they just need to record that they are using variables
7036 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
7037 routines to produce the forest of ScopeInfo trees.
7039 * class.cs (TypeContainer.AppendMethod): This is just like
7040 AddMethod, but ensures that an interface implementation method
7041 (IEnumerable.XXX) is not inserted at the beginning of the queue of
7042 methods, but at the end.
7044 We use this functionality to ensure that the generated MoveNext
7045 method in the iterator class is resolved/emitted before the
7046 enumerator methods created.
7048 This is required because the MoveNext method computes the right
7049 ScopeInfo for the method. And the other methods will eventually
7050 need to resolve and fetch information computed from the anonymous
7053 2006-01-21 Raja R Harinath <harinath@gmail.com>
7054 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7057 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
7059 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
7060 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
7062 2006-01-18 Raja R Harinath <rharinath@novell.com>
7064 Fix #76656, cs0231-2.cs.
7065 * cs-parser.jay (formal_parameter_list): Make error case catch
7067 (parenthesized_expression_0): Add CS1026 check.
7068 (invocation_expression): Remove unused { $$ = lexer.Location }.
7070 2006-01-17 Raja R Harinath <rharinath@novell.com>
7073 * cs-parser.jay (statement_expression): Don't list out the
7074 individual statement-expressions. Convert syntax error into
7077 2006-01-16 Raja R Harinath <rharinath@novell.com>
7080 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
7081 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
7082 CheckIntermediateModification.
7083 (FieldExpr.DoResolve): Add new two-argument version that
7084 allows us to resolve the InstanceExpression as an lvalue.
7085 The one-argument variant is now just a wrapper.
7086 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
7087 Resolve the lhs as an lvalue if the it has a value type.
7088 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
7089 from Assign.DoResolve.
7090 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
7091 resolved as an lvalue.
7092 (PropertyExpr.DoResolve): Update.
7093 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
7094 has a value type. Move CS1612 check here from
7095 CheckIntermediateModification.
7096 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
7097 * expression.cs (EmptyExpression.OutAccess): New. Used as the
7098 'right_side' of a ResolveLValue on an 'out' argument.
7099 (EmptyExpression.LValueMemberAccess): New. Used as the
7100 'right_side' of a propagated ResolveLValue on a value type.
7101 (LocalVariableReference.DoResolveBase): Recognize
7102 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
7104 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
7105 EmptyExpression.Null.
7107 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
7109 * typemanager.cs : added IsGenericParameter(). In mcs it always
7111 * doc.cs : for generic parameters, use GenericParameterPosition,
7114 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
7116 * expression.cs: Fix Console.WriteLine ((this = x).foo);
7118 2006-01-12 Miguel de Icaza <miguel@novell.com>
7120 This fixes the problem where we used ldfld instead of ldflda to
7121 load the "THIS" pointer on captured parameters, when THIS is a
7122 value type. See bug #77205.
7124 * iterators.cs (CapturedThisReference.Emit): Pass false to
7125 EmitThis (we do not need the address).
7127 * codegen.cs (EmitThis): it needs to know whether we need the
7128 address of `this' or not. This is used by value types.
7130 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
7131 every other call passes false.
7133 2006-01-12 Raja R Harinath <rharinath@novell.com>
7136 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
7138 * expression.cs (Invocation.OverloadResolve): Update.
7139 (Invocation.DoResolve): Avoid double resolution of invocation.
7141 2006-01-11 Raja R Harinath <rharinath@novell.com>
7144 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
7145 unary negation of floating point types as 0-expr; negation cannot
7146 overflow in floating point types.
7149 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
7150 on operands of 'void' type.
7153 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
7154 and ExclusiveOr for boolean constants too.
7156 2006-01-09 Raja R Harinath <rharinath@novell.com>
7159 * expression.cs (Invocation.OverloadResolve): Replace reflected
7160 override methods with their base virtual methods, rather than
7162 * typemanager.cs (TypeManager.GetOverride): New.
7164 2006-01-05 Jb Evain <jbevain@gmail.com>
7166 * class.cs (Property.Define, Indexer.Define): do not tag the
7167 properties as SpecialName | RTSpecialName.
7169 2006-01-04 Miguel de Icaza <miguel@novell.com>
7171 * class.cs (MethodCore.IsDuplicateImplementation): This method was
7172 doing a low-level comparission of parameter types. It was lacking
7173 a check for __argslist.
7175 2005-12-30 Miguel de Icaza <miguel@novell.com>
7177 * expression.cs (ParameterReference.DoResolveBase): Allow
7178 reference parameters if they are local to this block.
7180 This allows the ref and out parameters of a delegate to be used in
7181 an anonymous method, for example:
7183 delegate void set (out int x);
7185 set s = delegate (out int x){
7189 This is used by functionality introduced late in the C# language.
7191 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
7192 method that take ref and out parameters.
7194 Fixes #77119 which was a late change in the spec.
7196 2005-12-23 Miguel de Icaza <miguel@novell.com>
7198 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
7199 parent if its the same scope. Fixes #77060.
7201 2005-12-21 Miguel de Icaza <miguel@novell.com>
7203 * driver.cs: Report the case of no source files and no -out:
7206 2005-12-20 Raja R Harinath <rharinath@novell.com>
7209 * expression.cs (ComposedCast.GetSignatureForError): Define.
7211 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7215 * namespace.cs (NamespaceEntry): Add extern_aliases as a
7216 ListDictionary, to contain the ExternAliasEntry entries (in
7217 addition to the NamespaceEntry.aliases hashtable). This field is
7218 shared between the original entry and its doppelganger (bodyless
7220 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
7221 extern_aliases field.
7222 (NamespaceEntry.Lookup): Move the IsImplicit check after the
7223 lookup in extern_aliases.
7225 2005-12-16 Raja R Harinath <rharinath@novell.com>
7228 * class.cs (TypeContainer.Mark_HasEquals): New.
7229 (TypeContainer.Mark_HasGetHashCode): New.
7230 (ClassPart): Override them.
7231 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
7234 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
7235 'parent' argument to the base constructor.
7237 Remove all mention of TypeContainer from decl.cs.
7238 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
7239 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
7240 (DeclSpace.DeclSpace): Likewise.
7241 (DeclSpace.DefineMembers): Remove unused argument.
7242 * cs-parser.jay (pop_current_class): Update to changes. Simplify
7243 debugging check -- we don't care if the debug code throws an
7244 InvalidCastException instead of an InternalErrorException.
7245 * class.cs (TypeContainer.DefineMembers): Update to changes.
7246 (TypeContainer.DoDefineMembers): Likewise.
7247 (TypeContainer.GetMethods): Likewise.
7248 (PropertyMember.Define): Likewise.
7249 (MemberBase.Parent): New property that forwards to
7250 MemberCore.Parent, but ensures that we get a TypeContainer.
7251 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
7252 (RootContext.PopulateTypes): Likewise. Remove special case code
7253 for !RootContext.StdLib: DefineMembers is idempotent.
7255 2005-12-14 Miguel de Icaza <miguel@novell.com>
7257 * convert.cs (ExplicitConversionCore): Check the return value from
7258 ExplicitConversionCore which can return null on failure. Fixes #76914
7260 2005-12-13 Marek Safar <marek.safar@seznam.cz>
7262 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
7264 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
7266 * doc.cs : The search for referenced namespace was insufficient to
7267 get global one as it used to do. Fixed bug #76965.
7269 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
7271 * doc.cs : check name in cref in the last phase that whether it is
7274 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7276 * cs-tokenizer.cs : reverted the latest change: it somehow broke
7279 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7281 * doc.cs : so it turned out that we cannot skip override check for
7282 interface members. Fixed bug #76954.
7284 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7286 * cs-tokenizer.cs : fixed bug #75984:
7287 - #warning and #error should not be handled when the source line
7289 - #line is not checked strictly when the source line is disabled.
7290 - #define and #undef is on the other hand checked strictly at any
7293 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
7295 * cs-tokenizer.cs : missing Location (actually, filename) in one of
7298 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7300 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
7302 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
7304 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
7305 (FieldBase.Initializer): Initializer is now optional.
7306 (EventField.Define): Only event field can have initializer.
7308 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
7310 * const.cs (Const): Reuse initializer.
7312 * cs-parser.jay: Updated after FieldBase changes.
7313 Added current_array_type to simplify array initializers.
7315 * ecore.cs (NullCast.IsDefaultValue): Implemented.
7317 * expression.cs, iterators.cs: Updated.
7319 * namespace.cs (NamespaceEntry): Made UsingFound private.
7321 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7323 * parameterCollection.cs: Obsolete, removed.
7324 * parser.cs: Obsolete, removed.
7326 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7329 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
7331 * enum.cs (Enum.Define): Set obsolete context here.
7333 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7336 - FindDocumentedMember() now expects 1) paramList as null
7337 when "we don't have to check the number of parameters" and
7338 2) Type.EmptyTypes when "there is no arguments".
7339 - Introduced FoundMember struct to hold the exact type which was
7340 used to find the documented member (the above change broke
7341 test-xml-044; it might be better just to use DeclaringType than
7342 what MS does, like this change does, but it depends on usage.)
7344 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7346 * doc.cs : documented member might be from DeclaringType for nested
7347 types. Fixed bug #76782.
7349 2005-12-03 Ben Maurer <bmaurer@ximian.com>
7351 * anonymous.cs: Have the param code handle leaving copies on the
7352 stack etc. Allows anonymous params to take part in the assignment
7353 code (++, +=, etc). Fixes bug #76550
7355 * expression.cs: Handle the prepare_for_load/leave_copy by passing
7356 it down to the anon code.
7358 * iterators.cs: Use dummy var here
7360 * codegen.cs: Handle new vars
7362 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7365 * class.cs (MethodData.Define): Set proper Obsolete context.
7367 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
7369 (FieldExpr.DoResolve): Ditto.
7371 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7374 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
7375 parent is not obsolete.
7377 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
7379 * doc.cs : (FindDocumentedMember) find parameterless members first
7380 and get CS0419 in the early stage. Fixed first case of bug #76727.
7382 2005-11-30 Marek Safar <marek.safar@seznam.cz>
7385 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
7386 no error was reported.
7388 *expression.cs (Binary.DoResolve): left can be null.
7390 2005-11-22 Marek Safar <marek.safar@seznam.cz>
7393 * class.cs (MethodData.Emit): Parameters should be labeled first.
7395 2005-11-21 Marek Safar <marek.safar@seznam.cz>
7398 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
7400 2005-11-18 Marek Safar <marek.safar@seznam.cz>
7402 * attribute.cs (AreParametersCompliant): Moved to Parameter.
7404 * class.cs (MethodCore): Parameter clean up.
7405 (IMethodData): Added ParameterInfo.
7406 (MethodData): Parameter clean up.
7407 (Indexer.Define): Parameter clean up.
7419 * typemanager.cs: Parameter clean up.
7421 * delegate.cs (Define): Get rid of duplicated code.
7423 * expression.cs (ParameterReference): Removed useless parameters
7425 (Invocation): Ditto.
7427 * parameter.cs (ParamsParameter): New class, params specialization.
7428 (ArglistParameter): Attemp to separate arglist.
7429 (Parameter): Refactored to be reusable and faster.
7430 (Parameter.Modifier): Made understandable.
7431 (Parameters): Changed to be used as a class for `this' assembly
7432 parameters. Refactored to use new specialized classes.
7434 * support.cs (ParameterData): Added Types property.
7435 (InternalParameters): Deleted.
7437 2005-08-20 Martin Baulig <martin@ximian.com>
7439 Merging this patch from GMCS to fix #75867.
7441 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7442 scope if we don't already have it.
7444 2005-11-17 Martin Baulig <martin@ximian.com>
7447 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
7448 inherit the scope from our parent. Fixes #76653.
7450 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7452 * doc.cs : the previous patch does not actually fix the bug.
7453 PropertyInfo override check is now implemented and really fixed it.
7454 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
7456 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7458 * doc.cs : apply "override filter" also to properties.
7461 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7463 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
7464 no need to check overrides. For classes, omit those results from
7465 interfaces since they must exist in the class. Fixed bug #76726.
7467 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7469 * typemanager.cs : (GetFullNameSignature) differentiate indexers
7470 with different parameters. Fixed the second problem in #76685.
7472 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7474 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
7475 get expected 'protected' access in CheckValidFamilyAccess()).
7478 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7480 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
7481 Fixed bug #76705. CS1569 was incorrectly commented out.
7483 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7485 * doc.cs : use Invocation.IsOverride() to do real override check.
7486 * expression.cs : made Invocation.IsOverride() internal.
7488 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7490 * doc.cs : use TypeManager.FindMembers() instead of (possible)
7491 TypeBuilder.FindMembers() and filter overriden base members out.
7494 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7496 * doc.cs : ref/out parameters are represented as '@' (instead of
7497 '&' in type FullName). Fixed bug #76630 (additionally crefs).
7499 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7501 * doc.cs : when there was no '.' in cref to methods in doc comment,
7502 then parameters were missing in the output. Fixed bug #76691.
7504 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7506 * driver.cs : don't output docs when there is an error.
7509 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7512 Now it should detect indexers. Fixed primary concern in bug #76685.
7513 Fixed CS0419 message to not show the identical member signature in
7516 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7518 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
7519 instead of Type.FindMembers() since it does not handle events.
7522 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
7524 * codegen.cs: Fixed typo (speficied -> specified).
7526 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7529 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
7531 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7533 * attribute.cs: Changed error message.
7535 * cs-tokenizer.cs: One more check.
7537 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7539 * statement.cs (Block.Resolve): Ignore empty statement.
7541 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7543 * report.cs: Made error/warning methods more strict to avoid
7546 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
7547 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
7548 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
7549 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
7551 2005-11-08 Marek Safar <marek.safar@seznam.cz>
7553 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
7554 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
7556 * class.cs (TypeContainer.IsComImport): New property.
7557 (Constructor.Define): Create proper ctor for ComImport types.
7559 * expression.cs (New.CheckComImport): Fixed.
7561 2005-11-07 Miguel de Icaza <miguel@novell.com>
7563 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
7564 that a parameter has been captured does not mean that we do not
7565 have to do the rest of the processing. This fixes the second part
7566 of #76592. If there was another anonymous method capturing
7567 values in the past, the Scope would never be set for the second
7568 method that captured the same parameter.
7570 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
7571 properly manipulate the stack. Second part of fix for #76592.
7573 * expression.cs (New): Add support for invoking "new" on
7574 interfaces that have been flagged with the ComImport attribute and
7575 the CoClass. Fixes #76637
7577 * statement.cs (Try.DoEmit): When a variable is captured, do not
7578 try to emit the vi.LocalBuilder variable as it has been captured.
7579 Create a temporary variable and store the results on the
7580 FieldBuilder. Fixes #76642
7582 2005-11-07 Marek Safar <marek.safar@seznam.cz>
7584 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
7586 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
7588 * expression.cs (Binary.DoResolve): Added && optimalization.
7590 * typemanager.cs (AddUserType): Removed useless argument.
7592 2005-11-04 Marek Safar <marek.safar@seznam.cz>
7594 * statement.cs (Block.variables): Uses ListDictionary.
7596 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7599 * class.cs (PartialContainer.EmitType): Customized to emit
7600 security attributes.
7601 (ClassPart.ApplyAttributeBuilder): Transform security attribute
7602 for partial classes.
7604 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7607 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
7608 access has to be fixed.
7610 * typemanager.cs (IsUnmanagedType): Wrong common field type.
7612 2005-11-01 Marek Safar <marek.safar@seznam.cz>
7615 * ecore.cs (NullCast.Reduce): Implemented.
7617 * expression.cs (ArrayCreation.CheckIndices): Correcly check
7620 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
7622 (Foreach.Resolve): Catch null properly.
7624 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7626 * cs-tokenizer.cs: Warning text fix.
7628 * driver.cs: AllWarningNumbers exposed on public interface.
7630 * report.cs (): Reviewed warning numbers.
7631 (IsValidWarning): Use binary search.
7633 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7635 * driver.cs: Implemeted resource visibility.
7636 (Resources): New class for code sharing between /res: and
7639 2005-10-28 Marek Safar <marek.safar@seznam.cz>
7642 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
7645 * convert (Convert.ImplicitReferenceConversion): NullCast holds
7648 * ecore.cs (NullCast): Child is contant only.
7650 * literal.cs (NullLiteral.Reduce): null can be converted to any
7653 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
7655 * driver.cs: Use Encoding.Default as default code page instead
7658 2005-10-27 Raja R Harinath <rharinath@novell.com>
7661 * expression.cs (Invocation.Error_InvalidArguments): Handle
7662 __arglist parameters.
7663 (Invocation.VerifyArgumentsCompat): Likewise.
7664 * support.cs (ReflectionParameters.GetSignatureForError): Print
7665 __arglist parameters.
7666 (InternalParamters.GetSignatureForError): Likewise.
7667 * parameter.cs (Parameters.GetSignatureForError): Likewise.
7669 2005-10-26 Marek Safar <marek.safar@seznam.cz>
7671 * attribute.cs (GetPropertyValue): Made public.
7673 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
7675 Add new property WrapNonExceptionThrows to handle 2.0 assembly
7677 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
7680 * driver.cs: Reflect method name change.
7682 * statement.cs (Try.Resolve): Warn when try has both general
7685 * typemanager.cs: runtime_compatibility_attr_type new predefined
7688 2005-10-26 Raja R Harinath <harinath@gmail.com>
7691 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
7692 treat it as an empty parameter list.
7694 2005-10-26 Raja R Harinath <rharinath@novell.com>
7697 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
7698 ResolveAsTypeStep silent.
7699 * statement.cs (Block.AddConstant): Mark block as used.
7700 (Block.ResolveMeta): Avoid piling on error messages
7701 if a constant initializer resolution fails.
7703 2005-10-25 Raja R Harinath <rharinath@novell.com>
7705 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
7707 (NamespaceEntry.VerifyAllUsing): New.
7708 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
7709 behaviour. Delegates actual resolution of alias to ...
7710 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
7711 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
7713 * driver.cs (Driver.MainDriver): Update.
7715 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
7716 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
7718 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
7720 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
7721 RootNamespace.DefineNamespacesForAll.
7723 2005-10-24 Raja R Harinath <harinath@gmail.com>
7725 * typemanager.cs (assemblies, external_aliases, modules)
7726 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
7727 (ComputeNamespaces, GetRootNamespace): Remove extra staging
7728 overhead. Move resposibility ...
7729 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
7730 * driver.cs, attribute.cs, codegen.cs: Update to changes.
7732 2005-10-23 Raja R Harinath <harinath@gmail.com>
7734 * namespace.cs (RootNamespace.all_namespaces): Renamed from
7735 cached_namespaces. Improve usage.
7736 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
7737 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
7738 Move from GlobalRootNamespace and simplify.
7739 (RootNamespace.Global): Make instance variable.
7740 (RootNamespace.RootNamespace): Add "alias name" parameter.
7741 (GlobalRootNamespace): Simplify drastically.
7742 (Namespace.Lookup): Don't use GetNamespace.
7743 * typemanager.cs (GetRootNamespace): Rename from
7744 ComputeNamespaceForAlias.
7745 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
7747 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7749 * anonymous.cs (AnonymousContainer): Don't crash when container
7752 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7754 * expression.cs (Binary.DoResolve): Warn when comparing same
7757 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7760 * expression.cs (Binary.DoResolve): It looks like there are no
7761 convetsion rules in enum context.
7763 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7765 Add support for extern alias qualifiers.
7766 * typemanager.cs: Move some LookupTypeReflection code
7767 to namespace.cs, to have cleaner code. Added some methods
7768 to help us keep track of the extern aliased references.
7769 * driver.cs: Add suport for extern alias assemblies on command
7770 line and check for their warnings/errors. Also keep track of the
7771 extern aliased assemblies.
7772 * namespace.cs: Move the global functionality of Namespace
7773 to GlobalRootNamespace/RootNamespace. Now the global namespace
7774 is GlobalRootNamespace.Globa. Also the code moved from
7775 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
7776 Finally added LocalAliasEntry (AliasEntry before) and
7777 ExternAliasEntry, to handle alias statements.
7778 * cs-parser.jay: Add support in the grammar for extern alias
7780 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
7781 Update callings to Namespace (now in GlobalRootNamespace).
7783 2005-10-18 Raja R Harinath <rharinath@novell.com>
7786 * class.cs (TypeContainer.DefineType): Move updating of
7787 topological sort earlier in the code.
7788 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
7790 2005-10-18 Marek Safar <marek.safar@seznam.cz>
7793 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
7795 * constant.cs (Constant.TryReduce): Moved from Cast class.
7796 (Reduce): Made little bit more OO and fixed missing conversions.
7798 * ecore.cs (Reduce): Implemented.
7799 (Binary.EnumLiftUp): New method to upgrade values to enum values.
7801 * literal.cs (Reduce): Implemented.
7803 * class.cs: Reverted Miguel's wrong commit.
7805 2005-10-14 Miguel de Icaza <miguel@novell.com>
7807 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
7809 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
7811 * cs-parser.jay, expression.cs : CS0214 was missing error location
7812 for constants. Fixed bug #76404.
7814 2005-10-11 Marek Safar <marek.safar@seznam.cz>
7817 * convert.cs (ExplicitConversionCore): Fixed object->enum
7820 2005-10-10 Raja R Harinath <rharinath@novell.com>
7822 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
7824 (PropertyExpr.EmitCall): Likewise.
7825 * expression.cs (Invocation.EmitArguments): Handle case where
7827 (Invocation.EmitCall): Avoid allocating temporary variable if
7828 there are no arguments.
7830 2005-10-07 Raja R Harinath <rharinath@novell.com>
7833 * convert.cs (ImplicitConversionStandard): Move conversion of
7834 void* to arbitrary pointer types ...
7835 (ExplicitConversionStandard): .. here.
7836 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
7837 error to always print typenames.
7839 2005-10-07 Raja R Harinath <rharinath@novell.com>
7841 * convert.cs (GetConversionOperator): Rename from
7842 GetConversionOperators. Move operator selection code from ...
7843 (UserDefinedConversion): ... here.
7845 2005-10-06 Marek Safar <marek.safar@seznam.cz>
7847 * convert.cs (ExplicitConversionCore): Removed duplicate enum
7850 2005-10-05 Marek Safar <marek.safar@seznam.cz>
7852 * assign.cs (Assign.DoResolve): Error method changed.
7854 * cfold.cs (DoConstantNumericPromotions): Error method changed.
7856 * const.cs (ResolveValue): Reset in_transit immediately.
7858 * constant.cs: Error method changed.
7860 * convert.cs: Removed useless location parameter.
7861 (ExplicitNumericConversion): Don't do double enum check.
7862 (ExplicitConversionCore): Renamed from ExplicitConversion.
7863 (ExplicitUnsafe): Extracted from ExplicitConversion.
7864 (ExplicitConversion): Uses for error reporting.
7866 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
7868 (ResolveBoolean): Uses common error method.
7869 (CastToDecimal): Get rid of ec.
7870 (CastFromDecimal): Optimized.
7871 (ConvCast): Get rid of ec.
7873 * enum.cs (ResolveValue): Reset in_transit immediately.
7874 (Emit): Return after first error.
7876 * expression.cs: Convert changes.
7878 * literal.cs: Error method changed.
7880 * statement.cs: Error method changed.
7882 2005-10-03 Raja R Harinath <rharinath@novell.com>
7884 * support.cs (SeekableStreamReader.Position): Don't error out when
7885 the requested position is just beyond the end of the current
7888 2005-09-28 Raja R Harinath <rharinath@novell.com>
7890 * support.cs (SeekableStreamReader): Simplify drastically. Don't
7891 try to keep in sync with the byte count of the underlying Stream.
7892 However, this limits us to a window size of 2048 characters: i.e.,
7893 the maximum lookahead of our lexer/parser can be 2048 characters.
7895 2005-09-28 Marek Safar <marek.safar@seznam.cz>
7898 * driver.cs: Fix compilation files with full root path.
7900 2005-09-25 Miguel de Icaza <miguel@novell.com>
7902 * report.cs (SymbolRelatedToPreviousError): Format the output so
7903 it does not use an open parenthesis that is never closed.
7905 * driver.cs: Follow coding guidelines
7907 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7910 * const.cs (Const.ResolveValue): Check for assigning non-null
7911 value to reference type.
7913 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7915 * anonymous.cs: Implemented ExprClassName.
7917 * assign.cs (Assign.DoResolve): Don't chrash when type is not
7920 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
7923 * class.cs (StaticClass.DefineContainerMembers): Report protected
7926 * codegen.cs: if(ed) PRODUCTION.
7928 * convert.cs (Error_CannotImplicitConversion): Better error
7931 * cs-parser.jay: More error checks.
7933 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
7935 * driver.cs (CSCParseOption): Enabled wrong option check.
7937 * ecore.cs (Expression.ExprClassName): Turned to property.
7938 (MemberExpr.CheckIntermediateModification): For checking boxed
7939 value types modification.
7941 * statement.cs (Fixed.Resolve): Expression type must be
7942 convertible to fixed type.
7943 (CollectionForeach.GetEnumeratorFilter,TryType):
7944 Small refactoring for easier error checking.
7946 2005-09-26 Marek Safar <marek.safar@seznam.cz>
7948 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
7951 * class.cs (GeneratedBaseInitializer): New class for customization
7952 compiler generated initializers.
7953 (MemberBase.DoDefine): Check Obsolete attribute here.
7954 (FieldMember.DoDefine): Ditto.
7956 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
7959 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
7960 (MemberCore.GetObsoleteAttribute): Removed argument.
7961 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
7962 (MemberCore.CheckObsoleteType): New helper.
7966 * statement.cs: Updates after MemberCore changes.
7968 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
7969 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
7971 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
7972 obsolete attribute for compiler construct.
7973 (As.DoResolve): Cache result.
7975 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
7977 2005-09-26 Raja R Harinath <rharinath@novell.com>
7980 * expression.cs (This.VerifyFixed): In a value type T, the type of
7981 'this' is T&, iow, 'this' is either an out or ref parameter. In a
7982 value type R, 'this' is treated as a value parameter.
7984 2005-09-22 Miguel de Icaza <miguel@novell.com>
7986 * statement.cs (Lock): Use the TemporaryVariable class instead of
7987 manually using local variables as those do not work when variables
7990 * ecore.cs: Moved the TemporaryVariable class from being a nested
7991 class inside Foreach to be a public class that can be employed in
7994 2005-09-19 Marek Safar <marek.safar@seznam.cz>
7996 * cs-parser.jay: interface_accessors replaced by
7997 accessor_declarations.
7999 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
8002 * statement.cs (GotoCase.Resolve): Convert null constant to
8004 (SwitchLabel.ResolveAndReduce): Ditto.
8005 (SwitchLabel.NullStringCase): Custom null stamp.
8006 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
8008 typemanager.cs (CSharpSignature): Don't skip first argument
8011 2005-09-18 Miguel de Icaza <miguel@novell.com>
8013 * driver.cs: Set InEmacs based on the environment variable EMACS.
8015 * location.cs (InEmacs): in this mode, do not report column
8016 location as it confuses Emacs.
8018 2005-09-16 Marek Safar <marek.safar@seznam.cz>
8020 * cfold.cs, constant.cs, convert.cs, ecore.cs,
8021 expression.cs, iterators.cs, literal.cs: Store constants and
8024 * class.cs (MemberBase.ShortName): Pass location.
8026 * cs-parser.jay: Some location fixes.
8028 * ecore.cs (Expression.Location): Made virtual.
8030 2005-09-05 Miguel de Icaza <miguel@novell.com>
8032 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
8033 if the underlying types are the same, otherwise we need to produce
8034 code that will do the proper cast.
8036 This was exposed by Marek's constant rewrite which produced
8037 invalid code for the call site:
8040 void Method (X v) {}
8044 This fixes test-49.cs
8046 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
8048 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
8049 Type/Object should be allowed as well. Fixed bug #75968.
8051 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
8053 * expression.cs : (Binary.DoResolve): when one is enum constant and
8054 another is constant 0, then return enum one *as enum type*.
8057 2005-09-02 Raja R Harinath <rharinath@novell.com>
8059 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
8063 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
8064 flow-branching for LocalVariableReferences in case we were invoked
8065 from a MemberAccess.
8066 * expression.cs (LocalVariableReference.VerifyAssigned): New.
8068 (LocalVariableReference.DoResolveBase): ... this.
8069 (MemberAccess.Resolve): Do the check that was disabled during
8072 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8075 (PartialContainer.Create): check abstract/sealed/static strictly
8076 but abstract/sealed can exist only at one side. Fixed bug #75883.
8078 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
8081 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
8082 specified, don't default to UnmanagedType.I4.
8084 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8086 * expression.cs : conditional operator should check possibly
8087 incorrect assign expression. Fixed bug #75946.
8089 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8091 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
8092 Reverting the change. gmcs is much complex than mcs on this matter.
8094 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8096 * cs-tokenizer.cs : To read another token ahead of the actual
8097 consumption, use new SavedToken and cache token instead of moving
8098 back the stream with SeekableStreamReader (it seemed problematic).
8100 driver.cs : Thus use StreamReader directly.
8101 * support.cs : Thus removed SeekableStreamReader.
8103 2005-08-30 Raja R Harinath <rharinath@novell.com>
8106 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
8107 (ScopeInfo.EmitScopeType): Use it to construct field names from
8108 names of captured locals.
8111 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
8112 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
8113 Pass 'target_type' to BoxedCast. Don't default to 'object'.
8114 (ExplicitConversion): Remove enum cases already handled by
8115 implicit conversion. Move implicit conversion check to the beginning.
8116 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
8117 * expression.cs (ArrayCreation.EmitDynamicInitializers):
8118 Don't treat System.Enum as a struct.
8120 2005-08-30 Jb Evain <jbevain@gmail.com>
8122 * attribute.cs: handles as expression in parameters.
8124 2005-08-30 Raja R Harinath <rharinath@novell.com>
8127 * class.cs (TypeContainer.VerifyClsName): Don't use a
8128 PartialContainer when verifying CLS compliance.
8129 (AbstractPropertyEventMethod): Set Parent here, ...
8130 (PropertyMethod): ... not here.
8132 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
8134 * attribute.cs : escaped attribute name should not be allowed to be
8135 resolved (e.g. @class as classAttribute). Fixed bug #75930.
8137 2005-08-29 Raja R Harinath <rharinath@novell.com>
8140 * convert.cs (ImplicitStandardConversionExists): Allow zero also
8141 when converting a long constant to unsigned long.
8142 * expression.cs (Invocation.OverloadResolve): Add sanity check to
8143 detect where IsApplicable and VerifyArgumentsCompat disagree.
8145 2005-08-29 Raja R Harinath <rharinath@novell.com>
8146 and Carlos Alberto Cortez <carlos@unixmexico.org>
8149 * class.cs (TypeContainer.CanElideInitializer): New helper.
8150 (TypeContainer.EmitFieldInitializers): Use it to determine if we
8151 can safely emitting the initializer of a field.
8153 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8155 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
8156 allowed inside a switch (without loop). Fixed bug #75433.
8158 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
8160 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
8161 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
8163 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8165 * driver.cs : kinda reverting the default encoding changes (not exact
8166 revert since I noticed that "codepage:reset" might not work fine).
8168 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8170 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
8171 Location. Now getter and setter store location correctly.
8172 (errors/cs0111-12.cs now reports the expected location.)
8174 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8176 * driver.cs : Use default encoding on the environment.
8177 Removed (now that) extra parameter for SeekableStreamReader.
8178 * support.cs : (SeekableStreamReader) third .ctor() argument for
8179 StreamReader is not required (always true). preamble size could
8180 be acquired in simpler and safe way.
8182 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
8184 * cs-parser.jay: report CS0642 at warning level 3
8185 and report CS0642 for an if else statement also
8186 fixes bug #74745. Patch by John Luke (and a bit
8188 Removed extra CS0642 warning check for "while",
8190 * statement.cs: In Block.Resolve(), CS0642 check
8191 is reimplemented to check a sequence of an empty
8192 statement and a block.
8194 Both fix bug #66777.
8196 2005-08-24 Marek Safar <marek.safar@seznam.cz>
8198 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
8199 detection until I fix it.
8201 * cs-tokenizer.cs: Changed error message.
8203 * cs-parser.jay: Fixed 2 error locations.
8205 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
8206 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
8209 * enum.cs (GetSignatureForError): Fixed.
8211 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
8215 * typemanager.cs (RegisterProperty): Removed.
8217 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
8219 2005-08-24 Raja R Harinath <rharinath@novell.com>
8222 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
8223 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
8225 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8227 * expression.cs : tiny fix is required for not warning positive ulong.
8230 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8232 * expression.cs : add CS0652 check for constant and integral
8233 expression. Fixed bug #53974.
8235 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8237 * expression.cs : in DoNumericPromotions(), check if there is implicit
8238 conversion overload for string (to check CS0034). Fixed bug #52492.
8240 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8242 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
8244 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8246 * ecore.cs : report location when it is *not* Null.
8248 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8254 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
8255 correctly. Fixed bug #75721.
8257 2005-08-23 Raja R Harinath <rharinath@novell.com>
8259 * support.cs (SeekableStreamReader.Position): Avoid an expensive
8260 loop that performs 'min (pos, char_count)'.
8263 * expression.cs (Unary.ResolveOperator): Don't discard implicit
8264 converted value in Operator.OnesComplement.
8266 2005-08-22 Ben Maurer <bmaurer@ximian.com>
8268 * anonymous.cs: If the anon method is pulled into a helper class,
8269 it needs to be `internal' not `private'. Fixes runtime behavior on
8272 2005-08-20 Martin Baulig <martin@ximian.com>
8274 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
8275 scope if we don't already have it.
8277 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
8278 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
8281 2005-08-17 Marek Safar <marek.safar@seznam.cz>
8284 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
8287 2005-08-16 Marek Safar <marek.safar@seznam.cz>
8289 The big constants rewrite
8290 Fix #75746, #75685 and more
8291 As a side effect saved 1MB for MWF ;-)
8293 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
8294 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
8295 enum based for corlib compilation.
8297 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
8300 * class.cs (FixedField.Define): Use ResolveAsConstant.
8302 * const.cs (IConstant): Interface constants and enums.
8303 (Const.ResolveValue): New method for constant resolvning.
8304 (ExternalConstant): Constants from imported assemblies.
8306 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
8307 conversion; like enums.
8308 (Constant.ToType): Converts this constant to different type.
8309 (Constant.Increment): Adds 1.
8311 * convert.cs (ImplicitConversionRequired): Simplified.
8313 * cs-parser.jay: Create EnumMember directly.
8315 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
8317 * doc.cs (GenerateEnumDocComment): Removed.
8319 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
8320 (ConvertIntLiteral): Removed.
8321 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
8323 * enum.cs (EnumMember): Implement IConstant.
8324 (Enum.IsValidEnumConstant): Removed.
8325 (Enum.GetNextDefaultValue): Removed.
8326 (Enum.FindMembers): Updated.
8327 (Enum.GenerateDocComment): Iterate enum members.
8329 * expression.cs (Cast.TryReduce): Handle enums correctly.
8330 (New.Constantify): Made public.
8331 (MemberAccess.DoResolve): Removed contant specific if(s).
8333 * literal.cs (NullLiteral): Implement new abstract methods.
8335 * statement.cs (GotoCase.Resolve): Use new constant methods.
8336 (SwitchLabel.ResolveAndReduce): Use new constant methods.
8338 * typemanager.cs (LookupEnum): Removed.
8339 (IsEnumType): Fixed to work with corlib.
8340 (RegisterConstant): Removed.
8341 (LookupConstant): Removed.
8342 (GetConstant): Changed to work with IConstant.
8344 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
8346 * location.cs : Fixed overflown (>255) column number.
8348 2005-08-03 Raja R Harinath <rharinath@novell.com>
8350 First cut of the qualified-alias-member feature.
8351 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
8353 * cs-parser.jay (DOUBLE_COLON): New token.
8354 (namespace_or_type_name): Add rule for recognizing
8355 qualified-alias-members.
8356 (primary_expression): Likewise.
8357 (element_access): Allow QualifiedAliasMember as a possible
8358 type-bearing expression.
8359 (local_variable_type, local_variable_pointer_type): Likewise.
8360 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
8361 aliases in the current and enclosing namespace declarations.
8362 (NamespaceEntry.UsingAlias): Add CS0440 warning.
8363 * decl.cs (MemberName.is_double_colon): New.
8364 (MemberName.MemberName): Add new constructor for alias-member.
8365 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
8366 * expression.cs (QualifiedAliasMember): New expression type.
8368 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8370 * location.cs : it borked when no argument was specified.
8372 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8374 * location.cs : tiny ToString() format fix.
8376 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8378 * statement.cs : oops, it was missing.
8380 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8382 A set of fixes for precise line/column location.
8385 "token" field now holds a file/line "delta", a line number offset
8386 from the segment, and a column number. See also:
8387 http://lists.ximian.com/pipermail/mono-devel-list/2004-
8388 December/009508.html
8389 Removed static IsNull. Use instance IsNull property instead.
8391 For some tokens it stores Location. For Identifier it stores
8392 LocatedToken which is a pair of string name and location.
8393 Column numbers are adjusted only at getChar().
8395 Use Location.ToString() for reporting (it now contains column).
8397 Largely modified to use LocatedToken instead of
8398 string (IDENTIFIER), and to acquire Location from some tokens.
8399 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
8400 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
8402 Now MemberName holds Location. DeclSpace.ctor() receives Location
8403 as a parameter. Removed extra parameters to all derived classes.
8404 Replaced Location.IsNull() with instance property.
8405 * assign.cs, expression.cs :
8406 Added .ctor() overload that omits Location.
8408 Added "nameEscaped" flag that indicates the identifier was escaped
8409 in the source file. This fixes bug #57047.
8411 2005-08-02 Marek Safar <marek.safar@seznam.cz>
8413 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
8414 New method, looking for lo-case imported cls type.
8416 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
8419 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
8421 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
8423 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
8425 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
8427 Optimized to save 3.5 MB for SWF compilation.
8429 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8431 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
8432 (PartialContainer.Create): Moved logic AddToContainer.
8433 (PartialContainer.MarkForDuplicationCheck): Shares name.
8435 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
8438 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
8440 (Namespace.GetSignatureForError): New method.
8442 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
8443 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
8445 2005-08-01 Raja R Harinath <rharinath@novell.com>
8448 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
8449 member lookup rather than qualifier_type, since qualifier_type can
8452 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8454 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
8457 2005-07-31 Miguel de Icaza <miguel@novell.com>
8459 * statement.cs: Copy the local exception into the exception
8460 captured local. Fixes 75674
8462 2005-07-31 Raja R Harinath <harinath@gmail.com>
8465 * expression.cs (Invocation.OverloadResolve): Don't report error
8466 CS1501 if error CS1502 has been reported.
8467 (New.DoResolve): Delegate CS1501 reporting to
8468 Invocation.OverloadResolve.
8471 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
8472 invariant-meaning-in-block property in an enclosing block if
8475 2005-07-29 Marek Safar <marek.safar@seznam.cz>
8477 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
8478 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
8479 (Switch.CheckSwitch): Just save 50kb for SWF.
8481 2005-07-27 Martin Baulig <martin@ximian.com>
8483 * anonymous.cs (CaptureContext.AddField): Added
8484 `AnonymousContainer am' argument; compute its toplevel scope if
8485 it's not already computed. Fixes #75649.
8487 2005-07-26 Raja R Harinath <rharinath@novell.com>
8490 * class.cs (Constructor.Emit): Reset block to null if the block
8493 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8495 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
8497 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8499 * class.cs (MethodData.Define): Check whether accessor implementing
8500 interface is public.
8502 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
8504 2005-07-22 Marek Safar <marek.safar@seznam.cz>
8507 * namespace.cs (LookupType): Moved same type check to...
8509 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
8512 2005-07-21 Raja R Harinath <rharinath@novell.com>
8514 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
8515 already found a typebuilder.
8516 * class.cs (MethodCore.IsDuplicateImplementation): Compare
8517 MemberNames, not strings.
8519 * const.cs (Error_ExpressionMustBeConst):
8520 Rename from Error_EpressionMustBeConst.
8521 * const.cs, class.cs, statement.cd: Update.
8523 2005-07-21 Marek Safar <marek.safar@seznam.cz>
8527 * const.cs (Const.LookupConstantValue): Report missing contant expression
8529 (Error_EpressionMustBeConstant): Only one error method.
8531 * class.cs, statement.c: Updated.
8533 2005-07-20 Raja R Harinath <rharinath@novell.com>
8535 * statement.cs (Block.Flags): Add back HasVarargs.
8536 (Block.flags): Make protected.
8537 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
8539 * typemanager.cs (types, typecontainers, user_types): Remove.
8540 (UserTypes, TypeContainers): Likewise.
8541 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
8542 (CleanUp, Reset): Update.
8543 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
8544 (GetNestedType): Use Type.GetNestedType.
8545 (CoreLookupType): Take two arguments, the namespace and the
8546 basename of the type. Update to use the Namespace.Lookup
8548 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
8549 (RealMemberLookup): Use IsNestedChildOf instead of playing with
8550 string concatenation and substring matches.
8551 * class.cs, enum.cs, delegate.cs: Update to changes.
8553 2005-07-20 Marek Safar <marek.safar@seznam.cz>
8555 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
8556 Expression and made virtual.
8558 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
8559 (ImplicitStandardConversionExists): Fixed `byte' typo ?
8561 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
8563 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
8566 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
8569 2005-07-18 Marek Safar <marek.safar@seznam.cz>
8572 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
8573 AssemblyCultureAttribute is not used on executable.
8576 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
8578 2005-07-16 Raja R Harinath <rharinath@novell.com>
8581 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
8582 New. Reports CS0252/CS0253.
8583 Mostly taken from preliminary patch by Duncak Mak.
8584 (Binary.DoResolveOperator): Store results of operator lookup.
8585 Use them to detect if we need to warn about unintended reference
8588 2005-07-15 Raja R Harinath <rharinath@novell.com>
8591 * namespace.cs (Namespace.Lookup): Add back location parameter.
8592 (Namespace.LookupType): Add CS0436 report. Add location parameter.
8593 * delegate.cs, ecore.cs, expression.cs: Update to changes.
8595 * codegen.cs (EmitContext.DeclSpace): Make readonly.
8596 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
8597 (Namespace.LookupType): ... this.
8598 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
8600 * typemanager.cs (LookupTypeReflection): Remove buggy code that
8601 purported to handle pointers.
8602 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
8605 2005-07-15 Marek Safar <marek.safar@seznam.cz>
8607 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
8610 2005-07-15 Raja R Harinath <rharinath@novell.com>
8612 * namespace.cs (Namespace.Lookup): Drop location parameter.
8613 (NamespaceEntry.LookupAlias): Remove. Merge into ...
8614 (NamespaceEntry.Lookup): ... this.
8615 (NamespaceEntry.Error_AmbiguousTypeReference):
8616 Move here from DeclSpace.
8617 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
8619 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
8620 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
8621 Move to NamespaceEntry.
8622 * delegate.cs, expression.cs: Update to changes.
8624 2005-07-14 Marek Safar <marek.safar@seznam.cz>
8626 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
8627 CheckAttributeType and refactored.
8628 (Attribute.ResolvePossibleAttributeType): Changed to reuse
8629 ResolveAsTypeTerminal error handling.
8630 (ResolveAsTypeTerminal): Introduced because of global attributes extra
8632 (GetSignatureForError): Print errors in same way.
8635 * codegen.cs: Reflect attribute GetSignatureForError change.
8638 * expression.cs: Add silent parameter to ResolveAsTypeStep.
8640 * namespace.cs (UsingEntry): Refactored to make fields private.
8643 statement.cs: Error_UnexpectedKind has extra parameter.
8645 2005-07-14 Raja R Harinath <rharinath@novell.com>
8647 * ecore.cs (IAlias): Remove.
8648 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
8649 that implement the interface.
8650 * namespace.cs (Namespace): Likewise.
8651 (Namespace.declspaces): Renamed from 'defined_names'.
8652 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
8653 DeclSpace instead of an IAlias.
8654 * tree.cs (Tree.AddDecl): Update.
8656 2005-07-12 Raja R Harinath <rharinath@novell.com>
8658 * statement.cs (Block.Flags); Remove HasVarargs.
8659 (Block.HasVarargs): Move to ToplevelBlock.
8660 (Block.ThisVariable, Block.AddThisVariable): Likewise.
8661 (Block.Variables): Make protected. Initialize variable hashtable
8663 (Block.AddVariable): Update.
8664 (Block.Resolve): Update to changes.
8665 (ToplevelBlock.HasVarargs): New boolean.
8666 (ToplevelBlock.ThisVariable): Move here from Block.
8667 (ToplevelBlock.AddThisVariable): Likewise.
8668 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
8669 * expression.cs (This.ResolveBase): Update to changes.
8670 (ArglistAccess.DoResolve): Likewise.
8672 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8675 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
8677 * class.cs (TypeContainer.VerifyMembers): Distinguish between
8678 not used and not used & assigned.
8679 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
8681 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8684 * expression.cs (Is.DoResolve): null is never provided type.
8686 2005-07-08 Marek Safar <marek.safar@seznam.cz>
8689 * cs-parser.jay: Less strict event error rule to catch more errors.
8691 2005-07-08 Martin Baulig <martin@ximian.com>
8693 Fix test-iter-10.cs - distinguish whether we `yield' in a property
8694 gettter (allowed) or setter (not allowed).
8696 * class.cs (Accessor): Implement IIteratorContainer.
8697 (Accessor.Yields): New public field.
8698 (PropertyBase.PropertyMethod.Define): Handle iterators on a
8702 (get_accessor_declaration, set_accessor_declaration): Set the
8703 `yields' flag on the accessor, not the property.
8704 (property_declaration): Do the iterators check on a per-accessor
8705 basis and not for the whole property.
8707 2005-07-08 Martin Baulig <martin@ximian.com>
8709 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
8710 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
8712 2005-07-07 Marek Safar <marek.safar@seznam.cz>
8715 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
8716 (ExtractSecurityPermissionSet): Cope with self referencing security
8717 attributes properly.
8719 * driver.cs (SetOutputFile): Made public property OutputFile.
8721 2005-07-07 Raja R Harinath <rharinath@novell.com>
8724 * class.cs (TypeContainer.first_nonstatic_field): Rename from
8725 has_nonstatic_fields. Make into a FieldBase pointer.
8726 (TypeContainer.AddField): Add CS0282 check.
8727 (TypeContainer.EmitType): Update.
8729 2005-07-06 Miguel de Icaza <miguel@novell.com>
8731 * cs-tokenizer.cs (consume_identifier): Do not create strings to
8732 compare if they start with __.
8734 2005-07-06 Raja R Harinath <rharinath@novell.com>
8736 * statement.cs (Switch.SwitchGoverningType): Only look at
8737 UserCasts that don't need implicit standard conversions to one of
8738 the allowed switch types (Fixes test-322.cs).
8739 (LocalInfo.Resolve): Re-enable sanity-test.
8741 2005-07-06 Marek Safar <marek.safar@seznam.cz>
8743 * cs-tokenizer.cs (consume_identifier): Detect double undescores
8745 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
8747 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
8749 2005-07-06 Raja R Harinath <rharinath@novell.com>
8752 * ecore.cs (SimpleName.GetSignatureForError): Add.
8753 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
8754 (MemberAccess.GetSignatureForError): Add.
8756 2005-07-05 Marek Safar <marek.safar@seznam.cz>
8758 The big error and warning messages review.
8788 * typemanager.cs: Updated.
8790 * class.cs: (MethodCore.SetYields): Moved here to share.
8791 (PropertyMethod.Define): Moved iterator setup here.
8793 * iterators.cs: Add orig_method to have full access to parent
8796 2005-07-05 Raja R Harinath <rharinath@novell.com>
8798 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
8799 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
8800 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
8801 variable of struct type.
8802 * expression.cs (Unary.ResolveOperator): Update to change.
8803 (Indirection.VerifyFixed): Likewise.
8804 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
8805 (ParameterReference.VerifyFixed): Value parameters are fixed.
8806 (This.VerifyFixed): Treat 'this' as a value parameter.
8807 * statement.cs (LocalInfo.IsFixed): Remove.
8809 2005-07-01 Martin Baulig <martin@ximian.com>
8811 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
8812 `ec.EmitThis ()' to get the correct scope.
8814 2005-07-01 Martin Baulig <martin@ximian.com>
8816 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
8817 instance is a ParameterReference; fixes #75299.
8819 2005-07-01 Martin Baulig <martin@ximian.com>
8821 Reverted Marek's latest patch (r46725):
8822 - it contains structural changes which are neither mentioned in
8823 the ChangeLog nor explained anywhere; for example the additional
8824 argument of EmitContext's and Iterator's .ctor's and the
8825 TypeContainer.DefineMembers() change.
8826 - structural changes like this should go in in seperate patches
8827 and not be hidden in a huge patch which just seems to affect
8828 warnings and errors.
8829 a big and hard to understand patch.
8830 - it breaks iterators and causes regressions, for instance in
8833 2005-06-30 Raja R Harinath <rharinath@novell.com>
8836 * expression.cs (Indexers.map): Remove.
8837 (Indexers.Append): Filter out inaccessible setters and getters.
8838 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
8841 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
8843 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
8844 (FieldExpr.Emit, PropertyExpr.Emit): Update.
8845 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
8846 * expression.cs (Invocation.EmitCall): Add CS0120 check.
8848 2005-06-30 Marek Safar <marek.safar@seznam.cz>
8851 * class.cs (FieldBase.GetInitializerExpression): One more field
8854 2005-06-28 Miguel de Icaza <miguel@novell.com>
8856 * pending.cs: Do not define a proxy if the base method is virtual,
8857 it will be picked up by the runtime (bug 75270).
8859 2005-06-08 Martin Baulig <martin@ximian.com>
8861 The big Iterators rewrite :-)
8863 * iterators.cs: Rewrite this to use the anonymous methods framework.
8865 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
8866 before the TypeContainers; see 2test-21.cs.
8869 (TypeContainer.DefineType): Don't create a new EmitContext if we
8870 already have one (this only happens if we're an Iterator).
8871 (TypeContainer.Define): Also call Define() on all our iterators.
8872 (Method.CreateEmitContext): Added support for iterators.
8875 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
8876 (AnonymousContainer.CreateMethodHost): Moved here from
8877 AnonymousMethod and made abstract.
8878 (AnonymousContainer.CreateScopeType): New abstract method.
8879 (AnonymousContainer.IsIterator): New public property.
8880 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
8881 get the ScopeTypeBuilder rather than manually defining it here.
8882 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
8885 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
8886 before RootContext.DefineTypes().
8888 * codegen.cs (EmitContext.RemapToProxy): Removed.
8889 (EmitContext.CurrentAnonymousMethod): Changed type from
8890 AnonymousMethod -> AnonymousContainer.
8891 (EmitContext.ResolveTopBlock): Protect from being called twice.
8892 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
8893 (EmitContext.EmitThis): Removed the iterators hacks; use the
8894 anonymous methods framework for that.
8897 (ToplevelBlock.Container): Make this a property, not a field.
8898 (ToplevelBlock.ReParent): New public method; move the
8899 ToplevelBlock into a new container.
8900 (Foreach.TemporaryVariable): Simplify.
8902 2005-06-05 Martin Baulig <martin@ximian.com>
8904 * statement.cs (LocalInfo.CompilerGenerated): New flag.
8905 (Block.AddTemporaryVariable): New public method; creates a new
8906 `LocalInfo' for a temporary variable.
8907 (Block.EmitMeta): Create the LocalBuilders for all the temporary
8909 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
8910 non-iterator variables.
8912 2005-06-05 Martin Baulig <martin@ximian.com>
8914 * statement.cs (Foreach.TemporaryVariable): Create the
8915 LocalBuilder in the Emit phase and not in Resolve since in some
8916 situations, we don't have an ILGenerator during Resolve; see
8917 2test-19.cs for an example.
8919 2005-06-04 Martin Baulig <martin@ximian.com>
8921 **** Merged r45395 from GCS ****
8923 The big Foreach rewrite - Part II.
8925 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
8926 with `PropertyInfo ienumerator_getcurrent'.
8928 * codegen.cs (VariableStorage): Removed.
8931 (Foreach): Derive from Statement, not ExceptionStatement.
8932 (Foreach.CollectionForeach): New nested class. Moved all the code
8933 dealing with collection foreach here.
8934 (Foreach.ForeachHelperMethods): Removed.
8935 (Foreach.TemporaryVariable): Implement IMemoryLocation.
8937 2005-05-23 Martin Baulig <martin@ximian.com>
8939 * statement.cs (Try.DoResolve): Don't create a `finally' if we
8940 don't need to. Fix #75014.
8942 2005-05-20 Martin Baulig <martin@ximian.com>
8944 Merged r44808 from GMCS.
8946 * class.cs (TypeContainer.CircularDepException): Removed.
8947 (TypeContainer.DefineType): Removed the `InTransit' stuff.
8948 (TypeContainer.CheckRecursiveDefinition): Check for circular class
8949 (CS0146) and interface (CS0529) dependencies here.
8951 2005-06-21 Raja R Harinath <rharinath@novell.com>
8953 * expression.cs (Invocation.EmitCall): Fix initialization
8954 'this_call' to reflect current behaviour. Fix indentation.
8956 * convert.cs (FindMostEncompassedType): Add two trivial special
8957 cases (number_of_types == 0 || number_of_types == 1).
8958 (FindMostEncompasingType): Likewise.
8960 2005-06-17 Raja R Harinath <rharinath@novell.com>
8962 Some cleanups preparing for the fix of #75283.
8963 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
8965 (EventExpr.InstanceResolve): Likewise.
8966 (EventExpr.DoResolve): Remove redundant checks.
8968 2005-06-10 Duncan Mak <duncan@novell.com>
8970 * cs-tokenizer.cs (process_directives): New flag for controlling
8971 the processing of preprocessor directives.
8972 (x_token): After seeing a '#', return Token.NONE instead of going
8973 to handle_preprocessing_directive() when not processing
8974 directives. This avoids unnecessary processing during the token peek in
8979 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
8980 the existing error reporting methods instead of Report.Error.
8982 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
8983 after Raja's rewrite.
8985 2005-06-08 Miguel de Icaza <miguel@novell.com>
8987 * class.cs: Small fix.
8989 2005-06-08 Raja R Harinath <rharinath@novell.com>
8992 * class.cs (GetPartialBases): Fix return value check of
8995 2005-06-07 Raja R Harinath <rharinath@novell.com>
8997 Ensure that partial classes are registered in their enclosing
8998 namespace. Initial part of fix of #75160.
8999 * tree.cs (Tree.RecordDecl): Add new namespace argument.
9000 Register declspace with namespace here, not in
9001 DeclSpace.RecordDecl.
9002 * cs-parser.jay: Pass namespace to RecordDecl.
9003 * class.cs (PartialContainer.Create): Likewise.
9004 (ClassPart.DefineType): New sanity-check. Throws an exception if
9006 * decl.cs (Declspace.RecordDecl): Remove.
9007 * namespace.cs (NamespaceEntry.DefineName): Remove.
9009 2005-06-06 Marek Safar <marek.safar@seznam.cz>
9011 * rootcontext.cs: Reset TargetExt as well.
9013 2005-06-03 Raja R Harinath <rharinath@novell.com>
9015 * ecore.cs (Expression.Resolve): Emit CS0654 error when
9018 2005-06-02 Raja R Harinath <rharinath@novell.com>
9020 Fix #75080, cs0119.cs.
9021 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
9023 (Expression.Resolve): ... this. Use it. Remove bogus code
9024 allowing ExprClass.Type and ExprClass.Namespace for
9025 ResolveFlags.VariableOrValue.
9026 (Expression.Resolve) [1-argument variant]: Change default resolve
9027 flags based on language version.
9028 (Expression.Error_UnexpectedKind): Use a simple string array
9029 rather than an ArrayList.
9030 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
9032 (TypeOfVoid.DoResolve): Likewise.
9033 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
9034 flags argument -- it always has the same value.
9036 2005-05-31 Raja R Harinath <rharinath@novell.com>
9039 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
9040 Use it in the error message.
9041 * assign.cs, expression.cs, statement.cs: Update.
9043 2005-05-30 Raja R Harinath <rharinath@novell.com>
9046 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
9047 the "almostMatchedMember" case too.
9048 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
9049 that failed the accessibility checks to 'almost_match'.
9051 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
9053 * attribute.cs: Use internal MethodBuilder methods to set
9054 ExactSpelling and SetLastError on PInvoke methods, instead
9055 of passing them via charset. Fixes #75060.
9057 2005-05-27 Raja R Harinath <rharinath@novell.com>
9059 * parameter.cs (Parameter): Remove TODO comment.
9060 (Parameter.DefineParameter): Remove Location parameter.
9061 (Parameters.LabelParameters): Likewise.
9062 * class.cs (Constructor.Emit): Update to change.
9063 (MethodData.Emit): Likewise.
9064 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
9065 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
9067 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
9070 Removed Parameters.Location and added Parameter.Location instead.
9071 Removed Location parameter from Emit() and GetSignature().
9078 Modified all related calls.
9080 2005-05-26 Raja R Harinath <rharinath@novell.com>
9082 Improve user-defined conversion handling.
9083 * convert.cs (GetConversionOperators): Rewrite. Return only the
9084 applicable operators.
9085 (AddConversionOperators): New. Helper for GetConversionOperators.
9086 (FindMostEncompassedType, FindMostEncompassingType): Verify that
9087 there is only one most encompassed/encompassing type.
9088 (FindMostSpecificSource, FindMostSpecificTarget): Remove
9089 "applicable operator" handling.
9090 (UserConversion): Move cache here from GetConversionOperators.
9091 Directly cache the chosen operator, rather than the whole
9093 (ExplicitNumericConversion): Fix buggy implementation of Decimal
9094 case. Allow conversion of decimal to sbyte and byte too.
9095 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9096 New static methods. Used to avoid allocating EmptyExpressions in
9099 2005-05-24 Duncan Mak <duncan@novell.com>
9101 * ecore.cs (CastFromDecimal): New class for casting a decimal to
9102 another class, used in Convert.ExplicitNumericConversion.
9103 (CastToDecimal): New class, similar to above, but casts to
9104 System.Decimal, used in Convert.ImplicitNumericConversion and also
9105 in explicit convesion from double/float to decimal.
9107 * convert.cs (ImplicitNumericConversion): Handle implicit
9108 conversions to System.Decimal.
9109 (ExplicitNumericConversion): handle explicit conversions to
9114 2005-05-20 Miguel de Icaza <miguel@novell.com>
9116 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
9117 know the type at this stage, just break through. Fixes #75008
9119 2005-05-19 Martin Baulig <martin@ximian.com>
9122 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
9123 to disable error reporting.
9125 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
9126 here since we don't want to report an error; see the new test-336.cs.
9128 2005-05-19 Raja R Harinath <rharinath@novell.com>
9130 * statement.cs (ToplevelBlock.GetParameterReference)
9131 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
9132 Move here from class Block.
9133 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
9134 * expression.cs (ParameterReference.DoResolveBase): Likewise.
9136 2005-05-18 Martin Baulig <martin@ximian.com>
9141 (FlowBranching.Reachability): Add non-static public And() and Or()
9143 (FlowBranchingSwitch): New class; do the `break_origins' thing
9144 like in FlowBranchingLoop.
9145 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
9146 reachability, not just locals and parameters.
9147 (FlowBranching.MergeChild): Remove some of the hacks for loop and
9148 switch; MergeBreakOrigins() now takes care of that.
9150 2005-05-18 Martin Baulig <martin@ximian.com>
9152 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9153 a loop and may leave it, reset the barrier; fixes #74974.
9155 2005-05-17 Marek Safar <marek.safar@seznam.cz>
9157 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
9160 * cs-parser.jay: Catch more lexical errors.
9162 * report.cs: Add one more Error method.
9165 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
9167 2005-05-17 Martin Baulig <martin@ximian.com>
9169 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
9172 2005-05-16 Raja R Harinath <rharinath@novell.com>
9174 Fix test-382.cs. Emit values of decimal constants.
9175 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
9177 (TypeContainer.AddField): ... this.
9178 (TypeContainer.EmitFieldInitializers): Allow the list of fields
9179 with initializers to include 'Const's.
9180 (ClassPart.RegisterFieldForInitialization): Forward to
9182 * const.cs (Const.Const): Pass initializer to base class.
9183 (Const.Define): In case of decimal constants, register them for
9184 initialization in a static constructor.
9186 2005-05-14 Martin Baulig <martin@ximian.com>
9188 * statement.cs (Block.Resolve): Correctly handle unreachable code;
9189 do not call ResolveUnreachable() on unreachable statements in
9190 here, see the comment in the source code.
9192 2005-05-13 Raja R Harinath <rharinath@novell.com>
9195 * expression.cs (BinaryResolveOperator): If one of the operands of
9196 an equality comparison is 'null' and the other is a pointer type,
9197 convert the null to a NullPointer.
9198 * convert.cs (ImplicitReferenceConversion): If the expression is a
9199 NullLiteral and the target type is a pointer type, return a
9200 NullPointer instead.
9201 (ImplicitConversionStandard): Likewise.
9203 2005-05-13 Marek Safar <marek.safar@seznam.cz>
9205 * cs-parser.jay: Set readonly context based on special constructs.
9207 * expression.cs (LocalVariableReference.DoResolveBase): Improved
9208 readonly variable error handling.
9210 * rootcontext.cs (EmitCode): Don't verify members when error
9213 * statement.cs (LocalInfo): Add reaodnly context information.
9214 (SetReadOnlyContext, GetReadOnlyContext): New methods.
9216 2005-05-13 Raja R Harinath <rharinath@novell.com>
9218 * statement.cs (Block.Resolve): Revert change below. Modify fix
9219 for #74041 to initialize 'resolved' to false only for explicit
9220 blocks. Fixes #74873.
9222 2005-05-12 Raja R Harinath <harinath@gmail.com>
9225 * typemanager.cs (unmanaged_enclosing_types): New.
9226 (IsUnmanagedType): Avoid infloops by using
9227 'unmanaged_enclosing_types' to talk with recursive invocations.
9229 2005-05-13 Martin Baulig <martin@ximian.com>
9231 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
9232 instance variable, not a local. Fix #74873.
9233 (Block.ResolveUnreachable): Set it to true here.
9235 2005-05-11 Duncan Mak <duncan@novell.com>
9237 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
9238 continuing to process for 'arg'.
9239 (handle_preprocessing_directive): Check the argument of the #endif
9240 directive and report error CS1025 if there are any trailing
9243 According to the C# spec, having even whitespace after the #endif
9244 directive is illegal; however, because we call arg.TrimEnd ()
9245 beforehand, we have the same behavior as csc, allowing whitespace
9246 after the directive.
9250 2005-05-11 Marek Safar <marek.safar@seznam.cz>
9254 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
9255 (Constructor.GetObsoleteAttribute): Implemented correctly.
9257 2005-05-10 Martin Baulig <martin@ximian.com>
9259 * support.cs (ReflectionParameters.ParameterModifier): Use
9260 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
9261 and `ParameterAttributes.In'. Fixes #74884.
9263 2005-05-10 Marek Safar <marek.safar@seznam.cz>
9265 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
9267 * expression.cs (Argument.GetParameterModifier): Turned to property.
9268 (Invocation.Error_InvalidArguments): Add more descriptive errors.
9270 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
9273 2005-05-09 Raja R Harinath <rharinath@novell.com>
9276 * decl.cs (MemberCache.AddMethods): Register override methods,
9277 rather than non-override methods.
9278 * typemanager.cs (RegisterOverride): New.
9279 (IsOverride): Update.
9281 2005-05-09 Marek Safar <marek.safar@seznam.cz>
9285 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
9286 recursive declaration.
9288 * statement.cs (Block.ResolveMeta): Report any error in resolving.
9290 2005-05-06 Marek Safar <marek.safar@seznam.cz>
9292 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
9294 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
9296 2005-05-05 Raja R Harinath <rharinath@novell.com>
9299 * decl.cs (DeclSpace.FamilyAccessible):
9300 Use TypeManager.IsNestedFamilyAccessible.
9302 Fix reopened #64812.
9303 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
9306 2005-05-04 Raja R Harinath <rharinath@novell.com>
9307 Abin Thomas <projectmonokochi@rediffmail.com>
9308 Anoob V E <projectmonokochi@rediffmail.com>
9309 Harilal P R <projectmonokochi@rediffmail.com>
9312 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
9313 allow access to all static members.
9315 2005-05-04 Martin Baulig <martin@ximian.com>
9317 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
9319 2005-05-04 Martin Baulig <martin@ximian.com>
9323 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
9324 section at the end; make things work if `default' is not the last
9327 2005-05-04 Martin Baulig <martin@ximian.com>
9331 * statement.cs (Switch): Replaced the `got_default' field with a
9332 `default_section' one.
9333 (Switch.CheckSwitch): Set `default_section' here.
9334 (Switch.Resolve): If we're a constant switch and the constant is
9335 not found, use the default section.
9337 2005-05-03 Martin Baulig <martin@ximian.com>
9339 * expression.cs (ArrayAccess.EmitGetLength): New public method.
9341 * statement.cs (Foreach.ArrayForeach): New nested class.
9342 (Foreach.TemporaryVariable): New nested class.
9343 (Foreach.EmitArrayForeach): Removed; this is now in the new
9346 2005-05-03 Raja R Harinath <rharinath@novell.com>
9348 * pending.cs (BaseImplements): Move the #74773 fix here. This is
9350 (VerifyPendingMethods): Revert change below.
9352 * typemanager.cs (IsOverride, RegisterNonOverride): New.
9353 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
9354 that used to trigger warning -28. Remove warning -28.
9355 * expression.cs (Invocation.OverloadResolve): Use
9356 TypeManager.IsOverride to distinguish override methods.
9359 * pending.cs (VerifyPendingMethods): If a base type implements the
9360 requested interface, don't bother checking individual methods of
9361 the base type. As a side-effect, this prevents the creation of
9362 unnecessary proxies.
9364 2005-05-02 Martin Baulig <martin@ximian.com>
9368 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9369 Also `And' the locals if the old vector is null.
9370 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
9371 null; in this case we basically reset all the variables.
9373 2005-05-02 Martin Baulig <martin@ximian.com>
9377 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
9378 Added `FlowBranching branching' argument; always `and' the
9379 variables instead of `or'ing them unless we're an infinite loop.
9381 * statement.cs (While.Resolve): Create a new sibling unless we're
9384 2005-05-02 Martin Baulig <martin@ximian.com>
9388 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
9389 arguments; use it instead of creating a new TopLevelBlock.
9390 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
9391 our ConstructorInitializer.
9394 (TopLevelBlock.TopLevelBranching): New public property.
9395 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
9396 and create our `TopLevelBranching'.
9398 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
9399 anonymous method host, use `block.TopLevelBranching' rather than
9400 creating a new branching.
9402 2005-04-20 Miguel de Icaza <miguel@novell.com>
9404 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
9405 a ScopeInfo, if any of the current children is a child of the new
9406 entry, move those children there.
9408 2005-04-30 Martin Baulig <martin@ximian.com>
9410 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
9411 at the beginning of a SwitchSection. Fix #73335.
9413 2005-04-27 Marek Safar <marek.safar@seznam.cz>
9416 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
9418 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
9419 (FieldExpr.DoResolve): Obsolete members are ignored for field
9422 2005-04-26 Marek Safar <marek.safar@seznam.cz>
9424 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
9425 of arrays detection.
9427 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
9429 (Field.VerifyClsCompliance): Volatile fields are not compliant.
9431 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
9434 2005-04-25 Ben Maurer <bmaurer@ximian.com>
9436 * cs-parser.jay: Use the prefered version of -unsafe in error
9439 2005-04-22 Marek Safar <marek.safar@seznam.cz>
9441 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
9444 2005-04-20 John Luke <john.luke@gmail.com>
9446 * driver.cs: fix typo in error message, --outout to --output
9448 2005-04-20 Marek Safar <marek.safar@seznam.cz>
9450 * codegen.cs (InRefOutArgumentResolving): New field.
9452 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
9453 fields outside contructor.
9455 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
9457 2005-04-19 Miguel de Icaza <miguel@novell.com>
9459 * anonymous.cs (CaptureContext.EmitParameterInstance): The
9460 parameter code was not completed ever, so it was not as up-to-date
9461 as local variables. Must finish it.
9463 The bug fix was to compare the Toplevel of the block, not the
9464 current block. Thanks for Ben for pointing this out.
9466 2005-04-19 Raja R Harinath <rharinath@novell.com>
9468 * decl.cs (AddMethods): Use the declaring type of the problem
9469 method to determine if we want to squash a warning.
9471 2005-04-19 Marek Safar <marek.safar@seznam.cz>
9473 * attribute.cs: Removed debug output.
9475 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
9477 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
9480 2005-04-18 Raja R Harinath <rharinath@novell.com>
9483 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
9484 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
9485 all null comparisons against reference types.
9487 2005-04-18 Marek Safar <marek.safar@seznam.cz>
9490 * class.cs (TypeContainer.CircularDepException) New nested
9492 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
9493 (TypeContainer.DefineType): Removed error, reset InTransit before
9495 (Class.DefineType): Throw exception when is in Transit.
9496 Catch exception and report error.
9497 (Struct.DefineType): Throw exception when is in Transit.
9498 Catch exception and report error.
9499 (Interface.DefineType): Throw exception when is in Transit.
9500 Catch exception and report error.
9502 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
9503 handle nested exception handlers.
9505 * flowanalysis.cs (InTryWithCatch): New method, search for try with
9508 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
9509 InFinally and InCatch storage.
9511 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
9512 (Catch.Resolve): Set and Restore ec.InCatch.
9513 (Try.Resolve): Set and Restore ec.InFinally.
9514 (Try.HasCatch): True when try has catch.
9516 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
9518 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
9519 for the same event member, so exclude such cases from warning 419.
9522 2005-04-16 Miguel de Icaza <miguel@novell.com>
9524 * expression.cs (Binary.ResolveOperator): Apply patch from John
9525 Luke to fix bug 59864: operators &, | and ^ on enumerations
9526 require that the same enum type on both sides.
9528 * driver.cs: Add warnings to old flag usage, this is to assist
9529 people who produce Makefiles and hope that the Makefiles will be
9532 * class.cs (TypeContainer.EmitType): Moved the definition of the
9533 special $PRIVATE$ field from the resolve phase to the Emit phase.
9534 During resolve we do not know if we are a struct with
9535 HasExplicitLayout, we know this only after the attributes for the
9538 Set the FieldOffset to zero on the dummy field that we create for
9539 the class. Fixes 74590.
9541 2005-04-16 Raja R Harinath <rharinath@novell.com>
9544 * ecore.cs (PropertyExpr.resolved): New.
9545 (DoResolve): Use it to handle a case of double resolution here.
9546 Handle a case of identical-name-and-type-name.
9547 * expression.cs (ArrayCreation.CheckIndices): Avoid double
9548 resolution by storing the results of expression resolution back
9549 into the "probes" array.
9551 2005-04-15 Raja R Harinath <rharinath@novell.com>
9553 Fix cs0208-7.cs and cs0208-8.cs.
9554 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
9555 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
9556 error reporting to point out the reason a struct is not unmanaged.
9558 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9560 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
9561 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
9563 2005-04-13 Raja R Harinath <rharinath@novell.com>
9566 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
9567 IdenticalNameAndTypeName here.
9568 (EventExpr.InstanceResolve): Likewise.
9570 2005-04-13 Marek Safar <marek.safar@seznam.cz>
9572 C# 2.0 DefaultCharSetAttribute implementation
9574 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
9575 which allows us to set GlobalNamespace for every resolve.
9576 (Attribute.ResolveArguments): Cut from Resolve.
9577 (Attribute.GetCharSetValue): Returns CharSet named argument.
9578 (Attribute.DefinePInvokeMethod): Gets default charset from
9580 (GlobalAttribute.ResolveAsTypeStep): Override.
9581 (GlobalAttribute.ResolveArguments): Override.
9583 * class.cs (TypeAttr): Is protected.
9585 * codegen.cs (ModuleClass.DefaultCharSet): New member.
9586 (ModuleClass.DefaultCharSetType): New memeber.
9587 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
9589 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
9590 charset from module.
9592 * delegate.cs (TypeAttr): Override.
9593 (Delegate.DefineType): Use this TypeAttr.
9595 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
9596 at very early stage (before types are defined) to resolve model
9597 module attributes. It will probably not work with corlib but it
9600 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
9601 charset from module.
9603 * typemanager.cs (default_charset_type): New type.
9605 2005-04-13 Raja R Harinath <rharinath@novell.com>
9607 * decl.cs (MemberCache.AddMethods): Don't warn if
9608 System.Object.Finalize has buggy MethodAttributes.
9610 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
9613 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9615 * doc.cs : detect ambiguous reference to overloaded members.
9616 Fixed bug #71603. MS 1.1 csc does not detect it.
9618 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9620 * doc.cs : delegates must not be referenced with parameters.
9623 2005-04-12 Miguel de Icaza <miguel@novell.com>
9625 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
9627 2005-04-10 Miguel de Icaza <miguel@novell.com>
9629 * driver.cs (MainDriver): Stop processing if the CLS stage found
9632 (CompilerCallableEntryPoint.InvokeCompiler): Always
9633 reset after execution; Take a TextWriter argument for the
9636 * report.cs: Use the error stream instead of hardcoding stderr.
9638 2005-04-09 Miguel de Icaza <miguel@novell.com>
9640 * class.cs: Reduce code paths to test, too small of an
9641 optimization to make it worth the extra testing. Always perform
9644 2005-04-08 Raja R Harinath <rharinath@novell.com>
9647 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
9648 operators that had errors reported on them.
9650 2005-04-08 Marek Safar <marek.safar@seznam.cz>
9652 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
9654 (Attribute.Resolve): Add named argument type checking.
9656 * class.cs (FixedField.Define): Use IsPrimitiveType
9658 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
9660 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
9661 unsafe parameter types.
9663 * statement.cs (Using.ResolveExpression): Add better error description.
9665 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
9667 2005-04-08 Raja R Harinath <rharinath@novell.com>
9670 * attribute.cs (Attribute.GetAttributeUsage): Resolve
9671 AttributeUsageAttribute in the emitcontext of the attribute class,
9672 not in the emitcontext of the attributable entity it was attached to.
9673 * cs-parser.jay: Use 'current_class', not 'current_container',
9674 when creating a GlobalAttribute.
9676 2005-04-08 Alp Toker <alp@atoker.com>
9678 * pending.cs: The fix to #58413 failed to compile methods implementing
9679 interfaces with/without params modifiers and vice versa, even though
9680 params modifiers aren't part of the signature. Make the modifier check
9681 less strict as in csc.
9683 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
9684 Anoob V E <projectmonokochi@rediffmail.com>
9685 Harilal P R <projectmonokochi@rediffmail.com>
9688 * pending.cs (TypeAndMethods.mods): New. Store the parameter
9689 modifiers of pending methods.
9690 (PendingImplementation.PendingImplementation): Initialize it.
9691 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
9692 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
9693 with ParameterData. Add check for modifiers.
9694 * class.cs (MethodData.Define): Update to changes.
9696 2005-04-07 Raja R Harinath <rharinath@novell.com>
9698 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
9700 2005-04-07 Marek Safar <marek.safar@seznam.cz>
9702 * class.cs (PropertyMethod.Define): Check private accessor in abstract
9705 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
9708 * typemanager.cs: Registered RequiredAttributeAttribute.
9710 2005-04-06 Marek Safar <marek.safar@seznam.cz>
9712 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
9713 Warning CS0169 is back at level 3.
9714 (IMethodData.SetMemberIsUsed): New method.
9716 * decl.cs (IsUsed): New value; moved from FieldBase.Status
9717 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
9719 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
9721 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
9723 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
9726 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
9729 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
9730 to avoid the problems with nested types.
9732 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
9733 Anoob V.E <projectmonokochi@rediffmail.com>
9734 Harilal P.R <projectmonokochi@rediffmail.com>
9735 Raja R Harinath <rharinath@novell.com>
9738 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
9740 * typemanager (GetConstructor): Make public.
9742 2005-04-05 John Luke <john.luke@gmail.com>
9743 Raja R Harinath <rharinath@novell.com>
9746 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
9747 struct too. Return false quicker in a few cases.
9748 (VerifyUnManaged): Use it.
9750 2005-04-05 Raja R Harinath <rharinath@novell.com>
9753 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
9754 not 'unreachable_seen'.
9756 2005-04-04 Marek Safar <marek.safar@seznam.cz>
9758 * attribute.cs (Attribute.GetValue): Removed unused.
9760 * codegen.cs (CodeGen.TrimExt): Removed unused.
9762 * cs-parser.jay (output): Removed unused.
9764 * cs-tokenizer.cs (hex_digits): Removed unused.
9766 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
9768 * expression.cs (Indirection.LoadExprValue): Removed unused.
9769 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
9771 * iterators.cs (Iterator.param_types): Removed unused.
9773 * statement.cs (Goto.block): Removed unused.
9774 (ToplevelBlock.did): Removed unused.
9775 (Switch.ResolveConstantSwitch): Removed unused.
9777 2005-04-01 Ben Maurer <bmaurer@ximian.com>
9779 * rootcontext.cs: Allow mcs to bootstrap with the compilation
9782 2005-04-01 Raja R Harinath <rharinath@novell.com>
9784 Fix #74232 and cs0208-3.cs.
9785 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
9786 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
9787 unmanaged type. Don't use FieldBuilders when 't' is a
9788 TypeBuilder. Use ModFlags and MemberType fields.
9789 * class.cs (MemberBase.member_type): Rename from MemberType.
9790 (MemberBase.MemberType): New property. Determines member_type on
9792 (MemberBase.DoDefine): Don't initialize MemberType here.
9793 (FieldMember.Define): Likewise.
9795 2005-04-01 Marek Safar <marek.safar@seznam.cz>
9798 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
9799 Attributes are emitted there.
9801 2005-04-01 Raja R Harinath <rharinath@novell.com>
9803 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
9804 keyword in 'partial enum' too.
9805 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
9807 Report from Kamil Skalski <nazgul@omega.pl>.
9810 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
9811 have partial containers too.
9813 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
9814 in block' checks to Block.CheckInvariantMeaningInBlock.
9815 * statement.cs (Block.GetKnownVariableInfo): Make private.
9816 (Block.IsVariableUsedInChildBlock): Remove.
9817 (Block.IsVariableUsedInBlock): Likewise.
9818 (Block.CheckInvariantMeaningInBlock): New. Show location of
9819 conflicting declaration.
9820 (Block.AddVariable): Make error messages less long-winded and more
9821 specific. Show location of conflicting declaration.
9822 * parameter.cs (Parameters.Location): New readonly property.
9824 2005-03-31 Raja R Harinath <rharinath@novell.com>
9826 Clean up semantics of invoking ResolveMemberAccess.
9827 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
9828 can have an instance, ensure that we pass in a non-TypeExpression
9829 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
9830 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
9831 argument. Update to changes and simplify.
9832 (FieldExpr.Emitinstance): Remove CS0120 check.
9833 (PropertyExpr.EmitInstance): Likewise.
9834 * expression.cs (Argument.Resolve): Likewise.
9835 (Invocation.DoResolve): Update to changes in semantics of
9838 2005-03-31 Marek Safar <marek.safar@seznam.cz>
9841 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
9844 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
9846 2005-03-31 Raja R Harinath <rharinath@novell.com>
9848 Fix difference in behaviour with commandline invocation.
9849 * driver.cs (Driver.Reset): New.
9850 (CompilerCallableEntryPoint): Call it.
9852 * statement.cs (If.Resolve): Avoid spurious "uninitialized
9853 variable" warnings if the boolean expression failed to resolve.
9855 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
9857 * attribute.cs: Fix the union of several permissions when some of them
9858 are unrestricted (so the result isn't an unrestricted permission set).
9861 2005-03-30 Raja R Harinath <rharinath@novell.com>
9863 * ecore.cs (MemberExpr): New class. Convert from interface
9865 (MemberExpr.ResolveMemberAccess): Refactor and move here from
9866 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
9868 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
9869 (MethodGroupExpr.IsExplicitImpl): Remove.
9870 (Expression.GetFieldFromEvent): Remove.
9871 (SimpleName.MemberStaticCheck): Remove.
9872 (SimpleName.DoSimpleNameResolve): Update to changes.
9873 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
9874 (MemberAccess.IdenticalNameAndTypeName): Remove.
9875 (MemberAccess.error176): Move to MemberExpr.
9876 (MemberAccess.DoResolve): Update to changes.
9877 (BaseAccess.DoResolve): Likewise.
9879 2005-03-30 Marek Safar <marek.safar@seznam.cz>
9881 C# 2.0 Conditional attribute class implementation
9883 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
9884 Analyzes class whether it has attribute which has ConditionalAttribute
9885 and its condition is not defined.
9887 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
9888 (Class.IsExcluded): New method. Search for at least one defined
9889 condition in ConditionalAttribute of attribute class.
9891 2005-03-30 Raja R Harinath <rharinath@novell.com>
9893 * ecore.cs (PropertyExpr): Derive from Expression, not
9894 ExpressionStatement.
9895 (PropertyExpr.EmitStatement): Remove.
9897 2005-03-29 Raja R Harinath <rharinath@novell.com>
9900 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
9901 internal field "value__" of an enum be private. The examples for
9902 "value__" that I found on MSDN all used FieldAttributes.Private.
9904 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
9905 Don't mention IL method attribute names.
9907 Fix #47991. Remove a TODO.
9908 * statement.cs (Block.Toplevel): Make into a field.
9909 (Block.Parameters): Move into ToplevelBlock.
9910 (Block.known_variables): Rename from child_variable_names.
9911 (Block.Block): Remove variants that take Parameters. Initialize
9912 'Toplevel' with the immediately surrounding toplevel block.
9913 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
9914 LocalInfo parameter.
9915 (Block.GetKnownVariableInfo): New.
9916 (Block.IsVariableNameUsedInChildBlock): Update.
9917 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
9918 the block, even though it may not be in scope.
9919 (Block.AddVariable): Remove Parameters parameter. Use
9920 Toplevel.Parameters instead.
9921 (Block.AddConstant): Remove Parameters parameter.
9922 (Block.GetParameterReference): Update to use Toplevel.Parameters.
9923 (Block.IsParamaterReference): Likewise.
9924 (Block.IsLocalParameter): Likewise. Simplify a lot.
9925 (ToplevelBlock.Parameters): New. Moved from Block.
9926 (ToplevelBlock.ToplevelBlock): Update to changes. Always
9927 initialize Parameters to a non-null value.
9928 * cs-parser.jay: Update to changes.
9929 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
9930 simple names that mean different things in the same block. Use
9931 Block.IsVariableNameUsedInBlock.
9933 2005-03-28 Raja R Harinath <rharinath@novell.com>
9935 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
9936 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
9937 GetTypeHandle. It is possible for a reflected type to derive from
9938 a TypeBuilder (e.g., int[] derives from the TypeBuilder
9939 System.Array during mscorlib compilation).
9940 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
9941 contain a method_hash, don't create one either. Don't create a
9942 deep copy of the base cache's method_hash.
9943 (MemberCache.SetupCache): Rename back from DeepCopy.
9944 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
9945 already initialized. If we see an override function, add its
9946 underlying base virtual function to the member_hash too.
9948 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
9950 2005-03-26 Raja R Harinath <harinath@acm.org>
9953 * assign.cs (Assign.DoResolve): When the RHS of an assignment
9954 fails to resolve, ensure that the LHS is still resolved as an
9957 2005-03-25 Raja R Harinath <harinath@acm.org>
9959 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
9961 (Enum.current_ec): Remove.
9962 (Enum.LookupEnumValue): Remove EmitContext argument.
9963 Just uses the one created during DefineType.
9964 (Enum.FindMembers): Update.
9965 * expression.cs (MemberAccess.DoResolve): Update.
9967 2005-03-22 Marek Safar <marek.safar@seznam.cz>
9969 * assign.cs (Assign.DoResolve): Check for CS1717 when
9970 source and target are same (uses Equals).
9972 * expression.cs (LocalVariableReference, ParameterReference,
9973 This): Implemented Equals, GetHashCode.
9975 * statement.cs (Block.GetParameterReference): Removed useless
9978 2005-03-22 Raja R Harinath <rharinath@novell.com>
9981 * statement.cs (Block.AddVariable): Ensure that we skip implicit
9982 blocks before deciding whether the error is cs0136 or cs0128.
9984 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
9985 (using_alias_directive, using_namespace_directive): Pass
9986 MemberName, not an expression to Namespace.UsingAlias and
9988 (MakeName): Use the MemberName of the namespace.
9989 * namespace.cs (Namespace.MemberName): New.
9990 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
9991 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
9993 * decl.cs (MemberName.Name): Make readonly.
9994 (MemberName.FromDotted): New "constructor".
9995 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
9996 (MemberCore.Name): Compute from MemberName on demand.
9997 (MemberCore.SetMemberName): Provide a way to change the
9999 (MemberCore.AddToContainer): Don't take a fullname parameter.
10000 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
10001 fully qualified name of the container to the member name.
10002 (TypeContainer.AddToTypeContainer): Use a fully qualified name
10003 only if the type is a member of the root container.
10004 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
10005 MemberName.Left rather than searching for an embedded ".".
10006 (PartialContainer.CreatePart): Update to changes in RootContext.
10007 (MemberBase.ShortName): Turn into a property. Use
10008 MemberCore.SetMemberName.
10009 (MemberBase.ExplicitInterfaceName): Remove.
10010 (MemberBase.UpdateMemberName): Remove.
10011 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
10012 (PropertyBase.SetMemberName): New override.
10013 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
10014 (Tree.GetDecl): New.
10015 (Tree.AllDecls): Rename from Decls.
10016 * attribute.cs, enum.cs, report.cs: Update to changes.
10017 * driver.cs (MainDriver): Use MemberName.FromDotted on
10018 RootContext.MainClass.
10020 2005-03-21 Marek Safar <marek.safar@seznam.cz>
10022 * class.cs (FixedField.Define): Check for CS1664 and more sanity
10025 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
10027 2005-03-18 Marek Safar <marek.safar@seznam.cz>
10029 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
10030 property accessor modifiers.
10032 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
10033 fixed buffer attribute (CS1716).
10034 (PropertyMethod.HasCustomAccessModifier): When property accessor
10035 has custom modifier.
10037 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
10039 (PropertyExpr.DoResolveLValue): Add CS0272.
10041 2005-03-17 Miguel de Icaza <miguel@novell.com>
10043 * convert.cs: When converting to a pointer, use the proper Conv.U
10044 or Conv.I depending on the source data type.
10046 * cs-tokenizer.cs: Make the size for large decimal constants,
10049 2005-03-17 Martin Baulig <martin@ximian.com>
10051 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
10052 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
10054 2005-03-17 Martin Baulig <martin@ximian.com>
10056 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
10057 to bool so we can return an error condition.
10058 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
10061 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
10063 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
10066 2005-03-16 Raja R Harinath <rharinath@novell.com>
10068 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
10069 Refactor to avoid traversing the list of assemblies, and to avoid
10070 string concatenation.
10071 * typemanager.cs (guid_attr_type): Remove.
10072 (negative_hits, pointers, references): Remove hashes.
10074 (GetConstructedType): New. Uses type_hash to handle constructed
10075 types (arrays, references, pointers).
10076 (GetReferenceType, GetPointerType): Use it.
10077 (GetNestedType): New. Uses type_hash to handle nested types of
10079 (LookupType, LookupTypeDirect): Remove.
10080 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
10081 'types' hash and LookupTypeReflection directly.
10082 (params_string, params_object): Use GetConstructedType.
10083 * namespace.cs (Namespace.cached_types): New. Cache of reflected
10085 (Namespace.Lookup): Use cached_types.
10086 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
10087 provided by old TypeManager.LookupType.
10088 * rootcontext.cs (MakeFQN): Remove.
10089 * decl.cs (DeclSpace.MakeFQN): Likewise.
10090 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
10091 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
10092 TypeManager.GetConstructedType.
10093 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
10095 2005-03-15 Marek Safar <marek.safar@seznam.cz>
10097 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
10100 * cs-parser.jay: Reports CS1527 for any namespace element.
10102 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
10105 * expression.cs (ParameterReference.IsAssigned): Changed error to
10107 (Error_WrongNumArguments): Moved CS0245 detection here.
10109 * statement.cs (Return.Resolve): Add CS1622 report.
10111 2005-03-11 Marek Safar <marek.safar@seznam.cz>
10113 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
10115 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
10117 * attribute.cs expression.cs: Get rid of some allocations.
10119 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
10121 * doc.cs : just eliminate the latest change.
10123 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10125 * doc.cs : commented out the latest change. It breaks xml-030.cs
10127 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10129 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
10130 fail. So invoke CreateType() in FindDocumentedType().
10132 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10134 * cs-tokenizer.cs : added IsKeyword().
10135 * doc.cs : Detect keyword incorrectly used as identifier.
10136 Allow identifiers prefixed by @.
10138 2005-03-10 Marek Safar <marek.safar@seznam.cz>
10140 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
10141 It caused exception in namespace resolving (again!).
10143 * class.cs (Class.ctor): Removed exit.
10144 (PropertyMethod.ctor): ditto.
10146 * codegen.cs (Codegen.Reset): Reset static data.
10147 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
10149 * cs-tokenizer.cs (Cleanup): Removed.
10151 * driver.cs (GetSystemDir): Rewrote to one line command.
10152 It caused problem with unloaded dynamic modules.
10153 (UnixParseOption): Removed Exit.
10154 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
10155 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
10156 Now can be mcs used as library.
10158 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
10161 * location.cs (Reset): Reset static data.
10163 * namespace.cs (Reset): Reset static data.
10165 * report.cs (Report.Reset): Reset static data.
10167 * rootcontext.cs (RootContext.Reset): Reset static data.
10169 * tree.cs (RootTypes.ctor): Use Location.Null
10171 * typemanager.cs (TypeManager.Reset): Reset static data.
10172 (CoreLookupType): Removed Exit.
10173 (TypeHandle.Reset): Reset static data.
10175 2005-03-10 Raja R Harinath <rharinath@novell.com>
10178 * typemanager.cs (ComputeNamespaces): Import namespaces from
10179 referenced modules too.
10181 2005-03-09 Raja R Harinath <rharinath@novell.com>
10183 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
10186 2005-03-09 Raja R Harinath <rharinath@novell.com>
10188 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
10189 enclosing DeclSpace. This ensures that a name-lookup populates
10190 more caches and there are fewer 'TypeExpression's. Carve out
10191 nested type lookup into ...
10192 (LookupNestedTypeInHierarchy): ... this.
10194 2005-03-09 Raja R Harinath <rharinath@novell.com>
10196 Clean up a few partial-class semantics.
10197 Fixes test-357.cs and cs1618-2.cs.
10198 * cs-parser.jay (struct_declaration): Use 'current_class' as
10199 parent of newly-created struct. Remove call to Register ().
10200 Use 'pop_current_class' to complete handing the current struct.
10201 (interface_declaration): Likewise.
10202 (class_declaration): Likewise.
10203 (enum_declaration): Use 'current_class' as parent of newly created
10205 (delegate_declaration): Likewise.
10206 (pop_current_class): New function. This is used to handle closing
10207 up the 'current_class' and 'current_container', and pointing them
10208 to the enclosing class/container.
10209 (CSharpParser): Initialize 'current_class' too.
10210 * decl.cs (MemberCore): Add check for invariant: a partial
10211 container is not a parsed entity, and thus does not enclose any
10213 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
10214 (DeclSpace.BaseTypeExpr): Use it.
10215 (DeclSpace.LookupType): Add check for invariant.
10216 * class.cs (TypeContainer): Add check for invariant: a nested
10217 class should have the same NamespaceEntry as its enclosing class.
10218 (TypeContainer.EmitFieldInitializers): Make virtual.
10219 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
10221 (TypeContainer.Register): Remove.
10222 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
10223 null. Use TypeResolveEmitContext for resolving base types and
10224 interfaces. Move initialization of Parts.TypeBuilder here from
10226 (TypeContainer.DefineNestedTypes): ... here.
10227 (PartialContainer): Take a Namespace not a NamespaceEntry.
10228 (PartialContainer.Create): Don't use Register. Call the
10229 appropriate Add... function directly.
10230 (ClassPart): Take both the PartialContainer and the enclosing
10231 class as constructor arguments.
10232 (ClassPart.EmitFieldInitializers): Override.
10233 (ClassPart.PartFindNestedTypes): Remove.
10234 (FieldBase.GetInitializerExpression): Resolve the initializer
10235 expression in the emit context of the enclosing class.
10236 * tree.cs (RootTypes): Remove Register ().
10238 2005-03-08 Marek Safar <marek.safar@seznam.cz>
10240 * cs-parser.jay: Removed CS0134.
10242 * driver.cs: Removed CS1901.
10244 * expression.cs (SizeOf.DoResolve): Don't report CS0233
10245 for predefined types.
10247 2005-03-07 Duncan Mak <duncan@novell.com>
10249 * codegen.cs (Save): Catch UnauthorizedAccessException as
10250 well. Fixes bug #73454.
10252 2005-03-07 Marek Safar <marek.safar@seznam.cz>
10254 * cs-tokenizer.cs (xtoken): Add CS1035.
10256 * class.cs (MethodData.Define): Add CS0683.
10257 (FieldMember.ctor): Add CS0681.
10259 2005-03-07 Raja R Harinath <rharinath@novell.com>
10261 * ecore.cs (SimpleName.DoResolve): Rename from
10262 SimpleName.DoResolveAllowStatic.
10263 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
10264 Pass 'intermediate' flag to MemberStaticCheck.
10265 (SimpleName.MemberStaticCheck): Skip "static check" only in case
10266 of "intermediate" lookups via MemberAccess.
10267 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
10268 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
10270 2005-03-07 Raja R Harinath <rharinath@novell.com>
10273 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
10274 slipped in because of variable names that are identical to a
10275 builtin type's BCL equivalent ('string String;', 'int Int32;').
10276 (PropertyExpr.EmitInstance): Likewise.
10278 2005-03-04 Marek Safar <marek.safar@seznam.cz>
10280 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
10282 * report.cs (warning_ignore_table): Made public.
10284 2005-03-04 Raja R Harinath <rharinath@novell.com>
10287 * class.cs (MethodData.Emit): Pass 'container' to
10288 container.GetObsoleteAttribute instead of 'container.Parent'.
10290 2005-03-03 Marek Safar <marek.safar@seznam.cz>
10292 * cs-parser.jay: Add 1534 error test.
10294 * iterators.cs (Yield.CheckContext): Add error 1629.
10295 (Iterator.ctor): Save unsafe modifier.
10296 (MoveNextMethod.DoEmit): Restore unsafe context.
10298 * namespace.cs (UsingAlias): Better error message.
10300 2005-03-03 Dan Winship <danw@novell.com>
10302 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
10303 the warning message [#73219]
10305 2005-03-03 Raja R Harinath <rharinath@novell.com>
10307 Fix compile with MCS 1.0.0.0.
10308 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
10309 w_restore to not depend on string constant folding.
10311 2005-03-03 Raja R Harinath <rharinath@novell.com>
10313 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
10314 CS0246 check to users who passed 'silent = false'.
10315 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
10317 (SimpleName.SimpleNameResolve): Update.
10318 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
10319 (MemberAccess.IdenticalNameAndTypeName): Update.
10320 * doc.cs (FindDocumentedTypeNonArray): Update.
10322 2005-03-03 Raja R Harinath <rharinath@novell.com>
10324 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
10325 * parameters.cs (ComputeAndDefineParameters): Remove.
10326 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
10327 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
10328 Use GetParameterInfo.
10330 2005-03-02 Marek Safar <marek.safar@seznam.cz>
10332 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
10334 2005-03-02 Raja R Harinath <rharinath@novell.com>
10336 Unify DeclSpace.LookupType and DeclSpace.FindType.
10337 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
10338 is in charge of defining nested types on demand.
10339 (DeclSpace.LookupType): Use it when the current_type is a
10340 TypeBuilder. Use LookupTypeDirect for reflected types.
10341 (DeclSpace.FindType): Remove.
10342 (DeclSpace.LookupInterfaceOrClass): Likewise.
10343 (DeclSpace.DefineTypeAndParents): Likewise.
10344 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
10345 DeclSpace.LookupType.
10346 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
10347 * typemanager.cs (LookupType): Simplify.
10348 (AddUserType): Remove type from negative_hits.
10349 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
10350 * class.cs (TypeContainer.FindMembers): Move handling of nested
10352 (TypeContainer.FindMembers_NestedTypes): ... here.
10353 (TypeContainer.FindNestedType): Implement override.
10354 (ClassPart.FindNestedType): Delegate to PartialContainer.
10355 (ClassPart.PartFindNestedType): Looks up the nested types of the
10358 2005-03-02 Martin Baulig <martin@ximian.com>
10360 * class.cs (TypeContainer.DoDefineMembers): We also need a default
10361 static constructor in static classes.
10363 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
10365 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
10366 sizeParamIndex is not specified.
10368 2005-03-01 Marek Safar <marek.safar@seznam.cz>
10371 * report.cs (WarningMessage.IsEnabled): Missing null check.
10373 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10375 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
10376 in the fields and not in the properties.
10378 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
10380 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
10383 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10385 * attribute.cs: Small refactoring (improved robustness).
10386 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
10387 (ValidateGuid): Removed.
10388 (Resolve): Removed referenced to above mentioned.
10389 (GetAttributeUsage): Made private and changed to work without
10391 (GetIndexerAttributeValue): Don't crash.
10392 (GetConditionalAttributeValue): Ditto.
10393 (GetClsCompliantAttributeValue): Ditto.
10394 (ExtractSecurityPermissionSet): All attributes exceptions are
10396 (GetPropertyValue): New helper.
10397 (GetMethodImplOptions): New method.
10398 (DefinePInvokeMethod): Reuse common code. Implemented handling of
10399 some missing properties.
10401 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
10402 (Method.ApplyAttributeBuilder): Updated.
10404 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
10407 2005-02-28 Raja R Harinath <rharinath@novell.com>
10410 * report.cs (Report.SymbolRelatedToPreviousError): Handle
10411 non-simple types (array, pointer, reference).
10413 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10415 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
10417 * class.cs (MethodCore.IsDuplicateImplementation): Special error
10419 (Method.CheckBase): Catch wrong destructor here.
10420 (MethodData.Define): Add errors 550, 668.
10422 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
10424 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
10426 * pending.cs (VerifyPendingMethods): Add error 551.
10428 * typemanager.cs (CSharpName): Next error report helper.
10430 2005-02-25 Marek Safar <marek.safar@seznam.cz>
10432 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
10433 attributes. Removed useless attribute double check.
10434 It saves almost 2MBs for corlib.
10436 2005-02-25 Raja R Harinath <rharinath@novell.com>
10439 * statement.cs (ExpressionStatement.Resolve): Make robust to being
10440 called twice in case of error.
10442 2005-02-23 Chris Toshok <toshok@ximian.com>
10444 Fix compiler portions of #72827.
10445 * statement.cs (Block.Emit): call Begin/EndScope on the
10446 EmitContext instead of the ILGenerator.
10448 * codegen.cs (EmitContext.BeginScope): new method, call
10449 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
10451 (EmitContext.BeginScope): same, but EndScope and CloseScope
10453 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
10454 offset and call the superclass's OpenScope(int) with it.
10455 (SymbolWriter.CloseScope): get the current il
10456 offset and call superclass's CloseScope(int) with it.
10458 2005-02-23 Marek Safar <marek.safar@seznam.cz>
10460 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
10461 CS1677 for out and ref as well.
10463 * class.cs (Method.Define): Add error CS1599 detection.
10465 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
10467 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
10469 * delegate.cs (Delegate.Define): Add error CS1599 detection.
10471 * support.cs.cs (ModifierDesc): New helper method.
10473 2005-02-23 Raja R Harinath <rharinath@novell.com>
10474 Abin Thomas <projectmonokochi@rediffmail.com>
10475 Anoob V E <projectmonokochi@rediffmail.com>
10476 Harilal P R <projectmonokochi@rediffmail.com>
10478 Fix #57851, #72718.
10479 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
10480 MemberLookup (used for error reporting) actually returns a result.
10481 Fix error report number (122, not 112).
10483 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
10484 Anoob V E <projectmonokochi@rediffmail.com>
10485 Harilal P R <projectmonokochi@rediffmail.com>
10488 * pending.cs (PendingImplementation.GetAbstractMethods):
10489 Find NonPublic members too.
10491 2005-02-22 Marek Safar <marek.safar@seznam.cz>
10493 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
10496 * class.cs (MethodCore.CheckMethodAgainstBase):
10497 Add error 239 report.
10499 2005-02-21 Raja R Harinath <rharinath@novell.com>
10502 * expression.cs (Invocation.IsApplicable): Make public.
10503 (Invocation.IsParamsMethodApplicable): Likewise.
10504 * delegate.cs (Delegate.VerifyApplicability): Don't use
10505 Invocation.VerifyArgumentCompat for parameter applicability
10506 testing. Use Invocation.IsApplicable and
10507 Invocation.IsParamsMethodApplicable.
10509 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10511 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
10513 * class.cs (Operator.Define): Add error 217 report.
10515 2005-02-21 Raja R Harinath <rharinath@novell.com>
10517 * namespace.cs (UsingEntry.Resolve): Undo change below.
10519 2005-02-21 Raja R Harinath <rharinath@novell.com>
10522 * ecore.cs (Expression.MemberLookupFailed): Add argument to
10523 disable the error message when the extended MemberLookup also
10525 (Expression.MemberLookupFinal): Update.
10526 (SimpleName.DoSimpleNameResolve): Update.
10527 * expression.cs (MemberAccess.ResolveNamespaceOrType):
10528 Don't use MemberLookupFinal.
10529 (New.DoResolve): Update.
10530 (BaseAccess.CommonResolve): Update.
10532 2005-02-21 Raja R Harinath <rharinath@novell.com>
10535 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
10536 occured previously, don't resolve again.
10538 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10541 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
10542 argument. Call ResolveAttributeUsage for unresolved.
10543 when types doesn't match ctor arguments.
10545 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
10546 for nested attribute classes.
10547 (Class.attribute_usage): Removed.
10548 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
10549 for attribute class.
10551 * ecore.cs (IsAttribute): Removed.
10553 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
10555 * rootcontext.cs (RegisterAttribute): Removed, attributes are
10557 (attribute_types): Removed.
10558 (EmitCode): Global attributes are emited as the latest.
10560 2005-02-18 Marek Safar <marek.safar@seznam.cz>
10562 * class.cs (EmitFieldInitializers): Don't emit field initializer
10563 for default values when optimilization is on.
10565 * constant.cs (Constant.IsDefaultValue): New property.
10567 * driver.cs: Add /optimize handling.
10571 * literal.cs: Implement new IsDefaultValue property.
10573 * rootcontext.cs (Optimize): New field, holds /optimize option.
10575 2005-02-18 Raja R Harinath <rharinath@novell.com>
10577 Fix crasher in re-opened #72347.
10578 * namespace.cs (Namespace.Lookup): Return null if
10579 DeclSpace.DefineType returns null.
10582 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
10584 2005-02-18 Raja R Harinath <rharinath@novell.com>
10586 Fix remainder of #63202. Change semantics of DoResolveLValue: it
10587 now returns null if it cannot resolve to an lvalue.
10588 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
10589 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
10590 returned null. Remove check for SimpleName.
10591 (EventExpr.DoResolveLValue): New.
10592 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
10593 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
10595 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
10596 avoid CS0131 error.
10597 (Unary.ResolveOperator): Move CS0211 check ...
10598 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
10600 (Unary.DoResolveLValue): Simplify.
10601 (AddressOf.DoResolveLValue): New.
10602 (ArrayAccess.DoResolveLValue): New.
10604 2005-02-16 Marek Safar <marek.safar@seznam.cz>
10606 * attribute.cs (Attribute.Resolve): Add arguments casting for
10607 when types doesn't match ctor arguments.
10609 2005-02-16 Raja R Harinath <rharinath@novell.com>
10611 Fix parts of #63202.
10612 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
10613 lookup of operator in base type. Ensure that all checks happen
10614 when the operator resolves to an "op_..." method.
10616 2005-02-15 Raja R Harinath <rharinath@novell.com>
10619 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
10620 'ignore_cs0104' parameter. Pass it to ...
10621 (NamespaceEntry.Lookup): ... this.
10622 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
10623 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
10624 (TypeLookupExpression.DoResolveAsTypeStep): Update.
10625 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
10626 Update. Request that cs0104 errors be ignored.
10627 (ComposedCast.ResolveAsTypeStep): Update.
10629 2005-02-14 Raja R Harinath <rharinath@novell.com>
10632 * expression.cs (Invocation.BetterFunction): Remove support for
10633 comparing virtual functions and their overrides.
10634 (Invocation.IsOverride): New.
10635 (Invocation.OverloadResolve): Don't consider 'override' functions
10636 during candidate selection. Store them in a lookaside list.
10637 If the selected method is a 'virtual' function, use the list to
10638 find any overrides that are closer to the LHS type.
10640 2005-02-14 Marek Safar <marek.safar@seznam.cz>
10642 * expression.cs (New.DoResolve): Add complex core type reduction.
10643 (New.Constantify): Converts complex core type syntax like 'new int ()'
10644 to simple constant.
10646 2005-02-14 Raja R Harinath <rharinath@novell.com>
10648 * decl.cs (EntryType.EntryType): New constructor to create an
10649 updated copy of a cache entry.
10650 (MemberCache.AddMethods): Use it.
10651 (MemberCache.ClearDeclaredOnly): Remove.
10652 (MemberCache.MemberCache): Update.
10654 2005-02-11 Miguel de Icaza <miguel@novell.com>
10656 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
10657 variable. This one is represents the actual low-level declaration
10658 of the method, as opposed to the semantic level `IsStatic'.
10660 An anonymous method which is hosted into a static method might be
10661 actually an instance method. IsStatic would reflect the
10662 container, while MethodIsStatic represents the actual code
10665 * expression.cs (ParameterReference): Use the new MethodIsStatic
10666 instead of IsStatic.
10668 * anonymous.cs (AnonymousMethod.Compatible): Pass the
10669 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
10670 set on the current EmitContext.
10672 * expression.cs (Cast): Overload DoResolveLValue so we can pass
10673 resolve our casted expression as an LValue. This triggers the
10674 proper LValue processing that is later required by Assign.
10678 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
10680 2005-02-11 Marek Safar <marek.safar@seznam.cz>
10682 C# 2.0 Fixed buffer implementation
10684 * anonymous.cs: Update after RegisterHelperClass renaming.
10686 * attribute.cs (AttributeTester.fixed_buffer_cache):
10687 Cache of external fixed buffers.
10688 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
10689 implementation if field is fixed buffer else null.
10692 (TypeContainer.AddField): Accept FieldMember instead of Field.
10693 (FieldBase.IsFieldClsCompliant): Extracted code from
10694 VerifyClsCompliance descendant customization.
10695 (FixedField): New class handles fixed buffer fields.
10696 (FixedFieldExternal): Keeps information about imported fixed
10698 (IFixedField): Make access to internal or external fixed buffer
10701 * cs-parser.jay: Add fixed buffer parsing.
10703 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
10706 * expression.cs (Indirection): Extended implementation to accept
10707 fixed buffer field.
10708 (PointerArithmetic.Emit): Get element from fixed buffer as well.
10709 (ElementAccess.MakePointerAccess): Get type as parameter.
10710 (DoResolve): Add fixed buffer field expression conversion.
10711 (DoResolveLValue): Ditto.
10712 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
10713 (ArrayPtr): Derives from FixedBufferPtr.
10714 (ArrayPtr.Emit): Add extra emit for array elements.
10716 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
10718 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
10719 for compiler generated types.
10720 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
10722 * statement.cs (Fixed): Refactored to be easier add fixed buffer
10723 and consume less memory.
10724 (Fixed.Resolve): Add fixed buffer case.
10726 * typemanager.cs (compiler_generated_attr_ctor,
10727 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
10728 (HasElementType): Add our own implementation to work on every
10731 2005-02-11 Miguel de Icaza <miguel@novell.com>
10733 * anonymous.cs (CaptureContext): Track whether `this' has been
10736 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
10737 only captured `this' if it was implicitly done (instance
10738 methods/variables were used).
10740 * codegen.cs (EmitContext.CaptureThis): New method to flag that
10741 `this' must be captured.
10743 2005-01-30 Miguel de Icaza <miguel@novell.com>
10745 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
10746 is null it means that there has been no need to capture anything,
10747 so we just create a sibling.
10749 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
10751 Just a partial fix. The other half is fairly elusive.
10753 2005-02-10 Raja R Harinath <rharinath@novell.com>
10755 Fix #52586, cs0121-4.cs.
10756 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
10757 and return a hashtable.
10758 (MemberCache.ClearDeclaredOnly): New.
10759 (MemberCache.MemberCache): Update to change. Make a deep copy of
10760 the method_hash of a base type too.
10761 (MemberCache.AddMethods): Adapt to having a deep copy of the base
10762 type methods. Overwrite entries with the same MethodHandle so
10763 that the ReflectedType is correct. The process leaves in base
10764 virtual functions and their overrides as distinct entries.
10765 (CacheEntry): Now a class instead of a struct. It shouldn't alter
10766 matters since it was boxed in a ArrayList before.
10767 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
10769 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
10770 case of a virtual function and its override (choose the overload
10772 (Invocation.OverloadResolve): Avoid 'override' members during
10773 'applicable_type' calculation.
10775 2005-02-09 Raja R Harinath <rharinath@novell.com>
10777 Combine two near-redundant caches.
10778 * typemanager.cs (method_params): Rename from method_internal_params.
10779 (TypeManager.GetParameterData): New. Replace
10780 Invocation.GetParameterData.
10781 (TypeManager.LookupParametersByBuilder): Remove.
10782 * expression.cs (Invocation.method_parameter_cache): Remove.
10783 (Invocation.GetParameterData): Remove.
10785 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
10788 2005-02-08 Raja R Harinath <rharinath@novell.com>
10791 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
10792 TypeManager.multicast_delegate_type is null, resolve it by looking
10793 up "System.MulticastDelegate".
10794 * rootcontext.cs (RootContext.ResolveCore): Simplify.
10796 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
10797 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
10798 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
10801 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
10802 (LabeledStatement.AddReference): New. Set 'referenced'.
10803 (Goto.Resolve): Use it.
10805 2005-02-05 John Luke <john.luke@gmail.com>
10807 * driver.cs: remove duplicate -doc line in Usage ()
10809 2005-02-04 Raja R Harinath <rharinath@novell.com>
10811 * location.cs (Location.AddFile): Fix CS2002 error report.
10813 2005-02-02 Martin Baulig <martin@ximian.com>
10815 * delegate.cs (Delegate.DefineType): Report an internal error if
10816 TypeManager.multicast_delegate_type is null. See bug #72015 for
10819 2005-02-02 Raja R Harinath <rharinath@novell.com>
10821 Fix a crasher in a variant of #31984.
10822 * const.cs (Constant.CheckBase): New override that defers the
10823 new-or-override check in case the base type hasn't been populated
10825 (Constant.Define): Ensure the new-or-override check is performed.
10827 2005-02-01 Duncan Mak <duncan@ximian.com>
10829 * const.cs (LookupConstantValue): Check that `ce' is not null
10830 before calling GetValue ().
10832 2005-02-01 Raja R Harinath <rharinath@novell.com>
10834 Fix test-334.cs (#69519).
10835 * cs-parser.jay (using_alias_directive): Pass in an expression to
10836 NamespaceEntry.UsingAlias.
10837 (using_namespace_directive): Pass in an expression to
10838 NamespaceEntry.Using.
10839 (namespace_name): Don't flatten to a string.
10840 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
10841 (NamespaceEntry.AliasEntry.Resolve): Lookup using
10843 (NamespaceEntry.UsingEntry): Likewise.
10844 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
10846 (NamespaceEntry.LookupForUsing): Remove.
10847 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
10849 (NamespaceEntry.Lookup): Remove support for dotted names.
10851 2005-02-01 Raja R Harinath <rharinath@novell.com>
10853 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
10855 (NamespaceEntry.ImplicitParent): Compute on demand.
10856 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
10857 parallels the current.
10858 (NamespaceEntry.LookupForUsing): Use it.
10859 (NamespaceEntry.Lookup): If the current namespace-entry is
10860 implicit, don't search aliases and using tables.
10862 2005-02-01 Raja R Harinath <rharinath@novell.com>
10865 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
10867 (TypeContainer.BaseCache): Compute on demand.
10868 (TypeContainer.FindMembers): Define constants and types if they're
10869 not already created.
10870 (FieldMember.Define): Move resetting of ec.InUnsafe before error
10872 * const.cs (Constant.Define): Make idempotent.
10874 2005-01-29 Miguel de Icaza <miguel@novell.com>
10876 * pending.cs: Produce better code (no nops produced by using Ldarg
10879 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
10880 i - 1' it should be arg + 1.
10884 2005-01-28 Raja R Harinath <rharinath@novell.com>
10886 * attribute.cs (Attribute.CheckAttributeType): Make private
10888 (Attribute.ResolveType): Make virtual.
10889 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
10890 handling of RootContext.Tree.Types.
10892 2005-01-27 Raja R Harinath <rharinath@novell.com>
10894 Update attribute-handling to use the SimpleName/MemberAccess
10896 * cs-parser.jay (attribute): Pass in an expression to the
10897 constructors of Attribute and GlobalAttribute.
10898 * attribute.cs (Attribute): Take an expression for the name.
10899 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
10900 passed in attribute name expression.
10901 (Attribute.CheckAttributeType): Use it.
10902 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
10903 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
10904 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
10905 argument to prevent error messages if the lookup fails.
10907 2005-01-27 Marek Safar <marek.safar@seznam.cz>
10909 * expression.cs (Indirection): Implemented IVariable interface
10910 to support indirection in AddressOf operator.
10911 (PointerArithmetic.Emit): Add optimalization for case where
10912 result can be precomputed.
10914 2005-01-26 Martin Baulig <martin@ximian.com>
10916 * class.cs (TypeContainer.AttributeTargets): Return the correct
10917 AttributeTargets depending on our `Kind' instead of throwing an
10918 exception; fixes #71632.
10920 2005-01-26 Marek Safar <marek.safar@seznam.cz>
10923 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
10926 2005-01-25 Raja R Harinath <rharinath@novell.com>
10929 * expression.cs (MemberAccess.DoResolve): Don't complain with
10930 cs0572 when the LHS of a member access has identical name and type
10933 2005-01-25 Marek Safar <marek.safar@seznam.cz>
10936 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
10938 Create custom PermissionSet only for PermissionSetAttribute.
10940 2005-01-24 Marek Safar <marek.safar@seznam.cz>
10943 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
10944 delegates in static class.
10946 2005-01-24 Martin Baulig <martin@ximian.com>
10948 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10949 merging an implicit block, just use its reachability.
10951 * statement.cs (Block.Resolve): Make the unreachable code check
10952 work wrt. implicit blocks; see test-337 from #63842.
10954 2005-01-21 Alp Toker <alp@atoker.com>
10956 * cs-parser.jay: destructor_declaration's container is PartialContainer
10957 not Class when partial types are used, so use Kind prop instead of
10960 2005-01-22 Miguel de Icaza <miguel@ximian.com>
10962 * cs-parser.jay: Improve error reporting when an interface
10963 declares new types.
10965 2005-01-20 Dick Porter <dick@ximian.com>
10967 * support.cs: SeekableStreamReader fix from Sandor Dobos
10968 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
10969 chars are read. Fixes bug 70369.
10971 2005-01-20 Raja R Harinath <rharinath@novell.com>
10973 * cs-parser.jay (catch_clause): Simplify current_block handling
10976 2005-01-17 Miguel de Icaza <miguel@ximian.com>
10978 * convert.cs (ImplicitStandardConversionExists): Synchronize the
10979 code with ImplicitStandardConversion to handle the implicit
10980 conversion of method groups into valid delegate invocations.
10982 The problem is that in parameter handling we were using this code
10983 path. Fixes bug #64698
10985 2005-01-19 Raja R Harinath <rharinath@novell.com>
10987 * cs-parser.jay: Fix several infelicities.
10988 - Avoid assigning to the parser value stack. Code like
10989 '$3 = null' is unclean. Synthesize a value for the code block
10991 - Avoid using oob_stack for storing location information. Use ...
10992 (_mark_): ... this. New (empty) rule. Saves the current location
10994 (foreach_statement): Avoid using oob_stack for current_block
10995 handling. Use technique used in for_statement and
10996 using_statement. Synthesize a value for the code block to store
10997 additional intermediate information.
10999 2005-01-13 Miguel de Icaza <miguel@ximian.com>
11001 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
11002 of a different type is only allowed to private fields of a
11003 containing type, not on fields of a base class.
11005 See test-174.cs and error cs0122-9.cs
11007 2005-01-13 Raja R Harinath <rharinath@novell.com>
11009 Fix test-335.cs (bug #58126).
11010 * cs-parser.jay (argument): Split out non-expression parts of the
11011 rule into 'non_simple_argument'.
11012 (invocation_expression): Support parenthesized invocations with
11013 multiple arguments, and with single non-simple arguments.
11015 2005-01-13 Raja R Harinath <rharinath@novell.com>
11017 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
11020 2005-01-12 Raja R Harinath <rharinath@novell.com>
11022 Fix cs0038-1.cs, cs1640-6.cs.
11023 * ecore.cs (Expression.Resolve): Remove special-case for
11024 SimpleName in error-handling.
11025 (Expression.almostMatchedMembers): Relax access permission to
11027 (Expression.MemberLookupFailed): Handle duplicates in
11028 almostMatchedMembers list.
11029 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
11030 * expression.cs (New.DoResolve): Report CS1540 for more cases.
11031 * typemanager.cs (GetFullNameSignature): Use the MethodBase
11032 overload if the passed in MemberInfo is a MethodBase.
11034 2005-01-12 Marek Safar <marek.safar@seznam.cz>
11037 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
11038 for non-CAS & merge permission sets properly.
11040 2005-01-11 Raja R Harinath <rharinath@novell.com>
11042 Improve standard-compliance of simple name and member access
11043 resolution. Fixes bugs #52697, #57200, #67520, #69519.
11044 * ecore.cs (FullNamedExpression): New abstract base class
11045 for Namespaces and TypeExpressions.
11046 (ResolveFlags.SimpleName): Remove.
11047 (SimpleName): Remove support for dotted names.
11048 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
11049 DeclSpace.FindType and DeclSpace.LookupType.
11050 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
11051 (Expression.ExprClassName): Make member function.
11052 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
11053 a namespace. Remove creation of dotted "SimpleName"s.
11054 (MemberAccess.DoResolve): Likewise.
11055 * decl.cs (DeclSpace.Cache): Make private.
11056 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
11057 (DeclSpace.FindType): Update.
11058 (DeclSpace.LookupType): Move here from RootContext. Return a
11059 FullNamedExpression.
11060 * namespace.cs (Namespace): Derive from FullNamedExpression
11061 so that it can be part of expression resolution.
11062 (Namespace.Lookup): Return an FullNamedExpression.
11063 (NamespaceEntry.LookupAlias): Lookup aliases only in current
11065 * rootcontext.cs (NamespaceLookup): Remove.
11066 (LookupType): Move to DeclSpace.
11067 * attribute.cs (CheckAttributeType): Update.
11068 * doc.cs (FindDocumentedType): Remove allowAlias argument.
11069 (FindDocumentedTypeNonArray): Likewise.
11071 2005-01-11 Raja R Harinath <rharinath@novell.com>
11073 Fix cs0509.cs, cs1632.cs.
11074 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
11075 is the same as IsInterface.
11076 (TypeContainer.GetClassBases): Likewise.
11077 * statement.cs (LabeledStatement.ig): New field.
11078 (LabeledStatement.LabelTarget): Save ILGenerator which created the
11080 (LabeledStatement.DoEmit): Check that the label was created with
11081 the same ILGenerator.
11083 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11086 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
11087 accessors to its properties.
11089 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
11090 from accessors to property.
11092 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11095 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
11096 only for overrides.
11098 2005-01-08 Miguel de Icaza <miguel@ximian.com>
11100 * attribute.cs: Check for null and empty strings.
11102 I have lost another battle to Paolo.
11104 2005-01-07 Marek Safar <marek.safar@seznam.cz>
11107 * class.cs (PropertyMethod): Set Parent field in ctors.
11108 (SetMethod.InternalParameters): Add unsafe switch hack.
11109 Override MarkForDuplicationCheck where it is appropriate.
11111 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
11112 It says whether container allows members with the same name.
11113 Base default is no.
11114 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
11115 Removed is_method parameter.
11117 2005-01-06 Duncan Mak <duncan@ximian.com>
11119 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
11120 because the previous change led to incorrect reporting of CS1032
11121 ("Cannot define/undefine preprocessor symbols after first token in
11122 file"). Instead of using `tokens_seen' as the only flag that
11123 triggers CS1040, introduce `comments_seen'. This new flag is used
11124 to signify having seen comments on the current line, so it is
11125 unset after a newline.
11127 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11129 * doc.cs : When searching for a type, find nested type too.
11130 This fixes bug #71040.
11132 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11135 - Warn missing member comment on those classes which also does not
11136 have doc comments. Fixed bug #71041.
11137 - Don't warn missing doc comment on default constructor.
11140 2005-01-06 Duncan Mak <duncan@ximian.com>
11142 * cs-tokenizer.cs (xtoken): After handling traditional C-style
11143 comments, set `tokens_seen' to true. This allows us to detect
11144 misplaced preprocessor directives (i.e. not at the beginning of
11145 the a line, nor after whitespaces). In that case, report error
11146 CS1040. This fixes bug #56460.
11148 * cs-parser.jay (interface_member_declaration): Add checks for
11149 IsExplicitImpl, and report CS0541 error if an interface member is
11150 defined as an explicit interface declaration.
11152 2005-01-06 Marek Safar <marek.safar@seznam.cz>
11155 * class.cs (PropertyMethod): Set Parent field in ctors.
11156 (SetMethod.InternalParameters): Add unsafe switch hack.
11158 * decl.cs (MemberCore.Parent): Cannot be readonly.
11160 2005-01-06 Raja R Harinath <rharinath@novell.com>
11162 * decl.cs (DeclSpace.ResolveType): Remove.
11163 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
11164 Merge in code from ...
11165 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
11166 * class.cs, enum.cs: Update to changes.
11168 2005-01-06 Miguel de Icaza <miguel@ximian.com>
11170 * anonymous.cs: Ensure that we init the scope of our parent if it
11171 has not been initialized yet.
11173 2004-12-30 Duncan Mak <duncan@ximian.com>
11175 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
11176 if field.FieldBuilder is null. Fixes #70758.
11178 * convert.cs: Fixed some typos and updated some of the comments.
11179 (ImplicitStandardConversionExists):
11180 (TryImplicitIntConversion): If `target_type' is an interface and
11181 the type of `ic' implements this interface, return true or a new
11182 BoxedCast instead of null. This fixes #70468.
11184 2004-12-29 Duncan Mak <duncan@ximian.com>
11186 * expression.cs (Argument.Emit): Check that Expr is
11187 IMemoryLocation before casting to it, and report CS1510 otherwise.
11191 2004-12-21 Ben Maurer <bmaurer@ximian.com>
11193 * statement.cs (Block.ThisVariable): remove the recursion here, to
11194 make the --profile more sane.
11196 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
11198 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
11199 assembly, by JB Evain.
11201 2004-12-17 Raja R Harinath <rharinath@novell.com>
11203 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
11204 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
11205 "parent" refers to enclosing type/class. "base" refers to superclass.
11207 2004-12-17 Raja R Harinath <rharinath@novell.com>
11209 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11210 Ensure that we only have GlobalAttributes.
11211 * attribute.cs (Attribute.Emit): Make non-virtual.
11212 (GlobalAttribute.Emit): Remove.
11213 (Attribute.Resolve): Make virtual.
11214 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
11215 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
11216 the argument. Don't create one.
11217 (Attribute.GetObsoleteAttribute): Likewise.
11218 (Attribute.GetClsCompliantAttributeValue): Likewise.
11219 * class.cs, decl.cs: Update to changes.
11221 2004-12-17 Marek Safar <marek.safar@seznam.cz>
11223 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
11225 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
11227 * statement.cs (Foreach.Resolve): Add error 186 report.
11229 2004-12-16 Marek Safar <marek.safar@seznam.cz>
11231 * expression.cs (Conditional.DoResolve): Add warning 429.
11233 * statement.cs (If.Resolve): Add warning 665.
11235 2004-12-16 Raja R Harinath <rharinath@novell.com>
11237 New invariant: RootContext.Tree.Types.NamespaceEntry == null
11238 except when in the parser, and in GlobalAttribute.
11239 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
11240 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
11241 RootContext.Tree.Types.NamespaceEntry once work is done.
11242 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
11243 and resets RootContext.Tree.Types.NamespaceEntry.
11245 2004-12-15 Marek Safar <marek.safar@seznam.cz>
11247 * cs-parser.jay: Don't create a block for every variable.
11249 2004-12-14 Miguel de Icaza <miguel@ximian.com>
11251 * location.cs: Provide extra information.
11253 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
11254 variables from the captured environment, it is the ldarg_0.
11256 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11258 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
11261 * class.cs: Changed warning level for 169 to avoid developer
11262 displeasure from warning flooding. It will be changed back when they
11263 fix most of current BCL warnings.
11265 * RootContext.cs: Pushed default WarningLevel to 3.
11267 * statement.cs: Removed unused variable.
11269 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11271 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
11272 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
11273 Add error 502 report.
11274 (StaticClass.DefineType): Add error 441 report.
11275 (Class.AllowedModifiersProp): New virtual property as temporary
11276 extension to AllowedModifiers.
11277 (Class.DefineType): Add error 418 report. Moved ModFlags check here
11278 to share implementation with StaticClass and don't call virtual
11281 * driver.cs (MainDriver): Add error 1558 test.
11283 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
11284 report. Moved error 36 test here.
11286 * statement.cs (Throw.Resolve): Add error 724 report.
11288 * typemanager.cs: Add out_attribute_type core type.
11290 2004-12-13 Marek Safar <marek.safar@seznam.cz>
11292 * class.cs (TypeContainer.VerifyClsCompliance): Add error
11294 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
11296 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
11299 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
11301 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
11302 Add error 3023 report.
11303 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
11305 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
11308 2004-12-12 John Luke <john.luke@gmail.com>
11310 * driver.cs (AddArgs): take -- into account when
11311 adding arguments, fixes bug 65710
11313 2004-12-12 Martin Baulig <martin@ximian.com>
11315 * expression.cs (Unary.TryReduceNegative): Added support for
11316 SByteConstant and ByteConstant.
11317 (Unary.Reduce): Check error values from TryReduceNegative().
11319 2004-12-10 Marek Safar <marek.safar@seznam.cz>
11321 * attributes.cs (Attribute.Resolve): Avoid multiple error report
11322 and report exception as error 182.
11324 2004-12-10 Raja R Harinath <rharinath@novell.com>
11326 * driver.cs (Main): Fix message when there are warnings.
11328 2004-12-09 Miguel de Icaza <miguel@ximian.com>
11330 * delegate.cs: Fixed my fix from yesterday, sorry about that.
11332 2004-12-09 Marek Safar <marek.safar@seznam.cz>
11334 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
11335 Reduced number of warnings.
11337 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
11339 2004-12-08 Miguel de Icaza <miguel@ximian.com>
11341 * driver.cs: Removed message.
11343 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
11345 2004-12-08 <vargaz@freemail.hu>
11347 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
11349 2004-12-08 Martin Baulig <martin@ximian.com>
11351 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
11352 instead of a CS3002 for properties and indexer.
11354 2004-12-08 Martin Baulig <martin@ximian.com>
11356 * decl.cs (MemberName.ToString): Make this work again.
11358 2004-12-08 Marek Safar <marek.safar@seznam.cz>
11360 * attribute.cs (Resolve): Add error 591 detection.
11362 * class.cs (FieldMember.Define): Add error 1547 detection.
11363 (Indexer.Define): Add error 620 detection.
11364 (Operator.Define): Add error 590 detection.
11366 * ecore.cs: Missing argument for error 79.
11368 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
11371 2004-12-07 Marek Safar <marek.safar@seznam.cz>
11374 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
11377 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
11379 * cs-parser.jay : handle doc comments on implicit/explicit operators.
11380 Some operator comments were suppressed.
11381 * doc.cs : Implicit/explicit operator name in doc comments are like
11382 "op_Explicit(type)~returnType", so added suffix handling.
11384 2004-12-07 Martin Baulig <martin@ximian.com>
11387 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
11388 (MemberCore.GetClsCompliantAttributeValue): Likewise.
11389 (DeclSpace.ec): New protected field; store the EmitContext here.
11390 (DeclSpace.EmitContext): New public property; moved here from
11392 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
11395 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
11396 (Enum.Emit): Don't create a new EmitContext.
11398 * delegate.cs (Delegate.DefineType): Always create the
11401 * iterators.cs (Iterators.DefineIterator): Create a new
11402 EmitContext and store it in `ec'.
11404 2004-08-24 Martin Baulig <martin@ximian.com>
11407 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
11408 this for accessibility checks.
11409 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
11410 IsNestedFamilyAccessible.
11411 (TypeManager.IsSubclassOf): New method, do what the name actually
11414 2004-12-06 Raja R Harinath <rharinath@novell.com>
11416 Fix crash on cs0657-17.cs.
11417 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11418 Use RootContext.Tree.Types, not 'new RootTypes ()'.
11419 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
11420 the case where the NamespaceEntry gets overwritten.
11422 2004-12-06 Marek Safar <marek.safar@seznam.cz>
11424 Fixed #69195, #56821
11425 * ecore.cs (ResolveBoolean): Tiny refactoring.
11427 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
11428 of right expression resolving when left is false constant and
11429 operator is LogicalAnd OR true constant and operator is LogicalOr.
11431 * statement.cs (ResolveUnreachable): Always reports warning.
11433 2004-12-05 Miguel de Icaza <miguel@ximian.com>
11435 * class.cs: Distinguish between 1721 and 1722 (just a little help
11436 for the programmer).
11438 2004-12-03 Miguel de Icaza <miguel@ximian.com>
11440 * delegate.cs: Only allow this on new versions of the language.
11442 2004-12-02 Duncan Mak <duncan@ximian.com>
11444 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
11446 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
11447 here as a static method. Take an additional bool out parameter
11448 `must_do_cs1540_check' for signaling to InstanceResolve.
11449 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
11450 member field from PropertyExpr class and made it an argument of
11451 the method instead.
11452 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
11453 check for MarshalByRefObject, and report CS0122 instead of CS1540.
11454 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
11455 and `remove_accessor' as well as InstanceResolve: report CS0122
11460 2004-12-03 Raja R Harinath <rharinath@novell.com>
11462 Fix test-327.cs, test-328.cs, and put in early infrastructure
11463 for eventually fixing #52697.
11464 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
11465 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
11466 from other methods.
11467 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
11468 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
11469 (VerifyUsing, error246): Update.
11470 * rootcontext.cs (RootContext.NamespaceLookup): Just use
11471 'NamespaceEntry.LookupNamespaceOrType'.
11473 2004-12-03 Martin Baulig <martin@ximian.com>
11475 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11476 method as our child, call AnonymousMethod.Compatible() on it.
11478 2004-12-03 Raja R Harinath <rharinath@novell.com>
11480 Disable XML documentation support in 'basic' profile.
11481 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
11482 Redirect XmlElement to System.Object.
11483 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
11484 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
11485 * mcs.exe.sources: Add doc-bootstrap.cs.
11486 * doc-bootstrap.cs: New file. Contains empty stub implementation
11489 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
11491 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
11492 comments are allowed.
11494 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11496 * delegate.cs: Add checks for subtypes in paramaters and return values
11497 in VerifyMethod () to add support for Covariance/Contravariance
11500 2004-12-02 Miguel de Icaza <miguel@ximian.com>
11502 * report.cs: Remove extra closing parenthesis.
11504 * convert.cs (Error_CannotImplicitConversion): If the name of the
11505 types are the same, provide some extra information.
11507 * class.cs (FieldBase): Use an unused bit field from the field to
11508 encode the `has_offset' property from the FieldMember. This saves
11509 a couple of Ks on bootstrap compilation.
11511 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11512 method as our child, return the AnonymousMethod resolved
11515 * expression.cs (New.DoResolve): Allow return values from
11516 NewDelegate to also include AnonymousMethods.
11520 2004-12-02 Marek Safar <marek.safar@seznam.cz>
11523 * attribute.cs (Resolve): Improved implementation of params
11524 attribute arguments.
11526 * support.cs (ParameterData): Add HasParams to be faster.
11528 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
11530 all things are for /doc support:
11532 * doc.cs: new file that supports XML documentation generation.
11533 * mcs.exe.sources: added doc.cs.
11535 Handle /doc command line option.
11536 Report error 2006 instead of 5 for missing file name for /doc.
11537 Generate XML documentation when required, after type resolution.
11539 Added support for picking up documentation (/// and /** ... */),
11540 including a new XmlCommentState enumeration.
11542 Added lines to fill Documentation element for field, constant,
11543 property, indexer, method, constructor, destructor, operator, event
11544 and class, struct, interface, delegate, enum.
11545 Added lines to warn incorrect comment.
11547 Added Documentation field (passed only when /doc was specified).
11549 Added DocComment, DocCommentHeader, GenerateDocComment() and
11550 OnGenerateDocComment() and some supporting private members for
11551 /doc feature to MemberCore.
11553 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
11555 Added overriden DocCommentHeader.
11557 Added overriden DocCommentHeader and GenerateDocComment().
11559 2004-12-01 Miguel de Icaza <miguel@ximian.com>
11561 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
11562 unwrapping the enumeration values, chain to
11563 DoConstantNumericPromotions again, so we can promote things to the
11564 fundamental types (takes care of enums that are bytes, sbytes).
11568 2004-12-01 Raja R Harinath <rharinath@novell.com>
11570 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
11571 Fix long-standing bug in type-lookup. Use FindType instead of
11572 LookupType when ec.ResolvingTypeTree.
11573 (Attribute.ResolveType, Attribute.Resolve)
11574 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
11576 (Attributes.Search): Remove internal version. Update.
11577 (Attributes.SearchMulti): Update.
11578 (Attributes.GetClsCompliantAttribute): Remove.
11579 (Attributes.GetIndexerNameAttribute): Remove.
11580 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
11581 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
11582 * class.cs (Indexer.Define): Likewise.
11584 2004-12-01 Marek Safar <marek.safar@seznam.cz>
11587 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
11588 MarshallByReference members access.
11590 * expression.cs: Use CheckMarshallByRefAccess;
11591 Better error CS0197 message.
11593 * report.cs: Print whole related error message.
11595 2004-11-30 Raja R Harinath <rharinath@novell.com>
11597 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
11598 the current directory to help debugging.
11600 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11602 * class (GetClassBases): Better error 60 report.
11603 (EventProperty): Disabled warning 67 detection.
11605 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11608 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
11610 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
11613 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11616 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
11618 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
11620 2004-11-26 Miguel de Icaza <miguel@ximian.com>
11622 * attribute.cs (Attribute.Resolve): Refine error reporting and
11623 report a cs0117 if the identifier does not exist, to distinguish
11624 from 0617 which is a miss-use of the actual identifier.
11626 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
11627 between cs0070 and cs0079.
11629 * class.cs (MemberBase.DoDefine): When reporting a wrong
11630 accessibility level, we use MethodCore to compare instead of
11631 Method (this was a regression in some refactoring effort).
11633 So now we correctly report cs0056 again.
11635 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
11636 testing the target_type (which was known to be object_type) and
11637 not the source type (which is anonymous_method).
11639 Fixed reporting of error cs1660.
11641 * expression.cs (UserCast.Source): Expose the underlying cast.
11643 * statement.cs (Switch.SwitchGoverningType): Sort the list of
11644 allowed types to find a match to int32 first (most common).
11646 In addition, it ignores any ImplicitUserConversions that did an
11647 internal implicit conversion (as the switch statement allows only
11648 one integral conversion to exist).
11650 * class.cs (PartialContainer.Create): rename `name' to
11651 `member_name' for clarity. Then replace the string calls with a
11652 call to MemberName.GetPartialName, as now using
11653 MemberName.ToString is an error (this is due to the side effects
11654 it had, that were fixed in the past).
11656 This will restore the error reporting on a number of partial class
11657 errors that were missusing this (and getting an exception as a
11658 results, which is now just a plain textual warning, because
11659 yyparse debug output would crash otherwise).
11661 2004-11-26 Raja R Harinath <rharinath@novell.com>
11663 * Makefile (PROGRAM_INSTALL_DIR): Remove.
11665 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11667 * rootcontext.cs (LookupType): Make sure to cache lookups that
11668 don't give us a negative result. This saves about 5% of corlib
11671 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11673 * report.cs (AbstractMessage.Print): messages are sent to stderr
11675 * class.cs (TypeContainer.GetClassBases): It is an error to have a
11676 non-interface in the list of interfaces (at this point, either
11677 parent was properly set, or a base class is being listed in the
11678 interfaces section).
11680 This flags error 1722, and resolves the crash from bug 69259.
11682 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11684 * statement.cs (Using.EmitExpressionFinally): make this work right
11685 for valuetypes. Fixes 69926.
11687 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11689 * const.cs (Const.ChangeType): Cope with the "0 literal can be
11690 converted to an enum" here, before we try to change the underlying
11691 type. This code exists, but it is a different code path than the
11692 one used while encoding constants.
11694 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
11695 old bug: when converting from the null literal to a pointer,
11696 return an EmptyCast, not the NullLiteral.
11698 This fixes #69921, the recent null_type changes probably made this
11699 bug more prominent.
11701 (ImplicitReferenceConversionExists): In addition, resynchronized
11702 the code here, so it matches the same code in
11703 ImplicitReferenceConversionExists for the `from any class-type S
11704 to any interface-type T'.
11707 2004-11-25 Marek Safar <marek.safar@seznam.cz>
11709 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
11711 2004-11-24 Miguel de Icaza <miguel@ximian.com>
11713 * cs-parser.jay: Use verbosity accordingly.
11715 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11717 * expression.cs (Unary.ResolveOperator): Do not report warning;
11718 AddressOf reads from variable.
11720 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
11722 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11726 * attribute.cs (Attributable): Removed CheckTargets.
11727 (Attributes.Emit): Explicit attribute targets are tested here.
11729 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
11730 not enabled for interfaces.
11732 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
11733 (GetAssemblyName): Ouch next bug there.
11735 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11737 * expression.cs: Error 275 added.
11739 2004-11-23 Marek Safar <marek.safar@seznam.cz>
11741 Fix bug #69177 (Implemented decimal constant support)
11743 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
11744 (BinaryFold): Add DecimalConstant.
11746 * const.cs (Define): Decimal constant
11748 (ChangeType): Add decimal type handling.
11749 (LookupConstantValue): Don't set value for decimal type but
11750 emit DecimalConstantAttribute. Needed for constant optimization.
11752 * constant.cs (ToDecimal): New method.
11753 (ConvertToDecimal): New method.
11754 (IntConstant): Implemented ConvertToDecimal.
11755 (DecimalConstant.Emit): Emit optimized version for decimals in
11758 * expression.cs (ResolveOperator): Changed order of constant
11759 reduction to work correctly with native types which have
11760 overloaded operators.
11761 (ResolveMemberAccess): Extract constant value from attribute
11764 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
11766 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
11767 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
11768 (ChangeType): Decimal is special.
11769 (TypeToCoreType): Add decimal type.
11771 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11773 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
11776 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11778 * class.cs (EventField.ApplyAttributeBuilder): Fix error
11781 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11783 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
11785 * pending.cs (PendingImplementation): Grab only interfaces.
11787 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11789 * statement.cs (ForeachHelperMethods): Add location member and
11790 error 202 detection.
11792 2004-11-19 Raja R Harinath <rharinath@novell.com>
11794 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
11795 automatically handled by executable.make.
11796 (PROGRAM): Make profile-specific.
11798 2004-11-18 Marek Safar <marek.safar@seznam.cz>
11800 * expression.cs (DoResolveBase): Fixed wrong warning for out
11803 2004-11-18 Martin Baulig <martin@ximian.com>
11805 Merged latest changes into gmcs. Please keep this comment in
11806 here, it makes it easier for me to see what changed in MCS since
11807 the last time I merged.
11809 2004-11-17 Raja R Harinath <rharinath@novell.com>
11811 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
11812 (TypeHandle.GetMemberCache): New.
11813 (TypeHandle.TypeHandle): Update.
11814 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
11815 (TypeManager.LookupParentInterfacesCache):
11816 Rename from LookupInterfaceCache. Optimize slightly.
11817 (TypeManager.MemberLookup_FindMembers): Update.
11818 * decl.cs (MemberCache.MemberCache): Set Container to null in the
11819 multi-type variant.
11820 (AddCacheContents): Rename from AddHashtable.
11821 * class.cs (TypeContainer.parent_container): Remove.
11822 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
11823 (TypeContainer.DoDefineMembers): Don't initialize it.
11824 Update to name changes.
11826 2004-11-17 Miguel de Icaza <miguel@ximian.com>
11828 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
11829 that factors the code to check access modifiers on override.
11831 (PropertyBase): Use the code here.
11833 Patch from Lluis S'anchez, fixes bug #69361.
11835 2004-11-15 Miguel de Icaza <miguel@ximian.com>
11837 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
11838 routine that is used to report the use of a captured variable
11839 whose address has been taken.
11841 There are two checks: one when variables are being captured and
11842 the other check is when the address of a variable is taken.
11844 (because an anonymous methods might be resolved before *or* after
11845 the address has been taken) and
11847 * expression.cs (Conditional.DoResolve): Remove the special
11848 casing that Martin added to trueExpr and falseExpr being both
11849 NullLiteral. We get the right behavior now just by introducing
11850 the null_type into the compiler.
11852 * convert.cs (ExplicitConversion): Change the code to use
11853 null_type instead of testing `expr is NullLiteral'.
11854 (ImplicitConversionStandard): use null_type too.
11855 (ImplicitReferenceConversionExists): use null_type too.
11856 (ImplicitReferenceConversion): use null_type too.
11858 * literal.cs: The type of `NullLiteral' is now null_type instead
11860 (Resolve): Set the type here.
11862 * typemanager.cs: Introduce null_type.
11864 2004-11-17 Martin Baulig <martin@ximian.com>
11866 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
11867 direction, like FindMembers() does. Fixes #69546, testcase is in
11870 2004-11-16 Martin Baulig <martin@ximian.com>
11872 This is based on a patch from Marek Safar, see bug #69082.
11873 Fixes bugs #63705 and #67130.
11875 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
11876 method; create a MemberCache for an interface type and cache the
11879 * decl.cs (IMemberContainer.ParentContainer): Removed.
11880 (IMemberContainer.ParentCache): New property.
11881 (MemberCache.SetupCacheForInterface): Removed.
11882 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
11883 to create a cache for an interface's "parent".
11885 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
11888 2004-11-16 Martin Baulig <martin@ximian.com>
11890 Merged back from gmcs; these changes already went into gmcs a
11891 couple of weeks ago.
11894 (TypeManager.AddUserType): Removed the `ifaces' argument.
11895 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
11897 (TypeManager.AddUserInterface): Removed.
11898 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
11900 (TypeManager.GetInterfaces): Likewise.
11901 (TypeManager.GetExplicitInterfaces): Likewise.
11903 * ecore.cs (TypeExpr.GetInterfaces): Removed.
11905 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
11906 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
11908 2004-11-14 Ben Maurer <bmaurer@ximian.com>
11910 * statement.cs: Avoid adding bools to a hashtable.
11912 2004-11-07 Miguel de Icaza <miguel@ximian.com>
11914 * expression.cs (Invocation.OverloadResolve): Flag error if we are
11915 calling an unsafe method from a safe location.
11917 2004-11-06 Marek Safar <marek.safar@seznam.cz>
11920 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
11922 2004-11-06 Miguel de Icaza <miguel@ximian.com>
11924 * namespace.cs (VerifyUsing): use GetPartialName instead of
11927 2004-11-05 Miguel de Icaza <miguel@ximian.com>
11929 * statement.cs (Return.Resolve): Fix regression in typo: if
11930 `in_exc', we have to request a NeedReturnLabel, this was a typo
11931 introduced in the anonymous method check-in. Fixes #69131.
11933 * Indexers were using the ShortName when defining themselves,
11934 causing a regression in the compiler bootstrap when applying the
11935 patch from 2004-11-02 (first part), now they use their full name
11936 and the bug is gone.
11938 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
11940 * driver.cs: Strip the path from the names of embedded resources. Fixes
11943 2004-11-04 Raja R Harinath <rharinath@novell.com>
11945 Fix error message regression: cs0104-2.cs.
11946 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
11947 (AliasEntry.Resolve): Update.
11948 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
11950 (RootContext.LookupType): Update.
11952 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
11954 * cs-parser.jay: Add support for handling accessor modifiers
11955 * class: Add support port accessor modifiers and error checking,
11956 define PropertyMethod.Define as virtual (not abstract anymore)
11957 * ecore.cs: Add checking for proeprties access with access modifiers
11958 * iterators.cs: Modify Accessor constructor call based in the modified
11960 2004-11-02 Ben Maurer <bmaurer@ximian.com>
11962 * expression.cs (StringConcat): Handle being called twice,
11963 as when we have a concat in a field init with more than two
11966 2004-11-02 Miguel de Icaza <miguel@ximian.com>
11968 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
11969 special case explicit implementations, we should always produce
11970 the .property or .event declaration.
11972 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
11973 since it will not return correct data if people use this
11974 unresolved in the presence of using statements (see test-313).
11976 * class.cs (MethodData.Define): If we are an explicit interface
11977 implementation, set the method name to the full name of the
11978 interface plus the name of the method.
11980 Notice that using the method.MethodName.GetFullName() does not
11981 work, as it will only contain the name as declared on the source
11982 file (it can be a shorthand in the presence of using statements)
11983 and not the fully qualifed type name, for example:
11987 class D : ICloneable {
11988 object ICloneable.Clone () {
11992 Would produce a method called `ICloneable.Clone' instead of
11993 `System.ICloneable.Clone'.
11995 * namespace.cs (Alias.Resolve): Use GetPartialName.
11997 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11999 * cs-parser.jay: Add error 1055 report.
12001 2004-11-01 Miguel de Icaza <miguel@ximian.com>
12003 * assign.cs (Assign.DoResolve): Only do the transform of
12004 assignment into a New if the types are compatible, if not, fall
12005 through and let the implicit code deal with the errors and with
12006 the necessary conversions.
12008 2004-11-01 Marek Safar <marek.safar@seznam.cz>
12010 * cs-parser.jay: Add error 1031 report.
12012 * cs-tokenizer.cs: Add location for error 1038.
12014 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12016 * cs-parser.jay: Add error 1016 report.
12018 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12020 * cs-parser.jay: Add errors 1575,1611 report.
12022 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12024 * cs-parser.jay: Add error 1001 report.
12026 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12029 * attribute.cs (GetMarshal): Add method argument for
12030 caller identification.
12032 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
12033 agument for GetMarshal and RuntimeMissingSupport.
12035 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12037 * attribute.cs (ExtractSecurityPermissionSet): Removed
12038 TypeManager.code_access_permission_type.
12040 * typemanager.cs: Removed TypeManager.code_access_permission_type.
12042 2004-10-27 Miguel de Icaza <miguel@ximian.com>
12044 * expression.cs (LocalVariableReference.DoResolveLValue): Check
12045 for obsolete use of a variable here. Fixes regression on errors
12046 cs0619-25 and cs0619-26.
12048 2004-10-27 Marek Safar <marek.safar@seznam.cz>
12050 Fix #62358, implemented security attribute encoding.
12052 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
12053 Tests permitted SecurityAction for assembly or other types.
12054 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
12055 data from SecurityPermissionAttribute to PermisionSet class.
12057 * class.cs (ApplyAttributeBuilder): Added special handling
12058 for System.Security.Permissions.SecurityAttribute based types.
12060 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
12061 special handling for System.Security.Permissions.SecurityAttribute
12064 * enum.cs (ApplyAttributeBuilder): Added special handling
12065 for System.Security.Permissions.SecurityAttribute based types.
12067 * parameter.cs (ApplyAttributeBuilder): Added special handling
12068 for System.Security.Permissions.SecurityAttribute based types.
12070 * rootcontext.cs: Next 2 core types.
12072 * typemanager.cs (TypeManager.security_permission_attr_type):
12073 Built in type for the SecurityPermission Attribute.
12074 (code_access_permission_type): Build in type.
12076 2004-10-17 Miguel de Icaza <miguel@ximian.com>
12078 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
12079 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
12080 all of this information into
12081 EmitContext.EmitCapturedVariableInstance.
12083 * codegen.cs (EmitCapturedVariableInstance): move here the
12084 funcionality of emitting an ldarg.0 in the presence of a
12085 remapping. This centralizes the instance emit code.
12087 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
12088 then emit a load of this: it means that we have reached the
12089 topmost ScopeInfo: the one that contains the pointer to the
12090 instance of the class hosting the anonymous method.
12092 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
12093 captures to the topmost CaptureContext.
12095 2004-10-12 Miguel de Icaza <miguel@ximian.com>
12097 * expression.cs (LocalVariableReference): Move the knowledge about
12098 the iterators into codegen's EmitCapturedVariableInstance.
12100 2004-10-11 Miguel de Icaza <miguel@ximian.com>
12102 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
12103 all code paths return a value from an anonymous method (it is the
12104 same as the 161 error, but for anonymous methods).
12106 2004-10-08 Miguel de Icaza <miguel@ximian.com>
12108 The introduction of anonymous methods in the compiler changed
12109 various ways of doing things in the compiler. The most
12110 significant one is the hard split between the resolution phase
12111 and the emission phases of the compiler.
12113 For instance, routines that referenced local variables no
12114 longer can safely create temporary variables during the
12115 resolution phase: they must do so from the emission phase,
12116 since the variable might have been "captured", hence access to
12117 it can not be done with the local-variable operations from the runtime.
12121 (Block.Flags): New flag `IsTopLevel' to indicate that this block
12122 is a toplevel block.
12124 (ToplevelBlock): A new kind of Block, these are the blocks that
12125 are created by the parser for all toplevel method bodies. These
12126 include methods, accessors and anonymous methods.
12128 These contain some extra information not found in regular blocks:
12129 A pointer to an optional CaptureContext (for tracking captured
12130 local variables and parameters). A pointer to the parent
12133 (Return.Resolve): Catch missmatches when returning a value from an
12134 anonymous method (error 1662).
12135 Invoke NeedReturnLabel from the Resolve phase instead of the emit
12138 (Break.Resolve): ditto.
12140 (SwitchLabel): instead of defining the labels during the
12141 resolution phase, we now turned the public ILLabel and ILLabelCode
12142 labels into methods called GetILLabelCode() and GetILLabel() that
12143 only define the label during the Emit phase.
12145 (GotoCase): Track the SwitchLabel instead of the computed label
12146 (its contained therein). Emit the code by using
12147 SwitchLabel.GetILLabelCode ().
12149 (LocalInfo.Flags.Captured): A new flag has been introduce to track
12150 whether the Local has been captured or not.
12152 (LocalInfo.IsCaptured): New property, used to tell whether the
12153 local has been captured.
12155 * anonymous.cs: Vastly updated to contain the anonymous method
12158 The main classes here are: CaptureContext which tracks any
12159 captured information for a toplevel block and ScopeInfo used to
12160 track the activation frames for various local variables.
12162 Each toplevel block has an optional capture context associated
12163 with it. When a method contains an anonymous method both the
12164 toplevel method and the anonymous method will create a capture
12165 context. When variables or parameters are captured, they are
12166 recorded on the CaptureContext that owns them, for example:
12170 MyDelegate d = delegate {
12175 Here `a' will be recorded as captured on the toplevel
12176 CapturedContext, the inner captured context will not have anything
12177 (it will only have data if local variables or parameters from it
12178 are captured in a nested anonymous method.
12180 The ScopeInfo is used to track the activation frames for local
12181 variables, for example:
12183 for (int i = 0; i < 10; i++)
12184 for (int j = 0; j < 10; j++){
12185 MyDelegate d = delegate {
12190 At runtime this captures a single captured variable `i', but it
12191 captures 10 different versions of the variable `j'. The variable
12192 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
12193 recorded on a child.
12195 The toplevel ScopeInfo will also track information like the `this'
12196 pointer if instance variables were referenced (this is necessary
12197 as the anonymous method lives inside a nested class in the host
12198 type of the method).
12200 (AnonymousMethod): Expanded to track the Toplevel, implement
12201 `AnonymousMethod.Compatible' to tell whether an anonymous method
12202 can be converted to a target delegate type.
12204 The routine now also produces the anonymous method content
12206 (AnonymousDelegate): A helper class that derives from
12207 DelegateCreation, this is used to generate the code necessary to
12208 produce the delegate for the anonymous method that was created.
12210 * assign.cs: API adjustments for new changes in
12211 Convert.ImplicitStandardConversionExists.
12213 * class.cs: Adjustments to cope with the fact that now toplevel
12214 blocks are of type `ToplevelBlock'.
12216 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
12217 insteda of standard blocks.
12219 Flag errors if params arguments are passed to anonymous methods.
12221 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
12222 `CurrentAnonymousMethod' which points to the current Anonymous
12223 Method. The variable points to the AnonymousMethod class that
12224 holds the code being compiled. It is set in the new EmitContext
12225 created for the anonymous method.
12227 (EmitContext.Phase): Introduce a variable and an enumeration to
12228 assist in enforcing some rules about when and where we are allowed
12229 to invoke certain methods (EmitContext.NeedsReturnLabel is the
12230 only one that enfonces this right now).
12232 (EmitContext.HaveCaptureInfo): new helper method that returns
12233 whether we have a CapturedContext initialized.
12235 (EmitContext.CaptureVariable): New method used to register that a
12236 LocalInfo must be flagged for capturing.
12238 (EmitContext.CapturedParameter): New method used to register that a
12239 parameters must be flagged for capturing.
12241 (EmitContext.CapturedField): New method used to register that a
12242 field must be flagged for capturing.
12244 (EmitContext.HaveCapturedVariables,
12245 EmitContext.HaveCapturedFields): Return whether there are captured
12246 variables or fields.
12248 (EmitContext.EmitMethodHostInstance): This is used to emit the
12249 instance for the anonymous method. The instance might be null
12250 (static methods), this (for anonymous methods that capture nothing
12251 and happen to live side-by-side with the current method body) or a
12252 more complicated expression if the method has a CaptureContext.
12254 (EmitContext.EmitTopBlock): Routine that drives the emission of
12255 code: it will first resolve the top block, then emit any metadata
12256 and then emit the code. The split is done so that we can extract
12257 any anonymous methods and flag any captured variables/parameters.
12259 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
12260 during this phase, the ILGenerator should not be used as labels
12261 and local variables declared here might not be accessible to any
12262 code that is part of an anonymous method.
12264 Exceptions to this include the temporary variables that are
12265 created by some statements internally for holding temporary
12268 (EmitContext.EmitMeta): New routine, in charge of emitting all the
12271 (EmitContext.TemporaryReturn): This method is typically called
12272 from the Emit phase, and its the only place where we allow the
12273 ReturnLabel to be defined other than the EmitMeta. The reason is
12274 that otherwise we would have to duplicate a lot of logic in the
12275 Resolve phases of various methods that today is on the Emit
12278 (EmitContext.NeedReturnLabel): This no longer creates the label,
12279 as the ILGenerator is not valid during the resolve phase.
12281 (EmitContext.EmitThis): Extended the knowledge in this class to
12282 work in anonymous methods in addition to iterators.
12284 (EmitContext.EmitCapturedVariableInstance): This emits whatever
12285 code is necessary on the stack to access the instance to a local
12286 variable (the variable will be accessed as a field).
12288 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
12289 EmitContext.EmitAddressOfParameter): Routines to support
12290 parameters (not completed at this point).
12292 Removals: Removed RemapLocal and RemapLocalLValue. We probably
12293 will also remove the parameters.
12295 * convert.cs (Convert): Define a `ConstantEC' which points to a
12296 null. This is just to prefity some code that uses
12297 ImplicitStandardConversion code and do not have an EmitContext
12300 The idea is to flag explicitly that at that point in time, it is
12301 known that the conversion will not trigger the delegate checking
12302 code in implicit conversions (which requires a valid
12305 Everywhere: pass new EmitContext parameter since
12306 ImplicitStandardConversionExists now requires it to check for
12307 anonymous method conversions.
12309 (Convert.ImplicitStandardConversionExists): If the type of an
12310 expression is the anonymous_method_type, and the type is a
12311 delegate, we invoke the AnonymousMethod.Compatible method to check
12312 whether an implicit conversion is possible.
12314 (Convert.ImplicitConversionStandard): Only do implicit method
12315 group conversions if the language level is not ISO_1.
12317 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
12318 MethodInfo for the Invoke method. used by Delegate and
12321 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
12322 method conversions if the target type is a delegate.
12324 Removed extra debugging nops.
12326 (LocalVariableReference): Turn the `local_info' into a public
12329 Add `prepared' field, the same hack used for FieldExprs to cope
12330 with composed assignments, as Local variables do not necessarily
12331 operate purely on the stack as they used to: they can be captured
12334 Add `temp' for a temporary result, like fields.
12336 Refactor DoResolve and DoResolveLValue into DoResolveBase.
12338 It now copes with Local variables that are captured and emits the
12339 proper instance variable to load it from a field in the captured
12342 (ParameterReference.DoResolveBase): During the resolve phase,
12343 capture parameters if we are in an anonymous method.
12345 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
12346 anonymous method, use the EmitContext helper routines to emit the
12347 parameter reference.
12349 * iterators.cs: Set RemapToProxy to true/false during the
12352 * parameters.cs (GetParameterByName): New helper method.
12354 * typemanager.cs (anonymous_method_type) a new type that
12355 represents an anonyous method. This is always an internal type,
12356 used as a fencepost to test against the anonymous-methodness of an
12359 2004-10-20 Marek Safar <marek.safar@seznam.cz>
12361 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
12363 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
12365 2004-10-18 Martin Baulig <martin@ximian.com>
12367 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
12368 `Type' directly, but call ResolveType() on it.
12369 (Catch.Resolve): Likewise.
12370 (Foreach.Resolve): Likewise.
12372 2004-10-18 Martin Baulig <martin@ximian.com>
12374 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
12375 `Type' directly, but call ResolveType() on it.
12376 (Probe.DoResolve): Likewise.
12377 (ArrayCreation.LookupType): Likewise.
12378 (TypeOf.DoResolve): Likewise.
12379 (SizeOf.DoResolve): Likewise.
12381 2004-10-18 Martin Baulig <martin@ximian.com>
12383 * expression.cs (Invocation.BetterFunction): Put back
12384 TypeManager.TypeToCoreType().
12386 2004-10-18 Raja R Harinath <rharinath@novell.com>
12388 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
12391 2004-10-18 Martin Baulig <martin@ximian.com>
12393 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
12394 `Type' directly, but call ResolveType() on it.
12396 2004-10-18 Martin Baulig <martin@ximian.com>
12398 * class.cs (FieldMember.Define): Don't access the TypeExpr's
12399 `Type' directly, but call ResolveType() on it.
12400 (MemberBase.DoDefine): Likewise.
12402 * expression.cs (New.DoResolve): Don't access the TypeExpr's
12403 `Type' directly, but call ResolveType() on it.
12404 (ComposedCast.DoResolveAsTypeStep): Likewise.
12406 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
12407 `Type' directly, but call ResolveType() on it.
12409 2004-10-17 John Luke <john.luke@gmail.com>
12411 * class.cs (Operator.GetSignatureForError): use CSharpName
12413 * parameter.cs (Parameter.GetSignatureForError): Returns
12414 correct name even if was not defined.
12416 2004-10-13 Raja R Harinath <rharinath@novell.com>
12419 * class.cs (TypeContainer.EmitContext): New property.
12420 (DefineNestedTypes): Create an emitcontext for each part.
12421 (MethodCore.DoDefineParameters): Use container's emitcontext.
12422 Pass type array to InternalParameters.
12423 (MemberBase.DoDefine): Use container's emitcontext.
12424 (FieldMember.Define): Likewise.
12425 (Event.Define): Likewise.
12426 (SetMethod.GetParameterInfo): Change argument to EmitContext.
12427 Pass type array to InternalParameters.
12428 (SetIndexerMethod.GetParameterInfo): Likewise.
12429 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
12430 * delegate.cs (Define): Pass emitcontext to
12431 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
12432 array to InternalParameters.
12433 * expression.cs (ParameterReference.DoResolveBase): Pass
12434 emitcontext to GetParameterInfo.
12435 (ComposedCast.DoResolveAsTypeStep): Remove check on
12436 ec.ResolvingTypeTree.
12437 * parameter.cs (Parameter.Resolve): Change argument to
12438 EmitContext. Use ResolveAsTypeTerminal.
12439 (Parameter.GetSignature): Change argument to EmitContext.
12440 (Parameters.ComputeSignature): Likewise.
12441 (Parameters.ComputeParameterTypes): Likewise.
12442 (Parameters.GetParameterInfo): Likewise.
12443 (Parameters.ComputeAndDefineParameterTypes): Likewise.
12444 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
12445 * support.cs (InternalParameters..ctor): Remove variant that takes
12447 * typemanager.cs (system_intptr_expr): New.
12448 (InitExpressionTypes): Initialize it.
12450 2004-10-12 Chris Toshok <toshok@ximian.com>
12452 * cs-parser.jay: fix location for try_statement and catch_clause.
12454 2004-10-11 Martin Baulig <martin@ximian.com>
12456 * report.cs: Don't make --fatal abort on warnings, we have
12457 -warnaserror for that.
12459 2004-10-07 Raja R Harinath <rharinath@novell.com>
12461 More DeclSpace.ResolveType avoidance.
12462 * decl.cs (MemberCore.InUnsafe): New property.
12463 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
12464 with newly created EmitContext.
12465 (FieldMember.Define): Likewise.
12466 * delegate.cs (Delegate.Define): Likewise.
12467 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
12468 only if normal name-lookup fails.
12469 (TypeExpr.DoResolve): Enable error-checking.
12470 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
12471 (SizeOf.DoResolve): Likewise.
12472 (ComposedCast.DoResolveAsTypeStep): Likewise.
12473 (StackAlloc.DoResolve): Likewise.
12474 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
12475 (Block.Unsafe): New property.
12476 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
12477 (Unsafe): Set 'unsafe' flag of contained block.
12478 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
12479 (Fixed.Resolve): Likewise.
12480 (Catch.Resolve): Likewise.
12481 (Using.ResolveLocalVariableDecls): Likewise.
12482 (Foreach.Resolve): Likewise.
12484 2004-10-05 John Luke <john.luke@gmail.com>
12486 * cs-parser.jay: add location to error CS0175
12488 2004-10-04 Miguel de Icaza <miguel@ximian.com>
12490 * ecore.cs (Expression.Constantity): Add support for turning null
12493 * const.cs (Const.Define): Allow constants to be reference types
12494 as long as the value is Null.
12496 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
12498 * namespace.cs (NamespaceEntry.Using): No matter which warning
12499 level is set, check if this namespace name has already been added.
12501 2004-10-03 Ben Maurer <bmaurer@ximian.com>
12503 * expression.cs: reftype [!=]= null should always use br[true,false].
12506 2004-10-03 Marek Safar <marek.safar@seznam.cz>
12509 * attribute.cs: Enum conversion moved to
12510 GetAttributeArgumentExpression to be applied to the all
12513 2004-10-01 Raja R Harinath <rharinath@novell.com>
12515 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
12516 * class.c (TypeContainer.DefineType): Flag error if
12517 base types aren't accessible due to access permissions.
12518 * decl.cs (DeclSpace.ResolveType): Move logic to
12519 Expression.ResolveAsTypeTerminal.
12520 (DeclSpace.ResolveTypeExpr): Thin layer over
12521 Expression.ResolveAsTypeTerminal.
12522 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
12523 Refactor code into NestedAccess. Use it.
12524 (DeclSpace.NestedAccess): New.
12525 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
12526 argument to silence errors. Check access permissions.
12527 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
12528 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
12529 (Cast.DoResolve): Likewise.
12530 (New.DoResolve): Likewise.
12531 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
12532 (TypeOf.DoResolve): Likewise.
12534 * expression.cs (Invocation.BetterConversion): Return the Type of
12535 the better conversion. Implement section 14.4.2.3 more faithfully.
12536 (Invocation.BetterFunction): Make boolean. Make correspondence to
12537 section 14.4.2.2 explicit.
12538 (Invocation.OverloadResolve): Update.
12539 (Invocation): Remove is_base field.
12540 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
12541 (Invocation.Emit): Likewise.
12543 2004-09-27 Raja R Harinath <rharinath@novell.com>
12545 * README: Update to changes.
12547 2004-09-24 Marek Safar <marek.safar@seznam.cz>
12549 * cs-parser.jay: Reverted 642 warning fix.
12551 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12554 * decl.cs (FindMemberWithSameName): Indexer can have more than
12557 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12559 * expression.cs (LocalVariableReference.DoResolveLValue):
12560 Do not report warning 219 for out values.
12561 (EmptyExpression.Null): New member to avoid extra allocations.
12563 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12565 * cs-parser.jay: Fix wrong warning 642 report.
12567 * cs-tokenizer.cs (CheckNextToken): New helper;
12568 Inspect next character if is same as expected.
12570 2004-09-23 Martin Baulig <martin@ximian.com>
12572 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
12573 (Convert.ImplicitReferenceConversionExists): Likewise.
12575 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12577 * class.cs (Operator.Define): Add error 448 and 559 report.
12579 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12581 * class.cs (MemberBase.IsTypePermitted): New protected
12582 method for checking error CS0610.
12584 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12586 * class.cs (TypeContainer.HasExplicitLayout): New property
12587 Returns whether container has StructLayout attribute set Explicit.
12588 (FieldMember): New abstract class for consts and fields.
12589 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
12590 (Field): Reuse FieldMember.
12592 * const.cs (Const): Reuse FieldMember.
12594 * rootcontext.cs: EmitConstants call moved to class.
12596 2004-09-22 Martin Baulig <martin@ximian.com>
12598 Thanks to Peter Sestoft for this bug report.
12600 * expression.cs (Conditional): If both the `trueExpr' and the
12601 `falseExpr' is a NullLiteral, return a NullLiteral.
12603 2004-09-22 Martin Baulig <martin@ximian.com>
12605 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
12606 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
12607 for the "get_Current" call.
12609 2004-09-22 Martin Baulig <martin@ximian.com>
12611 Marek and me just fixed one of our oldest bugs: #28562 :-)
12613 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
12615 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
12616 we're an EnumConstant, just return that.
12617 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
12618 an EnumConstant. In this case, we need to use GetValueAsEnumType()
12619 to get the value which'll actually be written into the attribute.
12620 However, we have to use GetValue() to access the attribute's value
12623 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12625 * constant.cs (Constant.IsNegative): New abstract property
12628 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
12629 (StackAlloc.DoResolve): Reused IsNegative.
12631 2004-09-21 Martin Baulig <martin@ximian.com>
12633 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
12634 if we're used in an iterator, we may be called from different
12637 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
12638 we actually have an exception block.
12640 2004-09-20 John Luke <jluke@cfl.rr.com>
12642 * class.cs, cs-parser.jay: Improve the error report for 1520:
12643 report the actual line where the error happens, not where the
12644 class was declared.
12646 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
12647 Pass location information that was available elsewhere.
12649 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
12651 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
12652 runtime to delay sign assemblies.
12654 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12656 * cs-parser.jay: Do not report the stack trace, this is barely
12659 2004-08-22 John Luke <john.luke@gmail.com>
12661 * driver.cs : check that a resource id is not already used
12662 before adding it, report CS1508 if it is, bug #63637
12664 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12666 * ecore.cs: Removed dead code.
12668 2004-09-18 Marek Safar <marek.safar@seznam.cz>
12670 * class.cs: Do not report warning CS0067 on the interfaces.
12672 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12674 * cs-parser.jay: Add error 504 report.
12676 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12678 * rootcontext.cs: WarningLevel is 4 by default now.
12680 * statement.cs (Fixed.Resolve): Do not null
12683 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12686 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
12687 deep search when property is not virtual.
12688 (PropertyExpr.ResolveAccessors): Make one call for both
12691 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12694 * statement.cs: Error 152 report constains also location.
12696 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12699 * const.cs: Explicitly set constant as static.
12701 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12704 * cs-parser.jay: Add error 1017 report.
12706 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12708 Fixed bug #59980, #64224
12709 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
12711 * typemanager.cs (IsSpecialMethod): Simplified
12713 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12715 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
12716 condition with better params.
12718 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12721 * attribute.cs (Resolve): Property has to have both
12724 2004-09-14 Martin Baulig <martin@ximian.com>
12726 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
12728 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12731 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
12732 called and is obsolete then this member suppress message
12733 when call is inside next [Obsolete] method or type.
12735 * expression.cs: Use TestObsoleteMethodUsage member.
12737 2004-09-14 Martin Baulig <martin@ximian.com>
12739 * cs-parser.jay: Sync a bit with the GMCS version.
12741 2004-09-14 Martin Baulig <martin@ximian.com>
12743 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
12744 (CSharpParser.yacc_verbose_flag): New public field.
12746 * genericparser.cs: Removed.
12748 2004-09-14 Raja R Harinath <rharinath@novell.com>
12750 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
12752 2004-09-13 Marek Safar <marek.safar@seznam.cz>
12754 * class.cs (MethodCore.CheckBase): Fix bug #65757.
12756 2004-09-10 Martin Baulig <martin@ximian.com>
12758 Backported my MemberName changes from GMCS into MCS.
12760 - we are now using a special `MemberName' class instead of using
12761 strings; in GMCS, the `MemberName' also contains the type
12764 - changed the grammar rules a bit:
12765 * the old `member_name' is now a `namespace_or_type_name':
12766 The rule is that we use `namespace_or_type_name' everywhere
12767 where we expect either a "member name" (GetEnumerator) or a
12768 "member name" with an explicit interface name
12769 (IEnumerable.GetEnumerator).
12770 In GMCS, the explicit interface name may include type arguments
12771 (IEnumerable<T>.GetEnumerator).
12772 * we use `member_name' instead of just `IDENTIFIER' for
12774 The rule is that we use `member_name' wherever a member may
12775 have type parameters in GMCS.
12777 * decl.cs (MemberName): New public class.
12778 (MemberCore.MemberName): New public readonly field.
12779 (MemberCore.ctor): Take a `MemberName' argument, not a string.
12780 (DeclSpace): Likewise.
12782 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
12783 * enum.cs (Enum.ctor): Likewise.
12785 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
12787 (AliasEntry.ctor): Take a MemberName, not an Expression.
12788 (AliasEntry.UsingAlias): Likewise.
12790 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
12791 (IMethodData.MemberName): Changed type from string to MemberName.
12792 (MemberBase.ExplicitInterfaceName): Likewise.
12793 (AbstractPropertyEventMethod.SetupName): Make this private.
12794 (AbstractPropertyEventMethod.ctor): Added `string prefix'
12795 argument; compute the member name here.
12796 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
12797 on the `member.MemberName' and the `prefix'.
12799 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
12801 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
12802 thus, we get a `MemberName' instead of a `string'. These
12803 declarations may have type parameters in GMCS.
12804 (interface_method_declaration, delegate_declaration): Likewise.
12805 (class_declaration, interface_declaration): Likewise.
12806 (method_header): Use `namespace_or_type_name' instead of
12807 `member_name'. We may be an explicit interface implementation.
12808 (property_declaration, event_declaration): Likewise.
12809 (member_name): This is now just an `IDENTIFIER', not a
12810 `namespace_or_type_name'.
12811 (type_name, interface_type): Removed.
12812 (namespace_or_type_name): Return a MemberName, not an Expression.
12813 (primary_expression): Use `member_name' instead of `IDENTIFIER';
12814 call GetTypeExpression() on the MemberName to get an expression.
12815 (IndexerDeclaration.interface_type): Changed type from string to
12817 (MakeName): Operate on MemberName's instead of string's.
12819 2004-09-13 Raja R Harinath <rharinath@novell.com>
12822 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
12823 (NamespaceEntry.Lookup): Add new argument to flag if we want the
12824 lookup to avoid symbols introduced by 'using'.
12825 * rootcontext.cs (NamespaceLookup): Update.
12827 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12829 * class.cs (TypeContainer.DoDefineMembers): Do not call
12830 DefineDefaultConstructor for static classes.
12832 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12834 * attribute.cs (Attribute.Resolve): Add error 653 report.
12836 * class.cs (Class.ApplyAttributeBuilder): Add error 641
12838 (Method.ApplyAttributeBuilder): Add error 685 report.
12839 (Operator.Define): Add error 564 report.
12841 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
12843 * expression.cs (Invocation.DoResolve): Add error
12844 245 and 250 report.
12846 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
12849 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12851 * class.cs (ConstructorInitializer.Resolve):
12852 Wrong error number (515->516).
12854 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12856 * class.cs (Indexer.Define): Add error 631 report.
12858 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12860 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
12862 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12864 * expression.cs (Probe.DoResolve): Add error CS0241 report.
12866 2004-09-10 Marek Safar <marek.safar@seznam.cz>
12868 * cs-parser.jay: Added error CS0241 report.
12870 2004-09-10 Raja R Harinath <rharinath@novell.com>
12872 * cs-parser.jay (fixed_statement): Introduce a scope for the
12873 declaration in the 'fixed' statement.
12875 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12877 * cs-parser.jay: Added CS0230 error report.
12879 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12881 * cs-parser.jay: Added errors CS0231 and CS0257 report.
12883 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12885 * expression.cs (Argument.Resolve): Added error CS0192 and
12888 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12890 C# 2.0 #pragma warning feature
12892 * cs-tokenizer.cs (PreProcessPragma): New method;
12893 Handles #pragma directive.
12895 * report.cs (WarningRegions): New class; Support
12896 class for #pragma warning directive. It tests whether
12897 warning is enabled for a given line.
12899 2004-09-08 Miguel de Icaza <miguel@ximian.com>
12901 * const.cs: Add more descriptive error report, tahnks to
12904 2004-09-08 Marek Safar <marek.safar@seznam.cz>
12906 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
12908 2004-09-07 Miguel de Icaza <miguel@ximian.com>
12910 * expression.cs: Apply patch from Ben: Remove dead code from
12911 ArrayCreation, and remove the TurnintoConstant call in const.cs,
12912 as that code just threw an exception anwyays.
12914 * const.cs: Remove the call to the turnintoconstant, for details
12917 * literal.cs: The type of the null-literal is the null type; So
12918 we use a placeholder type (literal.cs:System.Null, defined here)
12921 * expression.cs (Conditional.DoResolve): Remove some old code that
12922 is no longer needed, conversions have been fixed.
12924 (ArrayCreationExpression.DoResolve): Return false if we fail to
12925 resolve the inner expression.
12927 2004-09-07 Raja R Harinath <rharinath@novell.com>
12930 * cs-parser.jay (delegate_declaration): Record a delegate
12931 declaration as a type declaration.
12932 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
12934 2004-09-06 Miguel de Icaza <miguel@ximian.com>
12936 * parameter.cs: Do not crash if the type can not be resolved.
12938 * expression.cs: Report errors with unsafe pointers, fixes #64896
12940 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
12942 * expression.cs: Pointer arith always needs to do a conv.i
12943 if the operand is a long. fix 65320
12945 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12947 Fixed cs0619-37.cs, cs0619-38.cs
12949 * enum.cs (GetObsoleteAttribute): Removed.
12951 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
12952 on Enum member is double staged. The first is tested member
12955 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12957 Fixed #56986, #63631, #65231
12959 * class.cs: (TypeContainer.AddToMemberContainer): New method,
12960 adds member to name container.
12961 (TypeContainer.AddToTypeContainer): New method, adds type to
12963 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
12964 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
12965 AddOperator): Simplified by reusing AddToMemberContainer.
12966 (TypeContainer.UserDefinedStaticConstructor): Changed to property
12968 (Method.CheckForDuplications): Fixed implementation to test all
12970 (MemberBase): Detection whether member is explicit interface
12971 implementation is now in constructor.
12972 (MemberBase.UpdateMemberName): Handles IndexerName.
12973 (Accessor): Changed to keep also location information.
12974 (AbstractPropertyEventMethod): Is derived from MemberCore.
12975 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
12976 will be emited or not.
12977 (PropertyBase.AreAccessorsDuplicateImplementation):
12978 Tests whether accessors are not in collision with some method.
12979 (Operator): Is derived from MethodCore to simplify common
12982 * decl.cs (Flags.TestMethodDuplication): Test for duplication
12984 (DeclSpace.AddToContainer): Adds the member to defined_names
12985 table. It tests for duplications and enclosing name conflicts.
12987 * enum.cs (EnumMember): Clean up to reuse the base structures
12989 2004-09-03 Martin Baulig <martin@ximian.com>
12991 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
12992 into TypeContainer, to make partial classes work again.
12994 2004-09-03 Martin Baulig <martin@ximian.com>
12996 * rootcontext.cs (RootContext.V2): Removed.
12998 2004-03-23 Martin Baulig <martin@ximian.com>
13000 * expression.cs (Invocation.OverloadResolve): Added `bool
13001 may_fail' argument and use it instead of the Location.IsNull() hack.
13003 2004-09-03 Martin Baulig <martin@ximian.com>
13005 Merged latest changes into gmcs. Please keep this comment in
13006 here, it makes it easier for me to see what changed in MCS since
13007 the last time I merged.
13009 2004-09-03 Raja R Harinath <rharinath@novell.com>
13012 * expression.cs (BetterConversion): Don't allow either conversion
13013 to be null. Remove redundant implicit conversion test when 'q ==
13014 null' -- when this function is invoked, we already know that the
13015 implicit conversion exists.
13016 (BetterFunction): Assume that 'best' is non-null. Remove
13017 redundant reimplementation of IsApplicable when 'best' is null.
13018 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
13019 number of arguments.
13020 (IsAncestralType): Extract from OverloadResolve.
13021 (OverloadResolve): Make robust to the MethodGroupExpr being
13022 unsorted. Implement all the logic of Section 14.5.5.1, and
13023 support overloading of methods from multiple applicable types.
13024 Clean up logic somewhat. Don't pass null methods to BetterFunction.
13026 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
13027 (RealError, Warning): Append type of report to related symbol.
13029 2004-09-03 Marek Safar <marek.safar@seznam.cz>
13031 * enum.cs: Fixed CLS-Compliance checks for enum members.
13032 Error tests cs3008-8.cs, cs3014-8.cs
13034 2004-09-02 Marek Safar <marek.safar@seznam.cz>
13036 Fixed bug #62342, #63102
13037 * class.cs: ImplementIndexer uses member.IsExplicitImpl
13038 like ImplementMethod.
13040 2004-09-02 Marek Safar <marek.safar@seznam.cz>
13042 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13045 2004-09-02 Martin Baulig <martin@ximian.com>
13047 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
13048 TypeManager.GetArgumentTypes() rather than calling GetParameters()
13051 2004-09-01 Marek Safar <marek.safar@seznam.cz>
13053 C# 2.0 Static classes implemented
13055 * class.cs (TypeContainer): instance_constructors,
13056 initialized_fields, initialized_static_fields,
13057 default_constructor, base_inteface_types are protected to be
13058 accessible from StaticClass.
13059 (TypeContainer.DefineDefaultConstructor): New virtual method
13060 for custom default constructor generating
13061 (StaticClass): New class to handle "Static classes" feature.
13063 * cs-parser.jay: Handle static keyword on class like instance
13066 * driver.cs: Added "/langversion" command line switch with two
13067 options (iso-1, default).
13069 2004-08-31 Marek Safar <marek.safar@seznam.cz>
13071 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
13073 2004-08-31 Miguel de Icaza <miguel@ximian.com>
13075 * delegate.cs: Style.
13077 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
13079 * delegate.cs: Add seperate instance expr field for miguel.
13081 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13083 * PointerArithmetic (Resolve): make sure we are not doing
13084 pointer arith on void*. Also, make sure we are resolved
13085 by not setting eclass until resolve.
13087 All callers: Make sure that PointerArithmetic gets resolved.
13089 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13091 * ArrayCreation (LookupType): If the type does not resolve
13092 to an array, give an error.
13094 2004-08-27 Marek Safar <marek.safar@seznam.cz>
13096 * statement.cs (Try.Resolve): Fixed bug #64222
13098 2004-08-27 Martin Baulig <martin@ximian.com>
13101 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
13104 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13106 * ecore.cs (Constantify): Get underlying type via
13107 System.Enum.GetUnderlyingType to avoid StackOverflow on the
13108 Windows in special cases.
13110 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13112 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
13113 for obtaining also private methods.
13114 (GetRemoveMethod): Used GetRemoveMethod (true)
13115 for obtaining also private methods.
13117 2004-08-24 Martin Baulig <martin@ximian.com>
13119 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
13120 MethodAttributes.HideBySig for operators.
13122 2004-08-23 Martin Baulig <martin@ximian.com>
13124 Back to the old error reporting system :-)
13126 * report.cs (Message): Removed.
13127 (Report.MessageData, ErrorData, WarningData): Removed.
13128 (Report.Error, Warning): Back to the old system.
13130 2004-08-23 Martin Baulig <martin@ximian.com>
13132 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
13134 * class.cs (TypeContainer.ParentContainer): New public virtual
13135 method; replaces the explicit interface implementation.
13136 (ClassPart.ParentContainer): Override.
13138 2004-08-23 Martin Baulig <martin@ximian.com>
13140 * statement.cs (Switch): Added support for constant switches; see
13141 #59428 or test-285.cs.
13143 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13146 * statement.cs (GetEnumeratorFilter): Removed useless
13147 logic because C# specs is strict. GetEnumerator must be
13150 2004-08-22 Martin Baulig <martin@ximian.com>
13152 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13153 a switch and may break, reset the barrier. Fixes #59867.
13155 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13157 CLS-Compliance speed up (~5% for corlib)
13159 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
13160 New method. Tests container for CLS-Compliant names
13162 * class.cs (TypeContainer.VerifyClsName): New method.
13163 Checks whether container name is CLS Compliant.
13164 (Constructor): Implements IMethodData.
13166 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
13167 low-case table for CLS Compliance test.
13168 (MemberCache.VerifyClsParameterConflict): New method.
13169 Checks method parameters for CS3006 error.
13171 * enum.cs (EnumMember): Is derived from MemberCore.
13172 (Enum.VerifyClsName): Optimized for better performance.
13174 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13176 * report.cs: Renamed Error_T to Error and changed all
13179 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13181 * class.cs (TypeContainer.IndexerArrayList): New inner class
13182 container for indexers.
13183 (TypeContainer.DefaultIndexerName): New constant for default
13184 indexer name. Replaced all "Item" with this constant.
13185 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
13187 * typemanager.cs (TypeManager.default_member_ctor): Cache here
13188 DefaultMemberAttribute constructor.
13190 2004-08-05 Martin Baulig <martin@ximian.com>
13192 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13195 2004-08-05 Marek Safar <marek.safar@seznam.cz>
13197 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
13198 multi platforms problem.
13200 * compiler.csproj: Included shared files.
13202 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13204 Fix bug 60333, 55971 in the more general way
13205 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13206 Added arg_type argument for constant conversion.
13207 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
13209 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13212 * class.cs (TypeContainer ): New inner classes MethodArrayList,
13213 OperatorArrayList, MethodCoreArrayList for typecontainer
13214 containers. Changed class member types to these new types.
13215 (MethodArrayList.DefineMembers): Added test for CS0659.
13217 2004-08-04 Miguel de Icaza <miguel@ximian.com>
13219 * cfold.cs: Synchronize the folding with the code in expression.cs
13220 Binary.DoNumericPromotions for uint operands.
13222 * attribute.cs: Revert patch from Raja, it introduced a regression
13223 while building Blam-1.2.1 (hard to isolate a test case).
13225 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13229 (TypeContainer.Define): Renamed to DefineContainerMembers because of
13231 (MethodCore.parent_method): New member. The method we're overriding
13232 if this is an override method.
13233 (MethodCore.CheckBase): Moved from Method class and made common.
13234 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
13236 (MethodCore.CheckForDuplications): New abstract method. For custom
13237 member duplication search in a container
13238 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
13239 method and its return type.
13240 (Event.conflict_symbol): New member. Symbol with same name in the
13244 (MemberCache.FindMemberWithSameName): New method. The method
13245 is looking for conflict with inherited symbols.
13247 2004-08-04 Martin Baulig <martin@ximian.com>
13249 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
13251 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
13253 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13255 * report.cs (Message): New enum for better error, warning reference in
13257 (MessageData): New inner abstract class. It generally handles printing of
13258 error and warning messages.
13259 Removed unused Error, Warning, Message methods.
13261 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13263 Fix for cs0592-8.cs test
13265 (Attributable.ValidAttributeTargets): Made public.
13266 (Attribute.ExplicitTarget): New member for explicit target value.
13267 (Attribute.CheckTargets): Now we translate explicit attribute
13268 target to Target here.
13270 2004-08-03 Ben Maurer <bmaurer@ximian.com>
13272 * ecore.cs (MethodGroupExpr): new IsBase property.
13274 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
13276 * delegate.cs (DelegateCreation): store a MethodGroupExpr
13277 rather than an instance expr.
13279 (DelegateCreation.Emit): Use the method group rather than
13280 the instance expression. Also, if you have base.Foo as the
13281 method for a delegate, make sure to emit ldftn, not ldftnvirt.
13283 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
13285 (NewDelegate.DoResolve): Only check for the existance of Invoke
13286 if the method is going to be needed. Use MethodGroupExpr.
13288 (NewDelegate.Emit): Remove, DelegateCreation implements this.
13290 * expression.cs: For pointer arith., make sure to use
13291 the size of the type, not the size of the pointer to
13294 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13297 * class.cs (Class): Added error CS0502 test.
13299 2004-08-03 John Luke <jluke@cfl.rr.com>
13300 Raja R Harinath <rharinath@novell.com>
13303 * attribute.cs (Attribute.complained_before): New flag.
13304 (Attribute.ResolveType, Attribute.Resolve),
13305 (Attribute.DefinePInvokeMethod): Set it.
13306 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
13308 2004-08-03 Martin Baulig <martin@ximian.com>
13310 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
13311 use a user-defined operator; we still need to do numeric
13312 promotions in case one argument is a builtin type and the other
13313 one has an implicit conversion to that type. Fixes #62322.
13315 2004-08-02 Martin Baulig <martin@ximian.com>
13317 * statement.cs (LocalInfo.Flags): Added `IsThis'.
13318 (LocalInfo.IsThis): New public property.
13319 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
13321 2004-08-01 Martin Baulig <martin@ximian.com>
13323 * class.cs (TypeContainer.GetClassBases): Don't set the default
13324 here since we may get called from GetPartialBases().
13325 (TypeContainer.DefineType): If GetClassBases() didn't return a
13326 parent, use the default one.
13328 2004-07-30 Duncan Mak <duncan@ximian.com>
13330 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
13332 2004-07-30 Martin Baulig <martin@ximian.com>
13334 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
13336 * class.cs (SourceMethod): New public class, derive from the
13337 symbol writer's ISourceMethod.
13338 (Method): Use the new symbol writer API.
13340 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
13341 as argument and use the new symbol writer.
13344 (SourceFile): Implement the symbol writer's ISourceFile.
13345 (Location.SymbolDocument): Removed.
13346 (Location.SourceFile): New public property.
13348 * symbolwriter.cs: Use the new symbol writer API.
13350 2004-07-30 Raja R Harinath <rharinath@novell.com>
13352 * Makefile (install-local): Remove. Functionality moved to
13355 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
13357 * Makefile: Install mcs.exe.config file together with mcs.exe.
13358 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
13359 correct runtime version.
13361 2004-07-25 Martin Baulig <martin@ximian.com>
13364 (TypeContainer.RegisterOrder): Removed, this was unused.
13365 (TypeContainer, interface_order): Removed.
13366 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
13367 TypeContainer as argument since we can also be called with a
13368 `PartialContainer' for a partial class/struct/interface.
13369 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
13370 of checking whether we're an `Interface' - we could be a
13371 `PartialContainer'.
13372 (PartialContainer.Register): Override; call
13373 AddClass()/AddStruct()/AddInterface() on our parent.
13375 * cs-parser.jay (interface_member_declaration): Add things to the
13376 `current_container', not the `current_class'.
13378 * rootcontext.cs (RegisterOrder): The overloaded version which
13379 takes an `Interface' was unused, removed.
13381 * typemanager.cs (TypeManager.LookupInterface): Return a
13382 `TypeContainer', not an `Interface'.
13383 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
13384 contain a `PartialContainer' for an interface, so check it's
13385 `Kind' to figure out what it is.
13387 2004-07-25 Martin Baulig <martin@ximian.com>
13389 * class.cs (Class.DefaultTypeAttributes): New public constant.
13390 (Struct.DefaultTypeAttributes): Likewise.
13391 (Interface.DefaultTypeAttributes): Likewise.
13392 (PartialContainer.TypeAttr): Override this and add the
13393 DefaultTypeAttributes.
13395 2004-07-25 Martin Baulig <martin@ximian.com>
13397 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
13398 we can just use the `Parent' field instead.
13400 2004-07-25 Martin Baulig <martin@ximian.com>
13402 * class.cs (TypeContainer.Emit): Renamed to EmitType().
13404 2004-07-25 Martin Baulig <martin@ximian.com>
13406 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
13407 our parts before defining any methods.
13408 (TypeContainer.VerifyImplements): Make this virtual.
13409 (ClassPart.VerifyImplements): Override and call VerifyImplements()
13410 on our PartialContainer.
13412 2004-07-25 Martin Baulig <martin@ximian.com>
13414 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
13416 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
13417 argument, we can just use the `Parent' field instead.
13420 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
13421 (MemberBase.DoDefine): Likewise.
13423 2004-07-24 Martin Baulig <martin@ximian.com>
13425 * decl.cs (MemberCore.Parent): New public field.
13426 (DeclSpace.Parent): Moved to MemberCore.
13428 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
13429 (MemberBase.ctor): Added TypeContainer argument, pass it to our
13431 (FieldBase, Field, Operator): Likewise.
13432 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
13433 (EventField, Event): Likewise.
13435 2004-07-23 Martin Baulig <martin@ximian.com>
13437 * class.cs (PartialContainer): New public class.
13438 (ClassPart): New public class.
13439 (TypeContainer): Added support for partial classes.
13440 (TypeContainer.GetClassBases): Splitted some of the functionality
13441 out into GetNormalBases() and GetPartialBases().
13443 * cs-tokenizer.cs (Token.PARTIAL): New token.
13444 (Tokenizer.consume_identifier): Added some hacks to recognize
13445 `partial', but only if it's immediately followed by `class',
13446 `struct' or `interface'.
13448 * cs-parser.jay: Added support for partial clases.
13450 2004-07-23 Martin Baulig <martin@ximian.com>
13452 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
13453 a `DeclSpace' and also made it readonly.
13454 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
13455 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
13456 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
13458 * cs-parser.jay: Pass the `current_class', not the
13459 `current_container' (at the moment, this is still the same thing)
13460 to a new Method, Property, Event, Indexer or Constructor.
13462 2004-07-23 Martin Baulig <martin@ximian.com>
13464 * cs-parser.jay (CSharpParser): Added a new `current_class' field
13465 and removed the `current_interface' one.
13466 (struct_declaration, class_declaration, interface_declaration):
13467 Set `current_class' to the newly created class/struct/interface;
13468 set their `Bases' and call Register() before parsing their body.
13470 2004-07-23 Martin Baulig <martin@ximian.com>
13472 * class.cs (Kind): New public enum.
13473 (TypeContainer): Made this class abstract.
13474 (TypeContainer.Kind): New public readonly field.
13475 (TypeContainer.CheckDef): New public method; moved here from
13477 (TypeContainer.Register): New public abstract method.
13478 (TypeContainer.GetPendingImplementations): New public abstract
13480 (TypeContainer.GetClassBases): Removed the `is_class' and
13481 `is_iface' parameters.
13482 (TypeContainer.DefineNestedTypes): Formerly known as
13484 (ClassOrStruct): Made this class abstract.
13486 * tree.cs (RootTypes): New public type.
13488 2004-07-20 Martin Baulig <martin@ximian.com>
13490 * tree.cs (Tree.RecordNamespace): Removed.
13491 (Tree.Namespaces): Removed.
13493 * rootcontext.cs (RootContext.IsNamespace): Removed.
13495 * cs-parser.jay (namespace_declaration): Just create a new
13496 NamespaceEntry here.
13498 2004-07-20 Martin Baulig <martin@ximian.com>
13500 * statement.cs (ExceptionStatement): New abstract class. This is
13501 now used as a base class for everyone who's using `finally'.
13502 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
13503 our local variables before using them.
13505 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
13506 virtual method. This is used by Yield.Resolve() to "steal" an
13507 outer block's `finally' clauses.
13508 (FlowBranchingException): The .ctor now takes an ExceptionStatement
13511 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
13512 version which takes an ExceptionStatement. This version must be
13513 used to create exception branchings.
13516 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
13517 (Iterator.EmitMoveNext): Added exception support; protect the
13518 block with a `fault' clause, properly handle 'finally' clauses.
13519 (Iterator.EmitDispose): Run all the `finally' clauses here.
13521 2004-07-20 Martin Baulig <martin@ximian.com>
13523 * iterator.cs: This is the first of a set of changes in the
13524 iterator code. Match the spec more closely: if we're an
13525 IEnumerable, then GetEnumerator() must be called. The first time
13526 GetEnumerator() is called, it returns the current instance; all
13527 subsequent invocations (if any) must create a copy.
13529 2004-07-19 Miguel de Icaza <miguel@ximian.com>
13531 * expression.cs: Resolve the constant expression before returning
13534 2004-07-19 Martin Baulig <martin@ximian.com>
13536 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
13537 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
13538 the return type of the new EmitContext.
13540 2004-07-18 Martin Baulig <martin@ximian.com>
13542 * class.cs (Property.Define): Fix iterators.
13544 * iterators.cs (Iterator.Define): Moved the
13545 `container.AddInterator (this)' call here from the .ctor; only do
13546 it if we resolved successfully.
13548 2004-07-17 Miguel de Icaza <miguel@ximian.com>
13550 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
13551 `true' for preprocessing directives that we parse. The return
13552 value indicates whether we should return to regular tokenizing or
13553 not, not whether it was parsed successfully.
13555 In the past if we were in: #if false ... #line #endif, we would
13556 resume parsing after `#line'. See bug 61604.
13558 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
13559 building: IsEnumType should return true only for enums, not for
13560 enums or System.Enum itself. This fixes #61593.
13562 Likely what happened is that corlib was wrong: mcs depended on
13563 this bug in some places. The bug got fixed, we had to add the
13564 hack, which caused bug 61593.
13566 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
13567 that was a workaround for the older conditions.
13569 2004-07-16 Ben Maurer <bmaurer@ximian.com>
13571 * assign.cs: IAssignMethod has a new interface, as documented
13572 inline. All assignment code now uses this new api.
13574 * ecore.cs, expression.cs: All classes which implement
13575 IAssignMethod now use the new interface.
13577 * expression.cs (Invocation): add a hack to EmitCall so that
13578 IndexerAccess can be the target of a compound assignment without
13579 evaluating its arguments twice.
13581 * statement.cs: Handle changes in Invocation api.
13583 2004-07-16 Martin Baulig <martin@ximian.com>
13585 * iterators.cs: Rewrote this. We're now using one single Proxy
13586 class for both the IEnumerable and the IEnumerator interface and
13587 `Iterator' derives from Class so we can use the high-level API.
13589 * class.cs (TypeContainer.AddIterator): New method.
13590 (TypeContainer.DoDefineType): New protected virtual method, which
13591 is called from DefineType().
13592 (TypeContainer.DoDefineMembers): Call DefineType() and
13593 DefineMembers() on all our iterators.
13594 (TypeContainer.Emit): Call Emit() on all our iterators.
13595 (TypeContainer.CloseType): Call CloseType() on all our iterators.
13597 * codegen.cs (EmitContext.CurrentIterator): New public field.
13599 2004-07-15 Martin Baulig <martin@ximian.com>
13602 (TypeManager.not_supported_exception_type): New type.
13604 2004-07-14 Martin Baulig <martin@ximian.com>
13606 * iterators.cs: Use real error numbers.
13608 2004-07-14 Martin Baulig <martin@ximian.com>
13610 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
13611 requires this to be a System.Collection.IEnumerable and not a
13612 class implementing that interface.
13613 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
13615 2004-07-13 Marek Safar <marek.safar@seznam.cz>
13617 * class.cs: Fixed previous fix, it broke some error tests.
13619 2004-07-12 Martin Baulig <martin@ximian.com>
13621 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
13624 2004-07-09 Miguel de Icaza <miguel@ximian.com>
13626 * assign.cs (LocalTemporary): Add new argument: is_address,If
13627 `is_address' is true, then the value that we store is the address
13628 to the real value, and not the value itself.
13630 * ecore.cs (PropertyExpr): use the new local temporary
13631 stuff to allow us to handle X.Y += z (where X is a struct)
13633 2004-07-08 Martin Baulig <martin@ximian.com>
13635 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
13636 not always return, just like we're doing in Using.Resolve().
13638 2004-07-07 Miguel de Icaza <miguel@ximian.com>
13640 * cs-parser.jay (fixed_statement): flag this as Pinned.
13642 2004-07-06 Miguel de Icaza <miguel@ximian.com>
13644 * typemanager.cs (TypeManager): Removed MakePinned method, this
13645 mechanism is replaced with the .NET 2.x compatible mechanism of
13646 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
13648 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
13649 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
13650 `IsFixed' property which has a different meaning.
13652 2004-07-02 Raja R Harinath <rharinath@novell.com>
13654 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
13655 visible from inside a nested class, not just the names of the
13656 immediately enclosing class.
13657 Fix for bug #60730.
13659 2004-06-24 Raja R Harinath <rharinath@novell.com>
13661 * expression.cs (BetterConversion): Remove buggy special-case
13662 handling of "implicit constant expression conversions". At this
13663 point, we already know that the conversion is possible -- we're
13664 only checking to see which is better.
13666 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13668 * cs-parser.jay: Added error CS0210 test.
13670 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13672 * cs-parser.jay: Added error CS0134 test.
13674 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13677 * cs-parser.jay: Added error CS0145 test.
13679 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13681 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
13683 2004-06-23 Ben Maurer <bmaurer@ximian.com>
13685 * expression.cs (StackAlloc.Resolve): The argument may not
13686 be a constant; deal with this case.
13688 2004-06-23 Marek Safar <marek.safar@seznam.cz>
13690 * attribute.cs (IndexerName_GetIndexerName): Renamed to
13691 GetIndexerAttributeValue.
13692 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
13694 * class.cs (Indexer.Define): Added error tests for CS0415,
13697 2004-06-23 Miguel de Icaza <miguel@ximian.com>
13699 * attribute.cs (Attribute.Resolve): Keep field code in sync with
13702 2004-06-23 Martin Baulig <martin@ximian.com>
13704 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
13705 neither return nor throw, reset the barrier as well. Fixes #60457.
13707 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
13709 * class.cs : EventAttributes is now set to None by default.
13710 This fixes bug #60459.
13712 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13715 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13716 Don't throw exception but return null (it's sufficient now).
13718 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13720 * typemanager.cs (GetArgumentTypes): Faster implementation.
13722 2004-06-18 Martin Baulig <martin@ximian.com>
13724 * attribute.cs (Attribute.Resolve): Check whether we're an
13725 EmptyCast which a Constant child. Fixes #60333.
13727 2004-06-17 Ben Maurer <bmaurer@ximian.com>
13729 * statement.cs (EmitCollectionForeach): Account for the fact that
13730 not all valuetypes are in areas which we can take the address of.
13731 For these variables, we store to a temporary variable. Also, make
13732 sure that we dont emit a `callvirt' on a valuetype method.
13734 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13736 * expression.cs (StackAlloc.DoReSolve): Added test for
13737 negative parameter (CS0247).
13739 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13742 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
13744 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13747 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
13750 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13752 Fix bug #58254 & cs1555.cs, cs1556.cs
13753 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
13755 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13757 * cs-parser.jay: Added error CS1669 test for indexers.
13759 2004-06-11 Martin Baulig <martin@ximian.com>
13761 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
13762 call this twice: for params and varargs methods.
13764 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13767 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
13769 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13771 * attribute.cs (Attribute.GetValidTargets): Made public.
13774 (AbstractPropertyEventMethod): New class for better code sharing.
13775 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
13777 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
13779 2004-06-11 Raja R Harinath <rharinath@novell.com>
13782 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
13783 that the call to Resolve is part of a MemberAccess.
13784 (Expression.Resolve): Use it for SimpleName resolution.
13785 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
13786 Add 'intermediate' boolean argument.
13787 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
13788 error message when the SimpleName can be resolved ambiguously
13789 between an expression and a type.
13790 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
13792 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
13793 call on the left-side.
13795 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13798 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
13800 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13802 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
13804 2004-06-11 Martin Baulig <martin@ximian.com>
13806 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
13807 varargs methods if applicable.
13809 2004-06-11 Martin Baulig <martin@ximian.com>
13811 * expression.cs (Invocation.EmitCall): Don't use
13812 `method.CallingConvention == CallingConventions.VarArgs' since the
13813 method could also have `CallingConventions.HasThis'.
13815 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13817 * class.cs (Event.GetSignatureForError): Implemented.
13818 Fixed crash in error test cs3010.cs
13820 2004-06-10 Miguel de Icaza <miguel@ximian.com>
13822 * cs-tokenizer.cs: Change the way we track __arglist to be
13823 consistent with the other keywords.
13825 2004-06-09 Miguel de Icaza <miguel@ximian.com>
13827 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
13830 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
13832 * codegen.cs: Check that all referenced assemblies have a strongname
13833 before strongnaming the compiled assembly. If not report error CS1577.
13834 Fix bug #56563. Patch by Jackson Harper.
13835 * typemanager.cs: Added a method to return all referenced assemblies.
13836 Fix bug #56563. Patch by Jackson Harper.
13838 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13841 (Method.ApplyAttributeBuilder): Moved and added conditional
13842 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
13845 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
13847 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13850 * class.cs: (EventField.attribute_targets): Changed default target.
13852 2004-06-08 Martin Baulig <martin@ximian.com>
13854 * expression.cs (Invocation.EmitCall): Enable varargs methods.
13856 2004-06-08 Martin Baulig <martin@ximian.com>
13858 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
13860 2004-06-07 Martin Baulig <martin@ximian.com>
13862 Added support for varargs methods.
13864 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
13867 * cs-parser.jay: Added support for `__arglist'.
13869 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
13871 * expression.cs (Argument.AType): Added `ArgList'.
13872 (Invocation): Added support for varargs methods.
13873 (ArglistAccess): New public class.
13874 (Arglist): New public class.
13876 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
13878 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
13879 a method's top-level block if the method has varargs.
13881 * support.cs (ReflectionParameters, InternalParameters): Added
13882 support for varargs methods.
13884 2004-06-07 Miguel de Icaza <miguel@ximian.com>
13886 * class.cs: Provide location in indexer error report.
13888 * driver.cs: Use standard names.
13890 * namespace.cs: Catch the use of using after a namespace has been
13891 declared also on using aliases.
13893 2004-06-03 Raja R Harinath <rharinath@novell.com>
13896 * typemanager.cs (closure_private_ok, closure_invocation_type)
13897 (closure_qualifier_type, closure_invocation_assembly)
13898 (FilterWithClosure): Move to ...
13899 (Closure): New internal nested class.
13900 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
13901 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
13902 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
13903 (MemberLookup, MemberLookupFailed): Use it.
13904 * expression.cs (New.DoResolve): Treat the lookup for the
13905 constructor as being qualified by the 'new'ed type.
13906 (Indexers.GetIndexersForTypeOrInterface): Update.
13908 2004-06-03 Marek Safar <marek.safar@seznam.cz>
13911 (GetConditionalAttributeValue): New method. Returns
13912 condition of ConditionalAttribute.
13913 (SearchMulti): New method. Returns all attributes of type 't'.
13914 Use it when attribute is AllowMultiple = true.
13915 (IsConditionalMethodExcluded): New method.
13918 (Method.IsExcluded): Implemented. Returns true if method has conditional
13919 attribute and the conditions is not defined (method is excluded).
13920 (IMethodData): Extended interface for ConditionalAttribute support.
13921 (PropertyMethod.IsExcluded): Implemented.
13924 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
13927 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
13930 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
13932 * expression.cs (ArrayCreationExpression): Make this just an
13933 `expression'. It can't be a statement, so the code here was
13936 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13939 * typemanager.cs (GetFullNameSignature): New method for
13942 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13945 * class.cs (MemberBase.GetSignatureForError): New virtual method.
13946 Use this method when MethodBuilder is null.
13947 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
13948 Added test for error CS0626 (MONO reports error for this situation).
13949 (IMethodData.GetSignatureForError): Extended interface.
13951 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13954 (AttributeTester.GetObsoleteAttribute): Returns instance of
13955 ObsoleteAttribute when type is obsolete.
13958 (TypeContainer.VerifyObsoleteAttribute): Override.
13959 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
13960 (MethodCode.VerifyObsoleteAttribute): Override.
13961 (MemberBase.VerifyObsoleteAttribute): Override.
13964 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
13965 and report proper error.
13968 Delegate.VerifyObsoleteAttribute): Override.
13971 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
13972 and report proper error.
13973 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
13976 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
13980 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
13981 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
13982 Added test for ObsoleteAttribute.
13985 (Catch): Derived from Statement.
13987 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13989 Fixed bug #59071 & cs0160.cs
13991 * statement.cs (Try.Resolve): Check here whether order of catch
13992 clauses matches their dependencies.
13994 2004-05-31 Miguel de Icaza <miguel@ximian.com>
13996 * Reverted patch to namespace.cs (Use lookuptypedirect). This
13997 caused a regression: #59343. Referencing nested classes from an
13998 assembly stopped working.
14000 2004-05-31 Martin Baulig <martin@ximian.com>
14002 MCS is now frozen for beta 2.
14004 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14006 * convert.cs: add a trivial cache for overload operator resolution.
14008 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14010 * decl.cs: If possible, use lookuptypedirect here. We can only do
14011 this if there is no `.' after the namespace. Avoids using
14012 LookupType, which does lots of slow processing.
14013 (FindNestedType) New method, does what it says :-).
14014 * namespace.cs: use LookupTypeDirect.
14015 * rootcontext.cs: use membercache, if possible.
14016 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
14018 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14021 According to the spec,
14023 In a member access of the form E.I, if E is a single identifier,
14024 and if the meaning of E as a simple-name (§7.5.2) is a constant,
14025 field, property, localvariable, or parameter with the same type as
14026 the meaning of E as a type-name (§3.8), then both possible
14027 meanings of E are permitted.
14029 We did not check that E as a simple-name had the same type as E as
14032 This trivial check gives us 5-7% on bootstrap time.
14034 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14036 * expression.cs (Invocation.OverloadResolve): Avoid the
14037 use of hashtables and boxing here by allocating on demand.
14039 2004-05-30 Martin Baulig <martin@ximian.com>
14041 * rootcontext.cs (RootContext.LookupType): Don't cache things if
14042 we're doing a silent lookup. Don't try to lookup nested types in
14043 TypeManager.object_type (thanks to Ben Maurer).
14045 2004-05-30 Martin Baulig <martin@ximian.com>
14047 Committing a patch from Ben Maurer.
14049 * rootcontext.cs (RootContext.LookupType): Cache negative results.
14051 2004-05-29 Martin Baulig <martin@ximian.com>
14053 * class.cs (IMethodData.ShouldIgnore): New method.
14055 * typemanager.cs (TypeManager.MethodFlags): Don't take a
14056 `Location' argument, we don't need it anywhere. Use
14057 `IMethodData.ShouldIgnore ()' instead of
14058 `MethodData.GetMethodFlags ()'.
14059 (TypeManager.AddMethod): Removed.
14060 (TypeManager.AddMethod2): Renamed to AddMethod.
14062 2004-05-29 Martin Baulig <martin@ximian.com>
14064 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
14066 * convert.cs (Convert.ImplicitReferenceConversion): If we're
14067 converting from a class type S to an interface type and we already
14068 have an object on the stack, don't box it again. Fixes #52578.
14070 2004-05-29 Martin Baulig <martin@ximian.com>
14072 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
14073 Added support for `params' parameters. Fixes #59267.
14075 2004-05-29 Martin Baulig <martin@ximian.com>
14077 * literal.cs (NullPointer): Provide a private .ctor which sets
14078 `type' to TypeManager.object_type. Fixes #59048.
14080 2004-05-29 Martin Baulig <martin@ximian.com>
14082 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
14083 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
14085 * ecore.cs (EventExpr.instance_expr): Make the field private.
14087 2004-05-26 Marek Safar <marek.safar@seznam.cz>
14089 Fixed bug #50080 & cs0214-2.cs
14090 * expression.cs (Cast.DoResolve): Check unsafe context here.
14092 * statement.cs (Resolve.DoResolve): Likewise.
14094 2004-05-26 Martin Baulig <martin@ximian.com>
14096 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
14098 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
14099 (RootContext.LookupType): Pass down the `silent' flag.
14101 2004-05-25 Martin Baulig <martin@ximian.com>
14104 (MethodGroupExpr.IdenticalTypeName): New public property.
14105 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
14106 expression actually refers to a type.
14108 2004-05-25 Martin Baulig <martin@ximian.com>
14110 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
14111 for #56176 and made it actually work.
14113 2004-05-25 Martin Baulig <martin@ximian.com>
14115 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
14116 (FieldExpr, PropertyExpr): Override and implement
14117 CacheTemporaries. Fixes #52279.
14119 2004-05-25 Miguel de Icaza <miguel@ximian.com>
14121 * location.cs: In the new compiler listing a file twice is a
14122 warning, not an error.
14124 2004-05-24 Martin Baulig <martin@ximian.com>
14126 * enum.cs (Enum.DefineType): For the `BaseType' to be a
14127 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
14129 2004-05-24 Martin Baulig <martin@ximian.com>
14131 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
14132 walking the `using' list. Fixes #53921.
14134 2004-05-24 Martin Baulig <martin@ximian.com>
14136 * const.cs (Const.LookupConstantValue): Added support for
14137 EmptyCast's; fixes #55251.
14139 2004-05-24 Martin Baulig <martin@ximian.com>
14141 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
14142 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
14143 which does the CS0135 check. The reason is that we first need to
14144 check whether the variable actually exists.
14146 2004-05-24 Martin Baulig <martin@ximian.com>
14148 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
14149 than RootContext.LookupType() to find the explicit interface
14150 type. Fixes #58584.
14152 2004-05-24 Raja R Harinath <rharinath@novell.com>
14154 * Makefile: Simplify. Use executable.make.
14155 * mcs.exe.sources: New file. List of sources of mcs.exe.
14157 2004-05-24 Anders Carlsson <andersca@gnome.org>
14161 Use the invariant culture when doing String.Compare for CLS case
14164 2004-05-23 Martin Baulig <martin@ximian.com>
14166 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
14167 don't have any dots. Fixes #52622, added cs0246-8.cs.
14169 * namespace.cs (NamespaceEntry.Lookup): Likewise.
14171 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14173 * class.cs (MemberBase.Define): Reuse MemberType member for
14174 resolved type. Other methods can use it too.
14176 2004-05-23 Martin Baulig <martin@ximian.com>
14178 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
14179 the variable also exists in the current block (otherwise, we need
14180 to report a CS0103). Fixes #58670.
14182 2004-05-23 Martin Baulig <martin@ximian.com>
14184 * flowanalysis.cs (Reachability.Reachable): Compute this
14185 on-the-fly rather than storing it as a field.
14187 2004-05-23 Martin Baulig <martin@ximian.com>
14189 * flowanalysis.cs (Reachability.And): Manually compute the
14190 resulting `barrier' from the reachability.
14192 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14195 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
14196 instance of ObsoleteAttribute when symbol is obsolete.
14199 (IMethodData): Extended interface for ObsoleteAttribute support.
14201 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14203 * attribute.cs: Fix bug #55970
14205 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14209 (GetObsoleteAttribute): New method. Creates the instance of
14211 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
14212 ObsoleteAttribute when member is obsolete.
14213 (AttributeTester.Report_ObsoleteMessage): Common method for
14214 Obsolete error/warning reporting.
14217 (TypeContainer.base_classs_type): New member for storing parent type.
14220 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
14221 for this MemberCore.
14223 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14225 * attribute.cs, const.cs: Fix bug #58590
14227 2004-05-21 Martin Baulig <martin@ximian.com>
14229 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
14230 out parameters if the end of the method is unreachable. Fixes
14233 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14235 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
14236 Hari was right, why extra method.
14238 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14240 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
14242 2004-05-20 Martin Baulig <martin@ximian.com>
14244 Merged this back from gmcs to keep the differences to a minumum.
14246 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
14247 instead of a Declspace.
14248 (Attribute.ResolveType): Likewise.
14249 (Attributes.Search): Likewise.
14250 (Attributes.Contains): Likewise.
14251 (Attributes.GetClsCompliantAttribute): Likewise.
14253 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
14255 (MethodData.ApplyAttributes): Take an EmitContext instead of a
14258 2004-05-19 Marek Safar <marek.safar@seznam.cz>
14260 Fix bug #58688 (MCS does not report error when the same attribute
14263 * attribute.cs (Attribute.Emit): Distinction between null and default.
14265 2004-05-19 Raja R Harinath <rharinath@novell.com>
14267 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
14268 of a top-level attribute without an attribute target.
14269 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
14271 (Attribute.Conditional_GetConditionName),
14272 (Attribute.Obsolete_GetObsoleteMessage): Update.
14273 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
14274 part of ScanForIndexerName.
14275 (Attribute.CanIgnoreInvalidAttribute): New function.
14276 (Attribute.ScanForIndexerName): Move to ...
14277 (Attributes.ScanForIndexerName): ... here.
14278 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
14279 (Attributes.Search): New internal variant that can choose not to
14280 complain if types aren't resolved. The original signature now
14282 (Attributes.GetClsCompliantAttribute): Use internal variant, with
14283 complaints suppressed.
14284 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
14285 only if it not useful.
14286 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
14287 top-level for attributes that are shared between the assembly
14288 and a top-level class.
14289 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
14290 * class.cs: Update to reflect changes.
14291 (DefineIndexers): Fuse loops.
14292 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
14293 a couple more variants of attribute names.
14295 2004-05-18 Marek Safar <marek.safar@seznam.cz>
14297 Fix bug #52585 (Implemented explicit attribute declaration)
14300 (Attributable.ValidAttributeTargets): New abstract method. It gets
14301 list of valid attribute targets for explicit target declaration.
14302 (Attribute.Target): It holds target itself.
14303 (AttributeSection): Removed.
14304 (Attribute.CheckTargets): New method. It checks whether attribute
14305 target is valid for the current element.
14308 (EventProperty): New class. For events that are declared like
14309 property (with add and remove accessors).
14310 (EventField): New class. For events that are declared like field.
14313 * cs-parser.jay: Implemented explicit attribute target declaration.
14315 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
14316 Override ValidAttributeTargets.
14319 (ReturnParameter): Class for applying custom attributes on
14321 (ParameterAtribute): New class. Class for applying custom
14322 attributes on the parameter type.
14324 2004-05-17 Miguel de Icaza <miguel@ximian.com>
14326 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
14329 (Method): Allow UNSAFE here.
14331 * modifiers.cs: Support unsafe reporting.
14333 2004-05-17 Marek Safar <marek.safar@seznam.cz>
14335 * decl.cs: Fix bug #58478.
14337 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14339 * statement.cs: When checking for unreachable code on an EmptyStatement,
14340 set the location. Fixes bug #58488.
14342 2004-05-13 Miguel de Icaza <miguel@ximian.com>
14344 * driver.cs: Add -pkg handling.
14346 From Gonzalo: UseShelLExecute=false
14348 2004-05-12 Marek Safar <marek.safar@seznam.cz>
14351 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
14353 (Attribute.IsClsCompliaceRequired): Moved to base for better
14355 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
14356 when attribute is AttributeUsageAttribute.
14357 (Attribute.GetValidTargets): Simplified.
14358 (Attribute.GetAttributeUsage): New method returns AttributeUsage
14359 attribute for this type.
14360 (Attribute.ApplyAttributes): Method renamed to Emit and make
14362 (GlobalAttributeSection): New class for special handling of global
14363 attributes (assembly, module).
14364 (AttributeSection.Emit): New method.
14366 * class.cs: Implemented Attributable abstract methods.
14367 (MethodCore.LabelParameters): Moved to Parameter class.
14368 (Accessor): Is back simple class.
14369 (PropertyMethod): Implemented Attributable abstract class.
14370 (DelegateMethod): Implemented Attributable abstract class.
14371 (Event): New constructor for disctintion between normal Event
14372 and Event with accessors.
14374 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
14376 * codegen.cs, const.cs, decl.cs, delegate.cs:
14377 (CommonAssemblyModulClass): Implemented Attributable abstract class
14380 * enum.cs: Implement IAttributeSupport interface.
14381 (EnumMember): New class for emum members. Implemented Attributable
14385 (ParameterBase): Is abstract.
14386 (ReturnParameter): New class for easier [return:] attribute handling.
14388 * typemanager.cs: Removed builder_to_attr.
14390 2004-05-11 Raja R Harinath <rharinath@novell.com>
14393 * attribute.cs (Attribute.GetPositionalValue): New function.
14394 * class.cs (TypeContainer.VerifyMembers): New function.
14395 (TypeContainer.Emit): Use it.
14396 (ClassOrStruct): New base class for Class and Struct.
14397 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
14398 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
14400 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
14401 then each non-static field should have a FieldOffset attribute.
14402 Otherwise, none of the fields should have a FieldOffset attribute.
14403 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
14404 and FieldOffset attributes.
14405 * typemanager.cs (TypeManager.struct_layout_attribute_type)
14406 (TypeManager.field_offset_attribute_type): New core types.
14407 (TypeManager.InitCoreTypes): Initialize them.
14409 2004-05-11 Michal Moskal <malekith@pld-linux.org>
14411 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
14412 Return correct type.
14415 2004-05-09 Miguel de Icaza <miguel@ximian.com>
14417 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
14418 be implicitly converted to ulong.
14420 * expression.cs: The logic for allowing operator &, | and ^ worked
14421 was wrong, it worked before because we did not report an error in
14422 an else branch. Fixes 57895.
14424 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
14425 allow volatile fields to be reference types.
14427 2004-05-07 Miguel de Icaza <miguel@ximian.com>
14429 * driver.cs: Add support for /debug-
14431 2004-05-07 Raja R Harinath <rharinath@novell.com>
14433 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
14434 Add a 'complain' parameter to silence errors.
14435 (Attribute.Resolve): Update to changes. Put in sanity check to catch
14436 silently overlooked type-resolutions.
14437 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
14438 to reflect changes.
14439 (Attributes.Search): New function.
14440 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
14441 (Attributes.GetAttributeFullName): Remove hack.
14442 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
14443 Update to reflect changes.
14444 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14445 Use Attributes.Search instead of nested loops.
14447 2004-05-07 Marek Safar <marek.safar@seznam.cz>
14450 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
14451 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
14452 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
14454 * report.cs: (Report.Warning): Renamed to Warning_T because of
14455 parameter collision.
14457 2004-05-05 Raja R Harinath <rharinath@novell.com>
14459 * expression.cs (MemberAccess.ResolveMemberAccess):
14460 Exit with non-zero status after Report.Error.
14461 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
14463 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
14465 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14467 * support.cs: Don't hang when the file is empty.
14469 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14471 * support.cs: In SeekableStreamReader, compute the preamble size of the
14472 underlying stream. Position changes should take into account that initial
14475 2004-05-03 Todd Berman <tberman@sevenl.net>
14477 * driver.cs: remove unused GetSysVersion function.
14479 2004-05-03 Todd Berman <tberman@sevenl.net>
14481 * driver.cs: Remove the hack from saturday, as well as the hack
14482 from jackson (LoadAssemblyFromGac), also adds the CWD to the
14483 link_paths to get that bit proper.
14485 2004-05-01 Todd Berman <tberman@sevenl.net>
14487 * driver.cs: Try a LoadFrom before a Load, this checks the current
14488 path. This is currently a bug in mono that is be fixed, however, this
14489 provides a workaround for now. This will be removed when the bug
14492 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
14494 * CryptoConvert.cs: Updated to latest version. Fix issue with
14495 incomplete key pairs (#57941).
14497 2004-05-01 Todd Berman <tberman@sevenl.net>
14499 * driver.cs: Remove '.' from path_chars, now System.* loads properly
14502 2004-04-30 Jackson Harper <jackson@ximian.com>
14504 * codegen.cs: Open keys readonly.
14506 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14508 * typemanager.cs: don't report cyclic struct layout when a struct
14509 contains 2 or more fields of the same type. Failed for Pango.AttrShape
14510 which has 2 Pango.Rectangle fields.
14512 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
14514 * expression.cs: Handle IntPtr comparisons with IL code
14515 rather than a method call.
14517 2004-04-29 Martin Baulig <martin@ximian.com>
14519 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
14520 the list of PropertyInfo's in class hierarchy and find the
14521 accessor. Fixes #56013.
14523 2004-04-29 Martin Baulig <martin@ximian.com>
14525 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
14527 2004-04-29 Martin Baulig <martin@ximian.com>
14529 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14531 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
14533 2004-04-29 Martin Baulig <martin@ximian.com>
14535 * class.cs (ConstructorInitializer.Resolve): Check whether the
14536 parent .ctor is accessible. Fixes #52146.
14538 2004-04-29 Martin Baulig <martin@ximian.com>
14540 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14542 * statement.cs (Using.EmitLocalVariableDecls): Use
14543 TypeManager.idisposable_type, not typeof (IDisposable).
14544 (Foreach.EmitCollectionForeach): Added support for valuetypes.
14546 2004-04-29 Martin Baulig <martin@ximian.com>
14548 * class.cs (Event.Define): Don't emit the field and don't set
14549 RTSpecialName and SpecialName for events on interfaces. Fixes
14552 2004-04-29 Raja R Harinath <rharinath@novell.com>
14554 Refactor Attribute.ApplyAttributes.
14555 * attribute.cs (Attributable): New base class for objects that can
14556 have Attributes applied on them.
14557 (Attribute): Make AttributeUsage fields public.
14558 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
14559 (Attribute.IsInternalCall): New property.
14560 (Attribute.UsageAttr): Convert to a public read-only property.
14561 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
14562 (Attribute.ResolveType, Attribute.Resolve)
14563 (Attribute.ScanForIndexerName): Update to reflect changes.
14564 (Attribute.CheckAttributeTarget): Re-format.
14565 (Attribute.ApplyAttributes): Refactor, to various
14566 Attributable.ApplyAttributeBuilder methods.
14567 * decl.cs (MemberCore): Make Attributable.
14568 * class.cs (Accessor): Make Attributable.
14569 (MethodData.ApplyAttributes): Use proper attribute types, not
14571 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
14572 (TypeContainer.ApplyAttributeBuilder)
14573 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
14574 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
14575 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
14576 (Operator.ApplyAttributeBuilder): New factored-out methods.
14577 * const.cs (Const.ApplyAttributeBuilder): Likewise.
14578 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
14579 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
14580 * parameter.cs (ParameterBase): New Attributable base class
14581 that can also represent Return types.
14582 (Parameter): Update to the changes.
14584 2004-04-29 Jackson Harper <jackson@ximian.com>
14586 * driver.cs: Prefer the corlib system version when looking for
14587 assemblies in the GAC. This is still a hack, but its a better hack
14590 2004-04-29 Marek Safar <marek.safar@seznam.cz>
14592 * decl.cs, enum.cs: Improved error 3005 reporting.
14594 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
14595 (related_symbols): New private member for list of symbols
14596 related to reported error/warning.
14598 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
14600 2004-04-29 Martin Baulig <martin@ximian.com>
14602 * ecore.cs (Expression.Constantify): If we're an enum and
14603 TypeManager.TypeToCoreType() doesn't give us another type, use
14604 t.UnderlyingSystemType. Fixes #56178.
14606 2004-04-29 Martin Baulig <martin@ximian.com>
14608 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
14609 interfaces and for each interface, only add members directly
14610 declared in that interface. Fixes #53255.
14612 2004-04-28 Martin Baulig <martin@ximian.com>
14614 * expression.cs (ConditionalLogicalOperator): Use a temporary
14615 variable for `left' to avoid that we evaluate it more than once;
14618 2004-04-28 Martin Baulig <martin@ximian.com>
14620 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
14623 2004-04-28 Martin Baulig <martin@ximian.com>
14625 * statement.cs (LocalInfo.Resolve): Check whether the type is not
14628 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
14629 whether the type is not void (CS1547).
14631 2004-04-28 Martin Baulig <martin@ximian.com>
14633 * expression.cs (Unary.DoResolveLValue): Override this and report
14634 CS0131 for anything but Operator.Indirection.
14636 2004-04-28 Martin Baulig <martin@ximian.com>
14638 Committing a patch from Ben Maurer; see bug #50820.
14640 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14643 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14646 2004-04-28 Martin Baulig <martin@ximian.com>
14648 Committing a patch from Ben Maurer; see bug #50820.
14650 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14653 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14656 2004-04-28 Martin Baulig <martin@ximian.com>
14658 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
14659 (Block.AddLabel): Call DoLookupLabel() to only search in the
14662 2004-04-28 Martin Baulig <martin@ximian.com>
14664 * cfold.cs (ConstantFold.BinaryFold): Added special support for
14665 comparing StringConstants and NullLiterals in Equality and Inequality.
14667 2004-04-28 Jackson Harper <jackson@ximian.com>
14669 * driver.cs: Attempt to load referenced assemblies from the
14670 GAC. This is the quick and dirty version of this method that
14671 doesnt take into account versions and just takes the first
14672 canidate found. Will be good enough for now as we will not have more
14673 then one version installed into the GAC until I update this method.
14675 2004-04-28 Martin Baulig <martin@ximian.com>
14677 * typemanager.cs (TypeManager.CheckStructCycles): New public
14678 static method to check for cycles in the struct layout.
14680 * rootcontext.cs (RootContext.PopulateTypes): Call
14681 TypeManager.CheckStructCycles() for each TypeContainer.
14682 [Note: We only need to visit each type once.]
14684 2004-04-28 Martin Baulig <martin@ximian.com>
14686 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
14688 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
14689 success and added `out object value'. Use a `bool resolved' field
14690 to check whether we've already been called rather than
14691 `ConstantValue != null' since this breaks for NullLiterals.
14693 2004-04-28 Raja R Harinath <rharinath@novell.com>
14695 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
14696 setting of this flag, since the 'set' method may be non-public.
14698 2004-04-28 Raja R Harinath <rharinath@novell.com>
14700 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
14701 check on current_vector.Block.
14703 2004-04-27 Martin Baulig <martin@ximian.com>
14705 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
14706 a field initializer. Fixes #56459.
14708 2004-04-27 Martin Baulig <martin@ximian.com>
14710 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
14711 we're not attempting to use an indexer. Fixes #52154.
14713 2004-04-27 Martin Baulig <martin@ximian.com>
14715 * statement.cs (Return): Don't create a return label if we don't
14716 need it; reverts my change from January 20th. Thanks to Ben
14719 2004-04-27 Martin Baulig <martin@ximian.com>
14721 According to the spec, `goto' can only leave a nested scope, but
14724 * statement.cs (Block.LookupLabel): Only lookup in the current
14725 block, don't recurse into parent or child blocks.
14726 (Block.AddLabel): Check in parent and child blocks, report
14727 CS0140/CS0158 if we find a duplicate.
14728 (Block): Removed this indexer for label lookups.
14729 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
14730 this already does the error reporting for us.
14733 (FlowBranching.UsageVector.Block): New public variable; may be null.
14734 (FlowBranching.CreateSibling): Added `Block' argument.
14735 (FlowBranching.LookupLabel): New public virtual method. Lookup a
14736 label for the target of a `goto' and check whether we're not
14737 leaving a `finally'.
14739 2004-04-27 Martin Baulig <martin@ximian.com>
14741 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14742 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
14745 2004-04-27 Martin Baulig <martin@ximian.com>
14747 * statement.cs (Block.AddLabel): Also check for implicit blocks
14748 and added a CS0158 check.
14750 2004-04-27 Martin Baulig <martin@ximian.com>
14752 * flowanalysis.cs (FlowBranchingLoop): New class.
14753 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
14754 UsageVector's instead of an ArrayList.
14755 (FlowBranching.Label): Likewise.
14756 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
14757 (FlowBranching.AddBreakVector): New method.
14759 2004-04-27 Miguel de Icaza <miguel@ximian.com>
14761 * attribute.cs: Small regression fix: only convert the type if we
14762 the type is different, fixes System.Drawing build.
14764 2004-04-27 Martin Baulig <martin@ximian.com>
14766 * attribute.cs (Attribute.Resolve): If we have a constant value
14767 for a named field or property, implicity convert it to the correct
14770 2004-04-27 Raja R Harinath <rharinath@novell.com>
14772 * statement.cs (Block.Block): Implicit blocks share
14773 'child_variable_names' fields with parent blocks.
14774 (Block.AddChildVariableNames): Remove.
14775 (Block.AddVariable): Mark variable as "used by a child block" in
14776 every surrounding block.
14777 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
14778 been used in a child block, complain about violation of "Invariant
14779 meaning in blocks" rule.
14780 * cs-parser.jay (declare_local_variables): Don't use
14781 AddChildVariableNames.
14782 (foreach_statement): Don't create an implicit block: 'foreach'
14783 introduces a scope.
14785 2004-04-23 Miguel de Icaza <miguel@ximian.com>
14787 * convert.cs (ImplicitNumericConversion): 0 is also positive when
14788 converting from 0L to ulong. Fixes 57522.
14790 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14792 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
14793 derived class hides via 'new' keyword field from base class (test-242.cs).
14794 TODO: Handle this in the more general way.
14796 * class.cs (CheckBase): Ditto.
14798 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14800 * decl.cs (caching_flags): New member for storing cached values
14802 (MemberCore.Flags): New enum where bit flags for caching_flags
14804 (MemberCore.cls_compliance): Moved to caching_flags.
14805 (DeclSpace.Created): Moved to caching_flags.
14807 * class.cs: Use caching_flags instead of DeclSpace.Created
14809 2004-04-21 Miguel de Icaza <miguel@ximian.com>
14811 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
14812 if we are only a derived class, not a nested class.
14814 * typemanager.cs: Same as above, but do this at the MemberLookup
14815 level (used by field and methods, properties are handled in
14816 PropertyExpr). Allow for the qualified access if we are a nested
14819 2004-04-21 Marek Safar <marek.safar@seznam.cz>
14821 * class.cs: Refactoring.
14822 (IMethodData): New inteface; Holds links to parent members
14823 to avoid member duplication (reduced memory allocation).
14824 (Method): Implemented IMethodData interface.
14825 (PropertyBase): New inner classes for get/set methods.
14826 (PropertyBase.PropertyMethod): Implemented IMethodData interface
14827 (Event): New inner classes for add/remove methods.
14828 (Event.DelegateMethod): Implemented IMethodData interface.
14830 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
14831 EmitContext (related to class.cs refactoring).
14833 2004-04-21 Raja R Harinath <rharinath@novell.com>
14835 * delegate.cs (Delegate.VerifyApplicability): If the number of
14836 arguments are the same as the number of parameters, first try to
14837 verify applicability ignoring any 'params' modifier on the last
14841 2004-04-16 Raja R Harinath <rharinath@novell.com>
14843 * class.cs (TypeContainer.AddIndexer): Use
14844 'ExplicitInterfaceName' to determine if interface name was
14845 explicitly specified. 'InterfaceType' is not initialized at this time.
14846 (TypeContainer.DefineIndexers): Remove use of temporary list. The
14847 Indexers array is already in the required order. Initialize
14848 'IndexerName' only if there are normal indexers.
14849 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
14850 (TypeContainer.Emit): Emit DefaultMember attribute only if
14851 IndexerName is initialized.
14854 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
14856 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
14859 2004-04-15 Raja R Harinath <rharinath@novell.com>
14861 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
14865 * attribute.cs (Attribute.Resolve): Check for duplicate named
14869 2004-04-15 Miguel de Icaza <miguel@ximian.com>
14871 * iterators.cs (MarkYield): track whether we are in an exception,
14872 and generate code accordingly. Use a temporary value to store the
14873 result for our state.
14875 I had ignored a bit the interaction of try/catch with iterators
14876 since their behavior was not entirely obvious, but now it is
14877 possible to verify that our behavior is the same as MS .NET 2.0
14881 2004-04-14 Miguel de Icaza <miguel@ximian.com>
14883 * iterators.cs: Avoid creating temporaries if there is no work to
14886 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
14887 Enumerations, use TypeManager.EnumToUnderlying and call
14890 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
14893 (This.Emit): Use EmitContext.EmitThis to emit our
14896 (This.EmitAssign): Ditto.
14898 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
14899 codepaths, we will move all the functionality into
14902 (FieldExpr.EmitAssign): Ditto.
14904 This fixes several hidden bugs that I uncovered while doing a code
14905 review of this today.
14907 * codegen.cs (EmitThis): reworked so the semantics are more clear
14908 and also support value types "this" instances.
14910 * iterators.cs: Changed so that for iterators in value types, we
14911 do not pass the value type as a parameter.
14913 Initialization of the enumerator helpers is now done in the caller
14914 instead of passing the parameters to the constructors and having
14915 the constructor set the fields.
14917 The fields have now `assembly' visibility instead of private.
14919 2004-04-11 Miguel de Icaza <miguel@ximian.com>
14921 * expression.cs (Argument.Resolve): Check if fields passed as ref
14922 or out are contained in a MarshalByRefObject.
14924 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
14925 another compiler type.
14927 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
14929 * class.cs (Indexer.Define): use the new name checking method.
14930 Also, return false on an error.
14931 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
14932 (is_identifier_[start/part]_character): make static.
14934 2004-04-10 Miguel de Icaza <miguel@ximian.com>
14936 * expression.cs (Binary.ResolveOperator): Do no append strings
14937 twice: since we can be invoked more than once (array evaluation)
14938 on the same concatenation, take care of this here. Based on a fix
14939 from Ben (bug #56454)
14941 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
14943 * codegen.cs: Fix another case where CS1548 must be reported (when
14944 delay-sign isn't specified and no private is available #56564). Fix
14945 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
14946 error when MCS is used on the MS runtime and we need to delay-sign
14947 (which seems unsupported by AssemblyBuilder - see #56621).
14949 2004-04-08 Marek Safar <marek.safar@seznam.cz>
14951 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
14952 (TypeManager.ComputeNamespaces): Faster implementation for
14955 * compiler.csproj: Updated AssemblyName to mcs.
14957 2004-04-07 Miguel de Icaza <miguel@ximian.com>
14959 * rootcontext.cs: Add new types to the boot resolution.
14961 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
14962 MulticastDelegate is not allowed.
14964 * typemanager.cs: Add new types to lookup: System.TypedReference
14967 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
14968 check for TypedReference or ArgIterator, they are not allowed.
14970 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
14971 makes us properly catch 1510 in some conditions (see bug 56016 for
14974 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
14976 * CryptoConvert.cs: update from corlib version
14979 2004-04-05 Miguel de Icaza <miguel@ximian.com>
14981 * class.cs (Indexer.Define): Check indexername declaration
14983 2004-04-05 Marek Safar <marek.safar@seznam.cz>
14985 * attribute.cs (IsClsCompliant): Fixed problem with handling
14986 all three states (compliant, not-compliant, undetected).
14988 2004-03-30 Marek Safar <marek.safar@seznam.cz>
14990 * attribute.cs (Attribute): Location is now public.
14991 (Resolve): Store resolved arguments (pos_values) in attribute class.
14992 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
14993 (GetClsCompliantAttributeValue): New method that gets
14994 CLSCompliantAttribute value.
14995 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
14996 if exists else null.
14997 (AttributeTester): New class for CLS-Compliant verification routines.
14999 * class.cs (Emit): Add CLS-Compliant verification.
15000 (Method.GetSignatureForError): Implemented.
15001 (Constructor.GetSignatureForError): Implemented
15002 (Constructor.HasCompliantArgs): Returns if constructor has
15003 CLS-Compliant arguments.
15004 (Constructor.Emit): Override.
15005 (Construcor.IsIdentifierClsCompliant): New method; For constructors
15006 is needed to test only parameters.
15007 (FieldBase.GetSignatureForError): Implemented.
15008 (TypeContainer): New member for storing base interfaces.
15009 (TypeContainer.FindMembers): Search in base interfaces too.
15011 * codegen.cs (GetClsComplianceAttribute): New method that gets
15012 assembly or module CLSCompliantAttribute value.
15013 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
15015 (ModuleClass.Emit): Add error 3012 test.
15017 * const.cs (Emit): Override and call base for CLS-Compliant tests.
15019 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
15020 state for all decl types.
15021 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
15022 if CLS-Compliant tests are required.
15023 (IsClsCompliaceRequired): New method. Analyze whether code
15024 must be CLS-Compliant.
15025 (IsExposedFromAssembly): New method. Returns true when MemberCore
15026 is exposed from assembly.
15027 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
15028 value or gets cached value.
15029 (HasClsCompliantAttribute): New method. Returns true if MemberCore
15030 is explicitly marked with CLSCompliantAttribute.
15031 (IsIdentifierClsCompliant): New abstract method. This method is
15032 used to testing error 3005.
15033 (IsIdentifierAndParamClsCompliant): New method. Common helper method
15034 for identifier and parameters CLS-Compliant testing.
15035 (VerifyClsCompliance): New method. The main virtual method for
15036 CLS-Compliant verifications.
15037 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
15038 null. I don't know why is null (too many public members !).
15039 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
15040 and get value of first CLSCompliantAttribute that found.
15042 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
15043 (VerifyClsCompliance): Override and add extra tests.
15045 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
15046 clscheck- disable CLS-Compliant verification event if assembly is has
15047 CLSCompliantAttribute(true).
15049 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
15050 ApllyAttribute is now called in emit section as in the other cases.
15051 Possible future Emit integration.
15052 (IsIdentifierClsCompliant): New override.
15053 (VerifyClsCompliance): New override.
15054 (GetEnumeratorName): Returns full enum name.
15056 * parameter.cs (GetSignatureForError): Implemented.
15058 * report.cs (WarningData): New struct for Warning message information.
15059 (LocationOfPreviousError): New method.
15060 (Warning): New method. Reports warning based on the warning table.
15061 (Error_T): New method. Reports error based on the error table.
15063 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
15064 verifications are done here.
15066 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
15068 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
15069 CLSCompliantAttribute.
15070 (all_imported_types): New member holds all imported types from other
15072 (LoadAllImportedTypes): New method fills static table with exported types
15073 from all referenced assemblies.
15074 (Modules): New property returns all assembly modules.
15076 2004-03-30 Miguel de Icaza <miguel@ximian.com>
15078 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
15079 throwing a parser error.
15081 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
15082 which removes the hardcoded get_/set_ prefixes for properties, as
15083 IL allows for the properties to be named something else.
15087 * expression.cs: Do not override operand before we know if it is
15088 non-null. Fix 56207
15090 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15092 * typemanager.cs: support for pinned variables.
15094 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15096 * decl.cs, typemanager.cs: Avoid using an arraylist
15097 as a buffer if there is only one result set.
15099 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15101 * expression.cs: Make sure you cant call a static method
15102 with an instance expression, bug #56174.
15104 2004-03-29 Miguel de Icaza <miguel@ximian.com>
15106 * class.cs (IsDuplicateImplementation): Improve error reporting to
15107 flag 663 (method only differs in parameter modifier).
15109 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
15110 in preprocessor directives.
15112 * location.cs (LookupFile): Allow for the empty path.
15114 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
15115 better approach for some of that patch, but its failing with the
15116 CharSet enumeration. For now try/catch will do.
15118 * typemanager.cs: Do not crash if a struct does not have fields.
15121 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15123 * expression.cs: cs0213, cant fix a fixed expression.
15126 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15128 * cs-parser.jay: detect invalid embeded statements gracefully.
15131 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15133 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
15136 the invocation type may not be a subclass of the tye of the item/
15137 The type of the item must be a subclass of the invocation item.
15142 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
15144 * attribute.cs: Added methods to get a string and a bool from an
15145 attribute. Required to information from AssemblyKeyFileAttribute,
15146 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
15147 * codegen.cs: Modified AssemblyName creation to include support for
15148 strongnames. Catch additional exceptions to report them as CS1548.
15149 * compiler.csproj: Updated include CryptoConvert.cs.
15150 * compiler.csproj.user: Removed file - user specific configuration.
15151 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
15152 Mono.Security assembly. The original class is maintained and tested in
15153 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
15154 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
15155 like CSC 8.0 (C# v2) supports.
15156 * Makefile: Added CryptoConvert.cs to mcs sources.
15157 * rootcontext.cs: Added new options for strongnames.
15159 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
15161 * driver.cs: For --expect-error, report error code `2'
15162 if the program compiled with no errors, error code `1' if
15163 it compiled with an error other than the one expected.
15165 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
15167 * compiler.csproj: Updated for Visual Studio .NET 2003.
15168 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
15169 * compiler.sln: Updated for Visual Studio .NET 2003.
15171 2004-03-24 Ravi Pratap M <ravi@ximian.com>
15173 * expression.cs: Fix bug #47234. We basically need to apply the
15174 rule that we prefer the conversion of null to a reference type
15175 when faced with a conversion to 'object' (csc behaviour).
15177 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15179 * statement.cs: Shorter form for foreach, eliminates
15180 a local variable. r=Martin.
15182 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15184 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
15185 checks if we can use brtrue/brfalse to test for 0.
15186 * expression.cs: use the above in the test for using brtrue/brfalse.
15187 cleanup code a bit.
15189 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15191 * expression.cs: Rewrite string concat stuff. Benefits:
15193 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
15194 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
15195 rather than a concat chain.
15197 * typemanager.cs: Add lookups for more concat overloads.
15199 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15201 * expression.cs: Emit shorter il code for array init.
15218 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
15220 * statement.cs: Before, two switch blocks would be merged if the
15221 total size of the blocks (end_item - begin_item + 1) was less than
15222 two times the combined sizes of the blocks.
15224 Now, it will only merge if after the merge at least half of the
15229 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
15231 * class.cs : csc build fix for GetMethods(). See bug #52503.
15233 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
15235 * expression.cs: Make sure fp comparisons work with NaN.
15236 This fixes bug #54303. Mig approved this patch a long
15237 time ago, but we were not able to test b/c the runtime
15240 2004-03-19 Miguel de Icaza <miguel@ximian.com>
15242 * ecore.cs (TypExpr.GetHashCode): implement this overload.
15244 2004-03-19 Martin Baulig <martin@ximian.com>
15246 * class.cs (MemberCore.IsDuplicateImplementation): Report the
15247 error here and not in our caller.
15249 2004-03-19 Martin Baulig <martin@ximian.com>
15251 * interface.cs: Completely killed this file.
15252 (Interface): We're now a TypeContainer and live in class.cs.
15254 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
15255 argument; we're now also called for interfaces.
15256 (TypeContainer.DefineMembers): Allow this method being called
15258 (TypeContainer.GetMethods): New public method; formerly known as
15259 Interface.GetMethod(). This is used by PendingImplementation.
15260 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
15261 it's now private and non-static.
15262 (Interface): Moved this here; it's now implemented similar to
15264 (Method, Property, Event, Indexer): Added `bool is_interface'
15265 argument to their .ctor's.
15266 (MemberBase.IsInterface): New public field.
15268 * cs-parser.jay: Create normal Method, Property, Event, Indexer
15269 instances instead of InterfaceMethod, InterfaceProperty, etc.
15270 (opt_interface_base): Removed; we now use `opt_class_base' instead.
15271 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
15273 2004-03-19 Martin Baulig <martin@ximian.com>
15275 * class.cs (MethodCore.IsDuplicateImplementation): New private
15276 method which does the CS0111 checking.
15277 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
15278 Use IsDuplicateImplementation().
15280 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
15282 * decl.cs (FindMemberToOverride): New method to find the correct
15283 method or property to override in the base class.
15285 - Make Method/Property use the above method to find the
15286 version in the base class.
15287 - Remove the InheritableMemberSignatureCompare as it is now
15290 This patch makes large code bases much faster to compile, as it is
15291 O(n) rather than O(n^2) to do this validation.
15293 Also, it fixes bug 52458 which is that nested classes are not
15294 taken into account when finding the base class member.
15296 Reviewed/Approved by Martin.
15298 2004-03-17 Marek Safar <marek.safar@seznam.cz>
15300 * interface.cs: In all interface classes removed redundant
15301 member initialization.
15303 2004-03-16 Martin Baulig <martin@ximian.com>
15305 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
15307 2004-03-15 Miguel de Icaza <miguel@ximian.com>
15309 * decl.cs (DefineTypeAndParents): New helper method to define a
15310 type's containers before the type itself is defined; This is a
15311 bug exposed by the recent changes to Windows.Forms when an
15312 implemented interface was defined inside a class that had not been
15315 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
15317 (Check): Loop correctly to report errors modifiers
15318 (UNSAFE was not in the loop, since it was the same as TOP).
15320 * interface.cs: Every interface member now takes a ModFlags,
15321 instead of a "is_new" bool, which we set on the base MemberCore.
15323 Every place where we called "UnsafeOk" in the interface, now we
15324 call the proper member (InterfaceMethod.UnsafeOK) instead to get
15325 the unsafe settings from the member declaration instead of the
15326 container interface.
15328 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
15330 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
15331 `set_indexer_name' to the pending bits (one per type).
15333 We fixed a bug today that was picking the wrong method to
15334 override, since for properties the existing InterfaceMethod code
15335 basically ignored the method name. Now we make sure that the
15336 method name is one of the valid indexer names.
15338 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
15340 * support.cs (SeekableStreamReader): Keep track of stream byte
15341 positions and don't mix them with character offsets to the buffer.
15343 Patch from Gustavo Giráldez
15345 2004-03-15 Marek Safar <marek.safar@seznam.cz>
15347 * interface.cs (InterfaceSetGetBase): Removed double member
15348 initialization, base class does it as well.
15350 2004-03-13 Martin Baulig <martin@ximian.com>
15352 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
15353 when compiling corlib.
15355 2004-03-13 Miguel de Icaza <miguel@ximian.com>
15357 * convert.cs (ExplicitConversion): We were reporting an error on
15358 certain conversions (object_type source to a value type, when the
15359 expression was `null') before we had a chance to pass it through
15360 the user defined conversions.
15362 * driver.cs: Replace / and \ in resource specifications to dots.
15365 * class.cs: Add check for duplicate operators. Fixes 52477
15367 2004-03-11 Miguel de Icaza <miguel@ximian.com>
15369 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
15370 that are in the middle of the statements, not only at the end.
15373 * class.cs (TypeContainer.AddField): No longer set the
15374 `HaveStaticConstructor' flag, now we call it
15375 `UserDefineStaticConstructor' to diferentiate the slightly
15376 semantic difference.
15378 The situation is that we were not adding BeforeFieldInit (from
15379 Modifiers.TypeAttr) to classes that could have it.
15380 BeforeFieldInit should be set to classes that have no static
15385 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
15387 And most importantly Zoltan's comment:
15389 http://bugzilla.ximian.com/show_bug.cgi?id=44229
15391 "I think beforefieldinit means 'it's ok to initialize the type sometime
15392 before its static fields are used', i.e. initialization does not need
15393 to be triggered by the first access to the type. Setting this flag
15394 helps the JIT to compile better code, since it can run the static
15395 constructor at JIT time, and does not need to generate code to call it
15396 (possibly lots of times) at runtime. Unfortunately, mcs does not set
15397 this flag for lots of classes like String.
15399 csc sets this flag if the type does not have an explicit static
15400 constructor. The reasoning seems to be that if there are only static
15401 initalizers for a type, and no static constructor, then the programmer
15402 does not care when this initialization happens, so beforefieldinit
15405 This bug prevents the AOT compiler from being usable, since it
15406 generates so many calls to mono_runtime_class_init that the AOT code
15407 is much slower than the JITted code. The JITted code is faster,
15408 because it does not generate these calls if the vtable is type is
15409 already initialized, which is true in the majority of cases. But the
15410 AOT compiler can't do this."
15412 2004-03-10 Miguel de Icaza <miguel@ximian.com>
15414 * class.cs (MethodData.Emit): Refactor the code so symbolic
15415 information is generated for destructors; For some reasons we
15416 were taking a code path that did not generate symbolic information
15419 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
15421 * class.cs: Create a Constructor.CheckBase method that
15422 takes care of all validation type code. The method
15423 contains some code that was moved from Define.
15425 It also includes new code that checks for duplicate ctors.
15426 This fixes bug #55148.
15428 2004-03-09 Joshua Tauberer <tauberer@for.net>
15430 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
15431 a { ... }-style array creation invokes EmitStaticInitializers
15432 which is not good for reference-type arrays. String, decimal
15433 and now null constants (NullCast) are not counted toward
15434 static initializers.
15436 2004-03-05 Martin Baulig <martin@ximian.com>
15438 * location.cs (SourceFile.HasLineDirective): New public field;
15439 specifies whether the file contains or is referenced by a "#line"
15441 (Location.DefineSymbolDocuments): Ignore source files which
15442 either contain or are referenced by a "#line" directive.
15444 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
15446 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
15447 direct access to our parent, so check the method inline there.
15449 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
15451 * expression.cs (Invocation.EmitCall): Miguel's last commit
15452 caused a regression. If you had:
15457 In Foo the implict this would be null.
15459 2004-02-27 Miguel de Icaza <miguel@ximian.com>
15461 * expression.cs (Invocation.EmitCall): If the method is not
15462 virtual, do not emit a CallVirt to it, use Call.
15464 * typemanager.cs (GetFullNameSignature): Improve the method to
15465 cope with ".ctor" and replace it with the type name.
15467 * class.cs (ConstructorInitializer.Resolve): Now the method takes
15468 as an argument the ConstructorBuilder where it is being defined,
15469 to catch the recursive constructor invocations.
15471 2004-02-26 Miguel de Icaza <miguel@ximian.com>
15473 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
15474 routines to check if a type is an enumerable/enumerator allow
15475 classes that implement the IEnumerable or IEnumerator interfaces.
15477 * class.cs (Property, Operator): Implement IIteratorContainer, and
15478 implement SetYields.
15480 (Property.Define): Do the block swapping for get_methods in the
15481 context of iterators. We need to check if Properties also
15482 include indexers or not.
15484 (Operator): Assign the Block before invoking the
15485 OperatorMethod.Define, so we can trigger the Iterator code
15488 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
15489 Property and Operator classes are not created when we parse the
15490 declarator but until we have the block completed, so we use a
15491 singleton SimpleIteratorContainer.Simple to flag whether the
15492 SetYields has been invoked.
15494 We propagate this setting then to the Property or the Operator to
15495 allow the `yield' to function.
15497 2004-02-25 Marek Safar <marek.safar@seznam.cz>
15499 * codegen.cs: Implemented attribute support for modules.
15500 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
15501 Assembly/Module functionality.
15503 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
15504 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
15505 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
15507 2004-02-16 Marek Safar <marek.safar@seznam.cz>
15509 * interface.cs (FindMembers): The operation is performed on all base
15510 interfaces and not only on the first. It is required for future CLS Compliance patch.
15512 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
15514 * statement.cs, codegen.cs:
15515 This patch deals with patterns such as:
15517 public class List : IEnumerable {
15519 public MyEnumerator GetEnumerator () {
15520 return new MyEnumerator(this);
15523 IEnumerator IEnumerable.GetEnumerator () {
15527 public struct MyEnumerator : IEnumerator {
15532 Before, there were a few things we did wrong:
15533 1) we would emit callvirt on a struct, which is illegal
15534 2) we emited ldarg when we needed to emit ldarga
15535 3) we would mistakenly call the interface methods on an enumerator
15536 type that derived from IEnumerator and was in another assembly. For example:
15538 public class MyEnumerator : IEnumerator
15540 Would have the interface methods called, even if there were public impls of the
15541 method. In a struct, this lead to invalid IL code.
15543 2004-02-11 Marek Safar <marek.safar@seznam.cz>
15545 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
15548 * delegate.cs (Define): Fixed crash when delegate type is undefined.
15550 2004-02-11 Miguel de Icaza <miguel@ximian.com>
15552 * cs-parser.jay: Fix small regression: we were not testing V2
15553 compiler features correctly.
15555 * interface.cs: If the emit context is null, then create one
15557 2004-02-09 Marek Safar <marek.safar@seznam.cz>
15559 * decl.cs (GetSignatureForError): New virtual method to get full name
15560 for error messages.
15562 * attribute.cs (IAttributeSupport): New interface for attribute setting.
15563 Now it is possible to rewrite ApplyAttributes method to be less if/else.
15565 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
15566 Duplicated members and code in these classes has been removed.
15567 Better encapsulation in these classes.
15569 2004-02-07 Miguel de Icaza <miguel@ximian.com>
15571 * assign.cs (Assign.DoResolve): When dealing with compound
15572 assignments, there is a new rule in ECMA C# 2.4 (might have been
15573 there before, but it is documented here) that states that in:
15577 If b is of type int, and the `op' is a shift-operator, then the
15578 above is evaluated as:
15582 * expression.cs (Binary.ResolveOperator): Instead of testing for
15583 int/uint/long/ulong, try to implicitly convert to any of those
15584 types and use that in pointer arithmetic.
15586 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
15587 method to print information for from the type, not from the
15588 null-method we were given.
15590 2004-02-01 Duncan Mak <duncan@ximian.com>
15592 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
15593 parsing for cmd, fixes bug #53694.
15595 2004-02-04 Marek Safar <marek.safar@seznam.cz>
15597 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
15598 in the member name duplication tests. Property and operator name duplication
15599 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
15601 2004-02-03 Marek Safar <marek.safar@seznam.cz>
15603 * interface.cs (PopulateMethod): Fixed crash when interface method
15604 returns not existing type (error test cs0246-3.cs).
15606 2004-02-02 Ravi Pratap M <ravi@ximian.com>
15608 * cs-parser.jay (interface_accessors): Re-write actions to also
15609 store attributes attached to get and set methods. Fix spelling
15612 (inteface_property_declaration): Modify accordingly.
15614 (InterfaceAccessorInfo): New helper class to store information to pass
15615 around between rules that use interface_accessors.
15617 * interface.cs (Emit): Apply attributes on the get and set
15618 accessors of properties and indexers too.
15620 * attribute.cs (ApplyAttributes): Modify accordingly to use the
15621 right MethodBuilder when applying attributes to the get and set accessors.
15623 2004-01-31 Miguel de Icaza <miguel@ximian.com>
15625 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
15627 2004-01-26 Miguel de Icaza <miguel@ximian.com>
15629 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
15631 2004-01-25 Miguel de Icaza <miguel@ximian.com>
15633 * cs-parser.jay: Remove YIELD token, instead use the new grammar
15634 changes that treat `yield' specially when present before `break'
15635 or `return' tokens.
15637 * cs-tokenizer.cs: yield is no longer a keyword.
15639 2004-01-23 Marek Safar <marek.safar@seznam.cz>
15641 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
15642 setting for default constructors.
15643 For default constructors are almost every time set wrong Modifier. The
15644 generated IL code has been alright. But inside mcs this values was
15645 wrong and this was reason why several of my CLS Compliance tests
15648 2004-01-22 Martin Baulig <martin@ximian.com>
15650 * cs-parser.jay (namespace_or_type_name): Return an Expression,
15651 not a QualifiedIdentifier. This is what `type_name_expression'
15652 was previously doing.
15653 (type_name_expression): Removed; the code is now in
15654 `namespace_or_type_name'.
15655 (qualified_identifier): Removed, use `namespace_or_type_name'
15657 (QualifiedIdentifier): Removed this class.
15659 2004-01-22 Martin Baulig <martin@ximian.com>
15661 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
15662 not a string as alias name.
15664 2004-01-21 Miguel de Icaza <miguel@ximian.com>
15666 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
15667 #52730 bug, and instead compute correctly the need to use a
15668 temporary variable when requesting an address based on the
15669 static/instace modified of the field and the constructor.
15671 2004-01-21 Martin Baulig <martin@ximian.com>
15673 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
15674 class and namespace before looking up aliases. Fixes #52517.
15676 2004-01-21 Martin Baulig <martin@ximian.com>
15678 * flowanalysis.cs (UsageVector.Merge): Allow variables being
15679 assinged in a 'try'; fixes exception4.cs.
15681 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15682 * class.cs : Implemented parameter-less constructor for TypeContainer
15684 * decl.cs: Attributes are now stored here. New property OptAttributes
15686 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
15688 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
15690 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15692 * typemanager.cs (CSharpSignature): Now reports also inner class name.
15693 (CSharpSignature): New method for indexer and property signature.
15695 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15697 * pending.cs (IsVirtualFilter): Faster implementation.
15699 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15701 * typemanager.cs: Avoid inclusion of same assembly more than once.
15703 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15705 * cs-parser.jay: Fixed problem where the last assembly attribute
15706 has been applied also to following declaration (class, struct, etc.)
15708 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15710 * class.cs: Added error CS0538, CS0539 reporting.
15711 Fixed crash on Microsoft runtime when field type is void.
15713 * cs-parser.jay: Added error CS0537 reporting.
15715 * pending.cs: Added error CS0535 reporting.
15716 Improved error report for errors CS0536, CS0534.
15718 2004-01-20 Miguel de Icaza <miguel@ximian.com>
15720 Merge a few bits from the Anonymous Method MCS tree.
15722 * statement.cs (ToplevelBlock): New class for toplevel methods,
15723 will hold anonymous methods, lifted variables.
15725 * cs-parser.jay: Create toplevel blocks for delegates and for
15726 regular blocks of code.
15728 2004-01-20 Martin Baulig <martin@ximian.com>
15730 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
15731 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
15732 and `NeedExplicitReturn'; added `IsLastStatement'.
15733 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
15734 have a `ReturnLabel' or we're not unreachable.
15736 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
15737 child's reachability; don't just override ours with it. Fixes
15738 #58058 (lluis's example).
15739 (FlowBranching): Added public InTryOrCatch(), InCatch(),
15740 InFinally(), InLoop(), InSwitch() and
15741 BreakCrossesTryCatchBoundary() methods.
15743 * statement.cs (Return): Do all error checking in Resolve().
15744 Unless we are the last statement in a top-level block, always
15745 create a return label and jump to it.
15746 (Break, Continue): Do all error checking in Resolve(); also make
15747 sure we aren't leaving a `finally'.
15748 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
15749 statement in a top-level block.
15750 (Block.Flags): Added `IsDestructor'.
15751 (Block.IsDestructor): New public property.
15753 2004-01-20 Martin Baulig <martin@ximian.com>
15755 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
15757 2004-01-20 Martin Baulig <martin@ximian.com>
15759 * statement.cs (Statement.ResolveUnreachable): New public method.
15760 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
15761 (Block.Resolve): Resolve unreachable statements.
15763 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15765 * expression.cs: We need to fix the case where we do
15766 not have a temp variable here.
15768 * assign.cs: Only expression compound assignments need
15769 temporary variables.
15771 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15773 * flowanalysis.cs: Reduce memory allocation in a few ways:
15774 - A block with no variables should not allocate a bit
15776 - A method with no out parameters does not need any tracking
15777 for assignment of the parameters, so we need not allocate
15780 public readonly Type[] VariableTypes;
15781 public readonly string[] VariableNames;
15782 Are redundant. The data is already stored in the variable
15783 map, so we need not allocate another array for it.
15784 - We need to add alot of checks for if (params | locals) == null
15785 due to the first two changes.
15787 2004-01-18 Miguel de Icaza <miguel@ximian.com>
15789 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
15790 implement IMemoryLocation, we store a copy on a local variable and
15791 take the address of it. Patch from Benjamin Jemlich
15793 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
15794 to use a special "type_name_expression" rule which reduces the
15795 number of "QualifiedIdentifier" classes created, and instead
15796 directly creates MemberAccess expressions.
15798 2004-01-17 Miguel de Icaza <miguel@ximian.com>
15800 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
15801 that fixes #52853. Null literal assignment to ValueType
15803 * class.cs (MethodData.Emit): Instead of checking the name of the
15804 method to determine if its a destructor, create a new derived
15805 class from Method called Destructor, and test for that.
15807 * cs-parser.jay: Create a Destructor object instead of a Method.
15809 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
15813 2004-01-16 Miguel de Icaza <miguel@ximian.com>
15815 * expression.cs (Binary.ResolveOperator): Perform an implicit
15816 conversion from MethodGroups to their delegate types on the
15817 Addition operation.
15819 * delegate.cs: Introduce a new class DelegateCreation that is the
15820 base class for `NewDelegate' and `ImplicitDelegateCreation',
15821 factor some code in here.
15823 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
15824 conversion from MethodGroups to compatible delegate types.
15826 * ecore.cs (Expression.Resolve): Do not flag error 654
15827 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
15828 we allow conversions from MethodGroups to delegate types now.
15830 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
15831 assignments in v2 either.
15833 2004-01-10 Miguel de Icaza <miguel@ximian.com>
15835 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
15836 static read-only fields in ctors.
15838 Applied patch from Benjamin Jemlich
15840 * expression.cs (UnaryMutator): Avoid leaking local variables.
15842 2004-01-09 Miguel de Icaza <miguel@ximian.com>
15844 * cs-tokenizer.cs (IsCastToken): Allow the various native types
15845 here to return true, as they can be used like this:
15847 (XXX) int.MEMBER ()
15849 Fixed 49836 and all the other dups
15851 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
15853 * driver.cs: Implement /win32res and /win32icon.
15855 2004-01-08 Miguel de Icaza <miguel@ximian.com>
15857 * cs-parser.jay: Add a rule to improve error handling for the
15858 common mistake of placing modifiers after the type.
15860 2004-01-07 Miguel de Icaza <miguel@ximian.com>
15862 * cs-parser.jay (interface_event_declaration): Catch
15863 initialization of events on interfaces, and report cs0068
15865 * cs-parser.jay (interface_event_declaration): Catch
15866 initialization of events.
15868 * ecore.cs: Better report missing constructors.
15870 * expression.cs (Binary.ResolveOperator): My previous bug fix had
15871 the error reporting done in the wrong place. Fix.
15873 * expression.cs (Binary.ResolveOperator): Catch the
15874 operator + (E x, E y) error earlier, and later allow for implicit
15875 conversions in operator +/- (E e, U x) from U to the underlying
15878 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
15879 52596, if the container class is abstract, the default constructor
15880 is protected otherwise its public (before, we were always public).
15882 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
15885 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
15886 Jemlich that fixes bug #52597, MCS was generating invalid code for
15887 idisposable structs. Thanks to Ben for following up with this
15890 2004-01-06 Miguel de Icaza <miguel@ximian.com>
15892 * driver.cs: Allow assemblies without code to be generated, fixes
15895 2004-01-07 Nick Drochak <ndrochak@gol.com>
15897 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
15899 2004-01-05 Miguel de Icaza <miguel@ximian.com>
15901 * cs-parser.jay: Add rules to improve error reporting if fields or
15902 methods are declared at the namespace level (error 116)
15904 * Add rules to catch event add/remove
15906 2004-01-04 David Sheldon <dave-mono@earth.li>
15908 * expression.cs: Added matching ")" to error message for
15911 2004-01-03 Todd Berman <tberman@gentoo.org>
15913 * ecore.cs, attribute.cs:
15914 Applying fix from #52429.
15916 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15918 * ecore.cs, expression.cs, statement.cs:
15919 Total rewrite of how we handle branching. We
15920 now handle complex boolean expressions with fewer
15921 jumps. As well if (x == 0) no longer emits a ceq.
15923 if (x is Foo) is much faster now, because we generate
15926 Overall, we get a pretty big improvement on our benchmark
15927 tests. The code we generate is smaller and more readable.
15929 I did a full two-stage bootstrap. The patch was reviewed
15930 by Martin and Miguel.
15932 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15934 * cs-parser.jay: Make primary_expression not take a QI.
15935 we dont need this because the member_access rule covers
15936 us here. So we replace the rule with just IDENTIFIER.
15938 This has two good effects. First, we remove a s/r conflict.
15939 Second, we allocate many fewer QualifiedIdentifier objects.
15941 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15943 * attribute.cs: Handle MarshalAs attributes as pseudo, and
15944 set the correct information via SRE. This prevents
15945 hanging on the MS runtime. Fixes #29374.
15947 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15949 * convert.cs: correctly handle conversions to value types
15950 from Enum and ValueType as unboxing conversions.
15952 Fixes bug #52569. Patch by Benjamin Jemlich.
15954 2004-01-02 Ravi Pratap <ravi@ximian.com>
15956 * expression.cs (BetterConversion): Prefer int -> uint
15957 over int -> ulong (csc's behaviour). This fixed bug #52046.
15959 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
15961 * decl.cs (MemberCache.FindMembers): now returns a
15964 * typemanager.cs: In general, go with with ^^.
15965 (CopyNewMethods): take an IList.
15966 (RealMemberLookup): Only allocate an arraylist
15967 if we copy from two sets of methods.
15969 This change basically does two things:
15970 1) Fewer array lists allocated due to CopyNewMethods.
15971 2) the explicit cast in MemberList costed ALOT.
15973 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
15975 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
15976 a hashtable to avoid needless string allocations when an identifier is
15977 used more than once (the common case).
15979 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15981 * pending.cs: MS's TypeBuilder.GetInterfaces ()
15982 is broken, it will not return anything. So, we
15983 have to use the information we have in mcs to
15986 * typemanager.cs: Add a cache for GetInterfaces,
15987 since this will now be used more often (due to ^^)
15989 (GetExplicitInterfaces) New method that gets the
15990 declared, not effective, interfaces on a type
15991 builder (eg, if you have interface IFoo, interface
15992 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
15995 This patch makes MCS able to bootstrap itself on
15998 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
16000 * expression.cs: Remove the Nop's that Miguel put
16003 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16005 * report.cs, codegen.cs: Give the real stack trace to
16006 the error when an exception is thrown.
16008 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16010 * decl.cs: only allocate hashtables for ifaces if
16013 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16015 * expression.cs: fix the error from cs0121-2.cs
16016 (a parent interface has two child interfaces that
16017 have a function with the same name and 0 params
16018 and the function is called through the parent).
16020 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
16022 * class.cs, rootcontext.cs, typmanager.cs: do not
16025 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
16027 * codegen.cs: remove stack for the ec flow branching.
16028 It is already a linked list, so no need.
16030 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
16032 * Makefile: Allow custom profiler here.
16034 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
16036 * typemanager.cs (LookupType):
16037 - Use a static char [], because split takes
16038 a param array for args, so it was allocating
16040 - Do not store true in a hashtable, it boxes.
16042 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
16044 * flowanalysis.cs: bytify common enums.
16046 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16048 * modifiers.cs: Add a new set of flags for the
16049 flags allowed on explicit interface impls.
16050 * cs-parser.jay: catch the use of modifiers in
16051 interfaces correctly.
16052 * class.cs: catch private void IFoo.Blah ().
16054 All related to bug #50572.
16056 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16058 * decl.cs: Rewrite the consistant accessability checking.
16059 Accessability is not linear, it must be implemented in
16060 a tableish way. Fixes #49704.
16062 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16064 * expression.cs: Handle negation in a checked context.
16065 We must use subtraction from zero. Fixes #38674.
16067 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
16069 * class.cs: Ignore static void main in DLLs.
16070 * rootcontext.cs: Handle the target type here,
16071 since we are have to access it from class.cs
16072 * driver.cs: account for the above.
16074 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
16076 * report.cs: Give line numbers and files if available.
16078 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
16080 * driver.cs: Implement /addmodule.
16082 * typemanager.cs: Change 'modules' field so it now contains Modules not
16085 2003-12-20 Martin Baulig <martin@ximian.com>
16087 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
16088 (FieldBase.IsAssigned): Removed this field.
16089 (FieldBase.SetAssigned): New public method.
16090 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
16092 2003-12-20 Martin Baulig <martin@ximian.com>
16094 * expression.cs (LocalVariableReference.DoResolve): Don't set
16095 `vi.Used' if we're called from DoResolveLValue().
16097 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
16098 returns the usage vector it just merged into the current one -
16099 pass this one to UsageWarning().
16100 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
16101 of the `EmitContext', don't call this recursively on our children.
16103 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
16105 * driver.cs: Implement /target:module.
16107 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
16109 * support.cs (CharArrayHashtable): New helper class.
16111 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
16112 char arrays, not strings, so we can avoid creating a string in
16113 consume_identifier if the identifier is a keyword.
16115 2003-12-16 Martin Baulig <martin@ximian.com>
16117 * statement.cs (LocalInfo.Assigned): Removed this property.
16118 (LocalInfo.Flags): Removed `Assigned'.
16119 (LocalInfo.IsAssigned): New public method; takes the EmitContext
16120 and uses flow analysis.
16121 (Block.UsageWarning): Made this method private.
16122 (Block.Resolve): Call UsageWarning() if appropriate.
16124 * expression.cs (LocalVariableReference.DoResolve): Always set
16125 LocalInfo.Used here.
16127 2003-12-13 Martin Baulig <martin@ximian.com>
16129 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
16130 any value here; we're now using flow analysis to figure out
16131 whether a statement/block returns a value.
16133 2003-12-13 Martin Baulig <martin@ximian.com>
16135 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
16137 (FlowBranching.MergeFinally): Don't call
16138 `branching.CheckOutParameters()' here, this is called in
16140 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
16141 when adding the `finally' vector.
16143 2003-12-13 Martin Baulig <martin@ximian.com>
16146 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
16147 actually work and also fix #48962.
16149 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
16151 * decl.cs: Do not check System.Object for nested types,
16152 since we know it does not have any. Big bang for buck:
16155 Run 1: 8.35 seconds
16156 Run 2: 8.32 seconds
16157 corlib: 17.99 seconds
16159 Run 1: 8.17 seconds
16160 Run 2: 8.17 seconds
16161 corlib: 17.39 seconds
16163 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
16165 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
16166 time we are returning 0 members, so we save alot here.
16168 2003-12-11 Martin Baulig <martin@ximian.com>
16170 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
16171 `MergeChild()', also just take the `FlowBranching' as argument;
16172 call Merge() on it and return the result.
16173 (FlowBranching.Merge): We don't need to do anything if we just
16176 2003-12-11 Martin Baulig <martin@ximian.com>
16178 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
16179 them in an `ArrayList' to reduce memory usage. Thanks to Ben
16180 Maurer for this idea.
16182 2003-12-11 Martin Baulig <martin@ximian.com>
16184 * flowanalysis.cs (MergeResult): This class is now gone; we now
16185 use the `UsageVector' for this. The reason for this is that if a
16186 branching just has one sibling, we don't need to "merge" them at
16187 all - that's the next step to do.
16188 (FlowBranching.Merge): We now return a `UsageVector' instead of a
16191 2003-12-11 Martin Baulig <martin@ximian.com>
16193 Reworked flow analyis and made it more precise and bug-free. The
16194 most important change is that we're now using a special `Reachability'
16195 class instead of having "magic" meanings of `FlowReturns'. I'll
16196 do some more cleanups and optimizations and also add some more
16197 documentation this week.
16199 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
16200 largely reworked this class.
16201 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
16202 the new `Reachability' class instead of having "magic" values here.
16203 (FlowBranching): We're now using an instance of `Reachability'
16204 instead of having separate `Returns', `Breaks' etc. fields.
16206 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
16207 based on flow analysis; ignore the return value of block.Emit ().
16209 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
16211 * driver.cs typemanager.cs: Find the mono extensions to corlib even
16212 if they are private.
16214 2003-12-09 Martin Baulig <martin@ximian.com>
16216 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
16217 call them directly on the UsageVector.
16219 2003-12-09 Martin Baulig <martin@ximian.com>
16221 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
16222 Changed return type from `FlowReturns' to `Reachability'.
16224 2003-12-09 Martin Baulig <martin@ximian.com>
16226 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
16227 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
16228 `Reachable' fields with a single `Reachability' one.
16230 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16232 * class.cs (FindMembers): Remove foreach's.
16237 Run 1: 8.74 seconds
16238 Run 2: 8.71 seconds
16241 Run 1: 8.64 seconds
16242 Run 2: 8.58 seconds
16245 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16250 This patch does a few things:
16251 1. EmptyStatement is now a singleton, so it is never reallocated.
16252 2. All blah is EmptyStatement constructs have been changed to
16253 blah == EmptyStatement.Value, which is much faster and valid
16254 now that EmptyStatement is a singleton.
16255 3. When resolving a block, rather than allocating a new array for
16256 the non-empty statements, empty statements are replaced with
16257 EmptyStatement.Value
16258 4. Some recursive functions have been made non-recursive.
16259 Mainly the performance impact is from (3), however (1) and (2) are needed for
16260 this to work. (4) does not make a big difference in normal situations, however
16261 it makes the profile look saner.
16266 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16267 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16268 Total memory allocated: 56397 KB
16271 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
16272 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
16273 Total memory allocated: 55666 KB
16275 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16277 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
16278 than the hashtable in a hashtable version
16280 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
16281 we always end up concating a string. This results in a huge perf
16282 loss, because many strings have to be tracked by the GC. In this
16283 patch, we first use a hashtable that works with two keys, so that
16284 the strings do not need to be concat'ed.
16288 Run 1: 8.74 seconds
16289 Run 2: 8.71 seconds
16292 Run 1: 8.65 seconds
16293 Run 2: 8.56 seconds
16295 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16297 * Makefile: Add a new target `do-time' that does a quick and simple
16298 profile, leaving easy to parse output.
16300 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
16302 * codegen.cs (Init): Create the dynamic assembly with
16303 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
16305 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
16307 * support.cs: Make the PtrHashtable use only one
16308 instance of its comparer.
16310 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
16312 * typemanager.cs: Fix lookup of GetNamespaces.
16314 2003-11-29 Miguel de Icaza <miguel@ximian.com>
16316 * expression.cs: Removed redundant line.
16318 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
16319 ArrayLists, use for loops with bounds.
16321 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
16324 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
16325 arraylists, use for loop with bounds.
16327 The above three changes give us a 0.071 second performance
16328 improvement out of 3.294 seconds down to 3.223. On my machine
16329 the above changes reduced the memory usage by 1,387 KB during
16330 compiler bootstrap.
16332 * cs-parser.jay (QualifiedIdentifier): New class used to represent
16333 QualifiedIdentifiers. Before we created a new string through
16334 concatenation, and mostly later on, the result would be
16335 manipulated by DecomposeQI through string manipulation.
16337 This reduced the compiler memory usage for bootstrapping from
16338 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
16339 compile times in 0.05 seconds.
16341 2003-11-28 Dick Porter <dick@ximian.com>
16343 * support.cs: Do string compares with the Invariant culture.
16351 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
16352 the comparison is done with the Invariant culture.
16354 2003-11-27 Miguel de Icaza <miguel@ximian.com>
16356 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
16357 GetEnumerator method.
16359 (ProbeCollectionType): Iterate starting at the most specific type
16360 upwards looking for a GetEnumerator
16362 * expression.cs: Shift count can be up to 31 for int/uint and 63
16365 2003-11-26 Miguel de Icaza <miguel@ximian.com>
16367 * statement.cs (Block.LookupLabel): Also look for the label on the
16368 children blocks. Use a hash table to keep track of visited
16371 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
16372 we actually did transform the other operand, otherwise fall back
16373 to the common codepath that casts to long.
16375 * cs-tokenizer.cs: Use the same code pattern as the int case.
16376 Maybe I should do the parsing myself, and avoid depending on the
16377 Parse routines to get this done.
16379 2003-11-25 Miguel de Icaza <miguel@ximian.com>
16381 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16382 which fixes bug 51347. This time test it.
16384 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
16385 attributes for example can not tell the difference between these.
16386 The difference was only a syntax feature of the language.
16388 * attribute.cs: Apply attributes to delegates.
16390 * delegate.cs: Call the apply attributes method.
16392 2003-11-24 Miguel de Icaza <miguel@ximian.com>
16394 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
16395 comparing 0 vs Byte.MinValue, not the value
16397 (ImplicitConversionRequired): When reporting a conversion error,
16398 use error 31 to print out the constant error instead of the
16401 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16402 which fixes bug 51347.
16404 2003-11-22 Miguel de Icaza <miguel@ximian.com>
16406 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
16407 which fixes the -warnaserror command line option.
16409 2003-11-21 Miguel de Icaza <miguel@ximian.com>
16411 * cfold.cs (DoNumericPromotions): During constant folding of
16412 additions on UIntConstant, special case intconstants with
16413 IntConstants like we do on the expression binary operator.
16415 2003-11-12 Miguel de Icaza <miguel@ximian.com>
16417 * convert.cs (ImplicitReferenceConversion): We were missing a case
16418 (System.Enum are not value types or class types, so we need to
16419 classify them separatedly).
16421 * driver.cs: We do not support error 2007.
16423 2003-11-12 Jackson Harper <jackson@ximian.com>
16425 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
16426 system directory. Also use the full file name so users can
16427 libraries names mscorlib-o-tron.dll in a non system dir.
16429 2003-11-10 Martin Baulig <martin@ximian.com>
16431 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
16432 (TypeManager.InitCoreTypes): Initialize them here, but instead of
16433 calling `ResolveType()' on them, directly assign their `Type'.
16435 2003-11-08 Martin Baulig <martin@ximian.com>
16437 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
16438 return value and the `out parent' parameter.
16439 (TypeContainer.DefineType): Moved the CS0644 check into
16440 GetClassBases(). Don't pass the interface types to the
16441 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
16442 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
16444 * ecore.cs (TypeExpr.IsAttribute): New property.
16445 (TypeExpr.GetInterfaces): New method.
16447 * interface.cs (Interface.GetInterfaceTypeByName): Return a
16448 TypeExpr instead of a Type.
16449 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
16450 (Interface.DefineType): Don't pass the interface types to the
16451 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
16452 them later and then call `TypeBulider.AddInterfaceImplementation()'.
16454 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
16455 instead of a `Type[]'.
16456 (TypeManager.RegisterBuilder): Likewise.
16457 (TypeManager.AddUserInterface): Likewise.
16458 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
16459 `Type[]' and also return a `TypeExpr[]'.
16460 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
16462 2003-11-08 Martin Baulig <martin@ximian.com>
16464 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
16467 2003-11-08 Martin Baulig <martin@ximian.com>
16469 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
16470 TypeManager.ResolveExpressionTypes().
16472 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
16473 instead of an Expression.
16474 (TypeExpr): This is now an abstract base class for `TypeExpression'.
16475 (TypeExpression): New public class; formerly known as `TypeExpr'.
16477 * expression.cs (ComposedCast): Derive from TypeExpr.
16479 * typemanager.cs (TypeManager.system_*_expr): These are now
16480 TypExpr's instead of Expression's.
16481 (TypeManager.ResolveExpressionTypes): New public static function;
16482 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
16485 2003-11-06 Miguel de Icaza <miguel@ximian.com>
16487 * expression.cs (New.DoResolve): Do not dereference value that
16488 might be a null return.
16490 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
16491 sure that the constant value has the right type. Fixes an
16492 unreported bug, similar to 50425.
16494 * const.cs (Const.LookupConstantValue): Call
16495 ImplicitStandardConversionExists before doing a conversion to
16496 avoid havng the TypeManager.ChangeType do conversions.
16498 Reduced the number of casts used
16500 (Const.ChangeType): New routine to enable reuse of the constant
16501 type changing code from statement.
16503 * typemanager.cs (ChangeType): Move common initialization to
16504 static global variables.
16508 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
16509 every value type to go through, even if it was void. Fix that.
16511 * cs-tokenizer.cs: Use is_identifier_start_character on the start
16512 character of the define, and the is_identifier_part_character for
16513 the rest of the string.
16515 2003-11-05 Miguel de Icaza <miguel@ximian.com>
16517 * expression.cs (UnaryMutator.EmitCode): When I updated
16518 LocalVariableReference.DoResolve, I overdid it, and dropped an
16519 optimization done on local variable references.
16521 2003-11-04 Miguel de Icaza <miguel@ximian.com>
16523 * ecore.cs: Convert the return from Ldlen into an int.
16525 2003-10-20 Miguel de Icaza <miguel@ximian.com>
16527 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
16528 the accessibility, this is a special case for toplevel non-public
16529 classes (internal for instance).
16531 2003-10-20 Nick Drochak <ndrochak@gol.com>
16533 * ecore.cs: Fix typo and build. Needed another right paren.
16535 2003-10-19 Miguel de Icaza <miguel@ximian.com>
16537 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
16538 `internal' case regular and protected, but not allowing protected
16539 to be evaluated later. Bug 49840
16541 2003-10-15 Miguel de Icaza <miguel@ximian.com>
16543 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
16544 to kb.Nlast, and not the kb.nFirst to isolate the switch
16547 Extract the underlying type, so enumerations of long/ulong are
16548 treated like long/ulong.
16550 2003-10-14 Miguel de Icaza <miguel@ximian.com>
16552 * expression.cs (New): Overload the meaning of RequestedType to
16553 track the possible creation of the NewDelegate type, since
16554 DoResolve is invoked more than once for new constructors on field
16557 See bugs: #48800 and #37014
16559 * cs-parser.jay (declare_local_constants): Take an arraylist
16560 instead of a single constant.
16562 (local_constant_declaration): It should take a
16563 constant_declarators, not a constant_declarator. Fixes 49487
16565 * convert.cs: Fix error report.
16567 2003-10-13 Jackson Harper <jackson@ximian.com>
16569 * typemanager.cs (TypeToCoreType): Add float and double this fixes
16572 2003-10-09 Martin Baulig <martin@ximian.com>
16574 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
16576 (MethodCore.DoDefineParameters): Removed the TypeContainer
16577 argument; use the DeclSpace which was passed to the .ctor instead.
16578 (MethodCore.CheckParameter): Take a DeclSpace instead of a
16579 TypeContainer; we only need a DeclSpace here.
16581 2003-10-09 Martin Baulig <martin@ximian.com>
16583 * class.cs (MethodData): Added additional `DeclSpace ds' argument
16585 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
16586 EmitContext's .ctor.
16588 2003-10-09 Martin Baulig <martin@ximian.com>
16590 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
16591 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
16592 AsAccessible(), moved them as well.
16594 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
16596 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
16598 * cs-parser.jay : Renamed yyName to yyNames related to jay.
16600 2003-10-07 Miguel de Icaza <miguel@ximian.com>
16602 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
16603 generation for >=, as spotted by Paolo, bug 48679.
16604 Patch from David Waite.
16606 * cs-tokenizer.cs: Add handling for #pragma.
16608 * cs-parser.jay: Allow for both yield and yield return in the
16609 syntax. The anti-cobolization of C# fight will go on!
16611 * class.cs (TypeBuilder.DefineType): Catch error condition here
16612 (Parent.DefineType erroring out and returning null).
16614 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16615 coping with enumerations variables, we were mistakenly processing
16616 them as a regular value type instead of built-in types. Fixes the
16619 * typemanager.cs (IsBuiltinOrEnum): New method.
16621 2003-09-30 Miguel de Icaza <miguel@ximian.com>
16623 * cs-parser.jay: Upgrade: yield now needs the return clause.
16625 2003-09-19 Martin Baulig <martin@ximian.com>
16627 * decl.cs (MemberCache.SetupCacheForInterface): Take a
16628 `MemberCache parent' argument. Normally, an interface doesn't
16629 have a parent type except System.Object, but we use this in gmcs
16630 for generic type parameters.
16632 2003-09-18 Martin Baulig <martin@ximian.com>
16634 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
16635 on `type.IsInterface'; don't check whether the type has a parent
16636 to determine whether it's an interface.
16638 2003-09-15 Martin Baulig <martin@ximian.com>
16640 * class.cs (TypeContainer.DefineType): Added an error flag to
16641 avoid reporting duplicate CS0146's ("class definition is
16644 * driver.cs (Driver.MainDriver): Abort if
16645 RootContext.ResolveTree() reported any errors.
16647 2003-09-07 Martin Baulig <martin@ximian.com>
16649 * report.cs (Error, Warning): Added overloaded versions which take
16650 a `params object[] args' and call String.Format().
16652 2003-09-07 Martin Baulig <martin@ximian.com>
16654 * decl.cs (DeclSpace..ctor): Don't call
16655 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
16656 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
16657 (DeclSpace.RecordDecl): New method.
16659 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
16661 2003-09-02 Ravi Pratap <ravi@ximian.com>
16663 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
16664 value attributes to be applied to ParameterBuilders.
16666 * class.cs (MethodCore.LabelParameters): Make static and more
16667 generic so that it can be used from other places - like interface
16668 methods, for instance.
16670 * interface.cs (Interface.Emit): Call LabelParameters before
16671 emitting attributes on the InterfaceMethod.
16673 2003-08-26 Martin Baulig <martin@ximian.com>
16675 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
16676 resolving aliases; fixes #47927.
16678 2003-08-26 Martin Baulig <martin@ximian.com>
16680 * statement.cs (Using.DoResolve): This is internally emitting a
16681 try/finally clause, so we need to set ec.NeedExplicitReturn if we
16682 do not always return. Fixes #47681.
16684 2003-08-26 Martin Baulig <martin@ximian.com>
16686 * decl.cs (MemberCore): Moved WarningNotHiding(),
16687 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
16689 (AdditionResult): Make this nested in DeclSpace.
16690 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
16691 argument; call NamespaceEntry.Define() unless we're nested in a
16694 * namespace.cs (Namespace.DefineName): New public function. This
16695 is called from DeclSpace's .ctor to add
16696 (Namespace.Lookup): Include DeclSpaces in the lookup.
16698 * class.cs (Operator): Derive from MemberBase, not MemberCore.
16700 * const.cs (Const): Derive from MemberBase, not MemberCore.
16702 2003-08-25 Martin Baulig <martin@ximian.com>
16704 * convert.cs (Convert.ExplicitReferenceConversion): When
16705 converting from an interface type to a class, unbox if the target
16706 type is a struct type. Fixes #47822.
16708 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16710 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
16713 2003-08-22 Martin Baulig <martin@ximian.com>
16715 * class.cs (TypeManager.DefineType): When defining a nested type,
16716 call DefineType() on our parent; fixes #47801.
16718 2003-08-22 Martin Baulig <martin@ximian.com>
16720 * class.cs (MethodData.Define): While checking if a method is an
16721 interface implementation, improve the test a bit more to fix #47654.
16723 2003-08-22 Martin Baulig <martin@ximian.com>
16725 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
16726 correctly; fixes #47722.
16728 2003-08-22 Martin Baulig <martin@ximian.com>
16730 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
16731 LocalVariableReference, ensure it's not read-only. Fixes #47536.
16733 * statement.cs (Fixed.DoResolve): Make all variables read-only.
16735 2003-08-22 Martin Baulig <martin@ximian.com>
16737 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
16738 can only be assigned in static constructors. Fixes #47161.
16740 2003-08-22 Martin Baulig <martin@ximian.com>
16742 Rewrote and improved the flow analysis code.
16744 * flowbranching.cs (FlowBranching): Make this class abstract.
16745 (FlowBranching.CreateBranching): New static function to create a
16746 new flow branching.
16747 (FlowBranchingBlock, FlowBranchingException): New classes.
16748 (FlowBranching.UsageVector.Type): New public readonly field.
16749 (FlowBranching.UsageVector.Breaks): Removed the setter.
16750 (FlowBranching.UsageVector.Returns): Removed the setter.
16751 (FlowBranching.UsageVector): Added Break(), Return(),
16752 NeverReachable() and Throw() methods to modify the reachability.
16753 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
16754 done by FlowBranching.Merge().
16755 (FlowBranching.UsageVector.MergeChild): New method; merges the
16756 merge result into the current vector.
16757 (FlowBranching.Merge): New abstract method to merge a branching.
16759 2003-08-12 Martin Baulig <martin@ximian.com>
16761 * expression.cs (Indirection.CacheTemporaries): Create the
16762 LocalTemporary with the pointer type, not its element type.
16764 2003-08-10 Miguel de Icaza <miguel@ximian.com>
16766 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
16767 token was a keyword or not.
16769 Add `error' options where an IDENTIFIER was expected; Provide
16770 CheckToken and CheckIdentifierToken convenience error reporting
16773 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
16775 * decl.cs: Rename `NamespaceEntry Namespace' public field into
16776 NameSpaceEntry NameSpaceEntry.
16778 (LookupInterfaceOrClass): Avoid creating a full qualified name
16779 from namespace and name: avoid doing lookups when we know the
16780 namespace is non-existant. Use new Tree.LookupByNamespace which
16781 looks up DeclSpaces based on their namespace, name pair.
16783 * driver.cs: Provide a new `parser verbose' to display the
16784 exception thrown during parsing. This is turned off by default
16785 now, so the output of a failure from mcs is more graceful.
16787 * namespace.cs: Track all the namespaces defined in a hashtable
16790 (IsNamespace): New method
16792 2003-08-09 Miguel de Icaza <miguel@ximian.com>
16794 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
16795 we know that we need to concatenate (full typename can never be
16800 * statement.cs: Use a bitfield; Do not initialize to null things
16801 which are done by the constructor by default.
16803 * cs-parser.jay: bug fix, parameter was 4, not 3.
16805 * expression.cs: Just use the property;
16807 * statement.cs: No need for GetVariableInfo method.
16809 2003-08-08 Martin Baulig <martin@ximian.com>
16811 * flowanalysis.cs (FlowReturns): This is now nested in the
16812 `FlowBranching' class.
16813 (MyBitVector): Moved this here from statement.cs.
16814 (FlowBranching.SiblingType): New enum type.
16815 (FlowBranching.CreateSibling): Added `SiblingType' argument.
16817 2003-08-07 Martin Baulig <martin@ximian.com>
16819 * flowanalysis.cs (FlowBranchingType): This is now nested in the
16820 `FlowBranching' class and called `BranchingType'.
16822 2003-08-07 Martin Baulig <martin@ximian.com>
16824 * flowanalysis.cs: Moved all the control flow analysis code into
16827 2003-08-07 Martin Baulig <martin@ximian.com>
16829 * assign.cs (Assign.DoResolve): `target' must either be an
16830 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
16833 2003-08-07 Miguel de Icaza <miguel@ximian.com>
16835 * expression.cs (BinaryMethod): This kind of expression is created by the
16836 Binary class if it determines that the operator has to be handled
16839 (BinaryDelegate): This kind of expression is created if we are
16840 dealing with a + or - operator on delegates.
16842 (Binary): remove method, argumetns, and DelegateOperator: when
16843 dealing with methods,
16845 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
16847 * statement.cs (Block): use bitfields for the three extra booleans
16848 we had in use. Remove unused topblock parameter.
16850 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
16852 * assign.cs: Drop extra unneeded tests.
16854 2003-08-06 Miguel de Icaza <miguel@ximian.com>
16856 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
16858 * statement.cs (Foreach): Use VariableStorage instead of
16861 * codegen.cs (VariableStorage): New class used by clients that
16862 require a variable stored: locals or fields for variables that
16863 need to live across yield.
16865 Maybe provide a convenience api for EmitThis+EmitLoad?
16867 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
16870 2003-08-05 Miguel de Icaza <miguel@ximian.com>
16872 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
16873 RemapParameterLValue): New methods that are used to turn a
16874 precomputed FieldInfo into an expression like this:
16878 The idea is to use this instead of making LocalVariableReference
16879 have more than one meaning.
16881 * cs-parser.jay: Add error production to BASE.
16883 * ecore.cs: Deal with TypeManager.GetField returning null, which
16884 is now a valid return value.
16886 (FieldExprNoAddress): New expression for Fields whose address can
16889 * expression.cs (LocalVariableReference): During the resolve
16890 phases, create new expressions if we are in a remapping context.
16891 Remove code that dealt with remapping here.
16893 (ParameterReference): same.
16895 (ProxyInstance): New expression, like the `This' expression, but
16896 it is born fully resolved. We know what we are doing, so remove
16897 the errors that are targeted to user-provided uses of `this'.
16899 * statement.cs (Foreach): our variable is now stored as an
16900 Expression; During resolution, follow the protocol, dont just
16901 assume it will return this.
16903 2003-08-06 Martin Baulig <martin@ximian.com>
16905 * support.cs (SeekableStreamReader.cs): New public class.
16907 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
16908 SeekableStreamReader instead of the normal StreamReader.
16910 2003-08-04 Martin Baulig <martin@ximian.com>
16912 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
16913 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
16914 deambiguate casts and delegate invocations.
16915 (parenthesized_expression): Use the new tokens to ensure this is
16916 not a cast of method invocation.
16918 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
16919 when reading a `)' and Deambiguate_CloseParens () was previously
16922 * expression.cs (ParenthesizedExpression): New class. This is
16923 just used for the CS0075 test.
16924 (Binary.DoResolve): Check for CS0075.
16926 2003-07-29 Ravi Pratap <ravi@ximian.com>
16928 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
16929 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
16930 reference comparison.
16932 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
16933 examine the ReturnType for equality - this is necessary in the
16934 cases of implicit and explicit operators whose signature also
16935 includes the return type.
16937 2003-07-26 Miguel de Icaza <miguel@ximian.com>
16939 * namespace.cs: Cache the result of the namespace computation,
16940 instead of computing it every time.
16942 2003-07-24 Miguel de Icaza <miguel@ximian.com>
16944 * decl.cs: Use a global arraylist that we reuse over invocations
16945 to avoid excesive memory consumption. Reduces memory usage on an
16946 mcs compile by one meg (45 average).
16948 * typemanager.cs (LookupTypeReflection): In .NET pointers are
16949 private, work around that.
16951 2003-07-23 Miguel de Icaza <miguel@ximian.com>
16953 * literal.cs (IntLiteral): Define Zero and One static literals.
16955 * cs-parser.jay (integer_literal): use static literals to reduce
16956 memory usage for the most used literals (0, 1 and -1). 211kb
16957 reduced in memory usage.
16959 Replace all calls to `new ArrayList' with `new
16960 ArrayList(4)' which is a good average number for most allocations,
16961 and also requires only 16 bytes of memory for its buffer by
16964 This reduced MCS memory usage in seven megabytes for the RSS after
16967 2003-07-28 Ravi Pratap <ravi@ximian.com>
16969 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
16970 handle params methods the correct way by forming only one
16971 applicable set with params and normal methods in them. Earlier we
16972 were looking at params methods only if we found no normal methods
16973 which was not the correct thing to do.
16975 (Invocation.BetterFunction): Take separate arguments indicating
16976 when candidate and the best method are params methods in their
16979 This fixes bugs #43367 and #46199.
16981 * attribute.cs: Documentation updates.
16983 (CheckAttribute): Rename to CheckAttributeTarget.
16984 (GetValidPlaces): Rename to GetValidTargets.
16986 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
16987 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
16991 2003-07-28 Martin Baulig <martin@ximian.com>
16993 * class.cs (TypeContainer.DefineMembers): Use the base type's full
16994 name when looking up the base class of a nested class. Fixes #46977.
16996 2003-07-26 Martin Baulig <martin@ximian.com>
16998 * expression.cs (Indexers.Indexer): New nested struct; contains
16999 getter, setter and the indexer's type.
17000 (Indexers.Properties): This is now an ArrayList of
17001 Indexers.Indexer's.
17002 (IndexerAccess.DoResolveLValue): Correctly set the type if the
17003 indexer doesn't have any getters.
17005 * assign.cs (Assign.DoResolve): Also do the implicit conversions
17006 for embedded property and indexer assignments.
17008 2003-07-26 Martin Baulig <martin@ximian.com>
17010 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
17011 preprocessor directive is not the first non-whitespace character
17014 2003-07-26 Martin Baulig <martin@ximian.com>
17016 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
17017 namespace parsing, follow the spec more closely.
17019 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
17020 NamespaceEntry.Lookup().
17022 2003-07-25 Martin Baulig <martin@ximian.com>
17024 * MethodCore.cs (OverridesSomething): New public field; it's set
17025 from TypeContainer.DefineMembers if this method overrides
17026 something (which doesn't need to be a method). Fix #39462.
17028 2003-07-25 Ravi Pratap <ravi@ximian.com>
17030 * typemanager.cs (GetMembers): Ensure that the list of members is
17031 reversed. This keeps things in sync.
17033 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
17034 find an AttributeUsage attribute.
17036 * expression.cs (Invocation.OverloadResolve): Perform the check
17037 which disallows Invoke to be directly called on a Delegate.
17039 (Error_InvokeOnDelegate): Report error cs1533.
17041 2003-07-25 Martin Baulig <martin@ximian.com>
17043 * expression.cs (Indexers.GetIndexersForType): Only look in the
17044 interface hierarchy if the requested type is already an
17045 interface. Fixes #46788 while keeping #46502 fixed.
17047 2003-07-25 Martin Baulig <martin@ximian.com>
17049 * class.cs (TypeContainer.DefineMembers): Check whether all
17050 readonly fields have been assigned and report warning CS0649 if
17053 * statement.cs (LocalInfo.IsFixed): Always return true if this is
17056 2003-07-24 Ravi Pratap <ravi@ximian.com>
17058 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
17059 returned from GetMethods to make things consistent with the
17060 assumptions MCS makes about ordering of methods.
17062 This should comprehensively fix bug #45127 and it does :-)
17064 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
17065 ordering is actually reverse.
17067 * Clean up some debug messages I left lying around.
17069 * interface.cs (Populate*): Get rid of code which emits attributes
17070 since the stage in which we emit attributes is the 'Emit' stage,
17071 not the define stage.
17073 (Emit): Move attribute emission for interface members here.
17075 2003-07-22 Ravi Pratap <ravi@ximian.com>
17077 * expression.cs (Invocation.OverloadResolve): Follow the spec more
17078 closely: we eliminate methods in base types when we have an
17079 applicable method in a top-level type.
17081 Please see section 14.5.5.1 for an exact description of what goes
17084 This fixes bug #45127 and a host of other related to corlib compilation.
17086 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
17087 array is the method corresponding to the top-level type (this is
17088 because of the changes made to icall.c) so we change this
17091 (MethodGroupExpr.Name): This too.
17093 * typemanager.cs (GetElementType): New method which does the right
17094 thing when compiling corlib.
17096 * everywhere: Make use of the above in the relevant places.
17098 2003-07-22 Martin Baulig <martin@ximian.com>
17100 * cs-parser.jay (invocation_expression): Moved
17101 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
17102 `cast_expression', but create a InvocationOrCast which later
17103 resolves to either an Invocation or a Cast.
17105 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
17106 method; call this before EmitStatement() to make sure that this
17107 expression can be used as a statement.
17109 * expression.cs (InvocationOrCast): New class; resolves to either
17110 an Invocation or a Cast.
17112 * statement.cs (StatementExpression): Call ResolveStatement() on
17113 the ExpressionStatement before emitting it.
17115 2003-07-21 Martin Baulig <martin@ximian.com>
17117 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
17118 `ref' and `out' attributes match; fixes #46220.
17119 (MemberAccess.ResolveMemberAccess): You can't reference a type
17120 through an expression; fixes #33180.
17121 (Indexers.GetIndexersForType): Don't return the indexers from
17122 interfaces the class implements; fixes #46502.
17124 2003-07-21 Martin Baulig <martin@ximian.com>
17126 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
17127 CS0661 checks; fixes bug #30442.
17129 2003-07-21 Martin Baulig <martin@ximian.com>
17131 * decl.cs (AdditionResult): Added `Error'.
17133 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
17135 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
17136 makes cs0031.cs actually work.
17138 2003-07-20 Martin Baulig <martin@ximian.com>
17140 * namespace.cs: Fixed that bug which caused a crash when compiling
17141 the debugger's GUI.
17143 2003-07-20 Miguel de Icaza <miguel@ximian.com>
17145 * typemanager.cs (LookupTypeReflection): Never expose types which
17146 are NotPublic, NestedPrivate, NestedAssembly, or
17147 NestedFamANDAssem. We used to return these, and later do a check
17148 that would report a meaningful error, but the problem is that we
17149 would not get the real match, if there was a name override.
17151 2003-07-18 Miguel de Icaza <miguel@ximian.com>
17153 * namespace.cs (Namespace, Name): Do not compute the namespace
17154 name dynamically, compute it in the constructor. This reduced
17155 memory usage by 1697 KB.
17157 * driver.cs: Use --pause to pause at the end.
17159 2003-07-17 Peter Williams <peter@newton.cx>
17161 * Makefile: Change the name of the test target so that it doesn't
17162 conflict with the recursive test target.
17164 2003-07-17 Miguel de Icaza <miguel@ximian.com>
17166 * expression.cs (LocalVariableReference.Emit, EmitAssign,
17167 AddressOf): Do not use EmitThis, that was wrong, use the actual
17170 2003-07-15 Miguel de Icaza <miguel@ximian.com>
17172 * class.cs (MethodData.Define): While checking if a method is an
17173 interface implementation, improve the test: If we are not public
17174 (use new test here: use the computed MethodAttributes directly,
17175 instead of the parsed modifier flags) check if the `implementing'
17176 method comes from an interface or not.
17178 * pending.cs (VerifyPendingMethods): Slightly better error
17181 * makefile: add test target that does the mcs bootstrap.
17183 2003-07-16 Ravi Pratap <ravi@ximian.com>
17185 * interface.cs (Define): Do nothing here since there are no
17186 members to populate etc. Move the attribute emission out of here
17187 since this was just totally the wrong place to put it. Attribute
17188 application happens during the 'Emit' phase, not in the 'Define'
17191 (Emit): Add this method and move the attribute emission here
17193 * rootcontext.cs (EmitCode): Call the Emit method on interface
17196 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17198 * expression.cs (OverloadResolve): Report error only if Location
17199 is not 'Null' which means that there was a probe going on.
17201 2003-07-14 Martin Baulig <martin@ximian.com>
17203 * expression.cs (ConditionalLogicalOperator): New public class to
17204 implement user defined conditional logical operators.
17205 This is section 14.11.2 in the spec and bug #40505.
17207 2003-07-14 Martin Baulig <martin@ximian.com>
17209 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
17211 2003-07-14 Martin Baulig <martin@ximian.com>
17213 * codegen.cs (EmitContext.InFixedInitializer): New public field.
17215 * ecore.cs (IVariable.VerifyFixed): New interface method.
17217 * expression.cs (Unary.ResolveOperator): When resolving the `&'
17218 operator, check whether the variable is actually fixed. Fixes bug
17219 #36055. Set a variable definitely assigned when taking its
17220 address as required by the spec.
17222 * statement.cs (LocalInfo.IsFixed): New field.
17223 (LocalInfo.MakePinned): Set `IsFixed' to true.
17225 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17227 * attribute.cs (Attribute.Resolve): While doing a Member lookup
17228 for .ctors, ensure that we only ask for members declared in the
17229 attribute type (BindingFlags.DeclaredOnly).
17233 * expression.cs (Error_WrongNumArguments): Report error 1501
17234 correctly the way CSC does.
17236 2003-07-13 Martin Baulig <martin@ximian.com>
17238 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
17239 lookup on the fully qualified name, to make things like "X.X" work
17240 where "X.X" is a fully qualified type name, but we also have a
17241 namespace "X" in the using list. Fixes #41975.
17243 2003-07-13 Martin Baulig <martin@ximian.com>
17245 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
17246 function. If we're a CompoundAssign, we need to create an embedded
17247 CompoundAssign, not an embedded Assign.
17248 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
17251 2003-07-13 Martin Baulig <martin@ximian.com>
17253 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
17254 work to fix bug #46088.
17256 2003-07-13 Ravi Pratap <ravi@ximian.com>
17258 * class.cs (Operator.Emit): Do not emit attributes here - it is
17259 taken care of by the Method class that we delegate too. This takes
17260 care of bug #45876.
17262 2003-07-10 Martin Baulig <martin@ximian.com>
17264 * expression.cs (TypeOfVoid): New class.
17265 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
17267 2003-07-10 Martin Baulig <martin@ximian.com>
17269 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
17272 2003-07-10 Martin Baulig <martin@ximian.com>
17274 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
17275 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
17277 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
17279 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
17281 2003-07-10 Martin Baulig <martin@ximian.com>
17283 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
17284 of decimal. Fixes #42850.
17286 NOTE: I also fixed the created byte blob, but this doesn't work on
17287 the MS runtime and csc never produces any byte blobs for decimal
17290 2003-07-10 Martin Baulig <martin@ximian.com>
17292 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
17293 structs; fixes #32068.
17294 (Block.AddChildVariableNames): Fixed #44302.
17296 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17298 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
17300 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17302 * attribute.cs: And this test is onger needed.
17304 2003-07-08 Martin Baulig <martin@ximian.com>
17306 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
17307 inaccessible types. Fixes #36313.
17309 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
17311 * namespace.cs (NamespaceEntry): Create implicit entries for all
17312 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
17313 implicit entries for N1.N2 and N1.
17315 2003-07-08 Martin Baulig <martin@ximian.com>
17317 Rewrote the handling of namespaces to fix a lot of the issues
17318 wrt. `using' aliases etc.
17320 * namespace.cs (Namespace): Splitted this class into a
17321 per-assembly `Namespace' and a per-file `NamespaceEntry'.
17323 * typemanager.cs (TypeManager.IsNamespace): Removed.
17324 (TypeManager.ComputeNamespaces): Only compute namespaces from
17325 loaded assemblies here, not the namespaces from the assembly we're
17326 currently compiling.
17328 2003-07-08 Martin Baulig <martin@ximian.com>
17330 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
17332 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17334 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
17337 I thought about the memory savings here, but LookupTypeReflection
17338 is used under already very constrained scenarios. Compiling
17339 corlib or mcs only exposes one hit, so it would not really reduce
17340 any memory consumption.
17342 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17344 * typemanager.cs: fixes bug #45889 by only adding public types from
17345 other assemblies to the list of known types.
17347 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17349 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
17350 on the type we resolved.
17352 2003-07-05 Martin Baulig <martin@ximian.com>
17354 * pending.cs (PendingImplementation.ParentImplements): Don't
17355 create the proxy if the parent is abstract.
17357 * class.cs (TypeContainer.DefineIndexers): Process explicit
17358 interface implementations first. Fixes #37714.
17360 2003-07-04 Miguel de Icaza <miguel@ximian.com>
17362 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
17363 defined recursively; but since we modify the input parameters
17364 (left is set to `this' temporarily), we reset this value if the
17365 left_is_explicit is false, which gives the original semantics to
17368 * literal.cs (NullPointer): new class used to represent a null
17369 literal in a pointer context.
17371 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
17372 type is a pointer, use a NullPointer object instead of a
17373 NullLiteral. Closes 43687
17375 (ExplicitConversion): Convert pointer values using
17376 the conv opcode to the proper type.
17378 * ecore.cs (New): change ValueTypeVariable property into a method,
17379 that returns whether the valuetype is suitable for being used.
17381 * expression.cs (Binary.DoNumericPromotions): Only return if we
17382 the int constant was a valid uint, and we can return both left and
17383 right as uints. If not, we continue processing, to trigger the
17384 type conversion. This fixes 39018.
17386 * statement.cs (Block.EmitMeta): During constant resolution, set
17387 the CurrentBlock property on the emitcontext, so that we resolve
17388 constants propertly.
17390 2003-07-02 Martin Baulig <martin@ximian.com>
17392 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
17393 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
17395 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
17396 than emitting it here.
17398 * statement.cs: Fixed some more flow analysis bugs.
17400 2003-07-02 Martin Baulig <martin@ximian.com>
17402 * class.cs (MethodData.Define): When implementing interface
17403 methods, set Final unless we're Virtual.
17405 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
17406 check work for interface methods.
17408 2003-07-01 Martin Baulig <martin@ximian.com>
17410 * ecore.cs (EmitContext.This): Replaced this property with a
17411 GetThis() method which takes a Location argument. This ensures
17412 that we get the correct error location for a CS0188.
17414 2003-07-01 Miguel de Icaza <miguel@ximian.com>
17416 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
17417 ImplicitStandardConversion.
17419 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
17421 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
17423 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
17426 2003-06-30 Miguel de Icaza <miguel@ximian.com>
17428 * class.cs (Constructor.Define): Turn off initlocals for unsafe
17431 (MethodData.Define): Turn off initlocals for unsafe methods.
17433 2003-06-29 Miguel de Icaza <miguel@ximian.com>
17435 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
17436 complete; Fixes #37521.
17438 * delegate.cs: Use Modifiers.TypeAttr to compute the
17439 TypeAttributes, instead of rolling our own. This makes the flags
17440 correct for the delegates.
17442 2003-06-28 Miguel de Icaza <miguel@ximian.com>
17444 * class.cs (Constructor.Define): Set the private flag for static
17445 constructors as well.
17447 * cs-parser.jay (statement_expression): Set the return value to
17448 null, to avoid a crash when we catch an error.
17450 2003-06-24 Miguel de Icaza <miguel@ximian.com>
17452 * cs-parser.jay: Applied patch from Jackson that adds support for
17453 extern and unsafe modifiers to destructor declarations.
17455 * expression.cs: Report error 21 if the user is trying to index a
17458 * driver.cs: Add an error message, suggested by the bug report.
17460 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
17461 if we do not have a ": this ()" constructor initializer. Fixes 45149
17463 2003-06-14 Miguel de Icaza <miguel@ximian.com>
17465 * namespace.cs: Add some information to reduce FAQs.
17467 2003-06-13 Miguel de Icaza <miguel@ximian.com>
17469 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
17470 underlying enumeration types. Fixes #43915.
17472 * expression.cs: Treat ushort/short as legal values to be used in
17473 bitwise operations.
17475 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
17477 * delegate.cs: transfer custom attributes for paramenters from
17478 the delegate declaration to Invoke and BeginInvoke.
17480 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
17482 * attribute.cs: handle custom marshalers and emit marshal info
17485 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
17487 * makefile.gnu: Added anonymous.cs to the compiler sources.
17489 2003-05-28 Miguel de Icaza <miguel@ximian.com>
17491 * iterators.cs: Change the name of the proxy class to include two
17494 * cs-parser.jay: Update grammar to include anonymous methods.
17496 * anonymous.cs: new file.
17498 2003-05-27 Miguel de Icaza <miguel@ximian.com>
17500 * class.cs (Field.Define): Add missing test for pointers and
17503 2003-05-27 Ravi Pratap <ravi@ximian.com>
17505 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
17506 we use the stobj opcode.
17508 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
17509 since it wasn't the correct fix.
17511 It still is puzzling that we are required to use stobj for IntPtr
17512 which seems to be a ValueType.
17514 2003-05-26 Miguel de Icaza <miguel@ximian.com>
17516 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
17517 during regular simple name resolution. Now, the trick is that
17518 instead of returning for processing the simplename, we do a
17519 TypeManager.LookupType (ie, a rooted lookup as opposed to a
17520 contextual lookup type). If a match is found, return that, if
17521 not, return for further composition.
17523 This fixes long-standing 30485.
17525 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
17526 using the address to initialize an object, do an Stobj instead of
17527 using the regular Stelem.
17529 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
17530 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
17531 Because if we are a BaseIndexerAccess that value will be true.
17534 * statement.cs (GotoCase.Resolve): Return after reporting an
17535 error, do not attempt to continue.
17537 * expression.cs (PointerArithmetic.Emit): If our operand is a
17538 long, convert our constants to match the operand before
17539 multiplying. Convert to I type before adding. Fixes 43670.
17541 2003-05-14 Ravi Pratap <ravi@ximian.com>
17543 * enum.cs (ImplicitConversionExists) : Rename to
17544 ImplicitEnumConversionExists to remove ambiguity.
17546 * ecore.cs (NullCast): New type of cast expression class which
17547 basically is very similar to EmptyCast with the difference being
17548 it still is a constant since it is used only to cast a null to
17550 (eg. (string) null)
17552 * convert.cs (ImplicitReferenceConversion): When casting a null
17553 literal, we return a NullCast.
17555 * literal.cs (NullLiteralTyped): Remove - I don't see why this
17556 should be around anymore.
17558 The renaming (reported was slightly wrong). Corrections:
17560 ConvertImplicitStandard -> ImplicitConversionStandard
17561 ConvertExplicitStandard -> ExplicitConversionStandard
17563 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
17564 before passing them in !
17566 * convert.cs (ImplicitConversionStandard): When comparing for
17567 equal expr and target types, ensure that expr is not a
17570 In general, we must not be checking (expr_type ==
17571 target_type) in the top level conversion methods
17572 (ImplicitConversion, ExplicitConversion etc). This checking is
17573 done in the methods that they delegate to.
17575 2003-05-20 Miguel de Icaza <miguel@ximian.com>
17577 * convert.cs: Move Error_CannotConvertType,
17578 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
17579 ImplicitNumericConversion, ImplicitConversionExists,
17580 ImplicitUserConversionExists, StandardConversionExists,
17581 FindMostEncompassedType, FindMostSpecificSource,
17582 FindMostSpecificTarget, ImplicitUserConversion,
17583 ExplicitUserConversion, GetConversionOperators,
17584 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
17585 TryImplicitIntConversion, Error_CannotConvertImplicit,
17586 ConvertImplicitRequired, ConvertNumericExplicit,
17587 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
17588 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
17591 Perform the following renames:
17593 StandardConversionExists -> ImplicitStandardConversionExists
17594 ConvertImplicit -> ImplicitConversion
17595 ConvertImplicitStandard -> ImplicitStandardConversion
17596 TryImplicitIntConversion -> ImplicitIntConversion
17597 ConvertImplicitRequired -> ImplicitConversionRequired
17598 ConvertNumericExplicit -> ExplicitNumericConversion
17599 ConvertReferenceExplicit -> ExplicitReferenceConversion
17600 ConvertExplicit -> ExplicitConversion
17601 ConvertExplicitStandard -> ExplicitStandardConversion
17603 2003-05-19 Martin Baulig <martin@ximian.com>
17605 * statement.cs (TypeInfo.StructInfo): Made this type protected.
17606 (TypeInfo): Added support for structs having structs as fields.
17608 * ecore.cs (FieldExpr): Implement IVariable.
17609 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
17610 VariableInfo for the field.
17612 2003-05-18 Martin Baulig <martin@ximian.com>
17614 * expression.cs (This.DoResolve): Report a CS0027 if we're
17615 emitting a field initializer.
17617 2003-05-18 Martin Baulig <martin@ximian.com>
17619 * expression.cs (This.ResolveBase): New public function.
17620 (This.DoResolve): Check for CS0188.
17622 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
17625 * ecore.cs (MethodGroupExpr.DoResolve): Set the
17626 `instance_expression' to null if we don't have any non-static
17629 2003-05-18 Martin Baulig <martin@ximian.com>
17631 Reworked the way how local variables and parameters are handled by
17632 the flow analysis code.
17634 * statement.cs (TypeInfo, VariableMap): New public classes.
17635 (VariableInfo): New public class. This is now responsible for
17636 checking whether a variable has been assigned. It is used for
17637 parameters and local variables.
17638 (Block.EmitMeta): Take the InternalParameters as argument; compute
17639 the layout of the flow vectors here.
17640 (Block.LocalMap, Block.ParameterMap): New public properties.
17641 (FlowBranching): The .ctor doesn't get the InternalParameters
17642 anymore since Block.EmitMeta() now computes the layout of the flow
17644 (MyStructInfo): This class is now known as `StructInfo' and nested
17645 in `TypeInfo'; we don't access this directly anymore.
17647 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
17648 property and removed IsAssigned(), IsFieldAssigned(),
17649 SetAssigned() and SetFieldAssigned(); we now call them on the
17650 VariableInfo so we don't need to duplicate this code everywhere.
17652 * expression.cs (ParameterReference): Added `Block block' argument
17654 (LocalVariableReference, ParameterReference, This): The new
17655 VariableInfo class is now responsible for all the definite
17658 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
17659 IsParameterAssigned, SetParameterAssigned): Removed.
17661 2003-05-18 Martin Baulig <martin@ximian.com>
17663 * typemanager.cs (InitCoreTypes): Try calling
17664 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
17665 the 3-args-version. Corlib now also needs our `void_type'.
17666 (GetMethod): Added overloaded version which takes an optional
17667 `bool report_errors' to allow lookups of optional methods.
17669 2003-05-12 Martin Baulig <martin@ximian.com>
17671 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
17672 only used for locals and not for parameters.
17674 2003-05-12 Miguel de Icaza <miguel@ximian.com>
17676 * support.cs (InternalParameters.ParameterType): Return the
17677 ExternalType of the parameter.
17679 * parameter.cs (Parameter.ExternalType): drop the two arguments,
17682 2003-05-11 Miguel de Icaza <miguel@ximian.com>
17684 * class.cs (MethodData.Define): Do not set the `newslot' on
17685 interface members, if they are also flagged as "override".
17687 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
17688 better code for ++i and i++. This only works for static fields
17689 and local variables.
17691 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
17692 want to pull the DeclSpace out of the builder_to_declspace instead
17693 of the TypeBuilder (like in TypeContainer.FindMembers).
17695 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
17696 instead of LookupTypeContainer. Fixes the crash on .NET for
17697 looking up interface members.
17699 * const.cs: Create our own emit context during the Definition
17700 stage, so that constants are evaluated in the proper context, when
17701 a recursive definition happens.
17703 2003-05-11 Martin Baulig <martin@ximian.com>
17705 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
17706 new block for a switch section.
17707 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
17708 the adding/lookup in the switch block. Fixes #39828.
17710 2003-05-09 Miguel de Icaza <miguel@ximian.com>
17712 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
17713 functionality: I needed to convert the data after I had performed
17714 the add/sub operation into the operands type size.
17716 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
17717 pass the type for the box operation, otherwise the resulting
17718 object would have been of type object.
17720 (BoxedCast): Add constructor to specify the type to box as.
17722 2003-05-07 Miguel de Icaza <miguel@ximian.com>
17724 * iterators.cs: I was reusing the `count' variable inadvertently,
17725 take steps to not allow this to happen.
17727 2003-05-06 Miguel de Icaza <miguel@ximian.com>
17729 * attribute.cs (Attribute.Resolve): Params attributes are encoded
17730 by creating an array at the point where the params starts and
17731 putting all those arguments there, then adjusting the size of the
17734 2003-05-05 Miguel de Icaza <miguel@ximian.com>
17736 * expression.cs (New.AddressOf): Implement interface
17737 IMemoryLocation. This is used when the `new' operator is used in
17738 the context of an invocation to a method on a value type.
17740 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
17743 * namespace.cs: Also check the using aliases here.
17745 * driver.cs: Move the test for using validity after the types have
17746 been entered, so we do a single pass that also includes the using
17749 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
17750 in the regular case. CreateSiblingForFinally is doing extra
17753 * attribute.cs (GetAttributeArgumentExpression): Store the result
17754 on an out value, and use the return value to indicate failure
17755 instead of using null (which is a valid return for Constant.GetValue).
17757 * statement.cs: Perform the analysis flow for the increment
17758 portion after the statement, because this will be the real flow of
17759 execution. Fixes #42385
17761 * codegen.cs (EmitContext.EmitArgument,
17762 EmitContext.EmitStoreArgument): New helper functions when the
17763 RemapToProxy flag is set.
17765 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
17768 Add support for remapping parameters.
17770 * iterators.cs: Propagate parameter values; Store parameter
17771 values in the proxy classes.
17773 2003-05-04 Miguel de Icaza <miguel@ximian.com>
17775 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
17776 need a proxy reference; I do not know what I was thinking
17778 * cs-parser.jay (constructor_initializer): catch another error,
17779 and display nice message.
17781 (field_declaration): catch void field declaration
17782 to flag a better error.
17784 * class.cs (MemberBase.CheckBase): Report an error instead of a
17785 warning if a new protected member is declared in a struct.
17786 (Field.Define): catch the error of readonly/volatile.
17788 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
17790 (FieldExpr.AddressOf): ditto. Catch error where the address of a
17791 volatile variable is taken
17793 2003-05-02 Miguel de Icaza <miguel@ximian.com>
17795 * statement.cs (Fixed.Resolve): Report an error if we are not in
17798 2003-05-01 Miguel de Icaza <miguel@ximian.com>
17800 * typemanager.cs: reuse the code that handles type clashes for
17801 delegates and enumerations.
17803 * class.cs (Report28): Always report.
17805 * expression.cs (EncodeAsAttribute): Allow nulls here.
17807 2003-04-28 Miguel de Icaza <miguel@ximian.com>
17809 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
17810 the functionality for testing whether an expression is valid for
17811 an attribute here. Also handle the case of arrays of elements
17814 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
17815 encoding a linear array into an array of objects that are suitable
17816 to be passed to an CustomAttributeBuilder.
17818 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
17820 * ecore.cs: (FieldExpr): Handle field remapping here.
17822 * iteratators.cs: Pass the instance variable (if the method is an
17823 instance method) to the constructors, so we can access the field
17824 variables on the class.
17826 TODO: Test this with structs. I think the THIS variable on
17827 structs might have to be a pointer, and not a refenrece
17829 2003-04-27 Miguel de Icaza <miguel@ximian.com>
17831 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
17832 local variables to fields in a proxy class.
17834 * iterators.cs (PopulateProxy): Rename our internal fields to
17836 Create a <THIS> field if we are an instance method, so we can
17837 reference our parent container variables.
17838 (MapVariable): Called back from the EmitContext code to enter a
17839 new variable to field mapping into the proxy class (we just create
17843 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
17844 for using the remapped locals to fields.
17846 I placed the code here, because that gives the same semantics to
17847 local variables, and only changes the Emit code.
17849 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
17850 statements inside iterators.
17851 (VariableInfo): Add a FieldBuilder for the cases when we are
17852 remapping local variables to fields in a proxy class
17854 * ecore.cs (SimpleNameResolve): Avoid testing two times for
17855 current_block != null.
17857 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
17858 not cope with strings, as it has been moved to the
17859 TableSwitchEmit. Fixed bug in switch generation.
17861 * expression.cs (New.DoResolve): Provide more context for the user
17862 when reporting an error.
17864 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
17867 * expression.cs (MemberAccess.DoResolve): When we get a type back,
17868 check the permissions for it. Note than in a type-resolution
17869 context the check was already present in DeclSpace.ResolveType,
17870 but was missing from the MemberAccess.
17872 (ArrayCreation.CheckIndices): warn if the user has
17873 more nested levels of expressions, but there are no more
17874 dimensions specified. Avoids crash on bug 41906.
17876 2003-04-26 Miguel de Icaza <miguel@ximian.com>
17878 * statement.cs (Block): replace Implicit bool, for a generic
17880 New flag: `Unchecked'. This is used during the EmitMeta phase
17881 (which is out-of-line with the regular Resolve/Emit process for a
17882 statement, as this is done ahead of time, but still gets a chance
17883 to call constant resolve).
17885 (Block.Flags): new enum for adding a new flag.
17887 (Block.EmitMeta): track the state of unchecked.
17889 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
17890 to enable constant resolution to work there as well.
17892 2003-04-22 Miguel de Icaza <miguel@ximian.com>
17894 * typemanager.cs (ienumerable_type): Also look up
17895 System.Collections.IEnumerable.
17897 2003-04-21 Miguel de Icaza <miguel@ximian.com>
17899 TODO: Test more than one conditional per method.
17901 * class.cs (Indexer.Define): Report the location where the user is
17902 referencing the unsupported feature.
17904 (MethodData): Overload the use of `conditionals' to
17905 minimize the creation of needless ArrayLists. This saves roughly
17906 212kb on my machine.
17908 (Method): Implement the new IIteratorContainer interface.
17909 (Method.SetYields): Implement the method by setting the ModFlags
17910 to contain METHOD_YIELDS.
17912 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
17913 which just got set to null.
17915 * iterators.cs: New file.
17917 (Yield, YieldBreak): New statements.
17919 * statement.cs (Return.Resolve): Flag an error if we are used in
17920 an iterator method.
17922 * codegen.cs (InIterator): New flag set if the code is being
17923 compiled in an iterator method.
17925 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
17926 internal modifier, and we just use it to avoid adding extra
17927 fields, as this is seldom used.
17929 * cs-parser.jay: Add yield_statement (yield and yield break).
17931 * driver.cs: New flag -v2 to turn on version 2 features.
17933 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
17934 hashtable when v2 is enabled.
17936 2003-04-20 Miguel de Icaza <miguel@ximian.com>
17938 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
17939 there is already a namespace defined with this name.
17941 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
17942 people upgraded their corlibs.
17944 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
17945 always use fully qualified types, no need to use the compiler
17948 (TypeManager.IsNamespace): Use binarysearch.
17950 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
17951 AddDelegate): I did not quite use the new IsValid API properly: I
17952 have to pass the short-name and the fullname. I was passing only
17953 the basename instead of the fullname sometimes.
17955 (TypeContainer.DefineType): call NamespaceClash.
17957 * interface.cs (Interface.DefineType): use NamespaceClash before
17960 * delegate.cs (Delegate.DefineType): use NamespaceClash before
17963 * enum.cs: (Enum.DefineType): use NamespaceClash before
17966 * typemanager.cs (: 3-line patch that gives us some tasty 11%
17967 speed increase. First, use the negative_hits cache when we get a
17968 negative. Second, add the type with its full original name
17969 instead of the new . and + encoded name (reflection uses + to
17970 separate type from a nested type). Use LookupTypeReflection
17971 directly which bypasses the type->name hashtable (that we already
17972 know does not contain the type.
17974 * decl.cs (DeclSpace.ResolveTypeExpr): track the
17975 location/container type.
17977 * driver.cs: When passing utf8, use directly the UTF8Encoding.
17979 2003-04-19 Miguel de Icaza <miguel@ximian.com>
17981 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
17983 * delegate.cs (NewDelegate.Resolve): Test whether an instance
17984 method is being referenced in the method group from a static
17985 context, and report error 120 if so.
17987 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
17990 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
17991 is created, we create the A namespace).
17993 * cs-parser.jay: A namespace also introduces a DeclarationFound.
17996 2003-04-18 Miguel de Icaza <miguel@ximian.com>
17998 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
17999 invocation to ModuleBuilder.GetType with the same values will
18000 return a new type instance, so we need to cache its return
18003 * expression.cs (Binary.ResolveOperator): Only allow the compare
18004 operators on enums if they are of the same type.
18006 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
18007 types of ValueType on their own case. Before we were giving them
18008 the same treatment as objects.
18010 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
18011 fullname. Short name is used to compare against container name.
18012 Fullname is used to check against defined namespace names.
18014 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
18015 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
18017 (Method.CheckBase): Call parent.
18018 (MemberBase.CheckBase): Check for protected members on sealed
18020 (PropertyBase.CheckBase): Call parent.
18021 (Field.Define): Call parent.
18023 * report.cs: Negative error codes are now mapped to 8000 - code,
18024 so that the display is render more nicely.
18026 * typemanager.cs: Do not use try/catch, instead report a regular
18029 (GetPointerType, GetReferenceType): These methods provide
18030 mechanisms to obtain the T* and T& from a T. We had the code
18031 previously scattered around the code base, and it also used
18032 TypeManager.LookupType that would go through plenty of caches.
18033 This one goes directly to the type source.
18035 In some places we did the Type.GetType followed by
18036 ModuleBuilder.GetType, but not in others, so this unifies the
18037 processing as well.
18039 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
18040 statements now that we have namespace information.
18042 * typemanager.cs (IsNamespace): New method, returns whether the
18043 string presented is a namespace or not.
18045 (ComputeNamespaces): New public entry point, computes the list of
18046 available namespaces, using the GetNamespaces API call in Mono, or
18047 the slower version in MS.NET.
18049 Now before we start the semantic analysis phase, we have a
18050 complete list of namespaces including everything that the user has
18053 Deleted old code to cache namespaces in .nsc files.
18055 2003-04-17 Miguel de Icaza <miguel@ximian.com>
18057 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
18058 class/struct location definition Location for the implicit
18059 constructor location.
18061 (Operator.Define): Use the location of the operator for the
18062 implicit Method definition.
18064 (Constructor.Emit): use the constructor location for the implicit
18065 base initializer constructor.
18067 * ecore.cs: Remove ITypeExpression. This interface is now gone,
18068 and the Expression class now contains two new methods:
18070 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
18071 isolate type lookup from the rest of the resolution process.
18073 Since we use Expressions to hold type definitions due to the way
18074 we parse the input we have historically overloaded Resolve to
18075 perform the Type lookups if a special flag is passed. Now this is
18076 eliminated and two methods take their place.
18078 The differences in the two methods between xStep and xTerminal is
18079 that xStep is involved in our current lookup system that uses
18080 SimpleNames to compose a name, while xTerminal is used just to
18081 catch the case where the simplename lookup failed.
18083 2003-04-16 Miguel de Icaza <miguel@ximian.com>
18085 * expression.cs (ResolveMemberAccess): Remove redundant code.
18086 TypeExpr expressions are always born fully resolved.
18088 * interface.cs (PopulateMethod): Do not lookup the types twice.
18089 We were doing it once during SemanticAnalysis and once during
18092 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
18093 in local variable type definitions, were being returned as a
18094 SimpleName (we decomposed everything into a string), that is
18095 because primary_expression was being used instead of a type in the
18096 grammar (reduce/reduce conflicts).
18098 The part that was wrong is that we converted the expression into a
18099 string (an oversimplification in one hand, compounded with primary
18100 expressions doing string concatenation).
18106 Would return "A.B.C[]" as a SimpleName. This stopped things like
18107 using clauses from working on this particular context. And a type
18108 was being matched directly against "A.B.C[]".
18110 We now use the correct approach, and allow for ComposedCast to be
18111 part of the unary expression. So the "A.B.C []" become a composed
18112 cast of "A.B.C" (as a nested group of MemberAccess with a
18113 SimpleName at the end) plus the rank composition "[]".
18117 2003-04-10 Miguel de Icaza <miguel@ximian.com>
18119 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
18120 for the access level checking.
18122 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
18123 `TypeContainer container', because I kept getting confused when I
18124 was debugging this code.
18126 * expression.cs (Indexers): Instead of tracking getters/setters,
18127 we now track them in parallel. We create one arraylist less, but
18128 most importantly it is possible now for the LValue code to find a
18129 matching get for a set.
18131 (IndexerAccess.DoResolveLValue): Update the code.
18132 GetIndexersForType has been modified already to extract all the
18133 indexers from a type. The code assumed it did not.
18135 Also make the code set the correct return type for the indexer.
18136 This was fixed a long time ago for properties, but was missing for
18137 indexers. It used to be void_type.
18139 (Binary.Emit): Test first for doubles instead of
18140 floats, as they are more common.
18142 (Binary.EmitBranchable): Use the .un version of the branch opcodes
18143 when dealing with floats and the <=, >= operators. This fixes bug
18146 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
18147 to load the array value by emitting a load on the foreach variable
18148 type. This was incorrect.
18150 We now emit the code to load an element using the the array
18151 variable type, and then we emit the conversion operator.
18155 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
18157 * attribute.cs: Avoid allocation of ArrayLists in the common case.
18159 2003-04-09 Miguel de Icaza <miguel@ximian.com>
18161 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
18162 test for protection before we test for signatures.
18164 (MethodSignature.ToString): implement.
18166 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
18167 to the case where we reduced into a LongConstant.
18169 * decl.cs (CheckAccessLevel): If the type is an array, we can not
18170 depend on whether the information is acurrate, because the
18171 Microsoft runtime will always claim that the array type is public,
18172 regardless of the real state.
18174 If the type is a pointer, another problem happens: the type is
18175 reported as non-public in Microsoft.
18177 In both cases we have to call CheckAccessLevel recursively with
18178 the underlying type as the argument to be tested.
18180 2003-04-08 Miguel de Icaza <miguel@ximian.com>
18182 * assign.cs (Assign.Emit): If we are dealing with a compound
18183 assignment expression, we should use the code path that stores the
18184 intermediate result in a temporary value. This fixes #40903.
18186 *expression.cs (Indirection.ToString): Provide ToString method for
18189 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
18191 * class.cs: Null out fields holding references to Block objects so
18192 they can be garbage collected.
18194 * expression.cs (OverloadResolve): Remove unused local.
18196 2003-04-07 Martin Baulig <martin@ximian.com>
18198 * codegen.cs (EmitContext.CurrentFile): New public field.
18199 (EmitContext.Mark): Use the CurrentFile to check whether the
18200 location is in the correct file.
18201 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
18203 2003-04-07 Martin Baulig <martin@ximian.com>
18205 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
18207 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
18208 location. [FIXME: The location argument which gets passed to this
18209 method is sometimes wrong!]
18211 2003-04-07 Nick Drochak <ndrochak@gol.com>
18213 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
18215 2003-04-07 Miguel de Icaza <miguel@ximian.com>
18217 * expression.cs (Indirection.EmitAssign): We were using the
18218 temporary, but returning immediately instead of continuing the
18221 2003-04-06 Martin Baulig <martin@ximian.com>
18223 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
18224 if it's a nested child, but also deriving from the outer class.
18227 * typemanager.cs (IsNestedChildOf): Make this work if it's a
18228 nested child, but also deriving from the outer class. See
18230 (FilterWithClosure): We may access private members of the outer
18231 class if we're a nested child and deriving from the outer class.
18232 (RealMemberLookup): Only set `closure_private_ok' if the
18233 `original_bf' contained BindingFlags.NonPublic.
18235 2003-04-05 Martin Baulig <martin@ximian.com>
18237 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
18239 2003-04-02 Miguel de Icaza <miguel@ximian.com>
18241 * class.cs (Event.Define): Do not allow abstract events to have
18244 2003-04-01 Miguel de Icaza <miguel@ximian.com>
18246 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
18247 block in event declarations.
18249 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
18250 value type, get its address.
18252 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
18253 leaving a class on the stack instead of a boolean value (int
18254 0/1). Change the code so we compare against null, and then the
18255 result against zero.
18257 * class.cs (TypeContainer.GetClassBases): We were checking for the
18258 parent class being sealed too late.
18260 * expression.cs (Binary.Emit): For <= and >= when dealing with
18261 floating point values, use cgt.un and clt.un instead of cgt and
18264 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
18266 * statement.cs: Apply the same optimization as MS: skip the
18267 GetEnumerator returning an IEnumerator, and use the one returning a
18268 CharEnumerator instead. This allows us to avoid the try-finally block
18271 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
18273 * cs-parser.jay: Attributes cannot be applied to
18274 namespaces. Fixes #40473
18276 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18279 (Add*): check if the name is valid using the full name for constants,
18280 fields, properties and events.
18282 2003-03-28 Miguel de Icaza <miguel@ximian.com>
18284 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
18285 char constants to be part of the enumeration.
18287 * expression.cs (Conditional.DoResolve): Add support for operator
18288 true. Implements the missing functionality from 14.12
18290 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
18291 operator true/false as required by the spec.
18293 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
18294 implicit conversion to boolean.
18296 * statement.cs (Statement.ResolveBoolean): A boolean expression is
18297 also one where the type implements `operator true'.
18299 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
18300 get an expression that will invoke operator true based on an
18303 (GetConversionOperators): Removed the hack that called op_True
18306 (Expression.ResolveBoolean): Move this from Statement.
18308 2003-03-17 Miguel de Icaza <miguel@ximian.com>
18310 * ecore.cs (FieldExpr): do not allow initialization of initonly
18311 fields on derived classes
18313 2003-03-13 Martin Baulig <martin@ximian.com>
18315 * statement.cs (Block.Emit): Call ig.BeginScope() and
18316 ig.EndScope() when compiling with debugging info; call
18317 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
18319 2003-03-08 Miguel de Icaza <miguel@ximian.com>
18321 * expression.cs (Indexers): Do not construct immediately, allow
18322 for new members to be appended as we go. Fixes 38143
18324 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18326 * expression.cs: save/restore context when resolving an unchecked
18329 2003-03-05 Miguel de Icaza <miguel@ximian.com>
18331 * cfold.cs: Catch division by zero in modulus operator during
18334 2003-03-03 Miguel de Icaza <miguel@ximian.com>
18336 * interface.cs (Interface.DefineMembers): Avoid defining members
18339 2003-02-27 Miguel de Icaza <miguel@ximian.com>
18341 * driver.cs: handle the +/- options for -noconfig
18343 * statement.cs (Unckeched.Resolve): Also track the state of
18344 unchecked in the Resolve phase.
18346 2003-02-27 Martin Baulig <martin@ximian.com>
18348 * ecore.cs (Expression.MemberLookup): Don't create a
18349 MethodGroupExpr for something which is not a method. Fixes #38291.
18351 2003-02-25 Miguel de Icaza <miguel@ximian.com>
18353 * class.cs (MemberBase.CheckParameters): Also check that the type
18354 is unmanaged if it is a pointer.
18356 * expression.cs (SizeOf.Resolve): Add location information.
18358 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
18359 a managed type is declared.
18361 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
18362 parameter modifiers as well. Fixes bug 38606
18364 * class.cs: Very sad. Am backing out the speed up changes
18365 introduced by the ArrayList -> Array in the TypeContainer, as they
18366 were not actually that much faster, and introduced a bug (no error
18367 reports on duplicated methods).
18369 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
18370 source first, this will guarantee that we have a valid expression
18371 before calling in lower levels functions that will require a
18372 resolved object. Then use this original_source in the
18373 target.ResolveLValue instead of the original source that was
18376 Another change. Use target.Resolve instead of LValueResolve.
18377 Although we are resolving for LValues, we will let the Assign code
18378 take care of that (it will be called again from Resolve). This
18379 basically allows code like this:
18381 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
18382 class Y { void A (X x) { x [0] += o; }
18384 The problem was that the indexer was trying to resolve for
18385 set_Item (idx, object o) and never finding one. The real set_Item
18386 was set_Item (idx, X). By delaying the process we get the right
18391 2003-02-23 Martin Baulig <martin@ximian.com>
18393 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
18394 while calling DoEmit ().
18396 * codegen.cs (EmitContext.Mark): Don't mark locations in other
18397 source files; if you use the #line directive inside a method, the
18398 compiler stops emitting line numbers for the debugger until it
18399 reaches the end of the method or another #line directive which
18400 restores the original file.
18402 2003-02-23 Martin Baulig <martin@ximian.com>
18404 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
18406 2003-02-23 Martin Baulig <martin@ximian.com>
18408 * statement.cs (Block.AddChildVariableNames): We need to call this
18409 recursively, not just for our immediate children.
18411 2003-02-23 Martin Baulig <martin@ximian.com>
18413 * class.cs (Event.Define): Always make the field private, like csc does.
18415 * typemanager.cs (TypeManager.RealMemberLookup): Make events
18416 actually work, fixes bug #37521.
18418 2003-02-23 Miguel de Icaza <miguel@ximian.com>
18420 * delegate.cs: When creating the various temporary "Parameters"
18421 classes, make sure that we call the ComputeAndDefineParameterTypes
18422 on those new parameters (just like we do with the formal ones), to
18423 allow them to be resolved in the context of the DeclSpace.
18425 This fixes the bug that Dick observed in Bugzilla #38530.
18427 2003-02-22 Miguel de Icaza <miguel@ximian.com>
18429 * expression.cs (ResolveMemberAccess): When resolving a constant,
18430 do not attempt to pull a constant if the value was not able to
18431 generate a valid constant.
18433 * const.cs (LookupConstantValue): Do not report more errors than required.
18435 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18437 * expression.cs: fixes bug #38328.
18439 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18441 * class.cs: Changed all the various members that can be part of a
18442 class from being an ArrayList to be an Array of the right type.
18443 During the DefineType type_list, interface_list, delegate_list and
18444 enum_list are turned into types, interfaces, delegates and enums
18447 And during the member population, indexer_list, event_list,
18448 constant_list, field_list, instance_constructor_list, method_list,
18449 operator_list and property_list are turned into their real arrays.
18451 Although we could probably perform this operation earlier, for
18452 good error reporting we need to keep the lists and remove the
18453 lists for longer than required.
18455 This optimization was triggered by Paolo profiling the compiler
18456 speed on the output of `gen-sample-program.pl' perl script.
18458 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
18459 not crash in methods like MemberLookupFailed that use this field.
18461 This problem arises when the compiler fails to resolve a type
18462 during interface type definition for example.
18464 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18466 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
18467 inherit from System.Object, so we have to stop at null, not only
18468 when reaching System.Object.
18470 2003-02-17 Miguel de Icaza <miguel@ximian.com>
18472 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
18473 DeclaredOnly because the parent indexer might have had a different
18474 name, but did not loop until the top of the hierarchy was reached.
18476 The problem this one fixes is 35492: when a class implemented an
18477 indexer from an interface, we were getting the interface method
18478 (which was abstract) and we were flagging an error (can not invoke
18481 This also keeps bug 33089 functioning, and test-148 functioning.
18483 * typemanager.cs (IsSpecialMethod): The correct way of figuring
18484 out if a method is special is to see if it is declared in a
18485 property or event, or whether it is one of the predefined operator
18486 names. This should fix correctly #36804.
18488 2003-02-15 Miguel de Icaza <miguel@ximian.com>
18490 The goal here is to remove the dependency on EmptyCast.Peel ().
18491 Killing it completely.
18493 The problem is that currently in a number of places where
18494 constants are expected, we have to "probe" for an EmptyCast, and
18495 Peel, which is not the correct thing to do, as this will be
18496 repetitive and will likely lead to errors.
18498 The idea is to remove any EmptyCasts that are used in casts that
18499 can be reduced to constants, so we only have to cope with
18502 This bug hunt was triggered by Bug 37363 and the desire to remove
18503 the duplicate pattern where we were "peeling" emptycasts to check
18504 whether they were constants. Now constants will always be
18507 * ecore.cs: Use an enumconstant here instead of wrapping with
18510 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
18511 throwing me off. By handling this we can get rid of a few hacks.
18513 * statement.cs (Switch): Removed Peel() code.
18515 2003-02-14 Miguel de Icaza <miguel@ximian.com>
18517 * class.cs: Location information for error 508
18519 * expression.cs (New.DoResolve): Add a guard against double
18520 resolution of an expression.
18522 The New DoResolve might be called twice when initializing field
18523 expressions (see EmitFieldInitializers, the call to
18524 GetInitializerExpression will perform a resolve on the expression,
18525 and later the assign will trigger another resolution
18527 This leads to bugs (#37014)
18529 * delegate.cs: The signature for EndInvoke should contain any ref
18530 or out parameters as well. We were not doing this in the past.
18532 * class.cs (Field.Define): Do not overwrite the type definition
18533 inside the `volatile' group. Turns out that volatile enumerations
18534 were changing the type here to perform a validity test, which
18537 2003-02-12 Miguel de Icaza <miguel@ximian.com>
18539 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
18540 and structs, we do not want to load the instance variable
18542 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
18543 enum_type has to be handled like an object reference (implicit
18544 conversions exists from this to object), but the regular IsClass
18545 and IsValueType tests will never return true for this one.
18547 Also we use TypeManager.IsValueType instead of type.IsValueType,
18548 just for consistency with the rest of the code (this is only
18549 needed if we ever use the construct exposed by test-180.cs inside
18550 corlib, which we dont today).
18552 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
18554 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
18557 2003-02-09 Martin Baulig <martin@ximian.com>
18559 * namespace.cs (Namespace..ctor): Added SourceFile argument.
18560 (Namespace.DefineNamespaces): New static public method; this is
18561 called when we're compiling with debugging to add all namespaces
18562 to the symbol file.
18564 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
18565 pass it to the Namespace's .ctor.
18567 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
18568 and MethodBase arguments; pass the namespace ID to the symwriter;
18569 pass the MethodBase instead of the token to the symwriter.
18570 (SymbolWriter.DefineNamespace): New method to add a namespace to
18573 2003-02-09 Martin Baulig <martin@ximian.com>
18575 * symbolwriter.cs: New file. This is a wrapper around
18576 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
18577 methods here in near future.
18579 2003-02-09 Martin Baulig <martin@ximian.com>
18581 * codegen.cs (EmitContext.Mark): Just pass the arguments to
18582 ILGenerator.MarkSequencePoint() which are actually used by the
18585 2003-02-09 Martin Baulig <martin@ximian.com>
18587 * location.cs (SourceFile): New public sealed class. This
18588 contains the name and an index which is used in the location's token.
18589 (Location): Reserve an appropriate number of bits in the token for
18590 the source file instead of walking over that list, this gives us a
18591 really huge performance improvement when compiling with debugging.
18593 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
18594 `SourceFile' argument instead of a string.
18595 (Driver.ProcessFile): Add all the files via Location.AddFile(),
18596 but don't parse/tokenize here, we need to generate the list of all
18597 source files before we do that.
18598 (Driver.ProcessFiles): New static function. Parses/tokenizes all
18601 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
18602 instead of a string.
18604 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
18607 2003-02-09 Martin Baulig <martin@ximian.com>
18609 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
18610 filename on `#line default'.
18612 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
18614 * statement.cs: don't clear the pinned var when the fixed statement
18615 returns from the method (fixes bug#37752).
18617 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
18619 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
18622 2003-02-07 Martin Baulig <martin@ximian.com>
18624 * driver.cs: Removed the `--debug-args' command line argument.
18626 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
18627 automatically by the AsssemblyBuilder.
18628 (CodeGen.InitializeSymbolWriter): We don't need to call any
18629 initialization function on the symbol writer anymore. This method
18630 doesn't take any arguments.
18632 2003-02-03 Miguel de Icaza <miguel@ximian.com>
18634 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
18635 from referenced assemblies as well.
18637 2003-02-02 Martin Baulig <martin@ximian.com>
18639 * class.cs (MethodData.Emit): Generate debugging info for external methods.
18641 2003-02-02 Martin Baulig <martin@ximian.com>
18643 * class.cs (Constructor.Emit): Open the symbol writer before
18644 emitting the constructor initializer.
18645 (ConstructorInitializer.Emit): Call ec.Mark() to allow
18646 single-stepping through constructor initializers.
18648 2003-01-30 Miguel de Icaza <miguel@ximian.com>
18650 * class.cs: Handle error 549: do not allow virtual methods in
18653 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
18655 * decl.cs: Check access levels when resolving types
18657 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
18659 * statement.cs: Add parameters and locals set in catch blocks that might
18660 return to set vector
18662 2003-01-29 Miguel de Icaza <miguel@ximian.com>
18664 * class.cs (Operator): Set the SpecialName flags for operators.
18666 * expression.cs (Invocation.DoResolve): Only block calls to
18667 accessors and operators on SpecialName methods.
18669 (Cast.TryReduce): Handle conversions from char constants.
18672 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
18674 * statement.cs: small memory and time optimization in FlowBranching.
18676 2003-01-28 Pedro Mart <yoros@wanadoo.es>
18678 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
18679 problem that the last fix but in the other sid (Set).
18681 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
18682 access when there is no indexer in the hierarchy.
18684 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
18686 * class.cs: Combine some if statements.
18688 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18690 * driver.cs: fixed bug #37187.
18692 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
18694 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
18695 any indexer, it's needed to build a list with all the indexers in the
18696 hierarchy (AllGetters), else we have problems. Fixes #35653.
18698 2003-01-23 Miguel de Icaza <miguel@ximian.com>
18700 * class.cs (MethodData.Define): It is wrong for an interface
18701 implementation to be static in both cases: explicit and implicit.
18702 We were only handling this in one case.
18704 Improve the if situation there to not have negations.
18706 * class.cs (Field.Define): Turns out that we do not need to check
18707 the unsafe bit on field definition, only on usage. Remove the test.
18709 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18711 * driver.cs: use assembly.Location instead of Codebase (the latest
18712 patch made mcs fail when using MS assemblies).
18714 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
18716 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
18717 get the path to *corlib.dll.
18719 2003-01-21 Nick Drochak <ndrochak@gol.com>
18723 * typemanager.cs: Remove compiler warnings
18725 2003-01-20 Duncan Mak <duncan@ximian.com>
18727 * AssemblyInfo.cs: Bump the version number to 0.19.
18729 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18731 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
18733 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
18735 * class.cs (Constructor::Emit): Emit debugging info for constructors.
18737 2003-01-17 Miguel de Icaza <miguel@ximian.com>
18739 * cs-parser.jay: Small fix: we were not comparing the constructor
18740 name correctly. Thanks to Zoltan for the initial pointer.
18742 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
18744 * cs-tokenizer.cs: Set file name when specified with #line
18746 2003-01-15 Miguel de Icaza <miguel@ximian.com>
18748 * cs-parser.jay: Only perform the constructor checks here if we
18749 are named like the class; This will help provider a better
18750 error. The constructor path is taken when a type definition is
18751 not found, but most likely the user forgot to add the type, so
18752 report that rather than the constructor error.
18754 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
18756 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
18759 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18761 * cs-parser.jay: Add cleanup call.
18763 2003-01-13 Duncan Mak <duncan@ximian.com>
18765 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
18766 consistent with other methods.
18768 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18770 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
18772 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
18774 * attribute.cs: only set GuidAttr to true when we have a
18777 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18781 * typemanager.cs: fixes to allow mcs compile corlib with the new
18782 Type.IsSubclassOf fix.
18784 2003-01-08 Miguel de Icaza <miguel@ximian.com>
18786 * expression.cs (LocalVariableReference.DoResolve): Classify a
18787 constant as a value, not as a variable. Also, set the type for
18790 * cs-parser.jay (fixed_statement): take a type instead of a
18791 pointer_type, so we can produce a better error message later.
18793 * statement.cs (Fixed.Resolve): Flag types that are not pointers
18796 (For.DoEmit): Make inifinite loops have a
18797 non-conditional branch back.
18799 (Fixed.DoEmit): First populate the pinned variables, then emit the
18800 statement, then clear the variables. Before I was emitting the
18801 code once for each fixed piece.
18804 2003-01-08 Martin Baulig <martin@ximian.com>
18806 * statement.cs (FlowBranching.MergeChild): A break in a
18807 SWITCH_SECTION does not leave a loop. Fixes #36155.
18809 2003-01-08 Martin Baulig <martin@ximian.com>
18811 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
18812 lives in the same number space than `param_map'. Fixes #36154.
18814 2003-01-07 Miguel de Icaza <miguel@ximian.com>
18816 * cs-parser.jay (constructor_declaration): Set the
18817 Constructor.ModFlags before probing for it. This makes the
18818 compiler report 514, 515 and 132 (the code was there, but got
18821 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
18822 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
18823 (GotoCase.Resolve): Set `Returns' to ALWAYS.
18825 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
18827 * enum.cs: create the enum static fields using the enum type.
18829 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
18831 * class.cs: don't try to create the ParamBuilder for the return
18832 type if it's not needed (and handle it breaking for the ms runtime
18835 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
18837 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
18839 2002-12-29 Miguel de Icaza <miguel@ximian.com>
18841 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
18842 the command. This showed up while compiling the JANET source
18843 code, which used \r as its only newline separator.
18845 2002-12-28 Miguel de Icaza <miguel@ximian.com>
18847 * class.cs (Method.Define): If we are an operator (because it
18848 reuses our code), then set the SpecialName and HideBySig. #36128
18850 2002-12-22 Miguel de Icaza <miguel@ximian.com>
18852 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
18853 exception, report error 120 `object reference required'.
18855 * driver.cs: Add --pause option, used during to measure the size
18856 of the process as it goes with --timestamp.
18858 * expression.cs (Invocation.DoResolve): Do not allow methods with
18859 SpecialName to be invoked.
18861 2002-12-21 Miguel de Icaza <miguel@ximian.com>
18863 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
18864 number before adding it.
18866 2002-12-21 Ravi Pratap <ravi@ximian.com>
18868 * ecore.cs (StandardImplicitConversion): When in an unsafe
18869 context, we allow conversion between void * to any other pointer
18870 type. This fixes bug #35973.
18872 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
18874 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
18875 is not thrown when extensionless outputs are used
18877 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18879 * rootcontext.cs: fixed compilation of corlib.
18881 2002-12-19 Miguel de Icaza <miguel@ximian.com>
18883 * attribute.cs (Attributes.Contains): Add new method.
18885 * class.cs (MethodCore.LabelParameters): if the parameter is an
18886 `out' parameter, check that no attribute `[In]' has been passed.
18888 * enum.cs: Handle the `value__' name in an enumeration.
18890 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
18892 * decl.cs: Added special case to allow overrides on "protected
18895 2002-12-18 Ravi Pratap <ravi@ximian.com>
18897 * attribute.cs (Attributes.AddAttributeSection): Rename to this
18898 since it makes much more sense.
18900 (Attributes.ctor): Don't require a Location parameter.
18902 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
18904 * attribute.cs (ApplyAttributes): Remove extra Location parameters
18905 since we already have that information per attribute.
18907 * everywhere : make appropriate changes.
18909 * class.cs (LabelParameters): Write the code which actually
18910 applies attributes to the return type. We can't do this on the MS
18911 .NET runtime so we flag a warning in the case an exception is
18914 2002-12-18 Miguel de Icaza <miguel@ximian.com>
18916 * const.cs: Handle implicit null conversions here too.
18918 2002-12-17 Ravi Pratap <ravi@ximian.com>
18920 * class.cs (MethodCore.LabelParameters): Remove the extra
18921 Type [] parameter since it is completely unnecessary. Instead
18922 pass in the method's attributes so that we can extract
18923 the "return" attribute.
18925 2002-12-17 Miguel de Icaza <miguel@ximian.com>
18927 * cs-parser.jay (parse): Use Report.Error to flag errors instead
18928 of ignoring it and letting the compile continue.
18930 * typemanager.cs (ChangeType): use an extra argument to return an
18931 error condition instead of throwing an exception.
18933 2002-12-15 Miguel de Icaza <miguel@ximian.com>
18935 * expression.cs (Unary.TryReduce): mimic the code for the regular
18936 code path. Perform an implicit cast in the cases where we can
18937 implicitly convert to one of the integral types, and then reduce
18938 based on that constant. This fixes bug #35483.
18940 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18942 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
18944 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18946 * namespace.cs: fixed bug #35489.
18948 2002-12-12 Miguel de Icaza <miguel@ximian.com>
18950 * class.cs: Remove some dead code.
18952 * cs-parser.jay: Estimate the number of methods needed
18953 (RootContext.MethodCount);
18955 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
18956 numbers instead of StringBuilders.
18958 * support.cs (PtrHashtable): Add constructor with initial size;
18959 We can now reduce reallocations of the method table.
18961 2002-12-10 Ravi Pratap <ravi@ximian.com>
18963 * attribute.cs (ApplyAttributes): Keep track of the emitted
18964 attributes on a per-target basis. This fixes bug #35413.
18966 2002-12-10 Miguel de Icaza <miguel@ximian.com>
18968 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
18969 default to the Windows 1252 encoding.
18971 (UnixParseOption): Support version, thanks to Alp for the missing
18974 * AssemblyInfo.cs: Add nice assembly information.
18976 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
18979 * cs-parser.jay: Allow a trailing comma before the close bracked
18980 in the attribute_section production.
18982 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
18983 address of the instance was being taken, I will take this out,
18984 because we take the address of the object immediately here.
18986 2002-12-09 Ravi Pratap <ravi@ximian.com>
18988 * typemanager.cs (AreMultipleAllowed): Take care of the most
18989 obvious case where attribute type is not in the current assembly -
18992 2002-12-08 Miguel de Icaza <miguel@ximian.com>
18994 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
18995 definitions, instead of doing that afterwards.
18997 Also we use a nice little hack, depending on the constructor, we
18998 know if we are a "composed" name or a simple name. Hence, we
18999 avoid the IndexOf test, and we avoid
19001 * codegen.cs: Add code to assist in a bug reporter to track down
19002 the source of a compiler crash.
19004 2002-12-07 Ravi Pratap <ravi@ximian.com>
19006 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
19007 types have been emitted for a given element and flag an error
19008 if something which does not have AllowMultiple set is used more
19011 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
19012 attribute types and their corresponding AllowMultiple properties
19014 (AreMultipleAllowed): Check the property for a given type.
19016 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
19017 property in the case we have a TypeContainer.
19019 (Attributes.AddAttribute): Detect duplicates and just skip on
19020 adding them. This trivial fix catches a pretty gross error in our
19021 attribute emission - global attributes were being emitted twice!
19023 Bugzilla bug #33187 is now fixed.
19025 2002-12-06 Miguel de Icaza <miguel@ximian.com>
19027 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
19028 instead of pp_and).
19030 * expression.cs (Binary.ResolveOperator): I can only use the
19031 Concat (string, string, string) and Concat (string, string,
19032 string, string) if the child is actually a concatenation of
19035 2002-12-04 Miguel de Icaza <miguel@ximian.com>
19037 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
19038 context where we need a 2-character lookahead.
19040 * pending.cs (PendingImplementation): Rework so we can keep track
19041 of interface types all the time, and flag those which were
19042 implemented by parents as optional.
19044 2002-12-03 Miguel de Icaza <miguel@ximian.com>
19046 * expression.cs (Binary.ResolveOperator): Use
19047 String.Concat(string,string,string) or
19048 String.Concat(string,string,string,string) when possible.
19050 * typemanager: More helper methods.
19053 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
19055 * pending.cs: remove the bogus return from GetMissingInterfaces()
19056 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
19058 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19060 * namespace.cs: avoid duplicated 'using xxx' being added to
19061 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
19062 when we get more than one 'using' statement for the same namespace.
19063 Report a CS0105 warning for it.
19065 2002-11-30 Miguel de Icaza <miguel@ximian.com>
19067 * cs-tokenizer.cs (consume_identifier): use read directly, instead
19068 of calling getChar/putback, uses internal knowledge of it.
19070 (xtoken): Reorder tokenizer so most common patterns are checked
19071 first. This reduces the compilation time in another 5% (from 8.11s
19072 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
19074 The parsing time is 22% of the compilation in mcs, and from that
19075 64% is spent on the tokenization process.
19077 I tried using a binary search for keywords, but this is slower
19078 than the hashtable. Another option would be to do a couple of
19081 * Not use a StringBuilder, instead use an array of chars,
19082 with a set value. Notice that this way we could catch
19083 the 645 error without having to do it *afterwards*.
19085 * We could write a hand-parser to avoid the hashtable
19086 compares altogether.
19088 The identifier consumption process takes 37% of the tokenization
19089 time. Another 15% is spent on is_number. 56% of the time spent
19090 on is_number is spent on Int64.Parse:
19092 * We could probably choose based on the string length to
19093 use Int32.Parse or Int64.Parse and avoid all the 64-bit
19096 Another 3% is spend on wrapping `xtoken' in the `token' function.
19098 Handle 0xa0 as whitespace (#34752)
19100 2002-11-26 Miguel de Icaza <miguel@ximian.com>
19102 * typemanager.cs (IsCLRType): New routine to tell whether a type
19103 is one of the builtin types.
19105 Maybe it needs to use TypeCodes to be faster. Maybe we could use
19106 typecode in more places instead of doing pointer comparissions.
19107 We could leverage some knowledge about the way the typecodes are
19110 New code to cache namespaces in assemblies, it is currently not
19111 invoked, to be used soon.
19113 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
19115 * expression.cs (Binary.ResolveOperator): specially handle
19116 strings, and do not perform user-defined operator overloading for
19119 2002-11-24 Miguel de Icaza <miguel@ximian.com>
19121 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
19122 internalcall as it is a pretty simple operation; Avoid whenever
19123 possible to call Char.IsLetter.
19125 (consume_identifier): Cut by half the number of
19126 hashtable calls by merging the is_keyword and GetKeyword behavior.
19128 Do not short-circuit, because if we do, we
19129 report errors (ie, #if false && true would produce an invalid
19133 2002-11-24 Martin Baulig <martin@ximian.com>
19135 * expression.cs (Cast.TryReduce): If we're in checked syntax,
19136 check constant ranges and report a CS0221. Fixes #33186.
19138 2002-11-24 Martin Baulig <martin@ximian.com>
19140 * cs-parser.jay: Make this work for uninitialized variable
19141 declarations in the `for' initializer. Fixes #32416.
19143 2002-11-24 Martin Baulig <martin@ximian.com>
19145 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
19146 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
19148 2002-11-24 Martin Baulig <martin@ximian.com>
19150 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
19151 argument; if true, we also check for user-defined conversions.
19152 This is only needed if both arguments are of a user-defined type.
19153 Fixes #30443, added test-175.cs.
19154 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
19156 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
19158 2002-11-24 Martin Baulig <martin@ximian.com>
19160 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
19161 function to get the store opcode.
19162 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
19163 only emit the Ldelema if the store opcode is Stobj. You must run
19164 both test-34 and test-167 to test this. Fixes #34529.
19166 2002-11-23 Martin Baulig <martin@ximian.com>
19168 * ecore.cs (Expression.MemberLookup): Added additional
19169 `qualifier_type' argument which is used when we're being called
19170 from MemberAccess.DoResolve() and null if we're called from a
19172 (Expression.MemberLookupFailed): New method to report errors; this
19173 does the CS1540 check and reports the correct error message.
19175 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
19176 argument for the CS1540 check and redone the way how we're dealing
19177 with private members. See the comment in the source code for details.
19178 (FilterWithClosure): Reverted this back to revision 1.197; renamed
19179 `closure_start_type' to `closure_qualifier_type' and check whether
19180 it's not null. It was not this filter being broken, it was just
19181 being called with the wrong arguments.
19183 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
19184 and pass it the correct `qualifier_type'; this also does the error
19187 2002-11-22 Miguel de Icaza <miguel@ximian.com>
19189 * expression.cs (Invocation.EmitParams): If the we are dealing
19190 with a non-built-in value type, load its address as well.
19192 (ArrayCreation): Use a a pretty constant instead
19193 of the hardcoded value 2. Use 6 instead of 2 for the number of
19194 static initializers.
19196 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
19197 because they are not really value types, just glorified integers.
19199 * driver.cs: Do not append .exe, the CSC compiler does not do it.
19201 * ecore.cs: Remove redundant code for enumerations, make them use
19202 the same code path as everything else, fixes the casting issue
19203 with enumerations in Windows.Forms.
19205 * attribute.cs: Do only cast to string if it is a string, the
19206 validation happens later.
19208 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
19209 people upgrade their corlibs.
19211 * ecore.cs: Oops, enumerations were not following the entire code path
19213 2002-11-21 Miguel de Icaza <miguel@ximian.com>
19215 * typemanager.cs (FilterWithClosure): Commented out the test for
19216 1540 in typemanager.cs, as it has problems when accessing
19217 protected methods from a parent class (see test-174.cs).
19219 * attribute.cs (Attribute.ValidateGuid): new method.
19220 (Attribute.Resolve): Use above.
19222 2002-11-19 Miguel de Icaza <miguel@ximian.com>
19224 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
19226 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
19227 handling for enumerations, as we only needed the TypeContainer
19228 functionality to begin with (this is required for the fix below to
19229 work for enums that reference constants in a container class for
19232 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
19234 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
19235 a valid TypeBuilder to perform lookups on.o
19237 * class.cs (InheritableMemberSignatureCompare): Use true in the
19238 call to GetGetMethod and GetSetMethod, because we are comparing
19239 the signature, and we need to get the methods *even* if they are
19242 (PropertyBase.CheckBase): ditto.
19244 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
19245 GotoCase.Resolve): Use Peel on EmpytCasts.
19247 * ecore.cs (EmptyCast): drop child, add Peel method.
19249 2002-11-17 Martin Baulig <martin@ximian.com>
19251 * ecore.cs (EmptyCast.Child): New public property.
19253 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
19254 label resolved to an EmptyCast. Fixes #34162.
19255 (GotoCase.Resolve): Likewise.
19256 (Block.EmitMeta): Likewise.
19258 2002-11-17 Martin Baulig <martin@ximian.com>
19260 * expression.cs (Invocation.BetterConversion): Prefer int over
19261 uint; short over ushort; long over ulong for integer literals.
19262 Use ImplicitConversionExists instead of StandardConversionExists
19263 since we also need to check for user-defined implicit conversions.
19264 Fixes #34165. Added test-173.cs.
19266 2002-11-16 Martin Baulig <martin@ximian.com>
19268 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
19269 with the `true' and `false' literals. Fixes #33151.
19271 2002-11-16 Martin Baulig <martin@ximian.com>
19273 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
19274 October 22nd; don't do the cs1540 check for static members.
19276 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
19277 now using our own filter here and doing the cs1540 check again.
19279 2002-11-16 Martin Baulig <martin@ximian.com>
19281 * support.cs (InternalParameters): Don't crash if we don't have
19282 any fixed parameters. Fixes #33532.
19284 2002-11-16 Martin Baulig <martin@ximian.com>
19286 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
19287 when looking up static methods to make this work on Windows.
19290 2002-11-16 Martin Baulig <martin@ximian.com>
19292 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
19293 a setter rather than using PropertyInfo.CanWrite.
19295 2002-11-15 Nick Drochak <ndrochak@gol.com>
19297 * class.cs: Allow acces to block member by subclasses. Fixes build
19300 2002-11-14 Martin Baulig <martin@ximian.com>
19302 * class.cs (Constructor.Emit): Added the extern/block check.
19305 2002-11-14 Martin Baulig <martin@ximian.com>
19307 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
19308 iteration while looking for indexers, this is needed because the
19309 indexer may have a different name in our base classes. Fixed the
19310 error reporting (no indexers at all, not get accessor, no
19311 overloaded match). Fixes bug #33089.
19312 (IndexerAccess.DoResolveLValue): Likewise.
19314 2002-11-14 Martin Baulig <martin@ximian.com>
19316 * class.cs (PropertyBase.CheckBase): Make this work for multiple
19317 indexers. Fixes the first part of bug #33089.
19318 (MethodSignature.InheritableMemberSignatureCompare): Added support
19321 2002-11-13 Ravi Pratap <ravi@ximian.com>
19323 * attribute.cs (Attribute.Resolve): Catch the
19324 NullReferenceException and report it since it isn't supposed to
19327 2002-11-12 Miguel de Icaza <miguel@ximian.com>
19329 * expression.cs (Binary.EmitBranchable): Also handle the cases for
19330 LogicalOr and LogicalAnd that can benefit from recursively
19331 handling EmitBranchable. The code now should be nice for Paolo.
19333 2002-11-08 Miguel de Icaza <miguel@ximian.com>
19335 * typemanager.cs (LookupType): Added a negative-hit hashtable for
19336 the Type lookups, as we perform quite a number of lookups on
19337 non-Types. This can be removed once we can deterministically tell
19338 whether we have a type or a namespace in advance.
19340 But this might require special hacks from our corlib.
19344 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
19345 and double which avoids a conversion from an integer to a double.
19347 * expression.cs: tiny optimization, avoid calling IsConstant,
19348 because it effectively performs the lookup twice.
19350 2002-11-06 Miguel de Icaza <miguel@ximian.com>
19352 But a bogus return here to keep the semantics of the old code
19353 until the Mono runtime is fixed.
19355 * pending.cs (GetMissingInterfaces): New method used to remove all
19356 the interfaces that are already implemented by our parent
19357 classes from the list of pending methods.
19359 * interface.cs: Add checks for calls after ResolveTypeExpr.
19361 2002-11-05 Miguel de Icaza <miguel@ximian.com>
19363 * class.cs (Class.Emit): Report warning 67: event not used if the
19364 warning level is beyond 3.
19366 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
19367 being a NullLiteral.
19369 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
19372 * class.cs (TypeContainer.GetClassBases): Cover a missing code
19373 path that might fail if a type can not be resolved.
19375 * expression.cs (Binary.Emit): Emit unsigned versions of the
19378 * driver.cs: use error 5.
19380 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
19382 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
19384 2002-11-01 Miguel de Icaza <miguel@ximian.com>
19386 * cs-parser.jay (switch_section): A beautiful patch from Martin
19387 Baulig that fixed 33094.
19389 2002-10-31 Miguel de Icaza <miguel@ximian.com>
19391 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
19392 Check whether the base is abstract and report an error if so.
19394 * expression.cs (IndexerAccess.DoResolveLValue,
19395 IndexerAccess.DoResolve): ditto.
19397 (Invocation.DoResolve): ditto.
19399 (Invocation.FullMethodDesc): Improve the report string.
19401 * statement.cs (Block): Eliminate IsVariableDefined as it is
19402 basically just a wrapper for GetVariableInfo.
19404 * ecore.cs (SimpleName): Use new
19406 * support.cs (ReflectionParamter.ParameterType): We unwrap the
19407 type, as we return the actual parameter ref/unref state on a
19410 2002-10-30 Miguel de Icaza <miguel@ximian.com>
19412 * support.cs: Return proper flags REF/OUT fixing the previous
19415 * expression.cs: Reverted last patch, that was wrong. Is_ref is
19416 not used to mean `ref' but `ref or out' in ParameterReference
19418 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
19419 full type signature instead of calling TypeManger.CSharpName
19422 * support.cs (InternalParameters.ParameterDesc): Do not compare
19423 directly to the modflags, because REF/OUT will actually be bitsets
19426 * delegate.cs (VerifyMethod): Check also the modifiers.
19428 * cs-tokenizer.cs: Fix bug where floating point values with an
19429 exponent where a sign was missing was ignored.
19431 * driver.cs: Allow multiple assemblies to be specified in a single
19434 2002-10-28 Miguel de Icaza <miguel@ximian.com>
19436 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
19437 because identifiers after a parenthesis would end up in this kind
19438 of production, and we needed to desamiguate it for having casts
19441 (UserDefinedType *) xxx
19443 2002-10-24 Miguel de Icaza <miguel@ximian.com>
19445 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
19446 we should set on the Bindingflags.NonPublic, but not turn on
19447 private_ok. private_ok controls whether a Private member is
19448 returned (this is chekced on the filter routine), while the
19449 BindingFlags.NonPublic just controls whether private/protected
19450 will be allowed. This fixes the problem part of the problem of
19451 private properties being allowed to be used in derived classes.
19453 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
19454 so we can call the children DoResolveLValue method (this will
19455 properly signal errors on lvalue assignments to base properties)
19457 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
19458 getter are null, and we have a property info, we know that this
19459 happened because the lookup failed, so we report an error 122 for
19460 protection level violation.
19462 We also silently return if setter and getter are null in the
19463 resolve functions, this condition only happens if we have flagged
19464 the error before. This is the other half of the problem.
19466 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
19467 not have accessibility information, that is why we were returning
19468 true in the filter function in typemanager.cs.
19470 To properly report 122 (property is inaccessible because of its
19471 protection level) correctly, we report this error in ResolveAccess
19472 by failing if both the setter and the getter are lacking (ie, the
19475 DoResolve and DoLResolve have been modified to check for both
19476 setter/getter being null and returning silently, the reason being
19477 that I did not want to put the knowledge about this error in upper
19480 int old = Report.Errors;
19481 x = new PropertyExpr (...);
19482 if (old != Report.Errors)
19487 So the property expr is returned, but it is invalid, so the error
19488 will be flagged during the resolve process.
19490 * class.cs: Remove InheritablePropertySignatureCompare from the
19491 class, as we no longer depend on the property signature to compute
19492 whether it is possible to implement a method or not.
19494 The reason is that calling PropertyInfo.GetGetMethod will return
19495 null (in .NET, in Mono it works, and we should change this), in
19496 cases where the Get Method does not exist in that particular
19501 class X { public virtual int A { get { return 1; } } }
19503 class Z : Y { public override int A { get { return 2; } } }
19505 Would fail in Z because the parent (Y) would not have the property
19506 defined. So we avoid this completely now (because the alternative
19507 fix was ugly and slow), and we now depend exclusively on the
19510 (PropertyBase.CheckBase): Use a method-base mechanism to find our
19511 reference method, instead of using the property.
19513 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
19514 routines are gone now.
19516 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
19517 names, they were incorrectly named.
19519 * cs-tokenizer.cs: Return are more gentle token on failure.
19521 * pending.cs (PendingImplementation.InterfaceMethod): This routine
19522 had an out-of-sync index variable, which caused it to remove from
19523 the list of pending methods the wrong method sometimes.
19525 2002-10-22 Miguel de Icaza <miguel@ximian.com>
19527 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
19528 CanWrite, because those refer to this particular instance of the
19529 property, and do not take into account the fact that we can
19530 override single members of a property.
19532 Constructor requires an EmitContext. The resolution process does
19533 not happen here, but we need to compute the accessors before,
19534 because the resolution does not always happen for properties.
19536 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
19537 subclass, before we did not update this flag, but we did update
19540 (GetAccessors): Drop this routine, as it did not work in the
19541 presence of partially overwritten set/get methods.
19543 Notice that this broke the cs1540 detection, but that will require
19546 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19550 * driver.cs: issue a warning instead of an error if we don't support
19551 debugging for the platform. Also ignore a couple of errors that may
19552 arise when trying to write the symbols. Undo my previous patch.
19554 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19556 * driver.cs: ignore /debug switch except for Unix platforms.
19558 2002-10-23 Nick Drochak <ndrochak@gol.com>
19560 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
19562 2002-10-21 Miguel de Icaza <miguel@ximian.com>
19564 * driver.cs: Do not make mcs-debug conditional, so we do not break
19565 builds that use it.
19567 * statement.cs (UsageVector.MergeChildren): I would like Martin to
19568 review this patch. But basically after all the children variables
19569 have been merged, the value of "Breaks" was not being set to
19570 new_breaks for Switch blocks. I think that it should be set after
19571 it has executed. Currently I set this to the value of new_breaks,
19572 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
19573 conservative, but I do not understand this code very well.
19575 I did not break anything in the build, so that is good ;-)
19577 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
19579 2002-10-20 Mark Crichton <crichton@gimp.org>
19581 * cfold.cs: Fixed compile blocker. Really fixed it this time.
19583 2002-10-20 Nick Drochak <ndrochak@gol.com>
19585 * cfold.cs: Fixed compile blocker.
19587 2002-10-20 Miguel de Icaza <miguel@ximian.com>
19589 * driver.cs: I was chekcing the key, not the file.
19591 2002-10-19 Ravi Pratap <ravi@ximian.com>
19593 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
19594 message that we were generating - we just need to silently return
19597 2002-10-19 Miguel de Icaza <miguel@ximian.com>
19599 * class.cs (Event.Define): Change my previous commit, as this
19600 breaks the debugger. This is a temporary hack, as it seems like
19601 the compiler is generating events incorrectly to begin with.
19603 * expression.cs (Binary.ResolveOperator): Added support for
19604 "U operator - (E x, E y)"
19606 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
19609 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
19610 init-only variables, but this path did not take into account that
19611 there might be also instance readonly variables. Correct this
19614 This fixes bug 32253
19616 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
19619 * driver.cs: Change the extension for modules to `netmodule'
19621 * cs-parser.jay: Improved slightly the location tracking for
19622 the debugger symbols.
19624 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
19625 modifiers that were specified instead of the hardcoded value
19626 (FamAndAssem). This was basically ignoring the static modifier,
19627 and others. Fixes 32429.
19629 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
19630 fixed a bug in the process (32476)
19632 * expression.cs (ArrayAccess.EmitAssign): Patch from
19633 hwang_rob@yahoo.ca that fixes bug 31834.3
19635 2002-10-18 Miguel de Icaza <miguel@ximian.com>
19637 * driver.cs: Make the module extension .netmodule.
19639 2002-10-16 Miguel de Icaza <miguel@ximian.com>
19641 * driver.cs: Report an error if the resource file is not found
19642 instead of crashing.
19644 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
19645 false, like Emit does.
19647 2002-10-16 Nick Drochak <ndrochak@gol.com>
19649 * typemanager.cs: Remove unused private member. Also reported mcs
19650 bug to report this as a warning like csc.
19652 2002-10-15 Martin Baulig <martin@gnome.org>
19654 * statement.cs (Statement.Emit): Made this a virtual method; emits
19655 the line number info and calls DoEmit().
19656 (Statement.DoEmit): New protected abstract method, formerly knows
19657 as Statement.Emit().
19659 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
19661 2002-10-11 Miguel de Icaza <miguel@ximian.com>
19663 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
19664 have fixed a remaining problem: not every AddXXXX was adding a
19665 fully qualified name.
19667 Now everyone registers a fully qualified name in the DeclSpace as
19668 being defined instead of the partial name.
19670 Downsides: we are slower than we need to be due to the excess
19671 copies and the names being registered this way.
19673 The reason for this is that we currently depend (on the corlib
19674 bootstrap for instance) that types are fully qualified, because
19675 we dump all the types in the namespace, and we should really have
19676 types inserted into the proper namespace, so we can only store the
19677 basenames in the defined_names array.
19679 2002-10-10 Martin Baulig <martin@gnome.org>
19681 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
19682 from bug #31834, see the bug report for a testcase which is
19685 2002-10-10 Martin Baulig <martin@gnome.org>
19687 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
19688 flow analysis code for this.
19690 * statement.cs (Do, While, For): Tell the flow analysis code about
19692 (FlowBranching.UsageVector): Added support for infinite loops.
19693 (Block.Resolve): Moved the dead code elimination here and use flow
19696 2002-10-09 Miguel de Icaza <miguel@ximian.com>
19698 * class.cs (Field.Define): Catch cycles on struct type
19701 * typemanager.cs (IsUnmanagedtype): Do not recursively check
19702 fields if the fields are static. We only need to check instance
19705 * expression.cs (As.DoResolve): Test for reference type.
19707 * statement.cs (Using.ResolveExpression): Use
19708 ConvertImplicitRequired, not ConvertImplicit which reports an
19710 (Using.ResolveLocalVariableDecls): ditto.
19712 * expression.cs (Binary.ResolveOperator): Report errors in a few
19713 places where we had to.
19715 * typemanager.cs (IsUnmanagedtype): Finish implementation.
19717 2002-10-08 Miguel de Icaza <miguel@ximian.com>
19719 * expression.cs: Use StoreFromPtr instead of extracting the type
19720 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
19722 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
19723 an enumeration value to a System.Enum, but System.Enum is not a
19724 value type, but an class type, so we need to box.
19726 (Expression.ConvertExplicit): One codepath could return
19727 errors but not flag them. Fix this. Fixes #31853
19729 * parameter.cs (Resolve): Do not allow void as a parameter type.
19731 2002-10-06 Martin Baulig <martin@gnome.org>
19733 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
19734 if it's a class type and not a struct. Fixes #31815.
19736 2002-10-06 Martin Baulig <martin@gnome.org>
19738 * statement.cs: Reworked the flow analysis code a bit to make it
19739 usable for dead code elimination.
19741 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19743 * cs-parser.jay: allow empty source files. Fixes bug #31781.
19745 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19747 * expression.cs (ComposedCast.DoResolveType): A quick workaround
19748 to fix the test 165, will investigate deeper.
19750 2002-10-04 Martin Baulig <martin@gnome.org>
19752 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
19753 finally blocks actually work.
19754 (Try.Resolve): We don't need to create a sibling for `finally' if
19755 there is no finally block.
19757 2002-10-04 Martin Baulig <martin@gnome.org>
19759 * class.cs (Constructor.Define): The default accessibility for a
19760 non-default constructor is private, not public.
19762 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19764 * class.cs (Constructor): Make AllowedModifiers public, add
19767 * cs-parser.jay: Perform the modifiers test here, as the
19768 constructor for the Constructor class usually receives a zero
19769 because of the way we create it (first we create, later we
19770 customize, and we were never checking the modifiers).
19772 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
19773 is a version of LookupTypeReflection that includes the type-name
19774 cache. This can be used as a fast path for functions that know
19775 the fully qualified name and are only calling into *.GetType() to
19776 obtain a composed type.
19778 This is also used by TypeManager.LookupType during its type
19781 (LookupType): We now also track the real type name, as sometimes
19782 we can get a quey for the real type name from things like
19783 ComposedCast. This fixes bug 31422.
19785 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
19786 complete type fullname, it does not have to go through the type
19787 resolution system to obtain the composed version of the type (for
19788 obtaining arrays or pointers).
19790 (Conditional.Emit): Use the EmitBoolExpression to
19791 generate nicer code, as requested by Paolo.
19793 (ArrayCreation.CheckIndices): Use the patch from
19794 hwang_rob@yahoo.ca to validate the array initializers.
19796 2002-10-03 Miguel de Icaza <miguel@ximian.com>
19798 * class.cs (ConstructorInitializer.Emit): simplify code by using
19799 Invocation.EmitCall, and at the same time, fix the bugs in calling
19800 parent constructors that took variable arguments.
19802 * ecore.cs (Expression.ConvertNumericExplicit,
19803 Expression.ImplicitNumericConversion): Remove the code that
19804 manually wrapped decimal (InternalTypeConstructor call is now gone
19807 * expression.cs (Cast.TryReduce): Also handle decimal types when
19808 trying to perform a constant fold on the type.
19810 * typemanager.cs (IsUnmanagedtype): Partially implemented.
19812 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
19813 that only turned off an error report, and did nothing else.
19815 2002-10-02 Miguel de Icaza <miguel@ximian.com>
19817 * driver.cs: Handle and ignore /fullpaths
19819 2002-10-01 Miguel de Icaza <miguel@ximian.com>
19821 * expression.cs (Binary.ResolveOperator): Catch the case where
19822 DoNumericPromotions returns true,
19824 (Binary.DoNumericPromotions): Simplify the code, and the tests.
19826 2002-09-27 Miguel de Icaza <miguel@ximian.com>
19828 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
19831 2002-09-26 Miguel de Icaza <miguel@ximian.com>
19833 * ecore.cs (ConvertNumericExplicit): It is not enough that the
19834 conversion exists, but it is also required that the conversion be
19835 performed. This manifested in "(Type64Enum) 2".
19837 * class.cs (TypeManager.AddMethod): The fix is not to change
19838 AddEnum, because that one was using a fully qualified name (every
19839 DeclSpace derivative does), but to change the AddMethod routine
19840 that was using an un-namespaced name. This now correctly reports
19841 the duplicated name.
19843 Revert patch until I can properly fix it. The issue
19844 is that we have a shared Type space across all namespaces
19845 currently, which is wrong.
19847 Options include making the Namespace a DeclSpace, and merge
19848 current_namespace/current_container in the parser.
19850 2002-09-25 Miguel de Icaza <miguel@ximian.com>
19852 * cs-parser.jay: Improve error reporting when we get a different
19853 kind of expression in local_variable_type and
19854 local_variable_pointer_type.
19856 Propagate this to avoid missleading errors being reported.
19858 * ecore.cs (ImplicitReferenceConversion): treat
19859 TypeManager.value_type as a target just like object_type. As
19864 Is valid, and needs to result in the int 1 being boxed before it
19865 is assigned to the value type v.
19867 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
19868 to validate the enumeration name.
19870 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
19871 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
19872 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
19874 * ecore.cs (TryImplicitIntConversion): When doing an
19875 implicit-enumeration-conversion, check if the type is 64-bits and
19876 perform a conversion before passing to EnumConstant.
19878 2002-09-23 Miguel de Icaza <miguel@ximian.com>
19880 * decl.cs (Error_AmbiguousTypeReference); New routine used to
19881 report ambiguous type references. Unlike the MS version, we
19882 report what the ambiguity is. Innovation at work ;-)
19884 (DeclSpace.FindType): Require a location argument to
19885 display when we display an ambiguous error.
19887 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
19889 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
19891 * expression.cs (EmitDynamicInitializers): Apply patch from
19892 hwang_rob@yahoo.ca that fixes the order in which we emit our
19895 2002-09-21 Martin Baulig <martin@gnome.org>
19897 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
19898 delegate takes no arguments.
19900 2002-09-20 Miguel de Icaza <miguel@ximian.com>
19902 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
19905 * expression.cs: Extract the underlying type.
19907 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
19909 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
19911 2002-09-19 Miguel de Icaza <miguel@ximian.com>
19913 * class.cs (TypeContainer.DefineType): We can not use the nice
19914 PackingSize with the size set to 1 DefineType method, because it
19915 will not allow us to define the interfaces that the struct
19918 This completes the fixing of bug 27287
19920 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
19921 means also structs. This fixes part of the problem.
19922 (Expresion.ImplicitReferenceConversionExists): ditto.
19924 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
19925 error if there were no errors reported during the type lookup
19926 process, to avoid duplicates or redundant errors. Without this
19927 you would get an ambiguous errors plus a type not found. We have
19928 beaten the user enough with the first error.
19930 (DeclSparce.FindType): Emit a warning if we have an ambiguous
19933 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
19934 during the resolution process, stop the lookup, this avoids
19935 repeated error reports (same error twice).
19937 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
19939 * typemanager.cs (LookupType): Redo the type lookup code to match
19940 the needs of System.Reflection.
19942 The issue is that System.Reflection requires references to nested
19943 types to begin with a "+" sign instead of a dot. So toplevel
19944 types look like: "NameSpace.TopLevelClass", and nested ones look
19945 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
19948 2002-09-19 Martin Baulig <martin@gnome.org>
19950 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
19951 says that a method always returns or always throws an exception,
19952 don't report the CS0161.
19954 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
19955 set `Returns = new_returns'.
19957 2002-09-19 Martin Baulig <martin@gnome.org>
19959 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
19960 to an enum constant, check for a CS0176.
19962 2002-09-18 Miguel de Icaza <miguel@ximian.com>
19964 * class.cs (TypeContainer.CheckPairedOperators): Now we check
19965 for operators that must be in pairs and report errors.
19967 * ecore.cs (SimpleName.DoResolveType): During the initial type
19968 resolution process, when we define types recursively, we must
19969 check first for types in our current scope before we perform
19970 lookups in the enclosing scopes.
19972 * expression.cs (MakeByteBlob): Handle Decimal blobs.
19974 (Invocation.VerifyArgumentsCompat): Call
19975 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
19976 I thought we were supposed to always call this, but there are a
19977 few places in the code where we dont do it.
19979 2002-09-17 Miguel de Icaza <miguel@ximian.com>
19981 * driver.cs: Add support in -linkres and -resource to specify the
19982 name of the identifier.
19984 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19986 * ecore.cs (StandardConversionExists): Sync with the conversion
19987 code: allow anything-* to void* conversions.
19989 (FindMostSpecificSource): Use an Expression argument
19990 instead of a Type, because we might be handed over a Literal which
19991 gets a few more implicit conversions that plain types do not. So
19992 this information was being lost.
19994 Also, we drop the temporary type-holder expression when not
19997 2002-09-17 Martin Baulig <martin@gnome.org>
19999 * class.cs (PropertyBase.CheckBase): Don't check the base class if
20000 this is an explicit interface implementation.
20002 2002-09-17 Martin Baulig <martin@gnome.org>
20004 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
20005 different `IndexerName' attributes.
20007 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
20008 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
20009 virtual CommonResolve().
20011 2002-09-16 Miguel de Icaza <miguel@ximian.com>
20013 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
20014 and convert that to the UnderlyingType.
20016 * statement.cs (Foreach.Resolve): Indexers are just like variables
20017 or PropertyAccesses.
20019 * cs-tokenizer.cs (consume_string): Track line numbers and columns
20020 inside quoted strings, we were not doing this before.
20022 2002-09-16 Martin Baulig <martin@gnome.org>
20024 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
20025 resolve it. This is needed for the definite assignment check of the
20026 instance expression, fixes bug #29846.
20027 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
20029 2002-09-16 Nick Drochak <ndrochak@gol.com>
20031 * parameter.cs: Fix compile error. Cannot reference static member
20032 from an instance object. Is this an mcs bug?
20034 2002-09-14 Martin Baulig <martin@gnome.org>
20036 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
20037 multiple times. Fixes bug #30295, added test-166.cs.
20039 2002-09-14 Martin Baulig <martin@gnome.org>
20041 * statement.cs (Block.Emit): Don't emit unreachable code.
20042 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
20043 `break' statements.
20044 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
20046 2002-09-14 Martin Baulig <martin@gnome.org>
20048 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
20051 2002-09-14 Martin Baulig <martin@gnome.org>
20053 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
20054 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
20055 be false on the ms runtime.
20057 2002-09-13 Martin Baulig <martin@gnome.org>
20059 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
20060 the CS0038 error message.
20062 2002-09-12 Miguel de Icaza <miguel@ximian.com>
20064 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
20065 constant inside, return it.
20067 2002-09-12 Martin Baulig <martin@gnome.org>
20069 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
20070 implicit conversion can be done between enum types.
20072 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
20073 check whether an implicit conversion to the current enum's UnderlyingType
20074 exists and report an error if not.
20076 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
20077 without debugging support.
20079 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
20080 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
20082 2002-09-12 Martin Baulig <martin@gnome.org>
20084 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
20086 * ecore.cs (IMemberExpr.DeclaringType): New property.
20087 (SimpleName.SimpleNameResolve): Check whether we're accessing a
20088 nonstatic member of an outer type (CS0038).
20090 2002-09-11 Miguel de Icaza <miguel@ximian.com>
20092 * driver.cs: Activate the using-error detector at warning level
20093 4 (at least for MS-compatible APIs).
20095 * namespace.cs (VerifyUsing): Small buglett fix.
20097 * pending.cs (PendingImplementation): pass the container pointer.
20099 * interface.cs (GetMethods): Allow for recursive definition. Long
20100 term, I would like to move every type to support recursive
20101 definitions, not the current ordering mechanism that we have right
20104 The situation is this: Attributes are handled before interfaces,
20105 so we can apply attributes to interfaces. But some attributes
20106 implement interfaces, we will now handle the simple cases
20107 (recursive definitions will just get an error).
20109 * parameter.cs: Only invalidate types at the end if we fail to
20112 2002-09-09 Martin Baulig <martin@gnome.org>
20114 * ecore.cs (PropertyExpr.Emit): Also check for
20115 TypeManager.system_int_array_get_length so this'll also work when
20116 compiling corlib. Fixes #30003.
20118 2002-09-09 Martin Baulig <martin@gnome.org>
20120 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
20121 and throw an exception if we can't get the type's size. Fixed #30040,
20124 2002-09-09 Martin Baulig <martin@gnome.org>
20126 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
20128 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
20129 context. Fixes bug #30027.
20131 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
20132 virtual functions. Fixes bug #30043, added test-164.cs.
20134 2002-09-08 Ravi Pratap <ravi@ximian.com>
20136 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
20138 2002-09-08 Nick Drochak <ndrochak@gol.com>
20140 * driver.cs: Use an object to get the windows codepage since it's not a
20143 2002-09-08 Miguel de Icaza <miguel@ximian.com>
20145 * statement.cs (For.Emit): for infinite loops (test == null)
20146 return whether there is a break inside, not always "true".
20148 * namespace.cs (UsingEntry): New struct to hold the name of the
20149 using definition, the location where it is defined, and whether it
20150 has been used in a successful type lookup.
20152 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
20157 2002-09-06 Ravi Pratap <ravi@ximian.com>
20159 * attribute.cs : Fix incorrect code which relied on catching
20160 a NullReferenceException to detect a null being passed in
20161 where an object was expected.
20163 2002-09-06 Miguel de Icaza <miguel@ximian.com>
20165 * statement.cs (Try): flag the catch variable as assigned
20167 * expression.cs (Cast): Simplified by using ResolveType instead of
20168 manually resolving.
20170 * statement.cs (Catch): Fix bug by using ResolveType.
20172 2002-09-06 Ravi Pratap <ravi@ximian.com>
20174 * expression.cs (BetterConversion): Special case for when we have
20175 a NullLiteral as the argument and we have to choose between string
20176 and object types - we choose string the way csc does.
20178 * attribute.cs (Attribute.Resolve): Catch the
20179 NullReferenceException and report error #182 since the Mono
20180 runtime no more has the bug and having this exception raised means
20181 we tried to select a constructor which takes an object and is
20184 2002-09-05 Ravi Pratap <ravi@ximian.com>
20186 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
20187 message (1502, 1503) when we can't locate a method after overload
20188 resolution. This is much more informative and closes the bug
20191 * interface.cs (PopulateMethod): Return if there are no argument
20192 types. Fixes a NullReferenceException bug.
20194 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
20195 expressions too. Previously we were checking only in one place for
20196 positional arguments leaving out named arguments.
20198 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
20199 type to the enum type is not allowed. Remove code corresponding to
20202 (ConvertNumericExplicit): Allow explicit conversions from
20203 the underlying type to enum type. This precisely follows the spec
20204 and closes a bug filed by Gonzalo.
20206 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20209 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
20211 2002-09-03 Miguel de Icaza <miguel@ximian.com>
20213 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
20214 it was important that we stored the right value after the
20215 reduction in `converted'.
20217 2002-09-04 Martin Baulig <martin@gnome.org>
20219 * location.cs (Location.SymbolDocument): Use full pathnames for the
20222 2002-08-30 Miguel de Icaza <miguel@ximian.com>
20224 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
20225 of the expression resolve mechanism, because that will catch the
20226 SimpleName error failures.
20228 (Conditional): If we can not resolve the
20229 expression, return, do not crash.
20231 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20234 (location): display token name instead of its number.
20236 2002-08-28 Martin Baulig <martin@gnome.org>
20238 * expression.cs (Binary.ResolveOperator): Don't silently return
20239 but return an error if an operator cannot be applied between two
20242 2002-08-28 Martin Baulig <martin@gnome.org>
20244 * class.cs (Constructor.Define): Set the permission attributes
20245 correctly instead of making all constructors public.
20247 2002-08-28 Martin Baulig <martin@gnome.org>
20249 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
20250 for private members before reporting a CS0103; if we find anything,
20253 2002-08-28 Martin Baulig <martin@gnome.org>
20255 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
20256 to check whether `closure_start_type == closure_invocation_type',
20257 we also need to check whether `m.DeclaringType == closure_invocation_type'
20258 before bypassing the permission checks. We might be accessing
20259 protected/private members from the base class.
20260 (TypeManager.RealMemberLookup): Only set private_ok if private
20261 members were requested via BindingFlags.NonPublic.
20263 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
20265 * expression.cs (MemberAccess.ResolveMemberAccess): Set
20266 MethodGroupExpr.IsExplicitImpl if appropriate.
20267 (Invocation.DoResolve): Don't report the CS0120 for explicit
20268 interface implementations.
20270 2002-08-27 Martin Baulig <martin@gnome.org>
20272 * expression.cs (Invocation.DoResolve): If this is a static
20273 method and we don't have an InstanceExpression, we must report
20276 2002-08-25 Martin Baulig <martin@gnome.org>
20278 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
20279 `==' between a valuetype and an object.
20281 2002-08-25 Miguel de Icaza <miguel@ximian.com>
20283 * ecore.cs (TypeExpr): Provide a ToString method.
20285 2002-08-24 Martin Baulig <martin@gnome.org>
20287 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
20288 now called proggie.dbg and it's a binary file.
20290 2002-08-23 Martin Baulig <martin@gnome.org>
20292 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
20294 2002-08-23 Martin Baulig <martin@gnome.org>
20296 * struct.cs (MyStructInfo.ctor): Make this work with empty
20297 structs; it's not allowed to use foreach() on null.
20299 2002-08-23 Martin Baulig <martin@gnome.org>
20301 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
20302 writer the full pathname of the generated assembly.
20304 2002-08-23 Martin Baulig <martin@gnome.org>
20306 * statements.cs (FlowBranching.UsageVector.MergeChildren):
20307 A `finally' block never returns or breaks; improved handling of
20310 2002-08-23 Martin Baulig <martin@gnome.org>
20312 * statement.cs (Throw.Resolve): Allow `throw null'.
20314 2002-08-23 Martin Baulig <martin@gnome.org>
20316 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
20317 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
20318 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
20319 MemberLookup would return a wrong event if this is an explicit
20320 interface implementation and the class has an event with the same
20323 2002-08-23 Martin Baulig <martin@gnome.org>
20325 * statement.cs (Block.AddChildVariableNames): New public method.
20326 (Block.AddChildVariableName): Likewise.
20327 (Block.IsVariableNameUsedInChildBlock): Likewise.
20328 (Block.AddVariable): Check whether a variable name has already
20329 been used in a child block.
20331 * cs-parser.jay (declare_local_variables): Mark all variable names
20332 from the current block as being used in a child block in the
20335 2002-08-23 Martin Baulig <martin@gnome.org>
20337 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
20338 find the symbol writer.
20340 * driver.cs: csc also allows the arguments to /define being
20341 separated by commas, not only by semicolons.
20343 2002-08-23 Martin Baulig <martin@gnome.org>
20345 * interface.cs (Interface.GetMembers): Added static check for events.
20347 2002-08-15 Martin Baulig <martin@gnome.org>
20349 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
20350 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
20352 * ecore.cs (Expression.MemberLookup): Added documentation and explained
20353 why the MethodData.EmitDestructor() change was necessary.
20355 2002-08-20 Martin Baulig <martin@gnome.org>
20357 * class.cs (TypeContainer.FindMembers): Added static check for events.
20359 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
20361 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
20362 use Type.GetEvents(), not Type.FindMembers().
20364 2002-08-20 Martin Baulig <martin@gnome.org>
20366 * decl.cs (MemberCache): Added a special method cache which will
20367 be used for method-only searched. This ensures that a method
20368 search will return a MethodInfo with the correct ReflectedType for
20371 2002-08-20 Martin Baulig <martin@gnome.org>
20373 * decl.cs (DeclSpace.FindMembers): Made this public.
20375 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20377 * delegate.cs: fixed build on windows.
20378 [FIXME: Filed as bug #29150: MCS must report these errors.]
20380 2002-08-19 Ravi Pratap <ravi@ximian.com>
20382 * ecore.cs (StandardConversionExists): Return a false
20383 if we are trying to convert the void type to anything else
20384 since that is not allowed.
20386 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
20387 we flag error 70 in the event an event is trying to be accessed
20388 directly from outside the declaring type.
20390 2002-08-20 Martin Baulig <martin@gnome.org>
20392 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
20393 MemberCache from typemanager.cs to decl.cs.
20395 2002-08-19 Martin Baulig <martin@gnome.org>
20397 * class.cs (TypeContainer): Implement IMemberContainer.
20398 (TypeContainer.DefineMembers): Create the MemberCache.
20399 (TypeContainer.FindMembers): Do better BindingFlags checking; only
20400 return public members if BindingFlags.Public was given, check
20401 whether members are static.
20403 2002-08-16 Martin Baulig <martin@gnome.org>
20405 * decl.cs (DeclSpace.Define): Splitted this in Define and
20406 DefineMembers. DefineMembers is called first and initializes the
20409 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
20410 DefineMembers() on all our DeclSpaces.
20412 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
20413 but call DefineMembers() on all nested interfaces. We call their
20414 Define() in our new Define() function.
20416 * interface.cs (Interface): Implement IMemberContainer.
20417 (Interface.Define): Moved all code except the attribute stuf to
20419 (Interface.DefineMembers): Initialize the member cache.
20421 * typemanager.cs (IMemberFinder): Removed this interface, we don't
20422 need this anymore since we can use MemberCache.FindMembers directly.
20424 2002-08-19 Martin Baulig <martin@gnome.org>
20426 * typemanager.cs (MemberCache): When creating the cache for an
20427 interface type, add all inherited members.
20428 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
20429 to `out bool used_cache' and documented it.
20430 (TypeManager.MemberLookup): If we already used the cache in the first
20431 iteration, we don't need to do the interfaces check.
20433 2002-08-19 Martin Baulig <martin@gnome.org>
20435 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
20436 here from IMemberFinder and don't implement this interface anymore.
20437 (DeclSpace.MemberCache): Moved here from IMemberFinder.
20439 * typemanager.cs (IMemberFinder): This interface is now only used by
20440 classes which actually support the member cache.
20441 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
20442 since we only put DeclSpaces into this Hashtable.
20443 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
20444 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
20446 2002-08-16 Martin Baulig <martin@gnome.org>
20448 * typemanager.cs (ICachingMemberFinder): Removed.
20449 (IMemberFinder.MemberCache): New property.
20450 (TypeManager.FindMembers): Merged this with RealFindMembers().
20451 This function will never be called from TypeManager.MemberLookup()
20452 so we can't use the cache here, just the IMemberFinder.
20453 (TypeManager.MemberLookup_FindMembers): Check whether the
20454 IMemberFinder has a MemberCache and call the cache's FindMembers
20456 (MemberCache): Rewrote larger parts of this yet another time and
20457 cleaned it up a bit.
20459 2002-08-15 Miguel de Icaza <miguel@ximian.com>
20461 * driver.cs (LoadArgs): Support quoting.
20463 (Usage): Show the CSC-like command line arguments.
20465 Improved a few error messages.
20467 2002-08-15 Martin Baulig <martin@gnome.org>
20469 * typemanager.cs (IMemberContainer.Type): New property.
20470 (IMemberContainer.IsInterface): New property.
20472 The following changes are conditional to BROKEN_RUNTIME, which is
20473 defined at the top of the file.
20475 * typemanager.cs (MemberCache.MemberCache): Don't add the base
20476 class'es members, but add all members from TypeHandle.ObjectType
20477 if we're an interface.
20478 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
20479 is the current type.
20480 (MemberCache.CacheEntry.Container): Removed this field.
20481 (TypeHandle.GetMembers): Include inherited members.
20483 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20485 * typemanager.cs: fixed compilation and added a comment on a field that
20488 2002-08-15 Martin Baulig <martin@gnome.org>
20490 * class.cs (ConstructorInitializer.Resolve): In the
20491 Expression.MemberLookup call, use the queried_type as
20494 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
20495 declared' attribute, it's always true.
20496 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
20497 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
20498 temporary wrapper for FindMembers which tells MemberLookup whether
20499 members from the base classes are included in the return value.
20500 This will go away soon.
20501 (TypeManager.MemberLookup): Use this temporary hack here; once the
20502 new MemberCache is completed, we don't need to do the DeclaredOnly
20503 looping here anymore since the MemberCache will take care of this.
20504 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
20505 (MemberCache): When creating the MemberCache for a class, get
20506 members from the current class and all its base classes.
20507 (MemberCache.CacheEntry.Container): New field. This is a
20508 temporary hack until the Mono runtime is fixed to distinguish
20509 between ReflectedType and DeclaringType. It allows us to use MCS
20510 with both the MS runtime and the unfixed Mono runtime without
20511 problems and without accecting performance.
20512 (MemberCache.SearchMembers): The DeclaredOnly looping from
20513 TypeManager.MemberLookup is now done here.
20515 2002-08-14 Martin Baulig <martin@gnome.org>
20517 * statement.cs (MyStructInfo.MyStructInfo): Don't call
20518 Type.GetFields on dynamic types but get the fields from the
20519 corresponding TypeContainer.
20520 (MyStructInfo.GetStructInfo): Added check for enum types.
20522 * typemanager.cs (MemberList.IsSynchronized): Implemented.
20523 (MemberList.SyncRoot): Implemented.
20524 (TypeManager.FilterWithClosure): No need to check permissions if
20525 closure_start_type == closure_invocation_type, don't crash if
20526 closure_invocation_type is null.
20528 2002-08-13 Martin Baulig <martin@gnome.org>
20530 Rewrote TypeContainer.FindMembers to use a member cache. This
20531 gives us a speed increase of about 35% for the self-hosting MCS
20532 build and of about 15-20% for the class libs (both on GNU/Linux).
20534 * report.cs (Timer): New class to get enhanced profiling. This
20535 whole class is "TIMER" conditional since it remarkably slows down
20538 * class.cs (MemberList): New class. This is an IList wrapper
20539 which we're now using instead of passing MemberInfo[]'s around to
20540 avoid copying this array unnecessarily.
20541 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
20542 (ICachingMemberFinder, IMemberContainer): New interface.
20543 (TypeManager.FilterWithClosure): If `criteria' is null, the name
20544 has already been checked, otherwise use it for the name comparision.
20545 (TypeManager.FindMembers): Renamed to RealMemberFinder and
20546 provided wrapper which tries to use ICachingMemberFinder.FindMembers
20547 if possible. Returns a MemberList, not a MemberInfo [].
20548 (TypeHandle): New class, implements IMemberContainer. We create
20549 one instance of this class per type, it contains a MemberCache
20550 which is used to do the member lookups.
20551 (MemberCache): New class. Each instance of this class contains
20552 all members of a type and a name-based hash table.
20553 (MemberCache.FindMembers): This is our new member lookup
20554 function. First, it looks up all members of the requested name in
20555 the hash table. Then, it walks this list and sorts out all
20556 applicable members and returns them.
20558 2002-08-13 Martin Baulig <martin@gnome.org>
20560 In addition to a nice code cleanup, this gives us a performance
20561 increase of about 1.4% on GNU/Linux - not much, but it's already
20562 half a second for the self-hosting MCS compilation.
20564 * typemanager.cs (IMemberFinder): New interface. It is used by
20565 TypeManager.FindMembers to call FindMembers on a TypeContainer,
20566 Enum, Delegate or Interface.
20567 (TypeManager.finder_to_member_finder): New PtrHashtable.
20568 (TypeManager.finder_to_container): Removed.
20569 (TypeManager.finder_to_delegate): Removed.
20570 (TypeManager.finder_to_interface): Removed.
20571 (TypeManager.finder_to_enum): Removed.
20573 * interface.cs (Interface): Implement IMemberFinder.
20575 * delegate.cs (Delegate): Implement IMemberFinder.
20577 * enum.cs (Enum): Implement IMemberFinder.
20579 * class.cs (TypeContainer): Implement IMemberFinder.
20581 2002-08-12 Martin Baulig <martin@gnome.org>
20583 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
20585 2002-08-12 Martin Baulig <martin@gnome.org>
20587 * ecore.cs (ITypeExpression): New interface for expressions which
20589 (TypeExpression): Renamed to TypeLookupExpression.
20590 (Expression.DoResolve): If we're doing a types-only lookup, the
20591 expression must implement the ITypeExpression interface and we
20592 call DoResolveType() on it.
20593 (SimpleName): Implement the new ITypeExpression interface.
20594 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
20595 hack, the situation that we're only looking up types can't happen
20596 anymore when this method is called. Moved the type lookup code to
20597 DoResolveType() and call it.
20598 (SimpleName.DoResolveType): This ITypeExpression interface method
20599 is now doing the types-only lookup.
20600 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
20601 (ResolveFlags): Added MaskExprClass.
20603 * expression.cs (MemberAccess): Implement the ITypeExpression
20605 (MemberAccess.DoResolve): Added support for a types-only lookup
20606 when we're called via ITypeExpression.DoResolveType().
20607 (ComposedCast): Implement the ITypeExpression interface.
20609 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
20610 Expression.Resolve() with ResolveFlags.Type instead.
20612 2002-08-12 Martin Baulig <martin@gnome.org>
20614 * interface.cs (Interface.Define): Apply attributes.
20616 * attribute.cs (Attribute.ApplyAttributes): Added support for
20617 interface attributes.
20619 2002-08-11 Martin Baulig <martin@gnome.org>
20621 * statement.cs (Block.Emit): Only check the "this" variable if we
20622 do not always throw an exception.
20624 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
20625 whether the property has a set accessor.
20627 2002-08-11 Martin Baulig <martin@gnome.org>
20629 Added control flow analysis support for structs.
20631 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
20632 with control flow analysis turned off.
20633 (IVariable): New interface.
20634 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
20635 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
20636 (FieldExpr.DoResolve): Resolve the instance expression with flow
20637 analysis turned off and do the definite assignment check after the
20638 resolving when we know what the expression will resolve to.
20640 * expression.cs (LocalVariableReference, ParameterReference):
20641 Implement the new IVariable interface, only call the flow analysis
20642 code if ec.DoFlowAnalysis is true.
20643 (This): Added constructor which takes a Block argument. Implement
20644 the new IVariable interface.
20645 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
20646 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
20647 This does the definite assignment checks for struct members.
20649 * class.cs (Constructor.Emit): If this is a non-static `struct'
20650 constructor which doesn't have any initializer, call
20651 Block.AddThisVariable() to tell the flow analysis code that all
20652 struct elements must be initialized before control returns from
20655 * statement.cs (MyStructInfo): New public class.
20656 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
20657 argument to this indexer. If non-zero, check an individual struct
20658 member, not the whole struct.
20659 (FlowBranching.CheckOutParameters): Check struct members.
20660 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
20661 overloaded versions of these methods which take an additional
20662 `int field_idx' argument to check struct members.
20663 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
20664 overloaded versions of these methods which take an additional
20665 `string field_name' argument to check struct member.s
20666 (VariableInfo): Implement the IVariable interface.
20667 (VariableInfo.StructInfo): New public property. Returns the
20668 MyStructInfo instance of the variable if it's a struct or null.
20669 (Block.AddThisVariable): New public method. This is called from
20670 Constructor.Emit() for non-static `struct' constructor which do
20671 not have any initializer. It creates a special variable for the
20672 "this" instance variable which will be checked by the flow
20673 analysis code to ensure that all of the struct's fields are
20674 initialized before control returns from the constructor.
20675 (UsageVector): Added support for struct members. If a
20676 variable/parameter is a struct with N members, we reserve a slot
20677 in the usage vector for each member. A struct is considered fully
20678 initialized if either the struct itself (slot 0) or all its
20679 members are initialized.
20681 2002-08-08 Martin Baulig <martin@gnome.org>
20683 * driver.cs (Driver.MainDriver): Only report an error CS5001
20684 if there were no compilation errors.
20686 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
20687 `UnsafeContext' property to determine whether the parent is in
20688 unsafe context rather than checking the parent's ModFlags:
20689 classes nested in an unsafe class are unsafe as well.
20691 2002-08-08 Martin Baulig <martin@gnome.org>
20693 * statement.cs (UsageVector.MergeChildren): Distinguish between
20694 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
20695 we return. Added test17() and test18() to test-154.cs.
20697 2002-08-08 Martin Baulig <martin@gnome.org>
20699 * typemanager.cs (TypeManager.FilterWithClosure): If we have
20700 Family access, make sure the invoking type isn't a subclass of the
20701 queried type (that'd be a CS1540).
20703 * ecore.cs (Expression.MemberLookup): Added overloaded version of
20704 this method which takes an additional `Type invocation_type'.
20706 * expression.cs (BaseAccess.DoResolve): Use the base type as
20707 invocation and query type.
20708 (MemberAccess.DoResolve): If the lookup failed and we're about to
20709 report a CS0122, try a lookup with the ec.ContainerType - if this
20710 succeeds, we must report a CS1540.
20712 2002-08-08 Martin Baulig <martin@gnome.org>
20714 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
20715 (MethodGroupExpr): Implement the IMemberExpr interface.
20717 * expression (MemberAccess.ResolveMemberAccess): No need to have
20718 any special code for MethodGroupExprs anymore, they're now
20721 2002-08-08 Martin Baulig <martin@gnome.org>
20723 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
20724 Family, FamANDAssem and FamORAssem permissions.
20725 (TypeManager.IsSubclassOrNestedChildOf): New public method.
20727 2002-08-08 Martin Baulig <martin@gnome.org>
20729 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
20730 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
20733 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
20735 * driver.cs: implemented /resource option to embed managed resources.
20737 2002-08-07 Martin Baulig <martin@gnome.org>
20739 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
20740 (FieldBase.HasFieldInitializer): New public property.
20741 (FieldBase.GetInitializerExpression): New public method. Resolves and
20742 returns the field initializer and makes sure it is only resolved once.
20743 (TypeContainer.EmitFieldInitializers): Call
20744 FieldBase.GetInitializerExpression to get the initializer, this ensures
20745 that it isn't resolved multiple times.
20747 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
20748 the resolving process (SimpleName/MemberLookup) that we're currently
20749 emitting a field initializer (which must not access any instance members,
20750 this is an error CS0236).
20752 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
20753 argument, if the `IsFieldInitializer' flag is set, we must report and
20754 error CS0236 and not an error CS0120.
20756 2002-08-07 Martin Baulig <martin@gnome.org>
20758 * ecore.cs (IMemberExpr): New public interface.
20759 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
20760 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
20761 if the expression is an IMemberExpr.
20763 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
20764 to be null, implicitly default to `this' if we're non-static in
20765 this case. Simplified the code a lot by using the new IMemberExpr
20766 interface. Also fixed bug #28176 here.
20768 2002-08-06 Martin Baulig <martin@gnome.org>
20770 * cs-parser.jay (SimpleLookup): Removed. We need to create
20771 ParameterReferences during semantic analysis so that we can do a
20772 type-only search when resolving Cast, TypeOf and SizeOf.
20773 (block): Pass the `current_local_parameters' to the Block's
20776 * class.cs (ConstructorInitializer): Added `Parameters parameters'
20777 argument to the constructor.
20778 (ConstructorInitializer.Resolve): Create a temporary implicit
20779 block with the parameters.
20781 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
20782 references here if we aren't doing a type-only search.
20784 * statement.cs (Block): Added constructor which takes a
20785 `Parameters parameters' argument.
20786 (Block.Parameters): New public property.
20788 * support.cs (InternalParameters.Parameters): Renamed `parameters'
20789 to `Parameters' and made it public readonly.
20791 2002-08-06 Martin Baulig <martin@gnome.org>
20793 * ecore.cs (Expression.Warning): Made this public as well.
20795 * report.cs (Report.Debug): Print the contents of collections.
20797 2002-08-06 Martin Baulig <martin@gnome.org>
20799 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
20800 used to tell Resolve() which kinds of expressions it may return.
20801 (Expression.Resolve): Added overloaded version of this method which
20802 takes a `ResolveFlags flags' argument. This can be used to tell
20803 Resolve() which kinds of expressions it may return. Reports a
20805 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
20806 ResolveFlags.SimpleName.
20807 (Expression.Error118): Added overloaded version of this method which
20808 takes a `ResolveFlags flags' argument. It uses the flags to determine
20809 which kinds of expressions are allowed.
20811 * expression.cs (Argument.ResolveMethodGroup): New public method.
20812 Resolves an argument, but allows a MethodGroup to be returned.
20813 This is used when invoking a delegate.
20815 * TODO: Updated a bit.
20817 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20819 Fixed compilation with csc.
20821 * ecore.cs: Expression.Error made public. Is this correct? Should
20822 Warning be made public too?
20824 * expression.cs: use ea.Location instead of ea.loc.
20825 [FIXME: Filed as bug #28607: MCS must report these errors.]
20827 2002-08-06 Martin Baulig <martin@gnome.org>
20829 * ecore.cs (Expression.loc): Moved the location here instead of
20830 duplicating it in all derived classes.
20831 (Expression.Location): New public property.
20832 (Expression.Error, Expression.Warning): Made them non-static and
20833 removed the location argument.
20834 (Expression.Warning): Added overloaded version which takes an
20835 `int level' argument.
20836 (Expression.Error118): Make this non-static and removed the
20837 expression and location arguments.
20838 (TypeExpr): Added location argument to the constructor.
20840 * expression.cs (StaticCallExpr): Added location argument to
20842 (Indirection, PointerArithmetic): Likewise.
20843 (CheckedExpr, UnCheckedExpr): Likewise.
20844 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
20845 (StringPtr): Likewise.
20848 2002-08-05 Martin Baulig <martin@gnome.org>
20850 * expression.cs (BaseAccess.DoResolve): Actually report errors.
20852 * assign.cs (Assign.DoResolve): Check whether the source
20853 expression is a value or variable.
20855 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
20856 while resolving the corresponding blocks.
20858 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
20859 an error, don't silently return null.
20861 * statement.cs (Block.AddVariable): Do the error reporting here
20862 and distinguish between CS0128 and CS0136.
20863 (Block.DoResolve): Report all unused labels (warning CS0164).
20864 (LabeledStatement): Pass the location to the constructor.
20865 (LabeledStatement.HasBeenReferenced): New property.
20866 (LabeledStatement.Resolve): Set it to true here.
20868 * statement.cs (Return.Emit): Return success even after reporting
20869 a type mismatch error (CS0126 or CS0127), this is what csc does and
20870 it avoids confusing the users with any consecutive errors.
20872 2002-08-05 Martin Baulig <martin@gnome.org>
20874 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
20876 * const.cs (Const.LookupConstantValue): Catch circular definitions.
20878 * expression.cs (MemberAccess.DoResolve): Silently return if an
20879 error has already been reported.
20881 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
20882 error has already been reported.
20884 2002-08-05 Martin Baulig <martin@gnome.org>
20886 * statement.cs (UsageVector): Only initialize the `parameters'
20887 vector if we actually have any "out" parameters.
20889 2002-08-05 Martin Baulig <martin@gnome.org>
20891 * expression.cs (Binary.ResolveOperator): When combining delegates,
20892 they must have the same type.
20894 2002-08-05 Martin Baulig <martin@gnome.org>
20896 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
20897 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
20898 work with the ms runtime and we also don't need it: if we're a
20899 PropertyBuilder and not in the `indexer_arguments' hash, then we
20900 are a property and not an indexer.
20902 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
20903 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
20904 since the latter one doesn't work with the ms runtime.
20906 2002-08-03 Martin Baulig <martin@gnome.org>
20908 Fixed bugs #27998 and #22735.
20910 * class.cs (Method.IsOperator): New public field.
20911 (Method.CheckBase): Report CS0111 if there's already a method
20912 with the same parameters in the current class. Report CS0508 when
20913 attempting to change the return type of an inherited method.
20914 (MethodData.Emit): Report CS0179 if a method doesn't have a body
20915 and it's not marked abstract or extern.
20916 (PropertyBase): New abstract base class for Property and Indexer.
20917 (PropertyBase.CheckBase): Moved here from Property and made it work
20919 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
20920 the same so we can reuse it there.
20921 (Property, Indexer): Derive from PropertyBase.
20922 (MethodSignature.inheritable_property_signature_filter): New delegate
20923 to find properties and indexers.
20925 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
20926 argument and improved error reporting.
20928 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
20929 EmptyReadOnlyParameters and made it a property.
20931 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
20932 version of this method which takes a `PropertyInfo indexer'.
20933 (TypeManager.RegisterIndexer): New method.
20935 * class.cs: Added myself as author of this file :-)
20937 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20939 * class.cs: fixed compilation on windoze.
20941 2002-08-03 Martin Baulig <martin@gnome.org>
20943 * interface.cs (Interface.GetInterfaceBases): Check whether all
20944 base interfaces are at least as accessible than the current one.
20946 * class.cs (TypeContainer.GetClassBases): Check whether base types
20947 are at least as accessible than the current type.
20948 (TypeContainer.AsAccessible): Implemented and made non-static.
20949 (MemberBase.CheckParameters): Report errors if the accessibility
20952 * delegate.cs (Delegate.Delegate): The default visibility is
20953 internal for top-level types and private for nested types.
20954 (Delegate.Define): Report errors if the accessibility checks fail.
20956 * enum.cs (Enum.Enum): The default visibility is internal for
20957 top-level types and private for nested types.
20958 (Enum.DefineType): Compute the correct visibility.
20960 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
20961 function which takes a `bool is_toplevel' instead of a TypeContainer.
20963 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
20966 2002-08-02 Martin Baulig <martin@gnome.org>
20968 * expression.cs (LocalVariableReferenc): Added constructor which
20969 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
20970 (LocalVariableReference.IsReadOnly): New property.
20971 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
20972 variable is readonly, use our own readonly flag to do this; you can
20973 use the new constructor to get a writable reference to a read-only
20976 * cs-parser.jay (foreach_statement, using_statement): Get a writable
20977 reference to the local variable.
20979 2002-08-01 Miguel de Icaza <miguel@ximian.com>
20981 * rootcontext.cs (ResolveCore): Also include System.Exception
20983 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
20984 we reach an EmptyStatement.
20986 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
20989 * expression.cs (Binary.ResolveOperator): Check error result in
20992 use brtrue/brfalse directly and avoid compares to null.
20994 2002-08-02 Martin Baulig <martin@gnome.org>
20996 * class.cs (TypeContainer.Define): Define all nested interfaces here.
20997 Fixes bug #28407, added test-155.cs.
20999 2002-08-01 Martin Baulig <martin@gnome.org>
21001 * class.cs (Event.EmitDefaultMethod): Make this work with static
21002 events. Fixes #28311, added verify-3.cs.
21004 2002-08-01 Martin Baulig <martin@gnome.org>
21006 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
21007 `is_disposable' fields.
21008 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
21009 `hm.is_disposable' if we're using the collection pattern.
21010 (Foreach.EmitCollectionForeach): Use the correct type for the
21011 enumerator's local variable, only emit the try/finally block if
21012 necessary (fixes #27713).
21014 2002-08-01 Martin Baulig <martin@gnome.org>
21016 * ecore.cs (Expression.report118): Renamed to Error118 and made
21019 * statement.cs (Throw.Resolve): Check whether the expression is of
21020 the correct type (CS0118) and whether the type derives from
21021 System.Exception (CS0155).
21022 (Catch.Resolve): New method. Do the type lookup here and check
21023 whether it derives from System.Exception (CS0155).
21024 (Catch.CatchType, Catch.IsGeneral): New public properties.
21026 * typemanager.cs (TypeManager.exception_type): Added.
21028 2002-07-31 Miguel de Icaza <miguel@ximian.com>
21030 * driver.cs: Updated About function.
21032 2002-07-31 Martin Baulig <martin@gnome.org>
21034 Implemented Control Flow Analysis.
21036 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
21037 (EmitContext.CurrentBranching): Added.
21038 (EmitContext.StartFlowBranching): Added.
21039 (EmitContext.EndFlowBranching): Added.
21040 (EmitContext.KillFlowBranching): Added.
21041 (EmitContext.IsVariableAssigned): Added.
21042 (EmitContext.SetVariableAssigned): Added.
21043 (EmitContext.IsParameterAssigned): Added.
21044 (EmitContext.SetParameterAssigned): Added.
21045 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
21046 Added control flow analysis stuff here.
21048 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
21049 resolve the expression as lvalue.
21050 (LocalVariableReference.DoResolve): Check whether the variable has
21051 already been assigned.
21052 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
21053 the parameter as assigned here.
21054 (ParameterReference.DoResolve): Check whether the parameter has already
21056 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
21057 expression as lvalue.
21059 * statement.cs (FlowBranching): New class for the flow analysis code.
21060 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
21061 (LabeledStatement.IsDefined): New public property.
21062 (LabeledStatement.AddUsageVector): New public method to tell flow
21063 analyis that the label may be reached via a forward jump.
21064 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
21066 (VariableInfo.Number): New public field. This is used by flow analysis
21067 to number all locals of a block.
21068 (Block.CountVariables): New public property. This is the number of
21069 local variables in this block (including the locals from all parent
21071 (Block.EmitMeta): Number all the variables.
21073 * statement.cs: Added flow analysis support to all classes.
21075 2002-07-31 Martin Baulig <martin@gnome.org>
21077 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
21078 To get debugging messages, compile mcs with /define:MCS_DEBUG and
21079 then use this argument.
21081 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
21083 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
21084 use this to specify /define options.
21086 2002-07-29 Martin Baulig <martin@gnome.org>
21088 * statement.cs (Fixed): Moved all code that does variable lookups
21089 and resolvings from Emit to Resolve.
21091 * statement.cs (For): Moved all code that does variable lookups
21092 and resolvings from Emit to Resolve.
21094 * statement.cs (Using): Moved all code that does variable lookups
21095 and resolvings from Emit to Resolve.
21097 2002-07-29 Martin Baulig <martin@gnome.org>
21099 * attribute.cs (Attribute.Resolve): Explicitly catch a
21100 System.NullReferenceException when creating the
21101 CustromAttributeBuilder and report a different warning message.
21103 2002-07-29 Martin Baulig <martin@gnome.org>
21105 * support.cs (ParameterData.ParameterName): Added method to
21106 get the name of a parameter.
21108 * typemanager.cs (TypeManager.IsValueType): New public method.
21110 2002-07-29 Martin Baulig <martin@gnome.org>
21112 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
21113 is a flag which specifies that it's either ref or out.
21114 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
21115 the out parameter to `out Parameter.Modifier mod', also set the
21116 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
21118 * support.cs (InternalParameters.ParameterModifier): Distinguish
21119 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21120 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21122 * expression.cs (Argument.GetParameterModifier): Distinguish
21123 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21124 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21126 2002-07-29 Martin Baulig <martin@gnome.org>
21128 * expression.cs (ParameterReference.ParameterReference): Added
21129 `Location loc' argument to the constructor.
21131 * cs-parser.jay: Pass location to ParameterReference.
21133 2002-07-28 Miguel de Icaza <miguel@ximian.com>
21135 * statement.cs (Try): Initialize the location.
21137 * cs-parser.jay: pass location to Try.
21139 * expression.cs (Unary.Reduce): Change the prototype to return
21140 whether a constant fold could be performed or not. The result is
21141 returned in an out parameters. In the case of Indirection and
21142 AddressOf, we want to perform the full tests.
21144 2002-07-26 Miguel de Icaza <miguel@ximian.com>
21146 * statement.cs (Statement.Emit): Flag dead code.
21148 2002-07-27 Andrew Birkett <andy@nobugs.org>
21150 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
21152 2002-07-27 Martin Baulig <martin@gnome.org>
21154 * class.cs (MethodData.Define): Put back call to
21155 TypeManager.AddMethod(), accidentally commented this out.
21157 * report.cs (Debug): New public method to print debugging information,
21158 this is `[Conditional ("DEBUG")]'.
21160 2002-07-26 Martin Baulig <martin@gnome.org>
21162 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
21163 (switch_statement): Push the current_block to the switch_stack and
21164 pop it again when we're done with the switch.
21165 (switch_section): The new block is a child of the current_block.
21166 Fixes bug #24007, added test-152.cs.
21168 2002-07-27 Martin Baulig <martin@gnome.org>
21170 * expression.cs (Invocation.EmitArguments): When calling a varargs
21171 function with only its fixed arguments, we need to pass an empty
21174 2002-07-27 Martin Baulig <martin@gnome.org>
21176 Mono 0.13 has been released.
21178 2002-07-25 Miguel de Icaza <miguel@ximian.com>
21180 * driver.cs: Rename --resource to --linkres, because that is what
21181 we do currently, we dont support --resource yet.
21183 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
21185 2002-07-25 Martin Baulig <martin@gnome.org>
21187 * class.cs (MethodData): New public class. This is a `method builder'
21188 class for a method or one accessor of a Property/Indexer/Event.
21189 (MethodData.GetMethodFlags): Moved here from MemberBase.
21190 (MethodData.ApplyAttributes): Likewise.
21191 (MethodData.ApplyObsoleteAttribute): Likewise.
21192 (MethodData.ApplyConditionalAttribute): Likewise.
21193 (MethodData.ApplyDllImportAttribute): Likewise.
21194 (MethodData.CheckAbstractAndExternal): Likewise.
21195 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
21196 (MethodData.Emit): Formerly known as Method.Emit().
21197 (MemberBase): Moved everything which was specific to a single
21198 accessor/method to MethodData.
21199 (Method): Create a new MethodData and call Define() and Emit() on it.
21200 (Property, Indexer, Event): Create a new MethodData objects for each
21201 accessor and call Define() and Emit() on them.
21203 2002-07-25 Martin Baulig <martin@gnome.org>
21205 Made MethodCore derive from MemberBase to reuse the code from there.
21206 MemberBase now also checks for attributes.
21208 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
21209 (MemberBase.GetMethodFlags): Moved here from class Method and marked
21211 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
21212 `CallingConventions cc' and `Attributes opt_attrs' arguments.
21213 (MemberBase.ApplyAttributes): New virtual method; applies the
21214 attributes to a method or accessor.
21215 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
21216 (MemberBase.ApplyConditionalAttribute): Likewise.
21217 (MemberBase.ApplyDllImportAttribute): Likewise.
21218 (MemberBase.CheckAbstractAndExternal): Likewise.
21219 (MethodCore.ParameterTypes): This is now a property instead of a
21220 method, it's initialized from DoDefineParameters().
21221 (MethodCore.ParameterInfo): Removed the set accessor.
21222 (MethodCore.DoDefineParameters): New protected virtual method to
21223 initialize ParameterTypes and ParameterInfo.
21224 (Method.GetReturnType): We can now simply return the MemberType.
21225 (Method.GetMethodFlags): Override the MemberBase version and add
21226 the conditional flags.
21227 (Method.CheckBase): Moved some code from Define() here, call
21228 DoDefineParameters() here.
21229 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
21230 here to avoid some larger code duplication.
21231 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
21232 ensure that abstract and external accessors don't declare a body.
21234 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
21235 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
21236 lookup in the attribute's parent classes, so we need to abort as soon
21237 as we found the first match.
21238 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
21239 the attribute has no arguments.
21241 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
21244 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21246 * cs-parser.jay: reverted previous patch.
21248 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21250 * cs-parser.jay: fixed bug #22119.
21252 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21254 * attribute.cs: fixed compilation. The error was:
21255 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
21256 be assigned to before control leaves the current method."
21257 [FIXME: Filed as bug #28186: MCS must report this error.]
21259 2002-07-25 Martin Baulig <martin@gnome.org>
21261 * attribute.cs (Attribute.Conditional_GetConditionName): New static
21262 method to pull the condition name ouf of a Conditional attribute.
21263 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
21264 the obsolete message and error flag out of an Obsolete attribute.
21266 * class.cs (Method.GetMethodFlags): New public method to get the
21267 TypeManager.MethodFlags for this method.
21268 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
21270 (Method.Define): Get and apply the Obsolete and Conditional attributes;
21271 if we're overriding a virtual function, set the new private variable
21272 `parent_method'; call the new TypeManager.AddMethod().
21274 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
21275 the MethodBuilder and the Method in a PtrHashtable.
21276 (TypeManager.builder_to_method): Added for this purpose.
21277 (TypeManager.MethodFlags): Added IsObsoleteError.
21278 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
21279 Obsolete and Conditional arguments in MethodBuilders. If we discover
21280 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
21281 the message from the attribute.
21283 2002-07-24 Martin Baulig <martin@gnome.org>
21285 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
21286 preprocessor directives, ensure that the argument to #define/#undef is
21287 exactly one identifier and that it's actually an identifier.
21289 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
21292 2002-07-24 Martin Baulig <martin@gnome.org>
21294 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
21295 initialize it to TypeManager.object_type in the constructor.
21296 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
21297 of the `hm.get_current' method if we're using the collection pattern.
21298 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
21299 for the explicit conversion to make it work when we're using the collection
21300 pattern and the `Current' property has a different return type than `object'.
21303 2002-07-24 Martin Baulig <martin@gnome.org>
21305 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
21306 does not match, but don't report any errors. This method is called in
21307 order for all methods in a MethodGroupExpr until a matching method is
21308 found, so we don't want to bail out if the first method doesn't match.
21309 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
21310 matches, report the 123. Fixes #28070.
21312 2002-07-24 Martin Baulig <martin@gnome.org>
21314 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
21315 TypeManager.TypeToCoreType() to the top of the method so the
21316 following equality checks will work. Fixes #28107.
21318 2002-07-24 Martin Baulig <martin@gnome.org>
21320 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
21321 operand is of type uint, and the other operand is of type sbyte,
21322 short or int, the operands are converted to type long." -
21323 Actually do what this comment already told us. Fixes bug #28106,
21326 2002-07-24 Martin Baulig <martin@gnome.org>
21328 * class.cs (MethodBase): New abstract class. This is now a base
21329 class for Property, Indexer and Event to avoid some code duplication
21330 in their Define() and DefineMethods() methods.
21331 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
21332 generic methods for Define() and DefineMethods().
21333 (FieldBase): Derive from MemberBase, not MemberCore.
21334 (Property): Derive from MemberBase, not MemberCore.
21335 (Property.DefineMethod): Moved all the code from this method to the
21336 new MethodBase.DefineAccessor(), just call it with appropriate
21338 (Property.Define): Call the new Property.DoDefine(), this does some
21339 sanity checks and we don't need to duplicate the code everywhere.
21340 (Event): Derive from MemberBase, not MemberCore.
21341 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
21342 accessors, this will also make them work with interface events.
21343 (Indexer): Derive from MemberBase, not MemberCore.
21344 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
21345 (Indexer.Define): Use the new MethodBase functions.
21347 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
21348 argument to the constructor.
21349 (Interface.FindMembers): Added support for interface events.
21350 (Interface.PopluateEvent): Implemented.
21352 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
21354 2002-07-22 Miguel de Icaza <miguel@ximian.com>
21356 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
21357 but this is required to check for a method name being the same as
21358 the containing class.
21362 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21364 * interface.cs: initialize variable.
21366 2002-07-23 Martin Baulig <martin@gnome.org>
21368 Implemented the IndexerName attribute in interfaces.
21370 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
21371 name if this is an explicit interface implementation.
21372 (Indexer.InterfaceIndexerName): New public variable. If we're
21373 implementing an interface indexer, this is the IndexerName in that
21374 interface. Otherwise, it's the IndexerName.
21375 (Indexer.DefineMethod): If we're implementing interface indexer,
21376 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
21377 and Pending.ImplementIndexer methods.
21378 (Indexer.Define): Also define the PropertyBuilder if we're
21379 implementing an interface indexer and this is neither an explicit
21380 interface implementation nor do the IndexerName match the one in
21383 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
21384 If a method is defined here, then we always need to create a proxy
21385 for it. This is used when implementing interface indexers.
21386 (Pending.IsInterfaceIndexer): New public method.
21387 (Pending.ImplementIndexer): New public method.
21388 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
21389 This is used when implementing interface indexers to define a proxy
21391 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
21392 define a proxy if necessary.
21394 * interface.cs (Interface.IndexerName): New public variable.
21395 (Interface.PopulateIndexer): Set the IndexerName.
21396 (Interface.DefineIndexers): New private method. Populate all the
21397 indexers and make sure their IndexerNames match.
21399 * typemanager.cs (IndexerPropertyName): Added support for interface
21402 2002-07-22 Martin Baulig <martin@gnome.org>
21404 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
21405 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
21406 ret if HasReturnLabel.
21407 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
21410 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
21411 and set the ec.LoopBeginTryCatchLevel.
21412 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
21413 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
21414 the current ec.TryCatchLevel, the branch goes out of an exception
21415 block. In this case, we need to use Leave and not Br.
21417 2002-07-22 Martin Baulig <martin@gnome.org>
21419 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
21420 block unless the block does not always return or it is contained in
21421 another try { ... } catch { ... } block. Fixes bug #26506.
21422 Added verify-1.cs to the test suite.
21424 2002-07-22 Martin Baulig <martin@gnome.org>
21426 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
21427 then we do not always return. Fixes bug #24985.
21429 2002-07-22 Martin Baulig <martin@gnome.org>
21431 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
21432 lookup on a per-class level; ie. walk up the class hierarchy until we
21433 found at least one applicable method, then choose the best among them.
21434 Fixes bug #24463 and test-29.cs.
21436 2002-07-22 Martin Baulig <martin@gnome.org>
21438 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
21439 return types of the methods. The return type is not part of the
21440 signature and we must not check it to make the `new' modifier work.
21441 Fixes bug #27999, also added test-147.cs.
21442 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
21444 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
21445 on the method's return type.
21447 2002-07-21 Martin Baulig <martin@gnome.org>
21449 * assign.cs: Make this work if the rightmost source is a constant and
21450 we need to do an implicit type conversion. Also adding a few more tests
21451 to test-38.cs which should have caught this.
21453 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
21454 target in the makefile for this. The makefile.gnu is primarily intended
21455 for end-users who don't want to debug the compiler.
21457 2002-07-21 Martin Baulig <martin@gnome.org>
21459 * assign.cs: Improved the Assign class so it can now handle embedded
21460 assignments (X = Y = Z = something). As a side-effect this'll now also
21461 consume less local variables. test-38.cs now passes with MCS, added
21462 a few new test cases to that test.
21464 2002-07-20 Martin Baulig <martin@gnome.org>
21466 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
21467 instructions. Fixes bug #27977, also added test-146.cs.
21469 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21471 * cs-tokenizer.cs: fixed getHex ().
21473 2002-07-19 Martin Baulig <martin@gnome.org>
21475 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
21476 not Type.GetType() to lookup the array type. This is needed when
21477 we're constructing an array of a user-defined type.
21478 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
21479 single-dimensional arrays, but also for single-dimensial arrays of
21482 2002-07-19 Martin Baulig <martin@gnome.org>
21484 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
21485 this function is called, it's not allowed to share LocalBuilders
21486 among ILGenerators.
21488 2002-07-19 Martin Baulig <martin@gnome.org>
21490 * expression.cs (Argument.Resolve): Report an error 118 when trying
21491 to pass a type as argument.
21493 2002-07-18 Martin Baulig <martin@gnome.org>
21495 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
21496 Conv_R_Un for the signed `long' type.
21498 2002-07-15 Miguel de Icaza <miguel@ximian.com>
21500 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
21501 `expr' for the temporary result, as that will fail if we do
21502 multiple resolves on the same expression.
21504 2002-07-05 Miguel de Icaza <miguel@ximian.com>
21506 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
21507 ec.TypeContainer for looking up aliases.
21509 * class.cs (TypeContainer): Remove LookupAlias from here.
21511 * decl.cs (DeclSpace); Move here.
21513 2002-07-01 Miguel de Icaza <miguel@ximian.com>
21515 * class.cs (FindMembers): Only call filter if the constructor
21516 bulider is not null.
21518 Also handle delegates in `NestedTypes' now. Now we will perform
21519 type lookups using the standard resolution process. This also
21522 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
21523 This uses Expressions (the limited kind that can be parsed by the
21524 tree) instead of strings.
21526 * expression.cs (ComposedCast.ToString): Implement, used to flag
21527 errors since now we have to render expressions.
21529 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
21532 * ecore.cs (SimpleName.ToString): ditto.
21534 * cs-parser.jay: Instead of using strings to assemble types, use
21535 Expressions to assemble the type (using SimpleName, ComposedCast,
21536 MemberAccess). This should fix the type lookups in declarations,
21537 because we were using a different code path for this.
21539 * statement.cs (Block.Resolve): Continue processing statements
21540 even when there is an error.
21542 2002-07-17 Miguel de Icaza <miguel@ximian.com>
21544 * class.cs (Event.Define): Also remove the `remove' method from
21545 the list of pending items.
21547 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
21548 generate more compact code.
21550 2002-07-17 Martin Baulig <martin@gnome.org>
21552 * const.cs (Const.LookupConstantValue): Add support for constant
21553 `unchecked' and `checked' expressions.
21554 Also adding test case test-140.cs for this.
21556 2002-07-17 Martin Baulig <martin@gnome.org>
21558 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
21559 check whether mi.ReturnType implements the IEnumerator interface; the
21560 `==' and the IsAssignableFrom() will fail in this situation.
21562 2002-07-16 Ravi Pratap <ravi@ximian.com>
21564 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
21567 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21569 * expression.cs: fixed bug #27811.
21571 2002-07-14 Miguel de Icaza <miguel@ximian.com>
21573 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
21574 Molaro: when we are a ref, the value already contains a pointer
21575 value, do not take the address of it.
21577 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21578 * removed mb-parser.jay and mb-tokenizer.cs
21580 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21582 * expression.cs: check against the building corlib void type.
21584 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
21586 * ecore.cs: fix for valuetype static readonly fields: when
21587 initializing them, we need their address, not the address of a copy.
21589 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
21591 * typemanager.cs: register also enum_type in corlib.
21593 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21595 * class.cs: allow calling this (but not base) initializers in structs.
21597 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
21599 * ecore.cs: make sure we compare against the building base types
21602 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
21604 * typemanager.cs: fix TypeToCoreType() to handle void and object
21605 (corlib gets no more typerefs after this change).
21607 2002-07-12 Miguel de Icaza <miguel@ximian.com>
21609 * expression.cs (ArrayCreation.EmitArrayArguments): use
21610 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
21612 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
21613 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
21614 array indexes, the runtime actually forbids them.
21616 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
21617 for array arguments here.
21619 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
21620 instead of the default for ValueTypes.
21622 (New.DoEmit): Use IsValueType instead of
21623 IsSubclassOf (value_type)
21624 (New.DoResolve): ditto.
21625 (Invocation.EmitCall): ditto.
21627 * assign.cs (Assign): ditto.
21629 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
21630 Statements *are* currently doing part of their resolution during
21633 Expressions do always resolve during resolve, but statements are
21634 only required to propagate resolution to their children.
21636 2002-07-11 Miguel de Icaza <miguel@ximian.com>
21638 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
21640 (LoadAssembly): Do not add the dll if it is already specified
21642 (MainDriver): Add the System directory to the link path at the end,
21643 after all the other -L arguments.
21645 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
21646 wrong opcode for loading bytes and bools (ldelem.i1 instead of
21647 ldelem.u1) and using the opposite for sbytes.
21649 This fixes Digger, and we can finally run it.
21651 * driver.cs (UnixParseOption): Move the option parsing here.
21652 (CSCParseOption): Implement CSC-like parsing of options.
21654 We now support both modes of operation, the old Unix way, and the
21655 new CSC-like way. This should help those who wanted to make cross
21656 platform makefiles.
21658 The only thing broken is that /r:, /reference: and /lib: are not
21659 implemented, because I want to make those have the same semantics
21660 as the CSC compiler has, and kill once and for all the confussion
21661 around this. Will be doing this tomorrow.
21663 * statement.cs (Unsafe.Resolve): The state is checked during
21664 resolve, not emit, so we have to set the flags for IsUnsfe here.
21666 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21668 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
21669 not catch the Error_ObjectRefRequired in SimpleName (as it is
21670 possible to have a class/instance variable name that later gets
21671 deambiguated), we have to check this here.
21673 2002-07-10 Ravi Pratap <ravi@ximian.com>
21675 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
21676 make static and put into Expression.
21678 (Event.Define): Register the private field of the event with the
21679 TypeManager so that GetFieldFromEvent can get at it.
21681 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
21682 keep track of the private field associated with an event which
21685 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
21688 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
21690 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21692 * expression.cs (Binary.EmitBranchable): this routine emits the
21693 Binary expression in a branchable context. This basically means:
21694 we need to branch somewhere, not just get the value on the stack.
21696 This works together with Statement.EmitBoolExpression.
21698 * statement.cs (Statement.EmitBoolExpression): Use
21701 2002-07-09 Miguel de Icaza <miguel@ximian.com>
21703 * statement.cs (For): Reduce the number of jumps in loops.
21705 (For): Implement loop inversion for the For statement.
21707 (Break): We can be breaking out of a Try/Catch controlled section
21708 (foreach might have an implicit try/catch clause), so we need to
21709 use Leave instead of Br.
21711 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
21712 now). If the instace expression supports IMemoryLocation, we use
21713 the AddressOf method from the IMemoryLocation to extract the
21714 address instead of emitting the instance.
21716 This showed up with `This', as we were emitting the instance
21717 always (Emit) instead of the Address of This. Particularly
21718 interesting when This is a value type, as we dont want the Emit
21719 effect (which was to load the object).
21721 2002-07-08 Miguel de Icaza <miguel@ximian.com>
21723 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
21725 * statement.cs (Checked): Set the CheckedState during the resolve
21726 process too, as the ConvCast operations track the checked state on
21727 the resolve process, and not emit.
21729 * cs-parser.jay (namespace_member_declaration): Flag that we have
21730 found a declaration when we do. This is used to flag error 1529
21732 * driver.cs: Report ok when we display the help only.
21734 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
21736 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
21738 2002-07-04 Miguel de Icaza <miguel@ximian.com>
21740 * cs-tokenizer.cs (define): We also have to track locally the
21741 defines. AllDefines is just used for the Conditional Attribute,
21742 but we also need the local defines for the current source code.
21744 2002-07-03 Miguel de Icaza <miguel@ximian.com>
21746 * statement.cs (While, For, Do): These loops can exit through a
21747 Break statement, use this information to tell whether the
21748 statement is the last piece of code.
21750 (Break): Flag that we break.
21752 * codegen.cs (EmitContexts): New `Breaks' state variable.
21754 2002-07-03 Martin Baulig <martin@gnome.org>
21756 * class.cs (TypeContainer.MethodModifiersValid): Allow override
21757 modifiers in method declarations in structs. Otherwise, you won't
21758 be able to override things like Object.Equals().
21760 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21762 * class.cs (Method, Property, Indexer): Do not allow the public
21763 modifier to be used in explicit interface implementations.
21765 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
21766 override modifiers in method declarations in structs
21768 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
21770 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
21771 integer or real overflow, report an error
21773 2002-07-02 Martin Baulig <martin@gnome.org>
21775 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
21776 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
21777 to tell the runtime about our newly created System.Object and
21778 System.ValueType types.
21780 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21782 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
21783 struct instead of Ldarg/Starg.
21785 2002-07-02 Martin Baulig <martin@gnome.org>
21787 * expression.cs (Indirection.Indirection): Call
21788 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
21790 2002-07-02 Martin Baulig <martin@gnome.org>
21792 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
21793 ValueType, call TypeManager.TypeToCoreType() on it.
21794 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
21795 the OpCodes.Newarr argument.
21797 2002-07-02 Martin Baulig <martin@gnome.org>
21799 * expression.cs (Invocation.EmitCall): When compiling corlib,
21800 replace all calls to the system's System.Array type to calls to
21801 the newly created one.
21803 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
21804 System.Array methods.
21805 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
21806 from the system's System.Array type which must be replaced.
21808 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
21810 * typemanager.cs: load unverifiable_code_ctor so we can build
21811 corlib using the correct type. Avoid using GetTypeCode() with
21813 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
21814 TypeManager.object_type to allow building corlib.
21816 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
21818 * ecore.cs: handle System.Enum separately in LoadFromPtr().
21820 2002-07-01 Martin Baulig <martin@gnome.org>
21822 * class.cs: Make the last change actually work, we need to check
21823 whether `ifaces != null' to avoid a crash.
21825 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21827 * class.cs: when we build structs without fields that implement
21828 interfaces, we need to add the interfaces separately, since there is
21829 no API to both set the size and add the interfaces at type creation
21832 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21834 * expression.cs: the dimension arguments to the array constructors
21835 need to be converted if they are a long.
21837 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
21839 * class.cs: don't emit ldarg.0 if there is no parent constructor
21840 (fixes showstopper for corlib).
21842 2002-06-29 Martin Baulig <martin@gnome.org>
21844 MCS now compiles corlib on GNU/Linux :-)
21846 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
21847 ie. check for MethodImplOptions.InternalCall.
21849 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
21850 and TypeManager.attribute_type are null, so we must explicitly check
21851 whether parent is not null to find out whether it's an attribute type.
21852 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
21853 and SetBuilder, not only if the property is neither abstract nor external.
21854 This is necessary to set the MethodImplOptions on the accessor methods.
21855 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
21856 SetBuilder, see Property.Emit().
21858 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
21859 populate "System.Object", "System.ValueType" and "System.Attribute" since
21860 they've already been populated from BootCorlib_PopulateCoreTypes().
21862 2002-06-29 Martin Baulig <martin@gnome.org>
21864 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
21865 is the NullLiteral, we also need to make sure that target_type is not
21868 2002-06-29 Martin Baulig <martin@gnome.org>
21870 * rootcontext.cs (RootContext.ResolveCore): We must initialize
21871 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
21872 before calling BootstrapCorlib_ResolveDelegate ().
21874 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21876 * statement.cs: fixed build-breaker. All tests passed ok.
21878 2002-06-27 Martin Baulig <martin@gnome.org>
21880 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
21881 for System.Decimal when compiling corlib.
21883 2002-06-27 Martin Baulig <martin@gnome.org>
21885 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
21886 switch blocks which contain nothing but a default clause.
21888 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
21890 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
21892 2002-06-27 Martin Baulig <martin@gnome.org>
21894 * ecore.cs (PropertyExpr.PropertyExpr): Call
21895 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
21897 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
21898 is already a TypeBuilder.
21900 2002-06-27 Martin Baulig <martin@gnome.org>
21902 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
21903 `target_type == TypeManager.array_type', not IsAssignableFrom() in
21904 the "from an array-type to System.Array" case. This makes it work
21905 when compiling corlib.
21907 2002-06-27 Martin Baulig <martin@gnome.org>
21909 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
21910 non-static PropertyExpr, set its InstanceExpression. This makes
21911 the `ICollection.Count' property work in System/Array.cs.
21913 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
21915 * driver.cs: Made error handling more consistent. Errors now
21916 tracked by Report class, so many methods which used to return int
21917 now return void. Main() now prints success/failure and
21918 errors/warnings message.
21920 Renamed '--probe' compiler argument to '--expect-error'. Removed
21921 the magic number return values (123 and 124). Now, if the
21922 expected error occurs, the compiler exits with success (exit value
21923 0). If the compilation completes without seeing that particular
21924 error, the compiler exits with failure (exit value 1). The
21925 makefile in mcs/errors has been changed to handle the new behaviour.
21927 * report.cs: Made 'expected error' number a property and renamed
21928 it from 'Probe' to 'ExpectedError'.
21930 * genericparser.cs: Removed error handling support, since it is
21931 now all done by Report class.
21933 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
21934 class, so parse() no longer returns an int.
21936 * namespace.cs: Use Report.Error instead of GenericParser.error
21938 2002-06-22 Miguel de Icaza <miguel@ximian.com>
21940 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
21941 TypeContainer.AddOperator): At the front of the list put the
21942 explicit implementations, so they get resolved/defined first.
21944 2002-06-21 Miguel de Icaza <miguel@ximian.com>
21946 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
21947 interface type is implemented by this TypeContainer. Used during
21948 explicit interface implementation.
21950 (Property.Define, Indexer.Define, Method.Define): Validate that
21951 the given interface in the explicit implementation is one of the
21952 base classes for the containing type.
21954 Also if we are explicitly implementing an interface, but there is
21955 no match in the pending implementation table, report an error.
21957 (Property.Define): Only define the property if we are
21958 not explicitly implementing a property from an interface. Use the
21959 correct name also for those properties (the same CSC uses,
21960 although that is really not needed).
21962 (Property.Emit): Do not emit attributes for explicitly implemented
21963 properties, as there is no TypeBuilder.
21965 (Indexer.Emit): ditto.
21967 Hiding then means that we do not really *implement* a pending
21968 implementation, which makes code fail.
21970 2002-06-22 Martin Baulig <martin@gnome.org>
21972 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
21973 the return value of Object.GetType(). [FIXME: we need to do this whenever
21974 we get a type back from the reflection library].
21976 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
21978 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
21980 2002-06-20 Miguel de Icaza <miguel@ximian.com>
21982 * attribute.cs: Return null if we can not look up the type.
21984 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
21985 the interface types found.
21987 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
21988 interface types found.
21990 * typemanager.cs (GetInterfaces): Make this routine returns alll
21991 the interfaces and work around the lame differences between
21992 System.Type and System.Reflection.Emit.TypeBuilder in the results
21993 result for GetInterfaces.
21995 (ExpandInterfaces): Given an array of interface types, expand and
21996 eliminate repeated ocurrences of an interface. This expands in
21997 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
22000 2002-06-21 Martin Baulig <martin@gnome.org>
22002 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
22005 2002-06-21 Martin Baulig <martin@gnome.org>
22007 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
22008 and called with one of the core types, return the corresponding typebuilder for
22011 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
22014 2002-06-21 Martin Baulig <martin@gnome.org>
22016 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
22017 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
22018 (Expression.ConvertReferenceExplicit): Likewise.
22020 * expression.cs (ElementAccess.DoResolve): Likewise.
22021 (ElementAccess.DoResolveLValue): Likewise.
22023 2002-06-10 Martin Baulig <martin@gnome.org>
22025 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
22026 add the "value" parameter to the parameter list.
22028 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
22031 2002-06-19 Miguel de Icaza <miguel@ximian.com>
22033 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
22034 the argument to an int, uint, long or ulong, per the spec. Also
22035 catch negative constants in array creation.
22037 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
22039 * class.cs: do not allow the same interface to appear twice in
22040 the definition list.
22042 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
22044 * ecore.cs: don't use ldlen with System.Array.
22046 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
22048 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
22050 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
22052 * modifiers.cs: produce correct field attributes for protected
22053 internal. Easy fix so miguel can work on ther harder stuff:-)
22055 2002-06-18 Miguel de Icaza <miguel@ximian.com>
22057 * pending.cs: New file. Move the code from class.cs here.
22058 Support clearning the pending flag for all methods (when not doing
22059 explicit interface implementation).
22061 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
22063 * rootcontext.cs: added a couple more types needed to bootstrap.
22065 2002-06-17 Miguel de Icaza <miguel@ximian.com>
22067 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
22068 constructor in the type, instead of any constructor in the type
22069 hierarchy. Thanks to Paolo for finding this bug (it showed up as
22070 a bug in the Mono runtime when applying the params attribute).
22072 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
22073 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
22075 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
22077 * expression.cs (Unary.ResolveOperator): Use TypeManager
22078 to resolve the type.
22080 2002-06-13 Ravi Pratap <ravi@ximian.com>
22082 * cs-parser.jay (enum_member_declaration): Pass in the attributes
22085 * enum.cs (AddEnumMember): Add support to store the attributes associated
22086 with each member too.
22088 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
22089 field builders too - this takes care of the enum member case.
22091 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
22093 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
22094 address-of operator on both value types and pointers.
22096 2002-06-10 Martin Baulig <martin@gnome.org>
22098 * interface.cs (Interface.PopulateIndexer): Add the indexer's
22099 PropertyBuilder to the `property_builders' list.
22101 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
22102 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
22103 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
22104 find any indexers which are inherited from an interface.
22106 2002-06-09 Martin Baulig <martin@gnome.org>
22108 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
22109 the same type as the constant if necessary. There's also a test-130.cs
22112 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
22114 * typemanager.cs (TypeManager.ChangeType): Previously known as
22115 Enum.ChangeEnumType().
22117 2002-06-09 Martin Baulig <martin@gnome.org>
22119 * expression.cs (Cast.TryReduce): Added support for consts.
22121 2002-06-08 Ravi Pratap <ravi@ximian.com>
22123 * class.cs (Accessor): Hold attributes information so we can pass
22126 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
22127 Modify to pass in attributes attached to the methods.
22129 (add_accessor_declaration, remove_accessor_declaration): Ditto.
22131 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
22132 to handle the Accessor kind :-)
22134 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
22136 2002-06-08 Martin Baulig <martin@gnome.org>
22138 * expression.cs (Unary.TryReduceNegative): Added support for
22141 2002-06-08 Martin Baulig <martin@gnome.org>
22143 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
22144 name can't be found in the `defined_names' - the caller will do a
22145 MemberLookup in this case and thus find methods in System.Enum
22146 such as Enum.IsDefined().
22148 2002-06-08 Martin Baulig <martin@gnome.org>
22150 * enum.cs (Enum.ChangeEnumType): This is a custom version of
22151 Convert.ChangeType() which works with TypeBuilder created types.
22152 (Enum.LookupEnumValue, Enum.Define): Use it here.
22154 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
22155 `TypeBuilder.BaseType != null' check.
22156 (TypeContainer.FindMembers): Only lookup parent members if we
22157 actually have a parent.
22158 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
22159 (ConstructorInitializer.Resolve): Likewise.
22161 * interface.cs (Interface.FindMembers): Added
22162 `TypeBuilder.BaseType != null' check.
22164 * rootcontext.cs (RootContext.ResolveCore): Added
22165 "System.Runtime.CompilerServices.IndexerNameAttribute" to
22166 classes_second_stage.
22168 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
22169 debug_type and trace_type when compiling with --nostdlib.
22171 2002-06-07 Martin Baulig <martin@gnome.org>
22173 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
22174 (AddField): Set it to true when adding a non-static field.
22175 (DefineType): Use `have_nonstatic_fields' to find out whether we
22176 have non-static fields, not `Fields != null'.
22178 2002-06-02 Miguel de Icaza <miguel@ximian.com>
22180 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
22181 dereferencing a null on the static-field code path)
22183 2002-05-30 Martin Baulig <martin@gnome.org>
22185 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
22186 to take command line arguments. Use reflection to call the new
22187 custom `Initialize' function on the symbol writer and pass it the
22188 command line arguments.
22190 * driver.cs (--debug-args): New command line argument to pass command
22191 line arguments to the symbol writer.
22193 2002-05-28 Miguel de Icaza <miguel@ximian.com>
22195 * assign.cs (DoResolve): Forgot to do the implicit conversion to
22196 the target type for indexers and properties. Thanks to Joe for
22199 2002-05-27 Miguel de Icaza <miguel@ximian.com>
22201 * typemanager.cs (MethodFlags): returns the method flags
22202 (Obsolete/ShouldIgnore) that control warning emission and whether
22203 the invocation should be made, or ignored.
22205 * expression.cs (Invocation.Emit): Remove previous hack, we should
22206 not do this on matching a base type, we should do this based on an attribute
22208 Only emit calls to System.Diagnostics.Debug and
22209 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
22210 on the command line.
22212 * rootcontext.cs: Global settings for tracing and debugging.
22214 * cs-tokenizer.cs (define): New utility function to track
22215 defines. Set the global settings for TRACE and DEBUG if found.
22217 2002-05-25 Ravi Pratap <ravi@ximian.com>
22219 * interface.cs (Populate*): Pass in the TypeContainer as well as
22220 the DeclSpace as parameters so that we can create EmitContexts and
22221 then use that to apply attributes etc.
22223 (PopulateMethod, PopulateEvent, PopulateProperty)
22224 (PopulateIndexer): Apply attributes everywhere.
22226 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
22229 (ApplyAttributes): Update accordingly.
22231 We now apply interface attributes for all members too.
22233 2002-05-26 Miguel de Icaza <miguel@ximian.com>
22235 * class.cs (Indexer.Define); Correctly check if we are explicit
22236 implementation (instead of checking the Name for a ".", we
22237 directly look up if the InterfaceType was specified).
22239 Delay the creation of the PropertyBuilder.
22241 Only create the PropertyBuilder if we are not an explicit
22242 interface implementation. This means that explicit interface
22243 implementation members do not participate in regular function
22244 lookups, and hence fixes another major ambiguity problem in
22245 overload resolution (that was the visible effect).
22247 (DefineMethod): Return whether we are doing an interface
22250 * typemanager.cs: Temporary hack until we get attributes in
22251 interfaces (Ravi is working on that) and we get IndexerName
22252 support in interfaces.
22254 * interface.cs: Register the indexers as properties.
22256 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
22257 warning, I have verified that this is a bug in the .NET runtime
22258 (JavaScript suffers of the same problem).
22260 * typemanager.cs (MemberLookup): When looking up members for
22261 interfaces, the parent of an interface is the implicit
22262 System.Object (so we succeed in searches of Object methods in an
22263 interface method invocation. Example: IEnumerable x; x.ToString
22266 2002-05-25 Miguel de Icaza <miguel@ximian.com>
22268 * class.cs (Event): Events should also register if they do
22269 implement the methods that an interface requires.
22271 * typemanager.cs (MemberLookup); use the new GetInterfaces
22274 (GetInterfaces): The code used to lookup interfaces for a type is
22275 used in more than one place, factor it here.
22277 * driver.cs: Track the errors at the bottom of the file, we kept
22280 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
22281 instance if the method we are calling is static!
22283 2002-05-24 Miguel de Icaza <miguel@ximian.com>
22285 * attribute.cs (ApplyAttributes): Make this function filter out
22286 the IndexerName attribute (as that attribute in reality is never
22287 applied) and return the string constant for the IndexerName
22290 * class.cs (TypeContainer.Emit): Validate that all the indexers
22291 have the same IndexerName attribute, and if so, set the
22292 DefaultName attribute on the class.
22294 * typemanager.cs: The return value might contain other stuff (not
22295 only methods). For instance, consider a method with an "Item"
22296 property and an Item method.
22298 * class.cs: If there is a problem with the parameter types,
22301 2002-05-24 Ravi Pratap <ravi@ximian.com>
22303 * ecore.cs (ImplicitConversionExists): Wrapper function which also
22304 looks at user defined conversion after making a call to
22305 StandardConversionExists - we need this for overload resolution.
22307 * expression.cs : Update accordingly the various method calls.
22309 This fixes 2 bugs filed against implicit user defined conversions
22311 2002-05-22 Miguel de Icaza <miguel@ximian.com>
22313 * statement.cs: Track the result of the assignment.
22315 2002-05-21 Miguel de Icaza <miguel@ximian.com>
22317 * expression.cs (MemberAccess): Improved error reporting for
22318 inaccessible members.
22320 2002-05-22 Martin Baulig <martin@gnome.org>
22322 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
22323 itself with debugging support.
22325 2002-05-22 Martin Baulig <martin@gnome.org>
22327 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
22328 Removed, this isn't needed anymore.
22330 2002-05-20 Martin Baulig <martin@gnome.org>
22332 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
22333 be underlying type for an enum.
22335 2002-05-20 Miguel de Icaza <miguel@ximian.com>
22337 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
22338 that splits out the loading of just the core types.
22340 * rootcontext.cs (ResolveCore): Split the struct resolution in
22341 two, so we can load the enumeration underlying types before any
22344 * expression.cs (Is): Bandaid until we fix properly Switch (see
22345 bug #24985 for details).
22347 * typemanager.cs (ImplementsInterface): The hashtable will contain
22348 a null if there are no interfaces implemented.
22350 2002-05-18 Miguel de Icaza <miguel@ximian.com>
22352 * cs-parser.jay (indexer_declarator): It is fine to have array
22355 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22357 * typemanager.cs: (RegisterBuilder): New function used to register
22358 TypeBuilders that implement interfaces. Since
22359 TypeBuilder.GetInterfaces (as usual) does not work with lame
22361 (AddUserType): register interfaces.
22363 (ImplementsInterface): Use the builder_to_ifaces hash if we are
22364 dealing with TypeBuilder. Also, arrays are showing up as
22365 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
22366 methods can not be invoked on them!
22368 * ecore.cs (ExplicitReferenceConversionExists): Made public.
22369 (ImplicitReferenceConversionExists): Split out from
22370 StandardConversionExists.
22372 * expression.cs (As): We were only implementing one of the three
22373 cases for the as operator. We now implement them all.
22374 (Is): Implement the various other cases for Is as well.
22376 * typemanager.cs (CACHE): New define used to control if we want or
22377 not the FindMembers cache. Seems to have a negative impact on
22378 performance currently
22380 (MemberLookup): Nested types have full acess to
22381 enclosing type members
22383 Remove code that coped with instance/static returns for events, we
22384 now catch this in RealFindMembers.
22386 (RealFindMembers): only perform static lookup if the instance
22387 lookup did not return a type or an event.
22389 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22391 * assign.cs (CompoundAssign): We pass more semantic information
22392 now to Compound Assignments than we did before: now we have all
22393 the information at hand, and now we resolve the target *before* we
22394 do the expression expansion, which allows the "CacheValue" method
22395 to have the effect we intended (before, a [x] += 1 would generate
22396 two differen ArrayAccess expressions from the ElementAccess,
22397 during the resolution process).
22399 (CompoundAssign.DoResolve): Resolve target and original_source here.
22401 2002-05-16 Miguel de Icaza <miguel@ximian.com>
22403 * expression.cs (ArrayAccess): dropped debugging information.
22405 * typemanager.cs: Small bug fix: I was always returning i_members,
22406 instead of one of i_members or s_members (depending on which had
22409 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
22410 method is invoked before any code generation takes place, and it
22411 is a mechanism to inform that the expression will be invoked more
22412 than once, and that the method should use temporary values to
22413 avoid having side effects
22415 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
22417 * ecore.cs (Expression.CacheTemporaries): Provide empty default
22420 * expression.cs (Indirection, ArrayAccess): Add support for
22421 CacheTemporaries in these two bad boys.
22423 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
22424 ldobj or ldind_ref.
22425 (StoreFromPtr): Handle stobj as well.
22427 * expression.cs (UnaryMutator): Share more code.
22429 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
22430 down: I was not tracking the Filter function as well, which
22431 was affecting the results of the cache.
22433 2002-05-15 Miguel de Icaza <miguel@ximian.com>
22435 * attribute.cs: Remove the hack to handle the CharSet property on
22438 2002-05-14 Miguel de Icaza <miguel@ximian.com>
22440 * attribute.cs (DoResolve): More uglyness, we now only try to
22441 resolve the attribute partially, to extract the CharSet
22442 information (only if we are a StructLayout attribute). Otherwise
22444 (GetExtraTypeInfo): Add some code to conditionally kill in the
22445 future this. I am more and more convinced that the .NET
22446 framework has special code to handle the attribute setting on
22449 * expression.cs (IsParamsMethodApplicable): Revert my previous
22450 foreach change here, it was wrong.
22452 2002-05-13 Miguel de Icaza <miguel@ximian.com>
22454 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
22455 (pp_expr): do not abort on unknown input, just return.
22456 (eval): abort if there are pending chars.
22458 * attribute.cs (Attribute.Resolve): Positional parameters are
22459 optional. Deal with that case.
22461 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
22462 the Ansi/Unicode/Auto information for the type.
22464 (TypeContainer.DefineType): instantiate the EmitContext here, as
22465 we will be using it during the type definition (to resolve
22466 attributes) and during the emit phase.
22468 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
22469 to pull type information out of the attributes
22471 (Attribute.Resolve): track the constructor builder, and allow for
22472 multiple invocations (structs and classes will use this).
22474 * ecore.cs (MemberLookupFinal): new version with all the
22475 parameters customizable.
22477 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
22478 constructors. Return if the result value is null (as the error
22479 would have been flagged already by MemberLookupFinal)
22481 Do not allow instances of abstract classes or interfaces to be
22484 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
22485 We have to compare the assembly property here when dealing with
22486 FamANDAssem and Assembly access modifiers, because we might be
22487 creating an assembly from *modules* (that means that we are not
22488 getting TypeBuilders for types defined in other modules that are
22489 part of this assembly).
22491 (Method.Emit): If the method is marked abstract and has a body,
22494 (TypeContainer.DefineMembers): If both the defined member and the
22495 parent name match are methods, then do not emit any warnings: let
22496 the Method.Define routine take care of flagging warnings. But if
22497 there is a mismatch (method overrides something else, or method is
22498 overriwritten by something, then emit warning).
22500 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
22501 set to null, this means `do not check for the return type on the
22504 (Method.Define): set the return type for the method signature to
22505 null, so that we get methods with the same name and parameters and
22506 different return types. This is used to flag warning 114 (you are
22507 hiding a method, and you probably want to use the new/override
22510 * typemanager.cs (MemberLookup): Implemented proper access
22511 control, closing a long standing set of bug reports. The problem
22512 was that the Framework only has two bits: Public and NonPublic,
22513 and NonPublic includes private and protected methods, but we need
22514 to enforce the FamANDAssem, FamOrAssem and Family.
22516 2002-05-11 Miguel de Icaza <miguel@ximian.com>
22518 * statement.cs (GotoCase): Return true: Ammounts to giving up
22519 knowledge on whether we return or not, and letting the other case
22520 be responsible for it.
22522 2002-05-10 Miguel de Icaza <miguel@ximian.com>
22524 * driver.cs: Do not load directories for each file processed, only
22525 do it if there is a pattern.
22527 * ecore.cs: Report readonly assigns here as well, as we might have
22528 been resolved only by MemberAccess.
22530 (SimpleName.SimpleNameResolve): Also be useful for LValue
22531 resolution. We need this to propagate assign to local readonly variables
22533 * typemanager.cs: Use a ptrhashtable for the criteria, because we
22534 do not want to reuse potential criteria memory.
22536 * class.cs (MyEventBuilder): Set reflected_type;
22538 * ecore.cs (Constantify): Added support for constifying bools.
22540 (RootContext.LookupType): Added a cache for values looked up in
22541 the declaration space.
22543 * typemanager.cs (FindMembers): Now is a front-end to
22544 RealFindMembers, and provides a two-level hashtable-based cache to
22547 15% performance improvement: from 22.5 to 19.2 seconds.
22549 * expression.cs (IsParamsMethodApplicable): use foreach.
22550 (Invocation.DoResolve): ditto.
22551 (New.DoResolve): ditto.
22552 (ArrayCreation.DoResolve): ditto.
22554 * ecore.cs (FindMostEncompassingType): use foreach.
22556 * delegate.cs (NewDelegate.DoResolve): Use foreach
22558 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
22559 (RemoveMethods): use foreach.
22561 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
22562 nested foreach statements instead of for, and also break out of
22563 the inner loop once a match is found.
22565 (Invocation.OverloadResolve): Use foreach, simplify the code.
22567 2002-05-08 Miguel de Icaza <miguel@ximian.com>
22569 * cfold.cs (BinaryFold): During an enumeration evaluation context,
22570 we actually unwrap the expression to allow for extra information
22573 * expression.cs: Use Shr_Un on unsigned operations.
22575 2002-05-08 Ravi Pratap <ravi@ximian.com>
22577 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
22578 applicable operators was not being considered correctly. This closes
22579 the bug Miguel reported.
22581 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
22583 * attribute.cs: check that the type derives from System.Attribute
22584 and report the correct error in that case (moved the duplicate code to
22585 its own method, too).
22587 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
22589 * attribute.cs: lookup attribute type name as the spec says: first the
22590 bare attribute name and then name + "Attribute" (nant compiles with
22591 mcs after this fix).
22593 2002-05-07 Miguel de Icaza <miguel@ximian.com>
22595 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
22596 Because of the way we parse things, we should try to see if a
22597 UIntConstant can fit in an integer.
22599 2002-05-07 Ravi Pratap <ravi@ximian.com>
22601 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
22602 when we are in an explicit context.
22604 (ConvertReferenceExplicit): When converting from Iface type S to Class
22605 T make sure the rules are implemented as an OR.
22607 * parameter.cs (ParameterType): Make it a property for now although the
22608 purpose really isn't anything immediate.
22610 * expression.cs (Is*Applicable): Do better checking on the parameter type
22611 of a ref/out parameter. The ones from the system assemblies are already
22612 marked with the correct type so we don't need to do any correction.
22614 * ecore.cs (StandardConversionExists): Conversion from Interface types to
22615 the object type is standard too so include that.
22617 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22619 * ecore.cs (StandardConversionExists): Augment with missing code:
22620 deal with IntConstant, LongConstants and Enumerations.
22622 * assign.cs: Report the error, instead of failing silently
22624 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
22625 typecontainer that they are declared, because the
22626 typecontainer/namespace will have the list of using clauses that
22627 need to be applied.
22629 Assembly Attributes were escaping the normal registration
22632 (EmitCode): Apply attributes within an EmitContext that represents
22633 the container they were declared on.
22635 * cs-parser.jay: Track bases for structs. How did I get this wrong?
22637 2002-05-06 Ravi Pratap <ravi@ximian.com>
22639 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
22640 Revamp completely - make much cleaner as we now operate only
22643 (FindMostSpecificSource, FindMostSpecificTarget): New methods
22644 to implement the logic detailed in the spec more correctly.
22646 (UserDefinedConversion): Update accordingly.
22648 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22650 * statement.cs: Return flow analysis information up.
22652 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
22655 (token): Do not consume an extra character before calling
22658 2002-05-06 Piers Haken <piersh@friskit.com>
22660 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
22662 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22664 * class.cs (Constructor.Emit): Set the IsStatic flag in the
22665 EmitContext during the instance constructor initializer
22666 resolution, to stop access to instance variables.
22668 This is mandated by the spec, last paragraph of the `constructor
22669 initializers' section.
22671 2002-05-05 Miguel de Icaza <miguel@ximian.com>
22673 * cs-parser.jay, class.cs (Accessor): new class used to represent
22674 an accessor (get or set). In the past we used `null' to represent
22675 a missing accessor. But this is ambiguous because there was no
22676 way to tell in abstract indexers/properties if one of them was
22679 Now there is a way of addressing that.
22681 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
22682 instead of FindMembers.
22684 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
22685 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
22687 * attribute.cs: Treat indexers and properties as the same in terms
22688 of applying attributes
22690 * ecore.cs (FindMostEncompassedType): Use statically initialized
22691 EmptyExpressions()s like we do elsewhere to avoid creating useless
22692 objects (and we take this out of the tight loop).
22694 (GetConversionOperators): Move the code to extract the actual
22695 operators to a separate routine to clean things up.
22697 2002-05-04 Miguel de Icaza <miguel@ximian.com>
22699 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
22700 events are always registered FieldBuilders.
22702 * class.cs (FieldBase): New class shared by Fields
22704 * delegate.cs: If we are a toplevel delegate, use our full name.
22705 If we are a nested delegate, then only use our tail name.
22707 2002-05-02 Ravi Pratap <ravi@ximian.com>
22709 * expression.cs (IsApplicable): Ensure that we add the "&" to
22710 ref/out types before comparing it with the type of the argument.
22712 (IsParamsMethodApplicable): Ditto.
22714 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
22717 * delegate.cs : Handle the case when we have more than one applicable
22718 method. Flag an error only when we finish checking all.
22720 2002-05-02 Miguel de Icaza <miguel@ximian.com>
22722 * expression.cs: Add support for boolean static initializers.
22724 2002-05-01 Miguel de Icaza <miguel@ximian.com>
22726 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
22728 * parameter.cs (ComputeParameterTypes,
22729 ComputeAndDefineParameterTypes): Better error handling: now we
22730 clear the `types' cache if we fail during any of the type lookups.
22731 We also return the status code correctly to our caller
22733 * delegate.cs: If we fail to define a delegate, abort the extra
22736 * expression.cs (Binary.ResolveOperator): for
22737 operator==(object,object) and operator !=(object, object) we also
22738 have to verify that there is an implicit conversion from one to
22741 (ArrayAccess.DoResolve): Array Access can operate on
22744 2002-04-30 Miguel de Icaza <miguel@ximian.com>
22746 * assign.cs (CompoundAssign): A new class used as a "flag" that
22747 the assignment actually is happening as part of a compound
22748 assignment operator.
22750 During compound assignment, a few new rules exist to enable things
22757 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
22758 to the type of x) if y is implicitly convertible to the type of x,
22759 and the operator is a builtin operator and the return type of the
22760 operator is explicitly convertible to the type of x.
22762 * rootcontext.cs: Reset warning level to 2. 4 catches various
22763 "interesting" features in mcs, we must clean this up at some
22764 point, but currently am trying to kill other bugs ;-)
22766 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
22767 in container classes as well.
22769 * expression.cs (Binary.ResolveOperator): Handle string case
22770 before anything else (as operator overloading does emit an error
22771 before doing anything else).
22773 This code could go away when we move to a table driven model, but
22774 i could not come up with a good plan last night.
22776 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
22778 * typemanager.cs (CSharpName): reimplementation using regex.
22779 * class.cs: added null check for fields in Emit
22780 * rootcontext.cs: set warninglevel to 4
22782 2002-04-29 Miguel de Icaza <miguel@ximian.com>
22784 * typemanager.cs (CSharpName): reimplemented with Lupus
22787 2002-04-28 Miguel de Icaza <miguel@ximian.com>
22789 * statement.cs (If): correclty implement Resolve, because we were
22790 not catching sem errors in there. The same process is needed
22792 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
22795 (Statement.Warning_DeadCodeFound): Factorize code.
22796 (While): Report dead code here too.
22798 (Statement): Added Resolve virtual method to allow
22799 for resolution split from the emit code.
22801 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22803 * statement.cs (EmitBoolExpression): No longer try to resolve the
22805 (MakeBoolean): New utility function that resolve, implicitly
22806 converts to boolean and tags the expression.
22809 (If, Do): Implement dead code elimination.
22810 (While): Implement loop inversion
22812 (Do, While, For, If): Resolve the expression prior to calling our
22815 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
22818 - added method Report28 (warning: program has more than one entry point)
22819 - added method IsEntryPoint, implements paragraph 10.1 of the spec
22820 - modified method Method.Define, the part at the end of the method
22822 * rootcontext.cs: added static public Location EntryPointLocation;
22824 * ../errors/cs0028.cs : Add test case for the above warning.
22827 - modified method CSharpName to allow arrays of primitive type to
22828 be printed nicely (e.g. instead of System.Int32[][] it now prints
22830 - added method CSharpSignature: returns the signature of a method
22831 in string format to be used in reporting errors, warnings, etc.
22833 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
22836 2002-04-26 Ravi Pratap <ravi@ximian.com>
22838 * delegate.cs (Define): Fix extremely silly bug where I was
22839 setting the type of the 'object' parameter of the BeginInvoke
22840 method to System.IAsyncResult instead of System.Object ;-)
22842 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22844 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
22847 (Constructor.Emit): return if we fail to initialize the
22848 constructor. Another door closed!
22850 * expression.cs (New.DoResolve): Improve error message (from -6 to
22851 1501). Use DeclaredOnly lookup to find the exact constructor.
22853 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
22854 loop. This is useful.
22856 * cs-parser.jay: Adjust the default parameters so that destructors
22857 have the proper signature.
22859 2002-04-26 Martin Baulig <martin@gnome.org>
22861 * driver.cs (LoadAssembly): If `assembly' contains any characters
22862 which are only valid in path names and not in assembly names
22863 (currently slash, backslash and point), use Assembly.LoadFrom ()
22864 instead of Assembly.Load () on the `assembly' (before iteration
22865 over the link_paths).
22867 2002-04-26 Martin Baulig <martin@gnome.org>
22869 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
22871 2002-04-25 Miguel de Icaza <miguel@ximian.com>
22873 * class.cs (Property): use the new typemanager.MemberLookup
22875 (TypeContainer.MemberLookup): Implement using the
22876 TypeManager.MemberLookup now.
22878 * typemanager.cs: Make MemberLookup a function of the TypeManager,
22879 and return MemberInfos, so that these can be used without an
22880 EmitContext (what we had before).
22882 2002-04-24 Miguel de Icaza <miguel@ximian.com>
22884 * expression.cs: Fix the case where the argument to params if the
22885 type of the params. I omitted handling this before. Fixed
22887 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22889 * driver.cs: Call BootCorlib_PopulateCoreType
22891 * class.cs (Property.CheckBase): Check for properties only, not
22894 * interface.cs: Temporary hack: try/catch around the
22895 CustomAttributeBuilder, because I am getting an exception that I
22898 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
22899 types whose definitions are required to be there (attributes are
22900 defined before standard types).
22902 Compute definitions as we boot the various types, as they are used
22903 immediately (value_type class will need object_type, but if we do
22904 not initialize object_type, we will pass a null, which will let
22905 the runtime pick the System.Object from the existing corlib, which
22906 is not what we want).
22908 2002-04-22 Patrik Torstensson <totte@labs2.com>
22910 * cs-tokenizer.cs: fixed a number of trim() issues.
22912 2002-04-22 Ravi Pratap <ravi@ximian.com>
22914 * expression.cs (Argument.Type): Ensure that we return the correct
22915 type when we have out or ref parameters [in which case we
22918 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22920 * class.cs (Property, Indexer): Allow extern modifier in there.
22922 * typemanager.cs (InitBaseTypes): Initializes object_type and
22923 value_type, since those will be used early on during the bootstrap
22924 process to compile corlib.
22926 (InitCoreTypes): Move code from here to InitBaseTypes.
22928 2002-04-21 Miguel de Icaza <miguel@ximian.com>
22930 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
22931 single-dimension arrays as using the ldlen opcode.
22933 Daniel Lewis discovered this optimization.
22935 * typemanager.cs: Add signature for System.Array::get_Length
22937 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22939 * statement.cs: report the error when the foreach does not apply to an
22940 array nor a collection.
22942 2002-04-19 Miguel de Icaza <miguel@ximian.com>
22944 * expression.cs: Add implicit conversions to the operator ~.
22946 * constant.cs (DecimalConstant.Emit): Emit decimal value.
22948 * typemanager.cs: Locate the decimal constructor.
22950 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22952 * attribute.cs: use the new property of TypeOf.
22953 * expression.cs: added 'get' property around typearg.
22955 These changes fix a build breaker reported by NickD. Is this the
22956 correct way to fix? If not, please, revert my changes and make it
22959 2002-04-17 Miguel de Icaza <miguel@ximian.com>
22961 * attribute.cs: Add support for typeof in attribute invocations.
22962 I am not sure that this is right though.
22964 2002-04-14 Duncan Mak <duncan@ximian.com>
22966 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
22967 Binary.Operator.Division case.
22969 2002-04-13 Ravi Pratap <ravi@ximian.com>
22971 * class.cs (DefineType): Ensure that we do a proper check on
22972 attribute types and also register it with the TypeManager.
22974 (TypeContainer.Targets): The default for attribute types is
22975 AttributeTargets.All.
22977 * attribute.cs (ApplyAttributes): Registering the attribute type
22978 is done elsewhere, not when we discover we have a Usage attribute.
22980 2002-04-12 Ravi Pratap <ravi@ximian.com>
22982 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
22983 and get rid of is_delegate parameter.
22985 * everywhere : update.
22987 2002-04-12 Ravi Pratap <ravi@ximian.com>
22989 * cs-parser.jay (compilation_unit): Revamp completely to use
22990 some new ideas that I got from Rhys' grammar to solve the problems
22991 with assembly level attributes.
22993 (outer_declaration): New grammar production.
22995 (attribute_sections): Add.
22997 (opt_attributes): Base on attribute_sections
22999 (namespace_declaration): Allow opt_attributes to tackle the case
23000 when we have assembly level attributes - we are clever in this
23003 * attribute.cs (ApplyAttributes): Do not worry about assembly
23004 attributes in the non-global context.
23006 * rootcontext.cs (AddGlobalAttributes): Go back to using this
23007 instead of SetGlobalAttributes.
23009 * class.cs, rootcontext.cs : Ensure we define and generate
23010 attribute types before anything else.
23012 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
23013 and flag the new error -20 for the case when the attribute type
23014 does not have valid targets specified. csc does not catch this.
23016 * ../errors/errors.txt : update for error # -20
23018 2002-04-11 Ravi Pratap <ravi@ximian.com>
23020 * support.cs (InternalParameters.ParameterModifier): Do some null
23021 checking and return sane values.
23023 * class.cs (Method.Define): If we are a PInvoke method, ensure
23024 that we are static and extern. Report error # 601
23026 * ../errors/cs0601.cs : Add test case for the above error.
23028 2002-04-07 Ravi Pratap <ravi@ximian.com>
23030 * rootcontext.cs (attribute_types): We need to keep type of
23031 all attribute types separately and emit code for them first.
23033 (RegisterAttribute) : Implement.
23035 * class.cs (DefineType): Check if the current Type is a custom
23036 attribute type and register it accordingly.
23038 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
23039 adding the first attribute twice and rename to
23041 (SetGlobalAttributes): this.
23043 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
23046 * attribute.cs (ApplyAttributes): Take an additional argument telling us
23047 if we are processing global arguments. Hmm, I am unsure of this.
23049 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23051 * expression.cs: added static array of strings to avoid calling
23052 Enum.ToString () for Operator in Binary. Significant recover of
23055 2002-04-10 Miguel de Icaza <miguel@ximian.com>
23057 * class.cs (FindMembers): Allow the Builders of the various
23058 members to be null. If they are skip them. This only happens
23059 during the PInvoke declaration.
23061 2002-04-09 Miguel de Icaza <miguel@ximian.com>
23063 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
23064 failure, so we do not keep going afterwards.
23066 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
23067 wanted to pass `false' as the `is_delegate' argument. If this is
23068 the case, why not use delegate_type == null to mean `is_delegate =
23069 false' and anything else as is_delegate = true.
23071 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
23073 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
23074 code for the section, not the beginning of the tests.
23076 2002-04-08 Miguel de Icaza <miguel@ximian.com>
23078 * cfold.cs: Handle operator + (Enum x, Underlying x)
23080 * expression.cs (Binary): same. Warn about errors where we have
23081 Enum/Enum in operator + as well.
23083 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
23086 - added support for switch(bool)
23087 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
23088 - add TableSwitchEmit() to handle table-based switch statements
23090 2002-04-05 Ravi Pratap <ravi@ximian.com>
23092 * expression.cs (Invocation.OverloadResolve): Factor out code which
23093 does parameter compatibility checking with arguments so that we can
23094 re-use the code even from Delegate.VerifyApplicability
23096 (VerifyArgumentsCompat): Move above code here.
23098 * delegate.cs (VerifyApplicability): Get rid of duplicate code
23099 and instead make a call to the above method.
23101 2002-03-31 Ravi Pratap <ravi@ximian.com>
23103 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
23104 We use it to keep track of classes which are attribute types.
23106 2002-04-02 Miguel de Icaza <miguel@ximian.com>
23108 * delegate.cs (Delegate.Define): Correctly define the types in the
23109 presence of fixed and array parameters.
23111 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
23114 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
23115 include NonPublic after the first iteration.
23117 * class.cs (Indexer.CheckBase): Only check if both parents are
23120 * cs-parser.jay (accessor_body): If empty, set to null.
23122 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
23123 same code path here to resolve constants names that we did have in
23124 MemberAccess.DoResolve. There is too much code duplicated here.
23126 2002-04-01 Miguel de Icaza <miguel@ximian.com>
23128 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
23130 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
23133 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
23134 tokens, numbers and strings.
23136 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
23139 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
23140 asyncronous parameters and the regular parameters.
23142 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
23143 specify the target directory.
23145 * expression.cs: (This.DoResolve): Simplify
23146 (As.Emit): Optimize, do not generate IsInst if the expression is
23147 always of the given type.
23149 (Is.DoResolve): Bug fix, we were reporting both always/never for
23152 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
23153 creating too many unnecessary arrays.
23155 2002-03-31 Miguel de Icaza <miguel@ximian.com>
23157 * class.cs (EmitFieldInitializer): Use Assign expression to assign
23158 fields instead of rolling our own initializer. Takes care of all
23159 implicit conversions, and drops unnecessary static checks/argument.
23161 2002-03-31 Dick Porter <dick@ximian.com>
23163 * driver.cs: use the GetDirectories() return values properly, and
23164 use "/" as path separator.
23166 2002-03-30 Miguel de Icaza <miguel@ximian.com>
23168 * expression.cs (Unary): Optimize - - expr into expr.
23169 (Binary): Optimize a + (-b) into a -b.
23171 * codegen.cs (CodeGen): Made all methods static.
23173 2002-03-29 Miguel de Icaza <miguel@ximian.com>
23177 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
23178 TypeBuilder property.
23180 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
23183 * tree.cs: Removed the various RecordXXXX, and replaced with a
23184 single RecordDecl. Removed all the accessor methods, and just
23185 left a single access point Type
23187 * enum.cs: Rename DefineEnum to DefineType.
23189 * decl.cs: New abstract method `DefineType' used to unify the
23190 Defines for Enumerations, Interfaces, TypeContainers and
23193 (FindType): Moved LookupInterfaceOrClass here. Moved the
23194 LookupBaseClasses method that used to live in class.cs and
23195 interface.cs here, and renamed to FindType.
23197 * delegate.cs: Implement DefineType. Take advantage of the
23198 refactored pattern for locating the parent builder without taking
23199 the parent_builder argument (which we know does not work if we are
23200 nested, and triggering a toplevel definition).
23202 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23204 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
23205 accessibility of a member has changed during override and report
23208 * class.cs (Method.Define, Property.Define): Only complain on
23209 overrides if the method is private, any other accessibility is
23210 fine (and since we just checked the permission is the same, we are
23213 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
23214 and elif are processed always. The other pre-processing
23215 directives are only processed if we are "taking" the path
23217 2002-03-29 Martin Baulig <martin@gnome.org>
23219 * class.cs (Method.Emit): Only emit symbolic debugging info if the
23220 current location is not Null.
23222 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
23223 a separate method so we can profile it.
23225 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
23226 `span.Seconds' are just seconds, but no minutes or hours.
23227 (MainDriver): Profile the CodeGen.SaveSymbols calls.
23229 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23231 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
23232 Remove the gratuitous set of Final:
23234 // If an interface implementation, then we can set Final.
23235 if (((flags & MethodAttributes.Abstract) == 0) &&
23236 implementing.DeclaringType.IsInterface)
23237 flags |= MethodAttributes.Final;
23239 I do not know what I was smoking when I used that.
23242 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
23243 step into fixing the name resolution issues for delegates and
23244 unifying the toplevel name resolution.
23246 2002-03-28 Martin Baulig <martin@gnome.org>
23248 * class.cs (Method.Emit): If we have a symbol writer, call its
23249 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
23250 tell it about the current method.
23252 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
23253 writer that we're going to emit the first byte of IL code for a new
23254 statement (a new source line).
23255 (EmitContext.EmitTopBlock): If we have a symbol writer, call
23256 EmitContext.Mark() before emitting any code.
23258 * location.cs (SymbolDocument): Return null when we're Null.
23260 * statement.cs (Statement): Moved the `Location loc' variable here.
23261 (Statement.EmitBoolExpression): If we have a symbol writer, call
23262 ec.Mark() before emitting any code to tell it that we're at the
23263 beginning of a new statement.
23264 (StatementExpression): Added `Location' argument to the constructor.
23265 (Block): Added public readonly variable `StartLocation' and public
23266 variable `EndLocation'. The latter is to be set using SetEndLocation().
23267 (Block): Added constructor which takes a start and end location.
23268 (Block.SetEndLocation): New method. This sets the end location.
23269 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
23270 local variables we create.
23271 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
23272 each statement and do also mark the begin and end of the block.
23274 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
23275 tell it the current lexer.Location, use Location.Null for the end of the
23277 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
23278 current block, set its end location using SetEndLocation().
23279 (statement_expression): StatementExpression constructor now takes the
23280 lexer.Location as additional argument.
23281 (for_statement, declare_local_variables): Likewise.
23282 (declare_local_variables): When creating a new implicit block, use the
23283 new Block constructor and pass it the lexer.Location.
23285 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23287 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
23288 members also on the parent interfaces recursively.
23290 2002-03-27 Miguel de Icaza <miguel@ximian.com>
23292 * report.cs: Use new formats, since Gonzalo finished the missing
23295 * expression.cs (Binary.ResolveOperator): added missing operator|
23296 operator& and operator^ for bool/bool.
23298 * cs-parser.jay: CheckDef now takes a Location argument that is
23299 used to report errors more precisly (instead of reporting the end
23300 of a definition, we try to track something which is a lot closer
23301 to the source of the problem).
23303 * cs-tokenizer.cs: Track global token use, so we can properly flag
23304 the use of #define/#undef after the first token has been seen.
23306 Also, rename the reportXXXX to Error_DescriptiveName
23308 * decl.cs (DeclSpace.IsTopLevel): Move property here from
23309 TypeContainer, so that Enum and Interface can use this too.
23311 * class.cs (TypeContainer.LookupInterfaceOrClass,
23312 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
23313 `builder' argument. Typically this was used to pass the parent
23314 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
23317 The problem is that a nested class could trigger the definition of
23318 a toplevel class, and the builder would be obviously wrong in that
23321 So we drop this argument, and we compute dynamically the
23322 TypeBuilder/ModuleBuilder (the correct information was available
23323 to us anyways from DeclSpace.Parent)
23325 * interface.cs (Interface.DefineInterface): Drop builder
23326 parameter cleanup like class.cs
23328 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
23331 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
23334 (Try.Emit): Propagate the returns value from the statement.
23336 (Return.Emit): Even if we are leavning
23338 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
23340 * modifiers.cs: Fix the computation of MethodAttributes flags.
23342 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
23344 * driver.cs: allow compilation of files that start with '/'.
23345 Add a default case when checking the argument of --target.
23347 2002-03-25 Miguel de Icaza <miguel@ximian.com>
23349 * interface.cs: Implement the same search algorithm for types in
23350 the interface code.
23352 * delegate.cs: Do not allow multiple definition.
23354 * Recovered ChangeLog that got accidentally amputated
23356 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
23358 * rootcontext.cs: Load manually enum to allow core classes to
23359 contain enumerations.
23361 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
23362 Update to new static methods in TypeManager.
23364 * typemanager.cs (GetMethod, GetConstructor): Use our
23365 implementation of FindMembers to find the members, since during
23366 corlib compilation, the types are TypeBuilders and GetMethod and
23367 GetConstructor do not work.
23369 Make all methods in TypeManager static.
23371 (InitCodeHelpers): Split the functionality from
23372 the InitCodeTypes function.
23374 * driver.cs: Call InitCodeHelpers after we have populated the
23377 * cs-parser.jay (delegate_declaration): we did not used to compute
23378 the delegate name correctly for void delegates.
23380 2002-03-24 Miguel de Icaza <miguel@ximian.com>
23382 * rootcontext.cs (RootContext): Init the interface_resolve_order
23383 and type_container_resolve_order always.
23385 (ResolveCore, BootstrapCorlib_ResolveClass,
23386 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
23387 compiler when compiling with --nostdlib
23389 * class.cs (TypeContainer.DefineType): Check that our parent is
23390 not null. This test is most important when we are bootstraping
23393 * codegen.cs: Split out the symbol writing code.
23395 2002-03-25 Martin Baulig <martin@gnome.org>
23397 * driver.cs (-g): Made -g an alias for --debug.
23399 2002-03-24 Martin Baulig <martin@gnome.org>
23401 * codegen.cs (SymbolWriter): New public variable. Returns the
23402 current symbol writer.
23403 (CodeGen): Added `bool want_debugging_support' argument to the
23404 constructor. If true, tell the ModuleBuild that we want debugging
23405 support and ask it for the ISymbolWriter.
23406 (Save): If we have a symbol writer, call it's Close() method after
23407 saving the assembly.
23409 * driver.c (--debug): New command line argument to create a
23410 debugger information file.
23412 * location.cs (SymbolDocument): New public property. Returns an
23413 ISymbolDocumentWriter object for the current source file or null
23414 if we don't have a symbol writer.
23416 2002-03-21 Miguel de Icaza <miguel@ximian.com>
23418 * driver.cs (LoadAssembly): Correctly return when all the paths
23419 have been tried and not before.
23421 * statement.cs (Switch.Emit): return the actual coverage for this
23422 statement (returns/not-returns)
23424 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
23425 switch of the statement if we are the last switch section. That
23426 kills two problems: try/catch problems (we used to emit an empty
23427 nop at the end) and switch statements where all branches would
23430 2002-03-19 Miguel de Icaza <miguel@ximian.com>
23432 * driver.cs: Add default assemblies (the equivalent to the
23433 Microsoft CSC.RSP file)
23435 * cs-tokenizer.cs: When updating `cols and setting it to zero,
23436 also update tokens_seen and set it to false.
23438 * driver.cs: Implement --recurse for Mike.
23440 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
23441 correctly splitting out the paths.
23443 2002-03-18 Miguel de Icaza <miguel@ximian.com>
23445 * interface.cs (Interface.PopulateProperty): Instead of using
23446 `parent' as the declaration space for the set parameters, use
23449 * support.cs (InternalParameters): InternalParameters constructor
23450 takes a DeclSpace instead of a TypeContainer.
23452 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
23453 types are being initialized, load the address of it before calling
23456 (New): Provide a mechanism to disable the generation of local
23457 value type temporaries when the caller will be providing us with
23458 an address to store it.
23460 (ArrayCreation.EmitDynamicInitializers): Use it.
23462 2002-03-17 Miguel de Icaza <miguel@ximian.com>
23464 * expression.cs (Invocation.EmitArguments): Only probe for array
23465 property if there is more than one argument. Sorry about that.
23467 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
23468 empty param arrays.
23470 * class.cs (Method.LabelParameters): Fix incorrect code path that
23471 prevented the `ParamArrayAttribute' from being applied to the
23474 2002-03-16 Miguel de Icaza <miguel@ximian.com>
23476 * support.cs (ReflectionParameters): Correctly compute whether the
23477 last argument is a params array. Fixes the problem with
23480 * typemanager.cs: Make the assemblies array always be non-null
23481 (empty, but non-null)
23483 * tree.cs (RecordDecl): New function that abstracts the recording
23484 of names. This reports error 101, and provides a pointer to the
23485 previous declaration. Fixes a crash in the compiler.
23487 * cs-parser.jay (constructor_declaration): Update to new grammar,
23488 and provide a constructor_body that can be empty.
23490 2002-03-15 Miguel de Icaza <miguel@ximian.com>
23492 * driver.cs: Add support for --resources.
23494 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
23495 Make all types for the various array helper methods be integer.
23497 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
23498 CheckState to ConvCast.
23500 (ConvCast): Now it takes a `checked' state argument, to avoid
23501 depending on the emit context for the conversion, and just using
23502 the resolve time setting.
23504 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
23505 instead of Invocation.EmitArguments. We do not emit the original
23506 arguments, instead we emit those which have been converted to
23507 unsigned int expressions.
23509 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
23511 * codegen.cs: ditto.
23513 * expression.cs (LocalVariableReference): Drop the use of the
23514 Store function that depended on the variable index.
23516 * statement.cs (VariableInfo): Drop the `Idx' property from this
23517 class, as this is not taking into account the indexes for
23518 temporaries tat we generate during the execution, getting the
23521 * class.cs: First emit class initializers, then call the parent
23524 * expression.cs (Binary): Fix opcode emision.
23525 (UnaryMutator.EmitCode): Support checked code generation
23527 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
23528 matches for events for both the Static and Instance scans,
23529 pointing to the same element. Fix that.
23531 2002-03-14 Miguel de Icaza <miguel@ximian.com>
23533 * rootcontext.cs (ResolveTree): Always set the
23534 interface_resolve_order, because nested interfaces will be calling
23537 * class.cs (GetInterfaceOrClass): Track the same resolution
23538 process used by TypeManager.LookupType. This fixes the nested
23539 type lookups in class declarations (separate path from
23542 (TypeContainer.DefineType): Also define nested interfaces.
23543 (TypeContainer.RegisterOrder): New public function used to
23544 register the order in which child interfaces need to be closed.
23546 Nested interfaces need to be closed after their parents have been
23549 * interface.cs (InterfaceAttr): Put all the logic for computing
23550 the interface attribute here.
23552 (DefineInterface): Register our interface order with the
23553 RootContext or with the TypeContainer depending on the case.
23555 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23557 * cs-parser.jay: rework foreach statement to work with the new
23558 changes to the policy on SimpleNames.
23560 * report.cs: support Stacktrace on warnings as well.
23562 * makefile: drop --unsafe and /unsafe from the compile.
23564 2002-03-13 Ravi Pratap <ravi@ximian.com>
23566 * ecore.cs (StandardConversionExists): Modify to take an Expression
23567 as the first parameter. Ensure we do null -> reference type conversion
23570 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
23571 temporary Expression objects.
23573 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
23575 * interface.cs: workaround bug in method overloading resolution
23576 (there is already a bugzilla bug for it).
23578 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23580 We could also solve this problem by having a separate path for
23581 performing type lookups, instead of DoResolve, we could have a
23582 ResolveType entry point, and only participating pieces of the
23583 production (simplename, deref, array) would implement this.
23585 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
23586 signal SimpleName to only resolve type names and not attempt to
23587 resolve anything else.
23589 * expression.cs (Cast): Set the flag.
23591 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
23593 * class.cs: Only report 108 if there is no `new' modifier.
23595 * cs-parser.jay: rework foreach statement to work with the new
23596 changes to the policy on SimpleNames.
23598 * report.cs: support Stacktrace on warnings as well.
23600 * makefile: drop --unsafe and /unsafe from the compile.
23602 2002-03-11 Miguel de Icaza <miguel@ximian.com>
23604 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23605 lookups here, instead of doing that at parse time. This means
23606 that our grammar will not introduce `LocalVariableReferences' as
23607 expressions at this point. That solves the problem of code like
23611 static void Main ()
23615 This is only half the fix. The full fix requires parameters to
23616 also be handled in this way.
23618 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
23619 makes the use more obvious of the DeclSpace. The
23620 ec.TypeContainer.TypeBuilder is now only used to pull the
23621 TypeBuilder for it.
23623 My theory is that I can get rid of the TypeBuilder completely from
23624 the EmitContext, and have typecasts where it is used (from
23625 DeclSpace to where it matters).
23627 The only pending problem is that the code that implements Aliases
23628 is on TypeContainer, and probably should go in DeclSpace.
23630 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23631 lookups here, instead of doing that at parse time. This means
23632 that our grammar will not introduce `LocalVariableReferences' as
23633 expressions at this point. That solves the problem of code like
23637 static void Main ()
23641 This is only half the fix. The full fix requires parameters to
23642 also be handled in this way.
23644 * class.cs (Property.DefineMethod): When implementing an interface
23645 method, set newslot, when implementing an abstract method, do not
23646 set the flag (before we tried never setting it, or always setting
23647 it, which is the difference).
23648 (Indexer.DefineMethod): same.
23649 (Method.DefineMethod): same.
23651 * ecore.cs: Only set the status used flag if we get back a Field.
23653 * attribute.cs: Temporary hack, so Paolo can keep working.
23655 2002-03-08 Ravi Pratap <ravi@ximian.com>
23657 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
23658 the unmanaged type in the case we have a MarshalAs attribute.
23660 (Resolve): Handle the case when we are parsing the special MarshalAs
23661 attribute [we need to store the unmanaged type to use later]
23663 * typemanager.cs (marshal_as_attr_type): Built in type for the
23664 MarshalAs Attribute.
23666 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
23667 on parameters and accordingly set the marshalling info.
23669 2002-03-09 Miguel de Icaza <miguel@ximian.com>
23671 * class.cs: Optimizing slightly by removing redundant code after
23672 we switched to the `NoTypes' return value.
23673 (Property.DefineMethod): use NoTypes here too.
23675 This fixes the bug I introduced in my last batch of changes.
23677 2002-03-05 Ravi Pratap <ravi@ximian.com>
23679 * tree.cs (RecordEnum): Add. We now keep track of enums too.
23681 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
23682 Enums since those are types too.
23684 * cs-parser.jay (enum_declaration): Record enums as we parse them.
23686 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
23687 thanks to a call during the lookup process.
23689 2002-03-07 Miguel de Icaza <miguel@ximian.com>
23691 * statement.cs (Foreach): Lots of work to accomodate a particular
23692 kind of foreach statement that I had not kept in mind. It is
23693 possible to have foreachs on classes that provide a GetEnumerator
23694 method that return objects that implement the "pattern" for using
23695 a foreach, there is no need to support GetEnumerator
23698 This is needed to compile nant.
23700 * decl.cs: Only report 114 if the member is not `Finalize' and if
23701 the warning level is at least 2.
23703 * class.cs: Moved the compare function from Method to
23706 (MethodSignature.InheritableMemberSignatureCompare): Add new
23707 filter function that is used to extract inheritable methods from a
23710 (Method.Define): Use the new `inheritable_method_signature_filter'
23713 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
23716 2002-03-06 Miguel de Icaza <miguel@ximian.com>
23718 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
23720 * cs-parser.jay: Add opt_semicolon to the interface declaration.
23722 * expression.cs: Pass location information to
23723 ConvertImplicitStandard.
23725 * class.cs: Added debugging code to track return values from
23728 2002-03-05 Miguel de Icaza <miguel@ximian.com>
23730 * expression.cs (Is.DoResolve): If either side of the `is' is an
23731 interface, do not flag the warning.
23733 * ecore.cs (ImplicitReferenceConversion): We need a separate test
23736 * report.cs: Allow for --fatal to be used with --probe.
23738 * typemanager.cs (NoTypes): Move the definition for the empty Type
23741 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
23743 (TypeContainer.DefineProxy): New function used to proxy to parent
23744 implementations when implementing interfaces.
23745 (TypeContainer.ParentImplements): used to lookup if our parent
23746 implements a public function that is required by an interface.
23747 (TypeContainer.VerifyPendingMethods): Hook this up.
23749 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
23750 `modules' and `assemblies' arraylists into arrays. We only grow
23751 these are the very early start up of the program, so this improves
23752 the speedof LookupType (nicely measured).
23754 * expression.cs (MakeByteBlob): Replaced unsafe code with
23755 BitConverter, as suggested by Paolo.
23757 * cfold.cs (ConstantFold.Binary): Special case: perform constant
23758 folding of string concatenation, but if either side is a string,
23759 and the other is not, then return null, and let the runtime use
23760 the concatenation on the string plus the object (using
23761 `Object.ToString').
23763 2002-03-04 Miguel de Icaza <miguel@ximian.com>
23765 Constant Folding has been implemented now.
23767 * expression.cs (Unary.Reduce): Do not throw an exception, catch
23768 the error instead on types that are not supported in one's
23771 * constant.cs (Constant and all children): New set of functions to
23772 perform implict and explicit conversions.
23774 * ecore.cs (EnumConstant): Implement the new functions to perform
23775 conversion by proxying to the child expression.
23777 * codegen.cs: (ConstantCheckState): Constant evaluation has its
23778 own separate setting that can not be turned off from the command
23779 line using --unchecked or --checked and is only controlled using
23780 the checked/unchecked statements and expressions. This setting is
23781 used by the constant folder to flag errors.
23783 * expression.cs (CheckedExpr, UncheckedExpr): Set the
23784 ConstantCheckState as well.
23786 During Resolve, they also have to flag the state, because the
23787 constant folder runs completely in the Resolve phase.
23789 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
23792 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23794 * cfold.cs: New file, this file contains the constant folder.
23796 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
23797 argument to track whether we are using the resulting address to
23798 load or store a value and provide better error messages.
23800 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
23801 new AddressOf arguments.
23803 * statement.cs (Foreach.EmitCollectionForeach): Update
23805 * expression.cs (Argument.Emit): Call AddressOf with proper
23806 arguments to track usage.
23808 (New.DoEmit): Call AddressOf with new arguments.
23810 (Unary.Emit): Adjust AddressOf call.
23812 2002-03-01 Ravi Pratap <ravi@ximian.com>
23814 * cs-parser.jay (member_access): Change the case for pre-defined types
23815 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
23818 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
23821 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
23822 essentially like methods and apply attributes like MethodImplOptions to them too.
23824 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
23827 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
23828 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
23831 * Update code everywhere accordingly.
23833 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
23835 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
23837 2002-02-28 Ravi Pratap <ravi@ximian.com>
23839 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
23840 try performing lookups against those instead of jumping straight into using
23841 the 'using' clauses.
23843 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
23845 (LookupType): Perform lookups in implicit parents too.
23847 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
23848 sequence as RootContext.LookupType.
23850 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
23851 the various cases of namespace lookups into this method.
23853 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23855 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
23856 in positional arguments)
23858 * class.cs (Operator): Update the AllowedModifiers to contain
23861 * cs-parser.jay: Update operator declaration to allow for the
23862 operator body to be empty.
23864 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
23867 2002-02-27 Miguel de Icaza <miguel@ximian.com>
23869 * class.cs (Method.Emit): Label parameters.
23871 * driver.cs: Return 1 or 0 as the program exit code.
23873 2002-02-26 Miguel de Icaza <miguel@ximian.com>
23875 * expression.cs: Special case the `null' object when trying to
23876 auto-compute the type, as anything can be explicitly converted to
23879 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
23880 spotting this Paolo.
23882 (Expression.ImplicitNumericConversion): Perform comparissions of
23883 the type using the underlying type in the case of an enumeration
23884 rather than using the enumeration type for the compare.
23886 Cope with the underlying == type case, which is not possible to
23889 (Expression.ConvertNumericExplicit): Perform comparissions of
23890 the type using the underlying type in the case of an enumeration
23891 rather than using the enumeration type for the compare.
23893 * driver.cs: If the user does not supply an extension, assume .exe
23895 * cs-parser.jay (if_statement): Rewrote so that we can track the
23896 location for the if statement.
23898 * expression.cs (Binary.ConstantFold): Only concat strings when
23899 the operation is "+", not everything ;-)
23901 * statement.cs (Statement.EmitBoolExpression): Take a location
23903 (If, While, Do): Track location.
23905 * expression.cs (Binary.ResolveOperator): In the object + string
23906 case, I was missing a call to ConvertImplicit
23908 2002-02-25 Ravi Pratap <ravi@ximian.com>
23910 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
23911 Location arguments. Ensure we use RootContext.LookupType to do our work
23912 and not try to do a direct Type.GetType and ModuleBuilder.GetType
23914 * interface.cs (PopulateMethod): Handle the type of the parameter being
23917 * expression.cs (Invocation.BetterFunction): Handle the case when we
23918 have a params method with no fixed arguments and a call is made with no
23921 2002-02-25 Miguel de Icaza <miguel@ximian.com>
23923 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
23924 the verbatim-string-literal
23926 * support.cs (InternalParameters.ParameterModifier): handle null
23928 (InternalParameters.ParameterType): ditto.
23930 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
23931 duplicating the name of the variable parameter.
23932 (GetParameterByName): Fix bug where we were not looking up array
23933 paramters if they were the only present (thanks Paolo!).
23934 (GetParameterInfo): We only have an empty set of types if both
23935 fixed and array are set to null.
23936 (GetParameterInfo-idx): Handle FixedParameter == null
23938 * cs-parser.jay: Handle the case where there is no catch
23939 statements (missing null test).
23941 2002-02-22 Miguel de Icaza <miguel@ximian.com>
23943 * driver.cs (MainDriver): Be conservative on our command line
23946 Catch DirectoryNotFoundException when calling GetFiles.
23948 (SplitPathAndPattern): Used to split the input specification into
23949 a path and a pattern that we can feed to Directory.GetFiles.
23951 2002-02-21 Miguel de Icaza <miguel@ximian.com>
23953 * statement.cs (Fixed): Implement the last case of the Fixed
23954 statement (string handling).
23956 * expression.cs (StringPtr): New class used to return a char * to
23957 a string; Used by the Fixed statement.
23959 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
23961 * expression.cs (Binary.ResolveOperator): Remove redundant
23962 MemberLookup pn parent type.
23963 Optimize union call, we do not need a union if the types are the same.
23964 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
23967 Specialize the use of MemberLookup everywhere, instead of using
23968 the default settings.
23970 (StackAlloc): Implement stackalloc keyword.
23972 * cs-parser.jay: Add rule to parse stackalloc.
23974 * driver.cs: Handle /h, /help, /?
23976 * expression.cs (MakeByteBlob): Removed the hacks we had in place
23977 before we supported unsafe code.
23979 * makefile: add --unsafe to the self compilation of mcs.
23981 2002-02-20 Miguel de Icaza <miguel@ximian.com>
23983 * expression.cs (PointerArithmetic): New class that is used to
23984 perform pointer arithmetic.
23985 (Binary.Resolve): Handle pointer arithmetic
23986 Handle pointer comparission.
23987 (ArrayPtr): Utility expression class that is used to take the
23988 address of an array.
23990 (ElementAccess): Implement array access for pointers
23992 * statement.cs (Fixed): Implement fixed statement for arrays, we
23993 are missing one more case before we are done.
23995 * expression.cs (Indirection): Implement EmitAssign and set the
23996 ExprClass to Variable. This allows pointer dereferences to be
23997 treated as variables, and to have values assigned to them.
23999 * ecore.cs (Expression.StoreFromPtr): New utility function to
24000 store values dereferencing.
24002 2002-02-20 Ravi Pratap <ravi@ximian.com>
24004 * expression.cs (Binary.ResolveOperator): Ensure that we are
24005 not trying to operate on a void type - this fixes the reported
24008 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
24009 the parent implementation is sealed.
24011 * ../errors/cs0239.cs : Add.
24013 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
24015 * typemanager.cs (unverifiable_code_type): Corresponds to
24016 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
24017 which have unsafe code in them.
24019 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
24022 2002-02-19 Miguel de Icaza <miguel@ximian.com>
24024 * cs-tokenizer.cs: Add support for @"litreal strings"
24026 Make tokenizer accept pre-processor directives
24027 on any column (remove the old C-like limitation).
24029 * rootcontext.cs (EmitCode): Emit any global attributes.
24030 (AddGlobalAttributes): Used to keep track of assembly attributes.
24032 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
24034 * cs-parser.jay: Add support for global attributes.
24036 2002-02-17 Miguel de Icaza <miguel@ximian.com>
24038 * expression.cs (Indirection): New helper class. Unary will
24039 create Indirection classes to be able to implement the
24040 IMemoryLocation interface on it.
24042 2002-02-16 Miguel de Icaza <miguel@ximian.com>
24044 * cs-parser.jay (fixed_statement): reference the right statement.
24046 * statement.cs (Fixed.Emit): Finish implementing the fixed
24047 statement for the &x case.
24049 2002-02-14 Miguel de Icaza <miguel@ximian.com>
24051 * class.cs (Property.Define, Method.Define): Remove newslot when
24054 * modifiers.cs: My use of NewSlot when `Abstract' was set was
24055 wrong. NewSlot should only be used if the `new' keyword is present.
24057 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
24058 locating our system dir. Sorry about this.
24060 2002-02-13 Miguel de Icaza <miguel@ximian.com>
24062 * driver.cs (GetSystemDir): Compute correctly the location of our
24063 system assemblies. I was using the compiler directory instead of
24064 the library directory.
24066 2002-02-13 Ravi Pratap <ravi@ximian.com>
24068 * expression.cs (BetterFunction): Put back in what Miguel commented out
24069 since it is the correct fix. The problem is elsewhere ;-)
24071 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
24072 parameters of the parms method are themselves compatible or not !
24074 (StandardConversionExists): Fix very dangerous bug where we were forgetting
24075 to check that a class implements an interface before saying that an implicit
24076 conversion was allowed. Use ImplementsInterface to do the checking.
24078 2002-02-13 Miguel de Icaza <miguel@ximian.com>
24080 * class.cs (Method.Define): Track whether we are an explicit
24081 implementation or not. And only call DefineMethodOverride if we
24082 are an explicit implementation.
24084 (Property.DefineMethod): Ditto.
24086 2002-02-11 Ravi Pratap <ravi@ximian.com>
24088 * expression.cs (BetterFunction): Catch hideous bug which was
24089 preventing us from detecting ambiguous calls due to implicit casts i.e
24092 2002-01-29 Miguel de Icaza <miguel@ximian.com>
24094 * support.cs (Pair): Remove un-needed method. I figured why I was
24095 getting the error in cs-parser.jay, the variable in a foreach loop
24096 is readonly, and the compiler does not really treat this as a variable.
24098 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
24099 instead of EQUALS in grammar.
24101 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
24103 * expression.cs (Unary.DoResolve): Check whether the argument is
24106 2002-01-28 Miguel de Icaza <miguel@ximian.com>
24108 * support.cs: Api for Pair to set a value. Despite the fact that
24109 the variables are public the MS C# compiler refuses to compile
24110 code that accesses the field if the variable is part of a foreach
24113 * statement.cs (Fixed): Begin implementation of the fixed
24116 (Block.AddVariable): Return the VariableInfo on success and null
24117 on failure instead of true/false.
24119 * cs-parser.jay (foreach): Catch errors on variables already
24120 defined (we were ignoring this value before) and properly unwind
24121 the block hierarchy
24123 (fixed_statement): grammar for the fixed statement.
24125 2002-01-25 Miguel de Icaza <miguel@ximian.com>
24127 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
24128 pointer types to be incretemented.
24130 (SizeOf): Implement.
24132 * cs-parser.jay (pointer_member_access): Implement
24133 expr->IDENTIFIER production.
24135 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
24136 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
24139 (Unary): Implement indirection.
24141 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
24142 use in non-unsafe context).
24144 (SimpleName.DoResolve): Check for pointers in field access on safe
24147 (Expression.LoadFromPtr): Factor the load-indirect code in this
24148 function. This was duplicated in UnboxCast and ParameterReference
24150 2002-01-24 Miguel de Icaza <miguel@ximian.com>
24152 * expression.cs (ComposedCast): report an error if a pointer cast
24153 is used in a safe region.
24155 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
24156 pointer type casts in unsafe context.
24158 * codegen.cs (EmitContext): Set up IsUnsafe.
24160 * cs-parser.jay (non_expression_type): Add productions for pointer
24163 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
24164 code. We should not use force into static mode if the method is
24165 not virtual. Fixes bug in MIS
24167 * statement.cs (Do.Emit, While.Emit, For.Emit,
24168 Statement.EmitBoolExpression): Add support to Do and While to
24169 propagate infinite loop as `I do return' semantics.
24171 Improve the For case to also test for boolean constants.
24173 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
24174 to the list of attributes we can add.
24176 Remove `EmitContext' argument.
24178 * class.cs (Method.Define): Apply parameter attributes.
24179 (Constructor.Define): Apply parameter attributes.
24180 (MethodCore.LabelParameters): Move here the core of labeling
24183 * support.cs (ReflectionParameters.ParameterModifier,
24184 InternalParameters.ParameterModifier): Use IsByRef on the type and
24185 only return the OUT bit for these parameters instead of in/out/ref
24188 This is because I miss-understood things. The ParameterInfo.IsIn
24189 and IsOut represent whether the parameter has the [In] and [Out]
24192 2002-01-22 Miguel de Icaza <miguel@ximian.com>
24194 * ecore.cs (FieldExpr.Emit): Release temporaries.
24196 * assign.cs (LocalTemporary.Release): new function.
24198 * codegen.cs (EmitContext.GetTemporaryStorage,
24199 EmitContext.FreeTemporaryStorage): Rework the way we deal with
24200 temporary storage. Now we can "put back" localbuilders when we
24203 2002-01-21 Miguel de Icaza <miguel@ximian.com>
24205 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
24206 need to make a copy of the variable to generate verifiable code.
24208 2002-01-19 Miguel de Icaza <miguel@ximian.com>
24210 * driver.cs: Compute dynamically the system directory.
24212 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
24213 Slower, but more generally useful. Used by the abstract
24214 registering implementation.
24216 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
24217 the rules for the special rule on Type/instances. First check if
24218 we have the same name, and if so, try that special static path
24219 rather than the instance path.
24221 2002-01-18 Miguel de Icaza <miguel@ximian.com>
24223 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
24226 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
24227 Enum, ValueType, Delegate or Array for non-corlib compiles.
24229 * cs-tokenizer.cs: Catch long identifiers (645)
24231 * typemanager.cs (IndexerPropetyName): Ravi never tested this
24234 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
24235 fix, we were returning too early, so we were not registering
24236 pending methods from abstract classes.
24238 Do not register pending methods if the class is abstract.
24240 * expression.cs (Conditional.DoResolve): Report circular implicit
24241 conversions when we neecd to compute it for conditional
24244 (Is.DoResolve): If the expression is always of the provided type,
24245 flag warning 183. If the expression can not ever be of the
24246 provided type flag warning 184.
24248 * class.cs: Catch 169 as well.
24250 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
24253 2002-01-18 Nick Drochak <ndrochak@gol.com>
24255 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
24257 2002-01-17 Miguel de Icaza <miguel@ximian.com>
24259 * interface.cs: (PopulateMethod): Check for pointers being defined
24260 only if the unsafe context is active.
24261 (PopulateProperty): ditto.
24262 (PopulateIndexer): ditto.
24264 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
24265 specified. If pointers are present, make sure that they are
24266 present in an unsafe context.
24267 (Constructor, Constructor.Define): ditto.
24268 (Field, Field.Define): ditto.
24269 (Property, Property.Define): ditto.
24270 (Event, Event.Define): ditto.
24272 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
24273 hashtable if there are classes or structs defined.
24275 * expression.cs (LocalVariableReference.DoResolve): Simplify this
24276 code, as the constant resolution moved.
24278 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
24279 the metadata, so we can flag error 133.
24281 * decl.cs (MemberCore.UnsafeOK): New function to test that a
24282 pointer is being declared in an unsafe context.
24284 2002-01-16 Miguel de Icaza <miguel@ximian.com>
24286 * modifiers.cs (Modifiers.Check): Require a Location argument.
24287 Report error 227 for Unsafe use.
24289 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
24291 * statement.cs (For.Emit): If the test is null, then report that
24292 we do `return', as we wont reach anything afterwards.
24294 (Switch.SwitchGoverningType): Track the expression that matched
24297 * driver.cs: Allow negative numbers as an error code to flag.
24299 * cs-parser.jay: Handle 1551.
24301 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
24303 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24305 * cs-parser.jay: Report 1518 (type declaration can only contain
24306 class, struct, interface, enum or delegate)
24308 (switch_label): Report 1523 (keywords `case' or `default' must
24311 (opt_switch_sections): Report 1522 (empty switch)
24313 * driver.cs: Report 1515 (response file specified multiple times)
24314 Report 1516 (Source file specified multiple times).
24316 * expression.cs (Argument.Resolve): Signal 1510
24318 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
24319 access not allowed in static code)
24321 2002-01-11 Ravi Pratap <ravi@ximian.com>
24323 * typemanager.cs (IsPointerType): Utility method which we are going
24326 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
24327 the object type, so we take care of that.
24329 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
24331 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
24332 added to non-params parameters :-)
24334 * typemanager.cs (CSharpName): Include 'void' type too.
24336 (void_ptr_type): Include in the set of core types.
24338 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
24341 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
24344 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
24345 completely forgotten about it.
24347 2002-01-10 Ravi Pratap <ravi@ximian.com>
24349 * cs-parser.jay (pointer_type): Add. This begins our implementation
24350 of parsing rules for unsafe code.
24352 (unsafe_statement): Implement.
24354 (embedded_statement): Modify to include the above.
24356 * statement.cs (Unsafe): Implement new class for unsafe blocks.
24358 * codegen.cs (EmitContext.InUnsafe): Add. This determines
24359 if the current context is an unsafe one.
24361 * cs-parser.jay (local_variable_pointer_type): Since local variable types
24362 are handled differently, we need separate rules for them.
24364 (local_variable_declaration): Update to use local_variable_pointer_type
24365 to allow variable declarations of unmanaged pointer types.
24367 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
24368 in unsafe contexts.
24370 * ../errors/cs0214.cs : Add.
24372 2002-01-16 Nick Drochak <ndrochak@gol.com>
24374 * makefile: remove 'response' file when cleaning.
24376 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24378 * cs-parser.jay: Report 1524.
24380 2002-01-14 Miguel de Icaza <miguel@ximian.com>
24382 * typemanager.cs (RegisterMethod): drop checking if we have
24383 registered this from here
24385 2002-01-12 Miguel de Icaza <miguel@ximian.com>
24387 * class.cs (Method.EmitDestructor): Implement calling our base
24390 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
24391 value of InFinally.
24393 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
24394 this routine and will wrap the call in a try/catch block. Deal
24397 2002-01-11 Miguel de Icaza <miguel@ximian.com>
24399 * ecore.cs (Expression.MemberLookup): instead of taking a
24400 parameter `same_type' that was used to tell whether we could
24401 access private members we compute our containing type from the
24404 (FieldExpr): Added partial support for volatile fields. This does
24405 not work for volatile fields exposed from assemblies, as I can not
24406 figure out how to extract the modreq from it.
24408 Updated all the source files to use this.
24410 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
24411 because it is referenced by MemberLookup very often.
24413 2002-01-09 Ravi Pratap <ravi@ximian.com>
24415 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
24416 TypeBuilder.GetCustomAttributes to retrieve what we need.
24418 Get rid of redundant default_member_attr_type as this is the same as
24419 default_member_type which already exists.
24421 * interface.cs, attribute.cs : Update accordingly.
24423 2002-01-08 Miguel de Icaza <miguel@ximian.com>
24425 * typemanager.cs: Enable IndexerPropertyName again. It does not
24426 work for TYpeBuilders though. Ravi, can you please fix this?
24428 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
24430 * expression.cs (Argument.Emit): Handle the case of ref objects
24431 being passed to ref functions;
24433 (ParameterReference.EmitLoad): Loads the content of the pointer
24434 without dereferencing.
24436 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24438 * cs-tokenizer.cs: Implemented the pre-processing expressions.
24440 2002-01-08 Ravi Pratap <ravi@ximian.com>
24442 * class.cs (Indexer.DefineMethod): Incorporate the interface
24443 type in the name of the method if we are doing explicit interface
24446 * expression.cs (ConversionExists): Remove as it is completely obsolete.
24448 (BetterConversion): Fix extremely trivial bug where we were referring to
24449 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
24452 * ../errors/bug16.cs : Add although we have fixed it.
24454 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24456 * expression.cs (BaseIndexer): Begin implementation.
24458 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
24460 * cs-parser.jay (indexer_declarator): Use qualified_identifier
24461 production directly to remove a shift/reduce, and implement
24462 explicit interface implementation.
24464 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
24465 after a floating point suffix.
24467 * expression.cs (DoNumericPromotions): Improved the conversion for
24468 uint/uint. If we have a constant, we avoid doing a typecast to a
24471 * class.cs (Indexer): Implement explicit interface implementation
24474 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
24476 * class.cs: make the default instance constructor public and hidebysig.
24478 2001-01-03 Ravi Pratap <ravi@ximian.com>
24480 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
24481 so we can call it from elsewhere.
24483 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
24484 we emit it internally if the class has a defined indexer; otherwise the user
24485 emits it by decorating the class definition with the DefaultMemberAttribute.
24487 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
24488 attribute is not used on a type which defines an indexer.
24490 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
24491 character when we skip whitespace.
24493 * ../errors/cs0646.cs : Add.
24495 2002-01-03 Miguel de Icaza <miguel@ximian.com>
24497 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
24500 * makefile: Add practical target `mcs3.exe' which builds the third
24501 generation compiler.
24503 * expression.cs (New): Fix structures constructor calling.
24505 * class.cs (Property, Method, Indexer): Emit Final flag on the
24506 method if we are an interface implementation and we are not
24509 * ecore.cs (PropertyExpr): New public field `IsBase', tells
24510 whether this property is referencing a `base' method.
24512 * expression.cs (Invocation.EmitCall): take an extra argument:
24513 is_base, this is used to determine whether the `call' or
24514 `callvirt' opcode should be used.
24517 * delegate.cs: update EmitCall.
24519 * class.cs (Method.Define): Set NewSlot for the cases where we are
24520 not implementing an interface method.
24522 (Property.Define): ditto.
24524 2002-01-02 Miguel de Icaza <miguel@ximian.com>
24526 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
24527 'r'. Allows mcs to parse itself fully.
24529 2002-01-02 Ravi Pratap <ravi@ximian.com>
24531 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
24532 of the number of initializers that require the InitializeArray method.
24534 (CheckIndices): Store the Expression in all cases - not the plain value. Also
24535 update the above field where necessary.
24537 (MakeByteBlob): Update accordingly.
24539 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
24542 (EmitDynamicInitializers): Update in accordance with the new optimization.
24544 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
24545 same OpCode applies.
24547 * cs-parser.jay : Fix some glaring errors I introduced.
24549 2002-01-01 Ravi Pratap <ravi@ximian.com>
24551 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
24552 so that we can check for name clashes there too.
24554 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
24555 for interface indexers.
24557 * interfaces.cs (Define): Emit the default member attribute.
24559 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
24560 variable was being referred to while setting the value ;-)
24562 2002-01-01 Miguel de Icaza <miguel@ximian.com>
24564 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
24565 byte-by-byte information when we know the data is zero.
24567 Make the block always a multiple of 4, because
24568 DefineInitializedData has a bug.
24570 * assign.cs: Fix, we should assign from the temporary, not from
24573 * expression.cs (MakeByteBlob): Fix my incorrect code.
24575 2001-12-31 Miguel de Icaza <miguel@ximian.com>
24577 * typemanager.cs (EnumToUnderlying): This function is used to get
24578 the underlying type from an enumeration, because it does not
24581 * constant.cs: Use the I4_S form for values between -128 and 127.
24583 * statement.cs (Block.LookupLabel): Looks up a label.
24584 (Block): Drop support for labeled blocks.
24586 (LabeledStatement): New kind of statement that represents a label
24589 (Goto): Finally implement this bad boy.
24591 * cs-parser.jay: Update to reflect new mechanism to implement
24594 2001-12-30 Miguel de Icaza <miguel@ximian.com>
24596 * codegen.cs (EmitContext.This): a codegen property that keeps the
24597 a single instance of this instead of creating many different this
24600 * delegate.cs (Delegate.DoResolve): Update to use the property;
24602 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
24604 * expression.cs (BaseAccess.DoResolve): Ditto.
24606 2001-12-29 Ravi Pratap <ravi@ximian.com>
24608 * typemanager.cs (methodimpl_attr_type): Add to hold the type
24609 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
24611 (InitCoreTypes): Update accordingly.
24613 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
24614 so we can quickly store the state.
24616 (ApplyAttributes): Set the correct implementation flags
24617 for InternalCall methods.
24619 2001-12-29 Miguel de Icaza <miguel@ximian.com>
24621 * expression.cs (EmitCall): if a method is not virtual, then do
24622 not use callvirt on it.
24624 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
24625 user defined stuff) requires the use of stobj, which takes an
24626 address on the stack instead of an array and an index. So emit
24627 the Ldelema operation for it.
24629 (EmitStoreOpcode): Use stobj for valuetypes.
24631 (UnaryMutator.EmitCode): Use the right 1 value depending on
24632 whether we are dealing with int64/uint64, float or doubles.
24634 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
24635 constructors that I implemented last night.
24637 (Constructor.IsDefault): Fix to work properly for static
24640 * cs-parser.jay (CheckDef): report method signature errors.
24641 Update error number 103 to be 132.
24643 * decl.cs: New AdditionResult enumeration value: MethodExists.
24644 Although we do this check for methods later on in the semantic
24645 analysis, catching repeated default constructors is so easy that
24646 we catch these here.
24648 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
24651 (ParameterReference.EmitAssign, Emit): handle
24654 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
24655 (ArrayAccess.EmitStoreOpcode): ditto.
24657 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
24659 * expression.cs (MakeByteBlob): Complete all the missing types
24660 (uint, short, ushort, byte, sbyte)
24662 * class.cs: Only init instance field initializers on instance
24665 Rename `constructors' to instance_constructors.
24667 (TypeContainer.AddConstructor): Only add constructors to the list
24668 if it is not static.
24670 Make sure that we handle default_static_constructor independently
24671 everywhere where we handle instance_constructors
24673 2001-12-28 Miguel de Icaza <miguel@ximian.com>
24675 * class.cs: Do not lookup or create a base initializer for a
24676 static constructor.
24678 (ConstructorInitializer.Resolve): use the proper type to lookup
24681 * cs-parser.jay: Report error 1585 (modifiers between type and name).
24683 * enum.cs, interface.cs: Remove CloseType, this is taken care by
24686 * decl.cs: CloseType is now an virtual method, the default
24687 implementation just closes this type.
24689 2001-12-28 Ravi Pratap <ravi@ximian.com>
24691 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
24692 to PreserveSig by default. Also emit HideBySig on such methods.
24694 Basically, set the defaults to standard values.
24696 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
24697 argument, if candidate is better, it can't be worse than the best !
24699 (Invocation): Re-write bits to differentiate between methods being
24700 applicable in their expanded form and their normal form - for params
24703 Get rid of use_standard everywhere as only standard conversions are allowed
24704 in overload resolution.
24706 More spec conformance.
24708 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24710 * driver.cs: Add --timestamp, to see where the compiler spends
24713 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
24714 `this' in static code.
24716 (SimpleName.DoResolve): Implement in terms of a helper function
24717 that allows static-references to be passed upstream to
24720 (Expression.ResolveWithSimpleName): Resolve specially simple
24721 names when called by MemberAccess to implement the special
24724 (Expression.ImplicitReferenceConversion): Handle conversions from
24725 Null to reference types before others, as Null's type is
24728 * expression.cs (Invocation.EmitCall): Handle the special case of
24729 calling methods declared on a reference type from a ValueType
24730 (Base classes System.Object and System.Enum)
24732 (MemberAccess.Resolve): Only perform lookups on Enumerations if
24733 the left hand side is a TypeExpr, not on every enumeration.
24735 (Binary.Resolve): If types are reference types, then do a cast to
24736 object on operators != and == of both arguments.
24738 * typemanager.cs (FindMembers): Extract instance and static
24739 members if requested.
24741 * interface.cs (PopulateProperty): Use void_type instead of null
24742 as the return type for the setter method.
24744 (PopulateIndexer): ditto.
24746 2001-12-27 Ravi Pratap <ravi@ximian.com>
24748 * support.cs (ReflectionParameters): Fix minor bug where we
24749 were examining the wrong parameter for the ParamArray attribute.
24751 Cope with requests for the type of the parameter at position
24752 greater than the params parameter's. We now return the element
24753 type of the params array as that makes more sense.
24755 * expression.cs (Invocation.IsParamsMethodApplicable): Update
24756 accordingly as we no longer have to extract the element type
24759 (Invocation.OverloadResolve): Update.
24761 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24763 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
24764 against IEnumerator, test whether the return value is a descendant
24765 of the IEnumerator interface.
24767 * class.cs (Indexer.Define): Use an auxiliary method to implement
24768 the other bits of the method definition. Begin support for
24769 explicit interface implementation.
24771 (Property.DefineMethod): Use TypeManager.void_type instead of null
24772 for an empty return value.
24774 2001-12-26 Miguel de Icaza <miguel@ximian.com>
24776 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
24777 dealing with a FieldExpr which is composed of a FieldBuilder, in
24778 the code path we did extract the constant, but we should have
24779 obtained the underlying value to be able to cast it (otherwise we
24780 end up in an infinite loop, this is what Ravi was running into).
24782 (ArrayCreation.UpdateIndices): Arrays might be empty.
24784 (MemberAccess.ResolveMemberAccess): Add support for section
24785 14.5.4.1 that deals with the special case of E.I when E is a type
24786 and something else, that I can be a reference to a static member.
24788 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
24789 handle a particular array type to create byte blobs, it is just
24790 something we dont generate byteblobs for.
24792 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
24795 * location.cs (Push): remove the key from the hashtable that we
24796 are about to add. This happens for empty files.
24798 * driver.cs: Dispose files after we have parsed them.
24800 (tokenize): new function that only runs the tokenizer on its
24801 input, for speed testing.
24803 2001-12-26 Ravi Pratap <ravi@ximian.com>
24805 * class.cs (Event.Define): Define the private field only if there
24806 are no accessors defined.
24808 * expression.cs (ResolveMemberAccess): If there is no associated
24809 field with the event, that means we have an event defined with its
24810 own accessors and we should flag error cs0070 since transforming
24811 ourselves into a field is not valid in that case.
24813 * ecore.cs (SimpleName.DoResolve): Same as above.
24815 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
24816 and charset to sane values.
24818 2001-12-25 Ravi Pratap <ravi@ximian.com>
24820 * assign.cs (DoResolve): Perform check on events only if they
24821 are being accessed outside the declaring type.
24823 * cs-parser.jay (event_declarations): Update rules to correctly
24824 set the type of the implicit parameter etc.
24826 (add_accessor, remove_accessor): Set current local parameters.
24828 * expression.cs (Binary): For delegate addition and subtraction,
24829 cast the return value from the method into the appropriate delegate
24832 2001-12-24 Ravi Pratap <ravi@ximian.com>
24834 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
24835 of these as the workaround is unnecessary.
24837 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
24838 delegate data - none of that is needed at all.
24840 Re-write bits to extract the instance expression and the delegate method
24843 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
24846 * attribute.cs (ApplyAttributes): New method to take care of common tasks
24847 of attaching attributes instead of duplicating code everywhere.
24849 * everywhere : Update code to do attribute emission using the above method.
24851 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24853 * expression.cs (IsParamsMethodApplicable): if there are not
24854 parameters, return immediately.
24856 * ecore.cs: The 0 literal can be implicity converted to an enum
24859 (SimpleName.DoResolve): First lookup the type, then lookup the
24862 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
24863 want to get its address. If the InstanceExpression is not
24864 addressable, store the result in a temporary variable, then get
24867 * codegen.cs: Only display 219 errors on warning level or above.
24869 * expression.cs (ArrayAccess): Make it implement the
24870 IMemoryLocation interface.
24872 (Binary.DoResolve): handle the operator == (object a, object b)
24873 and operator != (object a, object b) without incurring into a
24874 BoxedCast (because 5 != o should never be performed).
24876 Handle binary enumerator operators.
24878 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
24879 value type, otherwise use Ldelem_ref.
24881 Use precomputed names;
24883 (AddressOf): Implement address of
24885 * cs-parser.jay (labeled_statement): Fix recursive block
24886 addition by reworking the production.
24888 * expression.cs (New.DoEmit): New has a special case:
24890 If we are dealing with a ValueType, we have a few
24891 situations to deal with:
24893 * The target of New is a ValueType variable, that is
24894 easy, we just pass this as the variable reference
24896 * The target of New is being passed as an argument,
24897 to a boxing operation or a function that takes a
24900 In this case, we need to create a temporary variable
24901 that is the argument of New.
24904 2001-12-23 Ravi Pratap <ravi@ximian.com>
24906 * rootcontext.cs (LookupType): Check that current_type is not null before
24907 going about looking at nested types.
24909 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
24910 not implement the IAssignMethod interface any more.
24912 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
24913 where we tranform them into FieldExprs if they are being resolved from within
24914 the declaring type.
24916 * ecore.cs (SimpleName.DoResolve): Do the same here.
24918 * assign.cs (DoResolve, Emit): Clean up code considerably.
24920 * ../errors/bug10.cs : Add.
24922 * ../errors/cs0070.cs : Add.
24924 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
24926 * assign.cs : Get rid of EventIsLocal everywhere.
24928 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24930 * ecore.cs (ConvertIntLiteral): finished the implementation.
24932 * statement.cs (SwitchLabel): Convert the value we are using as a
24933 key before looking up the table.
24935 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24937 * codegen.cs (EmitTopBlock): Require a Location argument now.
24939 * cs-parser.jay (constructor_declarator): We need to setup
24940 current_local_parameters before we parse the
24941 opt_constructor_initializer, to allow the variables to be bound
24942 to the constructor arguments.
24944 * rootcontext.cs (LookupType): First lookup nested classes in our
24945 class and our parents before we go looking outside our class.
24947 * expression.cs (ConstantFold): Extract/debox the values at the
24950 * rootcontext.cs (EmitCode): Resolve the constants first before we
24951 resolve the types. This is not really needed, but it helps debugging.
24953 * statement.cs: report location.
24955 * cs-parser.jay: pass location to throw statement.
24957 * driver.cs: Small bug fix.
24959 * report.cs: Updated format to be 4-zero filled digits.
24961 2001-12-22 Ravi Pratap <ravi@ximian.com>
24963 * expression.cs (CheckIndices): Fix minor bug where the wrong
24964 variable was being referred to ;-)
24966 (DoEmit): Do not call EmitStaticInitializers when the
24967 underlying type is System.Object.
24969 2001-12-21 Ravi Pratap <ravi@ximian.com>
24971 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
24972 and do the usual workaround for SRE.
24974 * class.cs (MyEventBuilder.EventType): New member to get at the type
24975 of the event, quickly.
24977 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
24979 * assign.cs (Assign.DoResolve): Handle the case when the target
24980 is an EventExpr and perform the necessary checks.
24982 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
24985 (SimpleName.MemberStaticCheck): Include check for EventExpr.
24987 (EventExpr): Set the type in the constructor itself since we
24988 are meant to be born fully resolved.
24990 (EventExpr.Define): Revert code I wrote earlier.
24992 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
24993 instance expression is null. The instance expression is a This in that case
24994 or a null, depending on whether it is a static method or not.
24996 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
24997 refers to more than one method.
24999 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
25000 and accordingly flag errors.
25002 2001-12-21 Miguel de Icaza <miguel@ximian.com>
25004 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
25006 2001-12-22 Miguel de Icaza <miguel@ximian.com>
25008 * location.cs (ToString): Provide useful rutine.
25010 2001-12-21 Miguel de Icaza <miguel@ximian.com>
25012 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
25013 objects, return the actual integral boxed.
25015 * statement.cs (SwitchLabel): define an ILLabel for each
25018 (Switch.CheckSwitch): If the value is a Literal, extract
25019 the underlying literal.
25021 Also in the unused hashtable we had, add the SwitchLabel so we can
25022 quickly look this value up.
25024 * constant.cs: Implement a bunch of new constants. Rewrite
25025 Literal based on this. Made changes everywhere to adapt to this.
25027 * expression.cs (Expression.MakeByteBlob): Optimize routine by
25028 dereferencing array only once, and also copes with enumrations.
25030 bytes are two bytes wide, not one.
25032 (Cast): Perform constant conversions.
25034 * ecore.cs (TryImplicitIntConversion): Return literals instead of
25035 wrappers to the literals here.
25037 * expression.cs (DoNumericPromotions): long literals can converted
25038 to ulong implicity (this is taken care of elsewhere, but I was
25039 missing this spot).
25041 * ecore.cs (Expression.Literalize): Make the return type Literal,
25042 to improve type checking.
25044 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
25046 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25048 * literal.cs: Revert code from ravi that checked the bounds. The
25049 bounds are sane by the definition of the type itself.
25051 * typemanager.cs: Fix implementation of ImplementsInterface. We
25052 need to actually look up in our parent hierarchy for interfaces
25055 * const.cs: Use the underlying type for enumerations
25057 * delegate.cs: Compute the basename for the delegate creation,
25058 that should fix the delegate test case, and restore the correct
25059 Type Lookup semantics in rootcontext
25061 * rootcontext.cs: Revert Ravi's last patch. The correct way of
25062 referencing a nested type with the Reflection API is using the "+"
25065 * cs-parser.jay: Do not require EOF token at the end.
25067 2001-12-20 Ravi Pratap <ravi@ximian.com>
25069 * rootcontext.cs (LookupType): Concatenate type names with
25070 a '.' instead of a '+' The test suite passes again.
25072 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
25073 field of the enumeration.
25075 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
25076 the case when the member is an EventExpr.
25078 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
25079 static has an associated instance expression.
25081 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
25083 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
25085 * class.cs (Event.Define): Register event and perform appropriate checks
25088 We define the Add and Remove methods even if the use provides none because
25089 in that case, we provide default implementations ourselves.
25091 Define a private field of the type of the event. This is done by the CSC compiler
25092 and we should be doing it too ;-)
25094 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
25095 More methods we use in code we generate.
25097 (multicast_delegate_type, delegate_type): Two separate types since the distinction
25100 (InitCoreTypes): Update accordingly for the above.
25102 * class.cs (Event.Emit): Generate code for default accessors that we provide
25104 (EmitDefaultMethod): Do the job in the above.
25106 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
25109 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25111 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
25112 builders even if we were missing one.
25114 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
25115 pass the Basename as our class name instead of the Name. The
25116 basename will be correctly composed for us.
25118 * parameter.cs (Paramters): Now takes a Location argument.
25120 * decl.cs (DeclSpace.LookupType): Removed convenience function and
25121 make all the code call directly LookupType in RootContext and take
25122 this chance to pass the Location information everywhere.
25124 * Everywhere: pass Location information.
25126 2001-12-19 Miguel de Icaza <miguel@ximian.com>
25128 * class.cs (Constructor.Define): Updated way of detecting the
25129 length of the parameters.
25131 (TypeContainer.DefineType): Use basename as the type name for
25134 (TypeContainer.Define): Do not recursively define types here, as
25135 definition is taken care in order by the RootContext.
25137 * tree.cs: Keep track of namespaces in a per-file basis.
25139 * parameter.cs (Parameter.ComputeSignature): Update to use
25142 (Parameters.GetSignature): ditto.
25144 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
25145 instead of a TypeContainer.
25147 (Interface.SemanticAnalysis): Use `this' instead of our parent to
25148 resolve names. Because we need to be resolve in our context, not
25151 * driver.cs: Implement response files.
25153 * class.cs (TypeContainer.DefineType): If we are defined, do not
25154 redefine ourselves.
25156 (Event.Emit): Emit the code for add/remove handlers.
25157 (Event.Define): Save the MethodBuilders for add/remove.
25159 * typemanager.cs: Use pair here too.
25161 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
25162 DictionaryEntry requires the first argument to be non-null.
25164 (enum_declaration): Compute full name for registering the
25167 (delegate_declaration): Instead of using
25168 formal_parameter_list, use opt_formal_parameter_list as the list
25171 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
25172 (EventParsing): New property that controls whether `add' and
25173 `remove' are returned as tokens or identifiers (for events);
25175 2001-12-19 Ravi Pratap <ravi@ximian.com>
25177 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
25178 use MyEventBuilder only and let it wrap the real builder for us.
25180 (MyEventBuilder): Revamp constructor etc.
25182 Implement all operations that we perform on EventBuilder in precisely the same
25185 (FindMembers): Update to use the EventBuilder member.
25187 (Event.Emit): Update accordingly.
25189 2001-12-18 Ravi Pratap <ravi@ximian.com>
25191 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
25192 by calling the appropriate methods.
25194 (GetCustomAttributes): Make stubs as they cannot possibly do anything
25197 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
25199 2001-12-17 Ravi Pratap <ravi@ximian.com>
25201 * delegate.cs (Delegate.Populate): Check that the return type
25202 and various parameters types are indeed accessible.
25204 * class.cs (Constructor.Define): Same here.
25206 (Field.Define): Ditto.
25208 (Event.Define): Ditto.
25210 (Operator.Define): Check that the underlying Method defined itself
25211 correctly - so it's MethodBuilder should not be null.
25213 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
25214 expression happens to be null.
25216 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
25217 members but as of now we don't seem to be able to do anything really useful with it.
25219 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
25220 not the EventBuilder.
25222 2001-12-18 Miguel de Icaza <miguel@ximian.com>
25224 * cs-tokenizer.cs: Add support for defines.
25225 Add support for #if, #elif, #else, #endif
25227 (eval_var): evaluates a variable.
25228 (eval): stubbed for evaluating functions.
25230 * cs-parser.jay: Pass the defines information
25232 * driver.cs: Add --define command line option.
25234 * decl.cs: Move MemberCore here.
25236 Make it the base class for DeclSpace. This allows us to catch and
25237 report 108 and 109 for everything now.
25239 * class.cs (TypeContainer.Define): Extract all the members
25240 before populating and emit the warning 108 (new keyword required
25241 to override) instead of having each member implement this.
25243 (MemberCore.Define): New abstract method, we will be using this in
25244 the warning reporting engine in Populate.
25246 (Operator.Define): Adjust to new MemberCore protocol.
25248 * const.cs (Const): This does not derive from Expression, it is a
25249 temporary object we use to create fields, it is a MemberCore.
25251 * class.cs (Method.Define): Allow the entry point to be in a
25254 * driver.cs: Rewrite the argument handler to clean it up a bit.
25256 * rootcontext.cs: Made it just an auxiliary namespace feature by
25257 making everything static.
25259 * driver.cs: Adapt code to use RootContext type name instead of
25262 * delegate.cs: Remove RootContext argument.
25264 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
25267 * class.cs (Event.Define): The lookup can fail.
25269 * cs-tokenizer.cs: Begin implementation of pre-procesor.
25271 * expression.cs: Resolve the this instance before invoking the code.
25273 2001-12-17 Miguel de Icaza <miguel@ximian.com>
25275 * cs-parser.jay: Add a production in element_access that allows
25276 the thing to become a "type" reference. This way we can parse
25277 things like "(string [])" as a type.
25279 Note that this still does not handle the more complex rules of
25283 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
25285 * ecore.cs: (CopyNewMethods): new utility function used to
25286 assemble the list of methods from running FindMembers.
25288 (MemberLookup): Rework FindMembers so that
25290 2001-12-16 Miguel de Icaza <miguel@ximian.com>
25292 * class.cs (TypeContainer): Remove Delegates who fail to be
25295 * delegate.cs (Populate): Verify that we dont get null return
25296 values. TODO: Check for AsAccessible.
25298 * cs-parser.jay: Use basename to emit error 574 (destructor should
25299 have the same name as container class), not the full name.
25301 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
25302 possible representation.
25304 Also implements integer type suffixes U and L.
25306 2001-12-15 Miguel de Icaza <miguel@ximian.com>
25308 * expression.cs (ArrayCreation.DoResolve): We need to do the
25309 argument resolution *always*.
25311 * decl.cs: Make this hold the namespace. Hold the root context as
25313 (LookupType): Move here.
25315 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
25317 * location.cs (Row, Name): Fixed the code, it was always returning
25318 references to the first file.
25320 * interface.cs: Register properties defined through interfaces.
25322 * driver.cs: Add support for globbing on the command line
25324 * class.cs (Field): Make it derive from MemberCore as well.
25327 2001-12-15 Ravi Pratap <ravi@ximian.com>
25329 * class.cs (Event::Define): Check that the type of the event is a delegate
25330 type else flag error #66.
25332 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
25335 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
25336 values of EntryPoint, CharSet etc etc.
25338 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
25340 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
25341 be null and we should ignore this. I am not sure if this is really clean. Apparently,
25342 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
25343 which needs this to do its work.
25345 * ../errors/cs0066.cs : Add.
25347 2001-12-14 Miguel de Icaza <miguel@ximian.com>
25349 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
25352 * class.cs: (MethodSignature.MethodSignature): Removed hack that
25353 clears out the parameters field.
25354 (MemberSignatureCompare): Cleanup
25356 (MemberCore): New base class used to share code between MethodCore
25359 (RegisterRequiredImplementations) BindingFlags.Public requires
25360 either BindingFlags.Instace or Static. Use instance here.
25362 (Property): Refactored code to cope better with the full spec.
25364 * parameter.cs (GetParameterInfo): Return an empty array instead
25367 * class.cs (Property): Abstract or extern properties have no bodies.
25369 * parameter.cs (GetParameterInfo): return a zero-sized array.
25371 * class.cs (TypeContainer.MethodModifiersValid): Move all the
25372 method modifier validation to the typecontainer so we can reuse
25373 this on properties.
25375 (MethodCore.ParameterTypes): return an empty sized array of types.
25377 (Property.Define): Test property modifier validity.
25379 Add tests for sealed/override too.
25381 (Method.Emit): abstract or extern methods have no bodies.
25383 2001-12-14 Ravi Pratap <ravi@ximian.com>
25385 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
25388 (Method::Define, ::Emit): Modify accordingly.
25390 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
25392 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
25394 * makefile: Pass in /unsafe.
25396 2001-12-13 Miguel de Icaza <miguel@ximian.com>
25398 * class.cs (MakeKey): Kill routine.
25400 * class.cs (TypeContainer.Define): Correctly define explicit
25401 method implementations (they require the full interface name plus
25404 * typemanager.cs: Deply the PtrHashtable here and stop using the
25405 lame keys. Things work so much better.
25407 This of course broke everyone who depended on `RegisterMethod' to
25408 do the `test for existance' test. This has to be done elsewhere.
25410 * support.cs (PtrHashtable): A hashtable that avoid comparing with
25411 the object stupid Equals method (because, that like fails all over
25412 the place). We still do not use it.
25414 * class.cs (TypeContainer.SetRequiredInterface,
25415 TypeContainer.RequireMethods): Killed these two routines and moved
25416 all the functionality to RegisterRequiredImplementations.
25418 (TypeContainer.RegisterRequiredImplementations): This routine now
25419 registers all the implementations required in an array for the
25420 interfaces and abstract methods. We use an array of structures
25421 which can be computed ahead of time to reduce memory usage and we
25422 also assume that lookups are cheap as most classes will not
25423 implement too many interfaces.
25425 We also avoid creating too many MethodSignatures.
25427 (TypeContainer.IsInterfaceMethod): Update and optionally does not
25428 clear the "pending" bit if we find that there are problems with
25431 (TypeContainer.VerifyPendingMethods): Update to report errors of
25432 methods that look like implementations but are not.
25434 (TypeContainer.Define): Add support for explicit interface method
25437 2001-12-12 Miguel de Icaza <miguel@ximian.com>
25439 * typemanager.cs: Keep track of the parameters here instead of
25440 being a feature of the TypeContainer.
25442 * class.cs: Drop the registration of parameters here, as
25443 InterfaceMethods are also interface declarations.
25445 * delegate.cs: Register methods with the TypeManager not only with
25446 the TypeContainer. This code was buggy.
25448 * interface.cs: Full registation here.
25450 2001-12-11 Miguel de Icaza <miguel@ximian.com>
25452 * expression.cs: Remove reducer for binary expressions, it can not
25455 * const.cs: Put here the code that used to go into constant.cs
25457 * constant.cs: Put here the code for constants, this is a new base
25458 class for Literals.
25460 * literal.cs: Make Literal derive from Constant.
25462 2001-12-09 Miguel de Icaza <miguel@ximian.com>
25464 * statement.cs (Return.Emit): Report error 157 if the user
25465 attempts to return from a finally block.
25467 (Return.Emit): Instead of emitting a return, jump to the end of
25470 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
25471 LocalBuilder to store the result of the function. ReturnLabel is
25472 the target where we jump.
25475 2001-12-09 Radek Doulik <rodo@ximian.com>
25477 * cs-parser.jay: remember alias in current namespace
25479 * ecore.cs (SimpleName::DoResolve): use aliases for types or
25482 * class.cs (LookupAlias): lookup alias in my_namespace
25484 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
25486 (LookupAlias): lookup alias in this and if needed in parent
25489 2001-12-08 Miguel de Icaza <miguel@ximian.com>
25493 * rootcontext.cs: (ModuleBuilder) Made static, first step into
25494 making things static. I need this to avoid passing the
25495 TypeContainer when calling ParameterType.
25497 * support.cs (InternalParameters.ParameterType): Remove ugly hack
25498 that did string manipulation to compute the type and then call
25499 GetType. Use Parameter.ParameterType instead.
25501 * cs-tokenizer.cs: Consume the suffix for floating values.
25503 * expression.cs (ParameterReference): figure out whether this is a
25504 reference parameter or not. Kill an extra variable by computing
25505 the arg_idx during emission.
25507 * parameter.cs (Parameters.GetParameterInfo): New overloaded
25508 function that returns whether a parameter is an out/ref value or not.
25510 (Parameter.ParameterType): The type of the parameter (base,
25511 without ref/out applied).
25513 (Parameter.Resolve): Perform resolution here.
25514 (Parameter.ExternalType): The full type (with ref/out applied).
25516 * statement.cs (Using.Emit, Using.EmitExpression): Implement
25517 support for expressions on the using statement.
25519 2001-12-07 Miguel de Icaza <miguel@ximian.com>
25521 * statement.cs (Using.EmitLocalVariableDecls): Split the
25522 localvariable handling of the using statement.
25524 (Block.EmitMeta): Keep track of variable count across blocks. We
25525 were reusing slots on separate branches of blocks.
25527 (Try.Emit): Emit the general code block, we were not emitting it.
25529 Check the type of the declaration to be an IDisposable or
25530 something that can be implicity converted to it.
25532 Emit conversions if required.
25534 * ecore.cs (EmptyExpression): New utility class.
25535 (Expression.ImplicitConversionExists): New utility function.
25537 2001-12-06 Miguel de Icaza <miguel@ximian.com>
25539 * statement.cs (Using): Implement.
25541 * expression.cs (LocalVariableReference): Support read only variables.
25543 * statement.cs: Remove the explicit emit for the Leave opcode.
25544 (VariableInfo): Add a readonly field.
25546 2001-12-05 Miguel de Icaza <miguel@ximian.com>
25548 * ecore.cs (ConvCast): new class used to encapsulate the various
25549 explicit integer conversions that works in both checked and
25550 unchecked contexts.
25552 (Expression.ConvertNumericExplicit): Use new ConvCast class to
25553 properly generate the overflow opcodes.
25555 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25557 * statement.cs: The correct type for the EmptyExpression is the
25558 element_type, not the variable type. Ravi pointed this out.
25560 2001-12-04 Ravi Pratap <ravi@ximian.com>
25562 * class.cs (Method::Define): Handle PInvoke methods specially
25563 by using DefinePInvokeMethod instead of the usual one.
25565 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
25566 above to do the task of extracting information and defining the method.
25568 2001-12-04 Ravi Pratap <ravi@ximian.com>
25570 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
25571 of the condition for string type.
25573 (Emit): Move that here.
25575 (ArrayCreation::CheckIndices): Keep string literals in their expression
25578 (EmitDynamicInitializers): Handle strings appropriately.
25580 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25582 * codegen.cs (EmitContext): Replace multiple variables with a
25583 single pointer to the current Switch statement.
25585 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
25588 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25592 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
25595 (Foreach.Emit): Foreach on arrays was not setting
25596 up the loop variables (for break/continue).
25598 (GotoCase): Semi-implented.
25600 2001-12-03 Ravi Pratap <ravi@ximian.com>
25602 * attribute.cs (CheckAttribute): Handle system attributes by using
25603 Attribute.GetAttributes to examine information we need.
25605 (GetValidPlaces): Same here.
25607 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
25609 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
25611 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
25613 (Method::Define): Set appropriate flags if we have a DllImport attribute.
25615 (Method::Emit): Handle the case when we are a PInvoke method.
25617 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25619 * expression.cs: Use ResolveWithSimpleName on compound names.
25621 2001-12-02 Ravi Pratap <ravi@ximian.com>
25623 * constant.cs (EmitConstant): Make sure we resolve the associated expression
25624 before trying to reduce it.
25626 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
25628 * constant.cs (LookupConstantValue): Implement.
25630 (EmitConstant): Use the above in emitting the constant.
25632 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
25633 that are user-defined by doing a LookupConstantValue on them.
25635 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
25638 2001-11-29 Miguel de Icaza <miguel@ximian.com>
25640 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
25642 (BaseAccess.DoResolve): Implement.
25644 (MemberAccess.DoResolve): Split this routine into a
25645 ResolveMemberAccess routine that can be used independently
25647 2001-11-28 Miguel de Icaza <miguel@ximian.com>
25649 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
25650 As that share bits of the implementation. Is returns a boolean,
25651 while As returns the Type that is being probed.
25653 2001-12-01 Ravi Pratap <ravi@ximian.com>
25655 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
25656 instead of a Literal - much easier.
25658 (EnumInTransit): Remove - utterly useless :-)
25660 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
25662 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
25664 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
25665 chain when we have no associated expression.
25667 2001-11-30 Ravi Pratap <ravi@ximian.com>
25669 * constant.cs (Define): Use Location while reporting the errror.
25671 Also emit a warning when 'new' is used and there is no inherited
25674 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
25677 (LookupEnumValue): Implement to lookup an enum member's value and define it
25680 (Populate): Re-write accordingly to use the above routine.
25682 2001-11-27 Miguel de Icaza <miguel@ximian.com>
25684 * expression.cs (This): Fix prototype for DoResolveLValue to
25685 override the base class DoResolveLValue.
25687 * cs-parser.cs: Report errors cs574 and cs575 (destructor
25690 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
25691 (we need to load the address of the field here). This fixes
25694 (FieldExpr.DoResolveLValue): Call the DoResolve
25695 function to initialize the Instance expression.
25697 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
25698 correctly the GetEnumerator operation on a value type.
25700 * cs-parser.jay: Add more simple parsing error catches.
25702 * statement.cs (Switch): Add support for string switches.
25703 Handle null specially.
25705 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
25707 2001-11-28 Ravi Pratap <ravi@ximian.com>
25709 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
25711 (declare_local_constant): New helper function.
25713 * statement.cs (AddConstant): Keep a separate record of constants
25715 (IsConstant): Implement to determine if a variable is a constant.
25717 (GetConstantExpression): Implement.
25719 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
25721 * statement.cs (IsVariableDefined): Re-write.
25723 2001-11-27 Ravi Pratap <ravi@ximian.com>
25725 * class.cs (TypeContainer::FindMembers): Look for constants
25726 in the case when we are looking for MemberTypes.Field
25728 * expression.cs (MemberAccess::DoResolve): Check that in the
25729 case we are a FieldExpr and a Literal, we are not being accessed
25730 by an instance reference.
25732 * cs-parser.jay (local_constant_declaration): Implement.
25734 (declaration_statement): Implement for constant declarations.
25736 2001-11-26 Miguel de Icaza <miguel@ximian.com>
25738 * statement.cs (Switch): Catch double defaults.
25740 (Switch): More work on the switch() statement
25741 implementation. It works for integral values now, need to finish
25745 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25747 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
25748 integer literals into other integer literals. To be used by
25751 2001-11-24 Ravi Pratap <ravi@ximian.com>
25753 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
25756 (EmitDynamicInitializers): Cope with the above since we extract data
25757 directly from ArrayData now.
25759 (ExpectInitializers): Keep track of whether initializers are mandatory
25762 (Bounds): Make it a hashtable to prevent the same dimension being
25763 recorded for every element in that dimension.
25765 (EmitDynamicInitializers): Fix bug which prevented the Set array method
25768 Also fix bug which was causing the indices to be emitted in the reverse
25771 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25773 * expression.cs (ArrayCreation): Implement the bits that Ravi left
25774 unfinished. They do not work, because the underlying code is
25777 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25779 * cs-parser.jay: Remove bogus fixme.
25781 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
25782 on Switch statement.
25784 2001-11-23 Ravi Pratap <ravi@ximian.com>
25786 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
25789 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
25790 parameter. Apparently, any expression is allowed.
25792 (ValidateInitializers): Update accordingly.
25794 (CheckIndices): Fix some tricky bugs thanks to recursion.
25796 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
25797 I was being completely brain-dead.
25799 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
25800 and re-write acordingly.
25802 (DelegateInvocation): Re-write accordingly.
25804 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
25806 (MakeByteBlob): Handle types more correctly.
25808 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
25809 initialization from expressions but it is incomplete because I am a complete
25812 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25814 * statement.cs (If.Emit): Fix a bug that generated incorrect code
25815 on If. Basically, we have to return `true' (ie, we do return to
25816 our caller) only if both branches of the if return.
25818 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
25819 short-circuit operators, handle them as short circuit operators.
25821 (Cast.DoResolve): Resolve type.
25822 (Cast.Cast): Take an expression as the target type.
25824 * cs-parser.jay (cast_expression): Remove old hack that only
25825 allowed a limited set of types to be handled. Now we take a
25826 unary_expression and we resolve to a type during semantic
25829 Use the grammar productions from Rhys to handle casts (this is
25830 not complete like Rhys syntax yet, we fail to handle that corner
25831 case that C# has regarding (-x), but we will get there.
25833 2001-11-22 Ravi Pratap <ravi@ximian.com>
25835 * class.cs (EmitFieldInitializer): Take care of the case when we have a
25836 field which is an array type.
25838 * cs-parser.jay (declare_local_variables): Support array initialization too.
25840 * typemanager.cs (MakeKey): Implement.
25842 (everywhere): Use the above appropriately.
25844 * cs-parser.jay (for_statement): Update for array initialization while
25845 declaring variables.
25847 * ecore.cs : The error message was correct, it's the variable's names that
25848 were misleading ;-) Make the code more readable.
25850 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
25851 the correct type etc.
25853 (ConvertExplicit): Handle Enum types by examining the underlying type.
25855 2001-11-21 Ravi Pratap <ravi@ximian.com>
25857 * parameter.cs (GetCallingConvention): Always return
25858 CallingConventions.Standard for now.
25860 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25862 * expression.cs (Binary.ResolveOperator): Update the values of `l'
25863 and `r' after calling DoNumericPromotions.
25865 * ecore.cs: Fix error message (the types were in the wrong order).
25867 * statement.cs (Foreach.ProbeCollectionType): Need to pass
25868 BindingFlags.Instance as well
25870 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
25871 implicit int literal conversion in an empty cast so that we
25872 propagate the right type upstream.
25874 (UnboxCast): new class used to unbox value types.
25875 (Expression.ConvertExplicit): Add explicit type conversions done
25878 (Expression.ImplicitNumericConversion): Oops, forgot to test for
25879 the target type before applying the implicit LongLiterals to ULong
25882 2001-11-21 Miguel de Icaza <miguel@ximian.com>
25884 * cs-parser.jay (for_statement): Reworked the way For works: now
25885 we declare manually any variables that are introduced in
25886 for_initializer to solve the problem of having out-of-band code
25887 emition (that is what got for broken).
25889 (declaration_statement): Perform the actual variable declaration
25890 that used to be done in local_variable_declaration here.
25892 (local_variable_declaration): Do not declare anything, just pass
25893 the information on a DictionaryEntry
25895 2001-11-20 Ravi Pratap <ravi@ximian.com>
25897 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
25898 re-write of the logic to now make it recursive.
25900 (UpdateIndices): Re-write accordingly.
25902 Store element data in a separate ArrayData list in the above methods.
25904 (MakeByteBlob): Implement to dump the array data into a byte array.
25906 2001-11-19 Ravi Pratap <ravi@ximian.com>
25908 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
25911 * constant.cs (Define): Implement.
25913 (EmitConstant): Re-write fully.
25915 Pass in location info.
25917 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
25920 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
25921 DictionaryEntry since we need location info too.
25923 (constant_declaration): Update accordingly.
25925 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
25926 code into another method : UpdateIndices.
25928 2001-11-18 Ravi Pratap <ravi@ximian.com>
25930 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
25931 some type checking etc.
25933 2001-11-17 Ravi Pratap <ravi@ximian.com>
25935 * expression.cs (ArrayCreation::ValidateInitializers): Implement
25936 bits to provide dimension info if the user skips doing that.
25938 Update second constructor to store the rank correctly.
25940 2001-11-16 Ravi Pratap <ravi@ximian.com>
25942 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
25943 and try to implement.
25945 * ../errors/cs0150.cs : Add.
25947 * ../errors/cs0178.cs : Add.
25949 2001-11-16 Miguel de Icaza <miguel@ximian.com>
25951 * statement.cs: Implement foreach on multi-dimensional arrays.
25953 * parameter.cs (Parameters.GetParameterByName): Also lookup the
25954 name of the params argument.
25956 * expression.cs: Use EmitStoreOpcode to get the right opcode while
25957 initializing the array.
25959 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
25960 we can use this elsewhere.
25962 * statement.cs: Finish implementation of foreach for single
25965 * cs-parser.jay: Use an out-of-band stack to pass information
25966 around, I wonder why I need this.
25968 foreach_block: Make the new foreach_block the current_block.
25970 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
25971 function used to return a static Parameters structure. Used for
25972 empty parameters, as those are created very frequently.
25974 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
25976 2001-11-15 Ravi Pratap <ravi@ximian.com>
25978 * interface.cs : Default modifier is private, not public. The
25979 make verify test passes again.
25981 2001-11-15 Ravi Pratap <ravi@ximian.com>
25983 * support.cs (ReflectionParameters): Fix logic to determine
25984 whether the last parameter is a params one. Test 9 passes again.
25986 * delegate.cs (Populate): Register the builders we define with
25987 RegisterParameterForBuilder. Test 19 passes again.
25989 * cs-parser.jay (property_declaration): Reference $6 instead
25990 of $$ to get at the location.
25992 (indexer_declaration): Similar stuff.
25994 (attribute): Ditto.
25996 * class.cs (Property): Register parameters for the Get and Set methods
25997 if they exist. Test 23 passes again.
25999 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
26000 call to EmitArguments as we are sure there aren't any params arguments.
26001 Test 32 passes again.
26003 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
26004 IndexOutOfRangeException.
26006 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
26007 Test 33 now passes again.
26009 2001-11-15 Miguel de Icaza <miguel@ximian.com>
26011 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
26012 broke a bunch of things. Will have to come up with a better way
26013 of tracking locations.
26015 * statement.cs: Implemented foreach for single dimension arrays.
26017 2001-11-09 Miguel de Icaza <miguel@ximian.com>
26019 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
26020 an error. This removes the lookup from the critical path.
26022 * cs-parser.jay: Removed use of temporary_loc, which is completely
26025 2001-11-14 Miguel de Icaza <miguel@ximian.com>
26027 * support.cs (ReflectionParameters.ParameterModifier): Report
26028 whether the argument is a PARAMS argument or not.
26030 * class.cs: Set the attribute `ParamArrayAttribute' on the
26031 parameter argument.
26033 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
26034 and cons_param_array_attribute (ConstructorInfo for
26035 ParamArrayAttribute).,
26037 * codegen.cs: Emit the return using the `Return' statement, that
26038 way we can report the error correctly for missing return values.
26040 * class.cs (Method.Emit): Clean up.
26042 * expression.cs (Argument.Resolve): Take another argument: the
26043 location where this argument is used. Notice that this is not
26044 part of the "Argument" class as to reduce the size of the
26045 structure (we know the approximate location anyways).
26047 Test if the argument is a variable-reference, if not, then
26048 complain with a 206.
26050 (Argument.Emit): Emit addresses of variables.
26052 (Argument.FullDesc): Simplify.
26054 (Invocation.DoResolve): Update for Argument.Resolve.
26056 (ElementAccess.DoResolve): ditto.
26058 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
26059 method should be virtual, as this method is always virtual.
26061 (NewDelegate.DoResolve): Update for Argument.Resolve.
26063 * class.cs (ConstructorInitializer.DoResolve): ditto.
26065 * attribute.cs (Attribute.Resolve): ditto.
26067 2001-11-13 Miguel de Icaza <miguel@ximian.com>
26069 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
26071 * expression.cs (ParameterReference): Drop IStackStorage and implement
26072 IAssignMethod instead.
26074 (LocalVariableReference): ditto.
26076 * ecore.cs (FieldExpr): Drop IStackStorage and implement
26077 IAssignMethod instead.
26079 2001-11-13 Miguel de Icaza <miguel@ximian.com>
26081 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
26082 enumerations that are used in heavily used structures derive from
26083 byte in a laughable and pathetic attempt to reduce memory usage.
26084 This is the kind of pre-optimzations that you should not do at
26085 home without adult supervision.
26087 * expression.cs (UnaryMutator): New class, used to handle ++ and
26088 -- separatedly from the other unary operators. Cleans up the
26089 code, and kills the ExpressionStatement dependency in Unary.
26091 (Unary): Removed `method' and `Arguments' from this class, making
26092 it smaller, and moving it all to SimpleCall, so I can reuse this
26093 code in other locations and avoid creating a lot of transient data
26094 strucutres when not required.
26096 * cs-parser.jay: Adjust for new changes.
26098 2001-11-11 Miguel de Icaza <miguel@ximian.com>
26100 * enum.cs (Enum.Populate): If there is a failure during
26103 * cs-parser.jay (opt_enum_base): we used to catch type errors
26104 here, but this is really incorrect. The type error should be
26105 catched during semantic analysis.
26107 2001-12-11 Ravi Pratap <ravi@ximian.com>
26109 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
26110 current_local_parameters as expected since I, in my stupidity, had forgotten
26113 * attribute.cs (GetValidPlaces): Fix stupid bug.
26115 * class.cs (Method::Emit): Perform check on applicability of attributes.
26117 (Constructor::Emit): Ditto.
26119 (Field::Emit): Ditto.
26121 (Field.Location): Store location information.
26123 (Property, Event, Indexer, Operator): Ditto.
26125 * cs-parser.jay (field_declaration): Pass in location for each field.
26127 * ../errors/cs0592.cs : Add.
26129 2001-11-12 Ravi Pratap <ravi@ximian.com>
26131 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
26133 (InitCoreTypes): Update accordingly.
26135 (RegisterAttrType, LookupAttr): Implement.
26137 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
26138 info about the same.
26140 (Resolve): Update to populate the above as necessary.
26142 (Error592): Helper.
26144 (GetValidPlaces): Helper to the above.
26146 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
26148 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
26150 2001-11-12 Ravi Pratap <ravi@ximian.com>
26152 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
26154 * ../errors/cs0617.cs : Add.
26156 2001-11-11 Ravi Pratap <ravi@ximian.com>
26158 * enum.cs (Emit): Rename to Populate to be more consistent with what
26159 we expect it to do and when exactly it is called.
26161 * class.cs, rootcontext.cs : Update accordingly.
26163 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
26164 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
26166 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
26168 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
26169 of a fieldinfo using the above, when dealing with a FieldBuilder.
26171 2001-11-10 Ravi Pratap <ravi@ximian.com>
26173 * ../errors/cs0031.cs : Add.
26175 * ../errors/cs1008.cs : Add.
26177 * ../errrors/cs0543.cs : Add.
26179 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
26182 (FindMembers): Implement.
26184 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
26185 enums and delegates too.
26187 (enum_types): Rename to builder_to_enum.
26189 (delegate_types): Rename to builder_to_delegate.
26191 * delegate.cs (FindMembers): Implement.
26193 2001-11-09 Ravi Pratap <ravi@ximian.com>
26195 * typemanager.cs (IsEnumType): Implement.
26197 * enum.cs (Emit): Re-write parts to account for the underlying type
26198 better and perform checking etc.
26200 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
26201 of the underlying type.
26203 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
26206 * enum.cs (error31): Helper to report error #31.
26208 * cs-parser.jay (enum_declaration): Store location of each member too.
26210 * enum.cs (member_to_location): New hashtable.
26212 (AddEnumMember): Update location hashtable.
26214 (Emit): Use the location of each member while reporting errors.
26216 2001-11-09 Miguel de Icaza <miguel@ximian.com>
26218 * cs-parser.jay: A for_initializer if is a
26219 local_variable_declaration really ammount to have an implicit
26220 block with the variable declaration and no initializer for for.
26222 * statement.cs (For.Emit): Cope with null initializers.
26224 This fixes the infinite loop on for initializers.
26226 2001-11-08 Miguel de Icaza <miguel@ximian.com>
26228 * enum.cs: More cleanup.
26230 * ecore.cs: Remove dead code.
26232 * class.cs (Property.Emit): More simplification.
26233 (Event.Emit): ditto.
26235 Reworked to have less levels of indentation.
26237 2001-11-08 Ravi Pratap <ravi@ximian.com>
26239 * class.cs (Property): Emit attributes.
26249 * enum.cs (Emit): Ditto.
26251 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
26254 * class.cs (Field, Event, etc.): Move attribute generation into the
26255 Emit method everywhere.
26257 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
26258 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
26259 as we had no way of defining nested enums !
26261 * rootcontext.cs : Adjust code accordingly.
26263 * typemanager.cs (AddEnumType): To keep track of enum types separately.
26265 2001-11-07 Ravi Pratap <ravi@ximian.com>
26267 * expression.cs (EvalConstantExpression): Move into ecore.cs
26269 * enum.cs (Enum): Rename some members and make them public and readonly
26270 according to our convention.
26272 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
26275 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
26277 (Enum::Emit): Write a simple version for now which doesn't try to compute
26278 expressions. I shall modify this to be more robust in just a while.
26280 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
26282 (TypeContainer::CloseType): Create the Enum types too.
26284 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
26286 * expression.cs (EvalConstantExpression): Get rid of completely.
26288 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
26289 user-defined values and other cases.
26291 (IsValidEnumLiteral): Helper function.
26293 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
26294 out there in the case we had a literal FieldExpr.
26296 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
26298 (Literalize): Revamp a bit to take two arguments.
26300 (EnumLiteral): New class which derives from Literal to wrap enum literals.
26302 2001-11-06 Ravi Pratap <ravi@ximian.com>
26304 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
26306 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
26308 (Resolve): Use the above to ensure we have proper initializers.
26310 2001-11-05 Ravi Pratap <ravi@ximian.com>
26312 * expression.cs (Expression::EvalConstantExpression): New method to
26313 evaluate constant expressions.
26315 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
26317 2001-11-07 Miguel de Icaza <miguel@ximian.com>
26319 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
26322 (Binary.ResolveOperator): Handle operator != (object a, object b)
26323 and operator == (object a, object b);
26325 (Binary.DoNumericPromotions): Indicate whether the numeric
26326 promotion was possible.
26328 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
26331 Made the ArrayAccess implement interface IAssignMethod instead of
26332 IStackStore as the order in which arguments are passed reflects
26335 * assign.cs: Instead of using expr.ExprClass to select the way of
26336 assinging, probe for the IStackStore/IAssignMethod interfaces.
26338 * typemanager.cs: Load InitializeArray definition.
26340 * rootcontext.cs (RootContext.MakeStaticData): Used to define
26341 static data that can be used to initialize arrays.
26343 2001-11-05 Miguel de Icaza <miguel@ximian.com>
26345 * expression.cs: Handle operator== and operator!= for booleans.
26347 (Conditioal.Reduce): Implement reducer for the ?: operator.
26349 (Conditional.Resolve): Implement dead code elimination.
26351 (Binary.Resolve): Catch string literals and return a new
26352 concatenated string.
26354 (Unary.Reduce): Implement reduction of unary expressions.
26356 * ecore.cs: Split out the expression core handling here.
26358 (Expression.Reduce): New method used to perform constant folding
26359 and CSE. This is needed to support constant-expressions.
26361 * statement.cs (Statement.EmitBoolExpression): Pass true and false
26362 targets, and optimize for !x.
26364 2001-11-04 Ravi Pratap <ravi@ximian.com>
26366 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
26367 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
26368 set custom atttributes.
26370 * literal.cs (Literal::GetValue): New abstract method to return the actual
26371 value of the literal, cast as an object.
26373 (*Literal): Implement GetValue method.
26375 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
26376 expressions to the arraylist but objects of type Argument.
26378 * class.cs (TypeContainer::Emit): Emit our attributes too.
26380 (Method::Emit, Constructor::Emit): Ditto.
26382 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
26383 to be ignoring earlier.
26385 2001-11-03 Ravi Pratap <ravi@ximian.com>
26387 * attribute.cs (AttributeSection::Define): Implement to do the business
26388 of constructing a CustomAttributeBuilder.
26390 (Attribute): New trivial class. Increases readability of code.
26392 * cs-parser.jay : Update accordingly.
26394 (positional_argument_list, named_argument_list, named_argument): New rules
26396 (attribute_arguments): Use the above so that we are more correct.
26398 2001-11-02 Ravi Pratap <ravi@ximian.com>
26400 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
26401 to perform all checks for a method with a params parameter.
26403 (Invocation::OverloadResolve): Update to use the above method and therefore
26404 cope correctly with params method invocations.
26406 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
26409 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
26410 constructors in our parent too because we can't afford to miss out on
26413 * attribute.cs (AttributeSection): New name for the class Attribute
26415 Other trivial changes to improve readability.
26417 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
26418 use the new class names.
26420 2001-11-01 Ravi Pratap <ravi@ximian.com>
26422 * class.cs (Method::Define): Complete definition for params types too
26424 (Indexer::Define): Ditto.
26426 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
26427 Cope everywhere with a request for info about the array parameter.
26429 2001-11-01 Ravi Pratap <ravi@ximian.com>
26431 * tree.cs (RecordNamespace): Fix up to check for the correct key.
26433 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
26434 local_variable_type to extract the string corresponding to the type.
26436 (local_variable_type): Fixup the action to use the new helper method.
26438 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
26441 * expression.cs : Clean out code which uses the above.
26443 2001-10-31 Ravi Pratap <ravi@ximian.com>
26445 * typemanager.cs (RegisterMethod): Check if we already have an existing key
26446 and bale out if necessary by returning a false.
26448 (RegisterProperty): Ditto.
26450 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
26451 and print out appropriate error messages.
26453 * interface.cs (everywhere): Ditto.
26455 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
26456 location to constructor.
26458 * class.cs (Property, Event, Indexer): Update accordingly.
26460 * ../errors/cs111.cs : Added.
26462 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
26463 of a method, as laid down by the spec.
26465 (Invocation::OverloadResolve): Use the above method.
26467 2001-10-31 Ravi Pratap <ravi@ximian.com>
26469 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
26470 now take a TypeContainer and a Parameters object.
26472 (ParameterData): Modify return type of ParameterModifier method to be
26473 Parameter.Modifier and not a string.
26475 (ReflectionParameters, InternalParameters): Update accordingly.
26477 * expression.cs (Argument::GetParameterModifier): Same here.
26479 * support.cs (InternalParameters::ParameterType): Find a better way of determining
26480 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
26481 symbol in it at all so maybe this is only for now.
26483 2001-10-30 Ravi Pratap <ravi@ximian.com>
26485 * support.cs (InternalParameters): Constructor now takes an extra argument
26486 which is the actual Parameters class.
26488 (ParameterDesc): Update to provide info on ref/out modifiers.
26490 * class.cs (everywhere): Update call to InternalParameters to pass in
26491 the second argument too.
26493 * support.cs (ParameterData): Add ParameterModifier, which is a method
26494 to return the modifier info [ref/out etc]
26496 (InternalParameters, ReflectionParameters): Implement the above.
26498 * expression.cs (Argument::ParameterModifier): Similar function to return
26499 info about the argument's modifiers.
26501 (Invocation::OverloadResolve): Update to take into account matching modifiers
26504 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
26505 a new SetFormalParameters object which we pass to InternalParameters.
26507 2001-10-30 Ravi Pratap <ravi@ximian.com>
26509 * expression.cs (NewArray): Merge into the ArrayCreation class.
26511 2001-10-29 Ravi Pratap <ravi@ximian.com>
26513 * expression.cs (NewArray): Merge classes NewBuiltinArray and
26514 NewUserdefinedArray into one as there wasn't much of a use in having
26517 * expression.cs (Argument): Change field's name to ArgType from Type.
26519 (Type): New readonly property which returns the proper type, taking into
26520 account ref/out modifiers.
26522 (everywhere): Adjust code accordingly for the above.
26524 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
26525 whether we are emitting for a ref or out parameter.
26527 * expression.cs (Argument::Emit): Use the above field to set the state.
26529 (LocalVariableReference::Emit): Update to honour the flag and emit the
26532 * parameter.cs (Attributes): Set the correct flags for ref parameters.
26534 * expression.cs (Argument::FullDesc): New function to provide a full desc.
26536 * support.cs (ParameterData): Add method ParameterDesc to the interface.
26538 (ReflectionParameters, InternalParameters): Implement the above method.
26540 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
26543 (Invocation::FullMethodDesc): Ditto.
26545 2001-10-29 Miguel de Icaza <miguel@ximian.com>
26547 * cs-parser.jay: Add extra production for the second form of array
26550 * expression.cs (ArrayCreation): Update to reflect the above
26553 * Small changes to prepare for Array initialization.
26555 2001-10-28 Miguel de Icaza <miguel@ximian.com>
26557 * typemanager.cs (ImplementsInterface): interface might be null;
26558 Deal with this problem;
26560 Also, we do store negative hits on the cache (null values), so use
26561 this instead of calling t.GetInterfaces on the type everytime.
26563 2001-10-28 Ravi Pratap <ravi@ximian.com>
26565 * typemanager.cs (IsBuiltinType): New method to help determine the same.
26567 * expression.cs (New::DoResolve): Get rid of array creation code and instead
26568 split functionality out into different classes.
26570 (New::FormArrayType): Move into NewBuiltinArray.
26572 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
26575 (NewBuiltinArray): New class to handle creation of built-in arrays.
26577 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
26578 account creation of one-dimensional arrays.
26580 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
26582 (NewUserdefinedArray::DoResolve): Implement.
26584 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
26586 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
26587 we maintain inside the TypeManager. This is necessary to perform lookups on the
26590 (LookupType): Update to perform GetType on the module builders too.
26592 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
26594 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
26596 2001-10-23 Ravi Pratap <ravi@ximian.com>
26598 * expression.cs (New::DoResolve): Implement guts of array creation.
26600 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
26602 2001-10-27 Miguel de Icaza <miguel@ximian.com>
26604 * expression.cs: Fix bug I introduced lsat night that broke
26607 (Expression.Resolve): Report a 246 error (can not resolve name)
26608 if we find a SimpleName in the stream.
26610 (Expression.ResolveLValue): Ditto.
26612 (Expression.ResolveWithSimpleName): This function is a variant of
26613 ResolveName, this one allows SimpleNames to be returned without a
26614 warning. The only consumer of SimpleNames is MemberAccess
26616 2001-10-26 Miguel de Icaza <miguel@ximian.com>
26618 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
26619 might arrive here. I have my doubts that this is correct.
26621 * statement.cs (Lock): Implement lock statement.
26623 * cs-parser.jay: Small fixes to support `lock' and `using'
26625 * cs-tokenizer.cs: Remove extra space
26627 * driver.cs: New flag --checked, allows to turn on integer math
26630 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
26631 Threading.Monitor.Exit
26633 2001-10-23 Miguel de Icaza <miguel@ximian.com>
26635 * expression.cs (IndexerAccess::DoResolveLValue): Set the
26636 Expression Class to be IndexerAccess.
26638 Notice that Indexer::DoResolve sets the eclass to Value.
26640 2001-10-22 Miguel de Icaza <miguel@ximian.com>
26642 * class.cs (TypeContainer::Emit): Emit code for indexers.
26644 * assign.cs (IAssignMethod): New interface implemented by Indexers
26645 and Properties for handling assignment.
26647 (Assign::Emit): Simplify and reuse code.
26649 * expression.cs (IndexerAccess, PropertyExpr): Implement
26650 IAssignMethod, clean up old code.
26652 2001-10-22 Ravi Pratap <ravi@ximian.com>
26654 * typemanager.cs (ImplementsInterface): New method to determine if a type
26655 implements a given interface. Provides a nice cache too.
26657 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
26660 (ConvertReferenceExplicit): Ditto.
26662 * delegate.cs (Delegate::Populate): Update to define the parameters on the
26663 various methods, with correct names etc.
26665 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
26666 Operator.UnaryNegation.
26668 * cs-parser.jay (operator_declarator): Be a little clever in the case where
26669 we have a unary plus or minus operator.
26671 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
26674 * everywhere : update accordingly.
26676 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
26679 * class.cs (Method::Define): For the case where we are implementing a method
26680 inherited from an interface, we need to set the MethodAttributes.Final flag too.
26681 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
26683 2001-10-21 Ravi Pratap <ravi@ximian.com>
26685 * interface.cs (FindMembers): Implement to work around S.R.E
26688 * typemanager.cs (IsInterfaceType): Implement.
26690 (FindMembers): Update to handle interface types too.
26692 * expression.cs (ImplicitReferenceConversion): Re-write bits which
26693 use IsAssignableFrom as that is not correct - it doesn't work.
26695 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
26696 and accordingly override EmitStatement.
26698 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
26699 using the correct logic :-)
26701 2001-10-19 Ravi Pratap <ravi@ximian.com>
26703 * ../errors/cs-11.cs : Add to demonstrate error -11
26705 2001-10-17 Miguel de Icaza <miguel@ximian.com>
26707 * assign.cs (Assign::Resolve): Resolve right hand side first, and
26708 then pass this as a hint to ResolveLValue.
26710 * expression.cs (FieldExpr): Add Location information
26712 (FieldExpr::LValueResolve): Report assignment to readonly
26715 (Expression::ExprClassFromMemberInfo): Pass location information.
26717 (Expression::ResolveLValue): Add new method that resolves an
26720 (Expression::DoResolveLValue): Default invocation calls
26723 (Indexers): New class used to keep track of indexers in a given
26726 (IStackStore): Renamed from LValue, as it did not really describe
26727 what this did. Also ResolveLValue is gone from this interface and
26728 now is part of Expression.
26730 (ElementAccess): Depending on the element access type
26732 * typemanager.cs: Add `indexer_name_type' as a Core type
26733 (System.Runtime.CompilerServices.IndexerNameAttribute)
26735 * statement.cs (Goto): Take a location.
26737 2001-10-18 Ravi Pratap <ravi@ximian.com>
26739 * delegate.cs (Delegate::VerifyDelegate): New method to verify
26740 if two delegates are compatible.
26742 (NewDelegate::DoResolve): Update to take care of the case when
26743 we instantiate a delegate from another delegate.
26745 * typemanager.cs (FindMembers): Don't even try to look up members
26746 of Delegate types for now.
26748 2001-10-18 Ravi Pratap <ravi@ximian.com>
26750 * delegate.cs (NewDelegate): New class to take care of delegate
26753 * expression.cs (New): Split the delegate related code out into
26754 the NewDelegate class.
26756 * delegate.cs (DelegateInvocation): New class to handle delegate
26759 * expression.cs (Invocation): Split out delegate related code into
26760 the DelegateInvocation class.
26762 2001-10-17 Ravi Pratap <ravi@ximian.com>
26764 * expression.cs (New::DoResolve): Implement delegate creation fully
26765 and according to the spec.
26767 (New::DoEmit): Update to handle delegates differently.
26769 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
26770 because of which we were printing out arguments in reverse order !
26772 * delegate.cs (VerifyMethod): Implement to check if the given method
26773 matches the delegate.
26775 (FullDelegateDesc): Implement.
26777 (VerifyApplicability): Implement.
26779 * expression.cs (Invocation::DoResolve): Update to accordingly handle
26780 delegate invocations too.
26782 (Invocation::Emit): Ditto.
26784 * ../errors/cs1593.cs : Added.
26786 * ../errors/cs1594.cs : Added.
26788 * delegate.cs (InstanceExpression, TargetMethod): New properties.
26790 2001-10-16 Ravi Pratap <ravi@ximian.com>
26792 * typemanager.cs (intptr_type): Core type for System.IntPtr
26794 (InitCoreTypes): Update for the same.
26796 (iasyncresult_type, asynccallback_type): Ditto.
26798 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
26801 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
26804 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
26805 the builders for the 4 members of a delegate type :-)
26807 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
26810 * expression.cs (New::DoResolve): Implement guts for delegate creation.
26812 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
26814 2001-10-15 Miguel de Icaza <miguel@ximian.com>
26816 * statement.cs (Break::Emit): Implement.
26817 (Continue::Emit): Implement.
26819 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
26820 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
26821 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
26822 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
26825 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
26826 properties that track the label for the current loop (begin of the
26827 loop and end of the loop).
26829 2001-10-15 Ravi Pratap <ravi@ximian.com>
26831 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
26832 use of emitting anything at all.
26834 * class.cs, rootcontext.cs : Get rid of calls to the same.
26836 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
26838 (Populate): Define the constructor correctly and set the implementation
26841 * typemanager.cs (delegate_types): New hashtable to hold delegates that
26844 (AddDelegateType): Implement.
26846 (IsDelegateType): Implement helper method.
26848 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
26850 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
26851 and accordingly handle it.
26853 * delegate.cs (Populate): Take TypeContainer argument.
26854 Implement bits to define the Invoke method. However, I still haven't figured out
26855 how to take care of the native int bit :-(
26857 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
26858 Qualify the name of the delegate, not its return type !
26860 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
26863 (StandardConversionExists): Checking for array types turns out to be recursive.
26865 (ConvertReferenceExplicit): Implement array conversion.
26867 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
26869 2001-10-12 Ravi Pratap <ravi@ximian.com>
26871 * cs-parser.jay (delegate_declaration): Store the fully qualified
26872 name as it is a type declaration.
26874 * delegate.cs (ReturnType, Name): Rename members to these. Make them
26877 (DefineDelegate): Renamed from Define. Does the same thing essentially,
26878 as TypeContainer::DefineType.
26880 (Populate): Method in which all the definition of the various methods (Invoke)
26883 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
26886 (CloseDelegate): Finally creates the delegate.
26888 * class.cs (TypeContainer::DefineType): Update to define delegates.
26889 (Populate, Emit and CloseType): Do the same thing here too.
26891 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
26892 delegates in all these operations.
26894 2001-10-14 Miguel de Icaza <miguel@ximian.com>
26896 * expression.cs: LocalTemporary: a new expression used to
26897 reference a temporary that has been created.
26899 * assign.cs: Handle PropertyAccess back here, so that we can
26900 provide the proper semantic access to properties.
26902 * expression.cs (Expression::ConvertReferenceExplicit): Implement
26903 a few more explicit conversions.
26905 * modifiers.cs: `NEW' modifier maps to HideBySig.
26907 * expression.cs (PropertyExpr): Make this into an
26908 ExpressionStatement, and support the EmitStatement code path.
26910 Perform get/set error checking, clean up the interface.
26912 * assign.cs: recognize PropertyExprs as targets, and if so, turn
26913 them into toplevel access objects.
26915 2001-10-12 Miguel de Icaza <miguel@ximian.com>
26917 * expression.cs: PropertyExpr::PropertyExpr: use work around the
26920 * typemanager.cs: Keep track here of our PropertyBuilders again to
26921 work around lameness in SRE.
26923 2001-10-11 Miguel de Icaza <miguel@ximian.com>
26925 * expression.cs (LValue::LValueResolve): New method in the
26926 interface, used to perform a second resolution pass for LValues.
26928 (This::DoResolve): Catch the use of this in static methods.
26930 (This::LValueResolve): Implement.
26932 (This::Store): Remove warning, assigning to `this' in structures
26935 (Invocation::Emit): Deal with invocation of
26936 methods on value types. We need to pass the address to structure
26937 methods rather than the object itself. (The equivalent code to
26938 emit "this" for structures leaves the entire structure on the
26939 stack instead of a pointer to it).
26941 (ParameterReference::DoResolve): Compute the real index for the
26942 argument based on whether the method takes or not a `this' pointer
26943 (ie, the method is static).
26945 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
26946 value types returned from functions when we need to invoke a
26947 method on the sturcture.
26950 2001-10-11 Ravi Pratap <ravi@ximian.com>
26952 * class.cs (TypeContainer::DefineType): Method to actually do the business of
26953 defining the type in the Modulebuilder or Typebuilder. This is to take
26954 care of nested types which need to be defined on the TypeBuilder using
26955 DefineNestedMethod.
26957 (TypeContainer::GetClassBases): Implement. Essentially the code from the
26958 methods in RootContext, only ported to be part of TypeContainer.
26960 (TypeContainer::GetInterfaceOrClass): Ditto.
26962 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
26964 * interface.cs (Interface::DefineInterface): New method. Does exactly
26965 what RootContext.CreateInterface did earlier, only it takes care of nested types
26968 (Interface::GetInterfaces): Move from RootContext here and port.
26970 (Interface::GetInterfaceByName): Same here.
26972 * rootcontext.cs (ResolveTree): Re-write.
26974 (PopulateTypes): Re-write.
26976 * class.cs (TypeContainer::Populate): Populate nested types too.
26977 (TypeContainer::Emit): Emit nested members too.
26979 * typemanager.cs (AddUserType): Do not make use of the FullName property,
26980 instead just use the name argument passed in as it is already fully
26983 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
26984 to TypeContainer mapping to see if a type is user-defined.
26986 * class.cs (TypeContainer::CloseType): Implement.
26988 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
26989 the default constructor.
26991 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
26994 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
26996 * interface.cs (CloseType): Create the type here.
26998 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
27001 Remove all the methods which are now in TypeContainer.
27003 2001-10-10 Ravi Pratap <ravi@ximian.com>
27005 * delegate.cs (Define): Re-write bits to define the delegate
27008 2001-10-10 Miguel de Icaza <miguel@ximian.com>
27010 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
27012 * expression.cs (ImplicitReferenceConversion): handle null as well
27013 as a source to convert to any reference type.
27015 * statement.cs (Return): Perform any implicit conversions to
27016 expected return type.
27018 Validate use of return statement.
27020 * codegen.cs (EmitContext): Pass the expected return type here.
27022 * class.cs (Method, Constructor, Property): Pass expected return
27023 type to EmitContext.
27025 2001-10-09 Miguel de Icaza <miguel@ximian.com>
27027 * expression.cs: Make DoResolve take an EmitContext instead of a
27030 Replaced `l' and `location' for `loc', for consistency.
27032 (Error, Warning): Remove unneeded Tc argument.
27034 * assign.cs, literal.cs, constant.cs: Update to new calling
27037 * codegen.cs: EmitContext now contains a flag indicating whether
27038 code is being generated in a static method or not.
27040 * cs-parser.jay: DecomposeQI, new function that replaces the old
27041 QualifiedIdentifier. Now we always decompose the assembled
27042 strings from qualified_identifier productions into a group of
27045 2001-10-08 Miguel de Icaza <miguel@ximian.com>
27047 * rootcontext.cs: Deal with field-less struct types correctly now
27048 by passing the size option to Define Type.
27050 * class.cs: Removed hack that created one static field.
27052 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27054 * statement.cs: Moved most of the code generation here.
27056 2001-10-09 Ravi Pratap <ravi@ximian.com>
27058 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
27061 (ElementAccess): Remove useless bits for now - keep checks as the spec
27064 2001-10-08 Ravi Pratap <ravi@ximian.com>
27066 * expression.cs (ElementAccess::DoResolve): Remove my crap code
27067 and start performing checks according to the spec.
27069 2001-10-07 Ravi Pratap <ravi@ximian.com>
27071 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
27072 rank_specifiers instead.
27074 (rank_specifiers): Change the order in which the rank specifiers are stored
27076 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
27078 * expression.cs (ElementAccess): Implement the LValue interface too.
27080 2001-10-06 Ravi Pratap <ravi@ximian.com>
27082 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
27083 except that user defined conversions are not included.
27085 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
27086 perform the conversion of the return type, if necessary.
27088 (New::DoResolve): Check whether we are creating an array or an object
27089 and accordingly do the needful.
27091 (New::Emit): Same here.
27093 (New::DoResolve): Implement guts of array creation.
27095 (New::FormLookupType): Helper function.
27097 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27099 * codegen.cs: Removed most of the code generation here, and move the
27100 corresponding code generation bits to the statement classes.
27102 Added support for try/catch/finalize and throw.
27104 * cs-parser.jay: Added support for try/catch/finalize.
27106 * class.cs: Catch static methods having the flags override,
27107 virtual or abstract.
27109 * expression.cs (UserCast): This user cast was not really doing
27110 what it was supposed to do. Which is to be born in fully resolved
27111 state. Parts of the resolution were being performed at Emit time!
27115 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27117 * expression.cs: Implicity convert the result from UserCast.
27119 2001-10-05 Ravi Pratap <ravi@ximian.com>
27121 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
27122 prevented it from working correctly.
27124 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
27125 merely ConvertImplicit.
27127 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27129 * typemanager.cs: Make the LookupTypeContainer function static,
27130 and not per-instance.
27132 * class.cs: Make static FindMembers (the one that takes a Type
27135 * codegen.cs: Add EmitForeach here.
27137 * cs-parser.jay: Make foreach a toplevel object instead of the
27138 inline expansion, as we need to perform semantic analysis on it.
27140 2001-10-05 Ravi Pratap <ravi@ximian.com>
27142 * expression.cs (Expression::ImplicitUserConversion): Rename to
27143 UserDefinedConversion.
27145 (Expression::UserDefinedConversion): Take an extra argument specifying
27146 whether we look for explicit user conversions too.
27148 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
27150 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
27152 (ExplicitUserConversion): Make it a call to UserDefinedConversion
27153 with the appropriate arguments.
27155 * cs-parser.jay (cast_expression): Record location too.
27157 * expression.cs (Cast): Record location info.
27159 (Expression::ConvertExplicit): Take location argument.
27161 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
27162 to determine if we are doing explicit conversions.
27164 (UserCast::Emit): Update accordingly.
27166 (Expression::ConvertExplicit): Report an error if everything fails.
27168 * ../errors/cs0030.cs : Add.
27170 2001-10-04 Miguel de Icaza <miguel@ximian.com>
27172 * modifiers.cs: If the ABSTRACT keyword is present, also set the
27173 virtual and newslot bits.
27175 * class.cs (TypeContainer::RegisterRequiredImplementations):
27176 Record methods we need.
27178 (TypeContainer::MakeKey): Helper function to make keys for
27179 MethodBases, since the Methodbase key is useless.
27181 (TypeContainer::Populate): Call RegisterRequiredImplementations
27182 before defining the methods.
27184 Create a mapping for method_builders_to_methods ahead of time
27185 instead of inside a tight loop.
27187 (::RequireMethods): Accept an object as the data to set into the
27188 hashtable so we can report interface vs abstract method mismatch.
27190 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27192 * report.cs: Make all of it static.
27194 * rootcontext.cs: Drop object_type and value_type computations, as
27195 we have those in the TypeManager anyways.
27197 Drop report instance variable too, now it is a global.
27199 * driver.cs: Use try/catch on command line handling.
27201 Add --probe option to debug the error reporting system with a test
27204 * report.cs: Add support for exiting program when a probe
27205 condition is reached.
27207 2001-10-03 Ravi Pratap <ravi@ximian.com>
27209 * expression.cs (Binary::DoNumericPromotions): Fix the case when
27210 we do a forcible conversion regardless of type, to check if
27211 ForceConversion returns a null.
27213 (Binary::error19): Use location to report error.
27215 (Unary::error23): Use location here too.
27217 * ../errors/cs0019.cs : Check in.
27219 * ../errors/cs0023.cs : Check in.
27221 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
27222 case of a non-null MethodInfo object with a length of 0 !
27224 (Binary::ResolveOperator): Flag error if overload resolution fails to find
27225 an applicable member - according to the spec :-)
27226 Also fix logic to find members in base types.
27228 (Unary::ResolveOperator): Same here.
27230 (Unary::report23): Change name to error23 and make first argument a TypeContainer
27231 as I was getting thoroughly confused between this and error19 :-)
27233 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
27234 (::FindMostEncompassedType): Implement.
27235 (::FindMostEncompassingType): Implement.
27236 (::StandardConversionExists): Implement.
27238 (UserImplicitCast): Re-vamp. We now need info about most specific
27239 source and target types so that we can do the necessary conversions.
27241 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
27242 mathematical union with no duplicates.
27244 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27246 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
27247 in order from base classes to child classes, so that we can in
27248 child classes look up in our parent for method names and
27249 attributes (required for handling abstract, virtual, new, override
27250 constructs: we need to instrospect our base class, and if we dont
27251 populate the classes in order, the introspection might be
27252 incorrect. For example, a method could query its parent before
27253 the parent has any methods and would determine that the parent has
27254 no abstract methods (while it could have had them)).
27256 (RootContext::CreateType): Record the order in which we define the
27259 2001-10-02 Miguel de Icaza <miguel@ximian.com>
27261 * class.cs (TypeContainer::Populate): Also method definitions can
27262 fail now, keep track of this.
27264 (TypeContainer::FindMembers): Implement support for
27265 DeclaredOnly/noDeclaredOnly flag.
27267 (Constructor::Emit) Return the ConstructorBuilder.
27269 (Method::Emit) Return the MethodBuilder.
27270 Check for abstract or virtual methods to be public.
27272 * rootcontext.cs (RootContext::CreateType): Register all the
27273 abstract methods required for the class to be complete and the
27274 interface methods that must be implemented.
27276 * cs-parser.jay: Report error 501 (method requires body if it is
27277 not marked abstract or extern).
27279 * expression.cs (TypeOf::Emit): Implement.
27281 * typemanager.cs: runtime_handle_type, new global type.
27283 * class.cs (Property::Emit): Generate code for properties.
27285 2001-10-02 Ravi Pratap <ravi@ximian.com>
27287 * expression.cs (Unary::ResolveOperator): Find operators on base type
27288 too - we now conform exactly to the spec.
27290 (Binary::ResolveOperator): Same here.
27292 * class.cs (Operator::Define): Fix minor quirk in the tests.
27294 * ../errors/cs0215.cs : Added.
27296 * ../errors/cs0556.cs : Added.
27298 * ../errors/cs0555.cs : Added.
27300 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27302 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
27303 single integer which is really efficient
27305 2001-10-01 Ravi Pratap <ravi@ximian.com>
27307 * expression.cs (Expression::ImplicitUserConversion): Use location
27308 even in the case when we are examining True operators.
27310 * class.cs (Operator::Define): Perform extensive checks to conform
27311 with the rules for operator overloading in the spec.
27313 * expression.cs (Expression::ImplicitReferenceConversion): Implement
27314 some of the other conversions mentioned in the spec.
27316 * typemanager.cs (array_type): New static member for the System.Array built-in
27319 (cloneable_interface): For System.ICloneable interface.
27321 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
27322 we start resolving the tree and populating types.
27324 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
27326 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27328 * expression.cs (Expression::ExprClassFromMemberInfo,
27329 Expression::Literalize): Create literal expressions from
27330 FieldInfos which are literals.
27332 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
27333 type casts, because they were wrong. The test suite in tests
27336 (ImplicitNumericConversion): ushort to ulong requires a widening
27339 Int32 constant to long requires widening cast as well.
27341 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
27342 for integers because the type on the stack is not i4.
27344 2001-09-30 Miguel de Icaza <miguel@ximian.com>
27346 * expression.cs (report118): require location argument.
27348 * parameter.cs: Do not dereference potential null value.
27350 * class.cs: Catch methods that lack the `new' keyword when
27351 overriding a name. Report warnings when `new' is used without
27352 anything being there to override.
27354 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
27356 * class.cs: Only add constructor to hashtable if it is non-null
27357 (as now constructors can fail on define).
27359 (TypeManager, Class, Struct): Take location arguments.
27361 Catch field instance initialization in structs as errors.
27363 accepting_filter: a new filter for FindMembers that is static so
27364 that we dont create an instance per invocation.
27366 (Constructor::Define): Catch errors where a struct constructor is
27369 * cs-parser.jay: Pass location information for various new
27372 * delegate.cs (Delegate): take a location argument.
27374 * driver.cs: Do not call EmitCode if there were problesm in the
27375 Definition of the types, as many Builders wont be there.
27377 * decl.cs (Decl::Decl): Require a location argument.
27379 * cs-tokenizer.cs: Handle properly hex constants that can not fit
27380 into integers, and find the most appropiate integer for it.
27382 * literal.cs: Implement ULongLiteral.
27384 * rootcontext.cs: Provide better information about the location of
27385 failure when CreateType fails.
27387 2001-09-29 Miguel de Icaza <miguel@ximian.com>
27389 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
27392 * expression.cs (Binary::CheckShiftArguments): Add missing type
27394 (Binary::ResolveOperator): Add type to the logical and and logical
27395 or, Bitwise And/Or and Exclusive Or code paths, it was missing
27398 (Binary::DoNumericPromotions): In the case where either argument
27399 is ulong (and most signed types combined with ulong cause an
27400 error) perform implicit integer constant conversions as well.
27402 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27404 * expression.cs (UserImplicitCast): Method should always be
27406 (Invocation::BetterConversion): Simplified test for IntLiteral.
27408 (Expression::ImplicitNumericConversion): Split this routine out.
27409 Put the code that performs implicit constant integer conversions
27412 (Expression::Resolve): Become a wrapper around DoResolve so we can
27413 check eclass and type being set after resolve.
27415 (Invocation::Badness): Remove this dead function
27417 (Binary::ResolveOperator): Do not compute the expensive argumnets
27418 unless we have a union for it.
27420 (Probe::Emit): Is needs to do an isinst and then
27421 compare against null.
27423 (::CanConvert): Added Location argument. If the Location argument
27424 is null (Location.Null), then we do not report errors. This is
27425 used by the `probe' mechanism of the Explicit conversion. We do
27426 not want to generate an error for something that the user
27427 explicitly requested to be casted. But the pipeline for an
27428 explicit cast first tests for potential implicit casts.
27430 So for now, if the Location is null, it means `Probe only' to
27431 avoid adding another argument. Might have to revise this
27434 (ClassCast): New class used to type cast objects into arbitrary
27435 classes (used in Explicit Reference Conversions).
27437 Implement `as' as well.
27439 Reverted all the patches from Ravi below: they were broken:
27441 * The use of `level' as a mechanism to stop recursive
27442 invocations is wrong. That was there just to catch the
27443 bug with a strack trace but not as a way of addressing
27446 To fix the problem we have to *understand* what is going
27447 on and the interactions and come up with a plan, not
27448 just get things going.
27450 * The use of the type conversion cache that I proposed
27451 last night had an open topic: How does this work across
27452 protection domains. A user defined conversion might not
27453 be public in the location where we are applying the
27454 conversion, a different conversion might be selected
27455 (ie, private A->B (better) but public B->A (worse),
27456 inside A, A->B applies, but outside it, B->A will
27459 * On top of that (ie, even if the above is solved),
27460 conversions in a cache need to be abstract. Ie, `To
27461 convert from an Int to a Short use an OpcodeCast', not
27462 `To convert from an Int to a Short use the OpcodeCast on
27463 the variable 5' (which is what this patch was doing).
27465 2001-09-28 Ravi Pratap <ravi@ximian.com>
27467 * expression.cs (Invocation::ConversionExists): Re-write to use
27468 the conversion cache
27470 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
27471 cache all conversions done, not just user-defined ones.
27473 (Invocation::BetterConversion): The real culprit. Use ConversionExists
27474 to determine if a conversion exists instead of acutually trying to
27475 perform the conversion. It's faster too.
27477 (Expression::ConvertExplicit): Modify to use ConversionExists to check
27478 and only then attempt the implicit conversion.
27480 2001-09-28 Ravi Pratap <ravi@ximian.com>
27482 * expression.cs (ConvertImplicit): Use a cache for conversions
27483 already found. Check level of recursion and bail out if necessary.
27485 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27487 * typemanager.cs (string_concat_string_string, string_concat_object_object):
27488 Export standard methods that we expect for string operations.
27490 * statement.cs (Block::UsageWarning): Track usage of variables and
27491 report the errors for not used variables.
27493 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
27496 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27498 * codegen.cs: remove unnneded code
27500 * expression.cs: Removed BuiltinTypeAccess class
27502 Fix the order in which implicit conversions are
27505 The previous fixed dropped support for boxed conversions (adding a
27506 test to the test suite now)
27508 (UserImplicitCast::CanConvert): Remove test for source being null,
27509 that code is broken. We should not feed a null to begin with, if
27510 we do, then we should track the bug where the problem originates
27511 and not try to cover it up here.
27513 Return a resolved expression of type UserImplicitCast on success
27514 rather than true/false. Ravi: this is what I was talking about,
27515 the pattern is to use a static method as a "constructor" for
27518 Also, do not create arguments until the very last minute,
27519 otherwise we always create the arguments even for lookups that
27520 will never be performed.
27522 (UserImplicitCast::Resolve): Eliminate, objects of type
27523 UserImplicitCast are born in a fully resolved state.
27525 * typemanager.cs (InitCoreTypes): Init also value_type
27526 (System.ValueType).
27528 * expression.cs (Cast::Resolve): First resolve the child expression.
27530 (LValue): Add new method AddressOf to be used by
27533 Change the argument of Store to take an EmitContext instead of an
27534 ILGenerator, because things like FieldExpr need to be able to call
27535 their children expression to generate the instance code.
27537 (Expression::Error, Expression::Warning): Sugar functions for
27540 (Expression::MemberLookup): Accept a TypeContainer instead of a
27541 Report as the first argument.
27543 (Expression::ResolvePrimary): Killed. I still want to improve
27544 this as currently the code is just not right.
27546 (Expression::ResolveMemberAccess): Simplify, but it is still
27549 (Unary::Resolve): Catch errors in AddressOf operators.
27551 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
27552 index to a byte for the short-version, or the compiler will choose
27553 the wrong Emit call, which generates the wrong data.
27555 (ParameterReference::Emit, ::Store): same.
27557 (FieldExpr::AddressOf): Implement.
27559 * typemanager.cs: TypeManager: made public variable instead of
27562 * driver.cs: document --fatal.
27564 * report.cs (ErrorMessage, WarningMessage): new names for the old
27565 Error and Warning classes.
27567 * cs-parser.jay (member_access): Turn built-in access to types
27568 into a normal simplename
27570 2001-09-27 Ravi Pratap <ravi@ximian.com>
27572 * expression.cs (Invocation::BetterConversion): Fix to cope
27573 with q being null, since this was introducing a bug.
27575 * expression.cs (ConvertImplicit): Do built-in conversions first.
27577 2001-09-27 Ravi Pratap <ravi@ximian.com>
27579 * expression.cs (UserImplicitCast::Resolve): Fix bug.
27581 2001-09-27 Ravi Pratap <ravi@ximian.com>
27583 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
27584 I had introduced long ago (what's new ?).
27586 * expression.cs (UserImplicitCast::CanConvert): Static method to do
27587 the work of all the checking.
27588 (ConvertImplicit): Call CanConvert and only then create object if necessary.
27589 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
27591 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
27592 that is the right way.
27594 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
27595 overloading resolution. Use everywhere instead of cutting and pasting code.
27597 (Binary::ResolveOperator): Use MakeUnionSet.
27599 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
27600 we have to convert to bool types. Not complete yet.
27602 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27604 * typemanager.cs (TypeManager::CSharpName): support ushort.
27606 * expression.cs (Expression::TryImplicitIntConversion): Attempts
27607 to provide an expression that performsn an implicit constant int
27608 conversion (section 6.1.6).
27609 (Expression::ConvertImplicitRequired): Reworked to include
27610 implicit constant expression conversions.
27612 (Expression::ConvertNumericExplicit): Finished.
27614 (Invocation::Emit): If InstanceExpression is null, then it means
27615 that we perform a call on this.
27617 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27619 * expression.cs (Unary::Emit): Remove some dead code.
27620 (Probe): Implement Resolve and Emit for `is'.
27621 (Expression::ConvertImplicitRequired): Attempt to do constant
27622 expression conversions here. Maybe should be moved to
27623 ConvertImplicit, but I am not sure.
27624 (Expression::ImplicitLongConstantConversionPossible,
27625 Expression::ImplicitIntConstantConversionPossible): New functions
27626 that tell whether is it possible to apply an implicit constant
27627 expression conversion.
27629 (ConvertNumericExplicit): Started work on explicit numeric
27632 * cs-parser.jay: Update operator constants.
27634 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
27635 (Parameters::GetSignature): Hook up VerifyArgs here.
27636 (Parameters::VerifyArgs): Verifies that no two arguments have the
27639 * class.cs (Operator): Update the operator names to reflect the
27640 ones that the spec expects (as we are just stringizing the
27643 * expression.cs (Unary::ResolveOperator): Fix bug: Use
27644 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
27645 previous usage did only work for our methods.
27646 (Expression::ConvertImplicit): Handle decimal implicit numeric
27647 conversions as well.
27648 (Expression::InternalTypeConstructor): Used to invoke constructors
27649 on internal types for default promotions.
27651 (Unary::Emit): Implement special handling for the pre/post
27652 increment/decrement for overloaded operators, as they need to have
27653 the same semantics as the other operators.
27655 (Binary::ResolveOperator): ditto.
27656 (Invocation::ConversionExists): ditto.
27657 (UserImplicitCast::Resolve): ditto.
27659 2001-09-26 Ravi Pratap <ravi@ximian.com>
27661 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
27662 operator, return after emitting body. Regression tests pass again !
27664 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
27665 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
27666 (Invocation::OverloadResolve): Ditto.
27667 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
27669 * everywhere : update calls to the above methods accordingly.
27671 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27673 * assign.cs (Assign): Make it inherit from ExpressionStatement.
27675 * expression.cs (ExpressionStatement): New base class used for
27676 expressions that can appear in statements, so that we can provide
27677 an alternate path to generate expression that do not leave a value
27680 (Expression::Emit, and all the derivatives): We no longer return
27681 whether a value is left on the stack or not. Every expression
27682 after being emitted leaves a single value on the stack.
27684 * codegen.cs (EmitContext::EmitStatementExpression): Use the
27685 facilties of ExpressionStatement if possible.
27687 * cs-parser.jay: Update statement_expression.
27689 2001-09-25 Miguel de Icaza <miguel@ximian.com>
27691 * driver.cs: Change the wording of message
27693 2001-09-25 Ravi Pratap <ravi@ximian.com>
27695 * expression.cs (Binary::ResolveOperator): Had forgottten to set
27696 the type of the expression to the return type of the method if
27697 we have an overloaded operator match ! The regression tests pass again !
27698 (Unary::ResolveOperator): Ditto.
27700 * expression.cs (Invocation::ConversionExists): Correct the member lookup
27701 to find "op_Implicit", not "implicit" ;-)
27702 (UserImplicitCast): New class to take care of user-defined implicit conversions.
27703 (ConvertImplicit, ForceConversion): Take TypeContainer argument
27705 * everywhere : Correct calls to the above accordingly.
27707 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
27708 (ConvertImplicit): Do user-defined conversion if it exists.
27710 2001-09-24 Miguel de Icaza <miguel@ximian.com>
27712 * assign.cs: track location.
27713 (Resolve): Use implicit conversions on assignment.
27715 * literal.cs: Oops. Not good, Emit of short access values should
27716 pass (Bytes) or the wrong argument will be selected.
27718 * expression.cs (Unary::Emit): Emit code for -expr.
27720 (Unary::ResolveOperator): Handle `Substract' for non-constants
27721 (substract from zero from the non-constants).
27722 Deal with Doubles as well.
27724 (Expression::ConvertImplicitRequired): New routine that reports an
27725 error if no implicit conversion exists.
27727 (Invocation::OverloadResolve): Store the converted implicit
27728 expressions if we make them
27730 2001-09-24 Ravi Pratap <ravi@ximian.com>
27732 * class.cs (ConstructorInitializer): Take a Location argument.
27733 (ConstructorBaseInitializer): Same here.
27734 (ConstructorThisInitializer): Same here.
27736 * cs-parser.jay : Update all calls accordingly.
27738 * expression.cs (Unary, Binary, New): Take location argument.
27739 Update accordingly everywhere.
27741 * cs-parser.jay : Update all calls to the above to take a location
27744 * class.cs : Ditto.
27746 2001-09-24 Ravi Pratap <ravi@ximian.com>
27748 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
27749 (Invocation::BetterConversion): Same here
27750 (Invocation::ConversionExists): Ditto.
27752 (Invocation::ConversionExists): Implement.
27754 2001-09-22 Ravi Pratap <ravi@ximian.com>
27756 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
27757 Also take an additional TypeContainer argument.
27759 * All over : Pass in TypeContainer as argument to OverloadResolve.
27761 * typemanager.cs (CSharpName): Update to check for the string type and return
27764 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
27767 2001-09-21 Ravi Pratap <ravi@ximian.com>
27769 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
27770 (Invocation::BetterFunction): Implement.
27771 (Invocation::BetterConversion): Implement.
27772 (Invocation::ConversionExists): Skeleton, no implementation yet.
27774 Okay, things work fine !
27776 2001-09-21 Miguel de Icaza <miguel@ximian.com>
27778 * typemanager.cs: declare and load enum_type, delegate_type and
27781 * expression.cs (Expression::Emit): Now emit returns a value that
27782 tells whether a value is left on the stack or not. This strategy
27783 might be reveted tomorrow with a mechanism that would address
27784 multiple assignments.
27785 (Expression::report118): Utility routine to report mismatches on
27788 (Unary::Report23): Report impossible type/operator combination
27791 (Unary::IsIncrementableNumber): Whether the type can be
27792 incremented or decremented with add.
27793 (Unary::ResolveOperator): Also allow enumerations to be bitwise
27795 (Unary::ResolveOperator): Implement ++, !, ~,
27797 (Invocation::Emit): Deal with new Emit convetion.
27799 * All Expression derivatives: Updated their Emit method to return
27800 whether they leave values on the stack or not.
27802 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
27803 stack for expressions that are statements.
27805 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27807 * expression.cs (LValue): New interface. Must be implemented by
27809 (LocalVariableReference, ParameterReference, FieldExpr): Implement
27812 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
27813 interface for generating code, simplifies the code.
27815 2001-09-20 Ravi Pratap <ravi@ximian.com>
27817 * expression.cs (everywhere): Comment out return statements in ::Resolve
27818 methods to avoid the warnings.
27820 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27822 * driver.cs (parse): Report error 2001 if we can not open the
27825 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
27828 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
27831 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
27832 otherwise nested blocks end up with the same index.
27834 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
27836 * expression.cs: Instead of having FIXMEs in the Resolve
27837 functions, throw exceptions so it is obvious that we are facing a
27840 * cs-parser.jay (invocation_expression): Pass Location information.
27842 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
27843 Use a basename for those routines because .NET does not like paths
27846 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
27849 2001-09-19 Miguel de Icaza <miguel@ximian.com>
27851 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
27852 are loading the correct data types (throws an exception if not).
27853 (TypeManager::InitCoreTypes): Use CoreLookupType
27855 * expression.cs (Unary::ResolveOperator): return the child
27856 expression for expressions which are just +expr.
27857 (Unary::ResolveOperator): Return negative literals for -LITERAL
27858 expressions (otherwise they are Unary {Literal}).
27859 (Invocation::Badness): Take into account `Implicit constant
27860 expression conversions'.
27862 * literal.cs (LongLiteral): Implement long literal class.
27863 (IntLiteral): export the `Value' of the intliteral.
27865 2001-09-19 Ravi Pratap <ravi@ximian.com>
27867 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
27869 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
27870 instead of 'Operator'
27872 * expression.cs (Binary::ResolveOperator): Update accordingly.
27873 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
27876 * cs-parser.jay (unary_expression): Update to use the new names.
27878 * gen-treedump.cs (GetUnary): Same here.
27880 * expression.cs (Unary::Resolve): Implement.
27881 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
27882 operators are found instead of making noise ;-)
27883 (Unary::ResolveOperator): New method to do precisely the same thing which
27884 Binary::ResolveOperator does for Binary expressions.
27885 (Unary.method, .Arguments): Add.
27886 (Unary::OperName): Implement.
27887 (Unary::ForceConversion): Copy and Paste !
27889 * class.cs (Operator::Define): Fix a small bug for the case when we have
27892 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
27893 for the inbuilt operators. Only overloading works for now ;-)
27895 2001-09-18 Miguel de Icaza <miguel@ximian.com>
27897 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
27898 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
27900 * expression.cs (This::Emit): Implement.
27901 (This::Resolve): Implement.
27902 (TypeOf:Resolve): Implement.
27903 (Expression::ResolveSimpleName): Add an implicit this to instance
27905 (MemberAccess::Resolve): Deal with Parameters and Fields.
27906 Bind instance variable to Field expressions.
27907 (FieldExpr::Instance): New field used to track the expression that
27908 represents the object instance.
27909 (FieldExpr::Resolve): Track potential errors from MemberLookup not
27911 (FieldExpr::Emit): Implement.
27913 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
27914 the last instruction contains a return opcode to avoid generating
27915 the last `ret' instruction (this generates correct code, and it is
27916 nice to pass the peverify output).
27918 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
27919 initializer for static and instance variables.
27920 (Constructor::Emit): Allow initializer to be null in the case of
27921 static constructors. Only emit initializer for instance
27924 (TypeContainer::FindMembers): Return a null array if there are no
27927 Also fix the code for the MemberTypes.Method branch, as it was not
27928 scanning that for operators (or tried to access null variables before).
27930 * assign.cs (Assign::Emit): Handle instance and static fields.
27934 * driver.cs: Stop compilation if there are parse errors.
27936 * cs-parser.jay (constructor_declaration): Provide default base
27937 initializer for non-static constructors.
27938 (constructor_declarator): Do not provide a default base
27939 initializers if none was specified.
27940 Catch the fact that constructors should not have parameters.
27942 * class.cs: Do not emit parent class initializers for static
27943 constructors, that should be flagged as an error.
27945 2001-09-18 Ravi Pratap <ravi@ximian.com>
27947 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
27948 Move back code into TypeContainer::Populate.
27950 2001-09-18 Ravi Pratap <ravi@ximian.com>
27952 * class.cs (TypeContainer::AddConstructor): Fix the check to
27953 compare against Name, not Basename.
27954 (Operator::OpType): Change Plus and Minus to Add and Subtract.
27956 * cs-parser.jay : Update accordingly.
27958 * class.cs (TypeContainer::FindMembers): For the case where we are searching
27959 for methods, don't forget to look into the operators too.
27960 (RegisterMethodBuilder): Helper method to take care of this for
27961 methods, constructors and operators.
27962 (Operator::Define): Completely revamp.
27963 (Operator.OperatorMethod, MethodName): New fields.
27964 (TypeContainer::Populate): Move the registering of builders into
27965 RegisterMethodBuilder.
27966 (Operator::Emit): Re-write.
27968 * expression.cs (Binary::Emit): Comment out code path to emit method
27969 invocation stuff for the case when we have a user defined operator. I am
27970 just not able to get it right !
27972 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27974 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
27977 (Expression::MemberLookup): Provide a version that allows to
27978 specify the MemberTypes and BindingFlags.
27980 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
27981 so it was not fetching variable information from outer blocks.
27983 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
27984 Beforefieldinit as it was buggy.
27986 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
27987 that Ravi put here.
27989 * class.cs (Constructor::Emit): Only emit if block is not null.
27990 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
27991 deal with this by semantically definining it as if the user had
27994 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
27995 constructors as we now "emit" them at a higher level.
27997 (TypeContainer::DefineDefaultConstructor): Used to define the
27998 default constructors if none was provided.
28000 (ConstructorInitializer): Add methods Resolve and Emit.
28002 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
28004 2001-09-17 Ravi Pratap <ravi@ximian.com>
28006 * class.cs (TypeContainer::EmitDefaultConstructor): Register
28007 the default constructor builder with our hashtable for methodbuilders
28010 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
28011 and argument_count is 0 in which case we have a match.
28012 (Binary::ResolveOperator): More null checking and miscellaneous coding
28015 2001-09-17 Ravi Pratap <ravi@ximian.com>
28017 * rootcontext.cs (IsNameSpace): Compare against null.
28019 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
28021 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
28022 and Unary::Operator.
28024 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
28027 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
28028 we have overloaded operators.
28029 (Binary::ResolveOperator): Implement the part which does the operator overload
28032 * class.cs (Operator::Emit): Implement.
28033 (TypeContainer::Emit): Emit the operators we have too.
28035 * expression.cs (Binary::Emit): Update to emit the appropriate code for
28036 the case when we have a user-defined operator.
28038 2001-09-17 Miguel de Icaza <miguel@ximian.com>
28040 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
28042 2001-09-16 Ravi Pratap <ravi@ximian.com>
28044 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
28045 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
28046 (Constructor::Emit): Implement.
28047 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
28048 if we have no work to do.
28049 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
28052 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
28053 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
28055 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
28058 2001-09-15 Ravi Pratap <ravi@ximian.com>
28060 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
28062 (Tree::RecordNamespace): Method to do what the name says ;-)
28063 (Tree::Namespaces): Property to get at the namespaces hashtable.
28065 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
28068 * rootcontext.cs (IsNamespace): Fixed it :-)
28070 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28072 * class.cs (TypeContainer::FindMembers): Add support for
28074 (MethodCore): New class that encapsulates both the shared aspects
28075 of a Constructor and a Method.
28076 (Method, Constructor): Factored pieces into MethodCore.
28078 * driver.cs: Added --fatal which makes errors throw exceptions.
28079 Load System assembly as well as part of the standard library.
28081 * report.cs: Allow throwing exceptions on errors for debugging.
28083 * modifiers.cs: Do not use `parent', instead use the real type
28084 container to evaluate permission settings.
28086 * class.cs: Put Ravi's patch back in. He is right, and we will
28087 have to cope with the
28089 2001-09-14 Ravi Pratap <ravi@ximian.com>
28091 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
28092 FamORAssem, not FamANDAssem.
28094 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28096 * driver.cs: Added --parse option that only parses its input files
28099 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
28100 incorrect. IsTopLevel is not used to tell whether an object is
28101 root_types or not (that can be achieved by testing this ==
28102 root_types). But to see if this is a top-level *class* (not
28103 necessarly our "toplevel" container).
28105 2001-09-14 Ravi Pratap <ravi@ximian.com>
28107 * enum.cs (Enum::Define): Modify to call the Lookup method on the
28108 parent instead of a direct call to GetType.
28110 2001-09-14 Ravi Pratap <ravi@ximian.com>
28112 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
28113 Modifiers.TypeAttr. This should just be a call to that method.
28115 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
28116 object so that we can determine if we are top-level or not.
28118 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
28121 * enum.cs (Enum::Define): Ditto.
28123 * modifiers.cs (FieldAttr): Re-write.
28125 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
28126 (TypeContainer::HaveStaticConstructor): New property to provide access
28127 to precisely that info.
28129 * modifiers.cs (MethodAttr): Re-write.
28130 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
28132 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
28133 of top-level types as claimed.
28135 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28137 * expression.cs (MemberLookup): Fruitless attempt to lookup
28138 constructors. Maybe I need to emit default constructors? That
28139 might be it (currently .NET emits this for me automatically).
28140 (Invocation::OverloadResolve): Cope with Arguments == null.
28141 (Invocation::EmitArguments): new function, shared by the new
28142 constructor and us.
28143 (Invocation::Emit): Handle static and instance methods. Emit
28144 proper call instruction for virtual or non-virtual invocations.
28145 (New::Emit): Implement.
28146 (New::Resolve): Implement.
28147 (MemberAccess:Resolve): Implement.
28148 (MethodGroupExpr::InstanceExpression): used conforming to the spec
28149 to track instances.
28150 (FieldExpr::Resolve): Set type.
28152 * support.cs: Handle empty arguments.
28154 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
28155 SimpleLookup): Auxiliary routines to help parse a qualifier
28158 Update qualifier_identifier rule.
28160 * codegen.cs: Removed debugging messages.
28162 * class.cs: Make this a global thing, this acts just as a "key" to
28163 objects that we might have around.
28165 (Populate): Only initialize method_builders_to_methods once.
28167 * expression.cs (PropertyExpr): Initialize type from the
28170 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
28171 Resolve pattern. Attempt to implicitly convert value to boolean.
28174 * expression.cs: Set the type for the int32/int32 argument case.
28175 (Binary::ResolveOperator): Set the return type to boolean for
28176 comparission operators
28178 * typemanager.cs: Remove debugging print code.
28180 (Invocation::Resolve): resolve type.
28182 * class.cs: Allocate a MemberInfo of the correct size, as the code
28183 elsewhere depends on the test to reflect the correct contents.
28185 (Method::) Keep track of parameters, due to System.Reflection holes
28187 (TypeContainer::Populate): Keep track of MethodBuilders to Method
28190 (TypeContainer::FindMembers): Use ArrayList and then copy an array
28191 of the exact size and return that.
28193 (Class::LookupMethodByBuilder): New function that maps
28194 MethodBuilders to its methods. Required to locate the information
28195 on methods because System.Reflection bit us again.
28197 * support.cs: New file, contains an interface ParameterData and
28198 two implementations: ReflectionParameters and InternalParameters
28199 used to access Parameter information. We will need to grow this
28202 * expression.cs (Invocation::GetParameterData): implement a cache
28203 and a wrapper around the ParameterData creation for methods.
28204 (Invocation::OverloadResolve): Use new code.
28206 2001-09-13 Ravi Pratap <ravi@ximian.com>
28208 * class.cs (TypeContainer::EmitField): Remove and move into
28209 (Field::Define): here and modify accordingly.
28210 (Field.FieldBuilder): New member.
28211 (TypeContainer::Populate): Update accordingly.
28212 (TypeContainer::FindMembers): Implement.
28214 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28216 * statement.cs: (VariableInfo::VariableType): New field to be
28217 initialized with the full type once it is resolved.
28219 2001-09-12 Miguel de Icaza <miguel@ximian.com>
28221 * parameter.cs (GetParameterInfo): Use a type cache to compute
28222 things only once, and to reuse this information
28224 * expression.cs (LocalVariableReference::Emit): Implement.
28225 (OpcodeCast::Emit): fix.
28227 (ParameterReference::Resolve): Implement.
28228 (ParameterReference::Emit): Implement.
28230 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
28231 that are expressions need to stay as Expressions.
28233 * typemanager.cs (CSharpName): Returns the C# name of a type if
28236 * expression.cs (Expression::ConvertImplicit): New function that
28237 implements implicit type conversions.
28239 (Expression::ImplicitReferenceConversion): Implements implicit
28240 reference conversions.
28242 (EmptyCast): New type for transparent casts.
28244 (OpcodeCast): New type for casts of types that are performed with
28245 a sequence of bytecodes.
28247 (BoxedCast): New type used for casting value types into reference
28248 types. Emits a box opcode.
28250 (Binary::DoNumericPromotions): Implements numeric promotions of
28251 and computation of the Binary::Type.
28253 (Binary::EmitBranchable): Optimization.
28255 (Binary::Emit): Implement code emission for expressions.
28257 * typemanager.cs (TypeManager): Added two new core types: sbyte
28260 2001-09-12 Ravi Pratap <ravi@ximian.com>
28262 * class.cs (TypeContainer::FindMembers): Method which does exactly
28263 what Type.FindMembers does, only we don't have to use reflection. No
28264 implementation yet.
28266 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
28267 typecontainer objects as we need to get at them.
28268 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
28270 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
28271 typecontainer object.
28273 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
28274 of just a Report object.
28276 2001-09-11 Ravi Pratap <ravi@ximian.com>
28278 * class.cs (Event::Define): Go back to using the prefixes "add_" and
28280 (TypeContainer::Populate): Now define the delegates of the type too.
28281 (TypeContainer.Delegates): Property to access the list of delegates defined
28284 * delegates.cs (Delegate::Define): Implement partially.
28286 * modifiers.cs (TypeAttr): Handle more flags.
28288 2001-09-11 Ravi Pratap <ravi@ximian.com>
28290 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
28292 (Operator::Define): Re-write logic to get types by using the LookupType method
28293 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
28294 (Indexer::Define): Ditto.
28295 (Event::Define): Ditto.
28296 (Property::Define): Ditto.
28298 2001-09-10 Ravi Pratap <ravi@ximian.com>
28300 * class.cs (TypeContainer::Populate): Now define operators too.
28301 (TypeContainer.Operators): New property to access the list of operators
28303 (Operator.OperatorMethodBuilder): New member to hold the method builder
28304 for the operator we are defining.
28305 (Operator::Define): Implement.
28307 2001-09-10 Ravi Pratap <ravi@ximian.com>
28309 * class.cs (Event::Define): Make the prefixes of the accessor methods
28310 addOn_ and removeOn_
28312 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
28313 of the location being passed in too. Ideally, this should go later since all
28314 error reporting should be done through the Report object.
28316 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
28317 (Populate): Iterate thru the indexers we have and define them too.
28318 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
28319 for the get and set accessors.
28320 (Indexer::Define): Implement.
28322 2001-09-09 Miguel de Icaza <miguel@ximian.com>
28324 * expression.cs (Binary::Resolve): Beginning of it. I scratched
28325 my previous implementation, did not work.
28327 * typemanager.cs: Add a couple of missing types (the longs).
28329 * literal.cs: Use TypeManager.bool_type instead of getting it.
28331 * expression.cs (EventExpr): New kind of expressions.
28332 (Expressio::ExprClassFromMemberInfo): finish
28334 2001-09-08 Miguel de Icaza <miguel@ximian.com>
28336 * assign.cs: Emit stores to static fields differently.
28338 2001-09-08 Ravi Pratap <ravi@ximian.com>
28340 * Merge in changes and adjust code to tackle conflicts. Backed out my
28341 code in Assign::Resolve ;-)
28343 2001-09-08 Ravi Pratap <ravi@ximian.com>
28345 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
28346 instead Report.Error and also pass in the location.
28347 (CSharpParser::Lexer): New readonly property to return the reference
28348 to the Tokenizer object.
28349 (declare_local_variables): Use Report.Error with location instead of plain
28353 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
28354 (Operator.CheckBinaryOperator): Ditto.
28356 * cs-parser.jay (operator_declarator): Update accordingly.
28358 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
28359 (CheckBinaryOperator): Same here.
28361 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
28362 on the name without any prefixes of namespace names etc. This is because we
28363 already might have something already fully qualified like
28364 'System.Console.WriteLine'
28366 * assign.cs (Resolve): Begin implementation. Stuck ;-)
28368 2001-09-07 Ravi Pratap <ravi@ximian.com>
28370 * cs-tokenizer.cs (location): Return a string which also contains
28373 * expression.cs (ElementAccess): New class for expressions of the
28374 type 'element access.'
28375 (BaseAccess): New class for expressions of the type 'base access.'
28376 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
28379 * cs-parser.jay (element_access): Implement action.
28380 (base_access): Implement actions.
28381 (checked_expression, unchecked_expression): Implement.
28383 * cs-parser.jay (local_variable_type): Correct and implement.
28384 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
28386 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
28388 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
28389 name and the specifiers.
28391 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
28393 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
28394 making them all public ;-)
28396 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
28399 2001-09-07 Miguel de Icaza <miguel@ximian.com>
28401 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
28403 (FieldExpr, PropertyExprs): New resolved expressions.
28404 (SimpleName::MemberStaticCheck): Perform static checks for access
28405 to non-static fields on static methods. Maybe this should be
28406 generalized for MemberAccesses.
28407 (SimpleName::ResolveSimpleName): More work on simple name
28410 * cs-parser.jay (primary_expression/qualified_identifier): track
28411 the parameter index.
28413 * codegen.cs (CodeGen::Save): Catch save exception, report error.
28414 (EmitContext::EmitBoolExpression): Chain to expression generation
28415 instead of temporary hack.
28416 (::EmitStatementExpression): Put generic expression code generation.
28418 * assign.cs (Assign::Emit): Implement variable assignments to
28419 local variables, parameters and fields.
28421 2001-09-06 Miguel de Icaza <miguel@ximian.com>
28423 * statement.cs (Block::GetVariableInfo): New method, returns the
28424 VariableInfo for a variable name in a block.
28425 (Block::GetVariableType): Implement in terms of GetVariableInfo
28427 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
28428 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
28430 2001-09-06 Ravi Pratap <ravi@ximian.com>
28432 * cs-parser.jay (operator_declaration): Continue on my quest : update
28433 to take attributes argument.
28434 (event_declaration): Ditto.
28435 (enum_declaration): Ditto.
28436 (indexer_declaration): Ditto.
28438 * class.cs (Operator::Operator): Update constructor accordingly.
28439 (Event::Event): Ditto.
28441 * delegate.cs (Delegate::Delegate): Same here.
28443 * enum.cs (Enum::Enum): Same here.
28445 2001-09-05 Ravi Pratap <ravi@ximian.com>
28447 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
28449 * ../tests/cs0658.cs : New file to demonstrate error 0658.
28451 * attribute.cs (Attributes): New class to encapsulate all attributes which were
28452 being passed around as an arraylist.
28453 (Attributes::AddAttribute): Method to add attribute sections.
28455 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
28456 (struct_declaration): Update accordingly.
28457 (constant_declaration): Update.
28458 (field_declaration): Update.
28459 (method_header): Update.
28460 (fixed_parameter): Update.
28461 (parameter_array): Ditto.
28462 (property_declaration): Ditto.
28463 (destructor_declaration): Ditto.
28465 * class.cs (Struct::Struct): Update constructors accordingly.
28466 (Class::Class): Ditto.
28467 (Field::Field): Ditto.
28468 (Method::Method): Ditto.
28469 (Property::Property): Ditto.
28470 (TypeContainer::OptAttribute): update property's return type.
28472 * interface.cs (Interface.opt_attributes): New member.
28473 (Interface::Interface): Update to take the extra Attributes argument.
28475 * parameter.cs (Parameter::Parameter): Ditto.
28477 * constant.cs (Constant::Constant): Ditto.
28479 * interface.cs (InterfaceMemberBase): New OptAttributes field.
28480 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
28481 the attributes as a parameter.
28482 (InterfaceProperty): Update constructor call.
28483 (InterfaceEvent): Ditto.
28484 (InterfaceMethod): Ditto.
28485 (InterfaceIndexer): Ditto.
28487 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
28488 pass the attributes too.
28489 (interface_event_declaration): Ditto.
28490 (interface_property_declaration): Ditto.
28491 (interface_method_declaration): Ditto.
28492 (interface_declaration): Ditto.
28494 2001-09-05 Miguel de Icaza <miguel@ximian.com>
28496 * class.cs (Method::Define): Track the "static Main" definition to
28497 create an entry point.
28499 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
28500 EntryPoint if we find it.
28502 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
28503 (EmitContext::ig): Make this variable public.
28505 * driver.cs: Make the default output file be the first file name
28506 with the .exe extension.
28508 Detect empty compilations
28510 Handle various kinds of output targets. Handle --target and
28511 rename -t to --dumper.
28513 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
28514 methods inherited from Expression return now an Expression. This
28515 will is used during the tree rewriting as we resolve them during
28518 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
28519 the spec. Missing entirely is the information about
28520 accessability of elements of it.
28522 (Expression::ExprClassFromMemberInfo): New constructor for
28523 Expressions that creates a fully initialized Expression based on
28524 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
28527 (Invocation::Resolve): Begin implementing resolution of invocations.
28529 * literal.cs (StringLiteral): Implement Emit.
28531 2001-09-05 Ravi Pratap <ravi@ximian.com>
28533 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
28536 2001-09-04 Ravi Pratap <ravi@ximian.com>
28538 * cs-parser.jay (attribute_arguments): Implement actions.
28539 (attribute): Fix bug in production. Implement action.
28540 (attribute_list): Implement.
28541 (attribute_target): Implement.
28542 (attribute_target_specifier, opt_target_specifier): Implement
28543 (CheckAttributeTarget): New method to check if the attribute target
28545 (attribute_section): Implement.
28546 (opt_attributes): Implement.
28548 * attribute.cs : New file to handle attributes.
28549 (Attribute): Class to hold attribute info.
28551 * cs-parser.jay (opt_attribute_target_specifier): Remove production
28552 (attribute_section): Modify production to use 2 different rules to
28553 achieve the same thing. 1 s/r conflict down !
28554 Clean out commented, useless, non-reducing dimension_separator rules.
28556 * class.cs (TypeContainer.attributes): New member to hold list
28557 of attributes for a type.
28558 (Struct::Struct): Modify to take one more argument, the attribute list.
28559 (Class::Class): Ditto.
28560 (Field::Field): Ditto.
28561 (Method::Method): Ditto.
28562 (Property::Property): Ditto.
28564 * cs-parser.jay (struct_declaration): Update constructor call to
28565 pass in the attributes too.
28566 (class_declaration): Ditto.
28567 (constant_declaration): Ditto.
28568 (field_declaration): Ditto.
28569 (method_header): Ditto.
28570 (fixed_parameter): Ditto.
28571 (parameter_array): Ditto.
28572 (property_declaration): Ditto.
28574 * constant.cs (Constant::Constant): Update constructor similarly.
28575 Use System.Collections.
28577 * parameter.cs (Parameter::Parameter): Update as above.
28579 2001-09-02 Ravi Pratap <ravi@ximian.com>
28581 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
28582 (TypeContainer.delegates): New member to hold list of delegates.
28584 * cs-parser.jay (delegate_declaration): Implement the action correctly
28585 this time as I seem to be on crack ;-)
28587 2001-09-02 Miguel de Icaza <miguel@ximian.com>
28589 * rootcontext.cs (RootContext::IsNamespace): new function, used to
28590 tell whether an identifier represents a namespace.
28592 * expression.cs (NamespaceExpr): A namespace expression, used only
28593 temporarly during expression resolution.
28594 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
28595 utility functions to resolve names on expressions.
28597 2001-09-01 Miguel de Icaza <miguel@ximian.com>
28599 * codegen.cs: Add hook for StatementExpressions.
28601 * class.cs: Fix inverted test for static flag in methods.
28603 2001-09-02 Ravi Pratap <ravi@ximian.com>
28605 * class.cs (Operator::CheckUnaryOperator): Correct error number used
28606 to make it coincide with MS' number.
28607 (Operator::CheckBinaryOperator): Ditto.
28609 * ../errors/errors.txt : Remove error numbers added earlier.
28611 * ../errors/cs1019.cs : Test case for error # 1019
28613 * ../errros/cs1020.cs : Test case for error # 1020
28615 * cs-parser.jay : Clean out commented cruft.
28616 (dimension_separators, dimension_separator): Comment out. Ostensibly not
28617 used anywhere - non-reducing rule.
28618 (namespace_declarations): Non-reducing rule - comment out.
28620 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
28621 with TypeContainer::AddEnum.
28623 * delegate.cs : New file for delegate handling classes.
28624 (Delegate): Class for declaring delegates.
28626 * makefile : Update.
28628 * cs-parser.jay (delegate_declaration): Implement.
28630 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
28632 * class.cs (Event::Define): Implement.
28633 (Event.EventBuilder): New member.
28635 * class.cs (TypeContainer::Populate): Update to define all enums and events
28637 (Events): New property for the events arraylist we hold. Shouldn't we move to using
28638 readonly fields for all these cases ?
28640 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28642 * class.cs (Property): Revamp to use the convention of making fields readonly.
28643 Accordingly modify code elsewhere.
28645 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
28646 the Define method of the Property class.
28648 * class.cs : Clean up applied patch and update references to variables etc. Fix
28650 (TypeContainer::Populate): Update to define all the properties we have. Also
28651 define all enumerations.
28653 * enum.cs (Define): Implement.
28655 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28657 * cs-parser.jay (overloadable_operator): The semantic value is an
28658 enum of the Operator class.
28659 (operator_declarator): Implement actions.
28660 (operator_declaration): Implement.
28662 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
28663 validity of definitions.
28664 (Operator::CheckBinaryOperator): Static method to check for binary operators
28665 (TypeContainer::AddOperator): New method to add an operator to a type.
28667 * cs-parser.jay (indexer_declaration): Added line to actually call the
28668 AddIndexer method so it gets added ;-)
28670 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
28671 already taken care of by the MS compiler ?
28673 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28675 * class.cs (Operator): New class for operator declarations.
28676 (Operator::OpType): Enum for the various operators.
28678 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28680 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
28681 ostensibly handle this in semantic analysis.
28683 * cs-parser.jay (general_catch_clause): Comment out
28684 (specific_catch_clauses, specific_catch_clause): Ditto.
28685 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
28686 (catch_args, opt_catch_args): New productions.
28687 (catch_clause): Rewrite to use the new productions above
28688 (catch_clauses): Modify accordingly.
28689 (opt_catch_clauses): New production to use in try_statement
28690 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
28691 and re-write the code in the actions to extract the specific and
28692 general catch clauses by being a little smart ;-)
28694 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
28695 Hooray, try and catch statements parse fine !
28697 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28699 * statement.cs (Block::GetVariableType): Fix logic to extract the type
28700 string from the hashtable of variables.
28702 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
28703 I end up making that mistake ;-)
28704 (catch_clauses): Fixed gross error which made Key and Value of the
28705 DictionaryEntry the same : $1 !!
28707 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28709 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
28711 * cs-parser.jay (event_declaration): Correct to remove the semicolon
28712 when the add and remove accessors are specified.
28714 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28716 * cs-parser.jay (IndexerDeclaration): New helper class to hold
28717 information about indexer_declarator.
28718 (indexer_declarator): Implement actions.
28719 (parsing_indexer): New local boolean used to keep track of whether
28720 we are parsing indexers or properties. This is necessary because
28721 implicit_parameters come into picture even for the get accessor in the
28722 case of an indexer.
28723 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
28725 * class.cs (Indexer): New class for indexer declarations.
28726 (TypeContainer::AddIndexer): New method to add an indexer to a type.
28727 (TypeContainer::indexers): New member to hold list of indexers for the
28730 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28732 * cs-parser.jay (add_accessor_declaration): Implement action.
28733 (remove_accessor_declaration): Implement action.
28734 (event_accessors_declaration): Implement
28735 (variable_declarators): swap statements for first rule - trivial.
28737 * class.cs (Event): New class to hold information about event
28739 (TypeContainer::AddEvent): New method to add an event to a type
28740 (TypeContainer::events): New member to hold list of events.
28742 * cs-parser.jay (event_declaration): Implement actions.
28744 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28746 * cs-parser.jay (dim_separators): Implement. Make it a string
28747 concatenating all the commas together, just as they appear.
28748 (opt_dim_separators): Modify accordingly
28749 (rank_specifiers): Update accordingly. Basically do the same
28750 thing - instead, collect the brackets here.
28751 (opt_rank_sepcifiers): Modify accordingly.
28752 (array_type): Modify to actually return the complete type string
28753 instead of ignoring the rank_specifiers.
28754 (expression_list): Implement to collect the expressions
28755 (variable_initializer): Implement. We make it a list of expressions
28756 essentially so that we can handle the array_initializer case neatly too.
28757 (variable_initializer_list): Implement.
28758 (array_initializer): Make it a list of variable_initializers
28759 (opt_array_initializer): Modify accordingly.
28761 * expression.cs (New::NType): Add enumeration to help us
28762 keep track of whether we have an object/delegate creation
28763 or an array creation.
28764 (New:NewType, New::Rank, New::Indices, New::Initializers): New
28765 members to hold data about array creation.
28766 (New:New): Modify to update NewType
28767 (New:New): New Overloaded contructor for the array creation
28770 * cs-parser.jay (array_creation_expression): Implement to call
28771 the overloaded New constructor.
28773 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
28775 * class.cs (TypeContainer::Constructors): Return member
28776 constructors instead of returning null.
28778 2001-08-26 Miguel de Icaza <miguel@ximian.com>
28780 * typemanager.cs (InitCoreTypes): Initialize the various core
28781 types after we have populated the type manager with the user
28782 defined types (this distinction will be important later while
28783 compiling corlib.dll)
28785 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
28786 on Expression Classification. Now all expressions have a method
28787 `Resolve' and a method `Emit'.
28789 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
28790 generation from working. Also add some temporary debugging
28793 2001-08-24 Miguel de Icaza <miguel@ximian.com>
28795 * codegen.cs: Lots of code generation pieces. This is only the
28796 beginning, will continue tomorrow with more touches of polish. We
28797 handle the fundamentals of if, while, do, for, return. Others are
28798 trickier and I need to start working on invocations soon.
28800 * gen-treedump.cs: Bug fix, use s.Increment here instead of
28803 * codegen.cs (EmitContext): New struct, used during code
28804 emission to keep a context. Most of the code generation will be
28807 * cs-parser.jay: Add embedded blocks to the list of statements of
28808 this block. So code generation proceeds in a top down fashion.
28810 2001-08-23 Miguel de Icaza <miguel@ximian.com>
28812 * statement.cs: Add support for multiple child blocks.
28814 2001-08-22 Miguel de Icaza <miguel@ximian.com>
28816 * codegen.cs (EmitCode): New function, will emit the code for a
28817 Block of code given a TypeContainer and its ILGenerator.
28819 * statement.cs (Block): Standard public readonly optimization.
28820 (Block::Block constructors): Link children.
28821 (Block::Child): Child Linker.
28822 (Block::EmitVariables): Emits IL variable declarations.
28824 * class.cs: Drop support for MethodGroups here, delay until
28826 (Method::): Applied the same simplification that I did before, and
28827 move from Properties to public readonly fields.
28828 (Method::ParameterTypes): Returns the parameter types for the
28829 function, and implements a cache that will be useful later when I
28830 do error checking and the semantic analysis on the methods is
28832 (Constructor::GetCallingConvention): Renamed from CallingConvetion
28833 and made a method, optional argument tells whether this is a class
28834 or a structure to apply the `has-this' bit.
28835 (Method::GetCallingConvention): Implement, returns the calling
28837 (Method::Define): Defines the type, a second pass is performed
28838 later to populate the methods.
28840 (Constructor::ParameterTypes): implement a cache similar to the
28841 one on Method::ParameterTypes, useful later when we do semantic
28844 (TypeContainer::EmitMethod): New method. Emits methods.
28846 * expression.cs: Removed MethodGroup class from here.
28848 * parameter.cs (Parameters::GetCallingConvention): new method.
28850 2001-08-21 Miguel de Icaza <miguel@ximian.com>
28852 * class.cs (TypeContainer::Populate): Drop RootContext from the
28855 (Constructor::CallingConvention): Returns the calling convention.
28856 (Constructor::ParameterTypes): Returns the constructor parameter
28859 (TypeContainer::AddConstructor): Keep track of default constructor
28860 and the default static constructor.
28862 (Constructor::) Another class that starts using `public readonly'
28863 instead of properties.
28865 (Constructor::IsDefault): Whether this is a default constructor.
28867 (Field::) use readonly public fields instead of properties also.
28869 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
28870 track of static constructors; If none is used, turn on
28871 BeforeFieldInit in the TypeAttributes.
28873 * cs-parser.jay (opt_argument_list): now the return can be null
28874 for the cases where there are no arguments.
28876 (constructor_declarator): If there is no implicit `base' or
28877 `this', then invoke the default parent constructor.
28879 * modifiers.cs (MethodAttr): New static function maps a set of
28880 modifiers flags into a MethodAttributes enum
28881 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
28882 MethodAttr, TypeAttr to represent the various mappings where the
28883 modifiers are used.
28884 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
28886 2001-08-19 Miguel de Icaza <miguel@ximian.com>
28888 * parameter.cs (GetParameterInfo): Fix bug where there would be no
28891 * interface.cs (PopulateIndexer): Implemented the code generator
28892 for interface indexers.
28894 2001-08-17 Miguel de Icaza <miguel@ximian.com>
28896 * interface.cs (InterfaceMemberBase): Now we track the new status
28899 (PopulateProperty): Implement property population. Woohoo! Got
28900 Methods and Properties going today.
28902 Removed all the properties for interfaces, and replaced them with
28903 `public readonly' fields.
28905 2001-08-16 Miguel de Icaza <miguel@ximian.com>
28907 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
28908 initialize their hashtables/arraylists only when they are needed
28909 instead of doing this always.
28911 * parameter.cs: Handle refs and out parameters.
28913 * cs-parser.jay: Use an ArrayList to construct the arguments
28914 instead of the ParameterCollection, and then cast that to a
28917 * parameter.cs: Drop the use of ParameterCollection and use
28918 instead arrays of Parameters.
28920 (GetParameterInfo): Use the Type, not the Name when resolving
28923 2001-08-13 Miguel de Icaza <miguel@ximian.com>
28925 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
28926 and instead use public readonly fields.
28928 * class.cs: Put back walking code for type containers.
28930 2001-08-11 Miguel de Icaza <miguel@ximian.com>
28932 * class.cs (MakeConstant): Code to define constants.
28934 * rootcontext.cs (LookupType): New function. Used to locate types
28937 2001-08-08 Miguel de Icaza <miguel@ximian.com>
28939 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
28940 this System.Reflection code is. Kudos to Microsoft
28942 * typemanager.cs: Implement a type cache and avoid loading all
28943 types at boot time. Wrap in LookupType the internals. This made
28944 the compiler so much faster. Wow. I rule!
28946 * driver.cs: Make sure we always load mscorlib first (for
28947 debugging purposes, nothing really important).
28949 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
28950 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
28952 * rootcontext.cs: Lookup types on their namespace; Lookup types
28953 on namespaces that have been imported using the `using' keyword.
28955 * class.cs (TypeContainer::TypeAttr): Virtualize.
28956 (Class::TypeAttr): Return attributes suitable for this bad boy.
28957 (Struct::TypeAttr): ditto.
28958 Handle nested classes.
28959 (TypeContainer::) Remove all the type visiting code, it is now
28960 replaced with the rootcontext.cs code
28962 * rootcontext.cs (GetClassBases): Added support for structs.
28964 2001-08-06 Miguel de Icaza <miguel@ximian.com>
28966 * interface.cs, statement.cs, class.cs, parameter.cs,
28967 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
28968 Drop use of TypeRefs, and use strings instead.
28970 2001-08-04 Miguel de Icaza <miguel@ximian.com>
28974 * class.cs (Struct::Struct): set the SEALED flags after
28975 checking the modifiers.
28976 (TypeContainer::TypeAttr): new property, returns the
28977 TypeAttributes for a class.
28979 * cs-parser.jay (type_list): Oops, list production was creating a
28980 new list of base types.
28982 * rootcontext.cs (StdLib): New property.
28983 (GetInterfaceTypeByName): returns an interface by type name, and
28984 encapsulates error handling here.
28985 (GetInterfaces): simplified.
28986 (ResolveTree): Encapsulated all the tree resolution here.
28987 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
28990 * driver.cs: Add support for --nostdlib, to avoid loading the
28991 default assemblies.
28992 (Main): Do not put tree resolution here.
28994 * rootcontext.cs: Beginning of the class resolution.
28996 2001-08-03 Miguel de Icaza <miguel@ximian.com>
28998 * rootcontext.cs: Provide better error reporting.
29000 * cs-parser.jay (interface_base): set our $$ to be interfaces.
29002 * rootcontext.cs (CreateInterface): Handle the case where there
29003 are no parent interfaces.
29005 (CloseTypes): Routine to flush types at the end.
29006 (CreateInterface): Track types.
29007 (GetInterfaces): Returns an array of Types from the list of
29008 defined interfaces.
29010 * typemanager.c (AddUserType): Mechanism to track user types (puts
29011 the type on the global type hash, and allows us to close it at the
29014 2001-08-02 Miguel de Icaza <miguel@ximian.com>
29016 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
29017 RecordInterface instead.
29019 * cs-parser.jay: Updated to reflect changes above.
29021 * decl.cs (Definition): Keep track of the TypeBuilder type that
29022 represents this type here. Not sure we will use it in the long
29023 run, but wont hurt for now.
29025 * driver.cs: Smaller changes to accomodate the new code.
29027 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
29030 * rootcontext.cs (CreateInterface): New method, used to create
29031 the System.TypeBuilder type for interfaces.
29032 (ResolveInterfaces): new entry point to resolve the interface
29034 (CodeGen): Property, used to keep track of the code generator.
29036 2001-07-26 Miguel de Icaza <miguel@ximian.com>
29038 * cs-parser.jay: Add a second production for delegate_declaration
29041 (enum_body): Put an opt_comma here instead of putting it on
29042 enum_body or enum_member_declarations so we can handle trailing
29043 commas on enumeration members. Gets rid of a shift/reduce.
29045 (type_list): Need a COMMA in the middle.
29047 (indexer_declaration): Tell tokenizer to recognize get/set
29049 * Remove old targets.
29051 * Re-add the parser target.
29053 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29055 * cs-parser.jay: Add precendence rules for a number of operators
29056 ot reduce the number of shift/reduce conflicts in the grammar.
29058 2001-07-17 Miguel de Icaza <miguel@ximian.com>
29060 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
29063 Get rid of old crufty code.
29065 * rootcontext.cs: Use this to keep track of the parsed
29066 representation and the defined types available to the program.
29068 * gen-treedump.cs: adjust for new convention.
29070 * type.cs: Split out the type manager, and the assembly builder
29073 * typemanager.cs: the type manager will live here now.
29075 * cil-codegen.cs: And the code generator here.
29077 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
29079 * makefile: Fixed up for easy making.
29081 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29083 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
29086 (unary_expression): Expand pre_increment_expression and
29087 post_decrement_expression to reduce a shift/reduce.
29089 2001-07-11 Simon Cozens
29091 * cs-tokenizer.cs: Hex numbers should begin with a 0.
29093 Improve allow_keyword_as_indent name.
29095 2001-06-19 Miguel de Icaza <miguel@ximian.com>
29097 * Adjustments for Beta2.
29099 2001-06-13 Miguel de Icaza <miguel@ximian.com>
29101 * decl.cs: Added `Define' abstract method.
29102 (InTransit): new property, used to catch recursive definitions.
29104 * interface.cs: Implement `Define'.
29106 * modifiers.cs: Map Modifiers.constants to
29107 System.Reflection.TypeAttribute flags.
29109 * class.cs: Keep track of types and user-defined types.
29110 (BuilderInit): New method for creating an assembly
29111 (ResolveType): New function to launch the resolution process, only
29112 used by interfaces for now.
29114 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
29115 that are inserted into the name space.
29117 2001-06-08 Miguel de Icaza <miguel@ximian.com>
29119 * ARGH. I have screwed up my tree so many times due to the use of
29120 rsync rather than using CVS. Going to fix this at once.
29122 * driver.cs: Objetify driver. Load assemblies, use assemblies to
29125 2001-06-07 Miguel de Icaza <miguel@ximian.com>
29127 * Experiment successful: Use System.Type rather that our own
29130 2001-05-25 Miguel de Icaza <miguel@ximian.com>
29132 * cs-parser.jay: Removed nsAliases from here.
29134 Use new namespaces, handle `using XXX;'
29136 * namespace.cs: Reimplemented namespace handling, use a recursive
29137 definition of the class. Now we can keep track of using clauses
29138 and catch invalid using clauses.
29140 2001-05-24 Miguel de Icaza <miguel@ximian.com>
29142 * gen-treedump.cs: Adapted for all the renaming.
29144 * expression.cs (Expression): this class now has a Type property
29145 which returns an expression Type.
29147 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
29148 `Type', as this has a different meaning now in the base
29150 2001-05-22 Miguel de Icaza <miguel@ximian.com>
29152 * interface.cs, class.cs: Removed from all the sources the
29153 references to signature computation, as we can not do method
29154 signature computation during the parsing time, as we are not
29155 trying to solve at that point distinguishing:
29159 void a (NS.Blah x) {}
29162 Which depending on the context might be valid or not, as we do not
29163 know if Blah is the same thing as NS.Blah at that point.
29165 * Redid everything so the code uses TypeRefs now instead of
29166 Types. TypeRefs are just temporary type placeholders, that need
29167 to be resolved. They initially have a pointer to a string and the
29168 current scope in which they are used. This is used later by the
29169 compiler to resolve the reference to an actual Type.
29171 * DeclSpace is no longer a CIR.Type, and neither are
29172 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
29173 are all DeclSpaces, but no Types.
29175 * type.cs (TypeRefManager): This implements the TypeRef manager,
29176 which keeps track of all the types that need to be resolved after
29177 the parsing has finished.
29179 2001-05-13 Miguel de Icaza <miguel@ximian.com>
29181 * ARGH. We are going to have to store `foreach' as a class rather
29182 than resolving it, as we need to verify error 1579 after name
29183 resolution. *OR* we could keep a flag that says `This request to
29184 IEnumerator comes from a foreach statement' which we can then use
29185 to generate the error.
29187 2001-05-10 Miguel de Icaza <miguel@ximian.com>
29189 * class.cs (TypeContainer.AddMethod): we now add methods to the
29190 MethodGroup instead of the method hashtable.
29192 * expression.cs: Add MethodGroup abstraction, which gets us one
29193 step closer to the specification in the way we handle method
29196 * cs-parser.jay (primary_expression): qualified_identifier now
29197 tried to match up an identifier to a local variable reference or
29198 to a parameter reference.
29200 current_local_parameters is now a parser global variable that
29201 points to the current parameters for the block, used during name
29204 (property_declaration): Now creates an implicit `value' argument to
29207 2001-05-09 Miguel de Icaza <miguel@ximian.com>
29209 * parameter.cs: Do not use `param' arguments as part of the
29210 signature, per the spec.
29212 2001-05-08 Miguel de Icaza <miguel@ximian.com>
29214 * decl.cs: Base class for classes, structs and interfaces. This
29215 is the "Declaration Space"
29217 * cs-parser.jay: Use CheckDef for checking declaration errors
29218 instead of having one on each function.
29220 * class.cs: Factor out some code for handling error handling in
29221 accordance to the "Declarations" section in the "Basic Concepts"
29222 chapter in the ECMA C# spec.
29224 * interface.cs: Make all interface member classes derive from
29225 InterfaceMemberBase.
29227 2001-05-07 Miguel de Icaza <miguel@ximian.com>
29229 * Many things: all interfaces are parsed and generated in
29230 gen-treedump. Support for member variables, constructors,
29231 destructors, properties, constants is there.
29233 Beginning of the IL backend, but very little done, just there for
29236 2001-04-29 Miguel de Icaza <miguel@ximian.com>
29238 * cs-parser.jay: Fix labeled statement.
29240 * cs-tokenizer.cs (escape): Escape " and ' always.
29241 ref_line, ref_name: keep track of the line/filename as instructed
29242 by #line by the compiler.
29245 2001-04-27 Miguel de Icaza <miguel@ximian.com>
29247 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
29248 to match the values in System.CodeDOM.
29250 Divid renamed to Divide.
29252 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
29254 (Statements.set): remove.
29256 * System.CodeDOM/CodeCatchClause.cs: always have a valid
29259 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
29260 falseStatements always have valid values.
29262 * cs-parser.jay: Use System.CodeDOM now.