1 2008-05-06 Marek Safar <marek.safar@gmail.com>
3 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4 when left is nullable type.
6 2008-05-06 Marek Safar <marek.safar@gmail.com>
9 * expression.cs (LocalVariableReference): Continue in resolving when
10 variable is not assigned.
12 2008-05-05 Marek Safar <marek.safar@gmail.com>
14 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
17 2008-05-04 Marek Safar <marek.safar@gmail.com>
19 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
20 it saves many redundant temporary variables for nullable operations.
22 2008-05-03 Marek Safar <marek.safar@gmail.com>
24 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
26 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
29 * nullable.cs: Constant coalescing operator optimizations.
31 2008-05-03 Marek Safar <marek.safar@gmail.com>
33 * constant.cs: Use unsigned conversion for values which are unsigned only.
35 2008-05-03 Marek Safar <marek.safar@gmail.com>
37 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
38 coalescing operator as it should be.
40 2008-05-02 Marek Safar <marek.safar@gmail.com>
43 * expression.cs: All predefined delegate operators require implicit method
46 2008-05-02 Marek Safar <marek.safar@gmail.com>
48 * constant.cs: Emit long constant as uint when fits the range.
50 * convert.cs, expression.cs: Fixed few unsafe conversions.
52 2008-05-02 Marek Safar <marek.safar@gmail.com>
54 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
56 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
59 * convert.cs (ImplicitNumericConversion): Don't modify the type of
61 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
63 2008-05-01 Marek Safar <marek.safar@gmail.com>
65 * constant.cs, literal.cs: IsLiteral property for error reporting.
67 * ecore.cs, expression.cs: Implemented Property expression.
69 2008-05-01 Marek Safar <marek.safar@gmail.com>
71 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
73 * nullable.cs: Implemented nullable coalescing null operator.
75 * ecore.cs, expression.cs: Expression trees work.
77 2008-05-01 Marek Safar <marek.safar@gmail.com>
79 * ecore.cs: CreateExpressionTree is finally abstract.
81 * expression.cs, linq.cs: Updated.
83 2008-05-01 Marek Safar <marek.safar@gmail.com>
85 * expression.cs, ecore.cs: Block base access expression inside expression
88 2008-05-01 Marek Safar <marek.safar@gmail.com>
91 * expression.cs: User-defined operator implementations always take
92 precedence over predefined operator implementations.
94 2008-04-30 Marek Safar <marek.safar@gmail.com>
96 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
97 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
98 expression tree conversions.
100 2008-04-30 Marek Safar <marek.safar@gmail.com>
102 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
103 operators method details to Operator class.
105 2008-04-30 Marek Safar <marek.safar@gmail.com>
107 * anonymous.cs: Pass unsafe flags to anonymous container.
109 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
110 inside expression tree.
112 2008-04-29 Martin Baulig <martin@ximian.com>
114 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
115 (Tokenizer.PopPosition): Also restore the `line'.
117 2008-04-29 Marek Safar <marek.safar@gmail.com>
119 * delegate.cs: Implemented Invoke expression.
121 2008-04-29 Marek Safar <marek.safar@gmail.com>
123 * expression.cs: Fixed equality reference comparison regression.
125 2008-04-29 Marek Safar <marek.safar@gmail.com>
127 * ecore.cs: Clean up EmptyCast hack.
129 * expression.cs, nullable.cs: Implemented enum binary and unary operations
130 using correct conversion rules. Also fixes #383993.
132 2008-04-28 Martin Baulig <martin@ximian.com>
134 * class.cs (Constructor.Emit): Don't emit debugging information
135 for generated default .ctor's.
137 2008-04-28 Marek Safar <marek.safar@gmail.com>
139 * convert.cs: Empty-cast ushort to int conversion.
141 2008-04-28 Marek Safar <marek.safar@gmail.com>
143 A fix for bug #384191
144 * ecore.cs, expression.cs: Fixed expression cloning.
146 2008-04-28 Marek Safar <marek.safar@gmail.com>
148 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
150 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
152 Fix #381559, test-638.cs, test-639.cs
153 * assign.cs (CompoundAssign.Helper): New wrapper.
154 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
156 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
157 Pass unconverted expressions to the params array creation expression.
158 (FieldExpr.EmitAssign): Don't special-case StringConcat.
159 (PropertyExpr.EmitAssign): Likewise.
160 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
161 element if it is of kind CompoundAssign.Helper.
162 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
163 first before anything else.
164 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
165 (ArrayAccess.LoadArrayAndArguments): Simplify.
167 2008-04-27 Marek Safar <marek.safar@gmail.com>
169 * expression.cs: Fixed cloning of typeof(void).
171 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
173 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
174 (Assign.Emit): Likewise. Move it to ...
175 (CompoundAssign.DoResolve): ... here and ...
176 (CompoundAssign.Emit): ... here.
177 (EventAddOrRemove): New helper to handle += and -= on events, and
178 avoid the use of BinaryDelegates.
179 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
180 (EventExpr.EmitAddOrRemove): Improve.
181 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
183 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
184 create VarExprs for 'foo.bar.var'.
185 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
186 is a highly inappropriate name for its functionality.
188 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
190 Simplify handling of multiple assignments
191 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
193 (SimpleAssign): New. Class to be used for normal assignments.
194 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
195 * expression.cs, parameter.cs, statement.cs: Likewise.
197 2008-04-25 Marek Safar <marek.safar@gmail.com>
199 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
200 for incompatible underlying types, more to come, uff.
202 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
205 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
208 2008-04-25 Marek Safar <marek.safar@gmail.com>
210 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
212 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
214 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
215 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
216 * statement.cs (While, Do, For): Allow test to have side effects.
217 (For.DoEmit): Always emit InitStatement.
220 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
221 Always create SideEffectConstant.
222 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
223 of type EnumConstant.
225 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
226 Handle 'right' being SideEffectConstant of type 'bool'.
228 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
229 Use left.EmitBranchable instead of open coding it, so as to
230 improve optimization opportunities.
232 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
234 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
236 (Expression.EmitSideEffect): Document.
238 2008-04-23 Marek Safar <marek.safar@gmail.com>
240 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
242 2008-04-23 Marek Safar <marek.safar@gmail.com>
244 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
246 2008-04-23 Marek Safar <marek.safar@gmail.com>
248 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
249 conversion to expression tree.
251 2008-04-23 Marek Safar <marek.safar@gmail.com>
253 * ecore.cs: Removed unused expression.
255 2008-04-22 Marek Safar <marek.safar@gmail.com>
257 * expression.cs: Implemented NegateChecked and New expressions.
259 2008-04-22 Marek Safar <marek.safar@gmail.com>
261 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
263 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
266 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
267 needing final 'ret' instruction.
269 2008-04-22 Marek Safar <marek.safar@gmail.com>
271 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
273 2008-04-21 Marek Safar <marek.safar@gmail.com>
275 * expression.cs: Emit ldnull and not null expression as an instance argument
276 of static method expression calls.
278 2008-04-21 Marek Safar <marek.safar@gmail.com>
280 A fix for bug #378200
281 * expression.cs: Fixed crash when creating parameterless expression tree
284 2008-04-21 Marek Safar <marek.safar@gmail.com>
286 A fix for bug #375297
287 * anonymous.cs: Fixed crash when inferring from null argument anonymous
290 2008-04-21 Marek Safar <marek.safar@gmail.com>
292 A fix for bug #377596
293 * decl.cs, class.cs: Emit delegate type argument attributes.
295 2008-04-21 Marek Safar <marek.safar@gmail.com>
297 A fix for bug #365314
298 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
300 2008-04-21 Marek Safar <marek.safar@gmail.com>
302 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
305 2008-04-21 Marek Safar <marek.safar@gmail.com>
307 * generic.cs (TypeParameter): Removed redundant location.
309 2008-04-19 Marek Safar <marek.safar@gmail.com>
311 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
312 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
313 FullNamedExpression in all declaration type expression, statements will come
316 2008-04-18 Marek Safar <marek.safar@gmail.com>
318 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
319 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
321 2008-04-18 Marek Safar <marek.safar@gmail.com>
323 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
326 2008-04-17 Marek Safar <marek.safar@gmail.com>
328 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
331 2008-04-17 Marek Safar <marek.safar@gmail.com>
333 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
337 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
339 Hook up 'EmitSideEffect'
340 * constant.cs (Constant.EmitSideEffect): New.
341 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
342 (SideEffectConstant.EmitSideEffect): New.
343 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
344 unconditional branch in EmitBranchable.
345 (FieldExpr.EmitBranchable): New.
346 * expression.cs (Unary.EmitSideEffect): New.
347 (Binary.EmitSideEffect): New.
348 (VariableReference.EmitSideEffect): New. Do nothing.
350 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
352 Introduce 'EmitSideEffect'
353 * ecore.cs (Expression.EmitSideEffect): New.
354 (TypeCast): Rename from EmptyCast.
356 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
357 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
358 * convert.cs, nullable.cs: Update to changes.
360 2008-04-16 Marek Safar <marek.safar@gmail.com>
362 * class.cs, cs-parser.jay: Early check for base types expression.
364 2008-04-16 Marek Safar <marek.safar@gmail.com>
366 * decl.cs (MemberName): Declare PrettyName as obsolete.
368 2008-04-16 Marek Safar <marek.safar@gmail.com>
370 * namespace.cs: Use MemberName comparison.
372 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
375 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
377 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
378 (MemberName.FullyQualifiedName): New. Provides the functionality
379 that users assume FullName would have.
380 * ecore.cs, namespace.cs: Update to changes.
382 * statement.cs (Using.assign): Make into ExpressionStatement.
383 (Using.EmitPreTryBody): Simplify.
385 2008-04-16 Marek Safar <marek.safar@gmail.com>
387 * report.cs: ColorFormat is protected.
389 * rootcontext.cs: Unused fields clean-up.
391 * namespace.cs: Made UsingEntry name private.
393 2008-04-16 Marek Safar <marek.safar@gmail.com>
395 * cs-tokenizer.cs, location.cs: Removed unused field.
397 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
398 Raja R Harinath <harinath@hurrynot.org>
401 * constant.cs (SideEffectConstant.value): Rename from 'left'.
402 (SideEffectConstant.side_effect): Rename from 'right'.
403 (SideEffectConstant..ctor): Normalize 'side_effect'.
404 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
405 value of this constant.
406 * cfold.cs: Update to changes.
408 2008-04-15 Marek Safar <marek.safar@gmail.com>
410 * cs-paser.jay: Removed unused variable.
412 * driver.cs: Made Compile instance method.
414 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
416 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
418 2008-04-15 Marek Safar <marek.safar@gmail.com>
420 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
422 2008-04-13 Jb Evain <jbevain@novell.com>
424 * namespace.cs: update the System.Core fullname for 2.1
425 * driver.cs: update the list of required assemblies for 2.1.
426 Merged from the Moonlight 2 branch.
428 2008-04-11 Marek Safar <marek.safar@gmail.com>
430 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
431 types and user defined operators. User operators arguments has to be checked
432 for null value before invocation, which also means no operator is called
433 when any argument is not convertible to unwrapped nullable type.
435 2008-04-09 Marek Safar <marek.safar@gmail.com>
437 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
438 of Unary expressions to follow operator overloading rules precisely.
439 Also fixes #321794, #323794
441 2008-04-08 Marek Safar <marek.safar@gmail.com>
443 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
446 2008-04-08 Marek Safar <marek.safar@gmail.com>
448 * expression.cs, ecore.cs: Implemented MemberInit expression.
450 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
452 Fix mono/tests/exception4.cs
453 * statement.cs (ExceptionStatement, TryCatch): Revert to using
454 ec.NeedReturnLabel () rather emitting a 'nop'.
456 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
458 (TryCatch.SomeCodeFollows): Likewise.
459 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
460 for 'break', 'continue' and 'return' statements inside a try.
461 We're fairly sure that the generated IL stream will have more
462 instructions textually following the try.
463 (FlowBranchingTryCatch): Likewise.
465 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
466 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
469 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
470 wrapper -- forward everything to CollectionForeach.
471 (CollectionForeach.NonDisposableWrapper): New.
472 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
473 instead of a pop + branch to end.
475 2008-04-07 Marek Safar <marek.safar@gmail.com>
477 A fix for bug #377485
478 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
479 Propagate location for extension method groups. Report conversion failure at
482 2008-04-07 Marek Safar <marek.safar@gmail.com>
484 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
485 ListInit and Field expressions.
487 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
489 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
490 Since $PC is always -1 inside the body of MoveNext, the fault
492 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
493 * statement.cs (ExceptionStatement.emit_finally): Likewise.
494 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
496 The denouement! Fix #324708
497 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
498 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
499 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
500 'finally' inside the finally clause.
502 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
503 inside an iterator. Don't emit the body of the 'finally' inside
504 the finally clause yet.
506 Use the ResumableStatement infrastructure for MoveNext ()
507 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
508 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
509 'old_resume_points'. Move dispatcher upfront.
510 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
511 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
512 in an enumerator. This encodes the main fix in this patch series
513 -- we can only jump into the first instruction of a try from the
514 outside, but we want to emit try/finally regions in iterators and
515 resume in the middle of them.
517 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
519 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
520 of NeedReturnLabel here.
522 Introduce a common point for emitting try/finally to IL
523 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
524 features of the various subclasses, which are now driven by ...
525 (ExceptionStatement.EmitPreTryBody): ... this and ...
526 (ExceptionStatement.EmitTryBody): ... this and the original
528 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
529 Remove DoEmit and update to follow above protocol.
531 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
532 of the dispatcher are the same, skip emitting the 'switch'.
533 * iterator.cs (Iterator.EmitDispose): Update to changes.
535 Clean up handling of 'using' statement
536 * statement.cs (UsingTemporary): New. Carved out of ...
537 (Using): ... this. Simplify drastically. Handle exactly
539 * cs-parser.jay (using_statement): Split. Create UsingTemporary
540 or Using as appropriate. If there are multiple variable declared,
541 create nested Using statements.
542 (resource_acquisition): Kill.
544 * statement.cs (ExceptionStatement.EmitForDispose): Use
545 EmitFinallyBody, not EmitFinally.
547 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
548 * iterator.cs: Update to changes.
550 Start using the ResumableStatement infrastructure
551 * statement.cs (ResumeableStatement.PrepareForDispose): New.
552 (ResumableStatement.EmitForDispose): New.
553 (ExceptionStatement): Override them.
554 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
555 EmitForDispose to create the body of the Dispose method. Don't
558 * iterator.cs (Iterator.AddResumePoint): Move here from ...
559 * statement.cs (Toplevel.AddResumePoint): ... here.
560 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
561 * flowanalysis.cs (FlowBranchingIterator): New.
562 * codegen.cs (EmitContext): Update to changes.
564 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
565 (Iterator.old_resume_points): Rename from 'resume_points'.
566 (Iterator.MoveNextStatement): Remove unused class.
568 New infrastructure for try/finally in iterators (still unused)
569 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
570 (FlowBranchingToplevel.AddResumePoint): Hook into
571 ToplevelBlock.AddResumePoint.
572 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
573 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
574 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
575 resume points and assign program-counter values.
576 (ExceptionBlock.AddResumePoint): Collect resume points for
577 de-muxer at the top of try block.
578 * iterators.cs (Yield.CheckContext): Simplify.
579 (Yield.Resolve): Use FlowBranching.AddResumePoint.
581 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
583 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
584 argument to an ExitStatement.
585 (FlowBranchingException): Refactor saved origins code.
586 * statement.cs (ExitStatement): Update to cahges.
587 * iterator.cs (YieldBreak): Likewise.
589 * statement.cs (ResumableStatement): New. Common base class for
590 YieldReturn and ExceptionStatement.
591 (ExitStatement): New. Common base class for Return and YieldBreak.
592 (Return): Update to changes.
593 * iterator.cs (YieldBreak): Likewise.
594 * lambda.cs (ContextualReturn): Likewise.
597 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
598 emit a meaningful error message.
601 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
602 (VariableInfo.SetAssigned): Set it.
603 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
604 determine if CS0219 or CS0168 is appropriate. Don't use
605 flow-analysis information.
606 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
607 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
608 (EmitContext.EndFlowBranching): ... this.
610 2008-04-03 Marek Safar <marek.safar@gmail.com>
612 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
614 2008-04-03 Marek Safar <marek.safar@gmail.com>
616 A fix for bug #376508
617 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
618 ImplicitConversionExists.
620 2008-04-03 Marek Safar <marek.safar@gmail.com>
622 * expression.cs (Binary): Added remaining binary operators to expression
625 * nullable.cs: Optimize shift with null argument.
627 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
629 Fix minor IL regression
630 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
631 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
632 * cs-parser.jay (try_statement): Update to changes.
634 * statement.cs (TryFinally.need_exc_block): Delete.
635 (TryFinally): Update to changes.
637 Now all ExceptionStatements are unconditional
638 * statement.cs (CollectionForeach.DisposableWrapper): New.
639 Extract out the try/finally code into a new wrapper.
640 (CollectionForeach.Resolve): Use it to simplify the code.
642 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
644 Start at simplifying ExceptionStatement semantics a bit
645 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
646 * cs-parser.jay (try_statement): Update to changes.
647 (opt_catch_clauses): Remove.
648 * flowanalysis.cs: Update to changes.
649 (FlowBranching.BranchingType.TryCatch): New.
650 (FlowBranchingTryCatch): New.
652 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
653 (FlowBranching.CreateBranching): Update to changes.
654 (FlowBranchingBlock.AddSibling): Add sanity check.
655 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
658 * iterators.cs (Iterator.MarkFinally): Remove.
659 * statement.cs (ExceptionStatement): Update to changes.
661 Add support for skipping over finally blocks at runtime. First
662 in a series to fix #324708
663 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
664 (Iterator.EmitMoveNext): Initialize it.
665 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
666 branch over the body of the 'finally' clause.
668 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
670 Avoid lopsided use of Foo/DoFoo names
671 * statement.cs (ExpressionStatement.EmitFinallyBody):
672 Rename from EmitFinally.
673 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
674 * iterator.cs: Update to changes.
676 2008-04-02 Marek Safar <marek.safar@gmail.com>
678 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
679 based on UserOperatorCall. More binary nullable operators clean up.
681 2008-04-02 Martin Baulig <martin@ximian.com>
683 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
685 2008-04-02 Marek Safar <marek.safar@gmail.com>
687 * nullable.cs: Merge user and empty conversions when lifting expression
690 * expression.cs (StringConcat): Implemented expression tree representation.
692 2008-04-01 Marek Safar <marek.safar@gmail.com>
694 * nullable.cs: When lifting null literal and a user operator exists, no call
697 2008-04-01 Marek Safar <marek.safar@gmail.com>
699 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
702 2008-04-01 Marek Safar <marek.safar@gmail.com>
704 * nullable.cs, expression.cs: Use namespace instead heavily nested
705 monster abstract class.
707 2008-04-01 Marek Safar <marek.safar@gmail.com>
709 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
710 lifting of null literal and user operators. Clean up of some temporary
713 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
715 Fix #368224, test-629.cs
716 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
717 if it crossed an unwind-protect boundary.
718 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
719 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
720 inside an unwind-protected region.
721 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
722 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
723 'leave' instead of a 'br' if unwind-protected.
724 (Iterator.EmitYieldBreak): Likewise.
726 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
728 * driver.cs: Only define versioninfo resources if no win32 resource
731 2008-03-28 Marek Safar <marek.safar@gmail.com>
733 A fix for bug #372375
734 * convert.cs: Fixed boxing of nullable types.
736 2008-03-28 Marek Safar <marek.safar@gmail.com>
738 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
741 2008-03-28 Marek Safar <marek.safar@gmail.com>
743 A fix for bug #374619
744 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
746 2008-03-27 Marek Safar <marek.safar@gmail.com>
748 * lambda.cs: Check return type only for invocation.
750 2008-03-27 Marek Safar <marek.safar@gmail.com>
752 A fix for bug #374214
753 * ecore.cs: Correctly report argument type mismatch.
755 2008-03-27 Marek Safar <marek.safar@gmail.com>
757 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
758 and not rely on broken IsEnum.
760 2008-03-27 Marek Safar <marek.safar@gmail.com>
762 * nullable.cs: New file, extracted from generic.cs.
764 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
766 2008-03-27 Marek Safar <marek.safar@gmail.com>
768 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
769 predefined comparison operators and null literals.
771 * report.cs: New warning ID.
773 2008-03-25 Marek Safar <marek.safar@gmail.com>
775 A fix for bug #370577
776 * lambda.cs: Check return type too.
778 2008-03-25 Marek Safar <marek.safar@gmail.com>
780 A fix for bug #372846
781 * class.cs: Automatic properties can be declared as unsafe.
783 2008-03-20 Marek Safar <marek.safar@gmail.com>
785 * location.cs: Use string based concatenation.
787 * expression.cs: LiftedBinaryOperator is gmcs only.
789 2008-03-20 Marek Safar <marek.safar@gmail.com>
791 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
792 conversions rules and expression trees.
794 2008-03-19 Marek Safar <marek.safar@gmail.com>
796 * delegate.cs: Use extension method source as delegate target.
798 2008-03-19 Marek Safar <marek.safar@gmail.com>
800 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
801 binary operations to be purely based on binary operations and optimized
802 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
803 and other ET refactoring.
805 * typemanager.cs: Fixed warning.
807 2008-03-17 Marek Safar <marek.safar@gmail.com>
809 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
811 * symbolwriter.cs: Fixed.
813 2008-03-17 Marek Safar <marek.safar@gmail.com>
815 * anonymous.cs, driver.cs: Reset anonymous types counters.
817 2008-03-17 Marek Safar <marek.safar@gmail.com>
819 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
821 * class.cs: Use fullname for all type member definitions.
823 2008-02-19 Martin Baulig <martin@ximian.com>
826 (IMethodData.EmitExtraSymbolInfo): New interface method.
827 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
828 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
829 interface method here as an empty public virtual method.
832 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
833 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
834 CodeGen.SymbolWriter.SetRealMethodName().
836 2008-02-18 Martin Baulig <martin@ximian.com>
839 (ScopeInfo.EmitType): Override this and emit debugging
840 information for captured variables.
841 (RootScopeInfo.EmitType): Override this and emit symbol
842 information for a captured `this'.
844 2008-02-15 Martin Baulig <martin@ximian.com>
846 * iterators.cs: Emit debugging info.
849 (EmitContext.Flags): Add `OmitDebuggingInfo'.
850 (EmitContext.OmitDebuggingInfo): New public property.
853 (While): Override Emit() and don't emit symbol info there; do it
854 inside DoEmit() instead.
855 (Block.Emit): Omit symbol information while emitting the scope
856 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
858 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
859 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
860 .ctor to make `IsIterator' work.
862 2008-03-14 Martin Baulig <martin@ximian.com>
864 * symbolwriter.cs: Added the new symbol writer function from the
865 debugger's `terrania' branch; temporarily enclose them inside
866 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
869 2008-03-14 Martin Baulig <martin@ximian.com>
872 (SymbolWriter): Make this a public static class.
875 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
876 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
878 2008-03-14 Marek Safar <marek.safar@gmail.com>
880 A fix for bug #370577
881 * statement.cs, lambda.cs: Added extra limitations when dealing with void
884 2008-03-14 Marek Safar <marek.safar@gmail.com>
886 * typemanager.cs (CSharpName): Made 250 times faster.
888 2008-03-13 Marek Safar <marek.safar@gmail.com>
890 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
892 2008-03-12 Marek Safar <marek.safar@gmail.com>
894 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
895 crash when predefined field does not exist.
897 2008-03-12 Marek Safar <marek.safar@gmail.com>
899 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
901 2008-03-12 Marek Safar <marek.safar@gmail.com>
903 * class.cs (FixedField): Don't crash when contructors are missing.
905 2008-03-11 Marek Safar <marek.safar@gmail.com>
907 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
908 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
909 check internal types accessibility for internal and external types.
910 Replaced EnumToUnderlying by GetEnumUnderlyingType.
912 2008-03-11 Marek Safar <marek.safar@gmail.com>
914 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
915 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
916 attribute.cs, statement: Use corect instance of predefined types (work
919 2008-03-07 Marek Safar <marek.safar@gmail.com>
921 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
923 2008-03-07 Marek Safar <marek.safar@gmail.com>
925 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
926 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
927 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
928 predefined types clean up, delayed predefined types members initialization
929 (work related to #364674).
931 2008-03-05 Marek Safar <marek.safar@gmail.com>
933 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
935 2008-03-05 Marek Safar <marek.safar@gmail.com>
937 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
938 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
939 predefined types clean up (work related to #364674).
941 2008-03-04 Marek Safar <marek.safar@gmail.com>
943 * ecore.cs: Print an error message instead of throwing exception.
945 2008-03-04 Marek Safar <marek.safar@gmail.com>
947 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
948 expression.cs, statement.cs: Unififed null literal representation.
950 2008-03-03 Marek Safar <marek.safar@gmail.com>
952 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
953 expression.cs: Refactored binary operators resolve phase and improved speed.
954 The nullable code is still missing and won't work correctly, more fixes
957 It also fixes #323726, #324312, #324248, and many other unreported issues.
959 2008-02-29 Zoltan Varga <vargaz@gmail.com>
961 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
964 2008-02-27 Marek Safar <marek.safar@gmail.com>
966 * ecore.cs: Clean-up and split BetterConversion.
968 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
971 * enum.cs (EnumMember.Value): Only access 'value' if
972 ResolveValue says it's ok.
973 (EnumMember.DoResolveValue): Don't set prev_member.value.
974 (Enum.GetDefinition): Reverse arguments of Equals --
975 EnumMember.Value can return 'null'.
977 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
979 2008-02-22 Marek Safar <marek.safar@gmail.com>
981 * generic.cs, expression.cs: More ongoing work on expression trees.
983 2008-02-21 Marek Safar <marek.safar@gmail.com>
985 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
986 handle missing matches when mutiple operators exist.
988 2008-02-20 Marek Safar <marek.safar@gmail.com>
990 A fix for bug #363218
991 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
994 2008-02-20 Marek Safar <marek.safar@gmail.com>
996 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
997 update. This time to deal correctly with SideEffectConstant expression used
998 as an argument for another constant folding.
1000 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
1002 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
1005 2008-02-19 Marek Safar <marek.safar@gmail.com>
1007 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
1009 2008-02-19 Marek Safar <marek.safar@gmail.com>
1011 A fix for bug #328136
1012 * expression.cs: Do not fold immediately LogicalAnd operators when the left
1013 side is a false constant, because we still need to evaluate the right-hand
1016 * statement.cs (If): Emit two types of boolean constants (simple constant,
1017 side-effect constant).
1019 2008-02-19 Marek Safar <marek.safar@gmail.com>
1021 * constant.cs (SideEffectConstant): Don't emit boolean constant.
1023 * expression.cs: Fold immediately LogicalAnd operators when both sides are
1026 2008-02-18 Marek Safar <marek.safar@gmail.com>
1028 A fix for bug #361457
1029 * ecore.cs (IsApplicable): Params methods have lower priority.
1031 * support.cs: Return correct parameter modifier for params types.
1033 2008-02-18 Marek Safar <marek.safar@gmail.com>
1035 * generic.cs (TypeParameter): Cache attribute target name.
1037 * support.cs: Removed unused variable.
1039 * typemanager.cs: Removed debugging leftover.
1041 * ecore.cs: Use local type instead of a property;
1043 * class.cs (VerifyMembers): Consider also parent to test whether type member
1046 * expression.cs (FullMethodDesc): Removed.
1048 * attribute.cs (IsValidArgumentType): Made static.
1050 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
1052 Cleanup to be more readable.
1053 * Makefile (GMCS_PROFILE): Remove.
1054 (COMPILER_NAME): New helper.
1056 2008-02-15 Miguel de Icaza <miguel@novell.com>
1058 * cs-tokenizer.cs: if a conditional expression happens inside a
1059 (...) this also means that we do not need to de-ambiguate between
1060 an parenthesized expression and a cast.
1064 * constant.cs (SideEffectConstant): a constant value that happens
1065 to have a side effect.
1067 Fixes the build regressions introduced by the fix for #359789
1069 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
1071 * expression.cs (Conditional.Emit): when emitting the ternary
1072 operator, use local variables to generate code verifiable code.
1074 The verifier cannot infer that the type on stack before the
1075 stloc.0 is executed is of type ParentB. This happens because the
1076 stack merge algorithm uses only parent types when deciding which
1077 is the common type. This is described in Part III 1.8.1.3 of ECMA
1080 This code compiled with mcs is not verifiable under MS. The MS
1081 verifier picks the first common interface of Foo and Bar, which is
1082 wrong, but doesn't use a full join type of the 2 interfaces.
1084 CSC uses a clever hack to compile such code in a verifiable
1085 way. It stores the intermediate values in a local variable with
1090 2008-02-14 Miguel de Icaza <miguel@novell.com>
1092 * expression.cs: Do not fold BitwiseAnd operators when the left
1093 side is a false constant, because we still need to evaluate the
1098 * support.cs: Instead of throwing an InternalErrorException when
1099 the position of the stream is outside the boundary of our buffer,
1100 reset the state of the reader, and restart the reading from the
1101 beginning of the file.
1103 2008-02-14 Marek Safar <marek.safar@gmail.com>
1105 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
1107 2008-02-14 Marek Safar <marek.safar@gmail.com>
1109 A fix for bug #361686
1110 * decl.cs: A protected types used inside a private class which parents
1111 derives from the protected class are accessible.
1113 2008-02-13 Marek Safar <marek.safar@gmail.com>
1115 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
1116 the parameterless constructor.
1118 2008-02-13 Marek Safar <marek.safar@gmail.com>
1120 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
1121 lookup methods to use standard member cache when doing member lookup.
1123 2008-02-12 Marek Safar <marek.safar@gmail.com>
1125 * driver.cs: Don't report full path for referenced module as assembly error.
1127 2008-02-12 Marek Safar <marek.safar@gmail.com>
1129 * Makefile: Fixed `qh' target to work on all machines.
1131 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
1132 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
1133 and HasElementType with TypeManager implementation.
1135 2008-02-08 Marek Safar <marek.safar@gmail.com>
1137 A fix for bugs #325134, #359749
1138 * expression.cs, ecore.cs: Try to resolve an extension method even if the
1139 first binds point to non-method member expression.
1141 2008-02-08 Marek Safar <marek.safar@gmail.com>
1143 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
1145 2008-02-08 Marek Safar <marek.safar@gmail.com>
1147 A fix for bugs #321394, #323028
1148 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
1149 Reworked naive IsAccessibleAs implementation to handle nested types.
1151 2008-02-05 Jb Evain <jbevain@novell.com>
1153 * class.cs: use generic type comparison for parameters
1156 2008-02-05 Marek Safar <marek.safar@gmail.com>
1158 A fix for bug #325372
1159 * class.cs: Use generic type comparison when testing method signatures.
1161 2008-02-05 Marek Safar <marek.safar@gmail.com>
1163 A fix for bug #357047
1164 * ecore.cs: Applied C# 3.0 changes to better conversion.
1166 2008-02-05 Marek Safar <marek.safar@gmail.com>
1168 A fix for bug #358374
1169 * cs-parser.jay: Correctly set modifiers for all constructor types.
1171 2008-02-04 Marek Safar <marek.safar@gmail.com>
1173 A fix for bug #355251
1174 * generic.cs: Added base class constraint based type inference.
1176 2008-02-01 Marek Safar <marek.safar@gmail.com>
1178 A fix for bug #357255
1179 * decl.cs: One more missing visibility check.
1181 2008-02-01 Marek Safar <marek.safar@gmail.com>
1183 * support.cs: Fixed broken return.
1185 2008-01-25 Marek Safar <marek.safar@gmail.com>
1187 * report.cs: Correctly reset warnings count after probing.
1189 2008-01-25 Martin Baulig <martin@ximian.com>
1192 (NamespaceEntry.SymbolFileID): Make this work again after
1193 MemberName.ToString() is gone.
1195 2008-01-25 Marek Safar <marek.safar@gmail.com>
1197 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
1200 2008-01-25 Marek Safar <marek.safar@gmail.com>
1202 * generic.cs: Use full implicit conversion for type inference fixing.
1204 2008-01-24 Marek Safar <marek.safar@gmail.com>
1206 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
1207 Fixed user operator conversions.
1209 2008-01-24 Marek Safar <marek.safar@gmail.com>
1211 * generic.cs: Do nullable type to null comparison optimization during
1214 2008-01-24 Marek Safar <marek.safar@gmail.com>
1216 A fix for bug #355163
1217 * generic.cs: Enabled l-value resolve on nullable expressions.
1219 2008-01-24 Marek Safar <marek.safar@gmail.com>
1221 A fix for bug #353986
1222 * class.cs: Ingore static ctors with parameters for any further checks.
1224 2008-01-24 Marek Safar <marek.safar@gmail.com>
1226 A fix for bug #354310
1227 * namespace.cs: Removed redundant check.
1229 2008-01-24 Marek Safar <marek.safar@gmail.com>
1231 A fix for bug #354928
1232 * expression.cs: ElementInitializers can be resolved only once.
1234 2008-01-24 Marek Safar <marek.safar@gmail.com>
1236 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
1237 Condition expressions.
1239 2008-01-23 Marek Safar <marek.safar@gmail.com>
1241 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
1243 2008-01-22 Marek Safar <marek.safar@gmail.com>
1245 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
1248 * generic.cs: Implemented coalesce expression.
1250 2008-01-22 Marek Safar <marek.safar@gmail.com>
1252 A fix for bug #355145
1253 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
1254 expression tree type inference.
1256 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
1259 * expression.cs (Binary.IsUnsignedType): Fix typo.
1261 2008-01-22 Marek Safar <marek.safar@gmail.com>
1263 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
1265 2008-01-22 Marek Safar <marek.safar@gmail.com>
1267 A fix for bug #355161
1268 * ecore.cs, expression.cs: Wider range of extension method supported
1271 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
1273 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
1274 AssemblyBuilder to operate in compiler context. Fixes mcs part of
1277 2008-01-22 Marek Safar <marek.safar@gmail.com>
1279 A fix for bug #355148
1280 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
1282 2008-01-22 Miguel de Icaza <miguel@novell.com>
1284 * expression.cs (CreateExpressionTree): Add support for or and
1285 logical or, and indent following the coding conventions.
1287 * typemanager.cs (LinqExpression): renamed from
1288 ExpressionTreeManager, for a shorter name.
1290 Use TypeManager.CoreLookupType to lookup types from our core
1291 assemblies and turn those into "Type" variables.
1293 Consumers that previously used "Namespace" and "Type" from this
1294 class should instead use the TypeExpression which is a type that
1295 is fully resolved (without involving the regular C# resolution
1298 This typically looks like this:
1300 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
1301 new MemberAccess (texpr, name, type_arguments, loc)
1303 This avoids the problem in: #355178
1305 2008-01-21 Marek Safar <marek.safar@gmail.com>
1307 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
1308 feature in parser only as we do in other cases.
1310 2008-01-21 Marek Safar <marek.safar@gmail.com>
1312 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
1313 typemanager.cs: A refactoring of params arguments to reuse existing
1314 expressions (params -> array initializer) to emit params argument instead
1315 of specialized handling.
1316 It was required by expression tree implementation and it has other benefits
1317 as well, we now apply same optimization for params arguments as we do for
1320 2008-01-18 Marek Safar <marek.safar@gmail.com>
1322 A fix for bug #353526
1323 * generic.cs: A type inference of params arguments may not required any
1324 temporary array creation.
1326 2008-01-18 Marek Safar <marek.safar@gmail.com>
1328 A fix for bug #353534
1329 * generic.cs, ecore.cs, expression.cs: A method group type inference is
1330 supported for delegates only.
1332 2008-01-18 Marek Safar <marek.safar@gmail.com>
1334 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
1335 type for more than 1 candidates.
1337 2008-01-18 Marek Safar <marek.safar@gmail.com>
1339 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
1342 2008-01-16 Marek Safar <marek.safar@gmail.com>
1344 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
1345 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
1346 operator) expressions.
1348 2008-01-16 Zoltan Varga <vargaz@gmail.com>
1350 * statement.cs: Avoid declaring an IL variable for this_variable since it is
1351 not accessed from the generated IL.
1353 2008-01-14 Marek Safar <marek.safar@gmail.com>
1355 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
1356 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
1357 statement.cs: The first expression tree implementation drop, mostly
1358 infrastructure work.
1360 2008-01-14 Marek Safar <marek.safar@gmail.com>
1362 * ecore.cs (IsNestedChild): Refactored.
1364 2008-01-11 Marek Safar <marek.safar@gmail.com>
1366 * lambda.cs: Don't use a cast on unknown expression statement.
1368 2008-01-10 Geoff Norton <gnorton@novell.com>
1370 * cs-tokenizer.cs: One more token to distinguish between method and lambda
1373 2008-01-09 Marek Safar <marek.safar@gmail.com>
1375 * doc.cs: Report better /doc crash details.
1377 2008-01-09 Marek Safar <marek.safar@gmail.com>
1379 A fix for bug #352536
1380 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
1382 2008-01-08 Marek Safar <marek.safar@gmail.com>
1384 A fix for bug #352287
1385 * ecore.cs, expression.cs: Do `this' access checking in all member access
1388 2008-01-08 Marek Safar <marek.safar@gmail.com>
1390 * rootcontext.cs, driver.cs: Switch to linq mode by default.
1392 * report.cs: Reset message stacks.
1394 2008-01-08 Marek Safar <marek.safar@gmail.com>
1396 * generic.cs (InferInPhases): Correctly calculate params position.
1398 2008-01-08 Marek Safar <marek.safar@gmail.com>
1400 * cs-tokenizer.cs: No need to parse full string when parsing lambda
1403 2008-01-07 Marek Safar <marek.safar@gmail.com>
1405 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
1407 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
1409 * driver.cs: Updated --help option.
1411 2008-01-07 Marek Safar <marek.safar@gmail.com>
1413 * generic.cs (InferParamsTypeArguments): Removed.
1414 (InferInPhases): Add params type inference.
1415 (LowerBoundInference): Fixed scoring mechanism.
1417 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
1419 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
1421 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
1422 byte array for unsigned "baked" assemblies.
1424 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
1426 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
1427 array for assemblies that are not strongnamed.
1429 2008-01-04 Marek Safar <marek.safar@gmail.com>
1431 A fix for bug #351481
1432 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
1433 declaring type for nested generic types.
1435 2008-01-04 Marek Safar <marek.safar@gmail.com>
1437 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
1438 instead of ToString.
1440 2008-01-03 Marek Safar <marek.safar@gmail.com>
1442 A fix for bug #351047
1443 * expression.cs (Binary.ResolveOperator): Allow equality operators between
1444 null and structs only when equality and inequality operators are defined
1445 either as an user-operators or predefined operators.
1447 2008-01-03 Marek Safar <marek.safar@gmail.com>
1449 A fix for bug #351047
1450 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
1452 2008-01-03 Marek Safar <marek.safar@gmail.com>
1454 A fix for bug #351257
1455 * cs-tokenizer.cs: Advance line number for '\r' correctly.
1457 2008-01-03 Marek Safar <marek.safar@gmail.com>
1459 A fix for bug #351157
1460 * class.cs (Using): Fixed yet another broken cloning.
1462 (Block): Put back more sensible default value for statements.
1464 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
1466 * codegen.cs: Allow AssemblyVersion with only major version component.
1469 2007-12-29 Marek Safar <marek.safar@gmail.com>
1471 A fix for bug #324654
1472 * class.cs: Use FullName property as member name.
1474 2007-12-28 Marek Safar <marek.safar@gmail.com>
1476 A fix for bug #342117
1477 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
1478 constructor constraint.
1480 2007-12-28 Marek Safar <marek.safar@gmail.com>
1482 A fix for bug #338273
1483 * class.cs (ProbertyBase): Access modifier checks are required for overrides
1486 2007-12-28 Marek Safar <marek.safar@gmail.com>
1488 A fix for bug #350839
1489 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
1491 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1493 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1496 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1498 * statement.cs: Changed some Hashtables to use HybridDictionaries
1499 instead. It was observed that some HashTables only contained a few
1500 items in the vast majority of cases. Since HybridDictionary is
1501 more efficient on small sets (<10 elements), "known_variables"
1502 from class ExplicitBlock as well as "labels" and "constants " from
1503 class Block were changed to HybridDictionaries.
1505 Atsai results: (56216kb->54987kb)
1507 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
1510 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1512 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1515 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1517 * expression.cs: foreach loop to for loop, saved on allocation of
1518 enumerator (59333kb->59141kb)
1520 * statement.cs. Changed foreach loops to for loops, saved on
1521 allocation of enumerator (59141kb->59006kb)
1523 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
1524 when constructed with no specified capacity. This was causing a
1525 few ArrayLists to allocate more memory than they would potentially
1526 need in the Block class and MemberCache class. Setting the
1527 ArrayLists to construct with a capacity of 1 saves some
1528 memory. (56216kb->55585kb)
1530 2007-12-27 Marek Safar <marek.safar@gmail.com>
1532 A fix for bug #347189 (2nd issue)
1533 * expression.cs (MemberAccess): Nested type can be found in base non-generic
1536 2007-12-27 Miguel de Icaza <miguel@novell.com>
1538 * report.cs: Do not use colors if stdout and stderr are not a
1541 2007-12-27 Marek Safar <marek.safar@gmail.com>
1543 A fix for bug #346998
1544 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
1547 2007-12-27 Marek Safar <marek.safar@gmail.com>
1549 A fix for bug #343465
1550 * class.cs: Explicit method name for nested types uses dots only.
1552 2007-12-27 Marek Safar <marek.safar@gmail.com>
1554 A fix for bug #343707
1555 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
1557 2007-12-27 Marek Safar <marek.safar@gmail.com>
1559 * ecore.cs: Report type inference errors only when arguments count matches
1562 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
1564 * expression.cs, report.cs: New warning.
1566 * typemanager.cs: Catch anonymous method type too.
1568 2007-12-23 Marek Safar <marek.safar@gmail.com>
1570 A fix for bug #346379
1571 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
1573 2007-12-23 Marek Safar <marek.safar@gmail.com>
1575 A fix for bug #347359
1576 * expression.cs (Invocation): Don't resolve already resolved expression.
1578 2007-12-23 Marek Safar <marek.safar@gmail.com>
1580 A fix for bug #347189
1581 * class.cs (FixedField): Use non-dependent code only in the define phase.
1583 2007-12-23 Marek Safar <marek.safar@gmail.com>
1585 A fix for bug #348076
1586 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
1588 2007-12-22 Marek Safar <marek.safar@gmail.com>
1590 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
1591 discovered extension methods.
1593 2007-12-22 Marek Safar <marek.safar@gmail.com>
1595 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
1598 2007-12-21 Miguel de Icaza <miguel@novell.com>
1600 * report.cs (ErrorMessage): Add support for using colors on
1601 terminals that support it.
1603 2007-12-21 Marek Safar <marek.safar@gmail.com>
1605 * ecore.cs: Use information about expanded params for error reporting.
1607 2007-12-21 Marek Safar <marek.safar@gmail.com>
1609 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
1610 and logic for params overloads.
1612 2007-12-15 Miguel de Icaza <miguel@novell.com>
1614 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
1615 as this is also created from the parser. Fixes #349034
1617 2007-12-12 Miguel de Icaza <miguel@novell.com>
1619 * statement.cs (Throw.CloneTo): it is valid to have empty
1620 expressions for throw.
1622 2007-12-03 Marek Safar <marek.safar@gmail.com>
1624 * cs-parser.jay: Set delegate constraint parsing region correctly.
1626 2007-12-03 Marek Safar <marek.safar@gmail.com>
1628 A fix for bug #345467
1629 * typemanager.cs (IsEqual): Compare generic parameters position only.
1631 2007-11-28 Marek Safar <marek.safar@gmail.com>
1633 * expression.cs (BaseAccess): Type arguments can be null.
1635 2007-11-27 Raja R Harinath <harinath@gmail.com>
1637 * statement.cs (Block.Resolve): Ensure flow-branching tree is
1638 consistent even when an error has occured.
1639 (Switch.Resolve): Likewise.
1641 2007-11-22 Marek Safar <marek.safar@gmail.com>
1643 A fix for bug #334505
1644 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
1647 2007-11-22 Marek Safar <marek.safar@gmail.com>
1649 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
1650 refactorings required to resolve extension methods correctly when mixing
1651 generics and non-generics members.
1653 2007-11-20 Marek Safar <marek.safar@gmail.com>
1655 A fix for bug #342584
1656 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
1659 2007-11-19 Marek Safar <marek.safar@gmail.com>
1661 A fix for bug #342512
1662 * delegate.cs: Use delegate argument expression when is available. Don't
1663 emit virtual call when class is sealed.
1665 2007-11-16 Marek Safar <marek.safar@gmail.com>
1667 A fix for bug #325423
1668 * assign.cs (FieldInitializer): Use resolved expression for emit.
1670 * class.cs: Print less confusing error message.
1672 2007-11-16 Marek Safar <marek.safar@gmail.com>
1674 * cs-tokenizer.cs: Removed GMCS ifdefs.
1676 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
1679 * cs-parser.jay: Disabled nullable check.
1681 * generic-mcs: Copied more generic stuff.
1683 2007-11-16 Marek Safar <marek.safar@gmail.com>
1685 * gcs-parser.jay: Merged to cs-parser.jay.
1687 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
1688 * *.csproj, *.sources: Updated to use only jay parser file.
1690 2007-11-16 Marek Safar <marek.safar@gmail.com>
1692 * gcs-parser.jay: Added nullable and default expression feature checks.
1694 2007-11-16 Marek Safar <marek.safar@gmail.com>
1696 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
1697 it fixes many TODOs and hidden bugs.
1699 * expression: Removed duplicate error check.
1701 2007-11-15 Marek Safar <marek.safar@gmail.com>
1703 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
1704 implicitly type local variable only when it is used in a declaration.
1706 2007-11-15 Marek Safar <marek.safar@gmail.com>
1708 * attribute.cs: Use CS0612 for empty strings.
1710 2007-11-14 Marek Safar <marek.safar@gmail.com>
1712 * lambda.cs, statement.cs: Contextual return may act as a statement.
1714 2007-11-14 Marek Safar <marek.safar@gmail.com>
1716 A fix for a regression cause by #324222
1717 * class.cs: Don't report unused even when it implements an interface.
1719 2007-11-13 Marek Safar <marek.safar@gmail.com>
1721 A fix for bug #341205
1722 * ecore.cs, expression.cs: Method group expression cannot do static
1723 method access with an instance reference check before overloading takes
1726 2007-11-13 Marek Safar <marek.safar@gmail.com>
1728 A fix for bug #325359
1729 * class.cs: Use predictable name for automatically generated property.
1731 2007-11-12 Marek Safar <marek.safar@gmail.com>
1733 A fix for bug #324996
1734 * expression.cs (Is): Handle case where D is nullable and T is not
1737 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
1739 2007-11-12 Marek Safar <marek.safar@gmail.com>
1741 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
1742 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
1743 Flush small error reporting changes.
1745 2007-11-09 Marek Safar <marek.safar@gmail.com>
1747 A fix for bug #324996
1748 * expression.cs: Rewrote Is expression implementation to work with
1749 generics, nullable types, anonymous method. A const result expression
1750 uses existing infrastructure instead of custom not fully-featured one.
1752 2007-11-08 Marek Safar <marek.safar@gmail.com>
1754 A fix for bug #340202
1755 * class.cs: Consider generics for volatile field.
1757 2007-11-08 Marek Safar <marek.safar@gmail.com>
1759 A fix for bug #335594
1760 * expression.cs: Use conversion rules when handling string addition.
1762 2007-11-07 Marek Safar <marek.safar@gmail.com>
1764 A fix for bug #336651
1765 * expression.cs: Fixed a crash when probing is on.
1767 2007-11-07 Marek Safar <marek.safar@gmail.com>
1769 A fix for bug #324242
1770 * covert.cs: Added a conversion from any nullable-type with an
1771 underlying enum-type to the type System.Enum.
1773 2007-11-07 Marek Safar <marek.safar@gmail.com>
1775 A fix for bug #324222
1776 * class.cs: Report all non-used event fields.
1778 2007-11-07 Marek Safar <marek.safar@gmail.com>
1780 A fix for bug #325161
1781 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
1782 qualifier for generic types.
1784 2007-11-07 Marek Safar <marek.safar@gmail.com>
1786 A fix for bug #322971
1787 * expression.cs, ecore.cs: Added intermediate result value check for
1790 2007-11-07 Marek Safar <marek.safar@gmail.com>
1792 A fix for bug #324754
1793 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
1794 when it was requested.
1796 2007-11-07 Marek Safar <marek.safar@gmail.com>
1798 A fix for bug #325101
1799 * expression.cs: Do type not value comparison for `is' expression.
1801 2007-11-07 Marek Safar <marek.safar@gmail.com>
1803 A fix for bug #320236
1804 * convert.cs: Don't apply user conversion on underlying target type.
1806 2007-11-06 Marek Safar <marek.safar@gmail.com>
1808 * expression.cs: Don't use unresolved expression for error reporting.
1810 2007-11-06 Marek Safar <marek.safar@gmail.com>
1812 A fix for bugs #337712, #324490
1813 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
1814 overloading resolution too.
1816 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
1817 the process consistent and more robust.
1819 * expression.cs, linq.cs, report.cs: Update.
1821 2007-11-02 Marek Safar <marek.safar@gmail.com>
1823 A fix for bug #332909
1824 * attribute.cs: Resolve attributes in correct context using error
1827 * rootcontext.cs: Define Obsolete attribute members as core members.
1829 2007-11-02 Marek Safar <marek.safar@gmail.com>
1831 * statement.cs: Removed unused methods.
1833 2007-10-31 Wade Berrier <wberrier@novell.com>
1835 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
1836 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
1839 2007-10-31 Marek Safar <marek.safar@gmail.com>
1841 A fix for bug #338102
1842 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
1843 methods registered as non-generics.
1845 2007-10-31 Marek Safar <marek.safar@gmail.com>
1847 A fix for bugs #337712, #324490
1848 * delegate.cs: Delegate covariance and contravariance is not allowed for
1851 2007-10-31 Marek Safar <marek.safar@gmail.com>
1853 A fix for bug #337719
1854 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
1857 2007-10-30 Marek Safar <marek.safar@gmail.com>
1859 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
1861 2007-10-29 Marek Safar <marek.safar@gmail.com>
1863 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
1866 2007-10-29 Raja R Harinath <rharinath@novell.com>
1868 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
1870 2007-10-29 Marek Safar <marek.safar@gmail.com>
1872 A fix for bug #334652
1873 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
1874 extension methods when we have not found the best candidate in normal
1877 2007-10-27 Marek Safar <marek.safar@gmail.com>
1879 * AssemblyInfo.cs: Keep up-to-date.
1881 2007-10-27 Marek Safar <marek.safar@gmail.com>
1883 * Makefile: Fixed generics compiler name.
1885 2007-10-27 Marek Safar <marek.safar@gmail.com>
1887 * lambda.test: removed, lambda parsing is done differently.
1889 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
1891 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
1893 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
1895 2007-10-27 Marek Safar <marek.safar@gmail.com>
1897 * Makefile, *.sources : All C# compilers are in mcs folder.
1899 * *.cs: Use existing 2_1 define for smcs.
1901 2007-10-26 Marek Safar <marek.safar@gmail.com>
1903 A fix for bug #335847
1904 * assign.cs, expression.cs: Couple of changes to avoid creating a
1905 temporary variable for each object initializer assignment statement. It
1906 simplifies struct initialization too, otherwise two temporary variables
1908 Implemented optimization of redundant default element initializers.
1910 2007-10-25 Marek Safar <marek.safar@gmail.com>
1912 A fix for bug #336766
1913 * expression.cs (Class.CheckBase): Use generic name when method is
1916 2007-10-25 Marek Safar <marek.safar@gmail.com>
1918 A fix for bug #334737
1919 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
1920 variable and not variable argument for prepared copies.
1922 2007-10-24 Marek Safar <marek.safar@gmail.com>
1924 A fix for bug #325110
1925 * class.cs, expression.cs, attribute.cs: Use open generic method when
1926 checking conditional attribute.
1928 2007-10-24 Marek Safar <marek.safar@gmail.com>
1930 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
1931 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
1932 FeatureIsNotAvailable.
1934 2007-10-24 Marek Safar <marek.safar@gmail.com>
1936 ** C# 3.0 Partial methods
1938 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
1939 methods support. Because of member cache issue with generics only
1940 non-generics partial methods are fully supported.
1942 2007-10-23 Marek Safar <marek.safar@gmail.com>
1944 * class.cs, decl.cs: Rewrote member overloads check to cope with
1945 generics and to use member cache for member checking. It also improves
1946 performance and fixes remaining overloads issues.
1948 2007-10-20 Marek Safar <marek.safar@gmail.com>
1950 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
1951 roottypes.cs, typemanager.cs:
1953 A member cache creation logic changed to add members immediately and
1954 not rely on fallback. The member cache is now only prefered way
1955 how to access and find type declaration members. It saves 5 MB of memory
1956 during MWF compilation and makes code ready for more optimizations and
1957 clean-ups, it's also a pre-requirement for partial methods.
1959 2007-10-18 Raja R Harinath <harinath@gmail.com>
1961 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
1962 handling for generic parameters.
1964 2007-10-15 Marek Safar <marek.safar@gmail.com>
1966 * class.cs (FixedField): Removed redundant volatile check.
1968 2007-10-15 Marek Safar <marek.safar@gmail.com>
1970 * class.cs, decl.cs: Fixed overload members verification to do only one
1971 check per possible collision.
1973 2007-10-13 Marek Safar <marek.safar@gmail.com>
1975 A fix for bug #325478
1976 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
1977 and create only one disposable flags container.
1979 2007-10-12 Marek Safar <marek.safar@gmail.com>
1981 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
1982 * statement.cs (Fixed): Fixed variables cloning.
1984 2007-10-12 Marek Safar <marek.safar@gmail.com>
1986 A fix for bug #333342
1987 * class.cs (EventField): Don't mark value type event as synchronized.
1989 2007-10-12 Marek Safar <marek.safar@gmail.com>
1991 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
1992 inference to identify best candidate method correctly.
1993 (ProperyExpr): A range variable is read only and cannot be modified.
1995 2007-10-11 Marek Safar <marek.safar@gmail.com>
1997 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
1998 logic to identify best candidate method correctly.
2000 2007-10-11 Marek Safar <marek.safar@gmail.com>
2002 * location.cs (Equals, GetHashCode): Removed.
2004 2007-10-11 Marek Safar <marek.safar@gmail.com>
2006 * report.cs: Implemented message recorder. It is used mainly for lambda
2007 expressions to capture otherwise swallowed error messages.
2009 * anonymous.cs, lambda.cs.cs: Do full parameters check.
2011 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
2013 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
2015 * expression.cs (MemberAccess): Always report lookup failure.
2017 * location.cs: Implemented Equals, GetHashCode.
2019 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
2021 2007-10-10 Jb Evain <jbevain@novell.com>
2023 * codegen.cs: re-enable assembly version check.
2025 2007-10-09 Marek Safar <marek.safar@gmail.com>
2027 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
2030 * namespace.cs (UsingAlias): Do correct version check.
2032 2007-10-08 Marek Safar <marek.safar@gmail.com>
2034 * expresison.cs, ecore.cs: Issue extension method error message when
2037 * rootcontext.cs: Added ISO_2 compiler mode option.
2039 2007-10-08 Marek Safar <marek.safar@gmail.com>
2041 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
2044 2007-10-08 Marek Safar <marek.safar@gmail.com>
2046 * attribute.cs (GetString, GetBoolean): Work with both literal and
2049 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
2050 Moved method overload specific methods to MethodGroupExpr.
2052 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
2053 it should be less memory consuming.
2055 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
2057 * codegen.cs: remove the assembly version check until the buildbot is
2060 2007-10-07 Jb Evain <jbevain@novell.com>
2062 * attribute.cs (Attribute.GetString): if the value
2063 expression is a StringConstant, return its string value.
2065 2007-10-07 Jb Evain <jbevain@novell.com>
2067 * typemanager.cs: add `assembly_version_attribute_type`.
2068 * codegen.cs: on attribute emission, check that the
2069 AssemblyVersionAttribute doesn't overflow.
2071 2007-10-05 Marek Safar <marek.safar@gmail.com>
2073 A fix for bug #324677
2074 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
2075 parent container of a scope container with currently resolved one.
2077 2007-10-05 Marek Safar <marek.safar@gmail.com>
2079 A fix for bug #325534
2080 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
2083 2007-10-05 Marek Safar <marek.safar@gmail.com>
2085 A fix for bug #327504
2086 * class.cs (Operator.Define): Refactored implicit and explicit user
2087 operator conversion rules.
2089 2007-10-05 Marek Safar <marek.safar@gmail.com>
2091 A fix for bug #327520
2092 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
2094 2007-10-04 Marek Safar <marek.safar@gmail.com>
2096 A fix for bug #328022
2097 * class.cs (MethodData.Define): Use correct method to check whether
2098 a method implementents an accessor.
2100 2007-10-04 Marek Safar <marek.safar@gmail.com>
2102 A fix for bug #330069
2103 * statement.cs (Fixed.Resolve): Read the first array element only when
2104 an array is instantiated.
2106 2007-10-04 Marek Safar <marek.safar@gmail.com>
2108 * expression.cs, assign.cs, generics.cs: Print correct operator when
2109 compound assignment is used.
2111 2007-10-04 Marek Safar <marek.safar@gmail.com>
2113 A fix for bug #325841
2114 * expression.cs (ArrayAccess): Use full argument cloning only for
2115 string compound concatenation.
2117 2007-10-03 Marek Safar <marek.safar@gmail.com>
2119 A fix for bug #328774
2120 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
2122 (PropertyExpr.EmitAssign): Fixed string concatenation compound
2125 2007-10-03 Raja R Harinath <rharinath@novell.com>
2128 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
2129 Event accessibility checks here. Remove some bogus code that
2130 accidently made GenericMethods work.
2131 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
2133 2007-09-25 Marek Safar <marek.safar@gmail.com>
2135 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
2137 * statement.cs (Block): Refactored AddVariable to allow error handling
2140 * generic.cs: New stub.
2142 2007-09-23 Marek Safar <marek.safar@gmail.com>
2144 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
2147 2007-09-17 Marek Safar <marek.safar@gmail.com>
2149 * class.cs: Use partial container to record whether any partial part
2150 contains static field initializer and therefore default contructor has
2153 2007-09-14 Marek Safar <marek.safar@gmail.com>
2155 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
2156 mono-list when only one of two partial parts has defined accessibility
2159 2007-09-14 Marek Safar <marek.safar@gmail.com>
2161 A fix for bug #82845
2163 * class.cs (TypeContainer): Set correct resolve context for all field
2166 2007-09-13 Marek Safar <marek.safar@gmail.com>
2168 * assign.cs: Fixed a crash when field is resolved twice with an error.
2170 * codegen.cs: Changed InFieldInitializer to be flag.
2172 * anonymous.cs, ecore.cs, expression.cs: Update after
2173 IsInFieldInitializer rename.
2175 * const.cs: Removed unused parameter.
2177 * class.cs: Changed the way how we resolve and emit field initializers.
2178 The field initilizers have to have access to contructor block to emit
2179 compiler generated code.
2181 2007-09-13 Marek Safar <marek.safar@gmail.com>
2183 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
2184 generics use TypeContainer instead.
2186 2007-09-12 Marek Safar <marek.safar@gmail.com>
2188 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
2190 * lambda.cs (ResolveParameters): Use more powerful
2191 InflateGenericArgument.
2193 * parameters.cs: Better exception message.
2195 2007-09-10 Marek Safar <marek.safar@gmail.com>
2197 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
2198 correct expression block type.
2200 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
2202 * expression.cs (Invocation): Extracted method group resolve to
2205 2007-09-07 Marek Safar <marek.safar@gmail.com>
2207 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
2208 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
2210 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
2211 generic extension methods.
2213 2007-09-06 Marek Safar <marek.safar@gmail.com>
2215 A fix for bug #82676 (Do I get it right now?)
2216 * convert.cs (Binary.ResolveOperator): An interface is converted to the
2217 object before a standard conversion is applied.
2219 2007-09-06 Marek Safar <marek.safar@gmail.com>
2221 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
2224 2007-09-05 Marek Safar <marek.safar@gmail.com>
2226 A fix for bug #82676
2227 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
2228 non-generic interface types.
2230 2007-09-05 Marek Safar <marek.safar@gmail.com>
2232 A fix for bug #82690
2233 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
2235 2007-09-05 Marek Safar <marek.safar@gmail.com>
2237 A fix for bug #82571
2238 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
2239 modifier for container based methods.
2241 2007-09-05 Marek Safar <marek.safar@gmail.com>
2243 A fix for bug #82676
2244 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
2245 any interface-type T means to any of interface type T.
2247 2007-09-04 Marek Safar <marek.safar@gmail.com>
2249 * namespace.cs: We have 2 versions of System.Core assembly.
2251 2007-09-04 Marek Safar <marek.safar@gmail.com>
2253 A fix for bug #82652
2254 * class.cs (Class.GetClassBases): Compare types and not expressions.
2256 2007-09-04 Marek Safar <marek.safar@gmail.com>
2258 A fix for bug #82620
2259 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
2260 actually never worked before.
2261 (IndexerAccess): Emit prepared arguments before they are modified.
2263 2007-09-04 Marek Safar <marek.safar@gmail.com>
2265 A fix for bug #82563
2266 * assign.cs: Revert wrong fix.
2268 * expression.cs (VariableReference.EmitAssign): Handle ref reference
2270 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
2271 Instead of ldelema/stdind we have to use temporary variables to handle
2272 cases like String.Concat (params string[]).
2274 2007-08-31 Marek Safar <marek.safar@gmail.com>
2276 * class.cs: EmitAttributes to Emit rename.
2278 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
2280 (MemberCore.HasClsCompliantAttribute): Don't depend on
2281 GetClsCompliantAttributeValue execution.
2283 2007-08-31 Marek Safar <marek.safar@gmail.com>
2285 * anonymous.cs: Use shorter type prefix.
2287 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
2290 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
2291 variables when probing is on.
2293 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
2294 unresolved variables.
2295 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
2296 handle transparent identifiers.
2298 2007-08-26 Marek Safar <marek.safar@gmail.com>
2300 * attribute.cs (IsClsCompliant): Add nullable types test.
2302 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
2304 * doc.cs : catch other types of exception than XmlException to
2305 report CS1570. Fixed bug #82565.
2307 2007-08-23 Marek Safar <marek.safar@gmail.com>
2309 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
2310 The number of delegate parameters has to match.
2311 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
2314 2007-08-21 Marek Safar <marek.safar@gmail.com>
2316 * anonymous.cs (AnonymousMethod): Generate private anonymous method
2317 to fix problem with private arguments.
2319 2007-08-20 Marek Safar <marek.safar@gmail.com>
2321 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
2323 * decl.cs (MemberName): Ignore generic type with no generic arguments.
2325 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
2326 empty. Add cloning suport.
2328 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
2330 2007-08-20 Marek Safar <marek.safar@gmail.com>
2332 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
2333 to create EmptyCast. It handles EmptyConstantCast specialization for
2336 2007-08-18 Marek Safar <marek.safar@gmail.com>
2338 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
2339 (EmitArrayArgument): One routine for array arguments.
2340 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
2342 2007-08-17 Marek Safar <marek.safar@gmail.com>
2344 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
2346 2007-08-17 Marek Safar <marek.safar@gmail.com>
2348 * anonymous.cs: MemberLookupFinal update.
2350 * class.cs (ConstructorInitializer): Is expression based.
2352 * delegate.cs: MethodGroupExpr update.
2354 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
2356 (Error_MemberLookupFailed): Customizable error override.
2357 (MethodGroupExpr): Keep queried type for later usage.
2358 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
2361 * expression.cs: Error_MemberLookupFailed refactoring.
2362 (New.DoResolve): Resolve as much as possible.
2363 (ElementInitializer.Error_MemberLookupFailed): Object initializer
2364 customization for invalid member types.
2366 * statement.cs: MethodGroupExpr update.
2368 2007-08-16 Marek Safar <marek.safar@gmail.com>
2370 * modifier.cs (Check): Check all modifiers and not only accessibility
2373 2007-08-16 Marek Safar <marek.safar@gmail.com>
2375 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
2376 type and not an expression.
2378 2007-08-16 Marek Safar <marek.safar@gmail.com>
2380 * statement.cs (Catch.Clone): Type and variable can be null.
2382 2007-08-16 Marek Safar <marek.safar@gmail.com>
2384 A fix for bug #81979
2385 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
2386 I am really not sure whether this is the best fix.
2388 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
2391 2007-08-14 Marek Safar <marek.safar@gmail.com>
2393 ** C# 3.0 Object and collection initializers (major re-write)
2395 * assign.cs (DoResolve): Initializers are not assign related.
2397 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
2398 used during collection or object initialization.
2400 * expression.cs (Error_InvalidArguments): Add initializers specific
2401 messages. More will come later because it requires some general
2403 (New.DoResolve): Better error handling for unsafe types.
2404 (EmptyExpressionStatement): New class.
2405 (ElementInitializer): An object initializer expression.
2406 (CollectionElementInitializer): A collection initializer expression.
2407 (CollectionOrObjectInitializers): A block of object or collection
2409 (NewInitialize): New expression with element/object initializers.
2411 * statement.cs: Reverted object/collection initializer hacks.
2413 * typemanager.cs (CSharpName): Filter __arglist type.
2415 2007-08-09 Marek Safar <marek.safar@gmail.com>
2417 ** C# 3.0 Anonymous Types (update to the latest standard)
2419 * expression.cs (Binary.ResolveOperator): Threat all null based types
2421 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
2422 (AnonymousTypeParameter): Updated.
2424 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
2425 (AnonymousTypeClass): New anonymous type container.
2427 * class.cs (AddField): Return operation result.
2429 * generic.cs: Another empty TypeArguments overload.
2431 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
2432 are stored at top of normal hierarchy.
2434 * typemanager.cs (CSharpName): Filter anonymous types.
2436 2007-08-09 Marek Safar <marek.safar@gmail.com>
2438 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
2439 as single Concat call. How could we miss that :-(
2441 2007-08-08 Marek Safar <marek.safar@gmail.com>
2443 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
2445 2007-08-07 Miguel de Icaza <miguel@novell.com>
2447 * expression.cs: Fix the previous commit, the creation of the
2448 arguments array list needs also to be conditional on the arguments
2451 * class.cs: Add a little bit of help to help narrow down problems.
2453 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
2454 not try to copy in that case.
2456 * driver.cs: When building SMCS, include a new different set of
2457 default assemblies here. Do this here so we can control whether
2458 to include the default assemblies with /noconfig.
2460 2007-08-03 Marek Safar <marek.safar@gmail.com>
2462 A fix for bug #81979
2463 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
2466 2007-08-03 Marek Safar <marek.safar@gmail.com>
2468 A fix for bug #82300
2470 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
2471 we are in probing scope.
2473 2007-08-03 Marek Safar <marek.safar@gmail.com>
2475 A fix for bug #82301
2477 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
2478 (Statement.CloneTo): Clone and not map children blocks.
2480 2007-08-03 Marek Safar <marek.safar@gmail.com>
2482 A fix for bug #82299
2484 * expression.cs (LocalVariableReference.CloneTo): Remap local info
2487 * statement.cs (Statement.CloneTo): Clone variables before statements
2488 to allow remaping of local variables.
2490 2007-08-03 Marek Safar <marek.safar@gmail.com>
2492 A fix for bug #82296
2495 * report.cs: Log crash details for future clone problems.
2497 * statement.cs (Return.Clone): Don't clone non-existent expression.
2499 2007-08-03 Raja R Harinath <harinath@gmail.com>
2501 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
2502 (Class.AddBasesForPart): Move CS0537 check here from ...
2503 * cs-parser.jay (class_declaration): ... here. Move calling of
2504 'AddBasesForPart' to ...
2505 (class_bases): ... here.
2506 (struct_declaration, interface_declaration): Update to changes.
2508 2007-08-02 Marek Safar <marek.safar@gmail.com>
2510 A fix for bug #81923
2512 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
2513 conversion is allowed.
2515 2007-08-02 Marek Safar <marek.safar@gmail.com>
2517 A fix for bug #81564
2519 * ecore.cs (EventExpr): Add IsBase handling.
2521 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
2524 2007-08-02 Raja R Harinath <harinath@gmail.com>
2526 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
2527 * cs-parser.jay: Some whitespace cleanups.
2528 (current_delegate): New.
2530 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
2531 a dummy code block, and use 'type_name' instead of 'member_name'.
2532 (interface_declaration, class_declaration): Likewise.
2533 (delegate_declaration): Likewise. Rearrange slightly and use
2535 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
2536 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
2538 2007-08-02 Marek Safar <marek.safar@gmail.com>
2540 A fix for bug #82039
2542 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
2545 * typemanager.cs (CSharpName): Split to string overload.
2547 2007-08-02 Marek Safar <marek.safar@gmail.com>
2550 * report.cs: Updated warning CS0472.
2552 2007-08-01 Marek Safar <marek.safar@gmail.com>
2554 A fix for bug #82181
2556 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
2558 2007-08-01 Marek Safar <marek.safar@gmail.com>
2560 A fix for bug #82277
2561 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
2563 2007-08-01 Marek Safar <marek.safar@gmail.com>
2565 ** C# 3.0 Type Inference (major bits are working)
2567 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
2568 (.ImplicitStandardConversionExists): Uses compatible.
2569 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
2570 (.InferReturnType): New method.
2571 (.Compatible): Refactored.
2572 (.ResolveParameters): Uses factory to create resolved parameters.
2573 (.CompatibleMethod): Add probing mode support.
2574 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
2575 clearly distinguish between 2 different operations.
2576 (LambdaMethod): Moved to lambda.cs.
2577 (AnonymousMethod): Removed unused fields and methods.
2578 (AnonymousDelegate): Simplified.
2580 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
2582 * convert. cs (ImplicitConversionStandard): Compatible works differently.
2584 * delegate.cs (Delegate): New mehods to reduce code duplication.
2585 (.GetConstructor): New method.
2586 (.GetInvokeMethod): New method.
2587 (DelegateCreation): Updated.
2589 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
2591 (OverloadResolve): Made probing little bit faster.
2593 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
2596 * generic.cs (TypeInferenceContext): Dummy implementation.
2598 * iterators.cs: Updated after Resolve/Define rename.
2600 * lambda.cs (LambdaExpression)
2601 (.ResolveParameters): Handles both type of arguments and type inference too.
2603 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
2604 (InflateTypes): Updated.
2606 * support.cs (InflateTypes): Changed signature and updated.
2608 * typemanager.cs (LookupMemberCache): Better dynamic type check.
2609 (MemberLookup_FindMembers): More MS tricks.
2610 (GetParameterData): Ditto.
2611 (GetDelegateParameters): Uses quick path for dynamic types.
2613 2007-08-01 Marek Safar <marek.safar@gmail.com>
2615 * class.cs (MethodData.Define): EmitContext is required for generic stuff
2618 2007-07-31 Marek Safar <marek.safar@gmail.com>
2620 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
2623 2007-07-26 Jb Evain <jbevain@novell.com>
2625 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
2626 which takes a boolean 'report_errors', similar to the GetMethod.
2627 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
2628 in .net 2.1, do not report errors here.
2630 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
2631 System.Runtime.CompilerServices.RequiredAttributeAttribute and
2632 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
2635 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
2636 of the type InternalsVisibleToAttribute before the first call
2637 to CoreLookupType which is allowed to fail (third boolean parameter
2638 to true). Because, during the resolution for a type that is not
2639 immediately found, we try to check if the type is not defined in
2640 a friend assembly, and to do so, we need the
2641 InternalVisibleToAttribute.
2643 2007-07-23 Miguel de Icaza <miguel@novell.com>
2645 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
2646 feature that allows structs to be compared against null and inline
2647 the result as true or false.
2649 Notice that the same code is not permitted inside a generic block
2650 of code that would do:
2652 class Foo<T> where T : struct {
2659 It is only allowed if the type of T is not bound (no where
2660 clause). In my opinion, this CSC 2 behavior is broken but people
2661 seem to be using it (IronRuby does, a few bug reports on bugzilla
2662 have it and some people have complained about it).
2664 All of the users that depend on this behavior have code that is
2667 * report.cs (Warning, Error): make these take object arguments,
2668 not strings, as that allows us to take advantage of Format.
2670 2007-07-20 William Holmes <billholmes54@gmail.com>
2672 * decl.cs: Changed MemberName.CountTypeArguments to also check the
2673 Left member variable for the Count.
2674 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
2675 MemberName.CountTypeArguments to avoid a NRE.
2677 This code is contributed under the MIT X11 license
2679 2007-07-18 Marek Safar <marek.safar@gmail.com>
2681 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
2683 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2685 * doc.cs : generic method arguments are written as ``x while generic
2686 type arguments are `x. Combined with the previous change, fixed bug
2689 2007-07-18 Raja R Harinath <rharinath@novell.com>
2692 * expression.cs (Binary.ResolveOperator): When converting
2693 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
2695 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2697 * doc.cs : when T: or whatever x: is specified, it does not really
2698 check the doc comment's syntax correctness. Fixed bug #82006.
2700 2007-07-18 Marek Safar <marek.safar@gmail.com>
2702 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
2703 LambdaExpression better.
2705 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
2707 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
2709 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
2710 as it can be generated.
2712 * expression.cs (Invocation.Error_InvalidArguments): Show correct
2715 * lambda.cs (LambdaExpression): Refactored to share same code with
2716 AnonymousMethodExpression.
2718 2007-07-17 Marek Safar <marek.safar@gmail.com>
2720 * anonymous.cs (MakeName): Include host name for easier debugging.
2721 (LambdaMethod): New class for lambda spcecific stuff.
2723 * attribute.cs: Set EmitContext return type.
2725 * class.cs: Set EmitContext return type.
2727 * codegen.cs (EmitContext): Return type cannot be null to stop messing
2728 with null/void meaning.
2730 * iterators.cs (ContainerType): Implemented.
2732 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
2734 * statement.cs (Return): Updated to lambda expressions.
2735 (Block.CloneTo): Parent can be null.
2737 2007-07-13 Marek Safar <marek.safar@gmail.com>
2739 A fix for bug #81917
2740 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
2742 * class.cs (FixedField): Check whether field is in unsafe scope.
2744 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
2745 (FieldExpr.Emit): Fixed buffers cannot be volatile.
2747 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
2750 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
2752 2007-07-13 Marek Safar <marek.safar@gmail.com>
2754 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
2755 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
2758 2007-07-13 Marek Safar <marek.safar@gmail.com>
2760 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
2762 2007-07-13 Marek Safar <marek.safar@gmail.com>
2764 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
2765 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
2767 * codegen.cs(EmitContext): Add ProbingMode flag.
2769 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
2771 * driver.cs: For now set both warning values.
2773 * ecore.cs (SimpleName): Name is readonly.
2774 (MethodGroup.OverloadResolve): One quick path for probing.
2776 * expression.cs (Unary): Set Oper r/o.
2777 (Binary): Set Oper r/o.
2778 (ParameterReference): Set few instance variables as r/o.
2779 (ParameterReference.DoResolveBase): Don't capture aruments when
2781 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
2782 (Arglist): arguments are private.
2783 (SizeOf): type is private and r/o.
2784 (MemberAccess): arguments are private.
2786 * report.cs: Enhanced reporting on/off capabilities.
2788 * lambda.cs: Uses ec.IsInProbingMode.
2789 (ContextualReturn): Derives from return.
2791 * rootcontext.cs: For now set both warning values.
2793 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
2795 (Return.Resolve): Don't die immediately.
2796 (Block.Resolve): Speed-up probing.
2797 (Block.CloneTo): Clone only child blocks.
2799 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
2801 * iterators.cs: reverted Miguel's latest change (r81925) as it
2802 breaks the build in System.
2804 2007-07-13 Miguel de Icaza <miguel@novell.com>
2806 * iterators.cs (Yield.CheckContext): Check for the iterator type
2807 also here as we can call into Yield even in codepaths that are not
2809 (MethodOrOperator is the only path that was checked).
2811 In addition to the standard check, use a more specific check for
2812 constructors to report a more verbose error.
2814 2007-07-12 Miguel de Icaza <miguel@novell.com>
2816 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
2817 report the warning and continue
2819 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
2820 values on the stack on the call to Emit. Use EmitStatement if
2821 possible, or using Emit + Pop if not possible. Fixes #82064
2823 2007-07-12 Raja R Harinath <rharinath@novell.com>
2825 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
2826 avoid try...finally in some cases.
2828 2007-07-10 Marek Safar <marek.safar@gmail.com>
2830 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
2832 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
2833 instead of method. Re-use standard error handling.
2834 (ConstructorInitializer.Emit): Simplified.
2836 * delegate.cs: Updated after Invocation.EmitCall change.
2838 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
2839 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
2840 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
2841 method and don't permanently changing input arguments.
2842 (MethodGroupExpr): Introduced resolved best_candidate, when method group
2843 is resolved it has one of the candidates is the best one which is later
2844 used to emit. Removed a few unused method.
2845 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
2847 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
2848 (Binary.ResolveOperator): Ditto.
2849 (ConditionalLogicalOperator.DoResolve): Ditto.
2850 (Invocation): Uses method group.
2851 (Invocation.DoResolve): Simplified.
2852 (Invocation.EmitCall): Removed useless is_static.
2853 (Invocation.Emit): Delegate to method group.
2854 (Invocation.EmitStatement): Simplified.
2855 (New): Uses method group.
2856 (MemberAccess.DoResolve): Don't destroy original expression.
2858 * statement.cs (ForEach.Resolve): Use null for no method arguments.
2860 2007-07-04 Marek Safar <marek.safar@gmail.com>
2862 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
2865 * lambda.cs: Add custom error message type.
2867 2007-07-03 Marek Safar <marek.safar@gmail.com>
2869 * lambda.cs: Simplified little bit.
2871 * parameter.cs: Introduced ImplicitLambdaParameter.
2872 (Parameters.CreateFullyResolved): New factory instead of ctor.
2876 * delegate.cs: Updated parameter creation.
2878 2007-07-03 Marek Safar <marek.safar@gmail.com>
2880 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
2883 * generic.cs: Synchronized with gmcs.
2885 2007-07-03 Marek Safar <marek.safar@gmail.com>
2887 * class.cs (Indexer): Check return type as soon as possible.
2889 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
2892 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
2894 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
2896 * parameter.cs (Parameter): Use expression type when it is available.
2898 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
2899 method modifier for the first parameter only.
2901 2007-06-24 Marek Safar <marek.safar@gmail.com>
2903 A fix for bug #81938
2904 * typemanager.cs (ChangeType): Fixed couple of char conversions.
2906 * constant.cs: Tide up an exception message.
2908 2007-06-22 Marek Safar <marek.safar@gmail.com>
2910 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
2911 an uninitialized variable is used.
2913 * expression.cs (LocalVariableReference.DoResolve): Ditto.
2915 2007-06-22 Marek Safar <marek.safar@gmail.com>
2917 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
2918 not found error handling.
2920 * expression.cs (ArrayCreation): Removed redundant fields and little bit
2922 (ArrayCreation.ResolveArrayElement): To be ready to customization.
2923 (ArrayCreation.DoResolve): Simplified.
2924 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
2925 its own resolve process.
2926 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
2928 2007-06-20 Marek Safar <marek.safar@gmail.com>
2930 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
2933 2007-06-20 Marek Safar <marek.safar@gmail.com>
2935 * cs-tokenizer.cs: Removed var related stuff.
2937 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
2938 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
2939 a type and a keyword at same time.
2941 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
2944 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
2945 implicitly typed arrays, more changes will follow.
2947 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
2949 2007-06-19 Marek Safar <marek.safar@gmail.com>
2951 * ecore.cs (VarExpr): Removed Handled field.
2953 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
2954 build-in assign functionality.
2955 (ForEach.Resolve): Removed all implicitly typed local variable code and
2957 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
2958 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
2960 2007-06-18 Marek Safar <marek.safar@gmail.com>
2962 * assign.cs: Removed implicitly typed local variable check.
2964 * expression.cs (LocalVariableReference.DoResolve): Add check for self
2965 referencing implicitly typed local variable.
2966 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
2969 * statement.cs (Fixed): Removed unsupported implicitly typed local
2972 2007-06-15 Marek Safar <marek.safar@gmail.com>
2974 * decl.cs (MemberName): Moved all Unbound stuff to parser.
2976 2007-06-14 Marek Safar <marek.safar@gmail.com>
2978 A fix for bugs #81855 and #76274
2979 * attribute.cs (AttachTo): Always set owner for global attributes to
2982 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
2985 * cs-parser.jay: Assembly and module attributes must precede all other
2986 elements except using clauses and extern alias declarations.
2988 2007-06-13 Marek Safar <marek.safar@gmail.com>
2990 A fix for bug #81748
2992 * expression.cs: More checks for non ISO-1 features.
2994 2007-06-12 Marek Safar <marek.safar@gmail.com>
2996 A fix for bug #81807
2997 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
2998 present inside switch statement and it is required by nullable check.
3000 2007-06-12 Marek Safar <marek.safar@gmail.com>
3002 A fix for bug #81840
3003 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
3004 when type matching fails.
3006 * namespace.cs: Tiny error message change.
3008 2007-06-12 Marek Safar <marek.safar@gmail.com>
3010 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
3011 reporting. Added automatic property check.
3013 * class.cs: Updated after CheckAbstractAndExtern relocation.
3014 (AEventPropertyAccessor.GetSignatureForError): Customized.
3016 2007-06-11 Marek Safar <marek.safar@gmail.com>
3018 * class.cs (DefineBaseTypes): Base type can be undefined.
3020 * ecore.cs (TypeLookup): Minor refactoring.
3021 (DoResolveAsTypeStep): Removed redundant check.
3023 * namespace.cs (Lookup): Removed redundant check.
3025 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
3026 ResolveAsTypeTerminal step.
3027 (BootstrapCorlib_*): Simplified.
3028 (PopulateCoreType): Core types can be now external.
3030 2007-06-07 Marek Safar <marek.safar@gmail.com>
3032 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
3034 (InferTypeArguments): Infers anonymous expression type arguments.
3035 (Compatible): Split to Compatible and InferTypeArguments.
3037 * lambda.cs: Updated.
3039 2007-06-08 Marek Safar <marek.safar@gmail.com>
3041 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
3043 2007-06-07 Raja R Harinath <harinath@gmail.com>
3045 Fix #80477, cs0135-2.cs, cs0135-3.cs
3046 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
3047 names to the "known" variables list.
3048 (Block.CheckInvariantMeaningInBlock): Handle the fact the
3049 parameter names are also "known".
3050 (Block.CheckError136): Remove.
3051 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
3054 2007-06-07 Marek Safar <marek.safar@gmail.com>
3056 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
3058 2007-06-06 Marek Safar <marek.safar@gmail.com>
3060 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
3061 internal error not an user error.
3063 * expression.cs (IsApplicable): Refactored to make debugging easier.
3065 * support.cs: More tricks for non-mono runtimes.
3067 * typemanager.cs (CoreLookupType): Made public.
3068 (InitSystemCore): All linq specific stuff moved to linq.cs
3070 2007-06-05 Marek Safar <marek.safar@gmail.com>
3072 * typemanager.cs (CSharpSignature): One more missing build-in types
3074 More tricks for non-mono runtime.
3076 2007-06-05 Raja R Harinath <harinath@gmail.com>
3078 * statement.cs (Block.CheckError136_InParents): Remove.
3079 (Block.AddVariable): Use GetParameterInfo instead.
3080 (ToplevelBlock.ProcessArguments): Likewise.
3082 2007-06-04 Raja R Harinath <rharinath@novell.com>
3084 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
3086 (ToplevelBlock.GetParameterInfo): Split out of ...
3087 (ToplevelBlock.GetParameterRefernce): ... this.
3088 (ToplevelBlock.ParameterMap): Remove.
3089 * expression.cs (ParameterReference): Update to use
3090 ToplevelParameterInfo.
3092 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
3095 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
3096 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
3098 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
3099 (ToplevelBlock.ProcessParameters) ... here.
3100 (ToplevelBlock..ctor): Invoke it.
3102 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
3105 * statement.cs (IKnownVariable): New interface.
3106 (LocalInfo): Implement it.
3107 (ToplevelParameterInfo): New class.
3108 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
3109 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
3110 GetKnownVariableInfo.
3112 2007-06-03 Raja R Harinath <harinath@gmail.com>
3114 Partly speed up CS0136 error checks.
3115 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
3116 'recurse' parameter.
3117 (Block.DoCheckError136): Only check errors in parameters. Move
3118 local variable checks ...
3119 (Block.AddVariable): ... here, and ...
3120 (ToplevelBlock.ResolveMeta): ... here.
3122 2007-06-02 Raja R Harinath <harinath@gmail.com>
3124 * statement.cs (Block.IsChildOf): Remove.
3126 * statement.cs (Statement.Clone): Move special case code ...
3127 (Block.CloneTo): ... here.
3129 2007-05-29 Raja R Harinath <rharinath@novell.com>
3131 * statement.cs (ToplevelBlock.container): Remove field. It's
3132 redundant with 'Parent'.
3133 (ToplevelBlock.ContainerBlock): Remove accessor.
3134 (ToplevelBlock..ctor): Update to changes. Register anonymous
3135 child with parent here, ...
3136 * cs-parser.jay (end_anonymous): ... not here. Don't modify
3138 (start_anonymous): Don't save current_block.
3139 (top_current_block): Remove.
3141 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
3142 (Block.Resolve): Update to changes.
3143 (Block..ctor): Move setting of "correct" 'Toplevel'
3144 and 'Explicit' fields to ...
3145 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
3147 2007-05-27 Raja R Harinath <harinath@gmail.com>
3150 * statement.cs (Block.Implicit): Remove.
3151 (Block): Update to changes.
3152 * flowanalysis.cs: Likewise.
3154 Mildly speed up CheckInvariantMeaningInBlock
3155 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
3156 Recursively call AddKnownVariable to all enclosing blocks.
3157 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
3158 Remove recursive calls.
3159 (Block): Update to changes.
3161 New ExplicitBlock invariants
3162 * statement.cs (Block.Explicit): New field. It points to the
3163 immediately enclosing non-implicit block.
3164 (Block..ctor): Maintain the invariant.
3165 * cs-parser.jay: Take advantage of invariant.
3167 Introduce ExplicitBlock
3168 * statement.cs (ExplicitBlock): New.
3169 (ToplevelBlock): Derive from it.
3170 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
3172 (Block.Implicit): Update to changes.
3173 * cs-parser.jay: Update to changes.
3176 * codegen.cs (EmitContext.IsLastStatement): Remove.
3177 * statement.cs (Block.DoEmit): Update to changes.
3179 2007-05-25 Raja R Harinath <rharinath@novell.com>
3181 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
3182 modifying current_block directly.
3184 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
3186 * class.cs: Implemented automatic properties (C# 3.0)
3187 Thanks to Marek for the help.
3189 2007-05-23 Raja R Harinath <rharinath@novell.com>
3191 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
3192 variable as assigned, note also that all its components are
3194 (MyBitVector.SetRange): New. Function to set multiple bits to true.
3196 2007-05-19 Marek Safar <marek.safar@gmail.com>
3198 * anonymous.cs, class.cs: Emit Compiler generated attribute when
3199 member is marked as compiler generated.
3201 * decl.cs (MemberCore): Refactored ModFlags into property.
3203 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
3204 (Check): Check only accessibility modifiers.
3206 2007-05-18 Raja R Harinath <rharinath@novell.com>
3208 Track all assignable slots in one bit array
3209 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
3210 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
3211 logic from VariableMap constructor here. Use the same 'offset'
3212 variable that's later used for computing offsets of local
3214 * flowanalysis.cs (UsageVector.parameters): Remove.
3215 (UsageVector): Update to changes.
3216 (VariableMap): Remove.
3218 Avoid creating ParameterMap in every block
3219 * statement.cs (Block.ParameterMap): Move ...
3220 (ToplevelBlock.ParameterMap): ... here.
3221 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
3223 * flowanalysis.cs (FlowBranching.param_map): Remove.
3224 (FlowBranching.UsageVector): Update to changes.
3225 (FlowBranchingToplevel.CheckOutParameters): Likewise.
3227 * statement.cs (Block.CloneTo): Clone Toplevel field too.
3229 * expression.cs (ParameterReference): Distinguish between block
3230 where parameter was referenced and declared.
3232 2007-05-18 Marek Safar <marek.safar@gmail.com>
3234 * flowanalysis.cs, statement.cs: Put back improved error handling.
3236 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
3240 Imporved object and collection initialization (C# 3.0).
3242 2007-05-15 Marek Safar <marek.safar@gmail.com>
3244 A fix for bug #81380
3245 * expression.cs (Is.DoResolve): Only value types have constant `is'
3248 2007-05-15 Raja R Harinath <rharinath@novell.com>
3250 * statement.cs (ToplevelBlock.child): Remove.
3252 2007-05-15 Raja R Harinath <harinath@gmail.com>
3254 Rationalize ResolveMeta: refactoring
3255 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
3256 out constant handling code into ...
3257 (Block.DoResolveConstants): ... this.
3259 Rationalize ResolveMeta: kill local_map
3260 * statement.cs (Block.local_map, Block.LocalMap): Remove.
3261 (Block.AssignableSlots): New.
3262 (Block.ResolveMeta): Make protected. Don't create a VariableMap
3263 for locals -- move code from VariableMap here. Avoid unnecessary
3265 * flowanalysis.cs (FlowBranching.local_map): Remove.
3266 (FlowBranching..ctor): Use Block.AssignableSlots.
3267 (VariableMap): Remove unused constructors.
3269 2007-05-11 Raja R Harinath <rharinath@novell.com>
3271 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
3273 2007-05-11 Marek Safar <marek.safar@gmail.com>
3275 * typemanager.cs (IsFriendAssembly): Should not be called for building
3278 2007-05-09 Marek Safar <marek.safar@gmail.com>
3280 * literal.cs (NullConstant): Print null in all cases.
3282 * expression.cs (Binary.ResolveOperator): Implemented delegate
3283 comparison based on C# 2.0 changes.
3285 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
3287 This code is contributed under the MIT X11 license
3289 The following enables support for several C# 3.0 language features:
3291 * cs-tokenizer.cs: Added support for the "var" keyword.
3293 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
3294 Added VarExpr class to facilitate type inferencing.
3296 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
3297 to support anonymous types.
3299 * assign.cs: Added support for type inferencing and initialization.
3301 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
3303 * expression.cs: Added implicit array support to ArrayCreation.
3304 Added 5 types and 1 interface:
3306 IInitializable Implementing classes can inject initializing
3307 statements after object instantiation.
3309 Initializer Stores data for object initialization.
3311 AnonymousType An expression for anonymous types.
3313 AnonymousTypeParameter Stores data about an anonymous type's field.
3315 NewInitialize An expression for object initialization.
3317 CollectionInitialize An expression for collection initialization.
3319 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
3322 2007-05-06 Marek Safar <marek.safar@gmail.com>
3324 A fix for bug #81500
3325 * cs-tokenizer.cs: Add special handling for coalescing operator.
3327 2007-05-06 Marek Safar <marek.safar@gmail.com>
3329 A fix for bug #81529
3330 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
3331 its value from base class until it is redefined.
3333 2007-05-02 Raja R Harinath <rharinath@novell.com>
3335 Fix regression in cs0631-3.cs
3336 * cs-parser.jay (operator_declarator): Add opt_attributes to error
3337 fallback. Make error fallback catch more cases.
3339 2007-05-01 Miguel de Icaza <miguel@novell.com>
3341 * cs-parser.jay: Allow parameters in operator declarations to have
3344 2007-04-27 Miguel de Icaza <miguel@novell.com>
3346 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
3349 * lambda.cs (ContextualReturn.Resolve): An expression is valid
3350 inside the ContextualReturn, it does not have to be an
3351 ExpressionStatement.
3353 2007-04-24 Miguel de Icaza <miguel@novell.com>
3355 * lambda.cs (ContextualReturn.Resolve): if the return type is not
3358 2007-04-23 Miguel de Icaza <miguel@novell.com>
3360 * anonymous.cs (AnonymousContainer): split the virtual Resolve
3361 method in two methods: ResolveNoDefine and Resolve.
3363 ResolveNoDefine will stop just after ResolveTopBlock has been
3366 Resolve will then continue by creating a method and issuing the
3367 call to method.Define ().
3369 (AnonymousMethod): Split and implement the new Resolve and
3370 ResolveNoDefine as well.
3372 * lambda.cs (LambdaExpression): Split the anonymous method
3373 resolution code into a separate routine (CoreCompatibilityTest)
3374 from DoCompatibleTest.
3376 (LambdaExpression.TryBuild): New method, this method tries to
3377 build the LambdaExpression with the given set of types to be used
3378 as the types for the various parameters of the lambda expression.
3380 If the compilation succeed with the given types, the infered type
3381 of the Anonymous method is returned, otherwise null is returned.
3383 2007-04-23 Marek Safar <marek.safar@gmail.com>
3385 A fix for bug #81414
3386 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
3388 2007-04-22 Miguel de Icaza <miguel@novell.com>
3390 * cs-tokenizer.cs: Change various identifiers here from the
3391 camelCasing to the recommended Linux-like style for instance
3392 variables from the Coding Guidelines.
3394 2007-04-19 Martin Baulig <martin@ximian.com>
3397 (Convert.ImplicitReferenceConversionCore): Allow conversions from
3398 System.Enum to System.ValueType.
3400 2007-04-13 Martin Baulig <martin@ximian.com>
3402 Rewrote implicit reference conversions. We need to distinguish
3403 between implicit reference conversions (13.1.4) and implicit
3404 boxing conversions (13.1.5).
3406 According to the spec, there's an an implicit conversion
3407 "From a one-dimensional array-type S[] to IList<T> and base
3408 interfaces of this interface, provided there is an implicit
3409 reference conversion from S to T." Note that this does not
3410 include boxing conversions.
3413 (Convert.ImplicitTypeParameterBoxingConversion): New method.
3414 (Convert.ImplicitReferenceConversion): Split into
3415 ImplicitReferenceConversionCore() and
3416 ImplicitBoxingConversionExist().
3417 (Convert.ImplicitReferenceConversionExists): Use the new
3418 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
3420 2007-04-12 Martin Baulig <martin@ximian.com>
3422 * convert.cs (Convert.ImplicitReferenceConversion): Move the
3423 `TypeManager.null_type' checks up to the top of the method.
3425 2007-04-11 Marek Safar <marek.safar@gmail.com>
3427 A fix for bug #81350
3428 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
3431 2007-04-11 Martin Baulig <martin@ximian.com>
3433 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
3434 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
3435 to make this work for generic classes; fixes #79561.
3437 2007-04-11 Martin Baulig <martin@ximian.com>
3439 * expression.cs (As): Add support for nullable types; fixes #79371.
3441 2007-04-11 Martin Baulig <martin@ximian.com>
3443 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
3444 `type.FullName' is null; fixes #80243.
3446 2007-04-11 Martin Baulig <martin@ximian.com>
3448 * expression.cs (Invocation.IsApplicable): Don't modify the method
3449 if type inference succeeded, but the method was not applicable.
3452 2007-04-10 Marek Safar <marek.safar@gmail.com>
3454 A fix for bug #81324
3455 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
3456 internal and external namespaces containers.
3458 2007-04-10 Martin Baulig <martin@ximian.com>
3460 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
3461 TypeManager.DropGenericMethodArguments() so we also call
3462 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
3464 2007-04-10 Martin Baulig <martin@ximian.com>
3466 * iterators.cs (Iterator.CreateIterator): Don't crash if
3467 `method.ReturnType' is null. This happens if something went wrong
3468 while resolving that typ (we already reported an error in this case).
3470 2007-04-10 Martin Baulig <martin@ximian.com>
3472 * expression.cs (New.DoResolve): Don't call CheckComImport() on
3473 generic interfaces; report the CS0144 directly.
3475 2007-04-10 Martin Baulig <martin@ximian.com>
3477 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
3478 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
3480 2007-04-10 Martin Baulig <martin@ximian.com>
3482 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
3484 2007-04-09 Raja R Harinath <rharinath@novell.com>
3487 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
3488 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
3491 * statement.cs (For.Resolve): If resolution fails, use
3494 2007-04-08 Marek Safar <marek.safar@gmail.com>
3496 * anonymous.cs (MakeName): Make faster and zero-based.
3497 (VerifyExplicitParameterCompatibility): Back to mode where generic
3498 parameter is ignored.
3499 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
3501 * class.cs (EmitType): Method can emit another new method.
3503 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
3505 * driver.cs: Updated.
3507 * lambda.cs: Reuse predefined empty parameters.
3509 * parameter.cs: Updated
3511 * support.cs: Implemented InflateTypes.
3513 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
3514 (InitSystemCore): Introduced to isolate 3.0 dependencies.
3516 2007-04-03 Martin Baulig <martin@ximian.com>
3520 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
3521 version of TypeManager.IsOverride() which also works with generic
3524 2007-04-03 Martin Baulig <martin@ximian.com>
3529 (Convert.ExplicitReferenceConversion): We need to cast when
3530 converting from IList<T> to S[].
3532 2007-04-01 Marek Safar <marek.safar@gmail.com>
3534 * decl.cs (FindExtensionMethods): Consider all candidates with same name
3537 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
3539 2007-03-31 Marek Safar <marek.safar@gmail.com>
3541 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
3542 argument and return type inferring.
3544 * codegen.cs (InferReturnType): Flag whether return can be inferred.
3545 (ReturnType): Turned to property.
3547 * statement.cs (Return): Implemented return type inferring.
3549 * support.cs (ReflectionParameters): Use local types if possible.
3551 2007-03-30 Raja R Harinath <rharinath@novell.com>
3553 * flowanalysis.cs (FlowBranching.Reachability): Remove.
3554 (FlowBranching.UsageVector): Update to changes.
3556 Prepare to kill 'Reachability'
3557 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
3558 argument of constructor.
3560 2007-03-29 Raja R Harinath <rharinath@novell.com>
3562 Prepare to kill 'Reachability'
3563 * flowanalysis.cs (UsageVector.is_unreachable): New.
3564 (UsageVector): Update to maintain 'is_unreachable' in parallel to
3565 'reachability', and verify they're consistent.
3568 * expression.cs (New.EmitStatement): Handle type parameters here too.
3570 2007-03-29 Martin Baulig <martin@ximian.com>
3575 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
3576 CompilerGeneratedClass.
3577 (ScopeInfo.EmitScopeInstance): Make this protected.
3578 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
3579 `ec.CurrentAnonymousMethod.Scope == Scope'.
3581 * statement.cs (Block.ScopeInfo): Make this a property.
3583 2007-03-27 Raja R Harinath <harinath@gmail.com>
3585 Prepare to kill 'Reachability'
3586 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
3587 (FlowBranching.UsageVector.Reachability): Remove property.
3588 (FlowBranching.UsageVector.IsUnreachable): New property.
3589 (FlowBranching.UsageVector.ResetBarrier): New.
3590 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
3591 * codegen.cs, statement.cs: Update to changes.
3593 2007-03-27 Martin Baulig <martin@ximian.com>
3598 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
3601 2007-03-26 Raja R Harinath <rharinath@novell.com>
3603 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
3604 instead of TriState. Remove all mention of TriState.
3606 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
3607 replaced by a boolean. Add boolean 'is_unreachable' field, check
3608 and maintain invariants.
3610 2007-03-25 Marek Safar <marek.safar@gmail.com>
3612 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
3614 2007-03-25 Marek Safar <marek.safar@gmail.com>
3616 * expression.cs: Stop using obsolete 2.0 opcodes.
3618 2007-03-25 Marek Safar <marek.safar@gmail.com>
3620 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
3621 one of the latests Martin's fixes.
3623 2007-03-23 Miguel de Icaza <miguel@novell.com>
3625 * expression.cs: On BigEndian systems, swap the bytes, temporary
3626 solution until we get a new bitconverter class.
3628 2007-03-23 Martin Baulig <martin@ximian.com>
3632 * decl.cs (MemberCache.AddMembers): Add generic methods both as
3633 "Method" and "Method`1". Normally, a cache lookup is done on the
3634 "Method" form (ie. without the generic arity), but this one makes
3635 lookups on the full form work as well.
3637 2007-03-22 Raja R Harinath <rharinath@novell.com>
3639 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
3642 2007-03-20 Bill Holmes <billholmes54@gmail.com>
3644 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
3645 ordered_member_list, to TypeBuilder to store members to be defined
3646 in the order they were parsed in.
3647 - ordered_explicit_member_list contains all properties indexers
3648 and methods that are defined as explicit implementation of an
3649 interface or base class.
3650 - ordered_member_list contains all properties indexers and methods
3651 that are not defined as explicit implementation of an interface
3654 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
3655 functionality in these removed classes has been replaced with
3656 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
3657 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
3659 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
3660 to CheckForDuplications inside GetMethod and SetMethod Define Method
3661 to handle method property and indexer name conflicts.
3665 All code is contributed under the MIT/X11 license.
3667 2007-03-20 Martin Baulig <martin@ximian.com>
3669 * class.cs (TypeContainer.Interfaces): Removed; they're now
3670 included in `TypeContainer.Types'.
3672 2007-03-20 Martin Baulig <martin@ximian.com>
3674 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
3676 * class.cs (TypeContainer.CreateType): New public method. This is
3677 now called before DefineType() to create the TypeBuilders.
3678 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
3679 has already been created by CreateType().
3680 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
3681 don't resolve our base classes here; this has been moved into
3682 DefineBaseTypes(). We're now called from CreateType().
3683 (TypeContainer.DefineBaseTypes): New private method; resolve our
3684 base classes here. We're now called from DefineType().
3687 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
3688 our types first to create all the TypeBuilders. After that, call
3689 TypeContainer.DefineType() on all the types which'll resolve their
3690 base classes and setup the resolve order.
3692 2007-03-20 Martin Baulig <martin@ximian.com>
3694 * class.cs (TypeContainer.Enums): Removed; they're now included in
3695 `TypeContainer.Types'.
3697 2007-03-20 Martin Baulig <martin@ximian.com>
3700 (TypeContainer.DefineType): Don't call ResolveMembers() here.
3701 (TypeContainer.DoResolveMembers): Call DefineType() on our
3702 `compiler_generated' classes; moved here from DefineNestedTypes().
3705 (RootContext.ResolveTree): Call ResolveMembers() on all
3706 TypeContainer's in the `type_container_resolve_order'.
3708 2007-03-19 Marek Safar <marek.safar@gmail.com>
3710 * class.cs: Use corlib to handle InternalMethodImplAttribute.
3712 2007-03-17 Marek Safar <marek.safar@gmail.com>
3714 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
3715 implementation flags.
3717 2007-03-17 Marek Safar <marek.safar@gmail.com>
3719 * class.cs: More optimizations for type parameters.
3721 2007-03-15 Marek Safar <marek.safar@gmail.com>
3723 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
3725 * ecore.cs, parameter.cs: More common code for both corlibs.
3727 * typemanager.cs (IsGenericMethod): Simplified.
3729 2007-03-15 Raja R Harinath <rharinath@novell.com>
3731 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3733 * statement.cs, iterators.cs, lambda.cs: Update to changes.
3735 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
3736 unconditionally. Simplify explanation.
3737 (Try.Resolve, Using.Resolve): Likewise.
3739 2007-03-15 Martin Baulig <martin@ximian.com>
3743 * decl.cs (DeclSpace): If we're a partial class, use our
3744 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
3746 2007-03-15 Raja R Harinath <rharinath@novell.com>
3748 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3750 (FlowBranching.UsageVector): Update to changes.
3751 (FlowBranching.MergeSiblings): Likewise.
3752 * statement.cs: Likewise.
3754 2007-03-15 Martin Baulig <martin@ximian.com>
3759 (MemberCache): Added a special .ctor for type parameters.
3762 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
3765 2007-03-09 Martin Baulig <martin@ximian.com>
3767 * enum.cs (Enum): Make this a TypeContainer.
3768 (EnumMember): Derive from `Const'.
3771 (Const.DoResolveValue): New protected virtual method; move most of
3772 the functionality of ResolveValue() here so we can override it in
3774 (Const.CreateConstantReference): Make this virtual.
3776 * class.cs (Kind): Add `Kind.Enum'.
3777 (TypeContainer.Emit): Don't emit the enums here; they're already
3778 in the `RootContext.typecontainer_resolve_order'.
3780 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
3781 here; they're already in the `typecontainer_resolve_order'.
3783 * ecore.cs (EnumConstant.ConvertImplicitly): Add
3784 TypeManager.DropGenericTypeArguments().
3787 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
3788 (TypeManager.IsEnumType): Likewise.
3789 (TypeManager.EnumToUnderlying): Likewise.
3790 (TypeManager.IsEqual): Add support for enums.
3792 2007-03-12 Raja R Harinath <rharinath@novell.com>
3794 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
3795 DefaultParameterValueAttribute to be undefined, say if System.dll
3798 2007-03-11 Marek Safar <marek.safar@gmail.com>
3800 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
3803 2007-03-10 Marek Safar <marek.safar@gmail.com>
3805 * class.cs, parameter.cs: Unified parameters verification.
3807 2007-03-08 Martin Baulig <martin@ximian.com>
3809 * cs-parser.jay (constructor_header): Pass the location to the
3810 newly created TopLevelBlock.
3812 2007-03-07 Martin Baulig <martin@ximian.com>
3814 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
3816 2007-03-06 Miguel de Icaza <miguel@novell.com>
3818 * convert.cs (ExplicitReferenceConversionExists): Sync this method
3819 with the changes from David, fixes the build.
3821 2007-03-05 David Mitchell <dmitchell@logos.com>
3823 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
3824 and its base interfaces to a one-dimensional array type S[],
3825 provided there is an implicit or explicit reference conversion
3828 2007-03-03 Marek Safar <marek.safar@gmail.com>
3830 * cs-tokenizer.cs: Implemented basic linq grammar.
3832 * driver.cs: Set linq lang version on demand.
3834 2007-02-26 Marek Safar <marek.safar@gmail.com>
3836 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
3838 2007-02-25 Marek Safar <marek.safar@gmail.com>
3840 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
3843 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
3845 Check property and event extern attributes.
3847 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
3850 2007-02-24 Marek Safar <marek.safar@gmail.com>
3852 A fix for bug #80407
3853 * ecore.cs: Don't report ambiguity error when methods have same parent.
3855 2007-02-23 Marek Safar <marek.safar@gmail.com>
3857 A fix for bug #80878
3858 * class.cs, cs-parser.jay: Event property can host anonymous methods.
3860 2007-02-22 Marek Safar <marek.safar@gmail.com>
3862 * attribute.cs: Enable ExtensionAttribute presence test.
3864 2007-02-22 Marek Safar <marek.safar@gmail.com>
3866 * class.cs: Warn about missing GetHashCode only when Equals is override.
3868 * decl.cs: Check accessibility of type arguments.
3870 * typemanager.cs: Correctly report nullable array.
3872 2007-02-20 Marek Safar <marek.safar@gmail.com>
3874 * class.cs, report.cs: Capture more details when things go wrong.
3876 2007-02-20 Marek Safar <marek.safar@gmail.com>
3878 A fix for bug #80650
3879 * cs-parser.jay: Anonymous container starts at constructor declaration
3880 and not at block beginning because it has to be usable in constructor
3883 * statement.cs: Use context location and not block one for error reporting.
3885 2007-02-18 Marek Safar <marek.safar@gmail.com>
3887 A fix for bug #78712
3888 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
3891 2007-02-18 Marek Safar <marek.safar@gmail.com>
3893 A fix for bug #80493 by Atsushi Enomoto
3894 * cs-parser.jay: Ignore invalid attribute target.
3896 2007-02-18 Marek Safar <marek.safar@gmail.com>
3898 * cs-tokenizer.cs: Ignore '\0' as white space character.
3900 2007-02-17 Miguel de Icaza <miguel@novell.com>
3902 * cs-parser.jay: Add support for lambda expressions to the mcs
3905 * lambda.cs: Only clone when we are probing, not on the final call
3906 (Compatible is the final call).
3908 * statement.cs (CloneContext): Introduce class to provide block
3909 remapping during clone.
3911 All statements Clone themselves now.
3913 (Clone): special handling for blocks, when we clone a block, we
3914 register the block inside this routine, as children of the block
3915 might trigger a lookup.
3917 * expression.cs: Add support for CloneContext in all expressions.
3919 2007-02-17 Marek Safar <marek.safar@gmail.com>
3921 A fix for bug #80493
3922 * statement.cs: Report ambiguous warning when interfaces are not related.
3924 2007-02-15 Marek Safar <marek.safar@gmail.com>
3926 C# 3.0 extension methods.
3928 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
3929 cannot be used directly.
3931 * class.cs (Class.Emit): Emit extension attribute if any class method
3932 is extension method.
3933 (Method.Define): Add basic extension method validation conditions.
3934 (Method.Emit): Emit extension attribute for method.
3936 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
3937 extension method exists. Currently we follow same approach as Microsoft
3938 does, emit even if a method or a class are private but this can change
3941 * cs-parser.jay: Add handling of `this' keyword in method parameters
3944 * decl.cs (DeclSpace.IsStaticClass): New property.
3945 (MemberCache.FindExtensionMethods): Looks for extension methods with
3946 defined name and extension type.
3948 * doc.cs: Updated after OverloadResolve changes.
3950 * driver.cs: Add new soft reference to System.Core.dll.
3952 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
3953 (ExtensionMethodGroupExpr): Represents group of extension methods.
3955 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
3956 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
3957 to MethodGroupExpr and made non-static for easier customization.
3958 (Invocation.DoResolve): Add extension method lookup when no standard
3960 (MemberAccess.DoResolve): Try extension methods if no member exists.
3962 * modifiers.cs: Add METHOD_EXTENSION modifier.
3964 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
3965 as well as candidate extension type.
3966 (ComputeNamespaces): When assembly constains extension methods registers
3968 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
3969 extension method lookup.
3970 (Namespace.LookupExtensionMethod): Looks for extension method in this
3972 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
3973 find a method which matches name and extensionType.
3975 * parameter.cs (Parameter): Add This modifer.
3976 (HasExtensionMethodModifier): New property.
3977 (Resolve): Add extension parameter check.
3978 (ModFlags): turned to property to exclude this modifier as it is not real
3980 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
3982 * support.cs (ParameterData): Add ExtensionMethodType.
3983 (ReflectionParameters): Implemented ExtensionMethodType interface property.
3985 * typemanager.cs: Add type and ctor extension attribute type.
3987 2007-02-15 Miguel de Icaza <miguel@novell.com>
3989 * report.cs (DisableErrors, EnableErrors): used to prevent error
3990 output when we are "trying" to compile various methods with
3993 * ecore.cs (Expression): Add Clone method that calls the virtual
3994 CloneTo method. The current CloneTo method in Expression throws
3995 an exception so we can track down all the places where this must
3996 be implemented (not using abstract, because that would be a lot of
3997 up-front-work before we can start testing the implementation
4000 Important: we only need Clone capabilities for expressions created
4001 by the parser, as the expressions we will be cloning are
4002 expressions in the pre-resolved state. This vastly simplifies
4005 (SimpleName): Add CloneTo that does nothing.
4006 (EmptyCast): Add CloneTo.
4008 * expression.cs (Binary): Implement CloneTo.
4009 (Invocation.IsApplicable): Store the current ec in
4010 EmitContext.TempEc and restore it on return. This is used so we
4011 do not have to sprinkle hundres of methods with an extra
4012 EmitContext, we know that the only user is the lambda expression
4013 ImplicitConversionExists code.
4015 (Argument): Add Cloning capabilities.
4016 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
4017 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
4018 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
4019 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
4020 IndexerAccess): Add Clone capability.
4022 (LocalVariableReference, This): TODO: needs cloned Block mapping.
4024 (Argument): Add cloning capability.
4026 * assign.cs (Assign): Implement CloneTo.
4028 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
4030 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
4031 version by calling Convert with the EmitContext (that we are
4032 currently storing in ec, this is not great, but will do for now,
4033 to avoid passing EmitContext parameters to hundreds of functions
4034 that do not need them now).
4036 (SetExpression): Remove, it is not needed.
4038 (ContextualReturn): Implement CloneTo.
4040 * statement.cs (Statement): Implement cloning infrastructure,
4041 similar to expressions.
4043 (Block): Partial implementation of Clone for statements.
4045 (Return): Implement clone.
4047 * constant.cs (Constant.CloneTo): New method, does nothing.
4049 * codegen.cs (TempEc): Add a static EmitContext as a temporary
4050 solution, until we decide how to exactly do this.
4052 2007-02-14 Marek Safar <marek.safar@gmail.com>
4054 A fix for bug #80493
4055 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
4056 a property is override we need to use second accessor.
4058 2007-02-13 Marek Safar <marek.safar@gmail.com>
4060 A fix for bug #80418
4061 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
4064 2007-02-13 Marek Safar <marek.safar@gmail.com>
4066 Another fix for bug #80749
4067 * pending.cs: Abstract class has priority over interfaces.
4069 2007-02-13 Marek Safar <marek.safar@gmail.com>
4071 Another fix for bug #80749
4072 * pending.cs: Abstract class has priority over interfaces.
4074 2007-02-13 Marek Safar <marek.safar@gmail.com>
4076 Another fix for bug #80749
4077 * pending.cs: Abstract class has priority over interfaces.
4079 2007-02-13 Marek Safar <marek.safar@gmail.com>
4081 Another fix for bug #80749
4082 * pending.cs: Abstract class has priority over interfaces.
4084 2007-02-13 Marek Safar <marek.safar@gmail.com>
4086 * class.cs Better error message.
4088 * driver.cs: Add shorter versions of -optimize option.
4090 2007-02-13 Martin Baulig <martin@ximian.com>
4092 * class.cs (Constructor.Emit): Check the return value of
4093 ec.ResolveTopBlock() and return on error.
4095 2007-02-13 Raja R Harinath <rharinath@novell.com>
4097 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
4098 message to fix error message regression.
4100 2007-02-12 Marek Safar <marek.safar@gmail.com>
4102 * delegate.cs: Delegate creation expression cannot be of Nullable type.
4104 2007-02-12 Marek Safar <marek.safar@gmail.com>
4106 A fix for bug #80749
4107 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
4108 its parent container.
4110 * class.cs (DefineFieldInitializers): Each initializer can has different
4113 * const.cs: Updated.
4115 2007-02-11 Miguel de Icaza <miguel@novell.com>
4117 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
4118 now all the heavy lifting to check that embedded statements or
4119 expressions have the right form is done in the ContextualReturn.
4121 (ContextualReturn): New class.
4123 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
4124 method that can be invoked to report 201, so we do not replicate
4127 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
4129 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
4130 treating tabs as spaces.
4132 2007-02-09 Marek Safar <marek.safar@gmail.com>
4134 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
4135 * assign.cs: Use full implicit conversion for right side check.
4137 2007-02-09 Marek Safar <marek.safar@gmail.com>
4139 * statement.cs (Switch): Switch over boolean type is not standardized.
4141 2007-02-08 Marek Safar <marek.safar@gmail.com>
4143 A fix for bug #80755
4144 * decl.cs (FindBaseEvent): Don't use method cache for events.
4146 2007-02-07 Marek Safar <marek.safar@gmail.com>
4148 * cs-parser.jay: Better syntax error handling.
4150 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
4151 instead of underlying type value.
4153 2007-02-06 Marek Safar <marek.safar@gmail.com>
4155 * driver.cs: Check define identifier before is registered.
4157 * namespace.cs: Use existing error message.
4159 * report.cs: New warning.
4161 2007-02-06 Marek Safar <marek.safar@gmail.com>
4163 A fix for bug #80742
4164 * expression.cs: Delegate Invoke method can be called directly.
4166 2007-02-06 Marek Safar <marek.safar@gmail.com>
4168 A fix for bug #80676
4169 * class.cs (IsEntryPoint): The Main method can have params modifier.
4171 2007-02-04 Miguel de Icaza <miguel@novell.com>
4173 * parameter.cs (Parameter, Parameters): Add Clone method.
4175 * anonymous.cs (Compatible): Turn method into virtual method, so
4176 LambdaExpression can implement a different behavior.
4178 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
4179 out the basic checking here, so it can be used by
4182 * lambda.cs: Introduce "Compatible" function that will do the
4185 2007-02-02 Marek Safar <marek.safar@gmail.com>
4187 * attribute.cs: Unified one error message.
4189 * class.cs (Class): Use type attributes and not properties to test static
4191 (IsEntryPoint): Don's pass local variable.
4193 * convert.cs: Removed duplicate check.
4195 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
4197 * driver.cs: Don't crash when soft reference does not exist.
4199 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
4200 (UsingEntry): Removed redundant allocation.
4202 * parameter.cs: Add fast path for type parameters.
4204 * support.cs: Don't allocate attribute when it's not used.
4206 2007-01-30 Miguel de Icaza <miguel@novell.com>
4209 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
4210 this into a virtual method, so we can override it in LambdaExpression.
4212 * driver.cs: Improve diagnostics in case of failure.
4214 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
4215 write a function that is slightly more complex and that parses:
4217 type identifier [, type identifier]* )
4219 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
4222 (canEmpty ? i >= 0 : i > 0)
4224 2007-01-30 Raja R Harinath <rharinath@novell.com>
4226 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
4227 exception on possibly valid code.
4229 2007-01-29 Raja R Harinath <rharinath@novell.com>
4231 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
4233 (parse_opt_type_arguments): Remove. It's almost the same as
4235 (parse_namespace_or_typename): Use parse_less_than.
4237 2007-01-28 Miguel de Icaza <miguel@novell.com>
4239 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
4240 this bug took a few hours to find, because the state saved and
4241 restored by PushPosition and PopPosition was ignoring the state of
4242 parse_generic_less_than.
4244 I can also now remove the handling of OP_LT and OP_GT, this solves
4247 * cs-tokenizer.cs: store the location for the ARROW token, we use
4250 (PushPosition, PopPosition): save/restore also `current_token',
4251 restore `parse_generic_less_than' (was missing).
4253 (parse_opt_type_arguments): use parse_type, not
4254 parse_namespace_or_typename to parse types.
4256 * lambda.cs: Empty new file, will eventually have the lambda
4257 expression implementation.
4259 * lambda.test: used to test the internal tokenizer.
4261 * report.cs (FeatureIsNotISO1): Rename from
4262 FeatureIsNotStandardized, because it was about the language level
4263 (1 vs 2) it was not about standarization.
4265 (FeatureRequiresLINQ): New.
4267 * support.cs (SeekableStreamReader): Only require that the reader
4268 is a TextReader, not a StreamReader, so we can plug StringReader.
4270 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
4271 given position in the input stream the following tokens can be
4272 parsed as a type followed by an identifier.
4274 (is_punct): after a '(' if parse_type_and_parameter returns true,
4275 then return a special token OPEN_PARENS_LAMBDA which is used to
4276 avoid reduce/reduce errors in the grammar for the
4277 lambda_expression rules.
4279 (parse_type): implement a type parser inside the
4280 tokenizer, the parser only returns true or false depending on
4281 whether the input at a given position can be parsed as a type.
4283 (peek_token): new method used during type parsing.
4285 2007-01-28 Raja R Harinath <rharinath@novell.com>
4288 * anonymous.cs (ScopeInfo.InflateParameters): New.
4289 (AnonymousContainer.Resolve): Use it to redirect types of
4290 delegate parameters.
4292 2007-01-27 Raja R Harinath <rharinath@novell.com>
4295 * expression.cs (Error_InvalidArguments): Don't use two different
4296 messages for CS1503. Use ExtraInformation and
4297 SymbolRelatedToPreviousError instead.
4300 * decl.cs (DeclSpace.initialize_type_params): Don't access
4301 'type_params' of a partial class directly.
4303 2007-01-26 Miguel de Icaza <miguel@novell.com>
4305 * constant.cs: Removed a handful of out-of-range checks that were
4308 2007-01-25 Marek Safar <marek.safar@gmail.com>
4310 * expression.cs (CheckUselessComparison): Add additional check for char
4313 * namespace.cs: Fixed typo.
4315 2007-01-23 Miguel de Icaza <miguel@novell.com>
4317 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
4318 gone, instead we inline the test, preventing the needless casts to
4319 longs, ulongs and doubles for the parameters, avoiding calls to
4320 methods that overchecked stuff, and instead inlined things
4323 2007-01-20 Marek Safar <marek.safar@gmail.com>
4325 * cs-parser.jay: Better parameter error handling.
4327 2007-01-17 Marek Safar <marek.safar@gmail.com>
4329 A fix for bug #80368, #80522
4330 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
4331 whether array initializer contains constants only.
4332 (ArrayCreation.Emit): Use better formula to decide when
4333 are array initializers for static initialization.
4334 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
4335 have to emit even constants otherwise they are pre-initialized.
4337 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
4338 Raja R Harinath <rharinath@novell.com>
4340 Fix emit order of 'get' vs. 'set'.
4341 * support.cs (Accessors): New.
4342 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
4343 Note the order in which accessors are declared in the source.
4344 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
4345 Refactored from Property.Define and Indexer.Define.
4346 (PropertyBase.DefineAccessors): New helper that calls the above in
4347 appropriate order as noted by the parser.
4348 (Property.Define, Indexer.Define): Update to changes.
4349 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
4351 2007-01-17 Raja R Harinath <rharinath@novell.com>
4353 Fix cs0029-6.cs and gcs0029-2.cs (regression)
4354 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
4355 there's an implicit conversion from the current type to the target
4356 type before converting the underlying constant.
4358 2007-01-16 Marek Safar <marek.safar@gmail.com>
4360 * const.cs (ResolveValue): Updated after constant conversion was made more
4363 * constant.cs (GetAttributableValue): constant to object conversion is
4364 used for attributes only.
4365 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
4366 constant conversions.
4367 (LongConstant.ConvertImplicitly): Ditto.
4369 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
4370 (ImplicitConversionStandard): Handle constant conversion as extra step.
4371 It solves the issue when constant conversion was called indirectly like
4372 inside array initializer and constant folding was skipped.
4374 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
4377 * statement.cs(ImplicitConversionStandard): Updated after constant
4378 conversion was made more generic.
4380 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
4382 * expression.cs (As.DoResolve): Use GenericConstraints instead of
4383 Constraints, solves the problem where the compiler incorrectly
4384 reported that a type parameter was not constrained to a class (Bug
4387 2007-01-14 Marek Habersack <grendello@gmail.com>
4389 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
4391 2007-01-14 Marek Safar <marek.safar@gmail.com>
4393 A fix for bug #80368
4394 * assign.cs (FieldInitializer): New class implements field
4395 initializer statement.
4397 * attribute.cs: Update after FieldMember rename.
4399 * class.cs (PropertyBasedMember): New common class for property based
4401 (InterfaceMemberBase): New base class for all members which can be used as
4402 an interface members.
4403 (MethodCore): Moved really common code to InterfaceMemberBase.
4404 (Method.Define): Equal and GetHasCode detection is relevant for methods
4406 (MethodData.Define): Don't assume that public event implements an
4407 interface automatically.
4408 (MethodData.DefineMethodBuilder): Issue an error even if only extern
4410 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
4411 (FieldMember): Merged with FieldBase.
4412 (EventProperty.AEventPropertyAccessor): New specialization to check whether
4413 event extern modifier can be used.
4414 (EventField.EventFieldAccessor): Moved event field specific code here.
4415 (Event.AllowedModifiers): Even event can be extern.
4416 (Event.FindOutBaseMethod): New override specific to events.
4417 (Indexer.parameters): Reintroduce parameters because base class holds
4418 only properties common data.
4419 (Indexer.CheckForDuplications): Indexers are threated as methods so we
4420 need do extra parameters check.
4422 * const.cs: Update after FieldMember rename.
4424 * decl.cs (MemberCache.FindBaseEvent): New method.
4426 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
4427 to reflect that indexer is now derived from PropertyBased.
4429 * ecore.cs (GetMemberType): Made public.
4430 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
4433 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
4435 * typemanager.cs (CSharpSignature): Correctly print event accessors.
4436 (RegisterEvent): Removed.
4437 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
4438 (GetPrivateFieldOfEvent): Renamed to GetEventField.
4440 2007-01-11 Raja R Harinath <rharinath@novell.com>
4443 * statement.cs (CollectionForeach.TryType): Prefer generic
4444 GetEnumerator over non-generic variant. Fix code to follow comments.
4446 2007-01-09 Raja R Harinath <rharinath@novell.com>
4449 * support.cs (ReflectionParameter): Don't use an invalid index on
4450 the generic parameter data.
4452 2007-01-08 Miguel de Icaza <miguel@novell.com>
4454 * driver.cs: Just add a tiny bit of infrastructure.
4456 2007-01-02 Marek Safar <marek.safar@gmail.com>
4458 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
4459 where field type is struct from current assembly.
4461 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
4464 2007-01-02 Marek Safar <marek.safar@gmail.com>
4466 A fix for bug #80381
4467 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
4470 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
4472 (Namespace.LookupType): Always use core types from corlib when speficied.
4474 * report.cs: A new warning.
4476 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
4477 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
4478 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
4480 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
4481 (InitCoreTypes): Set expression type of object_type and value_type
4482 immediately after lookup.
4484 2007-01-01 Miguel de Icaza <miguel@novell.com>
4486 * cs-tokenizer.cs: Accept Pc class characters (Connector
4487 Punctuation) as valid identifiers. Fixes #78259
4489 * expression.cs (Invocation.DoResolve): Moved the check for the
4490 use of `this' for doing method calls to the Invocation resolution
4491 step, after overload resolution has taken place instead of doing
4492 the check at the low-level `This.DoResolve' level.
4494 The `This.DoResolve'(appens before overload resolution, so it has
4495 no way of knowing if the method that will be called will be
4496 instace or static, triggering an erroneous report for cs0188 (Bug
4499 We now do the check for instance method invocations after we know
4500 what method will be called.
4502 (This.CheckThisUsage): Move the actual use of this structure
4503 checking into its own method and expose it.
4505 * Everywhere that called Error_ValueCannotBeConverted: pass a new
4508 Exceptions: Null.ConvertImplicitly,
4509 Constant.ImplicitConversionRequired as there are too many call
4510 sites for passing the ec.
4512 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
4513 EmitContext, if the value is null, then we do not try to provide
4514 the extra information from the error (If a userdefined conversion
4515 exists, as UserDefinedConversion requires a non null-EmitContext).
4519 2006-12-30 Raja R Harinath <rharinath@novell.com>
4521 * flowanalysis.cs (MyBitVector): Document some invariants.
4522 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
4523 introduced below, and add a couple of others,
4525 2006-12-30 Marek Safar <marek.safar@gmail.com>
4527 * attribute.cs (GetMethodObsoleteAttribute): Uses new
4528 GetPropertyFromAccessor and GetEventFromAccessor.
4530 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
4531 overrides non-obsolete one.
4532 (Indexer.Define): Error message has been moved to the parser.
4534 * cs-parser.jay: Better syntax errors handling.
4536 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
4537 when an invocation has no arguments.
4539 * ecore.cs: Removed not used caching.
4541 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
4544 * report.cs: Add a new warning.
4546 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
4548 * typemanager.cs (enumeration_type): Removed.
4549 (CSharpSignature): Reuses IsSpecialMethod.
4550 (IsEqual): Hack for MS BCL.
4551 (GetPropertyFromAccessor): New method.
4552 (GetEventFromAccessor): New method.
4553 (IsSpecialMethod): Fixed to handle more cases.
4555 2006-12-30 Marek Safar <marek.safar@gmail.com>
4557 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
4558 Made white spaces array static.
4560 * ecore.cs (RemoveGenericArity): Optimized.
4562 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
4564 (MyBitVector.initialize_vector): Simplified.
4566 2006-12-22 Miguel de Icaza <miguel@novell.com>
4568 * ecore.cs: Am not entirely happy with this hack, but it seems to
4569 address the issue in 80257 (a small test case for
4572 I set the MethodGroupExpr.Type to an internal compiler type
4573 (itself in this case) to force the resolution to take place. Why
4574 it does not take place with a null is beyond me.
4576 2006-12-20 Marek Safar <marek.safar@gmail.com>
4578 A fix for bug #80288
4579 * expression.cs (ResolveOperator): Consider user defined conversion for
4580 logical and operator too.
4581 (EmitBranchable): Optimization for logical and when full constant folding
4582 could not be applied but one operand is constant.
4584 2006-12-19 Marek Safar <marek.safar@gmail.com>
4586 * class.cs (GetClassBases): Write 5 times every day, will never use
4587 FullName for error reporting.
4589 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
4591 2006-12-19 Martin Baulig <martin@ximian.com>
4593 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
4594 the symbol file info here.
4596 2006-12-18 Marek Safar <marek.safar@gmail.com>
4598 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
4599 of `elseif' is taking then following sections are not taking.
4600 Fixes an issue reported on mono mailing list.
4602 2006-12-18 Marek Safar <marek.safar@gmail.com>
4604 A fix for bug #80300
4605 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
4606 a caller is not taking.
4608 2006-12-18 Raja R Harinath <rharinath@novell.com>
4610 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
4611 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
4612 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
4613 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
4614 * class.cs: Update to changes.
4616 2006-12-17 Marek Safar <marek.safar@gmail.com>
4618 A fix for bug #79934
4619 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
4622 * class.cs (ResolveMembers): Register an iterator in current container and
4625 2006-12-16 Raja R Harinath <rharinath@novell.com>
4628 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
4629 satisfy a params annotated parameter.
4631 2006-12-16 Marek Safar <marek.safar@gmail.com>
4633 A fix for bug #77014
4634 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
4635 paramters correctly and not rely on hacks in Parameters class.
4636 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
4638 (Invocation.VerifyArgumentsCompat): Ditto.
4639 (Invocation.EmitArguments): Changed to correctly emit params arguments at
4642 * parameter.cs (HasParams): Don't assume that params is the last one.
4644 * support.cs (ReflectionParameters.ctor): Look for params attribute
4646 (ReflectionParameters.ParameterType): Removed hack when we returned last
4647 parameter for out of range parameters.
4648 (ParameterName, ParameterModifier): Ditto.
4650 2006-12-14 Marek Safar <marek.safar@gmail.com>
4652 A fix for bug #79987
4653 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
4654 when assembly is not CLS compliant but type is. I have no idea why is this
4657 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
4659 2006-12-13 Miguel de Icaza <miguel@novell.com>
4661 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
4662 in struct constructors, they are basically no-ops.
4664 2006-12-12 Marek Safar <marek.safar@gmail.com>
4666 * cs-tokenizer.cs (Position): Save preprocessor status too.
4668 2006-12-12 Marek Safar <marek.safar@gmail.com>
4670 A fix for bug #77794
4671 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
4673 2006-12-12 Marek Safar <marek.safar@gmail.com>
4675 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
4677 (pp_expr): Report error for an invalid expression.
4678 (handle_preprocessing_directive): Simplified; add more error checking.
4680 2006-12-11 Marek Safar <marek.safar@gmail.com>
4682 A fix for bug #74939
4683 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
4684 directives handling.
4686 2006-12-10 Marek Safar <marek.safar@gmail.com>
4688 A fix for bugs #80093, and #75984
4689 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
4690 logic, it seems to me as it worked before "by coincidence".
4691 (xtoken): Simplified to use reworked handle_preprocessing_directive.
4692 (cleanup): Enabled endif check.
4694 2006-12-09 Marek Safar <marek.safar@gmail.com>
4696 A fix for bug #80162
4697 * statement.cs (CollectionForeach.TryType): Generics and non-generics
4698 enumerators are never ambiguous.
4700 2006-12-08 Raja R Harinath <rharinath@novell.com>
4703 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
4705 2006-12-06 Marek Safar <marek.safar@gmail.com>
4707 A fix for bug #80144
4708 * class.cs (EventProperty.Define): Explicit implementation means
4709 that an even is used.
4711 2006-12-06 Marek Safar <marek.safar@gmail.com>
4713 Fixes the operators implementation (part II)
4715 * cfold.cs (DoConstantNumericPromotions): Renamed to
4716 DoBinaryNumericPromotions and simplified.
4717 (BinaryFold): Couple of conversion fixes; simplified.
4719 * constant.cs, ecore.cs, literal.cs
4720 (ToType): Renamed to ConvertImplicitly.
4721 (Reduce): Renamed to ConvertExplicitly.
4723 * class.cs, convert.cs: Updated.
4725 * expression.cs: TryReduce doesn't throw an exception.
4727 2006-12-01 Marek Safar <marek.safar@gmail.com>
4729 A fix for bug #80108
4730 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
4733 2006-11-30 Marek Safar <marek.safar@gmail.com>
4735 Fixes unary operators implementation (part I)
4738 * cfold.cs (Error_CompileTimeOverflow): Made internal
4740 * const.cs (IConstant): Changed to use reference to constant and
4741 not constant itself.
4742 Updated IConstant implementations.
4744 * constant.cs (CreateConstant): New factory method.
4745 Updated IConstant implementation.
4747 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
4749 * ecore.cs: Updated to use CreateConstantReference.
4751 * enum.cs: Reflects IConstant changes.
4753 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
4755 * literal.cs (NullConstant): Change to be independently usable.
4757 2006-11-29 Martin Baulig <martin@ximian.com>
4759 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
4760 we need to emit the scope initializer before calling the base .ctor.
4762 * anonymous.cs: Merged back from the new anonymous methods branch.
4763 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
4765 * expression.cs (ParameterReference.DoResolveBase): Create a
4766 "normal" ScopeInfo when capturing parameters rather than using the
4767 root scope; this makes things work with anonymous methods having
4771 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
4773 2006-11-22 Marek Safar <marek.safar@gmail.com>
4775 A fix for bug #79987
4776 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
4777 check to a base class.
4778 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
4779 only when assembly has missing attribute.
4780 * report.cs: Update.
4782 2006-11-21 Marek Safar <marek.safar@gmail.com>
4784 * cs-tokenizer.cs: Merged with gmcs version.
4786 2006-11-20 Marek Safar <marek.safar@gmail.com>
4789 * cs-parser.jay: Better error message when partial keyword is misplaced.
4791 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
4793 A fix for bug #79810
4794 report.cs: CS1058 only applies to 2.0 profile (gmcs).
4795 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
4796 a RuntimeWrappedException by default.
4798 2006-11-18 Marek Safar <marek.safar@gmail.com>
4800 A fix for bug #79843
4801 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
4803 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
4805 2006-11-18 Marek Safar <marek.safar@gmail.com>
4807 * driver.cs, namespace.cs: Uses faster IndexOf version.
4809 2006-11-17 Marek Safar <marek.safar@gmail.com>
4811 A fix for bug #79941
4812 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
4814 (Operator.Define): Implicit/Explicit operator of same type is duplicate
4815 even if internal name is different.
4816 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
4817 (UserDefinedConversion): Simplified as the operators cannot be internal.
4818 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
4820 (MethodLookup): Replaced EmitContext with parentType.
4821 * expression.cs: Updated.
4823 2006-11-09 Raja R Harinath <rharinath@novell.com>
4825 * driver.cs (BadAssembly): Handle all the ugliness of
4826 DefineDynamicAssembly.
4828 2006-11-08 Raja R Harinath <rharinath@novell.com>
4830 Address parts of #58244 -- most of what's left is in the runtime
4831 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
4832 CS1509 error checks, and handle them for all assembly loads, not
4833 just the first invocation.
4834 (LoadModule): Likewise. Move handling of 'adder_method' ...
4835 * codegen.cs (AssemblyClass.AddModule): ... here.
4837 2006-11-02 Marek Safar <marek.safar@gmail.com>
4839 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
4840 IEnumerable<T> is ambiguous.
4842 2006-10-31 Marek Safar <marek.safar@gmail.com>
4844 A fix for bug #67689
4845 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
4846 GetEnumerator is ambiguous.
4848 * report.cs: Add new warning.
4850 2006-10-29 Marek Safar <marek.safar@gmail.com>
4852 A fix for bug #78602
4853 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4854 to protected member can be nested type.
4856 2006-10-28 Marek Safar <marek.safar@gmail.com>
4858 A fix for bug #78965
4859 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4860 to protected member must derive from current type.
4862 2006-10-27 Marek Safar <marek.safar@gmail.com>
4864 assign.cs: Reuses error method.
4866 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
4867 instead of type for constants.
4868 (Expression.Error_ValueAssignment): Common error method.
4870 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
4873 2006-10-27 Marek Safar <marek.safar@gmail.com>
4875 A fix for bug #79081
4876 * expression.cs (MemberAccess.DoResolve): Check nested type
4879 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
4881 * doc.cs : nested delegates were not handled. Fixed bug #79754.
4883 2006-10-26 Marek Safar <marek.safar@gmail.com>
4885 A fix for bug #76591
4886 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
4888 2006-10-26 Marek Safar <marek.safar@gmail.com>
4890 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
4891 type forwarder of the same type multiple times.
4893 2006-10-26 Raja R Harinath <rharinath@novell.com>
4896 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
4897 instance as an rvalue, even when we later resolve as an lvalue.
4899 2006-10-25 Martin Baulig <martin@ximian.com>
4901 * anonymous.cs: Fix #79673.
4903 2006-10-24 Marek Safar <marek.safar@seznam.cz>
4905 A fix for bug #79666
4906 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
4907 ignored when is optimized (= default value) as its value is already set.
4909 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4911 A fix for bug #79724
4912 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
4913 TypeContainer for type lookup.
4915 2006-10-23 Marek Safar <marek.safar@seznam.cz>
4917 A fix for bug #79231
4918 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
4919 * expression.cs (OverloadResolve): Always convert type name for
4921 (ResolveNamespaceOrType): Don't confuse a nested type with any
4924 2006-10-18 Martin Baulig <martin@ximian.com>
4926 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
4928 2006-10-17 Miguel de Icaza <miguel@novell.com>
4930 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
4931 an int32, but requesting an int64 from the conversion
4933 2006-10-12 Martin Baulig <martin@ximian.com>
4936 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
4938 2006-10-12 Martin Baulig <martin@ximian.com>
4941 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
4943 2006-10-11 Miguel de Icaza <miguel@novell.com>
4945 * convert.cs: Remove broken code: I was doing the "Existance"
4946 tests for Implicit conversions.
4948 2006-10-10 Miguel de Icaza <miguel@novell.com>
4950 * convert.cs: Added one missing case in
4951 ImplicitStandardConversionExists uint64 to intptr.
4955 * typemanager.cs (uintptr_type): another core known type.
4957 * ecore.cs (OperatorCast): routine used to do cast operations that
4958 depend on op_Explicit. We could change some of the Decimal
4959 conversions to use this.
4961 This one has a probe mechanism that checks both types for an op_
4962 which it coudl be used to eliminate two classes: CastToDecimal
4963 and CastFromDecimal.
4965 * convert.cs: Implement the conversions documented in #59800
4967 2006-10-10 Martin Baulig <martin@ximian.com>
4969 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
4970 before RootScope.ResolveMembers().
4972 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
4973 `CurrentType' if appropriate.
4975 2006-10-09 Marek Safar <marek.safar@seznam.cz>
4977 A fix for bug #78568
4978 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
4979 when contains binary operators.
4980 * cs-parser.jay: Updated.
4982 2006-10-09 Martin Baulig <martin@ximian.com>
4985 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
4986 moved that into Define() and also do the other type parameter
4987 checks there. Fixes #79094. Added gtest-292.cs.
4990 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
4991 since that doesn't include type parameters; don't use `Ldelema'
4992 for type parameters. Fixes #78980. Added gtest-293.cs.
4994 2006-10-08 Marek Safar <marek.safar@seznam.cz>
4997 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
4998 conversion is allowed.
5000 2006-10-06 Marek Safar <marek.safar@seznam.cz>
5002 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
5003 error reporting when no error occurs.
5005 2006-10-06 Marek Safar <marek.safar@seznam.cz>
5007 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
5010 2006-10-06 Raja R Harinath <rharinath@novell.com>
5013 * class.cs (DefineTypeBuilder): Check circular dependencies before
5014 setting the parent of the TypeBuilder.
5015 (CheckRecursiveDefinition): Don't use 'BaseType', since
5016 it may not be valid until after DefineTypeBuilder. Use
5017 'base_type' instead.
5019 2006-10-04 Martin Baulig <martin@ximian.com>
5021 Merged the Anonymous Methods patch.
5023 * anonymous.cs, iterators.cs: The new anonymous methods code.
5025 * statement.cs (Variable): New public abstract class.
5026 (LocalInfo.Variable): New public property.
5027 (LocalInfo.ResolveVariable): New public method.
5028 (Block.Flags): Add `IsIterator'.
5029 (Block.AddVariable): Improved the CS0136 check.
5030 (Block.AnonymousChildren): New public property.
5031 (Block.AddAnonymousChild): New public method.
5032 (ToplevelBlock): Update to use the new anonymous method framework.
5033 (ToplevelBlock.ctor): `container' is now a `Block' and not a
5034 `ToplevelBlock'; this is required to correctly implement the
5036 (Fixed, Using): Use `TemporaryVariable' instead of directly
5037 creating the `LocalBuilder'.
5039 * parameter.cs (Parameter.ResolveVariable): New public method.
5040 (Parameters.ResolveVariable): Likewise.
5042 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
5044 * class.cs (TypeContainer): Replaced the `iterators' list and
5045 corresponding methods with a list of `CompilerGeneratedClass'es.
5046 (TypeContainer.ResolveMembers): New public method.
5047 (Method): `IIteratorContainer' has been replaced by
5050 * expression.cs (VariableReference): New public abstract base
5051 class for `LocalVariableReference', `ParameterReference' and
5054 * codegen.cs (EmitContext): Removed `capture_context',
5055 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
5056 (EmitContext.EmitThis): Removed.
5058 * cs-parser.jay: Replace `iterator_container' with
5061 2006-10-04 Martin Baulig <martin@ximian.com>
5063 * generic.cs (GenericMethod): Don't make this abstract.
5064 (Constraints.Clone): Added dummy implementation.
5066 2006-10-04 Raja R Harinath <harinath@gmail.com>
5069 * namespace.cs (LookForAnyGenericType): Avoid nullref on
5070 'declspaces'. Avoid allocating arrays willy-nilly.
5073 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
5074 cases out of the switch.
5076 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5078 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
5079 message when non-generic type is used with the type arguments.
5080 * expression.cs: Updated.
5082 2006-09-28 Raja R Harinath <rharinath@novell.com>
5085 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
5086 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5087 Change semantics slightly. Don't insist on having only one
5088 temporary EmptyExpression -- just throttle the creation of new ones.
5091 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
5092 non-interfaces too. If no methods are found, don't try to create
5095 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5097 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
5100 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
5101 us produce better error message.
5103 2006-09-27 Marek Safar <marek.safar@seznam.cz>
5105 * expression.cs (Binary.ResolveOperator): Warn about a side effect
5106 of the `|' operator.
5108 * report.cs: A new warning added.
5110 2006-09-27 Martin Baulig <martin@ximian.com>
5112 * generic.cs (GenericMethod): Don't make this abstract.
5114 2006-09-27 Martin Baulig <martin@ximian.com>
5117 (InternalErrorException): Added overloaded ctor taking a params array.
5119 2006-09-26 Marek Safar <marek.safar@seznam.cz>
5121 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
5122 Fixed the cases when same error was reported twice.
5124 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
5125 now report symbol information.
5127 2006-09-25 Martin Baulig <martin@ximian.com>
5129 * class.cs: Completely unified with the gmcs version.
5131 2006-09-25 Martin Baulig <martin@ximian.com>
5133 * typemanager.cs (TypeManager.IsNullableType): New public function.
5134 (TypeManager.IsNullableTypeOf): Likewise.
5135 (TypeManager.IsNullableValueType): Likewise.
5137 * class.cs (MethodCore): Added the `GenericMethod' argument from
5138 gmcs and also unified all classes derived from `MethodCore' with gmcs.
5140 2006-09-24 Raja R Harinath <harinath@gmail.com>
5142 * convert.cs: Unify with gmcs version.
5144 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5146 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
5147 verify them as well.
5149 * report.cs: New warning.
5151 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5153 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
5154 for anonymous block with out argument.
5156 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5158 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
5159 not used private events only.
5161 2006-09-23 Marek Safar <marek.safar@seznam.cz>
5163 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
5165 * const.cs (Const.Define): Check for constant type.
5166 (Const.IsConstantTypeValid): Looks for valid constant types.
5168 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
5170 * ecore.cs (EmptyConstantCast): New common class for all constant based
5173 * expression.cs (Is.DoResolve): Handle null constant especially.
5174 (New.DoResolve): Check for new void().
5175 (MemberAccess.DoResolve): Cope with all kind of nulls.
5177 * literal.cs (NullConstant): Uses EmptyConstantCast.
5178 (NullDefault): Based on EmptyConstantCast.
5179 (NullLiteral): Uses EmptyConstantCast.
5181 * statement.cs (Block.ResolveMeta): Check for constant type.
5183 2006-09-22 Martin Baulig <martin@ximian.com>
5185 * delegate.cs, attribute.cs: Merged with the gmcs versions.
5187 2006-09-22 Raja R Harinath <rharinath@novell.com>
5189 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
5193 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
5194 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
5197 2006-09-22 Martin Baulig <martin@ximian.com>
5199 * ecore.cs: Merged with the gmcs version.
5201 * generic.cs (ConstructedType): New dummy class.
5202 (TypeArguments): Don't make this abstract.
5205 (TypeManager.IsGenericTypeDefinition): New method.
5206 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
5208 2006-09-22 Raja R Harinath <rharinath@novell.com>
5210 * expression.cs (ComposedCast): Check for arrays of TypedReference
5211 before creating the type, not after.
5213 2006-09-21 Marek Safar <marek.safar@seznam.cz>
5215 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
5216 after ToType change.
5218 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
5219 when constant must be implicitly convertible.
5221 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
5223 * ecore.cs (NullCast): Derives from NullConstant.
5225 * expression.cs (Is.DoResolve): Removed useless variables.
5226 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
5227 (New.Constantify): Add enum support.
5228 (MemberAccess.DoResolve): Add warning when accessing null constant or
5231 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
5234 * literal.cs (NullConstant): New abstract class with common
5235 functionality for all null specializations.
5236 (NullDefault): Represents default(X) when result can be
5238 (NullLiteral): Updated.
5240 * report.cs: Add new warning.
5242 2006-09-21 Martin Baulig <martin@ximian.com>
5244 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
5246 2006-09-21 Martin Baulig <martin@ximian.com>
5248 * generic.cs (GenericConstraints): New dummy class.
5249 (Constraints): Likewise.
5250 (TypeParameter): Likewise.
5251 (TypeParameterName): Likewise.
5252 (GenericMethod): Likewise.
5254 * typemanager.cs (TypeManager.GetGenericArguments): New method.
5256 * decl.cs: Merged with the gmcs version.
5258 2006-09-21 Raja R Harinath <rharinath@novell.com>
5260 * generic.cs (TypeParameter): Implement IMemberContainer.
5261 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
5263 * rootcontext.cs: Unify with gmcs version.
5265 * report.cs: Unify with gmcs version.
5266 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
5267 from gmcs/generics.cs.
5268 * generics.cs (TypeParameter): New dummy class.
5270 * support.cs: Unify with gmcs version.
5272 2006-09-20 Raja R Harinath <rharinath@novell.com>
5274 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
5275 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
5277 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
5278 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
5279 * mcs.exe.sources: Add generic.cs.
5281 * codegen.cs: Unify with gmcs version.
5283 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
5284 (EmitContext): Add GenericDeclContainer implementation.
5285 * decl.cs (MemberCore, DeclSpace): Likewise.
5286 * namespace.cs: Remove #ifdef GMCS_SOURCE.
5288 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
5289 MCS TypeManager has a corresponding dummy method.
5291 2006-09-19 Martin Baulig <martin@ximian.com>
5293 * expression.cs: Completely merged with the gmcs version.
5295 2006-09-19 Martin Baulig <martin@ximian.com>
5297 * expression.cs (Invocation): Merged with the gmcs version.
5298 (ArrayAccess.GetStoreOpcode): Likewise.
5300 2006-09-19 Martin Baulig <martin@ximian.com>
5303 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
5304 (TypeManager.IsGenericMethodDefinition): Likewise.
5306 2006-09-19 Martin Baulig <martin@ximian.com>
5309 (TypeManager.IsEqual): Moved the gmcs implementation here.
5310 (TypeManager.DropGenericTypeArguments): Likewise.
5311 (TypeManager.DropGenericMethodArguments): Likewise.
5312 (TypeManager.GetTypeArguments): Moved here from gmcs.
5313 (TypeManager.HasGenericArguments): Likewise.
5315 2006-09-19 Martin Baulig <martin@ximian.com>
5317 * expression.cs (Binary): Merged with the gmcs version.
5319 2006-09-19 Martin Baulig <martin@ximian.com>
5321 * expression.cs (Probe, As, Is): Merged with the gmcs version.
5323 2006-09-19 Martin Baulig <martin@ximian.com>
5325 * typemanager.cs: Merged with the gmcs version.
5327 2006-09-16 Raja R Harinath <rharinath@novell.com>
5329 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
5330 * driver.cs: Likewise.
5332 2006-09-16 Marek Safar <marek.safar@seznam.cz>
5335 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
5336 only if parent type is class.
5337 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
5340 2006-09-15 Marek Safar <marek.safar@seznam.cz>
5343 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
5345 * typemanager.cs(CSharpName): Converts NullType to null.
5347 2006-09-15 Martin Baulig <martin@ximian.com>
5350 (TypeManager.GetMethodName): Added mcs implementation.
5351 (TypeManager.IsEqual): Likewise.
5354 (SimpleName.RemoveGenericArity): Added dummy implementation.
5356 * pending.cs: Merged with the gmcs version.
5358 2006-09-15 Martin Baulig <martin@ximian.com>
5360 * statement.cs: Merge with the gmcs version.
5362 2006-09-15 Martin Baulig <martin@ximian.com>
5364 * statement.cs (Switch): Merge with the gmcs implementation
5365 (without nullables), which is newer.
5367 2006-09-15 Martin Baulig <martin@ximian.com>
5369 * statement.cs (Block.Variables): Make this public.
5370 (ToplevelBlock.Parameters): Make this a property.
5371 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
5373 2006-09-15 Martin Baulig <martin@ximian.com>
5375 * namespace.cs: Merge with the gmcs version.
5377 2006-09-15 Martin Baulig <martin@ximian.com>
5379 * decl.cs (MemberName): Minor code cleanups.
5381 2006-09-15 Martin Baulig <martin@ximian.com>
5383 * parameter.cs: Merge with the gmcs version.
5385 2006-09-15 Martin Baulig <martin@ximian.com>
5387 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
5388 and an error in mcs.
5390 2006-09-15 Martin Baulig <martin@ximian.com>
5392 * flowanalysis.cs: Merged from GMCS; added the generics code into
5393 a `GMCS_SOURCE' conditional so we can share this file.
5395 2006-09-08 Martin Baulig <martin@ximian.com>
5397 * typemanager.cs (TypeManager.interlocked_type): New public field.
5398 (TypeManager.int_interlocked_compare-exchange): New public field.
5399 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
5400 enumerator types here and call InitGenericCoreTypes().
5401 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
5402 after calling InitEnumUnderlyingTypes().
5405 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
5406 `classes_second_stage'.
5408 2006-09-14 Marek Safar <marek.safar@seznam.cz>
5410 * assign.cs, ecore.cs, expression.cs: Share error message text.
5411 * class.cs (FieldMember.Define): Check for varible of static type.
5412 * driver.cs (LoadAssembly): Uses error output for errors.
5413 * statement.cs: Updated.
5415 2006-09-08 Marek Safar <marek.safar@seznam.cz>
5417 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
5420 2006-09-07 Martin Baulig <martin@ximian.com>
5423 (MainDriver): Revert r62663 from Marek; see #70506 for details.
5425 2006-08-29 Miguel de Icaza <miguel@novell.com>
5427 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
5429 2006-08-17 Miguel de Icaza <miguel@novell.com>
5431 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
5432 #52019 and #79064, the use of the \uXXXX sequence in source code
5433 to represent unicode characters.
5435 2006-08-15 Marek Safar <marek.safar@seznam.cz>
5437 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
5439 * class.cs, ecore.cs, statement.cs: Merged to one error message.
5441 2006-08-13 Miguel de Icaza <miguel@novell.com>
5443 * assign.cs: Catch attempts to assign to a method groups in += and
5446 2006-08-13 Marek Safar <marek.safar@seznam.cz>
5449 * cs-parser.jay: Don't destroy current array type by typeof of array's.
5451 2006-08-12 Marek Safar <marek.safar@seznam.cz>
5453 * class.cs (Method.Define): Issue a warning when generic method looks like
5455 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
5458 2006-08-09 Marek Safar <marek.safar@seznam.cz>
5460 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
5462 * decl.cs (MemberCache.FindMembers): When container is interface we need to
5463 search all base interfaces as a member can be ambiguous.
5464 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
5465 Constructor member type filter.
5466 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
5467 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
5468 reporting for returned memberinfos.
5469 * report.cs: Updated.
5470 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
5471 version to work on all runtimes.
5472 (TypeManager.RealMemberLookup): Removed members filtering.
5474 2006-08-08 Raja R Harinath <rharinath@novell.com>
5476 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
5477 (PropertyExpr.EmitAssign): Likewise.
5478 * expression.cs (Indirection.EmitAssign): Likewise.
5479 (LocalVariableReference.EmitAssign): Likewise.
5480 (ParameterReference.EmitAssign): Likewise.
5481 (Invocation.EmitArguments): Likewise.
5482 (ArrayAccess.EmitAssign): Likewise.
5483 (IndexerAccess.EmitAssign): Likewise.
5484 (This.EmitAssign): Likewise.
5485 (ConditionalLogicalOperator.Emit): Likewise.
5488 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
5489 instead of ArrayList. If the hashtable has a LocalBuilder, don't
5490 leave it in after returning it.
5491 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
5493 2006-08-06 Marek Safar <marek.safar@seznam.cz>
5495 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
5498 2006-08-03 Raja R Harinath <rharinath@novell.com>
5500 Fix cs0146-3.cs and cs0146-4.cs.
5501 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
5502 enclosing types don't depend on the current type.
5504 2006-08-02 Raja R Harinath <rharinath@novell.com>
5507 * class.cs (TypeContainer.DoDefineMembers): Use
5508 FindBaseMemberWithSameName on Parent, since we're interested in
5509 whether we hide inherited members or not.
5510 (FindBaseMemberWithSameName): Make slightly more robust.
5512 Fix the non-generic testcase from #77396
5513 * decl.cs (DeclSpace.DeclContainer): Remove override.
5515 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
5516 declspaces for doppelgangers too.
5517 (UsingEntry): Implement IResolveContext.
5518 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
5519 'this' as the resolve context.
5520 (LocalAliasEntry): Likewise.
5522 Implement parts of #77403
5523 * roottypes.cs (RootDeclSpace): New. Used to represent the
5524 toplevel declaration space. Each namespace declaration introduces
5525 a "partial" root declaretion space.
5526 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
5527 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
5528 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
5529 from 'current_namespace.SlaveDeclSpace'.
5530 (namespace_declaration): Likewise.
5531 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
5532 check. It can't happen now.
5533 * decl.cs (DeclSpace.LookupType): Likewise.
5534 * driver.cs (MainDriver): Sanity check.
5536 2006-08-01 Raja R Harinath <rharinath@novell.com>
5538 * decl.cs (DeclSpace.FindNestedType): Remove.
5539 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
5540 LookupTypeContainer to get the container of the nested type.
5541 * class.cs (TypeContainer.FindNestedType): Make non-override.
5543 2006-07-31 Raja R Harinath <rharinath@novell.com>
5545 * decl.cs (DeclSpace.PartialContainer): Move field from ...
5546 * class.cs (TypeContainer.PartialContainer): ... here.
5547 (TypeContainer.AddBasesForPart): New helper.
5548 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
5550 * cs-parser.jay (current_class): Convert to DeclSpace.
5551 (struct_declaration, interface_declaration, class_declaration):
5552 Use AddBasesForPart instead of .Bases directly.
5553 * const.cs, iterators.cs: Update to changes.
5555 2006-07-28 Raja R Harinath <rharinath@novell.com>
5557 * class.cs (TypeContainer.AddMemberType): Rename from
5559 (TypeContainer.AddMember): Rename from AddToMemberContainer.
5560 (AddTypeContainer): New. Combine AddClassOrStruct and
5562 (AddPartial): Update. Add 'is_partial' argument.
5563 * roottypes.cs: Update to changes.
5564 * cs-parser.jay (push_current_class): New helper for handling
5565 current_container and current_class.
5566 (struct_declaration, interface_declaration, class_declaration):
5569 2006-07-26 Raja R Harinath <rharinath@novell.com>
5571 * roottypes.cs: Rename from tree.cs.
5573 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
5574 * tree.cs (Tree, ITreeDump): Remove types.
5575 * rootcontext.cs (tree, Tree): Remove fields.
5576 (root, ToplevelTypes): New.
5577 * *.cs: Update to rename.
5579 * tree.cs (Tree.RecordDecl): Remove.
5580 (RootTypes.AddToTypeContainer): Record the toplevel type in its
5582 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
5584 2006-07-23 Raja R Harinath <harinath@gmail.com>
5586 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
5587 DoFlowAnalysis and OmitStructFlowAnalysis here.
5588 (ec.With): Rename from WithUnsafe and generalize.
5589 (ec.WithCheckState): Remove. All users can be handled by 'With'.
5590 (ec.WithFlowAnalyis): New.
5591 * ecore.cs, expression.cs, statement.cs: Update.
5593 2006-07-22 Raja R Harinath <harinath@gmail.com>
5595 * statement.cs (Block.ResolveMeta): Simplify slightly.
5597 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
5598 multiple boolean fields. Convert InUnsafe, constant_check_state,
5599 check_state to flags.
5600 (CheckState, ConstantCheckState): Update.
5601 (InUnsafe): New read-only property.
5602 (FlagsHandle): Rename from CheckStateHandle and convert to handle
5604 (WithUnsafe): New helper similar to WithCheckState.
5605 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
5606 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
5608 2006-07-21 Raja R Harinath <rharinath@novell.com>
5610 Make comparisons use the same IL irrespective of whether they're
5611 in a 'checked' or 'unchecked' context: one of the issues in #78899
5612 * codegen.cs (EmitContext.CheckState): Make read-only property.
5613 (EmitContext.ConstantCheckState): Likewise.
5614 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
5615 helper that implement a save/restore stack for CheckState
5616 values. This is the only way to change check-state.
5617 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
5618 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
5619 (CheckedExpr.EmitBranchable): New forwarding method.
5620 (UnCheckedExpr): Likewise.
5621 * statement.cs (Block.ResolveMeta): Use WithCheckState.
5622 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
5623 (Checked.Resolve, checked.DoEmit): Likewise.
5625 2006-07-20 Miguel de Icaza <miguel@novell.com>
5627 * anonymous.cs: Cache the resolved anonymous delegate, and return
5628 this so that the ResolveTopBlock is only triggered once, not
5631 Currently we trigger ResolvetopBlock twice due to a first pass of
5632 argument check compatibility, and a second pass that does the
5635 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5637 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
5639 * rootcontext.cs (Reset): Add helper_classes.
5641 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5644 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
5647 2006-07-13 Miguel de Icaza <miguel@novell.com>
5649 * statement.cs (Lock): Handle expressions of type
5650 TypeManager.null_type specially. Fixes #78770
5652 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5654 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
5657 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5659 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
5660 for accessors as well.
5661 * ecore.cs (EventExpr): Add AccessorTable.
5663 2006-07-01 Marek Safar <marek.safar@seznam.cz>
5666 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
5667 for CS0122 where appropriate.
5668 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
5670 (Filter): Assembly can be null in the case of top level attributes.
5672 2006-06-25 Marek Safar <marek.safar@seznam.cz>
5676 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
5677 is done at global level.
5679 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5681 A fix for #77002, Implemented TypeForwarder support.
5683 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
5684 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
5685 * typemanager.cs (): Add type_forwarder_attr_type.
5687 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5689 * report.cs: Add CS0469 warning.
5691 2006-06-21 Martin Baulig <martin@ximian.com>
5693 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
5694 the `try'-block, so we also report CS0016 etc. there.
5696 2006-06-21 Martin Baulig <martin@ximian.com>
5699 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
5701 2006-06-21 Martin Baulig <martin@ximian.com>
5703 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
5704 also report CS1686 for parameters.
5706 2006-06-21 Martin Baulig <martin@ximian.com>
5708 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
5709 instead of an error if the value is not implicitly convertible to
5710 the switch types; fixes #77964.
5712 2006-06-21 Raja R Harinath <rharinath@novell.com>
5715 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
5716 FieldBuilder is null.
5719 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
5720 'left' and 'right' before error-checking.
5722 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
5724 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
5726 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
5727 (FieldExpr.DoResolve): likewise.
5728 (PropertyExpr.InstanceResolve): likewise.
5729 (EventExpr.InstanceResolve): likewise.
5731 2006-06-04 Marek Safar <marek.safar@seznam.cz>
5733 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
5734 attribute applicable tests for attribute argument.
5736 2006-06-02 Raja R Harinath <rharinath@novell.com>
5739 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
5740 (Binary.OverloadResolve_PredefinedIntegral): New.
5741 (Binary.OverloadResolve_PredefinedFloating): New.
5742 (Binary.OverloadResolve_PredefinedString): New.
5743 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
5744 Follow the standard more closely, and treat numeric promotions in
5745 terms of overload resolution.
5746 (Binary.CheckShiftArguments): Simplify.
5748 2006-06-01 Raja R Harinath <rharinath@novell.com>
5750 * flowanalysis.cs (MyBitVector): Simplify representation.
5751 (MyBitVector.Clone): Avoid allocating BitArray.
5752 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
5753 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
5754 (*): Update. Change all references to MyBitVector.And and
5755 MyBitVector.Or to &= and |=.
5757 2006-05-29 Raja R Harinath <rharinath@novell.com>
5760 * cs-parser.jay (formal_parameter_list): Extend the pattern below
5761 to param arguments too.
5763 2006-05-26 Miguel de Icaza <miguel@novell.com>
5765 * cs-parser.jay: Catch another parsing form for arglist being
5766 followed by other arguments. Fixes #78313.
5768 2006-05-24 Raja R Harinath <rharinath@novell.com>
5770 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
5771 checking of out parameters to ...
5772 (FlowBranchingToplevel.Merge): ... here.
5773 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
5774 set, propagate the origin upward, and only complain if there was
5776 (FlowBranchingException.AddContinueOrigin): Likewise.
5777 (FlowBranchingException.AddReturnOrigin): Likewise.
5778 (FlowBranchingException.AddGotoOrigin): Likewise.
5780 2006-05-23 Raja R Harinath <rharinath@novell.com>
5782 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
5783 unreachable, skip it.
5784 (FlowBranchingException.Merge): Always propagate jumps, even if
5785 the finally block renders subsequent code unreachable.
5787 2006-05-18 Raja R Harinath <rharinath@novell.com>
5790 * statement.cs (Goto.Resolve): Move responsibility for resolving
5791 'goto' to FlowBranching.AddGotoOrigin.
5792 (Goto.SetResolvedTarget): New. Callback to set the
5793 LabeledStatement that's the target of the goto.
5794 (Goto.DoEmit): Use Leave instead of Br when crossing an
5795 unwind-protect boundary.
5796 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
5797 LookupLabel and adjust to new semantics.
5798 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
5799 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
5800 Goto.SetResolvedTarget to update target.
5801 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
5802 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
5803 AddBreakOrigin & co. Delay propagation until ...
5804 (FlowBranchingException.Merge): ... this.
5806 * statement.cs (Block.Resolve): Always depend on flow-branching to
5807 determine unreachability. Kill workaround that originally emitted
5808 only one statement after an "unreachable" label (see infloop in
5811 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
5812 This is still "wrong", but anything better would probably need a
5813 multi-pass algorithm.
5814 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
5815 usage vector. Force current usage vector to be reachable, to
5816 optimistically signify backward jumps.
5817 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
5819 (FlowBranchingLabeled.Merge): New. If no backward jump was
5820 detected, return the original salted-away usage vector instead,
5821 updated with appropriate changes. Print unreachable warning if
5823 * statement.cs (Block.Resolve): Don't print unreachable warning on
5824 a labeled statement.
5826 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
5828 * driver.cs: Pass filename without path to AssemblyBuilder's
5829 AddResourceFile. Fixes bug #78407.
5831 2006-05-17 Raja R Harinath <rharinath@novell.com>
5833 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
5834 * flowanalysis.cs (FlowBranchingLabeled): ... here.
5835 (FlowBranching.MergeChild): Overwrite
5836 reachability information from Labeled branchings too.
5838 2006-05-16 Raja R Harinath <rharinath@novell.com>
5840 * statement.cs (Goto.Resolve): Merge jump origins here ...
5841 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
5843 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
5844 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
5845 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
5846 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
5848 * statement.cs (Goto.Resolve): ... not here.
5849 (Goto.Emit): Remove CS1632 check.
5851 2006-05-14 Marek Safar <marek.safar@seznam.cz>
5853 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
5856 2006-05-11 Raja R Harinath <rharinath@novell.com>
5858 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
5859 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
5860 (FlowBranchingException.Label): Likewise.
5862 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
5864 (MyBitVector.Or): Use it to avoid losing information (Count).
5865 (FlowBranching.MergeOrigins): Likewise.
5867 * flowanalysis.cs (UsageVector.IsDirty): Remove.
5868 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
5869 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
5870 (UsageVector.ToString): Simplify.
5871 (UsageVector.MergeSiblings): Move here from ...
5872 (FlowBranching.Merge): ... here.
5873 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
5876 2006-05-10 Raja R Harinath <rharinath@novell.com>
5878 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
5879 null bitvector is treated as all-true.
5881 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
5882 (MyBitVector): Rationalize invariants. 'vector != null' implies
5883 that we have our own copy of the bitvector. Otherwise,
5884 'InheritsFrom == null' implies all inherited bits are true.
5886 2006-05-09 Marek Safar <marek.safar@seznam.cz>
5888 * statement.cs (LocalInfo): Add IsConstant.
5889 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
5890 local variable for constants.
5892 2006-05-09 Raja R Harinath <rharinath@novell.com>
5894 * flowanalysis.cs (MyBitVector.Empty): New.
5895 (MyBitVector): Don't allow InheritedFrom to be null.
5896 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
5897 (UsageVector, FlowBranching): Update to changes.
5899 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
5900 recursion. The 'Parent == null' condition isn't sufficient for
5902 (FlowBranching.AddBreakOrigin): Likewise.
5903 (FlowBranching.AddContinueOrigin): Likewise.
5904 (FlowBranching.AddReturnOrigin): Likewise.
5905 (FlowBranching.StealFinallyClauses): Likewise.
5906 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
5907 (FlowBranching.CheckOutParameters): Likewise.
5908 (FlowBranchingToplevel): Terminate all the above recursions here.
5909 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
5910 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
5912 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
5914 (FlowBranchingToplevel): New. Empty for now.
5915 (FlowBranching.MergeTopBlock): Update.
5916 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
5917 branching for the anonymous delegate.
5918 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
5920 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
5921 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
5922 information at the start of the merge. Reorganize.
5924 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5926 * class.cs (MethodData.Define): Method cannot implement interface accessor.
5928 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5930 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
5931 to newly introduced ctor.
5933 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
5934 message to one place.
5935 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
5938 2006-05-07 Marek Safar <marek.safar@seznam.cz>
5940 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
5942 * ecore.cs (Expression.ResolveAsConstant): Updated.
5944 * statement.cs (ResolveMeta): Updated.
5946 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5948 * cs-parser.jay: __arglist cannot be used in initializer.
5950 2006-05-06 Marek Safar <marek.safar@seznam.cz>
5953 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
5956 2006-05-05 Raja R Harinath <rharinath@novell.com>
5958 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
5959 (LabeledStatement): Add 'name' parameter.
5960 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
5961 (Block.AddLabel): Update to changes.
5962 * cs-parser.jay (labeled_statement): Likewise.
5964 * flowanalysis.cs (BranchingType.Labeled): New.
5965 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
5966 (FlowBranchingLabeled): New. Does nothing for now, but will
5967 eventually handle 'goto' flows.
5968 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
5969 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
5970 that's terminated ...
5971 (Block.Resolve): ... here.
5973 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
5974 (UsageVector.MergeFinallyOrigins): Likewise.
5975 (FlowBranching.InTryOrCatch): Likewise.
5976 (FlowBranching.AddFinallyVector): Likewise.
5977 (FlowBranchingException): Update to changes.
5980 * statement.cs (Return.Resolve): Move error checking to ...
5981 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
5982 (FlowBranchingException): Handle return origins like break and
5984 (FlowBranching.UsageVector.CheckOutParameters): Remove.
5986 2006-05-04 Marek Safar <marek.safar@seznam.cz>
5989 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
5992 2006-05-04 Marek Safar <marek.safar@seznam.cz>
5995 * class.cs (MethodData.Define): Do public accessor check only when method
5996 implements an interface.
5998 2006-05-04 Raja R Harinath <rharinath@novell.com>
6000 Remove special handling of 'break'
6001 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
6002 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
6003 (UsageVector.Break): Remove.
6004 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
6006 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
6008 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
6009 UsageVector.Breaks (). Don't set NeedsReturnLabel.
6011 2006-05-03 Marek Safar <marek.safar@seznam.cz>
6014 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
6015 be the interface member.
6017 2006-05-03 Marek Safar <marek.safar@seznam.cz>
6020 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
6021 for emitting small (int) values.
6023 2006-05-03 Raja R Harinath <rharinath@novell.com>
6026 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
6027 control-flow passes through the 'finally' after merging-in all the
6028 control-flows from 'try' and the 'catch' clauses.
6030 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
6031 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
6032 always true at the only non-recursive entry point.
6033 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
6034 FlowBranchingBreakable.
6035 (FlowBranchingLoop): Remove.
6036 * statement.cs (Return.DoResolve): Update to changes.
6039 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
6040 (FlowBranching.CreateBranching): Handle it: create a
6041 FlowBranchingContinuable.
6042 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
6043 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
6044 except that it handles the 'continue' command.
6045 (FlowBranching.UsageVector.MergeOrigins): Rename from
6047 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
6048 except that it overrides AddContinueOrigin.
6049 (FlowBranchingException): Override AddContinueOrigin, similar to
6051 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
6052 Create a new branching around the embedded statement.
6053 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
6054 control flow after the embedded statement.
6055 (Continue.Resolve): Move all error checking to AddContinueOrigin.
6057 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
6058 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
6059 FlowBranchingBreakable.
6060 (FlowBranchingSwitch): Remove.
6063 * statement.cs (Break.Resolve): Simplify. Move responsibility for
6064 error reporting to ...
6065 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
6066 Rename from 'AddBreakVector'. Add new location argument. Return
6067 a bool indicating whether the 'break' crosses an unwind-protect.
6068 (FlowBranchingException.AddBreakOrigin): Add.
6069 (FlowBranchingException.Merge): Propagate 'break's to surrounding
6070 flowbranching after updating with the effects of the 'finally'
6072 (FlowBranchingBreakable): New common base class for
6073 FlowBranchingLoop and FlowBranchingSwitch.
6075 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
6077 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
6079 2006-05-02 Raja R Harinath <rharinath@novell.com>
6081 * statement.cs (Do.Resolve): If the loop is infinite, set the
6083 (While.Resolve, For.Resolve): Set a barrier after the embedded
6084 statement. There's no direct control flow that goes from the end
6085 of the embedded statement to the end of the loop.
6086 * flowanalysis.cs (FlowBranching.Infinite): Remove.
6087 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
6088 above ensure that the reachability is correctly computed.
6090 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
6091 (UsageVector.MergeBreakOrigins): If the current path is
6092 unreachable, treat it as if all parameters/locals are initialized.
6093 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
6094 infinite loops before merging-in break origins.
6096 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
6097 (Reachability.Reachable): Split part into ...
6098 (Reachability.Unreachable): ... this. Simplify.
6099 (Reachability.IsUnreachable): Use 'Unreachable' instead.
6101 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
6102 (Reachability.SetThrowsSometimes): Likewise.
6103 (FlowBranchingBlock.MergeTopBlock): Don't compare against
6104 TriState.Always, use corresponding property.
6105 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
6106 (Block.Resolve): Likewise. Remove some redundant checks.
6108 2006-05-02 Raja R Harinath <harinath@gmail.com>
6110 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
6111 (Reachability.Meet): Don't bother checking AlwaysThrows --
6112 barrier is always set.
6113 (FlowBranchingBlock.Merge): Likewise.
6115 2006-05-01 Raja R Harinath <harinath@gmail.com>
6117 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
6118 checks for unreachable.
6120 2006-05-01 Marek Safar <marek.safar@seznam.cz>
6123 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
6125 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
6126 whether field is really assigned.
6128 2006-04-30 Raja R Harinath <harinath@gmail.com>
6130 * flowanalysis.cs (Reachability): Make 4-argument constructor
6132 (Reachability.Meet): Rename from 'And'. Remove static variant.
6133 (Reachability.Always): Rename from the highly misleading
6134 'Reachability.Never'.
6135 (FlowBranching.Merge): Update to changes. Mark an impossible
6136 situation with a 'throw'.
6137 (*): Update to changes.
6139 2006-04-29 Raja R Harinath <harinath@gmail.com>
6141 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
6143 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
6144 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
6145 (*): Update to changes.
6146 * statement.cs: Update to changes.
6148 2006-04-28 Marek Safar <marek.safar@seznam.cz>
6151 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
6153 2006-04-28 Raja R Harinath <harinath@gmail.com>
6155 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
6158 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
6159 argument to two arguments: an usage-vector and a bool. Move call
6160 to FlowBranching.Merge () ...
6161 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
6163 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
6164 handling of loop and switch reachability to ...
6165 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
6167 2006-04-27 Raja R Harinath <harinath@gmail.com>
6169 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
6170 handling to FlowBranchingLoop.InLoop.
6171 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
6173 2006-04-26 Marek Safar <marek.safar@seznam.cz>
6176 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
6177 anonymous method is allowed from AnonymousContainer here.
6179 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
6181 2006-04-24 Raja R Harinath <rharinath@novell.com>
6184 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
6186 2006-04-23 Marek Safar <marek.safar@seznam.cz>
6189 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
6190 (DoubleConstant.Reduce): Ditto.
6192 2006-04-23 Raja R Harinath <rharinath@novell.com>
6194 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
6195 Remove 'lvalue_right_side' argument. Move parts to ...
6196 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
6197 (LocalVariable.DoResolveLValue): ... these.
6199 2006-04-21 Raja R Harinath <rharinath@novell.com>
6202 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
6203 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
6204 (LocalVariableReference.DoResolveBase): Use it to implement new
6206 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
6207 (Argument.Resolve): Simplify. Move CS1510 check ...
6208 * ecore.cs (Expression.ResolveLValue): ... here.
6209 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
6210 (PropertyExpr.DoResolveLValue): Likewise.
6211 (FieldExpr.Report_AssignToReadonly): Likewise.
6212 (FieldExpr.DoResolve): Add 'out_access' argument. Use
6213 LValueMemberAccess or LValueMemberOutAccess on instance depending
6215 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
6216 DoResolve as appropriate.
6218 2006-04-20 Raja R Harinath <rharinath@novell.com>
6221 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
6222 implicit conversions on 'out' and 'ref' arguments.
6224 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
6225 improve clarity. Remove dead code.
6228 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
6229 (Catch.Resolve): Resolve VarBlock if it exists.
6231 2006-04-19 Miguel de Icaza <miguel@novell.com>
6233 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
6234 twice, this was some residual code, the enumerator was emitted
6235 properly in the two branche of if later.
6237 2006-04-19 Raja R Harinath <rharinath@novell.com>
6239 * expression.cs (Cast.ResolveLValue): Remove. The result of a
6240 cast is never an lvalue.
6241 (Cast.DoResolve, Cast.ResolveRest): Combine.
6242 (Argument.Emit): Simplify slightly. Move 'Expr is
6243 IMemoryLocation' check ...
6244 (Argument.Resolve): ... here.
6245 (Argument.Error_LValueRequired): Remove. Inline into only user.
6247 Simplifications. Fix cs0191-2.cs
6248 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
6249 CS1649 and CS1651 to ...
6250 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
6251 the actual selection of the error code and message to a lookup
6252 table. Add a dummy return value to simplify callsites.
6253 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
6254 readonly fields of other instances of the same type. Move CS0197
6256 * expression.cs (Argument.Resolve): ... here. Simplify code.
6257 Ensure that ec.InRefOutArgumentResolving is only set during LValue
6258 resolution of an out or ref argument. The code simplification
6259 above uses this invariant.
6261 2006-04-18 Raja R Harinath <rharinath@novell.com>
6263 Possibly fix #77752. Fix cs1690-[4-7].cs.
6264 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
6265 CheckMarshallByRefAccess. Drop parameter.
6266 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
6268 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
6270 * report.cs (AllWarnings): Add CS1690.
6271 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
6273 (LocalVariableReference.DoResolveBase): Update.
6275 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6277 * class.cs (MethodOrOperator): Moved common parts from method class.
6278 detect obsolete attributes.
6279 (Method.Define): Simplified as it reuses code from base.
6280 (Constructor.ValidAttributeTargets): Fixed issue found during
6282 (Destructor.ValidAttributeTargets): Fixed issue found during
6284 (Operator): Finished refactoring set off by #78020. Operator class is now
6285 ordinary method class.
6287 * anonymous.cs: Updated.
6289 * decl.cs (DeclSpace): Add IsGeneric
6291 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6293 * class.cs (Constructor.Emit): Don't emit the attributes twice.
6295 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6297 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
6298 detect obsolete attributes.
6299 (Method.CreateEmitContext): Moved to MethodOrOperator.
6301 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6304 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
6305 customized exception to make crash detection easier.
6306 (MethodOrOperator): Started to work on new base class for methods and
6308 (Method): Derives from MethodOrOperator.
6309 (Constructor.Emit): Emits its own attributes.
6310 (AbstractPropertyEventMethod.Emit): Ditto.
6311 (Operator): Derives from MethodOrOperator, will refactor fully in extra
6313 (Operator.Emit): It's temporary more tricky than should be.
6315 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
6317 * report.cs (InternalErrorException): Add ctor with inner exception.
6319 2006-04-08 Marek Safar <marek.safar@seznam.cz>
6322 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
6325 2006-04-07 Marek Safar <marek.safar@seznam.cz>
6328 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
6331 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6333 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
6334 attribute is present and Guid not.
6335 (Interface.ApplyAttributeBuilder): Ditto.
6337 * attribute.cs: Add error message.
6339 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6343 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
6344 sources (it's composite) so hold them in extra array as they are used in
6345 Emit phase only. It worked in the previous versions by mistake.
6346 (Attribute.Emit): Emit attribute for more owners when exist.
6348 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
6349 it has now different behaviour.
6351 2006-04-04 Marek Safar <marek.safar@seznam.cz>
6353 * constant.cs (Constant.IsDefaultInitializer): New method.
6355 * class.cs: Updated.
6357 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
6358 re-initialize default values. It saves KBs almost for every assembly.
6359 Thanks Zoltan for the idea.
6360 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
6361 (ArrayCreation.DoResolve): Resolve only once.
6362 (ArrayCreation.Emit): Emit static initializer only when it is faster.
6363 (ArrayCreation.GetAttributableValue): Cope with optimized values.
6365 2006-04-03 Zoltan Varga <vargaz@gmail.com>
6367 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
6370 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6372 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
6373 in an embedded statement too.
6375 2006-04-01 Raja R Harinath <rharinath@novell.com>
6378 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
6380 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6384 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
6387 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
6389 2006-03-31 Marek Safar <marek.safar@seznam.cz>
6391 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
6394 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
6395 LocalTemporary change.
6397 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
6399 (ClassOrStruct.DefineFieldInitializers): Implemented static field
6400 initializers optimization.
6401 (ClassOrStruct.TypeAttr): Moved from modifiers.
6402 (Constructor.CheckBase): Don't crash when static ctor has parameters.
6403 (FieldBase.ResolveInitializer): Resolves initializer.
6404 (FieldBase.HasDefaultInitializer): New property.
6406 * cs-parser.jay: Removed message.
6408 * expression.cs (CompilerGeneratedThis): New specialization.
6410 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
6412 2006-03-28 Marek Safar <marek.safar@seznam.cz>
6414 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
6416 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6418 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
6419 be now EnumConstants only.
6421 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6423 * attribute.cs, driver.cs: Reset more caches.
6425 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6427 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
6429 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6431 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
6432 for easier reuse. Updated all overrides.
6433 (IntegralConstant): New base class for all integral constants.
6434 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
6435 of the constant range, report custom error.
6436 (UIntConstant.Reduce): Fixed uint conversion.
6438 * ecore.cs, literal.cs: Reduce updates.
6440 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6444 * class.cs (Constructor.Define): Removed extra if for default ctors.
6445 A patch from Atsushi Enomoto.
6447 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6449 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
6450 GetAttributableValue.
6452 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
6455 * convert.cs (ImplicitConversionRequired): Error message moved to
6458 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
6459 automatic implicit conversion of an output value.
6460 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
6462 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
6464 (TypeOf.GetAttributableValue): Add extra handling for object type.
6466 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
6467 special error message.
6469 2006-03-25 Marek Safar <marek.safar@seznam.cz>
6471 * class.cs (Constructor.Emit): Don't crash when struct ctor is
6473 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
6474 compatible with MS runtime.
6476 2006-03-23 Marek Safar <marek.safar@seznam.cz>
6478 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
6479 attribute arguments here.
6481 * class.cs (Indexer.Define): The check was moved to attribute class.
6483 2006-03-22 Marek Safar <marek.safar@seznam.cz>
6485 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
6486 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
6489 2006-03-22 Raja R Harinath <rharinath@novell.com>
6491 Support ParameterDefaultValueAttribute in gmcs. Also applied to
6492 mcs to keep code differences small.
6493 * attribute.cs (Attribute.GetParameterDefaultValue): New.
6494 * typemanager.cs (parameter_default_value_attribute_type): New.
6495 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
6498 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6500 * expression.cs (StringConcat.Append): Reverted back to no warning state.
6502 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6504 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
6506 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
6509 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
6511 * doc-bootstrap.cs : fix build.
6513 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6515 * expression.cs (StringConcat.Append): Issue a warning when empty string
6518 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6520 * assign.cs (CompoundAssign.ResolveSource): Removed.
6522 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
6525 * class.cs (TypeContainer.FindMethods): Removed.
6526 (TypeContainer.CheckMemberUsage): Made static.
6528 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
6530 * constant.cs (CheckRange): Removed unused type argument.
6531 (CheckUnsigned): Removed unused type argument.
6533 * cs-parser.jay: Updated after MemberAccess clean up.
6534 Uses Length for empty string test.
6536 * cs-tokenizer.cs: Uses Length for empty string test.
6537 (IsCastToken): Made static.
6538 (is_hex): Made static.
6539 (real_type_suffix): Made static.
6541 * decl.cs (SetupCache): Made static.
6542 (OnGenerateDocComment): Removed unused ds argument.
6544 * delegate.cs (VerifyDelegate): Removed unused argument.
6546 * doc.cs: Uses Length for empty string test.
6548 * driver.cs: Uses Length for empty string test.
6550 * enum.cs (IsValidEnumType): Made static
6552 * expression.cs (EnumLiftUp): Removed unused argument.
6553 (ResolveMethodGroup): Ditto.
6554 (BetterConversion): Ditto.
6555 (GetVarargsTypes): Ditto.
6556 (UpdateIndices): Ditto.
6557 (ValidateInitializers): Ditto.
6558 (MemberAccess.ctor): Ditto.
6559 (GetIndexersForType): Ditto.
6561 * flowanalysis.cs: (MergeFinally): Removed unused argument.
6563 * iterators.cs: Updated after MemberAccess clean up.
6565 * location.cs: Uses Length for empty string test.
6567 * namespace.cs: Uses Length for empty string test.
6569 * report.cs (CheckWarningCode): Made static.
6571 * statement.cs (LabeledStatement): Removed unused argument.
6573 * typemanager.cs (FilterNone): Removed.
6575 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6577 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
6580 * class.cs: Updated.
6582 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6584 * cs-parser.jay.cs: __arglist is not allowed for delegates.
6586 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6590 * expression.cs (VerifyArgumentsCompat): Reverted to double error
6591 reporting, it's more tricky than I thought.
6593 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6597 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
6599 (AnonymousMethod.ImplicitStandardConversionExists): New method.
6600 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
6601 Add more error reporting; Fixed issue with params.
6603 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
6605 * cs-parser.jay: AnonymousMethod requires host container.
6607 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
6609 2006-03-18 Raja R Harinath <harinath@gmail.com>
6611 * class.cs: Change 'TypeContainer ds' constructor argument to
6612 'DeclSpace parent'. Some classes were missed below due to
6613 different naming convention.
6615 * class.cs (MemberCore.Parent): Delete. This makes the
6616 ParentContainer changes below enforceable by the compiler.
6618 Treat pointers to enclosing declaration space as 'DeclSpace', not
6620 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
6621 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
6623 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
6625 (Block.AddThisVariable): Likewise.
6626 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
6627 (AbstractPropertyEventMethod.Emit): Likewise.
6628 (AbstractPropertyEventMethod.EmitMethod): Likewise.
6629 (GetMethod.Define, SetMethod.Define): Likewise.
6630 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
6631 (DelegateMethod.EmitMethod): Likewise.
6633 Fix regression test-partial-13.cs.
6634 Rationalize use of PartialContainer. Ensure that the partial
6635 class semantics can be tied to type-correctness, i.e., any
6636 violation will cause a compile error.
6637 * class.cs, const.cs: Access all fields that belong to class
6638 TypeContainer via ParentContainer. Arguments of EmitContexts and
6639 Resolve()-like functions still use 'Parent'.
6641 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
6642 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
6643 (PropertyMethod.CheckModifiers): Remove unused argument.
6644 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
6647 2006-03-17 Raja R Harinath <harinath@gmail.com>
6649 Make semantics of PartialContainer simpler.
6650 * decl.cs (DeclSpace.IsPartial): Remove.
6651 * class.cs (TypeContainer.IsPartial): Likewise.
6652 (TypeContainer..ctor): Set PartialContainer to point to self.
6653 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
6654 (TypeContainer.FindNestedType): Likewise.
6655 (MemberCore.ParentContainer): Simplify. Remove deprecation.
6657 2006-03-17 Marek Safar <marek.safar@seznam.cz>
6659 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
6661 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6663 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
6666 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6668 * class.cs (Operator.Define): An error for base conversion was not
6671 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
6673 * iterator.cs : yield break is allowed in try statement which has
6674 catch clauses. Fixed bug #77767.
6676 2006-03-13 Marek Safar <marek.safar@seznam.cz>
6678 A fix for #77593, #77574.
6680 * class.cs (MethodCore.CheckBase): Another if for operator.
6682 2006-03-09 Marek Safar <marek.safar@seznam.cz>
6684 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
6687 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
6688 (DelegateCreation.ImplicitStandardConversionExists): New method for just
6691 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
6694 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
6695 Updated after another emitcontext usage was clean up. It should help us to
6696 synchronize with gmcs easier.
6698 2006-03-04 Marek Safar <marek.safar@seznam.cz>
6702 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
6703 (Event.Define): ditto
6704 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
6706 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
6707 Removed redundant code and set NewSlot for Invoke method too.
6709 * parameter.cs (Parameters.ctor): Add custom, type ctor.
6710 (Parameters.MergeGenerated): New method. Use this method when you merge
6711 compiler generated argument with user arguments.
6713 2006-03-03 Marek Safar <marek.safar@seznam.cz>
6715 * attribute.cs (ResolveAsTypeTerminal): Removed.
6717 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
6718 specialization for predefined types; 30% speed up.
6719 Finally placed obsolete check to right place.
6720 (Expression.ResolveType): Removed.
6722 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
6723 Updated after ResolveType was removed.
6725 * expression.cs (Cast.ctor): Check void cast.
6726 (Binary.ResolveAsTypeTerminal): Is never type.
6727 (Conditional.ResolveAsTypeTerminal): Is never type.
6729 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
6731 2006-03-01 Raja R Harinath <rharinath@novell.com>
6734 * expression.cs (ParameterReference.DoResolveBase): Change return
6736 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
6740 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
6743 * typemanager.cs (GetFullNameSignature): Don't nullref on
6744 protected accessors.
6746 2006-02-27 Marek Safar <marek.safar@seznam.cz>
6748 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
6749 these two separated members to simplify the code.
6750 (Attribute.Resolve): Refactored to use new fields and methods.
6751 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
6752 implemented obsolete attribute checking.
6753 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
6754 implemented obsolete checking again. It look line never ending quest ;-)
6755 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
6757 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
6759 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
6761 *class.cs (Property.Define): Add RegisterProperty call.
6763 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
6764 argument groups (only 2).
6766 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
6767 encoding expression to arguments.
6768 (Expression.ExprClassToResolveFlags): Just turned to property.
6770 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
6771 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
6772 optimized as well as implemented support for zero-length attributes.
6774 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
6775 Add caching of PropertyInfo's.
6777 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6779 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
6780 error multiple times.
6782 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6784 New partial class implementation.
6785 A fix for #77027, #77029, #77403
6787 * attribute.cs (Attributable): Made attributes protected.
6789 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
6790 the replacements of ClassPart and PartialContainer.
6791 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
6792 (TypeContainer.AddInterface): Ditto.
6793 (TypeContainer.AddPartial): The main method for partial classes. It checks
6794 for errors and merges ModFlags and attributes. At the end class is added to
6796 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
6798 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
6799 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
6800 from the rest of partial classes.
6801 (TypeContainer.GetClassBases): Simplified.
6802 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
6804 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
6805 (TypeContainer.HasExplicitLayout): Uses Flags now.
6806 (PartialContainer): Removed.
6807 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
6808 (StaticClass): Was merged with Class.
6809 (Class.GetClassBases): class and static class bases are verified here.
6810 (Class.TypeAttr): Added static attributes when class is static.
6811 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
6812 (MemberBase): In some cases we need to call parent container for partial
6813 class. It should be eliminated but it's not easy now.
6815 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
6817 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
6818 partial classed to accumulate class comments.
6819 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
6821 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
6823 * driver.cs (MainDriver): Tree.GetDecl was removed.
6825 * modifiers.cs (Modifiers): Add partial modifier.
6827 * tree.cs (Tree.decl): Removed.
6828 (RootTypes): Started to use this class more often for root types
6831 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6835 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
6836 external interface does not have an attribute.
6838 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6840 Another prerequisites for new partial classs implementation.
6842 * attribute.cs (Attribute.Equal): Implemented.
6843 (Attribute.Emit): Changed as attributes can be applied more than twice.
6844 (Attributes.Emit): Check for duplicate attributes here.
6846 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
6847 as a parameter, clean-up.
6849 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6853 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
6854 contains obsolete attribute check which can in some cases look for base
6855 type of current class which is not initialized yet.
6856 (TypeContainer.BaseType): Replacement of ptype.
6858 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
6860 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6862 First of prerequisites for new partial classs implemention.
6864 * attribute.cs (Attributable): Extended by ResolveContext;
6865 Attributes finally have correct context for resolving in all cases.
6866 (AttachTo): Attribute owner is assigned here.
6868 * codegen.cs (IResolveContext): Introduce new interface to hold
6869 all information needed in resolving phase.
6870 (EmitContext): Implements IResolveContext; more clean-up needed here.
6872 * decl.cs (MemberCore): Implemented IResolveContext.
6874 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
6875 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
6876 parameter.cs, statement.cs, tree.cs, typemanager.cs:
6877 Refactored to use new IResolveContext instead of EmitContext; cleanup
6879 2006-02-06 Miguel de Icaza <miguel@novell.com>
6881 * codegen.cs (EmitScopeInitFromBlock): check here the
6882 capture_context, there is no need to make two calls to the
6885 * anonymous.cs: Add some debugging messages that might help me
6886 track other instances of this problem in the future (the
6887 regression of test 467).
6889 * cs-parser.jay: track the variable block, as we need to initalize
6890 any captured variables declared in this block for the "catch"
6891 portion of the "Try" statement.
6893 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
6894 scope initialization for captured variables.
6896 Also, move the emit for the variables after the block location has
6899 2006-02-06 Marek Safar <marek.safar@seznam.cz>
6901 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
6903 2006-02-02 Miguel de Icaza <miguel@novell.com>
6905 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
6906 commit yesterday, the initialization for the roots is necessary.
6907 What is not necessary is the scope activation.
6909 2006-02-02 Raja R Harinath <rharinath@novell.com>
6911 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
6912 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
6914 (Argument.Resolve): Remove CS0206 checks.
6916 2006-02-01 Miguel de Icaza <miguel@novell.com>
6918 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
6919 scopes for all the roots, the scopes will now be emitted when the
6920 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
6922 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
6923 code. This reduces a lot of existing cruft.
6925 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
6926 that the ScopeInfo is generated as we enter the scope, not at the
6927 time of use, which is what we used to do before.
6929 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
6930 every time a Block is about to be emitted if we have a
6933 2006-02-01 Raja R Harinath <rharinath@novell.com>
6935 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
6937 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
6939 * typemanager.cs (cons_param_array_attribute): Make private.
6940 (Reset): Set it to null.
6941 (InitCoreHelpers): Don't initialize it.
6942 (ConsParamArrayAttribute): New. Initialize it as needed.
6943 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
6945 2006-01-31 Miguel de Icaza <miguel@novell.com>
6947 * expression.cs: There might be errors reported during the
6948 selection of applicable methods. If there are errors, do not
6949 continue execution as it will lead the compiler to crash.
6951 2006-01-30 Miguel de Icaza <miguel@novell.com>
6953 * expression.cs: Member access is not allowed on anonymous
6954 methods. Fixes #77402.
6956 2006-01-30 Raja R Harinath <rharinath@novell.com>
6959 * cs-parser.jay (VariableDeclaration): Don't set
6960 current_array_type to null.
6961 (field_declaration, event_declaration, declaration_statement):
6962 Set it to null here.
6964 2006-01-28 Raja R Harinath <harinath@gmail.com>
6966 * typemanager.cs (GenericParameterPosition): New.
6969 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
6971 * doc.cs : To process "include" elements, first we should create
6972 another list than XmlNodeList, because it could result in node
6973 removal, which could result in that the XmlNodeList gives up
6976 (Also made code identical to gmcs again.)
6978 2006-01-25 Miguel de Icaza <miguel@novell.com>
6980 * ecore.cs: Introduce an error report that we were not catching
6981 before, if not silent, we must report the error. Gonzalo ran into
6984 2006-01-23 Miguel de Icaza <miguel@novell.com>
6986 A fix for bug: #76957
6988 * iterators.cs (MoveNextMethod.CreateMethodHost): call
6989 ComputeMethodHost before creating the method, this is a new
6992 * anonymous.cs (AnonymousContainer): Now we track all the scopes
6993 that this method references (RegisterScope). The actual scope
6994 where the method is hosted is computed with the ComputeMethodHost
6995 before we create the method.
6997 Moved the Deepest routine here.
6999 (AnonymousContainer.ComputeMethodHost): New routine used to
7000 compute the proper ScopeInfo that will host the anonymous method.
7002 (ScopeInfo): Deal with multiple roots. The problem was that we
7003 did not have a unique root where all ScopeInfos could be hanged
7004 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
7007 Remove AdjustMethodScope which is now computed at the end. Remove
7008 LinkScope which did a partial link, instead link all ScopeInfos
7009 before code generation from the new "LinkScopes" routine.
7011 Simplify all the Add* routines as they no longer need to maintain
7012 the tree, they just need to record that they are using variables
7015 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
7016 routines to produce the forest of ScopeInfo trees.
7018 * class.cs (TypeContainer.AppendMethod): This is just like
7019 AddMethod, but ensures that an interface implementation method
7020 (IEnumerable.XXX) is not inserted at the beginning of the queue of
7021 methods, but at the end.
7023 We use this functionality to ensure that the generated MoveNext
7024 method in the iterator class is resolved/emitted before the
7025 enumerator methods created.
7027 This is required because the MoveNext method computes the right
7028 ScopeInfo for the method. And the other methods will eventually
7029 need to resolve and fetch information computed from the anonymous
7032 2006-01-21 Raja R Harinath <harinath@gmail.com>
7033 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7036 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
7038 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
7039 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
7041 2006-01-18 Raja R Harinath <rharinath@novell.com>
7043 Fix #76656, cs0231-2.cs.
7044 * cs-parser.jay (formal_parameter_list): Make error case catch
7046 (parenthesized_expression_0): Add CS1026 check.
7047 (invocation_expression): Remove unused { $$ = lexer.Location }.
7049 2006-01-17 Raja R Harinath <rharinath@novell.com>
7052 * cs-parser.jay (statement_expression): Don't list out the
7053 individual statement-expressions. Convert syntax error into
7056 2006-01-16 Raja R Harinath <rharinath@novell.com>
7059 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
7060 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
7061 CheckIntermediateModification.
7062 (FieldExpr.DoResolve): Add new two-argument version that
7063 allows us to resolve the InstanceExpression as an lvalue.
7064 The one-argument variant is now just a wrapper.
7065 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
7066 Resolve the lhs as an lvalue if the it has a value type.
7067 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
7068 from Assign.DoResolve.
7069 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
7070 resolved as an lvalue.
7071 (PropertyExpr.DoResolve): Update.
7072 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
7073 has a value type. Move CS1612 check here from
7074 CheckIntermediateModification.
7075 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
7076 * expression.cs (EmptyExpression.OutAccess): New. Used as the
7077 'right_side' of a ResolveLValue on an 'out' argument.
7078 (EmptyExpression.LValueMemberAccess): New. Used as the
7079 'right_side' of a propagated ResolveLValue on a value type.
7080 (LocalVariableReference.DoResolveBase): Recognize
7081 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
7083 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
7084 EmptyExpression.Null.
7086 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
7088 * typemanager.cs : added IsGenericParameter(). In mcs it always
7090 * doc.cs : for generic parameters, use GenericParameterPosition,
7093 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
7095 * expression.cs: Fix Console.WriteLine ((this = x).foo);
7097 2006-01-12 Miguel de Icaza <miguel@novell.com>
7099 This fixes the problem where we used ldfld instead of ldflda to
7100 load the "THIS" pointer on captured parameters, when THIS is a
7101 value type. See bug #77205.
7103 * iterators.cs (CapturedThisReference.Emit): Pass false to
7104 EmitThis (we do not need the address).
7106 * codegen.cs (EmitThis): it needs to know whether we need the
7107 address of `this' or not. This is used by value types.
7109 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
7110 every other call passes false.
7112 2006-01-12 Raja R Harinath <rharinath@novell.com>
7115 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
7117 * expression.cs (Invocation.OverloadResolve): Update.
7118 (Invocation.DoResolve): Avoid double resolution of invocation.
7120 2006-01-11 Raja R Harinath <rharinath@novell.com>
7123 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
7124 unary negation of floating point types as 0-expr; negation cannot
7125 overflow in floating point types.
7128 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
7129 on operands of 'void' type.
7132 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
7133 and ExclusiveOr for boolean constants too.
7135 2006-01-09 Raja R Harinath <rharinath@novell.com>
7138 * expression.cs (Invocation.OverloadResolve): Replace reflected
7139 override methods with their base virtual methods, rather than
7141 * typemanager.cs (TypeManager.GetOverride): New.
7143 2006-01-05 Jb Evain <jbevain@gmail.com>
7145 * class.cs (Property.Define, Indexer.Define): do not tag the
7146 properties as SpecialName | RTSpecialName.
7148 2006-01-04 Miguel de Icaza <miguel@novell.com>
7150 * class.cs (MethodCore.IsDuplicateImplementation): This method was
7151 doing a low-level comparission of parameter types. It was lacking
7152 a check for __argslist.
7154 2005-12-30 Miguel de Icaza <miguel@novell.com>
7156 * expression.cs (ParameterReference.DoResolveBase): Allow
7157 reference parameters if they are local to this block.
7159 This allows the ref and out parameters of a delegate to be used in
7160 an anonymous method, for example:
7162 delegate void set (out int x);
7164 set s = delegate (out int x){
7168 This is used by functionality introduced late in the C# language.
7170 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
7171 method that take ref and out parameters.
7173 Fixes #77119 which was a late change in the spec.
7175 2005-12-23 Miguel de Icaza <miguel@novell.com>
7177 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
7178 parent if its the same scope. Fixes #77060.
7180 2005-12-21 Miguel de Icaza <miguel@novell.com>
7182 * driver.cs: Report the case of no source files and no -out:
7185 2005-12-20 Raja R Harinath <rharinath@novell.com>
7188 * expression.cs (ComposedCast.GetSignatureForError): Define.
7190 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7194 * namespace.cs (NamespaceEntry): Add extern_aliases as a
7195 ListDictionary, to contain the ExternAliasEntry entries (in
7196 addition to the NamespaceEntry.aliases hashtable). This field is
7197 shared between the original entry and its doppelganger (bodyless
7199 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
7200 extern_aliases field.
7201 (NamespaceEntry.Lookup): Move the IsImplicit check after the
7202 lookup in extern_aliases.
7204 2005-12-16 Raja R Harinath <rharinath@novell.com>
7207 * class.cs (TypeContainer.Mark_HasEquals): New.
7208 (TypeContainer.Mark_HasGetHashCode): New.
7209 (ClassPart): Override them.
7210 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
7213 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
7214 'parent' argument to the base constructor.
7216 Remove all mention of TypeContainer from decl.cs.
7217 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
7218 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
7219 (DeclSpace.DeclSpace): Likewise.
7220 (DeclSpace.DefineMembers): Remove unused argument.
7221 * cs-parser.jay (pop_current_class): Update to changes. Simplify
7222 debugging check -- we don't care if the debug code throws an
7223 InvalidCastException instead of an InternalErrorException.
7224 * class.cs (TypeContainer.DefineMembers): Update to changes.
7225 (TypeContainer.DoDefineMembers): Likewise.
7226 (TypeContainer.GetMethods): Likewise.
7227 (PropertyMember.Define): Likewise.
7228 (MemberBase.Parent): New property that forwards to
7229 MemberCore.Parent, but ensures that we get a TypeContainer.
7230 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
7231 (RootContext.PopulateTypes): Likewise. Remove special case code
7232 for !RootContext.StdLib: DefineMembers is idempotent.
7234 2005-12-14 Miguel de Icaza <miguel@novell.com>
7236 * convert.cs (ExplicitConversionCore): Check the return value from
7237 ExplicitConversionCore which can return null on failure. Fixes #76914
7239 2005-12-13 Marek Safar <marek.safar@seznam.cz>
7241 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
7243 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
7245 * doc.cs : The search for referenced namespace was insufficient to
7246 get global one as it used to do. Fixed bug #76965.
7248 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
7250 * doc.cs : check name in cref in the last phase that whether it is
7253 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7255 * cs-tokenizer.cs : reverted the latest change: it somehow broke
7258 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7260 * doc.cs : so it turned out that we cannot skip override check for
7261 interface members. Fixed bug #76954.
7263 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7265 * cs-tokenizer.cs : fixed bug #75984:
7266 - #warning and #error should not be handled when the source line
7268 - #line is not checked strictly when the source line is disabled.
7269 - #define and #undef is on the other hand checked strictly at any
7272 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
7274 * cs-tokenizer.cs : missing Location (actually, filename) in one of
7277 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7279 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
7281 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
7283 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
7284 (FieldBase.Initializer): Initializer is now optional.
7285 (EventField.Define): Only event field can have initializer.
7287 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
7289 * const.cs (Const): Reuse initializer.
7291 * cs-parser.jay: Updated after FieldBase changes.
7292 Added current_array_type to simplify array initializers.
7294 * ecore.cs (NullCast.IsDefaultValue): Implemented.
7296 * expression.cs, iterators.cs: Updated.
7298 * namespace.cs (NamespaceEntry): Made UsingFound private.
7300 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7302 * parameterCollection.cs: Obsolete, removed.
7303 * parser.cs: Obsolete, removed.
7305 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7308 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
7310 * enum.cs (Enum.Define): Set obsolete context here.
7312 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7315 - FindDocumentedMember() now expects 1) paramList as null
7316 when "we don't have to check the number of parameters" and
7317 2) Type.EmptyTypes when "there is no arguments".
7318 - Introduced FoundMember struct to hold the exact type which was
7319 used to find the documented member (the above change broke
7320 test-xml-044; it might be better just to use DeclaringType than
7321 what MS does, like this change does, but it depends on usage.)
7323 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7325 * doc.cs : documented member might be from DeclaringType for nested
7326 types. Fixed bug #76782.
7328 2005-12-03 Ben Maurer <bmaurer@ximian.com>
7330 * anonymous.cs: Have the param code handle leaving copies on the
7331 stack etc. Allows anonymous params to take part in the assignment
7332 code (++, +=, etc). Fixes bug #76550
7334 * expression.cs: Handle the prepare_for_load/leave_copy by passing
7335 it down to the anon code.
7337 * iterators.cs: Use dummy var here
7339 * codegen.cs: Handle new vars
7341 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7344 * class.cs (MethodData.Define): Set proper Obsolete context.
7346 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
7348 (FieldExpr.DoResolve): Ditto.
7350 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7353 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
7354 parent is not obsolete.
7356 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
7358 * doc.cs : (FindDocumentedMember) find parameterless members first
7359 and get CS0419 in the early stage. Fixed first case of bug #76727.
7361 2005-11-30 Marek Safar <marek.safar@seznam.cz>
7364 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
7365 no error was reported.
7367 *expression.cs (Binary.DoResolve): left can be null.
7369 2005-11-22 Marek Safar <marek.safar@seznam.cz>
7372 * class.cs (MethodData.Emit): Parameters should be labeled first.
7374 2005-11-21 Marek Safar <marek.safar@seznam.cz>
7377 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
7379 2005-11-18 Marek Safar <marek.safar@seznam.cz>
7381 * attribute.cs (AreParametersCompliant): Moved to Parameter.
7383 * class.cs (MethodCore): Parameter clean up.
7384 (IMethodData): Added ParameterInfo.
7385 (MethodData): Parameter clean up.
7386 (Indexer.Define): Parameter clean up.
7398 * typemanager.cs: Parameter clean up.
7400 * delegate.cs (Define): Get rid of duplicated code.
7402 * expression.cs (ParameterReference): Removed useless parameters
7404 (Invocation): Ditto.
7406 * parameter.cs (ParamsParameter): New class, params specialization.
7407 (ArglistParameter): Attemp to separate arglist.
7408 (Parameter): Refactored to be reusable and faster.
7409 (Parameter.Modifier): Made understandable.
7410 (Parameters): Changed to be used as a class for `this' assembly
7411 parameters. Refactored to use new specialized classes.
7413 * support.cs (ParameterData): Added Types property.
7414 (InternalParameters): Deleted.
7416 2005-08-20 Martin Baulig <martin@ximian.com>
7418 Merging this patch from GMCS to fix #75867.
7420 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7421 scope if we don't already have it.
7423 2005-11-17 Martin Baulig <martin@ximian.com>
7426 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
7427 inherit the scope from our parent. Fixes #76653.
7429 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7431 * doc.cs : the previous patch does not actually fix the bug.
7432 PropertyInfo override check is now implemented and really fixed it.
7433 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
7435 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7437 * doc.cs : apply "override filter" also to properties.
7440 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7442 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
7443 no need to check overrides. For classes, omit those results from
7444 interfaces since they must exist in the class. Fixed bug #76726.
7446 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7448 * typemanager.cs : (GetFullNameSignature) differentiate indexers
7449 with different parameters. Fixed the second problem in #76685.
7451 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7453 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
7454 get expected 'protected' access in CheckValidFamilyAccess()).
7457 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7459 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
7460 Fixed bug #76705. CS1569 was incorrectly commented out.
7462 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7464 * doc.cs : use Invocation.IsOverride() to do real override check.
7465 * expression.cs : made Invocation.IsOverride() internal.
7467 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7469 * doc.cs : use TypeManager.FindMembers() instead of (possible)
7470 TypeBuilder.FindMembers() and filter overriden base members out.
7473 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7475 * doc.cs : ref/out parameters are represented as '@' (instead of
7476 '&' in type FullName). Fixed bug #76630 (additionally crefs).
7478 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7480 * doc.cs : when there was no '.' in cref to methods in doc comment,
7481 then parameters were missing in the output. Fixed bug #76691.
7483 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7485 * driver.cs : don't output docs when there is an error.
7488 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7491 Now it should detect indexers. Fixed primary concern in bug #76685.
7492 Fixed CS0419 message to not show the identical member signature in
7495 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7497 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
7498 instead of Type.FindMembers() since it does not handle events.
7501 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
7503 * codegen.cs: Fixed typo (speficied -> specified).
7505 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7508 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
7510 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7512 * attribute.cs: Changed error message.
7514 * cs-tokenizer.cs: One more check.
7516 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7518 * statement.cs (Block.Resolve): Ignore empty statement.
7520 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7522 * report.cs: Made error/warning methods more strict to avoid
7525 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
7526 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
7527 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
7528 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
7530 2005-11-08 Marek Safar <marek.safar@seznam.cz>
7532 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
7533 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
7535 * class.cs (TypeContainer.IsComImport): New property.
7536 (Constructor.Define): Create proper ctor for ComImport types.
7538 * expression.cs (New.CheckComImport): Fixed.
7540 2005-11-07 Miguel de Icaza <miguel@novell.com>
7542 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
7543 that a parameter has been captured does not mean that we do not
7544 have to do the rest of the processing. This fixes the second part
7545 of #76592. If there was another anonymous method capturing
7546 values in the past, the Scope would never be set for the second
7547 method that captured the same parameter.
7549 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
7550 properly manipulate the stack. Second part of fix for #76592.
7552 * expression.cs (New): Add support for invoking "new" on
7553 interfaces that have been flagged with the ComImport attribute and
7554 the CoClass. Fixes #76637
7556 * statement.cs (Try.DoEmit): When a variable is captured, do not
7557 try to emit the vi.LocalBuilder variable as it has been captured.
7558 Create a temporary variable and store the results on the
7559 FieldBuilder. Fixes #76642
7561 2005-11-07 Marek Safar <marek.safar@seznam.cz>
7563 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
7565 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
7567 * expression.cs (Binary.DoResolve): Added && optimalization.
7569 * typemanager.cs (AddUserType): Removed useless argument.
7571 2005-11-04 Marek Safar <marek.safar@seznam.cz>
7573 * statement.cs (Block.variables): Uses ListDictionary.
7575 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7578 * class.cs (PartialContainer.EmitType): Customized to emit
7579 security attributes.
7580 (ClassPart.ApplyAttributeBuilder): Transform security attribute
7581 for partial classes.
7583 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7586 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
7587 access has to be fixed.
7589 * typemanager.cs (IsUnmanagedType): Wrong common field type.
7591 2005-11-01 Marek Safar <marek.safar@seznam.cz>
7594 * ecore.cs (NullCast.Reduce): Implemented.
7596 * expression.cs (ArrayCreation.CheckIndices): Correcly check
7599 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
7601 (Foreach.Resolve): Catch null properly.
7603 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7605 * cs-tokenizer.cs: Warning text fix.
7607 * driver.cs: AllWarningNumbers exposed on public interface.
7609 * report.cs (): Reviewed warning numbers.
7610 (IsValidWarning): Use binary search.
7612 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7614 * driver.cs: Implemeted resource visibility.
7615 (Resources): New class for code sharing between /res: and
7618 2005-10-28 Marek Safar <marek.safar@seznam.cz>
7621 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
7624 * convert (Convert.ImplicitReferenceConversion): NullCast holds
7627 * ecore.cs (NullCast): Child is contant only.
7629 * literal.cs (NullLiteral.Reduce): null can be converted to any
7632 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
7634 * driver.cs: Use Encoding.Default as default code page instead
7637 2005-10-27 Raja R Harinath <rharinath@novell.com>
7640 * expression.cs (Invocation.Error_InvalidArguments): Handle
7641 __arglist parameters.
7642 (Invocation.VerifyArgumentsCompat): Likewise.
7643 * support.cs (ReflectionParameters.GetSignatureForError): Print
7644 __arglist parameters.
7645 (InternalParamters.GetSignatureForError): Likewise.
7646 * parameter.cs (Parameters.GetSignatureForError): Likewise.
7648 2005-10-26 Marek Safar <marek.safar@seznam.cz>
7650 * attribute.cs (GetPropertyValue): Made public.
7652 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
7654 Add new property WrapNonExceptionThrows to handle 2.0 assembly
7656 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
7659 * driver.cs: Reflect method name change.
7661 * statement.cs (Try.Resolve): Warn when try has both general
7664 * typemanager.cs: runtime_compatibility_attr_type new predefined
7667 2005-10-26 Raja R Harinath <harinath@gmail.com>
7670 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
7671 treat it as an empty parameter list.
7673 2005-10-26 Raja R Harinath <rharinath@novell.com>
7676 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
7677 ResolveAsTypeStep silent.
7678 * statement.cs (Block.AddConstant): Mark block as used.
7679 (Block.ResolveMeta): Avoid piling on error messages
7680 if a constant initializer resolution fails.
7682 2005-10-25 Raja R Harinath <rharinath@novell.com>
7684 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
7686 (NamespaceEntry.VerifyAllUsing): New.
7687 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
7688 behaviour. Delegates actual resolution of alias to ...
7689 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
7690 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
7692 * driver.cs (Driver.MainDriver): Update.
7694 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
7695 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
7697 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
7699 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
7700 RootNamespace.DefineNamespacesForAll.
7702 2005-10-24 Raja R Harinath <harinath@gmail.com>
7704 * typemanager.cs (assemblies, external_aliases, modules)
7705 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
7706 (ComputeNamespaces, GetRootNamespace): Remove extra staging
7707 overhead. Move resposibility ...
7708 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
7709 * driver.cs, attribute.cs, codegen.cs: Update to changes.
7711 2005-10-23 Raja R Harinath <harinath@gmail.com>
7713 * namespace.cs (RootNamespace.all_namespaces): Renamed from
7714 cached_namespaces. Improve usage.
7715 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
7716 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
7717 Move from GlobalRootNamespace and simplify.
7718 (RootNamespace.Global): Make instance variable.
7719 (RootNamespace.RootNamespace): Add "alias name" parameter.
7720 (GlobalRootNamespace): Simplify drastically.
7721 (Namespace.Lookup): Don't use GetNamespace.
7722 * typemanager.cs (GetRootNamespace): Rename from
7723 ComputeNamespaceForAlias.
7724 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
7726 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7728 * anonymous.cs (AnonymousContainer): Don't crash when container
7731 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7733 * expression.cs (Binary.DoResolve): Warn when comparing same
7736 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7739 * expression.cs (Binary.DoResolve): It looks like there are no
7740 convetsion rules in enum context.
7742 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7744 Add support for extern alias qualifiers.
7745 * typemanager.cs: Move some LookupTypeReflection code
7746 to namespace.cs, to have cleaner code. Added some methods
7747 to help us keep track of the extern aliased references.
7748 * driver.cs: Add suport for extern alias assemblies on command
7749 line and check for their warnings/errors. Also keep track of the
7750 extern aliased assemblies.
7751 * namespace.cs: Move the global functionality of Namespace
7752 to GlobalRootNamespace/RootNamespace. Now the global namespace
7753 is GlobalRootNamespace.Globa. Also the code moved from
7754 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
7755 Finally added LocalAliasEntry (AliasEntry before) and
7756 ExternAliasEntry, to handle alias statements.
7757 * cs-parser.jay: Add support in the grammar for extern alias
7759 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
7760 Update callings to Namespace (now in GlobalRootNamespace).
7762 2005-10-18 Raja R Harinath <rharinath@novell.com>
7765 * class.cs (TypeContainer.DefineType): Move updating of
7766 topological sort earlier in the code.
7767 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
7769 2005-10-18 Marek Safar <marek.safar@seznam.cz>
7772 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
7774 * constant.cs (Constant.TryReduce): Moved from Cast class.
7775 (Reduce): Made little bit more OO and fixed missing conversions.
7777 * ecore.cs (Reduce): Implemented.
7778 (Binary.EnumLiftUp): New method to upgrade values to enum values.
7780 * literal.cs (Reduce): Implemented.
7782 * class.cs: Reverted Miguel's wrong commit.
7784 2005-10-14 Miguel de Icaza <miguel@novell.com>
7786 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
7788 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
7790 * cs-parser.jay, expression.cs : CS0214 was missing error location
7791 for constants. Fixed bug #76404.
7793 2005-10-11 Marek Safar <marek.safar@seznam.cz>
7796 * convert.cs (ExplicitConversionCore): Fixed object->enum
7799 2005-10-10 Raja R Harinath <rharinath@novell.com>
7801 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
7803 (PropertyExpr.EmitCall): Likewise.
7804 * expression.cs (Invocation.EmitArguments): Handle case where
7806 (Invocation.EmitCall): Avoid allocating temporary variable if
7807 there are no arguments.
7809 2005-10-07 Raja R Harinath <rharinath@novell.com>
7812 * convert.cs (ImplicitConversionStandard): Move conversion of
7813 void* to arbitrary pointer types ...
7814 (ExplicitConversionStandard): .. here.
7815 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
7816 error to always print typenames.
7818 2005-10-07 Raja R Harinath <rharinath@novell.com>
7820 * convert.cs (GetConversionOperator): Rename from
7821 GetConversionOperators. Move operator selection code from ...
7822 (UserDefinedConversion): ... here.
7824 2005-10-06 Marek Safar <marek.safar@seznam.cz>
7826 * convert.cs (ExplicitConversionCore): Removed duplicate enum
7829 2005-10-05 Marek Safar <marek.safar@seznam.cz>
7831 * assign.cs (Assign.DoResolve): Error method changed.
7833 * cfold.cs (DoConstantNumericPromotions): Error method changed.
7835 * const.cs (ResolveValue): Reset in_transit immediately.
7837 * constant.cs: Error method changed.
7839 * convert.cs: Removed useless location parameter.
7840 (ExplicitNumericConversion): Don't do double enum check.
7841 (ExplicitConversionCore): Renamed from ExplicitConversion.
7842 (ExplicitUnsafe): Extracted from ExplicitConversion.
7843 (ExplicitConversion): Uses for error reporting.
7845 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
7847 (ResolveBoolean): Uses common error method.
7848 (CastToDecimal): Get rid of ec.
7849 (CastFromDecimal): Optimized.
7850 (ConvCast): Get rid of ec.
7852 * enum.cs (ResolveValue): Reset in_transit immediately.
7853 (Emit): Return after first error.
7855 * expression.cs: Convert changes.
7857 * literal.cs: Error method changed.
7859 * statement.cs: Error method changed.
7861 2005-10-03 Raja R Harinath <rharinath@novell.com>
7863 * support.cs (SeekableStreamReader.Position): Don't error out when
7864 the requested position is just beyond the end of the current
7867 2005-09-28 Raja R Harinath <rharinath@novell.com>
7869 * support.cs (SeekableStreamReader): Simplify drastically. Don't
7870 try to keep in sync with the byte count of the underlying Stream.
7871 However, this limits us to a window size of 2048 characters: i.e.,
7872 the maximum lookahead of our lexer/parser can be 2048 characters.
7874 2005-09-28 Marek Safar <marek.safar@seznam.cz>
7877 * driver.cs: Fix compilation files with full root path.
7879 2005-09-25 Miguel de Icaza <miguel@novell.com>
7881 * report.cs (SymbolRelatedToPreviousError): Format the output so
7882 it does not use an open parenthesis that is never closed.
7884 * driver.cs: Follow coding guidelines
7886 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7889 * const.cs (Const.ResolveValue): Check for assigning non-null
7890 value to reference type.
7892 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7894 * anonymous.cs: Implemented ExprClassName.
7896 * assign.cs (Assign.DoResolve): Don't chrash when type is not
7899 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
7902 * class.cs (StaticClass.DefineContainerMembers): Report protected
7905 * codegen.cs: if(ed) PRODUCTION.
7907 * convert.cs (Error_CannotImplicitConversion): Better error
7910 * cs-parser.jay: More error checks.
7912 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
7914 * driver.cs (CSCParseOption): Enabled wrong option check.
7916 * ecore.cs (Expression.ExprClassName): Turned to property.
7917 (MemberExpr.CheckIntermediateModification): For checking boxed
7918 value types modification.
7920 * statement.cs (Fixed.Resolve): Expression type must be
7921 convertible to fixed type.
7922 (CollectionForeach.GetEnumeratorFilter,TryType):
7923 Small refactoring for easier error checking.
7925 2005-09-26 Marek Safar <marek.safar@seznam.cz>
7927 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
7930 * class.cs (GeneratedBaseInitializer): New class for customization
7931 compiler generated initializers.
7932 (MemberBase.DoDefine): Check Obsolete attribute here.
7933 (FieldMember.DoDefine): Ditto.
7935 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
7938 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
7939 (MemberCore.GetObsoleteAttribute): Removed argument.
7940 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
7941 (MemberCore.CheckObsoleteType): New helper.
7945 * statement.cs: Updates after MemberCore changes.
7947 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
7948 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
7950 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
7951 obsolete attribute for compiler construct.
7952 (As.DoResolve): Cache result.
7954 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
7956 2005-09-26 Raja R Harinath <rharinath@novell.com>
7959 * expression.cs (This.VerifyFixed): In a value type T, the type of
7960 'this' is T&, iow, 'this' is either an out or ref parameter. In a
7961 value type R, 'this' is treated as a value parameter.
7963 2005-09-22 Miguel de Icaza <miguel@novell.com>
7965 * statement.cs (Lock): Use the TemporaryVariable class instead of
7966 manually using local variables as those do not work when variables
7969 * ecore.cs: Moved the TemporaryVariable class from being a nested
7970 class inside Foreach to be a public class that can be employed in
7973 2005-09-19 Marek Safar <marek.safar@seznam.cz>
7975 * cs-parser.jay: interface_accessors replaced by
7976 accessor_declarations.
7978 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
7981 * statement.cs (GotoCase.Resolve): Convert null constant to
7983 (SwitchLabel.ResolveAndReduce): Ditto.
7984 (SwitchLabel.NullStringCase): Custom null stamp.
7985 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
7987 typemanager.cs (CSharpSignature): Don't skip first argument
7990 2005-09-18 Miguel de Icaza <miguel@novell.com>
7992 * driver.cs: Set InEmacs based on the environment variable EMACS.
7994 * location.cs (InEmacs): in this mode, do not report column
7995 location as it confuses Emacs.
7997 2005-09-16 Marek Safar <marek.safar@seznam.cz>
7999 * cfold.cs, constant.cs, convert.cs, ecore.cs,
8000 expression.cs, iterators.cs, literal.cs: Store constants and
8003 * class.cs (MemberBase.ShortName): Pass location.
8005 * cs-parser.jay: Some location fixes.
8007 * ecore.cs (Expression.Location): Made virtual.
8009 2005-09-05 Miguel de Icaza <miguel@novell.com>
8011 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
8012 if the underlying types are the same, otherwise we need to produce
8013 code that will do the proper cast.
8015 This was exposed by Marek's constant rewrite which produced
8016 invalid code for the call site:
8019 void Method (X v) {}
8023 This fixes test-49.cs
8025 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
8027 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
8028 Type/Object should be allowed as well. Fixed bug #75968.
8030 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
8032 * expression.cs : (Binary.DoResolve): when one is enum constant and
8033 another is constant 0, then return enum one *as enum type*.
8036 2005-09-02 Raja R Harinath <rharinath@novell.com>
8038 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
8042 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
8043 flow-branching for LocalVariableReferences in case we were invoked
8044 from a MemberAccess.
8045 * expression.cs (LocalVariableReference.VerifyAssigned): New.
8047 (LocalVariableReference.DoResolveBase): ... this.
8048 (MemberAccess.Resolve): Do the check that was disabled during
8051 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8054 (PartialContainer.Create): check abstract/sealed/static strictly
8055 but abstract/sealed can exist only at one side. Fixed bug #75883.
8057 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
8060 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
8061 specified, don't default to UnmanagedType.I4.
8063 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8065 * expression.cs : conditional operator should check possibly
8066 incorrect assign expression. Fixed bug #75946.
8068 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8070 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
8071 Reverting the change. gmcs is much complex than mcs on this matter.
8073 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8075 * cs-tokenizer.cs : To read another token ahead of the actual
8076 consumption, use new SavedToken and cache token instead of moving
8077 back the stream with SeekableStreamReader (it seemed problematic).
8079 driver.cs : Thus use StreamReader directly.
8080 * support.cs : Thus removed SeekableStreamReader.
8082 2005-08-30 Raja R Harinath <rharinath@novell.com>
8085 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
8086 (ScopeInfo.EmitScopeType): Use it to construct field names from
8087 names of captured locals.
8090 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
8091 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
8092 Pass 'target_type' to BoxedCast. Don't default to 'object'.
8093 (ExplicitConversion): Remove enum cases already handled by
8094 implicit conversion. Move implicit conversion check to the beginning.
8095 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
8096 * expression.cs (ArrayCreation.EmitDynamicInitializers):
8097 Don't treat System.Enum as a struct.
8099 2005-08-30 Jb Evain <jbevain@gmail.com>
8101 * attribute.cs: handles as expression in parameters.
8103 2005-08-30 Raja R Harinath <rharinath@novell.com>
8106 * class.cs (TypeContainer.VerifyClsName): Don't use a
8107 PartialContainer when verifying CLS compliance.
8108 (AbstractPropertyEventMethod): Set Parent here, ...
8109 (PropertyMethod): ... not here.
8111 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
8113 * attribute.cs : escaped attribute name should not be allowed to be
8114 resolved (e.g. @class as classAttribute). Fixed bug #75930.
8116 2005-08-29 Raja R Harinath <rharinath@novell.com>
8119 * convert.cs (ImplicitStandardConversionExists): Allow zero also
8120 when converting a long constant to unsigned long.
8121 * expression.cs (Invocation.OverloadResolve): Add sanity check to
8122 detect where IsApplicable and VerifyArgumentsCompat disagree.
8124 2005-08-29 Raja R Harinath <rharinath@novell.com>
8125 and Carlos Alberto Cortez <carlos@unixmexico.org>
8128 * class.cs (TypeContainer.CanElideInitializer): New helper.
8129 (TypeContainer.EmitFieldInitializers): Use it to determine if we
8130 can safely emitting the initializer of a field.
8132 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8134 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
8135 allowed inside a switch (without loop). Fixed bug #75433.
8137 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
8139 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
8140 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
8142 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8144 * driver.cs : kinda reverting the default encoding changes (not exact
8145 revert since I noticed that "codepage:reset" might not work fine).
8147 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8149 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
8150 Location. Now getter and setter store location correctly.
8151 (errors/cs0111-12.cs now reports the expected location.)
8153 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8155 * driver.cs : Use default encoding on the environment.
8156 Removed (now that) extra parameter for SeekableStreamReader.
8157 * support.cs : (SeekableStreamReader) third .ctor() argument for
8158 StreamReader is not required (always true). preamble size could
8159 be acquired in simpler and safe way.
8161 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
8163 * cs-parser.jay: report CS0642 at warning level 3
8164 and report CS0642 for an if else statement also
8165 fixes bug #74745. Patch by John Luke (and a bit
8167 Removed extra CS0642 warning check for "while",
8169 * statement.cs: In Block.Resolve(), CS0642 check
8170 is reimplemented to check a sequence of an empty
8171 statement and a block.
8173 Both fix bug #66777.
8175 2005-08-24 Marek Safar <marek.safar@seznam.cz>
8177 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
8178 detection until I fix it.
8180 * cs-tokenizer.cs: Changed error message.
8182 * cs-parser.jay: Fixed 2 error locations.
8184 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
8185 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
8188 * enum.cs (GetSignatureForError): Fixed.
8190 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
8194 * typemanager.cs (RegisterProperty): Removed.
8196 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
8198 2005-08-24 Raja R Harinath <rharinath@novell.com>
8201 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
8202 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
8204 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8206 * expression.cs : tiny fix is required for not warning positive ulong.
8209 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8211 * expression.cs : add CS0652 check for constant and integral
8212 expression. Fixed bug #53974.
8214 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8216 * expression.cs : in DoNumericPromotions(), check if there is implicit
8217 conversion overload for string (to check CS0034). Fixed bug #52492.
8219 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8221 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
8223 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8225 * ecore.cs : report location when it is *not* Null.
8227 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8233 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
8234 correctly. Fixed bug #75721.
8236 2005-08-23 Raja R Harinath <rharinath@novell.com>
8238 * support.cs (SeekableStreamReader.Position): Avoid an expensive
8239 loop that performs 'min (pos, char_count)'.
8242 * expression.cs (Unary.ResolveOperator): Don't discard implicit
8243 converted value in Operator.OnesComplement.
8245 2005-08-22 Ben Maurer <bmaurer@ximian.com>
8247 * anonymous.cs: If the anon method is pulled into a helper class,
8248 it needs to be `internal' not `private'. Fixes runtime behavior on
8251 2005-08-20 Martin Baulig <martin@ximian.com>
8253 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
8254 scope if we don't already have it.
8256 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
8257 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
8260 2005-08-17 Marek Safar <marek.safar@seznam.cz>
8263 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
8266 2005-08-16 Marek Safar <marek.safar@seznam.cz>
8268 The big constants rewrite
8269 Fix #75746, #75685 and more
8270 As a side effect saved 1MB for MWF ;-)
8272 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
8273 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
8274 enum based for corlib compilation.
8276 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
8279 * class.cs (FixedField.Define): Use ResolveAsConstant.
8281 * const.cs (IConstant): Interface constants and enums.
8282 (Const.ResolveValue): New method for constant resolvning.
8283 (ExternalConstant): Constants from imported assemblies.
8285 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
8286 conversion; like enums.
8287 (Constant.ToType): Converts this constant to different type.
8288 (Constant.Increment): Adds 1.
8290 * convert.cs (ImplicitConversionRequired): Simplified.
8292 * cs-parser.jay: Create EnumMember directly.
8294 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
8296 * doc.cs (GenerateEnumDocComment): Removed.
8298 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
8299 (ConvertIntLiteral): Removed.
8300 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
8302 * enum.cs (EnumMember): Implement IConstant.
8303 (Enum.IsValidEnumConstant): Removed.
8304 (Enum.GetNextDefaultValue): Removed.
8305 (Enum.FindMembers): Updated.
8306 (Enum.GenerateDocComment): Iterate enum members.
8308 * expression.cs (Cast.TryReduce): Handle enums correctly.
8309 (New.Constantify): Made public.
8310 (MemberAccess.DoResolve): Removed contant specific if(s).
8312 * literal.cs (NullLiteral): Implement new abstract methods.
8314 * statement.cs (GotoCase.Resolve): Use new constant methods.
8315 (SwitchLabel.ResolveAndReduce): Use new constant methods.
8317 * typemanager.cs (LookupEnum): Removed.
8318 (IsEnumType): Fixed to work with corlib.
8319 (RegisterConstant): Removed.
8320 (LookupConstant): Removed.
8321 (GetConstant): Changed to work with IConstant.
8323 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
8325 * location.cs : Fixed overflown (>255) column number.
8327 2005-08-03 Raja R Harinath <rharinath@novell.com>
8329 First cut of the qualified-alias-member feature.
8330 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
8332 * cs-parser.jay (DOUBLE_COLON): New token.
8333 (namespace_or_type_name): Add rule for recognizing
8334 qualified-alias-members.
8335 (primary_expression): Likewise.
8336 (element_access): Allow QualifiedAliasMember as a possible
8337 type-bearing expression.
8338 (local_variable_type, local_variable_pointer_type): Likewise.
8339 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
8340 aliases in the current and enclosing namespace declarations.
8341 (NamespaceEntry.UsingAlias): Add CS0440 warning.
8342 * decl.cs (MemberName.is_double_colon): New.
8343 (MemberName.MemberName): Add new constructor for alias-member.
8344 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
8345 * expression.cs (QualifiedAliasMember): New expression type.
8347 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8349 * location.cs : it borked when no argument was specified.
8351 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8353 * location.cs : tiny ToString() format fix.
8355 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8357 * statement.cs : oops, it was missing.
8359 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8361 A set of fixes for precise line/column location.
8364 "token" field now holds a file/line "delta", a line number offset
8365 from the segment, and a column number. See also:
8366 http://lists.ximian.com/pipermail/mono-devel-list/2004-
8367 December/009508.html
8368 Removed static IsNull. Use instance IsNull property instead.
8370 For some tokens it stores Location. For Identifier it stores
8371 LocatedToken which is a pair of string name and location.
8372 Column numbers are adjusted only at getChar().
8374 Use Location.ToString() for reporting (it now contains column).
8376 Largely modified to use LocatedToken instead of
8377 string (IDENTIFIER), and to acquire Location from some tokens.
8378 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
8379 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
8381 Now MemberName holds Location. DeclSpace.ctor() receives Location
8382 as a parameter. Removed extra parameters to all derived classes.
8383 Replaced Location.IsNull() with instance property.
8384 * assign.cs, expression.cs :
8385 Added .ctor() overload that omits Location.
8387 Added "nameEscaped" flag that indicates the identifier was escaped
8388 in the source file. This fixes bug #57047.
8390 2005-08-02 Marek Safar <marek.safar@seznam.cz>
8392 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
8393 New method, looking for lo-case imported cls type.
8395 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
8398 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
8400 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
8402 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
8404 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
8406 Optimized to save 3.5 MB for SWF compilation.
8408 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8410 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
8411 (PartialContainer.Create): Moved logic AddToContainer.
8412 (PartialContainer.MarkForDuplicationCheck): Shares name.
8414 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
8417 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
8419 (Namespace.GetSignatureForError): New method.
8421 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
8422 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
8424 2005-08-01 Raja R Harinath <rharinath@novell.com>
8427 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
8428 member lookup rather than qualifier_type, since qualifier_type can
8431 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8433 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
8436 2005-07-31 Miguel de Icaza <miguel@novell.com>
8438 * statement.cs: Copy the local exception into the exception
8439 captured local. Fixes 75674
8441 2005-07-31 Raja R Harinath <harinath@gmail.com>
8444 * expression.cs (Invocation.OverloadResolve): Don't report error
8445 CS1501 if error CS1502 has been reported.
8446 (New.DoResolve): Delegate CS1501 reporting to
8447 Invocation.OverloadResolve.
8450 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
8451 invariant-meaning-in-block property in an enclosing block if
8454 2005-07-29 Marek Safar <marek.safar@seznam.cz>
8456 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
8457 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
8458 (Switch.CheckSwitch): Just save 50kb for SWF.
8460 2005-07-27 Martin Baulig <martin@ximian.com>
8462 * anonymous.cs (CaptureContext.AddField): Added
8463 `AnonymousContainer am' argument; compute its toplevel scope if
8464 it's not already computed. Fixes #75649.
8466 2005-07-26 Raja R Harinath <rharinath@novell.com>
8469 * class.cs (Constructor.Emit): Reset block to null if the block
8472 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8474 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
8476 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8478 * class.cs (MethodData.Define): Check whether accessor implementing
8479 interface is public.
8481 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
8483 2005-07-22 Marek Safar <marek.safar@seznam.cz>
8486 * namespace.cs (LookupType): Moved same type check to...
8488 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
8491 2005-07-21 Raja R Harinath <rharinath@novell.com>
8493 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
8494 already found a typebuilder.
8495 * class.cs (MethodCore.IsDuplicateImplementation): Compare
8496 MemberNames, not strings.
8498 * const.cs (Error_ExpressionMustBeConst):
8499 Rename from Error_EpressionMustBeConst.
8500 * const.cs, class.cs, statement.cd: Update.
8502 2005-07-21 Marek Safar <marek.safar@seznam.cz>
8506 * const.cs (Const.LookupConstantValue): Report missing contant expression
8508 (Error_EpressionMustBeConstant): Only one error method.
8510 * class.cs, statement.c: Updated.
8512 2005-07-20 Raja R Harinath <rharinath@novell.com>
8514 * statement.cs (Block.Flags): Add back HasVarargs.
8515 (Block.flags): Make protected.
8516 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
8518 * typemanager.cs (types, typecontainers, user_types): Remove.
8519 (UserTypes, TypeContainers): Likewise.
8520 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
8521 (CleanUp, Reset): Update.
8522 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
8523 (GetNestedType): Use Type.GetNestedType.
8524 (CoreLookupType): Take two arguments, the namespace and the
8525 basename of the type. Update to use the Namespace.Lookup
8527 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
8528 (RealMemberLookup): Use IsNestedChildOf instead of playing with
8529 string concatenation and substring matches.
8530 * class.cs, enum.cs, delegate.cs: Update to changes.
8532 2005-07-20 Marek Safar <marek.safar@seznam.cz>
8534 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
8535 Expression and made virtual.
8537 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
8538 (ImplicitStandardConversionExists): Fixed `byte' typo ?
8540 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
8542 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
8545 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
8548 2005-07-18 Marek Safar <marek.safar@seznam.cz>
8551 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
8552 AssemblyCultureAttribute is not used on executable.
8555 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
8557 2005-07-16 Raja R Harinath <rharinath@novell.com>
8560 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
8561 New. Reports CS0252/CS0253.
8562 Mostly taken from preliminary patch by Duncak Mak.
8563 (Binary.DoResolveOperator): Store results of operator lookup.
8564 Use them to detect if we need to warn about unintended reference
8567 2005-07-15 Raja R Harinath <rharinath@novell.com>
8570 * namespace.cs (Namespace.Lookup): Add back location parameter.
8571 (Namespace.LookupType): Add CS0436 report. Add location parameter.
8572 * delegate.cs, ecore.cs, expression.cs: Update to changes.
8574 * codegen.cs (EmitContext.DeclSpace): Make readonly.
8575 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
8576 (Namespace.LookupType): ... this.
8577 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
8579 * typemanager.cs (LookupTypeReflection): Remove buggy code that
8580 purported to handle pointers.
8581 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
8584 2005-07-15 Marek Safar <marek.safar@seznam.cz>
8586 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
8589 2005-07-15 Raja R Harinath <rharinath@novell.com>
8591 * namespace.cs (Namespace.Lookup): Drop location parameter.
8592 (NamespaceEntry.LookupAlias): Remove. Merge into ...
8593 (NamespaceEntry.Lookup): ... this.
8594 (NamespaceEntry.Error_AmbiguousTypeReference):
8595 Move here from DeclSpace.
8596 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
8598 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
8599 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
8600 Move to NamespaceEntry.
8601 * delegate.cs, expression.cs: Update to changes.
8603 2005-07-14 Marek Safar <marek.safar@seznam.cz>
8605 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
8606 CheckAttributeType and refactored.
8607 (Attribute.ResolvePossibleAttributeType): Changed to reuse
8608 ResolveAsTypeTerminal error handling.
8609 (ResolveAsTypeTerminal): Introduced because of global attributes extra
8611 (GetSignatureForError): Print errors in same way.
8614 * codegen.cs: Reflect attribute GetSignatureForError change.
8617 * expression.cs: Add silent parameter to ResolveAsTypeStep.
8619 * namespace.cs (UsingEntry): Refactored to make fields private.
8622 statement.cs: Error_UnexpectedKind has extra parameter.
8624 2005-07-14 Raja R Harinath <rharinath@novell.com>
8626 * ecore.cs (IAlias): Remove.
8627 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
8628 that implement the interface.
8629 * namespace.cs (Namespace): Likewise.
8630 (Namespace.declspaces): Renamed from 'defined_names'.
8631 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
8632 DeclSpace instead of an IAlias.
8633 * tree.cs (Tree.AddDecl): Update.
8635 2005-07-12 Raja R Harinath <rharinath@novell.com>
8637 * statement.cs (Block.Flags); Remove HasVarargs.
8638 (Block.HasVarargs): Move to ToplevelBlock.
8639 (Block.ThisVariable, Block.AddThisVariable): Likewise.
8640 (Block.Variables): Make protected. Initialize variable hashtable
8642 (Block.AddVariable): Update.
8643 (Block.Resolve): Update to changes.
8644 (ToplevelBlock.HasVarargs): New boolean.
8645 (ToplevelBlock.ThisVariable): Move here from Block.
8646 (ToplevelBlock.AddThisVariable): Likewise.
8647 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
8648 * expression.cs (This.ResolveBase): Update to changes.
8649 (ArglistAccess.DoResolve): Likewise.
8651 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8654 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
8656 * class.cs (TypeContainer.VerifyMembers): Distinguish between
8657 not used and not used & assigned.
8658 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
8660 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8663 * expression.cs (Is.DoResolve): null is never provided type.
8665 2005-07-08 Marek Safar <marek.safar@seznam.cz>
8668 * cs-parser.jay: Less strict event error rule to catch more errors.
8670 2005-07-08 Martin Baulig <martin@ximian.com>
8672 Fix test-iter-10.cs - distinguish whether we `yield' in a property
8673 gettter (allowed) or setter (not allowed).
8675 * class.cs (Accessor): Implement IIteratorContainer.
8676 (Accessor.Yields): New public field.
8677 (PropertyBase.PropertyMethod.Define): Handle iterators on a
8681 (get_accessor_declaration, set_accessor_declaration): Set the
8682 `yields' flag on the accessor, not the property.
8683 (property_declaration): Do the iterators check on a per-accessor
8684 basis and not for the whole property.
8686 2005-07-08 Martin Baulig <martin@ximian.com>
8688 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
8689 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
8691 2005-07-07 Marek Safar <marek.safar@seznam.cz>
8694 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
8695 (ExtractSecurityPermissionSet): Cope with self referencing security
8696 attributes properly.
8698 * driver.cs (SetOutputFile): Made public property OutputFile.
8700 2005-07-07 Raja R Harinath <rharinath@novell.com>
8703 * class.cs (TypeContainer.first_nonstatic_field): Rename from
8704 has_nonstatic_fields. Make into a FieldBase pointer.
8705 (TypeContainer.AddField): Add CS0282 check.
8706 (TypeContainer.EmitType): Update.
8708 2005-07-06 Miguel de Icaza <miguel@novell.com>
8710 * cs-tokenizer.cs (consume_identifier): Do not create strings to
8711 compare if they start with __.
8713 2005-07-06 Raja R Harinath <rharinath@novell.com>
8715 * statement.cs (Switch.SwitchGoverningType): Only look at
8716 UserCasts that don't need implicit standard conversions to one of
8717 the allowed switch types (Fixes test-322.cs).
8718 (LocalInfo.Resolve): Re-enable sanity-test.
8720 2005-07-06 Marek Safar <marek.safar@seznam.cz>
8722 * cs-tokenizer.cs (consume_identifier): Detect double undescores
8724 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
8726 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
8728 2005-07-06 Raja R Harinath <rharinath@novell.com>
8731 * ecore.cs (SimpleName.GetSignatureForError): Add.
8732 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
8733 (MemberAccess.GetSignatureForError): Add.
8735 2005-07-05 Marek Safar <marek.safar@seznam.cz>
8737 The big error and warning messages review.
8767 * typemanager.cs: Updated.
8769 * class.cs: (MethodCore.SetYields): Moved here to share.
8770 (PropertyMethod.Define): Moved iterator setup here.
8772 * iterators.cs: Add orig_method to have full access to parent
8775 2005-07-05 Raja R Harinath <rharinath@novell.com>
8777 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
8778 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
8779 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
8780 variable of struct type.
8781 * expression.cs (Unary.ResolveOperator): Update to change.
8782 (Indirection.VerifyFixed): Likewise.
8783 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
8784 (ParameterReference.VerifyFixed): Value parameters are fixed.
8785 (This.VerifyFixed): Treat 'this' as a value parameter.
8786 * statement.cs (LocalInfo.IsFixed): Remove.
8788 2005-07-01 Martin Baulig <martin@ximian.com>
8790 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
8791 `ec.EmitThis ()' to get the correct scope.
8793 2005-07-01 Martin Baulig <martin@ximian.com>
8795 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
8796 instance is a ParameterReference; fixes #75299.
8798 2005-07-01 Martin Baulig <martin@ximian.com>
8800 Reverted Marek's latest patch (r46725):
8801 - it contains structural changes which are neither mentioned in
8802 the ChangeLog nor explained anywhere; for example the additional
8803 argument of EmitContext's and Iterator's .ctor's and the
8804 TypeContainer.DefineMembers() change.
8805 - structural changes like this should go in in seperate patches
8806 and not be hidden in a huge patch which just seems to affect
8807 warnings and errors.
8808 a big and hard to understand patch.
8809 - it breaks iterators and causes regressions, for instance in
8812 2005-06-30 Raja R Harinath <rharinath@novell.com>
8815 * expression.cs (Indexers.map): Remove.
8816 (Indexers.Append): Filter out inaccessible setters and getters.
8817 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
8820 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
8822 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
8823 (FieldExpr.Emit, PropertyExpr.Emit): Update.
8824 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
8825 * expression.cs (Invocation.EmitCall): Add CS0120 check.
8827 2005-06-30 Marek Safar <marek.safar@seznam.cz>
8830 * class.cs (FieldBase.GetInitializerExpression): One more field
8833 2005-06-28 Miguel de Icaza <miguel@novell.com>
8835 * pending.cs: Do not define a proxy if the base method is virtual,
8836 it will be picked up by the runtime (bug 75270).
8838 2005-06-08 Martin Baulig <martin@ximian.com>
8840 The big Iterators rewrite :-)
8842 * iterators.cs: Rewrite this to use the anonymous methods framework.
8844 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
8845 before the TypeContainers; see 2test-21.cs.
8848 (TypeContainer.DefineType): Don't create a new EmitContext if we
8849 already have one (this only happens if we're an Iterator).
8850 (TypeContainer.Define): Also call Define() on all our iterators.
8851 (Method.CreateEmitContext): Added support for iterators.
8854 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
8855 (AnonymousContainer.CreateMethodHost): Moved here from
8856 AnonymousMethod and made abstract.
8857 (AnonymousContainer.CreateScopeType): New abstract method.
8858 (AnonymousContainer.IsIterator): New public property.
8859 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
8860 get the ScopeTypeBuilder rather than manually defining it here.
8861 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
8864 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
8865 before RootContext.DefineTypes().
8867 * codegen.cs (EmitContext.RemapToProxy): Removed.
8868 (EmitContext.CurrentAnonymousMethod): Changed type from
8869 AnonymousMethod -> AnonymousContainer.
8870 (EmitContext.ResolveTopBlock): Protect from being called twice.
8871 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
8872 (EmitContext.EmitThis): Removed the iterators hacks; use the
8873 anonymous methods framework for that.
8876 (ToplevelBlock.Container): Make this a property, not a field.
8877 (ToplevelBlock.ReParent): New public method; move the
8878 ToplevelBlock into a new container.
8879 (Foreach.TemporaryVariable): Simplify.
8881 2005-06-05 Martin Baulig <martin@ximian.com>
8883 * statement.cs (LocalInfo.CompilerGenerated): New flag.
8884 (Block.AddTemporaryVariable): New public method; creates a new
8885 `LocalInfo' for a temporary variable.
8886 (Block.EmitMeta): Create the LocalBuilders for all the temporary
8888 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
8889 non-iterator variables.
8891 2005-06-05 Martin Baulig <martin@ximian.com>
8893 * statement.cs (Foreach.TemporaryVariable): Create the
8894 LocalBuilder in the Emit phase and not in Resolve since in some
8895 situations, we don't have an ILGenerator during Resolve; see
8896 2test-19.cs for an example.
8898 2005-06-04 Martin Baulig <martin@ximian.com>
8900 **** Merged r45395 from GCS ****
8902 The big Foreach rewrite - Part II.
8904 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
8905 with `PropertyInfo ienumerator_getcurrent'.
8907 * codegen.cs (VariableStorage): Removed.
8910 (Foreach): Derive from Statement, not ExceptionStatement.
8911 (Foreach.CollectionForeach): New nested class. Moved all the code
8912 dealing with collection foreach here.
8913 (Foreach.ForeachHelperMethods): Removed.
8914 (Foreach.TemporaryVariable): Implement IMemoryLocation.
8916 2005-05-23 Martin Baulig <martin@ximian.com>
8918 * statement.cs (Try.DoResolve): Don't create a `finally' if we
8919 don't need to. Fix #75014.
8921 2005-05-20 Martin Baulig <martin@ximian.com>
8923 Merged r44808 from GMCS.
8925 * class.cs (TypeContainer.CircularDepException): Removed.
8926 (TypeContainer.DefineType): Removed the `InTransit' stuff.
8927 (TypeContainer.CheckRecursiveDefinition): Check for circular class
8928 (CS0146) and interface (CS0529) dependencies here.
8930 2005-06-21 Raja R Harinath <rharinath@novell.com>
8932 * expression.cs (Invocation.EmitCall): Fix initialization
8933 'this_call' to reflect current behaviour. Fix indentation.
8935 * convert.cs (FindMostEncompassedType): Add two trivial special
8936 cases (number_of_types == 0 || number_of_types == 1).
8937 (FindMostEncompasingType): Likewise.
8939 2005-06-17 Raja R Harinath <rharinath@novell.com>
8941 Some cleanups preparing for the fix of #75283.
8942 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
8944 (EventExpr.InstanceResolve): Likewise.
8945 (EventExpr.DoResolve): Remove redundant checks.
8947 2005-06-10 Duncan Mak <duncan@novell.com>
8949 * cs-tokenizer.cs (process_directives): New flag for controlling
8950 the processing of preprocessor directives.
8951 (x_token): After seeing a '#', return Token.NONE instead of going
8952 to handle_preprocessing_directive() when not processing
8953 directives. This avoids unnecessary processing during the token peek in
8958 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
8959 the existing error reporting methods instead of Report.Error.
8961 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
8962 after Raja's rewrite.
8964 2005-06-08 Miguel de Icaza <miguel@novell.com>
8966 * class.cs: Small fix.
8968 2005-06-08 Raja R Harinath <rharinath@novell.com>
8971 * class.cs (GetPartialBases): Fix return value check of
8974 2005-06-07 Raja R Harinath <rharinath@novell.com>
8976 Ensure that partial classes are registered in their enclosing
8977 namespace. Initial part of fix of #75160.
8978 * tree.cs (Tree.RecordDecl): Add new namespace argument.
8979 Register declspace with namespace here, not in
8980 DeclSpace.RecordDecl.
8981 * cs-parser.jay: Pass namespace to RecordDecl.
8982 * class.cs (PartialContainer.Create): Likewise.
8983 (ClassPart.DefineType): New sanity-check. Throws an exception if
8985 * decl.cs (Declspace.RecordDecl): Remove.
8986 * namespace.cs (NamespaceEntry.DefineName): Remove.
8988 2005-06-06 Marek Safar <marek.safar@seznam.cz>
8990 * rootcontext.cs: Reset TargetExt as well.
8992 2005-06-03 Raja R Harinath <rharinath@novell.com>
8994 * ecore.cs (Expression.Resolve): Emit CS0654 error when
8997 2005-06-02 Raja R Harinath <rharinath@novell.com>
8999 Fix #75080, cs0119.cs.
9000 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
9002 (Expression.Resolve): ... this. Use it. Remove bogus code
9003 allowing ExprClass.Type and ExprClass.Namespace for
9004 ResolveFlags.VariableOrValue.
9005 (Expression.Resolve) [1-argument variant]: Change default resolve
9006 flags based on language version.
9007 (Expression.Error_UnexpectedKind): Use a simple string array
9008 rather than an ArrayList.
9009 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
9011 (TypeOfVoid.DoResolve): Likewise.
9012 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
9013 flags argument -- it always has the same value.
9015 2005-05-31 Raja R Harinath <rharinath@novell.com>
9018 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
9019 Use it in the error message.
9020 * assign.cs, expression.cs, statement.cs: Update.
9022 2005-05-30 Raja R Harinath <rharinath@novell.com>
9025 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
9026 the "almostMatchedMember" case too.
9027 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
9028 that failed the accessibility checks to 'almost_match'.
9030 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
9032 * attribute.cs: Use internal MethodBuilder methods to set
9033 ExactSpelling and SetLastError on PInvoke methods, instead
9034 of passing them via charset. Fixes #75060.
9036 2005-05-27 Raja R Harinath <rharinath@novell.com>
9038 * parameter.cs (Parameter): Remove TODO comment.
9039 (Parameter.DefineParameter): Remove Location parameter.
9040 (Parameters.LabelParameters): Likewise.
9041 * class.cs (Constructor.Emit): Update to change.
9042 (MethodData.Emit): Likewise.
9043 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
9044 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
9046 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
9049 Removed Parameters.Location and added Parameter.Location instead.
9050 Removed Location parameter from Emit() and GetSignature().
9057 Modified all related calls.
9059 2005-05-26 Raja R Harinath <rharinath@novell.com>
9061 Improve user-defined conversion handling.
9062 * convert.cs (GetConversionOperators): Rewrite. Return only the
9063 applicable operators.
9064 (AddConversionOperators): New. Helper for GetConversionOperators.
9065 (FindMostEncompassedType, FindMostEncompassingType): Verify that
9066 there is only one most encompassed/encompassing type.
9067 (FindMostSpecificSource, FindMostSpecificTarget): Remove
9068 "applicable operator" handling.
9069 (UserConversion): Move cache here from GetConversionOperators.
9070 Directly cache the chosen operator, rather than the whole
9072 (ExplicitNumericConversion): Fix buggy implementation of Decimal
9073 case. Allow conversion of decimal to sbyte and byte too.
9074 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9075 New static methods. Used to avoid allocating EmptyExpressions in
9078 2005-05-24 Duncan Mak <duncan@novell.com>
9080 * ecore.cs (CastFromDecimal): New class for casting a decimal to
9081 another class, used in Convert.ExplicitNumericConversion.
9082 (CastToDecimal): New class, similar to above, but casts to
9083 System.Decimal, used in Convert.ImplicitNumericConversion and also
9084 in explicit convesion from double/float to decimal.
9086 * convert.cs (ImplicitNumericConversion): Handle implicit
9087 conversions to System.Decimal.
9088 (ExplicitNumericConversion): handle explicit conversions to
9093 2005-05-20 Miguel de Icaza <miguel@novell.com>
9095 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
9096 know the type at this stage, just break through. Fixes #75008
9098 2005-05-19 Martin Baulig <martin@ximian.com>
9101 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
9102 to disable error reporting.
9104 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
9105 here since we don't want to report an error; see the new test-336.cs.
9107 2005-05-19 Raja R Harinath <rharinath@novell.com>
9109 * statement.cs (ToplevelBlock.GetParameterReference)
9110 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
9111 Move here from class Block.
9112 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
9113 * expression.cs (ParameterReference.DoResolveBase): Likewise.
9115 2005-05-18 Martin Baulig <martin@ximian.com>
9120 (FlowBranching.Reachability): Add non-static public And() and Or()
9122 (FlowBranchingSwitch): New class; do the `break_origins' thing
9123 like in FlowBranchingLoop.
9124 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
9125 reachability, not just locals and parameters.
9126 (FlowBranching.MergeChild): Remove some of the hacks for loop and
9127 switch; MergeBreakOrigins() now takes care of that.
9129 2005-05-18 Martin Baulig <martin@ximian.com>
9131 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9132 a loop and may leave it, reset the barrier; fixes #74974.
9134 2005-05-17 Marek Safar <marek.safar@seznam.cz>
9136 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
9139 * cs-parser.jay: Catch more lexical errors.
9141 * report.cs: Add one more Error method.
9144 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
9146 2005-05-17 Martin Baulig <martin@ximian.com>
9148 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
9151 2005-05-16 Raja R Harinath <rharinath@novell.com>
9153 Fix test-382.cs. Emit values of decimal constants.
9154 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
9156 (TypeContainer.AddField): ... this.
9157 (TypeContainer.EmitFieldInitializers): Allow the list of fields
9158 with initializers to include 'Const's.
9159 (ClassPart.RegisterFieldForInitialization): Forward to
9161 * const.cs (Const.Const): Pass initializer to base class.
9162 (Const.Define): In case of decimal constants, register them for
9163 initialization in a static constructor.
9165 2005-05-14 Martin Baulig <martin@ximian.com>
9167 * statement.cs (Block.Resolve): Correctly handle unreachable code;
9168 do not call ResolveUnreachable() on unreachable statements in
9169 here, see the comment in the source code.
9171 2005-05-13 Raja R Harinath <rharinath@novell.com>
9174 * expression.cs (BinaryResolveOperator): If one of the operands of
9175 an equality comparison is 'null' and the other is a pointer type,
9176 convert the null to a NullPointer.
9177 * convert.cs (ImplicitReferenceConversion): If the expression is a
9178 NullLiteral and the target type is a pointer type, return a
9179 NullPointer instead.
9180 (ImplicitConversionStandard): Likewise.
9182 2005-05-13 Marek Safar <marek.safar@seznam.cz>
9184 * cs-parser.jay: Set readonly context based on special constructs.
9186 * expression.cs (LocalVariableReference.DoResolveBase): Improved
9187 readonly variable error handling.
9189 * rootcontext.cs (EmitCode): Don't verify members when error
9192 * statement.cs (LocalInfo): Add reaodnly context information.
9193 (SetReadOnlyContext, GetReadOnlyContext): New methods.
9195 2005-05-13 Raja R Harinath <rharinath@novell.com>
9197 * statement.cs (Block.Resolve): Revert change below. Modify fix
9198 for #74041 to initialize 'resolved' to false only for explicit
9199 blocks. Fixes #74873.
9201 2005-05-12 Raja R Harinath <harinath@gmail.com>
9204 * typemanager.cs (unmanaged_enclosing_types): New.
9205 (IsUnmanagedType): Avoid infloops by using
9206 'unmanaged_enclosing_types' to talk with recursive invocations.
9208 2005-05-13 Martin Baulig <martin@ximian.com>
9210 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
9211 instance variable, not a local. Fix #74873.
9212 (Block.ResolveUnreachable): Set it to true here.
9214 2005-05-11 Duncan Mak <duncan@novell.com>
9216 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
9217 continuing to process for 'arg'.
9218 (handle_preprocessing_directive): Check the argument of the #endif
9219 directive and report error CS1025 if there are any trailing
9222 According to the C# spec, having even whitespace after the #endif
9223 directive is illegal; however, because we call arg.TrimEnd ()
9224 beforehand, we have the same behavior as csc, allowing whitespace
9225 after the directive.
9229 2005-05-11 Marek Safar <marek.safar@seznam.cz>
9233 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
9234 (Constructor.GetObsoleteAttribute): Implemented correctly.
9236 2005-05-10 Martin Baulig <martin@ximian.com>
9238 * support.cs (ReflectionParameters.ParameterModifier): Use
9239 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
9240 and `ParameterAttributes.In'. Fixes #74884.
9242 2005-05-10 Marek Safar <marek.safar@seznam.cz>
9244 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
9246 * expression.cs (Argument.GetParameterModifier): Turned to property.
9247 (Invocation.Error_InvalidArguments): Add more descriptive errors.
9249 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
9252 2005-05-09 Raja R Harinath <rharinath@novell.com>
9255 * decl.cs (MemberCache.AddMethods): Register override methods,
9256 rather than non-override methods.
9257 * typemanager.cs (RegisterOverride): New.
9258 (IsOverride): Update.
9260 2005-05-09 Marek Safar <marek.safar@seznam.cz>
9264 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
9265 recursive declaration.
9267 * statement.cs (Block.ResolveMeta): Report any error in resolving.
9269 2005-05-06 Marek Safar <marek.safar@seznam.cz>
9271 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
9273 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
9275 2005-05-05 Raja R Harinath <rharinath@novell.com>
9278 * decl.cs (DeclSpace.FamilyAccessible):
9279 Use TypeManager.IsNestedFamilyAccessible.
9281 Fix reopened #64812.
9282 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
9285 2005-05-04 Raja R Harinath <rharinath@novell.com>
9286 Abin Thomas <projectmonokochi@rediffmail.com>
9287 Anoob V E <projectmonokochi@rediffmail.com>
9288 Harilal P R <projectmonokochi@rediffmail.com>
9291 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
9292 allow access to all static members.
9294 2005-05-04 Martin Baulig <martin@ximian.com>
9296 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
9298 2005-05-04 Martin Baulig <martin@ximian.com>
9302 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
9303 section at the end; make things work if `default' is not the last
9306 2005-05-04 Martin Baulig <martin@ximian.com>
9310 * statement.cs (Switch): Replaced the `got_default' field with a
9311 `default_section' one.
9312 (Switch.CheckSwitch): Set `default_section' here.
9313 (Switch.Resolve): If we're a constant switch and the constant is
9314 not found, use the default section.
9316 2005-05-03 Martin Baulig <martin@ximian.com>
9318 * expression.cs (ArrayAccess.EmitGetLength): New public method.
9320 * statement.cs (Foreach.ArrayForeach): New nested class.
9321 (Foreach.TemporaryVariable): New nested class.
9322 (Foreach.EmitArrayForeach): Removed; this is now in the new
9325 2005-05-03 Raja R Harinath <rharinath@novell.com>
9327 * pending.cs (BaseImplements): Move the #74773 fix here. This is
9329 (VerifyPendingMethods): Revert change below.
9331 * typemanager.cs (IsOverride, RegisterNonOverride): New.
9332 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
9333 that used to trigger warning -28. Remove warning -28.
9334 * expression.cs (Invocation.OverloadResolve): Use
9335 TypeManager.IsOverride to distinguish override methods.
9338 * pending.cs (VerifyPendingMethods): If a base type implements the
9339 requested interface, don't bother checking individual methods of
9340 the base type. As a side-effect, this prevents the creation of
9341 unnecessary proxies.
9343 2005-05-02 Martin Baulig <martin@ximian.com>
9347 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9348 Also `And' the locals if the old vector is null.
9349 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
9350 null; in this case we basically reset all the variables.
9352 2005-05-02 Martin Baulig <martin@ximian.com>
9356 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
9357 Added `FlowBranching branching' argument; always `and' the
9358 variables instead of `or'ing them unless we're an infinite loop.
9360 * statement.cs (While.Resolve): Create a new sibling unless we're
9363 2005-05-02 Martin Baulig <martin@ximian.com>
9367 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
9368 arguments; use it instead of creating a new TopLevelBlock.
9369 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
9370 our ConstructorInitializer.
9373 (TopLevelBlock.TopLevelBranching): New public property.
9374 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
9375 and create our `TopLevelBranching'.
9377 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
9378 anonymous method host, use `block.TopLevelBranching' rather than
9379 creating a new branching.
9381 2005-04-20 Miguel de Icaza <miguel@novell.com>
9383 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
9384 a ScopeInfo, if any of the current children is a child of the new
9385 entry, move those children there.
9387 2005-04-30 Martin Baulig <martin@ximian.com>
9389 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
9390 at the beginning of a SwitchSection. Fix #73335.
9392 2005-04-27 Marek Safar <marek.safar@seznam.cz>
9395 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
9397 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
9398 (FieldExpr.DoResolve): Obsolete members are ignored for field
9401 2005-04-26 Marek Safar <marek.safar@seznam.cz>
9403 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
9404 of arrays detection.
9406 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
9408 (Field.VerifyClsCompliance): Volatile fields are not compliant.
9410 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
9413 2005-04-25 Ben Maurer <bmaurer@ximian.com>
9415 * cs-parser.jay: Use the prefered version of -unsafe in error
9418 2005-04-22 Marek Safar <marek.safar@seznam.cz>
9420 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
9423 2005-04-20 John Luke <john.luke@gmail.com>
9425 * driver.cs: fix typo in error message, --outout to --output
9427 2005-04-20 Marek Safar <marek.safar@seznam.cz>
9429 * codegen.cs (InRefOutArgumentResolving): New field.
9431 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
9432 fields outside contructor.
9434 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
9436 2005-04-19 Miguel de Icaza <miguel@novell.com>
9438 * anonymous.cs (CaptureContext.EmitParameterInstance): The
9439 parameter code was not completed ever, so it was not as up-to-date
9440 as local variables. Must finish it.
9442 The bug fix was to compare the Toplevel of the block, not the
9443 current block. Thanks for Ben for pointing this out.
9445 2005-04-19 Raja R Harinath <rharinath@novell.com>
9447 * decl.cs (AddMethods): Use the declaring type of the problem
9448 method to determine if we want to squash a warning.
9450 2005-04-19 Marek Safar <marek.safar@seznam.cz>
9452 * attribute.cs: Removed debug output.
9454 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
9456 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
9459 2005-04-18 Raja R Harinath <rharinath@novell.com>
9462 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
9463 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
9464 all null comparisons against reference types.
9466 2005-04-18 Marek Safar <marek.safar@seznam.cz>
9469 * class.cs (TypeContainer.CircularDepException) New nested
9471 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
9472 (TypeContainer.DefineType): Removed error, reset InTransit before
9474 (Class.DefineType): Throw exception when is in Transit.
9475 Catch exception and report error.
9476 (Struct.DefineType): Throw exception when is in Transit.
9477 Catch exception and report error.
9478 (Interface.DefineType): Throw exception when is in Transit.
9479 Catch exception and report error.
9481 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
9482 handle nested exception handlers.
9484 * flowanalysis.cs (InTryWithCatch): New method, search for try with
9487 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
9488 InFinally and InCatch storage.
9490 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
9491 (Catch.Resolve): Set and Restore ec.InCatch.
9492 (Try.Resolve): Set and Restore ec.InFinally.
9493 (Try.HasCatch): True when try has catch.
9495 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
9497 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
9498 for the same event member, so exclude such cases from warning 419.
9501 2005-04-16 Miguel de Icaza <miguel@novell.com>
9503 * expression.cs (Binary.ResolveOperator): Apply patch from John
9504 Luke to fix bug 59864: operators &, | and ^ on enumerations
9505 require that the same enum type on both sides.
9507 * driver.cs: Add warnings to old flag usage, this is to assist
9508 people who produce Makefiles and hope that the Makefiles will be
9511 * class.cs (TypeContainer.EmitType): Moved the definition of the
9512 special $PRIVATE$ field from the resolve phase to the Emit phase.
9513 During resolve we do not know if we are a struct with
9514 HasExplicitLayout, we know this only after the attributes for the
9517 Set the FieldOffset to zero on the dummy field that we create for
9518 the class. Fixes 74590.
9520 2005-04-16 Raja R Harinath <rharinath@novell.com>
9523 * ecore.cs (PropertyExpr.resolved): New.
9524 (DoResolve): Use it to handle a case of double resolution here.
9525 Handle a case of identical-name-and-type-name.
9526 * expression.cs (ArrayCreation.CheckIndices): Avoid double
9527 resolution by storing the results of expression resolution back
9528 into the "probes" array.
9530 2005-04-15 Raja R Harinath <rharinath@novell.com>
9532 Fix cs0208-7.cs and cs0208-8.cs.
9533 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
9534 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
9535 error reporting to point out the reason a struct is not unmanaged.
9537 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9539 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
9540 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
9542 2005-04-13 Raja R Harinath <rharinath@novell.com>
9545 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
9546 IdenticalNameAndTypeName here.
9547 (EventExpr.InstanceResolve): Likewise.
9549 2005-04-13 Marek Safar <marek.safar@seznam.cz>
9551 C# 2.0 DefaultCharSetAttribute implementation
9553 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
9554 which allows us to set GlobalNamespace for every resolve.
9555 (Attribute.ResolveArguments): Cut from Resolve.
9556 (Attribute.GetCharSetValue): Returns CharSet named argument.
9557 (Attribute.DefinePInvokeMethod): Gets default charset from
9559 (GlobalAttribute.ResolveAsTypeStep): Override.
9560 (GlobalAttribute.ResolveArguments): Override.
9562 * class.cs (TypeAttr): Is protected.
9564 * codegen.cs (ModuleClass.DefaultCharSet): New member.
9565 (ModuleClass.DefaultCharSetType): New memeber.
9566 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
9568 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
9569 charset from module.
9571 * delegate.cs (TypeAttr): Override.
9572 (Delegate.DefineType): Use this TypeAttr.
9574 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
9575 at very early stage (before types are defined) to resolve model
9576 module attributes. It will probably not work with corlib but it
9579 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
9580 charset from module.
9582 * typemanager.cs (default_charset_type): New type.
9584 2005-04-13 Raja R Harinath <rharinath@novell.com>
9586 * decl.cs (MemberCache.AddMethods): Don't warn if
9587 System.Object.Finalize has buggy MethodAttributes.
9589 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
9592 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9594 * doc.cs : detect ambiguous reference to overloaded members.
9595 Fixed bug #71603. MS 1.1 csc does not detect it.
9597 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9599 * doc.cs : delegates must not be referenced with parameters.
9602 2005-04-12 Miguel de Icaza <miguel@novell.com>
9604 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
9606 2005-04-10 Miguel de Icaza <miguel@novell.com>
9608 * driver.cs (MainDriver): Stop processing if the CLS stage found
9611 (CompilerCallableEntryPoint.InvokeCompiler): Always
9612 reset after execution; Take a TextWriter argument for the
9615 * report.cs: Use the error stream instead of hardcoding stderr.
9617 2005-04-09 Miguel de Icaza <miguel@novell.com>
9619 * class.cs: Reduce code paths to test, too small of an
9620 optimization to make it worth the extra testing. Always perform
9623 2005-04-08 Raja R Harinath <rharinath@novell.com>
9626 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
9627 operators that had errors reported on them.
9629 2005-04-08 Marek Safar <marek.safar@seznam.cz>
9631 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
9633 (Attribute.Resolve): Add named argument type checking.
9635 * class.cs (FixedField.Define): Use IsPrimitiveType
9637 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
9639 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
9640 unsafe parameter types.
9642 * statement.cs (Using.ResolveExpression): Add better error description.
9644 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
9646 2005-04-08 Raja R Harinath <rharinath@novell.com>
9649 * attribute.cs (Attribute.GetAttributeUsage): Resolve
9650 AttributeUsageAttribute in the emitcontext of the attribute class,
9651 not in the emitcontext of the attributable entity it was attached to.
9652 * cs-parser.jay: Use 'current_class', not 'current_container',
9653 when creating a GlobalAttribute.
9655 2005-04-08 Alp Toker <alp@atoker.com>
9657 * pending.cs: The fix to #58413 failed to compile methods implementing
9658 interfaces with/without params modifiers and vice versa, even though
9659 params modifiers aren't part of the signature. Make the modifier check
9660 less strict as in csc.
9662 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
9663 Anoob V E <projectmonokochi@rediffmail.com>
9664 Harilal P R <projectmonokochi@rediffmail.com>
9667 * pending.cs (TypeAndMethods.mods): New. Store the parameter
9668 modifiers of pending methods.
9669 (PendingImplementation.PendingImplementation): Initialize it.
9670 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
9671 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
9672 with ParameterData. Add check for modifiers.
9673 * class.cs (MethodData.Define): Update to changes.
9675 2005-04-07 Raja R Harinath <rharinath@novell.com>
9677 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
9679 2005-04-07 Marek Safar <marek.safar@seznam.cz>
9681 * class.cs (PropertyMethod.Define): Check private accessor in abstract
9684 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
9687 * typemanager.cs: Registered RequiredAttributeAttribute.
9689 2005-04-06 Marek Safar <marek.safar@seznam.cz>
9691 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
9692 Warning CS0169 is back at level 3.
9693 (IMethodData.SetMemberIsUsed): New method.
9695 * decl.cs (IsUsed): New value; moved from FieldBase.Status
9696 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
9698 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
9700 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
9702 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
9705 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
9708 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
9709 to avoid the problems with nested types.
9711 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
9712 Anoob V.E <projectmonokochi@rediffmail.com>
9713 Harilal P.R <projectmonokochi@rediffmail.com>
9714 Raja R Harinath <rharinath@novell.com>
9717 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
9719 * typemanager (GetConstructor): Make public.
9721 2005-04-05 John Luke <john.luke@gmail.com>
9722 Raja R Harinath <rharinath@novell.com>
9725 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
9726 struct too. Return false quicker in a few cases.
9727 (VerifyUnManaged): Use it.
9729 2005-04-05 Raja R Harinath <rharinath@novell.com>
9732 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
9733 not 'unreachable_seen'.
9735 2005-04-04 Marek Safar <marek.safar@seznam.cz>
9737 * attribute.cs (Attribute.GetValue): Removed unused.
9739 * codegen.cs (CodeGen.TrimExt): Removed unused.
9741 * cs-parser.jay (output): Removed unused.
9743 * cs-tokenizer.cs (hex_digits): Removed unused.
9745 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
9747 * expression.cs (Indirection.LoadExprValue): Removed unused.
9748 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
9750 * iterators.cs (Iterator.param_types): Removed unused.
9752 * statement.cs (Goto.block): Removed unused.
9753 (ToplevelBlock.did): Removed unused.
9754 (Switch.ResolveConstantSwitch): Removed unused.
9756 2005-04-01 Ben Maurer <bmaurer@ximian.com>
9758 * rootcontext.cs: Allow mcs to bootstrap with the compilation
9761 2005-04-01 Raja R Harinath <rharinath@novell.com>
9763 Fix #74232 and cs0208-3.cs.
9764 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
9765 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
9766 unmanaged type. Don't use FieldBuilders when 't' is a
9767 TypeBuilder. Use ModFlags and MemberType fields.
9768 * class.cs (MemberBase.member_type): Rename from MemberType.
9769 (MemberBase.MemberType): New property. Determines member_type on
9771 (MemberBase.DoDefine): Don't initialize MemberType here.
9772 (FieldMember.Define): Likewise.
9774 2005-04-01 Marek Safar <marek.safar@seznam.cz>
9777 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
9778 Attributes are emitted there.
9780 2005-04-01 Raja R Harinath <rharinath@novell.com>
9782 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
9783 keyword in 'partial enum' too.
9784 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
9786 Report from Kamil Skalski <nazgul@omega.pl>.
9789 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
9790 have partial containers too.
9792 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
9793 in block' checks to Block.CheckInvariantMeaningInBlock.
9794 * statement.cs (Block.GetKnownVariableInfo): Make private.
9795 (Block.IsVariableUsedInChildBlock): Remove.
9796 (Block.IsVariableUsedInBlock): Likewise.
9797 (Block.CheckInvariantMeaningInBlock): New. Show location of
9798 conflicting declaration.
9799 (Block.AddVariable): Make error messages less long-winded and more
9800 specific. Show location of conflicting declaration.
9801 * parameter.cs (Parameters.Location): New readonly property.
9803 2005-03-31 Raja R Harinath <rharinath@novell.com>
9805 Clean up semantics of invoking ResolveMemberAccess.
9806 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
9807 can have an instance, ensure that we pass in a non-TypeExpression
9808 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
9809 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
9810 argument. Update to changes and simplify.
9811 (FieldExpr.Emitinstance): Remove CS0120 check.
9812 (PropertyExpr.EmitInstance): Likewise.
9813 * expression.cs (Argument.Resolve): Likewise.
9814 (Invocation.DoResolve): Update to changes in semantics of
9817 2005-03-31 Marek Safar <marek.safar@seznam.cz>
9820 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
9823 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
9825 2005-03-31 Raja R Harinath <rharinath@novell.com>
9827 Fix difference in behaviour with commandline invocation.
9828 * driver.cs (Driver.Reset): New.
9829 (CompilerCallableEntryPoint): Call it.
9831 * statement.cs (If.Resolve): Avoid spurious "uninitialized
9832 variable" warnings if the boolean expression failed to resolve.
9834 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
9836 * attribute.cs: Fix the union of several permissions when some of them
9837 are unrestricted (so the result isn't an unrestricted permission set).
9840 2005-03-30 Raja R Harinath <rharinath@novell.com>
9842 * ecore.cs (MemberExpr): New class. Convert from interface
9844 (MemberExpr.ResolveMemberAccess): Refactor and move here from
9845 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
9847 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
9848 (MethodGroupExpr.IsExplicitImpl): Remove.
9849 (Expression.GetFieldFromEvent): Remove.
9850 (SimpleName.MemberStaticCheck): Remove.
9851 (SimpleName.DoSimpleNameResolve): Update to changes.
9852 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
9853 (MemberAccess.IdenticalNameAndTypeName): Remove.
9854 (MemberAccess.error176): Move to MemberExpr.
9855 (MemberAccess.DoResolve): Update to changes.
9856 (BaseAccess.DoResolve): Likewise.
9858 2005-03-30 Marek Safar <marek.safar@seznam.cz>
9860 C# 2.0 Conditional attribute class implementation
9862 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
9863 Analyzes class whether it has attribute which has ConditionalAttribute
9864 and its condition is not defined.
9866 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
9867 (Class.IsExcluded): New method. Search for at least one defined
9868 condition in ConditionalAttribute of attribute class.
9870 2005-03-30 Raja R Harinath <rharinath@novell.com>
9872 * ecore.cs (PropertyExpr): Derive from Expression, not
9873 ExpressionStatement.
9874 (PropertyExpr.EmitStatement): Remove.
9876 2005-03-29 Raja R Harinath <rharinath@novell.com>
9879 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
9880 internal field "value__" of an enum be private. The examples for
9881 "value__" that I found on MSDN all used FieldAttributes.Private.
9883 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
9884 Don't mention IL method attribute names.
9886 Fix #47991. Remove a TODO.
9887 * statement.cs (Block.Toplevel): Make into a field.
9888 (Block.Parameters): Move into ToplevelBlock.
9889 (Block.known_variables): Rename from child_variable_names.
9890 (Block.Block): Remove variants that take Parameters. Initialize
9891 'Toplevel' with the immediately surrounding toplevel block.
9892 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
9893 LocalInfo parameter.
9894 (Block.GetKnownVariableInfo): New.
9895 (Block.IsVariableNameUsedInChildBlock): Update.
9896 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
9897 the block, even though it may not be in scope.
9898 (Block.AddVariable): Remove Parameters parameter. Use
9899 Toplevel.Parameters instead.
9900 (Block.AddConstant): Remove Parameters parameter.
9901 (Block.GetParameterReference): Update to use Toplevel.Parameters.
9902 (Block.IsParamaterReference): Likewise.
9903 (Block.IsLocalParameter): Likewise. Simplify a lot.
9904 (ToplevelBlock.Parameters): New. Moved from Block.
9905 (ToplevelBlock.ToplevelBlock): Update to changes. Always
9906 initialize Parameters to a non-null value.
9907 * cs-parser.jay: Update to changes.
9908 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
9909 simple names that mean different things in the same block. Use
9910 Block.IsVariableNameUsedInBlock.
9912 2005-03-28 Raja R Harinath <rharinath@novell.com>
9914 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
9915 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
9916 GetTypeHandle. It is possible for a reflected type to derive from
9917 a TypeBuilder (e.g., int[] derives from the TypeBuilder
9918 System.Array during mscorlib compilation).
9919 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
9920 contain a method_hash, don't create one either. Don't create a
9921 deep copy of the base cache's method_hash.
9922 (MemberCache.SetupCache): Rename back from DeepCopy.
9923 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
9924 already initialized. If we see an override function, add its
9925 underlying base virtual function to the member_hash too.
9927 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
9929 2005-03-26 Raja R Harinath <harinath@acm.org>
9932 * assign.cs (Assign.DoResolve): When the RHS of an assignment
9933 fails to resolve, ensure that the LHS is still resolved as an
9936 2005-03-25 Raja R Harinath <harinath@acm.org>
9938 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
9940 (Enum.current_ec): Remove.
9941 (Enum.LookupEnumValue): Remove EmitContext argument.
9942 Just uses the one created during DefineType.
9943 (Enum.FindMembers): Update.
9944 * expression.cs (MemberAccess.DoResolve): Update.
9946 2005-03-22 Marek Safar <marek.safar@seznam.cz>
9948 * assign.cs (Assign.DoResolve): Check for CS1717 when
9949 source and target are same (uses Equals).
9951 * expression.cs (LocalVariableReference, ParameterReference,
9952 This): Implemented Equals, GetHashCode.
9954 * statement.cs (Block.GetParameterReference): Removed useless
9957 2005-03-22 Raja R Harinath <rharinath@novell.com>
9960 * statement.cs (Block.AddVariable): Ensure that we skip implicit
9961 blocks before deciding whether the error is cs0136 or cs0128.
9963 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
9964 (using_alias_directive, using_namespace_directive): Pass
9965 MemberName, not an expression to Namespace.UsingAlias and
9967 (MakeName): Use the MemberName of the namespace.
9968 * namespace.cs (Namespace.MemberName): New.
9969 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
9970 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
9972 * decl.cs (MemberName.Name): Make readonly.
9973 (MemberName.FromDotted): New "constructor".
9974 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
9975 (MemberCore.Name): Compute from MemberName on demand.
9976 (MemberCore.SetMemberName): Provide a way to change the
9978 (MemberCore.AddToContainer): Don't take a fullname parameter.
9979 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
9980 fully qualified name of the container to the member name.
9981 (TypeContainer.AddToTypeContainer): Use a fully qualified name
9982 only if the type is a member of the root container.
9983 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
9984 MemberName.Left rather than searching for an embedded ".".
9985 (PartialContainer.CreatePart): Update to changes in RootContext.
9986 (MemberBase.ShortName): Turn into a property. Use
9987 MemberCore.SetMemberName.
9988 (MemberBase.ExplicitInterfaceName): Remove.
9989 (MemberBase.UpdateMemberName): Remove.
9990 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
9991 (PropertyBase.SetMemberName): New override.
9992 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
9993 (Tree.GetDecl): New.
9994 (Tree.AllDecls): Rename from Decls.
9995 * attribute.cs, enum.cs, report.cs: Update to changes.
9996 * driver.cs (MainDriver): Use MemberName.FromDotted on
9997 RootContext.MainClass.
9999 2005-03-21 Marek Safar <marek.safar@seznam.cz>
10001 * class.cs (FixedField.Define): Check for CS1664 and more sanity
10004 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
10006 2005-03-18 Marek Safar <marek.safar@seznam.cz>
10008 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
10009 property accessor modifiers.
10011 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
10012 fixed buffer attribute (CS1716).
10013 (PropertyMethod.HasCustomAccessModifier): When property accessor
10014 has custom modifier.
10016 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
10018 (PropertyExpr.DoResolveLValue): Add CS0272.
10020 2005-03-17 Miguel de Icaza <miguel@novell.com>
10022 * convert.cs: When converting to a pointer, use the proper Conv.U
10023 or Conv.I depending on the source data type.
10025 * cs-tokenizer.cs: Make the size for large decimal constants,
10028 2005-03-17 Martin Baulig <martin@ximian.com>
10030 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
10031 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
10033 2005-03-17 Martin Baulig <martin@ximian.com>
10035 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
10036 to bool so we can return an error condition.
10037 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
10040 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
10042 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
10045 2005-03-16 Raja R Harinath <rharinath@novell.com>
10047 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
10048 Refactor to avoid traversing the list of assemblies, and to avoid
10049 string concatenation.
10050 * typemanager.cs (guid_attr_type): Remove.
10051 (negative_hits, pointers, references): Remove hashes.
10053 (GetConstructedType): New. Uses type_hash to handle constructed
10054 types (arrays, references, pointers).
10055 (GetReferenceType, GetPointerType): Use it.
10056 (GetNestedType): New. Uses type_hash to handle nested types of
10058 (LookupType, LookupTypeDirect): Remove.
10059 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
10060 'types' hash and LookupTypeReflection directly.
10061 (params_string, params_object): Use GetConstructedType.
10062 * namespace.cs (Namespace.cached_types): New. Cache of reflected
10064 (Namespace.Lookup): Use cached_types.
10065 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
10066 provided by old TypeManager.LookupType.
10067 * rootcontext.cs (MakeFQN): Remove.
10068 * decl.cs (DeclSpace.MakeFQN): Likewise.
10069 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
10070 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
10071 TypeManager.GetConstructedType.
10072 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
10074 2005-03-15 Marek Safar <marek.safar@seznam.cz>
10076 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
10079 * cs-parser.jay: Reports CS1527 for any namespace element.
10081 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
10084 * expression.cs (ParameterReference.IsAssigned): Changed error to
10086 (Error_WrongNumArguments): Moved CS0245 detection here.
10088 * statement.cs (Return.Resolve): Add CS1622 report.
10090 2005-03-11 Marek Safar <marek.safar@seznam.cz>
10092 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
10094 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
10096 * attribute.cs expression.cs: Get rid of some allocations.
10098 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
10100 * doc.cs : just eliminate the latest change.
10102 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10104 * doc.cs : commented out the latest change. It breaks xml-030.cs
10106 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10108 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
10109 fail. So invoke CreateType() in FindDocumentedType().
10111 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10113 * cs-tokenizer.cs : added IsKeyword().
10114 * doc.cs : Detect keyword incorrectly used as identifier.
10115 Allow identifiers prefixed by @.
10117 2005-03-10 Marek Safar <marek.safar@seznam.cz>
10119 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
10120 It caused exception in namespace resolving (again!).
10122 * class.cs (Class.ctor): Removed exit.
10123 (PropertyMethod.ctor): ditto.
10125 * codegen.cs (Codegen.Reset): Reset static data.
10126 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
10128 * cs-tokenizer.cs (Cleanup): Removed.
10130 * driver.cs (GetSystemDir): Rewrote to one line command.
10131 It caused problem with unloaded dynamic modules.
10132 (UnixParseOption): Removed Exit.
10133 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
10134 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
10135 Now can be mcs used as library.
10137 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
10140 * location.cs (Reset): Reset static data.
10142 * namespace.cs (Reset): Reset static data.
10144 * report.cs (Report.Reset): Reset static data.
10146 * rootcontext.cs (RootContext.Reset): Reset static data.
10148 * tree.cs (RootTypes.ctor): Use Location.Null
10150 * typemanager.cs (TypeManager.Reset): Reset static data.
10151 (CoreLookupType): Removed Exit.
10152 (TypeHandle.Reset): Reset static data.
10154 2005-03-10 Raja R Harinath <rharinath@novell.com>
10157 * typemanager.cs (ComputeNamespaces): Import namespaces from
10158 referenced modules too.
10160 2005-03-09 Raja R Harinath <rharinath@novell.com>
10162 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
10165 2005-03-09 Raja R Harinath <rharinath@novell.com>
10167 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
10168 enclosing DeclSpace. This ensures that a name-lookup populates
10169 more caches and there are fewer 'TypeExpression's. Carve out
10170 nested type lookup into ...
10171 (LookupNestedTypeInHierarchy): ... this.
10173 2005-03-09 Raja R Harinath <rharinath@novell.com>
10175 Clean up a few partial-class semantics.
10176 Fixes test-357.cs and cs1618-2.cs.
10177 * cs-parser.jay (struct_declaration): Use 'current_class' as
10178 parent of newly-created struct. Remove call to Register ().
10179 Use 'pop_current_class' to complete handing the current struct.
10180 (interface_declaration): Likewise.
10181 (class_declaration): Likewise.
10182 (enum_declaration): Use 'current_class' as parent of newly created
10184 (delegate_declaration): Likewise.
10185 (pop_current_class): New function. This is used to handle closing
10186 up the 'current_class' and 'current_container', and pointing them
10187 to the enclosing class/container.
10188 (CSharpParser): Initialize 'current_class' too.
10189 * decl.cs (MemberCore): Add check for invariant: a partial
10190 container is not a parsed entity, and thus does not enclose any
10192 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
10193 (DeclSpace.BaseTypeExpr): Use it.
10194 (DeclSpace.LookupType): Add check for invariant.
10195 * class.cs (TypeContainer): Add check for invariant: a nested
10196 class should have the same NamespaceEntry as its enclosing class.
10197 (TypeContainer.EmitFieldInitializers): Make virtual.
10198 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
10200 (TypeContainer.Register): Remove.
10201 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
10202 null. Use TypeResolveEmitContext for resolving base types and
10203 interfaces. Move initialization of Parts.TypeBuilder here from
10205 (TypeContainer.DefineNestedTypes): ... here.
10206 (PartialContainer): Take a Namespace not a NamespaceEntry.
10207 (PartialContainer.Create): Don't use Register. Call the
10208 appropriate Add... function directly.
10209 (ClassPart): Take both the PartialContainer and the enclosing
10210 class as constructor arguments.
10211 (ClassPart.EmitFieldInitializers): Override.
10212 (ClassPart.PartFindNestedTypes): Remove.
10213 (FieldBase.GetInitializerExpression): Resolve the initializer
10214 expression in the emit context of the enclosing class.
10215 * tree.cs (RootTypes): Remove Register ().
10217 2005-03-08 Marek Safar <marek.safar@seznam.cz>
10219 * cs-parser.jay: Removed CS0134.
10221 * driver.cs: Removed CS1901.
10223 * expression.cs (SizeOf.DoResolve): Don't report CS0233
10224 for predefined types.
10226 2005-03-07 Duncan Mak <duncan@novell.com>
10228 * codegen.cs (Save): Catch UnauthorizedAccessException as
10229 well. Fixes bug #73454.
10231 2005-03-07 Marek Safar <marek.safar@seznam.cz>
10233 * cs-tokenizer.cs (xtoken): Add CS1035.
10235 * class.cs (MethodData.Define): Add CS0683.
10236 (FieldMember.ctor): Add CS0681.
10238 2005-03-07 Raja R Harinath <rharinath@novell.com>
10240 * ecore.cs (SimpleName.DoResolve): Rename from
10241 SimpleName.DoResolveAllowStatic.
10242 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
10243 Pass 'intermediate' flag to MemberStaticCheck.
10244 (SimpleName.MemberStaticCheck): Skip "static check" only in case
10245 of "intermediate" lookups via MemberAccess.
10246 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
10247 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
10249 2005-03-07 Raja R Harinath <rharinath@novell.com>
10252 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
10253 slipped in because of variable names that are identical to a
10254 builtin type's BCL equivalent ('string String;', 'int Int32;').
10255 (PropertyExpr.EmitInstance): Likewise.
10257 2005-03-04 Marek Safar <marek.safar@seznam.cz>
10259 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
10261 * report.cs (warning_ignore_table): Made public.
10263 2005-03-04 Raja R Harinath <rharinath@novell.com>
10266 * class.cs (MethodData.Emit): Pass 'container' to
10267 container.GetObsoleteAttribute instead of 'container.Parent'.
10269 2005-03-03 Marek Safar <marek.safar@seznam.cz>
10271 * cs-parser.jay: Add 1534 error test.
10273 * iterators.cs (Yield.CheckContext): Add error 1629.
10274 (Iterator.ctor): Save unsafe modifier.
10275 (MoveNextMethod.DoEmit): Restore unsafe context.
10277 * namespace.cs (UsingAlias): Better error message.
10279 2005-03-03 Dan Winship <danw@novell.com>
10281 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
10282 the warning message [#73219]
10284 2005-03-03 Raja R Harinath <rharinath@novell.com>
10286 Fix compile with MCS 1.0.0.0.
10287 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
10288 w_restore to not depend on string constant folding.
10290 2005-03-03 Raja R Harinath <rharinath@novell.com>
10292 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
10293 CS0246 check to users who passed 'silent = false'.
10294 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
10296 (SimpleName.SimpleNameResolve): Update.
10297 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
10298 (MemberAccess.IdenticalNameAndTypeName): Update.
10299 * doc.cs (FindDocumentedTypeNonArray): Update.
10301 2005-03-03 Raja R Harinath <rharinath@novell.com>
10303 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
10304 * parameters.cs (ComputeAndDefineParameters): Remove.
10305 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
10306 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
10307 Use GetParameterInfo.
10309 2005-03-02 Marek Safar <marek.safar@seznam.cz>
10311 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
10313 2005-03-02 Raja R Harinath <rharinath@novell.com>
10315 Unify DeclSpace.LookupType and DeclSpace.FindType.
10316 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
10317 is in charge of defining nested types on demand.
10318 (DeclSpace.LookupType): Use it when the current_type is a
10319 TypeBuilder. Use LookupTypeDirect for reflected types.
10320 (DeclSpace.FindType): Remove.
10321 (DeclSpace.LookupInterfaceOrClass): Likewise.
10322 (DeclSpace.DefineTypeAndParents): Likewise.
10323 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
10324 DeclSpace.LookupType.
10325 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
10326 * typemanager.cs (LookupType): Simplify.
10327 (AddUserType): Remove type from negative_hits.
10328 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
10329 * class.cs (TypeContainer.FindMembers): Move handling of nested
10331 (TypeContainer.FindMembers_NestedTypes): ... here.
10332 (TypeContainer.FindNestedType): Implement override.
10333 (ClassPart.FindNestedType): Delegate to PartialContainer.
10334 (ClassPart.PartFindNestedType): Looks up the nested types of the
10337 2005-03-02 Martin Baulig <martin@ximian.com>
10339 * class.cs (TypeContainer.DoDefineMembers): We also need a default
10340 static constructor in static classes.
10342 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
10344 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
10345 sizeParamIndex is not specified.
10347 2005-03-01 Marek Safar <marek.safar@seznam.cz>
10350 * report.cs (WarningMessage.IsEnabled): Missing null check.
10352 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10354 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
10355 in the fields and not in the properties.
10357 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
10359 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
10362 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10364 * attribute.cs: Small refactoring (improved robustness).
10365 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
10366 (ValidateGuid): Removed.
10367 (Resolve): Removed referenced to above mentioned.
10368 (GetAttributeUsage): Made private and changed to work without
10370 (GetIndexerAttributeValue): Don't crash.
10371 (GetConditionalAttributeValue): Ditto.
10372 (GetClsCompliantAttributeValue): Ditto.
10373 (ExtractSecurityPermissionSet): All attributes exceptions are
10375 (GetPropertyValue): New helper.
10376 (GetMethodImplOptions): New method.
10377 (DefinePInvokeMethod): Reuse common code. Implemented handling of
10378 some missing properties.
10380 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
10381 (Method.ApplyAttributeBuilder): Updated.
10383 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
10386 2005-02-28 Raja R Harinath <rharinath@novell.com>
10389 * report.cs (Report.SymbolRelatedToPreviousError): Handle
10390 non-simple types (array, pointer, reference).
10392 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10394 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
10396 * class.cs (MethodCore.IsDuplicateImplementation): Special error
10398 (Method.CheckBase): Catch wrong destructor here.
10399 (MethodData.Define): Add errors 550, 668.
10401 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
10403 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
10405 * pending.cs (VerifyPendingMethods): Add error 551.
10407 * typemanager.cs (CSharpName): Next error report helper.
10409 2005-02-25 Marek Safar <marek.safar@seznam.cz>
10411 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
10412 attributes. Removed useless attribute double check.
10413 It saves almost 2MBs for corlib.
10415 2005-02-25 Raja R Harinath <rharinath@novell.com>
10418 * statement.cs (ExpressionStatement.Resolve): Make robust to being
10419 called twice in case of error.
10421 2005-02-23 Chris Toshok <toshok@ximian.com>
10423 Fix compiler portions of #72827.
10424 * statement.cs (Block.Emit): call Begin/EndScope on the
10425 EmitContext instead of the ILGenerator.
10427 * codegen.cs (EmitContext.BeginScope): new method, call
10428 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
10430 (EmitContext.BeginScope): same, but EndScope and CloseScope
10432 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
10433 offset and call the superclass's OpenScope(int) with it.
10434 (SymbolWriter.CloseScope): get the current il
10435 offset and call superclass's CloseScope(int) with it.
10437 2005-02-23 Marek Safar <marek.safar@seznam.cz>
10439 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
10440 CS1677 for out and ref as well.
10442 * class.cs (Method.Define): Add error CS1599 detection.
10444 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
10446 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
10448 * delegate.cs (Delegate.Define): Add error CS1599 detection.
10450 * support.cs.cs (ModifierDesc): New helper method.
10452 2005-02-23 Raja R Harinath <rharinath@novell.com>
10453 Abin Thomas <projectmonokochi@rediffmail.com>
10454 Anoob V E <projectmonokochi@rediffmail.com>
10455 Harilal P R <projectmonokochi@rediffmail.com>
10457 Fix #57851, #72718.
10458 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
10459 MemberLookup (used for error reporting) actually returns a result.
10460 Fix error report number (122, not 112).
10462 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
10463 Anoob V E <projectmonokochi@rediffmail.com>
10464 Harilal P R <projectmonokochi@rediffmail.com>
10467 * pending.cs (PendingImplementation.GetAbstractMethods):
10468 Find NonPublic members too.
10470 2005-02-22 Marek Safar <marek.safar@seznam.cz>
10472 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
10475 * class.cs (MethodCore.CheckMethodAgainstBase):
10476 Add error 239 report.
10478 2005-02-21 Raja R Harinath <rharinath@novell.com>
10481 * expression.cs (Invocation.IsApplicable): Make public.
10482 (Invocation.IsParamsMethodApplicable): Likewise.
10483 * delegate.cs (Delegate.VerifyApplicability): Don't use
10484 Invocation.VerifyArgumentCompat for parameter applicability
10485 testing. Use Invocation.IsApplicable and
10486 Invocation.IsParamsMethodApplicable.
10488 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10490 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
10492 * class.cs (Operator.Define): Add error 217 report.
10494 2005-02-21 Raja R Harinath <rharinath@novell.com>
10496 * namespace.cs (UsingEntry.Resolve): Undo change below.
10498 2005-02-21 Raja R Harinath <rharinath@novell.com>
10501 * ecore.cs (Expression.MemberLookupFailed): Add argument to
10502 disable the error message when the extended MemberLookup also
10504 (Expression.MemberLookupFinal): Update.
10505 (SimpleName.DoSimpleNameResolve): Update.
10506 * expression.cs (MemberAccess.ResolveNamespaceOrType):
10507 Don't use MemberLookupFinal.
10508 (New.DoResolve): Update.
10509 (BaseAccess.CommonResolve): Update.
10511 2005-02-21 Raja R Harinath <rharinath@novell.com>
10514 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
10515 occured previously, don't resolve again.
10517 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10520 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
10521 argument. Call ResolveAttributeUsage for unresolved.
10522 when types doesn't match ctor arguments.
10524 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
10525 for nested attribute classes.
10526 (Class.attribute_usage): Removed.
10527 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
10528 for attribute class.
10530 * ecore.cs (IsAttribute): Removed.
10532 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
10534 * rootcontext.cs (RegisterAttribute): Removed, attributes are
10536 (attribute_types): Removed.
10537 (EmitCode): Global attributes are emited as the latest.
10539 2005-02-18 Marek Safar <marek.safar@seznam.cz>
10541 * class.cs (EmitFieldInitializers): Don't emit field initializer
10542 for default values when optimilization is on.
10544 * constant.cs (Constant.IsDefaultValue): New property.
10546 * driver.cs: Add /optimize handling.
10550 * literal.cs: Implement new IsDefaultValue property.
10552 * rootcontext.cs (Optimize): New field, holds /optimize option.
10554 2005-02-18 Raja R Harinath <rharinath@novell.com>
10556 Fix crasher in re-opened #72347.
10557 * namespace.cs (Namespace.Lookup): Return null if
10558 DeclSpace.DefineType returns null.
10561 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
10563 2005-02-18 Raja R Harinath <rharinath@novell.com>
10565 Fix remainder of #63202. Change semantics of DoResolveLValue: it
10566 now returns null if it cannot resolve to an lvalue.
10567 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
10568 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
10569 returned null. Remove check for SimpleName.
10570 (EventExpr.DoResolveLValue): New.
10571 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
10572 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
10574 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
10575 avoid CS0131 error.
10576 (Unary.ResolveOperator): Move CS0211 check ...
10577 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
10579 (Unary.DoResolveLValue): Simplify.
10580 (AddressOf.DoResolveLValue): New.
10581 (ArrayAccess.DoResolveLValue): New.
10583 2005-02-16 Marek Safar <marek.safar@seznam.cz>
10585 * attribute.cs (Attribute.Resolve): Add arguments casting for
10586 when types doesn't match ctor arguments.
10588 2005-02-16 Raja R Harinath <rharinath@novell.com>
10590 Fix parts of #63202.
10591 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
10592 lookup of operator in base type. Ensure that all checks happen
10593 when the operator resolves to an "op_..." method.
10595 2005-02-15 Raja R Harinath <rharinath@novell.com>
10598 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
10599 'ignore_cs0104' parameter. Pass it to ...
10600 (NamespaceEntry.Lookup): ... this.
10601 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
10602 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
10603 (TypeLookupExpression.DoResolveAsTypeStep): Update.
10604 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
10605 Update. Request that cs0104 errors be ignored.
10606 (ComposedCast.ResolveAsTypeStep): Update.
10608 2005-02-14 Raja R Harinath <rharinath@novell.com>
10611 * expression.cs (Invocation.BetterFunction): Remove support for
10612 comparing virtual functions and their overrides.
10613 (Invocation.IsOverride): New.
10614 (Invocation.OverloadResolve): Don't consider 'override' functions
10615 during candidate selection. Store them in a lookaside list.
10616 If the selected method is a 'virtual' function, use the list to
10617 find any overrides that are closer to the LHS type.
10619 2005-02-14 Marek Safar <marek.safar@seznam.cz>
10621 * expression.cs (New.DoResolve): Add complex core type reduction.
10622 (New.Constantify): Converts complex core type syntax like 'new int ()'
10623 to simple constant.
10625 2005-02-14 Raja R Harinath <rharinath@novell.com>
10627 * decl.cs (EntryType.EntryType): New constructor to create an
10628 updated copy of a cache entry.
10629 (MemberCache.AddMethods): Use it.
10630 (MemberCache.ClearDeclaredOnly): Remove.
10631 (MemberCache.MemberCache): Update.
10633 2005-02-11 Miguel de Icaza <miguel@novell.com>
10635 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
10636 variable. This one is represents the actual low-level declaration
10637 of the method, as opposed to the semantic level `IsStatic'.
10639 An anonymous method which is hosted into a static method might be
10640 actually an instance method. IsStatic would reflect the
10641 container, while MethodIsStatic represents the actual code
10644 * expression.cs (ParameterReference): Use the new MethodIsStatic
10645 instead of IsStatic.
10647 * anonymous.cs (AnonymousMethod.Compatible): Pass the
10648 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
10649 set on the current EmitContext.
10651 * expression.cs (Cast): Overload DoResolveLValue so we can pass
10652 resolve our casted expression as an LValue. This triggers the
10653 proper LValue processing that is later required by Assign.
10657 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
10659 2005-02-11 Marek Safar <marek.safar@seznam.cz>
10661 C# 2.0 Fixed buffer implementation
10663 * anonymous.cs: Update after RegisterHelperClass renaming.
10665 * attribute.cs (AttributeTester.fixed_buffer_cache):
10666 Cache of external fixed buffers.
10667 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
10668 implementation if field is fixed buffer else null.
10671 (TypeContainer.AddField): Accept FieldMember instead of Field.
10672 (FieldBase.IsFieldClsCompliant): Extracted code from
10673 VerifyClsCompliance descendant customization.
10674 (FixedField): New class handles fixed buffer fields.
10675 (FixedFieldExternal): Keeps information about imported fixed
10677 (IFixedField): Make access to internal or external fixed buffer
10680 * cs-parser.jay: Add fixed buffer parsing.
10682 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
10685 * expression.cs (Indirection): Extended implementation to accept
10686 fixed buffer field.
10687 (PointerArithmetic.Emit): Get element from fixed buffer as well.
10688 (ElementAccess.MakePointerAccess): Get type as parameter.
10689 (DoResolve): Add fixed buffer field expression conversion.
10690 (DoResolveLValue): Ditto.
10691 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
10692 (ArrayPtr): Derives from FixedBufferPtr.
10693 (ArrayPtr.Emit): Add extra emit for array elements.
10695 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
10697 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
10698 for compiler generated types.
10699 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
10701 * statement.cs (Fixed): Refactored to be easier add fixed buffer
10702 and consume less memory.
10703 (Fixed.Resolve): Add fixed buffer case.
10705 * typemanager.cs (compiler_generated_attr_ctor,
10706 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
10707 (HasElementType): Add our own implementation to work on every
10710 2005-02-11 Miguel de Icaza <miguel@novell.com>
10712 * anonymous.cs (CaptureContext): Track whether `this' has been
10715 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
10716 only captured `this' if it was implicitly done (instance
10717 methods/variables were used).
10719 * codegen.cs (EmitContext.CaptureThis): New method to flag that
10720 `this' must be captured.
10722 2005-01-30 Miguel de Icaza <miguel@novell.com>
10724 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
10725 is null it means that there has been no need to capture anything,
10726 so we just create a sibling.
10728 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
10730 Just a partial fix. The other half is fairly elusive.
10732 2005-02-10 Raja R Harinath <rharinath@novell.com>
10734 Fix #52586, cs0121-4.cs.
10735 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
10736 and return a hashtable.
10737 (MemberCache.ClearDeclaredOnly): New.
10738 (MemberCache.MemberCache): Update to change. Make a deep copy of
10739 the method_hash of a base type too.
10740 (MemberCache.AddMethods): Adapt to having a deep copy of the base
10741 type methods. Overwrite entries with the same MethodHandle so
10742 that the ReflectedType is correct. The process leaves in base
10743 virtual functions and their overrides as distinct entries.
10744 (CacheEntry): Now a class instead of a struct. It shouldn't alter
10745 matters since it was boxed in a ArrayList before.
10746 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
10748 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
10749 case of a virtual function and its override (choose the overload
10751 (Invocation.OverloadResolve): Avoid 'override' members during
10752 'applicable_type' calculation.
10754 2005-02-09 Raja R Harinath <rharinath@novell.com>
10756 Combine two near-redundant caches.
10757 * typemanager.cs (method_params): Rename from method_internal_params.
10758 (TypeManager.GetParameterData): New. Replace
10759 Invocation.GetParameterData.
10760 (TypeManager.LookupParametersByBuilder): Remove.
10761 * expression.cs (Invocation.method_parameter_cache): Remove.
10762 (Invocation.GetParameterData): Remove.
10764 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
10767 2005-02-08 Raja R Harinath <rharinath@novell.com>
10770 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
10771 TypeManager.multicast_delegate_type is null, resolve it by looking
10772 up "System.MulticastDelegate".
10773 * rootcontext.cs (RootContext.ResolveCore): Simplify.
10775 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
10776 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
10777 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
10780 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
10781 (LabeledStatement.AddReference): New. Set 'referenced'.
10782 (Goto.Resolve): Use it.
10784 2005-02-05 John Luke <john.luke@gmail.com>
10786 * driver.cs: remove duplicate -doc line in Usage ()
10788 2005-02-04 Raja R Harinath <rharinath@novell.com>
10790 * location.cs (Location.AddFile): Fix CS2002 error report.
10792 2005-02-02 Martin Baulig <martin@ximian.com>
10794 * delegate.cs (Delegate.DefineType): Report an internal error if
10795 TypeManager.multicast_delegate_type is null. See bug #72015 for
10798 2005-02-02 Raja R Harinath <rharinath@novell.com>
10800 Fix a crasher in a variant of #31984.
10801 * const.cs (Constant.CheckBase): New override that defers the
10802 new-or-override check in case the base type hasn't been populated
10804 (Constant.Define): Ensure the new-or-override check is performed.
10806 2005-02-01 Duncan Mak <duncan@ximian.com>
10808 * const.cs (LookupConstantValue): Check that `ce' is not null
10809 before calling GetValue ().
10811 2005-02-01 Raja R Harinath <rharinath@novell.com>
10813 Fix test-334.cs (#69519).
10814 * cs-parser.jay (using_alias_directive): Pass in an expression to
10815 NamespaceEntry.UsingAlias.
10816 (using_namespace_directive): Pass in an expression to
10817 NamespaceEntry.Using.
10818 (namespace_name): Don't flatten to a string.
10819 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
10820 (NamespaceEntry.AliasEntry.Resolve): Lookup using
10822 (NamespaceEntry.UsingEntry): Likewise.
10823 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
10825 (NamespaceEntry.LookupForUsing): Remove.
10826 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
10828 (NamespaceEntry.Lookup): Remove support for dotted names.
10830 2005-02-01 Raja R Harinath <rharinath@novell.com>
10832 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
10834 (NamespaceEntry.ImplicitParent): Compute on demand.
10835 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
10836 parallels the current.
10837 (NamespaceEntry.LookupForUsing): Use it.
10838 (NamespaceEntry.Lookup): If the current namespace-entry is
10839 implicit, don't search aliases and using tables.
10841 2005-02-01 Raja R Harinath <rharinath@novell.com>
10844 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
10846 (TypeContainer.BaseCache): Compute on demand.
10847 (TypeContainer.FindMembers): Define constants and types if they're
10848 not already created.
10849 (FieldMember.Define): Move resetting of ec.InUnsafe before error
10851 * const.cs (Constant.Define): Make idempotent.
10853 2005-01-29 Miguel de Icaza <miguel@novell.com>
10855 * pending.cs: Produce better code (no nops produced by using Ldarg
10858 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
10859 i - 1' it should be arg + 1.
10863 2005-01-28 Raja R Harinath <rharinath@novell.com>
10865 * attribute.cs (Attribute.CheckAttributeType): Make private
10867 (Attribute.ResolveType): Make virtual.
10868 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
10869 handling of RootContext.Tree.Types.
10871 2005-01-27 Raja R Harinath <rharinath@novell.com>
10873 Update attribute-handling to use the SimpleName/MemberAccess
10875 * cs-parser.jay (attribute): Pass in an expression to the
10876 constructors of Attribute and GlobalAttribute.
10877 * attribute.cs (Attribute): Take an expression for the name.
10878 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
10879 passed in attribute name expression.
10880 (Attribute.CheckAttributeType): Use it.
10881 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
10882 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
10883 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
10884 argument to prevent error messages if the lookup fails.
10886 2005-01-27 Marek Safar <marek.safar@seznam.cz>
10888 * expression.cs (Indirection): Implemented IVariable interface
10889 to support indirection in AddressOf operator.
10890 (PointerArithmetic.Emit): Add optimalization for case where
10891 result can be precomputed.
10893 2005-01-26 Martin Baulig <martin@ximian.com>
10895 * class.cs (TypeContainer.AttributeTargets): Return the correct
10896 AttributeTargets depending on our `Kind' instead of throwing an
10897 exception; fixes #71632.
10899 2005-01-26 Marek Safar <marek.safar@seznam.cz>
10902 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
10905 2005-01-25 Raja R Harinath <rharinath@novell.com>
10908 * expression.cs (MemberAccess.DoResolve): Don't complain with
10909 cs0572 when the LHS of a member access has identical name and type
10912 2005-01-25 Marek Safar <marek.safar@seznam.cz>
10915 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
10917 Create custom PermissionSet only for PermissionSetAttribute.
10919 2005-01-24 Marek Safar <marek.safar@seznam.cz>
10922 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
10923 delegates in static class.
10925 2005-01-24 Martin Baulig <martin@ximian.com>
10927 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
10928 merging an implicit block, just use its reachability.
10930 * statement.cs (Block.Resolve): Make the unreachable code check
10931 work wrt. implicit blocks; see test-337 from #63842.
10933 2005-01-21 Alp Toker <alp@atoker.com>
10935 * cs-parser.jay: destructor_declaration's container is PartialContainer
10936 not Class when partial types are used, so use Kind prop instead of
10939 2005-01-22 Miguel de Icaza <miguel@ximian.com>
10941 * cs-parser.jay: Improve error reporting when an interface
10942 declares new types.
10944 2005-01-20 Dick Porter <dick@ximian.com>
10946 * support.cs: SeekableStreamReader fix from Sandor Dobos
10947 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
10948 chars are read. Fixes bug 70369.
10950 2005-01-20 Raja R Harinath <rharinath@novell.com>
10952 * cs-parser.jay (catch_clause): Simplify current_block handling
10955 2005-01-17 Miguel de Icaza <miguel@ximian.com>
10957 * convert.cs (ImplicitStandardConversionExists): Synchronize the
10958 code with ImplicitStandardConversion to handle the implicit
10959 conversion of method groups into valid delegate invocations.
10961 The problem is that in parameter handling we were using this code
10962 path. Fixes bug #64698
10964 2005-01-19 Raja R Harinath <rharinath@novell.com>
10966 * cs-parser.jay: Fix several infelicities.
10967 - Avoid assigning to the parser value stack. Code like
10968 '$3 = null' is unclean. Synthesize a value for the code block
10970 - Avoid using oob_stack for storing location information. Use ...
10971 (_mark_): ... this. New (empty) rule. Saves the current location
10973 (foreach_statement): Avoid using oob_stack for current_block
10974 handling. Use technique used in for_statement and
10975 using_statement. Synthesize a value for the code block to store
10976 additional intermediate information.
10978 2005-01-13 Miguel de Icaza <miguel@ximian.com>
10980 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
10981 of a different type is only allowed to private fields of a
10982 containing type, not on fields of a base class.
10984 See test-174.cs and error cs0122-9.cs
10986 2005-01-13 Raja R Harinath <rharinath@novell.com>
10988 Fix test-335.cs (bug #58126).
10989 * cs-parser.jay (argument): Split out non-expression parts of the
10990 rule into 'non_simple_argument'.
10991 (invocation_expression): Support parenthesized invocations with
10992 multiple arguments, and with single non-simple arguments.
10994 2005-01-13 Raja R Harinath <rharinath@novell.com>
10996 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
10999 2005-01-12 Raja R Harinath <rharinath@novell.com>
11001 Fix cs0038-1.cs, cs1640-6.cs.
11002 * ecore.cs (Expression.Resolve): Remove special-case for
11003 SimpleName in error-handling.
11004 (Expression.almostMatchedMembers): Relax access permission to
11006 (Expression.MemberLookupFailed): Handle duplicates in
11007 almostMatchedMembers list.
11008 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
11009 * expression.cs (New.DoResolve): Report CS1540 for more cases.
11010 * typemanager.cs (GetFullNameSignature): Use the MethodBase
11011 overload if the passed in MemberInfo is a MethodBase.
11013 2005-01-12 Marek Safar <marek.safar@seznam.cz>
11016 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
11017 for non-CAS & merge permission sets properly.
11019 2005-01-11 Raja R Harinath <rharinath@novell.com>
11021 Improve standard-compliance of simple name and member access
11022 resolution. Fixes bugs #52697, #57200, #67520, #69519.
11023 * ecore.cs (FullNamedExpression): New abstract base class
11024 for Namespaces and TypeExpressions.
11025 (ResolveFlags.SimpleName): Remove.
11026 (SimpleName): Remove support for dotted names.
11027 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
11028 DeclSpace.FindType and DeclSpace.LookupType.
11029 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
11030 (Expression.ExprClassName): Make member function.
11031 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
11032 a namespace. Remove creation of dotted "SimpleName"s.
11033 (MemberAccess.DoResolve): Likewise.
11034 * decl.cs (DeclSpace.Cache): Make private.
11035 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
11036 (DeclSpace.FindType): Update.
11037 (DeclSpace.LookupType): Move here from RootContext. Return a
11038 FullNamedExpression.
11039 * namespace.cs (Namespace): Derive from FullNamedExpression
11040 so that it can be part of expression resolution.
11041 (Namespace.Lookup): Return an FullNamedExpression.
11042 (NamespaceEntry.LookupAlias): Lookup aliases only in current
11044 * rootcontext.cs (NamespaceLookup): Remove.
11045 (LookupType): Move to DeclSpace.
11046 * attribute.cs (CheckAttributeType): Update.
11047 * doc.cs (FindDocumentedType): Remove allowAlias argument.
11048 (FindDocumentedTypeNonArray): Likewise.
11050 2005-01-11 Raja R Harinath <rharinath@novell.com>
11052 Fix cs0509.cs, cs1632.cs.
11053 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
11054 is the same as IsInterface.
11055 (TypeContainer.GetClassBases): Likewise.
11056 * statement.cs (LabeledStatement.ig): New field.
11057 (LabeledStatement.LabelTarget): Save ILGenerator which created the
11059 (LabeledStatement.DoEmit): Check that the label was created with
11060 the same ILGenerator.
11062 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11065 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
11066 accessors to its properties.
11068 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
11069 from accessors to property.
11071 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11074 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
11075 only for overrides.
11077 2005-01-08 Miguel de Icaza <miguel@ximian.com>
11079 * attribute.cs: Check for null and empty strings.
11081 I have lost another battle to Paolo.
11083 2005-01-07 Marek Safar <marek.safar@seznam.cz>
11086 * class.cs (PropertyMethod): Set Parent field in ctors.
11087 (SetMethod.InternalParameters): Add unsafe switch hack.
11088 Override MarkForDuplicationCheck where it is appropriate.
11090 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
11091 It says whether container allows members with the same name.
11092 Base default is no.
11093 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
11094 Removed is_method parameter.
11096 2005-01-06 Duncan Mak <duncan@ximian.com>
11098 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
11099 because the previous change led to incorrect reporting of CS1032
11100 ("Cannot define/undefine preprocessor symbols after first token in
11101 file"). Instead of using `tokens_seen' as the only flag that
11102 triggers CS1040, introduce `comments_seen'. This new flag is used
11103 to signify having seen comments on the current line, so it is
11104 unset after a newline.
11106 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11108 * doc.cs : When searching for a type, find nested type too.
11109 This fixes bug #71040.
11111 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11114 - Warn missing member comment on those classes which also does not
11115 have doc comments. Fixed bug #71041.
11116 - Don't warn missing doc comment on default constructor.
11119 2005-01-06 Duncan Mak <duncan@ximian.com>
11121 * cs-tokenizer.cs (xtoken): After handling traditional C-style
11122 comments, set `tokens_seen' to true. This allows us to detect
11123 misplaced preprocessor directives (i.e. not at the beginning of
11124 the a line, nor after whitespaces). In that case, report error
11125 CS1040. This fixes bug #56460.
11127 * cs-parser.jay (interface_member_declaration): Add checks for
11128 IsExplicitImpl, and report CS0541 error if an interface member is
11129 defined as an explicit interface declaration.
11131 2005-01-06 Marek Safar <marek.safar@seznam.cz>
11134 * class.cs (PropertyMethod): Set Parent field in ctors.
11135 (SetMethod.InternalParameters): Add unsafe switch hack.
11137 * decl.cs (MemberCore.Parent): Cannot be readonly.
11139 2005-01-06 Raja R Harinath <rharinath@novell.com>
11141 * decl.cs (DeclSpace.ResolveType): Remove.
11142 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
11143 Merge in code from ...
11144 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
11145 * class.cs, enum.cs: Update to changes.
11147 2005-01-06 Miguel de Icaza <miguel@ximian.com>
11149 * anonymous.cs: Ensure that we init the scope of our parent if it
11150 has not been initialized yet.
11152 2004-12-30 Duncan Mak <duncan@ximian.com>
11154 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
11155 if field.FieldBuilder is null. Fixes #70758.
11157 * convert.cs: Fixed some typos and updated some of the comments.
11158 (ImplicitStandardConversionExists):
11159 (TryImplicitIntConversion): If `target_type' is an interface and
11160 the type of `ic' implements this interface, return true or a new
11161 BoxedCast instead of null. This fixes #70468.
11163 2004-12-29 Duncan Mak <duncan@ximian.com>
11165 * expression.cs (Argument.Emit): Check that Expr is
11166 IMemoryLocation before casting to it, and report CS1510 otherwise.
11170 2004-12-21 Ben Maurer <bmaurer@ximian.com>
11172 * statement.cs (Block.ThisVariable): remove the recursion here, to
11173 make the --profile more sane.
11175 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
11177 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
11178 assembly, by JB Evain.
11180 2004-12-17 Raja R Harinath <rharinath@novell.com>
11182 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
11183 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
11184 "parent" refers to enclosing type/class. "base" refers to superclass.
11186 2004-12-17 Raja R Harinath <rharinath@novell.com>
11188 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11189 Ensure that we only have GlobalAttributes.
11190 * attribute.cs (Attribute.Emit): Make non-virtual.
11191 (GlobalAttribute.Emit): Remove.
11192 (Attribute.Resolve): Make virtual.
11193 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
11194 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
11195 the argument. Don't create one.
11196 (Attribute.GetObsoleteAttribute): Likewise.
11197 (Attribute.GetClsCompliantAttributeValue): Likewise.
11198 * class.cs, decl.cs: Update to changes.
11200 2004-12-17 Marek Safar <marek.safar@seznam.cz>
11202 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
11204 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
11206 * statement.cs (Foreach.Resolve): Add error 186 report.
11208 2004-12-16 Marek Safar <marek.safar@seznam.cz>
11210 * expression.cs (Conditional.DoResolve): Add warning 429.
11212 * statement.cs (If.Resolve): Add warning 665.
11214 2004-12-16 Raja R Harinath <rharinath@novell.com>
11216 New invariant: RootContext.Tree.Types.NamespaceEntry == null
11217 except when in the parser, and in GlobalAttribute.
11218 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
11219 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
11220 RootContext.Tree.Types.NamespaceEntry once work is done.
11221 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
11222 and resets RootContext.Tree.Types.NamespaceEntry.
11224 2004-12-15 Marek Safar <marek.safar@seznam.cz>
11226 * cs-parser.jay: Don't create a block for every variable.
11228 2004-12-14 Miguel de Icaza <miguel@ximian.com>
11230 * location.cs: Provide extra information.
11232 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
11233 variables from the captured environment, it is the ldarg_0.
11235 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11237 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
11240 * class.cs: Changed warning level for 169 to avoid developer
11241 displeasure from warning flooding. It will be changed back when they
11242 fix most of current BCL warnings.
11244 * RootContext.cs: Pushed default WarningLevel to 3.
11246 * statement.cs: Removed unused variable.
11248 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11250 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
11251 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
11252 Add error 502 report.
11253 (StaticClass.DefineType): Add error 441 report.
11254 (Class.AllowedModifiersProp): New virtual property as temporary
11255 extension to AllowedModifiers.
11256 (Class.DefineType): Add error 418 report. Moved ModFlags check here
11257 to share implementation with StaticClass and don't call virtual
11260 * driver.cs (MainDriver): Add error 1558 test.
11262 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
11263 report. Moved error 36 test here.
11265 * statement.cs (Throw.Resolve): Add error 724 report.
11267 * typemanager.cs: Add out_attribute_type core type.
11269 2004-12-13 Marek Safar <marek.safar@seznam.cz>
11271 * class.cs (TypeContainer.VerifyClsCompliance): Add error
11273 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
11275 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
11278 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
11280 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
11281 Add error 3023 report.
11282 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
11284 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
11287 2004-12-12 John Luke <john.luke@gmail.com>
11289 * driver.cs (AddArgs): take -- into account when
11290 adding arguments, fixes bug 65710
11292 2004-12-12 Martin Baulig <martin@ximian.com>
11294 * expression.cs (Unary.TryReduceNegative): Added support for
11295 SByteConstant and ByteConstant.
11296 (Unary.Reduce): Check error values from TryReduceNegative().
11298 2004-12-10 Marek Safar <marek.safar@seznam.cz>
11300 * attributes.cs (Attribute.Resolve): Avoid multiple error report
11301 and report exception as error 182.
11303 2004-12-10 Raja R Harinath <rharinath@novell.com>
11305 * driver.cs (Main): Fix message when there are warnings.
11307 2004-12-09 Miguel de Icaza <miguel@ximian.com>
11309 * delegate.cs: Fixed my fix from yesterday, sorry about that.
11311 2004-12-09 Marek Safar <marek.safar@seznam.cz>
11313 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
11314 Reduced number of warnings.
11316 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
11318 2004-12-08 Miguel de Icaza <miguel@ximian.com>
11320 * driver.cs: Removed message.
11322 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
11324 2004-12-08 <vargaz@freemail.hu>
11326 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
11328 2004-12-08 Martin Baulig <martin@ximian.com>
11330 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
11331 instead of a CS3002 for properties and indexer.
11333 2004-12-08 Martin Baulig <martin@ximian.com>
11335 * decl.cs (MemberName.ToString): Make this work again.
11337 2004-12-08 Marek Safar <marek.safar@seznam.cz>
11339 * attribute.cs (Resolve): Add error 591 detection.
11341 * class.cs (FieldMember.Define): Add error 1547 detection.
11342 (Indexer.Define): Add error 620 detection.
11343 (Operator.Define): Add error 590 detection.
11345 * ecore.cs: Missing argument for error 79.
11347 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
11350 2004-12-07 Marek Safar <marek.safar@seznam.cz>
11353 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
11356 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
11358 * cs-parser.jay : handle doc comments on implicit/explicit operators.
11359 Some operator comments were suppressed.
11360 * doc.cs : Implicit/explicit operator name in doc comments are like
11361 "op_Explicit(type)~returnType", so added suffix handling.
11363 2004-12-07 Martin Baulig <martin@ximian.com>
11366 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
11367 (MemberCore.GetClsCompliantAttributeValue): Likewise.
11368 (DeclSpace.ec): New protected field; store the EmitContext here.
11369 (DeclSpace.EmitContext): New public property; moved here from
11371 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
11374 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
11375 (Enum.Emit): Don't create a new EmitContext.
11377 * delegate.cs (Delegate.DefineType): Always create the
11380 * iterators.cs (Iterators.DefineIterator): Create a new
11381 EmitContext and store it in `ec'.
11383 2004-08-24 Martin Baulig <martin@ximian.com>
11386 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
11387 this for accessibility checks.
11388 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
11389 IsNestedFamilyAccessible.
11390 (TypeManager.IsSubclassOf): New method, do what the name actually
11393 2004-12-06 Raja R Harinath <rharinath@novell.com>
11395 Fix crash on cs0657-17.cs.
11396 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11397 Use RootContext.Tree.Types, not 'new RootTypes ()'.
11398 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
11399 the case where the NamespaceEntry gets overwritten.
11401 2004-12-06 Marek Safar <marek.safar@seznam.cz>
11403 Fixed #69195, #56821
11404 * ecore.cs (ResolveBoolean): Tiny refactoring.
11406 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
11407 of right expression resolving when left is false constant and
11408 operator is LogicalAnd OR true constant and operator is LogicalOr.
11410 * statement.cs (ResolveUnreachable): Always reports warning.
11412 2004-12-05 Miguel de Icaza <miguel@ximian.com>
11414 * class.cs: Distinguish between 1721 and 1722 (just a little help
11415 for the programmer).
11417 2004-12-03 Miguel de Icaza <miguel@ximian.com>
11419 * delegate.cs: Only allow this on new versions of the language.
11421 2004-12-02 Duncan Mak <duncan@ximian.com>
11423 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
11425 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
11426 here as a static method. Take an additional bool out parameter
11427 `must_do_cs1540_check' for signaling to InstanceResolve.
11428 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
11429 member field from PropertyExpr class and made it an argument of
11430 the method instead.
11431 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
11432 check for MarshalByRefObject, and report CS0122 instead of CS1540.
11433 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
11434 and `remove_accessor' as well as InstanceResolve: report CS0122
11439 2004-12-03 Raja R Harinath <rharinath@novell.com>
11441 Fix test-327.cs, test-328.cs, and put in early infrastructure
11442 for eventually fixing #52697.
11443 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
11444 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
11445 from other methods.
11446 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
11447 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
11448 (VerifyUsing, error246): Update.
11449 * rootcontext.cs (RootContext.NamespaceLookup): Just use
11450 'NamespaceEntry.LookupNamespaceOrType'.
11452 2004-12-03 Martin Baulig <martin@ximian.com>
11454 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11455 method as our child, call AnonymousMethod.Compatible() on it.
11457 2004-12-03 Raja R Harinath <rharinath@novell.com>
11459 Disable XML documentation support in 'basic' profile.
11460 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
11461 Redirect XmlElement to System.Object.
11462 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
11463 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
11464 * mcs.exe.sources: Add doc-bootstrap.cs.
11465 * doc-bootstrap.cs: New file. Contains empty stub implementation
11468 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
11470 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
11471 comments are allowed.
11473 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11475 * delegate.cs: Add checks for subtypes in paramaters and return values
11476 in VerifyMethod () to add support for Covariance/Contravariance
11479 2004-12-02 Miguel de Icaza <miguel@ximian.com>
11481 * report.cs: Remove extra closing parenthesis.
11483 * convert.cs (Error_CannotImplicitConversion): If the name of the
11484 types are the same, provide some extra information.
11486 * class.cs (FieldBase): Use an unused bit field from the field to
11487 encode the `has_offset' property from the FieldMember. This saves
11488 a couple of Ks on bootstrap compilation.
11490 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11491 method as our child, return the AnonymousMethod resolved
11494 * expression.cs (New.DoResolve): Allow return values from
11495 NewDelegate to also include AnonymousMethods.
11499 2004-12-02 Marek Safar <marek.safar@seznam.cz>
11502 * attribute.cs (Resolve): Improved implementation of params
11503 attribute arguments.
11505 * support.cs (ParameterData): Add HasParams to be faster.
11507 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
11509 all things are for /doc support:
11511 * doc.cs: new file that supports XML documentation generation.
11512 * mcs.exe.sources: added doc.cs.
11514 Handle /doc command line option.
11515 Report error 2006 instead of 5 for missing file name for /doc.
11516 Generate XML documentation when required, after type resolution.
11518 Added support for picking up documentation (/// and /** ... */),
11519 including a new XmlCommentState enumeration.
11521 Added lines to fill Documentation element for field, constant,
11522 property, indexer, method, constructor, destructor, operator, event
11523 and class, struct, interface, delegate, enum.
11524 Added lines to warn incorrect comment.
11526 Added Documentation field (passed only when /doc was specified).
11528 Added DocComment, DocCommentHeader, GenerateDocComment() and
11529 OnGenerateDocComment() and some supporting private members for
11530 /doc feature to MemberCore.
11532 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
11534 Added overriden DocCommentHeader.
11536 Added overriden DocCommentHeader and GenerateDocComment().
11538 2004-12-01 Miguel de Icaza <miguel@ximian.com>
11540 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
11541 unwrapping the enumeration values, chain to
11542 DoConstantNumericPromotions again, so we can promote things to the
11543 fundamental types (takes care of enums that are bytes, sbytes).
11547 2004-12-01 Raja R Harinath <rharinath@novell.com>
11549 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
11550 Fix long-standing bug in type-lookup. Use FindType instead of
11551 LookupType when ec.ResolvingTypeTree.
11552 (Attribute.ResolveType, Attribute.Resolve)
11553 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
11555 (Attributes.Search): Remove internal version. Update.
11556 (Attributes.SearchMulti): Update.
11557 (Attributes.GetClsCompliantAttribute): Remove.
11558 (Attributes.GetIndexerNameAttribute): Remove.
11559 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
11560 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
11561 * class.cs (Indexer.Define): Likewise.
11563 2004-12-01 Marek Safar <marek.safar@seznam.cz>
11566 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
11567 MarshallByReference members access.
11569 * expression.cs: Use CheckMarshallByRefAccess;
11570 Better error CS0197 message.
11572 * report.cs: Print whole related error message.
11574 2004-11-30 Raja R Harinath <rharinath@novell.com>
11576 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
11577 the current directory to help debugging.
11579 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11581 * class (GetClassBases): Better error 60 report.
11582 (EventProperty): Disabled warning 67 detection.
11584 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11587 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
11589 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
11592 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11595 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
11597 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
11599 2004-11-26 Miguel de Icaza <miguel@ximian.com>
11601 * attribute.cs (Attribute.Resolve): Refine error reporting and
11602 report a cs0117 if the identifier does not exist, to distinguish
11603 from 0617 which is a miss-use of the actual identifier.
11605 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
11606 between cs0070 and cs0079.
11608 * class.cs (MemberBase.DoDefine): When reporting a wrong
11609 accessibility level, we use MethodCore to compare instead of
11610 Method (this was a regression in some refactoring effort).
11612 So now we correctly report cs0056 again.
11614 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
11615 testing the target_type (which was known to be object_type) and
11616 not the source type (which is anonymous_method).
11618 Fixed reporting of error cs1660.
11620 * expression.cs (UserCast.Source): Expose the underlying cast.
11622 * statement.cs (Switch.SwitchGoverningType): Sort the list of
11623 allowed types to find a match to int32 first (most common).
11625 In addition, it ignores any ImplicitUserConversions that did an
11626 internal implicit conversion (as the switch statement allows only
11627 one integral conversion to exist).
11629 * class.cs (PartialContainer.Create): rename `name' to
11630 `member_name' for clarity. Then replace the string calls with a
11631 call to MemberName.GetPartialName, as now using
11632 MemberName.ToString is an error (this is due to the side effects
11633 it had, that were fixed in the past).
11635 This will restore the error reporting on a number of partial class
11636 errors that were missusing this (and getting an exception as a
11637 results, which is now just a plain textual warning, because
11638 yyparse debug output would crash otherwise).
11640 2004-11-26 Raja R Harinath <rharinath@novell.com>
11642 * Makefile (PROGRAM_INSTALL_DIR): Remove.
11644 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11646 * rootcontext.cs (LookupType): Make sure to cache lookups that
11647 don't give us a negative result. This saves about 5% of corlib
11650 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11652 * report.cs (AbstractMessage.Print): messages are sent to stderr
11654 * class.cs (TypeContainer.GetClassBases): It is an error to have a
11655 non-interface in the list of interfaces (at this point, either
11656 parent was properly set, or a base class is being listed in the
11657 interfaces section).
11659 This flags error 1722, and resolves the crash from bug 69259.
11661 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11663 * statement.cs (Using.EmitExpressionFinally): make this work right
11664 for valuetypes. Fixes 69926.
11666 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11668 * const.cs (Const.ChangeType): Cope with the "0 literal can be
11669 converted to an enum" here, before we try to change the underlying
11670 type. This code exists, but it is a different code path than the
11671 one used while encoding constants.
11673 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
11674 old bug: when converting from the null literal to a pointer,
11675 return an EmptyCast, not the NullLiteral.
11677 This fixes #69921, the recent null_type changes probably made this
11678 bug more prominent.
11680 (ImplicitReferenceConversionExists): In addition, resynchronized
11681 the code here, so it matches the same code in
11682 ImplicitReferenceConversionExists for the `from any class-type S
11683 to any interface-type T'.
11686 2004-11-25 Marek Safar <marek.safar@seznam.cz>
11688 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
11690 2004-11-24 Miguel de Icaza <miguel@ximian.com>
11692 * cs-parser.jay: Use verbosity accordingly.
11694 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11696 * expression.cs (Unary.ResolveOperator): Do not report warning;
11697 AddressOf reads from variable.
11699 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
11701 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11705 * attribute.cs (Attributable): Removed CheckTargets.
11706 (Attributes.Emit): Explicit attribute targets are tested here.
11708 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
11709 not enabled for interfaces.
11711 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
11712 (GetAssemblyName): Ouch next bug there.
11714 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11716 * expression.cs: Error 275 added.
11718 2004-11-23 Marek Safar <marek.safar@seznam.cz>
11720 Fix bug #69177 (Implemented decimal constant support)
11722 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
11723 (BinaryFold): Add DecimalConstant.
11725 * const.cs (Define): Decimal constant
11727 (ChangeType): Add decimal type handling.
11728 (LookupConstantValue): Don't set value for decimal type but
11729 emit DecimalConstantAttribute. Needed for constant optimization.
11731 * constant.cs (ToDecimal): New method.
11732 (ConvertToDecimal): New method.
11733 (IntConstant): Implemented ConvertToDecimal.
11734 (DecimalConstant.Emit): Emit optimized version for decimals in
11737 * expression.cs (ResolveOperator): Changed order of constant
11738 reduction to work correctly with native types which have
11739 overloaded operators.
11740 (ResolveMemberAccess): Extract constant value from attribute
11743 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
11745 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
11746 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
11747 (ChangeType): Decimal is special.
11748 (TypeToCoreType): Add decimal type.
11750 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11752 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
11755 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11757 * class.cs (EventField.ApplyAttributeBuilder): Fix error
11760 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11762 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
11764 * pending.cs (PendingImplementation): Grab only interfaces.
11766 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11768 * statement.cs (ForeachHelperMethods): Add location member and
11769 error 202 detection.
11771 2004-11-19 Raja R Harinath <rharinath@novell.com>
11773 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
11774 automatically handled by executable.make.
11775 (PROGRAM): Make profile-specific.
11777 2004-11-18 Marek Safar <marek.safar@seznam.cz>
11779 * expression.cs (DoResolveBase): Fixed wrong warning for out
11782 2004-11-18 Martin Baulig <martin@ximian.com>
11784 Merged latest changes into gmcs. Please keep this comment in
11785 here, it makes it easier for me to see what changed in MCS since
11786 the last time I merged.
11788 2004-11-17 Raja R Harinath <rharinath@novell.com>
11790 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
11791 (TypeHandle.GetMemberCache): New.
11792 (TypeHandle.TypeHandle): Update.
11793 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
11794 (TypeManager.LookupParentInterfacesCache):
11795 Rename from LookupInterfaceCache. Optimize slightly.
11796 (TypeManager.MemberLookup_FindMembers): Update.
11797 * decl.cs (MemberCache.MemberCache): Set Container to null in the
11798 multi-type variant.
11799 (AddCacheContents): Rename from AddHashtable.
11800 * class.cs (TypeContainer.parent_container): Remove.
11801 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
11802 (TypeContainer.DoDefineMembers): Don't initialize it.
11803 Update to name changes.
11805 2004-11-17 Miguel de Icaza <miguel@ximian.com>
11807 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
11808 that factors the code to check access modifiers on override.
11810 (PropertyBase): Use the code here.
11812 Patch from Lluis S'anchez, fixes bug #69361.
11814 2004-11-15 Miguel de Icaza <miguel@ximian.com>
11816 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
11817 routine that is used to report the use of a captured variable
11818 whose address has been taken.
11820 There are two checks: one when variables are being captured and
11821 the other check is when the address of a variable is taken.
11823 (because an anonymous methods might be resolved before *or* after
11824 the address has been taken) and
11826 * expression.cs (Conditional.DoResolve): Remove the special
11827 casing that Martin added to trueExpr and falseExpr being both
11828 NullLiteral. We get the right behavior now just by introducing
11829 the null_type into the compiler.
11831 * convert.cs (ExplicitConversion): Change the code to use
11832 null_type instead of testing `expr is NullLiteral'.
11833 (ImplicitConversionStandard): use null_type too.
11834 (ImplicitReferenceConversionExists): use null_type too.
11835 (ImplicitReferenceConversion): use null_type too.
11837 * literal.cs: The type of `NullLiteral' is now null_type instead
11839 (Resolve): Set the type here.
11841 * typemanager.cs: Introduce null_type.
11843 2004-11-17 Martin Baulig <martin@ximian.com>
11845 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
11846 direction, like FindMembers() does. Fixes #69546, testcase is in
11849 2004-11-16 Martin Baulig <martin@ximian.com>
11851 This is based on a patch from Marek Safar, see bug #69082.
11852 Fixes bugs #63705 and #67130.
11854 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
11855 method; create a MemberCache for an interface type and cache the
11858 * decl.cs (IMemberContainer.ParentContainer): Removed.
11859 (IMemberContainer.ParentCache): New property.
11860 (MemberCache.SetupCacheForInterface): Removed.
11861 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
11862 to create a cache for an interface's "parent".
11864 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
11867 2004-11-16 Martin Baulig <martin@ximian.com>
11869 Merged back from gmcs; these changes already went into gmcs a
11870 couple of weeks ago.
11873 (TypeManager.AddUserType): Removed the `ifaces' argument.
11874 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
11876 (TypeManager.AddUserInterface): Removed.
11877 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
11879 (TypeManager.GetInterfaces): Likewise.
11880 (TypeManager.GetExplicitInterfaces): Likewise.
11882 * ecore.cs (TypeExpr.GetInterfaces): Removed.
11884 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
11885 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
11887 2004-11-14 Ben Maurer <bmaurer@ximian.com>
11889 * statement.cs: Avoid adding bools to a hashtable.
11891 2004-11-07 Miguel de Icaza <miguel@ximian.com>
11893 * expression.cs (Invocation.OverloadResolve): Flag error if we are
11894 calling an unsafe method from a safe location.
11896 2004-11-06 Marek Safar <marek.safar@seznam.cz>
11899 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
11901 2004-11-06 Miguel de Icaza <miguel@ximian.com>
11903 * namespace.cs (VerifyUsing): use GetPartialName instead of
11906 2004-11-05 Miguel de Icaza <miguel@ximian.com>
11908 * statement.cs (Return.Resolve): Fix regression in typo: if
11909 `in_exc', we have to request a NeedReturnLabel, this was a typo
11910 introduced in the anonymous method check-in. Fixes #69131.
11912 * Indexers were using the ShortName when defining themselves,
11913 causing a regression in the compiler bootstrap when applying the
11914 patch from 2004-11-02 (first part), now they use their full name
11915 and the bug is gone.
11917 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
11919 * driver.cs: Strip the path from the names of embedded resources. Fixes
11922 2004-11-04 Raja R Harinath <rharinath@novell.com>
11924 Fix error message regression: cs0104-2.cs.
11925 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
11926 (AliasEntry.Resolve): Update.
11927 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
11929 (RootContext.LookupType): Update.
11931 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
11933 * cs-parser.jay: Add support for handling accessor modifiers
11934 * class: Add support port accessor modifiers and error checking,
11935 define PropertyMethod.Define as virtual (not abstract anymore)
11936 * ecore.cs: Add checking for proeprties access with access modifiers
11937 * iterators.cs: Modify Accessor constructor call based in the modified
11939 2004-11-02 Ben Maurer <bmaurer@ximian.com>
11941 * expression.cs (StringConcat): Handle being called twice,
11942 as when we have a concat in a field init with more than two
11945 2004-11-02 Miguel de Icaza <miguel@ximian.com>
11947 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
11948 special case explicit implementations, we should always produce
11949 the .property or .event declaration.
11951 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
11952 since it will not return correct data if people use this
11953 unresolved in the presence of using statements (see test-313).
11955 * class.cs (MethodData.Define): If we are an explicit interface
11956 implementation, set the method name to the full name of the
11957 interface plus the name of the method.
11959 Notice that using the method.MethodName.GetFullName() does not
11960 work, as it will only contain the name as declared on the source
11961 file (it can be a shorthand in the presence of using statements)
11962 and not the fully qualifed type name, for example:
11966 class D : ICloneable {
11967 object ICloneable.Clone () {
11971 Would produce a method called `ICloneable.Clone' instead of
11972 `System.ICloneable.Clone'.
11974 * namespace.cs (Alias.Resolve): Use GetPartialName.
11976 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11978 * cs-parser.jay: Add error 1055 report.
11980 2004-11-01 Miguel de Icaza <miguel@ximian.com>
11982 * assign.cs (Assign.DoResolve): Only do the transform of
11983 assignment into a New if the types are compatible, if not, fall
11984 through and let the implicit code deal with the errors and with
11985 the necessary conversions.
11987 2004-11-01 Marek Safar <marek.safar@seznam.cz>
11989 * cs-parser.jay: Add error 1031 report.
11991 * cs-tokenizer.cs: Add location for error 1038.
11993 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11995 * cs-parser.jay: Add error 1016 report.
11997 2004-10-31 Marek Safar <marek.safar@seznam.cz>
11999 * cs-parser.jay: Add errors 1575,1611 report.
12001 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12003 * cs-parser.jay: Add error 1001 report.
12005 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12008 * attribute.cs (GetMarshal): Add method argument for
12009 caller identification.
12011 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
12012 agument for GetMarshal and RuntimeMissingSupport.
12014 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12016 * attribute.cs (ExtractSecurityPermissionSet): Removed
12017 TypeManager.code_access_permission_type.
12019 * typemanager.cs: Removed TypeManager.code_access_permission_type.
12021 2004-10-27 Miguel de Icaza <miguel@ximian.com>
12023 * expression.cs (LocalVariableReference.DoResolveLValue): Check
12024 for obsolete use of a variable here. Fixes regression on errors
12025 cs0619-25 and cs0619-26.
12027 2004-10-27 Marek Safar <marek.safar@seznam.cz>
12029 Fix #62358, implemented security attribute encoding.
12031 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
12032 Tests permitted SecurityAction for assembly or other types.
12033 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
12034 data from SecurityPermissionAttribute to PermisionSet class.
12036 * class.cs (ApplyAttributeBuilder): Added special handling
12037 for System.Security.Permissions.SecurityAttribute based types.
12039 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
12040 special handling for System.Security.Permissions.SecurityAttribute
12043 * enum.cs (ApplyAttributeBuilder): Added special handling
12044 for System.Security.Permissions.SecurityAttribute based types.
12046 * parameter.cs (ApplyAttributeBuilder): Added special handling
12047 for System.Security.Permissions.SecurityAttribute based types.
12049 * rootcontext.cs: Next 2 core types.
12051 * typemanager.cs (TypeManager.security_permission_attr_type):
12052 Built in type for the SecurityPermission Attribute.
12053 (code_access_permission_type): Build in type.
12055 2004-10-17 Miguel de Icaza <miguel@ximian.com>
12057 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
12058 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
12059 all of this information into
12060 EmitContext.EmitCapturedVariableInstance.
12062 * codegen.cs (EmitCapturedVariableInstance): move here the
12063 funcionality of emitting an ldarg.0 in the presence of a
12064 remapping. This centralizes the instance emit code.
12066 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
12067 then emit a load of this: it means that we have reached the
12068 topmost ScopeInfo: the one that contains the pointer to the
12069 instance of the class hosting the anonymous method.
12071 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
12072 captures to the topmost CaptureContext.
12074 2004-10-12 Miguel de Icaza <miguel@ximian.com>
12076 * expression.cs (LocalVariableReference): Move the knowledge about
12077 the iterators into codegen's EmitCapturedVariableInstance.
12079 2004-10-11 Miguel de Icaza <miguel@ximian.com>
12081 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
12082 all code paths return a value from an anonymous method (it is the
12083 same as the 161 error, but for anonymous methods).
12085 2004-10-08 Miguel de Icaza <miguel@ximian.com>
12087 The introduction of anonymous methods in the compiler changed
12088 various ways of doing things in the compiler. The most
12089 significant one is the hard split between the resolution phase
12090 and the emission phases of the compiler.
12092 For instance, routines that referenced local variables no
12093 longer can safely create temporary variables during the
12094 resolution phase: they must do so from the emission phase,
12095 since the variable might have been "captured", hence access to
12096 it can not be done with the local-variable operations from the runtime.
12100 (Block.Flags): New flag `IsTopLevel' to indicate that this block
12101 is a toplevel block.
12103 (ToplevelBlock): A new kind of Block, these are the blocks that
12104 are created by the parser for all toplevel method bodies. These
12105 include methods, accessors and anonymous methods.
12107 These contain some extra information not found in regular blocks:
12108 A pointer to an optional CaptureContext (for tracking captured
12109 local variables and parameters). A pointer to the parent
12112 (Return.Resolve): Catch missmatches when returning a value from an
12113 anonymous method (error 1662).
12114 Invoke NeedReturnLabel from the Resolve phase instead of the emit
12117 (Break.Resolve): ditto.
12119 (SwitchLabel): instead of defining the labels during the
12120 resolution phase, we now turned the public ILLabel and ILLabelCode
12121 labels into methods called GetILLabelCode() and GetILLabel() that
12122 only define the label during the Emit phase.
12124 (GotoCase): Track the SwitchLabel instead of the computed label
12125 (its contained therein). Emit the code by using
12126 SwitchLabel.GetILLabelCode ().
12128 (LocalInfo.Flags.Captured): A new flag has been introduce to track
12129 whether the Local has been captured or not.
12131 (LocalInfo.IsCaptured): New property, used to tell whether the
12132 local has been captured.
12134 * anonymous.cs: Vastly updated to contain the anonymous method
12137 The main classes here are: CaptureContext which tracks any
12138 captured information for a toplevel block and ScopeInfo used to
12139 track the activation frames for various local variables.
12141 Each toplevel block has an optional capture context associated
12142 with it. When a method contains an anonymous method both the
12143 toplevel method and the anonymous method will create a capture
12144 context. When variables or parameters are captured, they are
12145 recorded on the CaptureContext that owns them, for example:
12149 MyDelegate d = delegate {
12154 Here `a' will be recorded as captured on the toplevel
12155 CapturedContext, the inner captured context will not have anything
12156 (it will only have data if local variables or parameters from it
12157 are captured in a nested anonymous method.
12159 The ScopeInfo is used to track the activation frames for local
12160 variables, for example:
12162 for (int i = 0; i < 10; i++)
12163 for (int j = 0; j < 10; j++){
12164 MyDelegate d = delegate {
12169 At runtime this captures a single captured variable `i', but it
12170 captures 10 different versions of the variable `j'. The variable
12171 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
12172 recorded on a child.
12174 The toplevel ScopeInfo will also track information like the `this'
12175 pointer if instance variables were referenced (this is necessary
12176 as the anonymous method lives inside a nested class in the host
12177 type of the method).
12179 (AnonymousMethod): Expanded to track the Toplevel, implement
12180 `AnonymousMethod.Compatible' to tell whether an anonymous method
12181 can be converted to a target delegate type.
12183 The routine now also produces the anonymous method content
12185 (AnonymousDelegate): A helper class that derives from
12186 DelegateCreation, this is used to generate the code necessary to
12187 produce the delegate for the anonymous method that was created.
12189 * assign.cs: API adjustments for new changes in
12190 Convert.ImplicitStandardConversionExists.
12192 * class.cs: Adjustments to cope with the fact that now toplevel
12193 blocks are of type `ToplevelBlock'.
12195 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
12196 insteda of standard blocks.
12198 Flag errors if params arguments are passed to anonymous methods.
12200 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
12201 `CurrentAnonymousMethod' which points to the current Anonymous
12202 Method. The variable points to the AnonymousMethod class that
12203 holds the code being compiled. It is set in the new EmitContext
12204 created for the anonymous method.
12206 (EmitContext.Phase): Introduce a variable and an enumeration to
12207 assist in enforcing some rules about when and where we are allowed
12208 to invoke certain methods (EmitContext.NeedsReturnLabel is the
12209 only one that enfonces this right now).
12211 (EmitContext.HaveCaptureInfo): new helper method that returns
12212 whether we have a CapturedContext initialized.
12214 (EmitContext.CaptureVariable): New method used to register that a
12215 LocalInfo must be flagged for capturing.
12217 (EmitContext.CapturedParameter): New method used to register that a
12218 parameters must be flagged for capturing.
12220 (EmitContext.CapturedField): New method used to register that a
12221 field must be flagged for capturing.
12223 (EmitContext.HaveCapturedVariables,
12224 EmitContext.HaveCapturedFields): Return whether there are captured
12225 variables or fields.
12227 (EmitContext.EmitMethodHostInstance): This is used to emit the
12228 instance for the anonymous method. The instance might be null
12229 (static methods), this (for anonymous methods that capture nothing
12230 and happen to live side-by-side with the current method body) or a
12231 more complicated expression if the method has a CaptureContext.
12233 (EmitContext.EmitTopBlock): Routine that drives the emission of
12234 code: it will first resolve the top block, then emit any metadata
12235 and then emit the code. The split is done so that we can extract
12236 any anonymous methods and flag any captured variables/parameters.
12238 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
12239 during this phase, the ILGenerator should not be used as labels
12240 and local variables declared here might not be accessible to any
12241 code that is part of an anonymous method.
12243 Exceptions to this include the temporary variables that are
12244 created by some statements internally for holding temporary
12247 (EmitContext.EmitMeta): New routine, in charge of emitting all the
12250 (EmitContext.TemporaryReturn): This method is typically called
12251 from the Emit phase, and its the only place where we allow the
12252 ReturnLabel to be defined other than the EmitMeta. The reason is
12253 that otherwise we would have to duplicate a lot of logic in the
12254 Resolve phases of various methods that today is on the Emit
12257 (EmitContext.NeedReturnLabel): This no longer creates the label,
12258 as the ILGenerator is not valid during the resolve phase.
12260 (EmitContext.EmitThis): Extended the knowledge in this class to
12261 work in anonymous methods in addition to iterators.
12263 (EmitContext.EmitCapturedVariableInstance): This emits whatever
12264 code is necessary on the stack to access the instance to a local
12265 variable (the variable will be accessed as a field).
12267 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
12268 EmitContext.EmitAddressOfParameter): Routines to support
12269 parameters (not completed at this point).
12271 Removals: Removed RemapLocal and RemapLocalLValue. We probably
12272 will also remove the parameters.
12274 * convert.cs (Convert): Define a `ConstantEC' which points to a
12275 null. This is just to prefity some code that uses
12276 ImplicitStandardConversion code and do not have an EmitContext
12279 The idea is to flag explicitly that at that point in time, it is
12280 known that the conversion will not trigger the delegate checking
12281 code in implicit conversions (which requires a valid
12284 Everywhere: pass new EmitContext parameter since
12285 ImplicitStandardConversionExists now requires it to check for
12286 anonymous method conversions.
12288 (Convert.ImplicitStandardConversionExists): If the type of an
12289 expression is the anonymous_method_type, and the type is a
12290 delegate, we invoke the AnonymousMethod.Compatible method to check
12291 whether an implicit conversion is possible.
12293 (Convert.ImplicitConversionStandard): Only do implicit method
12294 group conversions if the language level is not ISO_1.
12296 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
12297 MethodInfo for the Invoke method. used by Delegate and
12300 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
12301 method conversions if the target type is a delegate.
12303 Removed extra debugging nops.
12305 (LocalVariableReference): Turn the `local_info' into a public
12308 Add `prepared' field, the same hack used for FieldExprs to cope
12309 with composed assignments, as Local variables do not necessarily
12310 operate purely on the stack as they used to: they can be captured
12313 Add `temp' for a temporary result, like fields.
12315 Refactor DoResolve and DoResolveLValue into DoResolveBase.
12317 It now copes with Local variables that are captured and emits the
12318 proper instance variable to load it from a field in the captured
12321 (ParameterReference.DoResolveBase): During the resolve phase,
12322 capture parameters if we are in an anonymous method.
12324 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
12325 anonymous method, use the EmitContext helper routines to emit the
12326 parameter reference.
12328 * iterators.cs: Set RemapToProxy to true/false during the
12331 * parameters.cs (GetParameterByName): New helper method.
12333 * typemanager.cs (anonymous_method_type) a new type that
12334 represents an anonyous method. This is always an internal type,
12335 used as a fencepost to test against the anonymous-methodness of an
12338 2004-10-20 Marek Safar <marek.safar@seznam.cz>
12340 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
12342 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
12344 2004-10-18 Martin Baulig <martin@ximian.com>
12346 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
12347 `Type' directly, but call ResolveType() on it.
12348 (Catch.Resolve): Likewise.
12349 (Foreach.Resolve): Likewise.
12351 2004-10-18 Martin Baulig <martin@ximian.com>
12353 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
12354 `Type' directly, but call ResolveType() on it.
12355 (Probe.DoResolve): Likewise.
12356 (ArrayCreation.LookupType): Likewise.
12357 (TypeOf.DoResolve): Likewise.
12358 (SizeOf.DoResolve): Likewise.
12360 2004-10-18 Martin Baulig <martin@ximian.com>
12362 * expression.cs (Invocation.BetterFunction): Put back
12363 TypeManager.TypeToCoreType().
12365 2004-10-18 Raja R Harinath <rharinath@novell.com>
12367 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
12370 2004-10-18 Martin Baulig <martin@ximian.com>
12372 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
12373 `Type' directly, but call ResolveType() on it.
12375 2004-10-18 Martin Baulig <martin@ximian.com>
12377 * class.cs (FieldMember.Define): Don't access the TypeExpr's
12378 `Type' directly, but call ResolveType() on it.
12379 (MemberBase.DoDefine): Likewise.
12381 * expression.cs (New.DoResolve): Don't access the TypeExpr's
12382 `Type' directly, but call ResolveType() on it.
12383 (ComposedCast.DoResolveAsTypeStep): Likewise.
12385 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
12386 `Type' directly, but call ResolveType() on it.
12388 2004-10-17 John Luke <john.luke@gmail.com>
12390 * class.cs (Operator.GetSignatureForError): use CSharpName
12392 * parameter.cs (Parameter.GetSignatureForError): Returns
12393 correct name even if was not defined.
12395 2004-10-13 Raja R Harinath <rharinath@novell.com>
12398 * class.cs (TypeContainer.EmitContext): New property.
12399 (DefineNestedTypes): Create an emitcontext for each part.
12400 (MethodCore.DoDefineParameters): Use container's emitcontext.
12401 Pass type array to InternalParameters.
12402 (MemberBase.DoDefine): Use container's emitcontext.
12403 (FieldMember.Define): Likewise.
12404 (Event.Define): Likewise.
12405 (SetMethod.GetParameterInfo): Change argument to EmitContext.
12406 Pass type array to InternalParameters.
12407 (SetIndexerMethod.GetParameterInfo): Likewise.
12408 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
12409 * delegate.cs (Define): Pass emitcontext to
12410 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
12411 array to InternalParameters.
12412 * expression.cs (ParameterReference.DoResolveBase): Pass
12413 emitcontext to GetParameterInfo.
12414 (ComposedCast.DoResolveAsTypeStep): Remove check on
12415 ec.ResolvingTypeTree.
12416 * parameter.cs (Parameter.Resolve): Change argument to
12417 EmitContext. Use ResolveAsTypeTerminal.
12418 (Parameter.GetSignature): Change argument to EmitContext.
12419 (Parameters.ComputeSignature): Likewise.
12420 (Parameters.ComputeParameterTypes): Likewise.
12421 (Parameters.GetParameterInfo): Likewise.
12422 (Parameters.ComputeAndDefineParameterTypes): Likewise.
12423 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
12424 * support.cs (InternalParameters..ctor): Remove variant that takes
12426 * typemanager.cs (system_intptr_expr): New.
12427 (InitExpressionTypes): Initialize it.
12429 2004-10-12 Chris Toshok <toshok@ximian.com>
12431 * cs-parser.jay: fix location for try_statement and catch_clause.
12433 2004-10-11 Martin Baulig <martin@ximian.com>
12435 * report.cs: Don't make --fatal abort on warnings, we have
12436 -warnaserror for that.
12438 2004-10-07 Raja R Harinath <rharinath@novell.com>
12440 More DeclSpace.ResolveType avoidance.
12441 * decl.cs (MemberCore.InUnsafe): New property.
12442 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
12443 with newly created EmitContext.
12444 (FieldMember.Define): Likewise.
12445 * delegate.cs (Delegate.Define): Likewise.
12446 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
12447 only if normal name-lookup fails.
12448 (TypeExpr.DoResolve): Enable error-checking.
12449 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
12450 (SizeOf.DoResolve): Likewise.
12451 (ComposedCast.DoResolveAsTypeStep): Likewise.
12452 (StackAlloc.DoResolve): Likewise.
12453 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
12454 (Block.Unsafe): New property.
12455 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
12456 (Unsafe): Set 'unsafe' flag of contained block.
12457 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
12458 (Fixed.Resolve): Likewise.
12459 (Catch.Resolve): Likewise.
12460 (Using.ResolveLocalVariableDecls): Likewise.
12461 (Foreach.Resolve): Likewise.
12463 2004-10-05 John Luke <john.luke@gmail.com>
12465 * cs-parser.jay: add location to error CS0175
12467 2004-10-04 Miguel de Icaza <miguel@ximian.com>
12469 * ecore.cs (Expression.Constantity): Add support for turning null
12472 * const.cs (Const.Define): Allow constants to be reference types
12473 as long as the value is Null.
12475 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
12477 * namespace.cs (NamespaceEntry.Using): No matter which warning
12478 level is set, check if this namespace name has already been added.
12480 2004-10-03 Ben Maurer <bmaurer@ximian.com>
12482 * expression.cs: reftype [!=]= null should always use br[true,false].
12485 2004-10-03 Marek Safar <marek.safar@seznam.cz>
12488 * attribute.cs: Enum conversion moved to
12489 GetAttributeArgumentExpression to be applied to the all
12492 2004-10-01 Raja R Harinath <rharinath@novell.com>
12494 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
12495 * class.c (TypeContainer.DefineType): Flag error if
12496 base types aren't accessible due to access permissions.
12497 * decl.cs (DeclSpace.ResolveType): Move logic to
12498 Expression.ResolveAsTypeTerminal.
12499 (DeclSpace.ResolveTypeExpr): Thin layer over
12500 Expression.ResolveAsTypeTerminal.
12501 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
12502 Refactor code into NestedAccess. Use it.
12503 (DeclSpace.NestedAccess): New.
12504 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
12505 argument to silence errors. Check access permissions.
12506 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
12507 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
12508 (Cast.DoResolve): Likewise.
12509 (New.DoResolve): Likewise.
12510 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
12511 (TypeOf.DoResolve): Likewise.
12513 * expression.cs (Invocation.BetterConversion): Return the Type of
12514 the better conversion. Implement section 14.4.2.3 more faithfully.
12515 (Invocation.BetterFunction): Make boolean. Make correspondence to
12516 section 14.4.2.2 explicit.
12517 (Invocation.OverloadResolve): Update.
12518 (Invocation): Remove is_base field.
12519 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
12520 (Invocation.Emit): Likewise.
12522 2004-09-27 Raja R Harinath <rharinath@novell.com>
12524 * README: Update to changes.
12526 2004-09-24 Marek Safar <marek.safar@seznam.cz>
12528 * cs-parser.jay: Reverted 642 warning fix.
12530 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12533 * decl.cs (FindMemberWithSameName): Indexer can have more than
12536 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12538 * expression.cs (LocalVariableReference.DoResolveLValue):
12539 Do not report warning 219 for out values.
12540 (EmptyExpression.Null): New member to avoid extra allocations.
12542 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12544 * cs-parser.jay: Fix wrong warning 642 report.
12546 * cs-tokenizer.cs (CheckNextToken): New helper;
12547 Inspect next character if is same as expected.
12549 2004-09-23 Martin Baulig <martin@ximian.com>
12551 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
12552 (Convert.ImplicitReferenceConversionExists): Likewise.
12554 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12556 * class.cs (Operator.Define): Add error 448 and 559 report.
12558 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12560 * class.cs (MemberBase.IsTypePermitted): New protected
12561 method for checking error CS0610.
12563 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12565 * class.cs (TypeContainer.HasExplicitLayout): New property
12566 Returns whether container has StructLayout attribute set Explicit.
12567 (FieldMember): New abstract class for consts and fields.
12568 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
12569 (Field): Reuse FieldMember.
12571 * const.cs (Const): Reuse FieldMember.
12573 * rootcontext.cs: EmitConstants call moved to class.
12575 2004-09-22 Martin Baulig <martin@ximian.com>
12577 Thanks to Peter Sestoft for this bug report.
12579 * expression.cs (Conditional): If both the `trueExpr' and the
12580 `falseExpr' is a NullLiteral, return a NullLiteral.
12582 2004-09-22 Martin Baulig <martin@ximian.com>
12584 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
12585 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
12586 for the "get_Current" call.
12588 2004-09-22 Martin Baulig <martin@ximian.com>
12590 Marek and me just fixed one of our oldest bugs: #28562 :-)
12592 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
12594 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
12595 we're an EnumConstant, just return that.
12596 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
12597 an EnumConstant. In this case, we need to use GetValueAsEnumType()
12598 to get the value which'll actually be written into the attribute.
12599 However, we have to use GetValue() to access the attribute's value
12602 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12604 * constant.cs (Constant.IsNegative): New abstract property
12607 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
12608 (StackAlloc.DoResolve): Reused IsNegative.
12610 2004-09-21 Martin Baulig <martin@ximian.com>
12612 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
12613 if we're used in an iterator, we may be called from different
12616 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
12617 we actually have an exception block.
12619 2004-09-20 John Luke <jluke@cfl.rr.com>
12621 * class.cs, cs-parser.jay: Improve the error report for 1520:
12622 report the actual line where the error happens, not where the
12623 class was declared.
12625 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
12626 Pass location information that was available elsewhere.
12628 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
12630 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
12631 runtime to delay sign assemblies.
12633 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12635 * cs-parser.jay: Do not report the stack trace, this is barely
12638 2004-08-22 John Luke <john.luke@gmail.com>
12640 * driver.cs : check that a resource id is not already used
12641 before adding it, report CS1508 if it is, bug #63637
12643 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12645 * ecore.cs: Removed dead code.
12647 2004-09-18 Marek Safar <marek.safar@seznam.cz>
12649 * class.cs: Do not report warning CS0067 on the interfaces.
12651 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12653 * cs-parser.jay: Add error 504 report.
12655 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12657 * rootcontext.cs: WarningLevel is 4 by default now.
12659 * statement.cs (Fixed.Resolve): Do not null
12662 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12665 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
12666 deep search when property is not virtual.
12667 (PropertyExpr.ResolveAccessors): Make one call for both
12670 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12673 * statement.cs: Error 152 report constains also location.
12675 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12678 * const.cs: Explicitly set constant as static.
12680 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12683 * cs-parser.jay: Add error 1017 report.
12685 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12687 Fixed bug #59980, #64224
12688 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
12690 * typemanager.cs (IsSpecialMethod): Simplified
12692 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12694 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
12695 condition with better params.
12697 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12700 * attribute.cs (Resolve): Property has to have both
12703 2004-09-14 Martin Baulig <martin@ximian.com>
12705 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
12707 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12710 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
12711 called and is obsolete then this member suppress message
12712 when call is inside next [Obsolete] method or type.
12714 * expression.cs: Use TestObsoleteMethodUsage member.
12716 2004-09-14 Martin Baulig <martin@ximian.com>
12718 * cs-parser.jay: Sync a bit with the GMCS version.
12720 2004-09-14 Martin Baulig <martin@ximian.com>
12722 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
12723 (CSharpParser.yacc_verbose_flag): New public field.
12725 * genericparser.cs: Removed.
12727 2004-09-14 Raja R Harinath <rharinath@novell.com>
12729 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
12731 2004-09-13 Marek Safar <marek.safar@seznam.cz>
12733 * class.cs (MethodCore.CheckBase): Fix bug #65757.
12735 2004-09-10 Martin Baulig <martin@ximian.com>
12737 Backported my MemberName changes from GMCS into MCS.
12739 - we are now using a special `MemberName' class instead of using
12740 strings; in GMCS, the `MemberName' also contains the type
12743 - changed the grammar rules a bit:
12744 * the old `member_name' is now a `namespace_or_type_name':
12745 The rule is that we use `namespace_or_type_name' everywhere
12746 where we expect either a "member name" (GetEnumerator) or a
12747 "member name" with an explicit interface name
12748 (IEnumerable.GetEnumerator).
12749 In GMCS, the explicit interface name may include type arguments
12750 (IEnumerable<T>.GetEnumerator).
12751 * we use `member_name' instead of just `IDENTIFIER' for
12753 The rule is that we use `member_name' wherever a member may
12754 have type parameters in GMCS.
12756 * decl.cs (MemberName): New public class.
12757 (MemberCore.MemberName): New public readonly field.
12758 (MemberCore.ctor): Take a `MemberName' argument, not a string.
12759 (DeclSpace): Likewise.
12761 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
12762 * enum.cs (Enum.ctor): Likewise.
12764 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
12766 (AliasEntry.ctor): Take a MemberName, not an Expression.
12767 (AliasEntry.UsingAlias): Likewise.
12769 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
12770 (IMethodData.MemberName): Changed type from string to MemberName.
12771 (MemberBase.ExplicitInterfaceName): Likewise.
12772 (AbstractPropertyEventMethod.SetupName): Make this private.
12773 (AbstractPropertyEventMethod.ctor): Added `string prefix'
12774 argument; compute the member name here.
12775 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
12776 on the `member.MemberName' and the `prefix'.
12778 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
12780 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
12781 thus, we get a `MemberName' instead of a `string'. These
12782 declarations may have type parameters in GMCS.
12783 (interface_method_declaration, delegate_declaration): Likewise.
12784 (class_declaration, interface_declaration): Likewise.
12785 (method_header): Use `namespace_or_type_name' instead of
12786 `member_name'. We may be an explicit interface implementation.
12787 (property_declaration, event_declaration): Likewise.
12788 (member_name): This is now just an `IDENTIFIER', not a
12789 `namespace_or_type_name'.
12790 (type_name, interface_type): Removed.
12791 (namespace_or_type_name): Return a MemberName, not an Expression.
12792 (primary_expression): Use `member_name' instead of `IDENTIFIER';
12793 call GetTypeExpression() on the MemberName to get an expression.
12794 (IndexerDeclaration.interface_type): Changed type from string to
12796 (MakeName): Operate on MemberName's instead of string's.
12798 2004-09-13 Raja R Harinath <rharinath@novell.com>
12801 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
12802 (NamespaceEntry.Lookup): Add new argument to flag if we want the
12803 lookup to avoid symbols introduced by 'using'.
12804 * rootcontext.cs (NamespaceLookup): Update.
12806 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12808 * class.cs (TypeContainer.DoDefineMembers): Do not call
12809 DefineDefaultConstructor for static classes.
12811 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12813 * attribute.cs (Attribute.Resolve): Add error 653 report.
12815 * class.cs (Class.ApplyAttributeBuilder): Add error 641
12817 (Method.ApplyAttributeBuilder): Add error 685 report.
12818 (Operator.Define): Add error 564 report.
12820 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
12822 * expression.cs (Invocation.DoResolve): Add error
12823 245 and 250 report.
12825 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
12828 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12830 * class.cs (ConstructorInitializer.Resolve):
12831 Wrong error number (515->516).
12833 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12835 * class.cs (Indexer.Define): Add error 631 report.
12837 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12839 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
12841 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12843 * expression.cs (Probe.DoResolve): Add error CS0241 report.
12845 2004-09-10 Marek Safar <marek.safar@seznam.cz>
12847 * cs-parser.jay: Added error CS0241 report.
12849 2004-09-10 Raja R Harinath <rharinath@novell.com>
12851 * cs-parser.jay (fixed_statement): Introduce a scope for the
12852 declaration in the 'fixed' statement.
12854 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12856 * cs-parser.jay: Added CS0230 error report.
12858 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12860 * cs-parser.jay: Added errors CS0231 and CS0257 report.
12862 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12864 * expression.cs (Argument.Resolve): Added error CS0192 and
12867 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12869 C# 2.0 #pragma warning feature
12871 * cs-tokenizer.cs (PreProcessPragma): New method;
12872 Handles #pragma directive.
12874 * report.cs (WarningRegions): New class; Support
12875 class for #pragma warning directive. It tests whether
12876 warning is enabled for a given line.
12878 2004-09-08 Miguel de Icaza <miguel@ximian.com>
12880 * const.cs: Add more descriptive error report, tahnks to
12883 2004-09-08 Marek Safar <marek.safar@seznam.cz>
12885 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
12887 2004-09-07 Miguel de Icaza <miguel@ximian.com>
12889 * expression.cs: Apply patch from Ben: Remove dead code from
12890 ArrayCreation, and remove the TurnintoConstant call in const.cs,
12891 as that code just threw an exception anwyays.
12893 * const.cs: Remove the call to the turnintoconstant, for details
12896 * literal.cs: The type of the null-literal is the null type; So
12897 we use a placeholder type (literal.cs:System.Null, defined here)
12900 * expression.cs (Conditional.DoResolve): Remove some old code that
12901 is no longer needed, conversions have been fixed.
12903 (ArrayCreationExpression.DoResolve): Return false if we fail to
12904 resolve the inner expression.
12906 2004-09-07 Raja R Harinath <rharinath@novell.com>
12909 * cs-parser.jay (delegate_declaration): Record a delegate
12910 declaration as a type declaration.
12911 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
12913 2004-09-06 Miguel de Icaza <miguel@ximian.com>
12915 * parameter.cs: Do not crash if the type can not be resolved.
12917 * expression.cs: Report errors with unsafe pointers, fixes #64896
12919 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
12921 * expression.cs: Pointer arith always needs to do a conv.i
12922 if the operand is a long. fix 65320
12924 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12926 Fixed cs0619-37.cs, cs0619-38.cs
12928 * enum.cs (GetObsoleteAttribute): Removed.
12930 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
12931 on Enum member is double staged. The first is tested member
12934 2004-09-04 Marek Safar <marek.safar@seznam.cz>
12936 Fixed #56986, #63631, #65231
12938 * class.cs: (TypeContainer.AddToMemberContainer): New method,
12939 adds member to name container.
12940 (TypeContainer.AddToTypeContainer): New method, adds type to
12942 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
12943 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
12944 AddOperator): Simplified by reusing AddToMemberContainer.
12945 (TypeContainer.UserDefinedStaticConstructor): Changed to property
12947 (Method.CheckForDuplications): Fixed implementation to test all
12949 (MemberBase): Detection whether member is explicit interface
12950 implementation is now in constructor.
12951 (MemberBase.UpdateMemberName): Handles IndexerName.
12952 (Accessor): Changed to keep also location information.
12953 (AbstractPropertyEventMethod): Is derived from MemberCore.
12954 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
12955 will be emited or not.
12956 (PropertyBase.AreAccessorsDuplicateImplementation):
12957 Tests whether accessors are not in collision with some method.
12958 (Operator): Is derived from MethodCore to simplify common
12961 * decl.cs (Flags.TestMethodDuplication): Test for duplication
12963 (DeclSpace.AddToContainer): Adds the member to defined_names
12964 table. It tests for duplications and enclosing name conflicts.
12966 * enum.cs (EnumMember): Clean up to reuse the base structures
12968 2004-09-03 Martin Baulig <martin@ximian.com>
12970 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
12971 into TypeContainer, to make partial classes work again.
12973 2004-09-03 Martin Baulig <martin@ximian.com>
12975 * rootcontext.cs (RootContext.V2): Removed.
12977 2004-03-23 Martin Baulig <martin@ximian.com>
12979 * expression.cs (Invocation.OverloadResolve): Added `bool
12980 may_fail' argument and use it instead of the Location.IsNull() hack.
12982 2004-09-03 Martin Baulig <martin@ximian.com>
12984 Merged latest changes into gmcs. Please keep this comment in
12985 here, it makes it easier for me to see what changed in MCS since
12986 the last time I merged.
12988 2004-09-03 Raja R Harinath <rharinath@novell.com>
12991 * expression.cs (BetterConversion): Don't allow either conversion
12992 to be null. Remove redundant implicit conversion test when 'q ==
12993 null' -- when this function is invoked, we already know that the
12994 implicit conversion exists.
12995 (BetterFunction): Assume that 'best' is non-null. Remove
12996 redundant reimplementation of IsApplicable when 'best' is null.
12997 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
12998 number of arguments.
12999 (IsAncestralType): Extract from OverloadResolve.
13000 (OverloadResolve): Make robust to the MethodGroupExpr being
13001 unsorted. Implement all the logic of Section 14.5.5.1, and
13002 support overloading of methods from multiple applicable types.
13003 Clean up logic somewhat. Don't pass null methods to BetterFunction.
13005 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
13006 (RealError, Warning): Append type of report to related symbol.
13008 2004-09-03 Marek Safar <marek.safar@seznam.cz>
13010 * enum.cs: Fixed CLS-Compliance checks for enum members.
13011 Error tests cs3008-8.cs, cs3014-8.cs
13013 2004-09-02 Marek Safar <marek.safar@seznam.cz>
13015 Fixed bug #62342, #63102
13016 * class.cs: ImplementIndexer uses member.IsExplicitImpl
13017 like ImplementMethod.
13019 2004-09-02 Marek Safar <marek.safar@seznam.cz>
13021 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13024 2004-09-02 Martin Baulig <martin@ximian.com>
13026 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
13027 TypeManager.GetArgumentTypes() rather than calling GetParameters()
13030 2004-09-01 Marek Safar <marek.safar@seznam.cz>
13032 C# 2.0 Static classes implemented
13034 * class.cs (TypeContainer): instance_constructors,
13035 initialized_fields, initialized_static_fields,
13036 default_constructor, base_inteface_types are protected to be
13037 accessible from StaticClass.
13038 (TypeContainer.DefineDefaultConstructor): New virtual method
13039 for custom default constructor generating
13040 (StaticClass): New class to handle "Static classes" feature.
13042 * cs-parser.jay: Handle static keyword on class like instance
13045 * driver.cs: Added "/langversion" command line switch with two
13046 options (iso-1, default).
13048 2004-08-31 Marek Safar <marek.safar@seznam.cz>
13050 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
13052 2004-08-31 Miguel de Icaza <miguel@ximian.com>
13054 * delegate.cs: Style.
13056 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
13058 * delegate.cs: Add seperate instance expr field for miguel.
13060 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13062 * PointerArithmetic (Resolve): make sure we are not doing
13063 pointer arith on void*. Also, make sure we are resolved
13064 by not setting eclass until resolve.
13066 All callers: Make sure that PointerArithmetic gets resolved.
13068 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13070 * ArrayCreation (LookupType): If the type does not resolve
13071 to an array, give an error.
13073 2004-08-27 Marek Safar <marek.safar@seznam.cz>
13075 * statement.cs (Try.Resolve): Fixed bug #64222
13077 2004-08-27 Martin Baulig <martin@ximian.com>
13080 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
13083 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13085 * ecore.cs (Constantify): Get underlying type via
13086 System.Enum.GetUnderlyingType to avoid StackOverflow on the
13087 Windows in special cases.
13089 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13091 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
13092 for obtaining also private methods.
13093 (GetRemoveMethod): Used GetRemoveMethod (true)
13094 for obtaining also private methods.
13096 2004-08-24 Martin Baulig <martin@ximian.com>
13098 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
13099 MethodAttributes.HideBySig for operators.
13101 2004-08-23 Martin Baulig <martin@ximian.com>
13103 Back to the old error reporting system :-)
13105 * report.cs (Message): Removed.
13106 (Report.MessageData, ErrorData, WarningData): Removed.
13107 (Report.Error, Warning): Back to the old system.
13109 2004-08-23 Martin Baulig <martin@ximian.com>
13111 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
13113 * class.cs (TypeContainer.ParentContainer): New public virtual
13114 method; replaces the explicit interface implementation.
13115 (ClassPart.ParentContainer): Override.
13117 2004-08-23 Martin Baulig <martin@ximian.com>
13119 * statement.cs (Switch): Added support for constant switches; see
13120 #59428 or test-285.cs.
13122 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13125 * statement.cs (GetEnumeratorFilter): Removed useless
13126 logic because C# specs is strict. GetEnumerator must be
13129 2004-08-22 Martin Baulig <martin@ximian.com>
13131 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13132 a switch and may break, reset the barrier. Fixes #59867.
13134 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13136 CLS-Compliance speed up (~5% for corlib)
13138 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
13139 New method. Tests container for CLS-Compliant names
13141 * class.cs (TypeContainer.VerifyClsName): New method.
13142 Checks whether container name is CLS Compliant.
13143 (Constructor): Implements IMethodData.
13145 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
13146 low-case table for CLS Compliance test.
13147 (MemberCache.VerifyClsParameterConflict): New method.
13148 Checks method parameters for CS3006 error.
13150 * enum.cs (EnumMember): Is derived from MemberCore.
13151 (Enum.VerifyClsName): Optimized for better performance.
13153 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13155 * report.cs: Renamed Error_T to Error and changed all
13158 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13160 * class.cs (TypeContainer.IndexerArrayList): New inner class
13161 container for indexers.
13162 (TypeContainer.DefaultIndexerName): New constant for default
13163 indexer name. Replaced all "Item" with this constant.
13164 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
13166 * typemanager.cs (TypeManager.default_member_ctor): Cache here
13167 DefaultMemberAttribute constructor.
13169 2004-08-05 Martin Baulig <martin@ximian.com>
13171 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13174 2004-08-05 Marek Safar <marek.safar@seznam.cz>
13176 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
13177 multi platforms problem.
13179 * compiler.csproj: Included shared files.
13181 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13183 Fix bug 60333, 55971 in the more general way
13184 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13185 Added arg_type argument for constant conversion.
13186 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
13188 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13191 * class.cs (TypeContainer ): New inner classes MethodArrayList,
13192 OperatorArrayList, MethodCoreArrayList for typecontainer
13193 containers. Changed class member types to these new types.
13194 (MethodArrayList.DefineMembers): Added test for CS0659.
13196 2004-08-04 Miguel de Icaza <miguel@ximian.com>
13198 * cfold.cs: Synchronize the folding with the code in expression.cs
13199 Binary.DoNumericPromotions for uint operands.
13201 * attribute.cs: Revert patch from Raja, it introduced a regression
13202 while building Blam-1.2.1 (hard to isolate a test case).
13204 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13208 (TypeContainer.Define): Renamed to DefineContainerMembers because of
13210 (MethodCore.parent_method): New member. The method we're overriding
13211 if this is an override method.
13212 (MethodCore.CheckBase): Moved from Method class and made common.
13213 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
13215 (MethodCore.CheckForDuplications): New abstract method. For custom
13216 member duplication search in a container
13217 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
13218 method and its return type.
13219 (Event.conflict_symbol): New member. Symbol with same name in the
13223 (MemberCache.FindMemberWithSameName): New method. The method
13224 is looking for conflict with inherited symbols.
13226 2004-08-04 Martin Baulig <martin@ximian.com>
13228 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
13230 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
13232 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13234 * report.cs (Message): New enum for better error, warning reference in
13236 (MessageData): New inner abstract class. It generally handles printing of
13237 error and warning messages.
13238 Removed unused Error, Warning, Message methods.
13240 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13242 Fix for cs0592-8.cs test
13244 (Attributable.ValidAttributeTargets): Made public.
13245 (Attribute.ExplicitTarget): New member for explicit target value.
13246 (Attribute.CheckTargets): Now we translate explicit attribute
13247 target to Target here.
13249 2004-08-03 Ben Maurer <bmaurer@ximian.com>
13251 * ecore.cs (MethodGroupExpr): new IsBase property.
13253 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
13255 * delegate.cs (DelegateCreation): store a MethodGroupExpr
13256 rather than an instance expr.
13258 (DelegateCreation.Emit): Use the method group rather than
13259 the instance expression. Also, if you have base.Foo as the
13260 method for a delegate, make sure to emit ldftn, not ldftnvirt.
13262 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
13264 (NewDelegate.DoResolve): Only check for the existance of Invoke
13265 if the method is going to be needed. Use MethodGroupExpr.
13267 (NewDelegate.Emit): Remove, DelegateCreation implements this.
13269 * expression.cs: For pointer arith., make sure to use
13270 the size of the type, not the size of the pointer to
13273 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13276 * class.cs (Class): Added error CS0502 test.
13278 2004-08-03 John Luke <jluke@cfl.rr.com>
13279 Raja R Harinath <rharinath@novell.com>
13282 * attribute.cs (Attribute.complained_before): New flag.
13283 (Attribute.ResolveType, Attribute.Resolve),
13284 (Attribute.DefinePInvokeMethod): Set it.
13285 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
13287 2004-08-03 Martin Baulig <martin@ximian.com>
13289 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
13290 use a user-defined operator; we still need to do numeric
13291 promotions in case one argument is a builtin type and the other
13292 one has an implicit conversion to that type. Fixes #62322.
13294 2004-08-02 Martin Baulig <martin@ximian.com>
13296 * statement.cs (LocalInfo.Flags): Added `IsThis'.
13297 (LocalInfo.IsThis): New public property.
13298 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
13300 2004-08-01 Martin Baulig <martin@ximian.com>
13302 * class.cs (TypeContainer.GetClassBases): Don't set the default
13303 here since we may get called from GetPartialBases().
13304 (TypeContainer.DefineType): If GetClassBases() didn't return a
13305 parent, use the default one.
13307 2004-07-30 Duncan Mak <duncan@ximian.com>
13309 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
13311 2004-07-30 Martin Baulig <martin@ximian.com>
13313 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
13315 * class.cs (SourceMethod): New public class, derive from the
13316 symbol writer's ISourceMethod.
13317 (Method): Use the new symbol writer API.
13319 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
13320 as argument and use the new symbol writer.
13323 (SourceFile): Implement the symbol writer's ISourceFile.
13324 (Location.SymbolDocument): Removed.
13325 (Location.SourceFile): New public property.
13327 * symbolwriter.cs: Use the new symbol writer API.
13329 2004-07-30 Raja R Harinath <rharinath@novell.com>
13331 * Makefile (install-local): Remove. Functionality moved to
13334 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
13336 * Makefile: Install mcs.exe.config file together with mcs.exe.
13337 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
13338 correct runtime version.
13340 2004-07-25 Martin Baulig <martin@ximian.com>
13343 (TypeContainer.RegisterOrder): Removed, this was unused.
13344 (TypeContainer, interface_order): Removed.
13345 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
13346 TypeContainer as argument since we can also be called with a
13347 `PartialContainer' for a partial class/struct/interface.
13348 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
13349 of checking whether we're an `Interface' - we could be a
13350 `PartialContainer'.
13351 (PartialContainer.Register): Override; call
13352 AddClass()/AddStruct()/AddInterface() on our parent.
13354 * cs-parser.jay (interface_member_declaration): Add things to the
13355 `current_container', not the `current_class'.
13357 * rootcontext.cs (RegisterOrder): The overloaded version which
13358 takes an `Interface' was unused, removed.
13360 * typemanager.cs (TypeManager.LookupInterface): Return a
13361 `TypeContainer', not an `Interface'.
13362 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
13363 contain a `PartialContainer' for an interface, so check it's
13364 `Kind' to figure out what it is.
13366 2004-07-25 Martin Baulig <martin@ximian.com>
13368 * class.cs (Class.DefaultTypeAttributes): New public constant.
13369 (Struct.DefaultTypeAttributes): Likewise.
13370 (Interface.DefaultTypeAttributes): Likewise.
13371 (PartialContainer.TypeAttr): Override this and add the
13372 DefaultTypeAttributes.
13374 2004-07-25 Martin Baulig <martin@ximian.com>
13376 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
13377 we can just use the `Parent' field instead.
13379 2004-07-25 Martin Baulig <martin@ximian.com>
13381 * class.cs (TypeContainer.Emit): Renamed to EmitType().
13383 2004-07-25 Martin Baulig <martin@ximian.com>
13385 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
13386 our parts before defining any methods.
13387 (TypeContainer.VerifyImplements): Make this virtual.
13388 (ClassPart.VerifyImplements): Override and call VerifyImplements()
13389 on our PartialContainer.
13391 2004-07-25 Martin Baulig <martin@ximian.com>
13393 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
13395 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
13396 argument, we can just use the `Parent' field instead.
13399 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
13400 (MemberBase.DoDefine): Likewise.
13402 2004-07-24 Martin Baulig <martin@ximian.com>
13404 * decl.cs (MemberCore.Parent): New public field.
13405 (DeclSpace.Parent): Moved to MemberCore.
13407 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
13408 (MemberBase.ctor): Added TypeContainer argument, pass it to our
13410 (FieldBase, Field, Operator): Likewise.
13411 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
13412 (EventField, Event): Likewise.
13414 2004-07-23 Martin Baulig <martin@ximian.com>
13416 * class.cs (PartialContainer): New public class.
13417 (ClassPart): New public class.
13418 (TypeContainer): Added support for partial classes.
13419 (TypeContainer.GetClassBases): Splitted some of the functionality
13420 out into GetNormalBases() and GetPartialBases().
13422 * cs-tokenizer.cs (Token.PARTIAL): New token.
13423 (Tokenizer.consume_identifier): Added some hacks to recognize
13424 `partial', but only if it's immediately followed by `class',
13425 `struct' or `interface'.
13427 * cs-parser.jay: Added support for partial clases.
13429 2004-07-23 Martin Baulig <martin@ximian.com>
13431 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
13432 a `DeclSpace' and also made it readonly.
13433 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
13434 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
13435 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
13437 * cs-parser.jay: Pass the `current_class', not the
13438 `current_container' (at the moment, this is still the same thing)
13439 to a new Method, Property, Event, Indexer or Constructor.
13441 2004-07-23 Martin Baulig <martin@ximian.com>
13443 * cs-parser.jay (CSharpParser): Added a new `current_class' field
13444 and removed the `current_interface' one.
13445 (struct_declaration, class_declaration, interface_declaration):
13446 Set `current_class' to the newly created class/struct/interface;
13447 set their `Bases' and call Register() before parsing their body.
13449 2004-07-23 Martin Baulig <martin@ximian.com>
13451 * class.cs (Kind): New public enum.
13452 (TypeContainer): Made this class abstract.
13453 (TypeContainer.Kind): New public readonly field.
13454 (TypeContainer.CheckDef): New public method; moved here from
13456 (TypeContainer.Register): New public abstract method.
13457 (TypeContainer.GetPendingImplementations): New public abstract
13459 (TypeContainer.GetClassBases): Removed the `is_class' and
13460 `is_iface' parameters.
13461 (TypeContainer.DefineNestedTypes): Formerly known as
13463 (ClassOrStruct): Made this class abstract.
13465 * tree.cs (RootTypes): New public type.
13467 2004-07-20 Martin Baulig <martin@ximian.com>
13469 * tree.cs (Tree.RecordNamespace): Removed.
13470 (Tree.Namespaces): Removed.
13472 * rootcontext.cs (RootContext.IsNamespace): Removed.
13474 * cs-parser.jay (namespace_declaration): Just create a new
13475 NamespaceEntry here.
13477 2004-07-20 Martin Baulig <martin@ximian.com>
13479 * statement.cs (ExceptionStatement): New abstract class. This is
13480 now used as a base class for everyone who's using `finally'.
13481 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
13482 our local variables before using them.
13484 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
13485 virtual method. This is used by Yield.Resolve() to "steal" an
13486 outer block's `finally' clauses.
13487 (FlowBranchingException): The .ctor now takes an ExceptionStatement
13490 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
13491 version which takes an ExceptionStatement. This version must be
13492 used to create exception branchings.
13495 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
13496 (Iterator.EmitMoveNext): Added exception support; protect the
13497 block with a `fault' clause, properly handle 'finally' clauses.
13498 (Iterator.EmitDispose): Run all the `finally' clauses here.
13500 2004-07-20 Martin Baulig <martin@ximian.com>
13502 * iterator.cs: This is the first of a set of changes in the
13503 iterator code. Match the spec more closely: if we're an
13504 IEnumerable, then GetEnumerator() must be called. The first time
13505 GetEnumerator() is called, it returns the current instance; all
13506 subsequent invocations (if any) must create a copy.
13508 2004-07-19 Miguel de Icaza <miguel@ximian.com>
13510 * expression.cs: Resolve the constant expression before returning
13513 2004-07-19 Martin Baulig <martin@ximian.com>
13515 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
13516 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
13517 the return type of the new EmitContext.
13519 2004-07-18 Martin Baulig <martin@ximian.com>
13521 * class.cs (Property.Define): Fix iterators.
13523 * iterators.cs (Iterator.Define): Moved the
13524 `container.AddInterator (this)' call here from the .ctor; only do
13525 it if we resolved successfully.
13527 2004-07-17 Miguel de Icaza <miguel@ximian.com>
13529 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
13530 `true' for preprocessing directives that we parse. The return
13531 value indicates whether we should return to regular tokenizing or
13532 not, not whether it was parsed successfully.
13534 In the past if we were in: #if false ... #line #endif, we would
13535 resume parsing after `#line'. See bug 61604.
13537 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
13538 building: IsEnumType should return true only for enums, not for
13539 enums or System.Enum itself. This fixes #61593.
13541 Likely what happened is that corlib was wrong: mcs depended on
13542 this bug in some places. The bug got fixed, we had to add the
13543 hack, which caused bug 61593.
13545 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
13546 that was a workaround for the older conditions.
13548 2004-07-16 Ben Maurer <bmaurer@ximian.com>
13550 * assign.cs: IAssignMethod has a new interface, as documented
13551 inline. All assignment code now uses this new api.
13553 * ecore.cs, expression.cs: All classes which implement
13554 IAssignMethod now use the new interface.
13556 * expression.cs (Invocation): add a hack to EmitCall so that
13557 IndexerAccess can be the target of a compound assignment without
13558 evaluating its arguments twice.
13560 * statement.cs: Handle changes in Invocation api.
13562 2004-07-16 Martin Baulig <martin@ximian.com>
13564 * iterators.cs: Rewrote this. We're now using one single Proxy
13565 class for both the IEnumerable and the IEnumerator interface and
13566 `Iterator' derives from Class so we can use the high-level API.
13568 * class.cs (TypeContainer.AddIterator): New method.
13569 (TypeContainer.DoDefineType): New protected virtual method, which
13570 is called from DefineType().
13571 (TypeContainer.DoDefineMembers): Call DefineType() and
13572 DefineMembers() on all our iterators.
13573 (TypeContainer.Emit): Call Emit() on all our iterators.
13574 (TypeContainer.CloseType): Call CloseType() on all our iterators.
13576 * codegen.cs (EmitContext.CurrentIterator): New public field.
13578 2004-07-15 Martin Baulig <martin@ximian.com>
13581 (TypeManager.not_supported_exception_type): New type.
13583 2004-07-14 Martin Baulig <martin@ximian.com>
13585 * iterators.cs: Use real error numbers.
13587 2004-07-14 Martin Baulig <martin@ximian.com>
13589 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
13590 requires this to be a System.Collection.IEnumerable and not a
13591 class implementing that interface.
13592 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
13594 2004-07-13 Marek Safar <marek.safar@seznam.cz>
13596 * class.cs: Fixed previous fix, it broke some error tests.
13598 2004-07-12 Martin Baulig <martin@ximian.com>
13600 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
13603 2004-07-09 Miguel de Icaza <miguel@ximian.com>
13605 * assign.cs (LocalTemporary): Add new argument: is_address,If
13606 `is_address' is true, then the value that we store is the address
13607 to the real value, and not the value itself.
13609 * ecore.cs (PropertyExpr): use the new local temporary
13610 stuff to allow us to handle X.Y += z (where X is a struct)
13612 2004-07-08 Martin Baulig <martin@ximian.com>
13614 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
13615 not always return, just like we're doing in Using.Resolve().
13617 2004-07-07 Miguel de Icaza <miguel@ximian.com>
13619 * cs-parser.jay (fixed_statement): flag this as Pinned.
13621 2004-07-06 Miguel de Icaza <miguel@ximian.com>
13623 * typemanager.cs (TypeManager): Removed MakePinned method, this
13624 mechanism is replaced with the .NET 2.x compatible mechanism of
13625 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
13627 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
13628 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
13629 `IsFixed' property which has a different meaning.
13631 2004-07-02 Raja R Harinath <rharinath@novell.com>
13633 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
13634 visible from inside a nested class, not just the names of the
13635 immediately enclosing class.
13636 Fix for bug #60730.
13638 2004-06-24 Raja R Harinath <rharinath@novell.com>
13640 * expression.cs (BetterConversion): Remove buggy special-case
13641 handling of "implicit constant expression conversions". At this
13642 point, we already know that the conversion is possible -- we're
13643 only checking to see which is better.
13645 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13647 * cs-parser.jay: Added error CS0210 test.
13649 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13651 * cs-parser.jay: Added error CS0134 test.
13653 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13656 * cs-parser.jay: Added error CS0145 test.
13658 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13660 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
13662 2004-06-23 Ben Maurer <bmaurer@ximian.com>
13664 * expression.cs (StackAlloc.Resolve): The argument may not
13665 be a constant; deal with this case.
13667 2004-06-23 Marek Safar <marek.safar@seznam.cz>
13669 * attribute.cs (IndexerName_GetIndexerName): Renamed to
13670 GetIndexerAttributeValue.
13671 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
13673 * class.cs (Indexer.Define): Added error tests for CS0415,
13676 2004-06-23 Miguel de Icaza <miguel@ximian.com>
13678 * attribute.cs (Attribute.Resolve): Keep field code in sync with
13681 2004-06-23 Martin Baulig <martin@ximian.com>
13683 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
13684 neither return nor throw, reset the barrier as well. Fixes #60457.
13686 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
13688 * class.cs : EventAttributes is now set to None by default.
13689 This fixes bug #60459.
13691 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13694 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13695 Don't throw exception but return null (it's sufficient now).
13697 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13699 * typemanager.cs (GetArgumentTypes): Faster implementation.
13701 2004-06-18 Martin Baulig <martin@ximian.com>
13703 * attribute.cs (Attribute.Resolve): Check whether we're an
13704 EmptyCast which a Constant child. Fixes #60333.
13706 2004-06-17 Ben Maurer <bmaurer@ximian.com>
13708 * statement.cs (EmitCollectionForeach): Account for the fact that
13709 not all valuetypes are in areas which we can take the address of.
13710 For these variables, we store to a temporary variable. Also, make
13711 sure that we dont emit a `callvirt' on a valuetype method.
13713 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13715 * expression.cs (StackAlloc.DoReSolve): Added test for
13716 negative parameter (CS0247).
13718 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13721 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
13723 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13726 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
13729 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13731 Fix bug #58254 & cs1555.cs, cs1556.cs
13732 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
13734 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13736 * cs-parser.jay: Added error CS1669 test for indexers.
13738 2004-06-11 Martin Baulig <martin@ximian.com>
13740 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
13741 call this twice: for params and varargs methods.
13743 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13746 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
13748 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13750 * attribute.cs (Attribute.GetValidTargets): Made public.
13753 (AbstractPropertyEventMethod): New class for better code sharing.
13754 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
13756 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
13758 2004-06-11 Raja R Harinath <rharinath@novell.com>
13761 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
13762 that the call to Resolve is part of a MemberAccess.
13763 (Expression.Resolve): Use it for SimpleName resolution.
13764 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
13765 Add 'intermediate' boolean argument.
13766 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
13767 error message when the SimpleName can be resolved ambiguously
13768 between an expression and a type.
13769 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
13771 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
13772 call on the left-side.
13774 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13777 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
13779 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13781 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
13783 2004-06-11 Martin Baulig <martin@ximian.com>
13785 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
13786 varargs methods if applicable.
13788 2004-06-11 Martin Baulig <martin@ximian.com>
13790 * expression.cs (Invocation.EmitCall): Don't use
13791 `method.CallingConvention == CallingConventions.VarArgs' since the
13792 method could also have `CallingConventions.HasThis'.
13794 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13796 * class.cs (Event.GetSignatureForError): Implemented.
13797 Fixed crash in error test cs3010.cs
13799 2004-06-10 Miguel de Icaza <miguel@ximian.com>
13801 * cs-tokenizer.cs: Change the way we track __arglist to be
13802 consistent with the other keywords.
13804 2004-06-09 Miguel de Icaza <miguel@ximian.com>
13806 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
13809 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
13811 * codegen.cs: Check that all referenced assemblies have a strongname
13812 before strongnaming the compiled assembly. If not report error CS1577.
13813 Fix bug #56563. Patch by Jackson Harper.
13814 * typemanager.cs: Added a method to return all referenced assemblies.
13815 Fix bug #56563. Patch by Jackson Harper.
13817 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13820 (Method.ApplyAttributeBuilder): Moved and added conditional
13821 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
13824 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
13826 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13829 * class.cs: (EventField.attribute_targets): Changed default target.
13831 2004-06-08 Martin Baulig <martin@ximian.com>
13833 * expression.cs (Invocation.EmitCall): Enable varargs methods.
13835 2004-06-08 Martin Baulig <martin@ximian.com>
13837 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
13839 2004-06-07 Martin Baulig <martin@ximian.com>
13841 Added support for varargs methods.
13843 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
13846 * cs-parser.jay: Added support for `__arglist'.
13848 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
13850 * expression.cs (Argument.AType): Added `ArgList'.
13851 (Invocation): Added support for varargs methods.
13852 (ArglistAccess): New public class.
13853 (Arglist): New public class.
13855 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
13857 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
13858 a method's top-level block if the method has varargs.
13860 * support.cs (ReflectionParameters, InternalParameters): Added
13861 support for varargs methods.
13863 2004-06-07 Miguel de Icaza <miguel@ximian.com>
13865 * class.cs: Provide location in indexer error report.
13867 * driver.cs: Use standard names.
13869 * namespace.cs: Catch the use of using after a namespace has been
13870 declared also on using aliases.
13872 2004-06-03 Raja R Harinath <rharinath@novell.com>
13875 * typemanager.cs (closure_private_ok, closure_invocation_type)
13876 (closure_qualifier_type, closure_invocation_assembly)
13877 (FilterWithClosure): Move to ...
13878 (Closure): New internal nested class.
13879 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
13880 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
13881 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
13882 (MemberLookup, MemberLookupFailed): Use it.
13883 * expression.cs (New.DoResolve): Treat the lookup for the
13884 constructor as being qualified by the 'new'ed type.
13885 (Indexers.GetIndexersForTypeOrInterface): Update.
13887 2004-06-03 Marek Safar <marek.safar@seznam.cz>
13890 (GetConditionalAttributeValue): New method. Returns
13891 condition of ConditionalAttribute.
13892 (SearchMulti): New method. Returns all attributes of type 't'.
13893 Use it when attribute is AllowMultiple = true.
13894 (IsConditionalMethodExcluded): New method.
13897 (Method.IsExcluded): Implemented. Returns true if method has conditional
13898 attribute and the conditions is not defined (method is excluded).
13899 (IMethodData): Extended interface for ConditionalAttribute support.
13900 (PropertyMethod.IsExcluded): Implemented.
13903 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
13906 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
13909 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
13911 * expression.cs (ArrayCreationExpression): Make this just an
13912 `expression'. It can't be a statement, so the code here was
13915 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13918 * typemanager.cs (GetFullNameSignature): New method for
13921 2004-06-02 Marek Safar <marek.safar@seznam.cz>
13924 * class.cs (MemberBase.GetSignatureForError): New virtual method.
13925 Use this method when MethodBuilder is null.
13926 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
13927 Added test for error CS0626 (MONO reports error for this situation).
13928 (IMethodData.GetSignatureForError): Extended interface.
13930 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13933 (AttributeTester.GetObsoleteAttribute): Returns instance of
13934 ObsoleteAttribute when type is obsolete.
13937 (TypeContainer.VerifyObsoleteAttribute): Override.
13938 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
13939 (MethodCode.VerifyObsoleteAttribute): Override.
13940 (MemberBase.VerifyObsoleteAttribute): Override.
13943 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
13944 and report proper error.
13947 Delegate.VerifyObsoleteAttribute): Override.
13950 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
13951 and report proper error.
13952 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
13955 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
13959 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
13960 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
13961 Added test for ObsoleteAttribute.
13964 (Catch): Derived from Statement.
13966 2004-06-01 Marek Safar <marek.safar@seznam.cz>
13968 Fixed bug #59071 & cs0160.cs
13970 * statement.cs (Try.Resolve): Check here whether order of catch
13971 clauses matches their dependencies.
13973 2004-05-31 Miguel de Icaza <miguel@ximian.com>
13975 * Reverted patch to namespace.cs (Use lookuptypedirect). This
13976 caused a regression: #59343. Referencing nested classes from an
13977 assembly stopped working.
13979 2004-05-31 Martin Baulig <martin@ximian.com>
13981 MCS is now frozen for beta 2.
13983 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13985 * convert.cs: add a trivial cache for overload operator resolution.
13987 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
13989 * decl.cs: If possible, use lookuptypedirect here. We can only do
13990 this if there is no `.' after the namespace. Avoids using
13991 LookupType, which does lots of slow processing.
13992 (FindNestedType) New method, does what it says :-).
13993 * namespace.cs: use LookupTypeDirect.
13994 * rootcontext.cs: use membercache, if possible.
13995 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
13997 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14000 According to the spec,
14002 In a member access of the form E.I, if E is a single identifier,
14003 and if the meaning of E as a simple-name (§7.5.2) is a constant,
14004 field, property, localvariable, or parameter with the same type as
14005 the meaning of E as a type-name (§3.8), then both possible
14006 meanings of E are permitted.
14008 We did not check that E as a simple-name had the same type as E as
14011 This trivial check gives us 5-7% on bootstrap time.
14013 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14015 * expression.cs (Invocation.OverloadResolve): Avoid the
14016 use of hashtables and boxing here by allocating on demand.
14018 2004-05-30 Martin Baulig <martin@ximian.com>
14020 * rootcontext.cs (RootContext.LookupType): Don't cache things if
14021 we're doing a silent lookup. Don't try to lookup nested types in
14022 TypeManager.object_type (thanks to Ben Maurer).
14024 2004-05-30 Martin Baulig <martin@ximian.com>
14026 Committing a patch from Ben Maurer.
14028 * rootcontext.cs (RootContext.LookupType): Cache negative results.
14030 2004-05-29 Martin Baulig <martin@ximian.com>
14032 * class.cs (IMethodData.ShouldIgnore): New method.
14034 * typemanager.cs (TypeManager.MethodFlags): Don't take a
14035 `Location' argument, we don't need it anywhere. Use
14036 `IMethodData.ShouldIgnore ()' instead of
14037 `MethodData.GetMethodFlags ()'.
14038 (TypeManager.AddMethod): Removed.
14039 (TypeManager.AddMethod2): Renamed to AddMethod.
14041 2004-05-29 Martin Baulig <martin@ximian.com>
14043 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
14045 * convert.cs (Convert.ImplicitReferenceConversion): If we're
14046 converting from a class type S to an interface type and we already
14047 have an object on the stack, don't box it again. Fixes #52578.
14049 2004-05-29 Martin Baulig <martin@ximian.com>
14051 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
14052 Added support for `params' parameters. Fixes #59267.
14054 2004-05-29 Martin Baulig <martin@ximian.com>
14056 * literal.cs (NullPointer): Provide a private .ctor which sets
14057 `type' to TypeManager.object_type. Fixes #59048.
14059 2004-05-29 Martin Baulig <martin@ximian.com>
14061 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
14062 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
14064 * ecore.cs (EventExpr.instance_expr): Make the field private.
14066 2004-05-26 Marek Safar <marek.safar@seznam.cz>
14068 Fixed bug #50080 & cs0214-2.cs
14069 * expression.cs (Cast.DoResolve): Check unsafe context here.
14071 * statement.cs (Resolve.DoResolve): Likewise.
14073 2004-05-26 Martin Baulig <martin@ximian.com>
14075 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
14077 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
14078 (RootContext.LookupType): Pass down the `silent' flag.
14080 2004-05-25 Martin Baulig <martin@ximian.com>
14083 (MethodGroupExpr.IdenticalTypeName): New public property.
14084 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
14085 expression actually refers to a type.
14087 2004-05-25 Martin Baulig <martin@ximian.com>
14089 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
14090 for #56176 and made it actually work.
14092 2004-05-25 Martin Baulig <martin@ximian.com>
14094 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
14095 (FieldExpr, PropertyExpr): Override and implement
14096 CacheTemporaries. Fixes #52279.
14098 2004-05-25 Miguel de Icaza <miguel@ximian.com>
14100 * location.cs: In the new compiler listing a file twice is a
14101 warning, not an error.
14103 2004-05-24 Martin Baulig <martin@ximian.com>
14105 * enum.cs (Enum.DefineType): For the `BaseType' to be a
14106 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
14108 2004-05-24 Martin Baulig <martin@ximian.com>
14110 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
14111 walking the `using' list. Fixes #53921.
14113 2004-05-24 Martin Baulig <martin@ximian.com>
14115 * const.cs (Const.LookupConstantValue): Added support for
14116 EmptyCast's; fixes #55251.
14118 2004-05-24 Martin Baulig <martin@ximian.com>
14120 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
14121 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
14122 which does the CS0135 check. The reason is that we first need to
14123 check whether the variable actually exists.
14125 2004-05-24 Martin Baulig <martin@ximian.com>
14127 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
14128 than RootContext.LookupType() to find the explicit interface
14129 type. Fixes #58584.
14131 2004-05-24 Raja R Harinath <rharinath@novell.com>
14133 * Makefile: Simplify. Use executable.make.
14134 * mcs.exe.sources: New file. List of sources of mcs.exe.
14136 2004-05-24 Anders Carlsson <andersca@gnome.org>
14140 Use the invariant culture when doing String.Compare for CLS case
14143 2004-05-23 Martin Baulig <martin@ximian.com>
14145 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
14146 don't have any dots. Fixes #52622, added cs0246-8.cs.
14148 * namespace.cs (NamespaceEntry.Lookup): Likewise.
14150 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14152 * class.cs (MemberBase.Define): Reuse MemberType member for
14153 resolved type. Other methods can use it too.
14155 2004-05-23 Martin Baulig <martin@ximian.com>
14157 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
14158 the variable also exists in the current block (otherwise, we need
14159 to report a CS0103). Fixes #58670.
14161 2004-05-23 Martin Baulig <martin@ximian.com>
14163 * flowanalysis.cs (Reachability.Reachable): Compute this
14164 on-the-fly rather than storing it as a field.
14166 2004-05-23 Martin Baulig <martin@ximian.com>
14168 * flowanalysis.cs (Reachability.And): Manually compute the
14169 resulting `barrier' from the reachability.
14171 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14174 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
14175 instance of ObsoleteAttribute when symbol is obsolete.
14178 (IMethodData): Extended interface for ObsoleteAttribute support.
14180 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14182 * attribute.cs: Fix bug #55970
14184 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14188 (GetObsoleteAttribute): New method. Creates the instance of
14190 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
14191 ObsoleteAttribute when member is obsolete.
14192 (AttributeTester.Report_ObsoleteMessage): Common method for
14193 Obsolete error/warning reporting.
14196 (TypeContainer.base_classs_type): New member for storing parent type.
14199 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
14200 for this MemberCore.
14202 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14204 * attribute.cs, const.cs: Fix bug #58590
14206 2004-05-21 Martin Baulig <martin@ximian.com>
14208 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
14209 out parameters if the end of the method is unreachable. Fixes
14212 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14214 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
14215 Hari was right, why extra method.
14217 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14219 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
14221 2004-05-20 Martin Baulig <martin@ximian.com>
14223 Merged this back from gmcs to keep the differences to a minumum.
14225 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
14226 instead of a Declspace.
14227 (Attribute.ResolveType): Likewise.
14228 (Attributes.Search): Likewise.
14229 (Attributes.Contains): Likewise.
14230 (Attributes.GetClsCompliantAttribute): Likewise.
14232 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
14234 (MethodData.ApplyAttributes): Take an EmitContext instead of a
14237 2004-05-19 Marek Safar <marek.safar@seznam.cz>
14239 Fix bug #58688 (MCS does not report error when the same attribute
14242 * attribute.cs (Attribute.Emit): Distinction between null and default.
14244 2004-05-19 Raja R Harinath <rharinath@novell.com>
14246 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
14247 of a top-level attribute without an attribute target.
14248 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
14250 (Attribute.Conditional_GetConditionName),
14251 (Attribute.Obsolete_GetObsoleteMessage): Update.
14252 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
14253 part of ScanForIndexerName.
14254 (Attribute.CanIgnoreInvalidAttribute): New function.
14255 (Attribute.ScanForIndexerName): Move to ...
14256 (Attributes.ScanForIndexerName): ... here.
14257 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
14258 (Attributes.Search): New internal variant that can choose not to
14259 complain if types aren't resolved. The original signature now
14261 (Attributes.GetClsCompliantAttribute): Use internal variant, with
14262 complaints suppressed.
14263 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
14264 only if it not useful.
14265 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
14266 top-level for attributes that are shared between the assembly
14267 and a top-level class.
14268 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
14269 * class.cs: Update to reflect changes.
14270 (DefineIndexers): Fuse loops.
14271 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
14272 a couple more variants of attribute names.
14274 2004-05-18 Marek Safar <marek.safar@seznam.cz>
14276 Fix bug #52585 (Implemented explicit attribute declaration)
14279 (Attributable.ValidAttributeTargets): New abstract method. It gets
14280 list of valid attribute targets for explicit target declaration.
14281 (Attribute.Target): It holds target itself.
14282 (AttributeSection): Removed.
14283 (Attribute.CheckTargets): New method. It checks whether attribute
14284 target is valid for the current element.
14287 (EventProperty): New class. For events that are declared like
14288 property (with add and remove accessors).
14289 (EventField): New class. For events that are declared like field.
14292 * cs-parser.jay: Implemented explicit attribute target declaration.
14294 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
14295 Override ValidAttributeTargets.
14298 (ReturnParameter): Class for applying custom attributes on
14300 (ParameterAtribute): New class. Class for applying custom
14301 attributes on the parameter type.
14303 2004-05-17 Miguel de Icaza <miguel@ximian.com>
14305 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
14308 (Method): Allow UNSAFE here.
14310 * modifiers.cs: Support unsafe reporting.
14312 2004-05-17 Marek Safar <marek.safar@seznam.cz>
14314 * decl.cs: Fix bug #58478.
14316 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14318 * statement.cs: When checking for unreachable code on an EmptyStatement,
14319 set the location. Fixes bug #58488.
14321 2004-05-13 Miguel de Icaza <miguel@ximian.com>
14323 * driver.cs: Add -pkg handling.
14325 From Gonzalo: UseShelLExecute=false
14327 2004-05-12 Marek Safar <marek.safar@seznam.cz>
14330 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
14332 (Attribute.IsClsCompliaceRequired): Moved to base for better
14334 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
14335 when attribute is AttributeUsageAttribute.
14336 (Attribute.GetValidTargets): Simplified.
14337 (Attribute.GetAttributeUsage): New method returns AttributeUsage
14338 attribute for this type.
14339 (Attribute.ApplyAttributes): Method renamed to Emit and make
14341 (GlobalAttributeSection): New class for special handling of global
14342 attributes (assembly, module).
14343 (AttributeSection.Emit): New method.
14345 * class.cs: Implemented Attributable abstract methods.
14346 (MethodCore.LabelParameters): Moved to Parameter class.
14347 (Accessor): Is back simple class.
14348 (PropertyMethod): Implemented Attributable abstract class.
14349 (DelegateMethod): Implemented Attributable abstract class.
14350 (Event): New constructor for disctintion between normal Event
14351 and Event with accessors.
14353 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
14355 * codegen.cs, const.cs, decl.cs, delegate.cs:
14356 (CommonAssemblyModulClass): Implemented Attributable abstract class
14359 * enum.cs: Implement IAttributeSupport interface.
14360 (EnumMember): New class for emum members. Implemented Attributable
14364 (ParameterBase): Is abstract.
14365 (ReturnParameter): New class for easier [return:] attribute handling.
14367 * typemanager.cs: Removed builder_to_attr.
14369 2004-05-11 Raja R Harinath <rharinath@novell.com>
14372 * attribute.cs (Attribute.GetPositionalValue): New function.
14373 * class.cs (TypeContainer.VerifyMembers): New function.
14374 (TypeContainer.Emit): Use it.
14375 (ClassOrStruct): New base class for Class and Struct.
14376 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
14377 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
14379 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
14380 then each non-static field should have a FieldOffset attribute.
14381 Otherwise, none of the fields should have a FieldOffset attribute.
14382 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
14383 and FieldOffset attributes.
14384 * typemanager.cs (TypeManager.struct_layout_attribute_type)
14385 (TypeManager.field_offset_attribute_type): New core types.
14386 (TypeManager.InitCoreTypes): Initialize them.
14388 2004-05-11 Michal Moskal <malekith@pld-linux.org>
14390 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
14391 Return correct type.
14394 2004-05-09 Miguel de Icaza <miguel@ximian.com>
14396 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
14397 be implicitly converted to ulong.
14399 * expression.cs: The logic for allowing operator &, | and ^ worked
14400 was wrong, it worked before because we did not report an error in
14401 an else branch. Fixes 57895.
14403 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
14404 allow volatile fields to be reference types.
14406 2004-05-07 Miguel de Icaza <miguel@ximian.com>
14408 * driver.cs: Add support for /debug-
14410 2004-05-07 Raja R Harinath <rharinath@novell.com>
14412 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
14413 Add a 'complain' parameter to silence errors.
14414 (Attribute.Resolve): Update to changes. Put in sanity check to catch
14415 silently overlooked type-resolutions.
14416 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
14417 to reflect changes.
14418 (Attributes.Search): New function.
14419 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
14420 (Attributes.GetAttributeFullName): Remove hack.
14421 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
14422 Update to reflect changes.
14423 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14424 Use Attributes.Search instead of nested loops.
14426 2004-05-07 Marek Safar <marek.safar@seznam.cz>
14429 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
14430 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
14431 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
14433 * report.cs: (Report.Warning): Renamed to Warning_T because of
14434 parameter collision.
14436 2004-05-05 Raja R Harinath <rharinath@novell.com>
14438 * expression.cs (MemberAccess.ResolveMemberAccess):
14439 Exit with non-zero status after Report.Error.
14440 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
14442 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
14444 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14446 * support.cs: Don't hang when the file is empty.
14448 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14450 * support.cs: In SeekableStreamReader, compute the preamble size of the
14451 underlying stream. Position changes should take into account that initial
14454 2004-05-03 Todd Berman <tberman@sevenl.net>
14456 * driver.cs: remove unused GetSysVersion function.
14458 2004-05-03 Todd Berman <tberman@sevenl.net>
14460 * driver.cs: Remove the hack from saturday, as well as the hack
14461 from jackson (LoadAssemblyFromGac), also adds the CWD to the
14462 link_paths to get that bit proper.
14464 2004-05-01 Todd Berman <tberman@sevenl.net>
14466 * driver.cs: Try a LoadFrom before a Load, this checks the current
14467 path. This is currently a bug in mono that is be fixed, however, this
14468 provides a workaround for now. This will be removed when the bug
14471 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
14473 * CryptoConvert.cs: Updated to latest version. Fix issue with
14474 incomplete key pairs (#57941).
14476 2004-05-01 Todd Berman <tberman@sevenl.net>
14478 * driver.cs: Remove '.' from path_chars, now System.* loads properly
14481 2004-04-30 Jackson Harper <jackson@ximian.com>
14483 * codegen.cs: Open keys readonly.
14485 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14487 * typemanager.cs: don't report cyclic struct layout when a struct
14488 contains 2 or more fields of the same type. Failed for Pango.AttrShape
14489 which has 2 Pango.Rectangle fields.
14491 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
14493 * expression.cs: Handle IntPtr comparisons with IL code
14494 rather than a method call.
14496 2004-04-29 Martin Baulig <martin@ximian.com>
14498 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
14499 the list of PropertyInfo's in class hierarchy and find the
14500 accessor. Fixes #56013.
14502 2004-04-29 Martin Baulig <martin@ximian.com>
14504 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
14506 2004-04-29 Martin Baulig <martin@ximian.com>
14508 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14510 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
14512 2004-04-29 Martin Baulig <martin@ximian.com>
14514 * class.cs (ConstructorInitializer.Resolve): Check whether the
14515 parent .ctor is accessible. Fixes #52146.
14517 2004-04-29 Martin Baulig <martin@ximian.com>
14519 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14521 * statement.cs (Using.EmitLocalVariableDecls): Use
14522 TypeManager.idisposable_type, not typeof (IDisposable).
14523 (Foreach.EmitCollectionForeach): Added support for valuetypes.
14525 2004-04-29 Martin Baulig <martin@ximian.com>
14527 * class.cs (Event.Define): Don't emit the field and don't set
14528 RTSpecialName and SpecialName for events on interfaces. Fixes
14531 2004-04-29 Raja R Harinath <rharinath@novell.com>
14533 Refactor Attribute.ApplyAttributes.
14534 * attribute.cs (Attributable): New base class for objects that can
14535 have Attributes applied on them.
14536 (Attribute): Make AttributeUsage fields public.
14537 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
14538 (Attribute.IsInternalCall): New property.
14539 (Attribute.UsageAttr): Convert to a public read-only property.
14540 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
14541 (Attribute.ResolveType, Attribute.Resolve)
14542 (Attribute.ScanForIndexerName): Update to reflect changes.
14543 (Attribute.CheckAttributeTarget): Re-format.
14544 (Attribute.ApplyAttributes): Refactor, to various
14545 Attributable.ApplyAttributeBuilder methods.
14546 * decl.cs (MemberCore): Make Attributable.
14547 * class.cs (Accessor): Make Attributable.
14548 (MethodData.ApplyAttributes): Use proper attribute types, not
14550 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
14551 (TypeContainer.ApplyAttributeBuilder)
14552 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
14553 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
14554 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
14555 (Operator.ApplyAttributeBuilder): New factored-out methods.
14556 * const.cs (Const.ApplyAttributeBuilder): Likewise.
14557 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
14558 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
14559 * parameter.cs (ParameterBase): New Attributable base class
14560 that can also represent Return types.
14561 (Parameter): Update to the changes.
14563 2004-04-29 Jackson Harper <jackson@ximian.com>
14565 * driver.cs: Prefer the corlib system version when looking for
14566 assemblies in the GAC. This is still a hack, but its a better hack
14569 2004-04-29 Marek Safar <marek.safar@seznam.cz>
14571 * decl.cs, enum.cs: Improved error 3005 reporting.
14573 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
14574 (related_symbols): New private member for list of symbols
14575 related to reported error/warning.
14577 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
14579 2004-04-29 Martin Baulig <martin@ximian.com>
14581 * ecore.cs (Expression.Constantify): If we're an enum and
14582 TypeManager.TypeToCoreType() doesn't give us another type, use
14583 t.UnderlyingSystemType. Fixes #56178.
14585 2004-04-29 Martin Baulig <martin@ximian.com>
14587 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
14588 interfaces and for each interface, only add members directly
14589 declared in that interface. Fixes #53255.
14591 2004-04-28 Martin Baulig <martin@ximian.com>
14593 * expression.cs (ConditionalLogicalOperator): Use a temporary
14594 variable for `left' to avoid that we evaluate it more than once;
14597 2004-04-28 Martin Baulig <martin@ximian.com>
14599 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
14602 2004-04-28 Martin Baulig <martin@ximian.com>
14604 * statement.cs (LocalInfo.Resolve): Check whether the type is not
14607 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
14608 whether the type is not void (CS1547).
14610 2004-04-28 Martin Baulig <martin@ximian.com>
14612 * expression.cs (Unary.DoResolveLValue): Override this and report
14613 CS0131 for anything but Operator.Indirection.
14615 2004-04-28 Martin Baulig <martin@ximian.com>
14617 Committing a patch from Ben Maurer; see bug #50820.
14619 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14622 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14625 2004-04-28 Martin Baulig <martin@ximian.com>
14627 Committing a patch from Ben Maurer; see bug #50820.
14629 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14632 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14635 2004-04-28 Martin Baulig <martin@ximian.com>
14637 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
14638 (Block.AddLabel): Call DoLookupLabel() to only search in the
14641 2004-04-28 Martin Baulig <martin@ximian.com>
14643 * cfold.cs (ConstantFold.BinaryFold): Added special support for
14644 comparing StringConstants and NullLiterals in Equality and Inequality.
14646 2004-04-28 Jackson Harper <jackson@ximian.com>
14648 * driver.cs: Attempt to load referenced assemblies from the
14649 GAC. This is the quick and dirty version of this method that
14650 doesnt take into account versions and just takes the first
14651 canidate found. Will be good enough for now as we will not have more
14652 then one version installed into the GAC until I update this method.
14654 2004-04-28 Martin Baulig <martin@ximian.com>
14656 * typemanager.cs (TypeManager.CheckStructCycles): New public
14657 static method to check for cycles in the struct layout.
14659 * rootcontext.cs (RootContext.PopulateTypes): Call
14660 TypeManager.CheckStructCycles() for each TypeContainer.
14661 [Note: We only need to visit each type once.]
14663 2004-04-28 Martin Baulig <martin@ximian.com>
14665 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
14667 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
14668 success and added `out object value'. Use a `bool resolved' field
14669 to check whether we've already been called rather than
14670 `ConstantValue != null' since this breaks for NullLiterals.
14672 2004-04-28 Raja R Harinath <rharinath@novell.com>
14674 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
14675 setting of this flag, since the 'set' method may be non-public.
14677 2004-04-28 Raja R Harinath <rharinath@novell.com>
14679 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
14680 check on current_vector.Block.
14682 2004-04-27 Martin Baulig <martin@ximian.com>
14684 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
14685 a field initializer. Fixes #56459.
14687 2004-04-27 Martin Baulig <martin@ximian.com>
14689 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
14690 we're not attempting to use an indexer. Fixes #52154.
14692 2004-04-27 Martin Baulig <martin@ximian.com>
14694 * statement.cs (Return): Don't create a return label if we don't
14695 need it; reverts my change from January 20th. Thanks to Ben
14698 2004-04-27 Martin Baulig <martin@ximian.com>
14700 According to the spec, `goto' can only leave a nested scope, but
14703 * statement.cs (Block.LookupLabel): Only lookup in the current
14704 block, don't recurse into parent or child blocks.
14705 (Block.AddLabel): Check in parent and child blocks, report
14706 CS0140/CS0158 if we find a duplicate.
14707 (Block): Removed this indexer for label lookups.
14708 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
14709 this already does the error reporting for us.
14712 (FlowBranching.UsageVector.Block): New public variable; may be null.
14713 (FlowBranching.CreateSibling): Added `Block' argument.
14714 (FlowBranching.LookupLabel): New public virtual method. Lookup a
14715 label for the target of a `goto' and check whether we're not
14716 leaving a `finally'.
14718 2004-04-27 Martin Baulig <martin@ximian.com>
14720 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14721 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
14724 2004-04-27 Martin Baulig <martin@ximian.com>
14726 * statement.cs (Block.AddLabel): Also check for implicit blocks
14727 and added a CS0158 check.
14729 2004-04-27 Martin Baulig <martin@ximian.com>
14731 * flowanalysis.cs (FlowBranchingLoop): New class.
14732 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
14733 UsageVector's instead of an ArrayList.
14734 (FlowBranching.Label): Likewise.
14735 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
14736 (FlowBranching.AddBreakVector): New method.
14738 2004-04-27 Miguel de Icaza <miguel@ximian.com>
14740 * attribute.cs: Small regression fix: only convert the type if we
14741 the type is different, fixes System.Drawing build.
14743 2004-04-27 Martin Baulig <martin@ximian.com>
14745 * attribute.cs (Attribute.Resolve): If we have a constant value
14746 for a named field or property, implicity convert it to the correct
14749 2004-04-27 Raja R Harinath <rharinath@novell.com>
14751 * statement.cs (Block.Block): Implicit blocks share
14752 'child_variable_names' fields with parent blocks.
14753 (Block.AddChildVariableNames): Remove.
14754 (Block.AddVariable): Mark variable as "used by a child block" in
14755 every surrounding block.
14756 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
14757 been used in a child block, complain about violation of "Invariant
14758 meaning in blocks" rule.
14759 * cs-parser.jay (declare_local_variables): Don't use
14760 AddChildVariableNames.
14761 (foreach_statement): Don't create an implicit block: 'foreach'
14762 introduces a scope.
14764 2004-04-23 Miguel de Icaza <miguel@ximian.com>
14766 * convert.cs (ImplicitNumericConversion): 0 is also positive when
14767 converting from 0L to ulong. Fixes 57522.
14769 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14771 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
14772 derived class hides via 'new' keyword field from base class (test-242.cs).
14773 TODO: Handle this in the more general way.
14775 * class.cs (CheckBase): Ditto.
14777 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14779 * decl.cs (caching_flags): New member for storing cached values
14781 (MemberCore.Flags): New enum where bit flags for caching_flags
14783 (MemberCore.cls_compliance): Moved to caching_flags.
14784 (DeclSpace.Created): Moved to caching_flags.
14786 * class.cs: Use caching_flags instead of DeclSpace.Created
14788 2004-04-21 Miguel de Icaza <miguel@ximian.com>
14790 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
14791 if we are only a derived class, not a nested class.
14793 * typemanager.cs: Same as above, but do this at the MemberLookup
14794 level (used by field and methods, properties are handled in
14795 PropertyExpr). Allow for the qualified access if we are a nested
14798 2004-04-21 Marek Safar <marek.safar@seznam.cz>
14800 * class.cs: Refactoring.
14801 (IMethodData): New inteface; Holds links to parent members
14802 to avoid member duplication (reduced memory allocation).
14803 (Method): Implemented IMethodData interface.
14804 (PropertyBase): New inner classes for get/set methods.
14805 (PropertyBase.PropertyMethod): Implemented IMethodData interface
14806 (Event): New inner classes for add/remove methods.
14807 (Event.DelegateMethod): Implemented IMethodData interface.
14809 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
14810 EmitContext (related to class.cs refactoring).
14812 2004-04-21 Raja R Harinath <rharinath@novell.com>
14814 * delegate.cs (Delegate.VerifyApplicability): If the number of
14815 arguments are the same as the number of parameters, first try to
14816 verify applicability ignoring any 'params' modifier on the last
14820 2004-04-16 Raja R Harinath <rharinath@novell.com>
14822 * class.cs (TypeContainer.AddIndexer): Use
14823 'ExplicitInterfaceName' to determine if interface name was
14824 explicitly specified. 'InterfaceType' is not initialized at this time.
14825 (TypeContainer.DefineIndexers): Remove use of temporary list. The
14826 Indexers array is already in the required order. Initialize
14827 'IndexerName' only if there are normal indexers.
14828 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
14829 (TypeContainer.Emit): Emit DefaultMember attribute only if
14830 IndexerName is initialized.
14833 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
14835 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
14838 2004-04-15 Raja R Harinath <rharinath@novell.com>
14840 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
14844 * attribute.cs (Attribute.Resolve): Check for duplicate named
14848 2004-04-15 Miguel de Icaza <miguel@ximian.com>
14850 * iterators.cs (MarkYield): track whether we are in an exception,
14851 and generate code accordingly. Use a temporary value to store the
14852 result for our state.
14854 I had ignored a bit the interaction of try/catch with iterators
14855 since their behavior was not entirely obvious, but now it is
14856 possible to verify that our behavior is the same as MS .NET 2.0
14860 2004-04-14 Miguel de Icaza <miguel@ximian.com>
14862 * iterators.cs: Avoid creating temporaries if there is no work to
14865 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
14866 Enumerations, use TypeManager.EnumToUnderlying and call
14869 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
14872 (This.Emit): Use EmitContext.EmitThis to emit our
14875 (This.EmitAssign): Ditto.
14877 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
14878 codepaths, we will move all the functionality into
14881 (FieldExpr.EmitAssign): Ditto.
14883 This fixes several hidden bugs that I uncovered while doing a code
14884 review of this today.
14886 * codegen.cs (EmitThis): reworked so the semantics are more clear
14887 and also support value types "this" instances.
14889 * iterators.cs: Changed so that for iterators in value types, we
14890 do not pass the value type as a parameter.
14892 Initialization of the enumerator helpers is now done in the caller
14893 instead of passing the parameters to the constructors and having
14894 the constructor set the fields.
14896 The fields have now `assembly' visibility instead of private.
14898 2004-04-11 Miguel de Icaza <miguel@ximian.com>
14900 * expression.cs (Argument.Resolve): Check if fields passed as ref
14901 or out are contained in a MarshalByRefObject.
14903 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
14904 another compiler type.
14906 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
14908 * class.cs (Indexer.Define): use the new name checking method.
14909 Also, return false on an error.
14910 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
14911 (is_identifier_[start/part]_character): make static.
14913 2004-04-10 Miguel de Icaza <miguel@ximian.com>
14915 * expression.cs (Binary.ResolveOperator): Do no append strings
14916 twice: since we can be invoked more than once (array evaluation)
14917 on the same concatenation, take care of this here. Based on a fix
14918 from Ben (bug #56454)
14920 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
14922 * codegen.cs: Fix another case where CS1548 must be reported (when
14923 delay-sign isn't specified and no private is available #56564). Fix
14924 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
14925 error when MCS is used on the MS runtime and we need to delay-sign
14926 (which seems unsupported by AssemblyBuilder - see #56621).
14928 2004-04-08 Marek Safar <marek.safar@seznam.cz>
14930 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
14931 (TypeManager.ComputeNamespaces): Faster implementation for
14934 * compiler.csproj: Updated AssemblyName to mcs.
14936 2004-04-07 Miguel de Icaza <miguel@ximian.com>
14938 * rootcontext.cs: Add new types to the boot resolution.
14940 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
14941 MulticastDelegate is not allowed.
14943 * typemanager.cs: Add new types to lookup: System.TypedReference
14946 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
14947 check for TypedReference or ArgIterator, they are not allowed.
14949 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
14950 makes us properly catch 1510 in some conditions (see bug 56016 for
14953 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
14955 * CryptoConvert.cs: update from corlib version
14958 2004-04-05 Miguel de Icaza <miguel@ximian.com>
14960 * class.cs (Indexer.Define): Check indexername declaration
14962 2004-04-05 Marek Safar <marek.safar@seznam.cz>
14964 * attribute.cs (IsClsCompliant): Fixed problem with handling
14965 all three states (compliant, not-compliant, undetected).
14967 2004-03-30 Marek Safar <marek.safar@seznam.cz>
14969 * attribute.cs (Attribute): Location is now public.
14970 (Resolve): Store resolved arguments (pos_values) in attribute class.
14971 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
14972 (GetClsCompliantAttributeValue): New method that gets
14973 CLSCompliantAttribute value.
14974 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
14975 if exists else null.
14976 (AttributeTester): New class for CLS-Compliant verification routines.
14978 * class.cs (Emit): Add CLS-Compliant verification.
14979 (Method.GetSignatureForError): Implemented.
14980 (Constructor.GetSignatureForError): Implemented
14981 (Constructor.HasCompliantArgs): Returns if constructor has
14982 CLS-Compliant arguments.
14983 (Constructor.Emit): Override.
14984 (Construcor.IsIdentifierClsCompliant): New method; For constructors
14985 is needed to test only parameters.
14986 (FieldBase.GetSignatureForError): Implemented.
14987 (TypeContainer): New member for storing base interfaces.
14988 (TypeContainer.FindMembers): Search in base interfaces too.
14990 * codegen.cs (GetClsComplianceAttribute): New method that gets
14991 assembly or module CLSCompliantAttribute value.
14992 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
14994 (ModuleClass.Emit): Add error 3012 test.
14996 * const.cs (Emit): Override and call base for CLS-Compliant tests.
14998 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
14999 state for all decl types.
15000 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
15001 if CLS-Compliant tests are required.
15002 (IsClsCompliaceRequired): New method. Analyze whether code
15003 must be CLS-Compliant.
15004 (IsExposedFromAssembly): New method. Returns true when MemberCore
15005 is exposed from assembly.
15006 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
15007 value or gets cached value.
15008 (HasClsCompliantAttribute): New method. Returns true if MemberCore
15009 is explicitly marked with CLSCompliantAttribute.
15010 (IsIdentifierClsCompliant): New abstract method. This method is
15011 used to testing error 3005.
15012 (IsIdentifierAndParamClsCompliant): New method. Common helper method
15013 for identifier and parameters CLS-Compliant testing.
15014 (VerifyClsCompliance): New method. The main virtual method for
15015 CLS-Compliant verifications.
15016 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
15017 null. I don't know why is null (too many public members !).
15018 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
15019 and get value of first CLSCompliantAttribute that found.
15021 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
15022 (VerifyClsCompliance): Override and add extra tests.
15024 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
15025 clscheck- disable CLS-Compliant verification event if assembly is has
15026 CLSCompliantAttribute(true).
15028 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
15029 ApllyAttribute is now called in emit section as in the other cases.
15030 Possible future Emit integration.
15031 (IsIdentifierClsCompliant): New override.
15032 (VerifyClsCompliance): New override.
15033 (GetEnumeratorName): Returns full enum name.
15035 * parameter.cs (GetSignatureForError): Implemented.
15037 * report.cs (WarningData): New struct for Warning message information.
15038 (LocationOfPreviousError): New method.
15039 (Warning): New method. Reports warning based on the warning table.
15040 (Error_T): New method. Reports error based on the error table.
15042 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
15043 verifications are done here.
15045 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
15047 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
15048 CLSCompliantAttribute.
15049 (all_imported_types): New member holds all imported types from other
15051 (LoadAllImportedTypes): New method fills static table with exported types
15052 from all referenced assemblies.
15053 (Modules): New property returns all assembly modules.
15055 2004-03-30 Miguel de Icaza <miguel@ximian.com>
15057 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
15058 throwing a parser error.
15060 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
15061 which removes the hardcoded get_/set_ prefixes for properties, as
15062 IL allows for the properties to be named something else.
15066 * expression.cs: Do not override operand before we know if it is
15067 non-null. Fix 56207
15069 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15071 * typemanager.cs: support for pinned variables.
15073 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15075 * decl.cs, typemanager.cs: Avoid using an arraylist
15076 as a buffer if there is only one result set.
15078 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15080 * expression.cs: Make sure you cant call a static method
15081 with an instance expression, bug #56174.
15083 2004-03-29 Miguel de Icaza <miguel@ximian.com>
15085 * class.cs (IsDuplicateImplementation): Improve error reporting to
15086 flag 663 (method only differs in parameter modifier).
15088 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
15089 in preprocessor directives.
15091 * location.cs (LookupFile): Allow for the empty path.
15093 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
15094 better approach for some of that patch, but its failing with the
15095 CharSet enumeration. For now try/catch will do.
15097 * typemanager.cs: Do not crash if a struct does not have fields.
15100 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15102 * expression.cs: cs0213, cant fix a fixed expression.
15105 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15107 * cs-parser.jay: detect invalid embeded statements gracefully.
15110 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15112 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
15115 the invocation type may not be a subclass of the tye of the item/
15116 The type of the item must be a subclass of the invocation item.
15121 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
15123 * attribute.cs: Added methods to get a string and a bool from an
15124 attribute. Required to information from AssemblyKeyFileAttribute,
15125 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
15126 * codegen.cs: Modified AssemblyName creation to include support for
15127 strongnames. Catch additional exceptions to report them as CS1548.
15128 * compiler.csproj: Updated include CryptoConvert.cs.
15129 * compiler.csproj.user: Removed file - user specific configuration.
15130 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
15131 Mono.Security assembly. The original class is maintained and tested in
15132 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
15133 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
15134 like CSC 8.0 (C# v2) supports.
15135 * Makefile: Added CryptoConvert.cs to mcs sources.
15136 * rootcontext.cs: Added new options for strongnames.
15138 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
15140 * driver.cs: For --expect-error, report error code `2'
15141 if the program compiled with no errors, error code `1' if
15142 it compiled with an error other than the one expected.
15144 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
15146 * compiler.csproj: Updated for Visual Studio .NET 2003.
15147 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
15148 * compiler.sln: Updated for Visual Studio .NET 2003.
15150 2004-03-24 Ravi Pratap M <ravi@ximian.com>
15152 * expression.cs: Fix bug #47234. We basically need to apply the
15153 rule that we prefer the conversion of null to a reference type
15154 when faced with a conversion to 'object' (csc behaviour).
15156 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15158 * statement.cs: Shorter form for foreach, eliminates
15159 a local variable. r=Martin.
15161 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15163 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
15164 checks if we can use brtrue/brfalse to test for 0.
15165 * expression.cs: use the above in the test for using brtrue/brfalse.
15166 cleanup code a bit.
15168 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15170 * expression.cs: Rewrite string concat stuff. Benefits:
15172 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
15173 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
15174 rather than a concat chain.
15176 * typemanager.cs: Add lookups for more concat overloads.
15178 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15180 * expression.cs: Emit shorter il code for array init.
15197 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
15199 * statement.cs: Before, two switch blocks would be merged if the
15200 total size of the blocks (end_item - begin_item + 1) was less than
15201 two times the combined sizes of the blocks.
15203 Now, it will only merge if after the merge at least half of the
15208 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
15210 * class.cs : csc build fix for GetMethods(). See bug #52503.
15212 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
15214 * expression.cs: Make sure fp comparisons work with NaN.
15215 This fixes bug #54303. Mig approved this patch a long
15216 time ago, but we were not able to test b/c the runtime
15219 2004-03-19 Miguel de Icaza <miguel@ximian.com>
15221 * ecore.cs (TypExpr.GetHashCode): implement this overload.
15223 2004-03-19 Martin Baulig <martin@ximian.com>
15225 * class.cs (MemberCore.IsDuplicateImplementation): Report the
15226 error here and not in our caller.
15228 2004-03-19 Martin Baulig <martin@ximian.com>
15230 * interface.cs: Completely killed this file.
15231 (Interface): We're now a TypeContainer and live in class.cs.
15233 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
15234 argument; we're now also called for interfaces.
15235 (TypeContainer.DefineMembers): Allow this method being called
15237 (TypeContainer.GetMethods): New public method; formerly known as
15238 Interface.GetMethod(). This is used by PendingImplementation.
15239 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
15240 it's now private and non-static.
15241 (Interface): Moved this here; it's now implemented similar to
15243 (Method, Property, Event, Indexer): Added `bool is_interface'
15244 argument to their .ctor's.
15245 (MemberBase.IsInterface): New public field.
15247 * cs-parser.jay: Create normal Method, Property, Event, Indexer
15248 instances instead of InterfaceMethod, InterfaceProperty, etc.
15249 (opt_interface_base): Removed; we now use `opt_class_base' instead.
15250 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
15252 2004-03-19 Martin Baulig <martin@ximian.com>
15254 * class.cs (MethodCore.IsDuplicateImplementation): New private
15255 method which does the CS0111 checking.
15256 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
15257 Use IsDuplicateImplementation().
15259 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
15261 * decl.cs (FindMemberToOverride): New method to find the correct
15262 method or property to override in the base class.
15264 - Make Method/Property use the above method to find the
15265 version in the base class.
15266 - Remove the InheritableMemberSignatureCompare as it is now
15269 This patch makes large code bases much faster to compile, as it is
15270 O(n) rather than O(n^2) to do this validation.
15272 Also, it fixes bug 52458 which is that nested classes are not
15273 taken into account when finding the base class member.
15275 Reviewed/Approved by Martin.
15277 2004-03-17 Marek Safar <marek.safar@seznam.cz>
15279 * interface.cs: In all interface classes removed redundant
15280 member initialization.
15282 2004-03-16 Martin Baulig <martin@ximian.com>
15284 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
15286 2004-03-15 Miguel de Icaza <miguel@ximian.com>
15288 * decl.cs (DefineTypeAndParents): New helper method to define a
15289 type's containers before the type itself is defined; This is a
15290 bug exposed by the recent changes to Windows.Forms when an
15291 implemented interface was defined inside a class that had not been
15294 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
15296 (Check): Loop correctly to report errors modifiers
15297 (UNSAFE was not in the loop, since it was the same as TOP).
15299 * interface.cs: Every interface member now takes a ModFlags,
15300 instead of a "is_new" bool, which we set on the base MemberCore.
15302 Every place where we called "UnsafeOk" in the interface, now we
15303 call the proper member (InterfaceMethod.UnsafeOK) instead to get
15304 the unsafe settings from the member declaration instead of the
15305 container interface.
15307 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
15309 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
15310 `set_indexer_name' to the pending bits (one per type).
15312 We fixed a bug today that was picking the wrong method to
15313 override, since for properties the existing InterfaceMethod code
15314 basically ignored the method name. Now we make sure that the
15315 method name is one of the valid indexer names.
15317 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
15319 * support.cs (SeekableStreamReader): Keep track of stream byte
15320 positions and don't mix them with character offsets to the buffer.
15322 Patch from Gustavo Giráldez
15324 2004-03-15 Marek Safar <marek.safar@seznam.cz>
15326 * interface.cs (InterfaceSetGetBase): Removed double member
15327 initialization, base class does it as well.
15329 2004-03-13 Martin Baulig <martin@ximian.com>
15331 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
15332 when compiling corlib.
15334 2004-03-13 Miguel de Icaza <miguel@ximian.com>
15336 * convert.cs (ExplicitConversion): We were reporting an error on
15337 certain conversions (object_type source to a value type, when the
15338 expression was `null') before we had a chance to pass it through
15339 the user defined conversions.
15341 * driver.cs: Replace / and \ in resource specifications to dots.
15344 * class.cs: Add check for duplicate operators. Fixes 52477
15346 2004-03-11 Miguel de Icaza <miguel@ximian.com>
15348 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
15349 that are in the middle of the statements, not only at the end.
15352 * class.cs (TypeContainer.AddField): No longer set the
15353 `HaveStaticConstructor' flag, now we call it
15354 `UserDefineStaticConstructor' to diferentiate the slightly
15355 semantic difference.
15357 The situation is that we were not adding BeforeFieldInit (from
15358 Modifiers.TypeAttr) to classes that could have it.
15359 BeforeFieldInit should be set to classes that have no static
15364 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
15366 And most importantly Zoltan's comment:
15368 http://bugzilla.ximian.com/show_bug.cgi?id=44229
15370 "I think beforefieldinit means 'it's ok to initialize the type sometime
15371 before its static fields are used', i.e. initialization does not need
15372 to be triggered by the first access to the type. Setting this flag
15373 helps the JIT to compile better code, since it can run the static
15374 constructor at JIT time, and does not need to generate code to call it
15375 (possibly lots of times) at runtime. Unfortunately, mcs does not set
15376 this flag for lots of classes like String.
15378 csc sets this flag if the type does not have an explicit static
15379 constructor. The reasoning seems to be that if there are only static
15380 initalizers for a type, and no static constructor, then the programmer
15381 does not care when this initialization happens, so beforefieldinit
15384 This bug prevents the AOT compiler from being usable, since it
15385 generates so many calls to mono_runtime_class_init that the AOT code
15386 is much slower than the JITted code. The JITted code is faster,
15387 because it does not generate these calls if the vtable is type is
15388 already initialized, which is true in the majority of cases. But the
15389 AOT compiler can't do this."
15391 2004-03-10 Miguel de Icaza <miguel@ximian.com>
15393 * class.cs (MethodData.Emit): Refactor the code so symbolic
15394 information is generated for destructors; For some reasons we
15395 were taking a code path that did not generate symbolic information
15398 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
15400 * class.cs: Create a Constructor.CheckBase method that
15401 takes care of all validation type code. The method
15402 contains some code that was moved from Define.
15404 It also includes new code that checks for duplicate ctors.
15405 This fixes bug #55148.
15407 2004-03-09 Joshua Tauberer <tauberer@for.net>
15409 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
15410 a { ... }-style array creation invokes EmitStaticInitializers
15411 which is not good for reference-type arrays. String, decimal
15412 and now null constants (NullCast) are not counted toward
15413 static initializers.
15415 2004-03-05 Martin Baulig <martin@ximian.com>
15417 * location.cs (SourceFile.HasLineDirective): New public field;
15418 specifies whether the file contains or is referenced by a "#line"
15420 (Location.DefineSymbolDocuments): Ignore source files which
15421 either contain or are referenced by a "#line" directive.
15423 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
15425 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
15426 direct access to our parent, so check the method inline there.
15428 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
15430 * expression.cs (Invocation.EmitCall): Miguel's last commit
15431 caused a regression. If you had:
15436 In Foo the implict this would be null.
15438 2004-02-27 Miguel de Icaza <miguel@ximian.com>
15440 * expression.cs (Invocation.EmitCall): If the method is not
15441 virtual, do not emit a CallVirt to it, use Call.
15443 * typemanager.cs (GetFullNameSignature): Improve the method to
15444 cope with ".ctor" and replace it with the type name.
15446 * class.cs (ConstructorInitializer.Resolve): Now the method takes
15447 as an argument the ConstructorBuilder where it is being defined,
15448 to catch the recursive constructor invocations.
15450 2004-02-26 Miguel de Icaza <miguel@ximian.com>
15452 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
15453 routines to check if a type is an enumerable/enumerator allow
15454 classes that implement the IEnumerable or IEnumerator interfaces.
15456 * class.cs (Property, Operator): Implement IIteratorContainer, and
15457 implement SetYields.
15459 (Property.Define): Do the block swapping for get_methods in the
15460 context of iterators. We need to check if Properties also
15461 include indexers or not.
15463 (Operator): Assign the Block before invoking the
15464 OperatorMethod.Define, so we can trigger the Iterator code
15467 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
15468 Property and Operator classes are not created when we parse the
15469 declarator but until we have the block completed, so we use a
15470 singleton SimpleIteratorContainer.Simple to flag whether the
15471 SetYields has been invoked.
15473 We propagate this setting then to the Property or the Operator to
15474 allow the `yield' to function.
15476 2004-02-25 Marek Safar <marek.safar@seznam.cz>
15478 * codegen.cs: Implemented attribute support for modules.
15479 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
15480 Assembly/Module functionality.
15482 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
15483 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
15484 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
15486 2004-02-16 Marek Safar <marek.safar@seznam.cz>
15488 * interface.cs (FindMembers): The operation is performed on all base
15489 interfaces and not only on the first. It is required for future CLS Compliance patch.
15491 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
15493 * statement.cs, codegen.cs:
15494 This patch deals with patterns such as:
15496 public class List : IEnumerable {
15498 public MyEnumerator GetEnumerator () {
15499 return new MyEnumerator(this);
15502 IEnumerator IEnumerable.GetEnumerator () {
15506 public struct MyEnumerator : IEnumerator {
15511 Before, there were a few things we did wrong:
15512 1) we would emit callvirt on a struct, which is illegal
15513 2) we emited ldarg when we needed to emit ldarga
15514 3) we would mistakenly call the interface methods on an enumerator
15515 type that derived from IEnumerator and was in another assembly. For example:
15517 public class MyEnumerator : IEnumerator
15519 Would have the interface methods called, even if there were public impls of the
15520 method. In a struct, this lead to invalid IL code.
15522 2004-02-11 Marek Safar <marek.safar@seznam.cz>
15524 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
15527 * delegate.cs (Define): Fixed crash when delegate type is undefined.
15529 2004-02-11 Miguel de Icaza <miguel@ximian.com>
15531 * cs-parser.jay: Fix small regression: we were not testing V2
15532 compiler features correctly.
15534 * interface.cs: If the emit context is null, then create one
15536 2004-02-09 Marek Safar <marek.safar@seznam.cz>
15538 * decl.cs (GetSignatureForError): New virtual method to get full name
15539 for error messages.
15541 * attribute.cs (IAttributeSupport): New interface for attribute setting.
15542 Now it is possible to rewrite ApplyAttributes method to be less if/else.
15544 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
15545 Duplicated members and code in these classes has been removed.
15546 Better encapsulation in these classes.
15548 2004-02-07 Miguel de Icaza <miguel@ximian.com>
15550 * assign.cs (Assign.DoResolve): When dealing with compound
15551 assignments, there is a new rule in ECMA C# 2.4 (might have been
15552 there before, but it is documented here) that states that in:
15556 If b is of type int, and the `op' is a shift-operator, then the
15557 above is evaluated as:
15561 * expression.cs (Binary.ResolveOperator): Instead of testing for
15562 int/uint/long/ulong, try to implicitly convert to any of those
15563 types and use that in pointer arithmetic.
15565 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
15566 method to print information for from the type, not from the
15567 null-method we were given.
15569 2004-02-01 Duncan Mak <duncan@ximian.com>
15571 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
15572 parsing for cmd, fixes bug #53694.
15574 2004-02-04 Marek Safar <marek.safar@seznam.cz>
15576 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
15577 in the member name duplication tests. Property and operator name duplication
15578 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
15580 2004-02-03 Marek Safar <marek.safar@seznam.cz>
15582 * interface.cs (PopulateMethod): Fixed crash when interface method
15583 returns not existing type (error test cs0246-3.cs).
15585 2004-02-02 Ravi Pratap M <ravi@ximian.com>
15587 * cs-parser.jay (interface_accessors): Re-write actions to also
15588 store attributes attached to get and set methods. Fix spelling
15591 (inteface_property_declaration): Modify accordingly.
15593 (InterfaceAccessorInfo): New helper class to store information to pass
15594 around between rules that use interface_accessors.
15596 * interface.cs (Emit): Apply attributes on the get and set
15597 accessors of properties and indexers too.
15599 * attribute.cs (ApplyAttributes): Modify accordingly to use the
15600 right MethodBuilder when applying attributes to the get and set accessors.
15602 2004-01-31 Miguel de Icaza <miguel@ximian.com>
15604 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
15606 2004-01-26 Miguel de Icaza <miguel@ximian.com>
15608 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
15610 2004-01-25 Miguel de Icaza <miguel@ximian.com>
15612 * cs-parser.jay: Remove YIELD token, instead use the new grammar
15613 changes that treat `yield' specially when present before `break'
15614 or `return' tokens.
15616 * cs-tokenizer.cs: yield is no longer a keyword.
15618 2004-01-23 Marek Safar <marek.safar@seznam.cz>
15620 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
15621 setting for default constructors.
15622 For default constructors are almost every time set wrong Modifier. The
15623 generated IL code has been alright. But inside mcs this values was
15624 wrong and this was reason why several of my CLS Compliance tests
15627 2004-01-22 Martin Baulig <martin@ximian.com>
15629 * cs-parser.jay (namespace_or_type_name): Return an Expression,
15630 not a QualifiedIdentifier. This is what `type_name_expression'
15631 was previously doing.
15632 (type_name_expression): Removed; the code is now in
15633 `namespace_or_type_name'.
15634 (qualified_identifier): Removed, use `namespace_or_type_name'
15636 (QualifiedIdentifier): Removed this class.
15638 2004-01-22 Martin Baulig <martin@ximian.com>
15640 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
15641 not a string as alias name.
15643 2004-01-21 Miguel de Icaza <miguel@ximian.com>
15645 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
15646 #52730 bug, and instead compute correctly the need to use a
15647 temporary variable when requesting an address based on the
15648 static/instace modified of the field and the constructor.
15650 2004-01-21 Martin Baulig <martin@ximian.com>
15652 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
15653 class and namespace before looking up aliases. Fixes #52517.
15655 2004-01-21 Martin Baulig <martin@ximian.com>
15657 * flowanalysis.cs (UsageVector.Merge): Allow variables being
15658 assinged in a 'try'; fixes exception4.cs.
15660 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15661 * class.cs : Implemented parameter-less constructor for TypeContainer
15663 * decl.cs: Attributes are now stored here. New property OptAttributes
15665 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
15667 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
15669 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15671 * typemanager.cs (CSharpSignature): Now reports also inner class name.
15672 (CSharpSignature): New method for indexer and property signature.
15674 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15676 * pending.cs (IsVirtualFilter): Faster implementation.
15678 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15680 * typemanager.cs: Avoid inclusion of same assembly more than once.
15682 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15684 * cs-parser.jay: Fixed problem where the last assembly attribute
15685 has been applied also to following declaration (class, struct, etc.)
15687 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15689 * class.cs: Added error CS0538, CS0539 reporting.
15690 Fixed crash on Microsoft runtime when field type is void.
15692 * cs-parser.jay: Added error CS0537 reporting.
15694 * pending.cs: Added error CS0535 reporting.
15695 Improved error report for errors CS0536, CS0534.
15697 2004-01-20 Miguel de Icaza <miguel@ximian.com>
15699 Merge a few bits from the Anonymous Method MCS tree.
15701 * statement.cs (ToplevelBlock): New class for toplevel methods,
15702 will hold anonymous methods, lifted variables.
15704 * cs-parser.jay: Create toplevel blocks for delegates and for
15705 regular blocks of code.
15707 2004-01-20 Martin Baulig <martin@ximian.com>
15709 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
15710 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
15711 and `NeedExplicitReturn'; added `IsLastStatement'.
15712 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
15713 have a `ReturnLabel' or we're not unreachable.
15715 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
15716 child's reachability; don't just override ours with it. Fixes
15717 #58058 (lluis's example).
15718 (FlowBranching): Added public InTryOrCatch(), InCatch(),
15719 InFinally(), InLoop(), InSwitch() and
15720 BreakCrossesTryCatchBoundary() methods.
15722 * statement.cs (Return): Do all error checking in Resolve().
15723 Unless we are the last statement in a top-level block, always
15724 create a return label and jump to it.
15725 (Break, Continue): Do all error checking in Resolve(); also make
15726 sure we aren't leaving a `finally'.
15727 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
15728 statement in a top-level block.
15729 (Block.Flags): Added `IsDestructor'.
15730 (Block.IsDestructor): New public property.
15732 2004-01-20 Martin Baulig <martin@ximian.com>
15734 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
15736 2004-01-20 Martin Baulig <martin@ximian.com>
15738 * statement.cs (Statement.ResolveUnreachable): New public method.
15739 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
15740 (Block.Resolve): Resolve unreachable statements.
15742 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15744 * expression.cs: We need to fix the case where we do
15745 not have a temp variable here.
15747 * assign.cs: Only expression compound assignments need
15748 temporary variables.
15750 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15752 * flowanalysis.cs: Reduce memory allocation in a few ways:
15753 - A block with no variables should not allocate a bit
15755 - A method with no out parameters does not need any tracking
15756 for assignment of the parameters, so we need not allocate
15759 public readonly Type[] VariableTypes;
15760 public readonly string[] VariableNames;
15761 Are redundant. The data is already stored in the variable
15762 map, so we need not allocate another array for it.
15763 - We need to add alot of checks for if (params | locals) == null
15764 due to the first two changes.
15766 2004-01-18 Miguel de Icaza <miguel@ximian.com>
15768 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
15769 implement IMemoryLocation, we store a copy on a local variable and
15770 take the address of it. Patch from Benjamin Jemlich
15772 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
15773 to use a special "type_name_expression" rule which reduces the
15774 number of "QualifiedIdentifier" classes created, and instead
15775 directly creates MemberAccess expressions.
15777 2004-01-17 Miguel de Icaza <miguel@ximian.com>
15779 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
15780 that fixes #52853. Null literal assignment to ValueType
15782 * class.cs (MethodData.Emit): Instead of checking the name of the
15783 method to determine if its a destructor, create a new derived
15784 class from Method called Destructor, and test for that.
15786 * cs-parser.jay: Create a Destructor object instead of a Method.
15788 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
15792 2004-01-16 Miguel de Icaza <miguel@ximian.com>
15794 * expression.cs (Binary.ResolveOperator): Perform an implicit
15795 conversion from MethodGroups to their delegate types on the
15796 Addition operation.
15798 * delegate.cs: Introduce a new class DelegateCreation that is the
15799 base class for `NewDelegate' and `ImplicitDelegateCreation',
15800 factor some code in here.
15802 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
15803 conversion from MethodGroups to compatible delegate types.
15805 * ecore.cs (Expression.Resolve): Do not flag error 654
15806 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
15807 we allow conversions from MethodGroups to delegate types now.
15809 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
15810 assignments in v2 either.
15812 2004-01-10 Miguel de Icaza <miguel@ximian.com>
15814 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
15815 static read-only fields in ctors.
15817 Applied patch from Benjamin Jemlich
15819 * expression.cs (UnaryMutator): Avoid leaking local variables.
15821 2004-01-09 Miguel de Icaza <miguel@ximian.com>
15823 * cs-tokenizer.cs (IsCastToken): Allow the various native types
15824 here to return true, as they can be used like this:
15826 (XXX) int.MEMBER ()
15828 Fixed 49836 and all the other dups
15830 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
15832 * driver.cs: Implement /win32res and /win32icon.
15834 2004-01-08 Miguel de Icaza <miguel@ximian.com>
15836 * cs-parser.jay: Add a rule to improve error handling for the
15837 common mistake of placing modifiers after the type.
15839 2004-01-07 Miguel de Icaza <miguel@ximian.com>
15841 * cs-parser.jay (interface_event_declaration): Catch
15842 initialization of events on interfaces, and report cs0068
15844 * cs-parser.jay (interface_event_declaration): Catch
15845 initialization of events.
15847 * ecore.cs: Better report missing constructors.
15849 * expression.cs (Binary.ResolveOperator): My previous bug fix had
15850 the error reporting done in the wrong place. Fix.
15852 * expression.cs (Binary.ResolveOperator): Catch the
15853 operator + (E x, E y) error earlier, and later allow for implicit
15854 conversions in operator +/- (E e, U x) from U to the underlying
15857 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
15858 52596, if the container class is abstract, the default constructor
15859 is protected otherwise its public (before, we were always public).
15861 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
15864 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
15865 Jemlich that fixes bug #52597, MCS was generating invalid code for
15866 idisposable structs. Thanks to Ben for following up with this
15869 2004-01-06 Miguel de Icaza <miguel@ximian.com>
15871 * driver.cs: Allow assemblies without code to be generated, fixes
15874 2004-01-07 Nick Drochak <ndrochak@gol.com>
15876 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
15878 2004-01-05 Miguel de Icaza <miguel@ximian.com>
15880 * cs-parser.jay: Add rules to improve error reporting if fields or
15881 methods are declared at the namespace level (error 116)
15883 * Add rules to catch event add/remove
15885 2004-01-04 David Sheldon <dave-mono@earth.li>
15887 * expression.cs: Added matching ")" to error message for
15890 2004-01-03 Todd Berman <tberman@gentoo.org>
15892 * ecore.cs, attribute.cs:
15893 Applying fix from #52429.
15895 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15897 * ecore.cs, expression.cs, statement.cs:
15898 Total rewrite of how we handle branching. We
15899 now handle complex boolean expressions with fewer
15900 jumps. As well if (x == 0) no longer emits a ceq.
15902 if (x is Foo) is much faster now, because we generate
15905 Overall, we get a pretty big improvement on our benchmark
15906 tests. The code we generate is smaller and more readable.
15908 I did a full two-stage bootstrap. The patch was reviewed
15909 by Martin and Miguel.
15911 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15913 * cs-parser.jay: Make primary_expression not take a QI.
15914 we dont need this because the member_access rule covers
15915 us here. So we replace the rule with just IDENTIFIER.
15917 This has two good effects. First, we remove a s/r conflict.
15918 Second, we allocate many fewer QualifiedIdentifier objects.
15920 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15922 * attribute.cs: Handle MarshalAs attributes as pseudo, and
15923 set the correct information via SRE. This prevents
15924 hanging on the MS runtime. Fixes #29374.
15926 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15928 * convert.cs: correctly handle conversions to value types
15929 from Enum and ValueType as unboxing conversions.
15931 Fixes bug #52569. Patch by Benjamin Jemlich.
15933 2004-01-02 Ravi Pratap <ravi@ximian.com>
15935 * expression.cs (BetterConversion): Prefer int -> uint
15936 over int -> ulong (csc's behaviour). This fixed bug #52046.
15938 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
15940 * decl.cs (MemberCache.FindMembers): now returns a
15943 * typemanager.cs: In general, go with with ^^.
15944 (CopyNewMethods): take an IList.
15945 (RealMemberLookup): Only allocate an arraylist
15946 if we copy from two sets of methods.
15948 This change basically does two things:
15949 1) Fewer array lists allocated due to CopyNewMethods.
15950 2) the explicit cast in MemberList costed ALOT.
15952 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
15954 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
15955 a hashtable to avoid needless string allocations when an identifier is
15956 used more than once (the common case).
15958 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15960 * pending.cs: MS's TypeBuilder.GetInterfaces ()
15961 is broken, it will not return anything. So, we
15962 have to use the information we have in mcs to
15965 * typemanager.cs: Add a cache for GetInterfaces,
15966 since this will now be used more often (due to ^^)
15968 (GetExplicitInterfaces) New method that gets the
15969 declared, not effective, interfaces on a type
15970 builder (eg, if you have interface IFoo, interface
15971 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
15974 This patch makes MCS able to bootstrap itself on
15977 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
15979 * expression.cs: Remove the Nop's that Miguel put
15982 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15984 * report.cs, codegen.cs: Give the real stack trace to
15985 the error when an exception is thrown.
15987 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15989 * decl.cs: only allocate hashtables for ifaces if
15992 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
15994 * expression.cs: fix the error from cs0121-2.cs
15995 (a parent interface has two child interfaces that
15996 have a function with the same name and 0 params
15997 and the function is called through the parent).
15999 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
16001 * class.cs, rootcontext.cs, typmanager.cs: do not
16004 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
16006 * codegen.cs: remove stack for the ec flow branching.
16007 It is already a linked list, so no need.
16009 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
16011 * Makefile: Allow custom profiler here.
16013 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
16015 * typemanager.cs (LookupType):
16016 - Use a static char [], because split takes
16017 a param array for args, so it was allocating
16019 - Do not store true in a hashtable, it boxes.
16021 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
16023 * flowanalysis.cs: bytify common enums.
16025 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16027 * modifiers.cs: Add a new set of flags for the
16028 flags allowed on explicit interface impls.
16029 * cs-parser.jay: catch the use of modifiers in
16030 interfaces correctly.
16031 * class.cs: catch private void IFoo.Blah ().
16033 All related to bug #50572.
16035 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16037 * decl.cs: Rewrite the consistant accessability checking.
16038 Accessability is not linear, it must be implemented in
16039 a tableish way. Fixes #49704.
16041 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16043 * expression.cs: Handle negation in a checked context.
16044 We must use subtraction from zero. Fixes #38674.
16046 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
16048 * class.cs: Ignore static void main in DLLs.
16049 * rootcontext.cs: Handle the target type here,
16050 since we are have to access it from class.cs
16051 * driver.cs: account for the above.
16053 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
16055 * report.cs: Give line numbers and files if available.
16057 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
16059 * driver.cs: Implement /addmodule.
16061 * typemanager.cs: Change 'modules' field so it now contains Modules not
16064 2003-12-20 Martin Baulig <martin@ximian.com>
16066 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
16067 (FieldBase.IsAssigned): Removed this field.
16068 (FieldBase.SetAssigned): New public method.
16069 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
16071 2003-12-20 Martin Baulig <martin@ximian.com>
16073 * expression.cs (LocalVariableReference.DoResolve): Don't set
16074 `vi.Used' if we're called from DoResolveLValue().
16076 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
16077 returns the usage vector it just merged into the current one -
16078 pass this one to UsageWarning().
16079 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
16080 of the `EmitContext', don't call this recursively on our children.
16082 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
16084 * driver.cs: Implement /target:module.
16086 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
16088 * support.cs (CharArrayHashtable): New helper class.
16090 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
16091 char arrays, not strings, so we can avoid creating a string in
16092 consume_identifier if the identifier is a keyword.
16094 2003-12-16 Martin Baulig <martin@ximian.com>
16096 * statement.cs (LocalInfo.Assigned): Removed this property.
16097 (LocalInfo.Flags): Removed `Assigned'.
16098 (LocalInfo.IsAssigned): New public method; takes the EmitContext
16099 and uses flow analysis.
16100 (Block.UsageWarning): Made this method private.
16101 (Block.Resolve): Call UsageWarning() if appropriate.
16103 * expression.cs (LocalVariableReference.DoResolve): Always set
16104 LocalInfo.Used here.
16106 2003-12-13 Martin Baulig <martin@ximian.com>
16108 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
16109 any value here; we're now using flow analysis to figure out
16110 whether a statement/block returns a value.
16112 2003-12-13 Martin Baulig <martin@ximian.com>
16114 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
16116 (FlowBranching.MergeFinally): Don't call
16117 `branching.CheckOutParameters()' here, this is called in
16119 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
16120 when adding the `finally' vector.
16122 2003-12-13 Martin Baulig <martin@ximian.com>
16125 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
16126 actually work and also fix #48962.
16128 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
16130 * decl.cs: Do not check System.Object for nested types,
16131 since we know it does not have any. Big bang for buck:
16134 Run 1: 8.35 seconds
16135 Run 2: 8.32 seconds
16136 corlib: 17.99 seconds
16138 Run 1: 8.17 seconds
16139 Run 2: 8.17 seconds
16140 corlib: 17.39 seconds
16142 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
16144 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
16145 time we are returning 0 members, so we save alot here.
16147 2003-12-11 Martin Baulig <martin@ximian.com>
16149 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
16150 `MergeChild()', also just take the `FlowBranching' as argument;
16151 call Merge() on it and return the result.
16152 (FlowBranching.Merge): We don't need to do anything if we just
16155 2003-12-11 Martin Baulig <martin@ximian.com>
16157 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
16158 them in an `ArrayList' to reduce memory usage. Thanks to Ben
16159 Maurer for this idea.
16161 2003-12-11 Martin Baulig <martin@ximian.com>
16163 * flowanalysis.cs (MergeResult): This class is now gone; we now
16164 use the `UsageVector' for this. The reason for this is that if a
16165 branching just has one sibling, we don't need to "merge" them at
16166 all - that's the next step to do.
16167 (FlowBranching.Merge): We now return a `UsageVector' instead of a
16170 2003-12-11 Martin Baulig <martin@ximian.com>
16172 Reworked flow analyis and made it more precise and bug-free. The
16173 most important change is that we're now using a special `Reachability'
16174 class instead of having "magic" meanings of `FlowReturns'. I'll
16175 do some more cleanups and optimizations and also add some more
16176 documentation this week.
16178 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
16179 largely reworked this class.
16180 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
16181 the new `Reachability' class instead of having "magic" values here.
16182 (FlowBranching): We're now using an instance of `Reachability'
16183 instead of having separate `Returns', `Breaks' etc. fields.
16185 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
16186 based on flow analysis; ignore the return value of block.Emit ().
16188 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
16190 * driver.cs typemanager.cs: Find the mono extensions to corlib even
16191 if they are private.
16193 2003-12-09 Martin Baulig <martin@ximian.com>
16195 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
16196 call them directly on the UsageVector.
16198 2003-12-09 Martin Baulig <martin@ximian.com>
16200 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
16201 Changed return type from `FlowReturns' to `Reachability'.
16203 2003-12-09 Martin Baulig <martin@ximian.com>
16205 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
16206 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
16207 `Reachable' fields with a single `Reachability' one.
16209 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16211 * class.cs (FindMembers): Remove foreach's.
16216 Run 1: 8.74 seconds
16217 Run 2: 8.71 seconds
16220 Run 1: 8.64 seconds
16221 Run 2: 8.58 seconds
16224 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16229 This patch does a few things:
16230 1. EmptyStatement is now a singleton, so it is never reallocated.
16231 2. All blah is EmptyStatement constructs have been changed to
16232 blah == EmptyStatement.Value, which is much faster and valid
16233 now that EmptyStatement is a singleton.
16234 3. When resolving a block, rather than allocating a new array for
16235 the non-empty statements, empty statements are replaced with
16236 EmptyStatement.Value
16237 4. Some recursive functions have been made non-recursive.
16238 Mainly the performance impact is from (3), however (1) and (2) are needed for
16239 this to work. (4) does not make a big difference in normal situations, however
16240 it makes the profile look saner.
16245 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16246 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16247 Total memory allocated: 56397 KB
16250 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
16251 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
16252 Total memory allocated: 55666 KB
16254 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16256 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
16257 than the hashtable in a hashtable version
16259 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
16260 we always end up concating a string. This results in a huge perf
16261 loss, because many strings have to be tracked by the GC. In this
16262 patch, we first use a hashtable that works with two keys, so that
16263 the strings do not need to be concat'ed.
16267 Run 1: 8.74 seconds
16268 Run 2: 8.71 seconds
16271 Run 1: 8.65 seconds
16272 Run 2: 8.56 seconds
16274 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16276 * Makefile: Add a new target `do-time' that does a quick and simple
16277 profile, leaving easy to parse output.
16279 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
16281 * codegen.cs (Init): Create the dynamic assembly with
16282 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
16284 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
16286 * support.cs: Make the PtrHashtable use only one
16287 instance of its comparer.
16289 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
16291 * typemanager.cs: Fix lookup of GetNamespaces.
16293 2003-11-29 Miguel de Icaza <miguel@ximian.com>
16295 * expression.cs: Removed redundant line.
16297 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
16298 ArrayLists, use for loops with bounds.
16300 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
16303 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
16304 arraylists, use for loop with bounds.
16306 The above three changes give us a 0.071 second performance
16307 improvement out of 3.294 seconds down to 3.223. On my machine
16308 the above changes reduced the memory usage by 1,387 KB during
16309 compiler bootstrap.
16311 * cs-parser.jay (QualifiedIdentifier): New class used to represent
16312 QualifiedIdentifiers. Before we created a new string through
16313 concatenation, and mostly later on, the result would be
16314 manipulated by DecomposeQI through string manipulation.
16316 This reduced the compiler memory usage for bootstrapping from
16317 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
16318 compile times in 0.05 seconds.
16320 2003-11-28 Dick Porter <dick@ximian.com>
16322 * support.cs: Do string compares with the Invariant culture.
16330 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
16331 the comparison is done with the Invariant culture.
16333 2003-11-27 Miguel de Icaza <miguel@ximian.com>
16335 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
16336 GetEnumerator method.
16338 (ProbeCollectionType): Iterate starting at the most specific type
16339 upwards looking for a GetEnumerator
16341 * expression.cs: Shift count can be up to 31 for int/uint and 63
16344 2003-11-26 Miguel de Icaza <miguel@ximian.com>
16346 * statement.cs (Block.LookupLabel): Also look for the label on the
16347 children blocks. Use a hash table to keep track of visited
16350 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
16351 we actually did transform the other operand, otherwise fall back
16352 to the common codepath that casts to long.
16354 * cs-tokenizer.cs: Use the same code pattern as the int case.
16355 Maybe I should do the parsing myself, and avoid depending on the
16356 Parse routines to get this done.
16358 2003-11-25 Miguel de Icaza <miguel@ximian.com>
16360 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16361 which fixes bug 51347. This time test it.
16363 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
16364 attributes for example can not tell the difference between these.
16365 The difference was only a syntax feature of the language.
16367 * attribute.cs: Apply attributes to delegates.
16369 * delegate.cs: Call the apply attributes method.
16371 2003-11-24 Miguel de Icaza <miguel@ximian.com>
16373 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
16374 comparing 0 vs Byte.MinValue, not the value
16376 (ImplicitConversionRequired): When reporting a conversion error,
16377 use error 31 to print out the constant error instead of the
16380 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16381 which fixes bug 51347.
16383 2003-11-22 Miguel de Icaza <miguel@ximian.com>
16385 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
16386 which fixes the -warnaserror command line option.
16388 2003-11-21 Miguel de Icaza <miguel@ximian.com>
16390 * cfold.cs (DoNumericPromotions): During constant folding of
16391 additions on UIntConstant, special case intconstants with
16392 IntConstants like we do on the expression binary operator.
16394 2003-11-12 Miguel de Icaza <miguel@ximian.com>
16396 * convert.cs (ImplicitReferenceConversion): We were missing a case
16397 (System.Enum are not value types or class types, so we need to
16398 classify them separatedly).
16400 * driver.cs: We do not support error 2007.
16402 2003-11-12 Jackson Harper <jackson@ximian.com>
16404 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
16405 system directory. Also use the full file name so users can
16406 libraries names mscorlib-o-tron.dll in a non system dir.
16408 2003-11-10 Martin Baulig <martin@ximian.com>
16410 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
16411 (TypeManager.InitCoreTypes): Initialize them here, but instead of
16412 calling `ResolveType()' on them, directly assign their `Type'.
16414 2003-11-08 Martin Baulig <martin@ximian.com>
16416 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
16417 return value and the `out parent' parameter.
16418 (TypeContainer.DefineType): Moved the CS0644 check into
16419 GetClassBases(). Don't pass the interface types to the
16420 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
16421 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
16423 * ecore.cs (TypeExpr.IsAttribute): New property.
16424 (TypeExpr.GetInterfaces): New method.
16426 * interface.cs (Interface.GetInterfaceTypeByName): Return a
16427 TypeExpr instead of a Type.
16428 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
16429 (Interface.DefineType): Don't pass the interface types to the
16430 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
16431 them later and then call `TypeBulider.AddInterfaceImplementation()'.
16433 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
16434 instead of a `Type[]'.
16435 (TypeManager.RegisterBuilder): Likewise.
16436 (TypeManager.AddUserInterface): Likewise.
16437 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
16438 `Type[]' and also return a `TypeExpr[]'.
16439 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
16441 2003-11-08 Martin Baulig <martin@ximian.com>
16443 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
16446 2003-11-08 Martin Baulig <martin@ximian.com>
16448 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
16449 TypeManager.ResolveExpressionTypes().
16451 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
16452 instead of an Expression.
16453 (TypeExpr): This is now an abstract base class for `TypeExpression'.
16454 (TypeExpression): New public class; formerly known as `TypeExpr'.
16456 * expression.cs (ComposedCast): Derive from TypeExpr.
16458 * typemanager.cs (TypeManager.system_*_expr): These are now
16459 TypExpr's instead of Expression's.
16460 (TypeManager.ResolveExpressionTypes): New public static function;
16461 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
16464 2003-11-06 Miguel de Icaza <miguel@ximian.com>
16466 * expression.cs (New.DoResolve): Do not dereference value that
16467 might be a null return.
16469 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
16470 sure that the constant value has the right type. Fixes an
16471 unreported bug, similar to 50425.
16473 * const.cs (Const.LookupConstantValue): Call
16474 ImplicitStandardConversionExists before doing a conversion to
16475 avoid havng the TypeManager.ChangeType do conversions.
16477 Reduced the number of casts used
16479 (Const.ChangeType): New routine to enable reuse of the constant
16480 type changing code from statement.
16482 * typemanager.cs (ChangeType): Move common initialization to
16483 static global variables.
16487 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
16488 every value type to go through, even if it was void. Fix that.
16490 * cs-tokenizer.cs: Use is_identifier_start_character on the start
16491 character of the define, and the is_identifier_part_character for
16492 the rest of the string.
16494 2003-11-05 Miguel de Icaza <miguel@ximian.com>
16496 * expression.cs (UnaryMutator.EmitCode): When I updated
16497 LocalVariableReference.DoResolve, I overdid it, and dropped an
16498 optimization done on local variable references.
16500 2003-11-04 Miguel de Icaza <miguel@ximian.com>
16502 * ecore.cs: Convert the return from Ldlen into an int.
16504 2003-10-20 Miguel de Icaza <miguel@ximian.com>
16506 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
16507 the accessibility, this is a special case for toplevel non-public
16508 classes (internal for instance).
16510 2003-10-20 Nick Drochak <ndrochak@gol.com>
16512 * ecore.cs: Fix typo and build. Needed another right paren.
16514 2003-10-19 Miguel de Icaza <miguel@ximian.com>
16516 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
16517 `internal' case regular and protected, but not allowing protected
16518 to be evaluated later. Bug 49840
16520 2003-10-15 Miguel de Icaza <miguel@ximian.com>
16522 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
16523 to kb.Nlast, and not the kb.nFirst to isolate the switch
16526 Extract the underlying type, so enumerations of long/ulong are
16527 treated like long/ulong.
16529 2003-10-14 Miguel de Icaza <miguel@ximian.com>
16531 * expression.cs (New): Overload the meaning of RequestedType to
16532 track the possible creation of the NewDelegate type, since
16533 DoResolve is invoked more than once for new constructors on field
16536 See bugs: #48800 and #37014
16538 * cs-parser.jay (declare_local_constants): Take an arraylist
16539 instead of a single constant.
16541 (local_constant_declaration): It should take a
16542 constant_declarators, not a constant_declarator. Fixes 49487
16544 * convert.cs: Fix error report.
16546 2003-10-13 Jackson Harper <jackson@ximian.com>
16548 * typemanager.cs (TypeToCoreType): Add float and double this fixes
16551 2003-10-09 Martin Baulig <martin@ximian.com>
16553 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
16555 (MethodCore.DoDefineParameters): Removed the TypeContainer
16556 argument; use the DeclSpace which was passed to the .ctor instead.
16557 (MethodCore.CheckParameter): Take a DeclSpace instead of a
16558 TypeContainer; we only need a DeclSpace here.
16560 2003-10-09 Martin Baulig <martin@ximian.com>
16562 * class.cs (MethodData): Added additional `DeclSpace ds' argument
16564 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
16565 EmitContext's .ctor.
16567 2003-10-09 Martin Baulig <martin@ximian.com>
16569 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
16570 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
16571 AsAccessible(), moved them as well.
16573 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
16575 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
16577 * cs-parser.jay : Renamed yyName to yyNames related to jay.
16579 2003-10-07 Miguel de Icaza <miguel@ximian.com>
16581 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
16582 generation for >=, as spotted by Paolo, bug 48679.
16583 Patch from David Waite.
16585 * cs-tokenizer.cs: Add handling for #pragma.
16587 * cs-parser.jay: Allow for both yield and yield return in the
16588 syntax. The anti-cobolization of C# fight will go on!
16590 * class.cs (TypeBuilder.DefineType): Catch error condition here
16591 (Parent.DefineType erroring out and returning null).
16593 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16594 coping with enumerations variables, we were mistakenly processing
16595 them as a regular value type instead of built-in types. Fixes the
16598 * typemanager.cs (IsBuiltinOrEnum): New method.
16600 2003-09-30 Miguel de Icaza <miguel@ximian.com>
16602 * cs-parser.jay: Upgrade: yield now needs the return clause.
16604 2003-09-19 Martin Baulig <martin@ximian.com>
16606 * decl.cs (MemberCache.SetupCacheForInterface): Take a
16607 `MemberCache parent' argument. Normally, an interface doesn't
16608 have a parent type except System.Object, but we use this in gmcs
16609 for generic type parameters.
16611 2003-09-18 Martin Baulig <martin@ximian.com>
16613 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
16614 on `type.IsInterface'; don't check whether the type has a parent
16615 to determine whether it's an interface.
16617 2003-09-15 Martin Baulig <martin@ximian.com>
16619 * class.cs (TypeContainer.DefineType): Added an error flag to
16620 avoid reporting duplicate CS0146's ("class definition is
16623 * driver.cs (Driver.MainDriver): Abort if
16624 RootContext.ResolveTree() reported any errors.
16626 2003-09-07 Martin Baulig <martin@ximian.com>
16628 * report.cs (Error, Warning): Added overloaded versions which take
16629 a `params object[] args' and call String.Format().
16631 2003-09-07 Martin Baulig <martin@ximian.com>
16633 * decl.cs (DeclSpace..ctor): Don't call
16634 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
16635 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
16636 (DeclSpace.RecordDecl): New method.
16638 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
16640 2003-09-02 Ravi Pratap <ravi@ximian.com>
16642 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
16643 value attributes to be applied to ParameterBuilders.
16645 * class.cs (MethodCore.LabelParameters): Make static and more
16646 generic so that it can be used from other places - like interface
16647 methods, for instance.
16649 * interface.cs (Interface.Emit): Call LabelParameters before
16650 emitting attributes on the InterfaceMethod.
16652 2003-08-26 Martin Baulig <martin@ximian.com>
16654 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
16655 resolving aliases; fixes #47927.
16657 2003-08-26 Martin Baulig <martin@ximian.com>
16659 * statement.cs (Using.DoResolve): This is internally emitting a
16660 try/finally clause, so we need to set ec.NeedExplicitReturn if we
16661 do not always return. Fixes #47681.
16663 2003-08-26 Martin Baulig <martin@ximian.com>
16665 * decl.cs (MemberCore): Moved WarningNotHiding(),
16666 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
16668 (AdditionResult): Make this nested in DeclSpace.
16669 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
16670 argument; call NamespaceEntry.Define() unless we're nested in a
16673 * namespace.cs (Namespace.DefineName): New public function. This
16674 is called from DeclSpace's .ctor to add
16675 (Namespace.Lookup): Include DeclSpaces in the lookup.
16677 * class.cs (Operator): Derive from MemberBase, not MemberCore.
16679 * const.cs (Const): Derive from MemberBase, not MemberCore.
16681 2003-08-25 Martin Baulig <martin@ximian.com>
16683 * convert.cs (Convert.ExplicitReferenceConversion): When
16684 converting from an interface type to a class, unbox if the target
16685 type is a struct type. Fixes #47822.
16687 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16689 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
16692 2003-08-22 Martin Baulig <martin@ximian.com>
16694 * class.cs (TypeManager.DefineType): When defining a nested type,
16695 call DefineType() on our parent; fixes #47801.
16697 2003-08-22 Martin Baulig <martin@ximian.com>
16699 * class.cs (MethodData.Define): While checking if a method is an
16700 interface implementation, improve the test a bit more to fix #47654.
16702 2003-08-22 Martin Baulig <martin@ximian.com>
16704 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
16705 correctly; fixes #47722.
16707 2003-08-22 Martin Baulig <martin@ximian.com>
16709 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
16710 LocalVariableReference, ensure it's not read-only. Fixes #47536.
16712 * statement.cs (Fixed.DoResolve): Make all variables read-only.
16714 2003-08-22 Martin Baulig <martin@ximian.com>
16716 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
16717 can only be assigned in static constructors. Fixes #47161.
16719 2003-08-22 Martin Baulig <martin@ximian.com>
16721 Rewrote and improved the flow analysis code.
16723 * flowbranching.cs (FlowBranching): Make this class abstract.
16724 (FlowBranching.CreateBranching): New static function to create a
16725 new flow branching.
16726 (FlowBranchingBlock, FlowBranchingException): New classes.
16727 (FlowBranching.UsageVector.Type): New public readonly field.
16728 (FlowBranching.UsageVector.Breaks): Removed the setter.
16729 (FlowBranching.UsageVector.Returns): Removed the setter.
16730 (FlowBranching.UsageVector): Added Break(), Return(),
16731 NeverReachable() and Throw() methods to modify the reachability.
16732 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
16733 done by FlowBranching.Merge().
16734 (FlowBranching.UsageVector.MergeChild): New method; merges the
16735 merge result into the current vector.
16736 (FlowBranching.Merge): New abstract method to merge a branching.
16738 2003-08-12 Martin Baulig <martin@ximian.com>
16740 * expression.cs (Indirection.CacheTemporaries): Create the
16741 LocalTemporary with the pointer type, not its element type.
16743 2003-08-10 Miguel de Icaza <miguel@ximian.com>
16745 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
16746 token was a keyword or not.
16748 Add `error' options where an IDENTIFIER was expected; Provide
16749 CheckToken and CheckIdentifierToken convenience error reporting
16752 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
16754 * decl.cs: Rename `NamespaceEntry Namespace' public field into
16755 NameSpaceEntry NameSpaceEntry.
16757 (LookupInterfaceOrClass): Avoid creating a full qualified name
16758 from namespace and name: avoid doing lookups when we know the
16759 namespace is non-existant. Use new Tree.LookupByNamespace which
16760 looks up DeclSpaces based on their namespace, name pair.
16762 * driver.cs: Provide a new `parser verbose' to display the
16763 exception thrown during parsing. This is turned off by default
16764 now, so the output of a failure from mcs is more graceful.
16766 * namespace.cs: Track all the namespaces defined in a hashtable
16769 (IsNamespace): New method
16771 2003-08-09 Miguel de Icaza <miguel@ximian.com>
16773 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
16774 we know that we need to concatenate (full typename can never be
16779 * statement.cs: Use a bitfield; Do not initialize to null things
16780 which are done by the constructor by default.
16782 * cs-parser.jay: bug fix, parameter was 4, not 3.
16784 * expression.cs: Just use the property;
16786 * statement.cs: No need for GetVariableInfo method.
16788 2003-08-08 Martin Baulig <martin@ximian.com>
16790 * flowanalysis.cs (FlowReturns): This is now nested in the
16791 `FlowBranching' class.
16792 (MyBitVector): Moved this here from statement.cs.
16793 (FlowBranching.SiblingType): New enum type.
16794 (FlowBranching.CreateSibling): Added `SiblingType' argument.
16796 2003-08-07 Martin Baulig <martin@ximian.com>
16798 * flowanalysis.cs (FlowBranchingType): This is now nested in the
16799 `FlowBranching' class and called `BranchingType'.
16801 2003-08-07 Martin Baulig <martin@ximian.com>
16803 * flowanalysis.cs: Moved all the control flow analysis code into
16806 2003-08-07 Martin Baulig <martin@ximian.com>
16808 * assign.cs (Assign.DoResolve): `target' must either be an
16809 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
16812 2003-08-07 Miguel de Icaza <miguel@ximian.com>
16814 * expression.cs (BinaryMethod): This kind of expression is created by the
16815 Binary class if it determines that the operator has to be handled
16818 (BinaryDelegate): This kind of expression is created if we are
16819 dealing with a + or - operator on delegates.
16821 (Binary): remove method, argumetns, and DelegateOperator: when
16822 dealing with methods,
16824 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
16826 * statement.cs (Block): use bitfields for the three extra booleans
16827 we had in use. Remove unused topblock parameter.
16829 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
16831 * assign.cs: Drop extra unneeded tests.
16833 2003-08-06 Miguel de Icaza <miguel@ximian.com>
16835 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
16837 * statement.cs (Foreach): Use VariableStorage instead of
16840 * codegen.cs (VariableStorage): New class used by clients that
16841 require a variable stored: locals or fields for variables that
16842 need to live across yield.
16844 Maybe provide a convenience api for EmitThis+EmitLoad?
16846 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
16849 2003-08-05 Miguel de Icaza <miguel@ximian.com>
16851 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
16852 RemapParameterLValue): New methods that are used to turn a
16853 precomputed FieldInfo into an expression like this:
16857 The idea is to use this instead of making LocalVariableReference
16858 have more than one meaning.
16860 * cs-parser.jay: Add error production to BASE.
16862 * ecore.cs: Deal with TypeManager.GetField returning null, which
16863 is now a valid return value.
16865 (FieldExprNoAddress): New expression for Fields whose address can
16868 * expression.cs (LocalVariableReference): During the resolve
16869 phases, create new expressions if we are in a remapping context.
16870 Remove code that dealt with remapping here.
16872 (ParameterReference): same.
16874 (ProxyInstance): New expression, like the `This' expression, but
16875 it is born fully resolved. We know what we are doing, so remove
16876 the errors that are targeted to user-provided uses of `this'.
16878 * statement.cs (Foreach): our variable is now stored as an
16879 Expression; During resolution, follow the protocol, dont just
16880 assume it will return this.
16882 2003-08-06 Martin Baulig <martin@ximian.com>
16884 * support.cs (SeekableStreamReader.cs): New public class.
16886 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
16887 SeekableStreamReader instead of the normal StreamReader.
16889 2003-08-04 Martin Baulig <martin@ximian.com>
16891 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
16892 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
16893 deambiguate casts and delegate invocations.
16894 (parenthesized_expression): Use the new tokens to ensure this is
16895 not a cast of method invocation.
16897 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
16898 when reading a `)' and Deambiguate_CloseParens () was previously
16901 * expression.cs (ParenthesizedExpression): New class. This is
16902 just used for the CS0075 test.
16903 (Binary.DoResolve): Check for CS0075.
16905 2003-07-29 Ravi Pratap <ravi@ximian.com>
16907 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
16908 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
16909 reference comparison.
16911 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
16912 examine the ReturnType for equality - this is necessary in the
16913 cases of implicit and explicit operators whose signature also
16914 includes the return type.
16916 2003-07-26 Miguel de Icaza <miguel@ximian.com>
16918 * namespace.cs: Cache the result of the namespace computation,
16919 instead of computing it every time.
16921 2003-07-24 Miguel de Icaza <miguel@ximian.com>
16923 * decl.cs: Use a global arraylist that we reuse over invocations
16924 to avoid excesive memory consumption. Reduces memory usage on an
16925 mcs compile by one meg (45 average).
16927 * typemanager.cs (LookupTypeReflection): In .NET pointers are
16928 private, work around that.
16930 2003-07-23 Miguel de Icaza <miguel@ximian.com>
16932 * literal.cs (IntLiteral): Define Zero and One static literals.
16934 * cs-parser.jay (integer_literal): use static literals to reduce
16935 memory usage for the most used literals (0, 1 and -1). 211kb
16936 reduced in memory usage.
16938 Replace all calls to `new ArrayList' with `new
16939 ArrayList(4)' which is a good average number for most allocations,
16940 and also requires only 16 bytes of memory for its buffer by
16943 This reduced MCS memory usage in seven megabytes for the RSS after
16946 2003-07-28 Ravi Pratap <ravi@ximian.com>
16948 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
16949 handle params methods the correct way by forming only one
16950 applicable set with params and normal methods in them. Earlier we
16951 were looking at params methods only if we found no normal methods
16952 which was not the correct thing to do.
16954 (Invocation.BetterFunction): Take separate arguments indicating
16955 when candidate and the best method are params methods in their
16958 This fixes bugs #43367 and #46199.
16960 * attribute.cs: Documentation updates.
16962 (CheckAttribute): Rename to CheckAttributeTarget.
16963 (GetValidPlaces): Rename to GetValidTargets.
16965 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
16966 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
16970 2003-07-28 Martin Baulig <martin@ximian.com>
16972 * class.cs (TypeContainer.DefineMembers): Use the base type's full
16973 name when looking up the base class of a nested class. Fixes #46977.
16975 2003-07-26 Martin Baulig <martin@ximian.com>
16977 * expression.cs (Indexers.Indexer): New nested struct; contains
16978 getter, setter and the indexer's type.
16979 (Indexers.Properties): This is now an ArrayList of
16980 Indexers.Indexer's.
16981 (IndexerAccess.DoResolveLValue): Correctly set the type if the
16982 indexer doesn't have any getters.
16984 * assign.cs (Assign.DoResolve): Also do the implicit conversions
16985 for embedded property and indexer assignments.
16987 2003-07-26 Martin Baulig <martin@ximian.com>
16989 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
16990 preprocessor directive is not the first non-whitespace character
16993 2003-07-26 Martin Baulig <martin@ximian.com>
16995 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
16996 namespace parsing, follow the spec more closely.
16998 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
16999 NamespaceEntry.Lookup().
17001 2003-07-25 Martin Baulig <martin@ximian.com>
17003 * MethodCore.cs (OverridesSomething): New public field; it's set
17004 from TypeContainer.DefineMembers if this method overrides
17005 something (which doesn't need to be a method). Fix #39462.
17007 2003-07-25 Ravi Pratap <ravi@ximian.com>
17009 * typemanager.cs (GetMembers): Ensure that the list of members is
17010 reversed. This keeps things in sync.
17012 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
17013 find an AttributeUsage attribute.
17015 * expression.cs (Invocation.OverloadResolve): Perform the check
17016 which disallows Invoke to be directly called on a Delegate.
17018 (Error_InvokeOnDelegate): Report error cs1533.
17020 2003-07-25 Martin Baulig <martin@ximian.com>
17022 * expression.cs (Indexers.GetIndexersForType): Only look in the
17023 interface hierarchy if the requested type is already an
17024 interface. Fixes #46788 while keeping #46502 fixed.
17026 2003-07-25 Martin Baulig <martin@ximian.com>
17028 * class.cs (TypeContainer.DefineMembers): Check whether all
17029 readonly fields have been assigned and report warning CS0649 if
17032 * statement.cs (LocalInfo.IsFixed): Always return true if this is
17035 2003-07-24 Ravi Pratap <ravi@ximian.com>
17037 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
17038 returned from GetMethods to make things consistent with the
17039 assumptions MCS makes about ordering of methods.
17041 This should comprehensively fix bug #45127 and it does :-)
17043 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
17044 ordering is actually reverse.
17046 * Clean up some debug messages I left lying around.
17048 * interface.cs (Populate*): Get rid of code which emits attributes
17049 since the stage in which we emit attributes is the 'Emit' stage,
17050 not the define stage.
17052 (Emit): Move attribute emission for interface members here.
17054 2003-07-22 Ravi Pratap <ravi@ximian.com>
17056 * expression.cs (Invocation.OverloadResolve): Follow the spec more
17057 closely: we eliminate methods in base types when we have an
17058 applicable method in a top-level type.
17060 Please see section 14.5.5.1 for an exact description of what goes
17063 This fixes bug #45127 and a host of other related to corlib compilation.
17065 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
17066 array is the method corresponding to the top-level type (this is
17067 because of the changes made to icall.c) so we change this
17070 (MethodGroupExpr.Name): This too.
17072 * typemanager.cs (GetElementType): New method which does the right
17073 thing when compiling corlib.
17075 * everywhere: Make use of the above in the relevant places.
17077 2003-07-22 Martin Baulig <martin@ximian.com>
17079 * cs-parser.jay (invocation_expression): Moved
17080 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
17081 `cast_expression', but create a InvocationOrCast which later
17082 resolves to either an Invocation or a Cast.
17084 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
17085 method; call this before EmitStatement() to make sure that this
17086 expression can be used as a statement.
17088 * expression.cs (InvocationOrCast): New class; resolves to either
17089 an Invocation or a Cast.
17091 * statement.cs (StatementExpression): Call ResolveStatement() on
17092 the ExpressionStatement before emitting it.
17094 2003-07-21 Martin Baulig <martin@ximian.com>
17096 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
17097 `ref' and `out' attributes match; fixes #46220.
17098 (MemberAccess.ResolveMemberAccess): You can't reference a type
17099 through an expression; fixes #33180.
17100 (Indexers.GetIndexersForType): Don't return the indexers from
17101 interfaces the class implements; fixes #46502.
17103 2003-07-21 Martin Baulig <martin@ximian.com>
17105 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
17106 CS0661 checks; fixes bug #30442.
17108 2003-07-21 Martin Baulig <martin@ximian.com>
17110 * decl.cs (AdditionResult): Added `Error'.
17112 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
17114 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
17115 makes cs0031.cs actually work.
17117 2003-07-20 Martin Baulig <martin@ximian.com>
17119 * namespace.cs: Fixed that bug which caused a crash when compiling
17120 the debugger's GUI.
17122 2003-07-20 Miguel de Icaza <miguel@ximian.com>
17124 * typemanager.cs (LookupTypeReflection): Never expose types which
17125 are NotPublic, NestedPrivate, NestedAssembly, or
17126 NestedFamANDAssem. We used to return these, and later do a check
17127 that would report a meaningful error, but the problem is that we
17128 would not get the real match, if there was a name override.
17130 2003-07-18 Miguel de Icaza <miguel@ximian.com>
17132 * namespace.cs (Namespace, Name): Do not compute the namespace
17133 name dynamically, compute it in the constructor. This reduced
17134 memory usage by 1697 KB.
17136 * driver.cs: Use --pause to pause at the end.
17138 2003-07-17 Peter Williams <peter@newton.cx>
17140 * Makefile: Change the name of the test target so that it doesn't
17141 conflict with the recursive test target.
17143 2003-07-17 Miguel de Icaza <miguel@ximian.com>
17145 * expression.cs (LocalVariableReference.Emit, EmitAssign,
17146 AddressOf): Do not use EmitThis, that was wrong, use the actual
17149 2003-07-15 Miguel de Icaza <miguel@ximian.com>
17151 * class.cs (MethodData.Define): While checking if a method is an
17152 interface implementation, improve the test: If we are not public
17153 (use new test here: use the computed MethodAttributes directly,
17154 instead of the parsed modifier flags) check if the `implementing'
17155 method comes from an interface or not.
17157 * pending.cs (VerifyPendingMethods): Slightly better error
17160 * makefile: add test target that does the mcs bootstrap.
17162 2003-07-16 Ravi Pratap <ravi@ximian.com>
17164 * interface.cs (Define): Do nothing here since there are no
17165 members to populate etc. Move the attribute emission out of here
17166 since this was just totally the wrong place to put it. Attribute
17167 application happens during the 'Emit' phase, not in the 'Define'
17170 (Emit): Add this method and move the attribute emission here
17172 * rootcontext.cs (EmitCode): Call the Emit method on interface
17175 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17177 * expression.cs (OverloadResolve): Report error only if Location
17178 is not 'Null' which means that there was a probe going on.
17180 2003-07-14 Martin Baulig <martin@ximian.com>
17182 * expression.cs (ConditionalLogicalOperator): New public class to
17183 implement user defined conditional logical operators.
17184 This is section 14.11.2 in the spec and bug #40505.
17186 2003-07-14 Martin Baulig <martin@ximian.com>
17188 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
17190 2003-07-14 Martin Baulig <martin@ximian.com>
17192 * codegen.cs (EmitContext.InFixedInitializer): New public field.
17194 * ecore.cs (IVariable.VerifyFixed): New interface method.
17196 * expression.cs (Unary.ResolveOperator): When resolving the `&'
17197 operator, check whether the variable is actually fixed. Fixes bug
17198 #36055. Set a variable definitely assigned when taking its
17199 address as required by the spec.
17201 * statement.cs (LocalInfo.IsFixed): New field.
17202 (LocalInfo.MakePinned): Set `IsFixed' to true.
17204 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17206 * attribute.cs (Attribute.Resolve): While doing a Member lookup
17207 for .ctors, ensure that we only ask for members declared in the
17208 attribute type (BindingFlags.DeclaredOnly).
17212 * expression.cs (Error_WrongNumArguments): Report error 1501
17213 correctly the way CSC does.
17215 2003-07-13 Martin Baulig <martin@ximian.com>
17217 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
17218 lookup on the fully qualified name, to make things like "X.X" work
17219 where "X.X" is a fully qualified type name, but we also have a
17220 namespace "X" in the using list. Fixes #41975.
17222 2003-07-13 Martin Baulig <martin@ximian.com>
17224 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
17225 function. If we're a CompoundAssign, we need to create an embedded
17226 CompoundAssign, not an embedded Assign.
17227 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
17230 2003-07-13 Martin Baulig <martin@ximian.com>
17232 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
17233 work to fix bug #46088.
17235 2003-07-13 Ravi Pratap <ravi@ximian.com>
17237 * class.cs (Operator.Emit): Do not emit attributes here - it is
17238 taken care of by the Method class that we delegate too. This takes
17239 care of bug #45876.
17241 2003-07-10 Martin Baulig <martin@ximian.com>
17243 * expression.cs (TypeOfVoid): New class.
17244 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
17246 2003-07-10 Martin Baulig <martin@ximian.com>
17248 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
17251 2003-07-10 Martin Baulig <martin@ximian.com>
17253 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
17254 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
17256 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
17258 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
17260 2003-07-10 Martin Baulig <martin@ximian.com>
17262 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
17263 of decimal. Fixes #42850.
17265 NOTE: I also fixed the created byte blob, but this doesn't work on
17266 the MS runtime and csc never produces any byte blobs for decimal
17269 2003-07-10 Martin Baulig <martin@ximian.com>
17271 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
17272 structs; fixes #32068.
17273 (Block.AddChildVariableNames): Fixed #44302.
17275 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17277 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
17279 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17281 * attribute.cs: And this test is onger needed.
17283 2003-07-08 Martin Baulig <martin@ximian.com>
17285 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
17286 inaccessible types. Fixes #36313.
17288 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
17290 * namespace.cs (NamespaceEntry): Create implicit entries for all
17291 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
17292 implicit entries for N1.N2 and N1.
17294 2003-07-08 Martin Baulig <martin@ximian.com>
17296 Rewrote the handling of namespaces to fix a lot of the issues
17297 wrt. `using' aliases etc.
17299 * namespace.cs (Namespace): Splitted this class into a
17300 per-assembly `Namespace' and a per-file `NamespaceEntry'.
17302 * typemanager.cs (TypeManager.IsNamespace): Removed.
17303 (TypeManager.ComputeNamespaces): Only compute namespaces from
17304 loaded assemblies here, not the namespaces from the assembly we're
17305 currently compiling.
17307 2003-07-08 Martin Baulig <martin@ximian.com>
17309 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
17311 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17313 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
17316 I thought about the memory savings here, but LookupTypeReflection
17317 is used under already very constrained scenarios. Compiling
17318 corlib or mcs only exposes one hit, so it would not really reduce
17319 any memory consumption.
17321 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17323 * typemanager.cs: fixes bug #45889 by only adding public types from
17324 other assemblies to the list of known types.
17326 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17328 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
17329 on the type we resolved.
17331 2003-07-05 Martin Baulig <martin@ximian.com>
17333 * pending.cs (PendingImplementation.ParentImplements): Don't
17334 create the proxy if the parent is abstract.
17336 * class.cs (TypeContainer.DefineIndexers): Process explicit
17337 interface implementations first. Fixes #37714.
17339 2003-07-04 Miguel de Icaza <miguel@ximian.com>
17341 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
17342 defined recursively; but since we modify the input parameters
17343 (left is set to `this' temporarily), we reset this value if the
17344 left_is_explicit is false, which gives the original semantics to
17347 * literal.cs (NullPointer): new class used to represent a null
17348 literal in a pointer context.
17350 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
17351 type is a pointer, use a NullPointer object instead of a
17352 NullLiteral. Closes 43687
17354 (ExplicitConversion): Convert pointer values using
17355 the conv opcode to the proper type.
17357 * ecore.cs (New): change ValueTypeVariable property into a method,
17358 that returns whether the valuetype is suitable for being used.
17360 * expression.cs (Binary.DoNumericPromotions): Only return if we
17361 the int constant was a valid uint, and we can return both left and
17362 right as uints. If not, we continue processing, to trigger the
17363 type conversion. This fixes 39018.
17365 * statement.cs (Block.EmitMeta): During constant resolution, set
17366 the CurrentBlock property on the emitcontext, so that we resolve
17367 constants propertly.
17369 2003-07-02 Martin Baulig <martin@ximian.com>
17371 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
17372 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
17374 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
17375 than emitting it here.
17377 * statement.cs: Fixed some more flow analysis bugs.
17379 2003-07-02 Martin Baulig <martin@ximian.com>
17381 * class.cs (MethodData.Define): When implementing interface
17382 methods, set Final unless we're Virtual.
17384 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
17385 check work for interface methods.
17387 2003-07-01 Martin Baulig <martin@ximian.com>
17389 * ecore.cs (EmitContext.This): Replaced this property with a
17390 GetThis() method which takes a Location argument. This ensures
17391 that we get the correct error location for a CS0188.
17393 2003-07-01 Miguel de Icaza <miguel@ximian.com>
17395 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
17396 ImplicitStandardConversion.
17398 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
17400 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
17402 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
17405 2003-06-30 Miguel de Icaza <miguel@ximian.com>
17407 * class.cs (Constructor.Define): Turn off initlocals for unsafe
17410 (MethodData.Define): Turn off initlocals for unsafe methods.
17412 2003-06-29 Miguel de Icaza <miguel@ximian.com>
17414 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
17415 complete; Fixes #37521.
17417 * delegate.cs: Use Modifiers.TypeAttr to compute the
17418 TypeAttributes, instead of rolling our own. This makes the flags
17419 correct for the delegates.
17421 2003-06-28 Miguel de Icaza <miguel@ximian.com>
17423 * class.cs (Constructor.Define): Set the private flag for static
17424 constructors as well.
17426 * cs-parser.jay (statement_expression): Set the return value to
17427 null, to avoid a crash when we catch an error.
17429 2003-06-24 Miguel de Icaza <miguel@ximian.com>
17431 * cs-parser.jay: Applied patch from Jackson that adds support for
17432 extern and unsafe modifiers to destructor declarations.
17434 * expression.cs: Report error 21 if the user is trying to index a
17437 * driver.cs: Add an error message, suggested by the bug report.
17439 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
17440 if we do not have a ": this ()" constructor initializer. Fixes 45149
17442 2003-06-14 Miguel de Icaza <miguel@ximian.com>
17444 * namespace.cs: Add some information to reduce FAQs.
17446 2003-06-13 Miguel de Icaza <miguel@ximian.com>
17448 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
17449 underlying enumeration types. Fixes #43915.
17451 * expression.cs: Treat ushort/short as legal values to be used in
17452 bitwise operations.
17454 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
17456 * delegate.cs: transfer custom attributes for paramenters from
17457 the delegate declaration to Invoke and BeginInvoke.
17459 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
17461 * attribute.cs: handle custom marshalers and emit marshal info
17464 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
17466 * makefile.gnu: Added anonymous.cs to the compiler sources.
17468 2003-05-28 Miguel de Icaza <miguel@ximian.com>
17470 * iterators.cs: Change the name of the proxy class to include two
17473 * cs-parser.jay: Update grammar to include anonymous methods.
17475 * anonymous.cs: new file.
17477 2003-05-27 Miguel de Icaza <miguel@ximian.com>
17479 * class.cs (Field.Define): Add missing test for pointers and
17482 2003-05-27 Ravi Pratap <ravi@ximian.com>
17484 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
17485 we use the stobj opcode.
17487 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
17488 since it wasn't the correct fix.
17490 It still is puzzling that we are required to use stobj for IntPtr
17491 which seems to be a ValueType.
17493 2003-05-26 Miguel de Icaza <miguel@ximian.com>
17495 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
17496 during regular simple name resolution. Now, the trick is that
17497 instead of returning for processing the simplename, we do a
17498 TypeManager.LookupType (ie, a rooted lookup as opposed to a
17499 contextual lookup type). If a match is found, return that, if
17500 not, return for further composition.
17502 This fixes long-standing 30485.
17504 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
17505 using the address to initialize an object, do an Stobj instead of
17506 using the regular Stelem.
17508 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
17509 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
17510 Because if we are a BaseIndexerAccess that value will be true.
17513 * statement.cs (GotoCase.Resolve): Return after reporting an
17514 error, do not attempt to continue.
17516 * expression.cs (PointerArithmetic.Emit): If our operand is a
17517 long, convert our constants to match the operand before
17518 multiplying. Convert to I type before adding. Fixes 43670.
17520 2003-05-14 Ravi Pratap <ravi@ximian.com>
17522 * enum.cs (ImplicitConversionExists) : Rename to
17523 ImplicitEnumConversionExists to remove ambiguity.
17525 * ecore.cs (NullCast): New type of cast expression class which
17526 basically is very similar to EmptyCast with the difference being
17527 it still is a constant since it is used only to cast a null to
17529 (eg. (string) null)
17531 * convert.cs (ImplicitReferenceConversion): When casting a null
17532 literal, we return a NullCast.
17534 * literal.cs (NullLiteralTyped): Remove - I don't see why this
17535 should be around anymore.
17537 The renaming (reported was slightly wrong). Corrections:
17539 ConvertImplicitStandard -> ImplicitConversionStandard
17540 ConvertExplicitStandard -> ExplicitConversionStandard
17542 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
17543 before passing them in !
17545 * convert.cs (ImplicitConversionStandard): When comparing for
17546 equal expr and target types, ensure that expr is not a
17549 In general, we must not be checking (expr_type ==
17550 target_type) in the top level conversion methods
17551 (ImplicitConversion, ExplicitConversion etc). This checking is
17552 done in the methods that they delegate to.
17554 2003-05-20 Miguel de Icaza <miguel@ximian.com>
17556 * convert.cs: Move Error_CannotConvertType,
17557 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
17558 ImplicitNumericConversion, ImplicitConversionExists,
17559 ImplicitUserConversionExists, StandardConversionExists,
17560 FindMostEncompassedType, FindMostSpecificSource,
17561 FindMostSpecificTarget, ImplicitUserConversion,
17562 ExplicitUserConversion, GetConversionOperators,
17563 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
17564 TryImplicitIntConversion, Error_CannotConvertImplicit,
17565 ConvertImplicitRequired, ConvertNumericExplicit,
17566 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
17567 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
17570 Perform the following renames:
17572 StandardConversionExists -> ImplicitStandardConversionExists
17573 ConvertImplicit -> ImplicitConversion
17574 ConvertImplicitStandard -> ImplicitStandardConversion
17575 TryImplicitIntConversion -> ImplicitIntConversion
17576 ConvertImplicitRequired -> ImplicitConversionRequired
17577 ConvertNumericExplicit -> ExplicitNumericConversion
17578 ConvertReferenceExplicit -> ExplicitReferenceConversion
17579 ConvertExplicit -> ExplicitConversion
17580 ConvertExplicitStandard -> ExplicitStandardConversion
17582 2003-05-19 Martin Baulig <martin@ximian.com>
17584 * statement.cs (TypeInfo.StructInfo): Made this type protected.
17585 (TypeInfo): Added support for structs having structs as fields.
17587 * ecore.cs (FieldExpr): Implement IVariable.
17588 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
17589 VariableInfo for the field.
17591 2003-05-18 Martin Baulig <martin@ximian.com>
17593 * expression.cs (This.DoResolve): Report a CS0027 if we're
17594 emitting a field initializer.
17596 2003-05-18 Martin Baulig <martin@ximian.com>
17598 * expression.cs (This.ResolveBase): New public function.
17599 (This.DoResolve): Check for CS0188.
17601 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
17604 * ecore.cs (MethodGroupExpr.DoResolve): Set the
17605 `instance_expression' to null if we don't have any non-static
17608 2003-05-18 Martin Baulig <martin@ximian.com>
17610 Reworked the way how local variables and parameters are handled by
17611 the flow analysis code.
17613 * statement.cs (TypeInfo, VariableMap): New public classes.
17614 (VariableInfo): New public class. This is now responsible for
17615 checking whether a variable has been assigned. It is used for
17616 parameters and local variables.
17617 (Block.EmitMeta): Take the InternalParameters as argument; compute
17618 the layout of the flow vectors here.
17619 (Block.LocalMap, Block.ParameterMap): New public properties.
17620 (FlowBranching): The .ctor doesn't get the InternalParameters
17621 anymore since Block.EmitMeta() now computes the layout of the flow
17623 (MyStructInfo): This class is now known as `StructInfo' and nested
17624 in `TypeInfo'; we don't access this directly anymore.
17626 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
17627 property and removed IsAssigned(), IsFieldAssigned(),
17628 SetAssigned() and SetFieldAssigned(); we now call them on the
17629 VariableInfo so we don't need to duplicate this code everywhere.
17631 * expression.cs (ParameterReference): Added `Block block' argument
17633 (LocalVariableReference, ParameterReference, This): The new
17634 VariableInfo class is now responsible for all the definite
17637 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
17638 IsParameterAssigned, SetParameterAssigned): Removed.
17640 2003-05-18 Martin Baulig <martin@ximian.com>
17642 * typemanager.cs (InitCoreTypes): Try calling
17643 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
17644 the 3-args-version. Corlib now also needs our `void_type'.
17645 (GetMethod): Added overloaded version which takes an optional
17646 `bool report_errors' to allow lookups of optional methods.
17648 2003-05-12 Martin Baulig <martin@ximian.com>
17650 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
17651 only used for locals and not for parameters.
17653 2003-05-12 Miguel de Icaza <miguel@ximian.com>
17655 * support.cs (InternalParameters.ParameterType): Return the
17656 ExternalType of the parameter.
17658 * parameter.cs (Parameter.ExternalType): drop the two arguments,
17661 2003-05-11 Miguel de Icaza <miguel@ximian.com>
17663 * class.cs (MethodData.Define): Do not set the `newslot' on
17664 interface members, if they are also flagged as "override".
17666 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
17667 better code for ++i and i++. This only works for static fields
17668 and local variables.
17670 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
17671 want to pull the DeclSpace out of the builder_to_declspace instead
17672 of the TypeBuilder (like in TypeContainer.FindMembers).
17674 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
17675 instead of LookupTypeContainer. Fixes the crash on .NET for
17676 looking up interface members.
17678 * const.cs: Create our own emit context during the Definition
17679 stage, so that constants are evaluated in the proper context, when
17680 a recursive definition happens.
17682 2003-05-11 Martin Baulig <martin@ximian.com>
17684 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
17685 new block for a switch section.
17686 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
17687 the adding/lookup in the switch block. Fixes #39828.
17689 2003-05-09 Miguel de Icaza <miguel@ximian.com>
17691 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
17692 functionality: I needed to convert the data after I had performed
17693 the add/sub operation into the operands type size.
17695 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
17696 pass the type for the box operation, otherwise the resulting
17697 object would have been of type object.
17699 (BoxedCast): Add constructor to specify the type to box as.
17701 2003-05-07 Miguel de Icaza <miguel@ximian.com>
17703 * iterators.cs: I was reusing the `count' variable inadvertently,
17704 take steps to not allow this to happen.
17706 2003-05-06 Miguel de Icaza <miguel@ximian.com>
17708 * attribute.cs (Attribute.Resolve): Params attributes are encoded
17709 by creating an array at the point where the params starts and
17710 putting all those arguments there, then adjusting the size of the
17713 2003-05-05 Miguel de Icaza <miguel@ximian.com>
17715 * expression.cs (New.AddressOf): Implement interface
17716 IMemoryLocation. This is used when the `new' operator is used in
17717 the context of an invocation to a method on a value type.
17719 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
17722 * namespace.cs: Also check the using aliases here.
17724 * driver.cs: Move the test for using validity after the types have
17725 been entered, so we do a single pass that also includes the using
17728 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
17729 in the regular case. CreateSiblingForFinally is doing extra
17732 * attribute.cs (GetAttributeArgumentExpression): Store the result
17733 on an out value, and use the return value to indicate failure
17734 instead of using null (which is a valid return for Constant.GetValue).
17736 * statement.cs: Perform the analysis flow for the increment
17737 portion after the statement, because this will be the real flow of
17738 execution. Fixes #42385
17740 * codegen.cs (EmitContext.EmitArgument,
17741 EmitContext.EmitStoreArgument): New helper functions when the
17742 RemapToProxy flag is set.
17744 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
17747 Add support for remapping parameters.
17749 * iterators.cs: Propagate parameter values; Store parameter
17750 values in the proxy classes.
17752 2003-05-04 Miguel de Icaza <miguel@ximian.com>
17754 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
17755 need a proxy reference; I do not know what I was thinking
17757 * cs-parser.jay (constructor_initializer): catch another error,
17758 and display nice message.
17760 (field_declaration): catch void field declaration
17761 to flag a better error.
17763 * class.cs (MemberBase.CheckBase): Report an error instead of a
17764 warning if a new protected member is declared in a struct.
17765 (Field.Define): catch the error of readonly/volatile.
17767 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
17769 (FieldExpr.AddressOf): ditto. Catch error where the address of a
17770 volatile variable is taken
17772 2003-05-02 Miguel de Icaza <miguel@ximian.com>
17774 * statement.cs (Fixed.Resolve): Report an error if we are not in
17777 2003-05-01 Miguel de Icaza <miguel@ximian.com>
17779 * typemanager.cs: reuse the code that handles type clashes for
17780 delegates and enumerations.
17782 * class.cs (Report28): Always report.
17784 * expression.cs (EncodeAsAttribute): Allow nulls here.
17786 2003-04-28 Miguel de Icaza <miguel@ximian.com>
17788 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
17789 the functionality for testing whether an expression is valid for
17790 an attribute here. Also handle the case of arrays of elements
17793 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
17794 encoding a linear array into an array of objects that are suitable
17795 to be passed to an CustomAttributeBuilder.
17797 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
17799 * ecore.cs: (FieldExpr): Handle field remapping here.
17801 * iteratators.cs: Pass the instance variable (if the method is an
17802 instance method) to the constructors, so we can access the field
17803 variables on the class.
17805 TODO: Test this with structs. I think the THIS variable on
17806 structs might have to be a pointer, and not a refenrece
17808 2003-04-27 Miguel de Icaza <miguel@ximian.com>
17810 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
17811 local variables to fields in a proxy class.
17813 * iterators.cs (PopulateProxy): Rename our internal fields to
17815 Create a <THIS> field if we are an instance method, so we can
17816 reference our parent container variables.
17817 (MapVariable): Called back from the EmitContext code to enter a
17818 new variable to field mapping into the proxy class (we just create
17822 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
17823 for using the remapped locals to fields.
17825 I placed the code here, because that gives the same semantics to
17826 local variables, and only changes the Emit code.
17828 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
17829 statements inside iterators.
17830 (VariableInfo): Add a FieldBuilder for the cases when we are
17831 remapping local variables to fields in a proxy class
17833 * ecore.cs (SimpleNameResolve): Avoid testing two times for
17834 current_block != null.
17836 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
17837 not cope with strings, as it has been moved to the
17838 TableSwitchEmit. Fixed bug in switch generation.
17840 * expression.cs (New.DoResolve): Provide more context for the user
17841 when reporting an error.
17843 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
17846 * expression.cs (MemberAccess.DoResolve): When we get a type back,
17847 check the permissions for it. Note than in a type-resolution
17848 context the check was already present in DeclSpace.ResolveType,
17849 but was missing from the MemberAccess.
17851 (ArrayCreation.CheckIndices): warn if the user has
17852 more nested levels of expressions, but there are no more
17853 dimensions specified. Avoids crash on bug 41906.
17855 2003-04-26 Miguel de Icaza <miguel@ximian.com>
17857 * statement.cs (Block): replace Implicit bool, for a generic
17859 New flag: `Unchecked'. This is used during the EmitMeta phase
17860 (which is out-of-line with the regular Resolve/Emit process for a
17861 statement, as this is done ahead of time, but still gets a chance
17862 to call constant resolve).
17864 (Block.Flags): new enum for adding a new flag.
17866 (Block.EmitMeta): track the state of unchecked.
17868 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
17869 to enable constant resolution to work there as well.
17871 2003-04-22 Miguel de Icaza <miguel@ximian.com>
17873 * typemanager.cs (ienumerable_type): Also look up
17874 System.Collections.IEnumerable.
17876 2003-04-21 Miguel de Icaza <miguel@ximian.com>
17878 TODO: Test more than one conditional per method.
17880 * class.cs (Indexer.Define): Report the location where the user is
17881 referencing the unsupported feature.
17883 (MethodData): Overload the use of `conditionals' to
17884 minimize the creation of needless ArrayLists. This saves roughly
17885 212kb on my machine.
17887 (Method): Implement the new IIteratorContainer interface.
17888 (Method.SetYields): Implement the method by setting the ModFlags
17889 to contain METHOD_YIELDS.
17891 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
17892 which just got set to null.
17894 * iterators.cs: New file.
17896 (Yield, YieldBreak): New statements.
17898 * statement.cs (Return.Resolve): Flag an error if we are used in
17899 an iterator method.
17901 * codegen.cs (InIterator): New flag set if the code is being
17902 compiled in an iterator method.
17904 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
17905 internal modifier, and we just use it to avoid adding extra
17906 fields, as this is seldom used.
17908 * cs-parser.jay: Add yield_statement (yield and yield break).
17910 * driver.cs: New flag -v2 to turn on version 2 features.
17912 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
17913 hashtable when v2 is enabled.
17915 2003-04-20 Miguel de Icaza <miguel@ximian.com>
17917 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
17918 there is already a namespace defined with this name.
17920 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
17921 people upgraded their corlibs.
17923 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
17924 always use fully qualified types, no need to use the compiler
17927 (TypeManager.IsNamespace): Use binarysearch.
17929 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
17930 AddDelegate): I did not quite use the new IsValid API properly: I
17931 have to pass the short-name and the fullname. I was passing only
17932 the basename instead of the fullname sometimes.
17934 (TypeContainer.DefineType): call NamespaceClash.
17936 * interface.cs (Interface.DefineType): use NamespaceClash before
17939 * delegate.cs (Delegate.DefineType): use NamespaceClash before
17942 * enum.cs: (Enum.DefineType): use NamespaceClash before
17945 * typemanager.cs (: 3-line patch that gives us some tasty 11%
17946 speed increase. First, use the negative_hits cache when we get a
17947 negative. Second, add the type with its full original name
17948 instead of the new . and + encoded name (reflection uses + to
17949 separate type from a nested type). Use LookupTypeReflection
17950 directly which bypasses the type->name hashtable (that we already
17951 know does not contain the type.
17953 * decl.cs (DeclSpace.ResolveTypeExpr): track the
17954 location/container type.
17956 * driver.cs: When passing utf8, use directly the UTF8Encoding.
17958 2003-04-19 Miguel de Icaza <miguel@ximian.com>
17960 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
17962 * delegate.cs (NewDelegate.Resolve): Test whether an instance
17963 method is being referenced in the method group from a static
17964 context, and report error 120 if so.
17966 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
17969 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
17970 is created, we create the A namespace).
17972 * cs-parser.jay: A namespace also introduces a DeclarationFound.
17975 2003-04-18 Miguel de Icaza <miguel@ximian.com>
17977 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
17978 invocation to ModuleBuilder.GetType with the same values will
17979 return a new type instance, so we need to cache its return
17982 * expression.cs (Binary.ResolveOperator): Only allow the compare
17983 operators on enums if they are of the same type.
17985 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
17986 types of ValueType on their own case. Before we were giving them
17987 the same treatment as objects.
17989 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
17990 fullname. Short name is used to compare against container name.
17991 Fullname is used to check against defined namespace names.
17993 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
17994 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
17996 (Method.CheckBase): Call parent.
17997 (MemberBase.CheckBase): Check for protected members on sealed
17999 (PropertyBase.CheckBase): Call parent.
18000 (Field.Define): Call parent.
18002 * report.cs: Negative error codes are now mapped to 8000 - code,
18003 so that the display is render more nicely.
18005 * typemanager.cs: Do not use try/catch, instead report a regular
18008 (GetPointerType, GetReferenceType): These methods provide
18009 mechanisms to obtain the T* and T& from a T. We had the code
18010 previously scattered around the code base, and it also used
18011 TypeManager.LookupType that would go through plenty of caches.
18012 This one goes directly to the type source.
18014 In some places we did the Type.GetType followed by
18015 ModuleBuilder.GetType, but not in others, so this unifies the
18016 processing as well.
18018 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
18019 statements now that we have namespace information.
18021 * typemanager.cs (IsNamespace): New method, returns whether the
18022 string presented is a namespace or not.
18024 (ComputeNamespaces): New public entry point, computes the list of
18025 available namespaces, using the GetNamespaces API call in Mono, or
18026 the slower version in MS.NET.
18028 Now before we start the semantic analysis phase, we have a
18029 complete list of namespaces including everything that the user has
18032 Deleted old code to cache namespaces in .nsc files.
18034 2003-04-17 Miguel de Icaza <miguel@ximian.com>
18036 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
18037 class/struct location definition Location for the implicit
18038 constructor location.
18040 (Operator.Define): Use the location of the operator for the
18041 implicit Method definition.
18043 (Constructor.Emit): use the constructor location for the implicit
18044 base initializer constructor.
18046 * ecore.cs: Remove ITypeExpression. This interface is now gone,
18047 and the Expression class now contains two new methods:
18049 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
18050 isolate type lookup from the rest of the resolution process.
18052 Since we use Expressions to hold type definitions due to the way
18053 we parse the input we have historically overloaded Resolve to
18054 perform the Type lookups if a special flag is passed. Now this is
18055 eliminated and two methods take their place.
18057 The differences in the two methods between xStep and xTerminal is
18058 that xStep is involved in our current lookup system that uses
18059 SimpleNames to compose a name, while xTerminal is used just to
18060 catch the case where the simplename lookup failed.
18062 2003-04-16 Miguel de Icaza <miguel@ximian.com>
18064 * expression.cs (ResolveMemberAccess): Remove redundant code.
18065 TypeExpr expressions are always born fully resolved.
18067 * interface.cs (PopulateMethod): Do not lookup the types twice.
18068 We were doing it once during SemanticAnalysis and once during
18071 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
18072 in local variable type definitions, were being returned as a
18073 SimpleName (we decomposed everything into a string), that is
18074 because primary_expression was being used instead of a type in the
18075 grammar (reduce/reduce conflicts).
18077 The part that was wrong is that we converted the expression into a
18078 string (an oversimplification in one hand, compounded with primary
18079 expressions doing string concatenation).
18085 Would return "A.B.C[]" as a SimpleName. This stopped things like
18086 using clauses from working on this particular context. And a type
18087 was being matched directly against "A.B.C[]".
18089 We now use the correct approach, and allow for ComposedCast to be
18090 part of the unary expression. So the "A.B.C []" become a composed
18091 cast of "A.B.C" (as a nested group of MemberAccess with a
18092 SimpleName at the end) plus the rank composition "[]".
18096 2003-04-10 Miguel de Icaza <miguel@ximian.com>
18098 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
18099 for the access level checking.
18101 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
18102 `TypeContainer container', because I kept getting confused when I
18103 was debugging this code.
18105 * expression.cs (Indexers): Instead of tracking getters/setters,
18106 we now track them in parallel. We create one arraylist less, but
18107 most importantly it is possible now for the LValue code to find a
18108 matching get for a set.
18110 (IndexerAccess.DoResolveLValue): Update the code.
18111 GetIndexersForType has been modified already to extract all the
18112 indexers from a type. The code assumed it did not.
18114 Also make the code set the correct return type for the indexer.
18115 This was fixed a long time ago for properties, but was missing for
18116 indexers. It used to be void_type.
18118 (Binary.Emit): Test first for doubles instead of
18119 floats, as they are more common.
18121 (Binary.EmitBranchable): Use the .un version of the branch opcodes
18122 when dealing with floats and the <=, >= operators. This fixes bug
18125 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
18126 to load the array value by emitting a load on the foreach variable
18127 type. This was incorrect.
18129 We now emit the code to load an element using the the array
18130 variable type, and then we emit the conversion operator.
18134 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
18136 * attribute.cs: Avoid allocation of ArrayLists in the common case.
18138 2003-04-09 Miguel de Icaza <miguel@ximian.com>
18140 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
18141 test for protection before we test for signatures.
18143 (MethodSignature.ToString): implement.
18145 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
18146 to the case where we reduced into a LongConstant.
18148 * decl.cs (CheckAccessLevel): If the type is an array, we can not
18149 depend on whether the information is acurrate, because the
18150 Microsoft runtime will always claim that the array type is public,
18151 regardless of the real state.
18153 If the type is a pointer, another problem happens: the type is
18154 reported as non-public in Microsoft.
18156 In both cases we have to call CheckAccessLevel recursively with
18157 the underlying type as the argument to be tested.
18159 2003-04-08 Miguel de Icaza <miguel@ximian.com>
18161 * assign.cs (Assign.Emit): If we are dealing with a compound
18162 assignment expression, we should use the code path that stores the
18163 intermediate result in a temporary value. This fixes #40903.
18165 *expression.cs (Indirection.ToString): Provide ToString method for
18168 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
18170 * class.cs: Null out fields holding references to Block objects so
18171 they can be garbage collected.
18173 * expression.cs (OverloadResolve): Remove unused local.
18175 2003-04-07 Martin Baulig <martin@ximian.com>
18177 * codegen.cs (EmitContext.CurrentFile): New public field.
18178 (EmitContext.Mark): Use the CurrentFile to check whether the
18179 location is in the correct file.
18180 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
18182 2003-04-07 Martin Baulig <martin@ximian.com>
18184 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
18186 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
18187 location. [FIXME: The location argument which gets passed to this
18188 method is sometimes wrong!]
18190 2003-04-07 Nick Drochak <ndrochak@gol.com>
18192 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
18194 2003-04-07 Miguel de Icaza <miguel@ximian.com>
18196 * expression.cs (Indirection.EmitAssign): We were using the
18197 temporary, but returning immediately instead of continuing the
18200 2003-04-06 Martin Baulig <martin@ximian.com>
18202 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
18203 if it's a nested child, but also deriving from the outer class.
18206 * typemanager.cs (IsNestedChildOf): Make this work if it's a
18207 nested child, but also deriving from the outer class. See
18209 (FilterWithClosure): We may access private members of the outer
18210 class if we're a nested child and deriving from the outer class.
18211 (RealMemberLookup): Only set `closure_private_ok' if the
18212 `original_bf' contained BindingFlags.NonPublic.
18214 2003-04-05 Martin Baulig <martin@ximian.com>
18216 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
18218 2003-04-02 Miguel de Icaza <miguel@ximian.com>
18220 * class.cs (Event.Define): Do not allow abstract events to have
18223 2003-04-01 Miguel de Icaza <miguel@ximian.com>
18225 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
18226 block in event declarations.
18228 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
18229 value type, get its address.
18231 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
18232 leaving a class on the stack instead of a boolean value (int
18233 0/1). Change the code so we compare against null, and then the
18234 result against zero.
18236 * class.cs (TypeContainer.GetClassBases): We were checking for the
18237 parent class being sealed too late.
18239 * expression.cs (Binary.Emit): For <= and >= when dealing with
18240 floating point values, use cgt.un and clt.un instead of cgt and
18243 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
18245 * statement.cs: Apply the same optimization as MS: skip the
18246 GetEnumerator returning an IEnumerator, and use the one returning a
18247 CharEnumerator instead. This allows us to avoid the try-finally block
18250 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
18252 * cs-parser.jay: Attributes cannot be applied to
18253 namespaces. Fixes #40473
18255 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18258 (Add*): check if the name is valid using the full name for constants,
18259 fields, properties and events.
18261 2003-03-28 Miguel de Icaza <miguel@ximian.com>
18263 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
18264 char constants to be part of the enumeration.
18266 * expression.cs (Conditional.DoResolve): Add support for operator
18267 true. Implements the missing functionality from 14.12
18269 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
18270 operator true/false as required by the spec.
18272 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
18273 implicit conversion to boolean.
18275 * statement.cs (Statement.ResolveBoolean): A boolean expression is
18276 also one where the type implements `operator true'.
18278 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
18279 get an expression that will invoke operator true based on an
18282 (GetConversionOperators): Removed the hack that called op_True
18285 (Expression.ResolveBoolean): Move this from Statement.
18287 2003-03-17 Miguel de Icaza <miguel@ximian.com>
18289 * ecore.cs (FieldExpr): do not allow initialization of initonly
18290 fields on derived classes
18292 2003-03-13 Martin Baulig <martin@ximian.com>
18294 * statement.cs (Block.Emit): Call ig.BeginScope() and
18295 ig.EndScope() when compiling with debugging info; call
18296 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
18298 2003-03-08 Miguel de Icaza <miguel@ximian.com>
18300 * expression.cs (Indexers): Do not construct immediately, allow
18301 for new members to be appended as we go. Fixes 38143
18303 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18305 * expression.cs: save/restore context when resolving an unchecked
18308 2003-03-05 Miguel de Icaza <miguel@ximian.com>
18310 * cfold.cs: Catch division by zero in modulus operator during
18313 2003-03-03 Miguel de Icaza <miguel@ximian.com>
18315 * interface.cs (Interface.DefineMembers): Avoid defining members
18318 2003-02-27 Miguel de Icaza <miguel@ximian.com>
18320 * driver.cs: handle the +/- options for -noconfig
18322 * statement.cs (Unckeched.Resolve): Also track the state of
18323 unchecked in the Resolve phase.
18325 2003-02-27 Martin Baulig <martin@ximian.com>
18327 * ecore.cs (Expression.MemberLookup): Don't create a
18328 MethodGroupExpr for something which is not a method. Fixes #38291.
18330 2003-02-25 Miguel de Icaza <miguel@ximian.com>
18332 * class.cs (MemberBase.CheckParameters): Also check that the type
18333 is unmanaged if it is a pointer.
18335 * expression.cs (SizeOf.Resolve): Add location information.
18337 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
18338 a managed type is declared.
18340 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
18341 parameter modifiers as well. Fixes bug 38606
18343 * class.cs: Very sad. Am backing out the speed up changes
18344 introduced by the ArrayList -> Array in the TypeContainer, as they
18345 were not actually that much faster, and introduced a bug (no error
18346 reports on duplicated methods).
18348 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
18349 source first, this will guarantee that we have a valid expression
18350 before calling in lower levels functions that will require a
18351 resolved object. Then use this original_source in the
18352 target.ResolveLValue instead of the original source that was
18355 Another change. Use target.Resolve instead of LValueResolve.
18356 Although we are resolving for LValues, we will let the Assign code
18357 take care of that (it will be called again from Resolve). This
18358 basically allows code like this:
18360 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
18361 class Y { void A (X x) { x [0] += o; }
18363 The problem was that the indexer was trying to resolve for
18364 set_Item (idx, object o) and never finding one. The real set_Item
18365 was set_Item (idx, X). By delaying the process we get the right
18370 2003-02-23 Martin Baulig <martin@ximian.com>
18372 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
18373 while calling DoEmit ().
18375 * codegen.cs (EmitContext.Mark): Don't mark locations in other
18376 source files; if you use the #line directive inside a method, the
18377 compiler stops emitting line numbers for the debugger until it
18378 reaches the end of the method or another #line directive which
18379 restores the original file.
18381 2003-02-23 Martin Baulig <martin@ximian.com>
18383 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
18385 2003-02-23 Martin Baulig <martin@ximian.com>
18387 * statement.cs (Block.AddChildVariableNames): We need to call this
18388 recursively, not just for our immediate children.
18390 2003-02-23 Martin Baulig <martin@ximian.com>
18392 * class.cs (Event.Define): Always make the field private, like csc does.
18394 * typemanager.cs (TypeManager.RealMemberLookup): Make events
18395 actually work, fixes bug #37521.
18397 2003-02-23 Miguel de Icaza <miguel@ximian.com>
18399 * delegate.cs: When creating the various temporary "Parameters"
18400 classes, make sure that we call the ComputeAndDefineParameterTypes
18401 on those new parameters (just like we do with the formal ones), to
18402 allow them to be resolved in the context of the DeclSpace.
18404 This fixes the bug that Dick observed in Bugzilla #38530.
18406 2003-02-22 Miguel de Icaza <miguel@ximian.com>
18408 * expression.cs (ResolveMemberAccess): When resolving a constant,
18409 do not attempt to pull a constant if the value was not able to
18410 generate a valid constant.
18412 * const.cs (LookupConstantValue): Do not report more errors than required.
18414 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18416 * expression.cs: fixes bug #38328.
18418 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18420 * class.cs: Changed all the various members that can be part of a
18421 class from being an ArrayList to be an Array of the right type.
18422 During the DefineType type_list, interface_list, delegate_list and
18423 enum_list are turned into types, interfaces, delegates and enums
18426 And during the member population, indexer_list, event_list,
18427 constant_list, field_list, instance_constructor_list, method_list,
18428 operator_list and property_list are turned into their real arrays.
18430 Although we could probably perform this operation earlier, for
18431 good error reporting we need to keep the lists and remove the
18432 lists for longer than required.
18434 This optimization was triggered by Paolo profiling the compiler
18435 speed on the output of `gen-sample-program.pl' perl script.
18437 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
18438 not crash in methods like MemberLookupFailed that use this field.
18440 This problem arises when the compiler fails to resolve a type
18441 during interface type definition for example.
18443 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18445 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
18446 inherit from System.Object, so we have to stop at null, not only
18447 when reaching System.Object.
18449 2003-02-17 Miguel de Icaza <miguel@ximian.com>
18451 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
18452 DeclaredOnly because the parent indexer might have had a different
18453 name, but did not loop until the top of the hierarchy was reached.
18455 The problem this one fixes is 35492: when a class implemented an
18456 indexer from an interface, we were getting the interface method
18457 (which was abstract) and we were flagging an error (can not invoke
18460 This also keeps bug 33089 functioning, and test-148 functioning.
18462 * typemanager.cs (IsSpecialMethod): The correct way of figuring
18463 out if a method is special is to see if it is declared in a
18464 property or event, or whether it is one of the predefined operator
18465 names. This should fix correctly #36804.
18467 2003-02-15 Miguel de Icaza <miguel@ximian.com>
18469 The goal here is to remove the dependency on EmptyCast.Peel ().
18470 Killing it completely.
18472 The problem is that currently in a number of places where
18473 constants are expected, we have to "probe" for an EmptyCast, and
18474 Peel, which is not the correct thing to do, as this will be
18475 repetitive and will likely lead to errors.
18477 The idea is to remove any EmptyCasts that are used in casts that
18478 can be reduced to constants, so we only have to cope with
18481 This bug hunt was triggered by Bug 37363 and the desire to remove
18482 the duplicate pattern where we were "peeling" emptycasts to check
18483 whether they were constants. Now constants will always be
18486 * ecore.cs: Use an enumconstant here instead of wrapping with
18489 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
18490 throwing me off. By handling this we can get rid of a few hacks.
18492 * statement.cs (Switch): Removed Peel() code.
18494 2003-02-14 Miguel de Icaza <miguel@ximian.com>
18496 * class.cs: Location information for error 508
18498 * expression.cs (New.DoResolve): Add a guard against double
18499 resolution of an expression.
18501 The New DoResolve might be called twice when initializing field
18502 expressions (see EmitFieldInitializers, the call to
18503 GetInitializerExpression will perform a resolve on the expression,
18504 and later the assign will trigger another resolution
18506 This leads to bugs (#37014)
18508 * delegate.cs: The signature for EndInvoke should contain any ref
18509 or out parameters as well. We were not doing this in the past.
18511 * class.cs (Field.Define): Do not overwrite the type definition
18512 inside the `volatile' group. Turns out that volatile enumerations
18513 were changing the type here to perform a validity test, which
18516 2003-02-12 Miguel de Icaza <miguel@ximian.com>
18518 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
18519 and structs, we do not want to load the instance variable
18521 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
18522 enum_type has to be handled like an object reference (implicit
18523 conversions exists from this to object), but the regular IsClass
18524 and IsValueType tests will never return true for this one.
18526 Also we use TypeManager.IsValueType instead of type.IsValueType,
18527 just for consistency with the rest of the code (this is only
18528 needed if we ever use the construct exposed by test-180.cs inside
18529 corlib, which we dont today).
18531 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
18533 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
18536 2003-02-09 Martin Baulig <martin@ximian.com>
18538 * namespace.cs (Namespace..ctor): Added SourceFile argument.
18539 (Namespace.DefineNamespaces): New static public method; this is
18540 called when we're compiling with debugging to add all namespaces
18541 to the symbol file.
18543 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
18544 pass it to the Namespace's .ctor.
18546 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
18547 and MethodBase arguments; pass the namespace ID to the symwriter;
18548 pass the MethodBase instead of the token to the symwriter.
18549 (SymbolWriter.DefineNamespace): New method to add a namespace to
18552 2003-02-09 Martin Baulig <martin@ximian.com>
18554 * symbolwriter.cs: New file. This is a wrapper around
18555 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
18556 methods here in near future.
18558 2003-02-09 Martin Baulig <martin@ximian.com>
18560 * codegen.cs (EmitContext.Mark): Just pass the arguments to
18561 ILGenerator.MarkSequencePoint() which are actually used by the
18564 2003-02-09 Martin Baulig <martin@ximian.com>
18566 * location.cs (SourceFile): New public sealed class. This
18567 contains the name and an index which is used in the location's token.
18568 (Location): Reserve an appropriate number of bits in the token for
18569 the source file instead of walking over that list, this gives us a
18570 really huge performance improvement when compiling with debugging.
18572 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
18573 `SourceFile' argument instead of a string.
18574 (Driver.ProcessFile): Add all the files via Location.AddFile(),
18575 but don't parse/tokenize here, we need to generate the list of all
18576 source files before we do that.
18577 (Driver.ProcessFiles): New static function. Parses/tokenizes all
18580 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
18581 instead of a string.
18583 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
18586 2003-02-09 Martin Baulig <martin@ximian.com>
18588 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
18589 filename on `#line default'.
18591 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
18593 * statement.cs: don't clear the pinned var when the fixed statement
18594 returns from the method (fixes bug#37752).
18596 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
18598 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
18601 2003-02-07 Martin Baulig <martin@ximian.com>
18603 * driver.cs: Removed the `--debug-args' command line argument.
18605 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
18606 automatically by the AsssemblyBuilder.
18607 (CodeGen.InitializeSymbolWriter): We don't need to call any
18608 initialization function on the symbol writer anymore. This method
18609 doesn't take any arguments.
18611 2003-02-03 Miguel de Icaza <miguel@ximian.com>
18613 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
18614 from referenced assemblies as well.
18616 2003-02-02 Martin Baulig <martin@ximian.com>
18618 * class.cs (MethodData.Emit): Generate debugging info for external methods.
18620 2003-02-02 Martin Baulig <martin@ximian.com>
18622 * class.cs (Constructor.Emit): Open the symbol writer before
18623 emitting the constructor initializer.
18624 (ConstructorInitializer.Emit): Call ec.Mark() to allow
18625 single-stepping through constructor initializers.
18627 2003-01-30 Miguel de Icaza <miguel@ximian.com>
18629 * class.cs: Handle error 549: do not allow virtual methods in
18632 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
18634 * decl.cs: Check access levels when resolving types
18636 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
18638 * statement.cs: Add parameters and locals set in catch blocks that might
18639 return to set vector
18641 2003-01-29 Miguel de Icaza <miguel@ximian.com>
18643 * class.cs (Operator): Set the SpecialName flags for operators.
18645 * expression.cs (Invocation.DoResolve): Only block calls to
18646 accessors and operators on SpecialName methods.
18648 (Cast.TryReduce): Handle conversions from char constants.
18651 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
18653 * statement.cs: small memory and time optimization in FlowBranching.
18655 2003-01-28 Pedro Mart <yoros@wanadoo.es>
18657 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
18658 problem that the last fix but in the other sid (Set).
18660 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
18661 access when there is no indexer in the hierarchy.
18663 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
18665 * class.cs: Combine some if statements.
18667 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18669 * driver.cs: fixed bug #37187.
18671 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
18673 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
18674 any indexer, it's needed to build a list with all the indexers in the
18675 hierarchy (AllGetters), else we have problems. Fixes #35653.
18677 2003-01-23 Miguel de Icaza <miguel@ximian.com>
18679 * class.cs (MethodData.Define): It is wrong for an interface
18680 implementation to be static in both cases: explicit and implicit.
18681 We were only handling this in one case.
18683 Improve the if situation there to not have negations.
18685 * class.cs (Field.Define): Turns out that we do not need to check
18686 the unsafe bit on field definition, only on usage. Remove the test.
18688 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18690 * driver.cs: use assembly.Location instead of Codebase (the latest
18691 patch made mcs fail when using MS assemblies).
18693 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
18695 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
18696 get the path to *corlib.dll.
18698 2003-01-21 Nick Drochak <ndrochak@gol.com>
18702 * typemanager.cs: Remove compiler warnings
18704 2003-01-20 Duncan Mak <duncan@ximian.com>
18706 * AssemblyInfo.cs: Bump the version number to 0.19.
18708 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18710 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
18712 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
18714 * class.cs (Constructor::Emit): Emit debugging info for constructors.
18716 2003-01-17 Miguel de Icaza <miguel@ximian.com>
18718 * cs-parser.jay: Small fix: we were not comparing the constructor
18719 name correctly. Thanks to Zoltan for the initial pointer.
18721 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
18723 * cs-tokenizer.cs: Set file name when specified with #line
18725 2003-01-15 Miguel de Icaza <miguel@ximian.com>
18727 * cs-parser.jay: Only perform the constructor checks here if we
18728 are named like the class; This will help provider a better
18729 error. The constructor path is taken when a type definition is
18730 not found, but most likely the user forgot to add the type, so
18731 report that rather than the constructor error.
18733 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
18735 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
18738 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18740 * cs-parser.jay: Add cleanup call.
18742 2003-01-13 Duncan Mak <duncan@ximian.com>
18744 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
18745 consistent with other methods.
18747 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18749 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
18751 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
18753 * attribute.cs: only set GuidAttr to true when we have a
18756 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18760 * typemanager.cs: fixes to allow mcs compile corlib with the new
18761 Type.IsSubclassOf fix.
18763 2003-01-08 Miguel de Icaza <miguel@ximian.com>
18765 * expression.cs (LocalVariableReference.DoResolve): Classify a
18766 constant as a value, not as a variable. Also, set the type for
18769 * cs-parser.jay (fixed_statement): take a type instead of a
18770 pointer_type, so we can produce a better error message later.
18772 * statement.cs (Fixed.Resolve): Flag types that are not pointers
18775 (For.DoEmit): Make inifinite loops have a
18776 non-conditional branch back.
18778 (Fixed.DoEmit): First populate the pinned variables, then emit the
18779 statement, then clear the variables. Before I was emitting the
18780 code once for each fixed piece.
18783 2003-01-08 Martin Baulig <martin@ximian.com>
18785 * statement.cs (FlowBranching.MergeChild): A break in a
18786 SWITCH_SECTION does not leave a loop. Fixes #36155.
18788 2003-01-08 Martin Baulig <martin@ximian.com>
18790 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
18791 lives in the same number space than `param_map'. Fixes #36154.
18793 2003-01-07 Miguel de Icaza <miguel@ximian.com>
18795 * cs-parser.jay (constructor_declaration): Set the
18796 Constructor.ModFlags before probing for it. This makes the
18797 compiler report 514, 515 and 132 (the code was there, but got
18800 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
18801 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
18802 (GotoCase.Resolve): Set `Returns' to ALWAYS.
18804 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
18806 * enum.cs: create the enum static fields using the enum type.
18808 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
18810 * class.cs: don't try to create the ParamBuilder for the return
18811 type if it's not needed (and handle it breaking for the ms runtime
18814 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
18816 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
18818 2002-12-29 Miguel de Icaza <miguel@ximian.com>
18820 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
18821 the command. This showed up while compiling the JANET source
18822 code, which used \r as its only newline separator.
18824 2002-12-28 Miguel de Icaza <miguel@ximian.com>
18826 * class.cs (Method.Define): If we are an operator (because it
18827 reuses our code), then set the SpecialName and HideBySig. #36128
18829 2002-12-22 Miguel de Icaza <miguel@ximian.com>
18831 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
18832 exception, report error 120 `object reference required'.
18834 * driver.cs: Add --pause option, used during to measure the size
18835 of the process as it goes with --timestamp.
18837 * expression.cs (Invocation.DoResolve): Do not allow methods with
18838 SpecialName to be invoked.
18840 2002-12-21 Miguel de Icaza <miguel@ximian.com>
18842 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
18843 number before adding it.
18845 2002-12-21 Ravi Pratap <ravi@ximian.com>
18847 * ecore.cs (StandardImplicitConversion): When in an unsafe
18848 context, we allow conversion between void * to any other pointer
18849 type. This fixes bug #35973.
18851 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
18853 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
18854 is not thrown when extensionless outputs are used
18856 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18858 * rootcontext.cs: fixed compilation of corlib.
18860 2002-12-19 Miguel de Icaza <miguel@ximian.com>
18862 * attribute.cs (Attributes.Contains): Add new method.
18864 * class.cs (MethodCore.LabelParameters): if the parameter is an
18865 `out' parameter, check that no attribute `[In]' has been passed.
18867 * enum.cs: Handle the `value__' name in an enumeration.
18869 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
18871 * decl.cs: Added special case to allow overrides on "protected
18874 2002-12-18 Ravi Pratap <ravi@ximian.com>
18876 * attribute.cs (Attributes.AddAttributeSection): Rename to this
18877 since it makes much more sense.
18879 (Attributes.ctor): Don't require a Location parameter.
18881 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
18883 * attribute.cs (ApplyAttributes): Remove extra Location parameters
18884 since we already have that information per attribute.
18886 * everywhere : make appropriate changes.
18888 * class.cs (LabelParameters): Write the code which actually
18889 applies attributes to the return type. We can't do this on the MS
18890 .NET runtime so we flag a warning in the case an exception is
18893 2002-12-18 Miguel de Icaza <miguel@ximian.com>
18895 * const.cs: Handle implicit null conversions here too.
18897 2002-12-17 Ravi Pratap <ravi@ximian.com>
18899 * class.cs (MethodCore.LabelParameters): Remove the extra
18900 Type [] parameter since it is completely unnecessary. Instead
18901 pass in the method's attributes so that we can extract
18902 the "return" attribute.
18904 2002-12-17 Miguel de Icaza <miguel@ximian.com>
18906 * cs-parser.jay (parse): Use Report.Error to flag errors instead
18907 of ignoring it and letting the compile continue.
18909 * typemanager.cs (ChangeType): use an extra argument to return an
18910 error condition instead of throwing an exception.
18912 2002-12-15 Miguel de Icaza <miguel@ximian.com>
18914 * expression.cs (Unary.TryReduce): mimic the code for the regular
18915 code path. Perform an implicit cast in the cases where we can
18916 implicitly convert to one of the integral types, and then reduce
18917 based on that constant. This fixes bug #35483.
18919 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18921 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
18923 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18925 * namespace.cs: fixed bug #35489.
18927 2002-12-12 Miguel de Icaza <miguel@ximian.com>
18929 * class.cs: Remove some dead code.
18931 * cs-parser.jay: Estimate the number of methods needed
18932 (RootContext.MethodCount);
18934 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
18935 numbers instead of StringBuilders.
18937 * support.cs (PtrHashtable): Add constructor with initial size;
18938 We can now reduce reallocations of the method table.
18940 2002-12-10 Ravi Pratap <ravi@ximian.com>
18942 * attribute.cs (ApplyAttributes): Keep track of the emitted
18943 attributes on a per-target basis. This fixes bug #35413.
18945 2002-12-10 Miguel de Icaza <miguel@ximian.com>
18947 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
18948 default to the Windows 1252 encoding.
18950 (UnixParseOption): Support version, thanks to Alp for the missing
18953 * AssemblyInfo.cs: Add nice assembly information.
18955 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
18958 * cs-parser.jay: Allow a trailing comma before the close bracked
18959 in the attribute_section production.
18961 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
18962 address of the instance was being taken, I will take this out,
18963 because we take the address of the object immediately here.
18965 2002-12-09 Ravi Pratap <ravi@ximian.com>
18967 * typemanager.cs (AreMultipleAllowed): Take care of the most
18968 obvious case where attribute type is not in the current assembly -
18971 2002-12-08 Miguel de Icaza <miguel@ximian.com>
18973 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
18974 definitions, instead of doing that afterwards.
18976 Also we use a nice little hack, depending on the constructor, we
18977 know if we are a "composed" name or a simple name. Hence, we
18978 avoid the IndexOf test, and we avoid
18980 * codegen.cs: Add code to assist in a bug reporter to track down
18981 the source of a compiler crash.
18983 2002-12-07 Ravi Pratap <ravi@ximian.com>
18985 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
18986 types have been emitted for a given element and flag an error
18987 if something which does not have AllowMultiple set is used more
18990 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
18991 attribute types and their corresponding AllowMultiple properties
18993 (AreMultipleAllowed): Check the property for a given type.
18995 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
18996 property in the case we have a TypeContainer.
18998 (Attributes.AddAttribute): Detect duplicates and just skip on
18999 adding them. This trivial fix catches a pretty gross error in our
19000 attribute emission - global attributes were being emitted twice!
19002 Bugzilla bug #33187 is now fixed.
19004 2002-12-06 Miguel de Icaza <miguel@ximian.com>
19006 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
19007 instead of pp_and).
19009 * expression.cs (Binary.ResolveOperator): I can only use the
19010 Concat (string, string, string) and Concat (string, string,
19011 string, string) if the child is actually a concatenation of
19014 2002-12-04 Miguel de Icaza <miguel@ximian.com>
19016 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
19017 context where we need a 2-character lookahead.
19019 * pending.cs (PendingImplementation): Rework so we can keep track
19020 of interface types all the time, and flag those which were
19021 implemented by parents as optional.
19023 2002-12-03 Miguel de Icaza <miguel@ximian.com>
19025 * expression.cs (Binary.ResolveOperator): Use
19026 String.Concat(string,string,string) or
19027 String.Concat(string,string,string,string) when possible.
19029 * typemanager: More helper methods.
19032 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
19034 * pending.cs: remove the bogus return from GetMissingInterfaces()
19035 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
19037 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19039 * namespace.cs: avoid duplicated 'using xxx' being added to
19040 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
19041 when we get more than one 'using' statement for the same namespace.
19042 Report a CS0105 warning for it.
19044 2002-11-30 Miguel de Icaza <miguel@ximian.com>
19046 * cs-tokenizer.cs (consume_identifier): use read directly, instead
19047 of calling getChar/putback, uses internal knowledge of it.
19049 (xtoken): Reorder tokenizer so most common patterns are checked
19050 first. This reduces the compilation time in another 5% (from 8.11s
19051 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
19053 The parsing time is 22% of the compilation in mcs, and from that
19054 64% is spent on the tokenization process.
19056 I tried using a binary search for keywords, but this is slower
19057 than the hashtable. Another option would be to do a couple of
19060 * Not use a StringBuilder, instead use an array of chars,
19061 with a set value. Notice that this way we could catch
19062 the 645 error without having to do it *afterwards*.
19064 * We could write a hand-parser to avoid the hashtable
19065 compares altogether.
19067 The identifier consumption process takes 37% of the tokenization
19068 time. Another 15% is spent on is_number. 56% of the time spent
19069 on is_number is spent on Int64.Parse:
19071 * We could probably choose based on the string length to
19072 use Int32.Parse or Int64.Parse and avoid all the 64-bit
19075 Another 3% is spend on wrapping `xtoken' in the `token' function.
19077 Handle 0xa0 as whitespace (#34752)
19079 2002-11-26 Miguel de Icaza <miguel@ximian.com>
19081 * typemanager.cs (IsCLRType): New routine to tell whether a type
19082 is one of the builtin types.
19084 Maybe it needs to use TypeCodes to be faster. Maybe we could use
19085 typecode in more places instead of doing pointer comparissions.
19086 We could leverage some knowledge about the way the typecodes are
19089 New code to cache namespaces in assemblies, it is currently not
19090 invoked, to be used soon.
19092 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
19094 * expression.cs (Binary.ResolveOperator): specially handle
19095 strings, and do not perform user-defined operator overloading for
19098 2002-11-24 Miguel de Icaza <miguel@ximian.com>
19100 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
19101 internalcall as it is a pretty simple operation; Avoid whenever
19102 possible to call Char.IsLetter.
19104 (consume_identifier): Cut by half the number of
19105 hashtable calls by merging the is_keyword and GetKeyword behavior.
19107 Do not short-circuit, because if we do, we
19108 report errors (ie, #if false && true would produce an invalid
19112 2002-11-24 Martin Baulig <martin@ximian.com>
19114 * expression.cs (Cast.TryReduce): If we're in checked syntax,
19115 check constant ranges and report a CS0221. Fixes #33186.
19117 2002-11-24 Martin Baulig <martin@ximian.com>
19119 * cs-parser.jay: Make this work for uninitialized variable
19120 declarations in the `for' initializer. Fixes #32416.
19122 2002-11-24 Martin Baulig <martin@ximian.com>
19124 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
19125 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
19127 2002-11-24 Martin Baulig <martin@ximian.com>
19129 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
19130 argument; if true, we also check for user-defined conversions.
19131 This is only needed if both arguments are of a user-defined type.
19132 Fixes #30443, added test-175.cs.
19133 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
19135 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
19137 2002-11-24 Martin Baulig <martin@ximian.com>
19139 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
19140 function to get the store opcode.
19141 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
19142 only emit the Ldelema if the store opcode is Stobj. You must run
19143 both test-34 and test-167 to test this. Fixes #34529.
19145 2002-11-23 Martin Baulig <martin@ximian.com>
19147 * ecore.cs (Expression.MemberLookup): Added additional
19148 `qualifier_type' argument which is used when we're being called
19149 from MemberAccess.DoResolve() and null if we're called from a
19151 (Expression.MemberLookupFailed): New method to report errors; this
19152 does the CS1540 check and reports the correct error message.
19154 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
19155 argument for the CS1540 check and redone the way how we're dealing
19156 with private members. See the comment in the source code for details.
19157 (FilterWithClosure): Reverted this back to revision 1.197; renamed
19158 `closure_start_type' to `closure_qualifier_type' and check whether
19159 it's not null. It was not this filter being broken, it was just
19160 being called with the wrong arguments.
19162 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
19163 and pass it the correct `qualifier_type'; this also does the error
19166 2002-11-22 Miguel de Icaza <miguel@ximian.com>
19168 * expression.cs (Invocation.EmitParams): If the we are dealing
19169 with a non-built-in value type, load its address as well.
19171 (ArrayCreation): Use a a pretty constant instead
19172 of the hardcoded value 2. Use 6 instead of 2 for the number of
19173 static initializers.
19175 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
19176 because they are not really value types, just glorified integers.
19178 * driver.cs: Do not append .exe, the CSC compiler does not do it.
19180 * ecore.cs: Remove redundant code for enumerations, make them use
19181 the same code path as everything else, fixes the casting issue
19182 with enumerations in Windows.Forms.
19184 * attribute.cs: Do only cast to string if it is a string, the
19185 validation happens later.
19187 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
19188 people upgrade their corlibs.
19190 * ecore.cs: Oops, enumerations were not following the entire code path
19192 2002-11-21 Miguel de Icaza <miguel@ximian.com>
19194 * typemanager.cs (FilterWithClosure): Commented out the test for
19195 1540 in typemanager.cs, as it has problems when accessing
19196 protected methods from a parent class (see test-174.cs).
19198 * attribute.cs (Attribute.ValidateGuid): new method.
19199 (Attribute.Resolve): Use above.
19201 2002-11-19 Miguel de Icaza <miguel@ximian.com>
19203 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
19205 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
19206 handling for enumerations, as we only needed the TypeContainer
19207 functionality to begin with (this is required for the fix below to
19208 work for enums that reference constants in a container class for
19211 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
19213 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
19214 a valid TypeBuilder to perform lookups on.o
19216 * class.cs (InheritableMemberSignatureCompare): Use true in the
19217 call to GetGetMethod and GetSetMethod, because we are comparing
19218 the signature, and we need to get the methods *even* if they are
19221 (PropertyBase.CheckBase): ditto.
19223 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
19224 GotoCase.Resolve): Use Peel on EmpytCasts.
19226 * ecore.cs (EmptyCast): drop child, add Peel method.
19228 2002-11-17 Martin Baulig <martin@ximian.com>
19230 * ecore.cs (EmptyCast.Child): New public property.
19232 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
19233 label resolved to an EmptyCast. Fixes #34162.
19234 (GotoCase.Resolve): Likewise.
19235 (Block.EmitMeta): Likewise.
19237 2002-11-17 Martin Baulig <martin@ximian.com>
19239 * expression.cs (Invocation.BetterConversion): Prefer int over
19240 uint; short over ushort; long over ulong for integer literals.
19241 Use ImplicitConversionExists instead of StandardConversionExists
19242 since we also need to check for user-defined implicit conversions.
19243 Fixes #34165. Added test-173.cs.
19245 2002-11-16 Martin Baulig <martin@ximian.com>
19247 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
19248 with the `true' and `false' literals. Fixes #33151.
19250 2002-11-16 Martin Baulig <martin@ximian.com>
19252 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
19253 October 22nd; don't do the cs1540 check for static members.
19255 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
19256 now using our own filter here and doing the cs1540 check again.
19258 2002-11-16 Martin Baulig <martin@ximian.com>
19260 * support.cs (InternalParameters): Don't crash if we don't have
19261 any fixed parameters. Fixes #33532.
19263 2002-11-16 Martin Baulig <martin@ximian.com>
19265 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
19266 when looking up static methods to make this work on Windows.
19269 2002-11-16 Martin Baulig <martin@ximian.com>
19271 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
19272 a setter rather than using PropertyInfo.CanWrite.
19274 2002-11-15 Nick Drochak <ndrochak@gol.com>
19276 * class.cs: Allow acces to block member by subclasses. Fixes build
19279 2002-11-14 Martin Baulig <martin@ximian.com>
19281 * class.cs (Constructor.Emit): Added the extern/block check.
19284 2002-11-14 Martin Baulig <martin@ximian.com>
19286 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
19287 iteration while looking for indexers, this is needed because the
19288 indexer may have a different name in our base classes. Fixed the
19289 error reporting (no indexers at all, not get accessor, no
19290 overloaded match). Fixes bug #33089.
19291 (IndexerAccess.DoResolveLValue): Likewise.
19293 2002-11-14 Martin Baulig <martin@ximian.com>
19295 * class.cs (PropertyBase.CheckBase): Make this work for multiple
19296 indexers. Fixes the first part of bug #33089.
19297 (MethodSignature.InheritableMemberSignatureCompare): Added support
19300 2002-11-13 Ravi Pratap <ravi@ximian.com>
19302 * attribute.cs (Attribute.Resolve): Catch the
19303 NullReferenceException and report it since it isn't supposed to
19306 2002-11-12 Miguel de Icaza <miguel@ximian.com>
19308 * expression.cs (Binary.EmitBranchable): Also handle the cases for
19309 LogicalOr and LogicalAnd that can benefit from recursively
19310 handling EmitBranchable. The code now should be nice for Paolo.
19312 2002-11-08 Miguel de Icaza <miguel@ximian.com>
19314 * typemanager.cs (LookupType): Added a negative-hit hashtable for
19315 the Type lookups, as we perform quite a number of lookups on
19316 non-Types. This can be removed once we can deterministically tell
19317 whether we have a type or a namespace in advance.
19319 But this might require special hacks from our corlib.
19323 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
19324 and double which avoids a conversion from an integer to a double.
19326 * expression.cs: tiny optimization, avoid calling IsConstant,
19327 because it effectively performs the lookup twice.
19329 2002-11-06 Miguel de Icaza <miguel@ximian.com>
19331 But a bogus return here to keep the semantics of the old code
19332 until the Mono runtime is fixed.
19334 * pending.cs (GetMissingInterfaces): New method used to remove all
19335 the interfaces that are already implemented by our parent
19336 classes from the list of pending methods.
19338 * interface.cs: Add checks for calls after ResolveTypeExpr.
19340 2002-11-05 Miguel de Icaza <miguel@ximian.com>
19342 * class.cs (Class.Emit): Report warning 67: event not used if the
19343 warning level is beyond 3.
19345 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
19346 being a NullLiteral.
19348 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
19351 * class.cs (TypeContainer.GetClassBases): Cover a missing code
19352 path that might fail if a type can not be resolved.
19354 * expression.cs (Binary.Emit): Emit unsigned versions of the
19357 * driver.cs: use error 5.
19359 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
19361 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
19363 2002-11-01 Miguel de Icaza <miguel@ximian.com>
19365 * cs-parser.jay (switch_section): A beautiful patch from Martin
19366 Baulig that fixed 33094.
19368 2002-10-31 Miguel de Icaza <miguel@ximian.com>
19370 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
19371 Check whether the base is abstract and report an error if so.
19373 * expression.cs (IndexerAccess.DoResolveLValue,
19374 IndexerAccess.DoResolve): ditto.
19376 (Invocation.DoResolve): ditto.
19378 (Invocation.FullMethodDesc): Improve the report string.
19380 * statement.cs (Block): Eliminate IsVariableDefined as it is
19381 basically just a wrapper for GetVariableInfo.
19383 * ecore.cs (SimpleName): Use new
19385 * support.cs (ReflectionParamter.ParameterType): We unwrap the
19386 type, as we return the actual parameter ref/unref state on a
19389 2002-10-30 Miguel de Icaza <miguel@ximian.com>
19391 * support.cs: Return proper flags REF/OUT fixing the previous
19394 * expression.cs: Reverted last patch, that was wrong. Is_ref is
19395 not used to mean `ref' but `ref or out' in ParameterReference
19397 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
19398 full type signature instead of calling TypeManger.CSharpName
19401 * support.cs (InternalParameters.ParameterDesc): Do not compare
19402 directly to the modflags, because REF/OUT will actually be bitsets
19405 * delegate.cs (VerifyMethod): Check also the modifiers.
19407 * cs-tokenizer.cs: Fix bug where floating point values with an
19408 exponent where a sign was missing was ignored.
19410 * driver.cs: Allow multiple assemblies to be specified in a single
19413 2002-10-28 Miguel de Icaza <miguel@ximian.com>
19415 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
19416 because identifiers after a parenthesis would end up in this kind
19417 of production, and we needed to desamiguate it for having casts
19420 (UserDefinedType *) xxx
19422 2002-10-24 Miguel de Icaza <miguel@ximian.com>
19424 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
19425 we should set on the Bindingflags.NonPublic, but not turn on
19426 private_ok. private_ok controls whether a Private member is
19427 returned (this is chekced on the filter routine), while the
19428 BindingFlags.NonPublic just controls whether private/protected
19429 will be allowed. This fixes the problem part of the problem of
19430 private properties being allowed to be used in derived classes.
19432 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
19433 so we can call the children DoResolveLValue method (this will
19434 properly signal errors on lvalue assignments to base properties)
19436 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
19437 getter are null, and we have a property info, we know that this
19438 happened because the lookup failed, so we report an error 122 for
19439 protection level violation.
19441 We also silently return if setter and getter are null in the
19442 resolve functions, this condition only happens if we have flagged
19443 the error before. This is the other half of the problem.
19445 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
19446 not have accessibility information, that is why we were returning
19447 true in the filter function in typemanager.cs.
19449 To properly report 122 (property is inaccessible because of its
19450 protection level) correctly, we report this error in ResolveAccess
19451 by failing if both the setter and the getter are lacking (ie, the
19454 DoResolve and DoLResolve have been modified to check for both
19455 setter/getter being null and returning silently, the reason being
19456 that I did not want to put the knowledge about this error in upper
19459 int old = Report.Errors;
19460 x = new PropertyExpr (...);
19461 if (old != Report.Errors)
19466 So the property expr is returned, but it is invalid, so the error
19467 will be flagged during the resolve process.
19469 * class.cs: Remove InheritablePropertySignatureCompare from the
19470 class, as we no longer depend on the property signature to compute
19471 whether it is possible to implement a method or not.
19473 The reason is that calling PropertyInfo.GetGetMethod will return
19474 null (in .NET, in Mono it works, and we should change this), in
19475 cases where the Get Method does not exist in that particular
19480 class X { public virtual int A { get { return 1; } } }
19482 class Z : Y { public override int A { get { return 2; } } }
19484 Would fail in Z because the parent (Y) would not have the property
19485 defined. So we avoid this completely now (because the alternative
19486 fix was ugly and slow), and we now depend exclusively on the
19489 (PropertyBase.CheckBase): Use a method-base mechanism to find our
19490 reference method, instead of using the property.
19492 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
19493 routines are gone now.
19495 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
19496 names, they were incorrectly named.
19498 * cs-tokenizer.cs: Return are more gentle token on failure.
19500 * pending.cs (PendingImplementation.InterfaceMethod): This routine
19501 had an out-of-sync index variable, which caused it to remove from
19502 the list of pending methods the wrong method sometimes.
19504 2002-10-22 Miguel de Icaza <miguel@ximian.com>
19506 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
19507 CanWrite, because those refer to this particular instance of the
19508 property, and do not take into account the fact that we can
19509 override single members of a property.
19511 Constructor requires an EmitContext. The resolution process does
19512 not happen here, but we need to compute the accessors before,
19513 because the resolution does not always happen for properties.
19515 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
19516 subclass, before we did not update this flag, but we did update
19519 (GetAccessors): Drop this routine, as it did not work in the
19520 presence of partially overwritten set/get methods.
19522 Notice that this broke the cs1540 detection, but that will require
19525 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19529 * driver.cs: issue a warning instead of an error if we don't support
19530 debugging for the platform. Also ignore a couple of errors that may
19531 arise when trying to write the symbols. Undo my previous patch.
19533 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19535 * driver.cs: ignore /debug switch except for Unix platforms.
19537 2002-10-23 Nick Drochak <ndrochak@gol.com>
19539 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
19541 2002-10-21 Miguel de Icaza <miguel@ximian.com>
19543 * driver.cs: Do not make mcs-debug conditional, so we do not break
19544 builds that use it.
19546 * statement.cs (UsageVector.MergeChildren): I would like Martin to
19547 review this patch. But basically after all the children variables
19548 have been merged, the value of "Breaks" was not being set to
19549 new_breaks for Switch blocks. I think that it should be set after
19550 it has executed. Currently I set this to the value of new_breaks,
19551 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
19552 conservative, but I do not understand this code very well.
19554 I did not break anything in the build, so that is good ;-)
19556 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
19558 2002-10-20 Mark Crichton <crichton@gimp.org>
19560 * cfold.cs: Fixed compile blocker. Really fixed it this time.
19562 2002-10-20 Nick Drochak <ndrochak@gol.com>
19564 * cfold.cs: Fixed compile blocker.
19566 2002-10-20 Miguel de Icaza <miguel@ximian.com>
19568 * driver.cs: I was chekcing the key, not the file.
19570 2002-10-19 Ravi Pratap <ravi@ximian.com>
19572 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
19573 message that we were generating - we just need to silently return
19576 2002-10-19 Miguel de Icaza <miguel@ximian.com>
19578 * class.cs (Event.Define): Change my previous commit, as this
19579 breaks the debugger. This is a temporary hack, as it seems like
19580 the compiler is generating events incorrectly to begin with.
19582 * expression.cs (Binary.ResolveOperator): Added support for
19583 "U operator - (E x, E y)"
19585 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
19588 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
19589 init-only variables, but this path did not take into account that
19590 there might be also instance readonly variables. Correct this
19593 This fixes bug 32253
19595 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
19598 * driver.cs: Change the extension for modules to `netmodule'
19600 * cs-parser.jay: Improved slightly the location tracking for
19601 the debugger symbols.
19603 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
19604 modifiers that were specified instead of the hardcoded value
19605 (FamAndAssem). This was basically ignoring the static modifier,
19606 and others. Fixes 32429.
19608 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
19609 fixed a bug in the process (32476)
19611 * expression.cs (ArrayAccess.EmitAssign): Patch from
19612 hwang_rob@yahoo.ca that fixes bug 31834.3
19614 2002-10-18 Miguel de Icaza <miguel@ximian.com>
19616 * driver.cs: Make the module extension .netmodule.
19618 2002-10-16 Miguel de Icaza <miguel@ximian.com>
19620 * driver.cs: Report an error if the resource file is not found
19621 instead of crashing.
19623 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
19624 false, like Emit does.
19626 2002-10-16 Nick Drochak <ndrochak@gol.com>
19628 * typemanager.cs: Remove unused private member. Also reported mcs
19629 bug to report this as a warning like csc.
19631 2002-10-15 Martin Baulig <martin@gnome.org>
19633 * statement.cs (Statement.Emit): Made this a virtual method; emits
19634 the line number info and calls DoEmit().
19635 (Statement.DoEmit): New protected abstract method, formerly knows
19636 as Statement.Emit().
19638 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
19640 2002-10-11 Miguel de Icaza <miguel@ximian.com>
19642 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
19643 have fixed a remaining problem: not every AddXXXX was adding a
19644 fully qualified name.
19646 Now everyone registers a fully qualified name in the DeclSpace as
19647 being defined instead of the partial name.
19649 Downsides: we are slower than we need to be due to the excess
19650 copies and the names being registered this way.
19652 The reason for this is that we currently depend (on the corlib
19653 bootstrap for instance) that types are fully qualified, because
19654 we dump all the types in the namespace, and we should really have
19655 types inserted into the proper namespace, so we can only store the
19656 basenames in the defined_names array.
19658 2002-10-10 Martin Baulig <martin@gnome.org>
19660 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
19661 from bug #31834, see the bug report for a testcase which is
19664 2002-10-10 Martin Baulig <martin@gnome.org>
19666 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
19667 flow analysis code for this.
19669 * statement.cs (Do, While, For): Tell the flow analysis code about
19671 (FlowBranching.UsageVector): Added support for infinite loops.
19672 (Block.Resolve): Moved the dead code elimination here and use flow
19675 2002-10-09 Miguel de Icaza <miguel@ximian.com>
19677 * class.cs (Field.Define): Catch cycles on struct type
19680 * typemanager.cs (IsUnmanagedtype): Do not recursively check
19681 fields if the fields are static. We only need to check instance
19684 * expression.cs (As.DoResolve): Test for reference type.
19686 * statement.cs (Using.ResolveExpression): Use
19687 ConvertImplicitRequired, not ConvertImplicit which reports an
19689 (Using.ResolveLocalVariableDecls): ditto.
19691 * expression.cs (Binary.ResolveOperator): Report errors in a few
19692 places where we had to.
19694 * typemanager.cs (IsUnmanagedtype): Finish implementation.
19696 2002-10-08 Miguel de Icaza <miguel@ximian.com>
19698 * expression.cs: Use StoreFromPtr instead of extracting the type
19699 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
19701 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
19702 an enumeration value to a System.Enum, but System.Enum is not a
19703 value type, but an class type, so we need to box.
19705 (Expression.ConvertExplicit): One codepath could return
19706 errors but not flag them. Fix this. Fixes #31853
19708 * parameter.cs (Resolve): Do not allow void as a parameter type.
19710 2002-10-06 Martin Baulig <martin@gnome.org>
19712 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
19713 if it's a class type and not a struct. Fixes #31815.
19715 2002-10-06 Martin Baulig <martin@gnome.org>
19717 * statement.cs: Reworked the flow analysis code a bit to make it
19718 usable for dead code elimination.
19720 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19722 * cs-parser.jay: allow empty source files. Fixes bug #31781.
19724 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19726 * expression.cs (ComposedCast.DoResolveType): A quick workaround
19727 to fix the test 165, will investigate deeper.
19729 2002-10-04 Martin Baulig <martin@gnome.org>
19731 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
19732 finally blocks actually work.
19733 (Try.Resolve): We don't need to create a sibling for `finally' if
19734 there is no finally block.
19736 2002-10-04 Martin Baulig <martin@gnome.org>
19738 * class.cs (Constructor.Define): The default accessibility for a
19739 non-default constructor is private, not public.
19741 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19743 * class.cs (Constructor): Make AllowedModifiers public, add
19746 * cs-parser.jay: Perform the modifiers test here, as the
19747 constructor for the Constructor class usually receives a zero
19748 because of the way we create it (first we create, later we
19749 customize, and we were never checking the modifiers).
19751 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
19752 is a version of LookupTypeReflection that includes the type-name
19753 cache. This can be used as a fast path for functions that know
19754 the fully qualified name and are only calling into *.GetType() to
19755 obtain a composed type.
19757 This is also used by TypeManager.LookupType during its type
19760 (LookupType): We now also track the real type name, as sometimes
19761 we can get a quey for the real type name from things like
19762 ComposedCast. This fixes bug 31422.
19764 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
19765 complete type fullname, it does not have to go through the type
19766 resolution system to obtain the composed version of the type (for
19767 obtaining arrays or pointers).
19769 (Conditional.Emit): Use the EmitBoolExpression to
19770 generate nicer code, as requested by Paolo.
19772 (ArrayCreation.CheckIndices): Use the patch from
19773 hwang_rob@yahoo.ca to validate the array initializers.
19775 2002-10-03 Miguel de Icaza <miguel@ximian.com>
19777 * class.cs (ConstructorInitializer.Emit): simplify code by using
19778 Invocation.EmitCall, and at the same time, fix the bugs in calling
19779 parent constructors that took variable arguments.
19781 * ecore.cs (Expression.ConvertNumericExplicit,
19782 Expression.ImplicitNumericConversion): Remove the code that
19783 manually wrapped decimal (InternalTypeConstructor call is now gone
19786 * expression.cs (Cast.TryReduce): Also handle decimal types when
19787 trying to perform a constant fold on the type.
19789 * typemanager.cs (IsUnmanagedtype): Partially implemented.
19791 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
19792 that only turned off an error report, and did nothing else.
19794 2002-10-02 Miguel de Icaza <miguel@ximian.com>
19796 * driver.cs: Handle and ignore /fullpaths
19798 2002-10-01 Miguel de Icaza <miguel@ximian.com>
19800 * expression.cs (Binary.ResolveOperator): Catch the case where
19801 DoNumericPromotions returns true,
19803 (Binary.DoNumericPromotions): Simplify the code, and the tests.
19805 2002-09-27 Miguel de Icaza <miguel@ximian.com>
19807 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
19810 2002-09-26 Miguel de Icaza <miguel@ximian.com>
19812 * ecore.cs (ConvertNumericExplicit): It is not enough that the
19813 conversion exists, but it is also required that the conversion be
19814 performed. This manifested in "(Type64Enum) 2".
19816 * class.cs (TypeManager.AddMethod): The fix is not to change
19817 AddEnum, because that one was using a fully qualified name (every
19818 DeclSpace derivative does), but to change the AddMethod routine
19819 that was using an un-namespaced name. This now correctly reports
19820 the duplicated name.
19822 Revert patch until I can properly fix it. The issue
19823 is that we have a shared Type space across all namespaces
19824 currently, which is wrong.
19826 Options include making the Namespace a DeclSpace, and merge
19827 current_namespace/current_container in the parser.
19829 2002-09-25 Miguel de Icaza <miguel@ximian.com>
19831 * cs-parser.jay: Improve error reporting when we get a different
19832 kind of expression in local_variable_type and
19833 local_variable_pointer_type.
19835 Propagate this to avoid missleading errors being reported.
19837 * ecore.cs (ImplicitReferenceConversion): treat
19838 TypeManager.value_type as a target just like object_type. As
19843 Is valid, and needs to result in the int 1 being boxed before it
19844 is assigned to the value type v.
19846 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
19847 to validate the enumeration name.
19849 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
19850 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
19851 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
19853 * ecore.cs (TryImplicitIntConversion): When doing an
19854 implicit-enumeration-conversion, check if the type is 64-bits and
19855 perform a conversion before passing to EnumConstant.
19857 2002-09-23 Miguel de Icaza <miguel@ximian.com>
19859 * decl.cs (Error_AmbiguousTypeReference); New routine used to
19860 report ambiguous type references. Unlike the MS version, we
19861 report what the ambiguity is. Innovation at work ;-)
19863 (DeclSpace.FindType): Require a location argument to
19864 display when we display an ambiguous error.
19866 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
19868 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
19870 * expression.cs (EmitDynamicInitializers): Apply patch from
19871 hwang_rob@yahoo.ca that fixes the order in which we emit our
19874 2002-09-21 Martin Baulig <martin@gnome.org>
19876 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
19877 delegate takes no arguments.
19879 2002-09-20 Miguel de Icaza <miguel@ximian.com>
19881 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
19884 * expression.cs: Extract the underlying type.
19886 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
19888 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
19890 2002-09-19 Miguel de Icaza <miguel@ximian.com>
19892 * class.cs (TypeContainer.DefineType): We can not use the nice
19893 PackingSize with the size set to 1 DefineType method, because it
19894 will not allow us to define the interfaces that the struct
19897 This completes the fixing of bug 27287
19899 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
19900 means also structs. This fixes part of the problem.
19901 (Expresion.ImplicitReferenceConversionExists): ditto.
19903 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
19904 error if there were no errors reported during the type lookup
19905 process, to avoid duplicates or redundant errors. Without this
19906 you would get an ambiguous errors plus a type not found. We have
19907 beaten the user enough with the first error.
19909 (DeclSparce.FindType): Emit a warning if we have an ambiguous
19912 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
19913 during the resolution process, stop the lookup, this avoids
19914 repeated error reports (same error twice).
19916 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
19918 * typemanager.cs (LookupType): Redo the type lookup code to match
19919 the needs of System.Reflection.
19921 The issue is that System.Reflection requires references to nested
19922 types to begin with a "+" sign instead of a dot. So toplevel
19923 types look like: "NameSpace.TopLevelClass", and nested ones look
19924 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
19927 2002-09-19 Martin Baulig <martin@gnome.org>
19929 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
19930 says that a method always returns or always throws an exception,
19931 don't report the CS0161.
19933 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
19934 set `Returns = new_returns'.
19936 2002-09-19 Martin Baulig <martin@gnome.org>
19938 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
19939 to an enum constant, check for a CS0176.
19941 2002-09-18 Miguel de Icaza <miguel@ximian.com>
19943 * class.cs (TypeContainer.CheckPairedOperators): Now we check
19944 for operators that must be in pairs and report errors.
19946 * ecore.cs (SimpleName.DoResolveType): During the initial type
19947 resolution process, when we define types recursively, we must
19948 check first for types in our current scope before we perform
19949 lookups in the enclosing scopes.
19951 * expression.cs (MakeByteBlob): Handle Decimal blobs.
19953 (Invocation.VerifyArgumentsCompat): Call
19954 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
19955 I thought we were supposed to always call this, but there are a
19956 few places in the code where we dont do it.
19958 2002-09-17 Miguel de Icaza <miguel@ximian.com>
19960 * driver.cs: Add support in -linkres and -resource to specify the
19961 name of the identifier.
19963 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19965 * ecore.cs (StandardConversionExists): Sync with the conversion
19966 code: allow anything-* to void* conversions.
19968 (FindMostSpecificSource): Use an Expression argument
19969 instead of a Type, because we might be handed over a Literal which
19970 gets a few more implicit conversions that plain types do not. So
19971 this information was being lost.
19973 Also, we drop the temporary type-holder expression when not
19976 2002-09-17 Martin Baulig <martin@gnome.org>
19978 * class.cs (PropertyBase.CheckBase): Don't check the base class if
19979 this is an explicit interface implementation.
19981 2002-09-17 Martin Baulig <martin@gnome.org>
19983 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
19984 different `IndexerName' attributes.
19986 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
19987 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
19988 virtual CommonResolve().
19990 2002-09-16 Miguel de Icaza <miguel@ximian.com>
19992 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
19993 and convert that to the UnderlyingType.
19995 * statement.cs (Foreach.Resolve): Indexers are just like variables
19996 or PropertyAccesses.
19998 * cs-tokenizer.cs (consume_string): Track line numbers and columns
19999 inside quoted strings, we were not doing this before.
20001 2002-09-16 Martin Baulig <martin@gnome.org>
20003 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
20004 resolve it. This is needed for the definite assignment check of the
20005 instance expression, fixes bug #29846.
20006 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
20008 2002-09-16 Nick Drochak <ndrochak@gol.com>
20010 * parameter.cs: Fix compile error. Cannot reference static member
20011 from an instance object. Is this an mcs bug?
20013 2002-09-14 Martin Baulig <martin@gnome.org>
20015 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
20016 multiple times. Fixes bug #30295, added test-166.cs.
20018 2002-09-14 Martin Baulig <martin@gnome.org>
20020 * statement.cs (Block.Emit): Don't emit unreachable code.
20021 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
20022 `break' statements.
20023 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
20025 2002-09-14 Martin Baulig <martin@gnome.org>
20027 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
20030 2002-09-14 Martin Baulig <martin@gnome.org>
20032 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
20033 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
20034 be false on the ms runtime.
20036 2002-09-13 Martin Baulig <martin@gnome.org>
20038 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
20039 the CS0038 error message.
20041 2002-09-12 Miguel de Icaza <miguel@ximian.com>
20043 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
20044 constant inside, return it.
20046 2002-09-12 Martin Baulig <martin@gnome.org>
20048 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
20049 implicit conversion can be done between enum types.
20051 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
20052 check whether an implicit conversion to the current enum's UnderlyingType
20053 exists and report an error if not.
20055 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
20056 without debugging support.
20058 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
20059 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
20061 2002-09-12 Martin Baulig <martin@gnome.org>
20063 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
20065 * ecore.cs (IMemberExpr.DeclaringType): New property.
20066 (SimpleName.SimpleNameResolve): Check whether we're accessing a
20067 nonstatic member of an outer type (CS0038).
20069 2002-09-11 Miguel de Icaza <miguel@ximian.com>
20071 * driver.cs: Activate the using-error detector at warning level
20072 4 (at least for MS-compatible APIs).
20074 * namespace.cs (VerifyUsing): Small buglett fix.
20076 * pending.cs (PendingImplementation): pass the container pointer.
20078 * interface.cs (GetMethods): Allow for recursive definition. Long
20079 term, I would like to move every type to support recursive
20080 definitions, not the current ordering mechanism that we have right
20083 The situation is this: Attributes are handled before interfaces,
20084 so we can apply attributes to interfaces. But some attributes
20085 implement interfaces, we will now handle the simple cases
20086 (recursive definitions will just get an error).
20088 * parameter.cs: Only invalidate types at the end if we fail to
20091 2002-09-09 Martin Baulig <martin@gnome.org>
20093 * ecore.cs (PropertyExpr.Emit): Also check for
20094 TypeManager.system_int_array_get_length so this'll also work when
20095 compiling corlib. Fixes #30003.
20097 2002-09-09 Martin Baulig <martin@gnome.org>
20099 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
20100 and throw an exception if we can't get the type's size. Fixed #30040,
20103 2002-09-09 Martin Baulig <martin@gnome.org>
20105 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
20107 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
20108 context. Fixes bug #30027.
20110 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
20111 virtual functions. Fixes bug #30043, added test-164.cs.
20113 2002-09-08 Ravi Pratap <ravi@ximian.com>
20115 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
20117 2002-09-08 Nick Drochak <ndrochak@gol.com>
20119 * driver.cs: Use an object to get the windows codepage since it's not a
20122 2002-09-08 Miguel de Icaza <miguel@ximian.com>
20124 * statement.cs (For.Emit): for infinite loops (test == null)
20125 return whether there is a break inside, not always "true".
20127 * namespace.cs (UsingEntry): New struct to hold the name of the
20128 using definition, the location where it is defined, and whether it
20129 has been used in a successful type lookup.
20131 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
20136 2002-09-06 Ravi Pratap <ravi@ximian.com>
20138 * attribute.cs : Fix incorrect code which relied on catching
20139 a NullReferenceException to detect a null being passed in
20140 where an object was expected.
20142 2002-09-06 Miguel de Icaza <miguel@ximian.com>
20144 * statement.cs (Try): flag the catch variable as assigned
20146 * expression.cs (Cast): Simplified by using ResolveType instead of
20147 manually resolving.
20149 * statement.cs (Catch): Fix bug by using ResolveType.
20151 2002-09-06 Ravi Pratap <ravi@ximian.com>
20153 * expression.cs (BetterConversion): Special case for when we have
20154 a NullLiteral as the argument and we have to choose between string
20155 and object types - we choose string the way csc does.
20157 * attribute.cs (Attribute.Resolve): Catch the
20158 NullReferenceException and report error #182 since the Mono
20159 runtime no more has the bug and having this exception raised means
20160 we tried to select a constructor which takes an object and is
20163 2002-09-05 Ravi Pratap <ravi@ximian.com>
20165 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
20166 message (1502, 1503) when we can't locate a method after overload
20167 resolution. This is much more informative and closes the bug
20170 * interface.cs (PopulateMethod): Return if there are no argument
20171 types. Fixes a NullReferenceException bug.
20173 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
20174 expressions too. Previously we were checking only in one place for
20175 positional arguments leaving out named arguments.
20177 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
20178 type to the enum type is not allowed. Remove code corresponding to
20181 (ConvertNumericExplicit): Allow explicit conversions from
20182 the underlying type to enum type. This precisely follows the spec
20183 and closes a bug filed by Gonzalo.
20185 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20188 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
20190 2002-09-03 Miguel de Icaza <miguel@ximian.com>
20192 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
20193 it was important that we stored the right value after the
20194 reduction in `converted'.
20196 2002-09-04 Martin Baulig <martin@gnome.org>
20198 * location.cs (Location.SymbolDocument): Use full pathnames for the
20201 2002-08-30 Miguel de Icaza <miguel@ximian.com>
20203 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
20204 of the expression resolve mechanism, because that will catch the
20205 SimpleName error failures.
20207 (Conditional): If we can not resolve the
20208 expression, return, do not crash.
20210 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20213 (location): display token name instead of its number.
20215 2002-08-28 Martin Baulig <martin@gnome.org>
20217 * expression.cs (Binary.ResolveOperator): Don't silently return
20218 but return an error if an operator cannot be applied between two
20221 2002-08-28 Martin Baulig <martin@gnome.org>
20223 * class.cs (Constructor.Define): Set the permission attributes
20224 correctly instead of making all constructors public.
20226 2002-08-28 Martin Baulig <martin@gnome.org>
20228 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
20229 for private members before reporting a CS0103; if we find anything,
20232 2002-08-28 Martin Baulig <martin@gnome.org>
20234 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
20235 to check whether `closure_start_type == closure_invocation_type',
20236 we also need to check whether `m.DeclaringType == closure_invocation_type'
20237 before bypassing the permission checks. We might be accessing
20238 protected/private members from the base class.
20239 (TypeManager.RealMemberLookup): Only set private_ok if private
20240 members were requested via BindingFlags.NonPublic.
20242 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
20244 * expression.cs (MemberAccess.ResolveMemberAccess): Set
20245 MethodGroupExpr.IsExplicitImpl if appropriate.
20246 (Invocation.DoResolve): Don't report the CS0120 for explicit
20247 interface implementations.
20249 2002-08-27 Martin Baulig <martin@gnome.org>
20251 * expression.cs (Invocation.DoResolve): If this is a static
20252 method and we don't have an InstanceExpression, we must report
20255 2002-08-25 Martin Baulig <martin@gnome.org>
20257 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
20258 `==' between a valuetype and an object.
20260 2002-08-25 Miguel de Icaza <miguel@ximian.com>
20262 * ecore.cs (TypeExpr): Provide a ToString method.
20264 2002-08-24 Martin Baulig <martin@gnome.org>
20266 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
20267 now called proggie.dbg and it's a binary file.
20269 2002-08-23 Martin Baulig <martin@gnome.org>
20271 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
20273 2002-08-23 Martin Baulig <martin@gnome.org>
20275 * struct.cs (MyStructInfo.ctor): Make this work with empty
20276 structs; it's not allowed to use foreach() on null.
20278 2002-08-23 Martin Baulig <martin@gnome.org>
20280 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
20281 writer the full pathname of the generated assembly.
20283 2002-08-23 Martin Baulig <martin@gnome.org>
20285 * statements.cs (FlowBranching.UsageVector.MergeChildren):
20286 A `finally' block never returns or breaks; improved handling of
20289 2002-08-23 Martin Baulig <martin@gnome.org>
20291 * statement.cs (Throw.Resolve): Allow `throw null'.
20293 2002-08-23 Martin Baulig <martin@gnome.org>
20295 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
20296 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
20297 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
20298 MemberLookup would return a wrong event if this is an explicit
20299 interface implementation and the class has an event with the same
20302 2002-08-23 Martin Baulig <martin@gnome.org>
20304 * statement.cs (Block.AddChildVariableNames): New public method.
20305 (Block.AddChildVariableName): Likewise.
20306 (Block.IsVariableNameUsedInChildBlock): Likewise.
20307 (Block.AddVariable): Check whether a variable name has already
20308 been used in a child block.
20310 * cs-parser.jay (declare_local_variables): Mark all variable names
20311 from the current block as being used in a child block in the
20314 2002-08-23 Martin Baulig <martin@gnome.org>
20316 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
20317 find the symbol writer.
20319 * driver.cs: csc also allows the arguments to /define being
20320 separated by commas, not only by semicolons.
20322 2002-08-23 Martin Baulig <martin@gnome.org>
20324 * interface.cs (Interface.GetMembers): Added static check for events.
20326 2002-08-15 Martin Baulig <martin@gnome.org>
20328 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
20329 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
20331 * ecore.cs (Expression.MemberLookup): Added documentation and explained
20332 why the MethodData.EmitDestructor() change was necessary.
20334 2002-08-20 Martin Baulig <martin@gnome.org>
20336 * class.cs (TypeContainer.FindMembers): Added static check for events.
20338 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
20340 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
20341 use Type.GetEvents(), not Type.FindMembers().
20343 2002-08-20 Martin Baulig <martin@gnome.org>
20345 * decl.cs (MemberCache): Added a special method cache which will
20346 be used for method-only searched. This ensures that a method
20347 search will return a MethodInfo with the correct ReflectedType for
20350 2002-08-20 Martin Baulig <martin@gnome.org>
20352 * decl.cs (DeclSpace.FindMembers): Made this public.
20354 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20356 * delegate.cs: fixed build on windows.
20357 [FIXME: Filed as bug #29150: MCS must report these errors.]
20359 2002-08-19 Ravi Pratap <ravi@ximian.com>
20361 * ecore.cs (StandardConversionExists): Return a false
20362 if we are trying to convert the void type to anything else
20363 since that is not allowed.
20365 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
20366 we flag error 70 in the event an event is trying to be accessed
20367 directly from outside the declaring type.
20369 2002-08-20 Martin Baulig <martin@gnome.org>
20371 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
20372 MemberCache from typemanager.cs to decl.cs.
20374 2002-08-19 Martin Baulig <martin@gnome.org>
20376 * class.cs (TypeContainer): Implement IMemberContainer.
20377 (TypeContainer.DefineMembers): Create the MemberCache.
20378 (TypeContainer.FindMembers): Do better BindingFlags checking; only
20379 return public members if BindingFlags.Public was given, check
20380 whether members are static.
20382 2002-08-16 Martin Baulig <martin@gnome.org>
20384 * decl.cs (DeclSpace.Define): Splitted this in Define and
20385 DefineMembers. DefineMembers is called first and initializes the
20388 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
20389 DefineMembers() on all our DeclSpaces.
20391 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
20392 but call DefineMembers() on all nested interfaces. We call their
20393 Define() in our new Define() function.
20395 * interface.cs (Interface): Implement IMemberContainer.
20396 (Interface.Define): Moved all code except the attribute stuf to
20398 (Interface.DefineMembers): Initialize the member cache.
20400 * typemanager.cs (IMemberFinder): Removed this interface, we don't
20401 need this anymore since we can use MemberCache.FindMembers directly.
20403 2002-08-19 Martin Baulig <martin@gnome.org>
20405 * typemanager.cs (MemberCache): When creating the cache for an
20406 interface type, add all inherited members.
20407 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
20408 to `out bool used_cache' and documented it.
20409 (TypeManager.MemberLookup): If we already used the cache in the first
20410 iteration, we don't need to do the interfaces check.
20412 2002-08-19 Martin Baulig <martin@gnome.org>
20414 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
20415 here from IMemberFinder and don't implement this interface anymore.
20416 (DeclSpace.MemberCache): Moved here from IMemberFinder.
20418 * typemanager.cs (IMemberFinder): This interface is now only used by
20419 classes which actually support the member cache.
20420 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
20421 since we only put DeclSpaces into this Hashtable.
20422 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
20423 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
20425 2002-08-16 Martin Baulig <martin@gnome.org>
20427 * typemanager.cs (ICachingMemberFinder): Removed.
20428 (IMemberFinder.MemberCache): New property.
20429 (TypeManager.FindMembers): Merged this with RealFindMembers().
20430 This function will never be called from TypeManager.MemberLookup()
20431 so we can't use the cache here, just the IMemberFinder.
20432 (TypeManager.MemberLookup_FindMembers): Check whether the
20433 IMemberFinder has a MemberCache and call the cache's FindMembers
20435 (MemberCache): Rewrote larger parts of this yet another time and
20436 cleaned it up a bit.
20438 2002-08-15 Miguel de Icaza <miguel@ximian.com>
20440 * driver.cs (LoadArgs): Support quoting.
20442 (Usage): Show the CSC-like command line arguments.
20444 Improved a few error messages.
20446 2002-08-15 Martin Baulig <martin@gnome.org>
20448 * typemanager.cs (IMemberContainer.Type): New property.
20449 (IMemberContainer.IsInterface): New property.
20451 The following changes are conditional to BROKEN_RUNTIME, which is
20452 defined at the top of the file.
20454 * typemanager.cs (MemberCache.MemberCache): Don't add the base
20455 class'es members, but add all members from TypeHandle.ObjectType
20456 if we're an interface.
20457 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
20458 is the current type.
20459 (MemberCache.CacheEntry.Container): Removed this field.
20460 (TypeHandle.GetMembers): Include inherited members.
20462 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20464 * typemanager.cs: fixed compilation and added a comment on a field that
20467 2002-08-15 Martin Baulig <martin@gnome.org>
20469 * class.cs (ConstructorInitializer.Resolve): In the
20470 Expression.MemberLookup call, use the queried_type as
20473 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
20474 declared' attribute, it's always true.
20475 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
20476 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
20477 temporary wrapper for FindMembers which tells MemberLookup whether
20478 members from the base classes are included in the return value.
20479 This will go away soon.
20480 (TypeManager.MemberLookup): Use this temporary hack here; once the
20481 new MemberCache is completed, we don't need to do the DeclaredOnly
20482 looping here anymore since the MemberCache will take care of this.
20483 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
20484 (MemberCache): When creating the MemberCache for a class, get
20485 members from the current class and all its base classes.
20486 (MemberCache.CacheEntry.Container): New field. This is a
20487 temporary hack until the Mono runtime is fixed to distinguish
20488 between ReflectedType and DeclaringType. It allows us to use MCS
20489 with both the MS runtime and the unfixed Mono runtime without
20490 problems and without accecting performance.
20491 (MemberCache.SearchMembers): The DeclaredOnly looping from
20492 TypeManager.MemberLookup is now done here.
20494 2002-08-14 Martin Baulig <martin@gnome.org>
20496 * statement.cs (MyStructInfo.MyStructInfo): Don't call
20497 Type.GetFields on dynamic types but get the fields from the
20498 corresponding TypeContainer.
20499 (MyStructInfo.GetStructInfo): Added check for enum types.
20501 * typemanager.cs (MemberList.IsSynchronized): Implemented.
20502 (MemberList.SyncRoot): Implemented.
20503 (TypeManager.FilterWithClosure): No need to check permissions if
20504 closure_start_type == closure_invocation_type, don't crash if
20505 closure_invocation_type is null.
20507 2002-08-13 Martin Baulig <martin@gnome.org>
20509 Rewrote TypeContainer.FindMembers to use a member cache. This
20510 gives us a speed increase of about 35% for the self-hosting MCS
20511 build and of about 15-20% for the class libs (both on GNU/Linux).
20513 * report.cs (Timer): New class to get enhanced profiling. This
20514 whole class is "TIMER" conditional since it remarkably slows down
20517 * class.cs (MemberList): New class. This is an IList wrapper
20518 which we're now using instead of passing MemberInfo[]'s around to
20519 avoid copying this array unnecessarily.
20520 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
20521 (ICachingMemberFinder, IMemberContainer): New interface.
20522 (TypeManager.FilterWithClosure): If `criteria' is null, the name
20523 has already been checked, otherwise use it for the name comparision.
20524 (TypeManager.FindMembers): Renamed to RealMemberFinder and
20525 provided wrapper which tries to use ICachingMemberFinder.FindMembers
20526 if possible. Returns a MemberList, not a MemberInfo [].
20527 (TypeHandle): New class, implements IMemberContainer. We create
20528 one instance of this class per type, it contains a MemberCache
20529 which is used to do the member lookups.
20530 (MemberCache): New class. Each instance of this class contains
20531 all members of a type and a name-based hash table.
20532 (MemberCache.FindMembers): This is our new member lookup
20533 function. First, it looks up all members of the requested name in
20534 the hash table. Then, it walks this list and sorts out all
20535 applicable members and returns them.
20537 2002-08-13 Martin Baulig <martin@gnome.org>
20539 In addition to a nice code cleanup, this gives us a performance
20540 increase of about 1.4% on GNU/Linux - not much, but it's already
20541 half a second for the self-hosting MCS compilation.
20543 * typemanager.cs (IMemberFinder): New interface. It is used by
20544 TypeManager.FindMembers to call FindMembers on a TypeContainer,
20545 Enum, Delegate or Interface.
20546 (TypeManager.finder_to_member_finder): New PtrHashtable.
20547 (TypeManager.finder_to_container): Removed.
20548 (TypeManager.finder_to_delegate): Removed.
20549 (TypeManager.finder_to_interface): Removed.
20550 (TypeManager.finder_to_enum): Removed.
20552 * interface.cs (Interface): Implement IMemberFinder.
20554 * delegate.cs (Delegate): Implement IMemberFinder.
20556 * enum.cs (Enum): Implement IMemberFinder.
20558 * class.cs (TypeContainer): Implement IMemberFinder.
20560 2002-08-12 Martin Baulig <martin@gnome.org>
20562 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
20564 2002-08-12 Martin Baulig <martin@gnome.org>
20566 * ecore.cs (ITypeExpression): New interface for expressions which
20568 (TypeExpression): Renamed to TypeLookupExpression.
20569 (Expression.DoResolve): If we're doing a types-only lookup, the
20570 expression must implement the ITypeExpression interface and we
20571 call DoResolveType() on it.
20572 (SimpleName): Implement the new ITypeExpression interface.
20573 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
20574 hack, the situation that we're only looking up types can't happen
20575 anymore when this method is called. Moved the type lookup code to
20576 DoResolveType() and call it.
20577 (SimpleName.DoResolveType): This ITypeExpression interface method
20578 is now doing the types-only lookup.
20579 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
20580 (ResolveFlags): Added MaskExprClass.
20582 * expression.cs (MemberAccess): Implement the ITypeExpression
20584 (MemberAccess.DoResolve): Added support for a types-only lookup
20585 when we're called via ITypeExpression.DoResolveType().
20586 (ComposedCast): Implement the ITypeExpression interface.
20588 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
20589 Expression.Resolve() with ResolveFlags.Type instead.
20591 2002-08-12 Martin Baulig <martin@gnome.org>
20593 * interface.cs (Interface.Define): Apply attributes.
20595 * attribute.cs (Attribute.ApplyAttributes): Added support for
20596 interface attributes.
20598 2002-08-11 Martin Baulig <martin@gnome.org>
20600 * statement.cs (Block.Emit): Only check the "this" variable if we
20601 do not always throw an exception.
20603 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
20604 whether the property has a set accessor.
20606 2002-08-11 Martin Baulig <martin@gnome.org>
20608 Added control flow analysis support for structs.
20610 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
20611 with control flow analysis turned off.
20612 (IVariable): New interface.
20613 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
20614 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
20615 (FieldExpr.DoResolve): Resolve the instance expression with flow
20616 analysis turned off and do the definite assignment check after the
20617 resolving when we know what the expression will resolve to.
20619 * expression.cs (LocalVariableReference, ParameterReference):
20620 Implement the new IVariable interface, only call the flow analysis
20621 code if ec.DoFlowAnalysis is true.
20622 (This): Added constructor which takes a Block argument. Implement
20623 the new IVariable interface.
20624 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
20625 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
20626 This does the definite assignment checks for struct members.
20628 * class.cs (Constructor.Emit): If this is a non-static `struct'
20629 constructor which doesn't have any initializer, call
20630 Block.AddThisVariable() to tell the flow analysis code that all
20631 struct elements must be initialized before control returns from
20634 * statement.cs (MyStructInfo): New public class.
20635 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
20636 argument to this indexer. If non-zero, check an individual struct
20637 member, not the whole struct.
20638 (FlowBranching.CheckOutParameters): Check struct members.
20639 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
20640 overloaded versions of these methods which take an additional
20641 `int field_idx' argument to check struct members.
20642 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
20643 overloaded versions of these methods which take an additional
20644 `string field_name' argument to check struct member.s
20645 (VariableInfo): Implement the IVariable interface.
20646 (VariableInfo.StructInfo): New public property. Returns the
20647 MyStructInfo instance of the variable if it's a struct or null.
20648 (Block.AddThisVariable): New public method. This is called from
20649 Constructor.Emit() for non-static `struct' constructor which do
20650 not have any initializer. It creates a special variable for the
20651 "this" instance variable which will be checked by the flow
20652 analysis code to ensure that all of the struct's fields are
20653 initialized before control returns from the constructor.
20654 (UsageVector): Added support for struct members. If a
20655 variable/parameter is a struct with N members, we reserve a slot
20656 in the usage vector for each member. A struct is considered fully
20657 initialized if either the struct itself (slot 0) or all its
20658 members are initialized.
20660 2002-08-08 Martin Baulig <martin@gnome.org>
20662 * driver.cs (Driver.MainDriver): Only report an error CS5001
20663 if there were no compilation errors.
20665 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
20666 `UnsafeContext' property to determine whether the parent is in
20667 unsafe context rather than checking the parent's ModFlags:
20668 classes nested in an unsafe class are unsafe as well.
20670 2002-08-08 Martin Baulig <martin@gnome.org>
20672 * statement.cs (UsageVector.MergeChildren): Distinguish between
20673 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
20674 we return. Added test17() and test18() to test-154.cs.
20676 2002-08-08 Martin Baulig <martin@gnome.org>
20678 * typemanager.cs (TypeManager.FilterWithClosure): If we have
20679 Family access, make sure the invoking type isn't a subclass of the
20680 queried type (that'd be a CS1540).
20682 * ecore.cs (Expression.MemberLookup): Added overloaded version of
20683 this method which takes an additional `Type invocation_type'.
20685 * expression.cs (BaseAccess.DoResolve): Use the base type as
20686 invocation and query type.
20687 (MemberAccess.DoResolve): If the lookup failed and we're about to
20688 report a CS0122, try a lookup with the ec.ContainerType - if this
20689 succeeds, we must report a CS1540.
20691 2002-08-08 Martin Baulig <martin@gnome.org>
20693 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
20694 (MethodGroupExpr): Implement the IMemberExpr interface.
20696 * expression (MemberAccess.ResolveMemberAccess): No need to have
20697 any special code for MethodGroupExprs anymore, they're now
20700 2002-08-08 Martin Baulig <martin@gnome.org>
20702 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
20703 Family, FamANDAssem and FamORAssem permissions.
20704 (TypeManager.IsSubclassOrNestedChildOf): New public method.
20706 2002-08-08 Martin Baulig <martin@gnome.org>
20708 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
20709 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
20712 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
20714 * driver.cs: implemented /resource option to embed managed resources.
20716 2002-08-07 Martin Baulig <martin@gnome.org>
20718 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
20719 (FieldBase.HasFieldInitializer): New public property.
20720 (FieldBase.GetInitializerExpression): New public method. Resolves and
20721 returns the field initializer and makes sure it is only resolved once.
20722 (TypeContainer.EmitFieldInitializers): Call
20723 FieldBase.GetInitializerExpression to get the initializer, this ensures
20724 that it isn't resolved multiple times.
20726 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
20727 the resolving process (SimpleName/MemberLookup) that we're currently
20728 emitting a field initializer (which must not access any instance members,
20729 this is an error CS0236).
20731 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
20732 argument, if the `IsFieldInitializer' flag is set, we must report and
20733 error CS0236 and not an error CS0120.
20735 2002-08-07 Martin Baulig <martin@gnome.org>
20737 * ecore.cs (IMemberExpr): New public interface.
20738 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
20739 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
20740 if the expression is an IMemberExpr.
20742 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
20743 to be null, implicitly default to `this' if we're non-static in
20744 this case. Simplified the code a lot by using the new IMemberExpr
20745 interface. Also fixed bug #28176 here.
20747 2002-08-06 Martin Baulig <martin@gnome.org>
20749 * cs-parser.jay (SimpleLookup): Removed. We need to create
20750 ParameterReferences during semantic analysis so that we can do a
20751 type-only search when resolving Cast, TypeOf and SizeOf.
20752 (block): Pass the `current_local_parameters' to the Block's
20755 * class.cs (ConstructorInitializer): Added `Parameters parameters'
20756 argument to the constructor.
20757 (ConstructorInitializer.Resolve): Create a temporary implicit
20758 block with the parameters.
20760 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
20761 references here if we aren't doing a type-only search.
20763 * statement.cs (Block): Added constructor which takes a
20764 `Parameters parameters' argument.
20765 (Block.Parameters): New public property.
20767 * support.cs (InternalParameters.Parameters): Renamed `parameters'
20768 to `Parameters' and made it public readonly.
20770 2002-08-06 Martin Baulig <martin@gnome.org>
20772 * ecore.cs (Expression.Warning): Made this public as well.
20774 * report.cs (Report.Debug): Print the contents of collections.
20776 2002-08-06 Martin Baulig <martin@gnome.org>
20778 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
20779 used to tell Resolve() which kinds of expressions it may return.
20780 (Expression.Resolve): Added overloaded version of this method which
20781 takes a `ResolveFlags flags' argument. This can be used to tell
20782 Resolve() which kinds of expressions it may return. Reports a
20784 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
20785 ResolveFlags.SimpleName.
20786 (Expression.Error118): Added overloaded version of this method which
20787 takes a `ResolveFlags flags' argument. It uses the flags to determine
20788 which kinds of expressions are allowed.
20790 * expression.cs (Argument.ResolveMethodGroup): New public method.
20791 Resolves an argument, but allows a MethodGroup to be returned.
20792 This is used when invoking a delegate.
20794 * TODO: Updated a bit.
20796 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20798 Fixed compilation with csc.
20800 * ecore.cs: Expression.Error made public. Is this correct? Should
20801 Warning be made public too?
20803 * expression.cs: use ea.Location instead of ea.loc.
20804 [FIXME: Filed as bug #28607: MCS must report these errors.]
20806 2002-08-06 Martin Baulig <martin@gnome.org>
20808 * ecore.cs (Expression.loc): Moved the location here instead of
20809 duplicating it in all derived classes.
20810 (Expression.Location): New public property.
20811 (Expression.Error, Expression.Warning): Made them non-static and
20812 removed the location argument.
20813 (Expression.Warning): Added overloaded version which takes an
20814 `int level' argument.
20815 (Expression.Error118): Make this non-static and removed the
20816 expression and location arguments.
20817 (TypeExpr): Added location argument to the constructor.
20819 * expression.cs (StaticCallExpr): Added location argument to
20821 (Indirection, PointerArithmetic): Likewise.
20822 (CheckedExpr, UnCheckedExpr): Likewise.
20823 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
20824 (StringPtr): Likewise.
20827 2002-08-05 Martin Baulig <martin@gnome.org>
20829 * expression.cs (BaseAccess.DoResolve): Actually report errors.
20831 * assign.cs (Assign.DoResolve): Check whether the source
20832 expression is a value or variable.
20834 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
20835 while resolving the corresponding blocks.
20837 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
20838 an error, don't silently return null.
20840 * statement.cs (Block.AddVariable): Do the error reporting here
20841 and distinguish between CS0128 and CS0136.
20842 (Block.DoResolve): Report all unused labels (warning CS0164).
20843 (LabeledStatement): Pass the location to the constructor.
20844 (LabeledStatement.HasBeenReferenced): New property.
20845 (LabeledStatement.Resolve): Set it to true here.
20847 * statement.cs (Return.Emit): Return success even after reporting
20848 a type mismatch error (CS0126 or CS0127), this is what csc does and
20849 it avoids confusing the users with any consecutive errors.
20851 2002-08-05 Martin Baulig <martin@gnome.org>
20853 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
20855 * const.cs (Const.LookupConstantValue): Catch circular definitions.
20857 * expression.cs (MemberAccess.DoResolve): Silently return if an
20858 error has already been reported.
20860 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
20861 error has already been reported.
20863 2002-08-05 Martin Baulig <martin@gnome.org>
20865 * statement.cs (UsageVector): Only initialize the `parameters'
20866 vector if we actually have any "out" parameters.
20868 2002-08-05 Martin Baulig <martin@gnome.org>
20870 * expression.cs (Binary.ResolveOperator): When combining delegates,
20871 they must have the same type.
20873 2002-08-05 Martin Baulig <martin@gnome.org>
20875 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
20876 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
20877 work with the ms runtime and we also don't need it: if we're a
20878 PropertyBuilder and not in the `indexer_arguments' hash, then we
20879 are a property and not an indexer.
20881 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
20882 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
20883 since the latter one doesn't work with the ms runtime.
20885 2002-08-03 Martin Baulig <martin@gnome.org>
20887 Fixed bugs #27998 and #22735.
20889 * class.cs (Method.IsOperator): New public field.
20890 (Method.CheckBase): Report CS0111 if there's already a method
20891 with the same parameters in the current class. Report CS0508 when
20892 attempting to change the return type of an inherited method.
20893 (MethodData.Emit): Report CS0179 if a method doesn't have a body
20894 and it's not marked abstract or extern.
20895 (PropertyBase): New abstract base class for Property and Indexer.
20896 (PropertyBase.CheckBase): Moved here from Property and made it work
20898 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
20899 the same so we can reuse it there.
20900 (Property, Indexer): Derive from PropertyBase.
20901 (MethodSignature.inheritable_property_signature_filter): New delegate
20902 to find properties and indexers.
20904 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
20905 argument and improved error reporting.
20907 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
20908 EmptyReadOnlyParameters and made it a property.
20910 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
20911 version of this method which takes a `PropertyInfo indexer'.
20912 (TypeManager.RegisterIndexer): New method.
20914 * class.cs: Added myself as author of this file :-)
20916 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20918 * class.cs: fixed compilation on windoze.
20920 2002-08-03 Martin Baulig <martin@gnome.org>
20922 * interface.cs (Interface.GetInterfaceBases): Check whether all
20923 base interfaces are at least as accessible than the current one.
20925 * class.cs (TypeContainer.GetClassBases): Check whether base types
20926 are at least as accessible than the current type.
20927 (TypeContainer.AsAccessible): Implemented and made non-static.
20928 (MemberBase.CheckParameters): Report errors if the accessibility
20931 * delegate.cs (Delegate.Delegate): The default visibility is
20932 internal for top-level types and private for nested types.
20933 (Delegate.Define): Report errors if the accessibility checks fail.
20935 * enum.cs (Enum.Enum): The default visibility is internal for
20936 top-level types and private for nested types.
20937 (Enum.DefineType): Compute the correct visibility.
20939 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
20940 function which takes a `bool is_toplevel' instead of a TypeContainer.
20942 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
20945 2002-08-02 Martin Baulig <martin@gnome.org>
20947 * expression.cs (LocalVariableReferenc): Added constructor which
20948 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
20949 (LocalVariableReference.IsReadOnly): New property.
20950 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
20951 variable is readonly, use our own readonly flag to do this; you can
20952 use the new constructor to get a writable reference to a read-only
20955 * cs-parser.jay (foreach_statement, using_statement): Get a writable
20956 reference to the local variable.
20958 2002-08-01 Miguel de Icaza <miguel@ximian.com>
20960 * rootcontext.cs (ResolveCore): Also include System.Exception
20962 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
20963 we reach an EmptyStatement.
20965 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
20968 * expression.cs (Binary.ResolveOperator): Check error result in
20971 use brtrue/brfalse directly and avoid compares to null.
20973 2002-08-02 Martin Baulig <martin@gnome.org>
20975 * class.cs (TypeContainer.Define): Define all nested interfaces here.
20976 Fixes bug #28407, added test-155.cs.
20978 2002-08-01 Martin Baulig <martin@gnome.org>
20980 * class.cs (Event.EmitDefaultMethod): Make this work with static
20981 events. Fixes #28311, added verify-3.cs.
20983 2002-08-01 Martin Baulig <martin@gnome.org>
20985 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
20986 `is_disposable' fields.
20987 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
20988 `hm.is_disposable' if we're using the collection pattern.
20989 (Foreach.EmitCollectionForeach): Use the correct type for the
20990 enumerator's local variable, only emit the try/finally block if
20991 necessary (fixes #27713).
20993 2002-08-01 Martin Baulig <martin@gnome.org>
20995 * ecore.cs (Expression.report118): Renamed to Error118 and made
20998 * statement.cs (Throw.Resolve): Check whether the expression is of
20999 the correct type (CS0118) and whether the type derives from
21000 System.Exception (CS0155).
21001 (Catch.Resolve): New method. Do the type lookup here and check
21002 whether it derives from System.Exception (CS0155).
21003 (Catch.CatchType, Catch.IsGeneral): New public properties.
21005 * typemanager.cs (TypeManager.exception_type): Added.
21007 2002-07-31 Miguel de Icaza <miguel@ximian.com>
21009 * driver.cs: Updated About function.
21011 2002-07-31 Martin Baulig <martin@gnome.org>
21013 Implemented Control Flow Analysis.
21015 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
21016 (EmitContext.CurrentBranching): Added.
21017 (EmitContext.StartFlowBranching): Added.
21018 (EmitContext.EndFlowBranching): Added.
21019 (EmitContext.KillFlowBranching): Added.
21020 (EmitContext.IsVariableAssigned): Added.
21021 (EmitContext.SetVariableAssigned): Added.
21022 (EmitContext.IsParameterAssigned): Added.
21023 (EmitContext.SetParameterAssigned): Added.
21024 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
21025 Added control flow analysis stuff here.
21027 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
21028 resolve the expression as lvalue.
21029 (LocalVariableReference.DoResolve): Check whether the variable has
21030 already been assigned.
21031 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
21032 the parameter as assigned here.
21033 (ParameterReference.DoResolve): Check whether the parameter has already
21035 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
21036 expression as lvalue.
21038 * statement.cs (FlowBranching): New class for the flow analysis code.
21039 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
21040 (LabeledStatement.IsDefined): New public property.
21041 (LabeledStatement.AddUsageVector): New public method to tell flow
21042 analyis that the label may be reached via a forward jump.
21043 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
21045 (VariableInfo.Number): New public field. This is used by flow analysis
21046 to number all locals of a block.
21047 (Block.CountVariables): New public property. This is the number of
21048 local variables in this block (including the locals from all parent
21050 (Block.EmitMeta): Number all the variables.
21052 * statement.cs: Added flow analysis support to all classes.
21054 2002-07-31 Martin Baulig <martin@gnome.org>
21056 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
21057 To get debugging messages, compile mcs with /define:MCS_DEBUG and
21058 then use this argument.
21060 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
21062 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
21063 use this to specify /define options.
21065 2002-07-29 Martin Baulig <martin@gnome.org>
21067 * statement.cs (Fixed): Moved all code that does variable lookups
21068 and resolvings from Emit to Resolve.
21070 * statement.cs (For): Moved all code that does variable lookups
21071 and resolvings from Emit to Resolve.
21073 * statement.cs (Using): Moved all code that does variable lookups
21074 and resolvings from Emit to Resolve.
21076 2002-07-29 Martin Baulig <martin@gnome.org>
21078 * attribute.cs (Attribute.Resolve): Explicitly catch a
21079 System.NullReferenceException when creating the
21080 CustromAttributeBuilder and report a different warning message.
21082 2002-07-29 Martin Baulig <martin@gnome.org>
21084 * support.cs (ParameterData.ParameterName): Added method to
21085 get the name of a parameter.
21087 * typemanager.cs (TypeManager.IsValueType): New public method.
21089 2002-07-29 Martin Baulig <martin@gnome.org>
21091 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
21092 is a flag which specifies that it's either ref or out.
21093 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
21094 the out parameter to `out Parameter.Modifier mod', also set the
21095 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
21097 * support.cs (InternalParameters.ParameterModifier): Distinguish
21098 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21099 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21101 * expression.cs (Argument.GetParameterModifier): Distinguish
21102 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21103 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21105 2002-07-29 Martin Baulig <martin@gnome.org>
21107 * expression.cs (ParameterReference.ParameterReference): Added
21108 `Location loc' argument to the constructor.
21110 * cs-parser.jay: Pass location to ParameterReference.
21112 2002-07-28 Miguel de Icaza <miguel@ximian.com>
21114 * statement.cs (Try): Initialize the location.
21116 * cs-parser.jay: pass location to Try.
21118 * expression.cs (Unary.Reduce): Change the prototype to return
21119 whether a constant fold could be performed or not. The result is
21120 returned in an out parameters. In the case of Indirection and
21121 AddressOf, we want to perform the full tests.
21123 2002-07-26 Miguel de Icaza <miguel@ximian.com>
21125 * statement.cs (Statement.Emit): Flag dead code.
21127 2002-07-27 Andrew Birkett <andy@nobugs.org>
21129 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
21131 2002-07-27 Martin Baulig <martin@gnome.org>
21133 * class.cs (MethodData.Define): Put back call to
21134 TypeManager.AddMethod(), accidentally commented this out.
21136 * report.cs (Debug): New public method to print debugging information,
21137 this is `[Conditional ("DEBUG")]'.
21139 2002-07-26 Martin Baulig <martin@gnome.org>
21141 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
21142 (switch_statement): Push the current_block to the switch_stack and
21143 pop it again when we're done with the switch.
21144 (switch_section): The new block is a child of the current_block.
21145 Fixes bug #24007, added test-152.cs.
21147 2002-07-27 Martin Baulig <martin@gnome.org>
21149 * expression.cs (Invocation.EmitArguments): When calling a varargs
21150 function with only its fixed arguments, we need to pass an empty
21153 2002-07-27 Martin Baulig <martin@gnome.org>
21155 Mono 0.13 has been released.
21157 2002-07-25 Miguel de Icaza <miguel@ximian.com>
21159 * driver.cs: Rename --resource to --linkres, because that is what
21160 we do currently, we dont support --resource yet.
21162 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
21164 2002-07-25 Martin Baulig <martin@gnome.org>
21166 * class.cs (MethodData): New public class. This is a `method builder'
21167 class for a method or one accessor of a Property/Indexer/Event.
21168 (MethodData.GetMethodFlags): Moved here from MemberBase.
21169 (MethodData.ApplyAttributes): Likewise.
21170 (MethodData.ApplyObsoleteAttribute): Likewise.
21171 (MethodData.ApplyConditionalAttribute): Likewise.
21172 (MethodData.ApplyDllImportAttribute): Likewise.
21173 (MethodData.CheckAbstractAndExternal): Likewise.
21174 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
21175 (MethodData.Emit): Formerly known as Method.Emit().
21176 (MemberBase): Moved everything which was specific to a single
21177 accessor/method to MethodData.
21178 (Method): Create a new MethodData and call Define() and Emit() on it.
21179 (Property, Indexer, Event): Create a new MethodData objects for each
21180 accessor and call Define() and Emit() on them.
21182 2002-07-25 Martin Baulig <martin@gnome.org>
21184 Made MethodCore derive from MemberBase to reuse the code from there.
21185 MemberBase now also checks for attributes.
21187 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
21188 (MemberBase.GetMethodFlags): Moved here from class Method and marked
21190 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
21191 `CallingConventions cc' and `Attributes opt_attrs' arguments.
21192 (MemberBase.ApplyAttributes): New virtual method; applies the
21193 attributes to a method or accessor.
21194 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
21195 (MemberBase.ApplyConditionalAttribute): Likewise.
21196 (MemberBase.ApplyDllImportAttribute): Likewise.
21197 (MemberBase.CheckAbstractAndExternal): Likewise.
21198 (MethodCore.ParameterTypes): This is now a property instead of a
21199 method, it's initialized from DoDefineParameters().
21200 (MethodCore.ParameterInfo): Removed the set accessor.
21201 (MethodCore.DoDefineParameters): New protected virtual method to
21202 initialize ParameterTypes and ParameterInfo.
21203 (Method.GetReturnType): We can now simply return the MemberType.
21204 (Method.GetMethodFlags): Override the MemberBase version and add
21205 the conditional flags.
21206 (Method.CheckBase): Moved some code from Define() here, call
21207 DoDefineParameters() here.
21208 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
21209 here to avoid some larger code duplication.
21210 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
21211 ensure that abstract and external accessors don't declare a body.
21213 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
21214 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
21215 lookup in the attribute's parent classes, so we need to abort as soon
21216 as we found the first match.
21217 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
21218 the attribute has no arguments.
21220 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
21223 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21225 * cs-parser.jay: reverted previous patch.
21227 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21229 * cs-parser.jay: fixed bug #22119.
21231 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21233 * attribute.cs: fixed compilation. The error was:
21234 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
21235 be assigned to before control leaves the current method."
21236 [FIXME: Filed as bug #28186: MCS must report this error.]
21238 2002-07-25 Martin Baulig <martin@gnome.org>
21240 * attribute.cs (Attribute.Conditional_GetConditionName): New static
21241 method to pull the condition name ouf of a Conditional attribute.
21242 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
21243 the obsolete message and error flag out of an Obsolete attribute.
21245 * class.cs (Method.GetMethodFlags): New public method to get the
21246 TypeManager.MethodFlags for this method.
21247 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
21249 (Method.Define): Get and apply the Obsolete and Conditional attributes;
21250 if we're overriding a virtual function, set the new private variable
21251 `parent_method'; call the new TypeManager.AddMethod().
21253 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
21254 the MethodBuilder and the Method in a PtrHashtable.
21255 (TypeManager.builder_to_method): Added for this purpose.
21256 (TypeManager.MethodFlags): Added IsObsoleteError.
21257 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
21258 Obsolete and Conditional arguments in MethodBuilders. If we discover
21259 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
21260 the message from the attribute.
21262 2002-07-24 Martin Baulig <martin@gnome.org>
21264 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
21265 preprocessor directives, ensure that the argument to #define/#undef is
21266 exactly one identifier and that it's actually an identifier.
21268 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
21271 2002-07-24 Martin Baulig <martin@gnome.org>
21273 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
21274 initialize it to TypeManager.object_type in the constructor.
21275 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
21276 of the `hm.get_current' method if we're using the collection pattern.
21277 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
21278 for the explicit conversion to make it work when we're using the collection
21279 pattern and the `Current' property has a different return type than `object'.
21282 2002-07-24 Martin Baulig <martin@gnome.org>
21284 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
21285 does not match, but don't report any errors. This method is called in
21286 order for all methods in a MethodGroupExpr until a matching method is
21287 found, so we don't want to bail out if the first method doesn't match.
21288 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
21289 matches, report the 123. Fixes #28070.
21291 2002-07-24 Martin Baulig <martin@gnome.org>
21293 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
21294 TypeManager.TypeToCoreType() to the top of the method so the
21295 following equality checks will work. Fixes #28107.
21297 2002-07-24 Martin Baulig <martin@gnome.org>
21299 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
21300 operand is of type uint, and the other operand is of type sbyte,
21301 short or int, the operands are converted to type long." -
21302 Actually do what this comment already told us. Fixes bug #28106,
21305 2002-07-24 Martin Baulig <martin@gnome.org>
21307 * class.cs (MethodBase): New abstract class. This is now a base
21308 class for Property, Indexer and Event to avoid some code duplication
21309 in their Define() and DefineMethods() methods.
21310 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
21311 generic methods for Define() and DefineMethods().
21312 (FieldBase): Derive from MemberBase, not MemberCore.
21313 (Property): Derive from MemberBase, not MemberCore.
21314 (Property.DefineMethod): Moved all the code from this method to the
21315 new MethodBase.DefineAccessor(), just call it with appropriate
21317 (Property.Define): Call the new Property.DoDefine(), this does some
21318 sanity checks and we don't need to duplicate the code everywhere.
21319 (Event): Derive from MemberBase, not MemberCore.
21320 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
21321 accessors, this will also make them work with interface events.
21322 (Indexer): Derive from MemberBase, not MemberCore.
21323 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
21324 (Indexer.Define): Use the new MethodBase functions.
21326 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
21327 argument to the constructor.
21328 (Interface.FindMembers): Added support for interface events.
21329 (Interface.PopluateEvent): Implemented.
21331 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
21333 2002-07-22 Miguel de Icaza <miguel@ximian.com>
21335 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
21336 but this is required to check for a method name being the same as
21337 the containing class.
21341 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21343 * interface.cs: initialize variable.
21345 2002-07-23 Martin Baulig <martin@gnome.org>
21347 Implemented the IndexerName attribute in interfaces.
21349 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
21350 name if this is an explicit interface implementation.
21351 (Indexer.InterfaceIndexerName): New public variable. If we're
21352 implementing an interface indexer, this is the IndexerName in that
21353 interface. Otherwise, it's the IndexerName.
21354 (Indexer.DefineMethod): If we're implementing interface indexer,
21355 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
21356 and Pending.ImplementIndexer methods.
21357 (Indexer.Define): Also define the PropertyBuilder if we're
21358 implementing an interface indexer and this is neither an explicit
21359 interface implementation nor do the IndexerName match the one in
21362 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
21363 If a method is defined here, then we always need to create a proxy
21364 for it. This is used when implementing interface indexers.
21365 (Pending.IsInterfaceIndexer): New public method.
21366 (Pending.ImplementIndexer): New public method.
21367 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
21368 This is used when implementing interface indexers to define a proxy
21370 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
21371 define a proxy if necessary.
21373 * interface.cs (Interface.IndexerName): New public variable.
21374 (Interface.PopulateIndexer): Set the IndexerName.
21375 (Interface.DefineIndexers): New private method. Populate all the
21376 indexers and make sure their IndexerNames match.
21378 * typemanager.cs (IndexerPropertyName): Added support for interface
21381 2002-07-22 Martin Baulig <martin@gnome.org>
21383 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
21384 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
21385 ret if HasReturnLabel.
21386 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
21389 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
21390 and set the ec.LoopBeginTryCatchLevel.
21391 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
21392 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
21393 the current ec.TryCatchLevel, the branch goes out of an exception
21394 block. In this case, we need to use Leave and not Br.
21396 2002-07-22 Martin Baulig <martin@gnome.org>
21398 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
21399 block unless the block does not always return or it is contained in
21400 another try { ... } catch { ... } block. Fixes bug #26506.
21401 Added verify-1.cs to the test suite.
21403 2002-07-22 Martin Baulig <martin@gnome.org>
21405 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
21406 then we do not always return. Fixes bug #24985.
21408 2002-07-22 Martin Baulig <martin@gnome.org>
21410 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
21411 lookup on a per-class level; ie. walk up the class hierarchy until we
21412 found at least one applicable method, then choose the best among them.
21413 Fixes bug #24463 and test-29.cs.
21415 2002-07-22 Martin Baulig <martin@gnome.org>
21417 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
21418 return types of the methods. The return type is not part of the
21419 signature and we must not check it to make the `new' modifier work.
21420 Fixes bug #27999, also added test-147.cs.
21421 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
21423 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
21424 on the method's return type.
21426 2002-07-21 Martin Baulig <martin@gnome.org>
21428 * assign.cs: Make this work if the rightmost source is a constant and
21429 we need to do an implicit type conversion. Also adding a few more tests
21430 to test-38.cs which should have caught this.
21432 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
21433 target in the makefile for this. The makefile.gnu is primarily intended
21434 for end-users who don't want to debug the compiler.
21436 2002-07-21 Martin Baulig <martin@gnome.org>
21438 * assign.cs: Improved the Assign class so it can now handle embedded
21439 assignments (X = Y = Z = something). As a side-effect this'll now also
21440 consume less local variables. test-38.cs now passes with MCS, added
21441 a few new test cases to that test.
21443 2002-07-20 Martin Baulig <martin@gnome.org>
21445 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
21446 instructions. Fixes bug #27977, also added test-146.cs.
21448 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21450 * cs-tokenizer.cs: fixed getHex ().
21452 2002-07-19 Martin Baulig <martin@gnome.org>
21454 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
21455 not Type.GetType() to lookup the array type. This is needed when
21456 we're constructing an array of a user-defined type.
21457 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
21458 single-dimensional arrays, but also for single-dimensial arrays of
21461 2002-07-19 Martin Baulig <martin@gnome.org>
21463 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
21464 this function is called, it's not allowed to share LocalBuilders
21465 among ILGenerators.
21467 2002-07-19 Martin Baulig <martin@gnome.org>
21469 * expression.cs (Argument.Resolve): Report an error 118 when trying
21470 to pass a type as argument.
21472 2002-07-18 Martin Baulig <martin@gnome.org>
21474 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
21475 Conv_R_Un for the signed `long' type.
21477 2002-07-15 Miguel de Icaza <miguel@ximian.com>
21479 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
21480 `expr' for the temporary result, as that will fail if we do
21481 multiple resolves on the same expression.
21483 2002-07-05 Miguel de Icaza <miguel@ximian.com>
21485 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
21486 ec.TypeContainer for looking up aliases.
21488 * class.cs (TypeContainer): Remove LookupAlias from here.
21490 * decl.cs (DeclSpace); Move here.
21492 2002-07-01 Miguel de Icaza <miguel@ximian.com>
21494 * class.cs (FindMembers): Only call filter if the constructor
21495 bulider is not null.
21497 Also handle delegates in `NestedTypes' now. Now we will perform
21498 type lookups using the standard resolution process. This also
21501 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
21502 This uses Expressions (the limited kind that can be parsed by the
21503 tree) instead of strings.
21505 * expression.cs (ComposedCast.ToString): Implement, used to flag
21506 errors since now we have to render expressions.
21508 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
21511 * ecore.cs (SimpleName.ToString): ditto.
21513 * cs-parser.jay: Instead of using strings to assemble types, use
21514 Expressions to assemble the type (using SimpleName, ComposedCast,
21515 MemberAccess). This should fix the type lookups in declarations,
21516 because we were using a different code path for this.
21518 * statement.cs (Block.Resolve): Continue processing statements
21519 even when there is an error.
21521 2002-07-17 Miguel de Icaza <miguel@ximian.com>
21523 * class.cs (Event.Define): Also remove the `remove' method from
21524 the list of pending items.
21526 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
21527 generate more compact code.
21529 2002-07-17 Martin Baulig <martin@gnome.org>
21531 * const.cs (Const.LookupConstantValue): Add support for constant
21532 `unchecked' and `checked' expressions.
21533 Also adding test case test-140.cs for this.
21535 2002-07-17 Martin Baulig <martin@gnome.org>
21537 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
21538 check whether mi.ReturnType implements the IEnumerator interface; the
21539 `==' and the IsAssignableFrom() will fail in this situation.
21541 2002-07-16 Ravi Pratap <ravi@ximian.com>
21543 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
21546 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21548 * expression.cs: fixed bug #27811.
21550 2002-07-14 Miguel de Icaza <miguel@ximian.com>
21552 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
21553 Molaro: when we are a ref, the value already contains a pointer
21554 value, do not take the address of it.
21556 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21557 * removed mb-parser.jay and mb-tokenizer.cs
21559 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21561 * expression.cs: check against the building corlib void type.
21563 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
21565 * ecore.cs: fix for valuetype static readonly fields: when
21566 initializing them, we need their address, not the address of a copy.
21568 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
21570 * typemanager.cs: register also enum_type in corlib.
21572 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21574 * class.cs: allow calling this (but not base) initializers in structs.
21576 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
21578 * ecore.cs: make sure we compare against the building base types
21581 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
21583 * typemanager.cs: fix TypeToCoreType() to handle void and object
21584 (corlib gets no more typerefs after this change).
21586 2002-07-12 Miguel de Icaza <miguel@ximian.com>
21588 * expression.cs (ArrayCreation.EmitArrayArguments): use
21589 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
21591 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
21592 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
21593 array indexes, the runtime actually forbids them.
21595 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
21596 for array arguments here.
21598 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
21599 instead of the default for ValueTypes.
21601 (New.DoEmit): Use IsValueType instead of
21602 IsSubclassOf (value_type)
21603 (New.DoResolve): ditto.
21604 (Invocation.EmitCall): ditto.
21606 * assign.cs (Assign): ditto.
21608 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
21609 Statements *are* currently doing part of their resolution during
21612 Expressions do always resolve during resolve, but statements are
21613 only required to propagate resolution to their children.
21615 2002-07-11 Miguel de Icaza <miguel@ximian.com>
21617 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
21619 (LoadAssembly): Do not add the dll if it is already specified
21621 (MainDriver): Add the System directory to the link path at the end,
21622 after all the other -L arguments.
21624 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
21625 wrong opcode for loading bytes and bools (ldelem.i1 instead of
21626 ldelem.u1) and using the opposite for sbytes.
21628 This fixes Digger, and we can finally run it.
21630 * driver.cs (UnixParseOption): Move the option parsing here.
21631 (CSCParseOption): Implement CSC-like parsing of options.
21633 We now support both modes of operation, the old Unix way, and the
21634 new CSC-like way. This should help those who wanted to make cross
21635 platform makefiles.
21637 The only thing broken is that /r:, /reference: and /lib: are not
21638 implemented, because I want to make those have the same semantics
21639 as the CSC compiler has, and kill once and for all the confussion
21640 around this. Will be doing this tomorrow.
21642 * statement.cs (Unsafe.Resolve): The state is checked during
21643 resolve, not emit, so we have to set the flags for IsUnsfe here.
21645 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21647 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
21648 not catch the Error_ObjectRefRequired in SimpleName (as it is
21649 possible to have a class/instance variable name that later gets
21650 deambiguated), we have to check this here.
21652 2002-07-10 Ravi Pratap <ravi@ximian.com>
21654 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
21655 make static and put into Expression.
21657 (Event.Define): Register the private field of the event with the
21658 TypeManager so that GetFieldFromEvent can get at it.
21660 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
21661 keep track of the private field associated with an event which
21664 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
21667 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
21669 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21671 * expression.cs (Binary.EmitBranchable): this routine emits the
21672 Binary expression in a branchable context. This basically means:
21673 we need to branch somewhere, not just get the value on the stack.
21675 This works together with Statement.EmitBoolExpression.
21677 * statement.cs (Statement.EmitBoolExpression): Use
21680 2002-07-09 Miguel de Icaza <miguel@ximian.com>
21682 * statement.cs (For): Reduce the number of jumps in loops.
21684 (For): Implement loop inversion for the For statement.
21686 (Break): We can be breaking out of a Try/Catch controlled section
21687 (foreach might have an implicit try/catch clause), so we need to
21688 use Leave instead of Br.
21690 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
21691 now). If the instace expression supports IMemoryLocation, we use
21692 the AddressOf method from the IMemoryLocation to extract the
21693 address instead of emitting the instance.
21695 This showed up with `This', as we were emitting the instance
21696 always (Emit) instead of the Address of This. Particularly
21697 interesting when This is a value type, as we dont want the Emit
21698 effect (which was to load the object).
21700 2002-07-08 Miguel de Icaza <miguel@ximian.com>
21702 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
21704 * statement.cs (Checked): Set the CheckedState during the resolve
21705 process too, as the ConvCast operations track the checked state on
21706 the resolve process, and not emit.
21708 * cs-parser.jay (namespace_member_declaration): Flag that we have
21709 found a declaration when we do. This is used to flag error 1529
21711 * driver.cs: Report ok when we display the help only.
21713 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
21715 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
21717 2002-07-04 Miguel de Icaza <miguel@ximian.com>
21719 * cs-tokenizer.cs (define): We also have to track locally the
21720 defines. AllDefines is just used for the Conditional Attribute,
21721 but we also need the local defines for the current source code.
21723 2002-07-03 Miguel de Icaza <miguel@ximian.com>
21725 * statement.cs (While, For, Do): These loops can exit through a
21726 Break statement, use this information to tell whether the
21727 statement is the last piece of code.
21729 (Break): Flag that we break.
21731 * codegen.cs (EmitContexts): New `Breaks' state variable.
21733 2002-07-03 Martin Baulig <martin@gnome.org>
21735 * class.cs (TypeContainer.MethodModifiersValid): Allow override
21736 modifiers in method declarations in structs. Otherwise, you won't
21737 be able to override things like Object.Equals().
21739 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21741 * class.cs (Method, Property, Indexer): Do not allow the public
21742 modifier to be used in explicit interface implementations.
21744 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
21745 override modifiers in method declarations in structs
21747 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
21749 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
21750 integer or real overflow, report an error
21752 2002-07-02 Martin Baulig <martin@gnome.org>
21754 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
21755 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
21756 to tell the runtime about our newly created System.Object and
21757 System.ValueType types.
21759 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21761 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
21762 struct instead of Ldarg/Starg.
21764 2002-07-02 Martin Baulig <martin@gnome.org>
21766 * expression.cs (Indirection.Indirection): Call
21767 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
21769 2002-07-02 Martin Baulig <martin@gnome.org>
21771 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
21772 ValueType, call TypeManager.TypeToCoreType() on it.
21773 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
21774 the OpCodes.Newarr argument.
21776 2002-07-02 Martin Baulig <martin@gnome.org>
21778 * expression.cs (Invocation.EmitCall): When compiling corlib,
21779 replace all calls to the system's System.Array type to calls to
21780 the newly created one.
21782 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
21783 System.Array methods.
21784 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
21785 from the system's System.Array type which must be replaced.
21787 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
21789 * typemanager.cs: load unverifiable_code_ctor so we can build
21790 corlib using the correct type. Avoid using GetTypeCode() with
21792 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
21793 TypeManager.object_type to allow building corlib.
21795 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
21797 * ecore.cs: handle System.Enum separately in LoadFromPtr().
21799 2002-07-01 Martin Baulig <martin@gnome.org>
21801 * class.cs: Make the last change actually work, we need to check
21802 whether `ifaces != null' to avoid a crash.
21804 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21806 * class.cs: when we build structs without fields that implement
21807 interfaces, we need to add the interfaces separately, since there is
21808 no API to both set the size and add the interfaces at type creation
21811 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21813 * expression.cs: the dimension arguments to the array constructors
21814 need to be converted if they are a long.
21816 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
21818 * class.cs: don't emit ldarg.0 if there is no parent constructor
21819 (fixes showstopper for corlib).
21821 2002-06-29 Martin Baulig <martin@gnome.org>
21823 MCS now compiles corlib on GNU/Linux :-)
21825 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
21826 ie. check for MethodImplOptions.InternalCall.
21828 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
21829 and TypeManager.attribute_type are null, so we must explicitly check
21830 whether parent is not null to find out whether it's an attribute type.
21831 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
21832 and SetBuilder, not only if the property is neither abstract nor external.
21833 This is necessary to set the MethodImplOptions on the accessor methods.
21834 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
21835 SetBuilder, see Property.Emit().
21837 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
21838 populate "System.Object", "System.ValueType" and "System.Attribute" since
21839 they've already been populated from BootCorlib_PopulateCoreTypes().
21841 2002-06-29 Martin Baulig <martin@gnome.org>
21843 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
21844 is the NullLiteral, we also need to make sure that target_type is not
21847 2002-06-29 Martin Baulig <martin@gnome.org>
21849 * rootcontext.cs (RootContext.ResolveCore): We must initialize
21850 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
21851 before calling BootstrapCorlib_ResolveDelegate ().
21853 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21855 * statement.cs: fixed build-breaker. All tests passed ok.
21857 2002-06-27 Martin Baulig <martin@gnome.org>
21859 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
21860 for System.Decimal when compiling corlib.
21862 2002-06-27 Martin Baulig <martin@gnome.org>
21864 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
21865 switch blocks which contain nothing but a default clause.
21867 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
21869 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
21871 2002-06-27 Martin Baulig <martin@gnome.org>
21873 * ecore.cs (PropertyExpr.PropertyExpr): Call
21874 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
21876 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
21877 is already a TypeBuilder.
21879 2002-06-27 Martin Baulig <martin@gnome.org>
21881 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
21882 `target_type == TypeManager.array_type', not IsAssignableFrom() in
21883 the "from an array-type to System.Array" case. This makes it work
21884 when compiling corlib.
21886 2002-06-27 Martin Baulig <martin@gnome.org>
21888 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
21889 non-static PropertyExpr, set its InstanceExpression. This makes
21890 the `ICollection.Count' property work in System/Array.cs.
21892 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
21894 * driver.cs: Made error handling more consistent. Errors now
21895 tracked by Report class, so many methods which used to return int
21896 now return void. Main() now prints success/failure and
21897 errors/warnings message.
21899 Renamed '--probe' compiler argument to '--expect-error'. Removed
21900 the magic number return values (123 and 124). Now, if the
21901 expected error occurs, the compiler exits with success (exit value
21902 0). If the compilation completes without seeing that particular
21903 error, the compiler exits with failure (exit value 1). The
21904 makefile in mcs/errors has been changed to handle the new behaviour.
21906 * report.cs: Made 'expected error' number a property and renamed
21907 it from 'Probe' to 'ExpectedError'.
21909 * genericparser.cs: Removed error handling support, since it is
21910 now all done by Report class.
21912 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
21913 class, so parse() no longer returns an int.
21915 * namespace.cs: Use Report.Error instead of GenericParser.error
21917 2002-06-22 Miguel de Icaza <miguel@ximian.com>
21919 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
21920 TypeContainer.AddOperator): At the front of the list put the
21921 explicit implementations, so they get resolved/defined first.
21923 2002-06-21 Miguel de Icaza <miguel@ximian.com>
21925 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
21926 interface type is implemented by this TypeContainer. Used during
21927 explicit interface implementation.
21929 (Property.Define, Indexer.Define, Method.Define): Validate that
21930 the given interface in the explicit implementation is one of the
21931 base classes for the containing type.
21933 Also if we are explicitly implementing an interface, but there is
21934 no match in the pending implementation table, report an error.
21936 (Property.Define): Only define the property if we are
21937 not explicitly implementing a property from an interface. Use the
21938 correct name also for those properties (the same CSC uses,
21939 although that is really not needed).
21941 (Property.Emit): Do not emit attributes for explicitly implemented
21942 properties, as there is no TypeBuilder.
21944 (Indexer.Emit): ditto.
21946 Hiding then means that we do not really *implement* a pending
21947 implementation, which makes code fail.
21949 2002-06-22 Martin Baulig <martin@gnome.org>
21951 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
21952 the return value of Object.GetType(). [FIXME: we need to do this whenever
21953 we get a type back from the reflection library].
21955 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
21957 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
21959 2002-06-20 Miguel de Icaza <miguel@ximian.com>
21961 * attribute.cs: Return null if we can not look up the type.
21963 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
21964 the interface types found.
21966 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
21967 interface types found.
21969 * typemanager.cs (GetInterfaces): Make this routine returns alll
21970 the interfaces and work around the lame differences between
21971 System.Type and System.Reflection.Emit.TypeBuilder in the results
21972 result for GetInterfaces.
21974 (ExpandInterfaces): Given an array of interface types, expand and
21975 eliminate repeated ocurrences of an interface. This expands in
21976 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
21979 2002-06-21 Martin Baulig <martin@gnome.org>
21981 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
21984 2002-06-21 Martin Baulig <martin@gnome.org>
21986 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
21987 and called with one of the core types, return the corresponding typebuilder for
21990 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
21993 2002-06-21 Martin Baulig <martin@gnome.org>
21995 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
21996 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
21997 (Expression.ConvertReferenceExplicit): Likewise.
21999 * expression.cs (ElementAccess.DoResolve): Likewise.
22000 (ElementAccess.DoResolveLValue): Likewise.
22002 2002-06-10 Martin Baulig <martin@gnome.org>
22004 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
22005 add the "value" parameter to the parameter list.
22007 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
22010 2002-06-19 Miguel de Icaza <miguel@ximian.com>
22012 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
22013 the argument to an int, uint, long or ulong, per the spec. Also
22014 catch negative constants in array creation.
22016 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
22018 * class.cs: do not allow the same interface to appear twice in
22019 the definition list.
22021 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
22023 * ecore.cs: don't use ldlen with System.Array.
22025 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
22027 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
22029 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
22031 * modifiers.cs: produce correct field attributes for protected
22032 internal. Easy fix so miguel can work on ther harder stuff:-)
22034 2002-06-18 Miguel de Icaza <miguel@ximian.com>
22036 * pending.cs: New file. Move the code from class.cs here.
22037 Support clearning the pending flag for all methods (when not doing
22038 explicit interface implementation).
22040 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
22042 * rootcontext.cs: added a couple more types needed to bootstrap.
22044 2002-06-17 Miguel de Icaza <miguel@ximian.com>
22046 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
22047 constructor in the type, instead of any constructor in the type
22048 hierarchy. Thanks to Paolo for finding this bug (it showed up as
22049 a bug in the Mono runtime when applying the params attribute).
22051 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
22052 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
22054 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
22056 * expression.cs (Unary.ResolveOperator): Use TypeManager
22057 to resolve the type.
22059 2002-06-13 Ravi Pratap <ravi@ximian.com>
22061 * cs-parser.jay (enum_member_declaration): Pass in the attributes
22064 * enum.cs (AddEnumMember): Add support to store the attributes associated
22065 with each member too.
22067 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
22068 field builders too - this takes care of the enum member case.
22070 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
22072 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
22073 address-of operator on both value types and pointers.
22075 2002-06-10 Martin Baulig <martin@gnome.org>
22077 * interface.cs (Interface.PopulateIndexer): Add the indexer's
22078 PropertyBuilder to the `property_builders' list.
22080 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
22081 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
22082 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
22083 find any indexers which are inherited from an interface.
22085 2002-06-09 Martin Baulig <martin@gnome.org>
22087 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
22088 the same type as the constant if necessary. There's also a test-130.cs
22091 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
22093 * typemanager.cs (TypeManager.ChangeType): Previously known as
22094 Enum.ChangeEnumType().
22096 2002-06-09 Martin Baulig <martin@gnome.org>
22098 * expression.cs (Cast.TryReduce): Added support for consts.
22100 2002-06-08 Ravi Pratap <ravi@ximian.com>
22102 * class.cs (Accessor): Hold attributes information so we can pass
22105 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
22106 Modify to pass in attributes attached to the methods.
22108 (add_accessor_declaration, remove_accessor_declaration): Ditto.
22110 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
22111 to handle the Accessor kind :-)
22113 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
22115 2002-06-08 Martin Baulig <martin@gnome.org>
22117 * expression.cs (Unary.TryReduceNegative): Added support for
22120 2002-06-08 Martin Baulig <martin@gnome.org>
22122 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
22123 name can't be found in the `defined_names' - the caller will do a
22124 MemberLookup in this case and thus find methods in System.Enum
22125 such as Enum.IsDefined().
22127 2002-06-08 Martin Baulig <martin@gnome.org>
22129 * enum.cs (Enum.ChangeEnumType): This is a custom version of
22130 Convert.ChangeType() which works with TypeBuilder created types.
22131 (Enum.LookupEnumValue, Enum.Define): Use it here.
22133 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
22134 `TypeBuilder.BaseType != null' check.
22135 (TypeContainer.FindMembers): Only lookup parent members if we
22136 actually have a parent.
22137 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
22138 (ConstructorInitializer.Resolve): Likewise.
22140 * interface.cs (Interface.FindMembers): Added
22141 `TypeBuilder.BaseType != null' check.
22143 * rootcontext.cs (RootContext.ResolveCore): Added
22144 "System.Runtime.CompilerServices.IndexerNameAttribute" to
22145 classes_second_stage.
22147 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
22148 debug_type and trace_type when compiling with --nostdlib.
22150 2002-06-07 Martin Baulig <martin@gnome.org>
22152 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
22153 (AddField): Set it to true when adding a non-static field.
22154 (DefineType): Use `have_nonstatic_fields' to find out whether we
22155 have non-static fields, not `Fields != null'.
22157 2002-06-02 Miguel de Icaza <miguel@ximian.com>
22159 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
22160 dereferencing a null on the static-field code path)
22162 2002-05-30 Martin Baulig <martin@gnome.org>
22164 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
22165 to take command line arguments. Use reflection to call the new
22166 custom `Initialize' function on the symbol writer and pass it the
22167 command line arguments.
22169 * driver.cs (--debug-args): New command line argument to pass command
22170 line arguments to the symbol writer.
22172 2002-05-28 Miguel de Icaza <miguel@ximian.com>
22174 * assign.cs (DoResolve): Forgot to do the implicit conversion to
22175 the target type for indexers and properties. Thanks to Joe for
22178 2002-05-27 Miguel de Icaza <miguel@ximian.com>
22180 * typemanager.cs (MethodFlags): returns the method flags
22181 (Obsolete/ShouldIgnore) that control warning emission and whether
22182 the invocation should be made, or ignored.
22184 * expression.cs (Invocation.Emit): Remove previous hack, we should
22185 not do this on matching a base type, we should do this based on an attribute
22187 Only emit calls to System.Diagnostics.Debug and
22188 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
22189 on the command line.
22191 * rootcontext.cs: Global settings for tracing and debugging.
22193 * cs-tokenizer.cs (define): New utility function to track
22194 defines. Set the global settings for TRACE and DEBUG if found.
22196 2002-05-25 Ravi Pratap <ravi@ximian.com>
22198 * interface.cs (Populate*): Pass in the TypeContainer as well as
22199 the DeclSpace as parameters so that we can create EmitContexts and
22200 then use that to apply attributes etc.
22202 (PopulateMethod, PopulateEvent, PopulateProperty)
22203 (PopulateIndexer): Apply attributes everywhere.
22205 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
22208 (ApplyAttributes): Update accordingly.
22210 We now apply interface attributes for all members too.
22212 2002-05-26 Miguel de Icaza <miguel@ximian.com>
22214 * class.cs (Indexer.Define); Correctly check if we are explicit
22215 implementation (instead of checking the Name for a ".", we
22216 directly look up if the InterfaceType was specified).
22218 Delay the creation of the PropertyBuilder.
22220 Only create the PropertyBuilder if we are not an explicit
22221 interface implementation. This means that explicit interface
22222 implementation members do not participate in regular function
22223 lookups, and hence fixes another major ambiguity problem in
22224 overload resolution (that was the visible effect).
22226 (DefineMethod): Return whether we are doing an interface
22229 * typemanager.cs: Temporary hack until we get attributes in
22230 interfaces (Ravi is working on that) and we get IndexerName
22231 support in interfaces.
22233 * interface.cs: Register the indexers as properties.
22235 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
22236 warning, I have verified that this is a bug in the .NET runtime
22237 (JavaScript suffers of the same problem).
22239 * typemanager.cs (MemberLookup): When looking up members for
22240 interfaces, the parent of an interface is the implicit
22241 System.Object (so we succeed in searches of Object methods in an
22242 interface method invocation. Example: IEnumerable x; x.ToString
22245 2002-05-25 Miguel de Icaza <miguel@ximian.com>
22247 * class.cs (Event): Events should also register if they do
22248 implement the methods that an interface requires.
22250 * typemanager.cs (MemberLookup); use the new GetInterfaces
22253 (GetInterfaces): The code used to lookup interfaces for a type is
22254 used in more than one place, factor it here.
22256 * driver.cs: Track the errors at the bottom of the file, we kept
22259 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
22260 instance if the method we are calling is static!
22262 2002-05-24 Miguel de Icaza <miguel@ximian.com>
22264 * attribute.cs (ApplyAttributes): Make this function filter out
22265 the IndexerName attribute (as that attribute in reality is never
22266 applied) and return the string constant for the IndexerName
22269 * class.cs (TypeContainer.Emit): Validate that all the indexers
22270 have the same IndexerName attribute, and if so, set the
22271 DefaultName attribute on the class.
22273 * typemanager.cs: The return value might contain other stuff (not
22274 only methods). For instance, consider a method with an "Item"
22275 property and an Item method.
22277 * class.cs: If there is a problem with the parameter types,
22280 2002-05-24 Ravi Pratap <ravi@ximian.com>
22282 * ecore.cs (ImplicitConversionExists): Wrapper function which also
22283 looks at user defined conversion after making a call to
22284 StandardConversionExists - we need this for overload resolution.
22286 * expression.cs : Update accordingly the various method calls.
22288 This fixes 2 bugs filed against implicit user defined conversions
22290 2002-05-22 Miguel de Icaza <miguel@ximian.com>
22292 * statement.cs: Track the result of the assignment.
22294 2002-05-21 Miguel de Icaza <miguel@ximian.com>
22296 * expression.cs (MemberAccess): Improved error reporting for
22297 inaccessible members.
22299 2002-05-22 Martin Baulig <martin@gnome.org>
22301 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
22302 itself with debugging support.
22304 2002-05-22 Martin Baulig <martin@gnome.org>
22306 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
22307 Removed, this isn't needed anymore.
22309 2002-05-20 Martin Baulig <martin@gnome.org>
22311 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
22312 be underlying type for an enum.
22314 2002-05-20 Miguel de Icaza <miguel@ximian.com>
22316 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
22317 that splits out the loading of just the core types.
22319 * rootcontext.cs (ResolveCore): Split the struct resolution in
22320 two, so we can load the enumeration underlying types before any
22323 * expression.cs (Is): Bandaid until we fix properly Switch (see
22324 bug #24985 for details).
22326 * typemanager.cs (ImplementsInterface): The hashtable will contain
22327 a null if there are no interfaces implemented.
22329 2002-05-18 Miguel de Icaza <miguel@ximian.com>
22331 * cs-parser.jay (indexer_declarator): It is fine to have array
22334 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22336 * typemanager.cs: (RegisterBuilder): New function used to register
22337 TypeBuilders that implement interfaces. Since
22338 TypeBuilder.GetInterfaces (as usual) does not work with lame
22340 (AddUserType): register interfaces.
22342 (ImplementsInterface): Use the builder_to_ifaces hash if we are
22343 dealing with TypeBuilder. Also, arrays are showing up as
22344 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
22345 methods can not be invoked on them!
22347 * ecore.cs (ExplicitReferenceConversionExists): Made public.
22348 (ImplicitReferenceConversionExists): Split out from
22349 StandardConversionExists.
22351 * expression.cs (As): We were only implementing one of the three
22352 cases for the as operator. We now implement them all.
22353 (Is): Implement the various other cases for Is as well.
22355 * typemanager.cs (CACHE): New define used to control if we want or
22356 not the FindMembers cache. Seems to have a negative impact on
22357 performance currently
22359 (MemberLookup): Nested types have full acess to
22360 enclosing type members
22362 Remove code that coped with instance/static returns for events, we
22363 now catch this in RealFindMembers.
22365 (RealFindMembers): only perform static lookup if the instance
22366 lookup did not return a type or an event.
22368 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22370 * assign.cs (CompoundAssign): We pass more semantic information
22371 now to Compound Assignments than we did before: now we have all
22372 the information at hand, and now we resolve the target *before* we
22373 do the expression expansion, which allows the "CacheValue" method
22374 to have the effect we intended (before, a [x] += 1 would generate
22375 two differen ArrayAccess expressions from the ElementAccess,
22376 during the resolution process).
22378 (CompoundAssign.DoResolve): Resolve target and original_source here.
22380 2002-05-16 Miguel de Icaza <miguel@ximian.com>
22382 * expression.cs (ArrayAccess): dropped debugging information.
22384 * typemanager.cs: Small bug fix: I was always returning i_members,
22385 instead of one of i_members or s_members (depending on which had
22388 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
22389 method is invoked before any code generation takes place, and it
22390 is a mechanism to inform that the expression will be invoked more
22391 than once, and that the method should use temporary values to
22392 avoid having side effects
22394 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
22396 * ecore.cs (Expression.CacheTemporaries): Provide empty default
22399 * expression.cs (Indirection, ArrayAccess): Add support for
22400 CacheTemporaries in these two bad boys.
22402 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
22403 ldobj or ldind_ref.
22404 (StoreFromPtr): Handle stobj as well.
22406 * expression.cs (UnaryMutator): Share more code.
22408 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
22409 down: I was not tracking the Filter function as well, which
22410 was affecting the results of the cache.
22412 2002-05-15 Miguel de Icaza <miguel@ximian.com>
22414 * attribute.cs: Remove the hack to handle the CharSet property on
22417 2002-05-14 Miguel de Icaza <miguel@ximian.com>
22419 * attribute.cs (DoResolve): More uglyness, we now only try to
22420 resolve the attribute partially, to extract the CharSet
22421 information (only if we are a StructLayout attribute). Otherwise
22423 (GetExtraTypeInfo): Add some code to conditionally kill in the
22424 future this. I am more and more convinced that the .NET
22425 framework has special code to handle the attribute setting on
22428 * expression.cs (IsParamsMethodApplicable): Revert my previous
22429 foreach change here, it was wrong.
22431 2002-05-13 Miguel de Icaza <miguel@ximian.com>
22433 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
22434 (pp_expr): do not abort on unknown input, just return.
22435 (eval): abort if there are pending chars.
22437 * attribute.cs (Attribute.Resolve): Positional parameters are
22438 optional. Deal with that case.
22440 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
22441 the Ansi/Unicode/Auto information for the type.
22443 (TypeContainer.DefineType): instantiate the EmitContext here, as
22444 we will be using it during the type definition (to resolve
22445 attributes) and during the emit phase.
22447 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
22448 to pull type information out of the attributes
22450 (Attribute.Resolve): track the constructor builder, and allow for
22451 multiple invocations (structs and classes will use this).
22453 * ecore.cs (MemberLookupFinal): new version with all the
22454 parameters customizable.
22456 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
22457 constructors. Return if the result value is null (as the error
22458 would have been flagged already by MemberLookupFinal)
22460 Do not allow instances of abstract classes or interfaces to be
22463 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
22464 We have to compare the assembly property here when dealing with
22465 FamANDAssem and Assembly access modifiers, because we might be
22466 creating an assembly from *modules* (that means that we are not
22467 getting TypeBuilders for types defined in other modules that are
22468 part of this assembly).
22470 (Method.Emit): If the method is marked abstract and has a body,
22473 (TypeContainer.DefineMembers): If both the defined member and the
22474 parent name match are methods, then do not emit any warnings: let
22475 the Method.Define routine take care of flagging warnings. But if
22476 there is a mismatch (method overrides something else, or method is
22477 overriwritten by something, then emit warning).
22479 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
22480 set to null, this means `do not check for the return type on the
22483 (Method.Define): set the return type for the method signature to
22484 null, so that we get methods with the same name and parameters and
22485 different return types. This is used to flag warning 114 (you are
22486 hiding a method, and you probably want to use the new/override
22489 * typemanager.cs (MemberLookup): Implemented proper access
22490 control, closing a long standing set of bug reports. The problem
22491 was that the Framework only has two bits: Public and NonPublic,
22492 and NonPublic includes private and protected methods, but we need
22493 to enforce the FamANDAssem, FamOrAssem and Family.
22495 2002-05-11 Miguel de Icaza <miguel@ximian.com>
22497 * statement.cs (GotoCase): Return true: Ammounts to giving up
22498 knowledge on whether we return or not, and letting the other case
22499 be responsible for it.
22501 2002-05-10 Miguel de Icaza <miguel@ximian.com>
22503 * driver.cs: Do not load directories for each file processed, only
22504 do it if there is a pattern.
22506 * ecore.cs: Report readonly assigns here as well, as we might have
22507 been resolved only by MemberAccess.
22509 (SimpleName.SimpleNameResolve): Also be useful for LValue
22510 resolution. We need this to propagate assign to local readonly variables
22512 * typemanager.cs: Use a ptrhashtable for the criteria, because we
22513 do not want to reuse potential criteria memory.
22515 * class.cs (MyEventBuilder): Set reflected_type;
22517 * ecore.cs (Constantify): Added support for constifying bools.
22519 (RootContext.LookupType): Added a cache for values looked up in
22520 the declaration space.
22522 * typemanager.cs (FindMembers): Now is a front-end to
22523 RealFindMembers, and provides a two-level hashtable-based cache to
22526 15% performance improvement: from 22.5 to 19.2 seconds.
22528 * expression.cs (IsParamsMethodApplicable): use foreach.
22529 (Invocation.DoResolve): ditto.
22530 (New.DoResolve): ditto.
22531 (ArrayCreation.DoResolve): ditto.
22533 * ecore.cs (FindMostEncompassingType): use foreach.
22535 * delegate.cs (NewDelegate.DoResolve): Use foreach
22537 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
22538 (RemoveMethods): use foreach.
22540 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
22541 nested foreach statements instead of for, and also break out of
22542 the inner loop once a match is found.
22544 (Invocation.OverloadResolve): Use foreach, simplify the code.
22546 2002-05-08 Miguel de Icaza <miguel@ximian.com>
22548 * cfold.cs (BinaryFold): During an enumeration evaluation context,
22549 we actually unwrap the expression to allow for extra information
22552 * expression.cs: Use Shr_Un on unsigned operations.
22554 2002-05-08 Ravi Pratap <ravi@ximian.com>
22556 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
22557 applicable operators was not being considered correctly. This closes
22558 the bug Miguel reported.
22560 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
22562 * attribute.cs: check that the type derives from System.Attribute
22563 and report the correct error in that case (moved the duplicate code to
22564 its own method, too).
22566 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
22568 * attribute.cs: lookup attribute type name as the spec says: first the
22569 bare attribute name and then name + "Attribute" (nant compiles with
22570 mcs after this fix).
22572 2002-05-07 Miguel de Icaza <miguel@ximian.com>
22574 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
22575 Because of the way we parse things, we should try to see if a
22576 UIntConstant can fit in an integer.
22578 2002-05-07 Ravi Pratap <ravi@ximian.com>
22580 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
22581 when we are in an explicit context.
22583 (ConvertReferenceExplicit): When converting from Iface type S to Class
22584 T make sure the rules are implemented as an OR.
22586 * parameter.cs (ParameterType): Make it a property for now although the
22587 purpose really isn't anything immediate.
22589 * expression.cs (Is*Applicable): Do better checking on the parameter type
22590 of a ref/out parameter. The ones from the system assemblies are already
22591 marked with the correct type so we don't need to do any correction.
22593 * ecore.cs (StandardConversionExists): Conversion from Interface types to
22594 the object type is standard too so include that.
22596 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22598 * ecore.cs (StandardConversionExists): Augment with missing code:
22599 deal with IntConstant, LongConstants and Enumerations.
22601 * assign.cs: Report the error, instead of failing silently
22603 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
22604 typecontainer that they are declared, because the
22605 typecontainer/namespace will have the list of using clauses that
22606 need to be applied.
22608 Assembly Attributes were escaping the normal registration
22611 (EmitCode): Apply attributes within an EmitContext that represents
22612 the container they were declared on.
22614 * cs-parser.jay: Track bases for structs. How did I get this wrong?
22616 2002-05-06 Ravi Pratap <ravi@ximian.com>
22618 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
22619 Revamp completely - make much cleaner as we now operate only
22622 (FindMostSpecificSource, FindMostSpecificTarget): New methods
22623 to implement the logic detailed in the spec more correctly.
22625 (UserDefinedConversion): Update accordingly.
22627 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22629 * statement.cs: Return flow analysis information up.
22631 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
22634 (token): Do not consume an extra character before calling
22637 2002-05-06 Piers Haken <piersh@friskit.com>
22639 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
22641 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22643 * class.cs (Constructor.Emit): Set the IsStatic flag in the
22644 EmitContext during the instance constructor initializer
22645 resolution, to stop access to instance variables.
22647 This is mandated by the spec, last paragraph of the `constructor
22648 initializers' section.
22650 2002-05-05 Miguel de Icaza <miguel@ximian.com>
22652 * cs-parser.jay, class.cs (Accessor): new class used to represent
22653 an accessor (get or set). In the past we used `null' to represent
22654 a missing accessor. But this is ambiguous because there was no
22655 way to tell in abstract indexers/properties if one of them was
22658 Now there is a way of addressing that.
22660 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
22661 instead of FindMembers.
22663 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
22664 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
22666 * attribute.cs: Treat indexers and properties as the same in terms
22667 of applying attributes
22669 * ecore.cs (FindMostEncompassedType): Use statically initialized
22670 EmptyExpressions()s like we do elsewhere to avoid creating useless
22671 objects (and we take this out of the tight loop).
22673 (GetConversionOperators): Move the code to extract the actual
22674 operators to a separate routine to clean things up.
22676 2002-05-04 Miguel de Icaza <miguel@ximian.com>
22678 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
22679 events are always registered FieldBuilders.
22681 * class.cs (FieldBase): New class shared by Fields
22683 * delegate.cs: If we are a toplevel delegate, use our full name.
22684 If we are a nested delegate, then only use our tail name.
22686 2002-05-02 Ravi Pratap <ravi@ximian.com>
22688 * expression.cs (IsApplicable): Ensure that we add the "&" to
22689 ref/out types before comparing it with the type of the argument.
22691 (IsParamsMethodApplicable): Ditto.
22693 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
22696 * delegate.cs : Handle the case when we have more than one applicable
22697 method. Flag an error only when we finish checking all.
22699 2002-05-02 Miguel de Icaza <miguel@ximian.com>
22701 * expression.cs: Add support for boolean static initializers.
22703 2002-05-01 Miguel de Icaza <miguel@ximian.com>
22705 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
22707 * parameter.cs (ComputeParameterTypes,
22708 ComputeAndDefineParameterTypes): Better error handling: now we
22709 clear the `types' cache if we fail during any of the type lookups.
22710 We also return the status code correctly to our caller
22712 * delegate.cs: If we fail to define a delegate, abort the extra
22715 * expression.cs (Binary.ResolveOperator): for
22716 operator==(object,object) and operator !=(object, object) we also
22717 have to verify that there is an implicit conversion from one to
22720 (ArrayAccess.DoResolve): Array Access can operate on
22723 2002-04-30 Miguel de Icaza <miguel@ximian.com>
22725 * assign.cs (CompoundAssign): A new class used as a "flag" that
22726 the assignment actually is happening as part of a compound
22727 assignment operator.
22729 During compound assignment, a few new rules exist to enable things
22736 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
22737 to the type of x) if y is implicitly convertible to the type of x,
22738 and the operator is a builtin operator and the return type of the
22739 operator is explicitly convertible to the type of x.
22741 * rootcontext.cs: Reset warning level to 2. 4 catches various
22742 "interesting" features in mcs, we must clean this up at some
22743 point, but currently am trying to kill other bugs ;-)
22745 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
22746 in container classes as well.
22748 * expression.cs (Binary.ResolveOperator): Handle string case
22749 before anything else (as operator overloading does emit an error
22750 before doing anything else).
22752 This code could go away when we move to a table driven model, but
22753 i could not come up with a good plan last night.
22755 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
22757 * typemanager.cs (CSharpName): reimplementation using regex.
22758 * class.cs: added null check for fields in Emit
22759 * rootcontext.cs: set warninglevel to 4
22761 2002-04-29 Miguel de Icaza <miguel@ximian.com>
22763 * typemanager.cs (CSharpName): reimplemented with Lupus
22766 2002-04-28 Miguel de Icaza <miguel@ximian.com>
22768 * statement.cs (If): correclty implement Resolve, because we were
22769 not catching sem errors in there. The same process is needed
22771 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
22774 (Statement.Warning_DeadCodeFound): Factorize code.
22775 (While): Report dead code here too.
22777 (Statement): Added Resolve virtual method to allow
22778 for resolution split from the emit code.
22780 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22782 * statement.cs (EmitBoolExpression): No longer try to resolve the
22784 (MakeBoolean): New utility function that resolve, implicitly
22785 converts to boolean and tags the expression.
22788 (If, Do): Implement dead code elimination.
22789 (While): Implement loop inversion
22791 (Do, While, For, If): Resolve the expression prior to calling our
22794 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
22797 - added method Report28 (warning: program has more than one entry point)
22798 - added method IsEntryPoint, implements paragraph 10.1 of the spec
22799 - modified method Method.Define, the part at the end of the method
22801 * rootcontext.cs: added static public Location EntryPointLocation;
22803 * ../errors/cs0028.cs : Add test case for the above warning.
22806 - modified method CSharpName to allow arrays of primitive type to
22807 be printed nicely (e.g. instead of System.Int32[][] it now prints
22809 - added method CSharpSignature: returns the signature of a method
22810 in string format to be used in reporting errors, warnings, etc.
22812 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
22815 2002-04-26 Ravi Pratap <ravi@ximian.com>
22817 * delegate.cs (Define): Fix extremely silly bug where I was
22818 setting the type of the 'object' parameter of the BeginInvoke
22819 method to System.IAsyncResult instead of System.Object ;-)
22821 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22823 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
22826 (Constructor.Emit): return if we fail to initialize the
22827 constructor. Another door closed!
22829 * expression.cs (New.DoResolve): Improve error message (from -6 to
22830 1501). Use DeclaredOnly lookup to find the exact constructor.
22832 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
22833 loop. This is useful.
22835 * cs-parser.jay: Adjust the default parameters so that destructors
22836 have the proper signature.
22838 2002-04-26 Martin Baulig <martin@gnome.org>
22840 * driver.cs (LoadAssembly): If `assembly' contains any characters
22841 which are only valid in path names and not in assembly names
22842 (currently slash, backslash and point), use Assembly.LoadFrom ()
22843 instead of Assembly.Load () on the `assembly' (before iteration
22844 over the link_paths).
22846 2002-04-26 Martin Baulig <martin@gnome.org>
22848 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
22850 2002-04-25 Miguel de Icaza <miguel@ximian.com>
22852 * class.cs (Property): use the new typemanager.MemberLookup
22854 (TypeContainer.MemberLookup): Implement using the
22855 TypeManager.MemberLookup now.
22857 * typemanager.cs: Make MemberLookup a function of the TypeManager,
22858 and return MemberInfos, so that these can be used without an
22859 EmitContext (what we had before).
22861 2002-04-24 Miguel de Icaza <miguel@ximian.com>
22863 * expression.cs: Fix the case where the argument to params if the
22864 type of the params. I omitted handling this before. Fixed
22866 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22868 * driver.cs: Call BootCorlib_PopulateCoreType
22870 * class.cs (Property.CheckBase): Check for properties only, not
22873 * interface.cs: Temporary hack: try/catch around the
22874 CustomAttributeBuilder, because I am getting an exception that I
22877 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
22878 types whose definitions are required to be there (attributes are
22879 defined before standard types).
22881 Compute definitions as we boot the various types, as they are used
22882 immediately (value_type class will need object_type, but if we do
22883 not initialize object_type, we will pass a null, which will let
22884 the runtime pick the System.Object from the existing corlib, which
22885 is not what we want).
22887 2002-04-22 Patrik Torstensson <totte@labs2.com>
22889 * cs-tokenizer.cs: fixed a number of trim() issues.
22891 2002-04-22 Ravi Pratap <ravi@ximian.com>
22893 * expression.cs (Argument.Type): Ensure that we return the correct
22894 type when we have out or ref parameters [in which case we
22897 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22899 * class.cs (Property, Indexer): Allow extern modifier in there.
22901 * typemanager.cs (InitBaseTypes): Initializes object_type and
22902 value_type, since those will be used early on during the bootstrap
22903 process to compile corlib.
22905 (InitCoreTypes): Move code from here to InitBaseTypes.
22907 2002-04-21 Miguel de Icaza <miguel@ximian.com>
22909 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
22910 single-dimension arrays as using the ldlen opcode.
22912 Daniel Lewis discovered this optimization.
22914 * typemanager.cs: Add signature for System.Array::get_Length
22916 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22918 * statement.cs: report the error when the foreach does not apply to an
22919 array nor a collection.
22921 2002-04-19 Miguel de Icaza <miguel@ximian.com>
22923 * expression.cs: Add implicit conversions to the operator ~.
22925 * constant.cs (DecimalConstant.Emit): Emit decimal value.
22927 * typemanager.cs: Locate the decimal constructor.
22929 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22931 * attribute.cs: use the new property of TypeOf.
22932 * expression.cs: added 'get' property around typearg.
22934 These changes fix a build breaker reported by NickD. Is this the
22935 correct way to fix? If not, please, revert my changes and make it
22938 2002-04-17 Miguel de Icaza <miguel@ximian.com>
22940 * attribute.cs: Add support for typeof in attribute invocations.
22941 I am not sure that this is right though.
22943 2002-04-14 Duncan Mak <duncan@ximian.com>
22945 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
22946 Binary.Operator.Division case.
22948 2002-04-13 Ravi Pratap <ravi@ximian.com>
22950 * class.cs (DefineType): Ensure that we do a proper check on
22951 attribute types and also register it with the TypeManager.
22953 (TypeContainer.Targets): The default for attribute types is
22954 AttributeTargets.All.
22956 * attribute.cs (ApplyAttributes): Registering the attribute type
22957 is done elsewhere, not when we discover we have a Usage attribute.
22959 2002-04-12 Ravi Pratap <ravi@ximian.com>
22961 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
22962 and get rid of is_delegate parameter.
22964 * everywhere : update.
22966 2002-04-12 Ravi Pratap <ravi@ximian.com>
22968 * cs-parser.jay (compilation_unit): Revamp completely to use
22969 some new ideas that I got from Rhys' grammar to solve the problems
22970 with assembly level attributes.
22972 (outer_declaration): New grammar production.
22974 (attribute_sections): Add.
22976 (opt_attributes): Base on attribute_sections
22978 (namespace_declaration): Allow opt_attributes to tackle the case
22979 when we have assembly level attributes - we are clever in this
22982 * attribute.cs (ApplyAttributes): Do not worry about assembly
22983 attributes in the non-global context.
22985 * rootcontext.cs (AddGlobalAttributes): Go back to using this
22986 instead of SetGlobalAttributes.
22988 * class.cs, rootcontext.cs : Ensure we define and generate
22989 attribute types before anything else.
22991 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
22992 and flag the new error -20 for the case when the attribute type
22993 does not have valid targets specified. csc does not catch this.
22995 * ../errors/errors.txt : update for error # -20
22997 2002-04-11 Ravi Pratap <ravi@ximian.com>
22999 * support.cs (InternalParameters.ParameterModifier): Do some null
23000 checking and return sane values.
23002 * class.cs (Method.Define): If we are a PInvoke method, ensure
23003 that we are static and extern. Report error # 601
23005 * ../errors/cs0601.cs : Add test case for the above error.
23007 2002-04-07 Ravi Pratap <ravi@ximian.com>
23009 * rootcontext.cs (attribute_types): We need to keep type of
23010 all attribute types separately and emit code for them first.
23012 (RegisterAttribute) : Implement.
23014 * class.cs (DefineType): Check if the current Type is a custom
23015 attribute type and register it accordingly.
23017 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
23018 adding the first attribute twice and rename to
23020 (SetGlobalAttributes): this.
23022 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
23025 * attribute.cs (ApplyAttributes): Take an additional argument telling us
23026 if we are processing global arguments. Hmm, I am unsure of this.
23028 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23030 * expression.cs: added static array of strings to avoid calling
23031 Enum.ToString () for Operator in Binary. Significant recover of
23034 2002-04-10 Miguel de Icaza <miguel@ximian.com>
23036 * class.cs (FindMembers): Allow the Builders of the various
23037 members to be null. If they are skip them. This only happens
23038 during the PInvoke declaration.
23040 2002-04-09 Miguel de Icaza <miguel@ximian.com>
23042 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
23043 failure, so we do not keep going afterwards.
23045 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
23046 wanted to pass `false' as the `is_delegate' argument. If this is
23047 the case, why not use delegate_type == null to mean `is_delegate =
23048 false' and anything else as is_delegate = true.
23050 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
23052 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
23053 code for the section, not the beginning of the tests.
23055 2002-04-08 Miguel de Icaza <miguel@ximian.com>
23057 * cfold.cs: Handle operator + (Enum x, Underlying x)
23059 * expression.cs (Binary): same. Warn about errors where we have
23060 Enum/Enum in operator + as well.
23062 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
23065 - added support for switch(bool)
23066 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
23067 - add TableSwitchEmit() to handle table-based switch statements
23069 2002-04-05 Ravi Pratap <ravi@ximian.com>
23071 * expression.cs (Invocation.OverloadResolve): Factor out code which
23072 does parameter compatibility checking with arguments so that we can
23073 re-use the code even from Delegate.VerifyApplicability
23075 (VerifyArgumentsCompat): Move above code here.
23077 * delegate.cs (VerifyApplicability): Get rid of duplicate code
23078 and instead make a call to the above method.
23080 2002-03-31 Ravi Pratap <ravi@ximian.com>
23082 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
23083 We use it to keep track of classes which are attribute types.
23085 2002-04-02 Miguel de Icaza <miguel@ximian.com>
23087 * delegate.cs (Delegate.Define): Correctly define the types in the
23088 presence of fixed and array parameters.
23090 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
23093 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
23094 include NonPublic after the first iteration.
23096 * class.cs (Indexer.CheckBase): Only check if both parents are
23099 * cs-parser.jay (accessor_body): If empty, set to null.
23101 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
23102 same code path here to resolve constants names that we did have in
23103 MemberAccess.DoResolve. There is too much code duplicated here.
23105 2002-04-01 Miguel de Icaza <miguel@ximian.com>
23107 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
23109 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
23112 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
23113 tokens, numbers and strings.
23115 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
23118 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
23119 asyncronous parameters and the regular parameters.
23121 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
23122 specify the target directory.
23124 * expression.cs: (This.DoResolve): Simplify
23125 (As.Emit): Optimize, do not generate IsInst if the expression is
23126 always of the given type.
23128 (Is.DoResolve): Bug fix, we were reporting both always/never for
23131 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
23132 creating too many unnecessary arrays.
23134 2002-03-31 Miguel de Icaza <miguel@ximian.com>
23136 * class.cs (EmitFieldInitializer): Use Assign expression to assign
23137 fields instead of rolling our own initializer. Takes care of all
23138 implicit conversions, and drops unnecessary static checks/argument.
23140 2002-03-31 Dick Porter <dick@ximian.com>
23142 * driver.cs: use the GetDirectories() return values properly, and
23143 use "/" as path separator.
23145 2002-03-30 Miguel de Icaza <miguel@ximian.com>
23147 * expression.cs (Unary): Optimize - - expr into expr.
23148 (Binary): Optimize a + (-b) into a -b.
23150 * codegen.cs (CodeGen): Made all methods static.
23152 2002-03-29 Miguel de Icaza <miguel@ximian.com>
23156 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
23157 TypeBuilder property.
23159 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
23162 * tree.cs: Removed the various RecordXXXX, and replaced with a
23163 single RecordDecl. Removed all the accessor methods, and just
23164 left a single access point Type
23166 * enum.cs: Rename DefineEnum to DefineType.
23168 * decl.cs: New abstract method `DefineType' used to unify the
23169 Defines for Enumerations, Interfaces, TypeContainers and
23172 (FindType): Moved LookupInterfaceOrClass here. Moved the
23173 LookupBaseClasses method that used to live in class.cs and
23174 interface.cs here, and renamed to FindType.
23176 * delegate.cs: Implement DefineType. Take advantage of the
23177 refactored pattern for locating the parent builder without taking
23178 the parent_builder argument (which we know does not work if we are
23179 nested, and triggering a toplevel definition).
23181 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23183 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
23184 accessibility of a member has changed during override and report
23187 * class.cs (Method.Define, Property.Define): Only complain on
23188 overrides if the method is private, any other accessibility is
23189 fine (and since we just checked the permission is the same, we are
23192 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
23193 and elif are processed always. The other pre-processing
23194 directives are only processed if we are "taking" the path
23196 2002-03-29 Martin Baulig <martin@gnome.org>
23198 * class.cs (Method.Emit): Only emit symbolic debugging info if the
23199 current location is not Null.
23201 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
23202 a separate method so we can profile it.
23204 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
23205 `span.Seconds' are just seconds, but no minutes or hours.
23206 (MainDriver): Profile the CodeGen.SaveSymbols calls.
23208 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23210 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
23211 Remove the gratuitous set of Final:
23213 // If an interface implementation, then we can set Final.
23214 if (((flags & MethodAttributes.Abstract) == 0) &&
23215 implementing.DeclaringType.IsInterface)
23216 flags |= MethodAttributes.Final;
23218 I do not know what I was smoking when I used that.
23221 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
23222 step into fixing the name resolution issues for delegates and
23223 unifying the toplevel name resolution.
23225 2002-03-28 Martin Baulig <martin@gnome.org>
23227 * class.cs (Method.Emit): If we have a symbol writer, call its
23228 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
23229 tell it about the current method.
23231 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
23232 writer that we're going to emit the first byte of IL code for a new
23233 statement (a new source line).
23234 (EmitContext.EmitTopBlock): If we have a symbol writer, call
23235 EmitContext.Mark() before emitting any code.
23237 * location.cs (SymbolDocument): Return null when we're Null.
23239 * statement.cs (Statement): Moved the `Location loc' variable here.
23240 (Statement.EmitBoolExpression): If we have a symbol writer, call
23241 ec.Mark() before emitting any code to tell it that we're at the
23242 beginning of a new statement.
23243 (StatementExpression): Added `Location' argument to the constructor.
23244 (Block): Added public readonly variable `StartLocation' and public
23245 variable `EndLocation'. The latter is to be set using SetEndLocation().
23246 (Block): Added constructor which takes a start and end location.
23247 (Block.SetEndLocation): New method. This sets the end location.
23248 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
23249 local variables we create.
23250 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
23251 each statement and do also mark the begin and end of the block.
23253 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
23254 tell it the current lexer.Location, use Location.Null for the end of the
23256 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
23257 current block, set its end location using SetEndLocation().
23258 (statement_expression): StatementExpression constructor now takes the
23259 lexer.Location as additional argument.
23260 (for_statement, declare_local_variables): Likewise.
23261 (declare_local_variables): When creating a new implicit block, use the
23262 new Block constructor and pass it the lexer.Location.
23264 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23266 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
23267 members also on the parent interfaces recursively.
23269 2002-03-27 Miguel de Icaza <miguel@ximian.com>
23271 * report.cs: Use new formats, since Gonzalo finished the missing
23274 * expression.cs (Binary.ResolveOperator): added missing operator|
23275 operator& and operator^ for bool/bool.
23277 * cs-parser.jay: CheckDef now takes a Location argument that is
23278 used to report errors more precisly (instead of reporting the end
23279 of a definition, we try to track something which is a lot closer
23280 to the source of the problem).
23282 * cs-tokenizer.cs: Track global token use, so we can properly flag
23283 the use of #define/#undef after the first token has been seen.
23285 Also, rename the reportXXXX to Error_DescriptiveName
23287 * decl.cs (DeclSpace.IsTopLevel): Move property here from
23288 TypeContainer, so that Enum and Interface can use this too.
23290 * class.cs (TypeContainer.LookupInterfaceOrClass,
23291 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
23292 `builder' argument. Typically this was used to pass the parent
23293 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
23296 The problem is that a nested class could trigger the definition of
23297 a toplevel class, and the builder would be obviously wrong in that
23300 So we drop this argument, and we compute dynamically the
23301 TypeBuilder/ModuleBuilder (the correct information was available
23302 to us anyways from DeclSpace.Parent)
23304 * interface.cs (Interface.DefineInterface): Drop builder
23305 parameter cleanup like class.cs
23307 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
23310 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
23313 (Try.Emit): Propagate the returns value from the statement.
23315 (Return.Emit): Even if we are leavning
23317 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
23319 * modifiers.cs: Fix the computation of MethodAttributes flags.
23321 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
23323 * driver.cs: allow compilation of files that start with '/'.
23324 Add a default case when checking the argument of --target.
23326 2002-03-25 Miguel de Icaza <miguel@ximian.com>
23328 * interface.cs: Implement the same search algorithm for types in
23329 the interface code.
23331 * delegate.cs: Do not allow multiple definition.
23333 * Recovered ChangeLog that got accidentally amputated
23335 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
23337 * rootcontext.cs: Load manually enum to allow core classes to
23338 contain enumerations.
23340 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
23341 Update to new static methods in TypeManager.
23343 * typemanager.cs (GetMethod, GetConstructor): Use our
23344 implementation of FindMembers to find the members, since during
23345 corlib compilation, the types are TypeBuilders and GetMethod and
23346 GetConstructor do not work.
23348 Make all methods in TypeManager static.
23350 (InitCodeHelpers): Split the functionality from
23351 the InitCodeTypes function.
23353 * driver.cs: Call InitCodeHelpers after we have populated the
23356 * cs-parser.jay (delegate_declaration): we did not used to compute
23357 the delegate name correctly for void delegates.
23359 2002-03-24 Miguel de Icaza <miguel@ximian.com>
23361 * rootcontext.cs (RootContext): Init the interface_resolve_order
23362 and type_container_resolve_order always.
23364 (ResolveCore, BootstrapCorlib_ResolveClass,
23365 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
23366 compiler when compiling with --nostdlib
23368 * class.cs (TypeContainer.DefineType): Check that our parent is
23369 not null. This test is most important when we are bootstraping
23372 * codegen.cs: Split out the symbol writing code.
23374 2002-03-25 Martin Baulig <martin@gnome.org>
23376 * driver.cs (-g): Made -g an alias for --debug.
23378 2002-03-24 Martin Baulig <martin@gnome.org>
23380 * codegen.cs (SymbolWriter): New public variable. Returns the
23381 current symbol writer.
23382 (CodeGen): Added `bool want_debugging_support' argument to the
23383 constructor. If true, tell the ModuleBuild that we want debugging
23384 support and ask it for the ISymbolWriter.
23385 (Save): If we have a symbol writer, call it's Close() method after
23386 saving the assembly.
23388 * driver.c (--debug): New command line argument to create a
23389 debugger information file.
23391 * location.cs (SymbolDocument): New public property. Returns an
23392 ISymbolDocumentWriter object for the current source file or null
23393 if we don't have a symbol writer.
23395 2002-03-21 Miguel de Icaza <miguel@ximian.com>
23397 * driver.cs (LoadAssembly): Correctly return when all the paths
23398 have been tried and not before.
23400 * statement.cs (Switch.Emit): return the actual coverage for this
23401 statement (returns/not-returns)
23403 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
23404 switch of the statement if we are the last switch section. That
23405 kills two problems: try/catch problems (we used to emit an empty
23406 nop at the end) and switch statements where all branches would
23409 2002-03-19 Miguel de Icaza <miguel@ximian.com>
23411 * driver.cs: Add default assemblies (the equivalent to the
23412 Microsoft CSC.RSP file)
23414 * cs-tokenizer.cs: When updating `cols and setting it to zero,
23415 also update tokens_seen and set it to false.
23417 * driver.cs: Implement --recurse for Mike.
23419 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
23420 correctly splitting out the paths.
23422 2002-03-18 Miguel de Icaza <miguel@ximian.com>
23424 * interface.cs (Interface.PopulateProperty): Instead of using
23425 `parent' as the declaration space for the set parameters, use
23428 * support.cs (InternalParameters): InternalParameters constructor
23429 takes a DeclSpace instead of a TypeContainer.
23431 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
23432 types are being initialized, load the address of it before calling
23435 (New): Provide a mechanism to disable the generation of local
23436 value type temporaries when the caller will be providing us with
23437 an address to store it.
23439 (ArrayCreation.EmitDynamicInitializers): Use it.
23441 2002-03-17 Miguel de Icaza <miguel@ximian.com>
23443 * expression.cs (Invocation.EmitArguments): Only probe for array
23444 property if there is more than one argument. Sorry about that.
23446 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
23447 empty param arrays.
23449 * class.cs (Method.LabelParameters): Fix incorrect code path that
23450 prevented the `ParamArrayAttribute' from being applied to the
23453 2002-03-16 Miguel de Icaza <miguel@ximian.com>
23455 * support.cs (ReflectionParameters): Correctly compute whether the
23456 last argument is a params array. Fixes the problem with
23459 * typemanager.cs: Make the assemblies array always be non-null
23460 (empty, but non-null)
23462 * tree.cs (RecordDecl): New function that abstracts the recording
23463 of names. This reports error 101, and provides a pointer to the
23464 previous declaration. Fixes a crash in the compiler.
23466 * cs-parser.jay (constructor_declaration): Update to new grammar,
23467 and provide a constructor_body that can be empty.
23469 2002-03-15 Miguel de Icaza <miguel@ximian.com>
23471 * driver.cs: Add support for --resources.
23473 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
23474 Make all types for the various array helper methods be integer.
23476 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
23477 CheckState to ConvCast.
23479 (ConvCast): Now it takes a `checked' state argument, to avoid
23480 depending on the emit context for the conversion, and just using
23481 the resolve time setting.
23483 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
23484 instead of Invocation.EmitArguments. We do not emit the original
23485 arguments, instead we emit those which have been converted to
23486 unsigned int expressions.
23488 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
23490 * codegen.cs: ditto.
23492 * expression.cs (LocalVariableReference): Drop the use of the
23493 Store function that depended on the variable index.
23495 * statement.cs (VariableInfo): Drop the `Idx' property from this
23496 class, as this is not taking into account the indexes for
23497 temporaries tat we generate during the execution, getting the
23500 * class.cs: First emit class initializers, then call the parent
23503 * expression.cs (Binary): Fix opcode emision.
23504 (UnaryMutator.EmitCode): Support checked code generation
23506 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
23507 matches for events for both the Static and Instance scans,
23508 pointing to the same element. Fix that.
23510 2002-03-14 Miguel de Icaza <miguel@ximian.com>
23512 * rootcontext.cs (ResolveTree): Always set the
23513 interface_resolve_order, because nested interfaces will be calling
23516 * class.cs (GetInterfaceOrClass): Track the same resolution
23517 process used by TypeManager.LookupType. This fixes the nested
23518 type lookups in class declarations (separate path from
23521 (TypeContainer.DefineType): Also define nested interfaces.
23522 (TypeContainer.RegisterOrder): New public function used to
23523 register the order in which child interfaces need to be closed.
23525 Nested interfaces need to be closed after their parents have been
23528 * interface.cs (InterfaceAttr): Put all the logic for computing
23529 the interface attribute here.
23531 (DefineInterface): Register our interface order with the
23532 RootContext or with the TypeContainer depending on the case.
23534 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23536 * cs-parser.jay: rework foreach statement to work with the new
23537 changes to the policy on SimpleNames.
23539 * report.cs: support Stacktrace on warnings as well.
23541 * makefile: drop --unsafe and /unsafe from the compile.
23543 2002-03-13 Ravi Pratap <ravi@ximian.com>
23545 * ecore.cs (StandardConversionExists): Modify to take an Expression
23546 as the first parameter. Ensure we do null -> reference type conversion
23549 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
23550 temporary Expression objects.
23552 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
23554 * interface.cs: workaround bug in method overloading resolution
23555 (there is already a bugzilla bug for it).
23557 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23559 We could also solve this problem by having a separate path for
23560 performing type lookups, instead of DoResolve, we could have a
23561 ResolveType entry point, and only participating pieces of the
23562 production (simplename, deref, array) would implement this.
23564 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
23565 signal SimpleName to only resolve type names and not attempt to
23566 resolve anything else.
23568 * expression.cs (Cast): Set the flag.
23570 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
23572 * class.cs: Only report 108 if there is no `new' modifier.
23574 * cs-parser.jay: rework foreach statement to work with the new
23575 changes to the policy on SimpleNames.
23577 * report.cs: support Stacktrace on warnings as well.
23579 * makefile: drop --unsafe and /unsafe from the compile.
23581 2002-03-11 Miguel de Icaza <miguel@ximian.com>
23583 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23584 lookups here, instead of doing that at parse time. This means
23585 that our grammar will not introduce `LocalVariableReferences' as
23586 expressions at this point. That solves the problem of code like
23590 static void Main ()
23594 This is only half the fix. The full fix requires parameters to
23595 also be handled in this way.
23597 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
23598 makes the use more obvious of the DeclSpace. The
23599 ec.TypeContainer.TypeBuilder is now only used to pull the
23600 TypeBuilder for it.
23602 My theory is that I can get rid of the TypeBuilder completely from
23603 the EmitContext, and have typecasts where it is used (from
23604 DeclSpace to where it matters).
23606 The only pending problem is that the code that implements Aliases
23607 is on TypeContainer, and probably should go in DeclSpace.
23609 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23610 lookups here, instead of doing that at parse time. This means
23611 that our grammar will not introduce `LocalVariableReferences' as
23612 expressions at this point. That solves the problem of code like
23616 static void Main ()
23620 This is only half the fix. The full fix requires parameters to
23621 also be handled in this way.
23623 * class.cs (Property.DefineMethod): When implementing an interface
23624 method, set newslot, when implementing an abstract method, do not
23625 set the flag (before we tried never setting it, or always setting
23626 it, which is the difference).
23627 (Indexer.DefineMethod): same.
23628 (Method.DefineMethod): same.
23630 * ecore.cs: Only set the status used flag if we get back a Field.
23632 * attribute.cs: Temporary hack, so Paolo can keep working.
23634 2002-03-08 Ravi Pratap <ravi@ximian.com>
23636 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
23637 the unmanaged type in the case we have a MarshalAs attribute.
23639 (Resolve): Handle the case when we are parsing the special MarshalAs
23640 attribute [we need to store the unmanaged type to use later]
23642 * typemanager.cs (marshal_as_attr_type): Built in type for the
23643 MarshalAs Attribute.
23645 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
23646 on parameters and accordingly set the marshalling info.
23648 2002-03-09 Miguel de Icaza <miguel@ximian.com>
23650 * class.cs: Optimizing slightly by removing redundant code after
23651 we switched to the `NoTypes' return value.
23652 (Property.DefineMethod): use NoTypes here too.
23654 This fixes the bug I introduced in my last batch of changes.
23656 2002-03-05 Ravi Pratap <ravi@ximian.com>
23658 * tree.cs (RecordEnum): Add. We now keep track of enums too.
23660 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
23661 Enums since those are types too.
23663 * cs-parser.jay (enum_declaration): Record enums as we parse them.
23665 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
23666 thanks to a call during the lookup process.
23668 2002-03-07 Miguel de Icaza <miguel@ximian.com>
23670 * statement.cs (Foreach): Lots of work to accomodate a particular
23671 kind of foreach statement that I had not kept in mind. It is
23672 possible to have foreachs on classes that provide a GetEnumerator
23673 method that return objects that implement the "pattern" for using
23674 a foreach, there is no need to support GetEnumerator
23677 This is needed to compile nant.
23679 * decl.cs: Only report 114 if the member is not `Finalize' and if
23680 the warning level is at least 2.
23682 * class.cs: Moved the compare function from Method to
23685 (MethodSignature.InheritableMemberSignatureCompare): Add new
23686 filter function that is used to extract inheritable methods from a
23689 (Method.Define): Use the new `inheritable_method_signature_filter'
23692 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
23695 2002-03-06 Miguel de Icaza <miguel@ximian.com>
23697 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
23699 * cs-parser.jay: Add opt_semicolon to the interface declaration.
23701 * expression.cs: Pass location information to
23702 ConvertImplicitStandard.
23704 * class.cs: Added debugging code to track return values from
23707 2002-03-05 Miguel de Icaza <miguel@ximian.com>
23709 * expression.cs (Is.DoResolve): If either side of the `is' is an
23710 interface, do not flag the warning.
23712 * ecore.cs (ImplicitReferenceConversion): We need a separate test
23715 * report.cs: Allow for --fatal to be used with --probe.
23717 * typemanager.cs (NoTypes): Move the definition for the empty Type
23720 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
23722 (TypeContainer.DefineProxy): New function used to proxy to parent
23723 implementations when implementing interfaces.
23724 (TypeContainer.ParentImplements): used to lookup if our parent
23725 implements a public function that is required by an interface.
23726 (TypeContainer.VerifyPendingMethods): Hook this up.
23728 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
23729 `modules' and `assemblies' arraylists into arrays. We only grow
23730 these are the very early start up of the program, so this improves
23731 the speedof LookupType (nicely measured).
23733 * expression.cs (MakeByteBlob): Replaced unsafe code with
23734 BitConverter, as suggested by Paolo.
23736 * cfold.cs (ConstantFold.Binary): Special case: perform constant
23737 folding of string concatenation, but if either side is a string,
23738 and the other is not, then return null, and let the runtime use
23739 the concatenation on the string plus the object (using
23740 `Object.ToString').
23742 2002-03-04 Miguel de Icaza <miguel@ximian.com>
23744 Constant Folding has been implemented now.
23746 * expression.cs (Unary.Reduce): Do not throw an exception, catch
23747 the error instead on types that are not supported in one's
23750 * constant.cs (Constant and all children): New set of functions to
23751 perform implict and explicit conversions.
23753 * ecore.cs (EnumConstant): Implement the new functions to perform
23754 conversion by proxying to the child expression.
23756 * codegen.cs: (ConstantCheckState): Constant evaluation has its
23757 own separate setting that can not be turned off from the command
23758 line using --unchecked or --checked and is only controlled using
23759 the checked/unchecked statements and expressions. This setting is
23760 used by the constant folder to flag errors.
23762 * expression.cs (CheckedExpr, UncheckedExpr): Set the
23763 ConstantCheckState as well.
23765 During Resolve, they also have to flag the state, because the
23766 constant folder runs completely in the Resolve phase.
23768 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
23771 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23773 * cfold.cs: New file, this file contains the constant folder.
23775 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
23776 argument to track whether we are using the resulting address to
23777 load or store a value and provide better error messages.
23779 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
23780 new AddressOf arguments.
23782 * statement.cs (Foreach.EmitCollectionForeach): Update
23784 * expression.cs (Argument.Emit): Call AddressOf with proper
23785 arguments to track usage.
23787 (New.DoEmit): Call AddressOf with new arguments.
23789 (Unary.Emit): Adjust AddressOf call.
23791 2002-03-01 Ravi Pratap <ravi@ximian.com>
23793 * cs-parser.jay (member_access): Change the case for pre-defined types
23794 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
23797 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
23800 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
23801 essentially like methods and apply attributes like MethodImplOptions to them too.
23803 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
23806 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
23807 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
23810 * Update code everywhere accordingly.
23812 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
23814 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
23816 2002-02-28 Ravi Pratap <ravi@ximian.com>
23818 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
23819 try performing lookups against those instead of jumping straight into using
23820 the 'using' clauses.
23822 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
23824 (LookupType): Perform lookups in implicit parents too.
23826 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
23827 sequence as RootContext.LookupType.
23829 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
23830 the various cases of namespace lookups into this method.
23832 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23834 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
23835 in positional arguments)
23837 * class.cs (Operator): Update the AllowedModifiers to contain
23840 * cs-parser.jay: Update operator declaration to allow for the
23841 operator body to be empty.
23843 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
23846 2002-02-27 Miguel de Icaza <miguel@ximian.com>
23848 * class.cs (Method.Emit): Label parameters.
23850 * driver.cs: Return 1 or 0 as the program exit code.
23852 2002-02-26 Miguel de Icaza <miguel@ximian.com>
23854 * expression.cs: Special case the `null' object when trying to
23855 auto-compute the type, as anything can be explicitly converted to
23858 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
23859 spotting this Paolo.
23861 (Expression.ImplicitNumericConversion): Perform comparissions of
23862 the type using the underlying type in the case of an enumeration
23863 rather than using the enumeration type for the compare.
23865 Cope with the underlying == type case, which is not possible to
23868 (Expression.ConvertNumericExplicit): Perform comparissions of
23869 the type using the underlying type in the case of an enumeration
23870 rather than using the enumeration type for the compare.
23872 * driver.cs: If the user does not supply an extension, assume .exe
23874 * cs-parser.jay (if_statement): Rewrote so that we can track the
23875 location for the if statement.
23877 * expression.cs (Binary.ConstantFold): Only concat strings when
23878 the operation is "+", not everything ;-)
23880 * statement.cs (Statement.EmitBoolExpression): Take a location
23882 (If, While, Do): Track location.
23884 * expression.cs (Binary.ResolveOperator): In the object + string
23885 case, I was missing a call to ConvertImplicit
23887 2002-02-25 Ravi Pratap <ravi@ximian.com>
23889 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
23890 Location arguments. Ensure we use RootContext.LookupType to do our work
23891 and not try to do a direct Type.GetType and ModuleBuilder.GetType
23893 * interface.cs (PopulateMethod): Handle the type of the parameter being
23896 * expression.cs (Invocation.BetterFunction): Handle the case when we
23897 have a params method with no fixed arguments and a call is made with no
23900 2002-02-25 Miguel de Icaza <miguel@ximian.com>
23902 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
23903 the verbatim-string-literal
23905 * support.cs (InternalParameters.ParameterModifier): handle null
23907 (InternalParameters.ParameterType): ditto.
23909 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
23910 duplicating the name of the variable parameter.
23911 (GetParameterByName): Fix bug where we were not looking up array
23912 paramters if they were the only present (thanks Paolo!).
23913 (GetParameterInfo): We only have an empty set of types if both
23914 fixed and array are set to null.
23915 (GetParameterInfo-idx): Handle FixedParameter == null
23917 * cs-parser.jay: Handle the case where there is no catch
23918 statements (missing null test).
23920 2002-02-22 Miguel de Icaza <miguel@ximian.com>
23922 * driver.cs (MainDriver): Be conservative on our command line
23925 Catch DirectoryNotFoundException when calling GetFiles.
23927 (SplitPathAndPattern): Used to split the input specification into
23928 a path and a pattern that we can feed to Directory.GetFiles.
23930 2002-02-21 Miguel de Icaza <miguel@ximian.com>
23932 * statement.cs (Fixed): Implement the last case of the Fixed
23933 statement (string handling).
23935 * expression.cs (StringPtr): New class used to return a char * to
23936 a string; Used by the Fixed statement.
23938 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
23940 * expression.cs (Binary.ResolveOperator): Remove redundant
23941 MemberLookup pn parent type.
23942 Optimize union call, we do not need a union if the types are the same.
23943 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
23946 Specialize the use of MemberLookup everywhere, instead of using
23947 the default settings.
23949 (StackAlloc): Implement stackalloc keyword.
23951 * cs-parser.jay: Add rule to parse stackalloc.
23953 * driver.cs: Handle /h, /help, /?
23955 * expression.cs (MakeByteBlob): Removed the hacks we had in place
23956 before we supported unsafe code.
23958 * makefile: add --unsafe to the self compilation of mcs.
23960 2002-02-20 Miguel de Icaza <miguel@ximian.com>
23962 * expression.cs (PointerArithmetic): New class that is used to
23963 perform pointer arithmetic.
23964 (Binary.Resolve): Handle pointer arithmetic
23965 Handle pointer comparission.
23966 (ArrayPtr): Utility expression class that is used to take the
23967 address of an array.
23969 (ElementAccess): Implement array access for pointers
23971 * statement.cs (Fixed): Implement fixed statement for arrays, we
23972 are missing one more case before we are done.
23974 * expression.cs (Indirection): Implement EmitAssign and set the
23975 ExprClass to Variable. This allows pointer dereferences to be
23976 treated as variables, and to have values assigned to them.
23978 * ecore.cs (Expression.StoreFromPtr): New utility function to
23979 store values dereferencing.
23981 2002-02-20 Ravi Pratap <ravi@ximian.com>
23983 * expression.cs (Binary.ResolveOperator): Ensure that we are
23984 not trying to operate on a void type - this fixes the reported
23987 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
23988 the parent implementation is sealed.
23990 * ../errors/cs0239.cs : Add.
23992 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
23994 * typemanager.cs (unverifiable_code_type): Corresponds to
23995 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
23996 which have unsafe code in them.
23998 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
24001 2002-02-19 Miguel de Icaza <miguel@ximian.com>
24003 * cs-tokenizer.cs: Add support for @"litreal strings"
24005 Make tokenizer accept pre-processor directives
24006 on any column (remove the old C-like limitation).
24008 * rootcontext.cs (EmitCode): Emit any global attributes.
24009 (AddGlobalAttributes): Used to keep track of assembly attributes.
24011 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
24013 * cs-parser.jay: Add support for global attributes.
24015 2002-02-17 Miguel de Icaza <miguel@ximian.com>
24017 * expression.cs (Indirection): New helper class. Unary will
24018 create Indirection classes to be able to implement the
24019 IMemoryLocation interface on it.
24021 2002-02-16 Miguel de Icaza <miguel@ximian.com>
24023 * cs-parser.jay (fixed_statement): reference the right statement.
24025 * statement.cs (Fixed.Emit): Finish implementing the fixed
24026 statement for the &x case.
24028 2002-02-14 Miguel de Icaza <miguel@ximian.com>
24030 * class.cs (Property.Define, Method.Define): Remove newslot when
24033 * modifiers.cs: My use of NewSlot when `Abstract' was set was
24034 wrong. NewSlot should only be used if the `new' keyword is present.
24036 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
24037 locating our system dir. Sorry about this.
24039 2002-02-13 Miguel de Icaza <miguel@ximian.com>
24041 * driver.cs (GetSystemDir): Compute correctly the location of our
24042 system assemblies. I was using the compiler directory instead of
24043 the library directory.
24045 2002-02-13 Ravi Pratap <ravi@ximian.com>
24047 * expression.cs (BetterFunction): Put back in what Miguel commented out
24048 since it is the correct fix. The problem is elsewhere ;-)
24050 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
24051 parameters of the parms method are themselves compatible or not !
24053 (StandardConversionExists): Fix very dangerous bug where we were forgetting
24054 to check that a class implements an interface before saying that an implicit
24055 conversion was allowed. Use ImplementsInterface to do the checking.
24057 2002-02-13 Miguel de Icaza <miguel@ximian.com>
24059 * class.cs (Method.Define): Track whether we are an explicit
24060 implementation or not. And only call DefineMethodOverride if we
24061 are an explicit implementation.
24063 (Property.DefineMethod): Ditto.
24065 2002-02-11 Ravi Pratap <ravi@ximian.com>
24067 * expression.cs (BetterFunction): Catch hideous bug which was
24068 preventing us from detecting ambiguous calls due to implicit casts i.e
24071 2002-01-29 Miguel de Icaza <miguel@ximian.com>
24073 * support.cs (Pair): Remove un-needed method. I figured why I was
24074 getting the error in cs-parser.jay, the variable in a foreach loop
24075 is readonly, and the compiler does not really treat this as a variable.
24077 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
24078 instead of EQUALS in grammar.
24080 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
24082 * expression.cs (Unary.DoResolve): Check whether the argument is
24085 2002-01-28 Miguel de Icaza <miguel@ximian.com>
24087 * support.cs: Api for Pair to set a value. Despite the fact that
24088 the variables are public the MS C# compiler refuses to compile
24089 code that accesses the field if the variable is part of a foreach
24092 * statement.cs (Fixed): Begin implementation of the fixed
24095 (Block.AddVariable): Return the VariableInfo on success and null
24096 on failure instead of true/false.
24098 * cs-parser.jay (foreach): Catch errors on variables already
24099 defined (we were ignoring this value before) and properly unwind
24100 the block hierarchy
24102 (fixed_statement): grammar for the fixed statement.
24104 2002-01-25 Miguel de Icaza <miguel@ximian.com>
24106 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
24107 pointer types to be incretemented.
24109 (SizeOf): Implement.
24111 * cs-parser.jay (pointer_member_access): Implement
24112 expr->IDENTIFIER production.
24114 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
24115 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
24118 (Unary): Implement indirection.
24120 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
24121 use in non-unsafe context).
24123 (SimpleName.DoResolve): Check for pointers in field access on safe
24126 (Expression.LoadFromPtr): Factor the load-indirect code in this
24127 function. This was duplicated in UnboxCast and ParameterReference
24129 2002-01-24 Miguel de Icaza <miguel@ximian.com>
24131 * expression.cs (ComposedCast): report an error if a pointer cast
24132 is used in a safe region.
24134 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
24135 pointer type casts in unsafe context.
24137 * codegen.cs (EmitContext): Set up IsUnsafe.
24139 * cs-parser.jay (non_expression_type): Add productions for pointer
24142 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
24143 code. We should not use force into static mode if the method is
24144 not virtual. Fixes bug in MIS
24146 * statement.cs (Do.Emit, While.Emit, For.Emit,
24147 Statement.EmitBoolExpression): Add support to Do and While to
24148 propagate infinite loop as `I do return' semantics.
24150 Improve the For case to also test for boolean constants.
24152 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
24153 to the list of attributes we can add.
24155 Remove `EmitContext' argument.
24157 * class.cs (Method.Define): Apply parameter attributes.
24158 (Constructor.Define): Apply parameter attributes.
24159 (MethodCore.LabelParameters): Move here the core of labeling
24162 * support.cs (ReflectionParameters.ParameterModifier,
24163 InternalParameters.ParameterModifier): Use IsByRef on the type and
24164 only return the OUT bit for these parameters instead of in/out/ref
24167 This is because I miss-understood things. The ParameterInfo.IsIn
24168 and IsOut represent whether the parameter has the [In] and [Out]
24171 2002-01-22 Miguel de Icaza <miguel@ximian.com>
24173 * ecore.cs (FieldExpr.Emit): Release temporaries.
24175 * assign.cs (LocalTemporary.Release): new function.
24177 * codegen.cs (EmitContext.GetTemporaryStorage,
24178 EmitContext.FreeTemporaryStorage): Rework the way we deal with
24179 temporary storage. Now we can "put back" localbuilders when we
24182 2002-01-21 Miguel de Icaza <miguel@ximian.com>
24184 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
24185 need to make a copy of the variable to generate verifiable code.
24187 2002-01-19 Miguel de Icaza <miguel@ximian.com>
24189 * driver.cs: Compute dynamically the system directory.
24191 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
24192 Slower, but more generally useful. Used by the abstract
24193 registering implementation.
24195 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
24196 the rules for the special rule on Type/instances. First check if
24197 we have the same name, and if so, try that special static path
24198 rather than the instance path.
24200 2002-01-18 Miguel de Icaza <miguel@ximian.com>
24202 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
24205 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
24206 Enum, ValueType, Delegate or Array for non-corlib compiles.
24208 * cs-tokenizer.cs: Catch long identifiers (645)
24210 * typemanager.cs (IndexerPropetyName): Ravi never tested this
24213 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
24214 fix, we were returning too early, so we were not registering
24215 pending methods from abstract classes.
24217 Do not register pending methods if the class is abstract.
24219 * expression.cs (Conditional.DoResolve): Report circular implicit
24220 conversions when we neecd to compute it for conditional
24223 (Is.DoResolve): If the expression is always of the provided type,
24224 flag warning 183. If the expression can not ever be of the
24225 provided type flag warning 184.
24227 * class.cs: Catch 169 as well.
24229 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
24232 2002-01-18 Nick Drochak <ndrochak@gol.com>
24234 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
24236 2002-01-17 Miguel de Icaza <miguel@ximian.com>
24238 * interface.cs: (PopulateMethod): Check for pointers being defined
24239 only if the unsafe context is active.
24240 (PopulateProperty): ditto.
24241 (PopulateIndexer): ditto.
24243 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
24244 specified. If pointers are present, make sure that they are
24245 present in an unsafe context.
24246 (Constructor, Constructor.Define): ditto.
24247 (Field, Field.Define): ditto.
24248 (Property, Property.Define): ditto.
24249 (Event, Event.Define): ditto.
24251 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
24252 hashtable if there are classes or structs defined.
24254 * expression.cs (LocalVariableReference.DoResolve): Simplify this
24255 code, as the constant resolution moved.
24257 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
24258 the metadata, so we can flag error 133.
24260 * decl.cs (MemberCore.UnsafeOK): New function to test that a
24261 pointer is being declared in an unsafe context.
24263 2002-01-16 Miguel de Icaza <miguel@ximian.com>
24265 * modifiers.cs (Modifiers.Check): Require a Location argument.
24266 Report error 227 for Unsafe use.
24268 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
24270 * statement.cs (For.Emit): If the test is null, then report that
24271 we do `return', as we wont reach anything afterwards.
24273 (Switch.SwitchGoverningType): Track the expression that matched
24276 * driver.cs: Allow negative numbers as an error code to flag.
24278 * cs-parser.jay: Handle 1551.
24280 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
24282 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24284 * cs-parser.jay: Report 1518 (type declaration can only contain
24285 class, struct, interface, enum or delegate)
24287 (switch_label): Report 1523 (keywords `case' or `default' must
24290 (opt_switch_sections): Report 1522 (empty switch)
24292 * driver.cs: Report 1515 (response file specified multiple times)
24293 Report 1516 (Source file specified multiple times).
24295 * expression.cs (Argument.Resolve): Signal 1510
24297 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
24298 access not allowed in static code)
24300 2002-01-11 Ravi Pratap <ravi@ximian.com>
24302 * typemanager.cs (IsPointerType): Utility method which we are going
24305 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
24306 the object type, so we take care of that.
24308 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
24310 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
24311 added to non-params parameters :-)
24313 * typemanager.cs (CSharpName): Include 'void' type too.
24315 (void_ptr_type): Include in the set of core types.
24317 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
24320 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
24323 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
24324 completely forgotten about it.
24326 2002-01-10 Ravi Pratap <ravi@ximian.com>
24328 * cs-parser.jay (pointer_type): Add. This begins our implementation
24329 of parsing rules for unsafe code.
24331 (unsafe_statement): Implement.
24333 (embedded_statement): Modify to include the above.
24335 * statement.cs (Unsafe): Implement new class for unsafe blocks.
24337 * codegen.cs (EmitContext.InUnsafe): Add. This determines
24338 if the current context is an unsafe one.
24340 * cs-parser.jay (local_variable_pointer_type): Since local variable types
24341 are handled differently, we need separate rules for them.
24343 (local_variable_declaration): Update to use local_variable_pointer_type
24344 to allow variable declarations of unmanaged pointer types.
24346 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
24347 in unsafe contexts.
24349 * ../errors/cs0214.cs : Add.
24351 2002-01-16 Nick Drochak <ndrochak@gol.com>
24353 * makefile: remove 'response' file when cleaning.
24355 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24357 * cs-parser.jay: Report 1524.
24359 2002-01-14 Miguel de Icaza <miguel@ximian.com>
24361 * typemanager.cs (RegisterMethod): drop checking if we have
24362 registered this from here
24364 2002-01-12 Miguel de Icaza <miguel@ximian.com>
24366 * class.cs (Method.EmitDestructor): Implement calling our base
24369 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
24370 value of InFinally.
24372 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
24373 this routine and will wrap the call in a try/catch block. Deal
24376 2002-01-11 Miguel de Icaza <miguel@ximian.com>
24378 * ecore.cs (Expression.MemberLookup): instead of taking a
24379 parameter `same_type' that was used to tell whether we could
24380 access private members we compute our containing type from the
24383 (FieldExpr): Added partial support for volatile fields. This does
24384 not work for volatile fields exposed from assemblies, as I can not
24385 figure out how to extract the modreq from it.
24387 Updated all the source files to use this.
24389 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
24390 because it is referenced by MemberLookup very often.
24392 2002-01-09 Ravi Pratap <ravi@ximian.com>
24394 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
24395 TypeBuilder.GetCustomAttributes to retrieve what we need.
24397 Get rid of redundant default_member_attr_type as this is the same as
24398 default_member_type which already exists.
24400 * interface.cs, attribute.cs : Update accordingly.
24402 2002-01-08 Miguel de Icaza <miguel@ximian.com>
24404 * typemanager.cs: Enable IndexerPropertyName again. It does not
24405 work for TYpeBuilders though. Ravi, can you please fix this?
24407 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
24409 * expression.cs (Argument.Emit): Handle the case of ref objects
24410 being passed to ref functions;
24412 (ParameterReference.EmitLoad): Loads the content of the pointer
24413 without dereferencing.
24415 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24417 * cs-tokenizer.cs: Implemented the pre-processing expressions.
24419 2002-01-08 Ravi Pratap <ravi@ximian.com>
24421 * class.cs (Indexer.DefineMethod): Incorporate the interface
24422 type in the name of the method if we are doing explicit interface
24425 * expression.cs (ConversionExists): Remove as it is completely obsolete.
24427 (BetterConversion): Fix extremely trivial bug where we were referring to
24428 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
24431 * ../errors/bug16.cs : Add although we have fixed it.
24433 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24435 * expression.cs (BaseIndexer): Begin implementation.
24437 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
24439 * cs-parser.jay (indexer_declarator): Use qualified_identifier
24440 production directly to remove a shift/reduce, and implement
24441 explicit interface implementation.
24443 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
24444 after a floating point suffix.
24446 * expression.cs (DoNumericPromotions): Improved the conversion for
24447 uint/uint. If we have a constant, we avoid doing a typecast to a
24450 * class.cs (Indexer): Implement explicit interface implementation
24453 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
24455 * class.cs: make the default instance constructor public and hidebysig.
24457 2001-01-03 Ravi Pratap <ravi@ximian.com>
24459 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
24460 so we can call it from elsewhere.
24462 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
24463 we emit it internally if the class has a defined indexer; otherwise the user
24464 emits it by decorating the class definition with the DefaultMemberAttribute.
24466 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
24467 attribute is not used on a type which defines an indexer.
24469 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
24470 character when we skip whitespace.
24472 * ../errors/cs0646.cs : Add.
24474 2002-01-03 Miguel de Icaza <miguel@ximian.com>
24476 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
24479 * makefile: Add practical target `mcs3.exe' which builds the third
24480 generation compiler.
24482 * expression.cs (New): Fix structures constructor calling.
24484 * class.cs (Property, Method, Indexer): Emit Final flag on the
24485 method if we are an interface implementation and we are not
24488 * ecore.cs (PropertyExpr): New public field `IsBase', tells
24489 whether this property is referencing a `base' method.
24491 * expression.cs (Invocation.EmitCall): take an extra argument:
24492 is_base, this is used to determine whether the `call' or
24493 `callvirt' opcode should be used.
24496 * delegate.cs: update EmitCall.
24498 * class.cs (Method.Define): Set NewSlot for the cases where we are
24499 not implementing an interface method.
24501 (Property.Define): ditto.
24503 2002-01-02 Miguel de Icaza <miguel@ximian.com>
24505 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
24506 'r'. Allows mcs to parse itself fully.
24508 2002-01-02 Ravi Pratap <ravi@ximian.com>
24510 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
24511 of the number of initializers that require the InitializeArray method.
24513 (CheckIndices): Store the Expression in all cases - not the plain value. Also
24514 update the above field where necessary.
24516 (MakeByteBlob): Update accordingly.
24518 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
24521 (EmitDynamicInitializers): Update in accordance with the new optimization.
24523 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
24524 same OpCode applies.
24526 * cs-parser.jay : Fix some glaring errors I introduced.
24528 2002-01-01 Ravi Pratap <ravi@ximian.com>
24530 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
24531 so that we can check for name clashes there too.
24533 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
24534 for interface indexers.
24536 * interfaces.cs (Define): Emit the default member attribute.
24538 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
24539 variable was being referred to while setting the value ;-)
24541 2002-01-01 Miguel de Icaza <miguel@ximian.com>
24543 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
24544 byte-by-byte information when we know the data is zero.
24546 Make the block always a multiple of 4, because
24547 DefineInitializedData has a bug.
24549 * assign.cs: Fix, we should assign from the temporary, not from
24552 * expression.cs (MakeByteBlob): Fix my incorrect code.
24554 2001-12-31 Miguel de Icaza <miguel@ximian.com>
24556 * typemanager.cs (EnumToUnderlying): This function is used to get
24557 the underlying type from an enumeration, because it does not
24560 * constant.cs: Use the I4_S form for values between -128 and 127.
24562 * statement.cs (Block.LookupLabel): Looks up a label.
24563 (Block): Drop support for labeled blocks.
24565 (LabeledStatement): New kind of statement that represents a label
24568 (Goto): Finally implement this bad boy.
24570 * cs-parser.jay: Update to reflect new mechanism to implement
24573 2001-12-30 Miguel de Icaza <miguel@ximian.com>
24575 * codegen.cs (EmitContext.This): a codegen property that keeps the
24576 a single instance of this instead of creating many different this
24579 * delegate.cs (Delegate.DoResolve): Update to use the property;
24581 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
24583 * expression.cs (BaseAccess.DoResolve): Ditto.
24585 2001-12-29 Ravi Pratap <ravi@ximian.com>
24587 * typemanager.cs (methodimpl_attr_type): Add to hold the type
24588 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
24590 (InitCoreTypes): Update accordingly.
24592 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
24593 so we can quickly store the state.
24595 (ApplyAttributes): Set the correct implementation flags
24596 for InternalCall methods.
24598 2001-12-29 Miguel de Icaza <miguel@ximian.com>
24600 * expression.cs (EmitCall): if a method is not virtual, then do
24601 not use callvirt on it.
24603 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
24604 user defined stuff) requires the use of stobj, which takes an
24605 address on the stack instead of an array and an index. So emit
24606 the Ldelema operation for it.
24608 (EmitStoreOpcode): Use stobj for valuetypes.
24610 (UnaryMutator.EmitCode): Use the right 1 value depending on
24611 whether we are dealing with int64/uint64, float or doubles.
24613 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
24614 constructors that I implemented last night.
24616 (Constructor.IsDefault): Fix to work properly for static
24619 * cs-parser.jay (CheckDef): report method signature errors.
24620 Update error number 103 to be 132.
24622 * decl.cs: New AdditionResult enumeration value: MethodExists.
24623 Although we do this check for methods later on in the semantic
24624 analysis, catching repeated default constructors is so easy that
24625 we catch these here.
24627 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
24630 (ParameterReference.EmitAssign, Emit): handle
24633 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
24634 (ArrayAccess.EmitStoreOpcode): ditto.
24636 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
24638 * expression.cs (MakeByteBlob): Complete all the missing types
24639 (uint, short, ushort, byte, sbyte)
24641 * class.cs: Only init instance field initializers on instance
24644 Rename `constructors' to instance_constructors.
24646 (TypeContainer.AddConstructor): Only add constructors to the list
24647 if it is not static.
24649 Make sure that we handle default_static_constructor independently
24650 everywhere where we handle instance_constructors
24652 2001-12-28 Miguel de Icaza <miguel@ximian.com>
24654 * class.cs: Do not lookup or create a base initializer for a
24655 static constructor.
24657 (ConstructorInitializer.Resolve): use the proper type to lookup
24660 * cs-parser.jay: Report error 1585 (modifiers between type and name).
24662 * enum.cs, interface.cs: Remove CloseType, this is taken care by
24665 * decl.cs: CloseType is now an virtual method, the default
24666 implementation just closes this type.
24668 2001-12-28 Ravi Pratap <ravi@ximian.com>
24670 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
24671 to PreserveSig by default. Also emit HideBySig on such methods.
24673 Basically, set the defaults to standard values.
24675 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
24676 argument, if candidate is better, it can't be worse than the best !
24678 (Invocation): Re-write bits to differentiate between methods being
24679 applicable in their expanded form and their normal form - for params
24682 Get rid of use_standard everywhere as only standard conversions are allowed
24683 in overload resolution.
24685 More spec conformance.
24687 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24689 * driver.cs: Add --timestamp, to see where the compiler spends
24692 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
24693 `this' in static code.
24695 (SimpleName.DoResolve): Implement in terms of a helper function
24696 that allows static-references to be passed upstream to
24699 (Expression.ResolveWithSimpleName): Resolve specially simple
24700 names when called by MemberAccess to implement the special
24703 (Expression.ImplicitReferenceConversion): Handle conversions from
24704 Null to reference types before others, as Null's type is
24707 * expression.cs (Invocation.EmitCall): Handle the special case of
24708 calling methods declared on a reference type from a ValueType
24709 (Base classes System.Object and System.Enum)
24711 (MemberAccess.Resolve): Only perform lookups on Enumerations if
24712 the left hand side is a TypeExpr, not on every enumeration.
24714 (Binary.Resolve): If types are reference types, then do a cast to
24715 object on operators != and == of both arguments.
24717 * typemanager.cs (FindMembers): Extract instance and static
24718 members if requested.
24720 * interface.cs (PopulateProperty): Use void_type instead of null
24721 as the return type for the setter method.
24723 (PopulateIndexer): ditto.
24725 2001-12-27 Ravi Pratap <ravi@ximian.com>
24727 * support.cs (ReflectionParameters): Fix minor bug where we
24728 were examining the wrong parameter for the ParamArray attribute.
24730 Cope with requests for the type of the parameter at position
24731 greater than the params parameter's. We now return the element
24732 type of the params array as that makes more sense.
24734 * expression.cs (Invocation.IsParamsMethodApplicable): Update
24735 accordingly as we no longer have to extract the element type
24738 (Invocation.OverloadResolve): Update.
24740 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24742 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
24743 against IEnumerator, test whether the return value is a descendant
24744 of the IEnumerator interface.
24746 * class.cs (Indexer.Define): Use an auxiliary method to implement
24747 the other bits of the method definition. Begin support for
24748 explicit interface implementation.
24750 (Property.DefineMethod): Use TypeManager.void_type instead of null
24751 for an empty return value.
24753 2001-12-26 Miguel de Icaza <miguel@ximian.com>
24755 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
24756 dealing with a FieldExpr which is composed of a FieldBuilder, in
24757 the code path we did extract the constant, but we should have
24758 obtained the underlying value to be able to cast it (otherwise we
24759 end up in an infinite loop, this is what Ravi was running into).
24761 (ArrayCreation.UpdateIndices): Arrays might be empty.
24763 (MemberAccess.ResolveMemberAccess): Add support for section
24764 14.5.4.1 that deals with the special case of E.I when E is a type
24765 and something else, that I can be a reference to a static member.
24767 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
24768 handle a particular array type to create byte blobs, it is just
24769 something we dont generate byteblobs for.
24771 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
24774 * location.cs (Push): remove the key from the hashtable that we
24775 are about to add. This happens for empty files.
24777 * driver.cs: Dispose files after we have parsed them.
24779 (tokenize): new function that only runs the tokenizer on its
24780 input, for speed testing.
24782 2001-12-26 Ravi Pratap <ravi@ximian.com>
24784 * class.cs (Event.Define): Define the private field only if there
24785 are no accessors defined.
24787 * expression.cs (ResolveMemberAccess): If there is no associated
24788 field with the event, that means we have an event defined with its
24789 own accessors and we should flag error cs0070 since transforming
24790 ourselves into a field is not valid in that case.
24792 * ecore.cs (SimpleName.DoResolve): Same as above.
24794 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
24795 and charset to sane values.
24797 2001-12-25 Ravi Pratap <ravi@ximian.com>
24799 * assign.cs (DoResolve): Perform check on events only if they
24800 are being accessed outside the declaring type.
24802 * cs-parser.jay (event_declarations): Update rules to correctly
24803 set the type of the implicit parameter etc.
24805 (add_accessor, remove_accessor): Set current local parameters.
24807 * expression.cs (Binary): For delegate addition and subtraction,
24808 cast the return value from the method into the appropriate delegate
24811 2001-12-24 Ravi Pratap <ravi@ximian.com>
24813 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
24814 of these as the workaround is unnecessary.
24816 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
24817 delegate data - none of that is needed at all.
24819 Re-write bits to extract the instance expression and the delegate method
24822 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
24825 * attribute.cs (ApplyAttributes): New method to take care of common tasks
24826 of attaching attributes instead of duplicating code everywhere.
24828 * everywhere : Update code to do attribute emission using the above method.
24830 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24832 * expression.cs (IsParamsMethodApplicable): if there are not
24833 parameters, return immediately.
24835 * ecore.cs: The 0 literal can be implicity converted to an enum
24838 (SimpleName.DoResolve): First lookup the type, then lookup the
24841 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
24842 want to get its address. If the InstanceExpression is not
24843 addressable, store the result in a temporary variable, then get
24846 * codegen.cs: Only display 219 errors on warning level or above.
24848 * expression.cs (ArrayAccess): Make it implement the
24849 IMemoryLocation interface.
24851 (Binary.DoResolve): handle the operator == (object a, object b)
24852 and operator != (object a, object b) without incurring into a
24853 BoxedCast (because 5 != o should never be performed).
24855 Handle binary enumerator operators.
24857 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
24858 value type, otherwise use Ldelem_ref.
24860 Use precomputed names;
24862 (AddressOf): Implement address of
24864 * cs-parser.jay (labeled_statement): Fix recursive block
24865 addition by reworking the production.
24867 * expression.cs (New.DoEmit): New has a special case:
24869 If we are dealing with a ValueType, we have a few
24870 situations to deal with:
24872 * The target of New is a ValueType variable, that is
24873 easy, we just pass this as the variable reference
24875 * The target of New is being passed as an argument,
24876 to a boxing operation or a function that takes a
24879 In this case, we need to create a temporary variable
24880 that is the argument of New.
24883 2001-12-23 Ravi Pratap <ravi@ximian.com>
24885 * rootcontext.cs (LookupType): Check that current_type is not null before
24886 going about looking at nested types.
24888 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
24889 not implement the IAssignMethod interface any more.
24891 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
24892 where we tranform them into FieldExprs if they are being resolved from within
24893 the declaring type.
24895 * ecore.cs (SimpleName.DoResolve): Do the same here.
24897 * assign.cs (DoResolve, Emit): Clean up code considerably.
24899 * ../errors/bug10.cs : Add.
24901 * ../errors/cs0070.cs : Add.
24903 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
24905 * assign.cs : Get rid of EventIsLocal everywhere.
24907 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24909 * ecore.cs (ConvertIntLiteral): finished the implementation.
24911 * statement.cs (SwitchLabel): Convert the value we are using as a
24912 key before looking up the table.
24914 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24916 * codegen.cs (EmitTopBlock): Require a Location argument now.
24918 * cs-parser.jay (constructor_declarator): We need to setup
24919 current_local_parameters before we parse the
24920 opt_constructor_initializer, to allow the variables to be bound
24921 to the constructor arguments.
24923 * rootcontext.cs (LookupType): First lookup nested classes in our
24924 class and our parents before we go looking outside our class.
24926 * expression.cs (ConstantFold): Extract/debox the values at the
24929 * rootcontext.cs (EmitCode): Resolve the constants first before we
24930 resolve the types. This is not really needed, but it helps debugging.
24932 * statement.cs: report location.
24934 * cs-parser.jay: pass location to throw statement.
24936 * driver.cs: Small bug fix.
24938 * report.cs: Updated format to be 4-zero filled digits.
24940 2001-12-22 Ravi Pratap <ravi@ximian.com>
24942 * expression.cs (CheckIndices): Fix minor bug where the wrong
24943 variable was being referred to ;-)
24945 (DoEmit): Do not call EmitStaticInitializers when the
24946 underlying type is System.Object.
24948 2001-12-21 Ravi Pratap <ravi@ximian.com>
24950 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
24951 and do the usual workaround for SRE.
24953 * class.cs (MyEventBuilder.EventType): New member to get at the type
24954 of the event, quickly.
24956 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
24958 * assign.cs (Assign.DoResolve): Handle the case when the target
24959 is an EventExpr and perform the necessary checks.
24961 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
24964 (SimpleName.MemberStaticCheck): Include check for EventExpr.
24966 (EventExpr): Set the type in the constructor itself since we
24967 are meant to be born fully resolved.
24969 (EventExpr.Define): Revert code I wrote earlier.
24971 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
24972 instance expression is null. The instance expression is a This in that case
24973 or a null, depending on whether it is a static method or not.
24975 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
24976 refers to more than one method.
24978 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
24979 and accordingly flag errors.
24981 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24983 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
24985 2001-12-22 Miguel de Icaza <miguel@ximian.com>
24987 * location.cs (ToString): Provide useful rutine.
24989 2001-12-21 Miguel de Icaza <miguel@ximian.com>
24991 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
24992 objects, return the actual integral boxed.
24994 * statement.cs (SwitchLabel): define an ILLabel for each
24997 (Switch.CheckSwitch): If the value is a Literal, extract
24998 the underlying literal.
25000 Also in the unused hashtable we had, add the SwitchLabel so we can
25001 quickly look this value up.
25003 * constant.cs: Implement a bunch of new constants. Rewrite
25004 Literal based on this. Made changes everywhere to adapt to this.
25006 * expression.cs (Expression.MakeByteBlob): Optimize routine by
25007 dereferencing array only once, and also copes with enumrations.
25009 bytes are two bytes wide, not one.
25011 (Cast): Perform constant conversions.
25013 * ecore.cs (TryImplicitIntConversion): Return literals instead of
25014 wrappers to the literals here.
25016 * expression.cs (DoNumericPromotions): long literals can converted
25017 to ulong implicity (this is taken care of elsewhere, but I was
25018 missing this spot).
25020 * ecore.cs (Expression.Literalize): Make the return type Literal,
25021 to improve type checking.
25023 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
25025 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25027 * literal.cs: Revert code from ravi that checked the bounds. The
25028 bounds are sane by the definition of the type itself.
25030 * typemanager.cs: Fix implementation of ImplementsInterface. We
25031 need to actually look up in our parent hierarchy for interfaces
25034 * const.cs: Use the underlying type for enumerations
25036 * delegate.cs: Compute the basename for the delegate creation,
25037 that should fix the delegate test case, and restore the correct
25038 Type Lookup semantics in rootcontext
25040 * rootcontext.cs: Revert Ravi's last patch. The correct way of
25041 referencing a nested type with the Reflection API is using the "+"
25044 * cs-parser.jay: Do not require EOF token at the end.
25046 2001-12-20 Ravi Pratap <ravi@ximian.com>
25048 * rootcontext.cs (LookupType): Concatenate type names with
25049 a '.' instead of a '+' The test suite passes again.
25051 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
25052 field of the enumeration.
25054 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
25055 the case when the member is an EventExpr.
25057 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
25058 static has an associated instance expression.
25060 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
25062 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
25064 * class.cs (Event.Define): Register event and perform appropriate checks
25067 We define the Add and Remove methods even if the use provides none because
25068 in that case, we provide default implementations ourselves.
25070 Define a private field of the type of the event. This is done by the CSC compiler
25071 and we should be doing it too ;-)
25073 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
25074 More methods we use in code we generate.
25076 (multicast_delegate_type, delegate_type): Two separate types since the distinction
25079 (InitCoreTypes): Update accordingly for the above.
25081 * class.cs (Event.Emit): Generate code for default accessors that we provide
25083 (EmitDefaultMethod): Do the job in the above.
25085 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
25088 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25090 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
25091 builders even if we were missing one.
25093 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
25094 pass the Basename as our class name instead of the Name. The
25095 basename will be correctly composed for us.
25097 * parameter.cs (Paramters): Now takes a Location argument.
25099 * decl.cs (DeclSpace.LookupType): Removed convenience function and
25100 make all the code call directly LookupType in RootContext and take
25101 this chance to pass the Location information everywhere.
25103 * Everywhere: pass Location information.
25105 2001-12-19 Miguel de Icaza <miguel@ximian.com>
25107 * class.cs (Constructor.Define): Updated way of detecting the
25108 length of the parameters.
25110 (TypeContainer.DefineType): Use basename as the type name for
25113 (TypeContainer.Define): Do not recursively define types here, as
25114 definition is taken care in order by the RootContext.
25116 * tree.cs: Keep track of namespaces in a per-file basis.
25118 * parameter.cs (Parameter.ComputeSignature): Update to use
25121 (Parameters.GetSignature): ditto.
25123 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
25124 instead of a TypeContainer.
25126 (Interface.SemanticAnalysis): Use `this' instead of our parent to
25127 resolve names. Because we need to be resolve in our context, not
25130 * driver.cs: Implement response files.
25132 * class.cs (TypeContainer.DefineType): If we are defined, do not
25133 redefine ourselves.
25135 (Event.Emit): Emit the code for add/remove handlers.
25136 (Event.Define): Save the MethodBuilders for add/remove.
25138 * typemanager.cs: Use pair here too.
25140 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
25141 DictionaryEntry requires the first argument to be non-null.
25143 (enum_declaration): Compute full name for registering the
25146 (delegate_declaration): Instead of using
25147 formal_parameter_list, use opt_formal_parameter_list as the list
25150 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
25151 (EventParsing): New property that controls whether `add' and
25152 `remove' are returned as tokens or identifiers (for events);
25154 2001-12-19 Ravi Pratap <ravi@ximian.com>
25156 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
25157 use MyEventBuilder only and let it wrap the real builder for us.
25159 (MyEventBuilder): Revamp constructor etc.
25161 Implement all operations that we perform on EventBuilder in precisely the same
25164 (FindMembers): Update to use the EventBuilder member.
25166 (Event.Emit): Update accordingly.
25168 2001-12-18 Ravi Pratap <ravi@ximian.com>
25170 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
25171 by calling the appropriate methods.
25173 (GetCustomAttributes): Make stubs as they cannot possibly do anything
25176 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
25178 2001-12-17 Ravi Pratap <ravi@ximian.com>
25180 * delegate.cs (Delegate.Populate): Check that the return type
25181 and various parameters types are indeed accessible.
25183 * class.cs (Constructor.Define): Same here.
25185 (Field.Define): Ditto.
25187 (Event.Define): Ditto.
25189 (Operator.Define): Check that the underlying Method defined itself
25190 correctly - so it's MethodBuilder should not be null.
25192 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
25193 expression happens to be null.
25195 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
25196 members but as of now we don't seem to be able to do anything really useful with it.
25198 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
25199 not the EventBuilder.
25201 2001-12-18 Miguel de Icaza <miguel@ximian.com>
25203 * cs-tokenizer.cs: Add support for defines.
25204 Add support for #if, #elif, #else, #endif
25206 (eval_var): evaluates a variable.
25207 (eval): stubbed for evaluating functions.
25209 * cs-parser.jay: Pass the defines information
25211 * driver.cs: Add --define command line option.
25213 * decl.cs: Move MemberCore here.
25215 Make it the base class for DeclSpace. This allows us to catch and
25216 report 108 and 109 for everything now.
25218 * class.cs (TypeContainer.Define): Extract all the members
25219 before populating and emit the warning 108 (new keyword required
25220 to override) instead of having each member implement this.
25222 (MemberCore.Define): New abstract method, we will be using this in
25223 the warning reporting engine in Populate.
25225 (Operator.Define): Adjust to new MemberCore protocol.
25227 * const.cs (Const): This does not derive from Expression, it is a
25228 temporary object we use to create fields, it is a MemberCore.
25230 * class.cs (Method.Define): Allow the entry point to be in a
25233 * driver.cs: Rewrite the argument handler to clean it up a bit.
25235 * rootcontext.cs: Made it just an auxiliary namespace feature by
25236 making everything static.
25238 * driver.cs: Adapt code to use RootContext type name instead of
25241 * delegate.cs: Remove RootContext argument.
25243 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
25246 * class.cs (Event.Define): The lookup can fail.
25248 * cs-tokenizer.cs: Begin implementation of pre-procesor.
25250 * expression.cs: Resolve the this instance before invoking the code.
25252 2001-12-17 Miguel de Icaza <miguel@ximian.com>
25254 * cs-parser.jay: Add a production in element_access that allows
25255 the thing to become a "type" reference. This way we can parse
25256 things like "(string [])" as a type.
25258 Note that this still does not handle the more complex rules of
25262 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
25264 * ecore.cs: (CopyNewMethods): new utility function used to
25265 assemble the list of methods from running FindMembers.
25267 (MemberLookup): Rework FindMembers so that
25269 2001-12-16 Miguel de Icaza <miguel@ximian.com>
25271 * class.cs (TypeContainer): Remove Delegates who fail to be
25274 * delegate.cs (Populate): Verify that we dont get null return
25275 values. TODO: Check for AsAccessible.
25277 * cs-parser.jay: Use basename to emit error 574 (destructor should
25278 have the same name as container class), not the full name.
25280 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
25281 possible representation.
25283 Also implements integer type suffixes U and L.
25285 2001-12-15 Miguel de Icaza <miguel@ximian.com>
25287 * expression.cs (ArrayCreation.DoResolve): We need to do the
25288 argument resolution *always*.
25290 * decl.cs: Make this hold the namespace. Hold the root context as
25292 (LookupType): Move here.
25294 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
25296 * location.cs (Row, Name): Fixed the code, it was always returning
25297 references to the first file.
25299 * interface.cs: Register properties defined through interfaces.
25301 * driver.cs: Add support for globbing on the command line
25303 * class.cs (Field): Make it derive from MemberCore as well.
25306 2001-12-15 Ravi Pratap <ravi@ximian.com>
25308 * class.cs (Event::Define): Check that the type of the event is a delegate
25309 type else flag error #66.
25311 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
25314 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
25315 values of EntryPoint, CharSet etc etc.
25317 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
25319 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
25320 be null and we should ignore this. I am not sure if this is really clean. Apparently,
25321 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
25322 which needs this to do its work.
25324 * ../errors/cs0066.cs : Add.
25326 2001-12-14 Miguel de Icaza <miguel@ximian.com>
25328 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
25331 * class.cs: (MethodSignature.MethodSignature): Removed hack that
25332 clears out the parameters field.
25333 (MemberSignatureCompare): Cleanup
25335 (MemberCore): New base class used to share code between MethodCore
25338 (RegisterRequiredImplementations) BindingFlags.Public requires
25339 either BindingFlags.Instace or Static. Use instance here.
25341 (Property): Refactored code to cope better with the full spec.
25343 * parameter.cs (GetParameterInfo): Return an empty array instead
25346 * class.cs (Property): Abstract or extern properties have no bodies.
25348 * parameter.cs (GetParameterInfo): return a zero-sized array.
25350 * class.cs (TypeContainer.MethodModifiersValid): Move all the
25351 method modifier validation to the typecontainer so we can reuse
25352 this on properties.
25354 (MethodCore.ParameterTypes): return an empty sized array of types.
25356 (Property.Define): Test property modifier validity.
25358 Add tests for sealed/override too.
25360 (Method.Emit): abstract or extern methods have no bodies.
25362 2001-12-14 Ravi Pratap <ravi@ximian.com>
25364 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
25367 (Method::Define, ::Emit): Modify accordingly.
25369 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
25371 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
25373 * makefile: Pass in /unsafe.
25375 2001-12-13 Miguel de Icaza <miguel@ximian.com>
25377 * class.cs (MakeKey): Kill routine.
25379 * class.cs (TypeContainer.Define): Correctly define explicit
25380 method implementations (they require the full interface name plus
25383 * typemanager.cs: Deply the PtrHashtable here and stop using the
25384 lame keys. Things work so much better.
25386 This of course broke everyone who depended on `RegisterMethod' to
25387 do the `test for existance' test. This has to be done elsewhere.
25389 * support.cs (PtrHashtable): A hashtable that avoid comparing with
25390 the object stupid Equals method (because, that like fails all over
25391 the place). We still do not use it.
25393 * class.cs (TypeContainer.SetRequiredInterface,
25394 TypeContainer.RequireMethods): Killed these two routines and moved
25395 all the functionality to RegisterRequiredImplementations.
25397 (TypeContainer.RegisterRequiredImplementations): This routine now
25398 registers all the implementations required in an array for the
25399 interfaces and abstract methods. We use an array of structures
25400 which can be computed ahead of time to reduce memory usage and we
25401 also assume that lookups are cheap as most classes will not
25402 implement too many interfaces.
25404 We also avoid creating too many MethodSignatures.
25406 (TypeContainer.IsInterfaceMethod): Update and optionally does not
25407 clear the "pending" bit if we find that there are problems with
25410 (TypeContainer.VerifyPendingMethods): Update to report errors of
25411 methods that look like implementations but are not.
25413 (TypeContainer.Define): Add support for explicit interface method
25416 2001-12-12 Miguel de Icaza <miguel@ximian.com>
25418 * typemanager.cs: Keep track of the parameters here instead of
25419 being a feature of the TypeContainer.
25421 * class.cs: Drop the registration of parameters here, as
25422 InterfaceMethods are also interface declarations.
25424 * delegate.cs: Register methods with the TypeManager not only with
25425 the TypeContainer. This code was buggy.
25427 * interface.cs: Full registation here.
25429 2001-12-11 Miguel de Icaza <miguel@ximian.com>
25431 * expression.cs: Remove reducer for binary expressions, it can not
25434 * const.cs: Put here the code that used to go into constant.cs
25436 * constant.cs: Put here the code for constants, this is a new base
25437 class for Literals.
25439 * literal.cs: Make Literal derive from Constant.
25441 2001-12-09 Miguel de Icaza <miguel@ximian.com>
25443 * statement.cs (Return.Emit): Report error 157 if the user
25444 attempts to return from a finally block.
25446 (Return.Emit): Instead of emitting a return, jump to the end of
25449 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
25450 LocalBuilder to store the result of the function. ReturnLabel is
25451 the target where we jump.
25454 2001-12-09 Radek Doulik <rodo@ximian.com>
25456 * cs-parser.jay: remember alias in current namespace
25458 * ecore.cs (SimpleName::DoResolve): use aliases for types or
25461 * class.cs (LookupAlias): lookup alias in my_namespace
25463 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
25465 (LookupAlias): lookup alias in this and if needed in parent
25468 2001-12-08 Miguel de Icaza <miguel@ximian.com>
25472 * rootcontext.cs: (ModuleBuilder) Made static, first step into
25473 making things static. I need this to avoid passing the
25474 TypeContainer when calling ParameterType.
25476 * support.cs (InternalParameters.ParameterType): Remove ugly hack
25477 that did string manipulation to compute the type and then call
25478 GetType. Use Parameter.ParameterType instead.
25480 * cs-tokenizer.cs: Consume the suffix for floating values.
25482 * expression.cs (ParameterReference): figure out whether this is a
25483 reference parameter or not. Kill an extra variable by computing
25484 the arg_idx during emission.
25486 * parameter.cs (Parameters.GetParameterInfo): New overloaded
25487 function that returns whether a parameter is an out/ref value or not.
25489 (Parameter.ParameterType): The type of the parameter (base,
25490 without ref/out applied).
25492 (Parameter.Resolve): Perform resolution here.
25493 (Parameter.ExternalType): The full type (with ref/out applied).
25495 * statement.cs (Using.Emit, Using.EmitExpression): Implement
25496 support for expressions on the using statement.
25498 2001-12-07 Miguel de Icaza <miguel@ximian.com>
25500 * statement.cs (Using.EmitLocalVariableDecls): Split the
25501 localvariable handling of the using statement.
25503 (Block.EmitMeta): Keep track of variable count across blocks. We
25504 were reusing slots on separate branches of blocks.
25506 (Try.Emit): Emit the general code block, we were not emitting it.
25508 Check the type of the declaration to be an IDisposable or
25509 something that can be implicity converted to it.
25511 Emit conversions if required.
25513 * ecore.cs (EmptyExpression): New utility class.
25514 (Expression.ImplicitConversionExists): New utility function.
25516 2001-12-06 Miguel de Icaza <miguel@ximian.com>
25518 * statement.cs (Using): Implement.
25520 * expression.cs (LocalVariableReference): Support read only variables.
25522 * statement.cs: Remove the explicit emit for the Leave opcode.
25523 (VariableInfo): Add a readonly field.
25525 2001-12-05 Miguel de Icaza <miguel@ximian.com>
25527 * ecore.cs (ConvCast): new class used to encapsulate the various
25528 explicit integer conversions that works in both checked and
25529 unchecked contexts.
25531 (Expression.ConvertNumericExplicit): Use new ConvCast class to
25532 properly generate the overflow opcodes.
25534 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25536 * statement.cs: The correct type for the EmptyExpression is the
25537 element_type, not the variable type. Ravi pointed this out.
25539 2001-12-04 Ravi Pratap <ravi@ximian.com>
25541 * class.cs (Method::Define): Handle PInvoke methods specially
25542 by using DefinePInvokeMethod instead of the usual one.
25544 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
25545 above to do the task of extracting information and defining the method.
25547 2001-12-04 Ravi Pratap <ravi@ximian.com>
25549 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
25550 of the condition for string type.
25552 (Emit): Move that here.
25554 (ArrayCreation::CheckIndices): Keep string literals in their expression
25557 (EmitDynamicInitializers): Handle strings appropriately.
25559 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25561 * codegen.cs (EmitContext): Replace multiple variables with a
25562 single pointer to the current Switch statement.
25564 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
25567 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25571 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
25574 (Foreach.Emit): Foreach on arrays was not setting
25575 up the loop variables (for break/continue).
25577 (GotoCase): Semi-implented.
25579 2001-12-03 Ravi Pratap <ravi@ximian.com>
25581 * attribute.cs (CheckAttribute): Handle system attributes by using
25582 Attribute.GetAttributes to examine information we need.
25584 (GetValidPlaces): Same here.
25586 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
25588 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
25590 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
25592 (Method::Define): Set appropriate flags if we have a DllImport attribute.
25594 (Method::Emit): Handle the case when we are a PInvoke method.
25596 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25598 * expression.cs: Use ResolveWithSimpleName on compound names.
25600 2001-12-02 Ravi Pratap <ravi@ximian.com>
25602 * constant.cs (EmitConstant): Make sure we resolve the associated expression
25603 before trying to reduce it.
25605 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
25607 * constant.cs (LookupConstantValue): Implement.
25609 (EmitConstant): Use the above in emitting the constant.
25611 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
25612 that are user-defined by doing a LookupConstantValue on them.
25614 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
25617 2001-11-29 Miguel de Icaza <miguel@ximian.com>
25619 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
25621 (BaseAccess.DoResolve): Implement.
25623 (MemberAccess.DoResolve): Split this routine into a
25624 ResolveMemberAccess routine that can be used independently
25626 2001-11-28 Miguel de Icaza <miguel@ximian.com>
25628 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
25629 As that share bits of the implementation. Is returns a boolean,
25630 while As returns the Type that is being probed.
25632 2001-12-01 Ravi Pratap <ravi@ximian.com>
25634 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
25635 instead of a Literal - much easier.
25637 (EnumInTransit): Remove - utterly useless :-)
25639 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
25641 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
25643 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
25644 chain when we have no associated expression.
25646 2001-11-30 Ravi Pratap <ravi@ximian.com>
25648 * constant.cs (Define): Use Location while reporting the errror.
25650 Also emit a warning when 'new' is used and there is no inherited
25653 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
25656 (LookupEnumValue): Implement to lookup an enum member's value and define it
25659 (Populate): Re-write accordingly to use the above routine.
25661 2001-11-27 Miguel de Icaza <miguel@ximian.com>
25663 * expression.cs (This): Fix prototype for DoResolveLValue to
25664 override the base class DoResolveLValue.
25666 * cs-parser.cs: Report errors cs574 and cs575 (destructor
25669 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
25670 (we need to load the address of the field here). This fixes
25673 (FieldExpr.DoResolveLValue): Call the DoResolve
25674 function to initialize the Instance expression.
25676 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
25677 correctly the GetEnumerator operation on a value type.
25679 * cs-parser.jay: Add more simple parsing error catches.
25681 * statement.cs (Switch): Add support for string switches.
25682 Handle null specially.
25684 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
25686 2001-11-28 Ravi Pratap <ravi@ximian.com>
25688 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
25690 (declare_local_constant): New helper function.
25692 * statement.cs (AddConstant): Keep a separate record of constants
25694 (IsConstant): Implement to determine if a variable is a constant.
25696 (GetConstantExpression): Implement.
25698 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
25700 * statement.cs (IsVariableDefined): Re-write.
25702 2001-11-27 Ravi Pratap <ravi@ximian.com>
25704 * class.cs (TypeContainer::FindMembers): Look for constants
25705 in the case when we are looking for MemberTypes.Field
25707 * expression.cs (MemberAccess::DoResolve): Check that in the
25708 case we are a FieldExpr and a Literal, we are not being accessed
25709 by an instance reference.
25711 * cs-parser.jay (local_constant_declaration): Implement.
25713 (declaration_statement): Implement for constant declarations.
25715 2001-11-26 Miguel de Icaza <miguel@ximian.com>
25717 * statement.cs (Switch): Catch double defaults.
25719 (Switch): More work on the switch() statement
25720 implementation. It works for integral values now, need to finish
25724 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25726 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
25727 integer literals into other integer literals. To be used by
25730 2001-11-24 Ravi Pratap <ravi@ximian.com>
25732 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
25735 (EmitDynamicInitializers): Cope with the above since we extract data
25736 directly from ArrayData now.
25738 (ExpectInitializers): Keep track of whether initializers are mandatory
25741 (Bounds): Make it a hashtable to prevent the same dimension being
25742 recorded for every element in that dimension.
25744 (EmitDynamicInitializers): Fix bug which prevented the Set array method
25747 Also fix bug which was causing the indices to be emitted in the reverse
25750 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25752 * expression.cs (ArrayCreation): Implement the bits that Ravi left
25753 unfinished. They do not work, because the underlying code is
25756 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25758 * cs-parser.jay: Remove bogus fixme.
25760 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
25761 on Switch statement.
25763 2001-11-23 Ravi Pratap <ravi@ximian.com>
25765 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
25768 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
25769 parameter. Apparently, any expression is allowed.
25771 (ValidateInitializers): Update accordingly.
25773 (CheckIndices): Fix some tricky bugs thanks to recursion.
25775 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
25776 I was being completely brain-dead.
25778 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
25779 and re-write acordingly.
25781 (DelegateInvocation): Re-write accordingly.
25783 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
25785 (MakeByteBlob): Handle types more correctly.
25787 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
25788 initialization from expressions but it is incomplete because I am a complete
25791 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25793 * statement.cs (If.Emit): Fix a bug that generated incorrect code
25794 on If. Basically, we have to return `true' (ie, we do return to
25795 our caller) only if both branches of the if return.
25797 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
25798 short-circuit operators, handle them as short circuit operators.
25800 (Cast.DoResolve): Resolve type.
25801 (Cast.Cast): Take an expression as the target type.
25803 * cs-parser.jay (cast_expression): Remove old hack that only
25804 allowed a limited set of types to be handled. Now we take a
25805 unary_expression and we resolve to a type during semantic
25808 Use the grammar productions from Rhys to handle casts (this is
25809 not complete like Rhys syntax yet, we fail to handle that corner
25810 case that C# has regarding (-x), but we will get there.
25812 2001-11-22 Ravi Pratap <ravi@ximian.com>
25814 * class.cs (EmitFieldInitializer): Take care of the case when we have a
25815 field which is an array type.
25817 * cs-parser.jay (declare_local_variables): Support array initialization too.
25819 * typemanager.cs (MakeKey): Implement.
25821 (everywhere): Use the above appropriately.
25823 * cs-parser.jay (for_statement): Update for array initialization while
25824 declaring variables.
25826 * ecore.cs : The error message was correct, it's the variable's names that
25827 were misleading ;-) Make the code more readable.
25829 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
25830 the correct type etc.
25832 (ConvertExplicit): Handle Enum types by examining the underlying type.
25834 2001-11-21 Ravi Pratap <ravi@ximian.com>
25836 * parameter.cs (GetCallingConvention): Always return
25837 CallingConventions.Standard for now.
25839 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25841 * expression.cs (Binary.ResolveOperator): Update the values of `l'
25842 and `r' after calling DoNumericPromotions.
25844 * ecore.cs: Fix error message (the types were in the wrong order).
25846 * statement.cs (Foreach.ProbeCollectionType): Need to pass
25847 BindingFlags.Instance as well
25849 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
25850 implicit int literal conversion in an empty cast so that we
25851 propagate the right type upstream.
25853 (UnboxCast): new class used to unbox value types.
25854 (Expression.ConvertExplicit): Add explicit type conversions done
25857 (Expression.ImplicitNumericConversion): Oops, forgot to test for
25858 the target type before applying the implicit LongLiterals to ULong
25861 2001-11-21 Miguel de Icaza <miguel@ximian.com>
25863 * cs-parser.jay (for_statement): Reworked the way For works: now
25864 we declare manually any variables that are introduced in
25865 for_initializer to solve the problem of having out-of-band code
25866 emition (that is what got for broken).
25868 (declaration_statement): Perform the actual variable declaration
25869 that used to be done in local_variable_declaration here.
25871 (local_variable_declaration): Do not declare anything, just pass
25872 the information on a DictionaryEntry
25874 2001-11-20 Ravi Pratap <ravi@ximian.com>
25876 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
25877 re-write of the logic to now make it recursive.
25879 (UpdateIndices): Re-write accordingly.
25881 Store element data in a separate ArrayData list in the above methods.
25883 (MakeByteBlob): Implement to dump the array data into a byte array.
25885 2001-11-19 Ravi Pratap <ravi@ximian.com>
25887 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
25890 * constant.cs (Define): Implement.
25892 (EmitConstant): Re-write fully.
25894 Pass in location info.
25896 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
25899 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
25900 DictionaryEntry since we need location info too.
25902 (constant_declaration): Update accordingly.
25904 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
25905 code into another method : UpdateIndices.
25907 2001-11-18 Ravi Pratap <ravi@ximian.com>
25909 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
25910 some type checking etc.
25912 2001-11-17 Ravi Pratap <ravi@ximian.com>
25914 * expression.cs (ArrayCreation::ValidateInitializers): Implement
25915 bits to provide dimension info if the user skips doing that.
25917 Update second constructor to store the rank correctly.
25919 2001-11-16 Ravi Pratap <ravi@ximian.com>
25921 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
25922 and try to implement.
25924 * ../errors/cs0150.cs : Add.
25926 * ../errors/cs0178.cs : Add.
25928 2001-11-16 Miguel de Icaza <miguel@ximian.com>
25930 * statement.cs: Implement foreach on multi-dimensional arrays.
25932 * parameter.cs (Parameters.GetParameterByName): Also lookup the
25933 name of the params argument.
25935 * expression.cs: Use EmitStoreOpcode to get the right opcode while
25936 initializing the array.
25938 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
25939 we can use this elsewhere.
25941 * statement.cs: Finish implementation of foreach for single
25944 * cs-parser.jay: Use an out-of-band stack to pass information
25945 around, I wonder why I need this.
25947 foreach_block: Make the new foreach_block the current_block.
25949 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
25950 function used to return a static Parameters structure. Used for
25951 empty parameters, as those are created very frequently.
25953 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
25955 2001-11-15 Ravi Pratap <ravi@ximian.com>
25957 * interface.cs : Default modifier is private, not public. The
25958 make verify test passes again.
25960 2001-11-15 Ravi Pratap <ravi@ximian.com>
25962 * support.cs (ReflectionParameters): Fix logic to determine
25963 whether the last parameter is a params one. Test 9 passes again.
25965 * delegate.cs (Populate): Register the builders we define with
25966 RegisterParameterForBuilder. Test 19 passes again.
25968 * cs-parser.jay (property_declaration): Reference $6 instead
25969 of $$ to get at the location.
25971 (indexer_declaration): Similar stuff.
25973 (attribute): Ditto.
25975 * class.cs (Property): Register parameters for the Get and Set methods
25976 if they exist. Test 23 passes again.
25978 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
25979 call to EmitArguments as we are sure there aren't any params arguments.
25980 Test 32 passes again.
25982 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
25983 IndexOutOfRangeException.
25985 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
25986 Test 33 now passes again.
25988 2001-11-15 Miguel de Icaza <miguel@ximian.com>
25990 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
25991 broke a bunch of things. Will have to come up with a better way
25992 of tracking locations.
25994 * statement.cs: Implemented foreach for single dimension arrays.
25996 2001-11-09 Miguel de Icaza <miguel@ximian.com>
25998 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
25999 an error. This removes the lookup from the critical path.
26001 * cs-parser.jay: Removed use of temporary_loc, which is completely
26004 2001-11-14 Miguel de Icaza <miguel@ximian.com>
26006 * support.cs (ReflectionParameters.ParameterModifier): Report
26007 whether the argument is a PARAMS argument or not.
26009 * class.cs: Set the attribute `ParamArrayAttribute' on the
26010 parameter argument.
26012 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
26013 and cons_param_array_attribute (ConstructorInfo for
26014 ParamArrayAttribute).,
26016 * codegen.cs: Emit the return using the `Return' statement, that
26017 way we can report the error correctly for missing return values.
26019 * class.cs (Method.Emit): Clean up.
26021 * expression.cs (Argument.Resolve): Take another argument: the
26022 location where this argument is used. Notice that this is not
26023 part of the "Argument" class as to reduce the size of the
26024 structure (we know the approximate location anyways).
26026 Test if the argument is a variable-reference, if not, then
26027 complain with a 206.
26029 (Argument.Emit): Emit addresses of variables.
26031 (Argument.FullDesc): Simplify.
26033 (Invocation.DoResolve): Update for Argument.Resolve.
26035 (ElementAccess.DoResolve): ditto.
26037 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
26038 method should be virtual, as this method is always virtual.
26040 (NewDelegate.DoResolve): Update for Argument.Resolve.
26042 * class.cs (ConstructorInitializer.DoResolve): ditto.
26044 * attribute.cs (Attribute.Resolve): ditto.
26046 2001-11-13 Miguel de Icaza <miguel@ximian.com>
26048 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
26050 * expression.cs (ParameterReference): Drop IStackStorage and implement
26051 IAssignMethod instead.
26053 (LocalVariableReference): ditto.
26055 * ecore.cs (FieldExpr): Drop IStackStorage and implement
26056 IAssignMethod instead.
26058 2001-11-13 Miguel de Icaza <miguel@ximian.com>
26060 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
26061 enumerations that are used in heavily used structures derive from
26062 byte in a laughable and pathetic attempt to reduce memory usage.
26063 This is the kind of pre-optimzations that you should not do at
26064 home without adult supervision.
26066 * expression.cs (UnaryMutator): New class, used to handle ++ and
26067 -- separatedly from the other unary operators. Cleans up the
26068 code, and kills the ExpressionStatement dependency in Unary.
26070 (Unary): Removed `method' and `Arguments' from this class, making
26071 it smaller, and moving it all to SimpleCall, so I can reuse this
26072 code in other locations and avoid creating a lot of transient data
26073 strucutres when not required.
26075 * cs-parser.jay: Adjust for new changes.
26077 2001-11-11 Miguel de Icaza <miguel@ximian.com>
26079 * enum.cs (Enum.Populate): If there is a failure during
26082 * cs-parser.jay (opt_enum_base): we used to catch type errors
26083 here, but this is really incorrect. The type error should be
26084 catched during semantic analysis.
26086 2001-12-11 Ravi Pratap <ravi@ximian.com>
26088 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
26089 current_local_parameters as expected since I, in my stupidity, had forgotten
26092 * attribute.cs (GetValidPlaces): Fix stupid bug.
26094 * class.cs (Method::Emit): Perform check on applicability of attributes.
26096 (Constructor::Emit): Ditto.
26098 (Field::Emit): Ditto.
26100 (Field.Location): Store location information.
26102 (Property, Event, Indexer, Operator): Ditto.
26104 * cs-parser.jay (field_declaration): Pass in location for each field.
26106 * ../errors/cs0592.cs : Add.
26108 2001-11-12 Ravi Pratap <ravi@ximian.com>
26110 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
26112 (InitCoreTypes): Update accordingly.
26114 (RegisterAttrType, LookupAttr): Implement.
26116 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
26117 info about the same.
26119 (Resolve): Update to populate the above as necessary.
26121 (Error592): Helper.
26123 (GetValidPlaces): Helper to the above.
26125 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
26127 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
26129 2001-11-12 Ravi Pratap <ravi@ximian.com>
26131 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
26133 * ../errors/cs0617.cs : Add.
26135 2001-11-11 Ravi Pratap <ravi@ximian.com>
26137 * enum.cs (Emit): Rename to Populate to be more consistent with what
26138 we expect it to do and when exactly it is called.
26140 * class.cs, rootcontext.cs : Update accordingly.
26142 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
26143 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
26145 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
26147 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
26148 of a fieldinfo using the above, when dealing with a FieldBuilder.
26150 2001-11-10 Ravi Pratap <ravi@ximian.com>
26152 * ../errors/cs0031.cs : Add.
26154 * ../errors/cs1008.cs : Add.
26156 * ../errrors/cs0543.cs : Add.
26158 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
26161 (FindMembers): Implement.
26163 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
26164 enums and delegates too.
26166 (enum_types): Rename to builder_to_enum.
26168 (delegate_types): Rename to builder_to_delegate.
26170 * delegate.cs (FindMembers): Implement.
26172 2001-11-09 Ravi Pratap <ravi@ximian.com>
26174 * typemanager.cs (IsEnumType): Implement.
26176 * enum.cs (Emit): Re-write parts to account for the underlying type
26177 better and perform checking etc.
26179 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
26180 of the underlying type.
26182 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
26185 * enum.cs (error31): Helper to report error #31.
26187 * cs-parser.jay (enum_declaration): Store location of each member too.
26189 * enum.cs (member_to_location): New hashtable.
26191 (AddEnumMember): Update location hashtable.
26193 (Emit): Use the location of each member while reporting errors.
26195 2001-11-09 Miguel de Icaza <miguel@ximian.com>
26197 * cs-parser.jay: A for_initializer if is a
26198 local_variable_declaration really ammount to have an implicit
26199 block with the variable declaration and no initializer for for.
26201 * statement.cs (For.Emit): Cope with null initializers.
26203 This fixes the infinite loop on for initializers.
26205 2001-11-08 Miguel de Icaza <miguel@ximian.com>
26207 * enum.cs: More cleanup.
26209 * ecore.cs: Remove dead code.
26211 * class.cs (Property.Emit): More simplification.
26212 (Event.Emit): ditto.
26214 Reworked to have less levels of indentation.
26216 2001-11-08 Ravi Pratap <ravi@ximian.com>
26218 * class.cs (Property): Emit attributes.
26228 * enum.cs (Emit): Ditto.
26230 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
26233 * class.cs (Field, Event, etc.): Move attribute generation into the
26234 Emit method everywhere.
26236 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
26237 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
26238 as we had no way of defining nested enums !
26240 * rootcontext.cs : Adjust code accordingly.
26242 * typemanager.cs (AddEnumType): To keep track of enum types separately.
26244 2001-11-07 Ravi Pratap <ravi@ximian.com>
26246 * expression.cs (EvalConstantExpression): Move into ecore.cs
26248 * enum.cs (Enum): Rename some members and make them public and readonly
26249 according to our convention.
26251 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
26254 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
26256 (Enum::Emit): Write a simple version for now which doesn't try to compute
26257 expressions. I shall modify this to be more robust in just a while.
26259 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
26261 (TypeContainer::CloseType): Create the Enum types too.
26263 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
26265 * expression.cs (EvalConstantExpression): Get rid of completely.
26267 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
26268 user-defined values and other cases.
26270 (IsValidEnumLiteral): Helper function.
26272 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
26273 out there in the case we had a literal FieldExpr.
26275 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
26277 (Literalize): Revamp a bit to take two arguments.
26279 (EnumLiteral): New class which derives from Literal to wrap enum literals.
26281 2001-11-06 Ravi Pratap <ravi@ximian.com>
26283 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
26285 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
26287 (Resolve): Use the above to ensure we have proper initializers.
26289 2001-11-05 Ravi Pratap <ravi@ximian.com>
26291 * expression.cs (Expression::EvalConstantExpression): New method to
26292 evaluate constant expressions.
26294 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
26296 2001-11-07 Miguel de Icaza <miguel@ximian.com>
26298 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
26301 (Binary.ResolveOperator): Handle operator != (object a, object b)
26302 and operator == (object a, object b);
26304 (Binary.DoNumericPromotions): Indicate whether the numeric
26305 promotion was possible.
26307 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
26310 Made the ArrayAccess implement interface IAssignMethod instead of
26311 IStackStore as the order in which arguments are passed reflects
26314 * assign.cs: Instead of using expr.ExprClass to select the way of
26315 assinging, probe for the IStackStore/IAssignMethod interfaces.
26317 * typemanager.cs: Load InitializeArray definition.
26319 * rootcontext.cs (RootContext.MakeStaticData): Used to define
26320 static data that can be used to initialize arrays.
26322 2001-11-05 Miguel de Icaza <miguel@ximian.com>
26324 * expression.cs: Handle operator== and operator!= for booleans.
26326 (Conditioal.Reduce): Implement reducer for the ?: operator.
26328 (Conditional.Resolve): Implement dead code elimination.
26330 (Binary.Resolve): Catch string literals and return a new
26331 concatenated string.
26333 (Unary.Reduce): Implement reduction of unary expressions.
26335 * ecore.cs: Split out the expression core handling here.
26337 (Expression.Reduce): New method used to perform constant folding
26338 and CSE. This is needed to support constant-expressions.
26340 * statement.cs (Statement.EmitBoolExpression): Pass true and false
26341 targets, and optimize for !x.
26343 2001-11-04 Ravi Pratap <ravi@ximian.com>
26345 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
26346 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
26347 set custom atttributes.
26349 * literal.cs (Literal::GetValue): New abstract method to return the actual
26350 value of the literal, cast as an object.
26352 (*Literal): Implement GetValue method.
26354 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
26355 expressions to the arraylist but objects of type Argument.
26357 * class.cs (TypeContainer::Emit): Emit our attributes too.
26359 (Method::Emit, Constructor::Emit): Ditto.
26361 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
26362 to be ignoring earlier.
26364 2001-11-03 Ravi Pratap <ravi@ximian.com>
26366 * attribute.cs (AttributeSection::Define): Implement to do the business
26367 of constructing a CustomAttributeBuilder.
26369 (Attribute): New trivial class. Increases readability of code.
26371 * cs-parser.jay : Update accordingly.
26373 (positional_argument_list, named_argument_list, named_argument): New rules
26375 (attribute_arguments): Use the above so that we are more correct.
26377 2001-11-02 Ravi Pratap <ravi@ximian.com>
26379 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
26380 to perform all checks for a method with a params parameter.
26382 (Invocation::OverloadResolve): Update to use the above method and therefore
26383 cope correctly with params method invocations.
26385 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
26388 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
26389 constructors in our parent too because we can't afford to miss out on
26392 * attribute.cs (AttributeSection): New name for the class Attribute
26394 Other trivial changes to improve readability.
26396 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
26397 use the new class names.
26399 2001-11-01 Ravi Pratap <ravi@ximian.com>
26401 * class.cs (Method::Define): Complete definition for params types too
26403 (Indexer::Define): Ditto.
26405 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
26406 Cope everywhere with a request for info about the array parameter.
26408 2001-11-01 Ravi Pratap <ravi@ximian.com>
26410 * tree.cs (RecordNamespace): Fix up to check for the correct key.
26412 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
26413 local_variable_type to extract the string corresponding to the type.
26415 (local_variable_type): Fixup the action to use the new helper method.
26417 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
26420 * expression.cs : Clean out code which uses the above.
26422 2001-10-31 Ravi Pratap <ravi@ximian.com>
26424 * typemanager.cs (RegisterMethod): Check if we already have an existing key
26425 and bale out if necessary by returning a false.
26427 (RegisterProperty): Ditto.
26429 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
26430 and print out appropriate error messages.
26432 * interface.cs (everywhere): Ditto.
26434 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
26435 location to constructor.
26437 * class.cs (Property, Event, Indexer): Update accordingly.
26439 * ../errors/cs111.cs : Added.
26441 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
26442 of a method, as laid down by the spec.
26444 (Invocation::OverloadResolve): Use the above method.
26446 2001-10-31 Ravi Pratap <ravi@ximian.com>
26448 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
26449 now take a TypeContainer and a Parameters object.
26451 (ParameterData): Modify return type of ParameterModifier method to be
26452 Parameter.Modifier and not a string.
26454 (ReflectionParameters, InternalParameters): Update accordingly.
26456 * expression.cs (Argument::GetParameterModifier): Same here.
26458 * support.cs (InternalParameters::ParameterType): Find a better way of determining
26459 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
26460 symbol in it at all so maybe this is only for now.
26462 2001-10-30 Ravi Pratap <ravi@ximian.com>
26464 * support.cs (InternalParameters): Constructor now takes an extra argument
26465 which is the actual Parameters class.
26467 (ParameterDesc): Update to provide info on ref/out modifiers.
26469 * class.cs (everywhere): Update call to InternalParameters to pass in
26470 the second argument too.
26472 * support.cs (ParameterData): Add ParameterModifier, which is a method
26473 to return the modifier info [ref/out etc]
26475 (InternalParameters, ReflectionParameters): Implement the above.
26477 * expression.cs (Argument::ParameterModifier): Similar function to return
26478 info about the argument's modifiers.
26480 (Invocation::OverloadResolve): Update to take into account matching modifiers
26483 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
26484 a new SetFormalParameters object which we pass to InternalParameters.
26486 2001-10-30 Ravi Pratap <ravi@ximian.com>
26488 * expression.cs (NewArray): Merge into the ArrayCreation class.
26490 2001-10-29 Ravi Pratap <ravi@ximian.com>
26492 * expression.cs (NewArray): Merge classes NewBuiltinArray and
26493 NewUserdefinedArray into one as there wasn't much of a use in having
26496 * expression.cs (Argument): Change field's name to ArgType from Type.
26498 (Type): New readonly property which returns the proper type, taking into
26499 account ref/out modifiers.
26501 (everywhere): Adjust code accordingly for the above.
26503 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
26504 whether we are emitting for a ref or out parameter.
26506 * expression.cs (Argument::Emit): Use the above field to set the state.
26508 (LocalVariableReference::Emit): Update to honour the flag and emit the
26511 * parameter.cs (Attributes): Set the correct flags for ref parameters.
26513 * expression.cs (Argument::FullDesc): New function to provide a full desc.
26515 * support.cs (ParameterData): Add method ParameterDesc to the interface.
26517 (ReflectionParameters, InternalParameters): Implement the above method.
26519 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
26522 (Invocation::FullMethodDesc): Ditto.
26524 2001-10-29 Miguel de Icaza <miguel@ximian.com>
26526 * cs-parser.jay: Add extra production for the second form of array
26529 * expression.cs (ArrayCreation): Update to reflect the above
26532 * Small changes to prepare for Array initialization.
26534 2001-10-28 Miguel de Icaza <miguel@ximian.com>
26536 * typemanager.cs (ImplementsInterface): interface might be null;
26537 Deal with this problem;
26539 Also, we do store negative hits on the cache (null values), so use
26540 this instead of calling t.GetInterfaces on the type everytime.
26542 2001-10-28 Ravi Pratap <ravi@ximian.com>
26544 * typemanager.cs (IsBuiltinType): New method to help determine the same.
26546 * expression.cs (New::DoResolve): Get rid of array creation code and instead
26547 split functionality out into different classes.
26549 (New::FormArrayType): Move into NewBuiltinArray.
26551 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
26554 (NewBuiltinArray): New class to handle creation of built-in arrays.
26556 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
26557 account creation of one-dimensional arrays.
26559 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
26561 (NewUserdefinedArray::DoResolve): Implement.
26563 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
26565 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
26566 we maintain inside the TypeManager. This is necessary to perform lookups on the
26569 (LookupType): Update to perform GetType on the module builders too.
26571 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
26573 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
26575 2001-10-23 Ravi Pratap <ravi@ximian.com>
26577 * expression.cs (New::DoResolve): Implement guts of array creation.
26579 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
26581 2001-10-27 Miguel de Icaza <miguel@ximian.com>
26583 * expression.cs: Fix bug I introduced lsat night that broke
26586 (Expression.Resolve): Report a 246 error (can not resolve name)
26587 if we find a SimpleName in the stream.
26589 (Expression.ResolveLValue): Ditto.
26591 (Expression.ResolveWithSimpleName): This function is a variant of
26592 ResolveName, this one allows SimpleNames to be returned without a
26593 warning. The only consumer of SimpleNames is MemberAccess
26595 2001-10-26 Miguel de Icaza <miguel@ximian.com>
26597 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
26598 might arrive here. I have my doubts that this is correct.
26600 * statement.cs (Lock): Implement lock statement.
26602 * cs-parser.jay: Small fixes to support `lock' and `using'
26604 * cs-tokenizer.cs: Remove extra space
26606 * driver.cs: New flag --checked, allows to turn on integer math
26609 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
26610 Threading.Monitor.Exit
26612 2001-10-23 Miguel de Icaza <miguel@ximian.com>
26614 * expression.cs (IndexerAccess::DoResolveLValue): Set the
26615 Expression Class to be IndexerAccess.
26617 Notice that Indexer::DoResolve sets the eclass to Value.
26619 2001-10-22 Miguel de Icaza <miguel@ximian.com>
26621 * class.cs (TypeContainer::Emit): Emit code for indexers.
26623 * assign.cs (IAssignMethod): New interface implemented by Indexers
26624 and Properties for handling assignment.
26626 (Assign::Emit): Simplify and reuse code.
26628 * expression.cs (IndexerAccess, PropertyExpr): Implement
26629 IAssignMethod, clean up old code.
26631 2001-10-22 Ravi Pratap <ravi@ximian.com>
26633 * typemanager.cs (ImplementsInterface): New method to determine if a type
26634 implements a given interface. Provides a nice cache too.
26636 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
26639 (ConvertReferenceExplicit): Ditto.
26641 * delegate.cs (Delegate::Populate): Update to define the parameters on the
26642 various methods, with correct names etc.
26644 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
26645 Operator.UnaryNegation.
26647 * cs-parser.jay (operator_declarator): Be a little clever in the case where
26648 we have a unary plus or minus operator.
26650 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
26653 * everywhere : update accordingly.
26655 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
26658 * class.cs (Method::Define): For the case where we are implementing a method
26659 inherited from an interface, we need to set the MethodAttributes.Final flag too.
26660 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
26662 2001-10-21 Ravi Pratap <ravi@ximian.com>
26664 * interface.cs (FindMembers): Implement to work around S.R.E
26667 * typemanager.cs (IsInterfaceType): Implement.
26669 (FindMembers): Update to handle interface types too.
26671 * expression.cs (ImplicitReferenceConversion): Re-write bits which
26672 use IsAssignableFrom as that is not correct - it doesn't work.
26674 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
26675 and accordingly override EmitStatement.
26677 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
26678 using the correct logic :-)
26680 2001-10-19 Ravi Pratap <ravi@ximian.com>
26682 * ../errors/cs-11.cs : Add to demonstrate error -11
26684 2001-10-17 Miguel de Icaza <miguel@ximian.com>
26686 * assign.cs (Assign::Resolve): Resolve right hand side first, and
26687 then pass this as a hint to ResolveLValue.
26689 * expression.cs (FieldExpr): Add Location information
26691 (FieldExpr::LValueResolve): Report assignment to readonly
26694 (Expression::ExprClassFromMemberInfo): Pass location information.
26696 (Expression::ResolveLValue): Add new method that resolves an
26699 (Expression::DoResolveLValue): Default invocation calls
26702 (Indexers): New class used to keep track of indexers in a given
26705 (IStackStore): Renamed from LValue, as it did not really describe
26706 what this did. Also ResolveLValue is gone from this interface and
26707 now is part of Expression.
26709 (ElementAccess): Depending on the element access type
26711 * typemanager.cs: Add `indexer_name_type' as a Core type
26712 (System.Runtime.CompilerServices.IndexerNameAttribute)
26714 * statement.cs (Goto): Take a location.
26716 2001-10-18 Ravi Pratap <ravi@ximian.com>
26718 * delegate.cs (Delegate::VerifyDelegate): New method to verify
26719 if two delegates are compatible.
26721 (NewDelegate::DoResolve): Update to take care of the case when
26722 we instantiate a delegate from another delegate.
26724 * typemanager.cs (FindMembers): Don't even try to look up members
26725 of Delegate types for now.
26727 2001-10-18 Ravi Pratap <ravi@ximian.com>
26729 * delegate.cs (NewDelegate): New class to take care of delegate
26732 * expression.cs (New): Split the delegate related code out into
26733 the NewDelegate class.
26735 * delegate.cs (DelegateInvocation): New class to handle delegate
26738 * expression.cs (Invocation): Split out delegate related code into
26739 the DelegateInvocation class.
26741 2001-10-17 Ravi Pratap <ravi@ximian.com>
26743 * expression.cs (New::DoResolve): Implement delegate creation fully
26744 and according to the spec.
26746 (New::DoEmit): Update to handle delegates differently.
26748 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
26749 because of which we were printing out arguments in reverse order !
26751 * delegate.cs (VerifyMethod): Implement to check if the given method
26752 matches the delegate.
26754 (FullDelegateDesc): Implement.
26756 (VerifyApplicability): Implement.
26758 * expression.cs (Invocation::DoResolve): Update to accordingly handle
26759 delegate invocations too.
26761 (Invocation::Emit): Ditto.
26763 * ../errors/cs1593.cs : Added.
26765 * ../errors/cs1594.cs : Added.
26767 * delegate.cs (InstanceExpression, TargetMethod): New properties.
26769 2001-10-16 Ravi Pratap <ravi@ximian.com>
26771 * typemanager.cs (intptr_type): Core type for System.IntPtr
26773 (InitCoreTypes): Update for the same.
26775 (iasyncresult_type, asynccallback_type): Ditto.
26777 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
26780 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
26783 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
26784 the builders for the 4 members of a delegate type :-)
26786 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
26789 * expression.cs (New::DoResolve): Implement guts for delegate creation.
26791 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
26793 2001-10-15 Miguel de Icaza <miguel@ximian.com>
26795 * statement.cs (Break::Emit): Implement.
26796 (Continue::Emit): Implement.
26798 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
26799 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
26800 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
26801 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
26804 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
26805 properties that track the label for the current loop (begin of the
26806 loop and end of the loop).
26808 2001-10-15 Ravi Pratap <ravi@ximian.com>
26810 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
26811 use of emitting anything at all.
26813 * class.cs, rootcontext.cs : Get rid of calls to the same.
26815 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
26817 (Populate): Define the constructor correctly and set the implementation
26820 * typemanager.cs (delegate_types): New hashtable to hold delegates that
26823 (AddDelegateType): Implement.
26825 (IsDelegateType): Implement helper method.
26827 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
26829 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
26830 and accordingly handle it.
26832 * delegate.cs (Populate): Take TypeContainer argument.
26833 Implement bits to define the Invoke method. However, I still haven't figured out
26834 how to take care of the native int bit :-(
26836 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
26837 Qualify the name of the delegate, not its return type !
26839 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
26842 (StandardConversionExists): Checking for array types turns out to be recursive.
26844 (ConvertReferenceExplicit): Implement array conversion.
26846 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
26848 2001-10-12 Ravi Pratap <ravi@ximian.com>
26850 * cs-parser.jay (delegate_declaration): Store the fully qualified
26851 name as it is a type declaration.
26853 * delegate.cs (ReturnType, Name): Rename members to these. Make them
26856 (DefineDelegate): Renamed from Define. Does the same thing essentially,
26857 as TypeContainer::DefineType.
26859 (Populate): Method in which all the definition of the various methods (Invoke)
26862 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
26865 (CloseDelegate): Finally creates the delegate.
26867 * class.cs (TypeContainer::DefineType): Update to define delegates.
26868 (Populate, Emit and CloseType): Do the same thing here too.
26870 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
26871 delegates in all these operations.
26873 2001-10-14 Miguel de Icaza <miguel@ximian.com>
26875 * expression.cs: LocalTemporary: a new expression used to
26876 reference a temporary that has been created.
26878 * assign.cs: Handle PropertyAccess back here, so that we can
26879 provide the proper semantic access to properties.
26881 * expression.cs (Expression::ConvertReferenceExplicit): Implement
26882 a few more explicit conversions.
26884 * modifiers.cs: `NEW' modifier maps to HideBySig.
26886 * expression.cs (PropertyExpr): Make this into an
26887 ExpressionStatement, and support the EmitStatement code path.
26889 Perform get/set error checking, clean up the interface.
26891 * assign.cs: recognize PropertyExprs as targets, and if so, turn
26892 them into toplevel access objects.
26894 2001-10-12 Miguel de Icaza <miguel@ximian.com>
26896 * expression.cs: PropertyExpr::PropertyExpr: use work around the
26899 * typemanager.cs: Keep track here of our PropertyBuilders again to
26900 work around lameness in SRE.
26902 2001-10-11 Miguel de Icaza <miguel@ximian.com>
26904 * expression.cs (LValue::LValueResolve): New method in the
26905 interface, used to perform a second resolution pass for LValues.
26907 (This::DoResolve): Catch the use of this in static methods.
26909 (This::LValueResolve): Implement.
26911 (This::Store): Remove warning, assigning to `this' in structures
26914 (Invocation::Emit): Deal with invocation of
26915 methods on value types. We need to pass the address to structure
26916 methods rather than the object itself. (The equivalent code to
26917 emit "this" for structures leaves the entire structure on the
26918 stack instead of a pointer to it).
26920 (ParameterReference::DoResolve): Compute the real index for the
26921 argument based on whether the method takes or not a `this' pointer
26922 (ie, the method is static).
26924 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
26925 value types returned from functions when we need to invoke a
26926 method on the sturcture.
26929 2001-10-11 Ravi Pratap <ravi@ximian.com>
26931 * class.cs (TypeContainer::DefineType): Method to actually do the business of
26932 defining the type in the Modulebuilder or Typebuilder. This is to take
26933 care of nested types which need to be defined on the TypeBuilder using
26934 DefineNestedMethod.
26936 (TypeContainer::GetClassBases): Implement. Essentially the code from the
26937 methods in RootContext, only ported to be part of TypeContainer.
26939 (TypeContainer::GetInterfaceOrClass): Ditto.
26941 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
26943 * interface.cs (Interface::DefineInterface): New method. Does exactly
26944 what RootContext.CreateInterface did earlier, only it takes care of nested types
26947 (Interface::GetInterfaces): Move from RootContext here and port.
26949 (Interface::GetInterfaceByName): Same here.
26951 * rootcontext.cs (ResolveTree): Re-write.
26953 (PopulateTypes): Re-write.
26955 * class.cs (TypeContainer::Populate): Populate nested types too.
26956 (TypeContainer::Emit): Emit nested members too.
26958 * typemanager.cs (AddUserType): Do not make use of the FullName property,
26959 instead just use the name argument passed in as it is already fully
26962 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
26963 to TypeContainer mapping to see if a type is user-defined.
26965 * class.cs (TypeContainer::CloseType): Implement.
26967 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
26968 the default constructor.
26970 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
26973 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
26975 * interface.cs (CloseType): Create the type here.
26977 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
26980 Remove all the methods which are now in TypeContainer.
26982 2001-10-10 Ravi Pratap <ravi@ximian.com>
26984 * delegate.cs (Define): Re-write bits to define the delegate
26987 2001-10-10 Miguel de Icaza <miguel@ximian.com>
26989 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
26991 * expression.cs (ImplicitReferenceConversion): handle null as well
26992 as a source to convert to any reference type.
26994 * statement.cs (Return): Perform any implicit conversions to
26995 expected return type.
26997 Validate use of return statement.
26999 * codegen.cs (EmitContext): Pass the expected return type here.
27001 * class.cs (Method, Constructor, Property): Pass expected return
27002 type to EmitContext.
27004 2001-10-09 Miguel de Icaza <miguel@ximian.com>
27006 * expression.cs: Make DoResolve take an EmitContext instead of a
27009 Replaced `l' and `location' for `loc', for consistency.
27011 (Error, Warning): Remove unneeded Tc argument.
27013 * assign.cs, literal.cs, constant.cs: Update to new calling
27016 * codegen.cs: EmitContext now contains a flag indicating whether
27017 code is being generated in a static method or not.
27019 * cs-parser.jay: DecomposeQI, new function that replaces the old
27020 QualifiedIdentifier. Now we always decompose the assembled
27021 strings from qualified_identifier productions into a group of
27024 2001-10-08 Miguel de Icaza <miguel@ximian.com>
27026 * rootcontext.cs: Deal with field-less struct types correctly now
27027 by passing the size option to Define Type.
27029 * class.cs: Removed hack that created one static field.
27031 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27033 * statement.cs: Moved most of the code generation here.
27035 2001-10-09 Ravi Pratap <ravi@ximian.com>
27037 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
27040 (ElementAccess): Remove useless bits for now - keep checks as the spec
27043 2001-10-08 Ravi Pratap <ravi@ximian.com>
27045 * expression.cs (ElementAccess::DoResolve): Remove my crap code
27046 and start performing checks according to the spec.
27048 2001-10-07 Ravi Pratap <ravi@ximian.com>
27050 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
27051 rank_specifiers instead.
27053 (rank_specifiers): Change the order in which the rank specifiers are stored
27055 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
27057 * expression.cs (ElementAccess): Implement the LValue interface too.
27059 2001-10-06 Ravi Pratap <ravi@ximian.com>
27061 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
27062 except that user defined conversions are not included.
27064 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
27065 perform the conversion of the return type, if necessary.
27067 (New::DoResolve): Check whether we are creating an array or an object
27068 and accordingly do the needful.
27070 (New::Emit): Same here.
27072 (New::DoResolve): Implement guts of array creation.
27074 (New::FormLookupType): Helper function.
27076 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27078 * codegen.cs: Removed most of the code generation here, and move the
27079 corresponding code generation bits to the statement classes.
27081 Added support for try/catch/finalize and throw.
27083 * cs-parser.jay: Added support for try/catch/finalize.
27085 * class.cs: Catch static methods having the flags override,
27086 virtual or abstract.
27088 * expression.cs (UserCast): This user cast was not really doing
27089 what it was supposed to do. Which is to be born in fully resolved
27090 state. Parts of the resolution were being performed at Emit time!
27094 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27096 * expression.cs: Implicity convert the result from UserCast.
27098 2001-10-05 Ravi Pratap <ravi@ximian.com>
27100 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
27101 prevented it from working correctly.
27103 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
27104 merely ConvertImplicit.
27106 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27108 * typemanager.cs: Make the LookupTypeContainer function static,
27109 and not per-instance.
27111 * class.cs: Make static FindMembers (the one that takes a Type
27114 * codegen.cs: Add EmitForeach here.
27116 * cs-parser.jay: Make foreach a toplevel object instead of the
27117 inline expansion, as we need to perform semantic analysis on it.
27119 2001-10-05 Ravi Pratap <ravi@ximian.com>
27121 * expression.cs (Expression::ImplicitUserConversion): Rename to
27122 UserDefinedConversion.
27124 (Expression::UserDefinedConversion): Take an extra argument specifying
27125 whether we look for explicit user conversions too.
27127 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
27129 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
27131 (ExplicitUserConversion): Make it a call to UserDefinedConversion
27132 with the appropriate arguments.
27134 * cs-parser.jay (cast_expression): Record location too.
27136 * expression.cs (Cast): Record location info.
27138 (Expression::ConvertExplicit): Take location argument.
27140 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
27141 to determine if we are doing explicit conversions.
27143 (UserCast::Emit): Update accordingly.
27145 (Expression::ConvertExplicit): Report an error if everything fails.
27147 * ../errors/cs0030.cs : Add.
27149 2001-10-04 Miguel de Icaza <miguel@ximian.com>
27151 * modifiers.cs: If the ABSTRACT keyword is present, also set the
27152 virtual and newslot bits.
27154 * class.cs (TypeContainer::RegisterRequiredImplementations):
27155 Record methods we need.
27157 (TypeContainer::MakeKey): Helper function to make keys for
27158 MethodBases, since the Methodbase key is useless.
27160 (TypeContainer::Populate): Call RegisterRequiredImplementations
27161 before defining the methods.
27163 Create a mapping for method_builders_to_methods ahead of time
27164 instead of inside a tight loop.
27166 (::RequireMethods): Accept an object as the data to set into the
27167 hashtable so we can report interface vs abstract method mismatch.
27169 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27171 * report.cs: Make all of it static.
27173 * rootcontext.cs: Drop object_type and value_type computations, as
27174 we have those in the TypeManager anyways.
27176 Drop report instance variable too, now it is a global.
27178 * driver.cs: Use try/catch on command line handling.
27180 Add --probe option to debug the error reporting system with a test
27183 * report.cs: Add support for exiting program when a probe
27184 condition is reached.
27186 2001-10-03 Ravi Pratap <ravi@ximian.com>
27188 * expression.cs (Binary::DoNumericPromotions): Fix the case when
27189 we do a forcible conversion regardless of type, to check if
27190 ForceConversion returns a null.
27192 (Binary::error19): Use location to report error.
27194 (Unary::error23): Use location here too.
27196 * ../errors/cs0019.cs : Check in.
27198 * ../errors/cs0023.cs : Check in.
27200 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
27201 case of a non-null MethodInfo object with a length of 0 !
27203 (Binary::ResolveOperator): Flag error if overload resolution fails to find
27204 an applicable member - according to the spec :-)
27205 Also fix logic to find members in base types.
27207 (Unary::ResolveOperator): Same here.
27209 (Unary::report23): Change name to error23 and make first argument a TypeContainer
27210 as I was getting thoroughly confused between this and error19 :-)
27212 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
27213 (::FindMostEncompassedType): Implement.
27214 (::FindMostEncompassingType): Implement.
27215 (::StandardConversionExists): Implement.
27217 (UserImplicitCast): Re-vamp. We now need info about most specific
27218 source and target types so that we can do the necessary conversions.
27220 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
27221 mathematical union with no duplicates.
27223 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27225 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
27226 in order from base classes to child classes, so that we can in
27227 child classes look up in our parent for method names and
27228 attributes (required for handling abstract, virtual, new, override
27229 constructs: we need to instrospect our base class, and if we dont
27230 populate the classes in order, the introspection might be
27231 incorrect. For example, a method could query its parent before
27232 the parent has any methods and would determine that the parent has
27233 no abstract methods (while it could have had them)).
27235 (RootContext::CreateType): Record the order in which we define the
27238 2001-10-02 Miguel de Icaza <miguel@ximian.com>
27240 * class.cs (TypeContainer::Populate): Also method definitions can
27241 fail now, keep track of this.
27243 (TypeContainer::FindMembers): Implement support for
27244 DeclaredOnly/noDeclaredOnly flag.
27246 (Constructor::Emit) Return the ConstructorBuilder.
27248 (Method::Emit) Return the MethodBuilder.
27249 Check for abstract or virtual methods to be public.
27251 * rootcontext.cs (RootContext::CreateType): Register all the
27252 abstract methods required for the class to be complete and the
27253 interface methods that must be implemented.
27255 * cs-parser.jay: Report error 501 (method requires body if it is
27256 not marked abstract or extern).
27258 * expression.cs (TypeOf::Emit): Implement.
27260 * typemanager.cs: runtime_handle_type, new global type.
27262 * class.cs (Property::Emit): Generate code for properties.
27264 2001-10-02 Ravi Pratap <ravi@ximian.com>
27266 * expression.cs (Unary::ResolveOperator): Find operators on base type
27267 too - we now conform exactly to the spec.
27269 (Binary::ResolveOperator): Same here.
27271 * class.cs (Operator::Define): Fix minor quirk in the tests.
27273 * ../errors/cs0215.cs : Added.
27275 * ../errors/cs0556.cs : Added.
27277 * ../errors/cs0555.cs : Added.
27279 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27281 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
27282 single integer which is really efficient
27284 2001-10-01 Ravi Pratap <ravi@ximian.com>
27286 * expression.cs (Expression::ImplicitUserConversion): Use location
27287 even in the case when we are examining True operators.
27289 * class.cs (Operator::Define): Perform extensive checks to conform
27290 with the rules for operator overloading in the spec.
27292 * expression.cs (Expression::ImplicitReferenceConversion): Implement
27293 some of the other conversions mentioned in the spec.
27295 * typemanager.cs (array_type): New static member for the System.Array built-in
27298 (cloneable_interface): For System.ICloneable interface.
27300 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
27301 we start resolving the tree and populating types.
27303 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
27305 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27307 * expression.cs (Expression::ExprClassFromMemberInfo,
27308 Expression::Literalize): Create literal expressions from
27309 FieldInfos which are literals.
27311 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
27312 type casts, because they were wrong. The test suite in tests
27315 (ImplicitNumericConversion): ushort to ulong requires a widening
27318 Int32 constant to long requires widening cast as well.
27320 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
27321 for integers because the type on the stack is not i4.
27323 2001-09-30 Miguel de Icaza <miguel@ximian.com>
27325 * expression.cs (report118): require location argument.
27327 * parameter.cs: Do not dereference potential null value.
27329 * class.cs: Catch methods that lack the `new' keyword when
27330 overriding a name. Report warnings when `new' is used without
27331 anything being there to override.
27333 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
27335 * class.cs: Only add constructor to hashtable if it is non-null
27336 (as now constructors can fail on define).
27338 (TypeManager, Class, Struct): Take location arguments.
27340 Catch field instance initialization in structs as errors.
27342 accepting_filter: a new filter for FindMembers that is static so
27343 that we dont create an instance per invocation.
27345 (Constructor::Define): Catch errors where a struct constructor is
27348 * cs-parser.jay: Pass location information for various new
27351 * delegate.cs (Delegate): take a location argument.
27353 * driver.cs: Do not call EmitCode if there were problesm in the
27354 Definition of the types, as many Builders wont be there.
27356 * decl.cs (Decl::Decl): Require a location argument.
27358 * cs-tokenizer.cs: Handle properly hex constants that can not fit
27359 into integers, and find the most appropiate integer for it.
27361 * literal.cs: Implement ULongLiteral.
27363 * rootcontext.cs: Provide better information about the location of
27364 failure when CreateType fails.
27366 2001-09-29 Miguel de Icaza <miguel@ximian.com>
27368 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
27371 * expression.cs (Binary::CheckShiftArguments): Add missing type
27373 (Binary::ResolveOperator): Add type to the logical and and logical
27374 or, Bitwise And/Or and Exclusive Or code paths, it was missing
27377 (Binary::DoNumericPromotions): In the case where either argument
27378 is ulong (and most signed types combined with ulong cause an
27379 error) perform implicit integer constant conversions as well.
27381 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27383 * expression.cs (UserImplicitCast): Method should always be
27385 (Invocation::BetterConversion): Simplified test for IntLiteral.
27387 (Expression::ImplicitNumericConversion): Split this routine out.
27388 Put the code that performs implicit constant integer conversions
27391 (Expression::Resolve): Become a wrapper around DoResolve so we can
27392 check eclass and type being set after resolve.
27394 (Invocation::Badness): Remove this dead function
27396 (Binary::ResolveOperator): Do not compute the expensive argumnets
27397 unless we have a union for it.
27399 (Probe::Emit): Is needs to do an isinst and then
27400 compare against null.
27402 (::CanConvert): Added Location argument. If the Location argument
27403 is null (Location.Null), then we do not report errors. This is
27404 used by the `probe' mechanism of the Explicit conversion. We do
27405 not want to generate an error for something that the user
27406 explicitly requested to be casted. But the pipeline for an
27407 explicit cast first tests for potential implicit casts.
27409 So for now, if the Location is null, it means `Probe only' to
27410 avoid adding another argument. Might have to revise this
27413 (ClassCast): New class used to type cast objects into arbitrary
27414 classes (used in Explicit Reference Conversions).
27416 Implement `as' as well.
27418 Reverted all the patches from Ravi below: they were broken:
27420 * The use of `level' as a mechanism to stop recursive
27421 invocations is wrong. That was there just to catch the
27422 bug with a strack trace but not as a way of addressing
27425 To fix the problem we have to *understand* what is going
27426 on and the interactions and come up with a plan, not
27427 just get things going.
27429 * The use of the type conversion cache that I proposed
27430 last night had an open topic: How does this work across
27431 protection domains. A user defined conversion might not
27432 be public in the location where we are applying the
27433 conversion, a different conversion might be selected
27434 (ie, private A->B (better) but public B->A (worse),
27435 inside A, A->B applies, but outside it, B->A will
27438 * On top of that (ie, even if the above is solved),
27439 conversions in a cache need to be abstract. Ie, `To
27440 convert from an Int to a Short use an OpcodeCast', not
27441 `To convert from an Int to a Short use the OpcodeCast on
27442 the variable 5' (which is what this patch was doing).
27444 2001-09-28 Ravi Pratap <ravi@ximian.com>
27446 * expression.cs (Invocation::ConversionExists): Re-write to use
27447 the conversion cache
27449 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
27450 cache all conversions done, not just user-defined ones.
27452 (Invocation::BetterConversion): The real culprit. Use ConversionExists
27453 to determine if a conversion exists instead of acutually trying to
27454 perform the conversion. It's faster too.
27456 (Expression::ConvertExplicit): Modify to use ConversionExists to check
27457 and only then attempt the implicit conversion.
27459 2001-09-28 Ravi Pratap <ravi@ximian.com>
27461 * expression.cs (ConvertImplicit): Use a cache for conversions
27462 already found. Check level of recursion and bail out if necessary.
27464 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27466 * typemanager.cs (string_concat_string_string, string_concat_object_object):
27467 Export standard methods that we expect for string operations.
27469 * statement.cs (Block::UsageWarning): Track usage of variables and
27470 report the errors for not used variables.
27472 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
27475 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27477 * codegen.cs: remove unnneded code
27479 * expression.cs: Removed BuiltinTypeAccess class
27481 Fix the order in which implicit conversions are
27484 The previous fixed dropped support for boxed conversions (adding a
27485 test to the test suite now)
27487 (UserImplicitCast::CanConvert): Remove test for source being null,
27488 that code is broken. We should not feed a null to begin with, if
27489 we do, then we should track the bug where the problem originates
27490 and not try to cover it up here.
27492 Return a resolved expression of type UserImplicitCast on success
27493 rather than true/false. Ravi: this is what I was talking about,
27494 the pattern is to use a static method as a "constructor" for
27497 Also, do not create arguments until the very last minute,
27498 otherwise we always create the arguments even for lookups that
27499 will never be performed.
27501 (UserImplicitCast::Resolve): Eliminate, objects of type
27502 UserImplicitCast are born in a fully resolved state.
27504 * typemanager.cs (InitCoreTypes): Init also value_type
27505 (System.ValueType).
27507 * expression.cs (Cast::Resolve): First resolve the child expression.
27509 (LValue): Add new method AddressOf to be used by
27512 Change the argument of Store to take an EmitContext instead of an
27513 ILGenerator, because things like FieldExpr need to be able to call
27514 their children expression to generate the instance code.
27516 (Expression::Error, Expression::Warning): Sugar functions for
27519 (Expression::MemberLookup): Accept a TypeContainer instead of a
27520 Report as the first argument.
27522 (Expression::ResolvePrimary): Killed. I still want to improve
27523 this as currently the code is just not right.
27525 (Expression::ResolveMemberAccess): Simplify, but it is still
27528 (Unary::Resolve): Catch errors in AddressOf operators.
27530 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
27531 index to a byte for the short-version, or the compiler will choose
27532 the wrong Emit call, which generates the wrong data.
27534 (ParameterReference::Emit, ::Store): same.
27536 (FieldExpr::AddressOf): Implement.
27538 * typemanager.cs: TypeManager: made public variable instead of
27541 * driver.cs: document --fatal.
27543 * report.cs (ErrorMessage, WarningMessage): new names for the old
27544 Error and Warning classes.
27546 * cs-parser.jay (member_access): Turn built-in access to types
27547 into a normal simplename
27549 2001-09-27 Ravi Pratap <ravi@ximian.com>
27551 * expression.cs (Invocation::BetterConversion): Fix to cope
27552 with q being null, since this was introducing a bug.
27554 * expression.cs (ConvertImplicit): Do built-in conversions first.
27556 2001-09-27 Ravi Pratap <ravi@ximian.com>
27558 * expression.cs (UserImplicitCast::Resolve): Fix bug.
27560 2001-09-27 Ravi Pratap <ravi@ximian.com>
27562 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
27563 I had introduced long ago (what's new ?).
27565 * expression.cs (UserImplicitCast::CanConvert): Static method to do
27566 the work of all the checking.
27567 (ConvertImplicit): Call CanConvert and only then create object if necessary.
27568 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
27570 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
27571 that is the right way.
27573 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
27574 overloading resolution. Use everywhere instead of cutting and pasting code.
27576 (Binary::ResolveOperator): Use MakeUnionSet.
27578 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
27579 we have to convert to bool types. Not complete yet.
27581 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27583 * typemanager.cs (TypeManager::CSharpName): support ushort.
27585 * expression.cs (Expression::TryImplicitIntConversion): Attempts
27586 to provide an expression that performsn an implicit constant int
27587 conversion (section 6.1.6).
27588 (Expression::ConvertImplicitRequired): Reworked to include
27589 implicit constant expression conversions.
27591 (Expression::ConvertNumericExplicit): Finished.
27593 (Invocation::Emit): If InstanceExpression is null, then it means
27594 that we perform a call on this.
27596 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27598 * expression.cs (Unary::Emit): Remove some dead code.
27599 (Probe): Implement Resolve and Emit for `is'.
27600 (Expression::ConvertImplicitRequired): Attempt to do constant
27601 expression conversions here. Maybe should be moved to
27602 ConvertImplicit, but I am not sure.
27603 (Expression::ImplicitLongConstantConversionPossible,
27604 Expression::ImplicitIntConstantConversionPossible): New functions
27605 that tell whether is it possible to apply an implicit constant
27606 expression conversion.
27608 (ConvertNumericExplicit): Started work on explicit numeric
27611 * cs-parser.jay: Update operator constants.
27613 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
27614 (Parameters::GetSignature): Hook up VerifyArgs here.
27615 (Parameters::VerifyArgs): Verifies that no two arguments have the
27618 * class.cs (Operator): Update the operator names to reflect the
27619 ones that the spec expects (as we are just stringizing the
27622 * expression.cs (Unary::ResolveOperator): Fix bug: Use
27623 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
27624 previous usage did only work for our methods.
27625 (Expression::ConvertImplicit): Handle decimal implicit numeric
27626 conversions as well.
27627 (Expression::InternalTypeConstructor): Used to invoke constructors
27628 on internal types for default promotions.
27630 (Unary::Emit): Implement special handling for the pre/post
27631 increment/decrement for overloaded operators, as they need to have
27632 the same semantics as the other operators.
27634 (Binary::ResolveOperator): ditto.
27635 (Invocation::ConversionExists): ditto.
27636 (UserImplicitCast::Resolve): ditto.
27638 2001-09-26 Ravi Pratap <ravi@ximian.com>
27640 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
27641 operator, return after emitting body. Regression tests pass again !
27643 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
27644 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
27645 (Invocation::OverloadResolve): Ditto.
27646 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
27648 * everywhere : update calls to the above methods accordingly.
27650 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27652 * assign.cs (Assign): Make it inherit from ExpressionStatement.
27654 * expression.cs (ExpressionStatement): New base class used for
27655 expressions that can appear in statements, so that we can provide
27656 an alternate path to generate expression that do not leave a value
27659 (Expression::Emit, and all the derivatives): We no longer return
27660 whether a value is left on the stack or not. Every expression
27661 after being emitted leaves a single value on the stack.
27663 * codegen.cs (EmitContext::EmitStatementExpression): Use the
27664 facilties of ExpressionStatement if possible.
27666 * cs-parser.jay: Update statement_expression.
27668 2001-09-25 Miguel de Icaza <miguel@ximian.com>
27670 * driver.cs: Change the wording of message
27672 2001-09-25 Ravi Pratap <ravi@ximian.com>
27674 * expression.cs (Binary::ResolveOperator): Had forgottten to set
27675 the type of the expression to the return type of the method if
27676 we have an overloaded operator match ! The regression tests pass again !
27677 (Unary::ResolveOperator): Ditto.
27679 * expression.cs (Invocation::ConversionExists): Correct the member lookup
27680 to find "op_Implicit", not "implicit" ;-)
27681 (UserImplicitCast): New class to take care of user-defined implicit conversions.
27682 (ConvertImplicit, ForceConversion): Take TypeContainer argument
27684 * everywhere : Correct calls to the above accordingly.
27686 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
27687 (ConvertImplicit): Do user-defined conversion if it exists.
27689 2001-09-24 Miguel de Icaza <miguel@ximian.com>
27691 * assign.cs: track location.
27692 (Resolve): Use implicit conversions on assignment.
27694 * literal.cs: Oops. Not good, Emit of short access values should
27695 pass (Bytes) or the wrong argument will be selected.
27697 * expression.cs (Unary::Emit): Emit code for -expr.
27699 (Unary::ResolveOperator): Handle `Substract' for non-constants
27700 (substract from zero from the non-constants).
27701 Deal with Doubles as well.
27703 (Expression::ConvertImplicitRequired): New routine that reports an
27704 error if no implicit conversion exists.
27706 (Invocation::OverloadResolve): Store the converted implicit
27707 expressions if we make them
27709 2001-09-24 Ravi Pratap <ravi@ximian.com>
27711 * class.cs (ConstructorInitializer): Take a Location argument.
27712 (ConstructorBaseInitializer): Same here.
27713 (ConstructorThisInitializer): Same here.
27715 * cs-parser.jay : Update all calls accordingly.
27717 * expression.cs (Unary, Binary, New): Take location argument.
27718 Update accordingly everywhere.
27720 * cs-parser.jay : Update all calls to the above to take a location
27723 * class.cs : Ditto.
27725 2001-09-24 Ravi Pratap <ravi@ximian.com>
27727 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
27728 (Invocation::BetterConversion): Same here
27729 (Invocation::ConversionExists): Ditto.
27731 (Invocation::ConversionExists): Implement.
27733 2001-09-22 Ravi Pratap <ravi@ximian.com>
27735 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
27736 Also take an additional TypeContainer argument.
27738 * All over : Pass in TypeContainer as argument to OverloadResolve.
27740 * typemanager.cs (CSharpName): Update to check for the string type and return
27743 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
27746 2001-09-21 Ravi Pratap <ravi@ximian.com>
27748 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
27749 (Invocation::BetterFunction): Implement.
27750 (Invocation::BetterConversion): Implement.
27751 (Invocation::ConversionExists): Skeleton, no implementation yet.
27753 Okay, things work fine !
27755 2001-09-21 Miguel de Icaza <miguel@ximian.com>
27757 * typemanager.cs: declare and load enum_type, delegate_type and
27760 * expression.cs (Expression::Emit): Now emit returns a value that
27761 tells whether a value is left on the stack or not. This strategy
27762 might be reveted tomorrow with a mechanism that would address
27763 multiple assignments.
27764 (Expression::report118): Utility routine to report mismatches on
27767 (Unary::Report23): Report impossible type/operator combination
27770 (Unary::IsIncrementableNumber): Whether the type can be
27771 incremented or decremented with add.
27772 (Unary::ResolveOperator): Also allow enumerations to be bitwise
27774 (Unary::ResolveOperator): Implement ++, !, ~,
27776 (Invocation::Emit): Deal with new Emit convetion.
27778 * All Expression derivatives: Updated their Emit method to return
27779 whether they leave values on the stack or not.
27781 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
27782 stack for expressions that are statements.
27784 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27786 * expression.cs (LValue): New interface. Must be implemented by
27788 (LocalVariableReference, ParameterReference, FieldExpr): Implement
27791 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
27792 interface for generating code, simplifies the code.
27794 2001-09-20 Ravi Pratap <ravi@ximian.com>
27796 * expression.cs (everywhere): Comment out return statements in ::Resolve
27797 methods to avoid the warnings.
27799 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27801 * driver.cs (parse): Report error 2001 if we can not open the
27804 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
27807 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
27810 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
27811 otherwise nested blocks end up with the same index.
27813 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
27815 * expression.cs: Instead of having FIXMEs in the Resolve
27816 functions, throw exceptions so it is obvious that we are facing a
27819 * cs-parser.jay (invocation_expression): Pass Location information.
27821 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
27822 Use a basename for those routines because .NET does not like paths
27825 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
27828 2001-09-19 Miguel de Icaza <miguel@ximian.com>
27830 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
27831 are loading the correct data types (throws an exception if not).
27832 (TypeManager::InitCoreTypes): Use CoreLookupType
27834 * expression.cs (Unary::ResolveOperator): return the child
27835 expression for expressions which are just +expr.
27836 (Unary::ResolveOperator): Return negative literals for -LITERAL
27837 expressions (otherwise they are Unary {Literal}).
27838 (Invocation::Badness): Take into account `Implicit constant
27839 expression conversions'.
27841 * literal.cs (LongLiteral): Implement long literal class.
27842 (IntLiteral): export the `Value' of the intliteral.
27844 2001-09-19 Ravi Pratap <ravi@ximian.com>
27846 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
27848 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
27849 instead of 'Operator'
27851 * expression.cs (Binary::ResolveOperator): Update accordingly.
27852 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
27855 * cs-parser.jay (unary_expression): Update to use the new names.
27857 * gen-treedump.cs (GetUnary): Same here.
27859 * expression.cs (Unary::Resolve): Implement.
27860 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
27861 operators are found instead of making noise ;-)
27862 (Unary::ResolveOperator): New method to do precisely the same thing which
27863 Binary::ResolveOperator does for Binary expressions.
27864 (Unary.method, .Arguments): Add.
27865 (Unary::OperName): Implement.
27866 (Unary::ForceConversion): Copy and Paste !
27868 * class.cs (Operator::Define): Fix a small bug for the case when we have
27871 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
27872 for the inbuilt operators. Only overloading works for now ;-)
27874 2001-09-18 Miguel de Icaza <miguel@ximian.com>
27876 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
27877 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
27879 * expression.cs (This::Emit): Implement.
27880 (This::Resolve): Implement.
27881 (TypeOf:Resolve): Implement.
27882 (Expression::ResolveSimpleName): Add an implicit this to instance
27884 (MemberAccess::Resolve): Deal with Parameters and Fields.
27885 Bind instance variable to Field expressions.
27886 (FieldExpr::Instance): New field used to track the expression that
27887 represents the object instance.
27888 (FieldExpr::Resolve): Track potential errors from MemberLookup not
27890 (FieldExpr::Emit): Implement.
27892 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
27893 the last instruction contains a return opcode to avoid generating
27894 the last `ret' instruction (this generates correct code, and it is
27895 nice to pass the peverify output).
27897 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
27898 initializer for static and instance variables.
27899 (Constructor::Emit): Allow initializer to be null in the case of
27900 static constructors. Only emit initializer for instance
27903 (TypeContainer::FindMembers): Return a null array if there are no
27906 Also fix the code for the MemberTypes.Method branch, as it was not
27907 scanning that for operators (or tried to access null variables before).
27909 * assign.cs (Assign::Emit): Handle instance and static fields.
27913 * driver.cs: Stop compilation if there are parse errors.
27915 * cs-parser.jay (constructor_declaration): Provide default base
27916 initializer for non-static constructors.
27917 (constructor_declarator): Do not provide a default base
27918 initializers if none was specified.
27919 Catch the fact that constructors should not have parameters.
27921 * class.cs: Do not emit parent class initializers for static
27922 constructors, that should be flagged as an error.
27924 2001-09-18 Ravi Pratap <ravi@ximian.com>
27926 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
27927 Move back code into TypeContainer::Populate.
27929 2001-09-18 Ravi Pratap <ravi@ximian.com>
27931 * class.cs (TypeContainer::AddConstructor): Fix the check to
27932 compare against Name, not Basename.
27933 (Operator::OpType): Change Plus and Minus to Add and Subtract.
27935 * cs-parser.jay : Update accordingly.
27937 * class.cs (TypeContainer::FindMembers): For the case where we are searching
27938 for methods, don't forget to look into the operators too.
27939 (RegisterMethodBuilder): Helper method to take care of this for
27940 methods, constructors and operators.
27941 (Operator::Define): Completely revamp.
27942 (Operator.OperatorMethod, MethodName): New fields.
27943 (TypeContainer::Populate): Move the registering of builders into
27944 RegisterMethodBuilder.
27945 (Operator::Emit): Re-write.
27947 * expression.cs (Binary::Emit): Comment out code path to emit method
27948 invocation stuff for the case when we have a user defined operator. I am
27949 just not able to get it right !
27951 2001-09-17 Miguel de Icaza <miguel@ximian.com>
27953 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
27956 (Expression::MemberLookup): Provide a version that allows to
27957 specify the MemberTypes and BindingFlags.
27959 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
27960 so it was not fetching variable information from outer blocks.
27962 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
27963 Beforefieldinit as it was buggy.
27965 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
27966 that Ravi put here.
27968 * class.cs (Constructor::Emit): Only emit if block is not null.
27969 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
27970 deal with this by semantically definining it as if the user had
27973 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
27974 constructors as we now "emit" them at a higher level.
27976 (TypeContainer::DefineDefaultConstructor): Used to define the
27977 default constructors if none was provided.
27979 (ConstructorInitializer): Add methods Resolve and Emit.
27981 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
27983 2001-09-17 Ravi Pratap <ravi@ximian.com>
27985 * class.cs (TypeContainer::EmitDefaultConstructor): Register
27986 the default constructor builder with our hashtable for methodbuilders
27989 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
27990 and argument_count is 0 in which case we have a match.
27991 (Binary::ResolveOperator): More null checking and miscellaneous coding
27994 2001-09-17 Ravi Pratap <ravi@ximian.com>
27996 * rootcontext.cs (IsNameSpace): Compare against null.
27998 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
28000 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
28001 and Unary::Operator.
28003 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
28006 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
28007 we have overloaded operators.
28008 (Binary::ResolveOperator): Implement the part which does the operator overload
28011 * class.cs (Operator::Emit): Implement.
28012 (TypeContainer::Emit): Emit the operators we have too.
28014 * expression.cs (Binary::Emit): Update to emit the appropriate code for
28015 the case when we have a user-defined operator.
28017 2001-09-17 Miguel de Icaza <miguel@ximian.com>
28019 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
28021 2001-09-16 Ravi Pratap <ravi@ximian.com>
28023 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
28024 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
28025 (Constructor::Emit): Implement.
28026 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
28027 if we have no work to do.
28028 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
28031 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
28032 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
28034 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
28037 2001-09-15 Ravi Pratap <ravi@ximian.com>
28039 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
28041 (Tree::RecordNamespace): Method to do what the name says ;-)
28042 (Tree::Namespaces): Property to get at the namespaces hashtable.
28044 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
28047 * rootcontext.cs (IsNamespace): Fixed it :-)
28049 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28051 * class.cs (TypeContainer::FindMembers): Add support for
28053 (MethodCore): New class that encapsulates both the shared aspects
28054 of a Constructor and a Method.
28055 (Method, Constructor): Factored pieces into MethodCore.
28057 * driver.cs: Added --fatal which makes errors throw exceptions.
28058 Load System assembly as well as part of the standard library.
28060 * report.cs: Allow throwing exceptions on errors for debugging.
28062 * modifiers.cs: Do not use `parent', instead use the real type
28063 container to evaluate permission settings.
28065 * class.cs: Put Ravi's patch back in. He is right, and we will
28066 have to cope with the
28068 2001-09-14 Ravi Pratap <ravi@ximian.com>
28070 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
28071 FamORAssem, not FamANDAssem.
28073 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28075 * driver.cs: Added --parse option that only parses its input files
28078 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
28079 incorrect. IsTopLevel is not used to tell whether an object is
28080 root_types or not (that can be achieved by testing this ==
28081 root_types). But to see if this is a top-level *class* (not
28082 necessarly our "toplevel" container).
28084 2001-09-14 Ravi Pratap <ravi@ximian.com>
28086 * enum.cs (Enum::Define): Modify to call the Lookup method on the
28087 parent instead of a direct call to GetType.
28089 2001-09-14 Ravi Pratap <ravi@ximian.com>
28091 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
28092 Modifiers.TypeAttr. This should just be a call to that method.
28094 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
28095 object so that we can determine if we are top-level or not.
28097 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
28100 * enum.cs (Enum::Define): Ditto.
28102 * modifiers.cs (FieldAttr): Re-write.
28104 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
28105 (TypeContainer::HaveStaticConstructor): New property to provide access
28106 to precisely that info.
28108 * modifiers.cs (MethodAttr): Re-write.
28109 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
28111 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
28112 of top-level types as claimed.
28114 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28116 * expression.cs (MemberLookup): Fruitless attempt to lookup
28117 constructors. Maybe I need to emit default constructors? That
28118 might be it (currently .NET emits this for me automatically).
28119 (Invocation::OverloadResolve): Cope with Arguments == null.
28120 (Invocation::EmitArguments): new function, shared by the new
28121 constructor and us.
28122 (Invocation::Emit): Handle static and instance methods. Emit
28123 proper call instruction for virtual or non-virtual invocations.
28124 (New::Emit): Implement.
28125 (New::Resolve): Implement.
28126 (MemberAccess:Resolve): Implement.
28127 (MethodGroupExpr::InstanceExpression): used conforming to the spec
28128 to track instances.
28129 (FieldExpr::Resolve): Set type.
28131 * support.cs: Handle empty arguments.
28133 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
28134 SimpleLookup): Auxiliary routines to help parse a qualifier
28137 Update qualifier_identifier rule.
28139 * codegen.cs: Removed debugging messages.
28141 * class.cs: Make this a global thing, this acts just as a "key" to
28142 objects that we might have around.
28144 (Populate): Only initialize method_builders_to_methods once.
28146 * expression.cs (PropertyExpr): Initialize type from the
28149 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
28150 Resolve pattern. Attempt to implicitly convert value to boolean.
28153 * expression.cs: Set the type for the int32/int32 argument case.
28154 (Binary::ResolveOperator): Set the return type to boolean for
28155 comparission operators
28157 * typemanager.cs: Remove debugging print code.
28159 (Invocation::Resolve): resolve type.
28161 * class.cs: Allocate a MemberInfo of the correct size, as the code
28162 elsewhere depends on the test to reflect the correct contents.
28164 (Method::) Keep track of parameters, due to System.Reflection holes
28166 (TypeContainer::Populate): Keep track of MethodBuilders to Method
28169 (TypeContainer::FindMembers): Use ArrayList and then copy an array
28170 of the exact size and return that.
28172 (Class::LookupMethodByBuilder): New function that maps
28173 MethodBuilders to its methods. Required to locate the information
28174 on methods because System.Reflection bit us again.
28176 * support.cs: New file, contains an interface ParameterData and
28177 two implementations: ReflectionParameters and InternalParameters
28178 used to access Parameter information. We will need to grow this
28181 * expression.cs (Invocation::GetParameterData): implement a cache
28182 and a wrapper around the ParameterData creation for methods.
28183 (Invocation::OverloadResolve): Use new code.
28185 2001-09-13 Ravi Pratap <ravi@ximian.com>
28187 * class.cs (TypeContainer::EmitField): Remove and move into
28188 (Field::Define): here and modify accordingly.
28189 (Field.FieldBuilder): New member.
28190 (TypeContainer::Populate): Update accordingly.
28191 (TypeContainer::FindMembers): Implement.
28193 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28195 * statement.cs: (VariableInfo::VariableType): New field to be
28196 initialized with the full type once it is resolved.
28198 2001-09-12 Miguel de Icaza <miguel@ximian.com>
28200 * parameter.cs (GetParameterInfo): Use a type cache to compute
28201 things only once, and to reuse this information
28203 * expression.cs (LocalVariableReference::Emit): Implement.
28204 (OpcodeCast::Emit): fix.
28206 (ParameterReference::Resolve): Implement.
28207 (ParameterReference::Emit): Implement.
28209 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
28210 that are expressions need to stay as Expressions.
28212 * typemanager.cs (CSharpName): Returns the C# name of a type if
28215 * expression.cs (Expression::ConvertImplicit): New function that
28216 implements implicit type conversions.
28218 (Expression::ImplicitReferenceConversion): Implements implicit
28219 reference conversions.
28221 (EmptyCast): New type for transparent casts.
28223 (OpcodeCast): New type for casts of types that are performed with
28224 a sequence of bytecodes.
28226 (BoxedCast): New type used for casting value types into reference
28227 types. Emits a box opcode.
28229 (Binary::DoNumericPromotions): Implements numeric promotions of
28230 and computation of the Binary::Type.
28232 (Binary::EmitBranchable): Optimization.
28234 (Binary::Emit): Implement code emission for expressions.
28236 * typemanager.cs (TypeManager): Added two new core types: sbyte
28239 2001-09-12 Ravi Pratap <ravi@ximian.com>
28241 * class.cs (TypeContainer::FindMembers): Method which does exactly
28242 what Type.FindMembers does, only we don't have to use reflection. No
28243 implementation yet.
28245 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
28246 typecontainer objects as we need to get at them.
28247 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
28249 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
28250 typecontainer object.
28252 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
28253 of just a Report object.
28255 2001-09-11 Ravi Pratap <ravi@ximian.com>
28257 * class.cs (Event::Define): Go back to using the prefixes "add_" and
28259 (TypeContainer::Populate): Now define the delegates of the type too.
28260 (TypeContainer.Delegates): Property to access the list of delegates defined
28263 * delegates.cs (Delegate::Define): Implement partially.
28265 * modifiers.cs (TypeAttr): Handle more flags.
28267 2001-09-11 Ravi Pratap <ravi@ximian.com>
28269 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
28271 (Operator::Define): Re-write logic to get types by using the LookupType method
28272 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
28273 (Indexer::Define): Ditto.
28274 (Event::Define): Ditto.
28275 (Property::Define): Ditto.
28277 2001-09-10 Ravi Pratap <ravi@ximian.com>
28279 * class.cs (TypeContainer::Populate): Now define operators too.
28280 (TypeContainer.Operators): New property to access the list of operators
28282 (Operator.OperatorMethodBuilder): New member to hold the method builder
28283 for the operator we are defining.
28284 (Operator::Define): Implement.
28286 2001-09-10 Ravi Pratap <ravi@ximian.com>
28288 * class.cs (Event::Define): Make the prefixes of the accessor methods
28289 addOn_ and removeOn_
28291 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
28292 of the location being passed in too. Ideally, this should go later since all
28293 error reporting should be done through the Report object.
28295 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
28296 (Populate): Iterate thru the indexers we have and define them too.
28297 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
28298 for the get and set accessors.
28299 (Indexer::Define): Implement.
28301 2001-09-09 Miguel de Icaza <miguel@ximian.com>
28303 * expression.cs (Binary::Resolve): Beginning of it. I scratched
28304 my previous implementation, did not work.
28306 * typemanager.cs: Add a couple of missing types (the longs).
28308 * literal.cs: Use TypeManager.bool_type instead of getting it.
28310 * expression.cs (EventExpr): New kind of expressions.
28311 (Expressio::ExprClassFromMemberInfo): finish
28313 2001-09-08 Miguel de Icaza <miguel@ximian.com>
28315 * assign.cs: Emit stores to static fields differently.
28317 2001-09-08 Ravi Pratap <ravi@ximian.com>
28319 * Merge in changes and adjust code to tackle conflicts. Backed out my
28320 code in Assign::Resolve ;-)
28322 2001-09-08 Ravi Pratap <ravi@ximian.com>
28324 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
28325 instead Report.Error and also pass in the location.
28326 (CSharpParser::Lexer): New readonly property to return the reference
28327 to the Tokenizer object.
28328 (declare_local_variables): Use Report.Error with location instead of plain
28332 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
28333 (Operator.CheckBinaryOperator): Ditto.
28335 * cs-parser.jay (operator_declarator): Update accordingly.
28337 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
28338 (CheckBinaryOperator): Same here.
28340 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
28341 on the name without any prefixes of namespace names etc. This is because we
28342 already might have something already fully qualified like
28343 'System.Console.WriteLine'
28345 * assign.cs (Resolve): Begin implementation. Stuck ;-)
28347 2001-09-07 Ravi Pratap <ravi@ximian.com>
28349 * cs-tokenizer.cs (location): Return a string which also contains
28352 * expression.cs (ElementAccess): New class for expressions of the
28353 type 'element access.'
28354 (BaseAccess): New class for expressions of the type 'base access.'
28355 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
28358 * cs-parser.jay (element_access): Implement action.
28359 (base_access): Implement actions.
28360 (checked_expression, unchecked_expression): Implement.
28362 * cs-parser.jay (local_variable_type): Correct and implement.
28363 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
28365 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
28367 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
28368 name and the specifiers.
28370 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
28372 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
28373 making them all public ;-)
28375 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
28378 2001-09-07 Miguel de Icaza <miguel@ximian.com>
28380 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
28382 (FieldExpr, PropertyExprs): New resolved expressions.
28383 (SimpleName::MemberStaticCheck): Perform static checks for access
28384 to non-static fields on static methods. Maybe this should be
28385 generalized for MemberAccesses.
28386 (SimpleName::ResolveSimpleName): More work on simple name
28389 * cs-parser.jay (primary_expression/qualified_identifier): track
28390 the parameter index.
28392 * codegen.cs (CodeGen::Save): Catch save exception, report error.
28393 (EmitContext::EmitBoolExpression): Chain to expression generation
28394 instead of temporary hack.
28395 (::EmitStatementExpression): Put generic expression code generation.
28397 * assign.cs (Assign::Emit): Implement variable assignments to
28398 local variables, parameters and fields.
28400 2001-09-06 Miguel de Icaza <miguel@ximian.com>
28402 * statement.cs (Block::GetVariableInfo): New method, returns the
28403 VariableInfo for a variable name in a block.
28404 (Block::GetVariableType): Implement in terms of GetVariableInfo
28406 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
28407 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
28409 2001-09-06 Ravi Pratap <ravi@ximian.com>
28411 * cs-parser.jay (operator_declaration): Continue on my quest : update
28412 to take attributes argument.
28413 (event_declaration): Ditto.
28414 (enum_declaration): Ditto.
28415 (indexer_declaration): Ditto.
28417 * class.cs (Operator::Operator): Update constructor accordingly.
28418 (Event::Event): Ditto.
28420 * delegate.cs (Delegate::Delegate): Same here.
28422 * enum.cs (Enum::Enum): Same here.
28424 2001-09-05 Ravi Pratap <ravi@ximian.com>
28426 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
28428 * ../tests/cs0658.cs : New file to demonstrate error 0658.
28430 * attribute.cs (Attributes): New class to encapsulate all attributes which were
28431 being passed around as an arraylist.
28432 (Attributes::AddAttribute): Method to add attribute sections.
28434 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
28435 (struct_declaration): Update accordingly.
28436 (constant_declaration): Update.
28437 (field_declaration): Update.
28438 (method_header): Update.
28439 (fixed_parameter): Update.
28440 (parameter_array): Ditto.
28441 (property_declaration): Ditto.
28442 (destructor_declaration): Ditto.
28444 * class.cs (Struct::Struct): Update constructors accordingly.
28445 (Class::Class): Ditto.
28446 (Field::Field): Ditto.
28447 (Method::Method): Ditto.
28448 (Property::Property): Ditto.
28449 (TypeContainer::OptAttribute): update property's return type.
28451 * interface.cs (Interface.opt_attributes): New member.
28452 (Interface::Interface): Update to take the extra Attributes argument.
28454 * parameter.cs (Parameter::Parameter): Ditto.
28456 * constant.cs (Constant::Constant): Ditto.
28458 * interface.cs (InterfaceMemberBase): New OptAttributes field.
28459 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
28460 the attributes as a parameter.
28461 (InterfaceProperty): Update constructor call.
28462 (InterfaceEvent): Ditto.
28463 (InterfaceMethod): Ditto.
28464 (InterfaceIndexer): Ditto.
28466 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
28467 pass the attributes too.
28468 (interface_event_declaration): Ditto.
28469 (interface_property_declaration): Ditto.
28470 (interface_method_declaration): Ditto.
28471 (interface_declaration): Ditto.
28473 2001-09-05 Miguel de Icaza <miguel@ximian.com>
28475 * class.cs (Method::Define): Track the "static Main" definition to
28476 create an entry point.
28478 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
28479 EntryPoint if we find it.
28481 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
28482 (EmitContext::ig): Make this variable public.
28484 * driver.cs: Make the default output file be the first file name
28485 with the .exe extension.
28487 Detect empty compilations
28489 Handle various kinds of output targets. Handle --target and
28490 rename -t to --dumper.
28492 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
28493 methods inherited from Expression return now an Expression. This
28494 will is used during the tree rewriting as we resolve them during
28497 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
28498 the spec. Missing entirely is the information about
28499 accessability of elements of it.
28501 (Expression::ExprClassFromMemberInfo): New constructor for
28502 Expressions that creates a fully initialized Expression based on
28503 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
28506 (Invocation::Resolve): Begin implementing resolution of invocations.
28508 * literal.cs (StringLiteral): Implement Emit.
28510 2001-09-05 Ravi Pratap <ravi@ximian.com>
28512 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
28515 2001-09-04 Ravi Pratap <ravi@ximian.com>
28517 * cs-parser.jay (attribute_arguments): Implement actions.
28518 (attribute): Fix bug in production. Implement action.
28519 (attribute_list): Implement.
28520 (attribute_target): Implement.
28521 (attribute_target_specifier, opt_target_specifier): Implement
28522 (CheckAttributeTarget): New method to check if the attribute target
28524 (attribute_section): Implement.
28525 (opt_attributes): Implement.
28527 * attribute.cs : New file to handle attributes.
28528 (Attribute): Class to hold attribute info.
28530 * cs-parser.jay (opt_attribute_target_specifier): Remove production
28531 (attribute_section): Modify production to use 2 different rules to
28532 achieve the same thing. 1 s/r conflict down !
28533 Clean out commented, useless, non-reducing dimension_separator rules.
28535 * class.cs (TypeContainer.attributes): New member to hold list
28536 of attributes for a type.
28537 (Struct::Struct): Modify to take one more argument, the attribute list.
28538 (Class::Class): Ditto.
28539 (Field::Field): Ditto.
28540 (Method::Method): Ditto.
28541 (Property::Property): Ditto.
28543 * cs-parser.jay (struct_declaration): Update constructor call to
28544 pass in the attributes too.
28545 (class_declaration): Ditto.
28546 (constant_declaration): Ditto.
28547 (field_declaration): Ditto.
28548 (method_header): Ditto.
28549 (fixed_parameter): Ditto.
28550 (parameter_array): Ditto.
28551 (property_declaration): Ditto.
28553 * constant.cs (Constant::Constant): Update constructor similarly.
28554 Use System.Collections.
28556 * parameter.cs (Parameter::Parameter): Update as above.
28558 2001-09-02 Ravi Pratap <ravi@ximian.com>
28560 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
28561 (TypeContainer.delegates): New member to hold list of delegates.
28563 * cs-parser.jay (delegate_declaration): Implement the action correctly
28564 this time as I seem to be on crack ;-)
28566 2001-09-02 Miguel de Icaza <miguel@ximian.com>
28568 * rootcontext.cs (RootContext::IsNamespace): new function, used to
28569 tell whether an identifier represents a namespace.
28571 * expression.cs (NamespaceExpr): A namespace expression, used only
28572 temporarly during expression resolution.
28573 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
28574 utility functions to resolve names on expressions.
28576 2001-09-01 Miguel de Icaza <miguel@ximian.com>
28578 * codegen.cs: Add hook for StatementExpressions.
28580 * class.cs: Fix inverted test for static flag in methods.
28582 2001-09-02 Ravi Pratap <ravi@ximian.com>
28584 * class.cs (Operator::CheckUnaryOperator): Correct error number used
28585 to make it coincide with MS' number.
28586 (Operator::CheckBinaryOperator): Ditto.
28588 * ../errors/errors.txt : Remove error numbers added earlier.
28590 * ../errors/cs1019.cs : Test case for error # 1019
28592 * ../errros/cs1020.cs : Test case for error # 1020
28594 * cs-parser.jay : Clean out commented cruft.
28595 (dimension_separators, dimension_separator): Comment out. Ostensibly not
28596 used anywhere - non-reducing rule.
28597 (namespace_declarations): Non-reducing rule - comment out.
28599 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
28600 with TypeContainer::AddEnum.
28602 * delegate.cs : New file for delegate handling classes.
28603 (Delegate): Class for declaring delegates.
28605 * makefile : Update.
28607 * cs-parser.jay (delegate_declaration): Implement.
28609 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
28611 * class.cs (Event::Define): Implement.
28612 (Event.EventBuilder): New member.
28614 * class.cs (TypeContainer::Populate): Update to define all enums and events
28616 (Events): New property for the events arraylist we hold. Shouldn't we move to using
28617 readonly fields for all these cases ?
28619 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28621 * class.cs (Property): Revamp to use the convention of making fields readonly.
28622 Accordingly modify code elsewhere.
28624 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
28625 the Define method of the Property class.
28627 * class.cs : Clean up applied patch and update references to variables etc. Fix
28629 (TypeContainer::Populate): Update to define all the properties we have. Also
28630 define all enumerations.
28632 * enum.cs (Define): Implement.
28634 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28636 * cs-parser.jay (overloadable_operator): The semantic value is an
28637 enum of the Operator class.
28638 (operator_declarator): Implement actions.
28639 (operator_declaration): Implement.
28641 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
28642 validity of definitions.
28643 (Operator::CheckBinaryOperator): Static method to check for binary operators
28644 (TypeContainer::AddOperator): New method to add an operator to a type.
28646 * cs-parser.jay (indexer_declaration): Added line to actually call the
28647 AddIndexer method so it gets added ;-)
28649 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
28650 already taken care of by the MS compiler ?
28652 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28654 * class.cs (Operator): New class for operator declarations.
28655 (Operator::OpType): Enum for the various operators.
28657 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28659 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
28660 ostensibly handle this in semantic analysis.
28662 * cs-parser.jay (general_catch_clause): Comment out
28663 (specific_catch_clauses, specific_catch_clause): Ditto.
28664 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
28665 (catch_args, opt_catch_args): New productions.
28666 (catch_clause): Rewrite to use the new productions above
28667 (catch_clauses): Modify accordingly.
28668 (opt_catch_clauses): New production to use in try_statement
28669 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
28670 and re-write the code in the actions to extract the specific and
28671 general catch clauses by being a little smart ;-)
28673 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
28674 Hooray, try and catch statements parse fine !
28676 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28678 * statement.cs (Block::GetVariableType): Fix logic to extract the type
28679 string from the hashtable of variables.
28681 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
28682 I end up making that mistake ;-)
28683 (catch_clauses): Fixed gross error which made Key and Value of the
28684 DictionaryEntry the same : $1 !!
28686 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28688 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
28690 * cs-parser.jay (event_declaration): Correct to remove the semicolon
28691 when the add and remove accessors are specified.
28693 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28695 * cs-parser.jay (IndexerDeclaration): New helper class to hold
28696 information about indexer_declarator.
28697 (indexer_declarator): Implement actions.
28698 (parsing_indexer): New local boolean used to keep track of whether
28699 we are parsing indexers or properties. This is necessary because
28700 implicit_parameters come into picture even for the get accessor in the
28701 case of an indexer.
28702 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
28704 * class.cs (Indexer): New class for indexer declarations.
28705 (TypeContainer::AddIndexer): New method to add an indexer to a type.
28706 (TypeContainer::indexers): New member to hold list of indexers for the
28709 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28711 * cs-parser.jay (add_accessor_declaration): Implement action.
28712 (remove_accessor_declaration): Implement action.
28713 (event_accessors_declaration): Implement
28714 (variable_declarators): swap statements for first rule - trivial.
28716 * class.cs (Event): New class to hold information about event
28718 (TypeContainer::AddEvent): New method to add an event to a type
28719 (TypeContainer::events): New member to hold list of events.
28721 * cs-parser.jay (event_declaration): Implement actions.
28723 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28725 * cs-parser.jay (dim_separators): Implement. Make it a string
28726 concatenating all the commas together, just as they appear.
28727 (opt_dim_separators): Modify accordingly
28728 (rank_specifiers): Update accordingly. Basically do the same
28729 thing - instead, collect the brackets here.
28730 (opt_rank_sepcifiers): Modify accordingly.
28731 (array_type): Modify to actually return the complete type string
28732 instead of ignoring the rank_specifiers.
28733 (expression_list): Implement to collect the expressions
28734 (variable_initializer): Implement. We make it a list of expressions
28735 essentially so that we can handle the array_initializer case neatly too.
28736 (variable_initializer_list): Implement.
28737 (array_initializer): Make it a list of variable_initializers
28738 (opt_array_initializer): Modify accordingly.
28740 * expression.cs (New::NType): Add enumeration to help us
28741 keep track of whether we have an object/delegate creation
28742 or an array creation.
28743 (New:NewType, New::Rank, New::Indices, New::Initializers): New
28744 members to hold data about array creation.
28745 (New:New): Modify to update NewType
28746 (New:New): New Overloaded contructor for the array creation
28749 * cs-parser.jay (array_creation_expression): Implement to call
28750 the overloaded New constructor.
28752 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
28754 * class.cs (TypeContainer::Constructors): Return member
28755 constructors instead of returning null.
28757 2001-08-26 Miguel de Icaza <miguel@ximian.com>
28759 * typemanager.cs (InitCoreTypes): Initialize the various core
28760 types after we have populated the type manager with the user
28761 defined types (this distinction will be important later while
28762 compiling corlib.dll)
28764 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
28765 on Expression Classification. Now all expressions have a method
28766 `Resolve' and a method `Emit'.
28768 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
28769 generation from working. Also add some temporary debugging
28772 2001-08-24 Miguel de Icaza <miguel@ximian.com>
28774 * codegen.cs: Lots of code generation pieces. This is only the
28775 beginning, will continue tomorrow with more touches of polish. We
28776 handle the fundamentals of if, while, do, for, return. Others are
28777 trickier and I need to start working on invocations soon.
28779 * gen-treedump.cs: Bug fix, use s.Increment here instead of
28782 * codegen.cs (EmitContext): New struct, used during code
28783 emission to keep a context. Most of the code generation will be
28786 * cs-parser.jay: Add embedded blocks to the list of statements of
28787 this block. So code generation proceeds in a top down fashion.
28789 2001-08-23 Miguel de Icaza <miguel@ximian.com>
28791 * statement.cs: Add support for multiple child blocks.
28793 2001-08-22 Miguel de Icaza <miguel@ximian.com>
28795 * codegen.cs (EmitCode): New function, will emit the code for a
28796 Block of code given a TypeContainer and its ILGenerator.
28798 * statement.cs (Block): Standard public readonly optimization.
28799 (Block::Block constructors): Link children.
28800 (Block::Child): Child Linker.
28801 (Block::EmitVariables): Emits IL variable declarations.
28803 * class.cs: Drop support for MethodGroups here, delay until
28805 (Method::): Applied the same simplification that I did before, and
28806 move from Properties to public readonly fields.
28807 (Method::ParameterTypes): Returns the parameter types for the
28808 function, and implements a cache that will be useful later when I
28809 do error checking and the semantic analysis on the methods is
28811 (Constructor::GetCallingConvention): Renamed from CallingConvetion
28812 and made a method, optional argument tells whether this is a class
28813 or a structure to apply the `has-this' bit.
28814 (Method::GetCallingConvention): Implement, returns the calling
28816 (Method::Define): Defines the type, a second pass is performed
28817 later to populate the methods.
28819 (Constructor::ParameterTypes): implement a cache similar to the
28820 one on Method::ParameterTypes, useful later when we do semantic
28823 (TypeContainer::EmitMethod): New method. Emits methods.
28825 * expression.cs: Removed MethodGroup class from here.
28827 * parameter.cs (Parameters::GetCallingConvention): new method.
28829 2001-08-21 Miguel de Icaza <miguel@ximian.com>
28831 * class.cs (TypeContainer::Populate): Drop RootContext from the
28834 (Constructor::CallingConvention): Returns the calling convention.
28835 (Constructor::ParameterTypes): Returns the constructor parameter
28838 (TypeContainer::AddConstructor): Keep track of default constructor
28839 and the default static constructor.
28841 (Constructor::) Another class that starts using `public readonly'
28842 instead of properties.
28844 (Constructor::IsDefault): Whether this is a default constructor.
28846 (Field::) use readonly public fields instead of properties also.
28848 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
28849 track of static constructors; If none is used, turn on
28850 BeforeFieldInit in the TypeAttributes.
28852 * cs-parser.jay (opt_argument_list): now the return can be null
28853 for the cases where there are no arguments.
28855 (constructor_declarator): If there is no implicit `base' or
28856 `this', then invoke the default parent constructor.
28858 * modifiers.cs (MethodAttr): New static function maps a set of
28859 modifiers flags into a MethodAttributes enum
28860 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
28861 MethodAttr, TypeAttr to represent the various mappings where the
28862 modifiers are used.
28863 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
28865 2001-08-19 Miguel de Icaza <miguel@ximian.com>
28867 * parameter.cs (GetParameterInfo): Fix bug where there would be no
28870 * interface.cs (PopulateIndexer): Implemented the code generator
28871 for interface indexers.
28873 2001-08-17 Miguel de Icaza <miguel@ximian.com>
28875 * interface.cs (InterfaceMemberBase): Now we track the new status
28878 (PopulateProperty): Implement property population. Woohoo! Got
28879 Methods and Properties going today.
28881 Removed all the properties for interfaces, and replaced them with
28882 `public readonly' fields.
28884 2001-08-16 Miguel de Icaza <miguel@ximian.com>
28886 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
28887 initialize their hashtables/arraylists only when they are needed
28888 instead of doing this always.
28890 * parameter.cs: Handle refs and out parameters.
28892 * cs-parser.jay: Use an ArrayList to construct the arguments
28893 instead of the ParameterCollection, and then cast that to a
28896 * parameter.cs: Drop the use of ParameterCollection and use
28897 instead arrays of Parameters.
28899 (GetParameterInfo): Use the Type, not the Name when resolving
28902 2001-08-13 Miguel de Icaza <miguel@ximian.com>
28904 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
28905 and instead use public readonly fields.
28907 * class.cs: Put back walking code for type containers.
28909 2001-08-11 Miguel de Icaza <miguel@ximian.com>
28911 * class.cs (MakeConstant): Code to define constants.
28913 * rootcontext.cs (LookupType): New function. Used to locate types
28916 2001-08-08 Miguel de Icaza <miguel@ximian.com>
28918 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
28919 this System.Reflection code is. Kudos to Microsoft
28921 * typemanager.cs: Implement a type cache and avoid loading all
28922 types at boot time. Wrap in LookupType the internals. This made
28923 the compiler so much faster. Wow. I rule!
28925 * driver.cs: Make sure we always load mscorlib first (for
28926 debugging purposes, nothing really important).
28928 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
28929 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
28931 * rootcontext.cs: Lookup types on their namespace; Lookup types
28932 on namespaces that have been imported using the `using' keyword.
28934 * class.cs (TypeContainer::TypeAttr): Virtualize.
28935 (Class::TypeAttr): Return attributes suitable for this bad boy.
28936 (Struct::TypeAttr): ditto.
28937 Handle nested classes.
28938 (TypeContainer::) Remove all the type visiting code, it is now
28939 replaced with the rootcontext.cs code
28941 * rootcontext.cs (GetClassBases): Added support for structs.
28943 2001-08-06 Miguel de Icaza <miguel@ximian.com>
28945 * interface.cs, statement.cs, class.cs, parameter.cs,
28946 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
28947 Drop use of TypeRefs, and use strings instead.
28949 2001-08-04 Miguel de Icaza <miguel@ximian.com>
28953 * class.cs (Struct::Struct): set the SEALED flags after
28954 checking the modifiers.
28955 (TypeContainer::TypeAttr): new property, returns the
28956 TypeAttributes for a class.
28958 * cs-parser.jay (type_list): Oops, list production was creating a
28959 new list of base types.
28961 * rootcontext.cs (StdLib): New property.
28962 (GetInterfaceTypeByName): returns an interface by type name, and
28963 encapsulates error handling here.
28964 (GetInterfaces): simplified.
28965 (ResolveTree): Encapsulated all the tree resolution here.
28966 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
28969 * driver.cs: Add support for --nostdlib, to avoid loading the
28970 default assemblies.
28971 (Main): Do not put tree resolution here.
28973 * rootcontext.cs: Beginning of the class resolution.
28975 2001-08-03 Miguel de Icaza <miguel@ximian.com>
28977 * rootcontext.cs: Provide better error reporting.
28979 * cs-parser.jay (interface_base): set our $$ to be interfaces.
28981 * rootcontext.cs (CreateInterface): Handle the case where there
28982 are no parent interfaces.
28984 (CloseTypes): Routine to flush types at the end.
28985 (CreateInterface): Track types.
28986 (GetInterfaces): Returns an array of Types from the list of
28987 defined interfaces.
28989 * typemanager.c (AddUserType): Mechanism to track user types (puts
28990 the type on the global type hash, and allows us to close it at the
28993 2001-08-02 Miguel de Icaza <miguel@ximian.com>
28995 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
28996 RecordInterface instead.
28998 * cs-parser.jay: Updated to reflect changes above.
29000 * decl.cs (Definition): Keep track of the TypeBuilder type that
29001 represents this type here. Not sure we will use it in the long
29002 run, but wont hurt for now.
29004 * driver.cs: Smaller changes to accomodate the new code.
29006 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
29009 * rootcontext.cs (CreateInterface): New method, used to create
29010 the System.TypeBuilder type for interfaces.
29011 (ResolveInterfaces): new entry point to resolve the interface
29013 (CodeGen): Property, used to keep track of the code generator.
29015 2001-07-26 Miguel de Icaza <miguel@ximian.com>
29017 * cs-parser.jay: Add a second production for delegate_declaration
29020 (enum_body): Put an opt_comma here instead of putting it on
29021 enum_body or enum_member_declarations so we can handle trailing
29022 commas on enumeration members. Gets rid of a shift/reduce.
29024 (type_list): Need a COMMA in the middle.
29026 (indexer_declaration): Tell tokenizer to recognize get/set
29028 * Remove old targets.
29030 * Re-add the parser target.
29032 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29034 * cs-parser.jay: Add precendence rules for a number of operators
29035 ot reduce the number of shift/reduce conflicts in the grammar.
29037 2001-07-17 Miguel de Icaza <miguel@ximian.com>
29039 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
29042 Get rid of old crufty code.
29044 * rootcontext.cs: Use this to keep track of the parsed
29045 representation and the defined types available to the program.
29047 * gen-treedump.cs: adjust for new convention.
29049 * type.cs: Split out the type manager, and the assembly builder
29052 * typemanager.cs: the type manager will live here now.
29054 * cil-codegen.cs: And the code generator here.
29056 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
29058 * makefile: Fixed up for easy making.
29060 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29062 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
29065 (unary_expression): Expand pre_increment_expression and
29066 post_decrement_expression to reduce a shift/reduce.
29068 2001-07-11 Simon Cozens
29070 * cs-tokenizer.cs: Hex numbers should begin with a 0.
29072 Improve allow_keyword_as_indent name.
29074 2001-06-19 Miguel de Icaza <miguel@ximian.com>
29076 * Adjustments for Beta2.
29078 2001-06-13 Miguel de Icaza <miguel@ximian.com>
29080 * decl.cs: Added `Define' abstract method.
29081 (InTransit): new property, used to catch recursive definitions.
29083 * interface.cs: Implement `Define'.
29085 * modifiers.cs: Map Modifiers.constants to
29086 System.Reflection.TypeAttribute flags.
29088 * class.cs: Keep track of types and user-defined types.
29089 (BuilderInit): New method for creating an assembly
29090 (ResolveType): New function to launch the resolution process, only
29091 used by interfaces for now.
29093 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
29094 that are inserted into the name space.
29096 2001-06-08 Miguel de Icaza <miguel@ximian.com>
29098 * ARGH. I have screwed up my tree so many times due to the use of
29099 rsync rather than using CVS. Going to fix this at once.
29101 * driver.cs: Objetify driver. Load assemblies, use assemblies to
29104 2001-06-07 Miguel de Icaza <miguel@ximian.com>
29106 * Experiment successful: Use System.Type rather that our own
29109 2001-05-25 Miguel de Icaza <miguel@ximian.com>
29111 * cs-parser.jay: Removed nsAliases from here.
29113 Use new namespaces, handle `using XXX;'
29115 * namespace.cs: Reimplemented namespace handling, use a recursive
29116 definition of the class. Now we can keep track of using clauses
29117 and catch invalid using clauses.
29119 2001-05-24 Miguel de Icaza <miguel@ximian.com>
29121 * gen-treedump.cs: Adapted for all the renaming.
29123 * expression.cs (Expression): this class now has a Type property
29124 which returns an expression Type.
29126 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
29127 `Type', as this has a different meaning now in the base
29129 2001-05-22 Miguel de Icaza <miguel@ximian.com>
29131 * interface.cs, class.cs: Removed from all the sources the
29132 references to signature computation, as we can not do method
29133 signature computation during the parsing time, as we are not
29134 trying to solve at that point distinguishing:
29138 void a (NS.Blah x) {}
29141 Which depending on the context might be valid or not, as we do not
29142 know if Blah is the same thing as NS.Blah at that point.
29144 * Redid everything so the code uses TypeRefs now instead of
29145 Types. TypeRefs are just temporary type placeholders, that need
29146 to be resolved. They initially have a pointer to a string and the
29147 current scope in which they are used. This is used later by the
29148 compiler to resolve the reference to an actual Type.
29150 * DeclSpace is no longer a CIR.Type, and neither are
29151 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
29152 are all DeclSpaces, but no Types.
29154 * type.cs (TypeRefManager): This implements the TypeRef manager,
29155 which keeps track of all the types that need to be resolved after
29156 the parsing has finished.
29158 2001-05-13 Miguel de Icaza <miguel@ximian.com>
29160 * ARGH. We are going to have to store `foreach' as a class rather
29161 than resolving it, as we need to verify error 1579 after name
29162 resolution. *OR* we could keep a flag that says `This request to
29163 IEnumerator comes from a foreach statement' which we can then use
29164 to generate the error.
29166 2001-05-10 Miguel de Icaza <miguel@ximian.com>
29168 * class.cs (TypeContainer.AddMethod): we now add methods to the
29169 MethodGroup instead of the method hashtable.
29171 * expression.cs: Add MethodGroup abstraction, which gets us one
29172 step closer to the specification in the way we handle method
29175 * cs-parser.jay (primary_expression): qualified_identifier now
29176 tried to match up an identifier to a local variable reference or
29177 to a parameter reference.
29179 current_local_parameters is now a parser global variable that
29180 points to the current parameters for the block, used during name
29183 (property_declaration): Now creates an implicit `value' argument to
29186 2001-05-09 Miguel de Icaza <miguel@ximian.com>
29188 * parameter.cs: Do not use `param' arguments as part of the
29189 signature, per the spec.
29191 2001-05-08 Miguel de Icaza <miguel@ximian.com>
29193 * decl.cs: Base class for classes, structs and interfaces. This
29194 is the "Declaration Space"
29196 * cs-parser.jay: Use CheckDef for checking declaration errors
29197 instead of having one on each function.
29199 * class.cs: Factor out some code for handling error handling in
29200 accordance to the "Declarations" section in the "Basic Concepts"
29201 chapter in the ECMA C# spec.
29203 * interface.cs: Make all interface member classes derive from
29204 InterfaceMemberBase.
29206 2001-05-07 Miguel de Icaza <miguel@ximian.com>
29208 * Many things: all interfaces are parsed and generated in
29209 gen-treedump. Support for member variables, constructors,
29210 destructors, properties, constants is there.
29212 Beginning of the IL backend, but very little done, just there for
29215 2001-04-29 Miguel de Icaza <miguel@ximian.com>
29217 * cs-parser.jay: Fix labeled statement.
29219 * cs-tokenizer.cs (escape): Escape " and ' always.
29220 ref_line, ref_name: keep track of the line/filename as instructed
29221 by #line by the compiler.
29224 2001-04-27 Miguel de Icaza <miguel@ximian.com>
29226 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
29227 to match the values in System.CodeDOM.
29229 Divid renamed to Divide.
29231 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
29233 (Statements.set): remove.
29235 * System.CodeDOM/CodeCatchClause.cs: always have a valid
29238 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
29239 falseStatements always have valid values.
29241 * cs-parser.jay: Use System.CodeDOM now.