1 2004-12-14 Marek Safar <marek.safar@seznam.cz>
3 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
6 * class.cs: Changed warning level for 169 to avoid developer
7 displeasure from warning flooding. It will be changed back when they
8 fix most of current BCL warnings.
10 * RootContext.cs: Pushed default WarningLevel to 3.
12 * statement.cs: Removed unused variable.
14 2004-12-14 Marek Safar <marek.safar@seznam.cz>
16 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
17 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
19 (StaticClass.DefineType): Add error 441 report.
20 (Class.AllowedModifiersProp): New virtual property as temporary
21 extension to AllowedModifiers.
22 (Class.DefineType): Add error 418 report. Moved ModFlags check here
23 to share implementation with StaticClass and don't call virtual
26 * driver.cs (MainDriver): Add error 1558 test.
28 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
29 report. Moved error 36 test here.
31 * statement.cs (Throw.Resolve): Add error 724 report.
33 * typemanager.cs: Add out_attribute_type core type.
35 2004-12-13 Marek Safar <marek.safar@seznam.cz>
37 * class.cs (TypeContainer.VerifyClsCompliance): Add error
39 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
41 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
44 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
46 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
47 Add error 3023 report.
48 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
50 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
53 2004-12-12 John Luke <john.luke@gmail.com>
55 * driver.cs (AddArgs): take -- into account when
56 adding arguments, fixes bug 65710
58 2004-12-12 Martin Baulig <martin@ximian.com>
60 * expression.cs (Unary.TryReduceNegative): Added support for
61 SByteConstant and ByteConstant.
62 (Unary.Reduce): Check error values from TryReduceNegative().
64 2004-12-10 Marek Safar <marek.safar@seznam.cz>
66 * attributes.cs (Attribute.Resolve): Avoid multiple error report
67 and report exception as error 182.
69 2004-12-10 Raja R Harinath <rharinath@novell.com>
71 * driver.cs (Main): Fix message when there are warnings.
73 2004-12-09 Miguel de Icaza <miguel@ximian.com>
75 * delegate.cs: Fixed my fix from yesterday, sorry about that.
77 2004-12-09 Marek Safar <marek.safar@seznam.cz>
79 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
80 Reduced number of warnings.
82 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
84 2004-12-08 Miguel de Icaza <miguel@ximian.com>
86 * driver.cs: Removed message.
88 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
90 2004-12-08 <vargaz@freemail.hu>
92 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
94 2004-12-08 Martin Baulig <martin@ximian.com>
96 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
97 instead of a CS3002 for properties and indexer.
99 2004-12-08 Martin Baulig <martin@ximian.com>
101 * decl.cs (MemberName.ToString): Make this work again.
103 2004-12-08 Marek Safar <marek.safar@seznam.cz>
105 * attribute.cs (Resolve): Add error 591 detection.
107 * class.cs (FieldMember.Define): Add error 1547 detection.
108 (Indexer.Define): Add error 620 detection.
109 (Operator.Define): Add error 590 detection.
111 * ecore.cs: Missing argument for error 79.
113 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
116 2004-12-07 Marek Safar <marek.safar@seznam.cz>
119 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
122 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
124 * cs-parser.jay : handle doc comments on implicit/explicit operators.
125 Some operator comments were suppressed.
126 * doc.cs : Implicit/explicit operator name in doc comments are like
127 "op_Explicit(type)~returnType", so added suffix handling.
129 2004-12-07 Martin Baulig <martin@ximian.com>
132 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
133 (MemberCore.GetClsCompliantAttributeValue): Likewise.
134 (DeclSpace.ec): New protected field; store the EmitContext here.
135 (DeclSpace.EmitContext): New public property; moved here from
137 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
140 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
141 (Enum.Emit): Don't create a new EmitContext.
143 * delegate.cs (Delegate.DefineType): Always create the
146 * iterators.cs (Iterators.DefineIterator): Create a new
147 EmitContext and store it in `ec'.
149 2004-08-24 Martin Baulig <martin@ximian.com>
152 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
153 this for accessibility checks.
154 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
155 IsNestedFamilyAccessible.
156 (TypeManager.IsSubclassOf): New method, do what the name actually
159 2004-12-06 Raja R Harinath <rharinath@novell.com>
161 Fix crash on cs0657-17.cs.
162 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
163 Use RootContext.Tree.Types, not 'new RootTypes ()'.
164 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
165 the case where the NamespaceEntry gets overwritten.
167 2004-12-06 Marek Safar <marek.safar@seznam.cz>
170 * ecore.cs (ResolveBoolean): Tiny refactoring.
172 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
173 of right expression resolving when left is false constant and
174 operator is LogicalAnd OR true constant and operator is LogicalOr.
176 * statement.cs (ResolveUnreachable): Always reports warning.
178 2004-12-05 Miguel de Icaza <miguel@ximian.com>
180 * class.cs: Distinguish between 1721 and 1722 (just a little help
183 2004-12-03 Miguel de Icaza <miguel@ximian.com>
185 * delegate.cs: Only allow this on new versions of the language.
187 2004-12-02 Duncan Mak <duncan@ximian.com>
189 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
191 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
192 here as a static method. Take an additional bool out parameter
193 `must_do_cs1540_check' for signaling to InstanceResolve.
194 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
195 member field from PropertyExpr class and made it an argument of
197 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
198 check for MarshalByRefObject, and report CS0122 instead of CS1540.
199 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
200 and `remove_accessor' as well as InstanceResolve: report CS0122
205 2004-12-03 Raja R Harinath <rharinath@novell.com>
207 Fix test-327.cs, test-328.cs, and put in early infrastructure
208 for eventually fixing #52697.
209 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
210 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
212 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
213 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
214 (VerifyUsing, error246): Update.
215 * rootcontext.cs (RootContext.NamespaceLookup): Just use
216 'NamespaceEntry.LookupNamespaceOrType'.
218 2004-12-03 Martin Baulig <martin@ximian.com>
220 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
221 method as our child, call AnonymousMethod.Compatible() on it.
223 2004-12-03 Raja R Harinath <rharinath@novell.com>
225 Disable XML documentation support in 'basic' profile.
226 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
227 Redirect XmlElement to System.Object.
228 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
229 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
230 * mcs.exe.sources: Add doc-bootstrap.cs.
231 * doc-bootstrap.cs: New file. Contains empty stub implementation
234 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
236 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
237 comments are allowed.
239 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
241 * delegate.cs: Add checks for subtypes in paramaters and return values
242 in VerifyMethod () to add support for Covariance/Contravariance
245 2004-12-02 Miguel de Icaza <miguel@ximian.com>
247 * report.cs: Remove extra closing parenthesis.
249 * convert.cs (Error_CannotImplicitConversion): If the name of the
250 types are the same, provide some extra information.
252 * class.cs (FieldBase): Use an unused bit field from the field to
253 encode the `has_offset' property from the FieldMember. This saves
254 a couple of Ks on bootstrap compilation.
256 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
257 method as our child, return the AnonymousMethod resolved
260 * expression.cs (New.DoResolve): Allow return values from
261 NewDelegate to also include AnonymousMethods.
265 2004-12-02 Marek Safar <marek.safar@seznam.cz>
268 * attribute.cs (Resolve): Improved implementation of params
271 * support.cs (ParameterData): Add HasParams to be faster.
273 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
275 all things are for /doc support:
277 * doc.cs: new file that supports XML documentation generation.
278 * mcs.exe.sources: added doc.cs.
280 Handle /doc command line option.
281 Report error 2006 instead of 5 for missing file name for /doc.
282 Generate XML documentation when required, after type resolution.
284 Added support for picking up documentation (/// and /** ... */),
285 including a new XmlCommentState enumeration.
287 Added lines to fill Documentation element for field, constant,
288 property, indexer, method, constructor, destructor, operator, event
289 and class, struct, interface, delegate, enum.
290 Added lines to warn incorrect comment.
292 Added Documentation field (passed only when /doc was specified).
294 Added DocComment, DocCommentHeader, GenerateDocComment() and
295 OnGenerateDocComment() and some supporting private members for
296 /doc feature to MemberCore.
298 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
300 Added overriden DocCommentHeader.
302 Added overriden DocCommentHeader and GenerateDocComment().
304 2004-12-01 Miguel de Icaza <miguel@ximian.com>
306 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
307 unwrapping the enumeration values, chain to
308 DoConstantNumericPromotions again, so we can promote things to the
309 fundamental types (takes care of enums that are bytes, sbytes).
313 2004-12-01 Raja R Harinath <rharinath@novell.com>
315 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
316 Fix long-standing bug in type-lookup. Use FindType instead of
317 LookupType when ec.ResolvingTypeTree.
318 (Attribute.ResolveType, Attribute.Resolve)
319 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
321 (Attributes.Search): Remove internal version. Update.
322 (Attributes.SearchMulti): Update.
323 (Attributes.GetClsCompliantAttribute): Remove.
324 (Attributes.GetIndexerNameAttribute): Remove.
325 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
326 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
327 * class.cs (Indexer.Define): Likewise.
329 2004-12-01 Marek Safar <marek.safar@seznam.cz>
332 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
333 MarshallByReference members access.
335 * expression.cs: Use CheckMarshallByRefAccess;
336 Better error CS0197 message.
338 * report.cs: Print whole related error message.
340 2004-11-30 Raja R Harinath <rharinath@novell.com>
342 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
343 the current directory to help debugging.
345 2004-11-29 Marek Safar <marek.safar@seznam.cz>
347 * class (GetClassBases): Better error 60 report.
348 (EventProperty): Disabled warning 67 detection.
350 2004-11-29 Marek Safar <marek.safar@seznam.cz>
353 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
355 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
358 2004-11-29 Marek Safar <marek.safar@seznam.cz>
361 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
363 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
365 2004-11-26 Miguel de Icaza <miguel@ximian.com>
367 * attribute.cs (Attribute.Resolve): Refine error reporting and
368 report a cs0117 if the identifier does not exist, to distinguish
369 from 0617 which is a miss-use of the actual identifier.
371 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
372 between cs0070 and cs0079.
374 * class.cs (MemberBase.DoDefine): When reporting a wrong
375 accessibility level, we use MethodCore to compare instead of
376 Method (this was a regression in some refactoring effort).
378 So now we correctly report cs0056 again.
380 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
381 testing the target_type (which was known to be object_type) and
382 not the source type (which is anonymous_method).
384 Fixed reporting of error cs1660.
386 * expression.cs (UserCast.Source): Expose the underlying cast.
388 * statement.cs (Switch.SwitchGoverningType): Sort the list of
389 allowed types to find a match to int32 first (most common).
391 In addition, it ignores any ImplicitUserConversions that did an
392 internal implicit conversion (as the switch statement allows only
393 one integral conversion to exist).
395 * class.cs (PartialContainer.Create): rename `name' to
396 `member_name' for clarity. Then replace the string calls with a
397 call to MemberName.GetPartialName, as now using
398 MemberName.ToString is an error (this is due to the side effects
399 it had, that were fixed in the past).
401 This will restore the error reporting on a number of partial class
402 errors that were missusing this (and getting an exception as a
403 results, which is now just a plain textual warning, because
404 yyparse debug output would crash otherwise).
406 2004-11-26 Raja R Harinath <rharinath@novell.com>
408 * Makefile (PROGRAM_INSTALL_DIR): Remove.
410 2004-11-25 Ben Maurer <bmaurer@ximian.com>
412 * rootcontext.cs (LookupType): Make sure to cache lookups that
413 don't give us a negative result. This saves about 5% of corlib
416 2004-11-25 Miguel de Icaza <miguel@ximian.com>
418 * report.cs (AbstractMessage.Print): messages are sent to stderr
420 * class.cs (TypeContainer.GetClassBases): It is an error to have a
421 non-interface in the list of interfaces (at this point, either
422 parent was properly set, or a base class is being listed in the
425 This flags error 1722, and resolves the crash from bug 69259.
427 2004-11-25 Ben Maurer <bmaurer@ximian.com>
429 * statement.cs (Using.EmitExpressionFinally): make this work right
430 for valuetypes. Fixes 69926.
432 2004-11-25 Miguel de Icaza <miguel@ximian.com>
434 * const.cs (Const.ChangeType): Cope with the "0 literal can be
435 converted to an enum" here, before we try to change the underlying
436 type. This code exists, but it is a different code path than the
437 one used while encoding constants.
439 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
440 old bug: when converting from the null literal to a pointer,
441 return an EmptyCast, not the NullLiteral.
443 This fixes #69921, the recent null_type changes probably made this
446 (ImplicitReferenceConversionExists): In addition, resynchronized
447 the code here, so it matches the same code in
448 ImplicitReferenceConversionExists for the `from any class-type S
449 to any interface-type T'.
452 2004-11-25 Marek Safar <marek.safar@seznam.cz>
454 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
456 2004-11-24 Miguel de Icaza <miguel@ximian.com>
458 * cs-parser.jay: Use verbosity accordingly.
460 2004-11-24 Marek Safar <marek.safar@seznam.cz>
462 * expression.cs (Unary.ResolveOperator): Do not report warning;
463 AddressOf reads from variable.
465 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
467 2004-11-24 Marek Safar <marek.safar@seznam.cz>
471 * attribute.cs (Attributable): Removed CheckTargets.
472 (Attributes.Emit): Explicit attribute targets are tested here.
474 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
475 not enabled for interfaces.
477 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
478 (GetAssemblyName): Ouch next bug there.
480 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
482 * expression.cs: Error 275 added.
484 2004-11-23 Marek Safar <marek.safar@seznam.cz>
486 Fix bug #69177 (Implemented decimal constant support)
488 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
489 (BinaryFold): Add DecimalConstant.
491 * const.cs (Define): Decimal constant
493 (ChangeType): Add decimal type handling.
494 (LookupConstantValue): Don't set value for decimal type but
495 emit DecimalConstantAttribute. Needed for constant optimization.
497 * constant.cs (ToDecimal): New method.
498 (ConvertToDecimal): New method.
499 (IntConstant): Implemented ConvertToDecimal.
500 (DecimalConstant.Emit): Emit optimized version for decimals in
503 * expression.cs (ResolveOperator): Changed order of constant
504 reduction to work correctly with native types which have
505 overloaded operators.
506 (ResolveMemberAccess): Extract constant value from attribute
509 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
511 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
512 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
513 (ChangeType): Decimal is special.
514 (TypeToCoreType): Add decimal type.
516 2004-11-22 Marek Safar <marek.safar@seznam.cz>
518 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
521 2004-11-22 Marek Safar <marek.safar@seznam.cz>
523 * class.cs (EventField.ApplyAttributeBuilder): Fix error
526 2004-11-19 Marek Safar <marek.safar@seznam.cz>
528 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
530 * pending.cs (PendingImplementation): Grab only interfaces.
532 2004-11-19 Marek Safar <marek.safar@seznam.cz>
534 * statement.cs (ForeachHelperMethods): Add location member and
537 2004-11-19 Raja R Harinath <rharinath@novell.com>
539 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
540 automatically handled by executable.make.
541 (PROGRAM): Make profile-specific.
543 2004-11-18 Marek Safar <marek.safar@seznam.cz>
545 * expression.cs (DoResolveBase): Fixed wrong warning for out
548 2004-11-18 Martin Baulig <martin@ximian.com>
550 Merged latest changes into gmcs. Please keep this comment in
551 here, it makes it easier for me to see what changed in MCS since
552 the last time I merged.
554 2004-11-17 Raja R Harinath <rharinath@novell.com>
556 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
557 (TypeHandle.GetMemberCache): New.
558 (TypeHandle.TypeHandle): Update.
559 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
560 (TypeManager.LookupParentInterfacesCache):
561 Rename from LookupInterfaceCache. Optimize slightly.
562 (TypeManager.MemberLookup_FindMembers): Update.
563 * decl.cs (MemberCache.MemberCache): Set Container to null in the
565 (AddCacheContents): Rename from AddHashtable.
566 * class.cs (TypeContainer.parent_container): Remove.
567 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
568 (TypeContainer.DoDefineMembers): Don't initialize it.
569 Update to name changes.
571 2004-11-17 Miguel de Icaza <miguel@ximian.com>
573 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
574 that factors the code to check access modifiers on override.
576 (PropertyBase): Use the code here.
578 Patch from Lluis S'anchez, fixes bug #69361.
580 2004-11-15 Miguel de Icaza <miguel@ximian.com>
582 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
583 routine that is used to report the use of a captured variable
584 whose address has been taken.
586 There are two checks: one when variables are being captured and
587 the other check is when the address of a variable is taken.
589 (because an anonymous methods might be resolved before *or* after
590 the address has been taken) and
592 * expression.cs (Conditional.DoResolve): Remove the special
593 casing that Martin added to trueExpr and falseExpr being both
594 NullLiteral. We get the right behavior now just by introducing
595 the null_type into the compiler.
597 * convert.cs (ExplicitConversion): Change the code to use
598 null_type instead of testing `expr is NullLiteral'.
599 (ImplicitConversionStandard): use null_type too.
600 (ImplicitReferenceConversionExists): use null_type too.
601 (ImplicitReferenceConversion): use null_type too.
603 * literal.cs: The type of `NullLiteral' is now null_type instead
605 (Resolve): Set the type here.
607 * typemanager.cs: Introduce null_type.
609 2004-11-17 Martin Baulig <martin@ximian.com>
611 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
612 direction, like FindMembers() does. Fixes #69546, testcase is in
615 2004-11-16 Martin Baulig <martin@ximian.com>
617 This is based on a patch from Marek Safar, see bug #69082.
618 Fixes bugs #63705 and #67130.
620 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
621 method; create a MemberCache for an interface type and cache the
624 * decl.cs (IMemberContainer.ParentContainer): Removed.
625 (IMemberContainer.ParentCache): New property.
626 (MemberCache.SetupCacheForInterface): Removed.
627 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
628 to create a cache for an interface's "parent".
630 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
633 2004-11-16 Martin Baulig <martin@ximian.com>
635 Merged back from gmcs; these changes already went into gmcs a
639 (TypeManager.AddUserType): Removed the `ifaces' argument.
640 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
642 (TypeManager.AddUserInterface): Removed.
643 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
645 (TypeManager.GetInterfaces): Likewise.
646 (TypeManager.GetExplicitInterfaces): Likewise.
648 * ecore.cs (TypeExpr.GetInterfaces): Removed.
650 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
651 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
653 2004-11-14 Ben Maurer <bmaurer@ximian.com>
655 * statement.cs: Avoid adding bools to a hashtable.
657 2004-11-07 Miguel de Icaza <miguel@ximian.com>
659 * expression.cs (Invocation.OverloadResolve): Flag error if we are
660 calling an unsafe method from a safe location.
662 2004-11-06 Marek Safar <marek.safar@seznam.cz>
665 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
667 2004-11-06 Miguel de Icaza <miguel@ximian.com>
669 * namespace.cs (VerifyUsing): use GetPartialName instead of
672 2004-11-05 Miguel de Icaza <miguel@ximian.com>
674 * statement.cs (Return.Resolve): Fix regression in typo: if
675 `in_exc', we have to request a NeedReturnLabel, this was a typo
676 introduced in the anonymous method check-in. Fixes #69131.
678 * Indexers were using the ShortName when defining themselves,
679 causing a regression in the compiler bootstrap when applying the
680 patch from 2004-11-02 (first part), now they use their full name
683 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
685 * driver.cs: Strip the path from the names of embedded resources. Fixes
688 2004-11-04 Raja R Harinath <rharinath@novell.com>
690 Fix error message regression: cs0104-2.cs.
691 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
692 (AliasEntry.Resolve): Update.
693 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
695 (RootContext.LookupType): Update.
697 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
699 * cs-parser.jay: Add support for handling accessor modifiers
700 * class: Add support port accessor modifiers and error checking,
701 define PropertyMethod.Define as virtual (not abstract anymore)
702 * ecore.cs: Add checking for proeprties access with access modifiers
703 * iterators.cs: Modify Accessor constructor call based in the modified
705 2004-11-02 Ben Maurer <bmaurer@ximian.com>
707 * expression.cs (StringConcat): Handle being called twice,
708 as when we have a concat in a field init with more than two
711 2004-11-02 Miguel de Icaza <miguel@ximian.com>
713 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
714 special case explicit implementations, we should always produce
715 the .property or .event declaration.
717 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
718 since it will not return correct data if people use this
719 unresolved in the presence of using statements (see test-313).
721 * class.cs (MethodData.Define): If we are an explicit interface
722 implementation, set the method name to the full name of the
723 interface plus the name of the method.
725 Notice that using the method.MethodName.GetFullName() does not
726 work, as it will only contain the name as declared on the source
727 file (it can be a shorthand in the presence of using statements)
728 and not the fully qualifed type name, for example:
732 class D : ICloneable {
733 object ICloneable.Clone () {
737 Would produce a method called `ICloneable.Clone' instead of
738 `System.ICloneable.Clone'.
740 * namespace.cs (Alias.Resolve): Use GetPartialName.
742 2004-11-01 Marek Safar <marek.safar@seznam.cz>
744 * cs-parser.jay: Add error 1055 report.
746 2004-11-01 Miguel de Icaza <miguel@ximian.com>
748 * assign.cs (Assign.DoResolve): Only do the transform of
749 assignment into a New if the types are compatible, if not, fall
750 through and let the implicit code deal with the errors and with
751 the necessary conversions.
753 2004-11-01 Marek Safar <marek.safar@seznam.cz>
755 * cs-parser.jay: Add error 1031 report.
757 * cs-tokenizer.cs: Add location for error 1038.
759 2004-10-31 Marek Safar <marek.safar@seznam.cz>
761 * cs-parser.jay: Add error 1016 report.
763 2004-10-31 Marek Safar <marek.safar@seznam.cz>
765 * cs-parser.jay: Add errors 1575,1611 report.
767 2004-10-31 Marek Safar <marek.safar@seznam.cz>
769 * cs-parser.jay: Add error 1001 report.
771 2004-10-31 Marek Safar <marek.safar@seznam.cz>
774 * attribute.cs (GetMarshal): Add method argument for
775 caller identification.
777 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
778 agument for GetMarshal and RuntimeMissingSupport.
780 2004-10-31 Marek Safar <marek.safar@seznam.cz>
782 * attribute.cs (ExtractSecurityPermissionSet): Removed
783 TypeManager.code_access_permission_type.
785 * typemanager.cs: Removed TypeManager.code_access_permission_type.
787 2004-10-27 Miguel de Icaza <miguel@ximian.com>
789 * expression.cs (LocalVariableReference.DoResolveLValue): Check
790 for obsolete use of a variable here. Fixes regression on errors
791 cs0619-25 and cs0619-26.
793 2004-10-27 Marek Safar <marek.safar@seznam.cz>
795 Fix #62358, implemented security attribute encoding.
797 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
798 Tests permitted SecurityAction for assembly or other types.
799 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
800 data from SecurityPermissionAttribute to PermisionSet class.
802 * class.cs (ApplyAttributeBuilder): Added special handling
803 for System.Security.Permissions.SecurityAttribute based types.
805 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
806 special handling for System.Security.Permissions.SecurityAttribute
809 * enum.cs (ApplyAttributeBuilder): Added special handling
810 for System.Security.Permissions.SecurityAttribute based types.
812 * parameter.cs (ApplyAttributeBuilder): Added special handling
813 for System.Security.Permissions.SecurityAttribute based types.
815 * rootcontext.cs: Next 2 core types.
817 * typemanager.cs (TypeManager.security_permission_attr_type):
818 Built in type for the SecurityPermission Attribute.
819 (code_access_permission_type): Build in type.
821 2004-10-17 Miguel de Icaza <miguel@ximian.com>
823 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
824 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
825 all of this information into
826 EmitContext.EmitCapturedVariableInstance.
828 * codegen.cs (EmitCapturedVariableInstance): move here the
829 funcionality of emitting an ldarg.0 in the presence of a
830 remapping. This centralizes the instance emit code.
832 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
833 then emit a load of this: it means that we have reached the
834 topmost ScopeInfo: the one that contains the pointer to the
835 instance of the class hosting the anonymous method.
837 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
838 captures to the topmost CaptureContext.
840 2004-10-12 Miguel de Icaza <miguel@ximian.com>
842 * expression.cs (LocalVariableReference): Move the knowledge about
843 the iterators into codegen's EmitCapturedVariableInstance.
845 2004-10-11 Miguel de Icaza <miguel@ximian.com>
847 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
848 all code paths return a value from an anonymous method (it is the
849 same as the 161 error, but for anonymous methods).
851 2004-10-08 Miguel de Icaza <miguel@ximian.com>
853 The introduction of anonymous methods in the compiler changed
854 various ways of doing things in the compiler. The most
855 significant one is the hard split between the resolution phase
856 and the emission phases of the compiler.
858 For instance, routines that referenced local variables no
859 longer can safely create temporary variables during the
860 resolution phase: they must do so from the emission phase,
861 since the variable might have been "captured", hence access to
862 it can not be done with the local-variable operations from the runtime.
866 (Block.Flags): New flag `IsTopLevel' to indicate that this block
869 (ToplevelBlock): A new kind of Block, these are the blocks that
870 are created by the parser for all toplevel method bodies. These
871 include methods, accessors and anonymous methods.
873 These contain some extra information not found in regular blocks:
874 A pointer to an optional CaptureContext (for tracking captured
875 local variables and parameters). A pointer to the parent
878 (Return.Resolve): Catch missmatches when returning a value from an
879 anonymous method (error 1662).
880 Invoke NeedReturnLabel from the Resolve phase instead of the emit
883 (Break.Resolve): ditto.
885 (SwitchLabel): instead of defining the labels during the
886 resolution phase, we now turned the public ILLabel and ILLabelCode
887 labels into methods called GetILLabelCode() and GetILLabel() that
888 only define the label during the Emit phase.
890 (GotoCase): Track the SwitchLabel instead of the computed label
891 (its contained therein). Emit the code by using
892 SwitchLabel.GetILLabelCode ().
894 (LocalInfo.Flags.Captured): A new flag has been introduce to track
895 whether the Local has been captured or not.
897 (LocalInfo.IsCaptured): New property, used to tell whether the
898 local has been captured.
900 * anonymous.cs: Vastly updated to contain the anonymous method
903 The main classes here are: CaptureContext which tracks any
904 captured information for a toplevel block and ScopeInfo used to
905 track the activation frames for various local variables.
907 Each toplevel block has an optional capture context associated
908 with it. When a method contains an anonymous method both the
909 toplevel method and the anonymous method will create a capture
910 context. When variables or parameters are captured, they are
911 recorded on the CaptureContext that owns them, for example:
915 MyDelegate d = delegate {
920 Here `a' will be recorded as captured on the toplevel
921 CapturedContext, the inner captured context will not have anything
922 (it will only have data if local variables or parameters from it
923 are captured in a nested anonymous method.
925 The ScopeInfo is used to track the activation frames for local
926 variables, for example:
928 for (int i = 0; i < 10; i++)
929 for (int j = 0; j < 10; j++){
930 MyDelegate d = delegate {
935 At runtime this captures a single captured variable `i', but it
936 captures 10 different versions of the variable `j'. The variable
937 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
940 The toplevel ScopeInfo will also track information like the `this'
941 pointer if instance variables were referenced (this is necessary
942 as the anonymous method lives inside a nested class in the host
945 (AnonymousMethod): Expanded to track the Toplevel, implement
946 `AnonymousMethod.Compatible' to tell whether an anonymous method
947 can be converted to a target delegate type.
949 The routine now also produces the anonymous method content
951 (AnonymousDelegate): A helper class that derives from
952 DelegateCreation, this is used to generate the code necessary to
953 produce the delegate for the anonymous method that was created.
955 * assign.cs: API adjustments for new changes in
956 Convert.ImplicitStandardConversionExists.
958 * class.cs: Adjustments to cope with the fact that now toplevel
959 blocks are of type `ToplevelBlock'.
961 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
962 insteda of standard blocks.
964 Flag errors if params arguments are passed to anonymous methods.
966 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
967 `CurrentAnonymousMethod' which points to the current Anonymous
968 Method. The variable points to the AnonymousMethod class that
969 holds the code being compiled. It is set in the new EmitContext
970 created for the anonymous method.
972 (EmitContext.Phase): Introduce a variable and an enumeration to
973 assist in enforcing some rules about when and where we are allowed
974 to invoke certain methods (EmitContext.NeedsReturnLabel is the
975 only one that enfonces this right now).
977 (EmitContext.HaveCaptureInfo): new helper method that returns
978 whether we have a CapturedContext initialized.
980 (EmitContext.CaptureVariable): New method used to register that a
981 LocalInfo must be flagged for capturing.
983 (EmitContext.CapturedParameter): New method used to register that a
984 parameters must be flagged for capturing.
986 (EmitContext.CapturedField): New method used to register that a
987 field must be flagged for capturing.
989 (EmitContext.HaveCapturedVariables,
990 EmitContext.HaveCapturedFields): Return whether there are captured
993 (EmitContext.EmitMethodHostInstance): This is used to emit the
994 instance for the anonymous method. The instance might be null
995 (static methods), this (for anonymous methods that capture nothing
996 and happen to live side-by-side with the current method body) or a
997 more complicated expression if the method has a CaptureContext.
999 (EmitContext.EmitTopBlock): Routine that drives the emission of
1000 code: it will first resolve the top block, then emit any metadata
1001 and then emit the code. The split is done so that we can extract
1002 any anonymous methods and flag any captured variables/parameters.
1004 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1005 during this phase, the ILGenerator should not be used as labels
1006 and local variables declared here might not be accessible to any
1007 code that is part of an anonymous method.
1009 Exceptions to this include the temporary variables that are
1010 created by some statements internally for holding temporary
1013 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1016 (EmitContext.TemporaryReturn): This method is typically called
1017 from the Emit phase, and its the only place where we allow the
1018 ReturnLabel to be defined other than the EmitMeta. The reason is
1019 that otherwise we would have to duplicate a lot of logic in the
1020 Resolve phases of various methods that today is on the Emit
1023 (EmitContext.NeedReturnLabel): This no longer creates the label,
1024 as the ILGenerator is not valid during the resolve phase.
1026 (EmitContext.EmitThis): Extended the knowledge in this class to
1027 work in anonymous methods in addition to iterators.
1029 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1030 code is necessary on the stack to access the instance to a local
1031 variable (the variable will be accessed as a field).
1033 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1034 EmitContext.EmitAddressOfParameter): Routines to support
1035 parameters (not completed at this point).
1037 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1038 will also remove the parameters.
1040 * convert.cs (Convert): Define a `ConstantEC' which points to a
1041 null. This is just to prefity some code that uses
1042 ImplicitStandardConversion code and do not have an EmitContext
1045 The idea is to flag explicitly that at that point in time, it is
1046 known that the conversion will not trigger the delegate checking
1047 code in implicit conversions (which requires a valid
1050 Everywhere: pass new EmitContext parameter since
1051 ImplicitStandardConversionExists now requires it to check for
1052 anonymous method conversions.
1054 (Convert.ImplicitStandardConversionExists): If the type of an
1055 expression is the anonymous_method_type, and the type is a
1056 delegate, we invoke the AnonymousMethod.Compatible method to check
1057 whether an implicit conversion is possible.
1059 (Convert.ImplicitConversionStandard): Only do implicit method
1060 group conversions if the language level is not ISO_1.
1062 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1063 MethodInfo for the Invoke method. used by Delegate and
1066 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1067 method conversions if the target type is a delegate.
1069 Removed extra debugging nops.
1071 (LocalVariableReference): Turn the `local_info' into a public
1074 Add `prepared' field, the same hack used for FieldExprs to cope
1075 with composed assignments, as Local variables do not necessarily
1076 operate purely on the stack as they used to: they can be captured
1079 Add `temp' for a temporary result, like fields.
1081 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1083 It now copes with Local variables that are captured and emits the
1084 proper instance variable to load it from a field in the captured
1087 (ParameterReference.DoResolveBase): During the resolve phase,
1088 capture parameters if we are in an anonymous method.
1090 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1091 anonymous method, use the EmitContext helper routines to emit the
1092 parameter reference.
1094 * iterators.cs: Set RemapToProxy to true/false during the
1097 * parameters.cs (GetParameterByName): New helper method.
1099 * typemanager.cs (anonymous_method_type) a new type that
1100 represents an anonyous method. This is always an internal type,
1101 used as a fencepost to test against the anonymous-methodness of an
1104 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1106 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1108 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1110 2004-10-18 Martin Baulig <martin@ximian.com>
1112 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1113 `Type' directly, but call ResolveType() on it.
1114 (Catch.Resolve): Likewise.
1115 (Foreach.Resolve): Likewise.
1117 2004-10-18 Martin Baulig <martin@ximian.com>
1119 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1120 `Type' directly, but call ResolveType() on it.
1121 (Probe.DoResolve): Likewise.
1122 (ArrayCreation.LookupType): Likewise.
1123 (TypeOf.DoResolve): Likewise.
1124 (SizeOf.DoResolve): Likewise.
1126 2004-10-18 Martin Baulig <martin@ximian.com>
1128 * expression.cs (Invocation.BetterFunction): Put back
1129 TypeManager.TypeToCoreType().
1131 2004-10-18 Raja R Harinath <rharinath@novell.com>
1133 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1136 2004-10-18 Martin Baulig <martin@ximian.com>
1138 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1139 `Type' directly, but call ResolveType() on it.
1141 2004-10-18 Martin Baulig <martin@ximian.com>
1143 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1144 `Type' directly, but call ResolveType() on it.
1145 (MemberBase.DoDefine): Likewise.
1147 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1148 `Type' directly, but call ResolveType() on it.
1149 (ComposedCast.DoResolveAsTypeStep): Likewise.
1151 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1152 `Type' directly, but call ResolveType() on it.
1154 2004-10-17 John Luke <john.luke@gmail.com>
1156 * class.cs (Operator.GetSignatureForError): use CSharpName
1158 * parameter.cs (Parameter.GetSignatureForError): Returns
1159 correct name even if was not defined.
1161 2004-10-13 Raja R Harinath <rharinath@novell.com>
1164 * class.cs (TypeContainer.EmitContext): New property.
1165 (DefineNestedTypes): Create an emitcontext for each part.
1166 (MethodCore.DoDefineParameters): Use container's emitcontext.
1167 Pass type array to InternalParameters.
1168 (MemberBase.DoDefine): Use container's emitcontext.
1169 (FieldMember.Define): Likewise.
1170 (Event.Define): Likewise.
1171 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1172 Pass type array to InternalParameters.
1173 (SetIndexerMethod.GetParameterInfo): Likewise.
1174 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1175 * delegate.cs (Define): Pass emitcontext to
1176 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1177 array to InternalParameters.
1178 * expression.cs (ParameterReference.DoResolveBase): Pass
1179 emitcontext to GetParameterInfo.
1180 (ComposedCast.DoResolveAsTypeStep): Remove check on
1181 ec.ResolvingTypeTree.
1182 * parameter.cs (Parameter.Resolve): Change argument to
1183 EmitContext. Use ResolveAsTypeTerminal.
1184 (Parameter.GetSignature): Change argument to EmitContext.
1185 (Parameters.ComputeSignature): Likewise.
1186 (Parameters.ComputeParameterTypes): Likewise.
1187 (Parameters.GetParameterInfo): Likewise.
1188 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1189 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1190 * support.cs (InternalParameters..ctor): Remove variant that takes
1192 * typemanager.cs (system_intptr_expr): New.
1193 (InitExpressionTypes): Initialize it.
1195 2004-10-12 Chris Toshok <toshok@ximian.com>
1197 * cs-parser.jay: fix location for try_statement and catch_clause.
1199 2004-10-11 Martin Baulig <martin@ximian.com>
1201 * report.cs: Don't make --fatal abort on warnings, we have
1202 -warnaserror for that.
1204 2004-10-07 Raja R Harinath <rharinath@novell.com>
1206 More DeclSpace.ResolveType avoidance.
1207 * decl.cs (MemberCore.InUnsafe): New property.
1208 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1209 with newly created EmitContext.
1210 (FieldMember.Define): Likewise.
1211 * delegate.cs (Delegate.Define): Likewise.
1212 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1213 only if normal name-lookup fails.
1214 (TypeExpr.DoResolve): Enable error-checking.
1215 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1216 (SizeOf.DoResolve): Likewise.
1217 (ComposedCast.DoResolveAsTypeStep): Likewise.
1218 (StackAlloc.DoResolve): Likewise.
1219 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1220 (Block.Unsafe): New property.
1221 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1222 (Unsafe): Set 'unsafe' flag of contained block.
1223 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1224 (Fixed.Resolve): Likewise.
1225 (Catch.Resolve): Likewise.
1226 (Using.ResolveLocalVariableDecls): Likewise.
1227 (Foreach.Resolve): Likewise.
1229 2004-10-05 John Luke <john.luke@gmail.com>
1231 * cs-parser.jay: add location to error CS0175
1233 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1235 * ecore.cs (Expression.Constantity): Add support for turning null
1238 * const.cs (Const.Define): Allow constants to be reference types
1239 as long as the value is Null.
1241 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1243 * namespace.cs (NamespaceEntry.Using): No matter which warning
1244 level is set, check if this namespace name has already been added.
1246 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1248 * expression.cs: reftype [!=]= null should always use br[true,false].
1251 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1254 * attribute.cs: Enum conversion moved to
1255 GetAttributeArgumentExpression to be applied to the all
1258 2004-10-01 Raja R Harinath <rharinath@novell.com>
1260 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1261 * class.c (TypeContainer.DefineType): Flag error if
1262 base types aren't accessible due to access permissions.
1263 * decl.cs (DeclSpace.ResolveType): Move logic to
1264 Expression.ResolveAsTypeTerminal.
1265 (DeclSpace.ResolveTypeExpr): Thin layer over
1266 Expression.ResolveAsTypeTerminal.
1267 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1268 Refactor code into NestedAccess. Use it.
1269 (DeclSpace.NestedAccess): New.
1270 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1271 argument to silence errors. Check access permissions.
1272 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1273 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1274 (Cast.DoResolve): Likewise.
1275 (New.DoResolve): Likewise.
1276 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1277 (TypeOf.DoResolve): Likewise.
1279 * expression.cs (Invocation.BetterConversion): Return the Type of
1280 the better conversion. Implement section 14.4.2.3 more faithfully.
1281 (Invocation.BetterFunction): Make boolean. Make correspondence to
1282 section 14.4.2.2 explicit.
1283 (Invocation.OverloadResolve): Update.
1284 (Invocation): Remove is_base field.
1285 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1286 (Invocation.Emit): Likewise.
1288 2004-09-27 Raja R Harinath <rharinath@novell.com>
1290 * README: Update to changes.
1292 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1294 * cs-parser.jay: Reverted 642 warning fix.
1296 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1299 * decl.cs (FindMemberWithSameName): Indexer can have more than
1302 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1304 * expression.cs (LocalVariableReference.DoResolveLValue):
1305 Do not report warning 219 for out values.
1306 (EmptyExpression.Null): New member to avoid extra allocations.
1308 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1310 * cs-parser.jay: Fix wrong warning 642 report.
1312 * cs-tokenizer.cs (CheckNextToken): New helper;
1313 Inspect next character if is same as expected.
1315 2004-09-23 Martin Baulig <martin@ximian.com>
1317 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1318 (Convert.ImplicitReferenceConversionExists): Likewise.
1320 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1322 * class.cs (Operator.Define): Add error 448 and 559 report.
1324 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1326 * class.cs (MemberBase.IsTypePermitted): New protected
1327 method for checking error CS0610.
1329 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1331 * class.cs (TypeContainer.HasExplicitLayout): New property
1332 Returns whether container has StructLayout attribute set Explicit.
1333 (FieldMember): New abstract class for consts and fields.
1334 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1335 (Field): Reuse FieldMember.
1337 * const.cs (Const): Reuse FieldMember.
1339 * rootcontext.cs: EmitConstants call moved to class.
1341 2004-09-22 Martin Baulig <martin@ximian.com>
1343 Thanks to Peter Sestoft for this bug report.
1345 * expression.cs (Conditional): If both the `trueExpr' and the
1346 `falseExpr' is a NullLiteral, return a NullLiteral.
1348 2004-09-22 Martin Baulig <martin@ximian.com>
1350 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1351 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1352 for the "get_Current" call.
1354 2004-09-22 Martin Baulig <martin@ximian.com>
1356 Marek and me just fixed one of our oldest bugs: #28562 :-)
1358 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1360 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1361 we're an EnumConstant, just return that.
1362 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1363 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1364 to get the value which'll actually be written into the attribute.
1365 However, we have to use GetValue() to access the attribute's value
1368 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1370 * constant.cs (Constant.IsNegative): New abstract property
1373 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1374 (StackAlloc.DoResolve): Reused IsNegative.
1376 2004-09-21 Martin Baulig <martin@ximian.com>
1378 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1379 if we're used in an iterator, we may be called from different
1382 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1383 we actually have an exception block.
1385 2004-09-20 John Luke <jluke@cfl.rr.com>
1387 * class.cs, cs-parser.jay: Improve the error report for 1520:
1388 report the actual line where the error happens, not where the
1391 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1392 Pass location information that was available elsewhere.
1394 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1396 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1397 runtime to delay sign assemblies.
1399 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1401 * cs-parser.jay: Do not report the stack trace, this is barely
1404 2004-08-22 John Luke <john.luke@gmail.com>
1406 * driver.cs : check that a resource id is not already used
1407 before adding it, report CS1508 if it is, bug #63637
1409 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1411 * ecore.cs: Removed dead code.
1413 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1415 * class.cs: Do not report warning CS0067 on the interfaces.
1417 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1419 * cs-parser.jay: Add error 504 report.
1421 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1423 * rootcontext.cs: WarningLevel is 4 by default now.
1425 * statement.cs (Fixed.Resolve): Do not null
1428 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1431 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1432 deep search when property is not virtual.
1433 (PropertyExpr.ResolveAccessors): Make one call for both
1436 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1439 * statement.cs: Error 152 report constains also location.
1441 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1444 * const.cs: Explicitly set constant as static.
1446 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1449 * cs-parser.jay: Add error 1017 report.
1451 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1453 Fixed bug #59980, #64224
1454 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1456 * typemanager.cs (IsSpecialMethod): Simplified
1458 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1460 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1461 condition with better params.
1463 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1466 * attribute.cs (Resolve): Property has to have both
1469 2004-09-14 Martin Baulig <martin@ximian.com>
1471 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1473 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1476 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1477 called and is obsolete then this member suppress message
1478 when call is inside next [Obsolete] method or type.
1480 * expression.cs: Use TestObsoleteMethodUsage member.
1482 2004-09-14 Martin Baulig <martin@ximian.com>
1484 * cs-parser.jay: Sync a bit with the GMCS version.
1486 2004-09-14 Martin Baulig <martin@ximian.com>
1488 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1489 (CSharpParser.yacc_verbose_flag): New public field.
1491 * genericparser.cs: Removed.
1493 2004-09-14 Raja R Harinath <rharinath@novell.com>
1495 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
1497 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1499 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1501 2004-09-10 Martin Baulig <martin@ximian.com>
1503 Backported my MemberName changes from GMCS into MCS.
1505 - we are now using a special `MemberName' class instead of using
1506 strings; in GMCS, the `MemberName' also contains the type
1509 - changed the grammar rules a bit:
1510 * the old `member_name' is now a `namespace_or_type_name':
1511 The rule is that we use `namespace_or_type_name' everywhere
1512 where we expect either a "member name" (GetEnumerator) or a
1513 "member name" with an explicit interface name
1514 (IEnumerable.GetEnumerator).
1515 In GMCS, the explicit interface name may include type arguments
1516 (IEnumerable<T>.GetEnumerator).
1517 * we use `member_name' instead of just `IDENTIFIER' for
1519 The rule is that we use `member_name' wherever a member may
1520 have type parameters in GMCS.
1522 * decl.cs (MemberName): New public class.
1523 (MemberCore.MemberName): New public readonly field.
1524 (MemberCore.ctor): Take a `MemberName' argument, not a string.
1525 (DeclSpace): Likewise.
1527 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
1528 * enum.cs (Enum.ctor): Likewise.
1530 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
1532 (AliasEntry.ctor): Take a MemberName, not an Expression.
1533 (AliasEntry.UsingAlias): Likewise.
1535 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
1536 (IMethodData.MemberName): Changed type from string to MemberName.
1537 (MemberBase.ExplicitInterfaceName): Likewise.
1538 (AbstractPropertyEventMethod.SetupName): Make this private.
1539 (AbstractPropertyEventMethod.ctor): Added `string prefix'
1540 argument; compute the member name here.
1541 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
1542 on the `member.MemberName' and the `prefix'.
1544 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
1546 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
1547 thus, we get a `MemberName' instead of a `string'. These
1548 declarations may have type parameters in GMCS.
1549 (interface_method_declaration, delegate_declaration): Likewise.
1550 (class_declaration, interface_declaration): Likewise.
1551 (method_header): Use `namespace_or_type_name' instead of
1552 `member_name'. We may be an explicit interface implementation.
1553 (property_declaration, event_declaration): Likewise.
1554 (member_name): This is now just an `IDENTIFIER', not a
1555 `namespace_or_type_name'.
1556 (type_name, interface_type): Removed.
1557 (namespace_or_type_name): Return a MemberName, not an Expression.
1558 (primary_expression): Use `member_name' instead of `IDENTIFIER';
1559 call GetTypeExpression() on the MemberName to get an expression.
1560 (IndexerDeclaration.interface_type): Changed type from string to
1562 (MakeName): Operate on MemberName's instead of string's.
1564 2004-09-13 Raja R Harinath <rharinath@novell.com>
1567 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
1568 (NamespaceEntry.Lookup): Add new argument to flag if we want the
1569 lookup to avoid symbols introduced by 'using'.
1570 * rootcontext.cs (NamespaceLookup): Update.
1572 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1574 * class.cs (TypeContainer.DoDefineMembers): Do not call
1575 DefineDefaultConstructor for static classes.
1577 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1579 * attribute.cs (Attribute.Resolve): Add error 653 report.
1581 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1583 (Method.ApplyAttributeBuilder): Add error 685 report.
1584 (Operator.Define): Add error 564 report.
1586 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1588 * expression.cs (Invocation.DoResolve): Add error
1591 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1594 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1596 * class.cs (ConstructorInitializer.Resolve):
1597 Wrong error number (515->516).
1599 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1601 * class.cs (Indexer.Define): Add error 631 report.
1603 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1605 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1607 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1609 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1611 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1613 * cs-parser.jay: Added error CS0241 report.
1615 2004-09-10 Raja R Harinath <rharinath@novell.com>
1617 * cs-parser.jay (fixed_statement): Introduce a scope for the
1618 declaration in the 'fixed' statement.
1620 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1622 * cs-parser.jay: Added CS0230 error report.
1624 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1626 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1628 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1630 * expression.cs (Argument.Resolve): Added error CS0192 and
1633 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1635 C# 2.0 #pragma warning feature
1637 * cs-tokenizer.cs (PreProcessPragma): New method;
1638 Handles #pragma directive.
1640 * report.cs (WarningRegions): New class; Support
1641 class for #pragma warning directive. It tests whether
1642 warning is enabled for a given line.
1644 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1646 * const.cs: Add more descriptive error report, tahnks to
1649 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1651 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1653 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1655 * expression.cs: Apply patch from Ben: Remove dead code from
1656 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1657 as that code just threw an exception anwyays.
1659 * const.cs: Remove the call to the turnintoconstant, for details
1662 * literal.cs: The type of the null-literal is the null type; So
1663 we use a placeholder type (literal.cs:System.Null, defined here)
1666 * expression.cs (Conditional.DoResolve): Remove some old code that
1667 is no longer needed, conversions have been fixed.
1669 (ArrayCreationExpression.DoResolve): Return false if we fail to
1670 resolve the inner expression.
1672 2004-09-07 Raja R Harinath <rharinath@novell.com>
1675 * cs-parser.jay (delegate_declaration): Record a delegate
1676 declaration as a type declaration.
1677 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1679 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1681 * parameter.cs: Do not crash if the type can not be resolved.
1683 * expression.cs: Report errors with unsafe pointers, fixes #64896
1685 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1687 * expression.cs: Pointer arith always needs to do a conv.i
1688 if the operand is a long. fix 65320
1690 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1692 Fixed cs0619-37.cs, cs0619-38.cs
1694 * enum.cs (GetObsoleteAttribute): Removed.
1696 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1697 on Enum member is double staged. The first is tested member
1700 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1702 Fixed #56986, #63631, #65231
1704 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1705 adds member to name container.
1706 (TypeContainer.AddToTypeContainer): New method, adds type to
1708 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1709 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1710 AddOperator): Simplified by reusing AddToMemberContainer.
1711 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1713 (Method.CheckForDuplications): Fixed implementation to test all
1715 (MemberBase): Detection whether member is explicit interface
1716 implementation is now in constructor.
1717 (MemberBase.UpdateMemberName): Handles IndexerName.
1718 (Accessor): Changed to keep also location information.
1719 (AbstractPropertyEventMethod): Is derived from MemberCore.
1720 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1721 will be emited or not.
1722 (PropertyBase.AreAccessorsDuplicateImplementation):
1723 Tests whether accessors are not in collision with some method.
1724 (Operator): Is derived from MethodCore to simplify common
1727 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1729 (DeclSpace.AddToContainer): Adds the member to defined_names
1730 table. It tests for duplications and enclosing name conflicts.
1732 * enum.cs (EnumMember): Clean up to reuse the base structures
1734 2004-09-03 Martin Baulig <martin@ximian.com>
1736 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1737 into TypeContainer, to make partial classes work again.
1739 2004-09-03 Martin Baulig <martin@ximian.com>
1741 * rootcontext.cs (RootContext.V2): Removed.
1743 2004-03-23 Martin Baulig <martin@ximian.com>
1745 * expression.cs (Invocation.OverloadResolve): Added `bool
1746 may_fail' argument and use it instead of the Location.IsNull() hack.
1748 2004-09-03 Martin Baulig <martin@ximian.com>
1750 Merged latest changes into gmcs. Please keep this comment in
1751 here, it makes it easier for me to see what changed in MCS since
1752 the last time I merged.
1754 2004-09-03 Raja R Harinath <rharinath@novell.com>
1757 * expression.cs (BetterConversion): Don't allow either conversion
1758 to be null. Remove redundant implicit conversion test when 'q ==
1759 null' -- when this function is invoked, we already know that the
1760 implicit conversion exists.
1761 (BetterFunction): Assume that 'best' is non-null. Remove
1762 redundant reimplementation of IsApplicable when 'best' is null.
1763 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1764 number of arguments.
1765 (IsAncestralType): Extract from OverloadResolve.
1766 (OverloadResolve): Make robust to the MethodGroupExpr being
1767 unsorted. Implement all the logic of Section 14.5.5.1, and
1768 support overloading of methods from multiple applicable types.
1769 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1771 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1772 (RealError, Warning): Append type of report to related symbol.
1774 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1776 * enum.cs: Fixed CLS-Compliance checks for enum members.
1777 Error tests cs3008-8.cs, cs3014-8.cs
1779 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1781 Fixed bug #62342, #63102
1782 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1783 like ImplementMethod.
1785 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1787 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1790 2004-09-02 Martin Baulig <martin@ximian.com>
1792 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1793 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1796 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1798 C# 2.0 Static classes implemented
1800 * class.cs (TypeContainer): instance_constructors,
1801 initialized_fields, initialized_static_fields,
1802 default_constructor, base_inteface_types are protected to be
1803 accessible from StaticClass.
1804 (TypeContainer.DefineDefaultConstructor): New virtual method
1805 for custom default constructor generating
1806 (StaticClass): New class to handle "Static classes" feature.
1808 * cs-parser.jay: Handle static keyword on class like instance
1811 * driver.cs: Added "/langversion" command line switch with two
1812 options (iso-1, default).
1814 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1816 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1818 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1820 * delegate.cs: Style.
1822 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1824 * delegate.cs: Add seperate instance expr field for miguel.
1826 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1828 * PointerArithmetic (Resolve): make sure we are not doing
1829 pointer arith on void*. Also, make sure we are resolved
1830 by not setting eclass until resolve.
1832 All callers: Make sure that PointerArithmetic gets resolved.
1834 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1836 * ArrayCreation (LookupType): If the type does not resolve
1837 to an array, give an error.
1839 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1841 * statement.cs (Try.Resolve): Fixed bug #64222
1843 2004-08-27 Martin Baulig <martin@ximian.com>
1846 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1849 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1851 * ecore.cs (Constantify): Get underlying type via
1852 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1853 Windows in special cases.
1855 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1857 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1858 for obtaining also private methods.
1859 (GetRemoveMethod): Used GetRemoveMethod (true)
1860 for obtaining also private methods.
1862 2004-08-24 Martin Baulig <martin@ximian.com>
1864 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1865 MethodAttributes.HideBySig for operators.
1867 2004-08-23 Martin Baulig <martin@ximian.com>
1869 Back to the old error reporting system :-)
1871 * report.cs (Message): Removed.
1872 (Report.MessageData, ErrorData, WarningData): Removed.
1873 (Report.Error, Warning): Back to the old system.
1875 2004-08-23 Martin Baulig <martin@ximian.com>
1877 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1879 * class.cs (TypeContainer.ParentContainer): New public virtual
1880 method; replaces the explicit interface implementation.
1881 (ClassPart.ParentContainer): Override.
1883 2004-08-23 Martin Baulig <martin@ximian.com>
1885 * statement.cs (Switch): Added support for constant switches; see
1886 #59428 or test-285.cs.
1888 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1891 * statement.cs (GetEnumeratorFilter): Removed useless
1892 logic because C# specs is strict. GetEnumerator must be
1895 2004-08-22 Martin Baulig <martin@ximian.com>
1897 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1898 a switch and may break, reset the barrier. Fixes #59867.
1900 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1902 CLS-Compliance speed up (~5% for corlib)
1904 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1905 New method. Tests container for CLS-Compliant names
1907 * class.cs (TypeContainer.VerifyClsName): New method.
1908 Checks whether container name is CLS Compliant.
1909 (Constructor): Implements IMethodData.
1911 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1912 low-case table for CLS Compliance test.
1913 (MemberCache.VerifyClsParameterConflict): New method.
1914 Checks method parameters for CS3006 error.
1916 * enum.cs (EnumMember): Is derived from MemberCore.
1917 (Enum.VerifyClsName): Optimized for better performance.
1919 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1921 * report.cs: Renamed Error_T to Error and changed all
1924 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1926 * class.cs (TypeContainer.IndexerArrayList): New inner class
1927 container for indexers.
1928 (TypeContainer.DefaultIndexerName): New constant for default
1929 indexer name. Replaced all "Item" with this constant.
1930 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1932 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1933 DefaultMemberAttribute constructor.
1935 2004-08-05 Martin Baulig <martin@ximian.com>
1937 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1940 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1942 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1943 multi platforms problem.
1945 * compiler.csproj: Included shared files.
1947 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1949 Fix bug 60333, 55971 in the more general way
1950 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1951 Added arg_type argument for constant conversion.
1952 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1954 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1957 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1958 OperatorArrayList, MethodCoreArrayList for typecontainer
1959 containers. Changed class member types to these new types.
1960 (MethodArrayList.DefineMembers): Added test for CS0659.
1962 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1964 * cfold.cs: Synchronize the folding with the code in expression.cs
1965 Binary.DoNumericPromotions for uint operands.
1967 * attribute.cs: Revert patch from Raja, it introduced a regression
1968 while building Blam-1.2.1 (hard to isolate a test case).
1970 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1974 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1976 (MethodCore.parent_method): New member. The method we're overriding
1977 if this is an override method.
1978 (MethodCore.CheckBase): Moved from Method class and made common.
1979 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1981 (MethodCore.CheckForDuplications): New abstract method. For custom
1982 member duplication search in a container
1983 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1984 method and its return type.
1985 (Event.conflict_symbol): New member. Symbol with same name in the
1989 (MemberCache.FindMemberWithSameName): New method. The method
1990 is looking for conflict with inherited symbols.
1992 2004-08-04 Martin Baulig <martin@ximian.com>
1994 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1996 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1998 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2000 * report.cs (Message): New enum for better error, warning reference in
2002 (MessageData): New inner abstract class. It generally handles printing of
2003 error and warning messages.
2004 Removed unused Error, Warning, Message methods.
2006 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2008 Fix for cs0592-8.cs test
2010 (Attributable.ValidAttributeTargets): Made public.
2011 (Attribute.ExplicitTarget): New member for explicit target value.
2012 (Attribute.CheckTargets): Now we translate explicit attribute
2013 target to Target here.
2015 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2017 * ecore.cs (MethodGroupExpr): new IsBase property.
2019 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2021 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2022 rather than an instance expr.
2024 (DelegateCreation.Emit): Use the method group rather than
2025 the instance expression. Also, if you have base.Foo as the
2026 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2028 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2030 (NewDelegate.DoResolve): Only check for the existance of Invoke
2031 if the method is going to be needed. Use MethodGroupExpr.
2033 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2035 * expression.cs: For pointer arith., make sure to use
2036 the size of the type, not the size of the pointer to
2039 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2042 * class.cs (Class): Added error CS0502 test.
2044 2004-08-03 John Luke <jluke@cfl.rr.com>
2045 Raja R Harinath <rharinath@novell.com>
2048 * attribute.cs (Attribute.complained_before): New flag.
2049 (Attribute.ResolveType, Attribute.Resolve),
2050 (Attribute.DefinePInvokeMethod): Set it.
2051 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2053 2004-08-03 Martin Baulig <martin@ximian.com>
2055 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2056 use a user-defined operator; we still need to do numeric
2057 promotions in case one argument is a builtin type and the other
2058 one has an implicit conversion to that type. Fixes #62322.
2060 2004-08-02 Martin Baulig <martin@ximian.com>
2062 * statement.cs (LocalInfo.Flags): Added `IsThis'.
2063 (LocalInfo.IsThis): New public property.
2064 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
2066 2004-08-01 Martin Baulig <martin@ximian.com>
2068 * class.cs (TypeContainer.GetClassBases): Don't set the default
2069 here since we may get called from GetPartialBases().
2070 (TypeContainer.DefineType): If GetClassBases() didn't return a
2071 parent, use the default one.
2073 2004-07-30 Duncan Mak <duncan@ximian.com>
2075 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
2077 2004-07-30 Martin Baulig <martin@ximian.com>
2079 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2081 * class.cs (SourceMethod): New public class, derive from the
2082 symbol writer's ISourceMethod.
2083 (Method): Use the new symbol writer API.
2085 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2086 as argument and use the new symbol writer.
2089 (SourceFile): Implement the symbol writer's ISourceFile.
2090 (Location.SymbolDocument): Removed.
2091 (Location.SourceFile): New public property.
2093 * symbolwriter.cs: Use the new symbol writer API.
2095 2004-07-30 Raja R Harinath <rharinath@novell.com>
2097 * Makefile (install-local): Remove. Functionality moved to
2100 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2102 * Makefile: Install mcs.exe.config file together with mcs.exe.
2103 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2104 correct runtime version.
2106 2004-07-25 Martin Baulig <martin@ximian.com>
2109 (TypeContainer.RegisterOrder): Removed, this was unused.
2110 (TypeContainer, interface_order): Removed.
2111 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2112 TypeContainer as argument since we can also be called with a
2113 `PartialContainer' for a partial class/struct/interface.
2114 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2115 of checking whether we're an `Interface' - we could be a
2117 (PartialContainer.Register): Override; call
2118 AddClass()/AddStruct()/AddInterface() on our parent.
2120 * cs-parser.jay (interface_member_declaration): Add things to the
2121 `current_container', not the `current_class'.
2123 * rootcontext.cs (RegisterOrder): The overloaded version which
2124 takes an `Interface' was unused, removed.
2126 * typemanager.cs (TypeManager.LookupInterface): Return a
2127 `TypeContainer', not an `Interface'.
2128 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2129 contain a `PartialContainer' for an interface, so check it's
2130 `Kind' to figure out what it is.
2132 2004-07-25 Martin Baulig <martin@ximian.com>
2134 * class.cs (Class.DefaultTypeAttributes): New public constant.
2135 (Struct.DefaultTypeAttributes): Likewise.
2136 (Interface.DefaultTypeAttributes): Likewise.
2137 (PartialContainer.TypeAttr): Override this and add the
2138 DefaultTypeAttributes.
2140 2004-07-25 Martin Baulig <martin@ximian.com>
2142 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2143 we can just use the `Parent' field instead.
2145 2004-07-25 Martin Baulig <martin@ximian.com>
2147 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2149 2004-07-25 Martin Baulig <martin@ximian.com>
2151 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2152 our parts before defining any methods.
2153 (TypeContainer.VerifyImplements): Make this virtual.
2154 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2155 on our PartialContainer.
2157 2004-07-25 Martin Baulig <martin@ximian.com>
2159 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2161 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2162 argument, we can just use the `Parent' field instead.
2165 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2166 (MemberBase.DoDefine): Likewise.
2168 2004-07-24 Martin Baulig <martin@ximian.com>
2170 * decl.cs (MemberCore.Parent): New public field.
2171 (DeclSpace.Parent): Moved to MemberCore.
2173 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2174 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2176 (FieldBase, Field, Operator): Likewise.
2177 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2178 (EventField, Event): Likewise.
2180 2004-07-23 Martin Baulig <martin@ximian.com>
2182 * class.cs (PartialContainer): New public class.
2183 (ClassPart): New public class.
2184 (TypeContainer): Added support for partial classes.
2185 (TypeContainer.GetClassBases): Splitted some of the functionality
2186 out into GetNormalBases() and GetPartialBases().
2188 * cs-tokenizer.cs (Token.PARTIAL): New token.
2189 (Tokenizer.consume_identifier): Added some hacks to recognize
2190 `partial', but only if it's immediately followed by `class',
2191 `struct' or `interface'.
2193 * cs-parser.jay: Added support for partial clases.
2195 2004-07-23 Martin Baulig <martin@ximian.com>
2197 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2198 a `DeclSpace' and also made it readonly.
2199 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2200 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2201 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2203 * cs-parser.jay: Pass the `current_class', not the
2204 `current_container' (at the moment, this is still the same thing)
2205 to a new Method, Property, Event, Indexer or Constructor.
2207 2004-07-23 Martin Baulig <martin@ximian.com>
2209 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2210 and removed the `current_interface' one.
2211 (struct_declaration, class_declaration, interface_declaration):
2212 Set `current_class' to the newly created class/struct/interface;
2213 set their `Bases' and call Register() before parsing their body.
2215 2004-07-23 Martin Baulig <martin@ximian.com>
2217 * class.cs (Kind): New public enum.
2218 (TypeContainer): Made this class abstract.
2219 (TypeContainer.Kind): New public readonly field.
2220 (TypeContainer.CheckDef): New public method; moved here from
2222 (TypeContainer.Register): New public abstract method.
2223 (TypeContainer.GetPendingImplementations): New public abstract
2225 (TypeContainer.GetClassBases): Removed the `is_class' and
2226 `is_iface' parameters.
2227 (TypeContainer.DefineNestedTypes): Formerly known as
2229 (ClassOrStruct): Made this class abstract.
2231 * tree.cs (RootTypes): New public type.
2233 2004-07-20 Martin Baulig <martin@ximian.com>
2235 * tree.cs (Tree.RecordNamespace): Removed.
2236 (Tree.Namespaces): Removed.
2238 * rootcontext.cs (RootContext.IsNamespace): Removed.
2240 * cs-parser.jay (namespace_declaration): Just create a new
2241 NamespaceEntry here.
2243 2004-07-20 Martin Baulig <martin@ximian.com>
2245 * statement.cs (ExceptionStatement): New abstract class. This is
2246 now used as a base class for everyone who's using `finally'.
2247 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2248 our local variables before using them.
2250 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2251 virtual method. This is used by Yield.Resolve() to "steal" an
2252 outer block's `finally' clauses.
2253 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2256 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2257 version which takes an ExceptionStatement. This version must be
2258 used to create exception branchings.
2261 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2262 (Iterator.EmitMoveNext): Added exception support; protect the
2263 block with a `fault' clause, properly handle 'finally' clauses.
2264 (Iterator.EmitDispose): Run all the `finally' clauses here.
2266 2004-07-20 Martin Baulig <martin@ximian.com>
2268 * iterator.cs: This is the first of a set of changes in the
2269 iterator code. Match the spec more closely: if we're an
2270 IEnumerable, then GetEnumerator() must be called. The first time
2271 GetEnumerator() is called, it returns the current instance; all
2272 subsequent invocations (if any) must create a copy.
2274 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2276 * expression.cs: Resolve the constant expression before returning
2279 2004-07-19 Martin Baulig <martin@ximian.com>
2281 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2282 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2283 the return type of the new EmitContext.
2285 2004-07-18 Martin Baulig <martin@ximian.com>
2287 * class.cs (Property.Define): Fix iterators.
2289 * iterators.cs (Iterator.Define): Moved the
2290 `container.AddInterator (this)' call here from the .ctor; only do
2291 it if we resolved successfully.
2293 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2295 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2296 `true' for preprocessing directives that we parse. The return
2297 value indicates whether we should return to regular tokenizing or
2298 not, not whether it was parsed successfully.
2300 In the past if we were in: #if false ... #line #endif, we would
2301 resume parsing after `#line'. See bug 61604.
2303 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2304 building: IsEnumType should return true only for enums, not for
2305 enums or System.Enum itself. This fixes #61593.
2307 Likely what happened is that corlib was wrong: mcs depended on
2308 this bug in some places. The bug got fixed, we had to add the
2309 hack, which caused bug 61593.
2311 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2312 that was a workaround for the older conditions.
2314 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2316 * assign.cs: IAssignMethod has a new interface, as documented
2317 inline. All assignment code now uses this new api.
2319 * ecore.cs, expression.cs: All classes which implement
2320 IAssignMethod now use the new interface.
2322 * expression.cs (Invocation): add a hack to EmitCall so that
2323 IndexerAccess can be the target of a compound assignment without
2324 evaluating its arguments twice.
2326 * statement.cs: Handle changes in Invocation api.
2328 2004-07-16 Martin Baulig <martin@ximian.com>
2330 * iterators.cs: Rewrote this. We're now using one single Proxy
2331 class for both the IEnumerable and the IEnumerator interface and
2332 `Iterator' derives from Class so we can use the high-level API.
2334 * class.cs (TypeContainer.AddIterator): New method.
2335 (TypeContainer.DoDefineType): New protected virtual method, which
2336 is called from DefineType().
2337 (TypeContainer.DoDefineMembers): Call DefineType() and
2338 DefineMembers() on all our iterators.
2339 (TypeContainer.Emit): Call Emit() on all our iterators.
2340 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2342 * codegen.cs (EmitContext.CurrentIterator): New public field.
2344 2004-07-15 Martin Baulig <martin@ximian.com>
2347 (TypeManager.not_supported_exception_type): New type.
2349 2004-07-14 Martin Baulig <martin@ximian.com>
2351 * iterators.cs: Use real error numbers.
2353 2004-07-14 Martin Baulig <martin@ximian.com>
2355 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2356 requires this to be a System.Collection.IEnumerable and not a
2357 class implementing that interface.
2358 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2360 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2362 * class.cs: Fixed previous fix, it broke some error tests.
2364 2004-07-12 Martin Baulig <martin@ximian.com>
2366 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2369 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2371 * assign.cs (LocalTemporary): Add new argument: is_address,If
2372 `is_address' is true, then the value that we store is the address
2373 to the real value, and not the value itself.
2375 * ecore.cs (PropertyExpr): use the new local temporary
2376 stuff to allow us to handle X.Y += z (where X is a struct)
2378 2004-07-08 Martin Baulig <martin@ximian.com>
2380 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2381 not always return, just like we're doing in Using.Resolve().
2383 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2385 * cs-parser.jay (fixed_statement): flag this as Pinned.
2387 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2389 * typemanager.cs (TypeManager): Removed MakePinned method, this
2390 mechanism is replaced with the .NET 2.x compatible mechanism of
2391 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2393 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2394 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2395 `IsFixed' property which has a different meaning.
2397 2004-07-02 Raja R Harinath <rharinath@novell.com>
2399 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2400 visible from inside a nested class, not just the names of the
2401 immediately enclosing class.
2404 2004-06-24 Raja R Harinath <rharinath@novell.com>
2406 * expression.cs (BetterConversion): Remove buggy special-case
2407 handling of "implicit constant expression conversions". At this
2408 point, we already know that the conversion is possible -- we're
2409 only checking to see which is better.
2411 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2413 * cs-parser.jay: Added error CS0210 test.
2415 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2417 * cs-parser.jay: Added error CS0134 test.
2419 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2422 * cs-parser.jay: Added error CS0145 test.
2424 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2426 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2428 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2430 * expression.cs (StackAlloc.Resolve): The argument may not
2431 be a constant; deal with this case.
2433 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2435 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2436 GetIndexerAttributeValue.
2437 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2439 * class.cs (Indexer.Define): Added error tests for CS0415,
2442 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2444 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2447 2004-06-23 Martin Baulig <martin@ximian.com>
2449 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2450 neither return nor throw, reset the barrier as well. Fixes #60457.
2452 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2454 * class.cs : EventAttributes is now set to None by default.
2455 This fixes bug #60459.
2457 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2460 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2461 Don't throw exception but return null (it's sufficient now).
2463 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2465 * typemanager.cs (GetArgumentTypes): Faster implementation.
2467 2004-06-18 Martin Baulig <martin@ximian.com>
2469 * attribute.cs (Attribute.Resolve): Check whether we're an
2470 EmptyCast which a Constant child. Fixes #60333.
2472 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2474 * statement.cs (EmitCollectionForeach): Account for the fact that
2475 not all valuetypes are in areas which we can take the address of.
2476 For these variables, we store to a temporary variable. Also, make
2477 sure that we dont emit a `callvirt' on a valuetype method.
2479 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2481 * expression.cs (StackAlloc.DoReSolve): Added test for
2482 negative parameter (CS0247).
2484 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2487 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2489 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2492 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2495 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2497 Fix bug #58254 & cs1555.cs, cs1556.cs
2498 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2500 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2502 * cs-parser.jay: Added error CS1669 test for indexers.
2504 2004-06-11 Martin Baulig <martin@ximian.com>
2506 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2507 call this twice: for params and varargs methods.
2509 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2512 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2514 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2516 * attribute.cs (Attribute.GetValidTargets): Made public.
2519 (AbstractPropertyEventMethod): New class for better code sharing.
2520 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2522 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2524 2004-06-11 Raja R Harinath <rharinath@novell.com>
2527 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
2528 that the call to Resolve is part of a MemberAccess.
2529 (Expression.Resolve): Use it for SimpleName resolution.
2530 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
2531 Add 'intermediate' boolean argument.
2532 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
2533 error message when the SimpleName can be resolved ambiguously
2534 between an expression and a type.
2535 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
2537 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
2538 call on the left-side.
2540 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2543 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
2545 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2547 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
2549 2004-06-11 Martin Baulig <martin@ximian.com>
2551 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
2552 varargs methods if applicable.
2554 2004-06-11 Martin Baulig <martin@ximian.com>
2556 * expression.cs (Invocation.EmitCall): Don't use
2557 `method.CallingConvention == CallingConventions.VarArgs' since the
2558 method could also have `CallingConventions.HasThis'.
2560 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2562 * class.cs (Event.GetSignatureForError): Implemented.
2563 Fixed crash in error test cs3010.cs
2565 2004-06-10 Miguel de Icaza <miguel@ximian.com>
2567 * cs-tokenizer.cs: Change the way we track __arglist to be
2568 consistent with the other keywords.
2570 2004-06-09 Miguel de Icaza <miguel@ximian.com>
2572 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
2575 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
2577 * codegen.cs: Check that all referenced assemblies have a strongname
2578 before strongnaming the compiled assembly. If not report error CS1577.
2579 Fix bug #56563. Patch by Jackson Harper.
2580 * typemanager.cs: Added a method to return all referenced assemblies.
2581 Fix bug #56563. Patch by Jackson Harper.
2583 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2586 (Method.ApplyAttributeBuilder): Moved and added conditional
2587 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
2590 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
2592 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2595 * class.cs: (EventField.attribute_targets): Changed default target.
2597 2004-06-08 Martin Baulig <martin@ximian.com>
2599 * expression.cs (Invocation.EmitCall): Enable varargs methods.
2601 2004-06-08 Martin Baulig <martin@ximian.com>
2603 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
2605 2004-06-07 Martin Baulig <martin@ximian.com>
2607 Added support for varargs methods.
2609 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
2612 * cs-parser.jay: Added support for `__arglist'.
2614 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
2616 * expression.cs (Argument.AType): Added `ArgList'.
2617 (Invocation): Added support for varargs methods.
2618 (ArglistAccess): New public class.
2619 (Arglist): New public class.
2621 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
2623 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
2624 a method's top-level block if the method has varargs.
2626 * support.cs (ReflectionParameters, InternalParameters): Added
2627 support for varargs methods.
2629 2004-06-07 Miguel de Icaza <miguel@ximian.com>
2631 * class.cs: Provide location in indexer error report.
2633 * driver.cs: Use standard names.
2635 * namespace.cs: Catch the use of using after a namespace has been
2636 declared also on using aliases.
2638 2004-06-03 Raja R Harinath <rharinath@novell.com>
2641 * typemanager.cs (closure_private_ok, closure_invocation_type)
2642 (closure_qualifier_type, closure_invocation_assembly)
2643 (FilterWithClosure): Move to ...
2644 (Closure): New internal nested class.
2645 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
2646 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
2647 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
2648 (MemberLookup, MemberLookupFailed): Use it.
2649 * expression.cs (New.DoResolve): Treat the lookup for the
2650 constructor as being qualified by the 'new'ed type.
2651 (Indexers.GetIndexersForTypeOrInterface): Update.
2653 2004-06-03 Marek Safar <marek.safar@seznam.cz>
2656 (GetConditionalAttributeValue): New method. Returns
2657 condition of ConditionalAttribute.
2658 (SearchMulti): New method. Returns all attributes of type 't'.
2659 Use it when attribute is AllowMultiple = true.
2660 (IsConditionalMethodExcluded): New method.
2663 (Method.IsExcluded): Implemented. Returns true if method has conditional
2664 attribute and the conditions is not defined (method is excluded).
2665 (IMethodData): Extended interface for ConditionalAttribute support.
2666 (PropertyMethod.IsExcluded): Implemented.
2669 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
2672 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
2675 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
2677 * expression.cs (ArrayCreationExpression): Make this just an
2678 `expression'. It can't be a statement, so the code here was
2681 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2684 * typemanager.cs (GetFullNameSignature): New method for
2687 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2690 * class.cs (MemberBase.GetSignatureForError): New virtual method.
2691 Use this method when MethodBuilder is null.
2692 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
2693 Added test for error CS0626 (MONO reports error for this situation).
2694 (IMethodData.GetSignatureForError): Extended interface.
2696 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2699 (AttributeTester.GetObsoleteAttribute): Returns instance of
2700 ObsoleteAttribute when type is obsolete.
2703 (TypeContainer.VerifyObsoleteAttribute): Override.
2704 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2705 (MethodCode.VerifyObsoleteAttribute): Override.
2706 (MemberBase.VerifyObsoleteAttribute): Override.
2709 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2710 and report proper error.
2713 Delegate.VerifyObsoleteAttribute): Override.
2716 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2717 and report proper error.
2718 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2721 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2725 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2726 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2727 Added test for ObsoleteAttribute.
2730 (Catch): Derived from Statement.
2732 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2734 Fixed bug #59071 & cs0160.cs
2736 * statement.cs (Try.Resolve): Check here whether order of catch
2737 clauses matches their dependencies.
2739 2004-05-31 Miguel de Icaza <miguel@ximian.com>
2741 * Reverted patch to namespace.cs (Use lookuptypedirect). This
2742 caused a regression: #59343. Referencing nested classes from an
2743 assembly stopped working.
2745 2004-05-31 Martin Baulig <martin@ximian.com>
2747 MCS is now frozen for beta 2.
2749 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2751 * convert.cs: add a trivial cache for overload operator resolution.
2753 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2755 * decl.cs: If possible, use lookuptypedirect here. We can only do
2756 this if there is no `.' after the namespace. Avoids using
2757 LookupType, which does lots of slow processing.
2758 (FindNestedType) New method, does what it says :-).
2759 * namespace.cs: use LookupTypeDirect.
2760 * rootcontext.cs: use membercache, if possible.
2761 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2763 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2766 According to the spec,
2768 In a member access of the form E.I, if E is a single identifier,
2769 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2770 field, property, localvariable, or parameter with the same type as
2771 the meaning of E as a type-name (§3.8), then both possible
2772 meanings of E are permitted.
2774 We did not check that E as a simple-name had the same type as E as
2777 This trivial check gives us 5-7% on bootstrap time.
2779 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2781 * expression.cs (Invocation.OverloadResolve): Avoid the
2782 use of hashtables and boxing here by allocating on demand.
2784 2004-05-30 Martin Baulig <martin@ximian.com>
2786 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2787 we're doing a silent lookup. Don't try to lookup nested types in
2788 TypeManager.object_type (thanks to Ben Maurer).
2790 2004-05-30 Martin Baulig <martin@ximian.com>
2792 Committing a patch from Ben Maurer.
2794 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2796 2004-05-29 Martin Baulig <martin@ximian.com>
2798 * class.cs (IMethodData.ShouldIgnore): New method.
2800 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2801 `Location' argument, we don't need it anywhere. Use
2802 `IMethodData.ShouldIgnore ()' instead of
2803 `MethodData.GetMethodFlags ()'.
2804 (TypeManager.AddMethod): Removed.
2805 (TypeManager.AddMethod2): Renamed to AddMethod.
2807 2004-05-29 Martin Baulig <martin@ximian.com>
2809 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2811 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2812 converting from a class type S to an interface type and we already
2813 have an object on the stack, don't box it again. Fixes #52578.
2815 2004-05-29 Martin Baulig <martin@ximian.com>
2817 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2818 Added support for `params' parameters. Fixes #59267.
2820 2004-05-29 Martin Baulig <martin@ximian.com>
2822 * literal.cs (NullPointer): Provide a private .ctor which sets
2823 `type' to TypeManager.object_type. Fixes #59048.
2825 2004-05-29 Martin Baulig <martin@ximian.com>
2827 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2828 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2830 * ecore.cs (EventExpr.instance_expr): Make the field private.
2832 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2834 Fixed bug #50080 & cs0214-2.cs
2835 * expression.cs (Cast.DoResolve): Check unsafe context here.
2837 * statement.cs (Resolve.DoResolve): Likewise.
2839 2004-05-26 Martin Baulig <martin@ximian.com>
2841 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2843 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2844 (RootContext.LookupType): Pass down the `silent' flag.
2846 2004-05-25 Martin Baulig <martin@ximian.com>
2849 (MethodGroupExpr.IdenticalTypeName): New public property.
2850 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2851 expression actually refers to a type.
2853 2004-05-25 Martin Baulig <martin@ximian.com>
2855 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2856 for #56176 and made it actually work.
2858 2004-05-25 Martin Baulig <martin@ximian.com>
2860 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2861 (FieldExpr, PropertyExpr): Override and implement
2862 CacheTemporaries. Fixes #52279.
2864 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2866 * location.cs: In the new compiler listing a file twice is a
2867 warning, not an error.
2869 2004-05-24 Martin Baulig <martin@ximian.com>
2871 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2872 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2874 2004-05-24 Martin Baulig <martin@ximian.com>
2876 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2877 walking the `using' list. Fixes #53921.
2879 2004-05-24 Martin Baulig <martin@ximian.com>
2881 * const.cs (Const.LookupConstantValue): Added support for
2882 EmptyCast's; fixes #55251.
2884 2004-05-24 Martin Baulig <martin@ximian.com>
2886 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2887 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2888 which does the CS0135 check. The reason is that we first need to
2889 check whether the variable actually exists.
2891 2004-05-24 Martin Baulig <martin@ximian.com>
2893 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2894 than RootContext.LookupType() to find the explicit interface
2897 2004-05-24 Raja R Harinath <rharinath@novell.com>
2899 * Makefile: Simplify. Use executable.make.
2900 * mcs.exe.sources: New file. List of sources of mcs.exe.
2902 2004-05-24 Anders Carlsson <andersca@gnome.org>
2906 Use the invariant culture when doing String.Compare for CLS case
2909 2004-05-23 Martin Baulig <martin@ximian.com>
2911 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2912 don't have any dots. Fixes #52622, added cs0246-8.cs.
2914 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2916 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2918 * class.cs (MemberBase.Define): Reuse MemberType member for
2919 resolved type. Other methods can use it too.
2921 2004-05-23 Martin Baulig <martin@ximian.com>
2923 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2924 the variable also exists in the current block (otherwise, we need
2925 to report a CS0103). Fixes #58670.
2927 2004-05-23 Martin Baulig <martin@ximian.com>
2929 * flowanalysis.cs (Reachability.Reachable): Compute this
2930 on-the-fly rather than storing it as a field.
2932 2004-05-23 Martin Baulig <martin@ximian.com>
2934 * flowanalysis.cs (Reachability.And): Manually compute the
2935 resulting `barrier' from the reachability.
2937 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2940 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2941 instance of ObsoleteAttribute when symbol is obsolete.
2944 (IMethodData): Extended interface for ObsoleteAttribute support.
2946 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2948 * attribute.cs: Fix bug #55970
2950 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2954 (GetObsoleteAttribute): New method. Creates the instance of
2956 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2957 ObsoleteAttribute when member is obsolete.
2958 (AttributeTester.Report_ObsoleteMessage): Common method for
2959 Obsolete error/warning reporting.
2962 (TypeContainer.base_classs_type): New member for storing parent type.
2965 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2966 for this MemberCore.
2968 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2970 * attribute.cs, const.cs: Fix bug #58590
2972 2004-05-21 Martin Baulig <martin@ximian.com>
2974 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2975 out parameters if the end of the method is unreachable. Fixes
2978 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2980 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2981 Hari was right, why extra method.
2983 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2985 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2987 2004-05-20 Martin Baulig <martin@ximian.com>
2989 Merged this back from gmcs to keep the differences to a minumum.
2991 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
2992 instead of a Declspace.
2993 (Attribute.ResolveType): Likewise.
2994 (Attributes.Search): Likewise.
2995 (Attributes.Contains): Likewise.
2996 (Attributes.GetClsCompliantAttribute): Likewise.
2998 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
3000 (MethodData.ApplyAttributes): Take an EmitContext instead of a
3003 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3005 Fix bug #58688 (MCS does not report error when the same attribute
3008 * attribute.cs (Attribute.Emit): Distinction between null and default.
3010 2004-05-19 Raja R Harinath <rharinath@novell.com>
3012 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3013 of a top-level attribute without an attribute target.
3014 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3016 (Attribute.Conditional_GetConditionName),
3017 (Attribute.Obsolete_GetObsoleteMessage): Update.
3018 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3019 part of ScanForIndexerName.
3020 (Attribute.CanIgnoreInvalidAttribute): New function.
3021 (Attribute.ScanForIndexerName): Move to ...
3022 (Attributes.ScanForIndexerName): ... here.
3023 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3024 (Attributes.Search): New internal variant that can choose not to
3025 complain if types aren't resolved. The original signature now
3027 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3028 complaints suppressed.
3029 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3030 only if it not useful.
3031 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3032 top-level for attributes that are shared between the assembly
3033 and a top-level class.
3034 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3035 * class.cs: Update to reflect changes.
3036 (DefineIndexers): Fuse loops.
3037 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3038 a couple more variants of attribute names.
3040 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3042 Fix bug #52585 (Implemented explicit attribute declaration)
3045 (Attributable.ValidAttributeTargets): New abstract method. It gets
3046 list of valid attribute targets for explicit target declaration.
3047 (Attribute.Target): It holds target itself.
3048 (AttributeSection): Removed.
3049 (Attribute.CheckTargets): New method. It checks whether attribute
3050 target is valid for the current element.
3053 (EventProperty): New class. For events that are declared like
3054 property (with add and remove accessors).
3055 (EventField): New class. For events that are declared like field.
3058 * cs-parser.jay: Implemented explicit attribute target declaration.
3060 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3061 Override ValidAttributeTargets.
3064 (ReturnParameter): Class for applying custom attributes on
3066 (ParameterAtribute): New class. Class for applying custom
3067 attributes on the parameter type.
3069 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3071 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3074 (Method): Allow UNSAFE here.
3076 * modifiers.cs: Support unsafe reporting.
3078 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3080 * decl.cs: Fix bug #58478.
3082 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3084 * statement.cs: When checking for unreachable code on an EmptyStatement,
3085 set the location. Fixes bug #58488.
3087 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3089 * driver.cs: Add -pkg handling.
3091 From Gonzalo: UseShelLExecute=false
3093 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3096 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3098 (Attribute.IsClsCompliaceRequired): Moved to base for better
3100 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3101 when attribute is AttributeUsageAttribute.
3102 (Attribute.GetValidTargets): Simplified.
3103 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3104 attribute for this type.
3105 (Attribute.ApplyAttributes): Method renamed to Emit and make
3107 (GlobalAttributeSection): New class for special handling of global
3108 attributes (assembly, module).
3109 (AttributeSection.Emit): New method.
3111 * class.cs: Implemented Attributable abstract methods.
3112 (MethodCore.LabelParameters): Moved to Parameter class.
3113 (Accessor): Is back simple class.
3114 (PropertyMethod): Implemented Attributable abstract class.
3115 (DelegateMethod): Implemented Attributable abstract class.
3116 (Event): New constructor for disctintion between normal Event
3117 and Event with accessors.
3119 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3121 * codegen.cs, const.cs, decl.cs, delegate.cs:
3122 (CommonAssemblyModulClass): Implemented Attributable abstract class
3125 * enum.cs: Implement IAttributeSupport interface.
3126 (EnumMember): New class for emum members. Implemented Attributable
3130 (ParameterBase): Is abstract.
3131 (ReturnParameter): New class for easier [return:] attribute handling.
3133 * typemanager.cs: Removed builder_to_attr.
3135 2004-05-11 Raja R Harinath <rharinath@novell.com>
3138 * attribute.cs (Attribute.GetPositionalValue): New function.
3139 * class.cs (TypeContainer.VerifyMembers): New function.
3140 (TypeContainer.Emit): Use it.
3141 (ClassOrStruct): New base class for Class and Struct.
3142 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3143 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3145 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3146 then each non-static field should have a FieldOffset attribute.
3147 Otherwise, none of the fields should have a FieldOffset attribute.
3148 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3149 and FieldOffset attributes.
3150 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3151 (TypeManager.field_offset_attribute_type): New core types.
3152 (TypeManager.InitCoreTypes): Initialize them.
3154 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3156 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3157 Return correct type.
3160 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3162 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3163 be implicitly converted to ulong.
3165 * expression.cs: The logic for allowing operator &, | and ^ worked
3166 was wrong, it worked before because we did not report an error in
3167 an else branch. Fixes 57895.
3169 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3170 allow volatile fields to be reference types.
3172 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3174 * driver.cs: Add support for /debug-
3176 2004-05-07 Raja R Harinath <rharinath@novell.com>
3178 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3179 Add a 'complain' parameter to silence errors.
3180 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3181 silently overlooked type-resolutions.
3182 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3184 (Attributes.Search): New function.
3185 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3186 (Attributes.GetAttributeFullName): Remove hack.
3187 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3188 Update to reflect changes.
3189 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3190 Use Attributes.Search instead of nested loops.
3192 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3195 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3196 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3197 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3199 * report.cs: (Report.Warning): Renamed to Warning_T because of
3200 parameter collision.
3202 2004-05-05 Raja R Harinath <rharinath@novell.com>
3204 * expression.cs (MemberAccess.ResolveMemberAccess):
3205 Exit with non-zero status after Report.Error.
3206 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3208 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3210 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3212 * support.cs: Don't hang when the file is empty.
3214 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3216 * support.cs: In SeekableStreamReader, compute the preamble size of the
3217 underlying stream. Position changes should take into account that initial
3220 2004-05-03 Todd Berman <tberman@sevenl.net>
3222 * driver.cs: remove unused GetSysVersion function.
3224 2004-05-03 Todd Berman <tberman@sevenl.net>
3226 * driver.cs: Remove the hack from saturday, as well as the hack
3227 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3228 link_paths to get that bit proper.
3230 2004-05-01 Todd Berman <tberman@sevenl.net>
3232 * driver.cs: Try a LoadFrom before a Load, this checks the current
3233 path. This is currently a bug in mono that is be fixed, however, this
3234 provides a workaround for now. This will be removed when the bug
3237 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3239 * CryptoConvert.cs: Updated to latest version. Fix issue with
3240 incomplete key pairs (#57941).
3242 2004-05-01 Todd Berman <tberman@sevenl.net>
3244 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3247 2004-04-30 Jackson Harper <jackson@ximian.com>
3249 * codegen.cs: Open keys readonly.
3251 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3253 * typemanager.cs: don't report cyclic struct layout when a struct
3254 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3255 which has 2 Pango.Rectangle fields.
3257 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3259 * expression.cs: Handle IntPtr comparisons with IL code
3260 rather than a method call.
3262 2004-04-29 Martin Baulig <martin@ximian.com>
3264 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3265 the list of PropertyInfo's in class hierarchy and find the
3266 accessor. Fixes #56013.
3268 2004-04-29 Martin Baulig <martin@ximian.com>
3270 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3272 2004-04-29 Martin Baulig <martin@ximian.com>
3274 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3276 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3278 2004-04-29 Martin Baulig <martin@ximian.com>
3280 * class.cs (ConstructorInitializer.Resolve): Check whether the
3281 parent .ctor is accessible. Fixes #52146.
3283 2004-04-29 Martin Baulig <martin@ximian.com>
3285 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3287 * statement.cs (Using.EmitLocalVariableDecls): Use
3288 TypeManager.idisposable_type, not typeof (IDisposable).
3289 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3291 2004-04-29 Martin Baulig <martin@ximian.com>
3293 * class.cs (Event.Define): Don't emit the field and don't set
3294 RTSpecialName and SpecialName for events on interfaces. Fixes
3297 2004-04-29 Raja R Harinath <rharinath@novell.com>
3299 Refactor Attribute.ApplyAttributes.
3300 * attribute.cs (Attributable): New base class for objects that can
3301 have Attributes applied on them.
3302 (Attribute): Make AttributeUsage fields public.
3303 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3304 (Attribute.IsInternalCall): New property.
3305 (Attribute.UsageAttr): Convert to a public read-only property.
3306 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3307 (Attribute.ResolveType, Attribute.Resolve)
3308 (Attribute.ScanForIndexerName): Update to reflect changes.
3309 (Attribute.CheckAttributeTarget): Re-format.
3310 (Attribute.ApplyAttributes): Refactor, to various
3311 Attributable.ApplyAttributeBuilder methods.
3312 * decl.cs (MemberCore): Make Attributable.
3313 * class.cs (Accessor): Make Attributable.
3314 (MethodData.ApplyAttributes): Use proper attribute types, not
3316 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3317 (TypeContainer.ApplyAttributeBuilder)
3318 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3319 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3320 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3321 (Operator.ApplyAttributeBuilder): New factored-out methods.
3322 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3323 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3324 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3325 * parameter.cs (ParameterBase): New Attributable base class
3326 that can also represent Return types.
3327 (Parameter): Update to the changes.
3329 2004-04-29 Jackson Harper <jackson@ximian.com>
3331 * driver.cs: Prefer the corlib system version when looking for
3332 assemblies in the GAC. This is still a hack, but its a better hack
3335 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3337 * decl.cs, enum.cs: Improved error 3005 reporting.
3339 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3340 (related_symbols): New private member for list of symbols
3341 related to reported error/warning.
3343 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3345 2004-04-29 Martin Baulig <martin@ximian.com>
3347 * ecore.cs (Expression.Constantify): If we're an enum and
3348 TypeManager.TypeToCoreType() doesn't give us another type, use
3349 t.UnderlyingSystemType. Fixes #56178.
3351 2004-04-29 Martin Baulig <martin@ximian.com>
3353 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3354 interfaces and for each interface, only add members directly
3355 declared in that interface. Fixes #53255.
3357 2004-04-28 Martin Baulig <martin@ximian.com>
3359 * expression.cs (ConditionalLogicalOperator): Use a temporary
3360 variable for `left' to avoid that we evaluate it more than once;
3363 2004-04-28 Martin Baulig <martin@ximian.com>
3365 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3368 2004-04-28 Martin Baulig <martin@ximian.com>
3370 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3373 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3374 whether the type is not void (CS1547).
3376 2004-04-28 Martin Baulig <martin@ximian.com>
3378 * expression.cs (Unary.DoResolveLValue): Override this and report
3379 CS0131 for anything but Operator.Indirection.
3381 2004-04-28 Martin Baulig <martin@ximian.com>
3383 Committing a patch from Ben Maurer; see bug #50820.
3385 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3388 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3391 2004-04-28 Martin Baulig <martin@ximian.com>
3393 Committing a patch from Ben Maurer; see bug #50820.
3395 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3398 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3401 2004-04-28 Martin Baulig <martin@ximian.com>
3403 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3404 (Block.AddLabel): Call DoLookupLabel() to only search in the
3407 2004-04-28 Martin Baulig <martin@ximian.com>
3409 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3410 comparing StringConstants and NullLiterals in Equality and Inequality.
3412 2004-04-28 Jackson Harper <jackson@ximian.com>
3414 * driver.cs: Attempt to load referenced assemblies from the
3415 GAC. This is the quick and dirty version of this method that
3416 doesnt take into account versions and just takes the first
3417 canidate found. Will be good enough for now as we will not have more
3418 then one version installed into the GAC until I update this method.
3420 2004-04-28 Martin Baulig <martin@ximian.com>
3422 * typemanager.cs (TypeManager.CheckStructCycles): New public
3423 static method to check for cycles in the struct layout.
3425 * rootcontext.cs (RootContext.PopulateTypes): Call
3426 TypeManager.CheckStructCycles() for each TypeContainer.
3427 [Note: We only need to visit each type once.]
3429 2004-04-28 Martin Baulig <martin@ximian.com>
3431 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3433 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3434 success and added `out object value'. Use a `bool resolved' field
3435 to check whether we've already been called rather than
3436 `ConstantValue != null' since this breaks for NullLiterals.
3438 2004-04-28 Raja R Harinath <rharinath@novell.com>
3440 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3441 setting of this flag, since the 'set' method may be non-public.
3443 2004-04-28 Raja R Harinath <rharinath@novell.com>
3445 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3446 check on current_vector.Block.
3448 2004-04-27 Martin Baulig <martin@ximian.com>
3450 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3451 a field initializer. Fixes #56459.
3453 2004-04-27 Martin Baulig <martin@ximian.com>
3455 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3456 we're not attempting to use an indexer. Fixes #52154.
3458 2004-04-27 Martin Baulig <martin@ximian.com>
3460 * statement.cs (Return): Don't create a return label if we don't
3461 need it; reverts my change from January 20th. Thanks to Ben
3464 2004-04-27 Martin Baulig <martin@ximian.com>
3466 According to the spec, `goto' can only leave a nested scope, but
3469 * statement.cs (Block.LookupLabel): Only lookup in the current
3470 block, don't recurse into parent or child blocks.
3471 (Block.AddLabel): Check in parent and child blocks, report
3472 CS0140/CS0158 if we find a duplicate.
3473 (Block): Removed this indexer for label lookups.
3474 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3475 this already does the error reporting for us.
3478 (FlowBranching.UsageVector.Block): New public variable; may be null.
3479 (FlowBranching.CreateSibling): Added `Block' argument.
3480 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3481 label for the target of a `goto' and check whether we're not
3482 leaving a `finally'.
3484 2004-04-27 Martin Baulig <martin@ximian.com>
3486 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3487 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3490 2004-04-27 Martin Baulig <martin@ximian.com>
3492 * statement.cs (Block.AddLabel): Also check for implicit blocks
3493 and added a CS0158 check.
3495 2004-04-27 Martin Baulig <martin@ximian.com>
3497 * flowanalysis.cs (FlowBranchingLoop): New class.
3498 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3499 UsageVector's instead of an ArrayList.
3500 (FlowBranching.Label): Likewise.
3501 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3502 (FlowBranching.AddBreakVector): New method.
3504 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3506 * attribute.cs: Small regression fix: only convert the type if we
3507 the type is different, fixes System.Drawing build.
3509 2004-04-27 Martin Baulig <martin@ximian.com>
3511 * attribute.cs (Attribute.Resolve): If we have a constant value
3512 for a named field or property, implicity convert it to the correct
3515 2004-04-27 Raja R Harinath <rharinath@novell.com>
3517 * statement.cs (Block.Block): Implicit blocks share
3518 'child_variable_names' fields with parent blocks.
3519 (Block.AddChildVariableNames): Remove.
3520 (Block.AddVariable): Mark variable as "used by a child block" in
3521 every surrounding block.
3522 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3523 been used in a child block, complain about violation of "Invariant
3524 meaning in blocks" rule.
3525 * cs-parser.jay (declare_local_variables): Don't use
3526 AddChildVariableNames.
3527 (foreach_statement): Don't create an implicit block: 'foreach'
3530 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3532 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3533 converting from 0L to ulong. Fixes 57522.
3535 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3537 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3538 derived class hides via 'new' keyword field from base class (test-242.cs).
3539 TODO: Handle this in the more general way.
3541 * class.cs (CheckBase): Ditto.
3543 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3545 * decl.cs (caching_flags): New member for storing cached values
3547 (MemberCore.Flags): New enum where bit flags for caching_flags
3549 (MemberCore.cls_compliance): Moved to caching_flags.
3550 (DeclSpace.Created): Moved to caching_flags.
3552 * class.cs: Use caching_flags instead of DeclSpace.Created
3554 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3556 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3557 if we are only a derived class, not a nested class.
3559 * typemanager.cs: Same as above, but do this at the MemberLookup
3560 level (used by field and methods, properties are handled in
3561 PropertyExpr). Allow for the qualified access if we are a nested
3564 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3566 * class.cs: Refactoring.
3567 (IMethodData): New inteface; Holds links to parent members
3568 to avoid member duplication (reduced memory allocation).
3569 (Method): Implemented IMethodData interface.
3570 (PropertyBase): New inner classes for get/set methods.
3571 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3572 (Event): New inner classes for add/remove methods.
3573 (Event.DelegateMethod): Implemented IMethodData interface.
3575 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3576 EmitContext (related to class.cs refactoring).
3578 2004-04-21 Raja R Harinath <rharinath@novell.com>
3580 * delegate.cs (Delegate.VerifyApplicability): If the number of
3581 arguments are the same as the number of parameters, first try to
3582 verify applicability ignoring any 'params' modifier on the last
3586 2004-04-16 Raja R Harinath <rharinath@novell.com>
3588 * class.cs (TypeContainer.AddIndexer): Use
3589 'ExplicitInterfaceName' to determine if interface name was
3590 explicitly specified. 'InterfaceType' is not initialized at this time.
3591 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3592 Indexers array is already in the required order. Initialize
3593 'IndexerName' only if there are normal indexers.
3594 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3595 (TypeContainer.Emit): Emit DefaultMember attribute only if
3596 IndexerName is initialized.
3599 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3601 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3604 2004-04-15 Raja R Harinath <rharinath@novell.com>
3606 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3610 * attribute.cs (Attribute.Resolve): Check for duplicate named
3614 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3616 * iterators.cs (MarkYield): track whether we are in an exception,
3617 and generate code accordingly. Use a temporary value to store the
3618 result for our state.
3620 I had ignored a bit the interaction of try/catch with iterators
3621 since their behavior was not entirely obvious, but now it is
3622 possible to verify that our behavior is the same as MS .NET 2.0
3626 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3628 * iterators.cs: Avoid creating temporaries if there is no work to
3631 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3632 Enumerations, use TypeManager.EnumToUnderlying and call
3635 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3638 (This.Emit): Use EmitContext.EmitThis to emit our
3641 (This.EmitAssign): Ditto.
3643 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3644 codepaths, we will move all the functionality into
3647 (FieldExpr.EmitAssign): Ditto.
3649 This fixes several hidden bugs that I uncovered while doing a code
3650 review of this today.
3652 * codegen.cs (EmitThis): reworked so the semantics are more clear
3653 and also support value types "this" instances.
3655 * iterators.cs: Changed so that for iterators in value types, we
3656 do not pass the value type as a parameter.
3658 Initialization of the enumerator helpers is now done in the caller
3659 instead of passing the parameters to the constructors and having
3660 the constructor set the fields.
3662 The fields have now `assembly' visibility instead of private.
3664 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3666 * expression.cs (Argument.Resolve): Check if fields passed as ref
3667 or out are contained in a MarshalByRefObject.
3669 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3670 another compiler type.
3672 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3674 * class.cs (Indexer.Define): use the new name checking method.
3675 Also, return false on an error.
3676 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3677 (is_identifier_[start/part]_character): make static.
3679 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3681 * expression.cs (Binary.ResolveOperator): Do no append strings
3682 twice: since we can be invoked more than once (array evaluation)
3683 on the same concatenation, take care of this here. Based on a fix
3684 from Ben (bug #56454)
3686 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3688 * codegen.cs: Fix another case where CS1548 must be reported (when
3689 delay-sign isn't specified and no private is available #56564). Fix
3690 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3691 error when MCS is used on the MS runtime and we need to delay-sign
3692 (which seems unsupported by AssemblyBuilder - see #56621).
3694 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3696 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3697 (TypeManager.ComputeNamespaces): Faster implementation for
3700 * compiler.csproj: Updated AssemblyName to mcs.
3702 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3704 * rootcontext.cs: Add new types to the boot resolution.
3706 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3707 MulticastDelegate is not allowed.
3709 * typemanager.cs: Add new types to lookup: System.TypedReference
3712 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3713 check for TypedReference or ArgIterator, they are not allowed.
3715 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3716 makes us properly catch 1510 in some conditions (see bug 56016 for
3719 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3721 * CryptoConvert.cs: update from corlib version
3724 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3726 * class.cs (Indexer.Define): Check indexername declaration
3728 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3730 * attribute.cs (IsClsCompliant): Fixed problem with handling
3731 all three states (compliant, not-compliant, undetected).
3733 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3735 * attribute.cs (Attribute): Location is now public.
3736 (Resolve): Store resolved arguments (pos_values) in attribute class.
3737 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3738 (GetClsCompliantAttributeValue): New method that gets
3739 CLSCompliantAttribute value.
3740 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3741 if exists else null.
3742 (AttributeTester): New class for CLS-Compliant verification routines.
3744 * class.cs (Emit): Add CLS-Compliant verification.
3745 (Method.GetSignatureForError): Implemented.
3746 (Constructor.GetSignatureForError): Implemented
3747 (Constructor.HasCompliantArgs): Returns if constructor has
3748 CLS-Compliant arguments.
3749 (Constructor.Emit): Override.
3750 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3751 is needed to test only parameters.
3752 (FieldBase.GetSignatureForError): Implemented.
3753 (TypeContainer): New member for storing base interfaces.
3754 (TypeContainer.FindMembers): Search in base interfaces too.
3756 * codegen.cs (GetClsComplianceAttribute): New method that gets
3757 assembly or module CLSCompliantAttribute value.
3758 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3760 (ModuleClass.Emit): Add error 3012 test.
3762 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3764 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3765 state for all decl types.
3766 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3767 if CLS-Compliant tests are required.
3768 (IsClsCompliaceRequired): New method. Analyze whether code
3769 must be CLS-Compliant.
3770 (IsExposedFromAssembly): New method. Returns true when MemberCore
3771 is exposed from assembly.
3772 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3773 value or gets cached value.
3774 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3775 is explicitly marked with CLSCompliantAttribute.
3776 (IsIdentifierClsCompliant): New abstract method. This method is
3777 used to testing error 3005.
3778 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3779 for identifier and parameters CLS-Compliant testing.
3780 (VerifyClsCompliance): New method. The main virtual method for
3781 CLS-Compliant verifications.
3782 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3783 null. I don't know why is null (too many public members !).
3784 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3785 and get value of first CLSCompliantAttribute that found.
3787 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3788 (VerifyClsCompliance): Override and add extra tests.
3790 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3791 clscheck- disable CLS-Compliant verification event if assembly is has
3792 CLSCompliantAttribute(true).
3794 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3795 ApllyAttribute is now called in emit section as in the other cases.
3796 Possible future Emit integration.
3797 (IsIdentifierClsCompliant): New override.
3798 (VerifyClsCompliance): New override.
3799 (GetEnumeratorName): Returns full enum name.
3801 * parameter.cs (GetSignatureForError): Implemented.
3803 * report.cs (WarningData): New struct for Warning message information.
3804 (LocationOfPreviousError): New method.
3805 (Warning): New method. Reports warning based on the warning table.
3806 (Error_T): New method. Reports error based on the error table.
3808 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3809 verifications are done here.
3811 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3813 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3814 CLSCompliantAttribute.
3815 (all_imported_types): New member holds all imported types from other
3817 (LoadAllImportedTypes): New method fills static table with exported types
3818 from all referenced assemblies.
3819 (Modules): New property returns all assembly modules.
3821 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3823 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3824 throwing a parser error.
3826 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3827 which removes the hardcoded get_/set_ prefixes for properties, as
3828 IL allows for the properties to be named something else.
3832 * expression.cs: Do not override operand before we know if it is
3835 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3837 * typemanager.cs: support for pinned variables.
3839 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3841 * decl.cs, typemanager.cs: Avoid using an arraylist
3842 as a buffer if there is only one result set.
3844 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3846 * expression.cs: Make sure you cant call a static method
3847 with an instance expression, bug #56174.
3849 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3851 * class.cs (IsDuplicateImplementation): Improve error reporting to
3852 flag 663 (method only differs in parameter modifier).
3854 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3855 in preprocessor directives.
3857 * location.cs (LookupFile): Allow for the empty path.
3859 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3860 better approach for some of that patch, but its failing with the
3861 CharSet enumeration. For now try/catch will do.
3863 * typemanager.cs: Do not crash if a struct does not have fields.
3866 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3868 * expression.cs: cs0213, cant fix a fixed expression.
3871 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3873 * cs-parser.jay: detect invalid embeded statements gracefully.
3876 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3878 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3881 the invocation type may not be a subclass of the tye of the item/
3882 The type of the item must be a subclass of the invocation item.
3887 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3889 * attribute.cs: Added methods to get a string and a bool from an
3890 attribute. Required to information from AssemblyKeyFileAttribute,
3891 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3892 * codegen.cs: Modified AssemblyName creation to include support for
3893 strongnames. Catch additional exceptions to report them as CS1548.
3894 * compiler.csproj: Updated include CryptoConvert.cs.
3895 * compiler.csproj.user: Removed file - user specific configuration.
3896 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3897 Mono.Security assembly. The original class is maintained and tested in
3898 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3899 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3900 like CSC 8.0 (C# v2) supports.
3901 * Makefile: Added CryptoConvert.cs to mcs sources.
3902 * rootcontext.cs: Added new options for strongnames.
3904 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
3906 * driver.cs: For --expect-error, report error code `2'
3907 if the program compiled with no errors, error code `1' if
3908 it compiled with an error other than the one expected.
3910 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
3912 * compiler.csproj: Updated for Visual Studio .NET 2003.
3913 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
3914 * compiler.sln: Updated for Visual Studio .NET 2003.
3916 2004-03-24 Ravi Pratap M <ravi@ximian.com>
3918 * expression.cs: Fix bug #47234. We basically need to apply the
3919 rule that we prefer the conversion of null to a reference type
3920 when faced with a conversion to 'object' (csc behaviour).
3922 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3924 * statement.cs: Shorter form for foreach, eliminates
3925 a local variable. r=Martin.
3927 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3929 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
3930 checks if we can use brtrue/brfalse to test for 0.
3931 * expression.cs: use the above in the test for using brtrue/brfalse.
3934 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3936 * expression.cs: Rewrite string concat stuff. Benefits:
3938 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
3939 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
3940 rather than a concat chain.
3942 * typemanager.cs: Add lookups for more concat overloads.
3944 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3946 * expression.cs: Emit shorter il code for array init.
3963 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
3965 * statement.cs: Before, two switch blocks would be merged if the
3966 total size of the blocks (end_item - begin_item + 1) was less than
3967 two times the combined sizes of the blocks.
3969 Now, it will only merge if after the merge at least half of the
3974 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
3976 * class.cs : csc build fix for GetMethods(). See bug #52503.
3978 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
3980 * expression.cs: Make sure fp comparisons work with NaN.
3981 This fixes bug #54303. Mig approved this patch a long
3982 time ago, but we were not able to test b/c the runtime
3985 2004-03-19 Miguel de Icaza <miguel@ximian.com>
3987 * ecore.cs (TypExpr.GetHashCode): implement this overload.
3989 2004-03-19 Martin Baulig <martin@ximian.com>
3991 * class.cs (MemberCore.IsDuplicateImplementation): Report the
3992 error here and not in our caller.
3994 2004-03-19 Martin Baulig <martin@ximian.com>
3996 * interface.cs: Completely killed this file.
3997 (Interface): We're now a TypeContainer and live in class.cs.
3999 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4000 argument; we're now also called for interfaces.
4001 (TypeContainer.DefineMembers): Allow this method being called
4003 (TypeContainer.GetMethods): New public method; formerly known as
4004 Interface.GetMethod(). This is used by PendingImplementation.
4005 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4006 it's now private and non-static.
4007 (Interface): Moved this here; it's now implemented similar to
4009 (Method, Property, Event, Indexer): Added `bool is_interface'
4010 argument to their .ctor's.
4011 (MemberBase.IsInterface): New public field.
4013 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4014 instances instead of InterfaceMethod, InterfaceProperty, etc.
4015 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4016 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4018 2004-03-19 Martin Baulig <martin@ximian.com>
4020 * class.cs (MethodCore.IsDuplicateImplementation): New private
4021 method which does the CS0111 checking.
4022 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4023 Use IsDuplicateImplementation().
4025 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4027 * decl.cs (FindMemberToOverride): New method to find the correct
4028 method or property to override in the base class.
4030 - Make Method/Property use the above method to find the
4031 version in the base class.
4032 - Remove the InheritableMemberSignatureCompare as it is now
4035 This patch makes large code bases much faster to compile, as it is
4036 O(n) rather than O(n^2) to do this validation.
4038 Also, it fixes bug 52458 which is that nested classes are not
4039 taken into account when finding the base class member.
4041 Reviewed/Approved by Martin.
4043 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4045 * interface.cs: In all interface classes removed redundant
4046 member initialization.
4048 2004-03-16 Martin Baulig <martin@ximian.com>
4050 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4052 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4054 * decl.cs (DefineTypeAndParents): New helper method to define a
4055 type's containers before the type itself is defined; This is a
4056 bug exposed by the recent changes to Windows.Forms when an
4057 implemented interface was defined inside a class that had not been
4060 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4062 (Check): Loop correctly to report errors modifiers
4063 (UNSAFE was not in the loop, since it was the same as TOP).
4065 * interface.cs: Every interface member now takes a ModFlags,
4066 instead of a "is_new" bool, which we set on the base MemberCore.
4068 Every place where we called "UnsafeOk" in the interface, now we
4069 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4070 the unsafe settings from the member declaration instead of the
4071 container interface.
4073 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4075 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4076 `set_indexer_name' to the pending bits (one per type).
4078 We fixed a bug today that was picking the wrong method to
4079 override, since for properties the existing InterfaceMethod code
4080 basically ignored the method name. Now we make sure that the
4081 method name is one of the valid indexer names.
4083 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4085 * support.cs (SeekableStreamReader): Keep track of stream byte
4086 positions and don't mix them with character offsets to the buffer.
4088 Patch from Gustavo Giráldez
4090 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4092 * interface.cs (InterfaceSetGetBase): Removed double member
4093 initialization, base class does it as well.
4095 2004-03-13 Martin Baulig <martin@ximian.com>
4097 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4098 when compiling corlib.
4100 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4102 * convert.cs (ExplicitConversion): We were reporting an error on
4103 certain conversions (object_type source to a value type, when the
4104 expression was `null') before we had a chance to pass it through
4105 the user defined conversions.
4107 * driver.cs: Replace / and \ in resource specifications to dots.
4110 * class.cs: Add check for duplicate operators. Fixes 52477
4112 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4114 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4115 that are in the middle of the statements, not only at the end.
4118 * class.cs (TypeContainer.AddField): No longer set the
4119 `HaveStaticConstructor' flag, now we call it
4120 `UserDefineStaticConstructor' to diferentiate the slightly
4121 semantic difference.
4123 The situation is that we were not adding BeforeFieldInit (from
4124 Modifiers.TypeAttr) to classes that could have it.
4125 BeforeFieldInit should be set to classes that have no static
4130 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4132 And most importantly Zoltan's comment:
4134 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4136 "I think beforefieldinit means 'it's ok to initialize the type sometime
4137 before its static fields are used', i.e. initialization does not need
4138 to be triggered by the first access to the type. Setting this flag
4139 helps the JIT to compile better code, since it can run the static
4140 constructor at JIT time, and does not need to generate code to call it
4141 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4142 this flag for lots of classes like String.
4144 csc sets this flag if the type does not have an explicit static
4145 constructor. The reasoning seems to be that if there are only static
4146 initalizers for a type, and no static constructor, then the programmer
4147 does not care when this initialization happens, so beforefieldinit
4150 This bug prevents the AOT compiler from being usable, since it
4151 generates so many calls to mono_runtime_class_init that the AOT code
4152 is much slower than the JITted code. The JITted code is faster,
4153 because it does not generate these calls if the vtable is type is
4154 already initialized, which is true in the majority of cases. But the
4155 AOT compiler can't do this."
4157 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4159 * class.cs (MethodData.Emit): Refactor the code so symbolic
4160 information is generated for destructors; For some reasons we
4161 were taking a code path that did not generate symbolic information
4164 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4166 * class.cs: Create a Constructor.CheckBase method that
4167 takes care of all validation type code. The method
4168 contains some code that was moved from Define.
4170 It also includes new code that checks for duplicate ctors.
4171 This fixes bug #55148.
4173 2004-03-09 Joshua Tauberer <tauberer@for.net>
4175 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4176 a { ... }-style array creation invokes EmitStaticInitializers
4177 which is not good for reference-type arrays. String, decimal
4178 and now null constants (NullCast) are not counted toward
4179 static initializers.
4181 2004-03-05 Martin Baulig <martin@ximian.com>
4183 * location.cs (SourceFile.HasLineDirective): New public field;
4184 specifies whether the file contains or is referenced by a "#line"
4186 (Location.DefineSymbolDocuments): Ignore source files which
4187 either contain or are referenced by a "#line" directive.
4189 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4191 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4192 direct access to our parent, so check the method inline there.
4194 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4196 * expression.cs (Invocation.EmitCall): Miguel's last commit
4197 caused a regression. If you had:
4202 In Foo the implict this would be null.
4204 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4206 * expression.cs (Invocation.EmitCall): If the method is not
4207 virtual, do not emit a CallVirt to it, use Call.
4209 * typemanager.cs (GetFullNameSignature): Improve the method to
4210 cope with ".ctor" and replace it with the type name.
4212 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4213 as an argument the ConstructorBuilder where it is being defined,
4214 to catch the recursive constructor invocations.
4216 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4218 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4219 routines to check if a type is an enumerable/enumerator allow
4220 classes that implement the IEnumerable or IEnumerator interfaces.
4222 * class.cs (Property, Operator): Implement IIteratorContainer, and
4223 implement SetYields.
4225 (Property.Define): Do the block swapping for get_methods in the
4226 context of iterators. We need to check if Properties also
4227 include indexers or not.
4229 (Operator): Assign the Block before invoking the
4230 OperatorMethod.Define, so we can trigger the Iterator code
4233 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4234 Property and Operator classes are not created when we parse the
4235 declarator but until we have the block completed, so we use a
4236 singleton SimpleIteratorContainer.Simple to flag whether the
4237 SetYields has been invoked.
4239 We propagate this setting then to the Property or the Operator to
4240 allow the `yield' to function.
4242 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4244 * codegen.cs: Implemented attribute support for modules.
4245 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4246 Assembly/Module functionality.
4248 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4249 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4250 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4252 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4254 * interface.cs (FindMembers): The operation is performed on all base
4255 interfaces and not only on the first. It is required for future CLS Compliance patch.
4257 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4259 * statement.cs, codegen.cs:
4260 This patch deals with patterns such as:
4262 public class List : IEnumerable {
4264 public MyEnumerator GetEnumerator () {
4265 return new MyEnumerator(this);
4268 IEnumerator IEnumerable.GetEnumerator () {
4272 public struct MyEnumerator : IEnumerator {
4277 Before, there were a few things we did wrong:
4278 1) we would emit callvirt on a struct, which is illegal
4279 2) we emited ldarg when we needed to emit ldarga
4280 3) we would mistakenly call the interface methods on an enumerator
4281 type that derived from IEnumerator and was in another assembly. For example:
4283 public class MyEnumerator : IEnumerator
4285 Would have the interface methods called, even if there were public impls of the
4286 method. In a struct, this lead to invalid IL code.
4288 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4290 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4293 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4295 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4297 * cs-parser.jay: Fix small regression: we were not testing V2
4298 compiler features correctly.
4300 * interface.cs: If the emit context is null, then create one
4302 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4304 * decl.cs (GetSignatureForError): New virtual method to get full name
4307 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4308 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4310 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4311 Duplicated members and code in these classes has been removed.
4312 Better encapsulation in these classes.
4314 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4316 * assign.cs (Assign.DoResolve): When dealing with compound
4317 assignments, there is a new rule in ECMA C# 2.4 (might have been
4318 there before, but it is documented here) that states that in:
4322 If b is of type int, and the `op' is a shift-operator, then the
4323 above is evaluated as:
4327 * expression.cs (Binary.ResolveOperator): Instead of testing for
4328 int/uint/long/ulong, try to implicitly convert to any of those
4329 types and use that in pointer arithmetic.
4331 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4332 method to print information for from the type, not from the
4333 null-method we were given.
4335 2004-02-01 Duncan Mak <duncan@ximian.com>
4337 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4338 parsing for cmd, fixes bug #53694.
4340 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4342 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4343 in the member name duplication tests. Property and operator name duplication
4344 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4346 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4348 * interface.cs (PopulateMethod): Fixed crash when interface method
4349 returns not existing type (error test cs0246-3.cs).
4351 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4353 * cs-parser.jay (interface_accessors): Re-write actions to also
4354 store attributes attached to get and set methods. Fix spelling
4357 (inteface_property_declaration): Modify accordingly.
4359 (InterfaceAccessorInfo): New helper class to store information to pass
4360 around between rules that use interface_accessors.
4362 * interface.cs (Emit): Apply attributes on the get and set
4363 accessors of properties and indexers too.
4365 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4366 right MethodBuilder when applying attributes to the get and set accessors.
4368 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4370 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4372 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4374 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4376 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4378 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4379 changes that treat `yield' specially when present before `break'
4382 * cs-tokenizer.cs: yield is no longer a keyword.
4384 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4386 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4387 setting for default constructors.
4388 For default constructors are almost every time set wrong Modifier. The
4389 generated IL code has been alright. But inside mcs this values was
4390 wrong and this was reason why several of my CLS Compliance tests
4393 2004-01-22 Martin Baulig <martin@ximian.com>
4395 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4396 not a QualifiedIdentifier. This is what `type_name_expression'
4397 was previously doing.
4398 (type_name_expression): Removed; the code is now in
4399 `namespace_or_type_name'.
4400 (qualified_identifier): Removed, use `namespace_or_type_name'
4402 (QualifiedIdentifier): Removed this class.
4404 2004-01-22 Martin Baulig <martin@ximian.com>
4406 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4407 not a string as alias name.
4409 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4411 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4412 #52730 bug, and instead compute correctly the need to use a
4413 temporary variable when requesting an address based on the
4414 static/instace modified of the field and the constructor.
4416 2004-01-21 Martin Baulig <martin@ximian.com>
4418 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4419 class and namespace before looking up aliases. Fixes #52517.
4421 2004-01-21 Martin Baulig <martin@ximian.com>
4423 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4424 assinged in a 'try'; fixes exception4.cs.
4426 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4427 * class.cs : Implemented parameter-less constructor for TypeContainer
4429 * decl.cs: Attributes are now stored here. New property OptAttributes
4431 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4433 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4435 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4437 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4438 (CSharpSignature): New method for indexer and property signature.
4440 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4442 * pending.cs (IsVirtualFilter): Faster implementation.
4444 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4446 * typemanager.cs: Avoid inclusion of same assembly more than once.
4448 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4450 * cs-parser.jay: Fixed problem where the last assembly attribute
4451 has been applied also to following declaration (class, struct, etc.)
4453 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4455 * class.cs: Added error CS0538, CS0539 reporting.
4456 Fixed crash on Microsoft runtime when field type is void.
4458 * cs-parser.jay: Added error CS0537 reporting.
4460 * pending.cs: Added error CS0535 reporting.
4461 Improved error report for errors CS0536, CS0534.
4463 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4465 Merge a few bits from the Anonymous Method MCS tree.
4467 * statement.cs (ToplevelBlock): New class for toplevel methods,
4468 will hold anonymous methods, lifted variables.
4470 * cs-parser.jay: Create toplevel blocks for delegates and for
4471 regular blocks of code.
4473 2004-01-20 Martin Baulig <martin@ximian.com>
4475 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4476 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4477 and `NeedExplicitReturn'; added `IsLastStatement'.
4478 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4479 have a `ReturnLabel' or we're not unreachable.
4481 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4482 child's reachability; don't just override ours with it. Fixes
4483 #58058 (lluis's example).
4484 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4485 InFinally(), InLoop(), InSwitch() and
4486 BreakCrossesTryCatchBoundary() methods.
4488 * statement.cs (Return): Do all error checking in Resolve().
4489 Unless we are the last statement in a top-level block, always
4490 create a return label and jump to it.
4491 (Break, Continue): Do all error checking in Resolve(); also make
4492 sure we aren't leaving a `finally'.
4493 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4494 statement in a top-level block.
4495 (Block.Flags): Added `IsDestructor'.
4496 (Block.IsDestructor): New public property.
4498 2004-01-20 Martin Baulig <martin@ximian.com>
4500 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4502 2004-01-20 Martin Baulig <martin@ximian.com>
4504 * statement.cs (Statement.ResolveUnreachable): New public method.
4505 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4506 (Block.Resolve): Resolve unreachable statements.
4508 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4510 * expression.cs: We need to fix the case where we do
4511 not have a temp variable here.
4513 * assign.cs: Only expression compound assignments need
4514 temporary variables.
4516 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4518 * flowanalysis.cs: Reduce memory allocation in a few ways:
4519 - A block with no variables should not allocate a bit
4521 - A method with no out parameters does not need any tracking
4522 for assignment of the parameters, so we need not allocate
4525 public readonly Type[] VariableTypes;
4526 public readonly string[] VariableNames;
4527 Are redundant. The data is already stored in the variable
4528 map, so we need not allocate another array for it.
4529 - We need to add alot of checks for if (params | locals) == null
4530 due to the first two changes.
4532 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4534 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4535 implement IMemoryLocation, we store a copy on a local variable and
4536 take the address of it. Patch from Benjamin Jemlich
4538 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4539 to use a special "type_name_expression" rule which reduces the
4540 number of "QualifiedIdentifier" classes created, and instead
4541 directly creates MemberAccess expressions.
4543 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4545 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4546 that fixes #52853. Null literal assignment to ValueType
4548 * class.cs (MethodData.Emit): Instead of checking the name of the
4549 method to determine if its a destructor, create a new derived
4550 class from Method called Destructor, and test for that.
4552 * cs-parser.jay: Create a Destructor object instead of a Method.
4554 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4558 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4560 * expression.cs (Binary.ResolveOperator): Perform an implicit
4561 conversion from MethodGroups to their delegate types on the
4564 * delegate.cs: Introduce a new class DelegateCreation that is the
4565 base class for `NewDelegate' and `ImplicitDelegateCreation',
4566 factor some code in here.
4568 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4569 conversion from MethodGroups to compatible delegate types.
4571 * ecore.cs (Expression.Resolve): Do not flag error 654
4572 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4573 we allow conversions from MethodGroups to delegate types now.
4575 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4576 assignments in v2 either.
4578 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4580 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4581 static read-only fields in ctors.
4583 Applied patch from Benjamin Jemlich
4585 * expression.cs (UnaryMutator): Avoid leaking local variables.
4587 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4589 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4590 here to return true, as they can be used like this:
4594 Fixed 49836 and all the other dups
4596 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4598 * driver.cs: Implement /win32res and /win32icon.
4600 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4602 * cs-parser.jay: Add a rule to improve error handling for the
4603 common mistake of placing modifiers after the type.
4605 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4607 * cs-parser.jay (interface_event_declaration): Catch
4608 initialization of events on interfaces, and report cs0068
4610 * cs-parser.jay (interface_event_declaration): Catch
4611 initialization of events.
4613 * ecore.cs: Better report missing constructors.
4615 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4616 the error reporting done in the wrong place. Fix.
4618 * expression.cs (Binary.ResolveOperator): Catch the
4619 operator + (E x, E y) error earlier, and later allow for implicit
4620 conversions in operator +/- (E e, U x) from U to the underlying
4623 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4624 52596, if the container class is abstract, the default constructor
4625 is protected otherwise its public (before, we were always public).
4627 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4630 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4631 Jemlich that fixes bug #52597, MCS was generating invalid code for
4632 idisposable structs. Thanks to Ben for following up with this
4635 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4637 * driver.cs: Allow assemblies without code to be generated, fixes
4640 2004-01-07 Nick Drochak <ndrochak@gol.com>
4642 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4644 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4646 * cs-parser.jay: Add rules to improve error reporting if fields or
4647 methods are declared at the namespace level (error 116)
4649 * Add rules to catch event add/remove
4651 2004-01-04 David Sheldon <dave-mono@earth.li>
4653 * expression.cs: Added matching ")" to error message for
4656 2004-01-03 Todd Berman <tberman@gentoo.org>
4658 * ecore.cs, attribute.cs:
4659 Applying fix from #52429.
4661 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4663 * ecore.cs, expression.cs, statement.cs:
4664 Total rewrite of how we handle branching. We
4665 now handle complex boolean expressions with fewer
4666 jumps. As well if (x == 0) no longer emits a ceq.
4668 if (x is Foo) is much faster now, because we generate
4671 Overall, we get a pretty big improvement on our benchmark
4672 tests. The code we generate is smaller and more readable.
4674 I did a full two-stage bootstrap. The patch was reviewed
4675 by Martin and Miguel.
4677 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4679 * cs-parser.jay: Make primary_expression not take a QI.
4680 we dont need this because the member_access rule covers
4681 us here. So we replace the rule with just IDENTIFIER.
4683 This has two good effects. First, we remove a s/r conflict.
4684 Second, we allocate many fewer QualifiedIdentifier objects.
4686 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4688 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4689 set the correct information via SRE. This prevents
4690 hanging on the MS runtime. Fixes #29374.
4692 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4694 * convert.cs: correctly handle conversions to value types
4695 from Enum and ValueType as unboxing conversions.
4697 Fixes bug #52569. Patch by Benjamin Jemlich.
4699 2004-01-02 Ravi Pratap <ravi@ximian.com>
4701 * expression.cs (BetterConversion): Prefer int -> uint
4702 over int -> ulong (csc's behaviour). This fixed bug #52046.
4704 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4706 * decl.cs (MemberCache.FindMembers): now returns a
4709 * typemanager.cs: In general, go with with ^^.
4710 (CopyNewMethods): take an IList.
4711 (RealMemberLookup): Only allocate an arraylist
4712 if we copy from two sets of methods.
4714 This change basically does two things:
4715 1) Fewer array lists allocated due to CopyNewMethods.
4716 2) the explicit cast in MemberList costed ALOT.
4718 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4720 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4721 a hashtable to avoid needless string allocations when an identifier is
4722 used more than once (the common case).
4724 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4726 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4727 is broken, it will not return anything. So, we
4728 have to use the information we have in mcs to
4731 * typemanager.cs: Add a cache for GetInterfaces,
4732 since this will now be used more often (due to ^^)
4734 (GetExplicitInterfaces) New method that gets the
4735 declared, not effective, interfaces on a type
4736 builder (eg, if you have interface IFoo, interface
4737 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4740 This patch makes MCS able to bootstrap itself on
4743 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4745 * expression.cs: Remove the Nop's that Miguel put
4748 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4750 * report.cs, codegen.cs: Give the real stack trace to
4751 the error when an exception is thrown.
4753 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4755 * decl.cs: only allocate hashtables for ifaces if
4758 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4760 * expression.cs: fix the error from cs0121-2.cs
4761 (a parent interface has two child interfaces that
4762 have a function with the same name and 0 params
4763 and the function is called through the parent).
4765 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4767 * class.cs, rootcontext.cs, typmanager.cs: do not
4770 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4772 * codegen.cs: remove stack for the ec flow branching.
4773 It is already a linked list, so no need.
4775 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4777 * Makefile: Allow custom profiler here.
4779 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4781 * typemanager.cs (LookupType):
4782 - Use a static char [], because split takes
4783 a param array for args, so it was allocating
4785 - Do not store true in a hashtable, it boxes.
4787 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4789 * flowanalysis.cs: bytify common enums.
4791 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4793 * modifiers.cs: Add a new set of flags for the
4794 flags allowed on explicit interface impls.
4795 * cs-parser.jay: catch the use of modifiers in
4796 interfaces correctly.
4797 * class.cs: catch private void IFoo.Blah ().
4799 All related to bug #50572.
4801 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4803 * decl.cs: Rewrite the consistant accessability checking.
4804 Accessability is not linear, it must be implemented in
4805 a tableish way. Fixes #49704.
4807 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4809 * expression.cs: Handle negation in a checked context.
4810 We must use subtraction from zero. Fixes #38674.
4812 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4814 * class.cs: Ignore static void main in DLLs.
4815 * rootcontext.cs: Handle the target type here,
4816 since we are have to access it from class.cs
4817 * driver.cs: account for the above.
4819 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4821 * report.cs: Give line numbers and files if available.
4823 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
4825 * driver.cs: Implement /addmodule.
4827 * typemanager.cs: Change 'modules' field so it now contains Modules not
4830 2003-12-20 Martin Baulig <martin@ximian.com>
4832 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
4833 (FieldBase.IsAssigned): Removed this field.
4834 (FieldBase.SetAssigned): New public method.
4835 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
4837 2003-12-20 Martin Baulig <martin@ximian.com>
4839 * expression.cs (LocalVariableReference.DoResolve): Don't set
4840 `vi.Used' if we're called from DoResolveLValue().
4842 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
4843 returns the usage vector it just merged into the current one -
4844 pass this one to UsageWarning().
4845 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
4846 of the `EmitContext', don't call this recursively on our children.
4848 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
4850 * driver.cs: Implement /target:module.
4852 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
4854 * support.cs (CharArrayHashtable): New helper class.
4856 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
4857 char arrays, not strings, so we can avoid creating a string in
4858 consume_identifier if the identifier is a keyword.
4860 2003-12-16 Martin Baulig <martin@ximian.com>
4862 * statement.cs (LocalInfo.Assigned): Removed this property.
4863 (LocalInfo.Flags): Removed `Assigned'.
4864 (LocalInfo.IsAssigned): New public method; takes the EmitContext
4865 and uses flow analysis.
4866 (Block.UsageWarning): Made this method private.
4867 (Block.Resolve): Call UsageWarning() if appropriate.
4869 * expression.cs (LocalVariableReference.DoResolve): Always set
4870 LocalInfo.Used here.
4872 2003-12-13 Martin Baulig <martin@ximian.com>
4874 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
4875 any value here; we're now using flow analysis to figure out
4876 whether a statement/block returns a value.
4878 2003-12-13 Martin Baulig <martin@ximian.com>
4880 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
4882 (FlowBranching.MergeFinally): Don't call
4883 `branching.CheckOutParameters()' here, this is called in
4885 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
4886 when adding the `finally' vector.
4888 2003-12-13 Martin Baulig <martin@ximian.com>
4891 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
4892 actually work and also fix #48962.
4894 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
4896 * decl.cs: Do not check System.Object for nested types,
4897 since we know it does not have any. Big bang for buck:
4902 corlib: 17.99 seconds
4906 corlib: 17.39 seconds
4908 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
4910 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
4911 time we are returning 0 members, so we save alot here.
4913 2003-12-11 Martin Baulig <martin@ximian.com>
4915 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
4916 `MergeChild()', also just take the `FlowBranching' as argument;
4917 call Merge() on it and return the result.
4918 (FlowBranching.Merge): We don't need to do anything if we just
4921 2003-12-11 Martin Baulig <martin@ximian.com>
4923 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
4924 them in an `ArrayList' to reduce memory usage. Thanks to Ben
4925 Maurer for this idea.
4927 2003-12-11 Martin Baulig <martin@ximian.com>
4929 * flowanalysis.cs (MergeResult): This class is now gone; we now
4930 use the `UsageVector' for this. The reason for this is that if a
4931 branching just has one sibling, we don't need to "merge" them at
4932 all - that's the next step to do.
4933 (FlowBranching.Merge): We now return a `UsageVector' instead of a
4936 2003-12-11 Martin Baulig <martin@ximian.com>
4938 Reworked flow analyis and made it more precise and bug-free. The
4939 most important change is that we're now using a special `Reachability'
4940 class instead of having "magic" meanings of `FlowReturns'. I'll
4941 do some more cleanups and optimizations and also add some more
4942 documentation this week.
4944 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
4945 largely reworked this class.
4946 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
4947 the new `Reachability' class instead of having "magic" values here.
4948 (FlowBranching): We're now using an instance of `Reachability'
4949 instead of having separate `Returns', `Breaks' etc. fields.
4951 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
4952 based on flow analysis; ignore the return value of block.Emit ().
4954 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
4956 * driver.cs typemanager.cs: Find the mono extensions to corlib even
4957 if they are private.
4959 2003-12-09 Martin Baulig <martin@ximian.com>
4961 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
4962 call them directly on the UsageVector.
4964 2003-12-09 Martin Baulig <martin@ximian.com>
4966 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
4967 Changed return type from `FlowReturns' to `Reachability'.
4969 2003-12-09 Martin Baulig <martin@ximian.com>
4971 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
4972 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
4973 `Reachable' fields with a single `Reachability' one.
4975 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4977 * class.cs (FindMembers): Remove foreach's.
4990 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4995 This patch does a few things:
4996 1. EmptyStatement is now a singleton, so it is never reallocated.
4997 2. All blah is EmptyStatement constructs have been changed to
4998 blah == EmptyStatement.Value, which is much faster and valid
4999 now that EmptyStatement is a singleton.
5000 3. When resolving a block, rather than allocating a new array for
5001 the non-empty statements, empty statements are replaced with
5002 EmptyStatement.Value
5003 4. Some recursive functions have been made non-recursive.
5004 Mainly the performance impact is from (3), however (1) and (2) are needed for
5005 this to work. (4) does not make a big difference in normal situations, however
5006 it makes the profile look saner.
5011 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5012 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5013 Total memory allocated: 56397 KB
5016 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5017 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5018 Total memory allocated: 55666 KB
5020 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5022 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5023 than the hashtable in a hashtable version
5025 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5026 we always end up concating a string. This results in a huge perf
5027 loss, because many strings have to be tracked by the GC. In this
5028 patch, we first use a hashtable that works with two keys, so that
5029 the strings do not need to be concat'ed.
5040 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5042 * Makefile: Add a new target `do-time' that does a quick and simple
5043 profile, leaving easy to parse output.
5045 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5047 * codegen.cs (Init): Create the dynamic assembly with
5048 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5050 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5052 * support.cs: Make the PtrHashtable use only one
5053 instance of its comparer.
5055 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5057 * typemanager.cs: Fix lookup of GetNamespaces.
5059 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5061 * expression.cs: Removed redundant line.
5063 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5064 ArrayLists, use for loops with bounds.
5066 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5069 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5070 arraylists, use for loop with bounds.
5072 The above three changes give us a 0.071 second performance
5073 improvement out of 3.294 seconds down to 3.223. On my machine
5074 the above changes reduced the memory usage by 1,387 KB during
5077 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5078 QualifiedIdentifiers. Before we created a new string through
5079 concatenation, and mostly later on, the result would be
5080 manipulated by DecomposeQI through string manipulation.
5082 This reduced the compiler memory usage for bootstrapping from
5083 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5084 compile times in 0.05 seconds.
5086 2003-11-28 Dick Porter <dick@ximian.com>
5088 * support.cs: Do string compares with the Invariant culture.
5096 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5097 the comparison is done with the Invariant culture.
5099 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5101 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5102 GetEnumerator method.
5104 (ProbeCollectionType): Iterate starting at the most specific type
5105 upwards looking for a GetEnumerator
5107 * expression.cs: Shift count can be up to 31 for int/uint and 63
5110 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5112 * statement.cs (Block.LookupLabel): Also look for the label on the
5113 children blocks. Use a hash table to keep track of visited
5116 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5117 we actually did transform the other operand, otherwise fall back
5118 to the common codepath that casts to long.
5120 * cs-tokenizer.cs: Use the same code pattern as the int case.
5121 Maybe I should do the parsing myself, and avoid depending on the
5122 Parse routines to get this done.
5124 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5126 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5127 which fixes bug 51347. This time test it.
5129 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5130 attributes for example can not tell the difference between these.
5131 The difference was only a syntax feature of the language.
5133 * attribute.cs: Apply attributes to delegates.
5135 * delegate.cs: Call the apply attributes method.
5137 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5139 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5140 comparing 0 vs Byte.MinValue, not the value
5142 (ImplicitConversionRequired): When reporting a conversion error,
5143 use error 31 to print out the constant error instead of the
5146 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5147 which fixes bug 51347.
5149 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5151 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5152 which fixes the -warnaserror command line option.
5154 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5156 * cfold.cs (DoNumericPromotions): During constant folding of
5157 additions on UIntConstant, special case intconstants with
5158 IntConstants like we do on the expression binary operator.
5160 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5162 * convert.cs (ImplicitReferenceConversion): We were missing a case
5163 (System.Enum are not value types or class types, so we need to
5164 classify them separatedly).
5166 * driver.cs: We do not support error 2007.
5168 2003-11-12 Jackson Harper <jackson@ximian.com>
5170 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5171 system directory. Also use the full file name so users can
5172 libraries names mscorlib-o-tron.dll in a non system dir.
5174 2003-11-10 Martin Baulig <martin@ximian.com>
5176 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5177 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5178 calling `ResolveType()' on them, directly assign their `Type'.
5180 2003-11-08 Martin Baulig <martin@ximian.com>
5182 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5183 return value and the `out parent' parameter.
5184 (TypeContainer.DefineType): Moved the CS0644 check into
5185 GetClassBases(). Don't pass the interface types to the
5186 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5187 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5189 * ecore.cs (TypeExpr.IsAttribute): New property.
5190 (TypeExpr.GetInterfaces): New method.
5192 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5193 TypeExpr instead of a Type.
5194 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5195 (Interface.DefineType): Don't pass the interface types to the
5196 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5197 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5199 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5200 instead of a `Type[]'.
5201 (TypeManager.RegisterBuilder): Likewise.
5202 (TypeManager.AddUserInterface): Likewise.
5203 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5204 `Type[]' and also return a `TypeExpr[]'.
5205 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5207 2003-11-08 Martin Baulig <martin@ximian.com>
5209 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5212 2003-11-08 Martin Baulig <martin@ximian.com>
5214 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5215 TypeManager.ResolveExpressionTypes().
5217 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5218 instead of an Expression.
5219 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5220 (TypeExpression): New public class; formerly known as `TypeExpr'.
5222 * expression.cs (ComposedCast): Derive from TypeExpr.
5224 * typemanager.cs (TypeManager.system_*_expr): These are now
5225 TypExpr's instead of Expression's.
5226 (TypeManager.ResolveExpressionTypes): New public static function;
5227 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5230 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5232 * expression.cs (New.DoResolve): Do not dereference value that
5233 might be a null return.
5235 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5236 sure that the constant value has the right type. Fixes an
5237 unreported bug, similar to 50425.
5239 * const.cs (Const.LookupConstantValue): Call
5240 ImplicitStandardConversionExists before doing a conversion to
5241 avoid havng the TypeManager.ChangeType do conversions.
5243 Reduced the number of casts used
5245 (Const.ChangeType): New routine to enable reuse of the constant
5246 type changing code from statement.
5248 * typemanager.cs (ChangeType): Move common initialization to
5249 static global variables.
5253 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5254 every value type to go through, even if it was void. Fix that.
5256 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5257 character of the define, and the is_identifier_part_character for
5258 the rest of the string.
5260 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5262 * expression.cs (UnaryMutator.EmitCode): When I updated
5263 LocalVariableReference.DoResolve, I overdid it, and dropped an
5264 optimization done on local variable references.
5266 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5268 * ecore.cs: Convert the return from Ldlen into an int.
5270 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5272 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5273 the accessibility, this is a special case for toplevel non-public
5274 classes (internal for instance).
5276 2003-10-20 Nick Drochak <ndrochak@gol.com>
5278 * ecore.cs: Fix typo and build. Needed another right paren.
5280 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5282 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5283 `internal' case regular and protected, but not allowing protected
5284 to be evaluated later. Bug 49840
5286 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5288 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5289 to kb.Nlast, and not the kb.nFirst to isolate the switch
5292 Extract the underlying type, so enumerations of long/ulong are
5293 treated like long/ulong.
5295 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5297 * expression.cs (New): Overload the meaning of RequestedType to
5298 track the possible creation of the NewDelegate type, since
5299 DoResolve is invoked more than once for new constructors on field
5302 See bugs: #48800 and #37014
5304 * cs-parser.jay (declare_local_constants): Take an arraylist
5305 instead of a single constant.
5307 (local_constant_declaration): It should take a
5308 constant_declarators, not a constant_declarator. Fixes 49487
5310 * convert.cs: Fix error report.
5312 2003-10-13 Jackson Harper <jackson@ximian.com>
5314 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5317 2003-10-09 Martin Baulig <martin@ximian.com>
5319 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5321 (MethodCore.DoDefineParameters): Removed the TypeContainer
5322 argument; use the DeclSpace which was passed to the .ctor instead.
5323 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5324 TypeContainer; we only need a DeclSpace here.
5326 2003-10-09 Martin Baulig <martin@ximian.com>
5328 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5330 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5331 EmitContext's .ctor.
5333 2003-10-09 Martin Baulig <martin@ximian.com>
5335 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5336 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5337 AsAccessible(), moved them as well.
5339 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5341 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5343 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5345 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5347 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5348 generation for >=, as spotted by Paolo, bug 48679.
5349 Patch from David Waite.
5351 * cs-tokenizer.cs: Add handling for #pragma.
5353 * cs-parser.jay: Allow for both yield and yield return in the
5354 syntax. The anti-cobolization of C# fight will go on!
5356 * class.cs (TypeBuilder.DefineType): Catch error condition here
5357 (Parent.DefineType erroring out and returning null).
5359 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5360 coping with enumerations variables, we were mistakenly processing
5361 them as a regular value type instead of built-in types. Fixes the
5364 * typemanager.cs (IsBuiltinOrEnum): New method.
5366 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5368 * cs-parser.jay: Upgrade: yield now needs the return clause.
5370 2003-09-19 Martin Baulig <martin@ximian.com>
5372 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5373 `MemberCache parent' argument. Normally, an interface doesn't
5374 have a parent type except System.Object, but we use this in gmcs
5375 for generic type parameters.
5377 2003-09-18 Martin Baulig <martin@ximian.com>
5379 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5380 on `type.IsInterface'; don't check whether the type has a parent
5381 to determine whether it's an interface.
5383 2003-09-15 Martin Baulig <martin@ximian.com>
5385 * class.cs (TypeContainer.DefineType): Added an error flag to
5386 avoid reporting duplicate CS0146's ("class definition is
5389 * driver.cs (Driver.MainDriver): Abort if
5390 RootContext.ResolveTree() reported any errors.
5392 2003-09-07 Martin Baulig <martin@ximian.com>
5394 * report.cs (Error, Warning): Added overloaded versions which take
5395 a `params object[] args' and call String.Format().
5397 2003-09-07 Martin Baulig <martin@ximian.com>
5399 * decl.cs (DeclSpace..ctor): Don't call
5400 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5401 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5402 (DeclSpace.RecordDecl): New method.
5404 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5406 2003-09-02 Ravi Pratap <ravi@ximian.com>
5408 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5409 value attributes to be applied to ParameterBuilders.
5411 * class.cs (MethodCore.LabelParameters): Make static and more
5412 generic so that it can be used from other places - like interface
5413 methods, for instance.
5415 * interface.cs (Interface.Emit): Call LabelParameters before
5416 emitting attributes on the InterfaceMethod.
5418 2003-08-26 Martin Baulig <martin@ximian.com>
5420 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5421 resolving aliases; fixes #47927.
5423 2003-08-26 Martin Baulig <martin@ximian.com>
5425 * statement.cs (Using.DoResolve): This is internally emitting a
5426 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5427 do not always return. Fixes #47681.
5429 2003-08-26 Martin Baulig <martin@ximian.com>
5431 * decl.cs (MemberCore): Moved WarningNotHiding(),
5432 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5434 (AdditionResult): Make this nested in DeclSpace.
5435 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5436 argument; call NamespaceEntry.Define() unless we're nested in a
5439 * namespace.cs (Namespace.DefineName): New public function. This
5440 is called from DeclSpace's .ctor to add
5441 (Namespace.Lookup): Include DeclSpaces in the lookup.
5443 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5445 * const.cs (Const): Derive from MemberBase, not MemberCore.
5447 2003-08-25 Martin Baulig <martin@ximian.com>
5449 * convert.cs (Convert.ExplicitReferenceConversion): When
5450 converting from an interface type to a class, unbox if the target
5451 type is a struct type. Fixes #47822.
5453 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5455 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5458 2003-08-22 Martin Baulig <martin@ximian.com>
5460 * class.cs (TypeManager.DefineType): When defining a nested type,
5461 call DefineType() on our parent; fixes #47801.
5463 2003-08-22 Martin Baulig <martin@ximian.com>
5465 * class.cs (MethodData.Define): While checking if a method is an
5466 interface implementation, improve the test a bit more to fix #47654.
5468 2003-08-22 Martin Baulig <martin@ximian.com>
5470 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5471 correctly; fixes #47722.
5473 2003-08-22 Martin Baulig <martin@ximian.com>
5475 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5476 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5478 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5480 2003-08-22 Martin Baulig <martin@ximian.com>
5482 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5483 can only be assigned in static constructors. Fixes #47161.
5485 2003-08-22 Martin Baulig <martin@ximian.com>
5487 Rewrote and improved the flow analysis code.
5489 * flowbranching.cs (FlowBranching): Make this class abstract.
5490 (FlowBranching.CreateBranching): New static function to create a
5492 (FlowBranchingBlock, FlowBranchingException): New classes.
5493 (FlowBranching.UsageVector.Type): New public readonly field.
5494 (FlowBranching.UsageVector.Breaks): Removed the setter.
5495 (FlowBranching.UsageVector.Returns): Removed the setter.
5496 (FlowBranching.UsageVector): Added Break(), Return(),
5497 NeverReachable() and Throw() methods to modify the reachability.
5498 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5499 done by FlowBranching.Merge().
5500 (FlowBranching.UsageVector.MergeChild): New method; merges the
5501 merge result into the current vector.
5502 (FlowBranching.Merge): New abstract method to merge a branching.
5504 2003-08-12 Martin Baulig <martin@ximian.com>
5506 * expression.cs (Indirection.CacheTemporaries): Create the
5507 LocalTemporary with the pointer type, not its element type.
5509 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5511 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5512 token was a keyword or not.
5514 Add `error' options where an IDENTIFIER was expected; Provide
5515 CheckToken and CheckIdentifierToken convenience error reporting
5518 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5520 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5521 NameSpaceEntry NameSpaceEntry.
5523 (LookupInterfaceOrClass): Avoid creating a full qualified name
5524 from namespace and name: avoid doing lookups when we know the
5525 namespace is non-existant. Use new Tree.LookupByNamespace which
5526 looks up DeclSpaces based on their namespace, name pair.
5528 * driver.cs: Provide a new `parser verbose' to display the
5529 exception thrown during parsing. This is turned off by default
5530 now, so the output of a failure from mcs is more graceful.
5532 * namespace.cs: Track all the namespaces defined in a hashtable
5535 (IsNamespace): New method
5537 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5539 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5540 we know that we need to concatenate (full typename can never be
5545 * statement.cs: Use a bitfield; Do not initialize to null things
5546 which are done by the constructor by default.
5548 * cs-parser.jay: bug fix, parameter was 4, not 3.
5550 * expression.cs: Just use the property;
5552 * statement.cs: No need for GetVariableInfo method.
5554 2003-08-08 Martin Baulig <martin@ximian.com>
5556 * flowanalysis.cs (FlowReturns): This is now nested in the
5557 `FlowBranching' class.
5558 (MyBitVector): Moved this here from statement.cs.
5559 (FlowBranching.SiblingType): New enum type.
5560 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5562 2003-08-07 Martin Baulig <martin@ximian.com>
5564 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5565 `FlowBranching' class and called `BranchingType'.
5567 2003-08-07 Martin Baulig <martin@ximian.com>
5569 * flowanalysis.cs: Moved all the control flow analysis code into
5572 2003-08-07 Martin Baulig <martin@ximian.com>
5574 * assign.cs (Assign.DoResolve): `target' must either be an
5575 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5578 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5580 * expression.cs (BinaryMethod): This kind of expression is created by the
5581 Binary class if it determines that the operator has to be handled
5584 (BinaryDelegate): This kind of expression is created if we are
5585 dealing with a + or - operator on delegates.
5587 (Binary): remove method, argumetns, and DelegateOperator: when
5588 dealing with methods,
5590 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5592 * statement.cs (Block): use bitfields for the three extra booleans
5593 we had in use. Remove unused topblock parameter.
5595 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5597 * assign.cs: Drop extra unneeded tests.
5599 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5601 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5603 * statement.cs (Foreach): Use VariableStorage instead of
5606 * codegen.cs (VariableStorage): New class used by clients that
5607 require a variable stored: locals or fields for variables that
5608 need to live across yield.
5610 Maybe provide a convenience api for EmitThis+EmitLoad?
5612 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5615 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5617 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5618 RemapParameterLValue): New methods that are used to turn a
5619 precomputed FieldInfo into an expression like this:
5623 The idea is to use this instead of making LocalVariableReference
5624 have more than one meaning.
5626 * cs-parser.jay: Add error production to BASE.
5628 * ecore.cs: Deal with TypeManager.GetField returning null, which
5629 is now a valid return value.
5631 (FieldExprNoAddress): New expression for Fields whose address can
5634 * expression.cs (LocalVariableReference): During the resolve
5635 phases, create new expressions if we are in a remapping context.
5636 Remove code that dealt with remapping here.
5638 (ParameterReference): same.
5640 (ProxyInstance): New expression, like the `This' expression, but
5641 it is born fully resolved. We know what we are doing, so remove
5642 the errors that are targeted to user-provided uses of `this'.
5644 * statement.cs (Foreach): our variable is now stored as an
5645 Expression; During resolution, follow the protocol, dont just
5646 assume it will return this.
5648 2003-08-06 Martin Baulig <martin@ximian.com>
5650 * support.cs (SeekableStreamReader.cs): New public class.
5652 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
5653 SeekableStreamReader instead of the normal StreamReader.
5655 2003-08-04 Martin Baulig <martin@ximian.com>
5657 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
5658 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
5659 deambiguate casts and delegate invocations.
5660 (parenthesized_expression): Use the new tokens to ensure this is
5661 not a cast of method invocation.
5663 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
5664 when reading a `)' and Deambiguate_CloseParens () was previously
5667 * expression.cs (ParenthesizedExpression): New class. This is
5668 just used for the CS0075 test.
5669 (Binary.DoResolve): Check for CS0075.
5671 2003-07-29 Ravi Pratap <ravi@ximian.com>
5673 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5674 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5675 reference comparison.
5677 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5678 examine the ReturnType for equality - this is necessary in the
5679 cases of implicit and explicit operators whose signature also
5680 includes the return type.
5682 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5684 * namespace.cs: Cache the result of the namespace computation,
5685 instead of computing it every time.
5687 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5689 * decl.cs: Use a global arraylist that we reuse over invocations
5690 to avoid excesive memory consumption. Reduces memory usage on an
5691 mcs compile by one meg (45 average).
5693 * typemanager.cs (LookupTypeReflection): In .NET pointers are
5694 private, work around that.
5696 2003-07-23 Miguel de Icaza <miguel@ximian.com>
5698 * literal.cs (IntLiteral): Define Zero and One static literals.
5700 * cs-parser.jay (integer_literal): use static literals to reduce
5701 memory usage for the most used literals (0, 1 and -1). 211kb
5702 reduced in memory usage.
5704 Replace all calls to `new ArrayList' with `new
5705 ArrayList(4)' which is a good average number for most allocations,
5706 and also requires only 16 bytes of memory for its buffer by
5709 This reduced MCS memory usage in seven megabytes for the RSS after
5712 2003-07-28 Ravi Pratap <ravi@ximian.com>
5714 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
5715 handle params methods the correct way by forming only one
5716 applicable set with params and normal methods in them. Earlier we
5717 were looking at params methods only if we found no normal methods
5718 which was not the correct thing to do.
5720 (Invocation.BetterFunction): Take separate arguments indicating
5721 when candidate and the best method are params methods in their
5724 This fixes bugs #43367 and #46199.
5726 * attribute.cs: Documentation updates.
5728 (CheckAttribute): Rename to CheckAttributeTarget.
5729 (GetValidPlaces): Rename to GetValidTargets.
5731 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
5732 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
5736 2003-07-28 Martin Baulig <martin@ximian.com>
5738 * class.cs (TypeContainer.DefineMembers): Use the base type's full
5739 name when looking up the base class of a nested class. Fixes #46977.
5741 2003-07-26 Martin Baulig <martin@ximian.com>
5743 * expression.cs (Indexers.Indexer): New nested struct; contains
5744 getter, setter and the indexer's type.
5745 (Indexers.Properties): This is now an ArrayList of
5747 (IndexerAccess.DoResolveLValue): Correctly set the type if the
5748 indexer doesn't have any getters.
5750 * assign.cs (Assign.DoResolve): Also do the implicit conversions
5751 for embedded property and indexer assignments.
5753 2003-07-26 Martin Baulig <martin@ximian.com>
5755 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
5756 preprocessor directive is not the first non-whitespace character
5759 2003-07-26 Martin Baulig <martin@ximian.com>
5761 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
5762 namespace parsing, follow the spec more closely.
5764 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
5765 NamespaceEntry.Lookup().
5767 2003-07-25 Martin Baulig <martin@ximian.com>
5769 * MethodCore.cs (OverridesSomething): New public field; it's set
5770 from TypeContainer.DefineMembers if this method overrides
5771 something (which doesn't need to be a method). Fix #39462.
5773 2003-07-25 Ravi Pratap <ravi@ximian.com>
5775 * typemanager.cs (GetMembers): Ensure that the list of members is
5776 reversed. This keeps things in sync.
5778 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
5779 find an AttributeUsage attribute.
5781 * expression.cs (Invocation.OverloadResolve): Perform the check
5782 which disallows Invoke to be directly called on a Delegate.
5784 (Error_InvokeOnDelegate): Report error cs1533.
5786 2003-07-25 Martin Baulig <martin@ximian.com>
5788 * expression.cs (Indexers.GetIndexersForType): Only look in the
5789 interface hierarchy if the requested type is already an
5790 interface. Fixes #46788 while keeping #46502 fixed.
5792 2003-07-25 Martin Baulig <martin@ximian.com>
5794 * class.cs (TypeContainer.DefineMembers): Check whether all
5795 readonly fields have been assigned and report warning CS0649 if
5798 * statement.cs (LocalInfo.IsFixed): Always return true if this is
5801 2003-07-24 Ravi Pratap <ravi@ximian.com>
5803 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
5804 returned from GetMethods to make things consistent with the
5805 assumptions MCS makes about ordering of methods.
5807 This should comprehensively fix bug #45127 and it does :-)
5809 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
5810 ordering is actually reverse.
5812 * Clean up some debug messages I left lying around.
5814 * interface.cs (Populate*): Get rid of code which emits attributes
5815 since the stage in which we emit attributes is the 'Emit' stage,
5816 not the define stage.
5818 (Emit): Move attribute emission for interface members here.
5820 2003-07-22 Ravi Pratap <ravi@ximian.com>
5822 * expression.cs (Invocation.OverloadResolve): Follow the spec more
5823 closely: we eliminate methods in base types when we have an
5824 applicable method in a top-level type.
5826 Please see section 14.5.5.1 for an exact description of what goes
5829 This fixes bug #45127 and a host of other related to corlib compilation.
5831 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
5832 array is the method corresponding to the top-level type (this is
5833 because of the changes made to icall.c) so we change this
5836 (MethodGroupExpr.Name): This too.
5838 * typemanager.cs (GetElementType): New method which does the right
5839 thing when compiling corlib.
5841 * everywhere: Make use of the above in the relevant places.
5843 2003-07-22 Martin Baulig <martin@ximian.com>
5845 * cs-parser.jay (invocation_expression): Moved
5846 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
5847 `cast_expression', but create a InvocationOrCast which later
5848 resolves to either an Invocation or a Cast.
5850 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
5851 method; call this before EmitStatement() to make sure that this
5852 expression can be used as a statement.
5854 * expression.cs (InvocationOrCast): New class; resolves to either
5855 an Invocation or a Cast.
5857 * statement.cs (StatementExpression): Call ResolveStatement() on
5858 the ExpressionStatement before emitting it.
5860 2003-07-21 Martin Baulig <martin@ximian.com>
5862 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
5863 `ref' and `out' attributes match; fixes #46220.
5864 (MemberAccess.ResolveMemberAccess): You can't reference a type
5865 through an expression; fixes #33180.
5866 (Indexers.GetIndexersForType): Don't return the indexers from
5867 interfaces the class implements; fixes #46502.
5869 2003-07-21 Martin Baulig <martin@ximian.com>
5871 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
5872 CS0661 checks; fixes bug #30442.
5874 2003-07-21 Martin Baulig <martin@ximian.com>
5876 * decl.cs (AdditionResult): Added `Error'.
5878 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
5880 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
5881 makes cs0031.cs actually work.
5883 2003-07-20 Martin Baulig <martin@ximian.com>
5885 * namespace.cs: Fixed that bug which caused a crash when compiling
5888 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5890 * typemanager.cs (LookupTypeReflection): Never expose types which
5891 are NotPublic, NestedPrivate, NestedAssembly, or
5892 NestedFamANDAssem. We used to return these, and later do a check
5893 that would report a meaningful error, but the problem is that we
5894 would not get the real match, if there was a name override.
5896 2003-07-18 Miguel de Icaza <miguel@ximian.com>
5898 * namespace.cs (Namespace, Name): Do not compute the namespace
5899 name dynamically, compute it in the constructor. This reduced
5900 memory usage by 1697 KB.
5902 * driver.cs: Use --pause to pause at the end.
5904 2003-07-17 Peter Williams <peter@newton.cx>
5906 * Makefile: Change the name of the test target so that it doesn't
5907 conflict with the recursive test target.
5909 2003-07-17 Miguel de Icaza <miguel@ximian.com>
5911 * expression.cs (LocalVariableReference.Emit, EmitAssign,
5912 AddressOf): Do not use EmitThis, that was wrong, use the actual
5915 2003-07-15 Miguel de Icaza <miguel@ximian.com>
5917 * class.cs (MethodData.Define): While checking if a method is an
5918 interface implementation, improve the test: If we are not public
5919 (use new test here: use the computed MethodAttributes directly,
5920 instead of the parsed modifier flags) check if the `implementing'
5921 method comes from an interface or not.
5923 * pending.cs (VerifyPendingMethods): Slightly better error
5926 * makefile: add test target that does the mcs bootstrap.
5928 2003-07-16 Ravi Pratap <ravi@ximian.com>
5930 * interface.cs (Define): Do nothing here since there are no
5931 members to populate etc. Move the attribute emission out of here
5932 since this was just totally the wrong place to put it. Attribute
5933 application happens during the 'Emit' phase, not in the 'Define'
5936 (Emit): Add this method and move the attribute emission here
5938 * rootcontext.cs (EmitCode): Call the Emit method on interface
5941 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5943 * expression.cs (OverloadResolve): Report error only if Location
5944 is not 'Null' which means that there was a probe going on.
5946 2003-07-14 Martin Baulig <martin@ximian.com>
5948 * expression.cs (ConditionalLogicalOperator): New public class to
5949 implement user defined conditional logical operators.
5950 This is section 14.11.2 in the spec and bug #40505.
5952 2003-07-14 Martin Baulig <martin@ximian.com>
5954 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
5956 2003-07-14 Martin Baulig <martin@ximian.com>
5958 * codegen.cs (EmitContext.InFixedInitializer): New public field.
5960 * ecore.cs (IVariable.VerifyFixed): New interface method.
5962 * expression.cs (Unary.ResolveOperator): When resolving the `&'
5963 operator, check whether the variable is actually fixed. Fixes bug
5964 #36055. Set a variable definitely assigned when taking its
5965 address as required by the spec.
5967 * statement.cs (LocalInfo.IsFixed): New field.
5968 (LocalInfo.MakePinned): Set `IsFixed' to true.
5970 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5972 * attribute.cs (Attribute.Resolve): While doing a Member lookup
5973 for .ctors, ensure that we only ask for members declared in the
5974 attribute type (BindingFlags.DeclaredOnly).
5978 * expression.cs (Error_WrongNumArguments): Report error 1501
5979 correctly the way CSC does.
5981 2003-07-13 Martin Baulig <martin@ximian.com>
5983 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
5984 lookup on the fully qualified name, to make things like "X.X" work
5985 where "X.X" is a fully qualified type name, but we also have a
5986 namespace "X" in the using list. Fixes #41975.
5988 2003-07-13 Martin Baulig <martin@ximian.com>
5990 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
5991 function. If we're a CompoundAssign, we need to create an embedded
5992 CompoundAssign, not an embedded Assign.
5993 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
5996 2003-07-13 Martin Baulig <martin@ximian.com>
5998 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
5999 work to fix bug #46088.
6001 2003-07-13 Ravi Pratap <ravi@ximian.com>
6003 * class.cs (Operator.Emit): Do not emit attributes here - it is
6004 taken care of by the Method class that we delegate too. This takes
6007 2003-07-10 Martin Baulig <martin@ximian.com>
6009 * expression.cs (TypeOfVoid): New class.
6010 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6012 2003-07-10 Martin Baulig <martin@ximian.com>
6014 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6017 2003-07-10 Martin Baulig <martin@ximian.com>
6019 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6020 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6022 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6024 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6026 2003-07-10 Martin Baulig <martin@ximian.com>
6028 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6029 of decimal. Fixes #42850.
6031 NOTE: I also fixed the created byte blob, but this doesn't work on
6032 the MS runtime and csc never produces any byte blobs for decimal
6035 2003-07-10 Martin Baulig <martin@ximian.com>
6037 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6038 structs; fixes #32068.
6039 (Block.AddChildVariableNames): Fixed #44302.
6041 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6043 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6045 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6047 * attribute.cs: And this test is onger needed.
6049 2003-07-08 Martin Baulig <martin@ximian.com>
6051 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6052 inaccessible types. Fixes #36313.
6054 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6056 * namespace.cs (NamespaceEntry): Create implicit entries for all
6057 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6058 implicit entries for N1.N2 and N1.
6060 2003-07-08 Martin Baulig <martin@ximian.com>
6062 Rewrote the handling of namespaces to fix a lot of the issues
6063 wrt. `using' aliases etc.
6065 * namespace.cs (Namespace): Splitted this class into a
6066 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6068 * typemanager.cs (TypeManager.IsNamespace): Removed.
6069 (TypeManager.ComputeNamespaces): Only compute namespaces from
6070 loaded assemblies here, not the namespaces from the assembly we're
6071 currently compiling.
6073 2003-07-08 Martin Baulig <martin@ximian.com>
6075 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6077 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6079 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6082 I thought about the memory savings here, but LookupTypeReflection
6083 is used under already very constrained scenarios. Compiling
6084 corlib or mcs only exposes one hit, so it would not really reduce
6085 any memory consumption.
6087 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6089 * typemanager.cs: fixes bug #45889 by only adding public types from
6090 other assemblies to the list of known types.
6092 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6094 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6095 on the type we resolved.
6097 2003-07-05 Martin Baulig <martin@ximian.com>
6099 * pending.cs (PendingImplementation.ParentImplements): Don't
6100 create the proxy if the parent is abstract.
6102 * class.cs (TypeContainer.DefineIndexers): Process explicit
6103 interface implementations first. Fixes #37714.
6105 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6107 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6108 defined recursively; but since we modify the input parameters
6109 (left is set to `this' temporarily), we reset this value if the
6110 left_is_explicit is false, which gives the original semantics to
6113 * literal.cs (NullPointer): new class used to represent a null
6114 literal in a pointer context.
6116 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6117 type is a pointer, use a NullPointer object instead of a
6118 NullLiteral. Closes 43687
6120 (ExplicitConversion): Convert pointer values using
6121 the conv opcode to the proper type.
6123 * ecore.cs (New): change ValueTypeVariable property into a method,
6124 that returns whether the valuetype is suitable for being used.
6126 * expression.cs (Binary.DoNumericPromotions): Only return if we
6127 the int constant was a valid uint, and we can return both left and
6128 right as uints. If not, we continue processing, to trigger the
6129 type conversion. This fixes 39018.
6131 * statement.cs (Block.EmitMeta): During constant resolution, set
6132 the CurrentBlock property on the emitcontext, so that we resolve
6133 constants propertly.
6135 2003-07-02 Martin Baulig <martin@ximian.com>
6137 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6138 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6140 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6141 than emitting it here.
6143 * statement.cs: Fixed some more flow analysis bugs.
6145 2003-07-02 Martin Baulig <martin@ximian.com>
6147 * class.cs (MethodData.Define): When implementing interface
6148 methods, set Final unless we're Virtual.
6150 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6151 check work for interface methods.
6153 2003-07-01 Martin Baulig <martin@ximian.com>
6155 * ecore.cs (EmitContext.This): Replaced this property with a
6156 GetThis() method which takes a Location argument. This ensures
6157 that we get the correct error location for a CS0188.
6159 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6161 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6162 ImplicitStandardConversion.
6164 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6166 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6168 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6171 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6173 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6176 (MethodData.Define): Turn off initlocals for unsafe methods.
6178 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6180 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6181 complete; Fixes #37521.
6183 * delegate.cs: Use Modifiers.TypeAttr to compute the
6184 TypeAttributes, instead of rolling our own. This makes the flags
6185 correct for the delegates.
6187 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6189 * class.cs (Constructor.Define): Set the private flag for static
6190 constructors as well.
6192 * cs-parser.jay (statement_expression): Set the return value to
6193 null, to avoid a crash when we catch an error.
6195 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6197 * cs-parser.jay: Applied patch from Jackson that adds support for
6198 extern and unsafe modifiers to destructor declarations.
6200 * expression.cs: Report error 21 if the user is trying to index a
6203 * driver.cs: Add an error message, suggested by the bug report.
6205 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6206 if we do not have a ": this ()" constructor initializer. Fixes 45149
6208 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6210 * namespace.cs: Add some information to reduce FAQs.
6212 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6214 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6215 underlying enumeration types. Fixes #43915.
6217 * expression.cs: Treat ushort/short as legal values to be used in
6220 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6222 * delegate.cs: transfer custom attributes for paramenters from
6223 the delegate declaration to Invoke and BeginInvoke.
6225 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6227 * attribute.cs: handle custom marshalers and emit marshal info
6230 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6232 * makefile.gnu: Added anonymous.cs to the compiler sources.
6234 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6236 * iterators.cs: Change the name of the proxy class to include two
6239 * cs-parser.jay: Update grammar to include anonymous methods.
6241 * anonymous.cs: new file.
6243 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6245 * class.cs (Field.Define): Add missing test for pointers and
6248 2003-05-27 Ravi Pratap <ravi@ximian.com>
6250 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6251 we use the stobj opcode.
6253 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6254 since it wasn't the correct fix.
6256 It still is puzzling that we are required to use stobj for IntPtr
6257 which seems to be a ValueType.
6259 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6261 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6262 during regular simple name resolution. Now, the trick is that
6263 instead of returning for processing the simplename, we do a
6264 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6265 contextual lookup type). If a match is found, return that, if
6266 not, return for further composition.
6268 This fixes long-standing 30485.
6270 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6271 using the address to initialize an object, do an Stobj instead of
6272 using the regular Stelem.
6274 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6275 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6276 Because if we are a BaseIndexerAccess that value will be true.
6279 * statement.cs (GotoCase.Resolve): Return after reporting an
6280 error, do not attempt to continue.
6282 * expression.cs (PointerArithmetic.Emit): If our operand is a
6283 long, convert our constants to match the operand before
6284 multiplying. Convert to I type before adding. Fixes 43670.
6286 2003-05-14 Ravi Pratap <ravi@ximian.com>
6288 * enum.cs (ImplicitConversionExists) : Rename to
6289 ImplicitEnumConversionExists to remove ambiguity.
6291 * ecore.cs (NullCast): New type of cast expression class which
6292 basically is very similar to EmptyCast with the difference being
6293 it still is a constant since it is used only to cast a null to
6297 * convert.cs (ImplicitReferenceConversion): When casting a null
6298 literal, we return a NullCast.
6300 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6301 should be around anymore.
6303 The renaming (reported was slightly wrong). Corrections:
6305 ConvertImplicitStandard -> ImplicitConversionStandard
6306 ConvertExplicitStandard -> ExplicitConversionStandard
6308 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6309 before passing them in !
6311 * convert.cs (ImplicitConversionStandard): When comparing for
6312 equal expr and target types, ensure that expr is not a
6315 In general, we must not be checking (expr_type ==
6316 target_type) in the top level conversion methods
6317 (ImplicitConversion, ExplicitConversion etc). This checking is
6318 done in the methods that they delegate to.
6320 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6322 * convert.cs: Move Error_CannotConvertType,
6323 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6324 ImplicitNumericConversion, ImplicitConversionExists,
6325 ImplicitUserConversionExists, StandardConversionExists,
6326 FindMostEncompassedType, FindMostSpecificSource,
6327 FindMostSpecificTarget, ImplicitUserConversion,
6328 ExplicitUserConversion, GetConversionOperators,
6329 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6330 TryImplicitIntConversion, Error_CannotConvertImplicit,
6331 ConvertImplicitRequired, ConvertNumericExplicit,
6332 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6333 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6336 Perform the following renames:
6338 StandardConversionExists -> ImplicitStandardConversionExists
6339 ConvertImplicit -> ImplicitConversion
6340 ConvertImplicitStandard -> ImplicitStandardConversion
6341 TryImplicitIntConversion -> ImplicitIntConversion
6342 ConvertImplicitRequired -> ImplicitConversionRequired
6343 ConvertNumericExplicit -> ExplicitNumericConversion
6344 ConvertReferenceExplicit -> ExplicitReferenceConversion
6345 ConvertExplicit -> ExplicitConversion
6346 ConvertExplicitStandard -> ExplicitStandardConversion
6348 2003-05-19 Martin Baulig <martin@ximian.com>
6350 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6351 (TypeInfo): Added support for structs having structs as fields.
6353 * ecore.cs (FieldExpr): Implement IVariable.
6354 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6355 VariableInfo for the field.
6357 2003-05-18 Martin Baulig <martin@ximian.com>
6359 * expression.cs (This.DoResolve): Report a CS0027 if we're
6360 emitting a field initializer.
6362 2003-05-18 Martin Baulig <martin@ximian.com>
6364 * expression.cs (This.ResolveBase): New public function.
6365 (This.DoResolve): Check for CS0188.
6367 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6370 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6371 `instance_expression' to null if we don't have any non-static
6374 2003-05-18 Martin Baulig <martin@ximian.com>
6376 Reworked the way how local variables and parameters are handled by
6377 the flow analysis code.
6379 * statement.cs (TypeInfo, VariableMap): New public classes.
6380 (VariableInfo): New public class. This is now responsible for
6381 checking whether a variable has been assigned. It is used for
6382 parameters and local variables.
6383 (Block.EmitMeta): Take the InternalParameters as argument; compute
6384 the layout of the flow vectors here.
6385 (Block.LocalMap, Block.ParameterMap): New public properties.
6386 (FlowBranching): The .ctor doesn't get the InternalParameters
6387 anymore since Block.EmitMeta() now computes the layout of the flow
6389 (MyStructInfo): This class is now known as `StructInfo' and nested
6390 in `TypeInfo'; we don't access this directly anymore.
6392 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6393 property and removed IsAssigned(), IsFieldAssigned(),
6394 SetAssigned() and SetFieldAssigned(); we now call them on the
6395 VariableInfo so we don't need to duplicate this code everywhere.
6397 * expression.cs (ParameterReference): Added `Block block' argument
6399 (LocalVariableReference, ParameterReference, This): The new
6400 VariableInfo class is now responsible for all the definite
6403 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6404 IsParameterAssigned, SetParameterAssigned): Removed.
6406 2003-05-18 Martin Baulig <martin@ximian.com>
6408 * typemanager.cs (InitCoreTypes): Try calling
6409 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6410 the 3-args-version. Corlib now also needs our `void_type'.
6411 (GetMethod): Added overloaded version which takes an optional
6412 `bool report_errors' to allow lookups of optional methods.
6414 2003-05-12 Martin Baulig <martin@ximian.com>
6416 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6417 only used for locals and not for parameters.
6419 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6421 * support.cs (InternalParameters.ParameterType): Return the
6422 ExternalType of the parameter.
6424 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6427 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6429 * class.cs (MethodData.Define): Do not set the `newslot' on
6430 interface members, if they are also flagged as "override".
6432 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6433 better code for ++i and i++. This only works for static fields
6434 and local variables.
6436 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6437 want to pull the DeclSpace out of the builder_to_declspace instead
6438 of the TypeBuilder (like in TypeContainer.FindMembers).
6440 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6441 instead of LookupTypeContainer. Fixes the crash on .NET for
6442 looking up interface members.
6444 * const.cs: Create our own emit context during the Definition
6445 stage, so that constants are evaluated in the proper context, when
6446 a recursive definition happens.
6448 2003-05-11 Martin Baulig <martin@ximian.com>
6450 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6451 new block for a switch section.
6452 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6453 the adding/lookup in the switch block. Fixes #39828.
6455 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6457 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6458 functionality: I needed to convert the data after I had performed
6459 the add/sub operation into the operands type size.
6461 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6462 pass the type for the box operation, otherwise the resulting
6463 object would have been of type object.
6465 (BoxedCast): Add constructor to specify the type to box as.
6467 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6469 * iterators.cs: I was reusing the `count' variable inadvertently,
6470 take steps to not allow this to happen.
6472 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6474 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6475 by creating an array at the point where the params starts and
6476 putting all those arguments there, then adjusting the size of the
6479 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6481 * expression.cs (New.AddressOf): Implement interface
6482 IMemoryLocation. This is used when the `new' operator is used in
6483 the context of an invocation to a method on a value type.
6485 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6488 * namespace.cs: Also check the using aliases here.
6490 * driver.cs: Move the test for using validity after the types have
6491 been entered, so we do a single pass that also includes the using
6494 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6495 in the regular case. CreateSiblingForFinally is doing extra
6498 * attribute.cs (GetAttributeArgumentExpression): Store the result
6499 on an out value, and use the return value to indicate failure
6500 instead of using null (which is a valid return for Constant.GetValue).
6502 * statement.cs: Perform the analysis flow for the increment
6503 portion after the statement, because this will be the real flow of
6504 execution. Fixes #42385
6506 * codegen.cs (EmitContext.EmitArgument,
6507 EmitContext.EmitStoreArgument): New helper functions when the
6508 RemapToProxy flag is set.
6510 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6513 Add support for remapping parameters.
6515 * iterators.cs: Propagate parameter values; Store parameter
6516 values in the proxy classes.
6518 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6520 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6521 need a proxy reference; I do not know what I was thinking
6523 * cs-parser.jay (constructor_initializer): catch another error,
6524 and display nice message.
6526 (field_declaration): catch void field declaration
6527 to flag a better error.
6529 * class.cs (MemberBase.CheckBase): Report an error instead of a
6530 warning if a new protected member is declared in a struct.
6531 (Field.Define): catch the error of readonly/volatile.
6533 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6535 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6536 volatile variable is taken
6538 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6540 * statement.cs (Fixed.Resolve): Report an error if we are not in
6543 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6545 * typemanager.cs: reuse the code that handles type clashes for
6546 delegates and enumerations.
6548 * class.cs (Report28): Always report.
6550 * expression.cs (EncodeAsAttribute): Allow nulls here.
6552 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6554 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6555 the functionality for testing whether an expression is valid for
6556 an attribute here. Also handle the case of arrays of elements
6559 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6560 encoding a linear array into an array of objects that are suitable
6561 to be passed to an CustomAttributeBuilder.
6563 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6565 * ecore.cs: (FieldExpr): Handle field remapping here.
6567 * iteratators.cs: Pass the instance variable (if the method is an
6568 instance method) to the constructors, so we can access the field
6569 variables on the class.
6571 TODO: Test this with structs. I think the THIS variable on
6572 structs might have to be a pointer, and not a refenrece
6574 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6576 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6577 local variables to fields in a proxy class.
6579 * iterators.cs (PopulateProxy): Rename our internal fields to
6581 Create a <THIS> field if we are an instance method, so we can
6582 reference our parent container variables.
6583 (MapVariable): Called back from the EmitContext code to enter a
6584 new variable to field mapping into the proxy class (we just create
6588 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6589 for using the remapped locals to fields.
6591 I placed the code here, because that gives the same semantics to
6592 local variables, and only changes the Emit code.
6594 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6595 statements inside iterators.
6596 (VariableInfo): Add a FieldBuilder for the cases when we are
6597 remapping local variables to fields in a proxy class
6599 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6600 current_block != null.
6602 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6603 not cope with strings, as it has been moved to the
6604 TableSwitchEmit. Fixed bug in switch generation.
6606 * expression.cs (New.DoResolve): Provide more context for the user
6607 when reporting an error.
6609 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6612 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6613 check the permissions for it. Note than in a type-resolution
6614 context the check was already present in DeclSpace.ResolveType,
6615 but was missing from the MemberAccess.
6617 (ArrayCreation.CheckIndices): warn if the user has
6618 more nested levels of expressions, but there are no more
6619 dimensions specified. Avoids crash on bug 41906.
6621 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6623 * statement.cs (Block): replace Implicit bool, for a generic
6625 New flag: `Unchecked'. This is used during the EmitMeta phase
6626 (which is out-of-line with the regular Resolve/Emit process for a
6627 statement, as this is done ahead of time, but still gets a chance
6628 to call constant resolve).
6630 (Block.Flags): new enum for adding a new flag.
6632 (Block.EmitMeta): track the state of unchecked.
6634 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6635 to enable constant resolution to work there as well.
6637 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6639 * typemanager.cs (ienumerable_type): Also look up
6640 System.Collections.IEnumerable.
6642 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6644 TODO: Test more than one conditional per method.
6646 * class.cs (Indexer.Define): Report the location where the user is
6647 referencing the unsupported feature.
6649 (MethodData): Overload the use of `conditionals' to
6650 minimize the creation of needless ArrayLists. This saves roughly
6651 212kb on my machine.
6653 (Method): Implement the new IIteratorContainer interface.
6654 (Method.SetYields): Implement the method by setting the ModFlags
6655 to contain METHOD_YIELDS.
6657 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
6658 which just got set to null.
6660 * iterators.cs: New file.
6662 (Yield, YieldBreak): New statements.
6664 * statement.cs (Return.Resolve): Flag an error if we are used in
6667 * codegen.cs (InIterator): New flag set if the code is being
6668 compiled in an iterator method.
6670 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6671 internal modifier, and we just use it to avoid adding extra
6672 fields, as this is seldom used.
6674 * cs-parser.jay: Add yield_statement (yield and yield break).
6676 * driver.cs: New flag -v2 to turn on version 2 features.
6678 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6679 hashtable when v2 is enabled.
6681 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6683 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6684 there is already a namespace defined with this name.
6686 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6687 people upgraded their corlibs.
6689 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
6690 always use fully qualified types, no need to use the compiler
6693 (TypeManager.IsNamespace): Use binarysearch.
6695 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
6696 AddDelegate): I did not quite use the new IsValid API properly: I
6697 have to pass the short-name and the fullname. I was passing only
6698 the basename instead of the fullname sometimes.
6700 (TypeContainer.DefineType): call NamespaceClash.
6702 * interface.cs (Interface.DefineType): use NamespaceClash before
6705 * delegate.cs (Delegate.DefineType): use NamespaceClash before
6708 * enum.cs: (Enum.DefineType): use NamespaceClash before
6711 * typemanager.cs (: 3-line patch that gives us some tasty 11%
6712 speed increase. First, use the negative_hits cache when we get a
6713 negative. Second, add the type with its full original name
6714 instead of the new . and + encoded name (reflection uses + to
6715 separate type from a nested type). Use LookupTypeReflection
6716 directly which bypasses the type->name hashtable (that we already
6717 know does not contain the type.
6719 * decl.cs (DeclSpace.ResolveTypeExpr): track the
6720 location/container type.
6722 * driver.cs: When passing utf8, use directly the UTF8Encoding.
6724 2003-04-19 Miguel de Icaza <miguel@ximian.com>
6726 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
6728 * delegate.cs (NewDelegate.Resolve): Test whether an instance
6729 method is being referenced in the method group from a static
6730 context, and report error 120 if so.
6732 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
6735 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
6736 is created, we create the A namespace).
6738 * cs-parser.jay: A namespace also introduces a DeclarationFound.
6741 2003-04-18 Miguel de Icaza <miguel@ximian.com>
6743 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
6744 invocation to ModuleBuilder.GetType with the same values will
6745 return a new type instance, so we need to cache its return
6748 * expression.cs (Binary.ResolveOperator): Only allow the compare
6749 operators on enums if they are of the same type.
6751 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
6752 types of ValueType on their own case. Before we were giving them
6753 the same treatment as objects.
6755 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
6756 fullname. Short name is used to compare against container name.
6757 Fullname is used to check against defined namespace names.
6759 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
6760 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
6762 (Method.CheckBase): Call parent.
6763 (MemberBase.CheckBase): Check for protected members on sealed
6765 (PropertyBase.CheckBase): Call parent.
6766 (Field.Define): Call parent.
6768 * report.cs: Negative error codes are now mapped to 8000 - code,
6769 so that the display is render more nicely.
6771 * typemanager.cs: Do not use try/catch, instead report a regular
6774 (GetPointerType, GetReferenceType): These methods provide
6775 mechanisms to obtain the T* and T& from a T. We had the code
6776 previously scattered around the code base, and it also used
6777 TypeManager.LookupType that would go through plenty of caches.
6778 This one goes directly to the type source.
6780 In some places we did the Type.GetType followed by
6781 ModuleBuilder.GetType, but not in others, so this unifies the
6784 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
6785 statements now that we have namespace information.
6787 * typemanager.cs (IsNamespace): New method, returns whether the
6788 string presented is a namespace or not.
6790 (ComputeNamespaces): New public entry point, computes the list of
6791 available namespaces, using the GetNamespaces API call in Mono, or
6792 the slower version in MS.NET.
6794 Now before we start the semantic analysis phase, we have a
6795 complete list of namespaces including everything that the user has
6798 Deleted old code to cache namespaces in .nsc files.
6800 2003-04-17 Miguel de Icaza <miguel@ximian.com>
6802 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
6803 class/struct location definition Location for the implicit
6804 constructor location.
6806 (Operator.Define): Use the location of the operator for the
6807 implicit Method definition.
6809 (Constructor.Emit): use the constructor location for the implicit
6810 base initializer constructor.
6812 * ecore.cs: Remove ITypeExpression. This interface is now gone,
6813 and the Expression class now contains two new methods:
6815 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
6816 isolate type lookup from the rest of the resolution process.
6818 Since we use Expressions to hold type definitions due to the way
6819 we parse the input we have historically overloaded Resolve to
6820 perform the Type lookups if a special flag is passed. Now this is
6821 eliminated and two methods take their place.
6823 The differences in the two methods between xStep and xTerminal is
6824 that xStep is involved in our current lookup system that uses
6825 SimpleNames to compose a name, while xTerminal is used just to
6826 catch the case where the simplename lookup failed.
6828 2003-04-16 Miguel de Icaza <miguel@ximian.com>
6830 * expression.cs (ResolveMemberAccess): Remove redundant code.
6831 TypeExpr expressions are always born fully resolved.
6833 * interface.cs (PopulateMethod): Do not lookup the types twice.
6834 We were doing it once during SemanticAnalysis and once during
6837 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
6838 in local variable type definitions, were being returned as a
6839 SimpleName (we decomposed everything into a string), that is
6840 because primary_expression was being used instead of a type in the
6841 grammar (reduce/reduce conflicts).
6843 The part that was wrong is that we converted the expression into a
6844 string (an oversimplification in one hand, compounded with primary
6845 expressions doing string concatenation).
6851 Would return "A.B.C[]" as a SimpleName. This stopped things like
6852 using clauses from working on this particular context. And a type
6853 was being matched directly against "A.B.C[]".
6855 We now use the correct approach, and allow for ComposedCast to be
6856 part of the unary expression. So the "A.B.C []" become a composed
6857 cast of "A.B.C" (as a nested group of MemberAccess with a
6858 SimpleName at the end) plus the rank composition "[]".
6862 2003-04-10 Miguel de Icaza <miguel@ximian.com>
6864 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
6865 for the access level checking.
6867 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
6868 `TypeContainer container', because I kept getting confused when I
6869 was debugging this code.
6871 * expression.cs (Indexers): Instead of tracking getters/setters,
6872 we now track them in parallel. We create one arraylist less, but
6873 most importantly it is possible now for the LValue code to find a
6874 matching get for a set.
6876 (IndexerAccess.DoResolveLValue): Update the code.
6877 GetIndexersForType has been modified already to extract all the
6878 indexers from a type. The code assumed it did not.
6880 Also make the code set the correct return type for the indexer.
6881 This was fixed a long time ago for properties, but was missing for
6882 indexers. It used to be void_type.
6884 (Binary.Emit): Test first for doubles instead of
6885 floats, as they are more common.
6887 (Binary.EmitBranchable): Use the .un version of the branch opcodes
6888 when dealing with floats and the <=, >= operators. This fixes bug
6891 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
6892 to load the array value by emitting a load on the foreach variable
6893 type. This was incorrect.
6895 We now emit the code to load an element using the the array
6896 variable type, and then we emit the conversion operator.
6900 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
6902 * attribute.cs: Avoid allocation of ArrayLists in the common case.
6904 2003-04-09 Miguel de Icaza <miguel@ximian.com>
6906 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
6907 test for protection before we test for signatures.
6909 (MethodSignature.ToString): implement.
6911 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
6912 to the case where we reduced into a LongConstant.
6914 * decl.cs (CheckAccessLevel): If the type is an array, we can not
6915 depend on whether the information is acurrate, because the
6916 Microsoft runtime will always claim that the array type is public,
6917 regardless of the real state.
6919 If the type is a pointer, another problem happens: the type is
6920 reported as non-public in Microsoft.
6922 In both cases we have to call CheckAccessLevel recursively with
6923 the underlying type as the argument to be tested.
6925 2003-04-08 Miguel de Icaza <miguel@ximian.com>
6927 * assign.cs (Assign.Emit): If we are dealing with a compound
6928 assignment expression, we should use the code path that stores the
6929 intermediate result in a temporary value. This fixes #40903.
6931 *expression.cs (Indirection.ToString): Provide ToString method for
6934 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
6936 * class.cs: Null out fields holding references to Block objects so
6937 they can be garbage collected.
6939 * expression.cs (OverloadResolve): Remove unused local.
6941 2003-04-07 Martin Baulig <martin@ximian.com>
6943 * codegen.cs (EmitContext.CurrentFile): New public field.
6944 (EmitContext.Mark): Use the CurrentFile to check whether the
6945 location is in the correct file.
6946 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
6948 2003-04-07 Martin Baulig <martin@ximian.com>
6950 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
6952 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
6953 location. [FIXME: The location argument which gets passed to this
6954 method is sometimes wrong!]
6956 2003-04-07 Nick Drochak <ndrochak@gol.com>
6958 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
6960 2003-04-07 Miguel de Icaza <miguel@ximian.com>
6962 * expression.cs (Indirection.EmitAssign): We were using the
6963 temporary, but returning immediately instead of continuing the
6966 2003-04-06 Martin Baulig <martin@ximian.com>
6968 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
6969 if it's a nested child, but also deriving from the outer class.
6972 * typemanager.cs (IsNestedChildOf): Make this work if it's a
6973 nested child, but also deriving from the outer class. See
6975 (FilterWithClosure): We may access private members of the outer
6976 class if we're a nested child and deriving from the outer class.
6977 (RealMemberLookup): Only set `closure_private_ok' if the
6978 `original_bf' contained BindingFlags.NonPublic.
6980 2003-04-05 Martin Baulig <martin@ximian.com>
6982 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
6984 2003-04-02 Miguel de Icaza <miguel@ximian.com>
6986 * class.cs (Event.Define): Do not allow abstract events to have
6989 2003-04-01 Miguel de Icaza <miguel@ximian.com>
6991 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
6992 block in event declarations.
6994 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
6995 value type, get its address.
6997 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
6998 leaving a class on the stack instead of a boolean value (int
6999 0/1). Change the code so we compare against null, and then the
7000 result against zero.
7002 * class.cs (TypeContainer.GetClassBases): We were checking for the
7003 parent class being sealed too late.
7005 * expression.cs (Binary.Emit): For <= and >= when dealing with
7006 floating point values, use cgt.un and clt.un instead of cgt and
7009 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7011 * statement.cs: Apply the same optimization as MS: skip the
7012 GetEnumerator returning an IEnumerator, and use the one returning a
7013 CharEnumerator instead. This allows us to avoid the try-finally block
7016 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7018 * cs-parser.jay: Attributes cannot be applied to
7019 namespaces. Fixes #40473
7021 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7024 (Add*): check if the name is valid using the full name for constants,
7025 fields, properties and events.
7027 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7029 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7030 char constants to be part of the enumeration.
7032 * expression.cs (Conditional.DoResolve): Add support for operator
7033 true. Implements the missing functionality from 14.12
7035 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7036 operator true/false as required by the spec.
7038 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7039 implicit conversion to boolean.
7041 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7042 also one where the type implements `operator true'.
7044 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7045 get an expression that will invoke operator true based on an
7048 (GetConversionOperators): Removed the hack that called op_True
7051 (Expression.ResolveBoolean): Move this from Statement.
7053 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7055 * ecore.cs (FieldExpr): do not allow initialization of initonly
7056 fields on derived classes
7058 2003-03-13 Martin Baulig <martin@ximian.com>
7060 * statement.cs (Block.Emit): Call ig.BeginScope() and
7061 ig.EndScope() when compiling with debugging info; call
7062 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7064 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7066 * expression.cs (Indexers): Do not construct immediately, allow
7067 for new members to be appended as we go. Fixes 38143
7069 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7071 * expression.cs: save/restore context when resolving an unchecked
7074 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7076 * cfold.cs: Catch division by zero in modulus operator during
7079 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7081 * interface.cs (Interface.DefineMembers): Avoid defining members
7084 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7086 * driver.cs: handle the +/- options for -noconfig
7088 * statement.cs (Unckeched.Resolve): Also track the state of
7089 unchecked in the Resolve phase.
7091 2003-02-27 Martin Baulig <martin@ximian.com>
7093 * ecore.cs (Expression.MemberLookup): Don't create a
7094 MethodGroupExpr for something which is not a method. Fixes #38291.
7096 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7098 * class.cs (MemberBase.CheckParameters): Also check that the type
7099 is unmanaged if it is a pointer.
7101 * expression.cs (SizeOf.Resolve): Add location information.
7103 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7104 a managed type is declared.
7106 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7107 parameter modifiers as well. Fixes bug 38606
7109 * class.cs: Very sad. Am backing out the speed up changes
7110 introduced by the ArrayList -> Array in the TypeContainer, as they
7111 were not actually that much faster, and introduced a bug (no error
7112 reports on duplicated methods).
7114 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7115 source first, this will guarantee that we have a valid expression
7116 before calling in lower levels functions that will require a
7117 resolved object. Then use this original_source in the
7118 target.ResolveLValue instead of the original source that was
7121 Another change. Use target.Resolve instead of LValueResolve.
7122 Although we are resolving for LValues, we will let the Assign code
7123 take care of that (it will be called again from Resolve). This
7124 basically allows code like this:
7126 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7127 class Y { void A (X x) { x [0] += o; }
7129 The problem was that the indexer was trying to resolve for
7130 set_Item (idx, object o) and never finding one. The real set_Item
7131 was set_Item (idx, X). By delaying the process we get the right
7136 2003-02-23 Martin Baulig <martin@ximian.com>
7138 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7139 while calling DoEmit ().
7141 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7142 source files; if you use the #line directive inside a method, the
7143 compiler stops emitting line numbers for the debugger until it
7144 reaches the end of the method or another #line directive which
7145 restores the original file.
7147 2003-02-23 Martin Baulig <martin@ximian.com>
7149 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7151 2003-02-23 Martin Baulig <martin@ximian.com>
7153 * statement.cs (Block.AddChildVariableNames): We need to call this
7154 recursively, not just for our immediate children.
7156 2003-02-23 Martin Baulig <martin@ximian.com>
7158 * class.cs (Event.Define): Always make the field private, like csc does.
7160 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7161 actually work, fixes bug #37521.
7163 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7165 * delegate.cs: When creating the various temporary "Parameters"
7166 classes, make sure that we call the ComputeAndDefineParameterTypes
7167 on those new parameters (just like we do with the formal ones), to
7168 allow them to be resolved in the context of the DeclSpace.
7170 This fixes the bug that Dick observed in Bugzilla #38530.
7172 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7174 * expression.cs (ResolveMemberAccess): When resolving a constant,
7175 do not attempt to pull a constant if the value was not able to
7176 generate a valid constant.
7178 * const.cs (LookupConstantValue): Do not report more errors than required.
7180 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7182 * expression.cs: fixes bug #38328.
7184 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7186 * class.cs: Changed all the various members that can be part of a
7187 class from being an ArrayList to be an Array of the right type.
7188 During the DefineType type_list, interface_list, delegate_list and
7189 enum_list are turned into types, interfaces, delegates and enums
7192 And during the member population, indexer_list, event_list,
7193 constant_list, field_list, instance_constructor_list, method_list,
7194 operator_list and property_list are turned into their real arrays.
7196 Although we could probably perform this operation earlier, for
7197 good error reporting we need to keep the lists and remove the
7198 lists for longer than required.
7200 This optimization was triggered by Paolo profiling the compiler
7201 speed on the output of `gen-sample-program.pl' perl script.
7203 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7204 not crash in methods like MemberLookupFailed that use this field.
7206 This problem arises when the compiler fails to resolve a type
7207 during interface type definition for example.
7209 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7211 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7212 inherit from System.Object, so we have to stop at null, not only
7213 when reaching System.Object.
7215 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7217 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7218 DeclaredOnly because the parent indexer might have had a different
7219 name, but did not loop until the top of the hierarchy was reached.
7221 The problem this one fixes is 35492: when a class implemented an
7222 indexer from an interface, we were getting the interface method
7223 (which was abstract) and we were flagging an error (can not invoke
7226 This also keeps bug 33089 functioning, and test-148 functioning.
7228 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7229 out if a method is special is to see if it is declared in a
7230 property or event, or whether it is one of the predefined operator
7231 names. This should fix correctly #36804.
7233 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7235 The goal here is to remove the dependency on EmptyCast.Peel ().
7236 Killing it completely.
7238 The problem is that currently in a number of places where
7239 constants are expected, we have to "probe" for an EmptyCast, and
7240 Peel, which is not the correct thing to do, as this will be
7241 repetitive and will likely lead to errors.
7243 The idea is to remove any EmptyCasts that are used in casts that
7244 can be reduced to constants, so we only have to cope with
7247 This bug hunt was triggered by Bug 37363 and the desire to remove
7248 the duplicate pattern where we were "peeling" emptycasts to check
7249 whether they were constants. Now constants will always be
7252 * ecore.cs: Use an enumconstant here instead of wrapping with
7255 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7256 throwing me off. By handling this we can get rid of a few hacks.
7258 * statement.cs (Switch): Removed Peel() code.
7260 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7262 * class.cs: Location information for error 508
7264 * expression.cs (New.DoResolve): Add a guard against double
7265 resolution of an expression.
7267 The New DoResolve might be called twice when initializing field
7268 expressions (see EmitFieldInitializers, the call to
7269 GetInitializerExpression will perform a resolve on the expression,
7270 and later the assign will trigger another resolution
7272 This leads to bugs (#37014)
7274 * delegate.cs: The signature for EndInvoke should contain any ref
7275 or out parameters as well. We were not doing this in the past.
7277 * class.cs (Field.Define): Do not overwrite the type definition
7278 inside the `volatile' group. Turns out that volatile enumerations
7279 were changing the type here to perform a validity test, which
7282 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7284 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7285 and structs, we do not want to load the instance variable
7287 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7288 enum_type has to be handled like an object reference (implicit
7289 conversions exists from this to object), but the regular IsClass
7290 and IsValueType tests will never return true for this one.
7292 Also we use TypeManager.IsValueType instead of type.IsValueType,
7293 just for consistency with the rest of the code (this is only
7294 needed if we ever use the construct exposed by test-180.cs inside
7295 corlib, which we dont today).
7297 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7299 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7302 2003-02-09 Martin Baulig <martin@ximian.com>
7304 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7305 (Namespace.DefineNamespaces): New static public method; this is
7306 called when we're compiling with debugging to add all namespaces
7309 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7310 pass it to the Namespace's .ctor.
7312 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7313 and MethodBase arguments; pass the namespace ID to the symwriter;
7314 pass the MethodBase instead of the token to the symwriter.
7315 (SymbolWriter.DefineNamespace): New method to add a namespace to
7318 2003-02-09 Martin Baulig <martin@ximian.com>
7320 * symbolwriter.cs: New file. This is a wrapper around
7321 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7322 methods here in near future.
7324 2003-02-09 Martin Baulig <martin@ximian.com>
7326 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7327 ILGenerator.MarkSequencePoint() which are actually used by the
7330 2003-02-09 Martin Baulig <martin@ximian.com>
7332 * location.cs (SourceFile): New public sealed class. This
7333 contains the name and an index which is used in the location's token.
7334 (Location): Reserve an appropriate number of bits in the token for
7335 the source file instead of walking over that list, this gives us a
7336 really huge performance improvement when compiling with debugging.
7338 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7339 `SourceFile' argument instead of a string.
7340 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7341 but don't parse/tokenize here, we need to generate the list of all
7342 source files before we do that.
7343 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7346 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7347 instead of a string.
7349 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7352 2003-02-09 Martin Baulig <martin@ximian.com>
7354 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7355 filename on `#line default'.
7357 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7359 * statement.cs: don't clear the pinned var when the fixed statement
7360 returns from the method (fixes bug#37752).
7362 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7364 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7367 2003-02-07 Martin Baulig <martin@ximian.com>
7369 * driver.cs: Removed the `--debug-args' command line argument.
7371 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7372 automatically by the AsssemblyBuilder.
7373 (CodeGen.InitializeSymbolWriter): We don't need to call any
7374 initialization function on the symbol writer anymore. This method
7375 doesn't take any arguments.
7377 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7379 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7380 from referenced assemblies as well.
7382 2003-02-02 Martin Baulig <martin@ximian.com>
7384 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7386 2003-02-02 Martin Baulig <martin@ximian.com>
7388 * class.cs (Constructor.Emit): Open the symbol writer before
7389 emitting the constructor initializer.
7390 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7391 single-stepping through constructor initializers.
7393 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7395 * class.cs: Handle error 549: do not allow virtual methods in
7398 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7400 * decl.cs: Check access levels when resolving types
7402 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7404 * statement.cs: Add parameters and locals set in catch blocks that might
7405 return to set vector
7407 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7409 * class.cs (Operator): Set the SpecialName flags for operators.
7411 * expression.cs (Invocation.DoResolve): Only block calls to
7412 accessors and operators on SpecialName methods.
7414 (Cast.TryReduce): Handle conversions from char constants.
7417 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7419 * statement.cs: small memory and time optimization in FlowBranching.
7421 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7423 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7424 problem that the last fix but in the other sid (Set).
7426 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7427 access when there is no indexer in the hierarchy.
7429 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7431 * class.cs: Combine some if statements.
7433 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7435 * driver.cs: fixed bug #37187.
7437 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7439 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7440 any indexer, it's needed to build a list with all the indexers in the
7441 hierarchy (AllGetters), else we have problems. Fixes #35653.
7443 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7445 * class.cs (MethodData.Define): It is wrong for an interface
7446 implementation to be static in both cases: explicit and implicit.
7447 We were only handling this in one case.
7449 Improve the if situation there to not have negations.
7451 * class.cs (Field.Define): Turns out that we do not need to check
7452 the unsafe bit on field definition, only on usage. Remove the test.
7454 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7456 * driver.cs: use assembly.Location instead of Codebase (the latest
7457 patch made mcs fail when using MS assemblies).
7459 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7461 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7462 get the path to *corlib.dll.
7464 2003-01-21 Nick Drochak <ndrochak@gol.com>
7468 * typemanager.cs: Remove compiler warnings
7470 2003-01-20 Duncan Mak <duncan@ximian.com>
7472 * AssemblyInfo.cs: Bump the version number to 0.19.
7474 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7476 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7478 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7480 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7482 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7484 * cs-parser.jay: Small fix: we were not comparing the constructor
7485 name correctly. Thanks to Zoltan for the initial pointer.
7487 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7489 * cs-tokenizer.cs: Set file name when specified with #line
7491 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7493 * cs-parser.jay: Only perform the constructor checks here if we
7494 are named like the class; This will help provider a better
7495 error. The constructor path is taken when a type definition is
7496 not found, but most likely the user forgot to add the type, so
7497 report that rather than the constructor error.
7499 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7501 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7504 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7506 * cs-parser.jay: Add cleanup call.
7508 2003-01-13 Duncan Mak <duncan@ximian.com>
7510 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7511 consistent with other methods.
7513 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7515 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7517 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7519 * attribute.cs: only set GuidAttr to true when we have a
7522 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7526 * typemanager.cs: fixes to allow mcs compile corlib with the new
7527 Type.IsSubclassOf fix.
7529 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7531 * expression.cs (LocalVariableReference.DoResolve): Classify a
7532 constant as a value, not as a variable. Also, set the type for
7535 * cs-parser.jay (fixed_statement): take a type instead of a
7536 pointer_type, so we can produce a better error message later.
7538 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7541 (For.DoEmit): Make inifinite loops have a
7542 non-conditional branch back.
7544 (Fixed.DoEmit): First populate the pinned variables, then emit the
7545 statement, then clear the variables. Before I was emitting the
7546 code once for each fixed piece.
7549 2003-01-08 Martin Baulig <martin@ximian.com>
7551 * statement.cs (FlowBranching.MergeChild): A break in a
7552 SWITCH_SECTION does not leave a loop. Fixes #36155.
7554 2003-01-08 Martin Baulig <martin@ximian.com>
7556 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7557 lives in the same number space than `param_map'. Fixes #36154.
7559 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7561 * cs-parser.jay (constructor_declaration): Set the
7562 Constructor.ModFlags before probing for it. This makes the
7563 compiler report 514, 515 and 132 (the code was there, but got
7566 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7567 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7568 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7570 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7572 * enum.cs: create the enum static fields using the enum type.
7574 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7576 * class.cs: don't try to create the ParamBuilder for the return
7577 type if it's not needed (and handle it breaking for the ms runtime
7580 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7582 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7584 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7586 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7587 the command. This showed up while compiling the JANET source
7588 code, which used \r as its only newline separator.
7590 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7592 * class.cs (Method.Define): If we are an operator (because it
7593 reuses our code), then set the SpecialName and HideBySig. #36128
7595 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7597 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7598 exception, report error 120 `object reference required'.
7600 * driver.cs: Add --pause option, used during to measure the size
7601 of the process as it goes with --timestamp.
7603 * expression.cs (Invocation.DoResolve): Do not allow methods with
7604 SpecialName to be invoked.
7606 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7608 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7609 number before adding it.
7611 2002-12-21 Ravi Pratap <ravi@ximian.com>
7613 * ecore.cs (StandardImplicitConversion): When in an unsafe
7614 context, we allow conversion between void * to any other pointer
7615 type. This fixes bug #35973.
7617 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7619 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7620 is not thrown when extensionless outputs are used
7622 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7624 * rootcontext.cs: fixed compilation of corlib.
7626 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7628 * attribute.cs (Attributes.Contains): Add new method.
7630 * class.cs (MethodCore.LabelParameters): if the parameter is an
7631 `out' parameter, check that no attribute `[In]' has been passed.
7633 * enum.cs: Handle the `value__' name in an enumeration.
7635 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7637 * decl.cs: Added special case to allow overrides on "protected
7640 2002-12-18 Ravi Pratap <ravi@ximian.com>
7642 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7643 since it makes much more sense.
7645 (Attributes.ctor): Don't require a Location parameter.
7647 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7649 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7650 since we already have that information per attribute.
7652 * everywhere : make appropriate changes.
7654 * class.cs (LabelParameters): Write the code which actually
7655 applies attributes to the return type. We can't do this on the MS
7656 .NET runtime so we flag a warning in the case an exception is
7659 2002-12-18 Miguel de Icaza <miguel@ximian.com>
7661 * const.cs: Handle implicit null conversions here too.
7663 2002-12-17 Ravi Pratap <ravi@ximian.com>
7665 * class.cs (MethodCore.LabelParameters): Remove the extra
7666 Type [] parameter since it is completely unnecessary. Instead
7667 pass in the method's attributes so that we can extract
7668 the "return" attribute.
7670 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7672 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7673 of ignoring it and letting the compile continue.
7675 * typemanager.cs (ChangeType): use an extra argument to return an
7676 error condition instead of throwing an exception.
7678 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7680 * expression.cs (Unary.TryReduce): mimic the code for the regular
7681 code path. Perform an implicit cast in the cases where we can
7682 implicitly convert to one of the integral types, and then reduce
7683 based on that constant. This fixes bug #35483.
7685 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7687 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7689 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7691 * namespace.cs: fixed bug #35489.
7693 2002-12-12 Miguel de Icaza <miguel@ximian.com>
7695 * class.cs: Remove some dead code.
7697 * cs-parser.jay: Estimate the number of methods needed
7698 (RootContext.MethodCount);
7700 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
7701 numbers instead of StringBuilders.
7703 * support.cs (PtrHashtable): Add constructor with initial size;
7704 We can now reduce reallocations of the method table.
7706 2002-12-10 Ravi Pratap <ravi@ximian.com>
7708 * attribute.cs (ApplyAttributes): Keep track of the emitted
7709 attributes on a per-target basis. This fixes bug #35413.
7711 2002-12-10 Miguel de Icaza <miguel@ximian.com>
7713 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
7714 default to the Windows 1252 encoding.
7716 (UnixParseOption): Support version, thanks to Alp for the missing
7719 * AssemblyInfo.cs: Add nice assembly information.
7721 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
7724 * cs-parser.jay: Allow a trailing comma before the close bracked
7725 in the attribute_section production.
7727 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
7728 address of the instance was being taken, I will take this out,
7729 because we take the address of the object immediately here.
7731 2002-12-09 Ravi Pratap <ravi@ximian.com>
7733 * typemanager.cs (AreMultipleAllowed): Take care of the most
7734 obvious case where attribute type is not in the current assembly -
7737 2002-12-08 Miguel de Icaza <miguel@ximian.com>
7739 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
7740 definitions, instead of doing that afterwards.
7742 Also we use a nice little hack, depending on the constructor, we
7743 know if we are a "composed" name or a simple name. Hence, we
7744 avoid the IndexOf test, and we avoid
7746 * codegen.cs: Add code to assist in a bug reporter to track down
7747 the source of a compiler crash.
7749 2002-12-07 Ravi Pratap <ravi@ximian.com>
7751 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
7752 types have been emitted for a given element and flag an error
7753 if something which does not have AllowMultiple set is used more
7756 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
7757 attribute types and their corresponding AllowMultiple properties
7759 (AreMultipleAllowed): Check the property for a given type.
7761 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
7762 property in the case we have a TypeContainer.
7764 (Attributes.AddAttribute): Detect duplicates and just skip on
7765 adding them. This trivial fix catches a pretty gross error in our
7766 attribute emission - global attributes were being emitted twice!
7768 Bugzilla bug #33187 is now fixed.
7770 2002-12-06 Miguel de Icaza <miguel@ximian.com>
7772 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
7775 * expression.cs (Binary.ResolveOperator): I can only use the
7776 Concat (string, string, string) and Concat (string, string,
7777 string, string) if the child is actually a concatenation of
7780 2002-12-04 Miguel de Icaza <miguel@ximian.com>
7782 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
7783 context where we need a 2-character lookahead.
7785 * pending.cs (PendingImplementation): Rework so we can keep track
7786 of interface types all the time, and flag those which were
7787 implemented by parents as optional.
7789 2002-12-03 Miguel de Icaza <miguel@ximian.com>
7791 * expression.cs (Binary.ResolveOperator): Use
7792 String.Concat(string,string,string) or
7793 String.Concat(string,string,string,string) when possible.
7795 * typemanager: More helper methods.
7798 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
7800 * pending.cs: remove the bogus return from GetMissingInterfaces()
7801 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
7803 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7805 * namespace.cs: avoid duplicated 'using xxx' being added to
7806 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
7807 when we get more than one 'using' statement for the same namespace.
7808 Report a CS0105 warning for it.
7810 2002-11-30 Miguel de Icaza <miguel@ximian.com>
7812 * cs-tokenizer.cs (consume_identifier): use read directly, instead
7813 of calling getChar/putback, uses internal knowledge of it.
7815 (xtoken): Reorder tokenizer so most common patterns are checked
7816 first. This reduces the compilation time in another 5% (from 8.11s
7817 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
7819 The parsing time is 22% of the compilation in mcs, and from that
7820 64% is spent on the tokenization process.
7822 I tried using a binary search for keywords, but this is slower
7823 than the hashtable. Another option would be to do a couple of
7826 * Not use a StringBuilder, instead use an array of chars,
7827 with a set value. Notice that this way we could catch
7828 the 645 error without having to do it *afterwards*.
7830 * We could write a hand-parser to avoid the hashtable
7831 compares altogether.
7833 The identifier consumption process takes 37% of the tokenization
7834 time. Another 15% is spent on is_number. 56% of the time spent
7835 on is_number is spent on Int64.Parse:
7837 * We could probably choose based on the string length to
7838 use Int32.Parse or Int64.Parse and avoid all the 64-bit
7841 Another 3% is spend on wrapping `xtoken' in the `token' function.
7843 Handle 0xa0 as whitespace (#34752)
7845 2002-11-26 Miguel de Icaza <miguel@ximian.com>
7847 * typemanager.cs (IsCLRType): New routine to tell whether a type
7848 is one of the builtin types.
7850 Maybe it needs to use TypeCodes to be faster. Maybe we could use
7851 typecode in more places instead of doing pointer comparissions.
7852 We could leverage some knowledge about the way the typecodes are
7855 New code to cache namespaces in assemblies, it is currently not
7856 invoked, to be used soon.
7858 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
7860 * expression.cs (Binary.ResolveOperator): specially handle
7861 strings, and do not perform user-defined operator overloading for
7864 2002-11-24 Miguel de Icaza <miguel@ximian.com>
7866 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
7867 internalcall as it is a pretty simple operation; Avoid whenever
7868 possible to call Char.IsLetter.
7870 (consume_identifier): Cut by half the number of
7871 hashtable calls by merging the is_keyword and GetKeyword behavior.
7873 Do not short-circuit, because if we do, we
7874 report errors (ie, #if false && true would produce an invalid
7878 2002-11-24 Martin Baulig <martin@ximian.com>
7880 * expression.cs (Cast.TryReduce): If we're in checked syntax,
7881 check constant ranges and report a CS0221. Fixes #33186.
7883 2002-11-24 Martin Baulig <martin@ximian.com>
7885 * cs-parser.jay: Make this work for uninitialized variable
7886 declarations in the `for' initializer. Fixes #32416.
7888 2002-11-24 Martin Baulig <martin@ximian.com>
7890 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
7891 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
7893 2002-11-24 Martin Baulig <martin@ximian.com>
7895 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
7896 argument; if true, we also check for user-defined conversions.
7897 This is only needed if both arguments are of a user-defined type.
7898 Fixes #30443, added test-175.cs.
7899 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
7901 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
7903 2002-11-24 Martin Baulig <martin@ximian.com>
7905 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
7906 function to get the store opcode.
7907 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
7908 only emit the Ldelema if the store opcode is Stobj. You must run
7909 both test-34 and test-167 to test this. Fixes #34529.
7911 2002-11-23 Martin Baulig <martin@ximian.com>
7913 * ecore.cs (Expression.MemberLookup): Added additional
7914 `qualifier_type' argument which is used when we're being called
7915 from MemberAccess.DoResolve() and null if we're called from a
7917 (Expression.MemberLookupFailed): New method to report errors; this
7918 does the CS1540 check and reports the correct error message.
7920 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
7921 argument for the CS1540 check and redone the way how we're dealing
7922 with private members. See the comment in the source code for details.
7923 (FilterWithClosure): Reverted this back to revision 1.197; renamed
7924 `closure_start_type' to `closure_qualifier_type' and check whether
7925 it's not null. It was not this filter being broken, it was just
7926 being called with the wrong arguments.
7928 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
7929 and pass it the correct `qualifier_type'; this also does the error
7932 2002-11-22 Miguel de Icaza <miguel@ximian.com>
7934 * expression.cs (Invocation.EmitParams): If the we are dealing
7935 with a non-built-in value type, load its address as well.
7937 (ArrayCreation): Use a a pretty constant instead
7938 of the hardcoded value 2. Use 6 instead of 2 for the number of
7939 static initializers.
7941 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
7942 because they are not really value types, just glorified integers.
7944 * driver.cs: Do not append .exe, the CSC compiler does not do it.
7946 * ecore.cs: Remove redundant code for enumerations, make them use
7947 the same code path as everything else, fixes the casting issue
7948 with enumerations in Windows.Forms.
7950 * attribute.cs: Do only cast to string if it is a string, the
7951 validation happens later.
7953 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
7954 people upgrade their corlibs.
7956 * ecore.cs: Oops, enumerations were not following the entire code path
7958 2002-11-21 Miguel de Icaza <miguel@ximian.com>
7960 * typemanager.cs (FilterWithClosure): Commented out the test for
7961 1540 in typemanager.cs, as it has problems when accessing
7962 protected methods from a parent class (see test-174.cs).
7964 * attribute.cs (Attribute.ValidateGuid): new method.
7965 (Attribute.Resolve): Use above.
7967 2002-11-19 Miguel de Icaza <miguel@ximian.com>
7969 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
7971 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
7972 handling for enumerations, as we only needed the TypeContainer
7973 functionality to begin with (this is required for the fix below to
7974 work for enums that reference constants in a container class for
7977 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
7979 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
7980 a valid TypeBuilder to perform lookups on.o
7982 * class.cs (InheritableMemberSignatureCompare): Use true in the
7983 call to GetGetMethod and GetSetMethod, because we are comparing
7984 the signature, and we need to get the methods *even* if they are
7987 (PropertyBase.CheckBase): ditto.
7989 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
7990 GotoCase.Resolve): Use Peel on EmpytCasts.
7992 * ecore.cs (EmptyCast): drop child, add Peel method.
7994 2002-11-17 Martin Baulig <martin@ximian.com>
7996 * ecore.cs (EmptyCast.Child): New public property.
7998 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
7999 label resolved to an EmptyCast. Fixes #34162.
8000 (GotoCase.Resolve): Likewise.
8001 (Block.EmitMeta): Likewise.
8003 2002-11-17 Martin Baulig <martin@ximian.com>
8005 * expression.cs (Invocation.BetterConversion): Prefer int over
8006 uint; short over ushort; long over ulong for integer literals.
8007 Use ImplicitConversionExists instead of StandardConversionExists
8008 since we also need to check for user-defined implicit conversions.
8009 Fixes #34165. Added test-173.cs.
8011 2002-11-16 Martin Baulig <martin@ximian.com>
8013 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8014 with the `true' and `false' literals. Fixes #33151.
8016 2002-11-16 Martin Baulig <martin@ximian.com>
8018 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8019 October 22nd; don't do the cs1540 check for static members.
8021 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8022 now using our own filter here and doing the cs1540 check again.
8024 2002-11-16 Martin Baulig <martin@ximian.com>
8026 * support.cs (InternalParameters): Don't crash if we don't have
8027 any fixed parameters. Fixes #33532.
8029 2002-11-16 Martin Baulig <martin@ximian.com>
8031 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8032 when looking up static methods to make this work on Windows.
8035 2002-11-16 Martin Baulig <martin@ximian.com>
8037 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8038 a setter rather than using PropertyInfo.CanWrite.
8040 2002-11-15 Nick Drochak <ndrochak@gol.com>
8042 * class.cs: Allow acces to block member by subclasses. Fixes build
8045 2002-11-14 Martin Baulig <martin@ximian.com>
8047 * class.cs (Constructor.Emit): Added the extern/block check.
8050 2002-11-14 Martin Baulig <martin@ximian.com>
8052 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8053 iteration while looking for indexers, this is needed because the
8054 indexer may have a different name in our base classes. Fixed the
8055 error reporting (no indexers at all, not get accessor, no
8056 overloaded match). Fixes bug #33089.
8057 (IndexerAccess.DoResolveLValue): Likewise.
8059 2002-11-14 Martin Baulig <martin@ximian.com>
8061 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8062 indexers. Fixes the first part of bug #33089.
8063 (MethodSignature.InheritableMemberSignatureCompare): Added support
8066 2002-11-13 Ravi Pratap <ravi@ximian.com>
8068 * attribute.cs (Attribute.Resolve): Catch the
8069 NullReferenceException and report it since it isn't supposed to
8072 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8074 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8075 LogicalOr and LogicalAnd that can benefit from recursively
8076 handling EmitBranchable. The code now should be nice for Paolo.
8078 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8080 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8081 the Type lookups, as we perform quite a number of lookups on
8082 non-Types. This can be removed once we can deterministically tell
8083 whether we have a type or a namespace in advance.
8085 But this might require special hacks from our corlib.
8089 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8090 and double which avoids a conversion from an integer to a double.
8092 * expression.cs: tiny optimization, avoid calling IsConstant,
8093 because it effectively performs the lookup twice.
8095 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8097 But a bogus return here to keep the semantics of the old code
8098 until the Mono runtime is fixed.
8100 * pending.cs (GetMissingInterfaces): New method used to remove all
8101 the interfaces that are already implemented by our parent
8102 classes from the list of pending methods.
8104 * interface.cs: Add checks for calls after ResolveTypeExpr.
8106 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8108 * class.cs (Class.Emit): Report warning 67: event not used if the
8109 warning level is beyond 3.
8111 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8112 being a NullLiteral.
8114 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8117 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8118 path that might fail if a type can not be resolved.
8120 * expression.cs (Binary.Emit): Emit unsigned versions of the
8123 * driver.cs: use error 5.
8125 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8127 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8129 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8131 * cs-parser.jay (switch_section): A beautiful patch from Martin
8132 Baulig that fixed 33094.
8134 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8136 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8137 Check whether the base is abstract and report an error if so.
8139 * expression.cs (IndexerAccess.DoResolveLValue,
8140 IndexerAccess.DoResolve): ditto.
8142 (Invocation.DoResolve): ditto.
8144 (Invocation.FullMethodDesc): Improve the report string.
8146 * statement.cs (Block): Eliminate IsVariableDefined as it is
8147 basically just a wrapper for GetVariableInfo.
8149 * ecore.cs (SimpleName): Use new
8151 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8152 type, as we return the actual parameter ref/unref state on a
8155 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8157 * support.cs: Return proper flags REF/OUT fixing the previous
8160 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8161 not used to mean `ref' but `ref or out' in ParameterReference
8163 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8164 full type signature instead of calling TypeManger.CSharpName
8167 * support.cs (InternalParameters.ParameterDesc): Do not compare
8168 directly to the modflags, because REF/OUT will actually be bitsets
8171 * delegate.cs (VerifyMethod): Check also the modifiers.
8173 * cs-tokenizer.cs: Fix bug where floating point values with an
8174 exponent where a sign was missing was ignored.
8176 * driver.cs: Allow multiple assemblies to be specified in a single
8179 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8181 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8182 because identifiers after a parenthesis would end up in this kind
8183 of production, and we needed to desamiguate it for having casts
8186 (UserDefinedType *) xxx
8188 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8190 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8191 we should set on the Bindingflags.NonPublic, but not turn on
8192 private_ok. private_ok controls whether a Private member is
8193 returned (this is chekced on the filter routine), while the
8194 BindingFlags.NonPublic just controls whether private/protected
8195 will be allowed. This fixes the problem part of the problem of
8196 private properties being allowed to be used in derived classes.
8198 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8199 so we can call the children DoResolveLValue method (this will
8200 properly signal errors on lvalue assignments to base properties)
8202 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8203 getter are null, and we have a property info, we know that this
8204 happened because the lookup failed, so we report an error 122 for
8205 protection level violation.
8207 We also silently return if setter and getter are null in the
8208 resolve functions, this condition only happens if we have flagged
8209 the error before. This is the other half of the problem.
8211 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8212 not have accessibility information, that is why we were returning
8213 true in the filter function in typemanager.cs.
8215 To properly report 122 (property is inaccessible because of its
8216 protection level) correctly, we report this error in ResolveAccess
8217 by failing if both the setter and the getter are lacking (ie, the
8220 DoResolve and DoLResolve have been modified to check for both
8221 setter/getter being null and returning silently, the reason being
8222 that I did not want to put the knowledge about this error in upper
8225 int old = Report.Errors;
8226 x = new PropertyExpr (...);
8227 if (old != Report.Errors)
8232 So the property expr is returned, but it is invalid, so the error
8233 will be flagged during the resolve process.
8235 * class.cs: Remove InheritablePropertySignatureCompare from the
8236 class, as we no longer depend on the property signature to compute
8237 whether it is possible to implement a method or not.
8239 The reason is that calling PropertyInfo.GetGetMethod will return
8240 null (in .NET, in Mono it works, and we should change this), in
8241 cases where the Get Method does not exist in that particular
8246 class X { public virtual int A { get { return 1; } } }
8248 class Z : Y { public override int A { get { return 2; } } }
8250 Would fail in Z because the parent (Y) would not have the property
8251 defined. So we avoid this completely now (because the alternative
8252 fix was ugly and slow), and we now depend exclusively on the
8255 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8256 reference method, instead of using the property.
8258 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8259 routines are gone now.
8261 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8262 names, they were incorrectly named.
8264 * cs-tokenizer.cs: Return are more gentle token on failure.
8266 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8267 had an out-of-sync index variable, which caused it to remove from
8268 the list of pending methods the wrong method sometimes.
8270 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8272 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8273 CanWrite, because those refer to this particular instance of the
8274 property, and do not take into account the fact that we can
8275 override single members of a property.
8277 Constructor requires an EmitContext. The resolution process does
8278 not happen here, but we need to compute the accessors before,
8279 because the resolution does not always happen for properties.
8281 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8282 subclass, before we did not update this flag, but we did update
8285 (GetAccessors): Drop this routine, as it did not work in the
8286 presence of partially overwritten set/get methods.
8288 Notice that this broke the cs1540 detection, but that will require
8291 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8295 * driver.cs: issue a warning instead of an error if we don't support
8296 debugging for the platform. Also ignore a couple of errors that may
8297 arise when trying to write the symbols. Undo my previous patch.
8299 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8301 * driver.cs: ignore /debug switch except for Unix platforms.
8303 2002-10-23 Nick Drochak <ndrochak@gol.com>
8305 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8307 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8309 * driver.cs: Do not make mcs-debug conditional, so we do not break
8312 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8313 review this patch. But basically after all the children variables
8314 have been merged, the value of "Breaks" was not being set to
8315 new_breaks for Switch blocks. I think that it should be set after
8316 it has executed. Currently I set this to the value of new_breaks,
8317 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8318 conservative, but I do not understand this code very well.
8320 I did not break anything in the build, so that is good ;-)
8322 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8324 2002-10-20 Mark Crichton <crichton@gimp.org>
8326 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8328 2002-10-20 Nick Drochak <ndrochak@gol.com>
8330 * cfold.cs: Fixed compile blocker.
8332 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8334 * driver.cs: I was chekcing the key, not the file.
8336 2002-10-19 Ravi Pratap <ravi@ximian.com>
8338 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8339 message that we were generating - we just need to silently return
8342 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8344 * class.cs (Event.Define): Change my previous commit, as this
8345 breaks the debugger. This is a temporary hack, as it seems like
8346 the compiler is generating events incorrectly to begin with.
8348 * expression.cs (Binary.ResolveOperator): Added support for
8349 "U operator - (E x, E y)"
8351 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8354 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8355 init-only variables, but this path did not take into account that
8356 there might be also instance readonly variables. Correct this
8359 This fixes bug 32253
8361 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8364 * driver.cs: Change the extension for modules to `netmodule'
8366 * cs-parser.jay: Improved slightly the location tracking for
8367 the debugger symbols.
8369 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8370 modifiers that were specified instead of the hardcoded value
8371 (FamAndAssem). This was basically ignoring the static modifier,
8372 and others. Fixes 32429.
8374 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8375 fixed a bug in the process (32476)
8377 * expression.cs (ArrayAccess.EmitAssign): Patch from
8378 hwang_rob@yahoo.ca that fixes bug 31834.3
8380 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8382 * driver.cs: Make the module extension .netmodule.
8384 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8386 * driver.cs: Report an error if the resource file is not found
8387 instead of crashing.
8389 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8390 false, like Emit does.
8392 2002-10-16 Nick Drochak <ndrochak@gol.com>
8394 * typemanager.cs: Remove unused private member. Also reported mcs
8395 bug to report this as a warning like csc.
8397 2002-10-15 Martin Baulig <martin@gnome.org>
8399 * statement.cs (Statement.Emit): Made this a virtual method; emits
8400 the line number info and calls DoEmit().
8401 (Statement.DoEmit): New protected abstract method, formerly knows
8402 as Statement.Emit().
8404 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8406 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8408 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8409 have fixed a remaining problem: not every AddXXXX was adding a
8410 fully qualified name.
8412 Now everyone registers a fully qualified name in the DeclSpace as
8413 being defined instead of the partial name.
8415 Downsides: we are slower than we need to be due to the excess
8416 copies and the names being registered this way.
8418 The reason for this is that we currently depend (on the corlib
8419 bootstrap for instance) that types are fully qualified, because
8420 we dump all the types in the namespace, and we should really have
8421 types inserted into the proper namespace, so we can only store the
8422 basenames in the defined_names array.
8424 2002-10-10 Martin Baulig <martin@gnome.org>
8426 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8427 from bug #31834, see the bug report for a testcase which is
8430 2002-10-10 Martin Baulig <martin@gnome.org>
8432 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8433 flow analysis code for this.
8435 * statement.cs (Do, While, For): Tell the flow analysis code about
8437 (FlowBranching.UsageVector): Added support for infinite loops.
8438 (Block.Resolve): Moved the dead code elimination here and use flow
8441 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8443 * class.cs (Field.Define): Catch cycles on struct type
8446 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8447 fields if the fields are static. We only need to check instance
8450 * expression.cs (As.DoResolve): Test for reference type.
8452 * statement.cs (Using.ResolveExpression): Use
8453 ConvertImplicitRequired, not ConvertImplicit which reports an
8455 (Using.ResolveLocalVariableDecls): ditto.
8457 * expression.cs (Binary.ResolveOperator): Report errors in a few
8458 places where we had to.
8460 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8462 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8464 * expression.cs: Use StoreFromPtr instead of extracting the type
8465 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8467 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8468 an enumeration value to a System.Enum, but System.Enum is not a
8469 value type, but an class type, so we need to box.
8471 (Expression.ConvertExplicit): One codepath could return
8472 errors but not flag them. Fix this. Fixes #31853
8474 * parameter.cs (Resolve): Do not allow void as a parameter type.
8476 2002-10-06 Martin Baulig <martin@gnome.org>
8478 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8479 if it's a class type and not a struct. Fixes #31815.
8481 2002-10-06 Martin Baulig <martin@gnome.org>
8483 * statement.cs: Reworked the flow analysis code a bit to make it
8484 usable for dead code elimination.
8486 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8488 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8490 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8492 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8493 to fix the test 165, will investigate deeper.
8495 2002-10-04 Martin Baulig <martin@gnome.org>
8497 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8498 finally blocks actually work.
8499 (Try.Resolve): We don't need to create a sibling for `finally' if
8500 there is no finally block.
8502 2002-10-04 Martin Baulig <martin@gnome.org>
8504 * class.cs (Constructor.Define): The default accessibility for a
8505 non-default constructor is private, not public.
8507 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8509 * class.cs (Constructor): Make AllowedModifiers public, add
8512 * cs-parser.jay: Perform the modifiers test here, as the
8513 constructor for the Constructor class usually receives a zero
8514 because of the way we create it (first we create, later we
8515 customize, and we were never checking the modifiers).
8517 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8518 is a version of LookupTypeReflection that includes the type-name
8519 cache. This can be used as a fast path for functions that know
8520 the fully qualified name and are only calling into *.GetType() to
8521 obtain a composed type.
8523 This is also used by TypeManager.LookupType during its type
8526 (LookupType): We now also track the real type name, as sometimes
8527 we can get a quey for the real type name from things like
8528 ComposedCast. This fixes bug 31422.
8530 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8531 complete type fullname, it does not have to go through the type
8532 resolution system to obtain the composed version of the type (for
8533 obtaining arrays or pointers).
8535 (Conditional.Emit): Use the EmitBoolExpression to
8536 generate nicer code, as requested by Paolo.
8538 (ArrayCreation.CheckIndices): Use the patch from
8539 hwang_rob@yahoo.ca to validate the array initializers.
8541 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8543 * class.cs (ConstructorInitializer.Emit): simplify code by using
8544 Invocation.EmitCall, and at the same time, fix the bugs in calling
8545 parent constructors that took variable arguments.
8547 * ecore.cs (Expression.ConvertNumericExplicit,
8548 Expression.ImplicitNumericConversion): Remove the code that
8549 manually wrapped decimal (InternalTypeConstructor call is now gone
8552 * expression.cs (Cast.TryReduce): Also handle decimal types when
8553 trying to perform a constant fold on the type.
8555 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8557 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8558 that only turned off an error report, and did nothing else.
8560 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8562 * driver.cs: Handle and ignore /fullpaths
8564 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8566 * expression.cs (Binary.ResolveOperator): Catch the case where
8567 DoNumericPromotions returns true,
8569 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8571 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8573 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8576 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8578 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8579 conversion exists, but it is also required that the conversion be
8580 performed. This manifested in "(Type64Enum) 2".
8582 * class.cs (TypeManager.AddMethod): The fix is not to change
8583 AddEnum, because that one was using a fully qualified name (every
8584 DeclSpace derivative does), but to change the AddMethod routine
8585 that was using an un-namespaced name. This now correctly reports
8586 the duplicated name.
8588 Revert patch until I can properly fix it. The issue
8589 is that we have a shared Type space across all namespaces
8590 currently, which is wrong.
8592 Options include making the Namespace a DeclSpace, and merge
8593 current_namespace/current_container in the parser.
8595 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8597 * cs-parser.jay: Improve error reporting when we get a different
8598 kind of expression in local_variable_type and
8599 local_variable_pointer_type.
8601 Propagate this to avoid missleading errors being reported.
8603 * ecore.cs (ImplicitReferenceConversion): treat
8604 TypeManager.value_type as a target just like object_type. As
8609 Is valid, and needs to result in the int 1 being boxed before it
8610 is assigned to the value type v.
8612 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8613 to validate the enumeration name.
8615 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8616 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8617 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8619 * ecore.cs (TryImplicitIntConversion): When doing an
8620 implicit-enumeration-conversion, check if the type is 64-bits and
8621 perform a conversion before passing to EnumConstant.
8623 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8625 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8626 report ambiguous type references. Unlike the MS version, we
8627 report what the ambiguity is. Innovation at work ;-)
8629 (DeclSpace.FindType): Require a location argument to
8630 display when we display an ambiguous error.
8632 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8634 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8636 * expression.cs (EmitDynamicInitializers): Apply patch from
8637 hwang_rob@yahoo.ca that fixes the order in which we emit our
8640 2002-09-21 Martin Baulig <martin@gnome.org>
8642 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8643 delegate takes no arguments.
8645 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8647 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8650 * expression.cs: Extract the underlying type.
8652 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
8654 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
8656 2002-09-19 Miguel de Icaza <miguel@ximian.com>
8658 * class.cs (TypeContainer.DefineType): We can not use the nice
8659 PackingSize with the size set to 1 DefineType method, because it
8660 will not allow us to define the interfaces that the struct
8663 This completes the fixing of bug 27287
8665 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
8666 means also structs. This fixes part of the problem.
8667 (Expresion.ImplicitReferenceConversionExists): ditto.
8669 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8670 error if there were no errors reported during the type lookup
8671 process, to avoid duplicates or redundant errors. Without this
8672 you would get an ambiguous errors plus a type not found. We have
8673 beaten the user enough with the first error.
8675 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8678 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8679 during the resolution process, stop the lookup, this avoids
8680 repeated error reports (same error twice).
8682 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8684 * typemanager.cs (LookupType): Redo the type lookup code to match
8685 the needs of System.Reflection.
8687 The issue is that System.Reflection requires references to nested
8688 types to begin with a "+" sign instead of a dot. So toplevel
8689 types look like: "NameSpace.TopLevelClass", and nested ones look
8690 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
8693 2002-09-19 Martin Baulig <martin@gnome.org>
8695 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
8696 says that a method always returns or always throws an exception,
8697 don't report the CS0161.
8699 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
8700 set `Returns = new_returns'.
8702 2002-09-19 Martin Baulig <martin@gnome.org>
8704 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
8705 to an enum constant, check for a CS0176.
8707 2002-09-18 Miguel de Icaza <miguel@ximian.com>
8709 * class.cs (TypeContainer.CheckPairedOperators): Now we check
8710 for operators that must be in pairs and report errors.
8712 * ecore.cs (SimpleName.DoResolveType): During the initial type
8713 resolution process, when we define types recursively, we must
8714 check first for types in our current scope before we perform
8715 lookups in the enclosing scopes.
8717 * expression.cs (MakeByteBlob): Handle Decimal blobs.
8719 (Invocation.VerifyArgumentsCompat): Call
8720 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
8721 I thought we were supposed to always call this, but there are a
8722 few places in the code where we dont do it.
8724 2002-09-17 Miguel de Icaza <miguel@ximian.com>
8726 * driver.cs: Add support in -linkres and -resource to specify the
8727 name of the identifier.
8729 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8731 * ecore.cs (StandardConversionExists): Sync with the conversion
8732 code: allow anything-* to void* conversions.
8734 (FindMostSpecificSource): Use an Expression argument
8735 instead of a Type, because we might be handed over a Literal which
8736 gets a few more implicit conversions that plain types do not. So
8737 this information was being lost.
8739 Also, we drop the temporary type-holder expression when not
8742 2002-09-17 Martin Baulig <martin@gnome.org>
8744 * class.cs (PropertyBase.CheckBase): Don't check the base class if
8745 this is an explicit interface implementation.
8747 2002-09-17 Martin Baulig <martin@gnome.org>
8749 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
8750 different `IndexerName' attributes.
8752 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
8753 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
8754 virtual CommonResolve().
8756 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8758 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
8759 and convert that to the UnderlyingType.
8761 * statement.cs (Foreach.Resolve): Indexers are just like variables
8762 or PropertyAccesses.
8764 * cs-tokenizer.cs (consume_string): Track line numbers and columns
8765 inside quoted strings, we were not doing this before.
8767 2002-09-16 Martin Baulig <martin@gnome.org>
8769 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
8770 resolve it. This is needed for the definite assignment check of the
8771 instance expression, fixes bug #29846.
8772 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
8774 2002-09-16 Nick Drochak <ndrochak@gol.com>
8776 * parameter.cs: Fix compile error. Cannot reference static member
8777 from an instance object. Is this an mcs bug?
8779 2002-09-14 Martin Baulig <martin@gnome.org>
8781 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
8782 multiple times. Fixes bug #30295, added test-166.cs.
8784 2002-09-14 Martin Baulig <martin@gnome.org>
8786 * statement.cs (Block.Emit): Don't emit unreachable code.
8787 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
8789 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
8791 2002-09-14 Martin Baulig <martin@gnome.org>
8793 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
8796 2002-09-14 Martin Baulig <martin@gnome.org>
8798 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
8799 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
8800 be false on the ms runtime.
8802 2002-09-13 Martin Baulig <martin@gnome.org>
8804 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
8805 the CS0038 error message.
8807 2002-09-12 Miguel de Icaza <miguel@ximian.com>
8809 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
8810 constant inside, return it.
8812 2002-09-12 Martin Baulig <martin@gnome.org>
8814 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
8815 implicit conversion can be done between enum types.
8817 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
8818 check whether an implicit conversion to the current enum's UnderlyingType
8819 exists and report an error if not.
8821 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
8822 without debugging support.
8824 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
8825 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
8827 2002-09-12 Martin Baulig <martin@gnome.org>
8829 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
8831 * ecore.cs (IMemberExpr.DeclaringType): New property.
8832 (SimpleName.SimpleNameResolve): Check whether we're accessing a
8833 nonstatic member of an outer type (CS0038).
8835 2002-09-11 Miguel de Icaza <miguel@ximian.com>
8837 * driver.cs: Activate the using-error detector at warning level
8838 4 (at least for MS-compatible APIs).
8840 * namespace.cs (VerifyUsing): Small buglett fix.
8842 * pending.cs (PendingImplementation): pass the container pointer.
8844 * interface.cs (GetMethods): Allow for recursive definition. Long
8845 term, I would like to move every type to support recursive
8846 definitions, not the current ordering mechanism that we have right
8849 The situation is this: Attributes are handled before interfaces,
8850 so we can apply attributes to interfaces. But some attributes
8851 implement interfaces, we will now handle the simple cases
8852 (recursive definitions will just get an error).
8854 * parameter.cs: Only invalidate types at the end if we fail to
8857 2002-09-09 Martin Baulig <martin@gnome.org>
8859 * ecore.cs (PropertyExpr.Emit): Also check for
8860 TypeManager.system_int_array_get_length so this'll also work when
8861 compiling corlib. Fixes #30003.
8863 2002-09-09 Martin Baulig <martin@gnome.org>
8865 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
8866 and throw an exception if we can't get the type's size. Fixed #30040,
8869 2002-09-09 Martin Baulig <martin@gnome.org>
8871 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
8873 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
8874 context. Fixes bug #30027.
8876 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
8877 virtual functions. Fixes bug #30043, added test-164.cs.
8879 2002-09-08 Ravi Pratap <ravi@ximian.com>
8881 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
8883 2002-09-08 Nick Drochak <ndrochak@gol.com>
8885 * driver.cs: Use an object to get the windows codepage since it's not a
8888 2002-09-08 Miguel de Icaza <miguel@ximian.com>
8890 * statement.cs (For.Emit): for infinite loops (test == null)
8891 return whether there is a break inside, not always "true".
8893 * namespace.cs (UsingEntry): New struct to hold the name of the
8894 using definition, the location where it is defined, and whether it
8895 has been used in a successful type lookup.
8897 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
8902 2002-09-06 Ravi Pratap <ravi@ximian.com>
8904 * attribute.cs : Fix incorrect code which relied on catching
8905 a NullReferenceException to detect a null being passed in
8906 where an object was expected.
8908 2002-09-06 Miguel de Icaza <miguel@ximian.com>
8910 * statement.cs (Try): flag the catch variable as assigned
8912 * expression.cs (Cast): Simplified by using ResolveType instead of
8915 * statement.cs (Catch): Fix bug by using ResolveType.
8917 2002-09-06 Ravi Pratap <ravi@ximian.com>
8919 * expression.cs (BetterConversion): Special case for when we have
8920 a NullLiteral as the argument and we have to choose between string
8921 and object types - we choose string the way csc does.
8923 * attribute.cs (Attribute.Resolve): Catch the
8924 NullReferenceException and report error #182 since the Mono
8925 runtime no more has the bug and having this exception raised means
8926 we tried to select a constructor which takes an object and is
8929 2002-09-05 Ravi Pratap <ravi@ximian.com>
8931 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
8932 message (1502, 1503) when we can't locate a method after overload
8933 resolution. This is much more informative and closes the bug
8936 * interface.cs (PopulateMethod): Return if there are no argument
8937 types. Fixes a NullReferenceException bug.
8939 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
8940 expressions too. Previously we were checking only in one place for
8941 positional arguments leaving out named arguments.
8943 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
8944 type to the enum type is not allowed. Remove code corresponding to
8947 (ConvertNumericExplicit): Allow explicit conversions from
8948 the underlying type to enum type. This precisely follows the spec
8949 and closes a bug filed by Gonzalo.
8951 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8954 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
8956 2002-09-03 Miguel de Icaza <miguel@ximian.com>
8958 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
8959 it was important that we stored the right value after the
8960 reduction in `converted'.
8962 2002-09-04 Martin Baulig <martin@gnome.org>
8964 * location.cs (Location.SymbolDocument): Use full pathnames for the
8967 2002-08-30 Miguel de Icaza <miguel@ximian.com>
8969 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
8970 of the expression resolve mechanism, because that will catch the
8971 SimpleName error failures.
8973 (Conditional): If we can not resolve the
8974 expression, return, do not crash.
8976 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8979 (location): display token name instead of its number.
8981 2002-08-28 Martin Baulig <martin@gnome.org>
8983 * expression.cs (Binary.ResolveOperator): Don't silently return
8984 but return an error if an operator cannot be applied between two
8987 2002-08-28 Martin Baulig <martin@gnome.org>
8989 * class.cs (Constructor.Define): Set the permission attributes
8990 correctly instead of making all constructors public.
8992 2002-08-28 Martin Baulig <martin@gnome.org>
8994 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
8995 for private members before reporting a CS0103; if we find anything,
8998 2002-08-28 Martin Baulig <martin@gnome.org>
9000 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9001 to check whether `closure_start_type == closure_invocation_type',
9002 we also need to check whether `m.DeclaringType == closure_invocation_type'
9003 before bypassing the permission checks. We might be accessing
9004 protected/private members from the base class.
9005 (TypeManager.RealMemberLookup): Only set private_ok if private
9006 members were requested via BindingFlags.NonPublic.
9008 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9010 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9011 MethodGroupExpr.IsExplicitImpl if appropriate.
9012 (Invocation.DoResolve): Don't report the CS0120 for explicit
9013 interface implementations.
9015 2002-08-27 Martin Baulig <martin@gnome.org>
9017 * expression.cs (Invocation.DoResolve): If this is a static
9018 method and we don't have an InstanceExpression, we must report
9021 2002-08-25 Martin Baulig <martin@gnome.org>
9023 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9024 `==' between a valuetype and an object.
9026 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9028 * ecore.cs (TypeExpr): Provide a ToString method.
9030 2002-08-24 Martin Baulig <martin@gnome.org>
9032 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9033 now called proggie.dbg and it's a binary file.
9035 2002-08-23 Martin Baulig <martin@gnome.org>
9037 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9039 2002-08-23 Martin Baulig <martin@gnome.org>
9041 * struct.cs (MyStructInfo.ctor): Make this work with empty
9042 structs; it's not allowed to use foreach() on null.
9044 2002-08-23 Martin Baulig <martin@gnome.org>
9046 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9047 writer the full pathname of the generated assembly.
9049 2002-08-23 Martin Baulig <martin@gnome.org>
9051 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9052 A `finally' block never returns or breaks; improved handling of
9055 2002-08-23 Martin Baulig <martin@gnome.org>
9057 * statement.cs (Throw.Resolve): Allow `throw null'.
9059 2002-08-23 Martin Baulig <martin@gnome.org>
9061 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9062 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9063 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9064 MemberLookup would return a wrong event if this is an explicit
9065 interface implementation and the class has an event with the same
9068 2002-08-23 Martin Baulig <martin@gnome.org>
9070 * statement.cs (Block.AddChildVariableNames): New public method.
9071 (Block.AddChildVariableName): Likewise.
9072 (Block.IsVariableNameUsedInChildBlock): Likewise.
9073 (Block.AddVariable): Check whether a variable name has already
9074 been used in a child block.
9076 * cs-parser.jay (declare_local_variables): Mark all variable names
9077 from the current block as being used in a child block in the
9080 2002-08-23 Martin Baulig <martin@gnome.org>
9082 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9083 find the symbol writer.
9085 * driver.cs: csc also allows the arguments to /define being
9086 separated by commas, not only by semicolons.
9088 2002-08-23 Martin Baulig <martin@gnome.org>
9090 * interface.cs (Interface.GetMembers): Added static check for events.
9092 2002-08-15 Martin Baulig <martin@gnome.org>
9094 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9095 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9097 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9098 why the MethodData.EmitDestructor() change was necessary.
9100 2002-08-20 Martin Baulig <martin@gnome.org>
9102 * class.cs (TypeContainer.FindMembers): Added static check for events.
9104 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9106 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9107 use Type.GetEvents(), not Type.FindMembers().
9109 2002-08-20 Martin Baulig <martin@gnome.org>
9111 * decl.cs (MemberCache): Added a special method cache which will
9112 be used for method-only searched. This ensures that a method
9113 search will return a MethodInfo with the correct ReflectedType for
9116 2002-08-20 Martin Baulig <martin@gnome.org>
9118 * decl.cs (DeclSpace.FindMembers): Made this public.
9120 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9122 * delegate.cs: fixed build on windows.
9123 [FIXME: Filed as bug #29150: MCS must report these errors.]
9125 2002-08-19 Ravi Pratap <ravi@ximian.com>
9127 * ecore.cs (StandardConversionExists): Return a false
9128 if we are trying to convert the void type to anything else
9129 since that is not allowed.
9131 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9132 we flag error 70 in the event an event is trying to be accessed
9133 directly from outside the declaring type.
9135 2002-08-20 Martin Baulig <martin@gnome.org>
9137 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9138 MemberCache from typemanager.cs to decl.cs.
9140 2002-08-19 Martin Baulig <martin@gnome.org>
9142 * class.cs (TypeContainer): Implement IMemberContainer.
9143 (TypeContainer.DefineMembers): Create the MemberCache.
9144 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9145 return public members if BindingFlags.Public was given, check
9146 whether members are static.
9148 2002-08-16 Martin Baulig <martin@gnome.org>
9150 * decl.cs (DeclSpace.Define): Splitted this in Define and
9151 DefineMembers. DefineMembers is called first and initializes the
9154 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9155 DefineMembers() on all our DeclSpaces.
9157 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9158 but call DefineMembers() on all nested interfaces. We call their
9159 Define() in our new Define() function.
9161 * interface.cs (Interface): Implement IMemberContainer.
9162 (Interface.Define): Moved all code except the attribute stuf to
9164 (Interface.DefineMembers): Initialize the member cache.
9166 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9167 need this anymore since we can use MemberCache.FindMembers directly.
9169 2002-08-19 Martin Baulig <martin@gnome.org>
9171 * typemanager.cs (MemberCache): When creating the cache for an
9172 interface type, add all inherited members.
9173 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9174 to `out bool used_cache' and documented it.
9175 (TypeManager.MemberLookup): If we already used the cache in the first
9176 iteration, we don't need to do the interfaces check.
9178 2002-08-19 Martin Baulig <martin@gnome.org>
9180 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9181 here from IMemberFinder and don't implement this interface anymore.
9182 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9184 * typemanager.cs (IMemberFinder): This interface is now only used by
9185 classes which actually support the member cache.
9186 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9187 since we only put DeclSpaces into this Hashtable.
9188 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9189 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9191 2002-08-16 Martin Baulig <martin@gnome.org>
9193 * typemanager.cs (ICachingMemberFinder): Removed.
9194 (IMemberFinder.MemberCache): New property.
9195 (TypeManager.FindMembers): Merged this with RealFindMembers().
9196 This function will never be called from TypeManager.MemberLookup()
9197 so we can't use the cache here, just the IMemberFinder.
9198 (TypeManager.MemberLookup_FindMembers): Check whether the
9199 IMemberFinder has a MemberCache and call the cache's FindMembers
9201 (MemberCache): Rewrote larger parts of this yet another time and
9202 cleaned it up a bit.
9204 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9206 * driver.cs (LoadArgs): Support quoting.
9208 (Usage): Show the CSC-like command line arguments.
9210 Improved a few error messages.
9212 2002-08-15 Martin Baulig <martin@gnome.org>
9214 * typemanager.cs (IMemberContainer.Type): New property.
9215 (IMemberContainer.IsInterface): New property.
9217 The following changes are conditional to BROKEN_RUNTIME, which is
9218 defined at the top of the file.
9220 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9221 class'es members, but add all members from TypeHandle.ObjectType
9222 if we're an interface.
9223 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9224 is the current type.
9225 (MemberCache.CacheEntry.Container): Removed this field.
9226 (TypeHandle.GetMembers): Include inherited members.
9228 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9230 * typemanager.cs: fixed compilation and added a comment on a field that
9233 2002-08-15 Martin Baulig <martin@gnome.org>
9235 * class.cs (ConstructorInitializer.Resolve): In the
9236 Expression.MemberLookup call, use the queried_type as
9239 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9240 declared' attribute, it's always true.
9241 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9242 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9243 temporary wrapper for FindMembers which tells MemberLookup whether
9244 members from the base classes are included in the return value.
9245 This will go away soon.
9246 (TypeManager.MemberLookup): Use this temporary hack here; once the
9247 new MemberCache is completed, we don't need to do the DeclaredOnly
9248 looping here anymore since the MemberCache will take care of this.
9249 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9250 (MemberCache): When creating the MemberCache for a class, get
9251 members from the current class and all its base classes.
9252 (MemberCache.CacheEntry.Container): New field. This is a
9253 temporary hack until the Mono runtime is fixed to distinguish
9254 between ReflectedType and DeclaringType. It allows us to use MCS
9255 with both the MS runtime and the unfixed Mono runtime without
9256 problems and without accecting performance.
9257 (MemberCache.SearchMembers): The DeclaredOnly looping from
9258 TypeManager.MemberLookup is now done here.
9260 2002-08-14 Martin Baulig <martin@gnome.org>
9262 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9263 Type.GetFields on dynamic types but get the fields from the
9264 corresponding TypeContainer.
9265 (MyStructInfo.GetStructInfo): Added check for enum types.
9267 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9268 (MemberList.SyncRoot): Implemented.
9269 (TypeManager.FilterWithClosure): No need to check permissions if
9270 closure_start_type == closure_invocation_type, don't crash if
9271 closure_invocation_type is null.
9273 2002-08-13 Martin Baulig <martin@gnome.org>
9275 Rewrote TypeContainer.FindMembers to use a member cache. This
9276 gives us a speed increase of about 35% for the self-hosting MCS
9277 build and of about 15-20% for the class libs (both on GNU/Linux).
9279 * report.cs (Timer): New class to get enhanced profiling. This
9280 whole class is "TIMER" conditional since it remarkably slows down
9283 * class.cs (MemberList): New class. This is an IList wrapper
9284 which we're now using instead of passing MemberInfo[]'s around to
9285 avoid copying this array unnecessarily.
9286 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9287 (ICachingMemberFinder, IMemberContainer): New interface.
9288 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9289 has already been checked, otherwise use it for the name comparision.
9290 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9291 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9292 if possible. Returns a MemberList, not a MemberInfo [].
9293 (TypeHandle): New class, implements IMemberContainer. We create
9294 one instance of this class per type, it contains a MemberCache
9295 which is used to do the member lookups.
9296 (MemberCache): New class. Each instance of this class contains
9297 all members of a type and a name-based hash table.
9298 (MemberCache.FindMembers): This is our new member lookup
9299 function. First, it looks up all members of the requested name in
9300 the hash table. Then, it walks this list and sorts out all
9301 applicable members and returns them.
9303 2002-08-13 Martin Baulig <martin@gnome.org>
9305 In addition to a nice code cleanup, this gives us a performance
9306 increase of about 1.4% on GNU/Linux - not much, but it's already
9307 half a second for the self-hosting MCS compilation.
9309 * typemanager.cs (IMemberFinder): New interface. It is used by
9310 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9311 Enum, Delegate or Interface.
9312 (TypeManager.finder_to_member_finder): New PtrHashtable.
9313 (TypeManager.finder_to_container): Removed.
9314 (TypeManager.finder_to_delegate): Removed.
9315 (TypeManager.finder_to_interface): Removed.
9316 (TypeManager.finder_to_enum): Removed.
9318 * interface.cs (Interface): Implement IMemberFinder.
9320 * delegate.cs (Delegate): Implement IMemberFinder.
9322 * enum.cs (Enum): Implement IMemberFinder.
9324 * class.cs (TypeContainer): Implement IMemberFinder.
9326 2002-08-12 Martin Baulig <martin@gnome.org>
9328 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9330 2002-08-12 Martin Baulig <martin@gnome.org>
9332 * ecore.cs (ITypeExpression): New interface for expressions which
9334 (TypeExpression): Renamed to TypeLookupExpression.
9335 (Expression.DoResolve): If we're doing a types-only lookup, the
9336 expression must implement the ITypeExpression interface and we
9337 call DoResolveType() on it.
9338 (SimpleName): Implement the new ITypeExpression interface.
9339 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9340 hack, the situation that we're only looking up types can't happen
9341 anymore when this method is called. Moved the type lookup code to
9342 DoResolveType() and call it.
9343 (SimpleName.DoResolveType): This ITypeExpression interface method
9344 is now doing the types-only lookup.
9345 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9346 (ResolveFlags): Added MaskExprClass.
9348 * expression.cs (MemberAccess): Implement the ITypeExpression
9350 (MemberAccess.DoResolve): Added support for a types-only lookup
9351 when we're called via ITypeExpression.DoResolveType().
9352 (ComposedCast): Implement the ITypeExpression interface.
9354 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9355 Expression.Resolve() with ResolveFlags.Type instead.
9357 2002-08-12 Martin Baulig <martin@gnome.org>
9359 * interface.cs (Interface.Define): Apply attributes.
9361 * attribute.cs (Attribute.ApplyAttributes): Added support for
9362 interface attributes.
9364 2002-08-11 Martin Baulig <martin@gnome.org>
9366 * statement.cs (Block.Emit): Only check the "this" variable if we
9367 do not always throw an exception.
9369 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9370 whether the property has a set accessor.
9372 2002-08-11 Martin Baulig <martin@gnome.org>
9374 Added control flow analysis support for structs.
9376 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9377 with control flow analysis turned off.
9378 (IVariable): New interface.
9379 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9380 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9381 (FieldExpr.DoResolve): Resolve the instance expression with flow
9382 analysis turned off and do the definite assignment check after the
9383 resolving when we know what the expression will resolve to.
9385 * expression.cs (LocalVariableReference, ParameterReference):
9386 Implement the new IVariable interface, only call the flow analysis
9387 code if ec.DoFlowAnalysis is true.
9388 (This): Added constructor which takes a Block argument. Implement
9389 the new IVariable interface.
9390 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9391 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9392 This does the definite assignment checks for struct members.
9394 * class.cs (Constructor.Emit): If this is a non-static `struct'
9395 constructor which doesn't have any initializer, call
9396 Block.AddThisVariable() to tell the flow analysis code that all
9397 struct elements must be initialized before control returns from
9400 * statement.cs (MyStructInfo): New public class.
9401 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9402 argument to this indexer. If non-zero, check an individual struct
9403 member, not the whole struct.
9404 (FlowBranching.CheckOutParameters): Check struct members.
9405 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9406 overloaded versions of these methods which take an additional
9407 `int field_idx' argument to check struct members.
9408 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9409 overloaded versions of these methods which take an additional
9410 `string field_name' argument to check struct member.s
9411 (VariableInfo): Implement the IVariable interface.
9412 (VariableInfo.StructInfo): New public property. Returns the
9413 MyStructInfo instance of the variable if it's a struct or null.
9414 (Block.AddThisVariable): New public method. This is called from
9415 Constructor.Emit() for non-static `struct' constructor which do
9416 not have any initializer. It creates a special variable for the
9417 "this" instance variable which will be checked by the flow
9418 analysis code to ensure that all of the struct's fields are
9419 initialized before control returns from the constructor.
9420 (UsageVector): Added support for struct members. If a
9421 variable/parameter is a struct with N members, we reserve a slot
9422 in the usage vector for each member. A struct is considered fully
9423 initialized if either the struct itself (slot 0) or all its
9424 members are initialized.
9426 2002-08-08 Martin Baulig <martin@gnome.org>
9428 * driver.cs (Driver.MainDriver): Only report an error CS5001
9429 if there were no compilation errors.
9431 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9432 `UnsafeContext' property to determine whether the parent is in
9433 unsafe context rather than checking the parent's ModFlags:
9434 classes nested in an unsafe class are unsafe as well.
9436 2002-08-08 Martin Baulig <martin@gnome.org>
9438 * statement.cs (UsageVector.MergeChildren): Distinguish between
9439 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9440 we return. Added test17() and test18() to test-154.cs.
9442 2002-08-08 Martin Baulig <martin@gnome.org>
9444 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9445 Family access, make sure the invoking type isn't a subclass of the
9446 queried type (that'd be a CS1540).
9448 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9449 this method which takes an additional `Type invocation_type'.
9451 * expression.cs (BaseAccess.DoResolve): Use the base type as
9452 invocation and query type.
9453 (MemberAccess.DoResolve): If the lookup failed and we're about to
9454 report a CS0122, try a lookup with the ec.ContainerType - if this
9455 succeeds, we must report a CS1540.
9457 2002-08-08 Martin Baulig <martin@gnome.org>
9459 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9460 (MethodGroupExpr): Implement the IMemberExpr interface.
9462 * expression (MemberAccess.ResolveMemberAccess): No need to have
9463 any special code for MethodGroupExprs anymore, they're now
9466 2002-08-08 Martin Baulig <martin@gnome.org>
9468 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9469 Family, FamANDAssem and FamORAssem permissions.
9470 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9472 2002-08-08 Martin Baulig <martin@gnome.org>
9474 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9475 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9478 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9480 * driver.cs: implemented /resource option to embed managed resources.
9482 2002-08-07 Martin Baulig <martin@gnome.org>
9484 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9485 (FieldBase.HasFieldInitializer): New public property.
9486 (FieldBase.GetInitializerExpression): New public method. Resolves and
9487 returns the field initializer and makes sure it is only resolved once.
9488 (TypeContainer.EmitFieldInitializers): Call
9489 FieldBase.GetInitializerExpression to get the initializer, this ensures
9490 that it isn't resolved multiple times.
9492 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9493 the resolving process (SimpleName/MemberLookup) that we're currently
9494 emitting a field initializer (which must not access any instance members,
9495 this is an error CS0236).
9497 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9498 argument, if the `IsFieldInitializer' flag is set, we must report and
9499 error CS0236 and not an error CS0120.
9501 2002-08-07 Martin Baulig <martin@gnome.org>
9503 * ecore.cs (IMemberExpr): New public interface.
9504 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9505 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9506 if the expression is an IMemberExpr.
9508 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9509 to be null, implicitly default to `this' if we're non-static in
9510 this case. Simplified the code a lot by using the new IMemberExpr
9511 interface. Also fixed bug #28176 here.
9513 2002-08-06 Martin Baulig <martin@gnome.org>
9515 * cs-parser.jay (SimpleLookup): Removed. We need to create
9516 ParameterReferences during semantic analysis so that we can do a
9517 type-only search when resolving Cast, TypeOf and SizeOf.
9518 (block): Pass the `current_local_parameters' to the Block's
9521 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9522 argument to the constructor.
9523 (ConstructorInitializer.Resolve): Create a temporary implicit
9524 block with the parameters.
9526 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9527 references here if we aren't doing a type-only search.
9529 * statement.cs (Block): Added constructor which takes a
9530 `Parameters parameters' argument.
9531 (Block.Parameters): New public property.
9533 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9534 to `Parameters' and made it public readonly.
9536 2002-08-06 Martin Baulig <martin@gnome.org>
9538 * ecore.cs (Expression.Warning): Made this public as well.
9540 * report.cs (Report.Debug): Print the contents of collections.
9542 2002-08-06 Martin Baulig <martin@gnome.org>
9544 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9545 used to tell Resolve() which kinds of expressions it may return.
9546 (Expression.Resolve): Added overloaded version of this method which
9547 takes a `ResolveFlags flags' argument. This can be used to tell
9548 Resolve() which kinds of expressions it may return. Reports a
9550 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9551 ResolveFlags.SimpleName.
9552 (Expression.Error118): Added overloaded version of this method which
9553 takes a `ResolveFlags flags' argument. It uses the flags to determine
9554 which kinds of expressions are allowed.
9556 * expression.cs (Argument.ResolveMethodGroup): New public method.
9557 Resolves an argument, but allows a MethodGroup to be returned.
9558 This is used when invoking a delegate.
9560 * TODO: Updated a bit.
9562 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9564 Fixed compilation with csc.
9566 * ecore.cs: Expression.Error made public. Is this correct? Should
9567 Warning be made public too?
9569 * expression.cs: use ea.Location instead of ea.loc.
9570 [FIXME: Filed as bug #28607: MCS must report these errors.]
9572 2002-08-06 Martin Baulig <martin@gnome.org>
9574 * ecore.cs (Expression.loc): Moved the location here instead of
9575 duplicating it in all derived classes.
9576 (Expression.Location): New public property.
9577 (Expression.Error, Expression.Warning): Made them non-static and
9578 removed the location argument.
9579 (Expression.Warning): Added overloaded version which takes an
9580 `int level' argument.
9581 (Expression.Error118): Make this non-static and removed the
9582 expression and location arguments.
9583 (TypeExpr): Added location argument to the constructor.
9585 * expression.cs (StaticCallExpr): Added location argument to
9587 (Indirection, PointerArithmetic): Likewise.
9588 (CheckedExpr, UnCheckedExpr): Likewise.
9589 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9590 (StringPtr): Likewise.
9593 2002-08-05 Martin Baulig <martin@gnome.org>
9595 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9597 * assign.cs (Assign.DoResolve): Check whether the source
9598 expression is a value or variable.
9600 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9601 while resolving the corresponding blocks.
9603 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9604 an error, don't silently return null.
9606 * statement.cs (Block.AddVariable): Do the error reporting here
9607 and distinguish between CS0128 and CS0136.
9608 (Block.DoResolve): Report all unused labels (warning CS0164).
9609 (LabeledStatement): Pass the location to the constructor.
9610 (LabeledStatement.HasBeenReferenced): New property.
9611 (LabeledStatement.Resolve): Set it to true here.
9613 * statement.cs (Return.Emit): Return success even after reporting
9614 a type mismatch error (CS0126 or CS0127), this is what csc does and
9615 it avoids confusing the users with any consecutive errors.
9617 2002-08-05 Martin Baulig <martin@gnome.org>
9619 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9621 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9623 * expression.cs (MemberAccess.DoResolve): Silently return if an
9624 error has already been reported.
9626 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9627 error has already been reported.
9629 2002-08-05 Martin Baulig <martin@gnome.org>
9631 * statement.cs (UsageVector): Only initialize the `parameters'
9632 vector if we actually have any "out" parameters.
9634 2002-08-05 Martin Baulig <martin@gnome.org>
9636 * expression.cs (Binary.ResolveOperator): When combining delegates,
9637 they must have the same type.
9639 2002-08-05 Martin Baulig <martin@gnome.org>
9641 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9642 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9643 work with the ms runtime and we also don't need it: if we're a
9644 PropertyBuilder and not in the `indexer_arguments' hash, then we
9645 are a property and not an indexer.
9647 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9648 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9649 since the latter one doesn't work with the ms runtime.
9651 2002-08-03 Martin Baulig <martin@gnome.org>
9653 Fixed bugs #27998 and #22735.
9655 * class.cs (Method.IsOperator): New public field.
9656 (Method.CheckBase): Report CS0111 if there's already a method
9657 with the same parameters in the current class. Report CS0508 when
9658 attempting to change the return type of an inherited method.
9659 (MethodData.Emit): Report CS0179 if a method doesn't have a body
9660 and it's not marked abstract or extern.
9661 (PropertyBase): New abstract base class for Property and Indexer.
9662 (PropertyBase.CheckBase): Moved here from Property and made it work
9664 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
9665 the same so we can reuse it there.
9666 (Property, Indexer): Derive from PropertyBase.
9667 (MethodSignature.inheritable_property_signature_filter): New delegate
9668 to find properties and indexers.
9670 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9671 argument and improved error reporting.
9673 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9674 EmptyReadOnlyParameters and made it a property.
9676 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9677 version of this method which takes a `PropertyInfo indexer'.
9678 (TypeManager.RegisterIndexer): New method.
9680 * class.cs: Added myself as author of this file :-)
9682 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9684 * class.cs: fixed compilation on windoze.
9686 2002-08-03 Martin Baulig <martin@gnome.org>
9688 * interface.cs (Interface.GetInterfaceBases): Check whether all
9689 base interfaces are at least as accessible than the current one.
9691 * class.cs (TypeContainer.GetClassBases): Check whether base types
9692 are at least as accessible than the current type.
9693 (TypeContainer.AsAccessible): Implemented and made non-static.
9694 (MemberBase.CheckParameters): Report errors if the accessibility
9697 * delegate.cs (Delegate.Delegate): The default visibility is
9698 internal for top-level types and private for nested types.
9699 (Delegate.Define): Report errors if the accessibility checks fail.
9701 * enum.cs (Enum.Enum): The default visibility is internal for
9702 top-level types and private for nested types.
9703 (Enum.DefineType): Compute the correct visibility.
9705 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
9706 function which takes a `bool is_toplevel' instead of a TypeContainer.
9708 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
9711 2002-08-02 Martin Baulig <martin@gnome.org>
9713 * expression.cs (LocalVariableReferenc): Added constructor which
9714 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
9715 (LocalVariableReference.IsReadOnly): New property.
9716 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
9717 variable is readonly, use our own readonly flag to do this; you can
9718 use the new constructor to get a writable reference to a read-only
9721 * cs-parser.jay (foreach_statement, using_statement): Get a writable
9722 reference to the local variable.
9724 2002-08-01 Miguel de Icaza <miguel@ximian.com>
9726 * rootcontext.cs (ResolveCore): Also include System.Exception
9728 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
9729 we reach an EmptyStatement.
9731 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
9734 * expression.cs (Binary.ResolveOperator): Check error result in
9737 use brtrue/brfalse directly and avoid compares to null.
9739 2002-08-02 Martin Baulig <martin@gnome.org>
9741 * class.cs (TypeContainer.Define): Define all nested interfaces here.
9742 Fixes bug #28407, added test-155.cs.
9744 2002-08-01 Martin Baulig <martin@gnome.org>
9746 * class.cs (Event.EmitDefaultMethod): Make this work with static
9747 events. Fixes #28311, added verify-3.cs.
9749 2002-08-01 Martin Baulig <martin@gnome.org>
9751 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
9752 `is_disposable' fields.
9753 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
9754 `hm.is_disposable' if we're using the collection pattern.
9755 (Foreach.EmitCollectionForeach): Use the correct type for the
9756 enumerator's local variable, only emit the try/finally block if
9757 necessary (fixes #27713).
9759 2002-08-01 Martin Baulig <martin@gnome.org>
9761 * ecore.cs (Expression.report118): Renamed to Error118 and made
9764 * statement.cs (Throw.Resolve): Check whether the expression is of
9765 the correct type (CS0118) and whether the type derives from
9766 System.Exception (CS0155).
9767 (Catch.Resolve): New method. Do the type lookup here and check
9768 whether it derives from System.Exception (CS0155).
9769 (Catch.CatchType, Catch.IsGeneral): New public properties.
9771 * typemanager.cs (TypeManager.exception_type): Added.
9773 2002-07-31 Miguel de Icaza <miguel@ximian.com>
9775 * driver.cs: Updated About function.
9777 2002-07-31 Martin Baulig <martin@gnome.org>
9779 Implemented Control Flow Analysis.
9781 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
9782 (EmitContext.CurrentBranching): Added.
9783 (EmitContext.StartFlowBranching): Added.
9784 (EmitContext.EndFlowBranching): Added.
9785 (EmitContext.KillFlowBranching): Added.
9786 (EmitContext.IsVariableAssigned): Added.
9787 (EmitContext.SetVariableAssigned): Added.
9788 (EmitContext.IsParameterAssigned): Added.
9789 (EmitContext.SetParameterAssigned): Added.
9790 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
9791 Added control flow analysis stuff here.
9793 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
9794 resolve the expression as lvalue.
9795 (LocalVariableReference.DoResolve): Check whether the variable has
9796 already been assigned.
9797 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
9798 the parameter as assigned here.
9799 (ParameterReference.DoResolve): Check whether the parameter has already
9801 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
9802 expression as lvalue.
9804 * statement.cs (FlowBranching): New class for the flow analysis code.
9805 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
9806 (LabeledStatement.IsDefined): New public property.
9807 (LabeledStatement.AddUsageVector): New public method to tell flow
9808 analyis that the label may be reached via a forward jump.
9809 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
9811 (VariableInfo.Number): New public field. This is used by flow analysis
9812 to number all locals of a block.
9813 (Block.CountVariables): New public property. This is the number of
9814 local variables in this block (including the locals from all parent
9816 (Block.EmitMeta): Number all the variables.
9818 * statement.cs: Added flow analysis support to all classes.
9820 2002-07-31 Martin Baulig <martin@gnome.org>
9822 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
9823 To get debugging messages, compile mcs with /define:MCS_DEBUG and
9824 then use this argument.
9826 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
9828 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
9829 use this to specify /define options.
9831 2002-07-29 Martin Baulig <martin@gnome.org>
9833 * statement.cs (Fixed): Moved all code that does variable lookups
9834 and resolvings from Emit to Resolve.
9836 * statement.cs (For): Moved all code that does variable lookups
9837 and resolvings from Emit to Resolve.
9839 * statement.cs (Using): Moved all code that does variable lookups
9840 and resolvings from Emit to Resolve.
9842 2002-07-29 Martin Baulig <martin@gnome.org>
9844 * attribute.cs (Attribute.Resolve): Explicitly catch a
9845 System.NullReferenceException when creating the
9846 CustromAttributeBuilder and report a different warning message.
9848 2002-07-29 Martin Baulig <martin@gnome.org>
9850 * support.cs (ParameterData.ParameterName): Added method to
9851 get the name of a parameter.
9853 * typemanager.cs (TypeManager.IsValueType): New public method.
9855 2002-07-29 Martin Baulig <martin@gnome.org>
9857 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
9858 is a flag which specifies that it's either ref or out.
9859 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
9860 the out parameter to `out Parameter.Modifier mod', also set the
9861 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
9863 * support.cs (InternalParameters.ParameterModifier): Distinguish
9864 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9865 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9867 * expression.cs (Argument.GetParameterModifier): Distinguish
9868 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9869 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9871 2002-07-29 Martin Baulig <martin@gnome.org>
9873 * expression.cs (ParameterReference.ParameterReference): Added
9874 `Location loc' argument to the constructor.
9876 * cs-parser.jay: Pass location to ParameterReference.
9878 2002-07-28 Miguel de Icaza <miguel@ximian.com>
9880 * statement.cs (Try): Initialize the location.
9882 * cs-parser.jay: pass location to Try.
9884 * expression.cs (Unary.Reduce): Change the prototype to return
9885 whether a constant fold could be performed or not. The result is
9886 returned in an out parameters. In the case of Indirection and
9887 AddressOf, we want to perform the full tests.
9889 2002-07-26 Miguel de Icaza <miguel@ximian.com>
9891 * statement.cs (Statement.Emit): Flag dead code.
9893 2002-07-27 Andrew Birkett <andy@nobugs.org>
9895 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
9897 2002-07-27 Martin Baulig <martin@gnome.org>
9899 * class.cs (MethodData.Define): Put back call to
9900 TypeManager.AddMethod(), accidentally commented this out.
9902 * report.cs (Debug): New public method to print debugging information,
9903 this is `[Conditional ("DEBUG")]'.
9905 2002-07-26 Martin Baulig <martin@gnome.org>
9907 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
9908 (switch_statement): Push the current_block to the switch_stack and
9909 pop it again when we're done with the switch.
9910 (switch_section): The new block is a child of the current_block.
9911 Fixes bug #24007, added test-152.cs.
9913 2002-07-27 Martin Baulig <martin@gnome.org>
9915 * expression.cs (Invocation.EmitArguments): When calling a varargs
9916 function with only its fixed arguments, we need to pass an empty
9919 2002-07-27 Martin Baulig <martin@gnome.org>
9921 Mono 0.13 has been released.
9923 2002-07-25 Miguel de Icaza <miguel@ximian.com>
9925 * driver.cs: Rename --resource to --linkres, because that is what
9926 we do currently, we dont support --resource yet.
9928 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
9930 2002-07-25 Martin Baulig <martin@gnome.org>
9932 * class.cs (MethodData): New public class. This is a `method builder'
9933 class for a method or one accessor of a Property/Indexer/Event.
9934 (MethodData.GetMethodFlags): Moved here from MemberBase.
9935 (MethodData.ApplyAttributes): Likewise.
9936 (MethodData.ApplyObsoleteAttribute): Likewise.
9937 (MethodData.ApplyConditionalAttribute): Likewise.
9938 (MethodData.ApplyDllImportAttribute): Likewise.
9939 (MethodData.CheckAbstractAndExternal): Likewise.
9940 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
9941 (MethodData.Emit): Formerly known as Method.Emit().
9942 (MemberBase): Moved everything which was specific to a single
9943 accessor/method to MethodData.
9944 (Method): Create a new MethodData and call Define() and Emit() on it.
9945 (Property, Indexer, Event): Create a new MethodData objects for each
9946 accessor and call Define() and Emit() on them.
9948 2002-07-25 Martin Baulig <martin@gnome.org>
9950 Made MethodCore derive from MemberBase to reuse the code from there.
9951 MemberBase now also checks for attributes.
9953 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
9954 (MemberBase.GetMethodFlags): Moved here from class Method and marked
9956 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
9957 `CallingConventions cc' and `Attributes opt_attrs' arguments.
9958 (MemberBase.ApplyAttributes): New virtual method; applies the
9959 attributes to a method or accessor.
9960 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
9961 (MemberBase.ApplyConditionalAttribute): Likewise.
9962 (MemberBase.ApplyDllImportAttribute): Likewise.
9963 (MemberBase.CheckAbstractAndExternal): Likewise.
9964 (MethodCore.ParameterTypes): This is now a property instead of a
9965 method, it's initialized from DoDefineParameters().
9966 (MethodCore.ParameterInfo): Removed the set accessor.
9967 (MethodCore.DoDefineParameters): New protected virtual method to
9968 initialize ParameterTypes and ParameterInfo.
9969 (Method.GetReturnType): We can now simply return the MemberType.
9970 (Method.GetMethodFlags): Override the MemberBase version and add
9971 the conditional flags.
9972 (Method.CheckBase): Moved some code from Define() here, call
9973 DoDefineParameters() here.
9974 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
9975 here to avoid some larger code duplication.
9976 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
9977 ensure that abstract and external accessors don't declare a body.
9979 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
9980 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
9981 lookup in the attribute's parent classes, so we need to abort as soon
9982 as we found the first match.
9983 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
9984 the attribute has no arguments.
9986 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
9989 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9991 * cs-parser.jay: reverted previous patch.
9993 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9995 * cs-parser.jay: fixed bug #22119.
9997 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9999 * attribute.cs: fixed compilation. The error was:
10000 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10001 be assigned to before control leaves the current method."
10002 [FIXME: Filed as bug #28186: MCS must report this error.]
10004 2002-07-25 Martin Baulig <martin@gnome.org>
10006 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10007 method to pull the condition name ouf of a Conditional attribute.
10008 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10009 the obsolete message and error flag out of an Obsolete attribute.
10011 * class.cs (Method.GetMethodFlags): New public method to get the
10012 TypeManager.MethodFlags for this method.
10013 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10015 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10016 if we're overriding a virtual function, set the new private variable
10017 `parent_method'; call the new TypeManager.AddMethod().
10019 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10020 the MethodBuilder and the Method in a PtrHashtable.
10021 (TypeManager.builder_to_method): Added for this purpose.
10022 (TypeManager.MethodFlags): Added IsObsoleteError.
10023 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10024 Obsolete and Conditional arguments in MethodBuilders. If we discover
10025 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10026 the message from the attribute.
10028 2002-07-24 Martin Baulig <martin@gnome.org>
10030 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10031 preprocessor directives, ensure that the argument to #define/#undef is
10032 exactly one identifier and that it's actually an identifier.
10034 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10037 2002-07-24 Martin Baulig <martin@gnome.org>
10039 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10040 initialize it to TypeManager.object_type in the constructor.
10041 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10042 of the `hm.get_current' method if we're using the collection pattern.
10043 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10044 for the explicit conversion to make it work when we're using the collection
10045 pattern and the `Current' property has a different return type than `object'.
10048 2002-07-24 Martin Baulig <martin@gnome.org>
10050 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10051 does not match, but don't report any errors. This method is called in
10052 order for all methods in a MethodGroupExpr until a matching method is
10053 found, so we don't want to bail out if the first method doesn't match.
10054 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10055 matches, report the 123. Fixes #28070.
10057 2002-07-24 Martin Baulig <martin@gnome.org>
10059 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10060 TypeManager.TypeToCoreType() to the top of the method so the
10061 following equality checks will work. Fixes #28107.
10063 2002-07-24 Martin Baulig <martin@gnome.org>
10065 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10066 operand is of type uint, and the other operand is of type sbyte,
10067 short or int, the operands are converted to type long." -
10068 Actually do what this comment already told us. Fixes bug #28106,
10071 2002-07-24 Martin Baulig <martin@gnome.org>
10073 * class.cs (MethodBase): New abstract class. This is now a base
10074 class for Property, Indexer and Event to avoid some code duplication
10075 in their Define() and DefineMethods() methods.
10076 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10077 generic methods for Define() and DefineMethods().
10078 (FieldBase): Derive from MemberBase, not MemberCore.
10079 (Property): Derive from MemberBase, not MemberCore.
10080 (Property.DefineMethod): Moved all the code from this method to the
10081 new MethodBase.DefineAccessor(), just call it with appropriate
10083 (Property.Define): Call the new Property.DoDefine(), this does some
10084 sanity checks and we don't need to duplicate the code everywhere.
10085 (Event): Derive from MemberBase, not MemberCore.
10086 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10087 accessors, this will also make them work with interface events.
10088 (Indexer): Derive from MemberBase, not MemberCore.
10089 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10090 (Indexer.Define): Use the new MethodBase functions.
10092 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10093 argument to the constructor.
10094 (Interface.FindMembers): Added support for interface events.
10095 (Interface.PopluateEvent): Implemented.
10097 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10099 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10101 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10102 but this is required to check for a method name being the same as
10103 the containing class.
10107 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10109 * interface.cs: initialize variable.
10111 2002-07-23 Martin Baulig <martin@gnome.org>
10113 Implemented the IndexerName attribute in interfaces.
10115 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10116 name if this is an explicit interface implementation.
10117 (Indexer.InterfaceIndexerName): New public variable. If we're
10118 implementing an interface indexer, this is the IndexerName in that
10119 interface. Otherwise, it's the IndexerName.
10120 (Indexer.DefineMethod): If we're implementing interface indexer,
10121 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10122 and Pending.ImplementIndexer methods.
10123 (Indexer.Define): Also define the PropertyBuilder if we're
10124 implementing an interface indexer and this is neither an explicit
10125 interface implementation nor do the IndexerName match the one in
10128 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10129 If a method is defined here, then we always need to create a proxy
10130 for it. This is used when implementing interface indexers.
10131 (Pending.IsInterfaceIndexer): New public method.
10132 (Pending.ImplementIndexer): New public method.
10133 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10134 This is used when implementing interface indexers to define a proxy
10136 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10137 define a proxy if necessary.
10139 * interface.cs (Interface.IndexerName): New public variable.
10140 (Interface.PopulateIndexer): Set the IndexerName.
10141 (Interface.DefineIndexers): New private method. Populate all the
10142 indexers and make sure their IndexerNames match.
10144 * typemanager.cs (IndexerPropertyName): Added support for interface
10147 2002-07-22 Martin Baulig <martin@gnome.org>
10149 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10150 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10151 ret if HasReturnLabel.
10152 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10155 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10156 and set the ec.LoopBeginTryCatchLevel.
10157 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10158 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10159 the current ec.TryCatchLevel, the branch goes out of an exception
10160 block. In this case, we need to use Leave and not Br.
10162 2002-07-22 Martin Baulig <martin@gnome.org>
10164 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10165 block unless the block does not always return or it is contained in
10166 another try { ... } catch { ... } block. Fixes bug #26506.
10167 Added verify-1.cs to the test suite.
10169 2002-07-22 Martin Baulig <martin@gnome.org>
10171 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10172 then we do not always return. Fixes bug #24985.
10174 2002-07-22 Martin Baulig <martin@gnome.org>
10176 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10177 lookup on a per-class level; ie. walk up the class hierarchy until we
10178 found at least one applicable method, then choose the best among them.
10179 Fixes bug #24463 and test-29.cs.
10181 2002-07-22 Martin Baulig <martin@gnome.org>
10183 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10184 return types of the methods. The return type is not part of the
10185 signature and we must not check it to make the `new' modifier work.
10186 Fixes bug #27999, also added test-147.cs.
10187 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10189 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10190 on the method's return type.
10192 2002-07-21 Martin Baulig <martin@gnome.org>
10194 * assign.cs: Make this work if the rightmost source is a constant and
10195 we need to do an implicit type conversion. Also adding a few more tests
10196 to test-38.cs which should have caught this.
10198 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10199 target in the makefile for this. The makefile.gnu is primarily intended
10200 for end-users who don't want to debug the compiler.
10202 2002-07-21 Martin Baulig <martin@gnome.org>
10204 * assign.cs: Improved the Assign class so it can now handle embedded
10205 assignments (X = Y = Z = something). As a side-effect this'll now also
10206 consume less local variables. test-38.cs now passes with MCS, added
10207 a few new test cases to that test.
10209 2002-07-20 Martin Baulig <martin@gnome.org>
10211 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10212 instructions. Fixes bug #27977, also added test-146.cs.
10214 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10216 * cs-tokenizer.cs: fixed getHex ().
10218 2002-07-19 Martin Baulig <martin@gnome.org>
10220 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10221 not Type.GetType() to lookup the array type. This is needed when
10222 we're constructing an array of a user-defined type.
10223 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10224 single-dimensional arrays, but also for single-dimensial arrays of
10227 2002-07-19 Martin Baulig <martin@gnome.org>
10229 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10230 this function is called, it's not allowed to share LocalBuilders
10231 among ILGenerators.
10233 2002-07-19 Martin Baulig <martin@gnome.org>
10235 * expression.cs (Argument.Resolve): Report an error 118 when trying
10236 to pass a type as argument.
10238 2002-07-18 Martin Baulig <martin@gnome.org>
10240 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10241 Conv_R_Un for the signed `long' type.
10243 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10245 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10246 `expr' for the temporary result, as that will fail if we do
10247 multiple resolves on the same expression.
10249 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10251 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10252 ec.TypeContainer for looking up aliases.
10254 * class.cs (TypeContainer): Remove LookupAlias from here.
10256 * decl.cs (DeclSpace); Move here.
10258 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10260 * class.cs (FindMembers): Only call filter if the constructor
10261 bulider is not null.
10263 Also handle delegates in `NestedTypes' now. Now we will perform
10264 type lookups using the standard resolution process. This also
10267 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10268 This uses Expressions (the limited kind that can be parsed by the
10269 tree) instead of strings.
10271 * expression.cs (ComposedCast.ToString): Implement, used to flag
10272 errors since now we have to render expressions.
10274 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10277 * ecore.cs (SimpleName.ToString): ditto.
10279 * cs-parser.jay: Instead of using strings to assemble types, use
10280 Expressions to assemble the type (using SimpleName, ComposedCast,
10281 MemberAccess). This should fix the type lookups in declarations,
10282 because we were using a different code path for this.
10284 * statement.cs (Block.Resolve): Continue processing statements
10285 even when there is an error.
10287 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10289 * class.cs (Event.Define): Also remove the `remove' method from
10290 the list of pending items.
10292 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10293 generate more compact code.
10295 2002-07-17 Martin Baulig <martin@gnome.org>
10297 * const.cs (Const.LookupConstantValue): Add support for constant
10298 `unchecked' and `checked' expressions.
10299 Also adding test case test-140.cs for this.
10301 2002-07-17 Martin Baulig <martin@gnome.org>
10303 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10304 check whether mi.ReturnType implements the IEnumerator interface; the
10305 `==' and the IsAssignableFrom() will fail in this situation.
10307 2002-07-16 Ravi Pratap <ravi@ximian.com>
10309 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10312 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10314 * expression.cs: fixed bug #27811.
10316 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10318 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10319 Molaro: when we are a ref, the value already contains a pointer
10320 value, do not take the address of it.
10322 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10323 * removed mb-parser.jay and mb-tokenizer.cs
10325 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10327 * expression.cs: check against the building corlib void type.
10329 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10331 * ecore.cs: fix for valuetype static readonly fields: when
10332 initializing them, we need their address, not the address of a copy.
10334 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10336 * typemanager.cs: register also enum_type in corlib.
10338 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10340 * class.cs: allow calling this (but not base) initializers in structs.
10342 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10344 * ecore.cs: make sure we compare against the building base types
10347 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10349 * typemanager.cs: fix TypeToCoreType() to handle void and object
10350 (corlib gets no more typerefs after this change).
10352 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10354 * expression.cs (ArrayCreation.EmitArrayArguments): use
10355 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10357 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10358 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10359 array indexes, the runtime actually forbids them.
10361 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10362 for array arguments here.
10364 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10365 instead of the default for ValueTypes.
10367 (New.DoEmit): Use IsValueType instead of
10368 IsSubclassOf (value_type)
10369 (New.DoResolve): ditto.
10370 (Invocation.EmitCall): ditto.
10372 * assign.cs (Assign): ditto.
10374 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10375 Statements *are* currently doing part of their resolution during
10378 Expressions do always resolve during resolve, but statements are
10379 only required to propagate resolution to their children.
10381 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10383 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10385 (LoadAssembly): Do not add the dll if it is already specified
10387 (MainDriver): Add the System directory to the link path at the end,
10388 after all the other -L arguments.
10390 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10391 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10392 ldelem.u1) and using the opposite for sbytes.
10394 This fixes Digger, and we can finally run it.
10396 * driver.cs (UnixParseOption): Move the option parsing here.
10397 (CSCParseOption): Implement CSC-like parsing of options.
10399 We now support both modes of operation, the old Unix way, and the
10400 new CSC-like way. This should help those who wanted to make cross
10401 platform makefiles.
10403 The only thing broken is that /r:, /reference: and /lib: are not
10404 implemented, because I want to make those have the same semantics
10405 as the CSC compiler has, and kill once and for all the confussion
10406 around this. Will be doing this tomorrow.
10408 * statement.cs (Unsafe.Resolve): The state is checked during
10409 resolve, not emit, so we have to set the flags for IsUnsfe here.
10411 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10413 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10414 not catch the Error_ObjectRefRequired in SimpleName (as it is
10415 possible to have a class/instance variable name that later gets
10416 deambiguated), we have to check this here.
10418 2002-07-10 Ravi Pratap <ravi@ximian.com>
10420 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10421 make static and put into Expression.
10423 (Event.Define): Register the private field of the event with the
10424 TypeManager so that GetFieldFromEvent can get at it.
10426 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10427 keep track of the private field associated with an event which
10430 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10433 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10435 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10437 * expression.cs (Binary.EmitBranchable): this routine emits the
10438 Binary expression in a branchable context. This basically means:
10439 we need to branch somewhere, not just get the value on the stack.
10441 This works together with Statement.EmitBoolExpression.
10443 * statement.cs (Statement.EmitBoolExpression): Use
10446 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10448 * statement.cs (For): Reduce the number of jumps in loops.
10450 (For): Implement loop inversion for the For statement.
10452 (Break): We can be breaking out of a Try/Catch controlled section
10453 (foreach might have an implicit try/catch clause), so we need to
10454 use Leave instead of Br.
10456 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10457 now). If the instace expression supports IMemoryLocation, we use
10458 the AddressOf method from the IMemoryLocation to extract the
10459 address instead of emitting the instance.
10461 This showed up with `This', as we were emitting the instance
10462 always (Emit) instead of the Address of This. Particularly
10463 interesting when This is a value type, as we dont want the Emit
10464 effect (which was to load the object).
10466 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10468 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10470 * statement.cs (Checked): Set the CheckedState during the resolve
10471 process too, as the ConvCast operations track the checked state on
10472 the resolve process, and not emit.
10474 * cs-parser.jay (namespace_member_declaration): Flag that we have
10475 found a declaration when we do. This is used to flag error 1529
10477 * driver.cs: Report ok when we display the help only.
10479 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10481 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10483 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10485 * cs-tokenizer.cs (define): We also have to track locally the
10486 defines. AllDefines is just used for the Conditional Attribute,
10487 but we also need the local defines for the current source code.
10489 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10491 * statement.cs (While, For, Do): These loops can exit through a
10492 Break statement, use this information to tell whether the
10493 statement is the last piece of code.
10495 (Break): Flag that we break.
10497 * codegen.cs (EmitContexts): New `Breaks' state variable.
10499 2002-07-03 Martin Baulig <martin@gnome.org>
10501 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10502 modifiers in method declarations in structs. Otherwise, you won't
10503 be able to override things like Object.Equals().
10505 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10507 * class.cs (Method, Property, Indexer): Do not allow the public
10508 modifier to be used in explicit interface implementations.
10510 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10511 override modifiers in method declarations in structs
10513 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10515 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10516 integer or real overflow, report an error
10518 2002-07-02 Martin Baulig <martin@gnome.org>
10520 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10521 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10522 to tell the runtime about our newly created System.Object and
10523 System.ValueType types.
10525 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10527 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10528 struct instead of Ldarg/Starg.
10530 2002-07-02 Martin Baulig <martin@gnome.org>
10532 * expression.cs (Indirection.Indirection): Call
10533 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10535 2002-07-02 Martin Baulig <martin@gnome.org>
10537 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10538 ValueType, call TypeManager.TypeToCoreType() on it.
10539 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10540 the OpCodes.Newarr argument.
10542 2002-07-02 Martin Baulig <martin@gnome.org>
10544 * expression.cs (Invocation.EmitCall): When compiling corlib,
10545 replace all calls to the system's System.Array type to calls to
10546 the newly created one.
10548 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10549 System.Array methods.
10550 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10551 from the system's System.Array type which must be replaced.
10553 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10555 * typemanager.cs: load unverifiable_code_ctor so we can build
10556 corlib using the correct type. Avoid using GetTypeCode() with
10558 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10559 TypeManager.object_type to allow building corlib.
10561 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10563 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10565 2002-07-01 Martin Baulig <martin@gnome.org>
10567 * class.cs: Make the last change actually work, we need to check
10568 whether `ifaces != null' to avoid a crash.
10570 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10572 * class.cs: when we build structs without fields that implement
10573 interfaces, we need to add the interfaces separately, since there is
10574 no API to both set the size and add the interfaces at type creation
10577 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10579 * expression.cs: the dimension arguments to the array constructors
10580 need to be converted if they are a long.
10582 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10584 * class.cs: don't emit ldarg.0 if there is no parent constructor
10585 (fixes showstopper for corlib).
10587 2002-06-29 Martin Baulig <martin@gnome.org>
10589 MCS now compiles corlib on GNU/Linux :-)
10591 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10592 ie. check for MethodImplOptions.InternalCall.
10594 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10595 and TypeManager.attribute_type are null, so we must explicitly check
10596 whether parent is not null to find out whether it's an attribute type.
10597 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10598 and SetBuilder, not only if the property is neither abstract nor external.
10599 This is necessary to set the MethodImplOptions on the accessor methods.
10600 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10601 SetBuilder, see Property.Emit().
10603 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10604 populate "System.Object", "System.ValueType" and "System.Attribute" since
10605 they've already been populated from BootCorlib_PopulateCoreTypes().
10607 2002-06-29 Martin Baulig <martin@gnome.org>
10609 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10610 is the NullLiteral, we also need to make sure that target_type is not
10613 2002-06-29 Martin Baulig <martin@gnome.org>
10615 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10616 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10617 before calling BootstrapCorlib_ResolveDelegate ().
10619 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10621 * statement.cs: fixed build-breaker. All tests passed ok.
10623 2002-06-27 Martin Baulig <martin@gnome.org>
10625 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10626 for System.Decimal when compiling corlib.
10628 2002-06-27 Martin Baulig <martin@gnome.org>
10630 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10631 switch blocks which contain nothing but a default clause.
10633 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10635 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10637 2002-06-27 Martin Baulig <martin@gnome.org>
10639 * ecore.cs (PropertyExpr.PropertyExpr): Call
10640 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10642 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10643 is already a TypeBuilder.
10645 2002-06-27 Martin Baulig <martin@gnome.org>
10647 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10648 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10649 the "from an array-type to System.Array" case. This makes it work
10650 when compiling corlib.
10652 2002-06-27 Martin Baulig <martin@gnome.org>
10654 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
10655 non-static PropertyExpr, set its InstanceExpression. This makes
10656 the `ICollection.Count' property work in System/Array.cs.
10658 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
10660 * driver.cs: Made error handling more consistent. Errors now
10661 tracked by Report class, so many methods which used to return int
10662 now return void. Main() now prints success/failure and
10663 errors/warnings message.
10665 Renamed '--probe' compiler argument to '--expect-error'. Removed
10666 the magic number return values (123 and 124). Now, if the
10667 expected error occurs, the compiler exits with success (exit value
10668 0). If the compilation completes without seeing that particular
10669 error, the compiler exits with failure (exit value 1). The
10670 makefile in mcs/errors has been changed to handle the new behaviour.
10672 * report.cs: Made 'expected error' number a property and renamed
10673 it from 'Probe' to 'ExpectedError'.
10675 * genericparser.cs: Removed error handling support, since it is
10676 now all done by Report class.
10678 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10679 class, so parse() no longer returns an int.
10681 * namespace.cs: Use Report.Error instead of GenericParser.error
10683 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10685 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10686 TypeContainer.AddOperator): At the front of the list put the
10687 explicit implementations, so they get resolved/defined first.
10689 2002-06-21 Miguel de Icaza <miguel@ximian.com>
10691 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
10692 interface type is implemented by this TypeContainer. Used during
10693 explicit interface implementation.
10695 (Property.Define, Indexer.Define, Method.Define): Validate that
10696 the given interface in the explicit implementation is one of the
10697 base classes for the containing type.
10699 Also if we are explicitly implementing an interface, but there is
10700 no match in the pending implementation table, report an error.
10702 (Property.Define): Only define the property if we are
10703 not explicitly implementing a property from an interface. Use the
10704 correct name also for those properties (the same CSC uses,
10705 although that is really not needed).
10707 (Property.Emit): Do not emit attributes for explicitly implemented
10708 properties, as there is no TypeBuilder.
10710 (Indexer.Emit): ditto.
10712 Hiding then means that we do not really *implement* a pending
10713 implementation, which makes code fail.
10715 2002-06-22 Martin Baulig <martin@gnome.org>
10717 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
10718 the return value of Object.GetType(). [FIXME: we need to do this whenever
10719 we get a type back from the reflection library].
10721 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
10723 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
10725 2002-06-20 Miguel de Icaza <miguel@ximian.com>
10727 * attribute.cs: Return null if we can not look up the type.
10729 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
10730 the interface types found.
10732 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
10733 interface types found.
10735 * typemanager.cs (GetInterfaces): Make this routine returns alll
10736 the interfaces and work around the lame differences between
10737 System.Type and System.Reflection.Emit.TypeBuilder in the results
10738 result for GetInterfaces.
10740 (ExpandInterfaces): Given an array of interface types, expand and
10741 eliminate repeated ocurrences of an interface. This expands in
10742 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
10745 2002-06-21 Martin Baulig <martin@gnome.org>
10747 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
10750 2002-06-21 Martin Baulig <martin@gnome.org>
10752 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
10753 and called with one of the core types, return the corresponding typebuilder for
10756 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
10759 2002-06-21 Martin Baulig <martin@gnome.org>
10761 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
10762 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
10763 (Expression.ConvertReferenceExplicit): Likewise.
10765 * expression.cs (ElementAccess.DoResolve): Likewise.
10766 (ElementAccess.DoResolveLValue): Likewise.
10768 2002-06-10 Martin Baulig <martin@gnome.org>
10770 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
10771 add the "value" parameter to the parameter list.
10773 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
10776 2002-06-19 Miguel de Icaza <miguel@ximian.com>
10778 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
10779 the argument to an int, uint, long or ulong, per the spec. Also
10780 catch negative constants in array creation.
10782 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
10784 * class.cs: do not allow the same interface to appear twice in
10785 the definition list.
10787 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
10789 * ecore.cs: don't use ldlen with System.Array.
10791 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
10793 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
10795 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
10797 * modifiers.cs: produce correct field attributes for protected
10798 internal. Easy fix so miguel can work on ther harder stuff:-)
10800 2002-06-18 Miguel de Icaza <miguel@ximian.com>
10802 * pending.cs: New file. Move the code from class.cs here.
10803 Support clearning the pending flag for all methods (when not doing
10804 explicit interface implementation).
10806 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
10808 * rootcontext.cs: added a couple more types needed to bootstrap.
10810 2002-06-17 Miguel de Icaza <miguel@ximian.com>
10812 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
10813 constructor in the type, instead of any constructor in the type
10814 hierarchy. Thanks to Paolo for finding this bug (it showed up as
10815 a bug in the Mono runtime when applying the params attribute).
10817 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10818 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
10820 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
10822 * expression.cs (Unary.ResolveOperator): Use TypeManager
10823 to resolve the type.
10825 2002-06-13 Ravi Pratap <ravi@ximian.com>
10827 * cs-parser.jay (enum_member_declaration): Pass in the attributes
10830 * enum.cs (AddEnumMember): Add support to store the attributes associated
10831 with each member too.
10833 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
10834 field builders too - this takes care of the enum member case.
10836 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
10838 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
10839 address-of operator on both value types and pointers.
10841 2002-06-10 Martin Baulig <martin@gnome.org>
10843 * interface.cs (Interface.PopulateIndexer): Add the indexer's
10844 PropertyBuilder to the `property_builders' list.
10846 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
10847 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
10848 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
10849 find any indexers which are inherited from an interface.
10851 2002-06-09 Martin Baulig <martin@gnome.org>
10853 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
10854 the same type as the constant if necessary. There's also a test-130.cs
10857 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
10859 * typemanager.cs (TypeManager.ChangeType): Previously known as
10860 Enum.ChangeEnumType().
10862 2002-06-09 Martin Baulig <martin@gnome.org>
10864 * expression.cs (Cast.TryReduce): Added support for consts.
10866 2002-06-08 Ravi Pratap <ravi@ximian.com>
10868 * class.cs (Accessor): Hold attributes information so we can pass
10871 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
10872 Modify to pass in attributes attached to the methods.
10874 (add_accessor_declaration, remove_accessor_declaration): Ditto.
10876 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
10877 to handle the Accessor kind :-)
10879 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
10881 2002-06-08 Martin Baulig <martin@gnome.org>
10883 * expression.cs (Unary.TryReduceNegative): Added support for
10886 2002-06-08 Martin Baulig <martin@gnome.org>
10888 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
10889 name can't be found in the `defined_names' - the caller will do a
10890 MemberLookup in this case and thus find methods in System.Enum
10891 such as Enum.IsDefined().
10893 2002-06-08 Martin Baulig <martin@gnome.org>
10895 * enum.cs (Enum.ChangeEnumType): This is a custom version of
10896 Convert.ChangeType() which works with TypeBuilder created types.
10897 (Enum.LookupEnumValue, Enum.Define): Use it here.
10899 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
10900 `TypeBuilder.BaseType != null' check.
10901 (TypeContainer.FindMembers): Only lookup parent members if we
10902 actually have a parent.
10903 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
10904 (ConstructorInitializer.Resolve): Likewise.
10906 * interface.cs (Interface.FindMembers): Added
10907 `TypeBuilder.BaseType != null' check.
10909 * rootcontext.cs (RootContext.ResolveCore): Added
10910 "System.Runtime.CompilerServices.IndexerNameAttribute" to
10911 classes_second_stage.
10913 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
10914 debug_type and trace_type when compiling with --nostdlib.
10916 2002-06-07 Martin Baulig <martin@gnome.org>
10918 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
10919 (AddField): Set it to true when adding a non-static field.
10920 (DefineType): Use `have_nonstatic_fields' to find out whether we
10921 have non-static fields, not `Fields != null'.
10923 2002-06-02 Miguel de Icaza <miguel@ximian.com>
10925 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
10926 dereferencing a null on the static-field code path)
10928 2002-05-30 Martin Baulig <martin@gnome.org>
10930 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
10931 to take command line arguments. Use reflection to call the new
10932 custom `Initialize' function on the symbol writer and pass it the
10933 command line arguments.
10935 * driver.cs (--debug-args): New command line argument to pass command
10936 line arguments to the symbol writer.
10938 2002-05-28 Miguel de Icaza <miguel@ximian.com>
10940 * assign.cs (DoResolve): Forgot to do the implicit conversion to
10941 the target type for indexers and properties. Thanks to Joe for
10944 2002-05-27 Miguel de Icaza <miguel@ximian.com>
10946 * typemanager.cs (MethodFlags): returns the method flags
10947 (Obsolete/ShouldIgnore) that control warning emission and whether
10948 the invocation should be made, or ignored.
10950 * expression.cs (Invocation.Emit): Remove previous hack, we should
10951 not do this on matching a base type, we should do this based on an attribute
10953 Only emit calls to System.Diagnostics.Debug and
10954 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
10955 on the command line.
10957 * rootcontext.cs: Global settings for tracing and debugging.
10959 * cs-tokenizer.cs (define): New utility function to track
10960 defines. Set the global settings for TRACE and DEBUG if found.
10962 2002-05-25 Ravi Pratap <ravi@ximian.com>
10964 * interface.cs (Populate*): Pass in the TypeContainer as well as
10965 the DeclSpace as parameters so that we can create EmitContexts and
10966 then use that to apply attributes etc.
10968 (PopulateMethod, PopulateEvent, PopulateProperty)
10969 (PopulateIndexer): Apply attributes everywhere.
10971 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
10974 (ApplyAttributes): Update accordingly.
10976 We now apply interface attributes for all members too.
10978 2002-05-26 Miguel de Icaza <miguel@ximian.com>
10980 * class.cs (Indexer.Define); Correctly check if we are explicit
10981 implementation (instead of checking the Name for a ".", we
10982 directly look up if the InterfaceType was specified).
10984 Delay the creation of the PropertyBuilder.
10986 Only create the PropertyBuilder if we are not an explicit
10987 interface implementation. This means that explicit interface
10988 implementation members do not participate in regular function
10989 lookups, and hence fixes another major ambiguity problem in
10990 overload resolution (that was the visible effect).
10992 (DefineMethod): Return whether we are doing an interface
10995 * typemanager.cs: Temporary hack until we get attributes in
10996 interfaces (Ravi is working on that) and we get IndexerName
10997 support in interfaces.
10999 * interface.cs: Register the indexers as properties.
11001 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11002 warning, I have verified that this is a bug in the .NET runtime
11003 (JavaScript suffers of the same problem).
11005 * typemanager.cs (MemberLookup): When looking up members for
11006 interfaces, the parent of an interface is the implicit
11007 System.Object (so we succeed in searches of Object methods in an
11008 interface method invocation. Example: IEnumerable x; x.ToString
11011 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11013 * class.cs (Event): Events should also register if they do
11014 implement the methods that an interface requires.
11016 * typemanager.cs (MemberLookup); use the new GetInterfaces
11019 (GetInterfaces): The code used to lookup interfaces for a type is
11020 used in more than one place, factor it here.
11022 * driver.cs: Track the errors at the bottom of the file, we kept
11025 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11026 instance if the method we are calling is static!
11028 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11030 * attribute.cs (ApplyAttributes): Make this function filter out
11031 the IndexerName attribute (as that attribute in reality is never
11032 applied) and return the string constant for the IndexerName
11035 * class.cs (TypeContainer.Emit): Validate that all the indexers
11036 have the same IndexerName attribute, and if so, set the
11037 DefaultName attribute on the class.
11039 * typemanager.cs: The return value might contain other stuff (not
11040 only methods). For instance, consider a method with an "Item"
11041 property and an Item method.
11043 * class.cs: If there is a problem with the parameter types,
11046 2002-05-24 Ravi Pratap <ravi@ximian.com>
11048 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11049 looks at user defined conversion after making a call to
11050 StandardConversionExists - we need this for overload resolution.
11052 * expression.cs : Update accordingly the various method calls.
11054 This fixes 2 bugs filed against implicit user defined conversions
11056 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11058 * statement.cs: Track the result of the assignment.
11060 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11062 * expression.cs (MemberAccess): Improved error reporting for
11063 inaccessible members.
11065 2002-05-22 Martin Baulig <martin@gnome.org>
11067 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11068 itself with debugging support.
11070 2002-05-22 Martin Baulig <martin@gnome.org>
11072 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11073 Removed, this isn't needed anymore.
11075 2002-05-20 Martin Baulig <martin@gnome.org>
11077 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11078 be underlying type for an enum.
11080 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11082 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11083 that splits out the loading of just the core types.
11085 * rootcontext.cs (ResolveCore): Split the struct resolution in
11086 two, so we can load the enumeration underlying types before any
11089 * expression.cs (Is): Bandaid until we fix properly Switch (see
11090 bug #24985 for details).
11092 * typemanager.cs (ImplementsInterface): The hashtable will contain
11093 a null if there are no interfaces implemented.
11095 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11097 * cs-parser.jay (indexer_declarator): It is fine to have array
11100 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11102 * typemanager.cs: (RegisterBuilder): New function used to register
11103 TypeBuilders that implement interfaces. Since
11104 TypeBuilder.GetInterfaces (as usual) does not work with lame
11106 (AddUserType): register interfaces.
11108 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11109 dealing with TypeBuilder. Also, arrays are showing up as
11110 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11111 methods can not be invoked on them!
11113 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11114 (ImplicitReferenceConversionExists): Split out from
11115 StandardConversionExists.
11117 * expression.cs (As): We were only implementing one of the three
11118 cases for the as operator. We now implement them all.
11119 (Is): Implement the various other cases for Is as well.
11121 * typemanager.cs (CACHE): New define used to control if we want or
11122 not the FindMembers cache. Seems to have a negative impact on
11123 performance currently
11125 (MemberLookup): Nested types have full acess to
11126 enclosing type members
11128 Remove code that coped with instance/static returns for events, we
11129 now catch this in RealFindMembers.
11131 (RealFindMembers): only perform static lookup if the instance
11132 lookup did not return a type or an event.
11134 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11136 * assign.cs (CompoundAssign): We pass more semantic information
11137 now to Compound Assignments than we did before: now we have all
11138 the information at hand, and now we resolve the target *before* we
11139 do the expression expansion, which allows the "CacheValue" method
11140 to have the effect we intended (before, a [x] += 1 would generate
11141 two differen ArrayAccess expressions from the ElementAccess,
11142 during the resolution process).
11144 (CompoundAssign.DoResolve): Resolve target and original_source here.
11146 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11148 * expression.cs (ArrayAccess): dropped debugging information.
11150 * typemanager.cs: Small bug fix: I was always returning i_members,
11151 instead of one of i_members or s_members (depending on which had
11154 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11155 method is invoked before any code generation takes place, and it
11156 is a mechanism to inform that the expression will be invoked more
11157 than once, and that the method should use temporary values to
11158 avoid having side effects
11160 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11162 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11165 * expression.cs (Indirection, ArrayAccess): Add support for
11166 CacheTemporaries in these two bad boys.
11168 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11169 ldobj or ldind_ref.
11170 (StoreFromPtr): Handle stobj as well.
11172 * expression.cs (UnaryMutator): Share more code.
11174 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11175 down: I was not tracking the Filter function as well, which
11176 was affecting the results of the cache.
11178 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11180 * attribute.cs: Remove the hack to handle the CharSet property on
11183 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11185 * attribute.cs (DoResolve): More uglyness, we now only try to
11186 resolve the attribute partially, to extract the CharSet
11187 information (only if we are a StructLayout attribute). Otherwise
11189 (GetExtraTypeInfo): Add some code to conditionally kill in the
11190 future this. I am more and more convinced that the .NET
11191 framework has special code to handle the attribute setting on
11194 * expression.cs (IsParamsMethodApplicable): Revert my previous
11195 foreach change here, it was wrong.
11197 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11199 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11200 (pp_expr): do not abort on unknown input, just return.
11201 (eval): abort if there are pending chars.
11203 * attribute.cs (Attribute.Resolve): Positional parameters are
11204 optional. Deal with that case.
11206 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11207 the Ansi/Unicode/Auto information for the type.
11209 (TypeContainer.DefineType): instantiate the EmitContext here, as
11210 we will be using it during the type definition (to resolve
11211 attributes) and during the emit phase.
11213 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11214 to pull type information out of the attributes
11216 (Attribute.Resolve): track the constructor builder, and allow for
11217 multiple invocations (structs and classes will use this).
11219 * ecore.cs (MemberLookupFinal): new version with all the
11220 parameters customizable.
11222 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11223 constructors. Return if the result value is null (as the error
11224 would have been flagged already by MemberLookupFinal)
11226 Do not allow instances of abstract classes or interfaces to be
11229 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11230 We have to compare the assembly property here when dealing with
11231 FamANDAssem and Assembly access modifiers, because we might be
11232 creating an assembly from *modules* (that means that we are not
11233 getting TypeBuilders for types defined in other modules that are
11234 part of this assembly).
11236 (Method.Emit): If the method is marked abstract and has a body,
11239 (TypeContainer.DefineMembers): If both the defined member and the
11240 parent name match are methods, then do not emit any warnings: let
11241 the Method.Define routine take care of flagging warnings. But if
11242 there is a mismatch (method overrides something else, or method is
11243 overriwritten by something, then emit warning).
11245 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11246 set to null, this means `do not check for the return type on the
11249 (Method.Define): set the return type for the method signature to
11250 null, so that we get methods with the same name and parameters and
11251 different return types. This is used to flag warning 114 (you are
11252 hiding a method, and you probably want to use the new/override
11255 * typemanager.cs (MemberLookup): Implemented proper access
11256 control, closing a long standing set of bug reports. The problem
11257 was that the Framework only has two bits: Public and NonPublic,
11258 and NonPublic includes private and protected methods, but we need
11259 to enforce the FamANDAssem, FamOrAssem and Family.
11261 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11263 * statement.cs (GotoCase): Return true: Ammounts to giving up
11264 knowledge on whether we return or not, and letting the other case
11265 be responsible for it.
11267 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11269 * driver.cs: Do not load directories for each file processed, only
11270 do it if there is a pattern.
11272 * ecore.cs: Report readonly assigns here as well, as we might have
11273 been resolved only by MemberAccess.
11275 (SimpleName.SimpleNameResolve): Also be useful for LValue
11276 resolution. We need this to propagate assign to local readonly variables
11278 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11279 do not want to reuse potential criteria memory.
11281 * class.cs (MyEventBuilder): Set reflected_type;
11283 * ecore.cs (Constantify): Added support for constifying bools.
11285 (RootContext.LookupType): Added a cache for values looked up in
11286 the declaration space.
11288 * typemanager.cs (FindMembers): Now is a front-end to
11289 RealFindMembers, and provides a two-level hashtable-based cache to
11292 15% performance improvement: from 22.5 to 19.2 seconds.
11294 * expression.cs (IsParamsMethodApplicable): use foreach.
11295 (Invocation.DoResolve): ditto.
11296 (New.DoResolve): ditto.
11297 (ArrayCreation.DoResolve): ditto.
11299 * ecore.cs (FindMostEncompassingType): use foreach.
11301 * delegate.cs (NewDelegate.DoResolve): Use foreach
11303 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11304 (RemoveMethods): use foreach.
11306 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11307 nested foreach statements instead of for, and also break out of
11308 the inner loop once a match is found.
11310 (Invocation.OverloadResolve): Use foreach, simplify the code.
11312 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11314 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11315 we actually unwrap the expression to allow for extra information
11318 * expression.cs: Use Shr_Un on unsigned operations.
11320 2002-05-08 Ravi Pratap <ravi@ximian.com>
11322 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11323 applicable operators was not being considered correctly. This closes
11324 the bug Miguel reported.
11326 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11328 * attribute.cs: check that the type derives from System.Attribute
11329 and report the correct error in that case (moved the duplicate code to
11330 its own method, too).
11332 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11334 * attribute.cs: lookup attribute type name as the spec says: first the
11335 bare attribute name and then name + "Attribute" (nant compiles with
11336 mcs after this fix).
11338 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11340 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11341 Because of the way we parse things, we should try to see if a
11342 UIntConstant can fit in an integer.
11344 2002-05-07 Ravi Pratap <ravi@ximian.com>
11346 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11347 when we are in an explicit context.
11349 (ConvertReferenceExplicit): When converting from Iface type S to Class
11350 T make sure the rules are implemented as an OR.
11352 * parameter.cs (ParameterType): Make it a property for now although the
11353 purpose really isn't anything immediate.
11355 * expression.cs (Is*Applicable): Do better checking on the parameter type
11356 of a ref/out parameter. The ones from the system assemblies are already
11357 marked with the correct type so we don't need to do any correction.
11359 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11360 the object type is standard too so include that.
11362 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11364 * ecore.cs (StandardConversionExists): Augment with missing code:
11365 deal with IntConstant, LongConstants and Enumerations.
11367 * assign.cs: Report the error, instead of failing silently
11369 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11370 typecontainer that they are declared, because the
11371 typecontainer/namespace will have the list of using clauses that
11372 need to be applied.
11374 Assembly Attributes were escaping the normal registration
11377 (EmitCode): Apply attributes within an EmitContext that represents
11378 the container they were declared on.
11380 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11382 2002-05-06 Ravi Pratap <ravi@ximian.com>
11384 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11385 Revamp completely - make much cleaner as we now operate only
11388 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11389 to implement the logic detailed in the spec more correctly.
11391 (UserDefinedConversion): Update accordingly.
11393 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11395 * statement.cs: Return flow analysis information up.
11397 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11400 (token): Do not consume an extra character before calling
11403 2002-05-06 Piers Haken <piersh@friskit.com>
11405 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11407 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11409 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11410 EmitContext during the instance constructor initializer
11411 resolution, to stop access to instance variables.
11413 This is mandated by the spec, last paragraph of the `constructor
11414 initializers' section.
11416 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11418 * cs-parser.jay, class.cs (Accessor): new class used to represent
11419 an accessor (get or set). In the past we used `null' to represent
11420 a missing accessor. But this is ambiguous because there was no
11421 way to tell in abstract indexers/properties if one of them was
11424 Now there is a way of addressing that.
11426 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11427 instead of FindMembers.
11429 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11430 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11432 * attribute.cs: Treat indexers and properties as the same in terms
11433 of applying attributes
11435 * ecore.cs (FindMostEncompassedType): Use statically initialized
11436 EmptyExpressions()s like we do elsewhere to avoid creating useless
11437 objects (and we take this out of the tight loop).
11439 (GetConversionOperators): Move the code to extract the actual
11440 operators to a separate routine to clean things up.
11442 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11444 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11445 events are always registered FieldBuilders.
11447 * class.cs (FieldBase): New class shared by Fields
11449 * delegate.cs: If we are a toplevel delegate, use our full name.
11450 If we are a nested delegate, then only use our tail name.
11452 2002-05-02 Ravi Pratap <ravi@ximian.com>
11454 * expression.cs (IsApplicable): Ensure that we add the "&" to
11455 ref/out types before comparing it with the type of the argument.
11457 (IsParamsMethodApplicable): Ditto.
11459 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11462 * delegate.cs : Handle the case when we have more than one applicable
11463 method. Flag an error only when we finish checking all.
11465 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11467 * expression.cs: Add support for boolean static initializers.
11469 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11471 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11473 * parameter.cs (ComputeParameterTypes,
11474 ComputeAndDefineParameterTypes): Better error handling: now we
11475 clear the `types' cache if we fail during any of the type lookups.
11476 We also return the status code correctly to our caller
11478 * delegate.cs: If we fail to define a delegate, abort the extra
11481 * expression.cs (Binary.ResolveOperator): for
11482 operator==(object,object) and operator !=(object, object) we also
11483 have to verify that there is an implicit conversion from one to
11486 (ArrayAccess.DoResolve): Array Access can operate on
11489 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11491 * assign.cs (CompoundAssign): A new class used as a "flag" that
11492 the assignment actually is happening as part of a compound
11493 assignment operator.
11495 During compound assignment, a few new rules exist to enable things
11502 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11503 to the type of x) if y is implicitly convertible to the type of x,
11504 and the operator is a builtin operator and the return type of the
11505 operator is explicitly convertible to the type of x.
11507 * rootcontext.cs: Reset warning level to 2. 4 catches various
11508 "interesting" features in mcs, we must clean this up at some
11509 point, but currently am trying to kill other bugs ;-)
11511 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11512 in container classes as well.
11514 * expression.cs (Binary.ResolveOperator): Handle string case
11515 before anything else (as operator overloading does emit an error
11516 before doing anything else).
11518 This code could go away when we move to a table driven model, but
11519 i could not come up with a good plan last night.
11521 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11523 * typemanager.cs (CSharpName): reimplementation using regex.
11524 * class.cs: added null check for fields in Emit
11525 * rootcontext.cs: set warninglevel to 4
11527 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11529 * typemanager.cs (CSharpName): reimplemented with Lupus
11532 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11534 * statement.cs (If): correclty implement Resolve, because we were
11535 not catching sem errors in there. The same process is needed
11537 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11540 (Statement.Warning_DeadCodeFound): Factorize code.
11541 (While): Report dead code here too.
11543 (Statement): Added Resolve virtual method to allow
11544 for resolution split from the emit code.
11546 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11548 * statement.cs (EmitBoolExpression): No longer try to resolve the
11550 (MakeBoolean): New utility function that resolve, implicitly
11551 converts to boolean and tags the expression.
11554 (If, Do): Implement dead code elimination.
11555 (While): Implement loop inversion
11557 (Do, While, For, If): Resolve the expression prior to calling our
11560 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11563 - added method Report28 (warning: program has more than one entry point)
11564 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11565 - modified method Method.Define, the part at the end of the method
11567 * rootcontext.cs: added static public Location EntryPointLocation;
11569 * ../errors/cs0028.cs : Add test case for the above warning.
11572 - modified method CSharpName to allow arrays of primitive type to
11573 be printed nicely (e.g. instead of System.Int32[][] it now prints
11575 - added method CSharpSignature: returns the signature of a method
11576 in string format to be used in reporting errors, warnings, etc.
11578 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11581 2002-04-26 Ravi Pratap <ravi@ximian.com>
11583 * delegate.cs (Define): Fix extremely silly bug where I was
11584 setting the type of the 'object' parameter of the BeginInvoke
11585 method to System.IAsyncResult instead of System.Object ;-)
11587 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11589 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11592 (Constructor.Emit): return if we fail to initialize the
11593 constructor. Another door closed!
11595 * expression.cs (New.DoResolve): Improve error message (from -6 to
11596 1501). Use DeclaredOnly lookup to find the exact constructor.
11598 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11599 loop. This is useful.
11601 * cs-parser.jay: Adjust the default parameters so that destructors
11602 have the proper signature.
11604 2002-04-26 Martin Baulig <martin@gnome.org>
11606 * driver.cs (LoadAssembly): If `assembly' contains any characters
11607 which are only valid in path names and not in assembly names
11608 (currently slash, backslash and point), use Assembly.LoadFrom ()
11609 instead of Assembly.Load () on the `assembly' (before iteration
11610 over the link_paths).
11612 2002-04-26 Martin Baulig <martin@gnome.org>
11614 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11616 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11618 * class.cs (Property): use the new typemanager.MemberLookup
11620 (TypeContainer.MemberLookup): Implement using the
11621 TypeManager.MemberLookup now.
11623 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11624 and return MemberInfos, so that these can be used without an
11625 EmitContext (what we had before).
11627 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11629 * expression.cs: Fix the case where the argument to params if the
11630 type of the params. I omitted handling this before. Fixed
11632 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11634 * driver.cs: Call BootCorlib_PopulateCoreType
11636 * class.cs (Property.CheckBase): Check for properties only, not
11639 * interface.cs: Temporary hack: try/catch around the
11640 CustomAttributeBuilder, because I am getting an exception that I
11643 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11644 types whose definitions are required to be there (attributes are
11645 defined before standard types).
11647 Compute definitions as we boot the various types, as they are used
11648 immediately (value_type class will need object_type, but if we do
11649 not initialize object_type, we will pass a null, which will let
11650 the runtime pick the System.Object from the existing corlib, which
11651 is not what we want).
11653 2002-04-22 Patrik Torstensson <totte@labs2.com>
11655 * cs-tokenizer.cs: fixed a number of trim() issues.
11657 2002-04-22 Ravi Pratap <ravi@ximian.com>
11659 * expression.cs (Argument.Type): Ensure that we return the correct
11660 type when we have out or ref parameters [in which case we
11663 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11665 * class.cs (Property, Indexer): Allow extern modifier in there.
11667 * typemanager.cs (InitBaseTypes): Initializes object_type and
11668 value_type, since those will be used early on during the bootstrap
11669 process to compile corlib.
11671 (InitCoreTypes): Move code from here to InitBaseTypes.
11673 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11675 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11676 single-dimension arrays as using the ldlen opcode.
11678 Daniel Lewis discovered this optimization.
11680 * typemanager.cs: Add signature for System.Array::get_Length
11682 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11684 * statement.cs: report the error when the foreach does not apply to an
11685 array nor a collection.
11687 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11689 * expression.cs: Add implicit conversions to the operator ~.
11691 * constant.cs (DecimalConstant.Emit): Emit decimal value.
11693 * typemanager.cs: Locate the decimal constructor.
11695 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11697 * attribute.cs: use the new property of TypeOf.
11698 * expression.cs: added 'get' property around typearg.
11700 These changes fix a build breaker reported by NickD. Is this the
11701 correct way to fix? If not, please, revert my changes and make it
11704 2002-04-17 Miguel de Icaza <miguel@ximian.com>
11706 * attribute.cs: Add support for typeof in attribute invocations.
11707 I am not sure that this is right though.
11709 2002-04-14 Duncan Mak <duncan@ximian.com>
11711 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
11712 Binary.Operator.Division case.
11714 2002-04-13 Ravi Pratap <ravi@ximian.com>
11716 * class.cs (DefineType): Ensure that we do a proper check on
11717 attribute types and also register it with the TypeManager.
11719 (TypeContainer.Targets): The default for attribute types is
11720 AttributeTargets.All.
11722 * attribute.cs (ApplyAttributes): Registering the attribute type
11723 is done elsewhere, not when we discover we have a Usage attribute.
11725 2002-04-12 Ravi Pratap <ravi@ximian.com>
11727 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
11728 and get rid of is_delegate parameter.
11730 * everywhere : update.
11732 2002-04-12 Ravi Pratap <ravi@ximian.com>
11734 * cs-parser.jay (compilation_unit): Revamp completely to use
11735 some new ideas that I got from Rhys' grammar to solve the problems
11736 with assembly level attributes.
11738 (outer_declaration): New grammar production.
11740 (attribute_sections): Add.
11742 (opt_attributes): Base on attribute_sections
11744 (namespace_declaration): Allow opt_attributes to tackle the case
11745 when we have assembly level attributes - we are clever in this
11748 * attribute.cs (ApplyAttributes): Do not worry about assembly
11749 attributes in the non-global context.
11751 * rootcontext.cs (AddGlobalAttributes): Go back to using this
11752 instead of SetGlobalAttributes.
11754 * class.cs, rootcontext.cs : Ensure we define and generate
11755 attribute types before anything else.
11757 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
11758 and flag the new error -20 for the case when the attribute type
11759 does not have valid targets specified. csc does not catch this.
11761 * ../errors/errors.txt : update for error # -20
11763 2002-04-11 Ravi Pratap <ravi@ximian.com>
11765 * support.cs (InternalParameters.ParameterModifier): Do some null
11766 checking and return sane values.
11768 * class.cs (Method.Define): If we are a PInvoke method, ensure
11769 that we are static and extern. Report error # 601
11771 * ../errors/cs0601.cs : Add test case for the above error.
11773 2002-04-07 Ravi Pratap <ravi@ximian.com>
11775 * rootcontext.cs (attribute_types): We need to keep type of
11776 all attribute types separately and emit code for them first.
11778 (RegisterAttribute) : Implement.
11780 * class.cs (DefineType): Check if the current Type is a custom
11781 attribute type and register it accordingly.
11783 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
11784 adding the first attribute twice and rename to
11786 (SetGlobalAttributes): this.
11788 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
11791 * attribute.cs (ApplyAttributes): Take an additional argument telling us
11792 if we are processing global arguments. Hmm, I am unsure of this.
11794 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11796 * expression.cs: added static array of strings to avoid calling
11797 Enum.ToString () for Operator in Binary. Significant recover of
11800 2002-04-10 Miguel de Icaza <miguel@ximian.com>
11802 * class.cs (FindMembers): Allow the Builders of the various
11803 members to be null. If they are skip them. This only happens
11804 during the PInvoke declaration.
11806 2002-04-09 Miguel de Icaza <miguel@ximian.com>
11808 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
11809 failure, so we do not keep going afterwards.
11811 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
11812 wanted to pass `false' as the `is_delegate' argument. If this is
11813 the case, why not use delegate_type == null to mean `is_delegate =
11814 false' and anything else as is_delegate = true.
11816 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
11818 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
11819 code for the section, not the beginning of the tests.
11821 2002-04-08 Miguel de Icaza <miguel@ximian.com>
11823 * cfold.cs: Handle operator + (Enum x, Underlying x)
11825 * expression.cs (Binary): same. Warn about errors where we have
11826 Enum/Enum in operator + as well.
11828 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
11831 - added support for switch(bool)
11832 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
11833 - add TableSwitchEmit() to handle table-based switch statements
11835 2002-04-05 Ravi Pratap <ravi@ximian.com>
11837 * expression.cs (Invocation.OverloadResolve): Factor out code which
11838 does parameter compatibility checking with arguments so that we can
11839 re-use the code even from Delegate.VerifyApplicability
11841 (VerifyArgumentsCompat): Move above code here.
11843 * delegate.cs (VerifyApplicability): Get rid of duplicate code
11844 and instead make a call to the above method.
11846 2002-03-31 Ravi Pratap <ravi@ximian.com>
11848 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
11849 We use it to keep track of classes which are attribute types.
11851 2002-04-02 Miguel de Icaza <miguel@ximian.com>
11853 * delegate.cs (Delegate.Define): Correctly define the types in the
11854 presence of fixed and array parameters.
11856 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
11859 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
11860 include NonPublic after the first iteration.
11862 * class.cs (Indexer.CheckBase): Only check if both parents are
11865 * cs-parser.jay (accessor_body): If empty, set to null.
11867 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
11868 same code path here to resolve constants names that we did have in
11869 MemberAccess.DoResolve. There is too much code duplicated here.
11871 2002-04-01 Miguel de Icaza <miguel@ximian.com>
11873 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
11875 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
11878 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
11879 tokens, numbers and strings.
11881 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
11884 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
11885 asyncronous parameters and the regular parameters.
11887 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
11888 specify the target directory.
11890 * expression.cs: (This.DoResolve): Simplify
11891 (As.Emit): Optimize, do not generate IsInst if the expression is
11892 always of the given type.
11894 (Is.DoResolve): Bug fix, we were reporting both always/never for
11897 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
11898 creating too many unnecessary arrays.
11900 2002-03-31 Miguel de Icaza <miguel@ximian.com>
11902 * class.cs (EmitFieldInitializer): Use Assign expression to assign
11903 fields instead of rolling our own initializer. Takes care of all
11904 implicit conversions, and drops unnecessary static checks/argument.
11906 2002-03-31 Dick Porter <dick@ximian.com>
11908 * driver.cs: use the GetDirectories() return values properly, and
11909 use "/" as path separator.
11911 2002-03-30 Miguel de Icaza <miguel@ximian.com>
11913 * expression.cs (Unary): Optimize - - expr into expr.
11914 (Binary): Optimize a + (-b) into a -b.
11916 * codegen.cs (CodeGen): Made all methods static.
11918 2002-03-29 Miguel de Icaza <miguel@ximian.com>
11922 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
11923 TypeBuilder property.
11925 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
11928 * tree.cs: Removed the various RecordXXXX, and replaced with a
11929 single RecordDecl. Removed all the accessor methods, and just
11930 left a single access point Type
11932 * enum.cs: Rename DefineEnum to DefineType.
11934 * decl.cs: New abstract method `DefineType' used to unify the
11935 Defines for Enumerations, Interfaces, TypeContainers and
11938 (FindType): Moved LookupInterfaceOrClass here. Moved the
11939 LookupBaseClasses method that used to live in class.cs and
11940 interface.cs here, and renamed to FindType.
11942 * delegate.cs: Implement DefineType. Take advantage of the
11943 refactored pattern for locating the parent builder without taking
11944 the parent_builder argument (which we know does not work if we are
11945 nested, and triggering a toplevel definition).
11947 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11949 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
11950 accessibility of a member has changed during override and report
11953 * class.cs (Method.Define, Property.Define): Only complain on
11954 overrides if the method is private, any other accessibility is
11955 fine (and since we just checked the permission is the same, we are
11958 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
11959 and elif are processed always. The other pre-processing
11960 directives are only processed if we are "taking" the path
11962 2002-03-29 Martin Baulig <martin@gnome.org>
11964 * class.cs (Method.Emit): Only emit symbolic debugging info if the
11965 current location is not Null.
11967 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
11968 a separate method so we can profile it.
11970 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
11971 `span.Seconds' are just seconds, but no minutes or hours.
11972 (MainDriver): Profile the CodeGen.SaveSymbols calls.
11974 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11976 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
11977 Remove the gratuitous set of Final:
11979 // If an interface implementation, then we can set Final.
11980 if (((flags & MethodAttributes.Abstract) == 0) &&
11981 implementing.DeclaringType.IsInterface)
11982 flags |= MethodAttributes.Final;
11984 I do not know what I was smoking when I used that.
11987 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
11988 step into fixing the name resolution issues for delegates and
11989 unifying the toplevel name resolution.
11991 2002-03-28 Martin Baulig <martin@gnome.org>
11993 * class.cs (Method.Emit): If we have a symbol writer, call its
11994 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
11995 tell it about the current method.
11997 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
11998 writer that we're going to emit the first byte of IL code for a new
11999 statement (a new source line).
12000 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12001 EmitContext.Mark() before emitting any code.
12003 * location.cs (SymbolDocument): Return null when we're Null.
12005 * statement.cs (Statement): Moved the `Location loc' variable here.
12006 (Statement.EmitBoolExpression): If we have a symbol writer, call
12007 ec.Mark() before emitting any code to tell it that we're at the
12008 beginning of a new statement.
12009 (StatementExpression): Added `Location' argument to the constructor.
12010 (Block): Added public readonly variable `StartLocation' and public
12011 variable `EndLocation'. The latter is to be set using SetEndLocation().
12012 (Block): Added constructor which takes a start and end location.
12013 (Block.SetEndLocation): New method. This sets the end location.
12014 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12015 local variables we create.
12016 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12017 each statement and do also mark the begin and end of the block.
12019 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12020 tell it the current lexer.Location, use Location.Null for the end of the
12022 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12023 current block, set its end location using SetEndLocation().
12024 (statement_expression): StatementExpression constructor now takes the
12025 lexer.Location as additional argument.
12026 (for_statement, declare_local_variables): Likewise.
12027 (declare_local_variables): When creating a new implicit block, use the
12028 new Block constructor and pass it the lexer.Location.
12030 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12032 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12033 members also on the parent interfaces recursively.
12035 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12037 * report.cs: Use new formats, since Gonzalo finished the missing
12040 * expression.cs (Binary.ResolveOperator): added missing operator|
12041 operator& and operator^ for bool/bool.
12043 * cs-parser.jay: CheckDef now takes a Location argument that is
12044 used to report errors more precisly (instead of reporting the end
12045 of a definition, we try to track something which is a lot closer
12046 to the source of the problem).
12048 * cs-tokenizer.cs: Track global token use, so we can properly flag
12049 the use of #define/#undef after the first token has been seen.
12051 Also, rename the reportXXXX to Error_DescriptiveName
12053 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12054 TypeContainer, so that Enum and Interface can use this too.
12056 * class.cs (TypeContainer.LookupInterfaceOrClass,
12057 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12058 `builder' argument. Typically this was used to pass the parent
12059 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12062 The problem is that a nested class could trigger the definition of
12063 a toplevel class, and the builder would be obviously wrong in that
12066 So we drop this argument, and we compute dynamically the
12067 TypeBuilder/ModuleBuilder (the correct information was available
12068 to us anyways from DeclSpace.Parent)
12070 * interface.cs (Interface.DefineInterface): Drop builder
12071 parameter cleanup like class.cs
12073 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12076 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12079 (Try.Emit): Propagate the returns value from the statement.
12081 (Return.Emit): Even if we are leavning
12083 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12085 * modifiers.cs: Fix the computation of MethodAttributes flags.
12087 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12089 * driver.cs: allow compilation of files that start with '/'.
12090 Add a default case when checking the argument of --target.
12092 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12094 * interface.cs: Implement the same search algorithm for types in
12095 the interface code.
12097 * delegate.cs: Do not allow multiple definition.
12099 * Recovered ChangeLog that got accidentally amputated
12101 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12103 * rootcontext.cs: Load manually enum to allow core classes to
12104 contain enumerations.
12106 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12107 Update to new static methods in TypeManager.
12109 * typemanager.cs (GetMethod, GetConstructor): Use our
12110 implementation of FindMembers to find the members, since during
12111 corlib compilation, the types are TypeBuilders and GetMethod and
12112 GetConstructor do not work.
12114 Make all methods in TypeManager static.
12116 (InitCodeHelpers): Split the functionality from
12117 the InitCodeTypes function.
12119 * driver.cs: Call InitCodeHelpers after we have populated the
12122 * cs-parser.jay (delegate_declaration): we did not used to compute
12123 the delegate name correctly for void delegates.
12125 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12127 * rootcontext.cs (RootContext): Init the interface_resolve_order
12128 and type_container_resolve_order always.
12130 (ResolveCore, BootstrapCorlib_ResolveClass,
12131 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12132 compiler when compiling with --nostdlib
12134 * class.cs (TypeContainer.DefineType): Check that our parent is
12135 not null. This test is most important when we are bootstraping
12138 * codegen.cs: Split out the symbol writing code.
12140 2002-03-25 Martin Baulig <martin@gnome.org>
12142 * driver.cs (-g): Made -g an alias for --debug.
12144 2002-03-24 Martin Baulig <martin@gnome.org>
12146 * codegen.cs (SymbolWriter): New public variable. Returns the
12147 current symbol writer.
12148 (CodeGen): Added `bool want_debugging_support' argument to the
12149 constructor. If true, tell the ModuleBuild that we want debugging
12150 support and ask it for the ISymbolWriter.
12151 (Save): If we have a symbol writer, call it's Close() method after
12152 saving the assembly.
12154 * driver.c (--debug): New command line argument to create a
12155 debugger information file.
12157 * location.cs (SymbolDocument): New public property. Returns an
12158 ISymbolDocumentWriter object for the current source file or null
12159 if we don't have a symbol writer.
12161 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12163 * driver.cs (LoadAssembly): Correctly return when all the paths
12164 have been tried and not before.
12166 * statement.cs (Switch.Emit): return the actual coverage for this
12167 statement (returns/not-returns)
12169 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12170 switch of the statement if we are the last switch section. That
12171 kills two problems: try/catch problems (we used to emit an empty
12172 nop at the end) and switch statements where all branches would
12175 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12177 * driver.cs: Add default assemblies (the equivalent to the
12178 Microsoft CSC.RSP file)
12180 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12181 also update tokens_seen and set it to false.
12183 * driver.cs: Implement --recurse for Mike.
12185 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12186 correctly splitting out the paths.
12188 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12190 * interface.cs (Interface.PopulateProperty): Instead of using
12191 `parent' as the declaration space for the set parameters, use
12194 * support.cs (InternalParameters): InternalParameters constructor
12195 takes a DeclSpace instead of a TypeContainer.
12197 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12198 types are being initialized, load the address of it before calling
12201 (New): Provide a mechanism to disable the generation of local
12202 value type temporaries when the caller will be providing us with
12203 an address to store it.
12205 (ArrayCreation.EmitDynamicInitializers): Use it.
12207 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12209 * expression.cs (Invocation.EmitArguments): Only probe for array
12210 property if there is more than one argument. Sorry about that.
12212 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12213 empty param arrays.
12215 * class.cs (Method.LabelParameters): Fix incorrect code path that
12216 prevented the `ParamArrayAttribute' from being applied to the
12219 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12221 * support.cs (ReflectionParameters): Correctly compute whether the
12222 last argument is a params array. Fixes the problem with
12225 * typemanager.cs: Make the assemblies array always be non-null
12226 (empty, but non-null)
12228 * tree.cs (RecordDecl): New function that abstracts the recording
12229 of names. This reports error 101, and provides a pointer to the
12230 previous declaration. Fixes a crash in the compiler.
12232 * cs-parser.jay (constructor_declaration): Update to new grammar,
12233 and provide a constructor_body that can be empty.
12235 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12237 * driver.cs: Add support for --resources.
12239 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12240 Make all types for the various array helper methods be integer.
12242 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12243 CheckState to ConvCast.
12245 (ConvCast): Now it takes a `checked' state argument, to avoid
12246 depending on the emit context for the conversion, and just using
12247 the resolve time setting.
12249 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12250 instead of Invocation.EmitArguments. We do not emit the original
12251 arguments, instead we emit those which have been converted to
12252 unsigned int expressions.
12254 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12256 * codegen.cs: ditto.
12258 * expression.cs (LocalVariableReference): Drop the use of the
12259 Store function that depended on the variable index.
12261 * statement.cs (VariableInfo): Drop the `Idx' property from this
12262 class, as this is not taking into account the indexes for
12263 temporaries tat we generate during the execution, getting the
12266 * class.cs: First emit class initializers, then call the parent
12269 * expression.cs (Binary): Fix opcode emision.
12270 (UnaryMutator.EmitCode): Support checked code generation
12272 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12273 matches for events for both the Static and Instance scans,
12274 pointing to the same element. Fix that.
12276 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12278 * rootcontext.cs (ResolveTree): Always set the
12279 interface_resolve_order, because nested interfaces will be calling
12282 * class.cs (GetInterfaceOrClass): Track the same resolution
12283 process used by TypeManager.LookupType. This fixes the nested
12284 type lookups in class declarations (separate path from
12287 (TypeContainer.DefineType): Also define nested interfaces.
12288 (TypeContainer.RegisterOrder): New public function used to
12289 register the order in which child interfaces need to be closed.
12291 Nested interfaces need to be closed after their parents have been
12294 * interface.cs (InterfaceAttr): Put all the logic for computing
12295 the interface attribute here.
12297 (DefineInterface): Register our interface order with the
12298 RootContext or with the TypeContainer depending on the case.
12300 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12302 * cs-parser.jay: rework foreach statement to work with the new
12303 changes to the policy on SimpleNames.
12305 * report.cs: support Stacktrace on warnings as well.
12307 * makefile: drop --unsafe and /unsafe from the compile.
12309 2002-03-13 Ravi Pratap <ravi@ximian.com>
12311 * ecore.cs (StandardConversionExists): Modify to take an Expression
12312 as the first parameter. Ensure we do null -> reference type conversion
12315 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12316 temporary Expression objects.
12318 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12320 * interface.cs: workaround bug in method overloading resolution
12321 (there is already a bugzilla bug for it).
12323 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12325 We could also solve this problem by having a separate path for
12326 performing type lookups, instead of DoResolve, we could have a
12327 ResolveType entry point, and only participating pieces of the
12328 production (simplename, deref, array) would implement this.
12330 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12331 signal SimpleName to only resolve type names and not attempt to
12332 resolve anything else.
12334 * expression.cs (Cast): Set the flag.
12336 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12338 * class.cs: Only report 108 if there is no `new' modifier.
12340 * cs-parser.jay: rework foreach statement to work with the new
12341 changes to the policy on SimpleNames.
12343 * report.cs: support Stacktrace on warnings as well.
12345 * makefile: drop --unsafe and /unsafe from the compile.
12347 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12349 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12350 lookups here, instead of doing that at parse time. This means
12351 that our grammar will not introduce `LocalVariableReferences' as
12352 expressions at this point. That solves the problem of code like
12356 static void Main ()
12360 This is only half the fix. The full fix requires parameters to
12361 also be handled in this way.
12363 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12364 makes the use more obvious of the DeclSpace. The
12365 ec.TypeContainer.TypeBuilder is now only used to pull the
12366 TypeBuilder for it.
12368 My theory is that I can get rid of the TypeBuilder completely from
12369 the EmitContext, and have typecasts where it is used (from
12370 DeclSpace to where it matters).
12372 The only pending problem is that the code that implements Aliases
12373 is on TypeContainer, and probably should go in DeclSpace.
12375 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12376 lookups here, instead of doing that at parse time. This means
12377 that our grammar will not introduce `LocalVariableReferences' as
12378 expressions at this point. That solves the problem of code like
12382 static void Main ()
12386 This is only half the fix. The full fix requires parameters to
12387 also be handled in this way.
12389 * class.cs (Property.DefineMethod): When implementing an interface
12390 method, set newslot, when implementing an abstract method, do not
12391 set the flag (before we tried never setting it, or always setting
12392 it, which is the difference).
12393 (Indexer.DefineMethod): same.
12394 (Method.DefineMethod): same.
12396 * ecore.cs: Only set the status used flag if we get back a Field.
12398 * attribute.cs: Temporary hack, so Paolo can keep working.
12400 2002-03-08 Ravi Pratap <ravi@ximian.com>
12402 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12403 the unmanaged type in the case we have a MarshalAs attribute.
12405 (Resolve): Handle the case when we are parsing the special MarshalAs
12406 attribute [we need to store the unmanaged type to use later]
12408 * typemanager.cs (marshal_as_attr_type): Built in type for the
12409 MarshalAs Attribute.
12411 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12412 on parameters and accordingly set the marshalling info.
12414 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12416 * class.cs: Optimizing slightly by removing redundant code after
12417 we switched to the `NoTypes' return value.
12418 (Property.DefineMethod): use NoTypes here too.
12420 This fixes the bug I introduced in my last batch of changes.
12422 2002-03-05 Ravi Pratap <ravi@ximian.com>
12424 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12426 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12427 Enums since those are types too.
12429 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12431 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12432 thanks to a call during the lookup process.
12434 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12436 * statement.cs (Foreach): Lots of work to accomodate a particular
12437 kind of foreach statement that I had not kept in mind. It is
12438 possible to have foreachs on classes that provide a GetEnumerator
12439 method that return objects that implement the "pattern" for using
12440 a foreach, there is no need to support GetEnumerator
12443 This is needed to compile nant.
12445 * decl.cs: Only report 114 if the member is not `Finalize' and if
12446 the warning level is at least 2.
12448 * class.cs: Moved the compare function from Method to
12451 (MethodSignature.InheritableMemberSignatureCompare): Add new
12452 filter function that is used to extract inheritable methods from a
12455 (Method.Define): Use the new `inheritable_method_signature_filter'
12458 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12461 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12463 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12465 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12467 * expression.cs: Pass location information to
12468 ConvertImplicitStandard.
12470 * class.cs: Added debugging code to track return values from
12473 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12475 * expression.cs (Is.DoResolve): If either side of the `is' is an
12476 interface, do not flag the warning.
12478 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12481 * report.cs: Allow for --fatal to be used with --probe.
12483 * typemanager.cs (NoTypes): Move the definition for the empty Type
12486 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12488 (TypeContainer.DefineProxy): New function used to proxy to parent
12489 implementations when implementing interfaces.
12490 (TypeContainer.ParentImplements): used to lookup if our parent
12491 implements a public function that is required by an interface.
12492 (TypeContainer.VerifyPendingMethods): Hook this up.
12494 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12495 `modules' and `assemblies' arraylists into arrays. We only grow
12496 these are the very early start up of the program, so this improves
12497 the speedof LookupType (nicely measured).
12499 * expression.cs (MakeByteBlob): Replaced unsafe code with
12500 BitConverter, as suggested by Paolo.
12502 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12503 folding of string concatenation, but if either side is a string,
12504 and the other is not, then return null, and let the runtime use
12505 the concatenation on the string plus the object (using
12506 `Object.ToString').
12508 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12510 Constant Folding has been implemented now.
12512 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12513 the error instead on types that are not supported in one's
12516 * constant.cs (Constant and all children): New set of functions to
12517 perform implict and explicit conversions.
12519 * ecore.cs (EnumConstant): Implement the new functions to perform
12520 conversion by proxying to the child expression.
12522 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12523 own separate setting that can not be turned off from the command
12524 line using --unchecked or --checked and is only controlled using
12525 the checked/unchecked statements and expressions. This setting is
12526 used by the constant folder to flag errors.
12528 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12529 ConstantCheckState as well.
12531 During Resolve, they also have to flag the state, because the
12532 constant folder runs completely in the Resolve phase.
12534 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12537 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12539 * cfold.cs: New file, this file contains the constant folder.
12541 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12542 argument to track whether we are using the resulting address to
12543 load or store a value and provide better error messages.
12545 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12546 new AddressOf arguments.
12548 * statement.cs (Foreach.EmitCollectionForeach): Update
12550 * expression.cs (Argument.Emit): Call AddressOf with proper
12551 arguments to track usage.
12553 (New.DoEmit): Call AddressOf with new arguments.
12555 (Unary.Emit): Adjust AddressOf call.
12557 2002-03-01 Ravi Pratap <ravi@ximian.com>
12559 * cs-parser.jay (member_access): Change the case for pre-defined types
12560 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12563 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12566 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12567 essentially like methods and apply attributes like MethodImplOptions to them too.
12569 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12572 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12573 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12576 * Update code everywhere accordingly.
12578 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12580 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12582 2002-02-28 Ravi Pratap <ravi@ximian.com>
12584 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12585 try performing lookups against those instead of jumping straight into using
12586 the 'using' clauses.
12588 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12590 (LookupType): Perform lookups in implicit parents too.
12592 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12593 sequence as RootContext.LookupType.
12595 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12596 the various cases of namespace lookups into this method.
12598 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12600 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12601 in positional arguments)
12603 * class.cs (Operator): Update the AllowedModifiers to contain
12606 * cs-parser.jay: Update operator declaration to allow for the
12607 operator body to be empty.
12609 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12612 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12614 * class.cs (Method.Emit): Label parameters.
12616 * driver.cs: Return 1 or 0 as the program exit code.
12618 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12620 * expression.cs: Special case the `null' object when trying to
12621 auto-compute the type, as anything can be explicitly converted to
12624 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12625 spotting this Paolo.
12627 (Expression.ImplicitNumericConversion): Perform comparissions of
12628 the type using the underlying type in the case of an enumeration
12629 rather than using the enumeration type for the compare.
12631 Cope with the underlying == type case, which is not possible to
12634 (Expression.ConvertNumericExplicit): Perform comparissions of
12635 the type using the underlying type in the case of an enumeration
12636 rather than using the enumeration type for the compare.
12638 * driver.cs: If the user does not supply an extension, assume .exe
12640 * cs-parser.jay (if_statement): Rewrote so that we can track the
12641 location for the if statement.
12643 * expression.cs (Binary.ConstantFold): Only concat strings when
12644 the operation is "+", not everything ;-)
12646 * statement.cs (Statement.EmitBoolExpression): Take a location
12648 (If, While, Do): Track location.
12650 * expression.cs (Binary.ResolveOperator): In the object + string
12651 case, I was missing a call to ConvertImplicit
12653 2002-02-25 Ravi Pratap <ravi@ximian.com>
12655 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
12656 Location arguments. Ensure we use RootContext.LookupType to do our work
12657 and not try to do a direct Type.GetType and ModuleBuilder.GetType
12659 * interface.cs (PopulateMethod): Handle the type of the parameter being
12662 * expression.cs (Invocation.BetterFunction): Handle the case when we
12663 have a params method with no fixed arguments and a call is made with no
12666 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12668 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12669 the verbatim-string-literal
12671 * support.cs (InternalParameters.ParameterModifier): handle null
12673 (InternalParameters.ParameterType): ditto.
12675 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12676 duplicating the name of the variable parameter.
12677 (GetParameterByName): Fix bug where we were not looking up array
12678 paramters if they were the only present (thanks Paolo!).
12679 (GetParameterInfo): We only have an empty set of types if both
12680 fixed and array are set to null.
12681 (GetParameterInfo-idx): Handle FixedParameter == null
12683 * cs-parser.jay: Handle the case where there is no catch
12684 statements (missing null test).
12686 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12688 * driver.cs (MainDriver): Be conservative on our command line
12691 Catch DirectoryNotFoundException when calling GetFiles.
12693 (SplitPathAndPattern): Used to split the input specification into
12694 a path and a pattern that we can feed to Directory.GetFiles.
12696 2002-02-21 Miguel de Icaza <miguel@ximian.com>
12698 * statement.cs (Fixed): Implement the last case of the Fixed
12699 statement (string handling).
12701 * expression.cs (StringPtr): New class used to return a char * to
12702 a string; Used by the Fixed statement.
12704 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
12706 * expression.cs (Binary.ResolveOperator): Remove redundant
12707 MemberLookup pn parent type.
12708 Optimize union call, we do not need a union if the types are the same.
12709 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
12712 Specialize the use of MemberLookup everywhere, instead of using
12713 the default settings.
12715 (StackAlloc): Implement stackalloc keyword.
12717 * cs-parser.jay: Add rule to parse stackalloc.
12719 * driver.cs: Handle /h, /help, /?
12721 * expression.cs (MakeByteBlob): Removed the hacks we had in place
12722 before we supported unsafe code.
12724 * makefile: add --unsafe to the self compilation of mcs.
12726 2002-02-20 Miguel de Icaza <miguel@ximian.com>
12728 * expression.cs (PointerArithmetic): New class that is used to
12729 perform pointer arithmetic.
12730 (Binary.Resolve): Handle pointer arithmetic
12731 Handle pointer comparission.
12732 (ArrayPtr): Utility expression class that is used to take the
12733 address of an array.
12735 (ElementAccess): Implement array access for pointers
12737 * statement.cs (Fixed): Implement fixed statement for arrays, we
12738 are missing one more case before we are done.
12740 * expression.cs (Indirection): Implement EmitAssign and set the
12741 ExprClass to Variable. This allows pointer dereferences to be
12742 treated as variables, and to have values assigned to them.
12744 * ecore.cs (Expression.StoreFromPtr): New utility function to
12745 store values dereferencing.
12747 2002-02-20 Ravi Pratap <ravi@ximian.com>
12749 * expression.cs (Binary.ResolveOperator): Ensure that we are
12750 not trying to operate on a void type - this fixes the reported
12753 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
12754 the parent implementation is sealed.
12756 * ../errors/cs0239.cs : Add.
12758 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
12760 * typemanager.cs (unverifiable_code_type): Corresponds to
12761 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
12762 which have unsafe code in them.
12764 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
12767 2002-02-19 Miguel de Icaza <miguel@ximian.com>
12769 * cs-tokenizer.cs: Add support for @"litreal strings"
12771 Make tokenizer accept pre-processor directives
12772 on any column (remove the old C-like limitation).
12774 * rootcontext.cs (EmitCode): Emit any global attributes.
12775 (AddGlobalAttributes): Used to keep track of assembly attributes.
12777 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
12779 * cs-parser.jay: Add support for global attributes.
12781 2002-02-17 Miguel de Icaza <miguel@ximian.com>
12783 * expression.cs (Indirection): New helper class. Unary will
12784 create Indirection classes to be able to implement the
12785 IMemoryLocation interface on it.
12787 2002-02-16 Miguel de Icaza <miguel@ximian.com>
12789 * cs-parser.jay (fixed_statement): reference the right statement.
12791 * statement.cs (Fixed.Emit): Finish implementing the fixed
12792 statement for the &x case.
12794 2002-02-14 Miguel de Icaza <miguel@ximian.com>
12796 * class.cs (Property.Define, Method.Define): Remove newslot when
12799 * modifiers.cs: My use of NewSlot when `Abstract' was set was
12800 wrong. NewSlot should only be used if the `new' keyword is present.
12802 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
12803 locating our system dir. Sorry about this.
12805 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12807 * driver.cs (GetSystemDir): Compute correctly the location of our
12808 system assemblies. I was using the compiler directory instead of
12809 the library directory.
12811 2002-02-13 Ravi Pratap <ravi@ximian.com>
12813 * expression.cs (BetterFunction): Put back in what Miguel commented out
12814 since it is the correct fix. The problem is elsewhere ;-)
12816 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
12817 parameters of the parms method are themselves compatible or not !
12819 (StandardConversionExists): Fix very dangerous bug where we were forgetting
12820 to check that a class implements an interface before saying that an implicit
12821 conversion was allowed. Use ImplementsInterface to do the checking.
12823 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12825 * class.cs (Method.Define): Track whether we are an explicit
12826 implementation or not. And only call DefineMethodOverride if we
12827 are an explicit implementation.
12829 (Property.DefineMethod): Ditto.
12831 2002-02-11 Ravi Pratap <ravi@ximian.com>
12833 * expression.cs (BetterFunction): Catch hideous bug which was
12834 preventing us from detecting ambiguous calls due to implicit casts i.e
12837 2002-01-29 Miguel de Icaza <miguel@ximian.com>
12839 * support.cs (Pair): Remove un-needed method. I figured why I was
12840 getting the error in cs-parser.jay, the variable in a foreach loop
12841 is readonly, and the compiler does not really treat this as a variable.
12843 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
12844 instead of EQUALS in grammar.
12846 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
12848 * expression.cs (Unary.DoResolve): Check whether the argument is
12851 2002-01-28 Miguel de Icaza <miguel@ximian.com>
12853 * support.cs: Api for Pair to set a value. Despite the fact that
12854 the variables are public the MS C# compiler refuses to compile
12855 code that accesses the field if the variable is part of a foreach
12858 * statement.cs (Fixed): Begin implementation of the fixed
12861 (Block.AddVariable): Return the VariableInfo on success and null
12862 on failure instead of true/false.
12864 * cs-parser.jay (foreach): Catch errors on variables already
12865 defined (we were ignoring this value before) and properly unwind
12866 the block hierarchy
12868 (fixed_statement): grammar for the fixed statement.
12870 2002-01-25 Miguel de Icaza <miguel@ximian.com>
12872 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
12873 pointer types to be incretemented.
12875 (SizeOf): Implement.
12877 * cs-parser.jay (pointer_member_access): Implement
12878 expr->IDENTIFIER production.
12880 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
12881 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
12884 (Unary): Implement indirection.
12886 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
12887 use in non-unsafe context).
12889 (SimpleName.DoResolve): Check for pointers in field access on safe
12892 (Expression.LoadFromPtr): Factor the load-indirect code in this
12893 function. This was duplicated in UnboxCast and ParameterReference
12895 2002-01-24 Miguel de Icaza <miguel@ximian.com>
12897 * expression.cs (ComposedCast): report an error if a pointer cast
12898 is used in a safe region.
12900 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
12901 pointer type casts in unsafe context.
12903 * codegen.cs (EmitContext): Set up IsUnsafe.
12905 * cs-parser.jay (non_expression_type): Add productions for pointer
12908 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
12909 code. We should not use force into static mode if the method is
12910 not virtual. Fixes bug in MIS
12912 * statement.cs (Do.Emit, While.Emit, For.Emit,
12913 Statement.EmitBoolExpression): Add support to Do and While to
12914 propagate infinite loop as `I do return' semantics.
12916 Improve the For case to also test for boolean constants.
12918 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
12919 to the list of attributes we can add.
12921 Remove `EmitContext' argument.
12923 * class.cs (Method.Define): Apply parameter attributes.
12924 (Constructor.Define): Apply parameter attributes.
12925 (MethodCore.LabelParameters): Move here the core of labeling
12928 * support.cs (ReflectionParameters.ParameterModifier,
12929 InternalParameters.ParameterModifier): Use IsByRef on the type and
12930 only return the OUT bit for these parameters instead of in/out/ref
12933 This is because I miss-understood things. The ParameterInfo.IsIn
12934 and IsOut represent whether the parameter has the [In] and [Out]
12937 2002-01-22 Miguel de Icaza <miguel@ximian.com>
12939 * ecore.cs (FieldExpr.Emit): Release temporaries.
12941 * assign.cs (LocalTemporary.Release): new function.
12943 * codegen.cs (EmitContext.GetTemporaryStorage,
12944 EmitContext.FreeTemporaryStorage): Rework the way we deal with
12945 temporary storage. Now we can "put back" localbuilders when we
12948 2002-01-21 Miguel de Icaza <miguel@ximian.com>
12950 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
12951 need to make a copy of the variable to generate verifiable code.
12953 2002-01-19 Miguel de Icaza <miguel@ximian.com>
12955 * driver.cs: Compute dynamically the system directory.
12957 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
12958 Slower, but more generally useful. Used by the abstract
12959 registering implementation.
12961 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
12962 the rules for the special rule on Type/instances. First check if
12963 we have the same name, and if so, try that special static path
12964 rather than the instance path.
12966 2002-01-18 Miguel de Icaza <miguel@ximian.com>
12968 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
12971 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
12972 Enum, ValueType, Delegate or Array for non-corlib compiles.
12974 * cs-tokenizer.cs: Catch long identifiers (645)
12976 * typemanager.cs (IndexerPropetyName): Ravi never tested this
12979 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
12980 fix, we were returning too early, so we were not registering
12981 pending methods from abstract classes.
12983 Do not register pending methods if the class is abstract.
12985 * expression.cs (Conditional.DoResolve): Report circular implicit
12986 conversions when we neecd to compute it for conditional
12989 (Is.DoResolve): If the expression is always of the provided type,
12990 flag warning 183. If the expression can not ever be of the
12991 provided type flag warning 184.
12993 * class.cs: Catch 169 as well.
12995 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
12998 2002-01-18 Nick Drochak <ndrochak@gol.com>
13000 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13002 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13004 * interface.cs: (PopulateMethod): Check for pointers being defined
13005 only if the unsafe context is active.
13006 (PopulateProperty): ditto.
13007 (PopulateIndexer): ditto.
13009 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13010 specified. If pointers are present, make sure that they are
13011 present in an unsafe context.
13012 (Constructor, Constructor.Define): ditto.
13013 (Field, Field.Define): ditto.
13014 (Property, Property.Define): ditto.
13015 (Event, Event.Define): ditto.
13017 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13018 hashtable if there are classes or structs defined.
13020 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13021 code, as the constant resolution moved.
13023 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13024 the metadata, so we can flag error 133.
13026 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13027 pointer is being declared in an unsafe context.
13029 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13031 * modifiers.cs (Modifiers.Check): Require a Location argument.
13032 Report error 227 for Unsafe use.
13034 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13036 * statement.cs (For.Emit): If the test is null, then report that
13037 we do `return', as we wont reach anything afterwards.
13039 (Switch.SwitchGoverningType): Track the expression that matched
13042 * driver.cs: Allow negative numbers as an error code to flag.
13044 * cs-parser.jay: Handle 1551.
13046 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13048 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13050 * cs-parser.jay: Report 1518 (type declaration can only contain
13051 class, struct, interface, enum or delegate)
13053 (switch_label): Report 1523 (keywords `case' or `default' must
13056 (opt_switch_sections): Report 1522 (empty switch)
13058 * driver.cs: Report 1515 (response file specified multiple times)
13059 Report 1516 (Source file specified multiple times).
13061 * expression.cs (Argument.Resolve): Signal 1510
13063 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13064 access not allowed in static code)
13066 2002-01-11 Ravi Pratap <ravi@ximian.com>
13068 * typemanager.cs (IsPointerType): Utility method which we are going
13071 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13072 the object type, so we take care of that.
13074 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13076 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13077 added to non-params parameters :-)
13079 * typemanager.cs (CSharpName): Include 'void' type too.
13081 (void_ptr_type): Include in the set of core types.
13083 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13086 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13089 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13090 completely forgotten about it.
13092 2002-01-10 Ravi Pratap <ravi@ximian.com>
13094 * cs-parser.jay (pointer_type): Add. This begins our implementation
13095 of parsing rules for unsafe code.
13097 (unsafe_statement): Implement.
13099 (embedded_statement): Modify to include the above.
13101 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13103 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13104 if the current context is an unsafe one.
13106 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13107 are handled differently, we need separate rules for them.
13109 (local_variable_declaration): Update to use local_variable_pointer_type
13110 to allow variable declarations of unmanaged pointer types.
13112 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13113 in unsafe contexts.
13115 * ../errors/cs0214.cs : Add.
13117 2002-01-16 Nick Drochak <ndrochak@gol.com>
13119 * makefile: remove 'response' file when cleaning.
13121 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13123 * cs-parser.jay: Report 1524.
13125 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13127 * typemanager.cs (RegisterMethod): drop checking if we have
13128 registered this from here
13130 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13132 * class.cs (Method.EmitDestructor): Implement calling our base
13135 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13136 value of InFinally.
13138 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13139 this routine and will wrap the call in a try/catch block. Deal
13142 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13144 * ecore.cs (Expression.MemberLookup): instead of taking a
13145 parameter `same_type' that was used to tell whether we could
13146 access private members we compute our containing type from the
13149 (FieldExpr): Added partial support for volatile fields. This does
13150 not work for volatile fields exposed from assemblies, as I can not
13151 figure out how to extract the modreq from it.
13153 Updated all the source files to use this.
13155 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13156 because it is referenced by MemberLookup very often.
13158 2002-01-09 Ravi Pratap <ravi@ximian.com>
13160 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13161 TypeBuilder.GetCustomAttributes to retrieve what we need.
13163 Get rid of redundant default_member_attr_type as this is the same as
13164 default_member_type which already exists.
13166 * interface.cs, attribute.cs : Update accordingly.
13168 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13170 * typemanager.cs: Enable IndexerPropertyName again. It does not
13171 work for TYpeBuilders though. Ravi, can you please fix this?
13173 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13175 * expression.cs (Argument.Emit): Handle the case of ref objects
13176 being passed to ref functions;
13178 (ParameterReference.EmitLoad): Loads the content of the pointer
13179 without dereferencing.
13181 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13183 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13185 2002-01-08 Ravi Pratap <ravi@ximian.com>
13187 * class.cs (Indexer.DefineMethod): Incorporate the interface
13188 type in the name of the method if we are doing explicit interface
13191 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13193 (BetterConversion): Fix extremely trivial bug where we were referring to
13194 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13197 * ../errors/bug16.cs : Add although we have fixed it.
13199 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13201 * expression.cs (BaseIndexer): Begin implementation.
13203 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13205 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13206 production directly to remove a shift/reduce, and implement
13207 explicit interface implementation.
13209 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13210 after a floating point suffix.
13212 * expression.cs (DoNumericPromotions): Improved the conversion for
13213 uint/uint. If we have a constant, we avoid doing a typecast to a
13216 * class.cs (Indexer): Implement explicit interface implementation
13219 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13221 * class.cs: make the default instance constructor public and hidebysig.
13223 2001-01-03 Ravi Pratap <ravi@ximian.com>
13225 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13226 so we can call it from elsewhere.
13228 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13229 we emit it internally if the class has a defined indexer; otherwise the user
13230 emits it by decorating the class definition with the DefaultMemberAttribute.
13232 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13233 attribute is not used on a type which defines an indexer.
13235 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13236 character when we skip whitespace.
13238 * ../errors/cs0646.cs : Add.
13240 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13242 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13245 * makefile: Add practical target `mcs3.exe' which builds the third
13246 generation compiler.
13248 * expression.cs (New): Fix structures constructor calling.
13250 * class.cs (Property, Method, Indexer): Emit Final flag on the
13251 method if we are an interface implementation and we are not
13254 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13255 whether this property is referencing a `base' method.
13257 * expression.cs (Invocation.EmitCall): take an extra argument:
13258 is_base, this is used to determine whether the `call' or
13259 `callvirt' opcode should be used.
13262 * delegate.cs: update EmitCall.
13264 * class.cs (Method.Define): Set NewSlot for the cases where we are
13265 not implementing an interface method.
13267 (Property.Define): ditto.
13269 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13271 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13272 'r'. Allows mcs to parse itself fully.
13274 2002-01-02 Ravi Pratap <ravi@ximian.com>
13276 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13277 of the number of initializers that require the InitializeArray method.
13279 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13280 update the above field where necessary.
13282 (MakeByteBlob): Update accordingly.
13284 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13287 (EmitDynamicInitializers): Update in accordance with the new optimization.
13289 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13290 same OpCode applies.
13292 * cs-parser.jay : Fix some glaring errors I introduced.
13294 2002-01-01 Ravi Pratap <ravi@ximian.com>
13296 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13297 so that we can check for name clashes there too.
13299 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13300 for interface indexers.
13302 * interfaces.cs (Define): Emit the default member attribute.
13304 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13305 variable was being referred to while setting the value ;-)
13307 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13309 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13310 byte-by-byte information when we know the data is zero.
13312 Make the block always a multiple of 4, because
13313 DefineInitializedData has a bug.
13315 * assign.cs: Fix, we should assign from the temporary, not from
13318 * expression.cs (MakeByteBlob): Fix my incorrect code.
13320 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13322 * typemanager.cs (EnumToUnderlying): This function is used to get
13323 the underlying type from an enumeration, because it does not
13326 * constant.cs: Use the I4_S form for values between -128 and 127.
13328 * statement.cs (Block.LookupLabel): Looks up a label.
13329 (Block): Drop support for labeled blocks.
13331 (LabeledStatement): New kind of statement that represents a label
13334 (Goto): Finally implement this bad boy.
13336 * cs-parser.jay: Update to reflect new mechanism to implement
13339 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13341 * codegen.cs (EmitContext.This): a codegen property that keeps the
13342 a single instance of this instead of creating many different this
13345 * delegate.cs (Delegate.DoResolve): Update to use the property;
13347 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13349 * expression.cs (BaseAccess.DoResolve): Ditto.
13351 2001-12-29 Ravi Pratap <ravi@ximian.com>
13353 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13354 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13356 (InitCoreTypes): Update accordingly.
13358 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13359 so we can quickly store the state.
13361 (ApplyAttributes): Set the correct implementation flags
13362 for InternalCall methods.
13364 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13366 * expression.cs (EmitCall): if a method is not virtual, then do
13367 not use callvirt on it.
13369 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13370 user defined stuff) requires the use of stobj, which takes an
13371 address on the stack instead of an array and an index. So emit
13372 the Ldelema operation for it.
13374 (EmitStoreOpcode): Use stobj for valuetypes.
13376 (UnaryMutator.EmitCode): Use the right 1 value depending on
13377 whether we are dealing with int64/uint64, float or doubles.
13379 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13380 constructors that I implemented last night.
13382 (Constructor.IsDefault): Fix to work properly for static
13385 * cs-parser.jay (CheckDef): report method signature errors.
13386 Update error number 103 to be 132.
13388 * decl.cs: New AdditionResult enumeration value: MethodExists.
13389 Although we do this check for methods later on in the semantic
13390 analysis, catching repeated default constructors is so easy that
13391 we catch these here.
13393 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13396 (ParameterReference.EmitAssign, Emit): handle
13399 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13400 (ArrayAccess.EmitStoreOpcode): ditto.
13402 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13404 * expression.cs (MakeByteBlob): Complete all the missing types
13405 (uint, short, ushort, byte, sbyte)
13407 * class.cs: Only init instance field initializers on instance
13410 Rename `constructors' to instance_constructors.
13412 (TypeContainer.AddConstructor): Only add constructors to the list
13413 if it is not static.
13415 Make sure that we handle default_static_constructor independently
13416 everywhere where we handle instance_constructors
13418 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13420 * class.cs: Do not lookup or create a base initializer for a
13421 static constructor.
13423 (ConstructorInitializer.Resolve): use the proper type to lookup
13426 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13428 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13431 * decl.cs: CloseType is now an virtual method, the default
13432 implementation just closes this type.
13434 2001-12-28 Ravi Pratap <ravi@ximian.com>
13436 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13437 to PreserveSig by default. Also emit HideBySig on such methods.
13439 Basically, set the defaults to standard values.
13441 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13442 argument, if candidate is better, it can't be worse than the best !
13444 (Invocation): Re-write bits to differentiate between methods being
13445 applicable in their expanded form and their normal form - for params
13448 Get rid of use_standard everywhere as only standard conversions are allowed
13449 in overload resolution.
13451 More spec conformance.
13453 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13455 * driver.cs: Add --timestamp, to see where the compiler spends
13458 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13459 `this' in static code.
13461 (SimpleName.DoResolve): Implement in terms of a helper function
13462 that allows static-references to be passed upstream to
13465 (Expression.ResolveWithSimpleName): Resolve specially simple
13466 names when called by MemberAccess to implement the special
13469 (Expression.ImplicitReferenceConversion): Handle conversions from
13470 Null to reference types before others, as Null's type is
13473 * expression.cs (Invocation.EmitCall): Handle the special case of
13474 calling methods declared on a reference type from a ValueType
13475 (Base classes System.Object and System.Enum)
13477 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13478 the left hand side is a TypeExpr, not on every enumeration.
13480 (Binary.Resolve): If types are reference types, then do a cast to
13481 object on operators != and == of both arguments.
13483 * typemanager.cs (FindMembers): Extract instance and static
13484 members if requested.
13486 * interface.cs (PopulateProperty): Use void_type instead of null
13487 as the return type for the setter method.
13489 (PopulateIndexer): ditto.
13491 2001-12-27 Ravi Pratap <ravi@ximian.com>
13493 * support.cs (ReflectionParameters): Fix minor bug where we
13494 were examining the wrong parameter for the ParamArray attribute.
13496 Cope with requests for the type of the parameter at position
13497 greater than the params parameter's. We now return the element
13498 type of the params array as that makes more sense.
13500 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13501 accordingly as we no longer have to extract the element type
13504 (Invocation.OverloadResolve): Update.
13506 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13508 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13509 against IEnumerator, test whether the return value is a descendant
13510 of the IEnumerator interface.
13512 * class.cs (Indexer.Define): Use an auxiliary method to implement
13513 the other bits of the method definition. Begin support for
13514 explicit interface implementation.
13516 (Property.DefineMethod): Use TypeManager.void_type instead of null
13517 for an empty return value.
13519 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13521 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13522 dealing with a FieldExpr which is composed of a FieldBuilder, in
13523 the code path we did extract the constant, but we should have
13524 obtained the underlying value to be able to cast it (otherwise we
13525 end up in an infinite loop, this is what Ravi was running into).
13527 (ArrayCreation.UpdateIndices): Arrays might be empty.
13529 (MemberAccess.ResolveMemberAccess): Add support for section
13530 14.5.4.1 that deals with the special case of E.I when E is a type
13531 and something else, that I can be a reference to a static member.
13533 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13534 handle a particular array type to create byte blobs, it is just
13535 something we dont generate byteblobs for.
13537 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13540 * location.cs (Push): remove the key from the hashtable that we
13541 are about to add. This happens for empty files.
13543 * driver.cs: Dispose files after we have parsed them.
13545 (tokenize): new function that only runs the tokenizer on its
13546 input, for speed testing.
13548 2001-12-26 Ravi Pratap <ravi@ximian.com>
13550 * class.cs (Event.Define): Define the private field only if there
13551 are no accessors defined.
13553 * expression.cs (ResolveMemberAccess): If there is no associated
13554 field with the event, that means we have an event defined with its
13555 own accessors and we should flag error cs0070 since transforming
13556 ourselves into a field is not valid in that case.
13558 * ecore.cs (SimpleName.DoResolve): Same as above.
13560 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13561 and charset to sane values.
13563 2001-12-25 Ravi Pratap <ravi@ximian.com>
13565 * assign.cs (DoResolve): Perform check on events only if they
13566 are being accessed outside the declaring type.
13568 * cs-parser.jay (event_declarations): Update rules to correctly
13569 set the type of the implicit parameter etc.
13571 (add_accessor, remove_accessor): Set current local parameters.
13573 * expression.cs (Binary): For delegate addition and subtraction,
13574 cast the return value from the method into the appropriate delegate
13577 2001-12-24 Ravi Pratap <ravi@ximian.com>
13579 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13580 of these as the workaround is unnecessary.
13582 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13583 delegate data - none of that is needed at all.
13585 Re-write bits to extract the instance expression and the delegate method
13588 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13591 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13592 of attaching attributes instead of duplicating code everywhere.
13594 * everywhere : Update code to do attribute emission using the above method.
13596 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13598 * expression.cs (IsParamsMethodApplicable): if there are not
13599 parameters, return immediately.
13601 * ecore.cs: The 0 literal can be implicity converted to an enum
13604 (SimpleName.DoResolve): First lookup the type, then lookup the
13607 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13608 want to get its address. If the InstanceExpression is not
13609 addressable, store the result in a temporary variable, then get
13612 * codegen.cs: Only display 219 errors on warning level or above.
13614 * expression.cs (ArrayAccess): Make it implement the
13615 IMemoryLocation interface.
13617 (Binary.DoResolve): handle the operator == (object a, object b)
13618 and operator != (object a, object b) without incurring into a
13619 BoxedCast (because 5 != o should never be performed).
13621 Handle binary enumerator operators.
13623 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13624 value type, otherwise use Ldelem_ref.
13626 Use precomputed names;
13628 (AddressOf): Implement address of
13630 * cs-parser.jay (labeled_statement): Fix recursive block
13631 addition by reworking the production.
13633 * expression.cs (New.DoEmit): New has a special case:
13635 If we are dealing with a ValueType, we have a few
13636 situations to deal with:
13638 * The target of New is a ValueType variable, that is
13639 easy, we just pass this as the variable reference
13641 * The target of New is being passed as an argument,
13642 to a boxing operation or a function that takes a
13645 In this case, we need to create a temporary variable
13646 that is the argument of New.
13649 2001-12-23 Ravi Pratap <ravi@ximian.com>
13651 * rootcontext.cs (LookupType): Check that current_type is not null before
13652 going about looking at nested types.
13654 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
13655 not implement the IAssignMethod interface any more.
13657 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
13658 where we tranform them into FieldExprs if they are being resolved from within
13659 the declaring type.
13661 * ecore.cs (SimpleName.DoResolve): Do the same here.
13663 * assign.cs (DoResolve, Emit): Clean up code considerably.
13665 * ../errors/bug10.cs : Add.
13667 * ../errors/cs0070.cs : Add.
13669 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13671 * assign.cs : Get rid of EventIsLocal everywhere.
13673 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13675 * ecore.cs (ConvertIntLiteral): finished the implementation.
13677 * statement.cs (SwitchLabel): Convert the value we are using as a
13678 key before looking up the table.
13680 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13682 * codegen.cs (EmitTopBlock): Require a Location argument now.
13684 * cs-parser.jay (constructor_declarator): We need to setup
13685 current_local_parameters before we parse the
13686 opt_constructor_initializer, to allow the variables to be bound
13687 to the constructor arguments.
13689 * rootcontext.cs (LookupType): First lookup nested classes in our
13690 class and our parents before we go looking outside our class.
13692 * expression.cs (ConstantFold): Extract/debox the values at the
13695 * rootcontext.cs (EmitCode): Resolve the constants first before we
13696 resolve the types. This is not really needed, but it helps debugging.
13698 * statement.cs: report location.
13700 * cs-parser.jay: pass location to throw statement.
13702 * driver.cs: Small bug fix.
13704 * report.cs: Updated format to be 4-zero filled digits.
13706 2001-12-22 Ravi Pratap <ravi@ximian.com>
13708 * expression.cs (CheckIndices): Fix minor bug where the wrong
13709 variable was being referred to ;-)
13711 (DoEmit): Do not call EmitStaticInitializers when the
13712 underlying type is System.Object.
13714 2001-12-21 Ravi Pratap <ravi@ximian.com>
13716 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
13717 and do the usual workaround for SRE.
13719 * class.cs (MyEventBuilder.EventType): New member to get at the type
13720 of the event, quickly.
13722 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
13724 * assign.cs (Assign.DoResolve): Handle the case when the target
13725 is an EventExpr and perform the necessary checks.
13727 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
13730 (SimpleName.MemberStaticCheck): Include check for EventExpr.
13732 (EventExpr): Set the type in the constructor itself since we
13733 are meant to be born fully resolved.
13735 (EventExpr.Define): Revert code I wrote earlier.
13737 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
13738 instance expression is null. The instance expression is a This in that case
13739 or a null, depending on whether it is a static method or not.
13741 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
13742 refers to more than one method.
13744 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
13745 and accordingly flag errors.
13747 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13749 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
13751 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13753 * location.cs (ToString): Provide useful rutine.
13755 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13757 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
13758 objects, return the actual integral boxed.
13760 * statement.cs (SwitchLabel): define an ILLabel for each
13763 (Switch.CheckSwitch): If the value is a Literal, extract
13764 the underlying literal.
13766 Also in the unused hashtable we had, add the SwitchLabel so we can
13767 quickly look this value up.
13769 * constant.cs: Implement a bunch of new constants. Rewrite
13770 Literal based on this. Made changes everywhere to adapt to this.
13772 * expression.cs (Expression.MakeByteBlob): Optimize routine by
13773 dereferencing array only once, and also copes with enumrations.
13775 bytes are two bytes wide, not one.
13777 (Cast): Perform constant conversions.
13779 * ecore.cs (TryImplicitIntConversion): Return literals instead of
13780 wrappers to the literals here.
13782 * expression.cs (DoNumericPromotions): long literals can converted
13783 to ulong implicity (this is taken care of elsewhere, but I was
13784 missing this spot).
13786 * ecore.cs (Expression.Literalize): Make the return type Literal,
13787 to improve type checking.
13789 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
13791 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13793 * literal.cs: Revert code from ravi that checked the bounds. The
13794 bounds are sane by the definition of the type itself.
13796 * typemanager.cs: Fix implementation of ImplementsInterface. We
13797 need to actually look up in our parent hierarchy for interfaces
13800 * const.cs: Use the underlying type for enumerations
13802 * delegate.cs: Compute the basename for the delegate creation,
13803 that should fix the delegate test case, and restore the correct
13804 Type Lookup semantics in rootcontext
13806 * rootcontext.cs: Revert Ravi's last patch. The correct way of
13807 referencing a nested type with the Reflection API is using the "+"
13810 * cs-parser.jay: Do not require EOF token at the end.
13812 2001-12-20 Ravi Pratap <ravi@ximian.com>
13814 * rootcontext.cs (LookupType): Concatenate type names with
13815 a '.' instead of a '+' The test suite passes again.
13817 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
13818 field of the enumeration.
13820 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
13821 the case when the member is an EventExpr.
13823 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
13824 static has an associated instance expression.
13826 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
13828 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
13830 * class.cs (Event.Define): Register event and perform appropriate checks
13833 We define the Add and Remove methods even if the use provides none because
13834 in that case, we provide default implementations ourselves.
13836 Define a private field of the type of the event. This is done by the CSC compiler
13837 and we should be doing it too ;-)
13839 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
13840 More methods we use in code we generate.
13842 (multicast_delegate_type, delegate_type): Two separate types since the distinction
13845 (InitCoreTypes): Update accordingly for the above.
13847 * class.cs (Event.Emit): Generate code for default accessors that we provide
13849 (EmitDefaultMethod): Do the job in the above.
13851 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
13854 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13856 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
13857 builders even if we were missing one.
13859 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
13860 pass the Basename as our class name instead of the Name. The
13861 basename will be correctly composed for us.
13863 * parameter.cs (Paramters): Now takes a Location argument.
13865 * decl.cs (DeclSpace.LookupType): Removed convenience function and
13866 make all the code call directly LookupType in RootContext and take
13867 this chance to pass the Location information everywhere.
13869 * Everywhere: pass Location information.
13871 2001-12-19 Miguel de Icaza <miguel@ximian.com>
13873 * class.cs (Constructor.Define): Updated way of detecting the
13874 length of the parameters.
13876 (TypeContainer.DefineType): Use basename as the type name for
13879 (TypeContainer.Define): Do not recursively define types here, as
13880 definition is taken care in order by the RootContext.
13882 * tree.cs: Keep track of namespaces in a per-file basis.
13884 * parameter.cs (Parameter.ComputeSignature): Update to use
13887 (Parameters.GetSignature): ditto.
13889 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
13890 instead of a TypeContainer.
13892 (Interface.SemanticAnalysis): Use `this' instead of our parent to
13893 resolve names. Because we need to be resolve in our context, not
13896 * driver.cs: Implement response files.
13898 * class.cs (TypeContainer.DefineType): If we are defined, do not
13899 redefine ourselves.
13901 (Event.Emit): Emit the code for add/remove handlers.
13902 (Event.Define): Save the MethodBuilders for add/remove.
13904 * typemanager.cs: Use pair here too.
13906 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
13907 DictionaryEntry requires the first argument to be non-null.
13909 (enum_declaration): Compute full name for registering the
13912 (delegate_declaration): Instead of using
13913 formal_parameter_list, use opt_formal_parameter_list as the list
13916 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
13917 (EventParsing): New property that controls whether `add' and
13918 `remove' are returned as tokens or identifiers (for events);
13920 2001-12-19 Ravi Pratap <ravi@ximian.com>
13922 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
13923 use MyEventBuilder only and let it wrap the real builder for us.
13925 (MyEventBuilder): Revamp constructor etc.
13927 Implement all operations that we perform on EventBuilder in precisely the same
13930 (FindMembers): Update to use the EventBuilder member.
13932 (Event.Emit): Update accordingly.
13934 2001-12-18 Ravi Pratap <ravi@ximian.com>
13936 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
13937 by calling the appropriate methods.
13939 (GetCustomAttributes): Make stubs as they cannot possibly do anything
13942 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
13944 2001-12-17 Ravi Pratap <ravi@ximian.com>
13946 * delegate.cs (Delegate.Populate): Check that the return type
13947 and various parameters types are indeed accessible.
13949 * class.cs (Constructor.Define): Same here.
13951 (Field.Define): Ditto.
13953 (Event.Define): Ditto.
13955 (Operator.Define): Check that the underlying Method defined itself
13956 correctly - so it's MethodBuilder should not be null.
13958 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
13959 expression happens to be null.
13961 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
13962 members but as of now we don't seem to be able to do anything really useful with it.
13964 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
13965 not the EventBuilder.
13967 2001-12-18 Miguel de Icaza <miguel@ximian.com>
13969 * cs-tokenizer.cs: Add support for defines.
13970 Add support for #if, #elif, #else, #endif
13972 (eval_var): evaluates a variable.
13973 (eval): stubbed for evaluating functions.
13975 * cs-parser.jay: Pass the defines information
13977 * driver.cs: Add --define command line option.
13979 * decl.cs: Move MemberCore here.
13981 Make it the base class for DeclSpace. This allows us to catch and
13982 report 108 and 109 for everything now.
13984 * class.cs (TypeContainer.Define): Extract all the members
13985 before populating and emit the warning 108 (new keyword required
13986 to override) instead of having each member implement this.
13988 (MemberCore.Define): New abstract method, we will be using this in
13989 the warning reporting engine in Populate.
13991 (Operator.Define): Adjust to new MemberCore protocol.
13993 * const.cs (Const): This does not derive from Expression, it is a
13994 temporary object we use to create fields, it is a MemberCore.
13996 * class.cs (Method.Define): Allow the entry point to be in a
13999 * driver.cs: Rewrite the argument handler to clean it up a bit.
14001 * rootcontext.cs: Made it just an auxiliary namespace feature by
14002 making everything static.
14004 * driver.cs: Adapt code to use RootContext type name instead of
14007 * delegate.cs: Remove RootContext argument.
14009 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14012 * class.cs (Event.Define): The lookup can fail.
14014 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14016 * expression.cs: Resolve the this instance before invoking the code.
14018 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14020 * cs-parser.jay: Add a production in element_access that allows
14021 the thing to become a "type" reference. This way we can parse
14022 things like "(string [])" as a type.
14024 Note that this still does not handle the more complex rules of
14028 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14030 * ecore.cs: (CopyNewMethods): new utility function used to
14031 assemble the list of methods from running FindMembers.
14033 (MemberLookup): Rework FindMembers so that
14035 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14037 * class.cs (TypeContainer): Remove Delegates who fail to be
14040 * delegate.cs (Populate): Verify that we dont get null return
14041 values. TODO: Check for AsAccessible.
14043 * cs-parser.jay: Use basename to emit error 574 (destructor should
14044 have the same name as container class), not the full name.
14046 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14047 possible representation.
14049 Also implements integer type suffixes U and L.
14051 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14053 * expression.cs (ArrayCreation.DoResolve): We need to do the
14054 argument resolution *always*.
14056 * decl.cs: Make this hold the namespace. Hold the root context as
14058 (LookupType): Move here.
14060 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14062 * location.cs (Row, Name): Fixed the code, it was always returning
14063 references to the first file.
14065 * interface.cs: Register properties defined through interfaces.
14067 * driver.cs: Add support for globbing on the command line
14069 * class.cs (Field): Make it derive from MemberCore as well.
14072 2001-12-15 Ravi Pratap <ravi@ximian.com>
14074 * class.cs (Event::Define): Check that the type of the event is a delegate
14075 type else flag error #66.
14077 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14080 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14081 values of EntryPoint, CharSet etc etc.
14083 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14085 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14086 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14087 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14088 which needs this to do its work.
14090 * ../errors/cs0066.cs : Add.
14092 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14094 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14097 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14098 clears out the parameters field.
14099 (MemberSignatureCompare): Cleanup
14101 (MemberCore): New base class used to share code between MethodCore
14104 (RegisterRequiredImplementations) BindingFlags.Public requires
14105 either BindingFlags.Instace or Static. Use instance here.
14107 (Property): Refactored code to cope better with the full spec.
14109 * parameter.cs (GetParameterInfo): Return an empty array instead
14112 * class.cs (Property): Abstract or extern properties have no bodies.
14114 * parameter.cs (GetParameterInfo): return a zero-sized array.
14116 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14117 method modifier validation to the typecontainer so we can reuse
14118 this on properties.
14120 (MethodCore.ParameterTypes): return an empty sized array of types.
14122 (Property.Define): Test property modifier validity.
14124 Add tests for sealed/override too.
14126 (Method.Emit): abstract or extern methods have no bodies.
14128 2001-12-14 Ravi Pratap <ravi@ximian.com>
14130 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14133 (Method::Define, ::Emit): Modify accordingly.
14135 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14137 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14139 * makefile: Pass in /unsafe.
14141 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14143 * class.cs (MakeKey): Kill routine.
14145 * class.cs (TypeContainer.Define): Correctly define explicit
14146 method implementations (they require the full interface name plus
14149 * typemanager.cs: Deply the PtrHashtable here and stop using the
14150 lame keys. Things work so much better.
14152 This of course broke everyone who depended on `RegisterMethod' to
14153 do the `test for existance' test. This has to be done elsewhere.
14155 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14156 the object stupid Equals method (because, that like fails all over
14157 the place). We still do not use it.
14159 * class.cs (TypeContainer.SetRequiredInterface,
14160 TypeContainer.RequireMethods): Killed these two routines and moved
14161 all the functionality to RegisterRequiredImplementations.
14163 (TypeContainer.RegisterRequiredImplementations): This routine now
14164 registers all the implementations required in an array for the
14165 interfaces and abstract methods. We use an array of structures
14166 which can be computed ahead of time to reduce memory usage and we
14167 also assume that lookups are cheap as most classes will not
14168 implement too many interfaces.
14170 We also avoid creating too many MethodSignatures.
14172 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14173 clear the "pending" bit if we find that there are problems with
14176 (TypeContainer.VerifyPendingMethods): Update to report errors of
14177 methods that look like implementations but are not.
14179 (TypeContainer.Define): Add support for explicit interface method
14182 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14184 * typemanager.cs: Keep track of the parameters here instead of
14185 being a feature of the TypeContainer.
14187 * class.cs: Drop the registration of parameters here, as
14188 InterfaceMethods are also interface declarations.
14190 * delegate.cs: Register methods with the TypeManager not only with
14191 the TypeContainer. This code was buggy.
14193 * interface.cs: Full registation here.
14195 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14197 * expression.cs: Remove reducer for binary expressions, it can not
14200 * const.cs: Put here the code that used to go into constant.cs
14202 * constant.cs: Put here the code for constants, this is a new base
14203 class for Literals.
14205 * literal.cs: Make Literal derive from Constant.
14207 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14209 * statement.cs (Return.Emit): Report error 157 if the user
14210 attempts to return from a finally block.
14212 (Return.Emit): Instead of emitting a return, jump to the end of
14215 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14216 LocalBuilder to store the result of the function. ReturnLabel is
14217 the target where we jump.
14220 2001-12-09 Radek Doulik <rodo@ximian.com>
14222 * cs-parser.jay: remember alias in current namespace
14224 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14227 * class.cs (LookupAlias): lookup alias in my_namespace
14229 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14231 (LookupAlias): lookup alias in this and if needed in parent
14234 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14238 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14239 making things static. I need this to avoid passing the
14240 TypeContainer when calling ParameterType.
14242 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14243 that did string manipulation to compute the type and then call
14244 GetType. Use Parameter.ParameterType instead.
14246 * cs-tokenizer.cs: Consume the suffix for floating values.
14248 * expression.cs (ParameterReference): figure out whether this is a
14249 reference parameter or not. Kill an extra variable by computing
14250 the arg_idx during emission.
14252 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14253 function that returns whether a parameter is an out/ref value or not.
14255 (Parameter.ParameterType): The type of the parameter (base,
14256 without ref/out applied).
14258 (Parameter.Resolve): Perform resolution here.
14259 (Parameter.ExternalType): The full type (with ref/out applied).
14261 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14262 support for expressions on the using statement.
14264 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14266 * statement.cs (Using.EmitLocalVariableDecls): Split the
14267 localvariable handling of the using statement.
14269 (Block.EmitMeta): Keep track of variable count across blocks. We
14270 were reusing slots on separate branches of blocks.
14272 (Try.Emit): Emit the general code block, we were not emitting it.
14274 Check the type of the declaration to be an IDisposable or
14275 something that can be implicity converted to it.
14277 Emit conversions if required.
14279 * ecore.cs (EmptyExpression): New utility class.
14280 (Expression.ImplicitConversionExists): New utility function.
14282 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14284 * statement.cs (Using): Implement.
14286 * expression.cs (LocalVariableReference): Support read only variables.
14288 * statement.cs: Remove the explicit emit for the Leave opcode.
14289 (VariableInfo): Add a readonly field.
14291 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14293 * ecore.cs (ConvCast): new class used to encapsulate the various
14294 explicit integer conversions that works in both checked and
14295 unchecked contexts.
14297 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14298 properly generate the overflow opcodes.
14300 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14302 * statement.cs: The correct type for the EmptyExpression is the
14303 element_type, not the variable type. Ravi pointed this out.
14305 2001-12-04 Ravi Pratap <ravi@ximian.com>
14307 * class.cs (Method::Define): Handle PInvoke methods specially
14308 by using DefinePInvokeMethod instead of the usual one.
14310 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14311 above to do the task of extracting information and defining the method.
14313 2001-12-04 Ravi Pratap <ravi@ximian.com>
14315 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14316 of the condition for string type.
14318 (Emit): Move that here.
14320 (ArrayCreation::CheckIndices): Keep string literals in their expression
14323 (EmitDynamicInitializers): Handle strings appropriately.
14325 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14327 * codegen.cs (EmitContext): Replace multiple variables with a
14328 single pointer to the current Switch statement.
14330 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14333 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14337 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14340 (Foreach.Emit): Foreach on arrays was not setting
14341 up the loop variables (for break/continue).
14343 (GotoCase): Semi-implented.
14345 2001-12-03 Ravi Pratap <ravi@ximian.com>
14347 * attribute.cs (CheckAttribute): Handle system attributes by using
14348 Attribute.GetAttributes to examine information we need.
14350 (GetValidPlaces): Same here.
14352 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14354 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14356 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14358 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14360 (Method::Emit): Handle the case when we are a PInvoke method.
14362 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14364 * expression.cs: Use ResolveWithSimpleName on compound names.
14366 2001-12-02 Ravi Pratap <ravi@ximian.com>
14368 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14369 before trying to reduce it.
14371 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14373 * constant.cs (LookupConstantValue): Implement.
14375 (EmitConstant): Use the above in emitting the constant.
14377 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14378 that are user-defined by doing a LookupConstantValue on them.
14380 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14383 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14385 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14387 (BaseAccess.DoResolve): Implement.
14389 (MemberAccess.DoResolve): Split this routine into a
14390 ResolveMemberAccess routine that can be used independently
14392 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14394 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14395 As that share bits of the implementation. Is returns a boolean,
14396 while As returns the Type that is being probed.
14398 2001-12-01 Ravi Pratap <ravi@ximian.com>
14400 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14401 instead of a Literal - much easier.
14403 (EnumInTransit): Remove - utterly useless :-)
14405 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14407 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14409 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14410 chain when we have no associated expression.
14412 2001-11-30 Ravi Pratap <ravi@ximian.com>
14414 * constant.cs (Define): Use Location while reporting the errror.
14416 Also emit a warning when 'new' is used and there is no inherited
14419 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14422 (LookupEnumValue): Implement to lookup an enum member's value and define it
14425 (Populate): Re-write accordingly to use the above routine.
14427 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14429 * expression.cs (This): Fix prototype for DoResolveLValue to
14430 override the base class DoResolveLValue.
14432 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14435 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14436 (we need to load the address of the field here). This fixes
14439 (FieldExpr.DoResolveLValue): Call the DoResolve
14440 function to initialize the Instance expression.
14442 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14443 correctly the GetEnumerator operation on a value type.
14445 * cs-parser.jay: Add more simple parsing error catches.
14447 * statement.cs (Switch): Add support for string switches.
14448 Handle null specially.
14450 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14452 2001-11-28 Ravi Pratap <ravi@ximian.com>
14454 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14456 (declare_local_constant): New helper function.
14458 * statement.cs (AddConstant): Keep a separate record of constants
14460 (IsConstant): Implement to determine if a variable is a constant.
14462 (GetConstantExpression): Implement.
14464 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14466 * statement.cs (IsVariableDefined): Re-write.
14468 2001-11-27 Ravi Pratap <ravi@ximian.com>
14470 * class.cs (TypeContainer::FindMembers): Look for constants
14471 in the case when we are looking for MemberTypes.Field
14473 * expression.cs (MemberAccess::DoResolve): Check that in the
14474 case we are a FieldExpr and a Literal, we are not being accessed
14475 by an instance reference.
14477 * cs-parser.jay (local_constant_declaration): Implement.
14479 (declaration_statement): Implement for constant declarations.
14481 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14483 * statement.cs (Switch): Catch double defaults.
14485 (Switch): More work on the switch() statement
14486 implementation. It works for integral values now, need to finish
14490 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14492 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14493 integer literals into other integer literals. To be used by
14496 2001-11-24 Ravi Pratap <ravi@ximian.com>
14498 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14501 (EmitDynamicInitializers): Cope with the above since we extract data
14502 directly from ArrayData now.
14504 (ExpectInitializers): Keep track of whether initializers are mandatory
14507 (Bounds): Make it a hashtable to prevent the same dimension being
14508 recorded for every element in that dimension.
14510 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14513 Also fix bug which was causing the indices to be emitted in the reverse
14516 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14518 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14519 unfinished. They do not work, because the underlying code is
14522 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14524 * cs-parser.jay: Remove bogus fixme.
14526 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14527 on Switch statement.
14529 2001-11-23 Ravi Pratap <ravi@ximian.com>
14531 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14534 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14535 parameter. Apparently, any expression is allowed.
14537 (ValidateInitializers): Update accordingly.
14539 (CheckIndices): Fix some tricky bugs thanks to recursion.
14541 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14542 I was being completely brain-dead.
14544 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14545 and re-write acordingly.
14547 (DelegateInvocation): Re-write accordingly.
14549 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14551 (MakeByteBlob): Handle types more correctly.
14553 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14554 initialization from expressions but it is incomplete because I am a complete
14557 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14559 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14560 on If. Basically, we have to return `true' (ie, we do return to
14561 our caller) only if both branches of the if return.
14563 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14564 short-circuit operators, handle them as short circuit operators.
14566 (Cast.DoResolve): Resolve type.
14567 (Cast.Cast): Take an expression as the target type.
14569 * cs-parser.jay (cast_expression): Remove old hack that only
14570 allowed a limited set of types to be handled. Now we take a
14571 unary_expression and we resolve to a type during semantic
14574 Use the grammar productions from Rhys to handle casts (this is
14575 not complete like Rhys syntax yet, we fail to handle that corner
14576 case that C# has regarding (-x), but we will get there.
14578 2001-11-22 Ravi Pratap <ravi@ximian.com>
14580 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14581 field which is an array type.
14583 * cs-parser.jay (declare_local_variables): Support array initialization too.
14585 * typemanager.cs (MakeKey): Implement.
14587 (everywhere): Use the above appropriately.
14589 * cs-parser.jay (for_statement): Update for array initialization while
14590 declaring variables.
14592 * ecore.cs : The error message was correct, it's the variable's names that
14593 were misleading ;-) Make the code more readable.
14595 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14596 the correct type etc.
14598 (ConvertExplicit): Handle Enum types by examining the underlying type.
14600 2001-11-21 Ravi Pratap <ravi@ximian.com>
14602 * parameter.cs (GetCallingConvention): Always return
14603 CallingConventions.Standard for now.
14605 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14607 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14608 and `r' after calling DoNumericPromotions.
14610 * ecore.cs: Fix error message (the types were in the wrong order).
14612 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14613 BindingFlags.Instance as well
14615 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14616 implicit int literal conversion in an empty cast so that we
14617 propagate the right type upstream.
14619 (UnboxCast): new class used to unbox value types.
14620 (Expression.ConvertExplicit): Add explicit type conversions done
14623 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14624 the target type before applying the implicit LongLiterals to ULong
14627 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14629 * cs-parser.jay (for_statement): Reworked the way For works: now
14630 we declare manually any variables that are introduced in
14631 for_initializer to solve the problem of having out-of-band code
14632 emition (that is what got for broken).
14634 (declaration_statement): Perform the actual variable declaration
14635 that used to be done in local_variable_declaration here.
14637 (local_variable_declaration): Do not declare anything, just pass
14638 the information on a DictionaryEntry
14640 2001-11-20 Ravi Pratap <ravi@ximian.com>
14642 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14643 re-write of the logic to now make it recursive.
14645 (UpdateIndices): Re-write accordingly.
14647 Store element data in a separate ArrayData list in the above methods.
14649 (MakeByteBlob): Implement to dump the array data into a byte array.
14651 2001-11-19 Ravi Pratap <ravi@ximian.com>
14653 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
14656 * constant.cs (Define): Implement.
14658 (EmitConstant): Re-write fully.
14660 Pass in location info.
14662 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
14665 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
14666 DictionaryEntry since we need location info too.
14668 (constant_declaration): Update accordingly.
14670 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14671 code into another method : UpdateIndices.
14673 2001-11-18 Ravi Pratap <ravi@ximian.com>
14675 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14676 some type checking etc.
14678 2001-11-17 Ravi Pratap <ravi@ximian.com>
14680 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14681 bits to provide dimension info if the user skips doing that.
14683 Update second constructor to store the rank correctly.
14685 2001-11-16 Ravi Pratap <ravi@ximian.com>
14687 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14688 and try to implement.
14690 * ../errors/cs0150.cs : Add.
14692 * ../errors/cs0178.cs : Add.
14694 2001-11-16 Miguel de Icaza <miguel@ximian.com>
14696 * statement.cs: Implement foreach on multi-dimensional arrays.
14698 * parameter.cs (Parameters.GetParameterByName): Also lookup the
14699 name of the params argument.
14701 * expression.cs: Use EmitStoreOpcode to get the right opcode while
14702 initializing the array.
14704 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
14705 we can use this elsewhere.
14707 * statement.cs: Finish implementation of foreach for single
14710 * cs-parser.jay: Use an out-of-band stack to pass information
14711 around, I wonder why I need this.
14713 foreach_block: Make the new foreach_block the current_block.
14715 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
14716 function used to return a static Parameters structure. Used for
14717 empty parameters, as those are created very frequently.
14719 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
14721 2001-11-15 Ravi Pratap <ravi@ximian.com>
14723 * interface.cs : Default modifier is private, not public. The
14724 make verify test passes again.
14726 2001-11-15 Ravi Pratap <ravi@ximian.com>
14728 * support.cs (ReflectionParameters): Fix logic to determine
14729 whether the last parameter is a params one. Test 9 passes again.
14731 * delegate.cs (Populate): Register the builders we define with
14732 RegisterParameterForBuilder. Test 19 passes again.
14734 * cs-parser.jay (property_declaration): Reference $6 instead
14735 of $$ to get at the location.
14737 (indexer_declaration): Similar stuff.
14739 (attribute): Ditto.
14741 * class.cs (Property): Register parameters for the Get and Set methods
14742 if they exist. Test 23 passes again.
14744 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
14745 call to EmitArguments as we are sure there aren't any params arguments.
14746 Test 32 passes again.
14748 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
14749 IndexOutOfRangeException.
14751 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
14752 Test 33 now passes again.
14754 2001-11-15 Miguel de Icaza <miguel@ximian.com>
14756 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
14757 broke a bunch of things. Will have to come up with a better way
14758 of tracking locations.
14760 * statement.cs: Implemented foreach for single dimension arrays.
14762 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14764 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
14765 an error. This removes the lookup from the critical path.
14767 * cs-parser.jay: Removed use of temporary_loc, which is completely
14770 2001-11-14 Miguel de Icaza <miguel@ximian.com>
14772 * support.cs (ReflectionParameters.ParameterModifier): Report
14773 whether the argument is a PARAMS argument or not.
14775 * class.cs: Set the attribute `ParamArrayAttribute' on the
14776 parameter argument.
14778 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
14779 and cons_param_array_attribute (ConstructorInfo for
14780 ParamArrayAttribute).,
14782 * codegen.cs: Emit the return using the `Return' statement, that
14783 way we can report the error correctly for missing return values.
14785 * class.cs (Method.Emit): Clean up.
14787 * expression.cs (Argument.Resolve): Take another argument: the
14788 location where this argument is used. Notice that this is not
14789 part of the "Argument" class as to reduce the size of the
14790 structure (we know the approximate location anyways).
14792 Test if the argument is a variable-reference, if not, then
14793 complain with a 206.
14795 (Argument.Emit): Emit addresses of variables.
14797 (Argument.FullDesc): Simplify.
14799 (Invocation.DoResolve): Update for Argument.Resolve.
14801 (ElementAccess.DoResolve): ditto.
14803 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
14804 method should be virtual, as this method is always virtual.
14806 (NewDelegate.DoResolve): Update for Argument.Resolve.
14808 * class.cs (ConstructorInitializer.DoResolve): ditto.
14810 * attribute.cs (Attribute.Resolve): ditto.
14812 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14814 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
14816 * expression.cs (ParameterReference): Drop IStackStorage and implement
14817 IAssignMethod instead.
14819 (LocalVariableReference): ditto.
14821 * ecore.cs (FieldExpr): Drop IStackStorage and implement
14822 IAssignMethod instead.
14824 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14826 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
14827 enumerations that are used in heavily used structures derive from
14828 byte in a laughable and pathetic attempt to reduce memory usage.
14829 This is the kind of pre-optimzations that you should not do at
14830 home without adult supervision.
14832 * expression.cs (UnaryMutator): New class, used to handle ++ and
14833 -- separatedly from the other unary operators. Cleans up the
14834 code, and kills the ExpressionStatement dependency in Unary.
14836 (Unary): Removed `method' and `Arguments' from this class, making
14837 it smaller, and moving it all to SimpleCall, so I can reuse this
14838 code in other locations and avoid creating a lot of transient data
14839 strucutres when not required.
14841 * cs-parser.jay: Adjust for new changes.
14843 2001-11-11 Miguel de Icaza <miguel@ximian.com>
14845 * enum.cs (Enum.Populate): If there is a failure during
14848 * cs-parser.jay (opt_enum_base): we used to catch type errors
14849 here, but this is really incorrect. The type error should be
14850 catched during semantic analysis.
14852 2001-12-11 Ravi Pratap <ravi@ximian.com>
14854 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
14855 current_local_parameters as expected since I, in my stupidity, had forgotten
14858 * attribute.cs (GetValidPlaces): Fix stupid bug.
14860 * class.cs (Method::Emit): Perform check on applicability of attributes.
14862 (Constructor::Emit): Ditto.
14864 (Field::Emit): Ditto.
14866 (Field.Location): Store location information.
14868 (Property, Event, Indexer, Operator): Ditto.
14870 * cs-parser.jay (field_declaration): Pass in location for each field.
14872 * ../errors/cs0592.cs : Add.
14874 2001-11-12 Ravi Pratap <ravi@ximian.com>
14876 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
14878 (InitCoreTypes): Update accordingly.
14880 (RegisterAttrType, LookupAttr): Implement.
14882 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
14883 info about the same.
14885 (Resolve): Update to populate the above as necessary.
14887 (Error592): Helper.
14889 (GetValidPlaces): Helper to the above.
14891 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
14893 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
14895 2001-11-12 Ravi Pratap <ravi@ximian.com>
14897 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
14899 * ../errors/cs0617.cs : Add.
14901 2001-11-11 Ravi Pratap <ravi@ximian.com>
14903 * enum.cs (Emit): Rename to Populate to be more consistent with what
14904 we expect it to do and when exactly it is called.
14906 * class.cs, rootcontext.cs : Update accordingly.
14908 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
14909 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
14911 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
14913 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
14914 of a fieldinfo using the above, when dealing with a FieldBuilder.
14916 2001-11-10 Ravi Pratap <ravi@ximian.com>
14918 * ../errors/cs0031.cs : Add.
14920 * ../errors/cs1008.cs : Add.
14922 * ../errrors/cs0543.cs : Add.
14924 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
14927 (FindMembers): Implement.
14929 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
14930 enums and delegates too.
14932 (enum_types): Rename to builder_to_enum.
14934 (delegate_types): Rename to builder_to_delegate.
14936 * delegate.cs (FindMembers): Implement.
14938 2001-11-09 Ravi Pratap <ravi@ximian.com>
14940 * typemanager.cs (IsEnumType): Implement.
14942 * enum.cs (Emit): Re-write parts to account for the underlying type
14943 better and perform checking etc.
14945 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
14946 of the underlying type.
14948 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
14951 * enum.cs (error31): Helper to report error #31.
14953 * cs-parser.jay (enum_declaration): Store location of each member too.
14955 * enum.cs (member_to_location): New hashtable.
14957 (AddEnumMember): Update location hashtable.
14959 (Emit): Use the location of each member while reporting errors.
14961 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14963 * cs-parser.jay: A for_initializer if is a
14964 local_variable_declaration really ammount to have an implicit
14965 block with the variable declaration and no initializer for for.
14967 * statement.cs (For.Emit): Cope with null initializers.
14969 This fixes the infinite loop on for initializers.
14971 2001-11-08 Miguel de Icaza <miguel@ximian.com>
14973 * enum.cs: More cleanup.
14975 * ecore.cs: Remove dead code.
14977 * class.cs (Property.Emit): More simplification.
14978 (Event.Emit): ditto.
14980 Reworked to have less levels of indentation.
14982 2001-11-08 Ravi Pratap <ravi@ximian.com>
14984 * class.cs (Property): Emit attributes.
14994 * enum.cs (Emit): Ditto.
14996 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
14999 * class.cs (Field, Event, etc.): Move attribute generation into the
15000 Emit method everywhere.
15002 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15003 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15004 as we had no way of defining nested enums !
15006 * rootcontext.cs : Adjust code accordingly.
15008 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15010 2001-11-07 Ravi Pratap <ravi@ximian.com>
15012 * expression.cs (EvalConstantExpression): Move into ecore.cs
15014 * enum.cs (Enum): Rename some members and make them public and readonly
15015 according to our convention.
15017 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15020 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15022 (Enum::Emit): Write a simple version for now which doesn't try to compute
15023 expressions. I shall modify this to be more robust in just a while.
15025 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15027 (TypeContainer::CloseType): Create the Enum types too.
15029 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15031 * expression.cs (EvalConstantExpression): Get rid of completely.
15033 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15034 user-defined values and other cases.
15036 (IsValidEnumLiteral): Helper function.
15038 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15039 out there in the case we had a literal FieldExpr.
15041 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15043 (Literalize): Revamp a bit to take two arguments.
15045 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15047 2001-11-06 Ravi Pratap <ravi@ximian.com>
15049 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15051 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15053 (Resolve): Use the above to ensure we have proper initializers.
15055 2001-11-05 Ravi Pratap <ravi@ximian.com>
15057 * expression.cs (Expression::EvalConstantExpression): New method to
15058 evaluate constant expressions.
15060 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15062 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15064 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15067 (Binary.ResolveOperator): Handle operator != (object a, object b)
15068 and operator == (object a, object b);
15070 (Binary.DoNumericPromotions): Indicate whether the numeric
15071 promotion was possible.
15073 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15076 Made the ArrayAccess implement interface IAssignMethod instead of
15077 IStackStore as the order in which arguments are passed reflects
15080 * assign.cs: Instead of using expr.ExprClass to select the way of
15081 assinging, probe for the IStackStore/IAssignMethod interfaces.
15083 * typemanager.cs: Load InitializeArray definition.
15085 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15086 static data that can be used to initialize arrays.
15088 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15090 * expression.cs: Handle operator== and operator!= for booleans.
15092 (Conditioal.Reduce): Implement reducer for the ?: operator.
15094 (Conditional.Resolve): Implement dead code elimination.
15096 (Binary.Resolve): Catch string literals and return a new
15097 concatenated string.
15099 (Unary.Reduce): Implement reduction of unary expressions.
15101 * ecore.cs: Split out the expression core handling here.
15103 (Expression.Reduce): New method used to perform constant folding
15104 and CSE. This is needed to support constant-expressions.
15106 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15107 targets, and optimize for !x.
15109 2001-11-04 Ravi Pratap <ravi@ximian.com>
15111 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15112 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15113 set custom atttributes.
15115 * literal.cs (Literal::GetValue): New abstract method to return the actual
15116 value of the literal, cast as an object.
15118 (*Literal): Implement GetValue method.
15120 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15121 expressions to the arraylist but objects of type Argument.
15123 * class.cs (TypeContainer::Emit): Emit our attributes too.
15125 (Method::Emit, Constructor::Emit): Ditto.
15127 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15128 to be ignoring earlier.
15130 2001-11-03 Ravi Pratap <ravi@ximian.com>
15132 * attribute.cs (AttributeSection::Define): Implement to do the business
15133 of constructing a CustomAttributeBuilder.
15135 (Attribute): New trivial class. Increases readability of code.
15137 * cs-parser.jay : Update accordingly.
15139 (positional_argument_list, named_argument_list, named_argument): New rules
15141 (attribute_arguments): Use the above so that we are more correct.
15143 2001-11-02 Ravi Pratap <ravi@ximian.com>
15145 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15146 to perform all checks for a method with a params parameter.
15148 (Invocation::OverloadResolve): Update to use the above method and therefore
15149 cope correctly with params method invocations.
15151 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15154 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15155 constructors in our parent too because we can't afford to miss out on
15158 * attribute.cs (AttributeSection): New name for the class Attribute
15160 Other trivial changes to improve readability.
15162 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15163 use the new class names.
15165 2001-11-01 Ravi Pratap <ravi@ximian.com>
15167 * class.cs (Method::Define): Complete definition for params types too
15169 (Indexer::Define): Ditto.
15171 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15172 Cope everywhere with a request for info about the array parameter.
15174 2001-11-01 Ravi Pratap <ravi@ximian.com>
15176 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15178 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15179 local_variable_type to extract the string corresponding to the type.
15181 (local_variable_type): Fixup the action to use the new helper method.
15183 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15186 * expression.cs : Clean out code which uses the above.
15188 2001-10-31 Ravi Pratap <ravi@ximian.com>
15190 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15191 and bale out if necessary by returning a false.
15193 (RegisterProperty): Ditto.
15195 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15196 and print out appropriate error messages.
15198 * interface.cs (everywhere): Ditto.
15200 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15201 location to constructor.
15203 * class.cs (Property, Event, Indexer): Update accordingly.
15205 * ../errors/cs111.cs : Added.
15207 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15208 of a method, as laid down by the spec.
15210 (Invocation::OverloadResolve): Use the above method.
15212 2001-10-31 Ravi Pratap <ravi@ximian.com>
15214 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15215 now take a TypeContainer and a Parameters object.
15217 (ParameterData): Modify return type of ParameterModifier method to be
15218 Parameter.Modifier and not a string.
15220 (ReflectionParameters, InternalParameters): Update accordingly.
15222 * expression.cs (Argument::GetParameterModifier): Same here.
15224 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15225 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15226 symbol in it at all so maybe this is only for now.
15228 2001-10-30 Ravi Pratap <ravi@ximian.com>
15230 * support.cs (InternalParameters): Constructor now takes an extra argument
15231 which is the actual Parameters class.
15233 (ParameterDesc): Update to provide info on ref/out modifiers.
15235 * class.cs (everywhere): Update call to InternalParameters to pass in
15236 the second argument too.
15238 * support.cs (ParameterData): Add ParameterModifier, which is a method
15239 to return the modifier info [ref/out etc]
15241 (InternalParameters, ReflectionParameters): Implement the above.
15243 * expression.cs (Argument::ParameterModifier): Similar function to return
15244 info about the argument's modifiers.
15246 (Invocation::OverloadResolve): Update to take into account matching modifiers
15249 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15250 a new SetFormalParameters object which we pass to InternalParameters.
15252 2001-10-30 Ravi Pratap <ravi@ximian.com>
15254 * expression.cs (NewArray): Merge into the ArrayCreation class.
15256 2001-10-29 Ravi Pratap <ravi@ximian.com>
15258 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15259 NewUserdefinedArray into one as there wasn't much of a use in having
15262 * expression.cs (Argument): Change field's name to ArgType from Type.
15264 (Type): New readonly property which returns the proper type, taking into
15265 account ref/out modifiers.
15267 (everywhere): Adjust code accordingly for the above.
15269 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15270 whether we are emitting for a ref or out parameter.
15272 * expression.cs (Argument::Emit): Use the above field to set the state.
15274 (LocalVariableReference::Emit): Update to honour the flag and emit the
15277 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15279 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15281 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15283 (ReflectionParameters, InternalParameters): Implement the above method.
15285 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15288 (Invocation::FullMethodDesc): Ditto.
15290 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15292 * cs-parser.jay: Add extra production for the second form of array
15295 * expression.cs (ArrayCreation): Update to reflect the above
15298 * Small changes to prepare for Array initialization.
15300 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15302 * typemanager.cs (ImplementsInterface): interface might be null;
15303 Deal with this problem;
15305 Also, we do store negative hits on the cache (null values), so use
15306 this instead of calling t.GetInterfaces on the type everytime.
15308 2001-10-28 Ravi Pratap <ravi@ximian.com>
15310 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15312 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15313 split functionality out into different classes.
15315 (New::FormArrayType): Move into NewBuiltinArray.
15317 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15320 (NewBuiltinArray): New class to handle creation of built-in arrays.
15322 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15323 account creation of one-dimensional arrays.
15325 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15327 (NewUserdefinedArray::DoResolve): Implement.
15329 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15331 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15332 we maintain inside the TypeManager. This is necessary to perform lookups on the
15335 (LookupType): Update to perform GetType on the module builders too.
15337 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15339 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15341 2001-10-23 Ravi Pratap <ravi@ximian.com>
15343 * expression.cs (New::DoResolve): Implement guts of array creation.
15345 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15347 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15349 * expression.cs: Fix bug I introduced lsat night that broke
15352 (Expression.Resolve): Report a 246 error (can not resolve name)
15353 if we find a SimpleName in the stream.
15355 (Expression.ResolveLValue): Ditto.
15357 (Expression.ResolveWithSimpleName): This function is a variant of
15358 ResolveName, this one allows SimpleNames to be returned without a
15359 warning. The only consumer of SimpleNames is MemberAccess
15361 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15363 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15364 might arrive here. I have my doubts that this is correct.
15366 * statement.cs (Lock): Implement lock statement.
15368 * cs-parser.jay: Small fixes to support `lock' and `using'
15370 * cs-tokenizer.cs: Remove extra space
15372 * driver.cs: New flag --checked, allows to turn on integer math
15375 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15376 Threading.Monitor.Exit
15378 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15380 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15381 Expression Class to be IndexerAccess.
15383 Notice that Indexer::DoResolve sets the eclass to Value.
15385 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15387 * class.cs (TypeContainer::Emit): Emit code for indexers.
15389 * assign.cs (IAssignMethod): New interface implemented by Indexers
15390 and Properties for handling assignment.
15392 (Assign::Emit): Simplify and reuse code.
15394 * expression.cs (IndexerAccess, PropertyExpr): Implement
15395 IAssignMethod, clean up old code.
15397 2001-10-22 Ravi Pratap <ravi@ximian.com>
15399 * typemanager.cs (ImplementsInterface): New method to determine if a type
15400 implements a given interface. Provides a nice cache too.
15402 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15405 (ConvertReferenceExplicit): Ditto.
15407 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15408 various methods, with correct names etc.
15410 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15411 Operator.UnaryNegation.
15413 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15414 we have a unary plus or minus operator.
15416 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15419 * everywhere : update accordingly.
15421 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15424 * class.cs (Method::Define): For the case where we are implementing a method
15425 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15426 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15428 2001-10-21 Ravi Pratap <ravi@ximian.com>
15430 * interface.cs (FindMembers): Implement to work around S.R.E
15433 * typemanager.cs (IsInterfaceType): Implement.
15435 (FindMembers): Update to handle interface types too.
15437 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15438 use IsAssignableFrom as that is not correct - it doesn't work.
15440 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15441 and accordingly override EmitStatement.
15443 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15444 using the correct logic :-)
15446 2001-10-19 Ravi Pratap <ravi@ximian.com>
15448 * ../errors/cs-11.cs : Add to demonstrate error -11
15450 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15452 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15453 then pass this as a hint to ResolveLValue.
15455 * expression.cs (FieldExpr): Add Location information
15457 (FieldExpr::LValueResolve): Report assignment to readonly
15460 (Expression::ExprClassFromMemberInfo): Pass location information.
15462 (Expression::ResolveLValue): Add new method that resolves an
15465 (Expression::DoResolveLValue): Default invocation calls
15468 (Indexers): New class used to keep track of indexers in a given
15471 (IStackStore): Renamed from LValue, as it did not really describe
15472 what this did. Also ResolveLValue is gone from this interface and
15473 now is part of Expression.
15475 (ElementAccess): Depending on the element access type
15477 * typemanager.cs: Add `indexer_name_type' as a Core type
15478 (System.Runtime.CompilerServices.IndexerNameAttribute)
15480 * statement.cs (Goto): Take a location.
15482 2001-10-18 Ravi Pratap <ravi@ximian.com>
15484 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15485 if two delegates are compatible.
15487 (NewDelegate::DoResolve): Update to take care of the case when
15488 we instantiate a delegate from another delegate.
15490 * typemanager.cs (FindMembers): Don't even try to look up members
15491 of Delegate types for now.
15493 2001-10-18 Ravi Pratap <ravi@ximian.com>
15495 * delegate.cs (NewDelegate): New class to take care of delegate
15498 * expression.cs (New): Split the delegate related code out into
15499 the NewDelegate class.
15501 * delegate.cs (DelegateInvocation): New class to handle delegate
15504 * expression.cs (Invocation): Split out delegate related code into
15505 the DelegateInvocation class.
15507 2001-10-17 Ravi Pratap <ravi@ximian.com>
15509 * expression.cs (New::DoResolve): Implement delegate creation fully
15510 and according to the spec.
15512 (New::DoEmit): Update to handle delegates differently.
15514 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15515 because of which we were printing out arguments in reverse order !
15517 * delegate.cs (VerifyMethod): Implement to check if the given method
15518 matches the delegate.
15520 (FullDelegateDesc): Implement.
15522 (VerifyApplicability): Implement.
15524 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15525 delegate invocations too.
15527 (Invocation::Emit): Ditto.
15529 * ../errors/cs1593.cs : Added.
15531 * ../errors/cs1594.cs : Added.
15533 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15535 2001-10-16 Ravi Pratap <ravi@ximian.com>
15537 * typemanager.cs (intptr_type): Core type for System.IntPtr
15539 (InitCoreTypes): Update for the same.
15541 (iasyncresult_type, asynccallback_type): Ditto.
15543 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15546 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15549 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15550 the builders for the 4 members of a delegate type :-)
15552 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15555 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15557 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15559 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15561 * statement.cs (Break::Emit): Implement.
15562 (Continue::Emit): Implement.
15564 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15565 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15566 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15567 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15570 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15571 properties that track the label for the current loop (begin of the
15572 loop and end of the loop).
15574 2001-10-15 Ravi Pratap <ravi@ximian.com>
15576 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15577 use of emitting anything at all.
15579 * class.cs, rootcontext.cs : Get rid of calls to the same.
15581 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15583 (Populate): Define the constructor correctly and set the implementation
15586 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15589 (AddDelegateType): Implement.
15591 (IsDelegateType): Implement helper method.
15593 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15595 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15596 and accordingly handle it.
15598 * delegate.cs (Populate): Take TypeContainer argument.
15599 Implement bits to define the Invoke method. However, I still haven't figured out
15600 how to take care of the native int bit :-(
15602 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15603 Qualify the name of the delegate, not its return type !
15605 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15608 (StandardConversionExists): Checking for array types turns out to be recursive.
15610 (ConvertReferenceExplicit): Implement array conversion.
15612 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15614 2001-10-12 Ravi Pratap <ravi@ximian.com>
15616 * cs-parser.jay (delegate_declaration): Store the fully qualified
15617 name as it is a type declaration.
15619 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15622 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15623 as TypeContainer::DefineType.
15625 (Populate): Method in which all the definition of the various methods (Invoke)
15628 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15631 (CloseDelegate): Finally creates the delegate.
15633 * class.cs (TypeContainer::DefineType): Update to define delegates.
15634 (Populate, Emit and CloseType): Do the same thing here too.
15636 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15637 delegates in all these operations.
15639 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15641 * expression.cs: LocalTemporary: a new expression used to
15642 reference a temporary that has been created.
15644 * assign.cs: Handle PropertyAccess back here, so that we can
15645 provide the proper semantic access to properties.
15647 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15648 a few more explicit conversions.
15650 * modifiers.cs: `NEW' modifier maps to HideBySig.
15652 * expression.cs (PropertyExpr): Make this into an
15653 ExpressionStatement, and support the EmitStatement code path.
15655 Perform get/set error checking, clean up the interface.
15657 * assign.cs: recognize PropertyExprs as targets, and if so, turn
15658 them into toplevel access objects.
15660 2001-10-12 Miguel de Icaza <miguel@ximian.com>
15662 * expression.cs: PropertyExpr::PropertyExpr: use work around the
15665 * typemanager.cs: Keep track here of our PropertyBuilders again to
15666 work around lameness in SRE.
15668 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15670 * expression.cs (LValue::LValueResolve): New method in the
15671 interface, used to perform a second resolution pass for LValues.
15673 (This::DoResolve): Catch the use of this in static methods.
15675 (This::LValueResolve): Implement.
15677 (This::Store): Remove warning, assigning to `this' in structures
15680 (Invocation::Emit): Deal with invocation of
15681 methods on value types. We need to pass the address to structure
15682 methods rather than the object itself. (The equivalent code to
15683 emit "this" for structures leaves the entire structure on the
15684 stack instead of a pointer to it).
15686 (ParameterReference::DoResolve): Compute the real index for the
15687 argument based on whether the method takes or not a `this' pointer
15688 (ie, the method is static).
15690 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
15691 value types returned from functions when we need to invoke a
15692 method on the sturcture.
15695 2001-10-11 Ravi Pratap <ravi@ximian.com>
15697 * class.cs (TypeContainer::DefineType): Method to actually do the business of
15698 defining the type in the Modulebuilder or Typebuilder. This is to take
15699 care of nested types which need to be defined on the TypeBuilder using
15700 DefineNestedMethod.
15702 (TypeContainer::GetClassBases): Implement. Essentially the code from the
15703 methods in RootContext, only ported to be part of TypeContainer.
15705 (TypeContainer::GetInterfaceOrClass): Ditto.
15707 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
15709 * interface.cs (Interface::DefineInterface): New method. Does exactly
15710 what RootContext.CreateInterface did earlier, only it takes care of nested types
15713 (Interface::GetInterfaces): Move from RootContext here and port.
15715 (Interface::GetInterfaceByName): Same here.
15717 * rootcontext.cs (ResolveTree): Re-write.
15719 (PopulateTypes): Re-write.
15721 * class.cs (TypeContainer::Populate): Populate nested types too.
15722 (TypeContainer::Emit): Emit nested members too.
15724 * typemanager.cs (AddUserType): Do not make use of the FullName property,
15725 instead just use the name argument passed in as it is already fully
15728 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
15729 to TypeContainer mapping to see if a type is user-defined.
15731 * class.cs (TypeContainer::CloseType): Implement.
15733 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
15734 the default constructor.
15736 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
15739 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
15741 * interface.cs (CloseType): Create the type here.
15743 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
15746 Remove all the methods which are now in TypeContainer.
15748 2001-10-10 Ravi Pratap <ravi@ximian.com>
15750 * delegate.cs (Define): Re-write bits to define the delegate
15753 2001-10-10 Miguel de Icaza <miguel@ximian.com>
15755 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
15757 * expression.cs (ImplicitReferenceConversion): handle null as well
15758 as a source to convert to any reference type.
15760 * statement.cs (Return): Perform any implicit conversions to
15761 expected return type.
15763 Validate use of return statement.
15765 * codegen.cs (EmitContext): Pass the expected return type here.
15767 * class.cs (Method, Constructor, Property): Pass expected return
15768 type to EmitContext.
15770 2001-10-09 Miguel de Icaza <miguel@ximian.com>
15772 * expression.cs: Make DoResolve take an EmitContext instead of a
15775 Replaced `l' and `location' for `loc', for consistency.
15777 (Error, Warning): Remove unneeded Tc argument.
15779 * assign.cs, literal.cs, constant.cs: Update to new calling
15782 * codegen.cs: EmitContext now contains a flag indicating whether
15783 code is being generated in a static method or not.
15785 * cs-parser.jay: DecomposeQI, new function that replaces the old
15786 QualifiedIdentifier. Now we always decompose the assembled
15787 strings from qualified_identifier productions into a group of
15790 2001-10-08 Miguel de Icaza <miguel@ximian.com>
15792 * rootcontext.cs: Deal with field-less struct types correctly now
15793 by passing the size option to Define Type.
15795 * class.cs: Removed hack that created one static field.
15797 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15799 * statement.cs: Moved most of the code generation here.
15801 2001-10-09 Ravi Pratap <ravi@ximian.com>
15803 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
15806 (ElementAccess): Remove useless bits for now - keep checks as the spec
15809 2001-10-08 Ravi Pratap <ravi@ximian.com>
15811 * expression.cs (ElementAccess::DoResolve): Remove my crap code
15812 and start performing checks according to the spec.
15814 2001-10-07 Ravi Pratap <ravi@ximian.com>
15816 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
15817 rank_specifiers instead.
15819 (rank_specifiers): Change the order in which the rank specifiers are stored
15821 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
15823 * expression.cs (ElementAccess): Implement the LValue interface too.
15825 2001-10-06 Ravi Pratap <ravi@ximian.com>
15827 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
15828 except that user defined conversions are not included.
15830 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
15831 perform the conversion of the return type, if necessary.
15833 (New::DoResolve): Check whether we are creating an array or an object
15834 and accordingly do the needful.
15836 (New::Emit): Same here.
15838 (New::DoResolve): Implement guts of array creation.
15840 (New::FormLookupType): Helper function.
15842 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15844 * codegen.cs: Removed most of the code generation here, and move the
15845 corresponding code generation bits to the statement classes.
15847 Added support for try/catch/finalize and throw.
15849 * cs-parser.jay: Added support for try/catch/finalize.
15851 * class.cs: Catch static methods having the flags override,
15852 virtual or abstract.
15854 * expression.cs (UserCast): This user cast was not really doing
15855 what it was supposed to do. Which is to be born in fully resolved
15856 state. Parts of the resolution were being performed at Emit time!
15860 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15862 * expression.cs: Implicity convert the result from UserCast.
15864 2001-10-05 Ravi Pratap <ravi@ximian.com>
15866 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
15867 prevented it from working correctly.
15869 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
15870 merely ConvertImplicit.
15872 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15874 * typemanager.cs: Make the LookupTypeContainer function static,
15875 and not per-instance.
15877 * class.cs: Make static FindMembers (the one that takes a Type
15880 * codegen.cs: Add EmitForeach here.
15882 * cs-parser.jay: Make foreach a toplevel object instead of the
15883 inline expansion, as we need to perform semantic analysis on it.
15885 2001-10-05 Ravi Pratap <ravi@ximian.com>
15887 * expression.cs (Expression::ImplicitUserConversion): Rename to
15888 UserDefinedConversion.
15890 (Expression::UserDefinedConversion): Take an extra argument specifying
15891 whether we look for explicit user conversions too.
15893 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
15895 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
15897 (ExplicitUserConversion): Make it a call to UserDefinedConversion
15898 with the appropriate arguments.
15900 * cs-parser.jay (cast_expression): Record location too.
15902 * expression.cs (Cast): Record location info.
15904 (Expression::ConvertExplicit): Take location argument.
15906 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
15907 to determine if we are doing explicit conversions.
15909 (UserCast::Emit): Update accordingly.
15911 (Expression::ConvertExplicit): Report an error if everything fails.
15913 * ../errors/cs0030.cs : Add.
15915 2001-10-04 Miguel de Icaza <miguel@ximian.com>
15917 * modifiers.cs: If the ABSTRACT keyword is present, also set the
15918 virtual and newslot bits.
15920 * class.cs (TypeContainer::RegisterRequiredImplementations):
15921 Record methods we need.
15923 (TypeContainer::MakeKey): Helper function to make keys for
15924 MethodBases, since the Methodbase key is useless.
15926 (TypeContainer::Populate): Call RegisterRequiredImplementations
15927 before defining the methods.
15929 Create a mapping for method_builders_to_methods ahead of time
15930 instead of inside a tight loop.
15932 (::RequireMethods): Accept an object as the data to set into the
15933 hashtable so we can report interface vs abstract method mismatch.
15935 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15937 * report.cs: Make all of it static.
15939 * rootcontext.cs: Drop object_type and value_type computations, as
15940 we have those in the TypeManager anyways.
15942 Drop report instance variable too, now it is a global.
15944 * driver.cs: Use try/catch on command line handling.
15946 Add --probe option to debug the error reporting system with a test
15949 * report.cs: Add support for exiting program when a probe
15950 condition is reached.
15952 2001-10-03 Ravi Pratap <ravi@ximian.com>
15954 * expression.cs (Binary::DoNumericPromotions): Fix the case when
15955 we do a forcible conversion regardless of type, to check if
15956 ForceConversion returns a null.
15958 (Binary::error19): Use location to report error.
15960 (Unary::error23): Use location here too.
15962 * ../errors/cs0019.cs : Check in.
15964 * ../errors/cs0023.cs : Check in.
15966 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
15967 case of a non-null MethodInfo object with a length of 0 !
15969 (Binary::ResolveOperator): Flag error if overload resolution fails to find
15970 an applicable member - according to the spec :-)
15971 Also fix logic to find members in base types.
15973 (Unary::ResolveOperator): Same here.
15975 (Unary::report23): Change name to error23 and make first argument a TypeContainer
15976 as I was getting thoroughly confused between this and error19 :-)
15978 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
15979 (::FindMostEncompassedType): Implement.
15980 (::FindMostEncompassingType): Implement.
15981 (::StandardConversionExists): Implement.
15983 (UserImplicitCast): Re-vamp. We now need info about most specific
15984 source and target types so that we can do the necessary conversions.
15986 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
15987 mathematical union with no duplicates.
15989 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15991 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
15992 in order from base classes to child classes, so that we can in
15993 child classes look up in our parent for method names and
15994 attributes (required for handling abstract, virtual, new, override
15995 constructs: we need to instrospect our base class, and if we dont
15996 populate the classes in order, the introspection might be
15997 incorrect. For example, a method could query its parent before
15998 the parent has any methods and would determine that the parent has
15999 no abstract methods (while it could have had them)).
16001 (RootContext::CreateType): Record the order in which we define the
16004 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16006 * class.cs (TypeContainer::Populate): Also method definitions can
16007 fail now, keep track of this.
16009 (TypeContainer::FindMembers): Implement support for
16010 DeclaredOnly/noDeclaredOnly flag.
16012 (Constructor::Emit) Return the ConstructorBuilder.
16014 (Method::Emit) Return the MethodBuilder.
16015 Check for abstract or virtual methods to be public.
16017 * rootcontext.cs (RootContext::CreateType): Register all the
16018 abstract methods required for the class to be complete and the
16019 interface methods that must be implemented.
16021 * cs-parser.jay: Report error 501 (method requires body if it is
16022 not marked abstract or extern).
16024 * expression.cs (TypeOf::Emit): Implement.
16026 * typemanager.cs: runtime_handle_type, new global type.
16028 * class.cs (Property::Emit): Generate code for properties.
16030 2001-10-02 Ravi Pratap <ravi@ximian.com>
16032 * expression.cs (Unary::ResolveOperator): Find operators on base type
16033 too - we now conform exactly to the spec.
16035 (Binary::ResolveOperator): Same here.
16037 * class.cs (Operator::Define): Fix minor quirk in the tests.
16039 * ../errors/cs0215.cs : Added.
16041 * ../errors/cs0556.cs : Added.
16043 * ../errors/cs0555.cs : Added.
16045 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16047 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16048 single integer which is really efficient
16050 2001-10-01 Ravi Pratap <ravi@ximian.com>
16052 * expression.cs (Expression::ImplicitUserConversion): Use location
16053 even in the case when we are examining True operators.
16055 * class.cs (Operator::Define): Perform extensive checks to conform
16056 with the rules for operator overloading in the spec.
16058 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16059 some of the other conversions mentioned in the spec.
16061 * typemanager.cs (array_type): New static member for the System.Array built-in
16064 (cloneable_interface): For System.ICloneable interface.
16066 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16067 we start resolving the tree and populating types.
16069 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16071 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16073 * expression.cs (Expression::ExprClassFromMemberInfo,
16074 Expression::Literalize): Create literal expressions from
16075 FieldInfos which are literals.
16077 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16078 type casts, because they were wrong. The test suite in tests
16081 (ImplicitNumericConversion): ushort to ulong requires a widening
16084 Int32 constant to long requires widening cast as well.
16086 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16087 for integers because the type on the stack is not i4.
16089 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16091 * expression.cs (report118): require location argument.
16093 * parameter.cs: Do not dereference potential null value.
16095 * class.cs: Catch methods that lack the `new' keyword when
16096 overriding a name. Report warnings when `new' is used without
16097 anything being there to override.
16099 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16101 * class.cs: Only add constructor to hashtable if it is non-null
16102 (as now constructors can fail on define).
16104 (TypeManager, Class, Struct): Take location arguments.
16106 Catch field instance initialization in structs as errors.
16108 accepting_filter: a new filter for FindMembers that is static so
16109 that we dont create an instance per invocation.
16111 (Constructor::Define): Catch errors where a struct constructor is
16114 * cs-parser.jay: Pass location information for various new
16117 * delegate.cs (Delegate): take a location argument.
16119 * driver.cs: Do not call EmitCode if there were problesm in the
16120 Definition of the types, as many Builders wont be there.
16122 * decl.cs (Decl::Decl): Require a location argument.
16124 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16125 into integers, and find the most appropiate integer for it.
16127 * literal.cs: Implement ULongLiteral.
16129 * rootcontext.cs: Provide better information about the location of
16130 failure when CreateType fails.
16132 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16134 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16137 * expression.cs (Binary::CheckShiftArguments): Add missing type
16139 (Binary::ResolveOperator): Add type to the logical and and logical
16140 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16143 (Binary::DoNumericPromotions): In the case where either argument
16144 is ulong (and most signed types combined with ulong cause an
16145 error) perform implicit integer constant conversions as well.
16147 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16149 * expression.cs (UserImplicitCast): Method should always be
16151 (Invocation::BetterConversion): Simplified test for IntLiteral.
16153 (Expression::ImplicitNumericConversion): Split this routine out.
16154 Put the code that performs implicit constant integer conversions
16157 (Expression::Resolve): Become a wrapper around DoResolve so we can
16158 check eclass and type being set after resolve.
16160 (Invocation::Badness): Remove this dead function
16162 (Binary::ResolveOperator): Do not compute the expensive argumnets
16163 unless we have a union for it.
16165 (Probe::Emit): Is needs to do an isinst and then
16166 compare against null.
16168 (::CanConvert): Added Location argument. If the Location argument
16169 is null (Location.Null), then we do not report errors. This is
16170 used by the `probe' mechanism of the Explicit conversion. We do
16171 not want to generate an error for something that the user
16172 explicitly requested to be casted. But the pipeline for an
16173 explicit cast first tests for potential implicit casts.
16175 So for now, if the Location is null, it means `Probe only' to
16176 avoid adding another argument. Might have to revise this
16179 (ClassCast): New class used to type cast objects into arbitrary
16180 classes (used in Explicit Reference Conversions).
16182 Implement `as' as well.
16184 Reverted all the patches from Ravi below: they were broken:
16186 * The use of `level' as a mechanism to stop recursive
16187 invocations is wrong. That was there just to catch the
16188 bug with a strack trace but not as a way of addressing
16191 To fix the problem we have to *understand* what is going
16192 on and the interactions and come up with a plan, not
16193 just get things going.
16195 * The use of the type conversion cache that I proposed
16196 last night had an open topic: How does this work across
16197 protection domains. A user defined conversion might not
16198 be public in the location where we are applying the
16199 conversion, a different conversion might be selected
16200 (ie, private A->B (better) but public B->A (worse),
16201 inside A, A->B applies, but outside it, B->A will
16204 * On top of that (ie, even if the above is solved),
16205 conversions in a cache need to be abstract. Ie, `To
16206 convert from an Int to a Short use an OpcodeCast', not
16207 `To convert from an Int to a Short use the OpcodeCast on
16208 the variable 5' (which is what this patch was doing).
16210 2001-09-28 Ravi Pratap <ravi@ximian.com>
16212 * expression.cs (Invocation::ConversionExists): Re-write to use
16213 the conversion cache
16215 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16216 cache all conversions done, not just user-defined ones.
16218 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16219 to determine if a conversion exists instead of acutually trying to
16220 perform the conversion. It's faster too.
16222 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16223 and only then attempt the implicit conversion.
16225 2001-09-28 Ravi Pratap <ravi@ximian.com>
16227 * expression.cs (ConvertImplicit): Use a cache for conversions
16228 already found. Check level of recursion and bail out if necessary.
16230 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16232 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16233 Export standard methods that we expect for string operations.
16235 * statement.cs (Block::UsageWarning): Track usage of variables and
16236 report the errors for not used variables.
16238 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16241 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16243 * codegen.cs: remove unnneded code
16245 * expression.cs: Removed BuiltinTypeAccess class
16247 Fix the order in which implicit conversions are
16250 The previous fixed dropped support for boxed conversions (adding a
16251 test to the test suite now)
16253 (UserImplicitCast::CanConvert): Remove test for source being null,
16254 that code is broken. We should not feed a null to begin with, if
16255 we do, then we should track the bug where the problem originates
16256 and not try to cover it up here.
16258 Return a resolved expression of type UserImplicitCast on success
16259 rather than true/false. Ravi: this is what I was talking about,
16260 the pattern is to use a static method as a "constructor" for
16263 Also, do not create arguments until the very last minute,
16264 otherwise we always create the arguments even for lookups that
16265 will never be performed.
16267 (UserImplicitCast::Resolve): Eliminate, objects of type
16268 UserImplicitCast are born in a fully resolved state.
16270 * typemanager.cs (InitCoreTypes): Init also value_type
16271 (System.ValueType).
16273 * expression.cs (Cast::Resolve): First resolve the child expression.
16275 (LValue): Add new method AddressOf to be used by
16278 Change the argument of Store to take an EmitContext instead of an
16279 ILGenerator, because things like FieldExpr need to be able to call
16280 their children expression to generate the instance code.
16282 (Expression::Error, Expression::Warning): Sugar functions for
16285 (Expression::MemberLookup): Accept a TypeContainer instead of a
16286 Report as the first argument.
16288 (Expression::ResolvePrimary): Killed. I still want to improve
16289 this as currently the code is just not right.
16291 (Expression::ResolveMemberAccess): Simplify, but it is still
16294 (Unary::Resolve): Catch errors in AddressOf operators.
16296 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16297 index to a byte for the short-version, or the compiler will choose
16298 the wrong Emit call, which generates the wrong data.
16300 (ParameterReference::Emit, ::Store): same.
16302 (FieldExpr::AddressOf): Implement.
16304 * typemanager.cs: TypeManager: made public variable instead of
16307 * driver.cs: document --fatal.
16309 * report.cs (ErrorMessage, WarningMessage): new names for the old
16310 Error and Warning classes.
16312 * cs-parser.jay (member_access): Turn built-in access to types
16313 into a normal simplename
16315 2001-09-27 Ravi Pratap <ravi@ximian.com>
16317 * expression.cs (Invocation::BetterConversion): Fix to cope
16318 with q being null, since this was introducing a bug.
16320 * expression.cs (ConvertImplicit): Do built-in conversions first.
16322 2001-09-27 Ravi Pratap <ravi@ximian.com>
16324 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16326 2001-09-27 Ravi Pratap <ravi@ximian.com>
16328 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16329 I had introduced long ago (what's new ?).
16331 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16332 the work of all the checking.
16333 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16334 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16336 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16337 that is the right way.
16339 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16340 overloading resolution. Use everywhere instead of cutting and pasting code.
16342 (Binary::ResolveOperator): Use MakeUnionSet.
16344 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16345 we have to convert to bool types. Not complete yet.
16347 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16349 * typemanager.cs (TypeManager::CSharpName): support ushort.
16351 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16352 to provide an expression that performsn an implicit constant int
16353 conversion (section 6.1.6).
16354 (Expression::ConvertImplicitRequired): Reworked to include
16355 implicit constant expression conversions.
16357 (Expression::ConvertNumericExplicit): Finished.
16359 (Invocation::Emit): If InstanceExpression is null, then it means
16360 that we perform a call on this.
16362 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16364 * expression.cs (Unary::Emit): Remove some dead code.
16365 (Probe): Implement Resolve and Emit for `is'.
16366 (Expression::ConvertImplicitRequired): Attempt to do constant
16367 expression conversions here. Maybe should be moved to
16368 ConvertImplicit, but I am not sure.
16369 (Expression::ImplicitLongConstantConversionPossible,
16370 Expression::ImplicitIntConstantConversionPossible): New functions
16371 that tell whether is it possible to apply an implicit constant
16372 expression conversion.
16374 (ConvertNumericExplicit): Started work on explicit numeric
16377 * cs-parser.jay: Update operator constants.
16379 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16380 (Parameters::GetSignature): Hook up VerifyArgs here.
16381 (Parameters::VerifyArgs): Verifies that no two arguments have the
16384 * class.cs (Operator): Update the operator names to reflect the
16385 ones that the spec expects (as we are just stringizing the
16388 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16389 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16390 previous usage did only work for our methods.
16391 (Expression::ConvertImplicit): Handle decimal implicit numeric
16392 conversions as well.
16393 (Expression::InternalTypeConstructor): Used to invoke constructors
16394 on internal types for default promotions.
16396 (Unary::Emit): Implement special handling for the pre/post
16397 increment/decrement for overloaded operators, as they need to have
16398 the same semantics as the other operators.
16400 (Binary::ResolveOperator): ditto.
16401 (Invocation::ConversionExists): ditto.
16402 (UserImplicitCast::Resolve): ditto.
16404 2001-09-26 Ravi Pratap <ravi@ximian.com>
16406 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16407 operator, return after emitting body. Regression tests pass again !
16409 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16410 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16411 (Invocation::OverloadResolve): Ditto.
16412 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16414 * everywhere : update calls to the above methods accordingly.
16416 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16418 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16420 * expression.cs (ExpressionStatement): New base class used for
16421 expressions that can appear in statements, so that we can provide
16422 an alternate path to generate expression that do not leave a value
16425 (Expression::Emit, and all the derivatives): We no longer return
16426 whether a value is left on the stack or not. Every expression
16427 after being emitted leaves a single value on the stack.
16429 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16430 facilties of ExpressionStatement if possible.
16432 * cs-parser.jay: Update statement_expression.
16434 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16436 * driver.cs: Change the wording of message
16438 2001-09-25 Ravi Pratap <ravi@ximian.com>
16440 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16441 the type of the expression to the return type of the method if
16442 we have an overloaded operator match ! The regression tests pass again !
16443 (Unary::ResolveOperator): Ditto.
16445 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16446 to find "op_Implicit", not "implicit" ;-)
16447 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16448 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16450 * everywhere : Correct calls to the above accordingly.
16452 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16453 (ConvertImplicit): Do user-defined conversion if it exists.
16455 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16457 * assign.cs: track location.
16458 (Resolve): Use implicit conversions on assignment.
16460 * literal.cs: Oops. Not good, Emit of short access values should
16461 pass (Bytes) or the wrong argument will be selected.
16463 * expression.cs (Unary::Emit): Emit code for -expr.
16465 (Unary::ResolveOperator): Handle `Substract' for non-constants
16466 (substract from zero from the non-constants).
16467 Deal with Doubles as well.
16469 (Expression::ConvertImplicitRequired): New routine that reports an
16470 error if no implicit conversion exists.
16472 (Invocation::OverloadResolve): Store the converted implicit
16473 expressions if we make them
16475 2001-09-24 Ravi Pratap <ravi@ximian.com>
16477 * class.cs (ConstructorInitializer): Take a Location argument.
16478 (ConstructorBaseInitializer): Same here.
16479 (ConstructorThisInitializer): Same here.
16481 * cs-parser.jay : Update all calls accordingly.
16483 * expression.cs (Unary, Binary, New): Take location argument.
16484 Update accordingly everywhere.
16486 * cs-parser.jay : Update all calls to the above to take a location
16489 * class.cs : Ditto.
16491 2001-09-24 Ravi Pratap <ravi@ximian.com>
16493 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16494 (Invocation::BetterConversion): Same here
16495 (Invocation::ConversionExists): Ditto.
16497 (Invocation::ConversionExists): Implement.
16499 2001-09-22 Ravi Pratap <ravi@ximian.com>
16501 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16502 Also take an additional TypeContainer argument.
16504 * All over : Pass in TypeContainer as argument to OverloadResolve.
16506 * typemanager.cs (CSharpName): Update to check for the string type and return
16509 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16512 2001-09-21 Ravi Pratap <ravi@ximian.com>
16514 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16515 (Invocation::BetterFunction): Implement.
16516 (Invocation::BetterConversion): Implement.
16517 (Invocation::ConversionExists): Skeleton, no implementation yet.
16519 Okay, things work fine !
16521 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16523 * typemanager.cs: declare and load enum_type, delegate_type and
16526 * expression.cs (Expression::Emit): Now emit returns a value that
16527 tells whether a value is left on the stack or not. This strategy
16528 might be reveted tomorrow with a mechanism that would address
16529 multiple assignments.
16530 (Expression::report118): Utility routine to report mismatches on
16533 (Unary::Report23): Report impossible type/operator combination
16536 (Unary::IsIncrementableNumber): Whether the type can be
16537 incremented or decremented with add.
16538 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16540 (Unary::ResolveOperator): Implement ++, !, ~,
16542 (Invocation::Emit): Deal with new Emit convetion.
16544 * All Expression derivatives: Updated their Emit method to return
16545 whether they leave values on the stack or not.
16547 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16548 stack for expressions that are statements.
16550 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16552 * expression.cs (LValue): New interface. Must be implemented by
16554 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16557 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16558 interface for generating code, simplifies the code.
16560 2001-09-20 Ravi Pratap <ravi@ximian.com>
16562 * expression.cs (everywhere): Comment out return statements in ::Resolve
16563 methods to avoid the warnings.
16565 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16567 * driver.cs (parse): Report error 2001 if we can not open the
16570 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16573 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16576 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16577 otherwise nested blocks end up with the same index.
16579 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16581 * expression.cs: Instead of having FIXMEs in the Resolve
16582 functions, throw exceptions so it is obvious that we are facing a
16585 * cs-parser.jay (invocation_expression): Pass Location information.
16587 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16588 Use a basename for those routines because .NET does not like paths
16591 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16594 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16596 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16597 are loading the correct data types (throws an exception if not).
16598 (TypeManager::InitCoreTypes): Use CoreLookupType
16600 * expression.cs (Unary::ResolveOperator): return the child
16601 expression for expressions which are just +expr.
16602 (Unary::ResolveOperator): Return negative literals for -LITERAL
16603 expressions (otherwise they are Unary {Literal}).
16604 (Invocation::Badness): Take into account `Implicit constant
16605 expression conversions'.
16607 * literal.cs (LongLiteral): Implement long literal class.
16608 (IntLiteral): export the `Value' of the intliteral.
16610 2001-09-19 Ravi Pratap <ravi@ximian.com>
16612 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16614 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16615 instead of 'Operator'
16617 * expression.cs (Binary::ResolveOperator): Update accordingly.
16618 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16621 * cs-parser.jay (unary_expression): Update to use the new names.
16623 * gen-treedump.cs (GetUnary): Same here.
16625 * expression.cs (Unary::Resolve): Implement.
16626 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16627 operators are found instead of making noise ;-)
16628 (Unary::ResolveOperator): New method to do precisely the same thing which
16629 Binary::ResolveOperator does for Binary expressions.
16630 (Unary.method, .Arguments): Add.
16631 (Unary::OperName): Implement.
16632 (Unary::ForceConversion): Copy and Paste !
16634 * class.cs (Operator::Define): Fix a small bug for the case when we have
16637 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16638 for the inbuilt operators. Only overloading works for now ;-)
16640 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16642 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16643 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16645 * expression.cs (This::Emit): Implement.
16646 (This::Resolve): Implement.
16647 (TypeOf:Resolve): Implement.
16648 (Expression::ResolveSimpleName): Add an implicit this to instance
16650 (MemberAccess::Resolve): Deal with Parameters and Fields.
16651 Bind instance variable to Field expressions.
16652 (FieldExpr::Instance): New field used to track the expression that
16653 represents the object instance.
16654 (FieldExpr::Resolve): Track potential errors from MemberLookup not
16656 (FieldExpr::Emit): Implement.
16658 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
16659 the last instruction contains a return opcode to avoid generating
16660 the last `ret' instruction (this generates correct code, and it is
16661 nice to pass the peverify output).
16663 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
16664 initializer for static and instance variables.
16665 (Constructor::Emit): Allow initializer to be null in the case of
16666 static constructors. Only emit initializer for instance
16669 (TypeContainer::FindMembers): Return a null array if there are no
16672 Also fix the code for the MemberTypes.Method branch, as it was not
16673 scanning that for operators (or tried to access null variables before).
16675 * assign.cs (Assign::Emit): Handle instance and static fields.
16679 * driver.cs: Stop compilation if there are parse errors.
16681 * cs-parser.jay (constructor_declaration): Provide default base
16682 initializer for non-static constructors.
16683 (constructor_declarator): Do not provide a default base
16684 initializers if none was specified.
16685 Catch the fact that constructors should not have parameters.
16687 * class.cs: Do not emit parent class initializers for static
16688 constructors, that should be flagged as an error.
16690 2001-09-18 Ravi Pratap <ravi@ximian.com>
16692 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
16693 Move back code into TypeContainer::Populate.
16695 2001-09-18 Ravi Pratap <ravi@ximian.com>
16697 * class.cs (TypeContainer::AddConstructor): Fix the check to
16698 compare against Name, not Basename.
16699 (Operator::OpType): Change Plus and Minus to Add and Subtract.
16701 * cs-parser.jay : Update accordingly.
16703 * class.cs (TypeContainer::FindMembers): For the case where we are searching
16704 for methods, don't forget to look into the operators too.
16705 (RegisterMethodBuilder): Helper method to take care of this for
16706 methods, constructors and operators.
16707 (Operator::Define): Completely revamp.
16708 (Operator.OperatorMethod, MethodName): New fields.
16709 (TypeContainer::Populate): Move the registering of builders into
16710 RegisterMethodBuilder.
16711 (Operator::Emit): Re-write.
16713 * expression.cs (Binary::Emit): Comment out code path to emit method
16714 invocation stuff for the case when we have a user defined operator. I am
16715 just not able to get it right !
16717 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16719 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
16722 (Expression::MemberLookup): Provide a version that allows to
16723 specify the MemberTypes and BindingFlags.
16725 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
16726 so it was not fetching variable information from outer blocks.
16728 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
16729 Beforefieldinit as it was buggy.
16731 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
16732 that Ravi put here.
16734 * class.cs (Constructor::Emit): Only emit if block is not null.
16735 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
16736 deal with this by semantically definining it as if the user had
16739 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
16740 constructors as we now "emit" them at a higher level.
16742 (TypeContainer::DefineDefaultConstructor): Used to define the
16743 default constructors if none was provided.
16745 (ConstructorInitializer): Add methods Resolve and Emit.
16747 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
16749 2001-09-17 Ravi Pratap <ravi@ximian.com>
16751 * class.cs (TypeContainer::EmitDefaultConstructor): Register
16752 the default constructor builder with our hashtable for methodbuilders
16755 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
16756 and argument_count is 0 in which case we have a match.
16757 (Binary::ResolveOperator): More null checking and miscellaneous coding
16760 2001-09-17 Ravi Pratap <ravi@ximian.com>
16762 * rootcontext.cs (IsNameSpace): Compare against null.
16764 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
16766 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
16767 and Unary::Operator.
16769 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
16772 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
16773 we have overloaded operators.
16774 (Binary::ResolveOperator): Implement the part which does the operator overload
16777 * class.cs (Operator::Emit): Implement.
16778 (TypeContainer::Emit): Emit the operators we have too.
16780 * expression.cs (Binary::Emit): Update to emit the appropriate code for
16781 the case when we have a user-defined operator.
16783 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16785 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
16787 2001-09-16 Ravi Pratap <ravi@ximian.com>
16789 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
16790 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
16791 (Constructor::Emit): Implement.
16792 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
16793 if we have no work to do.
16794 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
16797 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
16798 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
16800 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
16803 2001-09-15 Ravi Pratap <ravi@ximian.com>
16805 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
16807 (Tree::RecordNamespace): Method to do what the name says ;-)
16808 (Tree::Namespaces): Property to get at the namespaces hashtable.
16810 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
16813 * rootcontext.cs (IsNamespace): Fixed it :-)
16815 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16817 * class.cs (TypeContainer::FindMembers): Add support for
16819 (MethodCore): New class that encapsulates both the shared aspects
16820 of a Constructor and a Method.
16821 (Method, Constructor): Factored pieces into MethodCore.
16823 * driver.cs: Added --fatal which makes errors throw exceptions.
16824 Load System assembly as well as part of the standard library.
16826 * report.cs: Allow throwing exceptions on errors for debugging.
16828 * modifiers.cs: Do not use `parent', instead use the real type
16829 container to evaluate permission settings.
16831 * class.cs: Put Ravi's patch back in. He is right, and we will
16832 have to cope with the
16834 2001-09-14 Ravi Pratap <ravi@ximian.com>
16836 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
16837 FamORAssem, not FamANDAssem.
16839 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16841 * driver.cs: Added --parse option that only parses its input files
16844 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
16845 incorrect. IsTopLevel is not used to tell whether an object is
16846 root_types or not (that can be achieved by testing this ==
16847 root_types). But to see if this is a top-level *class* (not
16848 necessarly our "toplevel" container).
16850 2001-09-14 Ravi Pratap <ravi@ximian.com>
16852 * enum.cs (Enum::Define): Modify to call the Lookup method on the
16853 parent instead of a direct call to GetType.
16855 2001-09-14 Ravi Pratap <ravi@ximian.com>
16857 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
16858 Modifiers.TypeAttr. This should just be a call to that method.
16860 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
16861 object so that we can determine if we are top-level or not.
16863 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
16866 * enum.cs (Enum::Define): Ditto.
16868 * modifiers.cs (FieldAttr): Re-write.
16870 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
16871 (TypeContainer::HaveStaticConstructor): New property to provide access
16872 to precisely that info.
16874 * modifiers.cs (MethodAttr): Re-write.
16875 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
16877 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
16878 of top-level types as claimed.
16880 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16882 * expression.cs (MemberLookup): Fruitless attempt to lookup
16883 constructors. Maybe I need to emit default constructors? That
16884 might be it (currently .NET emits this for me automatically).
16885 (Invocation::OverloadResolve): Cope with Arguments == null.
16886 (Invocation::EmitArguments): new function, shared by the new
16887 constructor and us.
16888 (Invocation::Emit): Handle static and instance methods. Emit
16889 proper call instruction for virtual or non-virtual invocations.
16890 (New::Emit): Implement.
16891 (New::Resolve): Implement.
16892 (MemberAccess:Resolve): Implement.
16893 (MethodGroupExpr::InstanceExpression): used conforming to the spec
16894 to track instances.
16895 (FieldExpr::Resolve): Set type.
16897 * support.cs: Handle empty arguments.
16899 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
16900 SimpleLookup): Auxiliary routines to help parse a qualifier
16903 Update qualifier_identifier rule.
16905 * codegen.cs: Removed debugging messages.
16907 * class.cs: Make this a global thing, this acts just as a "key" to
16908 objects that we might have around.
16910 (Populate): Only initialize method_builders_to_methods once.
16912 * expression.cs (PropertyExpr): Initialize type from the
16915 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
16916 Resolve pattern. Attempt to implicitly convert value to boolean.
16919 * expression.cs: Set the type for the int32/int32 argument case.
16920 (Binary::ResolveOperator): Set the return type to boolean for
16921 comparission operators
16923 * typemanager.cs: Remove debugging print code.
16925 (Invocation::Resolve): resolve type.
16927 * class.cs: Allocate a MemberInfo of the correct size, as the code
16928 elsewhere depends on the test to reflect the correct contents.
16930 (Method::) Keep track of parameters, due to System.Reflection holes
16932 (TypeContainer::Populate): Keep track of MethodBuilders to Method
16935 (TypeContainer::FindMembers): Use ArrayList and then copy an array
16936 of the exact size and return that.
16938 (Class::LookupMethodByBuilder): New function that maps
16939 MethodBuilders to its methods. Required to locate the information
16940 on methods because System.Reflection bit us again.
16942 * support.cs: New file, contains an interface ParameterData and
16943 two implementations: ReflectionParameters and InternalParameters
16944 used to access Parameter information. We will need to grow this
16947 * expression.cs (Invocation::GetParameterData): implement a cache
16948 and a wrapper around the ParameterData creation for methods.
16949 (Invocation::OverloadResolve): Use new code.
16951 2001-09-13 Ravi Pratap <ravi@ximian.com>
16953 * class.cs (TypeContainer::EmitField): Remove and move into
16954 (Field::Define): here and modify accordingly.
16955 (Field.FieldBuilder): New member.
16956 (TypeContainer::Populate): Update accordingly.
16957 (TypeContainer::FindMembers): Implement.
16959 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16961 * statement.cs: (VariableInfo::VariableType): New field to be
16962 initialized with the full type once it is resolved.
16964 2001-09-12 Miguel de Icaza <miguel@ximian.com>
16966 * parameter.cs (GetParameterInfo): Use a type cache to compute
16967 things only once, and to reuse this information
16969 * expression.cs (LocalVariableReference::Emit): Implement.
16970 (OpcodeCast::Emit): fix.
16972 (ParameterReference::Resolve): Implement.
16973 (ParameterReference::Emit): Implement.
16975 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
16976 that are expressions need to stay as Expressions.
16978 * typemanager.cs (CSharpName): Returns the C# name of a type if
16981 * expression.cs (Expression::ConvertImplicit): New function that
16982 implements implicit type conversions.
16984 (Expression::ImplicitReferenceConversion): Implements implicit
16985 reference conversions.
16987 (EmptyCast): New type for transparent casts.
16989 (OpcodeCast): New type for casts of types that are performed with
16990 a sequence of bytecodes.
16992 (BoxedCast): New type used for casting value types into reference
16993 types. Emits a box opcode.
16995 (Binary::DoNumericPromotions): Implements numeric promotions of
16996 and computation of the Binary::Type.
16998 (Binary::EmitBranchable): Optimization.
17000 (Binary::Emit): Implement code emission for expressions.
17002 * typemanager.cs (TypeManager): Added two new core types: sbyte
17005 2001-09-12 Ravi Pratap <ravi@ximian.com>
17007 * class.cs (TypeContainer::FindMembers): Method which does exactly
17008 what Type.FindMembers does, only we don't have to use reflection. No
17009 implementation yet.
17011 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17012 typecontainer objects as we need to get at them.
17013 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17015 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17016 typecontainer object.
17018 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17019 of just a Report object.
17021 2001-09-11 Ravi Pratap <ravi@ximian.com>
17023 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17025 (TypeContainer::Populate): Now define the delegates of the type too.
17026 (TypeContainer.Delegates): Property to access the list of delegates defined
17029 * delegates.cs (Delegate::Define): Implement partially.
17031 * modifiers.cs (TypeAttr): Handle more flags.
17033 2001-09-11 Ravi Pratap <ravi@ximian.com>
17035 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17037 (Operator::Define): Re-write logic to get types by using the LookupType method
17038 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17039 (Indexer::Define): Ditto.
17040 (Event::Define): Ditto.
17041 (Property::Define): Ditto.
17043 2001-09-10 Ravi Pratap <ravi@ximian.com>
17045 * class.cs (TypeContainer::Populate): Now define operators too.
17046 (TypeContainer.Operators): New property to access the list of operators
17048 (Operator.OperatorMethodBuilder): New member to hold the method builder
17049 for the operator we are defining.
17050 (Operator::Define): Implement.
17052 2001-09-10 Ravi Pratap <ravi@ximian.com>
17054 * class.cs (Event::Define): Make the prefixes of the accessor methods
17055 addOn_ and removeOn_
17057 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17058 of the location being passed in too. Ideally, this should go later since all
17059 error reporting should be done through the Report object.
17061 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17062 (Populate): Iterate thru the indexers we have and define them too.
17063 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17064 for the get and set accessors.
17065 (Indexer::Define): Implement.
17067 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17069 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17070 my previous implementation, did not work.
17072 * typemanager.cs: Add a couple of missing types (the longs).
17074 * literal.cs: Use TypeManager.bool_type instead of getting it.
17076 * expression.cs (EventExpr): New kind of expressions.
17077 (Expressio::ExprClassFromMemberInfo): finish
17079 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17081 * assign.cs: Emit stores to static fields differently.
17083 2001-09-08 Ravi Pratap <ravi@ximian.com>
17085 * Merge in changes and adjust code to tackle conflicts. Backed out my
17086 code in Assign::Resolve ;-)
17088 2001-09-08 Ravi Pratap <ravi@ximian.com>
17090 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17091 instead Report.Error and also pass in the location.
17092 (CSharpParser::Lexer): New readonly property to return the reference
17093 to the Tokenizer object.
17094 (declare_local_variables): Use Report.Error with location instead of plain
17098 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17099 (Operator.CheckBinaryOperator): Ditto.
17101 * cs-parser.jay (operator_declarator): Update accordingly.
17103 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17104 (CheckBinaryOperator): Same here.
17106 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17107 on the name without any prefixes of namespace names etc. This is because we
17108 already might have something already fully qualified like
17109 'System.Console.WriteLine'
17111 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17113 2001-09-07 Ravi Pratap <ravi@ximian.com>
17115 * cs-tokenizer.cs (location): Return a string which also contains
17118 * expression.cs (ElementAccess): New class for expressions of the
17119 type 'element access.'
17120 (BaseAccess): New class for expressions of the type 'base access.'
17121 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17124 * cs-parser.jay (element_access): Implement action.
17125 (base_access): Implement actions.
17126 (checked_expression, unchecked_expression): Implement.
17128 * cs-parser.jay (local_variable_type): Correct and implement.
17129 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17131 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17133 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17134 name and the specifiers.
17136 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17138 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17139 making them all public ;-)
17141 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17144 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17146 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17148 (FieldExpr, PropertyExprs): New resolved expressions.
17149 (SimpleName::MemberStaticCheck): Perform static checks for access
17150 to non-static fields on static methods. Maybe this should be
17151 generalized for MemberAccesses.
17152 (SimpleName::ResolveSimpleName): More work on simple name
17155 * cs-parser.jay (primary_expression/qualified_identifier): track
17156 the parameter index.
17158 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17159 (EmitContext::EmitBoolExpression): Chain to expression generation
17160 instead of temporary hack.
17161 (::EmitStatementExpression): Put generic expression code generation.
17163 * assign.cs (Assign::Emit): Implement variable assignments to
17164 local variables, parameters and fields.
17166 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17168 * statement.cs (Block::GetVariableInfo): New method, returns the
17169 VariableInfo for a variable name in a block.
17170 (Block::GetVariableType): Implement in terms of GetVariableInfo
17172 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17173 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17175 2001-09-06 Ravi Pratap <ravi@ximian.com>
17177 * cs-parser.jay (operator_declaration): Continue on my quest : update
17178 to take attributes argument.
17179 (event_declaration): Ditto.
17180 (enum_declaration): Ditto.
17181 (indexer_declaration): Ditto.
17183 * class.cs (Operator::Operator): Update constructor accordingly.
17184 (Event::Event): Ditto.
17186 * delegate.cs (Delegate::Delegate): Same here.
17188 * enum.cs (Enum::Enum): Same here.
17190 2001-09-05 Ravi Pratap <ravi@ximian.com>
17192 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17194 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17196 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17197 being passed around as an arraylist.
17198 (Attributes::AddAttribute): Method to add attribute sections.
17200 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17201 (struct_declaration): Update accordingly.
17202 (constant_declaration): Update.
17203 (field_declaration): Update.
17204 (method_header): Update.
17205 (fixed_parameter): Update.
17206 (parameter_array): Ditto.
17207 (property_declaration): Ditto.
17208 (destructor_declaration): Ditto.
17210 * class.cs (Struct::Struct): Update constructors accordingly.
17211 (Class::Class): Ditto.
17212 (Field::Field): Ditto.
17213 (Method::Method): Ditto.
17214 (Property::Property): Ditto.
17215 (TypeContainer::OptAttribute): update property's return type.
17217 * interface.cs (Interface.opt_attributes): New member.
17218 (Interface::Interface): Update to take the extra Attributes argument.
17220 * parameter.cs (Parameter::Parameter): Ditto.
17222 * constant.cs (Constant::Constant): Ditto.
17224 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17225 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17226 the attributes as a parameter.
17227 (InterfaceProperty): Update constructor call.
17228 (InterfaceEvent): Ditto.
17229 (InterfaceMethod): Ditto.
17230 (InterfaceIndexer): Ditto.
17232 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17233 pass the attributes too.
17234 (interface_event_declaration): Ditto.
17235 (interface_property_declaration): Ditto.
17236 (interface_method_declaration): Ditto.
17237 (interface_declaration): Ditto.
17239 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17241 * class.cs (Method::Define): Track the "static Main" definition to
17242 create an entry point.
17244 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17245 EntryPoint if we find it.
17247 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17248 (EmitContext::ig): Make this variable public.
17250 * driver.cs: Make the default output file be the first file name
17251 with the .exe extension.
17253 Detect empty compilations
17255 Handle various kinds of output targets. Handle --target and
17256 rename -t to --dumper.
17258 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17259 methods inherited from Expression return now an Expression. This
17260 will is used during the tree rewriting as we resolve them during
17263 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17264 the spec. Missing entirely is the information about
17265 accessability of elements of it.
17267 (Expression::ExprClassFromMemberInfo): New constructor for
17268 Expressions that creates a fully initialized Expression based on
17269 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17272 (Invocation::Resolve): Begin implementing resolution of invocations.
17274 * literal.cs (StringLiteral): Implement Emit.
17276 2001-09-05 Ravi Pratap <ravi@ximian.com>
17278 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17281 2001-09-04 Ravi Pratap <ravi@ximian.com>
17283 * cs-parser.jay (attribute_arguments): Implement actions.
17284 (attribute): Fix bug in production. Implement action.
17285 (attribute_list): Implement.
17286 (attribute_target): Implement.
17287 (attribute_target_specifier, opt_target_specifier): Implement
17288 (CheckAttributeTarget): New method to check if the attribute target
17290 (attribute_section): Implement.
17291 (opt_attributes): Implement.
17293 * attribute.cs : New file to handle attributes.
17294 (Attribute): Class to hold attribute info.
17296 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17297 (attribute_section): Modify production to use 2 different rules to
17298 achieve the same thing. 1 s/r conflict down !
17299 Clean out commented, useless, non-reducing dimension_separator rules.
17301 * class.cs (TypeContainer.attributes): New member to hold list
17302 of attributes for a type.
17303 (Struct::Struct): Modify to take one more argument, the attribute list.
17304 (Class::Class): Ditto.
17305 (Field::Field): Ditto.
17306 (Method::Method): Ditto.
17307 (Property::Property): Ditto.
17309 * cs-parser.jay (struct_declaration): Update constructor call to
17310 pass in the attributes too.
17311 (class_declaration): Ditto.
17312 (constant_declaration): Ditto.
17313 (field_declaration): Ditto.
17314 (method_header): Ditto.
17315 (fixed_parameter): Ditto.
17316 (parameter_array): Ditto.
17317 (property_declaration): Ditto.
17319 * constant.cs (Constant::Constant): Update constructor similarly.
17320 Use System.Collections.
17322 * parameter.cs (Parameter::Parameter): Update as above.
17324 2001-09-02 Ravi Pratap <ravi@ximian.com>
17326 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17327 (TypeContainer.delegates): New member to hold list of delegates.
17329 * cs-parser.jay (delegate_declaration): Implement the action correctly
17330 this time as I seem to be on crack ;-)
17332 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17334 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17335 tell whether an identifier represents a namespace.
17337 * expression.cs (NamespaceExpr): A namespace expression, used only
17338 temporarly during expression resolution.
17339 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17340 utility functions to resolve names on expressions.
17342 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17344 * codegen.cs: Add hook for StatementExpressions.
17346 * class.cs: Fix inverted test for static flag in methods.
17348 2001-09-02 Ravi Pratap <ravi@ximian.com>
17350 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17351 to make it coincide with MS' number.
17352 (Operator::CheckBinaryOperator): Ditto.
17354 * ../errors/errors.txt : Remove error numbers added earlier.
17356 * ../errors/cs1019.cs : Test case for error # 1019
17358 * ../errros/cs1020.cs : Test case for error # 1020
17360 * cs-parser.jay : Clean out commented cruft.
17361 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17362 used anywhere - non-reducing rule.
17363 (namespace_declarations): Non-reducing rule - comment out.
17365 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17366 with TypeContainer::AddEnum.
17368 * delegate.cs : New file for delegate handling classes.
17369 (Delegate): Class for declaring delegates.
17371 * makefile : Update.
17373 * cs-parser.jay (delegate_declaration): Implement.
17375 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17377 * class.cs (Event::Define): Implement.
17378 (Event.EventBuilder): New member.
17380 * class.cs (TypeContainer::Populate): Update to define all enums and events
17382 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17383 readonly fields for all these cases ?
17385 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17387 * class.cs (Property): Revamp to use the convention of making fields readonly.
17388 Accordingly modify code elsewhere.
17390 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17391 the Define method of the Property class.
17393 * class.cs : Clean up applied patch and update references to variables etc. Fix
17395 (TypeContainer::Populate): Update to define all the properties we have. Also
17396 define all enumerations.
17398 * enum.cs (Define): Implement.
17400 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17402 * cs-parser.jay (overloadable_operator): The semantic value is an
17403 enum of the Operator class.
17404 (operator_declarator): Implement actions.
17405 (operator_declaration): Implement.
17407 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17408 validity of definitions.
17409 (Operator::CheckBinaryOperator): Static method to check for binary operators
17410 (TypeContainer::AddOperator): New method to add an operator to a type.
17412 * cs-parser.jay (indexer_declaration): Added line to actually call the
17413 AddIndexer method so it gets added ;-)
17415 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17416 already taken care of by the MS compiler ?
17418 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17420 * class.cs (Operator): New class for operator declarations.
17421 (Operator::OpType): Enum for the various operators.
17423 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17425 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17426 ostensibly handle this in semantic analysis.
17428 * cs-parser.jay (general_catch_clause): Comment out
17429 (specific_catch_clauses, specific_catch_clause): Ditto.
17430 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17431 (catch_args, opt_catch_args): New productions.
17432 (catch_clause): Rewrite to use the new productions above
17433 (catch_clauses): Modify accordingly.
17434 (opt_catch_clauses): New production to use in try_statement
17435 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17436 and re-write the code in the actions to extract the specific and
17437 general catch clauses by being a little smart ;-)
17439 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17440 Hooray, try and catch statements parse fine !
17442 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17444 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17445 string from the hashtable of variables.
17447 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17448 I end up making that mistake ;-)
17449 (catch_clauses): Fixed gross error which made Key and Value of the
17450 DictionaryEntry the same : $1 !!
17452 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17454 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17456 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17457 when the add and remove accessors are specified.
17459 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17461 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17462 information about indexer_declarator.
17463 (indexer_declarator): Implement actions.
17464 (parsing_indexer): New local boolean used to keep track of whether
17465 we are parsing indexers or properties. This is necessary because
17466 implicit_parameters come into picture even for the get accessor in the
17467 case of an indexer.
17468 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17470 * class.cs (Indexer): New class for indexer declarations.
17471 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17472 (TypeContainer::indexers): New member to hold list of indexers for the
17475 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17477 * cs-parser.jay (add_accessor_declaration): Implement action.
17478 (remove_accessor_declaration): Implement action.
17479 (event_accessors_declaration): Implement
17480 (variable_declarators): swap statements for first rule - trivial.
17482 * class.cs (Event): New class to hold information about event
17484 (TypeContainer::AddEvent): New method to add an event to a type
17485 (TypeContainer::events): New member to hold list of events.
17487 * cs-parser.jay (event_declaration): Implement actions.
17489 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17491 * cs-parser.jay (dim_separators): Implement. Make it a string
17492 concatenating all the commas together, just as they appear.
17493 (opt_dim_separators): Modify accordingly
17494 (rank_specifiers): Update accordingly. Basically do the same
17495 thing - instead, collect the brackets here.
17496 (opt_rank_sepcifiers): Modify accordingly.
17497 (array_type): Modify to actually return the complete type string
17498 instead of ignoring the rank_specifiers.
17499 (expression_list): Implement to collect the expressions
17500 (variable_initializer): Implement. We make it a list of expressions
17501 essentially so that we can handle the array_initializer case neatly too.
17502 (variable_initializer_list): Implement.
17503 (array_initializer): Make it a list of variable_initializers
17504 (opt_array_initializer): Modify accordingly.
17506 * expression.cs (New::NType): Add enumeration to help us
17507 keep track of whether we have an object/delegate creation
17508 or an array creation.
17509 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17510 members to hold data about array creation.
17511 (New:New): Modify to update NewType
17512 (New:New): New Overloaded contructor for the array creation
17515 * cs-parser.jay (array_creation_expression): Implement to call
17516 the overloaded New constructor.
17518 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17520 * class.cs (TypeContainer::Constructors): Return member
17521 constructors instead of returning null.
17523 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17525 * typemanager.cs (InitCoreTypes): Initialize the various core
17526 types after we have populated the type manager with the user
17527 defined types (this distinction will be important later while
17528 compiling corlib.dll)
17530 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17531 on Expression Classification. Now all expressions have a method
17532 `Resolve' and a method `Emit'.
17534 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17535 generation from working. Also add some temporary debugging
17538 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17540 * codegen.cs: Lots of code generation pieces. This is only the
17541 beginning, will continue tomorrow with more touches of polish. We
17542 handle the fundamentals of if, while, do, for, return. Others are
17543 trickier and I need to start working on invocations soon.
17545 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17548 * codegen.cs (EmitContext): New struct, used during code
17549 emission to keep a context. Most of the code generation will be
17552 * cs-parser.jay: Add embedded blocks to the list of statements of
17553 this block. So code generation proceeds in a top down fashion.
17555 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17557 * statement.cs: Add support for multiple child blocks.
17559 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17561 * codegen.cs (EmitCode): New function, will emit the code for a
17562 Block of code given a TypeContainer and its ILGenerator.
17564 * statement.cs (Block): Standard public readonly optimization.
17565 (Block::Block constructors): Link children.
17566 (Block::Child): Child Linker.
17567 (Block::EmitVariables): Emits IL variable declarations.
17569 * class.cs: Drop support for MethodGroups here, delay until
17571 (Method::): Applied the same simplification that I did before, and
17572 move from Properties to public readonly fields.
17573 (Method::ParameterTypes): Returns the parameter types for the
17574 function, and implements a cache that will be useful later when I
17575 do error checking and the semantic analysis on the methods is
17577 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17578 and made a method, optional argument tells whether this is a class
17579 or a structure to apply the `has-this' bit.
17580 (Method::GetCallingConvention): Implement, returns the calling
17582 (Method::Define): Defines the type, a second pass is performed
17583 later to populate the methods.
17585 (Constructor::ParameterTypes): implement a cache similar to the
17586 one on Method::ParameterTypes, useful later when we do semantic
17589 (TypeContainer::EmitMethod): New method. Emits methods.
17591 * expression.cs: Removed MethodGroup class from here.
17593 * parameter.cs (Parameters::GetCallingConvention): new method.
17595 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17597 * class.cs (TypeContainer::Populate): Drop RootContext from the
17600 (Constructor::CallingConvention): Returns the calling convention.
17601 (Constructor::ParameterTypes): Returns the constructor parameter
17604 (TypeContainer::AddConstructor): Keep track of default constructor
17605 and the default static constructor.
17607 (Constructor::) Another class that starts using `public readonly'
17608 instead of properties.
17610 (Constructor::IsDefault): Whether this is a default constructor.
17612 (Field::) use readonly public fields instead of properties also.
17614 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17615 track of static constructors; If none is used, turn on
17616 BeforeFieldInit in the TypeAttributes.
17618 * cs-parser.jay (opt_argument_list): now the return can be null
17619 for the cases where there are no arguments.
17621 (constructor_declarator): If there is no implicit `base' or
17622 `this', then invoke the default parent constructor.
17624 * modifiers.cs (MethodAttr): New static function maps a set of
17625 modifiers flags into a MethodAttributes enum
17626 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17627 MethodAttr, TypeAttr to represent the various mappings where the
17628 modifiers are used.
17629 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17631 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17633 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17636 * interface.cs (PopulateIndexer): Implemented the code generator
17637 for interface indexers.
17639 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17641 * interface.cs (InterfaceMemberBase): Now we track the new status
17644 (PopulateProperty): Implement property population. Woohoo! Got
17645 Methods and Properties going today.
17647 Removed all the properties for interfaces, and replaced them with
17648 `public readonly' fields.
17650 2001-08-16 Miguel de Icaza <miguel@ximian.com>
17652 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
17653 initialize their hashtables/arraylists only when they are needed
17654 instead of doing this always.
17656 * parameter.cs: Handle refs and out parameters.
17658 * cs-parser.jay: Use an ArrayList to construct the arguments
17659 instead of the ParameterCollection, and then cast that to a
17662 * parameter.cs: Drop the use of ParameterCollection and use
17663 instead arrays of Parameters.
17665 (GetParameterInfo): Use the Type, not the Name when resolving
17668 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17670 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17671 and instead use public readonly fields.
17673 * class.cs: Put back walking code for type containers.
17675 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17677 * class.cs (MakeConstant): Code to define constants.
17679 * rootcontext.cs (LookupType): New function. Used to locate types
17682 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17684 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17685 this System.Reflection code is. Kudos to Microsoft
17687 * typemanager.cs: Implement a type cache and avoid loading all
17688 types at boot time. Wrap in LookupType the internals. This made
17689 the compiler so much faster. Wow. I rule!
17691 * driver.cs: Make sure we always load mscorlib first (for
17692 debugging purposes, nothing really important).
17694 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
17695 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
17697 * rootcontext.cs: Lookup types on their namespace; Lookup types
17698 on namespaces that have been imported using the `using' keyword.
17700 * class.cs (TypeContainer::TypeAttr): Virtualize.
17701 (Class::TypeAttr): Return attributes suitable for this bad boy.
17702 (Struct::TypeAttr): ditto.
17703 Handle nested classes.
17704 (TypeContainer::) Remove all the type visiting code, it is now
17705 replaced with the rootcontext.cs code
17707 * rootcontext.cs (GetClassBases): Added support for structs.
17709 2001-08-06 Miguel de Icaza <miguel@ximian.com>
17711 * interface.cs, statement.cs, class.cs, parameter.cs,
17712 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
17713 Drop use of TypeRefs, and use strings instead.
17715 2001-08-04 Miguel de Icaza <miguel@ximian.com>
17719 * class.cs (Struct::Struct): set the SEALED flags after
17720 checking the modifiers.
17721 (TypeContainer::TypeAttr): new property, returns the
17722 TypeAttributes for a class.
17724 * cs-parser.jay (type_list): Oops, list production was creating a
17725 new list of base types.
17727 * rootcontext.cs (StdLib): New property.
17728 (GetInterfaceTypeByName): returns an interface by type name, and
17729 encapsulates error handling here.
17730 (GetInterfaces): simplified.
17731 (ResolveTree): Encapsulated all the tree resolution here.
17732 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
17735 * driver.cs: Add support for --nostdlib, to avoid loading the
17736 default assemblies.
17737 (Main): Do not put tree resolution here.
17739 * rootcontext.cs: Beginning of the class resolution.
17741 2001-08-03 Miguel de Icaza <miguel@ximian.com>
17743 * rootcontext.cs: Provide better error reporting.
17745 * cs-parser.jay (interface_base): set our $$ to be interfaces.
17747 * rootcontext.cs (CreateInterface): Handle the case where there
17748 are no parent interfaces.
17750 (CloseTypes): Routine to flush types at the end.
17751 (CreateInterface): Track types.
17752 (GetInterfaces): Returns an array of Types from the list of
17753 defined interfaces.
17755 * typemanager.c (AddUserType): Mechanism to track user types (puts
17756 the type on the global type hash, and allows us to close it at the
17759 2001-08-02 Miguel de Icaza <miguel@ximian.com>
17761 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
17762 RecordInterface instead.
17764 * cs-parser.jay: Updated to reflect changes above.
17766 * decl.cs (Definition): Keep track of the TypeBuilder type that
17767 represents this type here. Not sure we will use it in the long
17768 run, but wont hurt for now.
17770 * driver.cs: Smaller changes to accomodate the new code.
17772 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
17775 * rootcontext.cs (CreateInterface): New method, used to create
17776 the System.TypeBuilder type for interfaces.
17777 (ResolveInterfaces): new entry point to resolve the interface
17779 (CodeGen): Property, used to keep track of the code generator.
17781 2001-07-26 Miguel de Icaza <miguel@ximian.com>
17783 * cs-parser.jay: Add a second production for delegate_declaration
17786 (enum_body): Put an opt_comma here instead of putting it on
17787 enum_body or enum_member_declarations so we can handle trailing
17788 commas on enumeration members. Gets rid of a shift/reduce.
17790 (type_list): Need a COMMA in the middle.
17792 (indexer_declaration): Tell tokenizer to recognize get/set
17794 * Remove old targets.
17796 * Re-add the parser target.
17798 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17800 * cs-parser.jay: Add precendence rules for a number of operators
17801 ot reduce the number of shift/reduce conflicts in the grammar.
17803 2001-07-17 Miguel de Icaza <miguel@ximian.com>
17805 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
17808 Get rid of old crufty code.
17810 * rootcontext.cs: Use this to keep track of the parsed
17811 representation and the defined types available to the program.
17813 * gen-treedump.cs: adjust for new convention.
17815 * type.cs: Split out the type manager, and the assembly builder
17818 * typemanager.cs: the type manager will live here now.
17820 * cil-codegen.cs: And the code generator here.
17822 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
17824 * makefile: Fixed up for easy making.
17826 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17828 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
17831 (unary_expression): Expand pre_increment_expression and
17832 post_decrement_expression to reduce a shift/reduce.
17834 2001-07-11 Simon Cozens
17836 * cs-tokenizer.cs: Hex numbers should begin with a 0.
17838 Improve allow_keyword_as_indent name.
17840 2001-06-19 Miguel de Icaza <miguel@ximian.com>
17842 * Adjustments for Beta2.
17844 2001-06-13 Miguel de Icaza <miguel@ximian.com>
17846 * decl.cs: Added `Define' abstract method.
17847 (InTransit): new property, used to catch recursive definitions.
17849 * interface.cs: Implement `Define'.
17851 * modifiers.cs: Map Modifiers.constants to
17852 System.Reflection.TypeAttribute flags.
17854 * class.cs: Keep track of types and user-defined types.
17855 (BuilderInit): New method for creating an assembly
17856 (ResolveType): New function to launch the resolution process, only
17857 used by interfaces for now.
17859 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
17860 that are inserted into the name space.
17862 2001-06-08 Miguel de Icaza <miguel@ximian.com>
17864 * ARGH. I have screwed up my tree so many times due to the use of
17865 rsync rather than using CVS. Going to fix this at once.
17867 * driver.cs: Objetify driver. Load assemblies, use assemblies to
17870 2001-06-07 Miguel de Icaza <miguel@ximian.com>
17872 * Experiment successful: Use System.Type rather that our own
17875 2001-05-25 Miguel de Icaza <miguel@ximian.com>
17877 * cs-parser.jay: Removed nsAliases from here.
17879 Use new namespaces, handle `using XXX;'
17881 * namespace.cs: Reimplemented namespace handling, use a recursive
17882 definition of the class. Now we can keep track of using clauses
17883 and catch invalid using clauses.
17885 2001-05-24 Miguel de Icaza <miguel@ximian.com>
17887 * gen-treedump.cs: Adapted for all the renaming.
17889 * expression.cs (Expression): this class now has a Type property
17890 which returns an expression Type.
17892 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
17893 `Type', as this has a different meaning now in the base
17895 2001-05-22 Miguel de Icaza <miguel@ximian.com>
17897 * interface.cs, class.cs: Removed from all the sources the
17898 references to signature computation, as we can not do method
17899 signature computation during the parsing time, as we are not
17900 trying to solve at that point distinguishing:
17904 void a (NS.Blah x) {}
17907 Which depending on the context might be valid or not, as we do not
17908 know if Blah is the same thing as NS.Blah at that point.
17910 * Redid everything so the code uses TypeRefs now instead of
17911 Types. TypeRefs are just temporary type placeholders, that need
17912 to be resolved. They initially have a pointer to a string and the
17913 current scope in which they are used. This is used later by the
17914 compiler to resolve the reference to an actual Type.
17916 * DeclSpace is no longer a CIR.Type, and neither are
17917 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
17918 are all DeclSpaces, but no Types.
17920 * type.cs (TypeRefManager): This implements the TypeRef manager,
17921 which keeps track of all the types that need to be resolved after
17922 the parsing has finished.
17924 2001-05-13 Miguel de Icaza <miguel@ximian.com>
17926 * ARGH. We are going to have to store `foreach' as a class rather
17927 than resolving it, as we need to verify error 1579 after name
17928 resolution. *OR* we could keep a flag that says `This request to
17929 IEnumerator comes from a foreach statement' which we can then use
17930 to generate the error.
17932 2001-05-10 Miguel de Icaza <miguel@ximian.com>
17934 * class.cs (TypeContainer.AddMethod): we now add methods to the
17935 MethodGroup instead of the method hashtable.
17937 * expression.cs: Add MethodGroup abstraction, which gets us one
17938 step closer to the specification in the way we handle method
17941 * cs-parser.jay (primary_expression): qualified_identifier now
17942 tried to match up an identifier to a local variable reference or
17943 to a parameter reference.
17945 current_local_parameters is now a parser global variable that
17946 points to the current parameters for the block, used during name
17949 (property_declaration): Now creates an implicit `value' argument to
17952 2001-05-09 Miguel de Icaza <miguel@ximian.com>
17954 * parameter.cs: Do not use `param' arguments as part of the
17955 signature, per the spec.
17957 2001-05-08 Miguel de Icaza <miguel@ximian.com>
17959 * decl.cs: Base class for classes, structs and interfaces. This
17960 is the "Declaration Space"
17962 * cs-parser.jay: Use CheckDef for checking declaration errors
17963 instead of having one on each function.
17965 * class.cs: Factor out some code for handling error handling in
17966 accordance to the "Declarations" section in the "Basic Concepts"
17967 chapter in the ECMA C# spec.
17969 * interface.cs: Make all interface member classes derive from
17970 InterfaceMemberBase.
17972 2001-05-07 Miguel de Icaza <miguel@ximian.com>
17974 * Many things: all interfaces are parsed and generated in
17975 gen-treedump. Support for member variables, constructors,
17976 destructors, properties, constants is there.
17978 Beginning of the IL backend, but very little done, just there for
17981 2001-04-29 Miguel de Icaza <miguel@ximian.com>
17983 * cs-parser.jay: Fix labeled statement.
17985 * cs-tokenizer.cs (escape): Escape " and ' always.
17986 ref_line, ref_name: keep track of the line/filename as instructed
17987 by #line by the compiler.
17990 2001-04-27 Miguel de Icaza <miguel@ximian.com>
17992 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
17993 to match the values in System.CodeDOM.
17995 Divid renamed to Divide.
17997 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
17999 (Statements.set): remove.
18001 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18004 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18005 falseStatements always have valid values.
18007 * cs-parser.jay: Use System.CodeDOM now.