1 2004-12-09 Miguel de Icaza <miguel@ximian.com>
3 * delegate.cs: Fixed my fix from yesterday, sorry about that.
5 2004-12-09 Marek Safar <marek.safar@seznam.cz>
7 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
8 Reduced number of warnings.
10 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
12 2004-12-08 Miguel de Icaza <miguel@ximian.com>
14 * driver.cs: Removed message.
16 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
18 2004-12-08 <vargaz@freemail.hu>
20 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
22 2004-12-08 Martin Baulig <martin@ximian.com>
24 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
25 instead of a CS3002 for properties and indexer.
27 2004-12-08 Martin Baulig <martin@ximian.com>
29 * decl.cs (MemberName.ToString): Make this work again.
31 2004-12-08 Marek Safar <marek.safar@seznam.cz>
33 * attribute.cs (Resolve): Add error 591 detection.
35 * class.cs (FieldMember.Define): Add error 1547 detection.
36 (Indexer.Define): Add error 620 detection.
37 (Operator.Define): Add error 590 detection.
39 * ecore.cs: Missing argument for error 79.
41 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
44 2004-12-07 Marek Safar <marek.safar@seznam.cz>
47 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
50 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
52 * cs-parser.jay : handle doc comments on implicit/explicit operators.
53 Some operator comments were suppressed.
54 * doc.cs : Implicit/explicit operator name in doc comments are like
55 "op_Explicit(type)~returnType", so added suffix handling.
57 2004-12-07 Martin Baulig <martin@ximian.com>
60 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
61 (MemberCore.GetClsCompliantAttributeValue): Likewise.
62 (DeclSpace.ec): New protected field; store the EmitContext here.
63 (DeclSpace.EmitContext): New public property; moved here from
65 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
68 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
69 (Enum.Emit): Don't create a new EmitContext.
71 * delegate.cs (Delegate.DefineType): Always create the
74 * iterators.cs (Iterators.DefineIterator): Create a new
75 EmitContext and store it in `ec'.
77 2004-08-24 Martin Baulig <martin@ximian.com>
80 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
81 this for accessibility checks.
82 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
83 IsNestedFamilyAccessible.
84 (TypeManager.IsSubclassOf): New method, do what the name actually
87 2004-12-06 Raja R Harinath <rharinath@novell.com>
89 Fix crash on cs0657-17.cs.
90 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
91 Use RootContext.Tree.Types, not 'new RootTypes ()'.
92 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
93 the case where the NamespaceEntry gets overwritten.
95 2004-12-06 Marek Safar <marek.safar@seznam.cz>
98 * ecore.cs (ResolveBoolean): Tiny refactoring.
100 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
101 of right expression resolving when left is false constant and
102 operator is LogicalAnd OR true constant and operator is LogicalOr.
104 * statement.cs (ResolveUnreachable): Always reports warning.
106 2004-12-05 Miguel de Icaza <miguel@ximian.com>
108 * class.cs: Distinguish between 1721 and 1722 (just a little help
111 2004-12-03 Miguel de Icaza <miguel@ximian.com>
113 * delegate.cs: Only allow this on new versions of the language.
115 2004-12-02 Duncan Mak <duncan@ximian.com>
117 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
119 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
120 here as a static method. Take an additional bool out parameter
121 `must_do_cs1540_check' for signaling to InstanceResolve.
122 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
123 member field from PropertyExpr class and made it an argument of
125 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
126 check for MarshalByRefObject, and report CS0122 instead of CS1540.
127 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
128 and `remove_accessor' as well as InstanceResolve: report CS0122
133 2004-12-03 Raja R Harinath <rharinath@novell.com>
135 Fix test-327.cs, test-328.cs, and put in early infrastructure
136 for eventually fixing #52697.
137 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
138 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
140 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
141 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
142 (VerifyUsing, error246): Update.
143 * rootcontext.cs (RootContext.NamespaceLookup): Just use
144 'NamespaceEntry.LookupNamespaceOrType'.
146 2004-12-03 Martin Baulig <martin@ximian.com>
148 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
149 method as our child, call AnonymousMethod.Compatible() on it.
151 2004-12-03 Raja R Harinath <rharinath@novell.com>
153 Disable XML documentation support in 'basic' profile.
154 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
155 Redirect XmlElement to System.Object.
156 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
157 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
158 * mcs.exe.sources: Add doc-bootstrap.cs.
159 * doc-bootstrap.cs: New file. Contains empty stub implementation
162 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
164 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
165 comments are allowed.
167 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
169 * delegate.cs: Add checks for subtypes in paramaters and return values
170 in VerifyMethod () to add support for Covariance/Contravariance
173 2004-12-02 Miguel de Icaza <miguel@ximian.com>
175 * report.cs: Remove extra closing parenthesis.
177 * convert.cs (Error_CannotImplicitConversion): If the name of the
178 types are the same, provide some extra information.
180 * class.cs (FieldBase): Use an unused bit field from the field to
181 encode the `has_offset' property from the FieldMember. This saves
182 a couple of Ks on bootstrap compilation.
184 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
185 method as our child, return the AnonymousMethod resolved
188 * expression.cs (New.DoResolve): Allow return values from
189 NewDelegate to also include AnonymousMethods.
193 2004-12-02 Marek Safar <marek.safar@seznam.cz>
196 * attribute.cs (Resolve): Improved implementation of params
199 * support.cs (ParameterData): Add HasParams to be faster.
201 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
203 all things are for /doc support:
205 * doc.cs: new file that supports XML documentation generation.
206 * mcs.exe.sources: added doc.cs.
208 Handle /doc command line option.
209 Report error 2006 instead of 5 for missing file name for /doc.
210 Generate XML documentation when required, after type resolution.
212 Added support for picking up documentation (/// and /** ... */),
213 including a new XmlCommentState enumeration.
215 Added lines to fill Documentation element for field, constant,
216 property, indexer, method, constructor, destructor, operator, event
217 and class, struct, interface, delegate, enum.
218 Added lines to warn incorrect comment.
220 Added Documentation field (passed only when /doc was specified).
222 Added DocComment, DocCommentHeader, GenerateDocComment() and
223 OnGenerateDocComment() and some supporting private members for
224 /doc feature to MemberCore.
226 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
228 Added overriden DocCommentHeader.
230 Added overriden DocCommentHeader and GenerateDocComment().
232 2004-12-01 Miguel de Icaza <miguel@ximian.com>
234 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
235 unwrapping the enumeration values, chain to
236 DoConstantNumericPromotions again, so we can promote things to the
237 fundamental types (takes care of enums that are bytes, sbytes).
241 2004-12-01 Raja R Harinath <rharinath@novell.com>
243 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
244 Fix long-standing bug in type-lookup. Use FindType instead of
245 LookupType when ec.ResolvingTypeTree.
246 (Attribute.ResolveType, Attribute.Resolve)
247 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
249 (Attributes.Search): Remove internal version. Update.
250 (Attributes.SearchMulti): Update.
251 (Attributes.GetClsCompliantAttribute): Remove.
252 (Attributes.GetIndexerNameAttribute): Remove.
253 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
254 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
255 * class.cs (Indexer.Define): Likewise.
257 2004-12-01 Marek Safar <marek.safar@seznam.cz>
260 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
261 MarshallByReference members access.
263 * expression.cs: Use CheckMarshallByRefAccess;
264 Better error CS0197 message.
266 * report.cs: Print whole related error message.
268 2004-11-30 Raja R Harinath <rharinath@novell.com>
270 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
271 the current directory to help debugging.
273 2004-11-29 Marek Safar <marek.safar@seznam.cz>
275 * class (GetClassBases): Better error 60 report.
276 (EventProperty): Disabled warning 67 detection.
278 2004-11-29 Marek Safar <marek.safar@seznam.cz>
281 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
283 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
286 2004-11-29 Marek Safar <marek.safar@seznam.cz>
289 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
291 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
293 2004-11-26 Miguel de Icaza <miguel@ximian.com>
295 * attribute.cs (Attribute.Resolve): Refine error reporting and
296 report a cs0117 if the identifier does not exist, to distinguish
297 from 0617 which is a miss-use of the actual identifier.
299 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
300 between cs0070 and cs0079.
302 * class.cs (MemberBase.DoDefine): When reporting a wrong
303 accessibility level, we use MethodCore to compare instead of
304 Method (this was a regression in some refactoring effort).
306 So now we correctly report cs0056 again.
308 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
309 testing the target_type (which was known to be object_type) and
310 not the source type (which is anonymous_method).
312 Fixed reporting of error cs1660.
314 * expression.cs (UserCast.Source): Expose the underlying cast.
316 * statement.cs (Switch.SwitchGoverningType): Sort the list of
317 allowed types to find a match to int32 first (most common).
319 In addition, it ignores any ImplicitUserConversions that did an
320 internal implicit conversion (as the switch statement allows only
321 one integral conversion to exist).
323 * class.cs (PartialContainer.Create): rename `name' to
324 `member_name' for clarity. Then replace the string calls with a
325 call to MemberName.GetPartialName, as now using
326 MemberName.ToString is an error (this is due to the side effects
327 it had, that were fixed in the past).
329 This will restore the error reporting on a number of partial class
330 errors that were missusing this (and getting an exception as a
331 results, which is now just a plain textual warning, because
332 yyparse debug output would crash otherwise).
334 2004-11-26 Raja R Harinath <rharinath@novell.com>
336 * Makefile (PROGRAM_INSTALL_DIR): Remove.
338 2004-11-25 Ben Maurer <bmaurer@ximian.com>
340 * rootcontext.cs (LookupType): Make sure to cache lookups that
341 don't give us a negative result. This saves about 5% of corlib
344 2004-11-25 Miguel de Icaza <miguel@ximian.com>
346 * report.cs (AbstractMessage.Print): messages are sent to stderr
348 * class.cs (TypeContainer.GetClassBases): It is an error to have a
349 non-interface in the list of interfaces (at this point, either
350 parent was properly set, or a base class is being listed in the
353 This flags error 1722, and resolves the crash from bug 69259.
355 2004-11-25 Ben Maurer <bmaurer@ximian.com>
357 * statement.cs (Using.EmitExpressionFinally): make this work right
358 for valuetypes. Fixes 69926.
360 2004-11-25 Miguel de Icaza <miguel@ximian.com>
362 * const.cs (Const.ChangeType): Cope with the "0 literal can be
363 converted to an enum" here, before we try to change the underlying
364 type. This code exists, but it is a different code path than the
365 one used while encoding constants.
367 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
368 old bug: when converting from the null literal to a pointer,
369 return an EmptyCast, not the NullLiteral.
371 This fixes #69921, the recent null_type changes probably made this
374 (ImplicitReferenceConversionExists): In addition, resynchronized
375 the code here, so it matches the same code in
376 ImplicitReferenceConversionExists for the `from any class-type S
377 to any interface-type T'.
380 2004-11-25 Marek Safar <marek.safar@seznam.cz>
382 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
384 2004-11-24 Miguel de Icaza <miguel@ximian.com>
386 * cs-parser.jay: Use verbosity accordingly.
388 2004-11-24 Marek Safar <marek.safar@seznam.cz>
390 * expression.cs (Unary.ResolveOperator): Do not report warning;
391 AddressOf reads from variable.
393 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
395 2004-11-24 Marek Safar <marek.safar@seznam.cz>
399 * attribute.cs (Attributable): Removed CheckTargets.
400 (Attributes.Emit): Explicit attribute targets are tested here.
402 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
403 not enabled for interfaces.
405 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
406 (GetAssemblyName): Ouch next bug there.
408 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
410 * expression.cs: Error 275 added.
412 2004-11-23 Marek Safar <marek.safar@seznam.cz>
414 Fix bug #69177 (Implemented decimal constant support)
416 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
417 (BinaryFold): Add DecimalConstant.
419 * const.cs (Define): Decimal constant
421 (ChangeType): Add decimal type handling.
422 (LookupConstantValue): Don't set value for decimal type but
423 emit DecimalConstantAttribute. Needed for constant optimization.
425 * constant.cs (ToDecimal): New method.
426 (ConvertToDecimal): New method.
427 (IntConstant): Implemented ConvertToDecimal.
428 (DecimalConstant.Emit): Emit optimized version for decimals in
431 * expression.cs (ResolveOperator): Changed order of constant
432 reduction to work correctly with native types which have
433 overloaded operators.
434 (ResolveMemberAccess): Extract constant value from attribute
437 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
439 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
440 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
441 (ChangeType): Decimal is special.
442 (TypeToCoreType): Add decimal type.
444 2004-11-22 Marek Safar <marek.safar@seznam.cz>
446 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
449 2004-11-22 Marek Safar <marek.safar@seznam.cz>
451 * class.cs (EventField.ApplyAttributeBuilder): Fix error
454 2004-11-19 Marek Safar <marek.safar@seznam.cz>
456 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
458 * pending.cs (PendingImplementation): Grab only interfaces.
460 2004-11-19 Marek Safar <marek.safar@seznam.cz>
462 * statement.cs (ForeachHelperMethods): Add location member and
465 2004-11-19 Raja R Harinath <rharinath@novell.com>
467 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
468 automatically handled by executable.make.
469 (PROGRAM): Make profile-specific.
471 2004-11-18 Marek Safar <marek.safar@seznam.cz>
473 * expression.cs (DoResolveBase): Fixed wrong warning for out
476 2004-11-18 Martin Baulig <martin@ximian.com>
478 Merged latest changes into gmcs. Please keep this comment in
479 here, it makes it easier for me to see what changed in MCS since
480 the last time I merged.
482 2004-11-17 Raja R Harinath <rharinath@novell.com>
484 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
485 (TypeHandle.GetMemberCache): New.
486 (TypeHandle.TypeHandle): Update.
487 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
488 (TypeManager.LookupParentInterfacesCache):
489 Rename from LookupInterfaceCache. Optimize slightly.
490 (TypeManager.MemberLookup_FindMembers): Update.
491 * decl.cs (MemberCache.MemberCache): Set Container to null in the
493 (AddCacheContents): Rename from AddHashtable.
494 * class.cs (TypeContainer.parent_container): Remove.
495 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
496 (TypeContainer.DoDefineMembers): Don't initialize it.
497 Update to name changes.
499 2004-11-17 Miguel de Icaza <miguel@ximian.com>
501 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
502 that factors the code to check access modifiers on override.
504 (PropertyBase): Use the code here.
506 Patch from Lluis S'anchez, fixes bug #69361.
508 2004-11-15 Miguel de Icaza <miguel@ximian.com>
510 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
511 routine that is used to report the use of a captured variable
512 whose address has been taken.
514 There are two checks: one when variables are being captured and
515 the other check is when the address of a variable is taken.
517 (because an anonymous methods might be resolved before *or* after
518 the address has been taken) and
520 * expression.cs (Conditional.DoResolve): Remove the special
521 casing that Martin added to trueExpr and falseExpr being both
522 NullLiteral. We get the right behavior now just by introducing
523 the null_type into the compiler.
525 * convert.cs (ExplicitConversion): Change the code to use
526 null_type instead of testing `expr is NullLiteral'.
527 (ImplicitConversionStandard): use null_type too.
528 (ImplicitReferenceConversionExists): use null_type too.
529 (ImplicitReferenceConversion): use null_type too.
531 * literal.cs: The type of `NullLiteral' is now null_type instead
533 (Resolve): Set the type here.
535 * typemanager.cs: Introduce null_type.
537 2004-11-17 Martin Baulig <martin@ximian.com>
539 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
540 direction, like FindMembers() does. Fixes #69546, testcase is in
543 2004-11-16 Martin Baulig <martin@ximian.com>
545 This is based on a patch from Marek Safar, see bug #69082.
546 Fixes bugs #63705 and #67130.
548 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
549 method; create a MemberCache for an interface type and cache the
552 * decl.cs (IMemberContainer.ParentContainer): Removed.
553 (IMemberContainer.ParentCache): New property.
554 (MemberCache.SetupCacheForInterface): Removed.
555 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
556 to create a cache for an interface's "parent".
558 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
561 2004-11-16 Martin Baulig <martin@ximian.com>
563 Merged back from gmcs; these changes already went into gmcs a
567 (TypeManager.AddUserType): Removed the `ifaces' argument.
568 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
570 (TypeManager.AddUserInterface): Removed.
571 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
573 (TypeManager.GetInterfaces): Likewise.
574 (TypeManager.GetExplicitInterfaces): Likewise.
576 * ecore.cs (TypeExpr.GetInterfaces): Removed.
578 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
579 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
581 2004-11-14 Ben Maurer <bmaurer@ximian.com>
583 * statement.cs: Avoid adding bools to a hashtable.
585 2004-11-07 Miguel de Icaza <miguel@ximian.com>
587 * expression.cs (Invocation.OverloadResolve): Flag error if we are
588 calling an unsafe method from a safe location.
590 2004-11-06 Marek Safar <marek.safar@seznam.cz>
593 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
595 2004-11-06 Miguel de Icaza <miguel@ximian.com>
597 * namespace.cs (VerifyUsing): use GetPartialName instead of
600 2004-11-05 Miguel de Icaza <miguel@ximian.com>
602 * statement.cs (Return.Resolve): Fix regression in typo: if
603 `in_exc', we have to request a NeedReturnLabel, this was a typo
604 introduced in the anonymous method check-in. Fixes #69131.
606 * Indexers were using the ShortName when defining themselves,
607 causing a regression in the compiler bootstrap when applying the
608 patch from 2004-11-02 (first part), now they use their full name
611 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
613 * driver.cs: Strip the path from the names of embedded resources. Fixes
616 2004-11-04 Raja R Harinath <rharinath@novell.com>
618 Fix error message regression: cs0104-2.cs.
619 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
620 (AliasEntry.Resolve): Update.
621 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
623 (RootContext.LookupType): Update.
625 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
627 * cs-parser.jay: Add support for handling accessor modifiers
628 * class: Add support port accessor modifiers and error checking,
629 define PropertyMethod.Define as virtual (not abstract anymore)
630 * ecore.cs: Add checking for proeprties access with access modifiers
631 * iterators.cs: Modify Accessor constructor call based in the modified
633 2004-11-02 Ben Maurer <bmaurer@ximian.com>
635 * expression.cs (StringConcat): Handle being called twice,
636 as when we have a concat in a field init with more than two
639 2004-11-02 Miguel de Icaza <miguel@ximian.com>
641 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
642 special case explicit implementations, we should always produce
643 the .property or .event declaration.
645 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
646 since it will not return correct data if people use this
647 unresolved in the presence of using statements (see test-313).
649 * class.cs (MethodData.Define): If we are an explicit interface
650 implementation, set the method name to the full name of the
651 interface plus the name of the method.
653 Notice that using the method.MethodName.GetFullName() does not
654 work, as it will only contain the name as declared on the source
655 file (it can be a shorthand in the presence of using statements)
656 and not the fully qualifed type name, for example:
660 class D : ICloneable {
661 object ICloneable.Clone () {
665 Would produce a method called `ICloneable.Clone' instead of
666 `System.ICloneable.Clone'.
668 * namespace.cs (Alias.Resolve): Use GetPartialName.
670 2004-11-01 Marek Safar <marek.safar@seznam.cz>
672 * cs-parser.jay: Add error 1055 report.
674 2004-11-01 Miguel de Icaza <miguel@ximian.com>
676 * assign.cs (Assign.DoResolve): Only do the transform of
677 assignment into a New if the types are compatible, if not, fall
678 through and let the implicit code deal with the errors and with
679 the necessary conversions.
681 2004-11-01 Marek Safar <marek.safar@seznam.cz>
683 * cs-parser.jay: Add error 1031 report.
685 * cs-tokenizer.cs: Add location for error 1038.
687 2004-10-31 Marek Safar <marek.safar@seznam.cz>
689 * cs-parser.jay: Add error 1016 report.
691 2004-10-31 Marek Safar <marek.safar@seznam.cz>
693 * cs-parser.jay: Add errors 1575,1611 report.
695 2004-10-31 Marek Safar <marek.safar@seznam.cz>
697 * cs-parser.jay: Add error 1001 report.
699 2004-10-31 Marek Safar <marek.safar@seznam.cz>
702 * attribute.cs (GetMarshal): Add method argument for
703 caller identification.
705 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
706 agument for GetMarshal and RuntimeMissingSupport.
708 2004-10-31 Marek Safar <marek.safar@seznam.cz>
710 * attribute.cs (ExtractSecurityPermissionSet): Removed
711 TypeManager.code_access_permission_type.
713 * typemanager.cs: Removed TypeManager.code_access_permission_type.
715 2004-10-27 Miguel de Icaza <miguel@ximian.com>
717 * expression.cs (LocalVariableReference.DoResolveLValue): Check
718 for obsolete use of a variable here. Fixes regression on errors
719 cs0619-25 and cs0619-26.
721 2004-10-27 Marek Safar <marek.safar@seznam.cz>
723 Fix #62358, implemented security attribute encoding.
725 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
726 Tests permitted SecurityAction for assembly or other types.
727 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
728 data from SecurityPermissionAttribute to PermisionSet class.
730 * class.cs (ApplyAttributeBuilder): Added special handling
731 for System.Security.Permissions.SecurityAttribute based types.
733 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
734 special handling for System.Security.Permissions.SecurityAttribute
737 * enum.cs (ApplyAttributeBuilder): Added special handling
738 for System.Security.Permissions.SecurityAttribute based types.
740 * parameter.cs (ApplyAttributeBuilder): Added special handling
741 for System.Security.Permissions.SecurityAttribute based types.
743 * rootcontext.cs: Next 2 core types.
745 * typemanager.cs (TypeManager.security_permission_attr_type):
746 Built in type for the SecurityPermission Attribute.
747 (code_access_permission_type): Build in type.
749 2004-10-17 Miguel de Icaza <miguel@ximian.com>
751 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
752 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
753 all of this information into
754 EmitContext.EmitCapturedVariableInstance.
756 * codegen.cs (EmitCapturedVariableInstance): move here the
757 funcionality of emitting an ldarg.0 in the presence of a
758 remapping. This centralizes the instance emit code.
760 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
761 then emit a load of this: it means that we have reached the
762 topmost ScopeInfo: the one that contains the pointer to the
763 instance of the class hosting the anonymous method.
765 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
766 captures to the topmost CaptureContext.
768 2004-10-12 Miguel de Icaza <miguel@ximian.com>
770 * expression.cs (LocalVariableReference): Move the knowledge about
771 the iterators into codegen's EmitCapturedVariableInstance.
773 2004-10-11 Miguel de Icaza <miguel@ximian.com>
775 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
776 all code paths return a value from an anonymous method (it is the
777 same as the 161 error, but for anonymous methods).
779 2004-10-08 Miguel de Icaza <miguel@ximian.com>
781 The introduction of anonymous methods in the compiler changed
782 various ways of doing things in the compiler. The most
783 significant one is the hard split between the resolution phase
784 and the emission phases of the compiler.
786 For instance, routines that referenced local variables no
787 longer can safely create temporary variables during the
788 resolution phase: they must do so from the emission phase,
789 since the variable might have been "captured", hence access to
790 it can not be done with the local-variable operations from the runtime.
794 (Block.Flags): New flag `IsTopLevel' to indicate that this block
797 (ToplevelBlock): A new kind of Block, these are the blocks that
798 are created by the parser for all toplevel method bodies. These
799 include methods, accessors and anonymous methods.
801 These contain some extra information not found in regular blocks:
802 A pointer to an optional CaptureContext (for tracking captured
803 local variables and parameters). A pointer to the parent
806 (Return.Resolve): Catch missmatches when returning a value from an
807 anonymous method (error 1662).
808 Invoke NeedReturnLabel from the Resolve phase instead of the emit
811 (Break.Resolve): ditto.
813 (SwitchLabel): instead of defining the labels during the
814 resolution phase, we now turned the public ILLabel and ILLabelCode
815 labels into methods called GetILLabelCode() and GetILLabel() that
816 only define the label during the Emit phase.
818 (GotoCase): Track the SwitchLabel instead of the computed label
819 (its contained therein). Emit the code by using
820 SwitchLabel.GetILLabelCode ().
822 (LocalInfo.Flags.Captured): A new flag has been introduce to track
823 whether the Local has been captured or not.
825 (LocalInfo.IsCaptured): New property, used to tell whether the
826 local has been captured.
828 * anonymous.cs: Vastly updated to contain the anonymous method
831 The main classes here are: CaptureContext which tracks any
832 captured information for a toplevel block and ScopeInfo used to
833 track the activation frames for various local variables.
835 Each toplevel block has an optional capture context associated
836 with it. When a method contains an anonymous method both the
837 toplevel method and the anonymous method will create a capture
838 context. When variables or parameters are captured, they are
839 recorded on the CaptureContext that owns them, for example:
843 MyDelegate d = delegate {
848 Here `a' will be recorded as captured on the toplevel
849 CapturedContext, the inner captured context will not have anything
850 (it will only have data if local variables or parameters from it
851 are captured in a nested anonymous method.
853 The ScopeInfo is used to track the activation frames for local
854 variables, for example:
856 for (int i = 0; i < 10; i++)
857 for (int j = 0; j < 10; j++){
858 MyDelegate d = delegate {
863 At runtime this captures a single captured variable `i', but it
864 captures 10 different versions of the variable `j'. The variable
865 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
868 The toplevel ScopeInfo will also track information like the `this'
869 pointer if instance variables were referenced (this is necessary
870 as the anonymous method lives inside a nested class in the host
873 (AnonymousMethod): Expanded to track the Toplevel, implement
874 `AnonymousMethod.Compatible' to tell whether an anonymous method
875 can be converted to a target delegate type.
877 The routine now also produces the anonymous method content
879 (AnonymousDelegate): A helper class that derives from
880 DelegateCreation, this is used to generate the code necessary to
881 produce the delegate for the anonymous method that was created.
883 * assign.cs: API adjustments for new changes in
884 Convert.ImplicitStandardConversionExists.
886 * class.cs: Adjustments to cope with the fact that now toplevel
887 blocks are of type `ToplevelBlock'.
889 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
890 insteda of standard blocks.
892 Flag errors if params arguments are passed to anonymous methods.
894 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
895 `CurrentAnonymousMethod' which points to the current Anonymous
896 Method. The variable points to the AnonymousMethod class that
897 holds the code being compiled. It is set in the new EmitContext
898 created for the anonymous method.
900 (EmitContext.Phase): Introduce a variable and an enumeration to
901 assist in enforcing some rules about when and where we are allowed
902 to invoke certain methods (EmitContext.NeedsReturnLabel is the
903 only one that enfonces this right now).
905 (EmitContext.HaveCaptureInfo): new helper method that returns
906 whether we have a CapturedContext initialized.
908 (EmitContext.CaptureVariable): New method used to register that a
909 LocalInfo must be flagged for capturing.
911 (EmitContext.CapturedParameter): New method used to register that a
912 parameters must be flagged for capturing.
914 (EmitContext.CapturedField): New method used to register that a
915 field must be flagged for capturing.
917 (EmitContext.HaveCapturedVariables,
918 EmitContext.HaveCapturedFields): Return whether there are captured
921 (EmitContext.EmitMethodHostInstance): This is used to emit the
922 instance for the anonymous method. The instance might be null
923 (static methods), this (for anonymous methods that capture nothing
924 and happen to live side-by-side with the current method body) or a
925 more complicated expression if the method has a CaptureContext.
927 (EmitContext.EmitTopBlock): Routine that drives the emission of
928 code: it will first resolve the top block, then emit any metadata
929 and then emit the code. The split is done so that we can extract
930 any anonymous methods and flag any captured variables/parameters.
932 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
933 during this phase, the ILGenerator should not be used as labels
934 and local variables declared here might not be accessible to any
935 code that is part of an anonymous method.
937 Exceptions to this include the temporary variables that are
938 created by some statements internally for holding temporary
941 (EmitContext.EmitMeta): New routine, in charge of emitting all the
944 (EmitContext.TemporaryReturn): This method is typically called
945 from the Emit phase, and its the only place where we allow the
946 ReturnLabel to be defined other than the EmitMeta. The reason is
947 that otherwise we would have to duplicate a lot of logic in the
948 Resolve phases of various methods that today is on the Emit
951 (EmitContext.NeedReturnLabel): This no longer creates the label,
952 as the ILGenerator is not valid during the resolve phase.
954 (EmitContext.EmitThis): Extended the knowledge in this class to
955 work in anonymous methods in addition to iterators.
957 (EmitContext.EmitCapturedVariableInstance): This emits whatever
958 code is necessary on the stack to access the instance to a local
959 variable (the variable will be accessed as a field).
961 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
962 EmitContext.EmitAddressOfParameter): Routines to support
963 parameters (not completed at this point).
965 Removals: Removed RemapLocal and RemapLocalLValue. We probably
966 will also remove the parameters.
968 * convert.cs (Convert): Define a `ConstantEC' which points to a
969 null. This is just to prefity some code that uses
970 ImplicitStandardConversion code and do not have an EmitContext
973 The idea is to flag explicitly that at that point in time, it is
974 known that the conversion will not trigger the delegate checking
975 code in implicit conversions (which requires a valid
978 Everywhere: pass new EmitContext parameter since
979 ImplicitStandardConversionExists now requires it to check for
980 anonymous method conversions.
982 (Convert.ImplicitStandardConversionExists): If the type of an
983 expression is the anonymous_method_type, and the type is a
984 delegate, we invoke the AnonymousMethod.Compatible method to check
985 whether an implicit conversion is possible.
987 (Convert.ImplicitConversionStandard): Only do implicit method
988 group conversions if the language level is not ISO_1.
990 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
991 MethodInfo for the Invoke method. used by Delegate and
994 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
995 method conversions if the target type is a delegate.
997 Removed extra debugging nops.
999 (LocalVariableReference): Turn the `local_info' into a public
1002 Add `prepared' field, the same hack used for FieldExprs to cope
1003 with composed assignments, as Local variables do not necessarily
1004 operate purely on the stack as they used to: they can be captured
1007 Add `temp' for a temporary result, like fields.
1009 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1011 It now copes with Local variables that are captured and emits the
1012 proper instance variable to load it from a field in the captured
1015 (ParameterReference.DoResolveBase): During the resolve phase,
1016 capture parameters if we are in an anonymous method.
1018 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1019 anonymous method, use the EmitContext helper routines to emit the
1020 parameter reference.
1022 * iterators.cs: Set RemapToProxy to true/false during the
1025 * parameters.cs (GetParameterByName): New helper method.
1027 * typemanager.cs (anonymous_method_type) a new type that
1028 represents an anonyous method. This is always an internal type,
1029 used as a fencepost to test against the anonymous-methodness of an
1032 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1034 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1036 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1038 2004-10-18 Martin Baulig <martin@ximian.com>
1040 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1041 `Type' directly, but call ResolveType() on it.
1042 (Catch.Resolve): Likewise.
1043 (Foreach.Resolve): Likewise.
1045 2004-10-18 Martin Baulig <martin@ximian.com>
1047 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1048 `Type' directly, but call ResolveType() on it.
1049 (Probe.DoResolve): Likewise.
1050 (ArrayCreation.LookupType): Likewise.
1051 (TypeOf.DoResolve): Likewise.
1052 (SizeOf.DoResolve): Likewise.
1054 2004-10-18 Martin Baulig <martin@ximian.com>
1056 * expression.cs (Invocation.BetterFunction): Put back
1057 TypeManager.TypeToCoreType().
1059 2004-10-18 Raja R Harinath <rharinath@novell.com>
1061 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1064 2004-10-18 Martin Baulig <martin@ximian.com>
1066 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1067 `Type' directly, but call ResolveType() on it.
1069 2004-10-18 Martin Baulig <martin@ximian.com>
1071 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1072 `Type' directly, but call ResolveType() on it.
1073 (MemberBase.DoDefine): Likewise.
1075 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1076 `Type' directly, but call ResolveType() on it.
1077 (ComposedCast.DoResolveAsTypeStep): Likewise.
1079 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1080 `Type' directly, but call ResolveType() on it.
1082 2004-10-17 John Luke <john.luke@gmail.com>
1084 * class.cs (Operator.GetSignatureForError): use CSharpName
1086 * parameter.cs (Parameter.GetSignatureForError): Returns
1087 correct name even if was not defined.
1089 2004-10-13 Raja R Harinath <rharinath@novell.com>
1092 * class.cs (TypeContainer.EmitContext): New property.
1093 (DefineNestedTypes): Create an emitcontext for each part.
1094 (MethodCore.DoDefineParameters): Use container's emitcontext.
1095 Pass type array to InternalParameters.
1096 (MemberBase.DoDefine): Use container's emitcontext.
1097 (FieldMember.Define): Likewise.
1098 (Event.Define): Likewise.
1099 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1100 Pass type array to InternalParameters.
1101 (SetIndexerMethod.GetParameterInfo): Likewise.
1102 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1103 * delegate.cs (Define): Pass emitcontext to
1104 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1105 array to InternalParameters.
1106 * expression.cs (ParameterReference.DoResolveBase): Pass
1107 emitcontext to GetParameterInfo.
1108 (ComposedCast.DoResolveAsTypeStep): Remove check on
1109 ec.ResolvingTypeTree.
1110 * parameter.cs (Parameter.Resolve): Change argument to
1111 EmitContext. Use ResolveAsTypeTerminal.
1112 (Parameter.GetSignature): Change argument to EmitContext.
1113 (Parameters.ComputeSignature): Likewise.
1114 (Parameters.ComputeParameterTypes): Likewise.
1115 (Parameters.GetParameterInfo): Likewise.
1116 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1117 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1118 * support.cs (InternalParameters..ctor): Remove variant that takes
1120 * typemanager.cs (system_intptr_expr): New.
1121 (InitExpressionTypes): Initialize it.
1123 2004-10-12 Chris Toshok <toshok@ximian.com>
1125 * cs-parser.jay: fix location for try_statement and catch_clause.
1127 2004-10-11 Martin Baulig <martin@ximian.com>
1129 * report.cs: Don't make --fatal abort on warnings, we have
1130 -warnaserror for that.
1132 2004-10-07 Raja R Harinath <rharinath@novell.com>
1134 More DeclSpace.ResolveType avoidance.
1135 * decl.cs (MemberCore.InUnsafe): New property.
1136 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1137 with newly created EmitContext.
1138 (FieldMember.Define): Likewise.
1139 * delegate.cs (Delegate.Define): Likewise.
1140 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1141 only if normal name-lookup fails.
1142 (TypeExpr.DoResolve): Enable error-checking.
1143 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1144 (SizeOf.DoResolve): Likewise.
1145 (ComposedCast.DoResolveAsTypeStep): Likewise.
1146 (StackAlloc.DoResolve): Likewise.
1147 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1148 (Block.Unsafe): New property.
1149 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1150 (Unsafe): Set 'unsafe' flag of contained block.
1151 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1152 (Fixed.Resolve): Likewise.
1153 (Catch.Resolve): Likewise.
1154 (Using.ResolveLocalVariableDecls): Likewise.
1155 (Foreach.Resolve): Likewise.
1157 2004-10-05 John Luke <john.luke@gmail.com>
1159 * cs-parser.jay: add location to error CS0175
1161 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1163 * ecore.cs (Expression.Constantity): Add support for turning null
1166 * const.cs (Const.Define): Allow constants to be reference types
1167 as long as the value is Null.
1169 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1171 * namespace.cs (NamespaceEntry.Using): No matter which warning
1172 level is set, check if this namespace name has already been added.
1174 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1176 * expression.cs: reftype [!=]= null should always use br[true,false].
1179 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1182 * attribute.cs: Enum conversion moved to
1183 GetAttributeArgumentExpression to be applied to the all
1186 2004-10-01 Raja R Harinath <rharinath@novell.com>
1188 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1189 * class.c (TypeContainer.DefineType): Flag error if
1190 base types aren't accessible due to access permissions.
1191 * decl.cs (DeclSpace.ResolveType): Move logic to
1192 Expression.ResolveAsTypeTerminal.
1193 (DeclSpace.ResolveTypeExpr): Thin layer over
1194 Expression.ResolveAsTypeTerminal.
1195 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1196 Refactor code into NestedAccess. Use it.
1197 (DeclSpace.NestedAccess): New.
1198 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1199 argument to silence errors. Check access permissions.
1200 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1201 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1202 (Cast.DoResolve): Likewise.
1203 (New.DoResolve): Likewise.
1204 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1205 (TypeOf.DoResolve): Likewise.
1207 * expression.cs (Invocation.BetterConversion): Return the Type of
1208 the better conversion. Implement section 14.4.2.3 more faithfully.
1209 (Invocation.BetterFunction): Make boolean. Make correspondence to
1210 section 14.4.2.2 explicit.
1211 (Invocation.OverloadResolve): Update.
1212 (Invocation): Remove is_base field.
1213 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1214 (Invocation.Emit): Likewise.
1216 2004-09-27 Raja R Harinath <rharinath@novell.com>
1218 * README: Update to changes.
1220 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1222 * cs-parser.jay: Reverted 642 warning fix.
1224 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1227 * decl.cs (FindMemberWithSameName): Indexer can have more than
1230 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1232 * expression.cs (LocalVariableReference.DoResolveLValue):
1233 Do not report warning 219 for out values.
1234 (EmptyExpression.Null): New member to avoid extra allocations.
1236 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1238 * cs-parser.jay: Fix wrong warning 642 report.
1240 * cs-tokenizer.cs (CheckNextToken): New helper;
1241 Inspect next character if is same as expected.
1243 2004-09-23 Martin Baulig <martin@ximian.com>
1245 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1246 (Convert.ImplicitReferenceConversionExists): Likewise.
1248 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1250 * class.cs (Operator.Define): Add error 448 and 559 report.
1252 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1254 * class.cs (MemberBase.IsTypePermitted): New protected
1255 method for checking error CS0610.
1257 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1259 * class.cs (TypeContainer.HasExplicitLayout): New property
1260 Returns whether container has StructLayout attribute set Explicit.
1261 (FieldMember): New abstract class for consts and fields.
1262 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1263 (Field): Reuse FieldMember.
1265 * const.cs (Const): Reuse FieldMember.
1267 * rootcontext.cs: EmitConstants call moved to class.
1269 2004-09-22 Martin Baulig <martin@ximian.com>
1271 Thanks to Peter Sestoft for this bug report.
1273 * expression.cs (Conditional): If both the `trueExpr' and the
1274 `falseExpr' is a NullLiteral, return a NullLiteral.
1276 2004-09-22 Martin Baulig <martin@ximian.com>
1278 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1279 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1280 for the "get_Current" call.
1282 2004-09-22 Martin Baulig <martin@ximian.com>
1284 Marek and me just fixed one of our oldest bugs: #28562 :-)
1286 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1288 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1289 we're an EnumConstant, just return that.
1290 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1291 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1292 to get the value which'll actually be written into the attribute.
1293 However, we have to use GetValue() to access the attribute's value
1296 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1298 * constant.cs (Constant.IsNegative): New abstract property
1301 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1302 (StackAlloc.DoResolve): Reused IsNegative.
1304 2004-09-21 Martin Baulig <martin@ximian.com>
1306 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1307 if we're used in an iterator, we may be called from different
1310 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1311 we actually have an exception block.
1313 2004-09-20 John Luke <jluke@cfl.rr.com>
1315 * class.cs, cs-parser.jay: Improve the error report for 1520:
1316 report the actual line where the error happens, not where the
1319 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1320 Pass location information that was available elsewhere.
1322 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1324 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1325 runtime to delay sign assemblies.
1327 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1329 * cs-parser.jay: Do not report the stack trace, this is barely
1332 2004-08-22 John Luke <john.luke@gmail.com>
1334 * driver.cs : check that a resource id is not already used
1335 before adding it, report CS1508 if it is, bug #63637
1337 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1339 * ecore.cs: Removed dead code.
1341 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1343 * class.cs: Do not report warning CS0067 on the interfaces.
1345 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1347 * cs-parser.jay: Add error 504 report.
1349 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1351 * rootcontext.cs: WarningLevel is 4 by default now.
1353 * statement.cs (Fixed.Resolve): Do not null
1356 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1359 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1360 deep search when property is not virtual.
1361 (PropertyExpr.ResolveAccessors): Make one call for both
1364 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1367 * statement.cs: Error 152 report constains also location.
1369 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1372 * const.cs: Explicitly set constant as static.
1374 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1377 * cs-parser.jay: Add error 1017 report.
1379 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1381 Fixed bug #59980, #64224
1382 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1384 * typemanager.cs (IsSpecialMethod): Simplified
1386 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1388 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1389 condition with better params.
1391 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1394 * attribute.cs (Resolve): Property has to have both
1397 2004-09-14 Martin Baulig <martin@ximian.com>
1399 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1401 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1404 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1405 called and is obsolete then this member suppress message
1406 when call is inside next [Obsolete] method or type.
1408 * expression.cs: Use TestObsoleteMethodUsage member.
1410 2004-09-14 Martin Baulig <martin@ximian.com>
1412 * cs-parser.jay: Sync a bit with the GMCS version.
1414 2004-09-14 Martin Baulig <martin@ximian.com>
1416 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1417 (CSharpParser.yacc_verbose_flag): New public field.
1419 * genericparser.cs: Removed.
1421 2004-09-14 Raja R Harinath <rharinath@novell.com>
1423 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
1425 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1427 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1429 2004-09-10 Martin Baulig <martin@ximian.com>
1431 Backported my MemberName changes from GMCS into MCS.
1433 - we are now using a special `MemberName' class instead of using
1434 strings; in GMCS, the `MemberName' also contains the type
1437 - changed the grammar rules a bit:
1438 * the old `member_name' is now a `namespace_or_type_name':
1439 The rule is that we use `namespace_or_type_name' everywhere
1440 where we expect either a "member name" (GetEnumerator) or a
1441 "member name" with an explicit interface name
1442 (IEnumerable.GetEnumerator).
1443 In GMCS, the explicit interface name may include type arguments
1444 (IEnumerable<T>.GetEnumerator).
1445 * we use `member_name' instead of just `IDENTIFIER' for
1447 The rule is that we use `member_name' wherever a member may
1448 have type parameters in GMCS.
1450 * decl.cs (MemberName): New public class.
1451 (MemberCore.MemberName): New public readonly field.
1452 (MemberCore.ctor): Take a `MemberName' argument, not a string.
1453 (DeclSpace): Likewise.
1455 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
1456 * enum.cs (Enum.ctor): Likewise.
1458 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
1460 (AliasEntry.ctor): Take a MemberName, not an Expression.
1461 (AliasEntry.UsingAlias): Likewise.
1463 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
1464 (IMethodData.MemberName): Changed type from string to MemberName.
1465 (MemberBase.ExplicitInterfaceName): Likewise.
1466 (AbstractPropertyEventMethod.SetupName): Make this private.
1467 (AbstractPropertyEventMethod.ctor): Added `string prefix'
1468 argument; compute the member name here.
1469 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
1470 on the `member.MemberName' and the `prefix'.
1472 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
1474 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
1475 thus, we get a `MemberName' instead of a `string'. These
1476 declarations may have type parameters in GMCS.
1477 (interface_method_declaration, delegate_declaration): Likewise.
1478 (class_declaration, interface_declaration): Likewise.
1479 (method_header): Use `namespace_or_type_name' instead of
1480 `member_name'. We may be an explicit interface implementation.
1481 (property_declaration, event_declaration): Likewise.
1482 (member_name): This is now just an `IDENTIFIER', not a
1483 `namespace_or_type_name'.
1484 (type_name, interface_type): Removed.
1485 (namespace_or_type_name): Return a MemberName, not an Expression.
1486 (primary_expression): Use `member_name' instead of `IDENTIFIER';
1487 call GetTypeExpression() on the MemberName to get an expression.
1488 (IndexerDeclaration.interface_type): Changed type from string to
1490 (MakeName): Operate on MemberName's instead of string's.
1492 2004-09-13 Raja R Harinath <rharinath@novell.com>
1495 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
1496 (NamespaceEntry.Lookup): Add new argument to flag if we want the
1497 lookup to avoid symbols introduced by 'using'.
1498 * rootcontext.cs (NamespaceLookup): Update.
1500 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1502 * class.cs (TypeContainer.DoDefineMembers): Do not call
1503 DefineDefaultConstructor for static classes.
1505 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1507 * attribute.cs (Attribute.Resolve): Add error 653 report.
1509 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1511 (Method.ApplyAttributeBuilder): Add error 685 report.
1512 (Operator.Define): Add error 564 report.
1514 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1516 * expression.cs (Invocation.DoResolve): Add error
1519 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1522 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1524 * class.cs (ConstructorInitializer.Resolve):
1525 Wrong error number (515->516).
1527 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1529 * class.cs (Indexer.Define): Add error 631 report.
1531 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1533 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1535 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1537 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1539 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1541 * cs-parser.jay: Added error CS0241 report.
1543 2004-09-10 Raja R Harinath <rharinath@novell.com>
1545 * cs-parser.jay (fixed_statement): Introduce a scope for the
1546 declaration in the 'fixed' statement.
1548 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1550 * cs-parser.jay: Added CS0230 error report.
1552 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1554 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1556 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1558 * expression.cs (Argument.Resolve): Added error CS0192 and
1561 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1563 C# 2.0 #pragma warning feature
1565 * cs-tokenizer.cs (PreProcessPragma): New method;
1566 Handles #pragma directive.
1568 * report.cs (WarningRegions): New class; Support
1569 class for #pragma warning directive. It tests whether
1570 warning is enabled for a given line.
1572 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1574 * const.cs: Add more descriptive error report, tahnks to
1577 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1579 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1581 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1583 * expression.cs: Apply patch from Ben: Remove dead code from
1584 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1585 as that code just threw an exception anwyays.
1587 * const.cs: Remove the call to the turnintoconstant, for details
1590 * literal.cs: The type of the null-literal is the null type; So
1591 we use a placeholder type (literal.cs:System.Null, defined here)
1594 * expression.cs (Conditional.DoResolve): Remove some old code that
1595 is no longer needed, conversions have been fixed.
1597 (ArrayCreationExpression.DoResolve): Return false if we fail to
1598 resolve the inner expression.
1600 2004-09-07 Raja R Harinath <rharinath@novell.com>
1603 * cs-parser.jay (delegate_declaration): Record a delegate
1604 declaration as a type declaration.
1605 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1607 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1609 * parameter.cs: Do not crash if the type can not be resolved.
1611 * expression.cs: Report errors with unsafe pointers, fixes #64896
1613 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1615 * expression.cs: Pointer arith always needs to do a conv.i
1616 if the operand is a long. fix 65320
1618 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1620 Fixed cs0619-37.cs, cs0619-38.cs
1622 * enum.cs (GetObsoleteAttribute): Removed.
1624 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1625 on Enum member is double staged. The first is tested member
1628 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1630 Fixed #56986, #63631, #65231
1632 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1633 adds member to name container.
1634 (TypeContainer.AddToTypeContainer): New method, adds type to
1636 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1637 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1638 AddOperator): Simplified by reusing AddToMemberContainer.
1639 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1641 (Method.CheckForDuplications): Fixed implementation to test all
1643 (MemberBase): Detection whether member is explicit interface
1644 implementation is now in constructor.
1645 (MemberBase.UpdateMemberName): Handles IndexerName.
1646 (Accessor): Changed to keep also location information.
1647 (AbstractPropertyEventMethod): Is derived from MemberCore.
1648 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1649 will be emited or not.
1650 (PropertyBase.AreAccessorsDuplicateImplementation):
1651 Tests whether accessors are not in collision with some method.
1652 (Operator): Is derived from MethodCore to simplify common
1655 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1657 (DeclSpace.AddToContainer): Adds the member to defined_names
1658 table. It tests for duplications and enclosing name conflicts.
1660 * enum.cs (EnumMember): Clean up to reuse the base structures
1662 2004-09-03 Martin Baulig <martin@ximian.com>
1664 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1665 into TypeContainer, to make partial classes work again.
1667 2004-09-03 Martin Baulig <martin@ximian.com>
1669 * rootcontext.cs (RootContext.V2): Removed.
1671 2004-03-23 Martin Baulig <martin@ximian.com>
1673 * expression.cs (Invocation.OverloadResolve): Added `bool
1674 may_fail' argument and use it instead of the Location.IsNull() hack.
1676 2004-09-03 Martin Baulig <martin@ximian.com>
1678 Merged latest changes into gmcs. Please keep this comment in
1679 here, it makes it easier for me to see what changed in MCS since
1680 the last time I merged.
1682 2004-09-03 Raja R Harinath <rharinath@novell.com>
1685 * expression.cs (BetterConversion): Don't allow either conversion
1686 to be null. Remove redundant implicit conversion test when 'q ==
1687 null' -- when this function is invoked, we already know that the
1688 implicit conversion exists.
1689 (BetterFunction): Assume that 'best' is non-null. Remove
1690 redundant reimplementation of IsApplicable when 'best' is null.
1691 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1692 number of arguments.
1693 (IsAncestralType): Extract from OverloadResolve.
1694 (OverloadResolve): Make robust to the MethodGroupExpr being
1695 unsorted. Implement all the logic of Section 14.5.5.1, and
1696 support overloading of methods from multiple applicable types.
1697 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1699 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1700 (RealError, Warning): Append type of report to related symbol.
1702 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1704 * enum.cs: Fixed CLS-Compliance checks for enum members.
1705 Error tests cs3008-8.cs, cs3014-8.cs
1707 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1709 Fixed bug #62342, #63102
1710 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1711 like ImplementMethod.
1713 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1715 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1718 2004-09-02 Martin Baulig <martin@ximian.com>
1720 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1721 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1724 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1726 C# 2.0 Static classes implemented
1728 * class.cs (TypeContainer): instance_constructors,
1729 initialized_fields, initialized_static_fields,
1730 default_constructor, base_inteface_types are protected to be
1731 accessible from StaticClass.
1732 (TypeContainer.DefineDefaultConstructor): New virtual method
1733 for custom default constructor generating
1734 (StaticClass): New class to handle "Static classes" feature.
1736 * cs-parser.jay: Handle static keyword on class like instance
1739 * driver.cs: Added "/langversion" command line switch with two
1740 options (iso-1, default).
1742 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1744 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1746 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1748 * delegate.cs: Style.
1750 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1752 * delegate.cs: Add seperate instance expr field for miguel.
1754 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1756 * PointerArithmetic (Resolve): make sure we are not doing
1757 pointer arith on void*. Also, make sure we are resolved
1758 by not setting eclass until resolve.
1760 All callers: Make sure that PointerArithmetic gets resolved.
1762 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1764 * ArrayCreation (LookupType): If the type does not resolve
1765 to an array, give an error.
1767 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1769 * statement.cs (Try.Resolve): Fixed bug #64222
1771 2004-08-27 Martin Baulig <martin@ximian.com>
1774 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1777 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1779 * ecore.cs (Constantify): Get underlying type via
1780 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1781 Windows in special cases.
1783 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1785 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1786 for obtaining also private methods.
1787 (GetRemoveMethod): Used GetRemoveMethod (true)
1788 for obtaining also private methods.
1790 2004-08-24 Martin Baulig <martin@ximian.com>
1792 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1793 MethodAttributes.HideBySig for operators.
1795 2004-08-23 Martin Baulig <martin@ximian.com>
1797 Back to the old error reporting system :-)
1799 * report.cs (Message): Removed.
1800 (Report.MessageData, ErrorData, WarningData): Removed.
1801 (Report.Error, Warning): Back to the old system.
1803 2004-08-23 Martin Baulig <martin@ximian.com>
1805 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1807 * class.cs (TypeContainer.ParentContainer): New public virtual
1808 method; replaces the explicit interface implementation.
1809 (ClassPart.ParentContainer): Override.
1811 2004-08-23 Martin Baulig <martin@ximian.com>
1813 * statement.cs (Switch): Added support for constant switches; see
1814 #59428 or test-285.cs.
1816 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1819 * statement.cs (GetEnumeratorFilter): Removed useless
1820 logic because C# specs is strict. GetEnumerator must be
1823 2004-08-22 Martin Baulig <martin@ximian.com>
1825 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1826 a switch and may break, reset the barrier. Fixes #59867.
1828 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1830 CLS-Compliance speed up (~5% for corlib)
1832 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
1833 New method. Tests container for CLS-Compliant names
1835 * class.cs (TypeContainer.VerifyClsName): New method.
1836 Checks whether container name is CLS Compliant.
1837 (Constructor): Implements IMethodData.
1839 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
1840 low-case table for CLS Compliance test.
1841 (MemberCache.VerifyClsParameterConflict): New method.
1842 Checks method parameters for CS3006 error.
1844 * enum.cs (EnumMember): Is derived from MemberCore.
1845 (Enum.VerifyClsName): Optimized for better performance.
1847 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1849 * report.cs: Renamed Error_T to Error and changed all
1852 2004-08-06 Marek Safar <marek.safar@seznam.cz>
1854 * class.cs (TypeContainer.IndexerArrayList): New inner class
1855 container for indexers.
1856 (TypeContainer.DefaultIndexerName): New constant for default
1857 indexer name. Replaced all "Item" with this constant.
1858 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
1860 * typemanager.cs (TypeManager.default_member_ctor): Cache here
1861 DefaultMemberAttribute constructor.
1863 2004-08-05 Martin Baulig <martin@ximian.com>
1865 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
1868 2004-08-05 Marek Safar <marek.safar@seznam.cz>
1870 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
1871 multi platforms problem.
1873 * compiler.csproj: Included shared files.
1875 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1877 Fix bug 60333, 55971 in the more general way
1878 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1879 Added arg_type argument for constant conversion.
1880 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
1882 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1885 * class.cs (TypeContainer ): New inner classes MethodArrayList,
1886 OperatorArrayList, MethodCoreArrayList for typecontainer
1887 containers. Changed class member types to these new types.
1888 (MethodArrayList.DefineMembers): Added test for CS0659.
1890 2004-08-04 Miguel de Icaza <miguel@ximian.com>
1892 * cfold.cs: Synchronize the folding with the code in expression.cs
1893 Binary.DoNumericPromotions for uint operands.
1895 * attribute.cs: Revert patch from Raja, it introduced a regression
1896 while building Blam-1.2.1 (hard to isolate a test case).
1898 2004-08-04 Marek Safar <marek.safar@seznam.cz>
1902 (TypeContainer.Define): Renamed to DefineContainerMembers because of
1904 (MethodCore.parent_method): New member. The method we're overriding
1905 if this is an override method.
1906 (MethodCore.CheckBase): Moved from Method class and made common.
1907 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
1909 (MethodCore.CheckForDuplications): New abstract method. For custom
1910 member duplication search in a container
1911 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
1912 method and its return type.
1913 (Event.conflict_symbol): New member. Symbol with same name in the
1917 (MemberCache.FindMemberWithSameName): New method. The method
1918 is looking for conflict with inherited symbols.
1920 2004-08-04 Martin Baulig <martin@ximian.com>
1922 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
1924 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
1926 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1928 * report.cs (Message): New enum for better error, warning reference in
1930 (MessageData): New inner abstract class. It generally handles printing of
1931 error and warning messages.
1932 Removed unused Error, Warning, Message methods.
1934 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1936 Fix for cs0592-8.cs test
1938 (Attributable.ValidAttributeTargets): Made public.
1939 (Attribute.ExplicitTarget): New member for explicit target value.
1940 (Attribute.CheckTargets): Now we translate explicit attribute
1941 target to Target here.
1943 2004-08-03 Ben Maurer <bmaurer@ximian.com>
1945 * ecore.cs (MethodGroupExpr): new IsBase property.
1947 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
1949 * delegate.cs (DelegateCreation): store a MethodGroupExpr
1950 rather than an instance expr.
1952 (DelegateCreation.Emit): Use the method group rather than
1953 the instance expression. Also, if you have base.Foo as the
1954 method for a delegate, make sure to emit ldftn, not ldftnvirt.
1956 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
1958 (NewDelegate.DoResolve): Only check for the existance of Invoke
1959 if the method is going to be needed. Use MethodGroupExpr.
1961 (NewDelegate.Emit): Remove, DelegateCreation implements this.
1963 * expression.cs: For pointer arith., make sure to use
1964 the size of the type, not the size of the pointer to
1967 2004-08-03 Marek Safar <marek.safar@seznam.cz>
1970 * class.cs (Class): Added error CS0502 test.
1972 2004-08-03 John Luke <jluke@cfl.rr.com>
1973 Raja R Harinath <rharinath@novell.com>
1976 * attribute.cs (Attribute.complained_before): New flag.
1977 (Attribute.ResolveType, Attribute.Resolve),
1978 (Attribute.DefinePInvokeMethod): Set it.
1979 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
1981 2004-08-03 Martin Baulig <martin@ximian.com>
1983 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
1984 use a user-defined operator; we still need to do numeric
1985 promotions in case one argument is a builtin type and the other
1986 one has an implicit conversion to that type. Fixes #62322.
1988 2004-08-02 Martin Baulig <martin@ximian.com>
1990 * statement.cs (LocalInfo.Flags): Added `IsThis'.
1991 (LocalInfo.IsThis): New public property.
1992 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
1994 2004-08-01 Martin Baulig <martin@ximian.com>
1996 * class.cs (TypeContainer.GetClassBases): Don't set the default
1997 here since we may get called from GetPartialBases().
1998 (TypeContainer.DefineType): If GetClassBases() didn't return a
1999 parent, use the default one.
2001 2004-07-30 Duncan Mak <duncan@ximian.com>
2003 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
2005 2004-07-30 Martin Baulig <martin@ximian.com>
2007 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2009 * class.cs (SourceMethod): New public class, derive from the
2010 symbol writer's ISourceMethod.
2011 (Method): Use the new symbol writer API.
2013 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2014 as argument and use the new symbol writer.
2017 (SourceFile): Implement the symbol writer's ISourceFile.
2018 (Location.SymbolDocument): Removed.
2019 (Location.SourceFile): New public property.
2021 * symbolwriter.cs: Use the new symbol writer API.
2023 2004-07-30 Raja R Harinath <rharinath@novell.com>
2025 * Makefile (install-local): Remove. Functionality moved to
2028 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2030 * Makefile: Install mcs.exe.config file together with mcs.exe.
2031 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2032 correct runtime version.
2034 2004-07-25 Martin Baulig <martin@ximian.com>
2037 (TypeContainer.RegisterOrder): Removed, this was unused.
2038 (TypeContainer, interface_order): Removed.
2039 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2040 TypeContainer as argument since we can also be called with a
2041 `PartialContainer' for a partial class/struct/interface.
2042 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2043 of checking whether we're an `Interface' - we could be a
2045 (PartialContainer.Register): Override; call
2046 AddClass()/AddStruct()/AddInterface() on our parent.
2048 * cs-parser.jay (interface_member_declaration): Add things to the
2049 `current_container', not the `current_class'.
2051 * rootcontext.cs (RegisterOrder): The overloaded version which
2052 takes an `Interface' was unused, removed.
2054 * typemanager.cs (TypeManager.LookupInterface): Return a
2055 `TypeContainer', not an `Interface'.
2056 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2057 contain a `PartialContainer' for an interface, so check it's
2058 `Kind' to figure out what it is.
2060 2004-07-25 Martin Baulig <martin@ximian.com>
2062 * class.cs (Class.DefaultTypeAttributes): New public constant.
2063 (Struct.DefaultTypeAttributes): Likewise.
2064 (Interface.DefaultTypeAttributes): Likewise.
2065 (PartialContainer.TypeAttr): Override this and add the
2066 DefaultTypeAttributes.
2068 2004-07-25 Martin Baulig <martin@ximian.com>
2070 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2071 we can just use the `Parent' field instead.
2073 2004-07-25 Martin Baulig <martin@ximian.com>
2075 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2077 2004-07-25 Martin Baulig <martin@ximian.com>
2079 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2080 our parts before defining any methods.
2081 (TypeContainer.VerifyImplements): Make this virtual.
2082 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2083 on our PartialContainer.
2085 2004-07-25 Martin Baulig <martin@ximian.com>
2087 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2089 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2090 argument, we can just use the `Parent' field instead.
2093 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2094 (MemberBase.DoDefine): Likewise.
2096 2004-07-24 Martin Baulig <martin@ximian.com>
2098 * decl.cs (MemberCore.Parent): New public field.
2099 (DeclSpace.Parent): Moved to MemberCore.
2101 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2102 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2104 (FieldBase, Field, Operator): Likewise.
2105 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2106 (EventField, Event): Likewise.
2108 2004-07-23 Martin Baulig <martin@ximian.com>
2110 * class.cs (PartialContainer): New public class.
2111 (ClassPart): New public class.
2112 (TypeContainer): Added support for partial classes.
2113 (TypeContainer.GetClassBases): Splitted some of the functionality
2114 out into GetNormalBases() and GetPartialBases().
2116 * cs-tokenizer.cs (Token.PARTIAL): New token.
2117 (Tokenizer.consume_identifier): Added some hacks to recognize
2118 `partial', but only if it's immediately followed by `class',
2119 `struct' or `interface'.
2121 * cs-parser.jay: Added support for partial clases.
2123 2004-07-23 Martin Baulig <martin@ximian.com>
2125 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2126 a `DeclSpace' and also made it readonly.
2127 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2128 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2129 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2131 * cs-parser.jay: Pass the `current_class', not the
2132 `current_container' (at the moment, this is still the same thing)
2133 to a new Method, Property, Event, Indexer or Constructor.
2135 2004-07-23 Martin Baulig <martin@ximian.com>
2137 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2138 and removed the `current_interface' one.
2139 (struct_declaration, class_declaration, interface_declaration):
2140 Set `current_class' to the newly created class/struct/interface;
2141 set their `Bases' and call Register() before parsing their body.
2143 2004-07-23 Martin Baulig <martin@ximian.com>
2145 * class.cs (Kind): New public enum.
2146 (TypeContainer): Made this class abstract.
2147 (TypeContainer.Kind): New public readonly field.
2148 (TypeContainer.CheckDef): New public method; moved here from
2150 (TypeContainer.Register): New public abstract method.
2151 (TypeContainer.GetPendingImplementations): New public abstract
2153 (TypeContainer.GetClassBases): Removed the `is_class' and
2154 `is_iface' parameters.
2155 (TypeContainer.DefineNestedTypes): Formerly known as
2157 (ClassOrStruct): Made this class abstract.
2159 * tree.cs (RootTypes): New public type.
2161 2004-07-20 Martin Baulig <martin@ximian.com>
2163 * tree.cs (Tree.RecordNamespace): Removed.
2164 (Tree.Namespaces): Removed.
2166 * rootcontext.cs (RootContext.IsNamespace): Removed.
2168 * cs-parser.jay (namespace_declaration): Just create a new
2169 NamespaceEntry here.
2171 2004-07-20 Martin Baulig <martin@ximian.com>
2173 * statement.cs (ExceptionStatement): New abstract class. This is
2174 now used as a base class for everyone who's using `finally'.
2175 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2176 our local variables before using them.
2178 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2179 virtual method. This is used by Yield.Resolve() to "steal" an
2180 outer block's `finally' clauses.
2181 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2184 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2185 version which takes an ExceptionStatement. This version must be
2186 used to create exception branchings.
2189 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2190 (Iterator.EmitMoveNext): Added exception support; protect the
2191 block with a `fault' clause, properly handle 'finally' clauses.
2192 (Iterator.EmitDispose): Run all the `finally' clauses here.
2194 2004-07-20 Martin Baulig <martin@ximian.com>
2196 * iterator.cs: This is the first of a set of changes in the
2197 iterator code. Match the spec more closely: if we're an
2198 IEnumerable, then GetEnumerator() must be called. The first time
2199 GetEnumerator() is called, it returns the current instance; all
2200 subsequent invocations (if any) must create a copy.
2202 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2204 * expression.cs: Resolve the constant expression before returning
2207 2004-07-19 Martin Baulig <martin@ximian.com>
2209 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2210 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2211 the return type of the new EmitContext.
2213 2004-07-18 Martin Baulig <martin@ximian.com>
2215 * class.cs (Property.Define): Fix iterators.
2217 * iterators.cs (Iterator.Define): Moved the
2218 `container.AddInterator (this)' call here from the .ctor; only do
2219 it if we resolved successfully.
2221 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2223 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2224 `true' for preprocessing directives that we parse. The return
2225 value indicates whether we should return to regular tokenizing or
2226 not, not whether it was parsed successfully.
2228 In the past if we were in: #if false ... #line #endif, we would
2229 resume parsing after `#line'. See bug 61604.
2231 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2232 building: IsEnumType should return true only for enums, not for
2233 enums or System.Enum itself. This fixes #61593.
2235 Likely what happened is that corlib was wrong: mcs depended on
2236 this bug in some places. The bug got fixed, we had to add the
2237 hack, which caused bug 61593.
2239 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2240 that was a workaround for the older conditions.
2242 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2244 * assign.cs: IAssignMethod has a new interface, as documented
2245 inline. All assignment code now uses this new api.
2247 * ecore.cs, expression.cs: All classes which implement
2248 IAssignMethod now use the new interface.
2250 * expression.cs (Invocation): add a hack to EmitCall so that
2251 IndexerAccess can be the target of a compound assignment without
2252 evaluating its arguments twice.
2254 * statement.cs: Handle changes in Invocation api.
2256 2004-07-16 Martin Baulig <martin@ximian.com>
2258 * iterators.cs: Rewrote this. We're now using one single Proxy
2259 class for both the IEnumerable and the IEnumerator interface and
2260 `Iterator' derives from Class so we can use the high-level API.
2262 * class.cs (TypeContainer.AddIterator): New method.
2263 (TypeContainer.DoDefineType): New protected virtual method, which
2264 is called from DefineType().
2265 (TypeContainer.DoDefineMembers): Call DefineType() and
2266 DefineMembers() on all our iterators.
2267 (TypeContainer.Emit): Call Emit() on all our iterators.
2268 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2270 * codegen.cs (EmitContext.CurrentIterator): New public field.
2272 2004-07-15 Martin Baulig <martin@ximian.com>
2275 (TypeManager.not_supported_exception_type): New type.
2277 2004-07-14 Martin Baulig <martin@ximian.com>
2279 * iterators.cs: Use real error numbers.
2281 2004-07-14 Martin Baulig <martin@ximian.com>
2283 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2284 requires this to be a System.Collection.IEnumerable and not a
2285 class implementing that interface.
2286 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2288 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2290 * class.cs: Fixed previous fix, it broke some error tests.
2292 2004-07-12 Martin Baulig <martin@ximian.com>
2294 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2297 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2299 * assign.cs (LocalTemporary): Add new argument: is_address,If
2300 `is_address' is true, then the value that we store is the address
2301 to the real value, and not the value itself.
2303 * ecore.cs (PropertyExpr): use the new local temporary
2304 stuff to allow us to handle X.Y += z (where X is a struct)
2306 2004-07-08 Martin Baulig <martin@ximian.com>
2308 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2309 not always return, just like we're doing in Using.Resolve().
2311 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2313 * cs-parser.jay (fixed_statement): flag this as Pinned.
2315 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2317 * typemanager.cs (TypeManager): Removed MakePinned method, this
2318 mechanism is replaced with the .NET 2.x compatible mechanism of
2319 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2321 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2322 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2323 `IsFixed' property which has a different meaning.
2325 2004-07-02 Raja R Harinath <rharinath@novell.com>
2327 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2328 visible from inside a nested class, not just the names of the
2329 immediately enclosing class.
2332 2004-06-24 Raja R Harinath <rharinath@novell.com>
2334 * expression.cs (BetterConversion): Remove buggy special-case
2335 handling of "implicit constant expression conversions". At this
2336 point, we already know that the conversion is possible -- we're
2337 only checking to see which is better.
2339 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2341 * cs-parser.jay: Added error CS0210 test.
2343 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2345 * cs-parser.jay: Added error CS0134 test.
2347 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2350 * cs-parser.jay: Added error CS0145 test.
2352 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2354 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2356 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2358 * expression.cs (StackAlloc.Resolve): The argument may not
2359 be a constant; deal with this case.
2361 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2363 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2364 GetIndexerAttributeValue.
2365 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2367 * class.cs (Indexer.Define): Added error tests for CS0415,
2370 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2372 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2375 2004-06-23 Martin Baulig <martin@ximian.com>
2377 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2378 neither return nor throw, reset the barrier as well. Fixes #60457.
2380 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2382 * class.cs : EventAttributes is now set to None by default.
2383 This fixes bug #60459.
2385 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2388 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2389 Don't throw exception but return null (it's sufficient now).
2391 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2393 * typemanager.cs (GetArgumentTypes): Faster implementation.
2395 2004-06-18 Martin Baulig <martin@ximian.com>
2397 * attribute.cs (Attribute.Resolve): Check whether we're an
2398 EmptyCast which a Constant child. Fixes #60333.
2400 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2402 * statement.cs (EmitCollectionForeach): Account for the fact that
2403 not all valuetypes are in areas which we can take the address of.
2404 For these variables, we store to a temporary variable. Also, make
2405 sure that we dont emit a `callvirt' on a valuetype method.
2407 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2409 * expression.cs (StackAlloc.DoReSolve): Added test for
2410 negative parameter (CS0247).
2412 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2415 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2417 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2420 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2423 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2425 Fix bug #58254 & cs1555.cs, cs1556.cs
2426 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2428 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2430 * cs-parser.jay: Added error CS1669 test for indexers.
2432 2004-06-11 Martin Baulig <martin@ximian.com>
2434 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2435 call this twice: for params and varargs methods.
2437 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2440 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2442 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2444 * attribute.cs (Attribute.GetValidTargets): Made public.
2447 (AbstractPropertyEventMethod): New class for better code sharing.
2448 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2450 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2452 2004-06-11 Raja R Harinath <rharinath@novell.com>
2455 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
2456 that the call to Resolve is part of a MemberAccess.
2457 (Expression.Resolve): Use it for SimpleName resolution.
2458 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
2459 Add 'intermediate' boolean argument.
2460 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
2461 error message when the SimpleName can be resolved ambiguously
2462 between an expression and a type.
2463 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
2465 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
2466 call on the left-side.
2468 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2471 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
2473 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2475 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
2477 2004-06-11 Martin Baulig <martin@ximian.com>
2479 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
2480 varargs methods if applicable.
2482 2004-06-11 Martin Baulig <martin@ximian.com>
2484 * expression.cs (Invocation.EmitCall): Don't use
2485 `method.CallingConvention == CallingConventions.VarArgs' since the
2486 method could also have `CallingConventions.HasThis'.
2488 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2490 * class.cs (Event.GetSignatureForError): Implemented.
2491 Fixed crash in error test cs3010.cs
2493 2004-06-10 Miguel de Icaza <miguel@ximian.com>
2495 * cs-tokenizer.cs: Change the way we track __arglist to be
2496 consistent with the other keywords.
2498 2004-06-09 Miguel de Icaza <miguel@ximian.com>
2500 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
2503 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
2505 * codegen.cs: Check that all referenced assemblies have a strongname
2506 before strongnaming the compiled assembly. If not report error CS1577.
2507 Fix bug #56563. Patch by Jackson Harper.
2508 * typemanager.cs: Added a method to return all referenced assemblies.
2509 Fix bug #56563. Patch by Jackson Harper.
2511 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2514 (Method.ApplyAttributeBuilder): Moved and added conditional
2515 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
2518 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
2520 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2523 * class.cs: (EventField.attribute_targets): Changed default target.
2525 2004-06-08 Martin Baulig <martin@ximian.com>
2527 * expression.cs (Invocation.EmitCall): Enable varargs methods.
2529 2004-06-08 Martin Baulig <martin@ximian.com>
2531 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
2533 2004-06-07 Martin Baulig <martin@ximian.com>
2535 Added support for varargs methods.
2537 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
2540 * cs-parser.jay: Added support for `__arglist'.
2542 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
2544 * expression.cs (Argument.AType): Added `ArgList'.
2545 (Invocation): Added support for varargs methods.
2546 (ArglistAccess): New public class.
2547 (Arglist): New public class.
2549 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
2551 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
2552 a method's top-level block if the method has varargs.
2554 * support.cs (ReflectionParameters, InternalParameters): Added
2555 support for varargs methods.
2557 2004-06-07 Miguel de Icaza <miguel@ximian.com>
2559 * class.cs: Provide location in indexer error report.
2561 * driver.cs: Use standard names.
2563 * namespace.cs: Catch the use of using after a namespace has been
2564 declared also on using aliases.
2566 2004-06-03 Raja R Harinath <rharinath@novell.com>
2569 * typemanager.cs (closure_private_ok, closure_invocation_type)
2570 (closure_qualifier_type, closure_invocation_assembly)
2571 (FilterWithClosure): Move to ...
2572 (Closure): New internal nested class.
2573 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
2574 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
2575 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
2576 (MemberLookup, MemberLookupFailed): Use it.
2577 * expression.cs (New.DoResolve): Treat the lookup for the
2578 constructor as being qualified by the 'new'ed type.
2579 (Indexers.GetIndexersForTypeOrInterface): Update.
2581 2004-06-03 Marek Safar <marek.safar@seznam.cz>
2584 (GetConditionalAttributeValue): New method. Returns
2585 condition of ConditionalAttribute.
2586 (SearchMulti): New method. Returns all attributes of type 't'.
2587 Use it when attribute is AllowMultiple = true.
2588 (IsConditionalMethodExcluded): New method.
2591 (Method.IsExcluded): Implemented. Returns true if method has conditional
2592 attribute and the conditions is not defined (method is excluded).
2593 (IMethodData): Extended interface for ConditionalAttribute support.
2594 (PropertyMethod.IsExcluded): Implemented.
2597 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
2600 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
2603 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
2605 * expression.cs (ArrayCreationExpression): Make this just an
2606 `expression'. It can't be a statement, so the code here was
2609 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2612 * typemanager.cs (GetFullNameSignature): New method for
2615 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2618 * class.cs (MemberBase.GetSignatureForError): New virtual method.
2619 Use this method when MethodBuilder is null.
2620 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
2621 Added test for error CS0626 (MONO reports error for this situation).
2622 (IMethodData.GetSignatureForError): Extended interface.
2624 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2627 (AttributeTester.GetObsoleteAttribute): Returns instance of
2628 ObsoleteAttribute when type is obsolete.
2631 (TypeContainer.VerifyObsoleteAttribute): Override.
2632 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2633 (MethodCode.VerifyObsoleteAttribute): Override.
2634 (MemberBase.VerifyObsoleteAttribute): Override.
2637 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2638 and report proper error.
2641 Delegate.VerifyObsoleteAttribute): Override.
2644 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2645 and report proper error.
2646 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2649 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2653 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2654 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2655 Added test for ObsoleteAttribute.
2658 (Catch): Derived from Statement.
2660 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2662 Fixed bug #59071 & cs0160.cs
2664 * statement.cs (Try.Resolve): Check here whether order of catch
2665 clauses matches their dependencies.
2667 2004-05-31 Miguel de Icaza <miguel@ximian.com>
2669 * Reverted patch to namespace.cs (Use lookuptypedirect). This
2670 caused a regression: #59343. Referencing nested classes from an
2671 assembly stopped working.
2673 2004-05-31 Martin Baulig <martin@ximian.com>
2675 MCS is now frozen for beta 2.
2677 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2679 * convert.cs: add a trivial cache for overload operator resolution.
2681 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2683 * decl.cs: If possible, use lookuptypedirect here. We can only do
2684 this if there is no `.' after the namespace. Avoids using
2685 LookupType, which does lots of slow processing.
2686 (FindNestedType) New method, does what it says :-).
2687 * namespace.cs: use LookupTypeDirect.
2688 * rootcontext.cs: use membercache, if possible.
2689 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2691 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2694 According to the spec,
2696 In a member access of the form E.I, if E is a single identifier,
2697 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2698 field, property, localvariable, or parameter with the same type as
2699 the meaning of E as a type-name (§3.8), then both possible
2700 meanings of E are permitted.
2702 We did not check that E as a simple-name had the same type as E as
2705 This trivial check gives us 5-7% on bootstrap time.
2707 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2709 * expression.cs (Invocation.OverloadResolve): Avoid the
2710 use of hashtables and boxing here by allocating on demand.
2712 2004-05-30 Martin Baulig <martin@ximian.com>
2714 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2715 we're doing a silent lookup. Don't try to lookup nested types in
2716 TypeManager.object_type (thanks to Ben Maurer).
2718 2004-05-30 Martin Baulig <martin@ximian.com>
2720 Committing a patch from Ben Maurer.
2722 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2724 2004-05-29 Martin Baulig <martin@ximian.com>
2726 * class.cs (IMethodData.ShouldIgnore): New method.
2728 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2729 `Location' argument, we don't need it anywhere. Use
2730 `IMethodData.ShouldIgnore ()' instead of
2731 `MethodData.GetMethodFlags ()'.
2732 (TypeManager.AddMethod): Removed.
2733 (TypeManager.AddMethod2): Renamed to AddMethod.
2735 2004-05-29 Martin Baulig <martin@ximian.com>
2737 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2739 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2740 converting from a class type S to an interface type and we already
2741 have an object on the stack, don't box it again. Fixes #52578.
2743 2004-05-29 Martin Baulig <martin@ximian.com>
2745 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2746 Added support for `params' parameters. Fixes #59267.
2748 2004-05-29 Martin Baulig <martin@ximian.com>
2750 * literal.cs (NullPointer): Provide a private .ctor which sets
2751 `type' to TypeManager.object_type. Fixes #59048.
2753 2004-05-29 Martin Baulig <martin@ximian.com>
2755 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2756 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2758 * ecore.cs (EventExpr.instance_expr): Make the field private.
2760 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2762 Fixed bug #50080 & cs0214-2.cs
2763 * expression.cs (Cast.DoResolve): Check unsafe context here.
2765 * statement.cs (Resolve.DoResolve): Likewise.
2767 2004-05-26 Martin Baulig <martin@ximian.com>
2769 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2771 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2772 (RootContext.LookupType): Pass down the `silent' flag.
2774 2004-05-25 Martin Baulig <martin@ximian.com>
2777 (MethodGroupExpr.IdenticalTypeName): New public property.
2778 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2779 expression actually refers to a type.
2781 2004-05-25 Martin Baulig <martin@ximian.com>
2783 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2784 for #56176 and made it actually work.
2786 2004-05-25 Martin Baulig <martin@ximian.com>
2788 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2789 (FieldExpr, PropertyExpr): Override and implement
2790 CacheTemporaries. Fixes #52279.
2792 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2794 * location.cs: In the new compiler listing a file twice is a
2795 warning, not an error.
2797 2004-05-24 Martin Baulig <martin@ximian.com>
2799 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2800 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2802 2004-05-24 Martin Baulig <martin@ximian.com>
2804 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2805 walking the `using' list. Fixes #53921.
2807 2004-05-24 Martin Baulig <martin@ximian.com>
2809 * const.cs (Const.LookupConstantValue): Added support for
2810 EmptyCast's; fixes #55251.
2812 2004-05-24 Martin Baulig <martin@ximian.com>
2814 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2815 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2816 which does the CS0135 check. The reason is that we first need to
2817 check whether the variable actually exists.
2819 2004-05-24 Martin Baulig <martin@ximian.com>
2821 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2822 than RootContext.LookupType() to find the explicit interface
2825 2004-05-24 Raja R Harinath <rharinath@novell.com>
2827 * Makefile: Simplify. Use executable.make.
2828 * mcs.exe.sources: New file. List of sources of mcs.exe.
2830 2004-05-24 Anders Carlsson <andersca@gnome.org>
2834 Use the invariant culture when doing String.Compare for CLS case
2837 2004-05-23 Martin Baulig <martin@ximian.com>
2839 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
2840 don't have any dots. Fixes #52622, added cs0246-8.cs.
2842 * namespace.cs (NamespaceEntry.Lookup): Likewise.
2844 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2846 * class.cs (MemberBase.Define): Reuse MemberType member for
2847 resolved type. Other methods can use it too.
2849 2004-05-23 Martin Baulig <martin@ximian.com>
2851 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
2852 the variable also exists in the current block (otherwise, we need
2853 to report a CS0103). Fixes #58670.
2855 2004-05-23 Martin Baulig <martin@ximian.com>
2857 * flowanalysis.cs (Reachability.Reachable): Compute this
2858 on-the-fly rather than storing it as a field.
2860 2004-05-23 Martin Baulig <martin@ximian.com>
2862 * flowanalysis.cs (Reachability.And): Manually compute the
2863 resulting `barrier' from the reachability.
2865 2004-05-23 Marek Safar <marek.safar@seznam.cz>
2868 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
2869 instance of ObsoleteAttribute when symbol is obsolete.
2872 (IMethodData): Extended interface for ObsoleteAttribute support.
2874 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2876 * attribute.cs: Fix bug #55970
2878 2004-05-22 Marek Safar <marek.safar@seznam.cz>
2882 (GetObsoleteAttribute): New method. Creates the instance of
2884 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
2885 ObsoleteAttribute when member is obsolete.
2886 (AttributeTester.Report_ObsoleteMessage): Common method for
2887 Obsolete error/warning reporting.
2890 (TypeContainer.base_classs_type): New member for storing parent type.
2893 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
2894 for this MemberCore.
2896 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2898 * attribute.cs, const.cs: Fix bug #58590
2900 2004-05-21 Martin Baulig <martin@ximian.com>
2902 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
2903 out parameters if the end of the method is unreachable. Fixes
2906 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2908 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
2909 Hari was right, why extra method.
2911 2004-05-21 Marek Safar <marek.safar@seznam.cz>
2913 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
2915 2004-05-20 Martin Baulig <martin@ximian.com>
2917 Merged this back from gmcs to keep the differences to a minumum.
2919 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
2920 instead of a Declspace.
2921 (Attribute.ResolveType): Likewise.
2922 (Attributes.Search): Likewise.
2923 (Attributes.Contains): Likewise.
2924 (Attributes.GetClsCompliantAttribute): Likewise.
2926 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
2928 (MethodData.ApplyAttributes): Take an EmitContext instead of a
2931 2004-05-19 Marek Safar <marek.safar@seznam.cz>
2933 Fix bug #58688 (MCS does not report error when the same attribute
2936 * attribute.cs (Attribute.Emit): Distinction between null and default.
2938 2004-05-19 Raja R Harinath <rharinath@novell.com>
2940 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
2941 of a top-level attribute without an attribute target.
2942 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
2944 (Attribute.Conditional_GetConditionName),
2945 (Attribute.Obsolete_GetObsoleteMessage): Update.
2946 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
2947 part of ScanForIndexerName.
2948 (Attribute.CanIgnoreInvalidAttribute): New function.
2949 (Attribute.ScanForIndexerName): Move to ...
2950 (Attributes.ScanForIndexerName): ... here.
2951 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
2952 (Attributes.Search): New internal variant that can choose not to
2953 complain if types aren't resolved. The original signature now
2955 (Attributes.GetClsCompliantAttribute): Use internal variant, with
2956 complaints suppressed.
2957 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
2958 only if it not useful.
2959 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
2960 top-level for attributes that are shared between the assembly
2961 and a top-level class.
2962 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
2963 * class.cs: Update to reflect changes.
2964 (DefineIndexers): Fuse loops.
2965 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
2966 a couple more variants of attribute names.
2968 2004-05-18 Marek Safar <marek.safar@seznam.cz>
2970 Fix bug #52585 (Implemented explicit attribute declaration)
2973 (Attributable.ValidAttributeTargets): New abstract method. It gets
2974 list of valid attribute targets for explicit target declaration.
2975 (Attribute.Target): It holds target itself.
2976 (AttributeSection): Removed.
2977 (Attribute.CheckTargets): New method. It checks whether attribute
2978 target is valid for the current element.
2981 (EventProperty): New class. For events that are declared like
2982 property (with add and remove accessors).
2983 (EventField): New class. For events that are declared like field.
2986 * cs-parser.jay: Implemented explicit attribute target declaration.
2988 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
2989 Override ValidAttributeTargets.
2992 (ReturnParameter): Class for applying custom attributes on
2994 (ParameterAtribute): New class. Class for applying custom
2995 attributes on the parameter type.
2997 2004-05-17 Miguel de Icaza <miguel@ximian.com>
2999 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3002 (Method): Allow UNSAFE here.
3004 * modifiers.cs: Support unsafe reporting.
3006 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3008 * decl.cs: Fix bug #58478.
3010 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3012 * statement.cs: When checking for unreachable code on an EmptyStatement,
3013 set the location. Fixes bug #58488.
3015 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3017 * driver.cs: Add -pkg handling.
3019 From Gonzalo: UseShelLExecute=false
3021 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3024 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3026 (Attribute.IsClsCompliaceRequired): Moved to base for better
3028 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3029 when attribute is AttributeUsageAttribute.
3030 (Attribute.GetValidTargets): Simplified.
3031 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3032 attribute for this type.
3033 (Attribute.ApplyAttributes): Method renamed to Emit and make
3035 (GlobalAttributeSection): New class for special handling of global
3036 attributes (assembly, module).
3037 (AttributeSection.Emit): New method.
3039 * class.cs: Implemented Attributable abstract methods.
3040 (MethodCore.LabelParameters): Moved to Parameter class.
3041 (Accessor): Is back simple class.
3042 (PropertyMethod): Implemented Attributable abstract class.
3043 (DelegateMethod): Implemented Attributable abstract class.
3044 (Event): New constructor for disctintion between normal Event
3045 and Event with accessors.
3047 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3049 * codegen.cs, const.cs, decl.cs, delegate.cs:
3050 (CommonAssemblyModulClass): Implemented Attributable abstract class
3053 * enum.cs: Implement IAttributeSupport interface.
3054 (EnumMember): New class for emum members. Implemented Attributable
3058 (ParameterBase): Is abstract.
3059 (ReturnParameter): New class for easier [return:] attribute handling.
3061 * typemanager.cs: Removed builder_to_attr.
3063 2004-05-11 Raja R Harinath <rharinath@novell.com>
3066 * attribute.cs (Attribute.GetPositionalValue): New function.
3067 * class.cs (TypeContainer.VerifyMembers): New function.
3068 (TypeContainer.Emit): Use it.
3069 (ClassOrStruct): New base class for Class and Struct.
3070 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3071 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3073 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3074 then each non-static field should have a FieldOffset attribute.
3075 Otherwise, none of the fields should have a FieldOffset attribute.
3076 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3077 and FieldOffset attributes.
3078 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3079 (TypeManager.field_offset_attribute_type): New core types.
3080 (TypeManager.InitCoreTypes): Initialize them.
3082 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3084 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3085 Return correct type.
3088 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3090 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3091 be implicitly converted to ulong.
3093 * expression.cs: The logic for allowing operator &, | and ^ worked
3094 was wrong, it worked before because we did not report an error in
3095 an else branch. Fixes 57895.
3097 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3098 allow volatile fields to be reference types.
3100 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3102 * driver.cs: Add support for /debug-
3104 2004-05-07 Raja R Harinath <rharinath@novell.com>
3106 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3107 Add a 'complain' parameter to silence errors.
3108 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3109 silently overlooked type-resolutions.
3110 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3112 (Attributes.Search): New function.
3113 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3114 (Attributes.GetAttributeFullName): Remove hack.
3115 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3116 Update to reflect changes.
3117 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3118 Use Attributes.Search instead of nested loops.
3120 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3123 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3124 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3125 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3127 * report.cs: (Report.Warning): Renamed to Warning_T because of
3128 parameter collision.
3130 2004-05-05 Raja R Harinath <rharinath@novell.com>
3132 * expression.cs (MemberAccess.ResolveMemberAccess):
3133 Exit with non-zero status after Report.Error.
3134 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3136 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3138 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3140 * support.cs: Don't hang when the file is empty.
3142 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3144 * support.cs: In SeekableStreamReader, compute the preamble size of the
3145 underlying stream. Position changes should take into account that initial
3148 2004-05-03 Todd Berman <tberman@sevenl.net>
3150 * driver.cs: remove unused GetSysVersion function.
3152 2004-05-03 Todd Berman <tberman@sevenl.net>
3154 * driver.cs: Remove the hack from saturday, as well as the hack
3155 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3156 link_paths to get that bit proper.
3158 2004-05-01 Todd Berman <tberman@sevenl.net>
3160 * driver.cs: Try a LoadFrom before a Load, this checks the current
3161 path. This is currently a bug in mono that is be fixed, however, this
3162 provides a workaround for now. This will be removed when the bug
3165 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3167 * CryptoConvert.cs: Updated to latest version. Fix issue with
3168 incomplete key pairs (#57941).
3170 2004-05-01 Todd Berman <tberman@sevenl.net>
3172 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3175 2004-04-30 Jackson Harper <jackson@ximian.com>
3177 * codegen.cs: Open keys readonly.
3179 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3181 * typemanager.cs: don't report cyclic struct layout when a struct
3182 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3183 which has 2 Pango.Rectangle fields.
3185 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3187 * expression.cs: Handle IntPtr comparisons with IL code
3188 rather than a method call.
3190 2004-04-29 Martin Baulig <martin@ximian.com>
3192 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3193 the list of PropertyInfo's in class hierarchy and find the
3194 accessor. Fixes #56013.
3196 2004-04-29 Martin Baulig <martin@ximian.com>
3198 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3200 2004-04-29 Martin Baulig <martin@ximian.com>
3202 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3204 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3206 2004-04-29 Martin Baulig <martin@ximian.com>
3208 * class.cs (ConstructorInitializer.Resolve): Check whether the
3209 parent .ctor is accessible. Fixes #52146.
3211 2004-04-29 Martin Baulig <martin@ximian.com>
3213 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3215 * statement.cs (Using.EmitLocalVariableDecls): Use
3216 TypeManager.idisposable_type, not typeof (IDisposable).
3217 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3219 2004-04-29 Martin Baulig <martin@ximian.com>
3221 * class.cs (Event.Define): Don't emit the field and don't set
3222 RTSpecialName and SpecialName for events on interfaces. Fixes
3225 2004-04-29 Raja R Harinath <rharinath@novell.com>
3227 Refactor Attribute.ApplyAttributes.
3228 * attribute.cs (Attributable): New base class for objects that can
3229 have Attributes applied on them.
3230 (Attribute): Make AttributeUsage fields public.
3231 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3232 (Attribute.IsInternalCall): New property.
3233 (Attribute.UsageAttr): Convert to a public read-only property.
3234 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3235 (Attribute.ResolveType, Attribute.Resolve)
3236 (Attribute.ScanForIndexerName): Update to reflect changes.
3237 (Attribute.CheckAttributeTarget): Re-format.
3238 (Attribute.ApplyAttributes): Refactor, to various
3239 Attributable.ApplyAttributeBuilder methods.
3240 * decl.cs (MemberCore): Make Attributable.
3241 * class.cs (Accessor): Make Attributable.
3242 (MethodData.ApplyAttributes): Use proper attribute types, not
3244 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3245 (TypeContainer.ApplyAttributeBuilder)
3246 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3247 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3248 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3249 (Operator.ApplyAttributeBuilder): New factored-out methods.
3250 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3251 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3252 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3253 * parameter.cs (ParameterBase): New Attributable base class
3254 that can also represent Return types.
3255 (Parameter): Update to the changes.
3257 2004-04-29 Jackson Harper <jackson@ximian.com>
3259 * driver.cs: Prefer the corlib system version when looking for
3260 assemblies in the GAC. This is still a hack, but its a better hack
3263 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3265 * decl.cs, enum.cs: Improved error 3005 reporting.
3267 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3268 (related_symbols): New private member for list of symbols
3269 related to reported error/warning.
3271 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3273 2004-04-29 Martin Baulig <martin@ximian.com>
3275 * ecore.cs (Expression.Constantify): If we're an enum and
3276 TypeManager.TypeToCoreType() doesn't give us another type, use
3277 t.UnderlyingSystemType. Fixes #56178.
3279 2004-04-29 Martin Baulig <martin@ximian.com>
3281 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3282 interfaces and for each interface, only add members directly
3283 declared in that interface. Fixes #53255.
3285 2004-04-28 Martin Baulig <martin@ximian.com>
3287 * expression.cs (ConditionalLogicalOperator): Use a temporary
3288 variable for `left' to avoid that we evaluate it more than once;
3291 2004-04-28 Martin Baulig <martin@ximian.com>
3293 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3296 2004-04-28 Martin Baulig <martin@ximian.com>
3298 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3301 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3302 whether the type is not void (CS1547).
3304 2004-04-28 Martin Baulig <martin@ximian.com>
3306 * expression.cs (Unary.DoResolveLValue): Override this and report
3307 CS0131 for anything but Operator.Indirection.
3309 2004-04-28 Martin Baulig <martin@ximian.com>
3311 Committing a patch from Ben Maurer; see bug #50820.
3313 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3316 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3319 2004-04-28 Martin Baulig <martin@ximian.com>
3321 Committing a patch from Ben Maurer; see bug #50820.
3323 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3326 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3329 2004-04-28 Martin Baulig <martin@ximian.com>
3331 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3332 (Block.AddLabel): Call DoLookupLabel() to only search in the
3335 2004-04-28 Martin Baulig <martin@ximian.com>
3337 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3338 comparing StringConstants and NullLiterals in Equality and Inequality.
3340 2004-04-28 Jackson Harper <jackson@ximian.com>
3342 * driver.cs: Attempt to load referenced assemblies from the
3343 GAC. This is the quick and dirty version of this method that
3344 doesnt take into account versions and just takes the first
3345 canidate found. Will be good enough for now as we will not have more
3346 then one version installed into the GAC until I update this method.
3348 2004-04-28 Martin Baulig <martin@ximian.com>
3350 * typemanager.cs (TypeManager.CheckStructCycles): New public
3351 static method to check for cycles in the struct layout.
3353 * rootcontext.cs (RootContext.PopulateTypes): Call
3354 TypeManager.CheckStructCycles() for each TypeContainer.
3355 [Note: We only need to visit each type once.]
3357 2004-04-28 Martin Baulig <martin@ximian.com>
3359 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3361 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3362 success and added `out object value'. Use a `bool resolved' field
3363 to check whether we've already been called rather than
3364 `ConstantValue != null' since this breaks for NullLiterals.
3366 2004-04-28 Raja R Harinath <rharinath@novell.com>
3368 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3369 setting of this flag, since the 'set' method may be non-public.
3371 2004-04-28 Raja R Harinath <rharinath@novell.com>
3373 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3374 check on current_vector.Block.
3376 2004-04-27 Martin Baulig <martin@ximian.com>
3378 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3379 a field initializer. Fixes #56459.
3381 2004-04-27 Martin Baulig <martin@ximian.com>
3383 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3384 we're not attempting to use an indexer. Fixes #52154.
3386 2004-04-27 Martin Baulig <martin@ximian.com>
3388 * statement.cs (Return): Don't create a return label if we don't
3389 need it; reverts my change from January 20th. Thanks to Ben
3392 2004-04-27 Martin Baulig <martin@ximian.com>
3394 According to the spec, `goto' can only leave a nested scope, but
3397 * statement.cs (Block.LookupLabel): Only lookup in the current
3398 block, don't recurse into parent or child blocks.
3399 (Block.AddLabel): Check in parent and child blocks, report
3400 CS0140/CS0158 if we find a duplicate.
3401 (Block): Removed this indexer for label lookups.
3402 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3403 this already does the error reporting for us.
3406 (FlowBranching.UsageVector.Block): New public variable; may be null.
3407 (FlowBranching.CreateSibling): Added `Block' argument.
3408 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3409 label for the target of a `goto' and check whether we're not
3410 leaving a `finally'.
3412 2004-04-27 Martin Baulig <martin@ximian.com>
3414 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3415 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3418 2004-04-27 Martin Baulig <martin@ximian.com>
3420 * statement.cs (Block.AddLabel): Also check for implicit blocks
3421 and added a CS0158 check.
3423 2004-04-27 Martin Baulig <martin@ximian.com>
3425 * flowanalysis.cs (FlowBranchingLoop): New class.
3426 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3427 UsageVector's instead of an ArrayList.
3428 (FlowBranching.Label): Likewise.
3429 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3430 (FlowBranching.AddBreakVector): New method.
3432 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3434 * attribute.cs: Small regression fix: only convert the type if we
3435 the type is different, fixes System.Drawing build.
3437 2004-04-27 Martin Baulig <martin@ximian.com>
3439 * attribute.cs (Attribute.Resolve): If we have a constant value
3440 for a named field or property, implicity convert it to the correct
3443 2004-04-27 Raja R Harinath <rharinath@novell.com>
3445 * statement.cs (Block.Block): Implicit blocks share
3446 'child_variable_names' fields with parent blocks.
3447 (Block.AddChildVariableNames): Remove.
3448 (Block.AddVariable): Mark variable as "used by a child block" in
3449 every surrounding block.
3450 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3451 been used in a child block, complain about violation of "Invariant
3452 meaning in blocks" rule.
3453 * cs-parser.jay (declare_local_variables): Don't use
3454 AddChildVariableNames.
3455 (foreach_statement): Don't create an implicit block: 'foreach'
3458 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3460 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3461 converting from 0L to ulong. Fixes 57522.
3463 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3465 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3466 derived class hides via 'new' keyword field from base class (test-242.cs).
3467 TODO: Handle this in the more general way.
3469 * class.cs (CheckBase): Ditto.
3471 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3473 * decl.cs (caching_flags): New member for storing cached values
3475 (MemberCore.Flags): New enum where bit flags for caching_flags
3477 (MemberCore.cls_compliance): Moved to caching_flags.
3478 (DeclSpace.Created): Moved to caching_flags.
3480 * class.cs: Use caching_flags instead of DeclSpace.Created
3482 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3484 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3485 if we are only a derived class, not a nested class.
3487 * typemanager.cs: Same as above, but do this at the MemberLookup
3488 level (used by field and methods, properties are handled in
3489 PropertyExpr). Allow for the qualified access if we are a nested
3492 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3494 * class.cs: Refactoring.
3495 (IMethodData): New inteface; Holds links to parent members
3496 to avoid member duplication (reduced memory allocation).
3497 (Method): Implemented IMethodData interface.
3498 (PropertyBase): New inner classes for get/set methods.
3499 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3500 (Event): New inner classes for add/remove methods.
3501 (Event.DelegateMethod): Implemented IMethodData interface.
3503 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3504 EmitContext (related to class.cs refactoring).
3506 2004-04-21 Raja R Harinath <rharinath@novell.com>
3508 * delegate.cs (Delegate.VerifyApplicability): If the number of
3509 arguments are the same as the number of parameters, first try to
3510 verify applicability ignoring any 'params' modifier on the last
3514 2004-04-16 Raja R Harinath <rharinath@novell.com>
3516 * class.cs (TypeContainer.AddIndexer): Use
3517 'ExplicitInterfaceName' to determine if interface name was
3518 explicitly specified. 'InterfaceType' is not initialized at this time.
3519 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3520 Indexers array is already in the required order. Initialize
3521 'IndexerName' only if there are normal indexers.
3522 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3523 (TypeContainer.Emit): Emit DefaultMember attribute only if
3524 IndexerName is initialized.
3527 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3529 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3532 2004-04-15 Raja R Harinath <rharinath@novell.com>
3534 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3538 * attribute.cs (Attribute.Resolve): Check for duplicate named
3542 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3544 * iterators.cs (MarkYield): track whether we are in an exception,
3545 and generate code accordingly. Use a temporary value to store the
3546 result for our state.
3548 I had ignored a bit the interaction of try/catch with iterators
3549 since their behavior was not entirely obvious, but now it is
3550 possible to verify that our behavior is the same as MS .NET 2.0
3554 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3556 * iterators.cs: Avoid creating temporaries if there is no work to
3559 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3560 Enumerations, use TypeManager.EnumToUnderlying and call
3563 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3566 (This.Emit): Use EmitContext.EmitThis to emit our
3569 (This.EmitAssign): Ditto.
3571 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3572 codepaths, we will move all the functionality into
3575 (FieldExpr.EmitAssign): Ditto.
3577 This fixes several hidden bugs that I uncovered while doing a code
3578 review of this today.
3580 * codegen.cs (EmitThis): reworked so the semantics are more clear
3581 and also support value types "this" instances.
3583 * iterators.cs: Changed so that for iterators in value types, we
3584 do not pass the value type as a parameter.
3586 Initialization of the enumerator helpers is now done in the caller
3587 instead of passing the parameters to the constructors and having
3588 the constructor set the fields.
3590 The fields have now `assembly' visibility instead of private.
3592 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3594 * expression.cs (Argument.Resolve): Check if fields passed as ref
3595 or out are contained in a MarshalByRefObject.
3597 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3598 another compiler type.
3600 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3602 * class.cs (Indexer.Define): use the new name checking method.
3603 Also, return false on an error.
3604 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3605 (is_identifier_[start/part]_character): make static.
3607 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3609 * expression.cs (Binary.ResolveOperator): Do no append strings
3610 twice: since we can be invoked more than once (array evaluation)
3611 on the same concatenation, take care of this here. Based on a fix
3612 from Ben (bug #56454)
3614 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3616 * codegen.cs: Fix another case where CS1548 must be reported (when
3617 delay-sign isn't specified and no private is available #56564). Fix
3618 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3619 error when MCS is used on the MS runtime and we need to delay-sign
3620 (which seems unsupported by AssemblyBuilder - see #56621).
3622 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3624 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3625 (TypeManager.ComputeNamespaces): Faster implementation for
3628 * compiler.csproj: Updated AssemblyName to mcs.
3630 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3632 * rootcontext.cs: Add new types to the boot resolution.
3634 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3635 MulticastDelegate is not allowed.
3637 * typemanager.cs: Add new types to lookup: System.TypedReference
3640 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3641 check for TypedReference or ArgIterator, they are not allowed.
3643 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3644 makes us properly catch 1510 in some conditions (see bug 56016 for
3647 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3649 * CryptoConvert.cs: update from corlib version
3652 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3654 * class.cs (Indexer.Define): Check indexername declaration
3656 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3658 * attribute.cs (IsClsCompliant): Fixed problem with handling
3659 all three states (compliant, not-compliant, undetected).
3661 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3663 * attribute.cs (Attribute): Location is now public.
3664 (Resolve): Store resolved arguments (pos_values) in attribute class.
3665 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3666 (GetClsCompliantAttributeValue): New method that gets
3667 CLSCompliantAttribute value.
3668 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3669 if exists else null.
3670 (AttributeTester): New class for CLS-Compliant verification routines.
3672 * class.cs (Emit): Add CLS-Compliant verification.
3673 (Method.GetSignatureForError): Implemented.
3674 (Constructor.GetSignatureForError): Implemented
3675 (Constructor.HasCompliantArgs): Returns if constructor has
3676 CLS-Compliant arguments.
3677 (Constructor.Emit): Override.
3678 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3679 is needed to test only parameters.
3680 (FieldBase.GetSignatureForError): Implemented.
3681 (TypeContainer): New member for storing base interfaces.
3682 (TypeContainer.FindMembers): Search in base interfaces too.
3684 * codegen.cs (GetClsComplianceAttribute): New method that gets
3685 assembly or module CLSCompliantAttribute value.
3686 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3688 (ModuleClass.Emit): Add error 3012 test.
3690 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3692 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3693 state for all decl types.
3694 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3695 if CLS-Compliant tests are required.
3696 (IsClsCompliaceRequired): New method. Analyze whether code
3697 must be CLS-Compliant.
3698 (IsExposedFromAssembly): New method. Returns true when MemberCore
3699 is exposed from assembly.
3700 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3701 value or gets cached value.
3702 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3703 is explicitly marked with CLSCompliantAttribute.
3704 (IsIdentifierClsCompliant): New abstract method. This method is
3705 used to testing error 3005.
3706 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3707 for identifier and parameters CLS-Compliant testing.
3708 (VerifyClsCompliance): New method. The main virtual method for
3709 CLS-Compliant verifications.
3710 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3711 null. I don't know why is null (too many public members !).
3712 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3713 and get value of first CLSCompliantAttribute that found.
3715 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3716 (VerifyClsCompliance): Override and add extra tests.
3718 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3719 clscheck- disable CLS-Compliant verification event if assembly is has
3720 CLSCompliantAttribute(true).
3722 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3723 ApllyAttribute is now called in emit section as in the other cases.
3724 Possible future Emit integration.
3725 (IsIdentifierClsCompliant): New override.
3726 (VerifyClsCompliance): New override.
3727 (GetEnumeratorName): Returns full enum name.
3729 * parameter.cs (GetSignatureForError): Implemented.
3731 * report.cs (WarningData): New struct for Warning message information.
3732 (LocationOfPreviousError): New method.
3733 (Warning): New method. Reports warning based on the warning table.
3734 (Error_T): New method. Reports error based on the error table.
3736 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3737 verifications are done here.
3739 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3741 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3742 CLSCompliantAttribute.
3743 (all_imported_types): New member holds all imported types from other
3745 (LoadAllImportedTypes): New method fills static table with exported types
3746 from all referenced assemblies.
3747 (Modules): New property returns all assembly modules.
3749 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3751 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3752 throwing a parser error.
3754 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3755 which removes the hardcoded get_/set_ prefixes for properties, as
3756 IL allows for the properties to be named something else.
3760 * expression.cs: Do not override operand before we know if it is
3763 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3765 * typemanager.cs: support for pinned variables.
3767 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3769 * decl.cs, typemanager.cs: Avoid using an arraylist
3770 as a buffer if there is only one result set.
3772 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3774 * expression.cs: Make sure you cant call a static method
3775 with an instance expression, bug #56174.
3777 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3779 * class.cs (IsDuplicateImplementation): Improve error reporting to
3780 flag 663 (method only differs in parameter modifier).
3782 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3783 in preprocessor directives.
3785 * location.cs (LookupFile): Allow for the empty path.
3787 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3788 better approach for some of that patch, but its failing with the
3789 CharSet enumeration. For now try/catch will do.
3791 * typemanager.cs: Do not crash if a struct does not have fields.
3794 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3796 * expression.cs: cs0213, cant fix a fixed expression.
3799 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3801 * cs-parser.jay: detect invalid embeded statements gracefully.
3804 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3806 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3809 the invocation type may not be a subclass of the tye of the item/
3810 The type of the item must be a subclass of the invocation item.
3815 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3817 * attribute.cs: Added methods to get a string and a bool from an
3818 attribute. Required to information from AssemblyKeyFileAttribute,
3819 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3820 * codegen.cs: Modified AssemblyName creation to include support for
3821 strongnames. Catch additional exceptions to report them as CS1548.
3822 * compiler.csproj: Updated include CryptoConvert.cs.
3823 * compiler.csproj.user: Removed file - user specific configuration.
3824 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3825 Mono.Security assembly. The original class is maintained and tested in
3826 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3827 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3828 like CSC 8.0 (C# v2) supports.
3829 * Makefile: Added CryptoConvert.cs to mcs sources.
3830 * rootcontext.cs: Added new options for strongnames.
3832 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
3834 * driver.cs: For --expect-error, report error code `2'
3835 if the program compiled with no errors, error code `1' if
3836 it compiled with an error other than the one expected.
3838 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
3840 * compiler.csproj: Updated for Visual Studio .NET 2003.
3841 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
3842 * compiler.sln: Updated for Visual Studio .NET 2003.
3844 2004-03-24 Ravi Pratap M <ravi@ximian.com>
3846 * expression.cs: Fix bug #47234. We basically need to apply the
3847 rule that we prefer the conversion of null to a reference type
3848 when faced with a conversion to 'object' (csc behaviour).
3850 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3852 * statement.cs: Shorter form for foreach, eliminates
3853 a local variable. r=Martin.
3855 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3857 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
3858 checks if we can use brtrue/brfalse to test for 0.
3859 * expression.cs: use the above in the test for using brtrue/brfalse.
3862 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3864 * expression.cs: Rewrite string concat stuff. Benefits:
3866 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
3867 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
3868 rather than a concat chain.
3870 * typemanager.cs: Add lookups for more concat overloads.
3872 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
3874 * expression.cs: Emit shorter il code for array init.
3891 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
3893 * statement.cs: Before, two switch blocks would be merged if the
3894 total size of the blocks (end_item - begin_item + 1) was less than
3895 two times the combined sizes of the blocks.
3897 Now, it will only merge if after the merge at least half of the
3902 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
3904 * class.cs : csc build fix for GetMethods(). See bug #52503.
3906 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
3908 * expression.cs: Make sure fp comparisons work with NaN.
3909 This fixes bug #54303. Mig approved this patch a long
3910 time ago, but we were not able to test b/c the runtime
3913 2004-03-19 Miguel de Icaza <miguel@ximian.com>
3915 * ecore.cs (TypExpr.GetHashCode): implement this overload.
3917 2004-03-19 Martin Baulig <martin@ximian.com>
3919 * class.cs (MemberCore.IsDuplicateImplementation): Report the
3920 error here and not in our caller.
3922 2004-03-19 Martin Baulig <martin@ximian.com>
3924 * interface.cs: Completely killed this file.
3925 (Interface): We're now a TypeContainer and live in class.cs.
3927 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
3928 argument; we're now also called for interfaces.
3929 (TypeContainer.DefineMembers): Allow this method being called
3931 (TypeContainer.GetMethods): New public method; formerly known as
3932 Interface.GetMethod(). This is used by PendingImplementation.
3933 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
3934 it's now private and non-static.
3935 (Interface): Moved this here; it's now implemented similar to
3937 (Method, Property, Event, Indexer): Added `bool is_interface'
3938 argument to their .ctor's.
3939 (MemberBase.IsInterface): New public field.
3941 * cs-parser.jay: Create normal Method, Property, Event, Indexer
3942 instances instead of InterfaceMethod, InterfaceProperty, etc.
3943 (opt_interface_base): Removed; we now use `opt_class_base' instead.
3944 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
3946 2004-03-19 Martin Baulig <martin@ximian.com>
3948 * class.cs (MethodCore.IsDuplicateImplementation): New private
3949 method which does the CS0111 checking.
3950 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
3951 Use IsDuplicateImplementation().
3953 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
3955 * decl.cs (FindMemberToOverride): New method to find the correct
3956 method or property to override in the base class.
3958 - Make Method/Property use the above method to find the
3959 version in the base class.
3960 - Remove the InheritableMemberSignatureCompare as it is now
3963 This patch makes large code bases much faster to compile, as it is
3964 O(n) rather than O(n^2) to do this validation.
3966 Also, it fixes bug 52458 which is that nested classes are not
3967 taken into account when finding the base class member.
3969 Reviewed/Approved by Martin.
3971 2004-03-17 Marek Safar <marek.safar@seznam.cz>
3973 * interface.cs: In all interface classes removed redundant
3974 member initialization.
3976 2004-03-16 Martin Baulig <martin@ximian.com>
3978 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
3980 2004-03-15 Miguel de Icaza <miguel@ximian.com>
3982 * decl.cs (DefineTypeAndParents): New helper method to define a
3983 type's containers before the type itself is defined; This is a
3984 bug exposed by the recent changes to Windows.Forms when an
3985 implemented interface was defined inside a class that had not been
3988 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
3990 (Check): Loop correctly to report errors modifiers
3991 (UNSAFE was not in the loop, since it was the same as TOP).
3993 * interface.cs: Every interface member now takes a ModFlags,
3994 instead of a "is_new" bool, which we set on the base MemberCore.
3996 Every place where we called "UnsafeOk" in the interface, now we
3997 call the proper member (InterfaceMethod.UnsafeOK) instead to get
3998 the unsafe settings from the member declaration instead of the
3999 container interface.
4001 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4003 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4004 `set_indexer_name' to the pending bits (one per type).
4006 We fixed a bug today that was picking the wrong method to
4007 override, since for properties the existing InterfaceMethod code
4008 basically ignored the method name. Now we make sure that the
4009 method name is one of the valid indexer names.
4011 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4013 * support.cs (SeekableStreamReader): Keep track of stream byte
4014 positions and don't mix them with character offsets to the buffer.
4016 Patch from Gustavo Giráldez
4018 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4020 * interface.cs (InterfaceSetGetBase): Removed double member
4021 initialization, base class does it as well.
4023 2004-03-13 Martin Baulig <martin@ximian.com>
4025 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4026 when compiling corlib.
4028 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4030 * convert.cs (ExplicitConversion): We were reporting an error on
4031 certain conversions (object_type source to a value type, when the
4032 expression was `null') before we had a chance to pass it through
4033 the user defined conversions.
4035 * driver.cs: Replace / and \ in resource specifications to dots.
4038 * class.cs: Add check for duplicate operators. Fixes 52477
4040 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4042 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4043 that are in the middle of the statements, not only at the end.
4046 * class.cs (TypeContainer.AddField): No longer set the
4047 `HaveStaticConstructor' flag, now we call it
4048 `UserDefineStaticConstructor' to diferentiate the slightly
4049 semantic difference.
4051 The situation is that we were not adding BeforeFieldInit (from
4052 Modifiers.TypeAttr) to classes that could have it.
4053 BeforeFieldInit should be set to classes that have no static
4058 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4060 And most importantly Zoltan's comment:
4062 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4064 "I think beforefieldinit means 'it's ok to initialize the type sometime
4065 before its static fields are used', i.e. initialization does not need
4066 to be triggered by the first access to the type. Setting this flag
4067 helps the JIT to compile better code, since it can run the static
4068 constructor at JIT time, and does not need to generate code to call it
4069 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4070 this flag for lots of classes like String.
4072 csc sets this flag if the type does not have an explicit static
4073 constructor. The reasoning seems to be that if there are only static
4074 initalizers for a type, and no static constructor, then the programmer
4075 does not care when this initialization happens, so beforefieldinit
4078 This bug prevents the AOT compiler from being usable, since it
4079 generates so many calls to mono_runtime_class_init that the AOT code
4080 is much slower than the JITted code. The JITted code is faster,
4081 because it does not generate these calls if the vtable is type is
4082 already initialized, which is true in the majority of cases. But the
4083 AOT compiler can't do this."
4085 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4087 * class.cs (MethodData.Emit): Refactor the code so symbolic
4088 information is generated for destructors; For some reasons we
4089 were taking a code path that did not generate symbolic information
4092 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4094 * class.cs: Create a Constructor.CheckBase method that
4095 takes care of all validation type code. The method
4096 contains some code that was moved from Define.
4098 It also includes new code that checks for duplicate ctors.
4099 This fixes bug #55148.
4101 2004-03-09 Joshua Tauberer <tauberer@for.net>
4103 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4104 a { ... }-style array creation invokes EmitStaticInitializers
4105 which is not good for reference-type arrays. String, decimal
4106 and now null constants (NullCast) are not counted toward
4107 static initializers.
4109 2004-03-05 Martin Baulig <martin@ximian.com>
4111 * location.cs (SourceFile.HasLineDirective): New public field;
4112 specifies whether the file contains or is referenced by a "#line"
4114 (Location.DefineSymbolDocuments): Ignore source files which
4115 either contain or are referenced by a "#line" directive.
4117 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4119 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4120 direct access to our parent, so check the method inline there.
4122 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4124 * expression.cs (Invocation.EmitCall): Miguel's last commit
4125 caused a regression. If you had:
4130 In Foo the implict this would be null.
4132 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4134 * expression.cs (Invocation.EmitCall): If the method is not
4135 virtual, do not emit a CallVirt to it, use Call.
4137 * typemanager.cs (GetFullNameSignature): Improve the method to
4138 cope with ".ctor" and replace it with the type name.
4140 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4141 as an argument the ConstructorBuilder where it is being defined,
4142 to catch the recursive constructor invocations.
4144 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4146 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4147 routines to check if a type is an enumerable/enumerator allow
4148 classes that implement the IEnumerable or IEnumerator interfaces.
4150 * class.cs (Property, Operator): Implement IIteratorContainer, and
4151 implement SetYields.
4153 (Property.Define): Do the block swapping for get_methods in the
4154 context of iterators. We need to check if Properties also
4155 include indexers or not.
4157 (Operator): Assign the Block before invoking the
4158 OperatorMethod.Define, so we can trigger the Iterator code
4161 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4162 Property and Operator classes are not created when we parse the
4163 declarator but until we have the block completed, so we use a
4164 singleton SimpleIteratorContainer.Simple to flag whether the
4165 SetYields has been invoked.
4167 We propagate this setting then to the Property or the Operator to
4168 allow the `yield' to function.
4170 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4172 * codegen.cs: Implemented attribute support for modules.
4173 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4174 Assembly/Module functionality.
4176 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4177 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4178 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4180 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4182 * interface.cs (FindMembers): The operation is performed on all base
4183 interfaces and not only on the first. It is required for future CLS Compliance patch.
4185 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4187 * statement.cs, codegen.cs:
4188 This patch deals with patterns such as:
4190 public class List : IEnumerable {
4192 public MyEnumerator GetEnumerator () {
4193 return new MyEnumerator(this);
4196 IEnumerator IEnumerable.GetEnumerator () {
4200 public struct MyEnumerator : IEnumerator {
4205 Before, there were a few things we did wrong:
4206 1) we would emit callvirt on a struct, which is illegal
4207 2) we emited ldarg when we needed to emit ldarga
4208 3) we would mistakenly call the interface methods on an enumerator
4209 type that derived from IEnumerator and was in another assembly. For example:
4211 public class MyEnumerator : IEnumerator
4213 Would have the interface methods called, even if there were public impls of the
4214 method. In a struct, this lead to invalid IL code.
4216 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4218 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4221 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4223 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4225 * cs-parser.jay: Fix small regression: we were not testing V2
4226 compiler features correctly.
4228 * interface.cs: If the emit context is null, then create one
4230 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4232 * decl.cs (GetSignatureForError): New virtual method to get full name
4235 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4236 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4238 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4239 Duplicated members and code in these classes has been removed.
4240 Better encapsulation in these classes.
4242 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4244 * assign.cs (Assign.DoResolve): When dealing with compound
4245 assignments, there is a new rule in ECMA C# 2.4 (might have been
4246 there before, but it is documented here) that states that in:
4250 If b is of type int, and the `op' is a shift-operator, then the
4251 above is evaluated as:
4255 * expression.cs (Binary.ResolveOperator): Instead of testing for
4256 int/uint/long/ulong, try to implicitly convert to any of those
4257 types and use that in pointer arithmetic.
4259 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4260 method to print information for from the type, not from the
4261 null-method we were given.
4263 2004-02-01 Duncan Mak <duncan@ximian.com>
4265 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4266 parsing for cmd, fixes bug #53694.
4268 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4270 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4271 in the member name duplication tests. Property and operator name duplication
4272 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4274 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4276 * interface.cs (PopulateMethod): Fixed crash when interface method
4277 returns not existing type (error test cs0246-3.cs).
4279 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4281 * cs-parser.jay (interface_accessors): Re-write actions to also
4282 store attributes attached to get and set methods. Fix spelling
4285 (inteface_property_declaration): Modify accordingly.
4287 (InterfaceAccessorInfo): New helper class to store information to pass
4288 around between rules that use interface_accessors.
4290 * interface.cs (Emit): Apply attributes on the get and set
4291 accessors of properties and indexers too.
4293 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4294 right MethodBuilder when applying attributes to the get and set accessors.
4296 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4298 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4300 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4302 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4304 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4306 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4307 changes that treat `yield' specially when present before `break'
4310 * cs-tokenizer.cs: yield is no longer a keyword.
4312 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4314 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4315 setting for default constructors.
4316 For default constructors are almost every time set wrong Modifier. The
4317 generated IL code has been alright. But inside mcs this values was
4318 wrong and this was reason why several of my CLS Compliance tests
4321 2004-01-22 Martin Baulig <martin@ximian.com>
4323 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4324 not a QualifiedIdentifier. This is what `type_name_expression'
4325 was previously doing.
4326 (type_name_expression): Removed; the code is now in
4327 `namespace_or_type_name'.
4328 (qualified_identifier): Removed, use `namespace_or_type_name'
4330 (QualifiedIdentifier): Removed this class.
4332 2004-01-22 Martin Baulig <martin@ximian.com>
4334 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4335 not a string as alias name.
4337 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4339 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4340 #52730 bug, and instead compute correctly the need to use a
4341 temporary variable when requesting an address based on the
4342 static/instace modified of the field and the constructor.
4344 2004-01-21 Martin Baulig <martin@ximian.com>
4346 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4347 class and namespace before looking up aliases. Fixes #52517.
4349 2004-01-21 Martin Baulig <martin@ximian.com>
4351 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4352 assinged in a 'try'; fixes exception4.cs.
4354 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4355 * class.cs : Implemented parameter-less constructor for TypeContainer
4357 * decl.cs: Attributes are now stored here. New property OptAttributes
4359 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4361 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4363 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4365 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4366 (CSharpSignature): New method for indexer and property signature.
4368 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4370 * pending.cs (IsVirtualFilter): Faster implementation.
4372 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4374 * typemanager.cs: Avoid inclusion of same assembly more than once.
4376 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4378 * cs-parser.jay: Fixed problem where the last assembly attribute
4379 has been applied also to following declaration (class, struct, etc.)
4381 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4383 * class.cs: Added error CS0538, CS0539 reporting.
4384 Fixed crash on Microsoft runtime when field type is void.
4386 * cs-parser.jay: Added error CS0537 reporting.
4388 * pending.cs: Added error CS0535 reporting.
4389 Improved error report for errors CS0536, CS0534.
4391 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4393 Merge a few bits from the Anonymous Method MCS tree.
4395 * statement.cs (ToplevelBlock): New class for toplevel methods,
4396 will hold anonymous methods, lifted variables.
4398 * cs-parser.jay: Create toplevel blocks for delegates and for
4399 regular blocks of code.
4401 2004-01-20 Martin Baulig <martin@ximian.com>
4403 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4404 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4405 and `NeedExplicitReturn'; added `IsLastStatement'.
4406 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4407 have a `ReturnLabel' or we're not unreachable.
4409 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4410 child's reachability; don't just override ours with it. Fixes
4411 #58058 (lluis's example).
4412 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4413 InFinally(), InLoop(), InSwitch() and
4414 BreakCrossesTryCatchBoundary() methods.
4416 * statement.cs (Return): Do all error checking in Resolve().
4417 Unless we are the last statement in a top-level block, always
4418 create a return label and jump to it.
4419 (Break, Continue): Do all error checking in Resolve(); also make
4420 sure we aren't leaving a `finally'.
4421 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4422 statement in a top-level block.
4423 (Block.Flags): Added `IsDestructor'.
4424 (Block.IsDestructor): New public property.
4426 2004-01-20 Martin Baulig <martin@ximian.com>
4428 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4430 2004-01-20 Martin Baulig <martin@ximian.com>
4432 * statement.cs (Statement.ResolveUnreachable): New public method.
4433 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4434 (Block.Resolve): Resolve unreachable statements.
4436 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4438 * expression.cs: We need to fix the case where we do
4439 not have a temp variable here.
4441 * assign.cs: Only expression compound assignments need
4442 temporary variables.
4444 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4446 * flowanalysis.cs: Reduce memory allocation in a few ways:
4447 - A block with no variables should not allocate a bit
4449 - A method with no out parameters does not need any tracking
4450 for assignment of the parameters, so we need not allocate
4453 public readonly Type[] VariableTypes;
4454 public readonly string[] VariableNames;
4455 Are redundant. The data is already stored in the variable
4456 map, so we need not allocate another array for it.
4457 - We need to add alot of checks for if (params | locals) == null
4458 due to the first two changes.
4460 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4462 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4463 implement IMemoryLocation, we store a copy on a local variable and
4464 take the address of it. Patch from Benjamin Jemlich
4466 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4467 to use a special "type_name_expression" rule which reduces the
4468 number of "QualifiedIdentifier" classes created, and instead
4469 directly creates MemberAccess expressions.
4471 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4473 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4474 that fixes #52853. Null literal assignment to ValueType
4476 * class.cs (MethodData.Emit): Instead of checking the name of the
4477 method to determine if its a destructor, create a new derived
4478 class from Method called Destructor, and test for that.
4480 * cs-parser.jay: Create a Destructor object instead of a Method.
4482 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4486 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4488 * expression.cs (Binary.ResolveOperator): Perform an implicit
4489 conversion from MethodGroups to their delegate types on the
4492 * delegate.cs: Introduce a new class DelegateCreation that is the
4493 base class for `NewDelegate' and `ImplicitDelegateCreation',
4494 factor some code in here.
4496 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4497 conversion from MethodGroups to compatible delegate types.
4499 * ecore.cs (Expression.Resolve): Do not flag error 654
4500 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4501 we allow conversions from MethodGroups to delegate types now.
4503 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4504 assignments in v2 either.
4506 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4508 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4509 static read-only fields in ctors.
4511 Applied patch from Benjamin Jemlich
4513 * expression.cs (UnaryMutator): Avoid leaking local variables.
4515 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4517 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4518 here to return true, as they can be used like this:
4522 Fixed 49836 and all the other dups
4524 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4526 * driver.cs: Implement /win32res and /win32icon.
4528 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4530 * cs-parser.jay: Add a rule to improve error handling for the
4531 common mistake of placing modifiers after the type.
4533 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4535 * cs-parser.jay (interface_event_declaration): Catch
4536 initialization of events on interfaces, and report cs0068
4538 * cs-parser.jay (interface_event_declaration): Catch
4539 initialization of events.
4541 * ecore.cs: Better report missing constructors.
4543 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4544 the error reporting done in the wrong place. Fix.
4546 * expression.cs (Binary.ResolveOperator): Catch the
4547 operator + (E x, E y) error earlier, and later allow for implicit
4548 conversions in operator +/- (E e, U x) from U to the underlying
4551 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4552 52596, if the container class is abstract, the default constructor
4553 is protected otherwise its public (before, we were always public).
4555 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4558 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4559 Jemlich that fixes bug #52597, MCS was generating invalid code for
4560 idisposable structs. Thanks to Ben for following up with this
4563 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4565 * driver.cs: Allow assemblies without code to be generated, fixes
4568 2004-01-07 Nick Drochak <ndrochak@gol.com>
4570 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4572 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4574 * cs-parser.jay: Add rules to improve error reporting if fields or
4575 methods are declared at the namespace level (error 116)
4577 * Add rules to catch event add/remove
4579 2004-01-04 David Sheldon <dave-mono@earth.li>
4581 * expression.cs: Added matching ")" to error message for
4584 2004-01-03 Todd Berman <tberman@gentoo.org>
4586 * ecore.cs, attribute.cs:
4587 Applying fix from #52429.
4589 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4591 * ecore.cs, expression.cs, statement.cs:
4592 Total rewrite of how we handle branching. We
4593 now handle complex boolean expressions with fewer
4594 jumps. As well if (x == 0) no longer emits a ceq.
4596 if (x is Foo) is much faster now, because we generate
4599 Overall, we get a pretty big improvement on our benchmark
4600 tests. The code we generate is smaller and more readable.
4602 I did a full two-stage bootstrap. The patch was reviewed
4603 by Martin and Miguel.
4605 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4607 * cs-parser.jay: Make primary_expression not take a QI.
4608 we dont need this because the member_access rule covers
4609 us here. So we replace the rule with just IDENTIFIER.
4611 This has two good effects. First, we remove a s/r conflict.
4612 Second, we allocate many fewer QualifiedIdentifier objects.
4614 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4616 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4617 set the correct information via SRE. This prevents
4618 hanging on the MS runtime. Fixes #29374.
4620 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4622 * convert.cs: correctly handle conversions to value types
4623 from Enum and ValueType as unboxing conversions.
4625 Fixes bug #52569. Patch by Benjamin Jemlich.
4627 2004-01-02 Ravi Pratap <ravi@ximian.com>
4629 * expression.cs (BetterConversion): Prefer int -> uint
4630 over int -> ulong (csc's behaviour). This fixed bug #52046.
4632 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4634 * decl.cs (MemberCache.FindMembers): now returns a
4637 * typemanager.cs: In general, go with with ^^.
4638 (CopyNewMethods): take an IList.
4639 (RealMemberLookup): Only allocate an arraylist
4640 if we copy from two sets of methods.
4642 This change basically does two things:
4643 1) Fewer array lists allocated due to CopyNewMethods.
4644 2) the explicit cast in MemberList costed ALOT.
4646 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4648 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4649 a hashtable to avoid needless string allocations when an identifier is
4650 used more than once (the common case).
4652 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4654 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4655 is broken, it will not return anything. So, we
4656 have to use the information we have in mcs to
4659 * typemanager.cs: Add a cache for GetInterfaces,
4660 since this will now be used more often (due to ^^)
4662 (GetExplicitInterfaces) New method that gets the
4663 declared, not effective, interfaces on a type
4664 builder (eg, if you have interface IFoo, interface
4665 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4668 This patch makes MCS able to bootstrap itself on
4671 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4673 * expression.cs: Remove the Nop's that Miguel put
4676 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4678 * report.cs, codegen.cs: Give the real stack trace to
4679 the error when an exception is thrown.
4681 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4683 * decl.cs: only allocate hashtables for ifaces if
4686 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4688 * expression.cs: fix the error from cs0121-2.cs
4689 (a parent interface has two child interfaces that
4690 have a function with the same name and 0 params
4691 and the function is called through the parent).
4693 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4695 * class.cs, rootcontext.cs, typmanager.cs: do not
4698 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4700 * codegen.cs: remove stack for the ec flow branching.
4701 It is already a linked list, so no need.
4703 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4705 * Makefile: Allow custom profiler here.
4707 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4709 * typemanager.cs (LookupType):
4710 - Use a static char [], because split takes
4711 a param array for args, so it was allocating
4713 - Do not store true in a hashtable, it boxes.
4715 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4717 * flowanalysis.cs: bytify common enums.
4719 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4721 * modifiers.cs: Add a new set of flags for the
4722 flags allowed on explicit interface impls.
4723 * cs-parser.jay: catch the use of modifiers in
4724 interfaces correctly.
4725 * class.cs: catch private void IFoo.Blah ().
4727 All related to bug #50572.
4729 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4731 * decl.cs: Rewrite the consistant accessability checking.
4732 Accessability is not linear, it must be implemented in
4733 a tableish way. Fixes #49704.
4735 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4737 * expression.cs: Handle negation in a checked context.
4738 We must use subtraction from zero. Fixes #38674.
4740 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4742 * class.cs: Ignore static void main in DLLs.
4743 * rootcontext.cs: Handle the target type here,
4744 since we are have to access it from class.cs
4745 * driver.cs: account for the above.
4747 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4749 * report.cs: Give line numbers and files if available.
4751 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
4753 * driver.cs: Implement /addmodule.
4755 * typemanager.cs: Change 'modules' field so it now contains Modules not
4758 2003-12-20 Martin Baulig <martin@ximian.com>
4760 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
4761 (FieldBase.IsAssigned): Removed this field.
4762 (FieldBase.SetAssigned): New public method.
4763 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
4765 2003-12-20 Martin Baulig <martin@ximian.com>
4767 * expression.cs (LocalVariableReference.DoResolve): Don't set
4768 `vi.Used' if we're called from DoResolveLValue().
4770 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
4771 returns the usage vector it just merged into the current one -
4772 pass this one to UsageWarning().
4773 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
4774 of the `EmitContext', don't call this recursively on our children.
4776 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
4778 * driver.cs: Implement /target:module.
4780 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
4782 * support.cs (CharArrayHashtable): New helper class.
4784 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
4785 char arrays, not strings, so we can avoid creating a string in
4786 consume_identifier if the identifier is a keyword.
4788 2003-12-16 Martin Baulig <martin@ximian.com>
4790 * statement.cs (LocalInfo.Assigned): Removed this property.
4791 (LocalInfo.Flags): Removed `Assigned'.
4792 (LocalInfo.IsAssigned): New public method; takes the EmitContext
4793 and uses flow analysis.
4794 (Block.UsageWarning): Made this method private.
4795 (Block.Resolve): Call UsageWarning() if appropriate.
4797 * expression.cs (LocalVariableReference.DoResolve): Always set
4798 LocalInfo.Used here.
4800 2003-12-13 Martin Baulig <martin@ximian.com>
4802 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
4803 any value here; we're now using flow analysis to figure out
4804 whether a statement/block returns a value.
4806 2003-12-13 Martin Baulig <martin@ximian.com>
4808 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
4810 (FlowBranching.MergeFinally): Don't call
4811 `branching.CheckOutParameters()' here, this is called in
4813 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
4814 when adding the `finally' vector.
4816 2003-12-13 Martin Baulig <martin@ximian.com>
4819 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
4820 actually work and also fix #48962.
4822 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
4824 * decl.cs: Do not check System.Object for nested types,
4825 since we know it does not have any. Big bang for buck:
4830 corlib: 17.99 seconds
4834 corlib: 17.39 seconds
4836 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
4838 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
4839 time we are returning 0 members, so we save alot here.
4841 2003-12-11 Martin Baulig <martin@ximian.com>
4843 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
4844 `MergeChild()', also just take the `FlowBranching' as argument;
4845 call Merge() on it and return the result.
4846 (FlowBranching.Merge): We don't need to do anything if we just
4849 2003-12-11 Martin Baulig <martin@ximian.com>
4851 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
4852 them in an `ArrayList' to reduce memory usage. Thanks to Ben
4853 Maurer for this idea.
4855 2003-12-11 Martin Baulig <martin@ximian.com>
4857 * flowanalysis.cs (MergeResult): This class is now gone; we now
4858 use the `UsageVector' for this. The reason for this is that if a
4859 branching just has one sibling, we don't need to "merge" them at
4860 all - that's the next step to do.
4861 (FlowBranching.Merge): We now return a `UsageVector' instead of a
4864 2003-12-11 Martin Baulig <martin@ximian.com>
4866 Reworked flow analyis and made it more precise and bug-free. The
4867 most important change is that we're now using a special `Reachability'
4868 class instead of having "magic" meanings of `FlowReturns'. I'll
4869 do some more cleanups and optimizations and also add some more
4870 documentation this week.
4872 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
4873 largely reworked this class.
4874 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
4875 the new `Reachability' class instead of having "magic" values here.
4876 (FlowBranching): We're now using an instance of `Reachability'
4877 instead of having separate `Returns', `Breaks' etc. fields.
4879 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
4880 based on flow analysis; ignore the return value of block.Emit ().
4882 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
4884 * driver.cs typemanager.cs: Find the mono extensions to corlib even
4885 if they are private.
4887 2003-12-09 Martin Baulig <martin@ximian.com>
4889 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
4890 call them directly on the UsageVector.
4892 2003-12-09 Martin Baulig <martin@ximian.com>
4894 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
4895 Changed return type from `FlowReturns' to `Reachability'.
4897 2003-12-09 Martin Baulig <martin@ximian.com>
4899 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
4900 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
4901 `Reachable' fields with a single `Reachability' one.
4903 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4905 * class.cs (FindMembers): Remove foreach's.
4918 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4923 This patch does a few things:
4924 1. EmptyStatement is now a singleton, so it is never reallocated.
4925 2. All blah is EmptyStatement constructs have been changed to
4926 blah == EmptyStatement.Value, which is much faster and valid
4927 now that EmptyStatement is a singleton.
4928 3. When resolving a block, rather than allocating a new array for
4929 the non-empty statements, empty statements are replaced with
4930 EmptyStatement.Value
4931 4. Some recursive functions have been made non-recursive.
4932 Mainly the performance impact is from (3), however (1) and (2) are needed for
4933 this to work. (4) does not make a big difference in normal situations, however
4934 it makes the profile look saner.
4939 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4940 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
4941 Total memory allocated: 56397 KB
4944 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
4945 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
4946 Total memory allocated: 55666 KB
4948 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4950 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
4951 than the hashtable in a hashtable version
4953 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
4954 we always end up concating a string. This results in a huge perf
4955 loss, because many strings have to be tracked by the GC. In this
4956 patch, we first use a hashtable that works with two keys, so that
4957 the strings do not need to be concat'ed.
4968 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
4970 * Makefile: Add a new target `do-time' that does a quick and simple
4971 profile, leaving easy to parse output.
4973 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
4975 * codegen.cs (Init): Create the dynamic assembly with
4976 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
4978 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
4980 * support.cs: Make the PtrHashtable use only one
4981 instance of its comparer.
4983 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
4985 * typemanager.cs: Fix lookup of GetNamespaces.
4987 2003-11-29 Miguel de Icaza <miguel@ximian.com>
4989 * expression.cs: Removed redundant line.
4991 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
4992 ArrayLists, use for loops with bounds.
4994 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
4997 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
4998 arraylists, use for loop with bounds.
5000 The above three changes give us a 0.071 second performance
5001 improvement out of 3.294 seconds down to 3.223. On my machine
5002 the above changes reduced the memory usage by 1,387 KB during
5005 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5006 QualifiedIdentifiers. Before we created a new string through
5007 concatenation, and mostly later on, the result would be
5008 manipulated by DecomposeQI through string manipulation.
5010 This reduced the compiler memory usage for bootstrapping from
5011 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5012 compile times in 0.05 seconds.
5014 2003-11-28 Dick Porter <dick@ximian.com>
5016 * support.cs: Do string compares with the Invariant culture.
5024 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5025 the comparison is done with the Invariant culture.
5027 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5029 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5030 GetEnumerator method.
5032 (ProbeCollectionType): Iterate starting at the most specific type
5033 upwards looking for a GetEnumerator
5035 * expression.cs: Shift count can be up to 31 for int/uint and 63
5038 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5040 * statement.cs (Block.LookupLabel): Also look for the label on the
5041 children blocks. Use a hash table to keep track of visited
5044 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5045 we actually did transform the other operand, otherwise fall back
5046 to the common codepath that casts to long.
5048 * cs-tokenizer.cs: Use the same code pattern as the int case.
5049 Maybe I should do the parsing myself, and avoid depending on the
5050 Parse routines to get this done.
5052 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5054 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5055 which fixes bug 51347. This time test it.
5057 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5058 attributes for example can not tell the difference between these.
5059 The difference was only a syntax feature of the language.
5061 * attribute.cs: Apply attributes to delegates.
5063 * delegate.cs: Call the apply attributes method.
5065 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5067 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5068 comparing 0 vs Byte.MinValue, not the value
5070 (ImplicitConversionRequired): When reporting a conversion error,
5071 use error 31 to print out the constant error instead of the
5074 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5075 which fixes bug 51347.
5077 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5079 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5080 which fixes the -warnaserror command line option.
5082 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5084 * cfold.cs (DoNumericPromotions): During constant folding of
5085 additions on UIntConstant, special case intconstants with
5086 IntConstants like we do on the expression binary operator.
5088 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5090 * convert.cs (ImplicitReferenceConversion): We were missing a case
5091 (System.Enum are not value types or class types, so we need to
5092 classify them separatedly).
5094 * driver.cs: We do not support error 2007.
5096 2003-11-12 Jackson Harper <jackson@ximian.com>
5098 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5099 system directory. Also use the full file name so users can
5100 libraries names mscorlib-o-tron.dll in a non system dir.
5102 2003-11-10 Martin Baulig <martin@ximian.com>
5104 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5105 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5106 calling `ResolveType()' on them, directly assign their `Type'.
5108 2003-11-08 Martin Baulig <martin@ximian.com>
5110 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5111 return value and the `out parent' parameter.
5112 (TypeContainer.DefineType): Moved the CS0644 check into
5113 GetClassBases(). Don't pass the interface types to the
5114 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5115 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5117 * ecore.cs (TypeExpr.IsAttribute): New property.
5118 (TypeExpr.GetInterfaces): New method.
5120 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5121 TypeExpr instead of a Type.
5122 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5123 (Interface.DefineType): Don't pass the interface types to the
5124 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5125 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5127 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5128 instead of a `Type[]'.
5129 (TypeManager.RegisterBuilder): Likewise.
5130 (TypeManager.AddUserInterface): Likewise.
5131 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5132 `Type[]' and also return a `TypeExpr[]'.
5133 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5135 2003-11-08 Martin Baulig <martin@ximian.com>
5137 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5140 2003-11-08 Martin Baulig <martin@ximian.com>
5142 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5143 TypeManager.ResolveExpressionTypes().
5145 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5146 instead of an Expression.
5147 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5148 (TypeExpression): New public class; formerly known as `TypeExpr'.
5150 * expression.cs (ComposedCast): Derive from TypeExpr.
5152 * typemanager.cs (TypeManager.system_*_expr): These are now
5153 TypExpr's instead of Expression's.
5154 (TypeManager.ResolveExpressionTypes): New public static function;
5155 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5158 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5160 * expression.cs (New.DoResolve): Do not dereference value that
5161 might be a null return.
5163 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5164 sure that the constant value has the right type. Fixes an
5165 unreported bug, similar to 50425.
5167 * const.cs (Const.LookupConstantValue): Call
5168 ImplicitStandardConversionExists before doing a conversion to
5169 avoid havng the TypeManager.ChangeType do conversions.
5171 Reduced the number of casts used
5173 (Const.ChangeType): New routine to enable reuse of the constant
5174 type changing code from statement.
5176 * typemanager.cs (ChangeType): Move common initialization to
5177 static global variables.
5181 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5182 every value type to go through, even if it was void. Fix that.
5184 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5185 character of the define, and the is_identifier_part_character for
5186 the rest of the string.
5188 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5190 * expression.cs (UnaryMutator.EmitCode): When I updated
5191 LocalVariableReference.DoResolve, I overdid it, and dropped an
5192 optimization done on local variable references.
5194 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5196 * ecore.cs: Convert the return from Ldlen into an int.
5198 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5200 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5201 the accessibility, this is a special case for toplevel non-public
5202 classes (internal for instance).
5204 2003-10-20 Nick Drochak <ndrochak@gol.com>
5206 * ecore.cs: Fix typo and build. Needed another right paren.
5208 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5210 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5211 `internal' case regular and protected, but not allowing protected
5212 to be evaluated later. Bug 49840
5214 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5216 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5217 to kb.Nlast, and not the kb.nFirst to isolate the switch
5220 Extract the underlying type, so enumerations of long/ulong are
5221 treated like long/ulong.
5223 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5225 * expression.cs (New): Overload the meaning of RequestedType to
5226 track the possible creation of the NewDelegate type, since
5227 DoResolve is invoked more than once for new constructors on field
5230 See bugs: #48800 and #37014
5232 * cs-parser.jay (declare_local_constants): Take an arraylist
5233 instead of a single constant.
5235 (local_constant_declaration): It should take a
5236 constant_declarators, not a constant_declarator. Fixes 49487
5238 * convert.cs: Fix error report.
5240 2003-10-13 Jackson Harper <jackson@ximian.com>
5242 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5245 2003-10-09 Martin Baulig <martin@ximian.com>
5247 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5249 (MethodCore.DoDefineParameters): Removed the TypeContainer
5250 argument; use the DeclSpace which was passed to the .ctor instead.
5251 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5252 TypeContainer; we only need a DeclSpace here.
5254 2003-10-09 Martin Baulig <martin@ximian.com>
5256 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5258 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5259 EmitContext's .ctor.
5261 2003-10-09 Martin Baulig <martin@ximian.com>
5263 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5264 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5265 AsAccessible(), moved them as well.
5267 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5269 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5271 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5273 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5275 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5276 generation for >=, as spotted by Paolo, bug 48679.
5277 Patch from David Waite.
5279 * cs-tokenizer.cs: Add handling for #pragma.
5281 * cs-parser.jay: Allow for both yield and yield return in the
5282 syntax. The anti-cobolization of C# fight will go on!
5284 * class.cs (TypeBuilder.DefineType): Catch error condition here
5285 (Parent.DefineType erroring out and returning null).
5287 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5288 coping with enumerations variables, we were mistakenly processing
5289 them as a regular value type instead of built-in types. Fixes the
5292 * typemanager.cs (IsBuiltinOrEnum): New method.
5294 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5296 * cs-parser.jay: Upgrade: yield now needs the return clause.
5298 2003-09-19 Martin Baulig <martin@ximian.com>
5300 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5301 `MemberCache parent' argument. Normally, an interface doesn't
5302 have a parent type except System.Object, but we use this in gmcs
5303 for generic type parameters.
5305 2003-09-18 Martin Baulig <martin@ximian.com>
5307 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5308 on `type.IsInterface'; don't check whether the type has a parent
5309 to determine whether it's an interface.
5311 2003-09-15 Martin Baulig <martin@ximian.com>
5313 * class.cs (TypeContainer.DefineType): Added an error flag to
5314 avoid reporting duplicate CS0146's ("class definition is
5317 * driver.cs (Driver.MainDriver): Abort if
5318 RootContext.ResolveTree() reported any errors.
5320 2003-09-07 Martin Baulig <martin@ximian.com>
5322 * report.cs (Error, Warning): Added overloaded versions which take
5323 a `params object[] args' and call String.Format().
5325 2003-09-07 Martin Baulig <martin@ximian.com>
5327 * decl.cs (DeclSpace..ctor): Don't call
5328 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5329 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5330 (DeclSpace.RecordDecl): New method.
5332 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5334 2003-09-02 Ravi Pratap <ravi@ximian.com>
5336 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5337 value attributes to be applied to ParameterBuilders.
5339 * class.cs (MethodCore.LabelParameters): Make static and more
5340 generic so that it can be used from other places - like interface
5341 methods, for instance.
5343 * interface.cs (Interface.Emit): Call LabelParameters before
5344 emitting attributes on the InterfaceMethod.
5346 2003-08-26 Martin Baulig <martin@ximian.com>
5348 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5349 resolving aliases; fixes #47927.
5351 2003-08-26 Martin Baulig <martin@ximian.com>
5353 * statement.cs (Using.DoResolve): This is internally emitting a
5354 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5355 do not always return. Fixes #47681.
5357 2003-08-26 Martin Baulig <martin@ximian.com>
5359 * decl.cs (MemberCore): Moved WarningNotHiding(),
5360 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5362 (AdditionResult): Make this nested in DeclSpace.
5363 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5364 argument; call NamespaceEntry.Define() unless we're nested in a
5367 * namespace.cs (Namespace.DefineName): New public function. This
5368 is called from DeclSpace's .ctor to add
5369 (Namespace.Lookup): Include DeclSpaces in the lookup.
5371 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5373 * const.cs (Const): Derive from MemberBase, not MemberCore.
5375 2003-08-25 Martin Baulig <martin@ximian.com>
5377 * convert.cs (Convert.ExplicitReferenceConversion): When
5378 converting from an interface type to a class, unbox if the target
5379 type is a struct type. Fixes #47822.
5381 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5383 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5386 2003-08-22 Martin Baulig <martin@ximian.com>
5388 * class.cs (TypeManager.DefineType): When defining a nested type,
5389 call DefineType() on our parent; fixes #47801.
5391 2003-08-22 Martin Baulig <martin@ximian.com>
5393 * class.cs (MethodData.Define): While checking if a method is an
5394 interface implementation, improve the test a bit more to fix #47654.
5396 2003-08-22 Martin Baulig <martin@ximian.com>
5398 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5399 correctly; fixes #47722.
5401 2003-08-22 Martin Baulig <martin@ximian.com>
5403 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5404 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5406 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5408 2003-08-22 Martin Baulig <martin@ximian.com>
5410 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5411 can only be assigned in static constructors. Fixes #47161.
5413 2003-08-22 Martin Baulig <martin@ximian.com>
5415 Rewrote and improved the flow analysis code.
5417 * flowbranching.cs (FlowBranching): Make this class abstract.
5418 (FlowBranching.CreateBranching): New static function to create a
5420 (FlowBranchingBlock, FlowBranchingException): New classes.
5421 (FlowBranching.UsageVector.Type): New public readonly field.
5422 (FlowBranching.UsageVector.Breaks): Removed the setter.
5423 (FlowBranching.UsageVector.Returns): Removed the setter.
5424 (FlowBranching.UsageVector): Added Break(), Return(),
5425 NeverReachable() and Throw() methods to modify the reachability.
5426 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5427 done by FlowBranching.Merge().
5428 (FlowBranching.UsageVector.MergeChild): New method; merges the
5429 merge result into the current vector.
5430 (FlowBranching.Merge): New abstract method to merge a branching.
5432 2003-08-12 Martin Baulig <martin@ximian.com>
5434 * expression.cs (Indirection.CacheTemporaries): Create the
5435 LocalTemporary with the pointer type, not its element type.
5437 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5439 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5440 token was a keyword or not.
5442 Add `error' options where an IDENTIFIER was expected; Provide
5443 CheckToken and CheckIdentifierToken convenience error reporting
5446 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5448 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5449 NameSpaceEntry NameSpaceEntry.
5451 (LookupInterfaceOrClass): Avoid creating a full qualified name
5452 from namespace and name: avoid doing lookups when we know the
5453 namespace is non-existant. Use new Tree.LookupByNamespace which
5454 looks up DeclSpaces based on their namespace, name pair.
5456 * driver.cs: Provide a new `parser verbose' to display the
5457 exception thrown during parsing. This is turned off by default
5458 now, so the output of a failure from mcs is more graceful.
5460 * namespace.cs: Track all the namespaces defined in a hashtable
5463 (IsNamespace): New method
5465 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5467 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5468 we know that we need to concatenate (full typename can never be
5473 * statement.cs: Use a bitfield; Do not initialize to null things
5474 which are done by the constructor by default.
5476 * cs-parser.jay: bug fix, parameter was 4, not 3.
5478 * expression.cs: Just use the property;
5480 * statement.cs: No need for GetVariableInfo method.
5482 2003-08-08 Martin Baulig <martin@ximian.com>
5484 * flowanalysis.cs (FlowReturns): This is now nested in the
5485 `FlowBranching' class.
5486 (MyBitVector): Moved this here from statement.cs.
5487 (FlowBranching.SiblingType): New enum type.
5488 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5490 2003-08-07 Martin Baulig <martin@ximian.com>
5492 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5493 `FlowBranching' class and called `BranchingType'.
5495 2003-08-07 Martin Baulig <martin@ximian.com>
5497 * flowanalysis.cs: Moved all the control flow analysis code into
5500 2003-08-07 Martin Baulig <martin@ximian.com>
5502 * assign.cs (Assign.DoResolve): `target' must either be an
5503 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5506 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5508 * expression.cs (BinaryMethod): This kind of expression is created by the
5509 Binary class if it determines that the operator has to be handled
5512 (BinaryDelegate): This kind of expression is created if we are
5513 dealing with a + or - operator on delegates.
5515 (Binary): remove method, argumetns, and DelegateOperator: when
5516 dealing with methods,
5518 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5520 * statement.cs (Block): use bitfields for the three extra booleans
5521 we had in use. Remove unused topblock parameter.
5523 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5525 * assign.cs: Drop extra unneeded tests.
5527 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5529 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5531 * statement.cs (Foreach): Use VariableStorage instead of
5534 * codegen.cs (VariableStorage): New class used by clients that
5535 require a variable stored: locals or fields for variables that
5536 need to live across yield.
5538 Maybe provide a convenience api for EmitThis+EmitLoad?
5540 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5543 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5545 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5546 RemapParameterLValue): New methods that are used to turn a
5547 precomputed FieldInfo into an expression like this:
5551 The idea is to use this instead of making LocalVariableReference
5552 have more than one meaning.
5554 * cs-parser.jay: Add error production to BASE.
5556 * ecore.cs: Deal with TypeManager.GetField returning null, which
5557 is now a valid return value.
5559 (FieldExprNoAddress): New expression for Fields whose address can
5562 * expression.cs (LocalVariableReference): During the resolve
5563 phases, create new expressions if we are in a remapping context.
5564 Remove code that dealt with remapping here.
5566 (ParameterReference): same.
5568 (ProxyInstance): New expression, like the `This' expression, but
5569 it is born fully resolved. We know what we are doing, so remove
5570 the errors that are targeted to user-provided uses of `this'.
5572 * statement.cs (Foreach): our variable is now stored as an
5573 Expression; During resolution, follow the protocol, dont just
5574 assume it will return this.
5576 2003-08-06 Martin Baulig <martin@ximian.com>
5578 * support.cs (SeekableStreamReader.cs): New public class.
5580 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
5581 SeekableStreamReader instead of the normal StreamReader.
5583 2003-08-04 Martin Baulig <martin@ximian.com>
5585 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
5586 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
5587 deambiguate casts and delegate invocations.
5588 (parenthesized_expression): Use the new tokens to ensure this is
5589 not a cast of method invocation.
5591 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
5592 when reading a `)' and Deambiguate_CloseParens () was previously
5595 * expression.cs (ParenthesizedExpression): New class. This is
5596 just used for the CS0075 test.
5597 (Binary.DoResolve): Check for CS0075.
5599 2003-07-29 Ravi Pratap <ravi@ximian.com>
5601 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5602 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5603 reference comparison.
5605 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5606 examine the ReturnType for equality - this is necessary in the
5607 cases of implicit and explicit operators whose signature also
5608 includes the return type.
5610 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5612 * namespace.cs: Cache the result of the namespace computation,
5613 instead of computing it every time.
5615 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5617 * decl.cs: Use a global arraylist that we reuse over invocations
5618 to avoid excesive memory consumption. Reduces memory usage on an
5619 mcs compile by one meg (45 average).
5621 * typemanager.cs (LookupTypeReflection): In .NET pointers are
5622 private, work around that.
5624 2003-07-23 Miguel de Icaza <miguel@ximian.com>
5626 * literal.cs (IntLiteral): Define Zero and One static literals.
5628 * cs-parser.jay (integer_literal): use static literals to reduce
5629 memory usage for the most used literals (0, 1 and -1). 211kb
5630 reduced in memory usage.
5632 Replace all calls to `new ArrayList' with `new
5633 ArrayList(4)' which is a good average number for most allocations,
5634 and also requires only 16 bytes of memory for its buffer by
5637 This reduced MCS memory usage in seven megabytes for the RSS after
5640 2003-07-28 Ravi Pratap <ravi@ximian.com>
5642 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
5643 handle params methods the correct way by forming only one
5644 applicable set with params and normal methods in them. Earlier we
5645 were looking at params methods only if we found no normal methods
5646 which was not the correct thing to do.
5648 (Invocation.BetterFunction): Take separate arguments indicating
5649 when candidate and the best method are params methods in their
5652 This fixes bugs #43367 and #46199.
5654 * attribute.cs: Documentation updates.
5656 (CheckAttribute): Rename to CheckAttributeTarget.
5657 (GetValidPlaces): Rename to GetValidTargets.
5659 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
5660 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
5664 2003-07-28 Martin Baulig <martin@ximian.com>
5666 * class.cs (TypeContainer.DefineMembers): Use the base type's full
5667 name when looking up the base class of a nested class. Fixes #46977.
5669 2003-07-26 Martin Baulig <martin@ximian.com>
5671 * expression.cs (Indexers.Indexer): New nested struct; contains
5672 getter, setter and the indexer's type.
5673 (Indexers.Properties): This is now an ArrayList of
5675 (IndexerAccess.DoResolveLValue): Correctly set the type if the
5676 indexer doesn't have any getters.
5678 * assign.cs (Assign.DoResolve): Also do the implicit conversions
5679 for embedded property and indexer assignments.
5681 2003-07-26 Martin Baulig <martin@ximian.com>
5683 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
5684 preprocessor directive is not the first non-whitespace character
5687 2003-07-26 Martin Baulig <martin@ximian.com>
5689 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
5690 namespace parsing, follow the spec more closely.
5692 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
5693 NamespaceEntry.Lookup().
5695 2003-07-25 Martin Baulig <martin@ximian.com>
5697 * MethodCore.cs (OverridesSomething): New public field; it's set
5698 from TypeContainer.DefineMembers if this method overrides
5699 something (which doesn't need to be a method). Fix #39462.
5701 2003-07-25 Ravi Pratap <ravi@ximian.com>
5703 * typemanager.cs (GetMembers): Ensure that the list of members is
5704 reversed. This keeps things in sync.
5706 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
5707 find an AttributeUsage attribute.
5709 * expression.cs (Invocation.OverloadResolve): Perform the check
5710 which disallows Invoke to be directly called on a Delegate.
5712 (Error_InvokeOnDelegate): Report error cs1533.
5714 2003-07-25 Martin Baulig <martin@ximian.com>
5716 * expression.cs (Indexers.GetIndexersForType): Only look in the
5717 interface hierarchy if the requested type is already an
5718 interface. Fixes #46788 while keeping #46502 fixed.
5720 2003-07-25 Martin Baulig <martin@ximian.com>
5722 * class.cs (TypeContainer.DefineMembers): Check whether all
5723 readonly fields have been assigned and report warning CS0649 if
5726 * statement.cs (LocalInfo.IsFixed): Always return true if this is
5729 2003-07-24 Ravi Pratap <ravi@ximian.com>
5731 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
5732 returned from GetMethods to make things consistent with the
5733 assumptions MCS makes about ordering of methods.
5735 This should comprehensively fix bug #45127 and it does :-)
5737 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
5738 ordering is actually reverse.
5740 * Clean up some debug messages I left lying around.
5742 * interface.cs (Populate*): Get rid of code which emits attributes
5743 since the stage in which we emit attributes is the 'Emit' stage,
5744 not the define stage.
5746 (Emit): Move attribute emission for interface members here.
5748 2003-07-22 Ravi Pratap <ravi@ximian.com>
5750 * expression.cs (Invocation.OverloadResolve): Follow the spec more
5751 closely: we eliminate methods in base types when we have an
5752 applicable method in a top-level type.
5754 Please see section 14.5.5.1 for an exact description of what goes
5757 This fixes bug #45127 and a host of other related to corlib compilation.
5759 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
5760 array is the method corresponding to the top-level type (this is
5761 because of the changes made to icall.c) so we change this
5764 (MethodGroupExpr.Name): This too.
5766 * typemanager.cs (GetElementType): New method which does the right
5767 thing when compiling corlib.
5769 * everywhere: Make use of the above in the relevant places.
5771 2003-07-22 Martin Baulig <martin@ximian.com>
5773 * cs-parser.jay (invocation_expression): Moved
5774 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
5775 `cast_expression', but create a InvocationOrCast which later
5776 resolves to either an Invocation or a Cast.
5778 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
5779 method; call this before EmitStatement() to make sure that this
5780 expression can be used as a statement.
5782 * expression.cs (InvocationOrCast): New class; resolves to either
5783 an Invocation or a Cast.
5785 * statement.cs (StatementExpression): Call ResolveStatement() on
5786 the ExpressionStatement before emitting it.
5788 2003-07-21 Martin Baulig <martin@ximian.com>
5790 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
5791 `ref' and `out' attributes match; fixes #46220.
5792 (MemberAccess.ResolveMemberAccess): You can't reference a type
5793 through an expression; fixes #33180.
5794 (Indexers.GetIndexersForType): Don't return the indexers from
5795 interfaces the class implements; fixes #46502.
5797 2003-07-21 Martin Baulig <martin@ximian.com>
5799 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
5800 CS0661 checks; fixes bug #30442.
5802 2003-07-21 Martin Baulig <martin@ximian.com>
5804 * decl.cs (AdditionResult): Added `Error'.
5806 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
5808 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
5809 makes cs0031.cs actually work.
5811 2003-07-20 Martin Baulig <martin@ximian.com>
5813 * namespace.cs: Fixed that bug which caused a crash when compiling
5816 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5818 * typemanager.cs (LookupTypeReflection): Never expose types which
5819 are NotPublic, NestedPrivate, NestedAssembly, or
5820 NestedFamANDAssem. We used to return these, and later do a check
5821 that would report a meaningful error, but the problem is that we
5822 would not get the real match, if there was a name override.
5824 2003-07-18 Miguel de Icaza <miguel@ximian.com>
5826 * namespace.cs (Namespace, Name): Do not compute the namespace
5827 name dynamically, compute it in the constructor. This reduced
5828 memory usage by 1697 KB.
5830 * driver.cs: Use --pause to pause at the end.
5832 2003-07-17 Peter Williams <peter@newton.cx>
5834 * Makefile: Change the name of the test target so that it doesn't
5835 conflict with the recursive test target.
5837 2003-07-17 Miguel de Icaza <miguel@ximian.com>
5839 * expression.cs (LocalVariableReference.Emit, EmitAssign,
5840 AddressOf): Do not use EmitThis, that was wrong, use the actual
5843 2003-07-15 Miguel de Icaza <miguel@ximian.com>
5845 * class.cs (MethodData.Define): While checking if a method is an
5846 interface implementation, improve the test: If we are not public
5847 (use new test here: use the computed MethodAttributes directly,
5848 instead of the parsed modifier flags) check if the `implementing'
5849 method comes from an interface or not.
5851 * pending.cs (VerifyPendingMethods): Slightly better error
5854 * makefile: add test target that does the mcs bootstrap.
5856 2003-07-16 Ravi Pratap <ravi@ximian.com>
5858 * interface.cs (Define): Do nothing here since there are no
5859 members to populate etc. Move the attribute emission out of here
5860 since this was just totally the wrong place to put it. Attribute
5861 application happens during the 'Emit' phase, not in the 'Define'
5864 (Emit): Add this method and move the attribute emission here
5866 * rootcontext.cs (EmitCode): Call the Emit method on interface
5869 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5871 * expression.cs (OverloadResolve): Report error only if Location
5872 is not 'Null' which means that there was a probe going on.
5874 2003-07-14 Martin Baulig <martin@ximian.com>
5876 * expression.cs (ConditionalLogicalOperator): New public class to
5877 implement user defined conditional logical operators.
5878 This is section 14.11.2 in the spec and bug #40505.
5880 2003-07-14 Martin Baulig <martin@ximian.com>
5882 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
5884 2003-07-14 Martin Baulig <martin@ximian.com>
5886 * codegen.cs (EmitContext.InFixedInitializer): New public field.
5888 * ecore.cs (IVariable.VerifyFixed): New interface method.
5890 * expression.cs (Unary.ResolveOperator): When resolving the `&'
5891 operator, check whether the variable is actually fixed. Fixes bug
5892 #36055. Set a variable definitely assigned when taking its
5893 address as required by the spec.
5895 * statement.cs (LocalInfo.IsFixed): New field.
5896 (LocalInfo.MakePinned): Set `IsFixed' to true.
5898 2003-07-14 Ravi Pratap M <ravi@ximian.com>
5900 * attribute.cs (Attribute.Resolve): While doing a Member lookup
5901 for .ctors, ensure that we only ask for members declared in the
5902 attribute type (BindingFlags.DeclaredOnly).
5906 * expression.cs (Error_WrongNumArguments): Report error 1501
5907 correctly the way CSC does.
5909 2003-07-13 Martin Baulig <martin@ximian.com>
5911 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
5912 lookup on the fully qualified name, to make things like "X.X" work
5913 where "X.X" is a fully qualified type name, but we also have a
5914 namespace "X" in the using list. Fixes #41975.
5916 2003-07-13 Martin Baulig <martin@ximian.com>
5918 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
5919 function. If we're a CompoundAssign, we need to create an embedded
5920 CompoundAssign, not an embedded Assign.
5921 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
5924 2003-07-13 Martin Baulig <martin@ximian.com>
5926 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
5927 work to fix bug #46088.
5929 2003-07-13 Ravi Pratap <ravi@ximian.com>
5931 * class.cs (Operator.Emit): Do not emit attributes here - it is
5932 taken care of by the Method class that we delegate too. This takes
5935 2003-07-10 Martin Baulig <martin@ximian.com>
5937 * expression.cs (TypeOfVoid): New class.
5938 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
5940 2003-07-10 Martin Baulig <martin@ximian.com>
5942 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
5945 2003-07-10 Martin Baulig <martin@ximian.com>
5947 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
5948 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
5950 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
5952 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
5954 2003-07-10 Martin Baulig <martin@ximian.com>
5956 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
5957 of decimal. Fixes #42850.
5959 NOTE: I also fixed the created byte blob, but this doesn't work on
5960 the MS runtime and csc never produces any byte blobs for decimal
5963 2003-07-10 Martin Baulig <martin@ximian.com>
5965 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
5966 structs; fixes #32068.
5967 (Block.AddChildVariableNames): Fixed #44302.
5969 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5971 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
5973 2003-07-07 Miguel de Icaza <miguel@ximian.com>
5975 * attribute.cs: And this test is onger needed.
5977 2003-07-08 Martin Baulig <martin@ximian.com>
5979 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
5980 inaccessible types. Fixes #36313.
5982 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
5984 * namespace.cs (NamespaceEntry): Create implicit entries for all
5985 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
5986 implicit entries for N1.N2 and N1.
5988 2003-07-08 Martin Baulig <martin@ximian.com>
5990 Rewrote the handling of namespaces to fix a lot of the issues
5991 wrt. `using' aliases etc.
5993 * namespace.cs (Namespace): Splitted this class into a
5994 per-assembly `Namespace' and a per-file `NamespaceEntry'.
5996 * typemanager.cs (TypeManager.IsNamespace): Removed.
5997 (TypeManager.ComputeNamespaces): Only compute namespaces from
5998 loaded assemblies here, not the namespaces from the assembly we're
5999 currently compiling.
6001 2003-07-08 Martin Baulig <martin@ximian.com>
6003 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6005 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6007 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6010 I thought about the memory savings here, but LookupTypeReflection
6011 is used under already very constrained scenarios. Compiling
6012 corlib or mcs only exposes one hit, so it would not really reduce
6013 any memory consumption.
6015 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6017 * typemanager.cs: fixes bug #45889 by only adding public types from
6018 other assemblies to the list of known types.
6020 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6022 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6023 on the type we resolved.
6025 2003-07-05 Martin Baulig <martin@ximian.com>
6027 * pending.cs (PendingImplementation.ParentImplements): Don't
6028 create the proxy if the parent is abstract.
6030 * class.cs (TypeContainer.DefineIndexers): Process explicit
6031 interface implementations first. Fixes #37714.
6033 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6035 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6036 defined recursively; but since we modify the input parameters
6037 (left is set to `this' temporarily), we reset this value if the
6038 left_is_explicit is false, which gives the original semantics to
6041 * literal.cs (NullPointer): new class used to represent a null
6042 literal in a pointer context.
6044 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6045 type is a pointer, use a NullPointer object instead of a
6046 NullLiteral. Closes 43687
6048 (ExplicitConversion): Convert pointer values using
6049 the conv opcode to the proper type.
6051 * ecore.cs (New): change ValueTypeVariable property into a method,
6052 that returns whether the valuetype is suitable for being used.
6054 * expression.cs (Binary.DoNumericPromotions): Only return if we
6055 the int constant was a valid uint, and we can return both left and
6056 right as uints. If not, we continue processing, to trigger the
6057 type conversion. This fixes 39018.
6059 * statement.cs (Block.EmitMeta): During constant resolution, set
6060 the CurrentBlock property on the emitcontext, so that we resolve
6061 constants propertly.
6063 2003-07-02 Martin Baulig <martin@ximian.com>
6065 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6066 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6068 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6069 than emitting it here.
6071 * statement.cs: Fixed some more flow analysis bugs.
6073 2003-07-02 Martin Baulig <martin@ximian.com>
6075 * class.cs (MethodData.Define): When implementing interface
6076 methods, set Final unless we're Virtual.
6078 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6079 check work for interface methods.
6081 2003-07-01 Martin Baulig <martin@ximian.com>
6083 * ecore.cs (EmitContext.This): Replaced this property with a
6084 GetThis() method which takes a Location argument. This ensures
6085 that we get the correct error location for a CS0188.
6087 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6089 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6090 ImplicitStandardConversion.
6092 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6094 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6096 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6099 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6101 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6104 (MethodData.Define): Turn off initlocals for unsafe methods.
6106 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6108 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6109 complete; Fixes #37521.
6111 * delegate.cs: Use Modifiers.TypeAttr to compute the
6112 TypeAttributes, instead of rolling our own. This makes the flags
6113 correct for the delegates.
6115 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6117 * class.cs (Constructor.Define): Set the private flag for static
6118 constructors as well.
6120 * cs-parser.jay (statement_expression): Set the return value to
6121 null, to avoid a crash when we catch an error.
6123 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6125 * cs-parser.jay: Applied patch from Jackson that adds support for
6126 extern and unsafe modifiers to destructor declarations.
6128 * expression.cs: Report error 21 if the user is trying to index a
6131 * driver.cs: Add an error message, suggested by the bug report.
6133 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6134 if we do not have a ": this ()" constructor initializer. Fixes 45149
6136 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6138 * namespace.cs: Add some information to reduce FAQs.
6140 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6142 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6143 underlying enumeration types. Fixes #43915.
6145 * expression.cs: Treat ushort/short as legal values to be used in
6148 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6150 * delegate.cs: transfer custom attributes for paramenters from
6151 the delegate declaration to Invoke and BeginInvoke.
6153 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6155 * attribute.cs: handle custom marshalers and emit marshal info
6158 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6160 * makefile.gnu: Added anonymous.cs to the compiler sources.
6162 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6164 * iterators.cs: Change the name of the proxy class to include two
6167 * cs-parser.jay: Update grammar to include anonymous methods.
6169 * anonymous.cs: new file.
6171 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6173 * class.cs (Field.Define): Add missing test for pointers and
6176 2003-05-27 Ravi Pratap <ravi@ximian.com>
6178 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6179 we use the stobj opcode.
6181 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6182 since it wasn't the correct fix.
6184 It still is puzzling that we are required to use stobj for IntPtr
6185 which seems to be a ValueType.
6187 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6189 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6190 during regular simple name resolution. Now, the trick is that
6191 instead of returning for processing the simplename, we do a
6192 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6193 contextual lookup type). If a match is found, return that, if
6194 not, return for further composition.
6196 This fixes long-standing 30485.
6198 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6199 using the address to initialize an object, do an Stobj instead of
6200 using the regular Stelem.
6202 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6203 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6204 Because if we are a BaseIndexerAccess that value will be true.
6207 * statement.cs (GotoCase.Resolve): Return after reporting an
6208 error, do not attempt to continue.
6210 * expression.cs (PointerArithmetic.Emit): If our operand is a
6211 long, convert our constants to match the operand before
6212 multiplying. Convert to I type before adding. Fixes 43670.
6214 2003-05-14 Ravi Pratap <ravi@ximian.com>
6216 * enum.cs (ImplicitConversionExists) : Rename to
6217 ImplicitEnumConversionExists to remove ambiguity.
6219 * ecore.cs (NullCast): New type of cast expression class which
6220 basically is very similar to EmptyCast with the difference being
6221 it still is a constant since it is used only to cast a null to
6225 * convert.cs (ImplicitReferenceConversion): When casting a null
6226 literal, we return a NullCast.
6228 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6229 should be around anymore.
6231 The renaming (reported was slightly wrong). Corrections:
6233 ConvertImplicitStandard -> ImplicitConversionStandard
6234 ConvertExplicitStandard -> ExplicitConversionStandard
6236 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6237 before passing them in !
6239 * convert.cs (ImplicitConversionStandard): When comparing for
6240 equal expr and target types, ensure that expr is not a
6243 In general, we must not be checking (expr_type ==
6244 target_type) in the top level conversion methods
6245 (ImplicitConversion, ExplicitConversion etc). This checking is
6246 done in the methods that they delegate to.
6248 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6250 * convert.cs: Move Error_CannotConvertType,
6251 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6252 ImplicitNumericConversion, ImplicitConversionExists,
6253 ImplicitUserConversionExists, StandardConversionExists,
6254 FindMostEncompassedType, FindMostSpecificSource,
6255 FindMostSpecificTarget, ImplicitUserConversion,
6256 ExplicitUserConversion, GetConversionOperators,
6257 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6258 TryImplicitIntConversion, Error_CannotConvertImplicit,
6259 ConvertImplicitRequired, ConvertNumericExplicit,
6260 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6261 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6264 Perform the following renames:
6266 StandardConversionExists -> ImplicitStandardConversionExists
6267 ConvertImplicit -> ImplicitConversion
6268 ConvertImplicitStandard -> ImplicitStandardConversion
6269 TryImplicitIntConversion -> ImplicitIntConversion
6270 ConvertImplicitRequired -> ImplicitConversionRequired
6271 ConvertNumericExplicit -> ExplicitNumericConversion
6272 ConvertReferenceExplicit -> ExplicitReferenceConversion
6273 ConvertExplicit -> ExplicitConversion
6274 ConvertExplicitStandard -> ExplicitStandardConversion
6276 2003-05-19 Martin Baulig <martin@ximian.com>
6278 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6279 (TypeInfo): Added support for structs having structs as fields.
6281 * ecore.cs (FieldExpr): Implement IVariable.
6282 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6283 VariableInfo for the field.
6285 2003-05-18 Martin Baulig <martin@ximian.com>
6287 * expression.cs (This.DoResolve): Report a CS0027 if we're
6288 emitting a field initializer.
6290 2003-05-18 Martin Baulig <martin@ximian.com>
6292 * expression.cs (This.ResolveBase): New public function.
6293 (This.DoResolve): Check for CS0188.
6295 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6298 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6299 `instance_expression' to null if we don't have any non-static
6302 2003-05-18 Martin Baulig <martin@ximian.com>
6304 Reworked the way how local variables and parameters are handled by
6305 the flow analysis code.
6307 * statement.cs (TypeInfo, VariableMap): New public classes.
6308 (VariableInfo): New public class. This is now responsible for
6309 checking whether a variable has been assigned. It is used for
6310 parameters and local variables.
6311 (Block.EmitMeta): Take the InternalParameters as argument; compute
6312 the layout of the flow vectors here.
6313 (Block.LocalMap, Block.ParameterMap): New public properties.
6314 (FlowBranching): The .ctor doesn't get the InternalParameters
6315 anymore since Block.EmitMeta() now computes the layout of the flow
6317 (MyStructInfo): This class is now known as `StructInfo' and nested
6318 in `TypeInfo'; we don't access this directly anymore.
6320 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6321 property and removed IsAssigned(), IsFieldAssigned(),
6322 SetAssigned() and SetFieldAssigned(); we now call them on the
6323 VariableInfo so we don't need to duplicate this code everywhere.
6325 * expression.cs (ParameterReference): Added `Block block' argument
6327 (LocalVariableReference, ParameterReference, This): The new
6328 VariableInfo class is now responsible for all the definite
6331 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6332 IsParameterAssigned, SetParameterAssigned): Removed.
6334 2003-05-18 Martin Baulig <martin@ximian.com>
6336 * typemanager.cs (InitCoreTypes): Try calling
6337 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6338 the 3-args-version. Corlib now also needs our `void_type'.
6339 (GetMethod): Added overloaded version which takes an optional
6340 `bool report_errors' to allow lookups of optional methods.
6342 2003-05-12 Martin Baulig <martin@ximian.com>
6344 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6345 only used for locals and not for parameters.
6347 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6349 * support.cs (InternalParameters.ParameterType): Return the
6350 ExternalType of the parameter.
6352 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6355 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6357 * class.cs (MethodData.Define): Do not set the `newslot' on
6358 interface members, if they are also flagged as "override".
6360 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6361 better code for ++i and i++. This only works for static fields
6362 and local variables.
6364 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6365 want to pull the DeclSpace out of the builder_to_declspace instead
6366 of the TypeBuilder (like in TypeContainer.FindMembers).
6368 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6369 instead of LookupTypeContainer. Fixes the crash on .NET for
6370 looking up interface members.
6372 * const.cs: Create our own emit context during the Definition
6373 stage, so that constants are evaluated in the proper context, when
6374 a recursive definition happens.
6376 2003-05-11 Martin Baulig <martin@ximian.com>
6378 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6379 new block for a switch section.
6380 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6381 the adding/lookup in the switch block. Fixes #39828.
6383 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6385 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6386 functionality: I needed to convert the data after I had performed
6387 the add/sub operation into the operands type size.
6389 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6390 pass the type for the box operation, otherwise the resulting
6391 object would have been of type object.
6393 (BoxedCast): Add constructor to specify the type to box as.
6395 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6397 * iterators.cs: I was reusing the `count' variable inadvertently,
6398 take steps to not allow this to happen.
6400 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6402 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6403 by creating an array at the point where the params starts and
6404 putting all those arguments there, then adjusting the size of the
6407 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6409 * expression.cs (New.AddressOf): Implement interface
6410 IMemoryLocation. This is used when the `new' operator is used in
6411 the context of an invocation to a method on a value type.
6413 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6416 * namespace.cs: Also check the using aliases here.
6418 * driver.cs: Move the test for using validity after the types have
6419 been entered, so we do a single pass that also includes the using
6422 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6423 in the regular case. CreateSiblingForFinally is doing extra
6426 * attribute.cs (GetAttributeArgumentExpression): Store the result
6427 on an out value, and use the return value to indicate failure
6428 instead of using null (which is a valid return for Constant.GetValue).
6430 * statement.cs: Perform the analysis flow for the increment
6431 portion after the statement, because this will be the real flow of
6432 execution. Fixes #42385
6434 * codegen.cs (EmitContext.EmitArgument,
6435 EmitContext.EmitStoreArgument): New helper functions when the
6436 RemapToProxy flag is set.
6438 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6441 Add support for remapping parameters.
6443 * iterators.cs: Propagate parameter values; Store parameter
6444 values in the proxy classes.
6446 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6448 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6449 need a proxy reference; I do not know what I was thinking
6451 * cs-parser.jay (constructor_initializer): catch another error,
6452 and display nice message.
6454 (field_declaration): catch void field declaration
6455 to flag a better error.
6457 * class.cs (MemberBase.CheckBase): Report an error instead of a
6458 warning if a new protected member is declared in a struct.
6459 (Field.Define): catch the error of readonly/volatile.
6461 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6463 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6464 volatile variable is taken
6466 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6468 * statement.cs (Fixed.Resolve): Report an error if we are not in
6471 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6473 * typemanager.cs: reuse the code that handles type clashes for
6474 delegates and enumerations.
6476 * class.cs (Report28): Always report.
6478 * expression.cs (EncodeAsAttribute): Allow nulls here.
6480 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6482 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6483 the functionality for testing whether an expression is valid for
6484 an attribute here. Also handle the case of arrays of elements
6487 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6488 encoding a linear array into an array of objects that are suitable
6489 to be passed to an CustomAttributeBuilder.
6491 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6493 * ecore.cs: (FieldExpr): Handle field remapping here.
6495 * iteratators.cs: Pass the instance variable (if the method is an
6496 instance method) to the constructors, so we can access the field
6497 variables on the class.
6499 TODO: Test this with structs. I think the THIS variable on
6500 structs might have to be a pointer, and not a refenrece
6502 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6504 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6505 local variables to fields in a proxy class.
6507 * iterators.cs (PopulateProxy): Rename our internal fields to
6509 Create a <THIS> field if we are an instance method, so we can
6510 reference our parent container variables.
6511 (MapVariable): Called back from the EmitContext code to enter a
6512 new variable to field mapping into the proxy class (we just create
6516 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6517 for using the remapped locals to fields.
6519 I placed the code here, because that gives the same semantics to
6520 local variables, and only changes the Emit code.
6522 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6523 statements inside iterators.
6524 (VariableInfo): Add a FieldBuilder for the cases when we are
6525 remapping local variables to fields in a proxy class
6527 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6528 current_block != null.
6530 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6531 not cope with strings, as it has been moved to the
6532 TableSwitchEmit. Fixed bug in switch generation.
6534 * expression.cs (New.DoResolve): Provide more context for the user
6535 when reporting an error.
6537 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6540 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6541 check the permissions for it. Note than in a type-resolution
6542 context the check was already present in DeclSpace.ResolveType,
6543 but was missing from the MemberAccess.
6545 (ArrayCreation.CheckIndices): warn if the user has
6546 more nested levels of expressions, but there are no more
6547 dimensions specified. Avoids crash on bug 41906.
6549 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6551 * statement.cs (Block): replace Implicit bool, for a generic
6553 New flag: `Unchecked'. This is used during the EmitMeta phase
6554 (which is out-of-line with the regular Resolve/Emit process for a
6555 statement, as this is done ahead of time, but still gets a chance
6556 to call constant resolve).
6558 (Block.Flags): new enum for adding a new flag.
6560 (Block.EmitMeta): track the state of unchecked.
6562 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6563 to enable constant resolution to work there as well.
6565 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6567 * typemanager.cs (ienumerable_type): Also look up
6568 System.Collections.IEnumerable.
6570 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6572 TODO: Test more than one conditional per method.
6574 * class.cs (Indexer.Define): Report the location where the user is
6575 referencing the unsupported feature.
6577 (MethodData): Overload the use of `conditionals' to
6578 minimize the creation of needless ArrayLists. This saves roughly
6579 212kb on my machine.
6581 (Method): Implement the new IIteratorContainer interface.
6582 (Method.SetYields): Implement the method by setting the ModFlags
6583 to contain METHOD_YIELDS.
6585 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
6586 which just got set to null.
6588 * iterators.cs: New file.
6590 (Yield, YieldBreak): New statements.
6592 * statement.cs (Return.Resolve): Flag an error if we are used in
6595 * codegen.cs (InIterator): New flag set if the code is being
6596 compiled in an iterator method.
6598 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6599 internal modifier, and we just use it to avoid adding extra
6600 fields, as this is seldom used.
6602 * cs-parser.jay: Add yield_statement (yield and yield break).
6604 * driver.cs: New flag -v2 to turn on version 2 features.
6606 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6607 hashtable when v2 is enabled.
6609 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6611 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6612 there is already a namespace defined with this name.
6614 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6615 people upgraded their corlibs.
6617 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
6618 always use fully qualified types, no need to use the compiler
6621 (TypeManager.IsNamespace): Use binarysearch.
6623 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
6624 AddDelegate): I did not quite use the new IsValid API properly: I
6625 have to pass the short-name and the fullname. I was passing only
6626 the basename instead of the fullname sometimes.
6628 (TypeContainer.DefineType): call NamespaceClash.
6630 * interface.cs (Interface.DefineType): use NamespaceClash before
6633 * delegate.cs (Delegate.DefineType): use NamespaceClash before
6636 * enum.cs: (Enum.DefineType): use NamespaceClash before
6639 * typemanager.cs (: 3-line patch that gives us some tasty 11%
6640 speed increase. First, use the negative_hits cache when we get a
6641 negative. Second, add the type with its full original name
6642 instead of the new . and + encoded name (reflection uses + to
6643 separate type from a nested type). Use LookupTypeReflection
6644 directly which bypasses the type->name hashtable (that we already
6645 know does not contain the type.
6647 * decl.cs (DeclSpace.ResolveTypeExpr): track the
6648 location/container type.
6650 * driver.cs: When passing utf8, use directly the UTF8Encoding.
6652 2003-04-19 Miguel de Icaza <miguel@ximian.com>
6654 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
6656 * delegate.cs (NewDelegate.Resolve): Test whether an instance
6657 method is being referenced in the method group from a static
6658 context, and report error 120 if so.
6660 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
6663 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
6664 is created, we create the A namespace).
6666 * cs-parser.jay: A namespace also introduces a DeclarationFound.
6669 2003-04-18 Miguel de Icaza <miguel@ximian.com>
6671 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
6672 invocation to ModuleBuilder.GetType with the same values will
6673 return a new type instance, so we need to cache its return
6676 * expression.cs (Binary.ResolveOperator): Only allow the compare
6677 operators on enums if they are of the same type.
6679 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
6680 types of ValueType on their own case. Before we were giving them
6681 the same treatment as objects.
6683 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
6684 fullname. Short name is used to compare against container name.
6685 Fullname is used to check against defined namespace names.
6687 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
6688 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
6690 (Method.CheckBase): Call parent.
6691 (MemberBase.CheckBase): Check for protected members on sealed
6693 (PropertyBase.CheckBase): Call parent.
6694 (Field.Define): Call parent.
6696 * report.cs: Negative error codes are now mapped to 8000 - code,
6697 so that the display is render more nicely.
6699 * typemanager.cs: Do not use try/catch, instead report a regular
6702 (GetPointerType, GetReferenceType): These methods provide
6703 mechanisms to obtain the T* and T& from a T. We had the code
6704 previously scattered around the code base, and it also used
6705 TypeManager.LookupType that would go through plenty of caches.
6706 This one goes directly to the type source.
6708 In some places we did the Type.GetType followed by
6709 ModuleBuilder.GetType, but not in others, so this unifies the
6712 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
6713 statements now that we have namespace information.
6715 * typemanager.cs (IsNamespace): New method, returns whether the
6716 string presented is a namespace or not.
6718 (ComputeNamespaces): New public entry point, computes the list of
6719 available namespaces, using the GetNamespaces API call in Mono, or
6720 the slower version in MS.NET.
6722 Now before we start the semantic analysis phase, we have a
6723 complete list of namespaces including everything that the user has
6726 Deleted old code to cache namespaces in .nsc files.
6728 2003-04-17 Miguel de Icaza <miguel@ximian.com>
6730 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
6731 class/struct location definition Location for the implicit
6732 constructor location.
6734 (Operator.Define): Use the location of the operator for the
6735 implicit Method definition.
6737 (Constructor.Emit): use the constructor location for the implicit
6738 base initializer constructor.
6740 * ecore.cs: Remove ITypeExpression. This interface is now gone,
6741 and the Expression class now contains two new methods:
6743 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
6744 isolate type lookup from the rest of the resolution process.
6746 Since we use Expressions to hold type definitions due to the way
6747 we parse the input we have historically overloaded Resolve to
6748 perform the Type lookups if a special flag is passed. Now this is
6749 eliminated and two methods take their place.
6751 The differences in the two methods between xStep and xTerminal is
6752 that xStep is involved in our current lookup system that uses
6753 SimpleNames to compose a name, while xTerminal is used just to
6754 catch the case where the simplename lookup failed.
6756 2003-04-16 Miguel de Icaza <miguel@ximian.com>
6758 * expression.cs (ResolveMemberAccess): Remove redundant code.
6759 TypeExpr expressions are always born fully resolved.
6761 * interface.cs (PopulateMethod): Do not lookup the types twice.
6762 We were doing it once during SemanticAnalysis and once during
6765 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
6766 in local variable type definitions, were being returned as a
6767 SimpleName (we decomposed everything into a string), that is
6768 because primary_expression was being used instead of a type in the
6769 grammar (reduce/reduce conflicts).
6771 The part that was wrong is that we converted the expression into a
6772 string (an oversimplification in one hand, compounded with primary
6773 expressions doing string concatenation).
6779 Would return "A.B.C[]" as a SimpleName. This stopped things like
6780 using clauses from working on this particular context. And a type
6781 was being matched directly against "A.B.C[]".
6783 We now use the correct approach, and allow for ComposedCast to be
6784 part of the unary expression. So the "A.B.C []" become a composed
6785 cast of "A.B.C" (as a nested group of MemberAccess with a
6786 SimpleName at the end) plus the rank composition "[]".
6790 2003-04-10 Miguel de Icaza <miguel@ximian.com>
6792 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
6793 for the access level checking.
6795 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
6796 `TypeContainer container', because I kept getting confused when I
6797 was debugging this code.
6799 * expression.cs (Indexers): Instead of tracking getters/setters,
6800 we now track them in parallel. We create one arraylist less, but
6801 most importantly it is possible now for the LValue code to find a
6802 matching get for a set.
6804 (IndexerAccess.DoResolveLValue): Update the code.
6805 GetIndexersForType has been modified already to extract all the
6806 indexers from a type. The code assumed it did not.
6808 Also make the code set the correct return type for the indexer.
6809 This was fixed a long time ago for properties, but was missing for
6810 indexers. It used to be void_type.
6812 (Binary.Emit): Test first for doubles instead of
6813 floats, as they are more common.
6815 (Binary.EmitBranchable): Use the .un version of the branch opcodes
6816 when dealing with floats and the <=, >= operators. This fixes bug
6819 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
6820 to load the array value by emitting a load on the foreach variable
6821 type. This was incorrect.
6823 We now emit the code to load an element using the the array
6824 variable type, and then we emit the conversion operator.
6828 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
6830 * attribute.cs: Avoid allocation of ArrayLists in the common case.
6832 2003-04-09 Miguel de Icaza <miguel@ximian.com>
6834 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
6835 test for protection before we test for signatures.
6837 (MethodSignature.ToString): implement.
6839 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
6840 to the case where we reduced into a LongConstant.
6842 * decl.cs (CheckAccessLevel): If the type is an array, we can not
6843 depend on whether the information is acurrate, because the
6844 Microsoft runtime will always claim that the array type is public,
6845 regardless of the real state.
6847 If the type is a pointer, another problem happens: the type is
6848 reported as non-public in Microsoft.
6850 In both cases we have to call CheckAccessLevel recursively with
6851 the underlying type as the argument to be tested.
6853 2003-04-08 Miguel de Icaza <miguel@ximian.com>
6855 * assign.cs (Assign.Emit): If we are dealing with a compound
6856 assignment expression, we should use the code path that stores the
6857 intermediate result in a temporary value. This fixes #40903.
6859 *expression.cs (Indirection.ToString): Provide ToString method for
6862 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
6864 * class.cs: Null out fields holding references to Block objects so
6865 they can be garbage collected.
6867 * expression.cs (OverloadResolve): Remove unused local.
6869 2003-04-07 Martin Baulig <martin@ximian.com>
6871 * codegen.cs (EmitContext.CurrentFile): New public field.
6872 (EmitContext.Mark): Use the CurrentFile to check whether the
6873 location is in the correct file.
6874 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
6876 2003-04-07 Martin Baulig <martin@ximian.com>
6878 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
6880 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
6881 location. [FIXME: The location argument which gets passed to this
6882 method is sometimes wrong!]
6884 2003-04-07 Nick Drochak <ndrochak@gol.com>
6886 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
6888 2003-04-07 Miguel de Icaza <miguel@ximian.com>
6890 * expression.cs (Indirection.EmitAssign): We were using the
6891 temporary, but returning immediately instead of continuing the
6894 2003-04-06 Martin Baulig <martin@ximian.com>
6896 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
6897 if it's a nested child, but also deriving from the outer class.
6900 * typemanager.cs (IsNestedChildOf): Make this work if it's a
6901 nested child, but also deriving from the outer class. See
6903 (FilterWithClosure): We may access private members of the outer
6904 class if we're a nested child and deriving from the outer class.
6905 (RealMemberLookup): Only set `closure_private_ok' if the
6906 `original_bf' contained BindingFlags.NonPublic.
6908 2003-04-05 Martin Baulig <martin@ximian.com>
6910 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
6912 2003-04-02 Miguel de Icaza <miguel@ximian.com>
6914 * class.cs (Event.Define): Do not allow abstract events to have
6917 2003-04-01 Miguel de Icaza <miguel@ximian.com>
6919 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
6920 block in event declarations.
6922 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
6923 value type, get its address.
6925 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
6926 leaving a class on the stack instead of a boolean value (int
6927 0/1). Change the code so we compare against null, and then the
6928 result against zero.
6930 * class.cs (TypeContainer.GetClassBases): We were checking for the
6931 parent class being sealed too late.
6933 * expression.cs (Binary.Emit): For <= and >= when dealing with
6934 floating point values, use cgt.un and clt.un instead of cgt and
6937 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
6939 * statement.cs: Apply the same optimization as MS: skip the
6940 GetEnumerator returning an IEnumerator, and use the one returning a
6941 CharEnumerator instead. This allows us to avoid the try-finally block
6944 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
6946 * cs-parser.jay: Attributes cannot be applied to
6947 namespaces. Fixes #40473
6949 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6952 (Add*): check if the name is valid using the full name for constants,
6953 fields, properties and events.
6955 2003-03-28 Miguel de Icaza <miguel@ximian.com>
6957 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
6958 char constants to be part of the enumeration.
6960 * expression.cs (Conditional.DoResolve): Add support for operator
6961 true. Implements the missing functionality from 14.12
6963 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
6964 operator true/false as required by the spec.
6966 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
6967 implicit conversion to boolean.
6969 * statement.cs (Statement.ResolveBoolean): A boolean expression is
6970 also one where the type implements `operator true'.
6972 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
6973 get an expression that will invoke operator true based on an
6976 (GetConversionOperators): Removed the hack that called op_True
6979 (Expression.ResolveBoolean): Move this from Statement.
6981 2003-03-17 Miguel de Icaza <miguel@ximian.com>
6983 * ecore.cs (FieldExpr): do not allow initialization of initonly
6984 fields on derived classes
6986 2003-03-13 Martin Baulig <martin@ximian.com>
6988 * statement.cs (Block.Emit): Call ig.BeginScope() and
6989 ig.EndScope() when compiling with debugging info; call
6990 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
6992 2003-03-08 Miguel de Icaza <miguel@ximian.com>
6994 * expression.cs (Indexers): Do not construct immediately, allow
6995 for new members to be appended as we go. Fixes 38143
6997 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6999 * expression.cs: save/restore context when resolving an unchecked
7002 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7004 * cfold.cs: Catch division by zero in modulus operator during
7007 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7009 * interface.cs (Interface.DefineMembers): Avoid defining members
7012 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7014 * driver.cs: handle the +/- options for -noconfig
7016 * statement.cs (Unckeched.Resolve): Also track the state of
7017 unchecked in the Resolve phase.
7019 2003-02-27 Martin Baulig <martin@ximian.com>
7021 * ecore.cs (Expression.MemberLookup): Don't create a
7022 MethodGroupExpr for something which is not a method. Fixes #38291.
7024 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7026 * class.cs (MemberBase.CheckParameters): Also check that the type
7027 is unmanaged if it is a pointer.
7029 * expression.cs (SizeOf.Resolve): Add location information.
7031 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7032 a managed type is declared.
7034 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7035 parameter modifiers as well. Fixes bug 38606
7037 * class.cs: Very sad. Am backing out the speed up changes
7038 introduced by the ArrayList -> Array in the TypeContainer, as they
7039 were not actually that much faster, and introduced a bug (no error
7040 reports on duplicated methods).
7042 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7043 source first, this will guarantee that we have a valid expression
7044 before calling in lower levels functions that will require a
7045 resolved object. Then use this original_source in the
7046 target.ResolveLValue instead of the original source that was
7049 Another change. Use target.Resolve instead of LValueResolve.
7050 Although we are resolving for LValues, we will let the Assign code
7051 take care of that (it will be called again from Resolve). This
7052 basically allows code like this:
7054 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7055 class Y { void A (X x) { x [0] += o; }
7057 The problem was that the indexer was trying to resolve for
7058 set_Item (idx, object o) and never finding one. The real set_Item
7059 was set_Item (idx, X). By delaying the process we get the right
7064 2003-02-23 Martin Baulig <martin@ximian.com>
7066 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7067 while calling DoEmit ().
7069 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7070 source files; if you use the #line directive inside a method, the
7071 compiler stops emitting line numbers for the debugger until it
7072 reaches the end of the method or another #line directive which
7073 restores the original file.
7075 2003-02-23 Martin Baulig <martin@ximian.com>
7077 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7079 2003-02-23 Martin Baulig <martin@ximian.com>
7081 * statement.cs (Block.AddChildVariableNames): We need to call this
7082 recursively, not just for our immediate children.
7084 2003-02-23 Martin Baulig <martin@ximian.com>
7086 * class.cs (Event.Define): Always make the field private, like csc does.
7088 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7089 actually work, fixes bug #37521.
7091 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7093 * delegate.cs: When creating the various temporary "Parameters"
7094 classes, make sure that we call the ComputeAndDefineParameterTypes
7095 on those new parameters (just like we do with the formal ones), to
7096 allow them to be resolved in the context of the DeclSpace.
7098 This fixes the bug that Dick observed in Bugzilla #38530.
7100 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7102 * expression.cs (ResolveMemberAccess): When resolving a constant,
7103 do not attempt to pull a constant if the value was not able to
7104 generate a valid constant.
7106 * const.cs (LookupConstantValue): Do not report more errors than required.
7108 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7110 * expression.cs: fixes bug #38328.
7112 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7114 * class.cs: Changed all the various members that can be part of a
7115 class from being an ArrayList to be an Array of the right type.
7116 During the DefineType type_list, interface_list, delegate_list and
7117 enum_list are turned into types, interfaces, delegates and enums
7120 And during the member population, indexer_list, event_list,
7121 constant_list, field_list, instance_constructor_list, method_list,
7122 operator_list and property_list are turned into their real arrays.
7124 Although we could probably perform this operation earlier, for
7125 good error reporting we need to keep the lists and remove the
7126 lists for longer than required.
7128 This optimization was triggered by Paolo profiling the compiler
7129 speed on the output of `gen-sample-program.pl' perl script.
7131 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7132 not crash in methods like MemberLookupFailed that use this field.
7134 This problem arises when the compiler fails to resolve a type
7135 during interface type definition for example.
7137 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7139 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7140 inherit from System.Object, so we have to stop at null, not only
7141 when reaching System.Object.
7143 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7145 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7146 DeclaredOnly because the parent indexer might have had a different
7147 name, but did not loop until the top of the hierarchy was reached.
7149 The problem this one fixes is 35492: when a class implemented an
7150 indexer from an interface, we were getting the interface method
7151 (which was abstract) and we were flagging an error (can not invoke
7154 This also keeps bug 33089 functioning, and test-148 functioning.
7156 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7157 out if a method is special is to see if it is declared in a
7158 property or event, or whether it is one of the predefined operator
7159 names. This should fix correctly #36804.
7161 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7163 The goal here is to remove the dependency on EmptyCast.Peel ().
7164 Killing it completely.
7166 The problem is that currently in a number of places where
7167 constants are expected, we have to "probe" for an EmptyCast, and
7168 Peel, which is not the correct thing to do, as this will be
7169 repetitive and will likely lead to errors.
7171 The idea is to remove any EmptyCasts that are used in casts that
7172 can be reduced to constants, so we only have to cope with
7175 This bug hunt was triggered by Bug 37363 and the desire to remove
7176 the duplicate pattern where we were "peeling" emptycasts to check
7177 whether they were constants. Now constants will always be
7180 * ecore.cs: Use an enumconstant here instead of wrapping with
7183 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7184 throwing me off. By handling this we can get rid of a few hacks.
7186 * statement.cs (Switch): Removed Peel() code.
7188 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7190 * class.cs: Location information for error 508
7192 * expression.cs (New.DoResolve): Add a guard against double
7193 resolution of an expression.
7195 The New DoResolve might be called twice when initializing field
7196 expressions (see EmitFieldInitializers, the call to
7197 GetInitializerExpression will perform a resolve on the expression,
7198 and later the assign will trigger another resolution
7200 This leads to bugs (#37014)
7202 * delegate.cs: The signature for EndInvoke should contain any ref
7203 or out parameters as well. We were not doing this in the past.
7205 * class.cs (Field.Define): Do not overwrite the type definition
7206 inside the `volatile' group. Turns out that volatile enumerations
7207 were changing the type here to perform a validity test, which
7210 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7212 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7213 and structs, we do not want to load the instance variable
7215 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7216 enum_type has to be handled like an object reference (implicit
7217 conversions exists from this to object), but the regular IsClass
7218 and IsValueType tests will never return true for this one.
7220 Also we use TypeManager.IsValueType instead of type.IsValueType,
7221 just for consistency with the rest of the code (this is only
7222 needed if we ever use the construct exposed by test-180.cs inside
7223 corlib, which we dont today).
7225 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7227 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7230 2003-02-09 Martin Baulig <martin@ximian.com>
7232 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7233 (Namespace.DefineNamespaces): New static public method; this is
7234 called when we're compiling with debugging to add all namespaces
7237 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7238 pass it to the Namespace's .ctor.
7240 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7241 and MethodBase arguments; pass the namespace ID to the symwriter;
7242 pass the MethodBase instead of the token to the symwriter.
7243 (SymbolWriter.DefineNamespace): New method to add a namespace to
7246 2003-02-09 Martin Baulig <martin@ximian.com>
7248 * symbolwriter.cs: New file. This is a wrapper around
7249 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7250 methods here in near future.
7252 2003-02-09 Martin Baulig <martin@ximian.com>
7254 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7255 ILGenerator.MarkSequencePoint() which are actually used by the
7258 2003-02-09 Martin Baulig <martin@ximian.com>
7260 * location.cs (SourceFile): New public sealed class. This
7261 contains the name and an index which is used in the location's token.
7262 (Location): Reserve an appropriate number of bits in the token for
7263 the source file instead of walking over that list, this gives us a
7264 really huge performance improvement when compiling with debugging.
7266 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7267 `SourceFile' argument instead of a string.
7268 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7269 but don't parse/tokenize here, we need to generate the list of all
7270 source files before we do that.
7271 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7274 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7275 instead of a string.
7277 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7280 2003-02-09 Martin Baulig <martin@ximian.com>
7282 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7283 filename on `#line default'.
7285 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7287 * statement.cs: don't clear the pinned var when the fixed statement
7288 returns from the method (fixes bug#37752).
7290 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7292 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7295 2003-02-07 Martin Baulig <martin@ximian.com>
7297 * driver.cs: Removed the `--debug-args' command line argument.
7299 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7300 automatically by the AsssemblyBuilder.
7301 (CodeGen.InitializeSymbolWriter): We don't need to call any
7302 initialization function on the symbol writer anymore. This method
7303 doesn't take any arguments.
7305 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7307 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7308 from referenced assemblies as well.
7310 2003-02-02 Martin Baulig <martin@ximian.com>
7312 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7314 2003-02-02 Martin Baulig <martin@ximian.com>
7316 * class.cs (Constructor.Emit): Open the symbol writer before
7317 emitting the constructor initializer.
7318 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7319 single-stepping through constructor initializers.
7321 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7323 * class.cs: Handle error 549: do not allow virtual methods in
7326 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7328 * decl.cs: Check access levels when resolving types
7330 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7332 * statement.cs: Add parameters and locals set in catch blocks that might
7333 return to set vector
7335 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7337 * class.cs (Operator): Set the SpecialName flags for operators.
7339 * expression.cs (Invocation.DoResolve): Only block calls to
7340 accessors and operators on SpecialName methods.
7342 (Cast.TryReduce): Handle conversions from char constants.
7345 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7347 * statement.cs: small memory and time optimization in FlowBranching.
7349 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7351 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7352 problem that the last fix but in the other sid (Set).
7354 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7355 access when there is no indexer in the hierarchy.
7357 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7359 * class.cs: Combine some if statements.
7361 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7363 * driver.cs: fixed bug #37187.
7365 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7367 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7368 any indexer, it's needed to build a list with all the indexers in the
7369 hierarchy (AllGetters), else we have problems. Fixes #35653.
7371 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7373 * class.cs (MethodData.Define): It is wrong for an interface
7374 implementation to be static in both cases: explicit and implicit.
7375 We were only handling this in one case.
7377 Improve the if situation there to not have negations.
7379 * class.cs (Field.Define): Turns out that we do not need to check
7380 the unsafe bit on field definition, only on usage. Remove the test.
7382 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7384 * driver.cs: use assembly.Location instead of Codebase (the latest
7385 patch made mcs fail when using MS assemblies).
7387 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7389 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7390 get the path to *corlib.dll.
7392 2003-01-21 Nick Drochak <ndrochak@gol.com>
7396 * typemanager.cs: Remove compiler warnings
7398 2003-01-20 Duncan Mak <duncan@ximian.com>
7400 * AssemblyInfo.cs: Bump the version number to 0.19.
7402 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7404 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7406 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7408 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7410 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7412 * cs-parser.jay: Small fix: we were not comparing the constructor
7413 name correctly. Thanks to Zoltan for the initial pointer.
7415 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7417 * cs-tokenizer.cs: Set file name when specified with #line
7419 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7421 * cs-parser.jay: Only perform the constructor checks here if we
7422 are named like the class; This will help provider a better
7423 error. The constructor path is taken when a type definition is
7424 not found, but most likely the user forgot to add the type, so
7425 report that rather than the constructor error.
7427 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7429 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7432 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7434 * cs-parser.jay: Add cleanup call.
7436 2003-01-13 Duncan Mak <duncan@ximian.com>
7438 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7439 consistent with other methods.
7441 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7443 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7445 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7447 * attribute.cs: only set GuidAttr to true when we have a
7450 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7454 * typemanager.cs: fixes to allow mcs compile corlib with the new
7455 Type.IsSubclassOf fix.
7457 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7459 * expression.cs (LocalVariableReference.DoResolve): Classify a
7460 constant as a value, not as a variable. Also, set the type for
7463 * cs-parser.jay (fixed_statement): take a type instead of a
7464 pointer_type, so we can produce a better error message later.
7466 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7469 (For.DoEmit): Make inifinite loops have a
7470 non-conditional branch back.
7472 (Fixed.DoEmit): First populate the pinned variables, then emit the
7473 statement, then clear the variables. Before I was emitting the
7474 code once for each fixed piece.
7477 2003-01-08 Martin Baulig <martin@ximian.com>
7479 * statement.cs (FlowBranching.MergeChild): A break in a
7480 SWITCH_SECTION does not leave a loop. Fixes #36155.
7482 2003-01-08 Martin Baulig <martin@ximian.com>
7484 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7485 lives in the same number space than `param_map'. Fixes #36154.
7487 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7489 * cs-parser.jay (constructor_declaration): Set the
7490 Constructor.ModFlags before probing for it. This makes the
7491 compiler report 514, 515 and 132 (the code was there, but got
7494 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7495 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7496 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7498 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7500 * enum.cs: create the enum static fields using the enum type.
7502 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7504 * class.cs: don't try to create the ParamBuilder for the return
7505 type if it's not needed (and handle it breaking for the ms runtime
7508 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7510 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7512 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7514 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7515 the command. This showed up while compiling the JANET source
7516 code, which used \r as its only newline separator.
7518 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7520 * class.cs (Method.Define): If we are an operator (because it
7521 reuses our code), then set the SpecialName and HideBySig. #36128
7523 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7525 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7526 exception, report error 120 `object reference required'.
7528 * driver.cs: Add --pause option, used during to measure the size
7529 of the process as it goes with --timestamp.
7531 * expression.cs (Invocation.DoResolve): Do not allow methods with
7532 SpecialName to be invoked.
7534 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7536 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7537 number before adding it.
7539 2002-12-21 Ravi Pratap <ravi@ximian.com>
7541 * ecore.cs (StandardImplicitConversion): When in an unsafe
7542 context, we allow conversion between void * to any other pointer
7543 type. This fixes bug #35973.
7545 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7547 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7548 is not thrown when extensionless outputs are used
7550 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7552 * rootcontext.cs: fixed compilation of corlib.
7554 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7556 * attribute.cs (Attributes.Contains): Add new method.
7558 * class.cs (MethodCore.LabelParameters): if the parameter is an
7559 `out' parameter, check that no attribute `[In]' has been passed.
7561 * enum.cs: Handle the `value__' name in an enumeration.
7563 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7565 * decl.cs: Added special case to allow overrides on "protected
7568 2002-12-18 Ravi Pratap <ravi@ximian.com>
7570 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7571 since it makes much more sense.
7573 (Attributes.ctor): Don't require a Location parameter.
7575 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7577 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7578 since we already have that information per attribute.
7580 * everywhere : make appropriate changes.
7582 * class.cs (LabelParameters): Write the code which actually
7583 applies attributes to the return type. We can't do this on the MS
7584 .NET runtime so we flag a warning in the case an exception is
7587 2002-12-18 Miguel de Icaza <miguel@ximian.com>
7589 * const.cs: Handle implicit null conversions here too.
7591 2002-12-17 Ravi Pratap <ravi@ximian.com>
7593 * class.cs (MethodCore.LabelParameters): Remove the extra
7594 Type [] parameter since it is completely unnecessary. Instead
7595 pass in the method's attributes so that we can extract
7596 the "return" attribute.
7598 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7600 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7601 of ignoring it and letting the compile continue.
7603 * typemanager.cs (ChangeType): use an extra argument to return an
7604 error condition instead of throwing an exception.
7606 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7608 * expression.cs (Unary.TryReduce): mimic the code for the regular
7609 code path. Perform an implicit cast in the cases where we can
7610 implicitly convert to one of the integral types, and then reduce
7611 based on that constant. This fixes bug #35483.
7613 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7615 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7617 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7619 * namespace.cs: fixed bug #35489.
7621 2002-12-12 Miguel de Icaza <miguel@ximian.com>
7623 * class.cs: Remove some dead code.
7625 * cs-parser.jay: Estimate the number of methods needed
7626 (RootContext.MethodCount);
7628 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
7629 numbers instead of StringBuilders.
7631 * support.cs (PtrHashtable): Add constructor with initial size;
7632 We can now reduce reallocations of the method table.
7634 2002-12-10 Ravi Pratap <ravi@ximian.com>
7636 * attribute.cs (ApplyAttributes): Keep track of the emitted
7637 attributes on a per-target basis. This fixes bug #35413.
7639 2002-12-10 Miguel de Icaza <miguel@ximian.com>
7641 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
7642 default to the Windows 1252 encoding.
7644 (UnixParseOption): Support version, thanks to Alp for the missing
7647 * AssemblyInfo.cs: Add nice assembly information.
7649 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
7652 * cs-parser.jay: Allow a trailing comma before the close bracked
7653 in the attribute_section production.
7655 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
7656 address of the instance was being taken, I will take this out,
7657 because we take the address of the object immediately here.
7659 2002-12-09 Ravi Pratap <ravi@ximian.com>
7661 * typemanager.cs (AreMultipleAllowed): Take care of the most
7662 obvious case where attribute type is not in the current assembly -
7665 2002-12-08 Miguel de Icaza <miguel@ximian.com>
7667 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
7668 definitions, instead of doing that afterwards.
7670 Also we use a nice little hack, depending on the constructor, we
7671 know if we are a "composed" name or a simple name. Hence, we
7672 avoid the IndexOf test, and we avoid
7674 * codegen.cs: Add code to assist in a bug reporter to track down
7675 the source of a compiler crash.
7677 2002-12-07 Ravi Pratap <ravi@ximian.com>
7679 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
7680 types have been emitted for a given element and flag an error
7681 if something which does not have AllowMultiple set is used more
7684 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
7685 attribute types and their corresponding AllowMultiple properties
7687 (AreMultipleAllowed): Check the property for a given type.
7689 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
7690 property in the case we have a TypeContainer.
7692 (Attributes.AddAttribute): Detect duplicates and just skip on
7693 adding them. This trivial fix catches a pretty gross error in our
7694 attribute emission - global attributes were being emitted twice!
7696 Bugzilla bug #33187 is now fixed.
7698 2002-12-06 Miguel de Icaza <miguel@ximian.com>
7700 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
7703 * expression.cs (Binary.ResolveOperator): I can only use the
7704 Concat (string, string, string) and Concat (string, string,
7705 string, string) if the child is actually a concatenation of
7708 2002-12-04 Miguel de Icaza <miguel@ximian.com>
7710 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
7711 context where we need a 2-character lookahead.
7713 * pending.cs (PendingImplementation): Rework so we can keep track
7714 of interface types all the time, and flag those which were
7715 implemented by parents as optional.
7717 2002-12-03 Miguel de Icaza <miguel@ximian.com>
7719 * expression.cs (Binary.ResolveOperator): Use
7720 String.Concat(string,string,string) or
7721 String.Concat(string,string,string,string) when possible.
7723 * typemanager: More helper methods.
7726 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
7728 * pending.cs: remove the bogus return from GetMissingInterfaces()
7729 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
7731 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7733 * namespace.cs: avoid duplicated 'using xxx' being added to
7734 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
7735 when we get more than one 'using' statement for the same namespace.
7736 Report a CS0105 warning for it.
7738 2002-11-30 Miguel de Icaza <miguel@ximian.com>
7740 * cs-tokenizer.cs (consume_identifier): use read directly, instead
7741 of calling getChar/putback, uses internal knowledge of it.
7743 (xtoken): Reorder tokenizer so most common patterns are checked
7744 first. This reduces the compilation time in another 5% (from 8.11s
7745 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
7747 The parsing time is 22% of the compilation in mcs, and from that
7748 64% is spent on the tokenization process.
7750 I tried using a binary search for keywords, but this is slower
7751 than the hashtable. Another option would be to do a couple of
7754 * Not use a StringBuilder, instead use an array of chars,
7755 with a set value. Notice that this way we could catch
7756 the 645 error without having to do it *afterwards*.
7758 * We could write a hand-parser to avoid the hashtable
7759 compares altogether.
7761 The identifier consumption process takes 37% of the tokenization
7762 time. Another 15% is spent on is_number. 56% of the time spent
7763 on is_number is spent on Int64.Parse:
7765 * We could probably choose based on the string length to
7766 use Int32.Parse or Int64.Parse and avoid all the 64-bit
7769 Another 3% is spend on wrapping `xtoken' in the `token' function.
7771 Handle 0xa0 as whitespace (#34752)
7773 2002-11-26 Miguel de Icaza <miguel@ximian.com>
7775 * typemanager.cs (IsCLRType): New routine to tell whether a type
7776 is one of the builtin types.
7778 Maybe it needs to use TypeCodes to be faster. Maybe we could use
7779 typecode in more places instead of doing pointer comparissions.
7780 We could leverage some knowledge about the way the typecodes are
7783 New code to cache namespaces in assemblies, it is currently not
7784 invoked, to be used soon.
7786 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
7788 * expression.cs (Binary.ResolveOperator): specially handle
7789 strings, and do not perform user-defined operator overloading for
7792 2002-11-24 Miguel de Icaza <miguel@ximian.com>
7794 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
7795 internalcall as it is a pretty simple operation; Avoid whenever
7796 possible to call Char.IsLetter.
7798 (consume_identifier): Cut by half the number of
7799 hashtable calls by merging the is_keyword and GetKeyword behavior.
7801 Do not short-circuit, because if we do, we
7802 report errors (ie, #if false && true would produce an invalid
7806 2002-11-24 Martin Baulig <martin@ximian.com>
7808 * expression.cs (Cast.TryReduce): If we're in checked syntax,
7809 check constant ranges and report a CS0221. Fixes #33186.
7811 2002-11-24 Martin Baulig <martin@ximian.com>
7813 * cs-parser.jay: Make this work for uninitialized variable
7814 declarations in the `for' initializer. Fixes #32416.
7816 2002-11-24 Martin Baulig <martin@ximian.com>
7818 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
7819 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
7821 2002-11-24 Martin Baulig <martin@ximian.com>
7823 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
7824 argument; if true, we also check for user-defined conversions.
7825 This is only needed if both arguments are of a user-defined type.
7826 Fixes #30443, added test-175.cs.
7827 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
7829 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
7831 2002-11-24 Martin Baulig <martin@ximian.com>
7833 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
7834 function to get the store opcode.
7835 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
7836 only emit the Ldelema if the store opcode is Stobj. You must run
7837 both test-34 and test-167 to test this. Fixes #34529.
7839 2002-11-23 Martin Baulig <martin@ximian.com>
7841 * ecore.cs (Expression.MemberLookup): Added additional
7842 `qualifier_type' argument which is used when we're being called
7843 from MemberAccess.DoResolve() and null if we're called from a
7845 (Expression.MemberLookupFailed): New method to report errors; this
7846 does the CS1540 check and reports the correct error message.
7848 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
7849 argument for the CS1540 check and redone the way how we're dealing
7850 with private members. See the comment in the source code for details.
7851 (FilterWithClosure): Reverted this back to revision 1.197; renamed
7852 `closure_start_type' to `closure_qualifier_type' and check whether
7853 it's not null. It was not this filter being broken, it was just
7854 being called with the wrong arguments.
7856 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
7857 and pass it the correct `qualifier_type'; this also does the error
7860 2002-11-22 Miguel de Icaza <miguel@ximian.com>
7862 * expression.cs (Invocation.EmitParams): If the we are dealing
7863 with a non-built-in value type, load its address as well.
7865 (ArrayCreation): Use a a pretty constant instead
7866 of the hardcoded value 2. Use 6 instead of 2 for the number of
7867 static initializers.
7869 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
7870 because they are not really value types, just glorified integers.
7872 * driver.cs: Do not append .exe, the CSC compiler does not do it.
7874 * ecore.cs: Remove redundant code for enumerations, make them use
7875 the same code path as everything else, fixes the casting issue
7876 with enumerations in Windows.Forms.
7878 * attribute.cs: Do only cast to string if it is a string, the
7879 validation happens later.
7881 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
7882 people upgrade their corlibs.
7884 * ecore.cs: Oops, enumerations were not following the entire code path
7886 2002-11-21 Miguel de Icaza <miguel@ximian.com>
7888 * typemanager.cs (FilterWithClosure): Commented out the test for
7889 1540 in typemanager.cs, as it has problems when accessing
7890 protected methods from a parent class (see test-174.cs).
7892 * attribute.cs (Attribute.ValidateGuid): new method.
7893 (Attribute.Resolve): Use above.
7895 2002-11-19 Miguel de Icaza <miguel@ximian.com>
7897 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
7899 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
7900 handling for enumerations, as we only needed the TypeContainer
7901 functionality to begin with (this is required for the fix below to
7902 work for enums that reference constants in a container class for
7905 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
7907 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
7908 a valid TypeBuilder to perform lookups on.o
7910 * class.cs (InheritableMemberSignatureCompare): Use true in the
7911 call to GetGetMethod and GetSetMethod, because we are comparing
7912 the signature, and we need to get the methods *even* if they are
7915 (PropertyBase.CheckBase): ditto.
7917 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
7918 GotoCase.Resolve): Use Peel on EmpytCasts.
7920 * ecore.cs (EmptyCast): drop child, add Peel method.
7922 2002-11-17 Martin Baulig <martin@ximian.com>
7924 * ecore.cs (EmptyCast.Child): New public property.
7926 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
7927 label resolved to an EmptyCast. Fixes #34162.
7928 (GotoCase.Resolve): Likewise.
7929 (Block.EmitMeta): Likewise.
7931 2002-11-17 Martin Baulig <martin@ximian.com>
7933 * expression.cs (Invocation.BetterConversion): Prefer int over
7934 uint; short over ushort; long over ulong for integer literals.
7935 Use ImplicitConversionExists instead of StandardConversionExists
7936 since we also need to check for user-defined implicit conversions.
7937 Fixes #34165. Added test-173.cs.
7939 2002-11-16 Martin Baulig <martin@ximian.com>
7941 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
7942 with the `true' and `false' literals. Fixes #33151.
7944 2002-11-16 Martin Baulig <martin@ximian.com>
7946 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
7947 October 22nd; don't do the cs1540 check for static members.
7949 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
7950 now using our own filter here and doing the cs1540 check again.
7952 2002-11-16 Martin Baulig <martin@ximian.com>
7954 * support.cs (InternalParameters): Don't crash if we don't have
7955 any fixed parameters. Fixes #33532.
7957 2002-11-16 Martin Baulig <martin@ximian.com>
7959 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
7960 when looking up static methods to make this work on Windows.
7963 2002-11-16 Martin Baulig <martin@ximian.com>
7965 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
7966 a setter rather than using PropertyInfo.CanWrite.
7968 2002-11-15 Nick Drochak <ndrochak@gol.com>
7970 * class.cs: Allow acces to block member by subclasses. Fixes build
7973 2002-11-14 Martin Baulig <martin@ximian.com>
7975 * class.cs (Constructor.Emit): Added the extern/block check.
7978 2002-11-14 Martin Baulig <martin@ximian.com>
7980 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
7981 iteration while looking for indexers, this is needed because the
7982 indexer may have a different name in our base classes. Fixed the
7983 error reporting (no indexers at all, not get accessor, no
7984 overloaded match). Fixes bug #33089.
7985 (IndexerAccess.DoResolveLValue): Likewise.
7987 2002-11-14 Martin Baulig <martin@ximian.com>
7989 * class.cs (PropertyBase.CheckBase): Make this work for multiple
7990 indexers. Fixes the first part of bug #33089.
7991 (MethodSignature.InheritableMemberSignatureCompare): Added support
7994 2002-11-13 Ravi Pratap <ravi@ximian.com>
7996 * attribute.cs (Attribute.Resolve): Catch the
7997 NullReferenceException and report it since it isn't supposed to
8000 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8002 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8003 LogicalOr and LogicalAnd that can benefit from recursively
8004 handling EmitBranchable. The code now should be nice for Paolo.
8006 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8008 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8009 the Type lookups, as we perform quite a number of lookups on
8010 non-Types. This can be removed once we can deterministically tell
8011 whether we have a type or a namespace in advance.
8013 But this might require special hacks from our corlib.
8017 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8018 and double which avoids a conversion from an integer to a double.
8020 * expression.cs: tiny optimization, avoid calling IsConstant,
8021 because it effectively performs the lookup twice.
8023 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8025 But a bogus return here to keep the semantics of the old code
8026 until the Mono runtime is fixed.
8028 * pending.cs (GetMissingInterfaces): New method used to remove all
8029 the interfaces that are already implemented by our parent
8030 classes from the list of pending methods.
8032 * interface.cs: Add checks for calls after ResolveTypeExpr.
8034 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8036 * class.cs (Class.Emit): Report warning 67: event not used if the
8037 warning level is beyond 3.
8039 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8040 being a NullLiteral.
8042 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8045 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8046 path that might fail if a type can not be resolved.
8048 * expression.cs (Binary.Emit): Emit unsigned versions of the
8051 * driver.cs: use error 5.
8053 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8055 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8057 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8059 * cs-parser.jay (switch_section): A beautiful patch from Martin
8060 Baulig that fixed 33094.
8062 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8064 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8065 Check whether the base is abstract and report an error if so.
8067 * expression.cs (IndexerAccess.DoResolveLValue,
8068 IndexerAccess.DoResolve): ditto.
8070 (Invocation.DoResolve): ditto.
8072 (Invocation.FullMethodDesc): Improve the report string.
8074 * statement.cs (Block): Eliminate IsVariableDefined as it is
8075 basically just a wrapper for GetVariableInfo.
8077 * ecore.cs (SimpleName): Use new
8079 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8080 type, as we return the actual parameter ref/unref state on a
8083 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8085 * support.cs: Return proper flags REF/OUT fixing the previous
8088 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8089 not used to mean `ref' but `ref or out' in ParameterReference
8091 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8092 full type signature instead of calling TypeManger.CSharpName
8095 * support.cs (InternalParameters.ParameterDesc): Do not compare
8096 directly to the modflags, because REF/OUT will actually be bitsets
8099 * delegate.cs (VerifyMethod): Check also the modifiers.
8101 * cs-tokenizer.cs: Fix bug where floating point values with an
8102 exponent where a sign was missing was ignored.
8104 * driver.cs: Allow multiple assemblies to be specified in a single
8107 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8109 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8110 because identifiers after a parenthesis would end up in this kind
8111 of production, and we needed to desamiguate it for having casts
8114 (UserDefinedType *) xxx
8116 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8118 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8119 we should set on the Bindingflags.NonPublic, but not turn on
8120 private_ok. private_ok controls whether a Private member is
8121 returned (this is chekced on the filter routine), while the
8122 BindingFlags.NonPublic just controls whether private/protected
8123 will be allowed. This fixes the problem part of the problem of
8124 private properties being allowed to be used in derived classes.
8126 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8127 so we can call the children DoResolveLValue method (this will
8128 properly signal errors on lvalue assignments to base properties)
8130 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8131 getter are null, and we have a property info, we know that this
8132 happened because the lookup failed, so we report an error 122 for
8133 protection level violation.
8135 We also silently return if setter and getter are null in the
8136 resolve functions, this condition only happens if we have flagged
8137 the error before. This is the other half of the problem.
8139 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8140 not have accessibility information, that is why we were returning
8141 true in the filter function in typemanager.cs.
8143 To properly report 122 (property is inaccessible because of its
8144 protection level) correctly, we report this error in ResolveAccess
8145 by failing if both the setter and the getter are lacking (ie, the
8148 DoResolve and DoLResolve have been modified to check for both
8149 setter/getter being null and returning silently, the reason being
8150 that I did not want to put the knowledge about this error in upper
8153 int old = Report.Errors;
8154 x = new PropertyExpr (...);
8155 if (old != Report.Errors)
8160 So the property expr is returned, but it is invalid, so the error
8161 will be flagged during the resolve process.
8163 * class.cs: Remove InheritablePropertySignatureCompare from the
8164 class, as we no longer depend on the property signature to compute
8165 whether it is possible to implement a method or not.
8167 The reason is that calling PropertyInfo.GetGetMethod will return
8168 null (in .NET, in Mono it works, and we should change this), in
8169 cases where the Get Method does not exist in that particular
8174 class X { public virtual int A { get { return 1; } } }
8176 class Z : Y { public override int A { get { return 2; } } }
8178 Would fail in Z because the parent (Y) would not have the property
8179 defined. So we avoid this completely now (because the alternative
8180 fix was ugly and slow), and we now depend exclusively on the
8183 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8184 reference method, instead of using the property.
8186 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8187 routines are gone now.
8189 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8190 names, they were incorrectly named.
8192 * cs-tokenizer.cs: Return are more gentle token on failure.
8194 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8195 had an out-of-sync index variable, which caused it to remove from
8196 the list of pending methods the wrong method sometimes.
8198 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8200 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8201 CanWrite, because those refer to this particular instance of the
8202 property, and do not take into account the fact that we can
8203 override single members of a property.
8205 Constructor requires an EmitContext. The resolution process does
8206 not happen here, but we need to compute the accessors before,
8207 because the resolution does not always happen for properties.
8209 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8210 subclass, before we did not update this flag, but we did update
8213 (GetAccessors): Drop this routine, as it did not work in the
8214 presence of partially overwritten set/get methods.
8216 Notice that this broke the cs1540 detection, but that will require
8219 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8223 * driver.cs: issue a warning instead of an error if we don't support
8224 debugging for the platform. Also ignore a couple of errors that may
8225 arise when trying to write the symbols. Undo my previous patch.
8227 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8229 * driver.cs: ignore /debug switch except for Unix platforms.
8231 2002-10-23 Nick Drochak <ndrochak@gol.com>
8233 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8235 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8237 * driver.cs: Do not make mcs-debug conditional, so we do not break
8240 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8241 review this patch. But basically after all the children variables
8242 have been merged, the value of "Breaks" was not being set to
8243 new_breaks for Switch blocks. I think that it should be set after
8244 it has executed. Currently I set this to the value of new_breaks,
8245 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8246 conservative, but I do not understand this code very well.
8248 I did not break anything in the build, so that is good ;-)
8250 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8252 2002-10-20 Mark Crichton <crichton@gimp.org>
8254 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8256 2002-10-20 Nick Drochak <ndrochak@gol.com>
8258 * cfold.cs: Fixed compile blocker.
8260 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8262 * driver.cs: I was chekcing the key, not the file.
8264 2002-10-19 Ravi Pratap <ravi@ximian.com>
8266 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8267 message that we were generating - we just need to silently return
8270 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8272 * class.cs (Event.Define): Change my previous commit, as this
8273 breaks the debugger. This is a temporary hack, as it seems like
8274 the compiler is generating events incorrectly to begin with.
8276 * expression.cs (Binary.ResolveOperator): Added support for
8277 "U operator - (E x, E y)"
8279 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8282 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8283 init-only variables, but this path did not take into account that
8284 there might be also instance readonly variables. Correct this
8287 This fixes bug 32253
8289 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8292 * driver.cs: Change the extension for modules to `netmodule'
8294 * cs-parser.jay: Improved slightly the location tracking for
8295 the debugger symbols.
8297 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8298 modifiers that were specified instead of the hardcoded value
8299 (FamAndAssem). This was basically ignoring the static modifier,
8300 and others. Fixes 32429.
8302 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8303 fixed a bug in the process (32476)
8305 * expression.cs (ArrayAccess.EmitAssign): Patch from
8306 hwang_rob@yahoo.ca that fixes bug 31834.3
8308 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8310 * driver.cs: Make the module extension .netmodule.
8312 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8314 * driver.cs: Report an error if the resource file is not found
8315 instead of crashing.
8317 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8318 false, like Emit does.
8320 2002-10-16 Nick Drochak <ndrochak@gol.com>
8322 * typemanager.cs: Remove unused private member. Also reported mcs
8323 bug to report this as a warning like csc.
8325 2002-10-15 Martin Baulig <martin@gnome.org>
8327 * statement.cs (Statement.Emit): Made this a virtual method; emits
8328 the line number info and calls DoEmit().
8329 (Statement.DoEmit): New protected abstract method, formerly knows
8330 as Statement.Emit().
8332 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8334 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8336 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8337 have fixed a remaining problem: not every AddXXXX was adding a
8338 fully qualified name.
8340 Now everyone registers a fully qualified name in the DeclSpace as
8341 being defined instead of the partial name.
8343 Downsides: we are slower than we need to be due to the excess
8344 copies and the names being registered this way.
8346 The reason for this is that we currently depend (on the corlib
8347 bootstrap for instance) that types are fully qualified, because
8348 we dump all the types in the namespace, and we should really have
8349 types inserted into the proper namespace, so we can only store the
8350 basenames in the defined_names array.
8352 2002-10-10 Martin Baulig <martin@gnome.org>
8354 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8355 from bug #31834, see the bug report for a testcase which is
8358 2002-10-10 Martin Baulig <martin@gnome.org>
8360 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8361 flow analysis code for this.
8363 * statement.cs (Do, While, For): Tell the flow analysis code about
8365 (FlowBranching.UsageVector): Added support for infinite loops.
8366 (Block.Resolve): Moved the dead code elimination here and use flow
8369 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8371 * class.cs (Field.Define): Catch cycles on struct type
8374 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8375 fields if the fields are static. We only need to check instance
8378 * expression.cs (As.DoResolve): Test for reference type.
8380 * statement.cs (Using.ResolveExpression): Use
8381 ConvertImplicitRequired, not ConvertImplicit which reports an
8383 (Using.ResolveLocalVariableDecls): ditto.
8385 * expression.cs (Binary.ResolveOperator): Report errors in a few
8386 places where we had to.
8388 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8390 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8392 * expression.cs: Use StoreFromPtr instead of extracting the type
8393 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8395 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8396 an enumeration value to a System.Enum, but System.Enum is not a
8397 value type, but an class type, so we need to box.
8399 (Expression.ConvertExplicit): One codepath could return
8400 errors but not flag them. Fix this. Fixes #31853
8402 * parameter.cs (Resolve): Do not allow void as a parameter type.
8404 2002-10-06 Martin Baulig <martin@gnome.org>
8406 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8407 if it's a class type and not a struct. Fixes #31815.
8409 2002-10-06 Martin Baulig <martin@gnome.org>
8411 * statement.cs: Reworked the flow analysis code a bit to make it
8412 usable for dead code elimination.
8414 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8416 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8418 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8420 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8421 to fix the test 165, will investigate deeper.
8423 2002-10-04 Martin Baulig <martin@gnome.org>
8425 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8426 finally blocks actually work.
8427 (Try.Resolve): We don't need to create a sibling for `finally' if
8428 there is no finally block.
8430 2002-10-04 Martin Baulig <martin@gnome.org>
8432 * class.cs (Constructor.Define): The default accessibility for a
8433 non-default constructor is private, not public.
8435 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8437 * class.cs (Constructor): Make AllowedModifiers public, add
8440 * cs-parser.jay: Perform the modifiers test here, as the
8441 constructor for the Constructor class usually receives a zero
8442 because of the way we create it (first we create, later we
8443 customize, and we were never checking the modifiers).
8445 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8446 is a version of LookupTypeReflection that includes the type-name
8447 cache. This can be used as a fast path for functions that know
8448 the fully qualified name and are only calling into *.GetType() to
8449 obtain a composed type.
8451 This is also used by TypeManager.LookupType during its type
8454 (LookupType): We now also track the real type name, as sometimes
8455 we can get a quey for the real type name from things like
8456 ComposedCast. This fixes bug 31422.
8458 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8459 complete type fullname, it does not have to go through the type
8460 resolution system to obtain the composed version of the type (for
8461 obtaining arrays or pointers).
8463 (Conditional.Emit): Use the EmitBoolExpression to
8464 generate nicer code, as requested by Paolo.
8466 (ArrayCreation.CheckIndices): Use the patch from
8467 hwang_rob@yahoo.ca to validate the array initializers.
8469 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8471 * class.cs (ConstructorInitializer.Emit): simplify code by using
8472 Invocation.EmitCall, and at the same time, fix the bugs in calling
8473 parent constructors that took variable arguments.
8475 * ecore.cs (Expression.ConvertNumericExplicit,
8476 Expression.ImplicitNumericConversion): Remove the code that
8477 manually wrapped decimal (InternalTypeConstructor call is now gone
8480 * expression.cs (Cast.TryReduce): Also handle decimal types when
8481 trying to perform a constant fold on the type.
8483 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8485 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8486 that only turned off an error report, and did nothing else.
8488 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8490 * driver.cs: Handle and ignore /fullpaths
8492 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8494 * expression.cs (Binary.ResolveOperator): Catch the case where
8495 DoNumericPromotions returns true,
8497 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8499 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8501 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8504 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8506 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8507 conversion exists, but it is also required that the conversion be
8508 performed. This manifested in "(Type64Enum) 2".
8510 * class.cs (TypeManager.AddMethod): The fix is not to change
8511 AddEnum, because that one was using a fully qualified name (every
8512 DeclSpace derivative does), but to change the AddMethod routine
8513 that was using an un-namespaced name. This now correctly reports
8514 the duplicated name.
8516 Revert patch until I can properly fix it. The issue
8517 is that we have a shared Type space across all namespaces
8518 currently, which is wrong.
8520 Options include making the Namespace a DeclSpace, and merge
8521 current_namespace/current_container in the parser.
8523 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8525 * cs-parser.jay: Improve error reporting when we get a different
8526 kind of expression in local_variable_type and
8527 local_variable_pointer_type.
8529 Propagate this to avoid missleading errors being reported.
8531 * ecore.cs (ImplicitReferenceConversion): treat
8532 TypeManager.value_type as a target just like object_type. As
8537 Is valid, and needs to result in the int 1 being boxed before it
8538 is assigned to the value type v.
8540 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8541 to validate the enumeration name.
8543 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8544 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8545 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8547 * ecore.cs (TryImplicitIntConversion): When doing an
8548 implicit-enumeration-conversion, check if the type is 64-bits and
8549 perform a conversion before passing to EnumConstant.
8551 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8553 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8554 report ambiguous type references. Unlike the MS version, we
8555 report what the ambiguity is. Innovation at work ;-)
8557 (DeclSpace.FindType): Require a location argument to
8558 display when we display an ambiguous error.
8560 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8562 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8564 * expression.cs (EmitDynamicInitializers): Apply patch from
8565 hwang_rob@yahoo.ca that fixes the order in which we emit our
8568 2002-09-21 Martin Baulig <martin@gnome.org>
8570 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8571 delegate takes no arguments.
8573 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8575 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8578 * expression.cs: Extract the underlying type.
8580 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
8582 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
8584 2002-09-19 Miguel de Icaza <miguel@ximian.com>
8586 * class.cs (TypeContainer.DefineType): We can not use the nice
8587 PackingSize with the size set to 1 DefineType method, because it
8588 will not allow us to define the interfaces that the struct
8591 This completes the fixing of bug 27287
8593 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
8594 means also structs. This fixes part of the problem.
8595 (Expresion.ImplicitReferenceConversionExists): ditto.
8597 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8598 error if there were no errors reported during the type lookup
8599 process, to avoid duplicates or redundant errors. Without this
8600 you would get an ambiguous errors plus a type not found. We have
8601 beaten the user enough with the first error.
8603 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8606 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8607 during the resolution process, stop the lookup, this avoids
8608 repeated error reports (same error twice).
8610 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8612 * typemanager.cs (LookupType): Redo the type lookup code to match
8613 the needs of System.Reflection.
8615 The issue is that System.Reflection requires references to nested
8616 types to begin with a "+" sign instead of a dot. So toplevel
8617 types look like: "NameSpace.TopLevelClass", and nested ones look
8618 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
8621 2002-09-19 Martin Baulig <martin@gnome.org>
8623 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
8624 says that a method always returns or always throws an exception,
8625 don't report the CS0161.
8627 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
8628 set `Returns = new_returns'.
8630 2002-09-19 Martin Baulig <martin@gnome.org>
8632 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
8633 to an enum constant, check for a CS0176.
8635 2002-09-18 Miguel de Icaza <miguel@ximian.com>
8637 * class.cs (TypeContainer.CheckPairedOperators): Now we check
8638 for operators that must be in pairs and report errors.
8640 * ecore.cs (SimpleName.DoResolveType): During the initial type
8641 resolution process, when we define types recursively, we must
8642 check first for types in our current scope before we perform
8643 lookups in the enclosing scopes.
8645 * expression.cs (MakeByteBlob): Handle Decimal blobs.
8647 (Invocation.VerifyArgumentsCompat): Call
8648 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
8649 I thought we were supposed to always call this, but there are a
8650 few places in the code where we dont do it.
8652 2002-09-17 Miguel de Icaza <miguel@ximian.com>
8654 * driver.cs: Add support in -linkres and -resource to specify the
8655 name of the identifier.
8657 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8659 * ecore.cs (StandardConversionExists): Sync with the conversion
8660 code: allow anything-* to void* conversions.
8662 (FindMostSpecificSource): Use an Expression argument
8663 instead of a Type, because we might be handed over a Literal which
8664 gets a few more implicit conversions that plain types do not. So
8665 this information was being lost.
8667 Also, we drop the temporary type-holder expression when not
8670 2002-09-17 Martin Baulig <martin@gnome.org>
8672 * class.cs (PropertyBase.CheckBase): Don't check the base class if
8673 this is an explicit interface implementation.
8675 2002-09-17 Martin Baulig <martin@gnome.org>
8677 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
8678 different `IndexerName' attributes.
8680 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
8681 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
8682 virtual CommonResolve().
8684 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8686 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
8687 and convert that to the UnderlyingType.
8689 * statement.cs (Foreach.Resolve): Indexers are just like variables
8690 or PropertyAccesses.
8692 * cs-tokenizer.cs (consume_string): Track line numbers and columns
8693 inside quoted strings, we were not doing this before.
8695 2002-09-16 Martin Baulig <martin@gnome.org>
8697 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
8698 resolve it. This is needed for the definite assignment check of the
8699 instance expression, fixes bug #29846.
8700 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
8702 2002-09-16 Nick Drochak <ndrochak@gol.com>
8704 * parameter.cs: Fix compile error. Cannot reference static member
8705 from an instance object. Is this an mcs bug?
8707 2002-09-14 Martin Baulig <martin@gnome.org>
8709 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
8710 multiple times. Fixes bug #30295, added test-166.cs.
8712 2002-09-14 Martin Baulig <martin@gnome.org>
8714 * statement.cs (Block.Emit): Don't emit unreachable code.
8715 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
8717 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
8719 2002-09-14 Martin Baulig <martin@gnome.org>
8721 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
8724 2002-09-14 Martin Baulig <martin@gnome.org>
8726 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
8727 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
8728 be false on the ms runtime.
8730 2002-09-13 Martin Baulig <martin@gnome.org>
8732 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
8733 the CS0038 error message.
8735 2002-09-12 Miguel de Icaza <miguel@ximian.com>
8737 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
8738 constant inside, return it.
8740 2002-09-12 Martin Baulig <martin@gnome.org>
8742 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
8743 implicit conversion can be done between enum types.
8745 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
8746 check whether an implicit conversion to the current enum's UnderlyingType
8747 exists and report an error if not.
8749 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
8750 without debugging support.
8752 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
8753 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
8755 2002-09-12 Martin Baulig <martin@gnome.org>
8757 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
8759 * ecore.cs (IMemberExpr.DeclaringType): New property.
8760 (SimpleName.SimpleNameResolve): Check whether we're accessing a
8761 nonstatic member of an outer type (CS0038).
8763 2002-09-11 Miguel de Icaza <miguel@ximian.com>
8765 * driver.cs: Activate the using-error detector at warning level
8766 4 (at least for MS-compatible APIs).
8768 * namespace.cs (VerifyUsing): Small buglett fix.
8770 * pending.cs (PendingImplementation): pass the container pointer.
8772 * interface.cs (GetMethods): Allow for recursive definition. Long
8773 term, I would like to move every type to support recursive
8774 definitions, not the current ordering mechanism that we have right
8777 The situation is this: Attributes are handled before interfaces,
8778 so we can apply attributes to interfaces. But some attributes
8779 implement interfaces, we will now handle the simple cases
8780 (recursive definitions will just get an error).
8782 * parameter.cs: Only invalidate types at the end if we fail to
8785 2002-09-09 Martin Baulig <martin@gnome.org>
8787 * ecore.cs (PropertyExpr.Emit): Also check for
8788 TypeManager.system_int_array_get_length so this'll also work when
8789 compiling corlib. Fixes #30003.
8791 2002-09-09 Martin Baulig <martin@gnome.org>
8793 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
8794 and throw an exception if we can't get the type's size. Fixed #30040,
8797 2002-09-09 Martin Baulig <martin@gnome.org>
8799 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
8801 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
8802 context. Fixes bug #30027.
8804 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
8805 virtual functions. Fixes bug #30043, added test-164.cs.
8807 2002-09-08 Ravi Pratap <ravi@ximian.com>
8809 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
8811 2002-09-08 Nick Drochak <ndrochak@gol.com>
8813 * driver.cs: Use an object to get the windows codepage since it's not a
8816 2002-09-08 Miguel de Icaza <miguel@ximian.com>
8818 * statement.cs (For.Emit): for infinite loops (test == null)
8819 return whether there is a break inside, not always "true".
8821 * namespace.cs (UsingEntry): New struct to hold the name of the
8822 using definition, the location where it is defined, and whether it
8823 has been used in a successful type lookup.
8825 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
8830 2002-09-06 Ravi Pratap <ravi@ximian.com>
8832 * attribute.cs : Fix incorrect code which relied on catching
8833 a NullReferenceException to detect a null being passed in
8834 where an object was expected.
8836 2002-09-06 Miguel de Icaza <miguel@ximian.com>
8838 * statement.cs (Try): flag the catch variable as assigned
8840 * expression.cs (Cast): Simplified by using ResolveType instead of
8843 * statement.cs (Catch): Fix bug by using ResolveType.
8845 2002-09-06 Ravi Pratap <ravi@ximian.com>
8847 * expression.cs (BetterConversion): Special case for when we have
8848 a NullLiteral as the argument and we have to choose between string
8849 and object types - we choose string the way csc does.
8851 * attribute.cs (Attribute.Resolve): Catch the
8852 NullReferenceException and report error #182 since the Mono
8853 runtime no more has the bug and having this exception raised means
8854 we tried to select a constructor which takes an object and is
8857 2002-09-05 Ravi Pratap <ravi@ximian.com>
8859 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
8860 message (1502, 1503) when we can't locate a method after overload
8861 resolution. This is much more informative and closes the bug
8864 * interface.cs (PopulateMethod): Return if there are no argument
8865 types. Fixes a NullReferenceException bug.
8867 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
8868 expressions too. Previously we were checking only in one place for
8869 positional arguments leaving out named arguments.
8871 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
8872 type to the enum type is not allowed. Remove code corresponding to
8875 (ConvertNumericExplicit): Allow explicit conversions from
8876 the underlying type to enum type. This precisely follows the spec
8877 and closes a bug filed by Gonzalo.
8879 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8882 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
8884 2002-09-03 Miguel de Icaza <miguel@ximian.com>
8886 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
8887 it was important that we stored the right value after the
8888 reduction in `converted'.
8890 2002-09-04 Martin Baulig <martin@gnome.org>
8892 * location.cs (Location.SymbolDocument): Use full pathnames for the
8895 2002-08-30 Miguel de Icaza <miguel@ximian.com>
8897 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
8898 of the expression resolve mechanism, because that will catch the
8899 SimpleName error failures.
8901 (Conditional): If we can not resolve the
8902 expression, return, do not crash.
8904 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8907 (location): display token name instead of its number.
8909 2002-08-28 Martin Baulig <martin@gnome.org>
8911 * expression.cs (Binary.ResolveOperator): Don't silently return
8912 but return an error if an operator cannot be applied between two
8915 2002-08-28 Martin Baulig <martin@gnome.org>
8917 * class.cs (Constructor.Define): Set the permission attributes
8918 correctly instead of making all constructors public.
8920 2002-08-28 Martin Baulig <martin@gnome.org>
8922 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
8923 for private members before reporting a CS0103; if we find anything,
8926 2002-08-28 Martin Baulig <martin@gnome.org>
8928 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
8929 to check whether `closure_start_type == closure_invocation_type',
8930 we also need to check whether `m.DeclaringType == closure_invocation_type'
8931 before bypassing the permission checks. We might be accessing
8932 protected/private members from the base class.
8933 (TypeManager.RealMemberLookup): Only set private_ok if private
8934 members were requested via BindingFlags.NonPublic.
8936 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
8938 * expression.cs (MemberAccess.ResolveMemberAccess): Set
8939 MethodGroupExpr.IsExplicitImpl if appropriate.
8940 (Invocation.DoResolve): Don't report the CS0120 for explicit
8941 interface implementations.
8943 2002-08-27 Martin Baulig <martin@gnome.org>
8945 * expression.cs (Invocation.DoResolve): If this is a static
8946 method and we don't have an InstanceExpression, we must report
8949 2002-08-25 Martin Baulig <martin@gnome.org>
8951 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
8952 `==' between a valuetype and an object.
8954 2002-08-25 Miguel de Icaza <miguel@ximian.com>
8956 * ecore.cs (TypeExpr): Provide a ToString method.
8958 2002-08-24 Martin Baulig <martin@gnome.org>
8960 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
8961 now called proggie.dbg and it's a binary file.
8963 2002-08-23 Martin Baulig <martin@gnome.org>
8965 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
8967 2002-08-23 Martin Baulig <martin@gnome.org>
8969 * struct.cs (MyStructInfo.ctor): Make this work with empty
8970 structs; it's not allowed to use foreach() on null.
8972 2002-08-23 Martin Baulig <martin@gnome.org>
8974 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
8975 writer the full pathname of the generated assembly.
8977 2002-08-23 Martin Baulig <martin@gnome.org>
8979 * statements.cs (FlowBranching.UsageVector.MergeChildren):
8980 A `finally' block never returns or breaks; improved handling of
8983 2002-08-23 Martin Baulig <martin@gnome.org>
8985 * statement.cs (Throw.Resolve): Allow `throw null'.
8987 2002-08-23 Martin Baulig <martin@gnome.org>
8989 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
8990 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
8991 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
8992 MemberLookup would return a wrong event if this is an explicit
8993 interface implementation and the class has an event with the same
8996 2002-08-23 Martin Baulig <martin@gnome.org>
8998 * statement.cs (Block.AddChildVariableNames): New public method.
8999 (Block.AddChildVariableName): Likewise.
9000 (Block.IsVariableNameUsedInChildBlock): Likewise.
9001 (Block.AddVariable): Check whether a variable name has already
9002 been used in a child block.
9004 * cs-parser.jay (declare_local_variables): Mark all variable names
9005 from the current block as being used in a child block in the
9008 2002-08-23 Martin Baulig <martin@gnome.org>
9010 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9011 find the symbol writer.
9013 * driver.cs: csc also allows the arguments to /define being
9014 separated by commas, not only by semicolons.
9016 2002-08-23 Martin Baulig <martin@gnome.org>
9018 * interface.cs (Interface.GetMembers): Added static check for events.
9020 2002-08-15 Martin Baulig <martin@gnome.org>
9022 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9023 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9025 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9026 why the MethodData.EmitDestructor() change was necessary.
9028 2002-08-20 Martin Baulig <martin@gnome.org>
9030 * class.cs (TypeContainer.FindMembers): Added static check for events.
9032 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9034 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9035 use Type.GetEvents(), not Type.FindMembers().
9037 2002-08-20 Martin Baulig <martin@gnome.org>
9039 * decl.cs (MemberCache): Added a special method cache which will
9040 be used for method-only searched. This ensures that a method
9041 search will return a MethodInfo with the correct ReflectedType for
9044 2002-08-20 Martin Baulig <martin@gnome.org>
9046 * decl.cs (DeclSpace.FindMembers): Made this public.
9048 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9050 * delegate.cs: fixed build on windows.
9051 [FIXME: Filed as bug #29150: MCS must report these errors.]
9053 2002-08-19 Ravi Pratap <ravi@ximian.com>
9055 * ecore.cs (StandardConversionExists): Return a false
9056 if we are trying to convert the void type to anything else
9057 since that is not allowed.
9059 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9060 we flag error 70 in the event an event is trying to be accessed
9061 directly from outside the declaring type.
9063 2002-08-20 Martin Baulig <martin@gnome.org>
9065 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9066 MemberCache from typemanager.cs to decl.cs.
9068 2002-08-19 Martin Baulig <martin@gnome.org>
9070 * class.cs (TypeContainer): Implement IMemberContainer.
9071 (TypeContainer.DefineMembers): Create the MemberCache.
9072 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9073 return public members if BindingFlags.Public was given, check
9074 whether members are static.
9076 2002-08-16 Martin Baulig <martin@gnome.org>
9078 * decl.cs (DeclSpace.Define): Splitted this in Define and
9079 DefineMembers. DefineMembers is called first and initializes the
9082 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9083 DefineMembers() on all our DeclSpaces.
9085 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9086 but call DefineMembers() on all nested interfaces. We call their
9087 Define() in our new Define() function.
9089 * interface.cs (Interface): Implement IMemberContainer.
9090 (Interface.Define): Moved all code except the attribute stuf to
9092 (Interface.DefineMembers): Initialize the member cache.
9094 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9095 need this anymore since we can use MemberCache.FindMembers directly.
9097 2002-08-19 Martin Baulig <martin@gnome.org>
9099 * typemanager.cs (MemberCache): When creating the cache for an
9100 interface type, add all inherited members.
9101 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9102 to `out bool used_cache' and documented it.
9103 (TypeManager.MemberLookup): If we already used the cache in the first
9104 iteration, we don't need to do the interfaces check.
9106 2002-08-19 Martin Baulig <martin@gnome.org>
9108 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9109 here from IMemberFinder and don't implement this interface anymore.
9110 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9112 * typemanager.cs (IMemberFinder): This interface is now only used by
9113 classes which actually support the member cache.
9114 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9115 since we only put DeclSpaces into this Hashtable.
9116 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9117 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9119 2002-08-16 Martin Baulig <martin@gnome.org>
9121 * typemanager.cs (ICachingMemberFinder): Removed.
9122 (IMemberFinder.MemberCache): New property.
9123 (TypeManager.FindMembers): Merged this with RealFindMembers().
9124 This function will never be called from TypeManager.MemberLookup()
9125 so we can't use the cache here, just the IMemberFinder.
9126 (TypeManager.MemberLookup_FindMembers): Check whether the
9127 IMemberFinder has a MemberCache and call the cache's FindMembers
9129 (MemberCache): Rewrote larger parts of this yet another time and
9130 cleaned it up a bit.
9132 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9134 * driver.cs (LoadArgs): Support quoting.
9136 (Usage): Show the CSC-like command line arguments.
9138 Improved a few error messages.
9140 2002-08-15 Martin Baulig <martin@gnome.org>
9142 * typemanager.cs (IMemberContainer.Type): New property.
9143 (IMemberContainer.IsInterface): New property.
9145 The following changes are conditional to BROKEN_RUNTIME, which is
9146 defined at the top of the file.
9148 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9149 class'es members, but add all members from TypeHandle.ObjectType
9150 if we're an interface.
9151 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9152 is the current type.
9153 (MemberCache.CacheEntry.Container): Removed this field.
9154 (TypeHandle.GetMembers): Include inherited members.
9156 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9158 * typemanager.cs: fixed compilation and added a comment on a field that
9161 2002-08-15 Martin Baulig <martin@gnome.org>
9163 * class.cs (ConstructorInitializer.Resolve): In the
9164 Expression.MemberLookup call, use the queried_type as
9167 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9168 declared' attribute, it's always true.
9169 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9170 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9171 temporary wrapper for FindMembers which tells MemberLookup whether
9172 members from the base classes are included in the return value.
9173 This will go away soon.
9174 (TypeManager.MemberLookup): Use this temporary hack here; once the
9175 new MemberCache is completed, we don't need to do the DeclaredOnly
9176 looping here anymore since the MemberCache will take care of this.
9177 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9178 (MemberCache): When creating the MemberCache for a class, get
9179 members from the current class and all its base classes.
9180 (MemberCache.CacheEntry.Container): New field. This is a
9181 temporary hack until the Mono runtime is fixed to distinguish
9182 between ReflectedType and DeclaringType. It allows us to use MCS
9183 with both the MS runtime and the unfixed Mono runtime without
9184 problems and without accecting performance.
9185 (MemberCache.SearchMembers): The DeclaredOnly looping from
9186 TypeManager.MemberLookup is now done here.
9188 2002-08-14 Martin Baulig <martin@gnome.org>
9190 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9191 Type.GetFields on dynamic types but get the fields from the
9192 corresponding TypeContainer.
9193 (MyStructInfo.GetStructInfo): Added check for enum types.
9195 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9196 (MemberList.SyncRoot): Implemented.
9197 (TypeManager.FilterWithClosure): No need to check permissions if
9198 closure_start_type == closure_invocation_type, don't crash if
9199 closure_invocation_type is null.
9201 2002-08-13 Martin Baulig <martin@gnome.org>
9203 Rewrote TypeContainer.FindMembers to use a member cache. This
9204 gives us a speed increase of about 35% for the self-hosting MCS
9205 build and of about 15-20% for the class libs (both on GNU/Linux).
9207 * report.cs (Timer): New class to get enhanced profiling. This
9208 whole class is "TIMER" conditional since it remarkably slows down
9211 * class.cs (MemberList): New class. This is an IList wrapper
9212 which we're now using instead of passing MemberInfo[]'s around to
9213 avoid copying this array unnecessarily.
9214 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9215 (ICachingMemberFinder, IMemberContainer): New interface.
9216 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9217 has already been checked, otherwise use it for the name comparision.
9218 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9219 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9220 if possible. Returns a MemberList, not a MemberInfo [].
9221 (TypeHandle): New class, implements IMemberContainer. We create
9222 one instance of this class per type, it contains a MemberCache
9223 which is used to do the member lookups.
9224 (MemberCache): New class. Each instance of this class contains
9225 all members of a type and a name-based hash table.
9226 (MemberCache.FindMembers): This is our new member lookup
9227 function. First, it looks up all members of the requested name in
9228 the hash table. Then, it walks this list and sorts out all
9229 applicable members and returns them.
9231 2002-08-13 Martin Baulig <martin@gnome.org>
9233 In addition to a nice code cleanup, this gives us a performance
9234 increase of about 1.4% on GNU/Linux - not much, but it's already
9235 half a second for the self-hosting MCS compilation.
9237 * typemanager.cs (IMemberFinder): New interface. It is used by
9238 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9239 Enum, Delegate or Interface.
9240 (TypeManager.finder_to_member_finder): New PtrHashtable.
9241 (TypeManager.finder_to_container): Removed.
9242 (TypeManager.finder_to_delegate): Removed.
9243 (TypeManager.finder_to_interface): Removed.
9244 (TypeManager.finder_to_enum): Removed.
9246 * interface.cs (Interface): Implement IMemberFinder.
9248 * delegate.cs (Delegate): Implement IMemberFinder.
9250 * enum.cs (Enum): Implement IMemberFinder.
9252 * class.cs (TypeContainer): Implement IMemberFinder.
9254 2002-08-12 Martin Baulig <martin@gnome.org>
9256 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9258 2002-08-12 Martin Baulig <martin@gnome.org>
9260 * ecore.cs (ITypeExpression): New interface for expressions which
9262 (TypeExpression): Renamed to TypeLookupExpression.
9263 (Expression.DoResolve): If we're doing a types-only lookup, the
9264 expression must implement the ITypeExpression interface and we
9265 call DoResolveType() on it.
9266 (SimpleName): Implement the new ITypeExpression interface.
9267 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9268 hack, the situation that we're only looking up types can't happen
9269 anymore when this method is called. Moved the type lookup code to
9270 DoResolveType() and call it.
9271 (SimpleName.DoResolveType): This ITypeExpression interface method
9272 is now doing the types-only lookup.
9273 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9274 (ResolveFlags): Added MaskExprClass.
9276 * expression.cs (MemberAccess): Implement the ITypeExpression
9278 (MemberAccess.DoResolve): Added support for a types-only lookup
9279 when we're called via ITypeExpression.DoResolveType().
9280 (ComposedCast): Implement the ITypeExpression interface.
9282 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9283 Expression.Resolve() with ResolveFlags.Type instead.
9285 2002-08-12 Martin Baulig <martin@gnome.org>
9287 * interface.cs (Interface.Define): Apply attributes.
9289 * attribute.cs (Attribute.ApplyAttributes): Added support for
9290 interface attributes.
9292 2002-08-11 Martin Baulig <martin@gnome.org>
9294 * statement.cs (Block.Emit): Only check the "this" variable if we
9295 do not always throw an exception.
9297 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9298 whether the property has a set accessor.
9300 2002-08-11 Martin Baulig <martin@gnome.org>
9302 Added control flow analysis support for structs.
9304 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9305 with control flow analysis turned off.
9306 (IVariable): New interface.
9307 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9308 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9309 (FieldExpr.DoResolve): Resolve the instance expression with flow
9310 analysis turned off and do the definite assignment check after the
9311 resolving when we know what the expression will resolve to.
9313 * expression.cs (LocalVariableReference, ParameterReference):
9314 Implement the new IVariable interface, only call the flow analysis
9315 code if ec.DoFlowAnalysis is true.
9316 (This): Added constructor which takes a Block argument. Implement
9317 the new IVariable interface.
9318 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9319 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9320 This does the definite assignment checks for struct members.
9322 * class.cs (Constructor.Emit): If this is a non-static `struct'
9323 constructor which doesn't have any initializer, call
9324 Block.AddThisVariable() to tell the flow analysis code that all
9325 struct elements must be initialized before control returns from
9328 * statement.cs (MyStructInfo): New public class.
9329 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9330 argument to this indexer. If non-zero, check an individual struct
9331 member, not the whole struct.
9332 (FlowBranching.CheckOutParameters): Check struct members.
9333 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9334 overloaded versions of these methods which take an additional
9335 `int field_idx' argument to check struct members.
9336 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9337 overloaded versions of these methods which take an additional
9338 `string field_name' argument to check struct member.s
9339 (VariableInfo): Implement the IVariable interface.
9340 (VariableInfo.StructInfo): New public property. Returns the
9341 MyStructInfo instance of the variable if it's a struct or null.
9342 (Block.AddThisVariable): New public method. This is called from
9343 Constructor.Emit() for non-static `struct' constructor which do
9344 not have any initializer. It creates a special variable for the
9345 "this" instance variable which will be checked by the flow
9346 analysis code to ensure that all of the struct's fields are
9347 initialized before control returns from the constructor.
9348 (UsageVector): Added support for struct members. If a
9349 variable/parameter is a struct with N members, we reserve a slot
9350 in the usage vector for each member. A struct is considered fully
9351 initialized if either the struct itself (slot 0) or all its
9352 members are initialized.
9354 2002-08-08 Martin Baulig <martin@gnome.org>
9356 * driver.cs (Driver.MainDriver): Only report an error CS5001
9357 if there were no compilation errors.
9359 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9360 `UnsafeContext' property to determine whether the parent is in
9361 unsafe context rather than checking the parent's ModFlags:
9362 classes nested in an unsafe class are unsafe as well.
9364 2002-08-08 Martin Baulig <martin@gnome.org>
9366 * statement.cs (UsageVector.MergeChildren): Distinguish between
9367 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9368 we return. Added test17() and test18() to test-154.cs.
9370 2002-08-08 Martin Baulig <martin@gnome.org>
9372 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9373 Family access, make sure the invoking type isn't a subclass of the
9374 queried type (that'd be a CS1540).
9376 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9377 this method which takes an additional `Type invocation_type'.
9379 * expression.cs (BaseAccess.DoResolve): Use the base type as
9380 invocation and query type.
9381 (MemberAccess.DoResolve): If the lookup failed and we're about to
9382 report a CS0122, try a lookup with the ec.ContainerType - if this
9383 succeeds, we must report a CS1540.
9385 2002-08-08 Martin Baulig <martin@gnome.org>
9387 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9388 (MethodGroupExpr): Implement the IMemberExpr interface.
9390 * expression (MemberAccess.ResolveMemberAccess): No need to have
9391 any special code for MethodGroupExprs anymore, they're now
9394 2002-08-08 Martin Baulig <martin@gnome.org>
9396 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9397 Family, FamANDAssem and FamORAssem permissions.
9398 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9400 2002-08-08 Martin Baulig <martin@gnome.org>
9402 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9403 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9406 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9408 * driver.cs: implemented /resource option to embed managed resources.
9410 2002-08-07 Martin Baulig <martin@gnome.org>
9412 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9413 (FieldBase.HasFieldInitializer): New public property.
9414 (FieldBase.GetInitializerExpression): New public method. Resolves and
9415 returns the field initializer and makes sure it is only resolved once.
9416 (TypeContainer.EmitFieldInitializers): Call
9417 FieldBase.GetInitializerExpression to get the initializer, this ensures
9418 that it isn't resolved multiple times.
9420 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9421 the resolving process (SimpleName/MemberLookup) that we're currently
9422 emitting a field initializer (which must not access any instance members,
9423 this is an error CS0236).
9425 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9426 argument, if the `IsFieldInitializer' flag is set, we must report and
9427 error CS0236 and not an error CS0120.
9429 2002-08-07 Martin Baulig <martin@gnome.org>
9431 * ecore.cs (IMemberExpr): New public interface.
9432 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9433 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9434 if the expression is an IMemberExpr.
9436 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9437 to be null, implicitly default to `this' if we're non-static in
9438 this case. Simplified the code a lot by using the new IMemberExpr
9439 interface. Also fixed bug #28176 here.
9441 2002-08-06 Martin Baulig <martin@gnome.org>
9443 * cs-parser.jay (SimpleLookup): Removed. We need to create
9444 ParameterReferences during semantic analysis so that we can do a
9445 type-only search when resolving Cast, TypeOf and SizeOf.
9446 (block): Pass the `current_local_parameters' to the Block's
9449 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9450 argument to the constructor.
9451 (ConstructorInitializer.Resolve): Create a temporary implicit
9452 block with the parameters.
9454 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9455 references here if we aren't doing a type-only search.
9457 * statement.cs (Block): Added constructor which takes a
9458 `Parameters parameters' argument.
9459 (Block.Parameters): New public property.
9461 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9462 to `Parameters' and made it public readonly.
9464 2002-08-06 Martin Baulig <martin@gnome.org>
9466 * ecore.cs (Expression.Warning): Made this public as well.
9468 * report.cs (Report.Debug): Print the contents of collections.
9470 2002-08-06 Martin Baulig <martin@gnome.org>
9472 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9473 used to tell Resolve() which kinds of expressions it may return.
9474 (Expression.Resolve): Added overloaded version of this method which
9475 takes a `ResolveFlags flags' argument. This can be used to tell
9476 Resolve() which kinds of expressions it may return. Reports a
9478 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9479 ResolveFlags.SimpleName.
9480 (Expression.Error118): Added overloaded version of this method which
9481 takes a `ResolveFlags flags' argument. It uses the flags to determine
9482 which kinds of expressions are allowed.
9484 * expression.cs (Argument.ResolveMethodGroup): New public method.
9485 Resolves an argument, but allows a MethodGroup to be returned.
9486 This is used when invoking a delegate.
9488 * TODO: Updated a bit.
9490 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9492 Fixed compilation with csc.
9494 * ecore.cs: Expression.Error made public. Is this correct? Should
9495 Warning be made public too?
9497 * expression.cs: use ea.Location instead of ea.loc.
9498 [FIXME: Filed as bug #28607: MCS must report these errors.]
9500 2002-08-06 Martin Baulig <martin@gnome.org>
9502 * ecore.cs (Expression.loc): Moved the location here instead of
9503 duplicating it in all derived classes.
9504 (Expression.Location): New public property.
9505 (Expression.Error, Expression.Warning): Made them non-static and
9506 removed the location argument.
9507 (Expression.Warning): Added overloaded version which takes an
9508 `int level' argument.
9509 (Expression.Error118): Make this non-static and removed the
9510 expression and location arguments.
9511 (TypeExpr): Added location argument to the constructor.
9513 * expression.cs (StaticCallExpr): Added location argument to
9515 (Indirection, PointerArithmetic): Likewise.
9516 (CheckedExpr, UnCheckedExpr): Likewise.
9517 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9518 (StringPtr): Likewise.
9521 2002-08-05 Martin Baulig <martin@gnome.org>
9523 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9525 * assign.cs (Assign.DoResolve): Check whether the source
9526 expression is a value or variable.
9528 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9529 while resolving the corresponding blocks.
9531 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9532 an error, don't silently return null.
9534 * statement.cs (Block.AddVariable): Do the error reporting here
9535 and distinguish between CS0128 and CS0136.
9536 (Block.DoResolve): Report all unused labels (warning CS0164).
9537 (LabeledStatement): Pass the location to the constructor.
9538 (LabeledStatement.HasBeenReferenced): New property.
9539 (LabeledStatement.Resolve): Set it to true here.
9541 * statement.cs (Return.Emit): Return success even after reporting
9542 a type mismatch error (CS0126 or CS0127), this is what csc does and
9543 it avoids confusing the users with any consecutive errors.
9545 2002-08-05 Martin Baulig <martin@gnome.org>
9547 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9549 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9551 * expression.cs (MemberAccess.DoResolve): Silently return if an
9552 error has already been reported.
9554 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9555 error has already been reported.
9557 2002-08-05 Martin Baulig <martin@gnome.org>
9559 * statement.cs (UsageVector): Only initialize the `parameters'
9560 vector if we actually have any "out" parameters.
9562 2002-08-05 Martin Baulig <martin@gnome.org>
9564 * expression.cs (Binary.ResolveOperator): When combining delegates,
9565 they must have the same type.
9567 2002-08-05 Martin Baulig <martin@gnome.org>
9569 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9570 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9571 work with the ms runtime and we also don't need it: if we're a
9572 PropertyBuilder and not in the `indexer_arguments' hash, then we
9573 are a property and not an indexer.
9575 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9576 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9577 since the latter one doesn't work with the ms runtime.
9579 2002-08-03 Martin Baulig <martin@gnome.org>
9581 Fixed bugs #27998 and #22735.
9583 * class.cs (Method.IsOperator): New public field.
9584 (Method.CheckBase): Report CS0111 if there's already a method
9585 with the same parameters in the current class. Report CS0508 when
9586 attempting to change the return type of an inherited method.
9587 (MethodData.Emit): Report CS0179 if a method doesn't have a body
9588 and it's not marked abstract or extern.
9589 (PropertyBase): New abstract base class for Property and Indexer.
9590 (PropertyBase.CheckBase): Moved here from Property and made it work
9592 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
9593 the same so we can reuse it there.
9594 (Property, Indexer): Derive from PropertyBase.
9595 (MethodSignature.inheritable_property_signature_filter): New delegate
9596 to find properties and indexers.
9598 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9599 argument and improved error reporting.
9601 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9602 EmptyReadOnlyParameters and made it a property.
9604 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9605 version of this method which takes a `PropertyInfo indexer'.
9606 (TypeManager.RegisterIndexer): New method.
9608 * class.cs: Added myself as author of this file :-)
9610 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9612 * class.cs: fixed compilation on windoze.
9614 2002-08-03 Martin Baulig <martin@gnome.org>
9616 * interface.cs (Interface.GetInterfaceBases): Check whether all
9617 base interfaces are at least as accessible than the current one.
9619 * class.cs (TypeContainer.GetClassBases): Check whether base types
9620 are at least as accessible than the current type.
9621 (TypeContainer.AsAccessible): Implemented and made non-static.
9622 (MemberBase.CheckParameters): Report errors if the accessibility
9625 * delegate.cs (Delegate.Delegate): The default visibility is
9626 internal for top-level types and private for nested types.
9627 (Delegate.Define): Report errors if the accessibility checks fail.
9629 * enum.cs (Enum.Enum): The default visibility is internal for
9630 top-level types and private for nested types.
9631 (Enum.DefineType): Compute the correct visibility.
9633 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
9634 function which takes a `bool is_toplevel' instead of a TypeContainer.
9636 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
9639 2002-08-02 Martin Baulig <martin@gnome.org>
9641 * expression.cs (LocalVariableReferenc): Added constructor which
9642 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
9643 (LocalVariableReference.IsReadOnly): New property.
9644 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
9645 variable is readonly, use our own readonly flag to do this; you can
9646 use the new constructor to get a writable reference to a read-only
9649 * cs-parser.jay (foreach_statement, using_statement): Get a writable
9650 reference to the local variable.
9652 2002-08-01 Miguel de Icaza <miguel@ximian.com>
9654 * rootcontext.cs (ResolveCore): Also include System.Exception
9656 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
9657 we reach an EmptyStatement.
9659 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
9662 * expression.cs (Binary.ResolveOperator): Check error result in
9665 use brtrue/brfalse directly and avoid compares to null.
9667 2002-08-02 Martin Baulig <martin@gnome.org>
9669 * class.cs (TypeContainer.Define): Define all nested interfaces here.
9670 Fixes bug #28407, added test-155.cs.
9672 2002-08-01 Martin Baulig <martin@gnome.org>
9674 * class.cs (Event.EmitDefaultMethod): Make this work with static
9675 events. Fixes #28311, added verify-3.cs.
9677 2002-08-01 Martin Baulig <martin@gnome.org>
9679 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
9680 `is_disposable' fields.
9681 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
9682 `hm.is_disposable' if we're using the collection pattern.
9683 (Foreach.EmitCollectionForeach): Use the correct type for the
9684 enumerator's local variable, only emit the try/finally block if
9685 necessary (fixes #27713).
9687 2002-08-01 Martin Baulig <martin@gnome.org>
9689 * ecore.cs (Expression.report118): Renamed to Error118 and made
9692 * statement.cs (Throw.Resolve): Check whether the expression is of
9693 the correct type (CS0118) and whether the type derives from
9694 System.Exception (CS0155).
9695 (Catch.Resolve): New method. Do the type lookup here and check
9696 whether it derives from System.Exception (CS0155).
9697 (Catch.CatchType, Catch.IsGeneral): New public properties.
9699 * typemanager.cs (TypeManager.exception_type): Added.
9701 2002-07-31 Miguel de Icaza <miguel@ximian.com>
9703 * driver.cs: Updated About function.
9705 2002-07-31 Martin Baulig <martin@gnome.org>
9707 Implemented Control Flow Analysis.
9709 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
9710 (EmitContext.CurrentBranching): Added.
9711 (EmitContext.StartFlowBranching): Added.
9712 (EmitContext.EndFlowBranching): Added.
9713 (EmitContext.KillFlowBranching): Added.
9714 (EmitContext.IsVariableAssigned): Added.
9715 (EmitContext.SetVariableAssigned): Added.
9716 (EmitContext.IsParameterAssigned): Added.
9717 (EmitContext.SetParameterAssigned): Added.
9718 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
9719 Added control flow analysis stuff here.
9721 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
9722 resolve the expression as lvalue.
9723 (LocalVariableReference.DoResolve): Check whether the variable has
9724 already been assigned.
9725 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
9726 the parameter as assigned here.
9727 (ParameterReference.DoResolve): Check whether the parameter has already
9729 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
9730 expression as lvalue.
9732 * statement.cs (FlowBranching): New class for the flow analysis code.
9733 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
9734 (LabeledStatement.IsDefined): New public property.
9735 (LabeledStatement.AddUsageVector): New public method to tell flow
9736 analyis that the label may be reached via a forward jump.
9737 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
9739 (VariableInfo.Number): New public field. This is used by flow analysis
9740 to number all locals of a block.
9741 (Block.CountVariables): New public property. This is the number of
9742 local variables in this block (including the locals from all parent
9744 (Block.EmitMeta): Number all the variables.
9746 * statement.cs: Added flow analysis support to all classes.
9748 2002-07-31 Martin Baulig <martin@gnome.org>
9750 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
9751 To get debugging messages, compile mcs with /define:MCS_DEBUG and
9752 then use this argument.
9754 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
9756 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
9757 use this to specify /define options.
9759 2002-07-29 Martin Baulig <martin@gnome.org>
9761 * statement.cs (Fixed): Moved all code that does variable lookups
9762 and resolvings from Emit to Resolve.
9764 * statement.cs (For): Moved all code that does variable lookups
9765 and resolvings from Emit to Resolve.
9767 * statement.cs (Using): Moved all code that does variable lookups
9768 and resolvings from Emit to Resolve.
9770 2002-07-29 Martin Baulig <martin@gnome.org>
9772 * attribute.cs (Attribute.Resolve): Explicitly catch a
9773 System.NullReferenceException when creating the
9774 CustromAttributeBuilder and report a different warning message.
9776 2002-07-29 Martin Baulig <martin@gnome.org>
9778 * support.cs (ParameterData.ParameterName): Added method to
9779 get the name of a parameter.
9781 * typemanager.cs (TypeManager.IsValueType): New public method.
9783 2002-07-29 Martin Baulig <martin@gnome.org>
9785 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
9786 is a flag which specifies that it's either ref or out.
9787 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
9788 the out parameter to `out Parameter.Modifier mod', also set the
9789 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
9791 * support.cs (InternalParameters.ParameterModifier): Distinguish
9792 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9793 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9795 * expression.cs (Argument.GetParameterModifier): Distinguish
9796 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9797 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9799 2002-07-29 Martin Baulig <martin@gnome.org>
9801 * expression.cs (ParameterReference.ParameterReference): Added
9802 `Location loc' argument to the constructor.
9804 * cs-parser.jay: Pass location to ParameterReference.
9806 2002-07-28 Miguel de Icaza <miguel@ximian.com>
9808 * statement.cs (Try): Initialize the location.
9810 * cs-parser.jay: pass location to Try.
9812 * expression.cs (Unary.Reduce): Change the prototype to return
9813 whether a constant fold could be performed or not. The result is
9814 returned in an out parameters. In the case of Indirection and
9815 AddressOf, we want to perform the full tests.
9817 2002-07-26 Miguel de Icaza <miguel@ximian.com>
9819 * statement.cs (Statement.Emit): Flag dead code.
9821 2002-07-27 Andrew Birkett <andy@nobugs.org>
9823 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
9825 2002-07-27 Martin Baulig <martin@gnome.org>
9827 * class.cs (MethodData.Define): Put back call to
9828 TypeManager.AddMethod(), accidentally commented this out.
9830 * report.cs (Debug): New public method to print debugging information,
9831 this is `[Conditional ("DEBUG")]'.
9833 2002-07-26 Martin Baulig <martin@gnome.org>
9835 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
9836 (switch_statement): Push the current_block to the switch_stack and
9837 pop it again when we're done with the switch.
9838 (switch_section): The new block is a child of the current_block.
9839 Fixes bug #24007, added test-152.cs.
9841 2002-07-27 Martin Baulig <martin@gnome.org>
9843 * expression.cs (Invocation.EmitArguments): When calling a varargs
9844 function with only its fixed arguments, we need to pass an empty
9847 2002-07-27 Martin Baulig <martin@gnome.org>
9849 Mono 0.13 has been released.
9851 2002-07-25 Miguel de Icaza <miguel@ximian.com>
9853 * driver.cs: Rename --resource to --linkres, because that is what
9854 we do currently, we dont support --resource yet.
9856 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
9858 2002-07-25 Martin Baulig <martin@gnome.org>
9860 * class.cs (MethodData): New public class. This is a `method builder'
9861 class for a method or one accessor of a Property/Indexer/Event.
9862 (MethodData.GetMethodFlags): Moved here from MemberBase.
9863 (MethodData.ApplyAttributes): Likewise.
9864 (MethodData.ApplyObsoleteAttribute): Likewise.
9865 (MethodData.ApplyConditionalAttribute): Likewise.
9866 (MethodData.ApplyDllImportAttribute): Likewise.
9867 (MethodData.CheckAbstractAndExternal): Likewise.
9868 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
9869 (MethodData.Emit): Formerly known as Method.Emit().
9870 (MemberBase): Moved everything which was specific to a single
9871 accessor/method to MethodData.
9872 (Method): Create a new MethodData and call Define() and Emit() on it.
9873 (Property, Indexer, Event): Create a new MethodData objects for each
9874 accessor and call Define() and Emit() on them.
9876 2002-07-25 Martin Baulig <martin@gnome.org>
9878 Made MethodCore derive from MemberBase to reuse the code from there.
9879 MemberBase now also checks for attributes.
9881 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
9882 (MemberBase.GetMethodFlags): Moved here from class Method and marked
9884 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
9885 `CallingConventions cc' and `Attributes opt_attrs' arguments.
9886 (MemberBase.ApplyAttributes): New virtual method; applies the
9887 attributes to a method or accessor.
9888 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
9889 (MemberBase.ApplyConditionalAttribute): Likewise.
9890 (MemberBase.ApplyDllImportAttribute): Likewise.
9891 (MemberBase.CheckAbstractAndExternal): Likewise.
9892 (MethodCore.ParameterTypes): This is now a property instead of a
9893 method, it's initialized from DoDefineParameters().
9894 (MethodCore.ParameterInfo): Removed the set accessor.
9895 (MethodCore.DoDefineParameters): New protected virtual method to
9896 initialize ParameterTypes and ParameterInfo.
9897 (Method.GetReturnType): We can now simply return the MemberType.
9898 (Method.GetMethodFlags): Override the MemberBase version and add
9899 the conditional flags.
9900 (Method.CheckBase): Moved some code from Define() here, call
9901 DoDefineParameters() here.
9902 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
9903 here to avoid some larger code duplication.
9904 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
9905 ensure that abstract and external accessors don't declare a body.
9907 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
9908 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
9909 lookup in the attribute's parent classes, so we need to abort as soon
9910 as we found the first match.
9911 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
9912 the attribute has no arguments.
9914 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
9917 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9919 * cs-parser.jay: reverted previous patch.
9921 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9923 * cs-parser.jay: fixed bug #22119.
9925 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9927 * attribute.cs: fixed compilation. The error was:
9928 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
9929 be assigned to before control leaves the current method."
9930 [FIXME: Filed as bug #28186: MCS must report this error.]
9932 2002-07-25 Martin Baulig <martin@gnome.org>
9934 * attribute.cs (Attribute.Conditional_GetConditionName): New static
9935 method to pull the condition name ouf of a Conditional attribute.
9936 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
9937 the obsolete message and error flag out of an Obsolete attribute.
9939 * class.cs (Method.GetMethodFlags): New public method to get the
9940 TypeManager.MethodFlags for this method.
9941 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
9943 (Method.Define): Get and apply the Obsolete and Conditional attributes;
9944 if we're overriding a virtual function, set the new private variable
9945 `parent_method'; call the new TypeManager.AddMethod().
9947 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
9948 the MethodBuilder and the Method in a PtrHashtable.
9949 (TypeManager.builder_to_method): Added for this purpose.
9950 (TypeManager.MethodFlags): Added IsObsoleteError.
9951 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
9952 Obsolete and Conditional arguments in MethodBuilders. If we discover
9953 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
9954 the message from the attribute.
9956 2002-07-24 Martin Baulig <martin@gnome.org>
9958 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
9959 preprocessor directives, ensure that the argument to #define/#undef is
9960 exactly one identifier and that it's actually an identifier.
9962 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
9965 2002-07-24 Martin Baulig <martin@gnome.org>
9967 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
9968 initialize it to TypeManager.object_type in the constructor.
9969 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
9970 of the `hm.get_current' method if we're using the collection pattern.
9971 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
9972 for the explicit conversion to make it work when we're using the collection
9973 pattern and the `Current' property has a different return type than `object'.
9976 2002-07-24 Martin Baulig <martin@gnome.org>
9978 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
9979 does not match, but don't report any errors. This method is called in
9980 order for all methods in a MethodGroupExpr until a matching method is
9981 found, so we don't want to bail out if the first method doesn't match.
9982 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
9983 matches, report the 123. Fixes #28070.
9985 2002-07-24 Martin Baulig <martin@gnome.org>
9987 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
9988 TypeManager.TypeToCoreType() to the top of the method so the
9989 following equality checks will work. Fixes #28107.
9991 2002-07-24 Martin Baulig <martin@gnome.org>
9993 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
9994 operand is of type uint, and the other operand is of type sbyte,
9995 short or int, the operands are converted to type long." -
9996 Actually do what this comment already told us. Fixes bug #28106,
9999 2002-07-24 Martin Baulig <martin@gnome.org>
10001 * class.cs (MethodBase): New abstract class. This is now a base
10002 class for Property, Indexer and Event to avoid some code duplication
10003 in their Define() and DefineMethods() methods.
10004 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10005 generic methods for Define() and DefineMethods().
10006 (FieldBase): Derive from MemberBase, not MemberCore.
10007 (Property): Derive from MemberBase, not MemberCore.
10008 (Property.DefineMethod): Moved all the code from this method to the
10009 new MethodBase.DefineAccessor(), just call it with appropriate
10011 (Property.Define): Call the new Property.DoDefine(), this does some
10012 sanity checks and we don't need to duplicate the code everywhere.
10013 (Event): Derive from MemberBase, not MemberCore.
10014 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10015 accessors, this will also make them work with interface events.
10016 (Indexer): Derive from MemberBase, not MemberCore.
10017 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10018 (Indexer.Define): Use the new MethodBase functions.
10020 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10021 argument to the constructor.
10022 (Interface.FindMembers): Added support for interface events.
10023 (Interface.PopluateEvent): Implemented.
10025 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10027 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10029 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10030 but this is required to check for a method name being the same as
10031 the containing class.
10035 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10037 * interface.cs: initialize variable.
10039 2002-07-23 Martin Baulig <martin@gnome.org>
10041 Implemented the IndexerName attribute in interfaces.
10043 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10044 name if this is an explicit interface implementation.
10045 (Indexer.InterfaceIndexerName): New public variable. If we're
10046 implementing an interface indexer, this is the IndexerName in that
10047 interface. Otherwise, it's the IndexerName.
10048 (Indexer.DefineMethod): If we're implementing interface indexer,
10049 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10050 and Pending.ImplementIndexer methods.
10051 (Indexer.Define): Also define the PropertyBuilder if we're
10052 implementing an interface indexer and this is neither an explicit
10053 interface implementation nor do the IndexerName match the one in
10056 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10057 If a method is defined here, then we always need to create a proxy
10058 for it. This is used when implementing interface indexers.
10059 (Pending.IsInterfaceIndexer): New public method.
10060 (Pending.ImplementIndexer): New public method.
10061 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10062 This is used when implementing interface indexers to define a proxy
10064 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10065 define a proxy if necessary.
10067 * interface.cs (Interface.IndexerName): New public variable.
10068 (Interface.PopulateIndexer): Set the IndexerName.
10069 (Interface.DefineIndexers): New private method. Populate all the
10070 indexers and make sure their IndexerNames match.
10072 * typemanager.cs (IndexerPropertyName): Added support for interface
10075 2002-07-22 Martin Baulig <martin@gnome.org>
10077 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10078 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10079 ret if HasReturnLabel.
10080 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10083 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10084 and set the ec.LoopBeginTryCatchLevel.
10085 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10086 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10087 the current ec.TryCatchLevel, the branch goes out of an exception
10088 block. In this case, we need to use Leave and not Br.
10090 2002-07-22 Martin Baulig <martin@gnome.org>
10092 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10093 block unless the block does not always return or it is contained in
10094 another try { ... } catch { ... } block. Fixes bug #26506.
10095 Added verify-1.cs to the test suite.
10097 2002-07-22 Martin Baulig <martin@gnome.org>
10099 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10100 then we do not always return. Fixes bug #24985.
10102 2002-07-22 Martin Baulig <martin@gnome.org>
10104 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10105 lookup on a per-class level; ie. walk up the class hierarchy until we
10106 found at least one applicable method, then choose the best among them.
10107 Fixes bug #24463 and test-29.cs.
10109 2002-07-22 Martin Baulig <martin@gnome.org>
10111 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10112 return types of the methods. The return type is not part of the
10113 signature and we must not check it to make the `new' modifier work.
10114 Fixes bug #27999, also added test-147.cs.
10115 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10117 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10118 on the method's return type.
10120 2002-07-21 Martin Baulig <martin@gnome.org>
10122 * assign.cs: Make this work if the rightmost source is a constant and
10123 we need to do an implicit type conversion. Also adding a few more tests
10124 to test-38.cs which should have caught this.
10126 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10127 target in the makefile for this. The makefile.gnu is primarily intended
10128 for end-users who don't want to debug the compiler.
10130 2002-07-21 Martin Baulig <martin@gnome.org>
10132 * assign.cs: Improved the Assign class so it can now handle embedded
10133 assignments (X = Y = Z = something). As a side-effect this'll now also
10134 consume less local variables. test-38.cs now passes with MCS, added
10135 a few new test cases to that test.
10137 2002-07-20 Martin Baulig <martin@gnome.org>
10139 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10140 instructions. Fixes bug #27977, also added test-146.cs.
10142 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10144 * cs-tokenizer.cs: fixed getHex ().
10146 2002-07-19 Martin Baulig <martin@gnome.org>
10148 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10149 not Type.GetType() to lookup the array type. This is needed when
10150 we're constructing an array of a user-defined type.
10151 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10152 single-dimensional arrays, but also for single-dimensial arrays of
10155 2002-07-19 Martin Baulig <martin@gnome.org>
10157 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10158 this function is called, it's not allowed to share LocalBuilders
10159 among ILGenerators.
10161 2002-07-19 Martin Baulig <martin@gnome.org>
10163 * expression.cs (Argument.Resolve): Report an error 118 when trying
10164 to pass a type as argument.
10166 2002-07-18 Martin Baulig <martin@gnome.org>
10168 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10169 Conv_R_Un for the signed `long' type.
10171 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10173 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10174 `expr' for the temporary result, as that will fail if we do
10175 multiple resolves on the same expression.
10177 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10179 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10180 ec.TypeContainer for looking up aliases.
10182 * class.cs (TypeContainer): Remove LookupAlias from here.
10184 * decl.cs (DeclSpace); Move here.
10186 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10188 * class.cs (FindMembers): Only call filter if the constructor
10189 bulider is not null.
10191 Also handle delegates in `NestedTypes' now. Now we will perform
10192 type lookups using the standard resolution process. This also
10195 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10196 This uses Expressions (the limited kind that can be parsed by the
10197 tree) instead of strings.
10199 * expression.cs (ComposedCast.ToString): Implement, used to flag
10200 errors since now we have to render expressions.
10202 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10205 * ecore.cs (SimpleName.ToString): ditto.
10207 * cs-parser.jay: Instead of using strings to assemble types, use
10208 Expressions to assemble the type (using SimpleName, ComposedCast,
10209 MemberAccess). This should fix the type lookups in declarations,
10210 because we were using a different code path for this.
10212 * statement.cs (Block.Resolve): Continue processing statements
10213 even when there is an error.
10215 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10217 * class.cs (Event.Define): Also remove the `remove' method from
10218 the list of pending items.
10220 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10221 generate more compact code.
10223 2002-07-17 Martin Baulig <martin@gnome.org>
10225 * const.cs (Const.LookupConstantValue): Add support for constant
10226 `unchecked' and `checked' expressions.
10227 Also adding test case test-140.cs for this.
10229 2002-07-17 Martin Baulig <martin@gnome.org>
10231 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10232 check whether mi.ReturnType implements the IEnumerator interface; the
10233 `==' and the IsAssignableFrom() will fail in this situation.
10235 2002-07-16 Ravi Pratap <ravi@ximian.com>
10237 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10240 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10242 * expression.cs: fixed bug #27811.
10244 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10246 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10247 Molaro: when we are a ref, the value already contains a pointer
10248 value, do not take the address of it.
10250 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10251 * removed mb-parser.jay and mb-tokenizer.cs
10253 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10255 * expression.cs: check against the building corlib void type.
10257 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10259 * ecore.cs: fix for valuetype static readonly fields: when
10260 initializing them, we need their address, not the address of a copy.
10262 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10264 * typemanager.cs: register also enum_type in corlib.
10266 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10268 * class.cs: allow calling this (but not base) initializers in structs.
10270 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10272 * ecore.cs: make sure we compare against the building base types
10275 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10277 * typemanager.cs: fix TypeToCoreType() to handle void and object
10278 (corlib gets no more typerefs after this change).
10280 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10282 * expression.cs (ArrayCreation.EmitArrayArguments): use
10283 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10285 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10286 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10287 array indexes, the runtime actually forbids them.
10289 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10290 for array arguments here.
10292 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10293 instead of the default for ValueTypes.
10295 (New.DoEmit): Use IsValueType instead of
10296 IsSubclassOf (value_type)
10297 (New.DoResolve): ditto.
10298 (Invocation.EmitCall): ditto.
10300 * assign.cs (Assign): ditto.
10302 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10303 Statements *are* currently doing part of their resolution during
10306 Expressions do always resolve during resolve, but statements are
10307 only required to propagate resolution to their children.
10309 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10311 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10313 (LoadAssembly): Do not add the dll if it is already specified
10315 (MainDriver): Add the System directory to the link path at the end,
10316 after all the other -L arguments.
10318 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10319 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10320 ldelem.u1) and using the opposite for sbytes.
10322 This fixes Digger, and we can finally run it.
10324 * driver.cs (UnixParseOption): Move the option parsing here.
10325 (CSCParseOption): Implement CSC-like parsing of options.
10327 We now support both modes of operation, the old Unix way, and the
10328 new CSC-like way. This should help those who wanted to make cross
10329 platform makefiles.
10331 The only thing broken is that /r:, /reference: and /lib: are not
10332 implemented, because I want to make those have the same semantics
10333 as the CSC compiler has, and kill once and for all the confussion
10334 around this. Will be doing this tomorrow.
10336 * statement.cs (Unsafe.Resolve): The state is checked during
10337 resolve, not emit, so we have to set the flags for IsUnsfe here.
10339 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10341 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10342 not catch the Error_ObjectRefRequired in SimpleName (as it is
10343 possible to have a class/instance variable name that later gets
10344 deambiguated), we have to check this here.
10346 2002-07-10 Ravi Pratap <ravi@ximian.com>
10348 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10349 make static and put into Expression.
10351 (Event.Define): Register the private field of the event with the
10352 TypeManager so that GetFieldFromEvent can get at it.
10354 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10355 keep track of the private field associated with an event which
10358 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10361 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10363 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10365 * expression.cs (Binary.EmitBranchable): this routine emits the
10366 Binary expression in a branchable context. This basically means:
10367 we need to branch somewhere, not just get the value on the stack.
10369 This works together with Statement.EmitBoolExpression.
10371 * statement.cs (Statement.EmitBoolExpression): Use
10374 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10376 * statement.cs (For): Reduce the number of jumps in loops.
10378 (For): Implement loop inversion for the For statement.
10380 (Break): We can be breaking out of a Try/Catch controlled section
10381 (foreach might have an implicit try/catch clause), so we need to
10382 use Leave instead of Br.
10384 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10385 now). If the instace expression supports IMemoryLocation, we use
10386 the AddressOf method from the IMemoryLocation to extract the
10387 address instead of emitting the instance.
10389 This showed up with `This', as we were emitting the instance
10390 always (Emit) instead of the Address of This. Particularly
10391 interesting when This is a value type, as we dont want the Emit
10392 effect (which was to load the object).
10394 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10396 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10398 * statement.cs (Checked): Set the CheckedState during the resolve
10399 process too, as the ConvCast operations track the checked state on
10400 the resolve process, and not emit.
10402 * cs-parser.jay (namespace_member_declaration): Flag that we have
10403 found a declaration when we do. This is used to flag error 1529
10405 * driver.cs: Report ok when we display the help only.
10407 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10409 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10411 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10413 * cs-tokenizer.cs (define): We also have to track locally the
10414 defines. AllDefines is just used for the Conditional Attribute,
10415 but we also need the local defines for the current source code.
10417 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10419 * statement.cs (While, For, Do): These loops can exit through a
10420 Break statement, use this information to tell whether the
10421 statement is the last piece of code.
10423 (Break): Flag that we break.
10425 * codegen.cs (EmitContexts): New `Breaks' state variable.
10427 2002-07-03 Martin Baulig <martin@gnome.org>
10429 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10430 modifiers in method declarations in structs. Otherwise, you won't
10431 be able to override things like Object.Equals().
10433 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10435 * class.cs (Method, Property, Indexer): Do not allow the public
10436 modifier to be used in explicit interface implementations.
10438 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10439 override modifiers in method declarations in structs
10441 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10443 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10444 integer or real overflow, report an error
10446 2002-07-02 Martin Baulig <martin@gnome.org>
10448 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10449 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10450 to tell the runtime about our newly created System.Object and
10451 System.ValueType types.
10453 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10455 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10456 struct instead of Ldarg/Starg.
10458 2002-07-02 Martin Baulig <martin@gnome.org>
10460 * expression.cs (Indirection.Indirection): Call
10461 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10463 2002-07-02 Martin Baulig <martin@gnome.org>
10465 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10466 ValueType, call TypeManager.TypeToCoreType() on it.
10467 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10468 the OpCodes.Newarr argument.
10470 2002-07-02 Martin Baulig <martin@gnome.org>
10472 * expression.cs (Invocation.EmitCall): When compiling corlib,
10473 replace all calls to the system's System.Array type to calls to
10474 the newly created one.
10476 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10477 System.Array methods.
10478 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10479 from the system's System.Array type which must be replaced.
10481 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10483 * typemanager.cs: load unverifiable_code_ctor so we can build
10484 corlib using the correct type. Avoid using GetTypeCode() with
10486 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10487 TypeManager.object_type to allow building corlib.
10489 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10491 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10493 2002-07-01 Martin Baulig <martin@gnome.org>
10495 * class.cs: Make the last change actually work, we need to check
10496 whether `ifaces != null' to avoid a crash.
10498 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10500 * class.cs: when we build structs without fields that implement
10501 interfaces, we need to add the interfaces separately, since there is
10502 no API to both set the size and add the interfaces at type creation
10505 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10507 * expression.cs: the dimension arguments to the array constructors
10508 need to be converted if they are a long.
10510 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10512 * class.cs: don't emit ldarg.0 if there is no parent constructor
10513 (fixes showstopper for corlib).
10515 2002-06-29 Martin Baulig <martin@gnome.org>
10517 MCS now compiles corlib on GNU/Linux :-)
10519 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10520 ie. check for MethodImplOptions.InternalCall.
10522 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10523 and TypeManager.attribute_type are null, so we must explicitly check
10524 whether parent is not null to find out whether it's an attribute type.
10525 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10526 and SetBuilder, not only if the property is neither abstract nor external.
10527 This is necessary to set the MethodImplOptions on the accessor methods.
10528 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10529 SetBuilder, see Property.Emit().
10531 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10532 populate "System.Object", "System.ValueType" and "System.Attribute" since
10533 they've already been populated from BootCorlib_PopulateCoreTypes().
10535 2002-06-29 Martin Baulig <martin@gnome.org>
10537 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10538 is the NullLiteral, we also need to make sure that target_type is not
10541 2002-06-29 Martin Baulig <martin@gnome.org>
10543 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10544 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10545 before calling BootstrapCorlib_ResolveDelegate ().
10547 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10549 * statement.cs: fixed build-breaker. All tests passed ok.
10551 2002-06-27 Martin Baulig <martin@gnome.org>
10553 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10554 for System.Decimal when compiling corlib.
10556 2002-06-27 Martin Baulig <martin@gnome.org>
10558 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10559 switch blocks which contain nothing but a default clause.
10561 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10563 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10565 2002-06-27 Martin Baulig <martin@gnome.org>
10567 * ecore.cs (PropertyExpr.PropertyExpr): Call
10568 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10570 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10571 is already a TypeBuilder.
10573 2002-06-27 Martin Baulig <martin@gnome.org>
10575 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10576 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10577 the "from an array-type to System.Array" case. This makes it work
10578 when compiling corlib.
10580 2002-06-27 Martin Baulig <martin@gnome.org>
10582 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
10583 non-static PropertyExpr, set its InstanceExpression. This makes
10584 the `ICollection.Count' property work in System/Array.cs.
10586 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
10588 * driver.cs: Made error handling more consistent. Errors now
10589 tracked by Report class, so many methods which used to return int
10590 now return void. Main() now prints success/failure and
10591 errors/warnings message.
10593 Renamed '--probe' compiler argument to '--expect-error'. Removed
10594 the magic number return values (123 and 124). Now, if the
10595 expected error occurs, the compiler exits with success (exit value
10596 0). If the compilation completes without seeing that particular
10597 error, the compiler exits with failure (exit value 1). The
10598 makefile in mcs/errors has been changed to handle the new behaviour.
10600 * report.cs: Made 'expected error' number a property and renamed
10601 it from 'Probe' to 'ExpectedError'.
10603 * genericparser.cs: Removed error handling support, since it is
10604 now all done by Report class.
10606 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10607 class, so parse() no longer returns an int.
10609 * namespace.cs: Use Report.Error instead of GenericParser.error
10611 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10613 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10614 TypeContainer.AddOperator): At the front of the list put the
10615 explicit implementations, so they get resolved/defined first.
10617 2002-06-21 Miguel de Icaza <miguel@ximian.com>
10619 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
10620 interface type is implemented by this TypeContainer. Used during
10621 explicit interface implementation.
10623 (Property.Define, Indexer.Define, Method.Define): Validate that
10624 the given interface in the explicit implementation is one of the
10625 base classes for the containing type.
10627 Also if we are explicitly implementing an interface, but there is
10628 no match in the pending implementation table, report an error.
10630 (Property.Define): Only define the property if we are
10631 not explicitly implementing a property from an interface. Use the
10632 correct name also for those properties (the same CSC uses,
10633 although that is really not needed).
10635 (Property.Emit): Do not emit attributes for explicitly implemented
10636 properties, as there is no TypeBuilder.
10638 (Indexer.Emit): ditto.
10640 Hiding then means that we do not really *implement* a pending
10641 implementation, which makes code fail.
10643 2002-06-22 Martin Baulig <martin@gnome.org>
10645 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
10646 the return value of Object.GetType(). [FIXME: we need to do this whenever
10647 we get a type back from the reflection library].
10649 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
10651 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
10653 2002-06-20 Miguel de Icaza <miguel@ximian.com>
10655 * attribute.cs: Return null if we can not look up the type.
10657 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
10658 the interface types found.
10660 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
10661 interface types found.
10663 * typemanager.cs (GetInterfaces): Make this routine returns alll
10664 the interfaces and work around the lame differences between
10665 System.Type and System.Reflection.Emit.TypeBuilder in the results
10666 result for GetInterfaces.
10668 (ExpandInterfaces): Given an array of interface types, expand and
10669 eliminate repeated ocurrences of an interface. This expands in
10670 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
10673 2002-06-21 Martin Baulig <martin@gnome.org>
10675 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
10678 2002-06-21 Martin Baulig <martin@gnome.org>
10680 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
10681 and called with one of the core types, return the corresponding typebuilder for
10684 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
10687 2002-06-21 Martin Baulig <martin@gnome.org>
10689 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
10690 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
10691 (Expression.ConvertReferenceExplicit): Likewise.
10693 * expression.cs (ElementAccess.DoResolve): Likewise.
10694 (ElementAccess.DoResolveLValue): Likewise.
10696 2002-06-10 Martin Baulig <martin@gnome.org>
10698 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
10699 add the "value" parameter to the parameter list.
10701 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
10704 2002-06-19 Miguel de Icaza <miguel@ximian.com>
10706 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
10707 the argument to an int, uint, long or ulong, per the spec. Also
10708 catch negative constants in array creation.
10710 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
10712 * class.cs: do not allow the same interface to appear twice in
10713 the definition list.
10715 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
10717 * ecore.cs: don't use ldlen with System.Array.
10719 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
10721 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
10723 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
10725 * modifiers.cs: produce correct field attributes for protected
10726 internal. Easy fix so miguel can work on ther harder stuff:-)
10728 2002-06-18 Miguel de Icaza <miguel@ximian.com>
10730 * pending.cs: New file. Move the code from class.cs here.
10731 Support clearning the pending flag for all methods (when not doing
10732 explicit interface implementation).
10734 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
10736 * rootcontext.cs: added a couple more types needed to bootstrap.
10738 2002-06-17 Miguel de Icaza <miguel@ximian.com>
10740 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
10741 constructor in the type, instead of any constructor in the type
10742 hierarchy. Thanks to Paolo for finding this bug (it showed up as
10743 a bug in the Mono runtime when applying the params attribute).
10745 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10746 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
10748 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
10750 * expression.cs (Unary.ResolveOperator): Use TypeManager
10751 to resolve the type.
10753 2002-06-13 Ravi Pratap <ravi@ximian.com>
10755 * cs-parser.jay (enum_member_declaration): Pass in the attributes
10758 * enum.cs (AddEnumMember): Add support to store the attributes associated
10759 with each member too.
10761 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
10762 field builders too - this takes care of the enum member case.
10764 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
10766 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
10767 address-of operator on both value types and pointers.
10769 2002-06-10 Martin Baulig <martin@gnome.org>
10771 * interface.cs (Interface.PopulateIndexer): Add the indexer's
10772 PropertyBuilder to the `property_builders' list.
10774 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
10775 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
10776 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
10777 find any indexers which are inherited from an interface.
10779 2002-06-09 Martin Baulig <martin@gnome.org>
10781 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
10782 the same type as the constant if necessary. There's also a test-130.cs
10785 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
10787 * typemanager.cs (TypeManager.ChangeType): Previously known as
10788 Enum.ChangeEnumType().
10790 2002-06-09 Martin Baulig <martin@gnome.org>
10792 * expression.cs (Cast.TryReduce): Added support for consts.
10794 2002-06-08 Ravi Pratap <ravi@ximian.com>
10796 * class.cs (Accessor): Hold attributes information so we can pass
10799 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
10800 Modify to pass in attributes attached to the methods.
10802 (add_accessor_declaration, remove_accessor_declaration): Ditto.
10804 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
10805 to handle the Accessor kind :-)
10807 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
10809 2002-06-08 Martin Baulig <martin@gnome.org>
10811 * expression.cs (Unary.TryReduceNegative): Added support for
10814 2002-06-08 Martin Baulig <martin@gnome.org>
10816 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
10817 name can't be found in the `defined_names' - the caller will do a
10818 MemberLookup in this case and thus find methods in System.Enum
10819 such as Enum.IsDefined().
10821 2002-06-08 Martin Baulig <martin@gnome.org>
10823 * enum.cs (Enum.ChangeEnumType): This is a custom version of
10824 Convert.ChangeType() which works with TypeBuilder created types.
10825 (Enum.LookupEnumValue, Enum.Define): Use it here.
10827 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
10828 `TypeBuilder.BaseType != null' check.
10829 (TypeContainer.FindMembers): Only lookup parent members if we
10830 actually have a parent.
10831 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
10832 (ConstructorInitializer.Resolve): Likewise.
10834 * interface.cs (Interface.FindMembers): Added
10835 `TypeBuilder.BaseType != null' check.
10837 * rootcontext.cs (RootContext.ResolveCore): Added
10838 "System.Runtime.CompilerServices.IndexerNameAttribute" to
10839 classes_second_stage.
10841 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
10842 debug_type and trace_type when compiling with --nostdlib.
10844 2002-06-07 Martin Baulig <martin@gnome.org>
10846 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
10847 (AddField): Set it to true when adding a non-static field.
10848 (DefineType): Use `have_nonstatic_fields' to find out whether we
10849 have non-static fields, not `Fields != null'.
10851 2002-06-02 Miguel de Icaza <miguel@ximian.com>
10853 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
10854 dereferencing a null on the static-field code path)
10856 2002-05-30 Martin Baulig <martin@gnome.org>
10858 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
10859 to take command line arguments. Use reflection to call the new
10860 custom `Initialize' function on the symbol writer and pass it the
10861 command line arguments.
10863 * driver.cs (--debug-args): New command line argument to pass command
10864 line arguments to the symbol writer.
10866 2002-05-28 Miguel de Icaza <miguel@ximian.com>
10868 * assign.cs (DoResolve): Forgot to do the implicit conversion to
10869 the target type for indexers and properties. Thanks to Joe for
10872 2002-05-27 Miguel de Icaza <miguel@ximian.com>
10874 * typemanager.cs (MethodFlags): returns the method flags
10875 (Obsolete/ShouldIgnore) that control warning emission and whether
10876 the invocation should be made, or ignored.
10878 * expression.cs (Invocation.Emit): Remove previous hack, we should
10879 not do this on matching a base type, we should do this based on an attribute
10881 Only emit calls to System.Diagnostics.Debug and
10882 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
10883 on the command line.
10885 * rootcontext.cs: Global settings for tracing and debugging.
10887 * cs-tokenizer.cs (define): New utility function to track
10888 defines. Set the global settings for TRACE and DEBUG if found.
10890 2002-05-25 Ravi Pratap <ravi@ximian.com>
10892 * interface.cs (Populate*): Pass in the TypeContainer as well as
10893 the DeclSpace as parameters so that we can create EmitContexts and
10894 then use that to apply attributes etc.
10896 (PopulateMethod, PopulateEvent, PopulateProperty)
10897 (PopulateIndexer): Apply attributes everywhere.
10899 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
10902 (ApplyAttributes): Update accordingly.
10904 We now apply interface attributes for all members too.
10906 2002-05-26 Miguel de Icaza <miguel@ximian.com>
10908 * class.cs (Indexer.Define); Correctly check if we are explicit
10909 implementation (instead of checking the Name for a ".", we
10910 directly look up if the InterfaceType was specified).
10912 Delay the creation of the PropertyBuilder.
10914 Only create the PropertyBuilder if we are not an explicit
10915 interface implementation. This means that explicit interface
10916 implementation members do not participate in regular function
10917 lookups, and hence fixes another major ambiguity problem in
10918 overload resolution (that was the visible effect).
10920 (DefineMethod): Return whether we are doing an interface
10923 * typemanager.cs: Temporary hack until we get attributes in
10924 interfaces (Ravi is working on that) and we get IndexerName
10925 support in interfaces.
10927 * interface.cs: Register the indexers as properties.
10929 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
10930 warning, I have verified that this is a bug in the .NET runtime
10931 (JavaScript suffers of the same problem).
10933 * typemanager.cs (MemberLookup): When looking up members for
10934 interfaces, the parent of an interface is the implicit
10935 System.Object (so we succeed in searches of Object methods in an
10936 interface method invocation. Example: IEnumerable x; x.ToString
10939 2002-05-25 Miguel de Icaza <miguel@ximian.com>
10941 * class.cs (Event): Events should also register if they do
10942 implement the methods that an interface requires.
10944 * typemanager.cs (MemberLookup); use the new GetInterfaces
10947 (GetInterfaces): The code used to lookup interfaces for a type is
10948 used in more than one place, factor it here.
10950 * driver.cs: Track the errors at the bottom of the file, we kept
10953 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
10954 instance if the method we are calling is static!
10956 2002-05-24 Miguel de Icaza <miguel@ximian.com>
10958 * attribute.cs (ApplyAttributes): Make this function filter out
10959 the IndexerName attribute (as that attribute in reality is never
10960 applied) and return the string constant for the IndexerName
10963 * class.cs (TypeContainer.Emit): Validate that all the indexers
10964 have the same IndexerName attribute, and if so, set the
10965 DefaultName attribute on the class.
10967 * typemanager.cs: The return value might contain other stuff (not
10968 only methods). For instance, consider a method with an "Item"
10969 property and an Item method.
10971 * class.cs: If there is a problem with the parameter types,
10974 2002-05-24 Ravi Pratap <ravi@ximian.com>
10976 * ecore.cs (ImplicitConversionExists): Wrapper function which also
10977 looks at user defined conversion after making a call to
10978 StandardConversionExists - we need this for overload resolution.
10980 * expression.cs : Update accordingly the various method calls.
10982 This fixes 2 bugs filed against implicit user defined conversions
10984 2002-05-22 Miguel de Icaza <miguel@ximian.com>
10986 * statement.cs: Track the result of the assignment.
10988 2002-05-21 Miguel de Icaza <miguel@ximian.com>
10990 * expression.cs (MemberAccess): Improved error reporting for
10991 inaccessible members.
10993 2002-05-22 Martin Baulig <martin@gnome.org>
10995 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
10996 itself with debugging support.
10998 2002-05-22 Martin Baulig <martin@gnome.org>
11000 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11001 Removed, this isn't needed anymore.
11003 2002-05-20 Martin Baulig <martin@gnome.org>
11005 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11006 be underlying type for an enum.
11008 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11010 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11011 that splits out the loading of just the core types.
11013 * rootcontext.cs (ResolveCore): Split the struct resolution in
11014 two, so we can load the enumeration underlying types before any
11017 * expression.cs (Is): Bandaid until we fix properly Switch (see
11018 bug #24985 for details).
11020 * typemanager.cs (ImplementsInterface): The hashtable will contain
11021 a null if there are no interfaces implemented.
11023 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11025 * cs-parser.jay (indexer_declarator): It is fine to have array
11028 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11030 * typemanager.cs: (RegisterBuilder): New function used to register
11031 TypeBuilders that implement interfaces. Since
11032 TypeBuilder.GetInterfaces (as usual) does not work with lame
11034 (AddUserType): register interfaces.
11036 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11037 dealing with TypeBuilder. Also, arrays are showing up as
11038 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11039 methods can not be invoked on them!
11041 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11042 (ImplicitReferenceConversionExists): Split out from
11043 StandardConversionExists.
11045 * expression.cs (As): We were only implementing one of the three
11046 cases for the as operator. We now implement them all.
11047 (Is): Implement the various other cases for Is as well.
11049 * typemanager.cs (CACHE): New define used to control if we want or
11050 not the FindMembers cache. Seems to have a negative impact on
11051 performance currently
11053 (MemberLookup): Nested types have full acess to
11054 enclosing type members
11056 Remove code that coped with instance/static returns for events, we
11057 now catch this in RealFindMembers.
11059 (RealFindMembers): only perform static lookup if the instance
11060 lookup did not return a type or an event.
11062 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11064 * assign.cs (CompoundAssign): We pass more semantic information
11065 now to Compound Assignments than we did before: now we have all
11066 the information at hand, and now we resolve the target *before* we
11067 do the expression expansion, which allows the "CacheValue" method
11068 to have the effect we intended (before, a [x] += 1 would generate
11069 two differen ArrayAccess expressions from the ElementAccess,
11070 during the resolution process).
11072 (CompoundAssign.DoResolve): Resolve target and original_source here.
11074 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11076 * expression.cs (ArrayAccess): dropped debugging information.
11078 * typemanager.cs: Small bug fix: I was always returning i_members,
11079 instead of one of i_members or s_members (depending on which had
11082 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11083 method is invoked before any code generation takes place, and it
11084 is a mechanism to inform that the expression will be invoked more
11085 than once, and that the method should use temporary values to
11086 avoid having side effects
11088 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11090 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11093 * expression.cs (Indirection, ArrayAccess): Add support for
11094 CacheTemporaries in these two bad boys.
11096 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11097 ldobj or ldind_ref.
11098 (StoreFromPtr): Handle stobj as well.
11100 * expression.cs (UnaryMutator): Share more code.
11102 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11103 down: I was not tracking the Filter function as well, which
11104 was affecting the results of the cache.
11106 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11108 * attribute.cs: Remove the hack to handle the CharSet property on
11111 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11113 * attribute.cs (DoResolve): More uglyness, we now only try to
11114 resolve the attribute partially, to extract the CharSet
11115 information (only if we are a StructLayout attribute). Otherwise
11117 (GetExtraTypeInfo): Add some code to conditionally kill in the
11118 future this. I am more and more convinced that the .NET
11119 framework has special code to handle the attribute setting on
11122 * expression.cs (IsParamsMethodApplicable): Revert my previous
11123 foreach change here, it was wrong.
11125 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11127 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11128 (pp_expr): do not abort on unknown input, just return.
11129 (eval): abort if there are pending chars.
11131 * attribute.cs (Attribute.Resolve): Positional parameters are
11132 optional. Deal with that case.
11134 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11135 the Ansi/Unicode/Auto information for the type.
11137 (TypeContainer.DefineType): instantiate the EmitContext here, as
11138 we will be using it during the type definition (to resolve
11139 attributes) and during the emit phase.
11141 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11142 to pull type information out of the attributes
11144 (Attribute.Resolve): track the constructor builder, and allow for
11145 multiple invocations (structs and classes will use this).
11147 * ecore.cs (MemberLookupFinal): new version with all the
11148 parameters customizable.
11150 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11151 constructors. Return if the result value is null (as the error
11152 would have been flagged already by MemberLookupFinal)
11154 Do not allow instances of abstract classes or interfaces to be
11157 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11158 We have to compare the assembly property here when dealing with
11159 FamANDAssem and Assembly access modifiers, because we might be
11160 creating an assembly from *modules* (that means that we are not
11161 getting TypeBuilders for types defined in other modules that are
11162 part of this assembly).
11164 (Method.Emit): If the method is marked abstract and has a body,
11167 (TypeContainer.DefineMembers): If both the defined member and the
11168 parent name match are methods, then do not emit any warnings: let
11169 the Method.Define routine take care of flagging warnings. But if
11170 there is a mismatch (method overrides something else, or method is
11171 overriwritten by something, then emit warning).
11173 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11174 set to null, this means `do not check for the return type on the
11177 (Method.Define): set the return type for the method signature to
11178 null, so that we get methods with the same name and parameters and
11179 different return types. This is used to flag warning 114 (you are
11180 hiding a method, and you probably want to use the new/override
11183 * typemanager.cs (MemberLookup): Implemented proper access
11184 control, closing a long standing set of bug reports. The problem
11185 was that the Framework only has two bits: Public and NonPublic,
11186 and NonPublic includes private and protected methods, but we need
11187 to enforce the FamANDAssem, FamOrAssem and Family.
11189 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11191 * statement.cs (GotoCase): Return true: Ammounts to giving up
11192 knowledge on whether we return or not, and letting the other case
11193 be responsible for it.
11195 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11197 * driver.cs: Do not load directories for each file processed, only
11198 do it if there is a pattern.
11200 * ecore.cs: Report readonly assigns here as well, as we might have
11201 been resolved only by MemberAccess.
11203 (SimpleName.SimpleNameResolve): Also be useful for LValue
11204 resolution. We need this to propagate assign to local readonly variables
11206 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11207 do not want to reuse potential criteria memory.
11209 * class.cs (MyEventBuilder): Set reflected_type;
11211 * ecore.cs (Constantify): Added support for constifying bools.
11213 (RootContext.LookupType): Added a cache for values looked up in
11214 the declaration space.
11216 * typemanager.cs (FindMembers): Now is a front-end to
11217 RealFindMembers, and provides a two-level hashtable-based cache to
11220 15% performance improvement: from 22.5 to 19.2 seconds.
11222 * expression.cs (IsParamsMethodApplicable): use foreach.
11223 (Invocation.DoResolve): ditto.
11224 (New.DoResolve): ditto.
11225 (ArrayCreation.DoResolve): ditto.
11227 * ecore.cs (FindMostEncompassingType): use foreach.
11229 * delegate.cs (NewDelegate.DoResolve): Use foreach
11231 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11232 (RemoveMethods): use foreach.
11234 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11235 nested foreach statements instead of for, and also break out of
11236 the inner loop once a match is found.
11238 (Invocation.OverloadResolve): Use foreach, simplify the code.
11240 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11242 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11243 we actually unwrap the expression to allow for extra information
11246 * expression.cs: Use Shr_Un on unsigned operations.
11248 2002-05-08 Ravi Pratap <ravi@ximian.com>
11250 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11251 applicable operators was not being considered correctly. This closes
11252 the bug Miguel reported.
11254 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11256 * attribute.cs: check that the type derives from System.Attribute
11257 and report the correct error in that case (moved the duplicate code to
11258 its own method, too).
11260 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11262 * attribute.cs: lookup attribute type name as the spec says: first the
11263 bare attribute name and then name + "Attribute" (nant compiles with
11264 mcs after this fix).
11266 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11268 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11269 Because of the way we parse things, we should try to see if a
11270 UIntConstant can fit in an integer.
11272 2002-05-07 Ravi Pratap <ravi@ximian.com>
11274 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11275 when we are in an explicit context.
11277 (ConvertReferenceExplicit): When converting from Iface type S to Class
11278 T make sure the rules are implemented as an OR.
11280 * parameter.cs (ParameterType): Make it a property for now although the
11281 purpose really isn't anything immediate.
11283 * expression.cs (Is*Applicable): Do better checking on the parameter type
11284 of a ref/out parameter. The ones from the system assemblies are already
11285 marked with the correct type so we don't need to do any correction.
11287 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11288 the object type is standard too so include that.
11290 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11292 * ecore.cs (StandardConversionExists): Augment with missing code:
11293 deal with IntConstant, LongConstants and Enumerations.
11295 * assign.cs: Report the error, instead of failing silently
11297 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11298 typecontainer that they are declared, because the
11299 typecontainer/namespace will have the list of using clauses that
11300 need to be applied.
11302 Assembly Attributes were escaping the normal registration
11305 (EmitCode): Apply attributes within an EmitContext that represents
11306 the container they were declared on.
11308 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11310 2002-05-06 Ravi Pratap <ravi@ximian.com>
11312 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11313 Revamp completely - make much cleaner as we now operate only
11316 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11317 to implement the logic detailed in the spec more correctly.
11319 (UserDefinedConversion): Update accordingly.
11321 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11323 * statement.cs: Return flow analysis information up.
11325 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11328 (token): Do not consume an extra character before calling
11331 2002-05-06 Piers Haken <piersh@friskit.com>
11333 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11335 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11337 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11338 EmitContext during the instance constructor initializer
11339 resolution, to stop access to instance variables.
11341 This is mandated by the spec, last paragraph of the `constructor
11342 initializers' section.
11344 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11346 * cs-parser.jay, class.cs (Accessor): new class used to represent
11347 an accessor (get or set). In the past we used `null' to represent
11348 a missing accessor. But this is ambiguous because there was no
11349 way to tell in abstract indexers/properties if one of them was
11352 Now there is a way of addressing that.
11354 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11355 instead of FindMembers.
11357 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11358 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11360 * attribute.cs: Treat indexers and properties as the same in terms
11361 of applying attributes
11363 * ecore.cs (FindMostEncompassedType): Use statically initialized
11364 EmptyExpressions()s like we do elsewhere to avoid creating useless
11365 objects (and we take this out of the tight loop).
11367 (GetConversionOperators): Move the code to extract the actual
11368 operators to a separate routine to clean things up.
11370 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11372 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11373 events are always registered FieldBuilders.
11375 * class.cs (FieldBase): New class shared by Fields
11377 * delegate.cs: If we are a toplevel delegate, use our full name.
11378 If we are a nested delegate, then only use our tail name.
11380 2002-05-02 Ravi Pratap <ravi@ximian.com>
11382 * expression.cs (IsApplicable): Ensure that we add the "&" to
11383 ref/out types before comparing it with the type of the argument.
11385 (IsParamsMethodApplicable): Ditto.
11387 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11390 * delegate.cs : Handle the case when we have more than one applicable
11391 method. Flag an error only when we finish checking all.
11393 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11395 * expression.cs: Add support for boolean static initializers.
11397 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11399 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11401 * parameter.cs (ComputeParameterTypes,
11402 ComputeAndDefineParameterTypes): Better error handling: now we
11403 clear the `types' cache if we fail during any of the type lookups.
11404 We also return the status code correctly to our caller
11406 * delegate.cs: If we fail to define a delegate, abort the extra
11409 * expression.cs (Binary.ResolveOperator): for
11410 operator==(object,object) and operator !=(object, object) we also
11411 have to verify that there is an implicit conversion from one to
11414 (ArrayAccess.DoResolve): Array Access can operate on
11417 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11419 * assign.cs (CompoundAssign): A new class used as a "flag" that
11420 the assignment actually is happening as part of a compound
11421 assignment operator.
11423 During compound assignment, a few new rules exist to enable things
11430 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11431 to the type of x) if y is implicitly convertible to the type of x,
11432 and the operator is a builtin operator and the return type of the
11433 operator is explicitly convertible to the type of x.
11435 * rootcontext.cs: Reset warning level to 2. 4 catches various
11436 "interesting" features in mcs, we must clean this up at some
11437 point, but currently am trying to kill other bugs ;-)
11439 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11440 in container classes as well.
11442 * expression.cs (Binary.ResolveOperator): Handle string case
11443 before anything else (as operator overloading does emit an error
11444 before doing anything else).
11446 This code could go away when we move to a table driven model, but
11447 i could not come up with a good plan last night.
11449 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11451 * typemanager.cs (CSharpName): reimplementation using regex.
11452 * class.cs: added null check for fields in Emit
11453 * rootcontext.cs: set warninglevel to 4
11455 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11457 * typemanager.cs (CSharpName): reimplemented with Lupus
11460 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11462 * statement.cs (If): correclty implement Resolve, because we were
11463 not catching sem errors in there. The same process is needed
11465 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11468 (Statement.Warning_DeadCodeFound): Factorize code.
11469 (While): Report dead code here too.
11471 (Statement): Added Resolve virtual method to allow
11472 for resolution split from the emit code.
11474 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11476 * statement.cs (EmitBoolExpression): No longer try to resolve the
11478 (MakeBoolean): New utility function that resolve, implicitly
11479 converts to boolean and tags the expression.
11482 (If, Do): Implement dead code elimination.
11483 (While): Implement loop inversion
11485 (Do, While, For, If): Resolve the expression prior to calling our
11488 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11491 - added method Report28 (warning: program has more than one entry point)
11492 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11493 - modified method Method.Define, the part at the end of the method
11495 * rootcontext.cs: added static public Location EntryPointLocation;
11497 * ../errors/cs0028.cs : Add test case for the above warning.
11500 - modified method CSharpName to allow arrays of primitive type to
11501 be printed nicely (e.g. instead of System.Int32[][] it now prints
11503 - added method CSharpSignature: returns the signature of a method
11504 in string format to be used in reporting errors, warnings, etc.
11506 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11509 2002-04-26 Ravi Pratap <ravi@ximian.com>
11511 * delegate.cs (Define): Fix extremely silly bug where I was
11512 setting the type of the 'object' parameter of the BeginInvoke
11513 method to System.IAsyncResult instead of System.Object ;-)
11515 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11517 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11520 (Constructor.Emit): return if we fail to initialize the
11521 constructor. Another door closed!
11523 * expression.cs (New.DoResolve): Improve error message (from -6 to
11524 1501). Use DeclaredOnly lookup to find the exact constructor.
11526 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11527 loop. This is useful.
11529 * cs-parser.jay: Adjust the default parameters so that destructors
11530 have the proper signature.
11532 2002-04-26 Martin Baulig <martin@gnome.org>
11534 * driver.cs (LoadAssembly): If `assembly' contains any characters
11535 which are only valid in path names and not in assembly names
11536 (currently slash, backslash and point), use Assembly.LoadFrom ()
11537 instead of Assembly.Load () on the `assembly' (before iteration
11538 over the link_paths).
11540 2002-04-26 Martin Baulig <martin@gnome.org>
11542 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11544 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11546 * class.cs (Property): use the new typemanager.MemberLookup
11548 (TypeContainer.MemberLookup): Implement using the
11549 TypeManager.MemberLookup now.
11551 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11552 and return MemberInfos, so that these can be used without an
11553 EmitContext (what we had before).
11555 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11557 * expression.cs: Fix the case where the argument to params if the
11558 type of the params. I omitted handling this before. Fixed
11560 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11562 * driver.cs: Call BootCorlib_PopulateCoreType
11564 * class.cs (Property.CheckBase): Check for properties only, not
11567 * interface.cs: Temporary hack: try/catch around the
11568 CustomAttributeBuilder, because I am getting an exception that I
11571 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11572 types whose definitions are required to be there (attributes are
11573 defined before standard types).
11575 Compute definitions as we boot the various types, as they are used
11576 immediately (value_type class will need object_type, but if we do
11577 not initialize object_type, we will pass a null, which will let
11578 the runtime pick the System.Object from the existing corlib, which
11579 is not what we want).
11581 2002-04-22 Patrik Torstensson <totte@labs2.com>
11583 * cs-tokenizer.cs: fixed a number of trim() issues.
11585 2002-04-22 Ravi Pratap <ravi@ximian.com>
11587 * expression.cs (Argument.Type): Ensure that we return the correct
11588 type when we have out or ref parameters [in which case we
11591 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11593 * class.cs (Property, Indexer): Allow extern modifier in there.
11595 * typemanager.cs (InitBaseTypes): Initializes object_type and
11596 value_type, since those will be used early on during the bootstrap
11597 process to compile corlib.
11599 (InitCoreTypes): Move code from here to InitBaseTypes.
11601 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11603 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11604 single-dimension arrays as using the ldlen opcode.
11606 Daniel Lewis discovered this optimization.
11608 * typemanager.cs: Add signature for System.Array::get_Length
11610 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11612 * statement.cs: report the error when the foreach does not apply to an
11613 array nor a collection.
11615 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11617 * expression.cs: Add implicit conversions to the operator ~.
11619 * constant.cs (DecimalConstant.Emit): Emit decimal value.
11621 * typemanager.cs: Locate the decimal constructor.
11623 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11625 * attribute.cs: use the new property of TypeOf.
11626 * expression.cs: added 'get' property around typearg.
11628 These changes fix a build breaker reported by NickD. Is this the
11629 correct way to fix? If not, please, revert my changes and make it
11632 2002-04-17 Miguel de Icaza <miguel@ximian.com>
11634 * attribute.cs: Add support for typeof in attribute invocations.
11635 I am not sure that this is right though.
11637 2002-04-14 Duncan Mak <duncan@ximian.com>
11639 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
11640 Binary.Operator.Division case.
11642 2002-04-13 Ravi Pratap <ravi@ximian.com>
11644 * class.cs (DefineType): Ensure that we do a proper check on
11645 attribute types and also register it with the TypeManager.
11647 (TypeContainer.Targets): The default for attribute types is
11648 AttributeTargets.All.
11650 * attribute.cs (ApplyAttributes): Registering the attribute type
11651 is done elsewhere, not when we discover we have a Usage attribute.
11653 2002-04-12 Ravi Pratap <ravi@ximian.com>
11655 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
11656 and get rid of is_delegate parameter.
11658 * everywhere : update.
11660 2002-04-12 Ravi Pratap <ravi@ximian.com>
11662 * cs-parser.jay (compilation_unit): Revamp completely to use
11663 some new ideas that I got from Rhys' grammar to solve the problems
11664 with assembly level attributes.
11666 (outer_declaration): New grammar production.
11668 (attribute_sections): Add.
11670 (opt_attributes): Base on attribute_sections
11672 (namespace_declaration): Allow opt_attributes to tackle the case
11673 when we have assembly level attributes - we are clever in this
11676 * attribute.cs (ApplyAttributes): Do not worry about assembly
11677 attributes in the non-global context.
11679 * rootcontext.cs (AddGlobalAttributes): Go back to using this
11680 instead of SetGlobalAttributes.
11682 * class.cs, rootcontext.cs : Ensure we define and generate
11683 attribute types before anything else.
11685 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
11686 and flag the new error -20 for the case when the attribute type
11687 does not have valid targets specified. csc does not catch this.
11689 * ../errors/errors.txt : update for error # -20
11691 2002-04-11 Ravi Pratap <ravi@ximian.com>
11693 * support.cs (InternalParameters.ParameterModifier): Do some null
11694 checking and return sane values.
11696 * class.cs (Method.Define): If we are a PInvoke method, ensure
11697 that we are static and extern. Report error # 601
11699 * ../errors/cs0601.cs : Add test case for the above error.
11701 2002-04-07 Ravi Pratap <ravi@ximian.com>
11703 * rootcontext.cs (attribute_types): We need to keep type of
11704 all attribute types separately and emit code for them first.
11706 (RegisterAttribute) : Implement.
11708 * class.cs (DefineType): Check if the current Type is a custom
11709 attribute type and register it accordingly.
11711 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
11712 adding the first attribute twice and rename to
11714 (SetGlobalAttributes): this.
11716 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
11719 * attribute.cs (ApplyAttributes): Take an additional argument telling us
11720 if we are processing global arguments. Hmm, I am unsure of this.
11722 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11724 * expression.cs: added static array of strings to avoid calling
11725 Enum.ToString () for Operator in Binary. Significant recover of
11728 2002-04-10 Miguel de Icaza <miguel@ximian.com>
11730 * class.cs (FindMembers): Allow the Builders of the various
11731 members to be null. If they are skip them. This only happens
11732 during the PInvoke declaration.
11734 2002-04-09 Miguel de Icaza <miguel@ximian.com>
11736 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
11737 failure, so we do not keep going afterwards.
11739 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
11740 wanted to pass `false' as the `is_delegate' argument. If this is
11741 the case, why not use delegate_type == null to mean `is_delegate =
11742 false' and anything else as is_delegate = true.
11744 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
11746 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
11747 code for the section, not the beginning of the tests.
11749 2002-04-08 Miguel de Icaza <miguel@ximian.com>
11751 * cfold.cs: Handle operator + (Enum x, Underlying x)
11753 * expression.cs (Binary): same. Warn about errors where we have
11754 Enum/Enum in operator + as well.
11756 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
11759 - added support for switch(bool)
11760 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
11761 - add TableSwitchEmit() to handle table-based switch statements
11763 2002-04-05 Ravi Pratap <ravi@ximian.com>
11765 * expression.cs (Invocation.OverloadResolve): Factor out code which
11766 does parameter compatibility checking with arguments so that we can
11767 re-use the code even from Delegate.VerifyApplicability
11769 (VerifyArgumentsCompat): Move above code here.
11771 * delegate.cs (VerifyApplicability): Get rid of duplicate code
11772 and instead make a call to the above method.
11774 2002-03-31 Ravi Pratap <ravi@ximian.com>
11776 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
11777 We use it to keep track of classes which are attribute types.
11779 2002-04-02 Miguel de Icaza <miguel@ximian.com>
11781 * delegate.cs (Delegate.Define): Correctly define the types in the
11782 presence of fixed and array parameters.
11784 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
11787 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
11788 include NonPublic after the first iteration.
11790 * class.cs (Indexer.CheckBase): Only check if both parents are
11793 * cs-parser.jay (accessor_body): If empty, set to null.
11795 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
11796 same code path here to resolve constants names that we did have in
11797 MemberAccess.DoResolve. There is too much code duplicated here.
11799 2002-04-01 Miguel de Icaza <miguel@ximian.com>
11801 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
11803 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
11806 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
11807 tokens, numbers and strings.
11809 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
11812 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
11813 asyncronous parameters and the regular parameters.
11815 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
11816 specify the target directory.
11818 * expression.cs: (This.DoResolve): Simplify
11819 (As.Emit): Optimize, do not generate IsInst if the expression is
11820 always of the given type.
11822 (Is.DoResolve): Bug fix, we were reporting both always/never for
11825 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
11826 creating too many unnecessary arrays.
11828 2002-03-31 Miguel de Icaza <miguel@ximian.com>
11830 * class.cs (EmitFieldInitializer): Use Assign expression to assign
11831 fields instead of rolling our own initializer. Takes care of all
11832 implicit conversions, and drops unnecessary static checks/argument.
11834 2002-03-31 Dick Porter <dick@ximian.com>
11836 * driver.cs: use the GetDirectories() return values properly, and
11837 use "/" as path separator.
11839 2002-03-30 Miguel de Icaza <miguel@ximian.com>
11841 * expression.cs (Unary): Optimize - - expr into expr.
11842 (Binary): Optimize a + (-b) into a -b.
11844 * codegen.cs (CodeGen): Made all methods static.
11846 2002-03-29 Miguel de Icaza <miguel@ximian.com>
11850 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
11851 TypeBuilder property.
11853 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
11856 * tree.cs: Removed the various RecordXXXX, and replaced with a
11857 single RecordDecl. Removed all the accessor methods, and just
11858 left a single access point Type
11860 * enum.cs: Rename DefineEnum to DefineType.
11862 * decl.cs: New abstract method `DefineType' used to unify the
11863 Defines for Enumerations, Interfaces, TypeContainers and
11866 (FindType): Moved LookupInterfaceOrClass here. Moved the
11867 LookupBaseClasses method that used to live in class.cs and
11868 interface.cs here, and renamed to FindType.
11870 * delegate.cs: Implement DefineType. Take advantage of the
11871 refactored pattern for locating the parent builder without taking
11872 the parent_builder argument (which we know does not work if we are
11873 nested, and triggering a toplevel definition).
11875 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11877 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
11878 accessibility of a member has changed during override and report
11881 * class.cs (Method.Define, Property.Define): Only complain on
11882 overrides if the method is private, any other accessibility is
11883 fine (and since we just checked the permission is the same, we are
11886 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
11887 and elif are processed always. The other pre-processing
11888 directives are only processed if we are "taking" the path
11890 2002-03-29 Martin Baulig <martin@gnome.org>
11892 * class.cs (Method.Emit): Only emit symbolic debugging info if the
11893 current location is not Null.
11895 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
11896 a separate method so we can profile it.
11898 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
11899 `span.Seconds' are just seconds, but no minutes or hours.
11900 (MainDriver): Profile the CodeGen.SaveSymbols calls.
11902 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11904 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
11905 Remove the gratuitous set of Final:
11907 // If an interface implementation, then we can set Final.
11908 if (((flags & MethodAttributes.Abstract) == 0) &&
11909 implementing.DeclaringType.IsInterface)
11910 flags |= MethodAttributes.Final;
11912 I do not know what I was smoking when I used that.
11915 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
11916 step into fixing the name resolution issues for delegates and
11917 unifying the toplevel name resolution.
11919 2002-03-28 Martin Baulig <martin@gnome.org>
11921 * class.cs (Method.Emit): If we have a symbol writer, call its
11922 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
11923 tell it about the current method.
11925 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
11926 writer that we're going to emit the first byte of IL code for a new
11927 statement (a new source line).
11928 (EmitContext.EmitTopBlock): If we have a symbol writer, call
11929 EmitContext.Mark() before emitting any code.
11931 * location.cs (SymbolDocument): Return null when we're Null.
11933 * statement.cs (Statement): Moved the `Location loc' variable here.
11934 (Statement.EmitBoolExpression): If we have a symbol writer, call
11935 ec.Mark() before emitting any code to tell it that we're at the
11936 beginning of a new statement.
11937 (StatementExpression): Added `Location' argument to the constructor.
11938 (Block): Added public readonly variable `StartLocation' and public
11939 variable `EndLocation'. The latter is to be set using SetEndLocation().
11940 (Block): Added constructor which takes a start and end location.
11941 (Block.SetEndLocation): New method. This sets the end location.
11942 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
11943 local variables we create.
11944 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
11945 each statement and do also mark the begin and end of the block.
11947 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
11948 tell it the current lexer.Location, use Location.Null for the end of the
11950 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
11951 current block, set its end location using SetEndLocation().
11952 (statement_expression): StatementExpression constructor now takes the
11953 lexer.Location as additional argument.
11954 (for_statement, declare_local_variables): Likewise.
11955 (declare_local_variables): When creating a new implicit block, use the
11956 new Block constructor and pass it the lexer.Location.
11958 2002-03-28 Miguel de Icaza <miguel@ximian.com>
11960 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
11961 members also on the parent interfaces recursively.
11963 2002-03-27 Miguel de Icaza <miguel@ximian.com>
11965 * report.cs: Use new formats, since Gonzalo finished the missing
11968 * expression.cs (Binary.ResolveOperator): added missing operator|
11969 operator& and operator^ for bool/bool.
11971 * cs-parser.jay: CheckDef now takes a Location argument that is
11972 used to report errors more precisly (instead of reporting the end
11973 of a definition, we try to track something which is a lot closer
11974 to the source of the problem).
11976 * cs-tokenizer.cs: Track global token use, so we can properly flag
11977 the use of #define/#undef after the first token has been seen.
11979 Also, rename the reportXXXX to Error_DescriptiveName
11981 * decl.cs (DeclSpace.IsTopLevel): Move property here from
11982 TypeContainer, so that Enum and Interface can use this too.
11984 * class.cs (TypeContainer.LookupInterfaceOrClass,
11985 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
11986 `builder' argument. Typically this was used to pass the parent
11987 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
11990 The problem is that a nested class could trigger the definition of
11991 a toplevel class, and the builder would be obviously wrong in that
11994 So we drop this argument, and we compute dynamically the
11995 TypeBuilder/ModuleBuilder (the correct information was available
11996 to us anyways from DeclSpace.Parent)
11998 * interface.cs (Interface.DefineInterface): Drop builder
11999 parameter cleanup like class.cs
12001 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12004 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12007 (Try.Emit): Propagate the returns value from the statement.
12009 (Return.Emit): Even if we are leavning
12011 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12013 * modifiers.cs: Fix the computation of MethodAttributes flags.
12015 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12017 * driver.cs: allow compilation of files that start with '/'.
12018 Add a default case when checking the argument of --target.
12020 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12022 * interface.cs: Implement the same search algorithm for types in
12023 the interface code.
12025 * delegate.cs: Do not allow multiple definition.
12027 * Recovered ChangeLog that got accidentally amputated
12029 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12031 * rootcontext.cs: Load manually enum to allow core classes to
12032 contain enumerations.
12034 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12035 Update to new static methods in TypeManager.
12037 * typemanager.cs (GetMethod, GetConstructor): Use our
12038 implementation of FindMembers to find the members, since during
12039 corlib compilation, the types are TypeBuilders and GetMethod and
12040 GetConstructor do not work.
12042 Make all methods in TypeManager static.
12044 (InitCodeHelpers): Split the functionality from
12045 the InitCodeTypes function.
12047 * driver.cs: Call InitCodeHelpers after we have populated the
12050 * cs-parser.jay (delegate_declaration): we did not used to compute
12051 the delegate name correctly for void delegates.
12053 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12055 * rootcontext.cs (RootContext): Init the interface_resolve_order
12056 and type_container_resolve_order always.
12058 (ResolveCore, BootstrapCorlib_ResolveClass,
12059 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12060 compiler when compiling with --nostdlib
12062 * class.cs (TypeContainer.DefineType): Check that our parent is
12063 not null. This test is most important when we are bootstraping
12066 * codegen.cs: Split out the symbol writing code.
12068 2002-03-25 Martin Baulig <martin@gnome.org>
12070 * driver.cs (-g): Made -g an alias for --debug.
12072 2002-03-24 Martin Baulig <martin@gnome.org>
12074 * codegen.cs (SymbolWriter): New public variable. Returns the
12075 current symbol writer.
12076 (CodeGen): Added `bool want_debugging_support' argument to the
12077 constructor. If true, tell the ModuleBuild that we want debugging
12078 support and ask it for the ISymbolWriter.
12079 (Save): If we have a symbol writer, call it's Close() method after
12080 saving the assembly.
12082 * driver.c (--debug): New command line argument to create a
12083 debugger information file.
12085 * location.cs (SymbolDocument): New public property. Returns an
12086 ISymbolDocumentWriter object for the current source file or null
12087 if we don't have a symbol writer.
12089 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12091 * driver.cs (LoadAssembly): Correctly return when all the paths
12092 have been tried and not before.
12094 * statement.cs (Switch.Emit): return the actual coverage for this
12095 statement (returns/not-returns)
12097 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12098 switch of the statement if we are the last switch section. That
12099 kills two problems: try/catch problems (we used to emit an empty
12100 nop at the end) and switch statements where all branches would
12103 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12105 * driver.cs: Add default assemblies (the equivalent to the
12106 Microsoft CSC.RSP file)
12108 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12109 also update tokens_seen and set it to false.
12111 * driver.cs: Implement --recurse for Mike.
12113 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12114 correctly splitting out the paths.
12116 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12118 * interface.cs (Interface.PopulateProperty): Instead of using
12119 `parent' as the declaration space for the set parameters, use
12122 * support.cs (InternalParameters): InternalParameters constructor
12123 takes a DeclSpace instead of a TypeContainer.
12125 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12126 types are being initialized, load the address of it before calling
12129 (New): Provide a mechanism to disable the generation of local
12130 value type temporaries when the caller will be providing us with
12131 an address to store it.
12133 (ArrayCreation.EmitDynamicInitializers): Use it.
12135 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12137 * expression.cs (Invocation.EmitArguments): Only probe for array
12138 property if there is more than one argument. Sorry about that.
12140 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12141 empty param arrays.
12143 * class.cs (Method.LabelParameters): Fix incorrect code path that
12144 prevented the `ParamArrayAttribute' from being applied to the
12147 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12149 * support.cs (ReflectionParameters): Correctly compute whether the
12150 last argument is a params array. Fixes the problem with
12153 * typemanager.cs: Make the assemblies array always be non-null
12154 (empty, but non-null)
12156 * tree.cs (RecordDecl): New function that abstracts the recording
12157 of names. This reports error 101, and provides a pointer to the
12158 previous declaration. Fixes a crash in the compiler.
12160 * cs-parser.jay (constructor_declaration): Update to new grammar,
12161 and provide a constructor_body that can be empty.
12163 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12165 * driver.cs: Add support for --resources.
12167 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12168 Make all types for the various array helper methods be integer.
12170 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12171 CheckState to ConvCast.
12173 (ConvCast): Now it takes a `checked' state argument, to avoid
12174 depending on the emit context for the conversion, and just using
12175 the resolve time setting.
12177 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12178 instead of Invocation.EmitArguments. We do not emit the original
12179 arguments, instead we emit those which have been converted to
12180 unsigned int expressions.
12182 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12184 * codegen.cs: ditto.
12186 * expression.cs (LocalVariableReference): Drop the use of the
12187 Store function that depended on the variable index.
12189 * statement.cs (VariableInfo): Drop the `Idx' property from this
12190 class, as this is not taking into account the indexes for
12191 temporaries tat we generate during the execution, getting the
12194 * class.cs: First emit class initializers, then call the parent
12197 * expression.cs (Binary): Fix opcode emision.
12198 (UnaryMutator.EmitCode): Support checked code generation
12200 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12201 matches for events for both the Static and Instance scans,
12202 pointing to the same element. Fix that.
12204 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12206 * rootcontext.cs (ResolveTree): Always set the
12207 interface_resolve_order, because nested interfaces will be calling
12210 * class.cs (GetInterfaceOrClass): Track the same resolution
12211 process used by TypeManager.LookupType. This fixes the nested
12212 type lookups in class declarations (separate path from
12215 (TypeContainer.DefineType): Also define nested interfaces.
12216 (TypeContainer.RegisterOrder): New public function used to
12217 register the order in which child interfaces need to be closed.
12219 Nested interfaces need to be closed after their parents have been
12222 * interface.cs (InterfaceAttr): Put all the logic for computing
12223 the interface attribute here.
12225 (DefineInterface): Register our interface order with the
12226 RootContext or with the TypeContainer depending on the case.
12228 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12230 * cs-parser.jay: rework foreach statement to work with the new
12231 changes to the policy on SimpleNames.
12233 * report.cs: support Stacktrace on warnings as well.
12235 * makefile: drop --unsafe and /unsafe from the compile.
12237 2002-03-13 Ravi Pratap <ravi@ximian.com>
12239 * ecore.cs (StandardConversionExists): Modify to take an Expression
12240 as the first parameter. Ensure we do null -> reference type conversion
12243 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12244 temporary Expression objects.
12246 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12248 * interface.cs: workaround bug in method overloading resolution
12249 (there is already a bugzilla bug for it).
12251 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12253 We could also solve this problem by having a separate path for
12254 performing type lookups, instead of DoResolve, we could have a
12255 ResolveType entry point, and only participating pieces of the
12256 production (simplename, deref, array) would implement this.
12258 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12259 signal SimpleName to only resolve type names and not attempt to
12260 resolve anything else.
12262 * expression.cs (Cast): Set the flag.
12264 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12266 * class.cs: Only report 108 if there is no `new' modifier.
12268 * cs-parser.jay: rework foreach statement to work with the new
12269 changes to the policy on SimpleNames.
12271 * report.cs: support Stacktrace on warnings as well.
12273 * makefile: drop --unsafe and /unsafe from the compile.
12275 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12277 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12278 lookups here, instead of doing that at parse time. This means
12279 that our grammar will not introduce `LocalVariableReferences' as
12280 expressions at this point. That solves the problem of code like
12284 static void Main ()
12288 This is only half the fix. The full fix requires parameters to
12289 also be handled in this way.
12291 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12292 makes the use more obvious of the DeclSpace. The
12293 ec.TypeContainer.TypeBuilder is now only used to pull the
12294 TypeBuilder for it.
12296 My theory is that I can get rid of the TypeBuilder completely from
12297 the EmitContext, and have typecasts where it is used (from
12298 DeclSpace to where it matters).
12300 The only pending problem is that the code that implements Aliases
12301 is on TypeContainer, and probably should go in DeclSpace.
12303 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12304 lookups here, instead of doing that at parse time. This means
12305 that our grammar will not introduce `LocalVariableReferences' as
12306 expressions at this point. That solves the problem of code like
12310 static void Main ()
12314 This is only half the fix. The full fix requires parameters to
12315 also be handled in this way.
12317 * class.cs (Property.DefineMethod): When implementing an interface
12318 method, set newslot, when implementing an abstract method, do not
12319 set the flag (before we tried never setting it, or always setting
12320 it, which is the difference).
12321 (Indexer.DefineMethod): same.
12322 (Method.DefineMethod): same.
12324 * ecore.cs: Only set the status used flag if we get back a Field.
12326 * attribute.cs: Temporary hack, so Paolo can keep working.
12328 2002-03-08 Ravi Pratap <ravi@ximian.com>
12330 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12331 the unmanaged type in the case we have a MarshalAs attribute.
12333 (Resolve): Handle the case when we are parsing the special MarshalAs
12334 attribute [we need to store the unmanaged type to use later]
12336 * typemanager.cs (marshal_as_attr_type): Built in type for the
12337 MarshalAs Attribute.
12339 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12340 on parameters and accordingly set the marshalling info.
12342 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12344 * class.cs: Optimizing slightly by removing redundant code after
12345 we switched to the `NoTypes' return value.
12346 (Property.DefineMethod): use NoTypes here too.
12348 This fixes the bug I introduced in my last batch of changes.
12350 2002-03-05 Ravi Pratap <ravi@ximian.com>
12352 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12354 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12355 Enums since those are types too.
12357 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12359 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12360 thanks to a call during the lookup process.
12362 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12364 * statement.cs (Foreach): Lots of work to accomodate a particular
12365 kind of foreach statement that I had not kept in mind. It is
12366 possible to have foreachs on classes that provide a GetEnumerator
12367 method that return objects that implement the "pattern" for using
12368 a foreach, there is no need to support GetEnumerator
12371 This is needed to compile nant.
12373 * decl.cs: Only report 114 if the member is not `Finalize' and if
12374 the warning level is at least 2.
12376 * class.cs: Moved the compare function from Method to
12379 (MethodSignature.InheritableMemberSignatureCompare): Add new
12380 filter function that is used to extract inheritable methods from a
12383 (Method.Define): Use the new `inheritable_method_signature_filter'
12386 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12389 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12391 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12393 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12395 * expression.cs: Pass location information to
12396 ConvertImplicitStandard.
12398 * class.cs: Added debugging code to track return values from
12401 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12403 * expression.cs (Is.DoResolve): If either side of the `is' is an
12404 interface, do not flag the warning.
12406 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12409 * report.cs: Allow for --fatal to be used with --probe.
12411 * typemanager.cs (NoTypes): Move the definition for the empty Type
12414 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12416 (TypeContainer.DefineProxy): New function used to proxy to parent
12417 implementations when implementing interfaces.
12418 (TypeContainer.ParentImplements): used to lookup if our parent
12419 implements a public function that is required by an interface.
12420 (TypeContainer.VerifyPendingMethods): Hook this up.
12422 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12423 `modules' and `assemblies' arraylists into arrays. We only grow
12424 these are the very early start up of the program, so this improves
12425 the speedof LookupType (nicely measured).
12427 * expression.cs (MakeByteBlob): Replaced unsafe code with
12428 BitConverter, as suggested by Paolo.
12430 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12431 folding of string concatenation, but if either side is a string,
12432 and the other is not, then return null, and let the runtime use
12433 the concatenation on the string plus the object (using
12434 `Object.ToString').
12436 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12438 Constant Folding has been implemented now.
12440 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12441 the error instead on types that are not supported in one's
12444 * constant.cs (Constant and all children): New set of functions to
12445 perform implict and explicit conversions.
12447 * ecore.cs (EnumConstant): Implement the new functions to perform
12448 conversion by proxying to the child expression.
12450 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12451 own separate setting that can not be turned off from the command
12452 line using --unchecked or --checked and is only controlled using
12453 the checked/unchecked statements and expressions. This setting is
12454 used by the constant folder to flag errors.
12456 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12457 ConstantCheckState as well.
12459 During Resolve, they also have to flag the state, because the
12460 constant folder runs completely in the Resolve phase.
12462 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12465 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12467 * cfold.cs: New file, this file contains the constant folder.
12469 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12470 argument to track whether we are using the resulting address to
12471 load or store a value and provide better error messages.
12473 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12474 new AddressOf arguments.
12476 * statement.cs (Foreach.EmitCollectionForeach): Update
12478 * expression.cs (Argument.Emit): Call AddressOf with proper
12479 arguments to track usage.
12481 (New.DoEmit): Call AddressOf with new arguments.
12483 (Unary.Emit): Adjust AddressOf call.
12485 2002-03-01 Ravi Pratap <ravi@ximian.com>
12487 * cs-parser.jay (member_access): Change the case for pre-defined types
12488 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12491 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12494 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12495 essentially like methods and apply attributes like MethodImplOptions to them too.
12497 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12500 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12501 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12504 * Update code everywhere accordingly.
12506 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12508 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12510 2002-02-28 Ravi Pratap <ravi@ximian.com>
12512 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12513 try performing lookups against those instead of jumping straight into using
12514 the 'using' clauses.
12516 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12518 (LookupType): Perform lookups in implicit parents too.
12520 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12521 sequence as RootContext.LookupType.
12523 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12524 the various cases of namespace lookups into this method.
12526 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12528 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12529 in positional arguments)
12531 * class.cs (Operator): Update the AllowedModifiers to contain
12534 * cs-parser.jay: Update operator declaration to allow for the
12535 operator body to be empty.
12537 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12540 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12542 * class.cs (Method.Emit): Label parameters.
12544 * driver.cs: Return 1 or 0 as the program exit code.
12546 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12548 * expression.cs: Special case the `null' object when trying to
12549 auto-compute the type, as anything can be explicitly converted to
12552 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12553 spotting this Paolo.
12555 (Expression.ImplicitNumericConversion): Perform comparissions of
12556 the type using the underlying type in the case of an enumeration
12557 rather than using the enumeration type for the compare.
12559 Cope with the underlying == type case, which is not possible to
12562 (Expression.ConvertNumericExplicit): Perform comparissions of
12563 the type using the underlying type in the case of an enumeration
12564 rather than using the enumeration type for the compare.
12566 * driver.cs: If the user does not supply an extension, assume .exe
12568 * cs-parser.jay (if_statement): Rewrote so that we can track the
12569 location for the if statement.
12571 * expression.cs (Binary.ConstantFold): Only concat strings when
12572 the operation is "+", not everything ;-)
12574 * statement.cs (Statement.EmitBoolExpression): Take a location
12576 (If, While, Do): Track location.
12578 * expression.cs (Binary.ResolveOperator): In the object + string
12579 case, I was missing a call to ConvertImplicit
12581 2002-02-25 Ravi Pratap <ravi@ximian.com>
12583 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
12584 Location arguments. Ensure we use RootContext.LookupType to do our work
12585 and not try to do a direct Type.GetType and ModuleBuilder.GetType
12587 * interface.cs (PopulateMethod): Handle the type of the parameter being
12590 * expression.cs (Invocation.BetterFunction): Handle the case when we
12591 have a params method with no fixed arguments and a call is made with no
12594 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12596 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12597 the verbatim-string-literal
12599 * support.cs (InternalParameters.ParameterModifier): handle null
12601 (InternalParameters.ParameterType): ditto.
12603 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12604 duplicating the name of the variable parameter.
12605 (GetParameterByName): Fix bug where we were not looking up array
12606 paramters if they were the only present (thanks Paolo!).
12607 (GetParameterInfo): We only have an empty set of types if both
12608 fixed and array are set to null.
12609 (GetParameterInfo-idx): Handle FixedParameter == null
12611 * cs-parser.jay: Handle the case where there is no catch
12612 statements (missing null test).
12614 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12616 * driver.cs (MainDriver): Be conservative on our command line
12619 Catch DirectoryNotFoundException when calling GetFiles.
12621 (SplitPathAndPattern): Used to split the input specification into
12622 a path and a pattern that we can feed to Directory.GetFiles.
12624 2002-02-21 Miguel de Icaza <miguel@ximian.com>
12626 * statement.cs (Fixed): Implement the last case of the Fixed
12627 statement (string handling).
12629 * expression.cs (StringPtr): New class used to return a char * to
12630 a string; Used by the Fixed statement.
12632 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
12634 * expression.cs (Binary.ResolveOperator): Remove redundant
12635 MemberLookup pn parent type.
12636 Optimize union call, we do not need a union if the types are the same.
12637 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
12640 Specialize the use of MemberLookup everywhere, instead of using
12641 the default settings.
12643 (StackAlloc): Implement stackalloc keyword.
12645 * cs-parser.jay: Add rule to parse stackalloc.
12647 * driver.cs: Handle /h, /help, /?
12649 * expression.cs (MakeByteBlob): Removed the hacks we had in place
12650 before we supported unsafe code.
12652 * makefile: add --unsafe to the self compilation of mcs.
12654 2002-02-20 Miguel de Icaza <miguel@ximian.com>
12656 * expression.cs (PointerArithmetic): New class that is used to
12657 perform pointer arithmetic.
12658 (Binary.Resolve): Handle pointer arithmetic
12659 Handle pointer comparission.
12660 (ArrayPtr): Utility expression class that is used to take the
12661 address of an array.
12663 (ElementAccess): Implement array access for pointers
12665 * statement.cs (Fixed): Implement fixed statement for arrays, we
12666 are missing one more case before we are done.
12668 * expression.cs (Indirection): Implement EmitAssign and set the
12669 ExprClass to Variable. This allows pointer dereferences to be
12670 treated as variables, and to have values assigned to them.
12672 * ecore.cs (Expression.StoreFromPtr): New utility function to
12673 store values dereferencing.
12675 2002-02-20 Ravi Pratap <ravi@ximian.com>
12677 * expression.cs (Binary.ResolveOperator): Ensure that we are
12678 not trying to operate on a void type - this fixes the reported
12681 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
12682 the parent implementation is sealed.
12684 * ../errors/cs0239.cs : Add.
12686 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
12688 * typemanager.cs (unverifiable_code_type): Corresponds to
12689 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
12690 which have unsafe code in them.
12692 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
12695 2002-02-19 Miguel de Icaza <miguel@ximian.com>
12697 * cs-tokenizer.cs: Add support for @"litreal strings"
12699 Make tokenizer accept pre-processor directives
12700 on any column (remove the old C-like limitation).
12702 * rootcontext.cs (EmitCode): Emit any global attributes.
12703 (AddGlobalAttributes): Used to keep track of assembly attributes.
12705 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
12707 * cs-parser.jay: Add support for global attributes.
12709 2002-02-17 Miguel de Icaza <miguel@ximian.com>
12711 * expression.cs (Indirection): New helper class. Unary will
12712 create Indirection classes to be able to implement the
12713 IMemoryLocation interface on it.
12715 2002-02-16 Miguel de Icaza <miguel@ximian.com>
12717 * cs-parser.jay (fixed_statement): reference the right statement.
12719 * statement.cs (Fixed.Emit): Finish implementing the fixed
12720 statement for the &x case.
12722 2002-02-14 Miguel de Icaza <miguel@ximian.com>
12724 * class.cs (Property.Define, Method.Define): Remove newslot when
12727 * modifiers.cs: My use of NewSlot when `Abstract' was set was
12728 wrong. NewSlot should only be used if the `new' keyword is present.
12730 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
12731 locating our system dir. Sorry about this.
12733 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12735 * driver.cs (GetSystemDir): Compute correctly the location of our
12736 system assemblies. I was using the compiler directory instead of
12737 the library directory.
12739 2002-02-13 Ravi Pratap <ravi@ximian.com>
12741 * expression.cs (BetterFunction): Put back in what Miguel commented out
12742 since it is the correct fix. The problem is elsewhere ;-)
12744 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
12745 parameters of the parms method are themselves compatible or not !
12747 (StandardConversionExists): Fix very dangerous bug where we were forgetting
12748 to check that a class implements an interface before saying that an implicit
12749 conversion was allowed. Use ImplementsInterface to do the checking.
12751 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12753 * class.cs (Method.Define): Track whether we are an explicit
12754 implementation or not. And only call DefineMethodOverride if we
12755 are an explicit implementation.
12757 (Property.DefineMethod): Ditto.
12759 2002-02-11 Ravi Pratap <ravi@ximian.com>
12761 * expression.cs (BetterFunction): Catch hideous bug which was
12762 preventing us from detecting ambiguous calls due to implicit casts i.e
12765 2002-01-29 Miguel de Icaza <miguel@ximian.com>
12767 * support.cs (Pair): Remove un-needed method. I figured why I was
12768 getting the error in cs-parser.jay, the variable in a foreach loop
12769 is readonly, and the compiler does not really treat this as a variable.
12771 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
12772 instead of EQUALS in grammar.
12774 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
12776 * expression.cs (Unary.DoResolve): Check whether the argument is
12779 2002-01-28 Miguel de Icaza <miguel@ximian.com>
12781 * support.cs: Api for Pair to set a value. Despite the fact that
12782 the variables are public the MS C# compiler refuses to compile
12783 code that accesses the field if the variable is part of a foreach
12786 * statement.cs (Fixed): Begin implementation of the fixed
12789 (Block.AddVariable): Return the VariableInfo on success and null
12790 on failure instead of true/false.
12792 * cs-parser.jay (foreach): Catch errors on variables already
12793 defined (we were ignoring this value before) and properly unwind
12794 the block hierarchy
12796 (fixed_statement): grammar for the fixed statement.
12798 2002-01-25 Miguel de Icaza <miguel@ximian.com>
12800 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
12801 pointer types to be incretemented.
12803 (SizeOf): Implement.
12805 * cs-parser.jay (pointer_member_access): Implement
12806 expr->IDENTIFIER production.
12808 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
12809 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
12812 (Unary): Implement indirection.
12814 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
12815 use in non-unsafe context).
12817 (SimpleName.DoResolve): Check for pointers in field access on safe
12820 (Expression.LoadFromPtr): Factor the load-indirect code in this
12821 function. This was duplicated in UnboxCast and ParameterReference
12823 2002-01-24 Miguel de Icaza <miguel@ximian.com>
12825 * expression.cs (ComposedCast): report an error if a pointer cast
12826 is used in a safe region.
12828 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
12829 pointer type casts in unsafe context.
12831 * codegen.cs (EmitContext): Set up IsUnsafe.
12833 * cs-parser.jay (non_expression_type): Add productions for pointer
12836 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
12837 code. We should not use force into static mode if the method is
12838 not virtual. Fixes bug in MIS
12840 * statement.cs (Do.Emit, While.Emit, For.Emit,
12841 Statement.EmitBoolExpression): Add support to Do and While to
12842 propagate infinite loop as `I do return' semantics.
12844 Improve the For case to also test for boolean constants.
12846 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
12847 to the list of attributes we can add.
12849 Remove `EmitContext' argument.
12851 * class.cs (Method.Define): Apply parameter attributes.
12852 (Constructor.Define): Apply parameter attributes.
12853 (MethodCore.LabelParameters): Move here the core of labeling
12856 * support.cs (ReflectionParameters.ParameterModifier,
12857 InternalParameters.ParameterModifier): Use IsByRef on the type and
12858 only return the OUT bit for these parameters instead of in/out/ref
12861 This is because I miss-understood things. The ParameterInfo.IsIn
12862 and IsOut represent whether the parameter has the [In] and [Out]
12865 2002-01-22 Miguel de Icaza <miguel@ximian.com>
12867 * ecore.cs (FieldExpr.Emit): Release temporaries.
12869 * assign.cs (LocalTemporary.Release): new function.
12871 * codegen.cs (EmitContext.GetTemporaryStorage,
12872 EmitContext.FreeTemporaryStorage): Rework the way we deal with
12873 temporary storage. Now we can "put back" localbuilders when we
12876 2002-01-21 Miguel de Icaza <miguel@ximian.com>
12878 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
12879 need to make a copy of the variable to generate verifiable code.
12881 2002-01-19 Miguel de Icaza <miguel@ximian.com>
12883 * driver.cs: Compute dynamically the system directory.
12885 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
12886 Slower, but more generally useful. Used by the abstract
12887 registering implementation.
12889 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
12890 the rules for the special rule on Type/instances. First check if
12891 we have the same name, and if so, try that special static path
12892 rather than the instance path.
12894 2002-01-18 Miguel de Icaza <miguel@ximian.com>
12896 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
12899 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
12900 Enum, ValueType, Delegate or Array for non-corlib compiles.
12902 * cs-tokenizer.cs: Catch long identifiers (645)
12904 * typemanager.cs (IndexerPropetyName): Ravi never tested this
12907 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
12908 fix, we were returning too early, so we were not registering
12909 pending methods from abstract classes.
12911 Do not register pending methods if the class is abstract.
12913 * expression.cs (Conditional.DoResolve): Report circular implicit
12914 conversions when we neecd to compute it for conditional
12917 (Is.DoResolve): If the expression is always of the provided type,
12918 flag warning 183. If the expression can not ever be of the
12919 provided type flag warning 184.
12921 * class.cs: Catch 169 as well.
12923 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
12926 2002-01-18 Nick Drochak <ndrochak@gol.com>
12928 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
12930 2002-01-17 Miguel de Icaza <miguel@ximian.com>
12932 * interface.cs: (PopulateMethod): Check for pointers being defined
12933 only if the unsafe context is active.
12934 (PopulateProperty): ditto.
12935 (PopulateIndexer): ditto.
12937 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
12938 specified. If pointers are present, make sure that they are
12939 present in an unsafe context.
12940 (Constructor, Constructor.Define): ditto.
12941 (Field, Field.Define): ditto.
12942 (Property, Property.Define): ditto.
12943 (Event, Event.Define): ditto.
12945 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
12946 hashtable if there are classes or structs defined.
12948 * expression.cs (LocalVariableReference.DoResolve): Simplify this
12949 code, as the constant resolution moved.
12951 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
12952 the metadata, so we can flag error 133.
12954 * decl.cs (MemberCore.UnsafeOK): New function to test that a
12955 pointer is being declared in an unsafe context.
12957 2002-01-16 Miguel de Icaza <miguel@ximian.com>
12959 * modifiers.cs (Modifiers.Check): Require a Location argument.
12960 Report error 227 for Unsafe use.
12962 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
12964 * statement.cs (For.Emit): If the test is null, then report that
12965 we do `return', as we wont reach anything afterwards.
12967 (Switch.SwitchGoverningType): Track the expression that matched
12970 * driver.cs: Allow negative numbers as an error code to flag.
12972 * cs-parser.jay: Handle 1551.
12974 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
12976 2002-01-15 Miguel de Icaza <miguel@ximian.com>
12978 * cs-parser.jay: Report 1518 (type declaration can only contain
12979 class, struct, interface, enum or delegate)
12981 (switch_label): Report 1523 (keywords `case' or `default' must
12984 (opt_switch_sections): Report 1522 (empty switch)
12986 * driver.cs: Report 1515 (response file specified multiple times)
12987 Report 1516 (Source file specified multiple times).
12989 * expression.cs (Argument.Resolve): Signal 1510
12991 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
12992 access not allowed in static code)
12994 2002-01-11 Ravi Pratap <ravi@ximian.com>
12996 * typemanager.cs (IsPointerType): Utility method which we are going
12999 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13000 the object type, so we take care of that.
13002 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13004 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13005 added to non-params parameters :-)
13007 * typemanager.cs (CSharpName): Include 'void' type too.
13009 (void_ptr_type): Include in the set of core types.
13011 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13014 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13017 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13018 completely forgotten about it.
13020 2002-01-10 Ravi Pratap <ravi@ximian.com>
13022 * cs-parser.jay (pointer_type): Add. This begins our implementation
13023 of parsing rules for unsafe code.
13025 (unsafe_statement): Implement.
13027 (embedded_statement): Modify to include the above.
13029 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13031 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13032 if the current context is an unsafe one.
13034 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13035 are handled differently, we need separate rules for them.
13037 (local_variable_declaration): Update to use local_variable_pointer_type
13038 to allow variable declarations of unmanaged pointer types.
13040 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13041 in unsafe contexts.
13043 * ../errors/cs0214.cs : Add.
13045 2002-01-16 Nick Drochak <ndrochak@gol.com>
13047 * makefile: remove 'response' file when cleaning.
13049 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13051 * cs-parser.jay: Report 1524.
13053 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13055 * typemanager.cs (RegisterMethod): drop checking if we have
13056 registered this from here
13058 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13060 * class.cs (Method.EmitDestructor): Implement calling our base
13063 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13064 value of InFinally.
13066 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13067 this routine and will wrap the call in a try/catch block. Deal
13070 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13072 * ecore.cs (Expression.MemberLookup): instead of taking a
13073 parameter `same_type' that was used to tell whether we could
13074 access private members we compute our containing type from the
13077 (FieldExpr): Added partial support for volatile fields. This does
13078 not work for volatile fields exposed from assemblies, as I can not
13079 figure out how to extract the modreq from it.
13081 Updated all the source files to use this.
13083 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13084 because it is referenced by MemberLookup very often.
13086 2002-01-09 Ravi Pratap <ravi@ximian.com>
13088 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13089 TypeBuilder.GetCustomAttributes to retrieve what we need.
13091 Get rid of redundant default_member_attr_type as this is the same as
13092 default_member_type which already exists.
13094 * interface.cs, attribute.cs : Update accordingly.
13096 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13098 * typemanager.cs: Enable IndexerPropertyName again. It does not
13099 work for TYpeBuilders though. Ravi, can you please fix this?
13101 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13103 * expression.cs (Argument.Emit): Handle the case of ref objects
13104 being passed to ref functions;
13106 (ParameterReference.EmitLoad): Loads the content of the pointer
13107 without dereferencing.
13109 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13111 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13113 2002-01-08 Ravi Pratap <ravi@ximian.com>
13115 * class.cs (Indexer.DefineMethod): Incorporate the interface
13116 type in the name of the method if we are doing explicit interface
13119 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13121 (BetterConversion): Fix extremely trivial bug where we were referring to
13122 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13125 * ../errors/bug16.cs : Add although we have fixed it.
13127 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13129 * expression.cs (BaseIndexer): Begin implementation.
13131 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13133 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13134 production directly to remove a shift/reduce, and implement
13135 explicit interface implementation.
13137 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13138 after a floating point suffix.
13140 * expression.cs (DoNumericPromotions): Improved the conversion for
13141 uint/uint. If we have a constant, we avoid doing a typecast to a
13144 * class.cs (Indexer): Implement explicit interface implementation
13147 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13149 * class.cs: make the default instance constructor public and hidebysig.
13151 2001-01-03 Ravi Pratap <ravi@ximian.com>
13153 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13154 so we can call it from elsewhere.
13156 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13157 we emit it internally if the class has a defined indexer; otherwise the user
13158 emits it by decorating the class definition with the DefaultMemberAttribute.
13160 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13161 attribute is not used on a type which defines an indexer.
13163 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13164 character when we skip whitespace.
13166 * ../errors/cs0646.cs : Add.
13168 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13170 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13173 * makefile: Add practical target `mcs3.exe' which builds the third
13174 generation compiler.
13176 * expression.cs (New): Fix structures constructor calling.
13178 * class.cs (Property, Method, Indexer): Emit Final flag on the
13179 method if we are an interface implementation and we are not
13182 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13183 whether this property is referencing a `base' method.
13185 * expression.cs (Invocation.EmitCall): take an extra argument:
13186 is_base, this is used to determine whether the `call' or
13187 `callvirt' opcode should be used.
13190 * delegate.cs: update EmitCall.
13192 * class.cs (Method.Define): Set NewSlot for the cases where we are
13193 not implementing an interface method.
13195 (Property.Define): ditto.
13197 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13199 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13200 'r'. Allows mcs to parse itself fully.
13202 2002-01-02 Ravi Pratap <ravi@ximian.com>
13204 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13205 of the number of initializers that require the InitializeArray method.
13207 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13208 update the above field where necessary.
13210 (MakeByteBlob): Update accordingly.
13212 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13215 (EmitDynamicInitializers): Update in accordance with the new optimization.
13217 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13218 same OpCode applies.
13220 * cs-parser.jay : Fix some glaring errors I introduced.
13222 2002-01-01 Ravi Pratap <ravi@ximian.com>
13224 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13225 so that we can check for name clashes there too.
13227 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13228 for interface indexers.
13230 * interfaces.cs (Define): Emit the default member attribute.
13232 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13233 variable was being referred to while setting the value ;-)
13235 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13237 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13238 byte-by-byte information when we know the data is zero.
13240 Make the block always a multiple of 4, because
13241 DefineInitializedData has a bug.
13243 * assign.cs: Fix, we should assign from the temporary, not from
13246 * expression.cs (MakeByteBlob): Fix my incorrect code.
13248 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13250 * typemanager.cs (EnumToUnderlying): This function is used to get
13251 the underlying type from an enumeration, because it does not
13254 * constant.cs: Use the I4_S form for values between -128 and 127.
13256 * statement.cs (Block.LookupLabel): Looks up a label.
13257 (Block): Drop support for labeled blocks.
13259 (LabeledStatement): New kind of statement that represents a label
13262 (Goto): Finally implement this bad boy.
13264 * cs-parser.jay: Update to reflect new mechanism to implement
13267 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13269 * codegen.cs (EmitContext.This): a codegen property that keeps the
13270 a single instance of this instead of creating many different this
13273 * delegate.cs (Delegate.DoResolve): Update to use the property;
13275 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13277 * expression.cs (BaseAccess.DoResolve): Ditto.
13279 2001-12-29 Ravi Pratap <ravi@ximian.com>
13281 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13282 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13284 (InitCoreTypes): Update accordingly.
13286 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13287 so we can quickly store the state.
13289 (ApplyAttributes): Set the correct implementation flags
13290 for InternalCall methods.
13292 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13294 * expression.cs (EmitCall): if a method is not virtual, then do
13295 not use callvirt on it.
13297 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13298 user defined stuff) requires the use of stobj, which takes an
13299 address on the stack instead of an array and an index. So emit
13300 the Ldelema operation for it.
13302 (EmitStoreOpcode): Use stobj for valuetypes.
13304 (UnaryMutator.EmitCode): Use the right 1 value depending on
13305 whether we are dealing with int64/uint64, float or doubles.
13307 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13308 constructors that I implemented last night.
13310 (Constructor.IsDefault): Fix to work properly for static
13313 * cs-parser.jay (CheckDef): report method signature errors.
13314 Update error number 103 to be 132.
13316 * decl.cs: New AdditionResult enumeration value: MethodExists.
13317 Although we do this check for methods later on in the semantic
13318 analysis, catching repeated default constructors is so easy that
13319 we catch these here.
13321 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13324 (ParameterReference.EmitAssign, Emit): handle
13327 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13328 (ArrayAccess.EmitStoreOpcode): ditto.
13330 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13332 * expression.cs (MakeByteBlob): Complete all the missing types
13333 (uint, short, ushort, byte, sbyte)
13335 * class.cs: Only init instance field initializers on instance
13338 Rename `constructors' to instance_constructors.
13340 (TypeContainer.AddConstructor): Only add constructors to the list
13341 if it is not static.
13343 Make sure that we handle default_static_constructor independently
13344 everywhere where we handle instance_constructors
13346 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13348 * class.cs: Do not lookup or create a base initializer for a
13349 static constructor.
13351 (ConstructorInitializer.Resolve): use the proper type to lookup
13354 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13356 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13359 * decl.cs: CloseType is now an virtual method, the default
13360 implementation just closes this type.
13362 2001-12-28 Ravi Pratap <ravi@ximian.com>
13364 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13365 to PreserveSig by default. Also emit HideBySig on such methods.
13367 Basically, set the defaults to standard values.
13369 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13370 argument, if candidate is better, it can't be worse than the best !
13372 (Invocation): Re-write bits to differentiate between methods being
13373 applicable in their expanded form and their normal form - for params
13376 Get rid of use_standard everywhere as only standard conversions are allowed
13377 in overload resolution.
13379 More spec conformance.
13381 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13383 * driver.cs: Add --timestamp, to see where the compiler spends
13386 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13387 `this' in static code.
13389 (SimpleName.DoResolve): Implement in terms of a helper function
13390 that allows static-references to be passed upstream to
13393 (Expression.ResolveWithSimpleName): Resolve specially simple
13394 names when called by MemberAccess to implement the special
13397 (Expression.ImplicitReferenceConversion): Handle conversions from
13398 Null to reference types before others, as Null's type is
13401 * expression.cs (Invocation.EmitCall): Handle the special case of
13402 calling methods declared on a reference type from a ValueType
13403 (Base classes System.Object and System.Enum)
13405 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13406 the left hand side is a TypeExpr, not on every enumeration.
13408 (Binary.Resolve): If types are reference types, then do a cast to
13409 object on operators != and == of both arguments.
13411 * typemanager.cs (FindMembers): Extract instance and static
13412 members if requested.
13414 * interface.cs (PopulateProperty): Use void_type instead of null
13415 as the return type for the setter method.
13417 (PopulateIndexer): ditto.
13419 2001-12-27 Ravi Pratap <ravi@ximian.com>
13421 * support.cs (ReflectionParameters): Fix minor bug where we
13422 were examining the wrong parameter for the ParamArray attribute.
13424 Cope with requests for the type of the parameter at position
13425 greater than the params parameter's. We now return the element
13426 type of the params array as that makes more sense.
13428 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13429 accordingly as we no longer have to extract the element type
13432 (Invocation.OverloadResolve): Update.
13434 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13436 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13437 against IEnumerator, test whether the return value is a descendant
13438 of the IEnumerator interface.
13440 * class.cs (Indexer.Define): Use an auxiliary method to implement
13441 the other bits of the method definition. Begin support for
13442 explicit interface implementation.
13444 (Property.DefineMethod): Use TypeManager.void_type instead of null
13445 for an empty return value.
13447 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13449 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13450 dealing with a FieldExpr which is composed of a FieldBuilder, in
13451 the code path we did extract the constant, but we should have
13452 obtained the underlying value to be able to cast it (otherwise we
13453 end up in an infinite loop, this is what Ravi was running into).
13455 (ArrayCreation.UpdateIndices): Arrays might be empty.
13457 (MemberAccess.ResolveMemberAccess): Add support for section
13458 14.5.4.1 that deals with the special case of E.I when E is a type
13459 and something else, that I can be a reference to a static member.
13461 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13462 handle a particular array type to create byte blobs, it is just
13463 something we dont generate byteblobs for.
13465 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13468 * location.cs (Push): remove the key from the hashtable that we
13469 are about to add. This happens for empty files.
13471 * driver.cs: Dispose files after we have parsed them.
13473 (tokenize): new function that only runs the tokenizer on its
13474 input, for speed testing.
13476 2001-12-26 Ravi Pratap <ravi@ximian.com>
13478 * class.cs (Event.Define): Define the private field only if there
13479 are no accessors defined.
13481 * expression.cs (ResolveMemberAccess): If there is no associated
13482 field with the event, that means we have an event defined with its
13483 own accessors and we should flag error cs0070 since transforming
13484 ourselves into a field is not valid in that case.
13486 * ecore.cs (SimpleName.DoResolve): Same as above.
13488 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13489 and charset to sane values.
13491 2001-12-25 Ravi Pratap <ravi@ximian.com>
13493 * assign.cs (DoResolve): Perform check on events only if they
13494 are being accessed outside the declaring type.
13496 * cs-parser.jay (event_declarations): Update rules to correctly
13497 set the type of the implicit parameter etc.
13499 (add_accessor, remove_accessor): Set current local parameters.
13501 * expression.cs (Binary): For delegate addition and subtraction,
13502 cast the return value from the method into the appropriate delegate
13505 2001-12-24 Ravi Pratap <ravi@ximian.com>
13507 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13508 of these as the workaround is unnecessary.
13510 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13511 delegate data - none of that is needed at all.
13513 Re-write bits to extract the instance expression and the delegate method
13516 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13519 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13520 of attaching attributes instead of duplicating code everywhere.
13522 * everywhere : Update code to do attribute emission using the above method.
13524 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13526 * expression.cs (IsParamsMethodApplicable): if there are not
13527 parameters, return immediately.
13529 * ecore.cs: The 0 literal can be implicity converted to an enum
13532 (SimpleName.DoResolve): First lookup the type, then lookup the
13535 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13536 want to get its address. If the InstanceExpression is not
13537 addressable, store the result in a temporary variable, then get
13540 * codegen.cs: Only display 219 errors on warning level or above.
13542 * expression.cs (ArrayAccess): Make it implement the
13543 IMemoryLocation interface.
13545 (Binary.DoResolve): handle the operator == (object a, object b)
13546 and operator != (object a, object b) without incurring into a
13547 BoxedCast (because 5 != o should never be performed).
13549 Handle binary enumerator operators.
13551 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13552 value type, otherwise use Ldelem_ref.
13554 Use precomputed names;
13556 (AddressOf): Implement address of
13558 * cs-parser.jay (labeled_statement): Fix recursive block
13559 addition by reworking the production.
13561 * expression.cs (New.DoEmit): New has a special case:
13563 If we are dealing with a ValueType, we have a few
13564 situations to deal with:
13566 * The target of New is a ValueType variable, that is
13567 easy, we just pass this as the variable reference
13569 * The target of New is being passed as an argument,
13570 to a boxing operation or a function that takes a
13573 In this case, we need to create a temporary variable
13574 that is the argument of New.
13577 2001-12-23 Ravi Pratap <ravi@ximian.com>
13579 * rootcontext.cs (LookupType): Check that current_type is not null before
13580 going about looking at nested types.
13582 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
13583 not implement the IAssignMethod interface any more.
13585 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
13586 where we tranform them into FieldExprs if they are being resolved from within
13587 the declaring type.
13589 * ecore.cs (SimpleName.DoResolve): Do the same here.
13591 * assign.cs (DoResolve, Emit): Clean up code considerably.
13593 * ../errors/bug10.cs : Add.
13595 * ../errors/cs0070.cs : Add.
13597 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13599 * assign.cs : Get rid of EventIsLocal everywhere.
13601 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13603 * ecore.cs (ConvertIntLiteral): finished the implementation.
13605 * statement.cs (SwitchLabel): Convert the value we are using as a
13606 key before looking up the table.
13608 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13610 * codegen.cs (EmitTopBlock): Require a Location argument now.
13612 * cs-parser.jay (constructor_declarator): We need to setup
13613 current_local_parameters before we parse the
13614 opt_constructor_initializer, to allow the variables to be bound
13615 to the constructor arguments.
13617 * rootcontext.cs (LookupType): First lookup nested classes in our
13618 class and our parents before we go looking outside our class.
13620 * expression.cs (ConstantFold): Extract/debox the values at the
13623 * rootcontext.cs (EmitCode): Resolve the constants first before we
13624 resolve the types. This is not really needed, but it helps debugging.
13626 * statement.cs: report location.
13628 * cs-parser.jay: pass location to throw statement.
13630 * driver.cs: Small bug fix.
13632 * report.cs: Updated format to be 4-zero filled digits.
13634 2001-12-22 Ravi Pratap <ravi@ximian.com>
13636 * expression.cs (CheckIndices): Fix minor bug where the wrong
13637 variable was being referred to ;-)
13639 (DoEmit): Do not call EmitStaticInitializers when the
13640 underlying type is System.Object.
13642 2001-12-21 Ravi Pratap <ravi@ximian.com>
13644 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
13645 and do the usual workaround for SRE.
13647 * class.cs (MyEventBuilder.EventType): New member to get at the type
13648 of the event, quickly.
13650 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
13652 * assign.cs (Assign.DoResolve): Handle the case when the target
13653 is an EventExpr and perform the necessary checks.
13655 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
13658 (SimpleName.MemberStaticCheck): Include check for EventExpr.
13660 (EventExpr): Set the type in the constructor itself since we
13661 are meant to be born fully resolved.
13663 (EventExpr.Define): Revert code I wrote earlier.
13665 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
13666 instance expression is null. The instance expression is a This in that case
13667 or a null, depending on whether it is a static method or not.
13669 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
13670 refers to more than one method.
13672 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
13673 and accordingly flag errors.
13675 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13677 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
13679 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13681 * location.cs (ToString): Provide useful rutine.
13683 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13685 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
13686 objects, return the actual integral boxed.
13688 * statement.cs (SwitchLabel): define an ILLabel for each
13691 (Switch.CheckSwitch): If the value is a Literal, extract
13692 the underlying literal.
13694 Also in the unused hashtable we had, add the SwitchLabel so we can
13695 quickly look this value up.
13697 * constant.cs: Implement a bunch of new constants. Rewrite
13698 Literal based on this. Made changes everywhere to adapt to this.
13700 * expression.cs (Expression.MakeByteBlob): Optimize routine by
13701 dereferencing array only once, and also copes with enumrations.
13703 bytes are two bytes wide, not one.
13705 (Cast): Perform constant conversions.
13707 * ecore.cs (TryImplicitIntConversion): Return literals instead of
13708 wrappers to the literals here.
13710 * expression.cs (DoNumericPromotions): long literals can converted
13711 to ulong implicity (this is taken care of elsewhere, but I was
13712 missing this spot).
13714 * ecore.cs (Expression.Literalize): Make the return type Literal,
13715 to improve type checking.
13717 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
13719 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13721 * literal.cs: Revert code from ravi that checked the bounds. The
13722 bounds are sane by the definition of the type itself.
13724 * typemanager.cs: Fix implementation of ImplementsInterface. We
13725 need to actually look up in our parent hierarchy for interfaces
13728 * const.cs: Use the underlying type for enumerations
13730 * delegate.cs: Compute the basename for the delegate creation,
13731 that should fix the delegate test case, and restore the correct
13732 Type Lookup semantics in rootcontext
13734 * rootcontext.cs: Revert Ravi's last patch. The correct way of
13735 referencing a nested type with the Reflection API is using the "+"
13738 * cs-parser.jay: Do not require EOF token at the end.
13740 2001-12-20 Ravi Pratap <ravi@ximian.com>
13742 * rootcontext.cs (LookupType): Concatenate type names with
13743 a '.' instead of a '+' The test suite passes again.
13745 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
13746 field of the enumeration.
13748 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
13749 the case when the member is an EventExpr.
13751 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
13752 static has an associated instance expression.
13754 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
13756 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
13758 * class.cs (Event.Define): Register event and perform appropriate checks
13761 We define the Add and Remove methods even if the use provides none because
13762 in that case, we provide default implementations ourselves.
13764 Define a private field of the type of the event. This is done by the CSC compiler
13765 and we should be doing it too ;-)
13767 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
13768 More methods we use in code we generate.
13770 (multicast_delegate_type, delegate_type): Two separate types since the distinction
13773 (InitCoreTypes): Update accordingly for the above.
13775 * class.cs (Event.Emit): Generate code for default accessors that we provide
13777 (EmitDefaultMethod): Do the job in the above.
13779 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
13782 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13784 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
13785 builders even if we were missing one.
13787 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
13788 pass the Basename as our class name instead of the Name. The
13789 basename will be correctly composed for us.
13791 * parameter.cs (Paramters): Now takes a Location argument.
13793 * decl.cs (DeclSpace.LookupType): Removed convenience function and
13794 make all the code call directly LookupType in RootContext and take
13795 this chance to pass the Location information everywhere.
13797 * Everywhere: pass Location information.
13799 2001-12-19 Miguel de Icaza <miguel@ximian.com>
13801 * class.cs (Constructor.Define): Updated way of detecting the
13802 length of the parameters.
13804 (TypeContainer.DefineType): Use basename as the type name for
13807 (TypeContainer.Define): Do not recursively define types here, as
13808 definition is taken care in order by the RootContext.
13810 * tree.cs: Keep track of namespaces in a per-file basis.
13812 * parameter.cs (Parameter.ComputeSignature): Update to use
13815 (Parameters.GetSignature): ditto.
13817 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
13818 instead of a TypeContainer.
13820 (Interface.SemanticAnalysis): Use `this' instead of our parent to
13821 resolve names. Because we need to be resolve in our context, not
13824 * driver.cs: Implement response files.
13826 * class.cs (TypeContainer.DefineType): If we are defined, do not
13827 redefine ourselves.
13829 (Event.Emit): Emit the code for add/remove handlers.
13830 (Event.Define): Save the MethodBuilders for add/remove.
13832 * typemanager.cs: Use pair here too.
13834 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
13835 DictionaryEntry requires the first argument to be non-null.
13837 (enum_declaration): Compute full name for registering the
13840 (delegate_declaration): Instead of using
13841 formal_parameter_list, use opt_formal_parameter_list as the list
13844 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
13845 (EventParsing): New property that controls whether `add' and
13846 `remove' are returned as tokens or identifiers (for events);
13848 2001-12-19 Ravi Pratap <ravi@ximian.com>
13850 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
13851 use MyEventBuilder only and let it wrap the real builder for us.
13853 (MyEventBuilder): Revamp constructor etc.
13855 Implement all operations that we perform on EventBuilder in precisely the same
13858 (FindMembers): Update to use the EventBuilder member.
13860 (Event.Emit): Update accordingly.
13862 2001-12-18 Ravi Pratap <ravi@ximian.com>
13864 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
13865 by calling the appropriate methods.
13867 (GetCustomAttributes): Make stubs as they cannot possibly do anything
13870 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
13872 2001-12-17 Ravi Pratap <ravi@ximian.com>
13874 * delegate.cs (Delegate.Populate): Check that the return type
13875 and various parameters types are indeed accessible.
13877 * class.cs (Constructor.Define): Same here.
13879 (Field.Define): Ditto.
13881 (Event.Define): Ditto.
13883 (Operator.Define): Check that the underlying Method defined itself
13884 correctly - so it's MethodBuilder should not be null.
13886 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
13887 expression happens to be null.
13889 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
13890 members but as of now we don't seem to be able to do anything really useful with it.
13892 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
13893 not the EventBuilder.
13895 2001-12-18 Miguel de Icaza <miguel@ximian.com>
13897 * cs-tokenizer.cs: Add support for defines.
13898 Add support for #if, #elif, #else, #endif
13900 (eval_var): evaluates a variable.
13901 (eval): stubbed for evaluating functions.
13903 * cs-parser.jay: Pass the defines information
13905 * driver.cs: Add --define command line option.
13907 * decl.cs: Move MemberCore here.
13909 Make it the base class for DeclSpace. This allows us to catch and
13910 report 108 and 109 for everything now.
13912 * class.cs (TypeContainer.Define): Extract all the members
13913 before populating and emit the warning 108 (new keyword required
13914 to override) instead of having each member implement this.
13916 (MemberCore.Define): New abstract method, we will be using this in
13917 the warning reporting engine in Populate.
13919 (Operator.Define): Adjust to new MemberCore protocol.
13921 * const.cs (Const): This does not derive from Expression, it is a
13922 temporary object we use to create fields, it is a MemberCore.
13924 * class.cs (Method.Define): Allow the entry point to be in a
13927 * driver.cs: Rewrite the argument handler to clean it up a bit.
13929 * rootcontext.cs: Made it just an auxiliary namespace feature by
13930 making everything static.
13932 * driver.cs: Adapt code to use RootContext type name instead of
13935 * delegate.cs: Remove RootContext argument.
13937 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
13940 * class.cs (Event.Define): The lookup can fail.
13942 * cs-tokenizer.cs: Begin implementation of pre-procesor.
13944 * expression.cs: Resolve the this instance before invoking the code.
13946 2001-12-17 Miguel de Icaza <miguel@ximian.com>
13948 * cs-parser.jay: Add a production in element_access that allows
13949 the thing to become a "type" reference. This way we can parse
13950 things like "(string [])" as a type.
13952 Note that this still does not handle the more complex rules of
13956 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
13958 * ecore.cs: (CopyNewMethods): new utility function used to
13959 assemble the list of methods from running FindMembers.
13961 (MemberLookup): Rework FindMembers so that
13963 2001-12-16 Miguel de Icaza <miguel@ximian.com>
13965 * class.cs (TypeContainer): Remove Delegates who fail to be
13968 * delegate.cs (Populate): Verify that we dont get null return
13969 values. TODO: Check for AsAccessible.
13971 * cs-parser.jay: Use basename to emit error 574 (destructor should
13972 have the same name as container class), not the full name.
13974 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
13975 possible representation.
13977 Also implements integer type suffixes U and L.
13979 2001-12-15 Miguel de Icaza <miguel@ximian.com>
13981 * expression.cs (ArrayCreation.DoResolve): We need to do the
13982 argument resolution *always*.
13984 * decl.cs: Make this hold the namespace. Hold the root context as
13986 (LookupType): Move here.
13988 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
13990 * location.cs (Row, Name): Fixed the code, it was always returning
13991 references to the first file.
13993 * interface.cs: Register properties defined through interfaces.
13995 * driver.cs: Add support for globbing on the command line
13997 * class.cs (Field): Make it derive from MemberCore as well.
14000 2001-12-15 Ravi Pratap <ravi@ximian.com>
14002 * class.cs (Event::Define): Check that the type of the event is a delegate
14003 type else flag error #66.
14005 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14008 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14009 values of EntryPoint, CharSet etc etc.
14011 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14013 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14014 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14015 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14016 which needs this to do its work.
14018 * ../errors/cs0066.cs : Add.
14020 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14022 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14025 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14026 clears out the parameters field.
14027 (MemberSignatureCompare): Cleanup
14029 (MemberCore): New base class used to share code between MethodCore
14032 (RegisterRequiredImplementations) BindingFlags.Public requires
14033 either BindingFlags.Instace or Static. Use instance here.
14035 (Property): Refactored code to cope better with the full spec.
14037 * parameter.cs (GetParameterInfo): Return an empty array instead
14040 * class.cs (Property): Abstract or extern properties have no bodies.
14042 * parameter.cs (GetParameterInfo): return a zero-sized array.
14044 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14045 method modifier validation to the typecontainer so we can reuse
14046 this on properties.
14048 (MethodCore.ParameterTypes): return an empty sized array of types.
14050 (Property.Define): Test property modifier validity.
14052 Add tests for sealed/override too.
14054 (Method.Emit): abstract or extern methods have no bodies.
14056 2001-12-14 Ravi Pratap <ravi@ximian.com>
14058 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14061 (Method::Define, ::Emit): Modify accordingly.
14063 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14065 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14067 * makefile: Pass in /unsafe.
14069 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14071 * class.cs (MakeKey): Kill routine.
14073 * class.cs (TypeContainer.Define): Correctly define explicit
14074 method implementations (they require the full interface name plus
14077 * typemanager.cs: Deply the PtrHashtable here and stop using the
14078 lame keys. Things work so much better.
14080 This of course broke everyone who depended on `RegisterMethod' to
14081 do the `test for existance' test. This has to be done elsewhere.
14083 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14084 the object stupid Equals method (because, that like fails all over
14085 the place). We still do not use it.
14087 * class.cs (TypeContainer.SetRequiredInterface,
14088 TypeContainer.RequireMethods): Killed these two routines and moved
14089 all the functionality to RegisterRequiredImplementations.
14091 (TypeContainer.RegisterRequiredImplementations): This routine now
14092 registers all the implementations required in an array for the
14093 interfaces and abstract methods. We use an array of structures
14094 which can be computed ahead of time to reduce memory usage and we
14095 also assume that lookups are cheap as most classes will not
14096 implement too many interfaces.
14098 We also avoid creating too many MethodSignatures.
14100 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14101 clear the "pending" bit if we find that there are problems with
14104 (TypeContainer.VerifyPendingMethods): Update to report errors of
14105 methods that look like implementations but are not.
14107 (TypeContainer.Define): Add support for explicit interface method
14110 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14112 * typemanager.cs: Keep track of the parameters here instead of
14113 being a feature of the TypeContainer.
14115 * class.cs: Drop the registration of parameters here, as
14116 InterfaceMethods are also interface declarations.
14118 * delegate.cs: Register methods with the TypeManager not only with
14119 the TypeContainer. This code was buggy.
14121 * interface.cs: Full registation here.
14123 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14125 * expression.cs: Remove reducer for binary expressions, it can not
14128 * const.cs: Put here the code that used to go into constant.cs
14130 * constant.cs: Put here the code for constants, this is a new base
14131 class for Literals.
14133 * literal.cs: Make Literal derive from Constant.
14135 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14137 * statement.cs (Return.Emit): Report error 157 if the user
14138 attempts to return from a finally block.
14140 (Return.Emit): Instead of emitting a return, jump to the end of
14143 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14144 LocalBuilder to store the result of the function. ReturnLabel is
14145 the target where we jump.
14148 2001-12-09 Radek Doulik <rodo@ximian.com>
14150 * cs-parser.jay: remember alias in current namespace
14152 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14155 * class.cs (LookupAlias): lookup alias in my_namespace
14157 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14159 (LookupAlias): lookup alias in this and if needed in parent
14162 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14166 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14167 making things static. I need this to avoid passing the
14168 TypeContainer when calling ParameterType.
14170 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14171 that did string manipulation to compute the type and then call
14172 GetType. Use Parameter.ParameterType instead.
14174 * cs-tokenizer.cs: Consume the suffix for floating values.
14176 * expression.cs (ParameterReference): figure out whether this is a
14177 reference parameter or not. Kill an extra variable by computing
14178 the arg_idx during emission.
14180 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14181 function that returns whether a parameter is an out/ref value or not.
14183 (Parameter.ParameterType): The type of the parameter (base,
14184 without ref/out applied).
14186 (Parameter.Resolve): Perform resolution here.
14187 (Parameter.ExternalType): The full type (with ref/out applied).
14189 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14190 support for expressions on the using statement.
14192 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14194 * statement.cs (Using.EmitLocalVariableDecls): Split the
14195 localvariable handling of the using statement.
14197 (Block.EmitMeta): Keep track of variable count across blocks. We
14198 were reusing slots on separate branches of blocks.
14200 (Try.Emit): Emit the general code block, we were not emitting it.
14202 Check the type of the declaration to be an IDisposable or
14203 something that can be implicity converted to it.
14205 Emit conversions if required.
14207 * ecore.cs (EmptyExpression): New utility class.
14208 (Expression.ImplicitConversionExists): New utility function.
14210 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14212 * statement.cs (Using): Implement.
14214 * expression.cs (LocalVariableReference): Support read only variables.
14216 * statement.cs: Remove the explicit emit for the Leave opcode.
14217 (VariableInfo): Add a readonly field.
14219 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14221 * ecore.cs (ConvCast): new class used to encapsulate the various
14222 explicit integer conversions that works in both checked and
14223 unchecked contexts.
14225 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14226 properly generate the overflow opcodes.
14228 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14230 * statement.cs: The correct type for the EmptyExpression is the
14231 element_type, not the variable type. Ravi pointed this out.
14233 2001-12-04 Ravi Pratap <ravi@ximian.com>
14235 * class.cs (Method::Define): Handle PInvoke methods specially
14236 by using DefinePInvokeMethod instead of the usual one.
14238 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14239 above to do the task of extracting information and defining the method.
14241 2001-12-04 Ravi Pratap <ravi@ximian.com>
14243 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14244 of the condition for string type.
14246 (Emit): Move that here.
14248 (ArrayCreation::CheckIndices): Keep string literals in their expression
14251 (EmitDynamicInitializers): Handle strings appropriately.
14253 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14255 * codegen.cs (EmitContext): Replace multiple variables with a
14256 single pointer to the current Switch statement.
14258 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14261 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14265 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14268 (Foreach.Emit): Foreach on arrays was not setting
14269 up the loop variables (for break/continue).
14271 (GotoCase): Semi-implented.
14273 2001-12-03 Ravi Pratap <ravi@ximian.com>
14275 * attribute.cs (CheckAttribute): Handle system attributes by using
14276 Attribute.GetAttributes to examine information we need.
14278 (GetValidPlaces): Same here.
14280 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14282 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14284 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14286 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14288 (Method::Emit): Handle the case when we are a PInvoke method.
14290 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14292 * expression.cs: Use ResolveWithSimpleName on compound names.
14294 2001-12-02 Ravi Pratap <ravi@ximian.com>
14296 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14297 before trying to reduce it.
14299 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14301 * constant.cs (LookupConstantValue): Implement.
14303 (EmitConstant): Use the above in emitting the constant.
14305 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14306 that are user-defined by doing a LookupConstantValue on them.
14308 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14311 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14313 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14315 (BaseAccess.DoResolve): Implement.
14317 (MemberAccess.DoResolve): Split this routine into a
14318 ResolveMemberAccess routine that can be used independently
14320 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14322 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14323 As that share bits of the implementation. Is returns a boolean,
14324 while As returns the Type that is being probed.
14326 2001-12-01 Ravi Pratap <ravi@ximian.com>
14328 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14329 instead of a Literal - much easier.
14331 (EnumInTransit): Remove - utterly useless :-)
14333 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14335 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14337 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14338 chain when we have no associated expression.
14340 2001-11-30 Ravi Pratap <ravi@ximian.com>
14342 * constant.cs (Define): Use Location while reporting the errror.
14344 Also emit a warning when 'new' is used and there is no inherited
14347 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14350 (LookupEnumValue): Implement to lookup an enum member's value and define it
14353 (Populate): Re-write accordingly to use the above routine.
14355 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14357 * expression.cs (This): Fix prototype for DoResolveLValue to
14358 override the base class DoResolveLValue.
14360 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14363 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14364 (we need to load the address of the field here). This fixes
14367 (FieldExpr.DoResolveLValue): Call the DoResolve
14368 function to initialize the Instance expression.
14370 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14371 correctly the GetEnumerator operation on a value type.
14373 * cs-parser.jay: Add more simple parsing error catches.
14375 * statement.cs (Switch): Add support for string switches.
14376 Handle null specially.
14378 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14380 2001-11-28 Ravi Pratap <ravi@ximian.com>
14382 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14384 (declare_local_constant): New helper function.
14386 * statement.cs (AddConstant): Keep a separate record of constants
14388 (IsConstant): Implement to determine if a variable is a constant.
14390 (GetConstantExpression): Implement.
14392 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14394 * statement.cs (IsVariableDefined): Re-write.
14396 2001-11-27 Ravi Pratap <ravi@ximian.com>
14398 * class.cs (TypeContainer::FindMembers): Look for constants
14399 in the case when we are looking for MemberTypes.Field
14401 * expression.cs (MemberAccess::DoResolve): Check that in the
14402 case we are a FieldExpr and a Literal, we are not being accessed
14403 by an instance reference.
14405 * cs-parser.jay (local_constant_declaration): Implement.
14407 (declaration_statement): Implement for constant declarations.
14409 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14411 * statement.cs (Switch): Catch double defaults.
14413 (Switch): More work on the switch() statement
14414 implementation. It works for integral values now, need to finish
14418 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14420 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14421 integer literals into other integer literals. To be used by
14424 2001-11-24 Ravi Pratap <ravi@ximian.com>
14426 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14429 (EmitDynamicInitializers): Cope with the above since we extract data
14430 directly from ArrayData now.
14432 (ExpectInitializers): Keep track of whether initializers are mandatory
14435 (Bounds): Make it a hashtable to prevent the same dimension being
14436 recorded for every element in that dimension.
14438 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14441 Also fix bug which was causing the indices to be emitted in the reverse
14444 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14446 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14447 unfinished. They do not work, because the underlying code is
14450 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14452 * cs-parser.jay: Remove bogus fixme.
14454 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14455 on Switch statement.
14457 2001-11-23 Ravi Pratap <ravi@ximian.com>
14459 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14462 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14463 parameter. Apparently, any expression is allowed.
14465 (ValidateInitializers): Update accordingly.
14467 (CheckIndices): Fix some tricky bugs thanks to recursion.
14469 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14470 I was being completely brain-dead.
14472 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14473 and re-write acordingly.
14475 (DelegateInvocation): Re-write accordingly.
14477 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14479 (MakeByteBlob): Handle types more correctly.
14481 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14482 initialization from expressions but it is incomplete because I am a complete
14485 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14487 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14488 on If. Basically, we have to return `true' (ie, we do return to
14489 our caller) only if both branches of the if return.
14491 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14492 short-circuit operators, handle them as short circuit operators.
14494 (Cast.DoResolve): Resolve type.
14495 (Cast.Cast): Take an expression as the target type.
14497 * cs-parser.jay (cast_expression): Remove old hack that only
14498 allowed a limited set of types to be handled. Now we take a
14499 unary_expression and we resolve to a type during semantic
14502 Use the grammar productions from Rhys to handle casts (this is
14503 not complete like Rhys syntax yet, we fail to handle that corner
14504 case that C# has regarding (-x), but we will get there.
14506 2001-11-22 Ravi Pratap <ravi@ximian.com>
14508 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14509 field which is an array type.
14511 * cs-parser.jay (declare_local_variables): Support array initialization too.
14513 * typemanager.cs (MakeKey): Implement.
14515 (everywhere): Use the above appropriately.
14517 * cs-parser.jay (for_statement): Update for array initialization while
14518 declaring variables.
14520 * ecore.cs : The error message was correct, it's the variable's names that
14521 were misleading ;-) Make the code more readable.
14523 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14524 the correct type etc.
14526 (ConvertExplicit): Handle Enum types by examining the underlying type.
14528 2001-11-21 Ravi Pratap <ravi@ximian.com>
14530 * parameter.cs (GetCallingConvention): Always return
14531 CallingConventions.Standard for now.
14533 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14535 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14536 and `r' after calling DoNumericPromotions.
14538 * ecore.cs: Fix error message (the types were in the wrong order).
14540 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14541 BindingFlags.Instance as well
14543 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14544 implicit int literal conversion in an empty cast so that we
14545 propagate the right type upstream.
14547 (UnboxCast): new class used to unbox value types.
14548 (Expression.ConvertExplicit): Add explicit type conversions done
14551 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14552 the target type before applying the implicit LongLiterals to ULong
14555 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14557 * cs-parser.jay (for_statement): Reworked the way For works: now
14558 we declare manually any variables that are introduced in
14559 for_initializer to solve the problem of having out-of-band code
14560 emition (that is what got for broken).
14562 (declaration_statement): Perform the actual variable declaration
14563 that used to be done in local_variable_declaration here.
14565 (local_variable_declaration): Do not declare anything, just pass
14566 the information on a DictionaryEntry
14568 2001-11-20 Ravi Pratap <ravi@ximian.com>
14570 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14571 re-write of the logic to now make it recursive.
14573 (UpdateIndices): Re-write accordingly.
14575 Store element data in a separate ArrayData list in the above methods.
14577 (MakeByteBlob): Implement to dump the array data into a byte array.
14579 2001-11-19 Ravi Pratap <ravi@ximian.com>
14581 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
14584 * constant.cs (Define): Implement.
14586 (EmitConstant): Re-write fully.
14588 Pass in location info.
14590 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
14593 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
14594 DictionaryEntry since we need location info too.
14596 (constant_declaration): Update accordingly.
14598 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14599 code into another method : UpdateIndices.
14601 2001-11-18 Ravi Pratap <ravi@ximian.com>
14603 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14604 some type checking etc.
14606 2001-11-17 Ravi Pratap <ravi@ximian.com>
14608 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14609 bits to provide dimension info if the user skips doing that.
14611 Update second constructor to store the rank correctly.
14613 2001-11-16 Ravi Pratap <ravi@ximian.com>
14615 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14616 and try to implement.
14618 * ../errors/cs0150.cs : Add.
14620 * ../errors/cs0178.cs : Add.
14622 2001-11-16 Miguel de Icaza <miguel@ximian.com>
14624 * statement.cs: Implement foreach on multi-dimensional arrays.
14626 * parameter.cs (Parameters.GetParameterByName): Also lookup the
14627 name of the params argument.
14629 * expression.cs: Use EmitStoreOpcode to get the right opcode while
14630 initializing the array.
14632 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
14633 we can use this elsewhere.
14635 * statement.cs: Finish implementation of foreach for single
14638 * cs-parser.jay: Use an out-of-band stack to pass information
14639 around, I wonder why I need this.
14641 foreach_block: Make the new foreach_block the current_block.
14643 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
14644 function used to return a static Parameters structure. Used for
14645 empty parameters, as those are created very frequently.
14647 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
14649 2001-11-15 Ravi Pratap <ravi@ximian.com>
14651 * interface.cs : Default modifier is private, not public. The
14652 make verify test passes again.
14654 2001-11-15 Ravi Pratap <ravi@ximian.com>
14656 * support.cs (ReflectionParameters): Fix logic to determine
14657 whether the last parameter is a params one. Test 9 passes again.
14659 * delegate.cs (Populate): Register the builders we define with
14660 RegisterParameterForBuilder. Test 19 passes again.
14662 * cs-parser.jay (property_declaration): Reference $6 instead
14663 of $$ to get at the location.
14665 (indexer_declaration): Similar stuff.
14667 (attribute): Ditto.
14669 * class.cs (Property): Register parameters for the Get and Set methods
14670 if they exist. Test 23 passes again.
14672 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
14673 call to EmitArguments as we are sure there aren't any params arguments.
14674 Test 32 passes again.
14676 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
14677 IndexOutOfRangeException.
14679 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
14680 Test 33 now passes again.
14682 2001-11-15 Miguel de Icaza <miguel@ximian.com>
14684 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
14685 broke a bunch of things. Will have to come up with a better way
14686 of tracking locations.
14688 * statement.cs: Implemented foreach for single dimension arrays.
14690 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14692 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
14693 an error. This removes the lookup from the critical path.
14695 * cs-parser.jay: Removed use of temporary_loc, which is completely
14698 2001-11-14 Miguel de Icaza <miguel@ximian.com>
14700 * support.cs (ReflectionParameters.ParameterModifier): Report
14701 whether the argument is a PARAMS argument or not.
14703 * class.cs: Set the attribute `ParamArrayAttribute' on the
14704 parameter argument.
14706 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
14707 and cons_param_array_attribute (ConstructorInfo for
14708 ParamArrayAttribute).,
14710 * codegen.cs: Emit the return using the `Return' statement, that
14711 way we can report the error correctly for missing return values.
14713 * class.cs (Method.Emit): Clean up.
14715 * expression.cs (Argument.Resolve): Take another argument: the
14716 location where this argument is used. Notice that this is not
14717 part of the "Argument" class as to reduce the size of the
14718 structure (we know the approximate location anyways).
14720 Test if the argument is a variable-reference, if not, then
14721 complain with a 206.
14723 (Argument.Emit): Emit addresses of variables.
14725 (Argument.FullDesc): Simplify.
14727 (Invocation.DoResolve): Update for Argument.Resolve.
14729 (ElementAccess.DoResolve): ditto.
14731 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
14732 method should be virtual, as this method is always virtual.
14734 (NewDelegate.DoResolve): Update for Argument.Resolve.
14736 * class.cs (ConstructorInitializer.DoResolve): ditto.
14738 * attribute.cs (Attribute.Resolve): ditto.
14740 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14742 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
14744 * expression.cs (ParameterReference): Drop IStackStorage and implement
14745 IAssignMethod instead.
14747 (LocalVariableReference): ditto.
14749 * ecore.cs (FieldExpr): Drop IStackStorage and implement
14750 IAssignMethod instead.
14752 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14754 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
14755 enumerations that are used in heavily used structures derive from
14756 byte in a laughable and pathetic attempt to reduce memory usage.
14757 This is the kind of pre-optimzations that you should not do at
14758 home without adult supervision.
14760 * expression.cs (UnaryMutator): New class, used to handle ++ and
14761 -- separatedly from the other unary operators. Cleans up the
14762 code, and kills the ExpressionStatement dependency in Unary.
14764 (Unary): Removed `method' and `Arguments' from this class, making
14765 it smaller, and moving it all to SimpleCall, so I can reuse this
14766 code in other locations and avoid creating a lot of transient data
14767 strucutres when not required.
14769 * cs-parser.jay: Adjust for new changes.
14771 2001-11-11 Miguel de Icaza <miguel@ximian.com>
14773 * enum.cs (Enum.Populate): If there is a failure during
14776 * cs-parser.jay (opt_enum_base): we used to catch type errors
14777 here, but this is really incorrect. The type error should be
14778 catched during semantic analysis.
14780 2001-12-11 Ravi Pratap <ravi@ximian.com>
14782 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
14783 current_local_parameters as expected since I, in my stupidity, had forgotten
14786 * attribute.cs (GetValidPlaces): Fix stupid bug.
14788 * class.cs (Method::Emit): Perform check on applicability of attributes.
14790 (Constructor::Emit): Ditto.
14792 (Field::Emit): Ditto.
14794 (Field.Location): Store location information.
14796 (Property, Event, Indexer, Operator): Ditto.
14798 * cs-parser.jay (field_declaration): Pass in location for each field.
14800 * ../errors/cs0592.cs : Add.
14802 2001-11-12 Ravi Pratap <ravi@ximian.com>
14804 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
14806 (InitCoreTypes): Update accordingly.
14808 (RegisterAttrType, LookupAttr): Implement.
14810 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
14811 info about the same.
14813 (Resolve): Update to populate the above as necessary.
14815 (Error592): Helper.
14817 (GetValidPlaces): Helper to the above.
14819 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
14821 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
14823 2001-11-12 Ravi Pratap <ravi@ximian.com>
14825 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
14827 * ../errors/cs0617.cs : Add.
14829 2001-11-11 Ravi Pratap <ravi@ximian.com>
14831 * enum.cs (Emit): Rename to Populate to be more consistent with what
14832 we expect it to do and when exactly it is called.
14834 * class.cs, rootcontext.cs : Update accordingly.
14836 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
14837 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
14839 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
14841 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
14842 of a fieldinfo using the above, when dealing with a FieldBuilder.
14844 2001-11-10 Ravi Pratap <ravi@ximian.com>
14846 * ../errors/cs0031.cs : Add.
14848 * ../errors/cs1008.cs : Add.
14850 * ../errrors/cs0543.cs : Add.
14852 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
14855 (FindMembers): Implement.
14857 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
14858 enums and delegates too.
14860 (enum_types): Rename to builder_to_enum.
14862 (delegate_types): Rename to builder_to_delegate.
14864 * delegate.cs (FindMembers): Implement.
14866 2001-11-09 Ravi Pratap <ravi@ximian.com>
14868 * typemanager.cs (IsEnumType): Implement.
14870 * enum.cs (Emit): Re-write parts to account for the underlying type
14871 better and perform checking etc.
14873 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
14874 of the underlying type.
14876 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
14879 * enum.cs (error31): Helper to report error #31.
14881 * cs-parser.jay (enum_declaration): Store location of each member too.
14883 * enum.cs (member_to_location): New hashtable.
14885 (AddEnumMember): Update location hashtable.
14887 (Emit): Use the location of each member while reporting errors.
14889 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14891 * cs-parser.jay: A for_initializer if is a
14892 local_variable_declaration really ammount to have an implicit
14893 block with the variable declaration and no initializer for for.
14895 * statement.cs (For.Emit): Cope with null initializers.
14897 This fixes the infinite loop on for initializers.
14899 2001-11-08 Miguel de Icaza <miguel@ximian.com>
14901 * enum.cs: More cleanup.
14903 * ecore.cs: Remove dead code.
14905 * class.cs (Property.Emit): More simplification.
14906 (Event.Emit): ditto.
14908 Reworked to have less levels of indentation.
14910 2001-11-08 Ravi Pratap <ravi@ximian.com>
14912 * class.cs (Property): Emit attributes.
14922 * enum.cs (Emit): Ditto.
14924 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
14927 * class.cs (Field, Event, etc.): Move attribute generation into the
14928 Emit method everywhere.
14930 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
14931 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
14932 as we had no way of defining nested enums !
14934 * rootcontext.cs : Adjust code accordingly.
14936 * typemanager.cs (AddEnumType): To keep track of enum types separately.
14938 2001-11-07 Ravi Pratap <ravi@ximian.com>
14940 * expression.cs (EvalConstantExpression): Move into ecore.cs
14942 * enum.cs (Enum): Rename some members and make them public and readonly
14943 according to our convention.
14945 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
14948 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
14950 (Enum::Emit): Write a simple version for now which doesn't try to compute
14951 expressions. I shall modify this to be more robust in just a while.
14953 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
14955 (TypeContainer::CloseType): Create the Enum types too.
14957 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
14959 * expression.cs (EvalConstantExpression): Get rid of completely.
14961 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
14962 user-defined values and other cases.
14964 (IsValidEnumLiteral): Helper function.
14966 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
14967 out there in the case we had a literal FieldExpr.
14969 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
14971 (Literalize): Revamp a bit to take two arguments.
14973 (EnumLiteral): New class which derives from Literal to wrap enum literals.
14975 2001-11-06 Ravi Pratap <ravi@ximian.com>
14977 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
14979 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
14981 (Resolve): Use the above to ensure we have proper initializers.
14983 2001-11-05 Ravi Pratap <ravi@ximian.com>
14985 * expression.cs (Expression::EvalConstantExpression): New method to
14986 evaluate constant expressions.
14988 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
14990 2001-11-07 Miguel de Icaza <miguel@ximian.com>
14992 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
14995 (Binary.ResolveOperator): Handle operator != (object a, object b)
14996 and operator == (object a, object b);
14998 (Binary.DoNumericPromotions): Indicate whether the numeric
14999 promotion was possible.
15001 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15004 Made the ArrayAccess implement interface IAssignMethod instead of
15005 IStackStore as the order in which arguments are passed reflects
15008 * assign.cs: Instead of using expr.ExprClass to select the way of
15009 assinging, probe for the IStackStore/IAssignMethod interfaces.
15011 * typemanager.cs: Load InitializeArray definition.
15013 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15014 static data that can be used to initialize arrays.
15016 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15018 * expression.cs: Handle operator== and operator!= for booleans.
15020 (Conditioal.Reduce): Implement reducer for the ?: operator.
15022 (Conditional.Resolve): Implement dead code elimination.
15024 (Binary.Resolve): Catch string literals and return a new
15025 concatenated string.
15027 (Unary.Reduce): Implement reduction of unary expressions.
15029 * ecore.cs: Split out the expression core handling here.
15031 (Expression.Reduce): New method used to perform constant folding
15032 and CSE. This is needed to support constant-expressions.
15034 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15035 targets, and optimize for !x.
15037 2001-11-04 Ravi Pratap <ravi@ximian.com>
15039 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15040 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15041 set custom atttributes.
15043 * literal.cs (Literal::GetValue): New abstract method to return the actual
15044 value of the literal, cast as an object.
15046 (*Literal): Implement GetValue method.
15048 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15049 expressions to the arraylist but objects of type Argument.
15051 * class.cs (TypeContainer::Emit): Emit our attributes too.
15053 (Method::Emit, Constructor::Emit): Ditto.
15055 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15056 to be ignoring earlier.
15058 2001-11-03 Ravi Pratap <ravi@ximian.com>
15060 * attribute.cs (AttributeSection::Define): Implement to do the business
15061 of constructing a CustomAttributeBuilder.
15063 (Attribute): New trivial class. Increases readability of code.
15065 * cs-parser.jay : Update accordingly.
15067 (positional_argument_list, named_argument_list, named_argument): New rules
15069 (attribute_arguments): Use the above so that we are more correct.
15071 2001-11-02 Ravi Pratap <ravi@ximian.com>
15073 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15074 to perform all checks for a method with a params parameter.
15076 (Invocation::OverloadResolve): Update to use the above method and therefore
15077 cope correctly with params method invocations.
15079 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15082 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15083 constructors in our parent too because we can't afford to miss out on
15086 * attribute.cs (AttributeSection): New name for the class Attribute
15088 Other trivial changes to improve readability.
15090 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15091 use the new class names.
15093 2001-11-01 Ravi Pratap <ravi@ximian.com>
15095 * class.cs (Method::Define): Complete definition for params types too
15097 (Indexer::Define): Ditto.
15099 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15100 Cope everywhere with a request for info about the array parameter.
15102 2001-11-01 Ravi Pratap <ravi@ximian.com>
15104 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15106 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15107 local_variable_type to extract the string corresponding to the type.
15109 (local_variable_type): Fixup the action to use the new helper method.
15111 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15114 * expression.cs : Clean out code which uses the above.
15116 2001-10-31 Ravi Pratap <ravi@ximian.com>
15118 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15119 and bale out if necessary by returning a false.
15121 (RegisterProperty): Ditto.
15123 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15124 and print out appropriate error messages.
15126 * interface.cs (everywhere): Ditto.
15128 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15129 location to constructor.
15131 * class.cs (Property, Event, Indexer): Update accordingly.
15133 * ../errors/cs111.cs : Added.
15135 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15136 of a method, as laid down by the spec.
15138 (Invocation::OverloadResolve): Use the above method.
15140 2001-10-31 Ravi Pratap <ravi@ximian.com>
15142 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15143 now take a TypeContainer and a Parameters object.
15145 (ParameterData): Modify return type of ParameterModifier method to be
15146 Parameter.Modifier and not a string.
15148 (ReflectionParameters, InternalParameters): Update accordingly.
15150 * expression.cs (Argument::GetParameterModifier): Same here.
15152 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15153 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15154 symbol in it at all so maybe this is only for now.
15156 2001-10-30 Ravi Pratap <ravi@ximian.com>
15158 * support.cs (InternalParameters): Constructor now takes an extra argument
15159 which is the actual Parameters class.
15161 (ParameterDesc): Update to provide info on ref/out modifiers.
15163 * class.cs (everywhere): Update call to InternalParameters to pass in
15164 the second argument too.
15166 * support.cs (ParameterData): Add ParameterModifier, which is a method
15167 to return the modifier info [ref/out etc]
15169 (InternalParameters, ReflectionParameters): Implement the above.
15171 * expression.cs (Argument::ParameterModifier): Similar function to return
15172 info about the argument's modifiers.
15174 (Invocation::OverloadResolve): Update to take into account matching modifiers
15177 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15178 a new SetFormalParameters object which we pass to InternalParameters.
15180 2001-10-30 Ravi Pratap <ravi@ximian.com>
15182 * expression.cs (NewArray): Merge into the ArrayCreation class.
15184 2001-10-29 Ravi Pratap <ravi@ximian.com>
15186 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15187 NewUserdefinedArray into one as there wasn't much of a use in having
15190 * expression.cs (Argument): Change field's name to ArgType from Type.
15192 (Type): New readonly property which returns the proper type, taking into
15193 account ref/out modifiers.
15195 (everywhere): Adjust code accordingly for the above.
15197 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15198 whether we are emitting for a ref or out parameter.
15200 * expression.cs (Argument::Emit): Use the above field to set the state.
15202 (LocalVariableReference::Emit): Update to honour the flag and emit the
15205 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15207 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15209 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15211 (ReflectionParameters, InternalParameters): Implement the above method.
15213 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15216 (Invocation::FullMethodDesc): Ditto.
15218 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15220 * cs-parser.jay: Add extra production for the second form of array
15223 * expression.cs (ArrayCreation): Update to reflect the above
15226 * Small changes to prepare for Array initialization.
15228 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15230 * typemanager.cs (ImplementsInterface): interface might be null;
15231 Deal with this problem;
15233 Also, we do store negative hits on the cache (null values), so use
15234 this instead of calling t.GetInterfaces on the type everytime.
15236 2001-10-28 Ravi Pratap <ravi@ximian.com>
15238 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15240 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15241 split functionality out into different classes.
15243 (New::FormArrayType): Move into NewBuiltinArray.
15245 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15248 (NewBuiltinArray): New class to handle creation of built-in arrays.
15250 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15251 account creation of one-dimensional arrays.
15253 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15255 (NewUserdefinedArray::DoResolve): Implement.
15257 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15259 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15260 we maintain inside the TypeManager. This is necessary to perform lookups on the
15263 (LookupType): Update to perform GetType on the module builders too.
15265 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15267 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15269 2001-10-23 Ravi Pratap <ravi@ximian.com>
15271 * expression.cs (New::DoResolve): Implement guts of array creation.
15273 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15275 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15277 * expression.cs: Fix bug I introduced lsat night that broke
15280 (Expression.Resolve): Report a 246 error (can not resolve name)
15281 if we find a SimpleName in the stream.
15283 (Expression.ResolveLValue): Ditto.
15285 (Expression.ResolveWithSimpleName): This function is a variant of
15286 ResolveName, this one allows SimpleNames to be returned without a
15287 warning. The only consumer of SimpleNames is MemberAccess
15289 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15291 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15292 might arrive here. I have my doubts that this is correct.
15294 * statement.cs (Lock): Implement lock statement.
15296 * cs-parser.jay: Small fixes to support `lock' and `using'
15298 * cs-tokenizer.cs: Remove extra space
15300 * driver.cs: New flag --checked, allows to turn on integer math
15303 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15304 Threading.Monitor.Exit
15306 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15308 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15309 Expression Class to be IndexerAccess.
15311 Notice that Indexer::DoResolve sets the eclass to Value.
15313 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15315 * class.cs (TypeContainer::Emit): Emit code for indexers.
15317 * assign.cs (IAssignMethod): New interface implemented by Indexers
15318 and Properties for handling assignment.
15320 (Assign::Emit): Simplify and reuse code.
15322 * expression.cs (IndexerAccess, PropertyExpr): Implement
15323 IAssignMethod, clean up old code.
15325 2001-10-22 Ravi Pratap <ravi@ximian.com>
15327 * typemanager.cs (ImplementsInterface): New method to determine if a type
15328 implements a given interface. Provides a nice cache too.
15330 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15333 (ConvertReferenceExplicit): Ditto.
15335 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15336 various methods, with correct names etc.
15338 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15339 Operator.UnaryNegation.
15341 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15342 we have a unary plus or minus operator.
15344 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15347 * everywhere : update accordingly.
15349 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15352 * class.cs (Method::Define): For the case where we are implementing a method
15353 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15354 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15356 2001-10-21 Ravi Pratap <ravi@ximian.com>
15358 * interface.cs (FindMembers): Implement to work around S.R.E
15361 * typemanager.cs (IsInterfaceType): Implement.
15363 (FindMembers): Update to handle interface types too.
15365 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15366 use IsAssignableFrom as that is not correct - it doesn't work.
15368 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15369 and accordingly override EmitStatement.
15371 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15372 using the correct logic :-)
15374 2001-10-19 Ravi Pratap <ravi@ximian.com>
15376 * ../errors/cs-11.cs : Add to demonstrate error -11
15378 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15380 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15381 then pass this as a hint to ResolveLValue.
15383 * expression.cs (FieldExpr): Add Location information
15385 (FieldExpr::LValueResolve): Report assignment to readonly
15388 (Expression::ExprClassFromMemberInfo): Pass location information.
15390 (Expression::ResolveLValue): Add new method that resolves an
15393 (Expression::DoResolveLValue): Default invocation calls
15396 (Indexers): New class used to keep track of indexers in a given
15399 (IStackStore): Renamed from LValue, as it did not really describe
15400 what this did. Also ResolveLValue is gone from this interface and
15401 now is part of Expression.
15403 (ElementAccess): Depending on the element access type
15405 * typemanager.cs: Add `indexer_name_type' as a Core type
15406 (System.Runtime.CompilerServices.IndexerNameAttribute)
15408 * statement.cs (Goto): Take a location.
15410 2001-10-18 Ravi Pratap <ravi@ximian.com>
15412 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15413 if two delegates are compatible.
15415 (NewDelegate::DoResolve): Update to take care of the case when
15416 we instantiate a delegate from another delegate.
15418 * typemanager.cs (FindMembers): Don't even try to look up members
15419 of Delegate types for now.
15421 2001-10-18 Ravi Pratap <ravi@ximian.com>
15423 * delegate.cs (NewDelegate): New class to take care of delegate
15426 * expression.cs (New): Split the delegate related code out into
15427 the NewDelegate class.
15429 * delegate.cs (DelegateInvocation): New class to handle delegate
15432 * expression.cs (Invocation): Split out delegate related code into
15433 the DelegateInvocation class.
15435 2001-10-17 Ravi Pratap <ravi@ximian.com>
15437 * expression.cs (New::DoResolve): Implement delegate creation fully
15438 and according to the spec.
15440 (New::DoEmit): Update to handle delegates differently.
15442 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15443 because of which we were printing out arguments in reverse order !
15445 * delegate.cs (VerifyMethod): Implement to check if the given method
15446 matches the delegate.
15448 (FullDelegateDesc): Implement.
15450 (VerifyApplicability): Implement.
15452 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15453 delegate invocations too.
15455 (Invocation::Emit): Ditto.
15457 * ../errors/cs1593.cs : Added.
15459 * ../errors/cs1594.cs : Added.
15461 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15463 2001-10-16 Ravi Pratap <ravi@ximian.com>
15465 * typemanager.cs (intptr_type): Core type for System.IntPtr
15467 (InitCoreTypes): Update for the same.
15469 (iasyncresult_type, asynccallback_type): Ditto.
15471 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15474 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15477 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15478 the builders for the 4 members of a delegate type :-)
15480 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15483 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15485 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15487 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15489 * statement.cs (Break::Emit): Implement.
15490 (Continue::Emit): Implement.
15492 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15493 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15494 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15495 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15498 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15499 properties that track the label for the current loop (begin of the
15500 loop and end of the loop).
15502 2001-10-15 Ravi Pratap <ravi@ximian.com>
15504 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15505 use of emitting anything at all.
15507 * class.cs, rootcontext.cs : Get rid of calls to the same.
15509 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15511 (Populate): Define the constructor correctly and set the implementation
15514 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15517 (AddDelegateType): Implement.
15519 (IsDelegateType): Implement helper method.
15521 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15523 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15524 and accordingly handle it.
15526 * delegate.cs (Populate): Take TypeContainer argument.
15527 Implement bits to define the Invoke method. However, I still haven't figured out
15528 how to take care of the native int bit :-(
15530 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15531 Qualify the name of the delegate, not its return type !
15533 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15536 (StandardConversionExists): Checking for array types turns out to be recursive.
15538 (ConvertReferenceExplicit): Implement array conversion.
15540 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15542 2001-10-12 Ravi Pratap <ravi@ximian.com>
15544 * cs-parser.jay (delegate_declaration): Store the fully qualified
15545 name as it is a type declaration.
15547 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15550 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15551 as TypeContainer::DefineType.
15553 (Populate): Method in which all the definition of the various methods (Invoke)
15556 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15559 (CloseDelegate): Finally creates the delegate.
15561 * class.cs (TypeContainer::DefineType): Update to define delegates.
15562 (Populate, Emit and CloseType): Do the same thing here too.
15564 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15565 delegates in all these operations.
15567 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15569 * expression.cs: LocalTemporary: a new expression used to
15570 reference a temporary that has been created.
15572 * assign.cs: Handle PropertyAccess back here, so that we can
15573 provide the proper semantic access to properties.
15575 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15576 a few more explicit conversions.
15578 * modifiers.cs: `NEW' modifier maps to HideBySig.
15580 * expression.cs (PropertyExpr): Make this into an
15581 ExpressionStatement, and support the EmitStatement code path.
15583 Perform get/set error checking, clean up the interface.
15585 * assign.cs: recognize PropertyExprs as targets, and if so, turn
15586 them into toplevel access objects.
15588 2001-10-12 Miguel de Icaza <miguel@ximian.com>
15590 * expression.cs: PropertyExpr::PropertyExpr: use work around the
15593 * typemanager.cs: Keep track here of our PropertyBuilders again to
15594 work around lameness in SRE.
15596 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15598 * expression.cs (LValue::LValueResolve): New method in the
15599 interface, used to perform a second resolution pass for LValues.
15601 (This::DoResolve): Catch the use of this in static methods.
15603 (This::LValueResolve): Implement.
15605 (This::Store): Remove warning, assigning to `this' in structures
15608 (Invocation::Emit): Deal with invocation of
15609 methods on value types. We need to pass the address to structure
15610 methods rather than the object itself. (The equivalent code to
15611 emit "this" for structures leaves the entire structure on the
15612 stack instead of a pointer to it).
15614 (ParameterReference::DoResolve): Compute the real index for the
15615 argument based on whether the method takes or not a `this' pointer
15616 (ie, the method is static).
15618 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
15619 value types returned from functions when we need to invoke a
15620 method on the sturcture.
15623 2001-10-11 Ravi Pratap <ravi@ximian.com>
15625 * class.cs (TypeContainer::DefineType): Method to actually do the business of
15626 defining the type in the Modulebuilder or Typebuilder. This is to take
15627 care of nested types which need to be defined on the TypeBuilder using
15628 DefineNestedMethod.
15630 (TypeContainer::GetClassBases): Implement. Essentially the code from the
15631 methods in RootContext, only ported to be part of TypeContainer.
15633 (TypeContainer::GetInterfaceOrClass): Ditto.
15635 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
15637 * interface.cs (Interface::DefineInterface): New method. Does exactly
15638 what RootContext.CreateInterface did earlier, only it takes care of nested types
15641 (Interface::GetInterfaces): Move from RootContext here and port.
15643 (Interface::GetInterfaceByName): Same here.
15645 * rootcontext.cs (ResolveTree): Re-write.
15647 (PopulateTypes): Re-write.
15649 * class.cs (TypeContainer::Populate): Populate nested types too.
15650 (TypeContainer::Emit): Emit nested members too.
15652 * typemanager.cs (AddUserType): Do not make use of the FullName property,
15653 instead just use the name argument passed in as it is already fully
15656 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
15657 to TypeContainer mapping to see if a type is user-defined.
15659 * class.cs (TypeContainer::CloseType): Implement.
15661 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
15662 the default constructor.
15664 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
15667 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
15669 * interface.cs (CloseType): Create the type here.
15671 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
15674 Remove all the methods which are now in TypeContainer.
15676 2001-10-10 Ravi Pratap <ravi@ximian.com>
15678 * delegate.cs (Define): Re-write bits to define the delegate
15681 2001-10-10 Miguel de Icaza <miguel@ximian.com>
15683 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
15685 * expression.cs (ImplicitReferenceConversion): handle null as well
15686 as a source to convert to any reference type.
15688 * statement.cs (Return): Perform any implicit conversions to
15689 expected return type.
15691 Validate use of return statement.
15693 * codegen.cs (EmitContext): Pass the expected return type here.
15695 * class.cs (Method, Constructor, Property): Pass expected return
15696 type to EmitContext.
15698 2001-10-09 Miguel de Icaza <miguel@ximian.com>
15700 * expression.cs: Make DoResolve take an EmitContext instead of a
15703 Replaced `l' and `location' for `loc', for consistency.
15705 (Error, Warning): Remove unneeded Tc argument.
15707 * assign.cs, literal.cs, constant.cs: Update to new calling
15710 * codegen.cs: EmitContext now contains a flag indicating whether
15711 code is being generated in a static method or not.
15713 * cs-parser.jay: DecomposeQI, new function that replaces the old
15714 QualifiedIdentifier. Now we always decompose the assembled
15715 strings from qualified_identifier productions into a group of
15718 2001-10-08 Miguel de Icaza <miguel@ximian.com>
15720 * rootcontext.cs: Deal with field-less struct types correctly now
15721 by passing the size option to Define Type.
15723 * class.cs: Removed hack that created one static field.
15725 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15727 * statement.cs: Moved most of the code generation here.
15729 2001-10-09 Ravi Pratap <ravi@ximian.com>
15731 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
15734 (ElementAccess): Remove useless bits for now - keep checks as the spec
15737 2001-10-08 Ravi Pratap <ravi@ximian.com>
15739 * expression.cs (ElementAccess::DoResolve): Remove my crap code
15740 and start performing checks according to the spec.
15742 2001-10-07 Ravi Pratap <ravi@ximian.com>
15744 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
15745 rank_specifiers instead.
15747 (rank_specifiers): Change the order in which the rank specifiers are stored
15749 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
15751 * expression.cs (ElementAccess): Implement the LValue interface too.
15753 2001-10-06 Ravi Pratap <ravi@ximian.com>
15755 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
15756 except that user defined conversions are not included.
15758 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
15759 perform the conversion of the return type, if necessary.
15761 (New::DoResolve): Check whether we are creating an array or an object
15762 and accordingly do the needful.
15764 (New::Emit): Same here.
15766 (New::DoResolve): Implement guts of array creation.
15768 (New::FormLookupType): Helper function.
15770 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15772 * codegen.cs: Removed most of the code generation here, and move the
15773 corresponding code generation bits to the statement classes.
15775 Added support for try/catch/finalize and throw.
15777 * cs-parser.jay: Added support for try/catch/finalize.
15779 * class.cs: Catch static methods having the flags override,
15780 virtual or abstract.
15782 * expression.cs (UserCast): This user cast was not really doing
15783 what it was supposed to do. Which is to be born in fully resolved
15784 state. Parts of the resolution were being performed at Emit time!
15788 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15790 * expression.cs: Implicity convert the result from UserCast.
15792 2001-10-05 Ravi Pratap <ravi@ximian.com>
15794 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
15795 prevented it from working correctly.
15797 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
15798 merely ConvertImplicit.
15800 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15802 * typemanager.cs: Make the LookupTypeContainer function static,
15803 and not per-instance.
15805 * class.cs: Make static FindMembers (the one that takes a Type
15808 * codegen.cs: Add EmitForeach here.
15810 * cs-parser.jay: Make foreach a toplevel object instead of the
15811 inline expansion, as we need to perform semantic analysis on it.
15813 2001-10-05 Ravi Pratap <ravi@ximian.com>
15815 * expression.cs (Expression::ImplicitUserConversion): Rename to
15816 UserDefinedConversion.
15818 (Expression::UserDefinedConversion): Take an extra argument specifying
15819 whether we look for explicit user conversions too.
15821 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
15823 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
15825 (ExplicitUserConversion): Make it a call to UserDefinedConversion
15826 with the appropriate arguments.
15828 * cs-parser.jay (cast_expression): Record location too.
15830 * expression.cs (Cast): Record location info.
15832 (Expression::ConvertExplicit): Take location argument.
15834 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
15835 to determine if we are doing explicit conversions.
15837 (UserCast::Emit): Update accordingly.
15839 (Expression::ConvertExplicit): Report an error if everything fails.
15841 * ../errors/cs0030.cs : Add.
15843 2001-10-04 Miguel de Icaza <miguel@ximian.com>
15845 * modifiers.cs: If the ABSTRACT keyword is present, also set the
15846 virtual and newslot bits.
15848 * class.cs (TypeContainer::RegisterRequiredImplementations):
15849 Record methods we need.
15851 (TypeContainer::MakeKey): Helper function to make keys for
15852 MethodBases, since the Methodbase key is useless.
15854 (TypeContainer::Populate): Call RegisterRequiredImplementations
15855 before defining the methods.
15857 Create a mapping for method_builders_to_methods ahead of time
15858 instead of inside a tight loop.
15860 (::RequireMethods): Accept an object as the data to set into the
15861 hashtable so we can report interface vs abstract method mismatch.
15863 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15865 * report.cs: Make all of it static.
15867 * rootcontext.cs: Drop object_type and value_type computations, as
15868 we have those in the TypeManager anyways.
15870 Drop report instance variable too, now it is a global.
15872 * driver.cs: Use try/catch on command line handling.
15874 Add --probe option to debug the error reporting system with a test
15877 * report.cs: Add support for exiting program when a probe
15878 condition is reached.
15880 2001-10-03 Ravi Pratap <ravi@ximian.com>
15882 * expression.cs (Binary::DoNumericPromotions): Fix the case when
15883 we do a forcible conversion regardless of type, to check if
15884 ForceConversion returns a null.
15886 (Binary::error19): Use location to report error.
15888 (Unary::error23): Use location here too.
15890 * ../errors/cs0019.cs : Check in.
15892 * ../errors/cs0023.cs : Check in.
15894 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
15895 case of a non-null MethodInfo object with a length of 0 !
15897 (Binary::ResolveOperator): Flag error if overload resolution fails to find
15898 an applicable member - according to the spec :-)
15899 Also fix logic to find members in base types.
15901 (Unary::ResolveOperator): Same here.
15903 (Unary::report23): Change name to error23 and make first argument a TypeContainer
15904 as I was getting thoroughly confused between this and error19 :-)
15906 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
15907 (::FindMostEncompassedType): Implement.
15908 (::FindMostEncompassingType): Implement.
15909 (::StandardConversionExists): Implement.
15911 (UserImplicitCast): Re-vamp. We now need info about most specific
15912 source and target types so that we can do the necessary conversions.
15914 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
15915 mathematical union with no duplicates.
15917 2001-10-03 Miguel de Icaza <miguel@ximian.com>
15919 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
15920 in order from base classes to child classes, so that we can in
15921 child classes look up in our parent for method names and
15922 attributes (required for handling abstract, virtual, new, override
15923 constructs: we need to instrospect our base class, and if we dont
15924 populate the classes in order, the introspection might be
15925 incorrect. For example, a method could query its parent before
15926 the parent has any methods and would determine that the parent has
15927 no abstract methods (while it could have had them)).
15929 (RootContext::CreateType): Record the order in which we define the
15932 2001-10-02 Miguel de Icaza <miguel@ximian.com>
15934 * class.cs (TypeContainer::Populate): Also method definitions can
15935 fail now, keep track of this.
15937 (TypeContainer::FindMembers): Implement support for
15938 DeclaredOnly/noDeclaredOnly flag.
15940 (Constructor::Emit) Return the ConstructorBuilder.
15942 (Method::Emit) Return the MethodBuilder.
15943 Check for abstract or virtual methods to be public.
15945 * rootcontext.cs (RootContext::CreateType): Register all the
15946 abstract methods required for the class to be complete and the
15947 interface methods that must be implemented.
15949 * cs-parser.jay: Report error 501 (method requires body if it is
15950 not marked abstract or extern).
15952 * expression.cs (TypeOf::Emit): Implement.
15954 * typemanager.cs: runtime_handle_type, new global type.
15956 * class.cs (Property::Emit): Generate code for properties.
15958 2001-10-02 Ravi Pratap <ravi@ximian.com>
15960 * expression.cs (Unary::ResolveOperator): Find operators on base type
15961 too - we now conform exactly to the spec.
15963 (Binary::ResolveOperator): Same here.
15965 * class.cs (Operator::Define): Fix minor quirk in the tests.
15967 * ../errors/cs0215.cs : Added.
15969 * ../errors/cs0556.cs : Added.
15971 * ../errors/cs0555.cs : Added.
15973 2001-10-01 Miguel de Icaza <miguel@ximian.com>
15975 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
15976 single integer which is really efficient
15978 2001-10-01 Ravi Pratap <ravi@ximian.com>
15980 * expression.cs (Expression::ImplicitUserConversion): Use location
15981 even in the case when we are examining True operators.
15983 * class.cs (Operator::Define): Perform extensive checks to conform
15984 with the rules for operator overloading in the spec.
15986 * expression.cs (Expression::ImplicitReferenceConversion): Implement
15987 some of the other conversions mentioned in the spec.
15989 * typemanager.cs (array_type): New static member for the System.Array built-in
15992 (cloneable_interface): For System.ICloneable interface.
15994 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
15995 we start resolving the tree and populating types.
15997 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
15999 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16001 * expression.cs (Expression::ExprClassFromMemberInfo,
16002 Expression::Literalize): Create literal expressions from
16003 FieldInfos which are literals.
16005 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16006 type casts, because they were wrong. The test suite in tests
16009 (ImplicitNumericConversion): ushort to ulong requires a widening
16012 Int32 constant to long requires widening cast as well.
16014 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16015 for integers because the type on the stack is not i4.
16017 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16019 * expression.cs (report118): require location argument.
16021 * parameter.cs: Do not dereference potential null value.
16023 * class.cs: Catch methods that lack the `new' keyword when
16024 overriding a name. Report warnings when `new' is used without
16025 anything being there to override.
16027 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16029 * class.cs: Only add constructor to hashtable if it is non-null
16030 (as now constructors can fail on define).
16032 (TypeManager, Class, Struct): Take location arguments.
16034 Catch field instance initialization in structs as errors.
16036 accepting_filter: a new filter for FindMembers that is static so
16037 that we dont create an instance per invocation.
16039 (Constructor::Define): Catch errors where a struct constructor is
16042 * cs-parser.jay: Pass location information for various new
16045 * delegate.cs (Delegate): take a location argument.
16047 * driver.cs: Do not call EmitCode if there were problesm in the
16048 Definition of the types, as many Builders wont be there.
16050 * decl.cs (Decl::Decl): Require a location argument.
16052 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16053 into integers, and find the most appropiate integer for it.
16055 * literal.cs: Implement ULongLiteral.
16057 * rootcontext.cs: Provide better information about the location of
16058 failure when CreateType fails.
16060 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16062 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16065 * expression.cs (Binary::CheckShiftArguments): Add missing type
16067 (Binary::ResolveOperator): Add type to the logical and and logical
16068 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16071 (Binary::DoNumericPromotions): In the case where either argument
16072 is ulong (and most signed types combined with ulong cause an
16073 error) perform implicit integer constant conversions as well.
16075 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16077 * expression.cs (UserImplicitCast): Method should always be
16079 (Invocation::BetterConversion): Simplified test for IntLiteral.
16081 (Expression::ImplicitNumericConversion): Split this routine out.
16082 Put the code that performs implicit constant integer conversions
16085 (Expression::Resolve): Become a wrapper around DoResolve so we can
16086 check eclass and type being set after resolve.
16088 (Invocation::Badness): Remove this dead function
16090 (Binary::ResolveOperator): Do not compute the expensive argumnets
16091 unless we have a union for it.
16093 (Probe::Emit): Is needs to do an isinst and then
16094 compare against null.
16096 (::CanConvert): Added Location argument. If the Location argument
16097 is null (Location.Null), then we do not report errors. This is
16098 used by the `probe' mechanism of the Explicit conversion. We do
16099 not want to generate an error for something that the user
16100 explicitly requested to be casted. But the pipeline for an
16101 explicit cast first tests for potential implicit casts.
16103 So for now, if the Location is null, it means `Probe only' to
16104 avoid adding another argument. Might have to revise this
16107 (ClassCast): New class used to type cast objects into arbitrary
16108 classes (used in Explicit Reference Conversions).
16110 Implement `as' as well.
16112 Reverted all the patches from Ravi below: they were broken:
16114 * The use of `level' as a mechanism to stop recursive
16115 invocations is wrong. That was there just to catch the
16116 bug with a strack trace but not as a way of addressing
16119 To fix the problem we have to *understand* what is going
16120 on and the interactions and come up with a plan, not
16121 just get things going.
16123 * The use of the type conversion cache that I proposed
16124 last night had an open topic: How does this work across
16125 protection domains. A user defined conversion might not
16126 be public in the location where we are applying the
16127 conversion, a different conversion might be selected
16128 (ie, private A->B (better) but public B->A (worse),
16129 inside A, A->B applies, but outside it, B->A will
16132 * On top of that (ie, even if the above is solved),
16133 conversions in a cache need to be abstract. Ie, `To
16134 convert from an Int to a Short use an OpcodeCast', not
16135 `To convert from an Int to a Short use the OpcodeCast on
16136 the variable 5' (which is what this patch was doing).
16138 2001-09-28 Ravi Pratap <ravi@ximian.com>
16140 * expression.cs (Invocation::ConversionExists): Re-write to use
16141 the conversion cache
16143 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16144 cache all conversions done, not just user-defined ones.
16146 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16147 to determine if a conversion exists instead of acutually trying to
16148 perform the conversion. It's faster too.
16150 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16151 and only then attempt the implicit conversion.
16153 2001-09-28 Ravi Pratap <ravi@ximian.com>
16155 * expression.cs (ConvertImplicit): Use a cache for conversions
16156 already found. Check level of recursion and bail out if necessary.
16158 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16160 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16161 Export standard methods that we expect for string operations.
16163 * statement.cs (Block::UsageWarning): Track usage of variables and
16164 report the errors for not used variables.
16166 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16169 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16171 * codegen.cs: remove unnneded code
16173 * expression.cs: Removed BuiltinTypeAccess class
16175 Fix the order in which implicit conversions are
16178 The previous fixed dropped support for boxed conversions (adding a
16179 test to the test suite now)
16181 (UserImplicitCast::CanConvert): Remove test for source being null,
16182 that code is broken. We should not feed a null to begin with, if
16183 we do, then we should track the bug where the problem originates
16184 and not try to cover it up here.
16186 Return a resolved expression of type UserImplicitCast on success
16187 rather than true/false. Ravi: this is what I was talking about,
16188 the pattern is to use a static method as a "constructor" for
16191 Also, do not create arguments until the very last minute,
16192 otherwise we always create the arguments even for lookups that
16193 will never be performed.
16195 (UserImplicitCast::Resolve): Eliminate, objects of type
16196 UserImplicitCast are born in a fully resolved state.
16198 * typemanager.cs (InitCoreTypes): Init also value_type
16199 (System.ValueType).
16201 * expression.cs (Cast::Resolve): First resolve the child expression.
16203 (LValue): Add new method AddressOf to be used by
16206 Change the argument of Store to take an EmitContext instead of an
16207 ILGenerator, because things like FieldExpr need to be able to call
16208 their children expression to generate the instance code.
16210 (Expression::Error, Expression::Warning): Sugar functions for
16213 (Expression::MemberLookup): Accept a TypeContainer instead of a
16214 Report as the first argument.
16216 (Expression::ResolvePrimary): Killed. I still want to improve
16217 this as currently the code is just not right.
16219 (Expression::ResolveMemberAccess): Simplify, but it is still
16222 (Unary::Resolve): Catch errors in AddressOf operators.
16224 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16225 index to a byte for the short-version, or the compiler will choose
16226 the wrong Emit call, which generates the wrong data.
16228 (ParameterReference::Emit, ::Store): same.
16230 (FieldExpr::AddressOf): Implement.
16232 * typemanager.cs: TypeManager: made public variable instead of
16235 * driver.cs: document --fatal.
16237 * report.cs (ErrorMessage, WarningMessage): new names for the old
16238 Error and Warning classes.
16240 * cs-parser.jay (member_access): Turn built-in access to types
16241 into a normal simplename
16243 2001-09-27 Ravi Pratap <ravi@ximian.com>
16245 * expression.cs (Invocation::BetterConversion): Fix to cope
16246 with q being null, since this was introducing a bug.
16248 * expression.cs (ConvertImplicit): Do built-in conversions first.
16250 2001-09-27 Ravi Pratap <ravi@ximian.com>
16252 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16254 2001-09-27 Ravi Pratap <ravi@ximian.com>
16256 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16257 I had introduced long ago (what's new ?).
16259 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16260 the work of all the checking.
16261 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16262 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16264 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16265 that is the right way.
16267 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16268 overloading resolution. Use everywhere instead of cutting and pasting code.
16270 (Binary::ResolveOperator): Use MakeUnionSet.
16272 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16273 we have to convert to bool types. Not complete yet.
16275 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16277 * typemanager.cs (TypeManager::CSharpName): support ushort.
16279 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16280 to provide an expression that performsn an implicit constant int
16281 conversion (section 6.1.6).
16282 (Expression::ConvertImplicitRequired): Reworked to include
16283 implicit constant expression conversions.
16285 (Expression::ConvertNumericExplicit): Finished.
16287 (Invocation::Emit): If InstanceExpression is null, then it means
16288 that we perform a call on this.
16290 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16292 * expression.cs (Unary::Emit): Remove some dead code.
16293 (Probe): Implement Resolve and Emit for `is'.
16294 (Expression::ConvertImplicitRequired): Attempt to do constant
16295 expression conversions here. Maybe should be moved to
16296 ConvertImplicit, but I am not sure.
16297 (Expression::ImplicitLongConstantConversionPossible,
16298 Expression::ImplicitIntConstantConversionPossible): New functions
16299 that tell whether is it possible to apply an implicit constant
16300 expression conversion.
16302 (ConvertNumericExplicit): Started work on explicit numeric
16305 * cs-parser.jay: Update operator constants.
16307 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16308 (Parameters::GetSignature): Hook up VerifyArgs here.
16309 (Parameters::VerifyArgs): Verifies that no two arguments have the
16312 * class.cs (Operator): Update the operator names to reflect the
16313 ones that the spec expects (as we are just stringizing the
16316 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16317 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16318 previous usage did only work for our methods.
16319 (Expression::ConvertImplicit): Handle decimal implicit numeric
16320 conversions as well.
16321 (Expression::InternalTypeConstructor): Used to invoke constructors
16322 on internal types for default promotions.
16324 (Unary::Emit): Implement special handling for the pre/post
16325 increment/decrement for overloaded operators, as they need to have
16326 the same semantics as the other operators.
16328 (Binary::ResolveOperator): ditto.
16329 (Invocation::ConversionExists): ditto.
16330 (UserImplicitCast::Resolve): ditto.
16332 2001-09-26 Ravi Pratap <ravi@ximian.com>
16334 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16335 operator, return after emitting body. Regression tests pass again !
16337 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16338 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16339 (Invocation::OverloadResolve): Ditto.
16340 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16342 * everywhere : update calls to the above methods accordingly.
16344 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16346 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16348 * expression.cs (ExpressionStatement): New base class used for
16349 expressions that can appear in statements, so that we can provide
16350 an alternate path to generate expression that do not leave a value
16353 (Expression::Emit, and all the derivatives): We no longer return
16354 whether a value is left on the stack or not. Every expression
16355 after being emitted leaves a single value on the stack.
16357 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16358 facilties of ExpressionStatement if possible.
16360 * cs-parser.jay: Update statement_expression.
16362 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16364 * driver.cs: Change the wording of message
16366 2001-09-25 Ravi Pratap <ravi@ximian.com>
16368 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16369 the type of the expression to the return type of the method if
16370 we have an overloaded operator match ! The regression tests pass again !
16371 (Unary::ResolveOperator): Ditto.
16373 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16374 to find "op_Implicit", not "implicit" ;-)
16375 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16376 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16378 * everywhere : Correct calls to the above accordingly.
16380 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16381 (ConvertImplicit): Do user-defined conversion if it exists.
16383 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16385 * assign.cs: track location.
16386 (Resolve): Use implicit conversions on assignment.
16388 * literal.cs: Oops. Not good, Emit of short access values should
16389 pass (Bytes) or the wrong argument will be selected.
16391 * expression.cs (Unary::Emit): Emit code for -expr.
16393 (Unary::ResolveOperator): Handle `Substract' for non-constants
16394 (substract from zero from the non-constants).
16395 Deal with Doubles as well.
16397 (Expression::ConvertImplicitRequired): New routine that reports an
16398 error if no implicit conversion exists.
16400 (Invocation::OverloadResolve): Store the converted implicit
16401 expressions if we make them
16403 2001-09-24 Ravi Pratap <ravi@ximian.com>
16405 * class.cs (ConstructorInitializer): Take a Location argument.
16406 (ConstructorBaseInitializer): Same here.
16407 (ConstructorThisInitializer): Same here.
16409 * cs-parser.jay : Update all calls accordingly.
16411 * expression.cs (Unary, Binary, New): Take location argument.
16412 Update accordingly everywhere.
16414 * cs-parser.jay : Update all calls to the above to take a location
16417 * class.cs : Ditto.
16419 2001-09-24 Ravi Pratap <ravi@ximian.com>
16421 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16422 (Invocation::BetterConversion): Same here
16423 (Invocation::ConversionExists): Ditto.
16425 (Invocation::ConversionExists): Implement.
16427 2001-09-22 Ravi Pratap <ravi@ximian.com>
16429 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16430 Also take an additional TypeContainer argument.
16432 * All over : Pass in TypeContainer as argument to OverloadResolve.
16434 * typemanager.cs (CSharpName): Update to check for the string type and return
16437 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16440 2001-09-21 Ravi Pratap <ravi@ximian.com>
16442 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16443 (Invocation::BetterFunction): Implement.
16444 (Invocation::BetterConversion): Implement.
16445 (Invocation::ConversionExists): Skeleton, no implementation yet.
16447 Okay, things work fine !
16449 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16451 * typemanager.cs: declare and load enum_type, delegate_type and
16454 * expression.cs (Expression::Emit): Now emit returns a value that
16455 tells whether a value is left on the stack or not. This strategy
16456 might be reveted tomorrow with a mechanism that would address
16457 multiple assignments.
16458 (Expression::report118): Utility routine to report mismatches on
16461 (Unary::Report23): Report impossible type/operator combination
16464 (Unary::IsIncrementableNumber): Whether the type can be
16465 incremented or decremented with add.
16466 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16468 (Unary::ResolveOperator): Implement ++, !, ~,
16470 (Invocation::Emit): Deal with new Emit convetion.
16472 * All Expression derivatives: Updated their Emit method to return
16473 whether they leave values on the stack or not.
16475 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16476 stack for expressions that are statements.
16478 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16480 * expression.cs (LValue): New interface. Must be implemented by
16482 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16485 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16486 interface for generating code, simplifies the code.
16488 2001-09-20 Ravi Pratap <ravi@ximian.com>
16490 * expression.cs (everywhere): Comment out return statements in ::Resolve
16491 methods to avoid the warnings.
16493 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16495 * driver.cs (parse): Report error 2001 if we can not open the
16498 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16501 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16504 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16505 otherwise nested blocks end up with the same index.
16507 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16509 * expression.cs: Instead of having FIXMEs in the Resolve
16510 functions, throw exceptions so it is obvious that we are facing a
16513 * cs-parser.jay (invocation_expression): Pass Location information.
16515 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16516 Use a basename for those routines because .NET does not like paths
16519 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16522 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16524 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16525 are loading the correct data types (throws an exception if not).
16526 (TypeManager::InitCoreTypes): Use CoreLookupType
16528 * expression.cs (Unary::ResolveOperator): return the child
16529 expression for expressions which are just +expr.
16530 (Unary::ResolveOperator): Return negative literals for -LITERAL
16531 expressions (otherwise they are Unary {Literal}).
16532 (Invocation::Badness): Take into account `Implicit constant
16533 expression conversions'.
16535 * literal.cs (LongLiteral): Implement long literal class.
16536 (IntLiteral): export the `Value' of the intliteral.
16538 2001-09-19 Ravi Pratap <ravi@ximian.com>
16540 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16542 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16543 instead of 'Operator'
16545 * expression.cs (Binary::ResolveOperator): Update accordingly.
16546 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16549 * cs-parser.jay (unary_expression): Update to use the new names.
16551 * gen-treedump.cs (GetUnary): Same here.
16553 * expression.cs (Unary::Resolve): Implement.
16554 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16555 operators are found instead of making noise ;-)
16556 (Unary::ResolveOperator): New method to do precisely the same thing which
16557 Binary::ResolveOperator does for Binary expressions.
16558 (Unary.method, .Arguments): Add.
16559 (Unary::OperName): Implement.
16560 (Unary::ForceConversion): Copy and Paste !
16562 * class.cs (Operator::Define): Fix a small bug for the case when we have
16565 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16566 for the inbuilt operators. Only overloading works for now ;-)
16568 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16570 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16571 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16573 * expression.cs (This::Emit): Implement.
16574 (This::Resolve): Implement.
16575 (TypeOf:Resolve): Implement.
16576 (Expression::ResolveSimpleName): Add an implicit this to instance
16578 (MemberAccess::Resolve): Deal with Parameters and Fields.
16579 Bind instance variable to Field expressions.
16580 (FieldExpr::Instance): New field used to track the expression that
16581 represents the object instance.
16582 (FieldExpr::Resolve): Track potential errors from MemberLookup not
16584 (FieldExpr::Emit): Implement.
16586 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
16587 the last instruction contains a return opcode to avoid generating
16588 the last `ret' instruction (this generates correct code, and it is
16589 nice to pass the peverify output).
16591 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
16592 initializer for static and instance variables.
16593 (Constructor::Emit): Allow initializer to be null in the case of
16594 static constructors. Only emit initializer for instance
16597 (TypeContainer::FindMembers): Return a null array if there are no
16600 Also fix the code for the MemberTypes.Method branch, as it was not
16601 scanning that for operators (or tried to access null variables before).
16603 * assign.cs (Assign::Emit): Handle instance and static fields.
16607 * driver.cs: Stop compilation if there are parse errors.
16609 * cs-parser.jay (constructor_declaration): Provide default base
16610 initializer for non-static constructors.
16611 (constructor_declarator): Do not provide a default base
16612 initializers if none was specified.
16613 Catch the fact that constructors should not have parameters.
16615 * class.cs: Do not emit parent class initializers for static
16616 constructors, that should be flagged as an error.
16618 2001-09-18 Ravi Pratap <ravi@ximian.com>
16620 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
16621 Move back code into TypeContainer::Populate.
16623 2001-09-18 Ravi Pratap <ravi@ximian.com>
16625 * class.cs (TypeContainer::AddConstructor): Fix the check to
16626 compare against Name, not Basename.
16627 (Operator::OpType): Change Plus and Minus to Add and Subtract.
16629 * cs-parser.jay : Update accordingly.
16631 * class.cs (TypeContainer::FindMembers): For the case where we are searching
16632 for methods, don't forget to look into the operators too.
16633 (RegisterMethodBuilder): Helper method to take care of this for
16634 methods, constructors and operators.
16635 (Operator::Define): Completely revamp.
16636 (Operator.OperatorMethod, MethodName): New fields.
16637 (TypeContainer::Populate): Move the registering of builders into
16638 RegisterMethodBuilder.
16639 (Operator::Emit): Re-write.
16641 * expression.cs (Binary::Emit): Comment out code path to emit method
16642 invocation stuff for the case when we have a user defined operator. I am
16643 just not able to get it right !
16645 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16647 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
16650 (Expression::MemberLookup): Provide a version that allows to
16651 specify the MemberTypes and BindingFlags.
16653 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
16654 so it was not fetching variable information from outer blocks.
16656 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
16657 Beforefieldinit as it was buggy.
16659 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
16660 that Ravi put here.
16662 * class.cs (Constructor::Emit): Only emit if block is not null.
16663 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
16664 deal with this by semantically definining it as if the user had
16667 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
16668 constructors as we now "emit" them at a higher level.
16670 (TypeContainer::DefineDefaultConstructor): Used to define the
16671 default constructors if none was provided.
16673 (ConstructorInitializer): Add methods Resolve and Emit.
16675 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
16677 2001-09-17 Ravi Pratap <ravi@ximian.com>
16679 * class.cs (TypeContainer::EmitDefaultConstructor): Register
16680 the default constructor builder with our hashtable for methodbuilders
16683 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
16684 and argument_count is 0 in which case we have a match.
16685 (Binary::ResolveOperator): More null checking and miscellaneous coding
16688 2001-09-17 Ravi Pratap <ravi@ximian.com>
16690 * rootcontext.cs (IsNameSpace): Compare against null.
16692 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
16694 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
16695 and Unary::Operator.
16697 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
16700 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
16701 we have overloaded operators.
16702 (Binary::ResolveOperator): Implement the part which does the operator overload
16705 * class.cs (Operator::Emit): Implement.
16706 (TypeContainer::Emit): Emit the operators we have too.
16708 * expression.cs (Binary::Emit): Update to emit the appropriate code for
16709 the case when we have a user-defined operator.
16711 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16713 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
16715 2001-09-16 Ravi Pratap <ravi@ximian.com>
16717 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
16718 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
16719 (Constructor::Emit): Implement.
16720 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
16721 if we have no work to do.
16722 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
16725 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
16726 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
16728 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
16731 2001-09-15 Ravi Pratap <ravi@ximian.com>
16733 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
16735 (Tree::RecordNamespace): Method to do what the name says ;-)
16736 (Tree::Namespaces): Property to get at the namespaces hashtable.
16738 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
16741 * rootcontext.cs (IsNamespace): Fixed it :-)
16743 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16745 * class.cs (TypeContainer::FindMembers): Add support for
16747 (MethodCore): New class that encapsulates both the shared aspects
16748 of a Constructor and a Method.
16749 (Method, Constructor): Factored pieces into MethodCore.
16751 * driver.cs: Added --fatal which makes errors throw exceptions.
16752 Load System assembly as well as part of the standard library.
16754 * report.cs: Allow throwing exceptions on errors for debugging.
16756 * modifiers.cs: Do not use `parent', instead use the real type
16757 container to evaluate permission settings.
16759 * class.cs: Put Ravi's patch back in. He is right, and we will
16760 have to cope with the
16762 2001-09-14 Ravi Pratap <ravi@ximian.com>
16764 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
16765 FamORAssem, not FamANDAssem.
16767 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16769 * driver.cs: Added --parse option that only parses its input files
16772 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
16773 incorrect. IsTopLevel is not used to tell whether an object is
16774 root_types or not (that can be achieved by testing this ==
16775 root_types). But to see if this is a top-level *class* (not
16776 necessarly our "toplevel" container).
16778 2001-09-14 Ravi Pratap <ravi@ximian.com>
16780 * enum.cs (Enum::Define): Modify to call the Lookup method on the
16781 parent instead of a direct call to GetType.
16783 2001-09-14 Ravi Pratap <ravi@ximian.com>
16785 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
16786 Modifiers.TypeAttr. This should just be a call to that method.
16788 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
16789 object so that we can determine if we are top-level or not.
16791 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
16794 * enum.cs (Enum::Define): Ditto.
16796 * modifiers.cs (FieldAttr): Re-write.
16798 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
16799 (TypeContainer::HaveStaticConstructor): New property to provide access
16800 to precisely that info.
16802 * modifiers.cs (MethodAttr): Re-write.
16803 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
16805 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
16806 of top-level types as claimed.
16808 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16810 * expression.cs (MemberLookup): Fruitless attempt to lookup
16811 constructors. Maybe I need to emit default constructors? That
16812 might be it (currently .NET emits this for me automatically).
16813 (Invocation::OverloadResolve): Cope with Arguments == null.
16814 (Invocation::EmitArguments): new function, shared by the new
16815 constructor and us.
16816 (Invocation::Emit): Handle static and instance methods. Emit
16817 proper call instruction for virtual or non-virtual invocations.
16818 (New::Emit): Implement.
16819 (New::Resolve): Implement.
16820 (MemberAccess:Resolve): Implement.
16821 (MethodGroupExpr::InstanceExpression): used conforming to the spec
16822 to track instances.
16823 (FieldExpr::Resolve): Set type.
16825 * support.cs: Handle empty arguments.
16827 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
16828 SimpleLookup): Auxiliary routines to help parse a qualifier
16831 Update qualifier_identifier rule.
16833 * codegen.cs: Removed debugging messages.
16835 * class.cs: Make this a global thing, this acts just as a "key" to
16836 objects that we might have around.
16838 (Populate): Only initialize method_builders_to_methods once.
16840 * expression.cs (PropertyExpr): Initialize type from the
16843 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
16844 Resolve pattern. Attempt to implicitly convert value to boolean.
16847 * expression.cs: Set the type for the int32/int32 argument case.
16848 (Binary::ResolveOperator): Set the return type to boolean for
16849 comparission operators
16851 * typemanager.cs: Remove debugging print code.
16853 (Invocation::Resolve): resolve type.
16855 * class.cs: Allocate a MemberInfo of the correct size, as the code
16856 elsewhere depends on the test to reflect the correct contents.
16858 (Method::) Keep track of parameters, due to System.Reflection holes
16860 (TypeContainer::Populate): Keep track of MethodBuilders to Method
16863 (TypeContainer::FindMembers): Use ArrayList and then copy an array
16864 of the exact size and return that.
16866 (Class::LookupMethodByBuilder): New function that maps
16867 MethodBuilders to its methods. Required to locate the information
16868 on methods because System.Reflection bit us again.
16870 * support.cs: New file, contains an interface ParameterData and
16871 two implementations: ReflectionParameters and InternalParameters
16872 used to access Parameter information. We will need to grow this
16875 * expression.cs (Invocation::GetParameterData): implement a cache
16876 and a wrapper around the ParameterData creation for methods.
16877 (Invocation::OverloadResolve): Use new code.
16879 2001-09-13 Ravi Pratap <ravi@ximian.com>
16881 * class.cs (TypeContainer::EmitField): Remove and move into
16882 (Field::Define): here and modify accordingly.
16883 (Field.FieldBuilder): New member.
16884 (TypeContainer::Populate): Update accordingly.
16885 (TypeContainer::FindMembers): Implement.
16887 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16889 * statement.cs: (VariableInfo::VariableType): New field to be
16890 initialized with the full type once it is resolved.
16892 2001-09-12 Miguel de Icaza <miguel@ximian.com>
16894 * parameter.cs (GetParameterInfo): Use a type cache to compute
16895 things only once, and to reuse this information
16897 * expression.cs (LocalVariableReference::Emit): Implement.
16898 (OpcodeCast::Emit): fix.
16900 (ParameterReference::Resolve): Implement.
16901 (ParameterReference::Emit): Implement.
16903 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
16904 that are expressions need to stay as Expressions.
16906 * typemanager.cs (CSharpName): Returns the C# name of a type if
16909 * expression.cs (Expression::ConvertImplicit): New function that
16910 implements implicit type conversions.
16912 (Expression::ImplicitReferenceConversion): Implements implicit
16913 reference conversions.
16915 (EmptyCast): New type for transparent casts.
16917 (OpcodeCast): New type for casts of types that are performed with
16918 a sequence of bytecodes.
16920 (BoxedCast): New type used for casting value types into reference
16921 types. Emits a box opcode.
16923 (Binary::DoNumericPromotions): Implements numeric promotions of
16924 and computation of the Binary::Type.
16926 (Binary::EmitBranchable): Optimization.
16928 (Binary::Emit): Implement code emission for expressions.
16930 * typemanager.cs (TypeManager): Added two new core types: sbyte
16933 2001-09-12 Ravi Pratap <ravi@ximian.com>
16935 * class.cs (TypeContainer::FindMembers): Method which does exactly
16936 what Type.FindMembers does, only we don't have to use reflection. No
16937 implementation yet.
16939 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
16940 typecontainer objects as we need to get at them.
16941 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
16943 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
16944 typecontainer object.
16946 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
16947 of just a Report object.
16949 2001-09-11 Ravi Pratap <ravi@ximian.com>
16951 * class.cs (Event::Define): Go back to using the prefixes "add_" and
16953 (TypeContainer::Populate): Now define the delegates of the type too.
16954 (TypeContainer.Delegates): Property to access the list of delegates defined
16957 * delegates.cs (Delegate::Define): Implement partially.
16959 * modifiers.cs (TypeAttr): Handle more flags.
16961 2001-09-11 Ravi Pratap <ravi@ximian.com>
16963 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
16965 (Operator::Define): Re-write logic to get types by using the LookupType method
16966 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
16967 (Indexer::Define): Ditto.
16968 (Event::Define): Ditto.
16969 (Property::Define): Ditto.
16971 2001-09-10 Ravi Pratap <ravi@ximian.com>
16973 * class.cs (TypeContainer::Populate): Now define operators too.
16974 (TypeContainer.Operators): New property to access the list of operators
16976 (Operator.OperatorMethodBuilder): New member to hold the method builder
16977 for the operator we are defining.
16978 (Operator::Define): Implement.
16980 2001-09-10 Ravi Pratap <ravi@ximian.com>
16982 * class.cs (Event::Define): Make the prefixes of the accessor methods
16983 addOn_ and removeOn_
16985 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
16986 of the location being passed in too. Ideally, this should go later since all
16987 error reporting should be done through the Report object.
16989 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
16990 (Populate): Iterate thru the indexers we have and define them too.
16991 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
16992 for the get and set accessors.
16993 (Indexer::Define): Implement.
16995 2001-09-09 Miguel de Icaza <miguel@ximian.com>
16997 * expression.cs (Binary::Resolve): Beginning of it. I scratched
16998 my previous implementation, did not work.
17000 * typemanager.cs: Add a couple of missing types (the longs).
17002 * literal.cs: Use TypeManager.bool_type instead of getting it.
17004 * expression.cs (EventExpr): New kind of expressions.
17005 (Expressio::ExprClassFromMemberInfo): finish
17007 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17009 * assign.cs: Emit stores to static fields differently.
17011 2001-09-08 Ravi Pratap <ravi@ximian.com>
17013 * Merge in changes and adjust code to tackle conflicts. Backed out my
17014 code in Assign::Resolve ;-)
17016 2001-09-08 Ravi Pratap <ravi@ximian.com>
17018 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17019 instead Report.Error and also pass in the location.
17020 (CSharpParser::Lexer): New readonly property to return the reference
17021 to the Tokenizer object.
17022 (declare_local_variables): Use Report.Error with location instead of plain
17026 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17027 (Operator.CheckBinaryOperator): Ditto.
17029 * cs-parser.jay (operator_declarator): Update accordingly.
17031 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17032 (CheckBinaryOperator): Same here.
17034 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17035 on the name without any prefixes of namespace names etc. This is because we
17036 already might have something already fully qualified like
17037 'System.Console.WriteLine'
17039 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17041 2001-09-07 Ravi Pratap <ravi@ximian.com>
17043 * cs-tokenizer.cs (location): Return a string which also contains
17046 * expression.cs (ElementAccess): New class for expressions of the
17047 type 'element access.'
17048 (BaseAccess): New class for expressions of the type 'base access.'
17049 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17052 * cs-parser.jay (element_access): Implement action.
17053 (base_access): Implement actions.
17054 (checked_expression, unchecked_expression): Implement.
17056 * cs-parser.jay (local_variable_type): Correct and implement.
17057 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17059 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17061 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17062 name and the specifiers.
17064 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17066 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17067 making them all public ;-)
17069 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17072 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17074 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17076 (FieldExpr, PropertyExprs): New resolved expressions.
17077 (SimpleName::MemberStaticCheck): Perform static checks for access
17078 to non-static fields on static methods. Maybe this should be
17079 generalized for MemberAccesses.
17080 (SimpleName::ResolveSimpleName): More work on simple name
17083 * cs-parser.jay (primary_expression/qualified_identifier): track
17084 the parameter index.
17086 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17087 (EmitContext::EmitBoolExpression): Chain to expression generation
17088 instead of temporary hack.
17089 (::EmitStatementExpression): Put generic expression code generation.
17091 * assign.cs (Assign::Emit): Implement variable assignments to
17092 local variables, parameters and fields.
17094 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17096 * statement.cs (Block::GetVariableInfo): New method, returns the
17097 VariableInfo for a variable name in a block.
17098 (Block::GetVariableType): Implement in terms of GetVariableInfo
17100 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17101 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17103 2001-09-06 Ravi Pratap <ravi@ximian.com>
17105 * cs-parser.jay (operator_declaration): Continue on my quest : update
17106 to take attributes argument.
17107 (event_declaration): Ditto.
17108 (enum_declaration): Ditto.
17109 (indexer_declaration): Ditto.
17111 * class.cs (Operator::Operator): Update constructor accordingly.
17112 (Event::Event): Ditto.
17114 * delegate.cs (Delegate::Delegate): Same here.
17116 * enum.cs (Enum::Enum): Same here.
17118 2001-09-05 Ravi Pratap <ravi@ximian.com>
17120 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17122 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17124 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17125 being passed around as an arraylist.
17126 (Attributes::AddAttribute): Method to add attribute sections.
17128 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17129 (struct_declaration): Update accordingly.
17130 (constant_declaration): Update.
17131 (field_declaration): Update.
17132 (method_header): Update.
17133 (fixed_parameter): Update.
17134 (parameter_array): Ditto.
17135 (property_declaration): Ditto.
17136 (destructor_declaration): Ditto.
17138 * class.cs (Struct::Struct): Update constructors accordingly.
17139 (Class::Class): Ditto.
17140 (Field::Field): Ditto.
17141 (Method::Method): Ditto.
17142 (Property::Property): Ditto.
17143 (TypeContainer::OptAttribute): update property's return type.
17145 * interface.cs (Interface.opt_attributes): New member.
17146 (Interface::Interface): Update to take the extra Attributes argument.
17148 * parameter.cs (Parameter::Parameter): Ditto.
17150 * constant.cs (Constant::Constant): Ditto.
17152 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17153 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17154 the attributes as a parameter.
17155 (InterfaceProperty): Update constructor call.
17156 (InterfaceEvent): Ditto.
17157 (InterfaceMethod): Ditto.
17158 (InterfaceIndexer): Ditto.
17160 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17161 pass the attributes too.
17162 (interface_event_declaration): Ditto.
17163 (interface_property_declaration): Ditto.
17164 (interface_method_declaration): Ditto.
17165 (interface_declaration): Ditto.
17167 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17169 * class.cs (Method::Define): Track the "static Main" definition to
17170 create an entry point.
17172 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17173 EntryPoint if we find it.
17175 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17176 (EmitContext::ig): Make this variable public.
17178 * driver.cs: Make the default output file be the first file name
17179 with the .exe extension.
17181 Detect empty compilations
17183 Handle various kinds of output targets. Handle --target and
17184 rename -t to --dumper.
17186 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17187 methods inherited from Expression return now an Expression. This
17188 will is used during the tree rewriting as we resolve them during
17191 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17192 the spec. Missing entirely is the information about
17193 accessability of elements of it.
17195 (Expression::ExprClassFromMemberInfo): New constructor for
17196 Expressions that creates a fully initialized Expression based on
17197 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17200 (Invocation::Resolve): Begin implementing resolution of invocations.
17202 * literal.cs (StringLiteral): Implement Emit.
17204 2001-09-05 Ravi Pratap <ravi@ximian.com>
17206 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17209 2001-09-04 Ravi Pratap <ravi@ximian.com>
17211 * cs-parser.jay (attribute_arguments): Implement actions.
17212 (attribute): Fix bug in production. Implement action.
17213 (attribute_list): Implement.
17214 (attribute_target): Implement.
17215 (attribute_target_specifier, opt_target_specifier): Implement
17216 (CheckAttributeTarget): New method to check if the attribute target
17218 (attribute_section): Implement.
17219 (opt_attributes): Implement.
17221 * attribute.cs : New file to handle attributes.
17222 (Attribute): Class to hold attribute info.
17224 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17225 (attribute_section): Modify production to use 2 different rules to
17226 achieve the same thing. 1 s/r conflict down !
17227 Clean out commented, useless, non-reducing dimension_separator rules.
17229 * class.cs (TypeContainer.attributes): New member to hold list
17230 of attributes for a type.
17231 (Struct::Struct): Modify to take one more argument, the attribute list.
17232 (Class::Class): Ditto.
17233 (Field::Field): Ditto.
17234 (Method::Method): Ditto.
17235 (Property::Property): Ditto.
17237 * cs-parser.jay (struct_declaration): Update constructor call to
17238 pass in the attributes too.
17239 (class_declaration): Ditto.
17240 (constant_declaration): Ditto.
17241 (field_declaration): Ditto.
17242 (method_header): Ditto.
17243 (fixed_parameter): Ditto.
17244 (parameter_array): Ditto.
17245 (property_declaration): Ditto.
17247 * constant.cs (Constant::Constant): Update constructor similarly.
17248 Use System.Collections.
17250 * parameter.cs (Parameter::Parameter): Update as above.
17252 2001-09-02 Ravi Pratap <ravi@ximian.com>
17254 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17255 (TypeContainer.delegates): New member to hold list of delegates.
17257 * cs-parser.jay (delegate_declaration): Implement the action correctly
17258 this time as I seem to be on crack ;-)
17260 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17262 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17263 tell whether an identifier represents a namespace.
17265 * expression.cs (NamespaceExpr): A namespace expression, used only
17266 temporarly during expression resolution.
17267 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17268 utility functions to resolve names on expressions.
17270 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17272 * codegen.cs: Add hook for StatementExpressions.
17274 * class.cs: Fix inverted test for static flag in methods.
17276 2001-09-02 Ravi Pratap <ravi@ximian.com>
17278 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17279 to make it coincide with MS' number.
17280 (Operator::CheckBinaryOperator): Ditto.
17282 * ../errors/errors.txt : Remove error numbers added earlier.
17284 * ../errors/cs1019.cs : Test case for error # 1019
17286 * ../errros/cs1020.cs : Test case for error # 1020
17288 * cs-parser.jay : Clean out commented cruft.
17289 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17290 used anywhere - non-reducing rule.
17291 (namespace_declarations): Non-reducing rule - comment out.
17293 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17294 with TypeContainer::AddEnum.
17296 * delegate.cs : New file for delegate handling classes.
17297 (Delegate): Class for declaring delegates.
17299 * makefile : Update.
17301 * cs-parser.jay (delegate_declaration): Implement.
17303 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17305 * class.cs (Event::Define): Implement.
17306 (Event.EventBuilder): New member.
17308 * class.cs (TypeContainer::Populate): Update to define all enums and events
17310 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17311 readonly fields for all these cases ?
17313 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17315 * class.cs (Property): Revamp to use the convention of making fields readonly.
17316 Accordingly modify code elsewhere.
17318 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17319 the Define method of the Property class.
17321 * class.cs : Clean up applied patch and update references to variables etc. Fix
17323 (TypeContainer::Populate): Update to define all the properties we have. Also
17324 define all enumerations.
17326 * enum.cs (Define): Implement.
17328 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17330 * cs-parser.jay (overloadable_operator): The semantic value is an
17331 enum of the Operator class.
17332 (operator_declarator): Implement actions.
17333 (operator_declaration): Implement.
17335 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17336 validity of definitions.
17337 (Operator::CheckBinaryOperator): Static method to check for binary operators
17338 (TypeContainer::AddOperator): New method to add an operator to a type.
17340 * cs-parser.jay (indexer_declaration): Added line to actually call the
17341 AddIndexer method so it gets added ;-)
17343 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17344 already taken care of by the MS compiler ?
17346 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17348 * class.cs (Operator): New class for operator declarations.
17349 (Operator::OpType): Enum for the various operators.
17351 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17353 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17354 ostensibly handle this in semantic analysis.
17356 * cs-parser.jay (general_catch_clause): Comment out
17357 (specific_catch_clauses, specific_catch_clause): Ditto.
17358 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17359 (catch_args, opt_catch_args): New productions.
17360 (catch_clause): Rewrite to use the new productions above
17361 (catch_clauses): Modify accordingly.
17362 (opt_catch_clauses): New production to use in try_statement
17363 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17364 and re-write the code in the actions to extract the specific and
17365 general catch clauses by being a little smart ;-)
17367 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17368 Hooray, try and catch statements parse fine !
17370 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17372 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17373 string from the hashtable of variables.
17375 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17376 I end up making that mistake ;-)
17377 (catch_clauses): Fixed gross error which made Key and Value of the
17378 DictionaryEntry the same : $1 !!
17380 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17382 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17384 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17385 when the add and remove accessors are specified.
17387 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17389 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17390 information about indexer_declarator.
17391 (indexer_declarator): Implement actions.
17392 (parsing_indexer): New local boolean used to keep track of whether
17393 we are parsing indexers or properties. This is necessary because
17394 implicit_parameters come into picture even for the get accessor in the
17395 case of an indexer.
17396 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17398 * class.cs (Indexer): New class for indexer declarations.
17399 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17400 (TypeContainer::indexers): New member to hold list of indexers for the
17403 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17405 * cs-parser.jay (add_accessor_declaration): Implement action.
17406 (remove_accessor_declaration): Implement action.
17407 (event_accessors_declaration): Implement
17408 (variable_declarators): swap statements for first rule - trivial.
17410 * class.cs (Event): New class to hold information about event
17412 (TypeContainer::AddEvent): New method to add an event to a type
17413 (TypeContainer::events): New member to hold list of events.
17415 * cs-parser.jay (event_declaration): Implement actions.
17417 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17419 * cs-parser.jay (dim_separators): Implement. Make it a string
17420 concatenating all the commas together, just as they appear.
17421 (opt_dim_separators): Modify accordingly
17422 (rank_specifiers): Update accordingly. Basically do the same
17423 thing - instead, collect the brackets here.
17424 (opt_rank_sepcifiers): Modify accordingly.
17425 (array_type): Modify to actually return the complete type string
17426 instead of ignoring the rank_specifiers.
17427 (expression_list): Implement to collect the expressions
17428 (variable_initializer): Implement. We make it a list of expressions
17429 essentially so that we can handle the array_initializer case neatly too.
17430 (variable_initializer_list): Implement.
17431 (array_initializer): Make it a list of variable_initializers
17432 (opt_array_initializer): Modify accordingly.
17434 * expression.cs (New::NType): Add enumeration to help us
17435 keep track of whether we have an object/delegate creation
17436 or an array creation.
17437 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17438 members to hold data about array creation.
17439 (New:New): Modify to update NewType
17440 (New:New): New Overloaded contructor for the array creation
17443 * cs-parser.jay (array_creation_expression): Implement to call
17444 the overloaded New constructor.
17446 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17448 * class.cs (TypeContainer::Constructors): Return member
17449 constructors instead of returning null.
17451 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17453 * typemanager.cs (InitCoreTypes): Initialize the various core
17454 types after we have populated the type manager with the user
17455 defined types (this distinction will be important later while
17456 compiling corlib.dll)
17458 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17459 on Expression Classification. Now all expressions have a method
17460 `Resolve' and a method `Emit'.
17462 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17463 generation from working. Also add some temporary debugging
17466 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17468 * codegen.cs: Lots of code generation pieces. This is only the
17469 beginning, will continue tomorrow with more touches of polish. We
17470 handle the fundamentals of if, while, do, for, return. Others are
17471 trickier and I need to start working on invocations soon.
17473 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17476 * codegen.cs (EmitContext): New struct, used during code
17477 emission to keep a context. Most of the code generation will be
17480 * cs-parser.jay: Add embedded blocks to the list of statements of
17481 this block. So code generation proceeds in a top down fashion.
17483 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17485 * statement.cs: Add support for multiple child blocks.
17487 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17489 * codegen.cs (EmitCode): New function, will emit the code for a
17490 Block of code given a TypeContainer and its ILGenerator.
17492 * statement.cs (Block): Standard public readonly optimization.
17493 (Block::Block constructors): Link children.
17494 (Block::Child): Child Linker.
17495 (Block::EmitVariables): Emits IL variable declarations.
17497 * class.cs: Drop support for MethodGroups here, delay until
17499 (Method::): Applied the same simplification that I did before, and
17500 move from Properties to public readonly fields.
17501 (Method::ParameterTypes): Returns the parameter types for the
17502 function, and implements a cache that will be useful later when I
17503 do error checking and the semantic analysis on the methods is
17505 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17506 and made a method, optional argument tells whether this is a class
17507 or a structure to apply the `has-this' bit.
17508 (Method::GetCallingConvention): Implement, returns the calling
17510 (Method::Define): Defines the type, a second pass is performed
17511 later to populate the methods.
17513 (Constructor::ParameterTypes): implement a cache similar to the
17514 one on Method::ParameterTypes, useful later when we do semantic
17517 (TypeContainer::EmitMethod): New method. Emits methods.
17519 * expression.cs: Removed MethodGroup class from here.
17521 * parameter.cs (Parameters::GetCallingConvention): new method.
17523 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17525 * class.cs (TypeContainer::Populate): Drop RootContext from the
17528 (Constructor::CallingConvention): Returns the calling convention.
17529 (Constructor::ParameterTypes): Returns the constructor parameter
17532 (TypeContainer::AddConstructor): Keep track of default constructor
17533 and the default static constructor.
17535 (Constructor::) Another class that starts using `public readonly'
17536 instead of properties.
17538 (Constructor::IsDefault): Whether this is a default constructor.
17540 (Field::) use readonly public fields instead of properties also.
17542 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17543 track of static constructors; If none is used, turn on
17544 BeforeFieldInit in the TypeAttributes.
17546 * cs-parser.jay (opt_argument_list): now the return can be null
17547 for the cases where there are no arguments.
17549 (constructor_declarator): If there is no implicit `base' or
17550 `this', then invoke the default parent constructor.
17552 * modifiers.cs (MethodAttr): New static function maps a set of
17553 modifiers flags into a MethodAttributes enum
17554 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17555 MethodAttr, TypeAttr to represent the various mappings where the
17556 modifiers are used.
17557 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17559 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17561 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17564 * interface.cs (PopulateIndexer): Implemented the code generator
17565 for interface indexers.
17567 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17569 * interface.cs (InterfaceMemberBase): Now we track the new status
17572 (PopulateProperty): Implement property population. Woohoo! Got
17573 Methods and Properties going today.
17575 Removed all the properties for interfaces, and replaced them with
17576 `public readonly' fields.
17578 2001-08-16 Miguel de Icaza <miguel@ximian.com>
17580 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
17581 initialize their hashtables/arraylists only when they are needed
17582 instead of doing this always.
17584 * parameter.cs: Handle refs and out parameters.
17586 * cs-parser.jay: Use an ArrayList to construct the arguments
17587 instead of the ParameterCollection, and then cast that to a
17590 * parameter.cs: Drop the use of ParameterCollection and use
17591 instead arrays of Parameters.
17593 (GetParameterInfo): Use the Type, not the Name when resolving
17596 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17598 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17599 and instead use public readonly fields.
17601 * class.cs: Put back walking code for type containers.
17603 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17605 * class.cs (MakeConstant): Code to define constants.
17607 * rootcontext.cs (LookupType): New function. Used to locate types
17610 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17612 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17613 this System.Reflection code is. Kudos to Microsoft
17615 * typemanager.cs: Implement a type cache and avoid loading all
17616 types at boot time. Wrap in LookupType the internals. This made
17617 the compiler so much faster. Wow. I rule!
17619 * driver.cs: Make sure we always load mscorlib first (for
17620 debugging purposes, nothing really important).
17622 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
17623 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
17625 * rootcontext.cs: Lookup types on their namespace; Lookup types
17626 on namespaces that have been imported using the `using' keyword.
17628 * class.cs (TypeContainer::TypeAttr): Virtualize.
17629 (Class::TypeAttr): Return attributes suitable for this bad boy.
17630 (Struct::TypeAttr): ditto.
17631 Handle nested classes.
17632 (TypeContainer::) Remove all the type visiting code, it is now
17633 replaced with the rootcontext.cs code
17635 * rootcontext.cs (GetClassBases): Added support for structs.
17637 2001-08-06 Miguel de Icaza <miguel@ximian.com>
17639 * interface.cs, statement.cs, class.cs, parameter.cs,
17640 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
17641 Drop use of TypeRefs, and use strings instead.
17643 2001-08-04 Miguel de Icaza <miguel@ximian.com>
17647 * class.cs (Struct::Struct): set the SEALED flags after
17648 checking the modifiers.
17649 (TypeContainer::TypeAttr): new property, returns the
17650 TypeAttributes for a class.
17652 * cs-parser.jay (type_list): Oops, list production was creating a
17653 new list of base types.
17655 * rootcontext.cs (StdLib): New property.
17656 (GetInterfaceTypeByName): returns an interface by type name, and
17657 encapsulates error handling here.
17658 (GetInterfaces): simplified.
17659 (ResolveTree): Encapsulated all the tree resolution here.
17660 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
17663 * driver.cs: Add support for --nostdlib, to avoid loading the
17664 default assemblies.
17665 (Main): Do not put tree resolution here.
17667 * rootcontext.cs: Beginning of the class resolution.
17669 2001-08-03 Miguel de Icaza <miguel@ximian.com>
17671 * rootcontext.cs: Provide better error reporting.
17673 * cs-parser.jay (interface_base): set our $$ to be interfaces.
17675 * rootcontext.cs (CreateInterface): Handle the case where there
17676 are no parent interfaces.
17678 (CloseTypes): Routine to flush types at the end.
17679 (CreateInterface): Track types.
17680 (GetInterfaces): Returns an array of Types from the list of
17681 defined interfaces.
17683 * typemanager.c (AddUserType): Mechanism to track user types (puts
17684 the type on the global type hash, and allows us to close it at the
17687 2001-08-02 Miguel de Icaza <miguel@ximian.com>
17689 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
17690 RecordInterface instead.
17692 * cs-parser.jay: Updated to reflect changes above.
17694 * decl.cs (Definition): Keep track of the TypeBuilder type that
17695 represents this type here. Not sure we will use it in the long
17696 run, but wont hurt for now.
17698 * driver.cs: Smaller changes to accomodate the new code.
17700 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
17703 * rootcontext.cs (CreateInterface): New method, used to create
17704 the System.TypeBuilder type for interfaces.
17705 (ResolveInterfaces): new entry point to resolve the interface
17707 (CodeGen): Property, used to keep track of the code generator.
17709 2001-07-26 Miguel de Icaza <miguel@ximian.com>
17711 * cs-parser.jay: Add a second production for delegate_declaration
17714 (enum_body): Put an opt_comma here instead of putting it on
17715 enum_body or enum_member_declarations so we can handle trailing
17716 commas on enumeration members. Gets rid of a shift/reduce.
17718 (type_list): Need a COMMA in the middle.
17720 (indexer_declaration): Tell tokenizer to recognize get/set
17722 * Remove old targets.
17724 * Re-add the parser target.
17726 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17728 * cs-parser.jay: Add precendence rules for a number of operators
17729 ot reduce the number of shift/reduce conflicts in the grammar.
17731 2001-07-17 Miguel de Icaza <miguel@ximian.com>
17733 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
17736 Get rid of old crufty code.
17738 * rootcontext.cs: Use this to keep track of the parsed
17739 representation and the defined types available to the program.
17741 * gen-treedump.cs: adjust for new convention.
17743 * type.cs: Split out the type manager, and the assembly builder
17746 * typemanager.cs: the type manager will live here now.
17748 * cil-codegen.cs: And the code generator here.
17750 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
17752 * makefile: Fixed up for easy making.
17754 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17756 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
17759 (unary_expression): Expand pre_increment_expression and
17760 post_decrement_expression to reduce a shift/reduce.
17762 2001-07-11 Simon Cozens
17764 * cs-tokenizer.cs: Hex numbers should begin with a 0.
17766 Improve allow_keyword_as_indent name.
17768 2001-06-19 Miguel de Icaza <miguel@ximian.com>
17770 * Adjustments for Beta2.
17772 2001-06-13 Miguel de Icaza <miguel@ximian.com>
17774 * decl.cs: Added `Define' abstract method.
17775 (InTransit): new property, used to catch recursive definitions.
17777 * interface.cs: Implement `Define'.
17779 * modifiers.cs: Map Modifiers.constants to
17780 System.Reflection.TypeAttribute flags.
17782 * class.cs: Keep track of types and user-defined types.
17783 (BuilderInit): New method for creating an assembly
17784 (ResolveType): New function to launch the resolution process, only
17785 used by interfaces for now.
17787 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
17788 that are inserted into the name space.
17790 2001-06-08 Miguel de Icaza <miguel@ximian.com>
17792 * ARGH. I have screwed up my tree so many times due to the use of
17793 rsync rather than using CVS. Going to fix this at once.
17795 * driver.cs: Objetify driver. Load assemblies, use assemblies to
17798 2001-06-07 Miguel de Icaza <miguel@ximian.com>
17800 * Experiment successful: Use System.Type rather that our own
17803 2001-05-25 Miguel de Icaza <miguel@ximian.com>
17805 * cs-parser.jay: Removed nsAliases from here.
17807 Use new namespaces, handle `using XXX;'
17809 * namespace.cs: Reimplemented namespace handling, use a recursive
17810 definition of the class. Now we can keep track of using clauses
17811 and catch invalid using clauses.
17813 2001-05-24 Miguel de Icaza <miguel@ximian.com>
17815 * gen-treedump.cs: Adapted for all the renaming.
17817 * expression.cs (Expression): this class now has a Type property
17818 which returns an expression Type.
17820 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
17821 `Type', as this has a different meaning now in the base
17823 2001-05-22 Miguel de Icaza <miguel@ximian.com>
17825 * interface.cs, class.cs: Removed from all the sources the
17826 references to signature computation, as we can not do method
17827 signature computation during the parsing time, as we are not
17828 trying to solve at that point distinguishing:
17832 void a (NS.Blah x) {}
17835 Which depending on the context might be valid or not, as we do not
17836 know if Blah is the same thing as NS.Blah at that point.
17838 * Redid everything so the code uses TypeRefs now instead of
17839 Types. TypeRefs are just temporary type placeholders, that need
17840 to be resolved. They initially have a pointer to a string and the
17841 current scope in which they are used. This is used later by the
17842 compiler to resolve the reference to an actual Type.
17844 * DeclSpace is no longer a CIR.Type, and neither are
17845 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
17846 are all DeclSpaces, but no Types.
17848 * type.cs (TypeRefManager): This implements the TypeRef manager,
17849 which keeps track of all the types that need to be resolved after
17850 the parsing has finished.
17852 2001-05-13 Miguel de Icaza <miguel@ximian.com>
17854 * ARGH. We are going to have to store `foreach' as a class rather
17855 than resolving it, as we need to verify error 1579 after name
17856 resolution. *OR* we could keep a flag that says `This request to
17857 IEnumerator comes from a foreach statement' which we can then use
17858 to generate the error.
17860 2001-05-10 Miguel de Icaza <miguel@ximian.com>
17862 * class.cs (TypeContainer.AddMethod): we now add methods to the
17863 MethodGroup instead of the method hashtable.
17865 * expression.cs: Add MethodGroup abstraction, which gets us one
17866 step closer to the specification in the way we handle method
17869 * cs-parser.jay (primary_expression): qualified_identifier now
17870 tried to match up an identifier to a local variable reference or
17871 to a parameter reference.
17873 current_local_parameters is now a parser global variable that
17874 points to the current parameters for the block, used during name
17877 (property_declaration): Now creates an implicit `value' argument to
17880 2001-05-09 Miguel de Icaza <miguel@ximian.com>
17882 * parameter.cs: Do not use `param' arguments as part of the
17883 signature, per the spec.
17885 2001-05-08 Miguel de Icaza <miguel@ximian.com>
17887 * decl.cs: Base class for classes, structs and interfaces. This
17888 is the "Declaration Space"
17890 * cs-parser.jay: Use CheckDef for checking declaration errors
17891 instead of having one on each function.
17893 * class.cs: Factor out some code for handling error handling in
17894 accordance to the "Declarations" section in the "Basic Concepts"
17895 chapter in the ECMA C# spec.
17897 * interface.cs: Make all interface member classes derive from
17898 InterfaceMemberBase.
17900 2001-05-07 Miguel de Icaza <miguel@ximian.com>
17902 * Many things: all interfaces are parsed and generated in
17903 gen-treedump. Support for member variables, constructors,
17904 destructors, properties, constants is there.
17906 Beginning of the IL backend, but very little done, just there for
17909 2001-04-29 Miguel de Icaza <miguel@ximian.com>
17911 * cs-parser.jay: Fix labeled statement.
17913 * cs-tokenizer.cs (escape): Escape " and ' always.
17914 ref_line, ref_name: keep track of the line/filename as instructed
17915 by #line by the compiler.
17918 2001-04-27 Miguel de Icaza <miguel@ximian.com>
17920 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
17921 to match the values in System.CodeDOM.
17923 Divid renamed to Divide.
17925 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
17927 (Statements.set): remove.
17929 * System.CodeDOM/CodeCatchClause.cs: always have a valid
17932 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
17933 falseStatements always have valid values.
17935 * cs-parser.jay: Use System.CodeDOM now.