1 2005-01-06 Raja R Harinath <rharinath@novell.com>
3 * decl.cs (DeclSpace.ResolveType): Remove.
4 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
6 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
7 * class.cs, enum.cs: Update to changes.
9 2005-01-06 Miguel de Icaza <miguel@ximian.com>
11 * anonymous.cs: Ensure that we init the scope of our parent if it
12 has not been initialized yet.
14 2004-12-30 Duncan Mak <duncan@ximian.com>
16 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
17 if field.FieldBuilder is null. Fixes #70758.
19 * convert.cs: Fixed some typos and updated some of the comments.
20 (ImplicitStandardConversionExists):
21 (TryImplicitIntConversion): If `target_type' is an interface and
22 the type of `ic' implements this interface, return true or a new
23 BoxedCast instead of null. This fixes #70468.
25 2004-12-29 Duncan Mak <duncan@ximian.com>
27 * expression.cs (Argument.Emit): Check that Expr is
28 IMemoryLocation before casting to it, and report CS1510 otherwise.
32 2004-12-21 Ben Maurer <bmaurer@ximian.com>
34 * statement.cs (Block.ThisVariable): remove the recursion here, to
35 make the --profile more sane.
37 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
39 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
40 assembly, by JB Evain.
42 2004-12-17 Raja R Harinath <rharinath@novell.com>
44 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
45 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
46 "parent" refers to enclosing type/class. "base" refers to superclass.
48 2004-12-17 Raja R Harinath <rharinath@novell.com>
50 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
51 Ensure that we only have GlobalAttributes.
52 * attribute.cs (Attribute.Emit): Make non-virtual.
53 (GlobalAttribute.Emit): Remove.
54 (Attribute.Resolve): Make virtual.
55 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
56 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
57 the argument. Don't create one.
58 (Attribute.GetObsoleteAttribute): Likewise.
59 (Attribute.GetClsCompliantAttributeValue): Likewise.
60 * class.cs, decl.cs: Update to changes.
62 2004-12-17 Marek Safar <marek.safar@seznam.cz>
64 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
66 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
68 * statement.cs (Foreach.Resolve): Add error 186 report.
70 2004-12-16 Marek Safar <marek.safar@seznam.cz>
72 * expression.cs (Conditional.DoResolve): Add warning 429.
74 * statement.cs (If.Resolve): Add warning 665.
76 2004-12-16 Raja R Harinath <rharinath@novell.com>
78 New invariant: RootContext.Tree.Types.NamespaceEntry == null
79 except when in the parser, and in GlobalAttribute.
80 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
81 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
82 RootContext.Tree.Types.NamespaceEntry once work is done.
83 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
84 and resets RootContext.Tree.Types.NamespaceEntry.
86 2004-12-15 Marek Safar <marek.safar@seznam.cz>
88 * cs-parser.jay: Don't create a block for every variable.
90 2004-12-14 Miguel de Icaza <miguel@ximian.com>
92 * location.cs: Provide extra information.
94 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
95 variables from the captured environment, it is the ldarg_0.
97 2004-12-14 Marek Safar <marek.safar@seznam.cz>
99 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
102 * class.cs: Changed warning level for 169 to avoid developer
103 displeasure from warning flooding. It will be changed back when they
104 fix most of current BCL warnings.
106 * RootContext.cs: Pushed default WarningLevel to 3.
108 * statement.cs: Removed unused variable.
110 2004-12-14 Marek Safar <marek.safar@seznam.cz>
112 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
113 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
114 Add error 502 report.
115 (StaticClass.DefineType): Add error 441 report.
116 (Class.AllowedModifiersProp): New virtual property as temporary
117 extension to AllowedModifiers.
118 (Class.DefineType): Add error 418 report. Moved ModFlags check here
119 to share implementation with StaticClass and don't call virtual
122 * driver.cs (MainDriver): Add error 1558 test.
124 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
125 report. Moved error 36 test here.
127 * statement.cs (Throw.Resolve): Add error 724 report.
129 * typemanager.cs: Add out_attribute_type core type.
131 2004-12-13 Marek Safar <marek.safar@seznam.cz>
133 * class.cs (TypeContainer.VerifyClsCompliance): Add error
135 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
137 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
140 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
142 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
143 Add error 3023 report.
144 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
146 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
149 2004-12-12 John Luke <john.luke@gmail.com>
151 * driver.cs (AddArgs): take -- into account when
152 adding arguments, fixes bug 65710
154 2004-12-12 Martin Baulig <martin@ximian.com>
156 * expression.cs (Unary.TryReduceNegative): Added support for
157 SByteConstant and ByteConstant.
158 (Unary.Reduce): Check error values from TryReduceNegative().
160 2004-12-10 Marek Safar <marek.safar@seznam.cz>
162 * attributes.cs (Attribute.Resolve): Avoid multiple error report
163 and report exception as error 182.
165 2004-12-10 Raja R Harinath <rharinath@novell.com>
167 * driver.cs (Main): Fix message when there are warnings.
169 2004-12-09 Miguel de Icaza <miguel@ximian.com>
171 * delegate.cs: Fixed my fix from yesterday, sorry about that.
173 2004-12-09 Marek Safar <marek.safar@seznam.cz>
175 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
176 Reduced number of warnings.
178 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
180 2004-12-08 Miguel de Icaza <miguel@ximian.com>
182 * driver.cs: Removed message.
184 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
186 2004-12-08 <vargaz@freemail.hu>
188 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
190 2004-12-08 Martin Baulig <martin@ximian.com>
192 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
193 instead of a CS3002 for properties and indexer.
195 2004-12-08 Martin Baulig <martin@ximian.com>
197 * decl.cs (MemberName.ToString): Make this work again.
199 2004-12-08 Marek Safar <marek.safar@seznam.cz>
201 * attribute.cs (Resolve): Add error 591 detection.
203 * class.cs (FieldMember.Define): Add error 1547 detection.
204 (Indexer.Define): Add error 620 detection.
205 (Operator.Define): Add error 590 detection.
207 * ecore.cs: Missing argument for error 79.
209 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
212 2004-12-07 Marek Safar <marek.safar@seznam.cz>
215 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
218 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
220 * cs-parser.jay : handle doc comments on implicit/explicit operators.
221 Some operator comments were suppressed.
222 * doc.cs : Implicit/explicit operator name in doc comments are like
223 "op_Explicit(type)~returnType", so added suffix handling.
225 2004-12-07 Martin Baulig <martin@ximian.com>
228 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
229 (MemberCore.GetClsCompliantAttributeValue): Likewise.
230 (DeclSpace.ec): New protected field; store the EmitContext here.
231 (DeclSpace.EmitContext): New public property; moved here from
233 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
236 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
237 (Enum.Emit): Don't create a new EmitContext.
239 * delegate.cs (Delegate.DefineType): Always create the
242 * iterators.cs (Iterators.DefineIterator): Create a new
243 EmitContext and store it in `ec'.
245 2004-08-24 Martin Baulig <martin@ximian.com>
248 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
249 this for accessibility checks.
250 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
251 IsNestedFamilyAccessible.
252 (TypeManager.IsSubclassOf): New method, do what the name actually
255 2004-12-06 Raja R Harinath <rharinath@novell.com>
257 Fix crash on cs0657-17.cs.
258 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
259 Use RootContext.Tree.Types, not 'new RootTypes ()'.
260 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
261 the case where the NamespaceEntry gets overwritten.
263 2004-12-06 Marek Safar <marek.safar@seznam.cz>
266 * ecore.cs (ResolveBoolean): Tiny refactoring.
268 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
269 of right expression resolving when left is false constant and
270 operator is LogicalAnd OR true constant and operator is LogicalOr.
272 * statement.cs (ResolveUnreachable): Always reports warning.
274 2004-12-05 Miguel de Icaza <miguel@ximian.com>
276 * class.cs: Distinguish between 1721 and 1722 (just a little help
279 2004-12-03 Miguel de Icaza <miguel@ximian.com>
281 * delegate.cs: Only allow this on new versions of the language.
283 2004-12-02 Duncan Mak <duncan@ximian.com>
285 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
287 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
288 here as a static method. Take an additional bool out parameter
289 `must_do_cs1540_check' for signaling to InstanceResolve.
290 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
291 member field from PropertyExpr class and made it an argument of
293 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
294 check for MarshalByRefObject, and report CS0122 instead of CS1540.
295 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
296 and `remove_accessor' as well as InstanceResolve: report CS0122
301 2004-12-03 Raja R Harinath <rharinath@novell.com>
303 Fix test-327.cs, test-328.cs, and put in early infrastructure
304 for eventually fixing #52697.
305 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
306 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
308 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
309 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
310 (VerifyUsing, error246): Update.
311 * rootcontext.cs (RootContext.NamespaceLookup): Just use
312 'NamespaceEntry.LookupNamespaceOrType'.
314 2004-12-03 Martin Baulig <martin@ximian.com>
316 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
317 method as our child, call AnonymousMethod.Compatible() on it.
319 2004-12-03 Raja R Harinath <rharinath@novell.com>
321 Disable XML documentation support in 'basic' profile.
322 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
323 Redirect XmlElement to System.Object.
324 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
325 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
326 * mcs.exe.sources: Add doc-bootstrap.cs.
327 * doc-bootstrap.cs: New file. Contains empty stub implementation
330 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
332 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
333 comments are allowed.
335 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
337 * delegate.cs: Add checks for subtypes in paramaters and return values
338 in VerifyMethod () to add support for Covariance/Contravariance
341 2004-12-02 Miguel de Icaza <miguel@ximian.com>
343 * report.cs: Remove extra closing parenthesis.
345 * convert.cs (Error_CannotImplicitConversion): If the name of the
346 types are the same, provide some extra information.
348 * class.cs (FieldBase): Use an unused bit field from the field to
349 encode the `has_offset' property from the FieldMember. This saves
350 a couple of Ks on bootstrap compilation.
352 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
353 method as our child, return the AnonymousMethod resolved
356 * expression.cs (New.DoResolve): Allow return values from
357 NewDelegate to also include AnonymousMethods.
361 2004-12-02 Marek Safar <marek.safar@seznam.cz>
364 * attribute.cs (Resolve): Improved implementation of params
367 * support.cs (ParameterData): Add HasParams to be faster.
369 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
371 all things are for /doc support:
373 * doc.cs: new file that supports XML documentation generation.
374 * mcs.exe.sources: added doc.cs.
376 Handle /doc command line option.
377 Report error 2006 instead of 5 for missing file name for /doc.
378 Generate XML documentation when required, after type resolution.
380 Added support for picking up documentation (/// and /** ... */),
381 including a new XmlCommentState enumeration.
383 Added lines to fill Documentation element for field, constant,
384 property, indexer, method, constructor, destructor, operator, event
385 and class, struct, interface, delegate, enum.
386 Added lines to warn incorrect comment.
388 Added Documentation field (passed only when /doc was specified).
390 Added DocComment, DocCommentHeader, GenerateDocComment() and
391 OnGenerateDocComment() and some supporting private members for
392 /doc feature to MemberCore.
394 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
396 Added overriden DocCommentHeader.
398 Added overriden DocCommentHeader and GenerateDocComment().
400 2004-12-01 Miguel de Icaza <miguel@ximian.com>
402 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
403 unwrapping the enumeration values, chain to
404 DoConstantNumericPromotions again, so we can promote things to the
405 fundamental types (takes care of enums that are bytes, sbytes).
409 2004-12-01 Raja R Harinath <rharinath@novell.com>
411 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
412 Fix long-standing bug in type-lookup. Use FindType instead of
413 LookupType when ec.ResolvingTypeTree.
414 (Attribute.ResolveType, Attribute.Resolve)
415 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
417 (Attributes.Search): Remove internal version. Update.
418 (Attributes.SearchMulti): Update.
419 (Attributes.GetClsCompliantAttribute): Remove.
420 (Attributes.GetIndexerNameAttribute): Remove.
421 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
422 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
423 * class.cs (Indexer.Define): Likewise.
425 2004-12-01 Marek Safar <marek.safar@seznam.cz>
428 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
429 MarshallByReference members access.
431 * expression.cs: Use CheckMarshallByRefAccess;
432 Better error CS0197 message.
434 * report.cs: Print whole related error message.
436 2004-11-30 Raja R Harinath <rharinath@novell.com>
438 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
439 the current directory to help debugging.
441 2004-11-29 Marek Safar <marek.safar@seznam.cz>
443 * class (GetClassBases): Better error 60 report.
444 (EventProperty): Disabled warning 67 detection.
446 2004-11-29 Marek Safar <marek.safar@seznam.cz>
449 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
451 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
454 2004-11-29 Marek Safar <marek.safar@seznam.cz>
457 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
459 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
461 2004-11-26 Miguel de Icaza <miguel@ximian.com>
463 * attribute.cs (Attribute.Resolve): Refine error reporting and
464 report a cs0117 if the identifier does not exist, to distinguish
465 from 0617 which is a miss-use of the actual identifier.
467 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
468 between cs0070 and cs0079.
470 * class.cs (MemberBase.DoDefine): When reporting a wrong
471 accessibility level, we use MethodCore to compare instead of
472 Method (this was a regression in some refactoring effort).
474 So now we correctly report cs0056 again.
476 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
477 testing the target_type (which was known to be object_type) and
478 not the source type (which is anonymous_method).
480 Fixed reporting of error cs1660.
482 * expression.cs (UserCast.Source): Expose the underlying cast.
484 * statement.cs (Switch.SwitchGoverningType): Sort the list of
485 allowed types to find a match to int32 first (most common).
487 In addition, it ignores any ImplicitUserConversions that did an
488 internal implicit conversion (as the switch statement allows only
489 one integral conversion to exist).
491 * class.cs (PartialContainer.Create): rename `name' to
492 `member_name' for clarity. Then replace the string calls with a
493 call to MemberName.GetPartialName, as now using
494 MemberName.ToString is an error (this is due to the side effects
495 it had, that were fixed in the past).
497 This will restore the error reporting on a number of partial class
498 errors that were missusing this (and getting an exception as a
499 results, which is now just a plain textual warning, because
500 yyparse debug output would crash otherwise).
502 2004-11-26 Raja R Harinath <rharinath@novell.com>
504 * Makefile (PROGRAM_INSTALL_DIR): Remove.
506 2004-11-25 Ben Maurer <bmaurer@ximian.com>
508 * rootcontext.cs (LookupType): Make sure to cache lookups that
509 don't give us a negative result. This saves about 5% of corlib
512 2004-11-25 Miguel de Icaza <miguel@ximian.com>
514 * report.cs (AbstractMessage.Print): messages are sent to stderr
516 * class.cs (TypeContainer.GetClassBases): It is an error to have a
517 non-interface in the list of interfaces (at this point, either
518 parent was properly set, or a base class is being listed in the
521 This flags error 1722, and resolves the crash from bug 69259.
523 2004-11-25 Ben Maurer <bmaurer@ximian.com>
525 * statement.cs (Using.EmitExpressionFinally): make this work right
526 for valuetypes. Fixes 69926.
528 2004-11-25 Miguel de Icaza <miguel@ximian.com>
530 * const.cs (Const.ChangeType): Cope with the "0 literal can be
531 converted to an enum" here, before we try to change the underlying
532 type. This code exists, but it is a different code path than the
533 one used while encoding constants.
535 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
536 old bug: when converting from the null literal to a pointer,
537 return an EmptyCast, not the NullLiteral.
539 This fixes #69921, the recent null_type changes probably made this
542 (ImplicitReferenceConversionExists): In addition, resynchronized
543 the code here, so it matches the same code in
544 ImplicitReferenceConversionExists for the `from any class-type S
545 to any interface-type T'.
548 2004-11-25 Marek Safar <marek.safar@seznam.cz>
550 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
552 2004-11-24 Miguel de Icaza <miguel@ximian.com>
554 * cs-parser.jay: Use verbosity accordingly.
556 2004-11-24 Marek Safar <marek.safar@seznam.cz>
558 * expression.cs (Unary.ResolveOperator): Do not report warning;
559 AddressOf reads from variable.
561 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
563 2004-11-24 Marek Safar <marek.safar@seznam.cz>
567 * attribute.cs (Attributable): Removed CheckTargets.
568 (Attributes.Emit): Explicit attribute targets are tested here.
570 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
571 not enabled for interfaces.
573 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
574 (GetAssemblyName): Ouch next bug there.
576 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
578 * expression.cs: Error 275 added.
580 2004-11-23 Marek Safar <marek.safar@seznam.cz>
582 Fix bug #69177 (Implemented decimal constant support)
584 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
585 (BinaryFold): Add DecimalConstant.
587 * const.cs (Define): Decimal constant
589 (ChangeType): Add decimal type handling.
590 (LookupConstantValue): Don't set value for decimal type but
591 emit DecimalConstantAttribute. Needed for constant optimization.
593 * constant.cs (ToDecimal): New method.
594 (ConvertToDecimal): New method.
595 (IntConstant): Implemented ConvertToDecimal.
596 (DecimalConstant.Emit): Emit optimized version for decimals in
599 * expression.cs (ResolveOperator): Changed order of constant
600 reduction to work correctly with native types which have
601 overloaded operators.
602 (ResolveMemberAccess): Extract constant value from attribute
605 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
607 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
608 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
609 (ChangeType): Decimal is special.
610 (TypeToCoreType): Add decimal type.
612 2004-11-22 Marek Safar <marek.safar@seznam.cz>
614 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
617 2004-11-22 Marek Safar <marek.safar@seznam.cz>
619 * class.cs (EventField.ApplyAttributeBuilder): Fix error
622 2004-11-19 Marek Safar <marek.safar@seznam.cz>
624 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
626 * pending.cs (PendingImplementation): Grab only interfaces.
628 2004-11-19 Marek Safar <marek.safar@seznam.cz>
630 * statement.cs (ForeachHelperMethods): Add location member and
633 2004-11-19 Raja R Harinath <rharinath@novell.com>
635 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
636 automatically handled by executable.make.
637 (PROGRAM): Make profile-specific.
639 2004-11-18 Marek Safar <marek.safar@seznam.cz>
641 * expression.cs (DoResolveBase): Fixed wrong warning for out
644 2004-11-18 Martin Baulig <martin@ximian.com>
646 Merged latest changes into gmcs. Please keep this comment in
647 here, it makes it easier for me to see what changed in MCS since
648 the last time I merged.
650 2004-11-17 Raja R Harinath <rharinath@novell.com>
652 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
653 (TypeHandle.GetMemberCache): New.
654 (TypeHandle.TypeHandle): Update.
655 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
656 (TypeManager.LookupParentInterfacesCache):
657 Rename from LookupInterfaceCache. Optimize slightly.
658 (TypeManager.MemberLookup_FindMembers): Update.
659 * decl.cs (MemberCache.MemberCache): Set Container to null in the
661 (AddCacheContents): Rename from AddHashtable.
662 * class.cs (TypeContainer.parent_container): Remove.
663 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
664 (TypeContainer.DoDefineMembers): Don't initialize it.
665 Update to name changes.
667 2004-11-17 Miguel de Icaza <miguel@ximian.com>
669 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
670 that factors the code to check access modifiers on override.
672 (PropertyBase): Use the code here.
674 Patch from Lluis S'anchez, fixes bug #69361.
676 2004-11-15 Miguel de Icaza <miguel@ximian.com>
678 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
679 routine that is used to report the use of a captured variable
680 whose address has been taken.
682 There are two checks: one when variables are being captured and
683 the other check is when the address of a variable is taken.
685 (because an anonymous methods might be resolved before *or* after
686 the address has been taken) and
688 * expression.cs (Conditional.DoResolve): Remove the special
689 casing that Martin added to trueExpr and falseExpr being both
690 NullLiteral. We get the right behavior now just by introducing
691 the null_type into the compiler.
693 * convert.cs (ExplicitConversion): Change the code to use
694 null_type instead of testing `expr is NullLiteral'.
695 (ImplicitConversionStandard): use null_type too.
696 (ImplicitReferenceConversionExists): use null_type too.
697 (ImplicitReferenceConversion): use null_type too.
699 * literal.cs: The type of `NullLiteral' is now null_type instead
701 (Resolve): Set the type here.
703 * typemanager.cs: Introduce null_type.
705 2004-11-17 Martin Baulig <martin@ximian.com>
707 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
708 direction, like FindMembers() does. Fixes #69546, testcase is in
711 2004-11-16 Martin Baulig <martin@ximian.com>
713 This is based on a patch from Marek Safar, see bug #69082.
714 Fixes bugs #63705 and #67130.
716 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
717 method; create a MemberCache for an interface type and cache the
720 * decl.cs (IMemberContainer.ParentContainer): Removed.
721 (IMemberContainer.ParentCache): New property.
722 (MemberCache.SetupCacheForInterface): Removed.
723 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
724 to create a cache for an interface's "parent".
726 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
729 2004-11-16 Martin Baulig <martin@ximian.com>
731 Merged back from gmcs; these changes already went into gmcs a
735 (TypeManager.AddUserType): Removed the `ifaces' argument.
736 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
738 (TypeManager.AddUserInterface): Removed.
739 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
741 (TypeManager.GetInterfaces): Likewise.
742 (TypeManager.GetExplicitInterfaces): Likewise.
744 * ecore.cs (TypeExpr.GetInterfaces): Removed.
746 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
747 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
749 2004-11-14 Ben Maurer <bmaurer@ximian.com>
751 * statement.cs: Avoid adding bools to a hashtable.
753 2004-11-07 Miguel de Icaza <miguel@ximian.com>
755 * expression.cs (Invocation.OverloadResolve): Flag error if we are
756 calling an unsafe method from a safe location.
758 2004-11-06 Marek Safar <marek.safar@seznam.cz>
761 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
763 2004-11-06 Miguel de Icaza <miguel@ximian.com>
765 * namespace.cs (VerifyUsing): use GetPartialName instead of
768 2004-11-05 Miguel de Icaza <miguel@ximian.com>
770 * statement.cs (Return.Resolve): Fix regression in typo: if
771 `in_exc', we have to request a NeedReturnLabel, this was a typo
772 introduced in the anonymous method check-in. Fixes #69131.
774 * Indexers were using the ShortName when defining themselves,
775 causing a regression in the compiler bootstrap when applying the
776 patch from 2004-11-02 (first part), now they use their full name
779 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
781 * driver.cs: Strip the path from the names of embedded resources. Fixes
784 2004-11-04 Raja R Harinath <rharinath@novell.com>
786 Fix error message regression: cs0104-2.cs.
787 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
788 (AliasEntry.Resolve): Update.
789 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
791 (RootContext.LookupType): Update.
793 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
795 * cs-parser.jay: Add support for handling accessor modifiers
796 * class: Add support port accessor modifiers and error checking,
797 define PropertyMethod.Define as virtual (not abstract anymore)
798 * ecore.cs: Add checking for proeprties access with access modifiers
799 * iterators.cs: Modify Accessor constructor call based in the modified
801 2004-11-02 Ben Maurer <bmaurer@ximian.com>
803 * expression.cs (StringConcat): Handle being called twice,
804 as when we have a concat in a field init with more than two
807 2004-11-02 Miguel de Icaza <miguel@ximian.com>
809 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
810 special case explicit implementations, we should always produce
811 the .property or .event declaration.
813 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
814 since it will not return correct data if people use this
815 unresolved in the presence of using statements (see test-313).
817 * class.cs (MethodData.Define): If we are an explicit interface
818 implementation, set the method name to the full name of the
819 interface plus the name of the method.
821 Notice that using the method.MethodName.GetFullName() does not
822 work, as it will only contain the name as declared on the source
823 file (it can be a shorthand in the presence of using statements)
824 and not the fully qualifed type name, for example:
828 class D : ICloneable {
829 object ICloneable.Clone () {
833 Would produce a method called `ICloneable.Clone' instead of
834 `System.ICloneable.Clone'.
836 * namespace.cs (Alias.Resolve): Use GetPartialName.
838 2004-11-01 Marek Safar <marek.safar@seznam.cz>
840 * cs-parser.jay: Add error 1055 report.
842 2004-11-01 Miguel de Icaza <miguel@ximian.com>
844 * assign.cs (Assign.DoResolve): Only do the transform of
845 assignment into a New if the types are compatible, if not, fall
846 through and let the implicit code deal with the errors and with
847 the necessary conversions.
849 2004-11-01 Marek Safar <marek.safar@seznam.cz>
851 * cs-parser.jay: Add error 1031 report.
853 * cs-tokenizer.cs: Add location for error 1038.
855 2004-10-31 Marek Safar <marek.safar@seznam.cz>
857 * cs-parser.jay: Add error 1016 report.
859 2004-10-31 Marek Safar <marek.safar@seznam.cz>
861 * cs-parser.jay: Add errors 1575,1611 report.
863 2004-10-31 Marek Safar <marek.safar@seznam.cz>
865 * cs-parser.jay: Add error 1001 report.
867 2004-10-31 Marek Safar <marek.safar@seznam.cz>
870 * attribute.cs (GetMarshal): Add method argument for
871 caller identification.
873 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
874 agument for GetMarshal and RuntimeMissingSupport.
876 2004-10-31 Marek Safar <marek.safar@seznam.cz>
878 * attribute.cs (ExtractSecurityPermissionSet): Removed
879 TypeManager.code_access_permission_type.
881 * typemanager.cs: Removed TypeManager.code_access_permission_type.
883 2004-10-27 Miguel de Icaza <miguel@ximian.com>
885 * expression.cs (LocalVariableReference.DoResolveLValue): Check
886 for obsolete use of a variable here. Fixes regression on errors
887 cs0619-25 and cs0619-26.
889 2004-10-27 Marek Safar <marek.safar@seznam.cz>
891 Fix #62358, implemented security attribute encoding.
893 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
894 Tests permitted SecurityAction for assembly or other types.
895 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
896 data from SecurityPermissionAttribute to PermisionSet class.
898 * class.cs (ApplyAttributeBuilder): Added special handling
899 for System.Security.Permissions.SecurityAttribute based types.
901 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
902 special handling for System.Security.Permissions.SecurityAttribute
905 * enum.cs (ApplyAttributeBuilder): Added special handling
906 for System.Security.Permissions.SecurityAttribute based types.
908 * parameter.cs (ApplyAttributeBuilder): Added special handling
909 for System.Security.Permissions.SecurityAttribute based types.
911 * rootcontext.cs: Next 2 core types.
913 * typemanager.cs (TypeManager.security_permission_attr_type):
914 Built in type for the SecurityPermission Attribute.
915 (code_access_permission_type): Build in type.
917 2004-10-17 Miguel de Icaza <miguel@ximian.com>
919 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
920 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
921 all of this information into
922 EmitContext.EmitCapturedVariableInstance.
924 * codegen.cs (EmitCapturedVariableInstance): move here the
925 funcionality of emitting an ldarg.0 in the presence of a
926 remapping. This centralizes the instance emit code.
928 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
929 then emit a load of this: it means that we have reached the
930 topmost ScopeInfo: the one that contains the pointer to the
931 instance of the class hosting the anonymous method.
933 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
934 captures to the topmost CaptureContext.
936 2004-10-12 Miguel de Icaza <miguel@ximian.com>
938 * expression.cs (LocalVariableReference): Move the knowledge about
939 the iterators into codegen's EmitCapturedVariableInstance.
941 2004-10-11 Miguel de Icaza <miguel@ximian.com>
943 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
944 all code paths return a value from an anonymous method (it is the
945 same as the 161 error, but for anonymous methods).
947 2004-10-08 Miguel de Icaza <miguel@ximian.com>
949 The introduction of anonymous methods in the compiler changed
950 various ways of doing things in the compiler. The most
951 significant one is the hard split between the resolution phase
952 and the emission phases of the compiler.
954 For instance, routines that referenced local variables no
955 longer can safely create temporary variables during the
956 resolution phase: they must do so from the emission phase,
957 since the variable might have been "captured", hence access to
958 it can not be done with the local-variable operations from the runtime.
962 (Block.Flags): New flag `IsTopLevel' to indicate that this block
965 (ToplevelBlock): A new kind of Block, these are the blocks that
966 are created by the parser for all toplevel method bodies. These
967 include methods, accessors and anonymous methods.
969 These contain some extra information not found in regular blocks:
970 A pointer to an optional CaptureContext (for tracking captured
971 local variables and parameters). A pointer to the parent
974 (Return.Resolve): Catch missmatches when returning a value from an
975 anonymous method (error 1662).
976 Invoke NeedReturnLabel from the Resolve phase instead of the emit
979 (Break.Resolve): ditto.
981 (SwitchLabel): instead of defining the labels during the
982 resolution phase, we now turned the public ILLabel and ILLabelCode
983 labels into methods called GetILLabelCode() and GetILLabel() that
984 only define the label during the Emit phase.
986 (GotoCase): Track the SwitchLabel instead of the computed label
987 (its contained therein). Emit the code by using
988 SwitchLabel.GetILLabelCode ().
990 (LocalInfo.Flags.Captured): A new flag has been introduce to track
991 whether the Local has been captured or not.
993 (LocalInfo.IsCaptured): New property, used to tell whether the
994 local has been captured.
996 * anonymous.cs: Vastly updated to contain the anonymous method
999 The main classes here are: CaptureContext which tracks any
1000 captured information for a toplevel block and ScopeInfo used to
1001 track the activation frames for various local variables.
1003 Each toplevel block has an optional capture context associated
1004 with it. When a method contains an anonymous method both the
1005 toplevel method and the anonymous method will create a capture
1006 context. When variables or parameters are captured, they are
1007 recorded on the CaptureContext that owns them, for example:
1011 MyDelegate d = delegate {
1016 Here `a' will be recorded as captured on the toplevel
1017 CapturedContext, the inner captured context will not have anything
1018 (it will only have data if local variables or parameters from it
1019 are captured in a nested anonymous method.
1021 The ScopeInfo is used to track the activation frames for local
1022 variables, for example:
1024 for (int i = 0; i < 10; i++)
1025 for (int j = 0; j < 10; j++){
1026 MyDelegate d = delegate {
1031 At runtime this captures a single captured variable `i', but it
1032 captures 10 different versions of the variable `j'. The variable
1033 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
1034 recorded on a child.
1036 The toplevel ScopeInfo will also track information like the `this'
1037 pointer if instance variables were referenced (this is necessary
1038 as the anonymous method lives inside a nested class in the host
1039 type of the method).
1041 (AnonymousMethod): Expanded to track the Toplevel, implement
1042 `AnonymousMethod.Compatible' to tell whether an anonymous method
1043 can be converted to a target delegate type.
1045 The routine now also produces the anonymous method content
1047 (AnonymousDelegate): A helper class that derives from
1048 DelegateCreation, this is used to generate the code necessary to
1049 produce the delegate for the anonymous method that was created.
1051 * assign.cs: API adjustments for new changes in
1052 Convert.ImplicitStandardConversionExists.
1054 * class.cs: Adjustments to cope with the fact that now toplevel
1055 blocks are of type `ToplevelBlock'.
1057 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
1058 insteda of standard blocks.
1060 Flag errors if params arguments are passed to anonymous methods.
1062 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
1063 `CurrentAnonymousMethod' which points to the current Anonymous
1064 Method. The variable points to the AnonymousMethod class that
1065 holds the code being compiled. It is set in the new EmitContext
1066 created for the anonymous method.
1068 (EmitContext.Phase): Introduce a variable and an enumeration to
1069 assist in enforcing some rules about when and where we are allowed
1070 to invoke certain methods (EmitContext.NeedsReturnLabel is the
1071 only one that enfonces this right now).
1073 (EmitContext.HaveCaptureInfo): new helper method that returns
1074 whether we have a CapturedContext initialized.
1076 (EmitContext.CaptureVariable): New method used to register that a
1077 LocalInfo must be flagged for capturing.
1079 (EmitContext.CapturedParameter): New method used to register that a
1080 parameters must be flagged for capturing.
1082 (EmitContext.CapturedField): New method used to register that a
1083 field must be flagged for capturing.
1085 (EmitContext.HaveCapturedVariables,
1086 EmitContext.HaveCapturedFields): Return whether there are captured
1087 variables or fields.
1089 (EmitContext.EmitMethodHostInstance): This is used to emit the
1090 instance for the anonymous method. The instance might be null
1091 (static methods), this (for anonymous methods that capture nothing
1092 and happen to live side-by-side with the current method body) or a
1093 more complicated expression if the method has a CaptureContext.
1095 (EmitContext.EmitTopBlock): Routine that drives the emission of
1096 code: it will first resolve the top block, then emit any metadata
1097 and then emit the code. The split is done so that we can extract
1098 any anonymous methods and flag any captured variables/parameters.
1100 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
1101 during this phase, the ILGenerator should not be used as labels
1102 and local variables declared here might not be accessible to any
1103 code that is part of an anonymous method.
1105 Exceptions to this include the temporary variables that are
1106 created by some statements internally for holding temporary
1109 (EmitContext.EmitMeta): New routine, in charge of emitting all the
1112 (EmitContext.TemporaryReturn): This method is typically called
1113 from the Emit phase, and its the only place where we allow the
1114 ReturnLabel to be defined other than the EmitMeta. The reason is
1115 that otherwise we would have to duplicate a lot of logic in the
1116 Resolve phases of various methods that today is on the Emit
1119 (EmitContext.NeedReturnLabel): This no longer creates the label,
1120 as the ILGenerator is not valid during the resolve phase.
1122 (EmitContext.EmitThis): Extended the knowledge in this class to
1123 work in anonymous methods in addition to iterators.
1125 (EmitContext.EmitCapturedVariableInstance): This emits whatever
1126 code is necessary on the stack to access the instance to a local
1127 variable (the variable will be accessed as a field).
1129 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
1130 EmitContext.EmitAddressOfParameter): Routines to support
1131 parameters (not completed at this point).
1133 Removals: Removed RemapLocal and RemapLocalLValue. We probably
1134 will also remove the parameters.
1136 * convert.cs (Convert): Define a `ConstantEC' which points to a
1137 null. This is just to prefity some code that uses
1138 ImplicitStandardConversion code and do not have an EmitContext
1141 The idea is to flag explicitly that at that point in time, it is
1142 known that the conversion will not trigger the delegate checking
1143 code in implicit conversions (which requires a valid
1146 Everywhere: pass new EmitContext parameter since
1147 ImplicitStandardConversionExists now requires it to check for
1148 anonymous method conversions.
1150 (Convert.ImplicitStandardConversionExists): If the type of an
1151 expression is the anonymous_method_type, and the type is a
1152 delegate, we invoke the AnonymousMethod.Compatible method to check
1153 whether an implicit conversion is possible.
1155 (Convert.ImplicitConversionStandard): Only do implicit method
1156 group conversions if the language level is not ISO_1.
1158 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
1159 MethodInfo for the Invoke method. used by Delegate and
1162 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
1163 method conversions if the target type is a delegate.
1165 Removed extra debugging nops.
1167 (LocalVariableReference): Turn the `local_info' into a public
1170 Add `prepared' field, the same hack used for FieldExprs to cope
1171 with composed assignments, as Local variables do not necessarily
1172 operate purely on the stack as they used to: they can be captured
1175 Add `temp' for a temporary result, like fields.
1177 Refactor DoResolve and DoResolveLValue into DoResolveBase.
1179 It now copes with Local variables that are captured and emits the
1180 proper instance variable to load it from a field in the captured
1183 (ParameterReference.DoResolveBase): During the resolve phase,
1184 capture parameters if we are in an anonymous method.
1186 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
1187 anonymous method, use the EmitContext helper routines to emit the
1188 parameter reference.
1190 * iterators.cs: Set RemapToProxy to true/false during the
1193 * parameters.cs (GetParameterByName): New helper method.
1195 * typemanager.cs (anonymous_method_type) a new type that
1196 represents an anonyous method. This is always an internal type,
1197 used as a fencepost to test against the anonymous-methodness of an
1200 2004-10-20 Marek Safar <marek.safar@seznam.cz>
1202 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
1204 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
1206 2004-10-18 Martin Baulig <martin@ximian.com>
1208 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
1209 `Type' directly, but call ResolveType() on it.
1210 (Catch.Resolve): Likewise.
1211 (Foreach.Resolve): Likewise.
1213 2004-10-18 Martin Baulig <martin@ximian.com>
1215 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
1216 `Type' directly, but call ResolveType() on it.
1217 (Probe.DoResolve): Likewise.
1218 (ArrayCreation.LookupType): Likewise.
1219 (TypeOf.DoResolve): Likewise.
1220 (SizeOf.DoResolve): Likewise.
1222 2004-10-18 Martin Baulig <martin@ximian.com>
1224 * expression.cs (Invocation.BetterFunction): Put back
1225 TypeManager.TypeToCoreType().
1227 2004-10-18 Raja R Harinath <rharinath@novell.com>
1229 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
1232 2004-10-18 Martin Baulig <martin@ximian.com>
1234 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
1235 `Type' directly, but call ResolveType() on it.
1237 2004-10-18 Martin Baulig <martin@ximian.com>
1239 * class.cs (FieldMember.Define): Don't access the TypeExpr's
1240 `Type' directly, but call ResolveType() on it.
1241 (MemberBase.DoDefine): Likewise.
1243 * expression.cs (New.DoResolve): Don't access the TypeExpr's
1244 `Type' directly, but call ResolveType() on it.
1245 (ComposedCast.DoResolveAsTypeStep): Likewise.
1247 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
1248 `Type' directly, but call ResolveType() on it.
1250 2004-10-17 John Luke <john.luke@gmail.com>
1252 * class.cs (Operator.GetSignatureForError): use CSharpName
1254 * parameter.cs (Parameter.GetSignatureForError): Returns
1255 correct name even if was not defined.
1257 2004-10-13 Raja R Harinath <rharinath@novell.com>
1260 * class.cs (TypeContainer.EmitContext): New property.
1261 (DefineNestedTypes): Create an emitcontext for each part.
1262 (MethodCore.DoDefineParameters): Use container's emitcontext.
1263 Pass type array to InternalParameters.
1264 (MemberBase.DoDefine): Use container's emitcontext.
1265 (FieldMember.Define): Likewise.
1266 (Event.Define): Likewise.
1267 (SetMethod.GetParameterInfo): Change argument to EmitContext.
1268 Pass type array to InternalParameters.
1269 (SetIndexerMethod.GetParameterInfo): Likewise.
1270 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
1271 * delegate.cs (Define): Pass emitcontext to
1272 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
1273 array to InternalParameters.
1274 * expression.cs (ParameterReference.DoResolveBase): Pass
1275 emitcontext to GetParameterInfo.
1276 (ComposedCast.DoResolveAsTypeStep): Remove check on
1277 ec.ResolvingTypeTree.
1278 * parameter.cs (Parameter.Resolve): Change argument to
1279 EmitContext. Use ResolveAsTypeTerminal.
1280 (Parameter.GetSignature): Change argument to EmitContext.
1281 (Parameters.ComputeSignature): Likewise.
1282 (Parameters.ComputeParameterTypes): Likewise.
1283 (Parameters.GetParameterInfo): Likewise.
1284 (Parameters.ComputeAndDefineParameterTypes): Likewise.
1285 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
1286 * support.cs (InternalParameters..ctor): Remove variant that takes
1288 * typemanager.cs (system_intptr_expr): New.
1289 (InitExpressionTypes): Initialize it.
1291 2004-10-12 Chris Toshok <toshok@ximian.com>
1293 * cs-parser.jay: fix location for try_statement and catch_clause.
1295 2004-10-11 Martin Baulig <martin@ximian.com>
1297 * report.cs: Don't make --fatal abort on warnings, we have
1298 -warnaserror for that.
1300 2004-10-07 Raja R Harinath <rharinath@novell.com>
1302 More DeclSpace.ResolveType avoidance.
1303 * decl.cs (MemberCore.InUnsafe): New property.
1304 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
1305 with newly created EmitContext.
1306 (FieldMember.Define): Likewise.
1307 * delegate.cs (Delegate.Define): Likewise.
1308 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
1309 only if normal name-lookup fails.
1310 (TypeExpr.DoResolve): Enable error-checking.
1311 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
1312 (SizeOf.DoResolve): Likewise.
1313 (ComposedCast.DoResolveAsTypeStep): Likewise.
1314 (StackAlloc.DoResolve): Likewise.
1315 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
1316 (Block.Unsafe): New property.
1317 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
1318 (Unsafe): Set 'unsafe' flag of contained block.
1319 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
1320 (Fixed.Resolve): Likewise.
1321 (Catch.Resolve): Likewise.
1322 (Using.ResolveLocalVariableDecls): Likewise.
1323 (Foreach.Resolve): Likewise.
1325 2004-10-05 John Luke <john.luke@gmail.com>
1327 * cs-parser.jay: add location to error CS0175
1329 2004-10-04 Miguel de Icaza <miguel@ximian.com>
1331 * ecore.cs (Expression.Constantity): Add support for turning null
1334 * const.cs (Const.Define): Allow constants to be reference types
1335 as long as the value is Null.
1337 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
1339 * namespace.cs (NamespaceEntry.Using): No matter which warning
1340 level is set, check if this namespace name has already been added.
1342 2004-10-03 Ben Maurer <bmaurer@ximian.com>
1344 * expression.cs: reftype [!=]= null should always use br[true,false].
1347 2004-10-03 Marek Safar <marek.safar@seznam.cz>
1350 * attribute.cs: Enum conversion moved to
1351 GetAttributeArgumentExpression to be applied to the all
1354 2004-10-01 Raja R Harinath <rharinath@novell.com>
1356 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
1357 * class.c (TypeContainer.DefineType): Flag error if
1358 base types aren't accessible due to access permissions.
1359 * decl.cs (DeclSpace.ResolveType): Move logic to
1360 Expression.ResolveAsTypeTerminal.
1361 (DeclSpace.ResolveTypeExpr): Thin layer over
1362 Expression.ResolveAsTypeTerminal.
1363 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
1364 Refactor code into NestedAccess. Use it.
1365 (DeclSpace.NestedAccess): New.
1366 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
1367 argument to silence errors. Check access permissions.
1368 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
1369 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
1370 (Cast.DoResolve): Likewise.
1371 (New.DoResolve): Likewise.
1372 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
1373 (TypeOf.DoResolve): Likewise.
1375 * expression.cs (Invocation.BetterConversion): Return the Type of
1376 the better conversion. Implement section 14.4.2.3 more faithfully.
1377 (Invocation.BetterFunction): Make boolean. Make correspondence to
1378 section 14.4.2.2 explicit.
1379 (Invocation.OverloadResolve): Update.
1380 (Invocation): Remove is_base field.
1381 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
1382 (Invocation.Emit): Likewise.
1384 2004-09-27 Raja R Harinath <rharinath@novell.com>
1386 * README: Update to changes.
1388 2004-09-24 Marek Safar <marek.safar@seznam.cz>
1390 * cs-parser.jay: Reverted 642 warning fix.
1392 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1395 * decl.cs (FindMemberWithSameName): Indexer can have more than
1398 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1400 * expression.cs (LocalVariableReference.DoResolveLValue):
1401 Do not report warning 219 for out values.
1402 (EmptyExpression.Null): New member to avoid extra allocations.
1404 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1406 * cs-parser.jay: Fix wrong warning 642 report.
1408 * cs-tokenizer.cs (CheckNextToken): New helper;
1409 Inspect next character if is same as expected.
1411 2004-09-23 Martin Baulig <martin@ximian.com>
1413 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
1414 (Convert.ImplicitReferenceConversionExists): Likewise.
1416 2004-09-23 Marek Safar <marek.safar@seznam.cz>
1418 * class.cs (Operator.Define): Add error 448 and 559 report.
1420 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1422 * class.cs (MemberBase.IsTypePermitted): New protected
1423 method for checking error CS0610.
1425 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1427 * class.cs (TypeContainer.HasExplicitLayout): New property
1428 Returns whether container has StructLayout attribute set Explicit.
1429 (FieldMember): New abstract class for consts and fields.
1430 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
1431 (Field): Reuse FieldMember.
1433 * const.cs (Const): Reuse FieldMember.
1435 * rootcontext.cs: EmitConstants call moved to class.
1437 2004-09-22 Martin Baulig <martin@ximian.com>
1439 Thanks to Peter Sestoft for this bug report.
1441 * expression.cs (Conditional): If both the `trueExpr' and the
1442 `falseExpr' is a NullLiteral, return a NullLiteral.
1444 2004-09-22 Martin Baulig <martin@ximian.com>
1446 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
1447 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
1448 for the "get_Current" call.
1450 2004-09-22 Martin Baulig <martin@ximian.com>
1452 Marek and me just fixed one of our oldest bugs: #28562 :-)
1454 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
1456 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
1457 we're an EnumConstant, just return that.
1458 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
1459 an EnumConstant. In this case, we need to use GetValueAsEnumType()
1460 to get the value which'll actually be written into the attribute.
1461 However, we have to use GetValue() to access the attribute's value
1464 2004-09-22 Marek Safar <marek.safar@seznam.cz>
1466 * constant.cs (Constant.IsNegative): New abstract property
1469 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
1470 (StackAlloc.DoResolve): Reused IsNegative.
1472 2004-09-21 Martin Baulig <martin@ximian.com>
1474 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
1475 if we're used in an iterator, we may be called from different
1478 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
1479 we actually have an exception block.
1481 2004-09-20 John Luke <jluke@cfl.rr.com>
1483 * class.cs, cs-parser.jay: Improve the error report for 1520:
1484 report the actual line where the error happens, not where the
1487 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
1488 Pass location information that was available elsewhere.
1490 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
1492 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
1493 runtime to delay sign assemblies.
1495 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1497 * cs-parser.jay: Do not report the stack trace, this is barely
1500 2004-08-22 John Luke <john.luke@gmail.com>
1502 * driver.cs : check that a resource id is not already used
1503 before adding it, report CS1508 if it is, bug #63637
1505 2004-09-19 Miguel de Icaza <miguel@ximian.com>
1507 * ecore.cs: Removed dead code.
1509 2004-09-18 Marek Safar <marek.safar@seznam.cz>
1511 * class.cs: Do not report warning CS0067 on the interfaces.
1513 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1515 * cs-parser.jay: Add error 504 report.
1517 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1519 * rootcontext.cs: WarningLevel is 4 by default now.
1521 * statement.cs (Fixed.Resolve): Do not null
1524 2004-09-16 Marek Safar <marek.safar@seznam.cz>
1527 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
1528 deep search when property is not virtual.
1529 (PropertyExpr.ResolveAccessors): Make one call for both
1532 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1535 * statement.cs: Error 152 report constains also location.
1537 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1540 * const.cs: Explicitly set constant as static.
1542 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1545 * cs-parser.jay: Add error 1017 report.
1547 2004-09-15 Marek Safar <marek.safar@seznam.cz>
1549 Fixed bug #59980, #64224
1550 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
1552 * typemanager.cs (IsSpecialMethod): Simplified
1554 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1556 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
1557 condition with better params.
1559 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1562 * attribute.cs (Resolve): Property has to have both
1565 2004-09-14 Martin Baulig <martin@ximian.com>
1567 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
1569 2004-09-14 Marek Safar <marek.safar@seznam.cz>
1572 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
1573 called and is obsolete then this member suppress message
1574 when call is inside next [Obsolete] method or type.
1576 * expression.cs: Use TestObsoleteMethodUsage member.
1578 2004-09-14 Martin Baulig <martin@ximian.com>
1580 * cs-parser.jay: Sync a bit with the GMCS version.
1582 2004-09-14 Martin Baulig <martin@ximian.com>
1584 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
1585 (CSharpParser.yacc_verbose_flag): New public field.
1587 * genericparser.cs: Removed.
1589 2004-09-14 Raja R Harinath <rharinath@novell.com>
1591 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
1593 2004-09-13 Marek Safar <marek.safar@seznam.cz>
1595 * class.cs (MethodCore.CheckBase): Fix bug #65757.
1597 2004-09-10 Martin Baulig <martin@ximian.com>
1599 Backported my MemberName changes from GMCS into MCS.
1601 - we are now using a special `MemberName' class instead of using
1602 strings; in GMCS, the `MemberName' also contains the type
1605 - changed the grammar rules a bit:
1606 * the old `member_name' is now a `namespace_or_type_name':
1607 The rule is that we use `namespace_or_type_name' everywhere
1608 where we expect either a "member name" (GetEnumerator) or a
1609 "member name" with an explicit interface name
1610 (IEnumerable.GetEnumerator).
1611 In GMCS, the explicit interface name may include type arguments
1612 (IEnumerable<T>.GetEnumerator).
1613 * we use `member_name' instead of just `IDENTIFIER' for
1615 The rule is that we use `member_name' wherever a member may
1616 have type parameters in GMCS.
1618 * decl.cs (MemberName): New public class.
1619 (MemberCore.MemberName): New public readonly field.
1620 (MemberCore.ctor): Take a `MemberName' argument, not a string.
1621 (DeclSpace): Likewise.
1623 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
1624 * enum.cs (Enum.ctor): Likewise.
1626 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
1628 (AliasEntry.ctor): Take a MemberName, not an Expression.
1629 (AliasEntry.UsingAlias): Likewise.
1631 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
1632 (IMethodData.MemberName): Changed type from string to MemberName.
1633 (MemberBase.ExplicitInterfaceName): Likewise.
1634 (AbstractPropertyEventMethod.SetupName): Make this private.
1635 (AbstractPropertyEventMethod.ctor): Added `string prefix'
1636 argument; compute the member name here.
1637 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
1638 on the `member.MemberName' and the `prefix'.
1640 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
1642 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
1643 thus, we get a `MemberName' instead of a `string'. These
1644 declarations may have type parameters in GMCS.
1645 (interface_method_declaration, delegate_declaration): Likewise.
1646 (class_declaration, interface_declaration): Likewise.
1647 (method_header): Use `namespace_or_type_name' instead of
1648 `member_name'. We may be an explicit interface implementation.
1649 (property_declaration, event_declaration): Likewise.
1650 (member_name): This is now just an `IDENTIFIER', not a
1651 `namespace_or_type_name'.
1652 (type_name, interface_type): Removed.
1653 (namespace_or_type_name): Return a MemberName, not an Expression.
1654 (primary_expression): Use `member_name' instead of `IDENTIFIER';
1655 call GetTypeExpression() on the MemberName to get an expression.
1656 (IndexerDeclaration.interface_type): Changed type from string to
1658 (MakeName): Operate on MemberName's instead of string's.
1660 2004-09-13 Raja R Harinath <rharinath@novell.com>
1663 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
1664 (NamespaceEntry.Lookup): Add new argument to flag if we want the
1665 lookup to avoid symbols introduced by 'using'.
1666 * rootcontext.cs (NamespaceLookup): Update.
1668 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1670 * class.cs (TypeContainer.DoDefineMembers): Do not call
1671 DefineDefaultConstructor for static classes.
1673 2004-09-12 Marek Safar <marek.safar@seznam.cz>
1675 * attribute.cs (Attribute.Resolve): Add error 653 report.
1677 * class.cs (Class.ApplyAttributeBuilder): Add error 641
1679 (Method.ApplyAttributeBuilder): Add error 685 report.
1680 (Operator.Define): Add error 564 report.
1682 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
1684 * expression.cs (Invocation.DoResolve): Add error
1687 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
1690 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1692 * class.cs (ConstructorInitializer.Resolve):
1693 Wrong error number (515->516).
1695 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1697 * class.cs (Indexer.Define): Add error 631 report.
1699 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1701 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
1703 2004-09-11 Marek Safar <marek.safar@seznam.cz>
1705 * expression.cs (Probe.DoResolve): Add error CS0241 report.
1707 2004-09-10 Marek Safar <marek.safar@seznam.cz>
1709 * cs-parser.jay: Added error CS0241 report.
1711 2004-09-10 Raja R Harinath <rharinath@novell.com>
1713 * cs-parser.jay (fixed_statement): Introduce a scope for the
1714 declaration in the 'fixed' statement.
1716 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1718 * cs-parser.jay: Added CS0230 error report.
1720 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1722 * cs-parser.jay: Added errors CS0231 and CS0257 report.
1724 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1726 * expression.cs (Argument.Resolve): Added error CS0192 and
1729 2004-09-09 Marek Safar <marek.safar@seznam.cz>
1731 C# 2.0 #pragma warning feature
1733 * cs-tokenizer.cs (PreProcessPragma): New method;
1734 Handles #pragma directive.
1736 * report.cs (WarningRegions): New class; Support
1737 class for #pragma warning directive. It tests whether
1738 warning is enabled for a given line.
1740 2004-09-08 Miguel de Icaza <miguel@ximian.com>
1742 * const.cs: Add more descriptive error report, tahnks to
1745 2004-09-08 Marek Safar <marek.safar@seznam.cz>
1747 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
1749 2004-09-07 Miguel de Icaza <miguel@ximian.com>
1751 * expression.cs: Apply patch from Ben: Remove dead code from
1752 ArrayCreation, and remove the TurnintoConstant call in const.cs,
1753 as that code just threw an exception anwyays.
1755 * const.cs: Remove the call to the turnintoconstant, for details
1758 * literal.cs: The type of the null-literal is the null type; So
1759 we use a placeholder type (literal.cs:System.Null, defined here)
1762 * expression.cs (Conditional.DoResolve): Remove some old code that
1763 is no longer needed, conversions have been fixed.
1765 (ArrayCreationExpression.DoResolve): Return false if we fail to
1766 resolve the inner expression.
1768 2004-09-07 Raja R Harinath <rharinath@novell.com>
1771 * cs-parser.jay (delegate_declaration): Record a delegate
1772 declaration as a type declaration.
1773 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
1775 2004-09-06 Miguel de Icaza <miguel@ximian.com>
1777 * parameter.cs: Do not crash if the type can not be resolved.
1779 * expression.cs: Report errors with unsafe pointers, fixes #64896
1781 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
1783 * expression.cs: Pointer arith always needs to do a conv.i
1784 if the operand is a long. fix 65320
1786 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1788 Fixed cs0619-37.cs, cs0619-38.cs
1790 * enum.cs (GetObsoleteAttribute): Removed.
1792 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
1793 on Enum member is double staged. The first is tested member
1796 2004-09-04 Marek Safar <marek.safar@seznam.cz>
1798 Fixed #56986, #63631, #65231
1800 * class.cs: (TypeContainer.AddToMemberContainer): New method,
1801 adds member to name container.
1802 (TypeContainer.AddToTypeContainer): New method, adds type to
1804 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
1805 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
1806 AddOperator): Simplified by reusing AddToMemberContainer.
1807 (TypeContainer.UserDefinedStaticConstructor): Changed to property
1809 (Method.CheckForDuplications): Fixed implementation to test all
1811 (MemberBase): Detection whether member is explicit interface
1812 implementation is now in constructor.
1813 (MemberBase.UpdateMemberName): Handles IndexerName.
1814 (Accessor): Changed to keep also location information.
1815 (AbstractPropertyEventMethod): Is derived from MemberCore.
1816 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
1817 will be emited or not.
1818 (PropertyBase.AreAccessorsDuplicateImplementation):
1819 Tests whether accessors are not in collision with some method.
1820 (Operator): Is derived from MethodCore to simplify common
1823 * decl.cs (Flags.TestMethodDuplication): Test for duplication
1825 (DeclSpace.AddToContainer): Adds the member to defined_names
1826 table. It tests for duplications and enclosing name conflicts.
1828 * enum.cs (EnumMember): Clean up to reuse the base structures
1830 2004-09-03 Martin Baulig <martin@ximian.com>
1832 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
1833 into TypeContainer, to make partial classes work again.
1835 2004-09-03 Martin Baulig <martin@ximian.com>
1837 * rootcontext.cs (RootContext.V2): Removed.
1839 2004-03-23 Martin Baulig <martin@ximian.com>
1841 * expression.cs (Invocation.OverloadResolve): Added `bool
1842 may_fail' argument and use it instead of the Location.IsNull() hack.
1844 2004-09-03 Martin Baulig <martin@ximian.com>
1846 Merged latest changes into gmcs. Please keep this comment in
1847 here, it makes it easier for me to see what changed in MCS since
1848 the last time I merged.
1850 2004-09-03 Raja R Harinath <rharinath@novell.com>
1853 * expression.cs (BetterConversion): Don't allow either conversion
1854 to be null. Remove redundant implicit conversion test when 'q ==
1855 null' -- when this function is invoked, we already know that the
1856 implicit conversion exists.
1857 (BetterFunction): Assume that 'best' is non-null. Remove
1858 redundant reimplementation of IsApplicable when 'best' is null.
1859 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
1860 number of arguments.
1861 (IsAncestralType): Extract from OverloadResolve.
1862 (OverloadResolve): Make robust to the MethodGroupExpr being
1863 unsorted. Implement all the logic of Section 14.5.5.1, and
1864 support overloading of methods from multiple applicable types.
1865 Clean up logic somewhat. Don't pass null methods to BetterFunction.
1867 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
1868 (RealError, Warning): Append type of report to related symbol.
1870 2004-09-03 Marek Safar <marek.safar@seznam.cz>
1872 * enum.cs: Fixed CLS-Compliance checks for enum members.
1873 Error tests cs3008-8.cs, cs3014-8.cs
1875 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1877 Fixed bug #62342, #63102
1878 * class.cs: ImplementIndexer uses member.IsExplicitImpl
1879 like ImplementMethod.
1881 2004-09-02 Marek Safar <marek.safar@seznam.cz>
1883 * attribute.cs (Attribute.GetAttributeArgumentExpression):
1886 2004-09-02 Martin Baulig <martin@ximian.com>
1888 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
1889 TypeManager.GetArgumentTypes() rather than calling GetParameters()
1892 2004-09-01 Marek Safar <marek.safar@seznam.cz>
1894 C# 2.0 Static classes implemented
1896 * class.cs (TypeContainer): instance_constructors,
1897 initialized_fields, initialized_static_fields,
1898 default_constructor, base_inteface_types are protected to be
1899 accessible from StaticClass.
1900 (TypeContainer.DefineDefaultConstructor): New virtual method
1901 for custom default constructor generating
1902 (StaticClass): New class to handle "Static classes" feature.
1904 * cs-parser.jay: Handle static keyword on class like instance
1907 * driver.cs: Added "/langversion" command line switch with two
1908 options (iso-1, default).
1910 2004-08-31 Marek Safar <marek.safar@seznam.cz>
1912 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
1914 2004-08-31 Miguel de Icaza <miguel@ximian.com>
1916 * delegate.cs: Style.
1918 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
1920 * delegate.cs: Add seperate instance expr field for miguel.
1922 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1924 * PointerArithmetic (Resolve): make sure we are not doing
1925 pointer arith on void*. Also, make sure we are resolved
1926 by not setting eclass until resolve.
1928 All callers: Make sure that PointerArithmetic gets resolved.
1930 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
1932 * ArrayCreation (LookupType): If the type does not resolve
1933 to an array, give an error.
1935 2004-08-27 Marek Safar <marek.safar@seznam.cz>
1937 * statement.cs (Try.Resolve): Fixed bug #64222
1939 2004-08-27 Martin Baulig <martin@ximian.com>
1942 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
1945 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1947 * ecore.cs (Constantify): Get underlying type via
1948 System.Enum.GetUnderlyingType to avoid StackOverflow on the
1949 Windows in special cases.
1951 2004-08-26 Marek Safar <marek.safar@seznam.cz>
1953 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
1954 for obtaining also private methods.
1955 (GetRemoveMethod): Used GetRemoveMethod (true)
1956 for obtaining also private methods.
1958 2004-08-24 Martin Baulig <martin@ximian.com>
1960 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
1961 MethodAttributes.HideBySig for operators.
1963 2004-08-23 Martin Baulig <martin@ximian.com>
1965 Back to the old error reporting system :-)
1967 * report.cs (Message): Removed.
1968 (Report.MessageData, ErrorData, WarningData): Removed.
1969 (Report.Error, Warning): Back to the old system.
1971 2004-08-23 Martin Baulig <martin@ximian.com>
1973 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
1975 * class.cs (TypeContainer.ParentContainer): New public virtual
1976 method; replaces the explicit interface implementation.
1977 (ClassPart.ParentContainer): Override.
1979 2004-08-23 Martin Baulig <martin@ximian.com>
1981 * statement.cs (Switch): Added support for constant switches; see
1982 #59428 or test-285.cs.
1984 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1987 * statement.cs (GetEnumeratorFilter): Removed useless
1988 logic because C# specs is strict. GetEnumerator must be
1991 2004-08-22 Martin Baulig <martin@ximian.com>
1993 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
1994 a switch and may break, reset the barrier. Fixes #59867.
1996 2004-08-22 Marek Safar <marek.safar@seznam.cz>
1998 CLS-Compliance speed up (~5% for corlib)
2000 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
2001 New method. Tests container for CLS-Compliant names
2003 * class.cs (TypeContainer.VerifyClsName): New method.
2004 Checks whether container name is CLS Compliant.
2005 (Constructor): Implements IMethodData.
2007 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
2008 low-case table for CLS Compliance test.
2009 (MemberCache.VerifyClsParameterConflict): New method.
2010 Checks method parameters for CS3006 error.
2012 * enum.cs (EnumMember): Is derived from MemberCore.
2013 (Enum.VerifyClsName): Optimized for better performance.
2015 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2017 * report.cs: Renamed Error_T to Error and changed all
2020 2004-08-06 Marek Safar <marek.safar@seznam.cz>
2022 * class.cs (TypeContainer.IndexerArrayList): New inner class
2023 container for indexers.
2024 (TypeContainer.DefaultIndexerName): New constant for default
2025 indexer name. Replaced all "Item" with this constant.
2026 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
2028 * typemanager.cs (TypeManager.default_member_ctor): Cache here
2029 DefaultMemberAttribute constructor.
2031 2004-08-05 Martin Baulig <martin@ximian.com>
2033 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
2036 2004-08-05 Marek Safar <marek.safar@seznam.cz>
2038 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
2039 multi platforms problem.
2041 * compiler.csproj: Included shared files.
2043 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2045 Fix bug 60333, 55971 in the more general way
2046 * attribute.cs (Attribute.GetAttributeArgumentExpression):
2047 Added arg_type argument for constant conversion.
2048 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
2050 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2053 * class.cs (TypeContainer ): New inner classes MethodArrayList,
2054 OperatorArrayList, MethodCoreArrayList for typecontainer
2055 containers. Changed class member types to these new types.
2056 (MethodArrayList.DefineMembers): Added test for CS0659.
2058 2004-08-04 Miguel de Icaza <miguel@ximian.com>
2060 * cfold.cs: Synchronize the folding with the code in expression.cs
2061 Binary.DoNumericPromotions for uint operands.
2063 * attribute.cs: Revert patch from Raja, it introduced a regression
2064 while building Blam-1.2.1 (hard to isolate a test case).
2066 2004-08-04 Marek Safar <marek.safar@seznam.cz>
2070 (TypeContainer.Define): Renamed to DefineContainerMembers because of
2072 (MethodCore.parent_method): New member. The method we're overriding
2073 if this is an override method.
2074 (MethodCore.CheckBase): Moved from Method class and made common.
2075 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
2077 (MethodCore.CheckForDuplications): New abstract method. For custom
2078 member duplication search in a container
2079 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
2080 method and its return type.
2081 (Event.conflict_symbol): New member. Symbol with same name in the
2085 (MemberCache.FindMemberWithSameName): New method. The method
2086 is looking for conflict with inherited symbols.
2088 2004-08-04 Martin Baulig <martin@ximian.com>
2090 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
2092 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
2094 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2096 * report.cs (Message): New enum for better error, warning reference in
2098 (MessageData): New inner abstract class. It generally handles printing of
2099 error and warning messages.
2100 Removed unused Error, Warning, Message methods.
2102 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2104 Fix for cs0592-8.cs test
2106 (Attributable.ValidAttributeTargets): Made public.
2107 (Attribute.ExplicitTarget): New member for explicit target value.
2108 (Attribute.CheckTargets): Now we translate explicit attribute
2109 target to Target here.
2111 2004-08-03 Ben Maurer <bmaurer@ximian.com>
2113 * ecore.cs (MethodGroupExpr): new IsBase property.
2115 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
2117 * delegate.cs (DelegateCreation): store a MethodGroupExpr
2118 rather than an instance expr.
2120 (DelegateCreation.Emit): Use the method group rather than
2121 the instance expression. Also, if you have base.Foo as the
2122 method for a delegate, make sure to emit ldftn, not ldftnvirt.
2124 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
2126 (NewDelegate.DoResolve): Only check for the existance of Invoke
2127 if the method is going to be needed. Use MethodGroupExpr.
2129 (NewDelegate.Emit): Remove, DelegateCreation implements this.
2131 * expression.cs: For pointer arith., make sure to use
2132 the size of the type, not the size of the pointer to
2135 2004-08-03 Marek Safar <marek.safar@seznam.cz>
2138 * class.cs (Class): Added error CS0502 test.
2140 2004-08-03 John Luke <jluke@cfl.rr.com>
2141 Raja R Harinath <rharinath@novell.com>
2144 * attribute.cs (Attribute.complained_before): New flag.
2145 (Attribute.ResolveType, Attribute.Resolve),
2146 (Attribute.DefinePInvokeMethod): Set it.
2147 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
2149 2004-08-03 Martin Baulig <martin@ximian.com>
2151 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
2152 use a user-defined operator; we still need to do numeric
2153 promotions in case one argument is a builtin type and the other
2154 one has an implicit conversion to that type. Fixes #62322.
2156 2004-08-02 Martin Baulig <martin@ximian.com>
2158 * statement.cs (LocalInfo.Flags): Added `IsThis'.
2159 (LocalInfo.IsThis): New public property.
2160 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
2162 2004-08-01 Martin Baulig <martin@ximian.com>
2164 * class.cs (TypeContainer.GetClassBases): Don't set the default
2165 here since we may get called from GetPartialBases().
2166 (TypeContainer.DefineType): If GetClassBases() didn't return a
2167 parent, use the default one.
2169 2004-07-30 Duncan Mak <duncan@ximian.com>
2171 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
2173 2004-07-30 Martin Baulig <martin@ximian.com>
2175 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
2177 * class.cs (SourceMethod): New public class, derive from the
2178 symbol writer's ISourceMethod.
2179 (Method): Use the new symbol writer API.
2181 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
2182 as argument and use the new symbol writer.
2185 (SourceFile): Implement the symbol writer's ISourceFile.
2186 (Location.SymbolDocument): Removed.
2187 (Location.SourceFile): New public property.
2189 * symbolwriter.cs: Use the new symbol writer API.
2191 2004-07-30 Raja R Harinath <rharinath@novell.com>
2193 * Makefile (install-local): Remove. Functionality moved to
2196 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
2198 * Makefile: Install mcs.exe.config file together with mcs.exe.
2199 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
2200 correct runtime version.
2202 2004-07-25 Martin Baulig <martin@ximian.com>
2205 (TypeContainer.RegisterOrder): Removed, this was unused.
2206 (TypeContainer, interface_order): Removed.
2207 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
2208 TypeContainer as argument since we can also be called with a
2209 `PartialContainer' for a partial class/struct/interface.
2210 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
2211 of checking whether we're an `Interface' - we could be a
2213 (PartialContainer.Register): Override; call
2214 AddClass()/AddStruct()/AddInterface() on our parent.
2216 * cs-parser.jay (interface_member_declaration): Add things to the
2217 `current_container', not the `current_class'.
2219 * rootcontext.cs (RegisterOrder): The overloaded version which
2220 takes an `Interface' was unused, removed.
2222 * typemanager.cs (TypeManager.LookupInterface): Return a
2223 `TypeContainer', not an `Interface'.
2224 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
2225 contain a `PartialContainer' for an interface, so check it's
2226 `Kind' to figure out what it is.
2228 2004-07-25 Martin Baulig <martin@ximian.com>
2230 * class.cs (Class.DefaultTypeAttributes): New public constant.
2231 (Struct.DefaultTypeAttributes): Likewise.
2232 (Interface.DefaultTypeAttributes): Likewise.
2233 (PartialContainer.TypeAttr): Override this and add the
2234 DefaultTypeAttributes.
2236 2004-07-25 Martin Baulig <martin@ximian.com>
2238 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
2239 we can just use the `Parent' field instead.
2241 2004-07-25 Martin Baulig <martin@ximian.com>
2243 * class.cs (TypeContainer.Emit): Renamed to EmitType().
2245 2004-07-25 Martin Baulig <martin@ximian.com>
2247 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
2248 our parts before defining any methods.
2249 (TypeContainer.VerifyImplements): Make this virtual.
2250 (ClassPart.VerifyImplements): Override and call VerifyImplements()
2251 on our PartialContainer.
2253 2004-07-25 Martin Baulig <martin@ximian.com>
2255 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
2257 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
2258 argument, we can just use the `Parent' field instead.
2261 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
2262 (MemberBase.DoDefine): Likewise.
2264 2004-07-24 Martin Baulig <martin@ximian.com>
2266 * decl.cs (MemberCore.Parent): New public field.
2267 (DeclSpace.Parent): Moved to MemberCore.
2269 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
2270 (MemberBase.ctor): Added TypeContainer argument, pass it to our
2272 (FieldBase, Field, Operator): Likewise.
2273 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
2274 (EventField, Event): Likewise.
2276 2004-07-23 Martin Baulig <martin@ximian.com>
2278 * class.cs (PartialContainer): New public class.
2279 (ClassPart): New public class.
2280 (TypeContainer): Added support for partial classes.
2281 (TypeContainer.GetClassBases): Splitted some of the functionality
2282 out into GetNormalBases() and GetPartialBases().
2284 * cs-tokenizer.cs (Token.PARTIAL): New token.
2285 (Tokenizer.consume_identifier): Added some hacks to recognize
2286 `partial', but only if it's immediately followed by `class',
2287 `struct' or `interface'.
2289 * cs-parser.jay: Added support for partial clases.
2291 2004-07-23 Martin Baulig <martin@ximian.com>
2293 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
2294 a `DeclSpace' and also made it readonly.
2295 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
2296 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
2297 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
2299 * cs-parser.jay: Pass the `current_class', not the
2300 `current_container' (at the moment, this is still the same thing)
2301 to a new Method, Property, Event, Indexer or Constructor.
2303 2004-07-23 Martin Baulig <martin@ximian.com>
2305 * cs-parser.jay (CSharpParser): Added a new `current_class' field
2306 and removed the `current_interface' one.
2307 (struct_declaration, class_declaration, interface_declaration):
2308 Set `current_class' to the newly created class/struct/interface;
2309 set their `Bases' and call Register() before parsing their body.
2311 2004-07-23 Martin Baulig <martin@ximian.com>
2313 * class.cs (Kind): New public enum.
2314 (TypeContainer): Made this class abstract.
2315 (TypeContainer.Kind): New public readonly field.
2316 (TypeContainer.CheckDef): New public method; moved here from
2318 (TypeContainer.Register): New public abstract method.
2319 (TypeContainer.GetPendingImplementations): New public abstract
2321 (TypeContainer.GetClassBases): Removed the `is_class' and
2322 `is_iface' parameters.
2323 (TypeContainer.DefineNestedTypes): Formerly known as
2325 (ClassOrStruct): Made this class abstract.
2327 * tree.cs (RootTypes): New public type.
2329 2004-07-20 Martin Baulig <martin@ximian.com>
2331 * tree.cs (Tree.RecordNamespace): Removed.
2332 (Tree.Namespaces): Removed.
2334 * rootcontext.cs (RootContext.IsNamespace): Removed.
2336 * cs-parser.jay (namespace_declaration): Just create a new
2337 NamespaceEntry here.
2339 2004-07-20 Martin Baulig <martin@ximian.com>
2341 * statement.cs (ExceptionStatement): New abstract class. This is
2342 now used as a base class for everyone who's using `finally'.
2343 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
2344 our local variables before using them.
2346 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
2347 virtual method. This is used by Yield.Resolve() to "steal" an
2348 outer block's `finally' clauses.
2349 (FlowBranchingException): The .ctor now takes an ExceptionStatement
2352 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
2353 version which takes an ExceptionStatement. This version must be
2354 used to create exception branchings.
2357 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
2358 (Iterator.EmitMoveNext): Added exception support; protect the
2359 block with a `fault' clause, properly handle 'finally' clauses.
2360 (Iterator.EmitDispose): Run all the `finally' clauses here.
2362 2004-07-20 Martin Baulig <martin@ximian.com>
2364 * iterator.cs: This is the first of a set of changes in the
2365 iterator code. Match the spec more closely: if we're an
2366 IEnumerable, then GetEnumerator() must be called. The first time
2367 GetEnumerator() is called, it returns the current instance; all
2368 subsequent invocations (if any) must create a copy.
2370 2004-07-19 Miguel de Icaza <miguel@ximian.com>
2372 * expression.cs: Resolve the constant expression before returning
2375 2004-07-19 Martin Baulig <martin@ximian.com>
2377 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
2378 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
2379 the return type of the new EmitContext.
2381 2004-07-18 Martin Baulig <martin@ximian.com>
2383 * class.cs (Property.Define): Fix iterators.
2385 * iterators.cs (Iterator.Define): Moved the
2386 `container.AddInterator (this)' call here from the .ctor; only do
2387 it if we resolved successfully.
2389 2004-07-17 Miguel de Icaza <miguel@ximian.com>
2391 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
2392 `true' for preprocessing directives that we parse. The return
2393 value indicates whether we should return to regular tokenizing or
2394 not, not whether it was parsed successfully.
2396 In the past if we were in: #if false ... #line #endif, we would
2397 resume parsing after `#line'. See bug 61604.
2399 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
2400 building: IsEnumType should return true only for enums, not for
2401 enums or System.Enum itself. This fixes #61593.
2403 Likely what happened is that corlib was wrong: mcs depended on
2404 this bug in some places. The bug got fixed, we had to add the
2405 hack, which caused bug 61593.
2407 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
2408 that was a workaround for the older conditions.
2410 2004-07-16 Ben Maurer <bmaurer@ximian.com>
2412 * assign.cs: IAssignMethod has a new interface, as documented
2413 inline. All assignment code now uses this new api.
2415 * ecore.cs, expression.cs: All classes which implement
2416 IAssignMethod now use the new interface.
2418 * expression.cs (Invocation): add a hack to EmitCall so that
2419 IndexerAccess can be the target of a compound assignment without
2420 evaluating its arguments twice.
2422 * statement.cs: Handle changes in Invocation api.
2424 2004-07-16 Martin Baulig <martin@ximian.com>
2426 * iterators.cs: Rewrote this. We're now using one single Proxy
2427 class for both the IEnumerable and the IEnumerator interface and
2428 `Iterator' derives from Class so we can use the high-level API.
2430 * class.cs (TypeContainer.AddIterator): New method.
2431 (TypeContainer.DoDefineType): New protected virtual method, which
2432 is called from DefineType().
2433 (TypeContainer.DoDefineMembers): Call DefineType() and
2434 DefineMembers() on all our iterators.
2435 (TypeContainer.Emit): Call Emit() on all our iterators.
2436 (TypeContainer.CloseType): Call CloseType() on all our iterators.
2438 * codegen.cs (EmitContext.CurrentIterator): New public field.
2440 2004-07-15 Martin Baulig <martin@ximian.com>
2443 (TypeManager.not_supported_exception_type): New type.
2445 2004-07-14 Martin Baulig <martin@ximian.com>
2447 * iterators.cs: Use real error numbers.
2449 2004-07-14 Martin Baulig <martin@ximian.com>
2451 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
2452 requires this to be a System.Collection.IEnumerable and not a
2453 class implementing that interface.
2454 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
2456 2004-07-13 Marek Safar <marek.safar@seznam.cz>
2458 * class.cs: Fixed previous fix, it broke some error tests.
2460 2004-07-12 Martin Baulig <martin@ximian.com>
2462 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
2465 2004-07-09 Miguel de Icaza <miguel@ximian.com>
2467 * assign.cs (LocalTemporary): Add new argument: is_address,If
2468 `is_address' is true, then the value that we store is the address
2469 to the real value, and not the value itself.
2471 * ecore.cs (PropertyExpr): use the new local temporary
2472 stuff to allow us to handle X.Y += z (where X is a struct)
2474 2004-07-08 Martin Baulig <martin@ximian.com>
2476 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
2477 not always return, just like we're doing in Using.Resolve().
2479 2004-07-07 Miguel de Icaza <miguel@ximian.com>
2481 * cs-parser.jay (fixed_statement): flag this as Pinned.
2483 2004-07-06 Miguel de Icaza <miguel@ximian.com>
2485 * typemanager.cs (TypeManager): Removed MakePinned method, this
2486 mechanism is replaced with the .NET 2.x compatible mechanism of
2487 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
2489 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
2490 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
2491 `IsFixed' property which has a different meaning.
2493 2004-07-02 Raja R Harinath <rharinath@novell.com>
2495 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
2496 visible from inside a nested class, not just the names of the
2497 immediately enclosing class.
2500 2004-06-24 Raja R Harinath <rharinath@novell.com>
2502 * expression.cs (BetterConversion): Remove buggy special-case
2503 handling of "implicit constant expression conversions". At this
2504 point, we already know that the conversion is possible -- we're
2505 only checking to see which is better.
2507 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2509 * cs-parser.jay: Added error CS0210 test.
2511 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2513 * cs-parser.jay: Added error CS0134 test.
2515 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2518 * cs-parser.jay: Added error CS0145 test.
2520 2004-06-24 Marek Safar <marek.safar@seznam.cz>
2522 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
2524 2004-06-23 Ben Maurer <bmaurer@ximian.com>
2526 * expression.cs (StackAlloc.Resolve): The argument may not
2527 be a constant; deal with this case.
2529 2004-06-23 Marek Safar <marek.safar@seznam.cz>
2531 * attribute.cs (IndexerName_GetIndexerName): Renamed to
2532 GetIndexerAttributeValue.
2533 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
2535 * class.cs (Indexer.Define): Added error tests for CS0415,
2538 2004-06-23 Miguel de Icaza <miguel@ximian.com>
2540 * attribute.cs (Attribute.Resolve): Keep field code in sync with
2543 2004-06-23 Martin Baulig <martin@ximian.com>
2545 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
2546 neither return nor throw, reset the barrier as well. Fixes #60457.
2548 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
2550 * class.cs : EventAttributes is now set to None by default.
2551 This fixes bug #60459.
2553 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2556 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2557 Don't throw exception but return null (it's sufficient now).
2559 2004-06-18 Marek Safar <marek.safar@seznam.cz>
2561 * typemanager.cs (GetArgumentTypes): Faster implementation.
2563 2004-06-18 Martin Baulig <martin@ximian.com>
2565 * attribute.cs (Attribute.Resolve): Check whether we're an
2566 EmptyCast which a Constant child. Fixes #60333.
2568 2004-06-17 Ben Maurer <bmaurer@ximian.com>
2570 * statement.cs (EmitCollectionForeach): Account for the fact that
2571 not all valuetypes are in areas which we can take the address of.
2572 For these variables, we store to a temporary variable. Also, make
2573 sure that we dont emit a `callvirt' on a valuetype method.
2575 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2577 * expression.cs (StackAlloc.DoReSolve): Added test for
2578 negative parameter (CS0247).
2580 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2583 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
2585 2004-06-15 Marek Safar <marek.safar@seznam.cz>
2588 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
2591 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2593 Fix bug #58254 & cs1555.cs, cs1556.cs
2594 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
2596 2004-06-14 Marek Safar <marek.safar@seznam.cz>
2598 * cs-parser.jay: Added error CS1669 test for indexers.
2600 2004-06-11 Martin Baulig <martin@ximian.com>
2602 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
2603 call this twice: for params and varargs methods.
2605 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2608 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
2610 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2612 * attribute.cs (Attribute.GetValidTargets): Made public.
2615 (AbstractPropertyEventMethod): New class for better code sharing.
2616 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
2618 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
2620 2004-06-11 Raja R Harinath <rharinath@novell.com>
2623 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
2624 that the call to Resolve is part of a MemberAccess.
2625 (Expression.Resolve): Use it for SimpleName resolution.
2626 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
2627 Add 'intermediate' boolean argument.
2628 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
2629 error message when the SimpleName can be resolved ambiguously
2630 between an expression and a type.
2631 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
2633 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
2634 call on the left-side.
2636 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2639 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
2641 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2643 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
2645 2004-06-11 Martin Baulig <martin@ximian.com>
2647 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
2648 varargs methods if applicable.
2650 2004-06-11 Martin Baulig <martin@ximian.com>
2652 * expression.cs (Invocation.EmitCall): Don't use
2653 `method.CallingConvention == CallingConventions.VarArgs' since the
2654 method could also have `CallingConventions.HasThis'.
2656 2004-06-11 Marek Safar <marek.safar@seznam.cz>
2658 * class.cs (Event.GetSignatureForError): Implemented.
2659 Fixed crash in error test cs3010.cs
2661 2004-06-10 Miguel de Icaza <miguel@ximian.com>
2663 * cs-tokenizer.cs: Change the way we track __arglist to be
2664 consistent with the other keywords.
2666 2004-06-09 Miguel de Icaza <miguel@ximian.com>
2668 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
2671 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
2673 * codegen.cs: Check that all referenced assemblies have a strongname
2674 before strongnaming the compiled assembly. If not report error CS1577.
2675 Fix bug #56563. Patch by Jackson Harper.
2676 * typemanager.cs: Added a method to return all referenced assemblies.
2677 Fix bug #56563. Patch by Jackson Harper.
2679 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2682 (Method.ApplyAttributeBuilder): Moved and added conditional
2683 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
2686 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
2688 2004-06-08 Marek Safar <marek.safar@seznam.cz>
2691 * class.cs: (EventField.attribute_targets): Changed default target.
2693 2004-06-08 Martin Baulig <martin@ximian.com>
2695 * expression.cs (Invocation.EmitCall): Enable varargs methods.
2697 2004-06-08 Martin Baulig <martin@ximian.com>
2699 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
2701 2004-06-07 Martin Baulig <martin@ximian.com>
2703 Added support for varargs methods.
2705 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
2708 * cs-parser.jay: Added support for `__arglist'.
2710 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
2712 * expression.cs (Argument.AType): Added `ArgList'.
2713 (Invocation): Added support for varargs methods.
2714 (ArglistAccess): New public class.
2715 (Arglist): New public class.
2717 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
2719 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
2720 a method's top-level block if the method has varargs.
2722 * support.cs (ReflectionParameters, InternalParameters): Added
2723 support for varargs methods.
2725 2004-06-07 Miguel de Icaza <miguel@ximian.com>
2727 * class.cs: Provide location in indexer error report.
2729 * driver.cs: Use standard names.
2731 * namespace.cs: Catch the use of using after a namespace has been
2732 declared also on using aliases.
2734 2004-06-03 Raja R Harinath <rharinath@novell.com>
2737 * typemanager.cs (closure_private_ok, closure_invocation_type)
2738 (closure_qualifier_type, closure_invocation_assembly)
2739 (FilterWithClosure): Move to ...
2740 (Closure): New internal nested class.
2741 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
2742 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
2743 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
2744 (MemberLookup, MemberLookupFailed): Use it.
2745 * expression.cs (New.DoResolve): Treat the lookup for the
2746 constructor as being qualified by the 'new'ed type.
2747 (Indexers.GetIndexersForTypeOrInterface): Update.
2749 2004-06-03 Marek Safar <marek.safar@seznam.cz>
2752 (GetConditionalAttributeValue): New method. Returns
2753 condition of ConditionalAttribute.
2754 (SearchMulti): New method. Returns all attributes of type 't'.
2755 Use it when attribute is AllowMultiple = true.
2756 (IsConditionalMethodExcluded): New method.
2759 (Method.IsExcluded): Implemented. Returns true if method has conditional
2760 attribute and the conditions is not defined (method is excluded).
2761 (IMethodData): Extended interface for ConditionalAttribute support.
2762 (PropertyMethod.IsExcluded): Implemented.
2765 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
2768 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
2771 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
2773 * expression.cs (ArrayCreationExpression): Make this just an
2774 `expression'. It can't be a statement, so the code here was
2777 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2780 * typemanager.cs (GetFullNameSignature): New method for
2783 2004-06-02 Marek Safar <marek.safar@seznam.cz>
2786 * class.cs (MemberBase.GetSignatureForError): New virtual method.
2787 Use this method when MethodBuilder is null.
2788 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
2789 Added test for error CS0626 (MONO reports error for this situation).
2790 (IMethodData.GetSignatureForError): Extended interface.
2792 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2795 (AttributeTester.GetObsoleteAttribute): Returns instance of
2796 ObsoleteAttribute when type is obsolete.
2799 (TypeContainer.VerifyObsoleteAttribute): Override.
2800 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
2801 (MethodCode.VerifyObsoleteAttribute): Override.
2802 (MemberBase.VerifyObsoleteAttribute): Override.
2805 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
2806 and report proper error.
2809 Delegate.VerifyObsoleteAttribute): Override.
2812 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
2813 and report proper error.
2814 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
2817 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
2821 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
2822 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
2823 Added test for ObsoleteAttribute.
2826 (Catch): Derived from Statement.
2828 2004-06-01 Marek Safar <marek.safar@seznam.cz>
2830 Fixed bug #59071 & cs0160.cs
2832 * statement.cs (Try.Resolve): Check here whether order of catch
2833 clauses matches their dependencies.
2835 2004-05-31 Miguel de Icaza <miguel@ximian.com>
2837 * Reverted patch to namespace.cs (Use lookuptypedirect). This
2838 caused a regression: #59343. Referencing nested classes from an
2839 assembly stopped working.
2841 2004-05-31 Martin Baulig <martin@ximian.com>
2843 MCS is now frozen for beta 2.
2845 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2847 * convert.cs: add a trivial cache for overload operator resolution.
2849 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2851 * decl.cs: If possible, use lookuptypedirect here. We can only do
2852 this if there is no `.' after the namespace. Avoids using
2853 LookupType, which does lots of slow processing.
2854 (FindNestedType) New method, does what it says :-).
2855 * namespace.cs: use LookupTypeDirect.
2856 * rootcontext.cs: use membercache, if possible.
2857 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
2859 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2862 According to the spec,
2864 In a member access of the form E.I, if E is a single identifier,
2865 and if the meaning of E as a simple-name (§7.5.2) is a constant,
2866 field, property, localvariable, or parameter with the same type as
2867 the meaning of E as a type-name (§3.8), then both possible
2868 meanings of E are permitted.
2870 We did not check that E as a simple-name had the same type as E as
2873 This trivial check gives us 5-7% on bootstrap time.
2875 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
2877 * expression.cs (Invocation.OverloadResolve): Avoid the
2878 use of hashtables and boxing here by allocating on demand.
2880 2004-05-30 Martin Baulig <martin@ximian.com>
2882 * rootcontext.cs (RootContext.LookupType): Don't cache things if
2883 we're doing a silent lookup. Don't try to lookup nested types in
2884 TypeManager.object_type (thanks to Ben Maurer).
2886 2004-05-30 Martin Baulig <martin@ximian.com>
2888 Committing a patch from Ben Maurer.
2890 * rootcontext.cs (RootContext.LookupType): Cache negative results.
2892 2004-05-29 Martin Baulig <martin@ximian.com>
2894 * class.cs (IMethodData.ShouldIgnore): New method.
2896 * typemanager.cs (TypeManager.MethodFlags): Don't take a
2897 `Location' argument, we don't need it anywhere. Use
2898 `IMethodData.ShouldIgnore ()' instead of
2899 `MethodData.GetMethodFlags ()'.
2900 (TypeManager.AddMethod): Removed.
2901 (TypeManager.AddMethod2): Renamed to AddMethod.
2903 2004-05-29 Martin Baulig <martin@ximian.com>
2905 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
2907 * convert.cs (Convert.ImplicitReferenceConversion): If we're
2908 converting from a class type S to an interface type and we already
2909 have an object on the stack, don't box it again. Fixes #52578.
2911 2004-05-29 Martin Baulig <martin@ximian.com>
2913 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
2914 Added support for `params' parameters. Fixes #59267.
2916 2004-05-29 Martin Baulig <martin@ximian.com>
2918 * literal.cs (NullPointer): Provide a private .ctor which sets
2919 `type' to TypeManager.object_type. Fixes #59048.
2921 2004-05-29 Martin Baulig <martin@ximian.com>
2923 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
2924 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
2926 * ecore.cs (EventExpr.instance_expr): Make the field private.
2928 2004-05-26 Marek Safar <marek.safar@seznam.cz>
2930 Fixed bug #50080 & cs0214-2.cs
2931 * expression.cs (Cast.DoResolve): Check unsafe context here.
2933 * statement.cs (Resolve.DoResolve): Likewise.
2935 2004-05-26 Martin Baulig <martin@ximian.com>
2937 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
2939 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
2940 (RootContext.LookupType): Pass down the `silent' flag.
2942 2004-05-25 Martin Baulig <martin@ximian.com>
2945 (MethodGroupExpr.IdenticalTypeName): New public property.
2946 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
2947 expression actually refers to a type.
2949 2004-05-25 Martin Baulig <martin@ximian.com>
2951 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
2952 for #56176 and made it actually work.
2954 2004-05-25 Martin Baulig <martin@ximian.com>
2956 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
2957 (FieldExpr, PropertyExpr): Override and implement
2958 CacheTemporaries. Fixes #52279.
2960 2004-05-25 Miguel de Icaza <miguel@ximian.com>
2962 * location.cs: In the new compiler listing a file twice is a
2963 warning, not an error.
2965 2004-05-24 Martin Baulig <martin@ximian.com>
2967 * enum.cs (Enum.DefineType): For the `BaseType' to be a
2968 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
2970 2004-05-24 Martin Baulig <martin@ximian.com>
2972 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
2973 walking the `using' list. Fixes #53921.
2975 2004-05-24 Martin Baulig <martin@ximian.com>
2977 * const.cs (Const.LookupConstantValue): Added support for
2978 EmptyCast's; fixes #55251.
2980 2004-05-24 Martin Baulig <martin@ximian.com>
2982 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
2983 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
2984 which does the CS0135 check. The reason is that we first need to
2985 check whether the variable actually exists.
2987 2004-05-24 Martin Baulig <martin@ximian.com>
2989 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
2990 than RootContext.LookupType() to find the explicit interface
2993 2004-05-24 Raja R Harinath <rharinath@novell.com>
2995 * Makefile: Simplify. Use executable.make.
2996 * mcs.exe.sources: New file. List of sources of mcs.exe.
2998 2004-05-24 Anders Carlsson <andersca@gnome.org>
3002 Use the invariant culture when doing String.Compare for CLS case
3005 2004-05-23 Martin Baulig <martin@ximian.com>
3007 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
3008 don't have any dots. Fixes #52622, added cs0246-8.cs.
3010 * namespace.cs (NamespaceEntry.Lookup): Likewise.
3012 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3014 * class.cs (MemberBase.Define): Reuse MemberType member for
3015 resolved type. Other methods can use it too.
3017 2004-05-23 Martin Baulig <martin@ximian.com>
3019 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
3020 the variable also exists in the current block (otherwise, we need
3021 to report a CS0103). Fixes #58670.
3023 2004-05-23 Martin Baulig <martin@ximian.com>
3025 * flowanalysis.cs (Reachability.Reachable): Compute this
3026 on-the-fly rather than storing it as a field.
3028 2004-05-23 Martin Baulig <martin@ximian.com>
3030 * flowanalysis.cs (Reachability.And): Manually compute the
3031 resulting `barrier' from the reachability.
3033 2004-05-23 Marek Safar <marek.safar@seznam.cz>
3036 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
3037 instance of ObsoleteAttribute when symbol is obsolete.
3040 (IMethodData): Extended interface for ObsoleteAttribute support.
3042 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3044 * attribute.cs: Fix bug #55970
3046 2004-05-22 Marek Safar <marek.safar@seznam.cz>
3050 (GetObsoleteAttribute): New method. Creates the instance of
3052 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
3053 ObsoleteAttribute when member is obsolete.
3054 (AttributeTester.Report_ObsoleteMessage): Common method for
3055 Obsolete error/warning reporting.
3058 (TypeContainer.base_classs_type): New member for storing parent type.
3061 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
3062 for this MemberCore.
3064 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3066 * attribute.cs, const.cs: Fix bug #58590
3068 2004-05-21 Martin Baulig <martin@ximian.com>
3070 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
3071 out parameters if the end of the method is unreachable. Fixes
3074 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3076 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
3077 Hari was right, why extra method.
3079 2004-05-21 Marek Safar <marek.safar@seznam.cz>
3081 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
3083 2004-05-20 Martin Baulig <martin@ximian.com>
3085 Merged this back from gmcs to keep the differences to a minumum.
3087 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
3088 instead of a Declspace.
3089 (Attribute.ResolveType): Likewise.
3090 (Attributes.Search): Likewise.
3091 (Attributes.Contains): Likewise.
3092 (Attributes.GetClsCompliantAttribute): Likewise.
3094 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
3096 (MethodData.ApplyAttributes): Take an EmitContext instead of a
3099 2004-05-19 Marek Safar <marek.safar@seznam.cz>
3101 Fix bug #58688 (MCS does not report error when the same attribute
3104 * attribute.cs (Attribute.Emit): Distinction between null and default.
3106 2004-05-19 Raja R Harinath <rharinath@novell.com>
3108 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
3109 of a top-level attribute without an attribute target.
3110 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
3112 (Attribute.Conditional_GetConditionName),
3113 (Attribute.Obsolete_GetObsoleteMessage): Update.
3114 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
3115 part of ScanForIndexerName.
3116 (Attribute.CanIgnoreInvalidAttribute): New function.
3117 (Attribute.ScanForIndexerName): Move to ...
3118 (Attributes.ScanForIndexerName): ... here.
3119 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
3120 (Attributes.Search): New internal variant that can choose not to
3121 complain if types aren't resolved. The original signature now
3123 (Attributes.GetClsCompliantAttribute): Use internal variant, with
3124 complaints suppressed.
3125 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
3126 only if it not useful.
3127 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
3128 top-level for attributes that are shared between the assembly
3129 and a top-level class.
3130 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
3131 * class.cs: Update to reflect changes.
3132 (DefineIndexers): Fuse loops.
3133 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
3134 a couple more variants of attribute names.
3136 2004-05-18 Marek Safar <marek.safar@seznam.cz>
3138 Fix bug #52585 (Implemented explicit attribute declaration)
3141 (Attributable.ValidAttributeTargets): New abstract method. It gets
3142 list of valid attribute targets for explicit target declaration.
3143 (Attribute.Target): It holds target itself.
3144 (AttributeSection): Removed.
3145 (Attribute.CheckTargets): New method. It checks whether attribute
3146 target is valid for the current element.
3149 (EventProperty): New class. For events that are declared like
3150 property (with add and remove accessors).
3151 (EventField): New class. For events that are declared like field.
3154 * cs-parser.jay: Implemented explicit attribute target declaration.
3156 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
3157 Override ValidAttributeTargets.
3160 (ReturnParameter): Class for applying custom attributes on
3162 (ParameterAtribute): New class. Class for applying custom
3163 attributes on the parameter type.
3165 2004-05-17 Miguel de Icaza <miguel@ximian.com>
3167 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
3170 (Method): Allow UNSAFE here.
3172 * modifiers.cs: Support unsafe reporting.
3174 2004-05-17 Marek Safar <marek.safar@seznam.cz>
3176 * decl.cs: Fix bug #58478.
3178 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3180 * statement.cs: When checking for unreachable code on an EmptyStatement,
3181 set the location. Fixes bug #58488.
3183 2004-05-13 Miguel de Icaza <miguel@ximian.com>
3185 * driver.cs: Add -pkg handling.
3187 From Gonzalo: UseShelLExecute=false
3189 2004-05-12 Marek Safar <marek.safar@seznam.cz>
3192 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
3194 (Attribute.IsClsCompliaceRequired): Moved to base for better
3196 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
3197 when attribute is AttributeUsageAttribute.
3198 (Attribute.GetValidTargets): Simplified.
3199 (Attribute.GetAttributeUsage): New method returns AttributeUsage
3200 attribute for this type.
3201 (Attribute.ApplyAttributes): Method renamed to Emit and make
3203 (GlobalAttributeSection): New class for special handling of global
3204 attributes (assembly, module).
3205 (AttributeSection.Emit): New method.
3207 * class.cs: Implemented Attributable abstract methods.
3208 (MethodCore.LabelParameters): Moved to Parameter class.
3209 (Accessor): Is back simple class.
3210 (PropertyMethod): Implemented Attributable abstract class.
3211 (DelegateMethod): Implemented Attributable abstract class.
3212 (Event): New constructor for disctintion between normal Event
3213 and Event with accessors.
3215 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
3217 * codegen.cs, const.cs, decl.cs, delegate.cs:
3218 (CommonAssemblyModulClass): Implemented Attributable abstract class
3221 * enum.cs: Implement IAttributeSupport interface.
3222 (EnumMember): New class for emum members. Implemented Attributable
3226 (ParameterBase): Is abstract.
3227 (ReturnParameter): New class for easier [return:] attribute handling.
3229 * typemanager.cs: Removed builder_to_attr.
3231 2004-05-11 Raja R Harinath <rharinath@novell.com>
3234 * attribute.cs (Attribute.GetPositionalValue): New function.
3235 * class.cs (TypeContainer.VerifyMembers): New function.
3236 (TypeContainer.Emit): Use it.
3237 (ClassOrStruct): New base class for Class and Struct.
3238 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
3239 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
3241 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
3242 then each non-static field should have a FieldOffset attribute.
3243 Otherwise, none of the fields should have a FieldOffset attribute.
3244 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
3245 and FieldOffset attributes.
3246 * typemanager.cs (TypeManager.struct_layout_attribute_type)
3247 (TypeManager.field_offset_attribute_type): New core types.
3248 (TypeManager.InitCoreTypes): Initialize them.
3250 2004-05-11 Michal Moskal <malekith@pld-linux.org>
3252 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
3253 Return correct type.
3256 2004-05-09 Miguel de Icaza <miguel@ximian.com>
3258 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
3259 be implicitly converted to ulong.
3261 * expression.cs: The logic for allowing operator &, | and ^ worked
3262 was wrong, it worked before because we did not report an error in
3263 an else branch. Fixes 57895.
3265 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
3266 allow volatile fields to be reference types.
3268 2004-05-07 Miguel de Icaza <miguel@ximian.com>
3270 * driver.cs: Add support for /debug-
3272 2004-05-07 Raja R Harinath <rharinath@novell.com>
3274 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
3275 Add a 'complain' parameter to silence errors.
3276 (Attribute.Resolve): Update to changes. Put in sanity check to catch
3277 silently overlooked type-resolutions.
3278 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
3280 (Attributes.Search): New function.
3281 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
3282 (Attributes.GetAttributeFullName): Remove hack.
3283 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
3284 Update to reflect changes.
3285 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
3286 Use Attributes.Search instead of nested loops.
3288 2004-05-07 Marek Safar <marek.safar@seznam.cz>
3291 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
3292 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
3293 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
3295 * report.cs: (Report.Warning): Renamed to Warning_T because of
3296 parameter collision.
3298 2004-05-05 Raja R Harinath <rharinath@novell.com>
3300 * expression.cs (MemberAccess.ResolveMemberAccess):
3301 Exit with non-zero status after Report.Error.
3302 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
3304 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
3306 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3308 * support.cs: Don't hang when the file is empty.
3310 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
3312 * support.cs: In SeekableStreamReader, compute the preamble size of the
3313 underlying stream. Position changes should take into account that initial
3316 2004-05-03 Todd Berman <tberman@sevenl.net>
3318 * driver.cs: remove unused GetSysVersion function.
3320 2004-05-03 Todd Berman <tberman@sevenl.net>
3322 * driver.cs: Remove the hack from saturday, as well as the hack
3323 from jackson (LoadAssemblyFromGac), also adds the CWD to the
3324 link_paths to get that bit proper.
3326 2004-05-01 Todd Berman <tberman@sevenl.net>
3328 * driver.cs: Try a LoadFrom before a Load, this checks the current
3329 path. This is currently a bug in mono that is be fixed, however, this
3330 provides a workaround for now. This will be removed when the bug
3333 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
3335 * CryptoConvert.cs: Updated to latest version. Fix issue with
3336 incomplete key pairs (#57941).
3338 2004-05-01 Todd Berman <tberman@sevenl.net>
3340 * driver.cs: Remove '.' from path_chars, now System.* loads properly
3343 2004-04-30 Jackson Harper <jackson@ximian.com>
3345 * codegen.cs: Open keys readonly.
3347 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
3349 * typemanager.cs: don't report cyclic struct layout when a struct
3350 contains 2 or more fields of the same type. Failed for Pango.AttrShape
3351 which has 2 Pango.Rectangle fields.
3353 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
3355 * expression.cs: Handle IntPtr comparisons with IL code
3356 rather than a method call.
3358 2004-04-29 Martin Baulig <martin@ximian.com>
3360 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
3361 the list of PropertyInfo's in class hierarchy and find the
3362 accessor. Fixes #56013.
3364 2004-04-29 Martin Baulig <martin@ximian.com>
3366 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
3368 2004-04-29 Martin Baulig <martin@ximian.com>
3370 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3372 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
3374 2004-04-29 Martin Baulig <martin@ximian.com>
3376 * class.cs (ConstructorInitializer.Resolve): Check whether the
3377 parent .ctor is accessible. Fixes #52146.
3379 2004-04-29 Martin Baulig <martin@ximian.com>
3381 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
3383 * statement.cs (Using.EmitLocalVariableDecls): Use
3384 TypeManager.idisposable_type, not typeof (IDisposable).
3385 (Foreach.EmitCollectionForeach): Added support for valuetypes.
3387 2004-04-29 Martin Baulig <martin@ximian.com>
3389 * class.cs (Event.Define): Don't emit the field and don't set
3390 RTSpecialName and SpecialName for events on interfaces. Fixes
3393 2004-04-29 Raja R Harinath <rharinath@novell.com>
3395 Refactor Attribute.ApplyAttributes.
3396 * attribute.cs (Attributable): New base class for objects that can
3397 have Attributes applied on them.
3398 (Attribute): Make AttributeUsage fields public.
3399 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
3400 (Attribute.IsInternalCall): New property.
3401 (Attribute.UsageAttr): Convert to a public read-only property.
3402 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
3403 (Attribute.ResolveType, Attribute.Resolve)
3404 (Attribute.ScanForIndexerName): Update to reflect changes.
3405 (Attribute.CheckAttributeTarget): Re-format.
3406 (Attribute.ApplyAttributes): Refactor, to various
3407 Attributable.ApplyAttributeBuilder methods.
3408 * decl.cs (MemberCore): Make Attributable.
3409 * class.cs (Accessor): Make Attributable.
3410 (MethodData.ApplyAttributes): Use proper attribute types, not
3412 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
3413 (TypeContainer.ApplyAttributeBuilder)
3414 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
3415 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
3416 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
3417 (Operator.ApplyAttributeBuilder): New factored-out methods.
3418 * const.cs (Const.ApplyAttributeBuilder): Likewise.
3419 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
3420 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
3421 * parameter.cs (ParameterBase): New Attributable base class
3422 that can also represent Return types.
3423 (Parameter): Update to the changes.
3425 2004-04-29 Jackson Harper <jackson@ximian.com>
3427 * driver.cs: Prefer the corlib system version when looking for
3428 assemblies in the GAC. This is still a hack, but its a better hack
3431 2004-04-29 Marek Safar <marek.safar@seznam.cz>
3433 * decl.cs, enum.cs: Improved error 3005 reporting.
3435 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
3436 (related_symbols): New private member for list of symbols
3437 related to reported error/warning.
3439 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
3441 2004-04-29 Martin Baulig <martin@ximian.com>
3443 * ecore.cs (Expression.Constantify): If we're an enum and
3444 TypeManager.TypeToCoreType() doesn't give us another type, use
3445 t.UnderlyingSystemType. Fixes #56178.
3447 2004-04-29 Martin Baulig <martin@ximian.com>
3449 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
3450 interfaces and for each interface, only add members directly
3451 declared in that interface. Fixes #53255.
3453 2004-04-28 Martin Baulig <martin@ximian.com>
3455 * expression.cs (ConditionalLogicalOperator): Use a temporary
3456 variable for `left' to avoid that we evaluate it more than once;
3459 2004-04-28 Martin Baulig <martin@ximian.com>
3461 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
3464 2004-04-28 Martin Baulig <martin@ximian.com>
3466 * statement.cs (LocalInfo.Resolve): Check whether the type is not
3469 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
3470 whether the type is not void (CS1547).
3472 2004-04-28 Martin Baulig <martin@ximian.com>
3474 * expression.cs (Unary.DoResolveLValue): Override this and report
3475 CS0131 for anything but Operator.Indirection.
3477 2004-04-28 Martin Baulig <martin@ximian.com>
3479 Committing a patch from Ben Maurer; see bug #50820.
3481 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3484 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3487 2004-04-28 Martin Baulig <martin@ximian.com>
3489 Committing a patch from Ben Maurer; see bug #50820.
3491 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
3494 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
3497 2004-04-28 Martin Baulig <martin@ximian.com>
3499 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
3500 (Block.AddLabel): Call DoLookupLabel() to only search in the
3503 2004-04-28 Martin Baulig <martin@ximian.com>
3505 * cfold.cs (ConstantFold.BinaryFold): Added special support for
3506 comparing StringConstants and NullLiterals in Equality and Inequality.
3508 2004-04-28 Jackson Harper <jackson@ximian.com>
3510 * driver.cs: Attempt to load referenced assemblies from the
3511 GAC. This is the quick and dirty version of this method that
3512 doesnt take into account versions and just takes the first
3513 canidate found. Will be good enough for now as we will not have more
3514 then one version installed into the GAC until I update this method.
3516 2004-04-28 Martin Baulig <martin@ximian.com>
3518 * typemanager.cs (TypeManager.CheckStructCycles): New public
3519 static method to check for cycles in the struct layout.
3521 * rootcontext.cs (RootContext.PopulateTypes): Call
3522 TypeManager.CheckStructCycles() for each TypeContainer.
3523 [Note: We only need to visit each type once.]
3525 2004-04-28 Martin Baulig <martin@ximian.com>
3527 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
3529 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
3530 success and added `out object value'. Use a `bool resolved' field
3531 to check whether we've already been called rather than
3532 `ConstantValue != null' since this breaks for NullLiterals.
3534 2004-04-28 Raja R Harinath <rharinath@novell.com>
3536 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
3537 setting of this flag, since the 'set' method may be non-public.
3539 2004-04-28 Raja R Harinath <rharinath@novell.com>
3541 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
3542 check on current_vector.Block.
3544 2004-04-27 Martin Baulig <martin@ximian.com>
3546 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
3547 a field initializer. Fixes #56459.
3549 2004-04-27 Martin Baulig <martin@ximian.com>
3551 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
3552 we're not attempting to use an indexer. Fixes #52154.
3554 2004-04-27 Martin Baulig <martin@ximian.com>
3556 * statement.cs (Return): Don't create a return label if we don't
3557 need it; reverts my change from January 20th. Thanks to Ben
3560 2004-04-27 Martin Baulig <martin@ximian.com>
3562 According to the spec, `goto' can only leave a nested scope, but
3565 * statement.cs (Block.LookupLabel): Only lookup in the current
3566 block, don't recurse into parent or child blocks.
3567 (Block.AddLabel): Check in parent and child blocks, report
3568 CS0140/CS0158 if we find a duplicate.
3569 (Block): Removed this indexer for label lookups.
3570 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
3571 this already does the error reporting for us.
3574 (FlowBranching.UsageVector.Block): New public variable; may be null.
3575 (FlowBranching.CreateSibling): Added `Block' argument.
3576 (FlowBranching.LookupLabel): New public virtual method. Lookup a
3577 label for the target of a `goto' and check whether we're not
3578 leaving a `finally'.
3580 2004-04-27 Martin Baulig <martin@ximian.com>
3582 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
3583 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
3586 2004-04-27 Martin Baulig <martin@ximian.com>
3588 * statement.cs (Block.AddLabel): Also check for implicit blocks
3589 and added a CS0158 check.
3591 2004-04-27 Martin Baulig <martin@ximian.com>
3593 * flowanalysis.cs (FlowBranchingLoop): New class.
3594 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
3595 UsageVector's instead of an ArrayList.
3596 (FlowBranching.Label): Likewise.
3597 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
3598 (FlowBranching.AddBreakVector): New method.
3600 2004-04-27 Miguel de Icaza <miguel@ximian.com>
3602 * attribute.cs: Small regression fix: only convert the type if we
3603 the type is different, fixes System.Drawing build.
3605 2004-04-27 Martin Baulig <martin@ximian.com>
3607 * attribute.cs (Attribute.Resolve): If we have a constant value
3608 for a named field or property, implicity convert it to the correct
3611 2004-04-27 Raja R Harinath <rharinath@novell.com>
3613 * statement.cs (Block.Block): Implicit blocks share
3614 'child_variable_names' fields with parent blocks.
3615 (Block.AddChildVariableNames): Remove.
3616 (Block.AddVariable): Mark variable as "used by a child block" in
3617 every surrounding block.
3618 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
3619 been used in a child block, complain about violation of "Invariant
3620 meaning in blocks" rule.
3621 * cs-parser.jay (declare_local_variables): Don't use
3622 AddChildVariableNames.
3623 (foreach_statement): Don't create an implicit block: 'foreach'
3626 2004-04-23 Miguel de Icaza <miguel@ximian.com>
3628 * convert.cs (ImplicitNumericConversion): 0 is also positive when
3629 converting from 0L to ulong. Fixes 57522.
3631 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3633 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
3634 derived class hides via 'new' keyword field from base class (test-242.cs).
3635 TODO: Handle this in the more general way.
3637 * class.cs (CheckBase): Ditto.
3639 2004-04-22 Marek Safar <marek.safar@seznam.cz>
3641 * decl.cs (caching_flags): New member for storing cached values
3643 (MemberCore.Flags): New enum where bit flags for caching_flags
3645 (MemberCore.cls_compliance): Moved to caching_flags.
3646 (DeclSpace.Created): Moved to caching_flags.
3648 * class.cs: Use caching_flags instead of DeclSpace.Created
3650 2004-04-21 Miguel de Icaza <miguel@ximian.com>
3652 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
3653 if we are only a derived class, not a nested class.
3655 * typemanager.cs: Same as above, but do this at the MemberLookup
3656 level (used by field and methods, properties are handled in
3657 PropertyExpr). Allow for the qualified access if we are a nested
3660 2004-04-21 Marek Safar <marek.safar@seznam.cz>
3662 * class.cs: Refactoring.
3663 (IMethodData): New inteface; Holds links to parent members
3664 to avoid member duplication (reduced memory allocation).
3665 (Method): Implemented IMethodData interface.
3666 (PropertyBase): New inner classes for get/set methods.
3667 (PropertyBase.PropertyMethod): Implemented IMethodData interface
3668 (Event): New inner classes for add/remove methods.
3669 (Event.DelegateMethod): Implemented IMethodData interface.
3671 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
3672 EmitContext (related to class.cs refactoring).
3674 2004-04-21 Raja R Harinath <rharinath@novell.com>
3676 * delegate.cs (Delegate.VerifyApplicability): If the number of
3677 arguments are the same as the number of parameters, first try to
3678 verify applicability ignoring any 'params' modifier on the last
3682 2004-04-16 Raja R Harinath <rharinath@novell.com>
3684 * class.cs (TypeContainer.AddIndexer): Use
3685 'ExplicitInterfaceName' to determine if interface name was
3686 explicitly specified. 'InterfaceType' is not initialized at this time.
3687 (TypeContainer.DefineIndexers): Remove use of temporary list. The
3688 Indexers array is already in the required order. Initialize
3689 'IndexerName' only if there are normal indexers.
3690 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
3691 (TypeContainer.Emit): Emit DefaultMember attribute only if
3692 IndexerName is initialized.
3695 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
3697 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
3700 2004-04-15 Raja R Harinath <rharinath@novell.com>
3702 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
3706 * attribute.cs (Attribute.Resolve): Check for duplicate named
3710 2004-04-15 Miguel de Icaza <miguel@ximian.com>
3712 * iterators.cs (MarkYield): track whether we are in an exception,
3713 and generate code accordingly. Use a temporary value to store the
3714 result for our state.
3716 I had ignored a bit the interaction of try/catch with iterators
3717 since their behavior was not entirely obvious, but now it is
3718 possible to verify that our behavior is the same as MS .NET 2.0
3722 2004-04-14 Miguel de Icaza <miguel@ximian.com>
3724 * iterators.cs: Avoid creating temporaries if there is no work to
3727 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
3728 Enumerations, use TypeManager.EnumToUnderlying and call
3731 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
3734 (This.Emit): Use EmitContext.EmitThis to emit our
3737 (This.EmitAssign): Ditto.
3739 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
3740 codepaths, we will move all the functionality into
3743 (FieldExpr.EmitAssign): Ditto.
3745 This fixes several hidden bugs that I uncovered while doing a code
3746 review of this today.
3748 * codegen.cs (EmitThis): reworked so the semantics are more clear
3749 and also support value types "this" instances.
3751 * iterators.cs: Changed so that for iterators in value types, we
3752 do not pass the value type as a parameter.
3754 Initialization of the enumerator helpers is now done in the caller
3755 instead of passing the parameters to the constructors and having
3756 the constructor set the fields.
3758 The fields have now `assembly' visibility instead of private.
3760 2004-04-11 Miguel de Icaza <miguel@ximian.com>
3762 * expression.cs (Argument.Resolve): Check if fields passed as ref
3763 or out are contained in a MarshalByRefObject.
3765 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
3766 another compiler type.
3768 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
3770 * class.cs (Indexer.Define): use the new name checking method.
3771 Also, return false on an error.
3772 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
3773 (is_identifier_[start/part]_character): make static.
3775 2004-04-10 Miguel de Icaza <miguel@ximian.com>
3777 * expression.cs (Binary.ResolveOperator): Do no append strings
3778 twice: since we can be invoked more than once (array evaluation)
3779 on the same concatenation, take care of this here. Based on a fix
3780 from Ben (bug #56454)
3782 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
3784 * codegen.cs: Fix another case where CS1548 must be reported (when
3785 delay-sign isn't specified and no private is available #56564). Fix
3786 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
3787 error when MCS is used on the MS runtime and we need to delay-sign
3788 (which seems unsupported by AssemblyBuilder - see #56621).
3790 2004-04-08 Marek Safar <marek.safar@seznam.cz>
3792 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
3793 (TypeManager.ComputeNamespaces): Faster implementation for
3796 * compiler.csproj: Updated AssemblyName to mcs.
3798 2004-04-07 Miguel de Icaza <miguel@ximian.com>
3800 * rootcontext.cs: Add new types to the boot resolution.
3802 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
3803 MulticastDelegate is not allowed.
3805 * typemanager.cs: Add new types to lookup: System.TypedReference
3808 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
3809 check for TypedReference or ArgIterator, they are not allowed.
3811 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
3812 makes us properly catch 1510 in some conditions (see bug 56016 for
3815 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
3817 * CryptoConvert.cs: update from corlib version
3820 2004-04-05 Miguel de Icaza <miguel@ximian.com>
3822 * class.cs (Indexer.Define): Check indexername declaration
3824 2004-04-05 Marek Safar <marek.safar@seznam.cz>
3826 * attribute.cs (IsClsCompliant): Fixed problem with handling
3827 all three states (compliant, not-compliant, undetected).
3829 2004-03-30 Marek Safar <marek.safar@seznam.cz>
3831 * attribute.cs (Attribute): Location is now public.
3832 (Resolve): Store resolved arguments (pos_values) in attribute class.
3833 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
3834 (GetClsCompliantAttributeValue): New method that gets
3835 CLSCompliantAttribute value.
3836 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
3837 if exists else null.
3838 (AttributeTester): New class for CLS-Compliant verification routines.
3840 * class.cs (Emit): Add CLS-Compliant verification.
3841 (Method.GetSignatureForError): Implemented.
3842 (Constructor.GetSignatureForError): Implemented
3843 (Constructor.HasCompliantArgs): Returns if constructor has
3844 CLS-Compliant arguments.
3845 (Constructor.Emit): Override.
3846 (Construcor.IsIdentifierClsCompliant): New method; For constructors
3847 is needed to test only parameters.
3848 (FieldBase.GetSignatureForError): Implemented.
3849 (TypeContainer): New member for storing base interfaces.
3850 (TypeContainer.FindMembers): Search in base interfaces too.
3852 * codegen.cs (GetClsComplianceAttribute): New method that gets
3853 assembly or module CLSCompliantAttribute value.
3854 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
3856 (ModuleClass.Emit): Add error 3012 test.
3858 * const.cs (Emit): Override and call base for CLS-Compliant tests.
3860 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
3861 state for all decl types.
3862 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
3863 if CLS-Compliant tests are required.
3864 (IsClsCompliaceRequired): New method. Analyze whether code
3865 must be CLS-Compliant.
3866 (IsExposedFromAssembly): New method. Returns true when MemberCore
3867 is exposed from assembly.
3868 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
3869 value or gets cached value.
3870 (HasClsCompliantAttribute): New method. Returns true if MemberCore
3871 is explicitly marked with CLSCompliantAttribute.
3872 (IsIdentifierClsCompliant): New abstract method. This method is
3873 used to testing error 3005.
3874 (IsIdentifierAndParamClsCompliant): New method. Common helper method
3875 for identifier and parameters CLS-Compliant testing.
3876 (VerifyClsCompliance): New method. The main virtual method for
3877 CLS-Compliant verifications.
3878 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
3879 null. I don't know why is null (too many public members !).
3880 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
3881 and get value of first CLSCompliantAttribute that found.
3883 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
3884 (VerifyClsCompliance): Override and add extra tests.
3886 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
3887 clscheck- disable CLS-Compliant verification event if assembly is has
3888 CLSCompliantAttribute(true).
3890 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
3891 ApllyAttribute is now called in emit section as in the other cases.
3892 Possible future Emit integration.
3893 (IsIdentifierClsCompliant): New override.
3894 (VerifyClsCompliance): New override.
3895 (GetEnumeratorName): Returns full enum name.
3897 * parameter.cs (GetSignatureForError): Implemented.
3899 * report.cs (WarningData): New struct for Warning message information.
3900 (LocationOfPreviousError): New method.
3901 (Warning): New method. Reports warning based on the warning table.
3902 (Error_T): New method. Reports error based on the error table.
3904 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
3905 verifications are done here.
3907 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
3909 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
3910 CLSCompliantAttribute.
3911 (all_imported_types): New member holds all imported types from other
3913 (LoadAllImportedTypes): New method fills static table with exported types
3914 from all referenced assemblies.
3915 (Modules): New property returns all assembly modules.
3917 2004-03-30 Miguel de Icaza <miguel@ximian.com>
3919 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
3920 throwing a parser error.
3922 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
3923 which removes the hardcoded get_/set_ prefixes for properties, as
3924 IL allows for the properties to be named something else.
3928 * expression.cs: Do not override operand before we know if it is
3931 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3933 * typemanager.cs: support for pinned variables.
3935 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3937 * decl.cs, typemanager.cs: Avoid using an arraylist
3938 as a buffer if there is only one result set.
3940 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
3942 * expression.cs: Make sure you cant call a static method
3943 with an instance expression, bug #56174.
3945 2004-03-29 Miguel de Icaza <miguel@ximian.com>
3947 * class.cs (IsDuplicateImplementation): Improve error reporting to
3948 flag 663 (method only differs in parameter modifier).
3950 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
3951 in preprocessor directives.
3953 * location.cs (LookupFile): Allow for the empty path.
3955 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
3956 better approach for some of that patch, but its failing with the
3957 CharSet enumeration. For now try/catch will do.
3959 * typemanager.cs: Do not crash if a struct does not have fields.
3962 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3964 * expression.cs: cs0213, cant fix a fixed expression.
3967 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3969 * cs-parser.jay: detect invalid embeded statements gracefully.
3972 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
3974 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
3977 the invocation type may not be a subclass of the tye of the item/
3978 The type of the item must be a subclass of the invocation item.
3983 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
3985 * attribute.cs: Added methods to get a string and a bool from an
3986 attribute. Required to information from AssemblyKeyFileAttribute,
3987 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
3988 * codegen.cs: Modified AssemblyName creation to include support for
3989 strongnames. Catch additional exceptions to report them as CS1548.
3990 * compiler.csproj: Updated include CryptoConvert.cs.
3991 * compiler.csproj.user: Removed file - user specific configuration.
3992 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
3993 Mono.Security assembly. The original class is maintained and tested in
3994 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
3995 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
3996 like CSC 8.0 (C# v2) supports.
3997 * Makefile: Added CryptoConvert.cs to mcs sources.
3998 * rootcontext.cs: Added new options for strongnames.
4000 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
4002 * driver.cs: For --expect-error, report error code `2'
4003 if the program compiled with no errors, error code `1' if
4004 it compiled with an error other than the one expected.
4006 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
4008 * compiler.csproj: Updated for Visual Studio .NET 2003.
4009 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
4010 * compiler.sln: Updated for Visual Studio .NET 2003.
4012 2004-03-24 Ravi Pratap M <ravi@ximian.com>
4014 * expression.cs: Fix bug #47234. We basically need to apply the
4015 rule that we prefer the conversion of null to a reference type
4016 when faced with a conversion to 'object' (csc behaviour).
4018 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4020 * statement.cs: Shorter form for foreach, eliminates
4021 a local variable. r=Martin.
4023 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4025 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
4026 checks if we can use brtrue/brfalse to test for 0.
4027 * expression.cs: use the above in the test for using brtrue/brfalse.
4030 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4032 * expression.cs: Rewrite string concat stuff. Benefits:
4034 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
4035 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
4036 rather than a concat chain.
4038 * typemanager.cs: Add lookups for more concat overloads.
4040 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
4042 * expression.cs: Emit shorter il code for array init.
4059 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
4061 * statement.cs: Before, two switch blocks would be merged if the
4062 total size of the blocks (end_item - begin_item + 1) was less than
4063 two times the combined sizes of the blocks.
4065 Now, it will only merge if after the merge at least half of the
4070 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
4072 * class.cs : csc build fix for GetMethods(). See bug #52503.
4074 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
4076 * expression.cs: Make sure fp comparisons work with NaN.
4077 This fixes bug #54303. Mig approved this patch a long
4078 time ago, but we were not able to test b/c the runtime
4081 2004-03-19 Miguel de Icaza <miguel@ximian.com>
4083 * ecore.cs (TypExpr.GetHashCode): implement this overload.
4085 2004-03-19 Martin Baulig <martin@ximian.com>
4087 * class.cs (MemberCore.IsDuplicateImplementation): Report the
4088 error here and not in our caller.
4090 2004-03-19 Martin Baulig <martin@ximian.com>
4092 * interface.cs: Completely killed this file.
4093 (Interface): We're now a TypeContainer and live in class.cs.
4095 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
4096 argument; we're now also called for interfaces.
4097 (TypeContainer.DefineMembers): Allow this method being called
4099 (TypeContainer.GetMethods): New public method; formerly known as
4100 Interface.GetMethod(). This is used by PendingImplementation.
4101 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
4102 it's now private and non-static.
4103 (Interface): Moved this here; it's now implemented similar to
4105 (Method, Property, Event, Indexer): Added `bool is_interface'
4106 argument to their .ctor's.
4107 (MemberBase.IsInterface): New public field.
4109 * cs-parser.jay: Create normal Method, Property, Event, Indexer
4110 instances instead of InterfaceMethod, InterfaceProperty, etc.
4111 (opt_interface_base): Removed; we now use `opt_class_base' instead.
4112 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
4114 2004-03-19 Martin Baulig <martin@ximian.com>
4116 * class.cs (MethodCore.IsDuplicateImplementation): New private
4117 method which does the CS0111 checking.
4118 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
4119 Use IsDuplicateImplementation().
4121 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
4123 * decl.cs (FindMemberToOverride): New method to find the correct
4124 method or property to override in the base class.
4126 - Make Method/Property use the above method to find the
4127 version in the base class.
4128 - Remove the InheritableMemberSignatureCompare as it is now
4131 This patch makes large code bases much faster to compile, as it is
4132 O(n) rather than O(n^2) to do this validation.
4134 Also, it fixes bug 52458 which is that nested classes are not
4135 taken into account when finding the base class member.
4137 Reviewed/Approved by Martin.
4139 2004-03-17 Marek Safar <marek.safar@seznam.cz>
4141 * interface.cs: In all interface classes removed redundant
4142 member initialization.
4144 2004-03-16 Martin Baulig <martin@ximian.com>
4146 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
4148 2004-03-15 Miguel de Icaza <miguel@ximian.com>
4150 * decl.cs (DefineTypeAndParents): New helper method to define a
4151 type's containers before the type itself is defined; This is a
4152 bug exposed by the recent changes to Windows.Forms when an
4153 implemented interface was defined inside a class that had not been
4156 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
4158 (Check): Loop correctly to report errors modifiers
4159 (UNSAFE was not in the loop, since it was the same as TOP).
4161 * interface.cs: Every interface member now takes a ModFlags,
4162 instead of a "is_new" bool, which we set on the base MemberCore.
4164 Every place where we called "UnsafeOk" in the interface, now we
4165 call the proper member (InterfaceMethod.UnsafeOK) instead to get
4166 the unsafe settings from the member declaration instead of the
4167 container interface.
4169 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
4171 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
4172 `set_indexer_name' to the pending bits (one per type).
4174 We fixed a bug today that was picking the wrong method to
4175 override, since for properties the existing InterfaceMethod code
4176 basically ignored the method name. Now we make sure that the
4177 method name is one of the valid indexer names.
4179 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
4181 * support.cs (SeekableStreamReader): Keep track of stream byte
4182 positions and don't mix them with character offsets to the buffer.
4184 Patch from Gustavo Giráldez
4186 2004-03-15 Marek Safar <marek.safar@seznam.cz>
4188 * interface.cs (InterfaceSetGetBase): Removed double member
4189 initialization, base class does it as well.
4191 2004-03-13 Martin Baulig <martin@ximian.com>
4193 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
4194 when compiling corlib.
4196 2004-03-13 Miguel de Icaza <miguel@ximian.com>
4198 * convert.cs (ExplicitConversion): We were reporting an error on
4199 certain conversions (object_type source to a value type, when the
4200 expression was `null') before we had a chance to pass it through
4201 the user defined conversions.
4203 * driver.cs: Replace / and \ in resource specifications to dots.
4206 * class.cs: Add check for duplicate operators. Fixes 52477
4208 2004-03-11 Miguel de Icaza <miguel@ximian.com>
4210 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
4211 that are in the middle of the statements, not only at the end.
4214 * class.cs (TypeContainer.AddField): No longer set the
4215 `HaveStaticConstructor' flag, now we call it
4216 `UserDefineStaticConstructor' to diferentiate the slightly
4217 semantic difference.
4219 The situation is that we were not adding BeforeFieldInit (from
4220 Modifiers.TypeAttr) to classes that could have it.
4221 BeforeFieldInit should be set to classes that have no static
4226 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
4228 And most importantly Zoltan's comment:
4230 http://bugzilla.ximian.com/show_bug.cgi?id=44229
4232 "I think beforefieldinit means 'it's ok to initialize the type sometime
4233 before its static fields are used', i.e. initialization does not need
4234 to be triggered by the first access to the type. Setting this flag
4235 helps the JIT to compile better code, since it can run the static
4236 constructor at JIT time, and does not need to generate code to call it
4237 (possibly lots of times) at runtime. Unfortunately, mcs does not set
4238 this flag for lots of classes like String.
4240 csc sets this flag if the type does not have an explicit static
4241 constructor. The reasoning seems to be that if there are only static
4242 initalizers for a type, and no static constructor, then the programmer
4243 does not care when this initialization happens, so beforefieldinit
4246 This bug prevents the AOT compiler from being usable, since it
4247 generates so many calls to mono_runtime_class_init that the AOT code
4248 is much slower than the JITted code. The JITted code is faster,
4249 because it does not generate these calls if the vtable is type is
4250 already initialized, which is true in the majority of cases. But the
4251 AOT compiler can't do this."
4253 2004-03-10 Miguel de Icaza <miguel@ximian.com>
4255 * class.cs (MethodData.Emit): Refactor the code so symbolic
4256 information is generated for destructors; For some reasons we
4257 were taking a code path that did not generate symbolic information
4260 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
4262 * class.cs: Create a Constructor.CheckBase method that
4263 takes care of all validation type code. The method
4264 contains some code that was moved from Define.
4266 It also includes new code that checks for duplicate ctors.
4267 This fixes bug #55148.
4269 2004-03-09 Joshua Tauberer <tauberer@for.net>
4271 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
4272 a { ... }-style array creation invokes EmitStaticInitializers
4273 which is not good for reference-type arrays. String, decimal
4274 and now null constants (NullCast) are not counted toward
4275 static initializers.
4277 2004-03-05 Martin Baulig <martin@ximian.com>
4279 * location.cs (SourceFile.HasLineDirective): New public field;
4280 specifies whether the file contains or is referenced by a "#line"
4282 (Location.DefineSymbolDocuments): Ignore source files which
4283 either contain or are referenced by a "#line" directive.
4285 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
4287 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
4288 direct access to our parent, so check the method inline there.
4290 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
4292 * expression.cs (Invocation.EmitCall): Miguel's last commit
4293 caused a regression. If you had:
4298 In Foo the implict this would be null.
4300 2004-02-27 Miguel de Icaza <miguel@ximian.com>
4302 * expression.cs (Invocation.EmitCall): If the method is not
4303 virtual, do not emit a CallVirt to it, use Call.
4305 * typemanager.cs (GetFullNameSignature): Improve the method to
4306 cope with ".ctor" and replace it with the type name.
4308 * class.cs (ConstructorInitializer.Resolve): Now the method takes
4309 as an argument the ConstructorBuilder where it is being defined,
4310 to catch the recursive constructor invocations.
4312 2004-02-26 Miguel de Icaza <miguel@ximian.com>
4314 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
4315 routines to check if a type is an enumerable/enumerator allow
4316 classes that implement the IEnumerable or IEnumerator interfaces.
4318 * class.cs (Property, Operator): Implement IIteratorContainer, and
4319 implement SetYields.
4321 (Property.Define): Do the block swapping for get_methods in the
4322 context of iterators. We need to check if Properties also
4323 include indexers or not.
4325 (Operator): Assign the Block before invoking the
4326 OperatorMethod.Define, so we can trigger the Iterator code
4329 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
4330 Property and Operator classes are not created when we parse the
4331 declarator but until we have the block completed, so we use a
4332 singleton SimpleIteratorContainer.Simple to flag whether the
4333 SetYields has been invoked.
4335 We propagate this setting then to the Property or the Operator to
4336 allow the `yield' to function.
4338 2004-02-25 Marek Safar <marek.safar@seznam.cz>
4340 * codegen.cs: Implemented attribute support for modules.
4341 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
4342 Assembly/Module functionality.
4344 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
4345 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
4346 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
4348 2004-02-16 Marek Safar <marek.safar@seznam.cz>
4350 * interface.cs (FindMembers): The operation is performed on all base
4351 interfaces and not only on the first. It is required for future CLS Compliance patch.
4353 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
4355 * statement.cs, codegen.cs:
4356 This patch deals with patterns such as:
4358 public class List : IEnumerable {
4360 public MyEnumerator GetEnumerator () {
4361 return new MyEnumerator(this);
4364 IEnumerator IEnumerable.GetEnumerator () {
4368 public struct MyEnumerator : IEnumerator {
4373 Before, there were a few things we did wrong:
4374 1) we would emit callvirt on a struct, which is illegal
4375 2) we emited ldarg when we needed to emit ldarga
4376 3) we would mistakenly call the interface methods on an enumerator
4377 type that derived from IEnumerator and was in another assembly. For example:
4379 public class MyEnumerator : IEnumerator
4381 Would have the interface methods called, even if there were public impls of the
4382 method. In a struct, this lead to invalid IL code.
4384 2004-02-11 Marek Safar <marek.safar@seznam.cz>
4386 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
4389 * delegate.cs (Define): Fixed crash when delegate type is undefined.
4391 2004-02-11 Miguel de Icaza <miguel@ximian.com>
4393 * cs-parser.jay: Fix small regression: we were not testing V2
4394 compiler features correctly.
4396 * interface.cs: If the emit context is null, then create one
4398 2004-02-09 Marek Safar <marek.safar@seznam.cz>
4400 * decl.cs (GetSignatureForError): New virtual method to get full name
4403 * attribute.cs (IAttributeSupport): New interface for attribute setting.
4404 Now it is possible to rewrite ApplyAttributes method to be less if/else.
4406 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
4407 Duplicated members and code in these classes has been removed.
4408 Better encapsulation in these classes.
4410 2004-02-07 Miguel de Icaza <miguel@ximian.com>
4412 * assign.cs (Assign.DoResolve): When dealing with compound
4413 assignments, there is a new rule in ECMA C# 2.4 (might have been
4414 there before, but it is documented here) that states that in:
4418 If b is of type int, and the `op' is a shift-operator, then the
4419 above is evaluated as:
4423 * expression.cs (Binary.ResolveOperator): Instead of testing for
4424 int/uint/long/ulong, try to implicitly convert to any of those
4425 types and use that in pointer arithmetic.
4427 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
4428 method to print information for from the type, not from the
4429 null-method we were given.
4431 2004-02-01 Duncan Mak <duncan@ximian.com>
4433 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
4434 parsing for cmd, fixes bug #53694.
4436 2004-02-04 Marek Safar <marek.safar@seznam.cz>
4438 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
4439 in the member name duplication tests. Property and operator name duplication
4440 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
4442 2004-02-03 Marek Safar <marek.safar@seznam.cz>
4444 * interface.cs (PopulateMethod): Fixed crash when interface method
4445 returns not existing type (error test cs0246-3.cs).
4447 2004-02-02 Ravi Pratap M <ravi@ximian.com>
4449 * cs-parser.jay (interface_accessors): Re-write actions to also
4450 store attributes attached to get and set methods. Fix spelling
4453 (inteface_property_declaration): Modify accordingly.
4455 (InterfaceAccessorInfo): New helper class to store information to pass
4456 around between rules that use interface_accessors.
4458 * interface.cs (Emit): Apply attributes on the get and set
4459 accessors of properties and indexers too.
4461 * attribute.cs (ApplyAttributes): Modify accordingly to use the
4462 right MethodBuilder when applying attributes to the get and set accessors.
4464 2004-01-31 Miguel de Icaza <miguel@ximian.com>
4466 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
4468 2004-01-26 Miguel de Icaza <miguel@ximian.com>
4470 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
4472 2004-01-25 Miguel de Icaza <miguel@ximian.com>
4474 * cs-parser.jay: Remove YIELD token, instead use the new grammar
4475 changes that treat `yield' specially when present before `break'
4478 * cs-tokenizer.cs: yield is no longer a keyword.
4480 2004-01-23 Marek Safar <marek.safar@seznam.cz>
4482 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
4483 setting for default constructors.
4484 For default constructors are almost every time set wrong Modifier. The
4485 generated IL code has been alright. But inside mcs this values was
4486 wrong and this was reason why several of my CLS Compliance tests
4489 2004-01-22 Martin Baulig <martin@ximian.com>
4491 * cs-parser.jay (namespace_or_type_name): Return an Expression,
4492 not a QualifiedIdentifier. This is what `type_name_expression'
4493 was previously doing.
4494 (type_name_expression): Removed; the code is now in
4495 `namespace_or_type_name'.
4496 (qualified_identifier): Removed, use `namespace_or_type_name'
4498 (QualifiedIdentifier): Removed this class.
4500 2004-01-22 Martin Baulig <martin@ximian.com>
4502 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
4503 not a string as alias name.
4505 2004-01-21 Miguel de Icaza <miguel@ximian.com>
4507 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
4508 #52730 bug, and instead compute correctly the need to use a
4509 temporary variable when requesting an address based on the
4510 static/instace modified of the field and the constructor.
4512 2004-01-21 Martin Baulig <martin@ximian.com>
4514 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
4515 class and namespace before looking up aliases. Fixes #52517.
4517 2004-01-21 Martin Baulig <martin@ximian.com>
4519 * flowanalysis.cs (UsageVector.Merge): Allow variables being
4520 assinged in a 'try'; fixes exception4.cs.
4522 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4523 * class.cs : Implemented parameter-less constructor for TypeContainer
4525 * decl.cs: Attributes are now stored here. New property OptAttributes
4527 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
4529 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
4531 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4533 * typemanager.cs (CSharpSignature): Now reports also inner class name.
4534 (CSharpSignature): New method for indexer and property signature.
4536 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4538 * pending.cs (IsVirtualFilter): Faster implementation.
4540 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4542 * typemanager.cs: Avoid inclusion of same assembly more than once.
4544 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4546 * cs-parser.jay: Fixed problem where the last assembly attribute
4547 has been applied also to following declaration (class, struct, etc.)
4549 2004-01-21 Marek Safar <marek.safar@seznam.cz>
4551 * class.cs: Added error CS0538, CS0539 reporting.
4552 Fixed crash on Microsoft runtime when field type is void.
4554 * cs-parser.jay: Added error CS0537 reporting.
4556 * pending.cs: Added error CS0535 reporting.
4557 Improved error report for errors CS0536, CS0534.
4559 2004-01-20 Miguel de Icaza <miguel@ximian.com>
4561 Merge a few bits from the Anonymous Method MCS tree.
4563 * statement.cs (ToplevelBlock): New class for toplevel methods,
4564 will hold anonymous methods, lifted variables.
4566 * cs-parser.jay: Create toplevel blocks for delegates and for
4567 regular blocks of code.
4569 2004-01-20 Martin Baulig <martin@ximian.com>
4571 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
4572 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
4573 and `NeedExplicitReturn'; added `IsLastStatement'.
4574 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
4575 have a `ReturnLabel' or we're not unreachable.
4577 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
4578 child's reachability; don't just override ours with it. Fixes
4579 #58058 (lluis's example).
4580 (FlowBranching): Added public InTryOrCatch(), InCatch(),
4581 InFinally(), InLoop(), InSwitch() and
4582 BreakCrossesTryCatchBoundary() methods.
4584 * statement.cs (Return): Do all error checking in Resolve().
4585 Unless we are the last statement in a top-level block, always
4586 create a return label and jump to it.
4587 (Break, Continue): Do all error checking in Resolve(); also make
4588 sure we aren't leaving a `finally'.
4589 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
4590 statement in a top-level block.
4591 (Block.Flags): Added `IsDestructor'.
4592 (Block.IsDestructor): New public property.
4594 2004-01-20 Martin Baulig <martin@ximian.com>
4596 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
4598 2004-01-20 Martin Baulig <martin@ximian.com>
4600 * statement.cs (Statement.ResolveUnreachable): New public method.
4601 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
4602 (Block.Resolve): Resolve unreachable statements.
4604 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4606 * expression.cs: We need to fix the case where we do
4607 not have a temp variable here.
4609 * assign.cs: Only expression compound assignments need
4610 temporary variables.
4612 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
4614 * flowanalysis.cs: Reduce memory allocation in a few ways:
4615 - A block with no variables should not allocate a bit
4617 - A method with no out parameters does not need any tracking
4618 for assignment of the parameters, so we need not allocate
4621 public readonly Type[] VariableTypes;
4622 public readonly string[] VariableNames;
4623 Are redundant. The data is already stored in the variable
4624 map, so we need not allocate another array for it.
4625 - We need to add alot of checks for if (params | locals) == null
4626 due to the first two changes.
4628 2004-01-18 Miguel de Icaza <miguel@ximian.com>
4630 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
4631 implement IMemoryLocation, we store a copy on a local variable and
4632 take the address of it. Patch from Benjamin Jemlich
4634 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
4635 to use a special "type_name_expression" rule which reduces the
4636 number of "QualifiedIdentifier" classes created, and instead
4637 directly creates MemberAccess expressions.
4639 2004-01-17 Miguel de Icaza <miguel@ximian.com>
4641 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
4642 that fixes #52853. Null literal assignment to ValueType
4644 * class.cs (MethodData.Emit): Instead of checking the name of the
4645 method to determine if its a destructor, create a new derived
4646 class from Method called Destructor, and test for that.
4648 * cs-parser.jay: Create a Destructor object instead of a Method.
4650 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
4654 2004-01-16 Miguel de Icaza <miguel@ximian.com>
4656 * expression.cs (Binary.ResolveOperator): Perform an implicit
4657 conversion from MethodGroups to their delegate types on the
4660 * delegate.cs: Introduce a new class DelegateCreation that is the
4661 base class for `NewDelegate' and `ImplicitDelegateCreation',
4662 factor some code in here.
4664 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
4665 conversion from MethodGroups to compatible delegate types.
4667 * ecore.cs (Expression.Resolve): Do not flag error 654
4668 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
4669 we allow conversions from MethodGroups to delegate types now.
4671 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
4672 assignments in v2 either.
4674 2004-01-10 Miguel de Icaza <miguel@ximian.com>
4676 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
4677 static read-only fields in ctors.
4679 Applied patch from Benjamin Jemlich
4681 * expression.cs (UnaryMutator): Avoid leaking local variables.
4683 2004-01-09 Miguel de Icaza <miguel@ximian.com>
4685 * cs-tokenizer.cs (IsCastToken): Allow the various native types
4686 here to return true, as they can be used like this:
4690 Fixed 49836 and all the other dups
4692 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
4694 * driver.cs: Implement /win32res and /win32icon.
4696 2004-01-08 Miguel de Icaza <miguel@ximian.com>
4698 * cs-parser.jay: Add a rule to improve error handling for the
4699 common mistake of placing modifiers after the type.
4701 2004-01-07 Miguel de Icaza <miguel@ximian.com>
4703 * cs-parser.jay (interface_event_declaration): Catch
4704 initialization of events on interfaces, and report cs0068
4706 * cs-parser.jay (interface_event_declaration): Catch
4707 initialization of events.
4709 * ecore.cs: Better report missing constructors.
4711 * expression.cs (Binary.ResolveOperator): My previous bug fix had
4712 the error reporting done in the wrong place. Fix.
4714 * expression.cs (Binary.ResolveOperator): Catch the
4715 operator + (E x, E y) error earlier, and later allow for implicit
4716 conversions in operator +/- (E e, U x) from U to the underlying
4719 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
4720 52596, if the container class is abstract, the default constructor
4721 is protected otherwise its public (before, we were always public).
4723 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
4726 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
4727 Jemlich that fixes bug #52597, MCS was generating invalid code for
4728 idisposable structs. Thanks to Ben for following up with this
4731 2004-01-06 Miguel de Icaza <miguel@ximian.com>
4733 * driver.cs: Allow assemblies without code to be generated, fixes
4736 2004-01-07 Nick Drochak <ndrochak@gol.com>
4738 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
4740 2004-01-05 Miguel de Icaza <miguel@ximian.com>
4742 * cs-parser.jay: Add rules to improve error reporting if fields or
4743 methods are declared at the namespace level (error 116)
4745 * Add rules to catch event add/remove
4747 2004-01-04 David Sheldon <dave-mono@earth.li>
4749 * expression.cs: Added matching ")" to error message for
4752 2004-01-03 Todd Berman <tberman@gentoo.org>
4754 * ecore.cs, attribute.cs:
4755 Applying fix from #52429.
4757 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4759 * ecore.cs, expression.cs, statement.cs:
4760 Total rewrite of how we handle branching. We
4761 now handle complex boolean expressions with fewer
4762 jumps. As well if (x == 0) no longer emits a ceq.
4764 if (x is Foo) is much faster now, because we generate
4767 Overall, we get a pretty big improvement on our benchmark
4768 tests. The code we generate is smaller and more readable.
4770 I did a full two-stage bootstrap. The patch was reviewed
4771 by Martin and Miguel.
4773 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4775 * cs-parser.jay: Make primary_expression not take a QI.
4776 we dont need this because the member_access rule covers
4777 us here. So we replace the rule with just IDENTIFIER.
4779 This has two good effects. First, we remove a s/r conflict.
4780 Second, we allocate many fewer QualifiedIdentifier objects.
4782 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4784 * attribute.cs: Handle MarshalAs attributes as pseudo, and
4785 set the correct information via SRE. This prevents
4786 hanging on the MS runtime. Fixes #29374.
4788 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
4790 * convert.cs: correctly handle conversions to value types
4791 from Enum and ValueType as unboxing conversions.
4793 Fixes bug #52569. Patch by Benjamin Jemlich.
4795 2004-01-02 Ravi Pratap <ravi@ximian.com>
4797 * expression.cs (BetterConversion): Prefer int -> uint
4798 over int -> ulong (csc's behaviour). This fixed bug #52046.
4800 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
4802 * decl.cs (MemberCache.FindMembers): now returns a
4805 * typemanager.cs: In general, go with with ^^.
4806 (CopyNewMethods): take an IList.
4807 (RealMemberLookup): Only allocate an arraylist
4808 if we copy from two sets of methods.
4810 This change basically does two things:
4811 1) Fewer array lists allocated due to CopyNewMethods.
4812 2) the explicit cast in MemberList costed ALOT.
4814 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
4816 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
4817 a hashtable to avoid needless string allocations when an identifier is
4818 used more than once (the common case).
4820 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4822 * pending.cs: MS's TypeBuilder.GetInterfaces ()
4823 is broken, it will not return anything. So, we
4824 have to use the information we have in mcs to
4827 * typemanager.cs: Add a cache for GetInterfaces,
4828 since this will now be used more often (due to ^^)
4830 (GetExplicitInterfaces) New method that gets the
4831 declared, not effective, interfaces on a type
4832 builder (eg, if you have interface IFoo, interface
4833 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
4836 This patch makes MCS able to bootstrap itself on
4839 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
4841 * expression.cs: Remove the Nop's that Miguel put
4844 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4846 * report.cs, codegen.cs: Give the real stack trace to
4847 the error when an exception is thrown.
4849 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4851 * decl.cs: only allocate hashtables for ifaces if
4854 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
4856 * expression.cs: fix the error from cs0121-2.cs
4857 (a parent interface has two child interfaces that
4858 have a function with the same name and 0 params
4859 and the function is called through the parent).
4861 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
4863 * class.cs, rootcontext.cs, typmanager.cs: do not
4866 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
4868 * codegen.cs: remove stack for the ec flow branching.
4869 It is already a linked list, so no need.
4871 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
4873 * Makefile: Allow custom profiler here.
4875 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4877 * typemanager.cs (LookupType):
4878 - Use a static char [], because split takes
4879 a param array for args, so it was allocating
4881 - Do not store true in a hashtable, it boxes.
4883 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
4885 * flowanalysis.cs: bytify common enums.
4887 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4889 * modifiers.cs: Add a new set of flags for the
4890 flags allowed on explicit interface impls.
4891 * cs-parser.jay: catch the use of modifiers in
4892 interfaces correctly.
4893 * class.cs: catch private void IFoo.Blah ().
4895 All related to bug #50572.
4897 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4899 * decl.cs: Rewrite the consistant accessability checking.
4900 Accessability is not linear, it must be implemented in
4901 a tableish way. Fixes #49704.
4903 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
4905 * expression.cs: Handle negation in a checked context.
4906 We must use subtraction from zero. Fixes #38674.
4908 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4910 * class.cs: Ignore static void main in DLLs.
4911 * rootcontext.cs: Handle the target type here,
4912 since we are have to access it from class.cs
4913 * driver.cs: account for the above.
4915 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
4917 * report.cs: Give line numbers and files if available.
4919 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
4921 * driver.cs: Implement /addmodule.
4923 * typemanager.cs: Change 'modules' field so it now contains Modules not
4926 2003-12-20 Martin Baulig <martin@ximian.com>
4928 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
4929 (FieldBase.IsAssigned): Removed this field.
4930 (FieldBase.SetAssigned): New public method.
4931 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
4933 2003-12-20 Martin Baulig <martin@ximian.com>
4935 * expression.cs (LocalVariableReference.DoResolve): Don't set
4936 `vi.Used' if we're called from DoResolveLValue().
4938 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
4939 returns the usage vector it just merged into the current one -
4940 pass this one to UsageWarning().
4941 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
4942 of the `EmitContext', don't call this recursively on our children.
4944 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
4946 * driver.cs: Implement /target:module.
4948 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
4950 * support.cs (CharArrayHashtable): New helper class.
4952 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
4953 char arrays, not strings, so we can avoid creating a string in
4954 consume_identifier if the identifier is a keyword.
4956 2003-12-16 Martin Baulig <martin@ximian.com>
4958 * statement.cs (LocalInfo.Assigned): Removed this property.
4959 (LocalInfo.Flags): Removed `Assigned'.
4960 (LocalInfo.IsAssigned): New public method; takes the EmitContext
4961 and uses flow analysis.
4962 (Block.UsageWarning): Made this method private.
4963 (Block.Resolve): Call UsageWarning() if appropriate.
4965 * expression.cs (LocalVariableReference.DoResolve): Always set
4966 LocalInfo.Used here.
4968 2003-12-13 Martin Baulig <martin@ximian.com>
4970 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
4971 any value here; we're now using flow analysis to figure out
4972 whether a statement/block returns a value.
4974 2003-12-13 Martin Baulig <martin@ximian.com>
4976 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
4978 (FlowBranching.MergeFinally): Don't call
4979 `branching.CheckOutParameters()' here, this is called in
4981 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
4982 when adding the `finally' vector.
4984 2003-12-13 Martin Baulig <martin@ximian.com>
4987 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
4988 actually work and also fix #48962.
4990 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
4992 * decl.cs: Do not check System.Object for nested types,
4993 since we know it does not have any. Big bang for buck:
4998 corlib: 17.99 seconds
5002 corlib: 17.39 seconds
5004 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
5006 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
5007 time we are returning 0 members, so we save alot here.
5009 2003-12-11 Martin Baulig <martin@ximian.com>
5011 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
5012 `MergeChild()', also just take the `FlowBranching' as argument;
5013 call Merge() on it and return the result.
5014 (FlowBranching.Merge): We don't need to do anything if we just
5017 2003-12-11 Martin Baulig <martin@ximian.com>
5019 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
5020 them in an `ArrayList' to reduce memory usage. Thanks to Ben
5021 Maurer for this idea.
5023 2003-12-11 Martin Baulig <martin@ximian.com>
5025 * flowanalysis.cs (MergeResult): This class is now gone; we now
5026 use the `UsageVector' for this. The reason for this is that if a
5027 branching just has one sibling, we don't need to "merge" them at
5028 all - that's the next step to do.
5029 (FlowBranching.Merge): We now return a `UsageVector' instead of a
5032 2003-12-11 Martin Baulig <martin@ximian.com>
5034 Reworked flow analyis and made it more precise and bug-free. The
5035 most important change is that we're now using a special `Reachability'
5036 class instead of having "magic" meanings of `FlowReturns'. I'll
5037 do some more cleanups and optimizations and also add some more
5038 documentation this week.
5040 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
5041 largely reworked this class.
5042 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
5043 the new `Reachability' class instead of having "magic" values here.
5044 (FlowBranching): We're now using an instance of `Reachability'
5045 instead of having separate `Returns', `Breaks' etc. fields.
5047 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
5048 based on flow analysis; ignore the return value of block.Emit ().
5050 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
5052 * driver.cs typemanager.cs: Find the mono extensions to corlib even
5053 if they are private.
5055 2003-12-09 Martin Baulig <martin@ximian.com>
5057 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
5058 call them directly on the UsageVector.
5060 2003-12-09 Martin Baulig <martin@ximian.com>
5062 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
5063 Changed return type from `FlowReturns' to `Reachability'.
5065 2003-12-09 Martin Baulig <martin@ximian.com>
5067 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
5068 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
5069 `Reachable' fields with a single `Reachability' one.
5071 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5073 * class.cs (FindMembers): Remove foreach's.
5086 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5091 This patch does a few things:
5092 1. EmptyStatement is now a singleton, so it is never reallocated.
5093 2. All blah is EmptyStatement constructs have been changed to
5094 blah == EmptyStatement.Value, which is much faster and valid
5095 now that EmptyStatement is a singleton.
5096 3. When resolving a block, rather than allocating a new array for
5097 the non-empty statements, empty statements are replaced with
5098 EmptyStatement.Value
5099 4. Some recursive functions have been made non-recursive.
5100 Mainly the performance impact is from (3), however (1) and (2) are needed for
5101 this to work. (4) does not make a big difference in normal situations, however
5102 it makes the profile look saner.
5107 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5108 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
5109 Total memory allocated: 56397 KB
5112 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
5113 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
5114 Total memory allocated: 55666 KB
5116 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5118 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
5119 than the hashtable in a hashtable version
5121 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
5122 we always end up concating a string. This results in a huge perf
5123 loss, because many strings have to be tracked by the GC. In this
5124 patch, we first use a hashtable that works with two keys, so that
5125 the strings do not need to be concat'ed.
5136 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
5138 * Makefile: Add a new target `do-time' that does a quick and simple
5139 profile, leaving easy to parse output.
5141 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
5143 * codegen.cs (Init): Create the dynamic assembly with
5144 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
5146 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
5148 * support.cs: Make the PtrHashtable use only one
5149 instance of its comparer.
5151 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
5153 * typemanager.cs: Fix lookup of GetNamespaces.
5155 2003-11-29 Miguel de Icaza <miguel@ximian.com>
5157 * expression.cs: Removed redundant line.
5159 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
5160 ArrayLists, use for loops with bounds.
5162 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
5165 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
5166 arraylists, use for loop with bounds.
5168 The above three changes give us a 0.071 second performance
5169 improvement out of 3.294 seconds down to 3.223. On my machine
5170 the above changes reduced the memory usage by 1,387 KB during
5173 * cs-parser.jay (QualifiedIdentifier): New class used to represent
5174 QualifiedIdentifiers. Before we created a new string through
5175 concatenation, and mostly later on, the result would be
5176 manipulated by DecomposeQI through string manipulation.
5178 This reduced the compiler memory usage for bootstrapping from
5179 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
5180 compile times in 0.05 seconds.
5182 2003-11-28 Dick Porter <dick@ximian.com>
5184 * support.cs: Do string compares with the Invariant culture.
5192 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
5193 the comparison is done with the Invariant culture.
5195 2003-11-27 Miguel de Icaza <miguel@ximian.com>
5197 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
5198 GetEnumerator method.
5200 (ProbeCollectionType): Iterate starting at the most specific type
5201 upwards looking for a GetEnumerator
5203 * expression.cs: Shift count can be up to 31 for int/uint and 63
5206 2003-11-26 Miguel de Icaza <miguel@ximian.com>
5208 * statement.cs (Block.LookupLabel): Also look for the label on the
5209 children blocks. Use a hash table to keep track of visited
5212 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
5213 we actually did transform the other operand, otherwise fall back
5214 to the common codepath that casts to long.
5216 * cs-tokenizer.cs: Use the same code pattern as the int case.
5217 Maybe I should do the parsing myself, and avoid depending on the
5218 Parse routines to get this done.
5220 2003-11-25 Miguel de Icaza <miguel@ximian.com>
5222 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5223 which fixes bug 51347. This time test it.
5225 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
5226 attributes for example can not tell the difference between these.
5227 The difference was only a syntax feature of the language.
5229 * attribute.cs: Apply attributes to delegates.
5231 * delegate.cs: Call the apply attributes method.
5233 2003-11-24 Miguel de Icaza <miguel@ximian.com>
5235 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
5236 comparing 0 vs Byte.MinValue, not the value
5238 (ImplicitConversionRequired): When reporting a conversion error,
5239 use error 31 to print out the constant error instead of the
5242 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
5243 which fixes bug 51347.
5245 2003-11-22 Miguel de Icaza <miguel@ximian.com>
5247 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
5248 which fixes the -warnaserror command line option.
5250 2003-11-21 Miguel de Icaza <miguel@ximian.com>
5252 * cfold.cs (DoNumericPromotions): During constant folding of
5253 additions on UIntConstant, special case intconstants with
5254 IntConstants like we do on the expression binary operator.
5256 2003-11-12 Miguel de Icaza <miguel@ximian.com>
5258 * convert.cs (ImplicitReferenceConversion): We were missing a case
5259 (System.Enum are not value types or class types, so we need to
5260 classify them separatedly).
5262 * driver.cs: We do not support error 2007.
5264 2003-11-12 Jackson Harper <jackson@ximian.com>
5266 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
5267 system directory. Also use the full file name so users can
5268 libraries names mscorlib-o-tron.dll in a non system dir.
5270 2003-11-10 Martin Baulig <martin@ximian.com>
5272 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
5273 (TypeManager.InitCoreTypes): Initialize them here, but instead of
5274 calling `ResolveType()' on them, directly assign their `Type'.
5276 2003-11-08 Martin Baulig <martin@ximian.com>
5278 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
5279 return value and the `out parent' parameter.
5280 (TypeContainer.DefineType): Moved the CS0644 check into
5281 GetClassBases(). Don't pass the interface types to the
5282 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
5283 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
5285 * ecore.cs (TypeExpr.IsAttribute): New property.
5286 (TypeExpr.GetInterfaces): New method.
5288 * interface.cs (Interface.GetInterfaceTypeByName): Return a
5289 TypeExpr instead of a Type.
5290 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
5291 (Interface.DefineType): Don't pass the interface types to the
5292 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
5293 them later and then call `TypeBulider.AddInterfaceImplementation()'.
5295 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
5296 instead of a `Type[]'.
5297 (TypeManager.RegisterBuilder): Likewise.
5298 (TypeManager.AddUserInterface): Likewise.
5299 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
5300 `Type[]' and also return a `TypeExpr[]'.
5301 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
5303 2003-11-08 Martin Baulig <martin@ximian.com>
5305 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
5308 2003-11-08 Martin Baulig <martin@ximian.com>
5310 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
5311 TypeManager.ResolveExpressionTypes().
5313 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
5314 instead of an Expression.
5315 (TypeExpr): This is now an abstract base class for `TypeExpression'.
5316 (TypeExpression): New public class; formerly known as `TypeExpr'.
5318 * expression.cs (ComposedCast): Derive from TypeExpr.
5320 * typemanager.cs (TypeManager.system_*_expr): These are now
5321 TypExpr's instead of Expression's.
5322 (TypeManager.ResolveExpressionTypes): New public static function;
5323 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
5326 2003-11-06 Miguel de Icaza <miguel@ximian.com>
5328 * expression.cs (New.DoResolve): Do not dereference value that
5329 might be a null return.
5331 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
5332 sure that the constant value has the right type. Fixes an
5333 unreported bug, similar to 50425.
5335 * const.cs (Const.LookupConstantValue): Call
5336 ImplicitStandardConversionExists before doing a conversion to
5337 avoid havng the TypeManager.ChangeType do conversions.
5339 Reduced the number of casts used
5341 (Const.ChangeType): New routine to enable reuse of the constant
5342 type changing code from statement.
5344 * typemanager.cs (ChangeType): Move common initialization to
5345 static global variables.
5349 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
5350 every value type to go through, even if it was void. Fix that.
5352 * cs-tokenizer.cs: Use is_identifier_start_character on the start
5353 character of the define, and the is_identifier_part_character for
5354 the rest of the string.
5356 2003-11-05 Miguel de Icaza <miguel@ximian.com>
5358 * expression.cs (UnaryMutator.EmitCode): When I updated
5359 LocalVariableReference.DoResolve, I overdid it, and dropped an
5360 optimization done on local variable references.
5362 2003-11-04 Miguel de Icaza <miguel@ximian.com>
5364 * ecore.cs: Convert the return from Ldlen into an int.
5366 2003-10-20 Miguel de Icaza <miguel@ximian.com>
5368 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
5369 the accessibility, this is a special case for toplevel non-public
5370 classes (internal for instance).
5372 2003-10-20 Nick Drochak <ndrochak@gol.com>
5374 * ecore.cs: Fix typo and build. Needed another right paren.
5376 2003-10-19 Miguel de Icaza <miguel@ximian.com>
5378 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
5379 `internal' case regular and protected, but not allowing protected
5380 to be evaluated later. Bug 49840
5382 2003-10-15 Miguel de Icaza <miguel@ximian.com>
5384 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
5385 to kb.Nlast, and not the kb.nFirst to isolate the switch
5388 Extract the underlying type, so enumerations of long/ulong are
5389 treated like long/ulong.
5391 2003-10-14 Miguel de Icaza <miguel@ximian.com>
5393 * expression.cs (New): Overload the meaning of RequestedType to
5394 track the possible creation of the NewDelegate type, since
5395 DoResolve is invoked more than once for new constructors on field
5398 See bugs: #48800 and #37014
5400 * cs-parser.jay (declare_local_constants): Take an arraylist
5401 instead of a single constant.
5403 (local_constant_declaration): It should take a
5404 constant_declarators, not a constant_declarator. Fixes 49487
5406 * convert.cs: Fix error report.
5408 2003-10-13 Jackson Harper <jackson@ximian.com>
5410 * typemanager.cs (TypeToCoreType): Add float and double this fixes
5413 2003-10-09 Martin Baulig <martin@ximian.com>
5415 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
5417 (MethodCore.DoDefineParameters): Removed the TypeContainer
5418 argument; use the DeclSpace which was passed to the .ctor instead.
5419 (MethodCore.CheckParameter): Take a DeclSpace instead of a
5420 TypeContainer; we only need a DeclSpace here.
5422 2003-10-09 Martin Baulig <martin@ximian.com>
5424 * class.cs (MethodData): Added additional `DeclSpace ds' argument
5426 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
5427 EmitContext's .ctor.
5429 2003-10-09 Martin Baulig <martin@ximian.com>
5431 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
5432 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
5433 AsAccessible(), moved them as well.
5435 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
5437 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
5439 * cs-parser.jay : Renamed yyName to yyNames related to jay.
5441 2003-10-07 Miguel de Icaza <miguel@ximian.com>
5443 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
5444 generation for >=, as spotted by Paolo, bug 48679.
5445 Patch from David Waite.
5447 * cs-tokenizer.cs: Add handling for #pragma.
5449 * cs-parser.jay: Allow for both yield and yield return in the
5450 syntax. The anti-cobolization of C# fight will go on!
5452 * class.cs (TypeBuilder.DefineType): Catch error condition here
5453 (Parent.DefineType erroring out and returning null).
5455 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
5456 coping with enumerations variables, we were mistakenly processing
5457 them as a regular value type instead of built-in types. Fixes the
5460 * typemanager.cs (IsBuiltinOrEnum): New method.
5462 2003-09-30 Miguel de Icaza <miguel@ximian.com>
5464 * cs-parser.jay: Upgrade: yield now needs the return clause.
5466 2003-09-19 Martin Baulig <martin@ximian.com>
5468 * decl.cs (MemberCache.SetupCacheForInterface): Take a
5469 `MemberCache parent' argument. Normally, an interface doesn't
5470 have a parent type except System.Object, but we use this in gmcs
5471 for generic type parameters.
5473 2003-09-18 Martin Baulig <martin@ximian.com>
5475 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
5476 on `type.IsInterface'; don't check whether the type has a parent
5477 to determine whether it's an interface.
5479 2003-09-15 Martin Baulig <martin@ximian.com>
5481 * class.cs (TypeContainer.DefineType): Added an error flag to
5482 avoid reporting duplicate CS0146's ("class definition is
5485 * driver.cs (Driver.MainDriver): Abort if
5486 RootContext.ResolveTree() reported any errors.
5488 2003-09-07 Martin Baulig <martin@ximian.com>
5490 * report.cs (Error, Warning): Added overloaded versions which take
5491 a `params object[] args' and call String.Format().
5493 2003-09-07 Martin Baulig <martin@ximian.com>
5495 * decl.cs (DeclSpace..ctor): Don't call
5496 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
5497 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
5498 (DeclSpace.RecordDecl): New method.
5500 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
5502 2003-09-02 Ravi Pratap <ravi@ximian.com>
5504 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
5505 value attributes to be applied to ParameterBuilders.
5507 * class.cs (MethodCore.LabelParameters): Make static and more
5508 generic so that it can be used from other places - like interface
5509 methods, for instance.
5511 * interface.cs (Interface.Emit): Call LabelParameters before
5512 emitting attributes on the InterfaceMethod.
5514 2003-08-26 Martin Baulig <martin@ximian.com>
5516 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
5517 resolving aliases; fixes #47927.
5519 2003-08-26 Martin Baulig <martin@ximian.com>
5521 * statement.cs (Using.DoResolve): This is internally emitting a
5522 try/finally clause, so we need to set ec.NeedExplicitReturn if we
5523 do not always return. Fixes #47681.
5525 2003-08-26 Martin Baulig <martin@ximian.com>
5527 * decl.cs (MemberCore): Moved WarningNotHiding(),
5528 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
5530 (AdditionResult): Make this nested in DeclSpace.
5531 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
5532 argument; call NamespaceEntry.Define() unless we're nested in a
5535 * namespace.cs (Namespace.DefineName): New public function. This
5536 is called from DeclSpace's .ctor to add
5537 (Namespace.Lookup): Include DeclSpaces in the lookup.
5539 * class.cs (Operator): Derive from MemberBase, not MemberCore.
5541 * const.cs (Const): Derive from MemberBase, not MemberCore.
5543 2003-08-25 Martin Baulig <martin@ximian.com>
5545 * convert.cs (Convert.ExplicitReferenceConversion): When
5546 converting from an interface type to a class, unbox if the target
5547 type is a struct type. Fixes #47822.
5549 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
5551 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
5554 2003-08-22 Martin Baulig <martin@ximian.com>
5556 * class.cs (TypeManager.DefineType): When defining a nested type,
5557 call DefineType() on our parent; fixes #47801.
5559 2003-08-22 Martin Baulig <martin@ximian.com>
5561 * class.cs (MethodData.Define): While checking if a method is an
5562 interface implementation, improve the test a bit more to fix #47654.
5564 2003-08-22 Martin Baulig <martin@ximian.com>
5566 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
5567 correctly; fixes #47722.
5569 2003-08-22 Martin Baulig <martin@ximian.com>
5571 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
5572 LocalVariableReference, ensure it's not read-only. Fixes #47536.
5574 * statement.cs (Fixed.DoResolve): Make all variables read-only.
5576 2003-08-22 Martin Baulig <martin@ximian.com>
5578 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
5579 can only be assigned in static constructors. Fixes #47161.
5581 2003-08-22 Martin Baulig <martin@ximian.com>
5583 Rewrote and improved the flow analysis code.
5585 * flowbranching.cs (FlowBranching): Make this class abstract.
5586 (FlowBranching.CreateBranching): New static function to create a
5588 (FlowBranchingBlock, FlowBranchingException): New classes.
5589 (FlowBranching.UsageVector.Type): New public readonly field.
5590 (FlowBranching.UsageVector.Breaks): Removed the setter.
5591 (FlowBranching.UsageVector.Returns): Removed the setter.
5592 (FlowBranching.UsageVector): Added Break(), Return(),
5593 NeverReachable() and Throw() methods to modify the reachability.
5594 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
5595 done by FlowBranching.Merge().
5596 (FlowBranching.UsageVector.MergeChild): New method; merges the
5597 merge result into the current vector.
5598 (FlowBranching.Merge): New abstract method to merge a branching.
5600 2003-08-12 Martin Baulig <martin@ximian.com>
5602 * expression.cs (Indirection.CacheTemporaries): Create the
5603 LocalTemporary with the pointer type, not its element type.
5605 2003-08-10 Miguel de Icaza <miguel@ximian.com>
5607 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
5608 token was a keyword or not.
5610 Add `error' options where an IDENTIFIER was expected; Provide
5611 CheckToken and CheckIdentifierToken convenience error reporting
5614 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
5616 * decl.cs: Rename `NamespaceEntry Namespace' public field into
5617 NameSpaceEntry NameSpaceEntry.
5619 (LookupInterfaceOrClass): Avoid creating a full qualified name
5620 from namespace and name: avoid doing lookups when we know the
5621 namespace is non-existant. Use new Tree.LookupByNamespace which
5622 looks up DeclSpaces based on their namespace, name pair.
5624 * driver.cs: Provide a new `parser verbose' to display the
5625 exception thrown during parsing. This is turned off by default
5626 now, so the output of a failure from mcs is more graceful.
5628 * namespace.cs: Track all the namespaces defined in a hashtable
5631 (IsNamespace): New method
5633 2003-08-09 Miguel de Icaza <miguel@ximian.com>
5635 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
5636 we know that we need to concatenate (full typename can never be
5641 * statement.cs: Use a bitfield; Do not initialize to null things
5642 which are done by the constructor by default.
5644 * cs-parser.jay: bug fix, parameter was 4, not 3.
5646 * expression.cs: Just use the property;
5648 * statement.cs: No need for GetVariableInfo method.
5650 2003-08-08 Martin Baulig <martin@ximian.com>
5652 * flowanalysis.cs (FlowReturns): This is now nested in the
5653 `FlowBranching' class.
5654 (MyBitVector): Moved this here from statement.cs.
5655 (FlowBranching.SiblingType): New enum type.
5656 (FlowBranching.CreateSibling): Added `SiblingType' argument.
5658 2003-08-07 Martin Baulig <martin@ximian.com>
5660 * flowanalysis.cs (FlowBranchingType): This is now nested in the
5661 `FlowBranching' class and called `BranchingType'.
5663 2003-08-07 Martin Baulig <martin@ximian.com>
5665 * flowanalysis.cs: Moved all the control flow analysis code into
5668 2003-08-07 Martin Baulig <martin@ximian.com>
5670 * assign.cs (Assign.DoResolve): `target' must either be an
5671 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
5674 2003-08-07 Miguel de Icaza <miguel@ximian.com>
5676 * expression.cs (BinaryMethod): This kind of expression is created by the
5677 Binary class if it determines that the operator has to be handled
5680 (BinaryDelegate): This kind of expression is created if we are
5681 dealing with a + or - operator on delegates.
5683 (Binary): remove method, argumetns, and DelegateOperator: when
5684 dealing with methods,
5686 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
5688 * statement.cs (Block): use bitfields for the three extra booleans
5689 we had in use. Remove unused topblock parameter.
5691 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
5693 * assign.cs: Drop extra unneeded tests.
5695 2003-08-06 Miguel de Icaza <miguel@ximian.com>
5697 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
5699 * statement.cs (Foreach): Use VariableStorage instead of
5702 * codegen.cs (VariableStorage): New class used by clients that
5703 require a variable stored: locals or fields for variables that
5704 need to live across yield.
5706 Maybe provide a convenience api for EmitThis+EmitLoad?
5708 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
5711 2003-08-05 Miguel de Icaza <miguel@ximian.com>
5713 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
5714 RemapParameterLValue): New methods that are used to turn a
5715 precomputed FieldInfo into an expression like this:
5719 The idea is to use this instead of making LocalVariableReference
5720 have more than one meaning.
5722 * cs-parser.jay: Add error production to BASE.
5724 * ecore.cs: Deal with TypeManager.GetField returning null, which
5725 is now a valid return value.
5727 (FieldExprNoAddress): New expression for Fields whose address can
5730 * expression.cs (LocalVariableReference): During the resolve
5731 phases, create new expressions if we are in a remapping context.
5732 Remove code that dealt with remapping here.
5734 (ParameterReference): same.
5736 (ProxyInstance): New expression, like the `This' expression, but
5737 it is born fully resolved. We know what we are doing, so remove
5738 the errors that are targeted to user-provided uses of `this'.
5740 * statement.cs (Foreach): our variable is now stored as an
5741 Expression; During resolution, follow the protocol, dont just
5742 assume it will return this.
5744 2003-08-06 Martin Baulig <martin@ximian.com>
5746 * support.cs (SeekableStreamReader.cs): New public class.
5748 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
5749 SeekableStreamReader instead of the normal StreamReader.
5751 2003-08-04 Martin Baulig <martin@ximian.com>
5753 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
5754 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
5755 deambiguate casts and delegate invocations.
5756 (parenthesized_expression): Use the new tokens to ensure this is
5757 not a cast of method invocation.
5759 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
5760 when reading a `)' and Deambiguate_CloseParens () was previously
5763 * expression.cs (ParenthesizedExpression): New class. This is
5764 just used for the CS0075 test.
5765 (Binary.DoResolve): Check for CS0075.
5767 2003-07-29 Ravi Pratap <ravi@ximian.com>
5769 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
5770 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
5771 reference comparison.
5773 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
5774 examine the ReturnType for equality - this is necessary in the
5775 cases of implicit and explicit operators whose signature also
5776 includes the return type.
5778 2003-07-26 Miguel de Icaza <miguel@ximian.com>
5780 * namespace.cs: Cache the result of the namespace computation,
5781 instead of computing it every time.
5783 2003-07-24 Miguel de Icaza <miguel@ximian.com>
5785 * decl.cs: Use a global arraylist that we reuse over invocations
5786 to avoid excesive memory consumption. Reduces memory usage on an
5787 mcs compile by one meg (45 average).
5789 * typemanager.cs (LookupTypeReflection): In .NET pointers are
5790 private, work around that.
5792 2003-07-23 Miguel de Icaza <miguel@ximian.com>
5794 * literal.cs (IntLiteral): Define Zero and One static literals.
5796 * cs-parser.jay (integer_literal): use static literals to reduce
5797 memory usage for the most used literals (0, 1 and -1). 211kb
5798 reduced in memory usage.
5800 Replace all calls to `new ArrayList' with `new
5801 ArrayList(4)' which is a good average number for most allocations,
5802 and also requires only 16 bytes of memory for its buffer by
5805 This reduced MCS memory usage in seven megabytes for the RSS after
5808 2003-07-28 Ravi Pratap <ravi@ximian.com>
5810 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
5811 handle params methods the correct way by forming only one
5812 applicable set with params and normal methods in them. Earlier we
5813 were looking at params methods only if we found no normal methods
5814 which was not the correct thing to do.
5816 (Invocation.BetterFunction): Take separate arguments indicating
5817 when candidate and the best method are params methods in their
5820 This fixes bugs #43367 and #46199.
5822 * attribute.cs: Documentation updates.
5824 (CheckAttribute): Rename to CheckAttributeTarget.
5825 (GetValidPlaces): Rename to GetValidTargets.
5827 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
5828 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
5832 2003-07-28 Martin Baulig <martin@ximian.com>
5834 * class.cs (TypeContainer.DefineMembers): Use the base type's full
5835 name when looking up the base class of a nested class. Fixes #46977.
5837 2003-07-26 Martin Baulig <martin@ximian.com>
5839 * expression.cs (Indexers.Indexer): New nested struct; contains
5840 getter, setter and the indexer's type.
5841 (Indexers.Properties): This is now an ArrayList of
5843 (IndexerAccess.DoResolveLValue): Correctly set the type if the
5844 indexer doesn't have any getters.
5846 * assign.cs (Assign.DoResolve): Also do the implicit conversions
5847 for embedded property and indexer assignments.
5849 2003-07-26 Martin Baulig <martin@ximian.com>
5851 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
5852 preprocessor directive is not the first non-whitespace character
5855 2003-07-26 Martin Baulig <martin@ximian.com>
5857 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
5858 namespace parsing, follow the spec more closely.
5860 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
5861 NamespaceEntry.Lookup().
5863 2003-07-25 Martin Baulig <martin@ximian.com>
5865 * MethodCore.cs (OverridesSomething): New public field; it's set
5866 from TypeContainer.DefineMembers if this method overrides
5867 something (which doesn't need to be a method). Fix #39462.
5869 2003-07-25 Ravi Pratap <ravi@ximian.com>
5871 * typemanager.cs (GetMembers): Ensure that the list of members is
5872 reversed. This keeps things in sync.
5874 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
5875 find an AttributeUsage attribute.
5877 * expression.cs (Invocation.OverloadResolve): Perform the check
5878 which disallows Invoke to be directly called on a Delegate.
5880 (Error_InvokeOnDelegate): Report error cs1533.
5882 2003-07-25 Martin Baulig <martin@ximian.com>
5884 * expression.cs (Indexers.GetIndexersForType): Only look in the
5885 interface hierarchy if the requested type is already an
5886 interface. Fixes #46788 while keeping #46502 fixed.
5888 2003-07-25 Martin Baulig <martin@ximian.com>
5890 * class.cs (TypeContainer.DefineMembers): Check whether all
5891 readonly fields have been assigned and report warning CS0649 if
5894 * statement.cs (LocalInfo.IsFixed): Always return true if this is
5897 2003-07-24 Ravi Pratap <ravi@ximian.com>
5899 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
5900 returned from GetMethods to make things consistent with the
5901 assumptions MCS makes about ordering of methods.
5903 This should comprehensively fix bug #45127 and it does :-)
5905 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
5906 ordering is actually reverse.
5908 * Clean up some debug messages I left lying around.
5910 * interface.cs (Populate*): Get rid of code which emits attributes
5911 since the stage in which we emit attributes is the 'Emit' stage,
5912 not the define stage.
5914 (Emit): Move attribute emission for interface members here.
5916 2003-07-22 Ravi Pratap <ravi@ximian.com>
5918 * expression.cs (Invocation.OverloadResolve): Follow the spec more
5919 closely: we eliminate methods in base types when we have an
5920 applicable method in a top-level type.
5922 Please see section 14.5.5.1 for an exact description of what goes
5925 This fixes bug #45127 and a host of other related to corlib compilation.
5927 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
5928 array is the method corresponding to the top-level type (this is
5929 because of the changes made to icall.c) so we change this
5932 (MethodGroupExpr.Name): This too.
5934 * typemanager.cs (GetElementType): New method which does the right
5935 thing when compiling corlib.
5937 * everywhere: Make use of the above in the relevant places.
5939 2003-07-22 Martin Baulig <martin@ximian.com>
5941 * cs-parser.jay (invocation_expression): Moved
5942 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
5943 `cast_expression', but create a InvocationOrCast which later
5944 resolves to either an Invocation or a Cast.
5946 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
5947 method; call this before EmitStatement() to make sure that this
5948 expression can be used as a statement.
5950 * expression.cs (InvocationOrCast): New class; resolves to either
5951 an Invocation or a Cast.
5953 * statement.cs (StatementExpression): Call ResolveStatement() on
5954 the ExpressionStatement before emitting it.
5956 2003-07-21 Martin Baulig <martin@ximian.com>
5958 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
5959 `ref' and `out' attributes match; fixes #46220.
5960 (MemberAccess.ResolveMemberAccess): You can't reference a type
5961 through an expression; fixes #33180.
5962 (Indexers.GetIndexersForType): Don't return the indexers from
5963 interfaces the class implements; fixes #46502.
5965 2003-07-21 Martin Baulig <martin@ximian.com>
5967 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
5968 CS0661 checks; fixes bug #30442.
5970 2003-07-21 Martin Baulig <martin@ximian.com>
5972 * decl.cs (AdditionResult): Added `Error'.
5974 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
5976 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
5977 makes cs0031.cs actually work.
5979 2003-07-20 Martin Baulig <martin@ximian.com>
5981 * namespace.cs: Fixed that bug which caused a crash when compiling
5984 2003-07-20 Miguel de Icaza <miguel@ximian.com>
5986 * typemanager.cs (LookupTypeReflection): Never expose types which
5987 are NotPublic, NestedPrivate, NestedAssembly, or
5988 NestedFamANDAssem. We used to return these, and later do a check
5989 that would report a meaningful error, but the problem is that we
5990 would not get the real match, if there was a name override.
5992 2003-07-18 Miguel de Icaza <miguel@ximian.com>
5994 * namespace.cs (Namespace, Name): Do not compute the namespace
5995 name dynamically, compute it in the constructor. This reduced
5996 memory usage by 1697 KB.
5998 * driver.cs: Use --pause to pause at the end.
6000 2003-07-17 Peter Williams <peter@newton.cx>
6002 * Makefile: Change the name of the test target so that it doesn't
6003 conflict with the recursive test target.
6005 2003-07-17 Miguel de Icaza <miguel@ximian.com>
6007 * expression.cs (LocalVariableReference.Emit, EmitAssign,
6008 AddressOf): Do not use EmitThis, that was wrong, use the actual
6011 2003-07-15 Miguel de Icaza <miguel@ximian.com>
6013 * class.cs (MethodData.Define): While checking if a method is an
6014 interface implementation, improve the test: If we are not public
6015 (use new test here: use the computed MethodAttributes directly,
6016 instead of the parsed modifier flags) check if the `implementing'
6017 method comes from an interface or not.
6019 * pending.cs (VerifyPendingMethods): Slightly better error
6022 * makefile: add test target that does the mcs bootstrap.
6024 2003-07-16 Ravi Pratap <ravi@ximian.com>
6026 * interface.cs (Define): Do nothing here since there are no
6027 members to populate etc. Move the attribute emission out of here
6028 since this was just totally the wrong place to put it. Attribute
6029 application happens during the 'Emit' phase, not in the 'Define'
6032 (Emit): Add this method and move the attribute emission here
6034 * rootcontext.cs (EmitCode): Call the Emit method on interface
6037 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6039 * expression.cs (OverloadResolve): Report error only if Location
6040 is not 'Null' which means that there was a probe going on.
6042 2003-07-14 Martin Baulig <martin@ximian.com>
6044 * expression.cs (ConditionalLogicalOperator): New public class to
6045 implement user defined conditional logical operators.
6046 This is section 14.11.2 in the spec and bug #40505.
6048 2003-07-14 Martin Baulig <martin@ximian.com>
6050 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
6052 2003-07-14 Martin Baulig <martin@ximian.com>
6054 * codegen.cs (EmitContext.InFixedInitializer): New public field.
6056 * ecore.cs (IVariable.VerifyFixed): New interface method.
6058 * expression.cs (Unary.ResolveOperator): When resolving the `&'
6059 operator, check whether the variable is actually fixed. Fixes bug
6060 #36055. Set a variable definitely assigned when taking its
6061 address as required by the spec.
6063 * statement.cs (LocalInfo.IsFixed): New field.
6064 (LocalInfo.MakePinned): Set `IsFixed' to true.
6066 2003-07-14 Ravi Pratap M <ravi@ximian.com>
6068 * attribute.cs (Attribute.Resolve): While doing a Member lookup
6069 for .ctors, ensure that we only ask for members declared in the
6070 attribute type (BindingFlags.DeclaredOnly).
6074 * expression.cs (Error_WrongNumArguments): Report error 1501
6075 correctly the way CSC does.
6077 2003-07-13 Martin Baulig <martin@ximian.com>
6079 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
6080 lookup on the fully qualified name, to make things like "X.X" work
6081 where "X.X" is a fully qualified type name, but we also have a
6082 namespace "X" in the using list. Fixes #41975.
6084 2003-07-13 Martin Baulig <martin@ximian.com>
6086 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
6087 function. If we're a CompoundAssign, we need to create an embedded
6088 CompoundAssign, not an embedded Assign.
6089 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
6092 2003-07-13 Martin Baulig <martin@ximian.com>
6094 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
6095 work to fix bug #46088.
6097 2003-07-13 Ravi Pratap <ravi@ximian.com>
6099 * class.cs (Operator.Emit): Do not emit attributes here - it is
6100 taken care of by the Method class that we delegate too. This takes
6103 2003-07-10 Martin Baulig <martin@ximian.com>
6105 * expression.cs (TypeOfVoid): New class.
6106 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
6108 2003-07-10 Martin Baulig <martin@ximian.com>
6110 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
6113 2003-07-10 Martin Baulig <martin@ximian.com>
6115 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
6116 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
6118 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
6120 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
6122 2003-07-10 Martin Baulig <martin@ximian.com>
6124 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
6125 of decimal. Fixes #42850.
6127 NOTE: I also fixed the created byte blob, but this doesn't work on
6128 the MS runtime and csc never produces any byte blobs for decimal
6131 2003-07-10 Martin Baulig <martin@ximian.com>
6133 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
6134 structs; fixes #32068.
6135 (Block.AddChildVariableNames): Fixed #44302.
6137 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6139 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
6141 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6143 * attribute.cs: And this test is onger needed.
6145 2003-07-08 Martin Baulig <martin@ximian.com>
6147 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
6148 inaccessible types. Fixes #36313.
6150 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
6152 * namespace.cs (NamespaceEntry): Create implicit entries for all
6153 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
6154 implicit entries for N1.N2 and N1.
6156 2003-07-08 Martin Baulig <martin@ximian.com>
6158 Rewrote the handling of namespaces to fix a lot of the issues
6159 wrt. `using' aliases etc.
6161 * namespace.cs (Namespace): Splitted this class into a
6162 per-assembly `Namespace' and a per-file `NamespaceEntry'.
6164 * typemanager.cs (TypeManager.IsNamespace): Removed.
6165 (TypeManager.ComputeNamespaces): Only compute namespaces from
6166 loaded assemblies here, not the namespaces from the assembly we're
6167 currently compiling.
6169 2003-07-08 Martin Baulig <martin@ximian.com>
6171 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
6173 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6175 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
6178 I thought about the memory savings here, but LookupTypeReflection
6179 is used under already very constrained scenarios. Compiling
6180 corlib or mcs only exposes one hit, so it would not really reduce
6181 any memory consumption.
6183 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
6185 * typemanager.cs: fixes bug #45889 by only adding public types from
6186 other assemblies to the list of known types.
6188 2003-07-07 Miguel de Icaza <miguel@ximian.com>
6190 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
6191 on the type we resolved.
6193 2003-07-05 Martin Baulig <martin@ximian.com>
6195 * pending.cs (PendingImplementation.ParentImplements): Don't
6196 create the proxy if the parent is abstract.
6198 * class.cs (TypeContainer.DefineIndexers): Process explicit
6199 interface implementations first. Fixes #37714.
6201 2003-07-04 Miguel de Icaza <miguel@ximian.com>
6203 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
6204 defined recursively; but since we modify the input parameters
6205 (left is set to `this' temporarily), we reset this value if the
6206 left_is_explicit is false, which gives the original semantics to
6209 * literal.cs (NullPointer): new class used to represent a null
6210 literal in a pointer context.
6212 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
6213 type is a pointer, use a NullPointer object instead of a
6214 NullLiteral. Closes 43687
6216 (ExplicitConversion): Convert pointer values using
6217 the conv opcode to the proper type.
6219 * ecore.cs (New): change ValueTypeVariable property into a method,
6220 that returns whether the valuetype is suitable for being used.
6222 * expression.cs (Binary.DoNumericPromotions): Only return if we
6223 the int constant was a valid uint, and we can return both left and
6224 right as uints. If not, we continue processing, to trigger the
6225 type conversion. This fixes 39018.
6227 * statement.cs (Block.EmitMeta): During constant resolution, set
6228 the CurrentBlock property on the emitcontext, so that we resolve
6229 constants propertly.
6231 2003-07-02 Martin Baulig <martin@ximian.com>
6233 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
6234 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
6236 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
6237 than emitting it here.
6239 * statement.cs: Fixed some more flow analysis bugs.
6241 2003-07-02 Martin Baulig <martin@ximian.com>
6243 * class.cs (MethodData.Define): When implementing interface
6244 methods, set Final unless we're Virtual.
6246 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
6247 check work for interface methods.
6249 2003-07-01 Martin Baulig <martin@ximian.com>
6251 * ecore.cs (EmitContext.This): Replaced this property with a
6252 GetThis() method which takes a Location argument. This ensures
6253 that we get the correct error location for a CS0188.
6255 2003-07-01 Miguel de Icaza <miguel@ximian.com>
6257 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
6258 ImplicitStandardConversion.
6260 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
6262 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
6264 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
6267 2003-06-30 Miguel de Icaza <miguel@ximian.com>
6269 * class.cs (Constructor.Define): Turn off initlocals for unsafe
6272 (MethodData.Define): Turn off initlocals for unsafe methods.
6274 2003-06-29 Miguel de Icaza <miguel@ximian.com>
6276 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
6277 complete; Fixes #37521.
6279 * delegate.cs: Use Modifiers.TypeAttr to compute the
6280 TypeAttributes, instead of rolling our own. This makes the flags
6281 correct for the delegates.
6283 2003-06-28 Miguel de Icaza <miguel@ximian.com>
6285 * class.cs (Constructor.Define): Set the private flag for static
6286 constructors as well.
6288 * cs-parser.jay (statement_expression): Set the return value to
6289 null, to avoid a crash when we catch an error.
6291 2003-06-24 Miguel de Icaza <miguel@ximian.com>
6293 * cs-parser.jay: Applied patch from Jackson that adds support for
6294 extern and unsafe modifiers to destructor declarations.
6296 * expression.cs: Report error 21 if the user is trying to index a
6299 * driver.cs: Add an error message, suggested by the bug report.
6301 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
6302 if we do not have a ": this ()" constructor initializer. Fixes 45149
6304 2003-06-14 Miguel de Icaza <miguel@ximian.com>
6306 * namespace.cs: Add some information to reduce FAQs.
6308 2003-06-13 Miguel de Icaza <miguel@ximian.com>
6310 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
6311 underlying enumeration types. Fixes #43915.
6313 * expression.cs: Treat ushort/short as legal values to be used in
6316 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
6318 * delegate.cs: transfer custom attributes for paramenters from
6319 the delegate declaration to Invoke and BeginInvoke.
6321 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
6323 * attribute.cs: handle custom marshalers and emit marshal info
6326 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
6328 * makefile.gnu: Added anonymous.cs to the compiler sources.
6330 2003-05-28 Miguel de Icaza <miguel@ximian.com>
6332 * iterators.cs: Change the name of the proxy class to include two
6335 * cs-parser.jay: Update grammar to include anonymous methods.
6337 * anonymous.cs: new file.
6339 2003-05-27 Miguel de Icaza <miguel@ximian.com>
6341 * class.cs (Field.Define): Add missing test for pointers and
6344 2003-05-27 Ravi Pratap <ravi@ximian.com>
6346 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
6347 we use the stobj opcode.
6349 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
6350 since it wasn't the correct fix.
6352 It still is puzzling that we are required to use stobj for IntPtr
6353 which seems to be a ValueType.
6355 2003-05-26 Miguel de Icaza <miguel@ximian.com>
6357 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
6358 during regular simple name resolution. Now, the trick is that
6359 instead of returning for processing the simplename, we do a
6360 TypeManager.LookupType (ie, a rooted lookup as opposed to a
6361 contextual lookup type). If a match is found, return that, if
6362 not, return for further composition.
6364 This fixes long-standing 30485.
6366 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
6367 using the address to initialize an object, do an Stobj instead of
6368 using the regular Stelem.
6370 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
6371 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
6372 Because if we are a BaseIndexerAccess that value will be true.
6375 * statement.cs (GotoCase.Resolve): Return after reporting an
6376 error, do not attempt to continue.
6378 * expression.cs (PointerArithmetic.Emit): If our operand is a
6379 long, convert our constants to match the operand before
6380 multiplying. Convert to I type before adding. Fixes 43670.
6382 2003-05-14 Ravi Pratap <ravi@ximian.com>
6384 * enum.cs (ImplicitConversionExists) : Rename to
6385 ImplicitEnumConversionExists to remove ambiguity.
6387 * ecore.cs (NullCast): New type of cast expression class which
6388 basically is very similar to EmptyCast with the difference being
6389 it still is a constant since it is used only to cast a null to
6393 * convert.cs (ImplicitReferenceConversion): When casting a null
6394 literal, we return a NullCast.
6396 * literal.cs (NullLiteralTyped): Remove - I don't see why this
6397 should be around anymore.
6399 The renaming (reported was slightly wrong). Corrections:
6401 ConvertImplicitStandard -> ImplicitConversionStandard
6402 ConvertExplicitStandard -> ExplicitConversionStandard
6404 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
6405 before passing them in !
6407 * convert.cs (ImplicitConversionStandard): When comparing for
6408 equal expr and target types, ensure that expr is not a
6411 In general, we must not be checking (expr_type ==
6412 target_type) in the top level conversion methods
6413 (ImplicitConversion, ExplicitConversion etc). This checking is
6414 done in the methods that they delegate to.
6416 2003-05-20 Miguel de Icaza <miguel@ximian.com>
6418 * convert.cs: Move Error_CannotConvertType,
6419 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
6420 ImplicitNumericConversion, ImplicitConversionExists,
6421 ImplicitUserConversionExists, StandardConversionExists,
6422 FindMostEncompassedType, FindMostSpecificSource,
6423 FindMostSpecificTarget, ImplicitUserConversion,
6424 ExplicitUserConversion, GetConversionOperators,
6425 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
6426 TryImplicitIntConversion, Error_CannotConvertImplicit,
6427 ConvertImplicitRequired, ConvertNumericExplicit,
6428 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
6429 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
6432 Perform the following renames:
6434 StandardConversionExists -> ImplicitStandardConversionExists
6435 ConvertImplicit -> ImplicitConversion
6436 ConvertImplicitStandard -> ImplicitStandardConversion
6437 TryImplicitIntConversion -> ImplicitIntConversion
6438 ConvertImplicitRequired -> ImplicitConversionRequired
6439 ConvertNumericExplicit -> ExplicitNumericConversion
6440 ConvertReferenceExplicit -> ExplicitReferenceConversion
6441 ConvertExplicit -> ExplicitConversion
6442 ConvertExplicitStandard -> ExplicitStandardConversion
6444 2003-05-19 Martin Baulig <martin@ximian.com>
6446 * statement.cs (TypeInfo.StructInfo): Made this type protected.
6447 (TypeInfo): Added support for structs having structs as fields.
6449 * ecore.cs (FieldExpr): Implement IVariable.
6450 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
6451 VariableInfo for the field.
6453 2003-05-18 Martin Baulig <martin@ximian.com>
6455 * expression.cs (This.DoResolve): Report a CS0027 if we're
6456 emitting a field initializer.
6458 2003-05-18 Martin Baulig <martin@ximian.com>
6460 * expression.cs (This.ResolveBase): New public function.
6461 (This.DoResolve): Check for CS0188.
6463 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
6466 * ecore.cs (MethodGroupExpr.DoResolve): Set the
6467 `instance_expression' to null if we don't have any non-static
6470 2003-05-18 Martin Baulig <martin@ximian.com>
6472 Reworked the way how local variables and parameters are handled by
6473 the flow analysis code.
6475 * statement.cs (TypeInfo, VariableMap): New public classes.
6476 (VariableInfo): New public class. This is now responsible for
6477 checking whether a variable has been assigned. It is used for
6478 parameters and local variables.
6479 (Block.EmitMeta): Take the InternalParameters as argument; compute
6480 the layout of the flow vectors here.
6481 (Block.LocalMap, Block.ParameterMap): New public properties.
6482 (FlowBranching): The .ctor doesn't get the InternalParameters
6483 anymore since Block.EmitMeta() now computes the layout of the flow
6485 (MyStructInfo): This class is now known as `StructInfo' and nested
6486 in `TypeInfo'; we don't access this directly anymore.
6488 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
6489 property and removed IsAssigned(), IsFieldAssigned(),
6490 SetAssigned() and SetFieldAssigned(); we now call them on the
6491 VariableInfo so we don't need to duplicate this code everywhere.
6493 * expression.cs (ParameterReference): Added `Block block' argument
6495 (LocalVariableReference, ParameterReference, This): The new
6496 VariableInfo class is now responsible for all the definite
6499 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
6500 IsParameterAssigned, SetParameterAssigned): Removed.
6502 2003-05-18 Martin Baulig <martin@ximian.com>
6504 * typemanager.cs (InitCoreTypes): Try calling
6505 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
6506 the 3-args-version. Corlib now also needs our `void_type'.
6507 (GetMethod): Added overloaded version which takes an optional
6508 `bool report_errors' to allow lookups of optional methods.
6510 2003-05-12 Martin Baulig <martin@ximian.com>
6512 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
6513 only used for locals and not for parameters.
6515 2003-05-12 Miguel de Icaza <miguel@ximian.com>
6517 * support.cs (InternalParameters.ParameterType): Return the
6518 ExternalType of the parameter.
6520 * parameter.cs (Parameter.ExternalType): drop the two arguments,
6523 2003-05-11 Miguel de Icaza <miguel@ximian.com>
6525 * class.cs (MethodData.Define): Do not set the `newslot' on
6526 interface members, if they are also flagged as "override".
6528 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
6529 better code for ++i and i++. This only works for static fields
6530 and local variables.
6532 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
6533 want to pull the DeclSpace out of the builder_to_declspace instead
6534 of the TypeBuilder (like in TypeContainer.FindMembers).
6536 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
6537 instead of LookupTypeContainer. Fixes the crash on .NET for
6538 looking up interface members.
6540 * const.cs: Create our own emit context during the Definition
6541 stage, so that constants are evaluated in the proper context, when
6542 a recursive definition happens.
6544 2003-05-11 Martin Baulig <martin@ximian.com>
6546 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
6547 new block for a switch section.
6548 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
6549 the adding/lookup in the switch block. Fixes #39828.
6551 2003-05-09 Miguel de Icaza <miguel@ximian.com>
6553 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
6554 functionality: I needed to convert the data after I had performed
6555 the add/sub operation into the operands type size.
6557 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
6558 pass the type for the box operation, otherwise the resulting
6559 object would have been of type object.
6561 (BoxedCast): Add constructor to specify the type to box as.
6563 2003-05-07 Miguel de Icaza <miguel@ximian.com>
6565 * iterators.cs: I was reusing the `count' variable inadvertently,
6566 take steps to not allow this to happen.
6568 2003-05-06 Miguel de Icaza <miguel@ximian.com>
6570 * attribute.cs (Attribute.Resolve): Params attributes are encoded
6571 by creating an array at the point where the params starts and
6572 putting all those arguments there, then adjusting the size of the
6575 2003-05-05 Miguel de Icaza <miguel@ximian.com>
6577 * expression.cs (New.AddressOf): Implement interface
6578 IMemoryLocation. This is used when the `new' operator is used in
6579 the context of an invocation to a method on a value type.
6581 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
6584 * namespace.cs: Also check the using aliases here.
6586 * driver.cs: Move the test for using validity after the types have
6587 been entered, so we do a single pass that also includes the using
6590 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
6591 in the regular case. CreateSiblingForFinally is doing extra
6594 * attribute.cs (GetAttributeArgumentExpression): Store the result
6595 on an out value, and use the return value to indicate failure
6596 instead of using null (which is a valid return for Constant.GetValue).
6598 * statement.cs: Perform the analysis flow for the increment
6599 portion after the statement, because this will be the real flow of
6600 execution. Fixes #42385
6602 * codegen.cs (EmitContext.EmitArgument,
6603 EmitContext.EmitStoreArgument): New helper functions when the
6604 RemapToProxy flag is set.
6606 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
6609 Add support for remapping parameters.
6611 * iterators.cs: Propagate parameter values; Store parameter
6612 values in the proxy classes.
6614 2003-05-04 Miguel de Icaza <miguel@ximian.com>
6616 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
6617 need a proxy reference; I do not know what I was thinking
6619 * cs-parser.jay (constructor_initializer): catch another error,
6620 and display nice message.
6622 (field_declaration): catch void field declaration
6623 to flag a better error.
6625 * class.cs (MemberBase.CheckBase): Report an error instead of a
6626 warning if a new protected member is declared in a struct.
6627 (Field.Define): catch the error of readonly/volatile.
6629 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
6631 (FieldExpr.AddressOf): ditto. Catch error where the address of a
6632 volatile variable is taken
6634 2003-05-02 Miguel de Icaza <miguel@ximian.com>
6636 * statement.cs (Fixed.Resolve): Report an error if we are not in
6639 2003-05-01 Miguel de Icaza <miguel@ximian.com>
6641 * typemanager.cs: reuse the code that handles type clashes for
6642 delegates and enumerations.
6644 * class.cs (Report28): Always report.
6646 * expression.cs (EncodeAsAttribute): Allow nulls here.
6648 2003-04-28 Miguel de Icaza <miguel@ximian.com>
6650 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
6651 the functionality for testing whether an expression is valid for
6652 an attribute here. Also handle the case of arrays of elements
6655 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
6656 encoding a linear array into an array of objects that are suitable
6657 to be passed to an CustomAttributeBuilder.
6659 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
6661 * ecore.cs: (FieldExpr): Handle field remapping here.
6663 * iteratators.cs: Pass the instance variable (if the method is an
6664 instance method) to the constructors, so we can access the field
6665 variables on the class.
6667 TODO: Test this with structs. I think the THIS variable on
6668 structs might have to be a pointer, and not a refenrece
6670 2003-04-27 Miguel de Icaza <miguel@ximian.com>
6672 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
6673 local variables to fields in a proxy class.
6675 * iterators.cs (PopulateProxy): Rename our internal fields to
6677 Create a <THIS> field if we are an instance method, so we can
6678 reference our parent container variables.
6679 (MapVariable): Called back from the EmitContext code to enter a
6680 new variable to field mapping into the proxy class (we just create
6684 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
6685 for using the remapped locals to fields.
6687 I placed the code here, because that gives the same semantics to
6688 local variables, and only changes the Emit code.
6690 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
6691 statements inside iterators.
6692 (VariableInfo): Add a FieldBuilder for the cases when we are
6693 remapping local variables to fields in a proxy class
6695 * ecore.cs (SimpleNameResolve): Avoid testing two times for
6696 current_block != null.
6698 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
6699 not cope with strings, as it has been moved to the
6700 TableSwitchEmit. Fixed bug in switch generation.
6702 * expression.cs (New.DoResolve): Provide more context for the user
6703 when reporting an error.
6705 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
6708 * expression.cs (MemberAccess.DoResolve): When we get a type back,
6709 check the permissions for it. Note than in a type-resolution
6710 context the check was already present in DeclSpace.ResolveType,
6711 but was missing from the MemberAccess.
6713 (ArrayCreation.CheckIndices): warn if the user has
6714 more nested levels of expressions, but there are no more
6715 dimensions specified. Avoids crash on bug 41906.
6717 2003-04-26 Miguel de Icaza <miguel@ximian.com>
6719 * statement.cs (Block): replace Implicit bool, for a generic
6721 New flag: `Unchecked'. This is used during the EmitMeta phase
6722 (which is out-of-line with the regular Resolve/Emit process for a
6723 statement, as this is done ahead of time, but still gets a chance
6724 to call constant resolve).
6726 (Block.Flags): new enum for adding a new flag.
6728 (Block.EmitMeta): track the state of unchecked.
6730 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
6731 to enable constant resolution to work there as well.
6733 2003-04-22 Miguel de Icaza <miguel@ximian.com>
6735 * typemanager.cs (ienumerable_type): Also look up
6736 System.Collections.IEnumerable.
6738 2003-04-21 Miguel de Icaza <miguel@ximian.com>
6740 TODO: Test more than one conditional per method.
6742 * class.cs (Indexer.Define): Report the location where the user is
6743 referencing the unsupported feature.
6745 (MethodData): Overload the use of `conditionals' to
6746 minimize the creation of needless ArrayLists. This saves roughly
6747 212kb on my machine.
6749 (Method): Implement the new IIteratorContainer interface.
6750 (Method.SetYields): Implement the method by setting the ModFlags
6751 to contain METHOD_YIELDS.
6753 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
6754 which just got set to null.
6756 * iterators.cs: New file.
6758 (Yield, YieldBreak): New statements.
6760 * statement.cs (Return.Resolve): Flag an error if we are used in
6763 * codegen.cs (InIterator): New flag set if the code is being
6764 compiled in an iterator method.
6766 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
6767 internal modifier, and we just use it to avoid adding extra
6768 fields, as this is seldom used.
6770 * cs-parser.jay: Add yield_statement (yield and yield break).
6772 * driver.cs: New flag -v2 to turn on version 2 features.
6774 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
6775 hashtable when v2 is enabled.
6777 2003-04-20 Miguel de Icaza <miguel@ximian.com>
6779 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
6780 there is already a namespace defined with this name.
6782 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
6783 people upgraded their corlibs.
6785 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
6786 always use fully qualified types, no need to use the compiler
6789 (TypeManager.IsNamespace): Use binarysearch.
6791 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
6792 AddDelegate): I did not quite use the new IsValid API properly: I
6793 have to pass the short-name and the fullname. I was passing only
6794 the basename instead of the fullname sometimes.
6796 (TypeContainer.DefineType): call NamespaceClash.
6798 * interface.cs (Interface.DefineType): use NamespaceClash before
6801 * delegate.cs (Delegate.DefineType): use NamespaceClash before
6804 * enum.cs: (Enum.DefineType): use NamespaceClash before
6807 * typemanager.cs (: 3-line patch that gives us some tasty 11%
6808 speed increase. First, use the negative_hits cache when we get a
6809 negative. Second, add the type with its full original name
6810 instead of the new . and + encoded name (reflection uses + to
6811 separate type from a nested type). Use LookupTypeReflection
6812 directly which bypasses the type->name hashtable (that we already
6813 know does not contain the type.
6815 * decl.cs (DeclSpace.ResolveTypeExpr): track the
6816 location/container type.
6818 * driver.cs: When passing utf8, use directly the UTF8Encoding.
6820 2003-04-19 Miguel de Icaza <miguel@ximian.com>
6822 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
6824 * delegate.cs (NewDelegate.Resolve): Test whether an instance
6825 method is being referenced in the method group from a static
6826 context, and report error 120 if so.
6828 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
6831 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
6832 is created, we create the A namespace).
6834 * cs-parser.jay: A namespace also introduces a DeclarationFound.
6837 2003-04-18 Miguel de Icaza <miguel@ximian.com>
6839 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
6840 invocation to ModuleBuilder.GetType with the same values will
6841 return a new type instance, so we need to cache its return
6844 * expression.cs (Binary.ResolveOperator): Only allow the compare
6845 operators on enums if they are of the same type.
6847 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
6848 types of ValueType on their own case. Before we were giving them
6849 the same treatment as objects.
6851 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
6852 fullname. Short name is used to compare against container name.
6853 Fullname is used to check against defined namespace names.
6855 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
6856 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
6858 (Method.CheckBase): Call parent.
6859 (MemberBase.CheckBase): Check for protected members on sealed
6861 (PropertyBase.CheckBase): Call parent.
6862 (Field.Define): Call parent.
6864 * report.cs: Negative error codes are now mapped to 8000 - code,
6865 so that the display is render more nicely.
6867 * typemanager.cs: Do not use try/catch, instead report a regular
6870 (GetPointerType, GetReferenceType): These methods provide
6871 mechanisms to obtain the T* and T& from a T. We had the code
6872 previously scattered around the code base, and it also used
6873 TypeManager.LookupType that would go through plenty of caches.
6874 This one goes directly to the type source.
6876 In some places we did the Type.GetType followed by
6877 ModuleBuilder.GetType, but not in others, so this unifies the
6880 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
6881 statements now that we have namespace information.
6883 * typemanager.cs (IsNamespace): New method, returns whether the
6884 string presented is a namespace or not.
6886 (ComputeNamespaces): New public entry point, computes the list of
6887 available namespaces, using the GetNamespaces API call in Mono, or
6888 the slower version in MS.NET.
6890 Now before we start the semantic analysis phase, we have a
6891 complete list of namespaces including everything that the user has
6894 Deleted old code to cache namespaces in .nsc files.
6896 2003-04-17 Miguel de Icaza <miguel@ximian.com>
6898 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
6899 class/struct location definition Location for the implicit
6900 constructor location.
6902 (Operator.Define): Use the location of the operator for the
6903 implicit Method definition.
6905 (Constructor.Emit): use the constructor location for the implicit
6906 base initializer constructor.
6908 * ecore.cs: Remove ITypeExpression. This interface is now gone,
6909 and the Expression class now contains two new methods:
6911 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
6912 isolate type lookup from the rest of the resolution process.
6914 Since we use Expressions to hold type definitions due to the way
6915 we parse the input we have historically overloaded Resolve to
6916 perform the Type lookups if a special flag is passed. Now this is
6917 eliminated and two methods take their place.
6919 The differences in the two methods between xStep and xTerminal is
6920 that xStep is involved in our current lookup system that uses
6921 SimpleNames to compose a name, while xTerminal is used just to
6922 catch the case where the simplename lookup failed.
6924 2003-04-16 Miguel de Icaza <miguel@ximian.com>
6926 * expression.cs (ResolveMemberAccess): Remove redundant code.
6927 TypeExpr expressions are always born fully resolved.
6929 * interface.cs (PopulateMethod): Do not lookup the types twice.
6930 We were doing it once during SemanticAnalysis and once during
6933 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
6934 in local variable type definitions, were being returned as a
6935 SimpleName (we decomposed everything into a string), that is
6936 because primary_expression was being used instead of a type in the
6937 grammar (reduce/reduce conflicts).
6939 The part that was wrong is that we converted the expression into a
6940 string (an oversimplification in one hand, compounded with primary
6941 expressions doing string concatenation).
6947 Would return "A.B.C[]" as a SimpleName. This stopped things like
6948 using clauses from working on this particular context. And a type
6949 was being matched directly against "A.B.C[]".
6951 We now use the correct approach, and allow for ComposedCast to be
6952 part of the unary expression. So the "A.B.C []" become a composed
6953 cast of "A.B.C" (as a nested group of MemberAccess with a
6954 SimpleName at the end) plus the rank composition "[]".
6958 2003-04-10 Miguel de Icaza <miguel@ximian.com>
6960 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
6961 for the access level checking.
6963 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
6964 `TypeContainer container', because I kept getting confused when I
6965 was debugging this code.
6967 * expression.cs (Indexers): Instead of tracking getters/setters,
6968 we now track them in parallel. We create one arraylist less, but
6969 most importantly it is possible now for the LValue code to find a
6970 matching get for a set.
6972 (IndexerAccess.DoResolveLValue): Update the code.
6973 GetIndexersForType has been modified already to extract all the
6974 indexers from a type. The code assumed it did not.
6976 Also make the code set the correct return type for the indexer.
6977 This was fixed a long time ago for properties, but was missing for
6978 indexers. It used to be void_type.
6980 (Binary.Emit): Test first for doubles instead of
6981 floats, as they are more common.
6983 (Binary.EmitBranchable): Use the .un version of the branch opcodes
6984 when dealing with floats and the <=, >= operators. This fixes bug
6987 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
6988 to load the array value by emitting a load on the foreach variable
6989 type. This was incorrect.
6991 We now emit the code to load an element using the the array
6992 variable type, and then we emit the conversion operator.
6996 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
6998 * attribute.cs: Avoid allocation of ArrayLists in the common case.
7000 2003-04-09 Miguel de Icaza <miguel@ximian.com>
7002 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
7003 test for protection before we test for signatures.
7005 (MethodSignature.ToString): implement.
7007 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
7008 to the case where we reduced into a LongConstant.
7010 * decl.cs (CheckAccessLevel): If the type is an array, we can not
7011 depend on whether the information is acurrate, because the
7012 Microsoft runtime will always claim that the array type is public,
7013 regardless of the real state.
7015 If the type is a pointer, another problem happens: the type is
7016 reported as non-public in Microsoft.
7018 In both cases we have to call CheckAccessLevel recursively with
7019 the underlying type as the argument to be tested.
7021 2003-04-08 Miguel de Icaza <miguel@ximian.com>
7023 * assign.cs (Assign.Emit): If we are dealing with a compound
7024 assignment expression, we should use the code path that stores the
7025 intermediate result in a temporary value. This fixes #40903.
7027 *expression.cs (Indirection.ToString): Provide ToString method for
7030 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
7032 * class.cs: Null out fields holding references to Block objects so
7033 they can be garbage collected.
7035 * expression.cs (OverloadResolve): Remove unused local.
7037 2003-04-07 Martin Baulig <martin@ximian.com>
7039 * codegen.cs (EmitContext.CurrentFile): New public field.
7040 (EmitContext.Mark): Use the CurrentFile to check whether the
7041 location is in the correct file.
7042 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
7044 2003-04-07 Martin Baulig <martin@ximian.com>
7046 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
7048 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
7049 location. [FIXME: The location argument which gets passed to this
7050 method is sometimes wrong!]
7052 2003-04-07 Nick Drochak <ndrochak@gol.com>
7054 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
7056 2003-04-07 Miguel de Icaza <miguel@ximian.com>
7058 * expression.cs (Indirection.EmitAssign): We were using the
7059 temporary, but returning immediately instead of continuing the
7062 2003-04-06 Martin Baulig <martin@ximian.com>
7064 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
7065 if it's a nested child, but also deriving from the outer class.
7068 * typemanager.cs (IsNestedChildOf): Make this work if it's a
7069 nested child, but also deriving from the outer class. See
7071 (FilterWithClosure): We may access private members of the outer
7072 class if we're a nested child and deriving from the outer class.
7073 (RealMemberLookup): Only set `closure_private_ok' if the
7074 `original_bf' contained BindingFlags.NonPublic.
7076 2003-04-05 Martin Baulig <martin@ximian.com>
7078 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
7080 2003-04-02 Miguel de Icaza <miguel@ximian.com>
7082 * class.cs (Event.Define): Do not allow abstract events to have
7085 2003-04-01 Miguel de Icaza <miguel@ximian.com>
7087 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
7088 block in event declarations.
7090 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
7091 value type, get its address.
7093 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
7094 leaving a class on the stack instead of a boolean value (int
7095 0/1). Change the code so we compare against null, and then the
7096 result against zero.
7098 * class.cs (TypeContainer.GetClassBases): We were checking for the
7099 parent class being sealed too late.
7101 * expression.cs (Binary.Emit): For <= and >= when dealing with
7102 floating point values, use cgt.un and clt.un instead of cgt and
7105 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
7107 * statement.cs: Apply the same optimization as MS: skip the
7108 GetEnumerator returning an IEnumerator, and use the one returning a
7109 CharEnumerator instead. This allows us to avoid the try-finally block
7112 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
7114 * cs-parser.jay: Attributes cannot be applied to
7115 namespaces. Fixes #40473
7117 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7120 (Add*): check if the name is valid using the full name for constants,
7121 fields, properties and events.
7123 2003-03-28 Miguel de Icaza <miguel@ximian.com>
7125 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
7126 char constants to be part of the enumeration.
7128 * expression.cs (Conditional.DoResolve): Add support for operator
7129 true. Implements the missing functionality from 14.12
7131 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
7132 operator true/false as required by the spec.
7134 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
7135 implicit conversion to boolean.
7137 * statement.cs (Statement.ResolveBoolean): A boolean expression is
7138 also one where the type implements `operator true'.
7140 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
7141 get an expression that will invoke operator true based on an
7144 (GetConversionOperators): Removed the hack that called op_True
7147 (Expression.ResolveBoolean): Move this from Statement.
7149 2003-03-17 Miguel de Icaza <miguel@ximian.com>
7151 * ecore.cs (FieldExpr): do not allow initialization of initonly
7152 fields on derived classes
7154 2003-03-13 Martin Baulig <martin@ximian.com>
7156 * statement.cs (Block.Emit): Call ig.BeginScope() and
7157 ig.EndScope() when compiling with debugging info; call
7158 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
7160 2003-03-08 Miguel de Icaza <miguel@ximian.com>
7162 * expression.cs (Indexers): Do not construct immediately, allow
7163 for new members to be appended as we go. Fixes 38143
7165 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7167 * expression.cs: save/restore context when resolving an unchecked
7170 2003-03-05 Miguel de Icaza <miguel@ximian.com>
7172 * cfold.cs: Catch division by zero in modulus operator during
7175 2003-03-03 Miguel de Icaza <miguel@ximian.com>
7177 * interface.cs (Interface.DefineMembers): Avoid defining members
7180 2003-02-27 Miguel de Icaza <miguel@ximian.com>
7182 * driver.cs: handle the +/- options for -noconfig
7184 * statement.cs (Unckeched.Resolve): Also track the state of
7185 unchecked in the Resolve phase.
7187 2003-02-27 Martin Baulig <martin@ximian.com>
7189 * ecore.cs (Expression.MemberLookup): Don't create a
7190 MethodGroupExpr for something which is not a method. Fixes #38291.
7192 2003-02-25 Miguel de Icaza <miguel@ximian.com>
7194 * class.cs (MemberBase.CheckParameters): Also check that the type
7195 is unmanaged if it is a pointer.
7197 * expression.cs (SizeOf.Resolve): Add location information.
7199 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
7200 a managed type is declared.
7202 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
7203 parameter modifiers as well. Fixes bug 38606
7205 * class.cs: Very sad. Am backing out the speed up changes
7206 introduced by the ArrayList -> Array in the TypeContainer, as they
7207 were not actually that much faster, and introduced a bug (no error
7208 reports on duplicated methods).
7210 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
7211 source first, this will guarantee that we have a valid expression
7212 before calling in lower levels functions that will require a
7213 resolved object. Then use this original_source in the
7214 target.ResolveLValue instead of the original source that was
7217 Another change. Use target.Resolve instead of LValueResolve.
7218 Although we are resolving for LValues, we will let the Assign code
7219 take care of that (it will be called again from Resolve). This
7220 basically allows code like this:
7222 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
7223 class Y { void A (X x) { x [0] += o; }
7225 The problem was that the indexer was trying to resolve for
7226 set_Item (idx, object o) and never finding one. The real set_Item
7227 was set_Item (idx, X). By delaying the process we get the right
7232 2003-02-23 Martin Baulig <martin@ximian.com>
7234 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
7235 while calling DoEmit ().
7237 * codegen.cs (EmitContext.Mark): Don't mark locations in other
7238 source files; if you use the #line directive inside a method, the
7239 compiler stops emitting line numbers for the debugger until it
7240 reaches the end of the method or another #line directive which
7241 restores the original file.
7243 2003-02-23 Martin Baulig <martin@ximian.com>
7245 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
7247 2003-02-23 Martin Baulig <martin@ximian.com>
7249 * statement.cs (Block.AddChildVariableNames): We need to call this
7250 recursively, not just for our immediate children.
7252 2003-02-23 Martin Baulig <martin@ximian.com>
7254 * class.cs (Event.Define): Always make the field private, like csc does.
7256 * typemanager.cs (TypeManager.RealMemberLookup): Make events
7257 actually work, fixes bug #37521.
7259 2003-02-23 Miguel de Icaza <miguel@ximian.com>
7261 * delegate.cs: When creating the various temporary "Parameters"
7262 classes, make sure that we call the ComputeAndDefineParameterTypes
7263 on those new parameters (just like we do with the formal ones), to
7264 allow them to be resolved in the context of the DeclSpace.
7266 This fixes the bug that Dick observed in Bugzilla #38530.
7268 2003-02-22 Miguel de Icaza <miguel@ximian.com>
7270 * expression.cs (ResolveMemberAccess): When resolving a constant,
7271 do not attempt to pull a constant if the value was not able to
7272 generate a valid constant.
7274 * const.cs (LookupConstantValue): Do not report more errors than required.
7276 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7278 * expression.cs: fixes bug #38328.
7280 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7282 * class.cs: Changed all the various members that can be part of a
7283 class from being an ArrayList to be an Array of the right type.
7284 During the DefineType type_list, interface_list, delegate_list and
7285 enum_list are turned into types, interfaces, delegates and enums
7288 And during the member population, indexer_list, event_list,
7289 constant_list, field_list, instance_constructor_list, method_list,
7290 operator_list and property_list are turned into their real arrays.
7292 Although we could probably perform this operation earlier, for
7293 good error reporting we need to keep the lists and remove the
7294 lists for longer than required.
7296 This optimization was triggered by Paolo profiling the compiler
7297 speed on the output of `gen-sample-program.pl' perl script.
7299 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
7300 not crash in methods like MemberLookupFailed that use this field.
7302 This problem arises when the compiler fails to resolve a type
7303 during interface type definition for example.
7305 2003-02-18 Miguel de Icaza <miguel@ximian.com>
7307 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
7308 inherit from System.Object, so we have to stop at null, not only
7309 when reaching System.Object.
7311 2003-02-17 Miguel de Icaza <miguel@ximian.com>
7313 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
7314 DeclaredOnly because the parent indexer might have had a different
7315 name, but did not loop until the top of the hierarchy was reached.
7317 The problem this one fixes is 35492: when a class implemented an
7318 indexer from an interface, we were getting the interface method
7319 (which was abstract) and we were flagging an error (can not invoke
7322 This also keeps bug 33089 functioning, and test-148 functioning.
7324 * typemanager.cs (IsSpecialMethod): The correct way of figuring
7325 out if a method is special is to see if it is declared in a
7326 property or event, or whether it is one of the predefined operator
7327 names. This should fix correctly #36804.
7329 2003-02-15 Miguel de Icaza <miguel@ximian.com>
7331 The goal here is to remove the dependency on EmptyCast.Peel ().
7332 Killing it completely.
7334 The problem is that currently in a number of places where
7335 constants are expected, we have to "probe" for an EmptyCast, and
7336 Peel, which is not the correct thing to do, as this will be
7337 repetitive and will likely lead to errors.
7339 The idea is to remove any EmptyCasts that are used in casts that
7340 can be reduced to constants, so we only have to cope with
7343 This bug hunt was triggered by Bug 37363 and the desire to remove
7344 the duplicate pattern where we were "peeling" emptycasts to check
7345 whether they were constants. Now constants will always be
7348 * ecore.cs: Use an enumconstant here instead of wrapping with
7351 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
7352 throwing me off. By handling this we can get rid of a few hacks.
7354 * statement.cs (Switch): Removed Peel() code.
7356 2003-02-14 Miguel de Icaza <miguel@ximian.com>
7358 * class.cs: Location information for error 508
7360 * expression.cs (New.DoResolve): Add a guard against double
7361 resolution of an expression.
7363 The New DoResolve might be called twice when initializing field
7364 expressions (see EmitFieldInitializers, the call to
7365 GetInitializerExpression will perform a resolve on the expression,
7366 and later the assign will trigger another resolution
7368 This leads to bugs (#37014)
7370 * delegate.cs: The signature for EndInvoke should contain any ref
7371 or out parameters as well. We were not doing this in the past.
7373 * class.cs (Field.Define): Do not overwrite the type definition
7374 inside the `volatile' group. Turns out that volatile enumerations
7375 were changing the type here to perform a validity test, which
7378 2003-02-12 Miguel de Icaza <miguel@ximian.com>
7380 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
7381 and structs, we do not want to load the instance variable
7383 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
7384 enum_type has to be handled like an object reference (implicit
7385 conversions exists from this to object), but the regular IsClass
7386 and IsValueType tests will never return true for this one.
7388 Also we use TypeManager.IsValueType instead of type.IsValueType,
7389 just for consistency with the rest of the code (this is only
7390 needed if we ever use the construct exposed by test-180.cs inside
7391 corlib, which we dont today).
7393 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
7395 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
7398 2003-02-09 Martin Baulig <martin@ximian.com>
7400 * namespace.cs (Namespace..ctor): Added SourceFile argument.
7401 (Namespace.DefineNamespaces): New static public method; this is
7402 called when we're compiling with debugging to add all namespaces
7405 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
7406 pass it to the Namespace's .ctor.
7408 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
7409 and MethodBase arguments; pass the namespace ID to the symwriter;
7410 pass the MethodBase instead of the token to the symwriter.
7411 (SymbolWriter.DefineNamespace): New method to add a namespace to
7414 2003-02-09 Martin Baulig <martin@ximian.com>
7416 * symbolwriter.cs: New file. This is a wrapper around
7417 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
7418 methods here in near future.
7420 2003-02-09 Martin Baulig <martin@ximian.com>
7422 * codegen.cs (EmitContext.Mark): Just pass the arguments to
7423 ILGenerator.MarkSequencePoint() which are actually used by the
7426 2003-02-09 Martin Baulig <martin@ximian.com>
7428 * location.cs (SourceFile): New public sealed class. This
7429 contains the name and an index which is used in the location's token.
7430 (Location): Reserve an appropriate number of bits in the token for
7431 the source file instead of walking over that list, this gives us a
7432 really huge performance improvement when compiling with debugging.
7434 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
7435 `SourceFile' argument instead of a string.
7436 (Driver.ProcessFile): Add all the files via Location.AddFile(),
7437 but don't parse/tokenize here, we need to generate the list of all
7438 source files before we do that.
7439 (Driver.ProcessFiles): New static function. Parses/tokenizes all
7442 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
7443 instead of a string.
7445 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
7448 2003-02-09 Martin Baulig <martin@ximian.com>
7450 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
7451 filename on `#line default'.
7453 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
7455 * statement.cs: don't clear the pinned var when the fixed statement
7456 returns from the method (fixes bug#37752).
7458 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
7460 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
7463 2003-02-07 Martin Baulig <martin@ximian.com>
7465 * driver.cs: Removed the `--debug-args' command line argument.
7467 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
7468 automatically by the AsssemblyBuilder.
7469 (CodeGen.InitializeSymbolWriter): We don't need to call any
7470 initialization function on the symbol writer anymore. This method
7471 doesn't take any arguments.
7473 2003-02-03 Miguel de Icaza <miguel@ximian.com>
7475 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
7476 from referenced assemblies as well.
7478 2003-02-02 Martin Baulig <martin@ximian.com>
7480 * class.cs (MethodData.Emit): Generate debugging info for external methods.
7482 2003-02-02 Martin Baulig <martin@ximian.com>
7484 * class.cs (Constructor.Emit): Open the symbol writer before
7485 emitting the constructor initializer.
7486 (ConstructorInitializer.Emit): Call ec.Mark() to allow
7487 single-stepping through constructor initializers.
7489 2003-01-30 Miguel de Icaza <miguel@ximian.com>
7491 * class.cs: Handle error 549: do not allow virtual methods in
7494 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
7496 * decl.cs: Check access levels when resolving types
7498 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
7500 * statement.cs: Add parameters and locals set in catch blocks that might
7501 return to set vector
7503 2003-01-29 Miguel de Icaza <miguel@ximian.com>
7505 * class.cs (Operator): Set the SpecialName flags for operators.
7507 * expression.cs (Invocation.DoResolve): Only block calls to
7508 accessors and operators on SpecialName methods.
7510 (Cast.TryReduce): Handle conversions from char constants.
7513 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
7515 * statement.cs: small memory and time optimization in FlowBranching.
7517 2003-01-28 Pedro Mart <yoros@wanadoo.es>
7519 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
7520 problem that the last fix but in the other sid (Set).
7522 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
7523 access when there is no indexer in the hierarchy.
7525 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
7527 * class.cs: Combine some if statements.
7529 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7531 * driver.cs: fixed bug #37187.
7533 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
7535 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
7536 any indexer, it's needed to build a list with all the indexers in the
7537 hierarchy (AllGetters), else we have problems. Fixes #35653.
7539 2003-01-23 Miguel de Icaza <miguel@ximian.com>
7541 * class.cs (MethodData.Define): It is wrong for an interface
7542 implementation to be static in both cases: explicit and implicit.
7543 We were only handling this in one case.
7545 Improve the if situation there to not have negations.
7547 * class.cs (Field.Define): Turns out that we do not need to check
7548 the unsafe bit on field definition, only on usage. Remove the test.
7550 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7552 * driver.cs: use assembly.Location instead of Codebase (the latest
7553 patch made mcs fail when using MS assemblies).
7555 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
7557 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
7558 get the path to *corlib.dll.
7560 2003-01-21 Nick Drochak <ndrochak@gol.com>
7564 * typemanager.cs: Remove compiler warnings
7566 2003-01-20 Duncan Mak <duncan@ximian.com>
7568 * AssemblyInfo.cs: Bump the version number to 0.19.
7570 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7572 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
7574 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
7576 * class.cs (Constructor::Emit): Emit debugging info for constructors.
7578 2003-01-17 Miguel de Icaza <miguel@ximian.com>
7580 * cs-parser.jay: Small fix: we were not comparing the constructor
7581 name correctly. Thanks to Zoltan for the initial pointer.
7583 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
7585 * cs-tokenizer.cs: Set file name when specified with #line
7587 2003-01-15 Miguel de Icaza <miguel@ximian.com>
7589 * cs-parser.jay: Only perform the constructor checks here if we
7590 are named like the class; This will help provider a better
7591 error. The constructor path is taken when a type definition is
7592 not found, but most likely the user forgot to add the type, so
7593 report that rather than the constructor error.
7595 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
7597 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
7600 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7602 * cs-parser.jay: Add cleanup call.
7604 2003-01-13 Duncan Mak <duncan@ximian.com>
7606 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
7607 consistent with other methods.
7609 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
7611 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
7613 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
7615 * attribute.cs: only set GuidAttr to true when we have a
7618 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7622 * typemanager.cs: fixes to allow mcs compile corlib with the new
7623 Type.IsSubclassOf fix.
7625 2003-01-08 Miguel de Icaza <miguel@ximian.com>
7627 * expression.cs (LocalVariableReference.DoResolve): Classify a
7628 constant as a value, not as a variable. Also, set the type for
7631 * cs-parser.jay (fixed_statement): take a type instead of a
7632 pointer_type, so we can produce a better error message later.
7634 * statement.cs (Fixed.Resolve): Flag types that are not pointers
7637 (For.DoEmit): Make inifinite loops have a
7638 non-conditional branch back.
7640 (Fixed.DoEmit): First populate the pinned variables, then emit the
7641 statement, then clear the variables. Before I was emitting the
7642 code once for each fixed piece.
7645 2003-01-08 Martin Baulig <martin@ximian.com>
7647 * statement.cs (FlowBranching.MergeChild): A break in a
7648 SWITCH_SECTION does not leave a loop. Fixes #36155.
7650 2003-01-08 Martin Baulig <martin@ximian.com>
7652 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
7653 lives in the same number space than `param_map'. Fixes #36154.
7655 2003-01-07 Miguel de Icaza <miguel@ximian.com>
7657 * cs-parser.jay (constructor_declaration): Set the
7658 Constructor.ModFlags before probing for it. This makes the
7659 compiler report 514, 515 and 132 (the code was there, but got
7662 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
7663 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
7664 (GotoCase.Resolve): Set `Returns' to ALWAYS.
7666 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
7668 * enum.cs: create the enum static fields using the enum type.
7670 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
7672 * class.cs: don't try to create the ParamBuilder for the return
7673 type if it's not needed (and handle it breaking for the ms runtime
7676 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
7678 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
7680 2002-12-29 Miguel de Icaza <miguel@ximian.com>
7682 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
7683 the command. This showed up while compiling the JANET source
7684 code, which used \r as its only newline separator.
7686 2002-12-28 Miguel de Icaza <miguel@ximian.com>
7688 * class.cs (Method.Define): If we are an operator (because it
7689 reuses our code), then set the SpecialName and HideBySig. #36128
7691 2002-12-22 Miguel de Icaza <miguel@ximian.com>
7693 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
7694 exception, report error 120 `object reference required'.
7696 * driver.cs: Add --pause option, used during to measure the size
7697 of the process as it goes with --timestamp.
7699 * expression.cs (Invocation.DoResolve): Do not allow methods with
7700 SpecialName to be invoked.
7702 2002-12-21 Miguel de Icaza <miguel@ximian.com>
7704 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
7705 number before adding it.
7707 2002-12-21 Ravi Pratap <ravi@ximian.com>
7709 * ecore.cs (StandardImplicitConversion): When in an unsafe
7710 context, we allow conversion between void * to any other pointer
7711 type. This fixes bug #35973.
7713 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
7715 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
7716 is not thrown when extensionless outputs are used
7718 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7720 * rootcontext.cs: fixed compilation of corlib.
7722 2002-12-19 Miguel de Icaza <miguel@ximian.com>
7724 * attribute.cs (Attributes.Contains): Add new method.
7726 * class.cs (MethodCore.LabelParameters): if the parameter is an
7727 `out' parameter, check that no attribute `[In]' has been passed.
7729 * enum.cs: Handle the `value__' name in an enumeration.
7731 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
7733 * decl.cs: Added special case to allow overrides on "protected
7736 2002-12-18 Ravi Pratap <ravi@ximian.com>
7738 * attribute.cs (Attributes.AddAttributeSection): Rename to this
7739 since it makes much more sense.
7741 (Attributes.ctor): Don't require a Location parameter.
7743 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
7745 * attribute.cs (ApplyAttributes): Remove extra Location parameters
7746 since we already have that information per attribute.
7748 * everywhere : make appropriate changes.
7750 * class.cs (LabelParameters): Write the code which actually
7751 applies attributes to the return type. We can't do this on the MS
7752 .NET runtime so we flag a warning in the case an exception is
7755 2002-12-18 Miguel de Icaza <miguel@ximian.com>
7757 * const.cs: Handle implicit null conversions here too.
7759 2002-12-17 Ravi Pratap <ravi@ximian.com>
7761 * class.cs (MethodCore.LabelParameters): Remove the extra
7762 Type [] parameter since it is completely unnecessary. Instead
7763 pass in the method's attributes so that we can extract
7764 the "return" attribute.
7766 2002-12-17 Miguel de Icaza <miguel@ximian.com>
7768 * cs-parser.jay (parse): Use Report.Error to flag errors instead
7769 of ignoring it and letting the compile continue.
7771 * typemanager.cs (ChangeType): use an extra argument to return an
7772 error condition instead of throwing an exception.
7774 2002-12-15 Miguel de Icaza <miguel@ximian.com>
7776 * expression.cs (Unary.TryReduce): mimic the code for the regular
7777 code path. Perform an implicit cast in the cases where we can
7778 implicitly convert to one of the integral types, and then reduce
7779 based on that constant. This fixes bug #35483.
7781 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7783 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
7785 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7787 * namespace.cs: fixed bug #35489.
7789 2002-12-12 Miguel de Icaza <miguel@ximian.com>
7791 * class.cs: Remove some dead code.
7793 * cs-parser.jay: Estimate the number of methods needed
7794 (RootContext.MethodCount);
7796 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
7797 numbers instead of StringBuilders.
7799 * support.cs (PtrHashtable): Add constructor with initial size;
7800 We can now reduce reallocations of the method table.
7802 2002-12-10 Ravi Pratap <ravi@ximian.com>
7804 * attribute.cs (ApplyAttributes): Keep track of the emitted
7805 attributes on a per-target basis. This fixes bug #35413.
7807 2002-12-10 Miguel de Icaza <miguel@ximian.com>
7809 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
7810 default to the Windows 1252 encoding.
7812 (UnixParseOption): Support version, thanks to Alp for the missing
7815 * AssemblyInfo.cs: Add nice assembly information.
7817 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
7820 * cs-parser.jay: Allow a trailing comma before the close bracked
7821 in the attribute_section production.
7823 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
7824 address of the instance was being taken, I will take this out,
7825 because we take the address of the object immediately here.
7827 2002-12-09 Ravi Pratap <ravi@ximian.com>
7829 * typemanager.cs (AreMultipleAllowed): Take care of the most
7830 obvious case where attribute type is not in the current assembly -
7833 2002-12-08 Miguel de Icaza <miguel@ximian.com>
7835 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
7836 definitions, instead of doing that afterwards.
7838 Also we use a nice little hack, depending on the constructor, we
7839 know if we are a "composed" name or a simple name. Hence, we
7840 avoid the IndexOf test, and we avoid
7842 * codegen.cs: Add code to assist in a bug reporter to track down
7843 the source of a compiler crash.
7845 2002-12-07 Ravi Pratap <ravi@ximian.com>
7847 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
7848 types have been emitted for a given element and flag an error
7849 if something which does not have AllowMultiple set is used more
7852 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
7853 attribute types and their corresponding AllowMultiple properties
7855 (AreMultipleAllowed): Check the property for a given type.
7857 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
7858 property in the case we have a TypeContainer.
7860 (Attributes.AddAttribute): Detect duplicates and just skip on
7861 adding them. This trivial fix catches a pretty gross error in our
7862 attribute emission - global attributes were being emitted twice!
7864 Bugzilla bug #33187 is now fixed.
7866 2002-12-06 Miguel de Icaza <miguel@ximian.com>
7868 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
7871 * expression.cs (Binary.ResolveOperator): I can only use the
7872 Concat (string, string, string) and Concat (string, string,
7873 string, string) if the child is actually a concatenation of
7876 2002-12-04 Miguel de Icaza <miguel@ximian.com>
7878 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
7879 context where we need a 2-character lookahead.
7881 * pending.cs (PendingImplementation): Rework so we can keep track
7882 of interface types all the time, and flag those which were
7883 implemented by parents as optional.
7885 2002-12-03 Miguel de Icaza <miguel@ximian.com>
7887 * expression.cs (Binary.ResolveOperator): Use
7888 String.Concat(string,string,string) or
7889 String.Concat(string,string,string,string) when possible.
7891 * typemanager: More helper methods.
7894 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
7896 * pending.cs: remove the bogus return from GetMissingInterfaces()
7897 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
7899 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
7901 * namespace.cs: avoid duplicated 'using xxx' being added to
7902 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
7903 when we get more than one 'using' statement for the same namespace.
7904 Report a CS0105 warning for it.
7906 2002-11-30 Miguel de Icaza <miguel@ximian.com>
7908 * cs-tokenizer.cs (consume_identifier): use read directly, instead
7909 of calling getChar/putback, uses internal knowledge of it.
7911 (xtoken): Reorder tokenizer so most common patterns are checked
7912 first. This reduces the compilation time in another 5% (from 8.11s
7913 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
7915 The parsing time is 22% of the compilation in mcs, and from that
7916 64% is spent on the tokenization process.
7918 I tried using a binary search for keywords, but this is slower
7919 than the hashtable. Another option would be to do a couple of
7922 * Not use a StringBuilder, instead use an array of chars,
7923 with a set value. Notice that this way we could catch
7924 the 645 error without having to do it *afterwards*.
7926 * We could write a hand-parser to avoid the hashtable
7927 compares altogether.
7929 The identifier consumption process takes 37% of the tokenization
7930 time. Another 15% is spent on is_number. 56% of the time spent
7931 on is_number is spent on Int64.Parse:
7933 * We could probably choose based on the string length to
7934 use Int32.Parse or Int64.Parse and avoid all the 64-bit
7937 Another 3% is spend on wrapping `xtoken' in the `token' function.
7939 Handle 0xa0 as whitespace (#34752)
7941 2002-11-26 Miguel de Icaza <miguel@ximian.com>
7943 * typemanager.cs (IsCLRType): New routine to tell whether a type
7944 is one of the builtin types.
7946 Maybe it needs to use TypeCodes to be faster. Maybe we could use
7947 typecode in more places instead of doing pointer comparissions.
7948 We could leverage some knowledge about the way the typecodes are
7951 New code to cache namespaces in assemblies, it is currently not
7952 invoked, to be used soon.
7954 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
7956 * expression.cs (Binary.ResolveOperator): specially handle
7957 strings, and do not perform user-defined operator overloading for
7960 2002-11-24 Miguel de Icaza <miguel@ximian.com>
7962 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
7963 internalcall as it is a pretty simple operation; Avoid whenever
7964 possible to call Char.IsLetter.
7966 (consume_identifier): Cut by half the number of
7967 hashtable calls by merging the is_keyword and GetKeyword behavior.
7969 Do not short-circuit, because if we do, we
7970 report errors (ie, #if false && true would produce an invalid
7974 2002-11-24 Martin Baulig <martin@ximian.com>
7976 * expression.cs (Cast.TryReduce): If we're in checked syntax,
7977 check constant ranges and report a CS0221. Fixes #33186.
7979 2002-11-24 Martin Baulig <martin@ximian.com>
7981 * cs-parser.jay: Make this work for uninitialized variable
7982 declarations in the `for' initializer. Fixes #32416.
7984 2002-11-24 Martin Baulig <martin@ximian.com>
7986 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
7987 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
7989 2002-11-24 Martin Baulig <martin@ximian.com>
7991 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
7992 argument; if true, we also check for user-defined conversions.
7993 This is only needed if both arguments are of a user-defined type.
7994 Fixes #30443, added test-175.cs.
7995 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
7997 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
7999 2002-11-24 Martin Baulig <martin@ximian.com>
8001 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
8002 function to get the store opcode.
8003 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
8004 only emit the Ldelema if the store opcode is Stobj. You must run
8005 both test-34 and test-167 to test this. Fixes #34529.
8007 2002-11-23 Martin Baulig <martin@ximian.com>
8009 * ecore.cs (Expression.MemberLookup): Added additional
8010 `qualifier_type' argument which is used when we're being called
8011 from MemberAccess.DoResolve() and null if we're called from a
8013 (Expression.MemberLookupFailed): New method to report errors; this
8014 does the CS1540 check and reports the correct error message.
8016 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
8017 argument for the CS1540 check and redone the way how we're dealing
8018 with private members. See the comment in the source code for details.
8019 (FilterWithClosure): Reverted this back to revision 1.197; renamed
8020 `closure_start_type' to `closure_qualifier_type' and check whether
8021 it's not null. It was not this filter being broken, it was just
8022 being called with the wrong arguments.
8024 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
8025 and pass it the correct `qualifier_type'; this also does the error
8028 2002-11-22 Miguel de Icaza <miguel@ximian.com>
8030 * expression.cs (Invocation.EmitParams): If the we are dealing
8031 with a non-built-in value type, load its address as well.
8033 (ArrayCreation): Use a a pretty constant instead
8034 of the hardcoded value 2. Use 6 instead of 2 for the number of
8035 static initializers.
8037 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
8038 because they are not really value types, just glorified integers.
8040 * driver.cs: Do not append .exe, the CSC compiler does not do it.
8042 * ecore.cs: Remove redundant code for enumerations, make them use
8043 the same code path as everything else, fixes the casting issue
8044 with enumerations in Windows.Forms.
8046 * attribute.cs: Do only cast to string if it is a string, the
8047 validation happens later.
8049 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
8050 people upgrade their corlibs.
8052 * ecore.cs: Oops, enumerations were not following the entire code path
8054 2002-11-21 Miguel de Icaza <miguel@ximian.com>
8056 * typemanager.cs (FilterWithClosure): Commented out the test for
8057 1540 in typemanager.cs, as it has problems when accessing
8058 protected methods from a parent class (see test-174.cs).
8060 * attribute.cs (Attribute.ValidateGuid): new method.
8061 (Attribute.Resolve): Use above.
8063 2002-11-19 Miguel de Icaza <miguel@ximian.com>
8065 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
8067 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
8068 handling for enumerations, as we only needed the TypeContainer
8069 functionality to begin with (this is required for the fix below to
8070 work for enums that reference constants in a container class for
8073 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
8075 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
8076 a valid TypeBuilder to perform lookups on.o
8078 * class.cs (InheritableMemberSignatureCompare): Use true in the
8079 call to GetGetMethod and GetSetMethod, because we are comparing
8080 the signature, and we need to get the methods *even* if they are
8083 (PropertyBase.CheckBase): ditto.
8085 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
8086 GotoCase.Resolve): Use Peel on EmpytCasts.
8088 * ecore.cs (EmptyCast): drop child, add Peel method.
8090 2002-11-17 Martin Baulig <martin@ximian.com>
8092 * ecore.cs (EmptyCast.Child): New public property.
8094 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
8095 label resolved to an EmptyCast. Fixes #34162.
8096 (GotoCase.Resolve): Likewise.
8097 (Block.EmitMeta): Likewise.
8099 2002-11-17 Martin Baulig <martin@ximian.com>
8101 * expression.cs (Invocation.BetterConversion): Prefer int over
8102 uint; short over ushort; long over ulong for integer literals.
8103 Use ImplicitConversionExists instead of StandardConversionExists
8104 since we also need to check for user-defined implicit conversions.
8105 Fixes #34165. Added test-173.cs.
8107 2002-11-16 Martin Baulig <martin@ximian.com>
8109 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
8110 with the `true' and `false' literals. Fixes #33151.
8112 2002-11-16 Martin Baulig <martin@ximian.com>
8114 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
8115 October 22nd; don't do the cs1540 check for static members.
8117 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
8118 now using our own filter here and doing the cs1540 check again.
8120 2002-11-16 Martin Baulig <martin@ximian.com>
8122 * support.cs (InternalParameters): Don't crash if we don't have
8123 any fixed parameters. Fixes #33532.
8125 2002-11-16 Martin Baulig <martin@ximian.com>
8127 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
8128 when looking up static methods to make this work on Windows.
8131 2002-11-16 Martin Baulig <martin@ximian.com>
8133 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
8134 a setter rather than using PropertyInfo.CanWrite.
8136 2002-11-15 Nick Drochak <ndrochak@gol.com>
8138 * class.cs: Allow acces to block member by subclasses. Fixes build
8141 2002-11-14 Martin Baulig <martin@ximian.com>
8143 * class.cs (Constructor.Emit): Added the extern/block check.
8146 2002-11-14 Martin Baulig <martin@ximian.com>
8148 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
8149 iteration while looking for indexers, this is needed because the
8150 indexer may have a different name in our base classes. Fixed the
8151 error reporting (no indexers at all, not get accessor, no
8152 overloaded match). Fixes bug #33089.
8153 (IndexerAccess.DoResolveLValue): Likewise.
8155 2002-11-14 Martin Baulig <martin@ximian.com>
8157 * class.cs (PropertyBase.CheckBase): Make this work for multiple
8158 indexers. Fixes the first part of bug #33089.
8159 (MethodSignature.InheritableMemberSignatureCompare): Added support
8162 2002-11-13 Ravi Pratap <ravi@ximian.com>
8164 * attribute.cs (Attribute.Resolve): Catch the
8165 NullReferenceException and report it since it isn't supposed to
8168 2002-11-12 Miguel de Icaza <miguel@ximian.com>
8170 * expression.cs (Binary.EmitBranchable): Also handle the cases for
8171 LogicalOr and LogicalAnd that can benefit from recursively
8172 handling EmitBranchable. The code now should be nice for Paolo.
8174 2002-11-08 Miguel de Icaza <miguel@ximian.com>
8176 * typemanager.cs (LookupType): Added a negative-hit hashtable for
8177 the Type lookups, as we perform quite a number of lookups on
8178 non-Types. This can be removed once we can deterministically tell
8179 whether we have a type or a namespace in advance.
8181 But this might require special hacks from our corlib.
8185 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
8186 and double which avoids a conversion from an integer to a double.
8188 * expression.cs: tiny optimization, avoid calling IsConstant,
8189 because it effectively performs the lookup twice.
8191 2002-11-06 Miguel de Icaza <miguel@ximian.com>
8193 But a bogus return here to keep the semantics of the old code
8194 until the Mono runtime is fixed.
8196 * pending.cs (GetMissingInterfaces): New method used to remove all
8197 the interfaces that are already implemented by our parent
8198 classes from the list of pending methods.
8200 * interface.cs: Add checks for calls after ResolveTypeExpr.
8202 2002-11-05 Miguel de Icaza <miguel@ximian.com>
8204 * class.cs (Class.Emit): Report warning 67: event not used if the
8205 warning level is beyond 3.
8207 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
8208 being a NullLiteral.
8210 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
8213 * class.cs (TypeContainer.GetClassBases): Cover a missing code
8214 path that might fail if a type can not be resolved.
8216 * expression.cs (Binary.Emit): Emit unsigned versions of the
8219 * driver.cs: use error 5.
8221 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
8223 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
8225 2002-11-01 Miguel de Icaza <miguel@ximian.com>
8227 * cs-parser.jay (switch_section): A beautiful patch from Martin
8228 Baulig that fixed 33094.
8230 2002-10-31 Miguel de Icaza <miguel@ximian.com>
8232 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
8233 Check whether the base is abstract and report an error if so.
8235 * expression.cs (IndexerAccess.DoResolveLValue,
8236 IndexerAccess.DoResolve): ditto.
8238 (Invocation.DoResolve): ditto.
8240 (Invocation.FullMethodDesc): Improve the report string.
8242 * statement.cs (Block): Eliminate IsVariableDefined as it is
8243 basically just a wrapper for GetVariableInfo.
8245 * ecore.cs (SimpleName): Use new
8247 * support.cs (ReflectionParamter.ParameterType): We unwrap the
8248 type, as we return the actual parameter ref/unref state on a
8251 2002-10-30 Miguel de Icaza <miguel@ximian.com>
8253 * support.cs: Return proper flags REF/OUT fixing the previous
8256 * expression.cs: Reverted last patch, that was wrong. Is_ref is
8257 not used to mean `ref' but `ref or out' in ParameterReference
8259 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
8260 full type signature instead of calling TypeManger.CSharpName
8263 * support.cs (InternalParameters.ParameterDesc): Do not compare
8264 directly to the modflags, because REF/OUT will actually be bitsets
8267 * delegate.cs (VerifyMethod): Check also the modifiers.
8269 * cs-tokenizer.cs: Fix bug where floating point values with an
8270 exponent where a sign was missing was ignored.
8272 * driver.cs: Allow multiple assemblies to be specified in a single
8275 2002-10-28 Miguel de Icaza <miguel@ximian.com>
8277 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
8278 because identifiers after a parenthesis would end up in this kind
8279 of production, and we needed to desamiguate it for having casts
8282 (UserDefinedType *) xxx
8284 2002-10-24 Miguel de Icaza <miguel@ximian.com>
8286 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
8287 we should set on the Bindingflags.NonPublic, but not turn on
8288 private_ok. private_ok controls whether a Private member is
8289 returned (this is chekced on the filter routine), while the
8290 BindingFlags.NonPublic just controls whether private/protected
8291 will be allowed. This fixes the problem part of the problem of
8292 private properties being allowed to be used in derived classes.
8294 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
8295 so we can call the children DoResolveLValue method (this will
8296 properly signal errors on lvalue assignments to base properties)
8298 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
8299 getter are null, and we have a property info, we know that this
8300 happened because the lookup failed, so we report an error 122 for
8301 protection level violation.
8303 We also silently return if setter and getter are null in the
8304 resolve functions, this condition only happens if we have flagged
8305 the error before. This is the other half of the problem.
8307 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
8308 not have accessibility information, that is why we were returning
8309 true in the filter function in typemanager.cs.
8311 To properly report 122 (property is inaccessible because of its
8312 protection level) correctly, we report this error in ResolveAccess
8313 by failing if both the setter and the getter are lacking (ie, the
8316 DoResolve and DoLResolve have been modified to check for both
8317 setter/getter being null and returning silently, the reason being
8318 that I did not want to put the knowledge about this error in upper
8321 int old = Report.Errors;
8322 x = new PropertyExpr (...);
8323 if (old != Report.Errors)
8328 So the property expr is returned, but it is invalid, so the error
8329 will be flagged during the resolve process.
8331 * class.cs: Remove InheritablePropertySignatureCompare from the
8332 class, as we no longer depend on the property signature to compute
8333 whether it is possible to implement a method or not.
8335 The reason is that calling PropertyInfo.GetGetMethod will return
8336 null (in .NET, in Mono it works, and we should change this), in
8337 cases where the Get Method does not exist in that particular
8342 class X { public virtual int A { get { return 1; } } }
8344 class Z : Y { public override int A { get { return 2; } } }
8346 Would fail in Z because the parent (Y) would not have the property
8347 defined. So we avoid this completely now (because the alternative
8348 fix was ugly and slow), and we now depend exclusively on the
8351 (PropertyBase.CheckBase): Use a method-base mechanism to find our
8352 reference method, instead of using the property.
8354 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
8355 routines are gone now.
8357 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
8358 names, they were incorrectly named.
8360 * cs-tokenizer.cs: Return are more gentle token on failure.
8362 * pending.cs (PendingImplementation.InterfaceMethod): This routine
8363 had an out-of-sync index variable, which caused it to remove from
8364 the list of pending methods the wrong method sometimes.
8366 2002-10-22 Miguel de Icaza <miguel@ximian.com>
8368 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
8369 CanWrite, because those refer to this particular instance of the
8370 property, and do not take into account the fact that we can
8371 override single members of a property.
8373 Constructor requires an EmitContext. The resolution process does
8374 not happen here, but we need to compute the accessors before,
8375 because the resolution does not always happen for properties.
8377 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
8378 subclass, before we did not update this flag, but we did update
8381 (GetAccessors): Drop this routine, as it did not work in the
8382 presence of partially overwritten set/get methods.
8384 Notice that this broke the cs1540 detection, but that will require
8387 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8391 * driver.cs: issue a warning instead of an error if we don't support
8392 debugging for the platform. Also ignore a couple of errors that may
8393 arise when trying to write the symbols. Undo my previous patch.
8395 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8397 * driver.cs: ignore /debug switch except for Unix platforms.
8399 2002-10-23 Nick Drochak <ndrochak@gol.com>
8401 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
8403 2002-10-21 Miguel de Icaza <miguel@ximian.com>
8405 * driver.cs: Do not make mcs-debug conditional, so we do not break
8408 * statement.cs (UsageVector.MergeChildren): I would like Martin to
8409 review this patch. But basically after all the children variables
8410 have been merged, the value of "Breaks" was not being set to
8411 new_breaks for Switch blocks. I think that it should be set after
8412 it has executed. Currently I set this to the value of new_breaks,
8413 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
8414 conservative, but I do not understand this code very well.
8416 I did not break anything in the build, so that is good ;-)
8418 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
8420 2002-10-20 Mark Crichton <crichton@gimp.org>
8422 * cfold.cs: Fixed compile blocker. Really fixed it this time.
8424 2002-10-20 Nick Drochak <ndrochak@gol.com>
8426 * cfold.cs: Fixed compile blocker.
8428 2002-10-20 Miguel de Icaza <miguel@ximian.com>
8430 * driver.cs: I was chekcing the key, not the file.
8432 2002-10-19 Ravi Pratap <ravi@ximian.com>
8434 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
8435 message that we were generating - we just need to silently return
8438 2002-10-19 Miguel de Icaza <miguel@ximian.com>
8440 * class.cs (Event.Define): Change my previous commit, as this
8441 breaks the debugger. This is a temporary hack, as it seems like
8442 the compiler is generating events incorrectly to begin with.
8444 * expression.cs (Binary.ResolveOperator): Added support for
8445 "U operator - (E x, E y)"
8447 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
8450 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
8451 init-only variables, but this path did not take into account that
8452 there might be also instance readonly variables. Correct this
8455 This fixes bug 32253
8457 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
8460 * driver.cs: Change the extension for modules to `netmodule'
8462 * cs-parser.jay: Improved slightly the location tracking for
8463 the debugger symbols.
8465 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
8466 modifiers that were specified instead of the hardcoded value
8467 (FamAndAssem). This was basically ignoring the static modifier,
8468 and others. Fixes 32429.
8470 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
8471 fixed a bug in the process (32476)
8473 * expression.cs (ArrayAccess.EmitAssign): Patch from
8474 hwang_rob@yahoo.ca that fixes bug 31834.3
8476 2002-10-18 Miguel de Icaza <miguel@ximian.com>
8478 * driver.cs: Make the module extension .netmodule.
8480 2002-10-16 Miguel de Icaza <miguel@ximian.com>
8482 * driver.cs: Report an error if the resource file is not found
8483 instead of crashing.
8485 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
8486 false, like Emit does.
8488 2002-10-16 Nick Drochak <ndrochak@gol.com>
8490 * typemanager.cs: Remove unused private member. Also reported mcs
8491 bug to report this as a warning like csc.
8493 2002-10-15 Martin Baulig <martin@gnome.org>
8495 * statement.cs (Statement.Emit): Made this a virtual method; emits
8496 the line number info and calls DoEmit().
8497 (Statement.DoEmit): New protected abstract method, formerly knows
8498 as Statement.Emit().
8500 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
8502 2002-10-11 Miguel de Icaza <miguel@ximian.com>
8504 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
8505 have fixed a remaining problem: not every AddXXXX was adding a
8506 fully qualified name.
8508 Now everyone registers a fully qualified name in the DeclSpace as
8509 being defined instead of the partial name.
8511 Downsides: we are slower than we need to be due to the excess
8512 copies and the names being registered this way.
8514 The reason for this is that we currently depend (on the corlib
8515 bootstrap for instance) that types are fully qualified, because
8516 we dump all the types in the namespace, and we should really have
8517 types inserted into the proper namespace, so we can only store the
8518 basenames in the defined_names array.
8520 2002-10-10 Martin Baulig <martin@gnome.org>
8522 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
8523 from bug #31834, see the bug report for a testcase which is
8526 2002-10-10 Martin Baulig <martin@gnome.org>
8528 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
8529 flow analysis code for this.
8531 * statement.cs (Do, While, For): Tell the flow analysis code about
8533 (FlowBranching.UsageVector): Added support for infinite loops.
8534 (Block.Resolve): Moved the dead code elimination here and use flow
8537 2002-10-09 Miguel de Icaza <miguel@ximian.com>
8539 * class.cs (Field.Define): Catch cycles on struct type
8542 * typemanager.cs (IsUnmanagedtype): Do not recursively check
8543 fields if the fields are static. We only need to check instance
8546 * expression.cs (As.DoResolve): Test for reference type.
8548 * statement.cs (Using.ResolveExpression): Use
8549 ConvertImplicitRequired, not ConvertImplicit which reports an
8551 (Using.ResolveLocalVariableDecls): ditto.
8553 * expression.cs (Binary.ResolveOperator): Report errors in a few
8554 places where we had to.
8556 * typemanager.cs (IsUnmanagedtype): Finish implementation.
8558 2002-10-08 Miguel de Icaza <miguel@ximian.com>
8560 * expression.cs: Use StoreFromPtr instead of extracting the type
8561 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
8563 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
8564 an enumeration value to a System.Enum, but System.Enum is not a
8565 value type, but an class type, so we need to box.
8567 (Expression.ConvertExplicit): One codepath could return
8568 errors but not flag them. Fix this. Fixes #31853
8570 * parameter.cs (Resolve): Do not allow void as a parameter type.
8572 2002-10-06 Martin Baulig <martin@gnome.org>
8574 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
8575 if it's a class type and not a struct. Fixes #31815.
8577 2002-10-06 Martin Baulig <martin@gnome.org>
8579 * statement.cs: Reworked the flow analysis code a bit to make it
8580 usable for dead code elimination.
8582 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
8584 * cs-parser.jay: allow empty source files. Fixes bug #31781.
8586 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8588 * expression.cs (ComposedCast.DoResolveType): A quick workaround
8589 to fix the test 165, will investigate deeper.
8591 2002-10-04 Martin Baulig <martin@gnome.org>
8593 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
8594 finally blocks actually work.
8595 (Try.Resolve): We don't need to create a sibling for `finally' if
8596 there is no finally block.
8598 2002-10-04 Martin Baulig <martin@gnome.org>
8600 * class.cs (Constructor.Define): The default accessibility for a
8601 non-default constructor is private, not public.
8603 2002-10-04 Miguel de Icaza <miguel@ximian.com>
8605 * class.cs (Constructor): Make AllowedModifiers public, add
8608 * cs-parser.jay: Perform the modifiers test here, as the
8609 constructor for the Constructor class usually receives a zero
8610 because of the way we create it (first we create, later we
8611 customize, and we were never checking the modifiers).
8613 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
8614 is a version of LookupTypeReflection that includes the type-name
8615 cache. This can be used as a fast path for functions that know
8616 the fully qualified name and are only calling into *.GetType() to
8617 obtain a composed type.
8619 This is also used by TypeManager.LookupType during its type
8622 (LookupType): We now also track the real type name, as sometimes
8623 we can get a quey for the real type name from things like
8624 ComposedCast. This fixes bug 31422.
8626 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
8627 complete type fullname, it does not have to go through the type
8628 resolution system to obtain the composed version of the type (for
8629 obtaining arrays or pointers).
8631 (Conditional.Emit): Use the EmitBoolExpression to
8632 generate nicer code, as requested by Paolo.
8634 (ArrayCreation.CheckIndices): Use the patch from
8635 hwang_rob@yahoo.ca to validate the array initializers.
8637 2002-10-03 Miguel de Icaza <miguel@ximian.com>
8639 * class.cs (ConstructorInitializer.Emit): simplify code by using
8640 Invocation.EmitCall, and at the same time, fix the bugs in calling
8641 parent constructors that took variable arguments.
8643 * ecore.cs (Expression.ConvertNumericExplicit,
8644 Expression.ImplicitNumericConversion): Remove the code that
8645 manually wrapped decimal (InternalTypeConstructor call is now gone
8648 * expression.cs (Cast.TryReduce): Also handle decimal types when
8649 trying to perform a constant fold on the type.
8651 * typemanager.cs (IsUnmanagedtype): Partially implemented.
8653 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
8654 that only turned off an error report, and did nothing else.
8656 2002-10-02 Miguel de Icaza <miguel@ximian.com>
8658 * driver.cs: Handle and ignore /fullpaths
8660 2002-10-01 Miguel de Icaza <miguel@ximian.com>
8662 * expression.cs (Binary.ResolveOperator): Catch the case where
8663 DoNumericPromotions returns true,
8665 (Binary.DoNumericPromotions): Simplify the code, and the tests.
8667 2002-09-27 Miguel de Icaza <miguel@ximian.com>
8669 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
8672 2002-09-26 Miguel de Icaza <miguel@ximian.com>
8674 * ecore.cs (ConvertNumericExplicit): It is not enough that the
8675 conversion exists, but it is also required that the conversion be
8676 performed. This manifested in "(Type64Enum) 2".
8678 * class.cs (TypeManager.AddMethod): The fix is not to change
8679 AddEnum, because that one was using a fully qualified name (every
8680 DeclSpace derivative does), but to change the AddMethod routine
8681 that was using an un-namespaced name. This now correctly reports
8682 the duplicated name.
8684 Revert patch until I can properly fix it. The issue
8685 is that we have a shared Type space across all namespaces
8686 currently, which is wrong.
8688 Options include making the Namespace a DeclSpace, and merge
8689 current_namespace/current_container in the parser.
8691 2002-09-25 Miguel de Icaza <miguel@ximian.com>
8693 * cs-parser.jay: Improve error reporting when we get a different
8694 kind of expression in local_variable_type and
8695 local_variable_pointer_type.
8697 Propagate this to avoid missleading errors being reported.
8699 * ecore.cs (ImplicitReferenceConversion): treat
8700 TypeManager.value_type as a target just like object_type. As
8705 Is valid, and needs to result in the int 1 being boxed before it
8706 is assigned to the value type v.
8708 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
8709 to validate the enumeration name.
8711 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
8712 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
8713 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
8715 * ecore.cs (TryImplicitIntConversion): When doing an
8716 implicit-enumeration-conversion, check if the type is 64-bits and
8717 perform a conversion before passing to EnumConstant.
8719 2002-09-23 Miguel de Icaza <miguel@ximian.com>
8721 * decl.cs (Error_AmbiguousTypeReference); New routine used to
8722 report ambiguous type references. Unlike the MS version, we
8723 report what the ambiguity is. Innovation at work ;-)
8725 (DeclSpace.FindType): Require a location argument to
8726 display when we display an ambiguous error.
8728 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
8730 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
8732 * expression.cs (EmitDynamicInitializers): Apply patch from
8733 hwang_rob@yahoo.ca that fixes the order in which we emit our
8736 2002-09-21 Martin Baulig <martin@gnome.org>
8738 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
8739 delegate takes no arguments.
8741 2002-09-20 Miguel de Icaza <miguel@ximian.com>
8743 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
8746 * expression.cs: Extract the underlying type.
8748 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
8750 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
8752 2002-09-19 Miguel de Icaza <miguel@ximian.com>
8754 * class.cs (TypeContainer.DefineType): We can not use the nice
8755 PackingSize with the size set to 1 DefineType method, because it
8756 will not allow us to define the interfaces that the struct
8759 This completes the fixing of bug 27287
8761 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
8762 means also structs. This fixes part of the problem.
8763 (Expresion.ImplicitReferenceConversionExists): ditto.
8765 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
8766 error if there were no errors reported during the type lookup
8767 process, to avoid duplicates or redundant errors. Without this
8768 you would get an ambiguous errors plus a type not found. We have
8769 beaten the user enough with the first error.
8771 (DeclSparce.FindType): Emit a warning if we have an ambiguous
8774 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
8775 during the resolution process, stop the lookup, this avoids
8776 repeated error reports (same error twice).
8778 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
8780 * typemanager.cs (LookupType): Redo the type lookup code to match
8781 the needs of System.Reflection.
8783 The issue is that System.Reflection requires references to nested
8784 types to begin with a "+" sign instead of a dot. So toplevel
8785 types look like: "NameSpace.TopLevelClass", and nested ones look
8786 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
8789 2002-09-19 Martin Baulig <martin@gnome.org>
8791 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
8792 says that a method always returns or always throws an exception,
8793 don't report the CS0161.
8795 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
8796 set `Returns = new_returns'.
8798 2002-09-19 Martin Baulig <martin@gnome.org>
8800 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
8801 to an enum constant, check for a CS0176.
8803 2002-09-18 Miguel de Icaza <miguel@ximian.com>
8805 * class.cs (TypeContainer.CheckPairedOperators): Now we check
8806 for operators that must be in pairs and report errors.
8808 * ecore.cs (SimpleName.DoResolveType): During the initial type
8809 resolution process, when we define types recursively, we must
8810 check first for types in our current scope before we perform
8811 lookups in the enclosing scopes.
8813 * expression.cs (MakeByteBlob): Handle Decimal blobs.
8815 (Invocation.VerifyArgumentsCompat): Call
8816 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
8817 I thought we were supposed to always call this, but there are a
8818 few places in the code where we dont do it.
8820 2002-09-17 Miguel de Icaza <miguel@ximian.com>
8822 * driver.cs: Add support in -linkres and -resource to specify the
8823 name of the identifier.
8825 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8827 * ecore.cs (StandardConversionExists): Sync with the conversion
8828 code: allow anything-* to void* conversions.
8830 (FindMostSpecificSource): Use an Expression argument
8831 instead of a Type, because we might be handed over a Literal which
8832 gets a few more implicit conversions that plain types do not. So
8833 this information was being lost.
8835 Also, we drop the temporary type-holder expression when not
8838 2002-09-17 Martin Baulig <martin@gnome.org>
8840 * class.cs (PropertyBase.CheckBase): Don't check the base class if
8841 this is an explicit interface implementation.
8843 2002-09-17 Martin Baulig <martin@gnome.org>
8845 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
8846 different `IndexerName' attributes.
8848 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
8849 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
8850 virtual CommonResolve().
8852 2002-09-16 Miguel de Icaza <miguel@ximian.com>
8854 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
8855 and convert that to the UnderlyingType.
8857 * statement.cs (Foreach.Resolve): Indexers are just like variables
8858 or PropertyAccesses.
8860 * cs-tokenizer.cs (consume_string): Track line numbers and columns
8861 inside quoted strings, we were not doing this before.
8863 2002-09-16 Martin Baulig <martin@gnome.org>
8865 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
8866 resolve it. This is needed for the definite assignment check of the
8867 instance expression, fixes bug #29846.
8868 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
8870 2002-09-16 Nick Drochak <ndrochak@gol.com>
8872 * parameter.cs: Fix compile error. Cannot reference static member
8873 from an instance object. Is this an mcs bug?
8875 2002-09-14 Martin Baulig <martin@gnome.org>
8877 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
8878 multiple times. Fixes bug #30295, added test-166.cs.
8880 2002-09-14 Martin Baulig <martin@gnome.org>
8882 * statement.cs (Block.Emit): Don't emit unreachable code.
8883 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
8885 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
8887 2002-09-14 Martin Baulig <martin@gnome.org>
8889 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
8892 2002-09-14 Martin Baulig <martin@gnome.org>
8894 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
8895 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
8896 be false on the ms runtime.
8898 2002-09-13 Martin Baulig <martin@gnome.org>
8900 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
8901 the CS0038 error message.
8903 2002-09-12 Miguel de Icaza <miguel@ximian.com>
8905 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
8906 constant inside, return it.
8908 2002-09-12 Martin Baulig <martin@gnome.org>
8910 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
8911 implicit conversion can be done between enum types.
8913 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
8914 check whether an implicit conversion to the current enum's UnderlyingType
8915 exists and report an error if not.
8917 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
8918 without debugging support.
8920 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
8921 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
8923 2002-09-12 Martin Baulig <martin@gnome.org>
8925 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
8927 * ecore.cs (IMemberExpr.DeclaringType): New property.
8928 (SimpleName.SimpleNameResolve): Check whether we're accessing a
8929 nonstatic member of an outer type (CS0038).
8931 2002-09-11 Miguel de Icaza <miguel@ximian.com>
8933 * driver.cs: Activate the using-error detector at warning level
8934 4 (at least for MS-compatible APIs).
8936 * namespace.cs (VerifyUsing): Small buglett fix.
8938 * pending.cs (PendingImplementation): pass the container pointer.
8940 * interface.cs (GetMethods): Allow for recursive definition. Long
8941 term, I would like to move every type to support recursive
8942 definitions, not the current ordering mechanism that we have right
8945 The situation is this: Attributes are handled before interfaces,
8946 so we can apply attributes to interfaces. But some attributes
8947 implement interfaces, we will now handle the simple cases
8948 (recursive definitions will just get an error).
8950 * parameter.cs: Only invalidate types at the end if we fail to
8953 2002-09-09 Martin Baulig <martin@gnome.org>
8955 * ecore.cs (PropertyExpr.Emit): Also check for
8956 TypeManager.system_int_array_get_length so this'll also work when
8957 compiling corlib. Fixes #30003.
8959 2002-09-09 Martin Baulig <martin@gnome.org>
8961 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
8962 and throw an exception if we can't get the type's size. Fixed #30040,
8965 2002-09-09 Martin Baulig <martin@gnome.org>
8967 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
8969 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
8970 context. Fixes bug #30027.
8972 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
8973 virtual functions. Fixes bug #30043, added test-164.cs.
8975 2002-09-08 Ravi Pratap <ravi@ximian.com>
8977 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
8979 2002-09-08 Nick Drochak <ndrochak@gol.com>
8981 * driver.cs: Use an object to get the windows codepage since it's not a
8984 2002-09-08 Miguel de Icaza <miguel@ximian.com>
8986 * statement.cs (For.Emit): for infinite loops (test == null)
8987 return whether there is a break inside, not always "true".
8989 * namespace.cs (UsingEntry): New struct to hold the name of the
8990 using definition, the location where it is defined, and whether it
8991 has been used in a successful type lookup.
8993 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
8998 2002-09-06 Ravi Pratap <ravi@ximian.com>
9000 * attribute.cs : Fix incorrect code which relied on catching
9001 a NullReferenceException to detect a null being passed in
9002 where an object was expected.
9004 2002-09-06 Miguel de Icaza <miguel@ximian.com>
9006 * statement.cs (Try): flag the catch variable as assigned
9008 * expression.cs (Cast): Simplified by using ResolveType instead of
9011 * statement.cs (Catch): Fix bug by using ResolveType.
9013 2002-09-06 Ravi Pratap <ravi@ximian.com>
9015 * expression.cs (BetterConversion): Special case for when we have
9016 a NullLiteral as the argument and we have to choose between string
9017 and object types - we choose string the way csc does.
9019 * attribute.cs (Attribute.Resolve): Catch the
9020 NullReferenceException and report error #182 since the Mono
9021 runtime no more has the bug and having this exception raised means
9022 we tried to select a constructor which takes an object and is
9025 2002-09-05 Ravi Pratap <ravi@ximian.com>
9027 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
9028 message (1502, 1503) when we can't locate a method after overload
9029 resolution. This is much more informative and closes the bug
9032 * interface.cs (PopulateMethod): Return if there are no argument
9033 types. Fixes a NullReferenceException bug.
9035 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
9036 expressions too. Previously we were checking only in one place for
9037 positional arguments leaving out named arguments.
9039 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
9040 type to the enum type is not allowed. Remove code corresponding to
9043 (ConvertNumericExplicit): Allow explicit conversions from
9044 the underlying type to enum type. This precisely follows the spec
9045 and closes a bug filed by Gonzalo.
9047 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9050 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
9052 2002-09-03 Miguel de Icaza <miguel@ximian.com>
9054 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
9055 it was important that we stored the right value after the
9056 reduction in `converted'.
9058 2002-09-04 Martin Baulig <martin@gnome.org>
9060 * location.cs (Location.SymbolDocument): Use full pathnames for the
9063 2002-08-30 Miguel de Icaza <miguel@ximian.com>
9065 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
9066 of the expression resolve mechanism, because that will catch the
9067 SimpleName error failures.
9069 (Conditional): If we can not resolve the
9070 expression, return, do not crash.
9072 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9075 (location): display token name instead of its number.
9077 2002-08-28 Martin Baulig <martin@gnome.org>
9079 * expression.cs (Binary.ResolveOperator): Don't silently return
9080 but return an error if an operator cannot be applied between two
9083 2002-08-28 Martin Baulig <martin@gnome.org>
9085 * class.cs (Constructor.Define): Set the permission attributes
9086 correctly instead of making all constructors public.
9088 2002-08-28 Martin Baulig <martin@gnome.org>
9090 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
9091 for private members before reporting a CS0103; if we find anything,
9094 2002-08-28 Martin Baulig <martin@gnome.org>
9096 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
9097 to check whether `closure_start_type == closure_invocation_type',
9098 we also need to check whether `m.DeclaringType == closure_invocation_type'
9099 before bypassing the permission checks. We might be accessing
9100 protected/private members from the base class.
9101 (TypeManager.RealMemberLookup): Only set private_ok if private
9102 members were requested via BindingFlags.NonPublic.
9104 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
9106 * expression.cs (MemberAccess.ResolveMemberAccess): Set
9107 MethodGroupExpr.IsExplicitImpl if appropriate.
9108 (Invocation.DoResolve): Don't report the CS0120 for explicit
9109 interface implementations.
9111 2002-08-27 Martin Baulig <martin@gnome.org>
9113 * expression.cs (Invocation.DoResolve): If this is a static
9114 method and we don't have an InstanceExpression, we must report
9117 2002-08-25 Martin Baulig <martin@gnome.org>
9119 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
9120 `==' between a valuetype and an object.
9122 2002-08-25 Miguel de Icaza <miguel@ximian.com>
9124 * ecore.cs (TypeExpr): Provide a ToString method.
9126 2002-08-24 Martin Baulig <martin@gnome.org>
9128 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
9129 now called proggie.dbg and it's a binary file.
9131 2002-08-23 Martin Baulig <martin@gnome.org>
9133 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
9135 2002-08-23 Martin Baulig <martin@gnome.org>
9137 * struct.cs (MyStructInfo.ctor): Make this work with empty
9138 structs; it's not allowed to use foreach() on null.
9140 2002-08-23 Martin Baulig <martin@gnome.org>
9142 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
9143 writer the full pathname of the generated assembly.
9145 2002-08-23 Martin Baulig <martin@gnome.org>
9147 * statements.cs (FlowBranching.UsageVector.MergeChildren):
9148 A `finally' block never returns or breaks; improved handling of
9151 2002-08-23 Martin Baulig <martin@gnome.org>
9153 * statement.cs (Throw.Resolve): Allow `throw null'.
9155 2002-08-23 Martin Baulig <martin@gnome.org>
9157 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
9158 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
9159 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
9160 MemberLookup would return a wrong event if this is an explicit
9161 interface implementation and the class has an event with the same
9164 2002-08-23 Martin Baulig <martin@gnome.org>
9166 * statement.cs (Block.AddChildVariableNames): New public method.
9167 (Block.AddChildVariableName): Likewise.
9168 (Block.IsVariableNameUsedInChildBlock): Likewise.
9169 (Block.AddVariable): Check whether a variable name has already
9170 been used in a child block.
9172 * cs-parser.jay (declare_local_variables): Mark all variable names
9173 from the current block as being used in a child block in the
9176 2002-08-23 Martin Baulig <martin@gnome.org>
9178 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
9179 find the symbol writer.
9181 * driver.cs: csc also allows the arguments to /define being
9182 separated by commas, not only by semicolons.
9184 2002-08-23 Martin Baulig <martin@gnome.org>
9186 * interface.cs (Interface.GetMembers): Added static check for events.
9188 2002-08-15 Martin Baulig <martin@gnome.org>
9190 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
9191 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
9193 * ecore.cs (Expression.MemberLookup): Added documentation and explained
9194 why the MethodData.EmitDestructor() change was necessary.
9196 2002-08-20 Martin Baulig <martin@gnome.org>
9198 * class.cs (TypeContainer.FindMembers): Added static check for events.
9200 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
9202 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
9203 use Type.GetEvents(), not Type.FindMembers().
9205 2002-08-20 Martin Baulig <martin@gnome.org>
9207 * decl.cs (MemberCache): Added a special method cache which will
9208 be used for method-only searched. This ensures that a method
9209 search will return a MethodInfo with the correct ReflectedType for
9212 2002-08-20 Martin Baulig <martin@gnome.org>
9214 * decl.cs (DeclSpace.FindMembers): Made this public.
9216 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9218 * delegate.cs: fixed build on windows.
9219 [FIXME: Filed as bug #29150: MCS must report these errors.]
9221 2002-08-19 Ravi Pratap <ravi@ximian.com>
9223 * ecore.cs (StandardConversionExists): Return a false
9224 if we are trying to convert the void type to anything else
9225 since that is not allowed.
9227 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
9228 we flag error 70 in the event an event is trying to be accessed
9229 directly from outside the declaring type.
9231 2002-08-20 Martin Baulig <martin@gnome.org>
9233 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
9234 MemberCache from typemanager.cs to decl.cs.
9236 2002-08-19 Martin Baulig <martin@gnome.org>
9238 * class.cs (TypeContainer): Implement IMemberContainer.
9239 (TypeContainer.DefineMembers): Create the MemberCache.
9240 (TypeContainer.FindMembers): Do better BindingFlags checking; only
9241 return public members if BindingFlags.Public was given, check
9242 whether members are static.
9244 2002-08-16 Martin Baulig <martin@gnome.org>
9246 * decl.cs (DeclSpace.Define): Splitted this in Define and
9247 DefineMembers. DefineMembers is called first and initializes the
9250 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
9251 DefineMembers() on all our DeclSpaces.
9253 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
9254 but call DefineMembers() on all nested interfaces. We call their
9255 Define() in our new Define() function.
9257 * interface.cs (Interface): Implement IMemberContainer.
9258 (Interface.Define): Moved all code except the attribute stuf to
9260 (Interface.DefineMembers): Initialize the member cache.
9262 * typemanager.cs (IMemberFinder): Removed this interface, we don't
9263 need this anymore since we can use MemberCache.FindMembers directly.
9265 2002-08-19 Martin Baulig <martin@gnome.org>
9267 * typemanager.cs (MemberCache): When creating the cache for an
9268 interface type, add all inherited members.
9269 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
9270 to `out bool used_cache' and documented it.
9271 (TypeManager.MemberLookup): If we already used the cache in the first
9272 iteration, we don't need to do the interfaces check.
9274 2002-08-19 Martin Baulig <martin@gnome.org>
9276 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
9277 here from IMemberFinder and don't implement this interface anymore.
9278 (DeclSpace.MemberCache): Moved here from IMemberFinder.
9280 * typemanager.cs (IMemberFinder): This interface is now only used by
9281 classes which actually support the member cache.
9282 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
9283 since we only put DeclSpaces into this Hashtable.
9284 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
9285 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
9287 2002-08-16 Martin Baulig <martin@gnome.org>
9289 * typemanager.cs (ICachingMemberFinder): Removed.
9290 (IMemberFinder.MemberCache): New property.
9291 (TypeManager.FindMembers): Merged this with RealFindMembers().
9292 This function will never be called from TypeManager.MemberLookup()
9293 so we can't use the cache here, just the IMemberFinder.
9294 (TypeManager.MemberLookup_FindMembers): Check whether the
9295 IMemberFinder has a MemberCache and call the cache's FindMembers
9297 (MemberCache): Rewrote larger parts of this yet another time and
9298 cleaned it up a bit.
9300 2002-08-15 Miguel de Icaza <miguel@ximian.com>
9302 * driver.cs (LoadArgs): Support quoting.
9304 (Usage): Show the CSC-like command line arguments.
9306 Improved a few error messages.
9308 2002-08-15 Martin Baulig <martin@gnome.org>
9310 * typemanager.cs (IMemberContainer.Type): New property.
9311 (IMemberContainer.IsInterface): New property.
9313 The following changes are conditional to BROKEN_RUNTIME, which is
9314 defined at the top of the file.
9316 * typemanager.cs (MemberCache.MemberCache): Don't add the base
9317 class'es members, but add all members from TypeHandle.ObjectType
9318 if we're an interface.
9319 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
9320 is the current type.
9321 (MemberCache.CacheEntry.Container): Removed this field.
9322 (TypeHandle.GetMembers): Include inherited members.
9324 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9326 * typemanager.cs: fixed compilation and added a comment on a field that
9329 2002-08-15 Martin Baulig <martin@gnome.org>
9331 * class.cs (ConstructorInitializer.Resolve): In the
9332 Expression.MemberLookup call, use the queried_type as
9335 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
9336 declared' attribute, it's always true.
9337 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
9338 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
9339 temporary wrapper for FindMembers which tells MemberLookup whether
9340 members from the base classes are included in the return value.
9341 This will go away soon.
9342 (TypeManager.MemberLookup): Use this temporary hack here; once the
9343 new MemberCache is completed, we don't need to do the DeclaredOnly
9344 looping here anymore since the MemberCache will take care of this.
9345 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
9346 (MemberCache): When creating the MemberCache for a class, get
9347 members from the current class and all its base classes.
9348 (MemberCache.CacheEntry.Container): New field. This is a
9349 temporary hack until the Mono runtime is fixed to distinguish
9350 between ReflectedType and DeclaringType. It allows us to use MCS
9351 with both the MS runtime and the unfixed Mono runtime without
9352 problems and without accecting performance.
9353 (MemberCache.SearchMembers): The DeclaredOnly looping from
9354 TypeManager.MemberLookup is now done here.
9356 2002-08-14 Martin Baulig <martin@gnome.org>
9358 * statement.cs (MyStructInfo.MyStructInfo): Don't call
9359 Type.GetFields on dynamic types but get the fields from the
9360 corresponding TypeContainer.
9361 (MyStructInfo.GetStructInfo): Added check for enum types.
9363 * typemanager.cs (MemberList.IsSynchronized): Implemented.
9364 (MemberList.SyncRoot): Implemented.
9365 (TypeManager.FilterWithClosure): No need to check permissions if
9366 closure_start_type == closure_invocation_type, don't crash if
9367 closure_invocation_type is null.
9369 2002-08-13 Martin Baulig <martin@gnome.org>
9371 Rewrote TypeContainer.FindMembers to use a member cache. This
9372 gives us a speed increase of about 35% for the self-hosting MCS
9373 build and of about 15-20% for the class libs (both on GNU/Linux).
9375 * report.cs (Timer): New class to get enhanced profiling. This
9376 whole class is "TIMER" conditional since it remarkably slows down
9379 * class.cs (MemberList): New class. This is an IList wrapper
9380 which we're now using instead of passing MemberInfo[]'s around to
9381 avoid copying this array unnecessarily.
9382 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
9383 (ICachingMemberFinder, IMemberContainer): New interface.
9384 (TypeManager.FilterWithClosure): If `criteria' is null, the name
9385 has already been checked, otherwise use it for the name comparision.
9386 (TypeManager.FindMembers): Renamed to RealMemberFinder and
9387 provided wrapper which tries to use ICachingMemberFinder.FindMembers
9388 if possible. Returns a MemberList, not a MemberInfo [].
9389 (TypeHandle): New class, implements IMemberContainer. We create
9390 one instance of this class per type, it contains a MemberCache
9391 which is used to do the member lookups.
9392 (MemberCache): New class. Each instance of this class contains
9393 all members of a type and a name-based hash table.
9394 (MemberCache.FindMembers): This is our new member lookup
9395 function. First, it looks up all members of the requested name in
9396 the hash table. Then, it walks this list and sorts out all
9397 applicable members and returns them.
9399 2002-08-13 Martin Baulig <martin@gnome.org>
9401 In addition to a nice code cleanup, this gives us a performance
9402 increase of about 1.4% on GNU/Linux - not much, but it's already
9403 half a second for the self-hosting MCS compilation.
9405 * typemanager.cs (IMemberFinder): New interface. It is used by
9406 TypeManager.FindMembers to call FindMembers on a TypeContainer,
9407 Enum, Delegate or Interface.
9408 (TypeManager.finder_to_member_finder): New PtrHashtable.
9409 (TypeManager.finder_to_container): Removed.
9410 (TypeManager.finder_to_delegate): Removed.
9411 (TypeManager.finder_to_interface): Removed.
9412 (TypeManager.finder_to_enum): Removed.
9414 * interface.cs (Interface): Implement IMemberFinder.
9416 * delegate.cs (Delegate): Implement IMemberFinder.
9418 * enum.cs (Enum): Implement IMemberFinder.
9420 * class.cs (TypeContainer): Implement IMemberFinder.
9422 2002-08-12 Martin Baulig <martin@gnome.org>
9424 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
9426 2002-08-12 Martin Baulig <martin@gnome.org>
9428 * ecore.cs (ITypeExpression): New interface for expressions which
9430 (TypeExpression): Renamed to TypeLookupExpression.
9431 (Expression.DoResolve): If we're doing a types-only lookup, the
9432 expression must implement the ITypeExpression interface and we
9433 call DoResolveType() on it.
9434 (SimpleName): Implement the new ITypeExpression interface.
9435 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
9436 hack, the situation that we're only looking up types can't happen
9437 anymore when this method is called. Moved the type lookup code to
9438 DoResolveType() and call it.
9439 (SimpleName.DoResolveType): This ITypeExpression interface method
9440 is now doing the types-only lookup.
9441 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
9442 (ResolveFlags): Added MaskExprClass.
9444 * expression.cs (MemberAccess): Implement the ITypeExpression
9446 (MemberAccess.DoResolve): Added support for a types-only lookup
9447 when we're called via ITypeExpression.DoResolveType().
9448 (ComposedCast): Implement the ITypeExpression interface.
9450 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
9451 Expression.Resolve() with ResolveFlags.Type instead.
9453 2002-08-12 Martin Baulig <martin@gnome.org>
9455 * interface.cs (Interface.Define): Apply attributes.
9457 * attribute.cs (Attribute.ApplyAttributes): Added support for
9458 interface attributes.
9460 2002-08-11 Martin Baulig <martin@gnome.org>
9462 * statement.cs (Block.Emit): Only check the "this" variable if we
9463 do not always throw an exception.
9465 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
9466 whether the property has a set accessor.
9468 2002-08-11 Martin Baulig <martin@gnome.org>
9470 Added control flow analysis support for structs.
9472 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
9473 with control flow analysis turned off.
9474 (IVariable): New interface.
9475 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
9476 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
9477 (FieldExpr.DoResolve): Resolve the instance expression with flow
9478 analysis turned off and do the definite assignment check after the
9479 resolving when we know what the expression will resolve to.
9481 * expression.cs (LocalVariableReference, ParameterReference):
9482 Implement the new IVariable interface, only call the flow analysis
9483 code if ec.DoFlowAnalysis is true.
9484 (This): Added constructor which takes a Block argument. Implement
9485 the new IVariable interface.
9486 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
9487 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
9488 This does the definite assignment checks for struct members.
9490 * class.cs (Constructor.Emit): If this is a non-static `struct'
9491 constructor which doesn't have any initializer, call
9492 Block.AddThisVariable() to tell the flow analysis code that all
9493 struct elements must be initialized before control returns from
9496 * statement.cs (MyStructInfo): New public class.
9497 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
9498 argument to this indexer. If non-zero, check an individual struct
9499 member, not the whole struct.
9500 (FlowBranching.CheckOutParameters): Check struct members.
9501 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
9502 overloaded versions of these methods which take an additional
9503 `int field_idx' argument to check struct members.
9504 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
9505 overloaded versions of these methods which take an additional
9506 `string field_name' argument to check struct member.s
9507 (VariableInfo): Implement the IVariable interface.
9508 (VariableInfo.StructInfo): New public property. Returns the
9509 MyStructInfo instance of the variable if it's a struct or null.
9510 (Block.AddThisVariable): New public method. This is called from
9511 Constructor.Emit() for non-static `struct' constructor which do
9512 not have any initializer. It creates a special variable for the
9513 "this" instance variable which will be checked by the flow
9514 analysis code to ensure that all of the struct's fields are
9515 initialized before control returns from the constructor.
9516 (UsageVector): Added support for struct members. If a
9517 variable/parameter is a struct with N members, we reserve a slot
9518 in the usage vector for each member. A struct is considered fully
9519 initialized if either the struct itself (slot 0) or all its
9520 members are initialized.
9522 2002-08-08 Martin Baulig <martin@gnome.org>
9524 * driver.cs (Driver.MainDriver): Only report an error CS5001
9525 if there were no compilation errors.
9527 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
9528 `UnsafeContext' property to determine whether the parent is in
9529 unsafe context rather than checking the parent's ModFlags:
9530 classes nested in an unsafe class are unsafe as well.
9532 2002-08-08 Martin Baulig <martin@gnome.org>
9534 * statement.cs (UsageVector.MergeChildren): Distinguish between
9535 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
9536 we return. Added test17() and test18() to test-154.cs.
9538 2002-08-08 Martin Baulig <martin@gnome.org>
9540 * typemanager.cs (TypeManager.FilterWithClosure): If we have
9541 Family access, make sure the invoking type isn't a subclass of the
9542 queried type (that'd be a CS1540).
9544 * ecore.cs (Expression.MemberLookup): Added overloaded version of
9545 this method which takes an additional `Type invocation_type'.
9547 * expression.cs (BaseAccess.DoResolve): Use the base type as
9548 invocation and query type.
9549 (MemberAccess.DoResolve): If the lookup failed and we're about to
9550 report a CS0122, try a lookup with the ec.ContainerType - if this
9551 succeeds, we must report a CS1540.
9553 2002-08-08 Martin Baulig <martin@gnome.org>
9555 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
9556 (MethodGroupExpr): Implement the IMemberExpr interface.
9558 * expression (MemberAccess.ResolveMemberAccess): No need to have
9559 any special code for MethodGroupExprs anymore, they're now
9562 2002-08-08 Martin Baulig <martin@gnome.org>
9564 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
9565 Family, FamANDAssem and FamORAssem permissions.
9566 (TypeManager.IsSubclassOrNestedChildOf): New public method.
9568 2002-08-08 Martin Baulig <martin@gnome.org>
9570 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
9571 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
9574 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
9576 * driver.cs: implemented /resource option to embed managed resources.
9578 2002-08-07 Martin Baulig <martin@gnome.org>
9580 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
9581 (FieldBase.HasFieldInitializer): New public property.
9582 (FieldBase.GetInitializerExpression): New public method. Resolves and
9583 returns the field initializer and makes sure it is only resolved once.
9584 (TypeContainer.EmitFieldInitializers): Call
9585 FieldBase.GetInitializerExpression to get the initializer, this ensures
9586 that it isn't resolved multiple times.
9588 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
9589 the resolving process (SimpleName/MemberLookup) that we're currently
9590 emitting a field initializer (which must not access any instance members,
9591 this is an error CS0236).
9593 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
9594 argument, if the `IsFieldInitializer' flag is set, we must report and
9595 error CS0236 and not an error CS0120.
9597 2002-08-07 Martin Baulig <martin@gnome.org>
9599 * ecore.cs (IMemberExpr): New public interface.
9600 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
9601 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
9602 if the expression is an IMemberExpr.
9604 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
9605 to be null, implicitly default to `this' if we're non-static in
9606 this case. Simplified the code a lot by using the new IMemberExpr
9607 interface. Also fixed bug #28176 here.
9609 2002-08-06 Martin Baulig <martin@gnome.org>
9611 * cs-parser.jay (SimpleLookup): Removed. We need to create
9612 ParameterReferences during semantic analysis so that we can do a
9613 type-only search when resolving Cast, TypeOf and SizeOf.
9614 (block): Pass the `current_local_parameters' to the Block's
9617 * class.cs (ConstructorInitializer): Added `Parameters parameters'
9618 argument to the constructor.
9619 (ConstructorInitializer.Resolve): Create a temporary implicit
9620 block with the parameters.
9622 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
9623 references here if we aren't doing a type-only search.
9625 * statement.cs (Block): Added constructor which takes a
9626 `Parameters parameters' argument.
9627 (Block.Parameters): New public property.
9629 * support.cs (InternalParameters.Parameters): Renamed `parameters'
9630 to `Parameters' and made it public readonly.
9632 2002-08-06 Martin Baulig <martin@gnome.org>
9634 * ecore.cs (Expression.Warning): Made this public as well.
9636 * report.cs (Report.Debug): Print the contents of collections.
9638 2002-08-06 Martin Baulig <martin@gnome.org>
9640 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
9641 used to tell Resolve() which kinds of expressions it may return.
9642 (Expression.Resolve): Added overloaded version of this method which
9643 takes a `ResolveFlags flags' argument. This can be used to tell
9644 Resolve() which kinds of expressions it may return. Reports a
9646 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
9647 ResolveFlags.SimpleName.
9648 (Expression.Error118): Added overloaded version of this method which
9649 takes a `ResolveFlags flags' argument. It uses the flags to determine
9650 which kinds of expressions are allowed.
9652 * expression.cs (Argument.ResolveMethodGroup): New public method.
9653 Resolves an argument, but allows a MethodGroup to be returned.
9654 This is used when invoking a delegate.
9656 * TODO: Updated a bit.
9658 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9660 Fixed compilation with csc.
9662 * ecore.cs: Expression.Error made public. Is this correct? Should
9663 Warning be made public too?
9665 * expression.cs: use ea.Location instead of ea.loc.
9666 [FIXME: Filed as bug #28607: MCS must report these errors.]
9668 2002-08-06 Martin Baulig <martin@gnome.org>
9670 * ecore.cs (Expression.loc): Moved the location here instead of
9671 duplicating it in all derived classes.
9672 (Expression.Location): New public property.
9673 (Expression.Error, Expression.Warning): Made them non-static and
9674 removed the location argument.
9675 (Expression.Warning): Added overloaded version which takes an
9676 `int level' argument.
9677 (Expression.Error118): Make this non-static and removed the
9678 expression and location arguments.
9679 (TypeExpr): Added location argument to the constructor.
9681 * expression.cs (StaticCallExpr): Added location argument to
9683 (Indirection, PointerArithmetic): Likewise.
9684 (CheckedExpr, UnCheckedExpr): Likewise.
9685 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
9686 (StringPtr): Likewise.
9689 2002-08-05 Martin Baulig <martin@gnome.org>
9691 * expression.cs (BaseAccess.DoResolve): Actually report errors.
9693 * assign.cs (Assign.DoResolve): Check whether the source
9694 expression is a value or variable.
9696 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
9697 while resolving the corresponding blocks.
9699 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
9700 an error, don't silently return null.
9702 * statement.cs (Block.AddVariable): Do the error reporting here
9703 and distinguish between CS0128 and CS0136.
9704 (Block.DoResolve): Report all unused labels (warning CS0164).
9705 (LabeledStatement): Pass the location to the constructor.
9706 (LabeledStatement.HasBeenReferenced): New property.
9707 (LabeledStatement.Resolve): Set it to true here.
9709 * statement.cs (Return.Emit): Return success even after reporting
9710 a type mismatch error (CS0126 or CS0127), this is what csc does and
9711 it avoids confusing the users with any consecutive errors.
9713 2002-08-05 Martin Baulig <martin@gnome.org>
9715 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
9717 * const.cs (Const.LookupConstantValue): Catch circular definitions.
9719 * expression.cs (MemberAccess.DoResolve): Silently return if an
9720 error has already been reported.
9722 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
9723 error has already been reported.
9725 2002-08-05 Martin Baulig <martin@gnome.org>
9727 * statement.cs (UsageVector): Only initialize the `parameters'
9728 vector if we actually have any "out" parameters.
9730 2002-08-05 Martin Baulig <martin@gnome.org>
9732 * expression.cs (Binary.ResolveOperator): When combining delegates,
9733 they must have the same type.
9735 2002-08-05 Martin Baulig <martin@gnome.org>
9737 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
9738 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
9739 work with the ms runtime and we also don't need it: if we're a
9740 PropertyBuilder and not in the `indexer_arguments' hash, then we
9741 are a property and not an indexer.
9743 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
9744 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
9745 since the latter one doesn't work with the ms runtime.
9747 2002-08-03 Martin Baulig <martin@gnome.org>
9749 Fixed bugs #27998 and #22735.
9751 * class.cs (Method.IsOperator): New public field.
9752 (Method.CheckBase): Report CS0111 if there's already a method
9753 with the same parameters in the current class. Report CS0508 when
9754 attempting to change the return type of an inherited method.
9755 (MethodData.Emit): Report CS0179 if a method doesn't have a body
9756 and it's not marked abstract or extern.
9757 (PropertyBase): New abstract base class for Property and Indexer.
9758 (PropertyBase.CheckBase): Moved here from Property and made it work
9760 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
9761 the same so we can reuse it there.
9762 (Property, Indexer): Derive from PropertyBase.
9763 (MethodSignature.inheritable_property_signature_filter): New delegate
9764 to find properties and indexers.
9766 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
9767 argument and improved error reporting.
9769 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
9770 EmptyReadOnlyParameters and made it a property.
9772 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
9773 version of this method which takes a `PropertyInfo indexer'.
9774 (TypeManager.RegisterIndexer): New method.
9776 * class.cs: Added myself as author of this file :-)
9778 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
9780 * class.cs: fixed compilation on windoze.
9782 2002-08-03 Martin Baulig <martin@gnome.org>
9784 * interface.cs (Interface.GetInterfaceBases): Check whether all
9785 base interfaces are at least as accessible than the current one.
9787 * class.cs (TypeContainer.GetClassBases): Check whether base types
9788 are at least as accessible than the current type.
9789 (TypeContainer.AsAccessible): Implemented and made non-static.
9790 (MemberBase.CheckParameters): Report errors if the accessibility
9793 * delegate.cs (Delegate.Delegate): The default visibility is
9794 internal for top-level types and private for nested types.
9795 (Delegate.Define): Report errors if the accessibility checks fail.
9797 * enum.cs (Enum.Enum): The default visibility is internal for
9798 top-level types and private for nested types.
9799 (Enum.DefineType): Compute the correct visibility.
9801 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
9802 function which takes a `bool is_toplevel' instead of a TypeContainer.
9804 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
9807 2002-08-02 Martin Baulig <martin@gnome.org>
9809 * expression.cs (LocalVariableReferenc): Added constructor which
9810 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
9811 (LocalVariableReference.IsReadOnly): New property.
9812 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
9813 variable is readonly, use our own readonly flag to do this; you can
9814 use the new constructor to get a writable reference to a read-only
9817 * cs-parser.jay (foreach_statement, using_statement): Get a writable
9818 reference to the local variable.
9820 2002-08-01 Miguel de Icaza <miguel@ximian.com>
9822 * rootcontext.cs (ResolveCore): Also include System.Exception
9824 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
9825 we reach an EmptyStatement.
9827 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
9830 * expression.cs (Binary.ResolveOperator): Check error result in
9833 use brtrue/brfalse directly and avoid compares to null.
9835 2002-08-02 Martin Baulig <martin@gnome.org>
9837 * class.cs (TypeContainer.Define): Define all nested interfaces here.
9838 Fixes bug #28407, added test-155.cs.
9840 2002-08-01 Martin Baulig <martin@gnome.org>
9842 * class.cs (Event.EmitDefaultMethod): Make this work with static
9843 events. Fixes #28311, added verify-3.cs.
9845 2002-08-01 Martin Baulig <martin@gnome.org>
9847 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
9848 `is_disposable' fields.
9849 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
9850 `hm.is_disposable' if we're using the collection pattern.
9851 (Foreach.EmitCollectionForeach): Use the correct type for the
9852 enumerator's local variable, only emit the try/finally block if
9853 necessary (fixes #27713).
9855 2002-08-01 Martin Baulig <martin@gnome.org>
9857 * ecore.cs (Expression.report118): Renamed to Error118 and made
9860 * statement.cs (Throw.Resolve): Check whether the expression is of
9861 the correct type (CS0118) and whether the type derives from
9862 System.Exception (CS0155).
9863 (Catch.Resolve): New method. Do the type lookup here and check
9864 whether it derives from System.Exception (CS0155).
9865 (Catch.CatchType, Catch.IsGeneral): New public properties.
9867 * typemanager.cs (TypeManager.exception_type): Added.
9869 2002-07-31 Miguel de Icaza <miguel@ximian.com>
9871 * driver.cs: Updated About function.
9873 2002-07-31 Martin Baulig <martin@gnome.org>
9875 Implemented Control Flow Analysis.
9877 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
9878 (EmitContext.CurrentBranching): Added.
9879 (EmitContext.StartFlowBranching): Added.
9880 (EmitContext.EndFlowBranching): Added.
9881 (EmitContext.KillFlowBranching): Added.
9882 (EmitContext.IsVariableAssigned): Added.
9883 (EmitContext.SetVariableAssigned): Added.
9884 (EmitContext.IsParameterAssigned): Added.
9885 (EmitContext.SetParameterAssigned): Added.
9886 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
9887 Added control flow analysis stuff here.
9889 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
9890 resolve the expression as lvalue.
9891 (LocalVariableReference.DoResolve): Check whether the variable has
9892 already been assigned.
9893 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
9894 the parameter as assigned here.
9895 (ParameterReference.DoResolve): Check whether the parameter has already
9897 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
9898 expression as lvalue.
9900 * statement.cs (FlowBranching): New class for the flow analysis code.
9901 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
9902 (LabeledStatement.IsDefined): New public property.
9903 (LabeledStatement.AddUsageVector): New public method to tell flow
9904 analyis that the label may be reached via a forward jump.
9905 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
9907 (VariableInfo.Number): New public field. This is used by flow analysis
9908 to number all locals of a block.
9909 (Block.CountVariables): New public property. This is the number of
9910 local variables in this block (including the locals from all parent
9912 (Block.EmitMeta): Number all the variables.
9914 * statement.cs: Added flow analysis support to all classes.
9916 2002-07-31 Martin Baulig <martin@gnome.org>
9918 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
9919 To get debugging messages, compile mcs with /define:MCS_DEBUG and
9920 then use this argument.
9922 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
9924 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
9925 use this to specify /define options.
9927 2002-07-29 Martin Baulig <martin@gnome.org>
9929 * statement.cs (Fixed): Moved all code that does variable lookups
9930 and resolvings from Emit to Resolve.
9932 * statement.cs (For): Moved all code that does variable lookups
9933 and resolvings from Emit to Resolve.
9935 * statement.cs (Using): Moved all code that does variable lookups
9936 and resolvings from Emit to Resolve.
9938 2002-07-29 Martin Baulig <martin@gnome.org>
9940 * attribute.cs (Attribute.Resolve): Explicitly catch a
9941 System.NullReferenceException when creating the
9942 CustromAttributeBuilder and report a different warning message.
9944 2002-07-29 Martin Baulig <martin@gnome.org>
9946 * support.cs (ParameterData.ParameterName): Added method to
9947 get the name of a parameter.
9949 * typemanager.cs (TypeManager.IsValueType): New public method.
9951 2002-07-29 Martin Baulig <martin@gnome.org>
9953 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
9954 is a flag which specifies that it's either ref or out.
9955 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
9956 the out parameter to `out Parameter.Modifier mod', also set the
9957 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
9959 * support.cs (InternalParameters.ParameterModifier): Distinguish
9960 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9961 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9963 * expression.cs (Argument.GetParameterModifier): Distinguish
9964 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
9965 Parameter.Modifier.ISBYREF flag if it's either ref or out.
9967 2002-07-29 Martin Baulig <martin@gnome.org>
9969 * expression.cs (ParameterReference.ParameterReference): Added
9970 `Location loc' argument to the constructor.
9972 * cs-parser.jay: Pass location to ParameterReference.
9974 2002-07-28 Miguel de Icaza <miguel@ximian.com>
9976 * statement.cs (Try): Initialize the location.
9978 * cs-parser.jay: pass location to Try.
9980 * expression.cs (Unary.Reduce): Change the prototype to return
9981 whether a constant fold could be performed or not. The result is
9982 returned in an out parameters. In the case of Indirection and
9983 AddressOf, we want to perform the full tests.
9985 2002-07-26 Miguel de Icaza <miguel@ximian.com>
9987 * statement.cs (Statement.Emit): Flag dead code.
9989 2002-07-27 Andrew Birkett <andy@nobugs.org>
9991 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
9993 2002-07-27 Martin Baulig <martin@gnome.org>
9995 * class.cs (MethodData.Define): Put back call to
9996 TypeManager.AddMethod(), accidentally commented this out.
9998 * report.cs (Debug): New public method to print debugging information,
9999 this is `[Conditional ("DEBUG")]'.
10001 2002-07-26 Martin Baulig <martin@gnome.org>
10003 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
10004 (switch_statement): Push the current_block to the switch_stack and
10005 pop it again when we're done with the switch.
10006 (switch_section): The new block is a child of the current_block.
10007 Fixes bug #24007, added test-152.cs.
10009 2002-07-27 Martin Baulig <martin@gnome.org>
10011 * expression.cs (Invocation.EmitArguments): When calling a varargs
10012 function with only its fixed arguments, we need to pass an empty
10015 2002-07-27 Martin Baulig <martin@gnome.org>
10017 Mono 0.13 has been released.
10019 2002-07-25 Miguel de Icaza <miguel@ximian.com>
10021 * driver.cs: Rename --resource to --linkres, because that is what
10022 we do currently, we dont support --resource yet.
10024 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
10026 2002-07-25 Martin Baulig <martin@gnome.org>
10028 * class.cs (MethodData): New public class. This is a `method builder'
10029 class for a method or one accessor of a Property/Indexer/Event.
10030 (MethodData.GetMethodFlags): Moved here from MemberBase.
10031 (MethodData.ApplyAttributes): Likewise.
10032 (MethodData.ApplyObsoleteAttribute): Likewise.
10033 (MethodData.ApplyConditionalAttribute): Likewise.
10034 (MethodData.ApplyDllImportAttribute): Likewise.
10035 (MethodData.CheckAbstractAndExternal): Likewise.
10036 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
10037 (MethodData.Emit): Formerly known as Method.Emit().
10038 (MemberBase): Moved everything which was specific to a single
10039 accessor/method to MethodData.
10040 (Method): Create a new MethodData and call Define() and Emit() on it.
10041 (Property, Indexer, Event): Create a new MethodData objects for each
10042 accessor and call Define() and Emit() on them.
10044 2002-07-25 Martin Baulig <martin@gnome.org>
10046 Made MethodCore derive from MemberBase to reuse the code from there.
10047 MemberBase now also checks for attributes.
10049 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
10050 (MemberBase.GetMethodFlags): Moved here from class Method and marked
10052 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
10053 `CallingConventions cc' and `Attributes opt_attrs' arguments.
10054 (MemberBase.ApplyAttributes): New virtual method; applies the
10055 attributes to a method or accessor.
10056 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
10057 (MemberBase.ApplyConditionalAttribute): Likewise.
10058 (MemberBase.ApplyDllImportAttribute): Likewise.
10059 (MemberBase.CheckAbstractAndExternal): Likewise.
10060 (MethodCore.ParameterTypes): This is now a property instead of a
10061 method, it's initialized from DoDefineParameters().
10062 (MethodCore.ParameterInfo): Removed the set accessor.
10063 (MethodCore.DoDefineParameters): New protected virtual method to
10064 initialize ParameterTypes and ParameterInfo.
10065 (Method.GetReturnType): We can now simply return the MemberType.
10066 (Method.GetMethodFlags): Override the MemberBase version and add
10067 the conditional flags.
10068 (Method.CheckBase): Moved some code from Define() here, call
10069 DoDefineParameters() here.
10070 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
10071 here to avoid some larger code duplication.
10072 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
10073 ensure that abstract and external accessors don't declare a body.
10075 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
10076 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
10077 lookup in the attribute's parent classes, so we need to abort as soon
10078 as we found the first match.
10079 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
10080 the attribute has no arguments.
10082 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
10085 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10087 * cs-parser.jay: reverted previous patch.
10089 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10091 * cs-parser.jay: fixed bug #22119.
10093 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10095 * attribute.cs: fixed compilation. The error was:
10096 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
10097 be assigned to before control leaves the current method."
10098 [FIXME: Filed as bug #28186: MCS must report this error.]
10100 2002-07-25 Martin Baulig <martin@gnome.org>
10102 * attribute.cs (Attribute.Conditional_GetConditionName): New static
10103 method to pull the condition name ouf of a Conditional attribute.
10104 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
10105 the obsolete message and error flag out of an Obsolete attribute.
10107 * class.cs (Method.GetMethodFlags): New public method to get the
10108 TypeManager.MethodFlags for this method.
10109 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
10111 (Method.Define): Get and apply the Obsolete and Conditional attributes;
10112 if we're overriding a virtual function, set the new private variable
10113 `parent_method'; call the new TypeManager.AddMethod().
10115 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
10116 the MethodBuilder and the Method in a PtrHashtable.
10117 (TypeManager.builder_to_method): Added for this purpose.
10118 (TypeManager.MethodFlags): Added IsObsoleteError.
10119 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
10120 Obsolete and Conditional arguments in MethodBuilders. If we discover
10121 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
10122 the message from the attribute.
10124 2002-07-24 Martin Baulig <martin@gnome.org>
10126 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
10127 preprocessor directives, ensure that the argument to #define/#undef is
10128 exactly one identifier and that it's actually an identifier.
10130 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
10133 2002-07-24 Martin Baulig <martin@gnome.org>
10135 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
10136 initialize it to TypeManager.object_type in the constructor.
10137 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
10138 of the `hm.get_current' method if we're using the collection pattern.
10139 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
10140 for the explicit conversion to make it work when we're using the collection
10141 pattern and the `Current' property has a different return type than `object'.
10144 2002-07-24 Martin Baulig <martin@gnome.org>
10146 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
10147 does not match, but don't report any errors. This method is called in
10148 order for all methods in a MethodGroupExpr until a matching method is
10149 found, so we don't want to bail out if the first method doesn't match.
10150 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
10151 matches, report the 123. Fixes #28070.
10153 2002-07-24 Martin Baulig <martin@gnome.org>
10155 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
10156 TypeManager.TypeToCoreType() to the top of the method so the
10157 following equality checks will work. Fixes #28107.
10159 2002-07-24 Martin Baulig <martin@gnome.org>
10161 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
10162 operand is of type uint, and the other operand is of type sbyte,
10163 short or int, the operands are converted to type long." -
10164 Actually do what this comment already told us. Fixes bug #28106,
10167 2002-07-24 Martin Baulig <martin@gnome.org>
10169 * class.cs (MethodBase): New abstract class. This is now a base
10170 class for Property, Indexer and Event to avoid some code duplication
10171 in their Define() and DefineMethods() methods.
10172 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
10173 generic methods for Define() and DefineMethods().
10174 (FieldBase): Derive from MemberBase, not MemberCore.
10175 (Property): Derive from MemberBase, not MemberCore.
10176 (Property.DefineMethod): Moved all the code from this method to the
10177 new MethodBase.DefineAccessor(), just call it with appropriate
10179 (Property.Define): Call the new Property.DoDefine(), this does some
10180 sanity checks and we don't need to duplicate the code everywhere.
10181 (Event): Derive from MemberBase, not MemberCore.
10182 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
10183 accessors, this will also make them work with interface events.
10184 (Indexer): Derive from MemberBase, not MemberCore.
10185 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
10186 (Indexer.Define): Use the new MethodBase functions.
10188 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
10189 argument to the constructor.
10190 (Interface.FindMembers): Added support for interface events.
10191 (Interface.PopluateEvent): Implemented.
10193 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
10195 2002-07-22 Miguel de Icaza <miguel@ximian.com>
10197 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
10198 but this is required to check for a method name being the same as
10199 the containing class.
10203 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10205 * interface.cs: initialize variable.
10207 2002-07-23 Martin Baulig <martin@gnome.org>
10209 Implemented the IndexerName attribute in interfaces.
10211 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
10212 name if this is an explicit interface implementation.
10213 (Indexer.InterfaceIndexerName): New public variable. If we're
10214 implementing an interface indexer, this is the IndexerName in that
10215 interface. Otherwise, it's the IndexerName.
10216 (Indexer.DefineMethod): If we're implementing interface indexer,
10217 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
10218 and Pending.ImplementIndexer methods.
10219 (Indexer.Define): Also define the PropertyBuilder if we're
10220 implementing an interface indexer and this is neither an explicit
10221 interface implementation nor do the IndexerName match the one in
10224 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
10225 If a method is defined here, then we always need to create a proxy
10226 for it. This is used when implementing interface indexers.
10227 (Pending.IsInterfaceIndexer): New public method.
10228 (Pending.ImplementIndexer): New public method.
10229 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
10230 This is used when implementing interface indexers to define a proxy
10232 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
10233 define a proxy if necessary.
10235 * interface.cs (Interface.IndexerName): New public variable.
10236 (Interface.PopulateIndexer): Set the IndexerName.
10237 (Interface.DefineIndexers): New private method. Populate all the
10238 indexers and make sure their IndexerNames match.
10240 * typemanager.cs (IndexerPropertyName): Added support for interface
10243 2002-07-22 Martin Baulig <martin@gnome.org>
10245 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
10246 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
10247 ret if HasReturnLabel.
10248 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
10251 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
10252 and set the ec.LoopBeginTryCatchLevel.
10253 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
10254 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
10255 the current ec.TryCatchLevel, the branch goes out of an exception
10256 block. In this case, we need to use Leave and not Br.
10258 2002-07-22 Martin Baulig <martin@gnome.org>
10260 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
10261 block unless the block does not always return or it is contained in
10262 another try { ... } catch { ... } block. Fixes bug #26506.
10263 Added verify-1.cs to the test suite.
10265 2002-07-22 Martin Baulig <martin@gnome.org>
10267 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
10268 then we do not always return. Fixes bug #24985.
10270 2002-07-22 Martin Baulig <martin@gnome.org>
10272 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
10273 lookup on a per-class level; ie. walk up the class hierarchy until we
10274 found at least one applicable method, then choose the best among them.
10275 Fixes bug #24463 and test-29.cs.
10277 2002-07-22 Martin Baulig <martin@gnome.org>
10279 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
10280 return types of the methods. The return type is not part of the
10281 signature and we must not check it to make the `new' modifier work.
10282 Fixes bug #27999, also added test-147.cs.
10283 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
10285 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
10286 on the method's return type.
10288 2002-07-21 Martin Baulig <martin@gnome.org>
10290 * assign.cs: Make this work if the rightmost source is a constant and
10291 we need to do an implicit type conversion. Also adding a few more tests
10292 to test-38.cs which should have caught this.
10294 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
10295 target in the makefile for this. The makefile.gnu is primarily intended
10296 for end-users who don't want to debug the compiler.
10298 2002-07-21 Martin Baulig <martin@gnome.org>
10300 * assign.cs: Improved the Assign class so it can now handle embedded
10301 assignments (X = Y = Z = something). As a side-effect this'll now also
10302 consume less local variables. test-38.cs now passes with MCS, added
10303 a few new test cases to that test.
10305 2002-07-20 Martin Baulig <martin@gnome.org>
10307 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
10308 instructions. Fixes bug #27977, also added test-146.cs.
10310 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10312 * cs-tokenizer.cs: fixed getHex ().
10314 2002-07-19 Martin Baulig <martin@gnome.org>
10316 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
10317 not Type.GetType() to lookup the array type. This is needed when
10318 we're constructing an array of a user-defined type.
10319 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
10320 single-dimensional arrays, but also for single-dimensial arrays of
10323 2002-07-19 Martin Baulig <martin@gnome.org>
10325 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
10326 this function is called, it's not allowed to share LocalBuilders
10327 among ILGenerators.
10329 2002-07-19 Martin Baulig <martin@gnome.org>
10331 * expression.cs (Argument.Resolve): Report an error 118 when trying
10332 to pass a type as argument.
10334 2002-07-18 Martin Baulig <martin@gnome.org>
10336 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
10337 Conv_R_Un for the signed `long' type.
10339 2002-07-15 Miguel de Icaza <miguel@ximian.com>
10341 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
10342 `expr' for the temporary result, as that will fail if we do
10343 multiple resolves on the same expression.
10345 2002-07-05 Miguel de Icaza <miguel@ximian.com>
10347 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
10348 ec.TypeContainer for looking up aliases.
10350 * class.cs (TypeContainer): Remove LookupAlias from here.
10352 * decl.cs (DeclSpace); Move here.
10354 2002-07-01 Miguel de Icaza <miguel@ximian.com>
10356 * class.cs (FindMembers): Only call filter if the constructor
10357 bulider is not null.
10359 Also handle delegates in `NestedTypes' now. Now we will perform
10360 type lookups using the standard resolution process. This also
10363 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
10364 This uses Expressions (the limited kind that can be parsed by the
10365 tree) instead of strings.
10367 * expression.cs (ComposedCast.ToString): Implement, used to flag
10368 errors since now we have to render expressions.
10370 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
10373 * ecore.cs (SimpleName.ToString): ditto.
10375 * cs-parser.jay: Instead of using strings to assemble types, use
10376 Expressions to assemble the type (using SimpleName, ComposedCast,
10377 MemberAccess). This should fix the type lookups in declarations,
10378 because we were using a different code path for this.
10380 * statement.cs (Block.Resolve): Continue processing statements
10381 even when there is an error.
10383 2002-07-17 Miguel de Icaza <miguel@ximian.com>
10385 * class.cs (Event.Define): Also remove the `remove' method from
10386 the list of pending items.
10388 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
10389 generate more compact code.
10391 2002-07-17 Martin Baulig <martin@gnome.org>
10393 * const.cs (Const.LookupConstantValue): Add support for constant
10394 `unchecked' and `checked' expressions.
10395 Also adding test case test-140.cs for this.
10397 2002-07-17 Martin Baulig <martin@gnome.org>
10399 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
10400 check whether mi.ReturnType implements the IEnumerator interface; the
10401 `==' and the IsAssignableFrom() will fail in this situation.
10403 2002-07-16 Ravi Pratap <ravi@ximian.com>
10405 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
10408 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10410 * expression.cs: fixed bug #27811.
10412 2002-07-14 Miguel de Icaza <miguel@ximian.com>
10414 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
10415 Molaro: when we are a ref, the value already contains a pointer
10416 value, do not take the address of it.
10418 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10419 * removed mb-parser.jay and mb-tokenizer.cs
10421 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10423 * expression.cs: check against the building corlib void type.
10425 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
10427 * ecore.cs: fix for valuetype static readonly fields: when
10428 initializing them, we need their address, not the address of a copy.
10430 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
10432 * typemanager.cs: register also enum_type in corlib.
10434 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10436 * class.cs: allow calling this (but not base) initializers in structs.
10438 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
10440 * ecore.cs: make sure we compare against the building base types
10443 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
10445 * typemanager.cs: fix TypeToCoreType() to handle void and object
10446 (corlib gets no more typerefs after this change).
10448 2002-07-12 Miguel de Icaza <miguel@ximian.com>
10450 * expression.cs (ArrayCreation.EmitArrayArguments): use
10451 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
10453 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
10454 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
10455 array indexes, the runtime actually forbids them.
10457 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
10458 for array arguments here.
10460 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
10461 instead of the default for ValueTypes.
10463 (New.DoEmit): Use IsValueType instead of
10464 IsSubclassOf (value_type)
10465 (New.DoResolve): ditto.
10466 (Invocation.EmitCall): ditto.
10468 * assign.cs (Assign): ditto.
10470 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
10471 Statements *are* currently doing part of their resolution during
10474 Expressions do always resolve during resolve, but statements are
10475 only required to propagate resolution to their children.
10477 2002-07-11 Miguel de Icaza <miguel@ximian.com>
10479 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
10481 (LoadAssembly): Do not add the dll if it is already specified
10483 (MainDriver): Add the System directory to the link path at the end,
10484 after all the other -L arguments.
10486 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
10487 wrong opcode for loading bytes and bools (ldelem.i1 instead of
10488 ldelem.u1) and using the opposite for sbytes.
10490 This fixes Digger, and we can finally run it.
10492 * driver.cs (UnixParseOption): Move the option parsing here.
10493 (CSCParseOption): Implement CSC-like parsing of options.
10495 We now support both modes of operation, the old Unix way, and the
10496 new CSC-like way. This should help those who wanted to make cross
10497 platform makefiles.
10499 The only thing broken is that /r:, /reference: and /lib: are not
10500 implemented, because I want to make those have the same semantics
10501 as the CSC compiler has, and kill once and for all the confussion
10502 around this. Will be doing this tomorrow.
10504 * statement.cs (Unsafe.Resolve): The state is checked during
10505 resolve, not emit, so we have to set the flags for IsUnsfe here.
10507 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10509 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
10510 not catch the Error_ObjectRefRequired in SimpleName (as it is
10511 possible to have a class/instance variable name that later gets
10512 deambiguated), we have to check this here.
10514 2002-07-10 Ravi Pratap <ravi@ximian.com>
10516 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
10517 make static and put into Expression.
10519 (Event.Define): Register the private field of the event with the
10520 TypeManager so that GetFieldFromEvent can get at it.
10522 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
10523 keep track of the private field associated with an event which
10526 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
10529 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
10531 2002-07-10 Miguel de Icaza <miguel@ximian.com>
10533 * expression.cs (Binary.EmitBranchable): this routine emits the
10534 Binary expression in a branchable context. This basically means:
10535 we need to branch somewhere, not just get the value on the stack.
10537 This works together with Statement.EmitBoolExpression.
10539 * statement.cs (Statement.EmitBoolExpression): Use
10542 2002-07-09 Miguel de Icaza <miguel@ximian.com>
10544 * statement.cs (For): Reduce the number of jumps in loops.
10546 (For): Implement loop inversion for the For statement.
10548 (Break): We can be breaking out of a Try/Catch controlled section
10549 (foreach might have an implicit try/catch clause), so we need to
10550 use Leave instead of Br.
10552 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
10553 now). If the instace expression supports IMemoryLocation, we use
10554 the AddressOf method from the IMemoryLocation to extract the
10555 address instead of emitting the instance.
10557 This showed up with `This', as we were emitting the instance
10558 always (Emit) instead of the Address of This. Particularly
10559 interesting when This is a value type, as we dont want the Emit
10560 effect (which was to load the object).
10562 2002-07-08 Miguel de Icaza <miguel@ximian.com>
10564 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
10566 * statement.cs (Checked): Set the CheckedState during the resolve
10567 process too, as the ConvCast operations track the checked state on
10568 the resolve process, and not emit.
10570 * cs-parser.jay (namespace_member_declaration): Flag that we have
10571 found a declaration when we do. This is used to flag error 1529
10573 * driver.cs: Report ok when we display the help only.
10575 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
10577 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
10579 2002-07-04 Miguel de Icaza <miguel@ximian.com>
10581 * cs-tokenizer.cs (define): We also have to track locally the
10582 defines. AllDefines is just used for the Conditional Attribute,
10583 but we also need the local defines for the current source code.
10585 2002-07-03 Miguel de Icaza <miguel@ximian.com>
10587 * statement.cs (While, For, Do): These loops can exit through a
10588 Break statement, use this information to tell whether the
10589 statement is the last piece of code.
10591 (Break): Flag that we break.
10593 * codegen.cs (EmitContexts): New `Breaks' state variable.
10595 2002-07-03 Martin Baulig <martin@gnome.org>
10597 * class.cs (TypeContainer.MethodModifiersValid): Allow override
10598 modifiers in method declarations in structs. Otherwise, you won't
10599 be able to override things like Object.Equals().
10601 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10603 * class.cs (Method, Property, Indexer): Do not allow the public
10604 modifier to be used in explicit interface implementations.
10606 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
10607 override modifiers in method declarations in structs
10609 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
10611 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
10612 integer or real overflow, report an error
10614 2002-07-02 Martin Baulig <martin@gnome.org>
10616 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
10617 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
10618 to tell the runtime about our newly created System.Object and
10619 System.ValueType types.
10621 2002-07-02 Miguel de Icaza <miguel@ximian.com>
10623 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
10624 struct instead of Ldarg/Starg.
10626 2002-07-02 Martin Baulig <martin@gnome.org>
10628 * expression.cs (Indirection.Indirection): Call
10629 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
10631 2002-07-02 Martin Baulig <martin@gnome.org>
10633 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
10634 ValueType, call TypeManager.TypeToCoreType() on it.
10635 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
10636 the OpCodes.Newarr argument.
10638 2002-07-02 Martin Baulig <martin@gnome.org>
10640 * expression.cs (Invocation.EmitCall): When compiling corlib,
10641 replace all calls to the system's System.Array type to calls to
10642 the newly created one.
10644 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
10645 System.Array methods.
10646 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
10647 from the system's System.Array type which must be replaced.
10649 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
10651 * typemanager.cs: load unverifiable_code_ctor so we can build
10652 corlib using the correct type. Avoid using GetTypeCode() with
10654 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
10655 TypeManager.object_type to allow building corlib.
10657 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
10659 * ecore.cs: handle System.Enum separately in LoadFromPtr().
10661 2002-07-01 Martin Baulig <martin@gnome.org>
10663 * class.cs: Make the last change actually work, we need to check
10664 whether `ifaces != null' to avoid a crash.
10666 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
10668 * class.cs: when we build structs without fields that implement
10669 interfaces, we need to add the interfaces separately, since there is
10670 no API to both set the size and add the interfaces at type creation
10673 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
10675 * expression.cs: the dimension arguments to the array constructors
10676 need to be converted if they are a long.
10678 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
10680 * class.cs: don't emit ldarg.0 if there is no parent constructor
10681 (fixes showstopper for corlib).
10683 2002-06-29 Martin Baulig <martin@gnome.org>
10685 MCS now compiles corlib on GNU/Linux :-)
10687 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
10688 ie. check for MethodImplOptions.InternalCall.
10690 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
10691 and TypeManager.attribute_type are null, so we must explicitly check
10692 whether parent is not null to find out whether it's an attribute type.
10693 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
10694 and SetBuilder, not only if the property is neither abstract nor external.
10695 This is necessary to set the MethodImplOptions on the accessor methods.
10696 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
10697 SetBuilder, see Property.Emit().
10699 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
10700 populate "System.Object", "System.ValueType" and "System.Attribute" since
10701 they've already been populated from BootCorlib_PopulateCoreTypes().
10703 2002-06-29 Martin Baulig <martin@gnome.org>
10705 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
10706 is the NullLiteral, we also need to make sure that target_type is not
10709 2002-06-29 Martin Baulig <martin@gnome.org>
10711 * rootcontext.cs (RootContext.ResolveCore): We must initialize
10712 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
10713 before calling BootstrapCorlib_ResolveDelegate ().
10715 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
10717 * statement.cs: fixed build-breaker. All tests passed ok.
10719 2002-06-27 Martin Baulig <martin@gnome.org>
10721 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
10722 for System.Decimal when compiling corlib.
10724 2002-06-27 Martin Baulig <martin@gnome.org>
10726 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
10727 switch blocks which contain nothing but a default clause.
10729 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
10731 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
10733 2002-06-27 Martin Baulig <martin@gnome.org>
10735 * ecore.cs (PropertyExpr.PropertyExpr): Call
10736 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
10738 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
10739 is already a TypeBuilder.
10741 2002-06-27 Martin Baulig <martin@gnome.org>
10743 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
10744 `target_type == TypeManager.array_type', not IsAssignableFrom() in
10745 the "from an array-type to System.Array" case. This makes it work
10746 when compiling corlib.
10748 2002-06-27 Martin Baulig <martin@gnome.org>
10750 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
10751 non-static PropertyExpr, set its InstanceExpression. This makes
10752 the `ICollection.Count' property work in System/Array.cs.
10754 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
10756 * driver.cs: Made error handling more consistent. Errors now
10757 tracked by Report class, so many methods which used to return int
10758 now return void. Main() now prints success/failure and
10759 errors/warnings message.
10761 Renamed '--probe' compiler argument to '--expect-error'. Removed
10762 the magic number return values (123 and 124). Now, if the
10763 expected error occurs, the compiler exits with success (exit value
10764 0). If the compilation completes without seeing that particular
10765 error, the compiler exits with failure (exit value 1). The
10766 makefile in mcs/errors has been changed to handle the new behaviour.
10768 * report.cs: Made 'expected error' number a property and renamed
10769 it from 'Probe' to 'ExpectedError'.
10771 * genericparser.cs: Removed error handling support, since it is
10772 now all done by Report class.
10774 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
10775 class, so parse() no longer returns an int.
10777 * namespace.cs: Use Report.Error instead of GenericParser.error
10779 2002-06-22 Miguel de Icaza <miguel@ximian.com>
10781 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
10782 TypeContainer.AddOperator): At the front of the list put the
10783 explicit implementations, so they get resolved/defined first.
10785 2002-06-21 Miguel de Icaza <miguel@ximian.com>
10787 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
10788 interface type is implemented by this TypeContainer. Used during
10789 explicit interface implementation.
10791 (Property.Define, Indexer.Define, Method.Define): Validate that
10792 the given interface in the explicit implementation is one of the
10793 base classes for the containing type.
10795 Also if we are explicitly implementing an interface, but there is
10796 no match in the pending implementation table, report an error.
10798 (Property.Define): Only define the property if we are
10799 not explicitly implementing a property from an interface. Use the
10800 correct name also for those properties (the same CSC uses,
10801 although that is really not needed).
10803 (Property.Emit): Do not emit attributes for explicitly implemented
10804 properties, as there is no TypeBuilder.
10806 (Indexer.Emit): ditto.
10808 Hiding then means that we do not really *implement* a pending
10809 implementation, which makes code fail.
10811 2002-06-22 Martin Baulig <martin@gnome.org>
10813 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
10814 the return value of Object.GetType(). [FIXME: we need to do this whenever
10815 we get a type back from the reflection library].
10817 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
10819 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
10821 2002-06-20 Miguel de Icaza <miguel@ximian.com>
10823 * attribute.cs: Return null if we can not look up the type.
10825 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
10826 the interface types found.
10828 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
10829 interface types found.
10831 * typemanager.cs (GetInterfaces): Make this routine returns alll
10832 the interfaces and work around the lame differences between
10833 System.Type and System.Reflection.Emit.TypeBuilder in the results
10834 result for GetInterfaces.
10836 (ExpandInterfaces): Given an array of interface types, expand and
10837 eliminate repeated ocurrences of an interface. This expands in
10838 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
10841 2002-06-21 Martin Baulig <martin@gnome.org>
10843 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
10846 2002-06-21 Martin Baulig <martin@gnome.org>
10848 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
10849 and called with one of the core types, return the corresponding typebuilder for
10852 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
10855 2002-06-21 Martin Baulig <martin@gnome.org>
10857 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
10858 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
10859 (Expression.ConvertReferenceExplicit): Likewise.
10861 * expression.cs (ElementAccess.DoResolve): Likewise.
10862 (ElementAccess.DoResolveLValue): Likewise.
10864 2002-06-10 Martin Baulig <martin@gnome.org>
10866 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
10867 add the "value" parameter to the parameter list.
10869 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
10872 2002-06-19 Miguel de Icaza <miguel@ximian.com>
10874 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
10875 the argument to an int, uint, long or ulong, per the spec. Also
10876 catch negative constants in array creation.
10878 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
10880 * class.cs: do not allow the same interface to appear twice in
10881 the definition list.
10883 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
10885 * ecore.cs: don't use ldlen with System.Array.
10887 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
10889 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
10891 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
10893 * modifiers.cs: produce correct field attributes for protected
10894 internal. Easy fix so miguel can work on ther harder stuff:-)
10896 2002-06-18 Miguel de Icaza <miguel@ximian.com>
10898 * pending.cs: New file. Move the code from class.cs here.
10899 Support clearning the pending flag for all methods (when not doing
10900 explicit interface implementation).
10902 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
10904 * rootcontext.cs: added a couple more types needed to bootstrap.
10906 2002-06-17 Miguel de Icaza <miguel@ximian.com>
10908 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
10909 constructor in the type, instead of any constructor in the type
10910 hierarchy. Thanks to Paolo for finding this bug (it showed up as
10911 a bug in the Mono runtime when applying the params attribute).
10913 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
10914 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
10916 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
10918 * expression.cs (Unary.ResolveOperator): Use TypeManager
10919 to resolve the type.
10921 2002-06-13 Ravi Pratap <ravi@ximian.com>
10923 * cs-parser.jay (enum_member_declaration): Pass in the attributes
10926 * enum.cs (AddEnumMember): Add support to store the attributes associated
10927 with each member too.
10929 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
10930 field builders too - this takes care of the enum member case.
10932 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
10934 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
10935 address-of operator on both value types and pointers.
10937 2002-06-10 Martin Baulig <martin@gnome.org>
10939 * interface.cs (Interface.PopulateIndexer): Add the indexer's
10940 PropertyBuilder to the `property_builders' list.
10942 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
10943 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
10944 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
10945 find any indexers which are inherited from an interface.
10947 2002-06-09 Martin Baulig <martin@gnome.org>
10949 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
10950 the same type as the constant if necessary. There's also a test-130.cs
10953 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
10955 * typemanager.cs (TypeManager.ChangeType): Previously known as
10956 Enum.ChangeEnumType().
10958 2002-06-09 Martin Baulig <martin@gnome.org>
10960 * expression.cs (Cast.TryReduce): Added support for consts.
10962 2002-06-08 Ravi Pratap <ravi@ximian.com>
10964 * class.cs (Accessor): Hold attributes information so we can pass
10967 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
10968 Modify to pass in attributes attached to the methods.
10970 (add_accessor_declaration, remove_accessor_declaration): Ditto.
10972 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
10973 to handle the Accessor kind :-)
10975 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
10977 2002-06-08 Martin Baulig <martin@gnome.org>
10979 * expression.cs (Unary.TryReduceNegative): Added support for
10982 2002-06-08 Martin Baulig <martin@gnome.org>
10984 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
10985 name can't be found in the `defined_names' - the caller will do a
10986 MemberLookup in this case and thus find methods in System.Enum
10987 such as Enum.IsDefined().
10989 2002-06-08 Martin Baulig <martin@gnome.org>
10991 * enum.cs (Enum.ChangeEnumType): This is a custom version of
10992 Convert.ChangeType() which works with TypeBuilder created types.
10993 (Enum.LookupEnumValue, Enum.Define): Use it here.
10995 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
10996 `TypeBuilder.BaseType != null' check.
10997 (TypeContainer.FindMembers): Only lookup parent members if we
10998 actually have a parent.
10999 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
11000 (ConstructorInitializer.Resolve): Likewise.
11002 * interface.cs (Interface.FindMembers): Added
11003 `TypeBuilder.BaseType != null' check.
11005 * rootcontext.cs (RootContext.ResolveCore): Added
11006 "System.Runtime.CompilerServices.IndexerNameAttribute" to
11007 classes_second_stage.
11009 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
11010 debug_type and trace_type when compiling with --nostdlib.
11012 2002-06-07 Martin Baulig <martin@gnome.org>
11014 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
11015 (AddField): Set it to true when adding a non-static field.
11016 (DefineType): Use `have_nonstatic_fields' to find out whether we
11017 have non-static fields, not `Fields != null'.
11019 2002-06-02 Miguel de Icaza <miguel@ximian.com>
11021 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
11022 dereferencing a null on the static-field code path)
11024 2002-05-30 Martin Baulig <martin@gnome.org>
11026 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
11027 to take command line arguments. Use reflection to call the new
11028 custom `Initialize' function on the symbol writer and pass it the
11029 command line arguments.
11031 * driver.cs (--debug-args): New command line argument to pass command
11032 line arguments to the symbol writer.
11034 2002-05-28 Miguel de Icaza <miguel@ximian.com>
11036 * assign.cs (DoResolve): Forgot to do the implicit conversion to
11037 the target type for indexers and properties. Thanks to Joe for
11040 2002-05-27 Miguel de Icaza <miguel@ximian.com>
11042 * typemanager.cs (MethodFlags): returns the method flags
11043 (Obsolete/ShouldIgnore) that control warning emission and whether
11044 the invocation should be made, or ignored.
11046 * expression.cs (Invocation.Emit): Remove previous hack, we should
11047 not do this on matching a base type, we should do this based on an attribute
11049 Only emit calls to System.Diagnostics.Debug and
11050 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
11051 on the command line.
11053 * rootcontext.cs: Global settings for tracing and debugging.
11055 * cs-tokenizer.cs (define): New utility function to track
11056 defines. Set the global settings for TRACE and DEBUG if found.
11058 2002-05-25 Ravi Pratap <ravi@ximian.com>
11060 * interface.cs (Populate*): Pass in the TypeContainer as well as
11061 the DeclSpace as parameters so that we can create EmitContexts and
11062 then use that to apply attributes etc.
11064 (PopulateMethod, PopulateEvent, PopulateProperty)
11065 (PopulateIndexer): Apply attributes everywhere.
11067 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
11070 (ApplyAttributes): Update accordingly.
11072 We now apply interface attributes for all members too.
11074 2002-05-26 Miguel de Icaza <miguel@ximian.com>
11076 * class.cs (Indexer.Define); Correctly check if we are explicit
11077 implementation (instead of checking the Name for a ".", we
11078 directly look up if the InterfaceType was specified).
11080 Delay the creation of the PropertyBuilder.
11082 Only create the PropertyBuilder if we are not an explicit
11083 interface implementation. This means that explicit interface
11084 implementation members do not participate in regular function
11085 lookups, and hence fixes another major ambiguity problem in
11086 overload resolution (that was the visible effect).
11088 (DefineMethod): Return whether we are doing an interface
11091 * typemanager.cs: Temporary hack until we get attributes in
11092 interfaces (Ravi is working on that) and we get IndexerName
11093 support in interfaces.
11095 * interface.cs: Register the indexers as properties.
11097 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
11098 warning, I have verified that this is a bug in the .NET runtime
11099 (JavaScript suffers of the same problem).
11101 * typemanager.cs (MemberLookup): When looking up members for
11102 interfaces, the parent of an interface is the implicit
11103 System.Object (so we succeed in searches of Object methods in an
11104 interface method invocation. Example: IEnumerable x; x.ToString
11107 2002-05-25 Miguel de Icaza <miguel@ximian.com>
11109 * class.cs (Event): Events should also register if they do
11110 implement the methods that an interface requires.
11112 * typemanager.cs (MemberLookup); use the new GetInterfaces
11115 (GetInterfaces): The code used to lookup interfaces for a type is
11116 used in more than one place, factor it here.
11118 * driver.cs: Track the errors at the bottom of the file, we kept
11121 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
11122 instance if the method we are calling is static!
11124 2002-05-24 Miguel de Icaza <miguel@ximian.com>
11126 * attribute.cs (ApplyAttributes): Make this function filter out
11127 the IndexerName attribute (as that attribute in reality is never
11128 applied) and return the string constant for the IndexerName
11131 * class.cs (TypeContainer.Emit): Validate that all the indexers
11132 have the same IndexerName attribute, and if so, set the
11133 DefaultName attribute on the class.
11135 * typemanager.cs: The return value might contain other stuff (not
11136 only methods). For instance, consider a method with an "Item"
11137 property and an Item method.
11139 * class.cs: If there is a problem with the parameter types,
11142 2002-05-24 Ravi Pratap <ravi@ximian.com>
11144 * ecore.cs (ImplicitConversionExists): Wrapper function which also
11145 looks at user defined conversion after making a call to
11146 StandardConversionExists - we need this for overload resolution.
11148 * expression.cs : Update accordingly the various method calls.
11150 This fixes 2 bugs filed against implicit user defined conversions
11152 2002-05-22 Miguel de Icaza <miguel@ximian.com>
11154 * statement.cs: Track the result of the assignment.
11156 2002-05-21 Miguel de Icaza <miguel@ximian.com>
11158 * expression.cs (MemberAccess): Improved error reporting for
11159 inaccessible members.
11161 2002-05-22 Martin Baulig <martin@gnome.org>
11163 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
11164 itself with debugging support.
11166 2002-05-22 Martin Baulig <martin@gnome.org>
11168 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
11169 Removed, this isn't needed anymore.
11171 2002-05-20 Martin Baulig <martin@gnome.org>
11173 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
11174 be underlying type for an enum.
11176 2002-05-20 Miguel de Icaza <miguel@ximian.com>
11178 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
11179 that splits out the loading of just the core types.
11181 * rootcontext.cs (ResolveCore): Split the struct resolution in
11182 two, so we can load the enumeration underlying types before any
11185 * expression.cs (Is): Bandaid until we fix properly Switch (see
11186 bug #24985 for details).
11188 * typemanager.cs (ImplementsInterface): The hashtable will contain
11189 a null if there are no interfaces implemented.
11191 2002-05-18 Miguel de Icaza <miguel@ximian.com>
11193 * cs-parser.jay (indexer_declarator): It is fine to have array
11196 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11198 * typemanager.cs: (RegisterBuilder): New function used to register
11199 TypeBuilders that implement interfaces. Since
11200 TypeBuilder.GetInterfaces (as usual) does not work with lame
11202 (AddUserType): register interfaces.
11204 (ImplementsInterface): Use the builder_to_ifaces hash if we are
11205 dealing with TypeBuilder. Also, arrays are showing up as
11206 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
11207 methods can not be invoked on them!
11209 * ecore.cs (ExplicitReferenceConversionExists): Made public.
11210 (ImplicitReferenceConversionExists): Split out from
11211 StandardConversionExists.
11213 * expression.cs (As): We were only implementing one of the three
11214 cases for the as operator. We now implement them all.
11215 (Is): Implement the various other cases for Is as well.
11217 * typemanager.cs (CACHE): New define used to control if we want or
11218 not the FindMembers cache. Seems to have a negative impact on
11219 performance currently
11221 (MemberLookup): Nested types have full acess to
11222 enclosing type members
11224 Remove code that coped with instance/static returns for events, we
11225 now catch this in RealFindMembers.
11227 (RealFindMembers): only perform static lookup if the instance
11228 lookup did not return a type or an event.
11230 2002-05-17 Miguel de Icaza <miguel@ximian.com>
11232 * assign.cs (CompoundAssign): We pass more semantic information
11233 now to Compound Assignments than we did before: now we have all
11234 the information at hand, and now we resolve the target *before* we
11235 do the expression expansion, which allows the "CacheValue" method
11236 to have the effect we intended (before, a [x] += 1 would generate
11237 two differen ArrayAccess expressions from the ElementAccess,
11238 during the resolution process).
11240 (CompoundAssign.DoResolve): Resolve target and original_source here.
11242 2002-05-16 Miguel de Icaza <miguel@ximian.com>
11244 * expression.cs (ArrayAccess): dropped debugging information.
11246 * typemanager.cs: Small bug fix: I was always returning i_members,
11247 instead of one of i_members or s_members (depending on which had
11250 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
11251 method is invoked before any code generation takes place, and it
11252 is a mechanism to inform that the expression will be invoked more
11253 than once, and that the method should use temporary values to
11254 avoid having side effects
11256 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
11258 * ecore.cs (Expression.CacheTemporaries): Provide empty default
11261 * expression.cs (Indirection, ArrayAccess): Add support for
11262 CacheTemporaries in these two bad boys.
11264 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
11265 ldobj or ldind_ref.
11266 (StoreFromPtr): Handle stobj as well.
11268 * expression.cs (UnaryMutator): Share more code.
11270 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
11271 down: I was not tracking the Filter function as well, which
11272 was affecting the results of the cache.
11274 2002-05-15 Miguel de Icaza <miguel@ximian.com>
11276 * attribute.cs: Remove the hack to handle the CharSet property on
11279 2002-05-14 Miguel de Icaza <miguel@ximian.com>
11281 * attribute.cs (DoResolve): More uglyness, we now only try to
11282 resolve the attribute partially, to extract the CharSet
11283 information (only if we are a StructLayout attribute). Otherwise
11285 (GetExtraTypeInfo): Add some code to conditionally kill in the
11286 future this. I am more and more convinced that the .NET
11287 framework has special code to handle the attribute setting on
11290 * expression.cs (IsParamsMethodApplicable): Revert my previous
11291 foreach change here, it was wrong.
11293 2002-05-13 Miguel de Icaza <miguel@ximian.com>
11295 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
11296 (pp_expr): do not abort on unknown input, just return.
11297 (eval): abort if there are pending chars.
11299 * attribute.cs (Attribute.Resolve): Positional parameters are
11300 optional. Deal with that case.
11302 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
11303 the Ansi/Unicode/Auto information for the type.
11305 (TypeContainer.DefineType): instantiate the EmitContext here, as
11306 we will be using it during the type definition (to resolve
11307 attributes) and during the emit phase.
11309 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
11310 to pull type information out of the attributes
11312 (Attribute.Resolve): track the constructor builder, and allow for
11313 multiple invocations (structs and classes will use this).
11315 * ecore.cs (MemberLookupFinal): new version with all the
11316 parameters customizable.
11318 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
11319 constructors. Return if the result value is null (as the error
11320 would have been flagged already by MemberLookupFinal)
11322 Do not allow instances of abstract classes or interfaces to be
11325 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
11326 We have to compare the assembly property here when dealing with
11327 FamANDAssem and Assembly access modifiers, because we might be
11328 creating an assembly from *modules* (that means that we are not
11329 getting TypeBuilders for types defined in other modules that are
11330 part of this assembly).
11332 (Method.Emit): If the method is marked abstract and has a body,
11335 (TypeContainer.DefineMembers): If both the defined member and the
11336 parent name match are methods, then do not emit any warnings: let
11337 the Method.Define routine take care of flagging warnings. But if
11338 there is a mismatch (method overrides something else, or method is
11339 overriwritten by something, then emit warning).
11341 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
11342 set to null, this means `do not check for the return type on the
11345 (Method.Define): set the return type for the method signature to
11346 null, so that we get methods with the same name and parameters and
11347 different return types. This is used to flag warning 114 (you are
11348 hiding a method, and you probably want to use the new/override
11351 * typemanager.cs (MemberLookup): Implemented proper access
11352 control, closing a long standing set of bug reports. The problem
11353 was that the Framework only has two bits: Public and NonPublic,
11354 and NonPublic includes private and protected methods, but we need
11355 to enforce the FamANDAssem, FamOrAssem and Family.
11357 2002-05-11 Miguel de Icaza <miguel@ximian.com>
11359 * statement.cs (GotoCase): Return true: Ammounts to giving up
11360 knowledge on whether we return or not, and letting the other case
11361 be responsible for it.
11363 2002-05-10 Miguel de Icaza <miguel@ximian.com>
11365 * driver.cs: Do not load directories for each file processed, only
11366 do it if there is a pattern.
11368 * ecore.cs: Report readonly assigns here as well, as we might have
11369 been resolved only by MemberAccess.
11371 (SimpleName.SimpleNameResolve): Also be useful for LValue
11372 resolution. We need this to propagate assign to local readonly variables
11374 * typemanager.cs: Use a ptrhashtable for the criteria, because we
11375 do not want to reuse potential criteria memory.
11377 * class.cs (MyEventBuilder): Set reflected_type;
11379 * ecore.cs (Constantify): Added support for constifying bools.
11381 (RootContext.LookupType): Added a cache for values looked up in
11382 the declaration space.
11384 * typemanager.cs (FindMembers): Now is a front-end to
11385 RealFindMembers, and provides a two-level hashtable-based cache to
11388 15% performance improvement: from 22.5 to 19.2 seconds.
11390 * expression.cs (IsParamsMethodApplicable): use foreach.
11391 (Invocation.DoResolve): ditto.
11392 (New.DoResolve): ditto.
11393 (ArrayCreation.DoResolve): ditto.
11395 * ecore.cs (FindMostEncompassingType): use foreach.
11397 * delegate.cs (NewDelegate.DoResolve): Use foreach
11399 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
11400 (RemoveMethods): use foreach.
11402 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
11403 nested foreach statements instead of for, and also break out of
11404 the inner loop once a match is found.
11406 (Invocation.OverloadResolve): Use foreach, simplify the code.
11408 2002-05-08 Miguel de Icaza <miguel@ximian.com>
11410 * cfold.cs (BinaryFold): During an enumeration evaluation context,
11411 we actually unwrap the expression to allow for extra information
11414 * expression.cs: Use Shr_Un on unsigned operations.
11416 2002-05-08 Ravi Pratap <ravi@ximian.com>
11418 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
11419 applicable operators was not being considered correctly. This closes
11420 the bug Miguel reported.
11422 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
11424 * attribute.cs: check that the type derives from System.Attribute
11425 and report the correct error in that case (moved the duplicate code to
11426 its own method, too).
11428 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
11430 * attribute.cs: lookup attribute type name as the spec says: first the
11431 bare attribute name and then name + "Attribute" (nant compiles with
11432 mcs after this fix).
11434 2002-05-07 Miguel de Icaza <miguel@ximian.com>
11436 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
11437 Because of the way we parse things, we should try to see if a
11438 UIntConstant can fit in an integer.
11440 2002-05-07 Ravi Pratap <ravi@ximian.com>
11442 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
11443 when we are in an explicit context.
11445 (ConvertReferenceExplicit): When converting from Iface type S to Class
11446 T make sure the rules are implemented as an OR.
11448 * parameter.cs (ParameterType): Make it a property for now although the
11449 purpose really isn't anything immediate.
11451 * expression.cs (Is*Applicable): Do better checking on the parameter type
11452 of a ref/out parameter. The ones from the system assemblies are already
11453 marked with the correct type so we don't need to do any correction.
11455 * ecore.cs (StandardConversionExists): Conversion from Interface types to
11456 the object type is standard too so include that.
11458 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11460 * ecore.cs (StandardConversionExists): Augment with missing code:
11461 deal with IntConstant, LongConstants and Enumerations.
11463 * assign.cs: Report the error, instead of failing silently
11465 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
11466 typecontainer that they are declared, because the
11467 typecontainer/namespace will have the list of using clauses that
11468 need to be applied.
11470 Assembly Attributes were escaping the normal registration
11473 (EmitCode): Apply attributes within an EmitContext that represents
11474 the container they were declared on.
11476 * cs-parser.jay: Track bases for structs. How did I get this wrong?
11478 2002-05-06 Ravi Pratap <ravi@ximian.com>
11480 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
11481 Revamp completely - make much cleaner as we now operate only
11484 (FindMostSpecificSource, FindMostSpecificTarget): New methods
11485 to implement the logic detailed in the spec more correctly.
11487 (UserDefinedConversion): Update accordingly.
11489 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11491 * statement.cs: Return flow analysis information up.
11493 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
11496 (token): Do not consume an extra character before calling
11499 2002-05-06 Piers Haken <piersh@friskit.com>
11501 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
11503 2002-05-06 Miguel de Icaza <miguel@ximian.com>
11505 * class.cs (Constructor.Emit): Set the IsStatic flag in the
11506 EmitContext during the instance constructor initializer
11507 resolution, to stop access to instance variables.
11509 This is mandated by the spec, last paragraph of the `constructor
11510 initializers' section.
11512 2002-05-05 Miguel de Icaza <miguel@ximian.com>
11514 * cs-parser.jay, class.cs (Accessor): new class used to represent
11515 an accessor (get or set). In the past we used `null' to represent
11516 a missing accessor. But this is ambiguous because there was no
11517 way to tell in abstract indexers/properties if one of them was
11520 Now there is a way of addressing that.
11522 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
11523 instead of FindMembers.
11525 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
11526 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
11528 * attribute.cs: Treat indexers and properties as the same in terms
11529 of applying attributes
11531 * ecore.cs (FindMostEncompassedType): Use statically initialized
11532 EmptyExpressions()s like we do elsewhere to avoid creating useless
11533 objects (and we take this out of the tight loop).
11535 (GetConversionOperators): Move the code to extract the actual
11536 operators to a separate routine to clean things up.
11538 2002-05-04 Miguel de Icaza <miguel@ximian.com>
11540 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
11541 events are always registered FieldBuilders.
11543 * class.cs (FieldBase): New class shared by Fields
11545 * delegate.cs: If we are a toplevel delegate, use our full name.
11546 If we are a nested delegate, then only use our tail name.
11548 2002-05-02 Ravi Pratap <ravi@ximian.com>
11550 * expression.cs (IsApplicable): Ensure that we add the "&" to
11551 ref/out types before comparing it with the type of the argument.
11553 (IsParamsMethodApplicable): Ditto.
11555 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
11558 * delegate.cs : Handle the case when we have more than one applicable
11559 method. Flag an error only when we finish checking all.
11561 2002-05-02 Miguel de Icaza <miguel@ximian.com>
11563 * expression.cs: Add support for boolean static initializers.
11565 2002-05-01 Miguel de Icaza <miguel@ximian.com>
11567 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
11569 * parameter.cs (ComputeParameterTypes,
11570 ComputeAndDefineParameterTypes): Better error handling: now we
11571 clear the `types' cache if we fail during any of the type lookups.
11572 We also return the status code correctly to our caller
11574 * delegate.cs: If we fail to define a delegate, abort the extra
11577 * expression.cs (Binary.ResolveOperator): for
11578 operator==(object,object) and operator !=(object, object) we also
11579 have to verify that there is an implicit conversion from one to
11582 (ArrayAccess.DoResolve): Array Access can operate on
11585 2002-04-30 Miguel de Icaza <miguel@ximian.com>
11587 * assign.cs (CompoundAssign): A new class used as a "flag" that
11588 the assignment actually is happening as part of a compound
11589 assignment operator.
11591 During compound assignment, a few new rules exist to enable things
11598 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
11599 to the type of x) if y is implicitly convertible to the type of x,
11600 and the operator is a builtin operator and the return type of the
11601 operator is explicitly convertible to the type of x.
11603 * rootcontext.cs: Reset warning level to 2. 4 catches various
11604 "interesting" features in mcs, we must clean this up at some
11605 point, but currently am trying to kill other bugs ;-)
11607 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
11608 in container classes as well.
11610 * expression.cs (Binary.ResolveOperator): Handle string case
11611 before anything else (as operator overloading does emit an error
11612 before doing anything else).
11614 This code could go away when we move to a table driven model, but
11615 i could not come up with a good plan last night.
11617 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
11619 * typemanager.cs (CSharpName): reimplementation using regex.
11620 * class.cs: added null check for fields in Emit
11621 * rootcontext.cs: set warninglevel to 4
11623 2002-04-29 Miguel de Icaza <miguel@ximian.com>
11625 * typemanager.cs (CSharpName): reimplemented with Lupus
11628 2002-04-28 Miguel de Icaza <miguel@ximian.com>
11630 * statement.cs (If): correclty implement Resolve, because we were
11631 not catching sem errors in there. The same process is needed
11633 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
11636 (Statement.Warning_DeadCodeFound): Factorize code.
11637 (While): Report dead code here too.
11639 (Statement): Added Resolve virtual method to allow
11640 for resolution split from the emit code.
11642 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11644 * statement.cs (EmitBoolExpression): No longer try to resolve the
11646 (MakeBoolean): New utility function that resolve, implicitly
11647 converts to boolean and tags the expression.
11650 (If, Do): Implement dead code elimination.
11651 (While): Implement loop inversion
11653 (Do, While, For, If): Resolve the expression prior to calling our
11656 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
11659 - added method Report28 (warning: program has more than one entry point)
11660 - added method IsEntryPoint, implements paragraph 10.1 of the spec
11661 - modified method Method.Define, the part at the end of the method
11663 * rootcontext.cs: added static public Location EntryPointLocation;
11665 * ../errors/cs0028.cs : Add test case for the above warning.
11668 - modified method CSharpName to allow arrays of primitive type to
11669 be printed nicely (e.g. instead of System.Int32[][] it now prints
11671 - added method CSharpSignature: returns the signature of a method
11672 in string format to be used in reporting errors, warnings, etc.
11674 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
11677 2002-04-26 Ravi Pratap <ravi@ximian.com>
11679 * delegate.cs (Define): Fix extremely silly bug where I was
11680 setting the type of the 'object' parameter of the BeginInvoke
11681 method to System.IAsyncResult instead of System.Object ;-)
11683 2002-04-26 Miguel de Icaza <miguel@ximian.com>
11685 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
11688 (Constructor.Emit): return if we fail to initialize the
11689 constructor. Another door closed!
11691 * expression.cs (New.DoResolve): Improve error message (from -6 to
11692 1501). Use DeclaredOnly lookup to find the exact constructor.
11694 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
11695 loop. This is useful.
11697 * cs-parser.jay: Adjust the default parameters so that destructors
11698 have the proper signature.
11700 2002-04-26 Martin Baulig <martin@gnome.org>
11702 * driver.cs (LoadAssembly): If `assembly' contains any characters
11703 which are only valid in path names and not in assembly names
11704 (currently slash, backslash and point), use Assembly.LoadFrom ()
11705 instead of Assembly.Load () on the `assembly' (before iteration
11706 over the link_paths).
11708 2002-04-26 Martin Baulig <martin@gnome.org>
11710 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
11712 2002-04-25 Miguel de Icaza <miguel@ximian.com>
11714 * class.cs (Property): use the new typemanager.MemberLookup
11716 (TypeContainer.MemberLookup): Implement using the
11717 TypeManager.MemberLookup now.
11719 * typemanager.cs: Make MemberLookup a function of the TypeManager,
11720 and return MemberInfos, so that these can be used without an
11721 EmitContext (what we had before).
11723 2002-04-24 Miguel de Icaza <miguel@ximian.com>
11725 * expression.cs: Fix the case where the argument to params if the
11726 type of the params. I omitted handling this before. Fixed
11728 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11730 * driver.cs: Call BootCorlib_PopulateCoreType
11732 * class.cs (Property.CheckBase): Check for properties only, not
11735 * interface.cs: Temporary hack: try/catch around the
11736 CustomAttributeBuilder, because I am getting an exception that I
11739 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
11740 types whose definitions are required to be there (attributes are
11741 defined before standard types).
11743 Compute definitions as we boot the various types, as they are used
11744 immediately (value_type class will need object_type, but if we do
11745 not initialize object_type, we will pass a null, which will let
11746 the runtime pick the System.Object from the existing corlib, which
11747 is not what we want).
11749 2002-04-22 Patrik Torstensson <totte@labs2.com>
11751 * cs-tokenizer.cs: fixed a number of trim() issues.
11753 2002-04-22 Ravi Pratap <ravi@ximian.com>
11755 * expression.cs (Argument.Type): Ensure that we return the correct
11756 type when we have out or ref parameters [in which case we
11759 2002-04-22 Miguel de Icaza <miguel@ximian.com>
11761 * class.cs (Property, Indexer): Allow extern modifier in there.
11763 * typemanager.cs (InitBaseTypes): Initializes object_type and
11764 value_type, since those will be used early on during the bootstrap
11765 process to compile corlib.
11767 (InitCoreTypes): Move code from here to InitBaseTypes.
11769 2002-04-21 Miguel de Icaza <miguel@ximian.com>
11771 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
11772 single-dimension arrays as using the ldlen opcode.
11774 Daniel Lewis discovered this optimization.
11776 * typemanager.cs: Add signature for System.Array::get_Length
11778 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11780 * statement.cs: report the error when the foreach does not apply to an
11781 array nor a collection.
11783 2002-04-19 Miguel de Icaza <miguel@ximian.com>
11785 * expression.cs: Add implicit conversions to the operator ~.
11787 * constant.cs (DecimalConstant.Emit): Emit decimal value.
11789 * typemanager.cs: Locate the decimal constructor.
11791 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11793 * attribute.cs: use the new property of TypeOf.
11794 * expression.cs: added 'get' property around typearg.
11796 These changes fix a build breaker reported by NickD. Is this the
11797 correct way to fix? If not, please, revert my changes and make it
11800 2002-04-17 Miguel de Icaza <miguel@ximian.com>
11802 * attribute.cs: Add support for typeof in attribute invocations.
11803 I am not sure that this is right though.
11805 2002-04-14 Duncan Mak <duncan@ximian.com>
11807 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
11808 Binary.Operator.Division case.
11810 2002-04-13 Ravi Pratap <ravi@ximian.com>
11812 * class.cs (DefineType): Ensure that we do a proper check on
11813 attribute types and also register it with the TypeManager.
11815 (TypeContainer.Targets): The default for attribute types is
11816 AttributeTargets.All.
11818 * attribute.cs (ApplyAttributes): Registering the attribute type
11819 is done elsewhere, not when we discover we have a Usage attribute.
11821 2002-04-12 Ravi Pratap <ravi@ximian.com>
11823 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
11824 and get rid of is_delegate parameter.
11826 * everywhere : update.
11828 2002-04-12 Ravi Pratap <ravi@ximian.com>
11830 * cs-parser.jay (compilation_unit): Revamp completely to use
11831 some new ideas that I got from Rhys' grammar to solve the problems
11832 with assembly level attributes.
11834 (outer_declaration): New grammar production.
11836 (attribute_sections): Add.
11838 (opt_attributes): Base on attribute_sections
11840 (namespace_declaration): Allow opt_attributes to tackle the case
11841 when we have assembly level attributes - we are clever in this
11844 * attribute.cs (ApplyAttributes): Do not worry about assembly
11845 attributes in the non-global context.
11847 * rootcontext.cs (AddGlobalAttributes): Go back to using this
11848 instead of SetGlobalAttributes.
11850 * class.cs, rootcontext.cs : Ensure we define and generate
11851 attribute types before anything else.
11853 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
11854 and flag the new error -20 for the case when the attribute type
11855 does not have valid targets specified. csc does not catch this.
11857 * ../errors/errors.txt : update for error # -20
11859 2002-04-11 Ravi Pratap <ravi@ximian.com>
11861 * support.cs (InternalParameters.ParameterModifier): Do some null
11862 checking and return sane values.
11864 * class.cs (Method.Define): If we are a PInvoke method, ensure
11865 that we are static and extern. Report error # 601
11867 * ../errors/cs0601.cs : Add test case for the above error.
11869 2002-04-07 Ravi Pratap <ravi@ximian.com>
11871 * rootcontext.cs (attribute_types): We need to keep type of
11872 all attribute types separately and emit code for them first.
11874 (RegisterAttribute) : Implement.
11876 * class.cs (DefineType): Check if the current Type is a custom
11877 attribute type and register it accordingly.
11879 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
11880 adding the first attribute twice and rename to
11882 (SetGlobalAttributes): this.
11884 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
11887 * attribute.cs (ApplyAttributes): Take an additional argument telling us
11888 if we are processing global arguments. Hmm, I am unsure of this.
11890 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
11892 * expression.cs: added static array of strings to avoid calling
11893 Enum.ToString () for Operator in Binary. Significant recover of
11896 2002-04-10 Miguel de Icaza <miguel@ximian.com>
11898 * class.cs (FindMembers): Allow the Builders of the various
11899 members to be null. If they are skip them. This only happens
11900 during the PInvoke declaration.
11902 2002-04-09 Miguel de Icaza <miguel@ximian.com>
11904 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
11905 failure, so we do not keep going afterwards.
11907 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
11908 wanted to pass `false' as the `is_delegate' argument. If this is
11909 the case, why not use delegate_type == null to mean `is_delegate =
11910 false' and anything else as is_delegate = true.
11912 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
11914 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
11915 code for the section, not the beginning of the tests.
11917 2002-04-08 Miguel de Icaza <miguel@ximian.com>
11919 * cfold.cs: Handle operator + (Enum x, Underlying x)
11921 * expression.cs (Binary): same. Warn about errors where we have
11922 Enum/Enum in operator + as well.
11924 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
11927 - added support for switch(bool)
11928 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
11929 - add TableSwitchEmit() to handle table-based switch statements
11931 2002-04-05 Ravi Pratap <ravi@ximian.com>
11933 * expression.cs (Invocation.OverloadResolve): Factor out code which
11934 does parameter compatibility checking with arguments so that we can
11935 re-use the code even from Delegate.VerifyApplicability
11937 (VerifyArgumentsCompat): Move above code here.
11939 * delegate.cs (VerifyApplicability): Get rid of duplicate code
11940 and instead make a call to the above method.
11942 2002-03-31 Ravi Pratap <ravi@ximian.com>
11944 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
11945 We use it to keep track of classes which are attribute types.
11947 2002-04-02 Miguel de Icaza <miguel@ximian.com>
11949 * delegate.cs (Delegate.Define): Correctly define the types in the
11950 presence of fixed and array parameters.
11952 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
11955 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
11956 include NonPublic after the first iteration.
11958 * class.cs (Indexer.CheckBase): Only check if both parents are
11961 * cs-parser.jay (accessor_body): If empty, set to null.
11963 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
11964 same code path here to resolve constants names that we did have in
11965 MemberAccess.DoResolve. There is too much code duplicated here.
11967 2002-04-01 Miguel de Icaza <miguel@ximian.com>
11969 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
11971 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
11974 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
11975 tokens, numbers and strings.
11977 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
11980 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
11981 asyncronous parameters and the regular parameters.
11983 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
11984 specify the target directory.
11986 * expression.cs: (This.DoResolve): Simplify
11987 (As.Emit): Optimize, do not generate IsInst if the expression is
11988 always of the given type.
11990 (Is.DoResolve): Bug fix, we were reporting both always/never for
11993 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
11994 creating too many unnecessary arrays.
11996 2002-03-31 Miguel de Icaza <miguel@ximian.com>
11998 * class.cs (EmitFieldInitializer): Use Assign expression to assign
11999 fields instead of rolling our own initializer. Takes care of all
12000 implicit conversions, and drops unnecessary static checks/argument.
12002 2002-03-31 Dick Porter <dick@ximian.com>
12004 * driver.cs: use the GetDirectories() return values properly, and
12005 use "/" as path separator.
12007 2002-03-30 Miguel de Icaza <miguel@ximian.com>
12009 * expression.cs (Unary): Optimize - - expr into expr.
12010 (Binary): Optimize a + (-b) into a -b.
12012 * codegen.cs (CodeGen): Made all methods static.
12014 2002-03-29 Miguel de Icaza <miguel@ximian.com>
12018 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
12019 TypeBuilder property.
12021 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
12024 * tree.cs: Removed the various RecordXXXX, and replaced with a
12025 single RecordDecl. Removed all the accessor methods, and just
12026 left a single access point Type
12028 * enum.cs: Rename DefineEnum to DefineType.
12030 * decl.cs: New abstract method `DefineType' used to unify the
12031 Defines for Enumerations, Interfaces, TypeContainers and
12034 (FindType): Moved LookupInterfaceOrClass here. Moved the
12035 LookupBaseClasses method that used to live in class.cs and
12036 interface.cs here, and renamed to FindType.
12038 * delegate.cs: Implement DefineType. Take advantage of the
12039 refactored pattern for locating the parent builder without taking
12040 the parent_builder argument (which we know does not work if we are
12041 nested, and triggering a toplevel definition).
12043 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12045 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
12046 accessibility of a member has changed during override and report
12049 * class.cs (Method.Define, Property.Define): Only complain on
12050 overrides if the method is private, any other accessibility is
12051 fine (and since we just checked the permission is the same, we are
12054 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
12055 and elif are processed always. The other pre-processing
12056 directives are only processed if we are "taking" the path
12058 2002-03-29 Martin Baulig <martin@gnome.org>
12060 * class.cs (Method.Emit): Only emit symbolic debugging info if the
12061 current location is not Null.
12063 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
12064 a separate method so we can profile it.
12066 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
12067 `span.Seconds' are just seconds, but no minutes or hours.
12068 (MainDriver): Profile the CodeGen.SaveSymbols calls.
12070 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12072 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
12073 Remove the gratuitous set of Final:
12075 // If an interface implementation, then we can set Final.
12076 if (((flags & MethodAttributes.Abstract) == 0) &&
12077 implementing.DeclaringType.IsInterface)
12078 flags |= MethodAttributes.Final;
12080 I do not know what I was smoking when I used that.
12083 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
12084 step into fixing the name resolution issues for delegates and
12085 unifying the toplevel name resolution.
12087 2002-03-28 Martin Baulig <martin@gnome.org>
12089 * class.cs (Method.Emit): If we have a symbol writer, call its
12090 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
12091 tell it about the current method.
12093 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
12094 writer that we're going to emit the first byte of IL code for a new
12095 statement (a new source line).
12096 (EmitContext.EmitTopBlock): If we have a symbol writer, call
12097 EmitContext.Mark() before emitting any code.
12099 * location.cs (SymbolDocument): Return null when we're Null.
12101 * statement.cs (Statement): Moved the `Location loc' variable here.
12102 (Statement.EmitBoolExpression): If we have a symbol writer, call
12103 ec.Mark() before emitting any code to tell it that we're at the
12104 beginning of a new statement.
12105 (StatementExpression): Added `Location' argument to the constructor.
12106 (Block): Added public readonly variable `StartLocation' and public
12107 variable `EndLocation'. The latter is to be set using SetEndLocation().
12108 (Block): Added constructor which takes a start and end location.
12109 (Block.SetEndLocation): New method. This sets the end location.
12110 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
12111 local variables we create.
12112 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
12113 each statement and do also mark the begin and end of the block.
12115 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
12116 tell it the current lexer.Location, use Location.Null for the end of the
12118 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
12119 current block, set its end location using SetEndLocation().
12120 (statement_expression): StatementExpression constructor now takes the
12121 lexer.Location as additional argument.
12122 (for_statement, declare_local_variables): Likewise.
12123 (declare_local_variables): When creating a new implicit block, use the
12124 new Block constructor and pass it the lexer.Location.
12126 2002-03-28 Miguel de Icaza <miguel@ximian.com>
12128 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
12129 members also on the parent interfaces recursively.
12131 2002-03-27 Miguel de Icaza <miguel@ximian.com>
12133 * report.cs: Use new formats, since Gonzalo finished the missing
12136 * expression.cs (Binary.ResolveOperator): added missing operator|
12137 operator& and operator^ for bool/bool.
12139 * cs-parser.jay: CheckDef now takes a Location argument that is
12140 used to report errors more precisly (instead of reporting the end
12141 of a definition, we try to track something which is a lot closer
12142 to the source of the problem).
12144 * cs-tokenizer.cs: Track global token use, so we can properly flag
12145 the use of #define/#undef after the first token has been seen.
12147 Also, rename the reportXXXX to Error_DescriptiveName
12149 * decl.cs (DeclSpace.IsTopLevel): Move property here from
12150 TypeContainer, so that Enum and Interface can use this too.
12152 * class.cs (TypeContainer.LookupInterfaceOrClass,
12153 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
12154 `builder' argument. Typically this was used to pass the parent
12155 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
12158 The problem is that a nested class could trigger the definition of
12159 a toplevel class, and the builder would be obviously wrong in that
12162 So we drop this argument, and we compute dynamically the
12163 TypeBuilder/ModuleBuilder (the correct information was available
12164 to us anyways from DeclSpace.Parent)
12166 * interface.cs (Interface.DefineInterface): Drop builder
12167 parameter cleanup like class.cs
12169 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
12172 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
12175 (Try.Emit): Propagate the returns value from the statement.
12177 (Return.Emit): Even if we are leavning
12179 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
12181 * modifiers.cs: Fix the computation of MethodAttributes flags.
12183 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
12185 * driver.cs: allow compilation of files that start with '/'.
12186 Add a default case when checking the argument of --target.
12188 2002-03-25 Miguel de Icaza <miguel@ximian.com>
12190 * interface.cs: Implement the same search algorithm for types in
12191 the interface code.
12193 * delegate.cs: Do not allow multiple definition.
12195 * Recovered ChangeLog that got accidentally amputated
12197 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
12199 * rootcontext.cs: Load manually enum to allow core classes to
12200 contain enumerations.
12202 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
12203 Update to new static methods in TypeManager.
12205 * typemanager.cs (GetMethod, GetConstructor): Use our
12206 implementation of FindMembers to find the members, since during
12207 corlib compilation, the types are TypeBuilders and GetMethod and
12208 GetConstructor do not work.
12210 Make all methods in TypeManager static.
12212 (InitCodeHelpers): Split the functionality from
12213 the InitCodeTypes function.
12215 * driver.cs: Call InitCodeHelpers after we have populated the
12218 * cs-parser.jay (delegate_declaration): we did not used to compute
12219 the delegate name correctly for void delegates.
12221 2002-03-24 Miguel de Icaza <miguel@ximian.com>
12223 * rootcontext.cs (RootContext): Init the interface_resolve_order
12224 and type_container_resolve_order always.
12226 (ResolveCore, BootstrapCorlib_ResolveClass,
12227 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
12228 compiler when compiling with --nostdlib
12230 * class.cs (TypeContainer.DefineType): Check that our parent is
12231 not null. This test is most important when we are bootstraping
12234 * codegen.cs: Split out the symbol writing code.
12236 2002-03-25 Martin Baulig <martin@gnome.org>
12238 * driver.cs (-g): Made -g an alias for --debug.
12240 2002-03-24 Martin Baulig <martin@gnome.org>
12242 * codegen.cs (SymbolWriter): New public variable. Returns the
12243 current symbol writer.
12244 (CodeGen): Added `bool want_debugging_support' argument to the
12245 constructor. If true, tell the ModuleBuild that we want debugging
12246 support and ask it for the ISymbolWriter.
12247 (Save): If we have a symbol writer, call it's Close() method after
12248 saving the assembly.
12250 * driver.c (--debug): New command line argument to create a
12251 debugger information file.
12253 * location.cs (SymbolDocument): New public property. Returns an
12254 ISymbolDocumentWriter object for the current source file or null
12255 if we don't have a symbol writer.
12257 2002-03-21 Miguel de Icaza <miguel@ximian.com>
12259 * driver.cs (LoadAssembly): Correctly return when all the paths
12260 have been tried and not before.
12262 * statement.cs (Switch.Emit): return the actual coverage for this
12263 statement (returns/not-returns)
12265 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
12266 switch of the statement if we are the last switch section. That
12267 kills two problems: try/catch problems (we used to emit an empty
12268 nop at the end) and switch statements where all branches would
12271 2002-03-19 Miguel de Icaza <miguel@ximian.com>
12273 * driver.cs: Add default assemblies (the equivalent to the
12274 Microsoft CSC.RSP file)
12276 * cs-tokenizer.cs: When updating `cols and setting it to zero,
12277 also update tokens_seen and set it to false.
12279 * driver.cs: Implement --recurse for Mike.
12281 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
12282 correctly splitting out the paths.
12284 2002-03-18 Miguel de Icaza <miguel@ximian.com>
12286 * interface.cs (Interface.PopulateProperty): Instead of using
12287 `parent' as the declaration space for the set parameters, use
12290 * support.cs (InternalParameters): InternalParameters constructor
12291 takes a DeclSpace instead of a TypeContainer.
12293 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
12294 types are being initialized, load the address of it before calling
12297 (New): Provide a mechanism to disable the generation of local
12298 value type temporaries when the caller will be providing us with
12299 an address to store it.
12301 (ArrayCreation.EmitDynamicInitializers): Use it.
12303 2002-03-17 Miguel de Icaza <miguel@ximian.com>
12305 * expression.cs (Invocation.EmitArguments): Only probe for array
12306 property if there is more than one argument. Sorry about that.
12308 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
12309 empty param arrays.
12311 * class.cs (Method.LabelParameters): Fix incorrect code path that
12312 prevented the `ParamArrayAttribute' from being applied to the
12315 2002-03-16 Miguel de Icaza <miguel@ximian.com>
12317 * support.cs (ReflectionParameters): Correctly compute whether the
12318 last argument is a params array. Fixes the problem with
12321 * typemanager.cs: Make the assemblies array always be non-null
12322 (empty, but non-null)
12324 * tree.cs (RecordDecl): New function that abstracts the recording
12325 of names. This reports error 101, and provides a pointer to the
12326 previous declaration. Fixes a crash in the compiler.
12328 * cs-parser.jay (constructor_declaration): Update to new grammar,
12329 and provide a constructor_body that can be empty.
12331 2002-03-15 Miguel de Icaza <miguel@ximian.com>
12333 * driver.cs: Add support for --resources.
12335 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
12336 Make all types for the various array helper methods be integer.
12338 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
12339 CheckState to ConvCast.
12341 (ConvCast): Now it takes a `checked' state argument, to avoid
12342 depending on the emit context for the conversion, and just using
12343 the resolve time setting.
12345 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
12346 instead of Invocation.EmitArguments. We do not emit the original
12347 arguments, instead we emit those which have been converted to
12348 unsigned int expressions.
12350 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
12352 * codegen.cs: ditto.
12354 * expression.cs (LocalVariableReference): Drop the use of the
12355 Store function that depended on the variable index.
12357 * statement.cs (VariableInfo): Drop the `Idx' property from this
12358 class, as this is not taking into account the indexes for
12359 temporaries tat we generate during the execution, getting the
12362 * class.cs: First emit class initializers, then call the parent
12365 * expression.cs (Binary): Fix opcode emision.
12366 (UnaryMutator.EmitCode): Support checked code generation
12368 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
12369 matches for events for both the Static and Instance scans,
12370 pointing to the same element. Fix that.
12372 2002-03-14 Miguel de Icaza <miguel@ximian.com>
12374 * rootcontext.cs (ResolveTree): Always set the
12375 interface_resolve_order, because nested interfaces will be calling
12378 * class.cs (GetInterfaceOrClass): Track the same resolution
12379 process used by TypeManager.LookupType. This fixes the nested
12380 type lookups in class declarations (separate path from
12383 (TypeContainer.DefineType): Also define nested interfaces.
12384 (TypeContainer.RegisterOrder): New public function used to
12385 register the order in which child interfaces need to be closed.
12387 Nested interfaces need to be closed after their parents have been
12390 * interface.cs (InterfaceAttr): Put all the logic for computing
12391 the interface attribute here.
12393 (DefineInterface): Register our interface order with the
12394 RootContext or with the TypeContainer depending on the case.
12396 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12398 * cs-parser.jay: rework foreach statement to work with the new
12399 changes to the policy on SimpleNames.
12401 * report.cs: support Stacktrace on warnings as well.
12403 * makefile: drop --unsafe and /unsafe from the compile.
12405 2002-03-13 Ravi Pratap <ravi@ximian.com>
12407 * ecore.cs (StandardConversionExists): Modify to take an Expression
12408 as the first parameter. Ensure we do null -> reference type conversion
12411 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
12412 temporary Expression objects.
12414 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
12416 * interface.cs: workaround bug in method overloading resolution
12417 (there is already a bugzilla bug for it).
12419 2002-03-12 Miguel de Icaza <miguel@ximian.com>
12421 We could also solve this problem by having a separate path for
12422 performing type lookups, instead of DoResolve, we could have a
12423 ResolveType entry point, and only participating pieces of the
12424 production (simplename, deref, array) would implement this.
12426 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
12427 signal SimpleName to only resolve type names and not attempt to
12428 resolve anything else.
12430 * expression.cs (Cast): Set the flag.
12432 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
12434 * class.cs: Only report 108 if there is no `new' modifier.
12436 * cs-parser.jay: rework foreach statement to work with the new
12437 changes to the policy on SimpleNames.
12439 * report.cs: support Stacktrace on warnings as well.
12441 * makefile: drop --unsafe and /unsafe from the compile.
12443 2002-03-11 Miguel de Icaza <miguel@ximian.com>
12445 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12446 lookups here, instead of doing that at parse time. This means
12447 that our grammar will not introduce `LocalVariableReferences' as
12448 expressions at this point. That solves the problem of code like
12452 static void Main ()
12456 This is only half the fix. The full fix requires parameters to
12457 also be handled in this way.
12459 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
12460 makes the use more obvious of the DeclSpace. The
12461 ec.TypeContainer.TypeBuilder is now only used to pull the
12462 TypeBuilder for it.
12464 My theory is that I can get rid of the TypeBuilder completely from
12465 the EmitContext, and have typecasts where it is used (from
12466 DeclSpace to where it matters).
12468 The only pending problem is that the code that implements Aliases
12469 is on TypeContainer, and probably should go in DeclSpace.
12471 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
12472 lookups here, instead of doing that at parse time. This means
12473 that our grammar will not introduce `LocalVariableReferences' as
12474 expressions at this point. That solves the problem of code like
12478 static void Main ()
12482 This is only half the fix. The full fix requires parameters to
12483 also be handled in this way.
12485 * class.cs (Property.DefineMethod): When implementing an interface
12486 method, set newslot, when implementing an abstract method, do not
12487 set the flag (before we tried never setting it, or always setting
12488 it, which is the difference).
12489 (Indexer.DefineMethod): same.
12490 (Method.DefineMethod): same.
12492 * ecore.cs: Only set the status used flag if we get back a Field.
12494 * attribute.cs: Temporary hack, so Paolo can keep working.
12496 2002-03-08 Ravi Pratap <ravi@ximian.com>
12498 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
12499 the unmanaged type in the case we have a MarshalAs attribute.
12501 (Resolve): Handle the case when we are parsing the special MarshalAs
12502 attribute [we need to store the unmanaged type to use later]
12504 * typemanager.cs (marshal_as_attr_type): Built in type for the
12505 MarshalAs Attribute.
12507 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
12508 on parameters and accordingly set the marshalling info.
12510 2002-03-09 Miguel de Icaza <miguel@ximian.com>
12512 * class.cs: Optimizing slightly by removing redundant code after
12513 we switched to the `NoTypes' return value.
12514 (Property.DefineMethod): use NoTypes here too.
12516 This fixes the bug I introduced in my last batch of changes.
12518 2002-03-05 Ravi Pratap <ravi@ximian.com>
12520 * tree.cs (RecordEnum): Add. We now keep track of enums too.
12522 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
12523 Enums since those are types too.
12525 * cs-parser.jay (enum_declaration): Record enums as we parse them.
12527 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
12528 thanks to a call during the lookup process.
12530 2002-03-07 Miguel de Icaza <miguel@ximian.com>
12532 * statement.cs (Foreach): Lots of work to accomodate a particular
12533 kind of foreach statement that I had not kept in mind. It is
12534 possible to have foreachs on classes that provide a GetEnumerator
12535 method that return objects that implement the "pattern" for using
12536 a foreach, there is no need to support GetEnumerator
12539 This is needed to compile nant.
12541 * decl.cs: Only report 114 if the member is not `Finalize' and if
12542 the warning level is at least 2.
12544 * class.cs: Moved the compare function from Method to
12547 (MethodSignature.InheritableMemberSignatureCompare): Add new
12548 filter function that is used to extract inheritable methods from a
12551 (Method.Define): Use the new `inheritable_method_signature_filter'
12554 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
12557 2002-03-06 Miguel de Icaza <miguel@ximian.com>
12559 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
12561 * cs-parser.jay: Add opt_semicolon to the interface declaration.
12563 * expression.cs: Pass location information to
12564 ConvertImplicitStandard.
12566 * class.cs: Added debugging code to track return values from
12569 2002-03-05 Miguel de Icaza <miguel@ximian.com>
12571 * expression.cs (Is.DoResolve): If either side of the `is' is an
12572 interface, do not flag the warning.
12574 * ecore.cs (ImplicitReferenceConversion): We need a separate test
12577 * report.cs: Allow for --fatal to be used with --probe.
12579 * typemanager.cs (NoTypes): Move the definition for the empty Type
12582 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
12584 (TypeContainer.DefineProxy): New function used to proxy to parent
12585 implementations when implementing interfaces.
12586 (TypeContainer.ParentImplements): used to lookup if our parent
12587 implements a public function that is required by an interface.
12588 (TypeContainer.VerifyPendingMethods): Hook this up.
12590 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
12591 `modules' and `assemblies' arraylists into arrays. We only grow
12592 these are the very early start up of the program, so this improves
12593 the speedof LookupType (nicely measured).
12595 * expression.cs (MakeByteBlob): Replaced unsafe code with
12596 BitConverter, as suggested by Paolo.
12598 * cfold.cs (ConstantFold.Binary): Special case: perform constant
12599 folding of string concatenation, but if either side is a string,
12600 and the other is not, then return null, and let the runtime use
12601 the concatenation on the string plus the object (using
12602 `Object.ToString').
12604 2002-03-04 Miguel de Icaza <miguel@ximian.com>
12606 Constant Folding has been implemented now.
12608 * expression.cs (Unary.Reduce): Do not throw an exception, catch
12609 the error instead on types that are not supported in one's
12612 * constant.cs (Constant and all children): New set of functions to
12613 perform implict and explicit conversions.
12615 * ecore.cs (EnumConstant): Implement the new functions to perform
12616 conversion by proxying to the child expression.
12618 * codegen.cs: (ConstantCheckState): Constant evaluation has its
12619 own separate setting that can not be turned off from the command
12620 line using --unchecked or --checked and is only controlled using
12621 the checked/unchecked statements and expressions. This setting is
12622 used by the constant folder to flag errors.
12624 * expression.cs (CheckedExpr, UncheckedExpr): Set the
12625 ConstantCheckState as well.
12627 During Resolve, they also have to flag the state, because the
12628 constant folder runs completely in the Resolve phase.
12630 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
12633 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12635 * cfold.cs: New file, this file contains the constant folder.
12637 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
12638 argument to track whether we are using the resulting address to
12639 load or store a value and provide better error messages.
12641 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
12642 new AddressOf arguments.
12644 * statement.cs (Foreach.EmitCollectionForeach): Update
12646 * expression.cs (Argument.Emit): Call AddressOf with proper
12647 arguments to track usage.
12649 (New.DoEmit): Call AddressOf with new arguments.
12651 (Unary.Emit): Adjust AddressOf call.
12653 2002-03-01 Ravi Pratap <ravi@ximian.com>
12655 * cs-parser.jay (member_access): Change the case for pre-defined types
12656 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
12659 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
12662 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
12663 essentially like methods and apply attributes like MethodImplOptions to them too.
12665 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
12668 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
12669 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
12672 * Update code everywhere accordingly.
12674 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
12676 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
12678 2002-02-28 Ravi Pratap <ravi@ximian.com>
12680 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
12681 try performing lookups against those instead of jumping straight into using
12682 the 'using' clauses.
12684 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
12686 (LookupType): Perform lookups in implicit parents too.
12688 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
12689 sequence as RootContext.LookupType.
12691 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
12692 the various cases of namespace lookups into this method.
12694 2002-03-01 Miguel de Icaza <miguel@ximian.com>
12696 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
12697 in positional arguments)
12699 * class.cs (Operator): Update the AllowedModifiers to contain
12702 * cs-parser.jay: Update operator declaration to allow for the
12703 operator body to be empty.
12705 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
12708 2002-02-27 Miguel de Icaza <miguel@ximian.com>
12710 * class.cs (Method.Emit): Label parameters.
12712 * driver.cs: Return 1 or 0 as the program exit code.
12714 2002-02-26 Miguel de Icaza <miguel@ximian.com>
12716 * expression.cs: Special case the `null' object when trying to
12717 auto-compute the type, as anything can be explicitly converted to
12720 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
12721 spotting this Paolo.
12723 (Expression.ImplicitNumericConversion): Perform comparissions of
12724 the type using the underlying type in the case of an enumeration
12725 rather than using the enumeration type for the compare.
12727 Cope with the underlying == type case, which is not possible to
12730 (Expression.ConvertNumericExplicit): Perform comparissions of
12731 the type using the underlying type in the case of an enumeration
12732 rather than using the enumeration type for the compare.
12734 * driver.cs: If the user does not supply an extension, assume .exe
12736 * cs-parser.jay (if_statement): Rewrote so that we can track the
12737 location for the if statement.
12739 * expression.cs (Binary.ConstantFold): Only concat strings when
12740 the operation is "+", not everything ;-)
12742 * statement.cs (Statement.EmitBoolExpression): Take a location
12744 (If, While, Do): Track location.
12746 * expression.cs (Binary.ResolveOperator): In the object + string
12747 case, I was missing a call to ConvertImplicit
12749 2002-02-25 Ravi Pratap <ravi@ximian.com>
12751 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
12752 Location arguments. Ensure we use RootContext.LookupType to do our work
12753 and not try to do a direct Type.GetType and ModuleBuilder.GetType
12755 * interface.cs (PopulateMethod): Handle the type of the parameter being
12758 * expression.cs (Invocation.BetterFunction): Handle the case when we
12759 have a params method with no fixed arguments and a call is made with no
12762 2002-02-25 Miguel de Icaza <miguel@ximian.com>
12764 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
12765 the verbatim-string-literal
12767 * support.cs (InternalParameters.ParameterModifier): handle null
12769 (InternalParameters.ParameterType): ditto.
12771 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
12772 duplicating the name of the variable parameter.
12773 (GetParameterByName): Fix bug where we were not looking up array
12774 paramters if they were the only present (thanks Paolo!).
12775 (GetParameterInfo): We only have an empty set of types if both
12776 fixed and array are set to null.
12777 (GetParameterInfo-idx): Handle FixedParameter == null
12779 * cs-parser.jay: Handle the case where there is no catch
12780 statements (missing null test).
12782 2002-02-22 Miguel de Icaza <miguel@ximian.com>
12784 * driver.cs (MainDriver): Be conservative on our command line
12787 Catch DirectoryNotFoundException when calling GetFiles.
12789 (SplitPathAndPattern): Used to split the input specification into
12790 a path and a pattern that we can feed to Directory.GetFiles.
12792 2002-02-21 Miguel de Icaza <miguel@ximian.com>
12794 * statement.cs (Fixed): Implement the last case of the Fixed
12795 statement (string handling).
12797 * expression.cs (StringPtr): New class used to return a char * to
12798 a string; Used by the Fixed statement.
12800 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
12802 * expression.cs (Binary.ResolveOperator): Remove redundant
12803 MemberLookup pn parent type.
12804 Optimize union call, we do not need a union if the types are the same.
12805 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
12808 Specialize the use of MemberLookup everywhere, instead of using
12809 the default settings.
12811 (StackAlloc): Implement stackalloc keyword.
12813 * cs-parser.jay: Add rule to parse stackalloc.
12815 * driver.cs: Handle /h, /help, /?
12817 * expression.cs (MakeByteBlob): Removed the hacks we had in place
12818 before we supported unsafe code.
12820 * makefile: add --unsafe to the self compilation of mcs.
12822 2002-02-20 Miguel de Icaza <miguel@ximian.com>
12824 * expression.cs (PointerArithmetic): New class that is used to
12825 perform pointer arithmetic.
12826 (Binary.Resolve): Handle pointer arithmetic
12827 Handle pointer comparission.
12828 (ArrayPtr): Utility expression class that is used to take the
12829 address of an array.
12831 (ElementAccess): Implement array access for pointers
12833 * statement.cs (Fixed): Implement fixed statement for arrays, we
12834 are missing one more case before we are done.
12836 * expression.cs (Indirection): Implement EmitAssign and set the
12837 ExprClass to Variable. This allows pointer dereferences to be
12838 treated as variables, and to have values assigned to them.
12840 * ecore.cs (Expression.StoreFromPtr): New utility function to
12841 store values dereferencing.
12843 2002-02-20 Ravi Pratap <ravi@ximian.com>
12845 * expression.cs (Binary.ResolveOperator): Ensure that we are
12846 not trying to operate on a void type - this fixes the reported
12849 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
12850 the parent implementation is sealed.
12852 * ../errors/cs0239.cs : Add.
12854 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
12856 * typemanager.cs (unverifiable_code_type): Corresponds to
12857 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
12858 which have unsafe code in them.
12860 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
12863 2002-02-19 Miguel de Icaza <miguel@ximian.com>
12865 * cs-tokenizer.cs: Add support for @"litreal strings"
12867 Make tokenizer accept pre-processor directives
12868 on any column (remove the old C-like limitation).
12870 * rootcontext.cs (EmitCode): Emit any global attributes.
12871 (AddGlobalAttributes): Used to keep track of assembly attributes.
12873 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
12875 * cs-parser.jay: Add support for global attributes.
12877 2002-02-17 Miguel de Icaza <miguel@ximian.com>
12879 * expression.cs (Indirection): New helper class. Unary will
12880 create Indirection classes to be able to implement the
12881 IMemoryLocation interface on it.
12883 2002-02-16 Miguel de Icaza <miguel@ximian.com>
12885 * cs-parser.jay (fixed_statement): reference the right statement.
12887 * statement.cs (Fixed.Emit): Finish implementing the fixed
12888 statement for the &x case.
12890 2002-02-14 Miguel de Icaza <miguel@ximian.com>
12892 * class.cs (Property.Define, Method.Define): Remove newslot when
12895 * modifiers.cs: My use of NewSlot when `Abstract' was set was
12896 wrong. NewSlot should only be used if the `new' keyword is present.
12898 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
12899 locating our system dir. Sorry about this.
12901 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12903 * driver.cs (GetSystemDir): Compute correctly the location of our
12904 system assemblies. I was using the compiler directory instead of
12905 the library directory.
12907 2002-02-13 Ravi Pratap <ravi@ximian.com>
12909 * expression.cs (BetterFunction): Put back in what Miguel commented out
12910 since it is the correct fix. The problem is elsewhere ;-)
12912 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
12913 parameters of the parms method are themselves compatible or not !
12915 (StandardConversionExists): Fix very dangerous bug where we were forgetting
12916 to check that a class implements an interface before saying that an implicit
12917 conversion was allowed. Use ImplementsInterface to do the checking.
12919 2002-02-13 Miguel de Icaza <miguel@ximian.com>
12921 * class.cs (Method.Define): Track whether we are an explicit
12922 implementation or not. And only call DefineMethodOverride if we
12923 are an explicit implementation.
12925 (Property.DefineMethod): Ditto.
12927 2002-02-11 Ravi Pratap <ravi@ximian.com>
12929 * expression.cs (BetterFunction): Catch hideous bug which was
12930 preventing us from detecting ambiguous calls due to implicit casts i.e
12933 2002-01-29 Miguel de Icaza <miguel@ximian.com>
12935 * support.cs (Pair): Remove un-needed method. I figured why I was
12936 getting the error in cs-parser.jay, the variable in a foreach loop
12937 is readonly, and the compiler does not really treat this as a variable.
12939 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
12940 instead of EQUALS in grammar.
12942 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
12944 * expression.cs (Unary.DoResolve): Check whether the argument is
12947 2002-01-28 Miguel de Icaza <miguel@ximian.com>
12949 * support.cs: Api for Pair to set a value. Despite the fact that
12950 the variables are public the MS C# compiler refuses to compile
12951 code that accesses the field if the variable is part of a foreach
12954 * statement.cs (Fixed): Begin implementation of the fixed
12957 (Block.AddVariable): Return the VariableInfo on success and null
12958 on failure instead of true/false.
12960 * cs-parser.jay (foreach): Catch errors on variables already
12961 defined (we were ignoring this value before) and properly unwind
12962 the block hierarchy
12964 (fixed_statement): grammar for the fixed statement.
12966 2002-01-25 Miguel de Icaza <miguel@ximian.com>
12968 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
12969 pointer types to be incretemented.
12971 (SizeOf): Implement.
12973 * cs-parser.jay (pointer_member_access): Implement
12974 expr->IDENTIFIER production.
12976 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
12977 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
12980 (Unary): Implement indirection.
12982 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
12983 use in non-unsafe context).
12985 (SimpleName.DoResolve): Check for pointers in field access on safe
12988 (Expression.LoadFromPtr): Factor the load-indirect code in this
12989 function. This was duplicated in UnboxCast and ParameterReference
12991 2002-01-24 Miguel de Icaza <miguel@ximian.com>
12993 * expression.cs (ComposedCast): report an error if a pointer cast
12994 is used in a safe region.
12996 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
12997 pointer type casts in unsafe context.
12999 * codegen.cs (EmitContext): Set up IsUnsafe.
13001 * cs-parser.jay (non_expression_type): Add productions for pointer
13004 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
13005 code. We should not use force into static mode if the method is
13006 not virtual. Fixes bug in MIS
13008 * statement.cs (Do.Emit, While.Emit, For.Emit,
13009 Statement.EmitBoolExpression): Add support to Do and While to
13010 propagate infinite loop as `I do return' semantics.
13012 Improve the For case to also test for boolean constants.
13014 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
13015 to the list of attributes we can add.
13017 Remove `EmitContext' argument.
13019 * class.cs (Method.Define): Apply parameter attributes.
13020 (Constructor.Define): Apply parameter attributes.
13021 (MethodCore.LabelParameters): Move here the core of labeling
13024 * support.cs (ReflectionParameters.ParameterModifier,
13025 InternalParameters.ParameterModifier): Use IsByRef on the type and
13026 only return the OUT bit for these parameters instead of in/out/ref
13029 This is because I miss-understood things. The ParameterInfo.IsIn
13030 and IsOut represent whether the parameter has the [In] and [Out]
13033 2002-01-22 Miguel de Icaza <miguel@ximian.com>
13035 * ecore.cs (FieldExpr.Emit): Release temporaries.
13037 * assign.cs (LocalTemporary.Release): new function.
13039 * codegen.cs (EmitContext.GetTemporaryStorage,
13040 EmitContext.FreeTemporaryStorage): Rework the way we deal with
13041 temporary storage. Now we can "put back" localbuilders when we
13044 2002-01-21 Miguel de Icaza <miguel@ximian.com>
13046 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
13047 need to make a copy of the variable to generate verifiable code.
13049 2002-01-19 Miguel de Icaza <miguel@ximian.com>
13051 * driver.cs: Compute dynamically the system directory.
13053 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
13054 Slower, but more generally useful. Used by the abstract
13055 registering implementation.
13057 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
13058 the rules for the special rule on Type/instances. First check if
13059 we have the same name, and if so, try that special static path
13060 rather than the instance path.
13062 2002-01-18 Miguel de Icaza <miguel@ximian.com>
13064 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
13067 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
13068 Enum, ValueType, Delegate or Array for non-corlib compiles.
13070 * cs-tokenizer.cs: Catch long identifiers (645)
13072 * typemanager.cs (IndexerPropetyName): Ravi never tested this
13075 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
13076 fix, we were returning too early, so we were not registering
13077 pending methods from abstract classes.
13079 Do not register pending methods if the class is abstract.
13081 * expression.cs (Conditional.DoResolve): Report circular implicit
13082 conversions when we neecd to compute it for conditional
13085 (Is.DoResolve): If the expression is always of the provided type,
13086 flag warning 183. If the expression can not ever be of the
13087 provided type flag warning 184.
13089 * class.cs: Catch 169 as well.
13091 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
13094 2002-01-18 Nick Drochak <ndrochak@gol.com>
13096 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
13098 2002-01-17 Miguel de Icaza <miguel@ximian.com>
13100 * interface.cs: (PopulateMethod): Check for pointers being defined
13101 only if the unsafe context is active.
13102 (PopulateProperty): ditto.
13103 (PopulateIndexer): ditto.
13105 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
13106 specified. If pointers are present, make sure that they are
13107 present in an unsafe context.
13108 (Constructor, Constructor.Define): ditto.
13109 (Field, Field.Define): ditto.
13110 (Property, Property.Define): ditto.
13111 (Event, Event.Define): ditto.
13113 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
13114 hashtable if there are classes or structs defined.
13116 * expression.cs (LocalVariableReference.DoResolve): Simplify this
13117 code, as the constant resolution moved.
13119 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
13120 the metadata, so we can flag error 133.
13122 * decl.cs (MemberCore.UnsafeOK): New function to test that a
13123 pointer is being declared in an unsafe context.
13125 2002-01-16 Miguel de Icaza <miguel@ximian.com>
13127 * modifiers.cs (Modifiers.Check): Require a Location argument.
13128 Report error 227 for Unsafe use.
13130 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
13132 * statement.cs (For.Emit): If the test is null, then report that
13133 we do `return', as we wont reach anything afterwards.
13135 (Switch.SwitchGoverningType): Track the expression that matched
13138 * driver.cs: Allow negative numbers as an error code to flag.
13140 * cs-parser.jay: Handle 1551.
13142 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
13144 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13146 * cs-parser.jay: Report 1518 (type declaration can only contain
13147 class, struct, interface, enum or delegate)
13149 (switch_label): Report 1523 (keywords `case' or `default' must
13152 (opt_switch_sections): Report 1522 (empty switch)
13154 * driver.cs: Report 1515 (response file specified multiple times)
13155 Report 1516 (Source file specified multiple times).
13157 * expression.cs (Argument.Resolve): Signal 1510
13159 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
13160 access not allowed in static code)
13162 2002-01-11 Ravi Pratap <ravi@ximian.com>
13164 * typemanager.cs (IsPointerType): Utility method which we are going
13167 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
13168 the object type, so we take care of that.
13170 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
13172 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
13173 added to non-params parameters :-)
13175 * typemanager.cs (CSharpName): Include 'void' type too.
13177 (void_ptr_type): Include in the set of core types.
13179 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
13182 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
13185 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
13186 completely forgotten about it.
13188 2002-01-10 Ravi Pratap <ravi@ximian.com>
13190 * cs-parser.jay (pointer_type): Add. This begins our implementation
13191 of parsing rules for unsafe code.
13193 (unsafe_statement): Implement.
13195 (embedded_statement): Modify to include the above.
13197 * statement.cs (Unsafe): Implement new class for unsafe blocks.
13199 * codegen.cs (EmitContext.InUnsafe): Add. This determines
13200 if the current context is an unsafe one.
13202 * cs-parser.jay (local_variable_pointer_type): Since local variable types
13203 are handled differently, we need separate rules for them.
13205 (local_variable_declaration): Update to use local_variable_pointer_type
13206 to allow variable declarations of unmanaged pointer types.
13208 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
13209 in unsafe contexts.
13211 * ../errors/cs0214.cs : Add.
13213 2002-01-16 Nick Drochak <ndrochak@gol.com>
13215 * makefile: remove 'response' file when cleaning.
13217 2002-01-15 Miguel de Icaza <miguel@ximian.com>
13219 * cs-parser.jay: Report 1524.
13221 2002-01-14 Miguel de Icaza <miguel@ximian.com>
13223 * typemanager.cs (RegisterMethod): drop checking if we have
13224 registered this from here
13226 2002-01-12 Miguel de Icaza <miguel@ximian.com>
13228 * class.cs (Method.EmitDestructor): Implement calling our base
13231 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
13232 value of InFinally.
13234 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
13235 this routine and will wrap the call in a try/catch block. Deal
13238 2002-01-11 Miguel de Icaza <miguel@ximian.com>
13240 * ecore.cs (Expression.MemberLookup): instead of taking a
13241 parameter `same_type' that was used to tell whether we could
13242 access private members we compute our containing type from the
13245 (FieldExpr): Added partial support for volatile fields. This does
13246 not work for volatile fields exposed from assemblies, as I can not
13247 figure out how to extract the modreq from it.
13249 Updated all the source files to use this.
13251 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
13252 because it is referenced by MemberLookup very often.
13254 2002-01-09 Ravi Pratap <ravi@ximian.com>
13256 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
13257 TypeBuilder.GetCustomAttributes to retrieve what we need.
13259 Get rid of redundant default_member_attr_type as this is the same as
13260 default_member_type which already exists.
13262 * interface.cs, attribute.cs : Update accordingly.
13264 2002-01-08 Miguel de Icaza <miguel@ximian.com>
13266 * typemanager.cs: Enable IndexerPropertyName again. It does not
13267 work for TYpeBuilders though. Ravi, can you please fix this?
13269 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
13271 * expression.cs (Argument.Emit): Handle the case of ref objects
13272 being passed to ref functions;
13274 (ParameterReference.EmitLoad): Loads the content of the pointer
13275 without dereferencing.
13277 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13279 * cs-tokenizer.cs: Implemented the pre-processing expressions.
13281 2002-01-08 Ravi Pratap <ravi@ximian.com>
13283 * class.cs (Indexer.DefineMethod): Incorporate the interface
13284 type in the name of the method if we are doing explicit interface
13287 * expression.cs (ConversionExists): Remove as it is completely obsolete.
13289 (BetterConversion): Fix extremely trivial bug where we were referring to
13290 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
13293 * ../errors/bug16.cs : Add although we have fixed it.
13295 2002-01-07 Miguel de Icaza <miguel@ximian.com>
13297 * expression.cs (BaseIndexer): Begin implementation.
13299 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
13301 * cs-parser.jay (indexer_declarator): Use qualified_identifier
13302 production directly to remove a shift/reduce, and implement
13303 explicit interface implementation.
13305 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
13306 after a floating point suffix.
13308 * expression.cs (DoNumericPromotions): Improved the conversion for
13309 uint/uint. If we have a constant, we avoid doing a typecast to a
13312 * class.cs (Indexer): Implement explicit interface implementation
13315 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
13317 * class.cs: make the default instance constructor public and hidebysig.
13319 2001-01-03 Ravi Pratap <ravi@ximian.com>
13321 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
13322 so we can call it from elsewhere.
13324 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
13325 we emit it internally if the class has a defined indexer; otherwise the user
13326 emits it by decorating the class definition with the DefaultMemberAttribute.
13328 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
13329 attribute is not used on a type which defines an indexer.
13331 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
13332 character when we skip whitespace.
13334 * ../errors/cs0646.cs : Add.
13336 2002-01-03 Miguel de Icaza <miguel@ximian.com>
13338 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
13341 * makefile: Add practical target `mcs3.exe' which builds the third
13342 generation compiler.
13344 * expression.cs (New): Fix structures constructor calling.
13346 * class.cs (Property, Method, Indexer): Emit Final flag on the
13347 method if we are an interface implementation and we are not
13350 * ecore.cs (PropertyExpr): New public field `IsBase', tells
13351 whether this property is referencing a `base' method.
13353 * expression.cs (Invocation.EmitCall): take an extra argument:
13354 is_base, this is used to determine whether the `call' or
13355 `callvirt' opcode should be used.
13358 * delegate.cs: update EmitCall.
13360 * class.cs (Method.Define): Set NewSlot for the cases where we are
13361 not implementing an interface method.
13363 (Property.Define): ditto.
13365 2002-01-02 Miguel de Icaza <miguel@ximian.com>
13367 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
13368 'r'. Allows mcs to parse itself fully.
13370 2002-01-02 Ravi Pratap <ravi@ximian.com>
13372 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
13373 of the number of initializers that require the InitializeArray method.
13375 (CheckIndices): Store the Expression in all cases - not the plain value. Also
13376 update the above field where necessary.
13378 (MakeByteBlob): Update accordingly.
13380 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
13383 (EmitDynamicInitializers): Update in accordance with the new optimization.
13385 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
13386 same OpCode applies.
13388 * cs-parser.jay : Fix some glaring errors I introduced.
13390 2002-01-01 Ravi Pratap <ravi@ximian.com>
13392 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
13393 so that we can check for name clashes there too.
13395 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
13396 for interface indexers.
13398 * interfaces.cs (Define): Emit the default member attribute.
13400 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
13401 variable was being referred to while setting the value ;-)
13403 2002-01-01 Miguel de Icaza <miguel@ximian.com>
13405 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
13406 byte-by-byte information when we know the data is zero.
13408 Make the block always a multiple of 4, because
13409 DefineInitializedData has a bug.
13411 * assign.cs: Fix, we should assign from the temporary, not from
13414 * expression.cs (MakeByteBlob): Fix my incorrect code.
13416 2001-12-31 Miguel de Icaza <miguel@ximian.com>
13418 * typemanager.cs (EnumToUnderlying): This function is used to get
13419 the underlying type from an enumeration, because it does not
13422 * constant.cs: Use the I4_S form for values between -128 and 127.
13424 * statement.cs (Block.LookupLabel): Looks up a label.
13425 (Block): Drop support for labeled blocks.
13427 (LabeledStatement): New kind of statement that represents a label
13430 (Goto): Finally implement this bad boy.
13432 * cs-parser.jay: Update to reflect new mechanism to implement
13435 2001-12-30 Miguel de Icaza <miguel@ximian.com>
13437 * codegen.cs (EmitContext.This): a codegen property that keeps the
13438 a single instance of this instead of creating many different this
13441 * delegate.cs (Delegate.DoResolve): Update to use the property;
13443 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
13445 * expression.cs (BaseAccess.DoResolve): Ditto.
13447 2001-12-29 Ravi Pratap <ravi@ximian.com>
13449 * typemanager.cs (methodimpl_attr_type): Add to hold the type
13450 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
13452 (InitCoreTypes): Update accordingly.
13454 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
13455 so we can quickly store the state.
13457 (ApplyAttributes): Set the correct implementation flags
13458 for InternalCall methods.
13460 2001-12-29 Miguel de Icaza <miguel@ximian.com>
13462 * expression.cs (EmitCall): if a method is not virtual, then do
13463 not use callvirt on it.
13465 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
13466 user defined stuff) requires the use of stobj, which takes an
13467 address on the stack instead of an array and an index. So emit
13468 the Ldelema operation for it.
13470 (EmitStoreOpcode): Use stobj for valuetypes.
13472 (UnaryMutator.EmitCode): Use the right 1 value depending on
13473 whether we are dealing with int64/uint64, float or doubles.
13475 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
13476 constructors that I implemented last night.
13478 (Constructor.IsDefault): Fix to work properly for static
13481 * cs-parser.jay (CheckDef): report method signature errors.
13482 Update error number 103 to be 132.
13484 * decl.cs: New AdditionResult enumeration value: MethodExists.
13485 Although we do this check for methods later on in the semantic
13486 analysis, catching repeated default constructors is so easy that
13487 we catch these here.
13489 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
13492 (ParameterReference.EmitAssign, Emit): handle
13495 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
13496 (ArrayAccess.EmitStoreOpcode): ditto.
13498 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
13500 * expression.cs (MakeByteBlob): Complete all the missing types
13501 (uint, short, ushort, byte, sbyte)
13503 * class.cs: Only init instance field initializers on instance
13506 Rename `constructors' to instance_constructors.
13508 (TypeContainer.AddConstructor): Only add constructors to the list
13509 if it is not static.
13511 Make sure that we handle default_static_constructor independently
13512 everywhere where we handle instance_constructors
13514 2001-12-28 Miguel de Icaza <miguel@ximian.com>
13516 * class.cs: Do not lookup or create a base initializer for a
13517 static constructor.
13519 (ConstructorInitializer.Resolve): use the proper type to lookup
13522 * cs-parser.jay: Report error 1585 (modifiers between type and name).
13524 * enum.cs, interface.cs: Remove CloseType, this is taken care by
13527 * decl.cs: CloseType is now an virtual method, the default
13528 implementation just closes this type.
13530 2001-12-28 Ravi Pratap <ravi@ximian.com>
13532 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
13533 to PreserveSig by default. Also emit HideBySig on such methods.
13535 Basically, set the defaults to standard values.
13537 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
13538 argument, if candidate is better, it can't be worse than the best !
13540 (Invocation): Re-write bits to differentiate between methods being
13541 applicable in their expanded form and their normal form - for params
13544 Get rid of use_standard everywhere as only standard conversions are allowed
13545 in overload resolution.
13547 More spec conformance.
13549 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13551 * driver.cs: Add --timestamp, to see where the compiler spends
13554 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
13555 `this' in static code.
13557 (SimpleName.DoResolve): Implement in terms of a helper function
13558 that allows static-references to be passed upstream to
13561 (Expression.ResolveWithSimpleName): Resolve specially simple
13562 names when called by MemberAccess to implement the special
13565 (Expression.ImplicitReferenceConversion): Handle conversions from
13566 Null to reference types before others, as Null's type is
13569 * expression.cs (Invocation.EmitCall): Handle the special case of
13570 calling methods declared on a reference type from a ValueType
13571 (Base classes System.Object and System.Enum)
13573 (MemberAccess.Resolve): Only perform lookups on Enumerations if
13574 the left hand side is a TypeExpr, not on every enumeration.
13576 (Binary.Resolve): If types are reference types, then do a cast to
13577 object on operators != and == of both arguments.
13579 * typemanager.cs (FindMembers): Extract instance and static
13580 members if requested.
13582 * interface.cs (PopulateProperty): Use void_type instead of null
13583 as the return type for the setter method.
13585 (PopulateIndexer): ditto.
13587 2001-12-27 Ravi Pratap <ravi@ximian.com>
13589 * support.cs (ReflectionParameters): Fix minor bug where we
13590 were examining the wrong parameter for the ParamArray attribute.
13592 Cope with requests for the type of the parameter at position
13593 greater than the params parameter's. We now return the element
13594 type of the params array as that makes more sense.
13596 * expression.cs (Invocation.IsParamsMethodApplicable): Update
13597 accordingly as we no longer have to extract the element type
13600 (Invocation.OverloadResolve): Update.
13602 2001-12-27 Miguel de Icaza <miguel@ximian.com>
13604 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
13605 against IEnumerator, test whether the return value is a descendant
13606 of the IEnumerator interface.
13608 * class.cs (Indexer.Define): Use an auxiliary method to implement
13609 the other bits of the method definition. Begin support for
13610 explicit interface implementation.
13612 (Property.DefineMethod): Use TypeManager.void_type instead of null
13613 for an empty return value.
13615 2001-12-26 Miguel de Icaza <miguel@ximian.com>
13617 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
13618 dealing with a FieldExpr which is composed of a FieldBuilder, in
13619 the code path we did extract the constant, but we should have
13620 obtained the underlying value to be able to cast it (otherwise we
13621 end up in an infinite loop, this is what Ravi was running into).
13623 (ArrayCreation.UpdateIndices): Arrays might be empty.
13625 (MemberAccess.ResolveMemberAccess): Add support for section
13626 14.5.4.1 that deals with the special case of E.I when E is a type
13627 and something else, that I can be a reference to a static member.
13629 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
13630 handle a particular array type to create byte blobs, it is just
13631 something we dont generate byteblobs for.
13633 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
13636 * location.cs (Push): remove the key from the hashtable that we
13637 are about to add. This happens for empty files.
13639 * driver.cs: Dispose files after we have parsed them.
13641 (tokenize): new function that only runs the tokenizer on its
13642 input, for speed testing.
13644 2001-12-26 Ravi Pratap <ravi@ximian.com>
13646 * class.cs (Event.Define): Define the private field only if there
13647 are no accessors defined.
13649 * expression.cs (ResolveMemberAccess): If there is no associated
13650 field with the event, that means we have an event defined with its
13651 own accessors and we should flag error cs0070 since transforming
13652 ourselves into a field is not valid in that case.
13654 * ecore.cs (SimpleName.DoResolve): Same as above.
13656 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
13657 and charset to sane values.
13659 2001-12-25 Ravi Pratap <ravi@ximian.com>
13661 * assign.cs (DoResolve): Perform check on events only if they
13662 are being accessed outside the declaring type.
13664 * cs-parser.jay (event_declarations): Update rules to correctly
13665 set the type of the implicit parameter etc.
13667 (add_accessor, remove_accessor): Set current local parameters.
13669 * expression.cs (Binary): For delegate addition and subtraction,
13670 cast the return value from the method into the appropriate delegate
13673 2001-12-24 Ravi Pratap <ravi@ximian.com>
13675 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
13676 of these as the workaround is unnecessary.
13678 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
13679 delegate data - none of that is needed at all.
13681 Re-write bits to extract the instance expression and the delegate method
13684 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
13687 * attribute.cs (ApplyAttributes): New method to take care of common tasks
13688 of attaching attributes instead of duplicating code everywhere.
13690 * everywhere : Update code to do attribute emission using the above method.
13692 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13694 * expression.cs (IsParamsMethodApplicable): if there are not
13695 parameters, return immediately.
13697 * ecore.cs: The 0 literal can be implicity converted to an enum
13700 (SimpleName.DoResolve): First lookup the type, then lookup the
13703 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
13704 want to get its address. If the InstanceExpression is not
13705 addressable, store the result in a temporary variable, then get
13708 * codegen.cs: Only display 219 errors on warning level or above.
13710 * expression.cs (ArrayAccess): Make it implement the
13711 IMemoryLocation interface.
13713 (Binary.DoResolve): handle the operator == (object a, object b)
13714 and operator != (object a, object b) without incurring into a
13715 BoxedCast (because 5 != o should never be performed).
13717 Handle binary enumerator operators.
13719 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
13720 value type, otherwise use Ldelem_ref.
13722 Use precomputed names;
13724 (AddressOf): Implement address of
13726 * cs-parser.jay (labeled_statement): Fix recursive block
13727 addition by reworking the production.
13729 * expression.cs (New.DoEmit): New has a special case:
13731 If we are dealing with a ValueType, we have a few
13732 situations to deal with:
13734 * The target of New is a ValueType variable, that is
13735 easy, we just pass this as the variable reference
13737 * The target of New is being passed as an argument,
13738 to a boxing operation or a function that takes a
13741 In this case, we need to create a temporary variable
13742 that is the argument of New.
13745 2001-12-23 Ravi Pratap <ravi@ximian.com>
13747 * rootcontext.cs (LookupType): Check that current_type is not null before
13748 going about looking at nested types.
13750 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
13751 not implement the IAssignMethod interface any more.
13753 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
13754 where we tranform them into FieldExprs if they are being resolved from within
13755 the declaring type.
13757 * ecore.cs (SimpleName.DoResolve): Do the same here.
13759 * assign.cs (DoResolve, Emit): Clean up code considerably.
13761 * ../errors/bug10.cs : Add.
13763 * ../errors/cs0070.cs : Add.
13765 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
13767 * assign.cs : Get rid of EventIsLocal everywhere.
13769 2001-12-23 Miguel de Icaza <miguel@ximian.com>
13771 * ecore.cs (ConvertIntLiteral): finished the implementation.
13773 * statement.cs (SwitchLabel): Convert the value we are using as a
13774 key before looking up the table.
13776 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13778 * codegen.cs (EmitTopBlock): Require a Location argument now.
13780 * cs-parser.jay (constructor_declarator): We need to setup
13781 current_local_parameters before we parse the
13782 opt_constructor_initializer, to allow the variables to be bound
13783 to the constructor arguments.
13785 * rootcontext.cs (LookupType): First lookup nested classes in our
13786 class and our parents before we go looking outside our class.
13788 * expression.cs (ConstantFold): Extract/debox the values at the
13791 * rootcontext.cs (EmitCode): Resolve the constants first before we
13792 resolve the types. This is not really needed, but it helps debugging.
13794 * statement.cs: report location.
13796 * cs-parser.jay: pass location to throw statement.
13798 * driver.cs: Small bug fix.
13800 * report.cs: Updated format to be 4-zero filled digits.
13802 2001-12-22 Ravi Pratap <ravi@ximian.com>
13804 * expression.cs (CheckIndices): Fix minor bug where the wrong
13805 variable was being referred to ;-)
13807 (DoEmit): Do not call EmitStaticInitializers when the
13808 underlying type is System.Object.
13810 2001-12-21 Ravi Pratap <ravi@ximian.com>
13812 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
13813 and do the usual workaround for SRE.
13815 * class.cs (MyEventBuilder.EventType): New member to get at the type
13816 of the event, quickly.
13818 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
13820 * assign.cs (Assign.DoResolve): Handle the case when the target
13821 is an EventExpr and perform the necessary checks.
13823 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
13826 (SimpleName.MemberStaticCheck): Include check for EventExpr.
13828 (EventExpr): Set the type in the constructor itself since we
13829 are meant to be born fully resolved.
13831 (EventExpr.Define): Revert code I wrote earlier.
13833 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
13834 instance expression is null. The instance expression is a This in that case
13835 or a null, depending on whether it is a static method or not.
13837 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
13838 refers to more than one method.
13840 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
13841 and accordingly flag errors.
13843 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13845 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
13847 2001-12-22 Miguel de Icaza <miguel@ximian.com>
13849 * location.cs (ToString): Provide useful rutine.
13851 2001-12-21 Miguel de Icaza <miguel@ximian.com>
13853 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
13854 objects, return the actual integral boxed.
13856 * statement.cs (SwitchLabel): define an ILLabel for each
13859 (Switch.CheckSwitch): If the value is a Literal, extract
13860 the underlying literal.
13862 Also in the unused hashtable we had, add the SwitchLabel so we can
13863 quickly look this value up.
13865 * constant.cs: Implement a bunch of new constants. Rewrite
13866 Literal based on this. Made changes everywhere to adapt to this.
13868 * expression.cs (Expression.MakeByteBlob): Optimize routine by
13869 dereferencing array only once, and also copes with enumrations.
13871 bytes are two bytes wide, not one.
13873 (Cast): Perform constant conversions.
13875 * ecore.cs (TryImplicitIntConversion): Return literals instead of
13876 wrappers to the literals here.
13878 * expression.cs (DoNumericPromotions): long literals can converted
13879 to ulong implicity (this is taken care of elsewhere, but I was
13880 missing this spot).
13882 * ecore.cs (Expression.Literalize): Make the return type Literal,
13883 to improve type checking.
13885 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
13887 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13889 * literal.cs: Revert code from ravi that checked the bounds. The
13890 bounds are sane by the definition of the type itself.
13892 * typemanager.cs: Fix implementation of ImplementsInterface. We
13893 need to actually look up in our parent hierarchy for interfaces
13896 * const.cs: Use the underlying type for enumerations
13898 * delegate.cs: Compute the basename for the delegate creation,
13899 that should fix the delegate test case, and restore the correct
13900 Type Lookup semantics in rootcontext
13902 * rootcontext.cs: Revert Ravi's last patch. The correct way of
13903 referencing a nested type with the Reflection API is using the "+"
13906 * cs-parser.jay: Do not require EOF token at the end.
13908 2001-12-20 Ravi Pratap <ravi@ximian.com>
13910 * rootcontext.cs (LookupType): Concatenate type names with
13911 a '.' instead of a '+' The test suite passes again.
13913 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
13914 field of the enumeration.
13916 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
13917 the case when the member is an EventExpr.
13919 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
13920 static has an associated instance expression.
13922 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
13924 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
13926 * class.cs (Event.Define): Register event and perform appropriate checks
13929 We define the Add and Remove methods even if the use provides none because
13930 in that case, we provide default implementations ourselves.
13932 Define a private field of the type of the event. This is done by the CSC compiler
13933 and we should be doing it too ;-)
13935 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
13936 More methods we use in code we generate.
13938 (multicast_delegate_type, delegate_type): Two separate types since the distinction
13941 (InitCoreTypes): Update accordingly for the above.
13943 * class.cs (Event.Emit): Generate code for default accessors that we provide
13945 (EmitDefaultMethod): Do the job in the above.
13947 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
13950 2001-12-20 Miguel de Icaza <miguel@ximian.com>
13952 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
13953 builders even if we were missing one.
13955 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
13956 pass the Basename as our class name instead of the Name. The
13957 basename will be correctly composed for us.
13959 * parameter.cs (Paramters): Now takes a Location argument.
13961 * decl.cs (DeclSpace.LookupType): Removed convenience function and
13962 make all the code call directly LookupType in RootContext and take
13963 this chance to pass the Location information everywhere.
13965 * Everywhere: pass Location information.
13967 2001-12-19 Miguel de Icaza <miguel@ximian.com>
13969 * class.cs (Constructor.Define): Updated way of detecting the
13970 length of the parameters.
13972 (TypeContainer.DefineType): Use basename as the type name for
13975 (TypeContainer.Define): Do not recursively define types here, as
13976 definition is taken care in order by the RootContext.
13978 * tree.cs: Keep track of namespaces in a per-file basis.
13980 * parameter.cs (Parameter.ComputeSignature): Update to use
13983 (Parameters.GetSignature): ditto.
13985 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
13986 instead of a TypeContainer.
13988 (Interface.SemanticAnalysis): Use `this' instead of our parent to
13989 resolve names. Because we need to be resolve in our context, not
13992 * driver.cs: Implement response files.
13994 * class.cs (TypeContainer.DefineType): If we are defined, do not
13995 redefine ourselves.
13997 (Event.Emit): Emit the code for add/remove handlers.
13998 (Event.Define): Save the MethodBuilders for add/remove.
14000 * typemanager.cs: Use pair here too.
14002 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
14003 DictionaryEntry requires the first argument to be non-null.
14005 (enum_declaration): Compute full name for registering the
14008 (delegate_declaration): Instead of using
14009 formal_parameter_list, use opt_formal_parameter_list as the list
14012 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
14013 (EventParsing): New property that controls whether `add' and
14014 `remove' are returned as tokens or identifiers (for events);
14016 2001-12-19 Ravi Pratap <ravi@ximian.com>
14018 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
14019 use MyEventBuilder only and let it wrap the real builder for us.
14021 (MyEventBuilder): Revamp constructor etc.
14023 Implement all operations that we perform on EventBuilder in precisely the same
14026 (FindMembers): Update to use the EventBuilder member.
14028 (Event.Emit): Update accordingly.
14030 2001-12-18 Ravi Pratap <ravi@ximian.com>
14032 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
14033 by calling the appropriate methods.
14035 (GetCustomAttributes): Make stubs as they cannot possibly do anything
14038 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
14040 2001-12-17 Ravi Pratap <ravi@ximian.com>
14042 * delegate.cs (Delegate.Populate): Check that the return type
14043 and various parameters types are indeed accessible.
14045 * class.cs (Constructor.Define): Same here.
14047 (Field.Define): Ditto.
14049 (Event.Define): Ditto.
14051 (Operator.Define): Check that the underlying Method defined itself
14052 correctly - so it's MethodBuilder should not be null.
14054 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
14055 expression happens to be null.
14057 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
14058 members but as of now we don't seem to be able to do anything really useful with it.
14060 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
14061 not the EventBuilder.
14063 2001-12-18 Miguel de Icaza <miguel@ximian.com>
14065 * cs-tokenizer.cs: Add support for defines.
14066 Add support for #if, #elif, #else, #endif
14068 (eval_var): evaluates a variable.
14069 (eval): stubbed for evaluating functions.
14071 * cs-parser.jay: Pass the defines information
14073 * driver.cs: Add --define command line option.
14075 * decl.cs: Move MemberCore here.
14077 Make it the base class for DeclSpace. This allows us to catch and
14078 report 108 and 109 for everything now.
14080 * class.cs (TypeContainer.Define): Extract all the members
14081 before populating and emit the warning 108 (new keyword required
14082 to override) instead of having each member implement this.
14084 (MemberCore.Define): New abstract method, we will be using this in
14085 the warning reporting engine in Populate.
14087 (Operator.Define): Adjust to new MemberCore protocol.
14089 * const.cs (Const): This does not derive from Expression, it is a
14090 temporary object we use to create fields, it is a MemberCore.
14092 * class.cs (Method.Define): Allow the entry point to be in a
14095 * driver.cs: Rewrite the argument handler to clean it up a bit.
14097 * rootcontext.cs: Made it just an auxiliary namespace feature by
14098 making everything static.
14100 * driver.cs: Adapt code to use RootContext type name instead of
14103 * delegate.cs: Remove RootContext argument.
14105 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
14108 * class.cs (Event.Define): The lookup can fail.
14110 * cs-tokenizer.cs: Begin implementation of pre-procesor.
14112 * expression.cs: Resolve the this instance before invoking the code.
14114 2001-12-17 Miguel de Icaza <miguel@ximian.com>
14116 * cs-parser.jay: Add a production in element_access that allows
14117 the thing to become a "type" reference. This way we can parse
14118 things like "(string [])" as a type.
14120 Note that this still does not handle the more complex rules of
14124 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
14126 * ecore.cs: (CopyNewMethods): new utility function used to
14127 assemble the list of methods from running FindMembers.
14129 (MemberLookup): Rework FindMembers so that
14131 2001-12-16 Miguel de Icaza <miguel@ximian.com>
14133 * class.cs (TypeContainer): Remove Delegates who fail to be
14136 * delegate.cs (Populate): Verify that we dont get null return
14137 values. TODO: Check for AsAccessible.
14139 * cs-parser.jay: Use basename to emit error 574 (destructor should
14140 have the same name as container class), not the full name.
14142 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
14143 possible representation.
14145 Also implements integer type suffixes U and L.
14147 2001-12-15 Miguel de Icaza <miguel@ximian.com>
14149 * expression.cs (ArrayCreation.DoResolve): We need to do the
14150 argument resolution *always*.
14152 * decl.cs: Make this hold the namespace. Hold the root context as
14154 (LookupType): Move here.
14156 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
14158 * location.cs (Row, Name): Fixed the code, it was always returning
14159 references to the first file.
14161 * interface.cs: Register properties defined through interfaces.
14163 * driver.cs: Add support for globbing on the command line
14165 * class.cs (Field): Make it derive from MemberCore as well.
14168 2001-12-15 Ravi Pratap <ravi@ximian.com>
14170 * class.cs (Event::Define): Check that the type of the event is a delegate
14171 type else flag error #66.
14173 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
14176 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
14177 values of EntryPoint, CharSet etc etc.
14179 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
14181 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
14182 be null and we should ignore this. I am not sure if this is really clean. Apparently,
14183 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
14184 which needs this to do its work.
14186 * ../errors/cs0066.cs : Add.
14188 2001-12-14 Miguel de Icaza <miguel@ximian.com>
14190 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
14193 * class.cs: (MethodSignature.MethodSignature): Removed hack that
14194 clears out the parameters field.
14195 (MemberSignatureCompare): Cleanup
14197 (MemberCore): New base class used to share code between MethodCore
14200 (RegisterRequiredImplementations) BindingFlags.Public requires
14201 either BindingFlags.Instace or Static. Use instance here.
14203 (Property): Refactored code to cope better with the full spec.
14205 * parameter.cs (GetParameterInfo): Return an empty array instead
14208 * class.cs (Property): Abstract or extern properties have no bodies.
14210 * parameter.cs (GetParameterInfo): return a zero-sized array.
14212 * class.cs (TypeContainer.MethodModifiersValid): Move all the
14213 method modifier validation to the typecontainer so we can reuse
14214 this on properties.
14216 (MethodCore.ParameterTypes): return an empty sized array of types.
14218 (Property.Define): Test property modifier validity.
14220 Add tests for sealed/override too.
14222 (Method.Emit): abstract or extern methods have no bodies.
14224 2001-12-14 Ravi Pratap <ravi@ximian.com>
14226 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
14229 (Method::Define, ::Emit): Modify accordingly.
14231 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
14233 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
14235 * makefile: Pass in /unsafe.
14237 2001-12-13 Miguel de Icaza <miguel@ximian.com>
14239 * class.cs (MakeKey): Kill routine.
14241 * class.cs (TypeContainer.Define): Correctly define explicit
14242 method implementations (they require the full interface name plus
14245 * typemanager.cs: Deply the PtrHashtable here and stop using the
14246 lame keys. Things work so much better.
14248 This of course broke everyone who depended on `RegisterMethod' to
14249 do the `test for existance' test. This has to be done elsewhere.
14251 * support.cs (PtrHashtable): A hashtable that avoid comparing with
14252 the object stupid Equals method (because, that like fails all over
14253 the place). We still do not use it.
14255 * class.cs (TypeContainer.SetRequiredInterface,
14256 TypeContainer.RequireMethods): Killed these two routines and moved
14257 all the functionality to RegisterRequiredImplementations.
14259 (TypeContainer.RegisterRequiredImplementations): This routine now
14260 registers all the implementations required in an array for the
14261 interfaces and abstract methods. We use an array of structures
14262 which can be computed ahead of time to reduce memory usage and we
14263 also assume that lookups are cheap as most classes will not
14264 implement too many interfaces.
14266 We also avoid creating too many MethodSignatures.
14268 (TypeContainer.IsInterfaceMethod): Update and optionally does not
14269 clear the "pending" bit if we find that there are problems with
14272 (TypeContainer.VerifyPendingMethods): Update to report errors of
14273 methods that look like implementations but are not.
14275 (TypeContainer.Define): Add support for explicit interface method
14278 2001-12-12 Miguel de Icaza <miguel@ximian.com>
14280 * typemanager.cs: Keep track of the parameters here instead of
14281 being a feature of the TypeContainer.
14283 * class.cs: Drop the registration of parameters here, as
14284 InterfaceMethods are also interface declarations.
14286 * delegate.cs: Register methods with the TypeManager not only with
14287 the TypeContainer. This code was buggy.
14289 * interface.cs: Full registation here.
14291 2001-12-11 Miguel de Icaza <miguel@ximian.com>
14293 * expression.cs: Remove reducer for binary expressions, it can not
14296 * const.cs: Put here the code that used to go into constant.cs
14298 * constant.cs: Put here the code for constants, this is a new base
14299 class for Literals.
14301 * literal.cs: Make Literal derive from Constant.
14303 2001-12-09 Miguel de Icaza <miguel@ximian.com>
14305 * statement.cs (Return.Emit): Report error 157 if the user
14306 attempts to return from a finally block.
14308 (Return.Emit): Instead of emitting a return, jump to the end of
14311 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
14312 LocalBuilder to store the result of the function. ReturnLabel is
14313 the target where we jump.
14316 2001-12-09 Radek Doulik <rodo@ximian.com>
14318 * cs-parser.jay: remember alias in current namespace
14320 * ecore.cs (SimpleName::DoResolve): use aliases for types or
14323 * class.cs (LookupAlias): lookup alias in my_namespace
14325 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
14327 (LookupAlias): lookup alias in this and if needed in parent
14330 2001-12-08 Miguel de Icaza <miguel@ximian.com>
14334 * rootcontext.cs: (ModuleBuilder) Made static, first step into
14335 making things static. I need this to avoid passing the
14336 TypeContainer when calling ParameterType.
14338 * support.cs (InternalParameters.ParameterType): Remove ugly hack
14339 that did string manipulation to compute the type and then call
14340 GetType. Use Parameter.ParameterType instead.
14342 * cs-tokenizer.cs: Consume the suffix for floating values.
14344 * expression.cs (ParameterReference): figure out whether this is a
14345 reference parameter or not. Kill an extra variable by computing
14346 the arg_idx during emission.
14348 * parameter.cs (Parameters.GetParameterInfo): New overloaded
14349 function that returns whether a parameter is an out/ref value or not.
14351 (Parameter.ParameterType): The type of the parameter (base,
14352 without ref/out applied).
14354 (Parameter.Resolve): Perform resolution here.
14355 (Parameter.ExternalType): The full type (with ref/out applied).
14357 * statement.cs (Using.Emit, Using.EmitExpression): Implement
14358 support for expressions on the using statement.
14360 2001-12-07 Miguel de Icaza <miguel@ximian.com>
14362 * statement.cs (Using.EmitLocalVariableDecls): Split the
14363 localvariable handling of the using statement.
14365 (Block.EmitMeta): Keep track of variable count across blocks. We
14366 were reusing slots on separate branches of blocks.
14368 (Try.Emit): Emit the general code block, we were not emitting it.
14370 Check the type of the declaration to be an IDisposable or
14371 something that can be implicity converted to it.
14373 Emit conversions if required.
14375 * ecore.cs (EmptyExpression): New utility class.
14376 (Expression.ImplicitConversionExists): New utility function.
14378 2001-12-06 Miguel de Icaza <miguel@ximian.com>
14380 * statement.cs (Using): Implement.
14382 * expression.cs (LocalVariableReference): Support read only variables.
14384 * statement.cs: Remove the explicit emit for the Leave opcode.
14385 (VariableInfo): Add a readonly field.
14387 2001-12-05 Miguel de Icaza <miguel@ximian.com>
14389 * ecore.cs (ConvCast): new class used to encapsulate the various
14390 explicit integer conversions that works in both checked and
14391 unchecked contexts.
14393 (Expression.ConvertNumericExplicit): Use new ConvCast class to
14394 properly generate the overflow opcodes.
14396 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14398 * statement.cs: The correct type for the EmptyExpression is the
14399 element_type, not the variable type. Ravi pointed this out.
14401 2001-12-04 Ravi Pratap <ravi@ximian.com>
14403 * class.cs (Method::Define): Handle PInvoke methods specially
14404 by using DefinePInvokeMethod instead of the usual one.
14406 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
14407 above to do the task of extracting information and defining the method.
14409 2001-12-04 Ravi Pratap <ravi@ximian.com>
14411 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
14412 of the condition for string type.
14414 (Emit): Move that here.
14416 (ArrayCreation::CheckIndices): Keep string literals in their expression
14419 (EmitDynamicInitializers): Handle strings appropriately.
14421 2001-12-04 Miguel de Icaza <miguel@ximian.com>
14423 * codegen.cs (EmitContext): Replace multiple variables with a
14424 single pointer to the current Switch statement.
14426 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
14429 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14433 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
14436 (Foreach.Emit): Foreach on arrays was not setting
14437 up the loop variables (for break/continue).
14439 (GotoCase): Semi-implented.
14441 2001-12-03 Ravi Pratap <ravi@ximian.com>
14443 * attribute.cs (CheckAttribute): Handle system attributes by using
14444 Attribute.GetAttributes to examine information we need.
14446 (GetValidPlaces): Same here.
14448 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
14450 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
14452 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
14454 (Method::Define): Set appropriate flags if we have a DllImport attribute.
14456 (Method::Emit): Handle the case when we are a PInvoke method.
14458 2001-12-03 Miguel de Icaza <miguel@ximian.com>
14460 * expression.cs: Use ResolveWithSimpleName on compound names.
14462 2001-12-02 Ravi Pratap <ravi@ximian.com>
14464 * constant.cs (EmitConstant): Make sure we resolve the associated expression
14465 before trying to reduce it.
14467 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
14469 * constant.cs (LookupConstantValue): Implement.
14471 (EmitConstant): Use the above in emitting the constant.
14473 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
14474 that are user-defined by doing a LookupConstantValue on them.
14476 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
14479 2001-11-29 Miguel de Icaza <miguel@ximian.com>
14481 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
14483 (BaseAccess.DoResolve): Implement.
14485 (MemberAccess.DoResolve): Split this routine into a
14486 ResolveMemberAccess routine that can be used independently
14488 2001-11-28 Miguel de Icaza <miguel@ximian.com>
14490 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
14491 As that share bits of the implementation. Is returns a boolean,
14492 while As returns the Type that is being probed.
14494 2001-12-01 Ravi Pratap <ravi@ximian.com>
14496 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
14497 instead of a Literal - much easier.
14499 (EnumInTransit): Remove - utterly useless :-)
14501 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
14503 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
14505 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
14506 chain when we have no associated expression.
14508 2001-11-30 Ravi Pratap <ravi@ximian.com>
14510 * constant.cs (Define): Use Location while reporting the errror.
14512 Also emit a warning when 'new' is used and there is no inherited
14515 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
14518 (LookupEnumValue): Implement to lookup an enum member's value and define it
14521 (Populate): Re-write accordingly to use the above routine.
14523 2001-11-27 Miguel de Icaza <miguel@ximian.com>
14525 * expression.cs (This): Fix prototype for DoResolveLValue to
14526 override the base class DoResolveLValue.
14528 * cs-parser.cs: Report errors cs574 and cs575 (destructor
14531 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
14532 (we need to load the address of the field here). This fixes
14535 (FieldExpr.DoResolveLValue): Call the DoResolve
14536 function to initialize the Instance expression.
14538 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
14539 correctly the GetEnumerator operation on a value type.
14541 * cs-parser.jay: Add more simple parsing error catches.
14543 * statement.cs (Switch): Add support for string switches.
14544 Handle null specially.
14546 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
14548 2001-11-28 Ravi Pratap <ravi@ximian.com>
14550 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
14552 (declare_local_constant): New helper function.
14554 * statement.cs (AddConstant): Keep a separate record of constants
14556 (IsConstant): Implement to determine if a variable is a constant.
14558 (GetConstantExpression): Implement.
14560 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
14562 * statement.cs (IsVariableDefined): Re-write.
14564 2001-11-27 Ravi Pratap <ravi@ximian.com>
14566 * class.cs (TypeContainer::FindMembers): Look for constants
14567 in the case when we are looking for MemberTypes.Field
14569 * expression.cs (MemberAccess::DoResolve): Check that in the
14570 case we are a FieldExpr and a Literal, we are not being accessed
14571 by an instance reference.
14573 * cs-parser.jay (local_constant_declaration): Implement.
14575 (declaration_statement): Implement for constant declarations.
14577 2001-11-26 Miguel de Icaza <miguel@ximian.com>
14579 * statement.cs (Switch): Catch double defaults.
14581 (Switch): More work on the switch() statement
14582 implementation. It works for integral values now, need to finish
14586 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14588 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
14589 integer literals into other integer literals. To be used by
14592 2001-11-24 Ravi Pratap <ravi@ximian.com>
14594 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
14597 (EmitDynamicInitializers): Cope with the above since we extract data
14598 directly from ArrayData now.
14600 (ExpectInitializers): Keep track of whether initializers are mandatory
14603 (Bounds): Make it a hashtable to prevent the same dimension being
14604 recorded for every element in that dimension.
14606 (EmitDynamicInitializers): Fix bug which prevented the Set array method
14609 Also fix bug which was causing the indices to be emitted in the reverse
14612 2001-11-24 Miguel de Icaza <miguel@ximian.com>
14614 * expression.cs (ArrayCreation): Implement the bits that Ravi left
14615 unfinished. They do not work, because the underlying code is
14618 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14620 * cs-parser.jay: Remove bogus fixme.
14622 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
14623 on Switch statement.
14625 2001-11-23 Ravi Pratap <ravi@ximian.com>
14627 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
14630 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
14631 parameter. Apparently, any expression is allowed.
14633 (ValidateInitializers): Update accordingly.
14635 (CheckIndices): Fix some tricky bugs thanks to recursion.
14637 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
14638 I was being completely brain-dead.
14640 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
14641 and re-write acordingly.
14643 (DelegateInvocation): Re-write accordingly.
14645 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
14647 (MakeByteBlob): Handle types more correctly.
14649 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
14650 initialization from expressions but it is incomplete because I am a complete
14653 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14655 * statement.cs (If.Emit): Fix a bug that generated incorrect code
14656 on If. Basically, we have to return `true' (ie, we do return to
14657 our caller) only if both branches of the if return.
14659 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
14660 short-circuit operators, handle them as short circuit operators.
14662 (Cast.DoResolve): Resolve type.
14663 (Cast.Cast): Take an expression as the target type.
14665 * cs-parser.jay (cast_expression): Remove old hack that only
14666 allowed a limited set of types to be handled. Now we take a
14667 unary_expression and we resolve to a type during semantic
14670 Use the grammar productions from Rhys to handle casts (this is
14671 not complete like Rhys syntax yet, we fail to handle that corner
14672 case that C# has regarding (-x), but we will get there.
14674 2001-11-22 Ravi Pratap <ravi@ximian.com>
14676 * class.cs (EmitFieldInitializer): Take care of the case when we have a
14677 field which is an array type.
14679 * cs-parser.jay (declare_local_variables): Support array initialization too.
14681 * typemanager.cs (MakeKey): Implement.
14683 (everywhere): Use the above appropriately.
14685 * cs-parser.jay (for_statement): Update for array initialization while
14686 declaring variables.
14688 * ecore.cs : The error message was correct, it's the variable's names that
14689 were misleading ;-) Make the code more readable.
14691 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
14692 the correct type etc.
14694 (ConvertExplicit): Handle Enum types by examining the underlying type.
14696 2001-11-21 Ravi Pratap <ravi@ximian.com>
14698 * parameter.cs (GetCallingConvention): Always return
14699 CallingConventions.Standard for now.
14701 2001-11-22 Miguel de Icaza <miguel@ximian.com>
14703 * expression.cs (Binary.ResolveOperator): Update the values of `l'
14704 and `r' after calling DoNumericPromotions.
14706 * ecore.cs: Fix error message (the types were in the wrong order).
14708 * statement.cs (Foreach.ProbeCollectionType): Need to pass
14709 BindingFlags.Instance as well
14711 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
14712 implicit int literal conversion in an empty cast so that we
14713 propagate the right type upstream.
14715 (UnboxCast): new class used to unbox value types.
14716 (Expression.ConvertExplicit): Add explicit type conversions done
14719 (Expression.ImplicitNumericConversion): Oops, forgot to test for
14720 the target type before applying the implicit LongLiterals to ULong
14723 2001-11-21 Miguel de Icaza <miguel@ximian.com>
14725 * cs-parser.jay (for_statement): Reworked the way For works: now
14726 we declare manually any variables that are introduced in
14727 for_initializer to solve the problem of having out-of-band code
14728 emition (that is what got for broken).
14730 (declaration_statement): Perform the actual variable declaration
14731 that used to be done in local_variable_declaration here.
14733 (local_variable_declaration): Do not declare anything, just pass
14734 the information on a DictionaryEntry
14736 2001-11-20 Ravi Pratap <ravi@ximian.com>
14738 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
14739 re-write of the logic to now make it recursive.
14741 (UpdateIndices): Re-write accordingly.
14743 Store element data in a separate ArrayData list in the above methods.
14745 (MakeByteBlob): Implement to dump the array data into a byte array.
14747 2001-11-19 Ravi Pratap <ravi@ximian.com>
14749 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
14752 * constant.cs (Define): Implement.
14754 (EmitConstant): Re-write fully.
14756 Pass in location info.
14758 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
14761 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
14762 DictionaryEntry since we need location info too.
14764 (constant_declaration): Update accordingly.
14766 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
14767 code into another method : UpdateIndices.
14769 2001-11-18 Ravi Pratap <ravi@ximian.com>
14771 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
14772 some type checking etc.
14774 2001-11-17 Ravi Pratap <ravi@ximian.com>
14776 * expression.cs (ArrayCreation::ValidateInitializers): Implement
14777 bits to provide dimension info if the user skips doing that.
14779 Update second constructor to store the rank correctly.
14781 2001-11-16 Ravi Pratap <ravi@ximian.com>
14783 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
14784 and try to implement.
14786 * ../errors/cs0150.cs : Add.
14788 * ../errors/cs0178.cs : Add.
14790 2001-11-16 Miguel de Icaza <miguel@ximian.com>
14792 * statement.cs: Implement foreach on multi-dimensional arrays.
14794 * parameter.cs (Parameters.GetParameterByName): Also lookup the
14795 name of the params argument.
14797 * expression.cs: Use EmitStoreOpcode to get the right opcode while
14798 initializing the array.
14800 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
14801 we can use this elsewhere.
14803 * statement.cs: Finish implementation of foreach for single
14806 * cs-parser.jay: Use an out-of-band stack to pass information
14807 around, I wonder why I need this.
14809 foreach_block: Make the new foreach_block the current_block.
14811 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
14812 function used to return a static Parameters structure. Used for
14813 empty parameters, as those are created very frequently.
14815 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
14817 2001-11-15 Ravi Pratap <ravi@ximian.com>
14819 * interface.cs : Default modifier is private, not public. The
14820 make verify test passes again.
14822 2001-11-15 Ravi Pratap <ravi@ximian.com>
14824 * support.cs (ReflectionParameters): Fix logic to determine
14825 whether the last parameter is a params one. Test 9 passes again.
14827 * delegate.cs (Populate): Register the builders we define with
14828 RegisterParameterForBuilder. Test 19 passes again.
14830 * cs-parser.jay (property_declaration): Reference $6 instead
14831 of $$ to get at the location.
14833 (indexer_declaration): Similar stuff.
14835 (attribute): Ditto.
14837 * class.cs (Property): Register parameters for the Get and Set methods
14838 if they exist. Test 23 passes again.
14840 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
14841 call to EmitArguments as we are sure there aren't any params arguments.
14842 Test 32 passes again.
14844 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
14845 IndexOutOfRangeException.
14847 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
14848 Test 33 now passes again.
14850 2001-11-15 Miguel de Icaza <miguel@ximian.com>
14852 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
14853 broke a bunch of things. Will have to come up with a better way
14854 of tracking locations.
14856 * statement.cs: Implemented foreach for single dimension arrays.
14858 2001-11-09 Miguel de Icaza <miguel@ximian.com>
14860 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
14861 an error. This removes the lookup from the critical path.
14863 * cs-parser.jay: Removed use of temporary_loc, which is completely
14866 2001-11-14 Miguel de Icaza <miguel@ximian.com>
14868 * support.cs (ReflectionParameters.ParameterModifier): Report
14869 whether the argument is a PARAMS argument or not.
14871 * class.cs: Set the attribute `ParamArrayAttribute' on the
14872 parameter argument.
14874 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
14875 and cons_param_array_attribute (ConstructorInfo for
14876 ParamArrayAttribute).,
14878 * codegen.cs: Emit the return using the `Return' statement, that
14879 way we can report the error correctly for missing return values.
14881 * class.cs (Method.Emit): Clean up.
14883 * expression.cs (Argument.Resolve): Take another argument: the
14884 location where this argument is used. Notice that this is not
14885 part of the "Argument" class as to reduce the size of the
14886 structure (we know the approximate location anyways).
14888 Test if the argument is a variable-reference, if not, then
14889 complain with a 206.
14891 (Argument.Emit): Emit addresses of variables.
14893 (Argument.FullDesc): Simplify.
14895 (Invocation.DoResolve): Update for Argument.Resolve.
14897 (ElementAccess.DoResolve): ditto.
14899 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
14900 method should be virtual, as this method is always virtual.
14902 (NewDelegate.DoResolve): Update for Argument.Resolve.
14904 * class.cs (ConstructorInitializer.DoResolve): ditto.
14906 * attribute.cs (Attribute.Resolve): ditto.
14908 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14910 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
14912 * expression.cs (ParameterReference): Drop IStackStorage and implement
14913 IAssignMethod instead.
14915 (LocalVariableReference): ditto.
14917 * ecore.cs (FieldExpr): Drop IStackStorage and implement
14918 IAssignMethod instead.
14920 2001-11-13 Miguel de Icaza <miguel@ximian.com>
14922 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
14923 enumerations that are used in heavily used structures derive from
14924 byte in a laughable and pathetic attempt to reduce memory usage.
14925 This is the kind of pre-optimzations that you should not do at
14926 home without adult supervision.
14928 * expression.cs (UnaryMutator): New class, used to handle ++ and
14929 -- separatedly from the other unary operators. Cleans up the
14930 code, and kills the ExpressionStatement dependency in Unary.
14932 (Unary): Removed `method' and `Arguments' from this class, making
14933 it smaller, and moving it all to SimpleCall, so I can reuse this
14934 code in other locations and avoid creating a lot of transient data
14935 strucutres when not required.
14937 * cs-parser.jay: Adjust for new changes.
14939 2001-11-11 Miguel de Icaza <miguel@ximian.com>
14941 * enum.cs (Enum.Populate): If there is a failure during
14944 * cs-parser.jay (opt_enum_base): we used to catch type errors
14945 here, but this is really incorrect. The type error should be
14946 catched during semantic analysis.
14948 2001-12-11 Ravi Pratap <ravi@ximian.com>
14950 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
14951 current_local_parameters as expected since I, in my stupidity, had forgotten
14954 * attribute.cs (GetValidPlaces): Fix stupid bug.
14956 * class.cs (Method::Emit): Perform check on applicability of attributes.
14958 (Constructor::Emit): Ditto.
14960 (Field::Emit): Ditto.
14962 (Field.Location): Store location information.
14964 (Property, Event, Indexer, Operator): Ditto.
14966 * cs-parser.jay (field_declaration): Pass in location for each field.
14968 * ../errors/cs0592.cs : Add.
14970 2001-11-12 Ravi Pratap <ravi@ximian.com>
14972 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
14974 (InitCoreTypes): Update accordingly.
14976 (RegisterAttrType, LookupAttr): Implement.
14978 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
14979 info about the same.
14981 (Resolve): Update to populate the above as necessary.
14983 (Error592): Helper.
14985 (GetValidPlaces): Helper to the above.
14987 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
14989 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
14991 2001-11-12 Ravi Pratap <ravi@ximian.com>
14993 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
14995 * ../errors/cs0617.cs : Add.
14997 2001-11-11 Ravi Pratap <ravi@ximian.com>
14999 * enum.cs (Emit): Rename to Populate to be more consistent with what
15000 we expect it to do and when exactly it is called.
15002 * class.cs, rootcontext.cs : Update accordingly.
15004 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
15005 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
15007 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
15009 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
15010 of a fieldinfo using the above, when dealing with a FieldBuilder.
15012 2001-11-10 Ravi Pratap <ravi@ximian.com>
15014 * ../errors/cs0031.cs : Add.
15016 * ../errors/cs1008.cs : Add.
15018 * ../errrors/cs0543.cs : Add.
15020 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
15023 (FindMembers): Implement.
15025 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
15026 enums and delegates too.
15028 (enum_types): Rename to builder_to_enum.
15030 (delegate_types): Rename to builder_to_delegate.
15032 * delegate.cs (FindMembers): Implement.
15034 2001-11-09 Ravi Pratap <ravi@ximian.com>
15036 * typemanager.cs (IsEnumType): Implement.
15038 * enum.cs (Emit): Re-write parts to account for the underlying type
15039 better and perform checking etc.
15041 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
15042 of the underlying type.
15044 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
15047 * enum.cs (error31): Helper to report error #31.
15049 * cs-parser.jay (enum_declaration): Store location of each member too.
15051 * enum.cs (member_to_location): New hashtable.
15053 (AddEnumMember): Update location hashtable.
15055 (Emit): Use the location of each member while reporting errors.
15057 2001-11-09 Miguel de Icaza <miguel@ximian.com>
15059 * cs-parser.jay: A for_initializer if is a
15060 local_variable_declaration really ammount to have an implicit
15061 block with the variable declaration and no initializer for for.
15063 * statement.cs (For.Emit): Cope with null initializers.
15065 This fixes the infinite loop on for initializers.
15067 2001-11-08 Miguel de Icaza <miguel@ximian.com>
15069 * enum.cs: More cleanup.
15071 * ecore.cs: Remove dead code.
15073 * class.cs (Property.Emit): More simplification.
15074 (Event.Emit): ditto.
15076 Reworked to have less levels of indentation.
15078 2001-11-08 Ravi Pratap <ravi@ximian.com>
15080 * class.cs (Property): Emit attributes.
15090 * enum.cs (Emit): Ditto.
15092 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
15095 * class.cs (Field, Event, etc.): Move attribute generation into the
15096 Emit method everywhere.
15098 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
15099 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
15100 as we had no way of defining nested enums !
15102 * rootcontext.cs : Adjust code accordingly.
15104 * typemanager.cs (AddEnumType): To keep track of enum types separately.
15106 2001-11-07 Ravi Pratap <ravi@ximian.com>
15108 * expression.cs (EvalConstantExpression): Move into ecore.cs
15110 * enum.cs (Enum): Rename some members and make them public and readonly
15111 according to our convention.
15113 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
15116 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
15118 (Enum::Emit): Write a simple version for now which doesn't try to compute
15119 expressions. I shall modify this to be more robust in just a while.
15121 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
15123 (TypeContainer::CloseType): Create the Enum types too.
15125 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
15127 * expression.cs (EvalConstantExpression): Get rid of completely.
15129 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
15130 user-defined values and other cases.
15132 (IsValidEnumLiteral): Helper function.
15134 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
15135 out there in the case we had a literal FieldExpr.
15137 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
15139 (Literalize): Revamp a bit to take two arguments.
15141 (EnumLiteral): New class which derives from Literal to wrap enum literals.
15143 2001-11-06 Ravi Pratap <ravi@ximian.com>
15145 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
15147 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
15149 (Resolve): Use the above to ensure we have proper initializers.
15151 2001-11-05 Ravi Pratap <ravi@ximian.com>
15153 * expression.cs (Expression::EvalConstantExpression): New method to
15154 evaluate constant expressions.
15156 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
15158 2001-11-07 Miguel de Icaza <miguel@ximian.com>
15160 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
15163 (Binary.ResolveOperator): Handle operator != (object a, object b)
15164 and operator == (object a, object b);
15166 (Binary.DoNumericPromotions): Indicate whether the numeric
15167 promotion was possible.
15169 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
15172 Made the ArrayAccess implement interface IAssignMethod instead of
15173 IStackStore as the order in which arguments are passed reflects
15176 * assign.cs: Instead of using expr.ExprClass to select the way of
15177 assinging, probe for the IStackStore/IAssignMethod interfaces.
15179 * typemanager.cs: Load InitializeArray definition.
15181 * rootcontext.cs (RootContext.MakeStaticData): Used to define
15182 static data that can be used to initialize arrays.
15184 2001-11-05 Miguel de Icaza <miguel@ximian.com>
15186 * expression.cs: Handle operator== and operator!= for booleans.
15188 (Conditioal.Reduce): Implement reducer for the ?: operator.
15190 (Conditional.Resolve): Implement dead code elimination.
15192 (Binary.Resolve): Catch string literals and return a new
15193 concatenated string.
15195 (Unary.Reduce): Implement reduction of unary expressions.
15197 * ecore.cs: Split out the expression core handling here.
15199 (Expression.Reduce): New method used to perform constant folding
15200 and CSE. This is needed to support constant-expressions.
15202 * statement.cs (Statement.EmitBoolExpression): Pass true and false
15203 targets, and optimize for !x.
15205 2001-11-04 Ravi Pratap <ravi@ximian.com>
15207 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
15208 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
15209 set custom atttributes.
15211 * literal.cs (Literal::GetValue): New abstract method to return the actual
15212 value of the literal, cast as an object.
15214 (*Literal): Implement GetValue method.
15216 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
15217 expressions to the arraylist but objects of type Argument.
15219 * class.cs (TypeContainer::Emit): Emit our attributes too.
15221 (Method::Emit, Constructor::Emit): Ditto.
15223 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
15224 to be ignoring earlier.
15226 2001-11-03 Ravi Pratap <ravi@ximian.com>
15228 * attribute.cs (AttributeSection::Define): Implement to do the business
15229 of constructing a CustomAttributeBuilder.
15231 (Attribute): New trivial class. Increases readability of code.
15233 * cs-parser.jay : Update accordingly.
15235 (positional_argument_list, named_argument_list, named_argument): New rules
15237 (attribute_arguments): Use the above so that we are more correct.
15239 2001-11-02 Ravi Pratap <ravi@ximian.com>
15241 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
15242 to perform all checks for a method with a params parameter.
15244 (Invocation::OverloadResolve): Update to use the above method and therefore
15245 cope correctly with params method invocations.
15247 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
15250 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
15251 constructors in our parent too because we can't afford to miss out on
15254 * attribute.cs (AttributeSection): New name for the class Attribute
15256 Other trivial changes to improve readability.
15258 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
15259 use the new class names.
15261 2001-11-01 Ravi Pratap <ravi@ximian.com>
15263 * class.cs (Method::Define): Complete definition for params types too
15265 (Indexer::Define): Ditto.
15267 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
15268 Cope everywhere with a request for info about the array parameter.
15270 2001-11-01 Ravi Pratap <ravi@ximian.com>
15272 * tree.cs (RecordNamespace): Fix up to check for the correct key.
15274 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
15275 local_variable_type to extract the string corresponding to the type.
15277 (local_variable_type): Fixup the action to use the new helper method.
15279 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
15282 * expression.cs : Clean out code which uses the above.
15284 2001-10-31 Ravi Pratap <ravi@ximian.com>
15286 * typemanager.cs (RegisterMethod): Check if we already have an existing key
15287 and bale out if necessary by returning a false.
15289 (RegisterProperty): Ditto.
15291 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
15292 and print out appropriate error messages.
15294 * interface.cs (everywhere): Ditto.
15296 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
15297 location to constructor.
15299 * class.cs (Property, Event, Indexer): Update accordingly.
15301 * ../errors/cs111.cs : Added.
15303 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
15304 of a method, as laid down by the spec.
15306 (Invocation::OverloadResolve): Use the above method.
15308 2001-10-31 Ravi Pratap <ravi@ximian.com>
15310 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
15311 now take a TypeContainer and a Parameters object.
15313 (ParameterData): Modify return type of ParameterModifier method to be
15314 Parameter.Modifier and not a string.
15316 (ReflectionParameters, InternalParameters): Update accordingly.
15318 * expression.cs (Argument::GetParameterModifier): Same here.
15320 * support.cs (InternalParameters::ParameterType): Find a better way of determining
15321 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
15322 symbol in it at all so maybe this is only for now.
15324 2001-10-30 Ravi Pratap <ravi@ximian.com>
15326 * support.cs (InternalParameters): Constructor now takes an extra argument
15327 which is the actual Parameters class.
15329 (ParameterDesc): Update to provide info on ref/out modifiers.
15331 * class.cs (everywhere): Update call to InternalParameters to pass in
15332 the second argument too.
15334 * support.cs (ParameterData): Add ParameterModifier, which is a method
15335 to return the modifier info [ref/out etc]
15337 (InternalParameters, ReflectionParameters): Implement the above.
15339 * expression.cs (Argument::ParameterModifier): Similar function to return
15340 info about the argument's modifiers.
15342 (Invocation::OverloadResolve): Update to take into account matching modifiers
15345 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
15346 a new SetFormalParameters object which we pass to InternalParameters.
15348 2001-10-30 Ravi Pratap <ravi@ximian.com>
15350 * expression.cs (NewArray): Merge into the ArrayCreation class.
15352 2001-10-29 Ravi Pratap <ravi@ximian.com>
15354 * expression.cs (NewArray): Merge classes NewBuiltinArray and
15355 NewUserdefinedArray into one as there wasn't much of a use in having
15358 * expression.cs (Argument): Change field's name to ArgType from Type.
15360 (Type): New readonly property which returns the proper type, taking into
15361 account ref/out modifiers.
15363 (everywhere): Adjust code accordingly for the above.
15365 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
15366 whether we are emitting for a ref or out parameter.
15368 * expression.cs (Argument::Emit): Use the above field to set the state.
15370 (LocalVariableReference::Emit): Update to honour the flag and emit the
15373 * parameter.cs (Attributes): Set the correct flags for ref parameters.
15375 * expression.cs (Argument::FullDesc): New function to provide a full desc.
15377 * support.cs (ParameterData): Add method ParameterDesc to the interface.
15379 (ReflectionParameters, InternalParameters): Implement the above method.
15381 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
15384 (Invocation::FullMethodDesc): Ditto.
15386 2001-10-29 Miguel de Icaza <miguel@ximian.com>
15388 * cs-parser.jay: Add extra production for the second form of array
15391 * expression.cs (ArrayCreation): Update to reflect the above
15394 * Small changes to prepare for Array initialization.
15396 2001-10-28 Miguel de Icaza <miguel@ximian.com>
15398 * typemanager.cs (ImplementsInterface): interface might be null;
15399 Deal with this problem;
15401 Also, we do store negative hits on the cache (null values), so use
15402 this instead of calling t.GetInterfaces on the type everytime.
15404 2001-10-28 Ravi Pratap <ravi@ximian.com>
15406 * typemanager.cs (IsBuiltinType): New method to help determine the same.
15408 * expression.cs (New::DoResolve): Get rid of array creation code and instead
15409 split functionality out into different classes.
15411 (New::FormArrayType): Move into NewBuiltinArray.
15413 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
15416 (NewBuiltinArray): New class to handle creation of built-in arrays.
15418 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
15419 account creation of one-dimensional arrays.
15421 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
15423 (NewUserdefinedArray::DoResolve): Implement.
15425 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
15427 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
15428 we maintain inside the TypeManager. This is necessary to perform lookups on the
15431 (LookupType): Update to perform GetType on the module builders too.
15433 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
15435 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
15437 2001-10-23 Ravi Pratap <ravi@ximian.com>
15439 * expression.cs (New::DoResolve): Implement guts of array creation.
15441 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
15443 2001-10-27 Miguel de Icaza <miguel@ximian.com>
15445 * expression.cs: Fix bug I introduced lsat night that broke
15448 (Expression.Resolve): Report a 246 error (can not resolve name)
15449 if we find a SimpleName in the stream.
15451 (Expression.ResolveLValue): Ditto.
15453 (Expression.ResolveWithSimpleName): This function is a variant of
15454 ResolveName, this one allows SimpleNames to be returned without a
15455 warning. The only consumer of SimpleNames is MemberAccess
15457 2001-10-26 Miguel de Icaza <miguel@ximian.com>
15459 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
15460 might arrive here. I have my doubts that this is correct.
15462 * statement.cs (Lock): Implement lock statement.
15464 * cs-parser.jay: Small fixes to support `lock' and `using'
15466 * cs-tokenizer.cs: Remove extra space
15468 * driver.cs: New flag --checked, allows to turn on integer math
15471 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
15472 Threading.Monitor.Exit
15474 2001-10-23 Miguel de Icaza <miguel@ximian.com>
15476 * expression.cs (IndexerAccess::DoResolveLValue): Set the
15477 Expression Class to be IndexerAccess.
15479 Notice that Indexer::DoResolve sets the eclass to Value.
15481 2001-10-22 Miguel de Icaza <miguel@ximian.com>
15483 * class.cs (TypeContainer::Emit): Emit code for indexers.
15485 * assign.cs (IAssignMethod): New interface implemented by Indexers
15486 and Properties for handling assignment.
15488 (Assign::Emit): Simplify and reuse code.
15490 * expression.cs (IndexerAccess, PropertyExpr): Implement
15491 IAssignMethod, clean up old code.
15493 2001-10-22 Ravi Pratap <ravi@ximian.com>
15495 * typemanager.cs (ImplementsInterface): New method to determine if a type
15496 implements a given interface. Provides a nice cache too.
15498 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
15501 (ConvertReferenceExplicit): Ditto.
15503 * delegate.cs (Delegate::Populate): Update to define the parameters on the
15504 various methods, with correct names etc.
15506 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
15507 Operator.UnaryNegation.
15509 * cs-parser.jay (operator_declarator): Be a little clever in the case where
15510 we have a unary plus or minus operator.
15512 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
15515 * everywhere : update accordingly.
15517 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
15520 * class.cs (Method::Define): For the case where we are implementing a method
15521 inherited from an interface, we need to set the MethodAttributes.Final flag too.
15522 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
15524 2001-10-21 Ravi Pratap <ravi@ximian.com>
15526 * interface.cs (FindMembers): Implement to work around S.R.E
15529 * typemanager.cs (IsInterfaceType): Implement.
15531 (FindMembers): Update to handle interface types too.
15533 * expression.cs (ImplicitReferenceConversion): Re-write bits which
15534 use IsAssignableFrom as that is not correct - it doesn't work.
15536 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
15537 and accordingly override EmitStatement.
15539 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
15540 using the correct logic :-)
15542 2001-10-19 Ravi Pratap <ravi@ximian.com>
15544 * ../errors/cs-11.cs : Add to demonstrate error -11
15546 2001-10-17 Miguel de Icaza <miguel@ximian.com>
15548 * assign.cs (Assign::Resolve): Resolve right hand side first, and
15549 then pass this as a hint to ResolveLValue.
15551 * expression.cs (FieldExpr): Add Location information
15553 (FieldExpr::LValueResolve): Report assignment to readonly
15556 (Expression::ExprClassFromMemberInfo): Pass location information.
15558 (Expression::ResolveLValue): Add new method that resolves an
15561 (Expression::DoResolveLValue): Default invocation calls
15564 (Indexers): New class used to keep track of indexers in a given
15567 (IStackStore): Renamed from LValue, as it did not really describe
15568 what this did. Also ResolveLValue is gone from this interface and
15569 now is part of Expression.
15571 (ElementAccess): Depending on the element access type
15573 * typemanager.cs: Add `indexer_name_type' as a Core type
15574 (System.Runtime.CompilerServices.IndexerNameAttribute)
15576 * statement.cs (Goto): Take a location.
15578 2001-10-18 Ravi Pratap <ravi@ximian.com>
15580 * delegate.cs (Delegate::VerifyDelegate): New method to verify
15581 if two delegates are compatible.
15583 (NewDelegate::DoResolve): Update to take care of the case when
15584 we instantiate a delegate from another delegate.
15586 * typemanager.cs (FindMembers): Don't even try to look up members
15587 of Delegate types for now.
15589 2001-10-18 Ravi Pratap <ravi@ximian.com>
15591 * delegate.cs (NewDelegate): New class to take care of delegate
15594 * expression.cs (New): Split the delegate related code out into
15595 the NewDelegate class.
15597 * delegate.cs (DelegateInvocation): New class to handle delegate
15600 * expression.cs (Invocation): Split out delegate related code into
15601 the DelegateInvocation class.
15603 2001-10-17 Ravi Pratap <ravi@ximian.com>
15605 * expression.cs (New::DoResolve): Implement delegate creation fully
15606 and according to the spec.
15608 (New::DoEmit): Update to handle delegates differently.
15610 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
15611 because of which we were printing out arguments in reverse order !
15613 * delegate.cs (VerifyMethod): Implement to check if the given method
15614 matches the delegate.
15616 (FullDelegateDesc): Implement.
15618 (VerifyApplicability): Implement.
15620 * expression.cs (Invocation::DoResolve): Update to accordingly handle
15621 delegate invocations too.
15623 (Invocation::Emit): Ditto.
15625 * ../errors/cs1593.cs : Added.
15627 * ../errors/cs1594.cs : Added.
15629 * delegate.cs (InstanceExpression, TargetMethod): New properties.
15631 2001-10-16 Ravi Pratap <ravi@ximian.com>
15633 * typemanager.cs (intptr_type): Core type for System.IntPtr
15635 (InitCoreTypes): Update for the same.
15637 (iasyncresult_type, asynccallback_type): Ditto.
15639 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
15642 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
15645 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
15646 the builders for the 4 members of a delegate type :-)
15648 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
15651 * expression.cs (New::DoResolve): Implement guts for delegate creation.
15653 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
15655 2001-10-15 Miguel de Icaza <miguel@ximian.com>
15657 * statement.cs (Break::Emit): Implement.
15658 (Continue::Emit): Implement.
15660 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
15661 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
15662 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
15663 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
15666 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
15667 properties that track the label for the current loop (begin of the
15668 loop and end of the loop).
15670 2001-10-15 Ravi Pratap <ravi@ximian.com>
15672 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
15673 use of emitting anything at all.
15675 * class.cs, rootcontext.cs : Get rid of calls to the same.
15677 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
15679 (Populate): Define the constructor correctly and set the implementation
15682 * typemanager.cs (delegate_types): New hashtable to hold delegates that
15685 (AddDelegateType): Implement.
15687 (IsDelegateType): Implement helper method.
15689 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
15691 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
15692 and accordingly handle it.
15694 * delegate.cs (Populate): Take TypeContainer argument.
15695 Implement bits to define the Invoke method. However, I still haven't figured out
15696 how to take care of the native int bit :-(
15698 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
15699 Qualify the name of the delegate, not its return type !
15701 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
15704 (StandardConversionExists): Checking for array types turns out to be recursive.
15706 (ConvertReferenceExplicit): Implement array conversion.
15708 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
15710 2001-10-12 Ravi Pratap <ravi@ximian.com>
15712 * cs-parser.jay (delegate_declaration): Store the fully qualified
15713 name as it is a type declaration.
15715 * delegate.cs (ReturnType, Name): Rename members to these. Make them
15718 (DefineDelegate): Renamed from Define. Does the same thing essentially,
15719 as TypeContainer::DefineType.
15721 (Populate): Method in which all the definition of the various methods (Invoke)
15724 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
15727 (CloseDelegate): Finally creates the delegate.
15729 * class.cs (TypeContainer::DefineType): Update to define delegates.
15730 (Populate, Emit and CloseType): Do the same thing here too.
15732 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
15733 delegates in all these operations.
15735 2001-10-14 Miguel de Icaza <miguel@ximian.com>
15737 * expression.cs: LocalTemporary: a new expression used to
15738 reference a temporary that has been created.
15740 * assign.cs: Handle PropertyAccess back here, so that we can
15741 provide the proper semantic access to properties.
15743 * expression.cs (Expression::ConvertReferenceExplicit): Implement
15744 a few more explicit conversions.
15746 * modifiers.cs: `NEW' modifier maps to HideBySig.
15748 * expression.cs (PropertyExpr): Make this into an
15749 ExpressionStatement, and support the EmitStatement code path.
15751 Perform get/set error checking, clean up the interface.
15753 * assign.cs: recognize PropertyExprs as targets, and if so, turn
15754 them into toplevel access objects.
15756 2001-10-12 Miguel de Icaza <miguel@ximian.com>
15758 * expression.cs: PropertyExpr::PropertyExpr: use work around the
15761 * typemanager.cs: Keep track here of our PropertyBuilders again to
15762 work around lameness in SRE.
15764 2001-10-11 Miguel de Icaza <miguel@ximian.com>
15766 * expression.cs (LValue::LValueResolve): New method in the
15767 interface, used to perform a second resolution pass for LValues.
15769 (This::DoResolve): Catch the use of this in static methods.
15771 (This::LValueResolve): Implement.
15773 (This::Store): Remove warning, assigning to `this' in structures
15776 (Invocation::Emit): Deal with invocation of
15777 methods on value types. We need to pass the address to structure
15778 methods rather than the object itself. (The equivalent code to
15779 emit "this" for structures leaves the entire structure on the
15780 stack instead of a pointer to it).
15782 (ParameterReference::DoResolve): Compute the real index for the
15783 argument based on whether the method takes or not a `this' pointer
15784 (ie, the method is static).
15786 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
15787 value types returned from functions when we need to invoke a
15788 method on the sturcture.
15791 2001-10-11 Ravi Pratap <ravi@ximian.com>
15793 * class.cs (TypeContainer::DefineType): Method to actually do the business of
15794 defining the type in the Modulebuilder or Typebuilder. This is to take
15795 care of nested types which need to be defined on the TypeBuilder using
15796 DefineNestedMethod.
15798 (TypeContainer::GetClassBases): Implement. Essentially the code from the
15799 methods in RootContext, only ported to be part of TypeContainer.
15801 (TypeContainer::GetInterfaceOrClass): Ditto.
15803 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
15805 * interface.cs (Interface::DefineInterface): New method. Does exactly
15806 what RootContext.CreateInterface did earlier, only it takes care of nested types
15809 (Interface::GetInterfaces): Move from RootContext here and port.
15811 (Interface::GetInterfaceByName): Same here.
15813 * rootcontext.cs (ResolveTree): Re-write.
15815 (PopulateTypes): Re-write.
15817 * class.cs (TypeContainer::Populate): Populate nested types too.
15818 (TypeContainer::Emit): Emit nested members too.
15820 * typemanager.cs (AddUserType): Do not make use of the FullName property,
15821 instead just use the name argument passed in as it is already fully
15824 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
15825 to TypeContainer mapping to see if a type is user-defined.
15827 * class.cs (TypeContainer::CloseType): Implement.
15829 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
15830 the default constructor.
15832 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
15835 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
15837 * interface.cs (CloseType): Create the type here.
15839 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
15842 Remove all the methods which are now in TypeContainer.
15844 2001-10-10 Ravi Pratap <ravi@ximian.com>
15846 * delegate.cs (Define): Re-write bits to define the delegate
15849 2001-10-10 Miguel de Icaza <miguel@ximian.com>
15851 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
15853 * expression.cs (ImplicitReferenceConversion): handle null as well
15854 as a source to convert to any reference type.
15856 * statement.cs (Return): Perform any implicit conversions to
15857 expected return type.
15859 Validate use of return statement.
15861 * codegen.cs (EmitContext): Pass the expected return type here.
15863 * class.cs (Method, Constructor, Property): Pass expected return
15864 type to EmitContext.
15866 2001-10-09 Miguel de Icaza <miguel@ximian.com>
15868 * expression.cs: Make DoResolve take an EmitContext instead of a
15871 Replaced `l' and `location' for `loc', for consistency.
15873 (Error, Warning): Remove unneeded Tc argument.
15875 * assign.cs, literal.cs, constant.cs: Update to new calling
15878 * codegen.cs: EmitContext now contains a flag indicating whether
15879 code is being generated in a static method or not.
15881 * cs-parser.jay: DecomposeQI, new function that replaces the old
15882 QualifiedIdentifier. Now we always decompose the assembled
15883 strings from qualified_identifier productions into a group of
15886 2001-10-08 Miguel de Icaza <miguel@ximian.com>
15888 * rootcontext.cs: Deal with field-less struct types correctly now
15889 by passing the size option to Define Type.
15891 * class.cs: Removed hack that created one static field.
15893 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15895 * statement.cs: Moved most of the code generation here.
15897 2001-10-09 Ravi Pratap <ravi@ximian.com>
15899 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
15902 (ElementAccess): Remove useless bits for now - keep checks as the spec
15905 2001-10-08 Ravi Pratap <ravi@ximian.com>
15907 * expression.cs (ElementAccess::DoResolve): Remove my crap code
15908 and start performing checks according to the spec.
15910 2001-10-07 Ravi Pratap <ravi@ximian.com>
15912 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
15913 rank_specifiers instead.
15915 (rank_specifiers): Change the order in which the rank specifiers are stored
15917 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
15919 * expression.cs (ElementAccess): Implement the LValue interface too.
15921 2001-10-06 Ravi Pratap <ravi@ximian.com>
15923 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
15924 except that user defined conversions are not included.
15926 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
15927 perform the conversion of the return type, if necessary.
15929 (New::DoResolve): Check whether we are creating an array or an object
15930 and accordingly do the needful.
15932 (New::Emit): Same here.
15934 (New::DoResolve): Implement guts of array creation.
15936 (New::FormLookupType): Helper function.
15938 2001-10-07 Miguel de Icaza <miguel@ximian.com>
15940 * codegen.cs: Removed most of the code generation here, and move the
15941 corresponding code generation bits to the statement classes.
15943 Added support for try/catch/finalize and throw.
15945 * cs-parser.jay: Added support for try/catch/finalize.
15947 * class.cs: Catch static methods having the flags override,
15948 virtual or abstract.
15950 * expression.cs (UserCast): This user cast was not really doing
15951 what it was supposed to do. Which is to be born in fully resolved
15952 state. Parts of the resolution were being performed at Emit time!
15956 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15958 * expression.cs: Implicity convert the result from UserCast.
15960 2001-10-05 Ravi Pratap <ravi@ximian.com>
15962 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
15963 prevented it from working correctly.
15965 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
15966 merely ConvertImplicit.
15968 2001-10-05 Miguel de Icaza <miguel@ximian.com>
15970 * typemanager.cs: Make the LookupTypeContainer function static,
15971 and not per-instance.
15973 * class.cs: Make static FindMembers (the one that takes a Type
15976 * codegen.cs: Add EmitForeach here.
15978 * cs-parser.jay: Make foreach a toplevel object instead of the
15979 inline expansion, as we need to perform semantic analysis on it.
15981 2001-10-05 Ravi Pratap <ravi@ximian.com>
15983 * expression.cs (Expression::ImplicitUserConversion): Rename to
15984 UserDefinedConversion.
15986 (Expression::UserDefinedConversion): Take an extra argument specifying
15987 whether we look for explicit user conversions too.
15989 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
15991 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
15993 (ExplicitUserConversion): Make it a call to UserDefinedConversion
15994 with the appropriate arguments.
15996 * cs-parser.jay (cast_expression): Record location too.
15998 * expression.cs (Cast): Record location info.
16000 (Expression::ConvertExplicit): Take location argument.
16002 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
16003 to determine if we are doing explicit conversions.
16005 (UserCast::Emit): Update accordingly.
16007 (Expression::ConvertExplicit): Report an error if everything fails.
16009 * ../errors/cs0030.cs : Add.
16011 2001-10-04 Miguel de Icaza <miguel@ximian.com>
16013 * modifiers.cs: If the ABSTRACT keyword is present, also set the
16014 virtual and newslot bits.
16016 * class.cs (TypeContainer::RegisterRequiredImplementations):
16017 Record methods we need.
16019 (TypeContainer::MakeKey): Helper function to make keys for
16020 MethodBases, since the Methodbase key is useless.
16022 (TypeContainer::Populate): Call RegisterRequiredImplementations
16023 before defining the methods.
16025 Create a mapping for method_builders_to_methods ahead of time
16026 instead of inside a tight loop.
16028 (::RequireMethods): Accept an object as the data to set into the
16029 hashtable so we can report interface vs abstract method mismatch.
16031 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16033 * report.cs: Make all of it static.
16035 * rootcontext.cs: Drop object_type and value_type computations, as
16036 we have those in the TypeManager anyways.
16038 Drop report instance variable too, now it is a global.
16040 * driver.cs: Use try/catch on command line handling.
16042 Add --probe option to debug the error reporting system with a test
16045 * report.cs: Add support for exiting program when a probe
16046 condition is reached.
16048 2001-10-03 Ravi Pratap <ravi@ximian.com>
16050 * expression.cs (Binary::DoNumericPromotions): Fix the case when
16051 we do a forcible conversion regardless of type, to check if
16052 ForceConversion returns a null.
16054 (Binary::error19): Use location to report error.
16056 (Unary::error23): Use location here too.
16058 * ../errors/cs0019.cs : Check in.
16060 * ../errors/cs0023.cs : Check in.
16062 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
16063 case of a non-null MethodInfo object with a length of 0 !
16065 (Binary::ResolveOperator): Flag error if overload resolution fails to find
16066 an applicable member - according to the spec :-)
16067 Also fix logic to find members in base types.
16069 (Unary::ResolveOperator): Same here.
16071 (Unary::report23): Change name to error23 and make first argument a TypeContainer
16072 as I was getting thoroughly confused between this and error19 :-)
16074 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
16075 (::FindMostEncompassedType): Implement.
16076 (::FindMostEncompassingType): Implement.
16077 (::StandardConversionExists): Implement.
16079 (UserImplicitCast): Re-vamp. We now need info about most specific
16080 source and target types so that we can do the necessary conversions.
16082 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
16083 mathematical union with no duplicates.
16085 2001-10-03 Miguel de Icaza <miguel@ximian.com>
16087 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
16088 in order from base classes to child classes, so that we can in
16089 child classes look up in our parent for method names and
16090 attributes (required for handling abstract, virtual, new, override
16091 constructs: we need to instrospect our base class, and if we dont
16092 populate the classes in order, the introspection might be
16093 incorrect. For example, a method could query its parent before
16094 the parent has any methods and would determine that the parent has
16095 no abstract methods (while it could have had them)).
16097 (RootContext::CreateType): Record the order in which we define the
16100 2001-10-02 Miguel de Icaza <miguel@ximian.com>
16102 * class.cs (TypeContainer::Populate): Also method definitions can
16103 fail now, keep track of this.
16105 (TypeContainer::FindMembers): Implement support for
16106 DeclaredOnly/noDeclaredOnly flag.
16108 (Constructor::Emit) Return the ConstructorBuilder.
16110 (Method::Emit) Return the MethodBuilder.
16111 Check for abstract or virtual methods to be public.
16113 * rootcontext.cs (RootContext::CreateType): Register all the
16114 abstract methods required for the class to be complete and the
16115 interface methods that must be implemented.
16117 * cs-parser.jay: Report error 501 (method requires body if it is
16118 not marked abstract or extern).
16120 * expression.cs (TypeOf::Emit): Implement.
16122 * typemanager.cs: runtime_handle_type, new global type.
16124 * class.cs (Property::Emit): Generate code for properties.
16126 2001-10-02 Ravi Pratap <ravi@ximian.com>
16128 * expression.cs (Unary::ResolveOperator): Find operators on base type
16129 too - we now conform exactly to the spec.
16131 (Binary::ResolveOperator): Same here.
16133 * class.cs (Operator::Define): Fix minor quirk in the tests.
16135 * ../errors/cs0215.cs : Added.
16137 * ../errors/cs0556.cs : Added.
16139 * ../errors/cs0555.cs : Added.
16141 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16143 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
16144 single integer which is really efficient
16146 2001-10-01 Ravi Pratap <ravi@ximian.com>
16148 * expression.cs (Expression::ImplicitUserConversion): Use location
16149 even in the case when we are examining True operators.
16151 * class.cs (Operator::Define): Perform extensive checks to conform
16152 with the rules for operator overloading in the spec.
16154 * expression.cs (Expression::ImplicitReferenceConversion): Implement
16155 some of the other conversions mentioned in the spec.
16157 * typemanager.cs (array_type): New static member for the System.Array built-in
16160 (cloneable_interface): For System.ICloneable interface.
16162 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
16163 we start resolving the tree and populating types.
16165 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
16167 2001-10-01 Miguel de Icaza <miguel@ximian.com>
16169 * expression.cs (Expression::ExprClassFromMemberInfo,
16170 Expression::Literalize): Create literal expressions from
16171 FieldInfos which are literals.
16173 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
16174 type casts, because they were wrong. The test suite in tests
16177 (ImplicitNumericConversion): ushort to ulong requires a widening
16180 Int32 constant to long requires widening cast as well.
16182 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
16183 for integers because the type on the stack is not i4.
16185 2001-09-30 Miguel de Icaza <miguel@ximian.com>
16187 * expression.cs (report118): require location argument.
16189 * parameter.cs: Do not dereference potential null value.
16191 * class.cs: Catch methods that lack the `new' keyword when
16192 overriding a name. Report warnings when `new' is used without
16193 anything being there to override.
16195 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
16197 * class.cs: Only add constructor to hashtable if it is non-null
16198 (as now constructors can fail on define).
16200 (TypeManager, Class, Struct): Take location arguments.
16202 Catch field instance initialization in structs as errors.
16204 accepting_filter: a new filter for FindMembers that is static so
16205 that we dont create an instance per invocation.
16207 (Constructor::Define): Catch errors where a struct constructor is
16210 * cs-parser.jay: Pass location information for various new
16213 * delegate.cs (Delegate): take a location argument.
16215 * driver.cs: Do not call EmitCode if there were problesm in the
16216 Definition of the types, as many Builders wont be there.
16218 * decl.cs (Decl::Decl): Require a location argument.
16220 * cs-tokenizer.cs: Handle properly hex constants that can not fit
16221 into integers, and find the most appropiate integer for it.
16223 * literal.cs: Implement ULongLiteral.
16225 * rootcontext.cs: Provide better information about the location of
16226 failure when CreateType fails.
16228 2001-09-29 Miguel de Icaza <miguel@ximian.com>
16230 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
16233 * expression.cs (Binary::CheckShiftArguments): Add missing type
16235 (Binary::ResolveOperator): Add type to the logical and and logical
16236 or, Bitwise And/Or and Exclusive Or code paths, it was missing
16239 (Binary::DoNumericPromotions): In the case where either argument
16240 is ulong (and most signed types combined with ulong cause an
16241 error) perform implicit integer constant conversions as well.
16243 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16245 * expression.cs (UserImplicitCast): Method should always be
16247 (Invocation::BetterConversion): Simplified test for IntLiteral.
16249 (Expression::ImplicitNumericConversion): Split this routine out.
16250 Put the code that performs implicit constant integer conversions
16253 (Expression::Resolve): Become a wrapper around DoResolve so we can
16254 check eclass and type being set after resolve.
16256 (Invocation::Badness): Remove this dead function
16258 (Binary::ResolveOperator): Do not compute the expensive argumnets
16259 unless we have a union for it.
16261 (Probe::Emit): Is needs to do an isinst and then
16262 compare against null.
16264 (::CanConvert): Added Location argument. If the Location argument
16265 is null (Location.Null), then we do not report errors. This is
16266 used by the `probe' mechanism of the Explicit conversion. We do
16267 not want to generate an error for something that the user
16268 explicitly requested to be casted. But the pipeline for an
16269 explicit cast first tests for potential implicit casts.
16271 So for now, if the Location is null, it means `Probe only' to
16272 avoid adding another argument. Might have to revise this
16275 (ClassCast): New class used to type cast objects into arbitrary
16276 classes (used in Explicit Reference Conversions).
16278 Implement `as' as well.
16280 Reverted all the patches from Ravi below: they were broken:
16282 * The use of `level' as a mechanism to stop recursive
16283 invocations is wrong. That was there just to catch the
16284 bug with a strack trace but not as a way of addressing
16287 To fix the problem we have to *understand* what is going
16288 on and the interactions and come up with a plan, not
16289 just get things going.
16291 * The use of the type conversion cache that I proposed
16292 last night had an open topic: How does this work across
16293 protection domains. A user defined conversion might not
16294 be public in the location where we are applying the
16295 conversion, a different conversion might be selected
16296 (ie, private A->B (better) but public B->A (worse),
16297 inside A, A->B applies, but outside it, B->A will
16300 * On top of that (ie, even if the above is solved),
16301 conversions in a cache need to be abstract. Ie, `To
16302 convert from an Int to a Short use an OpcodeCast', not
16303 `To convert from an Int to a Short use the OpcodeCast on
16304 the variable 5' (which is what this patch was doing).
16306 2001-09-28 Ravi Pratap <ravi@ximian.com>
16308 * expression.cs (Invocation::ConversionExists): Re-write to use
16309 the conversion cache
16311 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
16312 cache all conversions done, not just user-defined ones.
16314 (Invocation::BetterConversion): The real culprit. Use ConversionExists
16315 to determine if a conversion exists instead of acutually trying to
16316 perform the conversion. It's faster too.
16318 (Expression::ConvertExplicit): Modify to use ConversionExists to check
16319 and only then attempt the implicit conversion.
16321 2001-09-28 Ravi Pratap <ravi@ximian.com>
16323 * expression.cs (ConvertImplicit): Use a cache for conversions
16324 already found. Check level of recursion and bail out if necessary.
16326 2001-09-28 Miguel de Icaza <miguel@ximian.com>
16328 * typemanager.cs (string_concat_string_string, string_concat_object_object):
16329 Export standard methods that we expect for string operations.
16331 * statement.cs (Block::UsageWarning): Track usage of variables and
16332 report the errors for not used variables.
16334 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
16337 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16339 * codegen.cs: remove unnneded code
16341 * expression.cs: Removed BuiltinTypeAccess class
16343 Fix the order in which implicit conversions are
16346 The previous fixed dropped support for boxed conversions (adding a
16347 test to the test suite now)
16349 (UserImplicitCast::CanConvert): Remove test for source being null,
16350 that code is broken. We should not feed a null to begin with, if
16351 we do, then we should track the bug where the problem originates
16352 and not try to cover it up here.
16354 Return a resolved expression of type UserImplicitCast on success
16355 rather than true/false. Ravi: this is what I was talking about,
16356 the pattern is to use a static method as a "constructor" for
16359 Also, do not create arguments until the very last minute,
16360 otherwise we always create the arguments even for lookups that
16361 will never be performed.
16363 (UserImplicitCast::Resolve): Eliminate, objects of type
16364 UserImplicitCast are born in a fully resolved state.
16366 * typemanager.cs (InitCoreTypes): Init also value_type
16367 (System.ValueType).
16369 * expression.cs (Cast::Resolve): First resolve the child expression.
16371 (LValue): Add new method AddressOf to be used by
16374 Change the argument of Store to take an EmitContext instead of an
16375 ILGenerator, because things like FieldExpr need to be able to call
16376 their children expression to generate the instance code.
16378 (Expression::Error, Expression::Warning): Sugar functions for
16381 (Expression::MemberLookup): Accept a TypeContainer instead of a
16382 Report as the first argument.
16384 (Expression::ResolvePrimary): Killed. I still want to improve
16385 this as currently the code is just not right.
16387 (Expression::ResolveMemberAccess): Simplify, but it is still
16390 (Unary::Resolve): Catch errors in AddressOf operators.
16392 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
16393 index to a byte for the short-version, or the compiler will choose
16394 the wrong Emit call, which generates the wrong data.
16396 (ParameterReference::Emit, ::Store): same.
16398 (FieldExpr::AddressOf): Implement.
16400 * typemanager.cs: TypeManager: made public variable instead of
16403 * driver.cs: document --fatal.
16405 * report.cs (ErrorMessage, WarningMessage): new names for the old
16406 Error and Warning classes.
16408 * cs-parser.jay (member_access): Turn built-in access to types
16409 into a normal simplename
16411 2001-09-27 Ravi Pratap <ravi@ximian.com>
16413 * expression.cs (Invocation::BetterConversion): Fix to cope
16414 with q being null, since this was introducing a bug.
16416 * expression.cs (ConvertImplicit): Do built-in conversions first.
16418 2001-09-27 Ravi Pratap <ravi@ximian.com>
16420 * expression.cs (UserImplicitCast::Resolve): Fix bug.
16422 2001-09-27 Ravi Pratap <ravi@ximian.com>
16424 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
16425 I had introduced long ago (what's new ?).
16427 * expression.cs (UserImplicitCast::CanConvert): Static method to do
16428 the work of all the checking.
16429 (ConvertImplicit): Call CanConvert and only then create object if necessary.
16430 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
16432 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
16433 that is the right way.
16435 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
16436 overloading resolution. Use everywhere instead of cutting and pasting code.
16438 (Binary::ResolveOperator): Use MakeUnionSet.
16440 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
16441 we have to convert to bool types. Not complete yet.
16443 2001-09-27 Miguel de Icaza <miguel@ximian.com>
16445 * typemanager.cs (TypeManager::CSharpName): support ushort.
16447 * expression.cs (Expression::TryImplicitIntConversion): Attempts
16448 to provide an expression that performsn an implicit constant int
16449 conversion (section 6.1.6).
16450 (Expression::ConvertImplicitRequired): Reworked to include
16451 implicit constant expression conversions.
16453 (Expression::ConvertNumericExplicit): Finished.
16455 (Invocation::Emit): If InstanceExpression is null, then it means
16456 that we perform a call on this.
16458 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16460 * expression.cs (Unary::Emit): Remove some dead code.
16461 (Probe): Implement Resolve and Emit for `is'.
16462 (Expression::ConvertImplicitRequired): Attempt to do constant
16463 expression conversions here. Maybe should be moved to
16464 ConvertImplicit, but I am not sure.
16465 (Expression::ImplicitLongConstantConversionPossible,
16466 Expression::ImplicitIntConstantConversionPossible): New functions
16467 that tell whether is it possible to apply an implicit constant
16468 expression conversion.
16470 (ConvertNumericExplicit): Started work on explicit numeric
16473 * cs-parser.jay: Update operator constants.
16475 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
16476 (Parameters::GetSignature): Hook up VerifyArgs here.
16477 (Parameters::VerifyArgs): Verifies that no two arguments have the
16480 * class.cs (Operator): Update the operator names to reflect the
16481 ones that the spec expects (as we are just stringizing the
16484 * expression.cs (Unary::ResolveOperator): Fix bug: Use
16485 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
16486 previous usage did only work for our methods.
16487 (Expression::ConvertImplicit): Handle decimal implicit numeric
16488 conversions as well.
16489 (Expression::InternalTypeConstructor): Used to invoke constructors
16490 on internal types for default promotions.
16492 (Unary::Emit): Implement special handling for the pre/post
16493 increment/decrement for overloaded operators, as they need to have
16494 the same semantics as the other operators.
16496 (Binary::ResolveOperator): ditto.
16497 (Invocation::ConversionExists): ditto.
16498 (UserImplicitCast::Resolve): ditto.
16500 2001-09-26 Ravi Pratap <ravi@ximian.com>
16502 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
16503 operator, return after emitting body. Regression tests pass again !
16505 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
16506 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
16507 (Invocation::OverloadResolve): Ditto.
16508 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
16510 * everywhere : update calls to the above methods accordingly.
16512 2001-09-26 Miguel de Icaza <miguel@ximian.com>
16514 * assign.cs (Assign): Make it inherit from ExpressionStatement.
16516 * expression.cs (ExpressionStatement): New base class used for
16517 expressions that can appear in statements, so that we can provide
16518 an alternate path to generate expression that do not leave a value
16521 (Expression::Emit, and all the derivatives): We no longer return
16522 whether a value is left on the stack or not. Every expression
16523 after being emitted leaves a single value on the stack.
16525 * codegen.cs (EmitContext::EmitStatementExpression): Use the
16526 facilties of ExpressionStatement if possible.
16528 * cs-parser.jay: Update statement_expression.
16530 2001-09-25 Miguel de Icaza <miguel@ximian.com>
16532 * driver.cs: Change the wording of message
16534 2001-09-25 Ravi Pratap <ravi@ximian.com>
16536 * expression.cs (Binary::ResolveOperator): Had forgottten to set
16537 the type of the expression to the return type of the method if
16538 we have an overloaded operator match ! The regression tests pass again !
16539 (Unary::ResolveOperator): Ditto.
16541 * expression.cs (Invocation::ConversionExists): Correct the member lookup
16542 to find "op_Implicit", not "implicit" ;-)
16543 (UserImplicitCast): New class to take care of user-defined implicit conversions.
16544 (ConvertImplicit, ForceConversion): Take TypeContainer argument
16546 * everywhere : Correct calls to the above accordingly.
16548 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
16549 (ConvertImplicit): Do user-defined conversion if it exists.
16551 2001-09-24 Miguel de Icaza <miguel@ximian.com>
16553 * assign.cs: track location.
16554 (Resolve): Use implicit conversions on assignment.
16556 * literal.cs: Oops. Not good, Emit of short access values should
16557 pass (Bytes) or the wrong argument will be selected.
16559 * expression.cs (Unary::Emit): Emit code for -expr.
16561 (Unary::ResolveOperator): Handle `Substract' for non-constants
16562 (substract from zero from the non-constants).
16563 Deal with Doubles as well.
16565 (Expression::ConvertImplicitRequired): New routine that reports an
16566 error if no implicit conversion exists.
16568 (Invocation::OverloadResolve): Store the converted implicit
16569 expressions if we make them
16571 2001-09-24 Ravi Pratap <ravi@ximian.com>
16573 * class.cs (ConstructorInitializer): Take a Location argument.
16574 (ConstructorBaseInitializer): Same here.
16575 (ConstructorThisInitializer): Same here.
16577 * cs-parser.jay : Update all calls accordingly.
16579 * expression.cs (Unary, Binary, New): Take location argument.
16580 Update accordingly everywhere.
16582 * cs-parser.jay : Update all calls to the above to take a location
16585 * class.cs : Ditto.
16587 2001-09-24 Ravi Pratap <ravi@ximian.com>
16589 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
16590 (Invocation::BetterConversion): Same here
16591 (Invocation::ConversionExists): Ditto.
16593 (Invocation::ConversionExists): Implement.
16595 2001-09-22 Ravi Pratap <ravi@ximian.com>
16597 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
16598 Also take an additional TypeContainer argument.
16600 * All over : Pass in TypeContainer as argument to OverloadResolve.
16602 * typemanager.cs (CSharpName): Update to check for the string type and return
16605 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
16608 2001-09-21 Ravi Pratap <ravi@ximian.com>
16610 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
16611 (Invocation::BetterFunction): Implement.
16612 (Invocation::BetterConversion): Implement.
16613 (Invocation::ConversionExists): Skeleton, no implementation yet.
16615 Okay, things work fine !
16617 2001-09-21 Miguel de Icaza <miguel@ximian.com>
16619 * typemanager.cs: declare and load enum_type, delegate_type and
16622 * expression.cs (Expression::Emit): Now emit returns a value that
16623 tells whether a value is left on the stack or not. This strategy
16624 might be reveted tomorrow with a mechanism that would address
16625 multiple assignments.
16626 (Expression::report118): Utility routine to report mismatches on
16629 (Unary::Report23): Report impossible type/operator combination
16632 (Unary::IsIncrementableNumber): Whether the type can be
16633 incremented or decremented with add.
16634 (Unary::ResolveOperator): Also allow enumerations to be bitwise
16636 (Unary::ResolveOperator): Implement ++, !, ~,
16638 (Invocation::Emit): Deal with new Emit convetion.
16640 * All Expression derivatives: Updated their Emit method to return
16641 whether they leave values on the stack or not.
16643 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
16644 stack for expressions that are statements.
16646 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16648 * expression.cs (LValue): New interface. Must be implemented by
16650 (LocalVariableReference, ParameterReference, FieldExpr): Implement
16653 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
16654 interface for generating code, simplifies the code.
16656 2001-09-20 Ravi Pratap <ravi@ximian.com>
16658 * expression.cs (everywhere): Comment out return statements in ::Resolve
16659 methods to avoid the warnings.
16661 2001-09-20 Miguel de Icaza <miguel@ximian.com>
16663 * driver.cs (parse): Report error 2001 if we can not open the
16666 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
16669 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
16672 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
16673 otherwise nested blocks end up with the same index.
16675 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
16677 * expression.cs: Instead of having FIXMEs in the Resolve
16678 functions, throw exceptions so it is obvious that we are facing a
16681 * cs-parser.jay (invocation_expression): Pass Location information.
16683 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
16684 Use a basename for those routines because .NET does not like paths
16687 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
16690 2001-09-19 Miguel de Icaza <miguel@ximian.com>
16692 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
16693 are loading the correct data types (throws an exception if not).
16694 (TypeManager::InitCoreTypes): Use CoreLookupType
16696 * expression.cs (Unary::ResolveOperator): return the child
16697 expression for expressions which are just +expr.
16698 (Unary::ResolveOperator): Return negative literals for -LITERAL
16699 expressions (otherwise they are Unary {Literal}).
16700 (Invocation::Badness): Take into account `Implicit constant
16701 expression conversions'.
16703 * literal.cs (LongLiteral): Implement long literal class.
16704 (IntLiteral): export the `Value' of the intliteral.
16706 2001-09-19 Ravi Pratap <ravi@ximian.com>
16708 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
16710 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
16711 instead of 'Operator'
16713 * expression.cs (Binary::ResolveOperator): Update accordingly.
16714 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
16717 * cs-parser.jay (unary_expression): Update to use the new names.
16719 * gen-treedump.cs (GetUnary): Same here.
16721 * expression.cs (Unary::Resolve): Implement.
16722 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
16723 operators are found instead of making noise ;-)
16724 (Unary::ResolveOperator): New method to do precisely the same thing which
16725 Binary::ResolveOperator does for Binary expressions.
16726 (Unary.method, .Arguments): Add.
16727 (Unary::OperName): Implement.
16728 (Unary::ForceConversion): Copy and Paste !
16730 * class.cs (Operator::Define): Fix a small bug for the case when we have
16733 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
16734 for the inbuilt operators. Only overloading works for now ;-)
16736 2001-09-18 Miguel de Icaza <miguel@ximian.com>
16738 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
16739 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
16741 * expression.cs (This::Emit): Implement.
16742 (This::Resolve): Implement.
16743 (TypeOf:Resolve): Implement.
16744 (Expression::ResolveSimpleName): Add an implicit this to instance
16746 (MemberAccess::Resolve): Deal with Parameters and Fields.
16747 Bind instance variable to Field expressions.
16748 (FieldExpr::Instance): New field used to track the expression that
16749 represents the object instance.
16750 (FieldExpr::Resolve): Track potential errors from MemberLookup not
16752 (FieldExpr::Emit): Implement.
16754 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
16755 the last instruction contains a return opcode to avoid generating
16756 the last `ret' instruction (this generates correct code, and it is
16757 nice to pass the peverify output).
16759 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
16760 initializer for static and instance variables.
16761 (Constructor::Emit): Allow initializer to be null in the case of
16762 static constructors. Only emit initializer for instance
16765 (TypeContainer::FindMembers): Return a null array if there are no
16768 Also fix the code for the MemberTypes.Method branch, as it was not
16769 scanning that for operators (or tried to access null variables before).
16771 * assign.cs (Assign::Emit): Handle instance and static fields.
16775 * driver.cs: Stop compilation if there are parse errors.
16777 * cs-parser.jay (constructor_declaration): Provide default base
16778 initializer for non-static constructors.
16779 (constructor_declarator): Do not provide a default base
16780 initializers if none was specified.
16781 Catch the fact that constructors should not have parameters.
16783 * class.cs: Do not emit parent class initializers for static
16784 constructors, that should be flagged as an error.
16786 2001-09-18 Ravi Pratap <ravi@ximian.com>
16788 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
16789 Move back code into TypeContainer::Populate.
16791 2001-09-18 Ravi Pratap <ravi@ximian.com>
16793 * class.cs (TypeContainer::AddConstructor): Fix the check to
16794 compare against Name, not Basename.
16795 (Operator::OpType): Change Plus and Minus to Add and Subtract.
16797 * cs-parser.jay : Update accordingly.
16799 * class.cs (TypeContainer::FindMembers): For the case where we are searching
16800 for methods, don't forget to look into the operators too.
16801 (RegisterMethodBuilder): Helper method to take care of this for
16802 methods, constructors and operators.
16803 (Operator::Define): Completely revamp.
16804 (Operator.OperatorMethod, MethodName): New fields.
16805 (TypeContainer::Populate): Move the registering of builders into
16806 RegisterMethodBuilder.
16807 (Operator::Emit): Re-write.
16809 * expression.cs (Binary::Emit): Comment out code path to emit method
16810 invocation stuff for the case when we have a user defined operator. I am
16811 just not able to get it right !
16813 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16815 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
16818 (Expression::MemberLookup): Provide a version that allows to
16819 specify the MemberTypes and BindingFlags.
16821 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
16822 so it was not fetching variable information from outer blocks.
16824 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
16825 Beforefieldinit as it was buggy.
16827 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
16828 that Ravi put here.
16830 * class.cs (Constructor::Emit): Only emit if block is not null.
16831 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
16832 deal with this by semantically definining it as if the user had
16835 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
16836 constructors as we now "emit" them at a higher level.
16838 (TypeContainer::DefineDefaultConstructor): Used to define the
16839 default constructors if none was provided.
16841 (ConstructorInitializer): Add methods Resolve and Emit.
16843 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
16845 2001-09-17 Ravi Pratap <ravi@ximian.com>
16847 * class.cs (TypeContainer::EmitDefaultConstructor): Register
16848 the default constructor builder with our hashtable for methodbuilders
16851 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
16852 and argument_count is 0 in which case we have a match.
16853 (Binary::ResolveOperator): More null checking and miscellaneous coding
16856 2001-09-17 Ravi Pratap <ravi@ximian.com>
16858 * rootcontext.cs (IsNameSpace): Compare against null.
16860 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
16862 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
16863 and Unary::Operator.
16865 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
16868 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
16869 we have overloaded operators.
16870 (Binary::ResolveOperator): Implement the part which does the operator overload
16873 * class.cs (Operator::Emit): Implement.
16874 (TypeContainer::Emit): Emit the operators we have too.
16876 * expression.cs (Binary::Emit): Update to emit the appropriate code for
16877 the case when we have a user-defined operator.
16879 2001-09-17 Miguel de Icaza <miguel@ximian.com>
16881 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
16883 2001-09-16 Ravi Pratap <ravi@ximian.com>
16885 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
16886 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
16887 (Constructor::Emit): Implement.
16888 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
16889 if we have no work to do.
16890 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
16893 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
16894 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
16896 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
16899 2001-09-15 Ravi Pratap <ravi@ximian.com>
16901 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
16903 (Tree::RecordNamespace): Method to do what the name says ;-)
16904 (Tree::Namespaces): Property to get at the namespaces hashtable.
16906 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
16909 * rootcontext.cs (IsNamespace): Fixed it :-)
16911 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16913 * class.cs (TypeContainer::FindMembers): Add support for
16915 (MethodCore): New class that encapsulates both the shared aspects
16916 of a Constructor and a Method.
16917 (Method, Constructor): Factored pieces into MethodCore.
16919 * driver.cs: Added --fatal which makes errors throw exceptions.
16920 Load System assembly as well as part of the standard library.
16922 * report.cs: Allow throwing exceptions on errors for debugging.
16924 * modifiers.cs: Do not use `parent', instead use the real type
16925 container to evaluate permission settings.
16927 * class.cs: Put Ravi's patch back in. He is right, and we will
16928 have to cope with the
16930 2001-09-14 Ravi Pratap <ravi@ximian.com>
16932 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
16933 FamORAssem, not FamANDAssem.
16935 2001-09-14 Miguel de Icaza <miguel@ximian.com>
16937 * driver.cs: Added --parse option that only parses its input files
16940 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
16941 incorrect. IsTopLevel is not used to tell whether an object is
16942 root_types or not (that can be achieved by testing this ==
16943 root_types). But to see if this is a top-level *class* (not
16944 necessarly our "toplevel" container).
16946 2001-09-14 Ravi Pratap <ravi@ximian.com>
16948 * enum.cs (Enum::Define): Modify to call the Lookup method on the
16949 parent instead of a direct call to GetType.
16951 2001-09-14 Ravi Pratap <ravi@ximian.com>
16953 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
16954 Modifiers.TypeAttr. This should just be a call to that method.
16956 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
16957 object so that we can determine if we are top-level or not.
16959 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
16962 * enum.cs (Enum::Define): Ditto.
16964 * modifiers.cs (FieldAttr): Re-write.
16966 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
16967 (TypeContainer::HaveStaticConstructor): New property to provide access
16968 to precisely that info.
16970 * modifiers.cs (MethodAttr): Re-write.
16971 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
16973 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
16974 of top-level types as claimed.
16976 2001-09-13 Miguel de Icaza <miguel@ximian.com>
16978 * expression.cs (MemberLookup): Fruitless attempt to lookup
16979 constructors. Maybe I need to emit default constructors? That
16980 might be it (currently .NET emits this for me automatically).
16981 (Invocation::OverloadResolve): Cope with Arguments == null.
16982 (Invocation::EmitArguments): new function, shared by the new
16983 constructor and us.
16984 (Invocation::Emit): Handle static and instance methods. Emit
16985 proper call instruction for virtual or non-virtual invocations.
16986 (New::Emit): Implement.
16987 (New::Resolve): Implement.
16988 (MemberAccess:Resolve): Implement.
16989 (MethodGroupExpr::InstanceExpression): used conforming to the spec
16990 to track instances.
16991 (FieldExpr::Resolve): Set type.
16993 * support.cs: Handle empty arguments.
16995 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
16996 SimpleLookup): Auxiliary routines to help parse a qualifier
16999 Update qualifier_identifier rule.
17001 * codegen.cs: Removed debugging messages.
17003 * class.cs: Make this a global thing, this acts just as a "key" to
17004 objects that we might have around.
17006 (Populate): Only initialize method_builders_to_methods once.
17008 * expression.cs (PropertyExpr): Initialize type from the
17011 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
17012 Resolve pattern. Attempt to implicitly convert value to boolean.
17015 * expression.cs: Set the type for the int32/int32 argument case.
17016 (Binary::ResolveOperator): Set the return type to boolean for
17017 comparission operators
17019 * typemanager.cs: Remove debugging print code.
17021 (Invocation::Resolve): resolve type.
17023 * class.cs: Allocate a MemberInfo of the correct size, as the code
17024 elsewhere depends on the test to reflect the correct contents.
17026 (Method::) Keep track of parameters, due to System.Reflection holes
17028 (TypeContainer::Populate): Keep track of MethodBuilders to Method
17031 (TypeContainer::FindMembers): Use ArrayList and then copy an array
17032 of the exact size and return that.
17034 (Class::LookupMethodByBuilder): New function that maps
17035 MethodBuilders to its methods. Required to locate the information
17036 on methods because System.Reflection bit us again.
17038 * support.cs: New file, contains an interface ParameterData and
17039 two implementations: ReflectionParameters and InternalParameters
17040 used to access Parameter information. We will need to grow this
17043 * expression.cs (Invocation::GetParameterData): implement a cache
17044 and a wrapper around the ParameterData creation for methods.
17045 (Invocation::OverloadResolve): Use new code.
17047 2001-09-13 Ravi Pratap <ravi@ximian.com>
17049 * class.cs (TypeContainer::EmitField): Remove and move into
17050 (Field::Define): here and modify accordingly.
17051 (Field.FieldBuilder): New member.
17052 (TypeContainer::Populate): Update accordingly.
17053 (TypeContainer::FindMembers): Implement.
17055 2001-09-13 Miguel de Icaza <miguel@ximian.com>
17057 * statement.cs: (VariableInfo::VariableType): New field to be
17058 initialized with the full type once it is resolved.
17060 2001-09-12 Miguel de Icaza <miguel@ximian.com>
17062 * parameter.cs (GetParameterInfo): Use a type cache to compute
17063 things only once, and to reuse this information
17065 * expression.cs (LocalVariableReference::Emit): Implement.
17066 (OpcodeCast::Emit): fix.
17068 (ParameterReference::Resolve): Implement.
17069 (ParameterReference::Emit): Implement.
17071 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
17072 that are expressions need to stay as Expressions.
17074 * typemanager.cs (CSharpName): Returns the C# name of a type if
17077 * expression.cs (Expression::ConvertImplicit): New function that
17078 implements implicit type conversions.
17080 (Expression::ImplicitReferenceConversion): Implements implicit
17081 reference conversions.
17083 (EmptyCast): New type for transparent casts.
17085 (OpcodeCast): New type for casts of types that are performed with
17086 a sequence of bytecodes.
17088 (BoxedCast): New type used for casting value types into reference
17089 types. Emits a box opcode.
17091 (Binary::DoNumericPromotions): Implements numeric promotions of
17092 and computation of the Binary::Type.
17094 (Binary::EmitBranchable): Optimization.
17096 (Binary::Emit): Implement code emission for expressions.
17098 * typemanager.cs (TypeManager): Added two new core types: sbyte
17101 2001-09-12 Ravi Pratap <ravi@ximian.com>
17103 * class.cs (TypeContainer::FindMembers): Method which does exactly
17104 what Type.FindMembers does, only we don't have to use reflection. No
17105 implementation yet.
17107 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
17108 typecontainer objects as we need to get at them.
17109 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
17111 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
17112 typecontainer object.
17114 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
17115 of just a Report object.
17117 2001-09-11 Ravi Pratap <ravi@ximian.com>
17119 * class.cs (Event::Define): Go back to using the prefixes "add_" and
17121 (TypeContainer::Populate): Now define the delegates of the type too.
17122 (TypeContainer.Delegates): Property to access the list of delegates defined
17125 * delegates.cs (Delegate::Define): Implement partially.
17127 * modifiers.cs (TypeAttr): Handle more flags.
17129 2001-09-11 Ravi Pratap <ravi@ximian.com>
17131 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
17133 (Operator::Define): Re-write logic to get types by using the LookupType method
17134 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
17135 (Indexer::Define): Ditto.
17136 (Event::Define): Ditto.
17137 (Property::Define): Ditto.
17139 2001-09-10 Ravi Pratap <ravi@ximian.com>
17141 * class.cs (TypeContainer::Populate): Now define operators too.
17142 (TypeContainer.Operators): New property to access the list of operators
17144 (Operator.OperatorMethodBuilder): New member to hold the method builder
17145 for the operator we are defining.
17146 (Operator::Define): Implement.
17148 2001-09-10 Ravi Pratap <ravi@ximian.com>
17150 * class.cs (Event::Define): Make the prefixes of the accessor methods
17151 addOn_ and removeOn_
17153 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
17154 of the location being passed in too. Ideally, this should go later since all
17155 error reporting should be done through the Report object.
17157 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
17158 (Populate): Iterate thru the indexers we have and define them too.
17159 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
17160 for the get and set accessors.
17161 (Indexer::Define): Implement.
17163 2001-09-09 Miguel de Icaza <miguel@ximian.com>
17165 * expression.cs (Binary::Resolve): Beginning of it. I scratched
17166 my previous implementation, did not work.
17168 * typemanager.cs: Add a couple of missing types (the longs).
17170 * literal.cs: Use TypeManager.bool_type instead of getting it.
17172 * expression.cs (EventExpr): New kind of expressions.
17173 (Expressio::ExprClassFromMemberInfo): finish
17175 2001-09-08 Miguel de Icaza <miguel@ximian.com>
17177 * assign.cs: Emit stores to static fields differently.
17179 2001-09-08 Ravi Pratap <ravi@ximian.com>
17181 * Merge in changes and adjust code to tackle conflicts. Backed out my
17182 code in Assign::Resolve ;-)
17184 2001-09-08 Ravi Pratap <ravi@ximian.com>
17186 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
17187 instead Report.Error and also pass in the location.
17188 (CSharpParser::Lexer): New readonly property to return the reference
17189 to the Tokenizer object.
17190 (declare_local_variables): Use Report.Error with location instead of plain
17194 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
17195 (Operator.CheckBinaryOperator): Ditto.
17197 * cs-parser.jay (operator_declarator): Update accordingly.
17199 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
17200 (CheckBinaryOperator): Same here.
17202 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
17203 on the name without any prefixes of namespace names etc. This is because we
17204 already might have something already fully qualified like
17205 'System.Console.WriteLine'
17207 * assign.cs (Resolve): Begin implementation. Stuck ;-)
17209 2001-09-07 Ravi Pratap <ravi@ximian.com>
17211 * cs-tokenizer.cs (location): Return a string which also contains
17214 * expression.cs (ElementAccess): New class for expressions of the
17215 type 'element access.'
17216 (BaseAccess): New class for expressions of the type 'base access.'
17217 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
17220 * cs-parser.jay (element_access): Implement action.
17221 (base_access): Implement actions.
17222 (checked_expression, unchecked_expression): Implement.
17224 * cs-parser.jay (local_variable_type): Correct and implement.
17225 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
17227 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
17229 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
17230 name and the specifiers.
17232 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
17234 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
17235 making them all public ;-)
17237 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
17240 2001-09-07 Miguel de Icaza <miguel@ximian.com>
17242 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
17244 (FieldExpr, PropertyExprs): New resolved expressions.
17245 (SimpleName::MemberStaticCheck): Perform static checks for access
17246 to non-static fields on static methods. Maybe this should be
17247 generalized for MemberAccesses.
17248 (SimpleName::ResolveSimpleName): More work on simple name
17251 * cs-parser.jay (primary_expression/qualified_identifier): track
17252 the parameter index.
17254 * codegen.cs (CodeGen::Save): Catch save exception, report error.
17255 (EmitContext::EmitBoolExpression): Chain to expression generation
17256 instead of temporary hack.
17257 (::EmitStatementExpression): Put generic expression code generation.
17259 * assign.cs (Assign::Emit): Implement variable assignments to
17260 local variables, parameters and fields.
17262 2001-09-06 Miguel de Icaza <miguel@ximian.com>
17264 * statement.cs (Block::GetVariableInfo): New method, returns the
17265 VariableInfo for a variable name in a block.
17266 (Block::GetVariableType): Implement in terms of GetVariableInfo
17268 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
17269 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
17271 2001-09-06 Ravi Pratap <ravi@ximian.com>
17273 * cs-parser.jay (operator_declaration): Continue on my quest : update
17274 to take attributes argument.
17275 (event_declaration): Ditto.
17276 (enum_declaration): Ditto.
17277 (indexer_declaration): Ditto.
17279 * class.cs (Operator::Operator): Update constructor accordingly.
17280 (Event::Event): Ditto.
17282 * delegate.cs (Delegate::Delegate): Same here.
17284 * enum.cs (Enum::Enum): Same here.
17286 2001-09-05 Ravi Pratap <ravi@ximian.com>
17288 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
17290 * ../tests/cs0658.cs : New file to demonstrate error 0658.
17292 * attribute.cs (Attributes): New class to encapsulate all attributes which were
17293 being passed around as an arraylist.
17294 (Attributes::AddAttribute): Method to add attribute sections.
17296 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
17297 (struct_declaration): Update accordingly.
17298 (constant_declaration): Update.
17299 (field_declaration): Update.
17300 (method_header): Update.
17301 (fixed_parameter): Update.
17302 (parameter_array): Ditto.
17303 (property_declaration): Ditto.
17304 (destructor_declaration): Ditto.
17306 * class.cs (Struct::Struct): Update constructors accordingly.
17307 (Class::Class): Ditto.
17308 (Field::Field): Ditto.
17309 (Method::Method): Ditto.
17310 (Property::Property): Ditto.
17311 (TypeContainer::OptAttribute): update property's return type.
17313 * interface.cs (Interface.opt_attributes): New member.
17314 (Interface::Interface): Update to take the extra Attributes argument.
17316 * parameter.cs (Parameter::Parameter): Ditto.
17318 * constant.cs (Constant::Constant): Ditto.
17320 * interface.cs (InterfaceMemberBase): New OptAttributes field.
17321 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
17322 the attributes as a parameter.
17323 (InterfaceProperty): Update constructor call.
17324 (InterfaceEvent): Ditto.
17325 (InterfaceMethod): Ditto.
17326 (InterfaceIndexer): Ditto.
17328 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
17329 pass the attributes too.
17330 (interface_event_declaration): Ditto.
17331 (interface_property_declaration): Ditto.
17332 (interface_method_declaration): Ditto.
17333 (interface_declaration): Ditto.
17335 2001-09-05 Miguel de Icaza <miguel@ximian.com>
17337 * class.cs (Method::Define): Track the "static Main" definition to
17338 create an entry point.
17340 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
17341 EntryPoint if we find it.
17343 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
17344 (EmitContext::ig): Make this variable public.
17346 * driver.cs: Make the default output file be the first file name
17347 with the .exe extension.
17349 Detect empty compilations
17351 Handle various kinds of output targets. Handle --target and
17352 rename -t to --dumper.
17354 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
17355 methods inherited from Expression return now an Expression. This
17356 will is used during the tree rewriting as we resolve them during
17359 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
17360 the spec. Missing entirely is the information about
17361 accessability of elements of it.
17363 (Expression::ExprClassFromMemberInfo): New constructor for
17364 Expressions that creates a fully initialized Expression based on
17365 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
17368 (Invocation::Resolve): Begin implementing resolution of invocations.
17370 * literal.cs (StringLiteral): Implement Emit.
17372 2001-09-05 Ravi Pratap <ravi@ximian.com>
17374 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
17377 2001-09-04 Ravi Pratap <ravi@ximian.com>
17379 * cs-parser.jay (attribute_arguments): Implement actions.
17380 (attribute): Fix bug in production. Implement action.
17381 (attribute_list): Implement.
17382 (attribute_target): Implement.
17383 (attribute_target_specifier, opt_target_specifier): Implement
17384 (CheckAttributeTarget): New method to check if the attribute target
17386 (attribute_section): Implement.
17387 (opt_attributes): Implement.
17389 * attribute.cs : New file to handle attributes.
17390 (Attribute): Class to hold attribute info.
17392 * cs-parser.jay (opt_attribute_target_specifier): Remove production
17393 (attribute_section): Modify production to use 2 different rules to
17394 achieve the same thing. 1 s/r conflict down !
17395 Clean out commented, useless, non-reducing dimension_separator rules.
17397 * class.cs (TypeContainer.attributes): New member to hold list
17398 of attributes for a type.
17399 (Struct::Struct): Modify to take one more argument, the attribute list.
17400 (Class::Class): Ditto.
17401 (Field::Field): Ditto.
17402 (Method::Method): Ditto.
17403 (Property::Property): Ditto.
17405 * cs-parser.jay (struct_declaration): Update constructor call to
17406 pass in the attributes too.
17407 (class_declaration): Ditto.
17408 (constant_declaration): Ditto.
17409 (field_declaration): Ditto.
17410 (method_header): Ditto.
17411 (fixed_parameter): Ditto.
17412 (parameter_array): Ditto.
17413 (property_declaration): Ditto.
17415 * constant.cs (Constant::Constant): Update constructor similarly.
17416 Use System.Collections.
17418 * parameter.cs (Parameter::Parameter): Update as above.
17420 2001-09-02 Ravi Pratap <ravi@ximian.com>
17422 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
17423 (TypeContainer.delegates): New member to hold list of delegates.
17425 * cs-parser.jay (delegate_declaration): Implement the action correctly
17426 this time as I seem to be on crack ;-)
17428 2001-09-02 Miguel de Icaza <miguel@ximian.com>
17430 * rootcontext.cs (RootContext::IsNamespace): new function, used to
17431 tell whether an identifier represents a namespace.
17433 * expression.cs (NamespaceExpr): A namespace expression, used only
17434 temporarly during expression resolution.
17435 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
17436 utility functions to resolve names on expressions.
17438 2001-09-01 Miguel de Icaza <miguel@ximian.com>
17440 * codegen.cs: Add hook for StatementExpressions.
17442 * class.cs: Fix inverted test for static flag in methods.
17444 2001-09-02 Ravi Pratap <ravi@ximian.com>
17446 * class.cs (Operator::CheckUnaryOperator): Correct error number used
17447 to make it coincide with MS' number.
17448 (Operator::CheckBinaryOperator): Ditto.
17450 * ../errors/errors.txt : Remove error numbers added earlier.
17452 * ../errors/cs1019.cs : Test case for error # 1019
17454 * ../errros/cs1020.cs : Test case for error # 1020
17456 * cs-parser.jay : Clean out commented cruft.
17457 (dimension_separators, dimension_separator): Comment out. Ostensibly not
17458 used anywhere - non-reducing rule.
17459 (namespace_declarations): Non-reducing rule - comment out.
17461 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
17462 with TypeContainer::AddEnum.
17464 * delegate.cs : New file for delegate handling classes.
17465 (Delegate): Class for declaring delegates.
17467 * makefile : Update.
17469 * cs-parser.jay (delegate_declaration): Implement.
17471 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
17473 * class.cs (Event::Define): Implement.
17474 (Event.EventBuilder): New member.
17476 * class.cs (TypeContainer::Populate): Update to define all enums and events
17478 (Events): New property for the events arraylist we hold. Shouldn't we move to using
17479 readonly fields for all these cases ?
17481 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17483 * class.cs (Property): Revamp to use the convention of making fields readonly.
17484 Accordingly modify code elsewhere.
17486 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
17487 the Define method of the Property class.
17489 * class.cs : Clean up applied patch and update references to variables etc. Fix
17491 (TypeContainer::Populate): Update to define all the properties we have. Also
17492 define all enumerations.
17494 * enum.cs (Define): Implement.
17496 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
17498 * cs-parser.jay (overloadable_operator): The semantic value is an
17499 enum of the Operator class.
17500 (operator_declarator): Implement actions.
17501 (operator_declaration): Implement.
17503 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
17504 validity of definitions.
17505 (Operator::CheckBinaryOperator): Static method to check for binary operators
17506 (TypeContainer::AddOperator): New method to add an operator to a type.
17508 * cs-parser.jay (indexer_declaration): Added line to actually call the
17509 AddIndexer method so it gets added ;-)
17511 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
17512 already taken care of by the MS compiler ?
17514 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17516 * class.cs (Operator): New class for operator declarations.
17517 (Operator::OpType): Enum for the various operators.
17519 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
17521 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
17522 ostensibly handle this in semantic analysis.
17524 * cs-parser.jay (general_catch_clause): Comment out
17525 (specific_catch_clauses, specific_catch_clause): Ditto.
17526 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
17527 (catch_args, opt_catch_args): New productions.
17528 (catch_clause): Rewrite to use the new productions above
17529 (catch_clauses): Modify accordingly.
17530 (opt_catch_clauses): New production to use in try_statement
17531 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
17532 and re-write the code in the actions to extract the specific and
17533 general catch clauses by being a little smart ;-)
17535 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
17536 Hooray, try and catch statements parse fine !
17538 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17540 * statement.cs (Block::GetVariableType): Fix logic to extract the type
17541 string from the hashtable of variables.
17543 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
17544 I end up making that mistake ;-)
17545 (catch_clauses): Fixed gross error which made Key and Value of the
17546 DictionaryEntry the same : $1 !!
17548 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17550 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
17552 * cs-parser.jay (event_declaration): Correct to remove the semicolon
17553 when the add and remove accessors are specified.
17555 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
17557 * cs-parser.jay (IndexerDeclaration): New helper class to hold
17558 information about indexer_declarator.
17559 (indexer_declarator): Implement actions.
17560 (parsing_indexer): New local boolean used to keep track of whether
17561 we are parsing indexers or properties. This is necessary because
17562 implicit_parameters come into picture even for the get accessor in the
17563 case of an indexer.
17564 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
17566 * class.cs (Indexer): New class for indexer declarations.
17567 (TypeContainer::AddIndexer): New method to add an indexer to a type.
17568 (TypeContainer::indexers): New member to hold list of indexers for the
17571 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17573 * cs-parser.jay (add_accessor_declaration): Implement action.
17574 (remove_accessor_declaration): Implement action.
17575 (event_accessors_declaration): Implement
17576 (variable_declarators): swap statements for first rule - trivial.
17578 * class.cs (Event): New class to hold information about event
17580 (TypeContainer::AddEvent): New method to add an event to a type
17581 (TypeContainer::events): New member to hold list of events.
17583 * cs-parser.jay (event_declaration): Implement actions.
17585 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
17587 * cs-parser.jay (dim_separators): Implement. Make it a string
17588 concatenating all the commas together, just as they appear.
17589 (opt_dim_separators): Modify accordingly
17590 (rank_specifiers): Update accordingly. Basically do the same
17591 thing - instead, collect the brackets here.
17592 (opt_rank_sepcifiers): Modify accordingly.
17593 (array_type): Modify to actually return the complete type string
17594 instead of ignoring the rank_specifiers.
17595 (expression_list): Implement to collect the expressions
17596 (variable_initializer): Implement. We make it a list of expressions
17597 essentially so that we can handle the array_initializer case neatly too.
17598 (variable_initializer_list): Implement.
17599 (array_initializer): Make it a list of variable_initializers
17600 (opt_array_initializer): Modify accordingly.
17602 * expression.cs (New::NType): Add enumeration to help us
17603 keep track of whether we have an object/delegate creation
17604 or an array creation.
17605 (New:NewType, New::Rank, New::Indices, New::Initializers): New
17606 members to hold data about array creation.
17607 (New:New): Modify to update NewType
17608 (New:New): New Overloaded contructor for the array creation
17611 * cs-parser.jay (array_creation_expression): Implement to call
17612 the overloaded New constructor.
17614 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
17616 * class.cs (TypeContainer::Constructors): Return member
17617 constructors instead of returning null.
17619 2001-08-26 Miguel de Icaza <miguel@ximian.com>
17621 * typemanager.cs (InitCoreTypes): Initialize the various core
17622 types after we have populated the type manager with the user
17623 defined types (this distinction will be important later while
17624 compiling corlib.dll)
17626 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
17627 on Expression Classification. Now all expressions have a method
17628 `Resolve' and a method `Emit'.
17630 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
17631 generation from working. Also add some temporary debugging
17634 2001-08-24 Miguel de Icaza <miguel@ximian.com>
17636 * codegen.cs: Lots of code generation pieces. This is only the
17637 beginning, will continue tomorrow with more touches of polish. We
17638 handle the fundamentals of if, while, do, for, return. Others are
17639 trickier and I need to start working on invocations soon.
17641 * gen-treedump.cs: Bug fix, use s.Increment here instead of
17644 * codegen.cs (EmitContext): New struct, used during code
17645 emission to keep a context. Most of the code generation will be
17648 * cs-parser.jay: Add embedded blocks to the list of statements of
17649 this block. So code generation proceeds in a top down fashion.
17651 2001-08-23 Miguel de Icaza <miguel@ximian.com>
17653 * statement.cs: Add support for multiple child blocks.
17655 2001-08-22 Miguel de Icaza <miguel@ximian.com>
17657 * codegen.cs (EmitCode): New function, will emit the code for a
17658 Block of code given a TypeContainer and its ILGenerator.
17660 * statement.cs (Block): Standard public readonly optimization.
17661 (Block::Block constructors): Link children.
17662 (Block::Child): Child Linker.
17663 (Block::EmitVariables): Emits IL variable declarations.
17665 * class.cs: Drop support for MethodGroups here, delay until
17667 (Method::): Applied the same simplification that I did before, and
17668 move from Properties to public readonly fields.
17669 (Method::ParameterTypes): Returns the parameter types for the
17670 function, and implements a cache that will be useful later when I
17671 do error checking and the semantic analysis on the methods is
17673 (Constructor::GetCallingConvention): Renamed from CallingConvetion
17674 and made a method, optional argument tells whether this is a class
17675 or a structure to apply the `has-this' bit.
17676 (Method::GetCallingConvention): Implement, returns the calling
17678 (Method::Define): Defines the type, a second pass is performed
17679 later to populate the methods.
17681 (Constructor::ParameterTypes): implement a cache similar to the
17682 one on Method::ParameterTypes, useful later when we do semantic
17685 (TypeContainer::EmitMethod): New method. Emits methods.
17687 * expression.cs: Removed MethodGroup class from here.
17689 * parameter.cs (Parameters::GetCallingConvention): new method.
17691 2001-08-21 Miguel de Icaza <miguel@ximian.com>
17693 * class.cs (TypeContainer::Populate): Drop RootContext from the
17696 (Constructor::CallingConvention): Returns the calling convention.
17697 (Constructor::ParameterTypes): Returns the constructor parameter
17700 (TypeContainer::AddConstructor): Keep track of default constructor
17701 and the default static constructor.
17703 (Constructor::) Another class that starts using `public readonly'
17704 instead of properties.
17706 (Constructor::IsDefault): Whether this is a default constructor.
17708 (Field::) use readonly public fields instead of properties also.
17710 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
17711 track of static constructors; If none is used, turn on
17712 BeforeFieldInit in the TypeAttributes.
17714 * cs-parser.jay (opt_argument_list): now the return can be null
17715 for the cases where there are no arguments.
17717 (constructor_declarator): If there is no implicit `base' or
17718 `this', then invoke the default parent constructor.
17720 * modifiers.cs (MethodAttr): New static function maps a set of
17721 modifiers flags into a MethodAttributes enum
17722 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
17723 MethodAttr, TypeAttr to represent the various mappings where the
17724 modifiers are used.
17725 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
17727 2001-08-19 Miguel de Icaza <miguel@ximian.com>
17729 * parameter.cs (GetParameterInfo): Fix bug where there would be no
17732 * interface.cs (PopulateIndexer): Implemented the code generator
17733 for interface indexers.
17735 2001-08-17 Miguel de Icaza <miguel@ximian.com>
17737 * interface.cs (InterfaceMemberBase): Now we track the new status
17740 (PopulateProperty): Implement property population. Woohoo! Got
17741 Methods and Properties going today.
17743 Removed all the properties for interfaces, and replaced them with
17744 `public readonly' fields.
17746 2001-08-16 Miguel de Icaza <miguel@ximian.com>
17748 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
17749 initialize their hashtables/arraylists only when they are needed
17750 instead of doing this always.
17752 * parameter.cs: Handle refs and out parameters.
17754 * cs-parser.jay: Use an ArrayList to construct the arguments
17755 instead of the ParameterCollection, and then cast that to a
17758 * parameter.cs: Drop the use of ParameterCollection and use
17759 instead arrays of Parameters.
17761 (GetParameterInfo): Use the Type, not the Name when resolving
17764 2001-08-13 Miguel de Icaza <miguel@ximian.com>
17766 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
17767 and instead use public readonly fields.
17769 * class.cs: Put back walking code for type containers.
17771 2001-08-11 Miguel de Icaza <miguel@ximian.com>
17773 * class.cs (MakeConstant): Code to define constants.
17775 * rootcontext.cs (LookupType): New function. Used to locate types
17778 2001-08-08 Miguel de Icaza <miguel@ximian.com>
17780 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
17781 this System.Reflection code is. Kudos to Microsoft
17783 * typemanager.cs: Implement a type cache and avoid loading all
17784 types at boot time. Wrap in LookupType the internals. This made
17785 the compiler so much faster. Wow. I rule!
17787 * driver.cs: Make sure we always load mscorlib first (for
17788 debugging purposes, nothing really important).
17790 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
17791 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
17793 * rootcontext.cs: Lookup types on their namespace; Lookup types
17794 on namespaces that have been imported using the `using' keyword.
17796 * class.cs (TypeContainer::TypeAttr): Virtualize.
17797 (Class::TypeAttr): Return attributes suitable for this bad boy.
17798 (Struct::TypeAttr): ditto.
17799 Handle nested classes.
17800 (TypeContainer::) Remove all the type visiting code, it is now
17801 replaced with the rootcontext.cs code
17803 * rootcontext.cs (GetClassBases): Added support for structs.
17805 2001-08-06 Miguel de Icaza <miguel@ximian.com>
17807 * interface.cs, statement.cs, class.cs, parameter.cs,
17808 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
17809 Drop use of TypeRefs, and use strings instead.
17811 2001-08-04 Miguel de Icaza <miguel@ximian.com>
17815 * class.cs (Struct::Struct): set the SEALED flags after
17816 checking the modifiers.
17817 (TypeContainer::TypeAttr): new property, returns the
17818 TypeAttributes for a class.
17820 * cs-parser.jay (type_list): Oops, list production was creating a
17821 new list of base types.
17823 * rootcontext.cs (StdLib): New property.
17824 (GetInterfaceTypeByName): returns an interface by type name, and
17825 encapsulates error handling here.
17826 (GetInterfaces): simplified.
17827 (ResolveTree): Encapsulated all the tree resolution here.
17828 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
17831 * driver.cs: Add support for --nostdlib, to avoid loading the
17832 default assemblies.
17833 (Main): Do not put tree resolution here.
17835 * rootcontext.cs: Beginning of the class resolution.
17837 2001-08-03 Miguel de Icaza <miguel@ximian.com>
17839 * rootcontext.cs: Provide better error reporting.
17841 * cs-parser.jay (interface_base): set our $$ to be interfaces.
17843 * rootcontext.cs (CreateInterface): Handle the case where there
17844 are no parent interfaces.
17846 (CloseTypes): Routine to flush types at the end.
17847 (CreateInterface): Track types.
17848 (GetInterfaces): Returns an array of Types from the list of
17849 defined interfaces.
17851 * typemanager.c (AddUserType): Mechanism to track user types (puts
17852 the type on the global type hash, and allows us to close it at the
17855 2001-08-02 Miguel de Icaza <miguel@ximian.com>
17857 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
17858 RecordInterface instead.
17860 * cs-parser.jay: Updated to reflect changes above.
17862 * decl.cs (Definition): Keep track of the TypeBuilder type that
17863 represents this type here. Not sure we will use it in the long
17864 run, but wont hurt for now.
17866 * driver.cs: Smaller changes to accomodate the new code.
17868 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
17871 * rootcontext.cs (CreateInterface): New method, used to create
17872 the System.TypeBuilder type for interfaces.
17873 (ResolveInterfaces): new entry point to resolve the interface
17875 (CodeGen): Property, used to keep track of the code generator.
17877 2001-07-26 Miguel de Icaza <miguel@ximian.com>
17879 * cs-parser.jay: Add a second production for delegate_declaration
17882 (enum_body): Put an opt_comma here instead of putting it on
17883 enum_body or enum_member_declarations so we can handle trailing
17884 commas on enumeration members. Gets rid of a shift/reduce.
17886 (type_list): Need a COMMA in the middle.
17888 (indexer_declaration): Tell tokenizer to recognize get/set
17890 * Remove old targets.
17892 * Re-add the parser target.
17894 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17896 * cs-parser.jay: Add precendence rules for a number of operators
17897 ot reduce the number of shift/reduce conflicts in the grammar.
17899 2001-07-17 Miguel de Icaza <miguel@ximian.com>
17901 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
17904 Get rid of old crufty code.
17906 * rootcontext.cs: Use this to keep track of the parsed
17907 representation and the defined types available to the program.
17909 * gen-treedump.cs: adjust for new convention.
17911 * type.cs: Split out the type manager, and the assembly builder
17914 * typemanager.cs: the type manager will live here now.
17916 * cil-codegen.cs: And the code generator here.
17918 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
17920 * makefile: Fixed up for easy making.
17922 2001-07-13 Simon Cozens <simon@simon-cozens.org>
17924 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
17927 (unary_expression): Expand pre_increment_expression and
17928 post_decrement_expression to reduce a shift/reduce.
17930 2001-07-11 Simon Cozens
17932 * cs-tokenizer.cs: Hex numbers should begin with a 0.
17934 Improve allow_keyword_as_indent name.
17936 2001-06-19 Miguel de Icaza <miguel@ximian.com>
17938 * Adjustments for Beta2.
17940 2001-06-13 Miguel de Icaza <miguel@ximian.com>
17942 * decl.cs: Added `Define' abstract method.
17943 (InTransit): new property, used to catch recursive definitions.
17945 * interface.cs: Implement `Define'.
17947 * modifiers.cs: Map Modifiers.constants to
17948 System.Reflection.TypeAttribute flags.
17950 * class.cs: Keep track of types and user-defined types.
17951 (BuilderInit): New method for creating an assembly
17952 (ResolveType): New function to launch the resolution process, only
17953 used by interfaces for now.
17955 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
17956 that are inserted into the name space.
17958 2001-06-08 Miguel de Icaza <miguel@ximian.com>
17960 * ARGH. I have screwed up my tree so many times due to the use of
17961 rsync rather than using CVS. Going to fix this at once.
17963 * driver.cs: Objetify driver. Load assemblies, use assemblies to
17966 2001-06-07 Miguel de Icaza <miguel@ximian.com>
17968 * Experiment successful: Use System.Type rather that our own
17971 2001-05-25 Miguel de Icaza <miguel@ximian.com>
17973 * cs-parser.jay: Removed nsAliases from here.
17975 Use new namespaces, handle `using XXX;'
17977 * namespace.cs: Reimplemented namespace handling, use a recursive
17978 definition of the class. Now we can keep track of using clauses
17979 and catch invalid using clauses.
17981 2001-05-24 Miguel de Icaza <miguel@ximian.com>
17983 * gen-treedump.cs: Adapted for all the renaming.
17985 * expression.cs (Expression): this class now has a Type property
17986 which returns an expression Type.
17988 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
17989 `Type', as this has a different meaning now in the base
17991 2001-05-22 Miguel de Icaza <miguel@ximian.com>
17993 * interface.cs, class.cs: Removed from all the sources the
17994 references to signature computation, as we can not do method
17995 signature computation during the parsing time, as we are not
17996 trying to solve at that point distinguishing:
18000 void a (NS.Blah x) {}
18003 Which depending on the context might be valid or not, as we do not
18004 know if Blah is the same thing as NS.Blah at that point.
18006 * Redid everything so the code uses TypeRefs now instead of
18007 Types. TypeRefs are just temporary type placeholders, that need
18008 to be resolved. They initially have a pointer to a string and the
18009 current scope in which they are used. This is used later by the
18010 compiler to resolve the reference to an actual Type.
18012 * DeclSpace is no longer a CIR.Type, and neither are
18013 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
18014 are all DeclSpaces, but no Types.
18016 * type.cs (TypeRefManager): This implements the TypeRef manager,
18017 which keeps track of all the types that need to be resolved after
18018 the parsing has finished.
18020 2001-05-13 Miguel de Icaza <miguel@ximian.com>
18022 * ARGH. We are going to have to store `foreach' as a class rather
18023 than resolving it, as we need to verify error 1579 after name
18024 resolution. *OR* we could keep a flag that says `This request to
18025 IEnumerator comes from a foreach statement' which we can then use
18026 to generate the error.
18028 2001-05-10 Miguel de Icaza <miguel@ximian.com>
18030 * class.cs (TypeContainer.AddMethod): we now add methods to the
18031 MethodGroup instead of the method hashtable.
18033 * expression.cs: Add MethodGroup abstraction, which gets us one
18034 step closer to the specification in the way we handle method
18037 * cs-parser.jay (primary_expression): qualified_identifier now
18038 tried to match up an identifier to a local variable reference or
18039 to a parameter reference.
18041 current_local_parameters is now a parser global variable that
18042 points to the current parameters for the block, used during name
18045 (property_declaration): Now creates an implicit `value' argument to
18048 2001-05-09 Miguel de Icaza <miguel@ximian.com>
18050 * parameter.cs: Do not use `param' arguments as part of the
18051 signature, per the spec.
18053 2001-05-08 Miguel de Icaza <miguel@ximian.com>
18055 * decl.cs: Base class for classes, structs and interfaces. This
18056 is the "Declaration Space"
18058 * cs-parser.jay: Use CheckDef for checking declaration errors
18059 instead of having one on each function.
18061 * class.cs: Factor out some code for handling error handling in
18062 accordance to the "Declarations" section in the "Basic Concepts"
18063 chapter in the ECMA C# spec.
18065 * interface.cs: Make all interface member classes derive from
18066 InterfaceMemberBase.
18068 2001-05-07 Miguel de Icaza <miguel@ximian.com>
18070 * Many things: all interfaces are parsed and generated in
18071 gen-treedump. Support for member variables, constructors,
18072 destructors, properties, constants is there.
18074 Beginning of the IL backend, but very little done, just there for
18077 2001-04-29 Miguel de Icaza <miguel@ximian.com>
18079 * cs-parser.jay: Fix labeled statement.
18081 * cs-tokenizer.cs (escape): Escape " and ' always.
18082 ref_line, ref_name: keep track of the line/filename as instructed
18083 by #line by the compiler.
18086 2001-04-27 Miguel de Icaza <miguel@ximian.com>
18088 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
18089 to match the values in System.CodeDOM.
18091 Divid renamed to Divide.
18093 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
18095 (Statements.set): remove.
18097 * System.CodeDOM/CodeCatchClause.cs: always have a valid
18100 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
18101 falseStatements always have valid values.
18103 * cs-parser.jay: Use System.CodeDOM now.