1 2008-05-22 Marek Safar <marek.safar@gmail.com>
3 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
5 2008-05-21 Marek Safar <marek.safar@gmail.com>
7 * cs-parser.jay: Removed redundant catch type check.
9 2008-05-21 Marek Safar <marek.safar@gmail.com>
12 * nullable.cs: Set correct return type.
14 2008-05-21 Marek Safar <marek.safar@gmail.com>
17 * typemanager.cs: Fixed crash when comparing null types.
19 2008-05-21 Marek Safar <marek.safar@gmail.com>
22 * cs-parser.jay: Better error handling for invalid catch type.
24 2008-05-20 Marek Safar <marek.safar@gmail.com>
27 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
29 2008-05-15 Marek Safar <marek.safar@gmail.com>
32 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
35 2008-05-15 Marek Safar <marek.safar@gmail.com>
37 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
40 2008-05-13 Marek Safar <marek.safar@gmail.com>
43 * delegate.cs, generic.cs: Some progress on method group return type
46 2008-05-13 Marek Safar <marek.safar@gmail.com>
49 * namespace.cs: Inspect also parent namespaces not only namespace entries.
51 2008-05-12 Marek Safar <marek.safar@gmail.com>
53 * class.cs (Constructor): Added IsCompilerGenerated.
55 2008-05-12 Marek Safar <marek.safar@gmail.com>
57 * expression.cs: Enum binary operators can accept non-enum operand only when
58 is implicitly convertible to underlying type.
60 2008-05-12 Marek Safar <marek.safar@gmail.com>
63 * support.cs: Workaround System.InvalidOperationException for enums.
65 2008-05-12 Marek Safar <marek.safar@gmail.com>
68 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
70 2008-05-10 Marek Safar <marek.safar@gmail.com>
72 * driver.cs: Split Parse.
74 * location.cs (LookupFile): Uses string.Empty.
76 2008-05-07 Marek Safar <marek.safar@gmail.com>
78 * expression.cs, parameter.cs: Small ParameterReference clean up.
80 2008-05-07 Marek Safar <marek.safar@gmail.com>
82 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
85 2008-05-06 Martin Baulig <martin@ximian.com>
87 * class.cs (Constructor.Emit): Fix the logic whether to emit
90 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
93 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
94 InvalidOperationException when the iterator is before the start or
97 2008-05-06 Marek Safar <marek.safar@gmail.com>
99 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
100 when left is nullable type.
102 2008-05-06 Marek Safar <marek.safar@gmail.com>
104 A fix for bug #386628
105 * expression.cs (LocalVariableReference): Continue in resolving when
106 variable is not assigned.
108 2008-05-05 Marek Safar <marek.safar@gmail.com>
110 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
113 2008-05-04 Marek Safar <marek.safar@gmail.com>
115 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
116 it saves many redundant temporary variables for nullable operations.
118 2008-05-03 Marek Safar <marek.safar@gmail.com>
120 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
122 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
125 * nullable.cs: Constant coalescing operator optimizations.
127 2008-05-03 Marek Safar <marek.safar@gmail.com>
129 * constant.cs: Use unsigned conversion for values which are unsigned only.
131 2008-05-03 Marek Safar <marek.safar@gmail.com>
133 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
134 coalescing operator as it should be.
136 2008-05-02 Marek Safar <marek.safar@gmail.com>
138 A fix for bug #371016
139 * expression.cs: All predefined delegate operators require implicit method
142 2008-05-02 Marek Safar <marek.safar@gmail.com>
144 * constant.cs: Emit long constant as uint when fits the range.
146 * convert.cs, expression.cs: Fixed few unsafe conversions.
148 2008-05-02 Marek Safar <marek.safar@gmail.com>
150 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
152 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
155 * convert.cs (ImplicitNumericConversion): Don't modify the type of
157 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
159 2008-05-01 Marek Safar <marek.safar@gmail.com>
161 * constant.cs, literal.cs: IsLiteral property for error reporting.
163 * ecore.cs, expression.cs: Implemented Property expression.
165 2008-05-01 Marek Safar <marek.safar@gmail.com>
167 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
169 * nullable.cs: Implemented nullable coalescing null operator.
171 * ecore.cs, expression.cs: Expression trees work.
173 2008-05-01 Marek Safar <marek.safar@gmail.com>
175 * ecore.cs: CreateExpressionTree is finally abstract.
177 * expression.cs, linq.cs: Updated.
179 2008-05-01 Marek Safar <marek.safar@gmail.com>
181 * expression.cs, ecore.cs: Block base access expression inside expression
184 2008-05-01 Marek Safar <marek.safar@gmail.com>
186 A fix for bug #385058
187 * expression.cs: User-defined operator implementations always take
188 precedence over predefined operator implementations.
190 2008-04-30 Marek Safar <marek.safar@gmail.com>
192 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
193 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
194 expression tree conversions.
196 2008-04-30 Marek Safar <marek.safar@gmail.com>
198 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
199 operators method details to Operator class.
201 2008-04-30 Marek Safar <marek.safar@gmail.com>
203 * anonymous.cs: Pass unsafe flags to anonymous container.
205 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
206 inside expression tree.
208 2008-04-29 Martin Baulig <martin@ximian.com>
210 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
211 (Tokenizer.PopPosition): Also restore the `line'.
213 2008-04-29 Marek Safar <marek.safar@gmail.com>
215 * delegate.cs: Implemented Invoke expression.
217 2008-04-29 Marek Safar <marek.safar@gmail.com>
219 * expression.cs: Fixed equality reference comparison regression.
221 2008-04-29 Marek Safar <marek.safar@gmail.com>
223 * ecore.cs: Clean up EmptyCast hack.
225 * expression.cs, nullable.cs: Implemented enum binary and unary operations
226 using correct conversion rules. Also fixes #383993.
228 2008-04-28 Martin Baulig <martin@ximian.com>
230 * class.cs (Constructor.Emit): Don't emit debugging information
231 for generated default .ctor's.
233 2008-04-28 Marek Safar <marek.safar@gmail.com>
235 * convert.cs: Empty-cast ushort to int conversion.
237 2008-04-28 Marek Safar <marek.safar@gmail.com>
239 A fix for bug #384191
240 * ecore.cs, expression.cs: Fixed expression cloning.
242 2008-04-28 Marek Safar <marek.safar@gmail.com>
244 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
246 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
248 Fix #381559, test-638.cs, test-639.cs
249 * assign.cs (CompoundAssign.Helper): New wrapper.
250 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
252 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
253 Pass unconverted expressions to the params array creation expression.
254 (FieldExpr.EmitAssign): Don't special-case StringConcat.
255 (PropertyExpr.EmitAssign): Likewise.
256 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
257 element if it is of kind CompoundAssign.Helper.
258 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
259 first before anything else.
260 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
261 (ArrayAccess.LoadArrayAndArguments): Simplify.
263 2008-04-27 Marek Safar <marek.safar@gmail.com>
265 * expression.cs: Fixed cloning of typeof(void).
267 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
269 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
270 (Assign.Emit): Likewise. Move it to ...
271 (CompoundAssign.DoResolve): ... here and ...
272 (CompoundAssign.Emit): ... here.
273 (EventAddOrRemove): New helper to handle += and -= on events, and
274 avoid the use of BinaryDelegates.
275 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
276 (EventExpr.EmitAddOrRemove): Improve.
277 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
279 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
280 create VarExprs for 'foo.bar.var'.
281 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
282 is a highly inappropriate name for its functionality.
284 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
286 Simplify handling of multiple assignments
287 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
289 (SimpleAssign): New. Class to be used for normal assignments.
290 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
291 * expression.cs, parameter.cs, statement.cs: Likewise.
293 2008-04-25 Marek Safar <marek.safar@gmail.com>
295 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
296 for incompatible underlying types, more to come, uff.
298 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
301 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
304 2008-04-25 Marek Safar <marek.safar@gmail.com>
306 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
308 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
310 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
311 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
312 * statement.cs (While, Do, For): Allow test to have side effects.
313 (For.DoEmit): Always emit InitStatement.
316 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
317 Always create SideEffectConstant.
318 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
319 of type EnumConstant.
321 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
322 Handle 'right' being SideEffectConstant of type 'bool'.
324 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
325 Use left.EmitBranchable instead of open coding it, so as to
326 improve optimization opportunities.
328 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
330 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
332 (Expression.EmitSideEffect): Document.
334 2008-04-23 Marek Safar <marek.safar@gmail.com>
336 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
338 2008-04-23 Marek Safar <marek.safar@gmail.com>
340 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
342 2008-04-23 Marek Safar <marek.safar@gmail.com>
344 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
345 conversion to expression tree.
347 2008-04-23 Marek Safar <marek.safar@gmail.com>
349 * ecore.cs: Removed unused expression.
351 2008-04-22 Marek Safar <marek.safar@gmail.com>
353 * expression.cs: Implemented NegateChecked and New expressions.
355 2008-04-22 Marek Safar <marek.safar@gmail.com>
357 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
359 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
362 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
363 needing final 'ret' instruction.
365 2008-04-22 Marek Safar <marek.safar@gmail.com>
367 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
369 2008-04-21 Marek Safar <marek.safar@gmail.com>
371 * expression.cs: Emit ldnull and not null expression as an instance argument
372 of static method expression calls.
374 2008-04-21 Marek Safar <marek.safar@gmail.com>
376 A fix for bug #378200
377 * expression.cs: Fixed crash when creating parameterless expression tree
380 2008-04-21 Marek Safar <marek.safar@gmail.com>
382 A fix for bug #375297
383 * anonymous.cs: Fixed crash when inferring from null argument anonymous
386 2008-04-21 Marek Safar <marek.safar@gmail.com>
388 A fix for bug #377596
389 * decl.cs, class.cs: Emit delegate type argument attributes.
391 2008-04-21 Marek Safar <marek.safar@gmail.com>
393 A fix for bug #365314
394 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
396 2008-04-21 Marek Safar <marek.safar@gmail.com>
398 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
401 2008-04-21 Marek Safar <marek.safar@gmail.com>
403 * generic.cs (TypeParameter): Removed redundant location.
405 2008-04-19 Marek Safar <marek.safar@gmail.com>
407 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
408 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
409 FullNamedExpression in all declaration type expression, statements will come
412 2008-04-18 Marek Safar <marek.safar@gmail.com>
414 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
415 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
417 2008-04-18 Marek Safar <marek.safar@gmail.com>
419 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
422 2008-04-17 Marek Safar <marek.safar@gmail.com>
424 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
427 2008-04-17 Marek Safar <marek.safar@gmail.com>
429 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
433 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
435 Hook up 'EmitSideEffect'
436 * constant.cs (Constant.EmitSideEffect): New.
437 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
438 (SideEffectConstant.EmitSideEffect): New.
439 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
440 unconditional branch in EmitBranchable.
441 (FieldExpr.EmitBranchable): New.
442 * expression.cs (Unary.EmitSideEffect): New.
443 (Binary.EmitSideEffect): New.
444 (VariableReference.EmitSideEffect): New. Do nothing.
446 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
448 Introduce 'EmitSideEffect'
449 * ecore.cs (Expression.EmitSideEffect): New.
450 (TypeCast): Rename from EmptyCast.
452 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
453 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
454 * convert.cs, nullable.cs: Update to changes.
456 2008-04-16 Marek Safar <marek.safar@gmail.com>
458 * class.cs, cs-parser.jay: Early check for base types expression.
460 2008-04-16 Marek Safar <marek.safar@gmail.com>
462 * decl.cs (MemberName): Declare PrettyName as obsolete.
464 2008-04-16 Marek Safar <marek.safar@gmail.com>
466 * namespace.cs: Use MemberName comparison.
468 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
471 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
473 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
474 (MemberName.FullyQualifiedName): New. Provides the functionality
475 that users assume FullName would have.
476 * ecore.cs, namespace.cs: Update to changes.
478 * statement.cs (Using.assign): Make into ExpressionStatement.
479 (Using.EmitPreTryBody): Simplify.
481 2008-04-16 Marek Safar <marek.safar@gmail.com>
483 * report.cs: ColorFormat is protected.
485 * rootcontext.cs: Unused fields clean-up.
487 * namespace.cs: Made UsingEntry name private.
489 2008-04-16 Marek Safar <marek.safar@gmail.com>
491 * cs-tokenizer.cs, location.cs: Removed unused field.
493 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
494 Raja R Harinath <harinath@hurrynot.org>
497 * constant.cs (SideEffectConstant.value): Rename from 'left'.
498 (SideEffectConstant.side_effect): Rename from 'right'.
499 (SideEffectConstant..ctor): Normalize 'side_effect'.
500 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
501 value of this constant.
502 * cfold.cs: Update to changes.
504 2008-04-15 Marek Safar <marek.safar@gmail.com>
506 * cs-paser.jay: Removed unused variable.
508 * driver.cs: Made Compile instance method.
510 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
512 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
514 2008-04-15 Marek Safar <marek.safar@gmail.com>
516 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
518 2008-04-13 Jb Evain <jbevain@novell.com>
520 * namespace.cs: update the System.Core fullname for 2.1
521 * driver.cs: update the list of required assemblies for 2.1.
522 Merged from the Moonlight 2 branch.
524 2008-04-11 Marek Safar <marek.safar@gmail.com>
526 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
527 types and user defined operators. User operators arguments has to be checked
528 for null value before invocation, which also means no operator is called
529 when any argument is not convertible to unwrapped nullable type.
531 2008-04-09 Marek Safar <marek.safar@gmail.com>
533 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
534 of Unary expressions to follow operator overloading rules precisely.
535 Also fixes #321794, #323794
537 2008-04-08 Marek Safar <marek.safar@gmail.com>
539 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
542 2008-04-08 Marek Safar <marek.safar@gmail.com>
544 * expression.cs, ecore.cs: Implemented MemberInit expression.
546 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
548 Fix mono/tests/exception4.cs
549 * statement.cs (ExceptionStatement, TryCatch): Revert to using
550 ec.NeedReturnLabel () rather emitting a 'nop'.
552 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
554 (TryCatch.SomeCodeFollows): Likewise.
555 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
556 for 'break', 'continue' and 'return' statements inside a try.
557 We're fairly sure that the generated IL stream will have more
558 instructions textually following the try.
559 (FlowBranchingTryCatch): Likewise.
561 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
562 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
565 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
566 wrapper -- forward everything to CollectionForeach.
567 (CollectionForeach.NonDisposableWrapper): New.
568 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
569 instead of a pop + branch to end.
571 2008-04-07 Marek Safar <marek.safar@gmail.com>
573 A fix for bug #377485
574 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
575 Propagate location for extension method groups. Report conversion failure at
578 2008-04-07 Marek Safar <marek.safar@gmail.com>
580 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
581 ListInit and Field expressions.
583 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
585 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
586 Since $PC is always -1 inside the body of MoveNext, the fault
588 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
589 * statement.cs (ExceptionStatement.emit_finally): Likewise.
590 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
592 The denouement! Fix #324708
593 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
594 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
595 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
596 'finally' inside the finally clause.
598 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
599 inside an iterator. Don't emit the body of the 'finally' inside
600 the finally clause yet.
602 Use the ResumableStatement infrastructure for MoveNext ()
603 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
604 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
605 'old_resume_points'. Move dispatcher upfront.
606 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
607 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
608 in an enumerator. This encodes the main fix in this patch series
609 -- we can only jump into the first instruction of a try from the
610 outside, but we want to emit try/finally regions in iterators and
611 resume in the middle of them.
613 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
615 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
616 of NeedReturnLabel here.
618 Introduce a common point for emitting try/finally to IL
619 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
620 features of the various subclasses, which are now driven by ...
621 (ExceptionStatement.EmitPreTryBody): ... this and ...
622 (ExceptionStatement.EmitTryBody): ... this and the original
624 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
625 Remove DoEmit and update to follow above protocol.
627 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
628 of the dispatcher are the same, skip emitting the 'switch'.
629 * iterator.cs (Iterator.EmitDispose): Update to changes.
631 Clean up handling of 'using' statement
632 * statement.cs (UsingTemporary): New. Carved out of ...
633 (Using): ... this. Simplify drastically. Handle exactly
635 * cs-parser.jay (using_statement): Split. Create UsingTemporary
636 or Using as appropriate. If there are multiple variable declared,
637 create nested Using statements.
638 (resource_acquisition): Kill.
640 * statement.cs (ExceptionStatement.EmitForDispose): Use
641 EmitFinallyBody, not EmitFinally.
643 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
644 * iterator.cs: Update to changes.
646 Start using the ResumableStatement infrastructure
647 * statement.cs (ResumeableStatement.PrepareForDispose): New.
648 (ResumableStatement.EmitForDispose): New.
649 (ExceptionStatement): Override them.
650 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
651 EmitForDispose to create the body of the Dispose method. Don't
654 * iterator.cs (Iterator.AddResumePoint): Move here from ...
655 * statement.cs (Toplevel.AddResumePoint): ... here.
656 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
657 * flowanalysis.cs (FlowBranchingIterator): New.
658 * codegen.cs (EmitContext): Update to changes.
660 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
661 (Iterator.old_resume_points): Rename from 'resume_points'.
662 (Iterator.MoveNextStatement): Remove unused class.
664 New infrastructure for try/finally in iterators (still unused)
665 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
666 (FlowBranchingToplevel.AddResumePoint): Hook into
667 ToplevelBlock.AddResumePoint.
668 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
669 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
670 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
671 resume points and assign program-counter values.
672 (ExceptionBlock.AddResumePoint): Collect resume points for
673 de-muxer at the top of try block.
674 * iterators.cs (Yield.CheckContext): Simplify.
675 (Yield.Resolve): Use FlowBranching.AddResumePoint.
677 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
679 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
680 argument to an ExitStatement.
681 (FlowBranchingException): Refactor saved origins code.
682 * statement.cs (ExitStatement): Update to cahges.
683 * iterator.cs (YieldBreak): Likewise.
685 * statement.cs (ResumableStatement): New. Common base class for
686 YieldReturn and ExceptionStatement.
687 (ExitStatement): New. Common base class for Return and YieldBreak.
688 (Return): Update to changes.
689 * iterator.cs (YieldBreak): Likewise.
690 * lambda.cs (ContextualReturn): Likewise.
693 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
694 emit a meaningful error message.
697 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
698 (VariableInfo.SetAssigned): Set it.
699 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
700 determine if CS0219 or CS0168 is appropriate. Don't use
701 flow-analysis information.
702 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
703 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
704 (EmitContext.EndFlowBranching): ... this.
706 2008-04-03 Marek Safar <marek.safar@gmail.com>
708 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
710 2008-04-03 Marek Safar <marek.safar@gmail.com>
712 A fix for bug #376508
713 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
714 ImplicitConversionExists.
716 2008-04-03 Marek Safar <marek.safar@gmail.com>
718 * expression.cs (Binary): Added remaining binary operators to expression
721 * nullable.cs: Optimize shift with null argument.
723 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
725 Fix minor IL regression
726 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
727 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
728 * cs-parser.jay (try_statement): Update to changes.
730 * statement.cs (TryFinally.need_exc_block): Delete.
731 (TryFinally): Update to changes.
733 Now all ExceptionStatements are unconditional
734 * statement.cs (CollectionForeach.DisposableWrapper): New.
735 Extract out the try/finally code into a new wrapper.
736 (CollectionForeach.Resolve): Use it to simplify the code.
738 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
740 Start at simplifying ExceptionStatement semantics a bit
741 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
742 * cs-parser.jay (try_statement): Update to changes.
743 (opt_catch_clauses): Remove.
744 * flowanalysis.cs: Update to changes.
745 (FlowBranching.BranchingType.TryCatch): New.
746 (FlowBranchingTryCatch): New.
748 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
749 (FlowBranching.CreateBranching): Update to changes.
750 (FlowBranchingBlock.AddSibling): Add sanity check.
751 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
754 * iterators.cs (Iterator.MarkFinally): Remove.
755 * statement.cs (ExceptionStatement): Update to changes.
757 Add support for skipping over finally blocks at runtime. First
758 in a series to fix #324708
759 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
760 (Iterator.EmitMoveNext): Initialize it.
761 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
762 branch over the body of the 'finally' clause.
764 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
766 Avoid lopsided use of Foo/DoFoo names
767 * statement.cs (ExpressionStatement.EmitFinallyBody):
768 Rename from EmitFinally.
769 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
770 * iterator.cs: Update to changes.
772 2008-04-02 Marek Safar <marek.safar@gmail.com>
774 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
775 based on UserOperatorCall. More binary nullable operators clean up.
777 2008-04-02 Martin Baulig <martin@ximian.com>
779 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
781 2008-04-02 Marek Safar <marek.safar@gmail.com>
783 * nullable.cs: Merge user and empty conversions when lifting expression
786 * expression.cs (StringConcat): Implemented expression tree representation.
788 2008-04-01 Marek Safar <marek.safar@gmail.com>
790 * nullable.cs: When lifting null literal and a user operator exists, no call
793 2008-04-01 Marek Safar <marek.safar@gmail.com>
795 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
798 2008-04-01 Marek Safar <marek.safar@gmail.com>
800 * nullable.cs, expression.cs: Use namespace instead heavily nested
801 monster abstract class.
803 2008-04-01 Marek Safar <marek.safar@gmail.com>
805 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
806 lifting of null literal and user operators. Clean up of some temporary
809 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
811 Fix #368224, test-629.cs
812 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
813 if it crossed an unwind-protect boundary.
814 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
815 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
816 inside an unwind-protected region.
817 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
818 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
819 'leave' instead of a 'br' if unwind-protected.
820 (Iterator.EmitYieldBreak): Likewise.
822 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
824 * driver.cs: Only define versioninfo resources if no win32 resource
827 2008-03-28 Marek Safar <marek.safar@gmail.com>
829 A fix for bug #372375
830 * convert.cs: Fixed boxing of nullable types.
832 2008-03-28 Marek Safar <marek.safar@gmail.com>
834 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
837 2008-03-28 Marek Safar <marek.safar@gmail.com>
839 A fix for bug #374619
840 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
842 2008-03-27 Marek Safar <marek.safar@gmail.com>
844 * lambda.cs: Check return type only for invocation.
846 2008-03-27 Marek Safar <marek.safar@gmail.com>
848 A fix for bug #374214
849 * ecore.cs: Correctly report argument type mismatch.
851 2008-03-27 Marek Safar <marek.safar@gmail.com>
853 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
854 and not rely on broken IsEnum.
856 2008-03-27 Marek Safar <marek.safar@gmail.com>
858 * nullable.cs: New file, extracted from generic.cs.
860 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
862 2008-03-27 Marek Safar <marek.safar@gmail.com>
864 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
865 predefined comparison operators and null literals.
867 * report.cs: New warning ID.
869 2008-03-25 Marek Safar <marek.safar@gmail.com>
871 A fix for bug #370577
872 * lambda.cs: Check return type too.
874 2008-03-25 Marek Safar <marek.safar@gmail.com>
876 A fix for bug #372846
877 * class.cs: Automatic properties can be declared as unsafe.
879 2008-03-20 Marek Safar <marek.safar@gmail.com>
881 * location.cs: Use string based concatenation.
883 * expression.cs: LiftedBinaryOperator is gmcs only.
885 2008-03-20 Marek Safar <marek.safar@gmail.com>
887 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
888 conversions rules and expression trees.
890 2008-03-19 Marek Safar <marek.safar@gmail.com>
892 * delegate.cs: Use extension method source as delegate target.
894 2008-03-19 Marek Safar <marek.safar@gmail.com>
896 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
897 binary operations to be purely based on binary operations and optimized
898 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
899 and other ET refactoring.
901 * typemanager.cs: Fixed warning.
903 2008-03-17 Marek Safar <marek.safar@gmail.com>
905 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
907 * symbolwriter.cs: Fixed.
909 2008-03-17 Marek Safar <marek.safar@gmail.com>
911 * anonymous.cs, driver.cs: Reset anonymous types counters.
913 2008-03-17 Marek Safar <marek.safar@gmail.com>
915 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
917 * class.cs: Use fullname for all type member definitions.
919 2008-02-19 Martin Baulig <martin@ximian.com>
922 (IMethodData.EmitExtraSymbolInfo): New interface method.
923 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
924 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
925 interface method here as an empty public virtual method.
928 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
929 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
930 CodeGen.SymbolWriter.SetRealMethodName().
932 2008-02-18 Martin Baulig <martin@ximian.com>
935 (ScopeInfo.EmitType): Override this and emit debugging
936 information for captured variables.
937 (RootScopeInfo.EmitType): Override this and emit symbol
938 information for a captured `this'.
940 2008-02-15 Martin Baulig <martin@ximian.com>
942 * iterators.cs: Emit debugging info.
945 (EmitContext.Flags): Add `OmitDebuggingInfo'.
946 (EmitContext.OmitDebuggingInfo): New public property.
949 (While): Override Emit() and don't emit symbol info there; do it
950 inside DoEmit() instead.
951 (Block.Emit): Omit symbol information while emitting the scope
952 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
954 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
955 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
956 .ctor to make `IsIterator' work.
958 2008-03-14 Martin Baulig <martin@ximian.com>
960 * symbolwriter.cs: Added the new symbol writer function from the
961 debugger's `terrania' branch; temporarily enclose them inside
962 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
965 2008-03-14 Martin Baulig <martin@ximian.com>
968 (SymbolWriter): Make this a public static class.
971 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
972 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
974 2008-03-14 Marek Safar <marek.safar@gmail.com>
976 A fix for bug #370577
977 * statement.cs, lambda.cs: Added extra limitations when dealing with void
980 2008-03-14 Marek Safar <marek.safar@gmail.com>
982 * typemanager.cs (CSharpName): Made 250 times faster.
984 2008-03-13 Marek Safar <marek.safar@gmail.com>
986 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
988 2008-03-12 Marek Safar <marek.safar@gmail.com>
990 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
991 crash when predefined field does not exist.
993 2008-03-12 Marek Safar <marek.safar@gmail.com>
995 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
997 2008-03-12 Marek Safar <marek.safar@gmail.com>
999 * class.cs (FixedField): Don't crash when contructors are missing.
1001 2008-03-11 Marek Safar <marek.safar@gmail.com>
1003 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
1004 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
1005 check internal types accessibility for internal and external types.
1006 Replaced EnumToUnderlying by GetEnumUnderlyingType.
1008 2008-03-11 Marek Safar <marek.safar@gmail.com>
1010 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
1011 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
1012 attribute.cs, statement: Use corect instance of predefined types (work
1013 related to #364674).
1015 2008-03-07 Marek Safar <marek.safar@gmail.com>
1017 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
1019 2008-03-07 Marek Safar <marek.safar@gmail.com>
1021 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
1022 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
1023 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
1024 predefined types clean up, delayed predefined types members initialization
1025 (work related to #364674).
1027 2008-03-05 Marek Safar <marek.safar@gmail.com>
1029 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
1031 2008-03-05 Marek Safar <marek.safar@gmail.com>
1033 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
1034 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
1035 predefined types clean up (work related to #364674).
1037 2008-03-04 Marek Safar <marek.safar@gmail.com>
1039 * ecore.cs: Print an error message instead of throwing exception.
1041 2008-03-04 Marek Safar <marek.safar@gmail.com>
1043 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
1044 expression.cs, statement.cs: Unififed null literal representation.
1046 2008-03-03 Marek Safar <marek.safar@gmail.com>
1048 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
1049 expression.cs: Refactored binary operators resolve phase and improved speed.
1050 The nullable code is still missing and won't work correctly, more fixes
1053 It also fixes #323726, #324312, #324248, and many other unreported issues.
1055 2008-02-29 Zoltan Varga <vargaz@gmail.com>
1057 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
1060 2008-02-27 Marek Safar <marek.safar@gmail.com>
1062 * ecore.cs: Clean-up and split BetterConversion.
1064 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
1067 * enum.cs (EnumMember.Value): Only access 'value' if
1068 ResolveValue says it's ok.
1069 (EnumMember.DoResolveValue): Don't set prev_member.value.
1070 (Enum.GetDefinition): Reverse arguments of Equals --
1071 EnumMember.Value can return 'null'.
1073 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
1075 2008-02-22 Marek Safar <marek.safar@gmail.com>
1077 * generic.cs, expression.cs: More ongoing work on expression trees.
1079 2008-02-21 Marek Safar <marek.safar@gmail.com>
1081 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
1082 handle missing matches when mutiple operators exist.
1084 2008-02-20 Marek Safar <marek.safar@gmail.com>
1086 A fix for bug #363218
1087 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
1090 2008-02-20 Marek Safar <marek.safar@gmail.com>
1092 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
1093 update. This time to deal correctly with SideEffectConstant expression used
1094 as an argument for another constant folding.
1096 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
1098 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
1101 2008-02-19 Marek Safar <marek.safar@gmail.com>
1103 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
1105 2008-02-19 Marek Safar <marek.safar@gmail.com>
1107 A fix for bug #328136
1108 * expression.cs: Do not fold immediately LogicalAnd operators when the left
1109 side is a false constant, because we still need to evaluate the right-hand
1112 * statement.cs (If): Emit two types of boolean constants (simple constant,
1113 side-effect constant).
1115 2008-02-19 Marek Safar <marek.safar@gmail.com>
1117 * constant.cs (SideEffectConstant): Don't emit boolean constant.
1119 * expression.cs: Fold immediately LogicalAnd operators when both sides are
1122 2008-02-18 Marek Safar <marek.safar@gmail.com>
1124 A fix for bug #361457
1125 * ecore.cs (IsApplicable): Params methods have lower priority.
1127 * support.cs: Return correct parameter modifier for params types.
1129 2008-02-18 Marek Safar <marek.safar@gmail.com>
1131 * generic.cs (TypeParameter): Cache attribute target name.
1133 * support.cs: Removed unused variable.
1135 * typemanager.cs: Removed debugging leftover.
1137 * ecore.cs: Use local type instead of a property;
1139 * class.cs (VerifyMembers): Consider also parent to test whether type member
1142 * expression.cs (FullMethodDesc): Removed.
1144 * attribute.cs (IsValidArgumentType): Made static.
1146 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
1148 Cleanup to be more readable.
1149 * Makefile (GMCS_PROFILE): Remove.
1150 (COMPILER_NAME): New helper.
1152 2008-02-15 Miguel de Icaza <miguel@novell.com>
1154 * cs-tokenizer.cs: if a conditional expression happens inside a
1155 (...) this also means that we do not need to de-ambiguate between
1156 an parenthesized expression and a cast.
1160 * constant.cs (SideEffectConstant): a constant value that happens
1161 to have a side effect.
1163 Fixes the build regressions introduced by the fix for #359789
1165 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
1167 * expression.cs (Conditional.Emit): when emitting the ternary
1168 operator, use local variables to generate code verifiable code.
1170 The verifier cannot infer that the type on stack before the
1171 stloc.0 is executed is of type ParentB. This happens because the
1172 stack merge algorithm uses only parent types when deciding which
1173 is the common type. This is described in Part III 1.8.1.3 of ECMA
1176 This code compiled with mcs is not verifiable under MS. The MS
1177 verifier picks the first common interface of Foo and Bar, which is
1178 wrong, but doesn't use a full join type of the 2 interfaces.
1180 CSC uses a clever hack to compile such code in a verifiable
1181 way. It stores the intermediate values in a local variable with
1186 2008-02-14 Miguel de Icaza <miguel@novell.com>
1188 * expression.cs: Do not fold BitwiseAnd operators when the left
1189 side is a false constant, because we still need to evaluate the
1194 * support.cs: Instead of throwing an InternalErrorException when
1195 the position of the stream is outside the boundary of our buffer,
1196 reset the state of the reader, and restart the reading from the
1197 beginning of the file.
1199 2008-02-14 Marek Safar <marek.safar@gmail.com>
1201 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
1203 2008-02-14 Marek Safar <marek.safar@gmail.com>
1205 A fix for bug #361686
1206 * decl.cs: A protected types used inside a private class which parents
1207 derives from the protected class are accessible.
1209 2008-02-13 Marek Safar <marek.safar@gmail.com>
1211 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
1212 the parameterless constructor.
1214 2008-02-13 Marek Safar <marek.safar@gmail.com>
1216 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
1217 lookup methods to use standard member cache when doing member lookup.
1219 2008-02-12 Marek Safar <marek.safar@gmail.com>
1221 * driver.cs: Don't report full path for referenced module as assembly error.
1223 2008-02-12 Marek Safar <marek.safar@gmail.com>
1225 * Makefile: Fixed `qh' target to work on all machines.
1227 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
1228 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
1229 and HasElementType with TypeManager implementation.
1231 2008-02-08 Marek Safar <marek.safar@gmail.com>
1233 A fix for bugs #325134, #359749
1234 * expression.cs, ecore.cs: Try to resolve an extension method even if the
1235 first binds point to non-method member expression.
1237 2008-02-08 Marek Safar <marek.safar@gmail.com>
1239 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
1241 2008-02-08 Marek Safar <marek.safar@gmail.com>
1243 A fix for bugs #321394, #323028
1244 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
1245 Reworked naive IsAccessibleAs implementation to handle nested types.
1247 2008-02-05 Jb Evain <jbevain@novell.com>
1249 * class.cs: use generic type comparison for parameters
1252 2008-02-05 Marek Safar <marek.safar@gmail.com>
1254 A fix for bug #325372
1255 * class.cs: Use generic type comparison when testing method signatures.
1257 2008-02-05 Marek Safar <marek.safar@gmail.com>
1259 A fix for bug #357047
1260 * ecore.cs: Applied C# 3.0 changes to better conversion.
1262 2008-02-05 Marek Safar <marek.safar@gmail.com>
1264 A fix for bug #358374
1265 * cs-parser.jay: Correctly set modifiers for all constructor types.
1267 2008-02-04 Marek Safar <marek.safar@gmail.com>
1269 A fix for bug #355251
1270 * generic.cs: Added base class constraint based type inference.
1272 2008-02-01 Marek Safar <marek.safar@gmail.com>
1274 A fix for bug #357255
1275 * decl.cs: One more missing visibility check.
1277 2008-02-01 Marek Safar <marek.safar@gmail.com>
1279 * support.cs: Fixed broken return.
1281 2008-01-25 Marek Safar <marek.safar@gmail.com>
1283 * report.cs: Correctly reset warnings count after probing.
1285 2008-01-25 Martin Baulig <martin@ximian.com>
1288 (NamespaceEntry.SymbolFileID): Make this work again after
1289 MemberName.ToString() is gone.
1291 2008-01-25 Marek Safar <marek.safar@gmail.com>
1293 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
1296 2008-01-25 Marek Safar <marek.safar@gmail.com>
1298 * generic.cs: Use full implicit conversion for type inference fixing.
1300 2008-01-24 Marek Safar <marek.safar@gmail.com>
1302 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
1303 Fixed user operator conversions.
1305 2008-01-24 Marek Safar <marek.safar@gmail.com>
1307 * generic.cs: Do nullable type to null comparison optimization during
1310 2008-01-24 Marek Safar <marek.safar@gmail.com>
1312 A fix for bug #355163
1313 * generic.cs: Enabled l-value resolve on nullable expressions.
1315 2008-01-24 Marek Safar <marek.safar@gmail.com>
1317 A fix for bug #353986
1318 * class.cs: Ingore static ctors with parameters for any further checks.
1320 2008-01-24 Marek Safar <marek.safar@gmail.com>
1322 A fix for bug #354310
1323 * namespace.cs: Removed redundant check.
1325 2008-01-24 Marek Safar <marek.safar@gmail.com>
1327 A fix for bug #354928
1328 * expression.cs: ElementInitializers can be resolved only once.
1330 2008-01-24 Marek Safar <marek.safar@gmail.com>
1332 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
1333 Condition expressions.
1335 2008-01-23 Marek Safar <marek.safar@gmail.com>
1337 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
1339 2008-01-22 Marek Safar <marek.safar@gmail.com>
1341 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
1344 * generic.cs: Implemented coalesce expression.
1346 2008-01-22 Marek Safar <marek.safar@gmail.com>
1348 A fix for bug #355145
1349 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
1350 expression tree type inference.
1352 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
1355 * expression.cs (Binary.IsUnsignedType): Fix typo.
1357 2008-01-22 Marek Safar <marek.safar@gmail.com>
1359 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
1361 2008-01-22 Marek Safar <marek.safar@gmail.com>
1363 A fix for bug #355161
1364 * ecore.cs, expression.cs: Wider range of extension method supported
1367 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
1369 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
1370 AssemblyBuilder to operate in compiler context. Fixes mcs part of
1373 2008-01-22 Marek Safar <marek.safar@gmail.com>
1375 A fix for bug #355148
1376 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
1378 2008-01-22 Miguel de Icaza <miguel@novell.com>
1380 * expression.cs (CreateExpressionTree): Add support for or and
1381 logical or, and indent following the coding conventions.
1383 * typemanager.cs (LinqExpression): renamed from
1384 ExpressionTreeManager, for a shorter name.
1386 Use TypeManager.CoreLookupType to lookup types from our core
1387 assemblies and turn those into "Type" variables.
1389 Consumers that previously used "Namespace" and "Type" from this
1390 class should instead use the TypeExpression which is a type that
1391 is fully resolved (without involving the regular C# resolution
1394 This typically looks like this:
1396 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
1397 new MemberAccess (texpr, name, type_arguments, loc)
1399 This avoids the problem in: #355178
1401 2008-01-21 Marek Safar <marek.safar@gmail.com>
1403 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
1404 feature in parser only as we do in other cases.
1406 2008-01-21 Marek Safar <marek.safar@gmail.com>
1408 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
1409 typemanager.cs: A refactoring of params arguments to reuse existing
1410 expressions (params -> array initializer) to emit params argument instead
1411 of specialized handling.
1412 It was required by expression tree implementation and it has other benefits
1413 as well, we now apply same optimization for params arguments as we do for
1416 2008-01-18 Marek Safar <marek.safar@gmail.com>
1418 A fix for bug #353526
1419 * generic.cs: A type inference of params arguments may not required any
1420 temporary array creation.
1422 2008-01-18 Marek Safar <marek.safar@gmail.com>
1424 A fix for bug #353534
1425 * generic.cs, ecore.cs, expression.cs: A method group type inference is
1426 supported for delegates only.
1428 2008-01-18 Marek Safar <marek.safar@gmail.com>
1430 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
1431 type for more than 1 candidates.
1433 2008-01-18 Marek Safar <marek.safar@gmail.com>
1435 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
1438 2008-01-16 Marek Safar <marek.safar@gmail.com>
1440 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
1441 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
1442 operator) expressions.
1444 2008-01-16 Zoltan Varga <vargaz@gmail.com>
1446 * statement.cs: Avoid declaring an IL variable for this_variable since it is
1447 not accessed from the generated IL.
1449 2008-01-14 Marek Safar <marek.safar@gmail.com>
1451 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
1452 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
1453 statement.cs: The first expression tree implementation drop, mostly
1454 infrastructure work.
1456 2008-01-14 Marek Safar <marek.safar@gmail.com>
1458 * ecore.cs (IsNestedChild): Refactored.
1460 2008-01-11 Marek Safar <marek.safar@gmail.com>
1462 * lambda.cs: Don't use a cast on unknown expression statement.
1464 2008-01-10 Geoff Norton <gnorton@novell.com>
1466 * cs-tokenizer.cs: One more token to distinguish between method and lambda
1469 2008-01-09 Marek Safar <marek.safar@gmail.com>
1471 * doc.cs: Report better /doc crash details.
1473 2008-01-09 Marek Safar <marek.safar@gmail.com>
1475 A fix for bug #352536
1476 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
1478 2008-01-08 Marek Safar <marek.safar@gmail.com>
1480 A fix for bug #352287
1481 * ecore.cs, expression.cs: Do `this' access checking in all member access
1484 2008-01-08 Marek Safar <marek.safar@gmail.com>
1486 * rootcontext.cs, driver.cs: Switch to linq mode by default.
1488 * report.cs: Reset message stacks.
1490 2008-01-08 Marek Safar <marek.safar@gmail.com>
1492 * generic.cs (InferInPhases): Correctly calculate params position.
1494 2008-01-08 Marek Safar <marek.safar@gmail.com>
1496 * cs-tokenizer.cs: No need to parse full string when parsing lambda
1499 2008-01-07 Marek Safar <marek.safar@gmail.com>
1501 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
1503 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
1505 * driver.cs: Updated --help option.
1507 2008-01-07 Marek Safar <marek.safar@gmail.com>
1509 * generic.cs (InferParamsTypeArguments): Removed.
1510 (InferInPhases): Add params type inference.
1511 (LowerBoundInference): Fixed scoring mechanism.
1513 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
1515 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
1517 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
1518 byte array for unsigned "baked" assemblies.
1520 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
1522 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
1523 array for assemblies that are not strongnamed.
1525 2008-01-04 Marek Safar <marek.safar@gmail.com>
1527 A fix for bug #351481
1528 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
1529 declaring type for nested generic types.
1531 2008-01-04 Marek Safar <marek.safar@gmail.com>
1533 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
1534 instead of ToString.
1536 2008-01-03 Marek Safar <marek.safar@gmail.com>
1538 A fix for bug #351047
1539 * expression.cs (Binary.ResolveOperator): Allow equality operators between
1540 null and structs only when equality and inequality operators are defined
1541 either as an user-operators or predefined operators.
1543 2008-01-03 Marek Safar <marek.safar@gmail.com>
1545 A fix for bug #351047
1546 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
1548 2008-01-03 Marek Safar <marek.safar@gmail.com>
1550 A fix for bug #351257
1551 * cs-tokenizer.cs: Advance line number for '\r' correctly.
1553 2008-01-03 Marek Safar <marek.safar@gmail.com>
1555 A fix for bug #351157
1556 * class.cs (Using): Fixed yet another broken cloning.
1558 (Block): Put back more sensible default value for statements.
1560 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
1562 * codegen.cs: Allow AssemblyVersion with only major version component.
1565 2007-12-29 Marek Safar <marek.safar@gmail.com>
1567 A fix for bug #324654
1568 * class.cs: Use FullName property as member name.
1570 2007-12-28 Marek Safar <marek.safar@gmail.com>
1572 A fix for bug #342117
1573 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
1574 constructor constraint.
1576 2007-12-28 Marek Safar <marek.safar@gmail.com>
1578 A fix for bug #338273
1579 * class.cs (ProbertyBase): Access modifier checks are required for overrides
1582 2007-12-28 Marek Safar <marek.safar@gmail.com>
1584 A fix for bug #350839
1585 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
1587 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1589 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1592 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1594 * statement.cs: Changed some Hashtables to use HybridDictionaries
1595 instead. It was observed that some HashTables only contained a few
1596 items in the vast majority of cases. Since HybridDictionary is
1597 more efficient on small sets (<10 elements), "known_variables"
1598 from class ExplicitBlock as well as "labels" and "constants " from
1599 class Block were changed to HybridDictionaries.
1601 Atsai results: (56216kb->54987kb)
1603 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
1606 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
1608 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
1611 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
1613 * expression.cs: foreach loop to for loop, saved on allocation of
1614 enumerator (59333kb->59141kb)
1616 * statement.cs. Changed foreach loops to for loops, saved on
1617 allocation of enumerator (59141kb->59006kb)
1619 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
1620 when constructed with no specified capacity. This was causing a
1621 few ArrayLists to allocate more memory than they would potentially
1622 need in the Block class and MemberCache class. Setting the
1623 ArrayLists to construct with a capacity of 1 saves some
1624 memory. (56216kb->55585kb)
1626 2007-12-27 Marek Safar <marek.safar@gmail.com>
1628 A fix for bug #347189 (2nd issue)
1629 * expression.cs (MemberAccess): Nested type can be found in base non-generic
1632 2007-12-27 Miguel de Icaza <miguel@novell.com>
1634 * report.cs: Do not use colors if stdout and stderr are not a
1637 2007-12-27 Marek Safar <marek.safar@gmail.com>
1639 A fix for bug #346998
1640 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
1643 2007-12-27 Marek Safar <marek.safar@gmail.com>
1645 A fix for bug #343465
1646 * class.cs: Explicit method name for nested types uses dots only.
1648 2007-12-27 Marek Safar <marek.safar@gmail.com>
1650 A fix for bug #343707
1651 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
1653 2007-12-27 Marek Safar <marek.safar@gmail.com>
1655 * ecore.cs: Report type inference errors only when arguments count matches
1658 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
1660 * expression.cs, report.cs: New warning.
1662 * typemanager.cs: Catch anonymous method type too.
1664 2007-12-23 Marek Safar <marek.safar@gmail.com>
1666 A fix for bug #346379
1667 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
1669 2007-12-23 Marek Safar <marek.safar@gmail.com>
1671 A fix for bug #347359
1672 * expression.cs (Invocation): Don't resolve already resolved expression.
1674 2007-12-23 Marek Safar <marek.safar@gmail.com>
1676 A fix for bug #347189
1677 * class.cs (FixedField): Use non-dependent code only in the define phase.
1679 2007-12-23 Marek Safar <marek.safar@gmail.com>
1681 A fix for bug #348076
1682 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
1684 2007-12-22 Marek Safar <marek.safar@gmail.com>
1686 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
1687 discovered extension methods.
1689 2007-12-22 Marek Safar <marek.safar@gmail.com>
1691 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
1694 2007-12-21 Miguel de Icaza <miguel@novell.com>
1696 * report.cs (ErrorMessage): Add support for using colors on
1697 terminals that support it.
1699 2007-12-21 Marek Safar <marek.safar@gmail.com>
1701 * ecore.cs: Use information about expanded params for error reporting.
1703 2007-12-21 Marek Safar <marek.safar@gmail.com>
1705 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
1706 and logic for params overloads.
1708 2007-12-15 Miguel de Icaza <miguel@novell.com>
1710 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
1711 as this is also created from the parser. Fixes #349034
1713 2007-12-12 Miguel de Icaza <miguel@novell.com>
1715 * statement.cs (Throw.CloneTo): it is valid to have empty
1716 expressions for throw.
1718 2007-12-03 Marek Safar <marek.safar@gmail.com>
1720 * cs-parser.jay: Set delegate constraint parsing region correctly.
1722 2007-12-03 Marek Safar <marek.safar@gmail.com>
1724 A fix for bug #345467
1725 * typemanager.cs (IsEqual): Compare generic parameters position only.
1727 2007-11-28 Marek Safar <marek.safar@gmail.com>
1729 * expression.cs (BaseAccess): Type arguments can be null.
1731 2007-11-27 Raja R Harinath <harinath@gmail.com>
1733 * statement.cs (Block.Resolve): Ensure flow-branching tree is
1734 consistent even when an error has occured.
1735 (Switch.Resolve): Likewise.
1737 2007-11-22 Marek Safar <marek.safar@gmail.com>
1739 A fix for bug #334505
1740 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
1743 2007-11-22 Marek Safar <marek.safar@gmail.com>
1745 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
1746 refactorings required to resolve extension methods correctly when mixing
1747 generics and non-generics members.
1749 2007-11-20 Marek Safar <marek.safar@gmail.com>
1751 A fix for bug #342584
1752 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
1755 2007-11-19 Marek Safar <marek.safar@gmail.com>
1757 A fix for bug #342512
1758 * delegate.cs: Use delegate argument expression when is available. Don't
1759 emit virtual call when class is sealed.
1761 2007-11-16 Marek Safar <marek.safar@gmail.com>
1763 A fix for bug #325423
1764 * assign.cs (FieldInitializer): Use resolved expression for emit.
1766 * class.cs: Print less confusing error message.
1768 2007-11-16 Marek Safar <marek.safar@gmail.com>
1770 * cs-tokenizer.cs: Removed GMCS ifdefs.
1772 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
1775 * cs-parser.jay: Disabled nullable check.
1777 * generic-mcs: Copied more generic stuff.
1779 2007-11-16 Marek Safar <marek.safar@gmail.com>
1781 * gcs-parser.jay: Merged to cs-parser.jay.
1783 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
1784 * *.csproj, *.sources: Updated to use only jay parser file.
1786 2007-11-16 Marek Safar <marek.safar@gmail.com>
1788 * gcs-parser.jay: Added nullable and default expression feature checks.
1790 2007-11-16 Marek Safar <marek.safar@gmail.com>
1792 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
1793 it fixes many TODOs and hidden bugs.
1795 * expression: Removed duplicate error check.
1797 2007-11-15 Marek Safar <marek.safar@gmail.com>
1799 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
1800 implicitly type local variable only when it is used in a declaration.
1802 2007-11-15 Marek Safar <marek.safar@gmail.com>
1804 * attribute.cs: Use CS0612 for empty strings.
1806 2007-11-14 Marek Safar <marek.safar@gmail.com>
1808 * lambda.cs, statement.cs: Contextual return may act as a statement.
1810 2007-11-14 Marek Safar <marek.safar@gmail.com>
1812 A fix for a regression cause by #324222
1813 * class.cs: Don't report unused even when it implements an interface.
1815 2007-11-13 Marek Safar <marek.safar@gmail.com>
1817 A fix for bug #341205
1818 * ecore.cs, expression.cs: Method group expression cannot do static
1819 method access with an instance reference check before overloading takes
1822 2007-11-13 Marek Safar <marek.safar@gmail.com>
1824 A fix for bug #325359
1825 * class.cs: Use predictable name for automatically generated property.
1827 2007-11-12 Marek Safar <marek.safar@gmail.com>
1829 A fix for bug #324996
1830 * expression.cs (Is): Handle case where D is nullable and T is not
1833 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
1835 2007-11-12 Marek Safar <marek.safar@gmail.com>
1837 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
1838 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
1839 Flush small error reporting changes.
1841 2007-11-09 Marek Safar <marek.safar@gmail.com>
1843 A fix for bug #324996
1844 * expression.cs: Rewrote Is expression implementation to work with
1845 generics, nullable types, anonymous method. A const result expression
1846 uses existing infrastructure instead of custom not fully-featured one.
1848 2007-11-08 Marek Safar <marek.safar@gmail.com>
1850 A fix for bug #340202
1851 * class.cs: Consider generics for volatile field.
1853 2007-11-08 Marek Safar <marek.safar@gmail.com>
1855 A fix for bug #335594
1856 * expression.cs: Use conversion rules when handling string addition.
1858 2007-11-07 Marek Safar <marek.safar@gmail.com>
1860 A fix for bug #336651
1861 * expression.cs: Fixed a crash when probing is on.
1863 2007-11-07 Marek Safar <marek.safar@gmail.com>
1865 A fix for bug #324242
1866 * covert.cs: Added a conversion from any nullable-type with an
1867 underlying enum-type to the type System.Enum.
1869 2007-11-07 Marek Safar <marek.safar@gmail.com>
1871 A fix for bug #324222
1872 * class.cs: Report all non-used event fields.
1874 2007-11-07 Marek Safar <marek.safar@gmail.com>
1876 A fix for bug #325161
1877 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
1878 qualifier for generic types.
1880 2007-11-07 Marek Safar <marek.safar@gmail.com>
1882 A fix for bug #322971
1883 * expression.cs, ecore.cs: Added intermediate result value check for
1886 2007-11-07 Marek Safar <marek.safar@gmail.com>
1888 A fix for bug #324754
1889 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
1890 when it was requested.
1892 2007-11-07 Marek Safar <marek.safar@gmail.com>
1894 A fix for bug #325101
1895 * expression.cs: Do type not value comparison for `is' expression.
1897 2007-11-07 Marek Safar <marek.safar@gmail.com>
1899 A fix for bug #320236
1900 * convert.cs: Don't apply user conversion on underlying target type.
1902 2007-11-06 Marek Safar <marek.safar@gmail.com>
1904 * expression.cs: Don't use unresolved expression for error reporting.
1906 2007-11-06 Marek Safar <marek.safar@gmail.com>
1908 A fix for bugs #337712, #324490
1909 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
1910 overloading resolution too.
1912 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
1913 the process consistent and more robust.
1915 * expression.cs, linq.cs, report.cs: Update.
1917 2007-11-02 Marek Safar <marek.safar@gmail.com>
1919 A fix for bug #332909
1920 * attribute.cs: Resolve attributes in correct context using error
1923 * rootcontext.cs: Define Obsolete attribute members as core members.
1925 2007-11-02 Marek Safar <marek.safar@gmail.com>
1927 * statement.cs: Removed unused methods.
1929 2007-10-31 Wade Berrier <wberrier@novell.com>
1931 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
1932 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
1935 2007-10-31 Marek Safar <marek.safar@gmail.com>
1937 A fix for bug #338102
1938 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
1939 methods registered as non-generics.
1941 2007-10-31 Marek Safar <marek.safar@gmail.com>
1943 A fix for bugs #337712, #324490
1944 * delegate.cs: Delegate covariance and contravariance is not allowed for
1947 2007-10-31 Marek Safar <marek.safar@gmail.com>
1949 A fix for bug #337719
1950 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
1953 2007-10-30 Marek Safar <marek.safar@gmail.com>
1955 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
1957 2007-10-29 Marek Safar <marek.safar@gmail.com>
1959 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
1962 2007-10-29 Raja R Harinath <rharinath@novell.com>
1964 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
1966 2007-10-29 Marek Safar <marek.safar@gmail.com>
1968 A fix for bug #334652
1969 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
1970 extension methods when we have not found the best candidate in normal
1973 2007-10-27 Marek Safar <marek.safar@gmail.com>
1975 * AssemblyInfo.cs: Keep up-to-date.
1977 2007-10-27 Marek Safar <marek.safar@gmail.com>
1979 * Makefile: Fixed generics compiler name.
1981 2007-10-27 Marek Safar <marek.safar@gmail.com>
1983 * lambda.test: removed, lambda parsing is done differently.
1985 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
1987 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
1989 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
1991 2007-10-27 Marek Safar <marek.safar@gmail.com>
1993 * Makefile, *.sources : All C# compilers are in mcs folder.
1995 * *.cs: Use existing 2_1 define for smcs.
1997 2007-10-26 Marek Safar <marek.safar@gmail.com>
1999 A fix for bug #335847
2000 * assign.cs, expression.cs: Couple of changes to avoid creating a
2001 temporary variable for each object initializer assignment statement. It
2002 simplifies struct initialization too, otherwise two temporary variables
2004 Implemented optimization of redundant default element initializers.
2006 2007-10-25 Marek Safar <marek.safar@gmail.com>
2008 A fix for bug #336766
2009 * expression.cs (Class.CheckBase): Use generic name when method is
2012 2007-10-25 Marek Safar <marek.safar@gmail.com>
2014 A fix for bug #334737
2015 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
2016 variable and not variable argument for prepared copies.
2018 2007-10-24 Marek Safar <marek.safar@gmail.com>
2020 A fix for bug #325110
2021 * class.cs, expression.cs, attribute.cs: Use open generic method when
2022 checking conditional attribute.
2024 2007-10-24 Marek Safar <marek.safar@gmail.com>
2026 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
2027 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
2028 FeatureIsNotAvailable.
2030 2007-10-24 Marek Safar <marek.safar@gmail.com>
2032 ** C# 3.0 Partial methods
2034 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
2035 methods support. Because of member cache issue with generics only
2036 non-generics partial methods are fully supported.
2038 2007-10-23 Marek Safar <marek.safar@gmail.com>
2040 * class.cs, decl.cs: Rewrote member overloads check to cope with
2041 generics and to use member cache for member checking. It also improves
2042 performance and fixes remaining overloads issues.
2044 2007-10-20 Marek Safar <marek.safar@gmail.com>
2046 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
2047 roottypes.cs, typemanager.cs:
2049 A member cache creation logic changed to add members immediately and
2050 not rely on fallback. The member cache is now only prefered way
2051 how to access and find type declaration members. It saves 5 MB of memory
2052 during MWF compilation and makes code ready for more optimizations and
2053 clean-ups, it's also a pre-requirement for partial methods.
2055 2007-10-18 Raja R Harinath <harinath@gmail.com>
2057 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
2058 handling for generic parameters.
2060 2007-10-15 Marek Safar <marek.safar@gmail.com>
2062 * class.cs (FixedField): Removed redundant volatile check.
2064 2007-10-15 Marek Safar <marek.safar@gmail.com>
2066 * class.cs, decl.cs: Fixed overload members verification to do only one
2067 check per possible collision.
2069 2007-10-13 Marek Safar <marek.safar@gmail.com>
2071 A fix for bug #325478
2072 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
2073 and create only one disposable flags container.
2075 2007-10-12 Marek Safar <marek.safar@gmail.com>
2077 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
2078 * statement.cs (Fixed): Fixed variables cloning.
2080 2007-10-12 Marek Safar <marek.safar@gmail.com>
2082 A fix for bug #333342
2083 * class.cs (EventField): Don't mark value type event as synchronized.
2085 2007-10-12 Marek Safar <marek.safar@gmail.com>
2087 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
2088 inference to identify best candidate method correctly.
2089 (ProperyExpr): A range variable is read only and cannot be modified.
2091 2007-10-11 Marek Safar <marek.safar@gmail.com>
2093 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
2094 logic to identify best candidate method correctly.
2096 2007-10-11 Marek Safar <marek.safar@gmail.com>
2098 * location.cs (Equals, GetHashCode): Removed.
2100 2007-10-11 Marek Safar <marek.safar@gmail.com>
2102 * report.cs: Implemented message recorder. It is used mainly for lambda
2103 expressions to capture otherwise swallowed error messages.
2105 * anonymous.cs, lambda.cs.cs: Do full parameters check.
2107 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
2109 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
2111 * expression.cs (MemberAccess): Always report lookup failure.
2113 * location.cs: Implemented Equals, GetHashCode.
2115 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
2117 2007-10-10 Jb Evain <jbevain@novell.com>
2119 * codegen.cs: re-enable assembly version check.
2121 2007-10-09 Marek Safar <marek.safar@gmail.com>
2123 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
2126 * namespace.cs (UsingAlias): Do correct version check.
2128 2007-10-08 Marek Safar <marek.safar@gmail.com>
2130 * expresison.cs, ecore.cs: Issue extension method error message when
2133 * rootcontext.cs: Added ISO_2 compiler mode option.
2135 2007-10-08 Marek Safar <marek.safar@gmail.com>
2137 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
2140 2007-10-08 Marek Safar <marek.safar@gmail.com>
2142 * attribute.cs (GetString, GetBoolean): Work with both literal and
2145 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
2146 Moved method overload specific methods to MethodGroupExpr.
2148 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
2149 it should be less memory consuming.
2151 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
2153 * codegen.cs: remove the assembly version check until the buildbot is
2156 2007-10-07 Jb Evain <jbevain@novell.com>
2158 * attribute.cs (Attribute.GetString): if the value
2159 expression is a StringConstant, return its string value.
2161 2007-10-07 Jb Evain <jbevain@novell.com>
2163 * typemanager.cs: add `assembly_version_attribute_type`.
2164 * codegen.cs: on attribute emission, check that the
2165 AssemblyVersionAttribute doesn't overflow.
2167 2007-10-05 Marek Safar <marek.safar@gmail.com>
2169 A fix for bug #324677
2170 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
2171 parent container of a scope container with currently resolved one.
2173 2007-10-05 Marek Safar <marek.safar@gmail.com>
2175 A fix for bug #325534
2176 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
2179 2007-10-05 Marek Safar <marek.safar@gmail.com>
2181 A fix for bug #327504
2182 * class.cs (Operator.Define): Refactored implicit and explicit user
2183 operator conversion rules.
2185 2007-10-05 Marek Safar <marek.safar@gmail.com>
2187 A fix for bug #327520
2188 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
2190 2007-10-04 Marek Safar <marek.safar@gmail.com>
2192 A fix for bug #328022
2193 * class.cs (MethodData.Define): Use correct method to check whether
2194 a method implementents an accessor.
2196 2007-10-04 Marek Safar <marek.safar@gmail.com>
2198 A fix for bug #330069
2199 * statement.cs (Fixed.Resolve): Read the first array element only when
2200 an array is instantiated.
2202 2007-10-04 Marek Safar <marek.safar@gmail.com>
2204 * expression.cs, assign.cs, generics.cs: Print correct operator when
2205 compound assignment is used.
2207 2007-10-04 Marek Safar <marek.safar@gmail.com>
2209 A fix for bug #325841
2210 * expression.cs (ArrayAccess): Use full argument cloning only for
2211 string compound concatenation.
2213 2007-10-03 Marek Safar <marek.safar@gmail.com>
2215 A fix for bug #328774
2216 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
2218 (PropertyExpr.EmitAssign): Fixed string concatenation compound
2221 2007-10-03 Raja R Harinath <rharinath@novell.com>
2224 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
2225 Event accessibility checks here. Remove some bogus code that
2226 accidently made GenericMethods work.
2227 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
2229 2007-09-25 Marek Safar <marek.safar@gmail.com>
2231 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
2233 * statement.cs (Block): Refactored AddVariable to allow error handling
2236 * generic.cs: New stub.
2238 2007-09-23 Marek Safar <marek.safar@gmail.com>
2240 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
2243 2007-09-17 Marek Safar <marek.safar@gmail.com>
2245 * class.cs: Use partial container to record whether any partial part
2246 contains static field initializer and therefore default contructor has
2249 2007-09-14 Marek Safar <marek.safar@gmail.com>
2251 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
2252 mono-list when only one of two partial parts has defined accessibility
2255 2007-09-14 Marek Safar <marek.safar@gmail.com>
2257 A fix for bug #82845
2259 * class.cs (TypeContainer): Set correct resolve context for all field
2262 2007-09-13 Marek Safar <marek.safar@gmail.com>
2264 * assign.cs: Fixed a crash when field is resolved twice with an error.
2266 * codegen.cs: Changed InFieldInitializer to be flag.
2268 * anonymous.cs, ecore.cs, expression.cs: Update after
2269 IsInFieldInitializer rename.
2271 * const.cs: Removed unused parameter.
2273 * class.cs: Changed the way how we resolve and emit field initializers.
2274 The field initilizers have to have access to contructor block to emit
2275 compiler generated code.
2277 2007-09-13 Marek Safar <marek.safar@gmail.com>
2279 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
2280 generics use TypeContainer instead.
2282 2007-09-12 Marek Safar <marek.safar@gmail.com>
2284 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
2286 * lambda.cs (ResolveParameters): Use more powerful
2287 InflateGenericArgument.
2289 * parameters.cs: Better exception message.
2291 2007-09-10 Marek Safar <marek.safar@gmail.com>
2293 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
2294 correct expression block type.
2296 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
2298 * expression.cs (Invocation): Extracted method group resolve to
2301 2007-09-07 Marek Safar <marek.safar@gmail.com>
2303 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
2304 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
2306 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
2307 generic extension methods.
2309 2007-09-06 Marek Safar <marek.safar@gmail.com>
2311 A fix for bug #82676 (Do I get it right now?)
2312 * convert.cs (Binary.ResolveOperator): An interface is converted to the
2313 object before a standard conversion is applied.
2315 2007-09-06 Marek Safar <marek.safar@gmail.com>
2317 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
2320 2007-09-05 Marek Safar <marek.safar@gmail.com>
2322 A fix for bug #82676
2323 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
2324 non-generic interface types.
2326 2007-09-05 Marek Safar <marek.safar@gmail.com>
2328 A fix for bug #82690
2329 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
2331 2007-09-05 Marek Safar <marek.safar@gmail.com>
2333 A fix for bug #82571
2334 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
2335 modifier for container based methods.
2337 2007-09-05 Marek Safar <marek.safar@gmail.com>
2339 A fix for bug #82676
2340 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
2341 any interface-type T means to any of interface type T.
2343 2007-09-04 Marek Safar <marek.safar@gmail.com>
2345 * namespace.cs: We have 2 versions of System.Core assembly.
2347 2007-09-04 Marek Safar <marek.safar@gmail.com>
2349 A fix for bug #82652
2350 * class.cs (Class.GetClassBases): Compare types and not expressions.
2352 2007-09-04 Marek Safar <marek.safar@gmail.com>
2354 A fix for bug #82620
2355 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
2356 actually never worked before.
2357 (IndexerAccess): Emit prepared arguments before they are modified.
2359 2007-09-04 Marek Safar <marek.safar@gmail.com>
2361 A fix for bug #82563
2362 * assign.cs: Revert wrong fix.
2364 * expression.cs (VariableReference.EmitAssign): Handle ref reference
2366 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
2367 Instead of ldelema/stdind we have to use temporary variables to handle
2368 cases like String.Concat (params string[]).
2370 2007-08-31 Marek Safar <marek.safar@gmail.com>
2372 * class.cs: EmitAttributes to Emit rename.
2374 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
2376 (MemberCore.HasClsCompliantAttribute): Don't depend on
2377 GetClsCompliantAttributeValue execution.
2379 2007-08-31 Marek Safar <marek.safar@gmail.com>
2381 * anonymous.cs: Use shorter type prefix.
2383 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
2386 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
2387 variables when probing is on.
2389 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
2390 unresolved variables.
2391 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
2392 handle transparent identifiers.
2394 2007-08-26 Marek Safar <marek.safar@gmail.com>
2396 * attribute.cs (IsClsCompliant): Add nullable types test.
2398 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
2400 * doc.cs : catch other types of exception than XmlException to
2401 report CS1570. Fixed bug #82565.
2403 2007-08-23 Marek Safar <marek.safar@gmail.com>
2405 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
2406 The number of delegate parameters has to match.
2407 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
2410 2007-08-21 Marek Safar <marek.safar@gmail.com>
2412 * anonymous.cs (AnonymousMethod): Generate private anonymous method
2413 to fix problem with private arguments.
2415 2007-08-20 Marek Safar <marek.safar@gmail.com>
2417 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
2419 * decl.cs (MemberName): Ignore generic type with no generic arguments.
2421 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
2422 empty. Add cloning suport.
2424 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
2426 2007-08-20 Marek Safar <marek.safar@gmail.com>
2428 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
2429 to create EmptyCast. It handles EmptyConstantCast specialization for
2432 2007-08-18 Marek Safar <marek.safar@gmail.com>
2434 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
2435 (EmitArrayArgument): One routine for array arguments.
2436 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
2438 2007-08-17 Marek Safar <marek.safar@gmail.com>
2440 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
2442 2007-08-17 Marek Safar <marek.safar@gmail.com>
2444 * anonymous.cs: MemberLookupFinal update.
2446 * class.cs (ConstructorInitializer): Is expression based.
2448 * delegate.cs: MethodGroupExpr update.
2450 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
2452 (Error_MemberLookupFailed): Customizable error override.
2453 (MethodGroupExpr): Keep queried type for later usage.
2454 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
2457 * expression.cs: Error_MemberLookupFailed refactoring.
2458 (New.DoResolve): Resolve as much as possible.
2459 (ElementInitializer.Error_MemberLookupFailed): Object initializer
2460 customization for invalid member types.
2462 * statement.cs: MethodGroupExpr update.
2464 2007-08-16 Marek Safar <marek.safar@gmail.com>
2466 * modifier.cs (Check): Check all modifiers and not only accessibility
2469 2007-08-16 Marek Safar <marek.safar@gmail.com>
2471 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
2472 type and not an expression.
2474 2007-08-16 Marek Safar <marek.safar@gmail.com>
2476 * statement.cs (Catch.Clone): Type and variable can be null.
2478 2007-08-16 Marek Safar <marek.safar@gmail.com>
2480 A fix for bug #81979
2481 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
2482 I am really not sure whether this is the best fix.
2484 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
2487 2007-08-14 Marek Safar <marek.safar@gmail.com>
2489 ** C# 3.0 Object and collection initializers (major re-write)
2491 * assign.cs (DoResolve): Initializers are not assign related.
2493 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
2494 used during collection or object initialization.
2496 * expression.cs (Error_InvalidArguments): Add initializers specific
2497 messages. More will come later because it requires some general
2499 (New.DoResolve): Better error handling for unsafe types.
2500 (EmptyExpressionStatement): New class.
2501 (ElementInitializer): An object initializer expression.
2502 (CollectionElementInitializer): A collection initializer expression.
2503 (CollectionOrObjectInitializers): A block of object or collection
2505 (NewInitialize): New expression with element/object initializers.
2507 * statement.cs: Reverted object/collection initializer hacks.
2509 * typemanager.cs (CSharpName): Filter __arglist type.
2511 2007-08-09 Marek Safar <marek.safar@gmail.com>
2513 ** C# 3.0 Anonymous Types (update to the latest standard)
2515 * expression.cs (Binary.ResolveOperator): Threat all null based types
2517 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
2518 (AnonymousTypeParameter): Updated.
2520 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
2521 (AnonymousTypeClass): New anonymous type container.
2523 * class.cs (AddField): Return operation result.
2525 * generic.cs: Another empty TypeArguments overload.
2527 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
2528 are stored at top of normal hierarchy.
2530 * typemanager.cs (CSharpName): Filter anonymous types.
2532 2007-08-09 Marek Safar <marek.safar@gmail.com>
2534 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
2535 as single Concat call. How could we miss that :-(
2537 2007-08-08 Marek Safar <marek.safar@gmail.com>
2539 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
2541 2007-08-07 Miguel de Icaza <miguel@novell.com>
2543 * expression.cs: Fix the previous commit, the creation of the
2544 arguments array list needs also to be conditional on the arguments
2547 * class.cs: Add a little bit of help to help narrow down problems.
2549 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
2550 not try to copy in that case.
2552 * driver.cs: When building SMCS, include a new different set of
2553 default assemblies here. Do this here so we can control whether
2554 to include the default assemblies with /noconfig.
2556 2007-08-03 Marek Safar <marek.safar@gmail.com>
2558 A fix for bug #81979
2559 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
2562 2007-08-03 Marek Safar <marek.safar@gmail.com>
2564 A fix for bug #82300
2566 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
2567 we are in probing scope.
2569 2007-08-03 Marek Safar <marek.safar@gmail.com>
2571 A fix for bug #82301
2573 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
2574 (Statement.CloneTo): Clone and not map children blocks.
2576 2007-08-03 Marek Safar <marek.safar@gmail.com>
2578 A fix for bug #82299
2580 * expression.cs (LocalVariableReference.CloneTo): Remap local info
2583 * statement.cs (Statement.CloneTo): Clone variables before statements
2584 to allow remaping of local variables.
2586 2007-08-03 Marek Safar <marek.safar@gmail.com>
2588 A fix for bug #82296
2591 * report.cs: Log crash details for future clone problems.
2593 * statement.cs (Return.Clone): Don't clone non-existent expression.
2595 2007-08-03 Raja R Harinath <harinath@gmail.com>
2597 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
2598 (Class.AddBasesForPart): Move CS0537 check here from ...
2599 * cs-parser.jay (class_declaration): ... here. Move calling of
2600 'AddBasesForPart' to ...
2601 (class_bases): ... here.
2602 (struct_declaration, interface_declaration): Update to changes.
2604 2007-08-02 Marek Safar <marek.safar@gmail.com>
2606 A fix for bug #81923
2608 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
2609 conversion is allowed.
2611 2007-08-02 Marek Safar <marek.safar@gmail.com>
2613 A fix for bug #81564
2615 * ecore.cs (EventExpr): Add IsBase handling.
2617 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
2620 2007-08-02 Raja R Harinath <harinath@gmail.com>
2622 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
2623 * cs-parser.jay: Some whitespace cleanups.
2624 (current_delegate): New.
2626 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
2627 a dummy code block, and use 'type_name' instead of 'member_name'.
2628 (interface_declaration, class_declaration): Likewise.
2629 (delegate_declaration): Likewise. Rearrange slightly and use
2631 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
2632 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
2634 2007-08-02 Marek Safar <marek.safar@gmail.com>
2636 A fix for bug #82039
2638 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
2641 * typemanager.cs (CSharpName): Split to string overload.
2643 2007-08-02 Marek Safar <marek.safar@gmail.com>
2646 * report.cs: Updated warning CS0472.
2648 2007-08-01 Marek Safar <marek.safar@gmail.com>
2650 A fix for bug #82181
2652 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
2654 2007-08-01 Marek Safar <marek.safar@gmail.com>
2656 A fix for bug #82277
2657 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
2659 2007-08-01 Marek Safar <marek.safar@gmail.com>
2661 ** C# 3.0 Type Inference (major bits are working)
2663 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
2664 (.ImplicitStandardConversionExists): Uses compatible.
2665 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
2666 (.InferReturnType): New method.
2667 (.Compatible): Refactored.
2668 (.ResolveParameters): Uses factory to create resolved parameters.
2669 (.CompatibleMethod): Add probing mode support.
2670 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
2671 clearly distinguish between 2 different operations.
2672 (LambdaMethod): Moved to lambda.cs.
2673 (AnonymousMethod): Removed unused fields and methods.
2674 (AnonymousDelegate): Simplified.
2676 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
2678 * convert. cs (ImplicitConversionStandard): Compatible works differently.
2680 * delegate.cs (Delegate): New mehods to reduce code duplication.
2681 (.GetConstructor): New method.
2682 (.GetInvokeMethod): New method.
2683 (DelegateCreation): Updated.
2685 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
2687 (OverloadResolve): Made probing little bit faster.
2689 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
2692 * generic.cs (TypeInferenceContext): Dummy implementation.
2694 * iterators.cs: Updated after Resolve/Define rename.
2696 * lambda.cs (LambdaExpression)
2697 (.ResolveParameters): Handles both type of arguments and type inference too.
2699 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
2700 (InflateTypes): Updated.
2702 * support.cs (InflateTypes): Changed signature and updated.
2704 * typemanager.cs (LookupMemberCache): Better dynamic type check.
2705 (MemberLookup_FindMembers): More MS tricks.
2706 (GetParameterData): Ditto.
2707 (GetDelegateParameters): Uses quick path for dynamic types.
2709 2007-08-01 Marek Safar <marek.safar@gmail.com>
2711 * class.cs (MethodData.Define): EmitContext is required for generic stuff
2714 2007-07-31 Marek Safar <marek.safar@gmail.com>
2716 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
2719 2007-07-26 Jb Evain <jbevain@novell.com>
2721 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
2722 which takes a boolean 'report_errors', similar to the GetMethod.
2723 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
2724 in .net 2.1, do not report errors here.
2726 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
2727 System.Runtime.CompilerServices.RequiredAttributeAttribute and
2728 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
2731 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
2732 of the type InternalsVisibleToAttribute before the first call
2733 to CoreLookupType which is allowed to fail (third boolean parameter
2734 to true). Because, during the resolution for a type that is not
2735 immediately found, we try to check if the type is not defined in
2736 a friend assembly, and to do so, we need the
2737 InternalVisibleToAttribute.
2739 2007-07-23 Miguel de Icaza <miguel@novell.com>
2741 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
2742 feature that allows structs to be compared against null and inline
2743 the result as true or false.
2745 Notice that the same code is not permitted inside a generic block
2746 of code that would do:
2748 class Foo<T> where T : struct {
2755 It is only allowed if the type of T is not bound (no where
2756 clause). In my opinion, this CSC 2 behavior is broken but people
2757 seem to be using it (IronRuby does, a few bug reports on bugzilla
2758 have it and some people have complained about it).
2760 All of the users that depend on this behavior have code that is
2763 * report.cs (Warning, Error): make these take object arguments,
2764 not strings, as that allows us to take advantage of Format.
2766 2007-07-20 William Holmes <billholmes54@gmail.com>
2768 * decl.cs: Changed MemberName.CountTypeArguments to also check the
2769 Left member variable for the Count.
2770 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
2771 MemberName.CountTypeArguments to avoid a NRE.
2773 This code is contributed under the MIT X11 license
2775 2007-07-18 Marek Safar <marek.safar@gmail.com>
2777 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
2779 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2781 * doc.cs : generic method arguments are written as ``x while generic
2782 type arguments are `x. Combined with the previous change, fixed bug
2785 2007-07-18 Raja R Harinath <rharinath@novell.com>
2788 * expression.cs (Binary.ResolveOperator): When converting
2789 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
2791 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
2793 * doc.cs : when T: or whatever x: is specified, it does not really
2794 check the doc comment's syntax correctness. Fixed bug #82006.
2796 2007-07-18 Marek Safar <marek.safar@gmail.com>
2798 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
2799 LambdaExpression better.
2801 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
2803 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
2805 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
2806 as it can be generated.
2808 * expression.cs (Invocation.Error_InvalidArguments): Show correct
2811 * lambda.cs (LambdaExpression): Refactored to share same code with
2812 AnonymousMethodExpression.
2814 2007-07-17 Marek Safar <marek.safar@gmail.com>
2816 * anonymous.cs (MakeName): Include host name for easier debugging.
2817 (LambdaMethod): New class for lambda spcecific stuff.
2819 * attribute.cs: Set EmitContext return type.
2821 * class.cs: Set EmitContext return type.
2823 * codegen.cs (EmitContext): Return type cannot be null to stop messing
2824 with null/void meaning.
2826 * iterators.cs (ContainerType): Implemented.
2828 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
2830 * statement.cs (Return): Updated to lambda expressions.
2831 (Block.CloneTo): Parent can be null.
2833 2007-07-13 Marek Safar <marek.safar@gmail.com>
2835 A fix for bug #81917
2836 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
2838 * class.cs (FixedField): Check whether field is in unsafe scope.
2840 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
2841 (FieldExpr.Emit): Fixed buffers cannot be volatile.
2843 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
2846 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
2848 2007-07-13 Marek Safar <marek.safar@gmail.com>
2850 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
2851 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
2854 2007-07-13 Marek Safar <marek.safar@gmail.com>
2856 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
2858 2007-07-13 Marek Safar <marek.safar@gmail.com>
2860 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
2861 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
2863 * codegen.cs(EmitContext): Add ProbingMode flag.
2865 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
2867 * driver.cs: For now set both warning values.
2869 * ecore.cs (SimpleName): Name is readonly.
2870 (MethodGroup.OverloadResolve): One quick path for probing.
2872 * expression.cs (Unary): Set Oper r/o.
2873 (Binary): Set Oper r/o.
2874 (ParameterReference): Set few instance variables as r/o.
2875 (ParameterReference.DoResolveBase): Don't capture aruments when
2877 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
2878 (Arglist): arguments are private.
2879 (SizeOf): type is private and r/o.
2880 (MemberAccess): arguments are private.
2882 * report.cs: Enhanced reporting on/off capabilities.
2884 * lambda.cs: Uses ec.IsInProbingMode.
2885 (ContextualReturn): Derives from return.
2887 * rootcontext.cs: For now set both warning values.
2889 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
2891 (Return.Resolve): Don't die immediately.
2892 (Block.Resolve): Speed-up probing.
2893 (Block.CloneTo): Clone only child blocks.
2895 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
2897 * iterators.cs: reverted Miguel's latest change (r81925) as it
2898 breaks the build in System.
2900 2007-07-13 Miguel de Icaza <miguel@novell.com>
2902 * iterators.cs (Yield.CheckContext): Check for the iterator type
2903 also here as we can call into Yield even in codepaths that are not
2905 (MethodOrOperator is the only path that was checked).
2907 In addition to the standard check, use a more specific check for
2908 constructors to report a more verbose error.
2910 2007-07-12 Miguel de Icaza <miguel@novell.com>
2912 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
2913 report the warning and continue
2915 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
2916 values on the stack on the call to Emit. Use EmitStatement if
2917 possible, or using Emit + Pop if not possible. Fixes #82064
2919 2007-07-12 Raja R Harinath <rharinath@novell.com>
2921 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
2922 avoid try...finally in some cases.
2924 2007-07-10 Marek Safar <marek.safar@gmail.com>
2926 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
2928 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
2929 instead of method. Re-use standard error handling.
2930 (ConstructorInitializer.Emit): Simplified.
2932 * delegate.cs: Updated after Invocation.EmitCall change.
2934 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
2935 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
2936 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
2937 method and don't permanently changing input arguments.
2938 (MethodGroupExpr): Introduced resolved best_candidate, when method group
2939 is resolved it has one of the candidates is the best one which is later
2940 used to emit. Removed a few unused method.
2941 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
2943 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
2944 (Binary.ResolveOperator): Ditto.
2945 (ConditionalLogicalOperator.DoResolve): Ditto.
2946 (Invocation): Uses method group.
2947 (Invocation.DoResolve): Simplified.
2948 (Invocation.EmitCall): Removed useless is_static.
2949 (Invocation.Emit): Delegate to method group.
2950 (Invocation.EmitStatement): Simplified.
2951 (New): Uses method group.
2952 (MemberAccess.DoResolve): Don't destroy original expression.
2954 * statement.cs (ForEach.Resolve): Use null for no method arguments.
2956 2007-07-04 Marek Safar <marek.safar@gmail.com>
2958 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
2961 * lambda.cs: Add custom error message type.
2963 2007-07-03 Marek Safar <marek.safar@gmail.com>
2965 * lambda.cs: Simplified little bit.
2967 * parameter.cs: Introduced ImplicitLambdaParameter.
2968 (Parameters.CreateFullyResolved): New factory instead of ctor.
2972 * delegate.cs: Updated parameter creation.
2974 2007-07-03 Marek Safar <marek.safar@gmail.com>
2976 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
2979 * generic.cs: Synchronized with gmcs.
2981 2007-07-03 Marek Safar <marek.safar@gmail.com>
2983 * class.cs (Indexer): Check return type as soon as possible.
2985 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
2988 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
2990 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
2992 * parameter.cs (Parameter): Use expression type when it is available.
2994 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
2995 method modifier for the first parameter only.
2997 2007-06-24 Marek Safar <marek.safar@gmail.com>
2999 A fix for bug #81938
3000 * typemanager.cs (ChangeType): Fixed couple of char conversions.
3002 * constant.cs: Tide up an exception message.
3004 2007-06-22 Marek Safar <marek.safar@gmail.com>
3006 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
3007 an uninitialized variable is used.
3009 * expression.cs (LocalVariableReference.DoResolve): Ditto.
3011 2007-06-22 Marek Safar <marek.safar@gmail.com>
3013 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
3014 not found error handling.
3016 * expression.cs (ArrayCreation): Removed redundant fields and little bit
3018 (ArrayCreation.ResolveArrayElement): To be ready to customization.
3019 (ArrayCreation.DoResolve): Simplified.
3020 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
3021 its own resolve process.
3022 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
3024 2007-06-20 Marek Safar <marek.safar@gmail.com>
3026 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
3029 2007-06-20 Marek Safar <marek.safar@gmail.com>
3031 * cs-tokenizer.cs: Removed var related stuff.
3033 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
3034 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
3035 a type and a keyword at same time.
3037 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
3040 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
3041 implicitly typed arrays, more changes will follow.
3043 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
3045 2007-06-19 Marek Safar <marek.safar@gmail.com>
3047 * ecore.cs (VarExpr): Removed Handled field.
3049 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
3050 build-in assign functionality.
3051 (ForEach.Resolve): Removed all implicitly typed local variable code and
3053 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
3054 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
3056 2007-06-18 Marek Safar <marek.safar@gmail.com>
3058 * assign.cs: Removed implicitly typed local variable check.
3060 * expression.cs (LocalVariableReference.DoResolve): Add check for self
3061 referencing implicitly typed local variable.
3062 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
3065 * statement.cs (Fixed): Removed unsupported implicitly typed local
3068 2007-06-15 Marek Safar <marek.safar@gmail.com>
3070 * decl.cs (MemberName): Moved all Unbound stuff to parser.
3072 2007-06-14 Marek Safar <marek.safar@gmail.com>
3074 A fix for bugs #81855 and #76274
3075 * attribute.cs (AttachTo): Always set owner for global attributes to
3078 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
3081 * cs-parser.jay: Assembly and module attributes must precede all other
3082 elements except using clauses and extern alias declarations.
3084 2007-06-13 Marek Safar <marek.safar@gmail.com>
3086 A fix for bug #81748
3088 * expression.cs: More checks for non ISO-1 features.
3090 2007-06-12 Marek Safar <marek.safar@gmail.com>
3092 A fix for bug #81807
3093 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
3094 present inside switch statement and it is required by nullable check.
3096 2007-06-12 Marek Safar <marek.safar@gmail.com>
3098 A fix for bug #81840
3099 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
3100 when type matching fails.
3102 * namespace.cs: Tiny error message change.
3104 2007-06-12 Marek Safar <marek.safar@gmail.com>
3106 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
3107 reporting. Added automatic property check.
3109 * class.cs: Updated after CheckAbstractAndExtern relocation.
3110 (AEventPropertyAccessor.GetSignatureForError): Customized.
3112 2007-06-11 Marek Safar <marek.safar@gmail.com>
3114 * class.cs (DefineBaseTypes): Base type can be undefined.
3116 * ecore.cs (TypeLookup): Minor refactoring.
3117 (DoResolveAsTypeStep): Removed redundant check.
3119 * namespace.cs (Lookup): Removed redundant check.
3121 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
3122 ResolveAsTypeTerminal step.
3123 (BootstrapCorlib_*): Simplified.
3124 (PopulateCoreType): Core types can be now external.
3126 2007-06-07 Marek Safar <marek.safar@gmail.com>
3128 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
3130 (InferTypeArguments): Infers anonymous expression type arguments.
3131 (Compatible): Split to Compatible and InferTypeArguments.
3133 * lambda.cs: Updated.
3135 2007-06-08 Marek Safar <marek.safar@gmail.com>
3137 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
3139 2007-06-07 Raja R Harinath <harinath@gmail.com>
3141 Fix #80477, cs0135-2.cs, cs0135-3.cs
3142 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
3143 names to the "known" variables list.
3144 (Block.CheckInvariantMeaningInBlock): Handle the fact the
3145 parameter names are also "known".
3146 (Block.CheckError136): Remove.
3147 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
3150 2007-06-07 Marek Safar <marek.safar@gmail.com>
3152 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
3154 2007-06-06 Marek Safar <marek.safar@gmail.com>
3156 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
3157 internal error not an user error.
3159 * expression.cs (IsApplicable): Refactored to make debugging easier.
3161 * support.cs: More tricks for non-mono runtimes.
3163 * typemanager.cs (CoreLookupType): Made public.
3164 (InitSystemCore): All linq specific stuff moved to linq.cs
3166 2007-06-05 Marek Safar <marek.safar@gmail.com>
3168 * typemanager.cs (CSharpSignature): One more missing build-in types
3170 More tricks for non-mono runtime.
3172 2007-06-05 Raja R Harinath <harinath@gmail.com>
3174 * statement.cs (Block.CheckError136_InParents): Remove.
3175 (Block.AddVariable): Use GetParameterInfo instead.
3176 (ToplevelBlock.ProcessArguments): Likewise.
3178 2007-06-04 Raja R Harinath <rharinath@novell.com>
3180 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
3182 (ToplevelBlock.GetParameterInfo): Split out of ...
3183 (ToplevelBlock.GetParameterRefernce): ... this.
3184 (ToplevelBlock.ParameterMap): Remove.
3185 * expression.cs (ParameterReference): Update to use
3186 ToplevelParameterInfo.
3188 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
3191 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
3192 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
3194 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
3195 (ToplevelBlock.ProcessParameters) ... here.
3196 (ToplevelBlock..ctor): Invoke it.
3198 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
3201 * statement.cs (IKnownVariable): New interface.
3202 (LocalInfo): Implement it.
3203 (ToplevelParameterInfo): New class.
3204 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
3205 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
3206 GetKnownVariableInfo.
3208 2007-06-03 Raja R Harinath <harinath@gmail.com>
3210 Partly speed up CS0136 error checks.
3211 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
3212 'recurse' parameter.
3213 (Block.DoCheckError136): Only check errors in parameters. Move
3214 local variable checks ...
3215 (Block.AddVariable): ... here, and ...
3216 (ToplevelBlock.ResolveMeta): ... here.
3218 2007-06-02 Raja R Harinath <harinath@gmail.com>
3220 * statement.cs (Block.IsChildOf): Remove.
3222 * statement.cs (Statement.Clone): Move special case code ...
3223 (Block.CloneTo): ... here.
3225 2007-05-29 Raja R Harinath <rharinath@novell.com>
3227 * statement.cs (ToplevelBlock.container): Remove field. It's
3228 redundant with 'Parent'.
3229 (ToplevelBlock.ContainerBlock): Remove accessor.
3230 (ToplevelBlock..ctor): Update to changes. Register anonymous
3231 child with parent here, ...
3232 * cs-parser.jay (end_anonymous): ... not here. Don't modify
3234 (start_anonymous): Don't save current_block.
3235 (top_current_block): Remove.
3237 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
3238 (Block.Resolve): Update to changes.
3239 (Block..ctor): Move setting of "correct" 'Toplevel'
3240 and 'Explicit' fields to ...
3241 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
3243 2007-05-27 Raja R Harinath <harinath@gmail.com>
3246 * statement.cs (Block.Implicit): Remove.
3247 (Block): Update to changes.
3248 * flowanalysis.cs: Likewise.
3250 Mildly speed up CheckInvariantMeaningInBlock
3251 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
3252 Recursively call AddKnownVariable to all enclosing blocks.
3253 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
3254 Remove recursive calls.
3255 (Block): Update to changes.
3257 New ExplicitBlock invariants
3258 * statement.cs (Block.Explicit): New field. It points to the
3259 immediately enclosing non-implicit block.
3260 (Block..ctor): Maintain the invariant.
3261 * cs-parser.jay: Take advantage of invariant.
3263 Introduce ExplicitBlock
3264 * statement.cs (ExplicitBlock): New.
3265 (ToplevelBlock): Derive from it.
3266 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
3268 (Block.Implicit): Update to changes.
3269 * cs-parser.jay: Update to changes.
3272 * codegen.cs (EmitContext.IsLastStatement): Remove.
3273 * statement.cs (Block.DoEmit): Update to changes.
3275 2007-05-25 Raja R Harinath <rharinath@novell.com>
3277 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
3278 modifying current_block directly.
3280 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
3282 * class.cs: Implemented automatic properties (C# 3.0)
3283 Thanks to Marek for the help.
3285 2007-05-23 Raja R Harinath <rharinath@novell.com>
3287 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
3288 variable as assigned, note also that all its components are
3290 (MyBitVector.SetRange): New. Function to set multiple bits to true.
3292 2007-05-19 Marek Safar <marek.safar@gmail.com>
3294 * anonymous.cs, class.cs: Emit Compiler generated attribute when
3295 member is marked as compiler generated.
3297 * decl.cs (MemberCore): Refactored ModFlags into property.
3299 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
3300 (Check): Check only accessibility modifiers.
3302 2007-05-18 Raja R Harinath <rharinath@novell.com>
3304 Track all assignable slots in one bit array
3305 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
3306 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
3307 logic from VariableMap constructor here. Use the same 'offset'
3308 variable that's later used for computing offsets of local
3310 * flowanalysis.cs (UsageVector.parameters): Remove.
3311 (UsageVector): Update to changes.
3312 (VariableMap): Remove.
3314 Avoid creating ParameterMap in every block
3315 * statement.cs (Block.ParameterMap): Move ...
3316 (ToplevelBlock.ParameterMap): ... here.
3317 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
3319 * flowanalysis.cs (FlowBranching.param_map): Remove.
3320 (FlowBranching.UsageVector): Update to changes.
3321 (FlowBranchingToplevel.CheckOutParameters): Likewise.
3323 * statement.cs (Block.CloneTo): Clone Toplevel field too.
3325 * expression.cs (ParameterReference): Distinguish between block
3326 where parameter was referenced and declared.
3328 2007-05-18 Marek Safar <marek.safar@gmail.com>
3330 * flowanalysis.cs, statement.cs: Put back improved error handling.
3332 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
3336 Imporved object and collection initialization (C# 3.0).
3338 2007-05-15 Marek Safar <marek.safar@gmail.com>
3340 A fix for bug #81380
3341 * expression.cs (Is.DoResolve): Only value types have constant `is'
3344 2007-05-15 Raja R Harinath <rharinath@novell.com>
3346 * statement.cs (ToplevelBlock.child): Remove.
3348 2007-05-15 Raja R Harinath <harinath@gmail.com>
3350 Rationalize ResolveMeta: refactoring
3351 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
3352 out constant handling code into ...
3353 (Block.DoResolveConstants): ... this.
3355 Rationalize ResolveMeta: kill local_map
3356 * statement.cs (Block.local_map, Block.LocalMap): Remove.
3357 (Block.AssignableSlots): New.
3358 (Block.ResolveMeta): Make protected. Don't create a VariableMap
3359 for locals -- move code from VariableMap here. Avoid unnecessary
3361 * flowanalysis.cs (FlowBranching.local_map): Remove.
3362 (FlowBranching..ctor): Use Block.AssignableSlots.
3363 (VariableMap): Remove unused constructors.
3365 2007-05-11 Raja R Harinath <rharinath@novell.com>
3367 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
3369 2007-05-11 Marek Safar <marek.safar@gmail.com>
3371 * typemanager.cs (IsFriendAssembly): Should not be called for building
3374 2007-05-09 Marek Safar <marek.safar@gmail.com>
3376 * literal.cs (NullConstant): Print null in all cases.
3378 * expression.cs (Binary.ResolveOperator): Implemented delegate
3379 comparison based on C# 2.0 changes.
3381 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
3383 This code is contributed under the MIT X11 license
3385 The following enables support for several C# 3.0 language features:
3387 * cs-tokenizer.cs: Added support for the "var" keyword.
3389 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
3390 Added VarExpr class to facilitate type inferencing.
3392 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
3393 to support anonymous types.
3395 * assign.cs: Added support for type inferencing and initialization.
3397 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
3399 * expression.cs: Added implicit array support to ArrayCreation.
3400 Added 5 types and 1 interface:
3402 IInitializable Implementing classes can inject initializing
3403 statements after object instantiation.
3405 Initializer Stores data for object initialization.
3407 AnonymousType An expression for anonymous types.
3409 AnonymousTypeParameter Stores data about an anonymous type's field.
3411 NewInitialize An expression for object initialization.
3413 CollectionInitialize An expression for collection initialization.
3415 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
3418 2007-05-06 Marek Safar <marek.safar@gmail.com>
3420 A fix for bug #81500
3421 * cs-tokenizer.cs: Add special handling for coalescing operator.
3423 2007-05-06 Marek Safar <marek.safar@gmail.com>
3425 A fix for bug #81529
3426 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
3427 its value from base class until it is redefined.
3429 2007-05-02 Raja R Harinath <rharinath@novell.com>
3431 Fix regression in cs0631-3.cs
3432 * cs-parser.jay (operator_declarator): Add opt_attributes to error
3433 fallback. Make error fallback catch more cases.
3435 2007-05-01 Miguel de Icaza <miguel@novell.com>
3437 * cs-parser.jay: Allow parameters in operator declarations to have
3440 2007-04-27 Miguel de Icaza <miguel@novell.com>
3442 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
3445 * lambda.cs (ContextualReturn.Resolve): An expression is valid
3446 inside the ContextualReturn, it does not have to be an
3447 ExpressionStatement.
3449 2007-04-24 Miguel de Icaza <miguel@novell.com>
3451 * lambda.cs (ContextualReturn.Resolve): if the return type is not
3454 2007-04-23 Miguel de Icaza <miguel@novell.com>
3456 * anonymous.cs (AnonymousContainer): split the virtual Resolve
3457 method in two methods: ResolveNoDefine and Resolve.
3459 ResolveNoDefine will stop just after ResolveTopBlock has been
3462 Resolve will then continue by creating a method and issuing the
3463 call to method.Define ().
3465 (AnonymousMethod): Split and implement the new Resolve and
3466 ResolveNoDefine as well.
3468 * lambda.cs (LambdaExpression): Split the anonymous method
3469 resolution code into a separate routine (CoreCompatibilityTest)
3470 from DoCompatibleTest.
3472 (LambdaExpression.TryBuild): New method, this method tries to
3473 build the LambdaExpression with the given set of types to be used
3474 as the types for the various parameters of the lambda expression.
3476 If the compilation succeed with the given types, the infered type
3477 of the Anonymous method is returned, otherwise null is returned.
3479 2007-04-23 Marek Safar <marek.safar@gmail.com>
3481 A fix for bug #81414
3482 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
3484 2007-04-22 Miguel de Icaza <miguel@novell.com>
3486 * cs-tokenizer.cs: Change various identifiers here from the
3487 camelCasing to the recommended Linux-like style for instance
3488 variables from the Coding Guidelines.
3490 2007-04-19 Martin Baulig <martin@ximian.com>
3493 (Convert.ImplicitReferenceConversionCore): Allow conversions from
3494 System.Enum to System.ValueType.
3496 2007-04-13 Martin Baulig <martin@ximian.com>
3498 Rewrote implicit reference conversions. We need to distinguish
3499 between implicit reference conversions (13.1.4) and implicit
3500 boxing conversions (13.1.5).
3502 According to the spec, there's an an implicit conversion
3503 "From a one-dimensional array-type S[] to IList<T> and base
3504 interfaces of this interface, provided there is an implicit
3505 reference conversion from S to T." Note that this does not
3506 include boxing conversions.
3509 (Convert.ImplicitTypeParameterBoxingConversion): New method.
3510 (Convert.ImplicitReferenceConversion): Split into
3511 ImplicitReferenceConversionCore() and
3512 ImplicitBoxingConversionExist().
3513 (Convert.ImplicitReferenceConversionExists): Use the new
3514 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
3516 2007-04-12 Martin Baulig <martin@ximian.com>
3518 * convert.cs (Convert.ImplicitReferenceConversion): Move the
3519 `TypeManager.null_type' checks up to the top of the method.
3521 2007-04-11 Marek Safar <marek.safar@gmail.com>
3523 A fix for bug #81350
3524 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
3527 2007-04-11 Martin Baulig <martin@ximian.com>
3529 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
3530 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
3531 to make this work for generic classes; fixes #79561.
3533 2007-04-11 Martin Baulig <martin@ximian.com>
3535 * expression.cs (As): Add support for nullable types; fixes #79371.
3537 2007-04-11 Martin Baulig <martin@ximian.com>
3539 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
3540 `type.FullName' is null; fixes #80243.
3542 2007-04-11 Martin Baulig <martin@ximian.com>
3544 * expression.cs (Invocation.IsApplicable): Don't modify the method
3545 if type inference succeeded, but the method was not applicable.
3548 2007-04-10 Marek Safar <marek.safar@gmail.com>
3550 A fix for bug #81324
3551 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
3552 internal and external namespaces containers.
3554 2007-04-10 Martin Baulig <martin@ximian.com>
3556 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
3557 TypeManager.DropGenericMethodArguments() so we also call
3558 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
3560 2007-04-10 Martin Baulig <martin@ximian.com>
3562 * iterators.cs (Iterator.CreateIterator): Don't crash if
3563 `method.ReturnType' is null. This happens if something went wrong
3564 while resolving that typ (we already reported an error in this case).
3566 2007-04-10 Martin Baulig <martin@ximian.com>
3568 * expression.cs (New.DoResolve): Don't call CheckComImport() on
3569 generic interfaces; report the CS0144 directly.
3571 2007-04-10 Martin Baulig <martin@ximian.com>
3573 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
3574 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
3576 2007-04-10 Martin Baulig <martin@ximian.com>
3578 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
3580 2007-04-09 Raja R Harinath <rharinath@novell.com>
3583 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
3584 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
3587 * statement.cs (For.Resolve): If resolution fails, use
3590 2007-04-08 Marek Safar <marek.safar@gmail.com>
3592 * anonymous.cs (MakeName): Make faster and zero-based.
3593 (VerifyExplicitParameterCompatibility): Back to mode where generic
3594 parameter is ignored.
3595 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
3597 * class.cs (EmitType): Method can emit another new method.
3599 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
3601 * driver.cs: Updated.
3603 * lambda.cs: Reuse predefined empty parameters.
3605 * parameter.cs: Updated
3607 * support.cs: Implemented InflateTypes.
3609 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
3610 (InitSystemCore): Introduced to isolate 3.0 dependencies.
3612 2007-04-03 Martin Baulig <martin@ximian.com>
3616 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
3617 version of TypeManager.IsOverride() which also works with generic
3620 2007-04-03 Martin Baulig <martin@ximian.com>
3625 (Convert.ExplicitReferenceConversion): We need to cast when
3626 converting from IList<T> to S[].
3628 2007-04-01 Marek Safar <marek.safar@gmail.com>
3630 * decl.cs (FindExtensionMethods): Consider all candidates with same name
3633 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
3635 2007-03-31 Marek Safar <marek.safar@gmail.com>
3637 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
3638 argument and return type inferring.
3640 * codegen.cs (InferReturnType): Flag whether return can be inferred.
3641 (ReturnType): Turned to property.
3643 * statement.cs (Return): Implemented return type inferring.
3645 * support.cs (ReflectionParameters): Use local types if possible.
3647 2007-03-30 Raja R Harinath <rharinath@novell.com>
3649 * flowanalysis.cs (FlowBranching.Reachability): Remove.
3650 (FlowBranching.UsageVector): Update to changes.
3652 Prepare to kill 'Reachability'
3653 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
3654 argument of constructor.
3656 2007-03-29 Raja R Harinath <rharinath@novell.com>
3658 Prepare to kill 'Reachability'
3659 * flowanalysis.cs (UsageVector.is_unreachable): New.
3660 (UsageVector): Update to maintain 'is_unreachable' in parallel to
3661 'reachability', and verify they're consistent.
3664 * expression.cs (New.EmitStatement): Handle type parameters here too.
3666 2007-03-29 Martin Baulig <martin@ximian.com>
3671 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
3672 CompilerGeneratedClass.
3673 (ScopeInfo.EmitScopeInstance): Make this protected.
3674 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
3675 `ec.CurrentAnonymousMethod.Scope == Scope'.
3677 * statement.cs (Block.ScopeInfo): Make this a property.
3679 2007-03-27 Raja R Harinath <harinath@gmail.com>
3681 Prepare to kill 'Reachability'
3682 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
3683 (FlowBranching.UsageVector.Reachability): Remove property.
3684 (FlowBranching.UsageVector.IsUnreachable): New property.
3685 (FlowBranching.UsageVector.ResetBarrier): New.
3686 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
3687 * codegen.cs, statement.cs: Update to changes.
3689 2007-03-27 Martin Baulig <martin@ximian.com>
3694 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
3697 2007-03-26 Raja R Harinath <rharinath@novell.com>
3699 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
3700 instead of TriState. Remove all mention of TriState.
3702 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
3703 replaced by a boolean. Add boolean 'is_unreachable' field, check
3704 and maintain invariants.
3706 2007-03-25 Marek Safar <marek.safar@gmail.com>
3708 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
3710 2007-03-25 Marek Safar <marek.safar@gmail.com>
3712 * expression.cs: Stop using obsolete 2.0 opcodes.
3714 2007-03-25 Marek Safar <marek.safar@gmail.com>
3716 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
3717 one of the latests Martin's fixes.
3719 2007-03-23 Miguel de Icaza <miguel@novell.com>
3721 * expression.cs: On BigEndian systems, swap the bytes, temporary
3722 solution until we get a new bitconverter class.
3724 2007-03-23 Martin Baulig <martin@ximian.com>
3728 * decl.cs (MemberCache.AddMembers): Add generic methods both as
3729 "Method" and "Method`1". Normally, a cache lookup is done on the
3730 "Method" form (ie. without the generic arity), but this one makes
3731 lookups on the full form work as well.
3733 2007-03-22 Raja R Harinath <rharinath@novell.com>
3735 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
3738 2007-03-20 Bill Holmes <billholmes54@gmail.com>
3740 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
3741 ordered_member_list, to TypeBuilder to store members to be defined
3742 in the order they were parsed in.
3743 - ordered_explicit_member_list contains all properties indexers
3744 and methods that are defined as explicit implementation of an
3745 interface or base class.
3746 - ordered_member_list contains all properties indexers and methods
3747 that are not defined as explicit implementation of an interface
3750 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
3751 functionality in these removed classes has been replaced with
3752 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
3753 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
3755 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
3756 to CheckForDuplications inside GetMethod and SetMethod Define Method
3757 to handle method property and indexer name conflicts.
3761 All code is contributed under the MIT/X11 license.
3763 2007-03-20 Martin Baulig <martin@ximian.com>
3765 * class.cs (TypeContainer.Interfaces): Removed; they're now
3766 included in `TypeContainer.Types'.
3768 2007-03-20 Martin Baulig <martin@ximian.com>
3770 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
3772 * class.cs (TypeContainer.CreateType): New public method. This is
3773 now called before DefineType() to create the TypeBuilders.
3774 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
3775 has already been created by CreateType().
3776 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
3777 don't resolve our base classes here; this has been moved into
3778 DefineBaseTypes(). We're now called from CreateType().
3779 (TypeContainer.DefineBaseTypes): New private method; resolve our
3780 base classes here. We're now called from DefineType().
3783 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
3784 our types first to create all the TypeBuilders. After that, call
3785 TypeContainer.DefineType() on all the types which'll resolve their
3786 base classes and setup the resolve order.
3788 2007-03-20 Martin Baulig <martin@ximian.com>
3790 * class.cs (TypeContainer.Enums): Removed; they're now included in
3791 `TypeContainer.Types'.
3793 2007-03-20 Martin Baulig <martin@ximian.com>
3796 (TypeContainer.DefineType): Don't call ResolveMembers() here.
3797 (TypeContainer.DoResolveMembers): Call DefineType() on our
3798 `compiler_generated' classes; moved here from DefineNestedTypes().
3801 (RootContext.ResolveTree): Call ResolveMembers() on all
3802 TypeContainer's in the `type_container_resolve_order'.
3804 2007-03-19 Marek Safar <marek.safar@gmail.com>
3806 * class.cs: Use corlib to handle InternalMethodImplAttribute.
3808 2007-03-17 Marek Safar <marek.safar@gmail.com>
3810 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
3811 implementation flags.
3813 2007-03-17 Marek Safar <marek.safar@gmail.com>
3815 * class.cs: More optimizations for type parameters.
3817 2007-03-15 Marek Safar <marek.safar@gmail.com>
3819 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
3821 * ecore.cs, parameter.cs: More common code for both corlibs.
3823 * typemanager.cs (IsGenericMethod): Simplified.
3825 2007-03-15 Raja R Harinath <rharinath@novell.com>
3827 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3829 * statement.cs, iterators.cs, lambda.cs: Update to changes.
3831 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
3832 unconditionally. Simplify explanation.
3833 (Try.Resolve, Using.Resolve): Likewise.
3835 2007-03-15 Martin Baulig <martin@ximian.com>
3839 * decl.cs (DeclSpace): If we're a partial class, use our
3840 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
3842 2007-03-15 Raja R Harinath <rharinath@novell.com>
3844 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
3846 (FlowBranching.UsageVector): Update to changes.
3847 (FlowBranching.MergeSiblings): Likewise.
3848 * statement.cs: Likewise.
3850 2007-03-15 Martin Baulig <martin@ximian.com>
3855 (MemberCache): Added a special .ctor for type parameters.
3858 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
3861 2007-03-09 Martin Baulig <martin@ximian.com>
3863 * enum.cs (Enum): Make this a TypeContainer.
3864 (EnumMember): Derive from `Const'.
3867 (Const.DoResolveValue): New protected virtual method; move most of
3868 the functionality of ResolveValue() here so we can override it in
3870 (Const.CreateConstantReference): Make this virtual.
3872 * class.cs (Kind): Add `Kind.Enum'.
3873 (TypeContainer.Emit): Don't emit the enums here; they're already
3874 in the `RootContext.typecontainer_resolve_order'.
3876 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
3877 here; they're already in the `typecontainer_resolve_order'.
3879 * ecore.cs (EnumConstant.ConvertImplicitly): Add
3880 TypeManager.DropGenericTypeArguments().
3883 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
3884 (TypeManager.IsEnumType): Likewise.
3885 (TypeManager.EnumToUnderlying): Likewise.
3886 (TypeManager.IsEqual): Add support for enums.
3888 2007-03-12 Raja R Harinath <rharinath@novell.com>
3890 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
3891 DefaultParameterValueAttribute to be undefined, say if System.dll
3894 2007-03-11 Marek Safar <marek.safar@gmail.com>
3896 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
3899 2007-03-10 Marek Safar <marek.safar@gmail.com>
3901 * class.cs, parameter.cs: Unified parameters verification.
3903 2007-03-08 Martin Baulig <martin@ximian.com>
3905 * cs-parser.jay (constructor_header): Pass the location to the
3906 newly created TopLevelBlock.
3908 2007-03-07 Martin Baulig <martin@ximian.com>
3910 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
3912 2007-03-06 Miguel de Icaza <miguel@novell.com>
3914 * convert.cs (ExplicitReferenceConversionExists): Sync this method
3915 with the changes from David, fixes the build.
3917 2007-03-05 David Mitchell <dmitchell@logos.com>
3919 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
3920 and its base interfaces to a one-dimensional array type S[],
3921 provided there is an implicit or explicit reference conversion
3924 2007-03-03 Marek Safar <marek.safar@gmail.com>
3926 * cs-tokenizer.cs: Implemented basic linq grammar.
3928 * driver.cs: Set linq lang version on demand.
3930 2007-02-26 Marek Safar <marek.safar@gmail.com>
3932 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
3934 2007-02-25 Marek Safar <marek.safar@gmail.com>
3936 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
3939 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
3941 Check property and event extern attributes.
3943 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
3946 2007-02-24 Marek Safar <marek.safar@gmail.com>
3948 A fix for bug #80407
3949 * ecore.cs: Don't report ambiguity error when methods have same parent.
3951 2007-02-23 Marek Safar <marek.safar@gmail.com>
3953 A fix for bug #80878
3954 * class.cs, cs-parser.jay: Event property can host anonymous methods.
3956 2007-02-22 Marek Safar <marek.safar@gmail.com>
3958 * attribute.cs: Enable ExtensionAttribute presence test.
3960 2007-02-22 Marek Safar <marek.safar@gmail.com>
3962 * class.cs: Warn about missing GetHashCode only when Equals is override.
3964 * decl.cs: Check accessibility of type arguments.
3966 * typemanager.cs: Correctly report nullable array.
3968 2007-02-20 Marek Safar <marek.safar@gmail.com>
3970 * class.cs, report.cs: Capture more details when things go wrong.
3972 2007-02-20 Marek Safar <marek.safar@gmail.com>
3974 A fix for bug #80650
3975 * cs-parser.jay: Anonymous container starts at constructor declaration
3976 and not at block beginning because it has to be usable in constructor
3979 * statement.cs: Use context location and not block one for error reporting.
3981 2007-02-18 Marek Safar <marek.safar@gmail.com>
3983 A fix for bug #78712
3984 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
3987 2007-02-18 Marek Safar <marek.safar@gmail.com>
3989 A fix for bug #80493 by Atsushi Enomoto
3990 * cs-parser.jay: Ignore invalid attribute target.
3992 2007-02-18 Marek Safar <marek.safar@gmail.com>
3994 * cs-tokenizer.cs: Ignore '\0' as white space character.
3996 2007-02-17 Miguel de Icaza <miguel@novell.com>
3998 * cs-parser.jay: Add support for lambda expressions to the mcs
4001 * lambda.cs: Only clone when we are probing, not on the final call
4002 (Compatible is the final call).
4004 * statement.cs (CloneContext): Introduce class to provide block
4005 remapping during clone.
4007 All statements Clone themselves now.
4009 (Clone): special handling for blocks, when we clone a block, we
4010 register the block inside this routine, as children of the block
4011 might trigger a lookup.
4013 * expression.cs: Add support for CloneContext in all expressions.
4015 2007-02-17 Marek Safar <marek.safar@gmail.com>
4017 A fix for bug #80493
4018 * statement.cs: Report ambiguous warning when interfaces are not related.
4020 2007-02-15 Marek Safar <marek.safar@gmail.com>
4022 C# 3.0 extension methods.
4024 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
4025 cannot be used directly.
4027 * class.cs (Class.Emit): Emit extension attribute if any class method
4028 is extension method.
4029 (Method.Define): Add basic extension method validation conditions.
4030 (Method.Emit): Emit extension attribute for method.
4032 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
4033 extension method exists. Currently we follow same approach as Microsoft
4034 does, emit even if a method or a class are private but this can change
4037 * cs-parser.jay: Add handling of `this' keyword in method parameters
4040 * decl.cs (DeclSpace.IsStaticClass): New property.
4041 (MemberCache.FindExtensionMethods): Looks for extension methods with
4042 defined name and extension type.
4044 * doc.cs: Updated after OverloadResolve changes.
4046 * driver.cs: Add new soft reference to System.Core.dll.
4048 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
4049 (ExtensionMethodGroupExpr): Represents group of extension methods.
4051 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
4052 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
4053 to MethodGroupExpr and made non-static for easier customization.
4054 (Invocation.DoResolve): Add extension method lookup when no standard
4056 (MemberAccess.DoResolve): Try extension methods if no member exists.
4058 * modifiers.cs: Add METHOD_EXTENSION modifier.
4060 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
4061 as well as candidate extension type.
4062 (ComputeNamespaces): When assembly constains extension methods registers
4064 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
4065 extension method lookup.
4066 (Namespace.LookupExtensionMethod): Looks for extension method in this
4068 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
4069 find a method which matches name and extensionType.
4071 * parameter.cs (Parameter): Add This modifer.
4072 (HasExtensionMethodModifier): New property.
4073 (Resolve): Add extension parameter check.
4074 (ModFlags): turned to property to exclude this modifier as it is not real
4076 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
4078 * support.cs (ParameterData): Add ExtensionMethodType.
4079 (ReflectionParameters): Implemented ExtensionMethodType interface property.
4081 * typemanager.cs: Add type and ctor extension attribute type.
4083 2007-02-15 Miguel de Icaza <miguel@novell.com>
4085 * report.cs (DisableErrors, EnableErrors): used to prevent error
4086 output when we are "trying" to compile various methods with
4089 * ecore.cs (Expression): Add Clone method that calls the virtual
4090 CloneTo method. The current CloneTo method in Expression throws
4091 an exception so we can track down all the places where this must
4092 be implemented (not using abstract, because that would be a lot of
4093 up-front-work before we can start testing the implementation
4096 Important: we only need Clone capabilities for expressions created
4097 by the parser, as the expressions we will be cloning are
4098 expressions in the pre-resolved state. This vastly simplifies
4101 (SimpleName): Add CloneTo that does nothing.
4102 (EmptyCast): Add CloneTo.
4104 * expression.cs (Binary): Implement CloneTo.
4105 (Invocation.IsApplicable): Store the current ec in
4106 EmitContext.TempEc and restore it on return. This is used so we
4107 do not have to sprinkle hundres of methods with an extra
4108 EmitContext, we know that the only user is the lambda expression
4109 ImplicitConversionExists code.
4111 (Argument): Add Cloning capabilities.
4112 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
4113 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
4114 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
4115 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
4116 IndexerAccess): Add Clone capability.
4118 (LocalVariableReference, This): TODO: needs cloned Block mapping.
4120 (Argument): Add cloning capability.
4122 * assign.cs (Assign): Implement CloneTo.
4124 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
4126 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
4127 version by calling Convert with the EmitContext (that we are
4128 currently storing in ec, this is not great, but will do for now,
4129 to avoid passing EmitContext parameters to hundreds of functions
4130 that do not need them now).
4132 (SetExpression): Remove, it is not needed.
4134 (ContextualReturn): Implement CloneTo.
4136 * statement.cs (Statement): Implement cloning infrastructure,
4137 similar to expressions.
4139 (Block): Partial implementation of Clone for statements.
4141 (Return): Implement clone.
4143 * constant.cs (Constant.CloneTo): New method, does nothing.
4145 * codegen.cs (TempEc): Add a static EmitContext as a temporary
4146 solution, until we decide how to exactly do this.
4148 2007-02-14 Marek Safar <marek.safar@gmail.com>
4150 A fix for bug #80493
4151 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
4152 a property is override we need to use second accessor.
4154 2007-02-13 Marek Safar <marek.safar@gmail.com>
4156 A fix for bug #80418
4157 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
4160 2007-02-13 Marek Safar <marek.safar@gmail.com>
4162 Another fix for bug #80749
4163 * pending.cs: Abstract class has priority over interfaces.
4165 2007-02-13 Marek Safar <marek.safar@gmail.com>
4167 Another fix for bug #80749
4168 * pending.cs: Abstract class has priority over interfaces.
4170 2007-02-13 Marek Safar <marek.safar@gmail.com>
4172 Another fix for bug #80749
4173 * pending.cs: Abstract class has priority over interfaces.
4175 2007-02-13 Marek Safar <marek.safar@gmail.com>
4177 Another fix for bug #80749
4178 * pending.cs: Abstract class has priority over interfaces.
4180 2007-02-13 Marek Safar <marek.safar@gmail.com>
4182 * class.cs Better error message.
4184 * driver.cs: Add shorter versions of -optimize option.
4186 2007-02-13 Martin Baulig <martin@ximian.com>
4188 * class.cs (Constructor.Emit): Check the return value of
4189 ec.ResolveTopBlock() and return on error.
4191 2007-02-13 Raja R Harinath <rharinath@novell.com>
4193 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
4194 message to fix error message regression.
4196 2007-02-12 Marek Safar <marek.safar@gmail.com>
4198 * delegate.cs: Delegate creation expression cannot be of Nullable type.
4200 2007-02-12 Marek Safar <marek.safar@gmail.com>
4202 A fix for bug #80749
4203 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
4204 its parent container.
4206 * class.cs (DefineFieldInitializers): Each initializer can has different
4209 * const.cs: Updated.
4211 2007-02-11 Miguel de Icaza <miguel@novell.com>
4213 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
4214 now all the heavy lifting to check that embedded statements or
4215 expressions have the right form is done in the ContextualReturn.
4217 (ContextualReturn): New class.
4219 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
4220 method that can be invoked to report 201, so we do not replicate
4223 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
4225 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
4226 treating tabs as spaces.
4228 2007-02-09 Marek Safar <marek.safar@gmail.com>
4230 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
4231 * assign.cs: Use full implicit conversion for right side check.
4233 2007-02-09 Marek Safar <marek.safar@gmail.com>
4235 * statement.cs (Switch): Switch over boolean type is not standardized.
4237 2007-02-08 Marek Safar <marek.safar@gmail.com>
4239 A fix for bug #80755
4240 * decl.cs (FindBaseEvent): Don't use method cache for events.
4242 2007-02-07 Marek Safar <marek.safar@gmail.com>
4244 * cs-parser.jay: Better syntax error handling.
4246 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
4247 instead of underlying type value.
4249 2007-02-06 Marek Safar <marek.safar@gmail.com>
4251 * driver.cs: Check define identifier before is registered.
4253 * namespace.cs: Use existing error message.
4255 * report.cs: New warning.
4257 2007-02-06 Marek Safar <marek.safar@gmail.com>
4259 A fix for bug #80742
4260 * expression.cs: Delegate Invoke method can be called directly.
4262 2007-02-06 Marek Safar <marek.safar@gmail.com>
4264 A fix for bug #80676
4265 * class.cs (IsEntryPoint): The Main method can have params modifier.
4267 2007-02-04 Miguel de Icaza <miguel@novell.com>
4269 * parameter.cs (Parameter, Parameters): Add Clone method.
4271 * anonymous.cs (Compatible): Turn method into virtual method, so
4272 LambdaExpression can implement a different behavior.
4274 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
4275 out the basic checking here, so it can be used by
4278 * lambda.cs: Introduce "Compatible" function that will do the
4281 2007-02-02 Marek Safar <marek.safar@gmail.com>
4283 * attribute.cs: Unified one error message.
4285 * class.cs (Class): Use type attributes and not properties to test static
4287 (IsEntryPoint): Don's pass local variable.
4289 * convert.cs: Removed duplicate check.
4291 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
4293 * driver.cs: Don't crash when soft reference does not exist.
4295 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
4296 (UsingEntry): Removed redundant allocation.
4298 * parameter.cs: Add fast path for type parameters.
4300 * support.cs: Don't allocate attribute when it's not used.
4302 2007-01-30 Miguel de Icaza <miguel@novell.com>
4305 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
4306 this into a virtual method, so we can override it in LambdaExpression.
4308 * driver.cs: Improve diagnostics in case of failure.
4310 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
4311 write a function that is slightly more complex and that parses:
4313 type identifier [, type identifier]* )
4315 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
4318 (canEmpty ? i >= 0 : i > 0)
4320 2007-01-30 Raja R Harinath <rharinath@novell.com>
4322 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
4323 exception on possibly valid code.
4325 2007-01-29 Raja R Harinath <rharinath@novell.com>
4327 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
4329 (parse_opt_type_arguments): Remove. It's almost the same as
4331 (parse_namespace_or_typename): Use parse_less_than.
4333 2007-01-28 Miguel de Icaza <miguel@novell.com>
4335 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
4336 this bug took a few hours to find, because the state saved and
4337 restored by PushPosition and PopPosition was ignoring the state of
4338 parse_generic_less_than.
4340 I can also now remove the handling of OP_LT and OP_GT, this solves
4343 * cs-tokenizer.cs: store the location for the ARROW token, we use
4346 (PushPosition, PopPosition): save/restore also `current_token',
4347 restore `parse_generic_less_than' (was missing).
4349 (parse_opt_type_arguments): use parse_type, not
4350 parse_namespace_or_typename to parse types.
4352 * lambda.cs: Empty new file, will eventually have the lambda
4353 expression implementation.
4355 * lambda.test: used to test the internal tokenizer.
4357 * report.cs (FeatureIsNotISO1): Rename from
4358 FeatureIsNotStandardized, because it was about the language level
4359 (1 vs 2) it was not about standarization.
4361 (FeatureRequiresLINQ): New.
4363 * support.cs (SeekableStreamReader): Only require that the reader
4364 is a TextReader, not a StreamReader, so we can plug StringReader.
4366 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
4367 given position in the input stream the following tokens can be
4368 parsed as a type followed by an identifier.
4370 (is_punct): after a '(' if parse_type_and_parameter returns true,
4371 then return a special token OPEN_PARENS_LAMBDA which is used to
4372 avoid reduce/reduce errors in the grammar for the
4373 lambda_expression rules.
4375 (parse_type): implement a type parser inside the
4376 tokenizer, the parser only returns true or false depending on
4377 whether the input at a given position can be parsed as a type.
4379 (peek_token): new method used during type parsing.
4381 2007-01-28 Raja R Harinath <rharinath@novell.com>
4384 * anonymous.cs (ScopeInfo.InflateParameters): New.
4385 (AnonymousContainer.Resolve): Use it to redirect types of
4386 delegate parameters.
4388 2007-01-27 Raja R Harinath <rharinath@novell.com>
4391 * expression.cs (Error_InvalidArguments): Don't use two different
4392 messages for CS1503. Use ExtraInformation and
4393 SymbolRelatedToPreviousError instead.
4396 * decl.cs (DeclSpace.initialize_type_params): Don't access
4397 'type_params' of a partial class directly.
4399 2007-01-26 Miguel de Icaza <miguel@novell.com>
4401 * constant.cs: Removed a handful of out-of-range checks that were
4404 2007-01-25 Marek Safar <marek.safar@gmail.com>
4406 * expression.cs (CheckUselessComparison): Add additional check for char
4409 * namespace.cs: Fixed typo.
4411 2007-01-23 Miguel de Icaza <miguel@novell.com>
4413 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
4414 gone, instead we inline the test, preventing the needless casts to
4415 longs, ulongs and doubles for the parameters, avoiding calls to
4416 methods that overchecked stuff, and instead inlined things
4419 2007-01-20 Marek Safar <marek.safar@gmail.com>
4421 * cs-parser.jay: Better parameter error handling.
4423 2007-01-17 Marek Safar <marek.safar@gmail.com>
4425 A fix for bug #80368, #80522
4426 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
4427 whether array initializer contains constants only.
4428 (ArrayCreation.Emit): Use better formula to decide when
4429 are array initializers for static initialization.
4430 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
4431 have to emit even constants otherwise they are pre-initialized.
4433 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
4434 Raja R Harinath <rharinath@novell.com>
4436 Fix emit order of 'get' vs. 'set'.
4437 * support.cs (Accessors): New.
4438 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
4439 Note the order in which accessors are declared in the source.
4440 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
4441 Refactored from Property.Define and Indexer.Define.
4442 (PropertyBase.DefineAccessors): New helper that calls the above in
4443 appropriate order as noted by the parser.
4444 (Property.Define, Indexer.Define): Update to changes.
4445 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
4447 2007-01-17 Raja R Harinath <rharinath@novell.com>
4449 Fix cs0029-6.cs and gcs0029-2.cs (regression)
4450 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
4451 there's an implicit conversion from the current type to the target
4452 type before converting the underlying constant.
4454 2007-01-16 Marek Safar <marek.safar@gmail.com>
4456 * const.cs (ResolveValue): Updated after constant conversion was made more
4459 * constant.cs (GetAttributableValue): constant to object conversion is
4460 used for attributes only.
4461 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
4462 constant conversions.
4463 (LongConstant.ConvertImplicitly): Ditto.
4465 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
4466 (ImplicitConversionStandard): Handle constant conversion as extra step.
4467 It solves the issue when constant conversion was called indirectly like
4468 inside array initializer and constant folding was skipped.
4470 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
4473 * statement.cs(ImplicitConversionStandard): Updated after constant
4474 conversion was made more generic.
4476 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
4478 * expression.cs (As.DoResolve): Use GenericConstraints instead of
4479 Constraints, solves the problem where the compiler incorrectly
4480 reported that a type parameter was not constrained to a class (Bug
4483 2007-01-14 Marek Habersack <grendello@gmail.com>
4485 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
4487 2007-01-14 Marek Safar <marek.safar@gmail.com>
4489 A fix for bug #80368
4490 * assign.cs (FieldInitializer): New class implements field
4491 initializer statement.
4493 * attribute.cs: Update after FieldMember rename.
4495 * class.cs (PropertyBasedMember): New common class for property based
4497 (InterfaceMemberBase): New base class for all members which can be used as
4498 an interface members.
4499 (MethodCore): Moved really common code to InterfaceMemberBase.
4500 (Method.Define): Equal and GetHasCode detection is relevant for methods
4502 (MethodData.Define): Don't assume that public event implements an
4503 interface automatically.
4504 (MethodData.DefineMethodBuilder): Issue an error even if only extern
4506 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
4507 (FieldMember): Merged with FieldBase.
4508 (EventProperty.AEventPropertyAccessor): New specialization to check whether
4509 event extern modifier can be used.
4510 (EventField.EventFieldAccessor): Moved event field specific code here.
4511 (Event.AllowedModifiers): Even event can be extern.
4512 (Event.FindOutBaseMethod): New override specific to events.
4513 (Indexer.parameters): Reintroduce parameters because base class holds
4514 only properties common data.
4515 (Indexer.CheckForDuplications): Indexers are threated as methods so we
4516 need do extra parameters check.
4518 * const.cs: Update after FieldMember rename.
4520 * decl.cs (MemberCache.FindBaseEvent): New method.
4522 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
4523 to reflect that indexer is now derived from PropertyBased.
4525 * ecore.cs (GetMemberType): Made public.
4526 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
4529 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
4531 * typemanager.cs (CSharpSignature): Correctly print event accessors.
4532 (RegisterEvent): Removed.
4533 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
4534 (GetPrivateFieldOfEvent): Renamed to GetEventField.
4536 2007-01-11 Raja R Harinath <rharinath@novell.com>
4539 * statement.cs (CollectionForeach.TryType): Prefer generic
4540 GetEnumerator over non-generic variant. Fix code to follow comments.
4542 2007-01-09 Raja R Harinath <rharinath@novell.com>
4545 * support.cs (ReflectionParameter): Don't use an invalid index on
4546 the generic parameter data.
4548 2007-01-08 Miguel de Icaza <miguel@novell.com>
4550 * driver.cs: Just add a tiny bit of infrastructure.
4552 2007-01-02 Marek Safar <marek.safar@gmail.com>
4554 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
4555 where field type is struct from current assembly.
4557 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
4560 2007-01-02 Marek Safar <marek.safar@gmail.com>
4562 A fix for bug #80381
4563 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
4566 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
4568 (Namespace.LookupType): Always use core types from corlib when speficied.
4570 * report.cs: A new warning.
4572 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
4573 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
4574 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
4576 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
4577 (InitCoreTypes): Set expression type of object_type and value_type
4578 immediately after lookup.
4580 2007-01-01 Miguel de Icaza <miguel@novell.com>
4582 * cs-tokenizer.cs: Accept Pc class characters (Connector
4583 Punctuation) as valid identifiers. Fixes #78259
4585 * expression.cs (Invocation.DoResolve): Moved the check for the
4586 use of `this' for doing method calls to the Invocation resolution
4587 step, after overload resolution has taken place instead of doing
4588 the check at the low-level `This.DoResolve' level.
4590 The `This.DoResolve'(appens before overload resolution, so it has
4591 no way of knowing if the method that will be called will be
4592 instace or static, triggering an erroneous report for cs0188 (Bug
4595 We now do the check for instance method invocations after we know
4596 what method will be called.
4598 (This.CheckThisUsage): Move the actual use of this structure
4599 checking into its own method and expose it.
4601 * Everywhere that called Error_ValueCannotBeConverted: pass a new
4604 Exceptions: Null.ConvertImplicitly,
4605 Constant.ImplicitConversionRequired as there are too many call
4606 sites for passing the ec.
4608 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
4609 EmitContext, if the value is null, then we do not try to provide
4610 the extra information from the error (If a userdefined conversion
4611 exists, as UserDefinedConversion requires a non null-EmitContext).
4615 2006-12-30 Raja R Harinath <rharinath@novell.com>
4617 * flowanalysis.cs (MyBitVector): Document some invariants.
4618 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
4619 introduced below, and add a couple of others,
4621 2006-12-30 Marek Safar <marek.safar@gmail.com>
4623 * attribute.cs (GetMethodObsoleteAttribute): Uses new
4624 GetPropertyFromAccessor and GetEventFromAccessor.
4626 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
4627 overrides non-obsolete one.
4628 (Indexer.Define): Error message has been moved to the parser.
4630 * cs-parser.jay: Better syntax errors handling.
4632 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
4633 when an invocation has no arguments.
4635 * ecore.cs: Removed not used caching.
4637 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
4640 * report.cs: Add a new warning.
4642 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
4644 * typemanager.cs (enumeration_type): Removed.
4645 (CSharpSignature): Reuses IsSpecialMethod.
4646 (IsEqual): Hack for MS BCL.
4647 (GetPropertyFromAccessor): New method.
4648 (GetEventFromAccessor): New method.
4649 (IsSpecialMethod): Fixed to handle more cases.
4651 2006-12-30 Marek Safar <marek.safar@gmail.com>
4653 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
4654 Made white spaces array static.
4656 * ecore.cs (RemoveGenericArity): Optimized.
4658 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
4660 (MyBitVector.initialize_vector): Simplified.
4662 2006-12-22 Miguel de Icaza <miguel@novell.com>
4664 * ecore.cs: Am not entirely happy with this hack, but it seems to
4665 address the issue in 80257 (a small test case for
4668 I set the MethodGroupExpr.Type to an internal compiler type
4669 (itself in this case) to force the resolution to take place. Why
4670 it does not take place with a null is beyond me.
4672 2006-12-20 Marek Safar <marek.safar@gmail.com>
4674 A fix for bug #80288
4675 * expression.cs (ResolveOperator): Consider user defined conversion for
4676 logical and operator too.
4677 (EmitBranchable): Optimization for logical and when full constant folding
4678 could not be applied but one operand is constant.
4680 2006-12-19 Marek Safar <marek.safar@gmail.com>
4682 * class.cs (GetClassBases): Write 5 times every day, will never use
4683 FullName for error reporting.
4685 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
4687 2006-12-19 Martin Baulig <martin@ximian.com>
4689 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
4690 the symbol file info here.
4692 2006-12-18 Marek Safar <marek.safar@gmail.com>
4694 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
4695 of `elseif' is taking then following sections are not taking.
4696 Fixes an issue reported on mono mailing list.
4698 2006-12-18 Marek Safar <marek.safar@gmail.com>
4700 A fix for bug #80300
4701 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
4702 a caller is not taking.
4704 2006-12-18 Raja R Harinath <rharinath@novell.com>
4706 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
4707 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
4708 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
4709 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
4710 * class.cs: Update to changes.
4712 2006-12-17 Marek Safar <marek.safar@gmail.com>
4714 A fix for bug #79934
4715 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
4718 * class.cs (ResolveMembers): Register an iterator in current container and
4721 2006-12-16 Raja R Harinath <rharinath@novell.com>
4724 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
4725 satisfy a params annotated parameter.
4727 2006-12-16 Marek Safar <marek.safar@gmail.com>
4729 A fix for bug #77014
4730 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
4731 paramters correctly and not rely on hacks in Parameters class.
4732 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
4734 (Invocation.VerifyArgumentsCompat): Ditto.
4735 (Invocation.EmitArguments): Changed to correctly emit params arguments at
4738 * parameter.cs (HasParams): Don't assume that params is the last one.
4740 * support.cs (ReflectionParameters.ctor): Look for params attribute
4742 (ReflectionParameters.ParameterType): Removed hack when we returned last
4743 parameter for out of range parameters.
4744 (ParameterName, ParameterModifier): Ditto.
4746 2006-12-14 Marek Safar <marek.safar@gmail.com>
4748 A fix for bug #79987
4749 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
4750 when assembly is not CLS compliant but type is. I have no idea why is this
4753 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
4755 2006-12-13 Miguel de Icaza <miguel@novell.com>
4757 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
4758 in struct constructors, they are basically no-ops.
4760 2006-12-12 Marek Safar <marek.safar@gmail.com>
4762 * cs-tokenizer.cs (Position): Save preprocessor status too.
4764 2006-12-12 Marek Safar <marek.safar@gmail.com>
4766 A fix for bug #77794
4767 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
4769 2006-12-12 Marek Safar <marek.safar@gmail.com>
4771 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
4773 (pp_expr): Report error for an invalid expression.
4774 (handle_preprocessing_directive): Simplified; add more error checking.
4776 2006-12-11 Marek Safar <marek.safar@gmail.com>
4778 A fix for bug #74939
4779 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
4780 directives handling.
4782 2006-12-10 Marek Safar <marek.safar@gmail.com>
4784 A fix for bugs #80093, and #75984
4785 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
4786 logic, it seems to me as it worked before "by coincidence".
4787 (xtoken): Simplified to use reworked handle_preprocessing_directive.
4788 (cleanup): Enabled endif check.
4790 2006-12-09 Marek Safar <marek.safar@gmail.com>
4792 A fix for bug #80162
4793 * statement.cs (CollectionForeach.TryType): Generics and non-generics
4794 enumerators are never ambiguous.
4796 2006-12-08 Raja R Harinath <rharinath@novell.com>
4799 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
4801 2006-12-06 Marek Safar <marek.safar@gmail.com>
4803 A fix for bug #80144
4804 * class.cs (EventProperty.Define): Explicit implementation means
4805 that an even is used.
4807 2006-12-06 Marek Safar <marek.safar@gmail.com>
4809 Fixes the operators implementation (part II)
4811 * cfold.cs (DoConstantNumericPromotions): Renamed to
4812 DoBinaryNumericPromotions and simplified.
4813 (BinaryFold): Couple of conversion fixes; simplified.
4815 * constant.cs, ecore.cs, literal.cs
4816 (ToType): Renamed to ConvertImplicitly.
4817 (Reduce): Renamed to ConvertExplicitly.
4819 * class.cs, convert.cs: Updated.
4821 * expression.cs: TryReduce doesn't throw an exception.
4823 2006-12-01 Marek Safar <marek.safar@gmail.com>
4825 A fix for bug #80108
4826 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
4829 2006-11-30 Marek Safar <marek.safar@gmail.com>
4831 Fixes unary operators implementation (part I)
4834 * cfold.cs (Error_CompileTimeOverflow): Made internal
4836 * const.cs (IConstant): Changed to use reference to constant and
4837 not constant itself.
4838 Updated IConstant implementations.
4840 * constant.cs (CreateConstant): New factory method.
4841 Updated IConstant implementation.
4843 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
4845 * ecore.cs: Updated to use CreateConstantReference.
4847 * enum.cs: Reflects IConstant changes.
4849 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
4851 * literal.cs (NullConstant): Change to be independently usable.
4853 2006-11-29 Martin Baulig <martin@ximian.com>
4855 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
4856 we need to emit the scope initializer before calling the base .ctor.
4858 * anonymous.cs: Merged back from the new anonymous methods branch.
4859 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
4861 * expression.cs (ParameterReference.DoResolveBase): Create a
4862 "normal" ScopeInfo when capturing parameters rather than using the
4863 root scope; this makes things work with anonymous methods having
4867 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
4869 2006-11-22 Marek Safar <marek.safar@gmail.com>
4871 A fix for bug #79987
4872 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
4873 check to a base class.
4874 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
4875 only when assembly has missing attribute.
4876 * report.cs: Update.
4878 2006-11-21 Marek Safar <marek.safar@gmail.com>
4880 * cs-tokenizer.cs: Merged with gmcs version.
4882 2006-11-20 Marek Safar <marek.safar@gmail.com>
4885 * cs-parser.jay: Better error message when partial keyword is misplaced.
4887 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
4889 A fix for bug #79810
4890 report.cs: CS1058 only applies to 2.0 profile (gmcs).
4891 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
4892 a RuntimeWrappedException by default.
4894 2006-11-18 Marek Safar <marek.safar@gmail.com>
4896 A fix for bug #79843
4897 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
4899 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
4901 2006-11-18 Marek Safar <marek.safar@gmail.com>
4903 * driver.cs, namespace.cs: Uses faster IndexOf version.
4905 2006-11-17 Marek Safar <marek.safar@gmail.com>
4907 A fix for bug #79941
4908 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
4910 (Operator.Define): Implicit/Explicit operator of same type is duplicate
4911 even if internal name is different.
4912 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
4913 (UserDefinedConversion): Simplified as the operators cannot be internal.
4914 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
4916 (MethodLookup): Replaced EmitContext with parentType.
4917 * expression.cs: Updated.
4919 2006-11-09 Raja R Harinath <rharinath@novell.com>
4921 * driver.cs (BadAssembly): Handle all the ugliness of
4922 DefineDynamicAssembly.
4924 2006-11-08 Raja R Harinath <rharinath@novell.com>
4926 Address parts of #58244 -- most of what's left is in the runtime
4927 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
4928 CS1509 error checks, and handle them for all assembly loads, not
4929 just the first invocation.
4930 (LoadModule): Likewise. Move handling of 'adder_method' ...
4931 * codegen.cs (AssemblyClass.AddModule): ... here.
4933 2006-11-02 Marek Safar <marek.safar@gmail.com>
4935 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
4936 IEnumerable<T> is ambiguous.
4938 2006-10-31 Marek Safar <marek.safar@gmail.com>
4940 A fix for bug #67689
4941 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
4942 GetEnumerator is ambiguous.
4944 * report.cs: Add new warning.
4946 2006-10-29 Marek Safar <marek.safar@gmail.com>
4948 A fix for bug #78602
4949 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4950 to protected member can be nested type.
4952 2006-10-28 Marek Safar <marek.safar@gmail.com>
4954 A fix for bug #78965
4955 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
4956 to protected member must derive from current type.
4958 2006-10-27 Marek Safar <marek.safar@gmail.com>
4960 assign.cs: Reuses error method.
4962 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
4963 instead of type for constants.
4964 (Expression.Error_ValueAssignment): Common error method.
4966 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
4969 2006-10-27 Marek Safar <marek.safar@gmail.com>
4971 A fix for bug #79081
4972 * expression.cs (MemberAccess.DoResolve): Check nested type
4975 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
4977 * doc.cs : nested delegates were not handled. Fixed bug #79754.
4979 2006-10-26 Marek Safar <marek.safar@gmail.com>
4981 A fix for bug #76591
4982 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
4984 2006-10-26 Marek Safar <marek.safar@gmail.com>
4986 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
4987 type forwarder of the same type multiple times.
4989 2006-10-26 Raja R Harinath <rharinath@novell.com>
4992 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
4993 instance as an rvalue, even when we later resolve as an lvalue.
4995 2006-10-25 Martin Baulig <martin@ximian.com>
4997 * anonymous.cs: Fix #79673.
4999 2006-10-24 Marek Safar <marek.safar@seznam.cz>
5001 A fix for bug #79666
5002 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
5003 ignored when is optimized (= default value) as its value is already set.
5005 2006-10-23 Marek Safar <marek.safar@seznam.cz>
5007 A fix for bug #79724
5008 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
5009 TypeContainer for type lookup.
5011 2006-10-23 Marek Safar <marek.safar@seznam.cz>
5013 A fix for bug #79231
5014 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
5015 * expression.cs (OverloadResolve): Always convert type name for
5017 (ResolveNamespaceOrType): Don't confuse a nested type with any
5020 2006-10-18 Martin Baulig <martin@ximian.com>
5022 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
5024 2006-10-17 Miguel de Icaza <miguel@novell.com>
5026 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
5027 an int32, but requesting an int64 from the conversion
5029 2006-10-12 Martin Baulig <martin@ximian.com>
5032 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
5034 2006-10-12 Martin Baulig <martin@ximian.com>
5037 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
5039 2006-10-11 Miguel de Icaza <miguel@novell.com>
5041 * convert.cs: Remove broken code: I was doing the "Existance"
5042 tests for Implicit conversions.
5044 2006-10-10 Miguel de Icaza <miguel@novell.com>
5046 * convert.cs: Added one missing case in
5047 ImplicitStandardConversionExists uint64 to intptr.
5051 * typemanager.cs (uintptr_type): another core known type.
5053 * ecore.cs (OperatorCast): routine used to do cast operations that
5054 depend on op_Explicit. We could change some of the Decimal
5055 conversions to use this.
5057 This one has a probe mechanism that checks both types for an op_
5058 which it coudl be used to eliminate two classes: CastToDecimal
5059 and CastFromDecimal.
5061 * convert.cs: Implement the conversions documented in #59800
5063 2006-10-10 Martin Baulig <martin@ximian.com>
5065 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
5066 before RootScope.ResolveMembers().
5068 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
5069 `CurrentType' if appropriate.
5071 2006-10-09 Marek Safar <marek.safar@seznam.cz>
5073 A fix for bug #78568
5074 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
5075 when contains binary operators.
5076 * cs-parser.jay: Updated.
5078 2006-10-09 Martin Baulig <martin@ximian.com>
5081 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
5082 moved that into Define() and also do the other type parameter
5083 checks there. Fixes #79094. Added gtest-292.cs.
5086 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
5087 since that doesn't include type parameters; don't use `Ldelema'
5088 for type parameters. Fixes #78980. Added gtest-293.cs.
5090 2006-10-08 Marek Safar <marek.safar@seznam.cz>
5093 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
5094 conversion is allowed.
5096 2006-10-06 Marek Safar <marek.safar@seznam.cz>
5098 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
5099 error reporting when no error occurs.
5101 2006-10-06 Marek Safar <marek.safar@seznam.cz>
5103 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
5106 2006-10-06 Raja R Harinath <rharinath@novell.com>
5109 * class.cs (DefineTypeBuilder): Check circular dependencies before
5110 setting the parent of the TypeBuilder.
5111 (CheckRecursiveDefinition): Don't use 'BaseType', since
5112 it may not be valid until after DefineTypeBuilder. Use
5113 'base_type' instead.
5115 2006-10-04 Martin Baulig <martin@ximian.com>
5117 Merged the Anonymous Methods patch.
5119 * anonymous.cs, iterators.cs: The new anonymous methods code.
5121 * statement.cs (Variable): New public abstract class.
5122 (LocalInfo.Variable): New public property.
5123 (LocalInfo.ResolveVariable): New public method.
5124 (Block.Flags): Add `IsIterator'.
5125 (Block.AddVariable): Improved the CS0136 check.
5126 (Block.AnonymousChildren): New public property.
5127 (Block.AddAnonymousChild): New public method.
5128 (ToplevelBlock): Update to use the new anonymous method framework.
5129 (ToplevelBlock.ctor): `container' is now a `Block' and not a
5130 `ToplevelBlock'; this is required to correctly implement the
5132 (Fixed, Using): Use `TemporaryVariable' instead of directly
5133 creating the `LocalBuilder'.
5135 * parameter.cs (Parameter.ResolveVariable): New public method.
5136 (Parameters.ResolveVariable): Likewise.
5138 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
5140 * class.cs (TypeContainer): Replaced the `iterators' list and
5141 corresponding methods with a list of `CompilerGeneratedClass'es.
5142 (TypeContainer.ResolveMembers): New public method.
5143 (Method): `IIteratorContainer' has been replaced by
5146 * expression.cs (VariableReference): New public abstract base
5147 class for `LocalVariableReference', `ParameterReference' and
5150 * codegen.cs (EmitContext): Removed `capture_context',
5151 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
5152 (EmitContext.EmitThis): Removed.
5154 * cs-parser.jay: Replace `iterator_container' with
5157 2006-10-04 Martin Baulig <martin@ximian.com>
5159 * generic.cs (GenericMethod): Don't make this abstract.
5160 (Constraints.Clone): Added dummy implementation.
5162 2006-10-04 Raja R Harinath <harinath@gmail.com>
5165 * namespace.cs (LookForAnyGenericType): Avoid nullref on
5166 'declspaces'. Avoid allocating arrays willy-nilly.
5169 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
5170 cases out of the switch.
5172 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5174 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
5175 message when non-generic type is used with the type arguments.
5176 * expression.cs: Updated.
5178 2006-09-28 Raja R Harinath <rharinath@novell.com>
5181 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
5182 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
5183 Change semantics slightly. Don't insist on having only one
5184 temporary EmptyExpression -- just throttle the creation of new ones.
5187 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
5188 non-interfaces too. If no methods are found, don't try to create
5191 2006-09-28 Marek Safar <marek.safar@seznam.cz>
5193 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
5196 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
5197 us produce better error message.
5199 2006-09-27 Marek Safar <marek.safar@seznam.cz>
5201 * expression.cs (Binary.ResolveOperator): Warn about a side effect
5202 of the `|' operator.
5204 * report.cs: A new warning added.
5206 2006-09-27 Martin Baulig <martin@ximian.com>
5208 * generic.cs (GenericMethod): Don't make this abstract.
5210 2006-09-27 Martin Baulig <martin@ximian.com>
5213 (InternalErrorException): Added overloaded ctor taking a params array.
5215 2006-09-26 Marek Safar <marek.safar@seznam.cz>
5217 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
5218 Fixed the cases when same error was reported twice.
5220 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
5221 now report symbol information.
5223 2006-09-25 Martin Baulig <martin@ximian.com>
5225 * class.cs: Completely unified with the gmcs version.
5227 2006-09-25 Martin Baulig <martin@ximian.com>
5229 * typemanager.cs (TypeManager.IsNullableType): New public function.
5230 (TypeManager.IsNullableTypeOf): Likewise.
5231 (TypeManager.IsNullableValueType): Likewise.
5233 * class.cs (MethodCore): Added the `GenericMethod' argument from
5234 gmcs and also unified all classes derived from `MethodCore' with gmcs.
5236 2006-09-24 Raja R Harinath <harinath@gmail.com>
5238 * convert.cs: Unify with gmcs version.
5240 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5242 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
5243 verify them as well.
5245 * report.cs: New warning.
5247 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5249 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
5250 for anonymous block with out argument.
5252 2006-09-24 Marek Safar <marek.safar@seznam.cz>
5254 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
5255 not used private events only.
5257 2006-09-23 Marek Safar <marek.safar@seznam.cz>
5259 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
5261 * const.cs (Const.Define): Check for constant type.
5262 (Const.IsConstantTypeValid): Looks for valid constant types.
5264 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
5266 * ecore.cs (EmptyConstantCast): New common class for all constant based
5269 * expression.cs (Is.DoResolve): Handle null constant especially.
5270 (New.DoResolve): Check for new void().
5271 (MemberAccess.DoResolve): Cope with all kind of nulls.
5273 * literal.cs (NullConstant): Uses EmptyConstantCast.
5274 (NullDefault): Based on EmptyConstantCast.
5275 (NullLiteral): Uses EmptyConstantCast.
5277 * statement.cs (Block.ResolveMeta): Check for constant type.
5279 2006-09-22 Martin Baulig <martin@ximian.com>
5281 * delegate.cs, attribute.cs: Merged with the gmcs versions.
5283 2006-09-22 Raja R Harinath <rharinath@novell.com>
5285 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
5289 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
5290 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
5293 2006-09-22 Martin Baulig <martin@ximian.com>
5295 * ecore.cs: Merged with the gmcs version.
5297 * generic.cs (ConstructedType): New dummy class.
5298 (TypeArguments): Don't make this abstract.
5301 (TypeManager.IsGenericTypeDefinition): New method.
5302 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
5304 2006-09-22 Raja R Harinath <rharinath@novell.com>
5306 * expression.cs (ComposedCast): Check for arrays of TypedReference
5307 before creating the type, not after.
5309 2006-09-21 Marek Safar <marek.safar@seznam.cz>
5311 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
5312 after ToType change.
5314 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
5315 when constant must be implicitly convertible.
5317 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
5319 * ecore.cs (NullCast): Derives from NullConstant.
5321 * expression.cs (Is.DoResolve): Removed useless variables.
5322 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
5323 (New.Constantify): Add enum support.
5324 (MemberAccess.DoResolve): Add warning when accessing null constant or
5327 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
5330 * literal.cs (NullConstant): New abstract class with common
5331 functionality for all null specializations.
5332 (NullDefault): Represents default(X) when result can be
5334 (NullLiteral): Updated.
5336 * report.cs: Add new warning.
5338 2006-09-21 Martin Baulig <martin@ximian.com>
5340 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
5342 2006-09-21 Martin Baulig <martin@ximian.com>
5344 * generic.cs (GenericConstraints): New dummy class.
5345 (Constraints): Likewise.
5346 (TypeParameter): Likewise.
5347 (TypeParameterName): Likewise.
5348 (GenericMethod): Likewise.
5350 * typemanager.cs (TypeManager.GetGenericArguments): New method.
5352 * decl.cs: Merged with the gmcs version.
5354 2006-09-21 Raja R Harinath <rharinath@novell.com>
5356 * generic.cs (TypeParameter): Implement IMemberContainer.
5357 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
5359 * rootcontext.cs: Unify with gmcs version.
5361 * report.cs: Unify with gmcs version.
5362 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
5363 from gmcs/generics.cs.
5364 * generics.cs (TypeParameter): New dummy class.
5366 * support.cs: Unify with gmcs version.
5368 2006-09-20 Raja R Harinath <rharinath@novell.com>
5370 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
5371 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
5373 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
5374 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
5375 * mcs.exe.sources: Add generic.cs.
5377 * codegen.cs: Unify with gmcs version.
5379 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
5380 (EmitContext): Add GenericDeclContainer implementation.
5381 * decl.cs (MemberCore, DeclSpace): Likewise.
5382 * namespace.cs: Remove #ifdef GMCS_SOURCE.
5384 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
5385 MCS TypeManager has a corresponding dummy method.
5387 2006-09-19 Martin Baulig <martin@ximian.com>
5389 * expression.cs: Completely merged with the gmcs version.
5391 2006-09-19 Martin Baulig <martin@ximian.com>
5393 * expression.cs (Invocation): Merged with the gmcs version.
5394 (ArrayAccess.GetStoreOpcode): Likewise.
5396 2006-09-19 Martin Baulig <martin@ximian.com>
5399 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
5400 (TypeManager.IsGenericMethodDefinition): Likewise.
5402 2006-09-19 Martin Baulig <martin@ximian.com>
5405 (TypeManager.IsEqual): Moved the gmcs implementation here.
5406 (TypeManager.DropGenericTypeArguments): Likewise.
5407 (TypeManager.DropGenericMethodArguments): Likewise.
5408 (TypeManager.GetTypeArguments): Moved here from gmcs.
5409 (TypeManager.HasGenericArguments): Likewise.
5411 2006-09-19 Martin Baulig <martin@ximian.com>
5413 * expression.cs (Binary): Merged with the gmcs version.
5415 2006-09-19 Martin Baulig <martin@ximian.com>
5417 * expression.cs (Probe, As, Is): Merged with the gmcs version.
5419 2006-09-19 Martin Baulig <martin@ximian.com>
5421 * typemanager.cs: Merged with the gmcs version.
5423 2006-09-16 Raja R Harinath <rharinath@novell.com>
5425 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
5426 * driver.cs: Likewise.
5428 2006-09-16 Marek Safar <marek.safar@seznam.cz>
5431 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
5432 only if parent type is class.
5433 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
5436 2006-09-15 Marek Safar <marek.safar@seznam.cz>
5439 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
5441 * typemanager.cs(CSharpName): Converts NullType to null.
5443 2006-09-15 Martin Baulig <martin@ximian.com>
5446 (TypeManager.GetMethodName): Added mcs implementation.
5447 (TypeManager.IsEqual): Likewise.
5450 (SimpleName.RemoveGenericArity): Added dummy implementation.
5452 * pending.cs: Merged with the gmcs version.
5454 2006-09-15 Martin Baulig <martin@ximian.com>
5456 * statement.cs: Merge with the gmcs version.
5458 2006-09-15 Martin Baulig <martin@ximian.com>
5460 * statement.cs (Switch): Merge with the gmcs implementation
5461 (without nullables), which is newer.
5463 2006-09-15 Martin Baulig <martin@ximian.com>
5465 * statement.cs (Block.Variables): Make this public.
5466 (ToplevelBlock.Parameters): Make this a property.
5467 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
5469 2006-09-15 Martin Baulig <martin@ximian.com>
5471 * namespace.cs: Merge with the gmcs version.
5473 2006-09-15 Martin Baulig <martin@ximian.com>
5475 * decl.cs (MemberName): Minor code cleanups.
5477 2006-09-15 Martin Baulig <martin@ximian.com>
5479 * parameter.cs: Merge with the gmcs version.
5481 2006-09-15 Martin Baulig <martin@ximian.com>
5483 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
5484 and an error in mcs.
5486 2006-09-15 Martin Baulig <martin@ximian.com>
5488 * flowanalysis.cs: Merged from GMCS; added the generics code into
5489 a `GMCS_SOURCE' conditional so we can share this file.
5491 2006-09-08 Martin Baulig <martin@ximian.com>
5493 * typemanager.cs (TypeManager.interlocked_type): New public field.
5494 (TypeManager.int_interlocked_compare-exchange): New public field.
5495 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
5496 enumerator types here and call InitGenericCoreTypes().
5497 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
5498 after calling InitEnumUnderlyingTypes().
5501 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
5502 `classes_second_stage'.
5504 2006-09-14 Marek Safar <marek.safar@seznam.cz>
5506 * assign.cs, ecore.cs, expression.cs: Share error message text.
5507 * class.cs (FieldMember.Define): Check for varible of static type.
5508 * driver.cs (LoadAssembly): Uses error output for errors.
5509 * statement.cs: Updated.
5511 2006-09-08 Marek Safar <marek.safar@seznam.cz>
5513 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
5516 2006-09-07 Martin Baulig <martin@ximian.com>
5519 (MainDriver): Revert r62663 from Marek; see #70506 for details.
5521 2006-08-29 Miguel de Icaza <miguel@novell.com>
5523 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
5525 2006-08-17 Miguel de Icaza <miguel@novell.com>
5527 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
5528 #52019 and #79064, the use of the \uXXXX sequence in source code
5529 to represent unicode characters.
5531 2006-08-15 Marek Safar <marek.safar@seznam.cz>
5533 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
5535 * class.cs, ecore.cs, statement.cs: Merged to one error message.
5537 2006-08-13 Miguel de Icaza <miguel@novell.com>
5539 * assign.cs: Catch attempts to assign to a method groups in += and
5542 2006-08-13 Marek Safar <marek.safar@seznam.cz>
5545 * cs-parser.jay: Don't destroy current array type by typeof of array's.
5547 2006-08-12 Marek Safar <marek.safar@seznam.cz>
5549 * class.cs (Method.Define): Issue a warning when generic method looks like
5551 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
5554 2006-08-09 Marek Safar <marek.safar@seznam.cz>
5556 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
5558 * decl.cs (MemberCache.FindMembers): When container is interface we need to
5559 search all base interfaces as a member can be ambiguous.
5560 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
5561 Constructor member type filter.
5562 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
5563 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
5564 reporting for returned memberinfos.
5565 * report.cs: Updated.
5566 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
5567 version to work on all runtimes.
5568 (TypeManager.RealMemberLookup): Removed members filtering.
5570 2006-08-08 Raja R Harinath <rharinath@novell.com>
5572 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
5573 (PropertyExpr.EmitAssign): Likewise.
5574 * expression.cs (Indirection.EmitAssign): Likewise.
5575 (LocalVariableReference.EmitAssign): Likewise.
5576 (ParameterReference.EmitAssign): Likewise.
5577 (Invocation.EmitArguments): Likewise.
5578 (ArrayAccess.EmitAssign): Likewise.
5579 (IndexerAccess.EmitAssign): Likewise.
5580 (This.EmitAssign): Likewise.
5581 (ConditionalLogicalOperator.Emit): Likewise.
5584 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
5585 instead of ArrayList. If the hashtable has a LocalBuilder, don't
5586 leave it in after returning it.
5587 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
5589 2006-08-06 Marek Safar <marek.safar@seznam.cz>
5591 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
5594 2006-08-03 Raja R Harinath <rharinath@novell.com>
5596 Fix cs0146-3.cs and cs0146-4.cs.
5597 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
5598 enclosing types don't depend on the current type.
5600 2006-08-02 Raja R Harinath <rharinath@novell.com>
5603 * class.cs (TypeContainer.DoDefineMembers): Use
5604 FindBaseMemberWithSameName on Parent, since we're interested in
5605 whether we hide inherited members or not.
5606 (FindBaseMemberWithSameName): Make slightly more robust.
5608 Fix the non-generic testcase from #77396
5609 * decl.cs (DeclSpace.DeclContainer): Remove override.
5611 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
5612 declspaces for doppelgangers too.
5613 (UsingEntry): Implement IResolveContext.
5614 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
5615 'this' as the resolve context.
5616 (LocalAliasEntry): Likewise.
5618 Implement parts of #77403
5619 * roottypes.cs (RootDeclSpace): New. Used to represent the
5620 toplevel declaration space. Each namespace declaration introduces
5621 a "partial" root declaretion space.
5622 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
5623 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
5624 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
5625 from 'current_namespace.SlaveDeclSpace'.
5626 (namespace_declaration): Likewise.
5627 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
5628 check. It can't happen now.
5629 * decl.cs (DeclSpace.LookupType): Likewise.
5630 * driver.cs (MainDriver): Sanity check.
5632 2006-08-01 Raja R Harinath <rharinath@novell.com>
5634 * decl.cs (DeclSpace.FindNestedType): Remove.
5635 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
5636 LookupTypeContainer to get the container of the nested type.
5637 * class.cs (TypeContainer.FindNestedType): Make non-override.
5639 2006-07-31 Raja R Harinath <rharinath@novell.com>
5641 * decl.cs (DeclSpace.PartialContainer): Move field from ...
5642 * class.cs (TypeContainer.PartialContainer): ... here.
5643 (TypeContainer.AddBasesForPart): New helper.
5644 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
5646 * cs-parser.jay (current_class): Convert to DeclSpace.
5647 (struct_declaration, interface_declaration, class_declaration):
5648 Use AddBasesForPart instead of .Bases directly.
5649 * const.cs, iterators.cs: Update to changes.
5651 2006-07-28 Raja R Harinath <rharinath@novell.com>
5653 * class.cs (TypeContainer.AddMemberType): Rename from
5655 (TypeContainer.AddMember): Rename from AddToMemberContainer.
5656 (AddTypeContainer): New. Combine AddClassOrStruct and
5658 (AddPartial): Update. Add 'is_partial' argument.
5659 * roottypes.cs: Update to changes.
5660 * cs-parser.jay (push_current_class): New helper for handling
5661 current_container and current_class.
5662 (struct_declaration, interface_declaration, class_declaration):
5665 2006-07-26 Raja R Harinath <rharinath@novell.com>
5667 * roottypes.cs: Rename from tree.cs.
5669 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
5670 * tree.cs (Tree, ITreeDump): Remove types.
5671 * rootcontext.cs (tree, Tree): Remove fields.
5672 (root, ToplevelTypes): New.
5673 * *.cs: Update to rename.
5675 * tree.cs (Tree.RecordDecl): Remove.
5676 (RootTypes.AddToTypeContainer): Record the toplevel type in its
5678 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
5680 2006-07-23 Raja R Harinath <harinath@gmail.com>
5682 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
5683 DoFlowAnalysis and OmitStructFlowAnalysis here.
5684 (ec.With): Rename from WithUnsafe and generalize.
5685 (ec.WithCheckState): Remove. All users can be handled by 'With'.
5686 (ec.WithFlowAnalyis): New.
5687 * ecore.cs, expression.cs, statement.cs: Update.
5689 2006-07-22 Raja R Harinath <harinath@gmail.com>
5691 * statement.cs (Block.ResolveMeta): Simplify slightly.
5693 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
5694 multiple boolean fields. Convert InUnsafe, constant_check_state,
5695 check_state to flags.
5696 (CheckState, ConstantCheckState): Update.
5697 (InUnsafe): New read-only property.
5698 (FlagsHandle): Rename from CheckStateHandle and convert to handle
5700 (WithUnsafe): New helper similar to WithCheckState.
5701 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
5702 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
5704 2006-07-21 Raja R Harinath <rharinath@novell.com>
5706 Make comparisons use the same IL irrespective of whether they're
5707 in a 'checked' or 'unchecked' context: one of the issues in #78899
5708 * codegen.cs (EmitContext.CheckState): Make read-only property.
5709 (EmitContext.ConstantCheckState): Likewise.
5710 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
5711 helper that implement a save/restore stack for CheckState
5712 values. This is the only way to change check-state.
5713 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
5714 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
5715 (CheckedExpr.EmitBranchable): New forwarding method.
5716 (UnCheckedExpr): Likewise.
5717 * statement.cs (Block.ResolveMeta): Use WithCheckState.
5718 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
5719 (Checked.Resolve, checked.DoEmit): Likewise.
5721 2006-07-20 Miguel de Icaza <miguel@novell.com>
5723 * anonymous.cs: Cache the resolved anonymous delegate, and return
5724 this so that the ResolveTopBlock is only triggered once, not
5727 Currently we trigger ResolvetopBlock twice due to a first pass of
5728 argument check compatibility, and a second pass that does the
5731 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5733 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
5735 * rootcontext.cs (Reset): Add helper_classes.
5737 2006-07-15 Marek Safar <marek.safar@seznam.cz>
5740 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
5743 2006-07-13 Miguel de Icaza <miguel@novell.com>
5745 * statement.cs (Lock): Handle expressions of type
5746 TypeManager.null_type specially. Fixes #78770
5748 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5750 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
5753 2006-07-08 Marek Safar <marek.safar@seznam.cz>
5755 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
5756 for accessors as well.
5757 * ecore.cs (EventExpr): Add AccessorTable.
5759 2006-07-01 Marek Safar <marek.safar@seznam.cz>
5762 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
5763 for CS0122 where appropriate.
5764 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
5766 (Filter): Assembly can be null in the case of top level attributes.
5768 2006-06-25 Marek Safar <marek.safar@seznam.cz>
5772 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
5773 is done at global level.
5775 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5777 A fix for #77002, Implemented TypeForwarder support.
5779 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
5780 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
5781 * typemanager.cs (): Add type_forwarder_attr_type.
5783 2006-06-24 Marek Safar <marek.safar@seznam.cz>
5785 * report.cs: Add CS0469 warning.
5787 2006-06-21 Martin Baulig <martin@ximian.com>
5789 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
5790 the `try'-block, so we also report CS0016 etc. there.
5792 2006-06-21 Martin Baulig <martin@ximian.com>
5795 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
5797 2006-06-21 Martin Baulig <martin@ximian.com>
5799 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
5800 also report CS1686 for parameters.
5802 2006-06-21 Martin Baulig <martin@ximian.com>
5804 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
5805 instead of an error if the value is not implicitly convertible to
5806 the switch types; fixes #77964.
5808 2006-06-21 Raja R Harinath <rharinath@novell.com>
5811 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
5812 FieldBuilder is null.
5815 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
5816 'left' and 'right' before error-checking.
5818 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
5820 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
5822 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
5823 (FieldExpr.DoResolve): likewise.
5824 (PropertyExpr.InstanceResolve): likewise.
5825 (EventExpr.InstanceResolve): likewise.
5827 2006-06-04 Marek Safar <marek.safar@seznam.cz>
5829 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
5830 attribute applicable tests for attribute argument.
5832 2006-06-02 Raja R Harinath <rharinath@novell.com>
5835 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
5836 (Binary.OverloadResolve_PredefinedIntegral): New.
5837 (Binary.OverloadResolve_PredefinedFloating): New.
5838 (Binary.OverloadResolve_PredefinedString): New.
5839 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
5840 Follow the standard more closely, and treat numeric promotions in
5841 terms of overload resolution.
5842 (Binary.CheckShiftArguments): Simplify.
5844 2006-06-01 Raja R Harinath <rharinath@novell.com>
5846 * flowanalysis.cs (MyBitVector): Simplify representation.
5847 (MyBitVector.Clone): Avoid allocating BitArray.
5848 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
5849 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
5850 (*): Update. Change all references to MyBitVector.And and
5851 MyBitVector.Or to &= and |=.
5853 2006-05-29 Raja R Harinath <rharinath@novell.com>
5856 * cs-parser.jay (formal_parameter_list): Extend the pattern below
5857 to param arguments too.
5859 2006-05-26 Miguel de Icaza <miguel@novell.com>
5861 * cs-parser.jay: Catch another parsing form for arglist being
5862 followed by other arguments. Fixes #78313.
5864 2006-05-24 Raja R Harinath <rharinath@novell.com>
5866 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
5867 checking of out parameters to ...
5868 (FlowBranchingToplevel.Merge): ... here.
5869 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
5870 set, propagate the origin upward, and only complain if there was
5872 (FlowBranchingException.AddContinueOrigin): Likewise.
5873 (FlowBranchingException.AddReturnOrigin): Likewise.
5874 (FlowBranchingException.AddGotoOrigin): Likewise.
5876 2006-05-23 Raja R Harinath <rharinath@novell.com>
5878 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
5879 unreachable, skip it.
5880 (FlowBranchingException.Merge): Always propagate jumps, even if
5881 the finally block renders subsequent code unreachable.
5883 2006-05-18 Raja R Harinath <rharinath@novell.com>
5886 * statement.cs (Goto.Resolve): Move responsibility for resolving
5887 'goto' to FlowBranching.AddGotoOrigin.
5888 (Goto.SetResolvedTarget): New. Callback to set the
5889 LabeledStatement that's the target of the goto.
5890 (Goto.DoEmit): Use Leave instead of Br when crossing an
5891 unwind-protect boundary.
5892 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
5893 LookupLabel and adjust to new semantics.
5894 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
5895 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
5896 Goto.SetResolvedTarget to update target.
5897 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
5898 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
5899 AddBreakOrigin & co. Delay propagation until ...
5900 (FlowBranchingException.Merge): ... this.
5902 * statement.cs (Block.Resolve): Always depend on flow-branching to
5903 determine unreachability. Kill workaround that originally emitted
5904 only one statement after an "unreachable" label (see infloop in
5907 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
5908 This is still "wrong", but anything better would probably need a
5909 multi-pass algorithm.
5910 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
5911 usage vector. Force current usage vector to be reachable, to
5912 optimistically signify backward jumps.
5913 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
5915 (FlowBranchingLabeled.Merge): New. If no backward jump was
5916 detected, return the original salted-away usage vector instead,
5917 updated with appropriate changes. Print unreachable warning if
5919 * statement.cs (Block.Resolve): Don't print unreachable warning on
5920 a labeled statement.
5922 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
5924 * driver.cs: Pass filename without path to AssemblyBuilder's
5925 AddResourceFile. Fixes bug #78407.
5927 2006-05-17 Raja R Harinath <rharinath@novell.com>
5929 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
5930 * flowanalysis.cs (FlowBranchingLabeled): ... here.
5931 (FlowBranching.MergeChild): Overwrite
5932 reachability information from Labeled branchings too.
5934 2006-05-16 Raja R Harinath <rharinath@novell.com>
5936 * statement.cs (Goto.Resolve): Merge jump origins here ...
5937 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
5939 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
5940 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
5941 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
5942 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
5944 * statement.cs (Goto.Resolve): ... not here.
5945 (Goto.Emit): Remove CS1632 check.
5947 2006-05-14 Marek Safar <marek.safar@seznam.cz>
5949 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
5952 2006-05-11 Raja R Harinath <rharinath@novell.com>
5954 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
5955 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
5956 (FlowBranchingException.Label): Likewise.
5958 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
5960 (MyBitVector.Or): Use it to avoid losing information (Count).
5961 (FlowBranching.MergeOrigins): Likewise.
5963 * flowanalysis.cs (UsageVector.IsDirty): Remove.
5964 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
5965 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
5966 (UsageVector.ToString): Simplify.
5967 (UsageVector.MergeSiblings): Move here from ...
5968 (FlowBranching.Merge): ... here.
5969 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
5972 2006-05-10 Raja R Harinath <rharinath@novell.com>
5974 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
5975 null bitvector is treated as all-true.
5977 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
5978 (MyBitVector): Rationalize invariants. 'vector != null' implies
5979 that we have our own copy of the bitvector. Otherwise,
5980 'InheritsFrom == null' implies all inherited bits are true.
5982 2006-05-09 Marek Safar <marek.safar@seznam.cz>
5984 * statement.cs (LocalInfo): Add IsConstant.
5985 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
5986 local variable for constants.
5988 2006-05-09 Raja R Harinath <rharinath@novell.com>
5990 * flowanalysis.cs (MyBitVector.Empty): New.
5991 (MyBitVector): Don't allow InheritedFrom to be null.
5992 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
5993 (UsageVector, FlowBranching): Update to changes.
5995 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
5996 recursion. The 'Parent == null' condition isn't sufficient for
5998 (FlowBranching.AddBreakOrigin): Likewise.
5999 (FlowBranching.AddContinueOrigin): Likewise.
6000 (FlowBranching.AddReturnOrigin): Likewise.
6001 (FlowBranching.StealFinallyClauses): Likewise.
6002 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
6003 (FlowBranching.CheckOutParameters): Likewise.
6004 (FlowBranchingToplevel): Terminate all the above recursions here.
6005 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
6006 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
6008 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
6010 (FlowBranchingToplevel): New. Empty for now.
6011 (FlowBranching.MergeTopBlock): Update.
6012 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
6013 branching for the anonymous delegate.
6014 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
6016 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
6017 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
6018 information at the start of the merge. Reorganize.
6020 2006-05-07 Marek Safar <marek.safar@seznam.cz>
6022 * class.cs (MethodData.Define): Method cannot implement interface accessor.
6024 2006-05-07 Marek Safar <marek.safar@seznam.cz>
6026 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
6027 to newly introduced ctor.
6029 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
6030 message to one place.
6031 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
6034 2006-05-07 Marek Safar <marek.safar@seznam.cz>
6036 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
6038 * ecore.cs (Expression.ResolveAsConstant): Updated.
6040 * statement.cs (ResolveMeta): Updated.
6042 2006-05-06 Marek Safar <marek.safar@seznam.cz>
6044 * cs-parser.jay: __arglist cannot be used in initializer.
6046 2006-05-06 Marek Safar <marek.safar@seznam.cz>
6049 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
6052 2006-05-05 Raja R Harinath <rharinath@novell.com>
6054 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
6055 (LabeledStatement): Add 'name' parameter.
6056 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
6057 (Block.AddLabel): Update to changes.
6058 * cs-parser.jay (labeled_statement): Likewise.
6060 * flowanalysis.cs (BranchingType.Labeled): New.
6061 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
6062 (FlowBranchingLabeled): New. Does nothing for now, but will
6063 eventually handle 'goto' flows.
6064 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
6065 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
6066 that's terminated ...
6067 (Block.Resolve): ... here.
6069 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
6070 (UsageVector.MergeFinallyOrigins): Likewise.
6071 (FlowBranching.InTryOrCatch): Likewise.
6072 (FlowBranching.AddFinallyVector): Likewise.
6073 (FlowBranchingException): Update to changes.
6076 * statement.cs (Return.Resolve): Move error checking to ...
6077 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
6078 (FlowBranchingException): Handle return origins like break and
6080 (FlowBranching.UsageVector.CheckOutParameters): Remove.
6082 2006-05-04 Marek Safar <marek.safar@seznam.cz>
6085 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
6088 2006-05-04 Marek Safar <marek.safar@seznam.cz>
6091 * class.cs (MethodData.Define): Do public accessor check only when method
6092 implements an interface.
6094 2006-05-04 Raja R Harinath <rharinath@novell.com>
6096 Remove special handling of 'break'
6097 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
6098 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
6099 (UsageVector.Break): Remove.
6100 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
6102 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
6104 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
6105 UsageVector.Breaks (). Don't set NeedsReturnLabel.
6107 2006-05-03 Marek Safar <marek.safar@seznam.cz>
6110 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
6111 be the interface member.
6113 2006-05-03 Marek Safar <marek.safar@seznam.cz>
6116 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
6117 for emitting small (int) values.
6119 2006-05-03 Raja R Harinath <rharinath@novell.com>
6122 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
6123 control-flow passes through the 'finally' after merging-in all the
6124 control-flows from 'try' and the 'catch' clauses.
6126 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
6127 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
6128 always true at the only non-recursive entry point.
6129 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
6130 FlowBranchingBreakable.
6131 (FlowBranchingLoop): Remove.
6132 * statement.cs (Return.DoResolve): Update to changes.
6135 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
6136 (FlowBranching.CreateBranching): Handle it: create a
6137 FlowBranchingContinuable.
6138 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
6139 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
6140 except that it handles the 'continue' command.
6141 (FlowBranching.UsageVector.MergeOrigins): Rename from
6143 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
6144 except that it overrides AddContinueOrigin.
6145 (FlowBranchingException): Override AddContinueOrigin, similar to
6147 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
6148 Create a new branching around the embedded statement.
6149 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
6150 control flow after the embedded statement.
6151 (Continue.Resolve): Move all error checking to AddContinueOrigin.
6153 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
6154 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
6155 FlowBranchingBreakable.
6156 (FlowBranchingSwitch): Remove.
6159 * statement.cs (Break.Resolve): Simplify. Move responsibility for
6160 error reporting to ...
6161 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
6162 Rename from 'AddBreakVector'. Add new location argument. Return
6163 a bool indicating whether the 'break' crosses an unwind-protect.
6164 (FlowBranchingException.AddBreakOrigin): Add.
6165 (FlowBranchingException.Merge): Propagate 'break's to surrounding
6166 flowbranching after updating with the effects of the 'finally'
6168 (FlowBranchingBreakable): New common base class for
6169 FlowBranchingLoop and FlowBranchingSwitch.
6171 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
6173 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
6175 2006-05-02 Raja R Harinath <rharinath@novell.com>
6177 * statement.cs (Do.Resolve): If the loop is infinite, set the
6179 (While.Resolve, For.Resolve): Set a barrier after the embedded
6180 statement. There's no direct control flow that goes from the end
6181 of the embedded statement to the end of the loop.
6182 * flowanalysis.cs (FlowBranching.Infinite): Remove.
6183 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
6184 above ensure that the reachability is correctly computed.
6186 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
6187 (UsageVector.MergeBreakOrigins): If the current path is
6188 unreachable, treat it as if all parameters/locals are initialized.
6189 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
6190 infinite loops before merging-in break origins.
6192 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
6193 (Reachability.Reachable): Split part into ...
6194 (Reachability.Unreachable): ... this. Simplify.
6195 (Reachability.IsUnreachable): Use 'Unreachable' instead.
6197 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
6198 (Reachability.SetThrowsSometimes): Likewise.
6199 (FlowBranchingBlock.MergeTopBlock): Don't compare against
6200 TriState.Always, use corresponding property.
6201 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
6202 (Block.Resolve): Likewise. Remove some redundant checks.
6204 2006-05-02 Raja R Harinath <harinath@gmail.com>
6206 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
6207 (Reachability.Meet): Don't bother checking AlwaysThrows --
6208 barrier is always set.
6209 (FlowBranchingBlock.Merge): Likewise.
6211 2006-05-01 Raja R Harinath <harinath@gmail.com>
6213 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
6214 checks for unreachable.
6216 2006-05-01 Marek Safar <marek.safar@seznam.cz>
6219 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
6221 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
6222 whether field is really assigned.
6224 2006-04-30 Raja R Harinath <harinath@gmail.com>
6226 * flowanalysis.cs (Reachability): Make 4-argument constructor
6228 (Reachability.Meet): Rename from 'And'. Remove static variant.
6229 (Reachability.Always): Rename from the highly misleading
6230 'Reachability.Never'.
6231 (FlowBranching.Merge): Update to changes. Mark an impossible
6232 situation with a 'throw'.
6233 (*): Update to changes.
6235 2006-04-29 Raja R Harinath <harinath@gmail.com>
6237 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
6239 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
6240 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
6241 (*): Update to changes.
6242 * statement.cs: Update to changes.
6244 2006-04-28 Marek Safar <marek.safar@seznam.cz>
6247 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
6249 2006-04-28 Raja R Harinath <harinath@gmail.com>
6251 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
6254 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
6255 argument to two arguments: an usage-vector and a bool. Move call
6256 to FlowBranching.Merge () ...
6257 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
6259 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
6260 handling of loop and switch reachability to ...
6261 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
6263 2006-04-27 Raja R Harinath <harinath@gmail.com>
6265 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
6266 handling to FlowBranchingLoop.InLoop.
6267 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
6269 2006-04-26 Marek Safar <marek.safar@seznam.cz>
6272 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
6273 anonymous method is allowed from AnonymousContainer here.
6275 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
6277 2006-04-24 Raja R Harinath <rharinath@novell.com>
6280 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
6282 2006-04-23 Marek Safar <marek.safar@seznam.cz>
6285 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
6286 (DoubleConstant.Reduce): Ditto.
6288 2006-04-23 Raja R Harinath <rharinath@novell.com>
6290 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
6291 Remove 'lvalue_right_side' argument. Move parts to ...
6292 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
6293 (LocalVariable.DoResolveLValue): ... these.
6295 2006-04-21 Raja R Harinath <rharinath@novell.com>
6298 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
6299 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
6300 (LocalVariableReference.DoResolveBase): Use it to implement new
6302 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
6303 (Argument.Resolve): Simplify. Move CS1510 check ...
6304 * ecore.cs (Expression.ResolveLValue): ... here.
6305 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
6306 (PropertyExpr.DoResolveLValue): Likewise.
6307 (FieldExpr.Report_AssignToReadonly): Likewise.
6308 (FieldExpr.DoResolve): Add 'out_access' argument. Use
6309 LValueMemberAccess or LValueMemberOutAccess on instance depending
6311 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
6312 DoResolve as appropriate.
6314 2006-04-20 Raja R Harinath <rharinath@novell.com>
6317 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
6318 implicit conversions on 'out' and 'ref' arguments.
6320 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
6321 improve clarity. Remove dead code.
6324 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
6325 (Catch.Resolve): Resolve VarBlock if it exists.
6327 2006-04-19 Miguel de Icaza <miguel@novell.com>
6329 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
6330 twice, this was some residual code, the enumerator was emitted
6331 properly in the two branche of if later.
6333 2006-04-19 Raja R Harinath <rharinath@novell.com>
6335 * expression.cs (Cast.ResolveLValue): Remove. The result of a
6336 cast is never an lvalue.
6337 (Cast.DoResolve, Cast.ResolveRest): Combine.
6338 (Argument.Emit): Simplify slightly. Move 'Expr is
6339 IMemoryLocation' check ...
6340 (Argument.Resolve): ... here.
6341 (Argument.Error_LValueRequired): Remove. Inline into only user.
6343 Simplifications. Fix cs0191-2.cs
6344 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
6345 CS1649 and CS1651 to ...
6346 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
6347 the actual selection of the error code and message to a lookup
6348 table. Add a dummy return value to simplify callsites.
6349 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
6350 readonly fields of other instances of the same type. Move CS0197
6352 * expression.cs (Argument.Resolve): ... here. Simplify code.
6353 Ensure that ec.InRefOutArgumentResolving is only set during LValue
6354 resolution of an out or ref argument. The code simplification
6355 above uses this invariant.
6357 2006-04-18 Raja R Harinath <rharinath@novell.com>
6359 Possibly fix #77752. Fix cs1690-[4-7].cs.
6360 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
6361 CheckMarshallByRefAccess. Drop parameter.
6362 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
6364 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
6366 * report.cs (AllWarnings): Add CS1690.
6367 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
6369 (LocalVariableReference.DoResolveBase): Update.
6371 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6373 * class.cs (MethodOrOperator): Moved common parts from method class.
6374 detect obsolete attributes.
6375 (Method.Define): Simplified as it reuses code from base.
6376 (Constructor.ValidAttributeTargets): Fixed issue found during
6378 (Destructor.ValidAttributeTargets): Fixed issue found during
6380 (Operator): Finished refactoring set off by #78020. Operator class is now
6381 ordinary method class.
6383 * anonymous.cs: Updated.
6385 * decl.cs (DeclSpace): Add IsGeneric
6387 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6389 * class.cs (Constructor.Emit): Don't emit the attributes twice.
6391 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6393 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
6394 detect obsolete attributes.
6395 (Method.CreateEmitContext): Moved to MethodOrOperator.
6397 2006-04-09 Marek Safar <marek.safar@seznam.cz>
6400 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
6401 customized exception to make crash detection easier.
6402 (MethodOrOperator): Started to work on new base class for methods and
6404 (Method): Derives from MethodOrOperator.
6405 (Constructor.Emit): Emits its own attributes.
6406 (AbstractPropertyEventMethod.Emit): Ditto.
6407 (Operator): Derives from MethodOrOperator, will refactor fully in extra
6409 (Operator.Emit): It's temporary more tricky than should be.
6411 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
6413 * report.cs (InternalErrorException): Add ctor with inner exception.
6415 2006-04-08 Marek Safar <marek.safar@seznam.cz>
6418 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
6421 2006-04-07 Marek Safar <marek.safar@seznam.cz>
6424 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
6427 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6429 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
6430 attribute is present and Guid not.
6431 (Interface.ApplyAttributeBuilder): Ditto.
6433 * attribute.cs: Add error message.
6435 2006-04-06 Marek Safar <marek.safar@seznam.cz>
6439 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
6440 sources (it's composite) so hold them in extra array as they are used in
6441 Emit phase only. It worked in the previous versions by mistake.
6442 (Attribute.Emit): Emit attribute for more owners when exist.
6444 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
6445 it has now different behaviour.
6447 2006-04-04 Marek Safar <marek.safar@seznam.cz>
6449 * constant.cs (Constant.IsDefaultInitializer): New method.
6451 * class.cs: Updated.
6453 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
6454 re-initialize default values. It saves KBs almost for every assembly.
6455 Thanks Zoltan for the idea.
6456 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
6457 (ArrayCreation.DoResolve): Resolve only once.
6458 (ArrayCreation.Emit): Emit static initializer only when it is faster.
6459 (ArrayCreation.GetAttributableValue): Cope with optimized values.
6461 2006-04-03 Zoltan Varga <vargaz@gmail.com>
6463 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
6466 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6468 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
6469 in an embedded statement too.
6471 2006-04-01 Raja R Harinath <rharinath@novell.com>
6474 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
6476 2006-04-01 Marek Safar <marek.safar@seznam.cz>
6480 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
6483 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
6485 2006-03-31 Marek Safar <marek.safar@seznam.cz>
6487 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
6490 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
6491 LocalTemporary change.
6493 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
6495 (ClassOrStruct.DefineFieldInitializers): Implemented static field
6496 initializers optimization.
6497 (ClassOrStruct.TypeAttr): Moved from modifiers.
6498 (Constructor.CheckBase): Don't crash when static ctor has parameters.
6499 (FieldBase.ResolveInitializer): Resolves initializer.
6500 (FieldBase.HasDefaultInitializer): New property.
6502 * cs-parser.jay: Removed message.
6504 * expression.cs (CompilerGeneratedThis): New specialization.
6506 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
6508 2006-03-28 Marek Safar <marek.safar@seznam.cz>
6510 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
6512 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6514 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
6515 be now EnumConstants only.
6517 2006-03-27 Marek Safar <marek.safar@seznam.cz>
6519 * attribute.cs, driver.cs: Reset more caches.
6521 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6523 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
6525 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6527 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
6528 for easier reuse. Updated all overrides.
6529 (IntegralConstant): New base class for all integral constants.
6530 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
6531 of the constant range, report custom error.
6532 (UIntConstant.Reduce): Fixed uint conversion.
6534 * ecore.cs, literal.cs: Reduce updates.
6536 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6540 * class.cs (Constructor.Define): Removed extra if for default ctors.
6541 A patch from Atsushi Enomoto.
6543 2006-03-26 Marek Safar <marek.safar@seznam.cz>
6545 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
6546 GetAttributableValue.
6548 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
6551 * convert.cs (ImplicitConversionRequired): Error message moved to
6554 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
6555 automatic implicit conversion of an output value.
6556 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
6558 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
6560 (TypeOf.GetAttributableValue): Add extra handling for object type.
6562 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
6563 special error message.
6565 2006-03-25 Marek Safar <marek.safar@seznam.cz>
6567 * class.cs (Constructor.Emit): Don't crash when struct ctor is
6569 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
6570 compatible with MS runtime.
6572 2006-03-23 Marek Safar <marek.safar@seznam.cz>
6574 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
6575 attribute arguments here.
6577 * class.cs (Indexer.Define): The check was moved to attribute class.
6579 2006-03-22 Marek Safar <marek.safar@seznam.cz>
6581 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
6582 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
6585 2006-03-22 Raja R Harinath <rharinath@novell.com>
6587 Support ParameterDefaultValueAttribute in gmcs. Also applied to
6588 mcs to keep code differences small.
6589 * attribute.cs (Attribute.GetParameterDefaultValue): New.
6590 * typemanager.cs (parameter_default_value_attribute_type): New.
6591 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
6594 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6596 * expression.cs (StringConcat.Append): Reverted back to no warning state.
6598 2006-03-21 Marek Safar <marek.safar@seznam.cz>
6600 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
6602 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
6605 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
6607 * doc-bootstrap.cs : fix build.
6609 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6611 * expression.cs (StringConcat.Append): Issue a warning when empty string
6614 2006-03-20 Marek Safar <marek.safar@seznam.cz>
6616 * assign.cs (CompoundAssign.ResolveSource): Removed.
6618 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
6621 * class.cs (TypeContainer.FindMethods): Removed.
6622 (TypeContainer.CheckMemberUsage): Made static.
6624 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
6626 * constant.cs (CheckRange): Removed unused type argument.
6627 (CheckUnsigned): Removed unused type argument.
6629 * cs-parser.jay: Updated after MemberAccess clean up.
6630 Uses Length for empty string test.
6632 * cs-tokenizer.cs: Uses Length for empty string test.
6633 (IsCastToken): Made static.
6634 (is_hex): Made static.
6635 (real_type_suffix): Made static.
6637 * decl.cs (SetupCache): Made static.
6638 (OnGenerateDocComment): Removed unused ds argument.
6640 * delegate.cs (VerifyDelegate): Removed unused argument.
6642 * doc.cs: Uses Length for empty string test.
6644 * driver.cs: Uses Length for empty string test.
6646 * enum.cs (IsValidEnumType): Made static
6648 * expression.cs (EnumLiftUp): Removed unused argument.
6649 (ResolveMethodGroup): Ditto.
6650 (BetterConversion): Ditto.
6651 (GetVarargsTypes): Ditto.
6652 (UpdateIndices): Ditto.
6653 (ValidateInitializers): Ditto.
6654 (MemberAccess.ctor): Ditto.
6655 (GetIndexersForType): Ditto.
6657 * flowanalysis.cs: (MergeFinally): Removed unused argument.
6659 * iterators.cs: Updated after MemberAccess clean up.
6661 * location.cs: Uses Length for empty string test.
6663 * namespace.cs: Uses Length for empty string test.
6665 * report.cs (CheckWarningCode): Made static.
6667 * statement.cs (LabeledStatement): Removed unused argument.
6669 * typemanager.cs (FilterNone): Removed.
6671 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6673 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
6676 * class.cs: Updated.
6678 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6680 * cs-parser.jay.cs: __arglist is not allowed for delegates.
6682 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6686 * expression.cs (VerifyArgumentsCompat): Reverted to double error
6687 reporting, it's more tricky than I thought.
6689 2006-03-18 Marek Safar <marek.safar@seznam.cz>
6693 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
6695 (AnonymousMethod.ImplicitStandardConversionExists): New method.
6696 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
6697 Add more error reporting; Fixed issue with params.
6699 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
6701 * cs-parser.jay: AnonymousMethod requires host container.
6703 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
6705 2006-03-18 Raja R Harinath <harinath@gmail.com>
6707 * class.cs: Change 'TypeContainer ds' constructor argument to
6708 'DeclSpace parent'. Some classes were missed below due to
6709 different naming convention.
6711 * class.cs (MemberCore.Parent): Delete. This makes the
6712 ParentContainer changes below enforceable by the compiler.
6714 Treat pointers to enclosing declaration space as 'DeclSpace', not
6716 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
6717 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
6719 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
6721 (Block.AddThisVariable): Likewise.
6722 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
6723 (AbstractPropertyEventMethod.Emit): Likewise.
6724 (AbstractPropertyEventMethod.EmitMethod): Likewise.
6725 (GetMethod.Define, SetMethod.Define): Likewise.
6726 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
6727 (DelegateMethod.EmitMethod): Likewise.
6729 Fix regression test-partial-13.cs.
6730 Rationalize use of PartialContainer. Ensure that the partial
6731 class semantics can be tied to type-correctness, i.e., any
6732 violation will cause a compile error.
6733 * class.cs, const.cs: Access all fields that belong to class
6734 TypeContainer via ParentContainer. Arguments of EmitContexts and
6735 Resolve()-like functions still use 'Parent'.
6737 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
6738 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
6739 (PropertyMethod.CheckModifiers): Remove unused argument.
6740 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
6743 2006-03-17 Raja R Harinath <harinath@gmail.com>
6745 Make semantics of PartialContainer simpler.
6746 * decl.cs (DeclSpace.IsPartial): Remove.
6747 * class.cs (TypeContainer.IsPartial): Likewise.
6748 (TypeContainer..ctor): Set PartialContainer to point to self.
6749 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
6750 (TypeContainer.FindNestedType): Likewise.
6751 (MemberCore.ParentContainer): Simplify. Remove deprecation.
6753 2006-03-17 Marek Safar <marek.safar@seznam.cz>
6755 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
6757 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6759 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
6762 2006-03-15 Marek Safar <marek.safar@seznam.cz>
6764 * class.cs (Operator.Define): An error for base conversion was not
6767 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
6769 * iterator.cs : yield break is allowed in try statement which has
6770 catch clauses. Fixed bug #77767.
6772 2006-03-13 Marek Safar <marek.safar@seznam.cz>
6774 A fix for #77593, #77574.
6776 * class.cs (MethodCore.CheckBase): Another if for operator.
6778 2006-03-09 Marek Safar <marek.safar@seznam.cz>
6780 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
6783 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
6784 (DelegateCreation.ImplicitStandardConversionExists): New method for just
6787 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
6790 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
6791 Updated after another emitcontext usage was clean up. It should help us to
6792 synchronize with gmcs easier.
6794 2006-03-04 Marek Safar <marek.safar@seznam.cz>
6798 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
6799 (Event.Define): ditto
6800 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
6802 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
6803 Removed redundant code and set NewSlot for Invoke method too.
6805 * parameter.cs (Parameters.ctor): Add custom, type ctor.
6806 (Parameters.MergeGenerated): New method. Use this method when you merge
6807 compiler generated argument with user arguments.
6809 2006-03-03 Marek Safar <marek.safar@seznam.cz>
6811 * attribute.cs (ResolveAsTypeTerminal): Removed.
6813 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
6814 specialization for predefined types; 30% speed up.
6815 Finally placed obsolete check to right place.
6816 (Expression.ResolveType): Removed.
6818 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
6819 Updated after ResolveType was removed.
6821 * expression.cs (Cast.ctor): Check void cast.
6822 (Binary.ResolveAsTypeTerminal): Is never type.
6823 (Conditional.ResolveAsTypeTerminal): Is never type.
6825 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
6827 2006-03-01 Raja R Harinath <rharinath@novell.com>
6830 * expression.cs (ParameterReference.DoResolveBase): Change return
6832 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
6836 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
6839 * typemanager.cs (GetFullNameSignature): Don't nullref on
6840 protected accessors.
6842 2006-02-27 Marek Safar <marek.safar@seznam.cz>
6844 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
6845 these two separated members to simplify the code.
6846 (Attribute.Resolve): Refactored to use new fields and methods.
6847 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
6848 implemented obsolete attribute checking.
6849 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
6850 implemented obsolete checking again. It look line never ending quest ;-)
6851 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
6853 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
6855 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
6857 *class.cs (Property.Define): Add RegisterProperty call.
6859 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
6860 argument groups (only 2).
6862 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
6863 encoding expression to arguments.
6864 (Expression.ExprClassToResolveFlags): Just turned to property.
6866 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
6867 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
6868 optimized as well as implemented support for zero-length attributes.
6870 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
6871 Add caching of PropertyInfo's.
6873 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6875 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
6876 error multiple times.
6878 2006-02-25 Marek Safar <marek.safar@seznam.cz>
6880 New partial class implementation.
6881 A fix for #77027, #77029, #77403
6883 * attribute.cs (Attributable): Made attributes protected.
6885 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
6886 the replacements of ClassPart and PartialContainer.
6887 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
6888 (TypeContainer.AddInterface): Ditto.
6889 (TypeContainer.AddPartial): The main method for partial classes. It checks
6890 for errors and merges ModFlags and attributes. At the end class is added to
6892 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
6894 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
6895 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
6896 from the rest of partial classes.
6897 (TypeContainer.GetClassBases): Simplified.
6898 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
6900 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
6901 (TypeContainer.HasExplicitLayout): Uses Flags now.
6902 (PartialContainer): Removed.
6903 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
6904 (StaticClass): Was merged with Class.
6905 (Class.GetClassBases): class and static class bases are verified here.
6906 (Class.TypeAttr): Added static attributes when class is static.
6907 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
6908 (MemberBase): In some cases we need to call parent container for partial
6909 class. It should be eliminated but it's not easy now.
6911 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
6913 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
6914 partial classed to accumulate class comments.
6915 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
6917 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
6919 * driver.cs (MainDriver): Tree.GetDecl was removed.
6921 * modifiers.cs (Modifiers): Add partial modifier.
6923 * tree.cs (Tree.decl): Removed.
6924 (RootTypes): Started to use this class more often for root types
6927 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6931 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
6932 external interface does not have an attribute.
6934 2006-02-22 Marek Safar <marek.safar@seznam.cz>
6936 Another prerequisites for new partial classs implementation.
6938 * attribute.cs (Attribute.Equal): Implemented.
6939 (Attribute.Emit): Changed as attributes can be applied more than twice.
6940 (Attributes.Emit): Check for duplicate attributes here.
6942 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
6943 as a parameter, clean-up.
6945 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6949 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
6950 contains obsolete attribute check which can in some cases look for base
6951 type of current class which is not initialized yet.
6952 (TypeContainer.BaseType): Replacement of ptype.
6954 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
6956 2006-02-11 Marek Safar <marek.safar@seznam.cz>
6958 First of prerequisites for new partial classs implemention.
6960 * attribute.cs (Attributable): Extended by ResolveContext;
6961 Attributes finally have correct context for resolving in all cases.
6962 (AttachTo): Attribute owner is assigned here.
6964 * codegen.cs (IResolveContext): Introduce new interface to hold
6965 all information needed in resolving phase.
6966 (EmitContext): Implements IResolveContext; more clean-up needed here.
6968 * decl.cs (MemberCore): Implemented IResolveContext.
6970 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
6971 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
6972 parameter.cs, statement.cs, tree.cs, typemanager.cs:
6973 Refactored to use new IResolveContext instead of EmitContext; cleanup
6975 2006-02-06 Miguel de Icaza <miguel@novell.com>
6977 * codegen.cs (EmitScopeInitFromBlock): check here the
6978 capture_context, there is no need to make two calls to the
6981 * anonymous.cs: Add some debugging messages that might help me
6982 track other instances of this problem in the future (the
6983 regression of test 467).
6985 * cs-parser.jay: track the variable block, as we need to initalize
6986 any captured variables declared in this block for the "catch"
6987 portion of the "Try" statement.
6989 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
6990 scope initialization for captured variables.
6992 Also, move the emit for the variables after the block location has
6995 2006-02-06 Marek Safar <marek.safar@seznam.cz>
6997 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
6999 2006-02-02 Miguel de Icaza <miguel@novell.com>
7001 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
7002 commit yesterday, the initialization for the roots is necessary.
7003 What is not necessary is the scope activation.
7005 2006-02-02 Raja R Harinath <rharinath@novell.com>
7007 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
7008 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
7010 (Argument.Resolve): Remove CS0206 checks.
7012 2006-02-01 Miguel de Icaza <miguel@novell.com>
7014 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
7015 scopes for all the roots, the scopes will now be emitted when the
7016 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
7018 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
7019 code. This reduces a lot of existing cruft.
7021 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
7022 that the ScopeInfo is generated as we enter the scope, not at the
7023 time of use, which is what we used to do before.
7025 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
7026 every time a Block is about to be emitted if we have a
7029 2006-02-01 Raja R Harinath <rharinath@novell.com>
7031 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
7033 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
7035 * typemanager.cs (cons_param_array_attribute): Make private.
7036 (Reset): Set it to null.
7037 (InitCoreHelpers): Don't initialize it.
7038 (ConsParamArrayAttribute): New. Initialize it as needed.
7039 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
7041 2006-01-31 Miguel de Icaza <miguel@novell.com>
7043 * expression.cs: There might be errors reported during the
7044 selection of applicable methods. If there are errors, do not
7045 continue execution as it will lead the compiler to crash.
7047 2006-01-30 Miguel de Icaza <miguel@novell.com>
7049 * expression.cs: Member access is not allowed on anonymous
7050 methods. Fixes #77402.
7052 2006-01-30 Raja R Harinath <rharinath@novell.com>
7055 * cs-parser.jay (VariableDeclaration): Don't set
7056 current_array_type to null.
7057 (field_declaration, event_declaration, declaration_statement):
7058 Set it to null here.
7060 2006-01-28 Raja R Harinath <harinath@gmail.com>
7062 * typemanager.cs (GenericParameterPosition): New.
7065 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
7067 * doc.cs : To process "include" elements, first we should create
7068 another list than XmlNodeList, because it could result in node
7069 removal, which could result in that the XmlNodeList gives up
7072 (Also made code identical to gmcs again.)
7074 2006-01-25 Miguel de Icaza <miguel@novell.com>
7076 * ecore.cs: Introduce an error report that we were not catching
7077 before, if not silent, we must report the error. Gonzalo ran into
7080 2006-01-23 Miguel de Icaza <miguel@novell.com>
7082 A fix for bug: #76957
7084 * iterators.cs (MoveNextMethod.CreateMethodHost): call
7085 ComputeMethodHost before creating the method, this is a new
7088 * anonymous.cs (AnonymousContainer): Now we track all the scopes
7089 that this method references (RegisterScope). The actual scope
7090 where the method is hosted is computed with the ComputeMethodHost
7091 before we create the method.
7093 Moved the Deepest routine here.
7095 (AnonymousContainer.ComputeMethodHost): New routine used to
7096 compute the proper ScopeInfo that will host the anonymous method.
7098 (ScopeInfo): Deal with multiple roots. The problem was that we
7099 did not have a unique root where all ScopeInfos could be hanged
7100 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
7103 Remove AdjustMethodScope which is now computed at the end. Remove
7104 LinkScope which did a partial link, instead link all ScopeInfos
7105 before code generation from the new "LinkScopes" routine.
7107 Simplify all the Add* routines as they no longer need to maintain
7108 the tree, they just need to record that they are using variables
7111 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
7112 routines to produce the forest of ScopeInfo trees.
7114 * class.cs (TypeContainer.AppendMethod): This is just like
7115 AddMethod, but ensures that an interface implementation method
7116 (IEnumerable.XXX) is not inserted at the beginning of the queue of
7117 methods, but at the end.
7119 We use this functionality to ensure that the generated MoveNext
7120 method in the iterator class is resolved/emitted before the
7121 enumerator methods created.
7123 This is required because the MoveNext method computes the right
7124 ScopeInfo for the method. And the other methods will eventually
7125 need to resolve and fetch information computed from the anonymous
7128 2006-01-21 Raja R Harinath <harinath@gmail.com>
7129 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7132 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
7134 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
7135 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
7137 2006-01-18 Raja R Harinath <rharinath@novell.com>
7139 Fix #76656, cs0231-2.cs.
7140 * cs-parser.jay (formal_parameter_list): Make error case catch
7142 (parenthesized_expression_0): Add CS1026 check.
7143 (invocation_expression): Remove unused { $$ = lexer.Location }.
7145 2006-01-17 Raja R Harinath <rharinath@novell.com>
7148 * cs-parser.jay (statement_expression): Don't list out the
7149 individual statement-expressions. Convert syntax error into
7152 2006-01-16 Raja R Harinath <rharinath@novell.com>
7155 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
7156 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
7157 CheckIntermediateModification.
7158 (FieldExpr.DoResolve): Add new two-argument version that
7159 allows us to resolve the InstanceExpression as an lvalue.
7160 The one-argument variant is now just a wrapper.
7161 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
7162 Resolve the lhs as an lvalue if the it has a value type.
7163 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
7164 from Assign.DoResolve.
7165 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
7166 resolved as an lvalue.
7167 (PropertyExpr.DoResolve): Update.
7168 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
7169 has a value type. Move CS1612 check here from
7170 CheckIntermediateModification.
7171 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
7172 * expression.cs (EmptyExpression.OutAccess): New. Used as the
7173 'right_side' of a ResolveLValue on an 'out' argument.
7174 (EmptyExpression.LValueMemberAccess): New. Used as the
7175 'right_side' of a propagated ResolveLValue on a value type.
7176 (LocalVariableReference.DoResolveBase): Recognize
7177 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
7179 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
7180 EmptyExpression.Null.
7182 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
7184 * typemanager.cs : added IsGenericParameter(). In mcs it always
7186 * doc.cs : for generic parameters, use GenericParameterPosition,
7189 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
7191 * expression.cs: Fix Console.WriteLine ((this = x).foo);
7193 2006-01-12 Miguel de Icaza <miguel@novell.com>
7195 This fixes the problem where we used ldfld instead of ldflda to
7196 load the "THIS" pointer on captured parameters, when THIS is a
7197 value type. See bug #77205.
7199 * iterators.cs (CapturedThisReference.Emit): Pass false to
7200 EmitThis (we do not need the address).
7202 * codegen.cs (EmitThis): it needs to know whether we need the
7203 address of `this' or not. This is used by value types.
7205 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
7206 every other call passes false.
7208 2006-01-12 Raja R Harinath <rharinath@novell.com>
7211 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
7213 * expression.cs (Invocation.OverloadResolve): Update.
7214 (Invocation.DoResolve): Avoid double resolution of invocation.
7216 2006-01-11 Raja R Harinath <rharinath@novell.com>
7219 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
7220 unary negation of floating point types as 0-expr; negation cannot
7221 overflow in floating point types.
7224 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
7225 on operands of 'void' type.
7228 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
7229 and ExclusiveOr for boolean constants too.
7231 2006-01-09 Raja R Harinath <rharinath@novell.com>
7234 * expression.cs (Invocation.OverloadResolve): Replace reflected
7235 override methods with their base virtual methods, rather than
7237 * typemanager.cs (TypeManager.GetOverride): New.
7239 2006-01-05 Jb Evain <jbevain@gmail.com>
7241 * class.cs (Property.Define, Indexer.Define): do not tag the
7242 properties as SpecialName | RTSpecialName.
7244 2006-01-04 Miguel de Icaza <miguel@novell.com>
7246 * class.cs (MethodCore.IsDuplicateImplementation): This method was
7247 doing a low-level comparission of parameter types. It was lacking
7248 a check for __argslist.
7250 2005-12-30 Miguel de Icaza <miguel@novell.com>
7252 * expression.cs (ParameterReference.DoResolveBase): Allow
7253 reference parameters if they are local to this block.
7255 This allows the ref and out parameters of a delegate to be used in
7256 an anonymous method, for example:
7258 delegate void set (out int x);
7260 set s = delegate (out int x){
7264 This is used by functionality introduced late in the C# language.
7266 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
7267 method that take ref and out parameters.
7269 Fixes #77119 which was a late change in the spec.
7271 2005-12-23 Miguel de Icaza <miguel@novell.com>
7273 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
7274 parent if its the same scope. Fixes #77060.
7276 2005-12-21 Miguel de Icaza <miguel@novell.com>
7278 * driver.cs: Report the case of no source files and no -out:
7281 2005-12-20 Raja R Harinath <rharinath@novell.com>
7284 * expression.cs (ComposedCast.GetSignatureForError): Define.
7286 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7290 * namespace.cs (NamespaceEntry): Add extern_aliases as a
7291 ListDictionary, to contain the ExternAliasEntry entries (in
7292 addition to the NamespaceEntry.aliases hashtable). This field is
7293 shared between the original entry and its doppelganger (bodyless
7295 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
7296 extern_aliases field.
7297 (NamespaceEntry.Lookup): Move the IsImplicit check after the
7298 lookup in extern_aliases.
7300 2005-12-16 Raja R Harinath <rharinath@novell.com>
7303 * class.cs (TypeContainer.Mark_HasEquals): New.
7304 (TypeContainer.Mark_HasGetHashCode): New.
7305 (ClassPart): Override them.
7306 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
7309 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
7310 'parent' argument to the base constructor.
7312 Remove all mention of TypeContainer from decl.cs.
7313 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
7314 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
7315 (DeclSpace.DeclSpace): Likewise.
7316 (DeclSpace.DefineMembers): Remove unused argument.
7317 * cs-parser.jay (pop_current_class): Update to changes. Simplify
7318 debugging check -- we don't care if the debug code throws an
7319 InvalidCastException instead of an InternalErrorException.
7320 * class.cs (TypeContainer.DefineMembers): Update to changes.
7321 (TypeContainer.DoDefineMembers): Likewise.
7322 (TypeContainer.GetMethods): Likewise.
7323 (PropertyMember.Define): Likewise.
7324 (MemberBase.Parent): New property that forwards to
7325 MemberCore.Parent, but ensures that we get a TypeContainer.
7326 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
7327 (RootContext.PopulateTypes): Likewise. Remove special case code
7328 for !RootContext.StdLib: DefineMembers is idempotent.
7330 2005-12-14 Miguel de Icaza <miguel@novell.com>
7332 * convert.cs (ExplicitConversionCore): Check the return value from
7333 ExplicitConversionCore which can return null on failure. Fixes #76914
7335 2005-12-13 Marek Safar <marek.safar@seznam.cz>
7337 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
7339 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
7341 * doc.cs : The search for referenced namespace was insufficient to
7342 get global one as it used to do. Fixed bug #76965.
7344 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
7346 * doc.cs : check name in cref in the last phase that whether it is
7349 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7351 * cs-tokenizer.cs : reverted the latest change: it somehow broke
7354 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7356 * doc.cs : so it turned out that we cannot skip override check for
7357 interface members. Fixed bug #76954.
7359 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
7361 * cs-tokenizer.cs : fixed bug #75984:
7362 - #warning and #error should not be handled when the source line
7364 - #line is not checked strictly when the source line is disabled.
7365 - #define and #undef is on the other hand checked strictly at any
7368 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
7370 * cs-tokenizer.cs : missing Location (actually, filename) in one of
7373 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7375 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
7377 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
7379 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
7380 (FieldBase.Initializer): Initializer is now optional.
7381 (EventField.Define): Only event field can have initializer.
7383 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
7385 * const.cs (Const): Reuse initializer.
7387 * cs-parser.jay: Updated after FieldBase changes.
7388 Added current_array_type to simplify array initializers.
7390 * ecore.cs (NullCast.IsDefaultValue): Implemented.
7392 * expression.cs, iterators.cs: Updated.
7394 * namespace.cs (NamespaceEntry): Made UsingFound private.
7396 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7398 * parameterCollection.cs: Obsolete, removed.
7399 * parser.cs: Obsolete, removed.
7401 2005-12-05 Marek Safar <marek.safar@seznam.cz>
7404 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
7406 * enum.cs (Enum.Define): Set obsolete context here.
7408 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7411 - FindDocumentedMember() now expects 1) paramList as null
7412 when "we don't have to check the number of parameters" and
7413 2) Type.EmptyTypes when "there is no arguments".
7414 - Introduced FoundMember struct to hold the exact type which was
7415 used to find the documented member (the above change broke
7416 test-xml-044; it might be better just to use DeclaringType than
7417 what MS does, like this change does, but it depends on usage.)
7419 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
7421 * doc.cs : documented member might be from DeclaringType for nested
7422 types. Fixed bug #76782.
7424 2005-12-03 Ben Maurer <bmaurer@ximian.com>
7426 * anonymous.cs: Have the param code handle leaving copies on the
7427 stack etc. Allows anonymous params to take part in the assignment
7428 code (++, +=, etc). Fixes bug #76550
7430 * expression.cs: Handle the prepare_for_load/leave_copy by passing
7431 it down to the anon code.
7433 * iterators.cs: Use dummy var here
7435 * codegen.cs: Handle new vars
7437 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7440 * class.cs (MethodData.Define): Set proper Obsolete context.
7442 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
7444 (FieldExpr.DoResolve): Ditto.
7446 2005-12-01 Marek Safar <marek.safar@seznam.cz>
7449 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
7450 parent is not obsolete.
7452 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
7454 * doc.cs : (FindDocumentedMember) find parameterless members first
7455 and get CS0419 in the early stage. Fixed first case of bug #76727.
7457 2005-11-30 Marek Safar <marek.safar@seznam.cz>
7460 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
7461 no error was reported.
7463 *expression.cs (Binary.DoResolve): left can be null.
7465 2005-11-22 Marek Safar <marek.safar@seznam.cz>
7468 * class.cs (MethodData.Emit): Parameters should be labeled first.
7470 2005-11-21 Marek Safar <marek.safar@seznam.cz>
7473 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
7475 2005-11-18 Marek Safar <marek.safar@seznam.cz>
7477 * attribute.cs (AreParametersCompliant): Moved to Parameter.
7479 * class.cs (MethodCore): Parameter clean up.
7480 (IMethodData): Added ParameterInfo.
7481 (MethodData): Parameter clean up.
7482 (Indexer.Define): Parameter clean up.
7494 * typemanager.cs: Parameter clean up.
7496 * delegate.cs (Define): Get rid of duplicated code.
7498 * expression.cs (ParameterReference): Removed useless parameters
7500 (Invocation): Ditto.
7502 * parameter.cs (ParamsParameter): New class, params specialization.
7503 (ArglistParameter): Attemp to separate arglist.
7504 (Parameter): Refactored to be reusable and faster.
7505 (Parameter.Modifier): Made understandable.
7506 (Parameters): Changed to be used as a class for `this' assembly
7507 parameters. Refactored to use new specialized classes.
7509 * support.cs (ParameterData): Added Types property.
7510 (InternalParameters): Deleted.
7512 2005-08-20 Martin Baulig <martin@ximian.com>
7514 Merging this patch from GMCS to fix #75867.
7516 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
7517 scope if we don't already have it.
7519 2005-11-17 Martin Baulig <martin@ximian.com>
7522 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
7523 inherit the scope from our parent. Fixes #76653.
7525 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7527 * doc.cs : the previous patch does not actually fix the bug.
7528 PropertyInfo override check is now implemented and really fixed it.
7529 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
7531 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7533 * doc.cs : apply "override filter" also to properties.
7536 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
7538 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
7539 no need to check overrides. For classes, omit those results from
7540 interfaces since they must exist in the class. Fixed bug #76726.
7542 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7544 * typemanager.cs : (GetFullNameSignature) differentiate indexers
7545 with different parameters. Fixed the second problem in #76685.
7547 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7549 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
7550 get expected 'protected' access in CheckValidFamilyAccess()).
7553 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
7555 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
7556 Fixed bug #76705. CS1569 was incorrectly commented out.
7558 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7560 * doc.cs : use Invocation.IsOverride() to do real override check.
7561 * expression.cs : made Invocation.IsOverride() internal.
7563 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
7565 * doc.cs : use TypeManager.FindMembers() instead of (possible)
7566 TypeBuilder.FindMembers() and filter overriden base members out.
7569 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7571 * doc.cs : ref/out parameters are represented as '@' (instead of
7572 '&' in type FullName). Fixed bug #76630 (additionally crefs).
7574 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7576 * doc.cs : when there was no '.' in cref to methods in doc comment,
7577 then parameters were missing in the output. Fixed bug #76691.
7579 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7581 * driver.cs : don't output docs when there is an error.
7584 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7587 Now it should detect indexers. Fixed primary concern in bug #76685.
7588 Fixed CS0419 message to not show the identical member signature in
7591 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
7593 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
7594 instead of Type.FindMembers() since it does not handle events.
7597 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
7599 * codegen.cs: Fixed typo (speficied -> specified).
7601 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7604 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
7606 2005-11-11 Marek Safar <marek.safar@seznam.cz>
7608 * attribute.cs: Changed error message.
7610 * cs-tokenizer.cs: One more check.
7612 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7614 * statement.cs (Block.Resolve): Ignore empty statement.
7616 2005-11-10 Marek Safar <marek.safar@seznam.cz>
7618 * report.cs: Made error/warning methods more strict to avoid
7621 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
7622 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
7623 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
7624 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
7626 2005-11-08 Marek Safar <marek.safar@seznam.cz>
7628 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
7629 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
7631 * class.cs (TypeContainer.IsComImport): New property.
7632 (Constructor.Define): Create proper ctor for ComImport types.
7634 * expression.cs (New.CheckComImport): Fixed.
7636 2005-11-07 Miguel de Icaza <miguel@novell.com>
7638 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
7639 that a parameter has been captured does not mean that we do not
7640 have to do the rest of the processing. This fixes the second part
7641 of #76592. If there was another anonymous method capturing
7642 values in the past, the Scope would never be set for the second
7643 method that captured the same parameter.
7645 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
7646 properly manipulate the stack. Second part of fix for #76592.
7648 * expression.cs (New): Add support for invoking "new" on
7649 interfaces that have been flagged with the ComImport attribute and
7650 the CoClass. Fixes #76637
7652 * statement.cs (Try.DoEmit): When a variable is captured, do not
7653 try to emit the vi.LocalBuilder variable as it has been captured.
7654 Create a temporary variable and store the results on the
7655 FieldBuilder. Fixes #76642
7657 2005-11-07 Marek Safar <marek.safar@seznam.cz>
7659 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
7661 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
7663 * expression.cs (Binary.DoResolve): Added && optimalization.
7665 * typemanager.cs (AddUserType): Removed useless argument.
7667 2005-11-04 Marek Safar <marek.safar@seznam.cz>
7669 * statement.cs (Block.variables): Uses ListDictionary.
7671 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7674 * class.cs (PartialContainer.EmitType): Customized to emit
7675 security attributes.
7676 (ClassPart.ApplyAttributeBuilder): Transform security attribute
7677 for partial classes.
7679 2005-11-03 Marek Safar <marek.safar@seznam.cz>
7682 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
7683 access has to be fixed.
7685 * typemanager.cs (IsUnmanagedType): Wrong common field type.
7687 2005-11-01 Marek Safar <marek.safar@seznam.cz>
7690 * ecore.cs (NullCast.Reduce): Implemented.
7692 * expression.cs (ArrayCreation.CheckIndices): Correcly check
7695 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
7697 (Foreach.Resolve): Catch null properly.
7699 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7701 * cs-tokenizer.cs: Warning text fix.
7703 * driver.cs: AllWarningNumbers exposed on public interface.
7705 * report.cs (): Reviewed warning numbers.
7706 (IsValidWarning): Use binary search.
7708 2005-10-29 Marek Safar <marek.safar@seznam.cz>
7710 * driver.cs: Implemeted resource visibility.
7711 (Resources): New class for code sharing between /res: and
7714 2005-10-28 Marek Safar <marek.safar@seznam.cz>
7717 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
7720 * convert (Convert.ImplicitReferenceConversion): NullCast holds
7723 * ecore.cs (NullCast): Child is contant only.
7725 * literal.cs (NullLiteral.Reduce): null can be converted to any
7728 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
7730 * driver.cs: Use Encoding.Default as default code page instead
7733 2005-10-27 Raja R Harinath <rharinath@novell.com>
7736 * expression.cs (Invocation.Error_InvalidArguments): Handle
7737 __arglist parameters.
7738 (Invocation.VerifyArgumentsCompat): Likewise.
7739 * support.cs (ReflectionParameters.GetSignatureForError): Print
7740 __arglist parameters.
7741 (InternalParamters.GetSignatureForError): Likewise.
7742 * parameter.cs (Parameters.GetSignatureForError): Likewise.
7744 2005-10-26 Marek Safar <marek.safar@seznam.cz>
7746 * attribute.cs (GetPropertyValue): Made public.
7748 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
7750 Add new property WrapNonExceptionThrows to handle 2.0 assembly
7752 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
7755 * driver.cs: Reflect method name change.
7757 * statement.cs (Try.Resolve): Warn when try has both general
7760 * typemanager.cs: runtime_compatibility_attr_type new predefined
7763 2005-10-26 Raja R Harinath <harinath@gmail.com>
7766 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
7767 treat it as an empty parameter list.
7769 2005-10-26 Raja R Harinath <rharinath@novell.com>
7772 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
7773 ResolveAsTypeStep silent.
7774 * statement.cs (Block.AddConstant): Mark block as used.
7775 (Block.ResolveMeta): Avoid piling on error messages
7776 if a constant initializer resolution fails.
7778 2005-10-25 Raja R Harinath <rharinath@novell.com>
7780 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
7782 (NamespaceEntry.VerifyAllUsing): New.
7783 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
7784 behaviour. Delegates actual resolution of alias to ...
7785 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
7786 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
7788 * driver.cs (Driver.MainDriver): Update.
7790 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
7791 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
7793 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
7795 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
7796 RootNamespace.DefineNamespacesForAll.
7798 2005-10-24 Raja R Harinath <harinath@gmail.com>
7800 * typemanager.cs (assemblies, external_aliases, modules)
7801 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
7802 (ComputeNamespaces, GetRootNamespace): Remove extra staging
7803 overhead. Move resposibility ...
7804 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
7805 * driver.cs, attribute.cs, codegen.cs: Update to changes.
7807 2005-10-23 Raja R Harinath <harinath@gmail.com>
7809 * namespace.cs (RootNamespace.all_namespaces): Renamed from
7810 cached_namespaces. Improve usage.
7811 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
7812 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
7813 Move from GlobalRootNamespace and simplify.
7814 (RootNamespace.Global): Make instance variable.
7815 (RootNamespace.RootNamespace): Add "alias name" parameter.
7816 (GlobalRootNamespace): Simplify drastically.
7817 (Namespace.Lookup): Don't use GetNamespace.
7818 * typemanager.cs (GetRootNamespace): Rename from
7819 ComputeNamespaceForAlias.
7820 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
7822 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7824 * anonymous.cs (AnonymousContainer): Don't crash when container
7827 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7829 * expression.cs (Binary.DoResolve): Warn when comparing same
7832 2005-10-23 Marek Safar <marek.safar@seznam.cz>
7835 * expression.cs (Binary.DoResolve): It looks like there are no
7836 convetsion rules in enum context.
7838 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
7840 Add support for extern alias qualifiers.
7841 * typemanager.cs: Move some LookupTypeReflection code
7842 to namespace.cs, to have cleaner code. Added some methods
7843 to help us keep track of the extern aliased references.
7844 * driver.cs: Add suport for extern alias assemblies on command
7845 line and check for their warnings/errors. Also keep track of the
7846 extern aliased assemblies.
7847 * namespace.cs: Move the global functionality of Namespace
7848 to GlobalRootNamespace/RootNamespace. Now the global namespace
7849 is GlobalRootNamespace.Globa. Also the code moved from
7850 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
7851 Finally added LocalAliasEntry (AliasEntry before) and
7852 ExternAliasEntry, to handle alias statements.
7853 * cs-parser.jay: Add support in the grammar for extern alias
7855 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
7856 Update callings to Namespace (now in GlobalRootNamespace).
7858 2005-10-18 Raja R Harinath <rharinath@novell.com>
7861 * class.cs (TypeContainer.DefineType): Move updating of
7862 topological sort earlier in the code.
7863 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
7865 2005-10-18 Marek Safar <marek.safar@seznam.cz>
7868 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
7870 * constant.cs (Constant.TryReduce): Moved from Cast class.
7871 (Reduce): Made little bit more OO and fixed missing conversions.
7873 * ecore.cs (Reduce): Implemented.
7874 (Binary.EnumLiftUp): New method to upgrade values to enum values.
7876 * literal.cs (Reduce): Implemented.
7878 * class.cs: Reverted Miguel's wrong commit.
7880 2005-10-14 Miguel de Icaza <miguel@novell.com>
7882 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
7884 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
7886 * cs-parser.jay, expression.cs : CS0214 was missing error location
7887 for constants. Fixed bug #76404.
7889 2005-10-11 Marek Safar <marek.safar@seznam.cz>
7892 * convert.cs (ExplicitConversionCore): Fixed object->enum
7895 2005-10-10 Raja R Harinath <rharinath@novell.com>
7897 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
7899 (PropertyExpr.EmitCall): Likewise.
7900 * expression.cs (Invocation.EmitArguments): Handle case where
7902 (Invocation.EmitCall): Avoid allocating temporary variable if
7903 there are no arguments.
7905 2005-10-07 Raja R Harinath <rharinath@novell.com>
7908 * convert.cs (ImplicitConversionStandard): Move conversion of
7909 void* to arbitrary pointer types ...
7910 (ExplicitConversionStandard): .. here.
7911 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
7912 error to always print typenames.
7914 2005-10-07 Raja R Harinath <rharinath@novell.com>
7916 * convert.cs (GetConversionOperator): Rename from
7917 GetConversionOperators. Move operator selection code from ...
7918 (UserDefinedConversion): ... here.
7920 2005-10-06 Marek Safar <marek.safar@seznam.cz>
7922 * convert.cs (ExplicitConversionCore): Removed duplicate enum
7925 2005-10-05 Marek Safar <marek.safar@seznam.cz>
7927 * assign.cs (Assign.DoResolve): Error method changed.
7929 * cfold.cs (DoConstantNumericPromotions): Error method changed.
7931 * const.cs (ResolveValue): Reset in_transit immediately.
7933 * constant.cs: Error method changed.
7935 * convert.cs: Removed useless location parameter.
7936 (ExplicitNumericConversion): Don't do double enum check.
7937 (ExplicitConversionCore): Renamed from ExplicitConversion.
7938 (ExplicitUnsafe): Extracted from ExplicitConversion.
7939 (ExplicitConversion): Uses for error reporting.
7941 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
7943 (ResolveBoolean): Uses common error method.
7944 (CastToDecimal): Get rid of ec.
7945 (CastFromDecimal): Optimized.
7946 (ConvCast): Get rid of ec.
7948 * enum.cs (ResolveValue): Reset in_transit immediately.
7949 (Emit): Return after first error.
7951 * expression.cs: Convert changes.
7953 * literal.cs: Error method changed.
7955 * statement.cs: Error method changed.
7957 2005-10-03 Raja R Harinath <rharinath@novell.com>
7959 * support.cs (SeekableStreamReader.Position): Don't error out when
7960 the requested position is just beyond the end of the current
7963 2005-09-28 Raja R Harinath <rharinath@novell.com>
7965 * support.cs (SeekableStreamReader): Simplify drastically. Don't
7966 try to keep in sync with the byte count of the underlying Stream.
7967 However, this limits us to a window size of 2048 characters: i.e.,
7968 the maximum lookahead of our lexer/parser can be 2048 characters.
7970 2005-09-28 Marek Safar <marek.safar@seznam.cz>
7973 * driver.cs: Fix compilation files with full root path.
7975 2005-09-25 Miguel de Icaza <miguel@novell.com>
7977 * report.cs (SymbolRelatedToPreviousError): Format the output so
7978 it does not use an open parenthesis that is never closed.
7980 * driver.cs: Follow coding guidelines
7982 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7985 * const.cs (Const.ResolveValue): Check for assigning non-null
7986 value to reference type.
7988 2005-09-27 Marek Safar <marek.safar@seznam.cz>
7990 * anonymous.cs: Implemented ExprClassName.
7992 * assign.cs (Assign.DoResolve): Don't chrash when type is not
7995 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
7998 * class.cs (StaticClass.DefineContainerMembers): Report protected
8001 * codegen.cs: if(ed) PRODUCTION.
8003 * convert.cs (Error_CannotImplicitConversion): Better error
8006 * cs-parser.jay: More error checks.
8008 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
8010 * driver.cs (CSCParseOption): Enabled wrong option check.
8012 * ecore.cs (Expression.ExprClassName): Turned to property.
8013 (MemberExpr.CheckIntermediateModification): For checking boxed
8014 value types modification.
8016 * statement.cs (Fixed.Resolve): Expression type must be
8017 convertible to fixed type.
8018 (CollectionForeach.GetEnumeratorFilter,TryType):
8019 Small refactoring for easier error checking.
8021 2005-09-26 Marek Safar <marek.safar@seznam.cz>
8023 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
8026 * class.cs (GeneratedBaseInitializer): New class for customization
8027 compiler generated initializers.
8028 (MemberBase.DoDefine): Check Obsolete attribute here.
8029 (FieldMember.DoDefine): Ditto.
8031 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
8034 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
8035 (MemberCore.GetObsoleteAttribute): Removed argument.
8036 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
8037 (MemberCore.CheckObsoleteType): New helper.
8041 * statement.cs: Updates after MemberCore changes.
8043 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
8044 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
8046 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
8047 obsolete attribute for compiler construct.
8048 (As.DoResolve): Cache result.
8050 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
8052 2005-09-26 Raja R Harinath <rharinath@novell.com>
8055 * expression.cs (This.VerifyFixed): In a value type T, the type of
8056 'this' is T&, iow, 'this' is either an out or ref parameter. In a
8057 value type R, 'this' is treated as a value parameter.
8059 2005-09-22 Miguel de Icaza <miguel@novell.com>
8061 * statement.cs (Lock): Use the TemporaryVariable class instead of
8062 manually using local variables as those do not work when variables
8065 * ecore.cs: Moved the TemporaryVariable class from being a nested
8066 class inside Foreach to be a public class that can be employed in
8069 2005-09-19 Marek Safar <marek.safar@seznam.cz>
8071 * cs-parser.jay: interface_accessors replaced by
8072 accessor_declarations.
8074 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
8077 * statement.cs (GotoCase.Resolve): Convert null constant to
8079 (SwitchLabel.ResolveAndReduce): Ditto.
8080 (SwitchLabel.NullStringCase): Custom null stamp.
8081 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
8083 typemanager.cs (CSharpSignature): Don't skip first argument
8086 2005-09-18 Miguel de Icaza <miguel@novell.com>
8088 * driver.cs: Set InEmacs based on the environment variable EMACS.
8090 * location.cs (InEmacs): in this mode, do not report column
8091 location as it confuses Emacs.
8093 2005-09-16 Marek Safar <marek.safar@seznam.cz>
8095 * cfold.cs, constant.cs, convert.cs, ecore.cs,
8096 expression.cs, iterators.cs, literal.cs: Store constants and
8099 * class.cs (MemberBase.ShortName): Pass location.
8101 * cs-parser.jay: Some location fixes.
8103 * ecore.cs (Expression.Location): Made virtual.
8105 2005-09-05 Miguel de Icaza <miguel@novell.com>
8107 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
8108 if the underlying types are the same, otherwise we need to produce
8109 code that will do the proper cast.
8111 This was exposed by Marek's constant rewrite which produced
8112 invalid code for the call site:
8115 void Method (X v) {}
8119 This fixes test-49.cs
8121 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
8123 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
8124 Type/Object should be allowed as well. Fixed bug #75968.
8126 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
8128 * expression.cs : (Binary.DoResolve): when one is enum constant and
8129 another is constant 0, then return enum one *as enum type*.
8132 2005-09-02 Raja R Harinath <rharinath@novell.com>
8134 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
8138 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
8139 flow-branching for LocalVariableReferences in case we were invoked
8140 from a MemberAccess.
8141 * expression.cs (LocalVariableReference.VerifyAssigned): New.
8143 (LocalVariableReference.DoResolveBase): ... this.
8144 (MemberAccess.Resolve): Do the check that was disabled during
8147 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8150 (PartialContainer.Create): check abstract/sealed/static strictly
8151 but abstract/sealed can exist only at one side. Fixed bug #75883.
8153 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
8156 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
8157 specified, don't default to UnmanagedType.I4.
8159 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
8161 * expression.cs : conditional operator should check possibly
8162 incorrect assign expression. Fixed bug #75946.
8164 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8166 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
8167 Reverting the change. gmcs is much complex than mcs on this matter.
8169 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
8171 * cs-tokenizer.cs : To read another token ahead of the actual
8172 consumption, use new SavedToken and cache token instead of moving
8173 back the stream with SeekableStreamReader (it seemed problematic).
8175 driver.cs : Thus use StreamReader directly.
8176 * support.cs : Thus removed SeekableStreamReader.
8178 2005-08-30 Raja R Harinath <rharinath@novell.com>
8181 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
8182 (ScopeInfo.EmitScopeType): Use it to construct field names from
8183 names of captured locals.
8186 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
8187 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
8188 Pass 'target_type' to BoxedCast. Don't default to 'object'.
8189 (ExplicitConversion): Remove enum cases already handled by
8190 implicit conversion. Move implicit conversion check to the beginning.
8191 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
8192 * expression.cs (ArrayCreation.EmitDynamicInitializers):
8193 Don't treat System.Enum as a struct.
8195 2005-08-30 Jb Evain <jbevain@gmail.com>
8197 * attribute.cs: handles as expression in parameters.
8199 2005-08-30 Raja R Harinath <rharinath@novell.com>
8202 * class.cs (TypeContainer.VerifyClsName): Don't use a
8203 PartialContainer when verifying CLS compliance.
8204 (AbstractPropertyEventMethod): Set Parent here, ...
8205 (PropertyMethod): ... not here.
8207 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
8209 * attribute.cs : escaped attribute name should not be allowed to be
8210 resolved (e.g. @class as classAttribute). Fixed bug #75930.
8212 2005-08-29 Raja R Harinath <rharinath@novell.com>
8215 * convert.cs (ImplicitStandardConversionExists): Allow zero also
8216 when converting a long constant to unsigned long.
8217 * expression.cs (Invocation.OverloadResolve): Add sanity check to
8218 detect where IsApplicable and VerifyArgumentsCompat disagree.
8220 2005-08-29 Raja R Harinath <rharinath@novell.com>
8221 and Carlos Alberto Cortez <carlos@unixmexico.org>
8224 * class.cs (TypeContainer.CanElideInitializer): New helper.
8225 (TypeContainer.EmitFieldInitializers): Use it to determine if we
8226 can safely emitting the initializer of a field.
8228 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8230 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
8231 allowed inside a switch (without loop). Fixed bug #75433.
8233 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
8235 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
8236 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
8238 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8240 * driver.cs : kinda reverting the default encoding changes (not exact
8241 revert since I noticed that "codepage:reset" might not work fine).
8243 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8245 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
8246 Location. Now getter and setter store location correctly.
8247 (errors/cs0111-12.cs now reports the expected location.)
8249 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
8251 * driver.cs : Use default encoding on the environment.
8252 Removed (now that) extra parameter for SeekableStreamReader.
8253 * support.cs : (SeekableStreamReader) third .ctor() argument for
8254 StreamReader is not required (always true). preamble size could
8255 be acquired in simpler and safe way.
8257 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
8259 * cs-parser.jay: report CS0642 at warning level 3
8260 and report CS0642 for an if else statement also
8261 fixes bug #74745. Patch by John Luke (and a bit
8263 Removed extra CS0642 warning check for "while",
8265 * statement.cs: In Block.Resolve(), CS0642 check
8266 is reimplemented to check a sequence of an empty
8267 statement and a block.
8269 Both fix bug #66777.
8271 2005-08-24 Marek Safar <marek.safar@seznam.cz>
8273 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
8274 detection until I fix it.
8276 * cs-tokenizer.cs: Changed error message.
8278 * cs-parser.jay: Fixed 2 error locations.
8280 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
8281 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
8284 * enum.cs (GetSignatureForError): Fixed.
8286 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
8290 * typemanager.cs (RegisterProperty): Removed.
8292 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
8294 2005-08-24 Raja R Harinath <rharinath@novell.com>
8297 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
8298 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
8300 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8302 * expression.cs : tiny fix is required for not warning positive ulong.
8305 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8307 * expression.cs : add CS0652 check for constant and integral
8308 expression. Fixed bug #53974.
8310 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8312 * expression.cs : in DoNumericPromotions(), check if there is implicit
8313 conversion overload for string (to check CS0034). Fixed bug #52492.
8315 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8317 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
8319 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8321 * ecore.cs : report location when it is *not* Null.
8323 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
8329 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
8330 correctly. Fixed bug #75721.
8332 2005-08-23 Raja R Harinath <rharinath@novell.com>
8334 * support.cs (SeekableStreamReader.Position): Avoid an expensive
8335 loop that performs 'min (pos, char_count)'.
8338 * expression.cs (Unary.ResolveOperator): Don't discard implicit
8339 converted value in Operator.OnesComplement.
8341 2005-08-22 Ben Maurer <bmaurer@ximian.com>
8343 * anonymous.cs: If the anon method is pulled into a helper class,
8344 it needs to be `internal' not `private'. Fixes runtime behavior on
8347 2005-08-20 Martin Baulig <martin@ximian.com>
8349 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
8350 scope if we don't already have it.
8352 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
8353 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
8356 2005-08-17 Marek Safar <marek.safar@seznam.cz>
8359 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
8362 2005-08-16 Marek Safar <marek.safar@seznam.cz>
8364 The big constants rewrite
8365 Fix #75746, #75685 and more
8366 As a side effect saved 1MB for MWF ;-)
8368 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
8369 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
8370 enum based for corlib compilation.
8372 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
8375 * class.cs (FixedField.Define): Use ResolveAsConstant.
8377 * const.cs (IConstant): Interface constants and enums.
8378 (Const.ResolveValue): New method for constant resolvning.
8379 (ExternalConstant): Constants from imported assemblies.
8381 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
8382 conversion; like enums.
8383 (Constant.ToType): Converts this constant to different type.
8384 (Constant.Increment): Adds 1.
8386 * convert.cs (ImplicitConversionRequired): Simplified.
8388 * cs-parser.jay: Create EnumMember directly.
8390 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
8392 * doc.cs (GenerateEnumDocComment): Removed.
8394 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
8395 (ConvertIntLiteral): Removed.
8396 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
8398 * enum.cs (EnumMember): Implement IConstant.
8399 (Enum.IsValidEnumConstant): Removed.
8400 (Enum.GetNextDefaultValue): Removed.
8401 (Enum.FindMembers): Updated.
8402 (Enum.GenerateDocComment): Iterate enum members.
8404 * expression.cs (Cast.TryReduce): Handle enums correctly.
8405 (New.Constantify): Made public.
8406 (MemberAccess.DoResolve): Removed contant specific if(s).
8408 * literal.cs (NullLiteral): Implement new abstract methods.
8410 * statement.cs (GotoCase.Resolve): Use new constant methods.
8411 (SwitchLabel.ResolveAndReduce): Use new constant methods.
8413 * typemanager.cs (LookupEnum): Removed.
8414 (IsEnumType): Fixed to work with corlib.
8415 (RegisterConstant): Removed.
8416 (LookupConstant): Removed.
8417 (GetConstant): Changed to work with IConstant.
8419 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
8421 * location.cs : Fixed overflown (>255) column number.
8423 2005-08-03 Raja R Harinath <rharinath@novell.com>
8425 First cut of the qualified-alias-member feature.
8426 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
8428 * cs-parser.jay (DOUBLE_COLON): New token.
8429 (namespace_or_type_name): Add rule for recognizing
8430 qualified-alias-members.
8431 (primary_expression): Likewise.
8432 (element_access): Allow QualifiedAliasMember as a possible
8433 type-bearing expression.
8434 (local_variable_type, local_variable_pointer_type): Likewise.
8435 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
8436 aliases in the current and enclosing namespace declarations.
8437 (NamespaceEntry.UsingAlias): Add CS0440 warning.
8438 * decl.cs (MemberName.is_double_colon): New.
8439 (MemberName.MemberName): Add new constructor for alias-member.
8440 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
8441 * expression.cs (QualifiedAliasMember): New expression type.
8443 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8445 * location.cs : it borked when no argument was specified.
8447 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8449 * location.cs : tiny ToString() format fix.
8451 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8453 * statement.cs : oops, it was missing.
8455 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
8457 A set of fixes for precise line/column location.
8460 "token" field now holds a file/line "delta", a line number offset
8461 from the segment, and a column number. See also:
8462 http://lists.ximian.com/pipermail/mono-devel-list/2004-
8463 December/009508.html
8464 Removed static IsNull. Use instance IsNull property instead.
8466 For some tokens it stores Location. For Identifier it stores
8467 LocatedToken which is a pair of string name and location.
8468 Column numbers are adjusted only at getChar().
8470 Use Location.ToString() for reporting (it now contains column).
8472 Largely modified to use LocatedToken instead of
8473 string (IDENTIFIER), and to acquire Location from some tokens.
8474 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
8475 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
8477 Now MemberName holds Location. DeclSpace.ctor() receives Location
8478 as a parameter. Removed extra parameters to all derived classes.
8479 Replaced Location.IsNull() with instance property.
8480 * assign.cs, expression.cs :
8481 Added .ctor() overload that omits Location.
8483 Added "nameEscaped" flag that indicates the identifier was escaped
8484 in the source file. This fixes bug #57047.
8486 2005-08-02 Marek Safar <marek.safar@seznam.cz>
8488 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
8489 New method, looking for lo-case imported cls type.
8491 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
8494 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
8496 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
8498 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
8500 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
8502 Optimized to save 3.5 MB for SWF compilation.
8504 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8506 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
8507 (PartialContainer.Create): Moved logic AddToContainer.
8508 (PartialContainer.MarkForDuplicationCheck): Shares name.
8510 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
8513 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
8515 (Namespace.GetSignatureForError): New method.
8517 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
8518 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
8520 2005-08-01 Raja R Harinath <rharinath@novell.com>
8523 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
8524 member lookup rather than qualifier_type, since qualifier_type can
8527 2005-08-01 Marek Safar <marek.safar@seznam.cz>
8529 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
8532 2005-07-31 Miguel de Icaza <miguel@novell.com>
8534 * statement.cs: Copy the local exception into the exception
8535 captured local. Fixes 75674
8537 2005-07-31 Raja R Harinath <harinath@gmail.com>
8540 * expression.cs (Invocation.OverloadResolve): Don't report error
8541 CS1501 if error CS1502 has been reported.
8542 (New.DoResolve): Delegate CS1501 reporting to
8543 Invocation.OverloadResolve.
8546 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
8547 invariant-meaning-in-block property in an enclosing block if
8550 2005-07-29 Marek Safar <marek.safar@seznam.cz>
8552 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
8553 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
8554 (Switch.CheckSwitch): Just save 50kb for SWF.
8556 2005-07-27 Martin Baulig <martin@ximian.com>
8558 * anonymous.cs (CaptureContext.AddField): Added
8559 `AnonymousContainer am' argument; compute its toplevel scope if
8560 it's not already computed. Fixes #75649.
8562 2005-07-26 Raja R Harinath <rharinath@novell.com>
8565 * class.cs (Constructor.Emit): Reset block to null if the block
8568 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8570 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
8572 2005-07-25 Marek Safar <marek.safar@seznam.cz>
8574 * class.cs (MethodData.Define): Check whether accessor implementing
8575 interface is public.
8577 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
8579 2005-07-22 Marek Safar <marek.safar@seznam.cz>
8582 * namespace.cs (LookupType): Moved same type check to...
8584 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
8587 2005-07-21 Raja R Harinath <rharinath@novell.com>
8589 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
8590 already found a typebuilder.
8591 * class.cs (MethodCore.IsDuplicateImplementation): Compare
8592 MemberNames, not strings.
8594 * const.cs (Error_ExpressionMustBeConst):
8595 Rename from Error_EpressionMustBeConst.
8596 * const.cs, class.cs, statement.cd: Update.
8598 2005-07-21 Marek Safar <marek.safar@seznam.cz>
8602 * const.cs (Const.LookupConstantValue): Report missing contant expression
8604 (Error_EpressionMustBeConstant): Only one error method.
8606 * class.cs, statement.c: Updated.
8608 2005-07-20 Raja R Harinath <rharinath@novell.com>
8610 * statement.cs (Block.Flags): Add back HasVarargs.
8611 (Block.flags): Make protected.
8612 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
8614 * typemanager.cs (types, typecontainers, user_types): Remove.
8615 (UserTypes, TypeContainers): Likewise.
8616 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
8617 (CleanUp, Reset): Update.
8618 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
8619 (GetNestedType): Use Type.GetNestedType.
8620 (CoreLookupType): Take two arguments, the namespace and the
8621 basename of the type. Update to use the Namespace.Lookup
8623 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
8624 (RealMemberLookup): Use IsNestedChildOf instead of playing with
8625 string concatenation and substring matches.
8626 * class.cs, enum.cs, delegate.cs: Update to changes.
8628 2005-07-20 Marek Safar <marek.safar@seznam.cz>
8630 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
8631 Expression and made virtual.
8633 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
8634 (ImplicitStandardConversionExists): Fixed `byte' typo ?
8636 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
8638 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
8641 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
8644 2005-07-18 Marek Safar <marek.safar@seznam.cz>
8647 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
8648 AssemblyCultureAttribute is not used on executable.
8651 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
8653 2005-07-16 Raja R Harinath <rharinath@novell.com>
8656 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
8657 New. Reports CS0252/CS0253.
8658 Mostly taken from preliminary patch by Duncak Mak.
8659 (Binary.DoResolveOperator): Store results of operator lookup.
8660 Use them to detect if we need to warn about unintended reference
8663 2005-07-15 Raja R Harinath <rharinath@novell.com>
8666 * namespace.cs (Namespace.Lookup): Add back location parameter.
8667 (Namespace.LookupType): Add CS0436 report. Add location parameter.
8668 * delegate.cs, ecore.cs, expression.cs: Update to changes.
8670 * codegen.cs (EmitContext.DeclSpace): Make readonly.
8671 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
8672 (Namespace.LookupType): ... this.
8673 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
8675 * typemanager.cs (LookupTypeReflection): Remove buggy code that
8676 purported to handle pointers.
8677 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
8680 2005-07-15 Marek Safar <marek.safar@seznam.cz>
8682 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
8685 2005-07-15 Raja R Harinath <rharinath@novell.com>
8687 * namespace.cs (Namespace.Lookup): Drop location parameter.
8688 (NamespaceEntry.LookupAlias): Remove. Merge into ...
8689 (NamespaceEntry.Lookup): ... this.
8690 (NamespaceEntry.Error_AmbiguousTypeReference):
8691 Move here from DeclSpace.
8692 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
8694 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
8695 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
8696 Move to NamespaceEntry.
8697 * delegate.cs, expression.cs: Update to changes.
8699 2005-07-14 Marek Safar <marek.safar@seznam.cz>
8701 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
8702 CheckAttributeType and refactored.
8703 (Attribute.ResolvePossibleAttributeType): Changed to reuse
8704 ResolveAsTypeTerminal error handling.
8705 (ResolveAsTypeTerminal): Introduced because of global attributes extra
8707 (GetSignatureForError): Print errors in same way.
8710 * codegen.cs: Reflect attribute GetSignatureForError change.
8713 * expression.cs: Add silent parameter to ResolveAsTypeStep.
8715 * namespace.cs (UsingEntry): Refactored to make fields private.
8718 statement.cs: Error_UnexpectedKind has extra parameter.
8720 2005-07-14 Raja R Harinath <rharinath@novell.com>
8722 * ecore.cs (IAlias): Remove.
8723 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
8724 that implement the interface.
8725 * namespace.cs (Namespace): Likewise.
8726 (Namespace.declspaces): Renamed from 'defined_names'.
8727 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
8728 DeclSpace instead of an IAlias.
8729 * tree.cs (Tree.AddDecl): Update.
8731 2005-07-12 Raja R Harinath <rharinath@novell.com>
8733 * statement.cs (Block.Flags); Remove HasVarargs.
8734 (Block.HasVarargs): Move to ToplevelBlock.
8735 (Block.ThisVariable, Block.AddThisVariable): Likewise.
8736 (Block.Variables): Make protected. Initialize variable hashtable
8738 (Block.AddVariable): Update.
8739 (Block.Resolve): Update to changes.
8740 (ToplevelBlock.HasVarargs): New boolean.
8741 (ToplevelBlock.ThisVariable): Move here from Block.
8742 (ToplevelBlock.AddThisVariable): Likewise.
8743 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
8744 * expression.cs (This.ResolveBase): Update to changes.
8745 (ArglistAccess.DoResolve): Likewise.
8747 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8750 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
8752 * class.cs (TypeContainer.VerifyMembers): Distinguish between
8753 not used and not used & assigned.
8754 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
8756 2005-07-11 Marek Safar <marek.safar@seznam.cz>
8759 * expression.cs (Is.DoResolve): null is never provided type.
8761 2005-07-08 Marek Safar <marek.safar@seznam.cz>
8764 * cs-parser.jay: Less strict event error rule to catch more errors.
8766 2005-07-08 Martin Baulig <martin@ximian.com>
8768 Fix test-iter-10.cs - distinguish whether we `yield' in a property
8769 gettter (allowed) or setter (not allowed).
8771 * class.cs (Accessor): Implement IIteratorContainer.
8772 (Accessor.Yields): New public field.
8773 (PropertyBase.PropertyMethod.Define): Handle iterators on a
8777 (get_accessor_declaration, set_accessor_declaration): Set the
8778 `yields' flag on the accessor, not the property.
8779 (property_declaration): Do the iterators check on a per-accessor
8780 basis and not for the whole property.
8782 2005-07-08 Martin Baulig <martin@ximian.com>
8784 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
8785 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
8787 2005-07-07 Marek Safar <marek.safar@seznam.cz>
8790 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
8791 (ExtractSecurityPermissionSet): Cope with self referencing security
8792 attributes properly.
8794 * driver.cs (SetOutputFile): Made public property OutputFile.
8796 2005-07-07 Raja R Harinath <rharinath@novell.com>
8799 * class.cs (TypeContainer.first_nonstatic_field): Rename from
8800 has_nonstatic_fields. Make into a FieldBase pointer.
8801 (TypeContainer.AddField): Add CS0282 check.
8802 (TypeContainer.EmitType): Update.
8804 2005-07-06 Miguel de Icaza <miguel@novell.com>
8806 * cs-tokenizer.cs (consume_identifier): Do not create strings to
8807 compare if they start with __.
8809 2005-07-06 Raja R Harinath <rharinath@novell.com>
8811 * statement.cs (Switch.SwitchGoverningType): Only look at
8812 UserCasts that don't need implicit standard conversions to one of
8813 the allowed switch types (Fixes test-322.cs).
8814 (LocalInfo.Resolve): Re-enable sanity-test.
8816 2005-07-06 Marek Safar <marek.safar@seznam.cz>
8818 * cs-tokenizer.cs (consume_identifier): Detect double undescores
8820 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
8822 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
8824 2005-07-06 Raja R Harinath <rharinath@novell.com>
8827 * ecore.cs (SimpleName.GetSignatureForError): Add.
8828 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
8829 (MemberAccess.GetSignatureForError): Add.
8831 2005-07-05 Marek Safar <marek.safar@seznam.cz>
8833 The big error and warning messages review.
8863 * typemanager.cs: Updated.
8865 * class.cs: (MethodCore.SetYields): Moved here to share.
8866 (PropertyMethod.Define): Moved iterator setup here.
8868 * iterators.cs: Add orig_method to have full access to parent
8871 2005-07-05 Raja R Harinath <rharinath@novell.com>
8873 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
8874 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
8875 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
8876 variable of struct type.
8877 * expression.cs (Unary.ResolveOperator): Update to change.
8878 (Indirection.VerifyFixed): Likewise.
8879 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
8880 (ParameterReference.VerifyFixed): Value parameters are fixed.
8881 (This.VerifyFixed): Treat 'this' as a value parameter.
8882 * statement.cs (LocalInfo.IsFixed): Remove.
8884 2005-07-01 Martin Baulig <martin@ximian.com>
8886 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
8887 `ec.EmitThis ()' to get the correct scope.
8889 2005-07-01 Martin Baulig <martin@ximian.com>
8891 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
8892 instance is a ParameterReference; fixes #75299.
8894 2005-07-01 Martin Baulig <martin@ximian.com>
8896 Reverted Marek's latest patch (r46725):
8897 - it contains structural changes which are neither mentioned in
8898 the ChangeLog nor explained anywhere; for example the additional
8899 argument of EmitContext's and Iterator's .ctor's and the
8900 TypeContainer.DefineMembers() change.
8901 - structural changes like this should go in in seperate patches
8902 and not be hidden in a huge patch which just seems to affect
8903 warnings and errors.
8904 a big and hard to understand patch.
8905 - it breaks iterators and causes regressions, for instance in
8908 2005-06-30 Raja R Harinath <rharinath@novell.com>
8911 * expression.cs (Indexers.map): Remove.
8912 (Indexers.Append): Filter out inaccessible setters and getters.
8913 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
8916 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
8918 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
8919 (FieldExpr.Emit, PropertyExpr.Emit): Update.
8920 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
8921 * expression.cs (Invocation.EmitCall): Add CS0120 check.
8923 2005-06-30 Marek Safar <marek.safar@seznam.cz>
8926 * class.cs (FieldBase.GetInitializerExpression): One more field
8929 2005-06-28 Miguel de Icaza <miguel@novell.com>
8931 * pending.cs: Do not define a proxy if the base method is virtual,
8932 it will be picked up by the runtime (bug 75270).
8934 2005-06-08 Martin Baulig <martin@ximian.com>
8936 The big Iterators rewrite :-)
8938 * iterators.cs: Rewrite this to use the anonymous methods framework.
8940 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
8941 before the TypeContainers; see 2test-21.cs.
8944 (TypeContainer.DefineType): Don't create a new EmitContext if we
8945 already have one (this only happens if we're an Iterator).
8946 (TypeContainer.Define): Also call Define() on all our iterators.
8947 (Method.CreateEmitContext): Added support for iterators.
8950 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
8951 (AnonymousContainer.CreateMethodHost): Moved here from
8952 AnonymousMethod and made abstract.
8953 (AnonymousContainer.CreateScopeType): New abstract method.
8954 (AnonymousContainer.IsIterator): New public property.
8955 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
8956 get the ScopeTypeBuilder rather than manually defining it here.
8957 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
8960 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
8961 before RootContext.DefineTypes().
8963 * codegen.cs (EmitContext.RemapToProxy): Removed.
8964 (EmitContext.CurrentAnonymousMethod): Changed type from
8965 AnonymousMethod -> AnonymousContainer.
8966 (EmitContext.ResolveTopBlock): Protect from being called twice.
8967 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
8968 (EmitContext.EmitThis): Removed the iterators hacks; use the
8969 anonymous methods framework for that.
8972 (ToplevelBlock.Container): Make this a property, not a field.
8973 (ToplevelBlock.ReParent): New public method; move the
8974 ToplevelBlock into a new container.
8975 (Foreach.TemporaryVariable): Simplify.
8977 2005-06-05 Martin Baulig <martin@ximian.com>
8979 * statement.cs (LocalInfo.CompilerGenerated): New flag.
8980 (Block.AddTemporaryVariable): New public method; creates a new
8981 `LocalInfo' for a temporary variable.
8982 (Block.EmitMeta): Create the LocalBuilders for all the temporary
8984 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
8985 non-iterator variables.
8987 2005-06-05 Martin Baulig <martin@ximian.com>
8989 * statement.cs (Foreach.TemporaryVariable): Create the
8990 LocalBuilder in the Emit phase and not in Resolve since in some
8991 situations, we don't have an ILGenerator during Resolve; see
8992 2test-19.cs for an example.
8994 2005-06-04 Martin Baulig <martin@ximian.com>
8996 **** Merged r45395 from GCS ****
8998 The big Foreach rewrite - Part II.
9000 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
9001 with `PropertyInfo ienumerator_getcurrent'.
9003 * codegen.cs (VariableStorage): Removed.
9006 (Foreach): Derive from Statement, not ExceptionStatement.
9007 (Foreach.CollectionForeach): New nested class. Moved all the code
9008 dealing with collection foreach here.
9009 (Foreach.ForeachHelperMethods): Removed.
9010 (Foreach.TemporaryVariable): Implement IMemoryLocation.
9012 2005-05-23 Martin Baulig <martin@ximian.com>
9014 * statement.cs (Try.DoResolve): Don't create a `finally' if we
9015 don't need to. Fix #75014.
9017 2005-05-20 Martin Baulig <martin@ximian.com>
9019 Merged r44808 from GMCS.
9021 * class.cs (TypeContainer.CircularDepException): Removed.
9022 (TypeContainer.DefineType): Removed the `InTransit' stuff.
9023 (TypeContainer.CheckRecursiveDefinition): Check for circular class
9024 (CS0146) and interface (CS0529) dependencies here.
9026 2005-06-21 Raja R Harinath <rharinath@novell.com>
9028 * expression.cs (Invocation.EmitCall): Fix initialization
9029 'this_call' to reflect current behaviour. Fix indentation.
9031 * convert.cs (FindMostEncompassedType): Add two trivial special
9032 cases (number_of_types == 0 || number_of_types == 1).
9033 (FindMostEncompasingType): Likewise.
9035 2005-06-17 Raja R Harinath <rharinath@novell.com>
9037 Some cleanups preparing for the fix of #75283.
9038 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
9040 (EventExpr.InstanceResolve): Likewise.
9041 (EventExpr.DoResolve): Remove redundant checks.
9043 2005-06-10 Duncan Mak <duncan@novell.com>
9045 * cs-tokenizer.cs (process_directives): New flag for controlling
9046 the processing of preprocessor directives.
9047 (x_token): After seeing a '#', return Token.NONE instead of going
9048 to handle_preprocessing_directive() when not processing
9049 directives. This avoids unnecessary processing during the token peek in
9054 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
9055 the existing error reporting methods instead of Report.Error.
9057 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
9058 after Raja's rewrite.
9060 2005-06-08 Miguel de Icaza <miguel@novell.com>
9062 * class.cs: Small fix.
9064 2005-06-08 Raja R Harinath <rharinath@novell.com>
9067 * class.cs (GetPartialBases): Fix return value check of
9070 2005-06-07 Raja R Harinath <rharinath@novell.com>
9072 Ensure that partial classes are registered in their enclosing
9073 namespace. Initial part of fix of #75160.
9074 * tree.cs (Tree.RecordDecl): Add new namespace argument.
9075 Register declspace with namespace here, not in
9076 DeclSpace.RecordDecl.
9077 * cs-parser.jay: Pass namespace to RecordDecl.
9078 * class.cs (PartialContainer.Create): Likewise.
9079 (ClassPart.DefineType): New sanity-check. Throws an exception if
9081 * decl.cs (Declspace.RecordDecl): Remove.
9082 * namespace.cs (NamespaceEntry.DefineName): Remove.
9084 2005-06-06 Marek Safar <marek.safar@seznam.cz>
9086 * rootcontext.cs: Reset TargetExt as well.
9088 2005-06-03 Raja R Harinath <rharinath@novell.com>
9090 * ecore.cs (Expression.Resolve): Emit CS0654 error when
9093 2005-06-02 Raja R Harinath <rharinath@novell.com>
9095 Fix #75080, cs0119.cs.
9096 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
9098 (Expression.Resolve): ... this. Use it. Remove bogus code
9099 allowing ExprClass.Type and ExprClass.Namespace for
9100 ResolveFlags.VariableOrValue.
9101 (Expression.Resolve) [1-argument variant]: Change default resolve
9102 flags based on language version.
9103 (Expression.Error_UnexpectedKind): Use a simple string array
9104 rather than an ArrayList.
9105 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
9107 (TypeOfVoid.DoResolve): Likewise.
9108 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
9109 flags argument -- it always has the same value.
9111 2005-05-31 Raja R Harinath <rharinath@novell.com>
9114 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
9115 Use it in the error message.
9116 * assign.cs, expression.cs, statement.cs: Update.
9118 2005-05-30 Raja R Harinath <rharinath@novell.com>
9121 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
9122 the "almostMatchedMember" case too.
9123 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
9124 that failed the accessibility checks to 'almost_match'.
9126 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
9128 * attribute.cs: Use internal MethodBuilder methods to set
9129 ExactSpelling and SetLastError on PInvoke methods, instead
9130 of passing them via charset. Fixes #75060.
9132 2005-05-27 Raja R Harinath <rharinath@novell.com>
9134 * parameter.cs (Parameter): Remove TODO comment.
9135 (Parameter.DefineParameter): Remove Location parameter.
9136 (Parameters.LabelParameters): Likewise.
9137 * class.cs (Constructor.Emit): Update to change.
9138 (MethodData.Emit): Likewise.
9139 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
9140 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
9142 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
9145 Removed Parameters.Location and added Parameter.Location instead.
9146 Removed Location parameter from Emit() and GetSignature().
9153 Modified all related calls.
9155 2005-05-26 Raja R Harinath <rharinath@novell.com>
9157 Improve user-defined conversion handling.
9158 * convert.cs (GetConversionOperators): Rewrite. Return only the
9159 applicable operators.
9160 (AddConversionOperators): New. Helper for GetConversionOperators.
9161 (FindMostEncompassedType, FindMostEncompassingType): Verify that
9162 there is only one most encompassed/encompassing type.
9163 (FindMostSpecificSource, FindMostSpecificTarget): Remove
9164 "applicable operator" handling.
9165 (UserConversion): Move cache here from GetConversionOperators.
9166 Directly cache the chosen operator, rather than the whole
9168 (ExplicitNumericConversion): Fix buggy implementation of Decimal
9169 case. Allow conversion of decimal to sbyte and byte too.
9170 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9171 New static methods. Used to avoid allocating EmptyExpressions in
9174 2005-05-24 Duncan Mak <duncan@novell.com>
9176 * ecore.cs (CastFromDecimal): New class for casting a decimal to
9177 another class, used in Convert.ExplicitNumericConversion.
9178 (CastToDecimal): New class, similar to above, but casts to
9179 System.Decimal, used in Convert.ImplicitNumericConversion and also
9180 in explicit convesion from double/float to decimal.
9182 * convert.cs (ImplicitNumericConversion): Handle implicit
9183 conversions to System.Decimal.
9184 (ExplicitNumericConversion): handle explicit conversions to
9189 2005-05-20 Miguel de Icaza <miguel@novell.com>
9191 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
9192 know the type at this stage, just break through. Fixes #75008
9194 2005-05-19 Martin Baulig <martin@ximian.com>
9197 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
9198 to disable error reporting.
9200 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
9201 here since we don't want to report an error; see the new test-336.cs.
9203 2005-05-19 Raja R Harinath <rharinath@novell.com>
9205 * statement.cs (ToplevelBlock.GetParameterReference)
9206 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
9207 Move here from class Block.
9208 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
9209 * expression.cs (ParameterReference.DoResolveBase): Likewise.
9211 2005-05-18 Martin Baulig <martin@ximian.com>
9216 (FlowBranching.Reachability): Add non-static public And() and Or()
9218 (FlowBranchingSwitch): New class; do the `break_origins' thing
9219 like in FlowBranchingLoop.
9220 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
9221 reachability, not just locals and parameters.
9222 (FlowBranching.MergeChild): Remove some of the hacks for loop and
9223 switch; MergeBreakOrigins() now takes care of that.
9225 2005-05-18 Martin Baulig <martin@ximian.com>
9227 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
9228 a loop and may leave it, reset the barrier; fixes #74974.
9230 2005-05-17 Marek Safar <marek.safar@seznam.cz>
9232 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
9235 * cs-parser.jay: Catch more lexical errors.
9237 * report.cs: Add one more Error method.
9240 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
9242 2005-05-17 Martin Baulig <martin@ximian.com>
9244 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
9247 2005-05-16 Raja R Harinath <rharinath@novell.com>
9249 Fix test-382.cs. Emit values of decimal constants.
9250 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
9252 (TypeContainer.AddField): ... this.
9253 (TypeContainer.EmitFieldInitializers): Allow the list of fields
9254 with initializers to include 'Const's.
9255 (ClassPart.RegisterFieldForInitialization): Forward to
9257 * const.cs (Const.Const): Pass initializer to base class.
9258 (Const.Define): In case of decimal constants, register them for
9259 initialization in a static constructor.
9261 2005-05-14 Martin Baulig <martin@ximian.com>
9263 * statement.cs (Block.Resolve): Correctly handle unreachable code;
9264 do not call ResolveUnreachable() on unreachable statements in
9265 here, see the comment in the source code.
9267 2005-05-13 Raja R Harinath <rharinath@novell.com>
9270 * expression.cs (BinaryResolveOperator): If one of the operands of
9271 an equality comparison is 'null' and the other is a pointer type,
9272 convert the null to a NullPointer.
9273 * convert.cs (ImplicitReferenceConversion): If the expression is a
9274 NullLiteral and the target type is a pointer type, return a
9275 NullPointer instead.
9276 (ImplicitConversionStandard): Likewise.
9278 2005-05-13 Marek Safar <marek.safar@seznam.cz>
9280 * cs-parser.jay: Set readonly context based on special constructs.
9282 * expression.cs (LocalVariableReference.DoResolveBase): Improved
9283 readonly variable error handling.
9285 * rootcontext.cs (EmitCode): Don't verify members when error
9288 * statement.cs (LocalInfo): Add reaodnly context information.
9289 (SetReadOnlyContext, GetReadOnlyContext): New methods.
9291 2005-05-13 Raja R Harinath <rharinath@novell.com>
9293 * statement.cs (Block.Resolve): Revert change below. Modify fix
9294 for #74041 to initialize 'resolved' to false only for explicit
9295 blocks. Fixes #74873.
9297 2005-05-12 Raja R Harinath <harinath@gmail.com>
9300 * typemanager.cs (unmanaged_enclosing_types): New.
9301 (IsUnmanagedType): Avoid infloops by using
9302 'unmanaged_enclosing_types' to talk with recursive invocations.
9304 2005-05-13 Martin Baulig <martin@ximian.com>
9306 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
9307 instance variable, not a local. Fix #74873.
9308 (Block.ResolveUnreachable): Set it to true here.
9310 2005-05-11 Duncan Mak <duncan@novell.com>
9312 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
9313 continuing to process for 'arg'.
9314 (handle_preprocessing_directive): Check the argument of the #endif
9315 directive and report error CS1025 if there are any trailing
9318 According to the C# spec, having even whitespace after the #endif
9319 directive is illegal; however, because we call arg.TrimEnd ()
9320 beforehand, we have the same behavior as csc, allowing whitespace
9321 after the directive.
9325 2005-05-11 Marek Safar <marek.safar@seznam.cz>
9329 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
9330 (Constructor.GetObsoleteAttribute): Implemented correctly.
9332 2005-05-10 Martin Baulig <martin@ximian.com>
9334 * support.cs (ReflectionParameters.ParameterModifier): Use
9335 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
9336 and `ParameterAttributes.In'. Fixes #74884.
9338 2005-05-10 Marek Safar <marek.safar@seznam.cz>
9340 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
9342 * expression.cs (Argument.GetParameterModifier): Turned to property.
9343 (Invocation.Error_InvalidArguments): Add more descriptive errors.
9345 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
9348 2005-05-09 Raja R Harinath <rharinath@novell.com>
9351 * decl.cs (MemberCache.AddMethods): Register override methods,
9352 rather than non-override methods.
9353 * typemanager.cs (RegisterOverride): New.
9354 (IsOverride): Update.
9356 2005-05-09 Marek Safar <marek.safar@seznam.cz>
9360 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
9361 recursive declaration.
9363 * statement.cs (Block.ResolveMeta): Report any error in resolving.
9365 2005-05-06 Marek Safar <marek.safar@seznam.cz>
9367 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
9369 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
9371 2005-05-05 Raja R Harinath <rharinath@novell.com>
9374 * decl.cs (DeclSpace.FamilyAccessible):
9375 Use TypeManager.IsNestedFamilyAccessible.
9377 Fix reopened #64812.
9378 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
9381 2005-05-04 Raja R Harinath <rharinath@novell.com>
9382 Abin Thomas <projectmonokochi@rediffmail.com>
9383 Anoob V E <projectmonokochi@rediffmail.com>
9384 Harilal P R <projectmonokochi@rediffmail.com>
9387 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
9388 allow access to all static members.
9390 2005-05-04 Martin Baulig <martin@ximian.com>
9392 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
9394 2005-05-04 Martin Baulig <martin@ximian.com>
9398 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
9399 section at the end; make things work if `default' is not the last
9402 2005-05-04 Martin Baulig <martin@ximian.com>
9406 * statement.cs (Switch): Replaced the `got_default' field with a
9407 `default_section' one.
9408 (Switch.CheckSwitch): Set `default_section' here.
9409 (Switch.Resolve): If we're a constant switch and the constant is
9410 not found, use the default section.
9412 2005-05-03 Martin Baulig <martin@ximian.com>
9414 * expression.cs (ArrayAccess.EmitGetLength): New public method.
9416 * statement.cs (Foreach.ArrayForeach): New nested class.
9417 (Foreach.TemporaryVariable): New nested class.
9418 (Foreach.EmitArrayForeach): Removed; this is now in the new
9421 2005-05-03 Raja R Harinath <rharinath@novell.com>
9423 * pending.cs (BaseImplements): Move the #74773 fix here. This is
9425 (VerifyPendingMethods): Revert change below.
9427 * typemanager.cs (IsOverride, RegisterNonOverride): New.
9428 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
9429 that used to trigger warning -28. Remove warning -28.
9430 * expression.cs (Invocation.OverloadResolve): Use
9431 TypeManager.IsOverride to distinguish override methods.
9434 * pending.cs (VerifyPendingMethods): If a base type implements the
9435 requested interface, don't bother checking individual methods of
9436 the base type. As a side-effect, this prevents the creation of
9437 unnecessary proxies.
9439 2005-05-02 Martin Baulig <martin@ximian.com>
9443 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
9444 Also `And' the locals if the old vector is null.
9445 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
9446 null; in this case we basically reset all the variables.
9448 2005-05-02 Martin Baulig <martin@ximian.com>
9452 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
9453 Added `FlowBranching branching' argument; always `and' the
9454 variables instead of `or'ing them unless we're an infinite loop.
9456 * statement.cs (While.Resolve): Create a new sibling unless we're
9459 2005-05-02 Martin Baulig <martin@ximian.com>
9463 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
9464 arguments; use it instead of creating a new TopLevelBlock.
9465 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
9466 our ConstructorInitializer.
9469 (TopLevelBlock.TopLevelBranching): New public property.
9470 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
9471 and create our `TopLevelBranching'.
9473 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
9474 anonymous method host, use `block.TopLevelBranching' rather than
9475 creating a new branching.
9477 2005-04-20 Miguel de Icaza <miguel@novell.com>
9479 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
9480 a ScopeInfo, if any of the current children is a child of the new
9481 entry, move those children there.
9483 2005-04-30 Martin Baulig <martin@ximian.com>
9485 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
9486 at the beginning of a SwitchSection. Fix #73335.
9488 2005-04-27 Marek Safar <marek.safar@seznam.cz>
9491 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
9493 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
9494 (FieldExpr.DoResolve): Obsolete members are ignored for field
9497 2005-04-26 Marek Safar <marek.safar@seznam.cz>
9499 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
9500 of arrays detection.
9502 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
9504 (Field.VerifyClsCompliance): Volatile fields are not compliant.
9506 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
9509 2005-04-25 Ben Maurer <bmaurer@ximian.com>
9511 * cs-parser.jay: Use the prefered version of -unsafe in error
9514 2005-04-22 Marek Safar <marek.safar@seznam.cz>
9516 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
9519 2005-04-20 John Luke <john.luke@gmail.com>
9521 * driver.cs: fix typo in error message, --outout to --output
9523 2005-04-20 Marek Safar <marek.safar@seznam.cz>
9525 * codegen.cs (InRefOutArgumentResolving): New field.
9527 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
9528 fields outside contructor.
9530 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
9532 2005-04-19 Miguel de Icaza <miguel@novell.com>
9534 * anonymous.cs (CaptureContext.EmitParameterInstance): The
9535 parameter code was not completed ever, so it was not as up-to-date
9536 as local variables. Must finish it.
9538 The bug fix was to compare the Toplevel of the block, not the
9539 current block. Thanks for Ben for pointing this out.
9541 2005-04-19 Raja R Harinath <rharinath@novell.com>
9543 * decl.cs (AddMethods): Use the declaring type of the problem
9544 method to determine if we want to squash a warning.
9546 2005-04-19 Marek Safar <marek.safar@seznam.cz>
9548 * attribute.cs: Removed debug output.
9550 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
9552 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
9555 2005-04-18 Raja R Harinath <rharinath@novell.com>
9558 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
9559 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
9560 all null comparisons against reference types.
9562 2005-04-18 Marek Safar <marek.safar@seznam.cz>
9565 * class.cs (TypeContainer.CircularDepException) New nested
9567 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
9568 (TypeContainer.DefineType): Removed error, reset InTransit before
9570 (Class.DefineType): Throw exception when is in Transit.
9571 Catch exception and report error.
9572 (Struct.DefineType): Throw exception when is in Transit.
9573 Catch exception and report error.
9574 (Interface.DefineType): Throw exception when is in Transit.
9575 Catch exception and report error.
9577 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
9578 handle nested exception handlers.
9580 * flowanalysis.cs (InTryWithCatch): New method, search for try with
9583 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
9584 InFinally and InCatch storage.
9586 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
9587 (Catch.Resolve): Set and Restore ec.InCatch.
9588 (Try.Resolve): Set and Restore ec.InFinally.
9589 (Try.HasCatch): True when try has catch.
9591 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
9593 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
9594 for the same event member, so exclude such cases from warning 419.
9597 2005-04-16 Miguel de Icaza <miguel@novell.com>
9599 * expression.cs (Binary.ResolveOperator): Apply patch from John
9600 Luke to fix bug 59864: operators &, | and ^ on enumerations
9601 require that the same enum type on both sides.
9603 * driver.cs: Add warnings to old flag usage, this is to assist
9604 people who produce Makefiles and hope that the Makefiles will be
9607 * class.cs (TypeContainer.EmitType): Moved the definition of the
9608 special $PRIVATE$ field from the resolve phase to the Emit phase.
9609 During resolve we do not know if we are a struct with
9610 HasExplicitLayout, we know this only after the attributes for the
9613 Set the FieldOffset to zero on the dummy field that we create for
9614 the class. Fixes 74590.
9616 2005-04-16 Raja R Harinath <rharinath@novell.com>
9619 * ecore.cs (PropertyExpr.resolved): New.
9620 (DoResolve): Use it to handle a case of double resolution here.
9621 Handle a case of identical-name-and-type-name.
9622 * expression.cs (ArrayCreation.CheckIndices): Avoid double
9623 resolution by storing the results of expression resolution back
9624 into the "probes" array.
9626 2005-04-15 Raja R Harinath <rharinath@novell.com>
9628 Fix cs0208-7.cs and cs0208-8.cs.
9629 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
9630 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
9631 error reporting to point out the reason a struct is not unmanaged.
9633 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9635 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
9636 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
9638 2005-04-13 Raja R Harinath <rharinath@novell.com>
9641 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
9642 IdenticalNameAndTypeName here.
9643 (EventExpr.InstanceResolve): Likewise.
9645 2005-04-13 Marek Safar <marek.safar@seznam.cz>
9647 C# 2.0 DefaultCharSetAttribute implementation
9649 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
9650 which allows us to set GlobalNamespace for every resolve.
9651 (Attribute.ResolveArguments): Cut from Resolve.
9652 (Attribute.GetCharSetValue): Returns CharSet named argument.
9653 (Attribute.DefinePInvokeMethod): Gets default charset from
9655 (GlobalAttribute.ResolveAsTypeStep): Override.
9656 (GlobalAttribute.ResolveArguments): Override.
9658 * class.cs (TypeAttr): Is protected.
9660 * codegen.cs (ModuleClass.DefaultCharSet): New member.
9661 (ModuleClass.DefaultCharSetType): New memeber.
9662 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
9664 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
9665 charset from module.
9667 * delegate.cs (TypeAttr): Override.
9668 (Delegate.DefineType): Use this TypeAttr.
9670 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
9671 at very early stage (before types are defined) to resolve model
9672 module attributes. It will probably not work with corlib but it
9675 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
9676 charset from module.
9678 * typemanager.cs (default_charset_type): New type.
9680 2005-04-13 Raja R Harinath <rharinath@novell.com>
9682 * decl.cs (MemberCache.AddMethods): Don't warn if
9683 System.Object.Finalize has buggy MethodAttributes.
9685 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
9688 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9690 * doc.cs : detect ambiguous reference to overloaded members.
9691 Fixed bug #71603. MS 1.1 csc does not detect it.
9693 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
9695 * doc.cs : delegates must not be referenced with parameters.
9698 2005-04-12 Miguel de Icaza <miguel@novell.com>
9700 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
9702 2005-04-10 Miguel de Icaza <miguel@novell.com>
9704 * driver.cs (MainDriver): Stop processing if the CLS stage found
9707 (CompilerCallableEntryPoint.InvokeCompiler): Always
9708 reset after execution; Take a TextWriter argument for the
9711 * report.cs: Use the error stream instead of hardcoding stderr.
9713 2005-04-09 Miguel de Icaza <miguel@novell.com>
9715 * class.cs: Reduce code paths to test, too small of an
9716 optimization to make it worth the extra testing. Always perform
9719 2005-04-08 Raja R Harinath <rharinath@novell.com>
9722 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
9723 operators that had errors reported on them.
9725 2005-04-08 Marek Safar <marek.safar@seznam.cz>
9727 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
9729 (Attribute.Resolve): Add named argument type checking.
9731 * class.cs (FixedField.Define): Use IsPrimitiveType
9733 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
9735 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
9736 unsafe parameter types.
9738 * statement.cs (Using.ResolveExpression): Add better error description.
9740 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
9742 2005-04-08 Raja R Harinath <rharinath@novell.com>
9745 * attribute.cs (Attribute.GetAttributeUsage): Resolve
9746 AttributeUsageAttribute in the emitcontext of the attribute class,
9747 not in the emitcontext of the attributable entity it was attached to.
9748 * cs-parser.jay: Use 'current_class', not 'current_container',
9749 when creating a GlobalAttribute.
9751 2005-04-08 Alp Toker <alp@atoker.com>
9753 * pending.cs: The fix to #58413 failed to compile methods implementing
9754 interfaces with/without params modifiers and vice versa, even though
9755 params modifiers aren't part of the signature. Make the modifier check
9756 less strict as in csc.
9758 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
9759 Anoob V E <projectmonokochi@rediffmail.com>
9760 Harilal P R <projectmonokochi@rediffmail.com>
9763 * pending.cs (TypeAndMethods.mods): New. Store the parameter
9764 modifiers of pending methods.
9765 (PendingImplementation.PendingImplementation): Initialize it.
9766 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
9767 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
9768 with ParameterData. Add check for modifiers.
9769 * class.cs (MethodData.Define): Update to changes.
9771 2005-04-07 Raja R Harinath <rharinath@novell.com>
9773 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
9775 2005-04-07 Marek Safar <marek.safar@seznam.cz>
9777 * class.cs (PropertyMethod.Define): Check private accessor in abstract
9780 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
9783 * typemanager.cs: Registered RequiredAttributeAttribute.
9785 2005-04-06 Marek Safar <marek.safar@seznam.cz>
9787 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
9788 Warning CS0169 is back at level 3.
9789 (IMethodData.SetMemberIsUsed): New method.
9791 * decl.cs (IsUsed): New value; moved from FieldBase.Status
9792 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
9794 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
9796 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
9798 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
9801 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
9804 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
9805 to avoid the problems with nested types.
9807 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
9808 Anoob V.E <projectmonokochi@rediffmail.com>
9809 Harilal P.R <projectmonokochi@rediffmail.com>
9810 Raja R Harinath <rharinath@novell.com>
9813 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
9815 * typemanager (GetConstructor): Make public.
9817 2005-04-05 John Luke <john.luke@gmail.com>
9818 Raja R Harinath <rharinath@novell.com>
9821 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
9822 struct too. Return false quicker in a few cases.
9823 (VerifyUnManaged): Use it.
9825 2005-04-05 Raja R Harinath <rharinath@novell.com>
9828 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
9829 not 'unreachable_seen'.
9831 2005-04-04 Marek Safar <marek.safar@seznam.cz>
9833 * attribute.cs (Attribute.GetValue): Removed unused.
9835 * codegen.cs (CodeGen.TrimExt): Removed unused.
9837 * cs-parser.jay (output): Removed unused.
9839 * cs-tokenizer.cs (hex_digits): Removed unused.
9841 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
9843 * expression.cs (Indirection.LoadExprValue): Removed unused.
9844 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
9846 * iterators.cs (Iterator.param_types): Removed unused.
9848 * statement.cs (Goto.block): Removed unused.
9849 (ToplevelBlock.did): Removed unused.
9850 (Switch.ResolveConstantSwitch): Removed unused.
9852 2005-04-01 Ben Maurer <bmaurer@ximian.com>
9854 * rootcontext.cs: Allow mcs to bootstrap with the compilation
9857 2005-04-01 Raja R Harinath <rharinath@novell.com>
9859 Fix #74232 and cs0208-3.cs.
9860 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
9861 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
9862 unmanaged type. Don't use FieldBuilders when 't' is a
9863 TypeBuilder. Use ModFlags and MemberType fields.
9864 * class.cs (MemberBase.member_type): Rename from MemberType.
9865 (MemberBase.MemberType): New property. Determines member_type on
9867 (MemberBase.DoDefine): Don't initialize MemberType here.
9868 (FieldMember.Define): Likewise.
9870 2005-04-01 Marek Safar <marek.safar@seznam.cz>
9873 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
9874 Attributes are emitted there.
9876 2005-04-01 Raja R Harinath <rharinath@novell.com>
9878 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
9879 keyword in 'partial enum' too.
9880 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
9882 Report from Kamil Skalski <nazgul@omega.pl>.
9885 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
9886 have partial containers too.
9888 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
9889 in block' checks to Block.CheckInvariantMeaningInBlock.
9890 * statement.cs (Block.GetKnownVariableInfo): Make private.
9891 (Block.IsVariableUsedInChildBlock): Remove.
9892 (Block.IsVariableUsedInBlock): Likewise.
9893 (Block.CheckInvariantMeaningInBlock): New. Show location of
9894 conflicting declaration.
9895 (Block.AddVariable): Make error messages less long-winded and more
9896 specific. Show location of conflicting declaration.
9897 * parameter.cs (Parameters.Location): New readonly property.
9899 2005-03-31 Raja R Harinath <rharinath@novell.com>
9901 Clean up semantics of invoking ResolveMemberAccess.
9902 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
9903 can have an instance, ensure that we pass in a non-TypeExpression
9904 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
9905 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
9906 argument. Update to changes and simplify.
9907 (FieldExpr.Emitinstance): Remove CS0120 check.
9908 (PropertyExpr.EmitInstance): Likewise.
9909 * expression.cs (Argument.Resolve): Likewise.
9910 (Invocation.DoResolve): Update to changes in semantics of
9913 2005-03-31 Marek Safar <marek.safar@seznam.cz>
9916 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
9919 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
9921 2005-03-31 Raja R Harinath <rharinath@novell.com>
9923 Fix difference in behaviour with commandline invocation.
9924 * driver.cs (Driver.Reset): New.
9925 (CompilerCallableEntryPoint): Call it.
9927 * statement.cs (If.Resolve): Avoid spurious "uninitialized
9928 variable" warnings if the boolean expression failed to resolve.
9930 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
9932 * attribute.cs: Fix the union of several permissions when some of them
9933 are unrestricted (so the result isn't an unrestricted permission set).
9936 2005-03-30 Raja R Harinath <rharinath@novell.com>
9938 * ecore.cs (MemberExpr): New class. Convert from interface
9940 (MemberExpr.ResolveMemberAccess): Refactor and move here from
9941 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
9943 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
9944 (MethodGroupExpr.IsExplicitImpl): Remove.
9945 (Expression.GetFieldFromEvent): Remove.
9946 (SimpleName.MemberStaticCheck): Remove.
9947 (SimpleName.DoSimpleNameResolve): Update to changes.
9948 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
9949 (MemberAccess.IdenticalNameAndTypeName): Remove.
9950 (MemberAccess.error176): Move to MemberExpr.
9951 (MemberAccess.DoResolve): Update to changes.
9952 (BaseAccess.DoResolve): Likewise.
9954 2005-03-30 Marek Safar <marek.safar@seznam.cz>
9956 C# 2.0 Conditional attribute class implementation
9958 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
9959 Analyzes class whether it has attribute which has ConditionalAttribute
9960 and its condition is not defined.
9962 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
9963 (Class.IsExcluded): New method. Search for at least one defined
9964 condition in ConditionalAttribute of attribute class.
9966 2005-03-30 Raja R Harinath <rharinath@novell.com>
9968 * ecore.cs (PropertyExpr): Derive from Expression, not
9969 ExpressionStatement.
9970 (PropertyExpr.EmitStatement): Remove.
9972 2005-03-29 Raja R Harinath <rharinath@novell.com>
9975 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
9976 internal field "value__" of an enum be private. The examples for
9977 "value__" that I found on MSDN all used FieldAttributes.Private.
9979 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
9980 Don't mention IL method attribute names.
9982 Fix #47991. Remove a TODO.
9983 * statement.cs (Block.Toplevel): Make into a field.
9984 (Block.Parameters): Move into ToplevelBlock.
9985 (Block.known_variables): Rename from child_variable_names.
9986 (Block.Block): Remove variants that take Parameters. Initialize
9987 'Toplevel' with the immediately surrounding toplevel block.
9988 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
9989 LocalInfo parameter.
9990 (Block.GetKnownVariableInfo): New.
9991 (Block.IsVariableNameUsedInChildBlock): Update.
9992 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
9993 the block, even though it may not be in scope.
9994 (Block.AddVariable): Remove Parameters parameter. Use
9995 Toplevel.Parameters instead.
9996 (Block.AddConstant): Remove Parameters parameter.
9997 (Block.GetParameterReference): Update to use Toplevel.Parameters.
9998 (Block.IsParamaterReference): Likewise.
9999 (Block.IsLocalParameter): Likewise. Simplify a lot.
10000 (ToplevelBlock.Parameters): New. Moved from Block.
10001 (ToplevelBlock.ToplevelBlock): Update to changes. Always
10002 initialize Parameters to a non-null value.
10003 * cs-parser.jay: Update to changes.
10004 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
10005 simple names that mean different things in the same block. Use
10006 Block.IsVariableNameUsedInBlock.
10008 2005-03-28 Raja R Harinath <rharinath@novell.com>
10010 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
10011 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
10012 GetTypeHandle. It is possible for a reflected type to derive from
10013 a TypeBuilder (e.g., int[] derives from the TypeBuilder
10014 System.Array during mscorlib compilation).
10015 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
10016 contain a method_hash, don't create one either. Don't create a
10017 deep copy of the base cache's method_hash.
10018 (MemberCache.SetupCache): Rename back from DeepCopy.
10019 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
10020 already initialized. If we see an override function, add its
10021 underlying base virtual function to the member_hash too.
10023 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
10025 2005-03-26 Raja R Harinath <harinath@acm.org>
10028 * assign.cs (Assign.DoResolve): When the RHS of an assignment
10029 fails to resolve, ensure that the LHS is still resolved as an
10032 2005-03-25 Raja R Harinath <harinath@acm.org>
10034 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
10036 (Enum.current_ec): Remove.
10037 (Enum.LookupEnumValue): Remove EmitContext argument.
10038 Just uses the one created during DefineType.
10039 (Enum.FindMembers): Update.
10040 * expression.cs (MemberAccess.DoResolve): Update.
10042 2005-03-22 Marek Safar <marek.safar@seznam.cz>
10044 * assign.cs (Assign.DoResolve): Check for CS1717 when
10045 source and target are same (uses Equals).
10047 * expression.cs (LocalVariableReference, ParameterReference,
10048 This): Implemented Equals, GetHashCode.
10050 * statement.cs (Block.GetParameterReference): Removed useless
10053 2005-03-22 Raja R Harinath <rharinath@novell.com>
10056 * statement.cs (Block.AddVariable): Ensure that we skip implicit
10057 blocks before deciding whether the error is cs0136 or cs0128.
10059 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
10060 (using_alias_directive, using_namespace_directive): Pass
10061 MemberName, not an expression to Namespace.UsingAlias and
10063 (MakeName): Use the MemberName of the namespace.
10064 * namespace.cs (Namespace.MemberName): New.
10065 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
10066 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
10068 * decl.cs (MemberName.Name): Make readonly.
10069 (MemberName.FromDotted): New "constructor".
10070 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
10071 (MemberCore.Name): Compute from MemberName on demand.
10072 (MemberCore.SetMemberName): Provide a way to change the
10074 (MemberCore.AddToContainer): Don't take a fullname parameter.
10075 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
10076 fully qualified name of the container to the member name.
10077 (TypeContainer.AddToTypeContainer): Use a fully qualified name
10078 only if the type is a member of the root container.
10079 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
10080 MemberName.Left rather than searching for an embedded ".".
10081 (PartialContainer.CreatePart): Update to changes in RootContext.
10082 (MemberBase.ShortName): Turn into a property. Use
10083 MemberCore.SetMemberName.
10084 (MemberBase.ExplicitInterfaceName): Remove.
10085 (MemberBase.UpdateMemberName): Remove.
10086 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
10087 (PropertyBase.SetMemberName): New override.
10088 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
10089 (Tree.GetDecl): New.
10090 (Tree.AllDecls): Rename from Decls.
10091 * attribute.cs, enum.cs, report.cs: Update to changes.
10092 * driver.cs (MainDriver): Use MemberName.FromDotted on
10093 RootContext.MainClass.
10095 2005-03-21 Marek Safar <marek.safar@seznam.cz>
10097 * class.cs (FixedField.Define): Check for CS1664 and more sanity
10100 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
10102 2005-03-18 Marek Safar <marek.safar@seznam.cz>
10104 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
10105 property accessor modifiers.
10107 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
10108 fixed buffer attribute (CS1716).
10109 (PropertyMethod.HasCustomAccessModifier): When property accessor
10110 has custom modifier.
10112 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
10114 (PropertyExpr.DoResolveLValue): Add CS0272.
10116 2005-03-17 Miguel de Icaza <miguel@novell.com>
10118 * convert.cs: When converting to a pointer, use the proper Conv.U
10119 or Conv.I depending on the source data type.
10121 * cs-tokenizer.cs: Make the size for large decimal constants,
10124 2005-03-17 Martin Baulig <martin@ximian.com>
10126 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
10127 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
10129 2005-03-17 Martin Baulig <martin@ximian.com>
10131 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
10132 to bool so we can return an error condition.
10133 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
10136 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
10138 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
10141 2005-03-16 Raja R Harinath <rharinath@novell.com>
10143 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
10144 Refactor to avoid traversing the list of assemblies, and to avoid
10145 string concatenation.
10146 * typemanager.cs (guid_attr_type): Remove.
10147 (negative_hits, pointers, references): Remove hashes.
10149 (GetConstructedType): New. Uses type_hash to handle constructed
10150 types (arrays, references, pointers).
10151 (GetReferenceType, GetPointerType): Use it.
10152 (GetNestedType): New. Uses type_hash to handle nested types of
10154 (LookupType, LookupTypeDirect): Remove.
10155 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
10156 'types' hash and LookupTypeReflection directly.
10157 (params_string, params_object): Use GetConstructedType.
10158 * namespace.cs (Namespace.cached_types): New. Cache of reflected
10160 (Namespace.Lookup): Use cached_types.
10161 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
10162 provided by old TypeManager.LookupType.
10163 * rootcontext.cs (MakeFQN): Remove.
10164 * decl.cs (DeclSpace.MakeFQN): Likewise.
10165 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
10166 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
10167 TypeManager.GetConstructedType.
10168 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
10170 2005-03-15 Marek Safar <marek.safar@seznam.cz>
10172 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
10175 * cs-parser.jay: Reports CS1527 for any namespace element.
10177 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
10180 * expression.cs (ParameterReference.IsAssigned): Changed error to
10182 (Error_WrongNumArguments): Moved CS0245 detection here.
10184 * statement.cs (Return.Resolve): Add CS1622 report.
10186 2005-03-11 Marek Safar <marek.safar@seznam.cz>
10188 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
10190 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
10192 * attribute.cs expression.cs: Get rid of some allocations.
10194 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
10196 * doc.cs : just eliminate the latest change.
10198 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10200 * doc.cs : commented out the latest change. It breaks xml-030.cs
10202 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10204 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
10205 fail. So invoke CreateType() in FindDocumentedType().
10207 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
10209 * cs-tokenizer.cs : added IsKeyword().
10210 * doc.cs : Detect keyword incorrectly used as identifier.
10211 Allow identifiers prefixed by @.
10213 2005-03-10 Marek Safar <marek.safar@seznam.cz>
10215 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
10216 It caused exception in namespace resolving (again!).
10218 * class.cs (Class.ctor): Removed exit.
10219 (PropertyMethod.ctor): ditto.
10221 * codegen.cs (Codegen.Reset): Reset static data.
10222 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
10224 * cs-tokenizer.cs (Cleanup): Removed.
10226 * driver.cs (GetSystemDir): Rewrote to one line command.
10227 It caused problem with unloaded dynamic modules.
10228 (UnixParseOption): Removed Exit.
10229 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
10230 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
10231 Now can be mcs used as library.
10233 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
10236 * location.cs (Reset): Reset static data.
10238 * namespace.cs (Reset): Reset static data.
10240 * report.cs (Report.Reset): Reset static data.
10242 * rootcontext.cs (RootContext.Reset): Reset static data.
10244 * tree.cs (RootTypes.ctor): Use Location.Null
10246 * typemanager.cs (TypeManager.Reset): Reset static data.
10247 (CoreLookupType): Removed Exit.
10248 (TypeHandle.Reset): Reset static data.
10250 2005-03-10 Raja R Harinath <rharinath@novell.com>
10253 * typemanager.cs (ComputeNamespaces): Import namespaces from
10254 referenced modules too.
10256 2005-03-09 Raja R Harinath <rharinath@novell.com>
10258 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
10261 2005-03-09 Raja R Harinath <rharinath@novell.com>
10263 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
10264 enclosing DeclSpace. This ensures that a name-lookup populates
10265 more caches and there are fewer 'TypeExpression's. Carve out
10266 nested type lookup into ...
10267 (LookupNestedTypeInHierarchy): ... this.
10269 2005-03-09 Raja R Harinath <rharinath@novell.com>
10271 Clean up a few partial-class semantics.
10272 Fixes test-357.cs and cs1618-2.cs.
10273 * cs-parser.jay (struct_declaration): Use 'current_class' as
10274 parent of newly-created struct. Remove call to Register ().
10275 Use 'pop_current_class' to complete handing the current struct.
10276 (interface_declaration): Likewise.
10277 (class_declaration): Likewise.
10278 (enum_declaration): Use 'current_class' as parent of newly created
10280 (delegate_declaration): Likewise.
10281 (pop_current_class): New function. This is used to handle closing
10282 up the 'current_class' and 'current_container', and pointing them
10283 to the enclosing class/container.
10284 (CSharpParser): Initialize 'current_class' too.
10285 * decl.cs (MemberCore): Add check for invariant: a partial
10286 container is not a parsed entity, and thus does not enclose any
10288 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
10289 (DeclSpace.BaseTypeExpr): Use it.
10290 (DeclSpace.LookupType): Add check for invariant.
10291 * class.cs (TypeContainer): Add check for invariant: a nested
10292 class should have the same NamespaceEntry as its enclosing class.
10293 (TypeContainer.EmitFieldInitializers): Make virtual.
10294 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
10296 (TypeContainer.Register): Remove.
10297 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
10298 null. Use TypeResolveEmitContext for resolving base types and
10299 interfaces. Move initialization of Parts.TypeBuilder here from
10301 (TypeContainer.DefineNestedTypes): ... here.
10302 (PartialContainer): Take a Namespace not a NamespaceEntry.
10303 (PartialContainer.Create): Don't use Register. Call the
10304 appropriate Add... function directly.
10305 (ClassPart): Take both the PartialContainer and the enclosing
10306 class as constructor arguments.
10307 (ClassPart.EmitFieldInitializers): Override.
10308 (ClassPart.PartFindNestedTypes): Remove.
10309 (FieldBase.GetInitializerExpression): Resolve the initializer
10310 expression in the emit context of the enclosing class.
10311 * tree.cs (RootTypes): Remove Register ().
10313 2005-03-08 Marek Safar <marek.safar@seznam.cz>
10315 * cs-parser.jay: Removed CS0134.
10317 * driver.cs: Removed CS1901.
10319 * expression.cs (SizeOf.DoResolve): Don't report CS0233
10320 for predefined types.
10322 2005-03-07 Duncan Mak <duncan@novell.com>
10324 * codegen.cs (Save): Catch UnauthorizedAccessException as
10325 well. Fixes bug #73454.
10327 2005-03-07 Marek Safar <marek.safar@seznam.cz>
10329 * cs-tokenizer.cs (xtoken): Add CS1035.
10331 * class.cs (MethodData.Define): Add CS0683.
10332 (FieldMember.ctor): Add CS0681.
10334 2005-03-07 Raja R Harinath <rharinath@novell.com>
10336 * ecore.cs (SimpleName.DoResolve): Rename from
10337 SimpleName.DoResolveAllowStatic.
10338 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
10339 Pass 'intermediate' flag to MemberStaticCheck.
10340 (SimpleName.MemberStaticCheck): Skip "static check" only in case
10341 of "intermediate" lookups via MemberAccess.
10342 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
10343 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
10345 2005-03-07 Raja R Harinath <rharinath@novell.com>
10348 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
10349 slipped in because of variable names that are identical to a
10350 builtin type's BCL equivalent ('string String;', 'int Int32;').
10351 (PropertyExpr.EmitInstance): Likewise.
10353 2005-03-04 Marek Safar <marek.safar@seznam.cz>
10355 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
10357 * report.cs (warning_ignore_table): Made public.
10359 2005-03-04 Raja R Harinath <rharinath@novell.com>
10362 * class.cs (MethodData.Emit): Pass 'container' to
10363 container.GetObsoleteAttribute instead of 'container.Parent'.
10365 2005-03-03 Marek Safar <marek.safar@seznam.cz>
10367 * cs-parser.jay: Add 1534 error test.
10369 * iterators.cs (Yield.CheckContext): Add error 1629.
10370 (Iterator.ctor): Save unsafe modifier.
10371 (MoveNextMethod.DoEmit): Restore unsafe context.
10373 * namespace.cs (UsingAlias): Better error message.
10375 2005-03-03 Dan Winship <danw@novell.com>
10377 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
10378 the warning message [#73219]
10380 2005-03-03 Raja R Harinath <rharinath@novell.com>
10382 Fix compile with MCS 1.0.0.0.
10383 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
10384 w_restore to not depend on string constant folding.
10386 2005-03-03 Raja R Harinath <rharinath@novell.com>
10388 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
10389 CS0246 check to users who passed 'silent = false'.
10390 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
10392 (SimpleName.SimpleNameResolve): Update.
10393 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
10394 (MemberAccess.IdenticalNameAndTypeName): Update.
10395 * doc.cs (FindDocumentedTypeNonArray): Update.
10397 2005-03-03 Raja R Harinath <rharinath@novell.com>
10399 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
10400 * parameters.cs (ComputeAndDefineParameters): Remove.
10401 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
10402 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
10403 Use GetParameterInfo.
10405 2005-03-02 Marek Safar <marek.safar@seznam.cz>
10407 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
10409 2005-03-02 Raja R Harinath <rharinath@novell.com>
10411 Unify DeclSpace.LookupType and DeclSpace.FindType.
10412 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
10413 is in charge of defining nested types on demand.
10414 (DeclSpace.LookupType): Use it when the current_type is a
10415 TypeBuilder. Use LookupTypeDirect for reflected types.
10416 (DeclSpace.FindType): Remove.
10417 (DeclSpace.LookupInterfaceOrClass): Likewise.
10418 (DeclSpace.DefineTypeAndParents): Likewise.
10419 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
10420 DeclSpace.LookupType.
10421 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
10422 * typemanager.cs (LookupType): Simplify.
10423 (AddUserType): Remove type from negative_hits.
10424 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
10425 * class.cs (TypeContainer.FindMembers): Move handling of nested
10427 (TypeContainer.FindMembers_NestedTypes): ... here.
10428 (TypeContainer.FindNestedType): Implement override.
10429 (ClassPart.FindNestedType): Delegate to PartialContainer.
10430 (ClassPart.PartFindNestedType): Looks up the nested types of the
10433 2005-03-02 Martin Baulig <martin@ximian.com>
10435 * class.cs (TypeContainer.DoDefineMembers): We also need a default
10436 static constructor in static classes.
10438 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
10440 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
10441 sizeParamIndex is not specified.
10443 2005-03-01 Marek Safar <marek.safar@seznam.cz>
10446 * report.cs (WarningMessage.IsEnabled): Missing null check.
10448 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10450 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
10451 in the fields and not in the properties.
10453 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
10455 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
10458 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10460 * attribute.cs: Small refactoring (improved robustness).
10461 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
10462 (ValidateGuid): Removed.
10463 (Resolve): Removed referenced to above mentioned.
10464 (GetAttributeUsage): Made private and changed to work without
10466 (GetIndexerAttributeValue): Don't crash.
10467 (GetConditionalAttributeValue): Ditto.
10468 (GetClsCompliantAttributeValue): Ditto.
10469 (ExtractSecurityPermissionSet): All attributes exceptions are
10471 (GetPropertyValue): New helper.
10472 (GetMethodImplOptions): New method.
10473 (DefinePInvokeMethod): Reuse common code. Implemented handling of
10474 some missing properties.
10476 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
10477 (Method.ApplyAttributeBuilder): Updated.
10479 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
10482 2005-02-28 Raja R Harinath <rharinath@novell.com>
10485 * report.cs (Report.SymbolRelatedToPreviousError): Handle
10486 non-simple types (array, pointer, reference).
10488 2005-02-28 Marek Safar <marek.safar@seznam.cz>
10490 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
10492 * class.cs (MethodCore.IsDuplicateImplementation): Special error
10494 (Method.CheckBase): Catch wrong destructor here.
10495 (MethodData.Define): Add errors 550, 668.
10497 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
10499 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
10501 * pending.cs (VerifyPendingMethods): Add error 551.
10503 * typemanager.cs (CSharpName): Next error report helper.
10505 2005-02-25 Marek Safar <marek.safar@seznam.cz>
10507 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
10508 attributes. Removed useless attribute double check.
10509 It saves almost 2MBs for corlib.
10511 2005-02-25 Raja R Harinath <rharinath@novell.com>
10514 * statement.cs (ExpressionStatement.Resolve): Make robust to being
10515 called twice in case of error.
10517 2005-02-23 Chris Toshok <toshok@ximian.com>
10519 Fix compiler portions of #72827.
10520 * statement.cs (Block.Emit): call Begin/EndScope on the
10521 EmitContext instead of the ILGenerator.
10523 * codegen.cs (EmitContext.BeginScope): new method, call
10524 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
10526 (EmitContext.BeginScope): same, but EndScope and CloseScope
10528 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
10529 offset and call the superclass's OpenScope(int) with it.
10530 (SymbolWriter.CloseScope): get the current il
10531 offset and call superclass's CloseScope(int) with it.
10533 2005-02-23 Marek Safar <marek.safar@seznam.cz>
10535 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
10536 CS1677 for out and ref as well.
10538 * class.cs (Method.Define): Add error CS1599 detection.
10540 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
10542 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
10544 * delegate.cs (Delegate.Define): Add error CS1599 detection.
10546 * support.cs.cs (ModifierDesc): New helper method.
10548 2005-02-23 Raja R Harinath <rharinath@novell.com>
10549 Abin Thomas <projectmonokochi@rediffmail.com>
10550 Anoob V E <projectmonokochi@rediffmail.com>
10551 Harilal P R <projectmonokochi@rediffmail.com>
10553 Fix #57851, #72718.
10554 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
10555 MemberLookup (used for error reporting) actually returns a result.
10556 Fix error report number (122, not 112).
10558 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
10559 Anoob V E <projectmonokochi@rediffmail.com>
10560 Harilal P R <projectmonokochi@rediffmail.com>
10563 * pending.cs (PendingImplementation.GetAbstractMethods):
10564 Find NonPublic members too.
10566 2005-02-22 Marek Safar <marek.safar@seznam.cz>
10568 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
10571 * class.cs (MethodCore.CheckMethodAgainstBase):
10572 Add error 239 report.
10574 2005-02-21 Raja R Harinath <rharinath@novell.com>
10577 * expression.cs (Invocation.IsApplicable): Make public.
10578 (Invocation.IsParamsMethodApplicable): Likewise.
10579 * delegate.cs (Delegate.VerifyApplicability): Don't use
10580 Invocation.VerifyArgumentCompat for parameter applicability
10581 testing. Use Invocation.IsApplicable and
10582 Invocation.IsParamsMethodApplicable.
10584 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10586 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
10588 * class.cs (Operator.Define): Add error 217 report.
10590 2005-02-21 Raja R Harinath <rharinath@novell.com>
10592 * namespace.cs (UsingEntry.Resolve): Undo change below.
10594 2005-02-21 Raja R Harinath <rharinath@novell.com>
10597 * ecore.cs (Expression.MemberLookupFailed): Add argument to
10598 disable the error message when the extended MemberLookup also
10600 (Expression.MemberLookupFinal): Update.
10601 (SimpleName.DoSimpleNameResolve): Update.
10602 * expression.cs (MemberAccess.ResolveNamespaceOrType):
10603 Don't use MemberLookupFinal.
10604 (New.DoResolve): Update.
10605 (BaseAccess.CommonResolve): Update.
10607 2005-02-21 Raja R Harinath <rharinath@novell.com>
10610 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
10611 occured previously, don't resolve again.
10613 2005-02-21 Marek Safar <marek.safar@seznam.cz>
10616 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
10617 argument. Call ResolveAttributeUsage for unresolved.
10618 when types doesn't match ctor arguments.
10620 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
10621 for nested attribute classes.
10622 (Class.attribute_usage): Removed.
10623 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
10624 for attribute class.
10626 * ecore.cs (IsAttribute): Removed.
10628 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
10630 * rootcontext.cs (RegisterAttribute): Removed, attributes are
10632 (attribute_types): Removed.
10633 (EmitCode): Global attributes are emited as the latest.
10635 2005-02-18 Marek Safar <marek.safar@seznam.cz>
10637 * class.cs (EmitFieldInitializers): Don't emit field initializer
10638 for default values when optimilization is on.
10640 * constant.cs (Constant.IsDefaultValue): New property.
10642 * driver.cs: Add /optimize handling.
10646 * literal.cs: Implement new IsDefaultValue property.
10648 * rootcontext.cs (Optimize): New field, holds /optimize option.
10650 2005-02-18 Raja R Harinath <rharinath@novell.com>
10652 Fix crasher in re-opened #72347.
10653 * namespace.cs (Namespace.Lookup): Return null if
10654 DeclSpace.DefineType returns null.
10657 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
10659 2005-02-18 Raja R Harinath <rharinath@novell.com>
10661 Fix remainder of #63202. Change semantics of DoResolveLValue: it
10662 now returns null if it cannot resolve to an lvalue.
10663 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
10664 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
10665 returned null. Remove check for SimpleName.
10666 (EventExpr.DoResolveLValue): New.
10667 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
10668 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
10670 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
10671 avoid CS0131 error.
10672 (Unary.ResolveOperator): Move CS0211 check ...
10673 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
10675 (Unary.DoResolveLValue): Simplify.
10676 (AddressOf.DoResolveLValue): New.
10677 (ArrayAccess.DoResolveLValue): New.
10679 2005-02-16 Marek Safar <marek.safar@seznam.cz>
10681 * attribute.cs (Attribute.Resolve): Add arguments casting for
10682 when types doesn't match ctor arguments.
10684 2005-02-16 Raja R Harinath <rharinath@novell.com>
10686 Fix parts of #63202.
10687 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
10688 lookup of operator in base type. Ensure that all checks happen
10689 when the operator resolves to an "op_..." method.
10691 2005-02-15 Raja R Harinath <rharinath@novell.com>
10694 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
10695 'ignore_cs0104' parameter. Pass it to ...
10696 (NamespaceEntry.Lookup): ... this.
10697 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
10698 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
10699 (TypeLookupExpression.DoResolveAsTypeStep): Update.
10700 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
10701 Update. Request that cs0104 errors be ignored.
10702 (ComposedCast.ResolveAsTypeStep): Update.
10704 2005-02-14 Raja R Harinath <rharinath@novell.com>
10707 * expression.cs (Invocation.BetterFunction): Remove support for
10708 comparing virtual functions and their overrides.
10709 (Invocation.IsOverride): New.
10710 (Invocation.OverloadResolve): Don't consider 'override' functions
10711 during candidate selection. Store them in a lookaside list.
10712 If the selected method is a 'virtual' function, use the list to
10713 find any overrides that are closer to the LHS type.
10715 2005-02-14 Marek Safar <marek.safar@seznam.cz>
10717 * expression.cs (New.DoResolve): Add complex core type reduction.
10718 (New.Constantify): Converts complex core type syntax like 'new int ()'
10719 to simple constant.
10721 2005-02-14 Raja R Harinath <rharinath@novell.com>
10723 * decl.cs (EntryType.EntryType): New constructor to create an
10724 updated copy of a cache entry.
10725 (MemberCache.AddMethods): Use it.
10726 (MemberCache.ClearDeclaredOnly): Remove.
10727 (MemberCache.MemberCache): Update.
10729 2005-02-11 Miguel de Icaza <miguel@novell.com>
10731 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
10732 variable. This one is represents the actual low-level declaration
10733 of the method, as opposed to the semantic level `IsStatic'.
10735 An anonymous method which is hosted into a static method might be
10736 actually an instance method. IsStatic would reflect the
10737 container, while MethodIsStatic represents the actual code
10740 * expression.cs (ParameterReference): Use the new MethodIsStatic
10741 instead of IsStatic.
10743 * anonymous.cs (AnonymousMethod.Compatible): Pass the
10744 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
10745 set on the current EmitContext.
10747 * expression.cs (Cast): Overload DoResolveLValue so we can pass
10748 resolve our casted expression as an LValue. This triggers the
10749 proper LValue processing that is later required by Assign.
10753 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
10755 2005-02-11 Marek Safar <marek.safar@seznam.cz>
10757 C# 2.0 Fixed buffer implementation
10759 * anonymous.cs: Update after RegisterHelperClass renaming.
10761 * attribute.cs (AttributeTester.fixed_buffer_cache):
10762 Cache of external fixed buffers.
10763 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
10764 implementation if field is fixed buffer else null.
10767 (TypeContainer.AddField): Accept FieldMember instead of Field.
10768 (FieldBase.IsFieldClsCompliant): Extracted code from
10769 VerifyClsCompliance descendant customization.
10770 (FixedField): New class handles fixed buffer fields.
10771 (FixedFieldExternal): Keeps information about imported fixed
10773 (IFixedField): Make access to internal or external fixed buffer
10776 * cs-parser.jay: Add fixed buffer parsing.
10778 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
10781 * expression.cs (Indirection): Extended implementation to accept
10782 fixed buffer field.
10783 (PointerArithmetic.Emit): Get element from fixed buffer as well.
10784 (ElementAccess.MakePointerAccess): Get type as parameter.
10785 (DoResolve): Add fixed buffer field expression conversion.
10786 (DoResolveLValue): Ditto.
10787 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
10788 (ArrayPtr): Derives from FixedBufferPtr.
10789 (ArrayPtr.Emit): Add extra emit for array elements.
10791 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
10793 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
10794 for compiler generated types.
10795 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
10797 * statement.cs (Fixed): Refactored to be easier add fixed buffer
10798 and consume less memory.
10799 (Fixed.Resolve): Add fixed buffer case.
10801 * typemanager.cs (compiler_generated_attr_ctor,
10802 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
10803 (HasElementType): Add our own implementation to work on every
10806 2005-02-11 Miguel de Icaza <miguel@novell.com>
10808 * anonymous.cs (CaptureContext): Track whether `this' has been
10811 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
10812 only captured `this' if it was implicitly done (instance
10813 methods/variables were used).
10815 * codegen.cs (EmitContext.CaptureThis): New method to flag that
10816 `this' must be captured.
10818 2005-01-30 Miguel de Icaza <miguel@novell.com>
10820 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
10821 is null it means that there has been no need to capture anything,
10822 so we just create a sibling.
10824 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
10826 Just a partial fix. The other half is fairly elusive.
10828 2005-02-10 Raja R Harinath <rharinath@novell.com>
10830 Fix #52586, cs0121-4.cs.
10831 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
10832 and return a hashtable.
10833 (MemberCache.ClearDeclaredOnly): New.
10834 (MemberCache.MemberCache): Update to change. Make a deep copy of
10835 the method_hash of a base type too.
10836 (MemberCache.AddMethods): Adapt to having a deep copy of the base
10837 type methods. Overwrite entries with the same MethodHandle so
10838 that the ReflectedType is correct. The process leaves in base
10839 virtual functions and their overrides as distinct entries.
10840 (CacheEntry): Now a class instead of a struct. It shouldn't alter
10841 matters since it was boxed in a ArrayList before.
10842 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
10844 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
10845 case of a virtual function and its override (choose the overload
10847 (Invocation.OverloadResolve): Avoid 'override' members during
10848 'applicable_type' calculation.
10850 2005-02-09 Raja R Harinath <rharinath@novell.com>
10852 Combine two near-redundant caches.
10853 * typemanager.cs (method_params): Rename from method_internal_params.
10854 (TypeManager.GetParameterData): New. Replace
10855 Invocation.GetParameterData.
10856 (TypeManager.LookupParametersByBuilder): Remove.
10857 * expression.cs (Invocation.method_parameter_cache): Remove.
10858 (Invocation.GetParameterData): Remove.
10860 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
10863 2005-02-08 Raja R Harinath <rharinath@novell.com>
10866 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
10867 TypeManager.multicast_delegate_type is null, resolve it by looking
10868 up "System.MulticastDelegate".
10869 * rootcontext.cs (RootContext.ResolveCore): Simplify.
10871 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
10872 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
10873 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
10876 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
10877 (LabeledStatement.AddReference): New. Set 'referenced'.
10878 (Goto.Resolve): Use it.
10880 2005-02-05 John Luke <john.luke@gmail.com>
10882 * driver.cs: remove duplicate -doc line in Usage ()
10884 2005-02-04 Raja R Harinath <rharinath@novell.com>
10886 * location.cs (Location.AddFile): Fix CS2002 error report.
10888 2005-02-02 Martin Baulig <martin@ximian.com>
10890 * delegate.cs (Delegate.DefineType): Report an internal error if
10891 TypeManager.multicast_delegate_type is null. See bug #72015 for
10894 2005-02-02 Raja R Harinath <rharinath@novell.com>
10896 Fix a crasher in a variant of #31984.
10897 * const.cs (Constant.CheckBase): New override that defers the
10898 new-or-override check in case the base type hasn't been populated
10900 (Constant.Define): Ensure the new-or-override check is performed.
10902 2005-02-01 Duncan Mak <duncan@ximian.com>
10904 * const.cs (LookupConstantValue): Check that `ce' is not null
10905 before calling GetValue ().
10907 2005-02-01 Raja R Harinath <rharinath@novell.com>
10909 Fix test-334.cs (#69519).
10910 * cs-parser.jay (using_alias_directive): Pass in an expression to
10911 NamespaceEntry.UsingAlias.
10912 (using_namespace_directive): Pass in an expression to
10913 NamespaceEntry.Using.
10914 (namespace_name): Don't flatten to a string.
10915 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
10916 (NamespaceEntry.AliasEntry.Resolve): Lookup using
10918 (NamespaceEntry.UsingEntry): Likewise.
10919 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
10921 (NamespaceEntry.LookupForUsing): Remove.
10922 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
10924 (NamespaceEntry.Lookup): Remove support for dotted names.
10926 2005-02-01 Raja R Harinath <rharinath@novell.com>
10928 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
10930 (NamespaceEntry.ImplicitParent): Compute on demand.
10931 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
10932 parallels the current.
10933 (NamespaceEntry.LookupForUsing): Use it.
10934 (NamespaceEntry.Lookup): If the current namespace-entry is
10935 implicit, don't search aliases and using tables.
10937 2005-02-01 Raja R Harinath <rharinath@novell.com>
10940 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
10942 (TypeContainer.BaseCache): Compute on demand.
10943 (TypeContainer.FindMembers): Define constants and types if they're
10944 not already created.
10945 (FieldMember.Define): Move resetting of ec.InUnsafe before error
10947 * const.cs (Constant.Define): Make idempotent.
10949 2005-01-29 Miguel de Icaza <miguel@novell.com>
10951 * pending.cs: Produce better code (no nops produced by using Ldarg
10954 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
10955 i - 1' it should be arg + 1.
10959 2005-01-28 Raja R Harinath <rharinath@novell.com>
10961 * attribute.cs (Attribute.CheckAttributeType): Make private
10963 (Attribute.ResolveType): Make virtual.
10964 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
10965 handling of RootContext.Tree.Types.
10967 2005-01-27 Raja R Harinath <rharinath@novell.com>
10969 Update attribute-handling to use the SimpleName/MemberAccess
10971 * cs-parser.jay (attribute): Pass in an expression to the
10972 constructors of Attribute and GlobalAttribute.
10973 * attribute.cs (Attribute): Take an expression for the name.
10974 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
10975 passed in attribute name expression.
10976 (Attribute.CheckAttributeType): Use it.
10977 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
10978 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
10979 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
10980 argument to prevent error messages if the lookup fails.
10982 2005-01-27 Marek Safar <marek.safar@seznam.cz>
10984 * expression.cs (Indirection): Implemented IVariable interface
10985 to support indirection in AddressOf operator.
10986 (PointerArithmetic.Emit): Add optimalization for case where
10987 result can be precomputed.
10989 2005-01-26 Martin Baulig <martin@ximian.com>
10991 * class.cs (TypeContainer.AttributeTargets): Return the correct
10992 AttributeTargets depending on our `Kind' instead of throwing an
10993 exception; fixes #71632.
10995 2005-01-26 Marek Safar <marek.safar@seznam.cz>
10998 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
11001 2005-01-25 Raja R Harinath <rharinath@novell.com>
11004 * expression.cs (MemberAccess.DoResolve): Don't complain with
11005 cs0572 when the LHS of a member access has identical name and type
11008 2005-01-25 Marek Safar <marek.safar@seznam.cz>
11011 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
11013 Create custom PermissionSet only for PermissionSetAttribute.
11015 2005-01-24 Marek Safar <marek.safar@seznam.cz>
11018 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
11019 delegates in static class.
11021 2005-01-24 Martin Baulig <martin@ximian.com>
11023 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
11024 merging an implicit block, just use its reachability.
11026 * statement.cs (Block.Resolve): Make the unreachable code check
11027 work wrt. implicit blocks; see test-337 from #63842.
11029 2005-01-21 Alp Toker <alp@atoker.com>
11031 * cs-parser.jay: destructor_declaration's container is PartialContainer
11032 not Class when partial types are used, so use Kind prop instead of
11035 2005-01-22 Miguel de Icaza <miguel@ximian.com>
11037 * cs-parser.jay: Improve error reporting when an interface
11038 declares new types.
11040 2005-01-20 Dick Porter <dick@ximian.com>
11042 * support.cs: SeekableStreamReader fix from Sandor Dobos
11043 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
11044 chars are read. Fixes bug 70369.
11046 2005-01-20 Raja R Harinath <rharinath@novell.com>
11048 * cs-parser.jay (catch_clause): Simplify current_block handling
11051 2005-01-17 Miguel de Icaza <miguel@ximian.com>
11053 * convert.cs (ImplicitStandardConversionExists): Synchronize the
11054 code with ImplicitStandardConversion to handle the implicit
11055 conversion of method groups into valid delegate invocations.
11057 The problem is that in parameter handling we were using this code
11058 path. Fixes bug #64698
11060 2005-01-19 Raja R Harinath <rharinath@novell.com>
11062 * cs-parser.jay: Fix several infelicities.
11063 - Avoid assigning to the parser value stack. Code like
11064 '$3 = null' is unclean. Synthesize a value for the code block
11066 - Avoid using oob_stack for storing location information. Use ...
11067 (_mark_): ... this. New (empty) rule. Saves the current location
11069 (foreach_statement): Avoid using oob_stack for current_block
11070 handling. Use technique used in for_statement and
11071 using_statement. Synthesize a value for the code block to store
11072 additional intermediate information.
11074 2005-01-13 Miguel de Icaza <miguel@ximian.com>
11076 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
11077 of a different type is only allowed to private fields of a
11078 containing type, not on fields of a base class.
11080 See test-174.cs and error cs0122-9.cs
11082 2005-01-13 Raja R Harinath <rharinath@novell.com>
11084 Fix test-335.cs (bug #58126).
11085 * cs-parser.jay (argument): Split out non-expression parts of the
11086 rule into 'non_simple_argument'.
11087 (invocation_expression): Support parenthesized invocations with
11088 multiple arguments, and with single non-simple arguments.
11090 2005-01-13 Raja R Harinath <rharinath@novell.com>
11092 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
11095 2005-01-12 Raja R Harinath <rharinath@novell.com>
11097 Fix cs0038-1.cs, cs1640-6.cs.
11098 * ecore.cs (Expression.Resolve): Remove special-case for
11099 SimpleName in error-handling.
11100 (Expression.almostMatchedMembers): Relax access permission to
11102 (Expression.MemberLookupFailed): Handle duplicates in
11103 almostMatchedMembers list.
11104 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
11105 * expression.cs (New.DoResolve): Report CS1540 for more cases.
11106 * typemanager.cs (GetFullNameSignature): Use the MethodBase
11107 overload if the passed in MemberInfo is a MethodBase.
11109 2005-01-12 Marek Safar <marek.safar@seznam.cz>
11112 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
11113 for non-CAS & merge permission sets properly.
11115 2005-01-11 Raja R Harinath <rharinath@novell.com>
11117 Improve standard-compliance of simple name and member access
11118 resolution. Fixes bugs #52697, #57200, #67520, #69519.
11119 * ecore.cs (FullNamedExpression): New abstract base class
11120 for Namespaces and TypeExpressions.
11121 (ResolveFlags.SimpleName): Remove.
11122 (SimpleName): Remove support for dotted names.
11123 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
11124 DeclSpace.FindType and DeclSpace.LookupType.
11125 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
11126 (Expression.ExprClassName): Make member function.
11127 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
11128 a namespace. Remove creation of dotted "SimpleName"s.
11129 (MemberAccess.DoResolve): Likewise.
11130 * decl.cs (DeclSpace.Cache): Make private.
11131 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
11132 (DeclSpace.FindType): Update.
11133 (DeclSpace.LookupType): Move here from RootContext. Return a
11134 FullNamedExpression.
11135 * namespace.cs (Namespace): Derive from FullNamedExpression
11136 so that it can be part of expression resolution.
11137 (Namespace.Lookup): Return an FullNamedExpression.
11138 (NamespaceEntry.LookupAlias): Lookup aliases only in current
11140 * rootcontext.cs (NamespaceLookup): Remove.
11141 (LookupType): Move to DeclSpace.
11142 * attribute.cs (CheckAttributeType): Update.
11143 * doc.cs (FindDocumentedType): Remove allowAlias argument.
11144 (FindDocumentedTypeNonArray): Likewise.
11146 2005-01-11 Raja R Harinath <rharinath@novell.com>
11148 Fix cs0509.cs, cs1632.cs.
11149 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
11150 is the same as IsInterface.
11151 (TypeContainer.GetClassBases): Likewise.
11152 * statement.cs (LabeledStatement.ig): New field.
11153 (LabeledStatement.LabelTarget): Save ILGenerator which created the
11155 (LabeledStatement.DoEmit): Check that the label was created with
11156 the same ILGenerator.
11158 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11161 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
11162 accessors to its properties.
11164 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
11165 from accessors to property.
11167 2005-01-10 Marek Safar <marek.safar@seznam.cz>
11170 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
11171 only for overrides.
11173 2005-01-08 Miguel de Icaza <miguel@ximian.com>
11175 * attribute.cs: Check for null and empty strings.
11177 I have lost another battle to Paolo.
11179 2005-01-07 Marek Safar <marek.safar@seznam.cz>
11182 * class.cs (PropertyMethod): Set Parent field in ctors.
11183 (SetMethod.InternalParameters): Add unsafe switch hack.
11184 Override MarkForDuplicationCheck where it is appropriate.
11186 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
11187 It says whether container allows members with the same name.
11188 Base default is no.
11189 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
11190 Removed is_method parameter.
11192 2005-01-06 Duncan Mak <duncan@ximian.com>
11194 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
11195 because the previous change led to incorrect reporting of CS1032
11196 ("Cannot define/undefine preprocessor symbols after first token in
11197 file"). Instead of using `tokens_seen' as the only flag that
11198 triggers CS1040, introduce `comments_seen'. This new flag is used
11199 to signify having seen comments on the current line, so it is
11200 unset after a newline.
11202 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11204 * doc.cs : When searching for a type, find nested type too.
11205 This fixes bug #71040.
11207 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
11210 - Warn missing member comment on those classes which also does not
11211 have doc comments. Fixed bug #71041.
11212 - Don't warn missing doc comment on default constructor.
11215 2005-01-06 Duncan Mak <duncan@ximian.com>
11217 * cs-tokenizer.cs (xtoken): After handling traditional C-style
11218 comments, set `tokens_seen' to true. This allows us to detect
11219 misplaced preprocessor directives (i.e. not at the beginning of
11220 the a line, nor after whitespaces). In that case, report error
11221 CS1040. This fixes bug #56460.
11223 * cs-parser.jay (interface_member_declaration): Add checks for
11224 IsExplicitImpl, and report CS0541 error if an interface member is
11225 defined as an explicit interface declaration.
11227 2005-01-06 Marek Safar <marek.safar@seznam.cz>
11230 * class.cs (PropertyMethod): Set Parent field in ctors.
11231 (SetMethod.InternalParameters): Add unsafe switch hack.
11233 * decl.cs (MemberCore.Parent): Cannot be readonly.
11235 2005-01-06 Raja R Harinath <rharinath@novell.com>
11237 * decl.cs (DeclSpace.ResolveType): Remove.
11238 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
11239 Merge in code from ...
11240 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
11241 * class.cs, enum.cs: Update to changes.
11243 2005-01-06 Miguel de Icaza <miguel@ximian.com>
11245 * anonymous.cs: Ensure that we init the scope of our parent if it
11246 has not been initialized yet.
11248 2004-12-30 Duncan Mak <duncan@ximian.com>
11250 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
11251 if field.FieldBuilder is null. Fixes #70758.
11253 * convert.cs: Fixed some typos and updated some of the comments.
11254 (ImplicitStandardConversionExists):
11255 (TryImplicitIntConversion): If `target_type' is an interface and
11256 the type of `ic' implements this interface, return true or a new
11257 BoxedCast instead of null. This fixes #70468.
11259 2004-12-29 Duncan Mak <duncan@ximian.com>
11261 * expression.cs (Argument.Emit): Check that Expr is
11262 IMemoryLocation before casting to it, and report CS1510 otherwise.
11266 2004-12-21 Ben Maurer <bmaurer@ximian.com>
11268 * statement.cs (Block.ThisVariable): remove the recursion here, to
11269 make the --profile more sane.
11271 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
11273 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
11274 assembly, by JB Evain.
11276 2004-12-17 Raja R Harinath <rharinath@novell.com>
11278 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
11279 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
11280 "parent" refers to enclosing type/class. "base" refers to superclass.
11282 2004-12-17 Raja R Harinath <rharinath@novell.com>
11284 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11285 Ensure that we only have GlobalAttributes.
11286 * attribute.cs (Attribute.Emit): Make non-virtual.
11287 (GlobalAttribute.Emit): Remove.
11288 (Attribute.Resolve): Make virtual.
11289 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
11290 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
11291 the argument. Don't create one.
11292 (Attribute.GetObsoleteAttribute): Likewise.
11293 (Attribute.GetClsCompliantAttributeValue): Likewise.
11294 * class.cs, decl.cs: Update to changes.
11296 2004-12-17 Marek Safar <marek.safar@seznam.cz>
11298 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
11300 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
11302 * statement.cs (Foreach.Resolve): Add error 186 report.
11304 2004-12-16 Marek Safar <marek.safar@seznam.cz>
11306 * expression.cs (Conditional.DoResolve): Add warning 429.
11308 * statement.cs (If.Resolve): Add warning 665.
11310 2004-12-16 Raja R Harinath <rharinath@novell.com>
11312 New invariant: RootContext.Tree.Types.NamespaceEntry == null
11313 except when in the parser, and in GlobalAttribute.
11314 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
11315 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
11316 RootContext.Tree.Types.NamespaceEntry once work is done.
11317 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
11318 and resets RootContext.Tree.Types.NamespaceEntry.
11320 2004-12-15 Marek Safar <marek.safar@seznam.cz>
11322 * cs-parser.jay: Don't create a block for every variable.
11324 2004-12-14 Miguel de Icaza <miguel@ximian.com>
11326 * location.cs: Provide extra information.
11328 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
11329 variables from the captured environment, it is the ldarg_0.
11331 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11333 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
11336 * class.cs: Changed warning level for 169 to avoid developer
11337 displeasure from warning flooding. It will be changed back when they
11338 fix most of current BCL warnings.
11340 * RootContext.cs: Pushed default WarningLevel to 3.
11342 * statement.cs: Removed unused variable.
11344 2004-12-14 Marek Safar <marek.safar@seznam.cz>
11346 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
11347 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
11348 Add error 502 report.
11349 (StaticClass.DefineType): Add error 441 report.
11350 (Class.AllowedModifiersProp): New virtual property as temporary
11351 extension to AllowedModifiers.
11352 (Class.DefineType): Add error 418 report. Moved ModFlags check here
11353 to share implementation with StaticClass and don't call virtual
11356 * driver.cs (MainDriver): Add error 1558 test.
11358 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
11359 report. Moved error 36 test here.
11361 * statement.cs (Throw.Resolve): Add error 724 report.
11363 * typemanager.cs: Add out_attribute_type core type.
11365 2004-12-13 Marek Safar <marek.safar@seznam.cz>
11367 * class.cs (TypeContainer.VerifyClsCompliance): Add error
11369 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
11371 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
11374 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
11376 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
11377 Add error 3023 report.
11378 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
11380 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
11383 2004-12-12 John Luke <john.luke@gmail.com>
11385 * driver.cs (AddArgs): take -- into account when
11386 adding arguments, fixes bug 65710
11388 2004-12-12 Martin Baulig <martin@ximian.com>
11390 * expression.cs (Unary.TryReduceNegative): Added support for
11391 SByteConstant and ByteConstant.
11392 (Unary.Reduce): Check error values from TryReduceNegative().
11394 2004-12-10 Marek Safar <marek.safar@seznam.cz>
11396 * attributes.cs (Attribute.Resolve): Avoid multiple error report
11397 and report exception as error 182.
11399 2004-12-10 Raja R Harinath <rharinath@novell.com>
11401 * driver.cs (Main): Fix message when there are warnings.
11403 2004-12-09 Miguel de Icaza <miguel@ximian.com>
11405 * delegate.cs: Fixed my fix from yesterday, sorry about that.
11407 2004-12-09 Marek Safar <marek.safar@seznam.cz>
11409 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
11410 Reduced number of warnings.
11412 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
11414 2004-12-08 Miguel de Icaza <miguel@ximian.com>
11416 * driver.cs: Removed message.
11418 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
11420 2004-12-08 <vargaz@freemail.hu>
11422 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
11424 2004-12-08 Martin Baulig <martin@ximian.com>
11426 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
11427 instead of a CS3002 for properties and indexer.
11429 2004-12-08 Martin Baulig <martin@ximian.com>
11431 * decl.cs (MemberName.ToString): Make this work again.
11433 2004-12-08 Marek Safar <marek.safar@seznam.cz>
11435 * attribute.cs (Resolve): Add error 591 detection.
11437 * class.cs (FieldMember.Define): Add error 1547 detection.
11438 (Indexer.Define): Add error 620 detection.
11439 (Operator.Define): Add error 590 detection.
11441 * ecore.cs: Missing argument for error 79.
11443 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
11446 2004-12-07 Marek Safar <marek.safar@seznam.cz>
11449 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
11452 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
11454 * cs-parser.jay : handle doc comments on implicit/explicit operators.
11455 Some operator comments were suppressed.
11456 * doc.cs : Implicit/explicit operator name in doc comments are like
11457 "op_Explicit(type)~returnType", so added suffix handling.
11459 2004-12-07 Martin Baulig <martin@ximian.com>
11462 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
11463 (MemberCore.GetClsCompliantAttributeValue): Likewise.
11464 (DeclSpace.ec): New protected field; store the EmitContext here.
11465 (DeclSpace.EmitContext): New public property; moved here from
11467 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
11470 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
11471 (Enum.Emit): Don't create a new EmitContext.
11473 * delegate.cs (Delegate.DefineType): Always create the
11476 * iterators.cs (Iterators.DefineIterator): Create a new
11477 EmitContext and store it in `ec'.
11479 2004-08-24 Martin Baulig <martin@ximian.com>
11482 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
11483 this for accessibility checks.
11484 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
11485 IsNestedFamilyAccessible.
11486 (TypeManager.IsSubclassOf): New method, do what the name actually
11489 2004-12-06 Raja R Harinath <rharinath@novell.com>
11491 Fix crash on cs0657-17.cs.
11492 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
11493 Use RootContext.Tree.Types, not 'new RootTypes ()'.
11494 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
11495 the case where the NamespaceEntry gets overwritten.
11497 2004-12-06 Marek Safar <marek.safar@seznam.cz>
11499 Fixed #69195, #56821
11500 * ecore.cs (ResolveBoolean): Tiny refactoring.
11502 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
11503 of right expression resolving when left is false constant and
11504 operator is LogicalAnd OR true constant and operator is LogicalOr.
11506 * statement.cs (ResolveUnreachable): Always reports warning.
11508 2004-12-05 Miguel de Icaza <miguel@ximian.com>
11510 * class.cs: Distinguish between 1721 and 1722 (just a little help
11511 for the programmer).
11513 2004-12-03 Miguel de Icaza <miguel@ximian.com>
11515 * delegate.cs: Only allow this on new versions of the language.
11517 2004-12-02 Duncan Mak <duncan@ximian.com>
11519 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
11521 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
11522 here as a static method. Take an additional bool out parameter
11523 `must_do_cs1540_check' for signaling to InstanceResolve.
11524 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
11525 member field from PropertyExpr class and made it an argument of
11526 the method instead.
11527 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
11528 check for MarshalByRefObject, and report CS0122 instead of CS1540.
11529 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
11530 and `remove_accessor' as well as InstanceResolve: report CS0122
11535 2004-12-03 Raja R Harinath <rharinath@novell.com>
11537 Fix test-327.cs, test-328.cs, and put in early infrastructure
11538 for eventually fixing #52697.
11539 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
11540 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
11541 from other methods.
11542 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
11543 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
11544 (VerifyUsing, error246): Update.
11545 * rootcontext.cs (RootContext.NamespaceLookup): Just use
11546 'NamespaceEntry.LookupNamespaceOrType'.
11548 2004-12-03 Martin Baulig <martin@ximian.com>
11550 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11551 method as our child, call AnonymousMethod.Compatible() on it.
11553 2004-12-03 Raja R Harinath <rharinath@novell.com>
11555 Disable XML documentation support in 'basic' profile.
11556 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
11557 Redirect XmlElement to System.Object.
11558 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
11559 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
11560 * mcs.exe.sources: Add doc-bootstrap.cs.
11561 * doc-bootstrap.cs: New file. Contains empty stub implementation
11564 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
11566 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
11567 comments are allowed.
11569 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11571 * delegate.cs: Add checks for subtypes in paramaters and return values
11572 in VerifyMethod () to add support for Covariance/Contravariance
11575 2004-12-02 Miguel de Icaza <miguel@ximian.com>
11577 * report.cs: Remove extra closing parenthesis.
11579 * convert.cs (Error_CannotImplicitConversion): If the name of the
11580 types are the same, provide some extra information.
11582 * class.cs (FieldBase): Use an unused bit field from the field to
11583 encode the `has_offset' property from the FieldMember. This saves
11584 a couple of Ks on bootstrap compilation.
11586 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
11587 method as our child, return the AnonymousMethod resolved
11590 * expression.cs (New.DoResolve): Allow return values from
11591 NewDelegate to also include AnonymousMethods.
11595 2004-12-02 Marek Safar <marek.safar@seznam.cz>
11598 * attribute.cs (Resolve): Improved implementation of params
11599 attribute arguments.
11601 * support.cs (ParameterData): Add HasParams to be faster.
11603 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
11605 all things are for /doc support:
11607 * doc.cs: new file that supports XML documentation generation.
11608 * mcs.exe.sources: added doc.cs.
11610 Handle /doc command line option.
11611 Report error 2006 instead of 5 for missing file name for /doc.
11612 Generate XML documentation when required, after type resolution.
11614 Added support for picking up documentation (/// and /** ... */),
11615 including a new XmlCommentState enumeration.
11617 Added lines to fill Documentation element for field, constant,
11618 property, indexer, method, constructor, destructor, operator, event
11619 and class, struct, interface, delegate, enum.
11620 Added lines to warn incorrect comment.
11622 Added Documentation field (passed only when /doc was specified).
11624 Added DocComment, DocCommentHeader, GenerateDocComment() and
11625 OnGenerateDocComment() and some supporting private members for
11626 /doc feature to MemberCore.
11628 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
11630 Added overriden DocCommentHeader.
11632 Added overriden DocCommentHeader and GenerateDocComment().
11634 2004-12-01 Miguel de Icaza <miguel@ximian.com>
11636 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
11637 unwrapping the enumeration values, chain to
11638 DoConstantNumericPromotions again, so we can promote things to the
11639 fundamental types (takes care of enums that are bytes, sbytes).
11643 2004-12-01 Raja R Harinath <rharinath@novell.com>
11645 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
11646 Fix long-standing bug in type-lookup. Use FindType instead of
11647 LookupType when ec.ResolvingTypeTree.
11648 (Attribute.ResolveType, Attribute.Resolve)
11649 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
11651 (Attributes.Search): Remove internal version. Update.
11652 (Attributes.SearchMulti): Update.
11653 (Attributes.GetClsCompliantAttribute): Remove.
11654 (Attributes.GetIndexerNameAttribute): Remove.
11655 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
11656 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
11657 * class.cs (Indexer.Define): Likewise.
11659 2004-12-01 Marek Safar <marek.safar@seznam.cz>
11662 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
11663 MarshallByReference members access.
11665 * expression.cs: Use CheckMarshallByRefAccess;
11666 Better error CS0197 message.
11668 * report.cs: Print whole related error message.
11670 2004-11-30 Raja R Harinath <rharinath@novell.com>
11672 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
11673 the current directory to help debugging.
11675 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11677 * class (GetClassBases): Better error 60 report.
11678 (EventProperty): Disabled warning 67 detection.
11680 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11683 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
11685 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
11688 2004-11-29 Marek Safar <marek.safar@seznam.cz>
11691 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
11693 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
11695 2004-11-26 Miguel de Icaza <miguel@ximian.com>
11697 * attribute.cs (Attribute.Resolve): Refine error reporting and
11698 report a cs0117 if the identifier does not exist, to distinguish
11699 from 0617 which is a miss-use of the actual identifier.
11701 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
11702 between cs0070 and cs0079.
11704 * class.cs (MemberBase.DoDefine): When reporting a wrong
11705 accessibility level, we use MethodCore to compare instead of
11706 Method (this was a regression in some refactoring effort).
11708 So now we correctly report cs0056 again.
11710 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
11711 testing the target_type (which was known to be object_type) and
11712 not the source type (which is anonymous_method).
11714 Fixed reporting of error cs1660.
11716 * expression.cs (UserCast.Source): Expose the underlying cast.
11718 * statement.cs (Switch.SwitchGoverningType): Sort the list of
11719 allowed types to find a match to int32 first (most common).
11721 In addition, it ignores any ImplicitUserConversions that did an
11722 internal implicit conversion (as the switch statement allows only
11723 one integral conversion to exist).
11725 * class.cs (PartialContainer.Create): rename `name' to
11726 `member_name' for clarity. Then replace the string calls with a
11727 call to MemberName.GetPartialName, as now using
11728 MemberName.ToString is an error (this is due to the side effects
11729 it had, that were fixed in the past).
11731 This will restore the error reporting on a number of partial class
11732 errors that were missusing this (and getting an exception as a
11733 results, which is now just a plain textual warning, because
11734 yyparse debug output would crash otherwise).
11736 2004-11-26 Raja R Harinath <rharinath@novell.com>
11738 * Makefile (PROGRAM_INSTALL_DIR): Remove.
11740 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11742 * rootcontext.cs (LookupType): Make sure to cache lookups that
11743 don't give us a negative result. This saves about 5% of corlib
11746 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11748 * report.cs (AbstractMessage.Print): messages are sent to stderr
11750 * class.cs (TypeContainer.GetClassBases): It is an error to have a
11751 non-interface in the list of interfaces (at this point, either
11752 parent was properly set, or a base class is being listed in the
11753 interfaces section).
11755 This flags error 1722, and resolves the crash from bug 69259.
11757 2004-11-25 Ben Maurer <bmaurer@ximian.com>
11759 * statement.cs (Using.EmitExpressionFinally): make this work right
11760 for valuetypes. Fixes 69926.
11762 2004-11-25 Miguel de Icaza <miguel@ximian.com>
11764 * const.cs (Const.ChangeType): Cope with the "0 literal can be
11765 converted to an enum" here, before we try to change the underlying
11766 type. This code exists, but it is a different code path than the
11767 one used while encoding constants.
11769 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
11770 old bug: when converting from the null literal to a pointer,
11771 return an EmptyCast, not the NullLiteral.
11773 This fixes #69921, the recent null_type changes probably made this
11774 bug more prominent.
11776 (ImplicitReferenceConversionExists): In addition, resynchronized
11777 the code here, so it matches the same code in
11778 ImplicitReferenceConversionExists for the `from any class-type S
11779 to any interface-type T'.
11782 2004-11-25 Marek Safar <marek.safar@seznam.cz>
11784 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
11786 2004-11-24 Miguel de Icaza <miguel@ximian.com>
11788 * cs-parser.jay: Use verbosity accordingly.
11790 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11792 * expression.cs (Unary.ResolveOperator): Do not report warning;
11793 AddressOf reads from variable.
11795 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
11797 2004-11-24 Marek Safar <marek.safar@seznam.cz>
11801 * attribute.cs (Attributable): Removed CheckTargets.
11802 (Attributes.Emit): Explicit attribute targets are tested here.
11804 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
11805 not enabled for interfaces.
11807 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
11808 (GetAssemblyName): Ouch next bug there.
11810 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11812 * expression.cs: Error 275 added.
11814 2004-11-23 Marek Safar <marek.safar@seznam.cz>
11816 Fix bug #69177 (Implemented decimal constant support)
11818 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
11819 (BinaryFold): Add DecimalConstant.
11821 * const.cs (Define): Decimal constant
11823 (ChangeType): Add decimal type handling.
11824 (LookupConstantValue): Don't set value for decimal type but
11825 emit DecimalConstantAttribute. Needed for constant optimization.
11827 * constant.cs (ToDecimal): New method.
11828 (ConvertToDecimal): New method.
11829 (IntConstant): Implemented ConvertToDecimal.
11830 (DecimalConstant.Emit): Emit optimized version for decimals in
11833 * expression.cs (ResolveOperator): Changed order of constant
11834 reduction to work correctly with native types which have
11835 overloaded operators.
11836 (ResolveMemberAccess): Extract constant value from attribute
11839 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
11841 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
11842 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
11843 (ChangeType): Decimal is special.
11844 (TypeToCoreType): Add decimal type.
11846 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11848 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
11851 2004-11-22 Marek Safar <marek.safar@seznam.cz>
11853 * class.cs (EventField.ApplyAttributeBuilder): Fix error
11856 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11858 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
11860 * pending.cs (PendingImplementation): Grab only interfaces.
11862 2004-11-19 Marek Safar <marek.safar@seznam.cz>
11864 * statement.cs (ForeachHelperMethods): Add location member and
11865 error 202 detection.
11867 2004-11-19 Raja R Harinath <rharinath@novell.com>
11869 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
11870 automatically handled by executable.make.
11871 (PROGRAM): Make profile-specific.
11873 2004-11-18 Marek Safar <marek.safar@seznam.cz>
11875 * expression.cs (DoResolveBase): Fixed wrong warning for out
11878 2004-11-18 Martin Baulig <martin@ximian.com>
11880 Merged latest changes into gmcs. Please keep this comment in
11881 here, it makes it easier for me to see what changed in MCS since
11882 the last time I merged.
11884 2004-11-17 Raja R Harinath <rharinath@novell.com>
11886 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
11887 (TypeHandle.GetMemberCache): New.
11888 (TypeHandle.TypeHandle): Update.
11889 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
11890 (TypeManager.LookupParentInterfacesCache):
11891 Rename from LookupInterfaceCache. Optimize slightly.
11892 (TypeManager.MemberLookup_FindMembers): Update.
11893 * decl.cs (MemberCache.MemberCache): Set Container to null in the
11894 multi-type variant.
11895 (AddCacheContents): Rename from AddHashtable.
11896 * class.cs (TypeContainer.parent_container): Remove.
11897 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
11898 (TypeContainer.DoDefineMembers): Don't initialize it.
11899 Update to name changes.
11901 2004-11-17 Miguel de Icaza <miguel@ximian.com>
11903 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
11904 that factors the code to check access modifiers on override.
11906 (PropertyBase): Use the code here.
11908 Patch from Lluis S'anchez, fixes bug #69361.
11910 2004-11-15 Miguel de Icaza <miguel@ximian.com>
11912 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
11913 routine that is used to report the use of a captured variable
11914 whose address has been taken.
11916 There are two checks: one when variables are being captured and
11917 the other check is when the address of a variable is taken.
11919 (because an anonymous methods might be resolved before *or* after
11920 the address has been taken) and
11922 * expression.cs (Conditional.DoResolve): Remove the special
11923 casing that Martin added to trueExpr and falseExpr being both
11924 NullLiteral. We get the right behavior now just by introducing
11925 the null_type into the compiler.
11927 * convert.cs (ExplicitConversion): Change the code to use
11928 null_type instead of testing `expr is NullLiteral'.
11929 (ImplicitConversionStandard): use null_type too.
11930 (ImplicitReferenceConversionExists): use null_type too.
11931 (ImplicitReferenceConversion): use null_type too.
11933 * literal.cs: The type of `NullLiteral' is now null_type instead
11935 (Resolve): Set the type here.
11937 * typemanager.cs: Introduce null_type.
11939 2004-11-17 Martin Baulig <martin@ximian.com>
11941 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
11942 direction, like FindMembers() does. Fixes #69546, testcase is in
11945 2004-11-16 Martin Baulig <martin@ximian.com>
11947 This is based on a patch from Marek Safar, see bug #69082.
11948 Fixes bugs #63705 and #67130.
11950 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
11951 method; create a MemberCache for an interface type and cache the
11954 * decl.cs (IMemberContainer.ParentContainer): Removed.
11955 (IMemberContainer.ParentCache): New property.
11956 (MemberCache.SetupCacheForInterface): Removed.
11957 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
11958 to create a cache for an interface's "parent".
11960 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
11963 2004-11-16 Martin Baulig <martin@ximian.com>
11965 Merged back from gmcs; these changes already went into gmcs a
11966 couple of weeks ago.
11969 (TypeManager.AddUserType): Removed the `ifaces' argument.
11970 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
11972 (TypeManager.AddUserInterface): Removed.
11973 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
11975 (TypeManager.GetInterfaces): Likewise.
11976 (TypeManager.GetExplicitInterfaces): Likewise.
11978 * ecore.cs (TypeExpr.GetInterfaces): Removed.
11980 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
11981 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
11983 2004-11-14 Ben Maurer <bmaurer@ximian.com>
11985 * statement.cs: Avoid adding bools to a hashtable.
11987 2004-11-07 Miguel de Icaza <miguel@ximian.com>
11989 * expression.cs (Invocation.OverloadResolve): Flag error if we are
11990 calling an unsafe method from a safe location.
11992 2004-11-06 Marek Safar <marek.safar@seznam.cz>
11995 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
11997 2004-11-06 Miguel de Icaza <miguel@ximian.com>
11999 * namespace.cs (VerifyUsing): use GetPartialName instead of
12002 2004-11-05 Miguel de Icaza <miguel@ximian.com>
12004 * statement.cs (Return.Resolve): Fix regression in typo: if
12005 `in_exc', we have to request a NeedReturnLabel, this was a typo
12006 introduced in the anonymous method check-in. Fixes #69131.
12008 * Indexers were using the ShortName when defining themselves,
12009 causing a regression in the compiler bootstrap when applying the
12010 patch from 2004-11-02 (first part), now they use their full name
12011 and the bug is gone.
12013 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
12015 * driver.cs: Strip the path from the names of embedded resources. Fixes
12018 2004-11-04 Raja R Harinath <rharinath@novell.com>
12020 Fix error message regression: cs0104-2.cs.
12021 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
12022 (AliasEntry.Resolve): Update.
12023 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
12025 (RootContext.LookupType): Update.
12027 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
12029 * cs-parser.jay: Add support for handling accessor modifiers
12030 * class: Add support port accessor modifiers and error checking,
12031 define PropertyMethod.Define as virtual (not abstract anymore)
12032 * ecore.cs: Add checking for proeprties access with access modifiers
12033 * iterators.cs: Modify Accessor constructor call based in the modified
12035 2004-11-02 Ben Maurer <bmaurer@ximian.com>
12037 * expression.cs (StringConcat): Handle being called twice,
12038 as when we have a concat in a field init with more than two
12041 2004-11-02 Miguel de Icaza <miguel@ximian.com>
12043 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
12044 special case explicit implementations, we should always produce
12045 the .property or .event declaration.
12047 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
12048 since it will not return correct data if people use this
12049 unresolved in the presence of using statements (see test-313).
12051 * class.cs (MethodData.Define): If we are an explicit interface
12052 implementation, set the method name to the full name of the
12053 interface plus the name of the method.
12055 Notice that using the method.MethodName.GetFullName() does not
12056 work, as it will only contain the name as declared on the source
12057 file (it can be a shorthand in the presence of using statements)
12058 and not the fully qualifed type name, for example:
12062 class D : ICloneable {
12063 object ICloneable.Clone () {
12067 Would produce a method called `ICloneable.Clone' instead of
12068 `System.ICloneable.Clone'.
12070 * namespace.cs (Alias.Resolve): Use GetPartialName.
12072 2004-11-01 Marek Safar <marek.safar@seznam.cz>
12074 * cs-parser.jay: Add error 1055 report.
12076 2004-11-01 Miguel de Icaza <miguel@ximian.com>
12078 * assign.cs (Assign.DoResolve): Only do the transform of
12079 assignment into a New if the types are compatible, if not, fall
12080 through and let the implicit code deal with the errors and with
12081 the necessary conversions.
12083 2004-11-01 Marek Safar <marek.safar@seznam.cz>
12085 * cs-parser.jay: Add error 1031 report.
12087 * cs-tokenizer.cs: Add location for error 1038.
12089 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12091 * cs-parser.jay: Add error 1016 report.
12093 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12095 * cs-parser.jay: Add errors 1575,1611 report.
12097 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12099 * cs-parser.jay: Add error 1001 report.
12101 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12104 * attribute.cs (GetMarshal): Add method argument for
12105 caller identification.
12107 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
12108 agument for GetMarshal and RuntimeMissingSupport.
12110 2004-10-31 Marek Safar <marek.safar@seznam.cz>
12112 * attribute.cs (ExtractSecurityPermissionSet): Removed
12113 TypeManager.code_access_permission_type.
12115 * typemanager.cs: Removed TypeManager.code_access_permission_type.
12117 2004-10-27 Miguel de Icaza <miguel@ximian.com>
12119 * expression.cs (LocalVariableReference.DoResolveLValue): Check
12120 for obsolete use of a variable here. Fixes regression on errors
12121 cs0619-25 and cs0619-26.
12123 2004-10-27 Marek Safar <marek.safar@seznam.cz>
12125 Fix #62358, implemented security attribute encoding.
12127 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
12128 Tests permitted SecurityAction for assembly or other types.
12129 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
12130 data from SecurityPermissionAttribute to PermisionSet class.
12132 * class.cs (ApplyAttributeBuilder): Added special handling
12133 for System.Security.Permissions.SecurityAttribute based types.
12135 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
12136 special handling for System.Security.Permissions.SecurityAttribute
12139 * enum.cs (ApplyAttributeBuilder): Added special handling
12140 for System.Security.Permissions.SecurityAttribute based types.
12142 * parameter.cs (ApplyAttributeBuilder): Added special handling
12143 for System.Security.Permissions.SecurityAttribute based types.
12145 * rootcontext.cs: Next 2 core types.
12147 * typemanager.cs (TypeManager.security_permission_attr_type):
12148 Built in type for the SecurityPermission Attribute.
12149 (code_access_permission_type): Build in type.
12151 2004-10-17 Miguel de Icaza <miguel@ximian.com>
12153 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
12154 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
12155 all of this information into
12156 EmitContext.EmitCapturedVariableInstance.
12158 * codegen.cs (EmitCapturedVariableInstance): move here the
12159 funcionality of emitting an ldarg.0 in the presence of a
12160 remapping. This centralizes the instance emit code.
12162 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
12163 then emit a load of this: it means that we have reached the
12164 topmost ScopeInfo: the one that contains the pointer to the
12165 instance of the class hosting the anonymous method.
12167 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
12168 captures to the topmost CaptureContext.
12170 2004-10-12 Miguel de Icaza <miguel@ximian.com>
12172 * expression.cs (LocalVariableReference): Move the knowledge about
12173 the iterators into codegen's EmitCapturedVariableInstance.
12175 2004-10-11 Miguel de Icaza <miguel@ximian.com>
12177 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
12178 all code paths return a value from an anonymous method (it is the
12179 same as the 161 error, but for anonymous methods).
12181 2004-10-08 Miguel de Icaza <miguel@ximian.com>
12183 The introduction of anonymous methods in the compiler changed
12184 various ways of doing things in the compiler. The most
12185 significant one is the hard split between the resolution phase
12186 and the emission phases of the compiler.
12188 For instance, routines that referenced local variables no
12189 longer can safely create temporary variables during the
12190 resolution phase: they must do so from the emission phase,
12191 since the variable might have been "captured", hence access to
12192 it can not be done with the local-variable operations from the runtime.
12196 (Block.Flags): New flag `IsTopLevel' to indicate that this block
12197 is a toplevel block.
12199 (ToplevelBlock): A new kind of Block, these are the blocks that
12200 are created by the parser for all toplevel method bodies. These
12201 include methods, accessors and anonymous methods.
12203 These contain some extra information not found in regular blocks:
12204 A pointer to an optional CaptureContext (for tracking captured
12205 local variables and parameters). A pointer to the parent
12208 (Return.Resolve): Catch missmatches when returning a value from an
12209 anonymous method (error 1662).
12210 Invoke NeedReturnLabel from the Resolve phase instead of the emit
12213 (Break.Resolve): ditto.
12215 (SwitchLabel): instead of defining the labels during the
12216 resolution phase, we now turned the public ILLabel and ILLabelCode
12217 labels into methods called GetILLabelCode() and GetILLabel() that
12218 only define the label during the Emit phase.
12220 (GotoCase): Track the SwitchLabel instead of the computed label
12221 (its contained therein). Emit the code by using
12222 SwitchLabel.GetILLabelCode ().
12224 (LocalInfo.Flags.Captured): A new flag has been introduce to track
12225 whether the Local has been captured or not.
12227 (LocalInfo.IsCaptured): New property, used to tell whether the
12228 local has been captured.
12230 * anonymous.cs: Vastly updated to contain the anonymous method
12233 The main classes here are: CaptureContext which tracks any
12234 captured information for a toplevel block and ScopeInfo used to
12235 track the activation frames for various local variables.
12237 Each toplevel block has an optional capture context associated
12238 with it. When a method contains an anonymous method both the
12239 toplevel method and the anonymous method will create a capture
12240 context. When variables or parameters are captured, they are
12241 recorded on the CaptureContext that owns them, for example:
12245 MyDelegate d = delegate {
12250 Here `a' will be recorded as captured on the toplevel
12251 CapturedContext, the inner captured context will not have anything
12252 (it will only have data if local variables or parameters from it
12253 are captured in a nested anonymous method.
12255 The ScopeInfo is used to track the activation frames for local
12256 variables, for example:
12258 for (int i = 0; i < 10; i++)
12259 for (int j = 0; j < 10; j++){
12260 MyDelegate d = delegate {
12265 At runtime this captures a single captured variable `i', but it
12266 captures 10 different versions of the variable `j'. The variable
12267 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
12268 recorded on a child.
12270 The toplevel ScopeInfo will also track information like the `this'
12271 pointer if instance variables were referenced (this is necessary
12272 as the anonymous method lives inside a nested class in the host
12273 type of the method).
12275 (AnonymousMethod): Expanded to track the Toplevel, implement
12276 `AnonymousMethod.Compatible' to tell whether an anonymous method
12277 can be converted to a target delegate type.
12279 The routine now also produces the anonymous method content
12281 (AnonymousDelegate): A helper class that derives from
12282 DelegateCreation, this is used to generate the code necessary to
12283 produce the delegate for the anonymous method that was created.
12285 * assign.cs: API adjustments for new changes in
12286 Convert.ImplicitStandardConversionExists.
12288 * class.cs: Adjustments to cope with the fact that now toplevel
12289 blocks are of type `ToplevelBlock'.
12291 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
12292 insteda of standard blocks.
12294 Flag errors if params arguments are passed to anonymous methods.
12296 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
12297 `CurrentAnonymousMethod' which points to the current Anonymous
12298 Method. The variable points to the AnonymousMethod class that
12299 holds the code being compiled. It is set in the new EmitContext
12300 created for the anonymous method.
12302 (EmitContext.Phase): Introduce a variable and an enumeration to
12303 assist in enforcing some rules about when and where we are allowed
12304 to invoke certain methods (EmitContext.NeedsReturnLabel is the
12305 only one that enfonces this right now).
12307 (EmitContext.HaveCaptureInfo): new helper method that returns
12308 whether we have a CapturedContext initialized.
12310 (EmitContext.CaptureVariable): New method used to register that a
12311 LocalInfo must be flagged for capturing.
12313 (EmitContext.CapturedParameter): New method used to register that a
12314 parameters must be flagged for capturing.
12316 (EmitContext.CapturedField): New method used to register that a
12317 field must be flagged for capturing.
12319 (EmitContext.HaveCapturedVariables,
12320 EmitContext.HaveCapturedFields): Return whether there are captured
12321 variables or fields.
12323 (EmitContext.EmitMethodHostInstance): This is used to emit the
12324 instance for the anonymous method. The instance might be null
12325 (static methods), this (for anonymous methods that capture nothing
12326 and happen to live side-by-side with the current method body) or a
12327 more complicated expression if the method has a CaptureContext.
12329 (EmitContext.EmitTopBlock): Routine that drives the emission of
12330 code: it will first resolve the top block, then emit any metadata
12331 and then emit the code. The split is done so that we can extract
12332 any anonymous methods and flag any captured variables/parameters.
12334 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
12335 during this phase, the ILGenerator should not be used as labels
12336 and local variables declared here might not be accessible to any
12337 code that is part of an anonymous method.
12339 Exceptions to this include the temporary variables that are
12340 created by some statements internally for holding temporary
12343 (EmitContext.EmitMeta): New routine, in charge of emitting all the
12346 (EmitContext.TemporaryReturn): This method is typically called
12347 from the Emit phase, and its the only place where we allow the
12348 ReturnLabel to be defined other than the EmitMeta. The reason is
12349 that otherwise we would have to duplicate a lot of logic in the
12350 Resolve phases of various methods that today is on the Emit
12353 (EmitContext.NeedReturnLabel): This no longer creates the label,
12354 as the ILGenerator is not valid during the resolve phase.
12356 (EmitContext.EmitThis): Extended the knowledge in this class to
12357 work in anonymous methods in addition to iterators.
12359 (EmitContext.EmitCapturedVariableInstance): This emits whatever
12360 code is necessary on the stack to access the instance to a local
12361 variable (the variable will be accessed as a field).
12363 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
12364 EmitContext.EmitAddressOfParameter): Routines to support
12365 parameters (not completed at this point).
12367 Removals: Removed RemapLocal and RemapLocalLValue. We probably
12368 will also remove the parameters.
12370 * convert.cs (Convert): Define a `ConstantEC' which points to a
12371 null. This is just to prefity some code that uses
12372 ImplicitStandardConversion code and do not have an EmitContext
12375 The idea is to flag explicitly that at that point in time, it is
12376 known that the conversion will not trigger the delegate checking
12377 code in implicit conversions (which requires a valid
12380 Everywhere: pass new EmitContext parameter since
12381 ImplicitStandardConversionExists now requires it to check for
12382 anonymous method conversions.
12384 (Convert.ImplicitStandardConversionExists): If the type of an
12385 expression is the anonymous_method_type, and the type is a
12386 delegate, we invoke the AnonymousMethod.Compatible method to check
12387 whether an implicit conversion is possible.
12389 (Convert.ImplicitConversionStandard): Only do implicit method
12390 group conversions if the language level is not ISO_1.
12392 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
12393 MethodInfo for the Invoke method. used by Delegate and
12396 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
12397 method conversions if the target type is a delegate.
12399 Removed extra debugging nops.
12401 (LocalVariableReference): Turn the `local_info' into a public
12404 Add `prepared' field, the same hack used for FieldExprs to cope
12405 with composed assignments, as Local variables do not necessarily
12406 operate purely on the stack as they used to: they can be captured
12409 Add `temp' for a temporary result, like fields.
12411 Refactor DoResolve and DoResolveLValue into DoResolveBase.
12413 It now copes with Local variables that are captured and emits the
12414 proper instance variable to load it from a field in the captured
12417 (ParameterReference.DoResolveBase): During the resolve phase,
12418 capture parameters if we are in an anonymous method.
12420 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
12421 anonymous method, use the EmitContext helper routines to emit the
12422 parameter reference.
12424 * iterators.cs: Set RemapToProxy to true/false during the
12427 * parameters.cs (GetParameterByName): New helper method.
12429 * typemanager.cs (anonymous_method_type) a new type that
12430 represents an anonyous method. This is always an internal type,
12431 used as a fencepost to test against the anonymous-methodness of an
12434 2004-10-20 Marek Safar <marek.safar@seznam.cz>
12436 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
12438 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
12440 2004-10-18 Martin Baulig <martin@ximian.com>
12442 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
12443 `Type' directly, but call ResolveType() on it.
12444 (Catch.Resolve): Likewise.
12445 (Foreach.Resolve): Likewise.
12447 2004-10-18 Martin Baulig <martin@ximian.com>
12449 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
12450 `Type' directly, but call ResolveType() on it.
12451 (Probe.DoResolve): Likewise.
12452 (ArrayCreation.LookupType): Likewise.
12453 (TypeOf.DoResolve): Likewise.
12454 (SizeOf.DoResolve): Likewise.
12456 2004-10-18 Martin Baulig <martin@ximian.com>
12458 * expression.cs (Invocation.BetterFunction): Put back
12459 TypeManager.TypeToCoreType().
12461 2004-10-18 Raja R Harinath <rharinath@novell.com>
12463 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
12466 2004-10-18 Martin Baulig <martin@ximian.com>
12468 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
12469 `Type' directly, but call ResolveType() on it.
12471 2004-10-18 Martin Baulig <martin@ximian.com>
12473 * class.cs (FieldMember.Define): Don't access the TypeExpr's
12474 `Type' directly, but call ResolveType() on it.
12475 (MemberBase.DoDefine): Likewise.
12477 * expression.cs (New.DoResolve): Don't access the TypeExpr's
12478 `Type' directly, but call ResolveType() on it.
12479 (ComposedCast.DoResolveAsTypeStep): Likewise.
12481 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
12482 `Type' directly, but call ResolveType() on it.
12484 2004-10-17 John Luke <john.luke@gmail.com>
12486 * class.cs (Operator.GetSignatureForError): use CSharpName
12488 * parameter.cs (Parameter.GetSignatureForError): Returns
12489 correct name even if was not defined.
12491 2004-10-13 Raja R Harinath <rharinath@novell.com>
12494 * class.cs (TypeContainer.EmitContext): New property.
12495 (DefineNestedTypes): Create an emitcontext for each part.
12496 (MethodCore.DoDefineParameters): Use container's emitcontext.
12497 Pass type array to InternalParameters.
12498 (MemberBase.DoDefine): Use container's emitcontext.
12499 (FieldMember.Define): Likewise.
12500 (Event.Define): Likewise.
12501 (SetMethod.GetParameterInfo): Change argument to EmitContext.
12502 Pass type array to InternalParameters.
12503 (SetIndexerMethod.GetParameterInfo): Likewise.
12504 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
12505 * delegate.cs (Define): Pass emitcontext to
12506 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
12507 array to InternalParameters.
12508 * expression.cs (ParameterReference.DoResolveBase): Pass
12509 emitcontext to GetParameterInfo.
12510 (ComposedCast.DoResolveAsTypeStep): Remove check on
12511 ec.ResolvingTypeTree.
12512 * parameter.cs (Parameter.Resolve): Change argument to
12513 EmitContext. Use ResolveAsTypeTerminal.
12514 (Parameter.GetSignature): Change argument to EmitContext.
12515 (Parameters.ComputeSignature): Likewise.
12516 (Parameters.ComputeParameterTypes): Likewise.
12517 (Parameters.GetParameterInfo): Likewise.
12518 (Parameters.ComputeAndDefineParameterTypes): Likewise.
12519 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
12520 * support.cs (InternalParameters..ctor): Remove variant that takes
12522 * typemanager.cs (system_intptr_expr): New.
12523 (InitExpressionTypes): Initialize it.
12525 2004-10-12 Chris Toshok <toshok@ximian.com>
12527 * cs-parser.jay: fix location for try_statement and catch_clause.
12529 2004-10-11 Martin Baulig <martin@ximian.com>
12531 * report.cs: Don't make --fatal abort on warnings, we have
12532 -warnaserror for that.
12534 2004-10-07 Raja R Harinath <rharinath@novell.com>
12536 More DeclSpace.ResolveType avoidance.
12537 * decl.cs (MemberCore.InUnsafe): New property.
12538 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
12539 with newly created EmitContext.
12540 (FieldMember.Define): Likewise.
12541 * delegate.cs (Delegate.Define): Likewise.
12542 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
12543 only if normal name-lookup fails.
12544 (TypeExpr.DoResolve): Enable error-checking.
12545 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
12546 (SizeOf.DoResolve): Likewise.
12547 (ComposedCast.DoResolveAsTypeStep): Likewise.
12548 (StackAlloc.DoResolve): Likewise.
12549 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
12550 (Block.Unsafe): New property.
12551 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
12552 (Unsafe): Set 'unsafe' flag of contained block.
12553 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
12554 (Fixed.Resolve): Likewise.
12555 (Catch.Resolve): Likewise.
12556 (Using.ResolveLocalVariableDecls): Likewise.
12557 (Foreach.Resolve): Likewise.
12559 2004-10-05 John Luke <john.luke@gmail.com>
12561 * cs-parser.jay: add location to error CS0175
12563 2004-10-04 Miguel de Icaza <miguel@ximian.com>
12565 * ecore.cs (Expression.Constantity): Add support for turning null
12568 * const.cs (Const.Define): Allow constants to be reference types
12569 as long as the value is Null.
12571 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
12573 * namespace.cs (NamespaceEntry.Using): No matter which warning
12574 level is set, check if this namespace name has already been added.
12576 2004-10-03 Ben Maurer <bmaurer@ximian.com>
12578 * expression.cs: reftype [!=]= null should always use br[true,false].
12581 2004-10-03 Marek Safar <marek.safar@seznam.cz>
12584 * attribute.cs: Enum conversion moved to
12585 GetAttributeArgumentExpression to be applied to the all
12588 2004-10-01 Raja R Harinath <rharinath@novell.com>
12590 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
12591 * class.c (TypeContainer.DefineType): Flag error if
12592 base types aren't accessible due to access permissions.
12593 * decl.cs (DeclSpace.ResolveType): Move logic to
12594 Expression.ResolveAsTypeTerminal.
12595 (DeclSpace.ResolveTypeExpr): Thin layer over
12596 Expression.ResolveAsTypeTerminal.
12597 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
12598 Refactor code into NestedAccess. Use it.
12599 (DeclSpace.NestedAccess): New.
12600 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
12601 argument to silence errors. Check access permissions.
12602 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
12603 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
12604 (Cast.DoResolve): Likewise.
12605 (New.DoResolve): Likewise.
12606 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
12607 (TypeOf.DoResolve): Likewise.
12609 * expression.cs (Invocation.BetterConversion): Return the Type of
12610 the better conversion. Implement section 14.4.2.3 more faithfully.
12611 (Invocation.BetterFunction): Make boolean. Make correspondence to
12612 section 14.4.2.2 explicit.
12613 (Invocation.OverloadResolve): Update.
12614 (Invocation): Remove is_base field.
12615 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
12616 (Invocation.Emit): Likewise.
12618 2004-09-27 Raja R Harinath <rharinath@novell.com>
12620 * README: Update to changes.
12622 2004-09-24 Marek Safar <marek.safar@seznam.cz>
12624 * cs-parser.jay: Reverted 642 warning fix.
12626 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12629 * decl.cs (FindMemberWithSameName): Indexer can have more than
12632 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12634 * expression.cs (LocalVariableReference.DoResolveLValue):
12635 Do not report warning 219 for out values.
12636 (EmptyExpression.Null): New member to avoid extra allocations.
12638 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12640 * cs-parser.jay: Fix wrong warning 642 report.
12642 * cs-tokenizer.cs (CheckNextToken): New helper;
12643 Inspect next character if is same as expected.
12645 2004-09-23 Martin Baulig <martin@ximian.com>
12647 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
12648 (Convert.ImplicitReferenceConversionExists): Likewise.
12650 2004-09-23 Marek Safar <marek.safar@seznam.cz>
12652 * class.cs (Operator.Define): Add error 448 and 559 report.
12654 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12656 * class.cs (MemberBase.IsTypePermitted): New protected
12657 method for checking error CS0610.
12659 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12661 * class.cs (TypeContainer.HasExplicitLayout): New property
12662 Returns whether container has StructLayout attribute set Explicit.
12663 (FieldMember): New abstract class for consts and fields.
12664 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
12665 (Field): Reuse FieldMember.
12667 * const.cs (Const): Reuse FieldMember.
12669 * rootcontext.cs: EmitConstants call moved to class.
12671 2004-09-22 Martin Baulig <martin@ximian.com>
12673 Thanks to Peter Sestoft for this bug report.
12675 * expression.cs (Conditional): If both the `trueExpr' and the
12676 `falseExpr' is a NullLiteral, return a NullLiteral.
12678 2004-09-22 Martin Baulig <martin@ximian.com>
12680 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
12681 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
12682 for the "get_Current" call.
12684 2004-09-22 Martin Baulig <martin@ximian.com>
12686 Marek and me just fixed one of our oldest bugs: #28562 :-)
12688 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
12690 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
12691 we're an EnumConstant, just return that.
12692 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
12693 an EnumConstant. In this case, we need to use GetValueAsEnumType()
12694 to get the value which'll actually be written into the attribute.
12695 However, we have to use GetValue() to access the attribute's value
12698 2004-09-22 Marek Safar <marek.safar@seznam.cz>
12700 * constant.cs (Constant.IsNegative): New abstract property
12703 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
12704 (StackAlloc.DoResolve): Reused IsNegative.
12706 2004-09-21 Martin Baulig <martin@ximian.com>
12708 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
12709 if we're used in an iterator, we may be called from different
12712 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
12713 we actually have an exception block.
12715 2004-09-20 John Luke <jluke@cfl.rr.com>
12717 * class.cs, cs-parser.jay: Improve the error report for 1520:
12718 report the actual line where the error happens, not where the
12719 class was declared.
12721 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
12722 Pass location information that was available elsewhere.
12724 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
12726 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
12727 runtime to delay sign assemblies.
12729 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12731 * cs-parser.jay: Do not report the stack trace, this is barely
12734 2004-08-22 John Luke <john.luke@gmail.com>
12736 * driver.cs : check that a resource id is not already used
12737 before adding it, report CS1508 if it is, bug #63637
12739 2004-09-19 Miguel de Icaza <miguel@ximian.com>
12741 * ecore.cs: Removed dead code.
12743 2004-09-18 Marek Safar <marek.safar@seznam.cz>
12745 * class.cs: Do not report warning CS0067 on the interfaces.
12747 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12749 * cs-parser.jay: Add error 504 report.
12751 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12753 * rootcontext.cs: WarningLevel is 4 by default now.
12755 * statement.cs (Fixed.Resolve): Do not null
12758 2004-09-16 Marek Safar <marek.safar@seznam.cz>
12761 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
12762 deep search when property is not virtual.
12763 (PropertyExpr.ResolveAccessors): Make one call for both
12766 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12769 * statement.cs: Error 152 report constains also location.
12771 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12774 * const.cs: Explicitly set constant as static.
12776 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12779 * cs-parser.jay: Add error 1017 report.
12781 2004-09-15 Marek Safar <marek.safar@seznam.cz>
12783 Fixed bug #59980, #64224
12784 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
12786 * typemanager.cs (IsSpecialMethod): Simplified
12788 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12790 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
12791 condition with better params.
12793 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12796 * attribute.cs (Resolve): Property has to have both
12799 2004-09-14 Martin Baulig <martin@ximian.com>
12801 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
12803 2004-09-14 Marek Safar <marek.safar@seznam.cz>
12806 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
12807 called and is obsolete then this member suppress message
12808 when call is inside next [Obsolete] method or type.
12810 * expression.cs: Use TestObsoleteMethodUsage member.
12812 2004-09-14 Martin Baulig <martin@ximian.com>
12814 * cs-parser.jay: Sync a bit with the GMCS version.
12816 2004-09-14 Martin Baulig <martin@ximian.com>
12818 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
12819 (CSharpParser.yacc_verbose_flag): New public field.
12821 * genericparser.cs: Removed.
12823 2004-09-14 Raja R Harinath <rharinath@novell.com>
12825 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
12827 2004-09-13 Marek Safar <marek.safar@seznam.cz>
12829 * class.cs (MethodCore.CheckBase): Fix bug #65757.
12831 2004-09-10 Martin Baulig <martin@ximian.com>
12833 Backported my MemberName changes from GMCS into MCS.
12835 - we are now using a special `MemberName' class instead of using
12836 strings; in GMCS, the `MemberName' also contains the type
12839 - changed the grammar rules a bit:
12840 * the old `member_name' is now a `namespace_or_type_name':
12841 The rule is that we use `namespace_or_type_name' everywhere
12842 where we expect either a "member name" (GetEnumerator) or a
12843 "member name" with an explicit interface name
12844 (IEnumerable.GetEnumerator).
12845 In GMCS, the explicit interface name may include type arguments
12846 (IEnumerable<T>.GetEnumerator).
12847 * we use `member_name' instead of just `IDENTIFIER' for
12849 The rule is that we use `member_name' wherever a member may
12850 have type parameters in GMCS.
12852 * decl.cs (MemberName): New public class.
12853 (MemberCore.MemberName): New public readonly field.
12854 (MemberCore.ctor): Take a `MemberName' argument, not a string.
12855 (DeclSpace): Likewise.
12857 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
12858 * enum.cs (Enum.ctor): Likewise.
12860 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
12862 (AliasEntry.ctor): Take a MemberName, not an Expression.
12863 (AliasEntry.UsingAlias): Likewise.
12865 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
12866 (IMethodData.MemberName): Changed type from string to MemberName.
12867 (MemberBase.ExplicitInterfaceName): Likewise.
12868 (AbstractPropertyEventMethod.SetupName): Make this private.
12869 (AbstractPropertyEventMethod.ctor): Added `string prefix'
12870 argument; compute the member name here.
12871 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
12872 on the `member.MemberName' and the `prefix'.
12874 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
12876 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
12877 thus, we get a `MemberName' instead of a `string'. These
12878 declarations may have type parameters in GMCS.
12879 (interface_method_declaration, delegate_declaration): Likewise.
12880 (class_declaration, interface_declaration): Likewise.
12881 (method_header): Use `namespace_or_type_name' instead of
12882 `member_name'. We may be an explicit interface implementation.
12883 (property_declaration, event_declaration): Likewise.
12884 (member_name): This is now just an `IDENTIFIER', not a
12885 `namespace_or_type_name'.
12886 (type_name, interface_type): Removed.
12887 (namespace_or_type_name): Return a MemberName, not an Expression.
12888 (primary_expression): Use `member_name' instead of `IDENTIFIER';
12889 call GetTypeExpression() on the MemberName to get an expression.
12890 (IndexerDeclaration.interface_type): Changed type from string to
12892 (MakeName): Operate on MemberName's instead of string's.
12894 2004-09-13 Raja R Harinath <rharinath@novell.com>
12897 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
12898 (NamespaceEntry.Lookup): Add new argument to flag if we want the
12899 lookup to avoid symbols introduced by 'using'.
12900 * rootcontext.cs (NamespaceLookup): Update.
12902 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12904 * class.cs (TypeContainer.DoDefineMembers): Do not call
12905 DefineDefaultConstructor for static classes.
12907 2004-09-12 Marek Safar <marek.safar@seznam.cz>
12909 * attribute.cs (Attribute.Resolve): Add error 653 report.
12911 * class.cs (Class.ApplyAttributeBuilder): Add error 641
12913 (Method.ApplyAttributeBuilder): Add error 685 report.
12914 (Operator.Define): Add error 564 report.
12916 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
12918 * expression.cs (Invocation.DoResolve): Add error
12919 245 and 250 report.
12921 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
12924 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12926 * class.cs (ConstructorInitializer.Resolve):
12927 Wrong error number (515->516).
12929 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12931 * class.cs (Indexer.Define): Add error 631 report.
12933 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12935 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
12937 2004-09-11 Marek Safar <marek.safar@seznam.cz>
12939 * expression.cs (Probe.DoResolve): Add error CS0241 report.
12941 2004-09-10 Marek Safar <marek.safar@seznam.cz>
12943 * cs-parser.jay: Added error CS0241 report.
12945 2004-09-10 Raja R Harinath <rharinath@novell.com>
12947 * cs-parser.jay (fixed_statement): Introduce a scope for the
12948 declaration in the 'fixed' statement.
12950 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12952 * cs-parser.jay: Added CS0230 error report.
12954 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12956 * cs-parser.jay: Added errors CS0231 and CS0257 report.
12958 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12960 * expression.cs (Argument.Resolve): Added error CS0192 and
12963 2004-09-09 Marek Safar <marek.safar@seznam.cz>
12965 C# 2.0 #pragma warning feature
12967 * cs-tokenizer.cs (PreProcessPragma): New method;
12968 Handles #pragma directive.
12970 * report.cs (WarningRegions): New class; Support
12971 class for #pragma warning directive. It tests whether
12972 warning is enabled for a given line.
12974 2004-09-08 Miguel de Icaza <miguel@ximian.com>
12976 * const.cs: Add more descriptive error report, tahnks to
12979 2004-09-08 Marek Safar <marek.safar@seznam.cz>
12981 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
12983 2004-09-07 Miguel de Icaza <miguel@ximian.com>
12985 * expression.cs: Apply patch from Ben: Remove dead code from
12986 ArrayCreation, and remove the TurnintoConstant call in const.cs,
12987 as that code just threw an exception anwyays.
12989 * const.cs: Remove the call to the turnintoconstant, for details
12992 * literal.cs: The type of the null-literal is the null type; So
12993 we use a placeholder type (literal.cs:System.Null, defined here)
12996 * expression.cs (Conditional.DoResolve): Remove some old code that
12997 is no longer needed, conversions have been fixed.
12999 (ArrayCreationExpression.DoResolve): Return false if we fail to
13000 resolve the inner expression.
13002 2004-09-07 Raja R Harinath <rharinath@novell.com>
13005 * cs-parser.jay (delegate_declaration): Record a delegate
13006 declaration as a type declaration.
13007 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
13009 2004-09-06 Miguel de Icaza <miguel@ximian.com>
13011 * parameter.cs: Do not crash if the type can not be resolved.
13013 * expression.cs: Report errors with unsafe pointers, fixes #64896
13015 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
13017 * expression.cs: Pointer arith always needs to do a conv.i
13018 if the operand is a long. fix 65320
13020 2004-09-04 Marek Safar <marek.safar@seznam.cz>
13022 Fixed cs0619-37.cs, cs0619-38.cs
13024 * enum.cs (GetObsoleteAttribute): Removed.
13026 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
13027 on Enum member is double staged. The first is tested member
13030 2004-09-04 Marek Safar <marek.safar@seznam.cz>
13032 Fixed #56986, #63631, #65231
13034 * class.cs: (TypeContainer.AddToMemberContainer): New method,
13035 adds member to name container.
13036 (TypeContainer.AddToTypeContainer): New method, adds type to
13038 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
13039 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
13040 AddOperator): Simplified by reusing AddToMemberContainer.
13041 (TypeContainer.UserDefinedStaticConstructor): Changed to property
13043 (Method.CheckForDuplications): Fixed implementation to test all
13045 (MemberBase): Detection whether member is explicit interface
13046 implementation is now in constructor.
13047 (MemberBase.UpdateMemberName): Handles IndexerName.
13048 (Accessor): Changed to keep also location information.
13049 (AbstractPropertyEventMethod): Is derived from MemberCore.
13050 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
13051 will be emited or not.
13052 (PropertyBase.AreAccessorsDuplicateImplementation):
13053 Tests whether accessors are not in collision with some method.
13054 (Operator): Is derived from MethodCore to simplify common
13057 * decl.cs (Flags.TestMethodDuplication): Test for duplication
13059 (DeclSpace.AddToContainer): Adds the member to defined_names
13060 table. It tests for duplications and enclosing name conflicts.
13062 * enum.cs (EnumMember): Clean up to reuse the base structures
13064 2004-09-03 Martin Baulig <martin@ximian.com>
13066 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
13067 into TypeContainer, to make partial classes work again.
13069 2004-09-03 Martin Baulig <martin@ximian.com>
13071 * rootcontext.cs (RootContext.V2): Removed.
13073 2004-03-23 Martin Baulig <martin@ximian.com>
13075 * expression.cs (Invocation.OverloadResolve): Added `bool
13076 may_fail' argument and use it instead of the Location.IsNull() hack.
13078 2004-09-03 Martin Baulig <martin@ximian.com>
13080 Merged latest changes into gmcs. Please keep this comment in
13081 here, it makes it easier for me to see what changed in MCS since
13082 the last time I merged.
13084 2004-09-03 Raja R Harinath <rharinath@novell.com>
13087 * expression.cs (BetterConversion): Don't allow either conversion
13088 to be null. Remove redundant implicit conversion test when 'q ==
13089 null' -- when this function is invoked, we already know that the
13090 implicit conversion exists.
13091 (BetterFunction): Assume that 'best' is non-null. Remove
13092 redundant reimplementation of IsApplicable when 'best' is null.
13093 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
13094 number of arguments.
13095 (IsAncestralType): Extract from OverloadResolve.
13096 (OverloadResolve): Make robust to the MethodGroupExpr being
13097 unsorted. Implement all the logic of Section 14.5.5.1, and
13098 support overloading of methods from multiple applicable types.
13099 Clean up logic somewhat. Don't pass null methods to BetterFunction.
13101 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
13102 (RealError, Warning): Append type of report to related symbol.
13104 2004-09-03 Marek Safar <marek.safar@seznam.cz>
13106 * enum.cs: Fixed CLS-Compliance checks for enum members.
13107 Error tests cs3008-8.cs, cs3014-8.cs
13109 2004-09-02 Marek Safar <marek.safar@seznam.cz>
13111 Fixed bug #62342, #63102
13112 * class.cs: ImplementIndexer uses member.IsExplicitImpl
13113 like ImplementMethod.
13115 2004-09-02 Marek Safar <marek.safar@seznam.cz>
13117 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13120 2004-09-02 Martin Baulig <martin@ximian.com>
13122 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
13123 TypeManager.GetArgumentTypes() rather than calling GetParameters()
13126 2004-09-01 Marek Safar <marek.safar@seznam.cz>
13128 C# 2.0 Static classes implemented
13130 * class.cs (TypeContainer): instance_constructors,
13131 initialized_fields, initialized_static_fields,
13132 default_constructor, base_inteface_types are protected to be
13133 accessible from StaticClass.
13134 (TypeContainer.DefineDefaultConstructor): New virtual method
13135 for custom default constructor generating
13136 (StaticClass): New class to handle "Static classes" feature.
13138 * cs-parser.jay: Handle static keyword on class like instance
13141 * driver.cs: Added "/langversion" command line switch with two
13142 options (iso-1, default).
13144 2004-08-31 Marek Safar <marek.safar@seznam.cz>
13146 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
13148 2004-08-31 Miguel de Icaza <miguel@ximian.com>
13150 * delegate.cs: Style.
13152 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
13154 * delegate.cs: Add seperate instance expr field for miguel.
13156 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13158 * PointerArithmetic (Resolve): make sure we are not doing
13159 pointer arith on void*. Also, make sure we are resolved
13160 by not setting eclass until resolve.
13162 All callers: Make sure that PointerArithmetic gets resolved.
13164 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
13166 * ArrayCreation (LookupType): If the type does not resolve
13167 to an array, give an error.
13169 2004-08-27 Marek Safar <marek.safar@seznam.cz>
13171 * statement.cs (Try.Resolve): Fixed bug #64222
13173 2004-08-27 Martin Baulig <martin@ximian.com>
13176 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
13179 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13181 * ecore.cs (Constantify): Get underlying type via
13182 System.Enum.GetUnderlyingType to avoid StackOverflow on the
13183 Windows in special cases.
13185 2004-08-26 Marek Safar <marek.safar@seznam.cz>
13187 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
13188 for obtaining also private methods.
13189 (GetRemoveMethod): Used GetRemoveMethod (true)
13190 for obtaining also private methods.
13192 2004-08-24 Martin Baulig <martin@ximian.com>
13194 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
13195 MethodAttributes.HideBySig for operators.
13197 2004-08-23 Martin Baulig <martin@ximian.com>
13199 Back to the old error reporting system :-)
13201 * report.cs (Message): Removed.
13202 (Report.MessageData, ErrorData, WarningData): Removed.
13203 (Report.Error, Warning): Back to the old system.
13205 2004-08-23 Martin Baulig <martin@ximian.com>
13207 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
13209 * class.cs (TypeContainer.ParentContainer): New public virtual
13210 method; replaces the explicit interface implementation.
13211 (ClassPart.ParentContainer): Override.
13213 2004-08-23 Martin Baulig <martin@ximian.com>
13215 * statement.cs (Switch): Added support for constant switches; see
13216 #59428 or test-285.cs.
13218 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13221 * statement.cs (GetEnumeratorFilter): Removed useless
13222 logic because C# specs is strict. GetEnumerator must be
13225 2004-08-22 Martin Baulig <martin@ximian.com>
13227 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13228 a switch and may break, reset the barrier. Fixes #59867.
13230 2004-08-22 Marek Safar <marek.safar@seznam.cz>
13232 CLS-Compliance speed up (~5% for corlib)
13234 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
13235 New method. Tests container for CLS-Compliant names
13237 * class.cs (TypeContainer.VerifyClsName): New method.
13238 Checks whether container name is CLS Compliant.
13239 (Constructor): Implements IMethodData.
13241 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
13242 low-case table for CLS Compliance test.
13243 (MemberCache.VerifyClsParameterConflict): New method.
13244 Checks method parameters for CS3006 error.
13246 * enum.cs (EnumMember): Is derived from MemberCore.
13247 (Enum.VerifyClsName): Optimized for better performance.
13249 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13251 * report.cs: Renamed Error_T to Error and changed all
13254 2004-08-06 Marek Safar <marek.safar@seznam.cz>
13256 * class.cs (TypeContainer.IndexerArrayList): New inner class
13257 container for indexers.
13258 (TypeContainer.DefaultIndexerName): New constant for default
13259 indexer name. Replaced all "Item" with this constant.
13260 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
13262 * typemanager.cs (TypeManager.default_member_ctor): Cache here
13263 DefaultMemberAttribute constructor.
13265 2004-08-05 Martin Baulig <martin@ximian.com>
13267 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13270 2004-08-05 Marek Safar <marek.safar@seznam.cz>
13272 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
13273 multi platforms problem.
13275 * compiler.csproj: Included shared files.
13277 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13279 Fix bug 60333, 55971 in the more general way
13280 * attribute.cs (Attribute.GetAttributeArgumentExpression):
13281 Added arg_type argument for constant conversion.
13282 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
13284 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13287 * class.cs (TypeContainer ): New inner classes MethodArrayList,
13288 OperatorArrayList, MethodCoreArrayList for typecontainer
13289 containers. Changed class member types to these new types.
13290 (MethodArrayList.DefineMembers): Added test for CS0659.
13292 2004-08-04 Miguel de Icaza <miguel@ximian.com>
13294 * cfold.cs: Synchronize the folding with the code in expression.cs
13295 Binary.DoNumericPromotions for uint operands.
13297 * attribute.cs: Revert patch from Raja, it introduced a regression
13298 while building Blam-1.2.1 (hard to isolate a test case).
13300 2004-08-04 Marek Safar <marek.safar@seznam.cz>
13304 (TypeContainer.Define): Renamed to DefineContainerMembers because of
13306 (MethodCore.parent_method): New member. The method we're overriding
13307 if this is an override method.
13308 (MethodCore.CheckBase): Moved from Method class and made common.
13309 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
13311 (MethodCore.CheckForDuplications): New abstract method. For custom
13312 member duplication search in a container
13313 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
13314 method and its return type.
13315 (Event.conflict_symbol): New member. Symbol with same name in the
13319 (MemberCache.FindMemberWithSameName): New method. The method
13320 is looking for conflict with inherited symbols.
13322 2004-08-04 Martin Baulig <martin@ximian.com>
13324 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
13326 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
13328 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13330 * report.cs (Message): New enum for better error, warning reference in
13332 (MessageData): New inner abstract class. It generally handles printing of
13333 error and warning messages.
13334 Removed unused Error, Warning, Message methods.
13336 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13338 Fix for cs0592-8.cs test
13340 (Attributable.ValidAttributeTargets): Made public.
13341 (Attribute.ExplicitTarget): New member for explicit target value.
13342 (Attribute.CheckTargets): Now we translate explicit attribute
13343 target to Target here.
13345 2004-08-03 Ben Maurer <bmaurer@ximian.com>
13347 * ecore.cs (MethodGroupExpr): new IsBase property.
13349 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
13351 * delegate.cs (DelegateCreation): store a MethodGroupExpr
13352 rather than an instance expr.
13354 (DelegateCreation.Emit): Use the method group rather than
13355 the instance expression. Also, if you have base.Foo as the
13356 method for a delegate, make sure to emit ldftn, not ldftnvirt.
13358 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
13360 (NewDelegate.DoResolve): Only check for the existance of Invoke
13361 if the method is going to be needed. Use MethodGroupExpr.
13363 (NewDelegate.Emit): Remove, DelegateCreation implements this.
13365 * expression.cs: For pointer arith., make sure to use
13366 the size of the type, not the size of the pointer to
13369 2004-08-03 Marek Safar <marek.safar@seznam.cz>
13372 * class.cs (Class): Added error CS0502 test.
13374 2004-08-03 John Luke <jluke@cfl.rr.com>
13375 Raja R Harinath <rharinath@novell.com>
13378 * attribute.cs (Attribute.complained_before): New flag.
13379 (Attribute.ResolveType, Attribute.Resolve),
13380 (Attribute.DefinePInvokeMethod): Set it.
13381 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
13383 2004-08-03 Martin Baulig <martin@ximian.com>
13385 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
13386 use a user-defined operator; we still need to do numeric
13387 promotions in case one argument is a builtin type and the other
13388 one has an implicit conversion to that type. Fixes #62322.
13390 2004-08-02 Martin Baulig <martin@ximian.com>
13392 * statement.cs (LocalInfo.Flags): Added `IsThis'.
13393 (LocalInfo.IsThis): New public property.
13394 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
13396 2004-08-01 Martin Baulig <martin@ximian.com>
13398 * class.cs (TypeContainer.GetClassBases): Don't set the default
13399 here since we may get called from GetPartialBases().
13400 (TypeContainer.DefineType): If GetClassBases() didn't return a
13401 parent, use the default one.
13403 2004-07-30 Duncan Mak <duncan@ximian.com>
13405 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
13407 2004-07-30 Martin Baulig <martin@ximian.com>
13409 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
13411 * class.cs (SourceMethod): New public class, derive from the
13412 symbol writer's ISourceMethod.
13413 (Method): Use the new symbol writer API.
13415 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
13416 as argument and use the new symbol writer.
13419 (SourceFile): Implement the symbol writer's ISourceFile.
13420 (Location.SymbolDocument): Removed.
13421 (Location.SourceFile): New public property.
13423 * symbolwriter.cs: Use the new symbol writer API.
13425 2004-07-30 Raja R Harinath <rharinath@novell.com>
13427 * Makefile (install-local): Remove. Functionality moved to
13430 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
13432 * Makefile: Install mcs.exe.config file together with mcs.exe.
13433 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
13434 correct runtime version.
13436 2004-07-25 Martin Baulig <martin@ximian.com>
13439 (TypeContainer.RegisterOrder): Removed, this was unused.
13440 (TypeContainer, interface_order): Removed.
13441 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
13442 TypeContainer as argument since we can also be called with a
13443 `PartialContainer' for a partial class/struct/interface.
13444 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
13445 of checking whether we're an `Interface' - we could be a
13446 `PartialContainer'.
13447 (PartialContainer.Register): Override; call
13448 AddClass()/AddStruct()/AddInterface() on our parent.
13450 * cs-parser.jay (interface_member_declaration): Add things to the
13451 `current_container', not the `current_class'.
13453 * rootcontext.cs (RegisterOrder): The overloaded version which
13454 takes an `Interface' was unused, removed.
13456 * typemanager.cs (TypeManager.LookupInterface): Return a
13457 `TypeContainer', not an `Interface'.
13458 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
13459 contain a `PartialContainer' for an interface, so check it's
13460 `Kind' to figure out what it is.
13462 2004-07-25 Martin Baulig <martin@ximian.com>
13464 * class.cs (Class.DefaultTypeAttributes): New public constant.
13465 (Struct.DefaultTypeAttributes): Likewise.
13466 (Interface.DefaultTypeAttributes): Likewise.
13467 (PartialContainer.TypeAttr): Override this and add the
13468 DefaultTypeAttributes.
13470 2004-07-25 Martin Baulig <martin@ximian.com>
13472 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
13473 we can just use the `Parent' field instead.
13475 2004-07-25 Martin Baulig <martin@ximian.com>
13477 * class.cs (TypeContainer.Emit): Renamed to EmitType().
13479 2004-07-25 Martin Baulig <martin@ximian.com>
13481 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
13482 our parts before defining any methods.
13483 (TypeContainer.VerifyImplements): Make this virtual.
13484 (ClassPart.VerifyImplements): Override and call VerifyImplements()
13485 on our PartialContainer.
13487 2004-07-25 Martin Baulig <martin@ximian.com>
13489 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
13491 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
13492 argument, we can just use the `Parent' field instead.
13495 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
13496 (MemberBase.DoDefine): Likewise.
13498 2004-07-24 Martin Baulig <martin@ximian.com>
13500 * decl.cs (MemberCore.Parent): New public field.
13501 (DeclSpace.Parent): Moved to MemberCore.
13503 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
13504 (MemberBase.ctor): Added TypeContainer argument, pass it to our
13506 (FieldBase, Field, Operator): Likewise.
13507 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
13508 (EventField, Event): Likewise.
13510 2004-07-23 Martin Baulig <martin@ximian.com>
13512 * class.cs (PartialContainer): New public class.
13513 (ClassPart): New public class.
13514 (TypeContainer): Added support for partial classes.
13515 (TypeContainer.GetClassBases): Splitted some of the functionality
13516 out into GetNormalBases() and GetPartialBases().
13518 * cs-tokenizer.cs (Token.PARTIAL): New token.
13519 (Tokenizer.consume_identifier): Added some hacks to recognize
13520 `partial', but only if it's immediately followed by `class',
13521 `struct' or `interface'.
13523 * cs-parser.jay: Added support for partial clases.
13525 2004-07-23 Martin Baulig <martin@ximian.com>
13527 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
13528 a `DeclSpace' and also made it readonly.
13529 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
13530 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
13531 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
13533 * cs-parser.jay: Pass the `current_class', not the
13534 `current_container' (at the moment, this is still the same thing)
13535 to a new Method, Property, Event, Indexer or Constructor.
13537 2004-07-23 Martin Baulig <martin@ximian.com>
13539 * cs-parser.jay (CSharpParser): Added a new `current_class' field
13540 and removed the `current_interface' one.
13541 (struct_declaration, class_declaration, interface_declaration):
13542 Set `current_class' to the newly created class/struct/interface;
13543 set their `Bases' and call Register() before parsing their body.
13545 2004-07-23 Martin Baulig <martin@ximian.com>
13547 * class.cs (Kind): New public enum.
13548 (TypeContainer): Made this class abstract.
13549 (TypeContainer.Kind): New public readonly field.
13550 (TypeContainer.CheckDef): New public method; moved here from
13552 (TypeContainer.Register): New public abstract method.
13553 (TypeContainer.GetPendingImplementations): New public abstract
13555 (TypeContainer.GetClassBases): Removed the `is_class' and
13556 `is_iface' parameters.
13557 (TypeContainer.DefineNestedTypes): Formerly known as
13559 (ClassOrStruct): Made this class abstract.
13561 * tree.cs (RootTypes): New public type.
13563 2004-07-20 Martin Baulig <martin@ximian.com>
13565 * tree.cs (Tree.RecordNamespace): Removed.
13566 (Tree.Namespaces): Removed.
13568 * rootcontext.cs (RootContext.IsNamespace): Removed.
13570 * cs-parser.jay (namespace_declaration): Just create a new
13571 NamespaceEntry here.
13573 2004-07-20 Martin Baulig <martin@ximian.com>
13575 * statement.cs (ExceptionStatement): New abstract class. This is
13576 now used as a base class for everyone who's using `finally'.
13577 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
13578 our local variables before using them.
13580 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
13581 virtual method. This is used by Yield.Resolve() to "steal" an
13582 outer block's `finally' clauses.
13583 (FlowBranchingException): The .ctor now takes an ExceptionStatement
13586 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
13587 version which takes an ExceptionStatement. This version must be
13588 used to create exception branchings.
13591 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
13592 (Iterator.EmitMoveNext): Added exception support; protect the
13593 block with a `fault' clause, properly handle 'finally' clauses.
13594 (Iterator.EmitDispose): Run all the `finally' clauses here.
13596 2004-07-20 Martin Baulig <martin@ximian.com>
13598 * iterator.cs: This is the first of a set of changes in the
13599 iterator code. Match the spec more closely: if we're an
13600 IEnumerable, then GetEnumerator() must be called. The first time
13601 GetEnumerator() is called, it returns the current instance; all
13602 subsequent invocations (if any) must create a copy.
13604 2004-07-19 Miguel de Icaza <miguel@ximian.com>
13606 * expression.cs: Resolve the constant expression before returning
13609 2004-07-19 Martin Baulig <martin@ximian.com>
13611 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
13612 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
13613 the return type of the new EmitContext.
13615 2004-07-18 Martin Baulig <martin@ximian.com>
13617 * class.cs (Property.Define): Fix iterators.
13619 * iterators.cs (Iterator.Define): Moved the
13620 `container.AddInterator (this)' call here from the .ctor; only do
13621 it if we resolved successfully.
13623 2004-07-17 Miguel de Icaza <miguel@ximian.com>
13625 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
13626 `true' for preprocessing directives that we parse. The return
13627 value indicates whether we should return to regular tokenizing or
13628 not, not whether it was parsed successfully.
13630 In the past if we were in: #if false ... #line #endif, we would
13631 resume parsing after `#line'. See bug 61604.
13633 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
13634 building: IsEnumType should return true only for enums, not for
13635 enums or System.Enum itself. This fixes #61593.
13637 Likely what happened is that corlib was wrong: mcs depended on
13638 this bug in some places. The bug got fixed, we had to add the
13639 hack, which caused bug 61593.
13641 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
13642 that was a workaround for the older conditions.
13644 2004-07-16 Ben Maurer <bmaurer@ximian.com>
13646 * assign.cs: IAssignMethod has a new interface, as documented
13647 inline. All assignment code now uses this new api.
13649 * ecore.cs, expression.cs: All classes which implement
13650 IAssignMethod now use the new interface.
13652 * expression.cs (Invocation): add a hack to EmitCall so that
13653 IndexerAccess can be the target of a compound assignment without
13654 evaluating its arguments twice.
13656 * statement.cs: Handle changes in Invocation api.
13658 2004-07-16 Martin Baulig <martin@ximian.com>
13660 * iterators.cs: Rewrote this. We're now using one single Proxy
13661 class for both the IEnumerable and the IEnumerator interface and
13662 `Iterator' derives from Class so we can use the high-level API.
13664 * class.cs (TypeContainer.AddIterator): New method.
13665 (TypeContainer.DoDefineType): New protected virtual method, which
13666 is called from DefineType().
13667 (TypeContainer.DoDefineMembers): Call DefineType() and
13668 DefineMembers() on all our iterators.
13669 (TypeContainer.Emit): Call Emit() on all our iterators.
13670 (TypeContainer.CloseType): Call CloseType() on all our iterators.
13672 * codegen.cs (EmitContext.CurrentIterator): New public field.
13674 2004-07-15 Martin Baulig <martin@ximian.com>
13677 (TypeManager.not_supported_exception_type): New type.
13679 2004-07-14 Martin Baulig <martin@ximian.com>
13681 * iterators.cs: Use real error numbers.
13683 2004-07-14 Martin Baulig <martin@ximian.com>
13685 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
13686 requires this to be a System.Collection.IEnumerable and not a
13687 class implementing that interface.
13688 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
13690 2004-07-13 Marek Safar <marek.safar@seznam.cz>
13692 * class.cs: Fixed previous fix, it broke some error tests.
13694 2004-07-12 Martin Baulig <martin@ximian.com>
13696 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
13699 2004-07-09 Miguel de Icaza <miguel@ximian.com>
13701 * assign.cs (LocalTemporary): Add new argument: is_address,If
13702 `is_address' is true, then the value that we store is the address
13703 to the real value, and not the value itself.
13705 * ecore.cs (PropertyExpr): use the new local temporary
13706 stuff to allow us to handle X.Y += z (where X is a struct)
13708 2004-07-08 Martin Baulig <martin@ximian.com>
13710 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
13711 not always return, just like we're doing in Using.Resolve().
13713 2004-07-07 Miguel de Icaza <miguel@ximian.com>
13715 * cs-parser.jay (fixed_statement): flag this as Pinned.
13717 2004-07-06 Miguel de Icaza <miguel@ximian.com>
13719 * typemanager.cs (TypeManager): Removed MakePinned method, this
13720 mechanism is replaced with the .NET 2.x compatible mechanism of
13721 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
13723 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
13724 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
13725 `IsFixed' property which has a different meaning.
13727 2004-07-02 Raja R Harinath <rharinath@novell.com>
13729 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
13730 visible from inside a nested class, not just the names of the
13731 immediately enclosing class.
13732 Fix for bug #60730.
13734 2004-06-24 Raja R Harinath <rharinath@novell.com>
13736 * expression.cs (BetterConversion): Remove buggy special-case
13737 handling of "implicit constant expression conversions". At this
13738 point, we already know that the conversion is possible -- we're
13739 only checking to see which is better.
13741 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13743 * cs-parser.jay: Added error CS0210 test.
13745 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13747 * cs-parser.jay: Added error CS0134 test.
13749 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13752 * cs-parser.jay: Added error CS0145 test.
13754 2004-06-24 Marek Safar <marek.safar@seznam.cz>
13756 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
13758 2004-06-23 Ben Maurer <bmaurer@ximian.com>
13760 * expression.cs (StackAlloc.Resolve): The argument may not
13761 be a constant; deal with this case.
13763 2004-06-23 Marek Safar <marek.safar@seznam.cz>
13765 * attribute.cs (IndexerName_GetIndexerName): Renamed to
13766 GetIndexerAttributeValue.
13767 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
13769 * class.cs (Indexer.Define): Added error tests for CS0415,
13772 2004-06-23 Miguel de Icaza <miguel@ximian.com>
13774 * attribute.cs (Attribute.Resolve): Keep field code in sync with
13777 2004-06-23 Martin Baulig <martin@ximian.com>
13779 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
13780 neither return nor throw, reset the barrier as well. Fixes #60457.
13782 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
13784 * class.cs : EventAttributes is now set to None by default.
13785 This fixes bug #60459.
13787 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13790 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
13791 Don't throw exception but return null (it's sufficient now).
13793 2004-06-18 Marek Safar <marek.safar@seznam.cz>
13795 * typemanager.cs (GetArgumentTypes): Faster implementation.
13797 2004-06-18 Martin Baulig <martin@ximian.com>
13799 * attribute.cs (Attribute.Resolve): Check whether we're an
13800 EmptyCast which a Constant child. Fixes #60333.
13802 2004-06-17 Ben Maurer <bmaurer@ximian.com>
13804 * statement.cs (EmitCollectionForeach): Account for the fact that
13805 not all valuetypes are in areas which we can take the address of.
13806 For these variables, we store to a temporary variable. Also, make
13807 sure that we dont emit a `callvirt' on a valuetype method.
13809 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13811 * expression.cs (StackAlloc.DoReSolve): Added test for
13812 negative parameter (CS0247).
13814 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13817 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
13819 2004-06-15 Marek Safar <marek.safar@seznam.cz>
13822 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
13825 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13827 Fix bug #58254 & cs1555.cs, cs1556.cs
13828 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
13830 2004-06-14 Marek Safar <marek.safar@seznam.cz>
13832 * cs-parser.jay: Added error CS1669 test for indexers.
13834 2004-06-11 Martin Baulig <martin@ximian.com>
13836 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
13837 call this twice: for params and varargs methods.
13839 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13842 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
13844 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13846 * attribute.cs (Attribute.GetValidTargets): Made public.
13849 (AbstractPropertyEventMethod): New class for better code sharing.
13850 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
13852 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
13854 2004-06-11 Raja R Harinath <rharinath@novell.com>
13857 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
13858 that the call to Resolve is part of a MemberAccess.
13859 (Expression.Resolve): Use it for SimpleName resolution.
13860 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
13861 Add 'intermediate' boolean argument.
13862 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
13863 error message when the SimpleName can be resolved ambiguously
13864 between an expression and a type.
13865 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
13867 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
13868 call on the left-side.
13870 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13873 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
13875 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13877 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
13879 2004-06-11 Martin Baulig <martin@ximian.com>
13881 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
13882 varargs methods if applicable.
13884 2004-06-11 Martin Baulig <martin@ximian.com>
13886 * expression.cs (Invocation.EmitCall): Don't use
13887 `method.CallingConvention == CallingConventions.VarArgs' since the
13888 method could also have `CallingConventions.HasThis'.
13890 2004-06-11 Marek Safar <marek.safar@seznam.cz>
13892 * class.cs (Event.GetSignatureForError): Implemented.
13893 Fixed crash in error test cs3010.cs
13895 2004-06-10 Miguel de Icaza <miguel@ximian.com>
13897 * cs-tokenizer.cs: Change the way we track __arglist to be
13898 consistent with the other keywords.
13900 2004-06-09 Miguel de Icaza <miguel@ximian.com>
13902 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
13905 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
13907 * codegen.cs: Check that all referenced assemblies have a strongname
13908 before strongnaming the compiled assembly. If not report error CS1577.
13909 Fix bug #56563. Patch by Jackson Harper.
13910 * typemanager.cs: Added a method to return all referenced assemblies.
13911 Fix bug #56563. Patch by Jackson Harper.
13913 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13916 (Method.ApplyAttributeBuilder): Moved and added conditional
13917 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
13920 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
13922 2004-06-08 Marek Safar <marek.safar@seznam.cz>
13925 * class.cs: (EventField.attribute_targets): Changed default target.
13927 2004-06-08 Martin Baulig <martin@ximian.com>
13929 * expression.cs (Invocation.EmitCall): Enable varargs methods.
13931 2004-06-08 Martin Baulig <martin@ximian.com>
13933 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
13935 2004-06-07 Martin Baulig <martin@ximian.com>
13937 Added support for varargs methods.
13939 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
13942 * cs-parser.jay: Added support for `__arglist'.
13944 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
13946 * expression.cs (Argument.AType): Added `ArgList'.
13947 (Invocation): Added support for varargs methods.
13948 (ArglistAccess): New public class.
13949 (Arglist): New public class.
13951 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
13953 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
13954 a method's top-level block if the method has varargs.
13956 * support.cs (ReflectionParameters, InternalParameters): Added
13957 support for varargs methods.
13959 2004-06-07 Miguel de Icaza <miguel@ximian.com>
13961 * class.cs: Provide location in indexer error report.
13963 * driver.cs: Use standard names.
13965 * namespace.cs: Catch the use of using after a namespace has been
13966 declared also on using aliases.
13968 2004-06-03 Raja R Harinath <rharinath@novell.com>
13971 * typemanager.cs (closure_private_ok, closure_invocation_type)
13972 (closure_qualifier_type, closure_invocation_assembly)
13973 (FilterWithClosure): Move to ...
13974 (Closure): New internal nested class.
13975 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
13976 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
13977 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
13978 (MemberLookup, MemberLookupFailed): Use it.
13979 * expression.cs (New.DoResolve): Treat the lookup for the
13980 constructor as being qualified by the 'new'ed type.
13981 (Indexers.GetIndexersForTypeOrInterface): Update.
13983 2004-06-03 Marek Safar <marek.safar@seznam.cz>
13986 (GetConditionalAttributeValue): New method. Returns
13987 condition of ConditionalAttribute.
13988 (SearchMulti): New method. Returns all attributes of type 't'.
13989 Use it when attribute is AllowMultiple = true.
13990 (IsConditionalMethodExcluded): New method.
13993 (Method.IsExcluded): Implemented. Returns true if method has conditional
13994 attribute and the conditions is not defined (method is excluded).
13995 (IMethodData): Extended interface for ConditionalAttribute support.
13996 (PropertyMethod.IsExcluded): Implemented.
13999 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
14002 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
14005 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
14007 * expression.cs (ArrayCreationExpression): Make this just an
14008 `expression'. It can't be a statement, so the code here was
14011 2004-06-02 Marek Safar <marek.safar@seznam.cz>
14014 * typemanager.cs (GetFullNameSignature): New method for
14017 2004-06-02 Marek Safar <marek.safar@seznam.cz>
14020 * class.cs (MemberBase.GetSignatureForError): New virtual method.
14021 Use this method when MethodBuilder is null.
14022 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
14023 Added test for error CS0626 (MONO reports error for this situation).
14024 (IMethodData.GetSignatureForError): Extended interface.
14026 2004-06-01 Marek Safar <marek.safar@seznam.cz>
14029 (AttributeTester.GetObsoleteAttribute): Returns instance of
14030 ObsoleteAttribute when type is obsolete.
14033 (TypeContainer.VerifyObsoleteAttribute): Override.
14034 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
14035 (MethodCode.VerifyObsoleteAttribute): Override.
14036 (MemberBase.VerifyObsoleteAttribute): Override.
14039 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
14040 and report proper error.
14043 Delegate.VerifyObsoleteAttribute): Override.
14046 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
14047 and report proper error.
14048 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
14051 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
14055 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
14056 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
14057 Added test for ObsoleteAttribute.
14060 (Catch): Derived from Statement.
14062 2004-06-01 Marek Safar <marek.safar@seznam.cz>
14064 Fixed bug #59071 & cs0160.cs
14066 * statement.cs (Try.Resolve): Check here whether order of catch
14067 clauses matches their dependencies.
14069 2004-05-31 Miguel de Icaza <miguel@ximian.com>
14071 * Reverted patch to namespace.cs (Use lookuptypedirect). This
14072 caused a regression: #59343. Referencing nested classes from an
14073 assembly stopped working.
14075 2004-05-31 Martin Baulig <martin@ximian.com>
14077 MCS is now frozen for beta 2.
14079 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14081 * convert.cs: add a trivial cache for overload operator resolution.
14083 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14085 * decl.cs: If possible, use lookuptypedirect here. We can only do
14086 this if there is no `.' after the namespace. Avoids using
14087 LookupType, which does lots of slow processing.
14088 (FindNestedType) New method, does what it says :-).
14089 * namespace.cs: use LookupTypeDirect.
14090 * rootcontext.cs: use membercache, if possible.
14091 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
14093 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14096 According to the spec,
14098 In a member access of the form E.I, if E is a single identifier,
14099 and if the meaning of E as a simple-name (§7.5.2) is a constant,
14100 field, property, localvariable, or parameter with the same type as
14101 the meaning of E as a type-name (§3.8), then both possible
14102 meanings of E are permitted.
14104 We did not check that E as a simple-name had the same type as E as
14107 This trivial check gives us 5-7% on bootstrap time.
14109 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
14111 * expression.cs (Invocation.OverloadResolve): Avoid the
14112 use of hashtables and boxing here by allocating on demand.
14114 2004-05-30 Martin Baulig <martin@ximian.com>
14116 * rootcontext.cs (RootContext.LookupType): Don't cache things if
14117 we're doing a silent lookup. Don't try to lookup nested types in
14118 TypeManager.object_type (thanks to Ben Maurer).
14120 2004-05-30 Martin Baulig <martin@ximian.com>
14122 Committing a patch from Ben Maurer.
14124 * rootcontext.cs (RootContext.LookupType): Cache negative results.
14126 2004-05-29 Martin Baulig <martin@ximian.com>
14128 * class.cs (IMethodData.ShouldIgnore): New method.
14130 * typemanager.cs (TypeManager.MethodFlags): Don't take a
14131 `Location' argument, we don't need it anywhere. Use
14132 `IMethodData.ShouldIgnore ()' instead of
14133 `MethodData.GetMethodFlags ()'.
14134 (TypeManager.AddMethod): Removed.
14135 (TypeManager.AddMethod2): Renamed to AddMethod.
14137 2004-05-29 Martin Baulig <martin@ximian.com>
14139 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
14141 * convert.cs (Convert.ImplicitReferenceConversion): If we're
14142 converting from a class type S to an interface type and we already
14143 have an object on the stack, don't box it again. Fixes #52578.
14145 2004-05-29 Martin Baulig <martin@ximian.com>
14147 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
14148 Added support for `params' parameters. Fixes #59267.
14150 2004-05-29 Martin Baulig <martin@ximian.com>
14152 * literal.cs (NullPointer): Provide a private .ctor which sets
14153 `type' to TypeManager.object_type. Fixes #59048.
14155 2004-05-29 Martin Baulig <martin@ximian.com>
14157 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
14158 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
14160 * ecore.cs (EventExpr.instance_expr): Make the field private.
14162 2004-05-26 Marek Safar <marek.safar@seznam.cz>
14164 Fixed bug #50080 & cs0214-2.cs
14165 * expression.cs (Cast.DoResolve): Check unsafe context here.
14167 * statement.cs (Resolve.DoResolve): Likewise.
14169 2004-05-26 Martin Baulig <martin@ximian.com>
14171 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
14173 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
14174 (RootContext.LookupType): Pass down the `silent' flag.
14176 2004-05-25 Martin Baulig <martin@ximian.com>
14179 (MethodGroupExpr.IdenticalTypeName): New public property.
14180 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
14181 expression actually refers to a type.
14183 2004-05-25 Martin Baulig <martin@ximian.com>
14185 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
14186 for #56176 and made it actually work.
14188 2004-05-25 Martin Baulig <martin@ximian.com>
14190 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
14191 (FieldExpr, PropertyExpr): Override and implement
14192 CacheTemporaries. Fixes #52279.
14194 2004-05-25 Miguel de Icaza <miguel@ximian.com>
14196 * location.cs: In the new compiler listing a file twice is a
14197 warning, not an error.
14199 2004-05-24 Martin Baulig <martin@ximian.com>
14201 * enum.cs (Enum.DefineType): For the `BaseType' to be a
14202 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
14204 2004-05-24 Martin Baulig <martin@ximian.com>
14206 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
14207 walking the `using' list. Fixes #53921.
14209 2004-05-24 Martin Baulig <martin@ximian.com>
14211 * const.cs (Const.LookupConstantValue): Added support for
14212 EmptyCast's; fixes #55251.
14214 2004-05-24 Martin Baulig <martin@ximian.com>
14216 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
14217 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
14218 which does the CS0135 check. The reason is that we first need to
14219 check whether the variable actually exists.
14221 2004-05-24 Martin Baulig <martin@ximian.com>
14223 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
14224 than RootContext.LookupType() to find the explicit interface
14225 type. Fixes #58584.
14227 2004-05-24 Raja R Harinath <rharinath@novell.com>
14229 * Makefile: Simplify. Use executable.make.
14230 * mcs.exe.sources: New file. List of sources of mcs.exe.
14232 2004-05-24 Anders Carlsson <andersca@gnome.org>
14236 Use the invariant culture when doing String.Compare for CLS case
14239 2004-05-23 Martin Baulig <martin@ximian.com>
14241 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
14242 don't have any dots. Fixes #52622, added cs0246-8.cs.
14244 * namespace.cs (NamespaceEntry.Lookup): Likewise.
14246 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14248 * class.cs (MemberBase.Define): Reuse MemberType member for
14249 resolved type. Other methods can use it too.
14251 2004-05-23 Martin Baulig <martin@ximian.com>
14253 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
14254 the variable also exists in the current block (otherwise, we need
14255 to report a CS0103). Fixes #58670.
14257 2004-05-23 Martin Baulig <martin@ximian.com>
14259 * flowanalysis.cs (Reachability.Reachable): Compute this
14260 on-the-fly rather than storing it as a field.
14262 2004-05-23 Martin Baulig <martin@ximian.com>
14264 * flowanalysis.cs (Reachability.And): Manually compute the
14265 resulting `barrier' from the reachability.
14267 2004-05-23 Marek Safar <marek.safar@seznam.cz>
14270 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
14271 instance of ObsoleteAttribute when symbol is obsolete.
14274 (IMethodData): Extended interface for ObsoleteAttribute support.
14276 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14278 * attribute.cs: Fix bug #55970
14280 2004-05-22 Marek Safar <marek.safar@seznam.cz>
14284 (GetObsoleteAttribute): New method. Creates the instance of
14286 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
14287 ObsoleteAttribute when member is obsolete.
14288 (AttributeTester.Report_ObsoleteMessage): Common method for
14289 Obsolete error/warning reporting.
14292 (TypeContainer.base_classs_type): New member for storing parent type.
14295 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
14296 for this MemberCore.
14298 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14300 * attribute.cs, const.cs: Fix bug #58590
14302 2004-05-21 Martin Baulig <martin@ximian.com>
14304 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
14305 out parameters if the end of the method is unreachable. Fixes
14308 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14310 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
14311 Hari was right, why extra method.
14313 2004-05-21 Marek Safar <marek.safar@seznam.cz>
14315 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
14317 2004-05-20 Martin Baulig <martin@ximian.com>
14319 Merged this back from gmcs to keep the differences to a minumum.
14321 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
14322 instead of a Declspace.
14323 (Attribute.ResolveType): Likewise.
14324 (Attributes.Search): Likewise.
14325 (Attributes.Contains): Likewise.
14326 (Attributes.GetClsCompliantAttribute): Likewise.
14328 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
14330 (MethodData.ApplyAttributes): Take an EmitContext instead of a
14333 2004-05-19 Marek Safar <marek.safar@seznam.cz>
14335 Fix bug #58688 (MCS does not report error when the same attribute
14338 * attribute.cs (Attribute.Emit): Distinction between null and default.
14340 2004-05-19 Raja R Harinath <rharinath@novell.com>
14342 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
14343 of a top-level attribute without an attribute target.
14344 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
14346 (Attribute.Conditional_GetConditionName),
14347 (Attribute.Obsolete_GetObsoleteMessage): Update.
14348 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
14349 part of ScanForIndexerName.
14350 (Attribute.CanIgnoreInvalidAttribute): New function.
14351 (Attribute.ScanForIndexerName): Move to ...
14352 (Attributes.ScanForIndexerName): ... here.
14353 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
14354 (Attributes.Search): New internal variant that can choose not to
14355 complain if types aren't resolved. The original signature now
14357 (Attributes.GetClsCompliantAttribute): Use internal variant, with
14358 complaints suppressed.
14359 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
14360 only if it not useful.
14361 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
14362 top-level for attributes that are shared between the assembly
14363 and a top-level class.
14364 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
14365 * class.cs: Update to reflect changes.
14366 (DefineIndexers): Fuse loops.
14367 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
14368 a couple more variants of attribute names.
14370 2004-05-18 Marek Safar <marek.safar@seznam.cz>
14372 Fix bug #52585 (Implemented explicit attribute declaration)
14375 (Attributable.ValidAttributeTargets): New abstract method. It gets
14376 list of valid attribute targets for explicit target declaration.
14377 (Attribute.Target): It holds target itself.
14378 (AttributeSection): Removed.
14379 (Attribute.CheckTargets): New method. It checks whether attribute
14380 target is valid for the current element.
14383 (EventProperty): New class. For events that are declared like
14384 property (with add and remove accessors).
14385 (EventField): New class. For events that are declared like field.
14388 * cs-parser.jay: Implemented explicit attribute target declaration.
14390 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
14391 Override ValidAttributeTargets.
14394 (ReturnParameter): Class for applying custom attributes on
14396 (ParameterAtribute): New class. Class for applying custom
14397 attributes on the parameter type.
14399 2004-05-17 Miguel de Icaza <miguel@ximian.com>
14401 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
14404 (Method): Allow UNSAFE here.
14406 * modifiers.cs: Support unsafe reporting.
14408 2004-05-17 Marek Safar <marek.safar@seznam.cz>
14410 * decl.cs: Fix bug #58478.
14412 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14414 * statement.cs: When checking for unreachable code on an EmptyStatement,
14415 set the location. Fixes bug #58488.
14417 2004-05-13 Miguel de Icaza <miguel@ximian.com>
14419 * driver.cs: Add -pkg handling.
14421 From Gonzalo: UseShelLExecute=false
14423 2004-05-12 Marek Safar <marek.safar@seznam.cz>
14426 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
14428 (Attribute.IsClsCompliaceRequired): Moved to base for better
14430 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
14431 when attribute is AttributeUsageAttribute.
14432 (Attribute.GetValidTargets): Simplified.
14433 (Attribute.GetAttributeUsage): New method returns AttributeUsage
14434 attribute for this type.
14435 (Attribute.ApplyAttributes): Method renamed to Emit and make
14437 (GlobalAttributeSection): New class for special handling of global
14438 attributes (assembly, module).
14439 (AttributeSection.Emit): New method.
14441 * class.cs: Implemented Attributable abstract methods.
14442 (MethodCore.LabelParameters): Moved to Parameter class.
14443 (Accessor): Is back simple class.
14444 (PropertyMethod): Implemented Attributable abstract class.
14445 (DelegateMethod): Implemented Attributable abstract class.
14446 (Event): New constructor for disctintion between normal Event
14447 and Event with accessors.
14449 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
14451 * codegen.cs, const.cs, decl.cs, delegate.cs:
14452 (CommonAssemblyModulClass): Implemented Attributable abstract class
14455 * enum.cs: Implement IAttributeSupport interface.
14456 (EnumMember): New class for emum members. Implemented Attributable
14460 (ParameterBase): Is abstract.
14461 (ReturnParameter): New class for easier [return:] attribute handling.
14463 * typemanager.cs: Removed builder_to_attr.
14465 2004-05-11 Raja R Harinath <rharinath@novell.com>
14468 * attribute.cs (Attribute.GetPositionalValue): New function.
14469 * class.cs (TypeContainer.VerifyMembers): New function.
14470 (TypeContainer.Emit): Use it.
14471 (ClassOrStruct): New base class for Class and Struct.
14472 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
14473 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
14475 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
14476 then each non-static field should have a FieldOffset attribute.
14477 Otherwise, none of the fields should have a FieldOffset attribute.
14478 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
14479 and FieldOffset attributes.
14480 * typemanager.cs (TypeManager.struct_layout_attribute_type)
14481 (TypeManager.field_offset_attribute_type): New core types.
14482 (TypeManager.InitCoreTypes): Initialize them.
14484 2004-05-11 Michal Moskal <malekith@pld-linux.org>
14486 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
14487 Return correct type.
14490 2004-05-09 Miguel de Icaza <miguel@ximian.com>
14492 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
14493 be implicitly converted to ulong.
14495 * expression.cs: The logic for allowing operator &, | and ^ worked
14496 was wrong, it worked before because we did not report an error in
14497 an else branch. Fixes 57895.
14499 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
14500 allow volatile fields to be reference types.
14502 2004-05-07 Miguel de Icaza <miguel@ximian.com>
14504 * driver.cs: Add support for /debug-
14506 2004-05-07 Raja R Harinath <rharinath@novell.com>
14508 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
14509 Add a 'complain' parameter to silence errors.
14510 (Attribute.Resolve): Update to changes. Put in sanity check to catch
14511 silently overlooked type-resolutions.
14512 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
14513 to reflect changes.
14514 (Attributes.Search): New function.
14515 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
14516 (Attributes.GetAttributeFullName): Remove hack.
14517 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
14518 Update to reflect changes.
14519 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14520 Use Attributes.Search instead of nested loops.
14522 2004-05-07 Marek Safar <marek.safar@seznam.cz>
14525 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
14526 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
14527 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
14529 * report.cs: (Report.Warning): Renamed to Warning_T because of
14530 parameter collision.
14532 2004-05-05 Raja R Harinath <rharinath@novell.com>
14534 * expression.cs (MemberAccess.ResolveMemberAccess):
14535 Exit with non-zero status after Report.Error.
14536 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
14538 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
14540 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14542 * support.cs: Don't hang when the file is empty.
14544 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
14546 * support.cs: In SeekableStreamReader, compute the preamble size of the
14547 underlying stream. Position changes should take into account that initial
14550 2004-05-03 Todd Berman <tberman@sevenl.net>
14552 * driver.cs: remove unused GetSysVersion function.
14554 2004-05-03 Todd Berman <tberman@sevenl.net>
14556 * driver.cs: Remove the hack from saturday, as well as the hack
14557 from jackson (LoadAssemblyFromGac), also adds the CWD to the
14558 link_paths to get that bit proper.
14560 2004-05-01 Todd Berman <tberman@sevenl.net>
14562 * driver.cs: Try a LoadFrom before a Load, this checks the current
14563 path. This is currently a bug in mono that is be fixed, however, this
14564 provides a workaround for now. This will be removed when the bug
14567 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
14569 * CryptoConvert.cs: Updated to latest version. Fix issue with
14570 incomplete key pairs (#57941).
14572 2004-05-01 Todd Berman <tberman@sevenl.net>
14574 * driver.cs: Remove '.' from path_chars, now System.* loads properly
14577 2004-04-30 Jackson Harper <jackson@ximian.com>
14579 * codegen.cs: Open keys readonly.
14581 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
14583 * typemanager.cs: don't report cyclic struct layout when a struct
14584 contains 2 or more fields of the same type. Failed for Pango.AttrShape
14585 which has 2 Pango.Rectangle fields.
14587 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
14589 * expression.cs: Handle IntPtr comparisons with IL code
14590 rather than a method call.
14592 2004-04-29 Martin Baulig <martin@ximian.com>
14594 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
14595 the list of PropertyInfo's in class hierarchy and find the
14596 accessor. Fixes #56013.
14598 2004-04-29 Martin Baulig <martin@ximian.com>
14600 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
14602 2004-04-29 Martin Baulig <martin@ximian.com>
14604 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14606 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
14608 2004-04-29 Martin Baulig <martin@ximian.com>
14610 * class.cs (ConstructorInitializer.Resolve): Check whether the
14611 parent .ctor is accessible. Fixes #52146.
14613 2004-04-29 Martin Baulig <martin@ximian.com>
14615 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
14617 * statement.cs (Using.EmitLocalVariableDecls): Use
14618 TypeManager.idisposable_type, not typeof (IDisposable).
14619 (Foreach.EmitCollectionForeach): Added support for valuetypes.
14621 2004-04-29 Martin Baulig <martin@ximian.com>
14623 * class.cs (Event.Define): Don't emit the field and don't set
14624 RTSpecialName and SpecialName for events on interfaces. Fixes
14627 2004-04-29 Raja R Harinath <rharinath@novell.com>
14629 Refactor Attribute.ApplyAttributes.
14630 * attribute.cs (Attributable): New base class for objects that can
14631 have Attributes applied on them.
14632 (Attribute): Make AttributeUsage fields public.
14633 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
14634 (Attribute.IsInternalCall): New property.
14635 (Attribute.UsageAttr): Convert to a public read-only property.
14636 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
14637 (Attribute.ResolveType, Attribute.Resolve)
14638 (Attribute.ScanForIndexerName): Update to reflect changes.
14639 (Attribute.CheckAttributeTarget): Re-format.
14640 (Attribute.ApplyAttributes): Refactor, to various
14641 Attributable.ApplyAttributeBuilder methods.
14642 * decl.cs (MemberCore): Make Attributable.
14643 * class.cs (Accessor): Make Attributable.
14644 (MethodData.ApplyAttributes): Use proper attribute types, not
14646 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
14647 (TypeContainer.ApplyAttributeBuilder)
14648 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
14649 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
14650 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
14651 (Operator.ApplyAttributeBuilder): New factored-out methods.
14652 * const.cs (Const.ApplyAttributeBuilder): Likewise.
14653 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
14654 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
14655 * parameter.cs (ParameterBase): New Attributable base class
14656 that can also represent Return types.
14657 (Parameter): Update to the changes.
14659 2004-04-29 Jackson Harper <jackson@ximian.com>
14661 * driver.cs: Prefer the corlib system version when looking for
14662 assemblies in the GAC. This is still a hack, but its a better hack
14665 2004-04-29 Marek Safar <marek.safar@seznam.cz>
14667 * decl.cs, enum.cs: Improved error 3005 reporting.
14669 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
14670 (related_symbols): New private member for list of symbols
14671 related to reported error/warning.
14673 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
14675 2004-04-29 Martin Baulig <martin@ximian.com>
14677 * ecore.cs (Expression.Constantify): If we're an enum and
14678 TypeManager.TypeToCoreType() doesn't give us another type, use
14679 t.UnderlyingSystemType. Fixes #56178.
14681 2004-04-29 Martin Baulig <martin@ximian.com>
14683 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
14684 interfaces and for each interface, only add members directly
14685 declared in that interface. Fixes #53255.
14687 2004-04-28 Martin Baulig <martin@ximian.com>
14689 * expression.cs (ConditionalLogicalOperator): Use a temporary
14690 variable for `left' to avoid that we evaluate it more than once;
14693 2004-04-28 Martin Baulig <martin@ximian.com>
14695 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
14698 2004-04-28 Martin Baulig <martin@ximian.com>
14700 * statement.cs (LocalInfo.Resolve): Check whether the type is not
14703 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
14704 whether the type is not void (CS1547).
14706 2004-04-28 Martin Baulig <martin@ximian.com>
14708 * expression.cs (Unary.DoResolveLValue): Override this and report
14709 CS0131 for anything but Operator.Indirection.
14711 2004-04-28 Martin Baulig <martin@ximian.com>
14713 Committing a patch from Ben Maurer; see bug #50820.
14715 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14718 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14721 2004-04-28 Martin Baulig <martin@ximian.com>
14723 Committing a patch from Ben Maurer; see bug #50820.
14725 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
14728 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
14731 2004-04-28 Martin Baulig <martin@ximian.com>
14733 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
14734 (Block.AddLabel): Call DoLookupLabel() to only search in the
14737 2004-04-28 Martin Baulig <martin@ximian.com>
14739 * cfold.cs (ConstantFold.BinaryFold): Added special support for
14740 comparing StringConstants and NullLiterals in Equality and Inequality.
14742 2004-04-28 Jackson Harper <jackson@ximian.com>
14744 * driver.cs: Attempt to load referenced assemblies from the
14745 GAC. This is the quick and dirty version of this method that
14746 doesnt take into account versions and just takes the first
14747 canidate found. Will be good enough for now as we will not have more
14748 then one version installed into the GAC until I update this method.
14750 2004-04-28 Martin Baulig <martin@ximian.com>
14752 * typemanager.cs (TypeManager.CheckStructCycles): New public
14753 static method to check for cycles in the struct layout.
14755 * rootcontext.cs (RootContext.PopulateTypes): Call
14756 TypeManager.CheckStructCycles() for each TypeContainer.
14757 [Note: We only need to visit each type once.]
14759 2004-04-28 Martin Baulig <martin@ximian.com>
14761 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
14763 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
14764 success and added `out object value'. Use a `bool resolved' field
14765 to check whether we've already been called rather than
14766 `ConstantValue != null' since this breaks for NullLiterals.
14768 2004-04-28 Raja R Harinath <rharinath@novell.com>
14770 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
14771 setting of this flag, since the 'set' method may be non-public.
14773 2004-04-28 Raja R Harinath <rharinath@novell.com>
14775 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
14776 check on current_vector.Block.
14778 2004-04-27 Martin Baulig <martin@ximian.com>
14780 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
14781 a field initializer. Fixes #56459.
14783 2004-04-27 Martin Baulig <martin@ximian.com>
14785 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
14786 we're not attempting to use an indexer. Fixes #52154.
14788 2004-04-27 Martin Baulig <martin@ximian.com>
14790 * statement.cs (Return): Don't create a return label if we don't
14791 need it; reverts my change from January 20th. Thanks to Ben
14794 2004-04-27 Martin Baulig <martin@ximian.com>
14796 According to the spec, `goto' can only leave a nested scope, but
14799 * statement.cs (Block.LookupLabel): Only lookup in the current
14800 block, don't recurse into parent or child blocks.
14801 (Block.AddLabel): Check in parent and child blocks, report
14802 CS0140/CS0158 if we find a duplicate.
14803 (Block): Removed this indexer for label lookups.
14804 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
14805 this already does the error reporting for us.
14808 (FlowBranching.UsageVector.Block): New public variable; may be null.
14809 (FlowBranching.CreateSibling): Added `Block' argument.
14810 (FlowBranching.LookupLabel): New public virtual method. Lookup a
14811 label for the target of a `goto' and check whether we're not
14812 leaving a `finally'.
14814 2004-04-27 Martin Baulig <martin@ximian.com>
14816 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14817 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
14820 2004-04-27 Martin Baulig <martin@ximian.com>
14822 * statement.cs (Block.AddLabel): Also check for implicit blocks
14823 and added a CS0158 check.
14825 2004-04-27 Martin Baulig <martin@ximian.com>
14827 * flowanalysis.cs (FlowBranchingLoop): New class.
14828 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
14829 UsageVector's instead of an ArrayList.
14830 (FlowBranching.Label): Likewise.
14831 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
14832 (FlowBranching.AddBreakVector): New method.
14834 2004-04-27 Miguel de Icaza <miguel@ximian.com>
14836 * attribute.cs: Small regression fix: only convert the type if we
14837 the type is different, fixes System.Drawing build.
14839 2004-04-27 Martin Baulig <martin@ximian.com>
14841 * attribute.cs (Attribute.Resolve): If we have a constant value
14842 for a named field or property, implicity convert it to the correct
14845 2004-04-27 Raja R Harinath <rharinath@novell.com>
14847 * statement.cs (Block.Block): Implicit blocks share
14848 'child_variable_names' fields with parent blocks.
14849 (Block.AddChildVariableNames): Remove.
14850 (Block.AddVariable): Mark variable as "used by a child block" in
14851 every surrounding block.
14852 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
14853 been used in a child block, complain about violation of "Invariant
14854 meaning in blocks" rule.
14855 * cs-parser.jay (declare_local_variables): Don't use
14856 AddChildVariableNames.
14857 (foreach_statement): Don't create an implicit block: 'foreach'
14858 introduces a scope.
14860 2004-04-23 Miguel de Icaza <miguel@ximian.com>
14862 * convert.cs (ImplicitNumericConversion): 0 is also positive when
14863 converting from 0L to ulong. Fixes 57522.
14865 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14867 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
14868 derived class hides via 'new' keyword field from base class (test-242.cs).
14869 TODO: Handle this in the more general way.
14871 * class.cs (CheckBase): Ditto.
14873 2004-04-22 Marek Safar <marek.safar@seznam.cz>
14875 * decl.cs (caching_flags): New member for storing cached values
14877 (MemberCore.Flags): New enum where bit flags for caching_flags
14879 (MemberCore.cls_compliance): Moved to caching_flags.
14880 (DeclSpace.Created): Moved to caching_flags.
14882 * class.cs: Use caching_flags instead of DeclSpace.Created
14884 2004-04-21 Miguel de Icaza <miguel@ximian.com>
14886 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
14887 if we are only a derived class, not a nested class.
14889 * typemanager.cs: Same as above, but do this at the MemberLookup
14890 level (used by field and methods, properties are handled in
14891 PropertyExpr). Allow for the qualified access if we are a nested
14894 2004-04-21 Marek Safar <marek.safar@seznam.cz>
14896 * class.cs: Refactoring.
14897 (IMethodData): New inteface; Holds links to parent members
14898 to avoid member duplication (reduced memory allocation).
14899 (Method): Implemented IMethodData interface.
14900 (PropertyBase): New inner classes for get/set methods.
14901 (PropertyBase.PropertyMethod): Implemented IMethodData interface
14902 (Event): New inner classes for add/remove methods.
14903 (Event.DelegateMethod): Implemented IMethodData interface.
14905 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
14906 EmitContext (related to class.cs refactoring).
14908 2004-04-21 Raja R Harinath <rharinath@novell.com>
14910 * delegate.cs (Delegate.VerifyApplicability): If the number of
14911 arguments are the same as the number of parameters, first try to
14912 verify applicability ignoring any 'params' modifier on the last
14916 2004-04-16 Raja R Harinath <rharinath@novell.com>
14918 * class.cs (TypeContainer.AddIndexer): Use
14919 'ExplicitInterfaceName' to determine if interface name was
14920 explicitly specified. 'InterfaceType' is not initialized at this time.
14921 (TypeContainer.DefineIndexers): Remove use of temporary list. The
14922 Indexers array is already in the required order. Initialize
14923 'IndexerName' only if there are normal indexers.
14924 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
14925 (TypeContainer.Emit): Emit DefaultMember attribute only if
14926 IndexerName is initialized.
14929 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
14931 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
14934 2004-04-15 Raja R Harinath <rharinath@novell.com>
14936 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
14940 * attribute.cs (Attribute.Resolve): Check for duplicate named
14944 2004-04-15 Miguel de Icaza <miguel@ximian.com>
14946 * iterators.cs (MarkYield): track whether we are in an exception,
14947 and generate code accordingly. Use a temporary value to store the
14948 result for our state.
14950 I had ignored a bit the interaction of try/catch with iterators
14951 since their behavior was not entirely obvious, but now it is
14952 possible to verify that our behavior is the same as MS .NET 2.0
14956 2004-04-14 Miguel de Icaza <miguel@ximian.com>
14958 * iterators.cs: Avoid creating temporaries if there is no work to
14961 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
14962 Enumerations, use TypeManager.EnumToUnderlying and call
14965 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
14968 (This.Emit): Use EmitContext.EmitThis to emit our
14971 (This.EmitAssign): Ditto.
14973 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
14974 codepaths, we will move all the functionality into
14977 (FieldExpr.EmitAssign): Ditto.
14979 This fixes several hidden bugs that I uncovered while doing a code
14980 review of this today.
14982 * codegen.cs (EmitThis): reworked so the semantics are more clear
14983 and also support value types "this" instances.
14985 * iterators.cs: Changed so that for iterators in value types, we
14986 do not pass the value type as a parameter.
14988 Initialization of the enumerator helpers is now done in the caller
14989 instead of passing the parameters to the constructors and having
14990 the constructor set the fields.
14992 The fields have now `assembly' visibility instead of private.
14994 2004-04-11 Miguel de Icaza <miguel@ximian.com>
14996 * expression.cs (Argument.Resolve): Check if fields passed as ref
14997 or out are contained in a MarshalByRefObject.
14999 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
15000 another compiler type.
15002 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
15004 * class.cs (Indexer.Define): use the new name checking method.
15005 Also, return false on an error.
15006 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
15007 (is_identifier_[start/part]_character): make static.
15009 2004-04-10 Miguel de Icaza <miguel@ximian.com>
15011 * expression.cs (Binary.ResolveOperator): Do no append strings
15012 twice: since we can be invoked more than once (array evaluation)
15013 on the same concatenation, take care of this here. Based on a fix
15014 from Ben (bug #56454)
15016 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
15018 * codegen.cs: Fix another case where CS1548 must be reported (when
15019 delay-sign isn't specified and no private is available #56564). Fix
15020 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
15021 error when MCS is used on the MS runtime and we need to delay-sign
15022 (which seems unsupported by AssemblyBuilder - see #56621).
15024 2004-04-08 Marek Safar <marek.safar@seznam.cz>
15026 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
15027 (TypeManager.ComputeNamespaces): Faster implementation for
15030 * compiler.csproj: Updated AssemblyName to mcs.
15032 2004-04-07 Miguel de Icaza <miguel@ximian.com>
15034 * rootcontext.cs: Add new types to the boot resolution.
15036 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
15037 MulticastDelegate is not allowed.
15039 * typemanager.cs: Add new types to lookup: System.TypedReference
15042 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
15043 check for TypedReference or ArgIterator, they are not allowed.
15045 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
15046 makes us properly catch 1510 in some conditions (see bug 56016 for
15049 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
15051 * CryptoConvert.cs: update from corlib version
15054 2004-04-05 Miguel de Icaza <miguel@ximian.com>
15056 * class.cs (Indexer.Define): Check indexername declaration
15058 2004-04-05 Marek Safar <marek.safar@seznam.cz>
15060 * attribute.cs (IsClsCompliant): Fixed problem with handling
15061 all three states (compliant, not-compliant, undetected).
15063 2004-03-30 Marek Safar <marek.safar@seznam.cz>
15065 * attribute.cs (Attribute): Location is now public.
15066 (Resolve): Store resolved arguments (pos_values) in attribute class.
15067 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
15068 (GetClsCompliantAttributeValue): New method that gets
15069 CLSCompliantAttribute value.
15070 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
15071 if exists else null.
15072 (AttributeTester): New class for CLS-Compliant verification routines.
15074 * class.cs (Emit): Add CLS-Compliant verification.
15075 (Method.GetSignatureForError): Implemented.
15076 (Constructor.GetSignatureForError): Implemented
15077 (Constructor.HasCompliantArgs): Returns if constructor has
15078 CLS-Compliant arguments.
15079 (Constructor.Emit): Override.
15080 (Construcor.IsIdentifierClsCompliant): New method; For constructors
15081 is needed to test only parameters.
15082 (FieldBase.GetSignatureForError): Implemented.
15083 (TypeContainer): New member for storing base interfaces.
15084 (TypeContainer.FindMembers): Search in base interfaces too.
15086 * codegen.cs (GetClsComplianceAttribute): New method that gets
15087 assembly or module CLSCompliantAttribute value.
15088 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
15090 (ModuleClass.Emit): Add error 3012 test.
15092 * const.cs (Emit): Override and call base for CLS-Compliant tests.
15094 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
15095 state for all decl types.
15096 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
15097 if CLS-Compliant tests are required.
15098 (IsClsCompliaceRequired): New method. Analyze whether code
15099 must be CLS-Compliant.
15100 (IsExposedFromAssembly): New method. Returns true when MemberCore
15101 is exposed from assembly.
15102 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
15103 value or gets cached value.
15104 (HasClsCompliantAttribute): New method. Returns true if MemberCore
15105 is explicitly marked with CLSCompliantAttribute.
15106 (IsIdentifierClsCompliant): New abstract method. This method is
15107 used to testing error 3005.
15108 (IsIdentifierAndParamClsCompliant): New method. Common helper method
15109 for identifier and parameters CLS-Compliant testing.
15110 (VerifyClsCompliance): New method. The main virtual method for
15111 CLS-Compliant verifications.
15112 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
15113 null. I don't know why is null (too many public members !).
15114 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
15115 and get value of first CLSCompliantAttribute that found.
15117 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
15118 (VerifyClsCompliance): Override and add extra tests.
15120 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
15121 clscheck- disable CLS-Compliant verification event if assembly is has
15122 CLSCompliantAttribute(true).
15124 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
15125 ApllyAttribute is now called in emit section as in the other cases.
15126 Possible future Emit integration.
15127 (IsIdentifierClsCompliant): New override.
15128 (VerifyClsCompliance): New override.
15129 (GetEnumeratorName): Returns full enum name.
15131 * parameter.cs (GetSignatureForError): Implemented.
15133 * report.cs (WarningData): New struct for Warning message information.
15134 (LocationOfPreviousError): New method.
15135 (Warning): New method. Reports warning based on the warning table.
15136 (Error_T): New method. Reports error based on the error table.
15138 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
15139 verifications are done here.
15141 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
15143 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
15144 CLSCompliantAttribute.
15145 (all_imported_types): New member holds all imported types from other
15147 (LoadAllImportedTypes): New method fills static table with exported types
15148 from all referenced assemblies.
15149 (Modules): New property returns all assembly modules.
15151 2004-03-30 Miguel de Icaza <miguel@ximian.com>
15153 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
15154 throwing a parser error.
15156 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
15157 which removes the hardcoded get_/set_ prefixes for properties, as
15158 IL allows for the properties to be named something else.
15162 * expression.cs: Do not override operand before we know if it is
15163 non-null. Fix 56207
15165 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15167 * typemanager.cs: support for pinned variables.
15169 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15171 * decl.cs, typemanager.cs: Avoid using an arraylist
15172 as a buffer if there is only one result set.
15174 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
15176 * expression.cs: Make sure you cant call a static method
15177 with an instance expression, bug #56174.
15179 2004-03-29 Miguel de Icaza <miguel@ximian.com>
15181 * class.cs (IsDuplicateImplementation): Improve error reporting to
15182 flag 663 (method only differs in parameter modifier).
15184 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
15185 in preprocessor directives.
15187 * location.cs (LookupFile): Allow for the empty path.
15189 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
15190 better approach for some of that patch, but its failing with the
15191 CharSet enumeration. For now try/catch will do.
15193 * typemanager.cs: Do not crash if a struct does not have fields.
15196 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15198 * expression.cs: cs0213, cant fix a fixed expression.
15201 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15203 * cs-parser.jay: detect invalid embeded statements gracefully.
15206 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
15208 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
15211 the invocation type may not be a subclass of the tye of the item/
15212 The type of the item must be a subclass of the invocation item.
15217 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
15219 * attribute.cs: Added methods to get a string and a bool from an
15220 attribute. Required to information from AssemblyKeyFileAttribute,
15221 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
15222 * codegen.cs: Modified AssemblyName creation to include support for
15223 strongnames. Catch additional exceptions to report them as CS1548.
15224 * compiler.csproj: Updated include CryptoConvert.cs.
15225 * compiler.csproj.user: Removed file - user specific configuration.
15226 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
15227 Mono.Security assembly. The original class is maintained and tested in
15228 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
15229 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
15230 like CSC 8.0 (C# v2) supports.
15231 * Makefile: Added CryptoConvert.cs to mcs sources.
15232 * rootcontext.cs: Added new options for strongnames.
15234 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
15236 * driver.cs: For --expect-error, report error code `2'
15237 if the program compiled with no errors, error code `1' if
15238 it compiled with an error other than the one expected.
15240 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
15242 * compiler.csproj: Updated for Visual Studio .NET 2003.
15243 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
15244 * compiler.sln: Updated for Visual Studio .NET 2003.
15246 2004-03-24 Ravi Pratap M <ravi@ximian.com>
15248 * expression.cs: Fix bug #47234. We basically need to apply the
15249 rule that we prefer the conversion of null to a reference type
15250 when faced with a conversion to 'object' (csc behaviour).
15252 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15254 * statement.cs: Shorter form for foreach, eliminates
15255 a local variable. r=Martin.
15257 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15259 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
15260 checks if we can use brtrue/brfalse to test for 0.
15261 * expression.cs: use the above in the test for using brtrue/brfalse.
15262 cleanup code a bit.
15264 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15266 * expression.cs: Rewrite string concat stuff. Benefits:
15268 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
15269 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
15270 rather than a concat chain.
15272 * typemanager.cs: Add lookups for more concat overloads.
15274 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
15276 * expression.cs: Emit shorter il code for array init.
15293 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
15295 * statement.cs: Before, two switch blocks would be merged if the
15296 total size of the blocks (end_item - begin_item + 1) was less than
15297 two times the combined sizes of the blocks.
15299 Now, it will only merge if after the merge at least half of the
15304 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
15306 * class.cs : csc build fix for GetMethods(). See bug #52503.
15308 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
15310 * expression.cs: Make sure fp comparisons work with NaN.
15311 This fixes bug #54303. Mig approved this patch a long
15312 time ago, but we were not able to test b/c the runtime
15315 2004-03-19 Miguel de Icaza <miguel@ximian.com>
15317 * ecore.cs (TypExpr.GetHashCode): implement this overload.
15319 2004-03-19 Martin Baulig <martin@ximian.com>
15321 * class.cs (MemberCore.IsDuplicateImplementation): Report the
15322 error here and not in our caller.
15324 2004-03-19 Martin Baulig <martin@ximian.com>
15326 * interface.cs: Completely killed this file.
15327 (Interface): We're now a TypeContainer and live in class.cs.
15329 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
15330 argument; we're now also called for interfaces.
15331 (TypeContainer.DefineMembers): Allow this method being called
15333 (TypeContainer.GetMethods): New public method; formerly known as
15334 Interface.GetMethod(). This is used by PendingImplementation.
15335 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
15336 it's now private and non-static.
15337 (Interface): Moved this here; it's now implemented similar to
15339 (Method, Property, Event, Indexer): Added `bool is_interface'
15340 argument to their .ctor's.
15341 (MemberBase.IsInterface): New public field.
15343 * cs-parser.jay: Create normal Method, Property, Event, Indexer
15344 instances instead of InterfaceMethod, InterfaceProperty, etc.
15345 (opt_interface_base): Removed; we now use `opt_class_base' instead.
15346 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
15348 2004-03-19 Martin Baulig <martin@ximian.com>
15350 * class.cs (MethodCore.IsDuplicateImplementation): New private
15351 method which does the CS0111 checking.
15352 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
15353 Use IsDuplicateImplementation().
15355 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
15357 * decl.cs (FindMemberToOverride): New method to find the correct
15358 method or property to override in the base class.
15360 - Make Method/Property use the above method to find the
15361 version in the base class.
15362 - Remove the InheritableMemberSignatureCompare as it is now
15365 This patch makes large code bases much faster to compile, as it is
15366 O(n) rather than O(n^2) to do this validation.
15368 Also, it fixes bug 52458 which is that nested classes are not
15369 taken into account when finding the base class member.
15371 Reviewed/Approved by Martin.
15373 2004-03-17 Marek Safar <marek.safar@seznam.cz>
15375 * interface.cs: In all interface classes removed redundant
15376 member initialization.
15378 2004-03-16 Martin Baulig <martin@ximian.com>
15380 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
15382 2004-03-15 Miguel de Icaza <miguel@ximian.com>
15384 * decl.cs (DefineTypeAndParents): New helper method to define a
15385 type's containers before the type itself is defined; This is a
15386 bug exposed by the recent changes to Windows.Forms when an
15387 implemented interface was defined inside a class that had not been
15390 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
15392 (Check): Loop correctly to report errors modifiers
15393 (UNSAFE was not in the loop, since it was the same as TOP).
15395 * interface.cs: Every interface member now takes a ModFlags,
15396 instead of a "is_new" bool, which we set on the base MemberCore.
15398 Every place where we called "UnsafeOk" in the interface, now we
15399 call the proper member (InterfaceMethod.UnsafeOK) instead to get
15400 the unsafe settings from the member declaration instead of the
15401 container interface.
15403 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
15405 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
15406 `set_indexer_name' to the pending bits (one per type).
15408 We fixed a bug today that was picking the wrong method to
15409 override, since for properties the existing InterfaceMethod code
15410 basically ignored the method name. Now we make sure that the
15411 method name is one of the valid indexer names.
15413 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
15415 * support.cs (SeekableStreamReader): Keep track of stream byte
15416 positions and don't mix them with character offsets to the buffer.
15418 Patch from Gustavo Giráldez
15420 2004-03-15 Marek Safar <marek.safar@seznam.cz>
15422 * interface.cs (InterfaceSetGetBase): Removed double member
15423 initialization, base class does it as well.
15425 2004-03-13 Martin Baulig <martin@ximian.com>
15427 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
15428 when compiling corlib.
15430 2004-03-13 Miguel de Icaza <miguel@ximian.com>
15432 * convert.cs (ExplicitConversion): We were reporting an error on
15433 certain conversions (object_type source to a value type, when the
15434 expression was `null') before we had a chance to pass it through
15435 the user defined conversions.
15437 * driver.cs: Replace / and \ in resource specifications to dots.
15440 * class.cs: Add check for duplicate operators. Fixes 52477
15442 2004-03-11 Miguel de Icaza <miguel@ximian.com>
15444 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
15445 that are in the middle of the statements, not only at the end.
15448 * class.cs (TypeContainer.AddField): No longer set the
15449 `HaveStaticConstructor' flag, now we call it
15450 `UserDefineStaticConstructor' to diferentiate the slightly
15451 semantic difference.
15453 The situation is that we were not adding BeforeFieldInit (from
15454 Modifiers.TypeAttr) to classes that could have it.
15455 BeforeFieldInit should be set to classes that have no static
15460 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
15462 And most importantly Zoltan's comment:
15464 http://bugzilla.ximian.com/show_bug.cgi?id=44229
15466 "I think beforefieldinit means 'it's ok to initialize the type sometime
15467 before its static fields are used', i.e. initialization does not need
15468 to be triggered by the first access to the type. Setting this flag
15469 helps the JIT to compile better code, since it can run the static
15470 constructor at JIT time, and does not need to generate code to call it
15471 (possibly lots of times) at runtime. Unfortunately, mcs does not set
15472 this flag for lots of classes like String.
15474 csc sets this flag if the type does not have an explicit static
15475 constructor. The reasoning seems to be that if there are only static
15476 initalizers for a type, and no static constructor, then the programmer
15477 does not care when this initialization happens, so beforefieldinit
15480 This bug prevents the AOT compiler from being usable, since it
15481 generates so many calls to mono_runtime_class_init that the AOT code
15482 is much slower than the JITted code. The JITted code is faster,
15483 because it does not generate these calls if the vtable is type is
15484 already initialized, which is true in the majority of cases. But the
15485 AOT compiler can't do this."
15487 2004-03-10 Miguel de Icaza <miguel@ximian.com>
15489 * class.cs (MethodData.Emit): Refactor the code so symbolic
15490 information is generated for destructors; For some reasons we
15491 were taking a code path that did not generate symbolic information
15494 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
15496 * class.cs: Create a Constructor.CheckBase method that
15497 takes care of all validation type code. The method
15498 contains some code that was moved from Define.
15500 It also includes new code that checks for duplicate ctors.
15501 This fixes bug #55148.
15503 2004-03-09 Joshua Tauberer <tauberer@for.net>
15505 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
15506 a { ... }-style array creation invokes EmitStaticInitializers
15507 which is not good for reference-type arrays. String, decimal
15508 and now null constants (NullCast) are not counted toward
15509 static initializers.
15511 2004-03-05 Martin Baulig <martin@ximian.com>
15513 * location.cs (SourceFile.HasLineDirective): New public field;
15514 specifies whether the file contains or is referenced by a "#line"
15516 (Location.DefineSymbolDocuments): Ignore source files which
15517 either contain or are referenced by a "#line" directive.
15519 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
15521 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
15522 direct access to our parent, so check the method inline there.
15524 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
15526 * expression.cs (Invocation.EmitCall): Miguel's last commit
15527 caused a regression. If you had:
15532 In Foo the implict this would be null.
15534 2004-02-27 Miguel de Icaza <miguel@ximian.com>
15536 * expression.cs (Invocation.EmitCall): If the method is not
15537 virtual, do not emit a CallVirt to it, use Call.
15539 * typemanager.cs (GetFullNameSignature): Improve the method to
15540 cope with ".ctor" and replace it with the type name.
15542 * class.cs (ConstructorInitializer.Resolve): Now the method takes
15543 as an argument the ConstructorBuilder where it is being defined,
15544 to catch the recursive constructor invocations.
15546 2004-02-26 Miguel de Icaza <miguel@ximian.com>
15548 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
15549 routines to check if a type is an enumerable/enumerator allow
15550 classes that implement the IEnumerable or IEnumerator interfaces.
15552 * class.cs (Property, Operator): Implement IIteratorContainer, and
15553 implement SetYields.
15555 (Property.Define): Do the block swapping for get_methods in the
15556 context of iterators. We need to check if Properties also
15557 include indexers or not.
15559 (Operator): Assign the Block before invoking the
15560 OperatorMethod.Define, so we can trigger the Iterator code
15563 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
15564 Property and Operator classes are not created when we parse the
15565 declarator but until we have the block completed, so we use a
15566 singleton SimpleIteratorContainer.Simple to flag whether the
15567 SetYields has been invoked.
15569 We propagate this setting then to the Property or the Operator to
15570 allow the `yield' to function.
15572 2004-02-25 Marek Safar <marek.safar@seznam.cz>
15574 * codegen.cs: Implemented attribute support for modules.
15575 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
15576 Assembly/Module functionality.
15578 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
15579 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
15580 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
15582 2004-02-16 Marek Safar <marek.safar@seznam.cz>
15584 * interface.cs (FindMembers): The operation is performed on all base
15585 interfaces and not only on the first. It is required for future CLS Compliance patch.
15587 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
15589 * statement.cs, codegen.cs:
15590 This patch deals with patterns such as:
15592 public class List : IEnumerable {
15594 public MyEnumerator GetEnumerator () {
15595 return new MyEnumerator(this);
15598 IEnumerator IEnumerable.GetEnumerator () {
15602 public struct MyEnumerator : IEnumerator {
15607 Before, there were a few things we did wrong:
15608 1) we would emit callvirt on a struct, which is illegal
15609 2) we emited ldarg when we needed to emit ldarga
15610 3) we would mistakenly call the interface methods on an enumerator
15611 type that derived from IEnumerator and was in another assembly. For example:
15613 public class MyEnumerator : IEnumerator
15615 Would have the interface methods called, even if there were public impls of the
15616 method. In a struct, this lead to invalid IL code.
15618 2004-02-11 Marek Safar <marek.safar@seznam.cz>
15620 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
15623 * delegate.cs (Define): Fixed crash when delegate type is undefined.
15625 2004-02-11 Miguel de Icaza <miguel@ximian.com>
15627 * cs-parser.jay: Fix small regression: we were not testing V2
15628 compiler features correctly.
15630 * interface.cs: If the emit context is null, then create one
15632 2004-02-09 Marek Safar <marek.safar@seznam.cz>
15634 * decl.cs (GetSignatureForError): New virtual method to get full name
15635 for error messages.
15637 * attribute.cs (IAttributeSupport): New interface for attribute setting.
15638 Now it is possible to rewrite ApplyAttributes method to be less if/else.
15640 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
15641 Duplicated members and code in these classes has been removed.
15642 Better encapsulation in these classes.
15644 2004-02-07 Miguel de Icaza <miguel@ximian.com>
15646 * assign.cs (Assign.DoResolve): When dealing with compound
15647 assignments, there is a new rule in ECMA C# 2.4 (might have been
15648 there before, but it is documented here) that states that in:
15652 If b is of type int, and the `op' is a shift-operator, then the
15653 above is evaluated as:
15657 * expression.cs (Binary.ResolveOperator): Instead of testing for
15658 int/uint/long/ulong, try to implicitly convert to any of those
15659 types and use that in pointer arithmetic.
15661 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
15662 method to print information for from the type, not from the
15663 null-method we were given.
15665 2004-02-01 Duncan Mak <duncan@ximian.com>
15667 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
15668 parsing for cmd, fixes bug #53694.
15670 2004-02-04 Marek Safar <marek.safar@seznam.cz>
15672 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
15673 in the member name duplication tests. Property and operator name duplication
15674 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
15676 2004-02-03 Marek Safar <marek.safar@seznam.cz>
15678 * interface.cs (PopulateMethod): Fixed crash when interface method
15679 returns not existing type (error test cs0246-3.cs).
15681 2004-02-02 Ravi Pratap M <ravi@ximian.com>
15683 * cs-parser.jay (interface_accessors): Re-write actions to also
15684 store attributes attached to get and set methods. Fix spelling
15687 (inteface_property_declaration): Modify accordingly.
15689 (InterfaceAccessorInfo): New helper class to store information to pass
15690 around between rules that use interface_accessors.
15692 * interface.cs (Emit): Apply attributes on the get and set
15693 accessors of properties and indexers too.
15695 * attribute.cs (ApplyAttributes): Modify accordingly to use the
15696 right MethodBuilder when applying attributes to the get and set accessors.
15698 2004-01-31 Miguel de Icaza <miguel@ximian.com>
15700 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
15702 2004-01-26 Miguel de Icaza <miguel@ximian.com>
15704 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
15706 2004-01-25 Miguel de Icaza <miguel@ximian.com>
15708 * cs-parser.jay: Remove YIELD token, instead use the new grammar
15709 changes that treat `yield' specially when present before `break'
15710 or `return' tokens.
15712 * cs-tokenizer.cs: yield is no longer a keyword.
15714 2004-01-23 Marek Safar <marek.safar@seznam.cz>
15716 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
15717 setting for default constructors.
15718 For default constructors are almost every time set wrong Modifier. The
15719 generated IL code has been alright. But inside mcs this values was
15720 wrong and this was reason why several of my CLS Compliance tests
15723 2004-01-22 Martin Baulig <martin@ximian.com>
15725 * cs-parser.jay (namespace_or_type_name): Return an Expression,
15726 not a QualifiedIdentifier. This is what `type_name_expression'
15727 was previously doing.
15728 (type_name_expression): Removed; the code is now in
15729 `namespace_or_type_name'.
15730 (qualified_identifier): Removed, use `namespace_or_type_name'
15732 (QualifiedIdentifier): Removed this class.
15734 2004-01-22 Martin Baulig <martin@ximian.com>
15736 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
15737 not a string as alias name.
15739 2004-01-21 Miguel de Icaza <miguel@ximian.com>
15741 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
15742 #52730 bug, and instead compute correctly the need to use a
15743 temporary variable when requesting an address based on the
15744 static/instace modified of the field and the constructor.
15746 2004-01-21 Martin Baulig <martin@ximian.com>
15748 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
15749 class and namespace before looking up aliases. Fixes #52517.
15751 2004-01-21 Martin Baulig <martin@ximian.com>
15753 * flowanalysis.cs (UsageVector.Merge): Allow variables being
15754 assinged in a 'try'; fixes exception4.cs.
15756 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15757 * class.cs : Implemented parameter-less constructor for TypeContainer
15759 * decl.cs: Attributes are now stored here. New property OptAttributes
15761 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
15763 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
15765 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15767 * typemanager.cs (CSharpSignature): Now reports also inner class name.
15768 (CSharpSignature): New method for indexer and property signature.
15770 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15772 * pending.cs (IsVirtualFilter): Faster implementation.
15774 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15776 * typemanager.cs: Avoid inclusion of same assembly more than once.
15778 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15780 * cs-parser.jay: Fixed problem where the last assembly attribute
15781 has been applied also to following declaration (class, struct, etc.)
15783 2004-01-21 Marek Safar <marek.safar@seznam.cz>
15785 * class.cs: Added error CS0538, CS0539 reporting.
15786 Fixed crash on Microsoft runtime when field type is void.
15788 * cs-parser.jay: Added error CS0537 reporting.
15790 * pending.cs: Added error CS0535 reporting.
15791 Improved error report for errors CS0536, CS0534.
15793 2004-01-20 Miguel de Icaza <miguel@ximian.com>
15795 Merge a few bits from the Anonymous Method MCS tree.
15797 * statement.cs (ToplevelBlock): New class for toplevel methods,
15798 will hold anonymous methods, lifted variables.
15800 * cs-parser.jay: Create toplevel blocks for delegates and for
15801 regular blocks of code.
15803 2004-01-20 Martin Baulig <martin@ximian.com>
15805 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
15806 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
15807 and `NeedExplicitReturn'; added `IsLastStatement'.
15808 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
15809 have a `ReturnLabel' or we're not unreachable.
15811 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
15812 child's reachability; don't just override ours with it. Fixes
15813 #58058 (lluis's example).
15814 (FlowBranching): Added public InTryOrCatch(), InCatch(),
15815 InFinally(), InLoop(), InSwitch() and
15816 BreakCrossesTryCatchBoundary() methods.
15818 * statement.cs (Return): Do all error checking in Resolve().
15819 Unless we are the last statement in a top-level block, always
15820 create a return label and jump to it.
15821 (Break, Continue): Do all error checking in Resolve(); also make
15822 sure we aren't leaving a `finally'.
15823 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
15824 statement in a top-level block.
15825 (Block.Flags): Added `IsDestructor'.
15826 (Block.IsDestructor): New public property.
15828 2004-01-20 Martin Baulig <martin@ximian.com>
15830 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
15832 2004-01-20 Martin Baulig <martin@ximian.com>
15834 * statement.cs (Statement.ResolveUnreachable): New public method.
15835 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
15836 (Block.Resolve): Resolve unreachable statements.
15838 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15840 * expression.cs: We need to fix the case where we do
15841 not have a temp variable here.
15843 * assign.cs: Only expression compound assignments need
15844 temporary variables.
15846 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
15848 * flowanalysis.cs: Reduce memory allocation in a few ways:
15849 - A block with no variables should not allocate a bit
15851 - A method with no out parameters does not need any tracking
15852 for assignment of the parameters, so we need not allocate
15855 public readonly Type[] VariableTypes;
15856 public readonly string[] VariableNames;
15857 Are redundant. The data is already stored in the variable
15858 map, so we need not allocate another array for it.
15859 - We need to add alot of checks for if (params | locals) == null
15860 due to the first two changes.
15862 2004-01-18 Miguel de Icaza <miguel@ximian.com>
15864 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
15865 implement IMemoryLocation, we store a copy on a local variable and
15866 take the address of it. Patch from Benjamin Jemlich
15868 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
15869 to use a special "type_name_expression" rule which reduces the
15870 number of "QualifiedIdentifier" classes created, and instead
15871 directly creates MemberAccess expressions.
15873 2004-01-17 Miguel de Icaza <miguel@ximian.com>
15875 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
15876 that fixes #52853. Null literal assignment to ValueType
15878 * class.cs (MethodData.Emit): Instead of checking the name of the
15879 method to determine if its a destructor, create a new derived
15880 class from Method called Destructor, and test for that.
15882 * cs-parser.jay: Create a Destructor object instead of a Method.
15884 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
15888 2004-01-16 Miguel de Icaza <miguel@ximian.com>
15890 * expression.cs (Binary.ResolveOperator): Perform an implicit
15891 conversion from MethodGroups to their delegate types on the
15892 Addition operation.
15894 * delegate.cs: Introduce a new class DelegateCreation that is the
15895 base class for `NewDelegate' and `ImplicitDelegateCreation',
15896 factor some code in here.
15898 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
15899 conversion from MethodGroups to compatible delegate types.
15901 * ecore.cs (Expression.Resolve): Do not flag error 654
15902 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
15903 we allow conversions from MethodGroups to delegate types now.
15905 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
15906 assignments in v2 either.
15908 2004-01-10 Miguel de Icaza <miguel@ximian.com>
15910 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
15911 static read-only fields in ctors.
15913 Applied patch from Benjamin Jemlich
15915 * expression.cs (UnaryMutator): Avoid leaking local variables.
15917 2004-01-09 Miguel de Icaza <miguel@ximian.com>
15919 * cs-tokenizer.cs (IsCastToken): Allow the various native types
15920 here to return true, as they can be used like this:
15922 (XXX) int.MEMBER ()
15924 Fixed 49836 and all the other dups
15926 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
15928 * driver.cs: Implement /win32res and /win32icon.
15930 2004-01-08 Miguel de Icaza <miguel@ximian.com>
15932 * cs-parser.jay: Add a rule to improve error handling for the
15933 common mistake of placing modifiers after the type.
15935 2004-01-07 Miguel de Icaza <miguel@ximian.com>
15937 * cs-parser.jay (interface_event_declaration): Catch
15938 initialization of events on interfaces, and report cs0068
15940 * cs-parser.jay (interface_event_declaration): Catch
15941 initialization of events.
15943 * ecore.cs: Better report missing constructors.
15945 * expression.cs (Binary.ResolveOperator): My previous bug fix had
15946 the error reporting done in the wrong place. Fix.
15948 * expression.cs (Binary.ResolveOperator): Catch the
15949 operator + (E x, E y) error earlier, and later allow for implicit
15950 conversions in operator +/- (E e, U x) from U to the underlying
15953 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
15954 52596, if the container class is abstract, the default constructor
15955 is protected otherwise its public (before, we were always public).
15957 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
15960 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
15961 Jemlich that fixes bug #52597, MCS was generating invalid code for
15962 idisposable structs. Thanks to Ben for following up with this
15965 2004-01-06 Miguel de Icaza <miguel@ximian.com>
15967 * driver.cs: Allow assemblies without code to be generated, fixes
15970 2004-01-07 Nick Drochak <ndrochak@gol.com>
15972 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
15974 2004-01-05 Miguel de Icaza <miguel@ximian.com>
15976 * cs-parser.jay: Add rules to improve error reporting if fields or
15977 methods are declared at the namespace level (error 116)
15979 * Add rules to catch event add/remove
15981 2004-01-04 David Sheldon <dave-mono@earth.li>
15983 * expression.cs: Added matching ")" to error message for
15986 2004-01-03 Todd Berman <tberman@gentoo.org>
15988 * ecore.cs, attribute.cs:
15989 Applying fix from #52429.
15991 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
15993 * ecore.cs, expression.cs, statement.cs:
15994 Total rewrite of how we handle branching. We
15995 now handle complex boolean expressions with fewer
15996 jumps. As well if (x == 0) no longer emits a ceq.
15998 if (x is Foo) is much faster now, because we generate
16001 Overall, we get a pretty big improvement on our benchmark
16002 tests. The code we generate is smaller and more readable.
16004 I did a full two-stage bootstrap. The patch was reviewed
16005 by Martin and Miguel.
16007 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
16009 * cs-parser.jay: Make primary_expression not take a QI.
16010 we dont need this because the member_access rule covers
16011 us here. So we replace the rule with just IDENTIFIER.
16013 This has two good effects. First, we remove a s/r conflict.
16014 Second, we allocate many fewer QualifiedIdentifier objects.
16016 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
16018 * attribute.cs: Handle MarshalAs attributes as pseudo, and
16019 set the correct information via SRE. This prevents
16020 hanging on the MS runtime. Fixes #29374.
16022 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
16024 * convert.cs: correctly handle conversions to value types
16025 from Enum and ValueType as unboxing conversions.
16027 Fixes bug #52569. Patch by Benjamin Jemlich.
16029 2004-01-02 Ravi Pratap <ravi@ximian.com>
16031 * expression.cs (BetterConversion): Prefer int -> uint
16032 over int -> ulong (csc's behaviour). This fixed bug #52046.
16034 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
16036 * decl.cs (MemberCache.FindMembers): now returns a
16039 * typemanager.cs: In general, go with with ^^.
16040 (CopyNewMethods): take an IList.
16041 (RealMemberLookup): Only allocate an arraylist
16042 if we copy from two sets of methods.
16044 This change basically does two things:
16045 1) Fewer array lists allocated due to CopyNewMethods.
16046 2) the explicit cast in MemberList costed ALOT.
16048 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
16050 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
16051 a hashtable to avoid needless string allocations when an identifier is
16052 used more than once (the common case).
16054 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
16056 * pending.cs: MS's TypeBuilder.GetInterfaces ()
16057 is broken, it will not return anything. So, we
16058 have to use the information we have in mcs to
16061 * typemanager.cs: Add a cache for GetInterfaces,
16062 since this will now be used more often (due to ^^)
16064 (GetExplicitInterfaces) New method that gets the
16065 declared, not effective, interfaces on a type
16066 builder (eg, if you have interface IFoo, interface
16067 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
16070 This patch makes MCS able to bootstrap itself on
16073 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
16075 * expression.cs: Remove the Nop's that Miguel put
16078 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16080 * report.cs, codegen.cs: Give the real stack trace to
16081 the error when an exception is thrown.
16083 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16085 * decl.cs: only allocate hashtables for ifaces if
16088 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
16090 * expression.cs: fix the error from cs0121-2.cs
16091 (a parent interface has two child interfaces that
16092 have a function with the same name and 0 params
16093 and the function is called through the parent).
16095 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
16097 * class.cs, rootcontext.cs, typmanager.cs: do not
16100 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
16102 * codegen.cs: remove stack for the ec flow branching.
16103 It is already a linked list, so no need.
16105 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
16107 * Makefile: Allow custom profiler here.
16109 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
16111 * typemanager.cs (LookupType):
16112 - Use a static char [], because split takes
16113 a param array for args, so it was allocating
16115 - Do not store true in a hashtable, it boxes.
16117 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
16119 * flowanalysis.cs: bytify common enums.
16121 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16123 * modifiers.cs: Add a new set of flags for the
16124 flags allowed on explicit interface impls.
16125 * cs-parser.jay: catch the use of modifiers in
16126 interfaces correctly.
16127 * class.cs: catch private void IFoo.Blah ().
16129 All related to bug #50572.
16131 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16133 * decl.cs: Rewrite the consistant accessability checking.
16134 Accessability is not linear, it must be implemented in
16135 a tableish way. Fixes #49704.
16137 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
16139 * expression.cs: Handle negation in a checked context.
16140 We must use subtraction from zero. Fixes #38674.
16142 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
16144 * class.cs: Ignore static void main in DLLs.
16145 * rootcontext.cs: Handle the target type here,
16146 since we are have to access it from class.cs
16147 * driver.cs: account for the above.
16149 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
16151 * report.cs: Give line numbers and files if available.
16153 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
16155 * driver.cs: Implement /addmodule.
16157 * typemanager.cs: Change 'modules' field so it now contains Modules not
16160 2003-12-20 Martin Baulig <martin@ximian.com>
16162 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
16163 (FieldBase.IsAssigned): Removed this field.
16164 (FieldBase.SetAssigned): New public method.
16165 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
16167 2003-12-20 Martin Baulig <martin@ximian.com>
16169 * expression.cs (LocalVariableReference.DoResolve): Don't set
16170 `vi.Used' if we're called from DoResolveLValue().
16172 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
16173 returns the usage vector it just merged into the current one -
16174 pass this one to UsageWarning().
16175 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
16176 of the `EmitContext', don't call this recursively on our children.
16178 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
16180 * driver.cs: Implement /target:module.
16182 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
16184 * support.cs (CharArrayHashtable): New helper class.
16186 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
16187 char arrays, not strings, so we can avoid creating a string in
16188 consume_identifier if the identifier is a keyword.
16190 2003-12-16 Martin Baulig <martin@ximian.com>
16192 * statement.cs (LocalInfo.Assigned): Removed this property.
16193 (LocalInfo.Flags): Removed `Assigned'.
16194 (LocalInfo.IsAssigned): New public method; takes the EmitContext
16195 and uses flow analysis.
16196 (Block.UsageWarning): Made this method private.
16197 (Block.Resolve): Call UsageWarning() if appropriate.
16199 * expression.cs (LocalVariableReference.DoResolve): Always set
16200 LocalInfo.Used here.
16202 2003-12-13 Martin Baulig <martin@ximian.com>
16204 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
16205 any value here; we're now using flow analysis to figure out
16206 whether a statement/block returns a value.
16208 2003-12-13 Martin Baulig <martin@ximian.com>
16210 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
16212 (FlowBranching.MergeFinally): Don't call
16213 `branching.CheckOutParameters()' here, this is called in
16215 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
16216 when adding the `finally' vector.
16218 2003-12-13 Martin Baulig <martin@ximian.com>
16221 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
16222 actually work and also fix #48962.
16224 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
16226 * decl.cs: Do not check System.Object for nested types,
16227 since we know it does not have any. Big bang for buck:
16230 Run 1: 8.35 seconds
16231 Run 2: 8.32 seconds
16232 corlib: 17.99 seconds
16234 Run 1: 8.17 seconds
16235 Run 2: 8.17 seconds
16236 corlib: 17.39 seconds
16238 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
16240 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
16241 time we are returning 0 members, so we save alot here.
16243 2003-12-11 Martin Baulig <martin@ximian.com>
16245 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
16246 `MergeChild()', also just take the `FlowBranching' as argument;
16247 call Merge() on it and return the result.
16248 (FlowBranching.Merge): We don't need to do anything if we just
16251 2003-12-11 Martin Baulig <martin@ximian.com>
16253 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
16254 them in an `ArrayList' to reduce memory usage. Thanks to Ben
16255 Maurer for this idea.
16257 2003-12-11 Martin Baulig <martin@ximian.com>
16259 * flowanalysis.cs (MergeResult): This class is now gone; we now
16260 use the `UsageVector' for this. The reason for this is that if a
16261 branching just has one sibling, we don't need to "merge" them at
16262 all - that's the next step to do.
16263 (FlowBranching.Merge): We now return a `UsageVector' instead of a
16266 2003-12-11 Martin Baulig <martin@ximian.com>
16268 Reworked flow analyis and made it more precise and bug-free. The
16269 most important change is that we're now using a special `Reachability'
16270 class instead of having "magic" meanings of `FlowReturns'. I'll
16271 do some more cleanups and optimizations and also add some more
16272 documentation this week.
16274 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
16275 largely reworked this class.
16276 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
16277 the new `Reachability' class instead of having "magic" values here.
16278 (FlowBranching): We're now using an instance of `Reachability'
16279 instead of having separate `Returns', `Breaks' etc. fields.
16281 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
16282 based on flow analysis; ignore the return value of block.Emit ().
16284 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
16286 * driver.cs typemanager.cs: Find the mono extensions to corlib even
16287 if they are private.
16289 2003-12-09 Martin Baulig <martin@ximian.com>
16291 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
16292 call them directly on the UsageVector.
16294 2003-12-09 Martin Baulig <martin@ximian.com>
16296 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
16297 Changed return type from `FlowReturns' to `Reachability'.
16299 2003-12-09 Martin Baulig <martin@ximian.com>
16301 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
16302 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
16303 `Reachable' fields with a single `Reachability' one.
16305 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16307 * class.cs (FindMembers): Remove foreach's.
16312 Run 1: 8.74 seconds
16313 Run 2: 8.71 seconds
16316 Run 1: 8.64 seconds
16317 Run 2: 8.58 seconds
16320 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16325 This patch does a few things:
16326 1. EmptyStatement is now a singleton, so it is never reallocated.
16327 2. All blah is EmptyStatement constructs have been changed to
16328 blah == EmptyStatement.Value, which is much faster and valid
16329 now that EmptyStatement is a singleton.
16330 3. When resolving a block, rather than allocating a new array for
16331 the non-empty statements, empty statements are replaced with
16332 EmptyStatement.Value
16333 4. Some recursive functions have been made non-recursive.
16334 Mainly the performance impact is from (3), however (1) and (2) are needed for
16335 this to work. (4) does not make a big difference in normal situations, however
16336 it makes the profile look saner.
16341 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16342 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
16343 Total memory allocated: 56397 KB
16346 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
16347 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
16348 Total memory allocated: 55666 KB
16350 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16352 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
16353 than the hashtable in a hashtable version
16355 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
16356 we always end up concating a string. This results in a huge perf
16357 loss, because many strings have to be tracked by the GC. In this
16358 patch, we first use a hashtable that works with two keys, so that
16359 the strings do not need to be concat'ed.
16363 Run 1: 8.74 seconds
16364 Run 2: 8.71 seconds
16367 Run 1: 8.65 seconds
16368 Run 2: 8.56 seconds
16370 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
16372 * Makefile: Add a new target `do-time' that does a quick and simple
16373 profile, leaving easy to parse output.
16375 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
16377 * codegen.cs (Init): Create the dynamic assembly with
16378 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
16380 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
16382 * support.cs: Make the PtrHashtable use only one
16383 instance of its comparer.
16385 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
16387 * typemanager.cs: Fix lookup of GetNamespaces.
16389 2003-11-29 Miguel de Icaza <miguel@ximian.com>
16391 * expression.cs: Removed redundant line.
16393 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
16394 ArrayLists, use for loops with bounds.
16396 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
16399 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
16400 arraylists, use for loop with bounds.
16402 The above three changes give us a 0.071 second performance
16403 improvement out of 3.294 seconds down to 3.223. On my machine
16404 the above changes reduced the memory usage by 1,387 KB during
16405 compiler bootstrap.
16407 * cs-parser.jay (QualifiedIdentifier): New class used to represent
16408 QualifiedIdentifiers. Before we created a new string through
16409 concatenation, and mostly later on, the result would be
16410 manipulated by DecomposeQI through string manipulation.
16412 This reduced the compiler memory usage for bootstrapping from
16413 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
16414 compile times in 0.05 seconds.
16416 2003-11-28 Dick Porter <dick@ximian.com>
16418 * support.cs: Do string compares with the Invariant culture.
16426 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
16427 the comparison is done with the Invariant culture.
16429 2003-11-27 Miguel de Icaza <miguel@ximian.com>
16431 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
16432 GetEnumerator method.
16434 (ProbeCollectionType): Iterate starting at the most specific type
16435 upwards looking for a GetEnumerator
16437 * expression.cs: Shift count can be up to 31 for int/uint and 63
16440 2003-11-26 Miguel de Icaza <miguel@ximian.com>
16442 * statement.cs (Block.LookupLabel): Also look for the label on the
16443 children blocks. Use a hash table to keep track of visited
16446 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
16447 we actually did transform the other operand, otherwise fall back
16448 to the common codepath that casts to long.
16450 * cs-tokenizer.cs: Use the same code pattern as the int case.
16451 Maybe I should do the parsing myself, and avoid depending on the
16452 Parse routines to get this done.
16454 2003-11-25 Miguel de Icaza <miguel@ximian.com>
16456 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16457 which fixes bug 51347. This time test it.
16459 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
16460 attributes for example can not tell the difference between these.
16461 The difference was only a syntax feature of the language.
16463 * attribute.cs: Apply attributes to delegates.
16465 * delegate.cs: Call the apply attributes method.
16467 2003-11-24 Miguel de Icaza <miguel@ximian.com>
16469 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
16470 comparing 0 vs Byte.MinValue, not the value
16472 (ImplicitConversionRequired): When reporting a conversion error,
16473 use error 31 to print out the constant error instead of the
16476 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
16477 which fixes bug 51347.
16479 2003-11-22 Miguel de Icaza <miguel@ximian.com>
16481 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
16482 which fixes the -warnaserror command line option.
16484 2003-11-21 Miguel de Icaza <miguel@ximian.com>
16486 * cfold.cs (DoNumericPromotions): During constant folding of
16487 additions on UIntConstant, special case intconstants with
16488 IntConstants like we do on the expression binary operator.
16490 2003-11-12 Miguel de Icaza <miguel@ximian.com>
16492 * convert.cs (ImplicitReferenceConversion): We were missing a case
16493 (System.Enum are not value types or class types, so we need to
16494 classify them separatedly).
16496 * driver.cs: We do not support error 2007.
16498 2003-11-12 Jackson Harper <jackson@ximian.com>
16500 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
16501 system directory. Also use the full file name so users can
16502 libraries names mscorlib-o-tron.dll in a non system dir.
16504 2003-11-10 Martin Baulig <martin@ximian.com>
16506 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
16507 (TypeManager.InitCoreTypes): Initialize them here, but instead of
16508 calling `ResolveType()' on them, directly assign their `Type'.
16510 2003-11-08 Martin Baulig <martin@ximian.com>
16512 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
16513 return value and the `out parent' parameter.
16514 (TypeContainer.DefineType): Moved the CS0644 check into
16515 GetClassBases(). Don't pass the interface types to the
16516 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
16517 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
16519 * ecore.cs (TypeExpr.IsAttribute): New property.
16520 (TypeExpr.GetInterfaces): New method.
16522 * interface.cs (Interface.GetInterfaceTypeByName): Return a
16523 TypeExpr instead of a Type.
16524 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
16525 (Interface.DefineType): Don't pass the interface types to the
16526 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
16527 them later and then call `TypeBulider.AddInterfaceImplementation()'.
16529 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
16530 instead of a `Type[]'.
16531 (TypeManager.RegisterBuilder): Likewise.
16532 (TypeManager.AddUserInterface): Likewise.
16533 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
16534 `Type[]' and also return a `TypeExpr[]'.
16535 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
16537 2003-11-08 Martin Baulig <martin@ximian.com>
16539 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
16542 2003-11-08 Martin Baulig <martin@ximian.com>
16544 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
16545 TypeManager.ResolveExpressionTypes().
16547 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
16548 instead of an Expression.
16549 (TypeExpr): This is now an abstract base class for `TypeExpression'.
16550 (TypeExpression): New public class; formerly known as `TypeExpr'.
16552 * expression.cs (ComposedCast): Derive from TypeExpr.
16554 * typemanager.cs (TypeManager.system_*_expr): These are now
16555 TypExpr's instead of Expression's.
16556 (TypeManager.ResolveExpressionTypes): New public static function;
16557 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
16560 2003-11-06 Miguel de Icaza <miguel@ximian.com>
16562 * expression.cs (New.DoResolve): Do not dereference value that
16563 might be a null return.
16565 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
16566 sure that the constant value has the right type. Fixes an
16567 unreported bug, similar to 50425.
16569 * const.cs (Const.LookupConstantValue): Call
16570 ImplicitStandardConversionExists before doing a conversion to
16571 avoid havng the TypeManager.ChangeType do conversions.
16573 Reduced the number of casts used
16575 (Const.ChangeType): New routine to enable reuse of the constant
16576 type changing code from statement.
16578 * typemanager.cs (ChangeType): Move common initialization to
16579 static global variables.
16583 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
16584 every value type to go through, even if it was void. Fix that.
16586 * cs-tokenizer.cs: Use is_identifier_start_character on the start
16587 character of the define, and the is_identifier_part_character for
16588 the rest of the string.
16590 2003-11-05 Miguel de Icaza <miguel@ximian.com>
16592 * expression.cs (UnaryMutator.EmitCode): When I updated
16593 LocalVariableReference.DoResolve, I overdid it, and dropped an
16594 optimization done on local variable references.
16596 2003-11-04 Miguel de Icaza <miguel@ximian.com>
16598 * ecore.cs: Convert the return from Ldlen into an int.
16600 2003-10-20 Miguel de Icaza <miguel@ximian.com>
16602 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
16603 the accessibility, this is a special case for toplevel non-public
16604 classes (internal for instance).
16606 2003-10-20 Nick Drochak <ndrochak@gol.com>
16608 * ecore.cs: Fix typo and build. Needed another right paren.
16610 2003-10-19 Miguel de Icaza <miguel@ximian.com>
16612 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
16613 `internal' case regular and protected, but not allowing protected
16614 to be evaluated later. Bug 49840
16616 2003-10-15 Miguel de Icaza <miguel@ximian.com>
16618 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
16619 to kb.Nlast, and not the kb.nFirst to isolate the switch
16622 Extract the underlying type, so enumerations of long/ulong are
16623 treated like long/ulong.
16625 2003-10-14 Miguel de Icaza <miguel@ximian.com>
16627 * expression.cs (New): Overload the meaning of RequestedType to
16628 track the possible creation of the NewDelegate type, since
16629 DoResolve is invoked more than once for new constructors on field
16632 See bugs: #48800 and #37014
16634 * cs-parser.jay (declare_local_constants): Take an arraylist
16635 instead of a single constant.
16637 (local_constant_declaration): It should take a
16638 constant_declarators, not a constant_declarator. Fixes 49487
16640 * convert.cs: Fix error report.
16642 2003-10-13 Jackson Harper <jackson@ximian.com>
16644 * typemanager.cs (TypeToCoreType): Add float and double this fixes
16647 2003-10-09 Martin Baulig <martin@ximian.com>
16649 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
16651 (MethodCore.DoDefineParameters): Removed the TypeContainer
16652 argument; use the DeclSpace which was passed to the .ctor instead.
16653 (MethodCore.CheckParameter): Take a DeclSpace instead of a
16654 TypeContainer; we only need a DeclSpace here.
16656 2003-10-09 Martin Baulig <martin@ximian.com>
16658 * class.cs (MethodData): Added additional `DeclSpace ds' argument
16660 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
16661 EmitContext's .ctor.
16663 2003-10-09 Martin Baulig <martin@ximian.com>
16665 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
16666 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
16667 AsAccessible(), moved them as well.
16669 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
16671 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
16673 * cs-parser.jay : Renamed yyName to yyNames related to jay.
16675 2003-10-07 Miguel de Icaza <miguel@ximian.com>
16677 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
16678 generation for >=, as spotted by Paolo, bug 48679.
16679 Patch from David Waite.
16681 * cs-tokenizer.cs: Add handling for #pragma.
16683 * cs-parser.jay: Allow for both yield and yield return in the
16684 syntax. The anti-cobolization of C# fight will go on!
16686 * class.cs (TypeBuilder.DefineType): Catch error condition here
16687 (Parent.DefineType erroring out and returning null).
16689 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
16690 coping with enumerations variables, we were mistakenly processing
16691 them as a regular value type instead of built-in types. Fixes the
16694 * typemanager.cs (IsBuiltinOrEnum): New method.
16696 2003-09-30 Miguel de Icaza <miguel@ximian.com>
16698 * cs-parser.jay: Upgrade: yield now needs the return clause.
16700 2003-09-19 Martin Baulig <martin@ximian.com>
16702 * decl.cs (MemberCache.SetupCacheForInterface): Take a
16703 `MemberCache parent' argument. Normally, an interface doesn't
16704 have a parent type except System.Object, but we use this in gmcs
16705 for generic type parameters.
16707 2003-09-18 Martin Baulig <martin@ximian.com>
16709 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
16710 on `type.IsInterface'; don't check whether the type has a parent
16711 to determine whether it's an interface.
16713 2003-09-15 Martin Baulig <martin@ximian.com>
16715 * class.cs (TypeContainer.DefineType): Added an error flag to
16716 avoid reporting duplicate CS0146's ("class definition is
16719 * driver.cs (Driver.MainDriver): Abort if
16720 RootContext.ResolveTree() reported any errors.
16722 2003-09-07 Martin Baulig <martin@ximian.com>
16724 * report.cs (Error, Warning): Added overloaded versions which take
16725 a `params object[] args' and call String.Format().
16727 2003-09-07 Martin Baulig <martin@ximian.com>
16729 * decl.cs (DeclSpace..ctor): Don't call
16730 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
16731 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
16732 (DeclSpace.RecordDecl): New method.
16734 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
16736 2003-09-02 Ravi Pratap <ravi@ximian.com>
16738 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
16739 value attributes to be applied to ParameterBuilders.
16741 * class.cs (MethodCore.LabelParameters): Make static and more
16742 generic so that it can be used from other places - like interface
16743 methods, for instance.
16745 * interface.cs (Interface.Emit): Call LabelParameters before
16746 emitting attributes on the InterfaceMethod.
16748 2003-08-26 Martin Baulig <martin@ximian.com>
16750 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
16751 resolving aliases; fixes #47927.
16753 2003-08-26 Martin Baulig <martin@ximian.com>
16755 * statement.cs (Using.DoResolve): This is internally emitting a
16756 try/finally clause, so we need to set ec.NeedExplicitReturn if we
16757 do not always return. Fixes #47681.
16759 2003-08-26 Martin Baulig <martin@ximian.com>
16761 * decl.cs (MemberCore): Moved WarningNotHiding(),
16762 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
16764 (AdditionResult): Make this nested in DeclSpace.
16765 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
16766 argument; call NamespaceEntry.Define() unless we're nested in a
16769 * namespace.cs (Namespace.DefineName): New public function. This
16770 is called from DeclSpace's .ctor to add
16771 (Namespace.Lookup): Include DeclSpaces in the lookup.
16773 * class.cs (Operator): Derive from MemberBase, not MemberCore.
16775 * const.cs (Const): Derive from MemberBase, not MemberCore.
16777 2003-08-25 Martin Baulig <martin@ximian.com>
16779 * convert.cs (Convert.ExplicitReferenceConversion): When
16780 converting from an interface type to a class, unbox if the target
16781 type is a struct type. Fixes #47822.
16783 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
16785 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
16788 2003-08-22 Martin Baulig <martin@ximian.com>
16790 * class.cs (TypeManager.DefineType): When defining a nested type,
16791 call DefineType() on our parent; fixes #47801.
16793 2003-08-22 Martin Baulig <martin@ximian.com>
16795 * class.cs (MethodData.Define): While checking if a method is an
16796 interface implementation, improve the test a bit more to fix #47654.
16798 2003-08-22 Martin Baulig <martin@ximian.com>
16800 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
16801 correctly; fixes #47722.
16803 2003-08-22 Martin Baulig <martin@ximian.com>
16805 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
16806 LocalVariableReference, ensure it's not read-only. Fixes #47536.
16808 * statement.cs (Fixed.DoResolve): Make all variables read-only.
16810 2003-08-22 Martin Baulig <martin@ximian.com>
16812 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
16813 can only be assigned in static constructors. Fixes #47161.
16815 2003-08-22 Martin Baulig <martin@ximian.com>
16817 Rewrote and improved the flow analysis code.
16819 * flowbranching.cs (FlowBranching): Make this class abstract.
16820 (FlowBranching.CreateBranching): New static function to create a
16821 new flow branching.
16822 (FlowBranchingBlock, FlowBranchingException): New classes.
16823 (FlowBranching.UsageVector.Type): New public readonly field.
16824 (FlowBranching.UsageVector.Breaks): Removed the setter.
16825 (FlowBranching.UsageVector.Returns): Removed the setter.
16826 (FlowBranching.UsageVector): Added Break(), Return(),
16827 NeverReachable() and Throw() methods to modify the reachability.
16828 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
16829 done by FlowBranching.Merge().
16830 (FlowBranching.UsageVector.MergeChild): New method; merges the
16831 merge result into the current vector.
16832 (FlowBranching.Merge): New abstract method to merge a branching.
16834 2003-08-12 Martin Baulig <martin@ximian.com>
16836 * expression.cs (Indirection.CacheTemporaries): Create the
16837 LocalTemporary with the pointer type, not its element type.
16839 2003-08-10 Miguel de Icaza <miguel@ximian.com>
16841 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
16842 token was a keyword or not.
16844 Add `error' options where an IDENTIFIER was expected; Provide
16845 CheckToken and CheckIdentifierToken convenience error reporting
16848 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
16850 * decl.cs: Rename `NamespaceEntry Namespace' public field into
16851 NameSpaceEntry NameSpaceEntry.
16853 (LookupInterfaceOrClass): Avoid creating a full qualified name
16854 from namespace and name: avoid doing lookups when we know the
16855 namespace is non-existant. Use new Tree.LookupByNamespace which
16856 looks up DeclSpaces based on their namespace, name pair.
16858 * driver.cs: Provide a new `parser verbose' to display the
16859 exception thrown during parsing. This is turned off by default
16860 now, so the output of a failure from mcs is more graceful.
16862 * namespace.cs: Track all the namespaces defined in a hashtable
16865 (IsNamespace): New method
16867 2003-08-09 Miguel de Icaza <miguel@ximian.com>
16869 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
16870 we know that we need to concatenate (full typename can never be
16875 * statement.cs: Use a bitfield; Do not initialize to null things
16876 which are done by the constructor by default.
16878 * cs-parser.jay: bug fix, parameter was 4, not 3.
16880 * expression.cs: Just use the property;
16882 * statement.cs: No need for GetVariableInfo method.
16884 2003-08-08 Martin Baulig <martin@ximian.com>
16886 * flowanalysis.cs (FlowReturns): This is now nested in the
16887 `FlowBranching' class.
16888 (MyBitVector): Moved this here from statement.cs.
16889 (FlowBranching.SiblingType): New enum type.
16890 (FlowBranching.CreateSibling): Added `SiblingType' argument.
16892 2003-08-07 Martin Baulig <martin@ximian.com>
16894 * flowanalysis.cs (FlowBranchingType): This is now nested in the
16895 `FlowBranching' class and called `BranchingType'.
16897 2003-08-07 Martin Baulig <martin@ximian.com>
16899 * flowanalysis.cs: Moved all the control flow analysis code into
16902 2003-08-07 Martin Baulig <martin@ximian.com>
16904 * assign.cs (Assign.DoResolve): `target' must either be an
16905 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
16908 2003-08-07 Miguel de Icaza <miguel@ximian.com>
16910 * expression.cs (BinaryMethod): This kind of expression is created by the
16911 Binary class if it determines that the operator has to be handled
16914 (BinaryDelegate): This kind of expression is created if we are
16915 dealing with a + or - operator on delegates.
16917 (Binary): remove method, argumetns, and DelegateOperator: when
16918 dealing with methods,
16920 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
16922 * statement.cs (Block): use bitfields for the three extra booleans
16923 we had in use. Remove unused topblock parameter.
16925 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
16927 * assign.cs: Drop extra unneeded tests.
16929 2003-08-06 Miguel de Icaza <miguel@ximian.com>
16931 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
16933 * statement.cs (Foreach): Use VariableStorage instead of
16936 * codegen.cs (VariableStorage): New class used by clients that
16937 require a variable stored: locals or fields for variables that
16938 need to live across yield.
16940 Maybe provide a convenience api for EmitThis+EmitLoad?
16942 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
16945 2003-08-05 Miguel de Icaza <miguel@ximian.com>
16947 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
16948 RemapParameterLValue): New methods that are used to turn a
16949 precomputed FieldInfo into an expression like this:
16953 The idea is to use this instead of making LocalVariableReference
16954 have more than one meaning.
16956 * cs-parser.jay: Add error production to BASE.
16958 * ecore.cs: Deal with TypeManager.GetField returning null, which
16959 is now a valid return value.
16961 (FieldExprNoAddress): New expression for Fields whose address can
16964 * expression.cs (LocalVariableReference): During the resolve
16965 phases, create new expressions if we are in a remapping context.
16966 Remove code that dealt with remapping here.
16968 (ParameterReference): same.
16970 (ProxyInstance): New expression, like the `This' expression, but
16971 it is born fully resolved. We know what we are doing, so remove
16972 the errors that are targeted to user-provided uses of `this'.
16974 * statement.cs (Foreach): our variable is now stored as an
16975 Expression; During resolution, follow the protocol, dont just
16976 assume it will return this.
16978 2003-08-06 Martin Baulig <martin@ximian.com>
16980 * support.cs (SeekableStreamReader.cs): New public class.
16982 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
16983 SeekableStreamReader instead of the normal StreamReader.
16985 2003-08-04 Martin Baulig <martin@ximian.com>
16987 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
16988 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
16989 deambiguate casts and delegate invocations.
16990 (parenthesized_expression): Use the new tokens to ensure this is
16991 not a cast of method invocation.
16993 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
16994 when reading a `)' and Deambiguate_CloseParens () was previously
16997 * expression.cs (ParenthesizedExpression): New class. This is
16998 just used for the CS0075 test.
16999 (Binary.DoResolve): Check for CS0075.
17001 2003-07-29 Ravi Pratap <ravi@ximian.com>
17003 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
17004 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
17005 reference comparison.
17007 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
17008 examine the ReturnType for equality - this is necessary in the
17009 cases of implicit and explicit operators whose signature also
17010 includes the return type.
17012 2003-07-26 Miguel de Icaza <miguel@ximian.com>
17014 * namespace.cs: Cache the result of the namespace computation,
17015 instead of computing it every time.
17017 2003-07-24 Miguel de Icaza <miguel@ximian.com>
17019 * decl.cs: Use a global arraylist that we reuse over invocations
17020 to avoid excesive memory consumption. Reduces memory usage on an
17021 mcs compile by one meg (45 average).
17023 * typemanager.cs (LookupTypeReflection): In .NET pointers are
17024 private, work around that.
17026 2003-07-23 Miguel de Icaza <miguel@ximian.com>
17028 * literal.cs (IntLiteral): Define Zero and One static literals.
17030 * cs-parser.jay (integer_literal): use static literals to reduce
17031 memory usage for the most used literals (0, 1 and -1). 211kb
17032 reduced in memory usage.
17034 Replace all calls to `new ArrayList' with `new
17035 ArrayList(4)' which is a good average number for most allocations,
17036 and also requires only 16 bytes of memory for its buffer by
17039 This reduced MCS memory usage in seven megabytes for the RSS after
17042 2003-07-28 Ravi Pratap <ravi@ximian.com>
17044 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
17045 handle params methods the correct way by forming only one
17046 applicable set with params and normal methods in them. Earlier we
17047 were looking at params methods only if we found no normal methods
17048 which was not the correct thing to do.
17050 (Invocation.BetterFunction): Take separate arguments indicating
17051 when candidate and the best method are params methods in their
17054 This fixes bugs #43367 and #46199.
17056 * attribute.cs: Documentation updates.
17058 (CheckAttribute): Rename to CheckAttributeTarget.
17059 (GetValidPlaces): Rename to GetValidTargets.
17061 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
17062 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
17066 2003-07-28 Martin Baulig <martin@ximian.com>
17068 * class.cs (TypeContainer.DefineMembers): Use the base type's full
17069 name when looking up the base class of a nested class. Fixes #46977.
17071 2003-07-26 Martin Baulig <martin@ximian.com>
17073 * expression.cs (Indexers.Indexer): New nested struct; contains
17074 getter, setter and the indexer's type.
17075 (Indexers.Properties): This is now an ArrayList of
17076 Indexers.Indexer's.
17077 (IndexerAccess.DoResolveLValue): Correctly set the type if the
17078 indexer doesn't have any getters.
17080 * assign.cs (Assign.DoResolve): Also do the implicit conversions
17081 for embedded property and indexer assignments.
17083 2003-07-26 Martin Baulig <martin@ximian.com>
17085 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
17086 preprocessor directive is not the first non-whitespace character
17089 2003-07-26 Martin Baulig <martin@ximian.com>
17091 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
17092 namespace parsing, follow the spec more closely.
17094 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
17095 NamespaceEntry.Lookup().
17097 2003-07-25 Martin Baulig <martin@ximian.com>
17099 * MethodCore.cs (OverridesSomething): New public field; it's set
17100 from TypeContainer.DefineMembers if this method overrides
17101 something (which doesn't need to be a method). Fix #39462.
17103 2003-07-25 Ravi Pratap <ravi@ximian.com>
17105 * typemanager.cs (GetMembers): Ensure that the list of members is
17106 reversed. This keeps things in sync.
17108 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
17109 find an AttributeUsage attribute.
17111 * expression.cs (Invocation.OverloadResolve): Perform the check
17112 which disallows Invoke to be directly called on a Delegate.
17114 (Error_InvokeOnDelegate): Report error cs1533.
17116 2003-07-25 Martin Baulig <martin@ximian.com>
17118 * expression.cs (Indexers.GetIndexersForType): Only look in the
17119 interface hierarchy if the requested type is already an
17120 interface. Fixes #46788 while keeping #46502 fixed.
17122 2003-07-25 Martin Baulig <martin@ximian.com>
17124 * class.cs (TypeContainer.DefineMembers): Check whether all
17125 readonly fields have been assigned and report warning CS0649 if
17128 * statement.cs (LocalInfo.IsFixed): Always return true if this is
17131 2003-07-24 Ravi Pratap <ravi@ximian.com>
17133 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
17134 returned from GetMethods to make things consistent with the
17135 assumptions MCS makes about ordering of methods.
17137 This should comprehensively fix bug #45127 and it does :-)
17139 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
17140 ordering is actually reverse.
17142 * Clean up some debug messages I left lying around.
17144 * interface.cs (Populate*): Get rid of code which emits attributes
17145 since the stage in which we emit attributes is the 'Emit' stage,
17146 not the define stage.
17148 (Emit): Move attribute emission for interface members here.
17150 2003-07-22 Ravi Pratap <ravi@ximian.com>
17152 * expression.cs (Invocation.OverloadResolve): Follow the spec more
17153 closely: we eliminate methods in base types when we have an
17154 applicable method in a top-level type.
17156 Please see section 14.5.5.1 for an exact description of what goes
17159 This fixes bug #45127 and a host of other related to corlib compilation.
17161 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
17162 array is the method corresponding to the top-level type (this is
17163 because of the changes made to icall.c) so we change this
17166 (MethodGroupExpr.Name): This too.
17168 * typemanager.cs (GetElementType): New method which does the right
17169 thing when compiling corlib.
17171 * everywhere: Make use of the above in the relevant places.
17173 2003-07-22 Martin Baulig <martin@ximian.com>
17175 * cs-parser.jay (invocation_expression): Moved
17176 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
17177 `cast_expression', but create a InvocationOrCast which later
17178 resolves to either an Invocation or a Cast.
17180 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
17181 method; call this before EmitStatement() to make sure that this
17182 expression can be used as a statement.
17184 * expression.cs (InvocationOrCast): New class; resolves to either
17185 an Invocation or a Cast.
17187 * statement.cs (StatementExpression): Call ResolveStatement() on
17188 the ExpressionStatement before emitting it.
17190 2003-07-21 Martin Baulig <martin@ximian.com>
17192 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
17193 `ref' and `out' attributes match; fixes #46220.
17194 (MemberAccess.ResolveMemberAccess): You can't reference a type
17195 through an expression; fixes #33180.
17196 (Indexers.GetIndexersForType): Don't return the indexers from
17197 interfaces the class implements; fixes #46502.
17199 2003-07-21 Martin Baulig <martin@ximian.com>
17201 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
17202 CS0661 checks; fixes bug #30442.
17204 2003-07-21 Martin Baulig <martin@ximian.com>
17206 * decl.cs (AdditionResult): Added `Error'.
17208 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
17210 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
17211 makes cs0031.cs actually work.
17213 2003-07-20 Martin Baulig <martin@ximian.com>
17215 * namespace.cs: Fixed that bug which caused a crash when compiling
17216 the debugger's GUI.
17218 2003-07-20 Miguel de Icaza <miguel@ximian.com>
17220 * typemanager.cs (LookupTypeReflection): Never expose types which
17221 are NotPublic, NestedPrivate, NestedAssembly, or
17222 NestedFamANDAssem. We used to return these, and later do a check
17223 that would report a meaningful error, but the problem is that we
17224 would not get the real match, if there was a name override.
17226 2003-07-18 Miguel de Icaza <miguel@ximian.com>
17228 * namespace.cs (Namespace, Name): Do not compute the namespace
17229 name dynamically, compute it in the constructor. This reduced
17230 memory usage by 1697 KB.
17232 * driver.cs: Use --pause to pause at the end.
17234 2003-07-17 Peter Williams <peter@newton.cx>
17236 * Makefile: Change the name of the test target so that it doesn't
17237 conflict with the recursive test target.
17239 2003-07-17 Miguel de Icaza <miguel@ximian.com>
17241 * expression.cs (LocalVariableReference.Emit, EmitAssign,
17242 AddressOf): Do not use EmitThis, that was wrong, use the actual
17245 2003-07-15 Miguel de Icaza <miguel@ximian.com>
17247 * class.cs (MethodData.Define): While checking if a method is an
17248 interface implementation, improve the test: If we are not public
17249 (use new test here: use the computed MethodAttributes directly,
17250 instead of the parsed modifier flags) check if the `implementing'
17251 method comes from an interface or not.
17253 * pending.cs (VerifyPendingMethods): Slightly better error
17256 * makefile: add test target that does the mcs bootstrap.
17258 2003-07-16 Ravi Pratap <ravi@ximian.com>
17260 * interface.cs (Define): Do nothing here since there are no
17261 members to populate etc. Move the attribute emission out of here
17262 since this was just totally the wrong place to put it. Attribute
17263 application happens during the 'Emit' phase, not in the 'Define'
17266 (Emit): Add this method and move the attribute emission here
17268 * rootcontext.cs (EmitCode): Call the Emit method on interface
17271 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17273 * expression.cs (OverloadResolve): Report error only if Location
17274 is not 'Null' which means that there was a probe going on.
17276 2003-07-14 Martin Baulig <martin@ximian.com>
17278 * expression.cs (ConditionalLogicalOperator): New public class to
17279 implement user defined conditional logical operators.
17280 This is section 14.11.2 in the spec and bug #40505.
17282 2003-07-14 Martin Baulig <martin@ximian.com>
17284 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
17286 2003-07-14 Martin Baulig <martin@ximian.com>
17288 * codegen.cs (EmitContext.InFixedInitializer): New public field.
17290 * ecore.cs (IVariable.VerifyFixed): New interface method.
17292 * expression.cs (Unary.ResolveOperator): When resolving the `&'
17293 operator, check whether the variable is actually fixed. Fixes bug
17294 #36055. Set a variable definitely assigned when taking its
17295 address as required by the spec.
17297 * statement.cs (LocalInfo.IsFixed): New field.
17298 (LocalInfo.MakePinned): Set `IsFixed' to true.
17300 2003-07-14 Ravi Pratap M <ravi@ximian.com>
17302 * attribute.cs (Attribute.Resolve): While doing a Member lookup
17303 for .ctors, ensure that we only ask for members declared in the
17304 attribute type (BindingFlags.DeclaredOnly).
17308 * expression.cs (Error_WrongNumArguments): Report error 1501
17309 correctly the way CSC does.
17311 2003-07-13 Martin Baulig <martin@ximian.com>
17313 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
17314 lookup on the fully qualified name, to make things like "X.X" work
17315 where "X.X" is a fully qualified type name, but we also have a
17316 namespace "X" in the using list. Fixes #41975.
17318 2003-07-13 Martin Baulig <martin@ximian.com>
17320 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
17321 function. If we're a CompoundAssign, we need to create an embedded
17322 CompoundAssign, not an embedded Assign.
17323 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
17326 2003-07-13 Martin Baulig <martin@ximian.com>
17328 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
17329 work to fix bug #46088.
17331 2003-07-13 Ravi Pratap <ravi@ximian.com>
17333 * class.cs (Operator.Emit): Do not emit attributes here - it is
17334 taken care of by the Method class that we delegate too. This takes
17335 care of bug #45876.
17337 2003-07-10 Martin Baulig <martin@ximian.com>
17339 * expression.cs (TypeOfVoid): New class.
17340 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
17342 2003-07-10 Martin Baulig <martin@ximian.com>
17344 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
17347 2003-07-10 Martin Baulig <martin@ximian.com>
17349 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
17350 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
17352 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
17354 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
17356 2003-07-10 Martin Baulig <martin@ximian.com>
17358 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
17359 of decimal. Fixes #42850.
17361 NOTE: I also fixed the created byte blob, but this doesn't work on
17362 the MS runtime and csc never produces any byte blobs for decimal
17365 2003-07-10 Martin Baulig <martin@ximian.com>
17367 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
17368 structs; fixes #32068.
17369 (Block.AddChildVariableNames): Fixed #44302.
17371 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17373 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
17375 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17377 * attribute.cs: And this test is onger needed.
17379 2003-07-08 Martin Baulig <martin@ximian.com>
17381 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
17382 inaccessible types. Fixes #36313.
17384 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
17386 * namespace.cs (NamespaceEntry): Create implicit entries for all
17387 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
17388 implicit entries for N1.N2 and N1.
17390 2003-07-08 Martin Baulig <martin@ximian.com>
17392 Rewrote the handling of namespaces to fix a lot of the issues
17393 wrt. `using' aliases etc.
17395 * namespace.cs (Namespace): Splitted this class into a
17396 per-assembly `Namespace' and a per-file `NamespaceEntry'.
17398 * typemanager.cs (TypeManager.IsNamespace): Removed.
17399 (TypeManager.ComputeNamespaces): Only compute namespaces from
17400 loaded assemblies here, not the namespaces from the assembly we're
17401 currently compiling.
17403 2003-07-08 Martin Baulig <martin@ximian.com>
17405 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
17407 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17409 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
17412 I thought about the memory savings here, but LookupTypeReflection
17413 is used under already very constrained scenarios. Compiling
17414 corlib or mcs only exposes one hit, so it would not really reduce
17415 any memory consumption.
17417 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17419 * typemanager.cs: fixes bug #45889 by only adding public types from
17420 other assemblies to the list of known types.
17422 2003-07-07 Miguel de Icaza <miguel@ximian.com>
17424 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
17425 on the type we resolved.
17427 2003-07-05 Martin Baulig <martin@ximian.com>
17429 * pending.cs (PendingImplementation.ParentImplements): Don't
17430 create the proxy if the parent is abstract.
17432 * class.cs (TypeContainer.DefineIndexers): Process explicit
17433 interface implementations first. Fixes #37714.
17435 2003-07-04 Miguel de Icaza <miguel@ximian.com>
17437 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
17438 defined recursively; but since we modify the input parameters
17439 (left is set to `this' temporarily), we reset this value if the
17440 left_is_explicit is false, which gives the original semantics to
17443 * literal.cs (NullPointer): new class used to represent a null
17444 literal in a pointer context.
17446 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
17447 type is a pointer, use a NullPointer object instead of a
17448 NullLiteral. Closes 43687
17450 (ExplicitConversion): Convert pointer values using
17451 the conv opcode to the proper type.
17453 * ecore.cs (New): change ValueTypeVariable property into a method,
17454 that returns whether the valuetype is suitable for being used.
17456 * expression.cs (Binary.DoNumericPromotions): Only return if we
17457 the int constant was a valid uint, and we can return both left and
17458 right as uints. If not, we continue processing, to trigger the
17459 type conversion. This fixes 39018.
17461 * statement.cs (Block.EmitMeta): During constant resolution, set
17462 the CurrentBlock property on the emitcontext, so that we resolve
17463 constants propertly.
17465 2003-07-02 Martin Baulig <martin@ximian.com>
17467 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
17468 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
17470 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
17471 than emitting it here.
17473 * statement.cs: Fixed some more flow analysis bugs.
17475 2003-07-02 Martin Baulig <martin@ximian.com>
17477 * class.cs (MethodData.Define): When implementing interface
17478 methods, set Final unless we're Virtual.
17480 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
17481 check work for interface methods.
17483 2003-07-01 Martin Baulig <martin@ximian.com>
17485 * ecore.cs (EmitContext.This): Replaced this property with a
17486 GetThis() method which takes a Location argument. This ensures
17487 that we get the correct error location for a CS0188.
17489 2003-07-01 Miguel de Icaza <miguel@ximian.com>
17491 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
17492 ImplicitStandardConversion.
17494 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
17496 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
17498 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
17501 2003-06-30 Miguel de Icaza <miguel@ximian.com>
17503 * class.cs (Constructor.Define): Turn off initlocals for unsafe
17506 (MethodData.Define): Turn off initlocals for unsafe methods.
17508 2003-06-29 Miguel de Icaza <miguel@ximian.com>
17510 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
17511 complete; Fixes #37521.
17513 * delegate.cs: Use Modifiers.TypeAttr to compute the
17514 TypeAttributes, instead of rolling our own. This makes the flags
17515 correct for the delegates.
17517 2003-06-28 Miguel de Icaza <miguel@ximian.com>
17519 * class.cs (Constructor.Define): Set the private flag for static
17520 constructors as well.
17522 * cs-parser.jay (statement_expression): Set the return value to
17523 null, to avoid a crash when we catch an error.
17525 2003-06-24 Miguel de Icaza <miguel@ximian.com>
17527 * cs-parser.jay: Applied patch from Jackson that adds support for
17528 extern and unsafe modifiers to destructor declarations.
17530 * expression.cs: Report error 21 if the user is trying to index a
17533 * driver.cs: Add an error message, suggested by the bug report.
17535 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
17536 if we do not have a ": this ()" constructor initializer. Fixes 45149
17538 2003-06-14 Miguel de Icaza <miguel@ximian.com>
17540 * namespace.cs: Add some information to reduce FAQs.
17542 2003-06-13 Miguel de Icaza <miguel@ximian.com>
17544 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
17545 underlying enumeration types. Fixes #43915.
17547 * expression.cs: Treat ushort/short as legal values to be used in
17548 bitwise operations.
17550 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
17552 * delegate.cs: transfer custom attributes for paramenters from
17553 the delegate declaration to Invoke and BeginInvoke.
17555 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
17557 * attribute.cs: handle custom marshalers and emit marshal info
17560 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
17562 * makefile.gnu: Added anonymous.cs to the compiler sources.
17564 2003-05-28 Miguel de Icaza <miguel@ximian.com>
17566 * iterators.cs: Change the name of the proxy class to include two
17569 * cs-parser.jay: Update grammar to include anonymous methods.
17571 * anonymous.cs: new file.
17573 2003-05-27 Miguel de Icaza <miguel@ximian.com>
17575 * class.cs (Field.Define): Add missing test for pointers and
17578 2003-05-27 Ravi Pratap <ravi@ximian.com>
17580 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
17581 we use the stobj opcode.
17583 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
17584 since it wasn't the correct fix.
17586 It still is puzzling that we are required to use stobj for IntPtr
17587 which seems to be a ValueType.
17589 2003-05-26 Miguel de Icaza <miguel@ximian.com>
17591 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
17592 during regular simple name resolution. Now, the trick is that
17593 instead of returning for processing the simplename, we do a
17594 TypeManager.LookupType (ie, a rooted lookup as opposed to a
17595 contextual lookup type). If a match is found, return that, if
17596 not, return for further composition.
17598 This fixes long-standing 30485.
17600 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
17601 using the address to initialize an object, do an Stobj instead of
17602 using the regular Stelem.
17604 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
17605 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
17606 Because if we are a BaseIndexerAccess that value will be true.
17609 * statement.cs (GotoCase.Resolve): Return after reporting an
17610 error, do not attempt to continue.
17612 * expression.cs (PointerArithmetic.Emit): If our operand is a
17613 long, convert our constants to match the operand before
17614 multiplying. Convert to I type before adding. Fixes 43670.
17616 2003-05-14 Ravi Pratap <ravi@ximian.com>
17618 * enum.cs (ImplicitConversionExists) : Rename to
17619 ImplicitEnumConversionExists to remove ambiguity.
17621 * ecore.cs (NullCast): New type of cast expression class which
17622 basically is very similar to EmptyCast with the difference being
17623 it still is a constant since it is used only to cast a null to
17625 (eg. (string) null)
17627 * convert.cs (ImplicitReferenceConversion): When casting a null
17628 literal, we return a NullCast.
17630 * literal.cs (NullLiteralTyped): Remove - I don't see why this
17631 should be around anymore.
17633 The renaming (reported was slightly wrong). Corrections:
17635 ConvertImplicitStandard -> ImplicitConversionStandard
17636 ConvertExplicitStandard -> ExplicitConversionStandard
17638 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
17639 before passing them in !
17641 * convert.cs (ImplicitConversionStandard): When comparing for
17642 equal expr and target types, ensure that expr is not a
17645 In general, we must not be checking (expr_type ==
17646 target_type) in the top level conversion methods
17647 (ImplicitConversion, ExplicitConversion etc). This checking is
17648 done in the methods that they delegate to.
17650 2003-05-20 Miguel de Icaza <miguel@ximian.com>
17652 * convert.cs: Move Error_CannotConvertType,
17653 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
17654 ImplicitNumericConversion, ImplicitConversionExists,
17655 ImplicitUserConversionExists, StandardConversionExists,
17656 FindMostEncompassedType, FindMostSpecificSource,
17657 FindMostSpecificTarget, ImplicitUserConversion,
17658 ExplicitUserConversion, GetConversionOperators,
17659 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
17660 TryImplicitIntConversion, Error_CannotConvertImplicit,
17661 ConvertImplicitRequired, ConvertNumericExplicit,
17662 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
17663 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
17666 Perform the following renames:
17668 StandardConversionExists -> ImplicitStandardConversionExists
17669 ConvertImplicit -> ImplicitConversion
17670 ConvertImplicitStandard -> ImplicitStandardConversion
17671 TryImplicitIntConversion -> ImplicitIntConversion
17672 ConvertImplicitRequired -> ImplicitConversionRequired
17673 ConvertNumericExplicit -> ExplicitNumericConversion
17674 ConvertReferenceExplicit -> ExplicitReferenceConversion
17675 ConvertExplicit -> ExplicitConversion
17676 ConvertExplicitStandard -> ExplicitStandardConversion
17678 2003-05-19 Martin Baulig <martin@ximian.com>
17680 * statement.cs (TypeInfo.StructInfo): Made this type protected.
17681 (TypeInfo): Added support for structs having structs as fields.
17683 * ecore.cs (FieldExpr): Implement IVariable.
17684 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
17685 VariableInfo for the field.
17687 2003-05-18 Martin Baulig <martin@ximian.com>
17689 * expression.cs (This.DoResolve): Report a CS0027 if we're
17690 emitting a field initializer.
17692 2003-05-18 Martin Baulig <martin@ximian.com>
17694 * expression.cs (This.ResolveBase): New public function.
17695 (This.DoResolve): Check for CS0188.
17697 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
17700 * ecore.cs (MethodGroupExpr.DoResolve): Set the
17701 `instance_expression' to null if we don't have any non-static
17704 2003-05-18 Martin Baulig <martin@ximian.com>
17706 Reworked the way how local variables and parameters are handled by
17707 the flow analysis code.
17709 * statement.cs (TypeInfo, VariableMap): New public classes.
17710 (VariableInfo): New public class. This is now responsible for
17711 checking whether a variable has been assigned. It is used for
17712 parameters and local variables.
17713 (Block.EmitMeta): Take the InternalParameters as argument; compute
17714 the layout of the flow vectors here.
17715 (Block.LocalMap, Block.ParameterMap): New public properties.
17716 (FlowBranching): The .ctor doesn't get the InternalParameters
17717 anymore since Block.EmitMeta() now computes the layout of the flow
17719 (MyStructInfo): This class is now known as `StructInfo' and nested
17720 in `TypeInfo'; we don't access this directly anymore.
17722 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
17723 property and removed IsAssigned(), IsFieldAssigned(),
17724 SetAssigned() and SetFieldAssigned(); we now call them on the
17725 VariableInfo so we don't need to duplicate this code everywhere.
17727 * expression.cs (ParameterReference): Added `Block block' argument
17729 (LocalVariableReference, ParameterReference, This): The new
17730 VariableInfo class is now responsible for all the definite
17733 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
17734 IsParameterAssigned, SetParameterAssigned): Removed.
17736 2003-05-18 Martin Baulig <martin@ximian.com>
17738 * typemanager.cs (InitCoreTypes): Try calling
17739 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
17740 the 3-args-version. Corlib now also needs our `void_type'.
17741 (GetMethod): Added overloaded version which takes an optional
17742 `bool report_errors' to allow lookups of optional methods.
17744 2003-05-12 Martin Baulig <martin@ximian.com>
17746 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
17747 only used for locals and not for parameters.
17749 2003-05-12 Miguel de Icaza <miguel@ximian.com>
17751 * support.cs (InternalParameters.ParameterType): Return the
17752 ExternalType of the parameter.
17754 * parameter.cs (Parameter.ExternalType): drop the two arguments,
17757 2003-05-11 Miguel de Icaza <miguel@ximian.com>
17759 * class.cs (MethodData.Define): Do not set the `newslot' on
17760 interface members, if they are also flagged as "override".
17762 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
17763 better code for ++i and i++. This only works for static fields
17764 and local variables.
17766 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
17767 want to pull the DeclSpace out of the builder_to_declspace instead
17768 of the TypeBuilder (like in TypeContainer.FindMembers).
17770 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
17771 instead of LookupTypeContainer. Fixes the crash on .NET for
17772 looking up interface members.
17774 * const.cs: Create our own emit context during the Definition
17775 stage, so that constants are evaluated in the proper context, when
17776 a recursive definition happens.
17778 2003-05-11 Martin Baulig <martin@ximian.com>
17780 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
17781 new block for a switch section.
17782 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
17783 the adding/lookup in the switch block. Fixes #39828.
17785 2003-05-09 Miguel de Icaza <miguel@ximian.com>
17787 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
17788 functionality: I needed to convert the data after I had performed
17789 the add/sub operation into the operands type size.
17791 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
17792 pass the type for the box operation, otherwise the resulting
17793 object would have been of type object.
17795 (BoxedCast): Add constructor to specify the type to box as.
17797 2003-05-07 Miguel de Icaza <miguel@ximian.com>
17799 * iterators.cs: I was reusing the `count' variable inadvertently,
17800 take steps to not allow this to happen.
17802 2003-05-06 Miguel de Icaza <miguel@ximian.com>
17804 * attribute.cs (Attribute.Resolve): Params attributes are encoded
17805 by creating an array at the point where the params starts and
17806 putting all those arguments there, then adjusting the size of the
17809 2003-05-05 Miguel de Icaza <miguel@ximian.com>
17811 * expression.cs (New.AddressOf): Implement interface
17812 IMemoryLocation. This is used when the `new' operator is used in
17813 the context of an invocation to a method on a value type.
17815 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
17818 * namespace.cs: Also check the using aliases here.
17820 * driver.cs: Move the test for using validity after the types have
17821 been entered, so we do a single pass that also includes the using
17824 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
17825 in the regular case. CreateSiblingForFinally is doing extra
17828 * attribute.cs (GetAttributeArgumentExpression): Store the result
17829 on an out value, and use the return value to indicate failure
17830 instead of using null (which is a valid return for Constant.GetValue).
17832 * statement.cs: Perform the analysis flow for the increment
17833 portion after the statement, because this will be the real flow of
17834 execution. Fixes #42385
17836 * codegen.cs (EmitContext.EmitArgument,
17837 EmitContext.EmitStoreArgument): New helper functions when the
17838 RemapToProxy flag is set.
17840 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
17843 Add support for remapping parameters.
17845 * iterators.cs: Propagate parameter values; Store parameter
17846 values in the proxy classes.
17848 2003-05-04 Miguel de Icaza <miguel@ximian.com>
17850 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
17851 need a proxy reference; I do not know what I was thinking
17853 * cs-parser.jay (constructor_initializer): catch another error,
17854 and display nice message.
17856 (field_declaration): catch void field declaration
17857 to flag a better error.
17859 * class.cs (MemberBase.CheckBase): Report an error instead of a
17860 warning if a new protected member is declared in a struct.
17861 (Field.Define): catch the error of readonly/volatile.
17863 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
17865 (FieldExpr.AddressOf): ditto. Catch error where the address of a
17866 volatile variable is taken
17868 2003-05-02 Miguel de Icaza <miguel@ximian.com>
17870 * statement.cs (Fixed.Resolve): Report an error if we are not in
17873 2003-05-01 Miguel de Icaza <miguel@ximian.com>
17875 * typemanager.cs: reuse the code that handles type clashes for
17876 delegates and enumerations.
17878 * class.cs (Report28): Always report.
17880 * expression.cs (EncodeAsAttribute): Allow nulls here.
17882 2003-04-28 Miguel de Icaza <miguel@ximian.com>
17884 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
17885 the functionality for testing whether an expression is valid for
17886 an attribute here. Also handle the case of arrays of elements
17889 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
17890 encoding a linear array into an array of objects that are suitable
17891 to be passed to an CustomAttributeBuilder.
17893 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
17895 * ecore.cs: (FieldExpr): Handle field remapping here.
17897 * iteratators.cs: Pass the instance variable (if the method is an
17898 instance method) to the constructors, so we can access the field
17899 variables on the class.
17901 TODO: Test this with structs. I think the THIS variable on
17902 structs might have to be a pointer, and not a refenrece
17904 2003-04-27 Miguel de Icaza <miguel@ximian.com>
17906 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
17907 local variables to fields in a proxy class.
17909 * iterators.cs (PopulateProxy): Rename our internal fields to
17911 Create a <THIS> field if we are an instance method, so we can
17912 reference our parent container variables.
17913 (MapVariable): Called back from the EmitContext code to enter a
17914 new variable to field mapping into the proxy class (we just create
17918 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
17919 for using the remapped locals to fields.
17921 I placed the code here, because that gives the same semantics to
17922 local variables, and only changes the Emit code.
17924 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
17925 statements inside iterators.
17926 (VariableInfo): Add a FieldBuilder for the cases when we are
17927 remapping local variables to fields in a proxy class
17929 * ecore.cs (SimpleNameResolve): Avoid testing two times for
17930 current_block != null.
17932 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
17933 not cope with strings, as it has been moved to the
17934 TableSwitchEmit. Fixed bug in switch generation.
17936 * expression.cs (New.DoResolve): Provide more context for the user
17937 when reporting an error.
17939 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
17942 * expression.cs (MemberAccess.DoResolve): When we get a type back,
17943 check the permissions for it. Note than in a type-resolution
17944 context the check was already present in DeclSpace.ResolveType,
17945 but was missing from the MemberAccess.
17947 (ArrayCreation.CheckIndices): warn if the user has
17948 more nested levels of expressions, but there are no more
17949 dimensions specified. Avoids crash on bug 41906.
17951 2003-04-26 Miguel de Icaza <miguel@ximian.com>
17953 * statement.cs (Block): replace Implicit bool, for a generic
17955 New flag: `Unchecked'. This is used during the EmitMeta phase
17956 (which is out-of-line with the regular Resolve/Emit process for a
17957 statement, as this is done ahead of time, but still gets a chance
17958 to call constant resolve).
17960 (Block.Flags): new enum for adding a new flag.
17962 (Block.EmitMeta): track the state of unchecked.
17964 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
17965 to enable constant resolution to work there as well.
17967 2003-04-22 Miguel de Icaza <miguel@ximian.com>
17969 * typemanager.cs (ienumerable_type): Also look up
17970 System.Collections.IEnumerable.
17972 2003-04-21 Miguel de Icaza <miguel@ximian.com>
17974 TODO: Test more than one conditional per method.
17976 * class.cs (Indexer.Define): Report the location where the user is
17977 referencing the unsupported feature.
17979 (MethodData): Overload the use of `conditionals' to
17980 minimize the creation of needless ArrayLists. This saves roughly
17981 212kb on my machine.
17983 (Method): Implement the new IIteratorContainer interface.
17984 (Method.SetYields): Implement the method by setting the ModFlags
17985 to contain METHOD_YIELDS.
17987 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
17988 which just got set to null.
17990 * iterators.cs: New file.
17992 (Yield, YieldBreak): New statements.
17994 * statement.cs (Return.Resolve): Flag an error if we are used in
17995 an iterator method.
17997 * codegen.cs (InIterator): New flag set if the code is being
17998 compiled in an iterator method.
18000 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
18001 internal modifier, and we just use it to avoid adding extra
18002 fields, as this is seldom used.
18004 * cs-parser.jay: Add yield_statement (yield and yield break).
18006 * driver.cs: New flag -v2 to turn on version 2 features.
18008 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
18009 hashtable when v2 is enabled.
18011 2003-04-20 Miguel de Icaza <miguel@ximian.com>
18013 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
18014 there is already a namespace defined with this name.
18016 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
18017 people upgraded their corlibs.
18019 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
18020 always use fully qualified types, no need to use the compiler
18023 (TypeManager.IsNamespace): Use binarysearch.
18025 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
18026 AddDelegate): I did not quite use the new IsValid API properly: I
18027 have to pass the short-name and the fullname. I was passing only
18028 the basename instead of the fullname sometimes.
18030 (TypeContainer.DefineType): call NamespaceClash.
18032 * interface.cs (Interface.DefineType): use NamespaceClash before
18035 * delegate.cs (Delegate.DefineType): use NamespaceClash before
18038 * enum.cs: (Enum.DefineType): use NamespaceClash before
18041 * typemanager.cs (: 3-line patch that gives us some tasty 11%
18042 speed increase. First, use the negative_hits cache when we get a
18043 negative. Second, add the type with its full original name
18044 instead of the new . and + encoded name (reflection uses + to
18045 separate type from a nested type). Use LookupTypeReflection
18046 directly which bypasses the type->name hashtable (that we already
18047 know does not contain the type.
18049 * decl.cs (DeclSpace.ResolveTypeExpr): track the
18050 location/container type.
18052 * driver.cs: When passing utf8, use directly the UTF8Encoding.
18054 2003-04-19 Miguel de Icaza <miguel@ximian.com>
18056 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
18058 * delegate.cs (NewDelegate.Resolve): Test whether an instance
18059 method is being referenced in the method group from a static
18060 context, and report error 120 if so.
18062 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
18065 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
18066 is created, we create the A namespace).
18068 * cs-parser.jay: A namespace also introduces a DeclarationFound.
18071 2003-04-18 Miguel de Icaza <miguel@ximian.com>
18073 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
18074 invocation to ModuleBuilder.GetType with the same values will
18075 return a new type instance, so we need to cache its return
18078 * expression.cs (Binary.ResolveOperator): Only allow the compare
18079 operators on enums if they are of the same type.
18081 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
18082 types of ValueType on their own case. Before we were giving them
18083 the same treatment as objects.
18085 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
18086 fullname. Short name is used to compare against container name.
18087 Fullname is used to check against defined namespace names.
18089 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
18090 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
18092 (Method.CheckBase): Call parent.
18093 (MemberBase.CheckBase): Check for protected members on sealed
18095 (PropertyBase.CheckBase): Call parent.
18096 (Field.Define): Call parent.
18098 * report.cs: Negative error codes are now mapped to 8000 - code,
18099 so that the display is render more nicely.
18101 * typemanager.cs: Do not use try/catch, instead report a regular
18104 (GetPointerType, GetReferenceType): These methods provide
18105 mechanisms to obtain the T* and T& from a T. We had the code
18106 previously scattered around the code base, and it also used
18107 TypeManager.LookupType that would go through plenty of caches.
18108 This one goes directly to the type source.
18110 In some places we did the Type.GetType followed by
18111 ModuleBuilder.GetType, but not in others, so this unifies the
18112 processing as well.
18114 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
18115 statements now that we have namespace information.
18117 * typemanager.cs (IsNamespace): New method, returns whether the
18118 string presented is a namespace or not.
18120 (ComputeNamespaces): New public entry point, computes the list of
18121 available namespaces, using the GetNamespaces API call in Mono, or
18122 the slower version in MS.NET.
18124 Now before we start the semantic analysis phase, we have a
18125 complete list of namespaces including everything that the user has
18128 Deleted old code to cache namespaces in .nsc files.
18130 2003-04-17 Miguel de Icaza <miguel@ximian.com>
18132 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
18133 class/struct location definition Location for the implicit
18134 constructor location.
18136 (Operator.Define): Use the location of the operator for the
18137 implicit Method definition.
18139 (Constructor.Emit): use the constructor location for the implicit
18140 base initializer constructor.
18142 * ecore.cs: Remove ITypeExpression. This interface is now gone,
18143 and the Expression class now contains two new methods:
18145 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
18146 isolate type lookup from the rest of the resolution process.
18148 Since we use Expressions to hold type definitions due to the way
18149 we parse the input we have historically overloaded Resolve to
18150 perform the Type lookups if a special flag is passed. Now this is
18151 eliminated and two methods take their place.
18153 The differences in the two methods between xStep and xTerminal is
18154 that xStep is involved in our current lookup system that uses
18155 SimpleNames to compose a name, while xTerminal is used just to
18156 catch the case where the simplename lookup failed.
18158 2003-04-16 Miguel de Icaza <miguel@ximian.com>
18160 * expression.cs (ResolveMemberAccess): Remove redundant code.
18161 TypeExpr expressions are always born fully resolved.
18163 * interface.cs (PopulateMethod): Do not lookup the types twice.
18164 We were doing it once during SemanticAnalysis and once during
18167 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
18168 in local variable type definitions, were being returned as a
18169 SimpleName (we decomposed everything into a string), that is
18170 because primary_expression was being used instead of a type in the
18171 grammar (reduce/reduce conflicts).
18173 The part that was wrong is that we converted the expression into a
18174 string (an oversimplification in one hand, compounded with primary
18175 expressions doing string concatenation).
18181 Would return "A.B.C[]" as a SimpleName. This stopped things like
18182 using clauses from working on this particular context. And a type
18183 was being matched directly against "A.B.C[]".
18185 We now use the correct approach, and allow for ComposedCast to be
18186 part of the unary expression. So the "A.B.C []" become a composed
18187 cast of "A.B.C" (as a nested group of MemberAccess with a
18188 SimpleName at the end) plus the rank composition "[]".
18192 2003-04-10 Miguel de Icaza <miguel@ximian.com>
18194 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
18195 for the access level checking.
18197 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
18198 `TypeContainer container', because I kept getting confused when I
18199 was debugging this code.
18201 * expression.cs (Indexers): Instead of tracking getters/setters,
18202 we now track them in parallel. We create one arraylist less, but
18203 most importantly it is possible now for the LValue code to find a
18204 matching get for a set.
18206 (IndexerAccess.DoResolveLValue): Update the code.
18207 GetIndexersForType has been modified already to extract all the
18208 indexers from a type. The code assumed it did not.
18210 Also make the code set the correct return type for the indexer.
18211 This was fixed a long time ago for properties, but was missing for
18212 indexers. It used to be void_type.
18214 (Binary.Emit): Test first for doubles instead of
18215 floats, as they are more common.
18217 (Binary.EmitBranchable): Use the .un version of the branch opcodes
18218 when dealing with floats and the <=, >= operators. This fixes bug
18221 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
18222 to load the array value by emitting a load on the foreach variable
18223 type. This was incorrect.
18225 We now emit the code to load an element using the the array
18226 variable type, and then we emit the conversion operator.
18230 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
18232 * attribute.cs: Avoid allocation of ArrayLists in the common case.
18234 2003-04-09 Miguel de Icaza <miguel@ximian.com>
18236 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
18237 test for protection before we test for signatures.
18239 (MethodSignature.ToString): implement.
18241 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
18242 to the case where we reduced into a LongConstant.
18244 * decl.cs (CheckAccessLevel): If the type is an array, we can not
18245 depend on whether the information is acurrate, because the
18246 Microsoft runtime will always claim that the array type is public,
18247 regardless of the real state.
18249 If the type is a pointer, another problem happens: the type is
18250 reported as non-public in Microsoft.
18252 In both cases we have to call CheckAccessLevel recursively with
18253 the underlying type as the argument to be tested.
18255 2003-04-08 Miguel de Icaza <miguel@ximian.com>
18257 * assign.cs (Assign.Emit): If we are dealing with a compound
18258 assignment expression, we should use the code path that stores the
18259 intermediate result in a temporary value. This fixes #40903.
18261 *expression.cs (Indirection.ToString): Provide ToString method for
18264 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
18266 * class.cs: Null out fields holding references to Block objects so
18267 they can be garbage collected.
18269 * expression.cs (OverloadResolve): Remove unused local.
18271 2003-04-07 Martin Baulig <martin@ximian.com>
18273 * codegen.cs (EmitContext.CurrentFile): New public field.
18274 (EmitContext.Mark): Use the CurrentFile to check whether the
18275 location is in the correct file.
18276 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
18278 2003-04-07 Martin Baulig <martin@ximian.com>
18280 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
18282 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
18283 location. [FIXME: The location argument which gets passed to this
18284 method is sometimes wrong!]
18286 2003-04-07 Nick Drochak <ndrochak@gol.com>
18288 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
18290 2003-04-07 Miguel de Icaza <miguel@ximian.com>
18292 * expression.cs (Indirection.EmitAssign): We were using the
18293 temporary, but returning immediately instead of continuing the
18296 2003-04-06 Martin Baulig <martin@ximian.com>
18298 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
18299 if it's a nested child, but also deriving from the outer class.
18302 * typemanager.cs (IsNestedChildOf): Make this work if it's a
18303 nested child, but also deriving from the outer class. See
18305 (FilterWithClosure): We may access private members of the outer
18306 class if we're a nested child and deriving from the outer class.
18307 (RealMemberLookup): Only set `closure_private_ok' if the
18308 `original_bf' contained BindingFlags.NonPublic.
18310 2003-04-05 Martin Baulig <martin@ximian.com>
18312 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
18314 2003-04-02 Miguel de Icaza <miguel@ximian.com>
18316 * class.cs (Event.Define): Do not allow abstract events to have
18319 2003-04-01 Miguel de Icaza <miguel@ximian.com>
18321 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
18322 block in event declarations.
18324 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
18325 value type, get its address.
18327 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
18328 leaving a class on the stack instead of a boolean value (int
18329 0/1). Change the code so we compare against null, and then the
18330 result against zero.
18332 * class.cs (TypeContainer.GetClassBases): We were checking for the
18333 parent class being sealed too late.
18335 * expression.cs (Binary.Emit): For <= and >= when dealing with
18336 floating point values, use cgt.un and clt.un instead of cgt and
18339 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
18341 * statement.cs: Apply the same optimization as MS: skip the
18342 GetEnumerator returning an IEnumerator, and use the one returning a
18343 CharEnumerator instead. This allows us to avoid the try-finally block
18346 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
18348 * cs-parser.jay: Attributes cannot be applied to
18349 namespaces. Fixes #40473
18351 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18354 (Add*): check if the name is valid using the full name for constants,
18355 fields, properties and events.
18357 2003-03-28 Miguel de Icaza <miguel@ximian.com>
18359 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
18360 char constants to be part of the enumeration.
18362 * expression.cs (Conditional.DoResolve): Add support for operator
18363 true. Implements the missing functionality from 14.12
18365 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
18366 operator true/false as required by the spec.
18368 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
18369 implicit conversion to boolean.
18371 * statement.cs (Statement.ResolveBoolean): A boolean expression is
18372 also one where the type implements `operator true'.
18374 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
18375 get an expression that will invoke operator true based on an
18378 (GetConversionOperators): Removed the hack that called op_True
18381 (Expression.ResolveBoolean): Move this from Statement.
18383 2003-03-17 Miguel de Icaza <miguel@ximian.com>
18385 * ecore.cs (FieldExpr): do not allow initialization of initonly
18386 fields on derived classes
18388 2003-03-13 Martin Baulig <martin@ximian.com>
18390 * statement.cs (Block.Emit): Call ig.BeginScope() and
18391 ig.EndScope() when compiling with debugging info; call
18392 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
18394 2003-03-08 Miguel de Icaza <miguel@ximian.com>
18396 * expression.cs (Indexers): Do not construct immediately, allow
18397 for new members to be appended as we go. Fixes 38143
18399 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18401 * expression.cs: save/restore context when resolving an unchecked
18404 2003-03-05 Miguel de Icaza <miguel@ximian.com>
18406 * cfold.cs: Catch division by zero in modulus operator during
18409 2003-03-03 Miguel de Icaza <miguel@ximian.com>
18411 * interface.cs (Interface.DefineMembers): Avoid defining members
18414 2003-02-27 Miguel de Icaza <miguel@ximian.com>
18416 * driver.cs: handle the +/- options for -noconfig
18418 * statement.cs (Unckeched.Resolve): Also track the state of
18419 unchecked in the Resolve phase.
18421 2003-02-27 Martin Baulig <martin@ximian.com>
18423 * ecore.cs (Expression.MemberLookup): Don't create a
18424 MethodGroupExpr for something which is not a method. Fixes #38291.
18426 2003-02-25 Miguel de Icaza <miguel@ximian.com>
18428 * class.cs (MemberBase.CheckParameters): Also check that the type
18429 is unmanaged if it is a pointer.
18431 * expression.cs (SizeOf.Resolve): Add location information.
18433 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
18434 a managed type is declared.
18436 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
18437 parameter modifiers as well. Fixes bug 38606
18439 * class.cs: Very sad. Am backing out the speed up changes
18440 introduced by the ArrayList -> Array in the TypeContainer, as they
18441 were not actually that much faster, and introduced a bug (no error
18442 reports on duplicated methods).
18444 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
18445 source first, this will guarantee that we have a valid expression
18446 before calling in lower levels functions that will require a
18447 resolved object. Then use this original_source in the
18448 target.ResolveLValue instead of the original source that was
18451 Another change. Use target.Resolve instead of LValueResolve.
18452 Although we are resolving for LValues, we will let the Assign code
18453 take care of that (it will be called again from Resolve). This
18454 basically allows code like this:
18456 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
18457 class Y { void A (X x) { x [0] += o; }
18459 The problem was that the indexer was trying to resolve for
18460 set_Item (idx, object o) and never finding one. The real set_Item
18461 was set_Item (idx, X). By delaying the process we get the right
18466 2003-02-23 Martin Baulig <martin@ximian.com>
18468 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
18469 while calling DoEmit ().
18471 * codegen.cs (EmitContext.Mark): Don't mark locations in other
18472 source files; if you use the #line directive inside a method, the
18473 compiler stops emitting line numbers for the debugger until it
18474 reaches the end of the method or another #line directive which
18475 restores the original file.
18477 2003-02-23 Martin Baulig <martin@ximian.com>
18479 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
18481 2003-02-23 Martin Baulig <martin@ximian.com>
18483 * statement.cs (Block.AddChildVariableNames): We need to call this
18484 recursively, not just for our immediate children.
18486 2003-02-23 Martin Baulig <martin@ximian.com>
18488 * class.cs (Event.Define): Always make the field private, like csc does.
18490 * typemanager.cs (TypeManager.RealMemberLookup): Make events
18491 actually work, fixes bug #37521.
18493 2003-02-23 Miguel de Icaza <miguel@ximian.com>
18495 * delegate.cs: When creating the various temporary "Parameters"
18496 classes, make sure that we call the ComputeAndDefineParameterTypes
18497 on those new parameters (just like we do with the formal ones), to
18498 allow them to be resolved in the context of the DeclSpace.
18500 This fixes the bug that Dick observed in Bugzilla #38530.
18502 2003-02-22 Miguel de Icaza <miguel@ximian.com>
18504 * expression.cs (ResolveMemberAccess): When resolving a constant,
18505 do not attempt to pull a constant if the value was not able to
18506 generate a valid constant.
18508 * const.cs (LookupConstantValue): Do not report more errors than required.
18510 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18512 * expression.cs: fixes bug #38328.
18514 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18516 * class.cs: Changed all the various members that can be part of a
18517 class from being an ArrayList to be an Array of the right type.
18518 During the DefineType type_list, interface_list, delegate_list and
18519 enum_list are turned into types, interfaces, delegates and enums
18522 And during the member population, indexer_list, event_list,
18523 constant_list, field_list, instance_constructor_list, method_list,
18524 operator_list and property_list are turned into their real arrays.
18526 Although we could probably perform this operation earlier, for
18527 good error reporting we need to keep the lists and remove the
18528 lists for longer than required.
18530 This optimization was triggered by Paolo profiling the compiler
18531 speed on the output of `gen-sample-program.pl' perl script.
18533 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
18534 not crash in methods like MemberLookupFailed that use this field.
18536 This problem arises when the compiler fails to resolve a type
18537 during interface type definition for example.
18539 2003-02-18 Miguel de Icaza <miguel@ximian.com>
18541 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
18542 inherit from System.Object, so we have to stop at null, not only
18543 when reaching System.Object.
18545 2003-02-17 Miguel de Icaza <miguel@ximian.com>
18547 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
18548 DeclaredOnly because the parent indexer might have had a different
18549 name, but did not loop until the top of the hierarchy was reached.
18551 The problem this one fixes is 35492: when a class implemented an
18552 indexer from an interface, we were getting the interface method
18553 (which was abstract) and we were flagging an error (can not invoke
18556 This also keeps bug 33089 functioning, and test-148 functioning.
18558 * typemanager.cs (IsSpecialMethod): The correct way of figuring
18559 out if a method is special is to see if it is declared in a
18560 property or event, or whether it is one of the predefined operator
18561 names. This should fix correctly #36804.
18563 2003-02-15 Miguel de Icaza <miguel@ximian.com>
18565 The goal here is to remove the dependency on EmptyCast.Peel ().
18566 Killing it completely.
18568 The problem is that currently in a number of places where
18569 constants are expected, we have to "probe" for an EmptyCast, and
18570 Peel, which is not the correct thing to do, as this will be
18571 repetitive and will likely lead to errors.
18573 The idea is to remove any EmptyCasts that are used in casts that
18574 can be reduced to constants, so we only have to cope with
18577 This bug hunt was triggered by Bug 37363 and the desire to remove
18578 the duplicate pattern where we were "peeling" emptycasts to check
18579 whether they were constants. Now constants will always be
18582 * ecore.cs: Use an enumconstant here instead of wrapping with
18585 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
18586 throwing me off. By handling this we can get rid of a few hacks.
18588 * statement.cs (Switch): Removed Peel() code.
18590 2003-02-14 Miguel de Icaza <miguel@ximian.com>
18592 * class.cs: Location information for error 508
18594 * expression.cs (New.DoResolve): Add a guard against double
18595 resolution of an expression.
18597 The New DoResolve might be called twice when initializing field
18598 expressions (see EmitFieldInitializers, the call to
18599 GetInitializerExpression will perform a resolve on the expression,
18600 and later the assign will trigger another resolution
18602 This leads to bugs (#37014)
18604 * delegate.cs: The signature for EndInvoke should contain any ref
18605 or out parameters as well. We were not doing this in the past.
18607 * class.cs (Field.Define): Do not overwrite the type definition
18608 inside the `volatile' group. Turns out that volatile enumerations
18609 were changing the type here to perform a validity test, which
18612 2003-02-12 Miguel de Icaza <miguel@ximian.com>
18614 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
18615 and structs, we do not want to load the instance variable
18617 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
18618 enum_type has to be handled like an object reference (implicit
18619 conversions exists from this to object), but the regular IsClass
18620 and IsValueType tests will never return true for this one.
18622 Also we use TypeManager.IsValueType instead of type.IsValueType,
18623 just for consistency with the rest of the code (this is only
18624 needed if we ever use the construct exposed by test-180.cs inside
18625 corlib, which we dont today).
18627 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
18629 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
18632 2003-02-09 Martin Baulig <martin@ximian.com>
18634 * namespace.cs (Namespace..ctor): Added SourceFile argument.
18635 (Namespace.DefineNamespaces): New static public method; this is
18636 called when we're compiling with debugging to add all namespaces
18637 to the symbol file.
18639 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
18640 pass it to the Namespace's .ctor.
18642 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
18643 and MethodBase arguments; pass the namespace ID to the symwriter;
18644 pass the MethodBase instead of the token to the symwriter.
18645 (SymbolWriter.DefineNamespace): New method to add a namespace to
18648 2003-02-09 Martin Baulig <martin@ximian.com>
18650 * symbolwriter.cs: New file. This is a wrapper around
18651 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
18652 methods here in near future.
18654 2003-02-09 Martin Baulig <martin@ximian.com>
18656 * codegen.cs (EmitContext.Mark): Just pass the arguments to
18657 ILGenerator.MarkSequencePoint() which are actually used by the
18660 2003-02-09 Martin Baulig <martin@ximian.com>
18662 * location.cs (SourceFile): New public sealed class. This
18663 contains the name and an index which is used in the location's token.
18664 (Location): Reserve an appropriate number of bits in the token for
18665 the source file instead of walking over that list, this gives us a
18666 really huge performance improvement when compiling with debugging.
18668 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
18669 `SourceFile' argument instead of a string.
18670 (Driver.ProcessFile): Add all the files via Location.AddFile(),
18671 but don't parse/tokenize here, we need to generate the list of all
18672 source files before we do that.
18673 (Driver.ProcessFiles): New static function. Parses/tokenizes all
18676 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
18677 instead of a string.
18679 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
18682 2003-02-09 Martin Baulig <martin@ximian.com>
18684 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
18685 filename on `#line default'.
18687 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
18689 * statement.cs: don't clear the pinned var when the fixed statement
18690 returns from the method (fixes bug#37752).
18692 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
18694 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
18697 2003-02-07 Martin Baulig <martin@ximian.com>
18699 * driver.cs: Removed the `--debug-args' command line argument.
18701 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
18702 automatically by the AsssemblyBuilder.
18703 (CodeGen.InitializeSymbolWriter): We don't need to call any
18704 initialization function on the symbol writer anymore. This method
18705 doesn't take any arguments.
18707 2003-02-03 Miguel de Icaza <miguel@ximian.com>
18709 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
18710 from referenced assemblies as well.
18712 2003-02-02 Martin Baulig <martin@ximian.com>
18714 * class.cs (MethodData.Emit): Generate debugging info for external methods.
18716 2003-02-02 Martin Baulig <martin@ximian.com>
18718 * class.cs (Constructor.Emit): Open the symbol writer before
18719 emitting the constructor initializer.
18720 (ConstructorInitializer.Emit): Call ec.Mark() to allow
18721 single-stepping through constructor initializers.
18723 2003-01-30 Miguel de Icaza <miguel@ximian.com>
18725 * class.cs: Handle error 549: do not allow virtual methods in
18728 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
18730 * decl.cs: Check access levels when resolving types
18732 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
18734 * statement.cs: Add parameters and locals set in catch blocks that might
18735 return to set vector
18737 2003-01-29 Miguel de Icaza <miguel@ximian.com>
18739 * class.cs (Operator): Set the SpecialName flags for operators.
18741 * expression.cs (Invocation.DoResolve): Only block calls to
18742 accessors and operators on SpecialName methods.
18744 (Cast.TryReduce): Handle conversions from char constants.
18747 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
18749 * statement.cs: small memory and time optimization in FlowBranching.
18751 2003-01-28 Pedro Mart <yoros@wanadoo.es>
18753 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
18754 problem that the last fix but in the other sid (Set).
18756 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
18757 access when there is no indexer in the hierarchy.
18759 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
18761 * class.cs: Combine some if statements.
18763 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18765 * driver.cs: fixed bug #37187.
18767 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
18769 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
18770 any indexer, it's needed to build a list with all the indexers in the
18771 hierarchy (AllGetters), else we have problems. Fixes #35653.
18773 2003-01-23 Miguel de Icaza <miguel@ximian.com>
18775 * class.cs (MethodData.Define): It is wrong for an interface
18776 implementation to be static in both cases: explicit and implicit.
18777 We were only handling this in one case.
18779 Improve the if situation there to not have negations.
18781 * class.cs (Field.Define): Turns out that we do not need to check
18782 the unsafe bit on field definition, only on usage. Remove the test.
18784 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18786 * driver.cs: use assembly.Location instead of Codebase (the latest
18787 patch made mcs fail when using MS assemblies).
18789 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
18791 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
18792 get the path to *corlib.dll.
18794 2003-01-21 Nick Drochak <ndrochak@gol.com>
18798 * typemanager.cs: Remove compiler warnings
18800 2003-01-20 Duncan Mak <duncan@ximian.com>
18802 * AssemblyInfo.cs: Bump the version number to 0.19.
18804 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18806 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
18808 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
18810 * class.cs (Constructor::Emit): Emit debugging info for constructors.
18812 2003-01-17 Miguel de Icaza <miguel@ximian.com>
18814 * cs-parser.jay: Small fix: we were not comparing the constructor
18815 name correctly. Thanks to Zoltan for the initial pointer.
18817 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
18819 * cs-tokenizer.cs: Set file name when specified with #line
18821 2003-01-15 Miguel de Icaza <miguel@ximian.com>
18823 * cs-parser.jay: Only perform the constructor checks here if we
18824 are named like the class; This will help provider a better
18825 error. The constructor path is taken when a type definition is
18826 not found, but most likely the user forgot to add the type, so
18827 report that rather than the constructor error.
18829 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
18831 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
18834 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18836 * cs-parser.jay: Add cleanup call.
18838 2003-01-13 Duncan Mak <duncan@ximian.com>
18840 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
18841 consistent with other methods.
18843 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
18845 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
18847 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
18849 * attribute.cs: only set GuidAttr to true when we have a
18852 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18856 * typemanager.cs: fixes to allow mcs compile corlib with the new
18857 Type.IsSubclassOf fix.
18859 2003-01-08 Miguel de Icaza <miguel@ximian.com>
18861 * expression.cs (LocalVariableReference.DoResolve): Classify a
18862 constant as a value, not as a variable. Also, set the type for
18865 * cs-parser.jay (fixed_statement): take a type instead of a
18866 pointer_type, so we can produce a better error message later.
18868 * statement.cs (Fixed.Resolve): Flag types that are not pointers
18871 (For.DoEmit): Make inifinite loops have a
18872 non-conditional branch back.
18874 (Fixed.DoEmit): First populate the pinned variables, then emit the
18875 statement, then clear the variables. Before I was emitting the
18876 code once for each fixed piece.
18879 2003-01-08 Martin Baulig <martin@ximian.com>
18881 * statement.cs (FlowBranching.MergeChild): A break in a
18882 SWITCH_SECTION does not leave a loop. Fixes #36155.
18884 2003-01-08 Martin Baulig <martin@ximian.com>
18886 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
18887 lives in the same number space than `param_map'. Fixes #36154.
18889 2003-01-07 Miguel de Icaza <miguel@ximian.com>
18891 * cs-parser.jay (constructor_declaration): Set the
18892 Constructor.ModFlags before probing for it. This makes the
18893 compiler report 514, 515 and 132 (the code was there, but got
18896 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
18897 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
18898 (GotoCase.Resolve): Set `Returns' to ALWAYS.
18900 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
18902 * enum.cs: create the enum static fields using the enum type.
18904 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
18906 * class.cs: don't try to create the ParamBuilder for the return
18907 type if it's not needed (and handle it breaking for the ms runtime
18910 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
18912 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
18914 2002-12-29 Miguel de Icaza <miguel@ximian.com>
18916 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
18917 the command. This showed up while compiling the JANET source
18918 code, which used \r as its only newline separator.
18920 2002-12-28 Miguel de Icaza <miguel@ximian.com>
18922 * class.cs (Method.Define): If we are an operator (because it
18923 reuses our code), then set the SpecialName and HideBySig. #36128
18925 2002-12-22 Miguel de Icaza <miguel@ximian.com>
18927 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
18928 exception, report error 120 `object reference required'.
18930 * driver.cs: Add --pause option, used during to measure the size
18931 of the process as it goes with --timestamp.
18933 * expression.cs (Invocation.DoResolve): Do not allow methods with
18934 SpecialName to be invoked.
18936 2002-12-21 Miguel de Icaza <miguel@ximian.com>
18938 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
18939 number before adding it.
18941 2002-12-21 Ravi Pratap <ravi@ximian.com>
18943 * ecore.cs (StandardImplicitConversion): When in an unsafe
18944 context, we allow conversion between void * to any other pointer
18945 type. This fixes bug #35973.
18947 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
18949 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
18950 is not thrown when extensionless outputs are used
18952 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18954 * rootcontext.cs: fixed compilation of corlib.
18956 2002-12-19 Miguel de Icaza <miguel@ximian.com>
18958 * attribute.cs (Attributes.Contains): Add new method.
18960 * class.cs (MethodCore.LabelParameters): if the parameter is an
18961 `out' parameter, check that no attribute `[In]' has been passed.
18963 * enum.cs: Handle the `value__' name in an enumeration.
18965 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
18967 * decl.cs: Added special case to allow overrides on "protected
18970 2002-12-18 Ravi Pratap <ravi@ximian.com>
18972 * attribute.cs (Attributes.AddAttributeSection): Rename to this
18973 since it makes much more sense.
18975 (Attributes.ctor): Don't require a Location parameter.
18977 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
18979 * attribute.cs (ApplyAttributes): Remove extra Location parameters
18980 since we already have that information per attribute.
18982 * everywhere : make appropriate changes.
18984 * class.cs (LabelParameters): Write the code which actually
18985 applies attributes to the return type. We can't do this on the MS
18986 .NET runtime so we flag a warning in the case an exception is
18989 2002-12-18 Miguel de Icaza <miguel@ximian.com>
18991 * const.cs: Handle implicit null conversions here too.
18993 2002-12-17 Ravi Pratap <ravi@ximian.com>
18995 * class.cs (MethodCore.LabelParameters): Remove the extra
18996 Type [] parameter since it is completely unnecessary. Instead
18997 pass in the method's attributes so that we can extract
18998 the "return" attribute.
19000 2002-12-17 Miguel de Icaza <miguel@ximian.com>
19002 * cs-parser.jay (parse): Use Report.Error to flag errors instead
19003 of ignoring it and letting the compile continue.
19005 * typemanager.cs (ChangeType): use an extra argument to return an
19006 error condition instead of throwing an exception.
19008 2002-12-15 Miguel de Icaza <miguel@ximian.com>
19010 * expression.cs (Unary.TryReduce): mimic the code for the regular
19011 code path. Perform an implicit cast in the cases where we can
19012 implicitly convert to one of the integral types, and then reduce
19013 based on that constant. This fixes bug #35483.
19015 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19017 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
19019 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19021 * namespace.cs: fixed bug #35489.
19023 2002-12-12 Miguel de Icaza <miguel@ximian.com>
19025 * class.cs: Remove some dead code.
19027 * cs-parser.jay: Estimate the number of methods needed
19028 (RootContext.MethodCount);
19030 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
19031 numbers instead of StringBuilders.
19033 * support.cs (PtrHashtable): Add constructor with initial size;
19034 We can now reduce reallocations of the method table.
19036 2002-12-10 Ravi Pratap <ravi@ximian.com>
19038 * attribute.cs (ApplyAttributes): Keep track of the emitted
19039 attributes on a per-target basis. This fixes bug #35413.
19041 2002-12-10 Miguel de Icaza <miguel@ximian.com>
19043 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
19044 default to the Windows 1252 encoding.
19046 (UnixParseOption): Support version, thanks to Alp for the missing
19049 * AssemblyInfo.cs: Add nice assembly information.
19051 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
19054 * cs-parser.jay: Allow a trailing comma before the close bracked
19055 in the attribute_section production.
19057 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
19058 address of the instance was being taken, I will take this out,
19059 because we take the address of the object immediately here.
19061 2002-12-09 Ravi Pratap <ravi@ximian.com>
19063 * typemanager.cs (AreMultipleAllowed): Take care of the most
19064 obvious case where attribute type is not in the current assembly -
19067 2002-12-08 Miguel de Icaza <miguel@ximian.com>
19069 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
19070 definitions, instead of doing that afterwards.
19072 Also we use a nice little hack, depending on the constructor, we
19073 know if we are a "composed" name or a simple name. Hence, we
19074 avoid the IndexOf test, and we avoid
19076 * codegen.cs: Add code to assist in a bug reporter to track down
19077 the source of a compiler crash.
19079 2002-12-07 Ravi Pratap <ravi@ximian.com>
19081 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
19082 types have been emitted for a given element and flag an error
19083 if something which does not have AllowMultiple set is used more
19086 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
19087 attribute types and their corresponding AllowMultiple properties
19089 (AreMultipleAllowed): Check the property for a given type.
19091 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
19092 property in the case we have a TypeContainer.
19094 (Attributes.AddAttribute): Detect duplicates and just skip on
19095 adding them. This trivial fix catches a pretty gross error in our
19096 attribute emission - global attributes were being emitted twice!
19098 Bugzilla bug #33187 is now fixed.
19100 2002-12-06 Miguel de Icaza <miguel@ximian.com>
19102 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
19103 instead of pp_and).
19105 * expression.cs (Binary.ResolveOperator): I can only use the
19106 Concat (string, string, string) and Concat (string, string,
19107 string, string) if the child is actually a concatenation of
19110 2002-12-04 Miguel de Icaza <miguel@ximian.com>
19112 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
19113 context where we need a 2-character lookahead.
19115 * pending.cs (PendingImplementation): Rework so we can keep track
19116 of interface types all the time, and flag those which were
19117 implemented by parents as optional.
19119 2002-12-03 Miguel de Icaza <miguel@ximian.com>
19121 * expression.cs (Binary.ResolveOperator): Use
19122 String.Concat(string,string,string) or
19123 String.Concat(string,string,string,string) when possible.
19125 * typemanager: More helper methods.
19128 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
19130 * pending.cs: remove the bogus return from GetMissingInterfaces()
19131 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
19133 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19135 * namespace.cs: avoid duplicated 'using xxx' being added to
19136 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
19137 when we get more than one 'using' statement for the same namespace.
19138 Report a CS0105 warning for it.
19140 2002-11-30 Miguel de Icaza <miguel@ximian.com>
19142 * cs-tokenizer.cs (consume_identifier): use read directly, instead
19143 of calling getChar/putback, uses internal knowledge of it.
19145 (xtoken): Reorder tokenizer so most common patterns are checked
19146 first. This reduces the compilation time in another 5% (from 8.11s
19147 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
19149 The parsing time is 22% of the compilation in mcs, and from that
19150 64% is spent on the tokenization process.
19152 I tried using a binary search for keywords, but this is slower
19153 than the hashtable. Another option would be to do a couple of
19156 * Not use a StringBuilder, instead use an array of chars,
19157 with a set value. Notice that this way we could catch
19158 the 645 error without having to do it *afterwards*.
19160 * We could write a hand-parser to avoid the hashtable
19161 compares altogether.
19163 The identifier consumption process takes 37% of the tokenization
19164 time. Another 15% is spent on is_number. 56% of the time spent
19165 on is_number is spent on Int64.Parse:
19167 * We could probably choose based on the string length to
19168 use Int32.Parse or Int64.Parse and avoid all the 64-bit
19171 Another 3% is spend on wrapping `xtoken' in the `token' function.
19173 Handle 0xa0 as whitespace (#34752)
19175 2002-11-26 Miguel de Icaza <miguel@ximian.com>
19177 * typemanager.cs (IsCLRType): New routine to tell whether a type
19178 is one of the builtin types.
19180 Maybe it needs to use TypeCodes to be faster. Maybe we could use
19181 typecode in more places instead of doing pointer comparissions.
19182 We could leverage some knowledge about the way the typecodes are
19185 New code to cache namespaces in assemblies, it is currently not
19186 invoked, to be used soon.
19188 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
19190 * expression.cs (Binary.ResolveOperator): specially handle
19191 strings, and do not perform user-defined operator overloading for
19194 2002-11-24 Miguel de Icaza <miguel@ximian.com>
19196 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
19197 internalcall as it is a pretty simple operation; Avoid whenever
19198 possible to call Char.IsLetter.
19200 (consume_identifier): Cut by half the number of
19201 hashtable calls by merging the is_keyword and GetKeyword behavior.
19203 Do not short-circuit, because if we do, we
19204 report errors (ie, #if false && true would produce an invalid
19208 2002-11-24 Martin Baulig <martin@ximian.com>
19210 * expression.cs (Cast.TryReduce): If we're in checked syntax,
19211 check constant ranges and report a CS0221. Fixes #33186.
19213 2002-11-24 Martin Baulig <martin@ximian.com>
19215 * cs-parser.jay: Make this work for uninitialized variable
19216 declarations in the `for' initializer. Fixes #32416.
19218 2002-11-24 Martin Baulig <martin@ximian.com>
19220 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
19221 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
19223 2002-11-24 Martin Baulig <martin@ximian.com>
19225 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
19226 argument; if true, we also check for user-defined conversions.
19227 This is only needed if both arguments are of a user-defined type.
19228 Fixes #30443, added test-175.cs.
19229 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
19231 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
19233 2002-11-24 Martin Baulig <martin@ximian.com>
19235 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
19236 function to get the store opcode.
19237 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
19238 only emit the Ldelema if the store opcode is Stobj. You must run
19239 both test-34 and test-167 to test this. Fixes #34529.
19241 2002-11-23 Martin Baulig <martin@ximian.com>
19243 * ecore.cs (Expression.MemberLookup): Added additional
19244 `qualifier_type' argument which is used when we're being called
19245 from MemberAccess.DoResolve() and null if we're called from a
19247 (Expression.MemberLookupFailed): New method to report errors; this
19248 does the CS1540 check and reports the correct error message.
19250 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
19251 argument for the CS1540 check and redone the way how we're dealing
19252 with private members. See the comment in the source code for details.
19253 (FilterWithClosure): Reverted this back to revision 1.197; renamed
19254 `closure_start_type' to `closure_qualifier_type' and check whether
19255 it's not null. It was not this filter being broken, it was just
19256 being called with the wrong arguments.
19258 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
19259 and pass it the correct `qualifier_type'; this also does the error
19262 2002-11-22 Miguel de Icaza <miguel@ximian.com>
19264 * expression.cs (Invocation.EmitParams): If the we are dealing
19265 with a non-built-in value type, load its address as well.
19267 (ArrayCreation): Use a a pretty constant instead
19268 of the hardcoded value 2. Use 6 instead of 2 for the number of
19269 static initializers.
19271 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
19272 because they are not really value types, just glorified integers.
19274 * driver.cs: Do not append .exe, the CSC compiler does not do it.
19276 * ecore.cs: Remove redundant code for enumerations, make them use
19277 the same code path as everything else, fixes the casting issue
19278 with enumerations in Windows.Forms.
19280 * attribute.cs: Do only cast to string if it is a string, the
19281 validation happens later.
19283 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
19284 people upgrade their corlibs.
19286 * ecore.cs: Oops, enumerations were not following the entire code path
19288 2002-11-21 Miguel de Icaza <miguel@ximian.com>
19290 * typemanager.cs (FilterWithClosure): Commented out the test for
19291 1540 in typemanager.cs, as it has problems when accessing
19292 protected methods from a parent class (see test-174.cs).
19294 * attribute.cs (Attribute.ValidateGuid): new method.
19295 (Attribute.Resolve): Use above.
19297 2002-11-19 Miguel de Icaza <miguel@ximian.com>
19299 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
19301 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
19302 handling for enumerations, as we only needed the TypeContainer
19303 functionality to begin with (this is required for the fix below to
19304 work for enums that reference constants in a container class for
19307 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
19309 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
19310 a valid TypeBuilder to perform lookups on.o
19312 * class.cs (InheritableMemberSignatureCompare): Use true in the
19313 call to GetGetMethod and GetSetMethod, because we are comparing
19314 the signature, and we need to get the methods *even* if they are
19317 (PropertyBase.CheckBase): ditto.
19319 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
19320 GotoCase.Resolve): Use Peel on EmpytCasts.
19322 * ecore.cs (EmptyCast): drop child, add Peel method.
19324 2002-11-17 Martin Baulig <martin@ximian.com>
19326 * ecore.cs (EmptyCast.Child): New public property.
19328 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
19329 label resolved to an EmptyCast. Fixes #34162.
19330 (GotoCase.Resolve): Likewise.
19331 (Block.EmitMeta): Likewise.
19333 2002-11-17 Martin Baulig <martin@ximian.com>
19335 * expression.cs (Invocation.BetterConversion): Prefer int over
19336 uint; short over ushort; long over ulong for integer literals.
19337 Use ImplicitConversionExists instead of StandardConversionExists
19338 since we also need to check for user-defined implicit conversions.
19339 Fixes #34165. Added test-173.cs.
19341 2002-11-16 Martin Baulig <martin@ximian.com>
19343 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
19344 with the `true' and `false' literals. Fixes #33151.
19346 2002-11-16 Martin Baulig <martin@ximian.com>
19348 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
19349 October 22nd; don't do the cs1540 check for static members.
19351 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
19352 now using our own filter here and doing the cs1540 check again.
19354 2002-11-16 Martin Baulig <martin@ximian.com>
19356 * support.cs (InternalParameters): Don't crash if we don't have
19357 any fixed parameters. Fixes #33532.
19359 2002-11-16 Martin Baulig <martin@ximian.com>
19361 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
19362 when looking up static methods to make this work on Windows.
19365 2002-11-16 Martin Baulig <martin@ximian.com>
19367 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
19368 a setter rather than using PropertyInfo.CanWrite.
19370 2002-11-15 Nick Drochak <ndrochak@gol.com>
19372 * class.cs: Allow acces to block member by subclasses. Fixes build
19375 2002-11-14 Martin Baulig <martin@ximian.com>
19377 * class.cs (Constructor.Emit): Added the extern/block check.
19380 2002-11-14 Martin Baulig <martin@ximian.com>
19382 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
19383 iteration while looking for indexers, this is needed because the
19384 indexer may have a different name in our base classes. Fixed the
19385 error reporting (no indexers at all, not get accessor, no
19386 overloaded match). Fixes bug #33089.
19387 (IndexerAccess.DoResolveLValue): Likewise.
19389 2002-11-14 Martin Baulig <martin@ximian.com>
19391 * class.cs (PropertyBase.CheckBase): Make this work for multiple
19392 indexers. Fixes the first part of bug #33089.
19393 (MethodSignature.InheritableMemberSignatureCompare): Added support
19396 2002-11-13 Ravi Pratap <ravi@ximian.com>
19398 * attribute.cs (Attribute.Resolve): Catch the
19399 NullReferenceException and report it since it isn't supposed to
19402 2002-11-12 Miguel de Icaza <miguel@ximian.com>
19404 * expression.cs (Binary.EmitBranchable): Also handle the cases for
19405 LogicalOr and LogicalAnd that can benefit from recursively
19406 handling EmitBranchable. The code now should be nice for Paolo.
19408 2002-11-08 Miguel de Icaza <miguel@ximian.com>
19410 * typemanager.cs (LookupType): Added a negative-hit hashtable for
19411 the Type lookups, as we perform quite a number of lookups on
19412 non-Types. This can be removed once we can deterministically tell
19413 whether we have a type or a namespace in advance.
19415 But this might require special hacks from our corlib.
19419 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
19420 and double which avoids a conversion from an integer to a double.
19422 * expression.cs: tiny optimization, avoid calling IsConstant,
19423 because it effectively performs the lookup twice.
19425 2002-11-06 Miguel de Icaza <miguel@ximian.com>
19427 But a bogus return here to keep the semantics of the old code
19428 until the Mono runtime is fixed.
19430 * pending.cs (GetMissingInterfaces): New method used to remove all
19431 the interfaces that are already implemented by our parent
19432 classes from the list of pending methods.
19434 * interface.cs: Add checks for calls after ResolveTypeExpr.
19436 2002-11-05 Miguel de Icaza <miguel@ximian.com>
19438 * class.cs (Class.Emit): Report warning 67: event not used if the
19439 warning level is beyond 3.
19441 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
19442 being a NullLiteral.
19444 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
19447 * class.cs (TypeContainer.GetClassBases): Cover a missing code
19448 path that might fail if a type can not be resolved.
19450 * expression.cs (Binary.Emit): Emit unsigned versions of the
19453 * driver.cs: use error 5.
19455 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
19457 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
19459 2002-11-01 Miguel de Icaza <miguel@ximian.com>
19461 * cs-parser.jay (switch_section): A beautiful patch from Martin
19462 Baulig that fixed 33094.
19464 2002-10-31 Miguel de Icaza <miguel@ximian.com>
19466 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
19467 Check whether the base is abstract and report an error if so.
19469 * expression.cs (IndexerAccess.DoResolveLValue,
19470 IndexerAccess.DoResolve): ditto.
19472 (Invocation.DoResolve): ditto.
19474 (Invocation.FullMethodDesc): Improve the report string.
19476 * statement.cs (Block): Eliminate IsVariableDefined as it is
19477 basically just a wrapper for GetVariableInfo.
19479 * ecore.cs (SimpleName): Use new
19481 * support.cs (ReflectionParamter.ParameterType): We unwrap the
19482 type, as we return the actual parameter ref/unref state on a
19485 2002-10-30 Miguel de Icaza <miguel@ximian.com>
19487 * support.cs: Return proper flags REF/OUT fixing the previous
19490 * expression.cs: Reverted last patch, that was wrong. Is_ref is
19491 not used to mean `ref' but `ref or out' in ParameterReference
19493 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
19494 full type signature instead of calling TypeManger.CSharpName
19497 * support.cs (InternalParameters.ParameterDesc): Do not compare
19498 directly to the modflags, because REF/OUT will actually be bitsets
19501 * delegate.cs (VerifyMethod): Check also the modifiers.
19503 * cs-tokenizer.cs: Fix bug where floating point values with an
19504 exponent where a sign was missing was ignored.
19506 * driver.cs: Allow multiple assemblies to be specified in a single
19509 2002-10-28 Miguel de Icaza <miguel@ximian.com>
19511 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
19512 because identifiers after a parenthesis would end up in this kind
19513 of production, and we needed to desamiguate it for having casts
19516 (UserDefinedType *) xxx
19518 2002-10-24 Miguel de Icaza <miguel@ximian.com>
19520 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
19521 we should set on the Bindingflags.NonPublic, but not turn on
19522 private_ok. private_ok controls whether a Private member is
19523 returned (this is chekced on the filter routine), while the
19524 BindingFlags.NonPublic just controls whether private/protected
19525 will be allowed. This fixes the problem part of the problem of
19526 private properties being allowed to be used in derived classes.
19528 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
19529 so we can call the children DoResolveLValue method (this will
19530 properly signal errors on lvalue assignments to base properties)
19532 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
19533 getter are null, and we have a property info, we know that this
19534 happened because the lookup failed, so we report an error 122 for
19535 protection level violation.
19537 We also silently return if setter and getter are null in the
19538 resolve functions, this condition only happens if we have flagged
19539 the error before. This is the other half of the problem.
19541 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
19542 not have accessibility information, that is why we were returning
19543 true in the filter function in typemanager.cs.
19545 To properly report 122 (property is inaccessible because of its
19546 protection level) correctly, we report this error in ResolveAccess
19547 by failing if both the setter and the getter are lacking (ie, the
19550 DoResolve and DoLResolve have been modified to check for both
19551 setter/getter being null and returning silently, the reason being
19552 that I did not want to put the knowledge about this error in upper
19555 int old = Report.Errors;
19556 x = new PropertyExpr (...);
19557 if (old != Report.Errors)
19562 So the property expr is returned, but it is invalid, so the error
19563 will be flagged during the resolve process.
19565 * class.cs: Remove InheritablePropertySignatureCompare from the
19566 class, as we no longer depend on the property signature to compute
19567 whether it is possible to implement a method or not.
19569 The reason is that calling PropertyInfo.GetGetMethod will return
19570 null (in .NET, in Mono it works, and we should change this), in
19571 cases where the Get Method does not exist in that particular
19576 class X { public virtual int A { get { return 1; } } }
19578 class Z : Y { public override int A { get { return 2; } } }
19580 Would fail in Z because the parent (Y) would not have the property
19581 defined. So we avoid this completely now (because the alternative
19582 fix was ugly and slow), and we now depend exclusively on the
19585 (PropertyBase.CheckBase): Use a method-base mechanism to find our
19586 reference method, instead of using the property.
19588 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
19589 routines are gone now.
19591 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
19592 names, they were incorrectly named.
19594 * cs-tokenizer.cs: Return are more gentle token on failure.
19596 * pending.cs (PendingImplementation.InterfaceMethod): This routine
19597 had an out-of-sync index variable, which caused it to remove from
19598 the list of pending methods the wrong method sometimes.
19600 2002-10-22 Miguel de Icaza <miguel@ximian.com>
19602 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
19603 CanWrite, because those refer to this particular instance of the
19604 property, and do not take into account the fact that we can
19605 override single members of a property.
19607 Constructor requires an EmitContext. The resolution process does
19608 not happen here, but we need to compute the accessors before,
19609 because the resolution does not always happen for properties.
19611 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
19612 subclass, before we did not update this flag, but we did update
19615 (GetAccessors): Drop this routine, as it did not work in the
19616 presence of partially overwritten set/get methods.
19618 Notice that this broke the cs1540 detection, but that will require
19621 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19625 * driver.cs: issue a warning instead of an error if we don't support
19626 debugging for the platform. Also ignore a couple of errors that may
19627 arise when trying to write the symbols. Undo my previous patch.
19629 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19631 * driver.cs: ignore /debug switch except for Unix platforms.
19633 2002-10-23 Nick Drochak <ndrochak@gol.com>
19635 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
19637 2002-10-21 Miguel de Icaza <miguel@ximian.com>
19639 * driver.cs: Do not make mcs-debug conditional, so we do not break
19640 builds that use it.
19642 * statement.cs (UsageVector.MergeChildren): I would like Martin to
19643 review this patch. But basically after all the children variables
19644 have been merged, the value of "Breaks" was not being set to
19645 new_breaks for Switch blocks. I think that it should be set after
19646 it has executed. Currently I set this to the value of new_breaks,
19647 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
19648 conservative, but I do not understand this code very well.
19650 I did not break anything in the build, so that is good ;-)
19652 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
19654 2002-10-20 Mark Crichton <crichton@gimp.org>
19656 * cfold.cs: Fixed compile blocker. Really fixed it this time.
19658 2002-10-20 Nick Drochak <ndrochak@gol.com>
19660 * cfold.cs: Fixed compile blocker.
19662 2002-10-20 Miguel de Icaza <miguel@ximian.com>
19664 * driver.cs: I was chekcing the key, not the file.
19666 2002-10-19 Ravi Pratap <ravi@ximian.com>
19668 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
19669 message that we were generating - we just need to silently return
19672 2002-10-19 Miguel de Icaza <miguel@ximian.com>
19674 * class.cs (Event.Define): Change my previous commit, as this
19675 breaks the debugger. This is a temporary hack, as it seems like
19676 the compiler is generating events incorrectly to begin with.
19678 * expression.cs (Binary.ResolveOperator): Added support for
19679 "U operator - (E x, E y)"
19681 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
19684 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
19685 init-only variables, but this path did not take into account that
19686 there might be also instance readonly variables. Correct this
19689 This fixes bug 32253
19691 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
19694 * driver.cs: Change the extension for modules to `netmodule'
19696 * cs-parser.jay: Improved slightly the location tracking for
19697 the debugger symbols.
19699 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
19700 modifiers that were specified instead of the hardcoded value
19701 (FamAndAssem). This was basically ignoring the static modifier,
19702 and others. Fixes 32429.
19704 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
19705 fixed a bug in the process (32476)
19707 * expression.cs (ArrayAccess.EmitAssign): Patch from
19708 hwang_rob@yahoo.ca that fixes bug 31834.3
19710 2002-10-18 Miguel de Icaza <miguel@ximian.com>
19712 * driver.cs: Make the module extension .netmodule.
19714 2002-10-16 Miguel de Icaza <miguel@ximian.com>
19716 * driver.cs: Report an error if the resource file is not found
19717 instead of crashing.
19719 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
19720 false, like Emit does.
19722 2002-10-16 Nick Drochak <ndrochak@gol.com>
19724 * typemanager.cs: Remove unused private member. Also reported mcs
19725 bug to report this as a warning like csc.
19727 2002-10-15 Martin Baulig <martin@gnome.org>
19729 * statement.cs (Statement.Emit): Made this a virtual method; emits
19730 the line number info and calls DoEmit().
19731 (Statement.DoEmit): New protected abstract method, formerly knows
19732 as Statement.Emit().
19734 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
19736 2002-10-11 Miguel de Icaza <miguel@ximian.com>
19738 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
19739 have fixed a remaining problem: not every AddXXXX was adding a
19740 fully qualified name.
19742 Now everyone registers a fully qualified name in the DeclSpace as
19743 being defined instead of the partial name.
19745 Downsides: we are slower than we need to be due to the excess
19746 copies and the names being registered this way.
19748 The reason for this is that we currently depend (on the corlib
19749 bootstrap for instance) that types are fully qualified, because
19750 we dump all the types in the namespace, and we should really have
19751 types inserted into the proper namespace, so we can only store the
19752 basenames in the defined_names array.
19754 2002-10-10 Martin Baulig <martin@gnome.org>
19756 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
19757 from bug #31834, see the bug report for a testcase which is
19760 2002-10-10 Martin Baulig <martin@gnome.org>
19762 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
19763 flow analysis code for this.
19765 * statement.cs (Do, While, For): Tell the flow analysis code about
19767 (FlowBranching.UsageVector): Added support for infinite loops.
19768 (Block.Resolve): Moved the dead code elimination here and use flow
19771 2002-10-09 Miguel de Icaza <miguel@ximian.com>
19773 * class.cs (Field.Define): Catch cycles on struct type
19776 * typemanager.cs (IsUnmanagedtype): Do not recursively check
19777 fields if the fields are static. We only need to check instance
19780 * expression.cs (As.DoResolve): Test for reference type.
19782 * statement.cs (Using.ResolveExpression): Use
19783 ConvertImplicitRequired, not ConvertImplicit which reports an
19785 (Using.ResolveLocalVariableDecls): ditto.
19787 * expression.cs (Binary.ResolveOperator): Report errors in a few
19788 places where we had to.
19790 * typemanager.cs (IsUnmanagedtype): Finish implementation.
19792 2002-10-08 Miguel de Icaza <miguel@ximian.com>
19794 * expression.cs: Use StoreFromPtr instead of extracting the type
19795 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
19797 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
19798 an enumeration value to a System.Enum, but System.Enum is not a
19799 value type, but an class type, so we need to box.
19801 (Expression.ConvertExplicit): One codepath could return
19802 errors but not flag them. Fix this. Fixes #31853
19804 * parameter.cs (Resolve): Do not allow void as a parameter type.
19806 2002-10-06 Martin Baulig <martin@gnome.org>
19808 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
19809 if it's a class type and not a struct. Fixes #31815.
19811 2002-10-06 Martin Baulig <martin@gnome.org>
19813 * statement.cs: Reworked the flow analysis code a bit to make it
19814 usable for dead code elimination.
19816 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19818 * cs-parser.jay: allow empty source files. Fixes bug #31781.
19820 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19822 * expression.cs (ComposedCast.DoResolveType): A quick workaround
19823 to fix the test 165, will investigate deeper.
19825 2002-10-04 Martin Baulig <martin@gnome.org>
19827 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
19828 finally blocks actually work.
19829 (Try.Resolve): We don't need to create a sibling for `finally' if
19830 there is no finally block.
19832 2002-10-04 Martin Baulig <martin@gnome.org>
19834 * class.cs (Constructor.Define): The default accessibility for a
19835 non-default constructor is private, not public.
19837 2002-10-04 Miguel de Icaza <miguel@ximian.com>
19839 * class.cs (Constructor): Make AllowedModifiers public, add
19842 * cs-parser.jay: Perform the modifiers test here, as the
19843 constructor for the Constructor class usually receives a zero
19844 because of the way we create it (first we create, later we
19845 customize, and we were never checking the modifiers).
19847 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
19848 is a version of LookupTypeReflection that includes the type-name
19849 cache. This can be used as a fast path for functions that know
19850 the fully qualified name and are only calling into *.GetType() to
19851 obtain a composed type.
19853 This is also used by TypeManager.LookupType during its type
19856 (LookupType): We now also track the real type name, as sometimes
19857 we can get a quey for the real type name from things like
19858 ComposedCast. This fixes bug 31422.
19860 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
19861 complete type fullname, it does not have to go through the type
19862 resolution system to obtain the composed version of the type (for
19863 obtaining arrays or pointers).
19865 (Conditional.Emit): Use the EmitBoolExpression to
19866 generate nicer code, as requested by Paolo.
19868 (ArrayCreation.CheckIndices): Use the patch from
19869 hwang_rob@yahoo.ca to validate the array initializers.
19871 2002-10-03 Miguel de Icaza <miguel@ximian.com>
19873 * class.cs (ConstructorInitializer.Emit): simplify code by using
19874 Invocation.EmitCall, and at the same time, fix the bugs in calling
19875 parent constructors that took variable arguments.
19877 * ecore.cs (Expression.ConvertNumericExplicit,
19878 Expression.ImplicitNumericConversion): Remove the code that
19879 manually wrapped decimal (InternalTypeConstructor call is now gone
19882 * expression.cs (Cast.TryReduce): Also handle decimal types when
19883 trying to perform a constant fold on the type.
19885 * typemanager.cs (IsUnmanagedtype): Partially implemented.
19887 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
19888 that only turned off an error report, and did nothing else.
19890 2002-10-02 Miguel de Icaza <miguel@ximian.com>
19892 * driver.cs: Handle and ignore /fullpaths
19894 2002-10-01 Miguel de Icaza <miguel@ximian.com>
19896 * expression.cs (Binary.ResolveOperator): Catch the case where
19897 DoNumericPromotions returns true,
19899 (Binary.DoNumericPromotions): Simplify the code, and the tests.
19901 2002-09-27 Miguel de Icaza <miguel@ximian.com>
19903 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
19906 2002-09-26 Miguel de Icaza <miguel@ximian.com>
19908 * ecore.cs (ConvertNumericExplicit): It is not enough that the
19909 conversion exists, but it is also required that the conversion be
19910 performed. This manifested in "(Type64Enum) 2".
19912 * class.cs (TypeManager.AddMethod): The fix is not to change
19913 AddEnum, because that one was using a fully qualified name (every
19914 DeclSpace derivative does), but to change the AddMethod routine
19915 that was using an un-namespaced name. This now correctly reports
19916 the duplicated name.
19918 Revert patch until I can properly fix it. The issue
19919 is that we have a shared Type space across all namespaces
19920 currently, which is wrong.
19922 Options include making the Namespace a DeclSpace, and merge
19923 current_namespace/current_container in the parser.
19925 2002-09-25 Miguel de Icaza <miguel@ximian.com>
19927 * cs-parser.jay: Improve error reporting when we get a different
19928 kind of expression in local_variable_type and
19929 local_variable_pointer_type.
19931 Propagate this to avoid missleading errors being reported.
19933 * ecore.cs (ImplicitReferenceConversion): treat
19934 TypeManager.value_type as a target just like object_type. As
19939 Is valid, and needs to result in the int 1 being boxed before it
19940 is assigned to the value type v.
19942 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
19943 to validate the enumeration name.
19945 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
19946 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
19947 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
19949 * ecore.cs (TryImplicitIntConversion): When doing an
19950 implicit-enumeration-conversion, check if the type is 64-bits and
19951 perform a conversion before passing to EnumConstant.
19953 2002-09-23 Miguel de Icaza <miguel@ximian.com>
19955 * decl.cs (Error_AmbiguousTypeReference); New routine used to
19956 report ambiguous type references. Unlike the MS version, we
19957 report what the ambiguity is. Innovation at work ;-)
19959 (DeclSpace.FindType): Require a location argument to
19960 display when we display an ambiguous error.
19962 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
19964 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
19966 * expression.cs (EmitDynamicInitializers): Apply patch from
19967 hwang_rob@yahoo.ca that fixes the order in which we emit our
19970 2002-09-21 Martin Baulig <martin@gnome.org>
19972 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
19973 delegate takes no arguments.
19975 2002-09-20 Miguel de Icaza <miguel@ximian.com>
19977 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
19980 * expression.cs: Extract the underlying type.
19982 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
19984 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
19986 2002-09-19 Miguel de Icaza <miguel@ximian.com>
19988 * class.cs (TypeContainer.DefineType): We can not use the nice
19989 PackingSize with the size set to 1 DefineType method, because it
19990 will not allow us to define the interfaces that the struct
19993 This completes the fixing of bug 27287
19995 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
19996 means also structs. This fixes part of the problem.
19997 (Expresion.ImplicitReferenceConversionExists): ditto.
19999 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
20000 error if there were no errors reported during the type lookup
20001 process, to avoid duplicates or redundant errors. Without this
20002 you would get an ambiguous errors plus a type not found. We have
20003 beaten the user enough with the first error.
20005 (DeclSparce.FindType): Emit a warning if we have an ambiguous
20008 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
20009 during the resolution process, stop the lookup, this avoids
20010 repeated error reports (same error twice).
20012 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
20014 * typemanager.cs (LookupType): Redo the type lookup code to match
20015 the needs of System.Reflection.
20017 The issue is that System.Reflection requires references to nested
20018 types to begin with a "+" sign instead of a dot. So toplevel
20019 types look like: "NameSpace.TopLevelClass", and nested ones look
20020 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
20023 2002-09-19 Martin Baulig <martin@gnome.org>
20025 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
20026 says that a method always returns or always throws an exception,
20027 don't report the CS0161.
20029 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
20030 set `Returns = new_returns'.
20032 2002-09-19 Martin Baulig <martin@gnome.org>
20034 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
20035 to an enum constant, check for a CS0176.
20037 2002-09-18 Miguel de Icaza <miguel@ximian.com>
20039 * class.cs (TypeContainer.CheckPairedOperators): Now we check
20040 for operators that must be in pairs and report errors.
20042 * ecore.cs (SimpleName.DoResolveType): During the initial type
20043 resolution process, when we define types recursively, we must
20044 check first for types in our current scope before we perform
20045 lookups in the enclosing scopes.
20047 * expression.cs (MakeByteBlob): Handle Decimal blobs.
20049 (Invocation.VerifyArgumentsCompat): Call
20050 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
20051 I thought we were supposed to always call this, but there are a
20052 few places in the code where we dont do it.
20054 2002-09-17 Miguel de Icaza <miguel@ximian.com>
20056 * driver.cs: Add support in -linkres and -resource to specify the
20057 name of the identifier.
20059 2002-09-16 Miguel de Icaza <miguel@ximian.com>
20061 * ecore.cs (StandardConversionExists): Sync with the conversion
20062 code: allow anything-* to void* conversions.
20064 (FindMostSpecificSource): Use an Expression argument
20065 instead of a Type, because we might be handed over a Literal which
20066 gets a few more implicit conversions that plain types do not. So
20067 this information was being lost.
20069 Also, we drop the temporary type-holder expression when not
20072 2002-09-17 Martin Baulig <martin@gnome.org>
20074 * class.cs (PropertyBase.CheckBase): Don't check the base class if
20075 this is an explicit interface implementation.
20077 2002-09-17 Martin Baulig <martin@gnome.org>
20079 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
20080 different `IndexerName' attributes.
20082 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
20083 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
20084 virtual CommonResolve().
20086 2002-09-16 Miguel de Icaza <miguel@ximian.com>
20088 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
20089 and convert that to the UnderlyingType.
20091 * statement.cs (Foreach.Resolve): Indexers are just like variables
20092 or PropertyAccesses.
20094 * cs-tokenizer.cs (consume_string): Track line numbers and columns
20095 inside quoted strings, we were not doing this before.
20097 2002-09-16 Martin Baulig <martin@gnome.org>
20099 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
20100 resolve it. This is needed for the definite assignment check of the
20101 instance expression, fixes bug #29846.
20102 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
20104 2002-09-16 Nick Drochak <ndrochak@gol.com>
20106 * parameter.cs: Fix compile error. Cannot reference static member
20107 from an instance object. Is this an mcs bug?
20109 2002-09-14 Martin Baulig <martin@gnome.org>
20111 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
20112 multiple times. Fixes bug #30295, added test-166.cs.
20114 2002-09-14 Martin Baulig <martin@gnome.org>
20116 * statement.cs (Block.Emit): Don't emit unreachable code.
20117 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
20118 `break' statements.
20119 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
20121 2002-09-14 Martin Baulig <martin@gnome.org>
20123 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
20126 2002-09-14 Martin Baulig <martin@gnome.org>
20128 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
20129 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
20130 be false on the ms runtime.
20132 2002-09-13 Martin Baulig <martin@gnome.org>
20134 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
20135 the CS0038 error message.
20137 2002-09-12 Miguel de Icaza <miguel@ximian.com>
20139 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
20140 constant inside, return it.
20142 2002-09-12 Martin Baulig <martin@gnome.org>
20144 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
20145 implicit conversion can be done between enum types.
20147 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
20148 check whether an implicit conversion to the current enum's UnderlyingType
20149 exists and report an error if not.
20151 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
20152 without debugging support.
20154 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
20155 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
20157 2002-09-12 Martin Baulig <martin@gnome.org>
20159 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
20161 * ecore.cs (IMemberExpr.DeclaringType): New property.
20162 (SimpleName.SimpleNameResolve): Check whether we're accessing a
20163 nonstatic member of an outer type (CS0038).
20165 2002-09-11 Miguel de Icaza <miguel@ximian.com>
20167 * driver.cs: Activate the using-error detector at warning level
20168 4 (at least for MS-compatible APIs).
20170 * namespace.cs (VerifyUsing): Small buglett fix.
20172 * pending.cs (PendingImplementation): pass the container pointer.
20174 * interface.cs (GetMethods): Allow for recursive definition. Long
20175 term, I would like to move every type to support recursive
20176 definitions, not the current ordering mechanism that we have right
20179 The situation is this: Attributes are handled before interfaces,
20180 so we can apply attributes to interfaces. But some attributes
20181 implement interfaces, we will now handle the simple cases
20182 (recursive definitions will just get an error).
20184 * parameter.cs: Only invalidate types at the end if we fail to
20187 2002-09-09 Martin Baulig <martin@gnome.org>
20189 * ecore.cs (PropertyExpr.Emit): Also check for
20190 TypeManager.system_int_array_get_length so this'll also work when
20191 compiling corlib. Fixes #30003.
20193 2002-09-09 Martin Baulig <martin@gnome.org>
20195 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
20196 and throw an exception if we can't get the type's size. Fixed #30040,
20199 2002-09-09 Martin Baulig <martin@gnome.org>
20201 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
20203 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
20204 context. Fixes bug #30027.
20206 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
20207 virtual functions. Fixes bug #30043, added test-164.cs.
20209 2002-09-08 Ravi Pratap <ravi@ximian.com>
20211 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
20213 2002-09-08 Nick Drochak <ndrochak@gol.com>
20215 * driver.cs: Use an object to get the windows codepage since it's not a
20218 2002-09-08 Miguel de Icaza <miguel@ximian.com>
20220 * statement.cs (For.Emit): for infinite loops (test == null)
20221 return whether there is a break inside, not always "true".
20223 * namespace.cs (UsingEntry): New struct to hold the name of the
20224 using definition, the location where it is defined, and whether it
20225 has been used in a successful type lookup.
20227 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
20232 2002-09-06 Ravi Pratap <ravi@ximian.com>
20234 * attribute.cs : Fix incorrect code which relied on catching
20235 a NullReferenceException to detect a null being passed in
20236 where an object was expected.
20238 2002-09-06 Miguel de Icaza <miguel@ximian.com>
20240 * statement.cs (Try): flag the catch variable as assigned
20242 * expression.cs (Cast): Simplified by using ResolveType instead of
20243 manually resolving.
20245 * statement.cs (Catch): Fix bug by using ResolveType.
20247 2002-09-06 Ravi Pratap <ravi@ximian.com>
20249 * expression.cs (BetterConversion): Special case for when we have
20250 a NullLiteral as the argument and we have to choose between string
20251 and object types - we choose string the way csc does.
20253 * attribute.cs (Attribute.Resolve): Catch the
20254 NullReferenceException and report error #182 since the Mono
20255 runtime no more has the bug and having this exception raised means
20256 we tried to select a constructor which takes an object and is
20259 2002-09-05 Ravi Pratap <ravi@ximian.com>
20261 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
20262 message (1502, 1503) when we can't locate a method after overload
20263 resolution. This is much more informative and closes the bug
20266 * interface.cs (PopulateMethod): Return if there are no argument
20267 types. Fixes a NullReferenceException bug.
20269 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
20270 expressions too. Previously we were checking only in one place for
20271 positional arguments leaving out named arguments.
20273 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
20274 type to the enum type is not allowed. Remove code corresponding to
20277 (ConvertNumericExplicit): Allow explicit conversions from
20278 the underlying type to enum type. This precisely follows the spec
20279 and closes a bug filed by Gonzalo.
20281 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20284 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
20286 2002-09-03 Miguel de Icaza <miguel@ximian.com>
20288 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
20289 it was important that we stored the right value after the
20290 reduction in `converted'.
20292 2002-09-04 Martin Baulig <martin@gnome.org>
20294 * location.cs (Location.SymbolDocument): Use full pathnames for the
20297 2002-08-30 Miguel de Icaza <miguel@ximian.com>
20299 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
20300 of the expression resolve mechanism, because that will catch the
20301 SimpleName error failures.
20303 (Conditional): If we can not resolve the
20304 expression, return, do not crash.
20306 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20309 (location): display token name instead of its number.
20311 2002-08-28 Martin Baulig <martin@gnome.org>
20313 * expression.cs (Binary.ResolveOperator): Don't silently return
20314 but return an error if an operator cannot be applied between two
20317 2002-08-28 Martin Baulig <martin@gnome.org>
20319 * class.cs (Constructor.Define): Set the permission attributes
20320 correctly instead of making all constructors public.
20322 2002-08-28 Martin Baulig <martin@gnome.org>
20324 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
20325 for private members before reporting a CS0103; if we find anything,
20328 2002-08-28 Martin Baulig <martin@gnome.org>
20330 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
20331 to check whether `closure_start_type == closure_invocation_type',
20332 we also need to check whether `m.DeclaringType == closure_invocation_type'
20333 before bypassing the permission checks. We might be accessing
20334 protected/private members from the base class.
20335 (TypeManager.RealMemberLookup): Only set private_ok if private
20336 members were requested via BindingFlags.NonPublic.
20338 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
20340 * expression.cs (MemberAccess.ResolveMemberAccess): Set
20341 MethodGroupExpr.IsExplicitImpl if appropriate.
20342 (Invocation.DoResolve): Don't report the CS0120 for explicit
20343 interface implementations.
20345 2002-08-27 Martin Baulig <martin@gnome.org>
20347 * expression.cs (Invocation.DoResolve): If this is a static
20348 method and we don't have an InstanceExpression, we must report
20351 2002-08-25 Martin Baulig <martin@gnome.org>
20353 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
20354 `==' between a valuetype and an object.
20356 2002-08-25 Miguel de Icaza <miguel@ximian.com>
20358 * ecore.cs (TypeExpr): Provide a ToString method.
20360 2002-08-24 Martin Baulig <martin@gnome.org>
20362 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
20363 now called proggie.dbg and it's a binary file.
20365 2002-08-23 Martin Baulig <martin@gnome.org>
20367 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
20369 2002-08-23 Martin Baulig <martin@gnome.org>
20371 * struct.cs (MyStructInfo.ctor): Make this work with empty
20372 structs; it's not allowed to use foreach() on null.
20374 2002-08-23 Martin Baulig <martin@gnome.org>
20376 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
20377 writer the full pathname of the generated assembly.
20379 2002-08-23 Martin Baulig <martin@gnome.org>
20381 * statements.cs (FlowBranching.UsageVector.MergeChildren):
20382 A `finally' block never returns or breaks; improved handling of
20385 2002-08-23 Martin Baulig <martin@gnome.org>
20387 * statement.cs (Throw.Resolve): Allow `throw null'.
20389 2002-08-23 Martin Baulig <martin@gnome.org>
20391 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
20392 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
20393 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
20394 MemberLookup would return a wrong event if this is an explicit
20395 interface implementation and the class has an event with the same
20398 2002-08-23 Martin Baulig <martin@gnome.org>
20400 * statement.cs (Block.AddChildVariableNames): New public method.
20401 (Block.AddChildVariableName): Likewise.
20402 (Block.IsVariableNameUsedInChildBlock): Likewise.
20403 (Block.AddVariable): Check whether a variable name has already
20404 been used in a child block.
20406 * cs-parser.jay (declare_local_variables): Mark all variable names
20407 from the current block as being used in a child block in the
20410 2002-08-23 Martin Baulig <martin@gnome.org>
20412 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
20413 find the symbol writer.
20415 * driver.cs: csc also allows the arguments to /define being
20416 separated by commas, not only by semicolons.
20418 2002-08-23 Martin Baulig <martin@gnome.org>
20420 * interface.cs (Interface.GetMembers): Added static check for events.
20422 2002-08-15 Martin Baulig <martin@gnome.org>
20424 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
20425 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
20427 * ecore.cs (Expression.MemberLookup): Added documentation and explained
20428 why the MethodData.EmitDestructor() change was necessary.
20430 2002-08-20 Martin Baulig <martin@gnome.org>
20432 * class.cs (TypeContainer.FindMembers): Added static check for events.
20434 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
20436 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
20437 use Type.GetEvents(), not Type.FindMembers().
20439 2002-08-20 Martin Baulig <martin@gnome.org>
20441 * decl.cs (MemberCache): Added a special method cache which will
20442 be used for method-only searched. This ensures that a method
20443 search will return a MethodInfo with the correct ReflectedType for
20446 2002-08-20 Martin Baulig <martin@gnome.org>
20448 * decl.cs (DeclSpace.FindMembers): Made this public.
20450 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20452 * delegate.cs: fixed build on windows.
20453 [FIXME: Filed as bug #29150: MCS must report these errors.]
20455 2002-08-19 Ravi Pratap <ravi@ximian.com>
20457 * ecore.cs (StandardConversionExists): Return a false
20458 if we are trying to convert the void type to anything else
20459 since that is not allowed.
20461 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
20462 we flag error 70 in the event an event is trying to be accessed
20463 directly from outside the declaring type.
20465 2002-08-20 Martin Baulig <martin@gnome.org>
20467 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
20468 MemberCache from typemanager.cs to decl.cs.
20470 2002-08-19 Martin Baulig <martin@gnome.org>
20472 * class.cs (TypeContainer): Implement IMemberContainer.
20473 (TypeContainer.DefineMembers): Create the MemberCache.
20474 (TypeContainer.FindMembers): Do better BindingFlags checking; only
20475 return public members if BindingFlags.Public was given, check
20476 whether members are static.
20478 2002-08-16 Martin Baulig <martin@gnome.org>
20480 * decl.cs (DeclSpace.Define): Splitted this in Define and
20481 DefineMembers. DefineMembers is called first and initializes the
20484 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
20485 DefineMembers() on all our DeclSpaces.
20487 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
20488 but call DefineMembers() on all nested interfaces. We call their
20489 Define() in our new Define() function.
20491 * interface.cs (Interface): Implement IMemberContainer.
20492 (Interface.Define): Moved all code except the attribute stuf to
20494 (Interface.DefineMembers): Initialize the member cache.
20496 * typemanager.cs (IMemberFinder): Removed this interface, we don't
20497 need this anymore since we can use MemberCache.FindMembers directly.
20499 2002-08-19 Martin Baulig <martin@gnome.org>
20501 * typemanager.cs (MemberCache): When creating the cache for an
20502 interface type, add all inherited members.
20503 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
20504 to `out bool used_cache' and documented it.
20505 (TypeManager.MemberLookup): If we already used the cache in the first
20506 iteration, we don't need to do the interfaces check.
20508 2002-08-19 Martin Baulig <martin@gnome.org>
20510 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
20511 here from IMemberFinder and don't implement this interface anymore.
20512 (DeclSpace.MemberCache): Moved here from IMemberFinder.
20514 * typemanager.cs (IMemberFinder): This interface is now only used by
20515 classes which actually support the member cache.
20516 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
20517 since we only put DeclSpaces into this Hashtable.
20518 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
20519 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
20521 2002-08-16 Martin Baulig <martin@gnome.org>
20523 * typemanager.cs (ICachingMemberFinder): Removed.
20524 (IMemberFinder.MemberCache): New property.
20525 (TypeManager.FindMembers): Merged this with RealFindMembers().
20526 This function will never be called from TypeManager.MemberLookup()
20527 so we can't use the cache here, just the IMemberFinder.
20528 (TypeManager.MemberLookup_FindMembers): Check whether the
20529 IMemberFinder has a MemberCache and call the cache's FindMembers
20531 (MemberCache): Rewrote larger parts of this yet another time and
20532 cleaned it up a bit.
20534 2002-08-15 Miguel de Icaza <miguel@ximian.com>
20536 * driver.cs (LoadArgs): Support quoting.
20538 (Usage): Show the CSC-like command line arguments.
20540 Improved a few error messages.
20542 2002-08-15 Martin Baulig <martin@gnome.org>
20544 * typemanager.cs (IMemberContainer.Type): New property.
20545 (IMemberContainer.IsInterface): New property.
20547 The following changes are conditional to BROKEN_RUNTIME, which is
20548 defined at the top of the file.
20550 * typemanager.cs (MemberCache.MemberCache): Don't add the base
20551 class'es members, but add all members from TypeHandle.ObjectType
20552 if we're an interface.
20553 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
20554 is the current type.
20555 (MemberCache.CacheEntry.Container): Removed this field.
20556 (TypeHandle.GetMembers): Include inherited members.
20558 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20560 * typemanager.cs: fixed compilation and added a comment on a field that
20563 2002-08-15 Martin Baulig <martin@gnome.org>
20565 * class.cs (ConstructorInitializer.Resolve): In the
20566 Expression.MemberLookup call, use the queried_type as
20569 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
20570 declared' attribute, it's always true.
20571 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
20572 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
20573 temporary wrapper for FindMembers which tells MemberLookup whether
20574 members from the base classes are included in the return value.
20575 This will go away soon.
20576 (TypeManager.MemberLookup): Use this temporary hack here; once the
20577 new MemberCache is completed, we don't need to do the DeclaredOnly
20578 looping here anymore since the MemberCache will take care of this.
20579 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
20580 (MemberCache): When creating the MemberCache for a class, get
20581 members from the current class and all its base classes.
20582 (MemberCache.CacheEntry.Container): New field. This is a
20583 temporary hack until the Mono runtime is fixed to distinguish
20584 between ReflectedType and DeclaringType. It allows us to use MCS
20585 with both the MS runtime and the unfixed Mono runtime without
20586 problems and without accecting performance.
20587 (MemberCache.SearchMembers): The DeclaredOnly looping from
20588 TypeManager.MemberLookup is now done here.
20590 2002-08-14 Martin Baulig <martin@gnome.org>
20592 * statement.cs (MyStructInfo.MyStructInfo): Don't call
20593 Type.GetFields on dynamic types but get the fields from the
20594 corresponding TypeContainer.
20595 (MyStructInfo.GetStructInfo): Added check for enum types.
20597 * typemanager.cs (MemberList.IsSynchronized): Implemented.
20598 (MemberList.SyncRoot): Implemented.
20599 (TypeManager.FilterWithClosure): No need to check permissions if
20600 closure_start_type == closure_invocation_type, don't crash if
20601 closure_invocation_type is null.
20603 2002-08-13 Martin Baulig <martin@gnome.org>
20605 Rewrote TypeContainer.FindMembers to use a member cache. This
20606 gives us a speed increase of about 35% for the self-hosting MCS
20607 build and of about 15-20% for the class libs (both on GNU/Linux).
20609 * report.cs (Timer): New class to get enhanced profiling. This
20610 whole class is "TIMER" conditional since it remarkably slows down
20613 * class.cs (MemberList): New class. This is an IList wrapper
20614 which we're now using instead of passing MemberInfo[]'s around to
20615 avoid copying this array unnecessarily.
20616 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
20617 (ICachingMemberFinder, IMemberContainer): New interface.
20618 (TypeManager.FilterWithClosure): If `criteria' is null, the name
20619 has already been checked, otherwise use it for the name comparision.
20620 (TypeManager.FindMembers): Renamed to RealMemberFinder and
20621 provided wrapper which tries to use ICachingMemberFinder.FindMembers
20622 if possible. Returns a MemberList, not a MemberInfo [].
20623 (TypeHandle): New class, implements IMemberContainer. We create
20624 one instance of this class per type, it contains a MemberCache
20625 which is used to do the member lookups.
20626 (MemberCache): New class. Each instance of this class contains
20627 all members of a type and a name-based hash table.
20628 (MemberCache.FindMembers): This is our new member lookup
20629 function. First, it looks up all members of the requested name in
20630 the hash table. Then, it walks this list and sorts out all
20631 applicable members and returns them.
20633 2002-08-13 Martin Baulig <martin@gnome.org>
20635 In addition to a nice code cleanup, this gives us a performance
20636 increase of about 1.4% on GNU/Linux - not much, but it's already
20637 half a second for the self-hosting MCS compilation.
20639 * typemanager.cs (IMemberFinder): New interface. It is used by
20640 TypeManager.FindMembers to call FindMembers on a TypeContainer,
20641 Enum, Delegate or Interface.
20642 (TypeManager.finder_to_member_finder): New PtrHashtable.
20643 (TypeManager.finder_to_container): Removed.
20644 (TypeManager.finder_to_delegate): Removed.
20645 (TypeManager.finder_to_interface): Removed.
20646 (TypeManager.finder_to_enum): Removed.
20648 * interface.cs (Interface): Implement IMemberFinder.
20650 * delegate.cs (Delegate): Implement IMemberFinder.
20652 * enum.cs (Enum): Implement IMemberFinder.
20654 * class.cs (TypeContainer): Implement IMemberFinder.
20656 2002-08-12 Martin Baulig <martin@gnome.org>
20658 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
20660 2002-08-12 Martin Baulig <martin@gnome.org>
20662 * ecore.cs (ITypeExpression): New interface for expressions which
20664 (TypeExpression): Renamed to TypeLookupExpression.
20665 (Expression.DoResolve): If we're doing a types-only lookup, the
20666 expression must implement the ITypeExpression interface and we
20667 call DoResolveType() on it.
20668 (SimpleName): Implement the new ITypeExpression interface.
20669 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
20670 hack, the situation that we're only looking up types can't happen
20671 anymore when this method is called. Moved the type lookup code to
20672 DoResolveType() and call it.
20673 (SimpleName.DoResolveType): This ITypeExpression interface method
20674 is now doing the types-only lookup.
20675 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
20676 (ResolveFlags): Added MaskExprClass.
20678 * expression.cs (MemberAccess): Implement the ITypeExpression
20680 (MemberAccess.DoResolve): Added support for a types-only lookup
20681 when we're called via ITypeExpression.DoResolveType().
20682 (ComposedCast): Implement the ITypeExpression interface.
20684 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
20685 Expression.Resolve() with ResolveFlags.Type instead.
20687 2002-08-12 Martin Baulig <martin@gnome.org>
20689 * interface.cs (Interface.Define): Apply attributes.
20691 * attribute.cs (Attribute.ApplyAttributes): Added support for
20692 interface attributes.
20694 2002-08-11 Martin Baulig <martin@gnome.org>
20696 * statement.cs (Block.Emit): Only check the "this" variable if we
20697 do not always throw an exception.
20699 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
20700 whether the property has a set accessor.
20702 2002-08-11 Martin Baulig <martin@gnome.org>
20704 Added control flow analysis support for structs.
20706 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
20707 with control flow analysis turned off.
20708 (IVariable): New interface.
20709 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
20710 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
20711 (FieldExpr.DoResolve): Resolve the instance expression with flow
20712 analysis turned off and do the definite assignment check after the
20713 resolving when we know what the expression will resolve to.
20715 * expression.cs (LocalVariableReference, ParameterReference):
20716 Implement the new IVariable interface, only call the flow analysis
20717 code if ec.DoFlowAnalysis is true.
20718 (This): Added constructor which takes a Block argument. Implement
20719 the new IVariable interface.
20720 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
20721 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
20722 This does the definite assignment checks for struct members.
20724 * class.cs (Constructor.Emit): If this is a non-static `struct'
20725 constructor which doesn't have any initializer, call
20726 Block.AddThisVariable() to tell the flow analysis code that all
20727 struct elements must be initialized before control returns from
20730 * statement.cs (MyStructInfo): New public class.
20731 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
20732 argument to this indexer. If non-zero, check an individual struct
20733 member, not the whole struct.
20734 (FlowBranching.CheckOutParameters): Check struct members.
20735 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
20736 overloaded versions of these methods which take an additional
20737 `int field_idx' argument to check struct members.
20738 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
20739 overloaded versions of these methods which take an additional
20740 `string field_name' argument to check struct member.s
20741 (VariableInfo): Implement the IVariable interface.
20742 (VariableInfo.StructInfo): New public property. Returns the
20743 MyStructInfo instance of the variable if it's a struct or null.
20744 (Block.AddThisVariable): New public method. This is called from
20745 Constructor.Emit() for non-static `struct' constructor which do
20746 not have any initializer. It creates a special variable for the
20747 "this" instance variable which will be checked by the flow
20748 analysis code to ensure that all of the struct's fields are
20749 initialized before control returns from the constructor.
20750 (UsageVector): Added support for struct members. If a
20751 variable/parameter is a struct with N members, we reserve a slot
20752 in the usage vector for each member. A struct is considered fully
20753 initialized if either the struct itself (slot 0) or all its
20754 members are initialized.
20756 2002-08-08 Martin Baulig <martin@gnome.org>
20758 * driver.cs (Driver.MainDriver): Only report an error CS5001
20759 if there were no compilation errors.
20761 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
20762 `UnsafeContext' property to determine whether the parent is in
20763 unsafe context rather than checking the parent's ModFlags:
20764 classes nested in an unsafe class are unsafe as well.
20766 2002-08-08 Martin Baulig <martin@gnome.org>
20768 * statement.cs (UsageVector.MergeChildren): Distinguish between
20769 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
20770 we return. Added test17() and test18() to test-154.cs.
20772 2002-08-08 Martin Baulig <martin@gnome.org>
20774 * typemanager.cs (TypeManager.FilterWithClosure): If we have
20775 Family access, make sure the invoking type isn't a subclass of the
20776 queried type (that'd be a CS1540).
20778 * ecore.cs (Expression.MemberLookup): Added overloaded version of
20779 this method which takes an additional `Type invocation_type'.
20781 * expression.cs (BaseAccess.DoResolve): Use the base type as
20782 invocation and query type.
20783 (MemberAccess.DoResolve): If the lookup failed and we're about to
20784 report a CS0122, try a lookup with the ec.ContainerType - if this
20785 succeeds, we must report a CS1540.
20787 2002-08-08 Martin Baulig <martin@gnome.org>
20789 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
20790 (MethodGroupExpr): Implement the IMemberExpr interface.
20792 * expression (MemberAccess.ResolveMemberAccess): No need to have
20793 any special code for MethodGroupExprs anymore, they're now
20796 2002-08-08 Martin Baulig <martin@gnome.org>
20798 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
20799 Family, FamANDAssem and FamORAssem permissions.
20800 (TypeManager.IsSubclassOrNestedChildOf): New public method.
20802 2002-08-08 Martin Baulig <martin@gnome.org>
20804 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
20805 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
20808 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
20810 * driver.cs: implemented /resource option to embed managed resources.
20812 2002-08-07 Martin Baulig <martin@gnome.org>
20814 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
20815 (FieldBase.HasFieldInitializer): New public property.
20816 (FieldBase.GetInitializerExpression): New public method. Resolves and
20817 returns the field initializer and makes sure it is only resolved once.
20818 (TypeContainer.EmitFieldInitializers): Call
20819 FieldBase.GetInitializerExpression to get the initializer, this ensures
20820 that it isn't resolved multiple times.
20822 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
20823 the resolving process (SimpleName/MemberLookup) that we're currently
20824 emitting a field initializer (which must not access any instance members,
20825 this is an error CS0236).
20827 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
20828 argument, if the `IsFieldInitializer' flag is set, we must report and
20829 error CS0236 and not an error CS0120.
20831 2002-08-07 Martin Baulig <martin@gnome.org>
20833 * ecore.cs (IMemberExpr): New public interface.
20834 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
20835 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
20836 if the expression is an IMemberExpr.
20838 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
20839 to be null, implicitly default to `this' if we're non-static in
20840 this case. Simplified the code a lot by using the new IMemberExpr
20841 interface. Also fixed bug #28176 here.
20843 2002-08-06 Martin Baulig <martin@gnome.org>
20845 * cs-parser.jay (SimpleLookup): Removed. We need to create
20846 ParameterReferences during semantic analysis so that we can do a
20847 type-only search when resolving Cast, TypeOf and SizeOf.
20848 (block): Pass the `current_local_parameters' to the Block's
20851 * class.cs (ConstructorInitializer): Added `Parameters parameters'
20852 argument to the constructor.
20853 (ConstructorInitializer.Resolve): Create a temporary implicit
20854 block with the parameters.
20856 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
20857 references here if we aren't doing a type-only search.
20859 * statement.cs (Block): Added constructor which takes a
20860 `Parameters parameters' argument.
20861 (Block.Parameters): New public property.
20863 * support.cs (InternalParameters.Parameters): Renamed `parameters'
20864 to `Parameters' and made it public readonly.
20866 2002-08-06 Martin Baulig <martin@gnome.org>
20868 * ecore.cs (Expression.Warning): Made this public as well.
20870 * report.cs (Report.Debug): Print the contents of collections.
20872 2002-08-06 Martin Baulig <martin@gnome.org>
20874 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
20875 used to tell Resolve() which kinds of expressions it may return.
20876 (Expression.Resolve): Added overloaded version of this method which
20877 takes a `ResolveFlags flags' argument. This can be used to tell
20878 Resolve() which kinds of expressions it may return. Reports a
20880 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
20881 ResolveFlags.SimpleName.
20882 (Expression.Error118): Added overloaded version of this method which
20883 takes a `ResolveFlags flags' argument. It uses the flags to determine
20884 which kinds of expressions are allowed.
20886 * expression.cs (Argument.ResolveMethodGroup): New public method.
20887 Resolves an argument, but allows a MethodGroup to be returned.
20888 This is used when invoking a delegate.
20890 * TODO: Updated a bit.
20892 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20894 Fixed compilation with csc.
20896 * ecore.cs: Expression.Error made public. Is this correct? Should
20897 Warning be made public too?
20899 * expression.cs: use ea.Location instead of ea.loc.
20900 [FIXME: Filed as bug #28607: MCS must report these errors.]
20902 2002-08-06 Martin Baulig <martin@gnome.org>
20904 * ecore.cs (Expression.loc): Moved the location here instead of
20905 duplicating it in all derived classes.
20906 (Expression.Location): New public property.
20907 (Expression.Error, Expression.Warning): Made them non-static and
20908 removed the location argument.
20909 (Expression.Warning): Added overloaded version which takes an
20910 `int level' argument.
20911 (Expression.Error118): Make this non-static and removed the
20912 expression and location arguments.
20913 (TypeExpr): Added location argument to the constructor.
20915 * expression.cs (StaticCallExpr): Added location argument to
20917 (Indirection, PointerArithmetic): Likewise.
20918 (CheckedExpr, UnCheckedExpr): Likewise.
20919 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
20920 (StringPtr): Likewise.
20923 2002-08-05 Martin Baulig <martin@gnome.org>
20925 * expression.cs (BaseAccess.DoResolve): Actually report errors.
20927 * assign.cs (Assign.DoResolve): Check whether the source
20928 expression is a value or variable.
20930 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
20931 while resolving the corresponding blocks.
20933 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
20934 an error, don't silently return null.
20936 * statement.cs (Block.AddVariable): Do the error reporting here
20937 and distinguish between CS0128 and CS0136.
20938 (Block.DoResolve): Report all unused labels (warning CS0164).
20939 (LabeledStatement): Pass the location to the constructor.
20940 (LabeledStatement.HasBeenReferenced): New property.
20941 (LabeledStatement.Resolve): Set it to true here.
20943 * statement.cs (Return.Emit): Return success even after reporting
20944 a type mismatch error (CS0126 or CS0127), this is what csc does and
20945 it avoids confusing the users with any consecutive errors.
20947 2002-08-05 Martin Baulig <martin@gnome.org>
20949 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
20951 * const.cs (Const.LookupConstantValue): Catch circular definitions.
20953 * expression.cs (MemberAccess.DoResolve): Silently return if an
20954 error has already been reported.
20956 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
20957 error has already been reported.
20959 2002-08-05 Martin Baulig <martin@gnome.org>
20961 * statement.cs (UsageVector): Only initialize the `parameters'
20962 vector if we actually have any "out" parameters.
20964 2002-08-05 Martin Baulig <martin@gnome.org>
20966 * expression.cs (Binary.ResolveOperator): When combining delegates,
20967 they must have the same type.
20969 2002-08-05 Martin Baulig <martin@gnome.org>
20971 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
20972 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
20973 work with the ms runtime and we also don't need it: if we're a
20974 PropertyBuilder and not in the `indexer_arguments' hash, then we
20975 are a property and not an indexer.
20977 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
20978 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
20979 since the latter one doesn't work with the ms runtime.
20981 2002-08-03 Martin Baulig <martin@gnome.org>
20983 Fixed bugs #27998 and #22735.
20985 * class.cs (Method.IsOperator): New public field.
20986 (Method.CheckBase): Report CS0111 if there's already a method
20987 with the same parameters in the current class. Report CS0508 when
20988 attempting to change the return type of an inherited method.
20989 (MethodData.Emit): Report CS0179 if a method doesn't have a body
20990 and it's not marked abstract or extern.
20991 (PropertyBase): New abstract base class for Property and Indexer.
20992 (PropertyBase.CheckBase): Moved here from Property and made it work
20994 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
20995 the same so we can reuse it there.
20996 (Property, Indexer): Derive from PropertyBase.
20997 (MethodSignature.inheritable_property_signature_filter): New delegate
20998 to find properties and indexers.
21000 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
21001 argument and improved error reporting.
21003 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
21004 EmptyReadOnlyParameters and made it a property.
21006 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
21007 version of this method which takes a `PropertyInfo indexer'.
21008 (TypeManager.RegisterIndexer): New method.
21010 * class.cs: Added myself as author of this file :-)
21012 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21014 * class.cs: fixed compilation on windoze.
21016 2002-08-03 Martin Baulig <martin@gnome.org>
21018 * interface.cs (Interface.GetInterfaceBases): Check whether all
21019 base interfaces are at least as accessible than the current one.
21021 * class.cs (TypeContainer.GetClassBases): Check whether base types
21022 are at least as accessible than the current type.
21023 (TypeContainer.AsAccessible): Implemented and made non-static.
21024 (MemberBase.CheckParameters): Report errors if the accessibility
21027 * delegate.cs (Delegate.Delegate): The default visibility is
21028 internal for top-level types and private for nested types.
21029 (Delegate.Define): Report errors if the accessibility checks fail.
21031 * enum.cs (Enum.Enum): The default visibility is internal for
21032 top-level types and private for nested types.
21033 (Enum.DefineType): Compute the correct visibility.
21035 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
21036 function which takes a `bool is_toplevel' instead of a TypeContainer.
21038 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
21041 2002-08-02 Martin Baulig <martin@gnome.org>
21043 * expression.cs (LocalVariableReferenc): Added constructor which
21044 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
21045 (LocalVariableReference.IsReadOnly): New property.
21046 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
21047 variable is readonly, use our own readonly flag to do this; you can
21048 use the new constructor to get a writable reference to a read-only
21051 * cs-parser.jay (foreach_statement, using_statement): Get a writable
21052 reference to the local variable.
21054 2002-08-01 Miguel de Icaza <miguel@ximian.com>
21056 * rootcontext.cs (ResolveCore): Also include System.Exception
21058 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
21059 we reach an EmptyStatement.
21061 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
21064 * expression.cs (Binary.ResolveOperator): Check error result in
21067 use brtrue/brfalse directly and avoid compares to null.
21069 2002-08-02 Martin Baulig <martin@gnome.org>
21071 * class.cs (TypeContainer.Define): Define all nested interfaces here.
21072 Fixes bug #28407, added test-155.cs.
21074 2002-08-01 Martin Baulig <martin@gnome.org>
21076 * class.cs (Event.EmitDefaultMethod): Make this work with static
21077 events. Fixes #28311, added verify-3.cs.
21079 2002-08-01 Martin Baulig <martin@gnome.org>
21081 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
21082 `is_disposable' fields.
21083 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
21084 `hm.is_disposable' if we're using the collection pattern.
21085 (Foreach.EmitCollectionForeach): Use the correct type for the
21086 enumerator's local variable, only emit the try/finally block if
21087 necessary (fixes #27713).
21089 2002-08-01 Martin Baulig <martin@gnome.org>
21091 * ecore.cs (Expression.report118): Renamed to Error118 and made
21094 * statement.cs (Throw.Resolve): Check whether the expression is of
21095 the correct type (CS0118) and whether the type derives from
21096 System.Exception (CS0155).
21097 (Catch.Resolve): New method. Do the type lookup here and check
21098 whether it derives from System.Exception (CS0155).
21099 (Catch.CatchType, Catch.IsGeneral): New public properties.
21101 * typemanager.cs (TypeManager.exception_type): Added.
21103 2002-07-31 Miguel de Icaza <miguel@ximian.com>
21105 * driver.cs: Updated About function.
21107 2002-07-31 Martin Baulig <martin@gnome.org>
21109 Implemented Control Flow Analysis.
21111 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
21112 (EmitContext.CurrentBranching): Added.
21113 (EmitContext.StartFlowBranching): Added.
21114 (EmitContext.EndFlowBranching): Added.
21115 (EmitContext.KillFlowBranching): Added.
21116 (EmitContext.IsVariableAssigned): Added.
21117 (EmitContext.SetVariableAssigned): Added.
21118 (EmitContext.IsParameterAssigned): Added.
21119 (EmitContext.SetParameterAssigned): Added.
21120 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
21121 Added control flow analysis stuff here.
21123 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
21124 resolve the expression as lvalue.
21125 (LocalVariableReference.DoResolve): Check whether the variable has
21126 already been assigned.
21127 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
21128 the parameter as assigned here.
21129 (ParameterReference.DoResolve): Check whether the parameter has already
21131 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
21132 expression as lvalue.
21134 * statement.cs (FlowBranching): New class for the flow analysis code.
21135 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
21136 (LabeledStatement.IsDefined): New public property.
21137 (LabeledStatement.AddUsageVector): New public method to tell flow
21138 analyis that the label may be reached via a forward jump.
21139 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
21141 (VariableInfo.Number): New public field. This is used by flow analysis
21142 to number all locals of a block.
21143 (Block.CountVariables): New public property. This is the number of
21144 local variables in this block (including the locals from all parent
21146 (Block.EmitMeta): Number all the variables.
21148 * statement.cs: Added flow analysis support to all classes.
21150 2002-07-31 Martin Baulig <martin@gnome.org>
21152 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
21153 To get debugging messages, compile mcs with /define:MCS_DEBUG and
21154 then use this argument.
21156 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
21158 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
21159 use this to specify /define options.
21161 2002-07-29 Martin Baulig <martin@gnome.org>
21163 * statement.cs (Fixed): Moved all code that does variable lookups
21164 and resolvings from Emit to Resolve.
21166 * statement.cs (For): Moved all code that does variable lookups
21167 and resolvings from Emit to Resolve.
21169 * statement.cs (Using): Moved all code that does variable lookups
21170 and resolvings from Emit to Resolve.
21172 2002-07-29 Martin Baulig <martin@gnome.org>
21174 * attribute.cs (Attribute.Resolve): Explicitly catch a
21175 System.NullReferenceException when creating the
21176 CustromAttributeBuilder and report a different warning message.
21178 2002-07-29 Martin Baulig <martin@gnome.org>
21180 * support.cs (ParameterData.ParameterName): Added method to
21181 get the name of a parameter.
21183 * typemanager.cs (TypeManager.IsValueType): New public method.
21185 2002-07-29 Martin Baulig <martin@gnome.org>
21187 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
21188 is a flag which specifies that it's either ref or out.
21189 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
21190 the out parameter to `out Parameter.Modifier mod', also set the
21191 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
21193 * support.cs (InternalParameters.ParameterModifier): Distinguish
21194 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21195 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21197 * expression.cs (Argument.GetParameterModifier): Distinguish
21198 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
21199 Parameter.Modifier.ISBYREF flag if it's either ref or out.
21201 2002-07-29 Martin Baulig <martin@gnome.org>
21203 * expression.cs (ParameterReference.ParameterReference): Added
21204 `Location loc' argument to the constructor.
21206 * cs-parser.jay: Pass location to ParameterReference.
21208 2002-07-28 Miguel de Icaza <miguel@ximian.com>
21210 * statement.cs (Try): Initialize the location.
21212 * cs-parser.jay: pass location to Try.
21214 * expression.cs (Unary.Reduce): Change the prototype to return
21215 whether a constant fold could be performed or not. The result is
21216 returned in an out parameters. In the case of Indirection and
21217 AddressOf, we want to perform the full tests.
21219 2002-07-26 Miguel de Icaza <miguel@ximian.com>
21221 * statement.cs (Statement.Emit): Flag dead code.
21223 2002-07-27 Andrew Birkett <andy@nobugs.org>
21225 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
21227 2002-07-27 Martin Baulig <martin@gnome.org>
21229 * class.cs (MethodData.Define): Put back call to
21230 TypeManager.AddMethod(), accidentally commented this out.
21232 * report.cs (Debug): New public method to print debugging information,
21233 this is `[Conditional ("DEBUG")]'.
21235 2002-07-26 Martin Baulig <martin@gnome.org>
21237 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
21238 (switch_statement): Push the current_block to the switch_stack and
21239 pop it again when we're done with the switch.
21240 (switch_section): The new block is a child of the current_block.
21241 Fixes bug #24007, added test-152.cs.
21243 2002-07-27 Martin Baulig <martin@gnome.org>
21245 * expression.cs (Invocation.EmitArguments): When calling a varargs
21246 function with only its fixed arguments, we need to pass an empty
21249 2002-07-27 Martin Baulig <martin@gnome.org>
21251 Mono 0.13 has been released.
21253 2002-07-25 Miguel de Icaza <miguel@ximian.com>
21255 * driver.cs: Rename --resource to --linkres, because that is what
21256 we do currently, we dont support --resource yet.
21258 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
21260 2002-07-25 Martin Baulig <martin@gnome.org>
21262 * class.cs (MethodData): New public class. This is a `method builder'
21263 class for a method or one accessor of a Property/Indexer/Event.
21264 (MethodData.GetMethodFlags): Moved here from MemberBase.
21265 (MethodData.ApplyAttributes): Likewise.
21266 (MethodData.ApplyObsoleteAttribute): Likewise.
21267 (MethodData.ApplyConditionalAttribute): Likewise.
21268 (MethodData.ApplyDllImportAttribute): Likewise.
21269 (MethodData.CheckAbstractAndExternal): Likewise.
21270 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
21271 (MethodData.Emit): Formerly known as Method.Emit().
21272 (MemberBase): Moved everything which was specific to a single
21273 accessor/method to MethodData.
21274 (Method): Create a new MethodData and call Define() and Emit() on it.
21275 (Property, Indexer, Event): Create a new MethodData objects for each
21276 accessor and call Define() and Emit() on them.
21278 2002-07-25 Martin Baulig <martin@gnome.org>
21280 Made MethodCore derive from MemberBase to reuse the code from there.
21281 MemberBase now also checks for attributes.
21283 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
21284 (MemberBase.GetMethodFlags): Moved here from class Method and marked
21286 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
21287 `CallingConventions cc' and `Attributes opt_attrs' arguments.
21288 (MemberBase.ApplyAttributes): New virtual method; applies the
21289 attributes to a method or accessor.
21290 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
21291 (MemberBase.ApplyConditionalAttribute): Likewise.
21292 (MemberBase.ApplyDllImportAttribute): Likewise.
21293 (MemberBase.CheckAbstractAndExternal): Likewise.
21294 (MethodCore.ParameterTypes): This is now a property instead of a
21295 method, it's initialized from DoDefineParameters().
21296 (MethodCore.ParameterInfo): Removed the set accessor.
21297 (MethodCore.DoDefineParameters): New protected virtual method to
21298 initialize ParameterTypes and ParameterInfo.
21299 (Method.GetReturnType): We can now simply return the MemberType.
21300 (Method.GetMethodFlags): Override the MemberBase version and add
21301 the conditional flags.
21302 (Method.CheckBase): Moved some code from Define() here, call
21303 DoDefineParameters() here.
21304 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
21305 here to avoid some larger code duplication.
21306 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
21307 ensure that abstract and external accessors don't declare a body.
21309 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
21310 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
21311 lookup in the attribute's parent classes, so we need to abort as soon
21312 as we found the first match.
21313 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
21314 the attribute has no arguments.
21316 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
21319 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21321 * cs-parser.jay: reverted previous patch.
21323 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21325 * cs-parser.jay: fixed bug #22119.
21327 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21329 * attribute.cs: fixed compilation. The error was:
21330 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
21331 be assigned to before control leaves the current method."
21332 [FIXME: Filed as bug #28186: MCS must report this error.]
21334 2002-07-25 Martin Baulig <martin@gnome.org>
21336 * attribute.cs (Attribute.Conditional_GetConditionName): New static
21337 method to pull the condition name ouf of a Conditional attribute.
21338 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
21339 the obsolete message and error flag out of an Obsolete attribute.
21341 * class.cs (Method.GetMethodFlags): New public method to get the
21342 TypeManager.MethodFlags for this method.
21343 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
21345 (Method.Define): Get and apply the Obsolete and Conditional attributes;
21346 if we're overriding a virtual function, set the new private variable
21347 `parent_method'; call the new TypeManager.AddMethod().
21349 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
21350 the MethodBuilder and the Method in a PtrHashtable.
21351 (TypeManager.builder_to_method): Added for this purpose.
21352 (TypeManager.MethodFlags): Added IsObsoleteError.
21353 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
21354 Obsolete and Conditional arguments in MethodBuilders. If we discover
21355 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
21356 the message from the attribute.
21358 2002-07-24 Martin Baulig <martin@gnome.org>
21360 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
21361 preprocessor directives, ensure that the argument to #define/#undef is
21362 exactly one identifier and that it's actually an identifier.
21364 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
21367 2002-07-24 Martin Baulig <martin@gnome.org>
21369 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
21370 initialize it to TypeManager.object_type in the constructor.
21371 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
21372 of the `hm.get_current' method if we're using the collection pattern.
21373 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
21374 for the explicit conversion to make it work when we're using the collection
21375 pattern and the `Current' property has a different return type than `object'.
21378 2002-07-24 Martin Baulig <martin@gnome.org>
21380 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
21381 does not match, but don't report any errors. This method is called in
21382 order for all methods in a MethodGroupExpr until a matching method is
21383 found, so we don't want to bail out if the first method doesn't match.
21384 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
21385 matches, report the 123. Fixes #28070.
21387 2002-07-24 Martin Baulig <martin@gnome.org>
21389 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
21390 TypeManager.TypeToCoreType() to the top of the method so the
21391 following equality checks will work. Fixes #28107.
21393 2002-07-24 Martin Baulig <martin@gnome.org>
21395 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
21396 operand is of type uint, and the other operand is of type sbyte,
21397 short or int, the operands are converted to type long." -
21398 Actually do what this comment already told us. Fixes bug #28106,
21401 2002-07-24 Martin Baulig <martin@gnome.org>
21403 * class.cs (MethodBase): New abstract class. This is now a base
21404 class for Property, Indexer and Event to avoid some code duplication
21405 in their Define() and DefineMethods() methods.
21406 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
21407 generic methods for Define() and DefineMethods().
21408 (FieldBase): Derive from MemberBase, not MemberCore.
21409 (Property): Derive from MemberBase, not MemberCore.
21410 (Property.DefineMethod): Moved all the code from this method to the
21411 new MethodBase.DefineAccessor(), just call it with appropriate
21413 (Property.Define): Call the new Property.DoDefine(), this does some
21414 sanity checks and we don't need to duplicate the code everywhere.
21415 (Event): Derive from MemberBase, not MemberCore.
21416 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
21417 accessors, this will also make them work with interface events.
21418 (Indexer): Derive from MemberBase, not MemberCore.
21419 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
21420 (Indexer.Define): Use the new MethodBase functions.
21422 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
21423 argument to the constructor.
21424 (Interface.FindMembers): Added support for interface events.
21425 (Interface.PopluateEvent): Implemented.
21427 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
21429 2002-07-22 Miguel de Icaza <miguel@ximian.com>
21431 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
21432 but this is required to check for a method name being the same as
21433 the containing class.
21437 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21439 * interface.cs: initialize variable.
21441 2002-07-23 Martin Baulig <martin@gnome.org>
21443 Implemented the IndexerName attribute in interfaces.
21445 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
21446 name if this is an explicit interface implementation.
21447 (Indexer.InterfaceIndexerName): New public variable. If we're
21448 implementing an interface indexer, this is the IndexerName in that
21449 interface. Otherwise, it's the IndexerName.
21450 (Indexer.DefineMethod): If we're implementing interface indexer,
21451 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
21452 and Pending.ImplementIndexer methods.
21453 (Indexer.Define): Also define the PropertyBuilder if we're
21454 implementing an interface indexer and this is neither an explicit
21455 interface implementation nor do the IndexerName match the one in
21458 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
21459 If a method is defined here, then we always need to create a proxy
21460 for it. This is used when implementing interface indexers.
21461 (Pending.IsInterfaceIndexer): New public method.
21462 (Pending.ImplementIndexer): New public method.
21463 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
21464 This is used when implementing interface indexers to define a proxy
21466 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
21467 define a proxy if necessary.
21469 * interface.cs (Interface.IndexerName): New public variable.
21470 (Interface.PopulateIndexer): Set the IndexerName.
21471 (Interface.DefineIndexers): New private method. Populate all the
21472 indexers and make sure their IndexerNames match.
21474 * typemanager.cs (IndexerPropertyName): Added support for interface
21477 2002-07-22 Martin Baulig <martin@gnome.org>
21479 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
21480 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
21481 ret if HasReturnLabel.
21482 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
21485 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
21486 and set the ec.LoopBeginTryCatchLevel.
21487 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
21488 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
21489 the current ec.TryCatchLevel, the branch goes out of an exception
21490 block. In this case, we need to use Leave and not Br.
21492 2002-07-22 Martin Baulig <martin@gnome.org>
21494 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
21495 block unless the block does not always return or it is contained in
21496 another try { ... } catch { ... } block. Fixes bug #26506.
21497 Added verify-1.cs to the test suite.
21499 2002-07-22 Martin Baulig <martin@gnome.org>
21501 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
21502 then we do not always return. Fixes bug #24985.
21504 2002-07-22 Martin Baulig <martin@gnome.org>
21506 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
21507 lookup on a per-class level; ie. walk up the class hierarchy until we
21508 found at least one applicable method, then choose the best among them.
21509 Fixes bug #24463 and test-29.cs.
21511 2002-07-22 Martin Baulig <martin@gnome.org>
21513 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
21514 return types of the methods. The return type is not part of the
21515 signature and we must not check it to make the `new' modifier work.
21516 Fixes bug #27999, also added test-147.cs.
21517 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
21519 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
21520 on the method's return type.
21522 2002-07-21 Martin Baulig <martin@gnome.org>
21524 * assign.cs: Make this work if the rightmost source is a constant and
21525 we need to do an implicit type conversion. Also adding a few more tests
21526 to test-38.cs which should have caught this.
21528 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
21529 target in the makefile for this. The makefile.gnu is primarily intended
21530 for end-users who don't want to debug the compiler.
21532 2002-07-21 Martin Baulig <martin@gnome.org>
21534 * assign.cs: Improved the Assign class so it can now handle embedded
21535 assignments (X = Y = Z = something). As a side-effect this'll now also
21536 consume less local variables. test-38.cs now passes with MCS, added
21537 a few new test cases to that test.
21539 2002-07-20 Martin Baulig <martin@gnome.org>
21541 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
21542 instructions. Fixes bug #27977, also added test-146.cs.
21544 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21546 * cs-tokenizer.cs: fixed getHex ().
21548 2002-07-19 Martin Baulig <martin@gnome.org>
21550 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
21551 not Type.GetType() to lookup the array type. This is needed when
21552 we're constructing an array of a user-defined type.
21553 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
21554 single-dimensional arrays, but also for single-dimensial arrays of
21557 2002-07-19 Martin Baulig <martin@gnome.org>
21559 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
21560 this function is called, it's not allowed to share LocalBuilders
21561 among ILGenerators.
21563 2002-07-19 Martin Baulig <martin@gnome.org>
21565 * expression.cs (Argument.Resolve): Report an error 118 when trying
21566 to pass a type as argument.
21568 2002-07-18 Martin Baulig <martin@gnome.org>
21570 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
21571 Conv_R_Un for the signed `long' type.
21573 2002-07-15 Miguel de Icaza <miguel@ximian.com>
21575 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
21576 `expr' for the temporary result, as that will fail if we do
21577 multiple resolves on the same expression.
21579 2002-07-05 Miguel de Icaza <miguel@ximian.com>
21581 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
21582 ec.TypeContainer for looking up aliases.
21584 * class.cs (TypeContainer): Remove LookupAlias from here.
21586 * decl.cs (DeclSpace); Move here.
21588 2002-07-01 Miguel de Icaza <miguel@ximian.com>
21590 * class.cs (FindMembers): Only call filter if the constructor
21591 bulider is not null.
21593 Also handle delegates in `NestedTypes' now. Now we will perform
21594 type lookups using the standard resolution process. This also
21597 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
21598 This uses Expressions (the limited kind that can be parsed by the
21599 tree) instead of strings.
21601 * expression.cs (ComposedCast.ToString): Implement, used to flag
21602 errors since now we have to render expressions.
21604 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
21607 * ecore.cs (SimpleName.ToString): ditto.
21609 * cs-parser.jay: Instead of using strings to assemble types, use
21610 Expressions to assemble the type (using SimpleName, ComposedCast,
21611 MemberAccess). This should fix the type lookups in declarations,
21612 because we were using a different code path for this.
21614 * statement.cs (Block.Resolve): Continue processing statements
21615 even when there is an error.
21617 2002-07-17 Miguel de Icaza <miguel@ximian.com>
21619 * class.cs (Event.Define): Also remove the `remove' method from
21620 the list of pending items.
21622 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
21623 generate more compact code.
21625 2002-07-17 Martin Baulig <martin@gnome.org>
21627 * const.cs (Const.LookupConstantValue): Add support for constant
21628 `unchecked' and `checked' expressions.
21629 Also adding test case test-140.cs for this.
21631 2002-07-17 Martin Baulig <martin@gnome.org>
21633 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
21634 check whether mi.ReturnType implements the IEnumerator interface; the
21635 `==' and the IsAssignableFrom() will fail in this situation.
21637 2002-07-16 Ravi Pratap <ravi@ximian.com>
21639 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
21642 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21644 * expression.cs: fixed bug #27811.
21646 2002-07-14 Miguel de Icaza <miguel@ximian.com>
21648 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
21649 Molaro: when we are a ref, the value already contains a pointer
21650 value, do not take the address of it.
21652 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
21653 * removed mb-parser.jay and mb-tokenizer.cs
21655 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21657 * expression.cs: check against the building corlib void type.
21659 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
21661 * ecore.cs: fix for valuetype static readonly fields: when
21662 initializing them, we need their address, not the address of a copy.
21664 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
21666 * typemanager.cs: register also enum_type in corlib.
21668 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21670 * class.cs: allow calling this (but not base) initializers in structs.
21672 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
21674 * ecore.cs: make sure we compare against the building base types
21677 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
21679 * typemanager.cs: fix TypeToCoreType() to handle void and object
21680 (corlib gets no more typerefs after this change).
21682 2002-07-12 Miguel de Icaza <miguel@ximian.com>
21684 * expression.cs (ArrayCreation.EmitArrayArguments): use
21685 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
21687 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
21688 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
21689 array indexes, the runtime actually forbids them.
21691 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
21692 for array arguments here.
21694 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
21695 instead of the default for ValueTypes.
21697 (New.DoEmit): Use IsValueType instead of
21698 IsSubclassOf (value_type)
21699 (New.DoResolve): ditto.
21700 (Invocation.EmitCall): ditto.
21702 * assign.cs (Assign): ditto.
21704 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
21705 Statements *are* currently doing part of their resolution during
21708 Expressions do always resolve during resolve, but statements are
21709 only required to propagate resolution to their children.
21711 2002-07-11 Miguel de Icaza <miguel@ximian.com>
21713 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
21715 (LoadAssembly): Do not add the dll if it is already specified
21717 (MainDriver): Add the System directory to the link path at the end,
21718 after all the other -L arguments.
21720 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
21721 wrong opcode for loading bytes and bools (ldelem.i1 instead of
21722 ldelem.u1) and using the opposite for sbytes.
21724 This fixes Digger, and we can finally run it.
21726 * driver.cs (UnixParseOption): Move the option parsing here.
21727 (CSCParseOption): Implement CSC-like parsing of options.
21729 We now support both modes of operation, the old Unix way, and the
21730 new CSC-like way. This should help those who wanted to make cross
21731 platform makefiles.
21733 The only thing broken is that /r:, /reference: and /lib: are not
21734 implemented, because I want to make those have the same semantics
21735 as the CSC compiler has, and kill once and for all the confussion
21736 around this. Will be doing this tomorrow.
21738 * statement.cs (Unsafe.Resolve): The state is checked during
21739 resolve, not emit, so we have to set the flags for IsUnsfe here.
21741 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21743 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
21744 not catch the Error_ObjectRefRequired in SimpleName (as it is
21745 possible to have a class/instance variable name that later gets
21746 deambiguated), we have to check this here.
21748 2002-07-10 Ravi Pratap <ravi@ximian.com>
21750 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
21751 make static and put into Expression.
21753 (Event.Define): Register the private field of the event with the
21754 TypeManager so that GetFieldFromEvent can get at it.
21756 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
21757 keep track of the private field associated with an event which
21760 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
21763 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
21765 2002-07-10 Miguel de Icaza <miguel@ximian.com>
21767 * expression.cs (Binary.EmitBranchable): this routine emits the
21768 Binary expression in a branchable context. This basically means:
21769 we need to branch somewhere, not just get the value on the stack.
21771 This works together with Statement.EmitBoolExpression.
21773 * statement.cs (Statement.EmitBoolExpression): Use
21776 2002-07-09 Miguel de Icaza <miguel@ximian.com>
21778 * statement.cs (For): Reduce the number of jumps in loops.
21780 (For): Implement loop inversion for the For statement.
21782 (Break): We can be breaking out of a Try/Catch controlled section
21783 (foreach might have an implicit try/catch clause), so we need to
21784 use Leave instead of Br.
21786 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
21787 now). If the instace expression supports IMemoryLocation, we use
21788 the AddressOf method from the IMemoryLocation to extract the
21789 address instead of emitting the instance.
21791 This showed up with `This', as we were emitting the instance
21792 always (Emit) instead of the Address of This. Particularly
21793 interesting when This is a value type, as we dont want the Emit
21794 effect (which was to load the object).
21796 2002-07-08 Miguel de Icaza <miguel@ximian.com>
21798 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
21800 * statement.cs (Checked): Set the CheckedState during the resolve
21801 process too, as the ConvCast operations track the checked state on
21802 the resolve process, and not emit.
21804 * cs-parser.jay (namespace_member_declaration): Flag that we have
21805 found a declaration when we do. This is used to flag error 1529
21807 * driver.cs: Report ok when we display the help only.
21809 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
21811 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
21813 2002-07-04 Miguel de Icaza <miguel@ximian.com>
21815 * cs-tokenizer.cs (define): We also have to track locally the
21816 defines. AllDefines is just used for the Conditional Attribute,
21817 but we also need the local defines for the current source code.
21819 2002-07-03 Miguel de Icaza <miguel@ximian.com>
21821 * statement.cs (While, For, Do): These loops can exit through a
21822 Break statement, use this information to tell whether the
21823 statement is the last piece of code.
21825 (Break): Flag that we break.
21827 * codegen.cs (EmitContexts): New `Breaks' state variable.
21829 2002-07-03 Martin Baulig <martin@gnome.org>
21831 * class.cs (TypeContainer.MethodModifiersValid): Allow override
21832 modifiers in method declarations in structs. Otherwise, you won't
21833 be able to override things like Object.Equals().
21835 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21837 * class.cs (Method, Property, Indexer): Do not allow the public
21838 modifier to be used in explicit interface implementations.
21840 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
21841 override modifiers in method declarations in structs
21843 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
21845 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
21846 integer or real overflow, report an error
21848 2002-07-02 Martin Baulig <martin@gnome.org>
21850 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
21851 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
21852 to tell the runtime about our newly created System.Object and
21853 System.ValueType types.
21855 2002-07-02 Miguel de Icaza <miguel@ximian.com>
21857 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
21858 struct instead of Ldarg/Starg.
21860 2002-07-02 Martin Baulig <martin@gnome.org>
21862 * expression.cs (Indirection.Indirection): Call
21863 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
21865 2002-07-02 Martin Baulig <martin@gnome.org>
21867 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
21868 ValueType, call TypeManager.TypeToCoreType() on it.
21869 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
21870 the OpCodes.Newarr argument.
21872 2002-07-02 Martin Baulig <martin@gnome.org>
21874 * expression.cs (Invocation.EmitCall): When compiling corlib,
21875 replace all calls to the system's System.Array type to calls to
21876 the newly created one.
21878 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
21879 System.Array methods.
21880 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
21881 from the system's System.Array type which must be replaced.
21883 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
21885 * typemanager.cs: load unverifiable_code_ctor so we can build
21886 corlib using the correct type. Avoid using GetTypeCode() with
21888 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
21889 TypeManager.object_type to allow building corlib.
21891 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
21893 * ecore.cs: handle System.Enum separately in LoadFromPtr().
21895 2002-07-01 Martin Baulig <martin@gnome.org>
21897 * class.cs: Make the last change actually work, we need to check
21898 whether `ifaces != null' to avoid a crash.
21900 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
21902 * class.cs: when we build structs without fields that implement
21903 interfaces, we need to add the interfaces separately, since there is
21904 no API to both set the size and add the interfaces at type creation
21907 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
21909 * expression.cs: the dimension arguments to the array constructors
21910 need to be converted if they are a long.
21912 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
21914 * class.cs: don't emit ldarg.0 if there is no parent constructor
21915 (fixes showstopper for corlib).
21917 2002-06-29 Martin Baulig <martin@gnome.org>
21919 MCS now compiles corlib on GNU/Linux :-)
21921 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
21922 ie. check for MethodImplOptions.InternalCall.
21924 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
21925 and TypeManager.attribute_type are null, so we must explicitly check
21926 whether parent is not null to find out whether it's an attribute type.
21927 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
21928 and SetBuilder, not only if the property is neither abstract nor external.
21929 This is necessary to set the MethodImplOptions on the accessor methods.
21930 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
21931 SetBuilder, see Property.Emit().
21933 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
21934 populate "System.Object", "System.ValueType" and "System.Attribute" since
21935 they've already been populated from BootCorlib_PopulateCoreTypes().
21937 2002-06-29 Martin Baulig <martin@gnome.org>
21939 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
21940 is the NullLiteral, we also need to make sure that target_type is not
21943 2002-06-29 Martin Baulig <martin@gnome.org>
21945 * rootcontext.cs (RootContext.ResolveCore): We must initialize
21946 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
21947 before calling BootstrapCorlib_ResolveDelegate ().
21949 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21951 * statement.cs: fixed build-breaker. All tests passed ok.
21953 2002-06-27 Martin Baulig <martin@gnome.org>
21955 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
21956 for System.Decimal when compiling corlib.
21958 2002-06-27 Martin Baulig <martin@gnome.org>
21960 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
21961 switch blocks which contain nothing but a default clause.
21963 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
21965 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
21967 2002-06-27 Martin Baulig <martin@gnome.org>
21969 * ecore.cs (PropertyExpr.PropertyExpr): Call
21970 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
21972 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
21973 is already a TypeBuilder.
21975 2002-06-27 Martin Baulig <martin@gnome.org>
21977 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
21978 `target_type == TypeManager.array_type', not IsAssignableFrom() in
21979 the "from an array-type to System.Array" case. This makes it work
21980 when compiling corlib.
21982 2002-06-27 Martin Baulig <martin@gnome.org>
21984 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
21985 non-static PropertyExpr, set its InstanceExpression. This makes
21986 the `ICollection.Count' property work in System/Array.cs.
21988 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
21990 * driver.cs: Made error handling more consistent. Errors now
21991 tracked by Report class, so many methods which used to return int
21992 now return void. Main() now prints success/failure and
21993 errors/warnings message.
21995 Renamed '--probe' compiler argument to '--expect-error'. Removed
21996 the magic number return values (123 and 124). Now, if the
21997 expected error occurs, the compiler exits with success (exit value
21998 0). If the compilation completes without seeing that particular
21999 error, the compiler exits with failure (exit value 1). The
22000 makefile in mcs/errors has been changed to handle the new behaviour.
22002 * report.cs: Made 'expected error' number a property and renamed
22003 it from 'Probe' to 'ExpectedError'.
22005 * genericparser.cs: Removed error handling support, since it is
22006 now all done by Report class.
22008 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
22009 class, so parse() no longer returns an int.
22011 * namespace.cs: Use Report.Error instead of GenericParser.error
22013 2002-06-22 Miguel de Icaza <miguel@ximian.com>
22015 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
22016 TypeContainer.AddOperator): At the front of the list put the
22017 explicit implementations, so they get resolved/defined first.
22019 2002-06-21 Miguel de Icaza <miguel@ximian.com>
22021 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
22022 interface type is implemented by this TypeContainer. Used during
22023 explicit interface implementation.
22025 (Property.Define, Indexer.Define, Method.Define): Validate that
22026 the given interface in the explicit implementation is one of the
22027 base classes for the containing type.
22029 Also if we are explicitly implementing an interface, but there is
22030 no match in the pending implementation table, report an error.
22032 (Property.Define): Only define the property if we are
22033 not explicitly implementing a property from an interface. Use the
22034 correct name also for those properties (the same CSC uses,
22035 although that is really not needed).
22037 (Property.Emit): Do not emit attributes for explicitly implemented
22038 properties, as there is no TypeBuilder.
22040 (Indexer.Emit): ditto.
22042 Hiding then means that we do not really *implement* a pending
22043 implementation, which makes code fail.
22045 2002-06-22 Martin Baulig <martin@gnome.org>
22047 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
22048 the return value of Object.GetType(). [FIXME: we need to do this whenever
22049 we get a type back from the reflection library].
22051 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
22053 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
22055 2002-06-20 Miguel de Icaza <miguel@ximian.com>
22057 * attribute.cs: Return null if we can not look up the type.
22059 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
22060 the interface types found.
22062 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
22063 interface types found.
22065 * typemanager.cs (GetInterfaces): Make this routine returns alll
22066 the interfaces and work around the lame differences between
22067 System.Type and System.Reflection.Emit.TypeBuilder in the results
22068 result for GetInterfaces.
22070 (ExpandInterfaces): Given an array of interface types, expand and
22071 eliminate repeated ocurrences of an interface. This expands in
22072 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
22075 2002-06-21 Martin Baulig <martin@gnome.org>
22077 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
22080 2002-06-21 Martin Baulig <martin@gnome.org>
22082 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
22083 and called with one of the core types, return the corresponding typebuilder for
22086 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
22089 2002-06-21 Martin Baulig <martin@gnome.org>
22091 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
22092 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
22093 (Expression.ConvertReferenceExplicit): Likewise.
22095 * expression.cs (ElementAccess.DoResolve): Likewise.
22096 (ElementAccess.DoResolveLValue): Likewise.
22098 2002-06-10 Martin Baulig <martin@gnome.org>
22100 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
22101 add the "value" parameter to the parameter list.
22103 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
22106 2002-06-19 Miguel de Icaza <miguel@ximian.com>
22108 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
22109 the argument to an int, uint, long or ulong, per the spec. Also
22110 catch negative constants in array creation.
22112 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
22114 * class.cs: do not allow the same interface to appear twice in
22115 the definition list.
22117 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
22119 * ecore.cs: don't use ldlen with System.Array.
22121 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
22123 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
22125 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
22127 * modifiers.cs: produce correct field attributes for protected
22128 internal. Easy fix so miguel can work on ther harder stuff:-)
22130 2002-06-18 Miguel de Icaza <miguel@ximian.com>
22132 * pending.cs: New file. Move the code from class.cs here.
22133 Support clearning the pending flag for all methods (when not doing
22134 explicit interface implementation).
22136 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
22138 * rootcontext.cs: added a couple more types needed to bootstrap.
22140 2002-06-17 Miguel de Icaza <miguel@ximian.com>
22142 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
22143 constructor in the type, instead of any constructor in the type
22144 hierarchy. Thanks to Paolo for finding this bug (it showed up as
22145 a bug in the Mono runtime when applying the params attribute).
22147 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
22148 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
22150 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
22152 * expression.cs (Unary.ResolveOperator): Use TypeManager
22153 to resolve the type.
22155 2002-06-13 Ravi Pratap <ravi@ximian.com>
22157 * cs-parser.jay (enum_member_declaration): Pass in the attributes
22160 * enum.cs (AddEnumMember): Add support to store the attributes associated
22161 with each member too.
22163 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
22164 field builders too - this takes care of the enum member case.
22166 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
22168 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
22169 address-of operator on both value types and pointers.
22171 2002-06-10 Martin Baulig <martin@gnome.org>
22173 * interface.cs (Interface.PopulateIndexer): Add the indexer's
22174 PropertyBuilder to the `property_builders' list.
22176 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
22177 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
22178 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
22179 find any indexers which are inherited from an interface.
22181 2002-06-09 Martin Baulig <martin@gnome.org>
22183 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
22184 the same type as the constant if necessary. There's also a test-130.cs
22187 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
22189 * typemanager.cs (TypeManager.ChangeType): Previously known as
22190 Enum.ChangeEnumType().
22192 2002-06-09 Martin Baulig <martin@gnome.org>
22194 * expression.cs (Cast.TryReduce): Added support for consts.
22196 2002-06-08 Ravi Pratap <ravi@ximian.com>
22198 * class.cs (Accessor): Hold attributes information so we can pass
22201 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
22202 Modify to pass in attributes attached to the methods.
22204 (add_accessor_declaration, remove_accessor_declaration): Ditto.
22206 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
22207 to handle the Accessor kind :-)
22209 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
22211 2002-06-08 Martin Baulig <martin@gnome.org>
22213 * expression.cs (Unary.TryReduceNegative): Added support for
22216 2002-06-08 Martin Baulig <martin@gnome.org>
22218 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
22219 name can't be found in the `defined_names' - the caller will do a
22220 MemberLookup in this case and thus find methods in System.Enum
22221 such as Enum.IsDefined().
22223 2002-06-08 Martin Baulig <martin@gnome.org>
22225 * enum.cs (Enum.ChangeEnumType): This is a custom version of
22226 Convert.ChangeType() which works with TypeBuilder created types.
22227 (Enum.LookupEnumValue, Enum.Define): Use it here.
22229 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
22230 `TypeBuilder.BaseType != null' check.
22231 (TypeContainer.FindMembers): Only lookup parent members if we
22232 actually have a parent.
22233 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
22234 (ConstructorInitializer.Resolve): Likewise.
22236 * interface.cs (Interface.FindMembers): Added
22237 `TypeBuilder.BaseType != null' check.
22239 * rootcontext.cs (RootContext.ResolveCore): Added
22240 "System.Runtime.CompilerServices.IndexerNameAttribute" to
22241 classes_second_stage.
22243 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
22244 debug_type and trace_type when compiling with --nostdlib.
22246 2002-06-07 Martin Baulig <martin@gnome.org>
22248 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
22249 (AddField): Set it to true when adding a non-static field.
22250 (DefineType): Use `have_nonstatic_fields' to find out whether we
22251 have non-static fields, not `Fields != null'.
22253 2002-06-02 Miguel de Icaza <miguel@ximian.com>
22255 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
22256 dereferencing a null on the static-field code path)
22258 2002-05-30 Martin Baulig <martin@gnome.org>
22260 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
22261 to take command line arguments. Use reflection to call the new
22262 custom `Initialize' function on the symbol writer and pass it the
22263 command line arguments.
22265 * driver.cs (--debug-args): New command line argument to pass command
22266 line arguments to the symbol writer.
22268 2002-05-28 Miguel de Icaza <miguel@ximian.com>
22270 * assign.cs (DoResolve): Forgot to do the implicit conversion to
22271 the target type for indexers and properties. Thanks to Joe for
22274 2002-05-27 Miguel de Icaza <miguel@ximian.com>
22276 * typemanager.cs (MethodFlags): returns the method flags
22277 (Obsolete/ShouldIgnore) that control warning emission and whether
22278 the invocation should be made, or ignored.
22280 * expression.cs (Invocation.Emit): Remove previous hack, we should
22281 not do this on matching a base type, we should do this based on an attribute
22283 Only emit calls to System.Diagnostics.Debug and
22284 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
22285 on the command line.
22287 * rootcontext.cs: Global settings for tracing and debugging.
22289 * cs-tokenizer.cs (define): New utility function to track
22290 defines. Set the global settings for TRACE and DEBUG if found.
22292 2002-05-25 Ravi Pratap <ravi@ximian.com>
22294 * interface.cs (Populate*): Pass in the TypeContainer as well as
22295 the DeclSpace as parameters so that we can create EmitContexts and
22296 then use that to apply attributes etc.
22298 (PopulateMethod, PopulateEvent, PopulateProperty)
22299 (PopulateIndexer): Apply attributes everywhere.
22301 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
22304 (ApplyAttributes): Update accordingly.
22306 We now apply interface attributes for all members too.
22308 2002-05-26 Miguel de Icaza <miguel@ximian.com>
22310 * class.cs (Indexer.Define); Correctly check if we are explicit
22311 implementation (instead of checking the Name for a ".", we
22312 directly look up if the InterfaceType was specified).
22314 Delay the creation of the PropertyBuilder.
22316 Only create the PropertyBuilder if we are not an explicit
22317 interface implementation. This means that explicit interface
22318 implementation members do not participate in regular function
22319 lookups, and hence fixes another major ambiguity problem in
22320 overload resolution (that was the visible effect).
22322 (DefineMethod): Return whether we are doing an interface
22325 * typemanager.cs: Temporary hack until we get attributes in
22326 interfaces (Ravi is working on that) and we get IndexerName
22327 support in interfaces.
22329 * interface.cs: Register the indexers as properties.
22331 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
22332 warning, I have verified that this is a bug in the .NET runtime
22333 (JavaScript suffers of the same problem).
22335 * typemanager.cs (MemberLookup): When looking up members for
22336 interfaces, the parent of an interface is the implicit
22337 System.Object (so we succeed in searches of Object methods in an
22338 interface method invocation. Example: IEnumerable x; x.ToString
22341 2002-05-25 Miguel de Icaza <miguel@ximian.com>
22343 * class.cs (Event): Events should also register if they do
22344 implement the methods that an interface requires.
22346 * typemanager.cs (MemberLookup); use the new GetInterfaces
22349 (GetInterfaces): The code used to lookup interfaces for a type is
22350 used in more than one place, factor it here.
22352 * driver.cs: Track the errors at the bottom of the file, we kept
22355 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
22356 instance if the method we are calling is static!
22358 2002-05-24 Miguel de Icaza <miguel@ximian.com>
22360 * attribute.cs (ApplyAttributes): Make this function filter out
22361 the IndexerName attribute (as that attribute in reality is never
22362 applied) and return the string constant for the IndexerName
22365 * class.cs (TypeContainer.Emit): Validate that all the indexers
22366 have the same IndexerName attribute, and if so, set the
22367 DefaultName attribute on the class.
22369 * typemanager.cs: The return value might contain other stuff (not
22370 only methods). For instance, consider a method with an "Item"
22371 property and an Item method.
22373 * class.cs: If there is a problem with the parameter types,
22376 2002-05-24 Ravi Pratap <ravi@ximian.com>
22378 * ecore.cs (ImplicitConversionExists): Wrapper function which also
22379 looks at user defined conversion after making a call to
22380 StandardConversionExists - we need this for overload resolution.
22382 * expression.cs : Update accordingly the various method calls.
22384 This fixes 2 bugs filed against implicit user defined conversions
22386 2002-05-22 Miguel de Icaza <miguel@ximian.com>
22388 * statement.cs: Track the result of the assignment.
22390 2002-05-21 Miguel de Icaza <miguel@ximian.com>
22392 * expression.cs (MemberAccess): Improved error reporting for
22393 inaccessible members.
22395 2002-05-22 Martin Baulig <martin@gnome.org>
22397 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
22398 itself with debugging support.
22400 2002-05-22 Martin Baulig <martin@gnome.org>
22402 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
22403 Removed, this isn't needed anymore.
22405 2002-05-20 Martin Baulig <martin@gnome.org>
22407 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
22408 be underlying type for an enum.
22410 2002-05-20 Miguel de Icaza <miguel@ximian.com>
22412 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
22413 that splits out the loading of just the core types.
22415 * rootcontext.cs (ResolveCore): Split the struct resolution in
22416 two, so we can load the enumeration underlying types before any
22419 * expression.cs (Is): Bandaid until we fix properly Switch (see
22420 bug #24985 for details).
22422 * typemanager.cs (ImplementsInterface): The hashtable will contain
22423 a null if there are no interfaces implemented.
22425 2002-05-18 Miguel de Icaza <miguel@ximian.com>
22427 * cs-parser.jay (indexer_declarator): It is fine to have array
22430 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22432 * typemanager.cs: (RegisterBuilder): New function used to register
22433 TypeBuilders that implement interfaces. Since
22434 TypeBuilder.GetInterfaces (as usual) does not work with lame
22436 (AddUserType): register interfaces.
22438 (ImplementsInterface): Use the builder_to_ifaces hash if we are
22439 dealing with TypeBuilder. Also, arrays are showing up as
22440 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
22441 methods can not be invoked on them!
22443 * ecore.cs (ExplicitReferenceConversionExists): Made public.
22444 (ImplicitReferenceConversionExists): Split out from
22445 StandardConversionExists.
22447 * expression.cs (As): We were only implementing one of the three
22448 cases for the as operator. We now implement them all.
22449 (Is): Implement the various other cases for Is as well.
22451 * typemanager.cs (CACHE): New define used to control if we want or
22452 not the FindMembers cache. Seems to have a negative impact on
22453 performance currently
22455 (MemberLookup): Nested types have full acess to
22456 enclosing type members
22458 Remove code that coped with instance/static returns for events, we
22459 now catch this in RealFindMembers.
22461 (RealFindMembers): only perform static lookup if the instance
22462 lookup did not return a type or an event.
22464 2002-05-17 Miguel de Icaza <miguel@ximian.com>
22466 * assign.cs (CompoundAssign): We pass more semantic information
22467 now to Compound Assignments than we did before: now we have all
22468 the information at hand, and now we resolve the target *before* we
22469 do the expression expansion, which allows the "CacheValue" method
22470 to have the effect we intended (before, a [x] += 1 would generate
22471 two differen ArrayAccess expressions from the ElementAccess,
22472 during the resolution process).
22474 (CompoundAssign.DoResolve): Resolve target and original_source here.
22476 2002-05-16 Miguel de Icaza <miguel@ximian.com>
22478 * expression.cs (ArrayAccess): dropped debugging information.
22480 * typemanager.cs: Small bug fix: I was always returning i_members,
22481 instead of one of i_members or s_members (depending on which had
22484 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
22485 method is invoked before any code generation takes place, and it
22486 is a mechanism to inform that the expression will be invoked more
22487 than once, and that the method should use temporary values to
22488 avoid having side effects
22490 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
22492 * ecore.cs (Expression.CacheTemporaries): Provide empty default
22495 * expression.cs (Indirection, ArrayAccess): Add support for
22496 CacheTemporaries in these two bad boys.
22498 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
22499 ldobj or ldind_ref.
22500 (StoreFromPtr): Handle stobj as well.
22502 * expression.cs (UnaryMutator): Share more code.
22504 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
22505 down: I was not tracking the Filter function as well, which
22506 was affecting the results of the cache.
22508 2002-05-15 Miguel de Icaza <miguel@ximian.com>
22510 * attribute.cs: Remove the hack to handle the CharSet property on
22513 2002-05-14 Miguel de Icaza <miguel@ximian.com>
22515 * attribute.cs (DoResolve): More uglyness, we now only try to
22516 resolve the attribute partially, to extract the CharSet
22517 information (only if we are a StructLayout attribute). Otherwise
22519 (GetExtraTypeInfo): Add some code to conditionally kill in the
22520 future this. I am more and more convinced that the .NET
22521 framework has special code to handle the attribute setting on
22524 * expression.cs (IsParamsMethodApplicable): Revert my previous
22525 foreach change here, it was wrong.
22527 2002-05-13 Miguel de Icaza <miguel@ximian.com>
22529 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
22530 (pp_expr): do not abort on unknown input, just return.
22531 (eval): abort if there are pending chars.
22533 * attribute.cs (Attribute.Resolve): Positional parameters are
22534 optional. Deal with that case.
22536 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
22537 the Ansi/Unicode/Auto information for the type.
22539 (TypeContainer.DefineType): instantiate the EmitContext here, as
22540 we will be using it during the type definition (to resolve
22541 attributes) and during the emit phase.
22543 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
22544 to pull type information out of the attributes
22546 (Attribute.Resolve): track the constructor builder, and allow for
22547 multiple invocations (structs and classes will use this).
22549 * ecore.cs (MemberLookupFinal): new version with all the
22550 parameters customizable.
22552 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
22553 constructors. Return if the result value is null (as the error
22554 would have been flagged already by MemberLookupFinal)
22556 Do not allow instances of abstract classes or interfaces to be
22559 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
22560 We have to compare the assembly property here when dealing with
22561 FamANDAssem and Assembly access modifiers, because we might be
22562 creating an assembly from *modules* (that means that we are not
22563 getting TypeBuilders for types defined in other modules that are
22564 part of this assembly).
22566 (Method.Emit): If the method is marked abstract and has a body,
22569 (TypeContainer.DefineMembers): If both the defined member and the
22570 parent name match are methods, then do not emit any warnings: let
22571 the Method.Define routine take care of flagging warnings. But if
22572 there is a mismatch (method overrides something else, or method is
22573 overriwritten by something, then emit warning).
22575 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
22576 set to null, this means `do not check for the return type on the
22579 (Method.Define): set the return type for the method signature to
22580 null, so that we get methods with the same name and parameters and
22581 different return types. This is used to flag warning 114 (you are
22582 hiding a method, and you probably want to use the new/override
22585 * typemanager.cs (MemberLookup): Implemented proper access
22586 control, closing a long standing set of bug reports. The problem
22587 was that the Framework only has two bits: Public and NonPublic,
22588 and NonPublic includes private and protected methods, but we need
22589 to enforce the FamANDAssem, FamOrAssem and Family.
22591 2002-05-11 Miguel de Icaza <miguel@ximian.com>
22593 * statement.cs (GotoCase): Return true: Ammounts to giving up
22594 knowledge on whether we return or not, and letting the other case
22595 be responsible for it.
22597 2002-05-10 Miguel de Icaza <miguel@ximian.com>
22599 * driver.cs: Do not load directories for each file processed, only
22600 do it if there is a pattern.
22602 * ecore.cs: Report readonly assigns here as well, as we might have
22603 been resolved only by MemberAccess.
22605 (SimpleName.SimpleNameResolve): Also be useful for LValue
22606 resolution. We need this to propagate assign to local readonly variables
22608 * typemanager.cs: Use a ptrhashtable for the criteria, because we
22609 do not want to reuse potential criteria memory.
22611 * class.cs (MyEventBuilder): Set reflected_type;
22613 * ecore.cs (Constantify): Added support for constifying bools.
22615 (RootContext.LookupType): Added a cache for values looked up in
22616 the declaration space.
22618 * typemanager.cs (FindMembers): Now is a front-end to
22619 RealFindMembers, and provides a two-level hashtable-based cache to
22622 15% performance improvement: from 22.5 to 19.2 seconds.
22624 * expression.cs (IsParamsMethodApplicable): use foreach.
22625 (Invocation.DoResolve): ditto.
22626 (New.DoResolve): ditto.
22627 (ArrayCreation.DoResolve): ditto.
22629 * ecore.cs (FindMostEncompassingType): use foreach.
22631 * delegate.cs (NewDelegate.DoResolve): Use foreach
22633 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
22634 (RemoveMethods): use foreach.
22636 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
22637 nested foreach statements instead of for, and also break out of
22638 the inner loop once a match is found.
22640 (Invocation.OverloadResolve): Use foreach, simplify the code.
22642 2002-05-08 Miguel de Icaza <miguel@ximian.com>
22644 * cfold.cs (BinaryFold): During an enumeration evaluation context,
22645 we actually unwrap the expression to allow for extra information
22648 * expression.cs: Use Shr_Un on unsigned operations.
22650 2002-05-08 Ravi Pratap <ravi@ximian.com>
22652 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
22653 applicable operators was not being considered correctly. This closes
22654 the bug Miguel reported.
22656 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
22658 * attribute.cs: check that the type derives from System.Attribute
22659 and report the correct error in that case (moved the duplicate code to
22660 its own method, too).
22662 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
22664 * attribute.cs: lookup attribute type name as the spec says: first the
22665 bare attribute name and then name + "Attribute" (nant compiles with
22666 mcs after this fix).
22668 2002-05-07 Miguel de Icaza <miguel@ximian.com>
22670 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
22671 Because of the way we parse things, we should try to see if a
22672 UIntConstant can fit in an integer.
22674 2002-05-07 Ravi Pratap <ravi@ximian.com>
22676 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
22677 when we are in an explicit context.
22679 (ConvertReferenceExplicit): When converting from Iface type S to Class
22680 T make sure the rules are implemented as an OR.
22682 * parameter.cs (ParameterType): Make it a property for now although the
22683 purpose really isn't anything immediate.
22685 * expression.cs (Is*Applicable): Do better checking on the parameter type
22686 of a ref/out parameter. The ones from the system assemblies are already
22687 marked with the correct type so we don't need to do any correction.
22689 * ecore.cs (StandardConversionExists): Conversion from Interface types to
22690 the object type is standard too so include that.
22692 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22694 * ecore.cs (StandardConversionExists): Augment with missing code:
22695 deal with IntConstant, LongConstants and Enumerations.
22697 * assign.cs: Report the error, instead of failing silently
22699 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
22700 typecontainer that they are declared, because the
22701 typecontainer/namespace will have the list of using clauses that
22702 need to be applied.
22704 Assembly Attributes were escaping the normal registration
22707 (EmitCode): Apply attributes within an EmitContext that represents
22708 the container they were declared on.
22710 * cs-parser.jay: Track bases for structs. How did I get this wrong?
22712 2002-05-06 Ravi Pratap <ravi@ximian.com>
22714 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
22715 Revamp completely - make much cleaner as we now operate only
22718 (FindMostSpecificSource, FindMostSpecificTarget): New methods
22719 to implement the logic detailed in the spec more correctly.
22721 (UserDefinedConversion): Update accordingly.
22723 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22725 * statement.cs: Return flow analysis information up.
22727 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
22730 (token): Do not consume an extra character before calling
22733 2002-05-06 Piers Haken <piersh@friskit.com>
22735 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
22737 2002-05-06 Miguel de Icaza <miguel@ximian.com>
22739 * class.cs (Constructor.Emit): Set the IsStatic flag in the
22740 EmitContext during the instance constructor initializer
22741 resolution, to stop access to instance variables.
22743 This is mandated by the spec, last paragraph of the `constructor
22744 initializers' section.
22746 2002-05-05 Miguel de Icaza <miguel@ximian.com>
22748 * cs-parser.jay, class.cs (Accessor): new class used to represent
22749 an accessor (get or set). In the past we used `null' to represent
22750 a missing accessor. But this is ambiguous because there was no
22751 way to tell in abstract indexers/properties if one of them was
22754 Now there is a way of addressing that.
22756 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
22757 instead of FindMembers.
22759 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
22760 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
22762 * attribute.cs: Treat indexers and properties as the same in terms
22763 of applying attributes
22765 * ecore.cs (FindMostEncompassedType): Use statically initialized
22766 EmptyExpressions()s like we do elsewhere to avoid creating useless
22767 objects (and we take this out of the tight loop).
22769 (GetConversionOperators): Move the code to extract the actual
22770 operators to a separate routine to clean things up.
22772 2002-05-04 Miguel de Icaza <miguel@ximian.com>
22774 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
22775 events are always registered FieldBuilders.
22777 * class.cs (FieldBase): New class shared by Fields
22779 * delegate.cs: If we are a toplevel delegate, use our full name.
22780 If we are a nested delegate, then only use our tail name.
22782 2002-05-02 Ravi Pratap <ravi@ximian.com>
22784 * expression.cs (IsApplicable): Ensure that we add the "&" to
22785 ref/out types before comparing it with the type of the argument.
22787 (IsParamsMethodApplicable): Ditto.
22789 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
22792 * delegate.cs : Handle the case when we have more than one applicable
22793 method. Flag an error only when we finish checking all.
22795 2002-05-02 Miguel de Icaza <miguel@ximian.com>
22797 * expression.cs: Add support for boolean static initializers.
22799 2002-05-01 Miguel de Icaza <miguel@ximian.com>
22801 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
22803 * parameter.cs (ComputeParameterTypes,
22804 ComputeAndDefineParameterTypes): Better error handling: now we
22805 clear the `types' cache if we fail during any of the type lookups.
22806 We also return the status code correctly to our caller
22808 * delegate.cs: If we fail to define a delegate, abort the extra
22811 * expression.cs (Binary.ResolveOperator): for
22812 operator==(object,object) and operator !=(object, object) we also
22813 have to verify that there is an implicit conversion from one to
22816 (ArrayAccess.DoResolve): Array Access can operate on
22819 2002-04-30 Miguel de Icaza <miguel@ximian.com>
22821 * assign.cs (CompoundAssign): A new class used as a "flag" that
22822 the assignment actually is happening as part of a compound
22823 assignment operator.
22825 During compound assignment, a few new rules exist to enable things
22832 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
22833 to the type of x) if y is implicitly convertible to the type of x,
22834 and the operator is a builtin operator and the return type of the
22835 operator is explicitly convertible to the type of x.
22837 * rootcontext.cs: Reset warning level to 2. 4 catches various
22838 "interesting" features in mcs, we must clean this up at some
22839 point, but currently am trying to kill other bugs ;-)
22841 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
22842 in container classes as well.
22844 * expression.cs (Binary.ResolveOperator): Handle string case
22845 before anything else (as operator overloading does emit an error
22846 before doing anything else).
22848 This code could go away when we move to a table driven model, but
22849 i could not come up with a good plan last night.
22851 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
22853 * typemanager.cs (CSharpName): reimplementation using regex.
22854 * class.cs: added null check for fields in Emit
22855 * rootcontext.cs: set warninglevel to 4
22857 2002-04-29 Miguel de Icaza <miguel@ximian.com>
22859 * typemanager.cs (CSharpName): reimplemented with Lupus
22862 2002-04-28 Miguel de Icaza <miguel@ximian.com>
22864 * statement.cs (If): correclty implement Resolve, because we were
22865 not catching sem errors in there. The same process is needed
22867 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
22870 (Statement.Warning_DeadCodeFound): Factorize code.
22871 (While): Report dead code here too.
22873 (Statement): Added Resolve virtual method to allow
22874 for resolution split from the emit code.
22876 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22878 * statement.cs (EmitBoolExpression): No longer try to resolve the
22880 (MakeBoolean): New utility function that resolve, implicitly
22881 converts to boolean and tags the expression.
22884 (If, Do): Implement dead code elimination.
22885 (While): Implement loop inversion
22887 (Do, While, For, If): Resolve the expression prior to calling our
22890 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
22893 - added method Report28 (warning: program has more than one entry point)
22894 - added method IsEntryPoint, implements paragraph 10.1 of the spec
22895 - modified method Method.Define, the part at the end of the method
22897 * rootcontext.cs: added static public Location EntryPointLocation;
22899 * ../errors/cs0028.cs : Add test case for the above warning.
22902 - modified method CSharpName to allow arrays of primitive type to
22903 be printed nicely (e.g. instead of System.Int32[][] it now prints
22905 - added method CSharpSignature: returns the signature of a method
22906 in string format to be used in reporting errors, warnings, etc.
22908 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
22911 2002-04-26 Ravi Pratap <ravi@ximian.com>
22913 * delegate.cs (Define): Fix extremely silly bug where I was
22914 setting the type of the 'object' parameter of the BeginInvoke
22915 method to System.IAsyncResult instead of System.Object ;-)
22917 2002-04-26 Miguel de Icaza <miguel@ximian.com>
22919 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
22922 (Constructor.Emit): return if we fail to initialize the
22923 constructor. Another door closed!
22925 * expression.cs (New.DoResolve): Improve error message (from -6 to
22926 1501). Use DeclaredOnly lookup to find the exact constructor.
22928 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
22929 loop. This is useful.
22931 * cs-parser.jay: Adjust the default parameters so that destructors
22932 have the proper signature.
22934 2002-04-26 Martin Baulig <martin@gnome.org>
22936 * driver.cs (LoadAssembly): If `assembly' contains any characters
22937 which are only valid in path names and not in assembly names
22938 (currently slash, backslash and point), use Assembly.LoadFrom ()
22939 instead of Assembly.Load () on the `assembly' (before iteration
22940 over the link_paths).
22942 2002-04-26 Martin Baulig <martin@gnome.org>
22944 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
22946 2002-04-25 Miguel de Icaza <miguel@ximian.com>
22948 * class.cs (Property): use the new typemanager.MemberLookup
22950 (TypeContainer.MemberLookup): Implement using the
22951 TypeManager.MemberLookup now.
22953 * typemanager.cs: Make MemberLookup a function of the TypeManager,
22954 and return MemberInfos, so that these can be used without an
22955 EmitContext (what we had before).
22957 2002-04-24 Miguel de Icaza <miguel@ximian.com>
22959 * expression.cs: Fix the case where the argument to params if the
22960 type of the params. I omitted handling this before. Fixed
22962 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22964 * driver.cs: Call BootCorlib_PopulateCoreType
22966 * class.cs (Property.CheckBase): Check for properties only, not
22969 * interface.cs: Temporary hack: try/catch around the
22970 CustomAttributeBuilder, because I am getting an exception that I
22973 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
22974 types whose definitions are required to be there (attributes are
22975 defined before standard types).
22977 Compute definitions as we boot the various types, as they are used
22978 immediately (value_type class will need object_type, but if we do
22979 not initialize object_type, we will pass a null, which will let
22980 the runtime pick the System.Object from the existing corlib, which
22981 is not what we want).
22983 2002-04-22 Patrik Torstensson <totte@labs2.com>
22985 * cs-tokenizer.cs: fixed a number of trim() issues.
22987 2002-04-22 Ravi Pratap <ravi@ximian.com>
22989 * expression.cs (Argument.Type): Ensure that we return the correct
22990 type when we have out or ref parameters [in which case we
22993 2002-04-22 Miguel de Icaza <miguel@ximian.com>
22995 * class.cs (Property, Indexer): Allow extern modifier in there.
22997 * typemanager.cs (InitBaseTypes): Initializes object_type and
22998 value_type, since those will be used early on during the bootstrap
22999 process to compile corlib.
23001 (InitCoreTypes): Move code from here to InitBaseTypes.
23003 2002-04-21 Miguel de Icaza <miguel@ximian.com>
23005 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
23006 single-dimension arrays as using the ldlen opcode.
23008 Daniel Lewis discovered this optimization.
23010 * typemanager.cs: Add signature for System.Array::get_Length
23012 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23014 * statement.cs: report the error when the foreach does not apply to an
23015 array nor a collection.
23017 2002-04-19 Miguel de Icaza <miguel@ximian.com>
23019 * expression.cs: Add implicit conversions to the operator ~.
23021 * constant.cs (DecimalConstant.Emit): Emit decimal value.
23023 * typemanager.cs: Locate the decimal constructor.
23025 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23027 * attribute.cs: use the new property of TypeOf.
23028 * expression.cs: added 'get' property around typearg.
23030 These changes fix a build breaker reported by NickD. Is this the
23031 correct way to fix? If not, please, revert my changes and make it
23034 2002-04-17 Miguel de Icaza <miguel@ximian.com>
23036 * attribute.cs: Add support for typeof in attribute invocations.
23037 I am not sure that this is right though.
23039 2002-04-14 Duncan Mak <duncan@ximian.com>
23041 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
23042 Binary.Operator.Division case.
23044 2002-04-13 Ravi Pratap <ravi@ximian.com>
23046 * class.cs (DefineType): Ensure that we do a proper check on
23047 attribute types and also register it with the TypeManager.
23049 (TypeContainer.Targets): The default for attribute types is
23050 AttributeTargets.All.
23052 * attribute.cs (ApplyAttributes): Registering the attribute type
23053 is done elsewhere, not when we discover we have a Usage attribute.
23055 2002-04-12 Ravi Pratap <ravi@ximian.com>
23057 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
23058 and get rid of is_delegate parameter.
23060 * everywhere : update.
23062 2002-04-12 Ravi Pratap <ravi@ximian.com>
23064 * cs-parser.jay (compilation_unit): Revamp completely to use
23065 some new ideas that I got from Rhys' grammar to solve the problems
23066 with assembly level attributes.
23068 (outer_declaration): New grammar production.
23070 (attribute_sections): Add.
23072 (opt_attributes): Base on attribute_sections
23074 (namespace_declaration): Allow opt_attributes to tackle the case
23075 when we have assembly level attributes - we are clever in this
23078 * attribute.cs (ApplyAttributes): Do not worry about assembly
23079 attributes in the non-global context.
23081 * rootcontext.cs (AddGlobalAttributes): Go back to using this
23082 instead of SetGlobalAttributes.
23084 * class.cs, rootcontext.cs : Ensure we define and generate
23085 attribute types before anything else.
23087 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
23088 and flag the new error -20 for the case when the attribute type
23089 does not have valid targets specified. csc does not catch this.
23091 * ../errors/errors.txt : update for error # -20
23093 2002-04-11 Ravi Pratap <ravi@ximian.com>
23095 * support.cs (InternalParameters.ParameterModifier): Do some null
23096 checking and return sane values.
23098 * class.cs (Method.Define): If we are a PInvoke method, ensure
23099 that we are static and extern. Report error # 601
23101 * ../errors/cs0601.cs : Add test case for the above error.
23103 2002-04-07 Ravi Pratap <ravi@ximian.com>
23105 * rootcontext.cs (attribute_types): We need to keep type of
23106 all attribute types separately and emit code for them first.
23108 (RegisterAttribute) : Implement.
23110 * class.cs (DefineType): Check if the current Type is a custom
23111 attribute type and register it accordingly.
23113 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
23114 adding the first attribute twice and rename to
23116 (SetGlobalAttributes): this.
23118 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
23121 * attribute.cs (ApplyAttributes): Take an additional argument telling us
23122 if we are processing global arguments. Hmm, I am unsure of this.
23124 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23126 * expression.cs: added static array of strings to avoid calling
23127 Enum.ToString () for Operator in Binary. Significant recover of
23130 2002-04-10 Miguel de Icaza <miguel@ximian.com>
23132 * class.cs (FindMembers): Allow the Builders of the various
23133 members to be null. If they are skip them. This only happens
23134 during the PInvoke declaration.
23136 2002-04-09 Miguel de Icaza <miguel@ximian.com>
23138 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
23139 failure, so we do not keep going afterwards.
23141 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
23142 wanted to pass `false' as the `is_delegate' argument. If this is
23143 the case, why not use delegate_type == null to mean `is_delegate =
23144 false' and anything else as is_delegate = true.
23146 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
23148 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
23149 code for the section, not the beginning of the tests.
23151 2002-04-08 Miguel de Icaza <miguel@ximian.com>
23153 * cfold.cs: Handle operator + (Enum x, Underlying x)
23155 * expression.cs (Binary): same. Warn about errors where we have
23156 Enum/Enum in operator + as well.
23158 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
23161 - added support for switch(bool)
23162 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
23163 - add TableSwitchEmit() to handle table-based switch statements
23165 2002-04-05 Ravi Pratap <ravi@ximian.com>
23167 * expression.cs (Invocation.OverloadResolve): Factor out code which
23168 does parameter compatibility checking with arguments so that we can
23169 re-use the code even from Delegate.VerifyApplicability
23171 (VerifyArgumentsCompat): Move above code here.
23173 * delegate.cs (VerifyApplicability): Get rid of duplicate code
23174 and instead make a call to the above method.
23176 2002-03-31 Ravi Pratap <ravi@ximian.com>
23178 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
23179 We use it to keep track of classes which are attribute types.
23181 2002-04-02 Miguel de Icaza <miguel@ximian.com>
23183 * delegate.cs (Delegate.Define): Correctly define the types in the
23184 presence of fixed and array parameters.
23186 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
23189 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
23190 include NonPublic after the first iteration.
23192 * class.cs (Indexer.CheckBase): Only check if both parents are
23195 * cs-parser.jay (accessor_body): If empty, set to null.
23197 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
23198 same code path here to resolve constants names that we did have in
23199 MemberAccess.DoResolve. There is too much code duplicated here.
23201 2002-04-01 Miguel de Icaza <miguel@ximian.com>
23203 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
23205 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
23208 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
23209 tokens, numbers and strings.
23211 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
23214 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
23215 asyncronous parameters and the regular parameters.
23217 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
23218 specify the target directory.
23220 * expression.cs: (This.DoResolve): Simplify
23221 (As.Emit): Optimize, do not generate IsInst if the expression is
23222 always of the given type.
23224 (Is.DoResolve): Bug fix, we were reporting both always/never for
23227 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
23228 creating too many unnecessary arrays.
23230 2002-03-31 Miguel de Icaza <miguel@ximian.com>
23232 * class.cs (EmitFieldInitializer): Use Assign expression to assign
23233 fields instead of rolling our own initializer. Takes care of all
23234 implicit conversions, and drops unnecessary static checks/argument.
23236 2002-03-31 Dick Porter <dick@ximian.com>
23238 * driver.cs: use the GetDirectories() return values properly, and
23239 use "/" as path separator.
23241 2002-03-30 Miguel de Icaza <miguel@ximian.com>
23243 * expression.cs (Unary): Optimize - - expr into expr.
23244 (Binary): Optimize a + (-b) into a -b.
23246 * codegen.cs (CodeGen): Made all methods static.
23248 2002-03-29 Miguel de Icaza <miguel@ximian.com>
23252 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
23253 TypeBuilder property.
23255 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
23258 * tree.cs: Removed the various RecordXXXX, and replaced with a
23259 single RecordDecl. Removed all the accessor methods, and just
23260 left a single access point Type
23262 * enum.cs: Rename DefineEnum to DefineType.
23264 * decl.cs: New abstract method `DefineType' used to unify the
23265 Defines for Enumerations, Interfaces, TypeContainers and
23268 (FindType): Moved LookupInterfaceOrClass here. Moved the
23269 LookupBaseClasses method that used to live in class.cs and
23270 interface.cs here, and renamed to FindType.
23272 * delegate.cs: Implement DefineType. Take advantage of the
23273 refactored pattern for locating the parent builder without taking
23274 the parent_builder argument (which we know does not work if we are
23275 nested, and triggering a toplevel definition).
23277 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23279 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
23280 accessibility of a member has changed during override and report
23283 * class.cs (Method.Define, Property.Define): Only complain on
23284 overrides if the method is private, any other accessibility is
23285 fine (and since we just checked the permission is the same, we are
23288 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
23289 and elif are processed always. The other pre-processing
23290 directives are only processed if we are "taking" the path
23292 2002-03-29 Martin Baulig <martin@gnome.org>
23294 * class.cs (Method.Emit): Only emit symbolic debugging info if the
23295 current location is not Null.
23297 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
23298 a separate method so we can profile it.
23300 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
23301 `span.Seconds' are just seconds, but no minutes or hours.
23302 (MainDriver): Profile the CodeGen.SaveSymbols calls.
23304 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23306 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
23307 Remove the gratuitous set of Final:
23309 // If an interface implementation, then we can set Final.
23310 if (((flags & MethodAttributes.Abstract) == 0) &&
23311 implementing.DeclaringType.IsInterface)
23312 flags |= MethodAttributes.Final;
23314 I do not know what I was smoking when I used that.
23317 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
23318 step into fixing the name resolution issues for delegates and
23319 unifying the toplevel name resolution.
23321 2002-03-28 Martin Baulig <martin@gnome.org>
23323 * class.cs (Method.Emit): If we have a symbol writer, call its
23324 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
23325 tell it about the current method.
23327 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
23328 writer that we're going to emit the first byte of IL code for a new
23329 statement (a new source line).
23330 (EmitContext.EmitTopBlock): If we have a symbol writer, call
23331 EmitContext.Mark() before emitting any code.
23333 * location.cs (SymbolDocument): Return null when we're Null.
23335 * statement.cs (Statement): Moved the `Location loc' variable here.
23336 (Statement.EmitBoolExpression): If we have a symbol writer, call
23337 ec.Mark() before emitting any code to tell it that we're at the
23338 beginning of a new statement.
23339 (StatementExpression): Added `Location' argument to the constructor.
23340 (Block): Added public readonly variable `StartLocation' and public
23341 variable `EndLocation'. The latter is to be set using SetEndLocation().
23342 (Block): Added constructor which takes a start and end location.
23343 (Block.SetEndLocation): New method. This sets the end location.
23344 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
23345 local variables we create.
23346 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
23347 each statement and do also mark the begin and end of the block.
23349 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
23350 tell it the current lexer.Location, use Location.Null for the end of the
23352 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
23353 current block, set its end location using SetEndLocation().
23354 (statement_expression): StatementExpression constructor now takes the
23355 lexer.Location as additional argument.
23356 (for_statement, declare_local_variables): Likewise.
23357 (declare_local_variables): When creating a new implicit block, use the
23358 new Block constructor and pass it the lexer.Location.
23360 2002-03-28 Miguel de Icaza <miguel@ximian.com>
23362 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
23363 members also on the parent interfaces recursively.
23365 2002-03-27 Miguel de Icaza <miguel@ximian.com>
23367 * report.cs: Use new formats, since Gonzalo finished the missing
23370 * expression.cs (Binary.ResolveOperator): added missing operator|
23371 operator& and operator^ for bool/bool.
23373 * cs-parser.jay: CheckDef now takes a Location argument that is
23374 used to report errors more precisly (instead of reporting the end
23375 of a definition, we try to track something which is a lot closer
23376 to the source of the problem).
23378 * cs-tokenizer.cs: Track global token use, so we can properly flag
23379 the use of #define/#undef after the first token has been seen.
23381 Also, rename the reportXXXX to Error_DescriptiveName
23383 * decl.cs (DeclSpace.IsTopLevel): Move property here from
23384 TypeContainer, so that Enum and Interface can use this too.
23386 * class.cs (TypeContainer.LookupInterfaceOrClass,
23387 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
23388 `builder' argument. Typically this was used to pass the parent
23389 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
23392 The problem is that a nested class could trigger the definition of
23393 a toplevel class, and the builder would be obviously wrong in that
23396 So we drop this argument, and we compute dynamically the
23397 TypeBuilder/ModuleBuilder (the correct information was available
23398 to us anyways from DeclSpace.Parent)
23400 * interface.cs (Interface.DefineInterface): Drop builder
23401 parameter cleanup like class.cs
23403 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
23406 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
23409 (Try.Emit): Propagate the returns value from the statement.
23411 (Return.Emit): Even if we are leavning
23413 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
23415 * modifiers.cs: Fix the computation of MethodAttributes flags.
23417 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
23419 * driver.cs: allow compilation of files that start with '/'.
23420 Add a default case when checking the argument of --target.
23422 2002-03-25 Miguel de Icaza <miguel@ximian.com>
23424 * interface.cs: Implement the same search algorithm for types in
23425 the interface code.
23427 * delegate.cs: Do not allow multiple definition.
23429 * Recovered ChangeLog that got accidentally amputated
23431 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
23433 * rootcontext.cs: Load manually enum to allow core classes to
23434 contain enumerations.
23436 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
23437 Update to new static methods in TypeManager.
23439 * typemanager.cs (GetMethod, GetConstructor): Use our
23440 implementation of FindMembers to find the members, since during
23441 corlib compilation, the types are TypeBuilders and GetMethod and
23442 GetConstructor do not work.
23444 Make all methods in TypeManager static.
23446 (InitCodeHelpers): Split the functionality from
23447 the InitCodeTypes function.
23449 * driver.cs: Call InitCodeHelpers after we have populated the
23452 * cs-parser.jay (delegate_declaration): we did not used to compute
23453 the delegate name correctly for void delegates.
23455 2002-03-24 Miguel de Icaza <miguel@ximian.com>
23457 * rootcontext.cs (RootContext): Init the interface_resolve_order
23458 and type_container_resolve_order always.
23460 (ResolveCore, BootstrapCorlib_ResolveClass,
23461 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
23462 compiler when compiling with --nostdlib
23464 * class.cs (TypeContainer.DefineType): Check that our parent is
23465 not null. This test is most important when we are bootstraping
23468 * codegen.cs: Split out the symbol writing code.
23470 2002-03-25 Martin Baulig <martin@gnome.org>
23472 * driver.cs (-g): Made -g an alias for --debug.
23474 2002-03-24 Martin Baulig <martin@gnome.org>
23476 * codegen.cs (SymbolWriter): New public variable. Returns the
23477 current symbol writer.
23478 (CodeGen): Added `bool want_debugging_support' argument to the
23479 constructor. If true, tell the ModuleBuild that we want debugging
23480 support and ask it for the ISymbolWriter.
23481 (Save): If we have a symbol writer, call it's Close() method after
23482 saving the assembly.
23484 * driver.c (--debug): New command line argument to create a
23485 debugger information file.
23487 * location.cs (SymbolDocument): New public property. Returns an
23488 ISymbolDocumentWriter object for the current source file or null
23489 if we don't have a symbol writer.
23491 2002-03-21 Miguel de Icaza <miguel@ximian.com>
23493 * driver.cs (LoadAssembly): Correctly return when all the paths
23494 have been tried and not before.
23496 * statement.cs (Switch.Emit): return the actual coverage for this
23497 statement (returns/not-returns)
23499 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
23500 switch of the statement if we are the last switch section. That
23501 kills two problems: try/catch problems (we used to emit an empty
23502 nop at the end) and switch statements where all branches would
23505 2002-03-19 Miguel de Icaza <miguel@ximian.com>
23507 * driver.cs: Add default assemblies (the equivalent to the
23508 Microsoft CSC.RSP file)
23510 * cs-tokenizer.cs: When updating `cols and setting it to zero,
23511 also update tokens_seen and set it to false.
23513 * driver.cs: Implement --recurse for Mike.
23515 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
23516 correctly splitting out the paths.
23518 2002-03-18 Miguel de Icaza <miguel@ximian.com>
23520 * interface.cs (Interface.PopulateProperty): Instead of using
23521 `parent' as the declaration space for the set parameters, use
23524 * support.cs (InternalParameters): InternalParameters constructor
23525 takes a DeclSpace instead of a TypeContainer.
23527 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
23528 types are being initialized, load the address of it before calling
23531 (New): Provide a mechanism to disable the generation of local
23532 value type temporaries when the caller will be providing us with
23533 an address to store it.
23535 (ArrayCreation.EmitDynamicInitializers): Use it.
23537 2002-03-17 Miguel de Icaza <miguel@ximian.com>
23539 * expression.cs (Invocation.EmitArguments): Only probe for array
23540 property if there is more than one argument. Sorry about that.
23542 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
23543 empty param arrays.
23545 * class.cs (Method.LabelParameters): Fix incorrect code path that
23546 prevented the `ParamArrayAttribute' from being applied to the
23549 2002-03-16 Miguel de Icaza <miguel@ximian.com>
23551 * support.cs (ReflectionParameters): Correctly compute whether the
23552 last argument is a params array. Fixes the problem with
23555 * typemanager.cs: Make the assemblies array always be non-null
23556 (empty, but non-null)
23558 * tree.cs (RecordDecl): New function that abstracts the recording
23559 of names. This reports error 101, and provides a pointer to the
23560 previous declaration. Fixes a crash in the compiler.
23562 * cs-parser.jay (constructor_declaration): Update to new grammar,
23563 and provide a constructor_body that can be empty.
23565 2002-03-15 Miguel de Icaza <miguel@ximian.com>
23567 * driver.cs: Add support for --resources.
23569 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
23570 Make all types for the various array helper methods be integer.
23572 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
23573 CheckState to ConvCast.
23575 (ConvCast): Now it takes a `checked' state argument, to avoid
23576 depending on the emit context for the conversion, and just using
23577 the resolve time setting.
23579 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
23580 instead of Invocation.EmitArguments. We do not emit the original
23581 arguments, instead we emit those which have been converted to
23582 unsigned int expressions.
23584 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
23586 * codegen.cs: ditto.
23588 * expression.cs (LocalVariableReference): Drop the use of the
23589 Store function that depended on the variable index.
23591 * statement.cs (VariableInfo): Drop the `Idx' property from this
23592 class, as this is not taking into account the indexes for
23593 temporaries tat we generate during the execution, getting the
23596 * class.cs: First emit class initializers, then call the parent
23599 * expression.cs (Binary): Fix opcode emision.
23600 (UnaryMutator.EmitCode): Support checked code generation
23602 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
23603 matches for events for both the Static and Instance scans,
23604 pointing to the same element. Fix that.
23606 2002-03-14 Miguel de Icaza <miguel@ximian.com>
23608 * rootcontext.cs (ResolveTree): Always set the
23609 interface_resolve_order, because nested interfaces will be calling
23612 * class.cs (GetInterfaceOrClass): Track the same resolution
23613 process used by TypeManager.LookupType. This fixes the nested
23614 type lookups in class declarations (separate path from
23617 (TypeContainer.DefineType): Also define nested interfaces.
23618 (TypeContainer.RegisterOrder): New public function used to
23619 register the order in which child interfaces need to be closed.
23621 Nested interfaces need to be closed after their parents have been
23624 * interface.cs (InterfaceAttr): Put all the logic for computing
23625 the interface attribute here.
23627 (DefineInterface): Register our interface order with the
23628 RootContext or with the TypeContainer depending on the case.
23630 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23632 * cs-parser.jay: rework foreach statement to work with the new
23633 changes to the policy on SimpleNames.
23635 * report.cs: support Stacktrace on warnings as well.
23637 * makefile: drop --unsafe and /unsafe from the compile.
23639 2002-03-13 Ravi Pratap <ravi@ximian.com>
23641 * ecore.cs (StandardConversionExists): Modify to take an Expression
23642 as the first parameter. Ensure we do null -> reference type conversion
23645 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
23646 temporary Expression objects.
23648 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
23650 * interface.cs: workaround bug in method overloading resolution
23651 (there is already a bugzilla bug for it).
23653 2002-03-12 Miguel de Icaza <miguel@ximian.com>
23655 We could also solve this problem by having a separate path for
23656 performing type lookups, instead of DoResolve, we could have a
23657 ResolveType entry point, and only participating pieces of the
23658 production (simplename, deref, array) would implement this.
23660 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
23661 signal SimpleName to only resolve type names and not attempt to
23662 resolve anything else.
23664 * expression.cs (Cast): Set the flag.
23666 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
23668 * class.cs: Only report 108 if there is no `new' modifier.
23670 * cs-parser.jay: rework foreach statement to work with the new
23671 changes to the policy on SimpleNames.
23673 * report.cs: support Stacktrace on warnings as well.
23675 * makefile: drop --unsafe and /unsafe from the compile.
23677 2002-03-11 Miguel de Icaza <miguel@ximian.com>
23679 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23680 lookups here, instead of doing that at parse time. This means
23681 that our grammar will not introduce `LocalVariableReferences' as
23682 expressions at this point. That solves the problem of code like
23686 static void Main ()
23690 This is only half the fix. The full fix requires parameters to
23691 also be handled in this way.
23693 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
23694 makes the use more obvious of the DeclSpace. The
23695 ec.TypeContainer.TypeBuilder is now only used to pull the
23696 TypeBuilder for it.
23698 My theory is that I can get rid of the TypeBuilder completely from
23699 the EmitContext, and have typecasts where it is used (from
23700 DeclSpace to where it matters).
23702 The only pending problem is that the code that implements Aliases
23703 is on TypeContainer, and probably should go in DeclSpace.
23705 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
23706 lookups here, instead of doing that at parse time. This means
23707 that our grammar will not introduce `LocalVariableReferences' as
23708 expressions at this point. That solves the problem of code like
23712 static void Main ()
23716 This is only half the fix. The full fix requires parameters to
23717 also be handled in this way.
23719 * class.cs (Property.DefineMethod): When implementing an interface
23720 method, set newslot, when implementing an abstract method, do not
23721 set the flag (before we tried never setting it, or always setting
23722 it, which is the difference).
23723 (Indexer.DefineMethod): same.
23724 (Method.DefineMethod): same.
23726 * ecore.cs: Only set the status used flag if we get back a Field.
23728 * attribute.cs: Temporary hack, so Paolo can keep working.
23730 2002-03-08 Ravi Pratap <ravi@ximian.com>
23732 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
23733 the unmanaged type in the case we have a MarshalAs attribute.
23735 (Resolve): Handle the case when we are parsing the special MarshalAs
23736 attribute [we need to store the unmanaged type to use later]
23738 * typemanager.cs (marshal_as_attr_type): Built in type for the
23739 MarshalAs Attribute.
23741 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
23742 on parameters and accordingly set the marshalling info.
23744 2002-03-09 Miguel de Icaza <miguel@ximian.com>
23746 * class.cs: Optimizing slightly by removing redundant code after
23747 we switched to the `NoTypes' return value.
23748 (Property.DefineMethod): use NoTypes here too.
23750 This fixes the bug I introduced in my last batch of changes.
23752 2002-03-05 Ravi Pratap <ravi@ximian.com>
23754 * tree.cs (RecordEnum): Add. We now keep track of enums too.
23756 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
23757 Enums since those are types too.
23759 * cs-parser.jay (enum_declaration): Record enums as we parse them.
23761 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
23762 thanks to a call during the lookup process.
23764 2002-03-07 Miguel de Icaza <miguel@ximian.com>
23766 * statement.cs (Foreach): Lots of work to accomodate a particular
23767 kind of foreach statement that I had not kept in mind. It is
23768 possible to have foreachs on classes that provide a GetEnumerator
23769 method that return objects that implement the "pattern" for using
23770 a foreach, there is no need to support GetEnumerator
23773 This is needed to compile nant.
23775 * decl.cs: Only report 114 if the member is not `Finalize' and if
23776 the warning level is at least 2.
23778 * class.cs: Moved the compare function from Method to
23781 (MethodSignature.InheritableMemberSignatureCompare): Add new
23782 filter function that is used to extract inheritable methods from a
23785 (Method.Define): Use the new `inheritable_method_signature_filter'
23788 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
23791 2002-03-06 Miguel de Icaza <miguel@ximian.com>
23793 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
23795 * cs-parser.jay: Add opt_semicolon to the interface declaration.
23797 * expression.cs: Pass location information to
23798 ConvertImplicitStandard.
23800 * class.cs: Added debugging code to track return values from
23803 2002-03-05 Miguel de Icaza <miguel@ximian.com>
23805 * expression.cs (Is.DoResolve): If either side of the `is' is an
23806 interface, do not flag the warning.
23808 * ecore.cs (ImplicitReferenceConversion): We need a separate test
23811 * report.cs: Allow for --fatal to be used with --probe.
23813 * typemanager.cs (NoTypes): Move the definition for the empty Type
23816 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
23818 (TypeContainer.DefineProxy): New function used to proxy to parent
23819 implementations when implementing interfaces.
23820 (TypeContainer.ParentImplements): used to lookup if our parent
23821 implements a public function that is required by an interface.
23822 (TypeContainer.VerifyPendingMethods): Hook this up.
23824 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
23825 `modules' and `assemblies' arraylists into arrays. We only grow
23826 these are the very early start up of the program, so this improves
23827 the speedof LookupType (nicely measured).
23829 * expression.cs (MakeByteBlob): Replaced unsafe code with
23830 BitConverter, as suggested by Paolo.
23832 * cfold.cs (ConstantFold.Binary): Special case: perform constant
23833 folding of string concatenation, but if either side is a string,
23834 and the other is not, then return null, and let the runtime use
23835 the concatenation on the string plus the object (using
23836 `Object.ToString').
23838 2002-03-04 Miguel de Icaza <miguel@ximian.com>
23840 Constant Folding has been implemented now.
23842 * expression.cs (Unary.Reduce): Do not throw an exception, catch
23843 the error instead on types that are not supported in one's
23846 * constant.cs (Constant and all children): New set of functions to
23847 perform implict and explicit conversions.
23849 * ecore.cs (EnumConstant): Implement the new functions to perform
23850 conversion by proxying to the child expression.
23852 * codegen.cs: (ConstantCheckState): Constant evaluation has its
23853 own separate setting that can not be turned off from the command
23854 line using --unchecked or --checked and is only controlled using
23855 the checked/unchecked statements and expressions. This setting is
23856 used by the constant folder to flag errors.
23858 * expression.cs (CheckedExpr, UncheckedExpr): Set the
23859 ConstantCheckState as well.
23861 During Resolve, they also have to flag the state, because the
23862 constant folder runs completely in the Resolve phase.
23864 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
23867 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23869 * cfold.cs: New file, this file contains the constant folder.
23871 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
23872 argument to track whether we are using the resulting address to
23873 load or store a value and provide better error messages.
23875 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
23876 new AddressOf arguments.
23878 * statement.cs (Foreach.EmitCollectionForeach): Update
23880 * expression.cs (Argument.Emit): Call AddressOf with proper
23881 arguments to track usage.
23883 (New.DoEmit): Call AddressOf with new arguments.
23885 (Unary.Emit): Adjust AddressOf call.
23887 2002-03-01 Ravi Pratap <ravi@ximian.com>
23889 * cs-parser.jay (member_access): Change the case for pre-defined types
23890 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
23893 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
23896 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
23897 essentially like methods and apply attributes like MethodImplOptions to them too.
23899 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
23902 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
23903 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
23906 * Update code everywhere accordingly.
23908 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
23910 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
23912 2002-02-28 Ravi Pratap <ravi@ximian.com>
23914 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
23915 try performing lookups against those instead of jumping straight into using
23916 the 'using' clauses.
23918 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
23920 (LookupType): Perform lookups in implicit parents too.
23922 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
23923 sequence as RootContext.LookupType.
23925 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
23926 the various cases of namespace lookups into this method.
23928 2002-03-01 Miguel de Icaza <miguel@ximian.com>
23930 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
23931 in positional arguments)
23933 * class.cs (Operator): Update the AllowedModifiers to contain
23936 * cs-parser.jay: Update operator declaration to allow for the
23937 operator body to be empty.
23939 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
23942 2002-02-27 Miguel de Icaza <miguel@ximian.com>
23944 * class.cs (Method.Emit): Label parameters.
23946 * driver.cs: Return 1 or 0 as the program exit code.
23948 2002-02-26 Miguel de Icaza <miguel@ximian.com>
23950 * expression.cs: Special case the `null' object when trying to
23951 auto-compute the type, as anything can be explicitly converted to
23954 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
23955 spotting this Paolo.
23957 (Expression.ImplicitNumericConversion): Perform comparissions of
23958 the type using the underlying type in the case of an enumeration
23959 rather than using the enumeration type for the compare.
23961 Cope with the underlying == type case, which is not possible to
23964 (Expression.ConvertNumericExplicit): Perform comparissions of
23965 the type using the underlying type in the case of an enumeration
23966 rather than using the enumeration type for the compare.
23968 * driver.cs: If the user does not supply an extension, assume .exe
23970 * cs-parser.jay (if_statement): Rewrote so that we can track the
23971 location for the if statement.
23973 * expression.cs (Binary.ConstantFold): Only concat strings when
23974 the operation is "+", not everything ;-)
23976 * statement.cs (Statement.EmitBoolExpression): Take a location
23978 (If, While, Do): Track location.
23980 * expression.cs (Binary.ResolveOperator): In the object + string
23981 case, I was missing a call to ConvertImplicit
23983 2002-02-25 Ravi Pratap <ravi@ximian.com>
23985 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
23986 Location arguments. Ensure we use RootContext.LookupType to do our work
23987 and not try to do a direct Type.GetType and ModuleBuilder.GetType
23989 * interface.cs (PopulateMethod): Handle the type of the parameter being
23992 * expression.cs (Invocation.BetterFunction): Handle the case when we
23993 have a params method with no fixed arguments and a call is made with no
23996 2002-02-25 Miguel de Icaza <miguel@ximian.com>
23998 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
23999 the verbatim-string-literal
24001 * support.cs (InternalParameters.ParameterModifier): handle null
24003 (InternalParameters.ParameterType): ditto.
24005 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
24006 duplicating the name of the variable parameter.
24007 (GetParameterByName): Fix bug where we were not looking up array
24008 paramters if they were the only present (thanks Paolo!).
24009 (GetParameterInfo): We only have an empty set of types if both
24010 fixed and array are set to null.
24011 (GetParameterInfo-idx): Handle FixedParameter == null
24013 * cs-parser.jay: Handle the case where there is no catch
24014 statements (missing null test).
24016 2002-02-22 Miguel de Icaza <miguel@ximian.com>
24018 * driver.cs (MainDriver): Be conservative on our command line
24021 Catch DirectoryNotFoundException when calling GetFiles.
24023 (SplitPathAndPattern): Used to split the input specification into
24024 a path and a pattern that we can feed to Directory.GetFiles.
24026 2002-02-21 Miguel de Icaza <miguel@ximian.com>
24028 * statement.cs (Fixed): Implement the last case of the Fixed
24029 statement (string handling).
24031 * expression.cs (StringPtr): New class used to return a char * to
24032 a string; Used by the Fixed statement.
24034 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
24036 * expression.cs (Binary.ResolveOperator): Remove redundant
24037 MemberLookup pn parent type.
24038 Optimize union call, we do not need a union if the types are the same.
24039 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
24042 Specialize the use of MemberLookup everywhere, instead of using
24043 the default settings.
24045 (StackAlloc): Implement stackalloc keyword.
24047 * cs-parser.jay: Add rule to parse stackalloc.
24049 * driver.cs: Handle /h, /help, /?
24051 * expression.cs (MakeByteBlob): Removed the hacks we had in place
24052 before we supported unsafe code.
24054 * makefile: add --unsafe to the self compilation of mcs.
24056 2002-02-20 Miguel de Icaza <miguel@ximian.com>
24058 * expression.cs (PointerArithmetic): New class that is used to
24059 perform pointer arithmetic.
24060 (Binary.Resolve): Handle pointer arithmetic
24061 Handle pointer comparission.
24062 (ArrayPtr): Utility expression class that is used to take the
24063 address of an array.
24065 (ElementAccess): Implement array access for pointers
24067 * statement.cs (Fixed): Implement fixed statement for arrays, we
24068 are missing one more case before we are done.
24070 * expression.cs (Indirection): Implement EmitAssign and set the
24071 ExprClass to Variable. This allows pointer dereferences to be
24072 treated as variables, and to have values assigned to them.
24074 * ecore.cs (Expression.StoreFromPtr): New utility function to
24075 store values dereferencing.
24077 2002-02-20 Ravi Pratap <ravi@ximian.com>
24079 * expression.cs (Binary.ResolveOperator): Ensure that we are
24080 not trying to operate on a void type - this fixes the reported
24083 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
24084 the parent implementation is sealed.
24086 * ../errors/cs0239.cs : Add.
24088 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
24090 * typemanager.cs (unverifiable_code_type): Corresponds to
24091 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
24092 which have unsafe code in them.
24094 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
24097 2002-02-19 Miguel de Icaza <miguel@ximian.com>
24099 * cs-tokenizer.cs: Add support for @"litreal strings"
24101 Make tokenizer accept pre-processor directives
24102 on any column (remove the old C-like limitation).
24104 * rootcontext.cs (EmitCode): Emit any global attributes.
24105 (AddGlobalAttributes): Used to keep track of assembly attributes.
24107 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
24109 * cs-parser.jay: Add support for global attributes.
24111 2002-02-17 Miguel de Icaza <miguel@ximian.com>
24113 * expression.cs (Indirection): New helper class. Unary will
24114 create Indirection classes to be able to implement the
24115 IMemoryLocation interface on it.
24117 2002-02-16 Miguel de Icaza <miguel@ximian.com>
24119 * cs-parser.jay (fixed_statement): reference the right statement.
24121 * statement.cs (Fixed.Emit): Finish implementing the fixed
24122 statement for the &x case.
24124 2002-02-14 Miguel de Icaza <miguel@ximian.com>
24126 * class.cs (Property.Define, Method.Define): Remove newslot when
24129 * modifiers.cs: My use of NewSlot when `Abstract' was set was
24130 wrong. NewSlot should only be used if the `new' keyword is present.
24132 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
24133 locating our system dir. Sorry about this.
24135 2002-02-13 Miguel de Icaza <miguel@ximian.com>
24137 * driver.cs (GetSystemDir): Compute correctly the location of our
24138 system assemblies. I was using the compiler directory instead of
24139 the library directory.
24141 2002-02-13 Ravi Pratap <ravi@ximian.com>
24143 * expression.cs (BetterFunction): Put back in what Miguel commented out
24144 since it is the correct fix. The problem is elsewhere ;-)
24146 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
24147 parameters of the parms method are themselves compatible or not !
24149 (StandardConversionExists): Fix very dangerous bug where we were forgetting
24150 to check that a class implements an interface before saying that an implicit
24151 conversion was allowed. Use ImplementsInterface to do the checking.
24153 2002-02-13 Miguel de Icaza <miguel@ximian.com>
24155 * class.cs (Method.Define): Track whether we are an explicit
24156 implementation or not. And only call DefineMethodOverride if we
24157 are an explicit implementation.
24159 (Property.DefineMethod): Ditto.
24161 2002-02-11 Ravi Pratap <ravi@ximian.com>
24163 * expression.cs (BetterFunction): Catch hideous bug which was
24164 preventing us from detecting ambiguous calls due to implicit casts i.e
24167 2002-01-29 Miguel de Icaza <miguel@ximian.com>
24169 * support.cs (Pair): Remove un-needed method. I figured why I was
24170 getting the error in cs-parser.jay, the variable in a foreach loop
24171 is readonly, and the compiler does not really treat this as a variable.
24173 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
24174 instead of EQUALS in grammar.
24176 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
24178 * expression.cs (Unary.DoResolve): Check whether the argument is
24181 2002-01-28 Miguel de Icaza <miguel@ximian.com>
24183 * support.cs: Api for Pair to set a value. Despite the fact that
24184 the variables are public the MS C# compiler refuses to compile
24185 code that accesses the field if the variable is part of a foreach
24188 * statement.cs (Fixed): Begin implementation of the fixed
24191 (Block.AddVariable): Return the VariableInfo on success and null
24192 on failure instead of true/false.
24194 * cs-parser.jay (foreach): Catch errors on variables already
24195 defined (we were ignoring this value before) and properly unwind
24196 the block hierarchy
24198 (fixed_statement): grammar for the fixed statement.
24200 2002-01-25 Miguel de Icaza <miguel@ximian.com>
24202 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
24203 pointer types to be incretemented.
24205 (SizeOf): Implement.
24207 * cs-parser.jay (pointer_member_access): Implement
24208 expr->IDENTIFIER production.
24210 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
24211 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
24214 (Unary): Implement indirection.
24216 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
24217 use in non-unsafe context).
24219 (SimpleName.DoResolve): Check for pointers in field access on safe
24222 (Expression.LoadFromPtr): Factor the load-indirect code in this
24223 function. This was duplicated in UnboxCast and ParameterReference
24225 2002-01-24 Miguel de Icaza <miguel@ximian.com>
24227 * expression.cs (ComposedCast): report an error if a pointer cast
24228 is used in a safe region.
24230 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
24231 pointer type casts in unsafe context.
24233 * codegen.cs (EmitContext): Set up IsUnsafe.
24235 * cs-parser.jay (non_expression_type): Add productions for pointer
24238 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
24239 code. We should not use force into static mode if the method is
24240 not virtual. Fixes bug in MIS
24242 * statement.cs (Do.Emit, While.Emit, For.Emit,
24243 Statement.EmitBoolExpression): Add support to Do and While to
24244 propagate infinite loop as `I do return' semantics.
24246 Improve the For case to also test for boolean constants.
24248 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
24249 to the list of attributes we can add.
24251 Remove `EmitContext' argument.
24253 * class.cs (Method.Define): Apply parameter attributes.
24254 (Constructor.Define): Apply parameter attributes.
24255 (MethodCore.LabelParameters): Move here the core of labeling
24258 * support.cs (ReflectionParameters.ParameterModifier,
24259 InternalParameters.ParameterModifier): Use IsByRef on the type and
24260 only return the OUT bit for these parameters instead of in/out/ref
24263 This is because I miss-understood things. The ParameterInfo.IsIn
24264 and IsOut represent whether the parameter has the [In] and [Out]
24267 2002-01-22 Miguel de Icaza <miguel@ximian.com>
24269 * ecore.cs (FieldExpr.Emit): Release temporaries.
24271 * assign.cs (LocalTemporary.Release): new function.
24273 * codegen.cs (EmitContext.GetTemporaryStorage,
24274 EmitContext.FreeTemporaryStorage): Rework the way we deal with
24275 temporary storage. Now we can "put back" localbuilders when we
24278 2002-01-21 Miguel de Icaza <miguel@ximian.com>
24280 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
24281 need to make a copy of the variable to generate verifiable code.
24283 2002-01-19 Miguel de Icaza <miguel@ximian.com>
24285 * driver.cs: Compute dynamically the system directory.
24287 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
24288 Slower, but more generally useful. Used by the abstract
24289 registering implementation.
24291 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
24292 the rules for the special rule on Type/instances. First check if
24293 we have the same name, and if so, try that special static path
24294 rather than the instance path.
24296 2002-01-18 Miguel de Icaza <miguel@ximian.com>
24298 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
24301 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
24302 Enum, ValueType, Delegate or Array for non-corlib compiles.
24304 * cs-tokenizer.cs: Catch long identifiers (645)
24306 * typemanager.cs (IndexerPropetyName): Ravi never tested this
24309 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
24310 fix, we were returning too early, so we were not registering
24311 pending methods from abstract classes.
24313 Do not register pending methods if the class is abstract.
24315 * expression.cs (Conditional.DoResolve): Report circular implicit
24316 conversions when we neecd to compute it for conditional
24319 (Is.DoResolve): If the expression is always of the provided type,
24320 flag warning 183. If the expression can not ever be of the
24321 provided type flag warning 184.
24323 * class.cs: Catch 169 as well.
24325 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
24328 2002-01-18 Nick Drochak <ndrochak@gol.com>
24330 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
24332 2002-01-17 Miguel de Icaza <miguel@ximian.com>
24334 * interface.cs: (PopulateMethod): Check for pointers being defined
24335 only if the unsafe context is active.
24336 (PopulateProperty): ditto.
24337 (PopulateIndexer): ditto.
24339 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
24340 specified. If pointers are present, make sure that they are
24341 present in an unsafe context.
24342 (Constructor, Constructor.Define): ditto.
24343 (Field, Field.Define): ditto.
24344 (Property, Property.Define): ditto.
24345 (Event, Event.Define): ditto.
24347 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
24348 hashtable if there are classes or structs defined.
24350 * expression.cs (LocalVariableReference.DoResolve): Simplify this
24351 code, as the constant resolution moved.
24353 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
24354 the metadata, so we can flag error 133.
24356 * decl.cs (MemberCore.UnsafeOK): New function to test that a
24357 pointer is being declared in an unsafe context.
24359 2002-01-16 Miguel de Icaza <miguel@ximian.com>
24361 * modifiers.cs (Modifiers.Check): Require a Location argument.
24362 Report error 227 for Unsafe use.
24364 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
24366 * statement.cs (For.Emit): If the test is null, then report that
24367 we do `return', as we wont reach anything afterwards.
24369 (Switch.SwitchGoverningType): Track the expression that matched
24372 * driver.cs: Allow negative numbers as an error code to flag.
24374 * cs-parser.jay: Handle 1551.
24376 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
24378 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24380 * cs-parser.jay: Report 1518 (type declaration can only contain
24381 class, struct, interface, enum or delegate)
24383 (switch_label): Report 1523 (keywords `case' or `default' must
24386 (opt_switch_sections): Report 1522 (empty switch)
24388 * driver.cs: Report 1515 (response file specified multiple times)
24389 Report 1516 (Source file specified multiple times).
24391 * expression.cs (Argument.Resolve): Signal 1510
24393 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
24394 access not allowed in static code)
24396 2002-01-11 Ravi Pratap <ravi@ximian.com>
24398 * typemanager.cs (IsPointerType): Utility method which we are going
24401 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
24402 the object type, so we take care of that.
24404 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
24406 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
24407 added to non-params parameters :-)
24409 * typemanager.cs (CSharpName): Include 'void' type too.
24411 (void_ptr_type): Include in the set of core types.
24413 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
24416 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
24419 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
24420 completely forgotten about it.
24422 2002-01-10 Ravi Pratap <ravi@ximian.com>
24424 * cs-parser.jay (pointer_type): Add. This begins our implementation
24425 of parsing rules for unsafe code.
24427 (unsafe_statement): Implement.
24429 (embedded_statement): Modify to include the above.
24431 * statement.cs (Unsafe): Implement new class for unsafe blocks.
24433 * codegen.cs (EmitContext.InUnsafe): Add. This determines
24434 if the current context is an unsafe one.
24436 * cs-parser.jay (local_variable_pointer_type): Since local variable types
24437 are handled differently, we need separate rules for them.
24439 (local_variable_declaration): Update to use local_variable_pointer_type
24440 to allow variable declarations of unmanaged pointer types.
24442 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
24443 in unsafe contexts.
24445 * ../errors/cs0214.cs : Add.
24447 2002-01-16 Nick Drochak <ndrochak@gol.com>
24449 * makefile: remove 'response' file when cleaning.
24451 2002-01-15 Miguel de Icaza <miguel@ximian.com>
24453 * cs-parser.jay: Report 1524.
24455 2002-01-14 Miguel de Icaza <miguel@ximian.com>
24457 * typemanager.cs (RegisterMethod): drop checking if we have
24458 registered this from here
24460 2002-01-12 Miguel de Icaza <miguel@ximian.com>
24462 * class.cs (Method.EmitDestructor): Implement calling our base
24465 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
24466 value of InFinally.
24468 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
24469 this routine and will wrap the call in a try/catch block. Deal
24472 2002-01-11 Miguel de Icaza <miguel@ximian.com>
24474 * ecore.cs (Expression.MemberLookup): instead of taking a
24475 parameter `same_type' that was used to tell whether we could
24476 access private members we compute our containing type from the
24479 (FieldExpr): Added partial support for volatile fields. This does
24480 not work for volatile fields exposed from assemblies, as I can not
24481 figure out how to extract the modreq from it.
24483 Updated all the source files to use this.
24485 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
24486 because it is referenced by MemberLookup very often.
24488 2002-01-09 Ravi Pratap <ravi@ximian.com>
24490 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
24491 TypeBuilder.GetCustomAttributes to retrieve what we need.
24493 Get rid of redundant default_member_attr_type as this is the same as
24494 default_member_type which already exists.
24496 * interface.cs, attribute.cs : Update accordingly.
24498 2002-01-08 Miguel de Icaza <miguel@ximian.com>
24500 * typemanager.cs: Enable IndexerPropertyName again. It does not
24501 work for TYpeBuilders though. Ravi, can you please fix this?
24503 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
24505 * expression.cs (Argument.Emit): Handle the case of ref objects
24506 being passed to ref functions;
24508 (ParameterReference.EmitLoad): Loads the content of the pointer
24509 without dereferencing.
24511 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24513 * cs-tokenizer.cs: Implemented the pre-processing expressions.
24515 2002-01-08 Ravi Pratap <ravi@ximian.com>
24517 * class.cs (Indexer.DefineMethod): Incorporate the interface
24518 type in the name of the method if we are doing explicit interface
24521 * expression.cs (ConversionExists): Remove as it is completely obsolete.
24523 (BetterConversion): Fix extremely trivial bug where we were referring to
24524 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
24527 * ../errors/bug16.cs : Add although we have fixed it.
24529 2002-01-07 Miguel de Icaza <miguel@ximian.com>
24531 * expression.cs (BaseIndexer): Begin implementation.
24533 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
24535 * cs-parser.jay (indexer_declarator): Use qualified_identifier
24536 production directly to remove a shift/reduce, and implement
24537 explicit interface implementation.
24539 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
24540 after a floating point suffix.
24542 * expression.cs (DoNumericPromotions): Improved the conversion for
24543 uint/uint. If we have a constant, we avoid doing a typecast to a
24546 * class.cs (Indexer): Implement explicit interface implementation
24549 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
24551 * class.cs: make the default instance constructor public and hidebysig.
24553 2001-01-03 Ravi Pratap <ravi@ximian.com>
24555 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
24556 so we can call it from elsewhere.
24558 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
24559 we emit it internally if the class has a defined indexer; otherwise the user
24560 emits it by decorating the class definition with the DefaultMemberAttribute.
24562 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
24563 attribute is not used on a type which defines an indexer.
24565 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
24566 character when we skip whitespace.
24568 * ../errors/cs0646.cs : Add.
24570 2002-01-03 Miguel de Icaza <miguel@ximian.com>
24572 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
24575 * makefile: Add practical target `mcs3.exe' which builds the third
24576 generation compiler.
24578 * expression.cs (New): Fix structures constructor calling.
24580 * class.cs (Property, Method, Indexer): Emit Final flag on the
24581 method if we are an interface implementation and we are not
24584 * ecore.cs (PropertyExpr): New public field `IsBase', tells
24585 whether this property is referencing a `base' method.
24587 * expression.cs (Invocation.EmitCall): take an extra argument:
24588 is_base, this is used to determine whether the `call' or
24589 `callvirt' opcode should be used.
24592 * delegate.cs: update EmitCall.
24594 * class.cs (Method.Define): Set NewSlot for the cases where we are
24595 not implementing an interface method.
24597 (Property.Define): ditto.
24599 2002-01-02 Miguel de Icaza <miguel@ximian.com>
24601 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
24602 'r'. Allows mcs to parse itself fully.
24604 2002-01-02 Ravi Pratap <ravi@ximian.com>
24606 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
24607 of the number of initializers that require the InitializeArray method.
24609 (CheckIndices): Store the Expression in all cases - not the plain value. Also
24610 update the above field where necessary.
24612 (MakeByteBlob): Update accordingly.
24614 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
24617 (EmitDynamicInitializers): Update in accordance with the new optimization.
24619 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
24620 same OpCode applies.
24622 * cs-parser.jay : Fix some glaring errors I introduced.
24624 2002-01-01 Ravi Pratap <ravi@ximian.com>
24626 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
24627 so that we can check for name clashes there too.
24629 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
24630 for interface indexers.
24632 * interfaces.cs (Define): Emit the default member attribute.
24634 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
24635 variable was being referred to while setting the value ;-)
24637 2002-01-01 Miguel de Icaza <miguel@ximian.com>
24639 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
24640 byte-by-byte information when we know the data is zero.
24642 Make the block always a multiple of 4, because
24643 DefineInitializedData has a bug.
24645 * assign.cs: Fix, we should assign from the temporary, not from
24648 * expression.cs (MakeByteBlob): Fix my incorrect code.
24650 2001-12-31 Miguel de Icaza <miguel@ximian.com>
24652 * typemanager.cs (EnumToUnderlying): This function is used to get
24653 the underlying type from an enumeration, because it does not
24656 * constant.cs: Use the I4_S form for values between -128 and 127.
24658 * statement.cs (Block.LookupLabel): Looks up a label.
24659 (Block): Drop support for labeled blocks.
24661 (LabeledStatement): New kind of statement that represents a label
24664 (Goto): Finally implement this bad boy.
24666 * cs-parser.jay: Update to reflect new mechanism to implement
24669 2001-12-30 Miguel de Icaza <miguel@ximian.com>
24671 * codegen.cs (EmitContext.This): a codegen property that keeps the
24672 a single instance of this instead of creating many different this
24675 * delegate.cs (Delegate.DoResolve): Update to use the property;
24677 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
24679 * expression.cs (BaseAccess.DoResolve): Ditto.
24681 2001-12-29 Ravi Pratap <ravi@ximian.com>
24683 * typemanager.cs (methodimpl_attr_type): Add to hold the type
24684 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
24686 (InitCoreTypes): Update accordingly.
24688 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
24689 so we can quickly store the state.
24691 (ApplyAttributes): Set the correct implementation flags
24692 for InternalCall methods.
24694 2001-12-29 Miguel de Icaza <miguel@ximian.com>
24696 * expression.cs (EmitCall): if a method is not virtual, then do
24697 not use callvirt on it.
24699 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
24700 user defined stuff) requires the use of stobj, which takes an
24701 address on the stack instead of an array and an index. So emit
24702 the Ldelema operation for it.
24704 (EmitStoreOpcode): Use stobj for valuetypes.
24706 (UnaryMutator.EmitCode): Use the right 1 value depending on
24707 whether we are dealing with int64/uint64, float or doubles.
24709 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
24710 constructors that I implemented last night.
24712 (Constructor.IsDefault): Fix to work properly for static
24715 * cs-parser.jay (CheckDef): report method signature errors.
24716 Update error number 103 to be 132.
24718 * decl.cs: New AdditionResult enumeration value: MethodExists.
24719 Although we do this check for methods later on in the semantic
24720 analysis, catching repeated default constructors is so easy that
24721 we catch these here.
24723 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
24726 (ParameterReference.EmitAssign, Emit): handle
24729 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
24730 (ArrayAccess.EmitStoreOpcode): ditto.
24732 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
24734 * expression.cs (MakeByteBlob): Complete all the missing types
24735 (uint, short, ushort, byte, sbyte)
24737 * class.cs: Only init instance field initializers on instance
24740 Rename `constructors' to instance_constructors.
24742 (TypeContainer.AddConstructor): Only add constructors to the list
24743 if it is not static.
24745 Make sure that we handle default_static_constructor independently
24746 everywhere where we handle instance_constructors
24748 2001-12-28 Miguel de Icaza <miguel@ximian.com>
24750 * class.cs: Do not lookup or create a base initializer for a
24751 static constructor.
24753 (ConstructorInitializer.Resolve): use the proper type to lookup
24756 * cs-parser.jay: Report error 1585 (modifiers between type and name).
24758 * enum.cs, interface.cs: Remove CloseType, this is taken care by
24761 * decl.cs: CloseType is now an virtual method, the default
24762 implementation just closes this type.
24764 2001-12-28 Ravi Pratap <ravi@ximian.com>
24766 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
24767 to PreserveSig by default. Also emit HideBySig on such methods.
24769 Basically, set the defaults to standard values.
24771 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
24772 argument, if candidate is better, it can't be worse than the best !
24774 (Invocation): Re-write bits to differentiate between methods being
24775 applicable in their expanded form and their normal form - for params
24778 Get rid of use_standard everywhere as only standard conversions are allowed
24779 in overload resolution.
24781 More spec conformance.
24783 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24785 * driver.cs: Add --timestamp, to see where the compiler spends
24788 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
24789 `this' in static code.
24791 (SimpleName.DoResolve): Implement in terms of a helper function
24792 that allows static-references to be passed upstream to
24795 (Expression.ResolveWithSimpleName): Resolve specially simple
24796 names when called by MemberAccess to implement the special
24799 (Expression.ImplicitReferenceConversion): Handle conversions from
24800 Null to reference types before others, as Null's type is
24803 * expression.cs (Invocation.EmitCall): Handle the special case of
24804 calling methods declared on a reference type from a ValueType
24805 (Base classes System.Object and System.Enum)
24807 (MemberAccess.Resolve): Only perform lookups on Enumerations if
24808 the left hand side is a TypeExpr, not on every enumeration.
24810 (Binary.Resolve): If types are reference types, then do a cast to
24811 object on operators != and == of both arguments.
24813 * typemanager.cs (FindMembers): Extract instance and static
24814 members if requested.
24816 * interface.cs (PopulateProperty): Use void_type instead of null
24817 as the return type for the setter method.
24819 (PopulateIndexer): ditto.
24821 2001-12-27 Ravi Pratap <ravi@ximian.com>
24823 * support.cs (ReflectionParameters): Fix minor bug where we
24824 were examining the wrong parameter for the ParamArray attribute.
24826 Cope with requests for the type of the parameter at position
24827 greater than the params parameter's. We now return the element
24828 type of the params array as that makes more sense.
24830 * expression.cs (Invocation.IsParamsMethodApplicable): Update
24831 accordingly as we no longer have to extract the element type
24834 (Invocation.OverloadResolve): Update.
24836 2001-12-27 Miguel de Icaza <miguel@ximian.com>
24838 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
24839 against IEnumerator, test whether the return value is a descendant
24840 of the IEnumerator interface.
24842 * class.cs (Indexer.Define): Use an auxiliary method to implement
24843 the other bits of the method definition. Begin support for
24844 explicit interface implementation.
24846 (Property.DefineMethod): Use TypeManager.void_type instead of null
24847 for an empty return value.
24849 2001-12-26 Miguel de Icaza <miguel@ximian.com>
24851 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
24852 dealing with a FieldExpr which is composed of a FieldBuilder, in
24853 the code path we did extract the constant, but we should have
24854 obtained the underlying value to be able to cast it (otherwise we
24855 end up in an infinite loop, this is what Ravi was running into).
24857 (ArrayCreation.UpdateIndices): Arrays might be empty.
24859 (MemberAccess.ResolveMemberAccess): Add support for section
24860 14.5.4.1 that deals with the special case of E.I when E is a type
24861 and something else, that I can be a reference to a static member.
24863 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
24864 handle a particular array type to create byte blobs, it is just
24865 something we dont generate byteblobs for.
24867 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
24870 * location.cs (Push): remove the key from the hashtable that we
24871 are about to add. This happens for empty files.
24873 * driver.cs: Dispose files after we have parsed them.
24875 (tokenize): new function that only runs the tokenizer on its
24876 input, for speed testing.
24878 2001-12-26 Ravi Pratap <ravi@ximian.com>
24880 * class.cs (Event.Define): Define the private field only if there
24881 are no accessors defined.
24883 * expression.cs (ResolveMemberAccess): If there is no associated
24884 field with the event, that means we have an event defined with its
24885 own accessors and we should flag error cs0070 since transforming
24886 ourselves into a field is not valid in that case.
24888 * ecore.cs (SimpleName.DoResolve): Same as above.
24890 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
24891 and charset to sane values.
24893 2001-12-25 Ravi Pratap <ravi@ximian.com>
24895 * assign.cs (DoResolve): Perform check on events only if they
24896 are being accessed outside the declaring type.
24898 * cs-parser.jay (event_declarations): Update rules to correctly
24899 set the type of the implicit parameter etc.
24901 (add_accessor, remove_accessor): Set current local parameters.
24903 * expression.cs (Binary): For delegate addition and subtraction,
24904 cast the return value from the method into the appropriate delegate
24907 2001-12-24 Ravi Pratap <ravi@ximian.com>
24909 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
24910 of these as the workaround is unnecessary.
24912 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
24913 delegate data - none of that is needed at all.
24915 Re-write bits to extract the instance expression and the delegate method
24918 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
24921 * attribute.cs (ApplyAttributes): New method to take care of common tasks
24922 of attaching attributes instead of duplicating code everywhere.
24924 * everywhere : Update code to do attribute emission using the above method.
24926 2001-12-23 Miguel de Icaza <miguel@ximian.com>
24928 * expression.cs (IsParamsMethodApplicable): if there are not
24929 parameters, return immediately.
24931 * ecore.cs: The 0 literal can be implicity converted to an enum
24934 (SimpleName.DoResolve): First lookup the type, then lookup the
24937 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
24938 want to get its address. If the InstanceExpression is not
24939 addressable, store the result in a temporary variable, then get
24942 * codegen.cs: Only display 219 errors on warning level or above.
24944 * expression.cs (ArrayAccess): Make it implement the
24945 IMemoryLocation interface.
24947 (Binary.DoResolve): handle the operator == (object a, object b)
24948 and operator != (object a, object b) without incurring into a
24949 BoxedCast (because 5 != o should never be performed).
24951 Handle binary enumerator operators.
24953 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
24954 value type, otherwise use Ldelem_ref.
24956 Use precomputed names;
24958 (AddressOf): Implement address of
24960 * cs-parser.jay (labeled_statement): Fix recursive block
24961 addition by reworking the production.
24963 * expression.cs (New.DoEmit): New has a special case:
24965 If we are dealing with a ValueType, we have a few
24966 situations to deal with:
24968 * The target of New is a ValueType variable, that is
24969 easy, we just pass this as the variable reference
24971 * The target of New is being passed as an argument,
24972 to a boxing operation or a function that takes a
24975 In this case, we need to create a temporary variable
24976 that is the argument of New.
24979 2001-12-23 Ravi Pratap <ravi@ximian.com>
24981 * rootcontext.cs (LookupType): Check that current_type is not null before
24982 going about looking at nested types.
24984 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
24985 not implement the IAssignMethod interface any more.
24987 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
24988 where we tranform them into FieldExprs if they are being resolved from within
24989 the declaring type.
24991 * ecore.cs (SimpleName.DoResolve): Do the same here.
24993 * assign.cs (DoResolve, Emit): Clean up code considerably.
24995 * ../errors/bug10.cs : Add.
24997 * ../errors/cs0070.cs : Add.
24999 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
25001 * assign.cs : Get rid of EventIsLocal everywhere.
25003 2001-12-23 Miguel de Icaza <miguel@ximian.com>
25005 * ecore.cs (ConvertIntLiteral): finished the implementation.
25007 * statement.cs (SwitchLabel): Convert the value we are using as a
25008 key before looking up the table.
25010 2001-12-22 Miguel de Icaza <miguel@ximian.com>
25012 * codegen.cs (EmitTopBlock): Require a Location argument now.
25014 * cs-parser.jay (constructor_declarator): We need to setup
25015 current_local_parameters before we parse the
25016 opt_constructor_initializer, to allow the variables to be bound
25017 to the constructor arguments.
25019 * rootcontext.cs (LookupType): First lookup nested classes in our
25020 class and our parents before we go looking outside our class.
25022 * expression.cs (ConstantFold): Extract/debox the values at the
25025 * rootcontext.cs (EmitCode): Resolve the constants first before we
25026 resolve the types. This is not really needed, but it helps debugging.
25028 * statement.cs: report location.
25030 * cs-parser.jay: pass location to throw statement.
25032 * driver.cs: Small bug fix.
25034 * report.cs: Updated format to be 4-zero filled digits.
25036 2001-12-22 Ravi Pratap <ravi@ximian.com>
25038 * expression.cs (CheckIndices): Fix minor bug where the wrong
25039 variable was being referred to ;-)
25041 (DoEmit): Do not call EmitStaticInitializers when the
25042 underlying type is System.Object.
25044 2001-12-21 Ravi Pratap <ravi@ximian.com>
25046 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
25047 and do the usual workaround for SRE.
25049 * class.cs (MyEventBuilder.EventType): New member to get at the type
25050 of the event, quickly.
25052 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
25054 * assign.cs (Assign.DoResolve): Handle the case when the target
25055 is an EventExpr and perform the necessary checks.
25057 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
25060 (SimpleName.MemberStaticCheck): Include check for EventExpr.
25062 (EventExpr): Set the type in the constructor itself since we
25063 are meant to be born fully resolved.
25065 (EventExpr.Define): Revert code I wrote earlier.
25067 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
25068 instance expression is null. The instance expression is a This in that case
25069 or a null, depending on whether it is a static method or not.
25071 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
25072 refers to more than one method.
25074 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
25075 and accordingly flag errors.
25077 2001-12-21 Miguel de Icaza <miguel@ximian.com>
25079 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
25081 2001-12-22 Miguel de Icaza <miguel@ximian.com>
25083 * location.cs (ToString): Provide useful rutine.
25085 2001-12-21 Miguel de Icaza <miguel@ximian.com>
25087 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
25088 objects, return the actual integral boxed.
25090 * statement.cs (SwitchLabel): define an ILLabel for each
25093 (Switch.CheckSwitch): If the value is a Literal, extract
25094 the underlying literal.
25096 Also in the unused hashtable we had, add the SwitchLabel so we can
25097 quickly look this value up.
25099 * constant.cs: Implement a bunch of new constants. Rewrite
25100 Literal based on this. Made changes everywhere to adapt to this.
25102 * expression.cs (Expression.MakeByteBlob): Optimize routine by
25103 dereferencing array only once, and also copes with enumrations.
25105 bytes are two bytes wide, not one.
25107 (Cast): Perform constant conversions.
25109 * ecore.cs (TryImplicitIntConversion): Return literals instead of
25110 wrappers to the literals here.
25112 * expression.cs (DoNumericPromotions): long literals can converted
25113 to ulong implicity (this is taken care of elsewhere, but I was
25114 missing this spot).
25116 * ecore.cs (Expression.Literalize): Make the return type Literal,
25117 to improve type checking.
25119 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
25121 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25123 * literal.cs: Revert code from ravi that checked the bounds. The
25124 bounds are sane by the definition of the type itself.
25126 * typemanager.cs: Fix implementation of ImplementsInterface. We
25127 need to actually look up in our parent hierarchy for interfaces
25130 * const.cs: Use the underlying type for enumerations
25132 * delegate.cs: Compute the basename for the delegate creation,
25133 that should fix the delegate test case, and restore the correct
25134 Type Lookup semantics in rootcontext
25136 * rootcontext.cs: Revert Ravi's last patch. The correct way of
25137 referencing a nested type with the Reflection API is using the "+"
25140 * cs-parser.jay: Do not require EOF token at the end.
25142 2001-12-20 Ravi Pratap <ravi@ximian.com>
25144 * rootcontext.cs (LookupType): Concatenate type names with
25145 a '.' instead of a '+' The test suite passes again.
25147 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
25148 field of the enumeration.
25150 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
25151 the case when the member is an EventExpr.
25153 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
25154 static has an associated instance expression.
25156 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
25158 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
25160 * class.cs (Event.Define): Register event and perform appropriate checks
25163 We define the Add and Remove methods even if the use provides none because
25164 in that case, we provide default implementations ourselves.
25166 Define a private field of the type of the event. This is done by the CSC compiler
25167 and we should be doing it too ;-)
25169 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
25170 More methods we use in code we generate.
25172 (multicast_delegate_type, delegate_type): Two separate types since the distinction
25175 (InitCoreTypes): Update accordingly for the above.
25177 * class.cs (Event.Emit): Generate code for default accessors that we provide
25179 (EmitDefaultMethod): Do the job in the above.
25181 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
25184 2001-12-20 Miguel de Icaza <miguel@ximian.com>
25186 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
25187 builders even if we were missing one.
25189 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
25190 pass the Basename as our class name instead of the Name. The
25191 basename will be correctly composed for us.
25193 * parameter.cs (Paramters): Now takes a Location argument.
25195 * decl.cs (DeclSpace.LookupType): Removed convenience function and
25196 make all the code call directly LookupType in RootContext and take
25197 this chance to pass the Location information everywhere.
25199 * Everywhere: pass Location information.
25201 2001-12-19 Miguel de Icaza <miguel@ximian.com>
25203 * class.cs (Constructor.Define): Updated way of detecting the
25204 length of the parameters.
25206 (TypeContainer.DefineType): Use basename as the type name for
25209 (TypeContainer.Define): Do not recursively define types here, as
25210 definition is taken care in order by the RootContext.
25212 * tree.cs: Keep track of namespaces in a per-file basis.
25214 * parameter.cs (Parameter.ComputeSignature): Update to use
25217 (Parameters.GetSignature): ditto.
25219 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
25220 instead of a TypeContainer.
25222 (Interface.SemanticAnalysis): Use `this' instead of our parent to
25223 resolve names. Because we need to be resolve in our context, not
25226 * driver.cs: Implement response files.
25228 * class.cs (TypeContainer.DefineType): If we are defined, do not
25229 redefine ourselves.
25231 (Event.Emit): Emit the code for add/remove handlers.
25232 (Event.Define): Save the MethodBuilders for add/remove.
25234 * typemanager.cs: Use pair here too.
25236 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
25237 DictionaryEntry requires the first argument to be non-null.
25239 (enum_declaration): Compute full name for registering the
25242 (delegate_declaration): Instead of using
25243 formal_parameter_list, use opt_formal_parameter_list as the list
25246 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
25247 (EventParsing): New property that controls whether `add' and
25248 `remove' are returned as tokens or identifiers (for events);
25250 2001-12-19 Ravi Pratap <ravi@ximian.com>
25252 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
25253 use MyEventBuilder only and let it wrap the real builder for us.
25255 (MyEventBuilder): Revamp constructor etc.
25257 Implement all operations that we perform on EventBuilder in precisely the same
25260 (FindMembers): Update to use the EventBuilder member.
25262 (Event.Emit): Update accordingly.
25264 2001-12-18 Ravi Pratap <ravi@ximian.com>
25266 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
25267 by calling the appropriate methods.
25269 (GetCustomAttributes): Make stubs as they cannot possibly do anything
25272 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
25274 2001-12-17 Ravi Pratap <ravi@ximian.com>
25276 * delegate.cs (Delegate.Populate): Check that the return type
25277 and various parameters types are indeed accessible.
25279 * class.cs (Constructor.Define): Same here.
25281 (Field.Define): Ditto.
25283 (Event.Define): Ditto.
25285 (Operator.Define): Check that the underlying Method defined itself
25286 correctly - so it's MethodBuilder should not be null.
25288 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
25289 expression happens to be null.
25291 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
25292 members but as of now we don't seem to be able to do anything really useful with it.
25294 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
25295 not the EventBuilder.
25297 2001-12-18 Miguel de Icaza <miguel@ximian.com>
25299 * cs-tokenizer.cs: Add support for defines.
25300 Add support for #if, #elif, #else, #endif
25302 (eval_var): evaluates a variable.
25303 (eval): stubbed for evaluating functions.
25305 * cs-parser.jay: Pass the defines information
25307 * driver.cs: Add --define command line option.
25309 * decl.cs: Move MemberCore here.
25311 Make it the base class for DeclSpace. This allows us to catch and
25312 report 108 and 109 for everything now.
25314 * class.cs (TypeContainer.Define): Extract all the members
25315 before populating and emit the warning 108 (new keyword required
25316 to override) instead of having each member implement this.
25318 (MemberCore.Define): New abstract method, we will be using this in
25319 the warning reporting engine in Populate.
25321 (Operator.Define): Adjust to new MemberCore protocol.
25323 * const.cs (Const): This does not derive from Expression, it is a
25324 temporary object we use to create fields, it is a MemberCore.
25326 * class.cs (Method.Define): Allow the entry point to be in a
25329 * driver.cs: Rewrite the argument handler to clean it up a bit.
25331 * rootcontext.cs: Made it just an auxiliary namespace feature by
25332 making everything static.
25334 * driver.cs: Adapt code to use RootContext type name instead of
25337 * delegate.cs: Remove RootContext argument.
25339 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
25342 * class.cs (Event.Define): The lookup can fail.
25344 * cs-tokenizer.cs: Begin implementation of pre-procesor.
25346 * expression.cs: Resolve the this instance before invoking the code.
25348 2001-12-17 Miguel de Icaza <miguel@ximian.com>
25350 * cs-parser.jay: Add a production in element_access that allows
25351 the thing to become a "type" reference. This way we can parse
25352 things like "(string [])" as a type.
25354 Note that this still does not handle the more complex rules of
25358 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
25360 * ecore.cs: (CopyNewMethods): new utility function used to
25361 assemble the list of methods from running FindMembers.
25363 (MemberLookup): Rework FindMembers so that
25365 2001-12-16 Miguel de Icaza <miguel@ximian.com>
25367 * class.cs (TypeContainer): Remove Delegates who fail to be
25370 * delegate.cs (Populate): Verify that we dont get null return
25371 values. TODO: Check for AsAccessible.
25373 * cs-parser.jay: Use basename to emit error 574 (destructor should
25374 have the same name as container class), not the full name.
25376 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
25377 possible representation.
25379 Also implements integer type suffixes U and L.
25381 2001-12-15 Miguel de Icaza <miguel@ximian.com>
25383 * expression.cs (ArrayCreation.DoResolve): We need to do the
25384 argument resolution *always*.
25386 * decl.cs: Make this hold the namespace. Hold the root context as
25388 (LookupType): Move here.
25390 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
25392 * location.cs (Row, Name): Fixed the code, it was always returning
25393 references to the first file.
25395 * interface.cs: Register properties defined through interfaces.
25397 * driver.cs: Add support for globbing on the command line
25399 * class.cs (Field): Make it derive from MemberCore as well.
25402 2001-12-15 Ravi Pratap <ravi@ximian.com>
25404 * class.cs (Event::Define): Check that the type of the event is a delegate
25405 type else flag error #66.
25407 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
25410 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
25411 values of EntryPoint, CharSet etc etc.
25413 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
25415 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
25416 be null and we should ignore this. I am not sure if this is really clean. Apparently,
25417 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
25418 which needs this to do its work.
25420 * ../errors/cs0066.cs : Add.
25422 2001-12-14 Miguel de Icaza <miguel@ximian.com>
25424 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
25427 * class.cs: (MethodSignature.MethodSignature): Removed hack that
25428 clears out the parameters field.
25429 (MemberSignatureCompare): Cleanup
25431 (MemberCore): New base class used to share code between MethodCore
25434 (RegisterRequiredImplementations) BindingFlags.Public requires
25435 either BindingFlags.Instace or Static. Use instance here.
25437 (Property): Refactored code to cope better with the full spec.
25439 * parameter.cs (GetParameterInfo): Return an empty array instead
25442 * class.cs (Property): Abstract or extern properties have no bodies.
25444 * parameter.cs (GetParameterInfo): return a zero-sized array.
25446 * class.cs (TypeContainer.MethodModifiersValid): Move all the
25447 method modifier validation to the typecontainer so we can reuse
25448 this on properties.
25450 (MethodCore.ParameterTypes): return an empty sized array of types.
25452 (Property.Define): Test property modifier validity.
25454 Add tests for sealed/override too.
25456 (Method.Emit): abstract or extern methods have no bodies.
25458 2001-12-14 Ravi Pratap <ravi@ximian.com>
25460 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
25463 (Method::Define, ::Emit): Modify accordingly.
25465 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
25467 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
25469 * makefile: Pass in /unsafe.
25471 2001-12-13 Miguel de Icaza <miguel@ximian.com>
25473 * class.cs (MakeKey): Kill routine.
25475 * class.cs (TypeContainer.Define): Correctly define explicit
25476 method implementations (they require the full interface name plus
25479 * typemanager.cs: Deply the PtrHashtable here and stop using the
25480 lame keys. Things work so much better.
25482 This of course broke everyone who depended on `RegisterMethod' to
25483 do the `test for existance' test. This has to be done elsewhere.
25485 * support.cs (PtrHashtable): A hashtable that avoid comparing with
25486 the object stupid Equals method (because, that like fails all over
25487 the place). We still do not use it.
25489 * class.cs (TypeContainer.SetRequiredInterface,
25490 TypeContainer.RequireMethods): Killed these two routines and moved
25491 all the functionality to RegisterRequiredImplementations.
25493 (TypeContainer.RegisterRequiredImplementations): This routine now
25494 registers all the implementations required in an array for the
25495 interfaces and abstract methods. We use an array of structures
25496 which can be computed ahead of time to reduce memory usage and we
25497 also assume that lookups are cheap as most classes will not
25498 implement too many interfaces.
25500 We also avoid creating too many MethodSignatures.
25502 (TypeContainer.IsInterfaceMethod): Update and optionally does not
25503 clear the "pending" bit if we find that there are problems with
25506 (TypeContainer.VerifyPendingMethods): Update to report errors of
25507 methods that look like implementations but are not.
25509 (TypeContainer.Define): Add support for explicit interface method
25512 2001-12-12 Miguel de Icaza <miguel@ximian.com>
25514 * typemanager.cs: Keep track of the parameters here instead of
25515 being a feature of the TypeContainer.
25517 * class.cs: Drop the registration of parameters here, as
25518 InterfaceMethods are also interface declarations.
25520 * delegate.cs: Register methods with the TypeManager not only with
25521 the TypeContainer. This code was buggy.
25523 * interface.cs: Full registation here.
25525 2001-12-11 Miguel de Icaza <miguel@ximian.com>
25527 * expression.cs: Remove reducer for binary expressions, it can not
25530 * const.cs: Put here the code that used to go into constant.cs
25532 * constant.cs: Put here the code for constants, this is a new base
25533 class for Literals.
25535 * literal.cs: Make Literal derive from Constant.
25537 2001-12-09 Miguel de Icaza <miguel@ximian.com>
25539 * statement.cs (Return.Emit): Report error 157 if the user
25540 attempts to return from a finally block.
25542 (Return.Emit): Instead of emitting a return, jump to the end of
25545 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
25546 LocalBuilder to store the result of the function. ReturnLabel is
25547 the target where we jump.
25550 2001-12-09 Radek Doulik <rodo@ximian.com>
25552 * cs-parser.jay: remember alias in current namespace
25554 * ecore.cs (SimpleName::DoResolve): use aliases for types or
25557 * class.cs (LookupAlias): lookup alias in my_namespace
25559 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
25561 (LookupAlias): lookup alias in this and if needed in parent
25564 2001-12-08 Miguel de Icaza <miguel@ximian.com>
25568 * rootcontext.cs: (ModuleBuilder) Made static, first step into
25569 making things static. I need this to avoid passing the
25570 TypeContainer when calling ParameterType.
25572 * support.cs (InternalParameters.ParameterType): Remove ugly hack
25573 that did string manipulation to compute the type and then call
25574 GetType. Use Parameter.ParameterType instead.
25576 * cs-tokenizer.cs: Consume the suffix for floating values.
25578 * expression.cs (ParameterReference): figure out whether this is a
25579 reference parameter or not. Kill an extra variable by computing
25580 the arg_idx during emission.
25582 * parameter.cs (Parameters.GetParameterInfo): New overloaded
25583 function that returns whether a parameter is an out/ref value or not.
25585 (Parameter.ParameterType): The type of the parameter (base,
25586 without ref/out applied).
25588 (Parameter.Resolve): Perform resolution here.
25589 (Parameter.ExternalType): The full type (with ref/out applied).
25591 * statement.cs (Using.Emit, Using.EmitExpression): Implement
25592 support for expressions on the using statement.
25594 2001-12-07 Miguel de Icaza <miguel@ximian.com>
25596 * statement.cs (Using.EmitLocalVariableDecls): Split the
25597 localvariable handling of the using statement.
25599 (Block.EmitMeta): Keep track of variable count across blocks. We
25600 were reusing slots on separate branches of blocks.
25602 (Try.Emit): Emit the general code block, we were not emitting it.
25604 Check the type of the declaration to be an IDisposable or
25605 something that can be implicity converted to it.
25607 Emit conversions if required.
25609 * ecore.cs (EmptyExpression): New utility class.
25610 (Expression.ImplicitConversionExists): New utility function.
25612 2001-12-06 Miguel de Icaza <miguel@ximian.com>
25614 * statement.cs (Using): Implement.
25616 * expression.cs (LocalVariableReference): Support read only variables.
25618 * statement.cs: Remove the explicit emit for the Leave opcode.
25619 (VariableInfo): Add a readonly field.
25621 2001-12-05 Miguel de Icaza <miguel@ximian.com>
25623 * ecore.cs (ConvCast): new class used to encapsulate the various
25624 explicit integer conversions that works in both checked and
25625 unchecked contexts.
25627 (Expression.ConvertNumericExplicit): Use new ConvCast class to
25628 properly generate the overflow opcodes.
25630 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25632 * statement.cs: The correct type for the EmptyExpression is the
25633 element_type, not the variable type. Ravi pointed this out.
25635 2001-12-04 Ravi Pratap <ravi@ximian.com>
25637 * class.cs (Method::Define): Handle PInvoke methods specially
25638 by using DefinePInvokeMethod instead of the usual one.
25640 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
25641 above to do the task of extracting information and defining the method.
25643 2001-12-04 Ravi Pratap <ravi@ximian.com>
25645 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
25646 of the condition for string type.
25648 (Emit): Move that here.
25650 (ArrayCreation::CheckIndices): Keep string literals in their expression
25653 (EmitDynamicInitializers): Handle strings appropriately.
25655 2001-12-04 Miguel de Icaza <miguel@ximian.com>
25657 * codegen.cs (EmitContext): Replace multiple variables with a
25658 single pointer to the current Switch statement.
25660 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
25663 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25667 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
25670 (Foreach.Emit): Foreach on arrays was not setting
25671 up the loop variables (for break/continue).
25673 (GotoCase): Semi-implented.
25675 2001-12-03 Ravi Pratap <ravi@ximian.com>
25677 * attribute.cs (CheckAttribute): Handle system attributes by using
25678 Attribute.GetAttributes to examine information we need.
25680 (GetValidPlaces): Same here.
25682 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
25684 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
25686 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
25688 (Method::Define): Set appropriate flags if we have a DllImport attribute.
25690 (Method::Emit): Handle the case when we are a PInvoke method.
25692 2001-12-03 Miguel de Icaza <miguel@ximian.com>
25694 * expression.cs: Use ResolveWithSimpleName on compound names.
25696 2001-12-02 Ravi Pratap <ravi@ximian.com>
25698 * constant.cs (EmitConstant): Make sure we resolve the associated expression
25699 before trying to reduce it.
25701 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
25703 * constant.cs (LookupConstantValue): Implement.
25705 (EmitConstant): Use the above in emitting the constant.
25707 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
25708 that are user-defined by doing a LookupConstantValue on them.
25710 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
25713 2001-11-29 Miguel de Icaza <miguel@ximian.com>
25715 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
25717 (BaseAccess.DoResolve): Implement.
25719 (MemberAccess.DoResolve): Split this routine into a
25720 ResolveMemberAccess routine that can be used independently
25722 2001-11-28 Miguel de Icaza <miguel@ximian.com>
25724 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
25725 As that share bits of the implementation. Is returns a boolean,
25726 while As returns the Type that is being probed.
25728 2001-12-01 Ravi Pratap <ravi@ximian.com>
25730 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
25731 instead of a Literal - much easier.
25733 (EnumInTransit): Remove - utterly useless :-)
25735 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
25737 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
25739 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
25740 chain when we have no associated expression.
25742 2001-11-30 Ravi Pratap <ravi@ximian.com>
25744 * constant.cs (Define): Use Location while reporting the errror.
25746 Also emit a warning when 'new' is used and there is no inherited
25749 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
25752 (LookupEnumValue): Implement to lookup an enum member's value and define it
25755 (Populate): Re-write accordingly to use the above routine.
25757 2001-11-27 Miguel de Icaza <miguel@ximian.com>
25759 * expression.cs (This): Fix prototype for DoResolveLValue to
25760 override the base class DoResolveLValue.
25762 * cs-parser.cs: Report errors cs574 and cs575 (destructor
25765 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
25766 (we need to load the address of the field here). This fixes
25769 (FieldExpr.DoResolveLValue): Call the DoResolve
25770 function to initialize the Instance expression.
25772 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
25773 correctly the GetEnumerator operation on a value type.
25775 * cs-parser.jay: Add more simple parsing error catches.
25777 * statement.cs (Switch): Add support for string switches.
25778 Handle null specially.
25780 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
25782 2001-11-28 Ravi Pratap <ravi@ximian.com>
25784 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
25786 (declare_local_constant): New helper function.
25788 * statement.cs (AddConstant): Keep a separate record of constants
25790 (IsConstant): Implement to determine if a variable is a constant.
25792 (GetConstantExpression): Implement.
25794 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
25796 * statement.cs (IsVariableDefined): Re-write.
25798 2001-11-27 Ravi Pratap <ravi@ximian.com>
25800 * class.cs (TypeContainer::FindMembers): Look for constants
25801 in the case when we are looking for MemberTypes.Field
25803 * expression.cs (MemberAccess::DoResolve): Check that in the
25804 case we are a FieldExpr and a Literal, we are not being accessed
25805 by an instance reference.
25807 * cs-parser.jay (local_constant_declaration): Implement.
25809 (declaration_statement): Implement for constant declarations.
25811 2001-11-26 Miguel de Icaza <miguel@ximian.com>
25813 * statement.cs (Switch): Catch double defaults.
25815 (Switch): More work on the switch() statement
25816 implementation. It works for integral values now, need to finish
25820 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25822 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
25823 integer literals into other integer literals. To be used by
25826 2001-11-24 Ravi Pratap <ravi@ximian.com>
25828 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
25831 (EmitDynamicInitializers): Cope with the above since we extract data
25832 directly from ArrayData now.
25834 (ExpectInitializers): Keep track of whether initializers are mandatory
25837 (Bounds): Make it a hashtable to prevent the same dimension being
25838 recorded for every element in that dimension.
25840 (EmitDynamicInitializers): Fix bug which prevented the Set array method
25843 Also fix bug which was causing the indices to be emitted in the reverse
25846 2001-11-24 Miguel de Icaza <miguel@ximian.com>
25848 * expression.cs (ArrayCreation): Implement the bits that Ravi left
25849 unfinished. They do not work, because the underlying code is
25852 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25854 * cs-parser.jay: Remove bogus fixme.
25856 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
25857 on Switch statement.
25859 2001-11-23 Ravi Pratap <ravi@ximian.com>
25861 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
25864 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
25865 parameter. Apparently, any expression is allowed.
25867 (ValidateInitializers): Update accordingly.
25869 (CheckIndices): Fix some tricky bugs thanks to recursion.
25871 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
25872 I was being completely brain-dead.
25874 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
25875 and re-write acordingly.
25877 (DelegateInvocation): Re-write accordingly.
25879 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
25881 (MakeByteBlob): Handle types more correctly.
25883 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
25884 initialization from expressions but it is incomplete because I am a complete
25887 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25889 * statement.cs (If.Emit): Fix a bug that generated incorrect code
25890 on If. Basically, we have to return `true' (ie, we do return to
25891 our caller) only if both branches of the if return.
25893 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
25894 short-circuit operators, handle them as short circuit operators.
25896 (Cast.DoResolve): Resolve type.
25897 (Cast.Cast): Take an expression as the target type.
25899 * cs-parser.jay (cast_expression): Remove old hack that only
25900 allowed a limited set of types to be handled. Now we take a
25901 unary_expression and we resolve to a type during semantic
25904 Use the grammar productions from Rhys to handle casts (this is
25905 not complete like Rhys syntax yet, we fail to handle that corner
25906 case that C# has regarding (-x), but we will get there.
25908 2001-11-22 Ravi Pratap <ravi@ximian.com>
25910 * class.cs (EmitFieldInitializer): Take care of the case when we have a
25911 field which is an array type.
25913 * cs-parser.jay (declare_local_variables): Support array initialization too.
25915 * typemanager.cs (MakeKey): Implement.
25917 (everywhere): Use the above appropriately.
25919 * cs-parser.jay (for_statement): Update for array initialization while
25920 declaring variables.
25922 * ecore.cs : The error message was correct, it's the variable's names that
25923 were misleading ;-) Make the code more readable.
25925 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
25926 the correct type etc.
25928 (ConvertExplicit): Handle Enum types by examining the underlying type.
25930 2001-11-21 Ravi Pratap <ravi@ximian.com>
25932 * parameter.cs (GetCallingConvention): Always return
25933 CallingConventions.Standard for now.
25935 2001-11-22 Miguel de Icaza <miguel@ximian.com>
25937 * expression.cs (Binary.ResolveOperator): Update the values of `l'
25938 and `r' after calling DoNumericPromotions.
25940 * ecore.cs: Fix error message (the types were in the wrong order).
25942 * statement.cs (Foreach.ProbeCollectionType): Need to pass
25943 BindingFlags.Instance as well
25945 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
25946 implicit int literal conversion in an empty cast so that we
25947 propagate the right type upstream.
25949 (UnboxCast): new class used to unbox value types.
25950 (Expression.ConvertExplicit): Add explicit type conversions done
25953 (Expression.ImplicitNumericConversion): Oops, forgot to test for
25954 the target type before applying the implicit LongLiterals to ULong
25957 2001-11-21 Miguel de Icaza <miguel@ximian.com>
25959 * cs-parser.jay (for_statement): Reworked the way For works: now
25960 we declare manually any variables that are introduced in
25961 for_initializer to solve the problem of having out-of-band code
25962 emition (that is what got for broken).
25964 (declaration_statement): Perform the actual variable declaration
25965 that used to be done in local_variable_declaration here.
25967 (local_variable_declaration): Do not declare anything, just pass
25968 the information on a DictionaryEntry
25970 2001-11-20 Ravi Pratap <ravi@ximian.com>
25972 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
25973 re-write of the logic to now make it recursive.
25975 (UpdateIndices): Re-write accordingly.
25977 Store element data in a separate ArrayData list in the above methods.
25979 (MakeByteBlob): Implement to dump the array data into a byte array.
25981 2001-11-19 Ravi Pratap <ravi@ximian.com>
25983 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
25986 * constant.cs (Define): Implement.
25988 (EmitConstant): Re-write fully.
25990 Pass in location info.
25992 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
25995 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
25996 DictionaryEntry since we need location info too.
25998 (constant_declaration): Update accordingly.
26000 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
26001 code into another method : UpdateIndices.
26003 2001-11-18 Ravi Pratap <ravi@ximian.com>
26005 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
26006 some type checking etc.
26008 2001-11-17 Ravi Pratap <ravi@ximian.com>
26010 * expression.cs (ArrayCreation::ValidateInitializers): Implement
26011 bits to provide dimension info if the user skips doing that.
26013 Update second constructor to store the rank correctly.
26015 2001-11-16 Ravi Pratap <ravi@ximian.com>
26017 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
26018 and try to implement.
26020 * ../errors/cs0150.cs : Add.
26022 * ../errors/cs0178.cs : Add.
26024 2001-11-16 Miguel de Icaza <miguel@ximian.com>
26026 * statement.cs: Implement foreach on multi-dimensional arrays.
26028 * parameter.cs (Parameters.GetParameterByName): Also lookup the
26029 name of the params argument.
26031 * expression.cs: Use EmitStoreOpcode to get the right opcode while
26032 initializing the array.
26034 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
26035 we can use this elsewhere.
26037 * statement.cs: Finish implementation of foreach for single
26040 * cs-parser.jay: Use an out-of-band stack to pass information
26041 around, I wonder why I need this.
26043 foreach_block: Make the new foreach_block the current_block.
26045 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
26046 function used to return a static Parameters structure. Used for
26047 empty parameters, as those are created very frequently.
26049 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
26051 2001-11-15 Ravi Pratap <ravi@ximian.com>
26053 * interface.cs : Default modifier is private, not public. The
26054 make verify test passes again.
26056 2001-11-15 Ravi Pratap <ravi@ximian.com>
26058 * support.cs (ReflectionParameters): Fix logic to determine
26059 whether the last parameter is a params one. Test 9 passes again.
26061 * delegate.cs (Populate): Register the builders we define with
26062 RegisterParameterForBuilder. Test 19 passes again.
26064 * cs-parser.jay (property_declaration): Reference $6 instead
26065 of $$ to get at the location.
26067 (indexer_declaration): Similar stuff.
26069 (attribute): Ditto.
26071 * class.cs (Property): Register parameters for the Get and Set methods
26072 if they exist. Test 23 passes again.
26074 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
26075 call to EmitArguments as we are sure there aren't any params arguments.
26076 Test 32 passes again.
26078 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
26079 IndexOutOfRangeException.
26081 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
26082 Test 33 now passes again.
26084 2001-11-15 Miguel de Icaza <miguel@ximian.com>
26086 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
26087 broke a bunch of things. Will have to come up with a better way
26088 of tracking locations.
26090 * statement.cs: Implemented foreach for single dimension arrays.
26092 2001-11-09 Miguel de Icaza <miguel@ximian.com>
26094 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
26095 an error. This removes the lookup from the critical path.
26097 * cs-parser.jay: Removed use of temporary_loc, which is completely
26100 2001-11-14 Miguel de Icaza <miguel@ximian.com>
26102 * support.cs (ReflectionParameters.ParameterModifier): Report
26103 whether the argument is a PARAMS argument or not.
26105 * class.cs: Set the attribute `ParamArrayAttribute' on the
26106 parameter argument.
26108 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
26109 and cons_param_array_attribute (ConstructorInfo for
26110 ParamArrayAttribute).,
26112 * codegen.cs: Emit the return using the `Return' statement, that
26113 way we can report the error correctly for missing return values.
26115 * class.cs (Method.Emit): Clean up.
26117 * expression.cs (Argument.Resolve): Take another argument: the
26118 location where this argument is used. Notice that this is not
26119 part of the "Argument" class as to reduce the size of the
26120 structure (we know the approximate location anyways).
26122 Test if the argument is a variable-reference, if not, then
26123 complain with a 206.
26125 (Argument.Emit): Emit addresses of variables.
26127 (Argument.FullDesc): Simplify.
26129 (Invocation.DoResolve): Update for Argument.Resolve.
26131 (ElementAccess.DoResolve): ditto.
26133 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
26134 method should be virtual, as this method is always virtual.
26136 (NewDelegate.DoResolve): Update for Argument.Resolve.
26138 * class.cs (ConstructorInitializer.DoResolve): ditto.
26140 * attribute.cs (Attribute.Resolve): ditto.
26142 2001-11-13 Miguel de Icaza <miguel@ximian.com>
26144 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
26146 * expression.cs (ParameterReference): Drop IStackStorage and implement
26147 IAssignMethod instead.
26149 (LocalVariableReference): ditto.
26151 * ecore.cs (FieldExpr): Drop IStackStorage and implement
26152 IAssignMethod instead.
26154 2001-11-13 Miguel de Icaza <miguel@ximian.com>
26156 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
26157 enumerations that are used in heavily used structures derive from
26158 byte in a laughable and pathetic attempt to reduce memory usage.
26159 This is the kind of pre-optimzations that you should not do at
26160 home without adult supervision.
26162 * expression.cs (UnaryMutator): New class, used to handle ++ and
26163 -- separatedly from the other unary operators. Cleans up the
26164 code, and kills the ExpressionStatement dependency in Unary.
26166 (Unary): Removed `method' and `Arguments' from this class, making
26167 it smaller, and moving it all to SimpleCall, so I can reuse this
26168 code in other locations and avoid creating a lot of transient data
26169 strucutres when not required.
26171 * cs-parser.jay: Adjust for new changes.
26173 2001-11-11 Miguel de Icaza <miguel@ximian.com>
26175 * enum.cs (Enum.Populate): If there is a failure during
26178 * cs-parser.jay (opt_enum_base): we used to catch type errors
26179 here, but this is really incorrect. The type error should be
26180 catched during semantic analysis.
26182 2001-12-11 Ravi Pratap <ravi@ximian.com>
26184 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
26185 current_local_parameters as expected since I, in my stupidity, had forgotten
26188 * attribute.cs (GetValidPlaces): Fix stupid bug.
26190 * class.cs (Method::Emit): Perform check on applicability of attributes.
26192 (Constructor::Emit): Ditto.
26194 (Field::Emit): Ditto.
26196 (Field.Location): Store location information.
26198 (Property, Event, Indexer, Operator): Ditto.
26200 * cs-parser.jay (field_declaration): Pass in location for each field.
26202 * ../errors/cs0592.cs : Add.
26204 2001-11-12 Ravi Pratap <ravi@ximian.com>
26206 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
26208 (InitCoreTypes): Update accordingly.
26210 (RegisterAttrType, LookupAttr): Implement.
26212 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
26213 info about the same.
26215 (Resolve): Update to populate the above as necessary.
26217 (Error592): Helper.
26219 (GetValidPlaces): Helper to the above.
26221 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
26223 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
26225 2001-11-12 Ravi Pratap <ravi@ximian.com>
26227 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
26229 * ../errors/cs0617.cs : Add.
26231 2001-11-11 Ravi Pratap <ravi@ximian.com>
26233 * enum.cs (Emit): Rename to Populate to be more consistent with what
26234 we expect it to do and when exactly it is called.
26236 * class.cs, rootcontext.cs : Update accordingly.
26238 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
26239 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
26241 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
26243 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
26244 of a fieldinfo using the above, when dealing with a FieldBuilder.
26246 2001-11-10 Ravi Pratap <ravi@ximian.com>
26248 * ../errors/cs0031.cs : Add.
26250 * ../errors/cs1008.cs : Add.
26252 * ../errrors/cs0543.cs : Add.
26254 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
26257 (FindMembers): Implement.
26259 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
26260 enums and delegates too.
26262 (enum_types): Rename to builder_to_enum.
26264 (delegate_types): Rename to builder_to_delegate.
26266 * delegate.cs (FindMembers): Implement.
26268 2001-11-09 Ravi Pratap <ravi@ximian.com>
26270 * typemanager.cs (IsEnumType): Implement.
26272 * enum.cs (Emit): Re-write parts to account for the underlying type
26273 better and perform checking etc.
26275 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
26276 of the underlying type.
26278 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
26281 * enum.cs (error31): Helper to report error #31.
26283 * cs-parser.jay (enum_declaration): Store location of each member too.
26285 * enum.cs (member_to_location): New hashtable.
26287 (AddEnumMember): Update location hashtable.
26289 (Emit): Use the location of each member while reporting errors.
26291 2001-11-09 Miguel de Icaza <miguel@ximian.com>
26293 * cs-parser.jay: A for_initializer if is a
26294 local_variable_declaration really ammount to have an implicit
26295 block with the variable declaration and no initializer for for.
26297 * statement.cs (For.Emit): Cope with null initializers.
26299 This fixes the infinite loop on for initializers.
26301 2001-11-08 Miguel de Icaza <miguel@ximian.com>
26303 * enum.cs: More cleanup.
26305 * ecore.cs: Remove dead code.
26307 * class.cs (Property.Emit): More simplification.
26308 (Event.Emit): ditto.
26310 Reworked to have less levels of indentation.
26312 2001-11-08 Ravi Pratap <ravi@ximian.com>
26314 * class.cs (Property): Emit attributes.
26324 * enum.cs (Emit): Ditto.
26326 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
26329 * class.cs (Field, Event, etc.): Move attribute generation into the
26330 Emit method everywhere.
26332 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
26333 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
26334 as we had no way of defining nested enums !
26336 * rootcontext.cs : Adjust code accordingly.
26338 * typemanager.cs (AddEnumType): To keep track of enum types separately.
26340 2001-11-07 Ravi Pratap <ravi@ximian.com>
26342 * expression.cs (EvalConstantExpression): Move into ecore.cs
26344 * enum.cs (Enum): Rename some members and make them public and readonly
26345 according to our convention.
26347 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
26350 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
26352 (Enum::Emit): Write a simple version for now which doesn't try to compute
26353 expressions. I shall modify this to be more robust in just a while.
26355 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
26357 (TypeContainer::CloseType): Create the Enum types too.
26359 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
26361 * expression.cs (EvalConstantExpression): Get rid of completely.
26363 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
26364 user-defined values and other cases.
26366 (IsValidEnumLiteral): Helper function.
26368 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
26369 out there in the case we had a literal FieldExpr.
26371 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
26373 (Literalize): Revamp a bit to take two arguments.
26375 (EnumLiteral): New class which derives from Literal to wrap enum literals.
26377 2001-11-06 Ravi Pratap <ravi@ximian.com>
26379 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
26381 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
26383 (Resolve): Use the above to ensure we have proper initializers.
26385 2001-11-05 Ravi Pratap <ravi@ximian.com>
26387 * expression.cs (Expression::EvalConstantExpression): New method to
26388 evaluate constant expressions.
26390 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
26392 2001-11-07 Miguel de Icaza <miguel@ximian.com>
26394 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
26397 (Binary.ResolveOperator): Handle operator != (object a, object b)
26398 and operator == (object a, object b);
26400 (Binary.DoNumericPromotions): Indicate whether the numeric
26401 promotion was possible.
26403 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
26406 Made the ArrayAccess implement interface IAssignMethod instead of
26407 IStackStore as the order in which arguments are passed reflects
26410 * assign.cs: Instead of using expr.ExprClass to select the way of
26411 assinging, probe for the IStackStore/IAssignMethod interfaces.
26413 * typemanager.cs: Load InitializeArray definition.
26415 * rootcontext.cs (RootContext.MakeStaticData): Used to define
26416 static data that can be used to initialize arrays.
26418 2001-11-05 Miguel de Icaza <miguel@ximian.com>
26420 * expression.cs: Handle operator== and operator!= for booleans.
26422 (Conditioal.Reduce): Implement reducer for the ?: operator.
26424 (Conditional.Resolve): Implement dead code elimination.
26426 (Binary.Resolve): Catch string literals and return a new
26427 concatenated string.
26429 (Unary.Reduce): Implement reduction of unary expressions.
26431 * ecore.cs: Split out the expression core handling here.
26433 (Expression.Reduce): New method used to perform constant folding
26434 and CSE. This is needed to support constant-expressions.
26436 * statement.cs (Statement.EmitBoolExpression): Pass true and false
26437 targets, and optimize for !x.
26439 2001-11-04 Ravi Pratap <ravi@ximian.com>
26441 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
26442 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
26443 set custom atttributes.
26445 * literal.cs (Literal::GetValue): New abstract method to return the actual
26446 value of the literal, cast as an object.
26448 (*Literal): Implement GetValue method.
26450 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
26451 expressions to the arraylist but objects of type Argument.
26453 * class.cs (TypeContainer::Emit): Emit our attributes too.
26455 (Method::Emit, Constructor::Emit): Ditto.
26457 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
26458 to be ignoring earlier.
26460 2001-11-03 Ravi Pratap <ravi@ximian.com>
26462 * attribute.cs (AttributeSection::Define): Implement to do the business
26463 of constructing a CustomAttributeBuilder.
26465 (Attribute): New trivial class. Increases readability of code.
26467 * cs-parser.jay : Update accordingly.
26469 (positional_argument_list, named_argument_list, named_argument): New rules
26471 (attribute_arguments): Use the above so that we are more correct.
26473 2001-11-02 Ravi Pratap <ravi@ximian.com>
26475 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
26476 to perform all checks for a method with a params parameter.
26478 (Invocation::OverloadResolve): Update to use the above method and therefore
26479 cope correctly with params method invocations.
26481 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
26484 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
26485 constructors in our parent too because we can't afford to miss out on
26488 * attribute.cs (AttributeSection): New name for the class Attribute
26490 Other trivial changes to improve readability.
26492 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
26493 use the new class names.
26495 2001-11-01 Ravi Pratap <ravi@ximian.com>
26497 * class.cs (Method::Define): Complete definition for params types too
26499 (Indexer::Define): Ditto.
26501 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
26502 Cope everywhere with a request for info about the array parameter.
26504 2001-11-01 Ravi Pratap <ravi@ximian.com>
26506 * tree.cs (RecordNamespace): Fix up to check for the correct key.
26508 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
26509 local_variable_type to extract the string corresponding to the type.
26511 (local_variable_type): Fixup the action to use the new helper method.
26513 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
26516 * expression.cs : Clean out code which uses the above.
26518 2001-10-31 Ravi Pratap <ravi@ximian.com>
26520 * typemanager.cs (RegisterMethod): Check if we already have an existing key
26521 and bale out if necessary by returning a false.
26523 (RegisterProperty): Ditto.
26525 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
26526 and print out appropriate error messages.
26528 * interface.cs (everywhere): Ditto.
26530 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
26531 location to constructor.
26533 * class.cs (Property, Event, Indexer): Update accordingly.
26535 * ../errors/cs111.cs : Added.
26537 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
26538 of a method, as laid down by the spec.
26540 (Invocation::OverloadResolve): Use the above method.
26542 2001-10-31 Ravi Pratap <ravi@ximian.com>
26544 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
26545 now take a TypeContainer and a Parameters object.
26547 (ParameterData): Modify return type of ParameterModifier method to be
26548 Parameter.Modifier and not a string.
26550 (ReflectionParameters, InternalParameters): Update accordingly.
26552 * expression.cs (Argument::GetParameterModifier): Same here.
26554 * support.cs (InternalParameters::ParameterType): Find a better way of determining
26555 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
26556 symbol in it at all so maybe this is only for now.
26558 2001-10-30 Ravi Pratap <ravi@ximian.com>
26560 * support.cs (InternalParameters): Constructor now takes an extra argument
26561 which is the actual Parameters class.
26563 (ParameterDesc): Update to provide info on ref/out modifiers.
26565 * class.cs (everywhere): Update call to InternalParameters to pass in
26566 the second argument too.
26568 * support.cs (ParameterData): Add ParameterModifier, which is a method
26569 to return the modifier info [ref/out etc]
26571 (InternalParameters, ReflectionParameters): Implement the above.
26573 * expression.cs (Argument::ParameterModifier): Similar function to return
26574 info about the argument's modifiers.
26576 (Invocation::OverloadResolve): Update to take into account matching modifiers
26579 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
26580 a new SetFormalParameters object which we pass to InternalParameters.
26582 2001-10-30 Ravi Pratap <ravi@ximian.com>
26584 * expression.cs (NewArray): Merge into the ArrayCreation class.
26586 2001-10-29 Ravi Pratap <ravi@ximian.com>
26588 * expression.cs (NewArray): Merge classes NewBuiltinArray and
26589 NewUserdefinedArray into one as there wasn't much of a use in having
26592 * expression.cs (Argument): Change field's name to ArgType from Type.
26594 (Type): New readonly property which returns the proper type, taking into
26595 account ref/out modifiers.
26597 (everywhere): Adjust code accordingly for the above.
26599 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
26600 whether we are emitting for a ref or out parameter.
26602 * expression.cs (Argument::Emit): Use the above field to set the state.
26604 (LocalVariableReference::Emit): Update to honour the flag and emit the
26607 * parameter.cs (Attributes): Set the correct flags for ref parameters.
26609 * expression.cs (Argument::FullDesc): New function to provide a full desc.
26611 * support.cs (ParameterData): Add method ParameterDesc to the interface.
26613 (ReflectionParameters, InternalParameters): Implement the above method.
26615 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
26618 (Invocation::FullMethodDesc): Ditto.
26620 2001-10-29 Miguel de Icaza <miguel@ximian.com>
26622 * cs-parser.jay: Add extra production for the second form of array
26625 * expression.cs (ArrayCreation): Update to reflect the above
26628 * Small changes to prepare for Array initialization.
26630 2001-10-28 Miguel de Icaza <miguel@ximian.com>
26632 * typemanager.cs (ImplementsInterface): interface might be null;
26633 Deal with this problem;
26635 Also, we do store negative hits on the cache (null values), so use
26636 this instead of calling t.GetInterfaces on the type everytime.
26638 2001-10-28 Ravi Pratap <ravi@ximian.com>
26640 * typemanager.cs (IsBuiltinType): New method to help determine the same.
26642 * expression.cs (New::DoResolve): Get rid of array creation code and instead
26643 split functionality out into different classes.
26645 (New::FormArrayType): Move into NewBuiltinArray.
26647 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
26650 (NewBuiltinArray): New class to handle creation of built-in arrays.
26652 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
26653 account creation of one-dimensional arrays.
26655 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
26657 (NewUserdefinedArray::DoResolve): Implement.
26659 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
26661 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
26662 we maintain inside the TypeManager. This is necessary to perform lookups on the
26665 (LookupType): Update to perform GetType on the module builders too.
26667 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
26669 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
26671 2001-10-23 Ravi Pratap <ravi@ximian.com>
26673 * expression.cs (New::DoResolve): Implement guts of array creation.
26675 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
26677 2001-10-27 Miguel de Icaza <miguel@ximian.com>
26679 * expression.cs: Fix bug I introduced lsat night that broke
26682 (Expression.Resolve): Report a 246 error (can not resolve name)
26683 if we find a SimpleName in the stream.
26685 (Expression.ResolveLValue): Ditto.
26687 (Expression.ResolveWithSimpleName): This function is a variant of
26688 ResolveName, this one allows SimpleNames to be returned without a
26689 warning. The only consumer of SimpleNames is MemberAccess
26691 2001-10-26 Miguel de Icaza <miguel@ximian.com>
26693 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
26694 might arrive here. I have my doubts that this is correct.
26696 * statement.cs (Lock): Implement lock statement.
26698 * cs-parser.jay: Small fixes to support `lock' and `using'
26700 * cs-tokenizer.cs: Remove extra space
26702 * driver.cs: New flag --checked, allows to turn on integer math
26705 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
26706 Threading.Monitor.Exit
26708 2001-10-23 Miguel de Icaza <miguel@ximian.com>
26710 * expression.cs (IndexerAccess::DoResolveLValue): Set the
26711 Expression Class to be IndexerAccess.
26713 Notice that Indexer::DoResolve sets the eclass to Value.
26715 2001-10-22 Miguel de Icaza <miguel@ximian.com>
26717 * class.cs (TypeContainer::Emit): Emit code for indexers.
26719 * assign.cs (IAssignMethod): New interface implemented by Indexers
26720 and Properties for handling assignment.
26722 (Assign::Emit): Simplify and reuse code.
26724 * expression.cs (IndexerAccess, PropertyExpr): Implement
26725 IAssignMethod, clean up old code.
26727 2001-10-22 Ravi Pratap <ravi@ximian.com>
26729 * typemanager.cs (ImplementsInterface): New method to determine if a type
26730 implements a given interface. Provides a nice cache too.
26732 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
26735 (ConvertReferenceExplicit): Ditto.
26737 * delegate.cs (Delegate::Populate): Update to define the parameters on the
26738 various methods, with correct names etc.
26740 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
26741 Operator.UnaryNegation.
26743 * cs-parser.jay (operator_declarator): Be a little clever in the case where
26744 we have a unary plus or minus operator.
26746 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
26749 * everywhere : update accordingly.
26751 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
26754 * class.cs (Method::Define): For the case where we are implementing a method
26755 inherited from an interface, we need to set the MethodAttributes.Final flag too.
26756 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
26758 2001-10-21 Ravi Pratap <ravi@ximian.com>
26760 * interface.cs (FindMembers): Implement to work around S.R.E
26763 * typemanager.cs (IsInterfaceType): Implement.
26765 (FindMembers): Update to handle interface types too.
26767 * expression.cs (ImplicitReferenceConversion): Re-write bits which
26768 use IsAssignableFrom as that is not correct - it doesn't work.
26770 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
26771 and accordingly override EmitStatement.
26773 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
26774 using the correct logic :-)
26776 2001-10-19 Ravi Pratap <ravi@ximian.com>
26778 * ../errors/cs-11.cs : Add to demonstrate error -11
26780 2001-10-17 Miguel de Icaza <miguel@ximian.com>
26782 * assign.cs (Assign::Resolve): Resolve right hand side first, and
26783 then pass this as a hint to ResolveLValue.
26785 * expression.cs (FieldExpr): Add Location information
26787 (FieldExpr::LValueResolve): Report assignment to readonly
26790 (Expression::ExprClassFromMemberInfo): Pass location information.
26792 (Expression::ResolveLValue): Add new method that resolves an
26795 (Expression::DoResolveLValue): Default invocation calls
26798 (Indexers): New class used to keep track of indexers in a given
26801 (IStackStore): Renamed from LValue, as it did not really describe
26802 what this did. Also ResolveLValue is gone from this interface and
26803 now is part of Expression.
26805 (ElementAccess): Depending on the element access type
26807 * typemanager.cs: Add `indexer_name_type' as a Core type
26808 (System.Runtime.CompilerServices.IndexerNameAttribute)
26810 * statement.cs (Goto): Take a location.
26812 2001-10-18 Ravi Pratap <ravi@ximian.com>
26814 * delegate.cs (Delegate::VerifyDelegate): New method to verify
26815 if two delegates are compatible.
26817 (NewDelegate::DoResolve): Update to take care of the case when
26818 we instantiate a delegate from another delegate.
26820 * typemanager.cs (FindMembers): Don't even try to look up members
26821 of Delegate types for now.
26823 2001-10-18 Ravi Pratap <ravi@ximian.com>
26825 * delegate.cs (NewDelegate): New class to take care of delegate
26828 * expression.cs (New): Split the delegate related code out into
26829 the NewDelegate class.
26831 * delegate.cs (DelegateInvocation): New class to handle delegate
26834 * expression.cs (Invocation): Split out delegate related code into
26835 the DelegateInvocation class.
26837 2001-10-17 Ravi Pratap <ravi@ximian.com>
26839 * expression.cs (New::DoResolve): Implement delegate creation fully
26840 and according to the spec.
26842 (New::DoEmit): Update to handle delegates differently.
26844 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
26845 because of which we were printing out arguments in reverse order !
26847 * delegate.cs (VerifyMethod): Implement to check if the given method
26848 matches the delegate.
26850 (FullDelegateDesc): Implement.
26852 (VerifyApplicability): Implement.
26854 * expression.cs (Invocation::DoResolve): Update to accordingly handle
26855 delegate invocations too.
26857 (Invocation::Emit): Ditto.
26859 * ../errors/cs1593.cs : Added.
26861 * ../errors/cs1594.cs : Added.
26863 * delegate.cs (InstanceExpression, TargetMethod): New properties.
26865 2001-10-16 Ravi Pratap <ravi@ximian.com>
26867 * typemanager.cs (intptr_type): Core type for System.IntPtr
26869 (InitCoreTypes): Update for the same.
26871 (iasyncresult_type, asynccallback_type): Ditto.
26873 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
26876 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
26879 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
26880 the builders for the 4 members of a delegate type :-)
26882 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
26885 * expression.cs (New::DoResolve): Implement guts for delegate creation.
26887 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
26889 2001-10-15 Miguel de Icaza <miguel@ximian.com>
26891 * statement.cs (Break::Emit): Implement.
26892 (Continue::Emit): Implement.
26894 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
26895 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
26896 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
26897 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
26900 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
26901 properties that track the label for the current loop (begin of the
26902 loop and end of the loop).
26904 2001-10-15 Ravi Pratap <ravi@ximian.com>
26906 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
26907 use of emitting anything at all.
26909 * class.cs, rootcontext.cs : Get rid of calls to the same.
26911 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
26913 (Populate): Define the constructor correctly and set the implementation
26916 * typemanager.cs (delegate_types): New hashtable to hold delegates that
26919 (AddDelegateType): Implement.
26921 (IsDelegateType): Implement helper method.
26923 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
26925 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
26926 and accordingly handle it.
26928 * delegate.cs (Populate): Take TypeContainer argument.
26929 Implement bits to define the Invoke method. However, I still haven't figured out
26930 how to take care of the native int bit :-(
26932 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
26933 Qualify the name of the delegate, not its return type !
26935 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
26938 (StandardConversionExists): Checking for array types turns out to be recursive.
26940 (ConvertReferenceExplicit): Implement array conversion.
26942 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
26944 2001-10-12 Ravi Pratap <ravi@ximian.com>
26946 * cs-parser.jay (delegate_declaration): Store the fully qualified
26947 name as it is a type declaration.
26949 * delegate.cs (ReturnType, Name): Rename members to these. Make them
26952 (DefineDelegate): Renamed from Define. Does the same thing essentially,
26953 as TypeContainer::DefineType.
26955 (Populate): Method in which all the definition of the various methods (Invoke)
26958 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
26961 (CloseDelegate): Finally creates the delegate.
26963 * class.cs (TypeContainer::DefineType): Update to define delegates.
26964 (Populate, Emit and CloseType): Do the same thing here too.
26966 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
26967 delegates in all these operations.
26969 2001-10-14 Miguel de Icaza <miguel@ximian.com>
26971 * expression.cs: LocalTemporary: a new expression used to
26972 reference a temporary that has been created.
26974 * assign.cs: Handle PropertyAccess back here, so that we can
26975 provide the proper semantic access to properties.
26977 * expression.cs (Expression::ConvertReferenceExplicit): Implement
26978 a few more explicit conversions.
26980 * modifiers.cs: `NEW' modifier maps to HideBySig.
26982 * expression.cs (PropertyExpr): Make this into an
26983 ExpressionStatement, and support the EmitStatement code path.
26985 Perform get/set error checking, clean up the interface.
26987 * assign.cs: recognize PropertyExprs as targets, and if so, turn
26988 them into toplevel access objects.
26990 2001-10-12 Miguel de Icaza <miguel@ximian.com>
26992 * expression.cs: PropertyExpr::PropertyExpr: use work around the
26995 * typemanager.cs: Keep track here of our PropertyBuilders again to
26996 work around lameness in SRE.
26998 2001-10-11 Miguel de Icaza <miguel@ximian.com>
27000 * expression.cs (LValue::LValueResolve): New method in the
27001 interface, used to perform a second resolution pass for LValues.
27003 (This::DoResolve): Catch the use of this in static methods.
27005 (This::LValueResolve): Implement.
27007 (This::Store): Remove warning, assigning to `this' in structures
27010 (Invocation::Emit): Deal with invocation of
27011 methods on value types. We need to pass the address to structure
27012 methods rather than the object itself. (The equivalent code to
27013 emit "this" for structures leaves the entire structure on the
27014 stack instead of a pointer to it).
27016 (ParameterReference::DoResolve): Compute the real index for the
27017 argument based on whether the method takes or not a `this' pointer
27018 (ie, the method is static).
27020 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
27021 value types returned from functions when we need to invoke a
27022 method on the sturcture.
27025 2001-10-11 Ravi Pratap <ravi@ximian.com>
27027 * class.cs (TypeContainer::DefineType): Method to actually do the business of
27028 defining the type in the Modulebuilder or Typebuilder. This is to take
27029 care of nested types which need to be defined on the TypeBuilder using
27030 DefineNestedMethod.
27032 (TypeContainer::GetClassBases): Implement. Essentially the code from the
27033 methods in RootContext, only ported to be part of TypeContainer.
27035 (TypeContainer::GetInterfaceOrClass): Ditto.
27037 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
27039 * interface.cs (Interface::DefineInterface): New method. Does exactly
27040 what RootContext.CreateInterface did earlier, only it takes care of nested types
27043 (Interface::GetInterfaces): Move from RootContext here and port.
27045 (Interface::GetInterfaceByName): Same here.
27047 * rootcontext.cs (ResolveTree): Re-write.
27049 (PopulateTypes): Re-write.
27051 * class.cs (TypeContainer::Populate): Populate nested types too.
27052 (TypeContainer::Emit): Emit nested members too.
27054 * typemanager.cs (AddUserType): Do not make use of the FullName property,
27055 instead just use the name argument passed in as it is already fully
27058 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
27059 to TypeContainer mapping to see if a type is user-defined.
27061 * class.cs (TypeContainer::CloseType): Implement.
27063 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
27064 the default constructor.
27066 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
27069 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
27071 * interface.cs (CloseType): Create the type here.
27073 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
27076 Remove all the methods which are now in TypeContainer.
27078 2001-10-10 Ravi Pratap <ravi@ximian.com>
27080 * delegate.cs (Define): Re-write bits to define the delegate
27083 2001-10-10 Miguel de Icaza <miguel@ximian.com>
27085 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
27087 * expression.cs (ImplicitReferenceConversion): handle null as well
27088 as a source to convert to any reference type.
27090 * statement.cs (Return): Perform any implicit conversions to
27091 expected return type.
27093 Validate use of return statement.
27095 * codegen.cs (EmitContext): Pass the expected return type here.
27097 * class.cs (Method, Constructor, Property): Pass expected return
27098 type to EmitContext.
27100 2001-10-09 Miguel de Icaza <miguel@ximian.com>
27102 * expression.cs: Make DoResolve take an EmitContext instead of a
27105 Replaced `l' and `location' for `loc', for consistency.
27107 (Error, Warning): Remove unneeded Tc argument.
27109 * assign.cs, literal.cs, constant.cs: Update to new calling
27112 * codegen.cs: EmitContext now contains a flag indicating whether
27113 code is being generated in a static method or not.
27115 * cs-parser.jay: DecomposeQI, new function that replaces the old
27116 QualifiedIdentifier. Now we always decompose the assembled
27117 strings from qualified_identifier productions into a group of
27120 2001-10-08 Miguel de Icaza <miguel@ximian.com>
27122 * rootcontext.cs: Deal with field-less struct types correctly now
27123 by passing the size option to Define Type.
27125 * class.cs: Removed hack that created one static field.
27127 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27129 * statement.cs: Moved most of the code generation here.
27131 2001-10-09 Ravi Pratap <ravi@ximian.com>
27133 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
27136 (ElementAccess): Remove useless bits for now - keep checks as the spec
27139 2001-10-08 Ravi Pratap <ravi@ximian.com>
27141 * expression.cs (ElementAccess::DoResolve): Remove my crap code
27142 and start performing checks according to the spec.
27144 2001-10-07 Ravi Pratap <ravi@ximian.com>
27146 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
27147 rank_specifiers instead.
27149 (rank_specifiers): Change the order in which the rank specifiers are stored
27151 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
27153 * expression.cs (ElementAccess): Implement the LValue interface too.
27155 2001-10-06 Ravi Pratap <ravi@ximian.com>
27157 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
27158 except that user defined conversions are not included.
27160 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
27161 perform the conversion of the return type, if necessary.
27163 (New::DoResolve): Check whether we are creating an array or an object
27164 and accordingly do the needful.
27166 (New::Emit): Same here.
27168 (New::DoResolve): Implement guts of array creation.
27170 (New::FormLookupType): Helper function.
27172 2001-10-07 Miguel de Icaza <miguel@ximian.com>
27174 * codegen.cs: Removed most of the code generation here, and move the
27175 corresponding code generation bits to the statement classes.
27177 Added support for try/catch/finalize and throw.
27179 * cs-parser.jay: Added support for try/catch/finalize.
27181 * class.cs: Catch static methods having the flags override,
27182 virtual or abstract.
27184 * expression.cs (UserCast): This user cast was not really doing
27185 what it was supposed to do. Which is to be born in fully resolved
27186 state. Parts of the resolution were being performed at Emit time!
27190 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27192 * expression.cs: Implicity convert the result from UserCast.
27194 2001-10-05 Ravi Pratap <ravi@ximian.com>
27196 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
27197 prevented it from working correctly.
27199 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
27200 merely ConvertImplicit.
27202 2001-10-05 Miguel de Icaza <miguel@ximian.com>
27204 * typemanager.cs: Make the LookupTypeContainer function static,
27205 and not per-instance.
27207 * class.cs: Make static FindMembers (the one that takes a Type
27210 * codegen.cs: Add EmitForeach here.
27212 * cs-parser.jay: Make foreach a toplevel object instead of the
27213 inline expansion, as we need to perform semantic analysis on it.
27215 2001-10-05 Ravi Pratap <ravi@ximian.com>
27217 * expression.cs (Expression::ImplicitUserConversion): Rename to
27218 UserDefinedConversion.
27220 (Expression::UserDefinedConversion): Take an extra argument specifying
27221 whether we look for explicit user conversions too.
27223 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
27225 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
27227 (ExplicitUserConversion): Make it a call to UserDefinedConversion
27228 with the appropriate arguments.
27230 * cs-parser.jay (cast_expression): Record location too.
27232 * expression.cs (Cast): Record location info.
27234 (Expression::ConvertExplicit): Take location argument.
27236 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
27237 to determine if we are doing explicit conversions.
27239 (UserCast::Emit): Update accordingly.
27241 (Expression::ConvertExplicit): Report an error if everything fails.
27243 * ../errors/cs0030.cs : Add.
27245 2001-10-04 Miguel de Icaza <miguel@ximian.com>
27247 * modifiers.cs: If the ABSTRACT keyword is present, also set the
27248 virtual and newslot bits.
27250 * class.cs (TypeContainer::RegisterRequiredImplementations):
27251 Record methods we need.
27253 (TypeContainer::MakeKey): Helper function to make keys for
27254 MethodBases, since the Methodbase key is useless.
27256 (TypeContainer::Populate): Call RegisterRequiredImplementations
27257 before defining the methods.
27259 Create a mapping for method_builders_to_methods ahead of time
27260 instead of inside a tight loop.
27262 (::RequireMethods): Accept an object as the data to set into the
27263 hashtable so we can report interface vs abstract method mismatch.
27265 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27267 * report.cs: Make all of it static.
27269 * rootcontext.cs: Drop object_type and value_type computations, as
27270 we have those in the TypeManager anyways.
27272 Drop report instance variable too, now it is a global.
27274 * driver.cs: Use try/catch on command line handling.
27276 Add --probe option to debug the error reporting system with a test
27279 * report.cs: Add support for exiting program when a probe
27280 condition is reached.
27282 2001-10-03 Ravi Pratap <ravi@ximian.com>
27284 * expression.cs (Binary::DoNumericPromotions): Fix the case when
27285 we do a forcible conversion regardless of type, to check if
27286 ForceConversion returns a null.
27288 (Binary::error19): Use location to report error.
27290 (Unary::error23): Use location here too.
27292 * ../errors/cs0019.cs : Check in.
27294 * ../errors/cs0023.cs : Check in.
27296 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
27297 case of a non-null MethodInfo object with a length of 0 !
27299 (Binary::ResolveOperator): Flag error if overload resolution fails to find
27300 an applicable member - according to the spec :-)
27301 Also fix logic to find members in base types.
27303 (Unary::ResolveOperator): Same here.
27305 (Unary::report23): Change name to error23 and make first argument a TypeContainer
27306 as I was getting thoroughly confused between this and error19 :-)
27308 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
27309 (::FindMostEncompassedType): Implement.
27310 (::FindMostEncompassingType): Implement.
27311 (::StandardConversionExists): Implement.
27313 (UserImplicitCast): Re-vamp. We now need info about most specific
27314 source and target types so that we can do the necessary conversions.
27316 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
27317 mathematical union with no duplicates.
27319 2001-10-03 Miguel de Icaza <miguel@ximian.com>
27321 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
27322 in order from base classes to child classes, so that we can in
27323 child classes look up in our parent for method names and
27324 attributes (required for handling abstract, virtual, new, override
27325 constructs: we need to instrospect our base class, and if we dont
27326 populate the classes in order, the introspection might be
27327 incorrect. For example, a method could query its parent before
27328 the parent has any methods and would determine that the parent has
27329 no abstract methods (while it could have had them)).
27331 (RootContext::CreateType): Record the order in which we define the
27334 2001-10-02 Miguel de Icaza <miguel@ximian.com>
27336 * class.cs (TypeContainer::Populate): Also method definitions can
27337 fail now, keep track of this.
27339 (TypeContainer::FindMembers): Implement support for
27340 DeclaredOnly/noDeclaredOnly flag.
27342 (Constructor::Emit) Return the ConstructorBuilder.
27344 (Method::Emit) Return the MethodBuilder.
27345 Check for abstract or virtual methods to be public.
27347 * rootcontext.cs (RootContext::CreateType): Register all the
27348 abstract methods required for the class to be complete and the
27349 interface methods that must be implemented.
27351 * cs-parser.jay: Report error 501 (method requires body if it is
27352 not marked abstract or extern).
27354 * expression.cs (TypeOf::Emit): Implement.
27356 * typemanager.cs: runtime_handle_type, new global type.
27358 * class.cs (Property::Emit): Generate code for properties.
27360 2001-10-02 Ravi Pratap <ravi@ximian.com>
27362 * expression.cs (Unary::ResolveOperator): Find operators on base type
27363 too - we now conform exactly to the spec.
27365 (Binary::ResolveOperator): Same here.
27367 * class.cs (Operator::Define): Fix minor quirk in the tests.
27369 * ../errors/cs0215.cs : Added.
27371 * ../errors/cs0556.cs : Added.
27373 * ../errors/cs0555.cs : Added.
27375 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27377 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
27378 single integer which is really efficient
27380 2001-10-01 Ravi Pratap <ravi@ximian.com>
27382 * expression.cs (Expression::ImplicitUserConversion): Use location
27383 even in the case when we are examining True operators.
27385 * class.cs (Operator::Define): Perform extensive checks to conform
27386 with the rules for operator overloading in the spec.
27388 * expression.cs (Expression::ImplicitReferenceConversion): Implement
27389 some of the other conversions mentioned in the spec.
27391 * typemanager.cs (array_type): New static member for the System.Array built-in
27394 (cloneable_interface): For System.ICloneable interface.
27396 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
27397 we start resolving the tree and populating types.
27399 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
27401 2001-10-01 Miguel de Icaza <miguel@ximian.com>
27403 * expression.cs (Expression::ExprClassFromMemberInfo,
27404 Expression::Literalize): Create literal expressions from
27405 FieldInfos which are literals.
27407 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
27408 type casts, because they were wrong. The test suite in tests
27411 (ImplicitNumericConversion): ushort to ulong requires a widening
27414 Int32 constant to long requires widening cast as well.
27416 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
27417 for integers because the type on the stack is not i4.
27419 2001-09-30 Miguel de Icaza <miguel@ximian.com>
27421 * expression.cs (report118): require location argument.
27423 * parameter.cs: Do not dereference potential null value.
27425 * class.cs: Catch methods that lack the `new' keyword when
27426 overriding a name. Report warnings when `new' is used without
27427 anything being there to override.
27429 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
27431 * class.cs: Only add constructor to hashtable if it is non-null
27432 (as now constructors can fail on define).
27434 (TypeManager, Class, Struct): Take location arguments.
27436 Catch field instance initialization in structs as errors.
27438 accepting_filter: a new filter for FindMembers that is static so
27439 that we dont create an instance per invocation.
27441 (Constructor::Define): Catch errors where a struct constructor is
27444 * cs-parser.jay: Pass location information for various new
27447 * delegate.cs (Delegate): take a location argument.
27449 * driver.cs: Do not call EmitCode if there were problesm in the
27450 Definition of the types, as many Builders wont be there.
27452 * decl.cs (Decl::Decl): Require a location argument.
27454 * cs-tokenizer.cs: Handle properly hex constants that can not fit
27455 into integers, and find the most appropiate integer for it.
27457 * literal.cs: Implement ULongLiteral.
27459 * rootcontext.cs: Provide better information about the location of
27460 failure when CreateType fails.
27462 2001-09-29 Miguel de Icaza <miguel@ximian.com>
27464 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
27467 * expression.cs (Binary::CheckShiftArguments): Add missing type
27469 (Binary::ResolveOperator): Add type to the logical and and logical
27470 or, Bitwise And/Or and Exclusive Or code paths, it was missing
27473 (Binary::DoNumericPromotions): In the case where either argument
27474 is ulong (and most signed types combined with ulong cause an
27475 error) perform implicit integer constant conversions as well.
27477 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27479 * expression.cs (UserImplicitCast): Method should always be
27481 (Invocation::BetterConversion): Simplified test for IntLiteral.
27483 (Expression::ImplicitNumericConversion): Split this routine out.
27484 Put the code that performs implicit constant integer conversions
27487 (Expression::Resolve): Become a wrapper around DoResolve so we can
27488 check eclass and type being set after resolve.
27490 (Invocation::Badness): Remove this dead function
27492 (Binary::ResolveOperator): Do not compute the expensive argumnets
27493 unless we have a union for it.
27495 (Probe::Emit): Is needs to do an isinst and then
27496 compare against null.
27498 (::CanConvert): Added Location argument. If the Location argument
27499 is null (Location.Null), then we do not report errors. This is
27500 used by the `probe' mechanism of the Explicit conversion. We do
27501 not want to generate an error for something that the user
27502 explicitly requested to be casted. But the pipeline for an
27503 explicit cast first tests for potential implicit casts.
27505 So for now, if the Location is null, it means `Probe only' to
27506 avoid adding another argument. Might have to revise this
27509 (ClassCast): New class used to type cast objects into arbitrary
27510 classes (used in Explicit Reference Conversions).
27512 Implement `as' as well.
27514 Reverted all the patches from Ravi below: they were broken:
27516 * The use of `level' as a mechanism to stop recursive
27517 invocations is wrong. That was there just to catch the
27518 bug with a strack trace but not as a way of addressing
27521 To fix the problem we have to *understand* what is going
27522 on and the interactions and come up with a plan, not
27523 just get things going.
27525 * The use of the type conversion cache that I proposed
27526 last night had an open topic: How does this work across
27527 protection domains. A user defined conversion might not
27528 be public in the location where we are applying the
27529 conversion, a different conversion might be selected
27530 (ie, private A->B (better) but public B->A (worse),
27531 inside A, A->B applies, but outside it, B->A will
27534 * On top of that (ie, even if the above is solved),
27535 conversions in a cache need to be abstract. Ie, `To
27536 convert from an Int to a Short use an OpcodeCast', not
27537 `To convert from an Int to a Short use the OpcodeCast on
27538 the variable 5' (which is what this patch was doing).
27540 2001-09-28 Ravi Pratap <ravi@ximian.com>
27542 * expression.cs (Invocation::ConversionExists): Re-write to use
27543 the conversion cache
27545 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
27546 cache all conversions done, not just user-defined ones.
27548 (Invocation::BetterConversion): The real culprit. Use ConversionExists
27549 to determine if a conversion exists instead of acutually trying to
27550 perform the conversion. It's faster too.
27552 (Expression::ConvertExplicit): Modify to use ConversionExists to check
27553 and only then attempt the implicit conversion.
27555 2001-09-28 Ravi Pratap <ravi@ximian.com>
27557 * expression.cs (ConvertImplicit): Use a cache for conversions
27558 already found. Check level of recursion and bail out if necessary.
27560 2001-09-28 Miguel de Icaza <miguel@ximian.com>
27562 * typemanager.cs (string_concat_string_string, string_concat_object_object):
27563 Export standard methods that we expect for string operations.
27565 * statement.cs (Block::UsageWarning): Track usage of variables and
27566 report the errors for not used variables.
27568 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
27571 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27573 * codegen.cs: remove unnneded code
27575 * expression.cs: Removed BuiltinTypeAccess class
27577 Fix the order in which implicit conversions are
27580 The previous fixed dropped support for boxed conversions (adding a
27581 test to the test suite now)
27583 (UserImplicitCast::CanConvert): Remove test for source being null,
27584 that code is broken. We should not feed a null to begin with, if
27585 we do, then we should track the bug where the problem originates
27586 and not try to cover it up here.
27588 Return a resolved expression of type UserImplicitCast on success
27589 rather than true/false. Ravi: this is what I was talking about,
27590 the pattern is to use a static method as a "constructor" for
27593 Also, do not create arguments until the very last minute,
27594 otherwise we always create the arguments even for lookups that
27595 will never be performed.
27597 (UserImplicitCast::Resolve): Eliminate, objects of type
27598 UserImplicitCast are born in a fully resolved state.
27600 * typemanager.cs (InitCoreTypes): Init also value_type
27601 (System.ValueType).
27603 * expression.cs (Cast::Resolve): First resolve the child expression.
27605 (LValue): Add new method AddressOf to be used by
27608 Change the argument of Store to take an EmitContext instead of an
27609 ILGenerator, because things like FieldExpr need to be able to call
27610 their children expression to generate the instance code.
27612 (Expression::Error, Expression::Warning): Sugar functions for
27615 (Expression::MemberLookup): Accept a TypeContainer instead of a
27616 Report as the first argument.
27618 (Expression::ResolvePrimary): Killed. I still want to improve
27619 this as currently the code is just not right.
27621 (Expression::ResolveMemberAccess): Simplify, but it is still
27624 (Unary::Resolve): Catch errors in AddressOf operators.
27626 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
27627 index to a byte for the short-version, or the compiler will choose
27628 the wrong Emit call, which generates the wrong data.
27630 (ParameterReference::Emit, ::Store): same.
27632 (FieldExpr::AddressOf): Implement.
27634 * typemanager.cs: TypeManager: made public variable instead of
27637 * driver.cs: document --fatal.
27639 * report.cs (ErrorMessage, WarningMessage): new names for the old
27640 Error and Warning classes.
27642 * cs-parser.jay (member_access): Turn built-in access to types
27643 into a normal simplename
27645 2001-09-27 Ravi Pratap <ravi@ximian.com>
27647 * expression.cs (Invocation::BetterConversion): Fix to cope
27648 with q being null, since this was introducing a bug.
27650 * expression.cs (ConvertImplicit): Do built-in conversions first.
27652 2001-09-27 Ravi Pratap <ravi@ximian.com>
27654 * expression.cs (UserImplicitCast::Resolve): Fix bug.
27656 2001-09-27 Ravi Pratap <ravi@ximian.com>
27658 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
27659 I had introduced long ago (what's new ?).
27661 * expression.cs (UserImplicitCast::CanConvert): Static method to do
27662 the work of all the checking.
27663 (ConvertImplicit): Call CanConvert and only then create object if necessary.
27664 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
27666 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
27667 that is the right way.
27669 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
27670 overloading resolution. Use everywhere instead of cutting and pasting code.
27672 (Binary::ResolveOperator): Use MakeUnionSet.
27674 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
27675 we have to convert to bool types. Not complete yet.
27677 2001-09-27 Miguel de Icaza <miguel@ximian.com>
27679 * typemanager.cs (TypeManager::CSharpName): support ushort.
27681 * expression.cs (Expression::TryImplicitIntConversion): Attempts
27682 to provide an expression that performsn an implicit constant int
27683 conversion (section 6.1.6).
27684 (Expression::ConvertImplicitRequired): Reworked to include
27685 implicit constant expression conversions.
27687 (Expression::ConvertNumericExplicit): Finished.
27689 (Invocation::Emit): If InstanceExpression is null, then it means
27690 that we perform a call on this.
27692 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27694 * expression.cs (Unary::Emit): Remove some dead code.
27695 (Probe): Implement Resolve and Emit for `is'.
27696 (Expression::ConvertImplicitRequired): Attempt to do constant
27697 expression conversions here. Maybe should be moved to
27698 ConvertImplicit, but I am not sure.
27699 (Expression::ImplicitLongConstantConversionPossible,
27700 Expression::ImplicitIntConstantConversionPossible): New functions
27701 that tell whether is it possible to apply an implicit constant
27702 expression conversion.
27704 (ConvertNumericExplicit): Started work on explicit numeric
27707 * cs-parser.jay: Update operator constants.
27709 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
27710 (Parameters::GetSignature): Hook up VerifyArgs here.
27711 (Parameters::VerifyArgs): Verifies that no two arguments have the
27714 * class.cs (Operator): Update the operator names to reflect the
27715 ones that the spec expects (as we are just stringizing the
27718 * expression.cs (Unary::ResolveOperator): Fix bug: Use
27719 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
27720 previous usage did only work for our methods.
27721 (Expression::ConvertImplicit): Handle decimal implicit numeric
27722 conversions as well.
27723 (Expression::InternalTypeConstructor): Used to invoke constructors
27724 on internal types for default promotions.
27726 (Unary::Emit): Implement special handling for the pre/post
27727 increment/decrement for overloaded operators, as they need to have
27728 the same semantics as the other operators.
27730 (Binary::ResolveOperator): ditto.
27731 (Invocation::ConversionExists): ditto.
27732 (UserImplicitCast::Resolve): ditto.
27734 2001-09-26 Ravi Pratap <ravi@ximian.com>
27736 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
27737 operator, return after emitting body. Regression tests pass again !
27739 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
27740 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
27741 (Invocation::OverloadResolve): Ditto.
27742 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
27744 * everywhere : update calls to the above methods accordingly.
27746 2001-09-26 Miguel de Icaza <miguel@ximian.com>
27748 * assign.cs (Assign): Make it inherit from ExpressionStatement.
27750 * expression.cs (ExpressionStatement): New base class used for
27751 expressions that can appear in statements, so that we can provide
27752 an alternate path to generate expression that do not leave a value
27755 (Expression::Emit, and all the derivatives): We no longer return
27756 whether a value is left on the stack or not. Every expression
27757 after being emitted leaves a single value on the stack.
27759 * codegen.cs (EmitContext::EmitStatementExpression): Use the
27760 facilties of ExpressionStatement if possible.
27762 * cs-parser.jay: Update statement_expression.
27764 2001-09-25 Miguel de Icaza <miguel@ximian.com>
27766 * driver.cs: Change the wording of message
27768 2001-09-25 Ravi Pratap <ravi@ximian.com>
27770 * expression.cs (Binary::ResolveOperator): Had forgottten to set
27771 the type of the expression to the return type of the method if
27772 we have an overloaded operator match ! The regression tests pass again !
27773 (Unary::ResolveOperator): Ditto.
27775 * expression.cs (Invocation::ConversionExists): Correct the member lookup
27776 to find "op_Implicit", not "implicit" ;-)
27777 (UserImplicitCast): New class to take care of user-defined implicit conversions.
27778 (ConvertImplicit, ForceConversion): Take TypeContainer argument
27780 * everywhere : Correct calls to the above accordingly.
27782 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
27783 (ConvertImplicit): Do user-defined conversion if it exists.
27785 2001-09-24 Miguel de Icaza <miguel@ximian.com>
27787 * assign.cs: track location.
27788 (Resolve): Use implicit conversions on assignment.
27790 * literal.cs: Oops. Not good, Emit of short access values should
27791 pass (Bytes) or the wrong argument will be selected.
27793 * expression.cs (Unary::Emit): Emit code for -expr.
27795 (Unary::ResolveOperator): Handle `Substract' for non-constants
27796 (substract from zero from the non-constants).
27797 Deal with Doubles as well.
27799 (Expression::ConvertImplicitRequired): New routine that reports an
27800 error if no implicit conversion exists.
27802 (Invocation::OverloadResolve): Store the converted implicit
27803 expressions if we make them
27805 2001-09-24 Ravi Pratap <ravi@ximian.com>
27807 * class.cs (ConstructorInitializer): Take a Location argument.
27808 (ConstructorBaseInitializer): Same here.
27809 (ConstructorThisInitializer): Same here.
27811 * cs-parser.jay : Update all calls accordingly.
27813 * expression.cs (Unary, Binary, New): Take location argument.
27814 Update accordingly everywhere.
27816 * cs-parser.jay : Update all calls to the above to take a location
27819 * class.cs : Ditto.
27821 2001-09-24 Ravi Pratap <ravi@ximian.com>
27823 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
27824 (Invocation::BetterConversion): Same here
27825 (Invocation::ConversionExists): Ditto.
27827 (Invocation::ConversionExists): Implement.
27829 2001-09-22 Ravi Pratap <ravi@ximian.com>
27831 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
27832 Also take an additional TypeContainer argument.
27834 * All over : Pass in TypeContainer as argument to OverloadResolve.
27836 * typemanager.cs (CSharpName): Update to check for the string type and return
27839 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
27842 2001-09-21 Ravi Pratap <ravi@ximian.com>
27844 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
27845 (Invocation::BetterFunction): Implement.
27846 (Invocation::BetterConversion): Implement.
27847 (Invocation::ConversionExists): Skeleton, no implementation yet.
27849 Okay, things work fine !
27851 2001-09-21 Miguel de Icaza <miguel@ximian.com>
27853 * typemanager.cs: declare and load enum_type, delegate_type and
27856 * expression.cs (Expression::Emit): Now emit returns a value that
27857 tells whether a value is left on the stack or not. This strategy
27858 might be reveted tomorrow with a mechanism that would address
27859 multiple assignments.
27860 (Expression::report118): Utility routine to report mismatches on
27863 (Unary::Report23): Report impossible type/operator combination
27866 (Unary::IsIncrementableNumber): Whether the type can be
27867 incremented or decremented with add.
27868 (Unary::ResolveOperator): Also allow enumerations to be bitwise
27870 (Unary::ResolveOperator): Implement ++, !, ~,
27872 (Invocation::Emit): Deal with new Emit convetion.
27874 * All Expression derivatives: Updated their Emit method to return
27875 whether they leave values on the stack or not.
27877 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
27878 stack for expressions that are statements.
27880 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27882 * expression.cs (LValue): New interface. Must be implemented by
27884 (LocalVariableReference, ParameterReference, FieldExpr): Implement
27887 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
27888 interface for generating code, simplifies the code.
27890 2001-09-20 Ravi Pratap <ravi@ximian.com>
27892 * expression.cs (everywhere): Comment out return statements in ::Resolve
27893 methods to avoid the warnings.
27895 2001-09-20 Miguel de Icaza <miguel@ximian.com>
27897 * driver.cs (parse): Report error 2001 if we can not open the
27900 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
27903 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
27906 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
27907 otherwise nested blocks end up with the same index.
27909 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
27911 * expression.cs: Instead of having FIXMEs in the Resolve
27912 functions, throw exceptions so it is obvious that we are facing a
27915 * cs-parser.jay (invocation_expression): Pass Location information.
27917 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
27918 Use a basename for those routines because .NET does not like paths
27921 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
27924 2001-09-19 Miguel de Icaza <miguel@ximian.com>
27926 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
27927 are loading the correct data types (throws an exception if not).
27928 (TypeManager::InitCoreTypes): Use CoreLookupType
27930 * expression.cs (Unary::ResolveOperator): return the child
27931 expression for expressions which are just +expr.
27932 (Unary::ResolveOperator): Return negative literals for -LITERAL
27933 expressions (otherwise they are Unary {Literal}).
27934 (Invocation::Badness): Take into account `Implicit constant
27935 expression conversions'.
27937 * literal.cs (LongLiteral): Implement long literal class.
27938 (IntLiteral): export the `Value' of the intliteral.
27940 2001-09-19 Ravi Pratap <ravi@ximian.com>
27942 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
27944 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
27945 instead of 'Operator'
27947 * expression.cs (Binary::ResolveOperator): Update accordingly.
27948 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
27951 * cs-parser.jay (unary_expression): Update to use the new names.
27953 * gen-treedump.cs (GetUnary): Same here.
27955 * expression.cs (Unary::Resolve): Implement.
27956 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
27957 operators are found instead of making noise ;-)
27958 (Unary::ResolveOperator): New method to do precisely the same thing which
27959 Binary::ResolveOperator does for Binary expressions.
27960 (Unary.method, .Arguments): Add.
27961 (Unary::OperName): Implement.
27962 (Unary::ForceConversion): Copy and Paste !
27964 * class.cs (Operator::Define): Fix a small bug for the case when we have
27967 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
27968 for the inbuilt operators. Only overloading works for now ;-)
27970 2001-09-18 Miguel de Icaza <miguel@ximian.com>
27972 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
27973 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
27975 * expression.cs (This::Emit): Implement.
27976 (This::Resolve): Implement.
27977 (TypeOf:Resolve): Implement.
27978 (Expression::ResolveSimpleName): Add an implicit this to instance
27980 (MemberAccess::Resolve): Deal with Parameters and Fields.
27981 Bind instance variable to Field expressions.
27982 (FieldExpr::Instance): New field used to track the expression that
27983 represents the object instance.
27984 (FieldExpr::Resolve): Track potential errors from MemberLookup not
27986 (FieldExpr::Emit): Implement.
27988 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
27989 the last instruction contains a return opcode to avoid generating
27990 the last `ret' instruction (this generates correct code, and it is
27991 nice to pass the peverify output).
27993 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
27994 initializer for static and instance variables.
27995 (Constructor::Emit): Allow initializer to be null in the case of
27996 static constructors. Only emit initializer for instance
27999 (TypeContainer::FindMembers): Return a null array if there are no
28002 Also fix the code for the MemberTypes.Method branch, as it was not
28003 scanning that for operators (or tried to access null variables before).
28005 * assign.cs (Assign::Emit): Handle instance and static fields.
28009 * driver.cs: Stop compilation if there are parse errors.
28011 * cs-parser.jay (constructor_declaration): Provide default base
28012 initializer for non-static constructors.
28013 (constructor_declarator): Do not provide a default base
28014 initializers if none was specified.
28015 Catch the fact that constructors should not have parameters.
28017 * class.cs: Do not emit parent class initializers for static
28018 constructors, that should be flagged as an error.
28020 2001-09-18 Ravi Pratap <ravi@ximian.com>
28022 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
28023 Move back code into TypeContainer::Populate.
28025 2001-09-18 Ravi Pratap <ravi@ximian.com>
28027 * class.cs (TypeContainer::AddConstructor): Fix the check to
28028 compare against Name, not Basename.
28029 (Operator::OpType): Change Plus and Minus to Add and Subtract.
28031 * cs-parser.jay : Update accordingly.
28033 * class.cs (TypeContainer::FindMembers): For the case where we are searching
28034 for methods, don't forget to look into the operators too.
28035 (RegisterMethodBuilder): Helper method to take care of this for
28036 methods, constructors and operators.
28037 (Operator::Define): Completely revamp.
28038 (Operator.OperatorMethod, MethodName): New fields.
28039 (TypeContainer::Populate): Move the registering of builders into
28040 RegisterMethodBuilder.
28041 (Operator::Emit): Re-write.
28043 * expression.cs (Binary::Emit): Comment out code path to emit method
28044 invocation stuff for the case when we have a user defined operator. I am
28045 just not able to get it right !
28047 2001-09-17 Miguel de Icaza <miguel@ximian.com>
28049 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
28052 (Expression::MemberLookup): Provide a version that allows to
28053 specify the MemberTypes and BindingFlags.
28055 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
28056 so it was not fetching variable information from outer blocks.
28058 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
28059 Beforefieldinit as it was buggy.
28061 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
28062 that Ravi put here.
28064 * class.cs (Constructor::Emit): Only emit if block is not null.
28065 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
28066 deal with this by semantically definining it as if the user had
28069 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
28070 constructors as we now "emit" them at a higher level.
28072 (TypeContainer::DefineDefaultConstructor): Used to define the
28073 default constructors if none was provided.
28075 (ConstructorInitializer): Add methods Resolve and Emit.
28077 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
28079 2001-09-17 Ravi Pratap <ravi@ximian.com>
28081 * class.cs (TypeContainer::EmitDefaultConstructor): Register
28082 the default constructor builder with our hashtable for methodbuilders
28085 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
28086 and argument_count is 0 in which case we have a match.
28087 (Binary::ResolveOperator): More null checking and miscellaneous coding
28090 2001-09-17 Ravi Pratap <ravi@ximian.com>
28092 * rootcontext.cs (IsNameSpace): Compare against null.
28094 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
28096 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
28097 and Unary::Operator.
28099 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
28102 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
28103 we have overloaded operators.
28104 (Binary::ResolveOperator): Implement the part which does the operator overload
28107 * class.cs (Operator::Emit): Implement.
28108 (TypeContainer::Emit): Emit the operators we have too.
28110 * expression.cs (Binary::Emit): Update to emit the appropriate code for
28111 the case when we have a user-defined operator.
28113 2001-09-17 Miguel de Icaza <miguel@ximian.com>
28115 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
28117 2001-09-16 Ravi Pratap <ravi@ximian.com>
28119 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
28120 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
28121 (Constructor::Emit): Implement.
28122 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
28123 if we have no work to do.
28124 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
28127 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
28128 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
28130 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
28133 2001-09-15 Ravi Pratap <ravi@ximian.com>
28135 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
28137 (Tree::RecordNamespace): Method to do what the name says ;-)
28138 (Tree::Namespaces): Property to get at the namespaces hashtable.
28140 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
28143 * rootcontext.cs (IsNamespace): Fixed it :-)
28145 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28147 * class.cs (TypeContainer::FindMembers): Add support for
28149 (MethodCore): New class that encapsulates both the shared aspects
28150 of a Constructor and a Method.
28151 (Method, Constructor): Factored pieces into MethodCore.
28153 * driver.cs: Added --fatal which makes errors throw exceptions.
28154 Load System assembly as well as part of the standard library.
28156 * report.cs: Allow throwing exceptions on errors for debugging.
28158 * modifiers.cs: Do not use `parent', instead use the real type
28159 container to evaluate permission settings.
28161 * class.cs: Put Ravi's patch back in. He is right, and we will
28162 have to cope with the
28164 2001-09-14 Ravi Pratap <ravi@ximian.com>
28166 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
28167 FamORAssem, not FamANDAssem.
28169 2001-09-14 Miguel de Icaza <miguel@ximian.com>
28171 * driver.cs: Added --parse option that only parses its input files
28174 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
28175 incorrect. IsTopLevel is not used to tell whether an object is
28176 root_types or not (that can be achieved by testing this ==
28177 root_types). But to see if this is a top-level *class* (not
28178 necessarly our "toplevel" container).
28180 2001-09-14 Ravi Pratap <ravi@ximian.com>
28182 * enum.cs (Enum::Define): Modify to call the Lookup method on the
28183 parent instead of a direct call to GetType.
28185 2001-09-14 Ravi Pratap <ravi@ximian.com>
28187 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
28188 Modifiers.TypeAttr. This should just be a call to that method.
28190 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
28191 object so that we can determine if we are top-level or not.
28193 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
28196 * enum.cs (Enum::Define): Ditto.
28198 * modifiers.cs (FieldAttr): Re-write.
28200 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
28201 (TypeContainer::HaveStaticConstructor): New property to provide access
28202 to precisely that info.
28204 * modifiers.cs (MethodAttr): Re-write.
28205 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
28207 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
28208 of top-level types as claimed.
28210 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28212 * expression.cs (MemberLookup): Fruitless attempt to lookup
28213 constructors. Maybe I need to emit default constructors? That
28214 might be it (currently .NET emits this for me automatically).
28215 (Invocation::OverloadResolve): Cope with Arguments == null.
28216 (Invocation::EmitArguments): new function, shared by the new
28217 constructor and us.
28218 (Invocation::Emit): Handle static and instance methods. Emit
28219 proper call instruction for virtual or non-virtual invocations.
28220 (New::Emit): Implement.
28221 (New::Resolve): Implement.
28222 (MemberAccess:Resolve): Implement.
28223 (MethodGroupExpr::InstanceExpression): used conforming to the spec
28224 to track instances.
28225 (FieldExpr::Resolve): Set type.
28227 * support.cs: Handle empty arguments.
28229 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
28230 SimpleLookup): Auxiliary routines to help parse a qualifier
28233 Update qualifier_identifier rule.
28235 * codegen.cs: Removed debugging messages.
28237 * class.cs: Make this a global thing, this acts just as a "key" to
28238 objects that we might have around.
28240 (Populate): Only initialize method_builders_to_methods once.
28242 * expression.cs (PropertyExpr): Initialize type from the
28245 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
28246 Resolve pattern. Attempt to implicitly convert value to boolean.
28249 * expression.cs: Set the type for the int32/int32 argument case.
28250 (Binary::ResolveOperator): Set the return type to boolean for
28251 comparission operators
28253 * typemanager.cs: Remove debugging print code.
28255 (Invocation::Resolve): resolve type.
28257 * class.cs: Allocate a MemberInfo of the correct size, as the code
28258 elsewhere depends on the test to reflect the correct contents.
28260 (Method::) Keep track of parameters, due to System.Reflection holes
28262 (TypeContainer::Populate): Keep track of MethodBuilders to Method
28265 (TypeContainer::FindMembers): Use ArrayList and then copy an array
28266 of the exact size and return that.
28268 (Class::LookupMethodByBuilder): New function that maps
28269 MethodBuilders to its methods. Required to locate the information
28270 on methods because System.Reflection bit us again.
28272 * support.cs: New file, contains an interface ParameterData and
28273 two implementations: ReflectionParameters and InternalParameters
28274 used to access Parameter information. We will need to grow this
28277 * expression.cs (Invocation::GetParameterData): implement a cache
28278 and a wrapper around the ParameterData creation for methods.
28279 (Invocation::OverloadResolve): Use new code.
28281 2001-09-13 Ravi Pratap <ravi@ximian.com>
28283 * class.cs (TypeContainer::EmitField): Remove and move into
28284 (Field::Define): here and modify accordingly.
28285 (Field.FieldBuilder): New member.
28286 (TypeContainer::Populate): Update accordingly.
28287 (TypeContainer::FindMembers): Implement.
28289 2001-09-13 Miguel de Icaza <miguel@ximian.com>
28291 * statement.cs: (VariableInfo::VariableType): New field to be
28292 initialized with the full type once it is resolved.
28294 2001-09-12 Miguel de Icaza <miguel@ximian.com>
28296 * parameter.cs (GetParameterInfo): Use a type cache to compute
28297 things only once, and to reuse this information
28299 * expression.cs (LocalVariableReference::Emit): Implement.
28300 (OpcodeCast::Emit): fix.
28302 (ParameterReference::Resolve): Implement.
28303 (ParameterReference::Emit): Implement.
28305 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
28306 that are expressions need to stay as Expressions.
28308 * typemanager.cs (CSharpName): Returns the C# name of a type if
28311 * expression.cs (Expression::ConvertImplicit): New function that
28312 implements implicit type conversions.
28314 (Expression::ImplicitReferenceConversion): Implements implicit
28315 reference conversions.
28317 (EmptyCast): New type for transparent casts.
28319 (OpcodeCast): New type for casts of types that are performed with
28320 a sequence of bytecodes.
28322 (BoxedCast): New type used for casting value types into reference
28323 types. Emits a box opcode.
28325 (Binary::DoNumericPromotions): Implements numeric promotions of
28326 and computation of the Binary::Type.
28328 (Binary::EmitBranchable): Optimization.
28330 (Binary::Emit): Implement code emission for expressions.
28332 * typemanager.cs (TypeManager): Added two new core types: sbyte
28335 2001-09-12 Ravi Pratap <ravi@ximian.com>
28337 * class.cs (TypeContainer::FindMembers): Method which does exactly
28338 what Type.FindMembers does, only we don't have to use reflection. No
28339 implementation yet.
28341 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
28342 typecontainer objects as we need to get at them.
28343 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
28345 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
28346 typecontainer object.
28348 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
28349 of just a Report object.
28351 2001-09-11 Ravi Pratap <ravi@ximian.com>
28353 * class.cs (Event::Define): Go back to using the prefixes "add_" and
28355 (TypeContainer::Populate): Now define the delegates of the type too.
28356 (TypeContainer.Delegates): Property to access the list of delegates defined
28359 * delegates.cs (Delegate::Define): Implement partially.
28361 * modifiers.cs (TypeAttr): Handle more flags.
28363 2001-09-11 Ravi Pratap <ravi@ximian.com>
28365 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
28367 (Operator::Define): Re-write logic to get types by using the LookupType method
28368 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
28369 (Indexer::Define): Ditto.
28370 (Event::Define): Ditto.
28371 (Property::Define): Ditto.
28373 2001-09-10 Ravi Pratap <ravi@ximian.com>
28375 * class.cs (TypeContainer::Populate): Now define operators too.
28376 (TypeContainer.Operators): New property to access the list of operators
28378 (Operator.OperatorMethodBuilder): New member to hold the method builder
28379 for the operator we are defining.
28380 (Operator::Define): Implement.
28382 2001-09-10 Ravi Pratap <ravi@ximian.com>
28384 * class.cs (Event::Define): Make the prefixes of the accessor methods
28385 addOn_ and removeOn_
28387 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
28388 of the location being passed in too. Ideally, this should go later since all
28389 error reporting should be done through the Report object.
28391 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
28392 (Populate): Iterate thru the indexers we have and define them too.
28393 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
28394 for the get and set accessors.
28395 (Indexer::Define): Implement.
28397 2001-09-09 Miguel de Icaza <miguel@ximian.com>
28399 * expression.cs (Binary::Resolve): Beginning of it. I scratched
28400 my previous implementation, did not work.
28402 * typemanager.cs: Add a couple of missing types (the longs).
28404 * literal.cs: Use TypeManager.bool_type instead of getting it.
28406 * expression.cs (EventExpr): New kind of expressions.
28407 (Expressio::ExprClassFromMemberInfo): finish
28409 2001-09-08 Miguel de Icaza <miguel@ximian.com>
28411 * assign.cs: Emit stores to static fields differently.
28413 2001-09-08 Ravi Pratap <ravi@ximian.com>
28415 * Merge in changes and adjust code to tackle conflicts. Backed out my
28416 code in Assign::Resolve ;-)
28418 2001-09-08 Ravi Pratap <ravi@ximian.com>
28420 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
28421 instead Report.Error and also pass in the location.
28422 (CSharpParser::Lexer): New readonly property to return the reference
28423 to the Tokenizer object.
28424 (declare_local_variables): Use Report.Error with location instead of plain
28428 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
28429 (Operator.CheckBinaryOperator): Ditto.
28431 * cs-parser.jay (operator_declarator): Update accordingly.
28433 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
28434 (CheckBinaryOperator): Same here.
28436 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
28437 on the name without any prefixes of namespace names etc. This is because we
28438 already might have something already fully qualified like
28439 'System.Console.WriteLine'
28441 * assign.cs (Resolve): Begin implementation. Stuck ;-)
28443 2001-09-07 Ravi Pratap <ravi@ximian.com>
28445 * cs-tokenizer.cs (location): Return a string which also contains
28448 * expression.cs (ElementAccess): New class for expressions of the
28449 type 'element access.'
28450 (BaseAccess): New class for expressions of the type 'base access.'
28451 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
28454 * cs-parser.jay (element_access): Implement action.
28455 (base_access): Implement actions.
28456 (checked_expression, unchecked_expression): Implement.
28458 * cs-parser.jay (local_variable_type): Correct and implement.
28459 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
28461 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
28463 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
28464 name and the specifiers.
28466 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
28468 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
28469 making them all public ;-)
28471 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
28474 2001-09-07 Miguel de Icaza <miguel@ximian.com>
28476 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
28478 (FieldExpr, PropertyExprs): New resolved expressions.
28479 (SimpleName::MemberStaticCheck): Perform static checks for access
28480 to non-static fields on static methods. Maybe this should be
28481 generalized for MemberAccesses.
28482 (SimpleName::ResolveSimpleName): More work on simple name
28485 * cs-parser.jay (primary_expression/qualified_identifier): track
28486 the parameter index.
28488 * codegen.cs (CodeGen::Save): Catch save exception, report error.
28489 (EmitContext::EmitBoolExpression): Chain to expression generation
28490 instead of temporary hack.
28491 (::EmitStatementExpression): Put generic expression code generation.
28493 * assign.cs (Assign::Emit): Implement variable assignments to
28494 local variables, parameters and fields.
28496 2001-09-06 Miguel de Icaza <miguel@ximian.com>
28498 * statement.cs (Block::GetVariableInfo): New method, returns the
28499 VariableInfo for a variable name in a block.
28500 (Block::GetVariableType): Implement in terms of GetVariableInfo
28502 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
28503 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
28505 2001-09-06 Ravi Pratap <ravi@ximian.com>
28507 * cs-parser.jay (operator_declaration): Continue on my quest : update
28508 to take attributes argument.
28509 (event_declaration): Ditto.
28510 (enum_declaration): Ditto.
28511 (indexer_declaration): Ditto.
28513 * class.cs (Operator::Operator): Update constructor accordingly.
28514 (Event::Event): Ditto.
28516 * delegate.cs (Delegate::Delegate): Same here.
28518 * enum.cs (Enum::Enum): Same here.
28520 2001-09-05 Ravi Pratap <ravi@ximian.com>
28522 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
28524 * ../tests/cs0658.cs : New file to demonstrate error 0658.
28526 * attribute.cs (Attributes): New class to encapsulate all attributes which were
28527 being passed around as an arraylist.
28528 (Attributes::AddAttribute): Method to add attribute sections.
28530 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
28531 (struct_declaration): Update accordingly.
28532 (constant_declaration): Update.
28533 (field_declaration): Update.
28534 (method_header): Update.
28535 (fixed_parameter): Update.
28536 (parameter_array): Ditto.
28537 (property_declaration): Ditto.
28538 (destructor_declaration): Ditto.
28540 * class.cs (Struct::Struct): Update constructors accordingly.
28541 (Class::Class): Ditto.
28542 (Field::Field): Ditto.
28543 (Method::Method): Ditto.
28544 (Property::Property): Ditto.
28545 (TypeContainer::OptAttribute): update property's return type.
28547 * interface.cs (Interface.opt_attributes): New member.
28548 (Interface::Interface): Update to take the extra Attributes argument.
28550 * parameter.cs (Parameter::Parameter): Ditto.
28552 * constant.cs (Constant::Constant): Ditto.
28554 * interface.cs (InterfaceMemberBase): New OptAttributes field.
28555 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
28556 the attributes as a parameter.
28557 (InterfaceProperty): Update constructor call.
28558 (InterfaceEvent): Ditto.
28559 (InterfaceMethod): Ditto.
28560 (InterfaceIndexer): Ditto.
28562 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
28563 pass the attributes too.
28564 (interface_event_declaration): Ditto.
28565 (interface_property_declaration): Ditto.
28566 (interface_method_declaration): Ditto.
28567 (interface_declaration): Ditto.
28569 2001-09-05 Miguel de Icaza <miguel@ximian.com>
28571 * class.cs (Method::Define): Track the "static Main" definition to
28572 create an entry point.
28574 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
28575 EntryPoint if we find it.
28577 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
28578 (EmitContext::ig): Make this variable public.
28580 * driver.cs: Make the default output file be the first file name
28581 with the .exe extension.
28583 Detect empty compilations
28585 Handle various kinds of output targets. Handle --target and
28586 rename -t to --dumper.
28588 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
28589 methods inherited from Expression return now an Expression. This
28590 will is used during the tree rewriting as we resolve them during
28593 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
28594 the spec. Missing entirely is the information about
28595 accessability of elements of it.
28597 (Expression::ExprClassFromMemberInfo): New constructor for
28598 Expressions that creates a fully initialized Expression based on
28599 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
28602 (Invocation::Resolve): Begin implementing resolution of invocations.
28604 * literal.cs (StringLiteral): Implement Emit.
28606 2001-09-05 Ravi Pratap <ravi@ximian.com>
28608 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
28611 2001-09-04 Ravi Pratap <ravi@ximian.com>
28613 * cs-parser.jay (attribute_arguments): Implement actions.
28614 (attribute): Fix bug in production. Implement action.
28615 (attribute_list): Implement.
28616 (attribute_target): Implement.
28617 (attribute_target_specifier, opt_target_specifier): Implement
28618 (CheckAttributeTarget): New method to check if the attribute target
28620 (attribute_section): Implement.
28621 (opt_attributes): Implement.
28623 * attribute.cs : New file to handle attributes.
28624 (Attribute): Class to hold attribute info.
28626 * cs-parser.jay (opt_attribute_target_specifier): Remove production
28627 (attribute_section): Modify production to use 2 different rules to
28628 achieve the same thing. 1 s/r conflict down !
28629 Clean out commented, useless, non-reducing dimension_separator rules.
28631 * class.cs (TypeContainer.attributes): New member to hold list
28632 of attributes for a type.
28633 (Struct::Struct): Modify to take one more argument, the attribute list.
28634 (Class::Class): Ditto.
28635 (Field::Field): Ditto.
28636 (Method::Method): Ditto.
28637 (Property::Property): Ditto.
28639 * cs-parser.jay (struct_declaration): Update constructor call to
28640 pass in the attributes too.
28641 (class_declaration): Ditto.
28642 (constant_declaration): Ditto.
28643 (field_declaration): Ditto.
28644 (method_header): Ditto.
28645 (fixed_parameter): Ditto.
28646 (parameter_array): Ditto.
28647 (property_declaration): Ditto.
28649 * constant.cs (Constant::Constant): Update constructor similarly.
28650 Use System.Collections.
28652 * parameter.cs (Parameter::Parameter): Update as above.
28654 2001-09-02 Ravi Pratap <ravi@ximian.com>
28656 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
28657 (TypeContainer.delegates): New member to hold list of delegates.
28659 * cs-parser.jay (delegate_declaration): Implement the action correctly
28660 this time as I seem to be on crack ;-)
28662 2001-09-02 Miguel de Icaza <miguel@ximian.com>
28664 * rootcontext.cs (RootContext::IsNamespace): new function, used to
28665 tell whether an identifier represents a namespace.
28667 * expression.cs (NamespaceExpr): A namespace expression, used only
28668 temporarly during expression resolution.
28669 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
28670 utility functions to resolve names on expressions.
28672 2001-09-01 Miguel de Icaza <miguel@ximian.com>
28674 * codegen.cs: Add hook for StatementExpressions.
28676 * class.cs: Fix inverted test for static flag in methods.
28678 2001-09-02 Ravi Pratap <ravi@ximian.com>
28680 * class.cs (Operator::CheckUnaryOperator): Correct error number used
28681 to make it coincide with MS' number.
28682 (Operator::CheckBinaryOperator): Ditto.
28684 * ../errors/errors.txt : Remove error numbers added earlier.
28686 * ../errors/cs1019.cs : Test case for error # 1019
28688 * ../errros/cs1020.cs : Test case for error # 1020
28690 * cs-parser.jay : Clean out commented cruft.
28691 (dimension_separators, dimension_separator): Comment out. Ostensibly not
28692 used anywhere - non-reducing rule.
28693 (namespace_declarations): Non-reducing rule - comment out.
28695 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
28696 with TypeContainer::AddEnum.
28698 * delegate.cs : New file for delegate handling classes.
28699 (Delegate): Class for declaring delegates.
28701 * makefile : Update.
28703 * cs-parser.jay (delegate_declaration): Implement.
28705 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
28707 * class.cs (Event::Define): Implement.
28708 (Event.EventBuilder): New member.
28710 * class.cs (TypeContainer::Populate): Update to define all enums and events
28712 (Events): New property for the events arraylist we hold. Shouldn't we move to using
28713 readonly fields for all these cases ?
28715 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28717 * class.cs (Property): Revamp to use the convention of making fields readonly.
28718 Accordingly modify code elsewhere.
28720 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
28721 the Define method of the Property class.
28723 * class.cs : Clean up applied patch and update references to variables etc. Fix
28725 (TypeContainer::Populate): Update to define all the properties we have. Also
28726 define all enumerations.
28728 * enum.cs (Define): Implement.
28730 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
28732 * cs-parser.jay (overloadable_operator): The semantic value is an
28733 enum of the Operator class.
28734 (operator_declarator): Implement actions.
28735 (operator_declaration): Implement.
28737 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
28738 validity of definitions.
28739 (Operator::CheckBinaryOperator): Static method to check for binary operators
28740 (TypeContainer::AddOperator): New method to add an operator to a type.
28742 * cs-parser.jay (indexer_declaration): Added line to actually call the
28743 AddIndexer method so it gets added ;-)
28745 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
28746 already taken care of by the MS compiler ?
28748 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28750 * class.cs (Operator): New class for operator declarations.
28751 (Operator::OpType): Enum for the various operators.
28753 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
28755 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
28756 ostensibly handle this in semantic analysis.
28758 * cs-parser.jay (general_catch_clause): Comment out
28759 (specific_catch_clauses, specific_catch_clause): Ditto.
28760 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
28761 (catch_args, opt_catch_args): New productions.
28762 (catch_clause): Rewrite to use the new productions above
28763 (catch_clauses): Modify accordingly.
28764 (opt_catch_clauses): New production to use in try_statement
28765 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
28766 and re-write the code in the actions to extract the specific and
28767 general catch clauses by being a little smart ;-)
28769 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
28770 Hooray, try and catch statements parse fine !
28772 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28774 * statement.cs (Block::GetVariableType): Fix logic to extract the type
28775 string from the hashtable of variables.
28777 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
28778 I end up making that mistake ;-)
28779 (catch_clauses): Fixed gross error which made Key and Value of the
28780 DictionaryEntry the same : $1 !!
28782 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28784 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
28786 * cs-parser.jay (event_declaration): Correct to remove the semicolon
28787 when the add and remove accessors are specified.
28789 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
28791 * cs-parser.jay (IndexerDeclaration): New helper class to hold
28792 information about indexer_declarator.
28793 (indexer_declarator): Implement actions.
28794 (parsing_indexer): New local boolean used to keep track of whether
28795 we are parsing indexers or properties. This is necessary because
28796 implicit_parameters come into picture even for the get accessor in the
28797 case of an indexer.
28798 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
28800 * class.cs (Indexer): New class for indexer declarations.
28801 (TypeContainer::AddIndexer): New method to add an indexer to a type.
28802 (TypeContainer::indexers): New member to hold list of indexers for the
28805 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28807 * cs-parser.jay (add_accessor_declaration): Implement action.
28808 (remove_accessor_declaration): Implement action.
28809 (event_accessors_declaration): Implement
28810 (variable_declarators): swap statements for first rule - trivial.
28812 * class.cs (Event): New class to hold information about event
28814 (TypeContainer::AddEvent): New method to add an event to a type
28815 (TypeContainer::events): New member to hold list of events.
28817 * cs-parser.jay (event_declaration): Implement actions.
28819 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
28821 * cs-parser.jay (dim_separators): Implement. Make it a string
28822 concatenating all the commas together, just as they appear.
28823 (opt_dim_separators): Modify accordingly
28824 (rank_specifiers): Update accordingly. Basically do the same
28825 thing - instead, collect the brackets here.
28826 (opt_rank_sepcifiers): Modify accordingly.
28827 (array_type): Modify to actually return the complete type string
28828 instead of ignoring the rank_specifiers.
28829 (expression_list): Implement to collect the expressions
28830 (variable_initializer): Implement. We make it a list of expressions
28831 essentially so that we can handle the array_initializer case neatly too.
28832 (variable_initializer_list): Implement.
28833 (array_initializer): Make it a list of variable_initializers
28834 (opt_array_initializer): Modify accordingly.
28836 * expression.cs (New::NType): Add enumeration to help us
28837 keep track of whether we have an object/delegate creation
28838 or an array creation.
28839 (New:NewType, New::Rank, New::Indices, New::Initializers): New
28840 members to hold data about array creation.
28841 (New:New): Modify to update NewType
28842 (New:New): New Overloaded contructor for the array creation
28845 * cs-parser.jay (array_creation_expression): Implement to call
28846 the overloaded New constructor.
28848 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
28850 * class.cs (TypeContainer::Constructors): Return member
28851 constructors instead of returning null.
28853 2001-08-26 Miguel de Icaza <miguel@ximian.com>
28855 * typemanager.cs (InitCoreTypes): Initialize the various core
28856 types after we have populated the type manager with the user
28857 defined types (this distinction will be important later while
28858 compiling corlib.dll)
28860 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
28861 on Expression Classification. Now all expressions have a method
28862 `Resolve' and a method `Emit'.
28864 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
28865 generation from working. Also add some temporary debugging
28868 2001-08-24 Miguel de Icaza <miguel@ximian.com>
28870 * codegen.cs: Lots of code generation pieces. This is only the
28871 beginning, will continue tomorrow with more touches of polish. We
28872 handle the fundamentals of if, while, do, for, return. Others are
28873 trickier and I need to start working on invocations soon.
28875 * gen-treedump.cs: Bug fix, use s.Increment here instead of
28878 * codegen.cs (EmitContext): New struct, used during code
28879 emission to keep a context. Most of the code generation will be
28882 * cs-parser.jay: Add embedded blocks to the list of statements of
28883 this block. So code generation proceeds in a top down fashion.
28885 2001-08-23 Miguel de Icaza <miguel@ximian.com>
28887 * statement.cs: Add support for multiple child blocks.
28889 2001-08-22 Miguel de Icaza <miguel@ximian.com>
28891 * codegen.cs (EmitCode): New function, will emit the code for a
28892 Block of code given a TypeContainer and its ILGenerator.
28894 * statement.cs (Block): Standard public readonly optimization.
28895 (Block::Block constructors): Link children.
28896 (Block::Child): Child Linker.
28897 (Block::EmitVariables): Emits IL variable declarations.
28899 * class.cs: Drop support for MethodGroups here, delay until
28901 (Method::): Applied the same simplification that I did before, and
28902 move from Properties to public readonly fields.
28903 (Method::ParameterTypes): Returns the parameter types for the
28904 function, and implements a cache that will be useful later when I
28905 do error checking and the semantic analysis on the methods is
28907 (Constructor::GetCallingConvention): Renamed from CallingConvetion
28908 and made a method, optional argument tells whether this is a class
28909 or a structure to apply the `has-this' bit.
28910 (Method::GetCallingConvention): Implement, returns the calling
28912 (Method::Define): Defines the type, a second pass is performed
28913 later to populate the methods.
28915 (Constructor::ParameterTypes): implement a cache similar to the
28916 one on Method::ParameterTypes, useful later when we do semantic
28919 (TypeContainer::EmitMethod): New method. Emits methods.
28921 * expression.cs: Removed MethodGroup class from here.
28923 * parameter.cs (Parameters::GetCallingConvention): new method.
28925 2001-08-21 Miguel de Icaza <miguel@ximian.com>
28927 * class.cs (TypeContainer::Populate): Drop RootContext from the
28930 (Constructor::CallingConvention): Returns the calling convention.
28931 (Constructor::ParameterTypes): Returns the constructor parameter
28934 (TypeContainer::AddConstructor): Keep track of default constructor
28935 and the default static constructor.
28937 (Constructor::) Another class that starts using `public readonly'
28938 instead of properties.
28940 (Constructor::IsDefault): Whether this is a default constructor.
28942 (Field::) use readonly public fields instead of properties also.
28944 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
28945 track of static constructors; If none is used, turn on
28946 BeforeFieldInit in the TypeAttributes.
28948 * cs-parser.jay (opt_argument_list): now the return can be null
28949 for the cases where there are no arguments.
28951 (constructor_declarator): If there is no implicit `base' or
28952 `this', then invoke the default parent constructor.
28954 * modifiers.cs (MethodAttr): New static function maps a set of
28955 modifiers flags into a MethodAttributes enum
28956 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
28957 MethodAttr, TypeAttr to represent the various mappings where the
28958 modifiers are used.
28959 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
28961 2001-08-19 Miguel de Icaza <miguel@ximian.com>
28963 * parameter.cs (GetParameterInfo): Fix bug where there would be no
28966 * interface.cs (PopulateIndexer): Implemented the code generator
28967 for interface indexers.
28969 2001-08-17 Miguel de Icaza <miguel@ximian.com>
28971 * interface.cs (InterfaceMemberBase): Now we track the new status
28974 (PopulateProperty): Implement property population. Woohoo! Got
28975 Methods and Properties going today.
28977 Removed all the properties for interfaces, and replaced them with
28978 `public readonly' fields.
28980 2001-08-16 Miguel de Icaza <miguel@ximian.com>
28982 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
28983 initialize their hashtables/arraylists only when they are needed
28984 instead of doing this always.
28986 * parameter.cs: Handle refs and out parameters.
28988 * cs-parser.jay: Use an ArrayList to construct the arguments
28989 instead of the ParameterCollection, and then cast that to a
28992 * parameter.cs: Drop the use of ParameterCollection and use
28993 instead arrays of Parameters.
28995 (GetParameterInfo): Use the Type, not the Name when resolving
28998 2001-08-13 Miguel de Icaza <miguel@ximian.com>
29000 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
29001 and instead use public readonly fields.
29003 * class.cs: Put back walking code for type containers.
29005 2001-08-11 Miguel de Icaza <miguel@ximian.com>
29007 * class.cs (MakeConstant): Code to define constants.
29009 * rootcontext.cs (LookupType): New function. Used to locate types
29012 2001-08-08 Miguel de Icaza <miguel@ximian.com>
29014 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
29015 this System.Reflection code is. Kudos to Microsoft
29017 * typemanager.cs: Implement a type cache and avoid loading all
29018 types at boot time. Wrap in LookupType the internals. This made
29019 the compiler so much faster. Wow. I rule!
29021 * driver.cs: Make sure we always load mscorlib first (for
29022 debugging purposes, nothing really important).
29024 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
29025 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
29027 * rootcontext.cs: Lookup types on their namespace; Lookup types
29028 on namespaces that have been imported using the `using' keyword.
29030 * class.cs (TypeContainer::TypeAttr): Virtualize.
29031 (Class::TypeAttr): Return attributes suitable for this bad boy.
29032 (Struct::TypeAttr): ditto.
29033 Handle nested classes.
29034 (TypeContainer::) Remove all the type visiting code, it is now
29035 replaced with the rootcontext.cs code
29037 * rootcontext.cs (GetClassBases): Added support for structs.
29039 2001-08-06 Miguel de Icaza <miguel@ximian.com>
29041 * interface.cs, statement.cs, class.cs, parameter.cs,
29042 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
29043 Drop use of TypeRefs, and use strings instead.
29045 2001-08-04 Miguel de Icaza <miguel@ximian.com>
29049 * class.cs (Struct::Struct): set the SEALED flags after
29050 checking the modifiers.
29051 (TypeContainer::TypeAttr): new property, returns the
29052 TypeAttributes for a class.
29054 * cs-parser.jay (type_list): Oops, list production was creating a
29055 new list of base types.
29057 * rootcontext.cs (StdLib): New property.
29058 (GetInterfaceTypeByName): returns an interface by type name, and
29059 encapsulates error handling here.
29060 (GetInterfaces): simplified.
29061 (ResolveTree): Encapsulated all the tree resolution here.
29062 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
29065 * driver.cs: Add support for --nostdlib, to avoid loading the
29066 default assemblies.
29067 (Main): Do not put tree resolution here.
29069 * rootcontext.cs: Beginning of the class resolution.
29071 2001-08-03 Miguel de Icaza <miguel@ximian.com>
29073 * rootcontext.cs: Provide better error reporting.
29075 * cs-parser.jay (interface_base): set our $$ to be interfaces.
29077 * rootcontext.cs (CreateInterface): Handle the case where there
29078 are no parent interfaces.
29080 (CloseTypes): Routine to flush types at the end.
29081 (CreateInterface): Track types.
29082 (GetInterfaces): Returns an array of Types from the list of
29083 defined interfaces.
29085 * typemanager.c (AddUserType): Mechanism to track user types (puts
29086 the type on the global type hash, and allows us to close it at the
29089 2001-08-02 Miguel de Icaza <miguel@ximian.com>
29091 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
29092 RecordInterface instead.
29094 * cs-parser.jay: Updated to reflect changes above.
29096 * decl.cs (Definition): Keep track of the TypeBuilder type that
29097 represents this type here. Not sure we will use it in the long
29098 run, but wont hurt for now.
29100 * driver.cs: Smaller changes to accomodate the new code.
29102 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
29105 * rootcontext.cs (CreateInterface): New method, used to create
29106 the System.TypeBuilder type for interfaces.
29107 (ResolveInterfaces): new entry point to resolve the interface
29109 (CodeGen): Property, used to keep track of the code generator.
29111 2001-07-26 Miguel de Icaza <miguel@ximian.com>
29113 * cs-parser.jay: Add a second production for delegate_declaration
29116 (enum_body): Put an opt_comma here instead of putting it on
29117 enum_body or enum_member_declarations so we can handle trailing
29118 commas on enumeration members. Gets rid of a shift/reduce.
29120 (type_list): Need a COMMA in the middle.
29122 (indexer_declaration): Tell tokenizer to recognize get/set
29124 * Remove old targets.
29126 * Re-add the parser target.
29128 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29130 * cs-parser.jay: Add precendence rules for a number of operators
29131 ot reduce the number of shift/reduce conflicts in the grammar.
29133 2001-07-17 Miguel de Icaza <miguel@ximian.com>
29135 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
29138 Get rid of old crufty code.
29140 * rootcontext.cs: Use this to keep track of the parsed
29141 representation and the defined types available to the program.
29143 * gen-treedump.cs: adjust for new convention.
29145 * type.cs: Split out the type manager, and the assembly builder
29148 * typemanager.cs: the type manager will live here now.
29150 * cil-codegen.cs: And the code generator here.
29152 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
29154 * makefile: Fixed up for easy making.
29156 2001-07-13 Simon Cozens <simon@simon-cozens.org>
29158 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
29161 (unary_expression): Expand pre_increment_expression and
29162 post_decrement_expression to reduce a shift/reduce.
29164 2001-07-11 Simon Cozens
29166 * cs-tokenizer.cs: Hex numbers should begin with a 0.
29168 Improve allow_keyword_as_indent name.
29170 2001-06-19 Miguel de Icaza <miguel@ximian.com>
29172 * Adjustments for Beta2.
29174 2001-06-13 Miguel de Icaza <miguel@ximian.com>
29176 * decl.cs: Added `Define' abstract method.
29177 (InTransit): new property, used to catch recursive definitions.
29179 * interface.cs: Implement `Define'.
29181 * modifiers.cs: Map Modifiers.constants to
29182 System.Reflection.TypeAttribute flags.
29184 * class.cs: Keep track of types and user-defined types.
29185 (BuilderInit): New method for creating an assembly
29186 (ResolveType): New function to launch the resolution process, only
29187 used by interfaces for now.
29189 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
29190 that are inserted into the name space.
29192 2001-06-08 Miguel de Icaza <miguel@ximian.com>
29194 * ARGH. I have screwed up my tree so many times due to the use of
29195 rsync rather than using CVS. Going to fix this at once.
29197 * driver.cs: Objetify driver. Load assemblies, use assemblies to
29200 2001-06-07 Miguel de Icaza <miguel@ximian.com>
29202 * Experiment successful: Use System.Type rather that our own
29205 2001-05-25 Miguel de Icaza <miguel@ximian.com>
29207 * cs-parser.jay: Removed nsAliases from here.
29209 Use new namespaces, handle `using XXX;'
29211 * namespace.cs: Reimplemented namespace handling, use a recursive
29212 definition of the class. Now we can keep track of using clauses
29213 and catch invalid using clauses.
29215 2001-05-24 Miguel de Icaza <miguel@ximian.com>
29217 * gen-treedump.cs: Adapted for all the renaming.
29219 * expression.cs (Expression): this class now has a Type property
29220 which returns an expression Type.
29222 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
29223 `Type', as this has a different meaning now in the base
29225 2001-05-22 Miguel de Icaza <miguel@ximian.com>
29227 * interface.cs, class.cs: Removed from all the sources the
29228 references to signature computation, as we can not do method
29229 signature computation during the parsing time, as we are not
29230 trying to solve at that point distinguishing:
29234 void a (NS.Blah x) {}
29237 Which depending on the context might be valid or not, as we do not
29238 know if Blah is the same thing as NS.Blah at that point.
29240 * Redid everything so the code uses TypeRefs now instead of
29241 Types. TypeRefs are just temporary type placeholders, that need
29242 to be resolved. They initially have a pointer to a string and the
29243 current scope in which they are used. This is used later by the
29244 compiler to resolve the reference to an actual Type.
29246 * DeclSpace is no longer a CIR.Type, and neither are
29247 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
29248 are all DeclSpaces, but no Types.
29250 * type.cs (TypeRefManager): This implements the TypeRef manager,
29251 which keeps track of all the types that need to be resolved after
29252 the parsing has finished.
29254 2001-05-13 Miguel de Icaza <miguel@ximian.com>
29256 * ARGH. We are going to have to store `foreach' as a class rather
29257 than resolving it, as we need to verify error 1579 after name
29258 resolution. *OR* we could keep a flag that says `This request to
29259 IEnumerator comes from a foreach statement' which we can then use
29260 to generate the error.
29262 2001-05-10 Miguel de Icaza <miguel@ximian.com>
29264 * class.cs (TypeContainer.AddMethod): we now add methods to the
29265 MethodGroup instead of the method hashtable.
29267 * expression.cs: Add MethodGroup abstraction, which gets us one
29268 step closer to the specification in the way we handle method
29271 * cs-parser.jay (primary_expression): qualified_identifier now
29272 tried to match up an identifier to a local variable reference or
29273 to a parameter reference.
29275 current_local_parameters is now a parser global variable that
29276 points to the current parameters for the block, used during name
29279 (property_declaration): Now creates an implicit `value' argument to
29282 2001-05-09 Miguel de Icaza <miguel@ximian.com>
29284 * parameter.cs: Do not use `param' arguments as part of the
29285 signature, per the spec.
29287 2001-05-08 Miguel de Icaza <miguel@ximian.com>
29289 * decl.cs: Base class for classes, structs and interfaces. This
29290 is the "Declaration Space"
29292 * cs-parser.jay: Use CheckDef for checking declaration errors
29293 instead of having one on each function.
29295 * class.cs: Factor out some code for handling error handling in
29296 accordance to the "Declarations" section in the "Basic Concepts"
29297 chapter in the ECMA C# spec.
29299 * interface.cs: Make all interface member classes derive from
29300 InterfaceMemberBase.
29302 2001-05-07 Miguel de Icaza <miguel@ximian.com>
29304 * Many things: all interfaces are parsed and generated in
29305 gen-treedump. Support for member variables, constructors,
29306 destructors, properties, constants is there.
29308 Beginning of the IL backend, but very little done, just there for
29311 2001-04-29 Miguel de Icaza <miguel@ximian.com>
29313 * cs-parser.jay: Fix labeled statement.
29315 * cs-tokenizer.cs (escape): Escape " and ' always.
29316 ref_line, ref_name: keep track of the line/filename as instructed
29317 by #line by the compiler.
29320 2001-04-27 Miguel de Icaza <miguel@ximian.com>
29322 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
29323 to match the values in System.CodeDOM.
29325 Divid renamed to Divide.
29327 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
29329 (Statements.set): remove.
29331 * System.CodeDOM/CodeCatchClause.cs: always have a valid
29334 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
29335 falseStatements always have valid values.
29337 * cs-parser.jay: Use System.CodeDOM now.